gdb/ChangeLog

   1 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
   2
   3         * tracectf.h: Rename, was ctf.h.
   4         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
   5         * tracefile.c: Likewise.
   6         * tracepoint.c: Remove unused include ctf.h.
   7         * mi/mi-main.c: Likewise.
   8         * Makefile.in Replace ctf.c with tracectf.c.
   9
  10 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
  11
  12         * version.in: Change version number to "9.0.50.DATE-git".
  13
  14 2019-10-03  Tom Tromey  <tom@tromey.com>
  15
  16         PR rust/24976:
  17         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
  18
  19 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  20
  21         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
  22         cp_search_name_hash.
  23         * NEWS: Add entry about nested function support.
  24
  25 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
  26             Andrew Burgess  <andrew.burgess@embecosm.com>
  27
  28         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
  29         for nested static variables when searchin VAR_DOMAIN.
  30         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
  31         global scope, update comment.
  32         (add_partial_subprogram): Call add_partial_subprogram recursively
  33         for nested subroutines when processinng Fortran.
  34         (load_partial_dies): Process the child entities of a subprogram
  35         when processing Fortran.
  36         (partial_die_parent_scope): Handle building scope
  37         for Fortran nested functions.
  38         (process_die): Record that nested functions have a scope.
  39         (new_symbol): Always record Fortran subprograms on the global
  40         symbol list.
  41         (determine_prefix): How to build the prefix for Fortran
  42         subprograms.
  43
  44 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  45
  46         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
  47         have just sent the thread a SIGSTOP and are waiting for it to
  48         arrive.
  49
  50 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  51
  52         * btrace.c (btrace_add_pc): Remove whitespace before the template
  53         parameter in 'std::vector <...>'.
  54         (parse_xml_btrace_block): Likewise.
  55         (btrace_maint_decode_pt): Likewise.
  56         (btrace_maint_update_packets): Likewise.
  57         (btrace_maint_print_packets): Likewise.
  58         * btrace.h (struct btrace_maint_info): Likewise.
  59         * dwarf2read.c (struct type_unit_group): Likewise.
  60         (build_type_psymtabs_reader): Likewise.
  61         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
  62         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
  63         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
  64
  65 2019-10-03  Tom de Vries  <tdevries@suse.de>
  66
  67         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
  68         the first line of the help text for set/show style metadata.
  69
  70 2019-10-02  Tom Tromey  <tromey@adacore.com>
  71
  72         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
  73         * gdbsupport/common-inferior.c: New file.
  74         * infcmd.c (startup_with_shell): Don't define.
  75         * nat/fork-inferior.h (startup_with_shell): Don't declare.
  76         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
  77         * inferior.h (startup_with_shell): Don't declare.
  78
  79 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
  80
  81         * gdbsupport/gdb_assert.h: Include errors.h.
  82         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
  83
  84 2019-10-02  Tom Tromey  <tromey@adacore.com>
  85
  86         * NEWS: Add $_ada_exception entry.
  87         * ada-lang.c (struct ada_catchpoint): Add constructor.
  88         <m_kind>: New member.
  89         (allocate_location_exception, re_set_exception): Remove
  90         "ex" parameter.
  91         (should_stop_exception): Compute $_ada_exception.
  92         (check_status_exception, print_it_exception)
  93         (print_one_exception, print_mention_exception): Remove
  94         "ex" parameter.
  95         (allocate_location_catch_exception, re_set_catch_exception)
  96         (check_status_exception, print_it_catch_exception)
  97         (print_one_catch_exception, print_mention_catch_exception)
  98         (print_recreate_catch_exception)
  99         (allocate_location_catch_exception_unhandled)
 100         (re_set_catch_exception_unhandled)
 101         (check_status_exception, print_it_catch_exception_unhandled)
 102         (print_one_catch_exception_unhandled)
 103         (print_mention_catch_exception_unhandled)
 104         (print_recreate_catch_exception_unhandled)
 105         (allocate_location_catch_assert, re_set_catch_assert)
 106         (check_status_assert, print_it_catch_assert)
 107         (print_one_catch_assert, print_mention_catch_assert)
 108         (print_recreate_catch_assert)
 109         (allocate_location_catch_handlers, re_set_catch_handlers)
 110         (check_status_handlers, print_it_catch_handlers)
 111         (print_one_catch_handlers, print_mention_catch_handlers)
 112         (print_recreate_catch_handlers): Remove.
 113         (create_ada_exception_catchpoint): Update.
 114         (initialize_ada_catchpoint_ops): Update.
 115
 116 2019-10-02  Tom Tromey  <tromey@adacore.com>
 117
 118         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 119         (create_excep_cond_exprs): Simplify exception string computation.
 120         (ada_exception_catchpoint_cond_string): Likewise.
 121
 122 2019-10-02  Tom Tromey  <tromey@adacore.com>
 123
 124         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 125         * ada-lang.c (lesseq_defined_than): Handle
 126         LOC_STATIC.
 127         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 128         parameter.
 129         (dwarf2_has_info): Likewise.
 130         (new_symbol): Set maybe_copied on symbol when
 131         appropriate.
 132         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 133         parameter.
 134         <can_copy>: New member.
 135         * elfread.c (record_minimal_symbol): Set maybe_copied
 136         on symbol when appropriate.
 137         (elf_symfile_read): Update call to dwarf2_has_info.
 138         * minsyms.c (lookup_minimal_symbol_linkage): New
 139         function.
 140         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 141         * symtab.c (get_symbol_address, get_msymbol_address):
 142         New functions.
 143         * symtab.h (get_symbol_address, get_msymbol_address):
 144         Declare.
 145         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 146         maybe_copied.
 147         (struct symbol, struct minimal_symbol) <maybe_copied>:
 148         New member.
 149
 150 2019-10-02  Tom Tromey  <tromey@adacore.com>
 151
 152         * source.c (struct current_source_location): New.
 153         (current_source_key): New global.
 154         (current_source_symtab, current_source_line)
 155         (current_source_pspace): Remove.
 156         (get_source_location): New function.
 157         (get_current_source_symtab_and_line)
 158         (set_default_source_symtab_and_line)
 159         (set_current_source_symtab_and_line)
 160         (clear_current_source_symtab_and_line, select_source_symtab)
 161         (info_source_command, print_source_lines_base)
 162         (info_line_command, search_command_helper, _initialize_source):
 163         Update.
 164
 165 2019-10-02  Tom Tromey  <tromey@adacore.com>
 166
 167         * source.c (select_source_symtab): Don't call
 168         decode_line_with_current_source.
 169
 170 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 171
 172         * symtab.c (lookup_global_symbol): Search global block.
 173
 174 2019-10-02  Tom Tromey  <tromey@adacore.com>
 175
 176         * coffread.c (process_coff_symbol): Update.
 177         * dwarf2read.c (var_decode_location, new_symbol): Update.
 178         * mdebugread.c (parse_symbol): Update.
 179         * objfiles.c (relocate_one_symbol): Update.
 180         * stabsread.c (define_symbol, fix_common_block)
 181         (scan_file_globals): Update.
 182         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 183         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 184         * xcoffread.c (process_xcoff_symbol): Update.
 185
 186 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 187
 188         * MAINTAINERS: Update my email address.
 189
 190 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 191
 192         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 193         std::vector.
 194         (build_type_psymtabs_reader): Update for std::vector.
 195         (build_type_psymtab_dependencies): Likewise.
 196         * dwarf2read.h: Remove use of DEF_VEC_P.
 197         (typedef sig_type_ptr): Delete.
 198
 199 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 200
 201         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 202         to std::vector.
 203         (btrace_maint_decode_pt): Likewise, and move allocation of the
 204         vector outside of the loop.
 205         (btrace_maint_update_packets): Update to handle change from VEC to
 206         std::vector.
 207         (btrace_maint_print_packets): Likewise.
 208         (maint_info_btrace_cmd): Likewise.
 209         * btrace.h: Remove use of DEF_VEC_O.
 210         (typedef btrace_pt_packet_s): Delete.
 211         (struct btrace_maint_info) <packets>: Change fromm VEC to
 212         std::vector.
 213         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 214
 215 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 216
 217         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 218         make accesses into the vector constant references.
 219         (btrace_add_pc): Update for std::vector.
 220         (btrace_stitch_bts): Likewise.
 221         (parse_xml_btrace_block): Likewise.
 222         (btrace_maint_update_packets): Likewise.
 223         (btrace_maint_print_packets): Likewise.
 224         (maint_info_btrace_cmd): Likewise.
 225         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 226         std::vector.
 227         (btrace_data::empty): Likewise.
 228         (btrace_data_append): Likewise.
 229         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 230         (typedef btrace_block_s): Delete.
 231         (struct btrace_block): Add constructor.
 232         (struct btrace_data_bts) <blocks>: Change to std::vector.
 233         * nat/linux-btrace.c (perf_event_read_bts): Update for
 234         std::vector.
 235         (linux_read_bts): Likewise.
 236
 237 2019-10-01  Tom Tromey  <tom@tromey.com>
 238
 239         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 240
 241 2019-10-01  Tom Tromey  <tom@tromey.com>
 242
 243         * stack.c (print_frame, info_frame_command_core): Use
 244         styled_string.
 245         * linux-thread-db.c (try_thread_db_load_1)
 246         (try_thread_db_load_from_pdir_1): Use styled_string.
 247         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 248         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 249         (maybe_print_unsupported_script_warning)
 250         (maybe_print_script_not_found_warning): Use styled_string.
 251         * ada-lang.c (user_select_syms): Use styled_string.
 252
 253 2019-10-01  Tom Tromey  <tom@tromey.com>
 254
 255         * p-lang.c (pascal_printstr): Use metadata style.
 256         * value.c (show_convenience): Use metadata style.
 257         * valprint.c (valprint_check_validity, val_print_optimized_out)
 258         (val_print_not_saved, val_print_unavailable)
 259         (val_print_invalid_address, generic_val_print, val_print)
 260         (value_check_printable, val_print_array_elements): Use metadata
 261         style.
 262         * ui-out.h (class ui_out) <field_fmt>: New overload.
 263         <do_field_fmt>: Add style parameter.
 264         * ui-out.c (ui_out::field_fmt): New overload.
 265         * typeprint.c (type_print_unknown_return_type)
 266         (val_print_not_allocated, val_print_not_associated): Use metadata
 267         style.
 268         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 269         parameter.
 270         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 271         * tracepoint.c (tvariables_info_1): Use metadata style.
 272         * stack.c (print_frame_arg, print_frame_info, print_frame)
 273         (info_frame_command_core): Use metadata style.
 274         * skip.c (info_skip_command): Use metadata style.
 275         * rust-lang.c (rust_print_enum): Use metadata style.
 276         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 277         metadata style.
 278         * python/py-framefilter.c (py_print_single_arg): Use metadata
 279         style.
 280         * printcmd.c (do_one_display, print_variable_and_value): Use
 281         metadata style.
 282         * p-valprint.c (pascal_val_print)
 283         (pascal_object_print_value_fields): Use metadata style.
 284         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 285         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 286         parameter.
 287         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 288         * m2-valprint.c (m2_print_long_set): Use metadata style.
 289         * m2-typeprint.c (m2_print_type): Use metadata style.
 290         * infcmd.c (print_return_value_1): Use metadata style.
 291         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 292         * f-valprint.c (info_common_command_for_block): Use metadata
 293         style.
 294         * f-typeprint.c (f_type_print_base): Use metadata style.
 295         * expprint.c (print_subexp_standard): Use metadata style.
 296         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 297         * cli/cli-style.h (class cli_style_option): Add constructor.
 298         (metadata_style): Declare.
 299         * cli/cli-style.c (metadata_style): New global.
 300         (_initialize_cli_style): Register metadata style.
 301         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 302         parameter.
 303         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 304         * c-typeprint.c (c_type_print_base_struct_union)
 305         (c_type_print_base_1): Use metadata style.
 306         * breakpoint.c (watchpoint_value_print)
 307         (print_one_breakpoint_location): Use metadata style.
 308         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 309         style.
 310         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 311         style.
 312         * ada-valprint.c (val_print_packed_array_elements, printstr)
 313         (print_field_values, ada_val_print_ref, ada_val_print): Use
 314         metadata style.
 315         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 316         style.
 317         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 318         style.
 319         * ada-lang.c (user_select_syms): Use metadata style.
 320
 321 2019-10-01  Tom Tromey  <tom@tromey.com>
 322
 323         * cli/cli-cmds.c (pwd_command): Style output.
 324
 325 2019-10-01  Pedro Alves  <palves@redhat.com>
 326             Tom Tromey  <tom@tromey.com>
 327
 328         * symtab.c (print_symbol_info): Use %ps.
 329         (print_msymbol_info): Use %ps.
 330         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 331         * printcmd.c (print_variable_and_value): Use %ps.
 332         * macrocmd.c (show_pp_source_pos): Use %ps.
 333         * infrun.c (print_exited_reason): Use ui_out::message.
 334         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 335         (describe_other_breakpoints): Use ui_out::message and new
 336         formats.
 337         (say_where): Use new formats.
 338         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 339         and new formats.
 340
 341 2019-10-01  Pedro Alves  <palves@redhat.com>
 342             Tom Tromey  <tom@tromey.com>
 343
 344         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 345         (test_gdb_formats): New function.
 346         (run_tests): Call it.
 347         (test_format_specifier): Update.
 348         * utils.h (fputs_filtered): Update comment.
 349         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 350         (fputs_styled_unfiltered): Declare.
 351         * utils.c (fputs_styled_unfiltered): New function.
 352         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 353         (vfprintf_filtered): Update.
 354         (vfprintf_unfiltered, vprintf_filtered): Update.
 355         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 356         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 357         disallow_ui_out_field>: New constants.
 358         (enum class field_kind): New.
 359         (struct base_field_s, struct signed_field_s): New.
 360         (signed_field): New function.
 361         (struct string_field_s): New.
 362         (string_field): New function.
 363         (struct styled_string_s): New.
 364         (styled_string): New function.
 365         (class ui_out) <message>: Add comment.
 366         <vmessage, call_do_message>: New methods.
 367         <do_message>: Add style parameter.
 368         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 369         methods.
 370         (ui_out::message): Rewrite.
 371         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 372         parameter.
 373         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 374         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 375         gdb_extensions parameter.
 376         (class format_piece): Add parameter to constructor.
 377         (n_int_args): New field.
 378         * gdbsupport/format.c (format_pieces::format_pieces): Add
 379         gdb_extensions parameter.  Handle '*'.
 380         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 381         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 382         vfprintf_styled_no_gdbfmt.
 383         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 384         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 385         unfiltered output.
 386         * ui-style.h (struct ui_file_style) <ptr>: New method.
 387
 388 2019-10-01  Tom Tromey  <tom@tromey.com>
 389
 390         * unittests/format_pieces-selftests.c: Update.  Add final format.
 391         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 392         empty literal pieces.
 393
 394 2019-10-01  Tom Tromey  <tom@tromey.com>
 395
 396         * ui-out.h (enum class ui_out_style_kind): Remove.
 397         (class ui_out) <field_string, field_stsream, do_field_string>:
 398         Change type of "style".
 399         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 400         (ui_out::field_string): Update.
 401         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 402         of "style".
 403         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 404         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 405         * stack.c (print_frame_arg, print_frame_info, print_frame):
 406         Update.
 407         * source.c (print_source_lines_base): Update.
 408         * solib.c (info_sharedlibrary_command): Update.
 409         * skip.c (info_skip_command): Update.
 410         * record-btrace.c (btrace_call_history_src_line)
 411         (btrace_call_history): Update.
 412         * python/py-framefilter.c (py_print_frame): Update.
 413         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 414         "style".
 415         * mi/mi-out.c (mi_ui_out::do_table_header)
 416         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 417         (mi_ui_out::do_field_string): Update.
 418         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 419         Update.
 420         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 421         "style".
 422         * cli-out.c (cli_ui_out::do_table_header)
 423         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 424         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 425         (cli_ui_out::do_field_fmt): Update.
 426         * breakpoint.c (print_breakpoint_location): Update.
 427         (update_static_tracepoint): Update.
 428
 429 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 430
 431         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 432         conversion of gdb_datadir.
 433         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 434         remove not needed c_str ().
 435
 436 2019-09-30  Ali Tamur <tamur@google.com>
 437
 438         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 439         (dwarf2_string_attr): Likewise.
 440
 441 2019-09-30  Ali Tamur <tamur@google.com>
 442
 443         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 444         (process_full_type_unit): Likewise.
 445         (dump_die_shallow): Likewise.
 446         (cu_debug_loc_section): Likewise.
 447
 448 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 449
 450         * minsyms.c (compare_minimal_symbols): Rename to...
 451         (minimal_symbol_is_less_than): ...this, and adjust to STL
 452         conventions (return bool, take arguments as references)
 453         (minimal_symbol_reader::install): Call std::sort instead
 454         of qsort.
 455
 456 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 457
 458         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 459         hash and why.
 460         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 461         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 462
 463 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 464
 465         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 466         * psympriv.h (add_psymbol_to_list): Move comment here and update
 467         it.
 468
 469 2019-09-29  Tom de Vries  <tdevries@suse.de>
 470
 471         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 472         Use $tmpdir/$(basename "$output_file").dwz instead of
 473         "${output_file}.dwz".
 474
 475 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 476
 477         PR gdb/25045
 478         * hppa-linux-nat.c: Include gdbarch.h.
 479
 480 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 481
 482         * blockframe.c (find_pc_partial_function): Change return type to bool.
 483         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 484         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 485         (stub_gnu_ifunc_resolve_name): Likewise.
 486         * symtab.c (compare_filenames_for_search): Likewise.
 487         (compare_glob_filenames_for_search): Likewise.
 488         (matching_obj_sections): Likewise.
 489         (symbol_matches_domain): Likewise.
 490         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 491         (find_line_pc): Change return type to bool.
 492         (find_line_pc_range): Likewise.
 493         (producer_is_realview): Likewise.
 494         * symtab.h (symbol_matches_domain): Likewise.
 495         (find_pc_partial_function): Likewise.
 496         (find_pc_line_pc_range): Likewise.
 497         (in_gnu_ifunc_stub): Likewise.
 498         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 499         (find_line_pc): Likewise.
 500         (find_line_pc_range): Likewise.
 501         (matching_obj_sections): Likewise.
 502         (find_line_symtab): Change out parameter to bool.
 503         (producer_is_realview): Change return type to bool.
 504         (compare_filenames_for_search): Likewise.
 505         (compare_glob_filenames_for_search): Likewise.
 506
 507 2019-09-26  Tom Tromey  <tom@tromey.com>
 508
 509         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 510         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 511         * gdb_usleep.h: Remove.
 512         * gdb_usleep.c: Remove.
 513         * utils.c: Don't include gdb_usleep.h.
 514
 515 2019-09-26  Tom Tromey  <tromey@adacore.com>
 516
 517         * python/py-type.c (type_to_type_object): Call check_typedef
 518         for stub types.
 519
 520 2019-09-26  Tom Tromey  <tom@tromey.com>
 521
 522         * utils.h (initialize_utils): Don't declare.
 523         * top.c (gdb_init): Don't call initialize_utils.
 524         * utils.c (initialize_utils): Remove.  Move contents...
 525         (_initialize_utils): ... here.
 526
 527 2019-09-25  Tom Tromey  <tom@tromey.com>
 528
 529         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 530         * utils.h (make_hex_string): Don't declare.
 531         * utils.c (make_hex_string): Remove.
 532
 533 2019-09-24  Tom de Vries  <tdevries@suse.de>
 534
 535         PR gdb/23815
 536         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 537         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 538
 539 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 540
 541         * NEWS: Mention new simulator port for PRU.
 542
 543 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 544
 545         * ada-exp.y (write_object_remaining): Update.
 546         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 547         and eliminate the static buffer.
 548         (ada_decode_symbol): Update.
 549         (ada_la_decode): Update.
 550         (ada_sniff_from_mangled_name): Update.
 551         (is_valid_name_for_wild_match): Update.
 552         (ada_lookup_name_info::matches): Update and simplify.
 553         (name_matches_regex): Update.
 554         (ada_add_global_exceptions): Update.
 555         * ada-lang.h (ada_decode): Update signature.
 556         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 557         * dwarf-index-write.c (debug_names::insert): Update.
 558
 559 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 560
 561         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 562         formatting.
 563
 564 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 565
 566         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 567         Change "nonzero" to "true" in documentation.
 568
 569 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 570
 571         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 572         (_initialize_darwin_solib): Don't set
 573         darwin_so_ops.lookup_lib_global_symbol.
 574         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 575         set_gdbarch_iterate_over_objfiles_in_search_order.
 576         (elf_lookup_lib_symbol): Rename to...
 577         (svr4_iterate_over_objfiles_in_search_order): this, and update
 578         to iterate semantics.
 579         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 580         * solib.c (solib_global_lookup): Remove.
 581         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 582         (solib_global_lookup): Remove.
 583         * symtab.c (lookup_global_or_static_symbol): Remove call to
 584         solib_global_lookup.
 585
 586 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 587
 588         * NEWS: Move entries about default MI version now being
 589         version 3, and about the GDB/MI fix for multi-location
 590         breakpoints to the "since GDB 8.3" section.
 591
 592 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 593
 594         GDB 8.3.1 released.
 595
 596 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 597
 598         * NEWS: Mention that Cell/B.E. debugging support was removed.
 599         * MAINTAINERS: Remove spu target.
 600
 601         * config/djgpp/fnchange.lst: Remove entries for removed files.
 602
 603         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 604         spu-multiarch.o, and spu-tdep.o.
 605         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 606         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 607         spu-multiarch.c, and spu-tdep.c.
 608         * spu-linux-nat.c: Remove file.
 609         * spu-multiarch.c: Remove file.
 610         * spu-tdep.c: Remove file.
 611         * spu-tdep.h: Remove file.
 612         * solib-spu.c: Remove file.
 613         * solib-spu.h: Remove file.
 614
 615         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 616         * configure.nat (spu-linux): Remove.
 617         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 618         solib-multiarch.o from gdb_target_obs.
 619         (spu*-*-*): Remove.
 620
 621         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 622         feature flag.
 623         (ppc_linux_no_features): Update.
 624         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 625         Cell/B.E. support.
 626         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 627         (tdesc_powerpc_cell64l): Likewise.
 628         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 629         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 630         Cell/B.E. support.
 631         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 632         Do not include "features/rs6000/powerpc-cell32l.c" or
 633         "features/rs6000/powerpc-cell64l.c".
 634         (ppc_linux_spu_section): Remove.
 635         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 636         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 637         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 638         (ppc_linux_spe_context_lookup): Remove.
 639         (ppc_linux_spe_context_inferior_created): Remove.
 640         (ppc_linux_spe_context_solib_loaded): Remove.
 641         (ppc_linux_spe_context_solib_unloaded): Remove.
 642         (ppc_linux_spe_context): Remove.
 643         (struct ppu2spu_cache): Remove.
 644         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 645         (struct ppu2spu_data): Remove.
 646         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 647         ppu2spu_unwind): Remove.
 648         (ppc_linux_init_abi): Remove Cell/B.E. support.
 649         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 650
 651         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 652         (rs6000/powerpc-cell64l-expedite): Likewise
 653         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 654         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 655         rs6000/powerpc-cell64l.xml.
 656         * features/rs6000/powerpc-cell32l.xml: Remove.
 657         * features/rs6000/powerpc-cell64l.xml: Likewise.
 658         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 659         * features/rs6000/powerpc-cell64l.c: Likewise.
 660         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 661         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 662         * regformats/reg-spu.dat: Remove.
 663
 664         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 665         * corelow.c (struct spuid_list): Remove.
 666         (add_to_spuid_list): Remove.
 667         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 668         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 669         (remote_protocol_features): Remove associated entries.
 670         (_initialize_remote): No longer initialize them.
 671         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 672         * linux-nat.c (SPUFS_MAGIC): Remove.
 673         (linux_proc_xfer_spu): Remove.
 674         (spu_enumerate_spu_ids): Remove.
 675         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 676         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 677         (linux_make_corefile_notes): No longer call it.
 678
 679         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 680         (cooked_write_test): Likewise.
 681
 682 2019-09-20  Tom Tromey  <tom@tromey.com>
 683
 684         * NEWS: Mention case-sensitivity of TUI commands.
 685         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 686         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 687         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 688
 689 2019-09-20  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-source.c (tui_source_window::set_contents): Use
 692         make_unique_xstrdup.
 693         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 694         make_unique_xstrdup.
 695
 696 2019-09-20  Tom Tromey  <tom@tromey.com>
 697
 698         * tui/tui-data.c: Remove separator comments.
 699         * tui/tui-layout.c: Remove separator comments.
 700         * tui/tui-win.c: Remove separator comments.
 701         * tui/tui-wingeneral.c: Remove separator comments.
 702
 703 2019-09-20  Tom Tromey  <tom@tromey.com>
 704
 705         * tui/tui.h (strcat_to_buf): Don't declare.
 706         * tui/tui.c (strcat_to_buf): Remove.
 707
 708 2019-09-20  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 711         from "fullname".
 712         * tui/tui-source.c (tui_source_window::set_contents)
 713         (tui_source_window::location_matches_p)
 714         (tui_source_window::maybe_update): Update.
 715
 716 2019-09-20  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 719         Update.
 720         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 721         prefix.
 722         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 723         (tui_data_window::line_from_reg_element_no)
 724         (tui_data_window::first_reg_element_no_inline)
 725         (tui_data_window::show_registers)
 726         (tui_data_window::show_register_group)
 727         (tui_data_window::display_registers_from)
 728         (tui_data_window::display_registers_from_line)
 729         (tui_data_window::first_data_item_displayed)
 730         (tui_data_window::delete_data_content_windows)
 731         (tui_data_window::erase_data_content)
 732         (tui_data_window::do_scroll_vertical)
 733         (tui_data_window::refresh_window)
 734         (tui_data_window::check_register_values): Update.
 735
 736 2019-09-20  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 739         (struct tui_locator_window) <full_name, proc_name>: Now
 740         std::string.
 741         * tui/tui-stack.c (tui_locator_window::make_status_line)
 742         (tui_locator_window::set_locator_fullname)
 743         (tui_locator_window::set_locator_info): Update.
 744         * tui/tui-source.c (tui_source_window::set_contents)
 745         (tui_source_window::showing_source_p): Update.
 746
 747 2019-09-20  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 750         Don't call tui_locator_win_info_ptr.
 751
 752 2019-09-20  Tom Tromey  <tom@tromey.com>
 753
 754         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 755
 756 2019-09-20  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 759         height for locator.
 760         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 761         * tui/tui-layout.c (show_source_disasm_command, show_data)
 762         (show_source_or_disasm_and_command): Use 1 as height for locator.
 763
 764 2019-09-20  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui.c (tui_enable): Update.
 767         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 768         Update.
 769         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 770         Update.
 771         * tui/tui-data.c (win_resized): Now bool.
 772         (tui_win_resized): Return bool.
 773         (tui_set_win_resized_to): Accept a bool.
 774
 775 2019-09-20  Tom Tromey  <tom@tromey.com>
 776
 777         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 778         Change type of "refresh_values_only".
 779         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 780         type of "refresh_values_only".
 781
 782 2019-09-20  Tom Tromey  <tom@tromey.com>
 783
 784         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 785         std::string.
 786         (tui_disassemble): Add "pos" parameter.
 787         (tui_disasm_window::set_contents): Simplify.
 788
 789 2019-09-20  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-winsource.h (struct tui_source_window_base)
 792         <show_source_content>: Now private.
 793         * tui/tui-winsource.c
 794         (tui_source_window_base::show_source_content): Don't handle empty
 795         content case.
 796
 797 2019-09-20  Tom Tromey  <tom@tromey.com>
 798
 799         * tui/tui-layout.c (show_source_disasm_command)
 800         (show_source_or_disasm_and_command): Don't call
 801         show_source_content.
 802
 803 2019-09-20  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 806         Declare.
 807         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 808         from tui_make_status_line.
 809         (tui_locator_window::rerender): Update.
 810
 811 2019-09-20  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 814         (tui_locator_window::rerender): Update.
 815
 816 2019-09-20  Tom Tromey  <tom@tromey.com>
 817
 818         * tui/tui-winsource.h (struct tui_source_window_base)
 819         <~tui_source_window_base>: Don't declare.
 820         <fullname>: Remove.
 821         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 822         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 823         member.
 824         * tui/tui-source.c (tui_source_window::set_contents): Update.
 825         (tui_source_window::location_matches_p)
 826         (tui_source_window::maybe_update): Update.
 827
 828 2019-09-20  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-winsource.h (~tui_source_element): Remove.
 831         (tui_source_element): Update.
 832         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 833         * tui/tui-winsource.c (tui_show_source_line): Update.
 834         * tui/tui-source.c (tui_source_window::set_contents): Update.
 835         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 836
 837 2019-09-20  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 840         declare.
 841         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 842         tui_clear_source_windows_detail.
 843         * tui/tui-winsource.h (struct tui_source_window_base)
 844         <clear_detail>: Don't declare.
 845         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 846         Remove.
 847         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 848
 849 2019-09-20  Tom Tromey  <tromey@adacore.com>
 850
 851         PR ada/24919:
 852         * block.c (contained_in): Fix final return value.
 853
 854 2019-09-20  Alan Modra  <amodra@gmail.com>
 855
 856         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 857         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 858         (read_indirect_string_from_dwz): Use bfd accessor.
 859         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 860         * machoread.c (macho_symfile_read_all_oso): Likewise.
 861         * solib.c (solib_bfd_open): Likewise.
 862
 863 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 864
 865         * eval.c: Move declaration of overload_resolution to...
 866         * value.h: ...here.
 867
 868 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 869
 870         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 871         * arm-linux-tdep.c: Likewise.
 872         * arm-nbsd-nat.c: Likewise.
 873         * arm-tdep.h: Declare arm_apcs_32.
 874         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 875
 876 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 877
 878         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 879         * dwarf2read.h: Declare dwarf_always_disassemble.
 880
 881 2019-09-19  Tom de Vries  <tdevries@suse.de>
 882
 883         PR gdb/25009
 884         * source-cache.c (source_cache::ensure): Catch exception thrown during
 885         construction of the highlighter.
 886
 887 2019-09-18  Alan Modra  <amodra@gmail.com>
 888
 889         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 890         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 891         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 892         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 893         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 894         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 895         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 896         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 897         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 898         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 899         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 900         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 901         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 902         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 903         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 904         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 905         * mi/mi-interp.c: Update throughout for bfd section macro and
 906         function changes.
 907         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 908         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 909
 910 2019-09-18  Tom Tromey  <tom@tromey.com>
 911
 912         * NEWS: Add entry.
 913         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 914         call rl_initialize.
 915         (tui_enable): Do not call rl_initialize.
 916
 917 2019-09-18  Christian Groessler  <chris@groessler.org>
 918
 919         * alpha-linux-nat.c: Include gdbarch.h.
 920
 921 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 922
 923         * ui-file.c: Include cli/cli-style.h.
 924         (term_cli_styling): Remove cli_styling declaration.
 925
 926 2019-09-18  Alan Modra  <amodra@gmail.com>
 927
 928         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 929         to bfd_asymbol_section.
 930
 931 2019-09-18  Alan Modra  <amodra@gmail.com>
 932
 933         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 934         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 935         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 936
 937 2019-09-18  Alan Modra  <amodra@gmail.com>
 938
 939         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 940         * spu-linux-nat.c (spu_bfd_open): Likewise.
 941
 942 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 943
 944         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 945         to bool to match definition in dwarf2read.c.
 946
 947 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 948
 949         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 950         (print_signatures): Likewise.
 951         (trust_pad_over_xvs): Likewise.
 952         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 953         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 954         * arm-linux-nat.c (arm_apcs_32): Likewise.
 955         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 956         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 957         * arm-tdep.c (arm_debug): Likewise.
 958         (arm_apcs_32): Likewise.
 959         * auto-load.c (debug_auto_load): Likewise.
 960         (auto_load_gdb_scripts): Likewise.
 961         (global_auto_load): Likewise.
 962         (auto_load_local_gdbinit): Likewise.
 963         (auto_load_local_gdbinit_loaded): Likewise.
 964         * auto-load.h (global_auto_load): Likewise.
 965         (auto_load_local_gdbinit): Likewise.
 966         (auto_load_local_gdbinit_loaded): Likewise.
 967         * breakpoint.c (disconnected_dprintf): Likewise.
 968         (breakpoint_proceeded): Likewise.
 969         (automatic_hardware_breakpoints): Likewise.
 970         (always_inserted_mode): Likewise.
 971         (target_exact_watchpoints): Likewise.
 972         (_initialize_breakpoint): Update.
 973         * breakpoint.h (target_exact_watchpoints): Change to bool.
 974         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 975         * cli/cli-cmds.c (trace_commands): Likewise.
 976         * cli/cli-cmds.h (trace_commands): Likewise.
 977         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 978         to bool*.
 979         * cli/cli-logging.c (logging_overwrite): Change to bool.
 980         (logging_redirect): Likewise.
 981         (debug_redirect): Likewise.
 982         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 983         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 984         to bool.
 985         <boolean_option_def>: Update.
 986         (struct flag_option_def): Change default type of Context to bool
 987         from int.
 988         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 989         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 990         (get_setshow_command_value_string): Likewise.
 991         * cli/cli-style.c (cli_styling): Change to bool.
 992         (source_styling): Likewise.
 993         * cli/cli-style.h (source_styling): Likewise.
 994         (cli_styling): Likewise.
 995         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 996         to bool.
 997         * command.h (var_types): Update comment.
 998         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 999         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1000         bool.
1001         (debug_compile_cplus_scopes): Likewise.
1002         * compile/compile-internal.h (compile_debug): Likewise.
1003         * compile/compile.c (compile_debug): Likewise.
1004         (struct compile_options) <raw>: Likewise.
1005         * cp-support.c (catch_demangler_crashes): Likewise.
1006         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1007         (usr_cmd_cris_dwarf2_cfi): Likewise.
1008         * csky-tdep.c (csky_debug): Likewise.
1009         * darwin-nat.c (enable_mach_exceptions): Likewise.
1010         * dcache.c (dcache_enabled_p): Likewise.
1011         * defs.h (info_verbose): Likewise.
1012         * demangle.c (demangle): Likewise.
1013         (asm_demangle): Likewise.
1014         * dwarf-index-cache.c (debug_index_cache): Likewise.
1015         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1016         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1017         * dwarf2read.c (check_physname): Likewise.
1018         (use_deprecated_index_sections): Likewise.
1019         (dwarf_always_disassemble): Likewise.
1020         * eval.c (overload_resolution): Likewise.
1021         * event-top.c (set_editing_cmd_var): Likewise.
1022         (exec_done_display_p): Likewise.
1023         * event-top.h (set_editing_cmd_var): Likewise.
1024         (exec_done_display_p): Likewise.
1025         * exec.c (write_files): Likewise.
1026         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1027         (debug_fbsd_nat): Likewise.
1028         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1029         Likewise.
1030         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1031         <backtrace_past_entry> Likewise.
1032         * gdb-demangle.h (demangle): Likewise.
1033         (asm_demangle): Likewise.
1034         * gdb_bfd.c (bfd_sharing): Likewise.
1035         * gdbcore.h (write_files): Likewise.
1036         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1037         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1038         * gdbthread.h (print_thread_events): Likewise.
1039         * gdbtypes.c (opaque_type_resolution): Likewise.
1040         (strict_type_checking): Likewise.
1041         * gnu-nat.c (gnu_debug_flag): Likewise.
1042         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1043         * guile/scm-param.c (pascm_variable): Add boolval.
1044         (add_setshow_generic): Update.
1045         (pascm_param_value): Update.
1046         (pascm_set_param_value_x): Update.
1047         * hppa-tdep.c (hppa_debug): Change to bool..
1048         * infcall.c (may_call_functions_p): Likewise.
1049         (coerce_float_to_double_p): Likewise.
1050         (unwind_on_signal_p): Likewise.
1051         (unwind_on_terminating_exception_p): Likewise.
1052         * infcmd.c (startup_with_shell): Likewise.
1053         * inferior.c (print_inferior_events): Likewise.
1054         * inferior.h (startup_with_shell): Likewise.
1055         (print_inferior_events): Likewise.
1056         * infrun.c (step_stop_if_no_debug): Likewise.
1057         (detach_fork): Likewise.
1058         (debug_displaced): Likewise.
1059         (disable_randomization): Likewise.
1060         (non_stop): Likewise.
1061         (non_stop_1): Likewise.
1062         (observer_mode): Likewise.
1063         (observer_mode_1): Likewise.
1064         (set_observer_mode): Update.
1065         (sched_multi): Change to bool.
1066         * infrun.h (debug_displaced): Likewise.
1067         (sched_multi): Likewise.
1068         (step_stop_if_no_debug): Likewise.
1069         (non_stop): Likewise.
1070         (disable_randomization): Likewise.
1071         * linux-tdep.c (use_coredump_filter): Likewise.
1072         (dump_excluded_mappings): Likewise.
1073         * linux-thread-db.c (auto_load_thread_db): Likewise.
1074         (check_thread_db_on_load): Likewise.
1075         * main.c (captured_main_1): Update.
1076         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1077         xx2_opt, boolean_opt>: Change to bool.
1078         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1079         * maint.c (maintenance_profile_p): Likewise.
1080         (per_command_time): Likewise.
1081         (per_command_space): Likewise.
1082         (per_command_symtab): Likewise.
1083         * memattr.c (inaccessible_by_default): Likewise.
1084         * mi/mi-main.c (mi_async): Likewise.
1085         (mi_async_1): Likewise.
1086         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1087         * nat/fork-inferior.h (startup_with_shell): Likewise.
1088         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1089         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1090         * nios2-tdep.c (nios2_debug): Likewise.
1091         * or1k-tdep.c (or1k_debug): Likewise.
1092         * parse.c (parser_debug): Likewise.
1093         * parser-defs.h (parser_debug): Likewise.
1094         * printcmd.c (print_symbol_filename): Likewise.
1095         * proc-api.c (procfs_trace): Likewise.
1096         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1097         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1098         (set_parameter_value): Update.
1099         (add_setshow_generic): Update.
1100         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1101         to bool*.
1102         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1103         int*.
1104         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1105         * record-btrace.c (record_btrace_target::store_registers): Update.
1106         * record-full.c (record_full_memory_query): Change to bool.
1107         (record_full_stop_at_limit): Likewise.
1108         * record-full.h (record_full_memory_query): Likewise.
1109         * remote-notif.c (notif_debug): Likewise.
1110         * remote-notif.h (notif_debug): Likewise.
1111         * remote.c (use_range_stepping): Likewise.
1112         (interrupt_on_connect): Likewise.
1113         (remote_break): Likewise.
1114         * ser-tcp.c (tcp_auto_retry): Likewise.
1115         * ser-unix.c (serial_hwflow): Likewise.
1116         * skip.c (debug_skip): Likewise.
1117         * solib-aix.c (solib_aix_debug): Likewise.
1118         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1119         (spu_auto_flush_cache_p): Likewise.
1120         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1121         Likewise.
1122         (struct info_print_options) <quiet>: Likewise.
1123         * symfile-debug.c (debug_symfile): Likewise.
1124         * symfile.c (auto_solib_add): Likewise.
1125         (separate_debug_file_debug): Likewise.
1126         * symfile.h (auto_solib_add): Likewise.
1127         (separate_debug_file_debug): Likewise.
1128         * symtab.c (basenames_may_differ): Likewise.
1129         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1130         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1131         (struct info_types_options) <quiet>: Likewise.
1132         * symtab.h (demangle): Likewise.
1133         (basenames_may_differ): Likewise.
1134         * target-dcache.c (stack_cache_enabled_1): Likewise.
1135         (code_cache_enabled_1): Likewise.
1136         * target.c (trust_readonly): Likewise.
1137         (may_write_registers): Likewise.
1138         (may_write_memory): Likewise.
1139         (may_insert_breakpoints): Likewise.
1140         (may_insert_tracepoints): Likewise.
1141         (may_insert_fast_tracepoints): Likewise.
1142         (may_stop): Likewise.
1143         (auto_connect_native_target): Likewise.
1144         (target_stop_and_wait): Update.
1145         (target_async_permitted): Change to bool.
1146         (target_async_permitted_1): Likewise.
1147         (may_write_registers_1): Likewise.
1148         (may_write_memory_1): Likewise.
1149         (may_insert_breakpoints_1): Likewise.
1150         (may_insert_tracepoints_1): Likewise.
1151         (may_insert_fast_tracepoints_1): Likewise.
1152         (may_stop_1): Likewise.
1153         * target.h (target_async_permitted): Likewise.
1154         (may_write_registers): Likewise.
1155         (may_write_memory): Likewise.
1156         (may_insert_breakpoints): Likewise.
1157         (may_insert_tracepoints): Likewise.
1158         (may_insert_fast_tracepoints): Likewise.
1159         (may_stop): Likewise.
1160         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1161         (make_thread_apply_all_options_def_group): Change argument from int*
1162         to bool*.
1163         (thread_apply_all_command): Update.
1164         (print_thread_events): Change to bool.
1165         * top.c (confirm): Likewise.
1166         (command_editing_p): Likewise.
1167         (history_expansion_p): Likewise.
1168         (write_history_p): Likewise.
1169         (info_verbose): Likewise.
1170         * top.h (confirm): Likewise.
1171         (history_expansion_p): Likewise.
1172         * tracepoint.c (disconnected_tracing): Likewise.
1173         (circular_trace_buffer): Likewise.
1174         * typeprint.c (print_methods): Likewise.
1175         (print_typedefs): Likewise.
1176         * utils.c (debug_timestamp): Likewise.
1177         (sevenbit_strings): Likewise.
1178         (pagination_enabled): Likewise.
1179         * utils.h (sevenbit_strings): Likewise.
1180         (pagination_enabled): Likewise.
1181         * valops.c (overload_resolution): Likewise.
1182         * valprint.h (struct value_print_options) <prettyformat_arrays,
1183         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1184         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1185         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1186         Likewise.
1187         * windows-nat.c (new_console): Likewise.
1188         (cygwin_exceptions): Likewise.
1189         (new_group): Likewise.
1190         (debug_exec): Likewise.
1191         (debug_events): Likewise.
1192         (debug_memory): Likewise.
1193         (debug_exceptions): Likewise.
1194         (useshell): Likewise.
1195         * windows-tdep.c (maint_display_all_tib): Likewise.
1196         * xml-support.c (debug_xml): Likewise.
1197
1198 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1199
1200         * source.c (prepare_path_for_appending): New function.
1201         (openp): Make use of new function.
1202         (find_and_open_source): Search for the compilation directory and
1203         source file as a relative path beneath the directory search path.
1204
1205 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * source-cache.c (source_cache::get_line_charpos): Catch
1208         exceptions and return false, this matches the behaviour documented
1209         in the header file.
1210
1211 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1212
1213         * ada-tasks.c (info_task): Remove quoting of the task's name.
1214
1215 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1216
1217         * symfile.c (auto_solib_add): Replace comment with a reference
1218         to the header file.
1219
1220 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1221
1222         * NEWS: Mention that gdb can now be compiled with Python 3
1223         on Windows.
1224
1225 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1226
1227         * maint.c (maint_print_section_data::maint_print_section_data):
1228         Force use of 'float log10 (float)' by casting the argument to
1229         float.
1230
1231 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * maint.c: Add 'cmath' include.
1234         (struct maint_print_section_data): New structure.
1235         (print_section_index): New function.
1236         (print_bfd_section_info): Add header comment, small whitespace
1237         cleanup, and update to call new print_section_index function.
1238         (print_objfile_section_info): Likewise.
1239         (maint_obj_section_from_bfd_section): New function.
1240         (print_bfd_section_info_maybe_relocated): New function.
1241         (maintenance_info_sections): Add header comment, always use
1242         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1243
1244 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1245
1246         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1247         inner scope, add check that the objfile has psymtabs before
1248         checking psymtabs_addrmap.
1249         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1250
1251 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1252
1253         * NEWS: Announce that Ada task names are now shown at more places,
1254         and between quotes (except in info task output).
1255         * gdb/ada-tasks.c (task_to_str): New function.
1256         (display_current_task_id): Call task_to_str.
1257         (task_command_1): Likewise.
1258         (print_ada_task_info): In non-mi mode, Properly align headers and data
1259         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1260
1261 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1262
1263         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1264         prstatus.pr_lwp.pr_info instead of making it up.
1265
1266 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1267
1268         * auto-load.c (auto_load_expand_dir_vars): Update.
1269         * defs.h (gdb_datadir): Change to std::string.
1270         (python_libdir): Likewise.
1271         (relocate_gdb_directory): Change return type to std::string.
1272         * guile/guile.c (gdbscm_data_directory): Update.
1273         (initialize_scheme_side): Update.
1274         * jit.c (jit_reader_dir): Change to std::string.
1275         (jit_reader_load_command): Update.
1276         * main.c (gdb_datadir): Change to std::string.
1277         (python_libdir): Likewise.
1278         (set_gdb_data_directory): Update.
1279         (relocate_path): Change to return std::string.
1280         (relocate_gdb_directory): Change to return std::string.
1281         (relocate_gdbinit_path_maybe_in_datadir): Update.
1282         (captured_main_1): Update.
1283         * python/python.c (do_start_initialization): Update.
1284         * top.c (show_gdb_datadir): Update.
1285         * xml-syscall.c (xml_init_syscalls_info): Update.
1286         (init_syscalls_info): Update.
1287
1288 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1289
1290         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1291         out of get_init_files.
1292         (get_init_files): Update.
1293
1294 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1295
1296         * main.c (get_init_files): Change to use std::string.
1297         (captured_main_1): Update.
1298         (print_gdb_help): Update.
1299
1300 2019-09-11  Ali Tamur  <tamur@google.com>
1301
1302         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1303         implementation.
1304
1305 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1306
1307         * dbxread.c (read_dbx_symtab): Update.
1308         * dwarf2read.c (load_partial_dies): Update.
1309         * mdebugread.c (parse_partial_symbols): Update.
1310         (handle_psymbol_enumerators): Update.
1311         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1312         * psymtab.c (add_psymbol_to_bcache): Likewise.
1313         (add_psymbol_to_list): Likewise.
1314         * symtab.c (symbol_set_names): Likewise.
1315         * symtab.h (symbol_set_names): Likewise.
1316         * xcoffread.c (scan_xcoff_symtab): Update.
1317
1318 2019-09-11  Tom Tromey  <tom@tromey.com>
1319
1320         * symfile-mem.c (symbol_file_add_from_memory): Use
1321         bfd_set_filename.
1322         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1323         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1324
1325 2019-09-10  Tom Tromey  <tromey@adacore.com>
1326
1327         * dwarf-index-write.c (write_psymbols): Extend error message.
1328         (debug_names::insert): Add Ada code.
1329         (debug_names::write_psymbols): Remove Ada check.
1330         (debug_names) <m_string_obstack>: New member.
1331         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1332         (gdb_index_symbol_name_matcher::matches): Remove.
1333         (mapped_index_base::find_name_components_bounds): Add "lang"
1334         parameter.
1335         (mapped_index_base::build_name_components): Also split names
1336         according to Ada syntax.
1337         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1338         type of "match_callback".
1339         (check_match, check_find_bounds_finds)
1340         (dw2_expand_symtabs_matching): Update.
1341         (dw2_debug_names_iterator): Add new constructor.
1342         (dw2_debug_names_map_matching_symbols): New function.
1343         (dw2_debug_names_expand_symtabs_matching): Update.
1344         (dwarf2_debug_names_functions): Use
1345         dw2_debug_names_map_matching_symbols.
1346
1347 2019-09-10  Tom Tromey  <tromey@adacore.com>
1348
1349         * dwarf2read.c (dw2_get_file_names_reader): Add the
1350         CU's file name to the results.
1351
1352 2019-09-10  Tom Tromey  <tromey@adacore.com>
1353
1354         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1355         map_matching_symbols.  Update.
1356         * dwarf2read.c (dw2_map_matching_symbols): Update.
1357         * psymtab.c (match_partial_symbol): Change type; update.
1358         (psym_map_matching_symbols): Likewise.
1359         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1360         type; update.
1361         * symfile.h (struct quick_symbol_functions)
1362         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1363         Remove "match".
1364
1365 2019-09-10  Tom Tromey  <tromey@adacore.com>
1366
1367         * psymtab.c (map_block): Remove.
1368         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1369         * symtab.c (iterate_over_symbols_terminated): New function.
1370         * symtab.c (iterate_over_symbols_terminated): Declare.
1371
1372 2019-09-10  Tom Tromey  <tromey@adacore.com>
1373
1374         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1375         * language.h (struct language_defn) <la_iterate_over_symbols>:
1376         Return bool.
1377         * symtab.c (iterate_over_symbols): Return bool.
1378         * symtab.h (iterate_over_symbols): Return bool.
1379
1380 2019-09-10  Tom Tromey  <tromey@adacore.com>
1381
1382         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1383         (add_nonlocal_symbols): Update.
1384         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1385         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1386         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1387         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1388         Change type of "callback".  Remove "data".
1389
1390
1391 2019-09-09  Ali Tamur  <tamur@google.com>
1392
1393         * dwarf2read.c (comp_unit_head): Update comment.
1394         (dwarf2_dwo_name): New function declaration.
1395         (dwarf_unit_type_name): New function declaration.
1396         (read_comp_unit_head): Add support for new compilation units,
1397         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1398         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1399         (currently named as "signature") in their header. Also clarify error
1400         messages.
1401         (lookup_dwo_id): New function. Returns the dwo id of the given
1402         compile unit.
1403         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1404         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1405         functions.
1406         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1407         (dwarf2_dwo_name): Get the dwo name if present.
1408         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1409         purposes.
1410
1411 2019-09-09  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1414
1415 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1416
1417         * python/python.c (do_start_initialization): Make progname_copy static,
1418         to avoid a leak report.
1419
1420 2019-09-08  Tom Tromey  <tom@tromey.com>
1421
1422         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1423
1424 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1425
1426         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1427         Change type to gdb::optional<block_enum>.
1428         (dw2_symtab_iter_init): Change block_index parameter type
1429         to gdb::optional<block_enum>.
1430         (dw2_lookup_symbol): Change block_index parameter
1431         type to block_enum.c
1432         (dw2_debug_names_lookup_symbol): Likewise.
1433         * psymtab.c (psym_lookup_symbol): Likewise.
1434         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1435         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1436         Likewise.
1437
1438 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1439
1440         * defs.h (relocate_gdb_directory): Change int to bool in
1441         signature and rename flag to relocatable.
1442         * main.c (relocate_path): Likewise.
1443         (relocate_gdb_directory): Likewise.
1444
1445 2019-09-06  Alan Modra  <amodra@gmail.com>
1446
1447         * coffread.c (coff_symfile_read): Constify filename variable.
1448         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1449         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1450         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1451         * solib.c (reload_shared_libraries_1): Likewise.
1452         * symfile.c (reread_symbols): Likewise.
1453         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1454         * solib-darwin.c (darwin_bfd_open): Likewise.
1455         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1456
1457 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1458
1459         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1460         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1461
1462 2019-09-03  Tom Tromey  <tromey@adacore.com>
1463
1464         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1465         types.
1466         (has_negatives): Unbias a range type bound.
1467         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1468         * gdbtypes.c (operator==): Handle new field.
1469         (create_range_type): Add "bias" parameter.
1470         (create_static_range_type, resolve_dynamic_range): Update.
1471         * gdbtypes.h (struct range_bounds) <bias>: New member.
1472         (create_range_type): Add bias parameter.
1473         * printcmd.c (print_scalar_formatted): Unbias range types.
1474         * value.c (unpack_long): Unbias range types.
1475         (pack_long): Bias range types.
1476
1477 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1478
1479         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1480         probe arguments.
1481
1482 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1483
1484         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1485         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1486         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1487         (compile_probe_arg): Likewise.
1488         * probe.h (get_argument_count): Likewise.
1489         * solib-svr4.c (solib_event_probe_action): Likewise.
1490         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1491
1492 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1493
1494         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1495         code to here...
1496         (svr4_create_solib_event_breakpoints): ...from here.
1497
1498 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1499
1500         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1501         suffix from warning message.
1502
1503 2019-08-30  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-winsource.h (struct tui_source_window_base)
1506         <refresh_all>: Don't declare.
1507         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1508         Remove.
1509         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1510         tui_show_locator_content.
1511         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1512         declare.
1513         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1514         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1515         declare.
1516
1517 2019-08-30  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1520
1521 2019-08-30  Tom Tromey  <tom@tromey.com>
1522
1523         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1524         Remove unnecessary forward declarations.
1525
1526 2019-08-30  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1529         rerender.
1530         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1531         tui_show_locator_content.
1532
1533 2019-08-30  Tom Tromey  <tom@tromey.com>
1534
1535         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1536         (tui_locator_window::rerender): Rewrite using body of previous
1537         tui_show_locator_content.
1538
1539 2019-08-30  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1542         set_locator_fullname>: New methods.
1543         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1544         Rename from tui_set_locator_fullname.
1545         (tui_locator_window::set_locator_info): Rename from
1546         tui_set_locator_info.  Return bool.
1547         (tui_update_locator_fullname, tui_show_frame_info): Update.
1548
1549 2019-08-30  Tom Tromey  <tom@tromey.com>
1550
1551         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1552
1553 2019-08-30  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1556         call touchwin.
1557
1558 2019-08-30  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-wingeneral.c (box_win): Assume win_info and
1561         win_info->handle cannot be NULL.
1562
1563 2019-08-30  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1566         refresh_window>: Declare.
1567         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1568         resize.
1569         (tui_data_item_window::rerender): Rename from
1570         tui_display_register.
1571         (tui_data_item_window::refresh_window): New method.
1572         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1573         no-op.
1574
1575 2019-08-30  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1578         regs_column_count, current_group>: Move later.  Now private.
1579         <get_current_group>: New method.
1580         * tui/tui-regs.c (tui_reg_command): Update.
1581         * tui/tui-layout.c (tui_set_layout): Update.
1582
1583 2019-08-30  Tom Tromey  <tom@tromey.com>
1584
1585         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1586         (tui_data_window::rerender): Don't call
1587         check_and_display_highlight_if_needed.
1588         (tui_data_window::refresh_all): Remove call to
1589         erase_data_content.
1590
1591 2019-08-30  Tom Tromey  <tom@tromey.com>
1592
1593         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1594         (tui_data_window::display_registers_from)
1595         (tui_data_window::display_reg_element_at_line)
1596         (tui_data_window::display_registers_from_line): Remove checks of
1597         "empty".
1598
1599 2019-08-30  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1602         Don't declare.
1603         * tui/tui-regs.c (tui_data_window::show_registers): Call
1604         rerender.
1605         (tui_data_window::rerender): Rename from display_all_data.
1606         (tui_data_window::rerender): Remove old implementation.
1607
1608 2019-08-30  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1611         text.
1612         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1613
1614 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1615             Sergio Durigan Junior  <sergiodj@redhat.com>
1616
1617         PR win32/24284
1618         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1619
1620 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1621
1622         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1623         when searching for types.
1624
1625 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1626
1627         * f-lang.c (f_language_defn): Use f_print_typedef.
1628         * f-lang.h (f_print_typedef): Declare.
1629         * f-typeprint.c (f_print_typedef): Define.
1630
1631 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1632
1633         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1634
1635 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         * cli/cli-utils.c (info_print_options_defs): Delete.
1638         (make_info_print_options_def_group): Delete.
1639         (extract_info_print_options): Delete.
1640         (info_print_command_completer): Delete.
1641         (info_print_args_help): Add extra parameter, and optionally
1642         include text about -n flag.
1643         * cli/cli-utils.h (struct info_print_options): Delete.
1644         (extract_info_print_options): Delete declaration.
1645         (info_print_command_completer): Delete declaration.
1646         (info_print_args_help): Add extra parameter, extend header
1647         comment.
1648         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1649         search_symbols.
1650         * stack.c (struct info_print_options): New type.
1651         (info_print_options_defs): New file scoped variable.
1652         (make_info_print_options_def_group): New static function.
1653         (info_print_command_completer): New static function.
1654         (info_locals_command): Update to use new local functions.
1655         (info_args_command): Likewise.
1656         (_initialize_stack): Add extra parameter to calls to
1657         info_print_args_help.
1658         * symtab.c (search_symbols): Add extra parameter, use this to
1659         possibly excluse non-debug symbols.
1660         (symtab_symbol_info): Add extra parameter, which is passed on to
1661         search_symbols.
1662         (struct info_print_options): New type.
1663         (info_print_options_defs): New file scoped variable.
1664         (make_info_print_options_def_group): New static function.
1665         (info_print_command_completer): New static function.
1666         (info_variables_command): Update to use local functions, and pass
1667         extra parameter through to symtab_symbol_info.
1668         (info_functions_command): Likewise.
1669         (info_types_command): Pass additional argument through to
1670         symtab_symbol_info.
1671         (rbreak_command): Pass extra argument to search_symbols.
1672         (_initialize_symtab): Add extra arguments for calls to
1673         info_print_args_help, and update help text for 'info variables',
1674         'whereis', and 'info functions' commands.
1675         * symtab.h (search_symbols): Add extra argument to declaration.
1676         * NEWS: Mention new flags.
1677
1678 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1679
1680         * symtab.c (lookup_static_symbol): Call the new function (and move
1681         it down to be next to lookup_global_symbol).
1682         (struct global_sym_lookup_data): Add block_enum member and rename to...
1683         (struct global_or_static_sym_lookup_data): ...this.
1684         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1685         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1686         (lookup_symbol_global_or_static_iterator_cb): ...this.
1687         (lookup_global_or_static_symbol): New function.
1688         (lookup_global_symbol): Call new function.
1689
1690 2019-08-26  Tom de Vries  <tdevries@suse.de>
1691
1692         PR c++/24852
1693         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1694         when pc_probe.prob == NULL.
1695
1696 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1697
1698         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1699         variable symbol_linkage to symbol_linkage_.
1700
1701 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1702
1703         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1704         represent whether the symbol is static, dynamic, or we don't
1705         know.
1706
1707 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1708
1709         * gdb/rx-tdep.c (rx_register_names): New.
1710         (rx_register_name): Delete.
1711         (rx_psw_type): Delete.
1712         (rx_fpsw_type): Delete.
1713         (rx_register_type): Delete.
1714         (rx_gdbarch_init): Convert target-descriptions.
1715         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1716         * gdb/features/Makefile: Add rx.xml.
1717         * gdb/features/rx.xml: New.
1718         * gdb/features/rx.c: Generated.
1719         * gdb/NEWS: Mention target description support.
1720
1721 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1722
1723         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1724         *slot_ptr.
1725
1726 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1727
1728         * configure.ac: Don't check for 'dlfcn.h' (moved to
1729         gdbsupport/common.m4).
1730         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1731         'gdbsupport/'.
1732         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1733         * compile/compile-c-support.c: Include
1734         'gdbsupport/gdb-dlfcn.h'.
1735         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1736         * gdb-dlfcn.c: Move to...
1737         * gdbsupport/gdb-dlfcn.c: ... here.
1738         * gdb-dlfcn.h: Move to...
1739         * gdbsupport/gdb-dlfcn.h: ... here.
1740
1741 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1742
1743         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1744         the offset field signed.
1745
1746 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1747
1748         * python/lib/gdb/__init__.py (_execute_file): New function.
1749         * python/python.c (python_run_simple_file): Call gdb._execute_file
1750         on Windows.
1751
1752 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1753
1754         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1755         all uses as this was never set to anything but a zero value.
1756
1757 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1758
1759         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1760
1761 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1762
1763         * tui/tui-data.h (tui_gen_win_info): Add an =default
1764         move constructor, required by some GCC versions.
1765
1766 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1767
1768         * go32-nat.c (go32_sysinfo): Add hygon_p.
1769
1770 2019-08-20  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1773         line_from_reg_element_no, first_reg_element_no_inline,
1774         display_all_data, delete_data_content_windows,
1775         erase_data_content>: Now private.
1776
1777 2019-08-20  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1780         (tui_unhighlight_win, tui_highlight_win)
1781         (tui_win_info::make_window): Update.
1782         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1783
1784 2019-08-20  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1787         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1788         (MAX_PID_WIDTH): Move to tui-stack.c.
1789         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1790         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1791         (MAX_PID_WIDTH): Move from tui-data.h.
1792
1793 2019-08-20  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1796         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1797         (box_win): Update.
1798         (tui_gen_win_info::make_window): Rename from tui_make_window.
1799         (tui_win_info::make_window): New method.
1800         (tui_gen_win_info::make_visible): Update.
1801         * tui/tui-source.c (tui_source_window::set_contents): Update.
1802         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1803         (tui_data_window::display_registers_from): Update.
1804         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1805         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1806         Declare.
1807         <can_box>: Remove.
1808         <title>: Remove.
1809         (struct tui_win_info) <make_window>: Declare.
1810         <can_box>: Now virtual.
1811         <title>: New member.
1812         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1813         * tui/tui-command.c (tui_cmd_window::resize): Update.
1814
1815 2019-08-20  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1818         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1819         (tui_data_window::check_register_values): Update.
1820
1821 2019-08-20  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-regs.h (struct tui_data_window): Use
1824         DISABLE_COPY_AND_ASSIGN.
1825         <regs_content>: Change type, removing unique_ptr.
1826         <tui_data_window>: Add move constructor.
1827         * tui/tui-regs.c (tui_data_window::show_registers)
1828         (tui_data_window::show_register_group)
1829         (tui_data_window::display_registers_from)
1830         (tui_data_window::display_registers_from)
1831         (tui_data_window::first_data_item_displayed)
1832         (tui_data_window::delete_data_content_windows)
1833         (tui_data_window::rerender, tui_data_window::refresh_window)
1834         (tui_data_window::check_register_values): Update.
1835
1836 2019-08-20  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1839         show_register_group>: Declare.
1840         (tui_show_register_group): Don't declare.
1841         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1842         tui_show_registers.
1843         (tui_data_window::show_register_group): Rename from
1844         tui_show_register_group.
1845         (tui_data_window::check_register_values, tui_reg_command):
1846         Update.
1847         * tui/tui-layout.c (tui_set_layout): Update.
1848
1849 2019-08-20  Tom Tromey  <tom@tromey.com>
1850
1851         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1852         Declare.
1853         (tui_check_register_values): Don't declare.
1854         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1855         from tui_check_register_values.
1856         * tui/tui-hooks.c (tui_register_changed): Update.
1857
1858 2019-08-20  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-regs.c (tui_reg_layout): Move later.
1861         (tui_show_registers): Don't enable TUI mode or change layout.
1862
1863 2019-08-20  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-regs.h (struct tui_data_item_window)
1866         <~tui_data_item_window>: Remove.
1867         <content>: Now a unique_xmalloc_ptr.
1868         * tui/tui-regs.c (tui_register_format): Return a
1869         unique_xmalloc_ptr.
1870         (tui_get_register): Update.
1871         (~tui_data_item_window): Remove.
1872         (tui_data_window::display_registers_from, tui_display_register):
1873         Update.
1874         * tui/tui-io.h (tui_expand_tabs): Update.
1875         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1876         Remove "col" parameter.
1877
1878 2019-08-20  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1881         field.
1882         * tui/tui-regs.c (~tui_data_item_window): Update.
1883
1884 2019-08-20  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1887         earlier.
1888
1889 2019-08-20  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1892
1893 2019-08-20  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-source.h (struct tui_source_window): Update.
1896         * tui/tui-regs.c (tui_show_registers): Update.
1897         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1898         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1899         (NO_REGS_STRING): Remove defines.
1900
1901 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1902
1903         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1904         unnecessary thread walk if remote doesn't support the packet.
1905
1906 2019-08-19  Tom Tromey  <tromey@adacore.com>
1907
1908         * python/py-value.c (value_has_field): Fix indentation.
1909
1910 2019-08-19  Tom Tromey  <tromey@adacore.com>
1911
1912         * printcmd.c (do_one_display, info_display_command): Update.
1913         * block.h (contained_in): Return bool.  Add allow_nested
1914         parameter.
1915         * block.c (contained_in): Return bool.  Add allow_nested
1916         parameter.
1917
1918 2019-08-19  Tom Tromey  <tom@tromey.com>
1919
1920         * configure: Rebuild.
1921         * configure.ac: Disallow the combination of -static-libstdc++ and
1922         source highlight.
1923         * source-cache.c (get_language_name): Handle rust.
1924         (source_cache::get_source_lines): Ignore highlighting exceptions.
1925
1926 2019-08-16  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1929         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1930         (struct tui_source_window_base) <make_visible, refresh_window,
1931         resize>: Remove methods.
1932         <execution_info>: Remove field.
1933         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1934         (tui_show_source_line, tui_source_window_base)
1935         (~tui_source_window_base): Update.
1936         (tui_source_window_base::resize)
1937         (tui_source_window_base::make_visible)
1938         (tui_source_window_base::refresh_window): Remove.
1939         (tui_source_window_base::update_exec_info): Update.
1940         * tui/tui-source.c (tui_source_window::set_contents): Update.
1941         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1942
1943 2019-08-16  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1946         deprecated_query_hook.
1947
1948 2019-08-16  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1951         (tui_update_source_windows_with_line): Update.
1952         * tui/tui-source.h (struct tui_source_window)
1953         <show_symtab_source>: Declare.
1954         (tui_show_symtab_source): Don't declare.
1955         * tui/tui-source.c (tui_show_symtab_source): Rename from
1956         tui_show_symtab_source.
1957
1958 2019-08-16  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-winsource.h (struct tui_source_window_base)
1961         <set_contents>: Declare.
1962         * tui/tui-winsource.c
1963         (tui_source_window_base::update_source_window_as_is): Update.
1964         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1965         Declare.
1966         (tui_set_source_content): Don't declare.
1967         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1968         tui_set_source_content.
1969         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1970         Declare.
1971         (tui_set_disassem_content): Don't declare.
1972         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1973         tui_set_disassem_content.
1974
1975 2019-08-16  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-winsource.h (struct tui_source_window_base)
1978         <update_breakpoint_info>: Declare.
1979         (tui_update_breakpoint_info): Don't declare.
1980         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1981         (tui_update_all_breakpoint_info): Update.
1982         (tui_source_window_base::update_breakpoint_info): Rename from
1983         tui_update_breakpoint_info.
1984         (tui_source_window_base::update_exec_info): Update.
1985
1986 2019-08-16  Tom Tromey  <tom@tromey.com>
1987
1988         * tui/tui-winsource.h (struct tui_source_window_base)
1989         <update_source_window>: Declare.
1990         (tui_update_source_window): Don't declare.
1991         * tui/tui-winsource.c
1992         (tui_source_window_base::update_source_window): Rename from
1993         tui_update_source_window.
1994         (tui_source_window_base::rerender): Update.
1995         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1996         * tui/tui-disasm.c (tui_show_disassem)
1997         (tui_show_disassem_and_update_source)
1998         (tui_disasm_window::maybe_update): Update.
1999
2000 2019-08-16  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-winsource.h (struct tui_source_window_base)
2003         <update_source_window_as_is>: Declare.
2004         (tui_update_source_window_as_is): Don't declare.
2005         * tui/tui-winsource.c (tui_update_source_window): Update
2006         (tui_source_window_base::update_source_window_as_is): Rename from
2007         tui_update_source_window_as_is.
2008         (tui_source_window_base::refill): Update.
2009         * tui/tui-source.c (tui_show_symtab_source): Update.
2010         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2011         Update.
2012
2013 2019-08-16  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-winsource.h (tui_update_source_window)
2016         (tui_update_source_window_as_is): Remove "noerror" parameter.
2017         * tui/tui-winsource.c (tui_update_source_window)
2018         (tui_update_source_window_as_is): Remove "noerror" parameter.
2019         (tui_update_source_windows_with_addr)
2020         (tui_update_source_windows_with_line)
2021         (tui_source_window_base::rerender)
2022         (tui_source_window_base::refill): Update.
2023         * tui/tui-source.h (tui_set_source_content)
2024         (tui_show_symtab_source): Remove "noerror" parameter.
2025         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2026         parameter.
2027         (tui_show_symtab_source): Likewise.
2028         (tui_source_window::maybe_update): Update.
2029         * tui/tui-disasm.c (tui_show_disassem)
2030         (tui_show_disassem_and_update_source)
2031         (tui_disasm_window::do_scroll_vertical)
2032         (tui_disasm_window::maybe_update): Update.
2033
2034 2019-08-16  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui.c (tui_is_window_visible): Update.
2037         * tui/tui-wingeneral.c (tui_make_window)
2038         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2039         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2040         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2041         (tui_set_win_height_command, parse_scrolling_args): Update.
2042         * tui/tui-source.c (tui_source_window::style_changed): Update.
2043         * tui/tui-regs.c (tui_show_registers)
2044         (tui_data_window::first_data_item_displayed)
2045         (tui_data_window::delete_data_content_windows)
2046         (tui_check_register_values, tui_reg_command): Update.
2047         * tui/tui-disasm.c (tui_show_disassem): Update.
2048         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2049         method.
2050         <is_visible>: Remove field.
2051         * tui/tui-data.c (tui_next_win, tui_prev_win)
2052         (tui_delete_invisible_windows): Update.
2053
2054 2019-08-16  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-winsource.h (struct tui_source_window_base)
2057         <m_has_locator>: Remove.
2058         * tui/tui-layout.c (show_source_disasm_command, show_data)
2059         (show_source_or_disasm_and_command): Update.
2060
2061 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2062
2063         * NEWS (Other MI changes): New subsection.
2064         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2065         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2066         * arch-utils.c (default_get_pc_address_flags): New function.
2067         * arch-utils.h (default_get_pc_address_flags): New declaration.
2068         * gdbarch.sh: Add get_pc_address_flags.
2069         * gdbarch.c: Regenerate.
2070         * gdbarch.h: Likewise.
2071         * stack.c (print_pc): New function.
2072         (print_frame_info) (print_frame): Call print_pc.
2073
2074 2019-08-16  Tom de Vries  <tdevries@suse.de>
2075
2076         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2077         print_objfile_section_info.
2078
2079 2019-08-15  Tom Tromey  <tom@tromey.com>
2080
2081         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2082         calling update_cmdwin_start_line.
2083         * tui/tui-winsource.h (struct tui_source_window_base)
2084         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2085         <rerender>: Declare.
2086         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2087         Call rerender.
2088         (tui_source_window_base::set_new_height): Remove.
2089         (tui_source_window_base::rerender): Rename from
2090         do_make_visible_with_new_height.
2091         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2092         resize method.
2093         (tui_win_info::make_invisible_and_set_new_height)
2094         (tui_win_info::make_visible_with_new_height): Remove.
2095         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2096         Declare.
2097         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2098         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2099         do_make_visible_with_new_height>: Don't declare.
2100         <rerender>: Declare.
2101         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2102         set_new_height.
2103         (tui_data_window::do_make_visible_with_new_height): Remove.
2104         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2105         call tui_show_locator_content.
2106         (tui_gen_win_info::resize): Call rerender.
2107         (show_source_or_disasm_and_command): Don't call
2108         tui_show_locator_content.
2109         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2110         method.
2111         (struct tui_win_info) <rerender>: Declare.
2112         <set_new_height, make_invisible_and_set_new_height,
2113         make_visible_with_new_height>: Don't declare.
2114         * tui/tui-data.c (tui_win_list::rerender): New method.
2115         * tui/tui-command.h (struct tui_cmd_window)
2116         <do_make_visible_with_new_height>: Don't declare.
2117         * tui/tui-command.c
2118         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2119
2120 2019-08-15  Tom Tromey  <tromey@adacore.com>
2121
2122         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2123         * ada-lang.c (ada_enum_name): Likewise.
2124
2125 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2126
2127         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2128         leading underscore.
2129         (GdbOutputErrorFile): Likewise.
2130         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2131         accordingly.
2132         (execute_unwinders): Rename to have a leading underscore.
2133         (auto_load_packages): Likewise.
2134         (global scope): Adjust call to auto_load_packages accordingly.
2135         (GdbSetPythonDirectory): Likewise.
2136         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2137         instead of execute_unwinders.
2138
2139 2019-08-15  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2142         (show_data): Don't change window visibility.
2143         (tui_gen_win_info::resize): Remove special case for command
2144         window.  Use wresize, when available.
2145         (show_source_or_disasm_and_command): Don't change window
2146         visibility.
2147         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2148         <make_visible>: New method.
2149         * tui/tui-command.c (tui_cmd_window::resize): New method.
2150
2151 2019-08-15  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2154         (struct tui_source_windows): New.
2155         * tui/tui-winsource.c (tui_display_main): Update.
2156         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2157         (new_height_ok, parse_scrolling_args): Update.
2158         * tui/tui-layout.c (show_layout, show_data): Update.
2159         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2160         (tui_add_to_source_windows): Don't declare.
2161         * tui/tui-data.c (source_windows, tui_source_windows)
2162         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2163
2164 2019-08-15  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2167         Rename from reset.
2168         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2169         * tui/tui-layout.c (show_source_disasm_command, show_data):
2170         Update.
2171         (tui_gen_win_info::resize): Rename.
2172         (show_source_or_disasm_and_command): Update.
2173         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2174         reset.
2175
2176 2019-08-15  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2179         * tui/tui-interp.c (tui_interp::init): Don't call
2180         tui_initialize_static_data.
2181         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2182
2183 2019-08-15  Tom Tromey  <tom@tromey.com>
2184
2185         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2186         examine tui_win_list.
2187
2188 2019-08-15  Tom Tromey  <tom@tromey.com>
2189
2190         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2191         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2192         tui_clear_source_content.
2193         (tui_clear_source_content): Remove.
2194         (tui_source_window_base::do_erase_source_content): Hoist call to
2195         content.clear().
2196         * tui/tui-stack.c (tui_show_frame_info): Don't call
2197         tui_clear_source_content.
2198
2199 2019-08-15  Tom Tromey  <tom@tromey.com>
2200
2201         * tui/tui-winsource.h (struct tui_source_window_base)
2202         <do_erase_source_content>: New method.
2203         <erase_source_content>: New method.
2204         (tui_erase_source_content): Don't declare.
2205         * tui/tui-winsource.c (tui_clear_source_content): Update.
2206         (tui_source_window_base::do_erase_source_content): Rename from
2207         tui_erase_source_content.
2208         (tui_source_window_base::show_source_content): Update.
2209         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2210         * tui/tui-source.h (struct tui_source_window)
2211         <erase_source_content>: New method.
2212         * tui/tui-disasm.h (struct tui_disasm_window)
2213         <erase_source_content>: New method.
2214
2215 2019-08-15  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2218         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2219         constructor.
2220         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2221         * tui/tui-source.c (tui_set_source_content): Update.
2222         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2223
2224 2019-08-15  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2227         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2228         tui-source.c.
2229         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2230         Declare.
2231         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2232         method.
2233         (tui_source_window::maybe_update): Update.
2234
2235 2019-08-15  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2238         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2239         tui-disasm.c.
2240         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2241         Declare.
2242         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2243         method.
2244         (tui_disasm_window::maybe_update): Update.
2245
2246 2019-08-15  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-winsource.h (struct tui_source_window_base)
2249         <maybe_update>: Declare.
2250         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2251         method.
2252         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2253         Declare.
2254         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2255         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2256         Declare.
2257         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2258
2259 2019-08-15  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2262
2263 2019-08-15  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui-wingeneral.c: Include tui-stack.h.
2266         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2267         (struct tui_locator_window): Move from tui-data.h.
2268         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2269         (tui_initialize_static_data): Move from tui-data.c.
2270         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2271         (struct tui_locator_window): Move to tui-stack.c.
2272         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2273         (tui_initialize_static_data): Move to tui-stack.c.
2274
2275 2019-08-15  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-layout.c (show_source_disasm_command)
2278         (show_source_or_disasm_and_command): Use make_visible method, not
2279         tui_make_window.
2280         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2281         Remove.
2282
2283 2019-08-15  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-wingeneral.h (tui_make_window): Update.
2286         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2287         parameter.
2288         (tui_gen_win_info::make_visible): Update.
2289         * tui/tui-regs.c (tui_data_window::display_registers_from):
2290         Update.
2291         * tui/tui-layout.c (show_source_disasm_command)
2292         (show_source_or_disasm_and_command): Update.
2293         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2294         (enum tui_box): Remove.
2295         (struct tui_win_info) <can_box>: New method.
2296         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2297         method.
2298
2299 2019-08-15  Tom de Vries  <tdevries@suse.de>
2300
2301         * linux-nat-trad.c: Include gdbarch.h.
2302
2303 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2304
2305         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2306         register sizes.
2307
2308 2019-08-14  Tom Tromey  <tromey@adacore.com>
2309
2310         * darwin-nat.c: Include gdbarch.h.
2311         * darwin-nat-info.c: Include gdbarch.h.
2312
2313 2019-08-13  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2316         Remove.
2317         * tui/tui-data.c (tui_initialize_static_data): Update.
2318
2319 2019-08-13  Tom Tromey  <tom@tromey.com>
2320
2321         * tui/tui-winsource.h (struct tui_exec_info_window)
2322         <~tui_exec_info_window, maybe_allocate_content, get_content,
2323         m_content>: Remove.
2324         (struct tui_source_window_base) <set_exec_info_content,
2325         show_exec_info_content>: Don't declare.
2326         * tui/tui-winsource.c
2327         (tui_exec_info_window::maybe_allocate_content): Remove.
2328         (tui_source_window_base::update_exec_info): Rename from
2329         set_exec_info_content.
2330         (tui_source_window_base::show_exec_info_content)
2331         (tui_source_window_base::update_exec_info): Remove.
2332
2333 2019-08-13  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2336         declare.
2337         * tui/tui-winsource.c (tui_update_source_window_as_is)
2338         (tui_update_source_windows_with_addr, tui_erase_source_content):
2339         Update.
2340         (tui_clear_exec_info_content): Remove.
2341
2342 2019-08-13  Tom Tromey  <tom@tromey.com>
2343
2344         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2345         declare.
2346         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2347         call tui_erase_exec_info_content.
2348         (tui_clear_exec_info_content): Rename from
2349         tui_erase_exec_info_content.
2350         (tui_clear_exec_info_content): Delete.
2351
2352 2019-08-13  Tom Tromey  <tom@tromey.com>
2353
2354         * tui/tui-winsource.h (struct tui_source_window_base)
2355         <show_exec_info_content>: Declare.
2356         (tui_show_exec_info_content): Don't declare.
2357         * tui/tui-winsource.c
2358         (tui_source_window_base::show_exec_info_content): Rename from
2359         tui_show_exec_info_content.
2360         (tui_source_window_base::update_exec_info): Update.
2361
2362 2019-08-13  Tom Tromey  <tom@tromey.com>
2363
2364         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2365         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2366         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2367         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2368         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2369         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2370         ... here.
2371
2372 2019-08-13  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-winsource.h (struct tui_source_window_base)
2375         <update_exec_info>: Declare.
2376         (tui_update_exec_info): Don't declare.
2377         * tui/tui-winsource.c (tui_update_source_window_as_is)
2378         (tui_source_window_base::refresh_all)
2379         (tui_update_all_breakpoint_info): Update.
2380         (tui_source_window_base::update_exec_info): Rename from
2381         tui_update_exec_info.
2382         * tui/tui-stack.c (tui_show_frame_info): Update.
2383
2384 2019-08-13  Tom Tromey  <tom@tromey.com>
2385
2386         * tui/tui-winsource.h (struct tui_source_window_base)
2387         <set_exec_info_content>: Declare.
2388         (tui_set_exec_info_content): Don't declare.
2389         * tui/tui-winsource.c
2390         (tui_source_window_base::set_exec_info_content): Rename from
2391         tui_set_exec_info_content.
2392         (tui_update_exec_info): Update.
2393
2394 2019-08-13  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-winsource.h (struct tui_source_window_base)
2397         <show_source_content>: Declare.
2398         (tui_show_source_content): Don't declare.
2399         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2400         (tui_source_window_base::show_source_content): Rename from
2401         tui_show_source_content.
2402         (tui_source_window_base::refresh_all): Update.
2403         * tui/tui-layout.c (show_source_disasm_command)
2404         (show_source_or_disasm_and_command): Update.
2405
2406 2019-08-13  Tom Tromey  <tom@tromey.com>
2407
2408         * tui/tui-winsource.c (tui_erase_source_content)
2409         (tui_show_source_content, tui_source_window_base::refresh_all):
2410         Update.
2411         * tui/tui-wingeneral.h
2412         (tui_check_and_display_highlight_if_needed): Don't declare.
2413         * tui/tui-wingeneral.c
2414         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2415         check_and_display_highlight_if_needed.
2416         * tui/tui-win.c (tui_rehighlight_all)
2417         (tui_win_info::make_visible_with_new_height): Update.
2418         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2419         (tui_data_window::erase_data_content)
2420         (tui_data_window::display_all_data): Update.
2421         * tui/tui-data.h (struct tui_win_info)
2422         <check_and_display_highlight_if_needed>: Declare.
2423
2424 2019-08-13  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-win.c (tui_resize_all): Call
2427         tui_delete_invisible_windows.
2428         * tui/tui-layout.c (show_layout): Call
2429         tui_delete_invisible_windows.
2430         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2431         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2432
2433 2019-08-13  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2436         tui_add_win_to_layout.
2437
2438 2019-08-13  Tom Tromey  <tom@tromey.com>
2439
2440         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2441         * tui/tui-layout.c (tui_default_win_height): Now static.
2442
2443 2019-08-13  Tom Tromey  <tom@tromey.com>
2444
2445         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2446         single switch.
2447         (show_source_disasm_command, show_source_or_disasm_and_command):
2448         Don't check current layout.
2449
2450 2019-08-13  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-wingeneral.c (make_all_visible): Remove.
2453         (tui_make_all_invisible): Simplify.
2454         * tui/tui-layout.c (tui_make_all_invisible): Move from
2455         tui-wingeneral.c; simplify.
2456         (show_layout): Hoist call to tui_make_all_invisible.
2457         (show_data): Don't call tui_make_all_invisible.
2458
2459 2019-08-13  Tom Tromey  <tom@tromey.com>
2460
2461         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2462         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2463
2464 2019-08-13  Tom Tromey  <tom@tromey.com>
2465
2466         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2467         tui-data.c.
2468         (show_source_disasm_command, show_data)
2469         (show_source_or_disasm_and_command): Don't use
2470         tui_set_current_layout_to.
2471         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2472         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2473         tui-layout.c.
2474         (tui_set_current_layout_to): Remove.
2475
2476 2019-08-13  Tom Tromey  <tom@tromey.com>
2477
2478         * tui/tui-layout.c (tui_set_layout): Update.
2479         * tui/tui-data.h (struct tui_layout_def): Remove.
2480         (tui_layout_def): Don't declare.
2481         * tui/tui-data.c (layout_def): Remove.
2482         (tui_layout_def): Remove.
2483
2484 2019-08-13  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-winsource.h (struct tui_source_window_base)
2487         <clear_detail>: No longer "override".
2488         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2489         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2490         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2491         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2492         Remove.
2493         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2494
2495 2019-08-13  Tom Tromey  <tromey@adacore.com>
2496
2497         * tracepoint.c: Don't include readline.h or history.h.
2498
2499 2019-08-12  Tom Tromey  <tom@tromey.com>
2500
2501         * configure: Rebuild.
2502         * configure.ac: Check for readline 7.
2503         * NEWS: Mention readline 7 requirement.
2504         * README: Update.
2505
2506 2019-08-12  Tom Tromey  <tom@tromey.com>
2507
2508         * mingw-hdep.c (gdb_select): Remove readline hack.
2509
2510 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2511
2512         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2513         when the function fails.
2514
2515 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2516
2517         * s390-tdep.c (s390_type_align): New function.
2518         (s390_gdbarch_init): Set it as type_align gdbarch method.
2519
2520 2019-08-09  Tom de Vries  <tdevries@suse.de>
2521
2522         PR gdb/24591
2523         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2524         pc_low with relocation offset.
2525
2526 2019-08-07  Tom Tromey  <tromey@adacore.com>
2527
2528         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2529         (print_frame_args): Update.
2530         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2531         Update.
2532         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2533         * frame.h (struct frame_arg): Add initializers.
2534         <error>: Now a unique_xmalloc_ptr.
2535
2536 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2537
2538         * NEWS: Expand the Pointer Authentication entry.
2539         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2540         (aarch64_frame_unmask_lr): ... to this.
2541         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2542         Call aarch64_frame_unmask_lr.
2543         * frame.c (struct frame_info): Add "masked" variable.
2544         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2545         (fprint_frame): Check for masked pc.
2546         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2547         declarations.
2548         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2549         * stack.c (print_frame): Check for masked pc.
2550
2551 2019-08-06  Tom Tromey  <tom@tromey.com>
2552
2553         * stabsread.c (patch_block_stabs, read_one_struct_field)
2554         (read_enum_type): Use obstack_strndup.
2555         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2556         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2557         * dwarf2read.c (guess_full_die_structure_name)
2558         (anonymous_struct_prefix): Use obstack_strndup.
2559         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2560         * c-exp.y (yylex): Use obstack_strndup.
2561         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2562         (write_var_or_type): Use obstack_strndup.
2563
2564 2019-08-06  Tom Tromey  <tom@tromey.com>
2565
2566         * symfile.c (reread_symbols): Use obstack_strdup.
2567         * stabsread.c (read_type): Use obstack_strdup.
2568         * gdb_obstack.h (obstack_strdup): New overload.
2569         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2570         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2571         (dwarf2_canonicalize_name): Use obstack_strdup.
2572         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2573         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2574         Use obstack_strdup.
2575
2576 2019-08-06  Tom Tromey  <tom@tromey.com>
2577
2578         * gdb_obstack.h (obstack_strdup): Define.
2579         * gdb_obstack.c (obstack_strdup): Don't define.
2580
2581 2019-08-06  Tom Tromey  <tom@tromey.com>
2582
2583         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2584         obstack_strdup.
2585         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2586         obstack_strdup.
2587         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2588         * stabsread.c (common_block_start): Use obstack_strdup.
2589         * objfiles.c (set_objfile_main_name, objfile): Use
2590         obstack_strdup.
2591         * namespace.c (add_using_directive): Use obstack_strdup.
2592         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2593         * jit.c (finalize_symtab): Use obstack_strdup.
2594         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2595         (guess_partial_die_structure_name, partial_die_info::fixup)
2596         (dwarf2_name): Use obstack_strdup.
2597         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2598         obstack_strdup.
2599         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2600         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2601         obstack_strdup.
2602         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2603
2604 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2605
2606         * unittests/help-doc-selftests.c: New file.
2607         * Makefile.in: Add the new file.
2608
2609 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2610
2611         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2612         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2613         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2614         the trailing '.' is not output, and the first character is uppercased.
2615         (print_help_for_command): Update call to print_doc_line.
2616         (print_doc_of_command): Likewise.
2617         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2618         * cli/cli-option.c (append_indented_doc): Do not append newline.
2619         (build_help_option): Append newline after first appended_indented_doc
2620         only if a second call is done.
2621         (build_help): Append 2 new lines before each option, except the first
2622         one.
2623         * compile/compile.c (_initialize_compile): Add new lines after
2624         %OPTIONS%, when not at the end of the help.
2625         Change help doc or code
2626         producing the help doc to respect the invariants.
2627         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2628         Also removed the new line after 'Options:', as all other commands
2629         do not put an empty line between 'Options:' and the first option.
2630         * printcmd.c (_initialize_printcmd): Likewise.
2631         * stack.c (_initialize_stack): Likewise.
2632         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2633         incorrectly telling COMMAND is optional.
2634         * ada-lang.c (_initialize_ada_language): Change help doc or code
2635         producing the help doc to respect the invariants.
2636         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2637         * breakpoint.c (_initialize_breakpoint): Likewise.
2638         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2639         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2640         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2641         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2642         _initialize_cli_style): Likewise.
2643         * corelow.c (core_target_info): Likewise.
2644         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2645         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2646         * filesystem.c (_initialize_filesystem): Likewise.
2647         * frame.c (_initialize_frame): Likewise.
2648         * gnu-nat.c (add_task_commands): Likewise.
2649         * infcall.c (_initialize_infcall): Likewise.
2650         * infcmd.c (_initialize_infcmd): Likewise.
2651         * interps.c (_initialize_interpreter): Likewise.
2652         * language.c (_initialize_language): Likewise.
2653         * linux-fork.c (_initialize_linux_fork): Likewise.
2654         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2655         * maint.c (_initialize_maint_cmds): Likewise.
2656         * memattr.c (_initialize_mem): Likewise.
2657         * printcmd.c (_initialize_printcmd): Likewise.
2658         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2659         _RegEx): Likewise.
2660         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2661         * record-btrace.c (_initialize_record_btrace): Likewise.
2662         * record-full.c (_initialize_record_full): Likewise.
2663         * record.c (_initialize_record): Likewise.
2664         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2665         * regcache.c (_initialize_regcache): Likewise.
2666         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2667         _initialize_remote): Likewise.
2668         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2669         * serial.c (_initialize_serial): Likewise.
2670         * skip.c (_initialize_step_skip): Likewise.
2671         * source.c (_initialize_source): Likewise.
2672         * stack.c (_initialize_stack): Likewise.
2673         * symfile.c (_initialize_symfile): Likewise.
2674         * symtab.c (_initialize_symtab): Likewise.
2675         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2676         * top.c (init_main): Likewise.
2677         * tracefile-tfile.c (tfile_target_info): Likewise.
2678         * tracepoint.c (_initialize_tracepoint): Likewise.
2679         * tui/tui-win.c (_initialize_tui_win): Likewise.
2680         * utils.c (add_internal_problem_command): Likewise.
2681         * valprint.c (value_print_option_defs): Likewise.
2682
2683 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2684
2685         PR build/24886
2686         * configure.ac: Drop enable-libmcheck support.
2687         * configure, config.in: Rebuild.
2688         * libmcheck.m4: Remove.
2689         * acinclude.m4: Don't include it.
2690         * Makefile.in: Don't distribute it.
2691         * top.c (print_gdb_configuration): Don't mention it.
2692
2693 2019-08-06  Tom Tromey  <tom@tromey.com>
2694
2695         * utils.c (set_output_style): Sometimes pass stream to
2696         emit_style_escape.
2697         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2698         * record-btrace.c (btrace_insn_history): Update.
2699         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2700         method.
2701         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2702         Update initializers.
2703         <m_uiout>: New field.
2704         <m_di>: Move lower.
2705         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2706         Remove "uiout" parameter.
2707         (dump_insns): Update.
2708         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2709         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2710
2711 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2712
2713         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2714         (error_in_psymtab_expansion): Likewise.
2715         (lookup_symbol_via_quick_fns): Likewise.
2716         (basic_lookup_transparent_type_quick): Likewise.
2717         (basic_lookup_transparent_type_1): Likewise.
2718
2719 2019-08-06  Tom Tromey  <tromey@adacore.com>
2720
2721         * source.c (last_source_error): Now bool.
2722         (print_source_lines_base): Make "noprint" bool.  Only open
2723         source file when last_source_visited changes.
2724
2725 2019-08-06  Tom Tromey  <tromey@adacore.com>
2726
2727         * annotate.c (annotate_source_line): Use g_source_cache.
2728         * source-cache.c (source_cache::get_plain_source_lines): Change
2729         parameters.  Populate m_offset_cache.
2730         (source_cache::ensure): New method.
2731         (source_cache::get_line_charpos): New method.
2732         (extract_lines): Move lower.  Change parameters.
2733         (source_cache::get_source_lines): Move lower.
2734         * source-cache.h (class source_cache): Update comment.
2735         <get_line_charpos>: New method.
2736         <get_source_lines>: Update comment.
2737         <clear>: Clear m_offset_cache.
2738         <get_plain_source_lines>: Change parameters.
2739         <ensure>: New method
2740         <m_offset_cache>: New member.
2741         * source.c (forget_cached_source_info_for_objfile): Update.
2742         (info_source_command): Use g_source_cache.
2743         (find_source_lines, open_source_file_with_line_charpos): Remove.
2744         (print_source_lines_base, search_command_helper): Use g_source_cache.
2745         * source.h (open_source_file_with_line_charpos): Don't declare.
2746         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2747         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2748         Use g_source_cache.
2749
2750 2019-08-06  Tom Tromey  <tromey@adacore.com>
2751
2752         * source-cache.c (source_cache::get_plain_source_lines):
2753         Remove "first_line" and "last_line" parameters.
2754         (source_cache::get_source_lines): Cache plain text.
2755         * source-cache.h (class source_cache)
2756         <get_plain_source_lines>: Update.
2757
2758 2019-08-06  Tom Tromey  <tromey@adacore.com>
2759
2760         * source-cache.c (extract_lines): No longer a method.
2761         Changed type of parameter.  Include final newline.
2762         (selftests::extract_lines_test): New function.
2763         (_initialize_source_cache): Likewise.
2764         * source-cache.h (class source_cache)
2765         <extract_lines>: Don't declare.
2766
2767 2019-08-06  Tom Tromey  <tromey@adacore.com>
2768
2769         * breakpoint.c (init_breakpoint_sal): Update.
2770         (breakpoint): Update.
2771         * breakpoint.h (struct breakpoint) <filter>: Now a
2772         unique_xmalloc_ptr.
2773
2774 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2775
2776         * NEWS: Mention dictionary access on blocks.
2777         * python/py-block.c (blpy_getitem): New function.
2778         (block_object_as_mapping): New struct.
2779         (block_object_type): Use new struct for tp_as_mapping field.
2780
2781 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2782
2783         * objfiles.h (objfile): Add a comment describing partial symbols.
2784
2785 2019-08-05  Tom Tromey  <tromey@adacore.com>
2786
2787         * compile/compile.c (_initialize_compile): Use _(), not N_().
2788         * thread.c (_initialize_thread): Use _(), not N_().
2789         * stack.c (_initialize_stack): Use _(), not N_().
2790         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2791
2792 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2793
2794         * dwarf2read.c (struct dw2_symtab_iterator):
2795         <want_specific_block>: Remove.
2796         <block_index>: Change type to gdb::optional.
2797         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2798         change type of BLOCK_INDEX parameter to gdb::optional.
2799         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2800         (dw2_lookup_symbol): Don't pass argument for
2801         WANT_SPECIFIC_BLOCK.
2802         (dw2_expand_symtabs_for_function): Don't pass argument for
2803         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2804         (class dw2_debug_names_iterator)
2805         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2806         parameter, change BLOCK_INDEX type to gdb::optional.
2807         <m_want_specific_block>: Remove.
2808         <m_block_index>: Change type to gdb::optional.
2809         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2810         gdb::optional.  Re-write in function of gdb::optional.
2811         (dw2_debug_names_lookup_symbol): Don't pass argument for
2812         WANT_SPECIFIC_BLOCK.
2813         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2814         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2815         BLOCK_INDEX.
2816
2817 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2818
2819         * NEWS: Mention changes to "info sources" command.
2820
2821 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2822
2823         * symtab.c (filename_partial_match_opts): New struct type.
2824         (struct output_source_filename_data): New members
2825         regexp, c_regexp, partial_match.
2826         (output_source_filename): Use new members to decide to print file.
2827         (info_sources_option_defs): New variable.
2828         (make_info_sources_options_def_group, print_info_sources_header,
2829         info_sources_command_completer):
2830         New functions.
2831         (info_sources_command): Read new optional arguments.
2832         (_initialize_symtab): Update info sources help.
2833
2834 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2835
2836         * ada-lang.c (exception_support_info_v0): Renamed from...
2837         (default_exception_support_info): ... this.  Create new
2838         definition for v1.
2839         (ada_has_this_exception_support): Look up catch_handlers_sym.
2840         (ada_exception_support_info_sniffer): Try v0 after default.
2841
2842 2019-08-01  Tom Tromey  <tromey@adacore.com>
2843
2844         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2845         gdbarch.h.
2846
2847 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2848
2849         * s12z-tdep.c: Fix include path for s12z-opc.h.
2850
2851 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2852
2853         * NEWS: Require GNU make 3.82.
2854
2855 2019-07-16  Tom Tromey  <tom@tromey.com>
2856
2857         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2858         declare.
2859
2860 2019-07-30  Tom Tromey  <tromey@adacore.com>
2861
2862         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2863
2864 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2865
2866         * printcmd.c (print_address_symbolic): Print negative offsets.
2867         (build_address_symbolic): Force signed arithmetic when computing
2868         offset.
2869
2870 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2871
2872         PR/24474: Add a function to lookup static variables.
2873         * NEWS: Mention this new function.
2874         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2875         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2876         * python/python.c (python_GdbMethods): Add new function.
2877
2878 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2879
2880         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2881         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2882         (objfpy_lookup_static_symbol): New function.
2883         (objfile_object_methods): Add new functions.
2884
2885 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2886
2887         * NEWS: Mention 'set|show print frame-info'.  Mention new
2888         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2889         backtrace argument.  Mention that python frame filtering code
2890         is now consistent with what 'backtrace' command prints.
2891
2892 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2893
2894         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2895         comments.
2896         (print_frame_info_auto, print_frame_info_source_line,
2897         print_frame_info_location, print_frame_info_source_and_location,
2898         print_frame_info_location_and_address, print_frame_info_short_location):
2899         New declarations.
2900         (struct frame_print_options): New member print_frame_info.
2901         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2902         * stack.h (get_user_print_what_frame_info): New declaration.
2903         (frame_show_address): New declaration.
2904         * stack.c (print_frame_arguments_choices): New value 'presence'.
2905         (print_frame_info_auto, print_frame_info_source_line,
2906         print_frame_info_location, print_frame_info_source_and_location,
2907         print_frame_info_location_and_address, print_frame_info_short_location,
2908         print_frame_info_choices, print_frame_info_print_what): New definitions.
2909         (print_frame_args): Only print dots for args if print frame-arguments
2910         is 'presence'.
2911         (frame_print_option_defs): New element for "frame-info".
2912         (get_user_print_what_frame_info): New function.
2913         (frame_show_address): Make non static.  Move comment to stack.h.
2914         (print_frame_info_to_print_what): New function.
2915         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2916         to decide what to print.
2917         (backtrace_command_1): Handle the new print_frame_arguments_presence
2918         value.
2919         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2920         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2921         (py_print_frame): In non-mi mode, use LOCATION as default for
2922         print_what, similarly to frame information printed directly by
2923         backtrace command. Handle frame-info user option in non MI mode.
2924
2925 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2926
2927         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2928         Add case for debugging 32-bit target on 64-bit host.  Revise
2929         comment.
2930
2931 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2932
2933         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2934         instead of find_function_entry_range_from_pc.
2935
2936 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2937
2938         * stack.c (find_frame_funname): Remove code which preferred
2939         minsym over symtab sym in "certain pathological cases".
2940
2941         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2942         parameter.  Change type of "do_demangle" to bool.
2943         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2944         Pass suitable "prefer_sym_over_minsym" flag to
2945         build_address_symbolic().  Don't output "+" for negative offsets.
2946         * printcmd.c (print_address_symbolic): Update invocation of
2947         build_address_symbolic to include a "prefer_sym_over_minsym"
2948         flag.
2949         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2950         Restrict cases in which use of minimal symbol is preferred to that
2951         of a found symbol.  Update comments.
2952
2953         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2954         for entry pc when entry pc is out of range for that FDE.
2955
2956 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2957
2958         PR gdb/24839:
2959         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2960         type.
2961
2962 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2963
2964         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2965         this function's Python signature.
2966
2967
2968 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2969
2970         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2971         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2972         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2973         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2974         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2975
2976
2977 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2978
2979         * h8300-tdep.c (h8300_register_name_common): New.
2980         h8300_register_name): Use h8300_register_name_common.
2981         (h8300s_register_name): Likewise.
2982         (h8300sx_register_name): Likewise.
2983         (h8300h_register_nam): New.
2984         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2985
2986
2987 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2988
2989         * arm-tdep.c (arm_skip_cmse_entry): New function.
2990         (arm_is_sgstubs_section): New function.
2991         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2992
2993 2019-07-22  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2996         Don't self-assign.
2997
2998 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2999
3000         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3001         type_print.
3002
3003 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3004
3005         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3006         so that GDB doesn't match any msymbols when searching in the
3007         TYPES_DOMAIN.
3008         (print_symbol_info): Print using typedef_print or type_print based
3009         on the type of the symbol.  Add updated FIXME comment moved from...
3010         (_initialize_symtab): ... move and update FIXME comment to above.
3011
3012 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * NEWS: Mention adding -q option to "info types".
3015         * symtab.c (struct info_types_options): New struct.
3016         (info_types_options_defs): New variable.
3017         (make_info_types_options_def_group): New function.
3018         (info_types_command): Use gdb::option framework to parse options.
3019         (info_types_command_completer): New function.
3020         (_initialize_symtab): Extend the help text on "info types" and
3021         register command completer.
3022
3023 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3024
3025         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3026         (lookup_symbol_in_objfile): Change int to block_enum and add a
3027         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3028
3029 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3030
3031         * MAINTAINERS (Write After Approval): Add self.
3032
3033 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3034
3035         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3036         instruction to the dummy code region.
3037
3038 2019-07-19  Tom Tromey  <tromey@adacore.com>
3039
3040         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3041         (ARGSUSED, PARAMS, __func__): Remove rules.
3042
3043 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3044
3045         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3046         * features/arm/arm-with-iwmmxt.c: Remove.
3047         * features/arm/arm-with-iwmmxt.xml: Remove.
3048         * features/arm/arm-with-m-fpa-layout.c: Remove.
3049         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3050         * features/arm/arm-with-m-vfp-d16.c: Remove.
3051         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3052         * features/arm/arm-with-m.c: Remove.
3053         * features/arm/arm-with-m.xml: Remove.
3054         * features/arm/arm-with-neon.c: Remove.
3055         * features/arm/arm-with-neon.xml: Remove.
3056         * features/arm/arm-with-vfpv2.c: Remove.
3057         * features/arm/arm-with-vfpv2.xml: Remove.
3058         * features/arm/arm-with-vfpv3.c: Remove.
3059         * features/arm/arm-with-vfpv3.xml: Remove.
3060
3061 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3062
3063         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3064
3065 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3066
3067         * arch/aarch32.c (aarch32_create_target_description): Create
3068         target descriptions using features.
3069         * arch/arm.c (arm_create_target_description)
3070         (arm_create_mprofile_target_description): Likewise.
3071         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3072
3073 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3074
3075         * Makefile.in: Add new files.
3076         * aarch32-tdep.c: New file.
3077         * aarch32-tdep.h: New file.
3078         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3079         Call aarch32_read_description.
3080         * arch/aarch32.c: New file.
3081         * arch/aarch32.h: New file.
3082         * arch/arm.c (arm_create_target_description)
3083         (arm_create_mprofile_target_description): New function.
3084         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3085         (arm_create_target_description)
3086         (arm_create_mprofile_target_description): New declaration.
3087         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3088         read_description functions.
3089         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3090         Likewise.
3091         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3092         * arm-tdep.c (tdesc_arm_list): New variable.
3093         (arm_register_g_packet_guesses): Call create description functions.
3094         (arm_read_description) (arm_read_mprofile_description): New
3095         function.
3096         * arm-tdep.h (arm_read_description)
3097         (arm_read_mprofile_description): Add declaration.
3098         * configure.tgt: Add new files.
3099
3100 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3101
3102         * top.c (new_ui_command): Open specified terminal just once.
3103
3104 2019-07-18  Tom Tromey  <tromey@adacore.com>
3105
3106         * symtab.c (main_name): Constify return type.
3107         * symfile.c (set_initial_language): Update.
3108         * symtab.h (main_name): Constify return type.
3109
3110 2019-07-17  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-winsource.c (tui_update_source_window)
3113         (tui_update_source_window_as_is)
3114         (tui_update_source_windows_with_line): Remove return.
3115         * tui/tui-disasm.c (tui_show_disassem)
3116         (tui_show_disassem_and_update_source): Remove return.
3117         * tui/tui.c (tui_reset): Remove return.
3118         * tui/tui-wingeneral.c
3119         (tui_check_and_display_highlight_if_needed): Remove return.
3120
3121 2019-07-17  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3124
3125 2019-07-17  Tom Tromey  <tom@tromey.com>
3126
3127         * tui/tui-winsource.h (struct tui_exec_info_window)
3128         (struct tui_source_window_base): Move from tui-data.h.
3129         * tui/tui-winsource.c: Move many method definitions from
3130         elsewhere.  Remove "structuring" comments.
3131         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3132         (tui_source_window_base::refresh_window): Move to
3133         tui-winsource.c.
3134         * tui/tui-win.c (tui_source_window_base::refresh_all)
3135         (tui_source_window_base::update_tab_width)
3136         (tui_source_window_base::set_new_height)
3137         (tui_source_window_base::do_make_visible_with_new_height): Move to
3138         tui-winsource.c.
3139         * tui/tui-source.h: Update.
3140         * tui/tui-source.c (tui_source_window_base::reset): Move to
3141         tui-winsource.c.
3142         * tui/tui-disasm.h: Update.
3143         * tui/tui-data.h (struct tui_exec_info_window): Move to
3144         tui-winsource.h.
3145         (struct tui_source_window_base): Likewise.
3146         * tui/tui-data.c (tui_source_window_base::clear_detail)
3147         (tui_source_window_base, ~tui_source_window_base): Move to
3148         tui-winsource.c.
3149
3150 2019-07-17  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-win.c (tui_resize_all)
3153         (tui_source_window_base::update_tab_width)
3154         (tui_adjust_win_heights): Update.
3155         (tui_win_info::make_invisible_and_set_new_height): Rename from
3156         make_invisible_and_set_new_height.
3157         * tui/tui-data.h (struct tui_win_info)
3158         <make_invisible_and_set_new_height>: New method.
3159
3160 2019-07-17  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui.c: Update.
3163         * tui/tui-source.h (struct tui_source_window): Move from
3164         tui-data.h.
3165         * tui/tui-layout.c: Update.
3166         * tui/tui-disasm.c: Update.
3167         * tui/tui-data.h (struct tui_source_window): Move to
3168         tui-source.h.
3169
3170 2019-07-17  Tom Tromey  <tom@tromey.com>
3171
3172         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3173         tui-data.h.
3174         * tui/tui-data.h (struct tui_disasm_window): Move to
3175         tui-disasm.h.
3176
3177 2019-07-17  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui-regs.h (struct tui_data_item_window): Move from
3180         tui-data.h.
3181         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3182         * tui/tui-data.h (struct tui_data_item_window): Move to
3183         tui-regs.h.
3184         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3185
3186 2019-07-17  Tom Tromey  <tom@tromey.com>
3187
3188         * tui/tui.c: Update.
3189         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3190         (tui_cmd_window::max_height): Move to tui-command.c.
3191         * tui/tui-layout.c: Update.
3192         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3193         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3194         tui-command.c.
3195         * tui/tui-command.h (struct tui_cmd_window): Move from
3196         tui-data.h.
3197         * tui/tui-command.c: Remove "structuring" comments.
3198         (tui_cmd_window::clear_detail)
3199         (tui_cmd_window::do_make_visible_with_new_height)
3200         (tui_cmd_window::max_height): Move from elsewhere.
3201
3202 2019-07-17  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3205         Now static.
3206         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3207         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3208
3209 2019-07-17  Tom Tromey  <tom@tromey.com>
3210
3211         * tui/tui.c: Update.
3212         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3213         tui-regs.c.
3214         * tui/tui-windata.h: Remove file.
3215         * tui/tui-windata.c: Remove file.
3216         * tui/tui-win.c (tui_data_window::set_new_height)
3217         (tui_data_window::do_make_visible_with_new_height): Move to
3218         tui-regs.c.
3219         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3220         * tui/tui-regs.c: Remove "structuring" comments.
3221         (tui_data_window::first_data_item_displayed)
3222         (tui_data_window::delete_data_content_windows)
3223         (tui_data_window::erase_data_content)
3224         (tui_data_window::display_all_data)
3225         (tui_data_window::refresh_all)
3226         (tui_data_window::do_scroll_vertical)
3227         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3228         (tui_data_window::do_make_visible_with_new_height)
3229         (tui_data_window::refresh_window): Move from elsewhere.
3230         (_initialize_tui_regs): Move to end of file.
3231         * tui/tui-layout.c: Update.
3232         * tui/tui-hooks.c: Update.
3233         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3234         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3235         tui-regs.c.
3236         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3237
3238 2019-07-17  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3241         seen.
3242
3243 2019-07-17  Tom Tromey  <tom@tromey.com>
3244
3245         * tui/tui-win.c (tui_source_window_base::set_new_height)
3246         (tui_source_window_base::do_make_visible_with_new_height): Use
3247         m_has_locator field directly.
3248         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3249         method.
3250         (struct tui_source_window_base) <has_locator>: Likewise.
3251
3252 2019-07-17  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3255         Don't declare.
3256         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3257         Remove.
3258         * tui/tui-win.c (tui_source_window_base::set_new_height)
3259         (tui_source_window_base::set_new_height)
3260         (make_invisible_and_set_new_height)
3261         (tui_source_window_base::do_make_visible_with_new_height)
3262         (tui_source_window_base::do_make_visible_with_new_height):
3263         Update.
3264         * tui/tui-layout.c (show_source_disasm_command, show_data)
3265         (show_source_or_disasm_and_command): Update.
3266         * tui/tui-layout.c (show_layout): Update.
3267
3268 2019-07-17  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-layout.c (make_data_window): Remove.
3271         (show_data): Unify creation and re-initialization cases.
3272
3273 2019-07-17  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-layout.c (make_source_window, make_disasm_window):
3276         Remove.
3277         (show_data): Unify creation and re-initialization cases.
3278
3279 2019-07-17  Tom Tromey  <tom@tromey.com>
3280
3281         * tui/tui-layout.c (make_command_window): Remove.
3282         (show_source_disasm_command, show_source_or_disasm_and_command):
3283         Unify creation and re-initialization cases.
3284
3285 2019-07-17  Tom Tromey  <tom@tromey.com>
3286
3287         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3288         creation and re-initialization cases.
3289
3290 2019-07-17  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-regs.c (tui_get_register): Return void.
3293
3294 2019-07-17  Tom Tromey  <tom@tromey.com>
3295
3296         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3297         Simplify.
3298
3299 2019-07-17  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3302         resetting.
3303
3304 2019-07-17  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3307         * tui/tui-regs.c (tui_reg_layout): New function.
3308         (tui_show_registers, tui_reg_command): Use it.
3309         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3310         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3311         parameters.
3312         (tui_layout_command): Remove.
3313
3314 2019-07-17  Tom Tromey  <tom@tromey.com>
3315
3316         * tui/tui-layout.h (tui/tui-layout): Return void.
3317         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3318
3319 2019-07-17  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui-layout.c (show_source_disasm_command, show_data):
3322         Update.
3323         (reset_locator): Remove.
3324         (show_source_or_disasm_and_command): Update.
3325
3326 2019-07-17  Tom Tromey  <tom@tromey.com>
3327
3328         * tui/tui-source.c (tui_source_window_base::reset): Remove
3329         win_type parameter.
3330         * tui/tui-layout.c (make_command_window, make_source_window)
3331         (make_disasm_window, make_data_window)
3332         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3333         (reset_locator, show_source_or_disasm_and_command): Update.
3334         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3335         win_type parameter.
3336         (struct tui_source_window_base) <reset>: Likewise.
3337
3338 2019-07-17  Tom Tromey  <tom@tromey.com>
3339
3340         * tui/tui-layout.c (show_source_disasm_command): Use
3341         reset_locator.
3342         (reset_locator): New function.
3343         (init_and_make_win): Remove.
3344         (show_source_or_disasm_and_command): Use reset_locator.
3345
3346 2019-07-17  Tom Tromey  <tom@tromey.com>
3347
3348         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3349         condition.
3350         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3351         Remove condition.
3352         * tui/tui-source.c (tui_source_window_base::reset): New method.
3353         * tui/tui-layout.c (make_command_window): Don't call
3354         init_and_make_win.
3355         (make_source_window, make_disasm_window): Don't call
3356         make_source_or_disasm_window.
3357         (make_data_window): Don't call init_and_make_win.  Change calling
3358         convention.
3359         (show_source_disasm_command, show_data): Simplify.
3360         (make_source_or_disasm_window): Remove.
3361         (show_source_or_disasm_and_command): Simplify.
3362         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3363         (struct tui_source_window_base) <reset>: Likewise.
3364         <execution_info>: Remove initializer.
3365         * tui/tui-data.c (tui_source_window_base): Initialize
3366         execution_info.
3367
3368 2019-07-17  Tom Tromey  <tom@tromey.com>
3369
3370         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3371         variable.
3372
3373 2019-07-17  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui.c (tui_rl_other_window): Update.
3376         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3377         superclass method first.  Always iterate over regs_content.
3378         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3379         method.
3380         * tui/tui-win.c (tui_set_focus_command): Update.
3381
3382 2019-07-17  Tom Tromey  <tom@tromey.com>
3383
3384         * tui/tui-win.c (tui_set_focus_command): Rename from
3385         tui_set_focus.  Call tui_enable.
3386         (tui_set_focus_command): Remove.
3387
3388 2019-07-17  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3391         refresh_window.
3392         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3393         touchwin.
3394         (tui_data_window::refresh_window): Call refresh_window on data
3395         items.  Always call superclass refresh_window.
3396         (tui_win_info::refresh): Remove.
3397         (tui_source_window_base::refresh_window): Update.
3398         (tui_refresh_all): Update.
3399         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3400         refresh_window.
3401         (show_source_or_disasm_and_command): Likewise.
3402         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3403         (struct tui_source_window_base) <refresh>: Likewise.
3404
3405 2019-07-17  Tom Tromey  <tom@tromey.com>
3406
3407         * tui/tui-winsource.c (tui_clear_source_content)
3408         (tui_show_source_content): Update.
3409         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3410         whether content is empty.
3411         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3412         Remove.
3413
3414 2019-07-17  Tom Tromey  <tom@tromey.com>
3415
3416         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3417         window's contents.
3418         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3419         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3420
3421 2019-07-17  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3424         (struct tui_data_item_window): Update.
3425
3426 2019-07-17  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3429         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3430         defines.
3431
3432 2019-07-17  Tom Tromey  <tom@tromey.com>
3433
3434         * tui/tui-winsource.h (tui_erase_source_content)
3435         (tui_clear_source_content): Remove "display_prompt" parameter.
3436         * tui/tui-winsource.c (tui_update_source_window_as_is)
3437         (tui_update_source_windows_with_addr): Update.
3438         (tui_clear_source_content): Remove "display_prompt" parameter.
3439         (tui_erase_source_content): Likewise.  Simplify.
3440         (tui_show_source_content): Update.
3441         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3442         * tui/tui-stack.c (tui_show_frame_info): Update.
3443         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3444         Remove defines.
3445
3446 2019-07-17  Tom Tromey  <tom@tromey.com>
3447
3448         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3449         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3450         parameter.
3451         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3452         parameter.
3453
3454 2019-07-17  Tom Tromey  <tom@tromey.com>
3455
3456         * tui/tui-winsource.c (tui_clear_source_content)
3457         (tui_show_source_content, tui_show_exec_info_content)
3458         (tui_clear_exec_info_content): Update.
3459         * tui/tui-stack.c (tui_show_locator_content): Update.
3460         (tui_show_frame_info): Update.
3461         * tui/tui-source.h (tui_source_window): Don't declare.
3462         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3463         from tui_source_is_displayed.
3464         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3465         Remove field.
3466         (struct tui_source_window_base) <content_in_use>: New field.  Now
3467         bool.
3468         (struct tui_source_window) <showing_source_p>: New method.
3469         (TUI_SRC_WIN): Change cast.
3470         * tui/tui-data.c (tui_initialize_static_data): Update.
3471
3472 2019-07-17  Tom Tromey  <tom@tromey.com>
3473
3474         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3475         location_matches_p.
3476         * tui/tui-source.c (tui_source_window::location_matches_p): New
3477         method.
3478         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3479         method.
3480         * tui/tui-data.h (struct tui_source_window_base)
3481         <location_matches_p>: New method.
3482         (struct tui_source_window, struct tui_disasm_window)
3483         <location_matches_p>: Likewise.
3484
3485 2019-07-17  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui-win.c (tui_set_win_height_command): Rename from
3488         tui_set_win_height.
3489         (tui_set_win_height_command): Remove.
3490
3491 2019-07-17  Tom Tromey  <tom@tromey.com>
3492
3493         * tui/tui-source.c (tui_source_window): New constructor.  Add
3494         observer.
3495         (~tui_source_window): New destructor.
3496         (tui_source_window::style_changed): New method.
3497         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3498         (tui_attach_detach_observers): Update.
3499         * tui/tui-data.h (struct tui_source_window): Make constructor not
3500         inline.  Add destructor.
3501         (struct tui_source_window) <style_changed>: New method.
3502         <m_observable>: New member.
3503
3504 2019-07-17  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3507         * tui/tui-win.c (tui_resize_all): Fix typo.
3508
3509 2019-07-17  Tom Tromey  <tom@tromey.com>
3510
3511         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3512         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3513         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3514         * tui/tui-win.c (window_name_completer): Use foreach.
3515         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3516         (update_tab_width): Likewise.
3517         * tui/tui-layout.c (show_layout): Update.
3518         * tui/tui-data.h (class tui_window_iterator): New.
3519         (struct all_tui_windows): New.
3520         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3521
3522 2019-07-17  Tom Tromey  <tom@tromey.com>
3523
3524         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3525         parameter.  Don't reference globals.
3526         (tui_reg_command): Update.
3527
3528 2019-07-17  Tom Tromey  <tom@tromey.com>
3529
3530         * tui/tui-regs.c (tui_show_registers): Simplify.
3531
3532 2019-07-17  Tom Tromey  <tom@tromey.com>
3533
3534         * tui/tui-regs.c (tui_show_registers): Update.
3535         (tui_show_register_group): Add win_info parameter.
3536
3537 2019-07-17  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3540         Rename from tui_display_reg_element_at_line.
3541         (tui_data_window::display_registers_from_line): Update.
3542         * tui/tui-data.h (struct tui_data_window)
3543         <display_reg_element_at_line>: New method.
3544
3545 2019-07-17  Tom Tromey  <tom@tromey.com>
3546
3547         * tui/tui-regs.h (tui_display_registers_from)
3548         (tui_display_registers_from_line): Don't declare.
3549         * tui/tui-windata.c (tui_data_window::display_all_data)
3550         (tui_data_window::refresh_all)
3551         (tui_data_window::do_scroll_vertical): Update.
3552         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3553         from tui_display_registers_from.
3554         (tui_display_reg_element_at_line): Update.
3555         (tui_data_window::display_registers_from_line): Rename from
3556         tui_display_registers_from_line.
3557         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3558         display_registers_from_line>: New methods.
3559
3560 2019-07-17  Tom Tromey  <tom@tromey.com>
3561
3562         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3563         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3564         from tui_erase_data_content.
3565         (tui_data_window::display_all_data)
3566         (tui_data_window::refresh_all)
3567         (tui_data_window::do_scroll_vertical): Update.
3568         * tui/tui-regs.c (tui_show_registers): Update.
3569         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3570         New method.
3571
3572 2019-07-17  Tom Tromey  <tom@tromey.com>
3573
3574         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3575         declare.
3576         * tui/tui-windata.c
3577         (tui_data_window::delete_data_content_windows): Rename from
3578         tui_delete_data_content_windows.
3579         (tui_data_window::display_all_data)
3580         (tui_data_window::do_scroll_vertical): Update.
3581         * tui/tui-data.h (struct tui_data_window)
3582         <delete_data_content_windows>: New method.
3583
3584 2019-07-17  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3587         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3588
3589 2019-07-17  Tom Tromey  <tom@tromey.com>
3590
3591         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3592         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3593         from tui_display_all_data.
3594         * tui/tui-win.c
3595         (tui_data_window::do_make_visible_with_new_height): Update.
3596         * tui/tui-regs.c (tui_show_registers): Update.
3597         * tui/tui-layout.c (tui_set_layout): Update.
3598         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3599         method.
3600
3601 2019-07-17  Tom Tromey  <tom@tromey.com>
3602
3603         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3604         * tui/tui-windata.c (tui_display_data_from): Remove.
3605         (tui_data_window::refresh_all): Update.
3606
3607 2019-07-17  Tom Tromey  <tom@tromey.com>
3608
3609         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3610         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3611         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3612         tui_display_registers_from_line.
3613         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3614         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3615         "force_display" parameter.
3616
3617 2019-07-17  Tom Tromey  <tom@tromey.com>
3618
3619         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3620         declare.
3621         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3622         Rename from tui_first_reg_element_no_inline.
3623         (tui_display_reg_element_at_line)
3624         (tui_display_registers_from_line): Update.
3625         * tui/tui-data.h (struct tui_data_window)
3626         <first_reg_element_no_inline>: New method.
3627
3628 2019-07-17  Tom Tromey  <tom@tromey.com>
3629
3630         * tui/tui-windata.c (tui_display_data_from)
3631         (tui_data_window::do_scroll_vertical): Update.
3632         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3633         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3634         Rename from tui_line_from_reg_element_no.
3635         (tui_display_registers_from_line): Update.
3636         * tui/tui-data.h (struct tui_data_window)
3637         <line_from_reg_element_no>: New method.
3638
3639 2019-07-17  Tom Tromey  <tom@tromey.com>
3640
3641         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3642         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3643         tui_last_regs_line_no.
3644         (tui_display_reg_element_at_line)
3645         (tui_display_registers_from_line): Update.
3646         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3647         method.
3648
3649 2019-07-17  Tom Tromey  <tom@tromey.com>
3650
3651         PR tui/24722:
3652         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3653         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3654         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3655         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3656         (tui_update_breakpoint_info): Likewise.
3657         * tui/tui-hooks.c (tui_event_create_breakpoint)
3658         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3659         Update.
3660
3661 2019-07-17  Tom Tromey  <tom@tromey.com>
3662
3663         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3664
3665 2019-07-17  Tom Tromey  <tom@tromey.com>
3666
3667         * tui/tui-winsource.c (tui_update_source_window_as_is)
3668         (tui_update_source_windows_with_addr): Update.
3669         * tui/tui-source.h (tui_set_source_content)
3670         (tui_show_symtab_source): Add "win_info" parameter.
3671         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3672         parameter.
3673         (tui_show_symtab_source): Likewise.
3674
3675 2019-07-17  Tom Tromey  <tom@tromey.com>
3676
3677         * tui/tui-wingeneral.c
3678         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3679
3680 2019-07-17  Tom Tromey  <tom@tromey.com>
3681
3682         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3683         (struct tui_cmd_window) <can_scroll>: New method.
3684         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3685         method.
3686
3687 2019-07-17  Tom Tromey  <tromey@adacore.com>
3688
3689         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3690         do_field_signed>: Rename.  Change type of "value".
3691         * ui-out.c (ui_out::field_signed): Rename from field_int.
3692         Change type of "value".
3693         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3694         type of "value".
3695         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3696         do_field_int.  Change type of "value".
3697         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3698         do_field_int.  Change type of "value".
3699         * tracepoint.c (trace_status_mi, tfind_1)
3700         (print_one_static_tracepoint_marker): Update.
3701         * thread.c (print_thread_info_1, print_selected_thread_frame):
3702         Update.
3703         * stack.c (print_frame, print_frame_info): Update.
3704         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3705         Update.
3706         * source.c (print_source_lines_base): Update.
3707         * skip.c (info_skip_command): Update.
3708         * record-btrace.c (btrace_ui_out_decode_error)
3709         (btrace_call_history_src_line): Update.
3710         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3711         Update.
3712         * progspace.c (print_program_space): Update.
3713         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3714         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3715         do_field_int.  Change type of "value".
3716         * mi/mi-out.c (mi_ui_out::do_table_begin)
3717         (mi_ui_out::do_table_header): Update.
3718         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3719         type of "value".
3720         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3721         (mi_cmd_data_list_changed_registers, output_register)
3722         (mi_cmd_data_read_memory, mi_load_progress)
3723         (mi_cmd_trace_frame_collected): Update.
3724         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3725         Update.
3726         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3727         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3728         (mi_cmd_var_list_children, varobj_update_one): Update.
3729         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3730         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3731         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3732         * inferior.c (print_inferior): Update.
3733         * gdb_bfd.c (print_one_bfd): Update.
3734         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3735         Update.
3736         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3737         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3738         do_field_int.  Change type of "value".
3739         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3740         do_field_int.  Change type of "value".
3741         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3742         (print_one_breakpoint_location, print_it_catch_fork)
3743         (print_one_catch_fork, print_it_catch_vfork)
3744         (print_one_catch_vfork, print_it_catch_solib)
3745         (print_it_catch_exec, print_it_ranged_breakpoint)
3746         (print_mention_watchpoint, print_mention_masked_watchpoint)
3747         (bkpt_print_it, update_static_tracepoint): Update.
3748         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3749         * break-catch-syscall.c (print_it_catch_syscall): Update.
3750         * ada-tasks.c (print_ada_task_info): Update.
3751         * ada-lang.c (print_it_exception, print_mention_exception):
3752         Update.
3753
3754 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3755
3756         PR breakpoints/24541
3757         * gdbarch.c: Regenerate.
3758         * gdbarch.h: Regenerate.
3759         * gdbarch.sh: Adjust return type and parameter types for
3760         'stap_adjust_register'.
3761         (i386_stap_adjust_register): Adjust signature and return new
3762         register name.
3763         * stap-probe.c (stap_parse_register_operand): Adjust use of
3764         'gdbarch_stap_adjust_register'.
3765
3766 2019-07-17  Tom Tromey  <tromey@adacore.com>
3767
3768         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3769         declare VEC.
3770         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3771         std::vector.
3772         (struct s390_process_info): Add initializers.
3773         (s390_add_process): Use new.
3774         (s390_linux_nat_target::low_forget_process): Use delete.
3775         (s390_linux_nat_target::low_new_fork)
3776         (s390_linux_nat_target::stopped_by_watchpoint)
3777         (s390_linux_nat_target::low_prepare_to_resume)
3778         (s390_linux_nat_target::insert_watchpoint)
3779         (s390_linux_nat_target::insert_hw_breakpoint)
3780         (s390_linux_nat_target::remove_watchpoint)
3781         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3782
3783 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3784
3785         * aarch64-fbsd-nat.c: Include regcache.h.
3786         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3787         argument.
3788         (aarch64_fbsd_nat_target::fetch_registers)
3789         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3790         variable.
3791         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3792
3793 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3794
3795         * fbsd-nat.c: Include gdbarch.h.
3796
3797 2019-07-15  Tom Tromey  <tromey@adacore.com>
3798
3799         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3800
3801 2019-07-15  Tom Tromey  <tromey@adacore.com>
3802
3803         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3804         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3805         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3806         * cli-out.c (cli_ui_out::do_field_int): New method.
3807         * ui-out.c (ui_out::field_unsigned): New method.
3808         * symfile.c (generic_load): Use field_unsigned.
3809         (print_transfer_performance): Likewise.
3810         * record-btrace.c (ui_out_field_uint): Remove.
3811         (btrace_call_history_insn_range, btrace_call_history): Use
3812         field_unsigned.
3813         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3814         field_unsigned.
3815         * ui-out.h (class ui_out) <field_unsigned>: New method.
3816         <do_field_unsigned>: Likewise.
3817
3818 2019-07-15  Tom Tromey  <tromey@adacore.com>
3819
3820         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3821         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3822         * target.c (flash_erase_command): Use field_string.
3823         * infrun.c (print_signal_received_reason): Use field_string.
3824         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3825         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3826         field_string.
3827         * ada-tasks.c (print_ada_task_info): Use field_string.
3828
3829 2019-07-15  Tom Tromey  <tromey@adacore.com>
3830
3831         * target.c (flash_erase_command): Use field_core_addr.
3832         * symfile.c (generic_load): Use field_core_addr.
3833         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3834         Use field_core_addr.
3835         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3836         field_core_addr.
3837
3838 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3839
3840         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3841         value if its desired type is smaller than a CORE_ADDR and signed.
3842
3843 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3844
3845         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3846         of changes to field names, and use new is_reference field to
3847         decide if a property is a reference or not.
3848         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3849         field.
3850         (struct dwarf2_property_baton): Update header comment, rename
3851         'referenced_type' to 'property_type' and update comments.
3852         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3853         default property type, store in property baton, update to take
3854         accound of renamed field.
3855         (read_func_scope): Update call to attr_to_dynamic_prop.
3856         (read_array_type): Likewise.
3857         (dwarf2_per_cu_addr_sized_int_type): New function.
3858         (read_subrange_index_type): Move type finding code to
3859         dwarf2_per_cu_addr_sized_int_type.
3860         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3861         (dwarf2_per_cu_addr_type): New function.
3862         (set_die_type): Update calls to attr_to_dynamic_prop.
3863
3864 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * dwarf2read.c (read_subrange_index_type): New function.
3867         (read_subrange_type): Move code into new function and call it.
3868         * gdbtypes.c (create_range_type): Add some asserts.
3869
3870 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3871
3872         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3873         update return statements.
3874         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3875         declaration, and update comment to match.
3876         * gdbtypes.c (resolve_dynamic_array): Update call to
3877         dwarf2_evaluate_property to match new return type.
3878
3879 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3880
3881         * valarith.c (value_subscripted_rvalue): Change lowerbound
3882         parameter type from int to LONGEST.
3883         * value.h (value_subscripted_rvalue): Likewise in declaration.
3884
3885 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3886
3887         * cli/cli-utils.c (info_print_command_completer): New function.
3888         * cli/cli-utils.h: Add 'completer.h' include, and forward
3889         declaration for 'struct cmd_list_element'.
3890         (info_print_command_completer): Declare.
3891         * stack.c (_initialize_stack): Add completer for 'info locals' and
3892         'info args'.
3893         * symtab.c (_initialize_symtab): Add completer for 'info
3894         variables' and 'info functions'.
3895         * NEWS: Mention completion for additional info commands.
3896
3897 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3898
3899         * cli/cli-utils.c (extract_info_print_args): Delete.
3900         (extract_arg_maybe_quoted): Delete.
3901         (info_print_options_defs): New variable.
3902         (make_info_print_options_def_group): New function.
3903         (extract_info_print_options): Define new function.
3904         * cli/cli-utils.h (extract_info_print_args): Delete.
3905         (struct info_print_options): New structure.
3906         (extract_info_print_options): Declare new function.
3907         * stack.c (info_locals_command): Update to use new
3908         extract_info_print_options, also add a header comment.
3909         (info_args_command): Likewise.
3910         * symtab.c (info_variables_command): Likewise.
3911         (info_functions_command): Likewise.
3912
3913 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3914
3915         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3916         to extract string arguments.
3917         * common/common-utils.c (extract_string_maybe_quoted): New function.
3918         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3919
3920 2019-07-11  Tom Tromey  <tromey@adacore.com>
3921
3922         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3923         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3924         * top.h (gdbinit): Don't declare.
3925         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3926         into...
3927         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3928         * top.c (gdb_init): Don't call init_cli_cmds.
3929         (gdbinit): Remove.
3930         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3931
3932 2019-07-11  Tom Tromey  <tromey@adacore.com>
3933
3934         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3935         after it has been moved.
3936
3937 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3938
3939         * valops.c (value_must_coerce_to_target): Change return type to
3940         bool.
3941         * value.h (value_must_coerce_to_target): Likewise.
3942
3943 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3944
3945         * breakpoint.c (is_hardware_watchpoint): Remove
3946         forward-declaration.
3947         (is_masked_watchpoint): Change return type to bool.
3948         (is_tracepoint): Likewise.
3949         (is_breakpoint): Likewise.
3950         (is_hardware_watchpoint): Likewise.
3951         (is_watchpoint): Likewise.
3952         (is_no_memory_software_watchpoint): Likewise.
3953         (is_catchpoint): Likewise.
3954         (breakpoint_1): Make FILTER parameter's return type bool.
3955         is_masked_watchpoint): Change return type to bool.
3956         (save_breakpoints): Make FILTER parameter's return type bool.
3957         * breakpoint.h (is_breakpoint): Change return type to bool.
3958         (is_watchpoint): Likewise.
3959         (is_catchpoint): Likewise.
3960         (is_tracepoint): Likewise.
3961
3962 2019-07-10  Tom Tromey  <tom@tromey.com>
3963
3964         * defs.h: Don't include gdbarch.h.
3965         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3966         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3967         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3968         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3969         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3970         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3971         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3972         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3973         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3974         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3975         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3976         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3977         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3978         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3979         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3980         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3981         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3982         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3983         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3984         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3985         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3986         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3987         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3988         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3989         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3990         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3991         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3992
3993 2019-07-10  Tom Tromey  <tromey@adacore.com>
3994
3995         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3996         * breakpoint.c (init_ada_exception_breakpoint): Register as
3997         bp_catchpoint.
3998         (print_one_breakpoint_location, print_one_breakpoint): Use
3999         is_ada_exception_catchpoint.
4000         * ada-lang.c (class ada_catchpoint_location): Pass
4001         bp_loc_software_breakpoint to bp_location constructor.
4002         (is_ada_exception_catchpoint): New function.
4003
4004 2019-07-10  Tom Tromey  <tromey@adacore.com>
4005
4006         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4007         VEC.
4008         (struct arm_exidx_entry): New method operator<.
4009         (struct arm_exidx_data) <section_maps>: Change type.
4010         (arm_exidx_data_free): Remove.
4011         (arm_exidx_data_key): Change type.  Move lower.
4012         (arm_exidx_new_objfile): Update.
4013         (arm_compare_exidx_entries): Remove.
4014         (arm_find_exidx_entry, _initialize_arm_tdep)
4015
4016 2019-07-10  Tom Tromey  <tromey@adacore.com>
4017
4018         * solib-spu.c (ocl_program_data_key): Change type.
4019         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4020         Update.
4021
4022 2019-07-10  Tom Tromey  <tromey@adacore.com>
4023
4024         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4025         (struct solib_aix_inferior_data) <library_list>: Change type.
4026         (solib_aix_inferior_data_handle): Change type.
4027         (get_solib_aix_inferior_data): Update.
4028         (solib_aix_free_library_list): Remove.
4029         (library_list_start_library): Update.
4030         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4031         return type.
4032         (solib_aix_get_library_list)
4033         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4034         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4035
4036 2019-07-10  Tom Tromey  <tromey@adacore.com>
4037
4038         * solib-dsbt.c (struct dsbt_info): Add initializers.
4039         (solib_dsbt_pspace_data): Change type.
4040         (dsbt_pspace_data_cleanup): Remove.
4041         (get_dsbt_info, _initialize_dsbt_solib): Update.
4042
4043 2019-07-10  Tom Tromey  <tromey@adacore.com>
4044
4045         * spu-tdep.c (spu_overlay_data): Change type.
4046         (spu_get_overlay_table, spu_overlay_new_objfile)
4047         (_initialize_spu_tdep): Update.
4048
4049 2019-07-10  Tom Tromey  <tromey@adacore.com>
4050
4051         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4052         destructor.
4053         (dbx_objfile_data_key): Change type and declare later.
4054         (DBX_SYMFILE_INFO): Rewrite.
4055         * dbxread.c (dbx_objfile_data_key): Change type.
4056         (dbx_symfile_init): Update.
4057         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4058         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4059         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4060
4061 2019-07-10  Tom Tromey  <tromey@adacore.com>
4062
4063         * jit.c (jit_program_space_key): Change type.  Move lower.
4064         (get_jit_program_space_data): Update.
4065         (jit_program_space_data_cleanup): Remove.
4066         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4067         Update.
4068         (struct jit_program_space_data): Add initializers.
4069
4070 2019-07-10  Tom Tromey  <tromey@adacore.com>
4071
4072         * solib-darwin.c (struct darwin_info): Add initializers.
4073         (solib_darwin_pspace_data): Change type.
4074         (darwin_pspace_data_cleanup): Remove.
4075         (get_darwin_info, _initialize_darwin_solib): Update.
4076
4077 2019-07-10  Tom Tromey  <tromey@adacore.com>
4078
4079         * remote-sim.c (struct sim_inferior_data): Add initializers,
4080         constructor, and destructor.
4081         (sim_inferior_data_key): Change type.  Move lower.
4082         (check_for_duplicate_sim_descriptor): Update.
4083         (get_sim_inferior_data): Use new.  Update.
4084         (~sim_inferior_data_cleanup): Rename from
4085         sim_inferior_data_cleanup.  Simplify.
4086         (gdbsim_close_inferior, simulator_command)
4087         (sim_command_completer, _initialize_remote_sim): Update.
4088         (next_pid, INITIAL_PID): Move earlier.
4089
4090 2019-07-10  Tom Tromey  <tromey@adacore.com>
4091
4092         * python/python-internal.h (create_thread_object): Return
4093         gdbpy_ref.
4094         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4095         * python/py-inferior.c (struct threadlist_entry): Add
4096         constructor.
4097         <thread_obj>: Now a gdbpy_ref.
4098         (thread_to_thread_object): Update.
4099         (add_thread_object): Use new.
4100         (delete_thread_object): Use delete.
4101         (infpy_threads): Update.
4102         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4103         GIL.
4104
4105 2019-07-10  Tom Tromey  <tromey@adacore.com>
4106
4107         * valops.c (value_cast): Specialize error message for Ada.
4108
4109 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4110
4111         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4112
4113 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4114
4115         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4116         bpstat_should_step): Return bool, adjust comments.
4117         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4118         bpstat_should_step): Likewise.
4119
4120 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4121
4122         * features/Makefile: Use feature target descriptions for Arm.
4123         * features/arm/arm-core.c: Generate new file.
4124         * features/arm/arm-fpa.c: Likewise.
4125         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4126         * features/arm/arm-m-profile.c: Likewise.
4127         * features/arm/arm-vfpv2.c: Likewise.
4128         * features/arm/arm-vfpv3.c: Likewise.
4129         * features/arm/xscale-iwmmxt.c: Likewise.
4130         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4131
4132 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4133
4134         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4135         ptrace earlier.
4136
4137 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4138
4139         * features/aarch64-pauth.c: Regenerate.
4140
4141 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4142
4143         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4144         bool.
4145         (bpstat_what): Use false instead of 0.
4146
4147 2019-07-09  Pedro Alves  <palves@redhat.com>
4148
4149         * break-catch-throw.c (is_exception_catchpoint): New.
4150         * breakpoint.c (print_one_breakpoint_location): New parameter
4151         'raw_loc'.  Handle it.  Use
4152         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4153         looking at the breakpoint's type.
4154         (print_one_breakpoint): If handling "maint info breakpoints", also
4155         print locations of exception catchpoints.
4156         * breakpoint.h (is_exception_catchpoint): Declare.
4157
4158 2019-07-09  Pedro Alves  <palves@redhat.com>
4159
4160         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4161         "addr" field.
4162         (allocate_location_exception_catchpoint): New.
4163         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4164         (initialize_throw_catchpoint_ops): Install
4165         allocate_location_exception_catchpoint as allocate_location
4166         method.
4167         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4168         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4169         bp_loc_other.
4170         (breakpoint_address_is_meaningful): Delete.
4171         (bl_address_is_meaningful): New.
4172         (breakpoint_locations_match): Adjust comment.
4173         (bp_location_from_bp_type): New, factored out of...
4174         (bp_location::bp_location(breakpoint *)): ... this.
4175         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4176         factored out of...
4177         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4178         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4179         breakpoint_address_is_meaningful.
4180         (bp_locations_compare): Adjust comment.
4181         (update_global_location_list): Use bl_address_is_meaningful
4182         instead of breakpoint_address_is_meaningful.
4183         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4184         explicit.
4185         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4186         * python/py-breakpoint.c (bppy_get_location): No longer check
4187         whether location is null.
4188
4189 2019-07-09  Pedro Alves  <palves@redhat.com>
4190
4191         PR c++/15468
4192         * breakpoint.c (print_one_breakpoint_location): Remove
4193         single-location assert.
4194
4195 2019-07-09  Tom Tromey  <tom@tromey.com>
4196
4197         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4198         * configure: Rebuild.
4199         * configure.ac: Change common to gdbsupport.
4200         * gdbsupport: Rename from common.
4201         * acinclude.m4: Change common to gdbsupport.
4202         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4203         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4204         gdbsupport.
4205         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4206         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4207         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4208         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4209         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4210         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4211         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4212         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4213         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4214         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4215         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4216         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4217         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4218         coff-pe-read.c, command.h, compile/compile-c-support.c,
4219         compile/compile-c.h, compile/compile-cplus-symbols.c,
4220         compile/compile-cplus-types.c, compile/compile-cplus.h,
4221         compile/compile-loc2c.c, compile/compile.c, completer.c,
4222         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4223         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4224         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4225         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4226         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4227         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4228         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4229         features/aarch64-core.c, features/aarch64-fpu.c,
4230         features/aarch64-pauth.c, features/aarch64-sve.c,
4231         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4232         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4233         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4234         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4235         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4236         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4237         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4238         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4239         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4240         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4241         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4242         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4243         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4244         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4245         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4246         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4247         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4248         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4249         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4250         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4251         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4252         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4253         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4254         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4255         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4256         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4257         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4258         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4259         minsyms.c, mips-linux-tdep.c, namespace.h,
4260         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4261         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4262         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4263         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4264         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4265         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4266         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4267         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4268         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4269         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4270         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4271         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4272         procfs.c, producer.c, progspace.h, psymtab.h,
4273         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4274         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4275         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4276         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4277         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4278         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4279         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4280         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4281         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4282         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4283         target-memory.c, target.c, target.h, target/waitstatus.c,
4284         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4285         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4286         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4287         unittests/array-view-selftests.c,
4288         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4289         unittests/common-utils-selftests.c,
4290         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4291         unittests/format_pieces-selftests.c,
4292         unittests/function-view-selftests.c,
4293         unittests/lookup_name_info-selftests.c,
4294         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4295         unittests/mkdir-recursive-selftests.c,
4296         unittests/observable-selftests.c,
4297         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4298         unittests/parse-connection-spec-selftests.c,
4299         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4300         unittests/scoped_fd-selftests.c,
4301         unittests/scoped_mmap-selftests.c,
4302         unittests/scoped_restore-selftests.c,
4303         unittests/string_view-selftests.c, unittests/style-selftests.c,
4304         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4305         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4306         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4307         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4308         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4309         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4310
4311 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4312
4313         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4314         bool value.
4315         (decode_digits_ordinary): Set explicit_line field in sal.
4316         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4317         symtab_and_line that was set on an explicit line number in
4318         assembler code.  Do always update the recorded symtab and line if
4319         we do skip the prologue.
4320
4321 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4322
4323         * breakpoint.c (set_breakpoint_location_function): Remove
4324         explicit_loc parameter.
4325         (momentary_breakpoint_from_master): Update call to
4326         set_breakpoint_location_function.
4327         (add_location_to_breakpoint): Likewise.
4328
4329 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4330
4331         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4332         required features based on default bfd type when no specific bfd
4333         is present.
4334
4335 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4336
4337         * NEWS: Mention that GDB printf and eval commands can now print
4338         C-style and Ada-style convenience var strings without
4339         calling the inferior.
4340         * printcmd.c (printf_c_string): Locally print GDB internal var
4341         instead of transiting via the inferior.
4342         (printf_wide_c_string): Likewise.
4343
4344 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4345
4346         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4347
4348 2019-07-04  Tom Tromey  <tom@tromey.com>
4349
4350         PR tui/24724:
4351         * tui/tui-winsource.c (tui_clear_source_content): Update.
4352         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4353         (tui_update_breakpoint_info): Update.
4354         (tui_set_exec_info_content): Update.
4355         * tui/tui-source.c (tui_set_source_content_nil): Update.
4356         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4357         has_break.
4358         * tui/tui-data.h (enum tui_bp_flag): New.
4359         (tui_bp_flags): New enum flags type.
4360         (struct tui_source_element) <break_mode>: Change type.  Rename
4361         from has_break.
4362         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4363         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4364         constants.
4365         * tui/tui-winsource.h: Fix comment.
4366
4367 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4368
4369         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4370         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4371         (store_fpregs_to_thread)
4372         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4373         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4374         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4375         (IWMMXT_REGS_SIZE): Add define.
4376         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4377         (fetch_vfp_regs, store_vfp_regs)
4378         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4379         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4380
4381 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4382
4383         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4384         defines.
4385         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4386         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4387         (ARM_INT_REGISTER_SIZE): ...to this.
4388         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4389         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4390         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4391         (arm_linux_collect_gregset, supply_nwfpe_register)
4392         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4393         defines.
4394         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4395         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4396         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4397         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4398         (arm_return_in_memory, arm_store_return_value)
4399         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4400         (arm_record_ld_st_multiple): Likewise.
4401         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4402         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4403
4404 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4405
4406         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4407         AARCH64_DISPLACED_MODIFIED_INSNS.
4408         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4409         (aarch64_displaced_step_copy_insn): Likewise.
4410         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4411         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4412         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4413         ARM_DISPLACED_MODIFIED_INSNS.
4414         * arm-tdep.c (arm_gdbarch_init): Likewise.
4415         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4416         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4417         (struct arm_displaced_step_closure): Use
4418         ARM_DISPLACED_MODIFIED_INSNS.
4419
4420 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4421
4422         * features/Makefile: Remove unused xml files.
4423         * features/aarch64.xml: Remove.
4424         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4425         * features/i386/amd64-avx-avx512.xml: Remove.
4426         * features/i386/amd64-avx-linux.xml: Remove.
4427         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4428         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4429         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4430         * features/i386/amd64-avx-mpx.xml: Remove.
4431         * features/i386/amd64-avx.xml: Remove.
4432         * features/i386/amd64-linux.xml: Remove.
4433         * features/i386/amd64-mpx-linux.xml: Remove.
4434         * features/i386/amd64-mpx.xml: Remove.
4435         * features/i386/amd64.xml: Remove.
4436         * features/i386/i386-avx-avx512-linux.xml: Remove.
4437         * features/i386/i386-avx-avx512.xml: Remove.
4438         * features/i386/i386-avx-linux.xml: Remove.
4439         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4440         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4441         * features/i386/i386-avx-mpx-linux.xml: Remove.
4442         * features/i386/i386-avx-mpx.xml: Remove.
4443         * features/i386/i386-avx.xml: Remove.
4444         * features/i386/i386-linux.xml: Remove.
4445         * features/i386/i386-mmx-linux.xml: Remove.
4446         * features/i386/i386-mmx.xml: Remove.
4447         * features/i386/i386-mpx-linux.xml: Remove.
4448         * features/i386/i386-mpx.xml: Remove.
4449         * features/i386/i386.xml: Remove.
4450         * features/i386/x32-avx-avx512-linux.xml: Remove.
4451         * features/i386/x32-avx-linux.xml: Remove.
4452         * features/i386/x32-linux.xml: Remove.
4453
4454 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4455
4456         * regformats/aarch64.dat: Remove.
4457         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4458         * regformats/i386/amd64-avx-linux.dat: Remove.
4459         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4460         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4461         * regformats/i386/amd64-linux.dat: Remove.
4462         * regformats/i386/amd64-mpx-linux.dat: Remove.
4463         * regformats/i386/amd64.dat: Remove.
4464         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4465         * regformats/i386/i386-avx-linux.dat: Remove.
4466         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4467         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4468         * regformats/i386/i386-linux.dat: Remove.
4469         * regformats/i386/i386-mmx-linux.dat: Remove.
4470         * regformats/i386/i386-mpx-linux.dat: Remove.
4471         * regformats/i386/i386.dat: Remove.
4472         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4473         * regformats/i386/x32-avx-linux.dat: Remove.
4474         * regformats/i386/x32-linux.dat: Remove.
4475
4476 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4477
4478         * aarch64-tdep.c: Remove xml self tests.
4479         * amd64-linux-tdep.c: Likewise.
4480         * amd64-tdep.c: Likewise.
4481         * i386-linux-tdep.c: Likewise.
4482         * i386-tdep.c: Likewise.
4483
4484 2019-07-03  Pedro Alves  <palves@redhat.com>
4485
4486         PR cli/24732
4487         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4488         (pipe_cmd_option_defs): New.
4489         (make_pipe_cmd_options_def_group): New.
4490         (pipe_command): Use gdb::option::process_options.
4491         (pipe_command_completer): New function.
4492         (_initialize_cli_cmds): Install completer for "pipe" command.
4493
4494 2019-07-03  Pedro Alves  <palves@redhat.com>
4495
4496         * cli/cli-option.c (union option_value) <string>: New field.
4497         (struct option_def_and_value): Add ctor, move ctor, dtor and
4498         use DISABLE_COPY_AND_ASSIGN.
4499         (option_def_and_value::clear_value): New.
4500         (parse_option, save_option_value_in_ctx, get_val_type_str)
4501         (add_setshow_cmds_for_options): Handle var_string.
4502         * cli-option.h (union option_def::var_address) <string>: New
4503         field.
4504         (struct string_option_def): New.
4505         * maint-test-options.c (struct test_options_opts): Add default
4506         ctor and use DISABLE_COPY_AND_ASSIGN.
4507         <string_opt>: New field.
4508         (test_options_opts::~test_options_opts): New.
4509         (test_options_opts::dump): Also dump "-string".
4510         (test_options_option_defs): Install "string.
4511
4512 2019-07-03  Pedro Alves  <palves@redhat.com>
4513
4514         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4515         option_value with a null enumeration.
4516         (complete_options): Save the option values in the context.
4517         (save_option_value_in_ctx): New, factored out from ...
4518         (process_options): ... here.
4519         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4520         of the function.
4521         * maint-test-options.c (test_options_opts::dump): New, factored
4522         out from ...
4523         (maintenance_test_options_command_mode): ... here.
4524         (maintenance_test_options_command_completion_result): Delete.
4525         (maintenance_test_options_command_completion_text): Update
4526         comment.
4527         (maintenance_show_test_options_completion_result): Change
4528         prototype.  Just print
4529         maintenance_test_options_command_completion_text.
4530         (save_completion_result): New.
4531         (maintenance_test_options_completer_mode): Pass options context to
4532         complete_options, and then save a dump.
4533         (_initialize_maint_test_options): Use add_cmd to install "maint
4534         show test-options-completion-result".
4535
4536 2019-07-03  Pedro Alves  <palves@redhat.com>
4537
4538         * NEWS (New commands): Mention "with" and "maint with".
4539         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4540         (with_command, with_command_completer): New.
4541         (pipe_command): Adjust to new repeat_previous
4542         interface.
4543         (_initialize_cli_cmds): Install the "with" command and its "w"
4544         alias.
4545         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4546         declarations.
4547         * cli/cli-setshow.c (parse_cli_var_uinteger)
4548         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4549         argument strings for all var_types.
4550         (get_setshow_command_value_string): New, factored out from ...
4551         (do_show_command): ... this.
4552         * cli/cli-setshow.h: Include <string>.
4553         (get_setshow_command_value_string): Declare.
4554         * command.h (repeat_previous): Now returns const char *.  Adjust
4555         comment.
4556         * maint.c: Include "cli/cli-cmds.h".
4557         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4558         (_initialize_maint_cmds): Register the "maintenance with" command.
4559         * top.c (repeat_previous): Move bits from pipe_command here:
4560         Return the saved command line, if any; error out if there's no
4561         command to relaunch.
4562
4563 2019-07-03  Pedro Alves  <palves@redhat.com>
4564
4565         * NEWS (New commands): Mention "maint set/show test-settings"
4566         instead of "maint test-settings".
4567         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4568         (maintenance_test_settings_set_list): Rename to ...
4569         (maintenance_set_test_settings_list): ... this.
4570         (maintenance_test_settings_show_list): Rename to  ...
4571         (maintenance_show_test_settings_list): ... this.
4572         (maintenance_test_settings_cmd): Delete.
4573         (maintenance_test_settings_set_cmd): ...
4574         (maintenance_set_test_settings_cmd): ... this.
4575         (maintenance_test_settings_show_cmd): ...
4576         (maintenance_show_test_settings_cmd): ... this.
4577         (maintenance_test_settings_show_value_cmd):
4578         (maintenance_show_test_settings_value_cmd): ... this.
4579         (_initialize_maint_test_settings): No longer install the "maint
4580         test-settings" prefix command.  Rename "maint test-settings set"
4581         to "maint set test-settings", and "maint test-settings show" to
4582         "maint show test-settings".  Adjust all subcommands.
4583
4584 2019-07-03  Pedro Alves  <palves@redhat.com>
4585
4586         * maint-test-settings.c: Fix file's intro comment.  Replace all
4587         references to "test-options" with references to "test-settings",
4588         in comments.
4589
4590 2019-07-03  Pedro Alves  <palves@redhat.com>
4591
4592         * maint-test-settings.c (maintenance_test_settings_xxx)
4593         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4594         New.
4595         (maintenance_test_settings_enums): Use them.
4596         (maintenance_test_settings_enum): Default to
4597         maintenance_test_settings_xxx.
4598         (_initialize_maint_test_settings): Initialize
4599         MAINTENANCE_TEST_SETTINGS_FILENAME.
4600
4601 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4602
4603         * breakpoint.h (remove_breakpoints_inf): Change return type to
4604         void, move function documentation here.
4605         * breakpoint.c (remove_breakpoints_inf): Change return type to
4606         void, move function documentation to header.
4607
4608 2019-07-02  Pedro Alves  <palves@redhat.com>
4609
4610         * NEWS (Completion improvements): Mention "info threads".
4611         * thread.c (struct info_threads_opts, info_threads_option_defs)
4612         (make_info_threads_options_def_group): New.
4613         (info_threads_command): Use gdb::option::process_options.
4614         (info_threads_command_completer): New.
4615         (_initialize_thread): Use gdb::option::build_help to build the
4616         help text for "info threads".
4617
4618 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4619
4620         * defs.h (generic_load): Move from here...
4621         * symfile.h (generic_load): ... to here.  Rename name parameter
4622         to args.
4623         * symfile.c (generic_load): Add comment.
4624
4625 2019-07-01  Tom Tromey  <tromey@adacore.com>
4626
4627         * dwarf2read.c
4628         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4629         declaration of without_params.  Fix formatting.
4630
4631 2019-07-01  Tom Tromey  <tromey@adacore.com>
4632
4633         * ada-exp.y (find_primitive_type): Update.
4634         * ada-lang.h (ada_lookup_symbol): Update.
4635         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4636         parameter.
4637         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4638
4639 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4640
4641         PR breakpoints/24541
4642         * gdbarch.c: Regenerate.
4643         * gdbarch.h: Regenerate.
4644         * gdbarch.sh: Add 'stap_adjust_register'.
4645         * i386-tdep.c: Include '<unordered_set>'.
4646         (i386_stap_adjust_register): New function.
4647         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4648         * stap-probe.c (stap_parse_register_operand): Call
4649         'gdbarch_stap_adjust_register'.
4650
4651 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4652
4653         PR python/24742
4654         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4655         * python/python.c (do_start_initialization): Use 'xmalloc'
4656         instead of 'PyMem_Malloc'.
4657
4658 2019-06-28  Tom Tromey  <tromey@adacore.com>
4659
4660         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4661         for Ada.
4662
4663 2019-06-27  Tom Tromey  <tromey@adacore.com>
4664
4665         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4666         objfile_key.
4667         (arm_find_mapping_symbol, arm_record_special_symbol)
4668         (_initialize_arm_tdep): Update.
4669         (arm_objfile_data_free): Remove.
4670
4671 2019-06-27  Tom Tromey  <tromey@adacore.com>
4672
4673         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4674         to cp_print_static_field.
4675
4676 2019-06-26  Tom Tromey  <tromey@adacore.com>
4677
4678         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4679         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4680         declare.
4681
4682 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4683
4684         * features/aarch64-core.c (create_feature_aarch64_core):
4685         Regenerate.
4686         * features/aarch64-core.xml: Add cpsr flags.
4687
4688 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4689
4690         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4691         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4692
4693 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4694
4695         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4696         field.
4697         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4698         use.
4699         (arm_record_special_symbol): Don't insert new symbol in sorted
4700         position, push it at the end.
4701
4702 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4703
4704         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4705         (arm_mapping_symbol_s): Remove.
4706         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4707         (arm_mapping_symbol_vec): New typedef.
4708         (struct arm_per_objfile): Add constructor.
4709         <section_maps>: Change type to
4710         std::unique_ptr<arm_mapping_symbol_vec[]>.
4711         (arm_compare_mapping_symbols): Remove.
4712         (arm_find_mapping_symbol): Adjust to section_maps type change.
4713         (arm_objfile_data_free): Call delete on arm_per_objfile.
4714         (arm_record_special_symbol): Adjust to section_maps type change.
4715         Allocate arm_per_objfile with new.
4716
4717 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4718
4719         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4720         with the command prefix.
4721
4722 2019-06-25  Tom Tromey  <tom@tromey.com>
4723
4724         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4725         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4726
4727 2019-06-25  Tom Tromey  <tom@tromey.com>
4728
4729         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4730         type.
4731         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4732         protected.
4733
4734 2019-06-25  Tom Tromey  <tom@tromey.com>
4735
4736         * tui/tui-winsource.c
4737         (tui_source_window_base::set_is_exec_point_at): Add check against
4738         LOA_ADDRESS.
4739
4740 2019-06-25  Tom Tromey  <tom@tromey.com>
4741
4742         * tui/tui-source.c (tui_set_source_content): Don't check before
4743         xfree.
4744         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4745
4746 2019-06-25  Tom Tromey  <tom@tromey.com>
4747
4748         * tui/tui-winsource.h (tui_update_source_window_as_is)
4749         (tui_alloc_source_buffer, tui_line_is_displayed)
4750         (tui_addr_is_displayed): Change type of win_info.
4751         * tui/tui-winsource.c (tui_update_source_window_as_is)
4752         (tui_clear_source_content, tui_show_source_line)
4753         (tui_show_source_content, tui_source_window_base::refill)
4754         (tui_source_window_base::set_is_exec_point_at)
4755         (tui_source_window_base::set_is_exec_point_at)
4756         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4757         (tui_alloc_source_buffer, tui_line_is_displayed)
4758         (tui_addr_is_displayed): Change type of win_info.  Update.
4759         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4760         (tui_source_window_base::do_make_visible_with_new_height):
4761         Update.
4762         * tui/tui-source.c (tui_set_source_content)
4763         (tui_set_source_content_nil)
4764         (tui_source_window::do_scroll_vertical): Update.
4765         * tui/tui-layout.c (show_layout): Update.
4766         * tui/tui-disasm.c (tui_set_disassem_content)
4767         (tui_disasm_window::do_scroll_vertical): Update.
4768         * tui/tui-data.h (tui_win_content): Remove.
4769         (struct tui_gen_win_info) <content, content_size>: Remove.
4770         (struct tui_source_element): Add initializers and destructor.
4771         (union tui_which_element, struct tui_win_element): Remove.
4772         (struct tui_source_window_base) <content>: New field.
4773         (struct tui_data_window): Remove destructor.
4774         (tui_alloc_content, tui_free_win_content)
4775         (tui_free_all_source_wins_content): Don't declare.
4776         * tui/tui-data.c (tui_initialize_static_data): Update.
4777         (init_content_element, tui_alloc_content): Remove.
4778         (~tui_gen_win_info): Update.
4779         (~tui_data_window, tui_free_all_source_wins_content)
4780         (tui_free_win_content, free_content, free_content_elements):
4781         Remove.
4782
4783 2019-06-25  Tom Tromey  <tom@tromey.com>
4784
4785         * tui/tui-winsource.h (tui_clear_source_content)
4786         (tui_erase_source_content, tui_show_source_content): Change type
4787         of win_info.
4788         * tui/tui-winsource.c (tui_clear_source_content)
4789         (tui_erase_source_content, tui_show_source_content): Change type
4790         of win_info.
4791         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4792         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4793         win_info.
4794         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4795         win_info.
4796         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4797
4798 2019-06-25  Tom Tromey  <tom@tromey.com>
4799
4800         * tui/tui-winsource.c (tui_clear_source_content)
4801         (tui_source_window_base::set_is_exec_point_at): Update.
4802         * tui/tui-source.c (tui_set_source_content_nil): Update.
4803         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4804         a bool.
4805         * tui/tui-data.c (init_content_element): Update.
4806
4807 2019-06-25  Tom Tromey  <tom@tromey.com>
4808
4809         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4810         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4811         * tui/tui-layout.c (init_and_make_win): Update.
4812         * tui/tui.h (enum tui_win_type): Update.
4813         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4814         tui_win_is_auxillary.
4815         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4816         tui_win_is_auxillary.
4817
4818 2019-06-25  Tom Tromey  <tom@tromey.com>
4819
4820         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4821         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4822         (tui_delete_data_content_windows, tui_display_all_data)
4823         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4824         Update.
4825         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4826         * tui/tui-regs.c (tui_last_regs_line_no)
4827         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4828         (tui_show_registers): Update.
4829         (tui_show_register_group): Return void.  Update.
4830         (tui_display_registers_from, tui_display_reg_element_at_line)
4831         (tui_display_registers_from_line, tui_check_register_values):
4832         Update.
4833         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4834         member.
4835         (struct tui_data_window) <regs_content>: Now a std::vector.
4836         <regs_content_count>: Remove.
4837         (tui_add_content_elements, tui_free_data_content): Don't declare.
4838         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4839         (init_content_element): Remove DATA_WIN case.  Add assert.
4840         (tui_add_content_elements): Remove.
4841         (tui_data_window): Update.
4842         (tui_free_data_content): Remove.
4843         (free_content_elements): Remove DATA_WIN case.
4844
4845 2019-06-25  Tom Tromey  <tom@tromey.com>
4846
4847         * tui/tui-data.c (tui_data_item_window): Update.
4848         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4849         * tui/tui-windata.c (tui_display_all_data)
4850         (tui_display_data_from_line): Update.
4851         (tui_check_data_values): Remove.
4852         * tui/tui-regs.c (tui_show_register_group)
4853         (tui_display_reg_element_at_line): Update.
4854         * tui/tui-hooks.c (tui_register_changed)
4855         (tui_refresh_frame_and_register_information): Call
4856         tui_check_register_values.
4857         * tui/tui-data.h (struct tui_data_window) <data_content,
4858         data_content_count, data_type>: Remove.
4859         (enum tui_data_type): Remove.
4860
4861         * tui/tui-data.c (tui_data_window::clear_detail)
4862         (~tui_data_window): Update.
4863
4864 2019-06-25  Tom Tromey  <tom@tromey.com>
4865
4866         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4867         declare.
4868         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4869         Rename from tui_first_data_item_displayed.  Update.
4870         (tui_data_window::refresh_all)
4871         (tui_data_window::do_scroll_vertical): Update.
4872         * tui/tui-data.h (struct tui_data_window)
4873         <first_data_item_displayed>: Declare new method.
4874
4875 2019-06-25  Tom Tromey  <tom@tromey.com>
4876
4877         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4878         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4879         contents...
4880         (tui_initialize_static_data): ...here.
4881
4882 2019-06-25  Tom Tromey  <tom@tromey.com>
4883
4884         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4885         (tui_display_registers_from, tui_check_register_values): Update.
4886         (tui_display_register): Remove win_info parameter; update.
4887         (tui_get_register): Change type of parameters.
4888         * tui/tui-data.h (struct tui_data_element): Remove.
4889         (union tui_which_element) <data>: Remove.
4890         <data_window>: Change type.
4891         (struct tui_data_item_window): New.
4892         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4893         case.  Add assert.
4894         (~tui_data_item_window): New destructor.
4895         (free_content_elements): Remove DATA_ITEM_WIN case.
4896
4897 2019-06-25  Tom Tromey  <tom@tromey.com>
4898
4899         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4900         Remove.
4901
4902 2019-06-25  Tom Tromey  <tom@tromey.com>
4903
4904         * tui/tui-data.h (struct tui_command_element): Remove.
4905         (union tui_which_element) <command>: Remove.
4906         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4907         assert.
4908         (free_content_elements): Remove CMD_WIN case.
4909
4910 2019-06-25  Tom Tromey  <tom@tromey.com>
4911
4912         * tui/tui-layout.c (tui_set_layout): Update.
4913         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4914         * tui/tui-data.c (layout_def): Update.
4915
4916 2019-06-25  Tom Tromey  <tom@tromey.com>
4917
4918         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4919         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4920         (tui_source_window_base::set_new_height): Update.
4921         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4922         Update.
4923         (tui_set_locator_fullname, tui_set_locator_info)
4924         (tui_show_frame_info): Update.
4925         * tui/tui-source.c (tui_set_source_content)
4926         (tui_source_is_displayed): Update.
4927         * tui/tui-layout.c (show_source_disasm_command, show_data)
4928         (show_source_or_disasm_and_command): Update.
4929         * tui/tui-disasm.c (tui_set_disassem_content)
4930         (tui_get_begin_asm_address): Update.
4931         * tui/tui-data.h (struct tui_locator_element): Remove.
4932         (union tui_which_element) <locator>: Remove.
4933         (struct tui_locator_window): New.
4934         (tui_locator_win_info_ptr): Change return type.
4935         * tui/tui-data.c (_locator): Change type.
4936         (tui_locator_win_info_ptr): Change return type.
4937         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4938         (tui_alloc_content): Add assert.
4939
4940 2019-06-25  Tom Tromey  <tom@tromey.com>
4941
4942         * tui/tui-winsource.c
4943         (tui_exec_info_window::maybe_allocate_content): New method.
4944         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4945         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4946         (make_source_or_disasm_window): Add cast.
4947         * tui/tui-data.h (union tui_which_element) <simple_string>:
4948         Remove.
4949         (struct tui_source_info): New.
4950         (struct tui_source_window_base) <execution_info>: Change type.
4951         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4952         case, and add assert.
4953         (tui_alloc_content): Add assert.
4954
4955 2019-06-25  Tom Tromey  <tom@tromey.com>
4956
4957         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4958         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4959         * tui/tui-data.c (tui_alloc_win_info): Remove.
4960
4961 2019-06-25  Tom Tromey  <tom@tromey.com>
4962
4963         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4964         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4965         can_highlight.
4966
4967 2019-06-25  Tom Tromey  <tom@tromey.com>
4968
4969         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4970         make_visible_with_new_height method.
4971         (tui_win_info::make_visible_with_new_height): New method.
4972         (tui_source_window_base::do_make_visible_with_new_height)
4973         (tui_data_window::do_make_visible_with_new_height)
4974         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4975         (make_visible_with_new_height): Remove.
4976         (tui_resize_all, tui_adjust_win_heights): Use
4977         make_visible_with_new_height method.
4978         * tui/tui-data.h (struct tui_win_info)
4979         <do_make_visible_with_new_height, make_visible_with_new_height>:
4980         New methods.
4981         (struct tui_source_window_base, struct tui_data_window)
4982         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4983         methods.
4984
4985 2019-06-25  Tom Tromey  <tom@tromey.com>
4986
4987         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4988         method.
4989         (update_tab_width): Call update_tab_width method.
4990         * tui/tui-data.h (struct tui_win_info)
4991         (struct tui_source_window_base) <update_tab_width>: New methods.
4992
4993 2019-06-25  Tom Tromey  <tom@tromey.com>
4994
4995         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4996         parameter.
4997         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4998         parameter.
4999         (tui_gen_win_info::make_visible): Update.
5000         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5001         parameter.
5002         * tui/tui-data.h (enum tui_box): New enum.
5003         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5004
5005 2019-06-25  Tom Tromey  <tom@tromey.com>
5006
5007         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5008         init_and_make_win for EXEC_INFO_WIN.
5009         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5010         longer inline.
5011         (struct tui_win_info) <~tui_win_info>: Inline.
5012         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5013         Don't declare.
5014         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5015         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5016         Remove.
5017         (tui_initialize_static_data): Update.
5018         (~tui_gen_win_info): Handle more cleanup here.
5019         (~tui_source_window_base): Delete "execution_info".
5020         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5021
5022 2019-06-25  Tom Tromey  <tom@tromey.com>
5023
5024         * tui/tui-layout.c (make_command_window): Don't set
5025         can_highlight.
5026         (show_source_disasm_command): Call the reset method.
5027         (show_data): Don't set can_highlight.  Call the reset method.
5028         (tui_gen_win_info::reset): Rename from init_gen_win_info
5029         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5030         (show_source_or_disasm_and_command): Call the reset method.
5031         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5032         (struct tui_cmd_window): Set can_highlight.
5033
5034 2019-06-25  Tom Tromey  <tom@tromey.com>
5035
5036         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5037         from make_visible.
5038         (tui_make_visible, tui_make_invisible): Rewrite.
5039         (tui_win_info::make_visible): Remove.
5040         (tui_source_window_base::make_visible): Update.
5041         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5042         method.  Moved from...
5043         (struct tui_win_info) <make_visible>: ...here.
5044
5045 2019-06-25  Tom Tromey  <tom@tromey.com>
5046
5047         * tui/tui-winsource.c
5048         (tui_source_window_base::do_scroll_horizontal): Remove direction
5049         parameter.
5050         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5051         direction parameter.
5052         * tui/tui-win.c (tui_win_info::forward_scroll)
5053         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5054         (tui_win_info::right_scroll): Update.
5055         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5056         direction parameter.
5057         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5058         direction parameter.
5059         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5060         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5061         Remove direction parameter.
5062         (struct tui_source_window_base, struct tui_source_window)
5063         (struct tui_disasm_window, struct tui_data_window)
5064         (struct tui_cmd_window): Update.
5065
5066 2019-06-25  Tom Tromey  <tom@tromey.com>
5067
5068         * tui/tui-winsource.h (tui_set_exec_info_content)
5069         (tui_show_exec_info_content, tui_erase_exec_info_content)
5070         (tui_clear_exec_info_content, tui_update_exec_info): Change
5071         argument to tui_source_window_base.
5072         * tui/tui-winsource.c (tui_set_exec_info_content)
5073         (tui_show_exec_info_content, tui_erase_exec_info_content)
5074         (tui_clear_exec_info_content, tui_update_exec_info): Change
5075         argument to tui_source_window_base.
5076
5077 2019-06-25  Tom Tromey  <tom@tromey.com>
5078
5079         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5080         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5081
5082 2019-06-25  Tom Tromey  <tom@tromey.com>
5083
5084         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5085         check.
5086
5087 2019-06-25  Tom Tromey  <tom@tromey.com>
5088
5089         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5090         type to void.
5091         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5092         type to void.
5093         * tui/tui-source.c (tui_set_source_content): Update.
5094         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5095
5096 2019-06-25  Tom Tromey  <tom@tromey.com>
5097
5098         * tui/tui-win.c (window_name_completer, tui_set_focus)
5099         (tui_all_windows_info): Use name method.
5100         * tui/tui-data.h (struct tui_gen_win_info)
5101         (struct tui_source_window, struct tui_disasm_window)
5102         (struct tui_data_window, struct tui_cmd_window) <name>: New
5103         method.
5104         (tui_win_name): Don't declare.
5105         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5106         (tui_win_name): Remove.
5107
5108 2019-06-25  Tom Tromey  <tom@tromey.com>
5109
5110         * tui/tui-winsource.h (tui_update_source_window)
5111         (tui_update_source_window_as_is): Change parameter type.
5112         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5113         to be a tui_source_window_base.
5114         (tui_update_source_window_as_is): Likewise.
5115         * tui/tui-win.c (make_visible_with_new_height): Update.
5116
5117 2019-06-25  Tom Tromey  <tom@tromey.com>
5118
5119         * tui/tui-winsource.c (tui_erase_source_content)
5120         (tui_show_source_content, tui_show_exec_info_content)
5121         (tui_erase_exec_info_content): Use refresh_window method.
5122         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5123         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5124         from tui_refresh_win.
5125         (tui_data_window::refresh_window): New method.
5126         (tui_win_info::refresh, tui_source_window_base::refresh)
5127         (tui_refresh_all): Use refresh_window method.
5128         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5129         method.
5130         * tui/tui-regs.c (tui_display_register): Call refresh_window
5131         method.
5132         * tui/tui-layout.c (show_source_disasm_command)
5133         (show_source_or_disasm_and_command): Call refresh_window method.
5134         * tui/tui-data.h (struct tui_gen_win_info)
5135         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5136         New method.
5137
5138 2019-06-25  Tom Tromey  <tom@tromey.com>
5139
5140         * tui/tui.c (tui_rl_other_window, tui_enable)
5141         (tui_is_window_visible, tui_get_command_dimension): Update.
5142         * tui/tui-winsource.c (tui_update_source_window_as_is)
5143         (tui_clear_source_content, tui_erase_source_content)
5144         (tui_show_source_line, tui_source_window_base::refill)
5145         (tui_source_window_base::do_scroll_horizontal)
5146         (tui_source_window_base::set_is_exec_point_at)
5147         (tui_update_breakpoint_info, tui_set_exec_info_content)
5148         (tui_alloc_source_buffer, tui_line_is_displayed)
5149         (tui_addr_is_displayed): Update.
5150         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5151         (tui_check_and_display_highlight_if_needed)
5152         (tui_win_info::make_visible, tui_win_info::refresh)
5153         (tui_refresh_all): Update.
5154         * tui/tui-windata.c (tui_first_data_item_displayed)
5155         (tui_delete_data_content_windows, tui_erase_data_content)
5156         (tui_display_all_data, tui_data_window::refresh_all)
5157         (tui_check_data_values): Update.
5158         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5159         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5160         (tui_win_info::backward_scroll, tui_refresh_all_win)
5161         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5162         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5163         (tui_source_window_base::set_new_height)
5164         (tui_data_window::set_new_height)
5165         (make_invisible_and_set_new_height)
5166         (make_visible_with_new_height, new_height_ok)
5167         (parse_scrolling_args): Update.
5168         * tui/tui-stack.c (tui_show_frame_info): Update.
5169         * tui/tui-source.c (tui_set_source_content)
5170         (tui_set_source_content_nil, tui_source_is_displayed)
5171         (tui_source_window::do_scroll_vertical): Update.
5172         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5173         (tui_display_registers_from, tui_display_reg_element_at_line)
5174         (tui_check_register_values, tui_reg_command): Update.
5175         * tui/tui-layout.c (tui_default_win_height)
5176         (show_source_disasm_command, show_data, init_and_make_win)
5177         (show_source_or_disasm_and_command): Update.
5178         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5179         (tui_redisplay_readline, tui_mld_flush)
5180         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5181         (tui_getc): Update.
5182         * tui/tui-disasm.c (tui_set_disassem_content)
5183         (tui_disasm_window::do_scroll_vertical): Update.
5184         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5185         Now virtual.
5186         (struct tui_win_info): Derive from tui_gen_win_info.
5187         <~tui_win_info>: Mark as override.
5188         <generic>: Remove member.
5189         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5190         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5191         (~tui_data_window, ~tui_win_info)
5192         (tui_free_all_source_wins_content): Update.
5193         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5194
5195 2019-06-25  Tom Tromey  <tom@tromey.com>
5196
5197         * tui/tui-layout.c (init_and_make_win): Use new.
5198         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5199         destructor, initializers.
5200         (tui_alloc_generic_win_info): Don't declare.
5201         * tui/tui-data.c (_locator): Add argument to constructor.
5202         (source_win, disasm_win): New globals.
5203         (exec_info): Remove.
5204         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5205         Update.
5206         (tui_alloc_generic_win_info): Remove.
5207         (init_content_element): Use new.
5208         (tui_win_info::tui_win_info): Update.
5209         (free_content_elements) <case DATA_WIN>: Use delete.
5210
5211 2019-06-25  Tom Tromey  <tom@tromey.com>
5212
5213         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5214         * tui/tui-windata.c (tui_first_data_item_displayed)
5215         (tui_delete_data_content_windows): Update.
5216         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5217         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5218         (tui_display_registers_from, tui_check_register_values): Update.
5219         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5220         pointer.
5221         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5222         window.
5223         (tui_free_data_content): Update.
5224         (free_content_elements) <case DATA_WIN>: Free the window.
5225
5226 2019-06-25  Tom Tromey  <tom@tromey.com>
5227
5228         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5229         Update.
5230         * tui/tui-layout.c (make_command_window)
5231         (show_source_disasm_command, show_data, init_and_make_win)
5232         (show_source_or_disasm_and_command): Update.
5233         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5234         method.
5235         <can_highight, is_highlighted>: Now bool.
5236         (tui_set_win_highlight): Don't declare.
5237         * tui/tui-data.c (tui_set_win_highlight): Remove.
5238
5239 2019-06-25  Tom Tromey  <tom@tromey.com>
5240
5241         * tui/tui-wingeneral.c (make_visible): Remove check of window
5242         type.
5243
5244 2019-06-25  Tom Tromey  <tom@tromey.com>
5245
5246         * tui/tui-win.c (tui_win_info::max_height)
5247         (tui_cmd_window::max_height): New methods.
5248         (new_height_ok): Call max_height.
5249         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5250         <max_height>: New method.
5251
5252 2019-06-25  Tom Tromey  <tom@tromey.com>
5253
5254         * tui/tui-win.c (tui_source_window_base::set_new_height)
5255         (tui_data_window::set_new_height): New methods.
5256         (make_invisible_and_set_new_height): Call set_new_height method.
5257         * tui/tui-data.h (struct tui_win_info)
5258         (struct tui_source_window_base, struct tui_data_window)
5259         <set_new_height>: New method.
5260
5261 2019-06-25  Tom Tromey  <tom@tromey.com>
5262
5263         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5264         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5265         tui_refresh_data_win.
5266         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5267         method.
5268         (tui_refresh_all_win): Call the refresh_all method.
5269         (tui_set_focus): Likewise.
5270         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5271         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5272         Likewise.
5273
5274 2019-06-25  Tom Tromey  <tom@tromey.com>
5275
5276         * tui/tui-winsource.h (tui_refill_source_window)
5277         (tui_set_is_exec_point_at): Don't declare.
5278         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5279         (tui_source_window_base::refill): Rename from
5280         tui_refill_source_window.
5281         (tui_source_window_base::do_scroll_horizontal): Update.
5282         (tui_source_window_base::set_is_exec_point_at): Rename from
5283         tui_set_is_exec_point_at.
5284         (tui_update_all_breakpoint_info): Update.
5285         * tui/tui-stack.c (tui_show_frame_info): Update.
5286         * tui/tui-layout.c (show_data): Add cast.
5287         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5288         * tui/tui-data.h (struct tui_source_window_base) <refill,
5289         set_is_exec_point_at>: New methods.
5290         (tui_source_windows, tui_add_to_source_windows): Update types.
5291         (tui_add_to_source_windows): Remove redundant declaration.
5292         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5293         (tui_source_windows): Change return type.
5294         (tui_clear_source_windows_detail): Update.
5295         (tui_add_to_source_windows): Change type of parameter.
5296         (tui_free_all_source_wins_content): Update.
5297
5298 2019-06-25  Tom Tromey  <tom@tromey.com>
5299
5300         * tui/tui-wingeneral.c (tui_win_info::refresh)
5301         (tui_source_window_base::refresh): New methods.
5302         (tui_refresh_all): Call the refresh method.
5303         * tui/tui-data.h (struct tui_win_info)
5304         (struct tui_source_window_base) <refresh>: New method.
5305
5306 2019-06-25  Tom Tromey  <tom@tromey.com>
5307
5308         * tui/tui.h (tui_is_window_visible): Return bool.
5309         * tui/tui.c (tui_is_window_visible): Return bool.
5310         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5311         (tui_make_visible, tui_make_invisible)
5312         (tui_win_info::make_visible)
5313         (tui_source_window_base::make_visible, make_all_visible)
5314         (tui_make_all_visible, tui_make_all_invisible): Update.
5315         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5316         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5317         bool.
5318         (struct tui_win_info, struct tui_source_window_base)
5319         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5320         * tui/tui-data.c (tui_init_generic_part): Update.
5321
5322 2019-06-25  Tom Tromey  <tom@tromey.com>
5323
5324         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5325         (tui_source_window_base::make_visible): New methods.
5326         (make_all_visible): Make method call.
5327         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5328         (struct tui_source_window_base, struct tui_cmd_window): Override
5329         make_visible.
5330         (tui_win_is_source_type): Don't declare.
5331         * tui/tui-data.c (tui_win_is_source_type): Remove.
5332
5333 2019-06-25  Tom Tromey  <tom@tromey.com>
5334
5335         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5336         NULL check.
5337
5338 2019-06-25  Tom Tromey  <tom@tromey.com>
5339
5340         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5341         Inline constructor.  Add initializers for members.
5342         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5343         constructors; now inline in class.
5344
5345 2019-06-25  Tom Tromey  <tom@tromey.com>
5346
5347         * tui/tui-regs.c (tui_show_registers): Update.
5348         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5349         bool.
5350         * tui/tui-data.c (tui_data_window::clear_detail)
5351         (tui_data_window): Update.
5352
5353 2019-06-25  Tom Tromey  <tom@tromey.com>
5354
5355         * tui/tui-windata.c (tui_display_all_data)
5356         (tui_display_data_from_line, tui_display_data_from)
5357         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5358         Update.
5359         * tui/tui-regs.c (tui_last_regs_line_no)
5360         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5361         (tui_show_registers, tui_show_register_group)
5362         (tui_display_registers_from, tui_display_reg_element_at_line)
5363         (tui_display_registers_from_line, tui_check_register_values)
5364         (tui_reg_next, tui_reg_prev): Update.
5365         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5366         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5367         tui_data_window.
5368         (struct tui_win_info) <detail>: Remove.  Add new fields from
5369         tui_data_info.
5370         (TUI_DATA_WIN): Add cast.
5371         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5372         (~tui_data_window): Simplify.
5373
5374 2019-06-25  Tom Tromey  <tom@tromey.com>
5375
5376         * tui/tui-layout.c (show_source_disasm_command)
5377         (show_source_or_disasm_and_command): Update.
5378         * tui/tui-io.c (update_cmdwin_start_line)
5379         (tui_redisplay_readline): Update.
5380         * tui/tui-data.h (struct tui_command_info): Remove.
5381         (struct tui_win_info) <detail>: Remove command_info member.
5382         (struct tui_data_window) <start_line>: New member, from
5383         tui_command_info.
5384         (TUI_CMD_WIN): Add casts.
5385
5386 2019-06-25  Tom Tromey  <tom@tromey.com>
5387
5388         * tui/tui-winsource.c (tui_update_source_window)
5389         (tui_refill_source_window)
5390         (tui_source_window_base::do_scroll_horizontal)
5391         (tui_update_breakpoint_info, tui_set_exec_info_content)
5392         (tui_show_exec_info_content, tui_erase_exec_info_content)
5393         (tui_clear_exec_info_content): Update.
5394         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5395         Update.
5396         * tui/tui-win.c (make_invisible_and_set_new_height)
5397         (make_visible_with_new_height): Update.
5398         * tui/tui-source.c (tui_set_source_content)
5399         (tui_show_symtab_source): Update.
5400         * tui/tui-layout.c (extract_display_start_addr)
5401         (show_source_disasm_command, show_data)
5402         (make_source_or_disasm_window)
5403         (show_source_or_disasm_and_command): Update.
5404         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5405         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5406         "gdbarch".
5407         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5408         to tui_source_window_base.
5409         (struct tui_win_info) <detail>: Remove source_info member.
5410         (struct tui_source_window_base) <has_locator>: Inline.
5411         Move contents from tui_source_info; rename has_locator member to
5412         m_has_locator.
5413         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5414         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5415         header file.
5416         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5417         Simplify.
5418         (tui_free_all_source_wins_content): Cast to
5419         tui_source_window_base.
5420
5421 2019-06-25  Tom Tromey  <tom@tromey.com>
5422
5423         * tui/tui-win.c (make_invisible_and_set_new_height)
5424         (make_visible_with_new_height): Call has_locator method.
5425         * tui/tui-layout.c (show_source_disasm_command, show_data)
5426         (show_source_or_disasm_and_command): Update for bool change.
5427         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5428         (tui_win_info) <has_locator>: New method.
5429         (struct tui_source_window_base) <has_locator>: New method.
5430         (tui_win_has_locator): Don't declare.
5431         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5432         from tui_win_has_locator.
5433         (tui_source_window_base): Use false, not FALSE.
5434
5435 2019-06-25  Tom Tromey  <tom@tromey.com>
5436
5437         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5438         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5439         clear_detail method directly.
5440         (tui_clear_win_detail): Remove.
5441
5442 2019-06-25  Tom Tromey  <tom@tromey.com>
5443
5444         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5445         "this", not TUI_DISASM_WIN.
5446
5447 2019-06-25  Tom Tromey  <tom@tromey.com>
5448
5449         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5450         declare.
5451         * tui/tui-winsource.c
5452         (tui_source_window_base::do_scroll_horizontal): Rename from
5453         tui_horizontal_source_scroll.
5454         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5455         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5456         from tui_vertical_data_scroll.
5457         * tui/tui-win.h (tui_scroll): Don't declare.
5458         * tui/tui-win.c (tui_win_info::forward_scroll)
5459         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5460         (tui_win_info::right_scroll): Rename and update.
5461         (tui_scroll_forward_command, tui_scroll_backward_command)
5462         (tui_scroll_left_command, tui_scroll_right_command): Update.
5463         (tui_scroll): Remove.
5464         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5465         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5466         from tui_vertical_source_scroll.
5467         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5468         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5469         from tui_vertical_disassem_scroll.
5470         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5471         do_scroll_horizontal>: New methods.
5472         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5473         Likewise.
5474         (struct tui_source_window_base): Add do_scroll_horizontal.
5475         (struct tui_source_window, struct tui_disasm_window): Add
5476         do_scroll_vertical.
5477         (struct tui_data_window, struct tui_cmd_window): Add
5478         do_scroll_horizontal and do_scroll_vertical.
5479         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5480
5481 2019-06-25  Tom Tromey  <tom@tromey.com>
5482
5483         * tui/tui-data.h (struct tui_source_window_base): New struct.
5484         (struct tui_source_window): Derive from tui_source_window_base.
5485         (struct tui_disasm_window): New struct.
5486         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5487         from tui_source_window::clear_detail.
5488         (tui_source_window_base): Rename from tui_source_window.
5489         (~tui_source_window_base): Rename from ~tui_source_window.
5490         (tui_alloc_win_info): Create a tui_disasm_window.
5491
5492 2019-06-25  Tom Tromey  <tom@tromey.com>
5493
5494         * tui/tui-data.h (struct tui_source_window)
5495         (struct tui_data_window): Declare destructors.
5496         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5497         destructors.
5498         (tui_win_info): Simplify.
5499
5500 2019-06-25  Tom Tromey  <tom@tromey.com>
5501
5502         * tui/tui-winsource.c (tui_display_main)
5503         (tui_update_source_windows_with_addr)
5504         (tui_update_all_breakpoint_info): Update.
5505         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5506         (new_height_ok, parse_scrolling_args): Update.
5507         * tui/tui-stack.c (tui_show_frame_info): Update.
5508         * tui/tui-data.h (struct tui_list): Remove.
5509         (tui_source_windows): Return a reference to a std::vector.
5510         * tui/tui-data.c (source_windows): Now a std::vector.
5511         (tui_source_windows): Change return type.
5512         (tui_clear_source_windows): Rewrite.
5513         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5514         (tui_free_all_source_wins_content): Rewrite.
5515
5516 2019-06-25  Tom Tromey  <tom@tromey.com>
5517
5518         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5519         (struct tui_data_window, struct tui_cmd_window): Declare
5520         clear_detail method.
5521         * tui/tui-data.c (tui_source_window::clear_detail)
5522         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5523         methods.
5524         (tui_clear_win_detail): Simplify.
5525
5526 2019-06-25  Tom Tromey  <tom@tromey.com>
5527
5528         * tui/tui-layout.c (make_source_window, make_disasm_window)
5529         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5530         Return the new window.
5531         (show_source_disasm_command, show_data)
5532         (show_source_or_disasm_and_command): Update.
5533
5534 2019-06-25  Tom Tromey  <tom@tromey.com>
5535
5536         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5537         parameter.  Return the new window.
5538         (show_source_disasm_command): Update and remove NULL check.
5539         (show_source_or_disasm_and_command): Update.
5540
5541 2019-06-25  Tom Tromey  <tom@tromey.com>
5542
5543         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5544
5545 2019-06-25  Tom Tromey  <tom@tromey.com>
5546
5547         * tui/tui-data.h (struct tui_win_info): Make constructor
5548         protected.  Make destructor virtual.  Add initializers.
5549         (tui_source_window, tui_data_window, tui_cmd_window): New
5550         classes.
5551         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5552         constructor.  Add "type" parameter.
5553         (tui_source_window, tui_data_window, tui_cmd_window): New
5554         constructors.
5555         (tui_alloc_win_info): Instantiate the appropriate subclass.
5556
5557 2019-06-25  Tom Tromey  <tom@tromey.com>
5558
5559         * tui/tui-win.c (tui_resize_all): Use delete.
5560         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5561         destructor.
5562         (tui_free_window): Don't declare.
5563         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5564         Update.
5565
5566 2019-06-25  Tom Tromey  <tom@tromey.com>
5567
5568         * tui/tui-data.h (struct tui_win_info): Add constructor.
5569         * tui/tui-data.c (tui_alloc_win_info): Use new.
5570         (tui_free_window): Use delete.
5571
5572 2019-06-22  Tom Tromey  <tom@tromey.com>
5573
5574         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5575         declare.
5576         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5577
5578 2019-06-22  Tom Tromey  <tom@tromey.com>
5579
5580         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5581         declare.
5582         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5583
5584 2019-06-22  Tom de Vries  <tdevries@suse.de>
5585
5586         * dwarf2read.c (create_addrmap_from_aranges)
5587         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5588         instead of '%zu'.
5589
5590 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5591
5592         * dwarf2read.h (dwarf2_section_info_def): Remove.
5593         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5594         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5595         std::vector<dwarf2_section_info>.
5596         (struct dwo_file) <~dwo_file>: Remove.
5597         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5598         types field.
5599         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5600         (dwarf2_read_debug_names): Likewise.
5601         (create_debug_types_hash_table): Change parameter type to
5602         array_view, adjust code accordingly.
5603         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5604         (partial_die_info::fixup): Likewise.
5605         (determine_prefix): Likewise.
5606         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5607
5608 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5609
5610         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5611         gdb_bfd_ref_ptr.
5612         <~dwo_file>: Remove call to gdb_bfd_unref.
5613         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5614         gdb_bfd_ref_ptr::get.
5615
5616 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5617
5618         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5619         type to htab_up.
5620         * dwarf2read.c (struct dwo_file): Initialize fields.
5621         <~dwo_file>: New.
5622         (free_dwo_file): Remove, move content to ~dwo_file.
5623         (struct dwo_file_deleter): Remove.
5624         (dwo_file_up>: Remove custom deleter.
5625         (free_dwo_files): Remove.
5626         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5627         dwo_files.
5628         (process_skeletonless_type_units): Call unique_ptr::get.
5629         (allocate_dwo_file_hash_table): Add deleter to created hash
5630         table.  Change return type to htab_up.
5631         (lookup_dwo_file_slot): Don't memset dwo_file, call
5632         unique_ptr::get.
5633         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5634         (create_dwo_unit_in_dwp_v2): Likewise.
5635         (open_and_init_dwo_file): Likewise.
5636         (free_dwo_file_from_slot): Remove.
5637
5638 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5639
5640         * dwarf2read.h (struct dwarf2_section_info) <readin,
5641         is_virtual>: Change type to bool.
5642         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5643         true instead of 1.
5644
5645 2019-06-19  Tom Tromey  <tom@tromey.com>
5646
5647         * tui/tui-data.h (tui_init_content_element): Don't declare.
5648
5649 2019-06-19  Tom Tromey  <tom@tromey.com>
5650
5651         * tui/tui-data.h (tui_init_win_info): Don't declare.
5652
5653 2019-06-19  Tom de Vries  <tdevries@suse.de>
5654
5655         * dwarf2read.h (abstract_to_concrete): Change type to
5656         std::unordered_map<sect_offset, std::vector<sect_offset>,
5657         gdb::hash_enum<sect_offset>>.
5658
5659 2019-06-19  Tom Tromey  <tromey@adacore.com>
5660
5661         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5662         EVAL_AVOID_SIDE_EFFECTS specially.
5663
5664 2019-06-19  Tom Tromey  <tromey@adacore.com>
5665
5666         * source-cache.c (highlighter): New global.
5667         (source_cache::get_source_lines): Create a highlighter on demand.
5668
5669 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5670
5671         * defs.h (deprecated_interactive_hook): Delete declaration.
5672         * interps.c (clear_interpreter_hooks): Remove use of
5673         deprecated_interactive_hook.
5674         * top.c (deprecated_interactive_hook): Delete definition.
5675         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5676
5677 2019-06-18  Tom de Vries  <tdevries@suse.de>
5678
5679         PR gdb/24515
5680         * dwarf2read.h (abstract_to_concrete): Change type from
5681         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5682         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5683         * dwarf2read.c (read_variable): Update.
5684         (dwarf2_fetch_die_loc_sect_off): Update.
5685
5686 2019-06-17  Tom de Vries  <tdevries@suse.de>
5687
5688         PR gdb/24617
5689         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5690         accessing parent[parent_len - 1].
5691
5692 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5693
5694         PR gdb/24364
5695         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5696         call dtrace_process_dof with NULL dof.
5697
5698 2019-06-16  Tom de Vries  <tdevries@suse.de>
5699
5700         PR gdb/24445
5701         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5702
5703 2019-06-16  Tom Tromey  <tom@tromey.com>
5704
5705         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5706         (make_all_visible): Use address of member.
5707
5708 2019-06-16  Tom Tromey  <tom@tromey.com>
5709
5710         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5711         (tui_free_window, free_content, free_content_elements): Remove
5712         unnecessary cast.
5713         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5714         cast.
5715         * tui/tui-regs.c (tui_show_register_group)
5716         (tui_display_registers_from, tui_display_reg_element_at_line):
5717         Remove unnecessary cast.
5718
5719 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5720
5721         * linux-nat.c (normal_mask): Delete.
5722         (_initialize_linux_nat): Don't initialise normal_mask.
5723
5724 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5725
5726         PR gdb/24445
5727         * dwarf-index-write.h (write_psymtabs_to_index): Add
5728         dwz_basename parameter.
5729         * dwarf-index-write.c (write_gdbindex): Move file writing to
5730         write_gdbindex_1.  Change return type void.
5731         (assert_file_size): Move up, remove filename parameter.
5732         (write_gdbindex_1): New function.
5733         (write_debug_names): Change return type to void, call
5734         assert_file_size.
5735         (struct index_wip_file): New struct.
5736         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5737         file logic to index_wip_file.  Write index for dwz file if
5738         needed.
5739         (save_gdb_index_command): Pass basename of dwz file, if present.
5740         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5741         build-id of dwz file, if present.
5742         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5743         (dwarf2_get_dwz_file): Likewise.
5744         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5745         (dwarf2_get_dwz_file): Likewise.
5746
5747 2019-06-16  Tom Tromey  <tom@tromey.com>
5748
5749         * coffread.c (process_coff_symbol): Use xstrdup.
5750         * value.c (create_internalvar): Use xstrdup.
5751
5752 2019-06-16  Tom Tromey  <tom@tromey.com>
5753
5754         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5755         * breakpoint.c (stopin_command, stopat_command)
5756         (until_break_command, decode_location_default): Remove unnecessary
5757         cast.
5758         * utils.c (subset_compare): Remove unnecessary cast.
5759         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5760         cast.
5761         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5762         cast.
5763         * infcmd.c (path_command): Remove unnecessary cast.
5764         * coffread.c (decode_type): Remove unnecessary cast.
5765         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5766         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5767         * tui/tui-stack.c (tui_show_locator_content)
5768         (tui_show_frame_info): Remove unnecessary cast.
5769         * tui/tui-win.c (tui_scroll_forward_command)
5770         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5771         (parse_scrolling_args): Remove unnecessary cast.
5772         * tui/tui-data.c (init_win_info, tui_del_window)
5773         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5774         (free_content_elements): Remove unnecessary cast.
5775         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5776         unnecessary cast.
5777         * tui/tui-source.c (tui_set_source_content)
5778         (tui_vertical_source_scroll): Remove unnecessary cast.
5779         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5780         cast.
5781         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5782         * tui/tui-regs.c (tui_display_registers_from)
5783         (tui_display_register): Remove unnecessary cast.
5784         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5785         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5786         (make_visible): Remove unnecessary cast.
5787         * tui/tui-winsource.c (tui_erase_source_content)
5788         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5789         unnecessary cast.
5790         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5791         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5792         * stabsread.c (read_type, read_array_type, read_range_type):
5793         Remove unnecessary cast.
5794         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5795         (parse_symbol, parse_type, upgrade_type, parse_external)
5796         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5797         unnecessary cast.
5798         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5799
5800 2019-06-16  Tom Tromey  <tom@tromey.com>
5801
5802         * tui/tui-data.c (tui_alloc_generic_win_info)
5803         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5804         checks.
5805
5806 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5807             Andrew Burgess  <andrew.burgess@embecosm.com>
5808
5809         * f-typeprint.c (f_print_type): Don't return early for not
5810         associated or not allocated types.
5811         (f_type_print_varspec_suffix): Add print_rank parameter and print
5812         ranks of array types in case they dangling.
5813         (f_type_print_base): Add print_rank parameter.
5814
5815 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5816
5817         * NEWS: Mention new MI commands.
5818         * break-catch-throw.c (enum exception_event_kind): Move to
5819         breakpoint.h.
5820         (print_mention_exception_catchpoint): Output text as a single
5821         message.
5822         (catch_exception_command_1): Rename to...
5823         (catch_exception_event): ...this, make non-static, update header
5824         command, and change some parameter types.
5825         (catch_catch_command): Update for changes to
5826         catch_exception_command_1.
5827         (catch_throw_command): Likewise.
5828         (catch_rethrow_command): Likewise.
5829         * breakpoint.c (enum exception_event_kind): Delete.
5830         * breakpoint.h (enum exception_event_kind): Moved here from
5831         break-catch-throw.c.
5832         (catch_exception_event): Declare.
5833         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5834         (mi_cmd_catch_throw): New function.
5835         (mi_cmd_catch_rethrow): New function.
5836         (mi_cmd_catch_catch): New function.
5837         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5838         'catch-catch' entries.
5839         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5840         (mi_cmd_catch_rethrow): Declare.
5841         (mi_cmd_catch_catch): Declare.
5842
5843 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5844
5845         * annotate.c (annotate_source_line): Change return type to void,
5846         update implementation to match.
5847         * annotate.h (annotate_source_line): Change return type to void,
5848         update header comment.
5849         * stack.c (print_frame_info): Don't change what frame information
5850         is printed based on whether annotations are on or not.
5851
5852 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5853
5854         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5855         (annotate_source): Make static.
5856         (annotate_source_line): Moved from source.c and renamed from
5857         identify_source_line.  Update the return type.
5858         * annotate.h (annotate_source): Delete declaration.
5859         (annotate_source_line): Declaration moved from source.h, and
5860         renamed from identify_source_line.  Return type updated.
5861         * source.c (identify_source_line): Moved to annotate.c and renamed
5862         to annotate_source_line.
5863         (info_line_command): Remove check of annotation_level.
5864         * source.h (identify_source_line): Move declaration to annotate.h
5865         and rename to annotate_source_line.
5866         * stack.c: Add 'annotate.h' include.
5867         (print_frame_info): Remove check of annotation_level before
5868         calling annotate_source_line.
5869
5870 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5871
5872         * source-cache.c (source_cache::get_plain_source_lines): Use
5873         open_source_file_with_line_charpos instead of just
5874         open_source_file, remove call to find_source_lines.
5875         (source_cache::get_source_lines): Likewise.
5876         * source.c (find_source_lines): Make static.
5877         (get_filename_and_charpos): Renamed into...
5878         (open_source_file_with_line_charpos): ..this along with changes to
5879         return a scoped_fd, and some other minor clean ups.
5880         (identify_source_line): Use open_source_file_with_line_charpos.
5881         (search_command_helper): Use open_source_file_with_line_charpos
5882         instead of just open_source_file, remove call to
5883         find_source_lines.
5884         * source.h (open_source_file_with_line_charpos): Declare new
5885         function.
5886         (find_source_lines): Delete declaration.
5887
5888 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5889
5890         * source.c (get_filename_and_charpos): Remove fullname
5891         parameter.
5892         (identify_source_line): Update call to get_filename_and_charpos.
5893
5894 2019-06-14  Tom Tromey  <tromey@adacore.com>
5895
5896         PR gdb/24502:
5897         * ui-style.h (skip_ansi_escape): Update comment.
5898         * ui-file.h (class no_terminal_escape_file): New class.
5899         * ui-file.c (no_terminal_escape_file::write)
5900         (no_terminal_escape_file::puts): New methods.
5901         * cli/cli-logging.c (handle_redirections): Use
5902         no_terminal_escape_file.
5903
5904 2019-06-14  Tom Tromey  <tromey@adacore.com>
5905
5906         * NEWS: Move convenience variable news above Python news.
5907
5908 2019-06-14  Tom Tromey  <tom@tromey.com>
5909
5910         * gnulib: Move directory to top-level.
5911         * configure.ac: Don't configure gnulib.
5912         * configure: Rebuild.
5913         * common/common-defs.h: Use new path to gnulib.
5914         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5915         (GNULIB_H): Remove.
5916         (INCGNU): Look in new gnulib location.
5917         (HFILES_NO_SRCDIR): Remove gnulib files.
5918         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5919         (generated_files): Remove GNULIB_H.
5920         ($(LIBGNU), all-lib): Remove targets.
5921         (distclean): Don't mention GNULIB_BUILDDIR.
5922         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5923
5924 2019-06-14  Tom Tromey  <tromey@adacore.com>
5925
5926         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5927         Warn if symbol file does not provide any symbols.
5928
5929 2019-06-14  Tom Tromey  <tromey@adacore.com>
5930
5931         * source.c (find_and_open_source): Respect basenames_may_differ.
5932
5933 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5934
5935         * annotate.c (annotate_breakpoints_invalid): Make use of
5936         scoped_restore_terminal_state.
5937         (annotate_frames_invalid): Likewise.
5938
5939 2019-06-14  Tom Tromey  <tromey@adacore.com>
5940
5941         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5942         allow assignment to an internalvar.
5943
5944 2019-06-14  Tom Tromey  <tromey@adacore.com>
5945
5946         * ada-lex.l: Allow "_" in attribute names.
5947
5948 2019-06-14  Tom Tromey  <tromey@adacore.com>
5949
5950         PR gdb/24653:
5951         * regcache.c (registers_changed): Don't call alloca.
5952         * top.c (execute_command): Don't call alloca.
5953
5954 2019-06-13  Pedro Alves  <palves@redhat.com>
5955
5956         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5957         'expression'.  When parsing an expression, error out if there's
5958         junk after "unlimited".
5959         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5960         (do_set_command): Adjust calls to is_unlimited_literal.
5961
5962 2019-06-13  Pedro Alves  <palves@redhat.com>
5963
5964         * compile/compile.c (make_compile_options_def_group): Add braces
5965         around array_view initializer.
5966         * thread.c (make_thread_apply_all_options_def_group)
5967         (make_thread_apply_all_options_def_group): Likewise.
5968
5969 2019-06-13  Pedro Alves  <palves@redhat.com>
5970
5971         * NEWS (New commands): Mention "maint test-options
5972         require-delimiter", "maint test-options unknown-is-error", "maint
5973         test-options unknown-is-operand" and "maint show
5974         test-options-completion-result".
5975         (New command options, command completion): New section.
5976         (Completion improvements): New section.
5977         Mention that you can abbreviate "unlimited".
5978
5979 2019-06-13  Pedro Alves  <palves@redhat.com>
5980
5981         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5982         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5983         * unittests/cli-utils-selftests.c (test_parse_flags)
5984         (test_parse_flags_qcs): Delete.
5985         (test_cli_utils): Don't call deleted functions.
5986
5987 2019-06-13  Pedro Alves  <palves@redhat.com>
5988
5989         * thread.c: Include "cli/cli-option.h".
5990         (tp_array_compar_ascending): Global.
5991         (tp_array_compar): Delete function.
5992         (tp_array_compar_ascending, tp_array_compar_descending): New
5993         functions.
5994         (ascending_option_def, qcs_flag_option_def)
5995         (thr_qcs_flags_option_defs)
5996         (make_thread_apply_all_options_def_group)
5997         (make_thread_apply_options_def_group): New.
5998         (thread_apply_all_command): Use gdb::option::process_options.
5999         (thread_apply_command_completer)
6000         (thread_apply_all_command_completer): New.
6001         (thread_apply_command): Use gdb::option::process_options.
6002         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6003         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6004         to generate help text of "thread apply".  Adjust "taas"'s help.
6005         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6006         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6007
6008 2019-06-13  Pedro Alves  <palves@redhat.com>
6009
6010         * thread.c (thread_apply_command): Check for invalid TID with
6011         isdigit instead of !isalpha.
6012
6013 2019-06-13  Pedro Alves  <palves@redhat.com>
6014
6015         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6016         (validate_flags_qcs): New.
6017         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6018         (validate_flags_qcs): Declare.
6019         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6020         (make_frame_apply_options_def_group): New.
6021         (frame_apply_command_count): Process options with
6022         gdb::option::process_options.
6023         (frame_apply_completer): New.
6024         (frame_apply_level_completer, frame_apply_all_completer)
6025         (frame_apply_completer): New.
6026         (_initialize_stack): Update help of "frame apply", "frame apply
6027         level", "frame apply all" and "faas" to mention supported options
6028         and install command completers.
6029         * stack.h (frame_apply_all_completer): Declare.
6030         * thread.c: Include "stack.h".
6031         (tfaas_command): Add "--".
6032         (_initialize_thread): Update help "tfaas" to mention supported
6033         options and install command completer.
6034
6035 2019-06-13  Pedro Alves  <palves@redhat.com>
6036
6037         * completer.c (complete_nested_command_line): New.
6038         (gdb_completion_word_break_characters_throw): Add assertion.
6039         * completer.h (complete_nested_command_line): Declare.
6040
6041 2019-06-13  Pedro Alves  <palves@redhat.com>
6042
6043         * stack.c (parse_backtrace_qualifiers): New.
6044         (backtrace_command): Use it.
6045         (backtrace_command_completer): Complete on qualifiers.
6046
6047 2019-06-13  Pedro Alves  <palves@redhat.com>
6048
6049         * frame.c: Include "cli/cli-option.h.
6050         (user_set_backtrace_options): New.
6051         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6052         Delete.
6053         (get_prev_frame): Adjust.
6054         (boolean_option_def, uinteger_option_def)
6055         (set_backtrace_option_defs): New.
6056         (_initialize_frame): Adjust and use
6057         gdb::option::add_setshow_cmds_for_options to install "set
6058         backtrace past-main" and "set backtrace past-entry".
6059         * frame.h: Include "cli/cli-option.h".
6060         (struct frame_print_options): Forward declare.
6061         (print_frame_arguments_all, print_frame_arguments_scalars)
6062         (print_frame_arguments_none): Declare.
6063         (print_entry_values): Delete declaration.
6064         (struct frame_print_options, user_frame_print_options): New.
6065         (struct set_backtrace_options): New.
6066         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6067         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6068         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6069         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6070         (list_args_or_locals): Add frame_print_options parameter.
6071         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6072         * python/py-framefilter.c (enumerate_args): Pass down
6073         USER_FRAME_PRINT_OPTIONS.
6074         * stack.c: Include "cli/cli-option.h".
6075         (print_frame_arguments_all, print_frame_arguments_scalars)
6076         (print_frame_arguments_none): Declare.
6077         (print_raw_frame_arguments, print_entry_values): Delete.
6078         (user_frame_print_options): New.
6079         (boolean_option_def, enum_option_def, frame_print_option_defs):
6080         New.
6081         (struct backtrace_cmd_options): New.
6082         (bt_flag_option_def): New.
6083         (backtrace_command_option_defs): New.
6084         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6085         (print_frame_arg, read_frame_arg, print_frame_args)
6086         (print_frame_info, print_frame): Add frame_print_options parameter
6087         and use it.
6088         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6089         (backtrace_command_1): Add frame_print_options and
6090         backtrace_cmd_options parameters and use them.
6091         (make_backtrace_options_def_group): New.
6092         (backtrace_command): Process command options with
6093         gdb::option::process_options.
6094         (backtrace_command_completer): New.
6095         (_initialize_stack): Extend "backtrace"'s help to mention
6096         supported options.  Install completer for "backtrace".
6097         Install some settings commands with add_setshow_cmds_for_options.
6098
6099 2019-06-13  Pedro Alves  <palves@redhat.com>
6100
6101         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6102         and that "set/show print raw frame-arguments" are now deprecated.
6103
6104         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6105         command.
6106         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6107         * stack.c (_initialize_stack): Install "set/show print
6108         raw-frame-arguments", and deprecate "set/show print raw
6109         frame-arguments".
6110         * valprint.c (_initialize_valprint): Deprecate "set/show print
6111         raw".
6112
6113 2019-06-13  Pedro Alves  <palves@redhat.com>
6114
6115         * compile/compile.c (struct compile_options): New.
6116         (compile_flag_option_def, compile_command_option_defs)
6117         (make_compile_options_def_group): New.
6118         (compile_file_command): Handle options with
6119         gdb::option::process_options.
6120         (compile_file_command_completer): New function.
6121         (compile_code_command): Handle options with
6122         gdb::option::process_options.
6123         (compile_code_command_completer): New function.
6124         (_initialize_compiler): Install completers for "compile code" and
6125         "compile file".  Mention available options in "compile code" and
6126         "compile code"'s help.
6127         * completer.c (advance_to_completion_word): New, factored out from
6128         ...
6129         (advance_to_expression_complete_word_point): ... this.
6130         (advance_to_filename_complete_word_point): New.
6131         * completer.h (advance_to_filename_complete_word_point): New
6132         declaration.
6133
6134 2019-06-13  Pedro Alves  <palves@redhat.com>
6135
6136         * compile/compile.c: Include "cli/cli-option.h".
6137         (compile_print_value): Scope data pointer is now a
6138         value_print_options pointer; adjust.
6139         (compile_print_command): Process options.  Scope data pointer is
6140         now a value_print_options pointer; adjust.
6141         (_initialize_compile): Update "compile print"'s help to include
6142         supported options.  Install a completer for "compile print".
6143         * cp-valprint.c (show_vtblprint, show_objectprint)
6144         (show_static_field_print): Delete.
6145         (_initialize_cp_valprint): Don't install "set print
6146         static-members", "set print vtbl", "set print object" here.
6147         * printcmd.c: Include "cli/cli-option.h" and
6148         "common/gdb_optional.h".
6149         (print_command_parse_format): Rework to fill in a
6150         value_print_options instead of a format_data.
6151         (print_value): Change parameter type from format_data pointer to
6152         value_print_options reference.  Adjust.
6153         (print_command_1): Process options.  Adjust to pass down a
6154         value_print_options.
6155         (print_command_completer): New.
6156         (_initialize_printcmd): Install print_command_completer as
6157         handle_brkchars completer for the "print" command.  Update
6158         "print"'s help to include supported options.
6159         * valprint.c: Include "cli/cli-option.h".
6160         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6161         here from cp-valprint.c.
6162         (boolean_option_def, uinteger_option_def)
6163         (value_print_option_defs, make_value_print_options_def_group):
6164         New.  Use gdb::option::add_setshow_cmds_for_options to install
6165         "set print elements", "set print null-stop", "set print repeats",
6166         "set print pretty", "set print union", "set print array", "set
6167         print address", "set print symbol", "set print array-indexes".
6168         * valprint.h: Include <string> and "cli/cli-option.h".
6169         (make_value_print_options_def_group): Declare.
6170         (print_value): Change parameter type from format_data pointer to
6171         value_print_options reference.
6172         (print_command_completer): Declare.
6173
6174 2019-06-13  Pedro Alves  <palves@redhat.com>
6175
6176         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6177         (COMMON_SFILES): Add maint-test-settings.c.
6178         * cli/cli-decode.c (boolean_enums): New global, factored out from
6179         ...
6180         (add_setshow_boolean_cmd): ... here.
6181         * cli/cli-decode.h (boolean_enums): Declare.
6182         * cli/cli-option.c: New file.
6183         * cli/cli-option.h: New file.
6184         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6185         factored out from ...
6186         (parse_cli_boolean_value(const char *)): ... this.
6187         (is_unlimited_literal): Change parameter type to pointer to
6188         pointer.  Adjust and advance ARG pointer.
6189         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6190         (parse_cli_var_enum): New, factored out from ...
6191         (do_set_command): ... this.  Adjust.
6192         * cli/cli-setshow.h (parse_cli_boolean_value)
6193         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6194         (parse_cli_var_enum): Declare.
6195         * cli/cli-utils.c: Include "cli/cli-option.h".
6196         (get_ulongest): New.
6197         * cli/cli-utils.h (get_ulongest): Declare.
6198         (check_for_argument): New overloads.
6199         * maint-test-options.c: New file.
6200
6201 2019-06-13  Pedro Alves  <palves@redhat.com>
6202
6203         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6204         parse a range if "-" is at the end of the string.
6205
6206 2019-06-13  Pedro Alves  <palves@redhat.com>
6207
6208         * cli/cli-setshow.c (parse_auto_binary_operation)
6209         (parse_cli_boolean_value): Don't allow "o".
6210
6211 2019-06-13  Pedro Alves  <palves@redhat.com>
6212
6213         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6214         * NEWS: Mention maint test-settings KIND.
6215         * maint-test-settings.c: New file.
6216
6217 2019-06-13  Pedro Alves  <palves@redhat.com>
6218
6219         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6220         completer.
6221         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6222         "set" completers.
6223
6224 2019-06-13  Pedro Alves  <palves@redhat.com>
6225
6226         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6227         after item.
6228
6229 2019-06-13  Pedro Alves  <palves@redhat.com>
6230
6231         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6232
6233 2019-06-13  Pedro Alves <palves@redhat.com>
6234
6235         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6236         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6237         call.
6238         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6239         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6240         calls.
6241         (check_for_argument): Skip spaces after argument.
6242
6243 2019-06-13  Pedro Alves  <palves@redhat.com>
6244
6245         * thread.c (thread_apply_command): Adjust TID parsing.
6246         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6247         detected before end of string.
6248         (tid_is_in_list): Error out if LIST is invalid.
6249
6250 2019-06-13  Pedro Alves  <palves@redhat.com>
6251
6252         * completer.c (complete_line_internal_1): Rewind completion word
6253         point.
6254         (completion_tracker::advance_custom_word_point_by): Change
6255         parameter type to int.
6256         * completer.h (completion_tracker::advance_custom_word_point_by):
6257         Likewise.
6258
6259 2019-06-13  Pedro Alves  <palves@redhat.com>
6260
6261         * completer.c (advance_to_completion_word): Handle delimiters.
6262
6263 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6264
6265         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6266
6267 2019-06-11  Tom Tromey  <tom@tromey.com>
6268
6269         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6270         (xmalloc_failed): Move to alloc.c.
6271         * alloc.c: New file.
6272         * Makefile.in (COMMON_SFILES): Add alloc.c.
6273
6274 2019-06-11  Tom Tromey  <tom@tromey.com>
6275
6276         * nat/linux-waitpid.c: Don't include server.h.
6277         (linux_debug): Remove.
6278         (my_waitpid): Update.
6279
6280 2019-06-11  Tom Tromey  <tromey@adacore.com>
6281
6282         * infcall.c (_initialize_infcall): Remove trailing newline from
6283         help.
6284         * user-regs.c (_initialize_user_regs): Remove trailing newline
6285         from help.
6286         * typeprint.c (_initialize_typeprint): Remove trailing newline
6287         from help.
6288         * reverse.c (_initialize_reverse): Remove trailing newlines from
6289         help.
6290         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6291         from help.
6292         * language.c (add_set_language_command): Remove trailing newline
6293         from help.
6294         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6295         help.
6296         * disasm.c (_initialize_disasm): Remove trailing newline from
6297         help.
6298         * top.c (init_main): Remove trailing newline from help.
6299         * interps.c (_initialize_interpreter): Remove trailing newline
6300         from help.
6301         * btrace.c (_initialize_btrace): Remove trailing newlines from
6302         help.
6303         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6304         from help.
6305         * python/python.c (_initialize_python): Remove trailing newline
6306         from help.
6307         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6308         help.
6309         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6310         from help.  Reformat some text.
6311         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6312         from help.
6313         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6314         newline from help.
6315
6316 2019-06-11  Tom Tromey  <tromey@adacore.com>
6317
6318         * darwin-nat.c (darwin_decode_exception_message)
6319         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6320
6321 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6322
6323         * valops.c (value_slice): Check for not allocated or not
6324         associated values.
6325
6326 2019-06-10  Tom de Vries  <tdevries@suse.de>
6327
6328         PR gdb/24618
6329         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6330         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6331         invalid.
6332
6333 2019-06-10  Tom de Vries  <tdevries@suse.de>
6334
6335         PR gdb/24611
6336         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6337         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6338
6339 2019-06-10  Tom de Vries  <tdevries@suse.de>
6340
6341         PR symtab/24545
6342         * symtab.c (struct demangled_name_entry): Add language field.
6343         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6344         static minimal symbol".  Set and use language field.
6345
6346 2019-06-10  Tom Tromey  <tromey@adacore.com>
6347
6348         * ada-lang.c (_initialize_ada_language): Update help text.
6349
6350 2019-06-10  Tom Tromey  <tromey@adacore.com>
6351
6352         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6353         with a newline.
6354         * guile/guile.c (handle_boot_error): Don't end warning with a
6355         newline.
6356         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6357         warning with a newline.
6358         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6359         newline.
6360         (s12z_frame_cache): Likewise.
6361         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6362         a newline.
6363         * solib-svr4.c (disable_probes_interface): Don't end warning with
6364         a newline.
6365         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6366         newline.
6367         * python/python.c (do_finish_initialization): Don't end warning
6368         with a newline.
6369
6370 2019-06-10  Tom Tromey  <tom@tromey.com>
6371
6372         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6373         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6374         gdbpy_enter.
6375
6376 2019-06-10  Tom Tromey  <tromey@adacore.com>
6377
6378         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6379         data.
6380         (elf_new_init): Don't call stabsread_new_init.
6381         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6382         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6383         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6384
6385 2019-06-10  Tom de Vries  <tdevries@suse.de>
6386
6387         PR symtab/16264
6388         PR symtab/24517
6389         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6390
6391 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6392
6393         * source.c (find_and_open_source): Also rewrite relative file
6394         names.
6395
6396 2019-04-26  Amos Bird  <amosbird@gmail.com>
6397
6398         * annotate.c (annotate_thread_exited): Add "thread-exited"
6399         annotation.
6400
6401 2019-06-06  Tom Tromey  <tromey@adacore.com>
6402
6403         * maint.h (class scoped_command_stats): Use
6404         DISABLE_COPY_AND_ASSIGN.
6405         <print_time>: New method.
6406         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6407         print_time.
6408         (scoped_command_stats::print_time): New method.
6409
6410 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6411
6412         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6413         instructions of lengths 6 or 8 bytes.
6414
6415 2019-06-04  Pedro Alves  <palves@redhat.com>
6416
6417         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6418
6419         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6420         * breakpoint.c (condition_completer): Likewise.
6421         * cli/cli-dump.c (scan_expression): Likewise.
6422         * common/filestuff.c (mkdir_recursive): Likewise.
6423         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6424         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6425         (gdb_abspath): Likewise.
6426         * compile/compile-cplus-types.c
6427         (compile_cplus_instance::decl_name): Likewise.
6428         * completer.c (complete_explicit_location):
6429         (signal_completer, reg_or_group_completer_1): Likewise.
6430         * cp-support.c (cp_remove_params_if_any): Likewise.
6431         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6432         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6433         * infcmd.c (strip_bg_char): Likewise.
6434         * linespec.c (copy_token_string): Likewise.
6435         * mi/mi-main.c (output_cores): Likewise.
6436         * psymtab.c (psymtab_search_name):
6437         * symfile.c (test_set_ext_lang_command): Likewise.
6438         * target.c (target_fileio_read_stralloc): Likewise.
6439         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6440         * value.c (complete_internalvar): Likewise.
6441
6442 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6443
6444         Add objfile property to gdb.Type.
6445         * NEWS: Mention Python API addition.
6446         * python/py-type.c (typy_get_objfile): New method.
6447
6448 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6449
6450         * NEWS: Mention the new set|show style [title|highlight].
6451         Mention changes to "show style", "help" and "apropos".
6452
6453 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6454
6455         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6456         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6457         instead of print_help_for_command.
6458         (print_doc_of_command): New function.
6459         (help_list): Add 'apropos -v word' suggestion.
6460         (print_help_for_command): Style the command name using title style.
6461         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6462         (_initialize_cli_cmds): Describe -v in apropos_command help.
6463
6464 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6465
6466         * cli/cli-style.h (cli_style_option): Add name in constructor,
6467         add m_name class member, add constructor with intensity,
6468         add name class function.
6469         (cli_style_option::add_setshow_commands): Remove name argument.
6470         (highlight_style, title_style): New styles.
6471         * cli/cli-style.c (do_show): New function that shows a style
6472         characteristic styling the style name with itself.
6473         (set_style_name): New function.
6474         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6475         Update all callers according to the changes in cli/cli-style.h.
6476         * utils.h (fputs_highlighted): New function.
6477         * utils.c (fputs_highlighted): Likewise.
6478
6479 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6480
6481         * NEWS: Mention new pipe command and new convenience variables.
6482
6483 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6484
6485         * cli/cli-cmds.c (pipe_command): New function.
6486         (_initialize_cli_cmds): Call add_com for pipe_command.
6487         Define | as an alias for pipe.
6488         (exit_status_set_internal_vars): New function.
6489         (shell_escape): Call exit_status_set_internal_vars.
6490         cli/cli-decode.c (find_command_name_length): Recognize | as
6491         a single character command.
6492
6493 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6494
6495         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6496         top.c (execute_command_to_ui_file): New function, mostly a copy
6497         of execute_command_to_string.
6498         (execute_command_to_string): Implement by calling
6499         execute_command_to_ui_file.
6500
6501 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6502
6503         * top.h (saved_command_line): Remove declaration.
6504         * top.c (previous_saved_command_line, previous_repeat_arguments):
6505         New variables.
6506         (saved_command_line): Make static, define together with other
6507         'repeat variables'.
6508         (dont_repeat): Clear repeat_arguments.
6509         (repeat_previous, get_saved_command_line, save_command_line):
6510         New functions.
6511         (gdb_init): Initialize saved_command_line
6512         and previous_saved_command_line.
6513         * main.c (captured_main_1): Remove saved_command_line initialization.
6514         * event-top.c (handle_line_of_input): Update to use
6515         the new 'repeat' related functions instead of direct access to
6516         saved_command_line.
6517         * command.h (repeat_previous, get_saved_command_line,
6518         save_command_line): New declarations.
6519         (dont_repeat): Add comment.
6520
6521 2019-05-30  Tom Tromey  <tromey@adacore.com>
6522
6523         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6524         Fix comment.
6525         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6526
6527 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6528
6529         PR cli/24587
6530         * completer.c (complete): Initialize variable word.
6531
6532 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6533
6534         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6535         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6536         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6537         'body' is NULL to the outter 'if', protecting the '!is_define'
6538         situation as well.
6539
6540 2019-05-29  Tom Tromey  <tromey@adacore.com>
6541
6542         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6543         (dwarf_unknown): New function.
6544         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6545         (dwarf_type_encoding_name): Use dwarf_unknown.
6546
6547 2019-05-29  Tom Tromey  <tromey@adacore.com>
6548
6549         PR c++/20020:
6550         * cp-valprint.c (cp_print_value_fields): Call
6551         cp_print_static_field inside "try".
6552
6553 2019-05-29  Tom Tromey  <tromey@adacore.com>
6554
6555         * inflow.c (struct terminal_info): Add default operator=.
6556         * configure: Rebuild.
6557         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6558         -Wdeprecated-copy-dtor, -Wredundant-move.
6559
6560 2019-05-29  Tom Tromey  <tromey@adacore.com>
6561
6562         * NEWS: Add entry.
6563         * infcmd.c (print_return_value_1): Handle finish_print
6564         option.
6565         (show_print_finish): New function.
6566         (_initialize_infcmd): Add "set/show print finish" commands.
6567         * valprint.c (user_print_options): Initialize new member.
6568         * valprint.h (struct value_print_options) <finish_print>: New
6569         member.
6570
6571 2019-05-28  Tom Tromey  <tromey@adacore.com>
6572
6573         * ada-lang.c (ada_remove_Xbn_suffix)
6574         (find_old_style_renaming_symbol)
6575         (parse_old_style_renaming): Remove.
6576         (ada_find_renaming_symbol): Don't call
6577         find_old_style_renaming_symbol.
6578         (ada_is_renaming_symbol): Rename from
6579         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6580         bool.  Now static.
6581         (ada_read_var_value): Update and simplify.
6582         * ada-exp.y (write_var_or_type): Remove old code.
6583
6584 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6585
6586         * event-top.c: Remove include comment.
6587         * inflow.c (class scoped_ignore_sigttou): Move from here...
6588         * inflow.h (class scoped_ignore_sigttou): ...to here.
6589         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6590         * top.c:  Remove include comment.
6591
6592 2019-05-27  Tom Tromey  <tom@tromey.com>
6593
6594         * NEWS: Fix typo.
6595
6596 2019-05-22  Tom Tromey  <tromey@adacore.com>
6597
6598         * target.c (target_follow_exec): Constify parameter.
6599         * target-delegates.c: Rebuild.
6600         * remote.c (remote_target::follow_exec): Constify parameter.
6601         * infrun.c (follow_exec): Constify parameter.
6602         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6603         (target_follow_exec): Likewise.
6604
6605 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6606
6607         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6608         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6609
6610 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6611
6612         * NEWS: Add debugredirect and testsuite sections.
6613
6614 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6615
6616         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6617         target descriptions using exclusively floating point register name
6618         aliases.
6619
6620 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6621
6622         PR gdb/18644:
6623         * f-lang.c (build_fortran_types): Handle the case where
6624         gdbarch_floatformat_for_type returns a nullptr.
6625
6626 2019-05-21  Tom de Vries  <tdevries@suse.de>
6627
6628         PR cli/24587
6629         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6630
6631 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6632
6633         PR gdb/18644:
6634         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6635         16-byte floats.
6636         * i386-tdep.c (i386_floatformat_for_type): Use
6637         floatformats_ia64_quad for the 16-byte floating point component
6638         within a fortran 32-byte complex number.
6639
6640 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6641
6642         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6643         delete default constructor.
6644         (find_partial_die): Update to return const struct.
6645         (partial_die_parent_scope): Move variable declaration into scope
6646         of its use and change its type to auto.
6647         (guess_partial_die_structure_name): Likewise.
6648         (partial_die_info::fixup): Likewise.
6649
6650 2019-05-17  Tom Tromey  <tromey@adacore.com>
6651
6652         * source.c (find_and_open_source): Remove cast.
6653
6654 2019-05-17  Tom Tromey  <tromey@adacore.com>
6655
6656         * annotate.c (annotate_source): Make "filename" const.
6657         * annotate.h (annotate_source): Use const.
6658
6659 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6660
6661         * disasm.c (set_disassembler_options): Send errors to stderr.
6662
6663 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6664
6665         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6666         (cli_interp_base::set_logging): Check debug_redirect.
6667         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6668         * cli/cli-logging.c (debug_redirect): Add static variable.
6669         (pop_output_files): Add default param.
6670         (handle_redirections): Print debug setting.
6671         (show_logging_command): Likewise.
6672         (_initialize_cli_logging): Add debugredirect command.
6673         * interps.c (current_interp_set_logging): Add debug_redirect
6674         parameter.
6675         * interps.h (set_logging): Add debug_redirect parameter.
6676         (current_interp_set_logging): Likewise.
6677         * mi/mi-common.h: Likewise.
6678         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6679
6680 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6681             Tom Tromey  <tromey@adacore.com>
6682
6683         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6684         directly.
6685         * cli/cli-interp.h (make_logging_output): Remove declaration.
6686         * cli/cli-logging.c (make_logging_output): Remove function.
6687         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6688         directly.
6689         * ui-file.c (tee_file::tee_file): Remove bools.
6690         (tee_file::~tee_file): Remove deletes.
6691         * ui-file.h (tee_file): Remove bools.
6692
6693 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6694
6695         * mi/mi-cmds.h (mi_cmd_complete): New function.
6696         * mi/mi-main.c (mi_cmd_complete): Likewise.
6697         * mi/mi-cmds.c: Define new MI command -complete.
6698         * NEWS: Mention new -complete command.
6699
6700 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6701
6702         * completer.h (complete): New function.
6703         * completer.c (complete): Likewise.
6704         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6705         function defined in completer.h.
6706
6707 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6708
6709         * MAINTAINERS (Write After Approval): Add myself.
6710
6711 2019-05-17  Tom de Vries  <tdevries@suse.de>
6712
6713         PR gdb/24094
6714         * dwarf2read.c (struct cu_partial_die_info): New struct.
6715         (find_partial_die): Return cu_partial_die_info.
6716         (partial_die_parent_scope, guess_partial_die_structure_name)
6717         (partial_die_info::fixup): Handle new return type of find_partial_die.
6718
6719 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6720
6721         PR breakpoints/24541
6722         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6723         "std::string", simplifying the algorithm.
6724
6725 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6726
6727         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6728         (stap_static_probe_ops::get_probes): Likewise.
6729
6730 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6731
6732         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6733         '-')" and "else if".
6734         (stap_parse_single_operand): Join checks for
6735         "gdbarch_stap_parse_special_token_p" and
6736         "gdbarch_stap_parse_special_token" in the same "if" statement.
6737         Invert check when verifying for operation on register
6738         displacement.
6739
6740 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6741
6742         * stap-probe.c (stap_get_opcode): Update comment.
6743         (stap_get_expected_argument_type): Likewise.
6744         (handle_stap_probe): Likewise.
6745
6746 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6747
6748         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6749         return type to 'bool'.  Adjust comment.  Use 'bool' when
6750         appropriate.
6751         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6752         * stap-probe.c (stap_parse_argument_1): Likewise.
6753         (stap_is_operator): Likewise.
6754         (stap_is_generic_prefix): Likewise.
6755         (stap_is_register_prefix): Likewise.
6756         (stap_is_register_indirection_prefix): Likewise.
6757         (stap_is_integer_prefix): Likewise.
6758         (stap_generic_check_suffix): Likewise.
6759         (stap_check_integer_suffix): Likewise.
6760         (stap_check_register_suffix): Likewise.
6761         (stap_check_register_indirection_suffix): Likewise.
6762         (stap_parse_register_operand): Likewise.
6763         (stap_parse_single_operand): Likewise.
6764         (stap_parse_argument_1): Likewise.
6765         (stap_probe::get_argument_count): Likewise.
6766         (stap_is_operator): Likewise.
6767
6768 2019-05-16  Tom Tromey  <tromey@adacore.com>
6769
6770         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6771         keyword to foreach.
6772
6773 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6774
6775         * linux-thread-db.c (try_thread_db_load_1): Change return type
6776         to bool.
6777         (try_thread_db_load): Likewise.
6778         (try_thread_db_load_from_pdir_1): Likewise.
6779         (try_thread_db_load_from_pdir): Likewise.
6780         (try_thread_db_load_from_sdir): Likewise.
6781         (try_thread_db_load_from_dir): Likewise.
6782         (thread_db_load_search): Likewise.
6783         (has_libpthread): Likewise.
6784         (thread_db_load): Likewise.
6785
6786 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6787
6788         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6789         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6790         NULL, and complain/return if that's the case.
6791
6792 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6793
6794         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6795         (advance, posn, abstract_read_memory): New functions.
6796         [struct mem_read_abstraction]: New struct.
6797         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6798
6799 2019-05-14  Tom Tromey  <tromey@adacore.com>
6800
6801         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6802         value is not lval_memory.
6803
6804 2019-05-14  Tom Tromey  <tromey@adacore.com>
6805
6806         * solib.c (info_sharedlibrary_command): Style the file name.
6807
6808 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6809
6810         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6811         (aarch64_vnv_type): Likewise.
6812         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6813         * common/tdesc.c: Likewise.
6814         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6815         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6816         * features/aarch64-fpu.xml: Add ieee half view.
6817         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6818         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6819         * gdbtypes.h (struct builtin_type): Likewise.
6820         (struct objfile_type): Likewise.
6821
6822 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6823
6824         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6825         typo.
6826         * location.h (string_to_event_location): Likewise.
6827
6828 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6829
6830         GDB 8.3 released.
6831
6832 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6833
6834         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6835         New variable declaration.
6836         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6837         New variable.
6838         (print_one_breakpoint): Use ui_out::test_flags and new global
6839         variable to compute use_fixed_output.
6840         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6841         Remove.
6842         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6843         (mi_multi_location_breakpoint_output_fixed): Remove.
6844         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6845         new variable.
6846         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6847         fix_multi_location_breakpoint_output flag if version >= 3.
6848         * ui-out.h (enum ui_out_flag)
6849         <fix_multi_location_breakpoint_output>: New enumerator.
6850
6851 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6852
6853         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6854
6855 2019-05-10  Tom Tromey  <tromey@adacore.com>
6856
6857         * ada-lang.c (catch_ada_completer): New function.
6858         (_initialize_ada_language): Use it.
6859
6860 2019-05-10  Tom Tromey  <tromey@adacore.com>
6861
6862         * thread.c (print_thread_info): Make "requested_threads" const.
6863         * gdbthread.h (print_thread_info): Make "requested_threads"
6864         const.
6865         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6866         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6867
6868 2019-05-08  Tom Tromey  <tom@tromey.com>
6869
6870         * gdbtypes.c (objfile_type_data): Change type.
6871         (objfile_type, _initialize_gdbtypes): Update.
6872
6873 2019-05-08  Tom Tromey  <tom@tromey.com>
6874
6875         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6876         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6877         (_initialize_dwarf2_frame): Update.
6878
6879 2019-05-08  Tom Tromey  <tom@tromey.com>
6880
6881         * objc-lang.c (objc_objfile_data): Change type.
6882         (find_methods): Update.
6883         (_initialize_objc_lang): Remove.
6884
6885 2019-05-08  Tom Tromey  <tom@tromey.com>
6886
6887         * stabsread.c (rs6000_builtin_type_data): Change type.
6888         (rs6000_builtin_type, _initialize_stabsread): Update.
6889
6890 2019-05-08  Tom Tromey  <tom@tromey.com>
6891
6892         * mips-tdep.c (mips_pdr_data): Remove.
6893         (_initialize_mips_tdep): Update.
6894
6895 2019-05-08  Tom Tromey  <tom@tromey.com>
6896
6897         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6898         (hppa_init_objfile_priv_data, read_unwind_info)
6899         (find_unwind_entry, _initialize_hppa_tdep): Update.
6900
6901 2019-05-08  Tom Tromey  <tom@tromey.com>
6902
6903         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6904         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6905         on obstack.
6906         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6907
6908 2019-05-08  Tom Tromey  <tom@tromey.com>
6909
6910         * mdebugread.c (basic_type_data): Change type.
6911         (basic_type, _initialize_mdebugread): Update.
6912
6913 2019-05-08  Tom Tromey  <tom@tromey.com>
6914
6915         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6916
6917 2019-05-08  Tom Tromey  <tom@tromey.com>
6918
6919         * nto-tdep.c (nto_inferior_data_reg): Change type.
6920         (nto_inferior_data): Update.
6921         (nto_inferior_data_cleanup, nto_new_inferior_data)
6922         (_initialize_nto_tdep): Remove.
6923         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6924
6925 2019-05-08  Tom Tromey  <tom@tromey.com>
6926
6927         * ada-lang.c (struct ada_inferior_data): Add initializers.
6928         (ada_inferior_data): Change type.
6929         (ada_inferior_data_cleanup): Remove.
6930         (get_ada_inferior_data, ada_inferior_exit)
6931         (struct ada_pspace_data): Add initializers, destructor.
6932         (ada_pspace_data_handle): Change type.
6933         (get_ada_pspace_data): Update.
6934         (ada_pspace_data_cleanup): Remove.
6935
6936 2019-05-08  Tom Tromey  <tom@tromey.com>
6937
6938         * coffread.c (struct coff_symfile_info): Add initializers.
6939         (coff_objfile_data_key): Move lower.  Change type.
6940         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6941         Update.
6942         (coff_free_info): Remove.
6943
6944 2019-05-08  Tom Tromey  <tom@tromey.com>
6945
6946         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6947         (fbsd_pspace_data_handle): Move lower.  Change type.
6948         (get_fbsd_pspace_data): Update.
6949         (fbsd_pspace_data_cleanup): Remove.
6950         (_initialize_fbsd_tdep): Update.
6951
6952 2019-05-08  Tom Tromey  <tom@tromey.com>
6953
6954         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6955         (get_ada_tasks_pspace_data): Update.
6956         (ada_tasks_pspace_data_cleanup): Remove.
6957         (_initialize_tasks): Update.
6958         (ada_tasks_inferior_data_handle): Change type.
6959         (get_ada_tasks_inferior_data): Update.
6960         (ada_tasks_inferior_data_cleanup): Remove.
6961         (struct ada_tasks_pspace_data): Add initializers.
6962
6963 2019-05-08  Tom Tromey  <tom@tromey.com>
6964
6965         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6966         * symfile-debug.c (debug_sym_get_probes): Change type.
6967         * stap-probe.c (handle_stap_probe):
6968         (stap_static_probe_ops::get_probes): Change type.
6969         * probe.h (class static_probe_ops) <get_probes>: Change type.
6970         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6971         (parse_probes_in_pspace): Update.
6972         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6973         Update.
6974         (any_static_probe_ops::get_probes): Change type.
6975         * elfread.c (elfread_data): New typedef.
6976         (probe_key): Change type.
6977         (elf_get_probes): Likewise.  Update.
6978         (probe_key_free): Remove.
6979         (_initialize_elfread): Update.
6980         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6981         Change type.
6982         (dtrace_process_dof_probe, dtrace_process_dof)
6983         (dtrace_static_probe_ops::get_probe): Change type.
6984
6985 2019-05-08  Tom Tromey  <tom@tromey.com>
6986
6987         * xcoffread.c (struct xcoff_symfile_info): Rename from
6988         coff_symfile_info.  Add initializers.
6989         (xcoff_objfile_data_key): Move lower.  Change type.
6990         (XCOFF_DATA): Rewrite.
6991         (xcoff_free_info): Remove.
6992         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6993         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6994         (xcoff_initial_scan): Update.
6995
6996 2019-05-08  Tom Tromey  <tom@tromey.com>
6997
6998         * solib-svr4.c (struct svr4_info): Add initializers and
6999         destructor.
7000         <probes_table>: Now an htab_up.
7001         (solib_svr4_pspace_data): Change type.
7002         (free_probes_table): Simplify.
7003         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7004         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7005         (probes_table_remove_objfile_probes, register_solib_event_probe)
7006         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7007         (_initialize_svr4_solib): Update.
7008
7009 2019-05-08  Tom Tromey  <tom@tromey.com>
7010
7011         * remote.c (remote_pspace_data): Change type.
7012         (remote_pspace_data_cleanup): Remove.
7013         (get_remote_exec_file, set_pspace_remote_exec_file)
7014         (_initialize_remote): Update.
7015
7016 2019-05-08  Tom Tromey  <tom@tromey.com>
7017
7018         * breakpoint.c (breakpoint_objfile_key): Change type.
7019         (get_breakpoint_objfile_data): Update.
7020         (free_breakpoint_objfile_data): Remove.
7021         (_initialize_breakpoint): Update.
7022
7023 2019-05-08  Tom Tromey  <tom@tromey.com>
7024
7025         * linux-tdep.c (struct linux_info): Add initializers.
7026         (linux_inferior_data): Move.  Change type.
7027         (invalidate_linux_cache_inf): Update.
7028         (linux_inferior_data_cleanup): Remove.
7029         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7030
7031 2019-05-08  Tom Tromey  <tom@tromey.com>
7032
7033         * auxv.c (auxv_inferior_data): Move.  Change type.
7034         (auxv_inferior_data_cleanup): Remove.
7035         (invalidate_auxv_cache_inf): Rewrite.
7036         (get_auxv_inferior_data, _initialize_auxv): Update.
7037
7038 2019-05-08  Tom Tromey  <tom@tromey.com>
7039
7040         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7041         (symfile_debug_objfile_data_key): Change type.
7042         (symfile_debug_installed, debug_qf_has_symbols)
7043         (debug_qf_find_last_source_symtab)
7044         (debug_qf_forget_cached_source_info)
7045         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7046         (debug_qf_print_stats, debug_qf_dump)
7047         (debug_qf_expand_symtabs_for_function)
7048         (debug_qf_expand_all_symtabs)
7049         (debug_qf_expand_symtabs_with_fullname)
7050         (debug_qf_map_matching_symbols)
7051         (debug_qf_expand_symtabs_matching)
7052         (debug_qf_find_pc_sect_compunit_symtab)
7053         (debug_qf_map_symbol_filenames)
7054         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7055         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7056         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7057         (debug_sym_read_linetable, debug_sym_relocate): Update.
7058         (symfile_debug_free_objfile): Remove.
7059         (install_symfile_debug_logging, _initialize_symfile_debug):
7060         Update.
7061
7062 2019-05-08  Tom Tromey  <tom@tromey.com>
7063
7064         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7065         allocate_on_obstack.
7066         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7067         (get_dwarf2_per_objfile): Update.
7068         (set_dwarf2_per_objfile): Remove.
7069         (dwarf2_has_info, dwarf2_get_section_info): Update.
7070         (dwarf2_free_objfile): Remove.
7071         (_initialize_dwarf2_read): Update.
7072
7073 2019-05-08  Tom Tromey  <tom@tromey.com>
7074
7075         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7076         initializers.
7077         <unsupported_script_warning_printed,
7078         script_not_found_warning_printed>: Now bool.
7079         (auto_load_pspace_data): Change type.
7080         (~auto_load_pspace_info): Rename from
7081         auto_load_pspace_data_cleanup.
7082         (get_auto_load_pspace_data, init_loaded_scripts_info)
7083         (clear_section_scripts, maybe_print_unsupported_script_warning)
7084         (maybe_print_script_not_found_warning, _initialize_auto_load):
7085         Update.
7086
7087 2019-05-08  Tom Tromey  <tom@tromey.com>
7088
7089         * objfiles.c (objfile_pspace_info): Add destructor and
7090         initializers.
7091         (objfiles_pspace_data): Change type.
7092         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7093         (get_objfile_pspace_data): Update.
7094         (objfiles_bfd_data): Change type.
7095         (get_objfile_bfd_data): Update.
7096         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7097
7098 2019-05-08  Tom Tromey  <tom@tromey.com>
7099
7100         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7101         Change type.
7102         (get_catch_syscall_inferior_data): Update.
7103         (catch_syscall_inferior_data_cleanup): Remove.
7104         (_initialize_break_catch_syscall): Update.
7105
7106 2019-05-08  Tom Tromey  <tom@tromey.com>
7107
7108         * inflow.c (struct terminal_info): Add destructor and
7109         initializers.
7110         (inflow_inferior_data): Change type.
7111         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7112         (get_inflow_inferior_data, inflow_inferior_exit)
7113         (swap_terminal_info, _initialize_inflow): Update.
7114
7115 2019-05-08  Tom Tromey  <tom@tromey.com>
7116
7117         * target-dcache.c (target_dcache_cleanup): Remove.
7118         (target_dcache_aspace_key): Change type.
7119         (target_dcache_init_p, target_dcache_invalidate)
7120         (target_dcache_get, target_dcache_get_or_init)
7121         (_initialize_target_dcache): Update.
7122         * dcache.h (struct dcache_deleter): New.
7123
7124 2019-05-08  Tom Tromey  <tom@tromey.com>
7125
7126         * symtab.c (struct symbol_cache): Add destructor and
7127         initializers.
7128         (symbol_cache_key): Move.  Change type.
7129         (make_symbol_cache, free_symbol_cache): Remove.
7130         (get_symbol_cache): Update.
7131         (symbol_cache_cleanup): Remove.
7132         (ALL_PSPACES, symbol_cache_flush)
7133         (maintenance_print_symbol_cache)
7134         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7135         Update.
7136
7137 2019-05-08  Tom Tromey  <tom@tromey.com>
7138
7139         * symtab.c (struct main_info): Add destructor and initializers.
7140         (main_progspace_key): Move.  Change type.
7141         (get_main_info): Update.
7142         (main_info_cleanup): Remove.
7143         (_initialize_symtab): Update.
7144
7145 2019-05-08  Tom Tromey  <tom@tromey.com>
7146
7147         * registry.h (DECLARE_REGISTRY): Define the _key class.
7148
7149 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7150
7151         * NEWS: Merge two 'New commands' sections.
7152
7153 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7154
7155         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7156         parameter and use Ada language definition instead.
7157         (ada_val_print_ptr): Remove unused language parameter.
7158         (ada_val_print_num): Remove language parameter and use Ada language
7159         definition instead.
7160         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7161         parameter.
7162         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7163         parameter and use Ada language definition instead.
7164         (ada_val_print_1): Update all ada_val_print_xxx calls.
7165         Remove language parameter.
7166         (ada_val_print): Update ada_val_print_1 call.
7167
7168 2019-05-08  Tom Tromey  <tromey@adacore.com>
7169
7170         * remote.c (remote_hw_watchpoint_limit)
7171         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7172         Now static.
7173
7174 2019-05-08  Tom Tromey  <tromey@adacore.com>
7175
7176         * maint.c (_initialize_maint_cmds): Move initialization code to
7177         remote.c.
7178         (watchdog, show_watchdog): Move to remote.c.
7179         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7180         "watchdog" static.
7181         (_initialize_remote): Move initialization code from maint.c.
7182         * defs.h (watchdog): Don't declare.
7183
7184 2019-05-08  Tom Tromey  <tromey@adacore.com>
7185
7186         * tui/tui-interp.c: Include main.h.
7187         * interps.c: Include main.h.
7188         * main.h (interpreter_p): Declare.
7189         * defs.h (interpreter_p): Don't declare.
7190
7191 2019-05-08  Tom Tromey  <tromey@adacore.com>
7192
7193         * dwarf2loc.c: Include dwarf2read.h.
7194         * defs.h (read_unsigned_leb128): Don't declare.
7195         * dwarf2read.h (read_unsigned_leb128): Declare.
7196
7197 2019-05-08  Tom Tromey  <tromey@adacore.com>
7198
7199         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7200         method.
7201
7202 2019-05-08  Tom Tromey  <tromey@adacore.com>
7203
7204         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7205         when no wrap column is set.
7206
7207 2019-05-08  Tom Tromey  <tromey@adacore.com>
7208
7209         * c-lang.c (c_get_string): Handle non-C-style arrays.
7210
7211 2019-05-08  Tom Tromey  <tromey@adacore.com>
7212
7213         * typeprint.c (print_offset_data::update): Print the bit offset,
7214         not the number of bits remaining.
7215
7216 2019-05-08  Tom Tromey  <tromey@adacore.com>
7217
7218         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7219         padding at end of comment.
7220
7221 2019-05-08  Tom Tromey  <tromey@adacore.com>
7222
7223         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7224         Compare main types.
7225
7226 2019-05-06  Tom Tromey  <tom@tromey.com>
7227
7228         * common/scoped_mmap.c: Include common-defs.h.
7229         * common/scoped_mmap.h: Don't include config.h.
7230
7231 2019-05-04  Tom Tromey  <tom@tromey.com>
7232
7233         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7234         (struct aarch64_call_info): Add initializers.
7235         <si>: Now a std::vector.
7236         (pass_on_stack, aarch64_push_dummy_call): Update.
7237
7238 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7239             Tom Tromey  <tom@tromey.com>
7240
7241         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7242         (ppc_threads): Now a std::vector.  Now static.
7243         (hwdebug_find_thread_points_by_tid)
7244         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7245         Update.
7246
7247 2019-05-04  Tom Tromey  <tom@tromey.com>
7248
7249         * arc-tdep.c (arc_tdesc_init): Return bool.
7250
7251 2019-05-04  Tom Tromey  <tom@tromey.com>
7252
7253         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7254         Use gdb_assert_not_reached.
7255
7256 2019-05-04  Tom Tromey  <tom@tromey.com>
7257
7258         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7259         "false".
7260
7261 2019-05-04  Tom Tromey  <tom@tromey.com>
7262
7263         * arc-tdep.c (arc_tdesc_init): Use bool.
7264
7265 2019-05-04  Tom Tromey  <tom@tromey.com>
7266
7267         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7268
7269 2019-05-04  Tom Tromey  <tom@tromey.com>
7270
7271         * cli/cli-cmds.c (valid_command_p): Return bool.
7272
7273 2019-05-04  Tom Tromey  <tom@tromey.com>
7274
7275         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7276         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7277
7278 2019-05-04  Raul Tambre  <raul@tambre.ee>
7279
7280         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7281         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7282         operator for comparison.
7283
7284 2019-05-04  Tom Tromey  <tom@tromey.com>
7285
7286         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7287         (lookup_partial_symbol, print_partial_symbols)
7288         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7289         (psymbol_compare): Update.
7290         (add_psymbol_to_bcache): Clear the entire psymbol.
7291         (maintenance_check_psymtabs): Update.
7292         * psympriv.h (struct partial_symbol): Don't derive from
7293         general_symbol_info.
7294         <obj_section, unrelocated_address, address,
7295         set_unrelocated_address>: Update.
7296         <ginfo>: New member.
7297         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7298         (debug_names::write_psymbols): Update.
7299
7300 2019-05-04  Tom de Vries  <tdevries@suse.de>
7301
7302         * contrib/cc-with-tweaks.sh: Support -n arg.
7303
7304 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7305
7306         * corelow.c (core_target::detach): Ensure frame cache and
7307         register caches are cleared.
7308         inferior.c (exit_inferior_1): Likewise.
7309
7310 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7311             Tom Tromey  <tom@tromey.com>
7312
7313         * dictionary.c (collate_pending_symbols_by_language): Remove
7314         "struct" from foreach.
7315         * symtab.c (lookup_global_symbol_from_objfile)
7316         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7317         foreach.
7318         * ser-tcp.c (net_open): Remove "struct" from foreach.
7319         * objfiles.c (objfile_relocate, objfile_rebase)
7320         (objfile_has_symbols): Remove "struct" from foreach.
7321         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7322         from foreach.
7323         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7324         foreach.
7325         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7326         "struct" from foreach.
7327         * ada-lang.c (create_excep_cond_exprs)
7328         (ada_exception_catchpoint_cond_string): Remove "struct" from
7329         foreach.
7330
7331 2019-05-03  Tom Tromey  <tromey@adacore.com>
7332
7333         * ada-exp.y (convert_char_literal): Check suffix of each
7334         enumerator.
7335
7336 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7337
7338         PR ada/21406:
7339         * ada-exp.y (yywrap): Don't define.
7340         * ada-lex.l (%option): Add noyywrap
7341         (yywrap): Remove.
7342
7343 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7344
7345         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7346         _WIN32_WINNT to the XP level, unless already defined to a higher
7347         level.
7348
7349         * unittests/parse-connection-spec-selftests.c:
7350         * ser-tcp.c:
7351         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7352         override.
7353
7354         * symfile.c (find_separate_debug_file): Remove colon from the
7355         drive spec of DOS/Windows file names of the target, so that the
7356         file name produced from DEBUGDIR and the target's directory will
7357         be valid on DOS/Windows systems.
7358
7359 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7360
7361         * rust-lang.c (val_print_struct): Handle printing structures
7362         containing strings.
7363
7364 2019-05-02  Tom Tromey  <tromey@adacore.com>
7365
7366         * valarith.c (_initialize_valarith): Remove.
7367
7368 2019-05-01  Tom Tromey  <tromey@adacore.com>
7369
7370         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7371         bitfields.
7372
7373 2019-05-01  Tom Tromey  <tromey@adacore.com>
7374
7375         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7376         for big-endian copies.
7377
7378 2019-04-30  Ali Tamur  <tamur@google.com>
7379         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7380         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7381         (read_3_bytes): New function.
7382
7383 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7384
7385         * windows-nat.c (main_thread_id): Delete.
7386         (handle_output_debug_string): Replace main_thread_id by
7387         current_event.dwThreadId.
7388         (fake_create_process): Likewise.
7389         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7390         Do not set main_thread_id.
7391         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7392         current_event.dwThreadId.
7393         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7394
7395 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7396
7397         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7398         Use current_event.dwThreadId instead of main_thread_id.
7399
7400 2019-04-30  Tom Tromey  <tromey@adacore.com>
7401
7402         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7403         (create_excep_cond_exprs): Iterate over program spaces.
7404         (ada_exception_catchpoint_cond_string): Examine all minimal
7405         symbols for exception types.
7406
7407 2019-04-30  Tom Tromey  <tromey@adacore.com>
7408
7409         PR c++/24470:
7410         * dwarf2read.c (process_structure_scope): Handle case where type
7411         has template parameters but no symbol was created.
7412
7413 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7414             Chris January  <chris.january@arm.com>
7415
7416         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7417         qualifier.
7418         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7419
7420 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7421
7422         * f-typeprint.c (f_print_type): Update rules for printing
7423         whitespace.
7424         (f_type_print_varspec_suffix): Likewise.
7425
7426 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7427             Chris January  <chris.january@arm.com>
7428
7429         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7430         function arguments.
7431
7432 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7433
7434         * f-lang.c (build_fortran_types): Change name of void type to
7435         lower case.
7436         * f-typeprint.c (f_type_print_base): Print the name of the void
7437         type, rather than a fixed string.
7438         * f-valprint.c (f_decorations): Use lower case void string.
7439
7440 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7441             Chris January  <chris.january@arm.com>
7442
7443         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7444         types for Fortran.
7445
7446 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7447             Chris January  <chris.january@arm.com>
7448             David Lecomber  <david.lecomber@arm.com>
7449
7450         * f-exp.y (BINOP_INTRINSIC): New token.
7451         (exp): New parser rule handling BINOP_INTRINSIC.
7452         (f77_keywords): Add new builtin procedures.
7453         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7454         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7455         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7456         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7457         (print_unop_subexp_f): New function.
7458         (print_binop_subexp_f): New function.
7459         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7460         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7461         (dump_subexp_body_f): Likewise.
7462         (operator_check_f): Likewise.
7463         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7464         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7465
7466 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7467
7468         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7469         UNOP_KIND.
7470         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7471         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7472         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7473         (operator_length_f): New fuction.
7474         (print_subexp_f): New function.
7475         (op_name_f): New function.
7476         (dump_subexp_body_f): New function.
7477         (operator_check_f): New function.
7478         (exp_descriptor_f): Replace standard expression handling functions
7479         with new functions.
7480         * gdb/fortran-operator.def: New file.
7481         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7482         * gdb/std-operator.def: Remove UNOP_KIND.
7483
7484 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7485
7486         * std-operator.def: Remove unbalanced, stray double quote
7487         character.
7488
7489 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7490             Chris January  <chris.january@arm.com>
7491             Daniel Everett  <daniel.everett@arm.com>
7492             Nick Forrington  <nick.forrington@arm.com>
7493             Richard Bunt  <richard.bunt@arm.com>
7494
7495         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7496         of depth when printing anonymous structs or unions.
7497         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7498         Don't print either the top-level value, or the children if the
7499         max-depth is exceeded.
7500         (ppscm_print_children): When printing the key of a map, allow one
7501         extra level of depth.
7502         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7503         print either the top-level value, or the children if the max-depth
7504         is exceeded.
7505         (print_children): When printing the key of a map, allow one extra
7506         level of depth.
7507         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7508         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7509         (user_print_options): Initialise max_depth field.
7510         (val_print_scalar_or_string_type_p): New function.
7511         (val_print): Check to see if the max depth has been reached.
7512         (val_print_check_max_depth): Define new function.
7513         (show_print_max_depth): New function.
7514         (_initialize_valprint): Add 'print max-depth' option.
7515         * valprint.h (struct value_print_options) <max_depth>: New field.
7516         (val_print_check_max_depth): Declare new function.
7517         * NEWS: Document new feature.
7518
7519 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7520
7521         * ada-lang.c (ada_language_defn): Initialise new field.
7522         * c-lang.c (c_is_string_type_p): New function.
7523         (c_language_defn): Initialise new field.
7524         (cplus_language_defn): Initialise new field.
7525         (asm_language_defn): Initialise new field.
7526         (minimal_language_defn): Initialise new field.
7527         * c-lang.h (c_is_string_type_p): Declare new function.
7528         * d-lang.c (d_language_defn): Initialise new field.
7529         * f-lang.c (f_is_string_type_p): New function.
7530         (f_language_defn): Initialise new field.
7531         * go-lang.c (go_is_string_type_p): New function.
7532         (go_language_defn): Initialise new field.
7533         * language.c (default_is_string_type_p): New function.
7534         (unknown_language_defn): Initialise new field.
7535         (auto_language_defn): Initialise new field.
7536         * language.h (struct language_defn) <la_is_string_type_p>: New
7537         member variable.
7538         (default_is_string_type_p): Declare new function.
7539         * m2-lang.c (m2_language_defn): Initialise new field.
7540         * objc-lang.c (objc_language_defn): Initialise new field.
7541         * opencl-lang.c (opencl_language_defn): Initialise new field.
7542         * p-lang.c (pascal_is_string_type_p): New function.
7543         (pascal_language_defn): Initialise new field.
7544         * rust-lang.c (rust_is_string_type_p): New function.
7545         (rust_language_defn): Initialise new field.
7546
7547 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7548
7549         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7550         New field.
7551         * ada-lang.c (ada_language_defn): Initialise new field.
7552         * c-lang.c (c_language_defn): Likewise.
7553         (cplus_language_defn): Likewise.
7554         (asm_language_defn): Likewise.
7555         (minimal_language_defn): Likewise.
7556         * d-lang.c (d_language_defn): Likewise.
7557         * f-lang.c (f_language_defn): Likewise.
7558         * go-lang.c (go_language_defn): Likewise.
7559         * language.c (unknown_language_defn): Likewise.
7560         (auto_language_defn): Likewise.
7561         * m2-lang.c (m2_language_defn): Likewise.
7562         * objc-lang.c (objc_language_defn): Likewise.
7563         * opencl-lang.c (opencl_language_defn): Likewise.
7564         * p-lang.c (pascal_language_defn): Likewise.
7565         * rust-lang.c (rust_language_defn): Likewise.
7566
7567 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7568
7569         * ada-lang.c (ada_is_character_type): Change return type to bool.
7570         (ada_is_string_type): Likewise.
7571         * ada-lang.h (ada_is_character_type): Update declaration
7572         (ada_is_string_type): Likewise.
7573
7574 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7575
7576         Support style in 'frame|thread apply'
7577
7578         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7579         * record.c (record_start, record_stop): Update callers of
7580         execute_command_to_string with false.
7581         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7582         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7583         methods.
7584         (class string_file): New constructor with term_out parameter.
7585         Override methods term_out and can_emit_style_escape.  New member
7586         term_out.
7587         (class stdio_file): Override can_emit_style_escape.
7588         (class tee_file): Override term_out and can_emit_style_escape.
7589         * utils.h (can_emit_style_escape): Remove.
7590         * utils.c (can_emit_style_escape): Likewise.
7591         Update all callers of can_emit_style_escape (SOMESTREAM) to
7592         SOMESTREAM->can_emit_style_escape.
7593         * source-cache.c (source_cache::get_source_lines): Likewise.
7594         * stack.c (frame_apply_command_count): Call execute_command_to_string
7595         passing the term_out characteristic of the current gdb_stdout.
7596         * thread.c (thr_try_catch_cmd): Likewise.
7597         * top.c (execute_command_to_string): pass term_out parameter
7598         to construct the string_file for the command output.
7599         * ui-file.c (term_cli_styling): New function (most code moved
7600         from utils.c can_emit_style_escape).
7601         (string_file::string_file, string_file::can_emit_style_escape,
7602         stdio_file::can_emit_style_escape, tee_file::term_out,
7603         tee_file::can_emit_style_escape): New functions.
7604
7605 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7606
7607         * NEWS: Mention the new set|show may-call-functions.
7608         * infcall.c (may_call_functions_p): New variable.
7609         (show_may_call_functions_p): New function.
7610         (call_function_by_hand_dummy): Throws an error if not
7611         may-call-functions.
7612         (_initialize_infcall): Call add_setshow_boolean_cmd for
7613         may-call-functions.
7614
7615 2019-04-25  Keith Seitz  <keiths@redhat.com>
7616
7617         PR c++/24367
7618         * cp-support.c (inspect_type): Don't attempt substitutions
7619         of symbol with the same name.
7620
7621 2019-04-25  Tom Tromey  <tromey@adacore.com>
7622
7623         PR gdb/24475:
7624         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7625         static.
7626
7627 2019-04-25  Tom Tromey  <tromey@adacore.com>
7628
7629         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7630         rvalue reference.
7631         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7632         (gdb_xml_parser::parse): Use std::move.
7633         * python/python-internal.h (gdbpy_convert_exception): Take a const
7634         reference.
7635         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7636         std::move.
7637         * python/py-utils.c (gdbpy_convert_exception): Take a const
7638         reference.
7639         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7640         Use std::move.
7641         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7642         Use std::move.
7643         * mi/mi-main.c (mi_print_exception): Take a const reference.
7644         * main.c (handle_command_errors): Take a const reference.
7645         * linespec.c (parse_linespec): Use std::move.
7646         * infcall.c (run_inferior_call): Use std::move.
7647         (call_function_by_hand_dummy): Use std::move.
7648         * exec.c (try_open_exec_file): Use std::move.
7649         * exceptions.h (exception_print, exception_fprintf)
7650         (exception_print_same): Update.
7651         * exceptions.c (print_exception, exception_print)
7652         (exception_fprintf, exception_print_same): Change parameters to
7653         const reference.
7654         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7655         * common/new-op.c: Use std::move.
7656         * common/common-exceptions.h (struct gdb_exception): Add move
7657         constructor.
7658         (struct gdb_exception_error, struct gdb_exception_quit, struct
7659         gdb_quit_bad_alloc): Change constructor to move constructor.
7660         (throw_exception): Change parameter to rvalue reference.
7661         * common/common-exceptions.c (throw_exception): Take rvalue
7662         reference.
7663         * cli/cli-interp.c (safe_execute_command): Use std::move.
7664         * breakpoint.c (insert_bp_location, location_to_sals): Use
7665         std::move.
7666
7667 2019-04-25  Tom Tromey  <tromey@adacore.com>
7668
7669         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7670         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7671         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7672         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7673         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7674         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7675         guile/scm-value.c: Use unpack.
7676         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7677         gdbscm_gdb_exception.
7678         (gdbscm_throw_gdb_exception): Likewise.
7679         (struct gdbscm_gdb_exception): New.
7680         (unpack): New function.
7681         (gdbscm_wrap): Use unpack.
7682
7683 2019-04-25  Tom Tromey  <tromey@adacore.com>
7684
7685         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7686         (gdb_rl_callback_handler): Use std::move.
7687         * common/common-exceptions.h (struct gdb_exception): Add move
7688         assignment operator.
7689         (throw_exception_sjlj): Change "exception" to const reference.
7690         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7691         (throw_exception_sjlj): Change "exception" to const reference.
7692
7693 2019-04-25  Tom Tromey  <tromey@adacore.com>
7694
7695         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7696         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7697         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7698         Update.
7699         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7700         Update.
7701         * mi/mi-interp.c (mi_interp::exec): Update.
7702         * linespec.c (parse_linespec): Update.
7703         * infcall.c (run_inferior_call): Update.
7704         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7705         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7706         (gdbscm_lookup_global_symbol): Update.
7707         * guile/scm-param.c (gdbscm_parameter_value): Update.
7708         * guile/scm-frame.c (gdbscm_frame_read_register)
7709         (gdbscm_frame_read_var): Update.
7710         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7711         * exec.c (try_open_exec_file): Update.
7712         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7713         (gdb_rl_callback_handler): Update.
7714         * common/common-exceptions.h (exception_none): Don't declare.
7715         * common/common-exceptions.c (exception_none): Don't define.
7716         (struct catcher) <exception>: Update.
7717         * cli/cli-interp.c (safe_execute_command): Update.
7718         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7719
7720 2019-04-25  Ali Tamur  <tamur@google.com>
7721
7722         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7723         (read_attribute_value): Likewise.
7724         (dwarf2_read_addr_index): Update comment.
7725         (read_str_index): Add DW_FORM_strx.
7726         (dwarf2_string_attr): Likewise.
7727         (dwarf2_const_value_attr): Likewise.
7728         (dump_die_shallow): Likewise.
7729         (dwarf2_fetch_constant_bytes): Likewise.
7730         (skip_form_bytes): Likewise.
7731         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7732
7733 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7734
7735         PR corefiles/11608
7736         PR corefiles/18187
7737         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7738         OFFSET.  Verify if current mapping contains an ELF header.
7739         (linux_find_memory_regions_full): Adjust call to
7740         dump_mapping_p.
7741
7742 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7743             Kang Li <kanglictf@gmail.com>
7744
7745         PR gdb/21600
7746
7747         * dwarf2-frame.c (read_initial_length): Be consistent about using
7748         unsigned representation of length.
7749         (decode_frame_entry_1): Likewise.  Check for wraparound of
7750         end pointer as well as buffer overflow.
7751
7752 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7753
7754         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7755         "vq".
7756
7757 2019-04-24  Tom Tromey  <tromey@adacore.com>
7758
7759         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7760
7761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7762
7763         * s12z-tdep.c (s12z_unwind_pc): Delete.
7764         (s12z_unwind_sp): Delete.
7765         (s12z_gdbarch_init): Don't register deleted functions with
7766         gdbarch.
7767
7768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7769
7770         * rl78-tdep.c (rl78_unwind_sp): Delete.
7771         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7772
7773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7774
7775         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7776         (xstormy16_unwind_pc): Delete.
7777         (xstormy16_dummy_id): Delete.
7778         (xstormy16_gdbarch_init): Don't register deleted functions with
7779         gdbarch.
7780
7781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7782
7783         * vax-tdep.c (vax_unwind_pc): Delete.
7784         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7785
7786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7787
7788         * v850-tdep.c (v850_unwind_sp): Delete.
7789         (v850_unwind_pc): Delete.
7790         (v850_dummy_id): Delete.
7791         (v850_gdbarch_init): Don't register deleted functions with
7792         gdbarch.
7793
7794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7795
7796         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7797         (tilegx_unwind_pc): Delete.
7798         (tilegx_unwind_dummy_id): Delete.
7799         (tilegx_gdbarch_init): Don't register deleted functions with
7800         gdbarch.
7801
7802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7803
7804         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7805         (tic6x_dummy_id): Delete.
7806         (tic6x_gdbarch_init): Don't register deleted functions with
7807         gdbarch.
7808
7809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7810
7811         * sparc-tdep.c (sparc_unwind_pc): Delete.
7812         (sparc32_gdbarch_init): Don't register deleted function with
7813         gdbarch.
7814
7815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7816
7817         * sh-tdep.c (sh_unwind_sp): Delete.
7818         (sh_unwind_pc): Delete.
7819         (sh_dummy_id): Delete.
7820         (sh_gdbarch_init): Don't register deleted functions with
7821         gdbarch.
7822
7823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7824
7825         * score-tdep.c (score_unwind_sp): Delete.
7826         (score_unwind_pc): Delete.
7827         (score_dummy_id): Delete.
7828         (score_gdbarch_init): Don't register deleted functions with
7829         gdbarch.
7830
7831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7832
7833         * rx-tdep.c (rx_unwind_pc): Delete.
7834         (rx_unwind_sp): Delete.
7835         (rx_dummy_id): Delete.
7836         (rx_gdbarch_init): Don't register deleted functions with
7837         gdbarch.  Update comment.
7838
7839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7840
7841         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7842         (rs6000_dummy_id): Delete.
7843         (rs6000_gdbarch_init): Don't register deleted functions with
7844         gdbarch.
7845
7846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7847
7848         * or1k-tdep.c (or1k_dummy_id): Delete.
7849         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7850
7851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * nios2-tdep.c (nios2_dummy_id): Delete.
7854         (nios2_unwind_sp): Delete.
7855         (nios2_gdbarch_init): Don't register deleted functions with
7856         gdbarch.
7857
7858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7859
7860         * nds32-tdep.c (nds32_dummy_id): Delete.
7861         (nds32_unwind_pc): Delete.
7862         (nds32_unwind_sp): Delete.
7863         (nds32_gdbarch_init): Don't register deleted functions with
7864         gdbarch.
7865
7866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7867
7868         * msp430-tdep.c (msp430_unwind_pc): Delete.
7869         (msp430_unwind_sp): Delete.
7870         (msp430_dummy_id): Delete.
7871         (msp430_gdbarch_init): Don't register deleted functions with
7872         gdbarch.
7873
7874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7875
7876         * moxie-tdep.c (moxie_unwind_sp): Delete.
7877         (moxie_unwind_pc): Delete.
7878         (moxie_dummy_id): Delete.
7879         (moxie_gdbarch_init): Don't register deleted functions with
7880         gdbarch.
7881
7882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7883
7884         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7885         (mn10300_unwind_pc): Delete.
7886         (mn10300_unwind_sp): Delete.
7887         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7888         mn10300_unwind_sp.
7889         (mn10300_frame_unwind_init): Don't register deleted functions with
7890         gdbarch.
7891
7892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7893
7894         * mep-tdep.c (mep_unwind_pc): Delete.
7895         (mep_unwind_sp): Delete.
7896         (mep_dummy_id): Delete.
7897         (mep_gdbarch_init): Don't register deleted functions with
7898         gdbarch.
7899
7900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7901
7902         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7903         (m68hc11_unwind_sp): Delete.
7904         (m68hc11_gdbarch_init): Don't register deleted functions with
7905         gdbarch.
7906
7907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7908
7909         * m32r-tdep.c (m32r_unwind_sp): Delete.
7910         (m32r_unwind_pc): Delete.
7911         (m32r_dummy_id): Delete.
7912         (m32r_gdbarch_init): Don't register deleted functions with
7913         gdbarch.
7914
7915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7916
7917         * m32c-tdep.c (m32c_unwind_pc): Delete.
7918         (m32c_unwind_sp): Delete.
7919         (m32c_dummy_id): Delete.
7920         (m32c_gdbarch_init): Don't register deleted functions with
7921         gdbarch.
7922
7923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7924
7925         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7926         (lm32_unwind_pc): Delete.
7927         (lm32_dummy_id): Delete.
7928         (lm32_gdbarch_init): Don't register deleted functions with
7929         gdbarch.
7930
7931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7932
7933         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7934         (iq2000_unwind_pc): Delete.
7935         (iq2000_dummy_id): Delete.
7936         (iq2000_gdbarch_init): Don't register deleted functions with
7937         gdbarch.
7938
7939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7940
7941         * nds32-tdep.c (nds32_type_align): Delete.
7942         (nds32_push_dummy_call): Use type_align instead.
7943
7944 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7945
7946         * arm-tdep.c (arm_type_align): Only handle vector override case.
7947         (arm_push_dummy_call): Use type_align.
7948         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7949
7950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7951
7952         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7953         case.
7954         (pass_on_stack): Use type_align.
7955         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7956         function.
7957
7958 2019-04-23  Tom Tromey  <tromey@adacore.com>
7959
7960         * dwarf2read.c (line_header::file_name_at): Remove unused
7961         overload.
7962
7963 2019-04-23  Tom de Vries  <tdevries@suse.de>
7964
7965         PR gdb/24438
7966         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7967         invocation.
7968
7969
7970 2019-03-27  Ali Tamur  <tamur@google.com>
7971
7972         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7973         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7974         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7975         (dwarf_expr_context::get_addr_index): Likewise
7976         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7977         (symbol_needs_eval_context::get_addr_index): Likewise
7978         (disassemble_dwarf_expression): Add DW_OP_addrx
7979         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7980         (read_cutu_die_from_dwo): Update comment
7981         (skip_one_die): Add DW_FORM_addrx
7982         (read_attribute_value): Likewise
7983         (var_decode_location): Add DW_OP_addrx
7984         (dwarf2_const_value_attr): Add DW_FORM_addrx
7985         (dump_die_shallow): Likewise
7986         (dwarf2_fetch_constant_bytes): Likewise
7987         (decode_locdesc): Add DW_OP_addrx
7988         (skip_form_bytes): Add DW_FORM_addrx
7989
7990 2019-04-22  Ali Tamur  <tamur@google.com>
7991
7992         * MAINTAINERS (Write After Approval): Add self.
7993
7994 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7995
7996         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7997         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7998         (open_symbol_file_object): Likewise.
7999         (svr4_default_sos): Add info parameter.
8000         (svr4_read_so_list): Likewise.
8001         (svr4_current_sos_direct): Adjust functions calls to pass down
8002         info.
8003         (svr4_current_sos_1): Add info parameter.
8004         (svr4_current_sos): Call get_svr4_info, pass info down to
8005         svr4_current_sos_1.
8006         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8007         get_svr4_info.
8008         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8009         get_svr4_info.
8010         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8011         to get_svr4_info.
8012         (probes_table_remove_objfile_probes): Likewise.
8013         (register_solib_event_probe): Add info parameter.
8014         (solist_update_incremental): Pass info parameter down to
8015         svr4_read_so_list.
8016         (disable_probes_interface): Add info parameter.
8017         (svr4_handle_solib_event): Pass current_program_space to
8018         get_svr4_info.  Adjust disable_probes_interface cleanup.
8019         (svr4_create_probe_breakpoints): Add info parameter, pass it
8020         down to register_solib_event_probe.
8021         (svr4_create_solib_event_breakpoints): Add info parameter,
8022         pass it down to svr4_create_probe_breakpoints.
8023         (enable_break): Pass info down to
8024         svr4_create_solib_event_breakpoints.
8025         (svr4_solib_create_inferior_hook): Pass current_program_space to
8026         get_svr4_info.
8027         (svr4_clear_solib): Likewise.
8028
8029 2019-04-22  Pedro Alves  <palves@redhat.com>
8030
8031         * solib-svr4.c (svr4_free_objfile_observer): New.
8032         (probe_and_action::objfile): New field.
8033         (probes_table_htab_remove_objfile_probes)
8034         (probes_table_remove_objfile_probes): New functions.
8035         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8036         in the new probe_and_action.  Don't store the probe in 'lookup'.
8037         (svr4_create_probe_breakpoints): Pass objfile to
8038         register_solib_event_probe.
8039         (_initialize_svr4_solib): Register a free_objfile observer.
8040
8041 2019-04-19  Tom Tromey  <tom@tromey.com>
8042
8043         * common/queue.h: Remove.
8044
8045 2019-04-19  Tom Tromey  <tom@tromey.com>
8046
8047         * event-loop.c: Don't include "common/queue.h".
8048
8049 2019-04-19  Tom Tromey  <tom@tromey.com>
8050
8051         * remote.c (remote_target): Use delete.
8052         * remote-notif.h: Include <list>, not "common/queue.h".
8053         (notif_client_p): Remove typedef.
8054         (remote_notif_state): Add constructor, destructor, initializer.
8055         <notif_queue>: Now a std::list.
8056         (remote_notif_state_xfree): Don't declare.
8057         * remote-notif.c (remote_notif_process, handle_notification)
8058         (remote_notif_state_allocate): Update.
8059         (~remote_notif_state): Rename from remote_notif_state_xfree.
8060
8061 2019-04-19  Tom Tromey  <tom@tromey.com>
8062
8063         * symfile.c (reread_symbols): Update.
8064         * objfiles.c (objfile_register_static_link)
8065         (objfile_lookup_static_link): Update
8066         (~objfile) Don't delete static_links.
8067         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8068
8069 2019-04-19  Tom Tromey  <tom@tromey.com>
8070
8071         * type-stack.h (struct type_stack) <insert>: Constify string.
8072         * type-stack.c (type_stack::insert): Constify string.
8073         * gdbtypes.h (lookup_template_type): Update.
8074         (address_space_name_to_int): Update.
8075         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8076         const.
8077         (lookup_template_type): Make name const.
8078         * c-exp.y: Update rules.
8079         (lex_one_token, classify_name, classify_inner_name)
8080         (c_print_token): Update.
8081         * p-exp.y: Update rules.
8082         (yylex): Update.
8083         * f-exp.y: Update rules.
8084         (yylex): Update.
8085         * d-exp.y: Update rules.
8086         (lex_one_token, classify_name, classify_inner_name): Update.
8087         * parse.c (write_dollar_variable, copy_name): Return std::string.
8088         * parser-defs.h (copy_name): Change return type.
8089         * m2-exp.y: Update rules.
8090         (yylex): Update.
8091         * go-exp.y (lex_one_token): Update.
8092         Update rules.
8093         (classify_unsafe_function, classify_packaged_name)
8094         (classify_name, yylex): Update.
8095
8096 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8097
8098         * configure.ac: add --enable-source-highlight switch.
8099         * configure: Regenerate.
8100         * top.c (print_gdb_version): plumb --enable-source-highlight
8101         status to "show configuration".
8102
8103 2019-04-19  Tom Tromey  <tromey@adacore.com>
8104
8105         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8106         Check ADA_TYPE_P.
8107         (empty_record, ada_template_to_fixed_record_type_1)
8108         (template_to_static_fixed_type)
8109         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8110         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8111         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8112         macros.
8113
8114 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8115
8116         PR symtab/24423:
8117         * source.c (print_source_lines_base): Advance "iter" when a
8118         control character is seen.
8119
8120 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8121
8122         * inferior.h (struct infcall_suspend_state_deleter):
8123         Catch exception in destructor to avoid crash.
8124
8125 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8126
8127         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8128         close to the add_com "shell".
8129
8130 2019-04-18  Tom Tromey  <tromey@adacore.com>
8131
8132         * process-stratum-target.h (class process_stratum_target)
8133         <stratum>: Add "final".
8134
8135 2019-04-17  Tom Tromey  <tromey@adacore.com>
8136
8137         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8138         against nullptr before use.
8139
8140 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8141
8142         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8143
8144 2019-04-17  Jim Wilson  <jimw@sifive.com>
8145             Andrew Burgess  <andrew.burgess@embecosm.com>
8146
8147         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8148         code read might fail, assume 4-byte breakpoint in that case.
8149
8150 2019-04-15  Leszek Swirski  <leszeks@google.com>
8151
8152         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8153         rather than a hand-rolled POD check when checking for forced MEMORY
8154         classification.
8155
8156 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8157
8158         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8159         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8160         function.
8161         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8162         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8163         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8164         declaration.
8165
8166 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8167
8168         * aarch64-linux-nat.c
8169         (aarch64_linux_nat_target::thread_architecture): Add override.
8170         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8171         each VQ.
8172
8173 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8174
8175         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8176
8177 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8178
8179         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8180         target types of size 96-bits, add some additional comments, and
8181         check that the builtin type we found was the correct size.
8182
8183 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8184
8185         * utils.c (prompt_for_continue): Don't restore the styling at the
8186         end, as applied_style has the wrong value.  This fixes styling in
8187         long lists of file names that are interrupted by the "Continue?"
8188         prompt.
8189
8190 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8191
8192         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8193         * c-lang.c (c_language_defn): Likewise.
8194         (cplus_language_defn): Likewise.
8195         (asm_language_defn): Likewise.
8196         (minimal_language_defn): Likewise.
8197         * d-lang.c (d_language_defn): Likewise.
8198         * f-lang.c (f_language_defn): Likewise.
8199         * go-lang.c (go_language_defn): Likewise.
8200         * language.c (unknown_language_defn): Likewise.
8201         (auto_language_defn): Likewise.
8202         * language.h (struct language_defn): Remove la_magic field.
8203         (LANG_MAGIC): Delete.
8204         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8205         * objc-lang.c (objc_language_defn): Likewise.
8206         * opencl-lang.c (opencl_language_defn): Likewise.
8207         * p-lang.c (pascal_language_defn): Likewise.
8208         * rust-lang.c (rust_language_defn): Likewise.
8209
8210 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8211
8212         * riscv-tdep.c (riscv_type_align): New function.
8213         (riscv_type_alignment): Delete.
8214         (riscv_arg_location): Use 'type_align'.
8215         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8216
8217 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8218
8219         * gdbtypes.c (type_align): A struct with no non-static fields also
8220         has alignment of 1.
8221
8222 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8223
8224         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8225         component to 0.
8226         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8227         member.
8228         (riscv_struct_info::analyse): New implementation using new
8229         analyse_inner member function.
8230         (riscv_struct_info::field_offset): New member function.
8231         (riscv_struct_info::m_offsets): New member variable.
8232         (riscv_struct_info::analyse_inner): New private member function,
8233         takes the old implementation of riscv_struct_info::analyse but
8234         extended to track field offsets.
8235         (riscv_call_arg_struct): Update the struct folding special cases
8236         to handle cases where empty C++ structs, which are non-zero
8237         length, are found.
8238         (riscv_arg_location): Initialise the length of each location, a
8239         non-zero length now indicates the location is in use.
8240         (riscv_push_dummy_call): Allow for the first location having a
8241         non-zero offset when setting up arguments.
8242         (riscv_return_value): Likewise, but for return values.
8243
8244 2019-04-11  Tom Tromey  <tromey@adacore.com>
8245
8246         * utils.c (internal_vproblem): Make "msg" const.
8247
8248 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8249
8250         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8251         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8252         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8253         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8254
8255 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8256
8257         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8258         function.
8259         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8260         of amd64_collect_native_gregset.
8261         (amd64_linux_nat_target::store_registers): Likewise.
8262
8263 2019-04-10  Tom Tromey  <tom@tromey.com>
8264
8265         * symtab.c (lookup_global_symbol_from_objfile)
8266         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8267         * objfiles.h (class separate_debug_iterator): New.
8268         (class separate_debug_range): New.
8269         (struct objfile) <separate_debug_objfiles>: New method.
8270         (objfile_separate_debug_iterate): Don't declare.
8271         * objfiles.c (separate_debug_iterator::operator++): Rename from
8272         objfile_separate_debug_iterate.
8273         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8274         iterator.
8275         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8276         iterator.
8277
8278 2019-04-10  Tom Tromey  <tom@tromey.com>
8279
8280         * symfile.c (reread_symbols): Remove old comment.
8281         * objfiles.c (free_all_objfiles): Fix a typo.
8282
8283 2019-04-10  Tom Tromey  <tom@tromey.com>
8284
8285         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8286         * minsyms.c (lookup_minimal_symbol): Use foreach.
8287         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8288         (lookup_minimal_symbol_solib_trampoline): Likewise.
8289         * symfile.c (reread_symbols): Use foreach.
8290
8291 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8292             Tom Tromey  <tromey@adacore.com>
8293
8294         PR rust/24414:
8295         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8296         (rust_lex_int_test): Change "value" to be LONGEST.
8297         (rust_lex_tests): Add test for long integer literal.
8298
8299 2019-04-09  Tom Tromey  <tromey@adacore.com>
8300
8301         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8302         to bool.
8303         (extended_remote_target::attach): Update.
8304         (remote_target::remote_notice_new_inferior): Update.
8305         (remote_target::add_current_inferior_and_thread): Update.
8306         * inferior.c (exit_inferior_1): Use "false".
8307         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8308
8309 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8310
8311         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8312         the "start" command.
8313
8314 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8315
8316         * python/py-inferior.c (infpy_thread_from_thread_handle):
8317         Adjust comments to reflect renaming of thread_from_thread_handle
8318         to thread_from_handle.  Adjust keywords.  Fix type error message.
8319         (inferior_object_methods): Add thread_from_handle.  Retain
8320         thread_from_thread_handle, but mark it as deprecated.
8321
8322 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8323
8324         * gdbthread.h (find_thread_by_handle): Revise declaration.
8325         * thread.c (find_thread_by_handle): Likewise.  Adjust
8326         implementation too.
8327         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8328         support for buffer objects as handles.
8329
8330 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8331
8332         * python/py-infthread.c (thpy_thread_handle): New function.
8333         (thread_object_methods): Register thpy_thread_handle.
8334
8335 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8336
8337         * gdbthread.h (thread_to_thread_handle): Declare.
8338         * thread.c (gdbtypes.h): Include.
8339         (thread_to_thread_handle): New function.
8340
8341         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8342         (target_thread_info_to_thread_handle): Declare.
8343         * target.c (target_thread_info_to_thread_handle): New function.
8344         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8345         * target-delegates.c: Regenerate.
8346
8347         * linux-thread-db.c (class thread_db_target): Add method
8348         thread_info_to_thread_handle.
8349         (thread_db_target::thread_info_to_thread_handle): Define.
8350         * remote.c (class remote_target): Add new method
8351         thread_info_to_thread_handle.
8352         (remote_target::thread_info_to_thread_handle): Define.
8353
8354 2019-04-08  Pedro Alves  <palves@redhat.com>
8355
8356         * common/common-exceptions.c (throw_exception): Don't create
8357         named object to throw; throw directly.
8358         (throw_it): Likewise.  Don't initialize gdb_exception::message
8359         here, with new; pass FMT and AP to the ctor instead.
8360         * common/common-exceptions.h: Include <string>.
8361         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8362         const char *, va_list)): New ctor.  Use std::make_shared.
8363         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8364         errors)): Delete.
8365         (gdb_exception_error::gdb_exception_error(enum errors, const char
8366         *, va_list)): New.
8367         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8368         Add assertion.
8369         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8370         errors)): Delete.
8371         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8372         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8373         Add assertion.
8374
8375 2019-04-08  Tom Tromey  <tom@tromey.com>
8376
8377         * valops.c (value_rtti_indirect_type): Replace throw_exception
8378         with throw.
8379         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8380         with throw.
8381         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8382         throw.
8383         * target.c (target_translate_tls_address): Replace throw_exception
8384         with throw.
8385         * stack.c (frame_apply_command_count): Replace throw_exception
8386         with throw.
8387         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8388         throw.
8389         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8390         with throw.
8391         * rs6000-tdep.c (rs6000_frame_cache)
8392         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8393         * remote.c: Replace throw_exception with throw.
8394         * record-full.c (record_full_message, record_full_wait_1)
8395         (record_full_restore): Replace throw_exception with throw.
8396         * record-btrace.c:
8397         (get_thread_current_frame_id, record_btrace_start_replaying)
8398         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8399         (cmd_record_btrace_start): Replace throw_exception with throw.
8400         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8401         throw.
8402         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8403         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8404         * linespec.c:
8405         (find_linespec_symbols): Replace throw_exception with throw.
8406         * infrun.c (displaced_step_prepare, resume): Replace
8407         throw_exception with throw.
8408         * infcmd.c (post_create_inferior): Replace throw_exception with
8409         throw.
8410         * inf-loop.c (inferior_event_handler): Replace throw_exception
8411         with throw.
8412         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8413         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8414         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8415         (get_prev_frame_always, get_frame_pc_if_available)
8416         (get_frame_address_in_block_if_available, get_frame_language):
8417         Replace throw_exception with throw.
8418         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8419         throw_exception with throw.
8420         * eval.c (fetch_subexp_value, evaluate_var_value)
8421         (evaluate_funcall, evaluate_subexp_standard): Replace
8422         throw_exception with throw.
8423         * dwarf2loc.c (call_site_find_chain)
8424         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8425         Replace throw_exception with throw.
8426         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8427         with throw.
8428         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8429         throw.
8430         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8431         * completer.c (complete_line_internal): Replace throw_exception
8432         with throw.
8433         * compile/compile-object-run.c (compile_object_run): Replace
8434         throw_exception with throw.
8435         * cli/cli-script.c (process_next_line): Replace throw_exception
8436         with throw.
8437         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8438         (btrace_enable, btrace_maint_update_pt_packets): Replace
8439         throw_exception with throw.
8440         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8441         throw_exception with throw.
8442         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8443         throw_exception with throw.
8444         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8445         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8446         * aarch64-tdep.c (aarch64_make_prologue_cache)
8447         (aarch64_make_stub_cache): Replace throw_exception with throw.
8448
8449 2019-04-08  Tom Tromey  <tom@tromey.com>
8450
8451         * common/common-exceptions.c (throw_exception): Rename from
8452         throw_exception_cxx.  Remove old copy.  Make argument const.
8453         (throw_it): Create and throw exception objects directly.
8454         * common/common-exceptions.h (throw_exception): Make argument
8455         const.
8456         (struct gdb_exception_error): Add constructor.
8457         (struct gdb_exception_quit): Add constructor.
8458
8459 2019-04-08  Tom Tromey  <tom@tromey.com>
8460
8461         * common/common-exceptions.h (exception_rethrow): Don't declare.
8462         (TRY_SJLJ): Update comment.
8463         (TRY, CATCH, END_CATCH): Remove.
8464         * common/common-exceptions.c (exception_rethrow): Remove.
8465
8466 2019-04-08  Tom Tromey  <tom@tromey.com>
8467
8468         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8469         Remove.
8470         (gdb_exception_error): Rename from
8471         gdb_exception_RETURN_MASK_ERROR.
8472         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8473         (gdb_quit_bad_alloc): Update.
8474         * aarch64-tdep.c: Update.
8475         * ada-lang.c: Update.
8476         * ada-typeprint.c: Update.
8477         * ada-valprint.c: Update.
8478         * amd64-tdep.c: Update.
8479         * arch-utils.c: Update.
8480         * break-catch-throw.c: Update.
8481         * breakpoint.c: Update.
8482         * btrace.c: Update.
8483         * c-varobj.c: Update.
8484         * cli/cli-cmds.c: Update.
8485         * cli/cli-interp.c: Update.
8486         * cli/cli-script.c: Update.
8487         * common/common-exceptions.c: Update.
8488         * common/new-op.c: Update.
8489         * common/selftest.c: Update.
8490         * compile/compile-c-symbols.c: Update.
8491         * compile/compile-cplus-symbols.c: Update.
8492         * compile/compile-object-load.c: Update.
8493         * compile/compile-object-run.c: Update.
8494         * completer.c: Update.
8495         * corelow.c: Update.
8496         * cp-abi.c: Update.
8497         * cp-support.c: Update.
8498         * cp-valprint.c: Update.
8499         * darwin-nat.c: Update.
8500         * disasm-selftests.c: Update.
8501         * dtrace-probe.c: Update.
8502         * dwarf-index-cache.c: Update.
8503         * dwarf-index-write.c: Update.
8504         * dwarf2-frame-tailcall.c: Update.
8505         * dwarf2-frame.c: Update.
8506         * dwarf2loc.c: Update.
8507         * dwarf2read.c: Update.
8508         * eval.c: Update.
8509         * event-loop.c: Update.
8510         * event-top.c: Update.
8511         * exec.c: Update.
8512         * f-valprint.c: Update.
8513         * fbsd-tdep.c: Update.
8514         * frame-unwind.c: Update.
8515         * frame.c: Update.
8516         * gdbtypes.c: Update.
8517         * gnu-v3-abi.c: Update.
8518         * guile/guile-internal.h: Update.
8519         * guile/scm-block.c: Update.
8520         * guile/scm-breakpoint.c: Update.
8521         * guile/scm-cmd.c: Update.
8522         * guile/scm-disasm.c: Update.
8523         * guile/scm-frame.c: Update.
8524         * guile/scm-lazy-string.c: Update.
8525         * guile/scm-math.c: Update.
8526         * guile/scm-param.c: Update.
8527         * guile/scm-ports.c: Update.
8528         * guile/scm-pretty-print.c: Update.
8529         * guile/scm-symbol.c: Update.
8530         * guile/scm-symtab.c: Update.
8531         * guile/scm-type.c: Update.
8532         * guile/scm-value.c: Update.
8533         * i386-linux-tdep.c: Update.
8534         * i386-tdep.c: Update.
8535         * inf-loop.c: Update.
8536         * infcall.c: Update.
8537         * infcmd.c: Update.
8538         * infrun.c: Update.
8539         * jit.c: Update.
8540         * language.c: Update.
8541         * linespec.c: Update.
8542         * linux-fork.c: Update.
8543         * linux-nat.c: Update.
8544         * linux-tdep.c: Update.
8545         * linux-thread-db.c: Update.
8546         * main.c: Update.
8547         * mi/mi-cmd-break.c: Update.
8548         * mi/mi-cmd-stack.c: Update.
8549         * mi/mi-interp.c: Update.
8550         * mi/mi-main.c: Update.
8551         * objc-lang.c: Update.
8552         * p-valprint.c: Update.
8553         * parse.c: Update.
8554         * ppc-linux-tdep.c: Update.
8555         * printcmd.c: Update.
8556         * python/py-arch.c: Update.
8557         * python/py-breakpoint.c: Update.
8558         * python/py-cmd.c: Update.
8559         * python/py-finishbreakpoint.c: Update.
8560         * python/py-frame.c: Update.
8561         * python/py-framefilter.c: Update.
8562         * python/py-gdb-readline.c: Update.
8563         * python/py-inferior.c: Update.
8564         * python/py-infthread.c: Update.
8565         * python/py-lazy-string.c: Update.
8566         * python/py-linetable.c: Update.
8567         * python/py-objfile.c: Update.
8568         * python/py-param.c: Update.
8569         * python/py-prettyprint.c: Update.
8570         * python/py-progspace.c: Update.
8571         * python/py-record-btrace.c: Update.
8572         * python/py-record.c: Update.
8573         * python/py-symbol.c: Update.
8574         * python/py-type.c: Update.
8575         * python/py-unwind.c: Update.
8576         * python/py-utils.c: Update.
8577         * python/py-value.c: Update.
8578         * python/python.c: Update.
8579         * record-btrace.c: Update.
8580         * record-full.c: Update.
8581         * remote-fileio.c: Update.
8582         * remote.c: Update.
8583         * riscv-tdep.c: Update.
8584         * rs6000-aix-tdep.c: Update.
8585         * rs6000-tdep.c: Update.
8586         * rust-exp.y: Update.
8587         * rust-lang.c: Update.
8588         * s390-tdep.c: Update.
8589         * selftest-arch.c: Update.
8590         * solib-dsbt.c: Update.
8591         * solib-frv.c: Update.
8592         * solib-spu.c: Update.
8593         * solib-svr4.c: Update.
8594         * solib.c: Update.
8595         * sparc64-linux-tdep.c: Update.
8596         * stack.c: Update.
8597         * symfile-mem.c: Update.
8598         * symmisc.c: Update.
8599         * target.c: Update.
8600         * thread.c: Update.
8601         * top.c: Update.
8602         * tracefile-tfile.c: Update.
8603         * tui/tui.c: Update.
8604         * typeprint.c: Update.
8605         * unittests/cli-utils-selftests.c: Update.
8606         * unittests/parse-connection-spec-selftests.c: Update.
8607         * valops.c: Update.
8608         * valprint.c: Update.
8609         * value.c: Update.
8610         * varobj.c: Update.
8611         * windows-nat.c: Update.
8612         * x86-linux-nat.c: Update.
8613         * xml-support.c: Update.
8614
8615 2019-04-08  Tom Tromey  <tom@tromey.com>
8616
8617         * xml-support.c: Use C++ exception handling.
8618         * x86-linux-nat.c: Use C++ exception handling.
8619         * windows-nat.c: Use C++ exception handling.
8620         * varobj.c: Use C++ exception handling.
8621         * value.c: Use C++ exception handling.
8622         * valprint.c: Use C++ exception handling.
8623         * valops.c: Use C++ exception handling.
8624         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8625         handling.
8626         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8627         * typeprint.c: Use C++ exception handling.
8628         * tui/tui.c: Use C++ exception handling.
8629         * tracefile-tfile.c: Use C++ exception handling.
8630         * top.c: Use C++ exception handling.
8631         * thread.c: Use C++ exception handling.
8632         * target.c: Use C++ exception handling.
8633         * symmisc.c: Use C++ exception handling.
8634         * symfile-mem.c: Use C++ exception handling.
8635         * stack.c: Use C++ exception handling.
8636         * sparc64-linux-tdep.c: Use C++ exception handling.
8637         * solib.c: Use C++ exception handling.
8638         * solib-svr4.c: Use C++ exception handling.
8639         * solib-spu.c: Use C++ exception handling.
8640         * solib-frv.c: Use C++ exception handling.
8641         * solib-dsbt.c: Use C++ exception handling.
8642         * selftest-arch.c: Use C++ exception handling.
8643         * s390-tdep.c: Use C++ exception handling.
8644         * rust-lang.c: Use C++ exception handling.
8645         * rust-exp.y: Use C++ exception handling.
8646         * rs6000-tdep.c: Use C++ exception handling.
8647         * rs6000-aix-tdep.c: Use C++ exception handling.
8648         * riscv-tdep.c: Use C++ exception handling.
8649         * remote.c: Use C++ exception handling.
8650         * remote-fileio.c: Use C++ exception handling.
8651         * record-full.c: Use C++ exception handling.
8652         * record-btrace.c: Use C++ exception handling.
8653         * python/python.c: Use C++ exception handling.
8654         * python/py-value.c: Use C++ exception handling.
8655         * python/py-utils.c: Use C++ exception handling.
8656         * python/py-unwind.c: Use C++ exception handling.
8657         * python/py-type.c: Use C++ exception handling.
8658         * python/py-symbol.c: Use C++ exception handling.
8659         * python/py-record.c: Use C++ exception handling.
8660         * python/py-record-btrace.c: Use C++ exception handling.
8661         * python/py-progspace.c: Use C++ exception handling.
8662         * python/py-prettyprint.c: Use C++ exception handling.
8663         * python/py-param.c: Use C++ exception handling.
8664         * python/py-objfile.c: Use C++ exception handling.
8665         * python/py-linetable.c: Use C++ exception handling.
8666         * python/py-lazy-string.c: Use C++ exception handling.
8667         * python/py-infthread.c: Use C++ exception handling.
8668         * python/py-inferior.c: Use C++ exception handling.
8669         * python/py-gdb-readline.c: Use C++ exception handling.
8670         * python/py-framefilter.c: Use C++ exception handling.
8671         * python/py-frame.c: Use C++ exception handling.
8672         * python/py-finishbreakpoint.c: Use C++ exception handling.
8673         * python/py-cmd.c: Use C++ exception handling.
8674         * python/py-breakpoint.c: Use C++ exception handling.
8675         * python/py-arch.c: Use C++ exception handling.
8676         * printcmd.c: Use C++ exception handling.
8677         * ppc-linux-tdep.c: Use C++ exception handling.
8678         * parse.c: Use C++ exception handling.
8679         * p-valprint.c: Use C++ exception handling.
8680         * objc-lang.c: Use C++ exception handling.
8681         * mi/mi-main.c: Use C++ exception handling.
8682         * mi/mi-interp.c: Use C++ exception handling.
8683         * mi/mi-cmd-stack.c: Use C++ exception handling.
8684         * mi/mi-cmd-break.c: Use C++ exception handling.
8685         * main.c: Use C++ exception handling.
8686         * linux-thread-db.c: Use C++ exception handling.
8687         * linux-tdep.c: Use C++ exception handling.
8688         * linux-nat.c: Use C++ exception handling.
8689         * linux-fork.c: Use C++ exception handling.
8690         * linespec.c: Use C++ exception handling.
8691         * language.c: Use C++ exception handling.
8692         * jit.c: Use C++ exception handling.
8693         * infrun.c: Use C++ exception handling.
8694         * infcmd.c: Use C++ exception handling.
8695         * infcall.c: Use C++ exception handling.
8696         * inf-loop.c: Use C++ exception handling.
8697         * i386-tdep.c: Use C++ exception handling.
8698         * i386-linux-tdep.c: Use C++ exception handling.
8699         * guile/scm-value.c: Use C++ exception handling.
8700         * guile/scm-type.c: Use C++ exception handling.
8701         * guile/scm-symtab.c: Use C++ exception handling.
8702         * guile/scm-symbol.c: Use C++ exception handling.
8703         * guile/scm-pretty-print.c: Use C++ exception handling.
8704         * guile/scm-ports.c: Use C++ exception handling.
8705         * guile/scm-param.c: Use C++ exception handling.
8706         * guile/scm-math.c: Use C++ exception handling.
8707         * guile/scm-lazy-string.c: Use C++ exception handling.
8708         * guile/scm-frame.c: Use C++ exception handling.
8709         * guile/scm-disasm.c: Use C++ exception handling.
8710         * guile/scm-cmd.c: Use C++ exception handling.
8711         * guile/scm-breakpoint.c: Use C++ exception handling.
8712         * guile/scm-block.c: Use C++ exception handling.
8713         * guile/guile-internal.h: Use C++ exception handling.
8714         * gnu-v3-abi.c: Use C++ exception handling.
8715         * gdbtypes.c: Use C++ exception handling.
8716         * frame.c: Use C++ exception handling.
8717         * frame-unwind.c: Use C++ exception handling.
8718         * fbsd-tdep.c: Use C++ exception handling.
8719         * f-valprint.c: Use C++ exception handling.
8720         * exec.c: Use C++ exception handling.
8721         * event-top.c: Use C++ exception handling.
8722         * event-loop.c: Use C++ exception handling.
8723         * eval.c: Use C++ exception handling.
8724         * dwarf2read.c: Use C++ exception handling.
8725         * dwarf2loc.c: Use C++ exception handling.
8726         * dwarf2-frame.c: Use C++ exception handling.
8727         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8728         * dwarf-index-write.c: Use C++ exception handling.
8729         * dwarf-index-cache.c: Use C++ exception handling.
8730         * dtrace-probe.c: Use C++ exception handling.
8731         * disasm-selftests.c: Use C++ exception handling.
8732         * darwin-nat.c: Use C++ exception handling.
8733         * cp-valprint.c: Use C++ exception handling.
8734         * cp-support.c: Use C++ exception handling.
8735         * cp-abi.c: Use C++ exception handling.
8736         * corelow.c: Use C++ exception handling.
8737         * completer.c: Use C++ exception handling.
8738         * compile/compile-object-run.c: Use C++ exception handling.
8739         * compile/compile-object-load.c: Use C++ exception handling.
8740         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8741         * compile/compile-c-symbols.c: Use C++ exception handling.
8742         * common/selftest.c: Use C++ exception handling.
8743         * common/new-op.c: Use C++ exception handling.
8744         * cli/cli-script.c: Use C++ exception handling.
8745         * cli/cli-interp.c: Use C++ exception handling.
8746         * cli/cli-cmds.c: Use C++ exception handling.
8747         * c-varobj.c: Use C++ exception handling.
8748         * btrace.c: Use C++ exception handling.
8749         * breakpoint.c: Use C++ exception handling.
8750         * break-catch-throw.c: Use C++ exception handling.
8751         * arch-utils.c: Use C++ exception handling.
8752         * amd64-tdep.c: Use C++ exception handling.
8753         * ada-valprint.c: Use C++ exception handling.
8754         * ada-typeprint.c: Use C++ exception handling.
8755         * ada-lang.c: Use C++ exception handling.
8756         * aarch64-tdep.c: Use C++ exception handling.
8757
8758 2019-04-08  Tom Tromey  <tom@tromey.com>
8759
8760         * xml-support.c (gdb_xml_parser::parse): Update.
8761         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8762         * value.c (show_convenience): Update.
8763         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8764         (test_parse_flags_qcs): Update.
8765         * thread.c (thr_try_catch_cmd): Update.
8766         * target.c (target_translate_tls_address): Update.
8767         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8768         (info_frame_command_core, frame_apply_command_count): Update.
8769         * rust-exp.y (rust_lex_exception_test): Update.
8770         * riscv-tdep.c (riscv_print_one_register_info): Update.
8771         * remote.c (remote_target::enable_btrace): Update.
8772         * record-btrace.c (record_btrace_enable_warn): Update.
8773         * python/py-utils.c (gdbpy_convert_exception): Update.
8774         * printcmd.c (do_one_display, print_variable_and_value): Update.
8775         * mi/mi-main.c (mi_print_exception): Update.
8776         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8777         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8778         * linux-nat.c (linux_nat_target::attach): Update.
8779         * linux-fork.c (class scoped_switch_fork_info): Update.
8780         * infrun.c (displaced_step_prepare): Update.
8781         * infcall.c (call_function_by_hand_dummy): Update.
8782         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8783         * gnu-v3-abi.c (print_one_vtable): Update.
8784         * frame.c (get_prev_frame_always): Update.
8785         * f-valprint.c (info_common_command_for_block): Update.
8786         * exec.c (try_open_exec_file): Update.
8787         * exceptions.c (print_exception, exception_print)
8788         (exception_fprintf, exception_print_same): Update.
8789         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8790         * dwarf-index-cache.c (index_cache::store)
8791         (index_cache::lookup_gdb_index): Update.
8792         * darwin-nat.c (maybe_cache_shell): Update.
8793         * cp-valprint.c (cp_print_value_fields): Update.
8794         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8795         (gcc_cplus_symbol_address): Update.
8796         * compile/compile-c-symbols.c (gcc_convert_symbol)
8797         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8798         * common/selftest.c: Update.
8799         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8800         a std::string.
8801         (exception_try_scope_entry, exception_try_scope_exit): Don't
8802         declare.
8803         (struct exception_try_scope): Remove.
8804         (TRY): Don't use exception_try_scope.
8805         (struct gdb_exception): Add constructor, operator=.
8806         <what>: New method.
8807         (struct gdb_exception_RETURN_MASK_ALL)
8808         (struct gdb_exception_RETURN_MASK_ERROR)
8809         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8810         (struct gdb_quit_bad_alloc): Update.
8811         * common/common-exceptions.c (exception_none): Change
8812         initializer.
8813         (struct catcher) <state, exception>: Initialize inline.
8814         <prev>: Remove member.
8815         (current_catcher): Remove.
8816         (catchers): New global.
8817         (exceptions_state_mc_init): Simplify.
8818         (catcher_pop): Remove.
8819         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8820         (try_scope_depth, exception_try_scope_entry)
8821         (exception_try_scope_exit): Remove.
8822         (throw_exception_sjlj): Update.
8823         (exception_messages, exception_messages_size): Remove.
8824         (throw_it): Simplify.
8825         (gdb_exception_sliced_copy): Remove.
8826         (throw_exception_cxx): Update.
8827         * cli/cli-script.c (script_from_file): Update.
8828         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8829         Update.
8830         * ada-valprint.c (ada_val_print): Update.
8831         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8832         (create_excep_cond_exprs): Update.
8833
8834 2019-04-08  Tom Tromey  <tom@tromey.com>
8835
8836         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8837         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8838         (TRY, CATCH, END_CATCH): Remove some definitions.
8839         * common/common-exceptions.c: Don't use GDB_XCPT.
8840         (catcher_list_size): Remove.
8841         (throw_exception, throw_it): Simplify.
8842
8843 2019-04-05  Tom Tromey  <tom@tromey.com>
8844
8845         Revert the header-sorting patch.
8846         * ft32-tdep.c: Revert.
8847         * frv-tdep.c: Revert.
8848         * frv-linux-tdep.c: Revert.
8849         * frame.c: Revert.
8850         * frame-unwind.c: Revert.
8851         * frame-base.c: Revert.
8852         * fork-child.c: Revert.
8853         * findvar.c: Revert.
8854         * findcmd.c: Revert.
8855         * filesystem.c: Revert.
8856         * filename-seen-cache.h: Revert.
8857         * filename-seen-cache.c: Revert.
8858         * fbsd-tdep.c: Revert.
8859         * fbsd-nat.h: Revert.
8860         * fbsd-nat.c: Revert.
8861         * f-valprint.c: Revert.
8862         * f-typeprint.c: Revert.
8863         * f-lang.c: Revert.
8864         * extension.h: Revert.
8865         * extension.c: Revert.
8866         * extension-priv.h: Revert.
8867         * expprint.c: Revert.
8868         * exec.h: Revert.
8869         * exec.c: Revert.
8870         * exceptions.c: Revert.
8871         * event-top.c: Revert.
8872         * event-loop.c: Revert.
8873         * eval.c: Revert.
8874         * elfread.c: Revert.
8875         * dwarf2read.h: Revert.
8876         * dwarf2read.c: Revert.
8877         * dwarf2loc.c: Revert.
8878         * dwarf2expr.h: Revert.
8879         * dwarf2expr.c: Revert.
8880         * dwarf2-frame.c: Revert.
8881         * dwarf2-frame-tailcall.c: Revert.
8882         * dwarf-index-write.h: Revert.
8883         * dwarf-index-write.c: Revert.
8884         * dwarf-index-common.c: Revert.
8885         * dwarf-index-cache.h: Revert.
8886         * dwarf-index-cache.c: Revert.
8887         * dummy-frame.c: Revert.
8888         * dtrace-probe.c: Revert.
8889         * disasm.h: Revert.
8890         * disasm.c: Revert.
8891         * disasm-selftests.c: Revert.
8892         * dictionary.c: Revert.
8893         * dicos-tdep.c: Revert.
8894         * demangle.c: Revert.
8895         * dcache.h: Revert.
8896         * dcache.c: Revert.
8897         * darwin-nat.h: Revert.
8898         * darwin-nat.c: Revert.
8899         * darwin-nat-info.c: Revert.
8900         * d-valprint.c: Revert.
8901         * d-namespace.c: Revert.
8902         * d-lang.c: Revert.
8903         * ctf.c: Revert.
8904         * csky-tdep.c: Revert.
8905         * csky-linux-tdep.c: Revert.
8906         * cris-tdep.c: Revert.
8907         * cris-linux-tdep.c: Revert.
8908         * cp-valprint.c: Revert.
8909         * cp-support.c: Revert.
8910         * cp-namespace.c: Revert.
8911         * cp-abi.c: Revert.
8912         * corelow.c: Revert.
8913         * corefile.c: Revert.
8914         * continuations.c: Revert.
8915         * completer.h: Revert.
8916         * completer.c: Revert.
8917         * complaints.c: Revert.
8918         * coffread.c: Revert.
8919         * coff-pe-read.c: Revert.
8920         * cli-out.h: Revert.
8921         * cli-out.c: Revert.
8922         * charset.c: Revert.
8923         * c-varobj.c: Revert.
8924         * c-valprint.c: Revert.
8925         * c-typeprint.c: Revert.
8926         * c-lang.c: Revert.
8927         * buildsym.c: Revert.
8928         * buildsym-legacy.c: Revert.
8929         * build-id.h: Revert.
8930         * build-id.c: Revert.
8931         * btrace.c: Revert.
8932         * bsd-uthread.c: Revert.
8933         * breakpoint.h: Revert.
8934         * breakpoint.c: Revert.
8935         * break-catch-throw.c: Revert.
8936         * break-catch-syscall.c: Revert.
8937         * break-catch-sig.c: Revert.
8938         * blockframe.c: Revert.
8939         * block.c: Revert.
8940         * bfin-tdep.c: Revert.
8941         * bfin-linux-tdep.c: Revert.
8942         * bfd-target.c: Revert.
8943         * bcache.c: Revert.
8944         * ax-general.c: Revert.
8945         * ax-gdb.h: Revert.
8946         * ax-gdb.c: Revert.
8947         * avr-tdep.c: Revert.
8948         * auxv.c: Revert.
8949         * auto-load.c: Revert.
8950         * arm-wince-tdep.c: Revert.
8951         * arm-tdep.c: Revert.
8952         * arm-symbian-tdep.c: Revert.
8953         * arm-pikeos-tdep.c: Revert.
8954         * arm-obsd-tdep.c: Revert.
8955         * arm-nbsd-tdep.c: Revert.
8956         * arm-nbsd-nat.c: Revert.
8957         * arm-linux-tdep.c: Revert.
8958         * arm-linux-nat.c: Revert.
8959         * arm-fbsd-tdep.c: Revert.
8960         * arm-fbsd-nat.c: Revert.
8961         * arm-bsd-tdep.c: Revert.
8962         * arch-utils.c: Revert.
8963         * arc-tdep.c: Revert.
8964         * arc-newlib-tdep.c: Revert.
8965         * annotate.h: Revert.
8966         * annotate.c: Revert.
8967         * amd64-windows-tdep.c: Revert.
8968         * amd64-windows-nat.c: Revert.
8969         * amd64-tdep.c: Revert.
8970         * amd64-sol2-tdep.c: Revert.
8971         * amd64-obsd-tdep.c: Revert.
8972         * amd64-obsd-nat.c: Revert.
8973         * amd64-nbsd-tdep.c: Revert.
8974         * amd64-nbsd-nat.c: Revert.
8975         * amd64-nat.c: Revert.
8976         * amd64-linux-tdep.c: Revert.
8977         * amd64-linux-nat.c: Revert.
8978         * amd64-fbsd-tdep.c: Revert.
8979         * amd64-fbsd-nat.c: Revert.
8980         * amd64-dicos-tdep.c: Revert.
8981         * amd64-darwin-tdep.c: Revert.
8982         * amd64-bsd-nat.c: Revert.
8983         * alpha-tdep.c: Revert.
8984         * alpha-obsd-tdep.c: Revert.
8985         * alpha-nbsd-tdep.c: Revert.
8986         * alpha-mdebug-tdep.c: Revert.
8987         * alpha-linux-tdep.c: Revert.
8988         * alpha-linux-nat.c: Revert.
8989         * alpha-bsd-tdep.c: Revert.
8990         * alpha-bsd-nat.c: Revert.
8991         * aix-thread.c: Revert.
8992         * agent.c: Revert.
8993         * addrmap.c: Revert.
8994         * ada-varobj.c: Revert.
8995         * ada-valprint.c: Revert.
8996         * ada-typeprint.c: Revert.
8997         * ada-tasks.c: Revert.
8998         * ada-lang.c: Revert.
8999         * aarch64-tdep.c: Revert.
9000         * aarch64-ravenscar-thread.c: Revert.
9001         * aarch64-newlib-tdep.c: Revert.
9002         * aarch64-linux-tdep.c: Revert.
9003         * aarch64-linux-nat.c: Revert.
9004         * aarch64-fbsd-tdep.c: Revert.
9005         * aarch64-fbsd-nat.c: Revert.
9006         * aarch32-linux-nat.c: Revert.
9007
9008 2019-04-05  Tom Tromey  <tom@tromey.com>
9009
9010         * ft32-tdep.c: Sort headers.
9011         * frv-tdep.c: Sort headers.
9012         * frv-linux-tdep.c: Sort headers.
9013         * frame.c: Sort headers.
9014         * frame-unwind.c: Sort headers.
9015         * frame-base.c: Sort headers.
9016         * fork-child.c: Sort headers.
9017         * findvar.c: Sort headers.
9018         * findcmd.c: Sort headers.
9019         * filesystem.c: Sort headers.
9020         * filename-seen-cache.h: Sort headers.
9021         * filename-seen-cache.c: Sort headers.
9022         * fbsd-tdep.c: Sort headers.
9023         * fbsd-nat.h: Sort headers.
9024         * fbsd-nat.c: Sort headers.
9025         * f-valprint.c: Sort headers.
9026         * f-typeprint.c: Sort headers.
9027         * f-lang.c: Sort headers.
9028         * extension.h: Sort headers.
9029         * extension.c: Sort headers.
9030         * extension-priv.h: Sort headers.
9031         * expprint.c: Sort headers.
9032         * exec.h: Sort headers.
9033         * exec.c: Sort headers.
9034         * exceptions.c: Sort headers.
9035         * event-top.c: Sort headers.
9036         * event-loop.c: Sort headers.
9037         * eval.c: Sort headers.
9038         * elfread.c: Sort headers.
9039         * dwarf2read.h: Sort headers.
9040         * dwarf2read.c: Sort headers.
9041         * dwarf2loc.c: Sort headers.
9042         * dwarf2expr.h: Sort headers.
9043         * dwarf2expr.c: Sort headers.
9044         * dwarf2-frame.c: Sort headers.
9045         * dwarf2-frame-tailcall.c: Sort headers.
9046         * dwarf-index-write.h: Sort headers.
9047         * dwarf-index-write.c: Sort headers.
9048         * dwarf-index-common.c: Sort headers.
9049         * dwarf-index-cache.h: Sort headers.
9050         * dwarf-index-cache.c: Sort headers.
9051         * dummy-frame.c: Sort headers.
9052         * dtrace-probe.c: Sort headers.
9053         * disasm.h: Sort headers.
9054         * disasm.c: Sort headers.
9055         * disasm-selftests.c: Sort headers.
9056         * dictionary.c: Sort headers.
9057         * dicos-tdep.c: Sort headers.
9058         * demangle.c: Sort headers.
9059         * dcache.h: Sort headers.
9060         * dcache.c: Sort headers.
9061         * darwin-nat.h: Sort headers.
9062         * darwin-nat.c: Sort headers.
9063         * darwin-nat-info.c: Sort headers.
9064         * d-valprint.c: Sort headers.
9065         * d-namespace.c: Sort headers.
9066         * d-lang.c: Sort headers.
9067         * ctf.c: Sort headers.
9068         * csky-tdep.c: Sort headers.
9069         * csky-linux-tdep.c: Sort headers.
9070         * cris-tdep.c: Sort headers.
9071         * cris-linux-tdep.c: Sort headers.
9072         * cp-valprint.c: Sort headers.
9073         * cp-support.c: Sort headers.
9074         * cp-namespace.c: Sort headers.
9075         * cp-abi.c: Sort headers.
9076         * corelow.c: Sort headers.
9077         * corefile.c: Sort headers.
9078         * continuations.c: Sort headers.
9079         * completer.h: Sort headers.
9080         * completer.c: Sort headers.
9081         * complaints.c: Sort headers.
9082         * coffread.c: Sort headers.
9083         * coff-pe-read.c: Sort headers.
9084         * cli-out.h: Sort headers.
9085         * cli-out.c: Sort headers.
9086         * charset.c: Sort headers.
9087         * c-varobj.c: Sort headers.
9088         * c-valprint.c: Sort headers.
9089         * c-typeprint.c: Sort headers.
9090         * c-lang.c: Sort headers.
9091         * buildsym.c: Sort headers.
9092         * buildsym-legacy.c: Sort headers.
9093         * build-id.h: Sort headers.
9094         * build-id.c: Sort headers.
9095         * btrace.c: Sort headers.
9096         * bsd-uthread.c: Sort headers.
9097         * breakpoint.h: Sort headers.
9098         * breakpoint.c: Sort headers.
9099         * break-catch-throw.c: Sort headers.
9100         * break-catch-syscall.c: Sort headers.
9101         * break-catch-sig.c: Sort headers.
9102         * blockframe.c: Sort headers.
9103         * block.c: Sort headers.
9104         * bfin-tdep.c: Sort headers.
9105         * bfin-linux-tdep.c: Sort headers.
9106         * bfd-target.c: Sort headers.
9107         * bcache.c: Sort headers.
9108         * ax-general.c: Sort headers.
9109         * ax-gdb.h: Sort headers.
9110         * ax-gdb.c: Sort headers.
9111         * avr-tdep.c: Sort headers.
9112         * auxv.c: Sort headers.
9113         * auto-load.c: Sort headers.
9114         * arm-wince-tdep.c: Sort headers.
9115         * arm-tdep.c: Sort headers.
9116         * arm-symbian-tdep.c: Sort headers.
9117         * arm-pikeos-tdep.c: Sort headers.
9118         * arm-obsd-tdep.c: Sort headers.
9119         * arm-nbsd-tdep.c: Sort headers.
9120         * arm-nbsd-nat.c: Sort headers.
9121         * arm-linux-tdep.c: Sort headers.
9122         * arm-linux-nat.c: Sort headers.
9123         * arm-fbsd-tdep.c: Sort headers.
9124         * arm-fbsd-nat.c: Sort headers.
9125         * arm-bsd-tdep.c: Sort headers.
9126         * arch-utils.c: Sort headers.
9127         * arc-tdep.c: Sort headers.
9128         * arc-newlib-tdep.c: Sort headers.
9129         * annotate.h: Sort headers.
9130         * annotate.c: Sort headers.
9131         * amd64-windows-tdep.c: Sort headers.
9132         * amd64-windows-nat.c: Sort headers.
9133         * amd64-tdep.c: Sort headers.
9134         * amd64-sol2-tdep.c: Sort headers.
9135         * amd64-obsd-tdep.c: Sort headers.
9136         * amd64-obsd-nat.c: Sort headers.
9137         * amd64-nbsd-tdep.c: Sort headers.
9138         * amd64-nbsd-nat.c: Sort headers.
9139         * amd64-nat.c: Sort headers.
9140         * amd64-linux-tdep.c: Sort headers.
9141         * amd64-linux-nat.c: Sort headers.
9142         * amd64-fbsd-tdep.c: Sort headers.
9143         * amd64-fbsd-nat.c: Sort headers.
9144         * amd64-dicos-tdep.c: Sort headers.
9145         * amd64-darwin-tdep.c: Sort headers.
9146         * amd64-bsd-nat.c: Sort headers.
9147         * alpha-tdep.c: Sort headers.
9148         * alpha-obsd-tdep.c: Sort headers.
9149         * alpha-nbsd-tdep.c: Sort headers.
9150         * alpha-mdebug-tdep.c: Sort headers.
9151         * alpha-linux-tdep.c: Sort headers.
9152         * alpha-linux-nat.c: Sort headers.
9153         * alpha-bsd-tdep.c: Sort headers.
9154         * alpha-bsd-nat.c: Sort headers.
9155         * aix-thread.c: Sort headers.
9156         * agent.c: Sort headers.
9157         * addrmap.c: Sort headers.
9158         * ada-varobj.c: Sort headers.
9159         * ada-valprint.c: Sort headers.
9160         * ada-typeprint.c: Sort headers.
9161         * ada-tasks.c: Sort headers.
9162         * ada-lang.c: Sort headers.
9163         * aarch64-tdep.c: Sort headers.
9164         * aarch64-ravenscar-thread.c: Sort headers.
9165         * aarch64-newlib-tdep.c: Sort headers.
9166         * aarch64-linux-tdep.c: Sort headers.
9167         * aarch64-linux-nat.c: Sort headers.
9168         * aarch64-fbsd-tdep.c: Sort headers.
9169         * aarch64-fbsd-nat.c: Sort headers.
9170         * aarch32-linux-nat.c: Sort headers.
9171
9172 2019-04-04  Tom Tromey  <tom@tromey.com>
9173
9174         * varobj.c (varobj_create): Update.
9175         * rust-exp.y (struct rust_parser) <update_innermost_block,
9176         lookup_symbol>: New methods.
9177         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9178         Rename.
9179         (rust_parser::rust_lookup_type)
9180         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9181         * printcmd.c (display_command, do_one_display): Update.
9182         * parser-defs.h (struct parser_state) <parser_state>: Add
9183         "tracker" parameter.
9184         (block_tracker): New member.
9185         (class innermost_block_tracker) <innermost_block_tracker>: Add
9186         "types" parameter.
9187         <reset>: Remove method.
9188         (innermost_block): Don't declare.
9189         (null_post_parser): Update.
9190         * parse.c (innermost_block): Remove global.
9191         (write_dollar_variable): Update.
9192         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9193         Remove "tracker_types" parameter.
9194         (parse_expression): Add "tracker" parameter.
9195         (parse_expression_for_completion): Update.
9196         (null_post_parser): Add "tracker" parameter.
9197         * p-exp.y: Update rules.
9198         * m2-exp.y: Update rules.
9199         * language.h (struct language_defn) <la_post_parser>: Add
9200         "tracker" parameter.
9201         * go-exp.y: Update rules.
9202         * f-exp.y: Update rules.
9203         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9204         parameter.
9205         * d-exp.y: Update rules.
9206         * c-exp.y: Update rules.
9207         * breakpoint.c (set_breakpoint_condition): Create an
9208         innermost_block_tracker.
9209         (watch_command_1): Likewise.
9210         * ada-lang.c (resolve): Add "tracker" parameter.
9211         (resolve_subexp): Likewise.
9212         * ada-exp.y (write_var_from_sym): Update.
9213
9214 2019-04-04  Tom Tromey  <tom@tromey.com>
9215
9216         * type-stack.h: New file.
9217         * type-stack.c: New file.
9218         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9219         type-stack.h.
9220         (insert_into_type_stack, insert_type, push_type, push_type_int)
9221         (insert_type_address_space, pop_type, pop_type_int)
9222         (pop_typelist, pop_type_stack, append_type_stack)
9223         (push_type_stack, get_type_stack, push_typelist)
9224         (follow_type_instance_flags, follow_types): Don't declare.
9225         * parse.c (type_stack): Remove global.
9226         (parse_exp_in_context): Update.
9227         (insert_into_type_stack, insert_type, push_type, push_type_int)
9228         (insert_type_address_space, pop_type, pop_type_int)
9229         (pop_typelist, pop_type_stack, append_type_stack)
9230         (push_type_stack, get_type_stack, push_typelist)
9231         (follow_type_instance_flags, follow_types): Remove (moved to
9232         type-stack.c).
9233         * f-exp.y (type_stack): New global.
9234         Update rules.
9235         (push_kind_type, f_parse): Update.
9236         * d-exp.y (type_stack): New global.
9237         Update rules.
9238         (d_parse): Update.
9239         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9240         Update rules.
9241         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9242         (HFILES_NO_SRCDIR): Add type-stack.h.
9243
9244 2019-04-04  Tom Tromey  <tom@tromey.com>
9245
9246         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9247         (rust_parser::convert_ast_to_expression, rust_parse)
9248         (rust_lex_test_completion, rust_lex_tests): Update.
9249         * parser-defs.h (struct expr_completion_state): New.
9250         (struct parser_state) <parser_state>: Add completion parameter.
9251         <mark_struct_expression, mark_completion_tag>: New methods.
9252         <parse_completion, m_completion_state>: New members.
9253         (prefixify_expression, null_post_parser): Update.
9254         (mark_struct_expression, mark_completion_tag): Don't declare.
9255         * parse.c (parse_completion, expout_last_struct)
9256         (expout_tag_completion_type, expout_completion_name): Remove
9257         globals.
9258         (parser_state::mark_struct_expression)
9259         (parser_state::mark_completion_tag): Now methods.
9260         (prefixify_expression): Add last_struct parameter.
9261         (prefixify_subexp): Likewise.
9262         (parse_exp_1): Update.
9263         (parse_exp_in_context): Add cstate parameter.  Update.
9264         (parse_expression_for_completion): Create an
9265         expr_completion_state.
9266         (null_post_parser): Add "completion" parameter.
9267         * p-exp.y: Update rules.
9268         (yylex): Update.
9269         * language.h (struct language_defn) <la_post_parser>: Add
9270         "completing" parameter.
9271         * go-exp.y: Update rules.
9272         (lex_one_token): Update.
9273         * expression.h (parse_completion): Don't declare.
9274         * d-exp.y: Update rules.
9275         (lex_one_token): Update rules.
9276         * c-exp.y: Update rules.
9277         (lex_one_token): Update.
9278         * ada-lang.c (resolve): Add "parse_completion" parameter.
9279         (resolve_subexp): Likewise.
9280         (ada_resolve_function): Likewise.
9281
9282 2019-04-04  Tom Tromey  <tom@tromey.com>
9283
9284         * parser-defs.h (struct parser_state) <start_arglist,
9285         end_arglist>: New methods.
9286         <arglist_len, m_funcall_chain>: New members.
9287         (arglist_len, start_arglist, end_arglist): Don't declare.
9288         * parse.c (arglist_len, funcall_chain): Remove global.
9289         (start_arglist, end_arglist): Remove functions.
9290         (parse_exp_in_context): Update.
9291         * p-exp.y: Update rules.
9292         * m2-exp.y: Update rules.
9293         * go-exp.y: Update rules.
9294         * f-exp.y: Update rules.
9295         * d-exp.y: Update rules.
9296         * c-exp.y: Update rules.
9297
9298 2019-04-04  Tom Tromey  <tom@tromey.com>
9299
9300         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9301         lex_operator, push_back>: New methods.
9302         Update all rules.
9303         (rust_parser::lex_hex, lex_escape): Rename and update.
9304         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9305         (rust_parser::lex_operator): Rename and update.
9306         (rust_parser::lex_number, rustyylex, rustyyerror)
9307         (rust_lex_test_init, rust_lex_test_sequence)
9308         (rust_lex_test_push_back, rust_lex_tests): Update.
9309         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9310         parameter.
9311         <lexptr, prev_lexptr>: New members.
9312         (lexptr, prev_lexptr): Don't declare.
9313         * parse.c (lexptr, prev_lexptr): Remove globals.
9314         (parse_exp_in_context): Update.
9315         * p-exp.y (yylex, yyerror): Update.
9316         * m2-exp.y (parse_number, yylex, yyerror): Update.
9317         * go-exp.y (lex_one_token, yyerror): Update.
9318         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9319         * d-exp.y (lex_one_token, yyerror): Update.
9320         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9321         (lex_one_token, yyerror): Update.
9322         * ada-lex.l (YY_INPUT): Update.
9323         (rewind_to_char): Update.
9324         * ada-exp.y (yyerror): Update.
9325
9326 2019-04-04  Tom Tromey  <tom@tromey.com>
9327
9328         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9329         * parser-defs.h (struct parser_state) <parser_state>: Add new
9330         parameter.
9331         <comma_terminates>: New member.
9332         (comma_terminates): Don't declare global.
9333         * parse.c (comma_terminates): Remove global.
9334         (parse_exp_in_context): Update.
9335         * p-exp.y (yylex): Update.
9336         * m2-exp.y (yylex): Update.
9337         * go-exp.y (lex_one_token): Update.
9338         * f-exp.y (yylex): Update.
9339         * d-exp.y (lex_one_token): Update.
9340         * c-exp.y (lex_one_token): Update.
9341         * ada-lex.l: Update.
9342
9343 2019-04-04  Tom Tromey  <tom@tromey.com>
9344
9345         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9346         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9347         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9348         * parser-defs.h (paren_depth): Don't declare.
9349         * parse.c (paren_depth): Remove global.
9350         (parse_exp_in_context): Update.
9351         * p-exp.y (paren_depth): New global.
9352         (pascal_parse): Initialize it.
9353         * m2-exp.y (paren_depth): New global.
9354         (m2_parse): Initialize it.
9355         * go-exp.y (paren_depth): New global.
9356         (go_parse): Initialize it.
9357         * f-exp.y (paren_depth): New global.
9358         (f_parse): Initialize it.
9359         * d-exp.y (paren_depth): New global.
9360         (d_parse): Initialize it.
9361         * c-exp.y (paren_depth): New global.
9362         (c_parse): Initialize it.
9363         * ada-lex.l (paren_depth): New global.
9364         (lexer_init): Initialize it.
9365
9366 2019-04-04  Tom Tromey  <tom@tromey.com>
9367
9368         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9369         (rust_parser::convert_ast_to_type)
9370         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9371         * parser-defs.h (struct parser_state) <parser_state>: Add
9372         parameters.  Initialize new members.
9373         <expression_context_block, expression_context_pc>: New members.
9374         * parse.c (expression_context_block, expression_context_pc):
9375         Remove globals.
9376         (parse_exp_in_context): Update.
9377         * p-exp.y: Update all rules.
9378         (yylex): Update.
9379         * m2-exp.y: Update all rules.
9380         (yylex): Update.
9381         * go-exp.y (yylex): Update.
9382         * f-exp.y (yylex): Update.
9383         * d-exp.y: Update all rules.
9384         (yylex): Update.
9385         * c-exp.y: Update all rules.
9386         (lex_one_token, classify_name, yylex, c_parse): Update.
9387         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9388
9389 2019-04-04  Tom Tromey  <tom@tromey.com>
9390
9391         * gdbarch.h, gdbarch.c: Rebuild.
9392         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9393         * stap-probe.h:
9394         (struct stap_parse_info): Replace "parser_state" with
9395         "expr_builder".
9396         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9397         (parser_state): New class.
9398         * parse.c (expr_builder): Rename.
9399         (expr_builder::release): Rename.
9400         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9401         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9402         (write_exp_elt_longcst, write_exp_elt_floatcst)
9403         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9404         (write_exp_string_vector, write_exp_bitstring)
9405         (write_exp_msymbol, mark_struct_expression)
9406         (write_dollar_variable)
9407         (insert_type_address_space, increase_expout_size): Replace
9408         "parser_state" with "expr_builder".
9409         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9410         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9411         "parser_state" with "expr_builder".
9412
9413 2019-04-04  Tom Tromey  <tom@tromey.com>
9414
9415         * rust-exp.y: Replace "parse_language" with method call.
9416         * p-exp.y:
9417         (yylex): Replace "parse_language" with method call.
9418         * m2-exp.y:
9419         (yylex): Replace "parse_language" with method call.
9420         * go-exp.y (classify_name): Replace "parse_language" with method
9421         call.
9422         * f-exp.y (yylex): Replace "parse_language" with method call.
9423         * d-exp.y (lex_one_token): Replace "parse_language" with method
9424         call.
9425         * c-exp.y:
9426         (lex_one_token, classify_name, yylex): Replace "parse_language"
9427         with method call.
9428         * ada-exp.y (find_primitive_type, type_char)
9429         (type_system_address): Replace "parse_language" with method call.
9430
9431 2019-04-04  Tom Tromey  <tom@tromey.com>
9432
9433         * rust-exp.y: Replace "parse_gdbarch" with method call.
9434         * parse.c (write_dollar_variable, insert_type_address_space):
9435         Replace "parse_gdbarch" with method call.
9436         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9437         call.
9438         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9439         call.
9440         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9441         "parse_gdbarch" with method call.
9442         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9443         with method call.
9444         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9445         "parse_gdbarch" with method call.
9446         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9447         "parse_gdbarch" with method call.
9448         * c-exp.y (parse_type, parse_number, classify_name): Replace
9449         "parse_gdbarch" with method call.
9450         * ada-lex.l: Replace "parse_gdbarch" with method call.
9451         * ada-exp.y (parse_type, find_primitive_type, type_char)
9452         (type_system_address): Replace "parse_gdbarch" with method call.
9453
9454 2019-04-04  Tom Tromey  <tom@tromey.com>
9455
9456         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9457         * stap-probe.c (stap_parse_argument): Update.
9458         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9459         initial_size parameter.
9460         * rust-exp.y (rust_lex_tests): Update.
9461         * parse.c (parser_state): Update.
9462         (parse_exp_in_context): Update.
9463         * parser-defs.h (struct parser_state) <parser_state>: Remove
9464         "initial_size" parameter.
9465
9466 2019-04-04  Tom Tromey  <tom@tromey.com>
9467
9468         * parser-defs.h (increase_expout_size): Don't declare.
9469         * parse.c (increase_expout_size): Now static.
9470
9471 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9472
9473         * gnu-nat.c (gnu_nat_target::wait): Fix
9474         target_waitstatus_to_string call.
9475
9476 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9477
9478         * eval.c (evaluate_subexp_standard): Handle internal functions
9479         during Fortran function call handling.
9480
9481 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9482
9483         * NEWS: Mention new internal functions.
9484         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9485         (read_base_type): Use dwarf2_init_complex_target_type.
9486         * value.c (creal_internal_fn): New function.
9487         (cimag_internal_fn): New function.
9488         (_initialize_values): Register new internal functions.
9489
9490 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9491
9492         * infrun.c (stop_all_threads): If debug_infrun, always
9493         trace the wait status after wait_one, using
9494         target_waitstatus_to_string and target_pid_to_str.
9495         (handle_inferior_event): Replace various trace of
9496         wait status kind by a single trace.
9497         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9498         wait status kind image by target_waitstatus_to_string.
9499         * target/waitstatus.c (target_waitstatus_to_string): Fix
9500         obsolete comment.
9501
9502 2019-04-01  Tom Tromey  <tromey@adacore.com>
9503
9504         PR symtab/23331:
9505         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9506
9507 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9508             Pedro Alves  <palves@redhat.com>
9509
9510         * top.c (quit_force): Call 'finalize_values'.
9511         * value.c (finalize_values): New function.
9512         * value.h (finalize_values): Declare.
9513
9514 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9515
9516         * NEWS: Announce $_gdb_major and $_gdb_minor.
9517
9518         * top.c (init_gdb_version_vars): New function.
9519         (gdb_init): Call init_gdb_version_vars.
9520
9521 2019-03-29  Tom Tromey  <tromey@adacore.com>
9522
9523         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9524         help text.  Remove dead code.
9525
9526 2019-03-29  Keith Seitz  <keiths@redhat.com>
9527
9528         From Siddhesh Poyarekar:
9529         * f-lang.h (f77_get_upperbound): Return LONGEST.
9530         (f77_get_lowerbound): Likewise.
9531         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9532         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9533         print them.
9534         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9535         plongest to format print it.
9536         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9537         (f77_get_upperbound): Likewise.
9538         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9539         LOWER_BOUND to LONGEST.
9540         (f77_create_arrayprint_offset_tbl): Likewise.
9541
9542 2019-03-29  Keith Seitz  <keiths@redhat.com>
9543
9544         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9545         %s/pulongest for TYPE_LENGTH instead of %d in format
9546         strings.
9547         * ada-typerint.c (ada_print_type): Likewise.
9548         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9549         * compile/compile-c-support.c (generate_register_struct): Likewise.
9550         * gdbtypes.c (recursive_dump_type): Likewise.
9551         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9552         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9553         instead of %d in format strings.
9554         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9555         to std::min to ULONGEST.
9556         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9557         instead of %d in format strings.
9558         * tracepoint.c (info_scope_command): Likewise.
9559         * typeprint.c (print_offset_data::update)
9560         (print_offset_data::finish): Likewise.
9561         * xtensa-tdep.c (xtensa_store_return_value)
9562         (xtensa_push_dummy_call): Likewise.
9563
9564 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9565
9566         * windows-nat.c (display_selector): Fixed format specifications
9567         for 64-bit Cygwin.
9568
9569 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9570
9571         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9572
9573 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9574
9575         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9576         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9577         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9578         (nios2_linux_init_abi): Install it.
9579
9580 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9581
9582         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9583
9584 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9585
9586         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9587
9588 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9589             Tom Tromey  <tromey@adacore.com>
9590
9591         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9592
9593 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9594
9595         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9596         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9597         method to compute the bounds of range types. Also print "[evaluated]"
9598         if the bounds' values come from a dynamic evaluation.
9599
9600 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9601
9602         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9603         whitespace when pretty printing is on.
9604
9605 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9606
9607         * ppc-linux-nat.c: Add include.
9608
9609 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9610
9611         * NEWS: Mention AArch64 Pointer Authentication.
9612
9613 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9614
9615         * arm-linux-nat.c: Add include.
9616
9617 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9618
9619         * source-cache.c (source_cache::get_source_lines): Re-read
9620         fullname after calling open_source_file.
9621
9622 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9623
9624         * NEWS: Mention TLS support for FreeBSD.
9625
9626 2019-03-25  Tom Tromey  <tromey@adacore.com>
9627
9628         * minsyms.c (BUNCH_SIZE): Update comment.
9629         (~minimal_symbol_reader): Remove old comment.
9630         (compact_minimal_symbols): Update comment.
9631         (minimal_symbol_reader::install): Remove old comment.  Update
9632         other comments.
9633
9634 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9635
9636         * s390-linux-nat.c: Add include.
9637
9638 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9639
9640         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9641         Call linux_get_hwcap.
9642         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9643         Likewise.
9644         (aarch64_linux_get_hwcap): Remove function.
9645         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9646         declaration.
9647         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9648         linux_get_hwcap.
9649         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9650         * linux-tdep.c (linux_get_hwcap): Add function.
9651         (linux_get_hwcap2): Likewise.
9652         * linux-tdep.h (linux_get_hwcap): Add declaration.
9653         (linux_get_hwcap2): Likewise.
9654         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9655         (ppc_linux_get_hwcap2): Likewise.
9656         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9657         linux_get_hwcap.
9658         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9659         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9660         (ppc_linux_nat_target::read_description): Likewise.
9661         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9662         * s390-linux-nat.c: Likewise.
9663         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9664
9665 2019-03-24  Tom Tromey  <tom@tromey.com>
9666
9667         * ada-lang.c (standard_lookup): Simplify initialization.
9668         (ada_lookup_symbol_nonlocal): Simplify return.
9669         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9670         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9671         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9672         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9673         initialization.
9674         * solib.c (solib_global_lookup): Simplify.
9675         * symtab.c (null_block_symbol): Remove.
9676         (symbol_cache_lookup): Simplify returns.
9677         (lookup_language_this): Simplify returns.
9678         (lookup_symbol_aux): Simplify return.
9679         (lookup_local_symbol): Simplify returns.
9680         (lookup_global_symbol_from_objfile): Simplify return.
9681         (lookup_symbol_in_objfile_symtabs)
9682         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9683         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9684         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9685         * cp-namespace.c (cp_lookup_bare_symbol)
9686         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9687         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9688         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9689         (cp_lookup_symbol_via_imports): Simplify initialization.
9690         (find_symbol_in_baseclass): Likewise.
9691         * symtab.h (null_block_symbol): Remove.
9692         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9693         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9694         (d_lookup_symbol_module): Likewise.
9695         (find_symbol_in_baseclass): Simplify initialization.
9696
9697 2019-03-24  Tom Tromey  <tom@tromey.com>
9698
9699         * expression.h: Don't include symtab.h.
9700         (struct block): Forward declare.
9701
9702 2019-03-24  Tom Tromey  <tom@tromey.com>
9703
9704         * c-exp.y (typebase): Remove casts.
9705         * gdbtypes.c (lookup_unsigned_typename, )
9706         (lookup_signed_typename): Remove cast.
9707         * eval.c (parse_to_comma_and_eval): Remove cast.
9708         * parse.c (write_dollar_variable): Remove cast.
9709         * block.h (struct block) <superblock>: Now const.
9710         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9711         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9712         (map_block): Make "block" const.
9713         * symfile.h (struct quick_symbol_functions)
9714         <map_matching_symbols>: Constify block argument to "callback".
9715         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9716         const.
9717         (find_pc_sect_compunit_symtab): Make "b" const.
9718         (find_symbol_at_address): Likewise.
9719         (search_symbols): Likewise.
9720         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9721         (dw2_debug_names_lookup_symbol): Likewise.
9722         (dw2_map_matching_symbols): Update.
9723         * p-valprint.c (pascal_val_print): Remove "block".
9724         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9725         (aux_add_nonlocal_symbols): Make "block" const.
9726         (resolve_subexp): Remove cast.
9727         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9728         const.
9729         (iterate_over_file_blocks): Likewise.
9730         * f-exp.y (%union) <bval>: Remove.
9731         * coffread.c (patch_opaque_types): Make "b" const.
9732         * spu-tdep.c (spu_catch_start): Make "block" const.
9733         * c-valprint.c (print_unpacked_pointer): Remove "block".
9734         * symmisc.c (dump_symtab_1): Make "b" const.
9735         (block_depth): Make "block" const.
9736         * d-exp.y (%union) <bval>: Remove.
9737         * cp-support.h (cp_lookup_rtti_type): Update.
9738         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9739         * psymtab.c (psym_lookup_symbol): Make "block" const.
9740         (maintenance_check_psymtabs): Make "b" const.
9741         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9742         (enumerate_locals, enumerate_args): Update.
9743         * python/py-symtab.c (stpy_global_block): Make "block" const.
9744         (stpy_static_block): Likewise.
9745         * inline-frame.c (block_starting_point_at): Make "new_block"
9746         const.
9747         * block.c (find_block_in_blockvector): Make return type const.
9748         (blockvector_for_pc_sect): Make "b" const.
9749         (find_block_in_blockvector): Make "b" const.
9750
9751 2019-03-23  Tom Tromey  <tom@tromey.com>
9752
9753         * varobj.c (varobj_create): Update.
9754         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9755         * printcmd.c (display_command, do_one_display): Don't reset
9756         innermost_block.
9757         * parser-defs.h (enum innermost_block_tracker_type): Move to
9758         expression.h.
9759         (innermost_block): Update comment.
9760         * parse.c (parse_exp_1): Add tracker_types parameter.
9761         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9762         tracker_types parameter.  Reset innermost_block.
9763         (parse_exp_in_context): Remove.
9764         (parse_expression_for_completion): Update.
9765         * objfiles.c (~objfile): Don't reset expression_context_block or
9766         innermost_block.
9767         * expression.h (enum innermost_block_tracker_type): Move from
9768         parser-defs.h.
9769         (parse_exp_1): Add tracker_types parameter.
9770         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9771         reset innermost_block.
9772
9773 2019-03-23  Tom Tromey  <tom@tromey.com>
9774
9775         * objfiles.h: Include bcache.h.
9776
9777 2019-03-23  Tom Tromey  <tom@tromey.com>
9778
9779         * linespec.c (get_current_search_block): Use
9780         scoped_restore_current_language.
9781         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9782
9783 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9784             Jiong Wang  <jiong.wang@arm.com>
9785
9786         * aarch64-linux-tdep.c
9787         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9788         section.
9789         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9790
9791 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9792             Jiong Wang  <jiong.wang@arm.com>
9793
9794         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9795         instructions.
9796         (aarch64_analyze_prologue_test): Add PACIASP test.
9797         (aarch64_prologue_prev_register): Unmask PC value.
9798
9799 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9800             Jiong Wang  <jiong.wang@arm.com>
9801
9802         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9803         (aarch64_dwarf2_prev_register): Unmask PC value.
9804         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9805         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9806         DW_CFA_AARCH64_negate_ra_state.
9807         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9808
9809 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9810             Jiong Wang  <jiong.wang@arm.com>
9811
9812         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9813         registers.
9814         (aarch64_pseudo_register_name): Likewise.
9815         (aarch64_pseudo_register_type): Likewise.
9816         (aarch64_pseudo_register_reggroup_p): Likewise.
9817         (aarch64_gdbarch_init): Add pauth registers.
9818         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9819         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9820         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9821         (struct gdbarch_tdep): Add regnum for ra_state.
9822
9823 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9824             Jiong Wang  <jiong.wang@arm.com>
9825
9826         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9827
9828 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9829             Jiong Wang  <jiong.wang@arm.com>
9830
9831         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9832         function.
9833         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9834         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9835         (aarch64_gdbarch_init): Add puth registers.
9836         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9837         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9838         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9839
9840 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9841             Jiong Wang  <jiong.wang@arm.com>
9842
9843         * aarch64-linux-nat.c
9844         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9845         * aarch64-linux-tdep.c
9846         (aarch64_linux_core_read_description): Likewise.
9847         (aarch64_linux_get_hwcap): New function.
9848         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9849         (aarch64_linux_get_hwcap): New declaration.
9850
9851 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9852             Jiong Wang  <jiong.wang@arm.com>
9853
9854         * aarch64-linux-nat.c
9855         (aarch64_linux_nat_target::read_description): Add pauth param.
9856         * aarch64-linux-tdep.c
9857         (aarch64_linux_core_read_description): Likewise.
9858         * aarch64-tdep.c (struct target_desc): Add in pauth.
9859         (aarch64_read_description): Add pauth param.
9860         (aarch64_gdbarch_init): Likewise.
9861         * aarch64-tdep.h (aarch64_read_description): Likewise.
9862         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9863         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9864         * features/Makefile: Add new files.
9865         * features/aarch64-pauth.c: New file.
9866         * features/aarch64-pauth.xml: New file.
9867
9868 2019-03-20  Tom Tromey  <tromey@adacore.com>
9869
9870         * infrun.c (handle_inferior_event): Rename from
9871         handle_inferior_event_1.  Create a scoped_value_mark.
9872         (handle_inferior_event): Remove.
9873
9874 2019-03-19  Tom Tromey  <tromey@adacore.com>
9875
9876         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9877         * infrun.h (print_stop_event): Add "displays" parameter.
9878         * infrun.c (print_stop_event): Add "displays" parameter.
9879
9880 2019-03-19  Pedro Alves  <palves@redhat.com>
9881
9882         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9883         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9884         to -1.  Fix TABs vs spaces.
9885         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9886         * tui/tui-out.h (tui_ui_out) Add intro comments.
9887         <m_line, m_start_of_line>: In-class initialize, and add describing
9888         comment.
9889
9890 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9891
9892         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9893         variable names.
9894         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9895
9896 2019-03-18  Pedro Alves  <palves@redhat.com>
9897             Eli Zaretskii <eliz@gnu.org>
9898
9899         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9900         m_line and m_start_of_line.
9901
9902 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9903
9904         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9905         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9906         it returns a newline.  This fixes a regression in TU mode, whereby
9907         the next line is output on the same screen line as the user input.
9908
9909 2019-03-18  Tom Tromey  <tromey@adacore.com>
9910
9911         * minsyms.c (minimal_symbol_reader::install): Remove call to
9912         obstack_blank.
9913
9914 2019-03-18  Pedro Alves  <palves@redhat.com>
9915
9916         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9917         New globals.
9918         (apply_style): New, factored out from ...
9919         (apply_ansi_escape): ... this.  Handle reverse video mode.
9920         (tui_set_reverse_mode): New function.
9921         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9922         * tui/tui-winsource.c (tui_show_source_line): Use
9923         tui_set_reverse_mode instead of setting A_STANDOUT.
9924         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9925         New setter methods.
9926
9927 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9928
9929         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9930         Handle tabs.
9931
9932 2019-03-18  Tom Tromey  <tromey@adacore.com>
9933
9934         * ada-lang.c (empty_array): Add "high" parameter.
9935         (ada_evaluate_subexp): Update.
9936
9937 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9938
9939         * unittests/string_view-selftests.c: Define
9940         _initialize_string_view_selftests unconditionally.
9941
9942 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9943
9944         PR gdb/24350
9945         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9946
9947 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9948
9949         PR gdb/24351
9950         * windows-nat.c (display_selector): Fix format specifiers.
9951
9952 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9953
9954         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9955         tui_refill_source_window instead of tui_refresh_win, to update the
9956         current execution line.  This fixes redisplay of the current line
9957         when stepping through the code with "next" or "step".
9958
9959 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9960
9961         * source-cache.c (source_cache::get_source_lines): Call
9962         find_source_lines to initialize s->nlines.  This fixes vertical
9963         scrolling of TUI source window when the DOWN arrow is pressed.
9964
9965 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9966
9967         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9968         linux-thread-db.c (_initialize_thread_db): Likewise.
9969
9970 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9971
9972         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9973         wclrtoeol in tui_show_source_line".  This reverts changes made in
9974         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9975
9976 2019-03-15  Tom Tromey  <tom@tromey.com>
9977
9978         * symtab.h (struct minimal_symbol): Derive from
9979         general_symbol_info.
9980         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9981         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9982         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9983         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9984         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9985         (MSYMBOL_SEARCH_NAME): Update.
9986         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9987         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9988         * minsyms.c (minimal_symbol_reader::record_full): Update.
9989
9990 2019-03-15  Tom Tromey  <tom@tromey.com>
9991
9992         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9993
9994 2019-03-15  Tom Tromey  <tom@tromey.com>
9995
9996         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9997         unique_xmalloc_ptr.
9998         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9999         Update.
10000         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10001         (build_minimal_symbol_hash_tables)
10002         (minimal_symbol_reader::install): Update.
10003
10004 2019-03-15  Tom Tromey  <tom@tromey.com>
10005
10006         * symtab.c (create_demangled_names_hash): Update.
10007         (symbol_set_names): Update.
10008         * objfiles.h (struct objfile_per_bfd_storage)
10009         <demangled_names_hash>: Now an htab_up.
10010         * objfiles.c (objfile_per_bfd_storage): Simplify.
10011
10012 2019-03-15  Tom Tromey  <tom@tromey.com>
10013
10014         * objfiles.h (struct objfile_per_bfd_storage): Declare
10015         destructor.
10016         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10017         New.
10018         (get_objfile_bfd_data): Use new.  Don't initialize
10019         language_of_main.
10020         (free_objfile_per_bfd_storage): Remove.
10021         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10022
10023 2019-03-15  Tom Tromey  <tom@tromey.com>
10024
10025         * symfile.c (reread_symbols): Update.
10026         * objfiles.c (objfile::objfile): Update.
10027         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10028         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10029         comment.
10030         (minimal_symbol_reader::install): Update.
10031         (terminate_minimal_symbol_table): Remove.
10032         * jit.c (jit_object_close_impl): Update.
10033
10034 2019-03-15  Tom Tromey  <tom@tromey.com>
10035
10036         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10037         initializations.
10038
10039 2019-03-15  Tom Tromey  <tom@tromey.com>
10040
10041         * objfiles.h (struct objfile_per_bfd_storage)
10042         <demangled_hash_languages>: Now a bitset.
10043         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10044         (lookup_minimal_symbol): Update.
10045
10046 2019-03-15  Tom Tromey  <tom@tromey.com>
10047
10048         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10049         Don't return the symbol.
10050         * coffread.c (record_minimal_symbol): Use record_full.
10051
10052 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10053
10054         The MS-Windows port of ncurses fails to switch to a color pair if
10055         one or both of the colors are the implicit default colors.  This
10056         change records the default colors when TUI is initialized, and
10057         then specifies them explicitly when a color pair uses the default
10058         colors.  This allows color styling in TUI mode on MS-Windows.
10059
10060         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10061         ncurses_norm_attr.
10062         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10063         colors in ncurses_norm_attr.
10064         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10065         "none", replace it with the default color recorded in
10066         ncurses_norm_attr.
10067
10068 2019-03-14  Tom Tromey  <tromey@adacore.com>
10069
10070         * source-cache.h (class source_cache) <get_source_lines>: Return
10071         std::string.
10072         * source-cache.c (source_cache::extract_lines): Handle case where
10073         first_pos==npos.  Return std::string.
10074         (source_cache::get_source_lines): Update.
10075
10076 2019-03-14  Tom Tromey  <tromey@adacore.com>
10077
10078         * NEWS: Add item for "style sources" commands.
10079         * source-cache.c (source_cache::get_source_lines): Check
10080         source_styling.
10081         * cli/cli-style.c (source_styling): New global.
10082         (_initialize_cli_style): Add "style sources" commands.
10083         (show_style_sources): New function.
10084         * cli/cli-style.h (source_styling): Declare.
10085
10086 2019-03-14  Pedro Alves  <palves@redhat.com>
10087             Tom Tromey  <tromey@adacore.com>
10088
10089         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10090         * tui/tui-winsource.c (tui_refill_source_window): New function,
10091         from...
10092         (tui_horizontal_source_scroll): ... here.  Move some logic.
10093         * cli/cli-style.c (set_style_enabled): Notify new observable.
10094         * tui/tui-hooks.c (tui_redisplay_source): New function.
10095         (tui_attach_detach_observers): Attach or detach
10096         tui_redisplay_source.
10097         * observable.h (source_styling_changed): New observable.
10098         * observable.c: Define source_styling_changed observable.
10099
10100 2019-03-13  Tom Tromey  <tromey@adacore.com>
10101
10102         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10103         (i386_gnu_nat_target::store_registers): Update.
10104         * target-debug.h (target_debug_print_std_string): New macro.
10105         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10106         * windows-tdep.c (display_one_tib): Update.
10107         * tui/tui-stack.c (tui_make_status_line): Update.
10108         * top.c (print_inferior_quit_action): Update.
10109         * thread.c (thr_try_catch_cmd): Update.
10110         (add_thread_with_info): Update.
10111         (thread_target_id_str): Update.
10112         (thr_try_catch_cmd): Update.
10113         (thread_command): Update.
10114         (thread_find_command): Update.
10115         * record-btrace.c (record_btrace_target::info_record)
10116         (record_btrace_resume_thread, record_btrace_target::resume)
10117         (record_btrace_cancel_resume, record_btrace_step_thread)
10118         (record_btrace_target::wait, record_btrace_target::wait)
10119         (record_btrace_target::wait, record_btrace_target::stop): Update.
10120         * progspace.c (print_program_space): Update.
10121         * process-stratum-target.c
10122         (process_stratum_target::thread_address_space): Update.
10123         * linux-fork.c (linux_fork_mourn_inferior)
10124         (detach_checkpoint_command, info_checkpoints_command)
10125         (linux_fork_context): Update.
10126         (linux_fork_detach): Update.
10127         (class scoped_switch_fork_info): Update.
10128         (delete_checkpoint_command): Update.
10129         * infrun.c (follow_fork_inferior): Update.
10130         (follow_fork_inferior): Update.
10131         (proceed_after_vfork_done): Update.
10132         (handle_vfork_child_exec_or_exit): Update.
10133         (follow_exec): Update.
10134         (displaced_step_prepare_throw): Update.
10135         (displaced_step_restore): Update.
10136         (start_step_over): Update.
10137         (resume_1): Update.
10138         (clear_proceed_status_thread): Update.
10139         (proceed): Update.
10140         (print_target_wait_results): Update.
10141         (do_target_wait): Update.
10142         (context_switch): Update.
10143         (stop_all_threads): Update.
10144         (restart_threads): Update.
10145         (finish_step_over): Update.
10146         (handle_signal_stop): Update.
10147         (switch_back_to_stepped_thread): Update.
10148         (keep_going_pass_signal): Update.
10149         (print_exited_reason): Update.
10150         (normal_stop): Update.
10151         * inferior.c (inferior_pid_to_str): Change return type.
10152         (print_selected_inferior): Update.
10153         (add_inferior): Update.
10154         (detach_inferior): Update.
10155         * dummy-frame.c (fprint_dummy_frames): Update.
10156         * dcache.c (dcache_info_1): Update.
10157         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10158         (btrace_fetch, btrace_clear): Update.
10159         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10160         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10161         type.
10162         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10163         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10164         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10165         * gdbarch.c, gdbarch.h: Rebuild.
10166         * gdbarch.sh (core_pid_to_str): Change return type.
10167         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10168         return type.
10169         (windows_nat_target::pid_to_str): Change return type.
10170         (windows_delete_thread): Update.
10171         (windows_nat_target::attach): Update.
10172         (windows_nat_target::files_info): Update.
10173         * target-delegates.c: Rebuild.
10174         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10175         return type.
10176         (sol_thread_target::pid_to_str): Change return type.
10177         * remote.c (class remote_target) <pid_to_str>: Change return
10178         type.
10179         (remote_target::pid_to_str): Change return type.
10180         (extended_remote_target::attach, remote_target::remote_stop_ns)
10181         (remote_target::remote_notif_remove_queued_reply)
10182         (remote_target::push_stop_reply, remote_target::disable_btrace):
10183         Update.
10184         (extended_remote_target::attach): Update.
10185         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10186         type.
10187         (gdbsim_target::pid_to_str): Change return type.
10188         * ravenscar-thread.c (struct ravenscar_thread_target)
10189         <pid_to_str>: Change return type.
10190         (ravenscar_thread_target::pid_to_str): Change return type.
10191         * procfs.c (class procfs_target) <pid_to_str>: Change return
10192         type.
10193         (procfs_target::pid_to_str): Change return type.
10194         (procfs_target::attach): Update.
10195         (procfs_target::detach): Update.
10196         (procfs_target::fetch_registers): Update.
10197         (procfs_target::store_registers): Update.
10198         (procfs_target::wait): Update.
10199         (procfs_target::files_info): Update.
10200         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10201         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10202         return type.
10203         (nto_procfs_target::pid_to_str): Change return type.
10204         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10205         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10206         return type.
10207         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10208         (exit_lwp): Update.
10209         (attach_proc_task_lwp_callback, get_detach_signal)
10210         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10211         (linux_nat_target::resume, wait_lwp, stop_callback)
10212         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10213         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10214         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10215         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10216         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10217         type.
10218         (inf_ptrace_target::attach): Update.
10219         (inf_ptrace_target::files_info): Update.
10220         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10221         type.
10222         (go32_nat_target::pid_to_str): Change return type.
10223         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10224         (gnu_nat_target::wait): Update.
10225         (gnu_nat_target::wait): Update.
10226         (gnu_nat_target::resume): Update.
10227         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10228         (fbsd_nat_target::wait): Update.
10229         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10230         type.
10231         (darwin_nat_target::attach): Update.
10232         * corelow.c (class core_target) <pid_to_str>: Change return type.
10233         (core_target::pid_to_str): Change return type.
10234         * target.c (normal_pid_to_str): Change return type.
10235         (default_pid_to_str): Likewise.
10236         (target_pid_to_str): Change return type.
10237         (target_translate_tls_address): Update.
10238         (target_announce_detach): Update.
10239         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10240         return type.
10241         (bsd_uthread_target::pid_to_str): Change return type.
10242         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10243         type.
10244         (bsd_kvm_target::pid_to_str): Change return type.
10245         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10246         return type.
10247         (aix_thread_target::pid_to_str): Change return type.
10248         * target.h (struct target_ops) <pid_to_str>: Change return type.
10249         (target_pid_to_str, normal_pid_to_str): Likewise.
10250         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10251         type.
10252         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10253         type.
10254         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10255         return type.
10256         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10257         type.
10258         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10259         type.
10260         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10261         return type.
10262
10263 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10264
10265         * NEWS: Mention that the new default MI version is 3.  Mention
10266         changes to the output of commands and events that deal with
10267         multi-location breakpoints.
10268         * breakpoint.c: Include "mi/mi-out.h".
10269         (print_one_breakpoint): Change output syntax if using MI version
10270         >= 3.
10271         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10272         New.
10273         (mi_multi_location_breakpoint_output_fixed): New.
10274         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10275         (mi_cmd_fix_multi_location_breakpoint_output): New.
10276         (mi_multi_location_breakpoint_output_fixed): New.
10277         * mi/mi-cmds.c (mi_cmds): Register command
10278         -fix-multi-location-breakpoint-output.
10279         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10280         interpreter "mi".
10281
10282 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10283
10284         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10285         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10286         instantiate mi_ui_out based on interpreter name.
10287         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10288         * mi/mi-main.c (mi_load_progress): Likewise.
10289
10290 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10291
10292         * NEWS: Combine separate "New targets" sections for 8.3.
10293
10294 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10295
10296         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10297         (ppcfbsd_init_abi): Install gdbarch
10298         "fetch_tls_load_module_address" and "get_thread_local_address"
10299         methods.
10300
10301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10302
10303         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10304         (riscv_fbsd_init_abi): Install gdbarch
10305         "fetch_tls_load_module_address" and "get_thread_local_address"
10306         methods.
10307
10308 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10309
10310         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10311         (i386fbsd_init_abi): Install gdbarch
10312         "fetch_tls_load_module_address" and "get_thread_local_address"
10313         methods.
10314
10315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10316
10317         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10318         (amd64fbsd_init_abi): Install gdbarch
10319         "fetch_tls_load_module_address" and "get_thread_local_address"
10320         methods.
10321
10322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10323
10324         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10325         (struct fbsd_pspace_data): New type.
10326         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10327         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10328         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10329         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10330         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10331
10332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10333
10334         * gdbtypes.c (lookup_struct_elt): New function.
10335         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10336         * gdbtypes.h (struct struct_elt): New type.
10337         (lookup_struct_elt): New prototype.
10338
10339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10340
10341         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10342         remove disabled code block.
10343
10344 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10345
10346         * gdbarch.sh (get_thread_local_address): New method.
10347         * gdbarch.h, gdbarch.c: Regenerate.
10348         * target.c (target_translate_tls_address): Use
10349         gdbarch_get_thread_local_address if present instead of
10350         target::get_thread_local_address.
10351
10352 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10353
10354         * target.h (target::get_thread_local_address): Update comment.
10355
10356 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10357
10358         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10359         objfile->separate_debug_objfile_backlink if not NULL.
10360
10361 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10362
10363         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10364         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10365         (amd64bsd_store_inferior_registers): Likewise.
10366         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10367         Enable segment base registers.
10368         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10369         PT_GETFSBASE and PT_GETGSBASE.
10370         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10371         PT_SETGSBASE.
10372         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10373         segment base registers.
10374         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10375
10376 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10377
10378         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10379         Update calls to i386_target_description to add 'segments'
10380         parameter.
10381         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10382         add segment base registers.
10383         * arch/i386.c (i386_create_target_description): Add 'segments'
10384         parameter to enable segment base registers.
10385         * arch/i386.h (i386_create_target_description): Likewise.
10386         * features/i386/32bit-segments.xml: New file.
10387         * features/i386/32bit-segments.c: Generate.
10388         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10389         call to i386_target_description to add 'segments' parameter.
10390         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10391         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10392         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10393         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10394         if feature is present.
10395         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10396         Add 'segments' parameter to call to i386_target_description.
10397         (i386_target_description): Add 'segments' parameter to enable
10398         segment base registers.
10399         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10400         to call to i386_target_description.
10401         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10402         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10403         Define I386_NUM_REGS.
10404         (i386_target_description): Add 'segments' parameter to enable
10405         segment base registers.
10406
10407 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10408
10409         PR/24325
10410         * source-cache.c: #undef open and close, to avoid unresolved
10411         externals during linking.
10412
10413 2019-03-12  Tom Tromey  <tromey@adacore.com>
10414
10415         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10416         const.  Add initializers.
10417         (_initialize_remote): Don't initialize ptid globals.
10418
10419 2019-03-12  Pedro Alves  <palves@redhat.com>
10420
10421         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10422
10423 2019-03-12  Pedro Alves  <palves@redhat.com>
10424
10425         * cp-name-parser.y (main): Remove unused 'len' variable.
10426
10427 2019-03-12  Tom Tromey  <tromey@adacore.com>
10428
10429         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10430         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10431
10432 2019-03-12  Tom Tromey  <tromey@adacore.com>
10433
10434         * linux-nat.c (iterate_over_lwps): Update.
10435         (stop_callback): Remove parameter.
10436         (stop_wait_callback, detach_callback, resume_set_callback)
10437         (select_singlestep_lwp_callback, set_ignore_sigint)
10438         (status_callback, resumed_callback, resume_clear_callback)
10439         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10440         data parameter.
10441         (linux_nat_target::detach, linux_nat_target::resume)
10442         (linux_stop_and_wait_all_lwps, select_event_lwp)
10443         (linux_nat_filter_event, linux_nat_wait_1)
10444         (linux_nat_target::kill, linux_nat_target::stop)
10445         (linux_nat_target::stop): Update.
10446         (linux_nat_resume_callback): Change type.
10447         (resume_stopped_resumed_lwps, count_events_callback)
10448         (select_event_lwp_callback): Likewise.
10449         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10450         * arm-linux-nat.c (struct update_registers_data): Remove.
10451         (update_registers_callback): Change type.
10452         (arm_linux_insert_hw_breakpoint1): Update.
10453         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10454         parameter.
10455         (x86_linux_dr_set_addr): Update.
10456         (x86_linux_dr_set_control): Update.
10457         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10458         (iterate_over_lwps): Use gdb::function_view.
10459         * nat/aarch64-linux-hw-point.c (struct
10460         aarch64_dr_update_callback_param): Remove.
10461         (debug_reg_change_callback): Change type.
10462         (aarch64_notify_debug_reg_change): Update.
10463         * s390-linux-nat.c (s390_refresh_per_info): Update.
10464
10465 2019-03-11  Tom Tromey  <tromey@adacore.com>
10466
10467         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10468         redundant assignment to "this_cu".
10469
10470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10471
10472         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10473
10474 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10475
10476         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10477         from...
10478         (rank_one_type): ... this.
10479
10480 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10481
10482         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10483         from...
10484         (rank_one_type): ... this.
10485
10486 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10487
10488         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10489         from...
10490         (rank_one_type): ... this.
10491
10492 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10493
10494         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10495         from...
10496         (rank_one_type): ... this.
10497
10498 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10499
10500         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10501         from...
10502         (rank_one_type): ... this.
10503
10504 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10505
10506         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10507         from...
10508         (rank_one_type): ... this.
10509
10510 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10511
10512         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10513         from...
10514         (rank_one_type): ... this.
10515
10516 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10517
10518         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10519         from...
10520         (rank_one_type): ... this.
10521
10522 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10523
10524         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10525         from...
10526         (rank_one_type): ... this.
10527
10528 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10529
10530         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10531         from...
10532         (rank_one_type): ... this.
10533
10534 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10535
10536         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10537         from...
10538         (rank_one_type): ... this.
10539
10540 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10541
10542         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10543         from...
10544         (rank_one_type): ... this.
10545
10546 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10547
10548         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10549         inferior-events' shows the example events.
10550
10551 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10552
10553         Support styling on native MS-Windows console
10554
10555         PR/24315
10556         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10557         on MS-Windows if $TERM is not defined.
10558
10559         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10560
10561         * posix-hdep.c (gdb_console_fputs):
10562         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10563         functions.
10564         * ui-file.h (gdb_console_fputs): Add prototype.
10565
10566         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10567         back to fputs only if the former returns zero.
10568
10569 2019-03-07  Tom Tromey  <tom@tromey.com>
10570
10571         * symmisc.c (print_symbol_bcache_statistics): Update.
10572         (print_objfile_statistics): Update.
10573         * symfile.c (allocate_symtab): Update.
10574         * stabsread.c: Don't include bcache.h.
10575         * psymtab.h (struct psymbol_bcache): Don't declare.
10576         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10577         (psymbol_bcache_init, psymbol_bcache_free)
10578         (psymbol_bcache_get_bcache): Don't declare.
10579         * psymtab.c (struct psymbol_bcache): Remove.
10580         (psymtab_storage::psymtab_storage): Update.
10581         (psymtab_storage::~psymtab_storage): Update.
10582         (psymbol_bcache_init, psymbol_bcache_free)
10583         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10584         (add_psymbol_to_bcache): Update.
10585         (allocate_psymtab): Update.
10586         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10587         macro_cache>: No longer pointers.
10588         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10589         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10590         * macrotab.c (macro_bcache): Update.
10591         * macroexp.c: Don't include bcache.h.
10592         * gdbtypes.c (check_types_worklist): Update.
10593         (types_deeply_equal): Remove TRY/CATCH.  Update.
10594         * elfread.c (elf_symtab_read): Update.
10595         * dwarf2read.c: Don't include bcache.h.
10596         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10597         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10598         (print_bcache_statistics, bcache_memory_used): Don't declare.
10599         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10600         methods.  Rename all data members.
10601         * bcache.c (struct bcache): Move to bcache.h.
10602         (bcache::expand_hash_table): Rename from expand_hash_table.
10603         (bcache): Remove.
10604         (bcache::insert): Rename from bcache_full.
10605         (bcache::compare): Rename from bcache_compare.
10606         (bcache_xmalloc): Remove.
10607         (bcache::~bcache): Rename from bcache_xfree.
10608         (bcache::print_statistics): Rename from print_bcache_statistics.
10609         (bcache::memory_used): Rename from bcache_memory_used.
10610
10611 2019-03-07  Pedro Alves  <palves@redhat.com>
10612
10613         * infrun.c (normal_stop): Also check for
10614         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10615
10616 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10617
10618         * f-lang.c (value_from_host_double): Moved to...
10619         * value.c (value_from_host_double): ...here.
10620         * value.h (value_from_host_double): Declare.
10621         * guile/scm-math.c (vlscm_convert_typed_number): Use
10622         value_from_host_double.
10623         (vlscm_convert_number): Likewise.
10624         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10625         * python/py-value.c (convert_value_from_python): Likewise.
10626
10627 2019-03-06  Tom Tromey  <tom@tromey.com>
10628
10629         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10630
10631 2019-03-06  Tom Tromey  <tom@tromey.com>
10632
10633         * utils.h (free_current_contents): Don't declare.
10634         * utils.c (free_current_contents): Remove.
10635
10636 2019-03-06  Tom Tromey  <tom@tromey.com>
10637
10638         * top.c (quit_force): Update.
10639         * main.c (captured_command_loop): Update.
10640         * common/new-op.c (operator new): Update.
10641         * common/common-exceptions.c (struct catcher)
10642         <save_cleanup_chain>: Remove member.
10643         (exceptions_state_mc_init): Update.
10644         (exception_try_scope_entry): Return nullptr.
10645         (exception_try_scope_exit, exception_rethrow)
10646         (throw_exception_sjlj, throw_exception_cxx): Update.
10647         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10648         (all_cleanups, do_cleanups, discard_cleanups)
10649         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10650         (restore_cleanups, restore_final_cleanups): Don't declare.
10651         (do_final_cleanups): Remove parameter.
10652         * common/cleanups.c (cleanup_chain, make_cleanup)
10653         (make_cleanup_dtor, all_cleanups, do_cleanups)
10654         (discard_my_cleanups, discard_cleanups)
10655         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10656         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10657         (null_cleanup): Remove.
10658         (do_final_cleanups): Remove parameter.
10659
10660 2019-03-06  Tom Tromey  <tom@tromey.com>
10661
10662         * remote.c (remote_target::remote_parse_stop_reply): Use
10663         unique_xmalloc_ptr.
10664
10665 2019-03-06  Tom Tromey  <tom@tromey.com>
10666
10667         * stabsread.c (struct stabs_field_info): Rename from field_info.
10668         <list, fnlist>: Add initializers.
10669         <obstack>: New member.
10670         (read_member_functions, read_struct_fields, read_baseclasses):
10671         Allocate on obstack.  Don't use cleanups.
10672         (read_one_struct_field, read_member_functions, read_struct_fields)
10673         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10674         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10675         (read_struct_type): Update.
10676
10677 2019-03-06  Tom Tromey  <tom@tromey.com>
10678
10679         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10680         * common/filestuff.h (make_cleanup_close): Don't declare.
10681         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10682         Remove.
10683
10684 2019-03-06  Tom Tromey  <tom@tromey.com>
10685
10686         * solib-aix.c: Use make_scope_exit.
10687
10688 2019-03-06  Tom Tromey  <tom@tromey.com>
10689
10690         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10691         Use make_scope_exit.
10692
10693 2019-03-06  Tom Tromey  <tom@tromey.com>
10694
10695         * solib-svr4.c (disable_probes_interface): Remove parameter.
10696         (svr4_handle_solib_event): Use make_scope_exit.
10697
10698 2019-03-06  Tom Tromey  <tom@tromey.com>
10699
10700         * remote.c (struct stop_reply_deleter): Remove.
10701         (stop_reply_up): Update.
10702         (struct stop_reply): Derive from notif_event.  Don't typedef.
10703         <regcache>: Now a std::vector.
10704         (stop_reply_xfree): Remove.
10705         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10706         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10707         (remote_target::discard_pending_stop_replies): Use delete.
10708         (remote_target::remote_parse_stop_reply): Update.
10709         (remote_target::process_stop_reply): Update.
10710         * remote-notif.h (struct notif_event): Add virtual destructor.
10711         Remove "dtr" member.
10712         (struct notif_client) <alloc_event>: Return a unique_ptr.
10713         (notif_event_xfree): Don't declare.
10714         (notif_event_up): New typedef.
10715         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10716         (notif_event_xfree, do_notif_event_xfree): Remove.
10717         (remote_notif_state_xfree): Update.
10718
10719 2019-03-06  Tom Tromey  <tom@tromey.com>
10720
10721         * infrun.c (displaced_step_clear_cleanup): Now a
10722         forward_scope_exit type.
10723         (displaced_step_prepare_throw): Update.
10724         (displaced_step_fixup): Update.
10725
10726 2019-03-06  Tom Tromey  <tom@tromey.com>
10727
10728         * inferior.h (class inferior): Update comment.
10729         * gdbthread.h (class thread_info): Update comment.
10730
10731 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10732             Tom Tromey  <tom@tromey.com>
10733
10734         * stabsread.h (struct stab_section_list): Remove.
10735         (coffstab_build_psymtabs): Update.
10736         * dbxread.c (symbuf_sections): Now a std::vector.
10737         (sect_idx): New global.
10738         (fill_symbuf): Update.
10739         (coffstab_build_psymtabs): Change type of stabsects parameter.
10740         Update.
10741         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10742         std::vector.
10743         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10744         (coff_locate_sections): Update.
10745         (coff_symfile_read): Remove cleanups.  Update.
10746         (init_stringtab): Add storage parameter.
10747         (free_stringtab, free_stringtab_cleanup): Remove.
10748         (init_lineno): Add storage parameter.
10749         (free_linetab, free_linetab_cleanup): Remove.
10750
10751 2019-03-06  Pedro Alves  <palves@redhat.com>
10752
10753         * linux-fork.c (fork_info::clobber_regs): Delete.
10754         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10755         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10756         comment.  Adjust.
10757         (scoped_switch_fork_info::scoped_switch_fork_info)
10758         (checkpoint_command, linux_fork_context): Adjust
10759         fork_save_infrun_state calls.
10760
10761 2019-03-06  Pedro Alves  <palves@redhat.com>
10762
10763         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10764         (inf_has_multiple_threads): Return 'bool' and rewrite using
10765         inferior_info::threads().
10766
10767 2019-03-06  Pedro Alves  <palves@redhat.com>
10768
10769         * linux-fork.c: Include <list>.
10770         (fork_list): Now a std::list instance.
10771         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10772         (forks_exist_p, find_last_fork): Adjust.
10773         (new_fork): Delete.
10774         (one_fork_p): New.
10775         (add_fork): Adjust.
10776         (free_fork): Delete, folded into fork_info::~fork_info().
10777         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10778         Adjust.
10779         (init_fork_list): Delete.
10780         (linux_fork_killall, linux_fork_mourn_inferior)
10781         (linux_fork_detach, info_checkpoints_command): Adjust.
10782         (_initialize_linux_fork): No longer call init_fork_list.
10783
10784 2019-03-06  Pedro Alves  <palves@redhat.com>
10785
10786         * linux-fork.c (new_fork): New, split out of ...
10787         (add_fork): ... this.  Return void.  Move "first fork" special
10788         case from here, to ...
10789         (checkpoint_command): ... here.
10790         * linux-linux.h (add_fork): Return void.
10791
10792 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10793
10794         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10795
10796 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10797             Chris January  <chris.january@arm.com>
10798             David Lecomber  <david.lecomber@arm.com>
10799
10800         * f-exp.y: New token, UNOP_INTRINSIC.
10801         (exp): New pattern using UNOP_INTRINSIC token.
10802         (f77_keywords): Add 'abs' keyword.
10803         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10804         (value_from_host_double): New function.
10805         (evaluate_subexp_f): Support UNOP_ABS.
10806
10807 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10808
10809         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10810         types.
10811
10812 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10813
10814         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10815         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10816         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10817
10818 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10819
10820         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10821
10822 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10823             Chris January  <chris.january@arm.com>
10824
10825         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10826         * f-exp.y: Define 'KIND' token.
10827         (exp): New pattern for KIND expressions.
10828         (ptype): Handle types with a kind extension.
10829         (direct_abs_decl): Extend to spot kind extensions.
10830         (f77_keywords): Add 'kind' to the list.
10831         (push_kind_type): New function.
10832         (convert_to_kind_type): New function.
10833         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10834         * parse.c (operator_length_standard): Likewise.
10835         * parser-defs.h (enum type_pieces): Add tp_kind.
10836         * std-operator.def: Add UNOP_KIND.
10837
10838 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10839
10840         * f-exp.y (f_parse): Set yydebug.
10841
10842 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10843
10844         * f-lang.c (evaluate_subexp_f): New function.
10845         (exp_descriptor_f): New global.
10846         (f_language_defn): Use exp_descriptor_f instead of
10847         exp_descriptor_standard.
10848
10849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10850
10851         * f-exp.y (struct token): Add comments.
10852         (dot_ops): Remove uppercase versions and the end marker.
10853         (f77_keywords): Likewise.
10854         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10855         entries in the dot_ops array are case insensitive, and use
10856         strncasecmp to compare strings.  Also some whitespace cleanup in
10857         this area.  Similar for the f77_keywords array, except entries in
10858         this list might be case sensitive.
10859
10860 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10861
10862         * f-exp.y (struct f77_boolean_val): Add comments.
10863         (boolean_values): Remove uppercase versions, and end marker.
10864         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10865         and use strncasecmp to achieve case insensitivity.  Additionally,
10866         perform whitespace cleanup around this code.
10867
10868 2019-03-06  Tom Tromey  <tromey@adacore.com>
10869
10870         * remote-sim.c (gdbsim_target_open): Use result of
10871         gdb_argv::release.
10872
10873 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10874         Dirk Schubert  <dirk.schubert@arm.com>
10875         Chris January  <chris.january@arm.com>
10876
10877         * eval.c (evaluate_subexp_standard): Call Fortran argument
10878         wrapping logic.
10879         * f-lang.c (struct value): A value which can be passed into a
10880         Fortran function call.
10881         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10882         where appropriate.
10883         (struct type): Value ready for a Fortran function call.
10884         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10885         is needed.
10886         * f-lang.h (fortran_argument_convert): Declaration.
10887         (fortran_preserve_arg_pointer): Declaration.
10888         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10889
10890 2019-03-05  Tom Tromey  <tromey@adacore.com>
10891
10892         * python/py-prettyprint.c (print_string_repr): Remove #if.
10893         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10894
10895 2019-03-05  Tom Tromey  <tromey@adacore.com>
10896
10897         * target.c (the_dummy_target): Move later.  Change type to
10898         "dummy_target".
10899         (initialize_targets): Don't initialize the_dummy_target.
10900
10901 2019-03-05  Tom Tromey  <tromey@adacore.com>
10902
10903         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10904         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10905
10906 2019-03-05  Tom Tromey  <tromey@adacore.com>
10907
10908         * windows-nat.c (windows_nat_target::attach)
10909         (windows_nat_target::detach): Don't call gdb_flush.
10910         * valprint.c (generic_val_print, val_print, val_print_string):
10911         Don't call gdb_flush.
10912         * utils.c (defaulted_query): Don't call gdb_flush.
10913         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10914         * target.c (target_announce_detach): Don't call gdb_flush.
10915         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10916         * remote.c (extended_remote_target::attach): Don't call
10917         gdb_flush.
10918         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10919         * printcmd.c (do_examine): Don't call gdb_flush.
10920         (info_display_command): Don't call gdb_flush.
10921         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10922         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10923         * memattr.c (info_mem_command): Don't call gdb_flush.
10924         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10925         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10926         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10927         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10928         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10929         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10930         (gnu_nat_target::detach): Don't call gdb_flush.
10931         * f-valprint.c (f_val_print): Don't call gdb_flush.
10932         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10933         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10934         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10935         gdb_flush.
10936         * c-valprint.c (c_val_print): Don't call gdb_flush.
10937         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10938
10939 2019-03-05  Tom Tromey  <tromey@adacore.com>
10940
10941         * varobj.c (update_dynamic_varobj_children): Update.
10942         (install_default_visualizer): Use reset, not release.
10943         * value.c (set_internalvar): Update.
10944         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10945         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10946         ATTRIBUTE_UNUSED_RESULT.
10947
10948 2019-03-05  Tom Tromey  <tromey@adacore.com>
10949
10950         * remote.c (class scoped_remote_fd) <release>: Add
10951         ATTRIBUTE_UNUSED_RESULT.
10952
10953 2019-03-05  Tom Tromey  <tromey@adacore.com>
10954
10955         * macroexp.c (struct macro_buffer) <release>: Add
10956         ATTRIBUTE_UNUSED_RESULT.
10957
10958 2019-03-05  Tom Tromey  <tromey@adacore.com>
10959
10960         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10961         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10962         ATTRIBUTE_UNUSED_RESULT.
10963
10964 2019-03-05  Tom Tromey  <tromey@adacore.com>
10965
10966         * common/scoped_fd.h (class scoped_fd) <release>: Add
10967         ATTRIBUTE_UNUSED_RESULT.
10968
10969 2019-03-05  Tom Tromey  <tromey@adacore.com>
10970
10971         * parser-defs.h (struct parser_state) <release>: Add
10972         ATTRIBUTE_UNUSED_RESULT.
10973
10974 2019-03-05  Tom Tromey  <tromey@adacore.com>
10975
10976         * utils.h (class gdb_argv) <release>: Add
10977         ATTRIBUTE_UNUSED_RESULT.
10978         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10979
10980 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10981
10982         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10983         for-loop range, to avoid compiler warnings.
10984
10985         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10986         avoid compiler warnings about unused variables.
10987
10988         * NEWS: Mention end of support for native debugging on MS-Windows
10989         before XP.
10990
10991         PR gdb/24292
10992         * common/netstuff.c:
10993         * gdbserver/gdbreplay.c
10994         * gdbserver/remote-utils.c:
10995         * ser-tcp.c:
10996         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10997         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10998         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10999         'getaddrinfo' and 'freeaddrinfo' were not available before
11000         Windows XP, and mingw.org's MinGW headers by default define
11001         _WIN32_WINNT to 0x500.
11002
11003 2019-03-01  Gary Benson <gbenson@redhat.com>
11004
11005         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11006
11007 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11008             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11009
11010         PR gdb/8527
11011         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11012         set_sigint_trap, clear_sigint_trap.
11013
11014 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11015
11016         * target.c (target_detach): Clear the regcache and the
11017         frame cache.
11018
11019 2019-02-27  Pedro Alves  <palves@redhat.com>
11020
11021         * utils.c (set_screen_size): When we cap the height/width sizes,
11022         tweak the corresponding command variable to show "unlimited":
11023
11024 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11025             Pedro Alves  <palves@redhat.com>
11026
11027         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11028         before calling rl_set_screen_size.
11029
11030 2019-02-27  Tom Tromey  <tromey@adacore.com>
11031
11032         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11033         define.
11034         * python/py-value.c: Remove Python 2.4 workaround.
11035         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11036         workaround.
11037         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11038         Python 2.4 workaround.
11039         * python/python-internal.h: Remove Python 2.4 comment.
11040         (Py_ssize_t): Don't define.
11041         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11042         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11043         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11044         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11045         * python/python.c (do_start_initialization): Remove Python 2.4
11046         workaround.
11047         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11048         (print_children): Remove Python 2.4 workaround.
11049         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11050         workaround.
11051         (CHARBUFFERPROC_NAME): Remove.
11052         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11053         Python 2.4 workaround.
11054
11055 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11056
11057         * NEWS: Note minimum Python version.
11058
11059 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11060
11061         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11062         code from these functions.  Remove corresponding ifdefs.  Use
11063         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11064         Remove gotos and target of gotos.
11065         (infpy_search_memory): Likewise.
11066
11067 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11068
11069         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11070         (hppa_gdbarch_init): Don't register deleted functions with
11071         gdbarch.
11072
11073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11074
11075         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11076         (h8300_unwind_sp): Delete.
11077         (h8300_dummy_id): Delete.
11078         (h8300_gdbarch_init): Don't register deleted functions with
11079         gdbarch.
11080
11081 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11082
11083         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11084         (ft32_unwind_pc): Delete.
11085         (ft32_unwind_sp): Delete.
11086         (ft32_gdbarch_init): Don't register deleted functions with
11087         gdbarch.
11088
11089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11090
11091         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11092         (frv_unwind_pc): Delete.
11093         (frv_unwind_sp): Delete.
11094         (frv_gdbarch_init): Don't register deleted functions with
11095         gdbarch.
11096
11097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11098
11099         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11100         (riscv_unwind_pc): Delete.
11101         (riscv_unwind_sp): Delete.
11102         (riscv_gdbarch_init): Don't register deleted functions with
11103         gdbarch.
11104
11105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11106
11107         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11108         (csky_unwind_pc): Delete.
11109         (csky_unwind_sp): Delete.
11110         (csky_gdbarch_init): Don't register deleted functions with
11111         gdbarch.
11112
11113 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11114
11115         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11116         (cris_unwind_pc): Delete.
11117         (cris_unwind_sp): Delete.
11118         (cris_gdbarch_init): Don't register deleted functions with
11119         gdbarch.
11120
11121 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11122
11123         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11124         (bfin_unwind_pc): Delete.
11125         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11126
11127 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11128
11129         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11130         (arm_unwind_pc): Delete.
11131         (arm_unwind_sp): Delete.
11132         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11133
11134 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11135
11136         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11137         (arc_unwind_pc): Delete.
11138         (arc_unwind_sp): Delete.
11139         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11140
11141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11142
11143         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11144         (alpha_unwind_pc): Delete.
11145         (alpha_gdbarch_init): Don't register deleted functions with
11146         gdbarch.
11147
11148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11149
11150         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11151         (aarch64_unwind_pc): Delete.
11152         (aarch64_unwind_sp): Delete.
11153         (aarch64_gdbarch_init): Don't register deleted functions with
11154         gdbarch.
11155
11156 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11157
11158         * gdbtypes.c (type_align): Don't consider static members when
11159         computing structure alignment.
11160
11161 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11162
11163         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11164         return 0 for other types.
11165         * arch-utils.c (default_type_align): Always return 0.
11166         * gdbarch.h: Regenerate.
11167         * gdbarch.sh (type_align): Extend comment.
11168         * gdbtypes.c (type_align): Add additional comments, always call
11169         gdbarch_type_align before applying the default rules.
11170         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11171         generic code will then apply a suitable default.
11172         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11173         types, return 0 for other types.
11174
11175 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11176
11177         * NEWS: Create a new section for the next release branch.
11178         Rename the section of the current branch, now that it has
11179         been cut.
11180
11181 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11182
11183         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11184         * version.in: Bump version to 8.3.50.DATE-git.
11185
11186 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11187
11188         * aix-thread.c (ptid_cmp): Remove unused variable.
11189         (get_signaled_thread): Likewise.
11190         (store_regs_user_thread): Likewise.
11191         (store_regs_kernel_thread): Likewise.
11192         (fetch_regs_kernel_thread): Remove shadowed variable.
11193
11194 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11195
11196         * features/riscv/32bit-cpu.xml: Add register numbers.
11197         * features/riscv/32bit-fpu.c: Regenerate.
11198         * features/riscv/32bit-fpu.xml: Add register numbers.
11199         * features/riscv/64bit-cpu.xml: Add register numbers.
11200         * features/riscv/64bit-fpu.c: Regenerate.
11201         * features/riscv/64bit-fpu.xml: Add register numbers.
11202
11203 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11204
11205         * NEWS: Mention two argument form of gdb.Value constructor.
11206         * python/py-value.c (convert_buffer_and_type_to_value): New
11207         function.
11208         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11209         Add support for handling an optional second argument.  Call
11210         convert_buffer_and_type_to_value as appropriate.
11211         * python/python-internal.h (Py_buffer_deleter): New struct.
11212         (Py_buffer_up): New typedef.
11213
11214 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11215
11216         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11217         instead of releasing ownership.
11218
11219 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11220
11221         * dwarf2read.c (open_and_init_dwp_file): Call
11222         elf_numsections instead of bfd_count_sections to initialize
11223         dwp_file->num_sections.
11224
11225 2019-02-25  Tom Tromey  <tromey@adacore.com>
11226
11227         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11228
11229 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11230
11231         * gcore.in: Add '--readnever' option when invoking GDB.
11232
11233 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11234
11235         * MAINTAINERS: Update my email address.
11236
11237 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11238
11239         * build-id.c (build_id_to_debug_bfd_1): New function.
11240         (build_id_to_debug_bfd): Look for separate debug file in
11241         sysroot.
11242
11243 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11244
11245         * gdbarch.sh: Update the copyright year range that is placed into
11246         generated files.
11247
11248 2019-02-22  Keith Seitz  <keiths@redhat.com>
11249
11250         PR symtab/23853
11251         * linespec.c (create_sals_line_offset): Search for the default
11252         symtab's filename instead of its fullname.
11253
11254 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11255
11256         * NEWS: Update style defaults.
11257
11258 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11259
11260         * main.c (captured_main_1): Disable styling in batch mode.
11261
11262 2019-02-20  Tom Tromey  <tom@tromey.com>
11263
11264         * symtab.c (symtab_symbol_info): Fix typos.
11265
11266 2019-02-20  Tom Tromey  <tromey@adacore.com>
11267
11268         * findcmd.c (_initialize_mem_search): Use upper case for
11269         metasyntactic variables.
11270
11271 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11272
11273         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11274         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11275
11276 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11277
11278         * top.h (source_file_name): Change to std::string.
11279         * top.c (source_file_name): Likewise.
11280         (command_line_input): Adjust.
11281         * cli/cli-script.c (script_from_file): Adjust.
11282
11283 2019-02-19  Tom Tromey  <tromey@adacore.com>
11284
11285         * ravenscar-thread.c
11286         (ravenscar_thread_target::update_thread_list): Don't call
11287         ada_build_task_list.
11288         * ada-lang.h (ada_build_task_list): Don't declare.
11289         * ada-tasks.c (struct ada_tasks_inferior_data)
11290         <task_list_valid_p>: Now bool.
11291         (read_known_tasks, ada_task_list_changed)
11292         (ada_tasks_invalidate_inferior_data): Update.
11293         (read_known_tasks_array): Return bool.
11294         (read_known_tasks_list): Likewise.
11295         (read_known_tasks): Return void.
11296         (ada_build_task_list): Now static.
11297
11298 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11299
11300         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11301         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11302
11303 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11304
11305         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11306         variant for ada_tasks_pspace_data_handle and
11307         ada_tasks_inferior_data_handle.
11308         (ada_tasks_pspace_data_cleanup): New function.
11309         (ada_tasks_inferior_data_cleanup): New function.
11310
11311 2019-02-17  Tom Tromey  <tom@tromey.com>
11312
11313         * macrotab.h (macro_source_fullname): Return a std::string.
11314         * macrotab.c (macro_include, check_for_redefinition)
11315         (macro_undef, macro_lookup_definition, foreach_macro)
11316         (foreach_macro_in_scope): Update.
11317         (macro_source_fullname): Return a std::string.
11318         * macrocmd.c (show_pp_source_pos): Update.
11319
11320 2019-02-17  Tom Tromey  <tom@tromey.com>
11321
11322         * macrocmd.c (show_pp_source_pos): Style the file names.
11323
11324 2019-02-17  Tom Tromey  <tom@tromey.com>
11325
11326         PR tui/24197:
11327         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11328
11329 2019-02-17  Tom Tromey  <tom@tromey.com>
11330
11331         * ada-lang.c (user_select_syms): Use filtered printing.
11332         * utils.c (wrap_style): New global.
11333         (desired_style): Remove.
11334         (emit_style_escape): Add stream parameter.
11335         (set_output_style, reset_terminal_style, prompt_for_continue):
11336         Update.
11337         (flush_wrap_buffer): Only flush gdb_stdout.
11338         (wrap_here): Set wrap_style.
11339         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11340         treat escape sequences as a character.  Change when wrap buffer is
11341         flushed.
11342         (fputs_styled): Do not set the output style when the default is
11343         requested.
11344         * ui-style.h (struct ui_file_style) <is_default>: New method.
11345         * source.c (print_source_lines_base): Emit escape sequences in one
11346         piece.
11347
11348 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11349
11350         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11351         integers and enumeration types.
11352
11353 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11354
11355         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11356         instead of lookup_symbol_in_language
11357         (do_exact_match): New function.
11358         (ada_get_symbol_name_matcher): Return do_exact_match when
11359         doing a verbatim match.
11360
11361 2019-02-15  Tom Tromey  <tromey@adacore.com>
11362
11363         * ravenscar-thread.c (ravenscar_thread_target::resume)
11364         (ravenscar_thread_target::wait): Special case wildcard requests.
11365
11366 2019-02-15  Tom Tromey  <tromey@adacore.com>
11367
11368         * ravenscar-thread.c (base_ptid): Remove.
11369         (struct ravenscar_thread_target) <close>: New method.
11370         <m_base_ptid>: New member.
11371         <update_inferior_ptid, active_task, task_is_currently_active,
11372         runtime_initialized>: Declare methods.
11373         <ravenscar_thread_target>: Add constructor.
11374         (ravenscar_thread_target::task_is_currently_active)
11375         (ravenscar_thread_target::update_inferior_ptid)
11376         (ravenscar_runtime_initialized): Rename.  Now methods.
11377         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11378         (ravenscar_thread_target::update_thread_list): Update.
11379         (ravenscar_thread_target::active_task): Now method.
11380         (ravenscar_thread_target::store_registers)
11381         (ravenscar_thread_target::prepare_to_store)
11382         (ravenscar_thread_target::prepare_to_store)
11383         (ravenscar_thread_target::mourn_inferior): Update.
11384         (ravenscar_inferior_created): Use "new" to create target.
11385         (ravenscar_thread_target::get_ada_task_ptid): Update.
11386         (_initialize_ravenscar): Don't initialize base_ptid.
11387         (ravenscar_ops): Remove global.
11388
11389 2019-02-15  Tom Tromey  <tromey@adacore.com>
11390
11391         * target.h (push_target): Declare new overload.
11392         * target.c (push_target): New overload, taking an rvalue reference.
11393         * remote.c (remote_target::open_1): Use push_target overload.
11394         * corelow.c (core_target_open): Use push_target overload.
11395
11396 2019-02-15  Tom Tromey  <tromey@adacore.com>
11397
11398         * ravenscar-thread.c (is_ravenscar_task)
11399         (ravenscar_task_is_currently_active): Return bool.
11400         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11401         (_initialize_ravenscar): Remove "(void)".
11402         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11403         Return bool.
11404
11405 2019-02-15  Tom Tromey  <tromey@adacore.com>
11406
11407         * ravenscar-thread.c (ravenscar_runtime_initializer)
11408         (has_ravenscar_runtime, get_running_thread_id)
11409         (ravenscar_thread_target::resume): Fix indentation.
11410
11411 2019-02-15  Tom Tromey  <tromey@adacore.com>
11412
11413         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11414         from ravenscar_arch_ops.
11415         (sparc_ravenscar_ops::fetch_registers)
11416         (sparc_ravenscar_ops::store_registers): Now methods.
11417         (sparc_ravenscar_prepare_to_store): Remove.
11418         (sparc_ravenscar_ops): Redefine.
11419         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11420         methods and destructor.  Remove members.
11421         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11422         (ravenscar_thread_target::store_registers)
11423         (ravenscar_thread_target::prepare_to_store): Update.
11424         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11425         Remove.
11426         (struct ppc_ravenscar_powerpc_ops): Derive from
11427         ravenscar_arch_ops.
11428         (ppc_ravenscar_powerpc_ops::fetch_registers)
11429         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11430         (ppc_ravenscar_powerpc_ops): Redefine.
11431         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11432         (ppc_ravenscar_e500_ops::fetch_registers)
11433         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11434         (ppc_ravenscar_e500_ops): Redefine.
11435         * aarch64-ravenscar-thread.c
11436         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11437         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11438         (aarch64_ravenscar_fetch_registers)
11439         (aarch64_ravenscar_store_registers): Now methods.
11440         (aarch64_ravenscar_ops): Redefine.
11441
11442 2019-02-15  Tom Tromey  <tromey@adacore.com>
11443
11444         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11445         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11446         (ravenscar_thread_target::stopped_by_watchpoint)
11447         (ravenscar_thread_target::stopped_data_address)
11448         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11449
11450 2019-02-15  Tom Tromey  <tromey@adacore.com>
11451
11452         * ravenscar-thread.c: Fix some typos.
11453
11454 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11455             Tom Tromey  <tromey@adacore.com>
11456
11457         * ada-lang.c (ada_exception_sal): Change addr_string to a
11458         std::string.
11459         (create_ada_exception_catchpoint): Update.
11460
11461 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11462             Tom Tromey  <tromey@adacore.com>
11463
11464         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11465         (bp_location_ops): Remove.
11466         (base_breakpoint_allocate_location): Update.
11467         (free_bp_location): Update.
11468         * ada-lang.c (class ada_catchpoint_location)
11469         <ada_catchpoint_location>: Remove ops parameter.
11470         (ada_catchpoint_location_dtor): Remove.
11471         (ada_catchpoint_location_ops): Remove.
11472         (allocate_location_exception): Update.
11473         * breakpoint.h (struct bp_location_ops): Remove.
11474         (class bp_location) <bp_location>: Remove bp_location_ops
11475         parameter.
11476         <~bp_location>: Add destructor.
11477         <ops>: Remove.
11478
11479 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11480             Pedro Alves  <palves@redhat.com>
11481
11482         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11483         'PATH_MAX'.
11484
11485 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11486             Samuel Thibault  <samuel.thibault@gnu.org>
11487             Thomas Schwinge  <thomas@codesourcery.com>
11488
11489         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11490         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11491
11492 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11493
11494         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11495         (check_empty): Use "const char *".
11496
11497         * gnu-nat.c (gnu_nat_target::detach): Instead of
11498         'detach_inferior (pid)' call
11499         'detach_inferior (find_inferior_pid (pid))'.
11500
11501         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11502         'nat/fork-inferior.o'.
11503         * gnu-nat.c: #include "nat/fork-inferior.h".
11504
11505         * gnu-nat.c (gnu_nat_target::detach): Instead of
11506         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11507         * gnu-nat.h: #include "inf-child.h".
11508         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11509         'i386_gnu_nat_target::fetch_registers'.
11510         (gnu_store_registers): Rename/move to
11511         'i386_gnu_nat_target::store_registers'.
11512
11513         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11514         * gnu-nat.h (mach_thread_info): New function.
11515         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11516
11517         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11518
11519 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11520
11521         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11522
11523 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11524
11525         * windows-nat.c (windows_add_thread): Add new parameter
11526         "main_thread_p" with default value set to false.  Update
11527         function documentation as well as all callers.
11528         (windows_delete_thread): Likewise.
11529         (fake_create_process): Update call to windows_add_thread.
11530         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11531         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11532         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11533         call to windows_delete_thread.
11534
11535 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11536
11537         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11538
11539 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11540
11541         * symfile.c (find_separate_debug_file): Use canonical path of
11542         sysroot with child_path instead of gdb_sysroot if it is valid.
11543
11544 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11545
11546         * symfile.c (find_separate_debug_file): Use child_path to
11547         determine if an object file is under a sysroot.
11548
11549 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11550
11551         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11552         unittests/child-path-selftests.c.
11553         * common/pathstuff.c (child_path): New function.
11554         * common/pathstuff.h (child_path): New prototype.
11555         * unittests/child-path-selftests.c: New file.
11556
11557 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11558
11559         * symfile.c (find_separate_debug_file): Look for separate debug
11560         files in debug directories under the sysroot.
11561
11562 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11563
11564         * symtab.h (struct minimal_symbol data_p): New const method.
11565         (struct minimal_symbol text_p): Likewise.
11566         * symtab.c (output_source_filename): Use file name style
11567         to print file name.
11568         (print_symbol_info): Likewise.
11569         (print_msymbol_info): Use address style to print addresses.
11570         Use function name style to print executable text symbols.
11571         (expand_symtab_containing_pc): Use data_p.
11572         (find_pc_sect_compunit_symtab): Likewise.
11573
11574 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11575
11576         * breakpoint.c (describe_other_breakpoints): Use address style
11577         to print addresses.
11578         (say_where): Likewise.
11579
11580 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11581
11582         * ada-typeprint.c (print_func_type): Print function name
11583         style to print function name.
11584         * c-typeprint.c (c_print_type_1): Likewise.
11585
11586 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11587
11588         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11589         for execve.
11590
11591 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11592
11593         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11594         type_stack.
11595
11596 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11597
11598         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11599         TYPE_CODE_REF types.
11600
11601 2019-02-08  Jim Wilson  <jimw@sifive.com>
11602
11603         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11604         (riscv_linux_fregset): New.
11605         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11606
11607 2019-02-07  Tom Tromey  <tom@tromey.com>
11608
11609         * thread.c (thread_cancel_execution_command): Update.
11610         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11611         methods.
11612         (struct thread_fsm_ops): Remove.
11613         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11614         (thread_fsm_should_stop, thread_fsm_return_value)
11615         (thread_fsm_set_finished, thread_fsm_finished_p)
11616         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11617         Don't declare.
11618         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11619         * infrun.c (clear_proceed_status_thread)
11620         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11621         (print_stop_event): Update.
11622         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11623         Add constructor.
11624         (step_command_fsm_ops): Remove.
11625         (new_step_command_fsm): Remove.
11626         (step_1): Update.
11627         (step_command_fsm::should_stop): Rename from
11628         step_command_fsm_should_stop.
11629         (step_command_fsm::clean_up): Rename from
11630         step_command_fsm_clean_up.
11631         (step_command_fsm::do_async_reply_reason): Rename from
11632         step_command_fsm_async_reply_reason.
11633         (struct until_next_fsm): Inherit from thread_fsm.  Add
11634         constructor.
11635         (until_next_fsm_ops): Remove.
11636         (new_until_next_fsm): Remove.
11637         (until_next_fsm::should_stop): Rename from
11638         until_next_fsm_should_stop.
11639         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11640         (until_next_fsm::do_async_reply_reason): Rename from
11641         until_next_fsm_async_reply_reason.
11642         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11643         constructor.  Change type of breakpoint.
11644         (finish_command_fsm_ops): Remove.
11645         (new_finish_command_fsm): Remove.
11646         (finish_command_fsm::should_stop): Rename from
11647         finish_command_fsm_should_stop.
11648         (finish_command_fsm::clean_up): Rename from
11649         finish_command_fsm_clean_up.
11650         (finish_command_fsm::return_value): Rename from
11651         finish_command_fsm_return_value.
11652         (finish_command_fsm::do_async_reply_reason): Rename from
11653         finish_command_fsm_async_reply_reason.
11654         (finish_command): Update.
11655         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11656         Add constructor.
11657         (call_thread_fsm_ops): Remove.
11658         (call_thread_fsm::call_thread_fsm): Rename from
11659         new_call_thread_fsm.
11660         (call_thread_fsm::should_stop): Rename from
11661         call_thread_fsm_should_stop.
11662         (call_thread_fsm::should_notify_stop): Rename from
11663         call_thread_fsm_should_notify_stop.
11664         (run_inferior_call, call_function_by_hand_dummy): Update.
11665         * cli/cli-interp.c (should_print_stop_to_console): Update.
11666         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11667         Add constructor.  Change type of location_breakpoint,
11668         caller_breakpoint.
11669         (until_break_fsm_ops): Remove.
11670         (new_until_break_fsm): Remove.
11671         (until_break_fsm::should_stop): Rename from
11672         until_break_fsm_should_stop.
11673         (until_break_fsm::clean_up): Rename from
11674         until_break_fsm_clean_up.
11675         (until_break_fsm::do_async_reply_reason): Rename from
11676         until_break_fsm_async_reply_reason.
11677         (until_break_command): Update.
11678         * thread-fsm.c: Remove.
11679         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11680
11681 2019-02-07  Tom Tromey  <tom@tromey.com>
11682
11683         * yy-remap.h: Add include guard.
11684         * xtensa-tdep.h: Add include guard.
11685         * xcoffread.h: Rename include guard.
11686         * varobj-iter.h: Add include guard.
11687         * tui/tui.h: Rename include guard.
11688         * tui/tui-winsource.h: Rename include guard.
11689         * tui/tui-wingeneral.h: Rename include guard.
11690         * tui/tui-windata.h: Rename include guard.
11691         * tui/tui-win.h: Rename include guard.
11692         * tui/tui-stack.h: Rename include guard.
11693         * tui/tui-source.h: Rename include guard.
11694         * tui/tui-regs.h: Rename include guard.
11695         * tui/tui-out.h: Rename include guard.
11696         * tui/tui-layout.h: Rename include guard.
11697         * tui/tui-io.h: Rename include guard.
11698         * tui/tui-hooks.h: Rename include guard.
11699         * tui/tui-file.h: Rename include guard.
11700         * tui/tui-disasm.h: Rename include guard.
11701         * tui/tui-data.h: Rename include guard.
11702         * tui/tui-command.h: Rename include guard.
11703         * tic6x-tdep.h: Add include guard.
11704         * target/waitstatus.h: Rename include guard.
11705         * target/wait.h: Rename include guard.
11706         * target/target.h: Rename include guard.
11707         * target/resume.h: Rename include guard.
11708         * target-float.h: Rename include guard.
11709         * stabsread.h: Add include guard.
11710         * rs6000-tdep.h: Add include guard.
11711         * riscv-fbsd-tdep.h: Add include guard.
11712         * regformats/regdef.h: Rename include guard.
11713         * record.h: Rename include guard.
11714         * python/python.h: Rename include guard.
11715         * python/python-internal.h: Rename include guard.
11716         * python/py-stopevent.h: Rename include guard.
11717         * python/py-ref.h: Rename include guard.
11718         * python/py-record.h: Rename include guard.
11719         * python/py-record-full.h: Rename include guard.
11720         * python/py-record-btrace.h: Rename include guard.
11721         * python/py-instruction.h: Rename include guard.
11722         * python/py-events.h: Rename include guard.
11723         * python/py-event.h: Rename include guard.
11724         * procfs.h: Add include guard.
11725         * proc-utils.h: Add include guard.
11726         * p-lang.h: Add include guard.
11727         * or1k-tdep.h: Rename include guard.
11728         * observable.h: Rename include guard.
11729         * nto-tdep.h: Rename include guard.
11730         * nat/x86-linux.h: Rename include guard.
11731         * nat/x86-linux-dregs.h: Rename include guard.
11732         * nat/x86-gcc-cpuid.h: Add include guard.
11733         * nat/x86-dregs.h: Rename include guard.
11734         * nat/x86-cpuid.h: Rename include guard.
11735         * nat/ppc-linux.h: Rename include guard.
11736         * nat/mips-linux-watch.h: Rename include guard.
11737         * nat/linux-waitpid.h: Rename include guard.
11738         * nat/linux-ptrace.h: Rename include guard.
11739         * nat/linux-procfs.h: Rename include guard.
11740         * nat/linux-osdata.h: Rename include guard.
11741         * nat/linux-nat.h: Rename include guard.
11742         * nat/linux-namespaces.h: Rename include guard.
11743         * nat/linux-btrace.h: Rename include guard.
11744         * nat/glibc_thread_db.h: Rename include guard.
11745         * nat/gdb_thread_db.h: Rename include guard.
11746         * nat/gdb_ptrace.h: Rename include guard.
11747         * nat/fork-inferior.h: Rename include guard.
11748         * nat/amd64-linux-siginfo.h: Rename include guard.
11749         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11750         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11751         * nat/aarch64-linux.h: Rename include guard.
11752         * nat/aarch64-linux-hw-point.h: Rename include guard.
11753         * mn10300-tdep.h: Add include guard.
11754         * mips-linux-tdep.h: Add include guard.
11755         * mi/mi-parse.h: Rename include guard.
11756         * mi/mi-out.h: Rename include guard.
11757         * mi/mi-main.h: Rename include guard.
11758         * mi/mi-interp.h: Rename include guard.
11759         * mi/mi-getopt.h: Rename include guard.
11760         * mi/mi-console.h: Rename include guard.
11761         * mi/mi-common.h: Rename include guard.
11762         * mi/mi-cmds.h: Rename include guard.
11763         * mi/mi-cmd-break.h: Rename include guard.
11764         * m2-lang.h: Add include guard.
11765         * location.h: Rename include guard.
11766         * linux-record.h: Rename include guard.
11767         * linux-nat.h: Add include guard.
11768         * linux-fork.h: Add include guard.
11769         * i386-darwin-tdep.h: Rename include guard.
11770         * hppa-linux-offsets.h: Add include guard.
11771         * guile/guile.h: Rename include guard.
11772         * guile/guile-internal.h: Rename include guard.
11773         * gnu-nat.h: Rename include guard.
11774         * gdb-stabs.h: Rename include guard.
11775         * frv-tdep.h: Add include guard.
11776         * f-lang.h: Add include guard.
11777         * event-loop.h: Add include guard.
11778         * darwin-nat.h: Rename include guard.
11779         * cp-abi.h: Rename include guard.
11780         * config/sparc/nm-sol2.h: Rename include guard.
11781         * config/nm-nto.h: Rename include guard.
11782         * config/nm-linux.h: Add include guard.
11783         * config/i386/nm-i386gnu.h: Rename include guard.
11784         * config/djgpp/nl_types.h: Rename include guard.
11785         * config/djgpp/langinfo.h: Rename include guard.
11786         * compile/gcc-cp-plugin.h: Add include guard.
11787         * compile/gcc-c-plugin.h: Add include guard.
11788         * compile/compile.h: Rename include guard.
11789         * compile/compile-object-run.h: Rename include guard.
11790         * compile/compile-object-load.h: Rename include guard.
11791         * compile/compile-internal.h: Rename include guard.
11792         * compile/compile-cplus.h: Rename include guard.
11793         * compile/compile-c.h: Rename include guard.
11794         * common/xml-utils.h: Rename include guard.
11795         * common/x86-xstate.h: Rename include guard.
11796         * common/version.h: Rename include guard.
11797         * common/vec.h: Rename include guard.
11798         * common/tdesc.h: Rename include guard.
11799         * common/selftest.h: Rename include guard.
11800         * common/scoped_restore.h: Rename include guard.
11801         * common/scoped_mmap.h: Rename include guard.
11802         * common/scoped_fd.h: Rename include guard.
11803         * common/safe-iterator.h: Rename include guard.
11804         * common/run-time-clock.h: Rename include guard.
11805         * common/refcounted-object.h: Rename include guard.
11806         * common/queue.h: Rename include guard.
11807         * common/ptid.h: Rename include guard.
11808         * common/print-utils.h: Rename include guard.
11809         * common/preprocessor.h: Rename include guard.
11810         * common/pathstuff.h: Rename include guard.
11811         * common/observable.h: Rename include guard.
11812         * common/netstuff.h: Rename include guard.
11813         * common/job-control.h: Rename include guard.
11814         * common/host-defs.h: Rename include guard.
11815         * common/gdb_wait.h: Rename include guard.
11816         * common/gdb_vecs.h: Rename include guard.
11817         * common/gdb_unlinker.h: Rename include guard.
11818         * common/gdb_unique_ptr.h: Rename include guard.
11819         * common/gdb_tilde_expand.h: Rename include guard.
11820         * common/gdb_sys_time.h: Rename include guard.
11821         * common/gdb_string_view.h: Rename include guard.
11822         * common/gdb_splay_tree.h: Rename include guard.
11823         * common/gdb_setjmp.h: Rename include guard.
11824         * common/gdb_ref_ptr.h: Rename include guard.
11825         * common/gdb_optional.h: Rename include guard.
11826         * common/gdb_locale.h: Rename include guard.
11827         * common/gdb_assert.h: Rename include guard.
11828         * common/filtered-iterator.h: Rename include guard.
11829         * common/filestuff.h: Rename include guard.
11830         * common/fileio.h: Rename include guard.
11831         * common/environ.h: Rename include guard.
11832         * common/common-utils.h: Rename include guard.
11833         * common/common-types.h: Rename include guard.
11834         * common/common-regcache.h: Rename include guard.
11835         * common/common-inferior.h: Rename include guard.
11836         * common/common-gdbthread.h: Rename include guard.
11837         * common/common-exceptions.h: Rename include guard.
11838         * common/common-defs.h: Rename include guard.
11839         * common/common-debug.h: Rename include guard.
11840         * common/cleanups.h: Rename include guard.
11841         * common/buffer.h: Rename include guard.
11842         * common/btrace-common.h: Rename include guard.
11843         * common/break-common.h: Rename include guard.
11844         * cli/cli-utils.h: Rename include guard.
11845         * cli/cli-style.h: Rename include guard.
11846         * cli/cli-setshow.h: Rename include guard.
11847         * cli/cli-script.h: Rename include guard.
11848         * cli/cli-interp.h: Rename include guard.
11849         * cli/cli-decode.h: Rename include guard.
11850         * cli/cli-cmds.h: Rename include guard.
11851         * charset-list.h: Add include guard.
11852         * buildsym-legacy.h: Rename include guard.
11853         * bfin-tdep.h: Add include guard.
11854         * ax.h: Rename include guard.
11855         * arm-linux-tdep.h: Add include guard.
11856         * arm-fbsd-tdep.h: Add include guard.
11857         * arch/xtensa.h: Rename include guard.
11858         * arch/tic6x.h: Add include guard.
11859         * arch/i386.h: Add include guard.
11860         * arch/arm.h: Rename include guard.
11861         * arch/arm-linux.h: Rename include guard.
11862         * arch/arm-get-next-pcs.h: Rename include guard.
11863         * arch/amd64.h: Add include guard.
11864         * arch/aarch64-insn.h: Rename include guard.
11865         * arch-utils.h: Rename include guard.
11866         * annotate.h: Add include guard.
11867         * amd64-darwin-tdep.h: Rename include guard.
11868         * aarch64-linux-tdep.h: Add include guard.
11869         * aarch64-fbsd-tdep.h: Add include guard.
11870         * aarch32-linux-nat.h: Add include guard.
11871
11872 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11873
11874         * macrotab.c (macro_define_internal): New function that
11875         factorizes macro_define_object_internal and macro_define_function
11876         code.
11877         (macro_define_object_internal): Use macro_define_internal.
11878         (macro_define_function): Likewise.
11879
11880 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11881
11882         * macrocmd.c (extract_identifier): Return
11883         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11884         callers.
11885
11886 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11887
11888         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11889
11890 2019-02-05  Tom Tromey  <tom@tromey.com>
11891
11892         * target.c (target_stack::unpush): Move assertion earlier.
11893
11894 2019-01-30  Tom Tromey  <tom@tromey.com>
11895
11896         PR python/23615:
11897         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11898         (gdbpy_parse_and_eval): Likewise.
11899         * python/python-internal.h (gdbpy_allow_threads): New class.
11900
11901 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11902
11903         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11904         (aarch64_fbsd_fpregmap): Move earlier.
11905         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11906         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11907         instead of individual calls to trad_frame_set_reg_addr.
11908         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11909         earlier.
11910         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11911         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11912         instead of individual calls to trad_frame_set_reg_addr.
11913
11914 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11915
11916         * CONTRIBUTE: Replace contribution list with wiki link.
11917
11918 2019-01-25  Tom Tromey  <tom@tromey.com>
11919
11920         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11921
11922 2019-01-25  Tom Tromey  <tom@tromey.com>
11923
11924         * xtensa-linux-nat.c: Fix common/ includes.
11925         * xml-support.h: Fix common/ includes.
11926         * xml-support.c: Fix common/ includes.
11927         * x86-linux-nat.c: Fix common/ includes.
11928         * windows-nat.c: Fix common/ includes.
11929         * varobj.h: Fix common/ includes.
11930         * varobj.c: Fix common/ includes.
11931         * value.c: Fix common/ includes.
11932         * valops.c: Fix common/ includes.
11933         * utils.c: Fix common/ includes.
11934         * unittests/xml-utils-selftests.c: Fix common/ includes.
11935         * unittests/utils-selftests.c: Fix common/ includes.
11936         * unittests/unpack-selftests.c: Fix common/ includes.
11937         * unittests/tracepoint-selftests.c: Fix common/ includes.
11938         * unittests/style-selftests.c: Fix common/ includes.
11939         * unittests/string_view-selftests.c: Fix common/ includes.
11940         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11941         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11942         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11943         * unittests/rsp-low-selftests.c: Fix common/ includes.
11944         * unittests/parse-connection-spec-selftests.c: Fix common/
11945         includes.
11946         * unittests/optional-selftests.c: Fix common/ includes.
11947         * unittests/offset-type-selftests.c: Fix common/ includes.
11948         * unittests/observable-selftests.c: Fix common/ includes.
11949         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11950         * unittests/memrange-selftests.c: Fix common/ includes.
11951         * unittests/memory-map-selftests.c: Fix common/ includes.
11952         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11953         * unittests/function-view-selftests.c: Fix common/ includes.
11954         * unittests/environ-selftests.c: Fix common/ includes.
11955         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11956         * unittests/common-utils-selftests.c: Fix common/ includes.
11957         * unittests/cli-utils-selftests.c: Fix common/ includes.
11958         * unittests/array-view-selftests.c: Fix common/ includes.
11959         * ui-file.c: Fix common/ includes.
11960         * tui/tui-io.c: Fix common/ includes.
11961         * tracepoint.h: Fix common/ includes.
11962         * tracepoint.c: Fix common/ includes.
11963         * tracefile-tfile.c: Fix common/ includes.
11964         * top.h: Fix common/ includes.
11965         * top.c: Fix common/ includes.
11966         * thread.c: Fix common/ includes.
11967         * target/waitstatus.h: Fix common/ includes.
11968         * target/waitstatus.c: Fix common/ includes.
11969         * target.h: Fix common/ includes.
11970         * target.c: Fix common/ includes.
11971         * target-memory.c: Fix common/ includes.
11972         * target-descriptions.c: Fix common/ includes.
11973         * symtab.h: Fix common/ includes.
11974         * symfile.c: Fix common/ includes.
11975         * stap-probe.c: Fix common/ includes.
11976         * spu-linux-nat.c: Fix common/ includes.
11977         * sparc-nat.c: Fix common/ includes.
11978         * source.c: Fix common/ includes.
11979         * solib.c: Fix common/ includes.
11980         * solib-target.c: Fix common/ includes.
11981         * ser-unix.c: Fix common/ includes.
11982         * ser-tcp.c: Fix common/ includes.
11983         * ser-pipe.c: Fix common/ includes.
11984         * ser-base.c: Fix common/ includes.
11985         * selftest-arch.c: Fix common/ includes.
11986         * s12z-tdep.c: Fix common/ includes.
11987         * rust-exp.y: Fix common/ includes.
11988         * rs6000-aix-tdep.c: Fix common/ includes.
11989         * riscv-tdep.c: Fix common/ includes.
11990         * remote.c: Fix common/ includes.
11991         * remote-notif.h: Fix common/ includes.
11992         * remote-fileio.h: Fix common/ includes.
11993         * remote-fileio.c: Fix common/ includes.
11994         * regcache.h: Fix common/ includes.
11995         * regcache.c: Fix common/ includes.
11996         * record-btrace.c: Fix common/ includes.
11997         * python/python.c: Fix common/ includes.
11998         * python/py-type.c: Fix common/ includes.
11999         * python/py-inferior.c: Fix common/ includes.
12000         * progspace.h: Fix common/ includes.
12001         * producer.c: Fix common/ includes.
12002         * procfs.c: Fix common/ includes.
12003         * proc-api.c: Fix common/ includes.
12004         * printcmd.c: Fix common/ includes.
12005         * ppc-linux-nat.c: Fix common/ includes.
12006         * parser-defs.h: Fix common/ includes.
12007         * osdata.c: Fix common/ includes.
12008         * obsd-nat.c: Fix common/ includes.
12009         * nat/x86-linux.c: Fix common/ includes.
12010         * nat/x86-linux-dregs.c: Fix common/ includes.
12011         * nat/x86-dregs.h: Fix common/ includes.
12012         * nat/x86-dregs.c: Fix common/ includes.
12013         * nat/ppc-linux.c: Fix common/ includes.
12014         * nat/mips-linux-watch.h: Fix common/ includes.
12015         * nat/mips-linux-watch.c: Fix common/ includes.
12016         * nat/linux-waitpid.c: Fix common/ includes.
12017         * nat/linux-ptrace.h: Fix common/ includes.
12018         * nat/linux-ptrace.c: Fix common/ includes.
12019         * nat/linux-procfs.c: Fix common/ includes.
12020         * nat/linux-personality.c: Fix common/ includes.
12021         * nat/linux-osdata.c: Fix common/ includes.
12022         * nat/linux-namespaces.c: Fix common/ includes.
12023         * nat/linux-btrace.h: Fix common/ includes.
12024         * nat/linux-btrace.c: Fix common/ includes.
12025         * nat/fork-inferior.c: Fix common/ includes.
12026         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12027         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12028         * nat/aarch64-linux.c: Fix common/ includes.
12029         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12030         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12031         * namespace.h: Fix common/ includes.
12032         * mips-linux-tdep.c: Fix common/ includes.
12033         * minsyms.c: Fix common/ includes.
12034         * mi/mi-parse.h: Fix common/ includes.
12035         * mi/mi-main.c: Fix common/ includes.
12036         * mi/mi-cmd-env.c: Fix common/ includes.
12037         * memrange.h: Fix common/ includes.
12038         * memattr.c: Fix common/ includes.
12039         * maint.h: Fix common/ includes.
12040         * maint.c: Fix common/ includes.
12041         * main.c: Fix common/ includes.
12042         * machoread.c: Fix common/ includes.
12043         * location.c: Fix common/ includes.
12044         * linux-thread-db.c: Fix common/ includes.
12045         * linux-nat.c: Fix common/ includes.
12046         * linux-fork.c: Fix common/ includes.
12047         * inline-frame.c: Fix common/ includes.
12048         * infrun.c: Fix common/ includes.
12049         * inflow.c: Fix common/ includes.
12050         * inferior.h: Fix common/ includes.
12051         * inferior.c: Fix common/ includes.
12052         * infcmd.c: Fix common/ includes.
12053         * inf-ptrace.c: Fix common/ includes.
12054         * inf-child.c: Fix common/ includes.
12055         * ia64-linux-nat.c: Fix common/ includes.
12056         * i387-tdep.c: Fix common/ includes.
12057         * i386-tdep.c: Fix common/ includes.
12058         * i386-linux-tdep.c: Fix common/ includes.
12059         * i386-linux-nat.c: Fix common/ includes.
12060         * i386-go32-tdep.c: Fix common/ includes.
12061         * i386-fbsd-tdep.c: Fix common/ includes.
12062         * i386-fbsd-nat.c: Fix common/ includes.
12063         * guile/scm-type.c: Fix common/ includes.
12064         * guile/guile.c: Fix common/ includes.
12065         * go32-nat.c: Fix common/ includes.
12066         * gnu-nat.c: Fix common/ includes.
12067         * gdbthread.h: Fix common/ includes.
12068         * gdbarch-selftests.c: Fix common/ includes.
12069         * gdb_usleep.c: Fix common/ includes.
12070         * gdb_select.h: Fix common/ includes.
12071         * gdb_bfd.c: Fix common/ includes.
12072         * gcore.c: Fix common/ includes.
12073         * fork-child.c: Fix common/ includes.
12074         * findvar.c: Fix common/ includes.
12075         * fbsd-nat.c: Fix common/ includes.
12076         * event-top.c: Fix common/ includes.
12077         * event-loop.c: Fix common/ includes.
12078         * dwarf2read.c: Fix common/ includes.
12079         * dwarf2loc.c: Fix common/ includes.
12080         * dwarf2-frame.c: Fix common/ includes.
12081         * dwarf-index-cache.c: Fix common/ includes.
12082         * dtrace-probe.c: Fix common/ includes.
12083         * disasm-selftests.c: Fix common/ includes.
12084         * defs.h: Fix common/ includes.
12085         * csky-tdep.c: Fix common/ includes.
12086         * cp-valprint.c: Fix common/ includes.
12087         * cp-support.h: Fix common/ includes.
12088         * cp-support.c: Fix common/ includes.
12089         * corelow.c: Fix common/ includes.
12090         * completer.h: Fix common/ includes.
12091         * completer.c: Fix common/ includes.
12092         * compile/compile.c: Fix common/ includes.
12093         * compile/compile-loc2c.c: Fix common/ includes.
12094         * compile/compile-cplus-types.c: Fix common/ includes.
12095         * compile/compile-cplus-symbols.c: Fix common/ includes.
12096         * command.h: Fix common/ includes.
12097         * cli/cli-dump.c: Fix common/ includes.
12098         * cli/cli-cmds.c: Fix common/ includes.
12099         * charset.c: Fix common/ includes.
12100         * build-id.c: Fix common/ includes.
12101         * btrace.h: Fix common/ includes.
12102         * btrace.c: Fix common/ includes.
12103         * breakpoint.h: Fix common/ includes.
12104         * breakpoint.c: Fix common/ includes.
12105         * ax.h:
12106         (enum agent_op): Fix common/ includes.
12107         * ax-general.c (struct aop_map): Fix common/ includes.
12108         * ax-gdb.c: Fix common/ includes.
12109         * auxv.c: Fix common/ includes.
12110         * auto-load.c: Fix common/ includes.
12111         * arm-tdep.c: Fix common/ includes.
12112         * arch/riscv.c: Fix common/ includes.
12113         * arch/ppc-linux-common.c: Fix common/ includes.
12114         * arch/i386.c: Fix common/ includes.
12115         * arch/arm.c: Fix common/ includes.
12116         * arch/arm-linux.c: Fix common/ includes.
12117         * arch/arm-get-next-pcs.c: Fix common/ includes.
12118         * arch/amd64.c: Fix common/ includes.
12119         * arch/aarch64.c: Fix common/ includes.
12120         * arch/aarch64-insn.c: Fix common/ includes.
12121         * arch-utils.c: Fix common/ includes.
12122         * amd64-windows-tdep.c: Fix common/ includes.
12123         * amd64-tdep.c: Fix common/ includes.
12124         * amd64-sol2-tdep.c: Fix common/ includes.
12125         * amd64-obsd-tdep.c: Fix common/ includes.
12126         * amd64-nbsd-tdep.c: Fix common/ includes.
12127         * amd64-linux-tdep.c: Fix common/ includes.
12128         * amd64-linux-nat.c: Fix common/ includes.
12129         * amd64-fbsd-tdep.c: Fix common/ includes.
12130         * amd64-fbsd-nat.c: Fix common/ includes.
12131         * amd64-dicos-tdep.c: Fix common/ includes.
12132         * amd64-darwin-tdep.c: Fix common/ includes.
12133         * agent.c: Fix common/ includes.
12134         * ada-lang.h: Fix common/ includes.
12135         * ada-lang.c: Fix common/ includes.
12136         * aarch64-tdep.c: Fix common/ includes.
12137
12138 2019-01-25  Tom Tromey  <tom@tromey.com>
12139
12140         * common/create-version.sh: Use common/version.h.
12141
12142 2019-01-24  Pedro Alves  <palves@redhat.com>
12143
12144         * infrun.c (signal_stop, signal_print, signal_program)
12145         (signal_catch, signal_pass): Now arrays instead of pointers.
12146         (update_signals_program_target, do_target_resume)
12147         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12148         * linux-nat.c (linux_nat_target::pass_signals)
12149         (linux_nat_target::create_inferior, linux_nat_target::attach):
12150         Adjust.
12151         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12152         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12153         * procfs.c (procfs_target::pass_signals): Adjust.
12154         * record-full.c (record_full_target::resume): Adjust.
12155         * remote.c (remote_target::pass_signals)
12156         (remote_target::program_signals): Adjust.
12157         * target-debug.h (target_debug_print_signals): Now takes a
12158         gdb::array_view as parameter.  Adjust.
12159         * target.h (target_ops) <pass_signals, program_signals>: Replace
12160         pointer and length parameters with gdb::array_view.
12161         (target_pass_signals, target_program_signals): Likewise.
12162         * target-delegates.c: Regenerate.
12163
12164 2019-01-24  Pedro Alves  <palves@redhat.com>
12165
12166         * common/forward-scope-exit.h
12167         (forward_scope_exit::forward_scope_exit): Pass arguments to
12168         m_bind_function directly, instead of creating a std::bind and
12169         copying that.
12170
12171 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12172
12173         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12174         for static members.
12175         (pass_in_v_vfp_candidate): Likewise.
12176
12177 2019-01-23  Tom Tromey  <tom@tromey.com>
12178             Pedro Alves  <palves@redhat.com>
12179
12180         * regcache.c (class regcache_invalidator): Remove.
12181         (regcache::raw_write): Use make_scope_exit.
12182
12183 2019-01-23  Tom Tromey  <tom@tromey.com>
12184
12185         * ui-out.h (class ui_out_emit_type): Update comment.
12186
12187 2019-01-23  Tom Tromey  <tom@tromey.com>
12188
12189         * infrun.c (fetch_inferior_event): Update comment.
12190
12191 2019-01-23  Tom Tromey  <tom@tromey.com>
12192             Pedro Alves  <palves@redhat.com>
12193
12194         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12195         parameter.
12196         (fetch_inferior_event): Use SCOPE_EXIT.
12197
12198
12199 2019-01-23  Tom Tromey  <tom@tromey.com>
12200             Pedro Alves  <palves@redhat.com>
12201
12202         * infrun.c (disable_thread_events): Delete.
12203         (stop_all_threads): Use SCOPE_EXIT.
12204
12205 2019-01-23  Tom Tromey  <tom@tromey.com>
12206             Pedro Alves  <palves@redhat.com>
12207
12208         * symfile.c: Include forward-scope-exit.h.
12209         (clear_symtab_users_cleanup): Replace forward declaration with
12210         a FORWARD_SCOPE_EXIT.
12211         (syms_from_objfile_1): Use the forward_scope_exit and
12212         gdb::optional instead of cleanup_function.
12213         (reread_symbols): Use the forward_scope_exit instead of
12214         cleanup_function.
12215         (clear_symtab_users_cleanup): Remove function.
12216
12217 2019-01-23  Tom Tromey  <tom@tromey.com>
12218             Pedro Alves  <palves@redhat.com>
12219
12220         * linux-nat.c: Include scope-exit.h.
12221         (cleanup_target_stop): Remove.
12222         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12223         SCOPE_EXIT.
12224
12225 2019-01-23  Tom Tromey  <tom@tromey.com>
12226             Pedro Alves  <palves@redhat.com>
12227
12228         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12229         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12230
12231 2019-01-23  Tom Tromey  <tom@tromey.com>
12232             Andrew Burgess  <andrew.burgess@embecosm.com>
12233             Pedro Alves  <palves@redhat.com>
12234
12235         * infrun.c (fetch_inferior_event): Use scope_exit.
12236         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12237         * top.c (execute_command): Use scope_exit.
12238         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12239         * utils.c (do_bpstat_clear_actions_cleanup)
12240         (make_bpstat_clear_actions_cleanup): Remove.
12241
12242 2019-01-23  Tom Tromey  <tom@tromey.com>
12243             Pedro Alves  <palves@redhat.com>
12244
12245         * infrun.c: Include "common/scope-exit.h"
12246         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12247         (wait_for_inferior): Use SCOPE_EXIT.
12248         (fetch_inferior_event): Use scope_exit.
12249
12250 2019-01-23  Tom Tromey  <tom@tromey.com>
12251             Pedro Alves  <palves@redhat.com>
12252
12253         * breakpoint.c (create_breakpoint): Remove cleanup.
12254
12255 2019-01-23  Tom Tromey  <tom@tromey.com>
12256             Andrew Burgess  <andrew.burgess@embecosm.com>
12257             Pedro Alves  <palves@redhat.com>
12258
12259 2019-01-23  Pedro Alves  <palves@redhat.com>
12260
12261         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12262
12263 2019-01-23  Pedro Alves  <palves@redhat.com>
12264             Andrew Burgess  <andrew.burgess@embecosm.com>
12265
12266         * gdbthread.h: Include "common/forward-scope-exit.h".
12267         (scoped_finish_thread_state): Redefine custom class in terms of
12268         forward_scope_exit.
12269
12270 2019-01-23  Pedro Alves  <palves@redhat.com>
12271             Andrew Burgess  <andrew.burgess@embecosm.com>
12272
12273         * common/forward-scope-exit.h: New file.
12274
12275 2019-01-23  Pedro Alves  <palves@redhat.com>
12276             Andrew Burgess  <andrew.burgess@embecosm.com>
12277             Tom Tromey  <tom@tromey.com>
12278
12279         * common/scope-exit.h: New file.
12280
12281 2019-01-23  Pedro Alves  <palves@redhat.com>
12282
12283         * common/preprocessor.h (ESC): Rename to ...
12284         (ESC_PARENS): ... this.
12285         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12286         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12287
12288 2019-01-23  Tom Tromey  <tom@tromey.com>
12289
12290         * language.h (class scoped_switch_to_sym_language_if_auto):
12291         Initialize m_lang in both cases.
12292
12293 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12294
12295         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12296         with XCNEW.
12297
12298 2019-01-22  Tom Tromey  <tom@tromey.com>
12299
12300         * corelow.c: Do not include sys/file.h.
12301
12302 2019-01-22  Tom Tromey  <tom@tromey.com>
12303
12304         * tui/tui-wingeneral.h: Include gdb_curses.h.
12305
12306 2019-01-22  Tom Tromey  <tom@tromey.com>
12307
12308         * source-cache.h (class source_cache) <get_source_lines,
12309         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12310
12311 2019-01-22  Tom Tromey  <tom@tromey.com>
12312
12313         * remote-fileio.h (struct remote_target): Declare.
12314
12315 2019-01-22  Tom Tromey  <tom@tromey.com>
12316
12317         * python/py-arch.c: Do not include py-ref.h.
12318         * python/py-bpevent.c: Do not include py-ref.h.
12319         * python/py-cmd.c: Do not include py-ref.h.
12320         * python/py-continueevent.c: Do not include py-ref.h.
12321         * python/py-event.h: Do not include py-ref.h.
12322         * python/py-evtregistry.c: Do not include py-ref.h.
12323         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12324         * python/py-frame.c: Do not include py-ref.h.
12325         * python/py-framefilter.c: Do not include py-ref.h.
12326         * python/py-function.c: Do not include py-ref.h.
12327         * python/py-infevents.c: Do not include py-ref.h.
12328         * python/py-linetable.c: Do not include py-ref.h.
12329         * python/py-objfile.c: Do not include py-ref.h.
12330         * python/py-param.c: Do not include py-ref.h.
12331         * python/py-prettyprint.c: Do not include py-ref.h.
12332         * python/py-progspace.c: Do not include py-ref.h.
12333         * python/py-symbol.c: Do not include py-ref.h.
12334         * python/py-symtab.c: Do not include py-ref.h.
12335         * python/py-type.c: Do not include py-ref.h.
12336         * python/py-unwind.c: Do not include py-ref.h.
12337         * python/py-utils.c: Do not include py-ref.h.
12338         * python/py-value.c: Do not include py-ref.h.
12339         * python/py-varobj.c: Do not include py-ref.h.
12340         * python/py-xmethods.c: Do not include py-ref.h.
12341         * python/python.c: Do not include py-ref.h.
12342         * varobj.c: Do not include py-ref.h.
12343
12344 2019-01-22  Tom Tromey  <tom@tromey.com>
12345
12346         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12347         keyword for bcache.
12348
12349 2019-01-22  Tom Tromey  <tom@tromey.com>
12350
12351         * compile/compile-cplus-types.c: Remove a comment by #include.
12352
12353 2019-01-22  Tom Tromey  <tom@tromey.com>
12354
12355         * compile/gcc-c-plugin.h: Include compile-internal.h.
12356
12357 2019-01-22  Tom Tromey  <tom@tromey.com>
12358
12359         * stabsread.c (EXTERN): Do not define.
12360         (symnum, next_symbol_text_func, processing_gcc_compilation)
12361         (within_function, global_sym_chain, global_stabs)
12362         (previous_stab_code, this_object_header_files)
12363         (n_this_object_header_files)
12364         (n_allocated_this_object_header_files): Define.
12365         * stabsread.h (EXTERN): Never define.  Use "extern".
12366
12367 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12368
12369         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12370         history_value.
12371
12372 2019-01-21  Tom Tromey  <tom@tromey.com>
12373
12374         * ui-out.c: Fix includes.
12375         * tui/tui-source.c: Fix includes.
12376         * target.c: Fix includes.
12377         * remote.c: Fix includes.
12378         * regcache.c: Fix includes.
12379         * python/py-block.c: Fix includes.
12380         * printcmd.c: Fix includes.
12381         * or1k-tdep.c: Fix includes.
12382         * mi/mi-main.c: Fix includes.
12383         * m32r-tdep.c: Fix includes.
12384         * csky-tdep.c: Fix includes.
12385         * compile/compile-cplus-types.c: Fix includes.
12386         * cli/cli-interp.c: Fix includes.
12387
12388 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12389
12390         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12391         for padding.
12392
12393 2019-01-16  Tom Tromey  <tom@tromey.com>
12394
12395         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12396         earlier.
12397         (struct objfile) <msymbols_range>: Move from top level.
12398         <msymbols>: New method.
12399         (class objfile_msymbols): Remove.
12400         * symtab.c (default_collect_symbol_completion_matches_break_on):
12401         Update.
12402         * symmisc.c (dump_msymbols): Update.
12403         * stabsread.c (scan_file_globals): Update.
12404         * objc-lang.c (info_selectors_command, info_classes_command)
12405         (find_methods): Update.
12406         * minsyms.c (find_solib_trampoline_target): Update.
12407         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12408         * coffread.c (coff_symfile_read): Update.
12409         * ada-lang.c (ada_lookup_simple_minsym)
12410         (ada_collect_symbol_completion_matches): Update.
12411
12412 2019-01-16  Tom Tromey  <tom@tromey.com>
12413
12414         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12415         type.  Remove no-argument constructor.
12416         <iterator::operator++>: Simplify.
12417         <begin>: Update.
12418         <end>: Use minimal_symbol_count.
12419
12420 2019-01-16  Tom Tromey  <tom@tromey.com>
12421
12422         * objfiles.h (struct objfile) <psymtabs>: New method.
12423         (class objfile_psymtabs): Remove.
12424         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12425         typedef.
12426         <range>: New method.
12427         (require_partial_symbols): Change return type.
12428         * psymtab.c (require_partial_symbols)
12429         (psym_expand_symtabs_matching): Update.
12430         * mdebugread.c (parse_partial_symbols): Update.
12431         * dbxread.c (dbx_end_psymtab): Update.
12432
12433 2019-01-15  Tom Tromey  <tom@tromey.com>
12434
12435         * symtab.c (lookup_objfile_from_block)
12436         (lookup_symbol_in_objfile_symtabs)
12437         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12438         (find_line_symtab, info_sources_command)
12439         (default_collect_symbol_completion_matches_break_on)
12440         (make_source_files_completion_list): Update.
12441         * symmisc.c (print_objfile_statistics, dump_objfile)
12442         (maintenance_print_symbols, maintenance_info_symtabs)
12443         (maintenance_check_symtabs, maintenance_info_line_tables):
12444         Update.
12445         * source.c (select_source_symtab)
12446         (forget_cached_source_info_for_objfile): Update.
12447         * objfiles.h (class objfile_compunits): Remove.
12448         (struct objfile) <compunits_range>: New typedef.
12449         (compunits): New method.
12450         * objfiles.c (objfile_relocate1): Update.
12451         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12452         * maint.c (count_symtabs_and_blocks): Update.
12453         * linespec.c (iterate_over_all_matching_symtabs): Update.
12454         * cp-support.c (add_symbol_overload_list_qualified): Update.
12455         * coffread.c (coff_symtab_read): Update.
12456         * ada-lang.c (add_nonlocal_symbols)
12457         (ada_collect_symbol_completion_matches)
12458         (ada_add_global_exceptions): Update.
12459
12460 2019-01-15  Tom Tromey  <tom@tromey.com>
12461
12462         * progspace.h (program_space) <objfiles_safe_range>: New
12463         typedef.
12464         <objfiles_safe>: New method.
12465         * objfiles.h (class all_objfiles_safe): Remove.
12466         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12467         * jit.c (jit_inferior_exit_hook): Update.
12468
12469 2019-01-17  Tom Tromey  <tom@tromey.com>
12470
12471         * progspace.h (program_space) <objfiles_range>: New typedef.
12472         <objfiles>: New method.
12473         <objfiles_head>: Rename from objfiles.
12474         (object_files): Update.
12475         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12476         * guile/scm-pretty-print.c
12477         (ppscm_find_pretty_printer_from_objfiles): Update.
12478         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12479         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12480         Update.
12481         * python/py-progspace.c (pspy_get_objfiles): Update.
12482         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12483         Update.
12484         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12485         (objfpy_lookup_objfile_by_build_id): Update.
12486         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12487         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12488         Update.
12489         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12490         (expand_symtab_containing_pc, lookup_objfile_from_block)
12491         (lookup_static_symbol, basic_lookup_transparent_type)
12492         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12493         (find_line_symtab, info_sources_command)
12494         (default_collect_symbol_completion_matches_break_on)
12495         (make_source_files_completion_list, find_main_name): Update.
12496         * symmisc.c (print_symbol_bcache_statistics)
12497         (print_objfile_statistics, maintenance_print_symbols)
12498         (maintenance_print_msymbols, maintenance_print_objfiles)
12499         (maintenance_info_symtabs, maintenance_check_symtabs)
12500         (maintenance_expand_symtabs, maintenance_info_line_tables):
12501         Update.
12502         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12503         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12504         (map_overlay_command, unmap_overlay_command)
12505         (simple_overlay_update, expand_symtabs_matching)
12506         (map_symbol_filenames): Update.
12507         * symfile-debug.c (set_debug_symfile): Update.
12508         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12509         Update.
12510         * source.c (select_source_symtab, forget_cached_source_info):
12511         Update.
12512         * solib.c (solib_read_symbols): Update.
12513         * solib-spu.c (append_ocl_sos): Update.
12514         * psymtab.c (maintenance_print_psymbols)
12515         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12516         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12517         * printcmd.c (info_symbol_command): Update.
12518         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12519         Update.
12520         * objfiles.h (class all_objfiles): Remove.
12521         * objfiles.c (have_partial_symbols, have_full_symbols)
12522         (have_minimal_symbols, qsort_cmp, update_section_map)
12523         (shared_objfile_contains_address_p)
12524         (default_iterate_over_objfiles_in_search_order): Update.
12525         * objc-lang.c (info_selectors_command, info_classes_command)
12526         (find_methods): Update.
12527         * minsyms.c (find_solib_trampoline_target): Update.
12528         * maint.c (maintenance_info_sections)
12529         (maintenance_translate_address, count_symtabs_and_blocks):
12530         Update.
12531         * main.c (captured_main_1): Update.
12532         * linux-thread-db.c (try_thread_db_load_from_pdir)
12533         (has_libpthread): Update.
12534         * linespec.c (iterate_over_all_matching_symtabs)
12535         (search_minsyms_for_name): Update.
12536         * jit.c (jit_find_objf_with_entry_addr): Update.
12537         * hppa-tdep.c (find_unwind_entry)
12538         (hppa_lookup_stub_minimal_symbol): Update.
12539         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12540         Update.
12541         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12542         (elf_gnu_ifunc_resolve_by_got): Update.
12543         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12544         * dwarf-index-write.c (save_gdb_index_command): Update.
12545         * cp-support.c (add_symbol_overload_list_qualified): Update.
12546         * breakpoint.c (create_overlay_event_breakpoint)
12547         (create_longjmp_master_breakpoint)
12548         (create_std_terminate_master_breakpoint)
12549         (create_exception_master_breakpoint): Update.
12550         * blockframe.c (find_pc_partial_function): Update.
12551         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12552         (ada_collect_symbol_completion_matches)
12553         (ada_add_global_exceptions): Update.
12554
12555 2019-01-17  Tom Tromey  <tom@tromey.com>
12556
12557         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12558         declare VEC.
12559         (solib_target_parse_libraries): Change return type.
12560         (library_list_start_segment, library_list_start_section)
12561         (library_list_end_library, library_list_start_library); Update.
12562         (solib_target_free_library_list): Remove.
12563         (solib_target_parse_libraries): Remove cleanup.  Change return
12564         type.
12565         (solib_target_current_sos): Update.
12566
12567 2019-01-17  Tom Tromey  <tromey@bapiya>
12568
12569         * valprint.c: Replace "the the" with "the".
12570         * symtab.c: Replace "the the" with "the".
12571         * solib.c: Replace "the the" with "the".
12572         * solib-dsbt.c: Replace "the the" with "the".
12573         * linespec.c: Replace "the the" with "the".
12574         * dwarf2loc.h: Replace "the the" with "the".
12575         * amd64-windows-tdep.c: Replace "the the" with "the".
12576         * aarch64-tdep.c: Replace "the the" with "the".
12577
12578 2019-01-16  Keith Seitz  <keiths@redhat.com>
12579
12580         PR gdb/23773
12581         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12582         <builder>: Rename to ..
12583         <m_builder>: ... this and make private.
12584         (dwarf2_cu::get_builder): New method.  Change all users of
12585         `builder' to use this method.
12586         (dwarf2_start_symtab): Move to ...
12587         (dwarf2_cu::start_symtab): ... here.  Update all callers
12588         (setup_type_unit_groups): Move to ...
12589         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12590         callers.
12591         (dwarf2_cu::reset_builder): New method.
12592         (process_full_compunit, process_full_type_unit): Use
12593         dwarf2_cu::reset_builder.
12594         (follow_die_offset): Record the ancestor CU if it is different
12595         from the followed DIE's CU.
12596         (follow_die_sig_1): Likewise.
12597
12598 2019-01-15  Tom Tromey  <tom@tromey.com>
12599
12600         * remote.c (class remote_state) <buf>: Now a char_vector.
12601         <buf_size>: Remove.
12602         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12603         parameter.
12604         (remote_target::getpkt_or_notif_sane_1)
12605         (remote_target::getpkt_sane)
12606         (remote_target::getpkt_or_notif_sane): Likewise.
12607         (class remote_target) <putpkt>: New overload.
12608         (remote_target::read_frame): Change type of "buf_p".  Remove
12609         sizeof_p parameter.
12610         (packet_ok): New overload.
12611         (packet_check_result): New overload.
12612         Update all uses.
12613
12614 2019-01-14  Tom Tromey  <tom@tromey.com>
12615
12616         * remote-notif.c (handle_notification, remote_notif_ack)
12617         (remote_notif_parse): Make "buf" const.
12618         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12619         const.
12620         (remote_notif_parse, remote_notif_ack, handle_notification):
12621         Likewise.
12622         * remote.c (remote_notif_stop_parse): Make "buf" const.
12623         (remote_target::remote_parse_stop_reply): Make "buf" const.
12624         (remote_notif_stop_ack): Make "buf" const.
12625
12626 2019-01-14  Tom Tromey  <tom@tromey.com>
12627
12628         * remote.c (remote_console_output): Make parameter const.
12629
12630 2019-01-14  Tom Tromey  <tom@tromey.com>
12631
12632         * target-debug.h (target_debug_print_signals): Constify.
12633         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12634         * procfs.c (procfs_target::pass_signals): Update.
12635         * linux-nat.c (linux_nat_target::pass_signals): Update.
12636         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12637         * target-delegates.c: Rebuild.
12638         * remote.c (remote_target::program_signals): Update.
12639         (remote_target::pass_signals): Update.
12640         * target.c (target_pass_signals): Constify argument.
12641         (target_program_signals): Likewise.
12642         * target.h (struct target_ops) <pass_signals, program_signals>:
12643         Constify argument.
12644         (target_pass_signals, target_program_signals): Constify argument.
12645
12646 2019-01-14  Tom Tromey  <tom@tromey.com>
12647
12648         PR tui/28819:
12649         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12650
12651 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12652
12653         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12654         field.
12655         * rs6000-tdep.c: Include reggroups.h.
12656         (IS_V_ALIAS_PSEUDOREG): Define.
12657         (rs6000_register_name): Return names for the "vX" aliases.
12658         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12659         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12660         aliases.  Call default_register_reggroup_p for all other
12661         pseudo-registers.
12662         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12663         New functions.
12664         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12665         Handle "vX" aliases.
12666         (v_alias_pseudo_register_collect): New function.
12667         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12668         (rs6000_gdbarch_init): Initialize "vX" aliases as
12669         pseudo-registers.  Restore registration of
12670         rs6000_pseudo_register_reggroup_p with
12671         set_tdesc_pseudo_register_reggroup_p.
12672
12673 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12674
12675         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12676         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12677         set_gdbarch_num_pseudo_regs.
12678
12679 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12680
12681         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12682         Remove arg prefixname, add do_set and do_show.
12683         Add member functions set_list and show_list.
12684         * cli/cli-style.c (class cli_style_option): Update accordingly.
12685         (style_set_list): Move to file scope.
12686         (style_show_list): Likewise.
12687         (set_style): Call help_list.
12688         (show_style): Call cmd_show_list.
12689         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12690         Update to use the new macro.
12691
12692 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12693
12694         * ada-lang.c (_initialize_ada_language): Expand the help text
12695         for the "catch exception" command.
12696
12697 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12698
12699         * symtab.c (matching_obj_sections): Initialize obj,
12700         declare it closer to its usage.
12701
12702 2019-01-10  Tom Tromey  <tom@tromey.com>
12703
12704         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12705         (basic_inf_threads_range): Remove.
12706         (inf_threads_range, inf_non_exited_threads_range)
12707         (safe_inf_threads_range): Use next_adapter.
12708
12709 2019-01-10  Keith Seitz  <keiths@redhat.com>
12710
12711         PR gdb/23712
12712         PR symtab/23010
12713         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12714         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12715
12716 2019-01-10  Keith Seitz  <keiths@redhat.com>
12717
12718         PR gdb/23712
12719         PR symtab/23010
12720         * dictionary.c (pending_to_vector): Remove.
12721         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12722         Remove _1 suffix, replacing functions of the same name.  Update
12723         all callers.
12724         (dict_create_hashed, dict_create_hashed_expandable)
12725         (dict_create_linear, dict_create_linear_expandable, dict_free)
12726         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12727         Make functions static.
12728
12729 2019-01-10  Keith Seitz  <keiths@redhat.com>
12730
12731         PR gdb/23712
12732         PR symtab/23010
12733         * dictionary.h (struct dictionary): Replace declaration with
12734         multidictionary.
12735         (dict_create_hashed, dict_create_hashed_expandable)
12736         (dict_create_linear, dict_create_linear_expandable)
12737         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12738         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12739         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12740         taking multidictionary argument.
12741         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12742         * block.h (struct block) <dict>: Change to multidictionary
12743         and rename `multidict'.
12744         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12745         symmisc.c: Update all dictionary references to multidictionary.
12746
12747 2019-01-10  Keith Seitz  <keiths@redhat.com>
12748
12749         PR gdb/23712
12750         PR symtab/23010
12751         * dictionary.c: Include unordered_map.
12752         (pending_to_vector): New function.
12753         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12754         Rewrite the non-"_1" functions to take vector instead
12755         of linked list.
12756         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12757         "new" _1 versions of the same name.
12758         (multidictionary): Define.
12759         (std::hash<enum language): New definition.
12760         (collate_pending_symbols_by_language, mdict_create_hashed)
12761         (mdict_create_hashed_expandable, mdict_create_linear)
12762         (mdict_create_linear_expandable, mdict_free)
12763         (find_language_dictionary, create_new_language_dictionary)
12764         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12765         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12766         (mdict_size, mdict_empty): New functions.
12767         * dictionary.h (mdict_iterator): Define.
12768
12769 2019-01-10  Pedro Alves  <palves@redhat.com>
12770
12771         * breakpoint.c (read_uploaded_action)
12772         (create_tracepoint_from_upload): Adjust to use
12773         gdb::unique_xmalloc_ptr.
12774         * ctf.c (ctf_write_uploaded_tp):
12775         (SET_ARRAY_FIELD): Use emplace_back.
12776         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12777         * tracefile-tfile.c (tfile_write_uploaded_tp):
12778         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12779         gdb::unique_xmalloc_ptr.
12780         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12781         at_string, cond_string, cmd_strings>: Replace char pointers
12782         with gdb::unique_xmalloc_ptr.
12783
12784 2019-01-10  Pedro Alves  <palves@redhat.com>
12785
12786         * solib-target.c (library_list_start_library): Don't xstrdup name.
12787
12788 2019-01-10  Pedro Alves  <palves@redhat.com>
12789
12790         * mdebugread.c (parse_partial_symbols): Use
12791         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12792
12793 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12794
12795         * linux-fork.c (scoped_switch_fork_info)
12796         <~scoped_switch_fork_info>: Fix incorrect variable name.
12797
12798 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12799
12800         * linux-fork.c (scoped_switch_fork_info)
12801         <scoped_switch_fork_info>: Make explicit.
12802         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12803
12804 2019-01-10  Tom Tromey  <tom@tromey.com>
12805
12806         * objfiles.h (objfile::reset_psymtabs): Update.
12807         * objfiles.c (objfile::objfile): Update.
12808         * psymtab.h (psymtab_storage::obstack): Update.
12809         (psymtab_storage::m_obstack): Use gdb::optional.
12810         (class psymtab_storage): Update comment.  Remove objfile
12811         parameter.
12812         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12813
12814 2019-01-10  Tom Tromey  <tom@tromey.com>
12815
12816         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12817         <free_psymtabs>: Now private.
12818         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12819         (allocate_psymtab): Use new method.
12820
12821 2019-01-10  Tom Tromey  <tom@tromey.com>
12822
12823         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12824         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12825         * mdebugread.c (parse_partial_symbols): Use
12826         allocate_dependencies.
12827         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12828         allocate_dependencies.
12829         (process_psymtab_comp_unit_reader)
12830         (build_type_psymtab_dependencies): Likewise.
12831         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12832
12833 2019-01-10  Tom Tromey  <tom@tromey.com>
12834
12835         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12836         PSYMBOL_SET_LANGUAGE.
12837         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12838
12839 2019-01-10  Tom Tromey  <tom@tromey.com>
12840
12841         * psymtab.h (psymtab_storage::obstack): New method.
12842         <m_obstack>: Rename from obstack; now private.
12843         * psymtab.c (psymtab_storage): Update.
12844         * dwarf2read.c (create_addrmap_from_index)
12845         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12846         Update.
12847
12848 2019-01-10  Tom Tromey  <tom@tromey.com>
12849
12850         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12851         * objfiles.h (objfile::reset_psymtabs): New method.
12852
12853 2019-01-10  Tom Tromey  <tom@tromey.com>
12854
12855         * symmisc.c (print_symbol_bcache_statistics): Update.
12856         (print_objfile_statistics): Update.
12857         * symfile.c (reread_symbols): Update.
12858         * psymtab.h (class psymtab_storage): New.
12859         * psymtab.c (psymtab_storage): New constructor.
12860         (~psymtab_storage): New destructor.
12861         (require_partial_symbols): Update.
12862         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12863         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12864         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12865         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12866         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12867         (start_psymtab_common, end_psymtab_common)
12868         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12869         (allocate_psymtab): Update.
12870         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12871         Update.
12872         (dump_psymtab_addrmap, maintenance_print_psymbols)
12873         (maintenance_check_psymtabs): Update.
12874         (class objfile_psymtabs): Move to objfiles.h.
12875         * psympriv.h (discard_psymtab): Now inline.
12876         (psymtab_discarder::psymtab_discarder): Update.
12877         (psymtab_discarder::~psymtab_discarder): Update.
12878         (ALL_OBJFILE_PSYMTABS): Rewrite.
12879         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12880         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12881         Remove fields.
12882         <partial_symtabs>: New field.
12883         (class objfile_psymtabs): Move from psymtab.h.  Update.
12884         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12885         psymbol_cache.
12886         (objfile::~objfile): Don't destroy psymbol_cache.
12887         * mdebugread.c (parse_partial_symbols): Update.
12888         * dwarf2read.c (create_addrmap_from_index)
12889         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12890         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12891         (add_partial_subprogram, dwarf2_ranges_read): Update.
12892         * dwarf-index-write.c (write_address_map)
12893         (write_one_signatured_type, recursively_write_psymbols)
12894         (class debug_names, class debug_names, write_psymtabs_to_index):
12895         Update.
12896
12897 2019-01-10  Tom Tromey  <tom@tromey.com>
12898
12899         * symtab.h (SYMBOL_SET_NAMES): Update.
12900         (symbol_set_names): Update.
12901         (MSYMBOL_SET_NAMES): Update.
12902         * symtab.c (symbol_set_names): Change argument to be an
12903         objfile_per_bfd_storage.
12904         * psymtab.c (add_psymbol_to_bcache): Update.
12905         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12906
12907 2019-01-10  Tom Tromey  <tom@tromey.com>
12908
12909         * symtab.c (create_demangled_names_hash): Change argument to be an
12910         objfile_per_bfd_storage.
12911         (symbol_set_names): Update.
12912
12913 2019-01-10  Tom Tromey  <tom@tromey.com>
12914
12915         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12916         init_psymbol_list.
12917         * psymtab.c (init_psymbol_list): Do nothing if already called.
12918         * psympriv.h (init_psymbol_list): Add comment.
12919         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12920         init_psymbol_list.
12921         * dbxread.c (dbx_symfile_read): Unconditionally call
12922         init_psymbol_list.
12923
12924 2019-01-10  Tom Tromey  <tom@tromey.com>
12925
12926         * xcoffread.c (scan_xcoff_symtab): Update.
12927         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12928         "where".
12929         * mdebugread.c (parse_partial_symbols)
12930         (handle_psymbol_enumerators): Update.
12931         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12932         * dbxread.c (read_dbx_symtab): Update.
12933         * psympriv.h (psymbol_placement): New enum.
12934         (add_psymbol_to_list): Update.
12935
12936 2019-01-10  Tom Tromey  <tom@tromey.com>
12937
12938         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12939         static_psymbols parameters.
12940         (scan_xcoff_symtab): Update.
12941         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12942         static_psymbols parameters.
12943         * psympriv.h (start_psymtab_common): Update.
12944         * mdebugread.c (parse_partial_symbols): Update.
12945         * dwarf2read.c (create_partial_symtab): Update.
12946         * dbxread.c (read_dbx_symtab): Update.
12947         (start_psymtab): Remove global_psymbols and static_psymbols
12948         parameters.
12949
12950 2019-01-10  Tom Tromey  <tom@tromey.com>
12951
12952         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12953         * psymtab.c (allocate_psymtab): Add comment.
12954         * psympriv.h (allocate_psymtab): Add comment.
12955         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12956         initializations.
12957         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12958
12959 2019-01-10  Tom Tromey  <tom@tromey.com>
12960
12961         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12962         Don't declare.
12963         * mipsread.c: Include mdebugread.h.
12964         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12965         Declare.
12966         * elfread.c: Include mdebugread.h.
12967
12968 2019-01-09  Tom Tromey  <tom@tromey.com>
12969
12970         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12971         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12972         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12973         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12974         (psym_lookup_symbol, psym_find_last_source_symtab)
12975         (psym_forget_cached_source_info, psym_print_stats)
12976         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12977         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12978         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12979         (psym_find_compunit_symtab_by_address)
12980         (maintenance_print_psymbols, maintenance_info_psymtabs)
12981         (maintenance_check_psymtabs): Use ranged for.
12982         * psymtab.h (class objfile_psymtabs): New.
12983         (require_partial_symbols): Return objfile_psymtabs.
12984         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12985
12986 2019-01-09  Tom Tromey  <tom@tromey.com>
12987
12988         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12989         (find_pc_mapped_section, list_overlays_command)
12990         (map_overlay_command, unmap_overlay_command)
12991         (simple_overlay_update): Use all_objfiles.
12992         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12993         * printcmd.c (info_symbol_command): Use all_objfiles.
12994         * objfiles.h (ALL_OBJSECTIONS): Remove.
12995         * maint.c (maintenance_translate_address): Use all_objfiles.
12996         * gcore.c (gcore_create_callback): Use all_objfiles.
12997         (objfile_find_memory_regions): Likewise.
12998
12999 2019-01-09  Tom Tromey  <tom@tromey.com>
13000
13001         * symtab.c (find_line_symtab, info_sources_command)
13002         (make_source_files_completion_list): Use objfile_compunits.
13003         * source.c (select_source_symtab): Use objfile_compunits.
13004         * objfiles.h (struct objfile): Update comment.
13005         (ALL_OBJFILES): Remove.
13006         (ALL_FILETABS): Remove.
13007         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13008         objfile_compunits.
13009
13010 2019-01-09  Tom Tromey  <tom@tromey.com>
13011
13012         * symmisc.c (print_objfile_statistics, dump_objfile)
13013         (maintenance_print_symbols): Use compunit_filetabs.
13014         * source.c (forget_cached_source_info_for_objfile): Use
13015         compunit_filetabs.
13016         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13017         (ALL_FILETABS): Use compunit_filetabs.
13018         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13019         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13020
13021 2019-01-09  Tom Tromey  <tom@tromey.com>
13022
13023         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13024         (compunit_filetabs): New.
13025         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13026         compunit_filetabs.
13027         (info_sources_command, make_source_files_completion_list): Remove
13028         declaration.
13029         * symmisc.c (print_objfile_statistics, dump_objfile)
13030         (maintenance_print_symbols): Remove declaration.
13031         (maintenance_info_symtabs): Use compunit_filetabs.
13032         (maintenance_info_line_tables): Likewise.
13033         * source.c (select_source_symtab): Change local variable name.
13034         (forget_cached_source_info_for_objfile): Remove declaration.
13035         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13036         * objfiles.c (objfile_relocate1): Remove declaration.
13037         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13038         declaration.
13039         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13040         * coffread.c (coff_symtab_read): Remove declaration.
13041         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13042         compunit_filetabs.
13043
13044 2019-01-09  Tom Tromey  <tom@tromey.com>
13045
13046         * symtab.c (lookup_objfile_from_block)
13047         (find_pc_sect_compunit_symtab, search_symbols)
13048         (default_collect_symbol_completion_matches_break_on): Use
13049         objfile_compunits.
13050         * objfiles.h (ALL_COMPUNITS): Remove.
13051         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13052         * cp-support.c (add_symbol_overload_list_qualified): Use
13053         objfile_compunits.
13054         * ada-lang.c (ada_collect_symbol_completion_matches)
13055         (ada_add_global_exceptions): Use objfile_compunits.
13056
13057 2019-01-09  Tom Tromey  <tom@tromey.com>
13058
13059         * source.c (select_source_symtab)
13060         (forget_cached_source_info_for_objfile): Remove declaration.
13061         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13062         declaration.
13063         * maint.c (count_symtabs_and_blocks): Remove declaration.
13064         * cp-support.c (add_symbol_overload_list_qualified): Remove
13065         declaration.
13066         * coffread.c (coff_symtab_read): Remove declaration.
13067         * symtab.c (lookup_symbol_in_objfile_symtabs)
13068         (basic_lookup_transparent_type_1): Use objfile_compunits.
13069         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13070         (info_sources_command, search_symbols)
13071         (default_collect_symbol_completion_matches_break_on)
13072         (make_source_files_completion_list): Remove declaration.
13073         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13074         (ada_collect_symbol_completion_matches)
13075         (ada_add_global_exceptions): Remove declaration.
13076         * linespec.c (iterate_over_all_matching_symtabs): Use
13077         objfile_compunits.
13078         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13079         (class objfile_compunits): New.
13080         (ALL_COMPUNITS): Use objfile_compunits.
13081         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13082         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13083         objfile_compunits.
13084         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13085
13086 2019-01-09  Tom Tromey  <tom@tromey.com>
13087
13088         * symtab.c (search_symbols)
13089         (default_collect_symbol_completion_matches_break_on): Use
13090         objfile_msymbols.
13091         * ada-lang.c (ada_lookup_simple_minsym)
13092         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13093         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13094         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13095         objfile_msymbols.
13096         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13097         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13098         * objc-lang.c (find_methods): Use objfile_msymbols.
13099         (info_selectors_command, info_classes_command): Likewise.
13100         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13101         * objfiles.h (class objfile_msymbols): New.
13102         (ALL_OBJFILE_MSYMBOLS): Remove.
13103         (ALL_MSYMBOLS): Remove.
13104
13105 2019-01-09  Tom Tromey  <tom@tromey.com>
13106
13107         * common/next-iterator.h (next_adapter): Add Iterator template
13108         parameter.
13109         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13110         (class all_objfiles_safe): New.
13111         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13112         * objfiles.c (put_objfile_before): Update comment.
13113         (add_separate_debug_objfile): Likewise.
13114         (free_all_objfiles): Use all_objfiles_safe.
13115         (objfile_purge_solibs): Likewise.
13116
13117 2019-01-09  Tom Tromey  <tom@tromey.com>
13118
13119         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13120         (expand_symtab_containing_pc, lookup_static_symbol)
13121         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13122         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13123         all_objfiles.
13124         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13125         * breakpoint.c (create_overlay_event_breakpoint)
13126         (create_longjmp_master_breakpoint)
13127         (create_std_terminate_master_breakpoint)
13128         (create_exception_master_breakpoint): Use all_objfiles.
13129         * linux-thread-db.c (try_thread_db_load_from_pdir)
13130         (has_libpthread): Use all_objfiles.
13131         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13132         * linespec.c (iterate_over_all_matching_symtabs)
13133         (search_minsyms_for_name): Use all_objfiles.
13134         * maint.c (maintenance_info_sections): Use all_objfiles.
13135         * main.c (captured_main_1): Use all_objfiles.
13136         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13137         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13138         * guile/scm-pretty-print.c
13139         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13140         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13141         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13142         (maintenance_print_msymbols): Use all_objfiles.
13143         * source.c (select_source_symtab): Use all_objfiles.
13144         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13145         * symfile.c (remove_symbol_file_command)
13146         (expand_symtabs_matching, map_symbol_filenames): Use
13147         all_objfiles.
13148         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13149         all_objfiles.
13150         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13151         * objc-lang.c (find_methods): Use all_objfiles.
13152         * objfiles.c (have_partial_symbols, have_full_symbols)
13153         (have_minimal_symbols, qsort_cmp)
13154         (default_iterate_over_objfiles_in_search_order): Use
13155         all_objfiles.
13156         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13157         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13158         (maintenance_check_psymtabs): Use all_objfiles.
13159         (ALL_PSYMTABS): Remove.
13160         * compile/compile-object-run.c (do_module_cleanup): Use
13161         all_objfiles.
13162         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13163         * cp-support.c (add_symbol_overload_list_qualified): Use
13164         all_objfiles.
13165         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13166         Use all_objfiles.
13167         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13168         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13169         all_objfiles.
13170         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13171         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13172         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13173         Uses all_objfiles.
13174         * solib.c (solib_read_symbols): Use all_objfiles
13175
13176 2019-01-09  Tom Tromey  <tom@tromey.com>
13177
13178         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13179         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13180         all_objfiles.
13181         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13182         * symmisc.c (print_symbol_bcache_statistics)
13183         (print_objfile_statistics, maintenance_print_objfiles)
13184         (maintenance_info_symtabs, maintenance_check_symtabs)
13185         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13186         all_objfiles.
13187         * source.c (forget_cached_source_info): Use all_objfiles.
13188         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13189         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13190         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13191         * objfiles.c (update_section_map): Use all_objfiles.
13192         (shared_objfile_contains_address_p): Likewise.
13193         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13194         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13195
13196 2019-01-09  Tom Tromey  <tom@tromey.com>
13197
13198         * common/next-iterator.h: New file.
13199         * objfiles.h (class all_objfiles): New.
13200         (struct objfile_iterator): New.
13201
13202 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13203
13204         * NEWS: Move the description of the changed "frame", "select-frame",
13205          and "info frame" commands to the Changed commands section.
13206
13207 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13208
13209         * gdbtypes.c (check_stub_method_group): Remove handling of old
13210         mangling schemes.
13211         * linespec.c (find_methods): Likewise.
13212         * stabsread.c (read_member_functions): Likewise.
13213         * valops.c (search_struct_method): Likewise.
13214         (value_struct_elt_for_reference): Likewise.
13215         * NEWS: Mention this change.
13216
13217 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13218
13219         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13220         print_source_lines.
13221         * source.c (print_source_lines_base): Update line number check.
13222         (print_source_lines): New function.
13223         (source_lines_range::source_lines_range): New function.
13224         * source.h (class source_lines_range): New class.
13225         (print_source_lines): New declaration.
13226
13227 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13228
13229         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13230
13231 2019-01-08  Tom Tromey  <tom@tromey.com>
13232             Simon Marchi  <simon.marchi@ericsson.com>
13233
13234         PR gdb/24060
13235         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13236         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13237         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13238         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13239         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13240         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13241
13242 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13243
13244         * source.c (select_source_symtab): Move header comment to
13245         declaration in source.h.
13246         (forget_cached_source_info_for_objfile): Likewise.
13247         (forget_cached_source_info): Likewise.
13248         (identify_source_line): Likewise.
13249         * source.h (identify_source_line): Move declaration from symtab.h
13250         and add comment from source.c
13251         (print_source_lines): Likewise.
13252         (forget_cached_source_info_for_objfile): Likewise.
13253         (forget_cached_source_info): Likewise.
13254         (select_source_symtab): Likewise.
13255         (enum print_source_lines_flag): Move definition from symtab.h.
13256         * symtab.h (identify_source_line): Move declaration to source.h.
13257         (print_source_lines): Likewise.
13258         (forget_cached_source_info_for_objfile): Likewise.
13259         (forget_cached_source_info): Likewise.
13260         (select_source_symtab): Likewise.
13261         (enum print_source_lines_flag): Move definition to source.h.
13262         * tui/tui-hooks.c: Add 'source.h' include.
13263
13264 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13265
13266         * source.c (print_source_lines_base): Handle requests to print
13267         reverse line number sequences, and guard against empty lines
13268         string.
13269
13270 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13271
13272         * source.c (print_source_lines_base): Fix skip of '\r' if next
13273         character is '\n'.
13274
13275 2019-01-06  Tom Tromey  <tom@tromey.com>
13276
13277         * c-exp.y (struct c_parse_state) <macro_original_text,
13278         expansion_obstack>: New member.
13279         (macro_original_text, expansion_obstack): Remove globals.
13280         (scan_macro_expansion, scanning_macro_expansion)
13281         (finished_macro_expansion): Update.
13282         (scan_macro_cleanup): Remove.
13283         (yylex, c_parse): Update.
13284
13285 2019-01-06  Tom Tromey  <tom@tromey.com>
13286
13287         * c-exp.y (struct c_parse_state) <strings>: New member.
13288         (operator_stoken): Update.
13289
13290 2019-01-06  Tom Tromey  <tom@tromey.com>
13291
13292         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13293         (union type_stack_elt) <typelist_val>: Now a pointer to
13294         std::vector.
13295         (type_stack_cleanup): Don't declare.
13296         (push_typelist): Update.
13297         * parse.c (pop_typelist): Return a std::vector.
13298         (push_typelist): Take a std::vector.
13299         (follow_types): Update.  Do not free args.
13300         (type_stack_cleanup): Remove.
13301         * c-exp.y (struct c_parse_state): New.
13302         (cpstate): New global.
13303         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13304         (nonempty_typelist): Update.
13305         (func_mod): Create a new vector.
13306         (c_parse): Create a c_parse_state.
13307         (check_parameter_typelist): Do not delete params.
13308         (function_method): Update.  Do not delete type_list.
13309
13310 2019-01-06  Tom Tromey  <tom@tromey.com>
13311
13312         PR gdb/28155:
13313         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13314         check_typedef.
13315         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13316         (print_return_value): Likewise.
13317
13318 2019-01-05  Tom Tromey  <tom@tromey.com>
13319
13320         * contrib/cleanup_check.py: Remove.
13321         * contrib/gcc-with-excheck: Remove.
13322         * contrib/exsummary.py: Remove.
13323         * contrib/excheck.py: Remove.
13324
13325 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13326
13327         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13328         NULL. Initialize tpprev to NULL instead of assigning it
13329         to NULL on the next statement.
13330         * windows-nat.c (windows_delete_thread): Remove check for
13331         main_thread_id before printing thread exit notifications.
13332         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13333         Remove thread ID check against main_thread_id.
13334         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13335         windows_delete_thread.
13336         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13337
13338 2019-01-04  Tom Tromey  <tom@tromey.com>
13339
13340         * compile/compile.c (_initialize_compile): Use upper case for
13341         metasyntactic variables.
13342         * symmisc.c (_initialize_symmisc): Use upper case for
13343         metasyntactic variables.
13344         * psymtab.c (_initialize_psymtab): Use upper case for
13345         metasyntactic variables.
13346         * demangle.c (demangle_command): Use upper case for metasyntactic
13347         variables.
13348         (_initialize_demangler): Likewise.
13349         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13350         variables.
13351
13352 2019-01-03  Tom Tromey  <tom@tromey.com>
13353
13354         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13355
13356 2019-01-03  Tom Tromey  <tom@tromey.com>
13357
13358         * python/py-symtab.c (salpy_str): Update.
13359         (struct salpy_sal_object) <symtab>: Now a PyObject.
13360         (salpy_dealloc): Update.
13361         (del_objfile_sal): Use gdbpy_ref.
13362
13363 2019-01-03  Tom Tromey  <tom@tromey.com>
13364
13365         * python/py-type.c (convert_field): Use new_reference.  Return
13366         gdbpy_ref.
13367         (make_fielditem): Return gdbpy_ref.
13368         (typy_fields): Update.
13369         (typy_getitem): Update.
13370         (field_name): Return gdbpy_ref.  Use new_reference.
13371         (typy_iterator_iternext): Update.
13372
13373 2019-01-03  Tom Tromey  <tom@tromey.com>
13374
13375         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13376
13377 2019-01-03  Tom Tromey  <tom@tromey.com>
13378
13379         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13380         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13381         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13382         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13383         (pspy_set_type_printers): Likewise.
13384         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13385         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13386         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13387         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13388         (objfpy_set_type_printers): Likewise.
13389
13390 2019-01-03  Tom Tromey  <tom@tromey.com>
13391
13392         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13393         (gdbpy_print_stack): Use gdbpy_err_fetch.
13394         * python/python-internal.h (class gdbpy_err_fetch): New class.
13395         (class gdbpy_enter) <m_error_type, m_error_value,
13396         m_error_traceback>: Remove.
13397         <m_error>: New member.
13398         (gdbpy_exception_to_string): Don't declare.
13399         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13400         * python/py-value.c (convert_value_from_python): Use
13401         gdbpy_err_fetch.
13402         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13403         gdbpy_exception_to_string.
13404         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13405         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13406         gdbpy_err_fetch.
13407
13408 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13409
13410         * linux-nat.c (delete_lwp_cleanup): Delete.
13411         (struct lwp_deleter): New struct.
13412         (lwp_info_up): New typedef.
13413         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13414         lwp_info_up.
13415
13416 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13417
13418         * linux-fork.c (class scoped_switch_fork_info): New class.
13419         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13420
13421 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13422
13423         * valops.c (find_overload_match): Remove use of null_cleanup, and
13424         calls to do_cleanups.
13425
13426 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13427
13428         * compile/compile-cplus-types.c
13429         (compile_cplus_instance::decl_name): Handle changes to
13430         cp_func_name.
13431         * cp-support.c (cp_func_name): Update header comment, update
13432         return type.
13433         * cp-support.h (cp_func_name): Update return type in declaration.
13434         * valops.c (find_overload_match): Move temp_func local to top
13435         level of function and change its type.  Use temp_func to hold and
13436         delete temporary string obtained from cp_func_name.
13437
13438 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13439
13440         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13441         gdb::char_vector, remove cleanup, and update uses of `msg`.
13442
13443 2019-01-03  Jim Wilson  <jimw@sifive.com>
13444
13445         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13446
13447 2019-01-02  Tom Tromey  <tom@tromey.com>
13448
13449         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13450         (tdesc_parse_xml): Remove cleanups.
13451         * target-descriptions.h (make_cleanup_free_target_description):
13452         Don't declare.
13453         (target_desc_deleter): New struct.
13454         (target_desc_up): New typedef.
13455         * target-descriptions.c (target_desc_deleter::operator()): Rename
13456         from free_target_description.
13457         (make_cleanup_free_target_description): Remove.
13458
13459 2019-01-02  Tom Tromey  <tom@tromey.com>
13460
13461         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13462         constructor, destructor.
13463         (linespec_parser): Remove typedef.
13464         (~linespec_parser): Rename from linespec_parser_delete.
13465         (linespec_lex_to_end, linespec_complete_label)
13466         (linespec_complete): Update.
13467         (decode_line_full): Remove cleanups.
13468         (decode_line_1): Update.
13469
13470 2019-01-02  Tom Tromey  <tom@tromey.com>
13471
13472         * python/python-internal.h (inferior_to_inferior_object): Change
13473         return type.
13474         * python/py-exitedevent.c (create_exited_event_object): Update.
13475         * python/py-inferior.c (inferior_to_inferior_object): Return
13476         gdbpy_ref.
13477         (python_new_inferior, python_inferior_deleted)
13478         (thread_to_thread_object, delete_thread_object)
13479         (build_inferior_list, gdbpy_selected_inferior): Update.
13480         * python/py-infthread.c (create_thread_object): Update.  Also fail
13481         if inferior_to_inferior_object fails.
13482
13483 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13484
13485         * inferior.h (class inferior) <displaced_step_state>: New field.
13486         * infrun.h (struct displaced_step_state): Move here from
13487         infrun.c.  Initialize fields, add constructor.
13488         <inf>: Remove field.
13489         <reset>: New method.
13490         * infrun.c (struct displaced_step_inferior_state): Move to
13491         infrun.h.
13492         (displaced_step_inferior_states): Remove.
13493         (get_displaced_stepping_state): Adust.
13494         (displaced_step_in_progress_any_inferior): Adjust.
13495         (displaced_step_in_progress_thread): Adjust.
13496         (displaced_step_in_progress): Adjust.
13497         (add_displaced_stepping_state): Remove.
13498         (get_displaced_step_closure_by_addr): Adjust.
13499         (remove_displaced_stepping_state): Remove.
13500         (infrun_inferior_exit): Call displaced_step_state.reset.
13501         (use_displaced_stepping): Don't check for NULL.
13502         (displaced_step_prepare_throw): Call
13503         get_displaced_stepping_state.
13504         (displaced_step_fixup): Don't check for NULL.
13505         (prepare_for_detach): Don't check for NULL.
13506
13507 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13508
13509         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13510          in case of call that did not complete.
13511
13512 2019-01-02  Andrey Utkin  <autkin@undo.io>
13513
13514         * symfile.c (find_separate_debug_file): Fix search of debug files for
13515         remote debuggee.
13516
13517 2019-01-02  Tom Tromey  <tom@tromey.com>
13518
13519         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13520         indentation.
13521         * python/py-frame.c (frapy_older): Remove cast.
13522         (frapy_newer): Likewise.
13523         * python/py-breakpoint.c (local_setattro): Remove cast.
13524         * python/py-arch.c (archpy_name): Remove local variable.
13525         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13526
13527 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13528
13529         * unittests/basic_string_view/element_access/char/empty.cc:
13530         Fix year range in copyright header.
13531
13532 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13533
13534         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13535         Delete.
13536         <operator==>: Update with for removed field.
13537         <hash>: Likewise.
13538         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13539         <isa_features>: ...this.
13540         <abi_features>: New field.
13541         (riscv_isa_flen): Update comment.
13542         (riscv_abi_xlen): New declaration.
13543         (riscv_abi_flen): New declaration.
13544         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13545         isa_features.
13546         (riscv_abi_xlen): New function.
13547         (riscv_isa_flen): Update to get answer from isa_features.
13548         (riscv_abi_flen): New function.
13549         (riscv_has_fp_abi): Update to get answer from abi_features.
13550         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13551         xlen and flen.
13552         (riscv_call_info) <xlen, flen>: Update comment.
13553         (riscv_call_arg_struct): Remove invalid assertions
13554         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13555         is removed.
13556         (riscv_gdbarch_init): Gather isa features and abi features
13557         separately, ensure both match on the gdbarch when reusing an old
13558         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13559         a target with 64-bit float hardware.
13560
13561 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13562
13563         * source.c (search_command_helper): Stop reverse search
13564         when line 1 has been searched.
13565
13566 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13567
13568         * record-full.c (record_full_base_target::close): Rewrite
13569         record_full_core_buf_list free logic.
13570
13571 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13572
13573         * break-catch-syscall.c (print_one_catch_syscall): xfree
13574         the last text.
13575
13576 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13577
13578         * top.c (print_gdb_version): Update Copyright year in version
13579         message.
13580
13581 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13582
13583         Update copyright year range in all GDB files.
13584
13585 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13586
13587         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13588
13589 For older changes see ChangeLog-2018.
13590 \f
13591 Local Variables:
13592 mode: change-log
13593 left-margin: 8
13594 fill-column: 74
13595 version-control: never
13596 coding: utf-8
13597 End:
13598