gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * breakpoint.c (breakpoint_objfile_key): Change type.
   4         (get_breakpoint_objfile_data): Update.
   5         (free_breakpoint_objfile_data): Remove.
   6         (_initialize_breakpoint): Update.
   7
   8 2019-05-08  Tom Tromey  <tom@tromey.com>
   9
  10         * linux-tdep.c (struct linux_info): Add initializers.
  11         (linux_inferior_data): Move.  Change type.
  12         (invalidate_linux_cache_inf): Update.
  13         (linux_inferior_data_cleanup): Remove.
  14         (get_linux_inferior_data, _initialize_linux_tdep): Update.
  15
  16 2019-05-08  Tom Tromey  <tom@tromey.com>
  17
  18         * auxv.c (auxv_inferior_data): Move.  Change type.
  19         (auxv_inferior_data_cleanup): Remove.
  20         (invalidate_auxv_cache_inf): Rewrite.
  21         (get_auxv_inferior_data, _initialize_auxv): Update.
  22
  23 2019-05-08  Tom Tromey  <tom@tromey.com>
  24
  25         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
  26         (symfile_debug_objfile_data_key): Change type.
  27         (symfile_debug_installed, debug_qf_has_symbols)
  28         (debug_qf_find_last_source_symtab)
  29         (debug_qf_forget_cached_source_info)
  30         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
  31         (debug_qf_print_stats, debug_qf_dump)
  32         (debug_qf_expand_symtabs_for_function)
  33         (debug_qf_expand_all_symtabs)
  34         (debug_qf_expand_symtabs_with_fullname)
  35         (debug_qf_map_matching_symbols)
  36         (debug_qf_expand_symtabs_matching)
  37         (debug_qf_find_pc_sect_compunit_symtab)
  38         (debug_qf_map_symbol_filenames)
  39         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
  40         (debug_sym_new_init, debug_sym_init, debug_sym_read)
  41         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
  42         (debug_sym_read_linetable, debug_sym_relocate): Update.
  43         (symfile_debug_free_objfile): Remove.
  44         (install_symfile_debug_logging, _initialize_symfile_debug):
  45         Update.
  46
  47 2019-05-08  Tom Tromey  <tom@tromey.com>
  48
  49         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
  50         allocate_on_obstack.
  51         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
  52         (get_dwarf2_per_objfile): Update.
  53         (set_dwarf2_per_objfile): Remove.
  54         (dwarf2_has_info, dwarf2_get_section_info): Update.
  55         (dwarf2_free_objfile): Remove.
  56         (_initialize_dwarf2_read): Update.
  57
  58 2019-05-08  Tom Tromey  <tom@tromey.com>
  59
  60         * auto-load.c (struct auto_load_pspace_info): Add destructor and
  61         initializers.
  62         <unsupported_script_warning_printed,
  63         script_not_found_warning_printed>: Now bool.
  64         (auto_load_pspace_data): Change type.
  65         (~auto_load_pspace_info): Rename from
  66         auto_load_pspace_data_cleanup.
  67         (get_auto_load_pspace_data, init_loaded_scripts_info)
  68         (clear_section_scripts, maybe_print_unsupported_script_warning)
  69         (maybe_print_script_not_found_warning, _initialize_auto_load):
  70         Update.
  71
  72 2019-05-08  Tom Tromey  <tom@tromey.com>
  73
  74         * objfiles.c (objfile_pspace_info): Add destructor and
  75         initializers.
  76         (objfiles_pspace_data): Change type.
  77         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
  78         (get_objfile_pspace_data): Update.
  79         (objfiles_bfd_data): Change type.
  80         (get_objfile_bfd_data): Update.
  81         (objfile_bfd_data_free, _initialize_objfiles): Remove.
  82
  83 2019-05-08  Tom Tromey  <tom@tromey.com>
  84
  85         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
  86         Change type.
  87         (get_catch_syscall_inferior_data): Update.
  88         (catch_syscall_inferior_data_cleanup): Remove.
  89         (_initialize_break_catch_syscall): Update.
  90
  91 2019-05-08  Tom Tromey  <tom@tromey.com>
  92
  93         * inflow.c (struct terminal_info): Add destructor and
  94         initializers.
  95         (inflow_inferior_data): Change type.
  96         (~terminal_info): Rename from inflow_inferior_data_cleanup.
  97         (get_inflow_inferior_data, inflow_inferior_exit)
  98         (swap_terminal_info, _initialize_inflow): Update.
  99
 100 2019-05-08  Tom Tromey  <tom@tromey.com>
 101
 102         * target-dcache.c (target_dcache_cleanup): Remove.
 103         (target_dcache_aspace_key): Change type.
 104         (target_dcache_init_p, target_dcache_invalidate)
 105         (target_dcache_get, target_dcache_get_or_init)
 106         (_initialize_target_dcache): Update.
 107         * dcache.h (struct dcache_deleter): New.
 108
 109 2019-05-08  Tom Tromey  <tom@tromey.com>
 110
 111         * symtab.c (struct symbol_cache): Add destructor and
 112         initializers.
 113         (symbol_cache_key): Move.  Change type.
 114         (make_symbol_cache, free_symbol_cache): Remove.
 115         (get_symbol_cache): Update.
 116         (symbol_cache_cleanup): Remove.
 117         (ALL_PSPACES, symbol_cache_flush)
 118         (maintenance_print_symbol_cache)
 119         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 120         Update.
 121
 122 2019-05-08  Tom Tromey  <tom@tromey.com>
 123
 124         * symtab.c (struct main_info): Add destructor and initializers.
 125         (main_progspace_key): Move.  Change type.
 126         (get_main_info): Update.
 127         (main_info_cleanup): Remove.
 128         (_initialize_symtab): Update.
 129
 130 2019-05-08  Tom Tromey  <tom@tromey.com>
 131
 132         * registry.h (DECLARE_REGISTRY): Define the _key class.
 133
 134 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 135
 136         * NEWS: Merge two 'New commands' sections.
 137
 138 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 139
 140         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 141         parameter and use Ada language definition instead.
 142         (ada_val_print_ptr): Remove unused language parameter.
 143         (ada_val_print_num): Remove language parameter and use Ada language
 144         definition instead.
 145         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 146         parameter.
 147         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 148         parameter and use Ada language definition instead.
 149         (ada_val_print_1): Update all ada_val_print_xxx calls.
 150         Remove language parameter.
 151         (ada_val_print): Update ada_val_print_1 call.
 152
 153 2019-05-08  Tom Tromey  <tromey@adacore.com>
 154
 155         * remote.c (remote_hw_watchpoint_limit)
 156         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 157         Now static.
 158
 159 2019-05-08  Tom Tromey  <tromey@adacore.com>
 160
 161         * maint.c (_initialize_maint_cmds): Move initialization code to
 162         remote.c.
 163         (watchdog, show_watchdog): Move to remote.c.
 164         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 165         "watchdog" static.
 166         (_initialize_remote): Move initialization code from maint.c.
 167         * defs.h (watchdog): Don't declare.
 168
 169 2019-05-08  Tom Tromey  <tromey@adacore.com>
 170
 171         * tui/tui-interp.c: Include main.h.
 172         * interps.c: Include main.h.
 173         * main.h (interpreter_p): Declare.
 174         * defs.h (interpreter_p): Don't declare.
 175
 176 2019-05-08  Tom Tromey  <tromey@adacore.com>
 177
 178         * dwarf2loc.c: Include dwarf2read.h.
 179         * defs.h (read_unsigned_leb128): Don't declare.
 180         * dwarf2read.h (read_unsigned_leb128): Declare.
 181
 182 2019-05-08  Tom Tromey  <tromey@adacore.com>
 183
 184         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 185         method.
 186
 187 2019-05-08  Tom Tromey  <tromey@adacore.com>
 188
 189         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 190         when no wrap column is set.
 191
 192 2019-05-08  Tom Tromey  <tromey@adacore.com>
 193
 194         * c-lang.c (c_get_string): Handle non-C-style arrays.
 195
 196 2019-05-08  Tom Tromey  <tromey@adacore.com>
 197
 198         * typeprint.c (print_offset_data::update): Print the bit offset,
 199         not the number of bits remaining.
 200
 201 2019-05-08  Tom Tromey  <tromey@adacore.com>
 202
 203         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 204         padding at end of comment.
 205
 206 2019-05-08  Tom Tromey  <tromey@adacore.com>
 207
 208         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 209         Compare main types.
 210
 211 2019-05-06  Tom Tromey  <tom@tromey.com>
 212
 213         * common/scoped_mmap.c: Include common-defs.h.
 214         * common/scoped_mmap.h: Don't include config.h.
 215
 216 2019-05-04  Tom Tromey  <tom@tromey.com>
 217
 218         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 219         (struct aarch64_call_info): Add initializers.
 220         <si>: Now a std::vector.
 221         (pass_on_stack, aarch64_push_dummy_call): Update.
 222
 223 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 224             Tom Tromey  <tom@tromey.com>
 225
 226         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 227         (ppc_threads): Now a std::vector.  Now static.
 228         (hwdebug_find_thread_points_by_tid)
 229         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 230         Update.
 231
 232 2019-05-04  Tom Tromey  <tom@tromey.com>
 233
 234         * arc-tdep.c (arc_tdesc_init): Return bool.
 235
 236 2019-05-04  Tom Tromey  <tom@tromey.com>
 237
 238         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 239         Use gdb_assert_not_reached.
 240
 241 2019-05-04  Tom Tromey  <tom@tromey.com>
 242
 243         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 244         "false".
 245
 246 2019-05-04  Tom Tromey  <tom@tromey.com>
 247
 248         * arc-tdep.c (arc_tdesc_init): Use bool.
 249
 250 2019-05-04  Tom Tromey  <tom@tromey.com>
 251
 252         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 253
 254 2019-05-04  Tom Tromey  <tom@tromey.com>
 255
 256         * cli/cli-cmds.c (valid_command_p): Return bool.
 257
 258 2019-05-04  Tom Tromey  <tom@tromey.com>
 259
 260         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 261         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 262
 263 2019-05-04  Raul Tambre  <raul@tambre.ee>
 264
 265         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 266         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 267         operator for comparison.
 268
 269 2019-05-04  Tom Tromey  <tom@tromey.com>
 270
 271         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 272         (lookup_partial_symbol, print_partial_symbols)
 273         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 274         (psymbol_compare): Update.
 275         (add_psymbol_to_bcache): Clear the entire psymbol.
 276         (maintenance_check_psymtabs): Update.
 277         * psympriv.h (struct partial_symbol): Don't derive from
 278         general_symbol_info.
 279         <obj_section, unrelocated_address, address,
 280         set_unrelocated_address>: Update.
 281         <ginfo>: New member.
 282         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 283         (debug_names::write_psymbols): Update.
 284
 285 2019-05-04  Tom de Vries  <tdevries@suse.de>
 286
 287         * contrib/cc-with-tweaks.sh: Support -n arg.
 288
 289 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 290
 291         * corelow.c (core_target::detach): Ensure frame cache and
 292         register caches are cleared.
 293         inferior.c (exit_inferior_1): Likewise.
 294
 295 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 296             Tom Tromey  <tom@tromey.com>
 297
 298         * dictionary.c (collate_pending_symbols_by_language): Remove
 299         "struct" from foreach.
 300         * symtab.c (lookup_global_symbol_from_objfile)
 301         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 302         foreach.
 303         * ser-tcp.c (net_open): Remove "struct" from foreach.
 304         * objfiles.c (objfile_relocate, objfile_rebase)
 305         (objfile_has_symbols): Remove "struct" from foreach.
 306         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 307         from foreach.
 308         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 309         foreach.
 310         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 311         "struct" from foreach.
 312         * ada-lang.c (create_excep_cond_exprs)
 313         (ada_exception_catchpoint_cond_string): Remove "struct" from
 314         foreach.
 315
 316 2019-05-03  Tom Tromey  <tromey@adacore.com>
 317
 318         * ada-exp.y (convert_char_literal): Check suffix of each
 319         enumerator.
 320
 321 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 322
 323         PR ada/21406:
 324         * ada-exp.y (yywrap): Don't define.
 325         * ada-lex.l (%option): Add noyywrap
 326         (yywrap): Remove.
 327
 328 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 329
 330         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 331         _WIN32_WINNT to the XP level, unless already defined to a higher
 332         level.
 333
 334         * unittests/parse-connection-spec-selftests.c:
 335         * ser-tcp.c:
 336         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 337         override.
 338
 339         * symfile.c (find_separate_debug_file): Remove colon from the
 340         drive spec of DOS/Windows file names of the target, so that the
 341         file name produced from DEBUGDIR and the target's directory will
 342         be valid on DOS/Windows systems.
 343
 344 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 345
 346         * rust-lang.c (val_print_struct): Handle printing structures
 347         containing strings.
 348
 349 2019-05-02  Tom Tromey  <tromey@adacore.com>
 350
 351         * valarith.c (_initialize_valarith): Remove.
 352
 353 2019-05-01  Tom Tromey  <tromey@adacore.com>
 354
 355         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 356         bitfields.
 357
 358 2019-05-01  Tom Tromey  <tromey@adacore.com>
 359
 360         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 361         for big-endian copies.
 362
 363 2019-04-30  Ali Tamur  <tamur@google.com>
 364         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 365         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 366         (read_3_bytes): New function.
 367
 368 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 369
 370         * windows-nat.c (main_thread_id): Delete.
 371         (handle_output_debug_string): Replace main_thread_id by
 372         current_event.dwThreadId.
 373         (fake_create_process): Likewise.
 374         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 375         Do not set main_thread_id.
 376         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 377         current_event.dwThreadId.
 378         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 379
 380 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 381
 382         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 383         Use current_event.dwThreadId instead of main_thread_id.
 384
 385 2019-04-30  Tom Tromey  <tromey@adacore.com>
 386
 387         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 388         (create_excep_cond_exprs): Iterate over program spaces.
 389         (ada_exception_catchpoint_cond_string): Examine all minimal
 390         symbols for exception types.
 391
 392 2019-04-30  Tom Tromey  <tromey@adacore.com>
 393
 394         PR c++/24470:
 395         * dwarf2read.c (process_structure_scope): Handle case where type
 396         has template parameters but no symbol was created.
 397
 398 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 399             Chris January  <chris.january@arm.com>
 400
 401         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 402         qualifier.
 403         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 404
 405 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 406
 407         * f-typeprint.c (f_print_type): Update rules for printing
 408         whitespace.
 409         (f_type_print_varspec_suffix): Likewise.
 410
 411 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 412             Chris January  <chris.january@arm.com>
 413
 414         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 415         function arguments.
 416
 417 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 418
 419         * f-lang.c (build_fortran_types): Change name of void type to
 420         lower case.
 421         * f-typeprint.c (f_type_print_base): Print the name of the void
 422         type, rather than a fixed string.
 423         * f-valprint.c (f_decorations): Use lower case void string.
 424
 425 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 426             Chris January  <chris.january@arm.com>
 427
 428         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 429         types for Fortran.
 430
 431 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 432             Chris January  <chris.january@arm.com>
 433             David Lecomber  <david.lecomber@arm.com>
 434
 435         * f-exp.y (BINOP_INTRINSIC): New token.
 436         (exp): New parser rule handling BINOP_INTRINSIC.
 437         (f77_keywords): Add new builtin procedures.
 438         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 439         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 440         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 441         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 442         (print_unop_subexp_f): New function.
 443         (print_binop_subexp_f): New function.
 444         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 445         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 446         (dump_subexp_body_f): Likewise.
 447         (operator_check_f): Likewise.
 448         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 449         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 450
 451 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 452
 453         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 454         UNOP_KIND.
 455         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 456         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 457         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 458         (operator_length_f): New fuction.
 459         (print_subexp_f): New function.
 460         (op_name_f): New function.
 461         (dump_subexp_body_f): New function.
 462         (operator_check_f): New function.
 463         (exp_descriptor_f): Replace standard expression handling functions
 464         with new functions.
 465         * gdb/fortran-operator.def: New file.
 466         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 467         * gdb/std-operator.def: Remove UNOP_KIND.
 468
 469 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 470
 471         * std-operator.def: Remove unbalanced, stray double quote
 472         character.
 473
 474 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 475             Chris January  <chris.january@arm.com>
 476             Daniel Everett  <daniel.everett@arm.com>
 477             Nick Forrington  <nick.forrington@arm.com>
 478             Richard Bunt  <richard.bunt@arm.com>
 479
 480         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 481         of depth when printing anonymous structs or unions.
 482         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 483         Don't print either the top-level value, or the children if the
 484         max-depth is exceeded.
 485         (ppscm_print_children): When printing the key of a map, allow one
 486         extra level of depth.
 487         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 488         print either the top-level value, or the children if the max-depth
 489         is exceeded.
 490         (print_children): When printing the key of a map, allow one extra
 491         level of depth.
 492         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 493         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 494         (user_print_options): Initialise max_depth field.
 495         (val_print_scalar_or_string_type_p): New function.
 496         (val_print): Check to see if the max depth has been reached.
 497         (val_print_check_max_depth): Define new function.
 498         (show_print_max_depth): New function.
 499         (_initialize_valprint): Add 'print max-depth' option.
 500         * valprint.h (struct value_print_options) <max_depth>: New field.
 501         (val_print_check_max_depth): Declare new function.
 502         * NEWS: Document new feature.
 503
 504 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 505
 506         * ada-lang.c (ada_language_defn): Initialise new field.
 507         * c-lang.c (c_is_string_type_p): New function.
 508         (c_language_defn): Initialise new field.
 509         (cplus_language_defn): Initialise new field.
 510         (asm_language_defn): Initialise new field.
 511         (minimal_language_defn): Initialise new field.
 512         * c-lang.h (c_is_string_type_p): Declare new function.
 513         * d-lang.c (d_language_defn): Initialise new field.
 514         * f-lang.c (f_is_string_type_p): New function.
 515         (f_language_defn): Initialise new field.
 516         * go-lang.c (go_is_string_type_p): New function.
 517         (go_language_defn): Initialise new field.
 518         * language.c (default_is_string_type_p): New function.
 519         (unknown_language_defn): Initialise new field.
 520         (auto_language_defn): Initialise new field.
 521         * language.h (struct language_defn) <la_is_string_type_p>: New
 522         member variable.
 523         (default_is_string_type_p): Declare new function.
 524         * m2-lang.c (m2_language_defn): Initialise new field.
 525         * objc-lang.c (objc_language_defn): Initialise new field.
 526         * opencl-lang.c (opencl_language_defn): Initialise new field.
 527         * p-lang.c (pascal_is_string_type_p): New function.
 528         (pascal_language_defn): Initialise new field.
 529         * rust-lang.c (rust_is_string_type_p): New function.
 530         (rust_language_defn): Initialise new field.
 531
 532 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 533
 534         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 535         New field.
 536         * ada-lang.c (ada_language_defn): Initialise new field.
 537         * c-lang.c (c_language_defn): Likewise.
 538         (cplus_language_defn): Likewise.
 539         (asm_language_defn): Likewise.
 540         (minimal_language_defn): Likewise.
 541         * d-lang.c (d_language_defn): Likewise.
 542         * f-lang.c (f_language_defn): Likewise.
 543         * go-lang.c (go_language_defn): Likewise.
 544         * language.c (unknown_language_defn): Likewise.
 545         (auto_language_defn): Likewise.
 546         * m2-lang.c (m2_language_defn): Likewise.
 547         * objc-lang.c (objc_language_defn): Likewise.
 548         * opencl-lang.c (opencl_language_defn): Likewise.
 549         * p-lang.c (pascal_language_defn): Likewise.
 550         * rust-lang.c (rust_language_defn): Likewise.
 551
 552 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 553
 554         * ada-lang.c (ada_is_character_type): Change return type to bool.
 555         (ada_is_string_type): Likewise.
 556         * ada-lang.h (ada_is_character_type): Update declaration
 557         (ada_is_string_type): Likewise.
 558
 559 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 560
 561         Support style in 'frame|thread apply'
 562
 563         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 564         * record.c (record_start, record_stop): Update callers of
 565         execute_command_to_string with false.
 566         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 567         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 568         methods.
 569         (class string_file): New constructor with term_out parameter.
 570         Override methods term_out and can_emit_style_escape.  New member
 571         term_out.
 572         (class stdio_file): Override can_emit_style_escape.
 573         (class tee_file): Override term_out and can_emit_style_escape.
 574         * utils.h (can_emit_style_escape): Remove.
 575         * utils.c (can_emit_style_escape): Likewise.
 576         Update all callers of can_emit_style_escape (SOMESTREAM) to
 577         SOMESTREAM->can_emit_style_escape.
 578         * source-cache.c (source_cache::get_source_lines): Likewise.
 579         * stack.c (frame_apply_command_count): Call execute_command_to_string
 580         passing the term_out characteristic of the current gdb_stdout.
 581         * thread.c (thr_try_catch_cmd): Likewise.
 582         * top.c (execute_command_to_string): pass term_out parameter
 583         to construct the string_file for the command output.
 584         * ui-file.c (term_cli_styling): New function (most code moved
 585         from utils.c can_emit_style_escape).
 586         (string_file::string_file, string_file::can_emit_style_escape,
 587         stdio_file::can_emit_style_escape, tee_file::term_out,
 588         tee_file::can_emit_style_escape): New functions.
 589
 590 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 591
 592         * NEWS: Mention the new set|show may-call-functions.
 593         * infcall.c (may_call_functions_p): New variable.
 594         (show_may_call_functions_p): New function.
 595         (call_function_by_hand_dummy): Throws an error if not
 596         may-call-functions.
 597         (_initialize_infcall): Call add_setshow_boolean_cmd for
 598         may-call-functions.
 599
 600 2019-04-25  Keith Seitz  <keiths@redhat.com>
 601
 602         PR c++/24367
 603         * cp-support.c (inspect_type): Don't attempt substitutions
 604         of symbol with the same name.
 605
 606 2019-04-25  Tom Tromey  <tromey@adacore.com>
 607
 608         PR gdb/24475:
 609         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 610         static.
 611
 612 2019-04-25  Tom Tromey  <tromey@adacore.com>
 613
 614         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 615         rvalue reference.
 616         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 617         (gdb_xml_parser::parse): Use std::move.
 618         * python/python-internal.h (gdbpy_convert_exception): Take a const
 619         reference.
 620         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 621         std::move.
 622         * python/py-utils.c (gdbpy_convert_exception): Take a const
 623         reference.
 624         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 625         Use std::move.
 626         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 627         Use std::move.
 628         * mi/mi-main.c (mi_print_exception): Take a const reference.
 629         * main.c (handle_command_errors): Take a const reference.
 630         * linespec.c (parse_linespec): Use std::move.
 631         * infcall.c (run_inferior_call): Use std::move.
 632         (call_function_by_hand_dummy): Use std::move.
 633         * exec.c (try_open_exec_file): Use std::move.
 634         * exceptions.h (exception_print, exception_fprintf)
 635         (exception_print_same): Update.
 636         * exceptions.c (print_exception, exception_print)
 637         (exception_fprintf, exception_print_same): Change parameters to
 638         const reference.
 639         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 640         * common/new-op.c: Use std::move.
 641         * common/common-exceptions.h (struct gdb_exception): Add move
 642         constructor.
 643         (struct gdb_exception_error, struct gdb_exception_quit, struct
 644         gdb_quit_bad_alloc): Change constructor to move constructor.
 645         (throw_exception): Change parameter to rvalue reference.
 646         * common/common-exceptions.c (throw_exception): Take rvalue
 647         reference.
 648         * cli/cli-interp.c (safe_execute_command): Use std::move.
 649         * breakpoint.c (insert_bp_location, location_to_sals): Use
 650         std::move.
 651
 652 2019-04-25  Tom Tromey  <tromey@adacore.com>
 653
 654         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 655         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 656         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 657         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 658         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 659         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 660         guile/scm-value.c: Use unpack.
 661         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 662         gdbscm_gdb_exception.
 663         (gdbscm_throw_gdb_exception): Likewise.
 664         (struct gdbscm_gdb_exception): New.
 665         (unpack): New function.
 666         (gdbscm_wrap): Use unpack.
 667
 668 2019-04-25  Tom Tromey  <tromey@adacore.com>
 669
 670         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 671         (gdb_rl_callback_handler): Use std::move.
 672         * common/common-exceptions.h (struct gdb_exception): Add move
 673         assignment operator.
 674         (throw_exception_sjlj): Change "exception" to const reference.
 675         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 676         (throw_exception_sjlj): Change "exception" to const reference.
 677
 678 2019-04-25  Tom Tromey  <tromey@adacore.com>
 679
 680         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 681         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 682         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 683         Update.
 684         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 685         Update.
 686         * mi/mi-interp.c (mi_interp::exec): Update.
 687         * linespec.c (parse_linespec): Update.
 688         * infcall.c (run_inferior_call): Update.
 689         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 690         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 691         (gdbscm_lookup_global_symbol): Update.
 692         * guile/scm-param.c (gdbscm_parameter_value): Update.
 693         * guile/scm-frame.c (gdbscm_frame_read_register)
 694         (gdbscm_frame_read_var): Update.
 695         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 696         * exec.c (try_open_exec_file): Update.
 697         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 698         (gdb_rl_callback_handler): Update.
 699         * common/common-exceptions.h (exception_none): Don't declare.
 700         * common/common-exceptions.c (exception_none): Don't define.
 701         (struct catcher) <exception>: Update.
 702         * cli/cli-interp.c (safe_execute_command): Update.
 703         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 704
 705 2019-04-25  Ali Tamur  <tamur@google.com>
 706
 707         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 708         (read_attribute_value): Likewise.
 709         (dwarf2_read_addr_index): Update comment.
 710         (read_str_index): Add DW_FORM_strx.
 711         (dwarf2_string_attr): Likewise.
 712         (dwarf2_const_value_attr): Likewise.
 713         (dump_die_shallow): Likewise.
 714         (dwarf2_fetch_constant_bytes): Likewise.
 715         (skip_form_bytes): Likewise.
 716         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 717
 718 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 719
 720         PR corefiles/11608
 721         PR corefiles/18187
 722         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 723         OFFSET.  Verify if current mapping contains an ELF header.
 724         (linux_find_memory_regions_full): Adjust call to
 725         dump_mapping_p.
 726
 727 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 728             Kang Li <kanglictf@gmail.com>
 729
 730         PR gdb/21600
 731
 732         * dwarf2-frame.c (read_initial_length): Be consistent about using
 733         unsigned representation of length.
 734         (decode_frame_entry_1): Likewise.  Check for wraparound of
 735         end pointer as well as buffer overflow.
 736
 737 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 738
 739         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 740         "vq".
 741
 742 2019-04-24  Tom Tromey  <tromey@adacore.com>
 743
 744         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 745
 746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 747
 748         * s12z-tdep.c (s12z_unwind_pc): Delete.
 749         (s12z_unwind_sp): Delete.
 750         (s12z_gdbarch_init): Don't register deleted functions with
 751         gdbarch.
 752
 753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 754
 755         * rl78-tdep.c (rl78_unwind_sp): Delete.
 756         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 757
 758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 759
 760         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 761         (xstormy16_unwind_pc): Delete.
 762         (xstormy16_dummy_id): Delete.
 763         (xstormy16_gdbarch_init): Don't register deleted functions with
 764         gdbarch.
 765
 766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 767
 768         * vax-tdep.c (vax_unwind_pc): Delete.
 769         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 770
 771 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * v850-tdep.c (v850_unwind_sp): Delete.
 774         (v850_unwind_pc): Delete.
 775         (v850_dummy_id): Delete.
 776         (v850_gdbarch_init): Don't register deleted functions with
 777         gdbarch.
 778
 779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 780
 781         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 782         (tilegx_unwind_pc): Delete.
 783         (tilegx_unwind_dummy_id): Delete.
 784         (tilegx_gdbarch_init): Don't register deleted functions with
 785         gdbarch.
 786
 787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 788
 789         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 790         (tic6x_dummy_id): Delete.
 791         (tic6x_gdbarch_init): Don't register deleted functions with
 792         gdbarch.
 793
 794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 795
 796         * sparc-tdep.c (sparc_unwind_pc): Delete.
 797         (sparc32_gdbarch_init): Don't register deleted function with
 798         gdbarch.
 799
 800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 801
 802         * sh-tdep.c (sh_unwind_sp): Delete.
 803         (sh_unwind_pc): Delete.
 804         (sh_dummy_id): Delete.
 805         (sh_gdbarch_init): Don't register deleted functions with
 806         gdbarch.
 807
 808 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 809
 810         * score-tdep.c (score_unwind_sp): Delete.
 811         (score_unwind_pc): Delete.
 812         (score_dummy_id): Delete.
 813         (score_gdbarch_init): Don't register deleted functions with
 814         gdbarch.
 815
 816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         * rx-tdep.c (rx_unwind_pc): Delete.
 819         (rx_unwind_sp): Delete.
 820         (rx_dummy_id): Delete.
 821         (rx_gdbarch_init): Don't register deleted functions with
 822         gdbarch.  Update comment.
 823
 824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 825
 826         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 827         (rs6000_dummy_id): Delete.
 828         (rs6000_gdbarch_init): Don't register deleted functions with
 829         gdbarch.
 830
 831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 832
 833         * or1k-tdep.c (or1k_dummy_id): Delete.
 834         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 835
 836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 837
 838         * nios2-tdep.c (nios2_dummy_id): Delete.
 839         (nios2_unwind_sp): Delete.
 840         (nios2_gdbarch_init): Don't register deleted functions with
 841         gdbarch.
 842
 843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 844
 845         * nds32-tdep.c (nds32_dummy_id): Delete.
 846         (nds32_unwind_pc): Delete.
 847         (nds32_unwind_sp): Delete.
 848         (nds32_gdbarch_init): Don't register deleted functions with
 849         gdbarch.
 850
 851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * msp430-tdep.c (msp430_unwind_pc): Delete.
 854         (msp430_unwind_sp): Delete.
 855         (msp430_dummy_id): Delete.
 856         (msp430_gdbarch_init): Don't register deleted functions with
 857         gdbarch.
 858
 859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 860
 861         * moxie-tdep.c (moxie_unwind_sp): Delete.
 862         (moxie_unwind_pc): Delete.
 863         (moxie_dummy_id): Delete.
 864         (moxie_gdbarch_init): Don't register deleted functions with
 865         gdbarch.
 866
 867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 870         (mn10300_unwind_pc): Delete.
 871         (mn10300_unwind_sp): Delete.
 872         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 873         mn10300_unwind_sp.
 874         (mn10300_frame_unwind_init): Don't register deleted functions with
 875         gdbarch.
 876
 877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 878
 879         * mep-tdep.c (mep_unwind_pc): Delete.
 880         (mep_unwind_sp): Delete.
 881         (mep_dummy_id): Delete.
 882         (mep_gdbarch_init): Don't register deleted functions with
 883         gdbarch.
 884
 885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 888         (m68hc11_unwind_sp): Delete.
 889         (m68hc11_gdbarch_init): Don't register deleted functions with
 890         gdbarch.
 891
 892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 893
 894         * m32r-tdep.c (m32r_unwind_sp): Delete.
 895         (m32r_unwind_pc): Delete.
 896         (m32r_dummy_id): Delete.
 897         (m32r_gdbarch_init): Don't register deleted functions with
 898         gdbarch.
 899
 900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 901
 902         * m32c-tdep.c (m32c_unwind_pc): Delete.
 903         (m32c_unwind_sp): Delete.
 904         (m32c_dummy_id): Delete.
 905         (m32c_gdbarch_init): Don't register deleted functions with
 906         gdbarch.
 907
 908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 911         (lm32_unwind_pc): Delete.
 912         (lm32_dummy_id): Delete.
 913         (lm32_gdbarch_init): Don't register deleted functions with
 914         gdbarch.
 915
 916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 919         (iq2000_unwind_pc): Delete.
 920         (iq2000_dummy_id): Delete.
 921         (iq2000_gdbarch_init): Don't register deleted functions with
 922         gdbarch.
 923
 924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         * nds32-tdep.c (nds32_type_align): Delete.
 927         (nds32_push_dummy_call): Use type_align instead.
 928
 929 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 930
 931         * arm-tdep.c (arm_type_align): Only handle vector override case.
 932         (arm_push_dummy_call): Use type_align.
 933         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 934
 935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 936
 937         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 938         case.
 939         (pass_on_stack): Use type_align.
 940         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 941         function.
 942
 943 2019-04-23  Tom Tromey  <tromey@adacore.com>
 944
 945         * dwarf2read.c (line_header::file_name_at): Remove unused
 946         overload.
 947
 948 2019-04-23  Tom de Vries  <tdevries@suse.de>
 949
 950         PR gdb/24438
 951         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 952         invocation.
 953
 954
 955 2019-03-27  Ali Tamur  <tamur@google.com>
 956
 957         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 958         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 959         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 960         (dwarf_expr_context::get_addr_index): Likewise
 961         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 962         (symbol_needs_eval_context::get_addr_index): Likewise
 963         (disassemble_dwarf_expression): Add DW_OP_addrx
 964         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 965         (read_cutu_die_from_dwo): Update comment
 966         (skip_one_die): Add DW_FORM_addrx
 967         (read_attribute_value): Likewise
 968         (var_decode_location): Add DW_OP_addrx
 969         (dwarf2_const_value_attr): Add DW_FORM_addrx
 970         (dump_die_shallow): Likewise
 971         (dwarf2_fetch_constant_bytes): Likewise
 972         (decode_locdesc): Add DW_OP_addrx
 973         (skip_form_bytes): Add DW_FORM_addrx
 974
 975 2019-04-22  Ali Tamur  <tamur@google.com>
 976
 977         * MAINTAINERS (Write After Approval): Add self.
 978
 979 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 980
 981         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 982         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 983         (open_symbol_file_object): Likewise.
 984         (svr4_default_sos): Add info parameter.
 985         (svr4_read_so_list): Likewise.
 986         (svr4_current_sos_direct): Adjust functions calls to pass down
 987         info.
 988         (svr4_current_sos_1): Add info parameter.
 989         (svr4_current_sos): Call get_svr4_info, pass info down to
 990         svr4_current_sos_1.
 991         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 992         get_svr4_info.
 993         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 994         get_svr4_info.
 995         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 996         to get_svr4_info.
 997         (probes_table_remove_objfile_probes): Likewise.
 998         (register_solib_event_probe): Add info parameter.
 999         (solist_update_incremental): Pass info parameter down to
1000         svr4_read_so_list.
1001         (disable_probes_interface): Add info parameter.
1002         (svr4_handle_solib_event): Pass current_program_space to
1003         get_svr4_info.  Adjust disable_probes_interface cleanup.
1004         (svr4_create_probe_breakpoints): Add info parameter, pass it
1005         down to register_solib_event_probe.
1006         (svr4_create_solib_event_breakpoints): Add info parameter,
1007         pass it down to svr4_create_probe_breakpoints.
1008         (enable_break): Pass info down to
1009         svr4_create_solib_event_breakpoints.
1010         (svr4_solib_create_inferior_hook): Pass current_program_space to
1011         get_svr4_info.
1012         (svr4_clear_solib): Likewise.
1013
1014 2019-04-22  Pedro Alves  <palves@redhat.com>
1015
1016         * solib-svr4.c (svr4_free_objfile_observer): New.
1017         (probe_and_action::objfile): New field.
1018         (probes_table_htab_remove_objfile_probes)
1019         (probes_table_remove_objfile_probes): New functions.
1020         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1021         in the new probe_and_action.  Don't store the probe in 'lookup'.
1022         (svr4_create_probe_breakpoints): Pass objfile to
1023         register_solib_event_probe.
1024         (_initialize_svr4_solib): Register a free_objfile observer.
1025
1026 2019-04-19  Tom Tromey  <tom@tromey.com>
1027
1028         * common/queue.h: Remove.
1029
1030 2019-04-19  Tom Tromey  <tom@tromey.com>
1031
1032         * event-loop.c: Don't include "common/queue.h".
1033
1034 2019-04-19  Tom Tromey  <tom@tromey.com>
1035
1036         * remote.c (remote_target): Use delete.
1037         * remote-notif.h: Include <list>, not "common/queue.h".
1038         (notif_client_p): Remove typedef.
1039         (remote_notif_state): Add constructor, destructor, initializer.
1040         <notif_queue>: Now a std::list.
1041         (remote_notif_state_xfree): Don't declare.
1042         * remote-notif.c (remote_notif_process, handle_notification)
1043         (remote_notif_state_allocate): Update.
1044         (~remote_notif_state): Rename from remote_notif_state_xfree.
1045
1046 2019-04-19  Tom Tromey  <tom@tromey.com>
1047
1048         * symfile.c (reread_symbols): Update.
1049         * objfiles.c (objfile_register_static_link)
1050         (objfile_lookup_static_link): Update
1051         (~objfile) Don't delete static_links.
1052         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1053
1054 2019-04-19  Tom Tromey  <tom@tromey.com>
1055
1056         * type-stack.h (struct type_stack) <insert>: Constify string.
1057         * type-stack.c (type_stack::insert): Constify string.
1058         * gdbtypes.h (lookup_template_type): Update.
1059         (address_space_name_to_int): Update.
1060         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1061         const.
1062         (lookup_template_type): Make name const.
1063         * c-exp.y: Update rules.
1064         (lex_one_token, classify_name, classify_inner_name)
1065         (c_print_token): Update.
1066         * p-exp.y: Update rules.
1067         (yylex): Update.
1068         * f-exp.y: Update rules.
1069         (yylex): Update.
1070         * d-exp.y: Update rules.
1071         (lex_one_token, classify_name, classify_inner_name): Update.
1072         * parse.c (write_dollar_variable, copy_name): Return std::string.
1073         * parser-defs.h (copy_name): Change return type.
1074         * m2-exp.y: Update rules.
1075         (yylex): Update.
1076         * go-exp.y (lex_one_token): Update.
1077         Update rules.
1078         (classify_unsafe_function, classify_packaged_name)
1079         (classify_name, yylex): Update.
1080
1081 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1082
1083         * configure.ac: add --enable-source-highlight switch.
1084         * configure: Regenerate.
1085         * top.c (print_gdb_version): plumb --enable-source-highlight
1086         status to "show configuration".
1087
1088 2019-04-19  Tom Tromey  <tromey@adacore.com>
1089
1090         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1091         Check ADA_TYPE_P.
1092         (empty_record, ada_template_to_fixed_record_type_1)
1093         (template_to_static_fixed_type)
1094         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1095         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1096         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1097         macros.
1098
1099 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1100
1101         PR symtab/24423:
1102         * source.c (print_source_lines_base): Advance "iter" when a
1103         control character is seen.
1104
1105 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1106
1107         * inferior.h (struct infcall_suspend_state_deleter):
1108         Catch exception in destructor to avoid crash.
1109
1110 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1111
1112         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1113         close to the add_com "shell".
1114
1115 2019-04-18  Tom Tromey  <tromey@adacore.com>
1116
1117         * process-stratum-target.h (class process_stratum_target)
1118         <stratum>: Add "final".
1119
1120 2019-04-17  Tom Tromey  <tromey@adacore.com>
1121
1122         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1123         against nullptr before use.
1124
1125 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1126
1127         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1128
1129 2019-04-17  Jim Wilson  <jimw@sifive.com>
1130             Andrew Burgess  <andrew.burgess@embecosm.com>
1131
1132         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1133         code read might fail, assume 4-byte breakpoint in that case.
1134
1135 2019-04-15  Leszek Swirski  <leszeks@google.com>
1136
1137         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1138         rather than a hand-rolled POD check when checking for forced MEMORY
1139         classification.
1140
1141 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1142
1143         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1144         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1145         function.
1146         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1147         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1148         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1149         declaration.
1150
1151 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1152
1153         * aarch64-linux-nat.c
1154         (aarch64_linux_nat_target::thread_architecture): Add override.
1155         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1156         each VQ.
1157
1158 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1159
1160         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1161
1162 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1163
1164         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1165         target types of size 96-bits, add some additional comments, and
1166         check that the builtin type we found was the correct size.
1167
1168 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1169
1170         * utils.c (prompt_for_continue): Don't restore the styling at the
1171         end, as applied_style has the wrong value.  This fixes styling in
1172         long lists of file names that are interrupted by the "Continue?"
1173         prompt.
1174
1175 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1176
1177         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1178         * c-lang.c (c_language_defn): Likewise.
1179         (cplus_language_defn): Likewise.
1180         (asm_language_defn): Likewise.
1181         (minimal_language_defn): Likewise.
1182         * d-lang.c (d_language_defn): Likewise.
1183         * f-lang.c (f_language_defn): Likewise.
1184         * go-lang.c (go_language_defn): Likewise.
1185         * language.c (unknown_language_defn): Likewise.
1186         (auto_language_defn): Likewise.
1187         * language.h (struct language_defn): Remove la_magic field.
1188         (LANG_MAGIC): Delete.
1189         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1190         * objc-lang.c (objc_language_defn): Likewise.
1191         * opencl-lang.c (opencl_language_defn): Likewise.
1192         * p-lang.c (pascal_language_defn): Likewise.
1193         * rust-lang.c (rust_language_defn): Likewise.
1194
1195 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1196
1197         * riscv-tdep.c (riscv_type_align): New function.
1198         (riscv_type_alignment): Delete.
1199         (riscv_arg_location): Use 'type_align'.
1200         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1201
1202 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1203
1204         * gdbtypes.c (type_align): A struct with no non-static fields also
1205         has alignment of 1.
1206
1207 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1208
1209         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1210         component to 0.
1211         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1212         member.
1213         (riscv_struct_info::analyse): New implementation using new
1214         analyse_inner member function.
1215         (riscv_struct_info::field_offset): New member function.
1216         (riscv_struct_info::m_offsets): New member variable.
1217         (riscv_struct_info::analyse_inner): New private member function,
1218         takes the old implementation of riscv_struct_info::analyse but
1219         extended to track field offsets.
1220         (riscv_call_arg_struct): Update the struct folding special cases
1221         to handle cases where empty C++ structs, which are non-zero
1222         length, are found.
1223         (riscv_arg_location): Initialise the length of each location, a
1224         non-zero length now indicates the location is in use.
1225         (riscv_push_dummy_call): Allow for the first location having a
1226         non-zero offset when setting up arguments.
1227         (riscv_return_value): Likewise, but for return values.
1228
1229 2019-04-11  Tom Tromey  <tromey@adacore.com>
1230
1231         * utils.c (internal_vproblem): Make "msg" const.
1232
1233 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1234
1235         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1236         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1237         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1238         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1239
1240 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1241
1242         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1243         function.
1244         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1245         of amd64_collect_native_gregset.
1246         (amd64_linux_nat_target::store_registers): Likewise.
1247
1248 2019-04-10  Tom Tromey  <tom@tromey.com>
1249
1250         * symtab.c (lookup_global_symbol_from_objfile)
1251         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1252         * objfiles.h (class separate_debug_iterator): New.
1253         (class separate_debug_range): New.
1254         (struct objfile) <separate_debug_objfiles>: New method.
1255         (objfile_separate_debug_iterate): Don't declare.
1256         * objfiles.c (separate_debug_iterator::operator++): Rename from
1257         objfile_separate_debug_iterate.
1258         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1259         iterator.
1260         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1261         iterator.
1262
1263 2019-04-10  Tom Tromey  <tom@tromey.com>
1264
1265         * symfile.c (reread_symbols): Remove old comment.
1266         * objfiles.c (free_all_objfiles): Fix a typo.
1267
1268 2019-04-10  Tom Tromey  <tom@tromey.com>
1269
1270         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1271         * minsyms.c (lookup_minimal_symbol): Use foreach.
1272         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1273         (lookup_minimal_symbol_solib_trampoline): Likewise.
1274         * symfile.c (reread_symbols): Use foreach.
1275
1276 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1277             Tom Tromey  <tromey@adacore.com>
1278
1279         PR rust/24414:
1280         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1281         (rust_lex_int_test): Change "value" to be LONGEST.
1282         (rust_lex_tests): Add test for long integer literal.
1283
1284 2019-04-09  Tom Tromey  <tromey@adacore.com>
1285
1286         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1287         to bool.
1288         (extended_remote_target::attach): Update.
1289         (remote_target::remote_notice_new_inferior): Update.
1290         (remote_target::add_current_inferior_and_thread): Update.
1291         * inferior.c (exit_inferior_1): Use "false".
1292         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1293
1294 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1295
1296         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1297         the "start" command.
1298
1299 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1300
1301         * python/py-inferior.c (infpy_thread_from_thread_handle):
1302         Adjust comments to reflect renaming of thread_from_thread_handle
1303         to thread_from_handle.  Adjust keywords.  Fix type error message.
1304         (inferior_object_methods): Add thread_from_handle.  Retain
1305         thread_from_thread_handle, but mark it as deprecated.
1306
1307 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1308
1309         * gdbthread.h (find_thread_by_handle): Revise declaration.
1310         * thread.c (find_thread_by_handle): Likewise.  Adjust
1311         implementation too.
1312         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1313         support for buffer objects as handles.
1314
1315 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1316
1317         * python/py-infthread.c (thpy_thread_handle): New function.
1318         (thread_object_methods): Register thpy_thread_handle.
1319
1320 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1321
1322         * gdbthread.h (thread_to_thread_handle): Declare.
1323         * thread.c (gdbtypes.h): Include.
1324         (thread_to_thread_handle): New function.
1325
1326         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1327         (target_thread_info_to_thread_handle): Declare.
1328         * target.c (target_thread_info_to_thread_handle): New function.
1329         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1330         * target-delegates.c: Regenerate.
1331
1332         * linux-thread-db.c (class thread_db_target): Add method
1333         thread_info_to_thread_handle.
1334         (thread_db_target::thread_info_to_thread_handle): Define.
1335         * remote.c (class remote_target): Add new method
1336         thread_info_to_thread_handle.
1337         (remote_target::thread_info_to_thread_handle): Define.
1338
1339 2019-04-08  Pedro Alves  <palves@redhat.com>
1340
1341         * common/common-exceptions.c (throw_exception): Don't create
1342         named object to throw; throw directly.
1343         (throw_it): Likewise.  Don't initialize gdb_exception::message
1344         here, with new; pass FMT and AP to the ctor instead.
1345         * common/common-exceptions.h: Include <string>.
1346         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1347         const char *, va_list)): New ctor.  Use std::make_shared.
1348         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1349         errors)): Delete.
1350         (gdb_exception_error::gdb_exception_error(enum errors, const char
1351         *, va_list)): New.
1352         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1353         Add assertion.
1354         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1355         errors)): Delete.
1356         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1357         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1358         Add assertion.
1359
1360 2019-04-08  Tom Tromey  <tom@tromey.com>
1361
1362         * valops.c (value_rtti_indirect_type): Replace throw_exception
1363         with throw.
1364         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1365         with throw.
1366         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1367         throw.
1368         * target.c (target_translate_tls_address): Replace throw_exception
1369         with throw.
1370         * stack.c (frame_apply_command_count): Replace throw_exception
1371         with throw.
1372         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1373         throw.
1374         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1375         with throw.
1376         * rs6000-tdep.c (rs6000_frame_cache)
1377         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1378         * remote.c: Replace throw_exception with throw.
1379         * record-full.c (record_full_message, record_full_wait_1)
1380         (record_full_restore): Replace throw_exception with throw.
1381         * record-btrace.c:
1382         (get_thread_current_frame_id, record_btrace_start_replaying)
1383         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1384         (cmd_record_btrace_start): Replace throw_exception with throw.
1385         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1386         throw.
1387         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1388         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1389         * linespec.c:
1390         (find_linespec_symbols): Replace throw_exception with throw.
1391         * infrun.c (displaced_step_prepare, resume): Replace
1392         throw_exception with throw.
1393         * infcmd.c (post_create_inferior): Replace throw_exception with
1394         throw.
1395         * inf-loop.c (inferior_event_handler): Replace throw_exception
1396         with throw.
1397         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1398         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1399         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1400         (get_prev_frame_always, get_frame_pc_if_available)
1401         (get_frame_address_in_block_if_available, get_frame_language):
1402         Replace throw_exception with throw.
1403         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1404         throw_exception with throw.
1405         * eval.c (fetch_subexp_value, evaluate_var_value)
1406         (evaluate_funcall, evaluate_subexp_standard): Replace
1407         throw_exception with throw.
1408         * dwarf2loc.c (call_site_find_chain)
1409         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1410         Replace throw_exception with throw.
1411         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1412         with throw.
1413         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1414         throw.
1415         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1416         * completer.c (complete_line_internal): Replace throw_exception
1417         with throw.
1418         * compile/compile-object-run.c (compile_object_run): Replace
1419         throw_exception with throw.
1420         * cli/cli-script.c (process_next_line): Replace throw_exception
1421         with throw.
1422         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1423         (btrace_enable, btrace_maint_update_pt_packets): Replace
1424         throw_exception with throw.
1425         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1426         throw_exception with throw.
1427         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1428         throw_exception with throw.
1429         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1430         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1431         * aarch64-tdep.c (aarch64_make_prologue_cache)
1432         (aarch64_make_stub_cache): Replace throw_exception with throw.
1433
1434 2019-04-08  Tom Tromey  <tom@tromey.com>
1435
1436         * common/common-exceptions.c (throw_exception): Rename from
1437         throw_exception_cxx.  Remove old copy.  Make argument const.
1438         (throw_it): Create and throw exception objects directly.
1439         * common/common-exceptions.h (throw_exception): Make argument
1440         const.
1441         (struct gdb_exception_error): Add constructor.
1442         (struct gdb_exception_quit): Add constructor.
1443
1444 2019-04-08  Tom Tromey  <tom@tromey.com>
1445
1446         * common/common-exceptions.h (exception_rethrow): Don't declare.
1447         (TRY_SJLJ): Update comment.
1448         (TRY, CATCH, END_CATCH): Remove.
1449         * common/common-exceptions.c (exception_rethrow): Remove.
1450
1451 2019-04-08  Tom Tromey  <tom@tromey.com>
1452
1453         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1454         Remove.
1455         (gdb_exception_error): Rename from
1456         gdb_exception_RETURN_MASK_ERROR.
1457         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1458         (gdb_quit_bad_alloc): Update.
1459         * aarch64-tdep.c: Update.
1460         * ada-lang.c: Update.
1461         * ada-typeprint.c: Update.
1462         * ada-valprint.c: Update.
1463         * amd64-tdep.c: Update.
1464         * arch-utils.c: Update.
1465         * break-catch-throw.c: Update.
1466         * breakpoint.c: Update.
1467         * btrace.c: Update.
1468         * c-varobj.c: Update.
1469         * cli/cli-cmds.c: Update.
1470         * cli/cli-interp.c: Update.
1471         * cli/cli-script.c: Update.
1472         * common/common-exceptions.c: Update.
1473         * common/new-op.c: Update.
1474         * common/selftest.c: Update.
1475         * compile/compile-c-symbols.c: Update.
1476         * compile/compile-cplus-symbols.c: Update.
1477         * compile/compile-object-load.c: Update.
1478         * compile/compile-object-run.c: Update.
1479         * completer.c: Update.
1480         * corelow.c: Update.
1481         * cp-abi.c: Update.
1482         * cp-support.c: Update.
1483         * cp-valprint.c: Update.
1484         * darwin-nat.c: Update.
1485         * disasm-selftests.c: Update.
1486         * dtrace-probe.c: Update.
1487         * dwarf-index-cache.c: Update.
1488         * dwarf-index-write.c: Update.
1489         * dwarf2-frame-tailcall.c: Update.
1490         * dwarf2-frame.c: Update.
1491         * dwarf2loc.c: Update.
1492         * dwarf2read.c: Update.
1493         * eval.c: Update.
1494         * event-loop.c: Update.
1495         * event-top.c: Update.
1496         * exec.c: Update.
1497         * f-valprint.c: Update.
1498         * fbsd-tdep.c: Update.
1499         * frame-unwind.c: Update.
1500         * frame.c: Update.
1501         * gdbtypes.c: Update.
1502         * gnu-v3-abi.c: Update.
1503         * guile/guile-internal.h: Update.
1504         * guile/scm-block.c: Update.
1505         * guile/scm-breakpoint.c: Update.
1506         * guile/scm-cmd.c: Update.
1507         * guile/scm-disasm.c: Update.
1508         * guile/scm-frame.c: Update.
1509         * guile/scm-lazy-string.c: Update.
1510         * guile/scm-math.c: Update.
1511         * guile/scm-param.c: Update.
1512         * guile/scm-ports.c: Update.
1513         * guile/scm-pretty-print.c: Update.
1514         * guile/scm-symbol.c: Update.
1515         * guile/scm-symtab.c: Update.
1516         * guile/scm-type.c: Update.
1517         * guile/scm-value.c: Update.
1518         * i386-linux-tdep.c: Update.
1519         * i386-tdep.c: Update.
1520         * inf-loop.c: Update.
1521         * infcall.c: Update.
1522         * infcmd.c: Update.
1523         * infrun.c: Update.
1524         * jit.c: Update.
1525         * language.c: Update.
1526         * linespec.c: Update.
1527         * linux-fork.c: Update.
1528         * linux-nat.c: Update.
1529         * linux-tdep.c: Update.
1530         * linux-thread-db.c: Update.
1531         * main.c: Update.
1532         * mi/mi-cmd-break.c: Update.
1533         * mi/mi-cmd-stack.c: Update.
1534         * mi/mi-interp.c: Update.
1535         * mi/mi-main.c: Update.
1536         * objc-lang.c: Update.
1537         * p-valprint.c: Update.
1538         * parse.c: Update.
1539         * ppc-linux-tdep.c: Update.
1540         * printcmd.c: Update.
1541         * python/py-arch.c: Update.
1542         * python/py-breakpoint.c: Update.
1543         * python/py-cmd.c: Update.
1544         * python/py-finishbreakpoint.c: Update.
1545         * python/py-frame.c: Update.
1546         * python/py-framefilter.c: Update.
1547         * python/py-gdb-readline.c: Update.
1548         * python/py-inferior.c: Update.
1549         * python/py-infthread.c: Update.
1550         * python/py-lazy-string.c: Update.
1551         * python/py-linetable.c: Update.
1552         * python/py-objfile.c: Update.
1553         * python/py-param.c: Update.
1554         * python/py-prettyprint.c: Update.
1555         * python/py-progspace.c: Update.
1556         * python/py-record-btrace.c: Update.
1557         * python/py-record.c: Update.
1558         * python/py-symbol.c: Update.
1559         * python/py-type.c: Update.
1560         * python/py-unwind.c: Update.
1561         * python/py-utils.c: Update.
1562         * python/py-value.c: Update.
1563         * python/python.c: Update.
1564         * record-btrace.c: Update.
1565         * record-full.c: Update.
1566         * remote-fileio.c: Update.
1567         * remote.c: Update.
1568         * riscv-tdep.c: Update.
1569         * rs6000-aix-tdep.c: Update.
1570         * rs6000-tdep.c: Update.
1571         * rust-exp.y: Update.
1572         * rust-lang.c: Update.
1573         * s390-tdep.c: Update.
1574         * selftest-arch.c: Update.
1575         * solib-dsbt.c: Update.
1576         * solib-frv.c: Update.
1577         * solib-spu.c: Update.
1578         * solib-svr4.c: Update.
1579         * solib.c: Update.
1580         * sparc64-linux-tdep.c: Update.
1581         * stack.c: Update.
1582         * symfile-mem.c: Update.
1583         * symmisc.c: Update.
1584         * target.c: Update.
1585         * thread.c: Update.
1586         * top.c: Update.
1587         * tracefile-tfile.c: Update.
1588         * tui/tui.c: Update.
1589         * typeprint.c: Update.
1590         * unittests/cli-utils-selftests.c: Update.
1591         * unittests/parse-connection-spec-selftests.c: Update.
1592         * valops.c: Update.
1593         * valprint.c: Update.
1594         * value.c: Update.
1595         * varobj.c: Update.
1596         * windows-nat.c: Update.
1597         * x86-linux-nat.c: Update.
1598         * xml-support.c: Update.
1599
1600 2019-04-08  Tom Tromey  <tom@tromey.com>
1601
1602         * xml-support.c: Use C++ exception handling.
1603         * x86-linux-nat.c: Use C++ exception handling.
1604         * windows-nat.c: Use C++ exception handling.
1605         * varobj.c: Use C++ exception handling.
1606         * value.c: Use C++ exception handling.
1607         * valprint.c: Use C++ exception handling.
1608         * valops.c: Use C++ exception handling.
1609         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1610         handling.
1611         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1612         * typeprint.c: Use C++ exception handling.
1613         * tui/tui.c: Use C++ exception handling.
1614         * tracefile-tfile.c: Use C++ exception handling.
1615         * top.c: Use C++ exception handling.
1616         * thread.c: Use C++ exception handling.
1617         * target.c: Use C++ exception handling.
1618         * symmisc.c: Use C++ exception handling.
1619         * symfile-mem.c: Use C++ exception handling.
1620         * stack.c: Use C++ exception handling.
1621         * sparc64-linux-tdep.c: Use C++ exception handling.
1622         * solib.c: Use C++ exception handling.
1623         * solib-svr4.c: Use C++ exception handling.
1624         * solib-spu.c: Use C++ exception handling.
1625         * solib-frv.c: Use C++ exception handling.
1626         * solib-dsbt.c: Use C++ exception handling.
1627         * selftest-arch.c: Use C++ exception handling.
1628         * s390-tdep.c: Use C++ exception handling.
1629         * rust-lang.c: Use C++ exception handling.
1630         * rust-exp.y: Use C++ exception handling.
1631         * rs6000-tdep.c: Use C++ exception handling.
1632         * rs6000-aix-tdep.c: Use C++ exception handling.
1633         * riscv-tdep.c: Use C++ exception handling.
1634         * remote.c: Use C++ exception handling.
1635         * remote-fileio.c: Use C++ exception handling.
1636         * record-full.c: Use C++ exception handling.
1637         * record-btrace.c: Use C++ exception handling.
1638         * python/python.c: Use C++ exception handling.
1639         * python/py-value.c: Use C++ exception handling.
1640         * python/py-utils.c: Use C++ exception handling.
1641         * python/py-unwind.c: Use C++ exception handling.
1642         * python/py-type.c: Use C++ exception handling.
1643         * python/py-symbol.c: Use C++ exception handling.
1644         * python/py-record.c: Use C++ exception handling.
1645         * python/py-record-btrace.c: Use C++ exception handling.
1646         * python/py-progspace.c: Use C++ exception handling.
1647         * python/py-prettyprint.c: Use C++ exception handling.
1648         * python/py-param.c: Use C++ exception handling.
1649         * python/py-objfile.c: Use C++ exception handling.
1650         * python/py-linetable.c: Use C++ exception handling.
1651         * python/py-lazy-string.c: Use C++ exception handling.
1652         * python/py-infthread.c: Use C++ exception handling.
1653         * python/py-inferior.c: Use C++ exception handling.
1654         * python/py-gdb-readline.c: Use C++ exception handling.
1655         * python/py-framefilter.c: Use C++ exception handling.
1656         * python/py-frame.c: Use C++ exception handling.
1657         * python/py-finishbreakpoint.c: Use C++ exception handling.
1658         * python/py-cmd.c: Use C++ exception handling.
1659         * python/py-breakpoint.c: Use C++ exception handling.
1660         * python/py-arch.c: Use C++ exception handling.
1661         * printcmd.c: Use C++ exception handling.
1662         * ppc-linux-tdep.c: Use C++ exception handling.
1663         * parse.c: Use C++ exception handling.
1664         * p-valprint.c: Use C++ exception handling.
1665         * objc-lang.c: Use C++ exception handling.
1666         * mi/mi-main.c: Use C++ exception handling.
1667         * mi/mi-interp.c: Use C++ exception handling.
1668         * mi/mi-cmd-stack.c: Use C++ exception handling.
1669         * mi/mi-cmd-break.c: Use C++ exception handling.
1670         * main.c: Use C++ exception handling.
1671         * linux-thread-db.c: Use C++ exception handling.
1672         * linux-tdep.c: Use C++ exception handling.
1673         * linux-nat.c: Use C++ exception handling.
1674         * linux-fork.c: Use C++ exception handling.
1675         * linespec.c: Use C++ exception handling.
1676         * language.c: Use C++ exception handling.
1677         * jit.c: Use C++ exception handling.
1678         * infrun.c: Use C++ exception handling.
1679         * infcmd.c: Use C++ exception handling.
1680         * infcall.c: Use C++ exception handling.
1681         * inf-loop.c: Use C++ exception handling.
1682         * i386-tdep.c: Use C++ exception handling.
1683         * i386-linux-tdep.c: Use C++ exception handling.
1684         * guile/scm-value.c: Use C++ exception handling.
1685         * guile/scm-type.c: Use C++ exception handling.
1686         * guile/scm-symtab.c: Use C++ exception handling.
1687         * guile/scm-symbol.c: Use C++ exception handling.
1688         * guile/scm-pretty-print.c: Use C++ exception handling.
1689         * guile/scm-ports.c: Use C++ exception handling.
1690         * guile/scm-param.c: Use C++ exception handling.
1691         * guile/scm-math.c: Use C++ exception handling.
1692         * guile/scm-lazy-string.c: Use C++ exception handling.
1693         * guile/scm-frame.c: Use C++ exception handling.
1694         * guile/scm-disasm.c: Use C++ exception handling.
1695         * guile/scm-cmd.c: Use C++ exception handling.
1696         * guile/scm-breakpoint.c: Use C++ exception handling.
1697         * guile/scm-block.c: Use C++ exception handling.
1698         * guile/guile-internal.h: Use C++ exception handling.
1699         * gnu-v3-abi.c: Use C++ exception handling.
1700         * gdbtypes.c: Use C++ exception handling.
1701         * frame.c: Use C++ exception handling.
1702         * frame-unwind.c: Use C++ exception handling.
1703         * fbsd-tdep.c: Use C++ exception handling.
1704         * f-valprint.c: Use C++ exception handling.
1705         * exec.c: Use C++ exception handling.
1706         * event-top.c: Use C++ exception handling.
1707         * event-loop.c: Use C++ exception handling.
1708         * eval.c: Use C++ exception handling.
1709         * dwarf2read.c: Use C++ exception handling.
1710         * dwarf2loc.c: Use C++ exception handling.
1711         * dwarf2-frame.c: Use C++ exception handling.
1712         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1713         * dwarf-index-write.c: Use C++ exception handling.
1714         * dwarf-index-cache.c: Use C++ exception handling.
1715         * dtrace-probe.c: Use C++ exception handling.
1716         * disasm-selftests.c: Use C++ exception handling.
1717         * darwin-nat.c: Use C++ exception handling.
1718         * cp-valprint.c: Use C++ exception handling.
1719         * cp-support.c: Use C++ exception handling.
1720         * cp-abi.c: Use C++ exception handling.
1721         * corelow.c: Use C++ exception handling.
1722         * completer.c: Use C++ exception handling.
1723         * compile/compile-object-run.c: Use C++ exception handling.
1724         * compile/compile-object-load.c: Use C++ exception handling.
1725         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1726         * compile/compile-c-symbols.c: Use C++ exception handling.
1727         * common/selftest.c: Use C++ exception handling.
1728         * common/new-op.c: Use C++ exception handling.
1729         * cli/cli-script.c: Use C++ exception handling.
1730         * cli/cli-interp.c: Use C++ exception handling.
1731         * cli/cli-cmds.c: Use C++ exception handling.
1732         * c-varobj.c: Use C++ exception handling.
1733         * btrace.c: Use C++ exception handling.
1734         * breakpoint.c: Use C++ exception handling.
1735         * break-catch-throw.c: Use C++ exception handling.
1736         * arch-utils.c: Use C++ exception handling.
1737         * amd64-tdep.c: Use C++ exception handling.
1738         * ada-valprint.c: Use C++ exception handling.
1739         * ada-typeprint.c: Use C++ exception handling.
1740         * ada-lang.c: Use C++ exception handling.
1741         * aarch64-tdep.c: Use C++ exception handling.
1742
1743 2019-04-08  Tom Tromey  <tom@tromey.com>
1744
1745         * xml-support.c (gdb_xml_parser::parse): Update.
1746         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1747         * value.c (show_convenience): Update.
1748         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1749         (test_parse_flags_qcs): Update.
1750         * thread.c (thr_try_catch_cmd): Update.
1751         * target.c (target_translate_tls_address): Update.
1752         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1753         (info_frame_command_core, frame_apply_command_count): Update.
1754         * rust-exp.y (rust_lex_exception_test): Update.
1755         * riscv-tdep.c (riscv_print_one_register_info): Update.
1756         * remote.c (remote_target::enable_btrace): Update.
1757         * record-btrace.c (record_btrace_enable_warn): Update.
1758         * python/py-utils.c (gdbpy_convert_exception): Update.
1759         * printcmd.c (do_one_display, print_variable_and_value): Update.
1760         * mi/mi-main.c (mi_print_exception): Update.
1761         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1762         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1763         * linux-nat.c (linux_nat_target::attach): Update.
1764         * linux-fork.c (class scoped_switch_fork_info): Update.
1765         * infrun.c (displaced_step_prepare): Update.
1766         * infcall.c (call_function_by_hand_dummy): Update.
1767         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1768         * gnu-v3-abi.c (print_one_vtable): Update.
1769         * frame.c (get_prev_frame_always): Update.
1770         * f-valprint.c (info_common_command_for_block): Update.
1771         * exec.c (try_open_exec_file): Update.
1772         * exceptions.c (print_exception, exception_print)
1773         (exception_fprintf, exception_print_same): Update.
1774         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1775         * dwarf-index-cache.c (index_cache::store)
1776         (index_cache::lookup_gdb_index): Update.
1777         * darwin-nat.c (maybe_cache_shell): Update.
1778         * cp-valprint.c (cp_print_value_fields): Update.
1779         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1780         (gcc_cplus_symbol_address): Update.
1781         * compile/compile-c-symbols.c (gcc_convert_symbol)
1782         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1783         * common/selftest.c: Update.
1784         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1785         a std::string.
1786         (exception_try_scope_entry, exception_try_scope_exit): Don't
1787         declare.
1788         (struct exception_try_scope): Remove.
1789         (TRY): Don't use exception_try_scope.
1790         (struct gdb_exception): Add constructor, operator=.
1791         <what>: New method.
1792         (struct gdb_exception_RETURN_MASK_ALL)
1793         (struct gdb_exception_RETURN_MASK_ERROR)
1794         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1795         (struct gdb_quit_bad_alloc): Update.
1796         * common/common-exceptions.c (exception_none): Change
1797         initializer.
1798         (struct catcher) <state, exception>: Initialize inline.
1799         <prev>: Remove member.
1800         (current_catcher): Remove.
1801         (catchers): New global.
1802         (exceptions_state_mc_init): Simplify.
1803         (catcher_pop): Remove.
1804         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1805         (try_scope_depth, exception_try_scope_entry)
1806         (exception_try_scope_exit): Remove.
1807         (throw_exception_sjlj): Update.
1808         (exception_messages, exception_messages_size): Remove.
1809         (throw_it): Simplify.
1810         (gdb_exception_sliced_copy): Remove.
1811         (throw_exception_cxx): Update.
1812         * cli/cli-script.c (script_from_file): Update.
1813         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1814         Update.
1815         * ada-valprint.c (ada_val_print): Update.
1816         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1817         (create_excep_cond_exprs): Update.
1818
1819 2019-04-08  Tom Tromey  <tom@tromey.com>
1820
1821         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1822         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1823         (TRY, CATCH, END_CATCH): Remove some definitions.
1824         * common/common-exceptions.c: Don't use GDB_XCPT.
1825         (catcher_list_size): Remove.
1826         (throw_exception, throw_it): Simplify.
1827
1828 2019-04-05  Tom Tromey  <tom@tromey.com>
1829
1830         Revert the header-sorting patch.
1831         * ft32-tdep.c: Revert.
1832         * frv-tdep.c: Revert.
1833         * frv-linux-tdep.c: Revert.
1834         * frame.c: Revert.
1835         * frame-unwind.c: Revert.
1836         * frame-base.c: Revert.
1837         * fork-child.c: Revert.
1838         * findvar.c: Revert.
1839         * findcmd.c: Revert.
1840         * filesystem.c: Revert.
1841         * filename-seen-cache.h: Revert.
1842         * filename-seen-cache.c: Revert.
1843         * fbsd-tdep.c: Revert.
1844         * fbsd-nat.h: Revert.
1845         * fbsd-nat.c: Revert.
1846         * f-valprint.c: Revert.
1847         * f-typeprint.c: Revert.
1848         * f-lang.c: Revert.
1849         * extension.h: Revert.
1850         * extension.c: Revert.
1851         * extension-priv.h: Revert.
1852         * expprint.c: Revert.
1853         * exec.h: Revert.
1854         * exec.c: Revert.
1855         * exceptions.c: Revert.
1856         * event-top.c: Revert.
1857         * event-loop.c: Revert.
1858         * eval.c: Revert.
1859         * elfread.c: Revert.
1860         * dwarf2read.h: Revert.
1861         * dwarf2read.c: Revert.
1862         * dwarf2loc.c: Revert.
1863         * dwarf2expr.h: Revert.
1864         * dwarf2expr.c: Revert.
1865         * dwarf2-frame.c: Revert.
1866         * dwarf2-frame-tailcall.c: Revert.
1867         * dwarf-index-write.h: Revert.
1868         * dwarf-index-write.c: Revert.
1869         * dwarf-index-common.c: Revert.
1870         * dwarf-index-cache.h: Revert.
1871         * dwarf-index-cache.c: Revert.
1872         * dummy-frame.c: Revert.
1873         * dtrace-probe.c: Revert.
1874         * disasm.h: Revert.
1875         * disasm.c: Revert.
1876         * disasm-selftests.c: Revert.
1877         * dictionary.c: Revert.
1878         * dicos-tdep.c: Revert.
1879         * demangle.c: Revert.
1880         * dcache.h: Revert.
1881         * dcache.c: Revert.
1882         * darwin-nat.h: Revert.
1883         * darwin-nat.c: Revert.
1884         * darwin-nat-info.c: Revert.
1885         * d-valprint.c: Revert.
1886         * d-namespace.c: Revert.
1887         * d-lang.c: Revert.
1888         * ctf.c: Revert.
1889         * csky-tdep.c: Revert.
1890         * csky-linux-tdep.c: Revert.
1891         * cris-tdep.c: Revert.
1892         * cris-linux-tdep.c: Revert.
1893         * cp-valprint.c: Revert.
1894         * cp-support.c: Revert.
1895         * cp-namespace.c: Revert.
1896         * cp-abi.c: Revert.
1897         * corelow.c: Revert.
1898         * corefile.c: Revert.
1899         * continuations.c: Revert.
1900         * completer.h: Revert.
1901         * completer.c: Revert.
1902         * complaints.c: Revert.
1903         * coffread.c: Revert.
1904         * coff-pe-read.c: Revert.
1905         * cli-out.h: Revert.
1906         * cli-out.c: Revert.
1907         * charset.c: Revert.
1908         * c-varobj.c: Revert.
1909         * c-valprint.c: Revert.
1910         * c-typeprint.c: Revert.
1911         * c-lang.c: Revert.
1912         * buildsym.c: Revert.
1913         * buildsym-legacy.c: Revert.
1914         * build-id.h: Revert.
1915         * build-id.c: Revert.
1916         * btrace.c: Revert.
1917         * bsd-uthread.c: Revert.
1918         * breakpoint.h: Revert.
1919         * breakpoint.c: Revert.
1920         * break-catch-throw.c: Revert.
1921         * break-catch-syscall.c: Revert.
1922         * break-catch-sig.c: Revert.
1923         * blockframe.c: Revert.
1924         * block.c: Revert.
1925         * bfin-tdep.c: Revert.
1926         * bfin-linux-tdep.c: Revert.
1927         * bfd-target.c: Revert.
1928         * bcache.c: Revert.
1929         * ax-general.c: Revert.
1930         * ax-gdb.h: Revert.
1931         * ax-gdb.c: Revert.
1932         * avr-tdep.c: Revert.
1933         * auxv.c: Revert.
1934         * auto-load.c: Revert.
1935         * arm-wince-tdep.c: Revert.
1936         * arm-tdep.c: Revert.
1937         * arm-symbian-tdep.c: Revert.
1938         * arm-pikeos-tdep.c: Revert.
1939         * arm-obsd-tdep.c: Revert.
1940         * arm-nbsd-tdep.c: Revert.
1941         * arm-nbsd-nat.c: Revert.
1942         * arm-linux-tdep.c: Revert.
1943         * arm-linux-nat.c: Revert.
1944         * arm-fbsd-tdep.c: Revert.
1945         * arm-fbsd-nat.c: Revert.
1946         * arm-bsd-tdep.c: Revert.
1947         * arch-utils.c: Revert.
1948         * arc-tdep.c: Revert.
1949         * arc-newlib-tdep.c: Revert.
1950         * annotate.h: Revert.
1951         * annotate.c: Revert.
1952         * amd64-windows-tdep.c: Revert.
1953         * amd64-windows-nat.c: Revert.
1954         * amd64-tdep.c: Revert.
1955         * amd64-sol2-tdep.c: Revert.
1956         * amd64-obsd-tdep.c: Revert.
1957         * amd64-obsd-nat.c: Revert.
1958         * amd64-nbsd-tdep.c: Revert.
1959         * amd64-nbsd-nat.c: Revert.
1960         * amd64-nat.c: Revert.
1961         * amd64-linux-tdep.c: Revert.
1962         * amd64-linux-nat.c: Revert.
1963         * amd64-fbsd-tdep.c: Revert.
1964         * amd64-fbsd-nat.c: Revert.
1965         * amd64-dicos-tdep.c: Revert.
1966         * amd64-darwin-tdep.c: Revert.
1967         * amd64-bsd-nat.c: Revert.
1968         * alpha-tdep.c: Revert.
1969         * alpha-obsd-tdep.c: Revert.
1970         * alpha-nbsd-tdep.c: Revert.
1971         * alpha-mdebug-tdep.c: Revert.
1972         * alpha-linux-tdep.c: Revert.
1973         * alpha-linux-nat.c: Revert.
1974         * alpha-bsd-tdep.c: Revert.
1975         * alpha-bsd-nat.c: Revert.
1976         * aix-thread.c: Revert.
1977         * agent.c: Revert.
1978         * addrmap.c: Revert.
1979         * ada-varobj.c: Revert.
1980         * ada-valprint.c: Revert.
1981         * ada-typeprint.c: Revert.
1982         * ada-tasks.c: Revert.
1983         * ada-lang.c: Revert.
1984         * aarch64-tdep.c: Revert.
1985         * aarch64-ravenscar-thread.c: Revert.
1986         * aarch64-newlib-tdep.c: Revert.
1987         * aarch64-linux-tdep.c: Revert.
1988         * aarch64-linux-nat.c: Revert.
1989         * aarch64-fbsd-tdep.c: Revert.
1990         * aarch64-fbsd-nat.c: Revert.
1991         * aarch32-linux-nat.c: Revert.
1992
1993 2019-04-05  Tom Tromey  <tom@tromey.com>
1994
1995         * ft32-tdep.c: Sort headers.
1996         * frv-tdep.c: Sort headers.
1997         * frv-linux-tdep.c: Sort headers.
1998         * frame.c: Sort headers.
1999         * frame-unwind.c: Sort headers.
2000         * frame-base.c: Sort headers.
2001         * fork-child.c: Sort headers.
2002         * findvar.c: Sort headers.
2003         * findcmd.c: Sort headers.
2004         * filesystem.c: Sort headers.
2005         * filename-seen-cache.h: Sort headers.
2006         * filename-seen-cache.c: Sort headers.
2007         * fbsd-tdep.c: Sort headers.
2008         * fbsd-nat.h: Sort headers.
2009         * fbsd-nat.c: Sort headers.
2010         * f-valprint.c: Sort headers.
2011         * f-typeprint.c: Sort headers.
2012         * f-lang.c: Sort headers.
2013         * extension.h: Sort headers.
2014         * extension.c: Sort headers.
2015         * extension-priv.h: Sort headers.
2016         * expprint.c: Sort headers.
2017         * exec.h: Sort headers.
2018         * exec.c: Sort headers.
2019         * exceptions.c: Sort headers.
2020         * event-top.c: Sort headers.
2021         * event-loop.c: Sort headers.
2022         * eval.c: Sort headers.
2023         * elfread.c: Sort headers.
2024         * dwarf2read.h: Sort headers.
2025         * dwarf2read.c: Sort headers.
2026         * dwarf2loc.c: Sort headers.
2027         * dwarf2expr.h: Sort headers.
2028         * dwarf2expr.c: Sort headers.
2029         * dwarf2-frame.c: Sort headers.
2030         * dwarf2-frame-tailcall.c: Sort headers.
2031         * dwarf-index-write.h: Sort headers.
2032         * dwarf-index-write.c: Sort headers.
2033         * dwarf-index-common.c: Sort headers.
2034         * dwarf-index-cache.h: Sort headers.
2035         * dwarf-index-cache.c: Sort headers.
2036         * dummy-frame.c: Sort headers.
2037         * dtrace-probe.c: Sort headers.
2038         * disasm.h: Sort headers.
2039         * disasm.c: Sort headers.
2040         * disasm-selftests.c: Sort headers.
2041         * dictionary.c: Sort headers.
2042         * dicos-tdep.c: Sort headers.
2043         * demangle.c: Sort headers.
2044         * dcache.h: Sort headers.
2045         * dcache.c: Sort headers.
2046         * darwin-nat.h: Sort headers.
2047         * darwin-nat.c: Sort headers.
2048         * darwin-nat-info.c: Sort headers.
2049         * d-valprint.c: Sort headers.
2050         * d-namespace.c: Sort headers.
2051         * d-lang.c: Sort headers.
2052         * ctf.c: Sort headers.
2053         * csky-tdep.c: Sort headers.
2054         * csky-linux-tdep.c: Sort headers.
2055         * cris-tdep.c: Sort headers.
2056         * cris-linux-tdep.c: Sort headers.
2057         * cp-valprint.c: Sort headers.
2058         * cp-support.c: Sort headers.
2059         * cp-namespace.c: Sort headers.
2060         * cp-abi.c: Sort headers.
2061         * corelow.c: Sort headers.
2062         * corefile.c: Sort headers.
2063         * continuations.c: Sort headers.
2064         * completer.h: Sort headers.
2065         * completer.c: Sort headers.
2066         * complaints.c: Sort headers.
2067         * coffread.c: Sort headers.
2068         * coff-pe-read.c: Sort headers.
2069         * cli-out.h: Sort headers.
2070         * cli-out.c: Sort headers.
2071         * charset.c: Sort headers.
2072         * c-varobj.c: Sort headers.
2073         * c-valprint.c: Sort headers.
2074         * c-typeprint.c: Sort headers.
2075         * c-lang.c: Sort headers.
2076         * buildsym.c: Sort headers.
2077         * buildsym-legacy.c: Sort headers.
2078         * build-id.h: Sort headers.
2079         * build-id.c: Sort headers.
2080         * btrace.c: Sort headers.
2081         * bsd-uthread.c: Sort headers.
2082         * breakpoint.h: Sort headers.
2083         * breakpoint.c: Sort headers.
2084         * break-catch-throw.c: Sort headers.
2085         * break-catch-syscall.c: Sort headers.
2086         * break-catch-sig.c: Sort headers.
2087         * blockframe.c: Sort headers.
2088         * block.c: Sort headers.
2089         * bfin-tdep.c: Sort headers.
2090         * bfin-linux-tdep.c: Sort headers.
2091         * bfd-target.c: Sort headers.
2092         * bcache.c: Sort headers.
2093         * ax-general.c: Sort headers.
2094         * ax-gdb.h: Sort headers.
2095         * ax-gdb.c: Sort headers.
2096         * avr-tdep.c: Sort headers.
2097         * auxv.c: Sort headers.
2098         * auto-load.c: Sort headers.
2099         * arm-wince-tdep.c: Sort headers.
2100         * arm-tdep.c: Sort headers.
2101         * arm-symbian-tdep.c: Sort headers.
2102         * arm-pikeos-tdep.c: Sort headers.
2103         * arm-obsd-tdep.c: Sort headers.
2104         * arm-nbsd-tdep.c: Sort headers.
2105         * arm-nbsd-nat.c: Sort headers.
2106         * arm-linux-tdep.c: Sort headers.
2107         * arm-linux-nat.c: Sort headers.
2108         * arm-fbsd-tdep.c: Sort headers.
2109         * arm-fbsd-nat.c: Sort headers.
2110         * arm-bsd-tdep.c: Sort headers.
2111         * arch-utils.c: Sort headers.
2112         * arc-tdep.c: Sort headers.
2113         * arc-newlib-tdep.c: Sort headers.
2114         * annotate.h: Sort headers.
2115         * annotate.c: Sort headers.
2116         * amd64-windows-tdep.c: Sort headers.
2117         * amd64-windows-nat.c: Sort headers.
2118         * amd64-tdep.c: Sort headers.
2119         * amd64-sol2-tdep.c: Sort headers.
2120         * amd64-obsd-tdep.c: Sort headers.
2121         * amd64-obsd-nat.c: Sort headers.
2122         * amd64-nbsd-tdep.c: Sort headers.
2123         * amd64-nbsd-nat.c: Sort headers.
2124         * amd64-nat.c: Sort headers.
2125         * amd64-linux-tdep.c: Sort headers.
2126         * amd64-linux-nat.c: Sort headers.
2127         * amd64-fbsd-tdep.c: Sort headers.
2128         * amd64-fbsd-nat.c: Sort headers.
2129         * amd64-dicos-tdep.c: Sort headers.
2130         * amd64-darwin-tdep.c: Sort headers.
2131         * amd64-bsd-nat.c: Sort headers.
2132         * alpha-tdep.c: Sort headers.
2133         * alpha-obsd-tdep.c: Sort headers.
2134         * alpha-nbsd-tdep.c: Sort headers.
2135         * alpha-mdebug-tdep.c: Sort headers.
2136         * alpha-linux-tdep.c: Sort headers.
2137         * alpha-linux-nat.c: Sort headers.
2138         * alpha-bsd-tdep.c: Sort headers.
2139         * alpha-bsd-nat.c: Sort headers.
2140         * aix-thread.c: Sort headers.
2141         * agent.c: Sort headers.
2142         * addrmap.c: Sort headers.
2143         * ada-varobj.c: Sort headers.
2144         * ada-valprint.c: Sort headers.
2145         * ada-typeprint.c: Sort headers.
2146         * ada-tasks.c: Sort headers.
2147         * ada-lang.c: Sort headers.
2148         * aarch64-tdep.c: Sort headers.
2149         * aarch64-ravenscar-thread.c: Sort headers.
2150         * aarch64-newlib-tdep.c: Sort headers.
2151         * aarch64-linux-tdep.c: Sort headers.
2152         * aarch64-linux-nat.c: Sort headers.
2153         * aarch64-fbsd-tdep.c: Sort headers.
2154         * aarch64-fbsd-nat.c: Sort headers.
2155         * aarch32-linux-nat.c: Sort headers.
2156
2157 2019-04-04  Tom Tromey  <tom@tromey.com>
2158
2159         * varobj.c (varobj_create): Update.
2160         * rust-exp.y (struct rust_parser) <update_innermost_block,
2161         lookup_symbol>: New methods.
2162         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2163         Rename.
2164         (rust_parser::rust_lookup_type)
2165         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2166         * printcmd.c (display_command, do_one_display): Update.
2167         * parser-defs.h (struct parser_state) <parser_state>: Add
2168         "tracker" parameter.
2169         (block_tracker): New member.
2170         (class innermost_block_tracker) <innermost_block_tracker>: Add
2171         "types" parameter.
2172         <reset>: Remove method.
2173         (innermost_block): Don't declare.
2174         (null_post_parser): Update.
2175         * parse.c (innermost_block): Remove global.
2176         (write_dollar_variable): Update.
2177         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2178         Remove "tracker_types" parameter.
2179         (parse_expression): Add "tracker" parameter.
2180         (parse_expression_for_completion): Update.
2181         (null_post_parser): Add "tracker" parameter.
2182         * p-exp.y: Update rules.
2183         * m2-exp.y: Update rules.
2184         * language.h (struct language_defn) <la_post_parser>: Add
2185         "tracker" parameter.
2186         * go-exp.y: Update rules.
2187         * f-exp.y: Update rules.
2188         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2189         parameter.
2190         * d-exp.y: Update rules.
2191         * c-exp.y: Update rules.
2192         * breakpoint.c (set_breakpoint_condition): Create an
2193         innermost_block_tracker.
2194         (watch_command_1): Likewise.
2195         * ada-lang.c (resolve): Add "tracker" parameter.
2196         (resolve_subexp): Likewise.
2197         * ada-exp.y (write_var_from_sym): Update.
2198
2199 2019-04-04  Tom Tromey  <tom@tromey.com>
2200
2201         * type-stack.h: New file.
2202         * type-stack.c: New file.
2203         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2204         type-stack.h.
2205         (insert_into_type_stack, insert_type, push_type, push_type_int)
2206         (insert_type_address_space, pop_type, pop_type_int)
2207         (pop_typelist, pop_type_stack, append_type_stack)
2208         (push_type_stack, get_type_stack, push_typelist)
2209         (follow_type_instance_flags, follow_types): Don't declare.
2210         * parse.c (type_stack): Remove global.
2211         (parse_exp_in_context): Update.
2212         (insert_into_type_stack, insert_type, push_type, push_type_int)
2213         (insert_type_address_space, pop_type, pop_type_int)
2214         (pop_typelist, pop_type_stack, append_type_stack)
2215         (push_type_stack, get_type_stack, push_typelist)
2216         (follow_type_instance_flags, follow_types): Remove (moved to
2217         type-stack.c).
2218         * f-exp.y (type_stack): New global.
2219         Update rules.
2220         (push_kind_type, f_parse): Update.
2221         * d-exp.y (type_stack): New global.
2222         Update rules.
2223         (d_parse): Update.
2224         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2225         Update rules.
2226         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2227         (HFILES_NO_SRCDIR): Add type-stack.h.
2228
2229 2019-04-04  Tom Tromey  <tom@tromey.com>
2230
2231         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2232         (rust_parser::convert_ast_to_expression, rust_parse)
2233         (rust_lex_test_completion, rust_lex_tests): Update.
2234         * parser-defs.h (struct expr_completion_state): New.
2235         (struct parser_state) <parser_state>: Add completion parameter.
2236         <mark_struct_expression, mark_completion_tag>: New methods.
2237         <parse_completion, m_completion_state>: New members.
2238         (prefixify_expression, null_post_parser): Update.
2239         (mark_struct_expression, mark_completion_tag): Don't declare.
2240         * parse.c (parse_completion, expout_last_struct)
2241         (expout_tag_completion_type, expout_completion_name): Remove
2242         globals.
2243         (parser_state::mark_struct_expression)
2244         (parser_state::mark_completion_tag): Now methods.
2245         (prefixify_expression): Add last_struct parameter.
2246         (prefixify_subexp): Likewise.
2247         (parse_exp_1): Update.
2248         (parse_exp_in_context): Add cstate parameter.  Update.
2249         (parse_expression_for_completion): Create an
2250         expr_completion_state.
2251         (null_post_parser): Add "completion" parameter.
2252         * p-exp.y: Update rules.
2253         (yylex): Update.
2254         * language.h (struct language_defn) <la_post_parser>: Add
2255         "completing" parameter.
2256         * go-exp.y: Update rules.
2257         (lex_one_token): Update.
2258         * expression.h (parse_completion): Don't declare.
2259         * d-exp.y: Update rules.
2260         (lex_one_token): Update rules.
2261         * c-exp.y: Update rules.
2262         (lex_one_token): Update.
2263         * ada-lang.c (resolve): Add "parse_completion" parameter.
2264         (resolve_subexp): Likewise.
2265         (ada_resolve_function): Likewise.
2266
2267 2019-04-04  Tom Tromey  <tom@tromey.com>
2268
2269         * parser-defs.h (struct parser_state) <start_arglist,
2270         end_arglist>: New methods.
2271         <arglist_len, m_funcall_chain>: New members.
2272         (arglist_len, start_arglist, end_arglist): Don't declare.
2273         * parse.c (arglist_len, funcall_chain): Remove global.
2274         (start_arglist, end_arglist): Remove functions.
2275         (parse_exp_in_context): Update.
2276         * p-exp.y: Update rules.
2277         * m2-exp.y: Update rules.
2278         * go-exp.y: Update rules.
2279         * f-exp.y: Update rules.
2280         * d-exp.y: Update rules.
2281         * c-exp.y: Update rules.
2282
2283 2019-04-04  Tom Tromey  <tom@tromey.com>
2284
2285         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2286         lex_operator, push_back>: New methods.
2287         Update all rules.
2288         (rust_parser::lex_hex, lex_escape): Rename and update.
2289         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2290         (rust_parser::lex_operator): Rename and update.
2291         (rust_parser::lex_number, rustyylex, rustyyerror)
2292         (rust_lex_test_init, rust_lex_test_sequence)
2293         (rust_lex_test_push_back, rust_lex_tests): Update.
2294         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2295         parameter.
2296         <lexptr, prev_lexptr>: New members.
2297         (lexptr, prev_lexptr): Don't declare.
2298         * parse.c (lexptr, prev_lexptr): Remove globals.
2299         (parse_exp_in_context): Update.
2300         * p-exp.y (yylex, yyerror): Update.
2301         * m2-exp.y (parse_number, yylex, yyerror): Update.
2302         * go-exp.y (lex_one_token, yyerror): Update.
2303         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2304         * d-exp.y (lex_one_token, yyerror): Update.
2305         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2306         (lex_one_token, yyerror): Update.
2307         * ada-lex.l (YY_INPUT): Update.
2308         (rewind_to_char): Update.
2309         * ada-exp.y (yyerror): Update.
2310
2311 2019-04-04  Tom Tromey  <tom@tromey.com>
2312
2313         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2314         * parser-defs.h (struct parser_state) <parser_state>: Add new
2315         parameter.
2316         <comma_terminates>: New member.
2317         (comma_terminates): Don't declare global.
2318         * parse.c (comma_terminates): Remove global.
2319         (parse_exp_in_context): Update.
2320         * p-exp.y (yylex): Update.
2321         * m2-exp.y (yylex): Update.
2322         * go-exp.y (lex_one_token): Update.
2323         * f-exp.y (yylex): Update.
2324         * d-exp.y (lex_one_token): Update.
2325         * c-exp.y (lex_one_token): Update.
2326         * ada-lex.l: Update.
2327
2328 2019-04-04  Tom Tromey  <tom@tromey.com>
2329
2330         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2331         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2332         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2333         * parser-defs.h (paren_depth): Don't declare.
2334         * parse.c (paren_depth): Remove global.
2335         (parse_exp_in_context): Update.
2336         * p-exp.y (paren_depth): New global.
2337         (pascal_parse): Initialize it.
2338         * m2-exp.y (paren_depth): New global.
2339         (m2_parse): Initialize it.
2340         * go-exp.y (paren_depth): New global.
2341         (go_parse): Initialize it.
2342         * f-exp.y (paren_depth): New global.
2343         (f_parse): Initialize it.
2344         * d-exp.y (paren_depth): New global.
2345         (d_parse): Initialize it.
2346         * c-exp.y (paren_depth): New global.
2347         (c_parse): Initialize it.
2348         * ada-lex.l (paren_depth): New global.
2349         (lexer_init): Initialize it.
2350
2351 2019-04-04  Tom Tromey  <tom@tromey.com>
2352
2353         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2354         (rust_parser::convert_ast_to_type)
2355         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2356         * parser-defs.h (struct parser_state) <parser_state>: Add
2357         parameters.  Initialize new members.
2358         <expression_context_block, expression_context_pc>: New members.
2359         * parse.c (expression_context_block, expression_context_pc):
2360         Remove globals.
2361         (parse_exp_in_context): Update.
2362         * p-exp.y: Update all rules.
2363         (yylex): Update.
2364         * m2-exp.y: Update all rules.
2365         (yylex): Update.
2366         * go-exp.y (yylex): Update.
2367         * f-exp.y (yylex): Update.
2368         * d-exp.y: Update all rules.
2369         (yylex): Update.
2370         * c-exp.y: Update all rules.
2371         (lex_one_token, classify_name, yylex, c_parse): Update.
2372         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2373
2374 2019-04-04  Tom Tromey  <tom@tromey.com>
2375
2376         * gdbarch.h, gdbarch.c: Rebuild.
2377         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2378         * stap-probe.h:
2379         (struct stap_parse_info): Replace "parser_state" with
2380         "expr_builder".
2381         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2382         (parser_state): New class.
2383         * parse.c (expr_builder): Rename.
2384         (expr_builder::release): Rename.
2385         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2386         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2387         (write_exp_elt_longcst, write_exp_elt_floatcst)
2388         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2389         (write_exp_string_vector, write_exp_bitstring)
2390         (write_exp_msymbol, mark_struct_expression)
2391         (write_dollar_variable)
2392         (insert_type_address_space, increase_expout_size): Replace
2393         "parser_state" with "expr_builder".
2394         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2395         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2396         "parser_state" with "expr_builder".
2397
2398 2019-04-04  Tom Tromey  <tom@tromey.com>
2399
2400         * rust-exp.y: Replace "parse_language" with method call.
2401         * p-exp.y:
2402         (yylex): Replace "parse_language" with method call.
2403         * m2-exp.y:
2404         (yylex): Replace "parse_language" with method call.
2405         * go-exp.y (classify_name): Replace "parse_language" with method
2406         call.
2407         * f-exp.y (yylex): Replace "parse_language" with method call.
2408         * d-exp.y (lex_one_token): Replace "parse_language" with method
2409         call.
2410         * c-exp.y:
2411         (lex_one_token, classify_name, yylex): Replace "parse_language"
2412         with method call.
2413         * ada-exp.y (find_primitive_type, type_char)
2414         (type_system_address): Replace "parse_language" with method call.
2415
2416 2019-04-04  Tom Tromey  <tom@tromey.com>
2417
2418         * rust-exp.y: Replace "parse_gdbarch" with method call.
2419         * parse.c (write_dollar_variable, insert_type_address_space):
2420         Replace "parse_gdbarch" with method call.
2421         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2422         call.
2423         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2424         call.
2425         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2426         "parse_gdbarch" with method call.
2427         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2428         with method call.
2429         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2430         "parse_gdbarch" with method call.
2431         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2432         "parse_gdbarch" with method call.
2433         * c-exp.y (parse_type, parse_number, classify_name): Replace
2434         "parse_gdbarch" with method call.
2435         * ada-lex.l: Replace "parse_gdbarch" with method call.
2436         * ada-exp.y (parse_type, find_primitive_type, type_char)
2437         (type_system_address): Replace "parse_gdbarch" with method call.
2438
2439 2019-04-04  Tom Tromey  <tom@tromey.com>
2440
2441         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2442         * stap-probe.c (stap_parse_argument): Update.
2443         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2444         initial_size parameter.
2445         * rust-exp.y (rust_lex_tests): Update.
2446         * parse.c (parser_state): Update.
2447         (parse_exp_in_context): Update.
2448         * parser-defs.h (struct parser_state) <parser_state>: Remove
2449         "initial_size" parameter.
2450
2451 2019-04-04  Tom Tromey  <tom@tromey.com>
2452
2453         * parser-defs.h (increase_expout_size): Don't declare.
2454         * parse.c (increase_expout_size): Now static.
2455
2456 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2457
2458         * gnu-nat.c (gnu_nat_target::wait): Fix
2459         target_waitstatus_to_string call.
2460
2461 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2462
2463         * eval.c (evaluate_subexp_standard): Handle internal functions
2464         during Fortran function call handling.
2465
2466 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2467
2468         * NEWS: Mention new internal functions.
2469         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2470         (read_base_type): Use dwarf2_init_complex_target_type.
2471         * value.c (creal_internal_fn): New function.
2472         (cimag_internal_fn): New function.
2473         (_initialize_values): Register new internal functions.
2474
2475 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2476
2477         * infrun.c (stop_all_threads): If debug_infrun, always
2478         trace the wait status after wait_one, using
2479         target_waitstatus_to_string and target_pid_to_str.
2480         (handle_inferior_event): Replace various trace of
2481         wait status kind by a single trace.
2482         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2483         wait status kind image by target_waitstatus_to_string.
2484         * target/waitstatus.c (target_waitstatus_to_string): Fix
2485         obsolete comment.
2486
2487 2019-04-01  Tom Tromey  <tromey@adacore.com>
2488
2489         PR symtab/23331:
2490         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2491
2492 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2493             Pedro Alves  <palves@redhat.com>
2494
2495         * top.c (quit_force): Call 'finalize_values'.
2496         * value.c (finalize_values): New function.
2497         * value.h (finalize_values): Declare.
2498
2499 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2500
2501         * NEWS: Announce $_gdb_major and $_gdb_minor.
2502
2503         * top.c (init_gdb_version_vars): New function.
2504         (gdb_init): Call init_gdb_version_vars.
2505
2506 2019-03-29  Tom Tromey  <tromey@adacore.com>
2507
2508         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2509         help text.  Remove dead code.
2510
2511 2019-03-29  Keith Seitz  <keiths@redhat.com>
2512
2513         From Siddhesh Poyarekar:
2514         * f-lang.h (f77_get_upperbound): Return LONGEST.
2515         (f77_get_lowerbound): Likewise.
2516         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2517         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2518         print them.
2519         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2520         plongest to format print it.
2521         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2522         (f77_get_upperbound): Likewise.
2523         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2524         LOWER_BOUND to LONGEST.
2525         (f77_create_arrayprint_offset_tbl): Likewise.
2526
2527 2019-03-29  Keith Seitz  <keiths@redhat.com>
2528
2529         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2530         %s/pulongest for TYPE_LENGTH instead of %d in format
2531         strings.
2532         * ada-typerint.c (ada_print_type): Likewise.
2533         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2534         * compile/compile-c-support.c (generate_register_struct): Likewise.
2535         * gdbtypes.c (recursive_dump_type): Likewise.
2536         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2537         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2538         instead of %d in format strings.
2539         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2540         to std::min to ULONGEST.
2541         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2542         instead of %d in format strings.
2543         * tracepoint.c (info_scope_command): Likewise.
2544         * typeprint.c (print_offset_data::update)
2545         (print_offset_data::finish): Likewise.
2546         * xtensa-tdep.c (xtensa_store_return_value)
2547         (xtensa_push_dummy_call): Likewise.
2548
2549 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2550
2551         * windows-nat.c (display_selector): Fixed format specifications
2552         for 64-bit Cygwin.
2553
2554 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2555
2556         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2557
2558 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2559
2560         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2561         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2562         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2563         (nios2_linux_init_abi): Install it.
2564
2565 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2566
2567         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2568
2569 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2570
2571         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2572
2573 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2574             Tom Tromey  <tromey@adacore.com>
2575
2576         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2577
2578 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2579
2580         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2581         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2582         method to compute the bounds of range types. Also print "[evaluated]"
2583         if the bounds' values come from a dynamic evaluation.
2584
2585 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2586
2587         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2588         whitespace when pretty printing is on.
2589
2590 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2591
2592         * ppc-linux-nat.c: Add include.
2593
2594 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2595
2596         * NEWS: Mention AArch64 Pointer Authentication.
2597
2598 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2599
2600         * arm-linux-nat.c: Add include.
2601
2602 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2603
2604         * source-cache.c (source_cache::get_source_lines): Re-read
2605         fullname after calling open_source_file.
2606
2607 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2608
2609         * NEWS: Mention TLS support for FreeBSD.
2610
2611 2019-03-25  Tom Tromey  <tromey@adacore.com>
2612
2613         * minsyms.c (BUNCH_SIZE): Update comment.
2614         (~minimal_symbol_reader): Remove old comment.
2615         (compact_minimal_symbols): Update comment.
2616         (minimal_symbol_reader::install): Remove old comment.  Update
2617         other comments.
2618
2619 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2620
2621         * s390-linux-nat.c: Add include.
2622
2623 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2624
2625         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2626         Call linux_get_hwcap.
2627         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2628         Likewise.
2629         (aarch64_linux_get_hwcap): Remove function.
2630         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2631         declaration.
2632         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2633         linux_get_hwcap.
2634         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2635         * linux-tdep.c (linux_get_hwcap): Add function.
2636         (linux_get_hwcap2): Likewise.
2637         * linux-tdep.h (linux_get_hwcap): Add declaration.
2638         (linux_get_hwcap2): Likewise.
2639         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2640         (ppc_linux_get_hwcap2): Likewise.
2641         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2642         linux_get_hwcap.
2643         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2644         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2645         (ppc_linux_nat_target::read_description): Likewise.
2646         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2647         * s390-linux-nat.c: Likewise.
2648         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2649
2650 2019-03-24  Tom Tromey  <tom@tromey.com>
2651
2652         * ada-lang.c (standard_lookup): Simplify initialization.
2653         (ada_lookup_symbol_nonlocal): Simplify return.
2654         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2655         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2656         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2657         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2658         initialization.
2659         * solib.c (solib_global_lookup): Simplify.
2660         * symtab.c (null_block_symbol): Remove.
2661         (symbol_cache_lookup): Simplify returns.
2662         (lookup_language_this): Simplify returns.
2663         (lookup_symbol_aux): Simplify return.
2664         (lookup_local_symbol): Simplify returns.
2665         (lookup_global_symbol_from_objfile): Simplify return.
2666         (lookup_symbol_in_objfile_symtabs)
2667         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2668         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2669         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2670         * cp-namespace.c (cp_lookup_bare_symbol)
2671         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2672         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2673         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2674         (cp_lookup_symbol_via_imports): Simplify initialization.
2675         (find_symbol_in_baseclass): Likewise.
2676         * symtab.h (null_block_symbol): Remove.
2677         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2678         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2679         (d_lookup_symbol_module): Likewise.
2680         (find_symbol_in_baseclass): Simplify initialization.
2681
2682 2019-03-24  Tom Tromey  <tom@tromey.com>
2683
2684         * expression.h: Don't include symtab.h.
2685         (struct block): Forward declare.
2686
2687 2019-03-24  Tom Tromey  <tom@tromey.com>
2688
2689         * c-exp.y (typebase): Remove casts.
2690         * gdbtypes.c (lookup_unsigned_typename, )
2691         (lookup_signed_typename): Remove cast.
2692         * eval.c (parse_to_comma_and_eval): Remove cast.
2693         * parse.c (write_dollar_variable): Remove cast.
2694         * block.h (struct block) <superblock>: Now const.
2695         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2696         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2697         (map_block): Make "block" const.
2698         * symfile.h (struct quick_symbol_functions)
2699         <map_matching_symbols>: Constify block argument to "callback".
2700         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2701         const.
2702         (find_pc_sect_compunit_symtab): Make "b" const.
2703         (find_symbol_at_address): Likewise.
2704         (search_symbols): Likewise.
2705         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2706         (dw2_debug_names_lookup_symbol): Likewise.
2707         (dw2_map_matching_symbols): Update.
2708         * p-valprint.c (pascal_val_print): Remove "block".
2709         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2710         (aux_add_nonlocal_symbols): Make "block" const.
2711         (resolve_subexp): Remove cast.
2712         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2713         const.
2714         (iterate_over_file_blocks): Likewise.
2715         * f-exp.y (%union) <bval>: Remove.
2716         * coffread.c (patch_opaque_types): Make "b" const.
2717         * spu-tdep.c (spu_catch_start): Make "block" const.
2718         * c-valprint.c (print_unpacked_pointer): Remove "block".
2719         * symmisc.c (dump_symtab_1): Make "b" const.
2720         (block_depth): Make "block" const.
2721         * d-exp.y (%union) <bval>: Remove.
2722         * cp-support.h (cp_lookup_rtti_type): Update.
2723         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2724         * psymtab.c (psym_lookup_symbol): Make "block" const.
2725         (maintenance_check_psymtabs): Make "b" const.
2726         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2727         (enumerate_locals, enumerate_args): Update.
2728         * python/py-symtab.c (stpy_global_block): Make "block" const.
2729         (stpy_static_block): Likewise.
2730         * inline-frame.c (block_starting_point_at): Make "new_block"
2731         const.
2732         * block.c (find_block_in_blockvector): Make return type const.
2733         (blockvector_for_pc_sect): Make "b" const.
2734         (find_block_in_blockvector): Make "b" const.
2735
2736 2019-03-23  Tom Tromey  <tom@tromey.com>
2737
2738         * varobj.c (varobj_create): Update.
2739         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2740         * printcmd.c (display_command, do_one_display): Don't reset
2741         innermost_block.
2742         * parser-defs.h (enum innermost_block_tracker_type): Move to
2743         expression.h.
2744         (innermost_block): Update comment.
2745         * parse.c (parse_exp_1): Add tracker_types parameter.
2746         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2747         tracker_types parameter.  Reset innermost_block.
2748         (parse_exp_in_context): Remove.
2749         (parse_expression_for_completion): Update.
2750         * objfiles.c (~objfile): Don't reset expression_context_block or
2751         innermost_block.
2752         * expression.h (enum innermost_block_tracker_type): Move from
2753         parser-defs.h.
2754         (parse_exp_1): Add tracker_types parameter.
2755         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2756         reset innermost_block.
2757
2758 2019-03-23  Tom Tromey  <tom@tromey.com>
2759
2760         * objfiles.h: Include bcache.h.
2761
2762 2019-03-23  Tom Tromey  <tom@tromey.com>
2763
2764         * linespec.c (get_current_search_block): Use
2765         scoped_restore_current_language.
2766         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2767
2768 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2769             Jiong Wang  <jiong.wang@arm.com>
2770
2771         * aarch64-linux-tdep.c
2772         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2773         section.
2774         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2775
2776 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2777             Jiong Wang  <jiong.wang@arm.com>
2778
2779         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2780         instructions.
2781         (aarch64_analyze_prologue_test): Add PACIASP test.
2782         (aarch64_prologue_prev_register): Unmask PC value.
2783
2784 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2785             Jiong Wang  <jiong.wang@arm.com>
2786
2787         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2788         (aarch64_dwarf2_prev_register): Unmask PC value.
2789         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2790         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2791         DW_CFA_AARCH64_negate_ra_state.
2792         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2793
2794 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2795             Jiong Wang  <jiong.wang@arm.com>
2796
2797         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2798         registers.
2799         (aarch64_pseudo_register_name): Likewise.
2800         (aarch64_pseudo_register_type): Likewise.
2801         (aarch64_pseudo_register_reggroup_p): Likewise.
2802         (aarch64_gdbarch_init): Add pauth registers.
2803         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2804         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2805         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2806         (struct gdbarch_tdep): Add regnum for ra_state.
2807
2808 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2809             Jiong Wang  <jiong.wang@arm.com>
2810
2811         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2812
2813 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2814             Jiong Wang  <jiong.wang@arm.com>
2815
2816         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2817         function.
2818         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2819         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2820         (aarch64_gdbarch_init): Add puth registers.
2821         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2822         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2823         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2824
2825 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2826             Jiong Wang  <jiong.wang@arm.com>
2827
2828         * aarch64-linux-nat.c
2829         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2830         * aarch64-linux-tdep.c
2831         (aarch64_linux_core_read_description): Likewise.
2832         (aarch64_linux_get_hwcap): New function.
2833         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2834         (aarch64_linux_get_hwcap): New declaration.
2835
2836 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2837             Jiong Wang  <jiong.wang@arm.com>
2838
2839         * aarch64-linux-nat.c
2840         (aarch64_linux_nat_target::read_description): Add pauth param.
2841         * aarch64-linux-tdep.c
2842         (aarch64_linux_core_read_description): Likewise.
2843         * aarch64-tdep.c (struct target_desc): Add in pauth.
2844         (aarch64_read_description): Add pauth param.
2845         (aarch64_gdbarch_init): Likewise.
2846         * aarch64-tdep.h (aarch64_read_description): Likewise.
2847         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2848         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2849         * features/Makefile: Add new files.
2850         * features/aarch64-pauth.c: New file.
2851         * features/aarch64-pauth.xml: New file.
2852
2853 2019-03-20  Tom Tromey  <tromey@adacore.com>
2854
2855         * infrun.c (handle_inferior_event): Rename from
2856         handle_inferior_event_1.  Create a scoped_value_mark.
2857         (handle_inferior_event): Remove.
2858
2859 2019-03-19  Tom Tromey  <tromey@adacore.com>
2860
2861         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2862         * infrun.h (print_stop_event): Add "displays" parameter.
2863         * infrun.c (print_stop_event): Add "displays" parameter.
2864
2865 2019-03-19  Pedro Alves  <palves@redhat.com>
2866
2867         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2868         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2869         to -1.  Fix TABs vs spaces.
2870         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2871         * tui/tui-out.h (tui_ui_out) Add intro comments.
2872         <m_line, m_start_of_line>: In-class initialize, and add describing
2873         comment.
2874
2875 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2876
2877         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2878         variable names.
2879         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2880
2881 2019-03-18  Pedro Alves  <palves@redhat.com>
2882             Eli Zaretskii <eliz@gnu.org>
2883
2884         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2885         m_line and m_start_of_line.
2886
2887 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2888
2889         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2890         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2891         it returns a newline.  This fixes a regression in TU mode, whereby
2892         the next line is output on the same screen line as the user input.
2893
2894 2019-03-18  Tom Tromey  <tromey@adacore.com>
2895
2896         * minsyms.c (minimal_symbol_reader::install): Remove call to
2897         obstack_blank.
2898
2899 2019-03-18  Pedro Alves  <palves@redhat.com>
2900
2901         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2902         New globals.
2903         (apply_style): New, factored out from ...
2904         (apply_ansi_escape): ... this.  Handle reverse video mode.
2905         (tui_set_reverse_mode): New function.
2906         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2907         * tui/tui-winsource.c (tui_show_source_line): Use
2908         tui_set_reverse_mode instead of setting A_STANDOUT.
2909         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2910         New setter methods.
2911
2912 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2913
2914         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2915         Handle tabs.
2916
2917 2019-03-18  Tom Tromey  <tromey@adacore.com>
2918
2919         * ada-lang.c (empty_array): Add "high" parameter.
2920         (ada_evaluate_subexp): Update.
2921
2922 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2923
2924         * unittests/string_view-selftests.c: Define
2925         _initialize_string_view_selftests unconditionally.
2926
2927 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2928
2929         PR gdb/24350
2930         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2931
2932 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2933
2934         PR gdb/24351
2935         * windows-nat.c (display_selector): Fix format specifiers.
2936
2937 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2938
2939         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2940         tui_refill_source_window instead of tui_refresh_win, to update the
2941         current execution line.  This fixes redisplay of the current line
2942         when stepping through the code with "next" or "step".
2943
2944 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2945
2946         * source-cache.c (source_cache::get_source_lines): Call
2947         find_source_lines to initialize s->nlines.  This fixes vertical
2948         scrolling of TUI source window when the DOWN arrow is pressed.
2949
2950 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2951
2952         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2953         linux-thread-db.c (_initialize_thread_db): Likewise.
2954
2955 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2956
2957         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2958         wclrtoeol in tui_show_source_line".  This reverts changes made in
2959         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2960
2961 2019-03-15  Tom Tromey  <tom@tromey.com>
2962
2963         * symtab.h (struct minimal_symbol): Derive from
2964         general_symbol_info.
2965         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2966         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2967         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2968         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2969         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2970         (MSYMBOL_SEARCH_NAME): Update.
2971         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2972         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2973         * minsyms.c (minimal_symbol_reader::record_full): Update.
2974
2975 2019-03-15  Tom Tromey  <tom@tromey.com>
2976
2977         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2978
2979 2019-03-15  Tom Tromey  <tom@tromey.com>
2980
2981         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2982         unique_xmalloc_ptr.
2983         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2984         Update.
2985         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2986         (build_minimal_symbol_hash_tables)
2987         (minimal_symbol_reader::install): Update.
2988
2989 2019-03-15  Tom Tromey  <tom@tromey.com>
2990
2991         * symtab.c (create_demangled_names_hash): Update.
2992         (symbol_set_names): Update.
2993         * objfiles.h (struct objfile_per_bfd_storage)
2994         <demangled_names_hash>: Now an htab_up.
2995         * objfiles.c (objfile_per_bfd_storage): Simplify.
2996
2997 2019-03-15  Tom Tromey  <tom@tromey.com>
2998
2999         * objfiles.h (struct objfile_per_bfd_storage): Declare
3000         destructor.
3001         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3002         New.
3003         (get_objfile_bfd_data): Use new.  Don't initialize
3004         language_of_main.
3005         (free_objfile_per_bfd_storage): Remove.
3006         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3007
3008 2019-03-15  Tom Tromey  <tom@tromey.com>
3009
3010         * symfile.c (reread_symbols): Update.
3011         * objfiles.c (objfile::objfile): Update.
3012         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3013         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3014         comment.
3015         (minimal_symbol_reader::install): Update.
3016         (terminate_minimal_symbol_table): Remove.
3017         * jit.c (jit_object_close_impl): Update.
3018
3019 2019-03-15  Tom Tromey  <tom@tromey.com>
3020
3021         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3022         initializations.
3023
3024 2019-03-15  Tom Tromey  <tom@tromey.com>
3025
3026         * objfiles.h (struct objfile_per_bfd_storage)
3027         <demangled_hash_languages>: Now a bitset.
3028         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3029         (lookup_minimal_symbol): Update.
3030
3031 2019-03-15  Tom Tromey  <tom@tromey.com>
3032
3033         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3034         Don't return the symbol.
3035         * coffread.c (record_minimal_symbol): Use record_full.
3036
3037 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3038
3039         The MS-Windows port of ncurses fails to switch to a color pair if
3040         one or both of the colors are the implicit default colors.  This
3041         change records the default colors when TUI is initialized, and
3042         then specifies them explicitly when a color pair uses the default
3043         colors.  This allows color styling in TUI mode on MS-Windows.
3044
3045         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3046         ncurses_norm_attr.
3047         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3048         colors in ncurses_norm_attr.
3049         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3050         "none", replace it with the default color recorded in
3051         ncurses_norm_attr.
3052
3053 2019-03-14  Tom Tromey  <tromey@adacore.com>
3054
3055         * source-cache.h (class source_cache) <get_source_lines>: Return
3056         std::string.
3057         * source-cache.c (source_cache::extract_lines): Handle case where
3058         first_pos==npos.  Return std::string.
3059         (source_cache::get_source_lines): Update.
3060
3061 2019-03-14  Tom Tromey  <tromey@adacore.com>
3062
3063         * NEWS: Add item for "style sources" commands.
3064         * source-cache.c (source_cache::get_source_lines): Check
3065         source_styling.
3066         * cli/cli-style.c (source_styling): New global.
3067         (_initialize_cli_style): Add "style sources" commands.
3068         (show_style_sources): New function.
3069         * cli/cli-style.h (source_styling): Declare.
3070
3071 2019-03-14  Pedro Alves  <palves@redhat.com>
3072             Tom Tromey  <tromey@adacore.com>
3073
3074         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3075         * tui/tui-winsource.c (tui_refill_source_window): New function,
3076         from...
3077         (tui_horizontal_source_scroll): ... here.  Move some logic.
3078         * cli/cli-style.c (set_style_enabled): Notify new observable.
3079         * tui/tui-hooks.c (tui_redisplay_source): New function.
3080         (tui_attach_detach_observers): Attach or detach
3081         tui_redisplay_source.
3082         * observable.h (source_styling_changed): New observable.
3083         * observable.c: Define source_styling_changed observable.
3084
3085 2019-03-13  Tom Tromey  <tromey@adacore.com>
3086
3087         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3088         (i386_gnu_nat_target::store_registers): Update.
3089         * target-debug.h (target_debug_print_std_string): New macro.
3090         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3091         * windows-tdep.c (display_one_tib): Update.
3092         * tui/tui-stack.c (tui_make_status_line): Update.
3093         * top.c (print_inferior_quit_action): Update.
3094         * thread.c (thr_try_catch_cmd): Update.
3095         (add_thread_with_info): Update.
3096         (thread_target_id_str): Update.
3097         (thr_try_catch_cmd): Update.
3098         (thread_command): Update.
3099         (thread_find_command): Update.
3100         * record-btrace.c (record_btrace_target::info_record)
3101         (record_btrace_resume_thread, record_btrace_target::resume)
3102         (record_btrace_cancel_resume, record_btrace_step_thread)
3103         (record_btrace_target::wait, record_btrace_target::wait)
3104         (record_btrace_target::wait, record_btrace_target::stop): Update.
3105         * progspace.c (print_program_space): Update.
3106         * process-stratum-target.c
3107         (process_stratum_target::thread_address_space): Update.
3108         * linux-fork.c (linux_fork_mourn_inferior)
3109         (detach_checkpoint_command, info_checkpoints_command)
3110         (linux_fork_context): Update.
3111         (linux_fork_detach): Update.
3112         (class scoped_switch_fork_info): Update.
3113         (delete_checkpoint_command): Update.
3114         * infrun.c (follow_fork_inferior): Update.
3115         (follow_fork_inferior): Update.
3116         (proceed_after_vfork_done): Update.
3117         (handle_vfork_child_exec_or_exit): Update.
3118         (follow_exec): Update.
3119         (displaced_step_prepare_throw): Update.
3120         (displaced_step_restore): Update.
3121         (start_step_over): Update.
3122         (resume_1): Update.
3123         (clear_proceed_status_thread): Update.
3124         (proceed): Update.
3125         (print_target_wait_results): Update.
3126         (do_target_wait): Update.
3127         (context_switch): Update.
3128         (stop_all_threads): Update.
3129         (restart_threads): Update.
3130         (finish_step_over): Update.
3131         (handle_signal_stop): Update.
3132         (switch_back_to_stepped_thread): Update.
3133         (keep_going_pass_signal): Update.
3134         (print_exited_reason): Update.
3135         (normal_stop): Update.
3136         * inferior.c (inferior_pid_to_str): Change return type.
3137         (print_selected_inferior): Update.
3138         (add_inferior): Update.
3139         (detach_inferior): Update.
3140         * dummy-frame.c (fprint_dummy_frames): Update.
3141         * dcache.c (dcache_info_1): Update.
3142         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3143         (btrace_fetch, btrace_clear): Update.
3144         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3145         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3146         type.
3147         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3148         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3149         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3150         * gdbarch.c, gdbarch.h: Rebuild.
3151         * gdbarch.sh (core_pid_to_str): Change return type.
3152         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3153         return type.
3154         (windows_nat_target::pid_to_str): Change return type.
3155         (windows_delete_thread): Update.
3156         (windows_nat_target::attach): Update.
3157         (windows_nat_target::files_info): Update.
3158         * target-delegates.c: Rebuild.
3159         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3160         return type.
3161         (sol_thread_target::pid_to_str): Change return type.
3162         * remote.c (class remote_target) <pid_to_str>: Change return
3163         type.
3164         (remote_target::pid_to_str): Change return type.
3165         (extended_remote_target::attach, remote_target::remote_stop_ns)
3166         (remote_target::remote_notif_remove_queued_reply)
3167         (remote_target::push_stop_reply, remote_target::disable_btrace):
3168         Update.
3169         (extended_remote_target::attach): Update.
3170         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3171         type.
3172         (gdbsim_target::pid_to_str): Change return type.
3173         * ravenscar-thread.c (struct ravenscar_thread_target)
3174         <pid_to_str>: Change return type.
3175         (ravenscar_thread_target::pid_to_str): Change return type.
3176         * procfs.c (class procfs_target) <pid_to_str>: Change return
3177         type.
3178         (procfs_target::pid_to_str): Change return type.
3179         (procfs_target::attach): Update.
3180         (procfs_target::detach): Update.
3181         (procfs_target::fetch_registers): Update.
3182         (procfs_target::store_registers): Update.
3183         (procfs_target::wait): Update.
3184         (procfs_target::files_info): Update.
3185         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3186         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3187         return type.
3188         (nto_procfs_target::pid_to_str): Change return type.
3189         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3190         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3191         return type.
3192         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3193         (exit_lwp): Update.
3194         (attach_proc_task_lwp_callback, get_detach_signal)
3195         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3196         (linux_nat_target::resume, wait_lwp, stop_callback)
3197         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3198         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3199         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3200         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3201         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3202         type.
3203         (inf_ptrace_target::attach): Update.
3204         (inf_ptrace_target::files_info): Update.
3205         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3206         type.
3207         (go32_nat_target::pid_to_str): Change return type.
3208         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3209         (gnu_nat_target::wait): Update.
3210         (gnu_nat_target::wait): Update.
3211         (gnu_nat_target::resume): Update.
3212         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3213         (fbsd_nat_target::wait): Update.
3214         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3215         type.
3216         (darwin_nat_target::attach): Update.
3217         * corelow.c (class core_target) <pid_to_str>: Change return type.
3218         (core_target::pid_to_str): Change return type.
3219         * target.c (normal_pid_to_str): Change return type.
3220         (default_pid_to_str): Likewise.
3221         (target_pid_to_str): Change return type.
3222         (target_translate_tls_address): Update.
3223         (target_announce_detach): Update.
3224         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3225         return type.
3226         (bsd_uthread_target::pid_to_str): Change return type.
3227         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3228         type.
3229         (bsd_kvm_target::pid_to_str): Change return type.
3230         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3231         return type.
3232         (aix_thread_target::pid_to_str): Change return type.
3233         * target.h (struct target_ops) <pid_to_str>: Change return type.
3234         (target_pid_to_str, normal_pid_to_str): Likewise.
3235         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3236         type.
3237         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3238         type.
3239         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3240         return type.
3241         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3242         type.
3243         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3244         type.
3245         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3246         return type.
3247
3248 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3249
3250         * NEWS: Mention that the new default MI version is 3.  Mention
3251         changes to the output of commands and events that deal with
3252         multi-location breakpoints.
3253         * breakpoint.c: Include "mi/mi-out.h".
3254         (print_one_breakpoint): Change output syntax if using MI version
3255         >= 3.
3256         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3257         New.
3258         (mi_multi_location_breakpoint_output_fixed): New.
3259         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3260         (mi_cmd_fix_multi_location_breakpoint_output): New.
3261         (mi_multi_location_breakpoint_output_fixed): New.
3262         * mi/mi-cmds.c (mi_cmds): Register command
3263         -fix-multi-location-breakpoint-output.
3264         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3265         interpreter "mi".
3266
3267 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3268
3269         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3270         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3271         instantiate mi_ui_out based on interpreter name.
3272         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3273         * mi/mi-main.c (mi_load_progress): Likewise.
3274
3275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3276
3277         * NEWS: Combine separate "New targets" sections for 8.3.
3278
3279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3280
3281         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3282         (ppcfbsd_init_abi): Install gdbarch
3283         "fetch_tls_load_module_address" and "get_thread_local_address"
3284         methods.
3285
3286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3287
3288         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3289         (riscv_fbsd_init_abi): Install gdbarch
3290         "fetch_tls_load_module_address" and "get_thread_local_address"
3291         methods.
3292
3293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3294
3295         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3296         (i386fbsd_init_abi): Install gdbarch
3297         "fetch_tls_load_module_address" and "get_thread_local_address"
3298         methods.
3299
3300 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3301
3302         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3303         (amd64fbsd_init_abi): Install gdbarch
3304         "fetch_tls_load_module_address" and "get_thread_local_address"
3305         methods.
3306
3307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3308
3309         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3310         (struct fbsd_pspace_data): New type.
3311         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3312         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3313         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3314         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3315         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3316
3317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3318
3319         * gdbtypes.c (lookup_struct_elt): New function.
3320         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3321         * gdbtypes.h (struct struct_elt): New type.
3322         (lookup_struct_elt): New prototype.
3323
3324 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3325
3326         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3327         remove disabled code block.
3328
3329 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3330
3331         * gdbarch.sh (get_thread_local_address): New method.
3332         * gdbarch.h, gdbarch.c: Regenerate.
3333         * target.c (target_translate_tls_address): Use
3334         gdbarch_get_thread_local_address if present instead of
3335         target::get_thread_local_address.
3336
3337 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3338
3339         * target.h (target::get_thread_local_address): Update comment.
3340
3341 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3342
3343         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3344         objfile->separate_debug_objfile_backlink if not NULL.
3345
3346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3347
3348         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3349         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3350         (amd64bsd_store_inferior_registers): Likewise.
3351         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3352         Enable segment base registers.
3353         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3354         PT_GETFSBASE and PT_GETGSBASE.
3355         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3356         PT_SETGSBASE.
3357         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3358         segment base registers.
3359         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3360
3361 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3362
3363         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3364         Update calls to i386_target_description to add 'segments'
3365         parameter.
3366         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3367         add segment base registers.
3368         * arch/i386.c (i386_create_target_description): Add 'segments'
3369         parameter to enable segment base registers.
3370         * arch/i386.h (i386_create_target_description): Likewise.
3371         * features/i386/32bit-segments.xml: New file.
3372         * features/i386/32bit-segments.c: Generate.
3373         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3374         call to i386_target_description to add 'segments' parameter.
3375         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3376         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3377         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3378         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3379         if feature is present.
3380         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3381         Add 'segments' parameter to call to i386_target_description.
3382         (i386_target_description): Add 'segments' parameter to enable
3383         segment base registers.
3384         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3385         to call to i386_target_description.
3386         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3387         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3388         Define I386_NUM_REGS.
3389         (i386_target_description): Add 'segments' parameter to enable
3390         segment base registers.
3391
3392 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3393
3394         PR/24325
3395         * source-cache.c: #undef open and close, to avoid unresolved
3396         externals during linking.
3397
3398 2019-03-12  Tom Tromey  <tromey@adacore.com>
3399
3400         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3401         const.  Add initializers.
3402         (_initialize_remote): Don't initialize ptid globals.
3403
3404 2019-03-12  Pedro Alves  <palves@redhat.com>
3405
3406         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3407
3408 2019-03-12  Pedro Alves  <palves@redhat.com>
3409
3410         * cp-name-parser.y (main): Remove unused 'len' variable.
3411
3412 2019-03-12  Tom Tromey  <tromey@adacore.com>
3413
3414         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3415         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3416
3417 2019-03-12  Tom Tromey  <tromey@adacore.com>
3418
3419         * linux-nat.c (iterate_over_lwps): Update.
3420         (stop_callback): Remove parameter.
3421         (stop_wait_callback, detach_callback, resume_set_callback)
3422         (select_singlestep_lwp_callback, set_ignore_sigint)
3423         (status_callback, resumed_callback, resume_clear_callback)
3424         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3425         data parameter.
3426         (linux_nat_target::detach, linux_nat_target::resume)
3427         (linux_stop_and_wait_all_lwps, select_event_lwp)
3428         (linux_nat_filter_event, linux_nat_wait_1)
3429         (linux_nat_target::kill, linux_nat_target::stop)
3430         (linux_nat_target::stop): Update.
3431         (linux_nat_resume_callback): Change type.
3432         (resume_stopped_resumed_lwps, count_events_callback)
3433         (select_event_lwp_callback): Likewise.
3434         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3435         * arm-linux-nat.c (struct update_registers_data): Remove.
3436         (update_registers_callback): Change type.
3437         (arm_linux_insert_hw_breakpoint1): Update.
3438         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3439         parameter.
3440         (x86_linux_dr_set_addr): Update.
3441         (x86_linux_dr_set_control): Update.
3442         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3443         (iterate_over_lwps): Use gdb::function_view.
3444         * nat/aarch64-linux-hw-point.c (struct
3445         aarch64_dr_update_callback_param): Remove.
3446         (debug_reg_change_callback): Change type.
3447         (aarch64_notify_debug_reg_change): Update.
3448         * s390-linux-nat.c (s390_refresh_per_info): Update.
3449
3450 2019-03-11  Tom Tromey  <tromey@adacore.com>
3451
3452         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3453         redundant assignment to "this_cu".
3454
3455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3456
3457         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3458
3459 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3460
3461         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3462         from...
3463         (rank_one_type): ... this.
3464
3465 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3466
3467         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3468         from...
3469         (rank_one_type): ... this.
3470
3471 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3472
3473         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3474         from...
3475         (rank_one_type): ... this.
3476
3477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3478
3479         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3480         from...
3481         (rank_one_type): ... this.
3482
3483 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3484
3485         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3486         from...
3487         (rank_one_type): ... this.
3488
3489 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3490
3491         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3492         from...
3493         (rank_one_type): ... this.
3494
3495 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3496
3497         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3498         from...
3499         (rank_one_type): ... this.
3500
3501 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3502
3503         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3504         from...
3505         (rank_one_type): ... this.
3506
3507 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3508
3509         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3510         from...
3511         (rank_one_type): ... this.
3512
3513 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3514
3515         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3516         from...
3517         (rank_one_type): ... this.
3518
3519 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3520
3521         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3522         from...
3523         (rank_one_type): ... this.
3524
3525 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3526
3527         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3528         from...
3529         (rank_one_type): ... this.
3530
3531 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3532
3533         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3534         inferior-events' shows the example events.
3535
3536 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3537
3538         Support styling on native MS-Windows console
3539
3540         PR/24315
3541         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3542         on MS-Windows if $TERM is not defined.
3543
3544         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3545
3546         * posix-hdep.c (gdb_console_fputs):
3547         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3548         functions.
3549         * ui-file.h (gdb_console_fputs): Add prototype.
3550
3551         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3552         back to fputs only if the former returns zero.
3553
3554 2019-03-07  Tom Tromey  <tom@tromey.com>
3555
3556         * symmisc.c (print_symbol_bcache_statistics): Update.
3557         (print_objfile_statistics): Update.
3558         * symfile.c (allocate_symtab): Update.
3559         * stabsread.c: Don't include bcache.h.
3560         * psymtab.h (struct psymbol_bcache): Don't declare.
3561         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3562         (psymbol_bcache_init, psymbol_bcache_free)
3563         (psymbol_bcache_get_bcache): Don't declare.
3564         * psymtab.c (struct psymbol_bcache): Remove.
3565         (psymtab_storage::psymtab_storage): Update.
3566         (psymtab_storage::~psymtab_storage): Update.
3567         (psymbol_bcache_init, psymbol_bcache_free)
3568         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3569         (add_psymbol_to_bcache): Update.
3570         (allocate_psymtab): Update.
3571         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3572         macro_cache>: No longer pointers.
3573         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3574         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3575         * macrotab.c (macro_bcache): Update.
3576         * macroexp.c: Don't include bcache.h.
3577         * gdbtypes.c (check_types_worklist): Update.
3578         (types_deeply_equal): Remove TRY/CATCH.  Update.
3579         * elfread.c (elf_symtab_read): Update.
3580         * dwarf2read.c: Don't include bcache.h.
3581         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3582         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3583         (print_bcache_statistics, bcache_memory_used): Don't declare.
3584         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3585         methods.  Rename all data members.
3586         * bcache.c (struct bcache): Move to bcache.h.
3587         (bcache::expand_hash_table): Rename from expand_hash_table.
3588         (bcache): Remove.
3589         (bcache::insert): Rename from bcache_full.
3590         (bcache::compare): Rename from bcache_compare.
3591         (bcache_xmalloc): Remove.
3592         (bcache::~bcache): Rename from bcache_xfree.
3593         (bcache::print_statistics): Rename from print_bcache_statistics.
3594         (bcache::memory_used): Rename from bcache_memory_used.
3595
3596 2019-03-07  Pedro Alves  <palves@redhat.com>
3597
3598         * infrun.c (normal_stop): Also check for
3599         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3600
3601 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3602
3603         * f-lang.c (value_from_host_double): Moved to...
3604         * value.c (value_from_host_double): ...here.
3605         * value.h (value_from_host_double): Declare.
3606         * guile/scm-math.c (vlscm_convert_typed_number): Use
3607         value_from_host_double.
3608         (vlscm_convert_number): Likewise.
3609         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3610         * python/py-value.c (convert_value_from_python): Likewise.
3611
3612 2019-03-06  Tom Tromey  <tom@tromey.com>
3613
3614         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3615
3616 2019-03-06  Tom Tromey  <tom@tromey.com>
3617
3618         * utils.h (free_current_contents): Don't declare.
3619         * utils.c (free_current_contents): Remove.
3620
3621 2019-03-06  Tom Tromey  <tom@tromey.com>
3622
3623         * top.c (quit_force): Update.
3624         * main.c (captured_command_loop): Update.
3625         * common/new-op.c (operator new): Update.
3626         * common/common-exceptions.c (struct catcher)
3627         <save_cleanup_chain>: Remove member.
3628         (exceptions_state_mc_init): Update.
3629         (exception_try_scope_entry): Return nullptr.
3630         (exception_try_scope_exit, exception_rethrow)
3631         (throw_exception_sjlj, throw_exception_cxx): Update.
3632         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3633         (all_cleanups, do_cleanups, discard_cleanups)
3634         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3635         (restore_cleanups, restore_final_cleanups): Don't declare.
3636         (do_final_cleanups): Remove parameter.
3637         * common/cleanups.c (cleanup_chain, make_cleanup)
3638         (make_cleanup_dtor, all_cleanups, do_cleanups)
3639         (discard_my_cleanups, discard_cleanups)
3640         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3641         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3642         (null_cleanup): Remove.
3643         (do_final_cleanups): Remove parameter.
3644
3645 2019-03-06  Tom Tromey  <tom@tromey.com>
3646
3647         * remote.c (remote_target::remote_parse_stop_reply): Use
3648         unique_xmalloc_ptr.
3649
3650 2019-03-06  Tom Tromey  <tom@tromey.com>
3651
3652         * stabsread.c (struct stabs_field_info): Rename from field_info.
3653         <list, fnlist>: Add initializers.
3654         <obstack>: New member.
3655         (read_member_functions, read_struct_fields, read_baseclasses):
3656         Allocate on obstack.  Don't use cleanups.
3657         (read_one_struct_field, read_member_functions, read_struct_fields)
3658         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3659         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3660         (read_struct_type): Update.
3661
3662 2019-03-06  Tom Tromey  <tom@tromey.com>
3663
3664         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3665         * common/filestuff.h (make_cleanup_close): Don't declare.
3666         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3667         Remove.
3668
3669 2019-03-06  Tom Tromey  <tom@tromey.com>
3670
3671         * solib-aix.c: Use make_scope_exit.
3672
3673 2019-03-06  Tom Tromey  <tom@tromey.com>
3674
3675         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3676         Use make_scope_exit.
3677
3678 2019-03-06  Tom Tromey  <tom@tromey.com>
3679
3680         * solib-svr4.c (disable_probes_interface): Remove parameter.
3681         (svr4_handle_solib_event): Use make_scope_exit.
3682
3683 2019-03-06  Tom Tromey  <tom@tromey.com>
3684
3685         * remote.c (struct stop_reply_deleter): Remove.
3686         (stop_reply_up): Update.
3687         (struct stop_reply): Derive from notif_event.  Don't typedef.
3688         <regcache>: Now a std::vector.
3689         (stop_reply_xfree): Remove.
3690         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3691         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3692         (remote_target::discard_pending_stop_replies): Use delete.
3693         (remote_target::remote_parse_stop_reply): Update.
3694         (remote_target::process_stop_reply): Update.
3695         * remote-notif.h (struct notif_event): Add virtual destructor.
3696         Remove "dtr" member.
3697         (struct notif_client) <alloc_event>: Return a unique_ptr.
3698         (notif_event_xfree): Don't declare.
3699         (notif_event_up): New typedef.
3700         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3701         (notif_event_xfree, do_notif_event_xfree): Remove.
3702         (remote_notif_state_xfree): Update.
3703
3704 2019-03-06  Tom Tromey  <tom@tromey.com>
3705
3706         * infrun.c (displaced_step_clear_cleanup): Now a
3707         forward_scope_exit type.
3708         (displaced_step_prepare_throw): Update.
3709         (displaced_step_fixup): Update.
3710
3711 2019-03-06  Tom Tromey  <tom@tromey.com>
3712
3713         * inferior.h (class inferior): Update comment.
3714         * gdbthread.h (class thread_info): Update comment.
3715
3716 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3717             Tom Tromey  <tom@tromey.com>
3718
3719         * stabsread.h (struct stab_section_list): Remove.
3720         (coffstab_build_psymtabs): Update.
3721         * dbxread.c (symbuf_sections): Now a std::vector.
3722         (sect_idx): New global.
3723         (fill_symbuf): Update.
3724         (coffstab_build_psymtabs): Change type of stabsects parameter.
3725         Update.
3726         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3727         std::vector.
3728         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3729         (coff_locate_sections): Update.
3730         (coff_symfile_read): Remove cleanups.  Update.
3731         (init_stringtab): Add storage parameter.
3732         (free_stringtab, free_stringtab_cleanup): Remove.
3733         (init_lineno): Add storage parameter.
3734         (free_linetab, free_linetab_cleanup): Remove.
3735
3736 2019-03-06  Pedro Alves  <palves@redhat.com>
3737
3738         * linux-fork.c (fork_info::clobber_regs): Delete.
3739         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3740         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3741         comment.  Adjust.
3742         (scoped_switch_fork_info::scoped_switch_fork_info)
3743         (checkpoint_command, linux_fork_context): Adjust
3744         fork_save_infrun_state calls.
3745
3746 2019-03-06  Pedro Alves  <palves@redhat.com>
3747
3748         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3749         (inf_has_multiple_threads): Return 'bool' and rewrite using
3750         inferior_info::threads().
3751
3752 2019-03-06  Pedro Alves  <palves@redhat.com>
3753
3754         * linux-fork.c: Include <list>.
3755         (fork_list): Now a std::list instance.
3756         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3757         (forks_exist_p, find_last_fork): Adjust.
3758         (new_fork): Delete.
3759         (one_fork_p): New.
3760         (add_fork): Adjust.
3761         (free_fork): Delete, folded into fork_info::~fork_info().
3762         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3763         Adjust.
3764         (init_fork_list): Delete.
3765         (linux_fork_killall, linux_fork_mourn_inferior)
3766         (linux_fork_detach, info_checkpoints_command): Adjust.
3767         (_initialize_linux_fork): No longer call init_fork_list.
3768
3769 2019-03-06  Pedro Alves  <palves@redhat.com>
3770
3771         * linux-fork.c (new_fork): New, split out of ...
3772         (add_fork): ... this.  Return void.  Move "first fork" special
3773         case from here, to ...
3774         (checkpoint_command): ... here.
3775         * linux-linux.h (add_fork): Return void.
3776
3777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3778
3779         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3780
3781 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3782             Chris January  <chris.january@arm.com>
3783             David Lecomber  <david.lecomber@arm.com>
3784
3785         * f-exp.y: New token, UNOP_INTRINSIC.
3786         (exp): New pattern using UNOP_INTRINSIC token.
3787         (f77_keywords): Add 'abs' keyword.
3788         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3789         (value_from_host_double): New function.
3790         (evaluate_subexp_f): Support UNOP_ABS.
3791
3792 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3793
3794         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3795         types.
3796
3797 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3798
3799         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3800         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3801         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3802
3803 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3804
3805         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3806
3807 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3808             Chris January  <chris.january@arm.com>
3809
3810         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3811         * f-exp.y: Define 'KIND' token.
3812         (exp): New pattern for KIND expressions.
3813         (ptype): Handle types with a kind extension.
3814         (direct_abs_decl): Extend to spot kind extensions.
3815         (f77_keywords): Add 'kind' to the list.
3816         (push_kind_type): New function.
3817         (convert_to_kind_type): New function.
3818         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3819         * parse.c (operator_length_standard): Likewise.
3820         * parser-defs.h (enum type_pieces): Add tp_kind.
3821         * std-operator.def: Add UNOP_KIND.
3822
3823 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * f-exp.y (f_parse): Set yydebug.
3826
3827 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3828
3829         * f-lang.c (evaluate_subexp_f): New function.
3830         (exp_descriptor_f): New global.
3831         (f_language_defn): Use exp_descriptor_f instead of
3832         exp_descriptor_standard.
3833
3834 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * f-exp.y (struct token): Add comments.
3837         (dot_ops): Remove uppercase versions and the end marker.
3838         (f77_keywords): Likewise.
3839         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3840         entries in the dot_ops array are case insensitive, and use
3841         strncasecmp to compare strings.  Also some whitespace cleanup in
3842         this area.  Similar for the f77_keywords array, except entries in
3843         this list might be case sensitive.
3844
3845 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3846
3847         * f-exp.y (struct f77_boolean_val): Add comments.
3848         (boolean_values): Remove uppercase versions, and end marker.
3849         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3850         and use strncasecmp to achieve case insensitivity.  Additionally,
3851         perform whitespace cleanup around this code.
3852
3853 2019-03-06  Tom Tromey  <tromey@adacore.com>
3854
3855         * remote-sim.c (gdbsim_target_open): Use result of
3856         gdb_argv::release.
3857
3858 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3859         Dirk Schubert  <dirk.schubert@arm.com>
3860         Chris January  <chris.january@arm.com>
3861
3862         * eval.c (evaluate_subexp_standard): Call Fortran argument
3863         wrapping logic.
3864         * f-lang.c (struct value): A value which can be passed into a
3865         Fortran function call.
3866         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3867         where appropriate.
3868         (struct type): Value ready for a Fortran function call.
3869         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3870         is needed.
3871         * f-lang.h (fortran_argument_convert): Declaration.
3872         (fortran_preserve_arg_pointer): Declaration.
3873         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3874
3875 2019-03-05  Tom Tromey  <tromey@adacore.com>
3876
3877         * python/py-prettyprint.c (print_string_repr): Remove #if.
3878         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3879
3880 2019-03-05  Tom Tromey  <tromey@adacore.com>
3881
3882         * target.c (the_dummy_target): Move later.  Change type to
3883         "dummy_target".
3884         (initialize_targets): Don't initialize the_dummy_target.
3885
3886 2019-03-05  Tom Tromey  <tromey@adacore.com>
3887
3888         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3889         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3890
3891 2019-03-05  Tom Tromey  <tromey@adacore.com>
3892
3893         * windows-nat.c (windows_nat_target::attach)
3894         (windows_nat_target::detach): Don't call gdb_flush.
3895         * valprint.c (generic_val_print, val_print, val_print_string):
3896         Don't call gdb_flush.
3897         * utils.c (defaulted_query): Don't call gdb_flush.
3898         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3899         * target.c (target_announce_detach): Don't call gdb_flush.
3900         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3901         * remote.c (extended_remote_target::attach): Don't call
3902         gdb_flush.
3903         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3904         * printcmd.c (do_examine): Don't call gdb_flush.
3905         (info_display_command): Don't call gdb_flush.
3906         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3907         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3908         * memattr.c (info_mem_command): Don't call gdb_flush.
3909         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3910         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3911         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3912         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3913         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3914         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3915         (gnu_nat_target::detach): Don't call gdb_flush.
3916         * f-valprint.c (f_val_print): Don't call gdb_flush.
3917         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3918         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3919         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3920         gdb_flush.
3921         * c-valprint.c (c_val_print): Don't call gdb_flush.
3922         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3923
3924 2019-03-05  Tom Tromey  <tromey@adacore.com>
3925
3926         * varobj.c (update_dynamic_varobj_children): Update.
3927         (install_default_visualizer): Use reset, not release.
3928         * value.c (set_internalvar): Update.
3929         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3930         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3931         ATTRIBUTE_UNUSED_RESULT.
3932
3933 2019-03-05  Tom Tromey  <tromey@adacore.com>
3934
3935         * remote.c (class scoped_remote_fd) <release>: Add
3936         ATTRIBUTE_UNUSED_RESULT.
3937
3938 2019-03-05  Tom Tromey  <tromey@adacore.com>
3939
3940         * macroexp.c (struct macro_buffer) <release>: Add
3941         ATTRIBUTE_UNUSED_RESULT.
3942
3943 2019-03-05  Tom Tromey  <tromey@adacore.com>
3944
3945         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3946         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3947         ATTRIBUTE_UNUSED_RESULT.
3948
3949 2019-03-05  Tom Tromey  <tromey@adacore.com>
3950
3951         * common/scoped_fd.h (class scoped_fd) <release>: Add
3952         ATTRIBUTE_UNUSED_RESULT.
3953
3954 2019-03-05  Tom Tromey  <tromey@adacore.com>
3955
3956         * parser-defs.h (struct parser_state) <release>: Add
3957         ATTRIBUTE_UNUSED_RESULT.
3958
3959 2019-03-05  Tom Tromey  <tromey@adacore.com>
3960
3961         * utils.h (class gdb_argv) <release>: Add
3962         ATTRIBUTE_UNUSED_RESULT.
3963         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3964
3965 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3966
3967         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3968         for-loop range, to avoid compiler warnings.
3969
3970         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3971         avoid compiler warnings about unused variables.
3972
3973         * NEWS: Mention end of support for native debugging on MS-Windows
3974         before XP.
3975
3976         PR gdb/24292
3977         * common/netstuff.c:
3978         * gdbserver/gdbreplay.c
3979         * gdbserver/remote-utils.c:
3980         * ser-tcp.c:
3981         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3982         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3983         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3984         'getaddrinfo' and 'freeaddrinfo' were not available before
3985         Windows XP, and mingw.org's MinGW headers by default define
3986         _WIN32_WINNT to 0x500.
3987
3988 2019-03-01  Gary Benson <gbenson@redhat.com>
3989
3990         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3991
3992 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3993             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3994
3995         PR gdb/8527
3996         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3997         set_sigint_trap, clear_sigint_trap.
3998
3999 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4000
4001         * target.c (target_detach): Clear the regcache and the
4002         frame cache.
4003
4004 2019-02-27  Pedro Alves  <palves@redhat.com>
4005
4006         * utils.c (set_screen_size): When we cap the height/width sizes,
4007         tweak the corresponding command variable to show "unlimited":
4008
4009 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4010             Pedro Alves  <palves@redhat.com>
4011
4012         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4013         before calling rl_set_screen_size.
4014
4015 2019-02-27  Tom Tromey  <tromey@adacore.com>
4016
4017         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4018         define.
4019         * python/py-value.c: Remove Python 2.4 workaround.
4020         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4021         workaround.
4022         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4023         Python 2.4 workaround.
4024         * python/python-internal.h: Remove Python 2.4 comment.
4025         (Py_ssize_t): Don't define.
4026         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4027         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4028         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4029         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4030         * python/python.c (do_start_initialization): Remove Python 2.4
4031         workaround.
4032         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4033         (print_children): Remove Python 2.4 workaround.
4034         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4035         workaround.
4036         (CHARBUFFERPROC_NAME): Remove.
4037         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4038         Python 2.4 workaround.
4039
4040 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4041
4042         * NEWS: Note minimum Python version.
4043
4044 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4045
4046         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4047         code from these functions.  Remove corresponding ifdefs.  Use
4048         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4049         Remove gotos and target of gotos.
4050         (infpy_search_memory): Likewise.
4051
4052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4053
4054         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4055         (hppa_gdbarch_init): Don't register deleted functions with
4056         gdbarch.
4057
4058 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4059
4060         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4061         (h8300_unwind_sp): Delete.
4062         (h8300_dummy_id): Delete.
4063         (h8300_gdbarch_init): Don't register deleted functions with
4064         gdbarch.
4065
4066 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4067
4068         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4069         (ft32_unwind_pc): Delete.
4070         (ft32_unwind_sp): Delete.
4071         (ft32_gdbarch_init): Don't register deleted functions with
4072         gdbarch.
4073
4074 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4075
4076         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4077         (frv_unwind_pc): Delete.
4078         (frv_unwind_sp): Delete.
4079         (frv_gdbarch_init): Don't register deleted functions with
4080         gdbarch.
4081
4082 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4083
4084         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4085         (riscv_unwind_pc): Delete.
4086         (riscv_unwind_sp): Delete.
4087         (riscv_gdbarch_init): Don't register deleted functions with
4088         gdbarch.
4089
4090 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4091
4092         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4093         (csky_unwind_pc): Delete.
4094         (csky_unwind_sp): Delete.
4095         (csky_gdbarch_init): Don't register deleted functions with
4096         gdbarch.
4097
4098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4099
4100         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4101         (cris_unwind_pc): Delete.
4102         (cris_unwind_sp): Delete.
4103         (cris_gdbarch_init): Don't register deleted functions with
4104         gdbarch.
4105
4106 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4107
4108         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4109         (bfin_unwind_pc): Delete.
4110         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4111
4112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4113
4114         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4115         (arm_unwind_pc): Delete.
4116         (arm_unwind_sp): Delete.
4117         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4118
4119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4120
4121         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4122         (arc_unwind_pc): Delete.
4123         (arc_unwind_sp): Delete.
4124         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4125
4126 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4127
4128         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4129         (alpha_unwind_pc): Delete.
4130         (alpha_gdbarch_init): Don't register deleted functions with
4131         gdbarch.
4132
4133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4134
4135         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4136         (aarch64_unwind_pc): Delete.
4137         (aarch64_unwind_sp): Delete.
4138         (aarch64_gdbarch_init): Don't register deleted functions with
4139         gdbarch.
4140
4141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4142
4143         * gdbtypes.c (type_align): Don't consider static members when
4144         computing structure alignment.
4145
4146 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4149         return 0 for other types.
4150         * arch-utils.c (default_type_align): Always return 0.
4151         * gdbarch.h: Regenerate.
4152         * gdbarch.sh (type_align): Extend comment.
4153         * gdbtypes.c (type_align): Add additional comments, always call
4154         gdbarch_type_align before applying the default rules.
4155         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4156         generic code will then apply a suitable default.
4157         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4158         types, return 0 for other types.
4159
4160 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4161
4162         * NEWS: Create a new section for the next release branch.
4163         Rename the section of the current branch, now that it has
4164         been cut.
4165
4166 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4167
4168         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4169         * version.in: Bump version to 8.3.50.DATE-git.
4170
4171 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4172
4173         * aix-thread.c (ptid_cmp): Remove unused variable.
4174         (get_signaled_thread): Likewise.
4175         (store_regs_user_thread): Likewise.
4176         (store_regs_kernel_thread): Likewise.
4177         (fetch_regs_kernel_thread): Remove shadowed variable.
4178
4179 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4180
4181         * features/riscv/32bit-cpu.xml: Add register numbers.
4182         * features/riscv/32bit-fpu.c: Regenerate.
4183         * features/riscv/32bit-fpu.xml: Add register numbers.
4184         * features/riscv/64bit-cpu.xml: Add register numbers.
4185         * features/riscv/64bit-fpu.c: Regenerate.
4186         * features/riscv/64bit-fpu.xml: Add register numbers.
4187
4188 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4189
4190         * NEWS: Mention two argument form of gdb.Value constructor.
4191         * python/py-value.c (convert_buffer_and_type_to_value): New
4192         function.
4193         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4194         Add support for handling an optional second argument.  Call
4195         convert_buffer_and_type_to_value as appropriate.
4196         * python/python-internal.h (Py_buffer_deleter): New struct.
4197         (Py_buffer_up): New typedef.
4198
4199 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4200
4201         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4202         instead of releasing ownership.
4203
4204 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4205
4206         * dwarf2read.c (open_and_init_dwp_file): Call
4207         elf_numsections instead of bfd_count_sections to initialize
4208         dwp_file->num_sections.
4209
4210 2019-02-25  Tom Tromey  <tromey@adacore.com>
4211
4212         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4213
4214 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4215
4216         * gcore.in: Add '--readnever' option when invoking GDB.
4217
4218 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4219
4220         * MAINTAINERS: Update my email address.
4221
4222 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4223
4224         * build-id.c (build_id_to_debug_bfd_1): New function.
4225         (build_id_to_debug_bfd): Look for separate debug file in
4226         sysroot.
4227
4228 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * gdbarch.sh: Update the copyright year range that is placed into
4231         generated files.
4232
4233 2019-02-22  Keith Seitz  <keiths@redhat.com>
4234
4235         PR symtab/23853
4236         * linespec.c (create_sals_line_offset): Search for the default
4237         symtab's filename instead of its fullname.
4238
4239 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4240
4241         * NEWS: Update style defaults.
4242
4243 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4244
4245         * main.c (captured_main_1): Disable styling in batch mode.
4246
4247 2019-02-20  Tom Tromey  <tom@tromey.com>
4248
4249         * symtab.c (symtab_symbol_info): Fix typos.
4250
4251 2019-02-20  Tom Tromey  <tromey@adacore.com>
4252
4253         * findcmd.c (_initialize_mem_search): Use upper case for
4254         metasyntactic variables.
4255
4256 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4257
4258         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4259         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4260
4261 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4262
4263         * top.h (source_file_name): Change to std::string.
4264         * top.c (source_file_name): Likewise.
4265         (command_line_input): Adjust.
4266         * cli/cli-script.c (script_from_file): Adjust.
4267
4268 2019-02-19  Tom Tromey  <tromey@adacore.com>
4269
4270         * ravenscar-thread.c
4271         (ravenscar_thread_target::update_thread_list): Don't call
4272         ada_build_task_list.
4273         * ada-lang.h (ada_build_task_list): Don't declare.
4274         * ada-tasks.c (struct ada_tasks_inferior_data)
4275         <task_list_valid_p>: Now bool.
4276         (read_known_tasks, ada_task_list_changed)
4277         (ada_tasks_invalidate_inferior_data): Update.
4278         (read_known_tasks_array): Return bool.
4279         (read_known_tasks_list): Likewise.
4280         (read_known_tasks): Return void.
4281         (ada_build_task_list): Now static.
4282
4283 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4284
4285         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4286         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4287
4288 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4289
4290         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4291         variant for ada_tasks_pspace_data_handle and
4292         ada_tasks_inferior_data_handle.
4293         (ada_tasks_pspace_data_cleanup): New function.
4294         (ada_tasks_inferior_data_cleanup): New function.
4295
4296 2019-02-17  Tom Tromey  <tom@tromey.com>
4297
4298         * macrotab.h (macro_source_fullname): Return a std::string.
4299         * macrotab.c (macro_include, check_for_redefinition)
4300         (macro_undef, macro_lookup_definition, foreach_macro)
4301         (foreach_macro_in_scope): Update.
4302         (macro_source_fullname): Return a std::string.
4303         * macrocmd.c (show_pp_source_pos): Update.
4304
4305 2019-02-17  Tom Tromey  <tom@tromey.com>
4306
4307         * macrocmd.c (show_pp_source_pos): Style the file names.
4308
4309 2019-02-17  Tom Tromey  <tom@tromey.com>
4310
4311         PR tui/24197:
4312         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4313
4314 2019-02-17  Tom Tromey  <tom@tromey.com>
4315
4316         * ada-lang.c (user_select_syms): Use filtered printing.
4317         * utils.c (wrap_style): New global.
4318         (desired_style): Remove.
4319         (emit_style_escape): Add stream parameter.
4320         (set_output_style, reset_terminal_style, prompt_for_continue):
4321         Update.
4322         (flush_wrap_buffer): Only flush gdb_stdout.
4323         (wrap_here): Set wrap_style.
4324         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4325         treat escape sequences as a character.  Change when wrap buffer is
4326         flushed.
4327         (fputs_styled): Do not set the output style when the default is
4328         requested.
4329         * ui-style.h (struct ui_file_style) <is_default>: New method.
4330         * source.c (print_source_lines_base): Emit escape sequences in one
4331         piece.
4332
4333 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4334
4335         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4336         integers and enumeration types.
4337
4338 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4339
4340         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4341         instead of lookup_symbol_in_language
4342         (do_exact_match): New function.
4343         (ada_get_symbol_name_matcher): Return do_exact_match when
4344         doing a verbatim match.
4345
4346 2019-02-15  Tom Tromey  <tromey@adacore.com>
4347
4348         * ravenscar-thread.c (ravenscar_thread_target::resume)
4349         (ravenscar_thread_target::wait): Special case wildcard requests.
4350
4351 2019-02-15  Tom Tromey  <tromey@adacore.com>
4352
4353         * ravenscar-thread.c (base_ptid): Remove.
4354         (struct ravenscar_thread_target) <close>: New method.
4355         <m_base_ptid>: New member.
4356         <update_inferior_ptid, active_task, task_is_currently_active,
4357         runtime_initialized>: Declare methods.
4358         <ravenscar_thread_target>: Add constructor.
4359         (ravenscar_thread_target::task_is_currently_active)
4360         (ravenscar_thread_target::update_inferior_ptid)
4361         (ravenscar_runtime_initialized): Rename.  Now methods.
4362         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4363         (ravenscar_thread_target::update_thread_list): Update.
4364         (ravenscar_thread_target::active_task): Now method.
4365         (ravenscar_thread_target::store_registers)
4366         (ravenscar_thread_target::prepare_to_store)
4367         (ravenscar_thread_target::prepare_to_store)
4368         (ravenscar_thread_target::mourn_inferior): Update.
4369         (ravenscar_inferior_created): Use "new" to create target.
4370         (ravenscar_thread_target::get_ada_task_ptid): Update.
4371         (_initialize_ravenscar): Don't initialize base_ptid.
4372         (ravenscar_ops): Remove global.
4373
4374 2019-02-15  Tom Tromey  <tromey@adacore.com>
4375
4376         * target.h (push_target): Declare new overload.
4377         * target.c (push_target): New overload, taking an rvalue reference.
4378         * remote.c (remote_target::open_1): Use push_target overload.
4379         * corelow.c (core_target_open): Use push_target overload.
4380
4381 2019-02-15  Tom Tromey  <tromey@adacore.com>
4382
4383         * ravenscar-thread.c (is_ravenscar_task)
4384         (ravenscar_task_is_currently_active): Return bool.
4385         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4386         (_initialize_ravenscar): Remove "(void)".
4387         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4388         Return bool.
4389
4390 2019-02-15  Tom Tromey  <tromey@adacore.com>
4391
4392         * ravenscar-thread.c (ravenscar_runtime_initializer)
4393         (has_ravenscar_runtime, get_running_thread_id)
4394         (ravenscar_thread_target::resume): Fix indentation.
4395
4396 2019-02-15  Tom Tromey  <tromey@adacore.com>
4397
4398         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4399         from ravenscar_arch_ops.
4400         (sparc_ravenscar_ops::fetch_registers)
4401         (sparc_ravenscar_ops::store_registers): Now methods.
4402         (sparc_ravenscar_prepare_to_store): Remove.
4403         (sparc_ravenscar_ops): Redefine.
4404         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4405         methods and destructor.  Remove members.
4406         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4407         (ravenscar_thread_target::store_registers)
4408         (ravenscar_thread_target::prepare_to_store): Update.
4409         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4410         Remove.
4411         (struct ppc_ravenscar_powerpc_ops): Derive from
4412         ravenscar_arch_ops.
4413         (ppc_ravenscar_powerpc_ops::fetch_registers)
4414         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4415         (ppc_ravenscar_powerpc_ops): Redefine.
4416         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4417         (ppc_ravenscar_e500_ops::fetch_registers)
4418         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4419         (ppc_ravenscar_e500_ops): Redefine.
4420         * aarch64-ravenscar-thread.c
4421         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4422         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4423         (aarch64_ravenscar_fetch_registers)
4424         (aarch64_ravenscar_store_registers): Now methods.
4425         (aarch64_ravenscar_ops): Redefine.
4426
4427 2019-02-15  Tom Tromey  <tromey@adacore.com>
4428
4429         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4430         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4431         (ravenscar_thread_target::stopped_by_watchpoint)
4432         (ravenscar_thread_target::stopped_data_address)
4433         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4434
4435 2019-02-15  Tom Tromey  <tromey@adacore.com>
4436
4437         * ravenscar-thread.c: Fix some typos.
4438
4439 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4440             Tom Tromey  <tromey@adacore.com>
4441
4442         * ada-lang.c (ada_exception_sal): Change addr_string to a
4443         std::string.
4444         (create_ada_exception_catchpoint): Update.
4445
4446 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4447             Tom Tromey  <tromey@adacore.com>
4448
4449         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4450         (bp_location_ops): Remove.
4451         (base_breakpoint_allocate_location): Update.
4452         (free_bp_location): Update.
4453         * ada-lang.c (class ada_catchpoint_location)
4454         <ada_catchpoint_location>: Remove ops parameter.
4455         (ada_catchpoint_location_dtor): Remove.
4456         (ada_catchpoint_location_ops): Remove.
4457         (allocate_location_exception): Update.
4458         * breakpoint.h (struct bp_location_ops): Remove.
4459         (class bp_location) <bp_location>: Remove bp_location_ops
4460         parameter.
4461         <~bp_location>: Add destructor.
4462         <ops>: Remove.
4463
4464 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4465             Pedro Alves  <palves@redhat.com>
4466
4467         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4468         'PATH_MAX'.
4469
4470 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4471             Samuel Thibault  <samuel.thibault@gnu.org>
4472             Thomas Schwinge  <thomas@codesourcery.com>
4473
4474         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4475         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4476
4477 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4478
4479         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4480         (check_empty): Use "const char *".
4481
4482         * gnu-nat.c (gnu_nat_target::detach): Instead of
4483         'detach_inferior (pid)' call
4484         'detach_inferior (find_inferior_pid (pid))'.
4485
4486         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4487         'nat/fork-inferior.o'.
4488         * gnu-nat.c: #include "nat/fork-inferior.h".
4489
4490         * gnu-nat.c (gnu_nat_target::detach): Instead of
4491         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4492         * gnu-nat.h: #include "inf-child.h".
4493         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4494         'i386_gnu_nat_target::fetch_registers'.
4495         (gnu_store_registers): Rename/move to
4496         'i386_gnu_nat_target::store_registers'.
4497
4498         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4499         * gnu-nat.h (mach_thread_info): New function.
4500         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4501
4502         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4503
4504 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4505
4506         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4507
4508 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4509
4510         * windows-nat.c (windows_add_thread): Add new parameter
4511         "main_thread_p" with default value set to false.  Update
4512         function documentation as well as all callers.
4513         (windows_delete_thread): Likewise.
4514         (fake_create_process): Update call to windows_add_thread.
4515         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4516         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4517         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4518         call to windows_delete_thread.
4519
4520 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4521
4522         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4523
4524 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4525
4526         * symfile.c (find_separate_debug_file): Use canonical path of
4527         sysroot with child_path instead of gdb_sysroot if it is valid.
4528
4529 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4530
4531         * symfile.c (find_separate_debug_file): Use child_path to
4532         determine if an object file is under a sysroot.
4533
4534 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4535
4536         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4537         unittests/child-path-selftests.c.
4538         * common/pathstuff.c (child_path): New function.
4539         * common/pathstuff.h (child_path): New prototype.
4540         * unittests/child-path-selftests.c: New file.
4541
4542 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4543
4544         * symfile.c (find_separate_debug_file): Look for separate debug
4545         files in debug directories under the sysroot.
4546
4547 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4548
4549         * symtab.h (struct minimal_symbol data_p): New const method.
4550         (struct minimal_symbol text_p): Likewise.
4551         * symtab.c (output_source_filename): Use file name style
4552         to print file name.
4553         (print_symbol_info): Likewise.
4554         (print_msymbol_info): Use address style to print addresses.
4555         Use function name style to print executable text symbols.
4556         (expand_symtab_containing_pc): Use data_p.
4557         (find_pc_sect_compunit_symtab): Likewise.
4558
4559 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4560
4561         * breakpoint.c (describe_other_breakpoints): Use address style
4562         to print addresses.
4563         (say_where): Likewise.
4564
4565 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4566
4567         * ada-typeprint.c (print_func_type): Print function name
4568         style to print function name.
4569         * c-typeprint.c (c_print_type_1): Likewise.
4570
4571 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4572
4573         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4574         for execve.
4575
4576 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4577
4578         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4579         type_stack.
4580
4581 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4582
4583         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4584         TYPE_CODE_REF types.
4585
4586 2019-02-08  Jim Wilson  <jimw@sifive.com>
4587
4588         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4589         (riscv_linux_fregset): New.
4590         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4591
4592 2019-02-07  Tom Tromey  <tom@tromey.com>
4593
4594         * thread.c (thread_cancel_execution_command): Update.
4595         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4596         methods.
4597         (struct thread_fsm_ops): Remove.
4598         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4599         (thread_fsm_should_stop, thread_fsm_return_value)
4600         (thread_fsm_set_finished, thread_fsm_finished_p)
4601         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4602         Don't declare.
4603         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4604         * infrun.c (clear_proceed_status_thread)
4605         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4606         (print_stop_event): Update.
4607         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4608         Add constructor.
4609         (step_command_fsm_ops): Remove.
4610         (new_step_command_fsm): Remove.
4611         (step_1): Update.
4612         (step_command_fsm::should_stop): Rename from
4613         step_command_fsm_should_stop.
4614         (step_command_fsm::clean_up): Rename from
4615         step_command_fsm_clean_up.
4616         (step_command_fsm::do_async_reply_reason): Rename from
4617         step_command_fsm_async_reply_reason.
4618         (struct until_next_fsm): Inherit from thread_fsm.  Add
4619         constructor.
4620         (until_next_fsm_ops): Remove.
4621         (new_until_next_fsm): Remove.
4622         (until_next_fsm::should_stop): Rename from
4623         until_next_fsm_should_stop.
4624         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4625         (until_next_fsm::do_async_reply_reason): Rename from
4626         until_next_fsm_async_reply_reason.
4627         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4628         constructor.  Change type of breakpoint.
4629         (finish_command_fsm_ops): Remove.
4630         (new_finish_command_fsm): Remove.
4631         (finish_command_fsm::should_stop): Rename from
4632         finish_command_fsm_should_stop.
4633         (finish_command_fsm::clean_up): Rename from
4634         finish_command_fsm_clean_up.
4635         (finish_command_fsm::return_value): Rename from
4636         finish_command_fsm_return_value.
4637         (finish_command_fsm::do_async_reply_reason): Rename from
4638         finish_command_fsm_async_reply_reason.
4639         (finish_command): Update.
4640         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4641         Add constructor.
4642         (call_thread_fsm_ops): Remove.
4643         (call_thread_fsm::call_thread_fsm): Rename from
4644         new_call_thread_fsm.
4645         (call_thread_fsm::should_stop): Rename from
4646         call_thread_fsm_should_stop.
4647         (call_thread_fsm::should_notify_stop): Rename from
4648         call_thread_fsm_should_notify_stop.
4649         (run_inferior_call, call_function_by_hand_dummy): Update.
4650         * cli/cli-interp.c (should_print_stop_to_console): Update.
4651         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4652         Add constructor.  Change type of location_breakpoint,
4653         caller_breakpoint.
4654         (until_break_fsm_ops): Remove.
4655         (new_until_break_fsm): Remove.
4656         (until_break_fsm::should_stop): Rename from
4657         until_break_fsm_should_stop.
4658         (until_break_fsm::clean_up): Rename from
4659         until_break_fsm_clean_up.
4660         (until_break_fsm::do_async_reply_reason): Rename from
4661         until_break_fsm_async_reply_reason.
4662         (until_break_command): Update.
4663         * thread-fsm.c: Remove.
4664         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4665
4666 2019-02-07  Tom Tromey  <tom@tromey.com>
4667
4668         * yy-remap.h: Add include guard.
4669         * xtensa-tdep.h: Add include guard.
4670         * xcoffread.h: Rename include guard.
4671         * varobj-iter.h: Add include guard.
4672         * tui/tui.h: Rename include guard.
4673         * tui/tui-winsource.h: Rename include guard.
4674         * tui/tui-wingeneral.h: Rename include guard.
4675         * tui/tui-windata.h: Rename include guard.
4676         * tui/tui-win.h: Rename include guard.
4677         * tui/tui-stack.h: Rename include guard.
4678         * tui/tui-source.h: Rename include guard.
4679         * tui/tui-regs.h: Rename include guard.
4680         * tui/tui-out.h: Rename include guard.
4681         * tui/tui-layout.h: Rename include guard.
4682         * tui/tui-io.h: Rename include guard.
4683         * tui/tui-hooks.h: Rename include guard.
4684         * tui/tui-file.h: Rename include guard.
4685         * tui/tui-disasm.h: Rename include guard.
4686         * tui/tui-data.h: Rename include guard.
4687         * tui/tui-command.h: Rename include guard.
4688         * tic6x-tdep.h: Add include guard.
4689         * target/waitstatus.h: Rename include guard.
4690         * target/wait.h: Rename include guard.
4691         * target/target.h: Rename include guard.
4692         * target/resume.h: Rename include guard.
4693         * target-float.h: Rename include guard.
4694         * stabsread.h: Add include guard.
4695         * rs6000-tdep.h: Add include guard.
4696         * riscv-fbsd-tdep.h: Add include guard.
4697         * regformats/regdef.h: Rename include guard.
4698         * record.h: Rename include guard.
4699         * python/python.h: Rename include guard.
4700         * python/python-internal.h: Rename include guard.
4701         * python/py-stopevent.h: Rename include guard.
4702         * python/py-ref.h: Rename include guard.
4703         * python/py-record.h: Rename include guard.
4704         * python/py-record-full.h: Rename include guard.
4705         * python/py-record-btrace.h: Rename include guard.
4706         * python/py-instruction.h: Rename include guard.
4707         * python/py-events.h: Rename include guard.
4708         * python/py-event.h: Rename include guard.
4709         * procfs.h: Add include guard.
4710         * proc-utils.h: Add include guard.
4711         * p-lang.h: Add include guard.
4712         * or1k-tdep.h: Rename include guard.
4713         * observable.h: Rename include guard.
4714         * nto-tdep.h: Rename include guard.
4715         * nat/x86-linux.h: Rename include guard.
4716         * nat/x86-linux-dregs.h: Rename include guard.
4717         * nat/x86-gcc-cpuid.h: Add include guard.
4718         * nat/x86-dregs.h: Rename include guard.
4719         * nat/x86-cpuid.h: Rename include guard.
4720         * nat/ppc-linux.h: Rename include guard.
4721         * nat/mips-linux-watch.h: Rename include guard.
4722         * nat/linux-waitpid.h: Rename include guard.
4723         * nat/linux-ptrace.h: Rename include guard.
4724         * nat/linux-procfs.h: Rename include guard.
4725         * nat/linux-osdata.h: Rename include guard.
4726         * nat/linux-nat.h: Rename include guard.
4727         * nat/linux-namespaces.h: Rename include guard.
4728         * nat/linux-btrace.h: Rename include guard.
4729         * nat/glibc_thread_db.h: Rename include guard.
4730         * nat/gdb_thread_db.h: Rename include guard.
4731         * nat/gdb_ptrace.h: Rename include guard.
4732         * nat/fork-inferior.h: Rename include guard.
4733         * nat/amd64-linux-siginfo.h: Rename include guard.
4734         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4735         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4736         * nat/aarch64-linux.h: Rename include guard.
4737         * nat/aarch64-linux-hw-point.h: Rename include guard.
4738         * mn10300-tdep.h: Add include guard.
4739         * mips-linux-tdep.h: Add include guard.
4740         * mi/mi-parse.h: Rename include guard.
4741         * mi/mi-out.h: Rename include guard.
4742         * mi/mi-main.h: Rename include guard.
4743         * mi/mi-interp.h: Rename include guard.
4744         * mi/mi-getopt.h: Rename include guard.
4745         * mi/mi-console.h: Rename include guard.
4746         * mi/mi-common.h: Rename include guard.
4747         * mi/mi-cmds.h: Rename include guard.
4748         * mi/mi-cmd-break.h: Rename include guard.
4749         * m2-lang.h: Add include guard.
4750         * location.h: Rename include guard.
4751         * linux-record.h: Rename include guard.
4752         * linux-nat.h: Add include guard.
4753         * linux-fork.h: Add include guard.
4754         * i386-darwin-tdep.h: Rename include guard.
4755         * hppa-linux-offsets.h: Add include guard.
4756         * guile/guile.h: Rename include guard.
4757         * guile/guile-internal.h: Rename include guard.
4758         * gnu-nat.h: Rename include guard.
4759         * gdb-stabs.h: Rename include guard.
4760         * frv-tdep.h: Add include guard.
4761         * f-lang.h: Add include guard.
4762         * event-loop.h: Add include guard.
4763         * darwin-nat.h: Rename include guard.
4764         * cp-abi.h: Rename include guard.
4765         * config/sparc/nm-sol2.h: Rename include guard.
4766         * config/nm-nto.h: Rename include guard.
4767         * config/nm-linux.h: Add include guard.
4768         * config/i386/nm-i386gnu.h: Rename include guard.
4769         * config/djgpp/nl_types.h: Rename include guard.
4770         * config/djgpp/langinfo.h: Rename include guard.
4771         * compile/gcc-cp-plugin.h: Add include guard.
4772         * compile/gcc-c-plugin.h: Add include guard.
4773         * compile/compile.h: Rename include guard.
4774         * compile/compile-object-run.h: Rename include guard.
4775         * compile/compile-object-load.h: Rename include guard.
4776         * compile/compile-internal.h: Rename include guard.
4777         * compile/compile-cplus.h: Rename include guard.
4778         * compile/compile-c.h: Rename include guard.
4779         * common/xml-utils.h: Rename include guard.
4780         * common/x86-xstate.h: Rename include guard.
4781         * common/version.h: Rename include guard.
4782         * common/vec.h: Rename include guard.
4783         * common/tdesc.h: Rename include guard.
4784         * common/selftest.h: Rename include guard.
4785         * common/scoped_restore.h: Rename include guard.
4786         * common/scoped_mmap.h: Rename include guard.
4787         * common/scoped_fd.h: Rename include guard.
4788         * common/safe-iterator.h: Rename include guard.
4789         * common/run-time-clock.h: Rename include guard.
4790         * common/refcounted-object.h: Rename include guard.
4791         * common/queue.h: Rename include guard.
4792         * common/ptid.h: Rename include guard.
4793         * common/print-utils.h: Rename include guard.
4794         * common/preprocessor.h: Rename include guard.
4795         * common/pathstuff.h: Rename include guard.
4796         * common/observable.h: Rename include guard.
4797         * common/netstuff.h: Rename include guard.
4798         * common/job-control.h: Rename include guard.
4799         * common/host-defs.h: Rename include guard.
4800         * common/gdb_wait.h: Rename include guard.
4801         * common/gdb_vecs.h: Rename include guard.
4802         * common/gdb_unlinker.h: Rename include guard.
4803         * common/gdb_unique_ptr.h: Rename include guard.
4804         * common/gdb_tilde_expand.h: Rename include guard.
4805         * common/gdb_sys_time.h: Rename include guard.
4806         * common/gdb_string_view.h: Rename include guard.
4807         * common/gdb_splay_tree.h: Rename include guard.
4808         * common/gdb_setjmp.h: Rename include guard.
4809         * common/gdb_ref_ptr.h: Rename include guard.
4810         * common/gdb_optional.h: Rename include guard.
4811         * common/gdb_locale.h: Rename include guard.
4812         * common/gdb_assert.h: Rename include guard.
4813         * common/filtered-iterator.h: Rename include guard.
4814         * common/filestuff.h: Rename include guard.
4815         * common/fileio.h: Rename include guard.
4816         * common/environ.h: Rename include guard.
4817         * common/common-utils.h: Rename include guard.
4818         * common/common-types.h: Rename include guard.
4819         * common/common-regcache.h: Rename include guard.
4820         * common/common-inferior.h: Rename include guard.
4821         * common/common-gdbthread.h: Rename include guard.
4822         * common/common-exceptions.h: Rename include guard.
4823         * common/common-defs.h: Rename include guard.
4824         * common/common-debug.h: Rename include guard.
4825         * common/cleanups.h: Rename include guard.
4826         * common/buffer.h: Rename include guard.
4827         * common/btrace-common.h: Rename include guard.
4828         * common/break-common.h: Rename include guard.
4829         * cli/cli-utils.h: Rename include guard.
4830         * cli/cli-style.h: Rename include guard.
4831         * cli/cli-setshow.h: Rename include guard.
4832         * cli/cli-script.h: Rename include guard.
4833         * cli/cli-interp.h: Rename include guard.
4834         * cli/cli-decode.h: Rename include guard.
4835         * cli/cli-cmds.h: Rename include guard.
4836         * charset-list.h: Add include guard.
4837         * buildsym-legacy.h: Rename include guard.
4838         * bfin-tdep.h: Add include guard.
4839         * ax.h: Rename include guard.
4840         * arm-linux-tdep.h: Add include guard.
4841         * arm-fbsd-tdep.h: Add include guard.
4842         * arch/xtensa.h: Rename include guard.
4843         * arch/tic6x.h: Add include guard.
4844         * arch/i386.h: Add include guard.
4845         * arch/arm.h: Rename include guard.
4846         * arch/arm-linux.h: Rename include guard.
4847         * arch/arm-get-next-pcs.h: Rename include guard.
4848         * arch/amd64.h: Add include guard.
4849         * arch/aarch64-insn.h: Rename include guard.
4850         * arch-utils.h: Rename include guard.
4851         * annotate.h: Add include guard.
4852         * amd64-darwin-tdep.h: Rename include guard.
4853         * aarch64-linux-tdep.h: Add include guard.
4854         * aarch64-fbsd-tdep.h: Add include guard.
4855         * aarch32-linux-nat.h: Add include guard.
4856
4857 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4858
4859         * macrotab.c (macro_define_internal): New function that
4860         factorizes macro_define_object_internal and macro_define_function
4861         code.
4862         (macro_define_object_internal): Use macro_define_internal.
4863         (macro_define_function): Likewise.
4864
4865 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4866
4867         * macrocmd.c (extract_identifier): Return
4868         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4869         callers.
4870
4871 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4872
4873         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4874
4875 2019-02-05  Tom Tromey  <tom@tromey.com>
4876
4877         * target.c (target_stack::unpush): Move assertion earlier.
4878
4879 2019-01-30  Tom Tromey  <tom@tromey.com>
4880
4881         PR python/23615:
4882         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4883         (gdbpy_parse_and_eval): Likewise.
4884         * python/python-internal.h (gdbpy_allow_threads): New class.
4885
4886 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4887
4888         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4889         (aarch64_fbsd_fpregmap): Move earlier.
4890         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4891         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4892         instead of individual calls to trad_frame_set_reg_addr.
4893         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4894         earlier.
4895         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4896         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4897         instead of individual calls to trad_frame_set_reg_addr.
4898
4899 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4900
4901         * CONTRIBUTE: Replace contribution list with wiki link.
4902
4903 2019-01-25  Tom Tromey  <tom@tromey.com>
4904
4905         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4906
4907 2019-01-25  Tom Tromey  <tom@tromey.com>
4908
4909         * xtensa-linux-nat.c: Fix common/ includes.
4910         * xml-support.h: Fix common/ includes.
4911         * xml-support.c: Fix common/ includes.
4912         * x86-linux-nat.c: Fix common/ includes.
4913         * windows-nat.c: Fix common/ includes.
4914         * varobj.h: Fix common/ includes.
4915         * varobj.c: Fix common/ includes.
4916         * value.c: Fix common/ includes.
4917         * valops.c: Fix common/ includes.
4918         * utils.c: Fix common/ includes.
4919         * unittests/xml-utils-selftests.c: Fix common/ includes.
4920         * unittests/utils-selftests.c: Fix common/ includes.
4921         * unittests/unpack-selftests.c: Fix common/ includes.
4922         * unittests/tracepoint-selftests.c: Fix common/ includes.
4923         * unittests/style-selftests.c: Fix common/ includes.
4924         * unittests/string_view-selftests.c: Fix common/ includes.
4925         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4926         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4927         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4928         * unittests/rsp-low-selftests.c: Fix common/ includes.
4929         * unittests/parse-connection-spec-selftests.c: Fix common/
4930         includes.
4931         * unittests/optional-selftests.c: Fix common/ includes.
4932         * unittests/offset-type-selftests.c: Fix common/ includes.
4933         * unittests/observable-selftests.c: Fix common/ includes.
4934         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4935         * unittests/memrange-selftests.c: Fix common/ includes.
4936         * unittests/memory-map-selftests.c: Fix common/ includes.
4937         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4938         * unittests/function-view-selftests.c: Fix common/ includes.
4939         * unittests/environ-selftests.c: Fix common/ includes.
4940         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4941         * unittests/common-utils-selftests.c: Fix common/ includes.
4942         * unittests/cli-utils-selftests.c: Fix common/ includes.
4943         * unittests/array-view-selftests.c: Fix common/ includes.
4944         * ui-file.c: Fix common/ includes.
4945         * tui/tui-io.c: Fix common/ includes.
4946         * tracepoint.h: Fix common/ includes.
4947         * tracepoint.c: Fix common/ includes.
4948         * tracefile-tfile.c: Fix common/ includes.
4949         * top.h: Fix common/ includes.
4950         * top.c: Fix common/ includes.
4951         * thread.c: Fix common/ includes.
4952         * target/waitstatus.h: Fix common/ includes.
4953         * target/waitstatus.c: Fix common/ includes.
4954         * target.h: Fix common/ includes.
4955         * target.c: Fix common/ includes.
4956         * target-memory.c: Fix common/ includes.
4957         * target-descriptions.c: Fix common/ includes.
4958         * symtab.h: Fix common/ includes.
4959         * symfile.c: Fix common/ includes.
4960         * stap-probe.c: Fix common/ includes.
4961         * spu-linux-nat.c: Fix common/ includes.
4962         * sparc-nat.c: Fix common/ includes.
4963         * source.c: Fix common/ includes.
4964         * solib.c: Fix common/ includes.
4965         * solib-target.c: Fix common/ includes.
4966         * ser-unix.c: Fix common/ includes.
4967         * ser-tcp.c: Fix common/ includes.
4968         * ser-pipe.c: Fix common/ includes.
4969         * ser-base.c: Fix common/ includes.
4970         * selftest-arch.c: Fix common/ includes.
4971         * s12z-tdep.c: Fix common/ includes.
4972         * rust-exp.y: Fix common/ includes.
4973         * rs6000-aix-tdep.c: Fix common/ includes.
4974         * riscv-tdep.c: Fix common/ includes.
4975         * remote.c: Fix common/ includes.
4976         * remote-notif.h: Fix common/ includes.
4977         * remote-fileio.h: Fix common/ includes.
4978         * remote-fileio.c: Fix common/ includes.
4979         * regcache.h: Fix common/ includes.
4980         * regcache.c: Fix common/ includes.
4981         * record-btrace.c: Fix common/ includes.
4982         * python/python.c: Fix common/ includes.
4983         * python/py-type.c: Fix common/ includes.
4984         * python/py-inferior.c: Fix common/ includes.
4985         * progspace.h: Fix common/ includes.
4986         * producer.c: Fix common/ includes.
4987         * procfs.c: Fix common/ includes.
4988         * proc-api.c: Fix common/ includes.
4989         * printcmd.c: Fix common/ includes.
4990         * ppc-linux-nat.c: Fix common/ includes.
4991         * parser-defs.h: Fix common/ includes.
4992         * osdata.c: Fix common/ includes.
4993         * obsd-nat.c: Fix common/ includes.
4994         * nat/x86-linux.c: Fix common/ includes.
4995         * nat/x86-linux-dregs.c: Fix common/ includes.
4996         * nat/x86-dregs.h: Fix common/ includes.
4997         * nat/x86-dregs.c: Fix common/ includes.
4998         * nat/ppc-linux.c: Fix common/ includes.
4999         * nat/mips-linux-watch.h: Fix common/ includes.
5000         * nat/mips-linux-watch.c: Fix common/ includes.
5001         * nat/linux-waitpid.c: Fix common/ includes.
5002         * nat/linux-ptrace.h: Fix common/ includes.
5003         * nat/linux-ptrace.c: Fix common/ includes.
5004         * nat/linux-procfs.c: Fix common/ includes.
5005         * nat/linux-personality.c: Fix common/ includes.
5006         * nat/linux-osdata.c: Fix common/ includes.
5007         * nat/linux-namespaces.c: Fix common/ includes.
5008         * nat/linux-btrace.h: Fix common/ includes.
5009         * nat/linux-btrace.c: Fix common/ includes.
5010         * nat/fork-inferior.c: Fix common/ includes.
5011         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5012         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5013         * nat/aarch64-linux.c: Fix common/ includes.
5014         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5015         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5016         * namespace.h: Fix common/ includes.
5017         * mips-linux-tdep.c: Fix common/ includes.
5018         * minsyms.c: Fix common/ includes.
5019         * mi/mi-parse.h: Fix common/ includes.
5020         * mi/mi-main.c: Fix common/ includes.
5021         * mi/mi-cmd-env.c: Fix common/ includes.
5022         * memrange.h: Fix common/ includes.
5023         * memattr.c: Fix common/ includes.
5024         * maint.h: Fix common/ includes.
5025         * maint.c: Fix common/ includes.
5026         * main.c: Fix common/ includes.
5027         * machoread.c: Fix common/ includes.
5028         * location.c: Fix common/ includes.
5029         * linux-thread-db.c: Fix common/ includes.
5030         * linux-nat.c: Fix common/ includes.
5031         * linux-fork.c: Fix common/ includes.
5032         * inline-frame.c: Fix common/ includes.
5033         * infrun.c: Fix common/ includes.
5034         * inflow.c: Fix common/ includes.
5035         * inferior.h: Fix common/ includes.
5036         * inferior.c: Fix common/ includes.
5037         * infcmd.c: Fix common/ includes.
5038         * inf-ptrace.c: Fix common/ includes.
5039         * inf-child.c: Fix common/ includes.
5040         * ia64-linux-nat.c: Fix common/ includes.
5041         * i387-tdep.c: Fix common/ includes.
5042         * i386-tdep.c: Fix common/ includes.
5043         * i386-linux-tdep.c: Fix common/ includes.
5044         * i386-linux-nat.c: Fix common/ includes.
5045         * i386-go32-tdep.c: Fix common/ includes.
5046         * i386-fbsd-tdep.c: Fix common/ includes.
5047         * i386-fbsd-nat.c: Fix common/ includes.
5048         * guile/scm-type.c: Fix common/ includes.
5049         * guile/guile.c: Fix common/ includes.
5050         * go32-nat.c: Fix common/ includes.
5051         * gnu-nat.c: Fix common/ includes.
5052         * gdbthread.h: Fix common/ includes.
5053         * gdbarch-selftests.c: Fix common/ includes.
5054         * gdb_usleep.c: Fix common/ includes.
5055         * gdb_select.h: Fix common/ includes.
5056         * gdb_bfd.c: Fix common/ includes.
5057         * gcore.c: Fix common/ includes.
5058         * fork-child.c: Fix common/ includes.
5059         * findvar.c: Fix common/ includes.
5060         * fbsd-nat.c: Fix common/ includes.
5061         * event-top.c: Fix common/ includes.
5062         * event-loop.c: Fix common/ includes.
5063         * dwarf2read.c: Fix common/ includes.
5064         * dwarf2loc.c: Fix common/ includes.
5065         * dwarf2-frame.c: Fix common/ includes.
5066         * dwarf-index-cache.c: Fix common/ includes.
5067         * dtrace-probe.c: Fix common/ includes.
5068         * disasm-selftests.c: Fix common/ includes.
5069         * defs.h: Fix common/ includes.
5070         * csky-tdep.c: Fix common/ includes.
5071         * cp-valprint.c: Fix common/ includes.
5072         * cp-support.h: Fix common/ includes.
5073         * cp-support.c: Fix common/ includes.
5074         * corelow.c: Fix common/ includes.
5075         * completer.h: Fix common/ includes.
5076         * completer.c: Fix common/ includes.
5077         * compile/compile.c: Fix common/ includes.
5078         * compile/compile-loc2c.c: Fix common/ includes.
5079         * compile/compile-cplus-types.c: Fix common/ includes.
5080         * compile/compile-cplus-symbols.c: Fix common/ includes.
5081         * command.h: Fix common/ includes.
5082         * cli/cli-dump.c: Fix common/ includes.
5083         * cli/cli-cmds.c: Fix common/ includes.
5084         * charset.c: Fix common/ includes.
5085         * build-id.c: Fix common/ includes.
5086         * btrace.h: Fix common/ includes.
5087         * btrace.c: Fix common/ includes.
5088         * breakpoint.h: Fix common/ includes.
5089         * breakpoint.c: Fix common/ includes.
5090         * ax.h:
5091         (enum agent_op): Fix common/ includes.
5092         * ax-general.c (struct aop_map): Fix common/ includes.
5093         * ax-gdb.c: Fix common/ includes.
5094         * auxv.c: Fix common/ includes.
5095         * auto-load.c: Fix common/ includes.
5096         * arm-tdep.c: Fix common/ includes.
5097         * arch/riscv.c: Fix common/ includes.
5098         * arch/ppc-linux-common.c: Fix common/ includes.
5099         * arch/i386.c: Fix common/ includes.
5100         * arch/arm.c: Fix common/ includes.
5101         * arch/arm-linux.c: Fix common/ includes.
5102         * arch/arm-get-next-pcs.c: Fix common/ includes.
5103         * arch/amd64.c: Fix common/ includes.
5104         * arch/aarch64.c: Fix common/ includes.
5105         * arch/aarch64-insn.c: Fix common/ includes.
5106         * arch-utils.c: Fix common/ includes.
5107         * amd64-windows-tdep.c: Fix common/ includes.
5108         * amd64-tdep.c: Fix common/ includes.
5109         * amd64-sol2-tdep.c: Fix common/ includes.
5110         * amd64-obsd-tdep.c: Fix common/ includes.
5111         * amd64-nbsd-tdep.c: Fix common/ includes.
5112         * amd64-linux-tdep.c: Fix common/ includes.
5113         * amd64-linux-nat.c: Fix common/ includes.
5114         * amd64-fbsd-tdep.c: Fix common/ includes.
5115         * amd64-fbsd-nat.c: Fix common/ includes.
5116         * amd64-dicos-tdep.c: Fix common/ includes.
5117         * amd64-darwin-tdep.c: Fix common/ includes.
5118         * agent.c: Fix common/ includes.
5119         * ada-lang.h: Fix common/ includes.
5120         * ada-lang.c: Fix common/ includes.
5121         * aarch64-tdep.c: Fix common/ includes.
5122
5123 2019-01-25  Tom Tromey  <tom@tromey.com>
5124
5125         * common/create-version.sh: Use common/version.h.
5126
5127 2019-01-24  Pedro Alves  <palves@redhat.com>
5128
5129         * infrun.c (signal_stop, signal_print, signal_program)
5130         (signal_catch, signal_pass): Now arrays instead of pointers.
5131         (update_signals_program_target, do_target_resume)
5132         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5133         * linux-nat.c (linux_nat_target::pass_signals)
5134         (linux_nat_target::create_inferior, linux_nat_target::attach):
5135         Adjust.
5136         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5137         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5138         * procfs.c (procfs_target::pass_signals): Adjust.
5139         * record-full.c (record_full_target::resume): Adjust.
5140         * remote.c (remote_target::pass_signals)
5141         (remote_target::program_signals): Adjust.
5142         * target-debug.h (target_debug_print_signals): Now takes a
5143         gdb::array_view as parameter.  Adjust.
5144         * target.h (target_ops) <pass_signals, program_signals>: Replace
5145         pointer and length parameters with gdb::array_view.
5146         (target_pass_signals, target_program_signals): Likewise.
5147         * target-delegates.c: Regenerate.
5148
5149 2019-01-24  Pedro Alves  <palves@redhat.com>
5150
5151         * common/forward-scope-exit.h
5152         (forward_scope_exit::forward_scope_exit): Pass arguments to
5153         m_bind_function directly, instead of creating a std::bind and
5154         copying that.
5155
5156 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5157
5158         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5159         for static members.
5160         (pass_in_v_vfp_candidate): Likewise.
5161
5162 2019-01-23  Tom Tromey  <tom@tromey.com>
5163             Pedro Alves  <palves@redhat.com>
5164
5165         * regcache.c (class regcache_invalidator): Remove.
5166         (regcache::raw_write): Use make_scope_exit.
5167
5168 2019-01-23  Tom Tromey  <tom@tromey.com>
5169
5170         * ui-out.h (class ui_out_emit_type): Update comment.
5171
5172 2019-01-23  Tom Tromey  <tom@tromey.com>
5173
5174         * infrun.c (fetch_inferior_event): Update comment.
5175
5176 2019-01-23  Tom Tromey  <tom@tromey.com>
5177             Pedro Alves  <palves@redhat.com>
5178
5179         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5180         parameter.
5181         (fetch_inferior_event): Use SCOPE_EXIT.
5182
5183
5184 2019-01-23  Tom Tromey  <tom@tromey.com>
5185             Pedro Alves  <palves@redhat.com>
5186
5187         * infrun.c (disable_thread_events): Delete.
5188         (stop_all_threads): Use SCOPE_EXIT.
5189
5190 2019-01-23  Tom Tromey  <tom@tromey.com>
5191             Pedro Alves  <palves@redhat.com>
5192
5193         * symfile.c: Include forward-scope-exit.h.
5194         (clear_symtab_users_cleanup): Replace forward declaration with
5195         a FORWARD_SCOPE_EXIT.
5196         (syms_from_objfile_1): Use the forward_scope_exit and
5197         gdb::optional instead of cleanup_function.
5198         (reread_symbols): Use the forward_scope_exit instead of
5199         cleanup_function.
5200         (clear_symtab_users_cleanup): Remove function.
5201
5202 2019-01-23  Tom Tromey  <tom@tromey.com>
5203             Pedro Alves  <palves@redhat.com>
5204
5205         * linux-nat.c: Include scope-exit.h.
5206         (cleanup_target_stop): Remove.
5207         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5208         SCOPE_EXIT.
5209
5210 2019-01-23  Tom Tromey  <tom@tromey.com>
5211             Pedro Alves  <palves@redhat.com>
5212
5213         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5214         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5215
5216 2019-01-23  Tom Tromey  <tom@tromey.com>
5217             Andrew Burgess  <andrew.burgess@embecosm.com>
5218             Pedro Alves  <palves@redhat.com>
5219
5220         * infrun.c (fetch_inferior_event): Use scope_exit.
5221         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5222         * top.c (execute_command): Use scope_exit.
5223         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5224         * utils.c (do_bpstat_clear_actions_cleanup)
5225         (make_bpstat_clear_actions_cleanup): Remove.
5226
5227 2019-01-23  Tom Tromey  <tom@tromey.com>
5228             Pedro Alves  <palves@redhat.com>
5229
5230         * infrun.c: Include "common/scope-exit.h"
5231         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5232         (wait_for_inferior): Use SCOPE_EXIT.
5233         (fetch_inferior_event): Use scope_exit.
5234
5235 2019-01-23  Tom Tromey  <tom@tromey.com>
5236             Pedro Alves  <palves@redhat.com>
5237
5238         * breakpoint.c (create_breakpoint): Remove cleanup.
5239
5240 2019-01-23  Tom Tromey  <tom@tromey.com>
5241             Andrew Burgess  <andrew.burgess@embecosm.com>
5242             Pedro Alves  <palves@redhat.com>
5243
5244 2019-01-23  Pedro Alves  <palves@redhat.com>
5245
5246         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5247
5248 2019-01-23  Pedro Alves  <palves@redhat.com>
5249             Andrew Burgess  <andrew.burgess@embecosm.com>
5250
5251         * gdbthread.h: Include "common/forward-scope-exit.h".
5252         (scoped_finish_thread_state): Redefine custom class in terms of
5253         forward_scope_exit.
5254
5255 2019-01-23  Pedro Alves  <palves@redhat.com>
5256             Andrew Burgess  <andrew.burgess@embecosm.com>
5257
5258         * common/forward-scope-exit.h: New file.
5259
5260 2019-01-23  Pedro Alves  <palves@redhat.com>
5261             Andrew Burgess  <andrew.burgess@embecosm.com>
5262             Tom Tromey  <tom@tromey.com>
5263
5264         * common/scope-exit.h: New file.
5265
5266 2019-01-23  Pedro Alves  <palves@redhat.com>
5267
5268         * common/preprocessor.h (ESC): Rename to ...
5269         (ESC_PARENS): ... this.
5270         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5271         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5272
5273 2019-01-23  Tom Tromey  <tom@tromey.com>
5274
5275         * language.h (class scoped_switch_to_sym_language_if_auto):
5276         Initialize m_lang in both cases.
5277
5278 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5279
5280         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5281         with XCNEW.
5282
5283 2019-01-22  Tom Tromey  <tom@tromey.com>
5284
5285         * corelow.c: Do not include sys/file.h.
5286
5287 2019-01-22  Tom Tromey  <tom@tromey.com>
5288
5289         * tui/tui-wingeneral.h: Include gdb_curses.h.
5290
5291 2019-01-22  Tom Tromey  <tom@tromey.com>
5292
5293         * source-cache.h (class source_cache) <get_source_lines,
5294         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5295
5296 2019-01-22  Tom Tromey  <tom@tromey.com>
5297
5298         * remote-fileio.h (struct remote_target): Declare.
5299
5300 2019-01-22  Tom Tromey  <tom@tromey.com>
5301
5302         * python/py-arch.c: Do not include py-ref.h.
5303         * python/py-bpevent.c: Do not include py-ref.h.
5304         * python/py-cmd.c: Do not include py-ref.h.
5305         * python/py-continueevent.c: Do not include py-ref.h.
5306         * python/py-event.h: Do not include py-ref.h.
5307         * python/py-evtregistry.c: Do not include py-ref.h.
5308         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5309         * python/py-frame.c: Do not include py-ref.h.
5310         * python/py-framefilter.c: Do not include py-ref.h.
5311         * python/py-function.c: Do not include py-ref.h.
5312         * python/py-infevents.c: Do not include py-ref.h.
5313         * python/py-linetable.c: Do not include py-ref.h.
5314         * python/py-objfile.c: Do not include py-ref.h.
5315         * python/py-param.c: Do not include py-ref.h.
5316         * python/py-prettyprint.c: Do not include py-ref.h.
5317         * python/py-progspace.c: Do not include py-ref.h.
5318         * python/py-symbol.c: Do not include py-ref.h.
5319         * python/py-symtab.c: Do not include py-ref.h.
5320         * python/py-type.c: Do not include py-ref.h.
5321         * python/py-unwind.c: Do not include py-ref.h.
5322         * python/py-utils.c: Do not include py-ref.h.
5323         * python/py-value.c: Do not include py-ref.h.
5324         * python/py-varobj.c: Do not include py-ref.h.
5325         * python/py-xmethods.c: Do not include py-ref.h.
5326         * python/python.c: Do not include py-ref.h.
5327         * varobj.c: Do not include py-ref.h.
5328
5329 2019-01-22  Tom Tromey  <tom@tromey.com>
5330
5331         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5332         keyword for bcache.
5333
5334 2019-01-22  Tom Tromey  <tom@tromey.com>
5335
5336         * compile/compile-cplus-types.c: Remove a comment by #include.
5337
5338 2019-01-22  Tom Tromey  <tom@tromey.com>
5339
5340         * compile/gcc-c-plugin.h: Include compile-internal.h.
5341
5342 2019-01-22  Tom Tromey  <tom@tromey.com>
5343
5344         * stabsread.c (EXTERN): Do not define.
5345         (symnum, next_symbol_text_func, processing_gcc_compilation)
5346         (within_function, global_sym_chain, global_stabs)
5347         (previous_stab_code, this_object_header_files)
5348         (n_this_object_header_files)
5349         (n_allocated_this_object_header_files): Define.
5350         * stabsread.h (EXTERN): Never define.  Use "extern".
5351
5352 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5353
5354         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5355         history_value.
5356
5357 2019-01-21  Tom Tromey  <tom@tromey.com>
5358
5359         * ui-out.c: Fix includes.
5360         * tui/tui-source.c: Fix includes.
5361         * target.c: Fix includes.
5362         * remote.c: Fix includes.
5363         * regcache.c: Fix includes.
5364         * python/py-block.c: Fix includes.
5365         * printcmd.c: Fix includes.
5366         * or1k-tdep.c: Fix includes.
5367         * mi/mi-main.c: Fix includes.
5368         * m32r-tdep.c: Fix includes.
5369         * csky-tdep.c: Fix includes.
5370         * compile/compile-cplus-types.c: Fix includes.
5371         * cli/cli-interp.c: Fix includes.
5372
5373 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5374
5375         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5376         for padding.
5377
5378 2019-01-16  Tom Tromey  <tom@tromey.com>
5379
5380         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5381         earlier.
5382         (struct objfile) <msymbols_range>: Move from top level.
5383         <msymbols>: New method.
5384         (class objfile_msymbols): Remove.
5385         * symtab.c (default_collect_symbol_completion_matches_break_on):
5386         Update.
5387         * symmisc.c (dump_msymbols): Update.
5388         * stabsread.c (scan_file_globals): Update.
5389         * objc-lang.c (info_selectors_command, info_classes_command)
5390         (find_methods): Update.
5391         * minsyms.c (find_solib_trampoline_target): Update.
5392         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5393         * coffread.c (coff_symfile_read): Update.
5394         * ada-lang.c (ada_lookup_simple_minsym)
5395         (ada_collect_symbol_completion_matches): Update.
5396
5397 2019-01-16  Tom Tromey  <tom@tromey.com>
5398
5399         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5400         type.  Remove no-argument constructor.
5401         <iterator::operator++>: Simplify.
5402         <begin>: Update.
5403         <end>: Use minimal_symbol_count.
5404
5405 2019-01-16  Tom Tromey  <tom@tromey.com>
5406
5407         * objfiles.h (struct objfile) <psymtabs>: New method.
5408         (class objfile_psymtabs): Remove.
5409         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5410         typedef.
5411         <range>: New method.
5412         (require_partial_symbols): Change return type.
5413         * psymtab.c (require_partial_symbols)
5414         (psym_expand_symtabs_matching): Update.
5415         * mdebugread.c (parse_partial_symbols): Update.
5416         * dbxread.c (dbx_end_psymtab): Update.
5417
5418 2019-01-15  Tom Tromey  <tom@tromey.com>
5419
5420         * symtab.c (lookup_objfile_from_block)
5421         (lookup_symbol_in_objfile_symtabs)
5422         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5423         (find_line_symtab, info_sources_command)
5424         (default_collect_symbol_completion_matches_break_on)
5425         (make_source_files_completion_list): Update.
5426         * symmisc.c (print_objfile_statistics, dump_objfile)
5427         (maintenance_print_symbols, maintenance_info_symtabs)
5428         (maintenance_check_symtabs, maintenance_info_line_tables):
5429         Update.
5430         * source.c (select_source_symtab)
5431         (forget_cached_source_info_for_objfile): Update.
5432         * objfiles.h (class objfile_compunits): Remove.
5433         (struct objfile) <compunits_range>: New typedef.
5434         (compunits): New method.
5435         * objfiles.c (objfile_relocate1): Update.
5436         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5437         * maint.c (count_symtabs_and_blocks): Update.
5438         * linespec.c (iterate_over_all_matching_symtabs): Update.
5439         * cp-support.c (add_symbol_overload_list_qualified): Update.
5440         * coffread.c (coff_symtab_read): Update.
5441         * ada-lang.c (add_nonlocal_symbols)
5442         (ada_collect_symbol_completion_matches)
5443         (ada_add_global_exceptions): Update.
5444
5445 2019-01-15  Tom Tromey  <tom@tromey.com>
5446
5447         * progspace.h (program_space) <objfiles_safe_range>: New
5448         typedef.
5449         <objfiles_safe>: New method.
5450         * objfiles.h (class all_objfiles_safe): Remove.
5451         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5452         * jit.c (jit_inferior_exit_hook): Update.
5453
5454 2019-01-17  Tom Tromey  <tom@tromey.com>
5455
5456         * progspace.h (program_space) <objfiles_range>: New typedef.
5457         <objfiles>: New method.
5458         <objfiles_head>: Rename from objfiles.
5459         (object_files): Update.
5460         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5461         * guile/scm-pretty-print.c
5462         (ppscm_find_pretty_printer_from_objfiles): Update.
5463         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5464         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5465         Update.
5466         * python/py-progspace.c (pspy_get_objfiles): Update.
5467         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5468         Update.
5469         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5470         (objfpy_lookup_objfile_by_build_id): Update.
5471         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5472         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5473         Update.
5474         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5475         (expand_symtab_containing_pc, lookup_objfile_from_block)
5476         (lookup_static_symbol, basic_lookup_transparent_type)
5477         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5478         (find_line_symtab, info_sources_command)
5479         (default_collect_symbol_completion_matches_break_on)
5480         (make_source_files_completion_list, find_main_name): Update.
5481         * symmisc.c (print_symbol_bcache_statistics)
5482         (print_objfile_statistics, maintenance_print_symbols)
5483         (maintenance_print_msymbols, maintenance_print_objfiles)
5484         (maintenance_info_symtabs, maintenance_check_symtabs)
5485         (maintenance_expand_symtabs, maintenance_info_line_tables):
5486         Update.
5487         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5488         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5489         (map_overlay_command, unmap_overlay_command)
5490         (simple_overlay_update, expand_symtabs_matching)
5491         (map_symbol_filenames): Update.
5492         * symfile-debug.c (set_debug_symfile): Update.
5493         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5494         Update.
5495         * source.c (select_source_symtab, forget_cached_source_info):
5496         Update.
5497         * solib.c (solib_read_symbols): Update.
5498         * solib-spu.c (append_ocl_sos): Update.
5499         * psymtab.c (maintenance_print_psymbols)
5500         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5501         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5502         * printcmd.c (info_symbol_command): Update.
5503         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5504         Update.
5505         * objfiles.h (class all_objfiles): Remove.
5506         * objfiles.c (have_partial_symbols, have_full_symbols)
5507         (have_minimal_symbols, qsort_cmp, update_section_map)
5508         (shared_objfile_contains_address_p)
5509         (default_iterate_over_objfiles_in_search_order): Update.
5510         * objc-lang.c (info_selectors_command, info_classes_command)
5511         (find_methods): Update.
5512         * minsyms.c (find_solib_trampoline_target): Update.
5513         * maint.c (maintenance_info_sections)
5514         (maintenance_translate_address, count_symtabs_and_blocks):
5515         Update.
5516         * main.c (captured_main_1): Update.
5517         * linux-thread-db.c (try_thread_db_load_from_pdir)
5518         (has_libpthread): Update.
5519         * linespec.c (iterate_over_all_matching_symtabs)
5520         (search_minsyms_for_name): Update.
5521         * jit.c (jit_find_objf_with_entry_addr): Update.
5522         * hppa-tdep.c (find_unwind_entry)
5523         (hppa_lookup_stub_minimal_symbol): Update.
5524         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5525         Update.
5526         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5527         (elf_gnu_ifunc_resolve_by_got): Update.
5528         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5529         * dwarf-index-write.c (save_gdb_index_command): Update.
5530         * cp-support.c (add_symbol_overload_list_qualified): Update.
5531         * breakpoint.c (create_overlay_event_breakpoint)
5532         (create_longjmp_master_breakpoint)
5533         (create_std_terminate_master_breakpoint)
5534         (create_exception_master_breakpoint): Update.
5535         * blockframe.c (find_pc_partial_function): Update.
5536         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5537         (ada_collect_symbol_completion_matches)
5538         (ada_add_global_exceptions): Update.
5539
5540 2019-01-17  Tom Tromey  <tom@tromey.com>
5541
5542         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5543         declare VEC.
5544         (solib_target_parse_libraries): Change return type.
5545         (library_list_start_segment, library_list_start_section)
5546         (library_list_end_library, library_list_start_library); Update.
5547         (solib_target_free_library_list): Remove.
5548         (solib_target_parse_libraries): Remove cleanup.  Change return
5549         type.
5550         (solib_target_current_sos): Update.
5551
5552 2019-01-17  Tom Tromey  <tromey@bapiya>
5553
5554         * valprint.c: Replace "the the" with "the".
5555         * symtab.c: Replace "the the" with "the".
5556         * solib.c: Replace "the the" with "the".
5557         * solib-dsbt.c: Replace "the the" with "the".
5558         * linespec.c: Replace "the the" with "the".
5559         * dwarf2loc.h: Replace "the the" with "the".
5560         * amd64-windows-tdep.c: Replace "the the" with "the".
5561         * aarch64-tdep.c: Replace "the the" with "the".
5562
5563 2019-01-16  Keith Seitz  <keiths@redhat.com>
5564
5565         PR gdb/23773
5566         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5567         <builder>: Rename to ..
5568         <m_builder>: ... this and make private.
5569         (dwarf2_cu::get_builder): New method.  Change all users of
5570         `builder' to use this method.
5571         (dwarf2_start_symtab): Move to ...
5572         (dwarf2_cu::start_symtab): ... here.  Update all callers
5573         (setup_type_unit_groups): Move to ...
5574         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5575         callers.
5576         (dwarf2_cu::reset_builder): New method.
5577         (process_full_compunit, process_full_type_unit): Use
5578         dwarf2_cu::reset_builder.
5579         (follow_die_offset): Record the ancestor CU if it is different
5580         from the followed DIE's CU.
5581         (follow_die_sig_1): Likewise.
5582
5583 2019-01-15  Tom Tromey  <tom@tromey.com>
5584
5585         * remote.c (class remote_state) <buf>: Now a char_vector.
5586         <buf_size>: Remove.
5587         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5588         parameter.
5589         (remote_target::getpkt_or_notif_sane_1)
5590         (remote_target::getpkt_sane)
5591         (remote_target::getpkt_or_notif_sane): Likewise.
5592         (class remote_target) <putpkt>: New overload.
5593         (remote_target::read_frame): Change type of "buf_p".  Remove
5594         sizeof_p parameter.
5595         (packet_ok): New overload.
5596         (packet_check_result): New overload.
5597         Update all uses.
5598
5599 2019-01-14  Tom Tromey  <tom@tromey.com>
5600
5601         * remote-notif.c (handle_notification, remote_notif_ack)
5602         (remote_notif_parse): Make "buf" const.
5603         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5604         const.
5605         (remote_notif_parse, remote_notif_ack, handle_notification):
5606         Likewise.
5607         * remote.c (remote_notif_stop_parse): Make "buf" const.
5608         (remote_target::remote_parse_stop_reply): Make "buf" const.
5609         (remote_notif_stop_ack): Make "buf" const.
5610
5611 2019-01-14  Tom Tromey  <tom@tromey.com>
5612
5613         * remote.c (remote_console_output): Make parameter const.
5614
5615 2019-01-14  Tom Tromey  <tom@tromey.com>
5616
5617         * target-debug.h (target_debug_print_signals): Constify.
5618         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5619         * procfs.c (procfs_target::pass_signals): Update.
5620         * linux-nat.c (linux_nat_target::pass_signals): Update.
5621         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5622         * target-delegates.c: Rebuild.
5623         * remote.c (remote_target::program_signals): Update.
5624         (remote_target::pass_signals): Update.
5625         * target.c (target_pass_signals): Constify argument.
5626         (target_program_signals): Likewise.
5627         * target.h (struct target_ops) <pass_signals, program_signals>:
5628         Constify argument.
5629         (target_pass_signals, target_program_signals): Constify argument.
5630
5631 2019-01-14  Tom Tromey  <tom@tromey.com>
5632
5633         PR tui/28819:
5634         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5635
5636 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5637
5638         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5639         field.
5640         * rs6000-tdep.c: Include reggroups.h.
5641         (IS_V_ALIAS_PSEUDOREG): Define.
5642         (rs6000_register_name): Return names for the "vX" aliases.
5643         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5644         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5645         aliases.  Call default_register_reggroup_p for all other
5646         pseudo-registers.
5647         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5648         New functions.
5649         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5650         Handle "vX" aliases.
5651         (v_alias_pseudo_register_collect): New function.
5652         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5653         (rs6000_gdbarch_init): Initialize "vX" aliases as
5654         pseudo-registers.  Restore registration of
5655         rs6000_pseudo_register_reggroup_p with
5656         set_tdesc_pseudo_register_reggroup_p.
5657
5658 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5659
5660         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5661         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5662         set_gdbarch_num_pseudo_regs.
5663
5664 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5665
5666         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5667         Remove arg prefixname, add do_set and do_show.
5668         Add member functions set_list and show_list.
5669         * cli/cli-style.c (class cli_style_option): Update accordingly.
5670         (style_set_list): Move to file scope.
5671         (style_show_list): Likewise.
5672         (set_style): Call help_list.
5673         (show_style): Call cmd_show_list.
5674         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5675         Update to use the new macro.
5676
5677 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5678
5679         * ada-lang.c (_initialize_ada_language): Expand the help text
5680         for the "catch exception" command.
5681
5682 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5683
5684         * symtab.c (matching_obj_sections): Initialize obj,
5685         declare it closer to its usage.
5686
5687 2019-01-10  Tom Tromey  <tom@tromey.com>
5688
5689         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5690         (basic_inf_threads_range): Remove.
5691         (inf_threads_range, inf_non_exited_threads_range)
5692         (safe_inf_threads_range): Use next_adapter.
5693
5694 2019-01-10  Keith Seitz  <keiths@redhat.com>
5695
5696         PR gdb/23712
5697         PR symtab/23010
5698         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5699         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5700
5701 2019-01-10  Keith Seitz  <keiths@redhat.com>
5702
5703         PR gdb/23712
5704         PR symtab/23010
5705         * dictionary.c (pending_to_vector): Remove.
5706         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5707         Remove _1 suffix, replacing functions of the same name.  Update
5708         all callers.
5709         (dict_create_hashed, dict_create_hashed_expandable)
5710         (dict_create_linear, dict_create_linear_expandable, dict_free)
5711         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5712         Make functions static.
5713
5714 2019-01-10  Keith Seitz  <keiths@redhat.com>
5715
5716         PR gdb/23712
5717         PR symtab/23010
5718         * dictionary.h (struct dictionary): Replace declaration with
5719         multidictionary.
5720         (dict_create_hashed, dict_create_hashed_expandable)
5721         (dict_create_linear, dict_create_linear_expandable)
5722         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5723         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5724         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5725         taking multidictionary argument.
5726         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5727         * block.h (struct block) <dict>: Change to multidictionary
5728         and rename `multidict'.
5729         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5730         symmisc.c: Update all dictionary references to multidictionary.
5731
5732 2019-01-10  Keith Seitz  <keiths@redhat.com>
5733
5734         PR gdb/23712
5735         PR symtab/23010
5736         * dictionary.c: Include unordered_map.
5737         (pending_to_vector): New function.
5738         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5739         Rewrite the non-"_1" functions to take vector instead
5740         of linked list.
5741         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5742         "new" _1 versions of the same name.
5743         (multidictionary): Define.
5744         (std::hash<enum language): New definition.
5745         (collate_pending_symbols_by_language, mdict_create_hashed)
5746         (mdict_create_hashed_expandable, mdict_create_linear)
5747         (mdict_create_linear_expandable, mdict_free)
5748         (find_language_dictionary, create_new_language_dictionary)
5749         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5750         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5751         (mdict_size, mdict_empty): New functions.
5752         * dictionary.h (mdict_iterator): Define.
5753
5754 2019-01-10  Pedro Alves  <palves@redhat.com>
5755
5756         * breakpoint.c (read_uploaded_action)
5757         (create_tracepoint_from_upload): Adjust to use
5758         gdb::unique_xmalloc_ptr.
5759         * ctf.c (ctf_write_uploaded_tp):
5760         (SET_ARRAY_FIELD): Use emplace_back.
5761         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5762         * tracefile-tfile.c (tfile_write_uploaded_tp):
5763         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5764         gdb::unique_xmalloc_ptr.
5765         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5766         at_string, cond_string, cmd_strings>: Replace char pointers
5767         with gdb::unique_xmalloc_ptr.
5768
5769 2019-01-10  Pedro Alves  <palves@redhat.com>
5770
5771         * solib-target.c (library_list_start_library): Don't xstrdup name.
5772
5773 2019-01-10  Pedro Alves  <palves@redhat.com>
5774
5775         * mdebugread.c (parse_partial_symbols): Use
5776         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5777
5778 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5779
5780         * linux-fork.c (scoped_switch_fork_info)
5781         <~scoped_switch_fork_info>: Fix incorrect variable name.
5782
5783 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5784
5785         * linux-fork.c (scoped_switch_fork_info)
5786         <scoped_switch_fork_info>: Make explicit.
5787         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5788
5789 2019-01-10  Tom Tromey  <tom@tromey.com>
5790
5791         * objfiles.h (objfile::reset_psymtabs): Update.
5792         * objfiles.c (objfile::objfile): Update.
5793         * psymtab.h (psymtab_storage::obstack): Update.
5794         (psymtab_storage::m_obstack): Use gdb::optional.
5795         (class psymtab_storage): Update comment.  Remove objfile
5796         parameter.
5797         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5798
5799 2019-01-10  Tom Tromey  <tom@tromey.com>
5800
5801         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5802         <free_psymtabs>: Now private.
5803         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5804         (allocate_psymtab): Use new method.
5805
5806 2019-01-10  Tom Tromey  <tom@tromey.com>
5807
5808         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5809         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5810         * mdebugread.c (parse_partial_symbols): Use
5811         allocate_dependencies.
5812         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5813         allocate_dependencies.
5814         (process_psymtab_comp_unit_reader)
5815         (build_type_psymtab_dependencies): Likewise.
5816         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5817
5818 2019-01-10  Tom Tromey  <tom@tromey.com>
5819
5820         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5821         PSYMBOL_SET_LANGUAGE.
5822         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5823
5824 2019-01-10  Tom Tromey  <tom@tromey.com>
5825
5826         * psymtab.h (psymtab_storage::obstack): New method.
5827         <m_obstack>: Rename from obstack; now private.
5828         * psymtab.c (psymtab_storage): Update.
5829         * dwarf2read.c (create_addrmap_from_index)
5830         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5831         Update.
5832
5833 2019-01-10  Tom Tromey  <tom@tromey.com>
5834
5835         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5836         * objfiles.h (objfile::reset_psymtabs): New method.
5837
5838 2019-01-10  Tom Tromey  <tom@tromey.com>
5839
5840         * symmisc.c (print_symbol_bcache_statistics): Update.
5841         (print_objfile_statistics): Update.
5842         * symfile.c (reread_symbols): Update.
5843         * psymtab.h (class psymtab_storage): New.
5844         * psymtab.c (psymtab_storage): New constructor.
5845         (~psymtab_storage): New destructor.
5846         (require_partial_symbols): Update.
5847         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5848         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5849         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5850         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5851         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5852         (start_psymtab_common, end_psymtab_common)
5853         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5854         (allocate_psymtab): Update.
5855         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5856         Update.
5857         (dump_psymtab_addrmap, maintenance_print_psymbols)
5858         (maintenance_check_psymtabs): Update.
5859         (class objfile_psymtabs): Move to objfiles.h.
5860         * psympriv.h (discard_psymtab): Now inline.
5861         (psymtab_discarder::psymtab_discarder): Update.
5862         (psymtab_discarder::~psymtab_discarder): Update.
5863         (ALL_OBJFILE_PSYMTABS): Rewrite.
5864         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5865         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5866         Remove fields.
5867         <partial_symtabs>: New field.
5868         (class objfile_psymtabs): Move from psymtab.h.  Update.
5869         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5870         psymbol_cache.
5871         (objfile::~objfile): Don't destroy psymbol_cache.
5872         * mdebugread.c (parse_partial_symbols): Update.
5873         * dwarf2read.c (create_addrmap_from_index)
5874         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5875         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5876         (add_partial_subprogram, dwarf2_ranges_read): Update.
5877         * dwarf-index-write.c (write_address_map)
5878         (write_one_signatured_type, recursively_write_psymbols)
5879         (class debug_names, class debug_names, write_psymtabs_to_index):
5880         Update.
5881
5882 2019-01-10  Tom Tromey  <tom@tromey.com>
5883
5884         * symtab.h (SYMBOL_SET_NAMES): Update.
5885         (symbol_set_names): Update.
5886         (MSYMBOL_SET_NAMES): Update.
5887         * symtab.c (symbol_set_names): Change argument to be an
5888         objfile_per_bfd_storage.
5889         * psymtab.c (add_psymbol_to_bcache): Update.
5890         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5891
5892 2019-01-10  Tom Tromey  <tom@tromey.com>
5893
5894         * symtab.c (create_demangled_names_hash): Change argument to be an
5895         objfile_per_bfd_storage.
5896         (symbol_set_names): Update.
5897
5898 2019-01-10  Tom Tromey  <tom@tromey.com>
5899
5900         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5901         init_psymbol_list.
5902         * psymtab.c (init_psymbol_list): Do nothing if already called.
5903         * psympriv.h (init_psymbol_list): Add comment.
5904         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5905         init_psymbol_list.
5906         * dbxread.c (dbx_symfile_read): Unconditionally call
5907         init_psymbol_list.
5908
5909 2019-01-10  Tom Tromey  <tom@tromey.com>
5910
5911         * xcoffread.c (scan_xcoff_symtab): Update.
5912         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5913         "where".
5914         * mdebugread.c (parse_partial_symbols)
5915         (handle_psymbol_enumerators): Update.
5916         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5917         * dbxread.c (read_dbx_symtab): Update.
5918         * psympriv.h (psymbol_placement): New enum.
5919         (add_psymbol_to_list): Update.
5920
5921 2019-01-10  Tom Tromey  <tom@tromey.com>
5922
5923         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5924         static_psymbols parameters.
5925         (scan_xcoff_symtab): Update.
5926         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5927         static_psymbols parameters.
5928         * psympriv.h (start_psymtab_common): Update.
5929         * mdebugread.c (parse_partial_symbols): Update.
5930         * dwarf2read.c (create_partial_symtab): Update.
5931         * dbxread.c (read_dbx_symtab): Update.
5932         (start_psymtab): Remove global_psymbols and static_psymbols
5933         parameters.
5934
5935 2019-01-10  Tom Tromey  <tom@tromey.com>
5936
5937         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5938         * psymtab.c (allocate_psymtab): Add comment.
5939         * psympriv.h (allocate_psymtab): Add comment.
5940         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5941         initializations.
5942         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5943
5944 2019-01-10  Tom Tromey  <tom@tromey.com>
5945
5946         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5947         Don't declare.
5948         * mipsread.c: Include mdebugread.h.
5949         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5950         Declare.
5951         * elfread.c: Include mdebugread.h.
5952
5953 2019-01-09  Tom Tromey  <tom@tromey.com>
5954
5955         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5956         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5957         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5958         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5959         (psym_lookup_symbol, psym_find_last_source_symtab)
5960         (psym_forget_cached_source_info, psym_print_stats)
5961         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5962         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5963         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5964         (psym_find_compunit_symtab_by_address)
5965         (maintenance_print_psymbols, maintenance_info_psymtabs)
5966         (maintenance_check_psymtabs): Use ranged for.
5967         * psymtab.h (class objfile_psymtabs): New.
5968         (require_partial_symbols): Return objfile_psymtabs.
5969         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5970
5971 2019-01-09  Tom Tromey  <tom@tromey.com>
5972
5973         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5974         (find_pc_mapped_section, list_overlays_command)
5975         (map_overlay_command, unmap_overlay_command)
5976         (simple_overlay_update): Use all_objfiles.
5977         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5978         * printcmd.c (info_symbol_command): Use all_objfiles.
5979         * objfiles.h (ALL_OBJSECTIONS): Remove.
5980         * maint.c (maintenance_translate_address): Use all_objfiles.
5981         * gcore.c (gcore_create_callback): Use all_objfiles.
5982         (objfile_find_memory_regions): Likewise.
5983
5984 2019-01-09  Tom Tromey  <tom@tromey.com>
5985
5986         * symtab.c (find_line_symtab, info_sources_command)
5987         (make_source_files_completion_list): Use objfile_compunits.
5988         * source.c (select_source_symtab): Use objfile_compunits.
5989         * objfiles.h (struct objfile): Update comment.
5990         (ALL_OBJFILES): Remove.
5991         (ALL_FILETABS): Remove.
5992         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5993         objfile_compunits.
5994
5995 2019-01-09  Tom Tromey  <tom@tromey.com>
5996
5997         * symmisc.c (print_objfile_statistics, dump_objfile)
5998         (maintenance_print_symbols): Use compunit_filetabs.
5999         * source.c (forget_cached_source_info_for_objfile): Use
6000         compunit_filetabs.
6001         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6002         (ALL_FILETABS): Use compunit_filetabs.
6003         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6004         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6005
6006 2019-01-09  Tom Tromey  <tom@tromey.com>
6007
6008         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6009         (compunit_filetabs): New.
6010         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6011         compunit_filetabs.
6012         (info_sources_command, make_source_files_completion_list): Remove
6013         declaration.
6014         * symmisc.c (print_objfile_statistics, dump_objfile)
6015         (maintenance_print_symbols): Remove declaration.
6016         (maintenance_info_symtabs): Use compunit_filetabs.
6017         (maintenance_info_line_tables): Likewise.
6018         * source.c (select_source_symtab): Change local variable name.
6019         (forget_cached_source_info_for_objfile): Remove declaration.
6020         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6021         * objfiles.c (objfile_relocate1): Remove declaration.
6022         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6023         declaration.
6024         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6025         * coffread.c (coff_symtab_read): Remove declaration.
6026         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6027         compunit_filetabs.
6028
6029 2019-01-09  Tom Tromey  <tom@tromey.com>
6030
6031         * symtab.c (lookup_objfile_from_block)
6032         (find_pc_sect_compunit_symtab, search_symbols)
6033         (default_collect_symbol_completion_matches_break_on): Use
6034         objfile_compunits.
6035         * objfiles.h (ALL_COMPUNITS): Remove.
6036         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6037         * cp-support.c (add_symbol_overload_list_qualified): Use
6038         objfile_compunits.
6039         * ada-lang.c (ada_collect_symbol_completion_matches)
6040         (ada_add_global_exceptions): Use objfile_compunits.
6041
6042 2019-01-09  Tom Tromey  <tom@tromey.com>
6043
6044         * source.c (select_source_symtab)
6045         (forget_cached_source_info_for_objfile): Remove declaration.
6046         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6047         declaration.
6048         * maint.c (count_symtabs_and_blocks): Remove declaration.
6049         * cp-support.c (add_symbol_overload_list_qualified): Remove
6050         declaration.
6051         * coffread.c (coff_symtab_read): Remove declaration.
6052         * symtab.c (lookup_symbol_in_objfile_symtabs)
6053         (basic_lookup_transparent_type_1): Use objfile_compunits.
6054         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6055         (info_sources_command, search_symbols)
6056         (default_collect_symbol_completion_matches_break_on)
6057         (make_source_files_completion_list): Remove declaration.
6058         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6059         (ada_collect_symbol_completion_matches)
6060         (ada_add_global_exceptions): Remove declaration.
6061         * linespec.c (iterate_over_all_matching_symtabs): Use
6062         objfile_compunits.
6063         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6064         (class objfile_compunits): New.
6065         (ALL_COMPUNITS): Use objfile_compunits.
6066         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6067         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6068         objfile_compunits.
6069         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6070
6071 2019-01-09  Tom Tromey  <tom@tromey.com>
6072
6073         * symtab.c (search_symbols)
6074         (default_collect_symbol_completion_matches_break_on): Use
6075         objfile_msymbols.
6076         * ada-lang.c (ada_lookup_simple_minsym)
6077         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6078         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6079         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6080         objfile_msymbols.
6081         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6082         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6083         * objc-lang.c (find_methods): Use objfile_msymbols.
6084         (info_selectors_command, info_classes_command): Likewise.
6085         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6086         * objfiles.h (class objfile_msymbols): New.
6087         (ALL_OBJFILE_MSYMBOLS): Remove.
6088         (ALL_MSYMBOLS): Remove.
6089
6090 2019-01-09  Tom Tromey  <tom@tromey.com>
6091
6092         * common/next-iterator.h (next_adapter): Add Iterator template
6093         parameter.
6094         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6095         (class all_objfiles_safe): New.
6096         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6097         * objfiles.c (put_objfile_before): Update comment.
6098         (add_separate_debug_objfile): Likewise.
6099         (free_all_objfiles): Use all_objfiles_safe.
6100         (objfile_purge_solibs): Likewise.
6101
6102 2019-01-09  Tom Tromey  <tom@tromey.com>
6103
6104         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6105         (expand_symtab_containing_pc, lookup_static_symbol)
6106         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6107         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6108         all_objfiles.
6109         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6110         * breakpoint.c (create_overlay_event_breakpoint)
6111         (create_longjmp_master_breakpoint)
6112         (create_std_terminate_master_breakpoint)
6113         (create_exception_master_breakpoint): Use all_objfiles.
6114         * linux-thread-db.c (try_thread_db_load_from_pdir)
6115         (has_libpthread): Use all_objfiles.
6116         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6117         * linespec.c (iterate_over_all_matching_symtabs)
6118         (search_minsyms_for_name): Use all_objfiles.
6119         * maint.c (maintenance_info_sections): Use all_objfiles.
6120         * main.c (captured_main_1): Use all_objfiles.
6121         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6122         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6123         * guile/scm-pretty-print.c
6124         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6125         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6126         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6127         (maintenance_print_msymbols): Use all_objfiles.
6128         * source.c (select_source_symtab): Use all_objfiles.
6129         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6130         * symfile.c (remove_symbol_file_command)
6131         (expand_symtabs_matching, map_symbol_filenames): Use
6132         all_objfiles.
6133         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6134         all_objfiles.
6135         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6136         * objc-lang.c (find_methods): Use all_objfiles.
6137         * objfiles.c (have_partial_symbols, have_full_symbols)
6138         (have_minimal_symbols, qsort_cmp)
6139         (default_iterate_over_objfiles_in_search_order): Use
6140         all_objfiles.
6141         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6142         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6143         (maintenance_check_psymtabs): Use all_objfiles.
6144         (ALL_PSYMTABS): Remove.
6145         * compile/compile-object-run.c (do_module_cleanup): Use
6146         all_objfiles.
6147         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6148         * cp-support.c (add_symbol_overload_list_qualified): Use
6149         all_objfiles.
6150         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6151         Use all_objfiles.
6152         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6153         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6154         all_objfiles.
6155         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6156         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6157         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6158         Uses all_objfiles.
6159         * solib.c (solib_read_symbols): Use all_objfiles
6160
6161 2019-01-09  Tom Tromey  <tom@tromey.com>
6162
6163         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6164         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6165         all_objfiles.
6166         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6167         * symmisc.c (print_symbol_bcache_statistics)
6168         (print_objfile_statistics, maintenance_print_objfiles)
6169         (maintenance_info_symtabs, maintenance_check_symtabs)
6170         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6171         all_objfiles.
6172         * source.c (forget_cached_source_info): Use all_objfiles.
6173         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6174         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6175         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6176         * objfiles.c (update_section_map): Use all_objfiles.
6177         (shared_objfile_contains_address_p): Likewise.
6178         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6179         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6180
6181 2019-01-09  Tom Tromey  <tom@tromey.com>
6182
6183         * common/next-iterator.h: New file.
6184         * objfiles.h (class all_objfiles): New.
6185         (struct objfile_iterator): New.
6186
6187 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6188
6189         * NEWS: Move the description of the changed "frame", "select-frame",
6190          and "info frame" commands to the Changed commands section.
6191
6192 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6193
6194         * gdbtypes.c (check_stub_method_group): Remove handling of old
6195         mangling schemes.
6196         * linespec.c (find_methods): Likewise.
6197         * stabsread.c (read_member_functions): Likewise.
6198         * valops.c (search_struct_method): Likewise.
6199         (value_struct_elt_for_reference): Likewise.
6200         * NEWS: Mention this change.
6201
6202 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6203
6204         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6205         print_source_lines.
6206         * source.c (print_source_lines_base): Update line number check.
6207         (print_source_lines): New function.
6208         (source_lines_range::source_lines_range): New function.
6209         * source.h (class source_lines_range): New class.
6210         (print_source_lines): New declaration.
6211
6212 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6213
6214         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6215
6216 2019-01-08  Tom Tromey  <tom@tromey.com>
6217             Simon Marchi  <simon.marchi@ericsson.com>
6218
6219         PR gdb/24060
6220         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6221         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6222         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6223         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6224         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6225         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6226
6227 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6228
6229         * source.c (select_source_symtab): Move header comment to
6230         declaration in source.h.
6231         (forget_cached_source_info_for_objfile): Likewise.
6232         (forget_cached_source_info): Likewise.
6233         (identify_source_line): Likewise.
6234         * source.h (identify_source_line): Move declaration from symtab.h
6235         and add comment from source.c
6236         (print_source_lines): Likewise.
6237         (forget_cached_source_info_for_objfile): Likewise.
6238         (forget_cached_source_info): Likewise.
6239         (select_source_symtab): Likewise.
6240         (enum print_source_lines_flag): Move definition from symtab.h.
6241         * symtab.h (identify_source_line): Move declaration to source.h.
6242         (print_source_lines): Likewise.
6243         (forget_cached_source_info_for_objfile): Likewise.
6244         (forget_cached_source_info): Likewise.
6245         (select_source_symtab): Likewise.
6246         (enum print_source_lines_flag): Move definition to source.h.
6247         * tui/tui-hooks.c: Add 'source.h' include.
6248
6249 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6250
6251         * source.c (print_source_lines_base): Handle requests to print
6252         reverse line number sequences, and guard against empty lines
6253         string.
6254
6255 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6256
6257         * source.c (print_source_lines_base): Fix skip of '\r' if next
6258         character is '\n'.
6259
6260 2019-01-06  Tom Tromey  <tom@tromey.com>
6261
6262         * c-exp.y (struct c_parse_state) <macro_original_text,
6263         expansion_obstack>: New member.
6264         (macro_original_text, expansion_obstack): Remove globals.
6265         (scan_macro_expansion, scanning_macro_expansion)
6266         (finished_macro_expansion): Update.
6267         (scan_macro_cleanup): Remove.
6268         (yylex, c_parse): Update.
6269
6270 2019-01-06  Tom Tromey  <tom@tromey.com>
6271
6272         * c-exp.y (struct c_parse_state) <strings>: New member.
6273         (operator_stoken): Update.
6274
6275 2019-01-06  Tom Tromey  <tom@tromey.com>
6276
6277         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6278         (union type_stack_elt) <typelist_val>: Now a pointer to
6279         std::vector.
6280         (type_stack_cleanup): Don't declare.
6281         (push_typelist): Update.
6282         * parse.c (pop_typelist): Return a std::vector.
6283         (push_typelist): Take a std::vector.
6284         (follow_types): Update.  Do not free args.
6285         (type_stack_cleanup): Remove.
6286         * c-exp.y (struct c_parse_state): New.
6287         (cpstate): New global.
6288         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6289         (nonempty_typelist): Update.
6290         (func_mod): Create a new vector.
6291         (c_parse): Create a c_parse_state.
6292         (check_parameter_typelist): Do not delete params.
6293         (function_method): Update.  Do not delete type_list.
6294
6295 2019-01-06  Tom Tromey  <tom@tromey.com>
6296
6297         PR gdb/28155:
6298         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6299         check_typedef.
6300         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6301         (print_return_value): Likewise.
6302
6303 2019-01-05  Tom Tromey  <tom@tromey.com>
6304
6305         * contrib/cleanup_check.py: Remove.
6306         * contrib/gcc-with-excheck: Remove.
6307         * contrib/exsummary.py: Remove.
6308         * contrib/excheck.py: Remove.
6309
6310 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6311
6312         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6313         NULL. Initialize tpprev to NULL instead of assigning it
6314         to NULL on the next statement.
6315         * windows-nat.c (windows_delete_thread): Remove check for
6316         main_thread_id before printing thread exit notifications.
6317         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6318         Remove thread ID check against main_thread_id.
6319         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6320         windows_delete_thread.
6321         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6322
6323 2019-01-04  Tom Tromey  <tom@tromey.com>
6324
6325         * compile/compile.c (_initialize_compile): Use upper case for
6326         metasyntactic variables.
6327         * symmisc.c (_initialize_symmisc): Use upper case for
6328         metasyntactic variables.
6329         * psymtab.c (_initialize_psymtab): Use upper case for
6330         metasyntactic variables.
6331         * demangle.c (demangle_command): Use upper case for metasyntactic
6332         variables.
6333         (_initialize_demangler): Likewise.
6334         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6335         variables.
6336
6337 2019-01-03  Tom Tromey  <tom@tromey.com>
6338
6339         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6340
6341 2019-01-03  Tom Tromey  <tom@tromey.com>
6342
6343         * python/py-symtab.c (salpy_str): Update.
6344         (struct salpy_sal_object) <symtab>: Now a PyObject.
6345         (salpy_dealloc): Update.
6346         (del_objfile_sal): Use gdbpy_ref.
6347
6348 2019-01-03  Tom Tromey  <tom@tromey.com>
6349
6350         * python/py-type.c (convert_field): Use new_reference.  Return
6351         gdbpy_ref.
6352         (make_fielditem): Return gdbpy_ref.
6353         (typy_fields): Update.
6354         (typy_getitem): Update.
6355         (field_name): Return gdbpy_ref.  Use new_reference.
6356         (typy_iterator_iternext): Update.
6357
6358 2019-01-03  Tom Tromey  <tom@tromey.com>
6359
6360         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6361
6362 2019-01-03  Tom Tromey  <tom@tromey.com>
6363
6364         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6365         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6366         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6367         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6368         (pspy_set_type_printers): Likewise.
6369         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6370         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6371         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6372         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6373         (objfpy_set_type_printers): Likewise.
6374
6375 2019-01-03  Tom Tromey  <tom@tromey.com>
6376
6377         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6378         (gdbpy_print_stack): Use gdbpy_err_fetch.
6379         * python/python-internal.h (class gdbpy_err_fetch): New class.
6380         (class gdbpy_enter) <m_error_type, m_error_value,
6381         m_error_traceback>: Remove.
6382         <m_error>: New member.
6383         (gdbpy_exception_to_string): Don't declare.
6384         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6385         * python/py-value.c (convert_value_from_python): Use
6386         gdbpy_err_fetch.
6387         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6388         gdbpy_exception_to_string.
6389         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6390         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6391         gdbpy_err_fetch.
6392
6393 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6394
6395         * linux-nat.c (delete_lwp_cleanup): Delete.
6396         (struct lwp_deleter): New struct.
6397         (lwp_info_up): New typedef.
6398         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6399         lwp_info_up.
6400
6401 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6402
6403         * linux-fork.c (class scoped_switch_fork_info): New class.
6404         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6405
6406 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6407
6408         * valops.c (find_overload_match): Remove use of null_cleanup, and
6409         calls to do_cleanups.
6410
6411 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6412
6413         * compile/compile-cplus-types.c
6414         (compile_cplus_instance::decl_name): Handle changes to
6415         cp_func_name.
6416         * cp-support.c (cp_func_name): Update header comment, update
6417         return type.
6418         * cp-support.h (cp_func_name): Update return type in declaration.
6419         * valops.c (find_overload_match): Move temp_func local to top
6420         level of function and change its type.  Use temp_func to hold and
6421         delete temporary string obtained from cp_func_name.
6422
6423 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6424
6425         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6426         gdb::char_vector, remove cleanup, and update uses of `msg`.
6427
6428 2019-01-03  Jim Wilson  <jimw@sifive.com>
6429
6430         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6431
6432 2019-01-02  Tom Tromey  <tom@tromey.com>
6433
6434         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6435         (tdesc_parse_xml): Remove cleanups.
6436         * target-descriptions.h (make_cleanup_free_target_description):
6437         Don't declare.
6438         (target_desc_deleter): New struct.
6439         (target_desc_up): New typedef.
6440         * target-descriptions.c (target_desc_deleter::operator()): Rename
6441         from free_target_description.
6442         (make_cleanup_free_target_description): Remove.
6443
6444 2019-01-02  Tom Tromey  <tom@tromey.com>
6445
6446         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6447         constructor, destructor.
6448         (linespec_parser): Remove typedef.
6449         (~linespec_parser): Rename from linespec_parser_delete.
6450         (linespec_lex_to_end, linespec_complete_label)
6451         (linespec_complete): Update.
6452         (decode_line_full): Remove cleanups.
6453         (decode_line_1): Update.
6454
6455 2019-01-02  Tom Tromey  <tom@tromey.com>
6456
6457         * python/python-internal.h (inferior_to_inferior_object): Change
6458         return type.
6459         * python/py-exitedevent.c (create_exited_event_object): Update.
6460         * python/py-inferior.c (inferior_to_inferior_object): Return
6461         gdbpy_ref.
6462         (python_new_inferior, python_inferior_deleted)
6463         (thread_to_thread_object, delete_thread_object)
6464         (build_inferior_list, gdbpy_selected_inferior): Update.
6465         * python/py-infthread.c (create_thread_object): Update.  Also fail
6466         if inferior_to_inferior_object fails.
6467
6468 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6469
6470         * inferior.h (class inferior) <displaced_step_state>: New field.
6471         * infrun.h (struct displaced_step_state): Move here from
6472         infrun.c.  Initialize fields, add constructor.
6473         <inf>: Remove field.
6474         <reset>: New method.
6475         * infrun.c (struct displaced_step_inferior_state): Move to
6476         infrun.h.
6477         (displaced_step_inferior_states): Remove.
6478         (get_displaced_stepping_state): Adust.
6479         (displaced_step_in_progress_any_inferior): Adjust.
6480         (displaced_step_in_progress_thread): Adjust.
6481         (displaced_step_in_progress): Adjust.
6482         (add_displaced_stepping_state): Remove.
6483         (get_displaced_step_closure_by_addr): Adjust.
6484         (remove_displaced_stepping_state): Remove.
6485         (infrun_inferior_exit): Call displaced_step_state.reset.
6486         (use_displaced_stepping): Don't check for NULL.
6487         (displaced_step_prepare_throw): Call
6488         get_displaced_stepping_state.
6489         (displaced_step_fixup): Don't check for NULL.
6490         (prepare_for_detach): Don't check for NULL.
6491
6492 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6493
6494         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6495          in case of call that did not complete.
6496
6497 2019-01-02  Andrey Utkin  <autkin@undo.io>
6498
6499         * symfile.c (find_separate_debug_file): Fix search of debug files for
6500         remote debuggee.
6501
6502 2019-01-02  Tom Tromey  <tom@tromey.com>
6503
6504         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6505         indentation.
6506         * python/py-frame.c (frapy_older): Remove cast.
6507         (frapy_newer): Likewise.
6508         * python/py-breakpoint.c (local_setattro): Remove cast.
6509         * python/py-arch.c (archpy_name): Remove local variable.
6510         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6511
6512 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6513
6514         * unittests/basic_string_view/element_access/char/empty.cc:
6515         Fix year range in copyright header.
6516
6517 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6518
6519         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6520         Delete.
6521         <operator==>: Update with for removed field.
6522         <hash>: Likewise.
6523         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6524         <isa_features>: ...this.
6525         <abi_features>: New field.
6526         (riscv_isa_flen): Update comment.
6527         (riscv_abi_xlen): New declaration.
6528         (riscv_abi_flen): New declaration.
6529         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6530         isa_features.
6531         (riscv_abi_xlen): New function.
6532         (riscv_isa_flen): Update to get answer from isa_features.
6533         (riscv_abi_flen): New function.
6534         (riscv_has_fp_abi): Update to get answer from abi_features.
6535         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6536         xlen and flen.
6537         (riscv_call_info) <xlen, flen>: Update comment.
6538         (riscv_call_arg_struct): Remove invalid assertions
6539         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6540         is removed.
6541         (riscv_gdbarch_init): Gather isa features and abi features
6542         separately, ensure both match on the gdbarch when reusing an old
6543         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6544         a target with 64-bit float hardware.
6545
6546 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6547
6548         * source.c (search_command_helper): Stop reverse search
6549         when line 1 has been searched.
6550
6551 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6552
6553         * record-full.c (record_full_base_target::close): Rewrite
6554         record_full_core_buf_list free logic.
6555
6556 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6557
6558         * break-catch-syscall.c (print_one_catch_syscall): xfree
6559         the last text.
6560
6561 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6562
6563         * top.c (print_gdb_version): Update Copyright year in version
6564         message.
6565
6566 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6567
6568         Update copyright year range in all GDB files.
6569
6570 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6571
6572         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6573
6574 For older changes see ChangeLog-2018.
6575 \f
6576 Local Variables:
6577 mode: change-log
6578 left-margin: 8
6579 fill-column: 74
6580 version-control: never
6581 coding: utf-8
6582 End:
6583