gdb/ChangeLog

   1 2019-11-28  Tom Tromey  <tom@tromey.com>
   2
   3         * value.c (creal_internal_fn): Fix comment.
   4
   5 2019-11-28  Tom Tromey  <tom@tromey.com>
   6
   7         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
   8         flag_bound_evaluated>: Now unsigned.
   9
  10 2019-11-28  Tom Tromey  <tom@tromey.com>
  11
  12         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
  13         declare.
  14
  15 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
  16
  17         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
  18         debug output.
  19         * jit.c (jit_unregister_code): Add debug print to match
  20         `jit_register_code`.
  21
  22 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  23
  24         * NEWS: Mention the new multithreaded symbol loading.
  25
  26 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  27
  28         * maint.c (n_worker_threads): Default to 0.
  29         (worker_threads_disabled): New function.
  30         * maint.h (worker_threads_disabled): New function.
  31         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
  32         here if worker_threads_disabled () is true.
  33         (minimal_symbol_reader::install): Skip all threading if
  34         worker_threads_disabled () is true.
  35
  36 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  37
  38         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
  39         hash code if possible.
  40         (add_minsym_to_demangled_hash_table): Likewise.
  41         (minimal_symbol_reader::install): Compute the hash codes for msymbol
  42         on the background thread.
  43         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
  44         Add these fields.
  45
  46 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  47
  48         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
  49         of the mangled name on the background thread.
  50         * symtab.c (symbol_set_names): Allow passing in the hash of the
  51         linkage_name.
  52         * symtab.h (symbol_set_names): Likewise.
  53
  54 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
  55
  56         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
  57         physnames are computed for inherited DIEs.
  58
  59 2019-11-27  Tom Tromey  <tromey@adacore.com>
  60
  61         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
  62         backslashes.
  63         * cp-support.c: Remove unnecessary backslashes.
  64
  65 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
  66
  67         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
  68         with sym->set_linkage_name.
  69         * coffread.c (coff_read_enum_type): Likewise.
  70         * mdebugread.c (parse_symbol): Likewise.
  71         * stabsread.c (patch_block_stabs): Likewise.
  72         (define_symbol): Likewise.
  73         (read_enum_type): Likewise.
  74         (common_block_end): Likewise.
  75         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
  76         function.
  77         (SYMBOL_SET_LINKAGE_NAME): Remove.
  78         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
  79         with sym->set_linkage_name.
  80
  81 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  82
  83         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
  84         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
  85         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
  86         * NEWS: Mention new MI command.
  87
  88 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  89
  90         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
  91         '-symbol-info-types', and '-symbol-info-variables'.
  92         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
  93         (mi_cmd_symbol_info_types): Declare.
  94         (mi_cmd_symbol_info_variables): Declare.
  95         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
  96         (output_debug_symbol): New function.
  97         (output_nondebug_symbol): New function.
  98         (mi_symbol_info): New function.
  99         (mi_info_functions_or_variables): New function.
 100         (mi_cmd_symbol_info_functions): New function.
 101         (mi_cmd_symbol_info_types): New function.
 102         (mi_cmd_symbol_info_variables): New function.
 103         * NEWS: Mention new commands.
 104
 105 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 106
 107         * symtab.c (symbol_to_info_string): New function, most content
 108         moved from print_symbol_info, but updated to return a std::string.
 109         (print_symbol_info): Update to use symbol_to_info_string and print
 110         returned string.
 111         * symtab.h (symbol_to_info_string): Declare new function.
 112
 113 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 114
 115         * python/python.c (gdbpy_rbreak): Convert to using
 116         global_symbol_searcher.
 117         * symtab.c (file_matches): Convert return type to bool, change
 118         file list to std::vector, update header comment.
 119         (search_symbols): Rename to...
 120         (global_symbol_searcher::search): ...this and update now its
 121         a member function of global_symbol_searcher.  Take account of the
 122         changes to file_matches.
 123         (symtab_symbol_info): Convert to using global_symbol_searcher.
 124         (rbreak_command): Likewise.
 125         (search_module_symbols): Likewise.
 126         * symtab.h (enum symbol_search): Update comment.
 127         (search_symbols): Remove declaration.
 128         (class global_symbol_searcher): New class.
 129
 130 2019-11-26  Tom Tromey  <tromey@adacore.com>
 131
 132         * cp-support.c (_initialize_cp_support): Conditionally initialize
 133         gdb_demangle_attempt_core_dump.
 134
 135 2019-11-26  Tom Tromey  <tom@tromey.com>
 136
 137         * python/py-function.c (fnpy_init): Update.
 138         * value.h (add_internal_function): Adjust declaration.
 139         * value.c (function_destroyer): Remove.
 140         (do_add_internal_function): Don't set destroyer or copy name.
 141         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 142         Set name_allocated.
 143         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 144         (cmdpy_init): Set name_allocated.
 145         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 146         member.
 147         (~cmd_list_element): Free "name" if needed.
 148
 149 2019-11-26  Tom Tromey  <tom@tromey.com>
 150
 151         * value.h (add_internal_function): Add new overload.  Move
 152         documentation from value.h.
 153         * value.c (do_add_internal_function): New function.
 154         (add_internal_function): Use it.  Add new overload.
 155         (function_destroyer): Don't free doc.
 156         * python/py-function.c (fnpy_init): Update.
 157
 158 2019-11-26  Tom Tromey  <tom@tromey.com>
 159
 160         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 161         (cmdpy_init): Set "doc_allocated".
 162
 163 2019-11-26  Tom Tromey  <tom@tromey.com>
 164
 165         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 166         name of worker thread.
 167         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 168         pthread_setname_np.
 169         * configure, config.in: Rebuild.
 170
 171 2019-11-26  Tom Tromey  <tom@tromey.com>
 172
 173         * python/python.c (class gdbpy_gil): New.
 174         (struct gdbpy_event): Add constructor, destructor, operator().
 175         (gdbpy_post_event): Use run_on_main_thread.
 176         (gdbpy_initialize_events): Remove.
 177         (do_start_initialization): Update.
 178
 179 2019-11-26  Tom Tromey  <tom@tromey.com>
 180
 181         * NEWS: Add entry.
 182         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 183         commands.  Call update_thread_pool_size.
 184         (update_thread_pool_size, maintenance_set_worker_threads): New
 185         functions.
 186         (n_worker_threads): New global.
 187
 188 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 189             Tom Tromey  <tom@tromey.com>
 190
 191         * minsyms.c (minimal_symbol_reader::install): Use
 192         parallel_for_each.
 193         * gdbsupport/parallel-for.h: New file.
 194         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 195
 196 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 197             Tom Tromey  <tom@tromey.com>
 198
 199         * gdbsupport/thread-pool.h: New file.
 200         * gdbsupport/thread-pool.c: New file.
 201         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 202         (HFILES_NO_SRCDIR): Add thread-pool.h.
 203
 204 2019-11-26  Tom Tromey  <tom@tromey.com>
 205
 206         * event-top.h (thread_local_segv_handler): Declare.
 207         * event-top.c (thread_local_segv_handler): New global.
 208         (install_handle_sigsegv, handle_sigsegv): New functions.
 209         (async_init_signals): Install SIGSEGV handler.
 210         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 211         thread-local.
 212         (report_failed_demangle): New function.
 213         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 214         handler-setting code, instead use segv_handler.  Run warning code
 215         on main thread.
 216
 217 2019-11-26  Tom Tromey  <tom@tromey.com>
 218
 219         * run-on-main-thread.c: New file.
 220         * run-on-main-thread.h: New file.
 221         * unittests/main-thread-selftests.c: New file.
 222         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 223         main-thread-selftests.c.
 224         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 225         (COMMON_SFILES): Add run-on-main-thread.c.
 226
 227 2019-11-26  Tom Tromey  <tom@tromey.com>
 228
 229         * main.c (setup_alternate_signal_stack): Remove.
 230         (captured_main_1): Use gdb::alternate_signal_stack.
 231         * gdbsupport/alt-stack.h: New file.
 232
 233 2019-11-26  Tom Tromey  <tom@tromey.com>
 234
 235         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 236         Remove comment.
 237         (save_original_signals_state, restore_original_signals_state): Use
 238         gdb_sigmask.
 239         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 240         (_initialize_linux_nat): Use gdb_sigmask.
 241         * guile/guile.c (_initialize_guile): Use block_signals.
 242         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 243         * gdbsupport/gdb-sigmask.h: New file.
 244         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 245         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 246         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 247         pthread_sigmask.
 248         * configure, config.in: Rebuild.
 249         * gdbsupport/block-signals.h: New file.
 250
 251 2019-11-26  Tom Tromey  <tom@tromey.com>
 252
 253         * acinclude.m4: Include ax_pthread.m4.
 254         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 255         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 256         (CLIBS): Use PTHREAD_LIBS.
 257         (aclocal_m4_deps): Add ax_pthread.m4.
 258         * config.in, configure: Rebuild.
 259         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 260
 261 2019-11-26  Tom Tromey  <tom@tromey.com>
 262
 263         * symtab.h (struct minimal_symbol) <name_set>: New member.
 264         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 265         Don't call symbol_set_names.
 266         (minimal_symbol_reader::install): Call symbol_set_names.
 267
 268 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 269
 270         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 271         restore_active_ext_lang, as GIL is needed for (indirectly)
 272         called PyOS_InterruptOccurred.
 273
 274 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 275
 276         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 277         definition.
 278
 279 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 280
 281         * remote-sim.c (simulator_command): Make static, remove
 282         declaration.
 283
 284 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 285
 286         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 287         static.
 288         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 289         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 290         (main): Likewise.
 291         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 292         (main): Likewise.
 293         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 294         (main): Likewise.
 295         * unittests/basic_string_view/element_access/char/1.cc (test01):
 296         Likewise.
 297         (main): Likewise.
 298         * unittests/basic_string_view/element_access/char/empty.cc (main):
 299         Likewise.
 300         * unittests/basic_string_view/element_access/char/front_back.cc
 301         (test01): Likewise.
 302         (main): Likewise.
 303         * unittests/basic_string_view/inserters/char/2.cc (test05):
 304         Likewise.
 305         (main): Likewise.
 306         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 307         (test01): Likewise.
 308         (main): Likewise.
 309         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 310         (test01): Likewise.
 311         (main): Likewise.
 312         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 313         Likewise.
 314         * unittests/basic_string_view/operations/compare/char/1.cc
 315         (test01): Likewise.
 316         (main): Likewise.
 317         * unittests/basic_string_view/operations/compare/char/13650.cc
 318         (test01): Likewise.
 319         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 320         Likewise.
 321         (main): Likewise.
 322         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 323         Likewise.
 324         (main): Likewise.
 325         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 326         Likewise.
 327         (main): Likewise.
 328         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 329         Likewise.
 330         (main): Likewise.
 331         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 332         Likewise.
 333         (main): Likewise.
 334         * unittests/basic_string_view/operations/find/char/4.cc (main):
 335         Likewise.
 336         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 337         Likewise.
 338         (main): Likewise.
 339         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 340         Likewise.
 341         (main): Likewise.
 342         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 343         Likewise.
 344         (main): Likewise.
 345         * unittests/basic_string_view/operations/substr/char/1.cc
 346         (test01): Likewise.
 347         (main): Likewise.
 348         * unittests/basic_string_view/operators/char/2.cc (main):
 349         Likewise.
 350         * unittests/optional/assignment/1.cc (test): Likewise.
 351         * unittests/optional/assignment/2.cc (test): Likewise.
 352         * unittests/optional/assignment/3.cc (test): Likewise.
 353         * unittests/optional/assignment/4.cc (test): Likewise.
 354         * unittests/optional/assignment/5.cc (test): Likewise.
 355         * unittests/optional/assignment/6.cc (test): Likewise.
 356         * unittests/optional/assignment/7.cc (test): Likewise.
 357         * unittests/optional/cons/copy.cc (test): Likewise.
 358         * unittests/optional/cons/default.cc (test): Likewise.
 359         * unittests/optional/cons/move.cc (test): Likewise.
 360         * unittests/optional/cons/value.cc (test): Likewise.
 361         * unittests/optional/in_place.cc (test): Likewise.
 362         * unittests/optional/observers/1.cc (test): Likewise.
 363         * unittests/optional/observers/2.cc (test): Likewise.
 364
 365 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 366
 367         * tui-win.h (tui_set_var_cmd): Remove.
 368         * tui-win.c (tui_set_var_cmd): Make static.
 369
 370 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 371
 372         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 373         rbreak_command_wrapper): Remove.
 374         * symtab.c (rbreak_command_wrapper): Remove.
 375
 376 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 377
 378         * inferior.h (info_terminal_command): Remove declaration.
 379         * inflow.c (info_terminal_command): Make static.
 380
 381 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 382
 383         * inferior.c (exit_inferior_silent): Remove.
 384
 385 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 386
 387         * dictionary.c (dict_empty, mdict_empty): Remove.
 388         * dictionary.c (mdict_empty): Remove.
 389
 390 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 391
 392          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 393          (arc_insn_get_memory_offset): Likewise.
 394          (arc_insn_dump): Likewise.
 395          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 396          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 397          * dictionary.c (dict_iterator_next): Likewise.
 398          (dict_iter_match_first): Likewise.
 399          (dict_iter_match_next): Likewise.
 400          * f-lang.c (evaluate_subexp_f): Likewise.
 401          * hppa-tdep.c (hppa_read_pc): Likewise.
 402          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 403          * parse.c (write_exp_elt_msym): Likewise.
 404          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 405          * remote.c (remote_packet_size): Likewise.
 406          (remote_notif_stop_parse): Likewise.
 407          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 408          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 409          * source.c (prepare_path_for_appending): Likewise.
 410          * sparc64-linux-tdep.c
 411          (sparc64_linux_handle_segmentation_fault); Likewise.
 412          * stack.c (frame_selection_by_function_completer): Likewise.
 413
 414 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 415
 416         * completer.c (set_gdb_completion_word_break_characters):
 417         Remove.
 418
 419 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 420
 421         * dwarf-index-write.c: Include dwarf-index-write.h.
 422         * mi/mi-interp.c: Include mi/mi-interp.h.
 423
 424 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 425
 426         * aarch32-tdep.c: Include aarch32-tdep.h.
 427         * aarch32-tdep.h: Forward-declare struct target_desc.
 428
 429 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 430
 431         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 432         strerror.
 433         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 434         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 435
 436 2019-11-25  Tom de Vries  <tdevries@suse.de>
 437
 438         * contrib/words.sh: Add -c option.
 439
 440 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
 441
 442         * solib.c (solib_find_1): Change int to bool.
 443         (exec_file_find): Change int to bool.
 444         (solib_find): Change int to bool.
 445         (solib_read_symbols): Change int to bool.
 446         (solib_used): Change int to bool.
 447         (solib_add): Change int to bool.
 448         (info_sharedlibrary_command): Change int to bool.
 449         (solib_contains_address_p): Change int to bool.
 450         (solib_keep_data_in_core): Change int to bool.
 451         (in_solib_dynsym_resolve_code): Change int to bool.
 452         (reload_shared_libraries_1): Change int to bool.
 453         (gdb_sysroot_changed): Change int to bool.
 454         * solib.h (solib_read_symbols): Change int to bool.
 455         (solib_contains_address_p): Change int to bool.
 456         (solib_keep_data_in_core): Change int to bool.
 457         (in_solib_dynsym_resolve_code): Change int to bool.
 458         (libpthread_name_p): Change int to bool.
 459
 460 2019-11-25  Luis Machado  <luis.machado@linaro.org>
 461
 462         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
 463         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
 464         (remote_packet_max_chars): New static global.
 465         (show_remote_packet_max_chars): New function.
 466         (remote_target::putpkt_binary): Adjust to use new
 467         remote_packet_max_chars option.
 468         (remote_target::getpkt_or_notif_sane_1): Likewise.
 469         (_initialize_remote): Register new remote-packet-max-chars option.
 470
 471 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
 472
 473         * m68k-linux-nat.c: Include gdbarch.h.
 474
 475 2019-11-24  Tom Tromey  <tom@tromey.com>
 476
 477         * symfile.c (read_symbols): Update.
 478         * psymtab.c (require_partial_symbols): Change type of "verbose" to
 479         bool.
 480         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 481         (psym_lookup_symbol, psym_find_last_source_symtab)
 482         (psym_forget_cached_source_info, psym_print_stats)
 483         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 484         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 485         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 486         (psym_find_compunit_symtab_by_address)
 487         (maintenance_print_psymbols, maintenance_info_psymtabs)
 488         (maintenance_check_psymtabs): Update.
 489         * psymtab.h (require_partial_symbols): Change type of "verbose" to
 490         bool.
 491
 492 2019-11-22  Tom Tromey  <tom@tromey.com>
 493
 494         * observable.h: Update comments.
 495
 496 2019-11-22  Tom Tromey  <tromey@adacore.com>
 497
 498         * ada-tasks.c (ada_task_is_alive): Make parameter const.
 499         (print_ada_task_info): Don't try to fetch thread id if task is not
 500         alive.
 501
 502 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 503
 504         * ada-exp.y: Update.
 505         * ada-lang.c (sort_choices): Update.
 506         (ada_print_symbol_signature): Update.
 507         (resolve_subexp): Update.
 508         (ada_parse_renaming): Update.
 509         (ada_read_renaming_var_value): Update.
 510         (lesseq_defined_than): Update.
 511         (remove_extra_symbols): Update.
 512         (remove_irrelevant_renamings): Update.
 513         (ada_add_block_symbols): Update.
 514         (ada_collect_symbol_completion_matches): Update.
 515         (ada_is_renaming_symbol): Update.
 516         (aggregate_assign_from_choices): Update.
 517         (ada_evaluate_subexp): Update.
 518         (ada_has_this_exception_support): Update.
 519         (ada_is_non_standard_exception_sym): Update.
 520         (ada_add_exceptions_from_frame): Update.
 521         (ada_add_global_exceptions): Update.
 522         (ada_print_subexp): Update.
 523         * ax-gdb.c (gen_var_ref): Update.
 524         (gen_maybe_namespace_elt): Update.
 525         (gen_expr_for_cast): Update.
 526         (gen_expr): Update.
 527         * block.h: Update.
 528         * blockframe.c (find_pc_partial_function): Update.
 529         * breakpoint.c (print_breakpoint_location): Update.
 530         (update_static_tracepoint): Update.
 531         * btrace.c (ftrace_print_function_name): Update.
 532         (ftrace_function_switched): Update.
 533         * buildsym.c (find_symbol_in_list): Update.
 534         * c-exp.y: Update.
 535         * c-typeprint.c (c_print_typedef): Update.
 536         (c_type_print_template_args): Update.
 537         * cli/cli-cmds.c (edit_command): Update.
 538         (list_command): Update.
 539         (print_sal_location): Update.
 540         * coffread.c (patch_opaque_types): Update.
 541         (process_coff_symbol): Update.
 542         (coff_read_enum_type): Update.
 543         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
 544         (convert_one_symbol): Update.
 545         (hash_symname): Update.
 546         (eq_symname): Update.
 547         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
 548         * compile/compile-cplus-types.c (debug_print_scope): Update.
 549         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 550         * compile/compile-object-load.c (get_out_value_type): Update.
 551         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
 552         (search_symbol_list): Update.
 553         (cp_lookup_symbol_imports_or_template): Update.
 554         * cp-support.c (overload_list_add_symbol): Update.
 555         * ctfread.c (psymtab_to_symtab): Update.
 556         * dbxread.c (cp_set_block_scope): Update.
 557         * dictionary.c (iter_match_first_hashed): Update.
 558         (iter_match_next_hashed): Update.
 559         (insert_symbol_hashed): Update.
 560         (iter_match_next_linear): Update.
 561         * dictionary.h: Update.
 562         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
 563         (locexpr_describe_location_piece): Update.
 564         (locexpr_describe_location_1): Update.
 565         (locexpr_generate_c_location): Update.
 566         (loclist_describe_location): Update.
 567         (loclist_generate_c_location): Update.
 568         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
 569         (read_func_scope): Update.
 570         (process_enumeration_scope): Update.
 571         (new_symbol): Update.
 572         (dwarf2_const_value): Update.
 573         (dwarf2_symbol_mark_computed): Update.
 574         * eval.c (evaluate_funcall): Update.
 575         (evaluate_subexp_standard): Update.
 576         * expprint.c (print_subexp_standard): Update.
 577         (dump_subexp_body_standard): Update.
 578         * f-valprint.c (info_common_command_for_block): Update.
 579         * findvar.c (get_hosting_frame): Update.
 580         (default_read_var_value): Update.
 581         * go-lang.c (go_symbol_package_name): Update.
 582         * guile/scm-block.c (bkscm_print_block_smob): Update.
 583         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
 584         (gdbscm_symbol_name): Update.
 585         (gdbscm_symbol_linkage_name): Update.
 586         (gdbscm_symbol_print_name): Update.
 587         * infcall.c (get_function_name): Update.
 588         * infcmd.c (jump_command): Update.
 589         (finish_command): Update.
 590         * infrun.c (insert_exception_resume_breakpoint): Update.
 591         * linespec.c (canonicalize_linespec): Update.
 592         (create_sals_line_offset): Update.
 593         (convert_linespec_to_sals): Update.
 594         (complete_label): Update.
 595         (find_label_symbols_in_block): Update.
 596         * m2-typeprint.c (m2_print_typedef): Update.
 597         * mdebugread.c (mdebug_reg_to_regnum): Update.
 598         (parse_symbol): Update.
 599         (mylookup_symbol): Update.
 600         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 601         (list_args_or_locals): Update.
 602         * objc-lang.c (compare_selectors): Update.
 603         (info_selectors_command): Update.
 604         (compare_classes): Update.
 605         (info_classes_command): Update.
 606         (find_imps): Update.
 607         * p-typeprint.c (pascal_print_typedef): Update.
 608         * printcmd.c (build_address_symbolic): Update.
 609         (info_address_command): Update.
 610         (print_variable_and_value): Update.
 611         * python/py-framefilter.c (extract_sym): Update.
 612         (py_print_single_arg): Update.
 613         * python/py-symbol.c (sympy_str): Update.
 614         (sympy_get_name): Update.
 615         (sympy_get_linkage_name): Update.
 616         * python/python.c (gdbpy_rbreak): Update.
 617         * record-btrace.c (btrace_get_bfun_name): Update.
 618         (btrace_call_history): Update.
 619         * rust-lang.c (rust_print_typedef): Update.
 620         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 621         * stabsread.c (stab_reg_to_regnum): Update.
 622         (define_symbol): Update.
 623         (read_enum_type): Update.
 624         (common_block_end): Update.
 625         (cleanup_undefined_types_1): Update.
 626         (scan_file_globals): Update.
 627         * stack.c (print_frame_arg): Update.
 628         (print_frame_args): Update.
 629         (find_frame_funname): Update.
 630         (info_frame_command_core): Update.
 631         (iterate_over_block_locals): Update.
 632         (print_block_frame_labels): Update.
 633         (do_print_variable_and_value): Update.
 634         (iterate_over_block_arg_vars): Update.
 635         (return_command): Update.
 636         * symmisc.c (dump_symtab_1): Update.
 637         (print_symbol): Update.
 638         * symtab.c (eq_symbol_entry): Update.
 639         (symbol_cache_dump): Update.
 640         (lookup_language_this): Update.
 641         (find_pc_sect_line): Update.
 642         (skip_prologue_sal): Update.
 643         (symbol_search::compare_search_syms): Update.
 644         (treg_matches_sym_type_name): Update.
 645         (search_symbols): Update.
 646         (print_symbol_info): Update.
 647         (rbreak_command): Update.
 648         (completion_list_add_symbol): Update.
 649         (find_gnu_ifunc): Update.
 650         (get_symbol_address): Update.
 651         (search_module_symbols): Update.
 652         (info_module_subcommand): Update.
 653         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 654         (SYMBOL_LINKAGE_NAME): Remove.
 655         (SYMBOL_DEMANGLED_NAME): Remove.
 656         (SYMBOL_PRINT_NAME): Remove.
 657         (SYMBOL_SEARCH_NAME): Remove.
 658         * tracepoint.c (set_traceframe_context): Update.
 659         (validate_actionline): Update.
 660         (collection_list::collect_symbol): Update.
 661         (encode_actions_1): Update.
 662         (info_scope_command): Update.
 663         (print_one_static_tracepoint_marker): Update.
 664         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 665         * valops.c (address_of_variable): Update.
 666         (find_overload_match): Update.
 667         (find_oload_champ): Update.
 668
 669 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 670
 671         * ada-lang.c (ada_lookup_simple_minsym): Update.
 672         (ada_collect_symbol_completion_matches): Update.
 673         * ada-tasks.c (read_atcb): Update.
 674         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 675         (amd64_windows_skip_trampoline_code): Update.
 676         * arm-tdep.c (skip_prologue_function): Update.
 677         (arm_skip_stack_protector): Update.
 678         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
 679         (arm_wince_skip_main_prologue): Update.
 680         * ax-gdb.c (gen_expr): Update.
 681         * block.c (call_site_for_pc): Update.
 682         * blockframe.c (find_pc_partial_function): Update.
 683         * breakpoint.c (set_breakpoint_location_function): Update.
 684         * btrace.c (ftrace_print_function_name): Update.
 685         (ftrace_function_switched): Update.
 686         * c-valprint.c (print_unpacked_pointer): Update.
 687         * coffread.c (coff_symfile_read): Update.
 688         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
 689         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
 690         * dwarf-index-write.c (write_psymbols): Update.
 691         * dwarf2loc.c (call_site_to_target_addr): Update.
 692         (func_verify_no_selftailcall): Update.
 693         (tailcall_dump): Update.
 694         (call_site_find_chain_1): Update.
 695         (dwarf_expr_reg_to_entry_parameter): Update.
 696         * elfread.c (elf_gnu_ifunc_record_cache): Update.
 697         * eval.c (evaluate_funcall): Update.
 698         (evaluate_subexp_standard): Update.
 699         (evaluate_subexp_for_sizeof): Update.
 700         * expprint.c (print_subexp_standard): Update.
 701         (dump_subexp_body_standard): Update.
 702         * frame.c (get_prev_frame_always_1): Update.
 703         * frv-tdep.c (frv_skip_main_prologue): Update.
 704         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
 705         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
 706         (gnuv3_get_typename_from_type_info): Update.
 707         (gnuv3_skip_trampoline): Update.
 708         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 709         * i386-tdep.c (i386_skip_main_prologue): Update.
 710         (i386_pe_skip_trampoline_code): Update.
 711         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
 712         * infcall.c (get_function_name): Update.
 713         * linespec.c (minsym_found): Update.
 714         * linux-fork.c (info_checkpoints_command): Update.
 715         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
 716         (m32c_m16c_pointer_to_address): Update.
 717         * maint.c (maintenance_translate_address): Update.
 718         * minsyms.c (add_minsym_to_hash_table): Update.
 719         (add_minsym_to_demangled_hash_table): Update.
 720         (lookup_minimal_symbol_mangled): Update.
 721         (lookup_minimal_symbol_demangled): Update.
 722         (lookup_minimal_symbol_linkage): Update.
 723         (lookup_minimal_symbol_text): Update.
 724         (lookup_minimal_symbol_by_pc_name): Update.
 725         (minimal_symbol_is_less_than): Update.
 726         (compact_minimal_symbols): Update.
 727         (build_minimal_symbol_hash_tables): Update.
 728         (find_solib_trampoline_target): Update.
 729         * mips-tdep.c (mips_stub_frame_sniffer): Update.
 730         (mips_skip_pic_trampoline_code): Update.
 731         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
 732         * objc-lang.c (info_selectors_command): Update.
 733         (info_classes_command): Update.
 734         (find_methods): Update.
 735         (find_imps): Update.
 736         * p-valprint.c (pascal_val_print): Update.
 737         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
 738         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
 739         * printcmd.c (build_address_symbolic): Update.
 740         (info_symbol_command): Update.
 741         * psymtab.c (psymbol_name_matches): Update.
 742         (match_partial_symbol): Update.
 743         (lookup_partial_symbol): Update.
 744         (print_partial_symbols): Update.
 745         (sort_pst_symbols): Update.
 746         (maintenance_check_psymtabs): Update.
 747         * python/py-framefilter.c (py_print_frame): Update.
 748         * python/python.c (gdbpy_rbreak): Update.
 749         * record-btrace.c (btrace_get_bfun_name): Update.
 750         (btrace_call_history): Update.
 751         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
 752         (rs6000_skip_trampoline_code): Update.
 753         * sol-thread.c (info_cb): Update.
 754         * stabsread.c (scan_file_globals): Update.
 755         * stack.c (find_frame_funname): Update.
 756         (info_frame_command_core): Update.
 757         * symmisc.c (dump_msymbols): Update.
 758         * symtab.c (symbol_natural_name): Rename to..,
 759         (general_symbol_info::natural_name): ...this.
 760         (symbol_demangled_name): Rename to...
 761         (general_symbol_info::demangled_name): ...this.
 762         (symbol_search_name): Rename to...
 763         (general_symbol_info::search_name): ...this.
 764         (symbol_matches_search_name): Update.
 765         (find_pc_sect_line): Update.
 766         (skip_prologue_sal): Update.
 767         (search_symbols): Update.
 768         (print_msymbol_info): Update.
 769         (rbreak_command): Update.
 770         (completion_list_add_msymbol): Update.
 771         (completion_list_objc_symbol): Update.
 772         (get_msymbol_address): Update.
 773         * symtab.h (struct general_symbol_info): Add member functions
 774         natural_name (), linkage_name (), print_name (), demangled_name (),
 775         and search_name ().
 776         (SYMBOL_NATURAL_NAME): Update.
 777         (symbol_natural_name): Move to a member function on general_symbol_info.
 778         (SYMBOL_DEMANGLED_NAME): Update.
 779         (symbol_demangled_name): Move to a member function on
 780         general_symbol_info.
 781         (SYMBOL_SEARCH_NAME): Update.
 782         (symbol_search_name): Move to a member function on general_symbol_info.
 783         (MSYMBOL_NATURAL_NAME): Remove.
 784         (MSYMBOL_LINKAGE_NAME): Remove.
 785         (MSYMBOL_PRINT_NAME): Remove.
 786         (MSYMBOL_DEMANGLED_NAME): Remove.
 787         (MSYMBOL_SEARCH_NAME): Remove.
 788         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
 789
 790 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 791
 792         * symtab.c (create_demangled_names_hash): Use per_bfd->
 793         minimal_symbol_count for computing the initial size, if greater
 794         than our default size.
 795
 796 2019-11-22  Tom de Vries  <tdevries@suse.de>
 797
 798         * contrib/words.sh: Improve words extraction.
 799
 800 2019-11-22  Tom de Vries  <tdevries@suse.de>
 801
 802         * contrib/words.sh: Combine sed invocations.
 803
 804 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
 805
 806         * Makefile.in: Update.
 807         * demangle.c: Rename to...
 808         * gdb-demangle.c: ..this.
 809         (is_cplus_marker): Change return type to bool.
 810         (_initialize_demangler): Rename to...
 811         (_initialize_gdb_demangle): ...this.
 812         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
 813         * symtab.h (demangle): Remove declaration; instead include
 814         gdb-demangle.h.
 815
 816 2019-11-21  Tom Tromey  <tromey@adacore.com>
 817
 818         * gdbsupport/format.c (format_pieces): Parse %I64d.
 819         * unittests/format_pieces-selftests.c (test_windows_formats): New
 820         function.
 821         (run_tests): Call it.
 822
 823 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
 824
 825         Byte reverse display of variables with DW_END_big, DW_END_little
 826         (DW_AT_endianity) dwarf attributes if different than the native
 827         byte order.
 828         * ada-lang.c (ada_value_binop):
 829         Use type_byte_order instead of gdbarch_byte_order.
 830         * ada-valprint.c (printstr):
 831         (ada_val_print_string):
 832         * ada-lang.c (value_pointer):
 833         (ada_value_binop):
 834         Use type_byte_order instead of gdbarch_byte_order.
 835         * c-lang.c (c_get_string):
 836         Use type_byte_order instead of gdbarch_byte_order.
 837         * c-valprint.c (c_val_print_array):
 838         Use type_byte_order instead of gdbarch_byte_order.
 839         * cp-valprint.c (cp_print_class_member):
 840         Use type_byte_order instead of gdbarch_byte_order.
 841         * dwarf2loc.c (rw_pieced_value):
 842         Use type_byte_order instead of gdbarch_byte_order.
 843         * dwarf2read.c (read_base_type): Handle DW_END_big,
 844         DW_END_little
 845         * f-lang.c (f_get_encoding):
 846         Use type_byte_order instead of gdbarch_byte_order.
 847         * findvar.c (default_read_var_value):
 848         Use type_byte_order instead of gdbarch_byte_order.
 849         * gdbtypes.c (check_types_equal):
 850         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
 851         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
 852         and TYPE_ENDIANITY_LITTLE if set.
 853         (type_byte_order): new function.
 854         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
 855         (struct main_type) <flag_endianity_not_default>:
 856         New field.
 857         (type_byte_order): New function.
 858         * infcmd.c (default_print_one_register_info):
 859         Use type_byte_order instead of gdbarch_byte_order.
 860         * p-lang.c (pascal_printstr):
 861         Use type_byte_order instead of gdbarch_byte_order.
 862         * p-valprint.c (pascal_val_print):
 863         Use type_byte_order instead of gdbarch_byte_order.
 864         * printcmd.c (print_scalar_formatted):
 865         Use type_byte_order instead of gdbarch_byte_order.
 866         * solib-darwin.c (darwin_current_sos):
 867         Use type_byte_order instead of gdbarch_byte_order.
 868         * solib-svr4.c (solib_svr4_r_ldsomap):
 869         Use type_byte_order instead of gdbarch_byte_order.
 870         * stap-probe.c (stap_modify_semaphore):
 871         Use type_byte_order instead of gdbarch_byte_order.
 872         * target-float.c (target_float_same_format_p):
 873         Use type_byte_order instead of gdbarch_byte_order.
 874         * valarith.c (scalar_binop):
 875         (value_bit_index):
 876         Use type_byte_order instead of gdbarch_byte_order.
 877         * valops.c (value_cast):
 878         Use type_byte_order instead of gdbarch_byte_order.
 879         * valprint.c (generic_emit_char):
 880         (generic_printstr):
 881         (val_print_string):
 882         Use type_byte_order instead of gdbarch_byte_order.
 883         * value.c (unpack_long):
 884         (unpack_bits_as_long):
 885         (unpack_value_bitfield):
 886         (modify_field):
 887         (pack_long):
 888         (pack_unsigned_long):
 889         Use type_byte_order instead of gdbarch_byte_order.
 890         * findvar.c (unsigned_pointer_to_address):
 891         (signed_pointer_to_address):
 892         (unsigned_address_to_pointer):
 893         (address_to_signed_pointer):
 894         (default_read_var_value):
 895         (default_value_from_register):
 896         Use type_byte_order instead of gdbarch_byte_order.
 897         * gnu-v3-abi.c (gnuv3_make_method_ptr):
 898         Use type_byte_order instead of gdbarch_byte_order.
 899         * riscv-tdep.c (riscv_print_one_register_info):
 900         Use type_byte_order instead of gdbarch_byte_order.
 901
 902 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
 903
 904         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
 905         (current_ui_gdb_stdin_ptr): Likewise.
 906         (current_ui_gdb_stderr_ptr): Likewise.
 907         (current_ui_gdb_stdlog_ptr): Likewise.
 908         (current_ui_current_uiout_ptr): Likewise.
 909         (gen_ret_current_ui_field_ptr): Remove.
 910
 911 2019-11-21  Tom de Vries  <tdevries@suse.de>
 912
 913         PR gdb/24956
 914         * cli/cli-script.c (execute_control_command): Only switch to
 915         INTERP_CONSOLE's ui_out when INTERP_MI is active.
 916
 917 2019-11-19  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
 920         Now static.  Change type of "name".
 921         (tui_set_win_height_command): Don't copy "arg".
 922         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
 923         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
 924
 925 2019-11-19  Ali Tamur <tamur@google.com>
 926
 927         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
 928         "if (attr != nullptr)".
 929         (dwarf2_find_base_address): Likewise.
 930         (dwarf2_build_include_psymtabs): Likewise.
 931         (read_cutu_die_from_dwo): Likewise.
 932         (read_func_scope): Likewise.
 933         (read_call_site_scope): Likewise.
 934         (dwarf2_get_pc_bounds): Likewise.
 935         (dwarf2_record_block_ranges): Likewise.
 936         (dwarf2_add_field): Likewise.
 937         (dwarf2_add_member_fn): Likewise.
 938         (read_structure_type): Likewise.
 939         (read_enumeration_type): Likewise.
 940         (read_array_type): Likewise.
 941         (read_array_order): Likewise.
 942         (read_set_type): Likewise.
 943         (read_common_block): Likewise.
 944         (read_tag_reference_type): Likewise.
 945         (read_tag_string_type): Likewise.
 946         (read_subroutine_type): Likewise.
 947         (read_base_type): Likewise.
 948         (read_subrange_type): Likewise.
 949         (new_symbol): Likewise.
 950         (prepare_one_comp_unit): Likewise.
 951
 952 2019-11-19  Tom Tromey  <tromey@adacore.com>
 953
 954         * windows-nat.c (windows_nat_target::attach): Include GetLastError
 955         result in error when DebugActiveProcess fails.
 956
 957 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
 958             Pedro Alves  <palves@redhat.com>
 959
 960         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
 961         * target.c (target_stack::push): Call 'unpush' if there's a
 962         target on top of the stack.
 963
 964 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 965
 966         * python/py-block.c (blpy_dealloc): Call tp_free.
 967         (blpy_block_syms_dealloc): Likewise.
 968         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
 969         * python/py-inferior.c (infpy_dealloc): Likewise.
 970         * python/py-lazy-string.c (stpy_dealloc): Likewise.
 971         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
 972         * python/py-symbol.c (sympy_dealloc): Likewise.
 973         * python/py-symtab.c (stpy_dealloc): Likewise.
 974         * python/py-type.c (typy_iterator_dealloc): Likewise.
 975
 976 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
 977
 978         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
 979         constructor instead of using a class initializer.
 980
 981 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 982
 983         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
 984         * configure: Regenerate.
 985         * configure.ac: Don't source common.host.
 986         * gdbsupport/common.host: Remove.
 987         * gdbsupport/mingw-strerror.c: Remove.
 988         * gdbsupport/posix-strerror.c: Rename to...
 989         * gdbsupport/safe-strerror.c: ...this.
 990
 991 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 992
 993         * maint.c (scoped_command_stats::print_time): Use localtime_r
 994         instead of localtime (provided through gnulib if necessary).
 995         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
 996         of ctime.
 997
 998 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 999
1000         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1001         avoid compile errors.
1002
1003 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1004
1005         * config.in: Regenerate.
1006         * configure: Regenerate.
1007         * gdbsupport/common.m4: No longer check for strerror_r.
1008         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1009         POSIX version of strerror_r, now that gnulib provides it if
1010         necessary.
1011
1012 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1013
1014         * README (`configure' options): Update.
1015
1016 2019-11-14  Tom Tromey  <tromey@adacore.com>
1017
1018         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1019         expected type for the RHS if the LHS is a convenience variable.
1020
1021 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1022
1023         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1024         Provide explicit default and copy constructor.
1025
1026 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1027
1028         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1029         only call Py_INCREF (newbp) in the bppy_pending_object case.
1030
1031 2019-11-13  Tom Tromey  <tromey@adacore.com>
1032
1033         PR build/25182:
1034         * psympriv.h (partial_symbol): Remove static assert.
1035         * symtab.h (general_symbol_info, symbol): Remove static assert.
1036
1037 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1038
1039         * gdbsupport/format.c (format_pieces::format_pieces): Support
1040         printf 'z' size modifier.
1041         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1042         * printcmd.c (ui_printf):  Handle size_t_arg.
1043         * ui-out.c (ui_out::vmessage): Likewise.
1044         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1045         function.
1046         (run_tests): Call test_format_int_sizes.
1047
1048 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1049
1050         * ada-exp.y (write_ambiguous_var): Update.
1051         * buildsym.c (add_symbol_to_list): Update.
1052         * dwarf2read.c (read_variable): Update.
1053         (new_symbol): Update.
1054         * jit.c (finalize_symtab): Update.
1055         * language.c (language_alloc_type_symbol): Update.
1056         * symtab.c (fixup_symbol_section): Update.
1057         (initialize_objfile_symbol_1): Move code to...
1058         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1059         (allocate_symbol): Update.
1060         (allocate_template_symbol): Update.
1061         (get_symbol_address): Update.
1062         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1063         of having as a field, and add a constructor.
1064         (SYMBOL_VALUE): Update.
1065         (SYMBOL_VALUE_ADDRESS): Update.
1066         (SET_SYMBOL_VALUE_ADDRESS): Update.
1067         (SYMBOL_VALUE_BYTES): Update.
1068         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1069         (SYMBOL_BLOCK_VALUE): Update.
1070         (SYMBOL_VALUE_CHAIN): Update.
1071         (SYMBOL_LANGUAGE): Update.
1072         (SYMBOL_SECTION): Update.
1073         (SYMBOL_OBJ_SECTION): Update.
1074         (SYMBOL_SET_LANGUAGE): Update.
1075         (SYMBOL_SET_LINKAGE_NAME): Update.
1076         (SYMBOL_SET_NAMES): Update.
1077         (SYMBOL_NATURAL_NAME): Update.
1078         (SYMBOL_LINKAGE_NAME): Update.
1079         (SYMBOL_DEMANGLED_NAME): Update.
1080         (SYMBOL_SEARCH_NAME): Update.
1081         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1082         (struct symbol): Update.
1083         (struct template_symbol): Update.
1084         (struct rust_vtable_symbol): Update.
1085         * xcoffread.c (SYMBOL_DUP): Update.
1086
1087 2019-11-12  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui-layout.c (show_layout): Set current_layout.
1090         (show_source_disasm_command, show_data)
1091         (show_source_or_disasm_and_command): Don't set current_layout.
1092
1093 2019-11-12  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1096
1097 2019-11-12  Tom Tromey  <tom@tromey.com>
1098
1099         * tui/tui-win.c (resize_message): New global.
1100         (show_tui_resize_message): New function.
1101         (tui_async_resize_screen): Print message if requested.
1102         (_initialize_tui_win): Add tui-resize-message setting.
1103         * NEWS: Add entry for new commands.
1104
1105 2019-11-11  Tom Tromey  <tom@tromey.com>
1106
1107         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1108         functions.
1109
1110 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1111
1112         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1113
1114 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1115
1116         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1117         function.
1118         * python/python-internal.h (gdbpy_lookup_static_symbols):
1119         Declare new function.
1120         * python/python.c (python_GdbMethods): Add
1121         gdb.lookup_static_symbols method.
1122         * NEWS: Mention gdb.lookup_static_symbols.
1123
1124 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1127         static block of current object file first.  Also fix typo in
1128         header comment.
1129
1130 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1131
1132         * stack.c (set_last_displayed_sal): Delete.
1133         (last_displayed_sal_valid): Delete.
1134         (last_displayed_pspace): Delete.
1135         (last_displayed_addr): Delete.
1136         (last_displayed_symtab): Delete.
1137         (last_displayed_line): Delete.
1138         (class last_displayed_symtab_info_type): New.
1139         (last_displayed_symtab_info): New static global variable.
1140         (print_frame_info): Call methods on last_displayed_symtab_info.
1141         (clear_last_displayed_sal): Update header comment, and make use of
1142         last_displayed_symtab_info.
1143         (last_displayed_sal_is_valid): Likewise.
1144         (get_last_displayed_pspace): Likewise.
1145         (get_last_displayed_addr): Likewise.
1146         (get_last_displayed_symtab): Likewise.
1147         (get_last_displayed_line): Likewise.
1148         (get_last_displayed_sal): Likewise.
1149         * stack.h (clear_last_displayed_sal): Update header comment.
1150         (last_displayed_sal_is_valid): Likewise.
1151         (get_last_displayed_pspace): Likewise.
1152         (get_last_displayed_addr): Likewise.
1153         (get_last_displayed_symtab): Likewise.
1154         (get_last_displayed_line): Likewise.
1155         (get_last_displayed_sal): Likewise.
1156
1157 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1158
1159         * stack.c (frame_show_address): Convert return type to bool.
1160         * stack.h (frame_show_address): Likewise, and update header
1161         comment.
1162
1163 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1164
1165         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1166         * unittests/vec-utils-selftests.c: New file.
1167         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1168
1169 2019-11-10  Tom Tromey  <tom@tromey.com>
1170
1171         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1172         (tui_highlight_win): Likewise.
1173         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1174         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1175         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1176         Don't set can_highlight.
1177
1178 2019-11-10  Tom Tromey  <tom@tromey.com>
1179
1180         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1181         Remove unused declaration.
1182
1183 2019-11-08  Tom Tromey  <tromey@adacore.com>
1184
1185         * top.c (read_command_file): Update.
1186         (command_line_input): Make return type const.
1187         * python/py-gdb-readline.c: Update.
1188         * linespec.c (decode_line_2): Update.
1189         * defs.h (command_line_input): Make return type const.
1190         * cli/cli-script.c (read_next_line): Make return type const.
1191         * ada-lang.c (get_selections): Update.
1192
1193 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1194
1195         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1196         * mi/mi-main.c (output_cores): Likewise.
1197         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1198         (linux_xfer_osdata_modules): Likewise.
1199         * remote.c (register_remote_support_xml): Likewise.
1200         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1201         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1202
1203 2019-11-06  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-interp.c: Don't include readline.h.
1206         * tui/tui-hooks.c: Don't include readline.h.
1207         * symmisc.c: Include tilde.h, not readline.h.
1208         * symfile.c: Include tilde.h, not readline.h.
1209         * source.c: Include tilde.h, not readline.h.
1210         * solib.c: Include tilde.h, not readline.h.
1211         * psymtab.c: Include tilde.h, not readline.h.
1212         * exec.c: Include tilde.h, not readline.h.
1213         * corelow.c: Include tilde.h, not readline.h.
1214         * cli/cli-dump.c: Include tilde.h, not readline.h.
1215         * cli/cli-cmds.c: Don't include readline.h.
1216
1217 2019-11-05  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1220         (tui_disassemble): Set addr_size.
1221         (tui_disasm_window::set_contents): Use addr_size.
1222
1223 2019-11-05  Tom Tromey  <tom@tromey.com>
1224
1225         * rust-lang.c (rust_language_defn): Update.
1226         * python/py-value.c (valpy_string): Call c_get_string.
1227         * p-lang.c (pascal_language_defn): Update.
1228         * opencl-lang.c (opencl_language_defn): Update.
1229         * objc-lang.c (objc_language_defn): Update.
1230         * m2-lang.c (m2_language_defn): Update.
1231         * language.c (unknown_language_defn, auto_language_defn): Update.
1232         (default_get_string): Remove.
1233         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1234         * go-lang.c (go_language_defn): Update.
1235         * f-lang.c (f_language_defn): Update.
1236         * d-lang.c (d_language_defn): Update.
1237         * c-lang.c (c_language_defn, cplus_language_defn)
1238         (asm_language_defn, minimal_language_defn): Update.
1239         * ada-lang.c (ada_language_defn): Update.
1240         * language.h (struct language_defn) <la_get_string>: Remove.
1241         (LA_GET_STRING): Remove.
1242         (default_get_string): Don't declare.
1243
1244 2019-11-05  Tom Tromey  <tom@tromey.com>
1245
1246         * tui/tui-source.h (struct tui_source_window): Inline
1247         constructor.  Remove destructor.
1248         <style_changed, m_observable>: Move to superclass.
1249         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1250         (struct tui_source_window_base): Move private members to end.
1251         <style_changed, m_observable>: Move from tui_source_window.
1252         * tui/tui-winsource.c (tui_copy_source_line): Move from
1253         tui-source.c.  Rename from copy_source_line.  Add special handling
1254         for negative line number.
1255         (tui_source_window_base::style_changed): Move from
1256         tui_source_window.
1257         (tui_source_window_base): Register observer.
1258         (~tui_source_window_base): New.
1259         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1260         rename.
1261         (tui_source_window::set_contents): Use tui_copy_source_line.
1262         (tui_source_window::tui_source_window): Move to tui-source.h.
1263         (tui_source_window::~tui_source_window): Remove.
1264         (tui_source_window::style_changed): Move to superclass.
1265         * tui/tui-disasm.c (tui_disassemble): Create string file with
1266         styling, when possible.  Add "addr_size" parameter.
1267         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1268         Don't compute maximum size.
1269         (len_without_escapes): New function
1270
1271 2019-11-05  Tom Tromey  <tom@tromey.com>
1272
1273         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1274         std::string.
1275         * tui/tui-winsource.c (tui_show_source_line): Update.
1276         * tui/tui-source.c (tui_source_window::set_contents): Update.
1277         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1278
1279 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1280
1281         * symtab.h (gdb_static_assert): Put && operator at the beginning
1282         of the line instead of the end.
1283
1284 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1285
1286         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1287         and sizeof (symbol).
1288         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1289
1290 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1291
1292         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1293         * configure.host: Mark *-*-solaris2.10* obsolete.
1294         * configure.tgt: Mark Solaris < 11 obsolete.
1295         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1296         Update target triplet.
1297
1298 2019-11-01  Tom Tromey  <tromey@adacore.com>
1299
1300         * utils.c (print_sys_errmsg): Simplify.
1301
1302 2019-11-01  Tom Tromey  <tromey@adacore.com>
1303
1304         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1305
1306 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1307
1308         * configure: Regenerate.
1309         * configure.ac: Remove check for strerror_r.
1310         * gdbsupport/common.m4: Check for strerror_r.
1311
1312 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1313
1314         PR gdb/25124
1315
1316         * arm-tdep.c (arm_per_objfile): Rename to ...
1317         (arm_per_bfd): ... this.
1318         (arm_objfile_data_key): Rename to ...
1319         (arm_bfd_data_key): ... this.
1320         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1321         data.
1322         (arm_record_special_symbol): Likewise.
1323
1324 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1327         end.
1328         * c-typeprint.c (c_print_typedef): Likewise.
1329         * f-typeprint.c (f_print_typedef): Likewise.
1330         * m2-typeprint.c (m2_print_typedef): Likewise.
1331         * p-typeprint.c (pascal_print_typedef): Likewise.
1332         * rust-lang.c (rust_print_typedef): Likewise.
1333         * symtab.c (print_symbol_info): Print a newline after calling
1334         typedef_print.
1335
1336 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1337
1338         * symtab.c (info_module_cmdlist): New variable.
1339         (info_module_command): New function.
1340         (search_module_symbols): New function.
1341         (info_module_subcommand): New function.
1342         (struct info_modules_var_func_options): New struct.
1343         (info_modules_var_func_options_defs): New variable.
1344         (make_info_modules_var_func_options_def_group): New function.
1345         (info_module_functions_command): New function.
1346         (info_module_variables_command): New function.
1347         (info_module_var_func_command_completer): New function.
1348         (_initialize_symtab): Register new 'info module functions' and
1349         'info module variables' commands.
1350         * symtab.h (typedef symbol_search_in_module): New typedef.
1351         (search_module_symbols): Declare new function.
1352         * NEWS: Mention new commands.
1353
1354 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1355
1356         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1357         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1358         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1359         MODULES_DOMAIN.
1360         (scan_partial_symbols): Only create partial module symbols for non
1361         declarations.
1362         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1363         and MODULES_DOMAIN.
1364         * symtab.c (search_domain_name): Likewise.
1365         (search_symbols): Likewise.
1366         (print_symbol_info): Likewise.
1367         (symtab_symbol_info): Likewise.
1368         (info_modules_command): New function.
1369         (_initialize_symtab): Register 'info modules' command.
1370         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1371         * NEWS: Mention new 'info modules' command.
1372
1373 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1374
1375         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1376         and $_gdb_maint_setting_str.
1377
1378 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1379
1380         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1381         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1382         (str_value_from_setting, gdb_setting_str_internal_fn)
1383         (gdb_maint_setting_str_internal_fn): New functions.
1384         (_initialize_cli_cmds): Define the new convenience functions.
1385         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1386         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1387
1388 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1389
1390         * agent.c (set_can_use_agent): When the setting is turned on,
1391         look up agent symbols if we don't have them yet.
1392         (agent_new_objfile): Don't look up agent symbols when the agent
1393         setting is off.
1394
1395 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1396
1397         * config.in: Regenerate.
1398
1399 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1400
1401         * configure: Regenerate.
1402         * configure.ac: Check for strerror_r.
1403         * gdbsupport/common-utils.h (safe_strerror): Change return value
1404         to const char * and document that this function is now threadsafe.
1405         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1406         thread_local and call strerror_r, if available.
1407         * utils.c (perror_string): Update.
1408         (print_sys_errmsg): Update.
1409
1410 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1411
1412         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1413         objfile_key.
1414         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1415         objfile to fetch per-bfd data.
1416         (arm_find_exidx_entry): Likewise.
1417
1418 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1419
1420         * gdbsupport/agent.c (debug_agent): Change type to bool.
1421         (use_agent): Likewise.
1422         (all_agent_symbols_look_up): Likewise.
1423         (agent_loaded_p): Change return value to bool.
1424         (agent_look_up_symbols): Update.
1425         (agent_capability_check): Change return value to bool.
1426         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1427         (debug_agent): Change type to bool.
1428         (use_agent): Likewise.
1429         (agent_capability_check): Change return value to bool.
1430
1431 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1432
1433         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1434         (build_minimal_symbol_hash_tables): Code to clear the table moved
1435         to clear_minimal_symbol_hash_tables.
1436         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1437         when needed.
1438
1439 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1440
1441         * infcmd.c: Remove includes.
1442         * infrun.c: Remove includes.
1443
1444 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1445
1446         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1447         (grow_vect): Remove declaration.
1448         (ada_type_of_array): Remove declaration.
1449         (ada_update_initial_language): Remove declaration.
1450         (ada_fold_name): Remove declaration.
1451         (ada_fill_in_ada_prototype): Remove declaration.
1452         (user_select_syms): Remove declaration.
1453         (get_selections): Remove declaration.
1454         (ada_tag_type): Remove declaration.
1455         (ada_value_tag): Remove declaration.
1456         (ada_is_others_clause): Remove declaration.
1457         (ada_in_variant): Remove declaration.
1458         (ada_value_struct_elt): Remove declaration.
1459         (ada_attribute_name): Remove declaration.
1460         (ada_system_address_type): Remove declaration.
1461         * ada-lang.c (ada_watch_location_expression): Make static.
1462         (GROW_VECT): Move here from ada-lang.h.
1463         (grow_vect): Make static.
1464         (ada_update_initial_language): Make static.
1465         (ada_fold_name): Make static.
1466         (ada_type_of_array): Make static.
1467         (encoded_ordered_before): Move up.
1468         (sort_choices): Move up.
1469         (print_signatures): Move up.
1470         (ada_print_symbol_signature): Move up.
1471         (get_selections): Move up and make static.
1472         (user_select_syms): Move up and make static.
1473         (ada_value_struct_elt): Move up and make static.
1474         (ada_tag_type): Make static.
1475         (ada_value_tag): Make static.
1476         (ada_is_others_clause): Make static.
1477         (ada_in_variant): Make static.
1478         (ada_attribute_name): Make static.
1479
1480 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1481
1482         * ada-lang.c: Remove includes.
1483         * ada-typeprint.c: Remove includes.
1484         * ada-valprint.c: Remove includes.
1485
1486 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1487
1488         * addrmap.c: Add static assertions of type size, moved from
1489         _initialize_addrmap.
1490         (_initialize_addrmap): Remove.
1491
1492 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1493
1494         * coffread.c (record_minimal_symbol): Update.
1495         (process_coff_symbol): Update.
1496         * dbxread.c (read_dbx_symtab): Update.
1497         * dwarf2read.c (add_partial_symbol): Update.
1498         (fixup_go_packaging): Update.
1499         (load_partial_dies): Update.
1500         (new_symbol): Update.
1501         * elfread.c (record_minimal_symbol): Change signature to use
1502         gdb::string_view instead of name+len.
1503         (elf_symtab_read): Update.
1504         (elf_rel_plt_read): Update.
1505         * mdebugread.c (parse_partial_symbols): Update.
1506         (handle_psymbol_enumerators): Update.
1507         (new_symbol): Update.
1508         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1509         to use gdb::string_view instead of name+len.
1510         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1511         * psympriv.h (add_psymbol_to_list): Likewise.
1512         * psymtab.c (add_psymbol_to_bcache): Likewise.
1513         (add_psymbol_to_list): Likewise.
1514         * stabsread.c (define_symbol): Update.
1515         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1516         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1517         (symbol_set_names): Likewise.
1518         * xcoffread.c (scan_xcoff_symtab): Update.
1519
1520 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1521
1522         * symtab.h (symbol_set_names): Document that copy_name must be
1523         set to true for non-nullterminated strings.
1524         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1525         linkage_name if the entry was not found and we need to demangle.
1526
1527 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1528
1529         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1530         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1531         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1532         * gdbsupport/gdb_binary_search.h: New file.
1533
1534 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1535
1536         * NEWS: Mention new --with-system-gdbinit-dir option.
1537         * config.in: Regenerate.
1538         * configure: Regenerate.
1539         * configure.ac: Add new option --with-system-gdbinit-dir.
1540         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1541         for a ".gdb" suffix.
1542         * main.c (get_init_files): Change system_gdbinit argument to
1543         a vector and return the files in SYSTEM_GDBINIT_DIR in
1544         addition to SYSTEM_GDBINIT.
1545         (captured_main_1): Update.
1546         (print_gdb_help): Update.
1547         * top.c (print_gdb_configuration): Also print the value of
1548         SYSTEM_GDBINIT_DIR.
1549
1550 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1551
1552         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1553         that takes gdb::string_view arguments.
1554
1555 2019-10-26  Tom de Vries  <tdevries@suse.de>
1556
1557         * aarch64-linux-tdep.c: Fix typos in comments.
1558         * aarch64-tdep.c: Same.
1559         * ada-lang.c: Same.
1560         * amd64-nat.c: Same.
1561         * arc-tdep.c: Same.
1562         * arch/aarch64-insn.c: Same.
1563         * block.c: Same.
1564         * breakpoint.h: Same.
1565         * btrace.h: Same.
1566         * c-varobj.c: Same.
1567         * cli/cli-decode.c: Same.
1568         * cli/cli-script.c: Same.
1569         * cli/cli-utils.h: Same.
1570         * coff-pe-read.c: Same.
1571         * coffread.c: Same.
1572         * compile/compile-cplus-symbols.c: Same.
1573         * compile/compile-object-run.c: Same.
1574         * completer.c: Same.
1575         * corelow.c: Same.
1576         * cp-support.c: Same.
1577         * demangle.c: Same.
1578         * dwarf-index-write.c: Same.
1579         * dwarf2-frame.c: Same.
1580         * dwarf2-frame.h: Same.
1581         * eval.c: Same.
1582         * frame-base.h: Same.
1583         * frame.h: Same.
1584         * gdbcmd.h: Same.
1585         * gdbtypes.h: Same.
1586         * gnu-nat.c: Same.
1587         * guile/scm-objfile.c: Same.
1588         * i386-tdep.c: Same.
1589         * i386-tdep.h: Same.
1590         * infcall.c: Same.
1591         * infcall.h: Same.
1592         * linux-nat.c: Same.
1593         * m68k-tdep.c: Same.
1594         * macroexp.c: Same.
1595         * memattr.c: Same.
1596         * mi/mi-cmd-disas.c: Same.
1597         * mi/mi-getopt.h: Same.
1598         * mi/mi-main.c: Same.
1599         * minsyms.c: Same.
1600         * nat/aarch64-sve-linux-sigcontext.h: Same.
1601         * objfiles.h: Same.
1602         * ppc-linux-nat.c: Same.
1603         * ppc-linux-tdep.c: Same.
1604         * ppc-tdep.h: Same.
1605         * progspace.h: Same.
1606         * prologue-value.h: Same.
1607         * python/py-evtregistry.c: Same.
1608         * python/py-instruction.h: Same.
1609         * record-btrace.c: Same.
1610         * record-full.c: Same.
1611         * remote.c: Same.
1612         * rs6000-tdep.c: Same.
1613         * ser-tcp.c: Same.
1614         * sol-thread.c: Same.
1615         * sparc-sol2-tdep.c: Same.
1616         * sparc64-tdep.c: Same.
1617         * stabsread.c: Same.
1618         * symfile.c: Same.
1619         * symtab.h: Same.
1620         * target.c: Same.
1621         * tracepoint.c: Same.
1622         * tui/tui-data.h: Same.
1623         * tui/tui-io.c: Same.
1624         * tui/tui-win.c: Same.
1625         * tui/tui.c: Same.
1626         * unittests/rsp-low-selftests.c: Same.
1627         * user-regs.h: Same.
1628         * utils.c: Same.
1629         * utils.h: Same.
1630         * valarith.c: Same.
1631         * valops.c: Same.
1632         * valprint.c: Same.
1633         * valprint.h: Same.
1634         * value.c: Same.
1635         * value.h: Same.
1636         * varobj.c: Same.
1637         * x86-nat.h: Same.
1638         * xtensa-tdep.c: Same.
1639
1640 2019-10-25  Ali Tamur <tamur@google.com>
1641
1642         * charset.c (find_charset_names): Reflect API change.
1643
1644 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1645
1646         * symtab.c (struct demangled_name_entry): Change demangled name
1647         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1648         part of the struct anymore.
1649         (symbol_set_names): No longer obstack allocate + copy the demangled
1650         name, just store the allocated name from bfd.
1651
1652 2019-10-25  Tom Tromey  <tromey@adacore.com>
1653
1654         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1655         (bsearch_cie_cmp, add_cie): Remove.
1656         (find_cie): Reimplement.
1657         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1658         (dwarf2_build_frame_info): Update.
1659
1660 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1661
1662         PR gdb/25126
1663         * symfile.c (reread_symbols): Call forget_cached_source_info to
1664         clear the stale source cache.
1665
1666 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1667
1668         * configure: Regenerate.
1669         * configure.ac: Remove code that sets python_has_threads.
1670
1671 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1672
1673         * config.in: Regenerate.
1674         * configure: Regenerate.
1675         * configure.ac: Remove the code that uses sed to get the python
1676         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1677
1678 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1679
1680         * python/py-progspace.c (pspy_block_for_pc): Return None for all
1681         error paths.
1682
1683 2019-10-23  Tom Tromey  <tom@tromey.com>
1684
1685         * arc-tdep.c: Remove ".." from include.
1686         * frv-tdep.c: Remove ".." from include.
1687         * lm32-tdep.c: Remove ".." from include.
1688         * microblaze-tdep.c: Remove ".." from include.
1689         * or1k-tdep.h: Remove ".." from include.
1690         * s12z-tdep.c: Remove ".." from include.
1691         * Makefile.in (OPCODES_CFLAGS): Add comment.
1692         (TOP_CFLAGS): New variable.
1693         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1694
1695 2019-10-23  Tom Tromey  <tom@tromey.com>
1696
1697         * Makefile.in (READLINE_DIR): Update.
1698
1699 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1700
1701         * infcall.c (call_function_by_hand_dummy): Fix the function
1702         comment.  And extract out a code section into...
1703         (reserve_stack_space): ...this new function.
1704
1705 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1706
1707         * infcall.c (value_arg_coerce): Remove an unused parameter.
1708         (call_function_by_hand_dummy): Update the call to
1709         'value_arg_coerce'.
1710
1711 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1712
1713         * infcall.c (call_function_by_hand_dummy): Refactor.
1714
1715 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1716
1717         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1718
1719 2019-10-23  Tom Tromey  <tom@tromey.com>
1720
1721         * configure: Rebuild.
1722         * configure.ac: Don't check for sigprocmask.
1723         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1724
1725 2019-10-23  Tom Tromey  <tom@tromey.com>
1726
1727         * configure: Rebuild.
1728         * acinclude.m4: Use m4_include, not sinclude.
1729
1730 2019-10-23  Tom de Vries  <tdevries@suse.de>
1731
1732         PR breakpoints/24687
1733         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1734
1735 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1736
1737         * symtab.c (struct demangled_name_entry) <language>: Change from
1738         bitfield to regular variable.
1739
1740 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1741
1742         * symtab.c (struct demangled_name_entry): Add a constructor.
1743         (free_demangled_name_entry): New function to call the destructor
1744         for demangled_name_entry.
1745         (create_demangled_names_hash): Pass free_demangled_name_entry to
1746         htab_create_alloc.
1747         (symbol_set_names): Call placement new for demangled_name_entry.
1748         * utils.c: No longer include xxhash.h here, now that fast_hash
1749         is inlined in the header.
1750         * utils.h: Instead, include it here.
1751
1752 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1753
1754         * Makefile.in: Link with libxxhash.
1755         * config.in: Regenerate.
1756         * configure: Regenerate.
1757         * configure.ac: Search for libxxhash.
1758         * utils.c (fast_hash): Use xxhash if present.
1759
1760 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1761
1762         * utils.h (fast_hash): New function.
1763         * symtab.c (hash_demangled_name_entry): Call new function
1764         fast_hash.
1765
1766 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1767
1768         * symtab.c (struct demangled_name_entry): Change type of mangled
1769         to gdb::string_view. Also adds a constructor that takes the
1770         mangled name.
1771         (hash_demangled_name_entry): Update.
1772         (eq_demangled_name_entry): Update.
1773         (free_demangled_name_entry): New function to call the destructor
1774         now that this is not a POD anymore.
1775         (create_demangled_names_hash): Pass free_demangled_name_entry to
1776         htab_create_alloc.
1777         (symbol_set_names): Update.
1778
1779 2019-10-21  Ali Tamur  <tamu@google.com>
1780
1781         * dwarf2read.c (dir_index): Change type.
1782         (file_name_index): Likewise.
1783         (line_header::include_dir_at): Change comment and implementation on
1784         whether it is DWARF 5.
1785         (line_header::is_valid_file_index): New function.
1786         (line_header::file_name_at): Change comment and implementation on
1787         whether it is DWARF 5.
1788         (line_header::file_names): Change to private field renamed as
1789         m_file_names and introduce a new accessor method.
1790         (line_header::file_names_size): New method.
1791         (line_header::include_dirs): Change to private field and rename as
1792         m_include_dirs.
1793         (dw2_get_file_names_reader): Define local var at a smaller scope and
1794         reflect API change.
1795         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1796         (process_structure_scope): Likewise.
1797         (line_header::add_include_dir): Change message and reflect renaming.
1798         (line_header::add_file_name): Likewise.
1799         (read_formatted_entries): Handle DW_FORM_data16.
1800         (dwarf_decode_line_header): Fix line header length calculation.
1801         (psymtab_include_file_name): Change comment and API.
1802         (lnp_state_machine::m_file): Update comment and reflect type change.
1803         (lnp_state_machine::record_line): Reflect type change.
1804         (dwarf_decode_lines): Reflect API change.
1805         (file_file_name): Likewise.
1806         (file_full_name): Likewise.
1807
1808 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1809
1810         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1811
1812 2019-10-21  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1815
1816 2019-10-21  Tom Tromey  <tom@tromey.com>
1817
1818         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
1819         NM_H.   Use AC_CONFIG_LINKS.
1820         * configure: Rebuild.
1821         * Makefile.in (NM_H): New variable.
1822         (generated_files): Add NM_H.  Remove gcore.
1823         (nm.h, stamp-nmh): New targets.
1824
1825 2019-10-20  Tom Tromey  <tom@tromey.com>
1826
1827         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1828         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
1829         obsolete comment.
1830         (put_objfile_before): Now static.
1831
1832 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
1833
1834         * gdbsupport/common-utils.h (startswith): Change return type to
1835         bool.
1836
1837 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
1838
1839         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1840         * breakpoint.c (bp_locations_compare): Rename to...
1841         (bp_location_is_less_than): ...this, and change to std::sort semantics.
1842         (update_global_location_list): Use std::sort instead of qsort.
1843         * buildsym.c (compare_line_numbers): Rename to...
1844         (lte_is_less_than): ...this, and change to std::sort semantics.
1845         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1846         instead of qsort.
1847         * disasm.c (compare_lines): Rename to...
1848         (line_is_less_than): ...this, and change to std::sort semantics.
1849         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1850         of qsort.
1851         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1852         (fde_is_less_than): ...this, and change to std::sort semantics.
1853         (dwarf2_build_frame_info): Call std::sort instead of qsort.
1854         * mdebugread.c (compare_blocks):
1855         (block_is_less_than): ...this, and change to std::sort semantics.
1856         (sort_blocks): Call std::sort instead of qsort.
1857         * objfiles.c (qsort_cmp): Rename to...
1858         (sort_cmp): ...this, and change to std::sort semantics.
1859         (update_section_map): Call std::sort instead of qsort.
1860         * remote.c (compare_pnums): Remove.
1861         (map_regcache_remote_table): Call std::sort instead of qsort.
1862         * utils.c (compare_positive_ints): Remove.
1863         * utils.h (compare_positive_ints): Remove.
1864         * xcoffread.c (compare_lte): Remove.
1865         (arrange_linetable): Call std::sort instead of qsort.
1866
1867 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
1868
1869         * symfile.c (init_entry_point_info): Fix typo.
1870         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1871
1872 2019-10-18  Tom de Vries  <tdevries@suse.de>
1873
1874         * aarch64-tdep.c: Fix typos in comments.
1875         * ada-lang.c: Same.
1876         * ada-tasks.c: Same.
1877         * alpha-tdep.c: Same.
1878         * alpha-tdep.h: Same.
1879         * amd64-nat.c: Same.
1880         * amd64-windows-tdep.c: Same.
1881         * arc-tdep.c: Same.
1882         * arc-tdep.h: Same.
1883         * arch-utils.c: Same.
1884         * arm-nbsd-tdep.c: Same.
1885         * arm-tdep.c: Same.
1886         * ax-gdb.c: Same.
1887         * blockframe.c: Same.
1888         * btrace.c: Same.
1889         * c-varobj.c: Same.
1890         * coff-pe-read.c: Same.
1891         * coffread.c: Same.
1892         * cris-tdep.c: Same.
1893         * darwin-nat.c: Same.
1894         * dbxread.c: Same.
1895         * dcache.c: Same.
1896         * disasm.c: Same.
1897         * dtrace-probe.c: Same.
1898         * dwarf-index-write.c: Same.
1899         * dwarf2-frame-tailcall.c: Same.
1900         * dwarf2-frame.c: Same.
1901         * dwarf2read.c: Same.
1902         * eval.c: Same.
1903         * exceptions.c: Same.
1904         * fbsd-tdep.c: Same.
1905         * findvar.c: Same.
1906         * frame.c: Same.
1907         * frv-tdep.c: Same.
1908         * gnu-v3-abi.c: Same.
1909         * go32-nat.c: Same.
1910         * h8300-tdep.c: Same.
1911         * hppa-tdep.c: Same.
1912         * i386-linux-tdep.c: Same.
1913         * i386-tdep.c: Same.
1914         * ia64-libunwind-tdep.c: Same.
1915         * ia64-tdep.c: Same.
1916         * infcmd.c: Same.
1917         * infrun.c: Same.
1918         * linespec.c: Same.
1919         * linux-nat.c: Same.
1920         * linux-thread-db.c: Same.
1921         * machoread.c: Same.
1922         * mdebugread.c: Same.
1923         * mep-tdep.c: Same.
1924         * mn10300-tdep.c: Same.
1925         * namespace.c: Same.
1926         * objfiles.c: Same.
1927         * opencl-lang.c: Same.
1928         * or1k-tdep.c: Same.
1929         * osabi.c: Same.
1930         * ppc-linux-nat.c: Same.
1931         * ppc-linux-tdep.c: Same.
1932         * ppc-sysv-tdep.c: Same.
1933         * printcmd.c: Same.
1934         * procfs.c: Same.
1935         * record-btrace.c: Same.
1936         * record-full.c: Same.
1937         * remote-fileio.c: Same.
1938         * remote.c: Same.
1939         * rs6000-tdep.c: Same.
1940         * s12z-tdep.c: Same.
1941         * score-tdep.c: Same.
1942         * ser-base.c: Same.
1943         * ser-go32.c: Same.
1944         * skip.c: Same.
1945         * sol-thread.c: Same.
1946         * solib-svr4.c: Same.
1947         * solib.c: Same.
1948         * source.c: Same.
1949         * sparc-nat.c: Same.
1950         * sparc-sol2-tdep.c: Same.
1951         * sparc-tdep.c: Same.
1952         * sparc64-tdep.c: Same.
1953         * stabsread.c: Same.
1954         * stack.c: Same.
1955         * symfile.c: Same.
1956         * symtab.c: Same.
1957         * target-descriptions.c: Same.
1958         * target-float.c: Same.
1959         * thread.c: Same.
1960         * utils.c: Same.
1961         * valops.c: Same.
1962         * valprint.c: Same.
1963         * value.c: Same.
1964         * varobj.c: Same.
1965         * windows-nat.c: Same.
1966         * xcoffread.c: Same.
1967         * xstormy16-tdep.c: Same.
1968         * xtensa-tdep.c: Same.
1969
1970 2019-10-17  Tom Tromey  <tromey@adacore.com>
1971
1972         * configure: Rebuild.
1973         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
1974         in AC_CONFIG_FILES invocation.
1975         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
1976         new-style config.status invocation.
1977
1978 2019-10-17  Tom de Vries  <tdevries@suse.de>
1979
1980         * arm-nbsd-nat.c: Fix typos in comments.
1981         * arm-tdep.c: Same.
1982         * darwin-nat-info.c: Same.
1983         * dwarf2read.c: Same.
1984         * elfread.c: Same.
1985         * event-top.c: Same.
1986         * findvar.c: Same.
1987         * gdbtypes.c: Same.
1988         * hppa-tdep.c: Same.
1989         * i386-tdep.c: Same.
1990         * jit.c: Same.
1991         * main.c: Same.
1992         * mdebugread.c: Same.
1993         * moxie-tdep.c: Same.
1994         * nto-procfs.c: Same.
1995         * osabi.c: Same.
1996         * ppc-linux-tdep.c: Same.
1997         * remote.c: Same.
1998         * riscv-tdep.c: Same.
1999         * s390-tdep.c: Same.
2000         * sh-tdep.c: Same.
2001         * sparc-linux-tdep.c: Same.
2002         * sparc-nat.c: Same.
2003         * stack.c: Same.
2004         * target-descriptions.c: Same.
2005         * top.c: Same.
2006         * varobj.c: Same.
2007
2008 2019-10-16  Tom Tromey  <tom@tromey.com>
2009
2010         * objfiles.h (struct objfile) <original_name>: Now const.
2011
2012 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2013
2014         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2015         pass on to sigsetjmp's second argument.
2016         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2017
2018 2019-10-16  Keith Seitz  <keiths@redhat.com>
2019
2020         PR gdb/23567
2021         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2022         sections whose size is greater than the file size.
2023
2024 2019-10-16  Jim Wilson  <jimw@sifive.com>
2025
2026         * riscv-tdep.c (riscv_gcc_target_options): New.
2027         (riscv_gnu_triplet_regexp): New.
2028         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2029         set_gdbarch_gnu_triplet_regexp.
2030
2031 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2032
2033         * Makefile.in: Add xml-builtin.h.
2034         * features/feature_to_c.sh: Add an include for xml-builtin.h
2035         to ensure that the compiler checks that the types match.
2036         * xml-builtin.h: New file.
2037         * xml-support.c (fetch_xml_builtin): Add missing const.
2038         * xml-support.h: Remove declaration of xml_builtins.
2039
2040 2019-10-16  Tom de Vries  <tdevries@suse.de>
2041
2042         PR tdep/25096
2043         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2044         (amd64_classify_aggregate): ... here.
2045         (amd64_classify_aggregate_field): Handled fiels of nested structs
2046         recursively.
2047
2048 2019-10-16  Tom de Vries  <tdevries@suse.de>
2049
2050         PR tdep/24104
2051         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2052         that handles 'theclass'.
2053
2054 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2055
2056         * linespec.c (decode_digits_ordinary): Update comment.
2057         * make-target-delegates: No longer need to handle VEC case.
2058         * memrange.c (normalize_mem_ranges): Update comment.
2059         * namespace.c (add_using_directive): Update comment.
2060         * objc-lang.c (uniquify_strings): Update comment.
2061         * ppc-linux-nat.c (struct thread_points): Update comment.
2062         * probe.h (find_probes_in_objfile): Update comment.
2063         * target.h (enum flash_preserve_mode): Update comment.
2064         * varobj.c (varobj_restrict_range): Update comment.
2065         * varobj.h (varobj_list_children): Update comment.
2066
2067 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2068
2069         * Makefile.in: Remove references to vec.h and vec.c.
2070         * aarch64-tdep.c: No longer include vec.h.
2071         * ada-lang.c: Likewise.
2072         * ada-lang.h: Likewise.
2073         * arm-tdep.c: Likewise.
2074         * ax.h: Likewise.
2075         * breakpoint.h: Likewise.
2076         * charset.c: Likewise.
2077         * cp-support.h: Likewise.
2078         * dtrace-probe.c: Likewise.
2079         * dwarf2read.c: Likewise.
2080         * extension.h: Likewise.
2081         * gdb_bfd.c: Likewise.
2082         * gdbsupport/gdb_vecs.h: Likewise.
2083         * gdbsupport/vec.c: Remove.
2084         * gdbsupport/vec.h: Remove.
2085         * gdbthread.h: Likewise.
2086         * guile/scm-type.c: Likewise.
2087         * inline-frame.c: Likewise.
2088         * machoread.c: Likewise.
2089         * memattr.c: Likewise.
2090         * memrange.h: Likewise.
2091         * namespace.h: Likewise.
2092         * nat/linux-btrace.h: Likewise.
2093         * osdata.c: Likewise.
2094         * parser-defs.h: Likewise.
2095         * progspace.h: Likewise.
2096         * python/py-type.c: Likewise.
2097         * record-btrace.c: Likewise.
2098         * rust-exp.y: Likewise.
2099         * solib-target.c: Likewise.
2100         * stap-probe.c: Likewise.
2101         * target-descriptions.c: Likewise.
2102         * target-memory.c: Likewise.
2103         * target.h: Likewise.
2104         * varobj.c: Likewise.
2105         * varobj.h: Likewise.
2106         * xml-support.h: Likewise.
2107
2108 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2109
2110         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2111         Update for new std::vector based implementation.
2112         (process_psymtab_comp_unit_reader): Likewise.
2113         (scan_partial_symbols): Likewise.
2114         (recursively_compute_inclusions): Likewise.
2115         (compute_compunit_symtab_includes): Likewise.
2116         (process_imported_unit_die): Likewise.
2117         (queue_and_load_dwo_tu): Likewise.
2118         (follow_die_sig_1): Likewise.
2119         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2120         (typedef dwarf2_per_cu_ptr): Remove.
2121         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2122         function.
2123         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2124         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2125         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2126         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2127         std::vector.
2128
2129 2019-10-15  Tom Tromey  <tromey@adacore.com>
2130
2131         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2132         TID.
2133
2134 2019-10-15  Tom Tromey  <tromey@adacore.com>
2135
2136         * windows-nat.c (windows_nat_target::fetch_registers)
2137         (windows_nat_target::store_registers): Rename "pid" to "tid".
2138
2139 2019-10-15  Tom Tromey  <tromey@adacore.com>
2140
2141         * gdbarch.h, gdbarch.c: Rebuild.
2142         * gdbarch.sh (gcc_target_options): Change return type to
2143         std::string.
2144         * compile/compile.c (get_args): Update.
2145         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2146         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2147         std::string.
2148         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2149         std::string.
2150         * arch-utils.c (default_gcc_target_options): Return std::string.
2151         * arch-utils.h (default_gcc_target_options): Return std::string.
2152         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2153
2154 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2155
2156         * breakpoint.c (breakpoint_chain): Make static.
2157         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2158         of accessing breakpoint_chain.
2159
2160 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2161
2162         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2163         to a gdb::function_view and return value to bool.
2164         * breakpoint.h (iterate_over_breakpoints): Likewise.
2165         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2166         (pop_dummy_frame): Update.
2167         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2168         (gdbscm_breakpoints): Update.
2169         * python/py-breakpoint.c (build_bp_list): Update.
2170         (gdbpy_breakpoints): Update.
2171         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2172         Update.
2173         (bpfinishpy_handle_stop): Update.
2174         (bpfinishpy_handle_exit): Update.
2175         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2176         (svr4_update_solib_event_breakpoints): Update.
2177
2178 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2179
2180         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2181         when unwrapping single-field structs.
2182
2183 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2184
2185         * dwarf2read.c: Remove includes.
2186
2187 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2188
2189         * ui-out.c (ui_out::call_do_message): Silence
2190         -Wformat-nonliteral warning.
2191
2192 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2193
2194         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2195         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2196         include: readline/tilde.h.
2197
2198 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2199
2200         * remote.c (remote_target::get_trace_status): Remove declaration of
2201         trace_regblock_size.
2202
2203 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2204
2205         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2206         (show_user): Remove declaration of cmdlist.
2207         * cli/cli-cmds.h (max_user_call_depth): Declare.
2208         * cli/cli-script.c (execute_user_command): Remove declaration
2209         of max_user_call_depth.
2210
2211 2019-10-11  Jim Wilson  <jimw@sifive.com>
2212
2213         * gdbsupport/print-utils.h (pulongest): Fix comment.
2214         (plongest): Likewise.
2215         (phex): Add missing comment, mention leading zeros.
2216         (phex_nz): Add mention of no leading zeros to comment.
2217
2218         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2219         plongest instead of unsigned long long cast.
2220
2221 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2222
2223         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2224         for external_editor_command and gdbtk_test.
2225
2226 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2227
2228         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2229         * varobj.c (varobjdebug): Move comment to...
2230         * varobj.h (varobjdebug): ...here, and declare.
2231
2232 2019-10-09  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2235         erase_data_content.
2236
2237 2019-10-09  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2240         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2241         * tui/tui-command.c (tui_cmd_window::resize)
2242         (tui_refresh_cmd_win): Update.
2243         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2244         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2245         * tui/tui-data.c (~tui_gen_win_info): Remove.
2246         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2247         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2248         (tui_redisplay_readline, tui_mld_flush)
2249         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2250         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2251         (tui_data_window::erase_data_content)
2252         (tui_data_item_window::rerender)
2253         (tui_data_item_window::refresh_window): Update.
2254         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2255         (box_win, tui_gen_win_info::make_window)
2256         (tui_gen_win_info::make_visible): Update.
2257         (tui_delete_win): Remove.
2258         * tui/tui-winsource.c
2259         (tui_source_window_base::do_erase_source_content): Update.
2260         (tui_show_source_line, tui_source_window_base::update_tab_width)
2261         (tui_source_window_base::update_exec_info): Update.
2262         * tui/tui-data.h (struct curses_deleter): New.
2263         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2264         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2265
2266 2019-10-09  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2269
2270 2019-10-09  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2273         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2274
2275 2019-10-09  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2278         window height directly.
2279         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2280         declare.
2281         * tui/tui-layout.c (tui_default_win_height): Remove.
2282         (tui_default_win_viewport_height): Remove.
2283
2284 2019-10-09  Tom Tromey  <tom@tromey.com>
2285
2286         * tui/tui.h: Remove comments.
2287
2288 2019-10-09  Tom de Vries  <tdevries@suse.de>
2289
2290         * python/lib/gdb/printer/bound_registers.py: Use
2291         '^builtin_type_bound128' as regexp argument for
2292         add_builtin_pretty_printer.
2293
2294 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2295
2296         * guile/guile.c (guile_extension_script_ops): Remove forward
2297         declaration and mark as static.
2298         (guile_script_ops): Likewise.
2299         (extension_language_guile): Move further down in the file so
2300         it can reference the definitions for guile_{extension_,}script_ops.
2301
2302 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2303
2304         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2305         except SORTL, DFLTCC, and KDSA.
2306
2307 2019-10-08  Tom Tromey  <tromey@adacore.com>
2308
2309         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2310         (struct safe_symbol_file_add_args): Remove.
2311
2312 2019-10-08  Tom Tromey  <tromey@adacore.com>
2313
2314         * windows-nat.c: Don't include buildsym-legacy.h.
2315
2316 2019-10-08  Tom Tromey  <tromey@adacore.com>
2317
2318         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2319
2320 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2321
2322         * gdbtypes.c (overload_debug): Move comment to header.
2323         * gdbtypes.h (overload_debug): Declare.
2324         * valops.c: Remove declaration of overload_debug, instead
2325         include gdbtypes.h.
2326
2327 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2328
2329         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2330         through _().
2331         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2332         move comment...
2333         * language.h (lang_frame_mismatch_warn): ... here. Also add
2334         declaration.
2335         * top.c (lang_frame_mismatch_warn): Remove declaration.
2336         (check_frame_language_change): Pass lang_frame_mismatch_warn
2337         through _().
2338
2339 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2340
2341         * c-lang.h (vtbl_ptr_name): Declare.
2342         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2343         it from the header.
2344         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2345
2346 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2347
2348         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2349         gdb_static_assert.
2350
2351 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2352
2353         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2354         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2355         * ctfread.c: New file.
2356         * ctfread.h: New file.
2357         * elfread.c: Include ctfread.h.
2358         (struct elfinfo text_p): New member ctfsect.
2359         (elf_locate_sections): Mark CTF section.
2360         (elf_symfile_read): Call elfctf_build_psymtabs.
2361         * Makefile.in (LIBCTF): Add.
2362         (CLIBS): Use it.
2363         (CDEPS): Likewise.
2364         (DIST): Add ctfread.c.
2365
2366 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * ctfread.c (struct nextfield): Renamed to ...
2369         (struct ctf_nextfield): ... this.
2370         (struct field_info): Renamed to ...
2371         (strut ctf_field_info): ... this.
2372         (attach_fields_to_type): Update for renamed structures.
2373         (ctf_add_member_cb): Likewise.
2374         (ctf_add_enum_member_cb): Likewise.
2375         (process_struct_members): Likewise.
2376         (process_enum_type): Likewise.
2377
2378 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2379
2380         * tracectf.h: Rename, was ctf.h.
2381         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2382         * tracefile.c: Likewise.
2383         * tracepoint.c: Remove unused include ctf.h.
2384         * mi/mi-main.c: Likewise.
2385         * Makefile.in Replace ctf.c with tracectf.c.
2386
2387 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2388
2389         * version.in: Change version number to "9.0.50.DATE-git".
2390
2391 2019-10-03  Tom Tromey  <tom@tromey.com>
2392
2393         PR rust/24976:
2394         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2395
2396 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2397
2398         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2399         cp_search_name_hash.
2400         * NEWS: Add entry about nested function support.
2401
2402 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2403             Andrew Burgess  <andrew.burgess@embecosm.com>
2404
2405         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2406         for nested static variables when searchin VAR_DOMAIN.
2407         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2408         global scope, update comment.
2409         (add_partial_subprogram): Call add_partial_subprogram recursively
2410         for nested subroutines when processinng Fortran.
2411         (load_partial_dies): Process the child entities of a subprogram
2412         when processing Fortran.
2413         (partial_die_parent_scope): Handle building scope
2414         for Fortran nested functions.
2415         (process_die): Record that nested functions have a scope.
2416         (new_symbol): Always record Fortran subprograms on the global
2417         symbol list.
2418         (determine_prefix): How to build the prefix for Fortran
2419         subprograms.
2420
2421 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2422
2423         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2424         have just sent the thread a SIGSTOP and are waiting for it to
2425         arrive.
2426
2427 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2428
2429         * btrace.c (btrace_add_pc): Remove whitespace before the template
2430         parameter in 'std::vector <...>'.
2431         (parse_xml_btrace_block): Likewise.
2432         (btrace_maint_decode_pt): Likewise.
2433         (btrace_maint_update_packets): Likewise.
2434         (btrace_maint_print_packets): Likewise.
2435         * btrace.h (struct btrace_maint_info): Likewise.
2436         * dwarf2read.c (struct type_unit_group): Likewise.
2437         (build_type_psymtabs_reader): Likewise.
2438         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2439         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2440         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2441
2442 2019-10-03  Tom de Vries  <tdevries@suse.de>
2443
2444         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2445         the first line of the help text for set/show style metadata.
2446
2447 2019-10-02  Tom Tromey  <tromey@adacore.com>
2448
2449         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2450         * gdbsupport/common-inferior.c: New file.
2451         * infcmd.c (startup_with_shell): Don't define.
2452         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2453         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2454         * inferior.h (startup_with_shell): Don't declare.
2455
2456 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2457
2458         * gdbsupport/gdb_assert.h: Include errors.h.
2459         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2460
2461 2019-10-02  Tom Tromey  <tromey@adacore.com>
2462
2463         * NEWS: Add $_ada_exception entry.
2464         * ada-lang.c (struct ada_catchpoint): Add constructor.
2465         <m_kind>: New member.
2466         (allocate_location_exception, re_set_exception): Remove
2467         "ex" parameter.
2468         (should_stop_exception): Compute $_ada_exception.
2469         (check_status_exception, print_it_exception)
2470         (print_one_exception, print_mention_exception): Remove
2471         "ex" parameter.
2472         (allocate_location_catch_exception, re_set_catch_exception)
2473         (check_status_exception, print_it_catch_exception)
2474         (print_one_catch_exception, print_mention_catch_exception)
2475         (print_recreate_catch_exception)
2476         (allocate_location_catch_exception_unhandled)
2477         (re_set_catch_exception_unhandled)
2478         (check_status_exception, print_it_catch_exception_unhandled)
2479         (print_one_catch_exception_unhandled)
2480         (print_mention_catch_exception_unhandled)
2481         (print_recreate_catch_exception_unhandled)
2482         (allocate_location_catch_assert, re_set_catch_assert)
2483         (check_status_assert, print_it_catch_assert)
2484         (print_one_catch_assert, print_mention_catch_assert)
2485         (print_recreate_catch_assert)
2486         (allocate_location_catch_handlers, re_set_catch_handlers)
2487         (check_status_handlers, print_it_catch_handlers)
2488         (print_one_catch_handlers, print_mention_catch_handlers)
2489         (print_recreate_catch_handlers): Remove.
2490         (create_ada_exception_catchpoint): Update.
2491         (initialize_ada_catchpoint_ops): Update.
2492
2493 2019-10-02  Tom Tromey  <tromey@adacore.com>
2494
2495         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2496         (create_excep_cond_exprs): Simplify exception string computation.
2497         (ada_exception_catchpoint_cond_string): Likewise.
2498
2499 2019-10-02  Tom Tromey  <tromey@adacore.com>
2500
2501         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2502         * ada-lang.c (lesseq_defined_than): Handle
2503         LOC_STATIC.
2504         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2505         parameter.
2506         (dwarf2_has_info): Likewise.
2507         (new_symbol): Set maybe_copied on symbol when
2508         appropriate.
2509         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2510         parameter.
2511         <can_copy>: New member.
2512         * elfread.c (record_minimal_symbol): Set maybe_copied
2513         on symbol when appropriate.
2514         (elf_symfile_read): Update call to dwarf2_has_info.
2515         * minsyms.c (lookup_minimal_symbol_linkage): New
2516         function.
2517         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2518         * symtab.c (get_symbol_address, get_msymbol_address):
2519         New functions.
2520         * symtab.h (get_symbol_address, get_msymbol_address):
2521         Declare.
2522         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2523         maybe_copied.
2524         (struct symbol, struct minimal_symbol) <maybe_copied>:
2525         New member.
2526
2527 2019-10-02  Tom Tromey  <tromey@adacore.com>
2528
2529         * source.c (struct current_source_location): New.
2530         (current_source_key): New global.
2531         (current_source_symtab, current_source_line)
2532         (current_source_pspace): Remove.
2533         (get_source_location): New function.
2534         (get_current_source_symtab_and_line)
2535         (set_default_source_symtab_and_line)
2536         (set_current_source_symtab_and_line)
2537         (clear_current_source_symtab_and_line, select_source_symtab)
2538         (info_source_command, print_source_lines_base)
2539         (info_line_command, search_command_helper, _initialize_source):
2540         Update.
2541
2542 2019-10-02  Tom Tromey  <tromey@adacore.com>
2543
2544         * source.c (select_source_symtab): Don't call
2545         decode_line_with_current_source.
2546
2547 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2548
2549         * symtab.c (lookup_global_symbol): Search global block.
2550
2551 2019-10-02  Tom Tromey  <tromey@adacore.com>
2552
2553         * coffread.c (process_coff_symbol): Update.
2554         * dwarf2read.c (var_decode_location, new_symbol): Update.
2555         * mdebugread.c (parse_symbol): Update.
2556         * objfiles.c (relocate_one_symbol): Update.
2557         * stabsread.c (define_symbol, fix_common_block)
2558         (scan_file_globals): Update.
2559         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2560         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2561         * xcoffread.c (process_xcoff_symbol): Update.
2562
2563 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2564
2565         * MAINTAINERS: Update my email address.
2566
2567 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2568
2569         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2570         std::vector.
2571         (build_type_psymtabs_reader): Update for std::vector.
2572         (build_type_psymtab_dependencies): Likewise.
2573         * dwarf2read.h: Remove use of DEF_VEC_P.
2574         (typedef sig_type_ptr): Delete.
2575
2576 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2577
2578         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2579         to std::vector.
2580         (btrace_maint_decode_pt): Likewise, and move allocation of the
2581         vector outside of the loop.
2582         (btrace_maint_update_packets): Update to handle change from VEC to
2583         std::vector.
2584         (btrace_maint_print_packets): Likewise.
2585         (maint_info_btrace_cmd): Likewise.
2586         * btrace.h: Remove use of DEF_VEC_O.
2587         (typedef btrace_pt_packet_s): Delete.
2588         (struct btrace_maint_info) <packets>: Change fromm VEC to
2589         std::vector.
2590         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2591
2592 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2595         make accesses into the vector constant references.
2596         (btrace_add_pc): Update for std::vector.
2597         (btrace_stitch_bts): Likewise.
2598         (parse_xml_btrace_block): Likewise.
2599         (btrace_maint_update_packets): Likewise.
2600         (btrace_maint_print_packets): Likewise.
2601         (maint_info_btrace_cmd): Likewise.
2602         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2603         std::vector.
2604         (btrace_data::empty): Likewise.
2605         (btrace_data_append): Likewise.
2606         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2607         (typedef btrace_block_s): Delete.
2608         (struct btrace_block): Add constructor.
2609         (struct btrace_data_bts) <blocks>: Change to std::vector.
2610         * nat/linux-btrace.c (perf_event_read_bts): Update for
2611         std::vector.
2612         (linux_read_bts): Likewise.
2613
2614 2019-10-01  Tom Tromey  <tom@tromey.com>
2615
2616         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2617
2618 2019-10-01  Tom Tromey  <tom@tromey.com>
2619
2620         * stack.c (print_frame, info_frame_command_core): Use
2621         styled_string.
2622         * linux-thread-db.c (try_thread_db_load_1)
2623         (try_thread_db_load_from_pdir_1): Use styled_string.
2624         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2625         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2626         (maybe_print_unsupported_script_warning)
2627         (maybe_print_script_not_found_warning): Use styled_string.
2628         * ada-lang.c (user_select_syms): Use styled_string.
2629
2630 2019-10-01  Tom Tromey  <tom@tromey.com>
2631
2632         * p-lang.c (pascal_printstr): Use metadata style.
2633         * value.c (show_convenience): Use metadata style.
2634         * valprint.c (valprint_check_validity, val_print_optimized_out)
2635         (val_print_not_saved, val_print_unavailable)
2636         (val_print_invalid_address, generic_val_print, val_print)
2637         (value_check_printable, val_print_array_elements): Use metadata
2638         style.
2639         * ui-out.h (class ui_out) <field_fmt>: New overload.
2640         <do_field_fmt>: Add style parameter.
2641         * ui-out.c (ui_out::field_fmt): New overload.
2642         * typeprint.c (type_print_unknown_return_type)
2643         (val_print_not_allocated, val_print_not_associated): Use metadata
2644         style.
2645         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2646         parameter.
2647         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2648         * tracepoint.c (tvariables_info_1): Use metadata style.
2649         * stack.c (print_frame_arg, print_frame_info, print_frame)
2650         (info_frame_command_core): Use metadata style.
2651         * skip.c (info_skip_command): Use metadata style.
2652         * rust-lang.c (rust_print_enum): Use metadata style.
2653         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2654         metadata style.
2655         * python/py-framefilter.c (py_print_single_arg): Use metadata
2656         style.
2657         * printcmd.c (do_one_display, print_variable_and_value): Use
2658         metadata style.
2659         * p-valprint.c (pascal_val_print)
2660         (pascal_object_print_value_fields): Use metadata style.
2661         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2662         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2663         parameter.
2664         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2665         * m2-valprint.c (m2_print_long_set): Use metadata style.
2666         * m2-typeprint.c (m2_print_type): Use metadata style.
2667         * infcmd.c (print_return_value_1): Use metadata style.
2668         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2669         * f-valprint.c (info_common_command_for_block): Use metadata
2670         style.
2671         * f-typeprint.c (f_type_print_base): Use metadata style.
2672         * expprint.c (print_subexp_standard): Use metadata style.
2673         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2674         * cli/cli-style.h (class cli_style_option): Add constructor.
2675         (metadata_style): Declare.
2676         * cli/cli-style.c (metadata_style): New global.
2677         (_initialize_cli_style): Register metadata style.
2678         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2679         parameter.
2680         * cli-out.c (cli_ui_out::do_field_fmt): Update.
2681         * c-typeprint.c (c_type_print_base_struct_union)
2682         (c_type_print_base_1): Use metadata style.
2683         * breakpoint.c (watchpoint_value_print)
2684         (print_one_breakpoint_location): Use metadata style.
2685         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2686         style.
2687         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2688         style.
2689         * ada-valprint.c (val_print_packed_array_elements, printstr)
2690         (print_field_values, ada_val_print_ref, ada_val_print): Use
2691         metadata style.
2692         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2693         style.
2694         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2695         style.
2696         * ada-lang.c (user_select_syms): Use metadata style.
2697
2698 2019-10-01  Tom Tromey  <tom@tromey.com>
2699
2700         * cli/cli-cmds.c (pwd_command): Style output.
2701
2702 2019-10-01  Pedro Alves  <palves@redhat.com>
2703             Tom Tromey  <tom@tromey.com>
2704
2705         * symtab.c (print_symbol_info): Use %ps.
2706         (print_msymbol_info): Use %ps.
2707         * symfile.c (symbol_file_add_with_addrs): Use %ps.
2708         * printcmd.c (print_variable_and_value): Use %ps.
2709         * macrocmd.c (show_pp_source_pos): Use %ps.
2710         * infrun.c (print_exited_reason): Use ui_out::message.
2711         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2712         (describe_other_breakpoints): Use ui_out::message and new
2713         formats.
2714         (say_where): Use new formats.
2715         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2716         and new formats.
2717
2718 2019-10-01  Pedro Alves  <palves@redhat.com>
2719             Tom Tromey  <tom@tromey.com>
2720
2721         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2722         (test_gdb_formats): New function.
2723         (run_tests): Call it.
2724         (test_format_specifier): Update.
2725         * utils.h (fputs_filtered): Update comment.
2726         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2727         (fputs_styled_unfiltered): Declare.
2728         * utils.c (fputs_styled_unfiltered): New function.
2729         (vfprintf_maybe_filtered): Add gdbfmt parameter.
2730         (vfprintf_filtered): Update.
2731         (vfprintf_unfiltered, vprintf_filtered): Update.
2732         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2733         * ui-out.h (enum ui_out_flag) <unfiltered_output,
2734         disallow_ui_out_field>: New constants.
2735         (enum class field_kind): New.
2736         (struct base_field_s, struct signed_field_s): New.
2737         (signed_field): New function.
2738         (struct string_field_s): New.
2739         (string_field): New function.
2740         (struct styled_string_s): New.
2741         (styled_string): New function.
2742         (class ui_out) <message>: Add comment.
2743         <vmessage, call_do_message>: New methods.
2744         <do_message>: Add style parameter.
2745         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2746         methods.
2747         (ui_out::message): Rewrite.
2748         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2749         parameter.
2750         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2751         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2752         gdb_extensions parameter.
2753         (class format_piece): Add parameter to constructor.
2754         (n_int_args): New field.
2755         * gdbsupport/format.c (format_pieces::format_pieces): Add
2756         gdb_extensions parameter.  Handle '*'.
2757         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2758         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
2759         vfprintf_styled_no_gdbfmt.
2760         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2761         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2762         unfiltered output.
2763         * ui-style.h (struct ui_file_style) <ptr>: New method.
2764
2765 2019-10-01  Tom Tromey  <tom@tromey.com>
2766
2767         * unittests/format_pieces-selftests.c: Update.  Add final format.
2768         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2769         empty literal pieces.
2770
2771 2019-10-01  Tom Tromey  <tom@tromey.com>
2772
2773         * ui-out.h (enum class ui_out_style_kind): Remove.
2774         (class ui_out) <field_string, field_stsream, do_field_string>:
2775         Change type of "style".
2776         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2777         (ui_out::field_string): Update.
2778         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2779         of "style".
2780         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2781         * tracepoint.c (print_one_static_tracepoint_marker): Update.
2782         * stack.c (print_frame_arg, print_frame_info, print_frame):
2783         Update.
2784         * source.c (print_source_lines_base): Update.
2785         * solib.c (info_sharedlibrary_command): Update.
2786         * skip.c (info_skip_command): Update.
2787         * record-btrace.c (btrace_call_history_src_line)
2788         (btrace_call_history): Update.
2789         * python/py-framefilter.c (py_print_frame): Update.
2790         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2791         "style".
2792         * mi/mi-out.c (mi_ui_out::do_table_header)
2793         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2794         (mi_ui_out::do_field_string): Update.
2795         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2796         Update.
2797         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2798         "style".
2799         * cli-out.c (cli_ui_out::do_table_header)
2800         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2801         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2802         (cli_ui_out::do_field_fmt): Update.
2803         * breakpoint.c (print_breakpoint_location): Update.
2804         (update_static_tracepoint): Update.
2805
2806 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2807
2808         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2809         conversion of gdb_datadir.
2810         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2811         remove not needed c_str ().
2812
2813 2019-09-30  Ali Tamur <tamur@google.com>
2814
2815         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2816         (dwarf2_string_attr): Likewise.
2817
2818 2019-09-30  Ali Tamur <tamur@google.com>
2819
2820         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2821         (process_full_type_unit): Likewise.
2822         (dump_die_shallow): Likewise.
2823         (cu_debug_loc_section): Likewise.
2824
2825 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
2826
2827         * minsyms.c (compare_minimal_symbols): Rename to...
2828         (minimal_symbol_is_less_than): ...this, and adjust to STL
2829         conventions (return bool, take arguments as references)
2830         (minimal_symbol_reader::install): Call std::sort instead
2831         of qsort.
2832
2833 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
2834
2835         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2836         hash and why.
2837         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2838         msymbol_hash, msymbol_demangled_hash>: Improve comments.
2839
2840 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
2841
2842         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2843         * psympriv.h (add_psymbol_to_list): Move comment here and update
2844         it.
2845
2846 2019-09-29  Tom de Vries  <tdevries@suse.de>
2847
2848         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2849         Use $tmpdir/$(basename "$output_file").dwz instead of
2850         "${output_file}.dwz".
2851
2852 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
2853
2854         PR gdb/25045
2855         * hppa-linux-nat.c: Include gdbarch.h.
2856
2857 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
2858
2859         * blockframe.c (find_pc_partial_function): Change return type to bool.
2860         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2861         * minsyms.c (in_gnu_ifunc_stub): Likewise.
2862         (stub_gnu_ifunc_resolve_name): Likewise.
2863         * symtab.c (compare_filenames_for_search): Likewise.
2864         (compare_glob_filenames_for_search): Likewise.
2865         (matching_obj_sections): Likewise.
2866         (symbol_matches_domain): Likewise.
2867         (find_line_symtab): Change out param EXACT_MATCH to bool *.
2868         (find_line_pc): Change return type to bool.
2869         (find_line_pc_range): Likewise.
2870         (producer_is_realview): Likewise.
2871         * symtab.h (symbol_matches_domain): Likewise.
2872         (find_pc_partial_function): Likewise.
2873         (find_pc_line_pc_range): Likewise.
2874         (in_gnu_ifunc_stub): Likewise.
2875         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2876         (find_line_pc): Likewise.
2877         (find_line_pc_range): Likewise.
2878         (matching_obj_sections): Likewise.
2879         (find_line_symtab): Change out parameter to bool.
2880         (producer_is_realview): Change return type to bool.
2881         (compare_filenames_for_search): Likewise.
2882         (compare_glob_filenames_for_search): Likewise.
2883
2884 2019-09-26  Tom Tromey  <tom@tromey.com>
2885
2886         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2887         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2888         * gdb_usleep.h: Remove.
2889         * gdb_usleep.c: Remove.
2890         * utils.c: Don't include gdb_usleep.h.
2891
2892 2019-09-26  Tom Tromey  <tromey@adacore.com>
2893
2894         * python/py-type.c (type_to_type_object): Call check_typedef
2895         for stub types.
2896
2897 2019-09-26  Tom Tromey  <tom@tromey.com>
2898
2899         * utils.h (initialize_utils): Don't declare.
2900         * top.c (gdb_init): Don't call initialize_utils.
2901         * utils.c (initialize_utils): Remove.  Move contents...
2902         (_initialize_utils): ... here.
2903
2904 2019-09-25  Tom Tromey  <tom@tromey.com>
2905
2906         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
2907         * utils.h (make_hex_string): Don't declare.
2908         * utils.c (make_hex_string): Remove.
2909
2910 2019-09-24  Tom de Vries  <tdevries@suse.de>
2911
2912         PR gdb/23815
2913         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
2914         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
2915
2916 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
2917
2918         * NEWS: Mention new simulator port for PRU.
2919
2920 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
2921
2922         * ada-exp.y (write_object_remaining): Update.
2923         * ada-lang.c (ada_decode): Return a std::string instead of a char*
2924         and eliminate the static buffer.
2925         (ada_decode_symbol): Update.
2926         (ada_la_decode): Update.
2927         (ada_sniff_from_mangled_name): Update.
2928         (is_valid_name_for_wild_match): Update.
2929         (ada_lookup_name_info::matches): Update and simplify.
2930         (name_matches_regex): Update.
2931         (ada_add_global_exceptions): Update.
2932         * ada-lang.h (ada_decode): Update signature.
2933         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
2934         * dwarf-index-write.c (debug_names::insert): Update.
2935
2936 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2937
2938         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
2939         formatting.
2940
2941 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2942
2943         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
2944         Change "nonzero" to "true" in documentation.
2945
2946 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
2947
2948         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
2949         (_initialize_darwin_solib): Don't set
2950         darwin_so_ops.lookup_lib_global_symbol.
2951         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
2952         set_gdbarch_iterate_over_objfiles_in_search_order.
2953         (elf_lookup_lib_symbol): Rename to...
2954         (svr4_iterate_over_objfiles_in_search_order): this, and update
2955         to iterate semantics.
2956         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2957         * solib.c (solib_global_lookup): Remove.
2958         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2959         (solib_global_lookup): Remove.
2960         * symtab.c (lookup_global_or_static_symbol): Remove call to
2961         solib_global_lookup.
2962
2963 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2964
2965         * NEWS: Move entries about default MI version now being
2966         version 3, and about the GDB/MI fix for multi-location
2967         breakpoints to the "since GDB 8.3" section.
2968
2969 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2970
2971         GDB 8.3.1 released.
2972
2973 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
2974
2975         * NEWS: Mention that Cell/B.E. debugging support was removed.
2976         * MAINTAINERS: Remove spu target.
2977
2978         * config/djgpp/fnchange.lst: Remove entries for removed files.
2979
2980         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
2981         spu-multiarch.o, and spu-tdep.o.
2982         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
2983         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
2984         spu-multiarch.c, and spu-tdep.c.
2985         * spu-linux-nat.c: Remove file.
2986         * spu-multiarch.c: Remove file.
2987         * spu-tdep.c: Remove file.
2988         * spu-tdep.h: Remove file.
2989         * solib-spu.c: Remove file.
2990         * solib-spu.h: Remove file.
2991
2992         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2993         * configure.nat (spu-linux): Remove.
2994         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2995         solib-multiarch.o from gdb_target_obs.
2996         (spu*-*-*): Remove.
2997
2998         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2999         feature flag.
3000         (ppc_linux_no_features): Update.
3001         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3002         Cell/B.E. support.
3003         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3004         (tdesc_powerpc_cell64l): Likewise.
3005         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3006         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3007         Cell/B.E. support.
3008         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3009         Do not include "features/rs6000/powerpc-cell32l.c" or
3010         "features/rs6000/powerpc-cell64l.c".
3011         (ppc_linux_spu_section): Remove.
3012         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3013         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3014         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3015         (ppc_linux_spe_context_lookup): Remove.
3016         (ppc_linux_spe_context_inferior_created): Remove.
3017         (ppc_linux_spe_context_solib_loaded): Remove.
3018         (ppc_linux_spe_context_solib_unloaded): Remove.
3019         (ppc_linux_spe_context): Remove.
3020         (struct ppu2spu_cache): Remove.
3021         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3022         (struct ppu2spu_data): Remove.
3023         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3024         ppu2spu_unwind): Remove.
3025         (ppc_linux_init_abi): Remove Cell/B.E. support.
3026         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3027
3028         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3029         (rs6000/powerpc-cell64l-expedite): Likewise
3030         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3031         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3032         rs6000/powerpc-cell64l.xml.
3033         * features/rs6000/powerpc-cell32l.xml: Remove.
3034         * features/rs6000/powerpc-cell64l.xml: Likewise.
3035         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3036         * features/rs6000/powerpc-cell64l.c: Likewise.
3037         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3038         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3039         * regformats/reg-spu.dat: Remove.
3040
3041         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3042         * corelow.c (struct spuid_list): Remove.
3043         (add_to_spuid_list): Remove.
3044         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3045         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3046         (remote_protocol_features): Remove associated entries.
3047         (_initialize_remote): No longer initialize them.
3048         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3049         * linux-nat.c (SPUFS_MAGIC): Remove.
3050         (linux_proc_xfer_spu): Remove.
3051         (spu_enumerate_spu_ids): Remove.
3052         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3053         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3054         (linux_make_corefile_notes): No longer call it.
3055
3056         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3057         (cooked_write_test): Likewise.
3058
3059 2019-09-20  Tom Tromey  <tom@tromey.com>
3060
3061         * NEWS: Mention case-sensitivity of TUI commands.
3062         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3063         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3064         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3065
3066 2019-09-20  Tom Tromey  <tom@tromey.com>
3067
3068         * tui/tui-source.c (tui_source_window::set_contents): Use
3069         make_unique_xstrdup.
3070         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3071         make_unique_xstrdup.
3072
3073 2019-09-20  Tom Tromey  <tom@tromey.com>
3074
3075         * tui/tui-data.c: Remove separator comments.
3076         * tui/tui-layout.c: Remove separator comments.
3077         * tui/tui-win.c: Remove separator comments.
3078         * tui/tui-wingeneral.c: Remove separator comments.
3079
3080 2019-09-20  Tom Tromey  <tom@tromey.com>
3081
3082         * tui/tui.h (strcat_to_buf): Don't declare.
3083         * tui/tui.c (strcat_to_buf): Remove.
3084
3085 2019-09-20  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3088         from "fullname".
3089         * tui/tui-source.c (tui_source_window::set_contents)
3090         (tui_source_window::location_matches_p)
3091         (tui_source_window::maybe_update): Update.
3092
3093 2019-09-20  Tom Tromey  <tom@tromey.com>
3094
3095         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3096         Update.
3097         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3098         prefix.
3099         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3100         (tui_data_window::line_from_reg_element_no)
3101         (tui_data_window::first_reg_element_no_inline)
3102         (tui_data_window::show_registers)
3103         (tui_data_window::show_register_group)
3104         (tui_data_window::display_registers_from)
3105         (tui_data_window::display_registers_from_line)
3106         (tui_data_window::first_data_item_displayed)
3107         (tui_data_window::delete_data_content_windows)
3108         (tui_data_window::erase_data_content)
3109         (tui_data_window::do_scroll_vertical)
3110         (tui_data_window::refresh_window)
3111         (tui_data_window::check_register_values): Update.
3112
3113 2019-09-20  Tom Tromey  <tom@tromey.com>
3114
3115         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3116         (struct tui_locator_window) <full_name, proc_name>: Now
3117         std::string.
3118         * tui/tui-stack.c (tui_locator_window::make_status_line)
3119         (tui_locator_window::set_locator_fullname)
3120         (tui_locator_window::set_locator_info): Update.
3121         * tui/tui-source.c (tui_source_window::set_contents)
3122         (tui_source_window::showing_source_p): Update.
3123
3124 2019-09-20  Tom Tromey  <tom@tromey.com>
3125
3126         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3127         Don't call tui_locator_win_info_ptr.
3128
3129 2019-09-20  Tom Tromey  <tom@tromey.com>
3130
3131         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3132
3133 2019-09-20  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3136         height for locator.
3137         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3138         * tui/tui-layout.c (show_source_disasm_command, show_data)
3139         (show_source_or_disasm_and_command): Use 1 as height for locator.
3140
3141 2019-09-20  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui.c (tui_enable): Update.
3144         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3145         Update.
3146         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3147         Update.
3148         * tui/tui-data.c (win_resized): Now bool.
3149         (tui_win_resized): Return bool.
3150         (tui_set_win_resized_to): Accept a bool.
3151
3152 2019-09-20  Tom Tromey  <tom@tromey.com>
3153
3154         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3155         Change type of "refresh_values_only".
3156         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3157         type of "refresh_values_only".
3158
3159 2019-09-20  Tom Tromey  <tom@tromey.com>
3160
3161         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3162         std::string.
3163         (tui_disassemble): Add "pos" parameter.
3164         (tui_disasm_window::set_contents): Simplify.
3165
3166 2019-09-20  Tom Tromey  <tom@tromey.com>
3167
3168         * tui/tui-winsource.h (struct tui_source_window_base)
3169         <show_source_content>: Now private.
3170         * tui/tui-winsource.c
3171         (tui_source_window_base::show_source_content): Don't handle empty
3172         content case.
3173
3174 2019-09-20  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-layout.c (show_source_disasm_command)
3177         (show_source_or_disasm_and_command): Don't call
3178         show_source_content.
3179
3180 2019-09-20  Tom Tromey  <tom@tromey.com>
3181
3182         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3183         Declare.
3184         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3185         from tui_make_status_line.
3186         (tui_locator_window::rerender): Update.
3187
3188 2019-09-20  Tom Tromey  <tom@tromey.com>
3189
3190         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3191         (tui_locator_window::rerender): Update.
3192
3193 2019-09-20  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-winsource.h (struct tui_source_window_base)
3196         <~tui_source_window_base>: Don't declare.
3197         <fullname>: Remove.
3198         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3199         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3200         member.
3201         * tui/tui-source.c (tui_source_window::set_contents): Update.
3202         (tui_source_window::location_matches_p)
3203         (tui_source_window::maybe_update): Update.
3204
3205 2019-09-20  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-winsource.h (~tui_source_element): Remove.
3208         (tui_source_element): Update.
3209         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3210         * tui/tui-winsource.c (tui_show_source_line): Update.
3211         * tui/tui-source.c (tui_source_window::set_contents): Update.
3212         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3213
3214 2019-09-20  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3217         declare.
3218         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3219         tui_clear_source_windows_detail.
3220         * tui/tui-winsource.h (struct tui_source_window_base)
3221         <clear_detail>: Don't declare.
3222         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3223         Remove.
3224         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3225
3226 2019-09-20  Tom Tromey  <tromey@adacore.com>
3227
3228         PR ada/24919:
3229         * block.c (contained_in): Fix final return value.
3230
3231 2019-09-20  Alan Modra  <amodra@gmail.com>
3232
3233         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3234         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3235         (read_indirect_string_from_dwz): Use bfd accessor.
3236         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3237         * machoread.c (macho_symfile_read_all_oso): Likewise.
3238         * solib.c (solib_bfd_open): Likewise.
3239
3240 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3241
3242         * eval.c: Move declaration of overload_resolution to...
3243         * value.h: ...here.
3244
3245 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3246
3247         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3248         * arm-linux-tdep.c: Likewise.
3249         * arm-nbsd-nat.c: Likewise.
3250         * arm-tdep.h: Declare arm_apcs_32.
3251         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3252
3253 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3254
3255         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3256         * dwarf2read.h: Declare dwarf_always_disassemble.
3257
3258 2019-09-19  Tom de Vries  <tdevries@suse.de>
3259
3260         PR gdb/25009
3261         * source-cache.c (source_cache::ensure): Catch exception thrown during
3262         construction of the highlighter.
3263
3264 2019-09-18  Alan Modra  <amodra@gmail.com>
3265
3266         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3267         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3268         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3269         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3270         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3271         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3272         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3273         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3274         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3275         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3276         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3277         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3278         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3279         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3280         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3281         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3282         * mi/mi-interp.c: Update throughout for bfd section macro and
3283         function changes.
3284         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3285         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3286
3287 2019-09-18  Tom Tromey  <tom@tromey.com>
3288
3289         * NEWS: Add entry.
3290         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3291         call rl_initialize.
3292         (tui_enable): Do not call rl_initialize.
3293
3294 2019-09-18  Christian Groessler  <chris@groessler.org>
3295
3296         * alpha-linux-nat.c: Include gdbarch.h.
3297
3298 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3299
3300         * ui-file.c: Include cli/cli-style.h.
3301         (term_cli_styling): Remove cli_styling declaration.
3302
3303 2019-09-18  Alan Modra  <amodra@gmail.com>
3304
3305         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3306         to bfd_asymbol_section.
3307
3308 2019-09-18  Alan Modra  <amodra@gmail.com>
3309
3310         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3311         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3312         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3313
3314 2019-09-18  Alan Modra  <amodra@gmail.com>
3315
3316         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3317         * spu-linux-nat.c (spu_bfd_open): Likewise.
3318
3319 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3320
3321         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3322         to bool to match definition in dwarf2read.c.
3323
3324 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3325
3326         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3327         (print_signatures): Likewise.
3328         (trust_pad_over_xvs): Likewise.
3329         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3330         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3331         * arm-linux-nat.c (arm_apcs_32): Likewise.
3332         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3333         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3334         * arm-tdep.c (arm_debug): Likewise.
3335         (arm_apcs_32): Likewise.
3336         * auto-load.c (debug_auto_load): Likewise.
3337         (auto_load_gdb_scripts): Likewise.
3338         (global_auto_load): Likewise.
3339         (auto_load_local_gdbinit): Likewise.
3340         (auto_load_local_gdbinit_loaded): Likewise.
3341         * auto-load.h (global_auto_load): Likewise.
3342         (auto_load_local_gdbinit): Likewise.
3343         (auto_load_local_gdbinit_loaded): Likewise.
3344         * breakpoint.c (disconnected_dprintf): Likewise.
3345         (breakpoint_proceeded): Likewise.
3346         (automatic_hardware_breakpoints): Likewise.
3347         (always_inserted_mode): Likewise.
3348         (target_exact_watchpoints): Likewise.
3349         (_initialize_breakpoint): Update.
3350         * breakpoint.h (target_exact_watchpoints): Change to bool.
3351         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3352         * cli/cli-cmds.c (trace_commands): Likewise.
3353         * cli/cli-cmds.h (trace_commands): Likewise.
3354         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3355         to bool*.
3356         * cli/cli-logging.c (logging_overwrite): Change to bool.
3357         (logging_redirect): Likewise.
3358         (debug_redirect): Likewise.
3359         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3360         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3361         to bool.
3362         <boolean_option_def>: Update.
3363         (struct flag_option_def): Change default type of Context to bool
3364         from int.
3365         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3366         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3367         (get_setshow_command_value_string): Likewise.
3368         * cli/cli-style.c (cli_styling): Change to bool.
3369         (source_styling): Likewise.
3370         * cli/cli-style.h (source_styling): Likewise.
3371         (cli_styling): Likewise.
3372         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3373         to bool.
3374         * command.h (var_types): Update comment.
3375         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3376         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3377         bool.
3378         (debug_compile_cplus_scopes): Likewise.
3379         * compile/compile-internal.h (compile_debug): Likewise.
3380         * compile/compile.c (compile_debug): Likewise.
3381         (struct compile_options) <raw>: Likewise.
3382         * cp-support.c (catch_demangler_crashes): Likewise.
3383         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3384         (usr_cmd_cris_dwarf2_cfi): Likewise.
3385         * csky-tdep.c (csky_debug): Likewise.
3386         * darwin-nat.c (enable_mach_exceptions): Likewise.
3387         * dcache.c (dcache_enabled_p): Likewise.
3388         * defs.h (info_verbose): Likewise.
3389         * demangle.c (demangle): Likewise.
3390         (asm_demangle): Likewise.
3391         * dwarf-index-cache.c (debug_index_cache): Likewise.
3392         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3393         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3394         * dwarf2read.c (check_physname): Likewise.
3395         (use_deprecated_index_sections): Likewise.
3396         (dwarf_always_disassemble): Likewise.
3397         * eval.c (overload_resolution): Likewise.
3398         * event-top.c (set_editing_cmd_var): Likewise.
3399         (exec_done_display_p): Likewise.
3400         * event-top.h (set_editing_cmd_var): Likewise.
3401         (exec_done_display_p): Likewise.
3402         * exec.c (write_files): Likewise.
3403         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3404         (debug_fbsd_nat): Likewise.
3405         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3406         Likewise.
3407         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3408         <backtrace_past_entry> Likewise.
3409         * gdb-demangle.h (demangle): Likewise.
3410         (asm_demangle): Likewise.
3411         * gdb_bfd.c (bfd_sharing): Likewise.
3412         * gdbcore.h (write_files): Likewise.
3413         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3414         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3415         * gdbthread.h (print_thread_events): Likewise.
3416         * gdbtypes.c (opaque_type_resolution): Likewise.
3417         (strict_type_checking): Likewise.
3418         * gnu-nat.c (gnu_debug_flag): Likewise.
3419         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3420         * guile/scm-param.c (pascm_variable): Add boolval.
3421         (add_setshow_generic): Update.
3422         (pascm_param_value): Update.
3423         (pascm_set_param_value_x): Update.
3424         * hppa-tdep.c (hppa_debug): Change to bool..
3425         * infcall.c (may_call_functions_p): Likewise.
3426         (coerce_float_to_double_p): Likewise.
3427         (unwind_on_signal_p): Likewise.
3428         (unwind_on_terminating_exception_p): Likewise.
3429         * infcmd.c (startup_with_shell): Likewise.
3430         * inferior.c (print_inferior_events): Likewise.
3431         * inferior.h (startup_with_shell): Likewise.
3432         (print_inferior_events): Likewise.
3433         * infrun.c (step_stop_if_no_debug): Likewise.
3434         (detach_fork): Likewise.
3435         (debug_displaced): Likewise.
3436         (disable_randomization): Likewise.
3437         (non_stop): Likewise.
3438         (non_stop_1): Likewise.
3439         (observer_mode): Likewise.
3440         (observer_mode_1): Likewise.
3441         (set_observer_mode): Update.
3442         (sched_multi): Change to bool.
3443         * infrun.h (debug_displaced): Likewise.
3444         (sched_multi): Likewise.
3445         (step_stop_if_no_debug): Likewise.
3446         (non_stop): Likewise.
3447         (disable_randomization): Likewise.
3448         * linux-tdep.c (use_coredump_filter): Likewise.
3449         (dump_excluded_mappings): Likewise.
3450         * linux-thread-db.c (auto_load_thread_db): Likewise.
3451         (check_thread_db_on_load): Likewise.
3452         * main.c (captured_main_1): Update.
3453         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3454         xx2_opt, boolean_opt>: Change to bool.
3455         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3456         * maint.c (maintenance_profile_p): Likewise.
3457         (per_command_time): Likewise.
3458         (per_command_space): Likewise.
3459         (per_command_symtab): Likewise.
3460         * memattr.c (inaccessible_by_default): Likewise.
3461         * mi/mi-main.c (mi_async): Likewise.
3462         (mi_async_1): Likewise.
3463         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3464         * nat/fork-inferior.h (startup_with_shell): Likewise.
3465         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3466         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3467         * nios2-tdep.c (nios2_debug): Likewise.
3468         * or1k-tdep.c (or1k_debug): Likewise.
3469         * parse.c (parser_debug): Likewise.
3470         * parser-defs.h (parser_debug): Likewise.
3471         * printcmd.c (print_symbol_filename): Likewise.
3472         * proc-api.c (procfs_trace): Likewise.
3473         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3474         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3475         (set_parameter_value): Update.
3476         (add_setshow_generic): Update.
3477         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3478         to bool*.
3479         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3480         int*.
3481         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3482         * record-btrace.c (record_btrace_target::store_registers): Update.
3483         * record-full.c (record_full_memory_query): Change to bool.
3484         (record_full_stop_at_limit): Likewise.
3485         * record-full.h (record_full_memory_query): Likewise.
3486         * remote-notif.c (notif_debug): Likewise.
3487         * remote-notif.h (notif_debug): Likewise.
3488         * remote.c (use_range_stepping): Likewise.
3489         (interrupt_on_connect): Likewise.
3490         (remote_break): Likewise.
3491         * ser-tcp.c (tcp_auto_retry): Likewise.
3492         * ser-unix.c (serial_hwflow): Likewise.
3493         * skip.c (debug_skip): Likewise.
3494         * solib-aix.c (solib_aix_debug): Likewise.
3495         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3496         (spu_auto_flush_cache_p): Likewise.
3497         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3498         Likewise.
3499         (struct info_print_options) <quiet>: Likewise.
3500         * symfile-debug.c (debug_symfile): Likewise.
3501         * symfile.c (auto_solib_add): Likewise.
3502         (separate_debug_file_debug): Likewise.
3503         * symfile.h (auto_solib_add): Likewise.
3504         (separate_debug_file_debug): Likewise.
3505         * symtab.c (basenames_may_differ): Likewise.
3506         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3507         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3508         (struct info_types_options) <quiet>: Likewise.
3509         * symtab.h (demangle): Likewise.
3510         (basenames_may_differ): Likewise.
3511         * target-dcache.c (stack_cache_enabled_1): Likewise.
3512         (code_cache_enabled_1): Likewise.
3513         * target.c (trust_readonly): Likewise.
3514         (may_write_registers): Likewise.
3515         (may_write_memory): Likewise.
3516         (may_insert_breakpoints): Likewise.
3517         (may_insert_tracepoints): Likewise.
3518         (may_insert_fast_tracepoints): Likewise.
3519         (may_stop): Likewise.
3520         (auto_connect_native_target): Likewise.
3521         (target_stop_and_wait): Update.
3522         (target_async_permitted): Change to bool.
3523         (target_async_permitted_1): Likewise.
3524         (may_write_registers_1): Likewise.
3525         (may_write_memory_1): Likewise.
3526         (may_insert_breakpoints_1): Likewise.
3527         (may_insert_tracepoints_1): Likewise.
3528         (may_insert_fast_tracepoints_1): Likewise.
3529         (may_stop_1): Likewise.
3530         * target.h (target_async_permitted): Likewise.
3531         (may_write_registers): Likewise.
3532         (may_write_memory): Likewise.
3533         (may_insert_breakpoints): Likewise.
3534         (may_insert_tracepoints): Likewise.
3535         (may_insert_fast_tracepoints): Likewise.
3536         (may_stop): Likewise.
3537         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3538         (make_thread_apply_all_options_def_group): Change argument from int*
3539         to bool*.
3540         (thread_apply_all_command): Update.
3541         (print_thread_events): Change to bool.
3542         * top.c (confirm): Likewise.
3543         (command_editing_p): Likewise.
3544         (history_expansion_p): Likewise.
3545         (write_history_p): Likewise.
3546         (info_verbose): Likewise.
3547         * top.h (confirm): Likewise.
3548         (history_expansion_p): Likewise.
3549         * tracepoint.c (disconnected_tracing): Likewise.
3550         (circular_trace_buffer): Likewise.
3551         * typeprint.c (print_methods): Likewise.
3552         (print_typedefs): Likewise.
3553         * utils.c (debug_timestamp): Likewise.
3554         (sevenbit_strings): Likewise.
3555         (pagination_enabled): Likewise.
3556         * utils.h (sevenbit_strings): Likewise.
3557         (pagination_enabled): Likewise.
3558         * valops.c (overload_resolution): Likewise.
3559         * valprint.h (struct value_print_options) <prettyformat_arrays,
3560         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3561         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3562         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3563         Likewise.
3564         * windows-nat.c (new_console): Likewise.
3565         (cygwin_exceptions): Likewise.
3566         (new_group): Likewise.
3567         (debug_exec): Likewise.
3568         (debug_events): Likewise.
3569         (debug_memory): Likewise.
3570         (debug_exceptions): Likewise.
3571         (useshell): Likewise.
3572         * windows-tdep.c (maint_display_all_tib): Likewise.
3573         * xml-support.c (debug_xml): Likewise.
3574
3575 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3576
3577         * source.c (prepare_path_for_appending): New function.
3578         (openp): Make use of new function.
3579         (find_and_open_source): Search for the compilation directory and
3580         source file as a relative path beneath the directory search path.
3581
3582 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * source-cache.c (source_cache::get_line_charpos): Catch
3585         exceptions and return false, this matches the behaviour documented
3586         in the header file.
3587
3588 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3589
3590         * ada-tasks.c (info_task): Remove quoting of the task's name.
3591
3592 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3593
3594         * symfile.c (auto_solib_add): Replace comment with a reference
3595         to the header file.
3596
3597 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3598
3599         * NEWS: Mention that gdb can now be compiled with Python 3
3600         on Windows.
3601
3602 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3603
3604         * maint.c (maint_print_section_data::maint_print_section_data):
3605         Force use of 'float log10 (float)' by casting the argument to
3606         float.
3607
3608 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3609
3610         * maint.c: Add 'cmath' include.
3611         (struct maint_print_section_data): New structure.
3612         (print_section_index): New function.
3613         (print_bfd_section_info): Add header comment, small whitespace
3614         cleanup, and update to call new print_section_index function.
3615         (print_objfile_section_info): Likewise.
3616         (maint_obj_section_from_bfd_section): New function.
3617         (print_bfd_section_info_maybe_relocated): New function.
3618         (maintenance_info_sections): Add header comment, always use
3619         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3620
3621 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3622
3623         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3624         inner scope, add check that the objfile has psymtabs before
3625         checking psymtabs_addrmap.
3626         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3627
3628 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3629
3630         * NEWS: Announce that Ada task names are now shown at more places,
3631         and between quotes (except in info task output).
3632         * gdb/ada-tasks.c (task_to_str): New function.
3633         (display_current_task_id): Call task_to_str.
3634         (task_command_1): Likewise.
3635         (print_ada_task_info): In non-mi mode, Properly align headers and data
3636         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3637
3638 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3639
3640         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3641         prstatus.pr_lwp.pr_info instead of making it up.
3642
3643 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3644
3645         * auto-load.c (auto_load_expand_dir_vars): Update.
3646         * defs.h (gdb_datadir): Change to std::string.
3647         (python_libdir): Likewise.
3648         (relocate_gdb_directory): Change return type to std::string.
3649         * guile/guile.c (gdbscm_data_directory): Update.
3650         (initialize_scheme_side): Update.
3651         * jit.c (jit_reader_dir): Change to std::string.
3652         (jit_reader_load_command): Update.
3653         * main.c (gdb_datadir): Change to std::string.
3654         (python_libdir): Likewise.
3655         (set_gdb_data_directory): Update.
3656         (relocate_path): Change to return std::string.
3657         (relocate_gdb_directory): Change to return std::string.
3658         (relocate_gdbinit_path_maybe_in_datadir): Update.
3659         (captured_main_1): Update.
3660         * python/python.c (do_start_initialization): Update.
3661         * top.c (show_gdb_datadir): Update.
3662         * xml-syscall.c (xml_init_syscalls_info): Update.
3663         (init_syscalls_info): Update.
3664
3665 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3666
3667         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3668         out of get_init_files.
3669         (get_init_files): Update.
3670
3671 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3672
3673         * main.c (get_init_files): Change to use std::string.
3674         (captured_main_1): Update.
3675         (print_gdb_help): Update.
3676
3677 2019-09-11  Ali Tamur  <tamur@google.com>
3678
3679         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3680         implementation.
3681
3682 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3683
3684         * dbxread.c (read_dbx_symtab): Update.
3685         * dwarf2read.c (load_partial_dies): Update.
3686         * mdebugread.c (parse_partial_symbols): Update.
3687         (handle_psymbol_enumerators): Update.
3688         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3689         * psymtab.c (add_psymbol_to_bcache): Likewise.
3690         (add_psymbol_to_list): Likewise.
3691         * symtab.c (symbol_set_names): Likewise.
3692         * symtab.h (symbol_set_names): Likewise.
3693         * xcoffread.c (scan_xcoff_symtab): Update.
3694
3695 2019-09-11  Tom Tromey  <tom@tromey.com>
3696
3697         * symfile-mem.c (symbol_file_add_from_memory): Use
3698         bfd_set_filename.
3699         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3700         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3701
3702 2019-09-10  Tom Tromey  <tromey@adacore.com>
3703
3704         * dwarf-index-write.c (write_psymbols): Extend error message.
3705         (debug_names::insert): Add Ada code.
3706         (debug_names::write_psymbols): Remove Ada check.
3707         (debug_names) <m_string_obstack>: New member.
3708         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3709         (gdb_index_symbol_name_matcher::matches): Remove.
3710         (mapped_index_base::find_name_components_bounds): Add "lang"
3711         parameter.
3712         (mapped_index_base::build_name_components): Also split names
3713         according to Ada syntax.
3714         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
3715         type of "match_callback".
3716         (check_match, check_find_bounds_finds)
3717         (dw2_expand_symtabs_matching): Update.
3718         (dw2_debug_names_iterator): Add new constructor.
3719         (dw2_debug_names_map_matching_symbols): New function.
3720         (dw2_debug_names_expand_symtabs_matching): Update.
3721         (dwarf2_debug_names_functions): Use
3722         dw2_debug_names_map_matching_symbols.
3723
3724 2019-09-10  Tom Tromey  <tromey@adacore.com>
3725
3726         * dwarf2read.c (dw2_get_file_names_reader): Add the
3727         CU's file name to the results.
3728
3729 2019-09-10  Tom Tromey  <tromey@adacore.com>
3730
3731         * ada-lang.c (add_nonlocal_symbols): Combine calls to
3732         map_matching_symbols.  Update.
3733         * dwarf2read.c (dw2_map_matching_symbols): Update.
3734         * psymtab.c (match_partial_symbol): Change type; update.
3735         (psym_map_matching_symbols): Likewise.
3736         * symfile-debug.c (debug_qf_map_matching_symbols): Change
3737         type; update.
3738         * symfile.h (struct quick_symbol_functions)
3739         <map_matching_symbols>: Change "name" to be a lookup_name_info.
3740         Remove "match".
3741
3742 2019-09-10  Tom Tromey  <tromey@adacore.com>
3743
3744         * psymtab.c (map_block): Remove.
3745         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3746         * symtab.c (iterate_over_symbols_terminated): New function.
3747         * symtab.c (iterate_over_symbols_terminated): Declare.
3748
3749 2019-09-10  Tom Tromey  <tromey@adacore.com>
3750
3751         * ada-lang.c (ada_iterate_over_symbols): Return bool.
3752         * language.h (struct language_defn) <la_iterate_over_symbols>:
3753         Return bool.
3754         * symtab.c (iterate_over_symbols): Return bool.
3755         * symtab.h (iterate_over_symbols): Return bool.
3756
3757 2019-09-10  Tom Tromey  <tromey@adacore.com>
3758
3759         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3760         (add_nonlocal_symbols): Update.
3761         * dwarf2read.c (dw2_map_matching_symbols): Change type.
3762         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3763         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3764         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3765         Change type of "callback".  Remove "data".
3766
3767
3768 2019-09-09  Ali Tamur  <tamur@google.com>
3769
3770         * dwarf2read.c (comp_unit_head): Update comment.
3771         (dwarf2_dwo_name): New function declaration.
3772         (dwarf_unit_type_name): New function declaration.
3773         (read_comp_unit_head): Add support for new compilation units,
3774         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3775         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3776         (currently named as "signature") in their header. Also clarify error
3777         messages.
3778         (lookup_dwo_id): New function. Returns the dwo id of the given
3779         compile unit.
3780         (lookup_dwo_unit): Use the new lookup_dwo_id function.
3781         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3782         functions.
3783         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3784         (dwarf2_dwo_name): Get the dwo name if present.
3785         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3786         purposes.
3787
3788 2019-09-09  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3791
3792 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3793
3794         * python/python.c (do_start_initialization): Make progname_copy static,
3795         to avoid a leak report.
3796
3797 2019-09-08  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3800
3801 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
3802
3803         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3804         Change type to gdb::optional<block_enum>.
3805         (dw2_symtab_iter_init): Change block_index parameter type
3806         to gdb::optional<block_enum>.
3807         (dw2_lookup_symbol): Change block_index parameter
3808         type to block_enum.c
3809         (dw2_debug_names_lookup_symbol): Likewise.
3810         * psymtab.c (psym_lookup_symbol): Likewise.
3811         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3812         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3813         Likewise.
3814
3815 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
3816
3817         * defs.h (relocate_gdb_directory): Change int to bool in
3818         signature and rename flag to relocatable.
3819         * main.c (relocate_path): Likewise.
3820         (relocate_gdb_directory): Likewise.
3821
3822 2019-09-06  Alan Modra  <amodra@gmail.com>
3823
3824         * coffread.c (coff_symfile_read): Constify filename variable.
3825         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3826         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3827         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3828         * solib.c (reload_shared_libraries_1): Likewise.
3829         * symfile.c (reread_symbols): Likewise.
3830         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3831         * solib-darwin.c (darwin_bfd_open): Likewise.
3832         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3833
3834 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * psymtab.c (print_partial_symbols): Handle missing domain_enum
3837         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3838
3839 2019-09-03  Tom Tromey  <tromey@adacore.com>
3840
3841         * ada-valprint.c (ada_val_print_num): Don't recurse for range
3842         types.
3843         (has_negatives): Unbias a range type bound.
3844         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3845         * gdbtypes.c (operator==): Handle new field.
3846         (create_range_type): Add "bias" parameter.
3847         (create_static_range_type, resolve_dynamic_range): Update.
3848         * gdbtypes.h (struct range_bounds) <bias>: New member.
3849         (create_range_type): Add bias parameter.
3850         * printcmd.c (print_scalar_formatted): Unbias range types.
3851         * value.c (unpack_long): Unbias range types.
3852         (pack_long): Bias range types.
3853
3854 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3855
3856         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3857         probe arguments.
3858
3859 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3860
3861         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3862         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3863         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3864         (compile_probe_arg): Likewise.
3865         * probe.h (get_argument_count): Likewise.
3866         * solib-svr4.c (solib_event_probe_action): Likewise.
3867         * stap-probe.c (stap_probe::get_argument_count): Likewise.
3868
3869 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3870
3871         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3872         code to here...
3873         (svr4_create_solib_event_breakpoints): ...from here.
3874
3875 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
3876
3877         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3878         suffix from warning message.
3879
3880 2019-08-30  Tom Tromey  <tom@tromey.com>
3881
3882         * tui/tui-winsource.h (struct tui_source_window_base)
3883         <refresh_all>: Don't declare.
3884         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3885         Remove.
3886         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3887         tui_show_locator_content.
3888         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3889         declare.
3890         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3891         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3892         declare.
3893
3894 2019-08-30  Tom Tromey  <tom@tromey.com>
3895
3896         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3897
3898 2019-08-30  Tom Tromey  <tom@tromey.com>
3899
3900         * tui/tui-stack.c (_initialize_tui_stack): Move later.
3901         Remove unnecessary forward declarations.
3902
3903 2019-08-30  Tom Tromey  <tom@tromey.com>
3904
3905         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
3906         rerender.
3907         (tui_update_locator_fullname, tui_show_frame_info): Don't call
3908         tui_show_locator_content.
3909
3910 2019-08-30  Tom Tromey  <tom@tromey.com>
3911
3912         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
3913         (tui_locator_window::rerender): Rewrite using body of previous
3914         tui_show_locator_content.
3915
3916 2019-08-30  Tom Tromey  <tom@tromey.com>
3917
3918         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
3919         set_locator_fullname>: New methods.
3920         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3921         Rename from tui_set_locator_fullname.
3922         (tui_locator_window::set_locator_info): Rename from
3923         tui_set_locator_info.  Return bool.
3924         (tui_update_locator_fullname, tui_show_frame_info): Update.
3925
3926 2019-08-30  Tom Tromey  <tom@tromey.com>
3927
3928         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
3929
3930 2019-08-30  Tom Tromey  <tom@tromey.com>
3931
3932         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
3933         call touchwin.
3934
3935 2019-08-30  Tom Tromey  <tom@tromey.com>
3936
3937         * tui/tui-wingeneral.c (box_win): Assume win_info and
3938         win_info->handle cannot be NULL.
3939
3940 2019-08-30  Tom Tromey  <tom@tromey.com>
3941
3942         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
3943         refresh_window>: Declare.
3944         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
3945         resize.
3946         (tui_data_item_window::rerender): Rename from
3947         tui_display_register.
3948         (tui_data_item_window::refresh_window): New method.
3949         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
3950         no-op.
3951
3952 2019-08-30  Tom Tromey  <tom@tromey.com>
3953
3954         * tui/tui-regs.h (struct tui_data_window) <regs_content,
3955         regs_column_count, current_group>: Move later.  Now private.
3956         <get_current_group>: New method.
3957         * tui/tui-regs.c (tui_reg_command): Update.
3958         * tui/tui-layout.c (tui_set_layout): Update.
3959
3960 2019-08-30  Tom Tromey  <tom@tromey.com>
3961
3962         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3963         (tui_data_window::rerender): Don't call
3964         check_and_display_highlight_if_needed.
3965         (tui_data_window::refresh_all): Remove call to
3966         erase_data_content.
3967
3968 2019-08-30  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3971         (tui_data_window::display_registers_from)
3972         (tui_data_window::display_reg_element_at_line)
3973         (tui_data_window::display_registers_from_line): Remove checks of
3974         "empty".
3975
3976 2019-08-30  Tom Tromey  <tom@tromey.com>
3977
3978         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
3979         Don't declare.
3980         * tui/tui-regs.c (tui_data_window::show_registers): Call
3981         rerender.
3982         (tui_data_window::rerender): Rename from display_all_data.
3983         (tui_data_window::rerender): Remove old implementation.
3984
3985 2019-08-30  Tom Tromey  <tom@tromey.com>
3986
3987         * tui/tui-regs.c (tui_data_window::display_all_data): Change
3988         text.
3989         * tui/tui-data.h (NO_DATA_STRING): Remove define.
3990
3991 2019-08-29  Bernhard Wodok  <barto@gmx.net>
3992             Sergio Durigan Junior  <sergiodj@redhat.com>
3993
3994         PR win32/24284
3995         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3996
3997 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3998
3999         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4000         when searching for types.
4001
4002 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4003
4004         * f-lang.c (f_language_defn): Use f_print_typedef.
4005         * f-lang.h (f_print_typedef): Declare.
4006         * f-typeprint.c (f_print_typedef): Define.
4007
4008 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4009
4010         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4011
4012 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4013
4014         * cli/cli-utils.c (info_print_options_defs): Delete.
4015         (make_info_print_options_def_group): Delete.
4016         (extract_info_print_options): Delete.
4017         (info_print_command_completer): Delete.
4018         (info_print_args_help): Add extra parameter, and optionally
4019         include text about -n flag.
4020         * cli/cli-utils.h (struct info_print_options): Delete.
4021         (extract_info_print_options): Delete declaration.
4022         (info_print_command_completer): Delete declaration.
4023         (info_print_args_help): Add extra parameter, extend header
4024         comment.
4025         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4026         search_symbols.
4027         * stack.c (struct info_print_options): New type.
4028         (info_print_options_defs): New file scoped variable.
4029         (make_info_print_options_def_group): New static function.
4030         (info_print_command_completer): New static function.
4031         (info_locals_command): Update to use new local functions.
4032         (info_args_command): Likewise.
4033         (_initialize_stack): Add extra parameter to calls to
4034         info_print_args_help.
4035         * symtab.c (search_symbols): Add extra parameter, use this to
4036         possibly excluse non-debug symbols.
4037         (symtab_symbol_info): Add extra parameter, which is passed on to
4038         search_symbols.
4039         (struct info_print_options): New type.
4040         (info_print_options_defs): New file scoped variable.
4041         (make_info_print_options_def_group): New static function.
4042         (info_print_command_completer): New static function.
4043         (info_variables_command): Update to use local functions, and pass
4044         extra parameter through to symtab_symbol_info.
4045         (info_functions_command): Likewise.
4046         (info_types_command): Pass additional argument through to
4047         symtab_symbol_info.
4048         (rbreak_command): Pass extra argument to search_symbols.
4049         (_initialize_symtab): Add extra arguments for calls to
4050         info_print_args_help, and update help text for 'info variables',
4051         'whereis', and 'info functions' commands.
4052         * symtab.h (search_symbols): Add extra argument to declaration.
4053         * NEWS: Mention new flags.
4054
4055 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4056
4057         * symtab.c (lookup_static_symbol): Call the new function (and move
4058         it down to be next to lookup_global_symbol).
4059         (struct global_sym_lookup_data): Add block_enum member and rename to...
4060         (struct global_or_static_sym_lookup_data): ...this.
4061         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4062         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4063         (lookup_symbol_global_or_static_iterator_cb): ...this.
4064         (lookup_global_or_static_symbol): New function.
4065         (lookup_global_symbol): Call new function.
4066
4067 2019-08-26  Tom de Vries  <tdevries@suse.de>
4068
4069         PR c++/24852
4070         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4071         when pc_probe.prob == NULL.
4072
4073 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4074
4075         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4076         variable symbol_linkage to symbol_linkage_.
4077
4078 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4079
4080         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4081         represent whether the symbol is static, dynamic, or we don't
4082         know.
4083
4084 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4085
4086         * gdb/rx-tdep.c (rx_register_names): New.
4087         (rx_register_name): Delete.
4088         (rx_psw_type): Delete.
4089         (rx_fpsw_type): Delete.
4090         (rx_register_type): Delete.
4091         (rx_gdbarch_init): Convert target-descriptions.
4092         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4093         * gdb/features/Makefile: Add rx.xml.
4094         * gdb/features/rx.xml: New.
4095         * gdb/features/rx.c: Generated.
4096         * gdb/NEWS: Mention target description support.
4097
4098 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4099
4100         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4101         *slot_ptr.
4102
4103 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4104
4105         * configure.ac: Don't check for 'dlfcn.h' (moved to
4106         gdbsupport/common.m4).
4107         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4108         'gdbsupport/'.
4109         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4110         * compile/compile-c-support.c: Include
4111         'gdbsupport/gdb-dlfcn.h'.
4112         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4113         * gdb-dlfcn.c: Move to...
4114         * gdbsupport/gdb-dlfcn.c: ... here.
4115         * gdb-dlfcn.h: Move to...
4116         * gdbsupport/gdb-dlfcn.h: ... here.
4117
4118 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4119
4120         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4121         the offset field signed.
4122
4123 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4124
4125         * python/lib/gdb/__init__.py (_execute_file): New function.
4126         * python/python.c (python_run_simple_file): Call gdb._execute_file
4127         on Windows.
4128
4129 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4130
4131         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4132         all uses as this was never set to anything but a zero value.
4133
4134 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4135
4136         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4137
4138 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4139
4140         * tui/tui-data.h (tui_gen_win_info): Add an =default
4141         move constructor, required by some GCC versions.
4142
4143 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4144
4145         * go32-nat.c (go32_sysinfo): Add hygon_p.
4146
4147 2019-08-20  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4150         line_from_reg_element_no, first_reg_element_no_inline,
4151         display_all_data, delete_data_content_windows,
4152         erase_data_content>: Now private.
4153
4154 2019-08-20  Tom Tromey  <tom@tromey.com>
4155
4156         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4157         (tui_unhighlight_win, tui_highlight_win)
4158         (tui_win_info::make_window): Update.
4159         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4160
4161 2019-08-20  Tom Tromey  <tom@tromey.com>
4162
4163         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4164         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4165         (MAX_PID_WIDTH): Move to tui-stack.c.
4166         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4167         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4168         (MAX_PID_WIDTH): Move from tui-data.h.
4169
4170 2019-08-20  Tom Tromey  <tom@tromey.com>
4171
4172         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4173         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4174         (box_win): Update.
4175         (tui_gen_win_info::make_window): Rename from tui_make_window.
4176         (tui_win_info::make_window): New method.
4177         (tui_gen_win_info::make_visible): Update.
4178         * tui/tui-source.c (tui_source_window::set_contents): Update.
4179         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4180         (tui_data_window::display_registers_from): Update.
4181         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4182         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4183         Declare.
4184         <can_box>: Remove.
4185         <title>: Remove.
4186         (struct tui_win_info) <make_window>: Declare.
4187         <can_box>: Now virtual.
4188         <title>: New member.
4189         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4190         * tui/tui-command.c (tui_cmd_window::resize): Update.
4191
4192 2019-08-20  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4195         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4196         (tui_data_window::check_register_values): Update.
4197
4198 2019-08-20  Tom Tromey  <tom@tromey.com>
4199
4200         * tui/tui-regs.h (struct tui_data_window): Use
4201         DISABLE_COPY_AND_ASSIGN.
4202         <regs_content>: Change type, removing unique_ptr.
4203         <tui_data_window>: Add move constructor.
4204         * tui/tui-regs.c (tui_data_window::show_registers)
4205         (tui_data_window::show_register_group)
4206         (tui_data_window::display_registers_from)
4207         (tui_data_window::display_registers_from)
4208         (tui_data_window::first_data_item_displayed)
4209         (tui_data_window::delete_data_content_windows)
4210         (tui_data_window::rerender, tui_data_window::refresh_window)
4211         (tui_data_window::check_register_values): Update.
4212
4213 2019-08-20  Tom Tromey  <tom@tromey.com>
4214
4215         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4216         show_register_group>: Declare.
4217         (tui_show_register_group): Don't declare.
4218         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4219         tui_show_registers.
4220         (tui_data_window::show_register_group): Rename from
4221         tui_show_register_group.
4222         (tui_data_window::check_register_values, tui_reg_command):
4223         Update.
4224         * tui/tui-layout.c (tui_set_layout): Update.
4225
4226 2019-08-20  Tom Tromey  <tom@tromey.com>
4227
4228         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4229         Declare.
4230         (tui_check_register_values): Don't declare.
4231         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4232         from tui_check_register_values.
4233         * tui/tui-hooks.c (tui_register_changed): Update.
4234
4235 2019-08-20  Tom Tromey  <tom@tromey.com>
4236
4237         * tui/tui-regs.c (tui_reg_layout): Move later.
4238         (tui_show_registers): Don't enable TUI mode or change layout.
4239
4240 2019-08-20  Tom Tromey  <tom@tromey.com>
4241
4242         * tui/tui-regs.h (struct tui_data_item_window)
4243         <~tui_data_item_window>: Remove.
4244         <content>: Now a unique_xmalloc_ptr.
4245         * tui/tui-regs.c (tui_register_format): Return a
4246         unique_xmalloc_ptr.
4247         (tui_get_register): Update.
4248         (~tui_data_item_window): Remove.
4249         (tui_data_window::display_registers_from, tui_display_register):
4250         Update.
4251         * tui/tui-io.h (tui_expand_tabs): Update.
4252         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4253         Remove "col" parameter.
4254
4255 2019-08-20  Tom Tromey  <tom@tromey.com>
4256
4257         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4258         field.
4259         * tui/tui-regs.c (~tui_data_item_window): Update.
4260
4261 2019-08-20  Tom Tromey  <tom@tromey.com>
4262
4263         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4264         earlier.
4265
4266 2019-08-20  Tom Tromey  <tom@tromey.com>
4267
4268         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4269
4270 2019-08-20  Tom Tromey  <tom@tromey.com>
4271
4272         * tui/tui-source.h (struct tui_source_window): Update.
4273         * tui/tui-regs.c (tui_show_registers): Update.
4274         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4275         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4276         (NO_REGS_STRING): Remove defines.
4277
4278 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4279
4280         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4281         unnecessary thread walk if remote doesn't support the packet.
4282
4283 2019-08-19  Tom Tromey  <tromey@adacore.com>
4284
4285         * python/py-value.c (value_has_field): Fix indentation.
4286
4287 2019-08-19  Tom Tromey  <tromey@adacore.com>
4288
4289         * printcmd.c (do_one_display, info_display_command): Update.
4290         * block.h (contained_in): Return bool.  Add allow_nested
4291         parameter.
4292         * block.c (contained_in): Return bool.  Add allow_nested
4293         parameter.
4294
4295 2019-08-19  Tom Tromey  <tom@tromey.com>
4296
4297         * configure: Rebuild.
4298         * configure.ac: Disallow the combination of -static-libstdc++ and
4299         source highlight.
4300         * source-cache.c (get_language_name): Handle rust.
4301         (source_cache::get_source_lines): Ignore highlighting exceptions.
4302
4303 2019-08-16  Tom Tromey  <tom@tromey.com>
4304
4305         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4306         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4307         (struct tui_source_window_base) <make_visible, refresh_window,
4308         resize>: Remove methods.
4309         <execution_info>: Remove field.
4310         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4311         (tui_show_source_line, tui_source_window_base)
4312         (~tui_source_window_base): Update.
4313         (tui_source_window_base::resize)
4314         (tui_source_window_base::make_visible)
4315         (tui_source_window_base::refresh_window): Remove.
4316         (tui_source_window_base::update_exec_info): Update.
4317         * tui/tui-source.c (tui_source_window::set_contents): Update.
4318         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4319
4320 2019-08-16  Tom Tromey  <tom@tromey.com>
4321
4322         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4323         deprecated_query_hook.
4324
4325 2019-08-16  Tom Tromey  <tom@tromey.com>
4326
4327         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4328         (tui_update_source_windows_with_line): Update.
4329         * tui/tui-source.h (struct tui_source_window)
4330         <show_symtab_source>: Declare.
4331         (tui_show_symtab_source): Don't declare.
4332         * tui/tui-source.c (tui_show_symtab_source): Rename from
4333         tui_show_symtab_source.
4334
4335 2019-08-16  Tom Tromey  <tom@tromey.com>
4336
4337         * tui/tui-winsource.h (struct tui_source_window_base)
4338         <set_contents>: Declare.
4339         * tui/tui-winsource.c
4340         (tui_source_window_base::update_source_window_as_is): Update.
4341         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4342         Declare.
4343         (tui_set_source_content): Don't declare.
4344         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4345         tui_set_source_content.
4346         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4347         Declare.
4348         (tui_set_disassem_content): Don't declare.
4349         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4350         tui_set_disassem_content.
4351
4352 2019-08-16  Tom Tromey  <tom@tromey.com>
4353
4354         * tui/tui-winsource.h (struct tui_source_window_base)
4355         <update_breakpoint_info>: Declare.
4356         (tui_update_breakpoint_info): Don't declare.
4357         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4358         (tui_update_all_breakpoint_info): Update.
4359         (tui_source_window_base::update_breakpoint_info): Rename from
4360         tui_update_breakpoint_info.
4361         (tui_source_window_base::update_exec_info): Update.
4362
4363 2019-08-16  Tom Tromey  <tom@tromey.com>
4364
4365         * tui/tui-winsource.h (struct tui_source_window_base)
4366         <update_source_window>: Declare.
4367         (tui_update_source_window): Don't declare.
4368         * tui/tui-winsource.c
4369         (tui_source_window_base::update_source_window): Rename from
4370         tui_update_source_window.
4371         (tui_source_window_base::rerender): Update.
4372         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4373         * tui/tui-disasm.c (tui_show_disassem)
4374         (tui_show_disassem_and_update_source)
4375         (tui_disasm_window::maybe_update): Update.
4376
4377 2019-08-16  Tom Tromey  <tom@tromey.com>
4378
4379         * tui/tui-winsource.h (struct tui_source_window_base)
4380         <update_source_window_as_is>: Declare.
4381         (tui_update_source_window_as_is): Don't declare.
4382         * tui/tui-winsource.c (tui_update_source_window): Update
4383         (tui_source_window_base::update_source_window_as_is): Rename from
4384         tui_update_source_window_as_is.
4385         (tui_source_window_base::refill): Update.
4386         * tui/tui-source.c (tui_show_symtab_source): Update.
4387         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4388         Update.
4389
4390 2019-08-16  Tom Tromey  <tom@tromey.com>
4391
4392         * tui/tui-winsource.h (tui_update_source_window)
4393         (tui_update_source_window_as_is): Remove "noerror" parameter.
4394         * tui/tui-winsource.c (tui_update_source_window)
4395         (tui_update_source_window_as_is): Remove "noerror" parameter.
4396         (tui_update_source_windows_with_addr)
4397         (tui_update_source_windows_with_line)
4398         (tui_source_window_base::rerender)
4399         (tui_source_window_base::refill): Update.
4400         * tui/tui-source.h (tui_set_source_content)
4401         (tui_show_symtab_source): Remove "noerror" parameter.
4402         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4403         parameter.
4404         (tui_show_symtab_source): Likewise.
4405         (tui_source_window::maybe_update): Update.
4406         * tui/tui-disasm.c (tui_show_disassem)
4407         (tui_show_disassem_and_update_source)
4408         (tui_disasm_window::do_scroll_vertical)
4409         (tui_disasm_window::maybe_update): Update.
4410
4411 2019-08-16  Tom Tromey  <tom@tromey.com>
4412
4413         * tui/tui.c (tui_is_window_visible): Update.
4414         * tui/tui-wingeneral.c (tui_make_window)
4415         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4416         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4417         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4418         (tui_set_win_height_command, parse_scrolling_args): Update.
4419         * tui/tui-source.c (tui_source_window::style_changed): Update.
4420         * tui/tui-regs.c (tui_show_registers)
4421         (tui_data_window::first_data_item_displayed)
4422         (tui_data_window::delete_data_content_windows)
4423         (tui_check_register_values, tui_reg_command): Update.
4424         * tui/tui-disasm.c (tui_show_disassem): Update.
4425         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4426         method.
4427         <is_visible>: Remove field.
4428         * tui/tui-data.c (tui_next_win, tui_prev_win)
4429         (tui_delete_invisible_windows): Update.
4430
4431 2019-08-16  Tom Tromey  <tom@tromey.com>
4432
4433         * tui/tui-winsource.h (struct tui_source_window_base)
4434         <m_has_locator>: Remove.
4435         * tui/tui-layout.c (show_source_disasm_command, show_data)
4436         (show_source_or_disasm_and_command): Update.
4437
4438 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4439
4440         * NEWS (Other MI changes): New subsection.
4441         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4442         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4443         * arch-utils.c (default_get_pc_address_flags): New function.
4444         * arch-utils.h (default_get_pc_address_flags): New declaration.
4445         * gdbarch.sh: Add get_pc_address_flags.
4446         * gdbarch.c: Regenerate.
4447         * gdbarch.h: Likewise.
4448         * stack.c (print_pc): New function.
4449         (print_frame_info) (print_frame): Call print_pc.
4450
4451 2019-08-16  Tom de Vries  <tdevries@suse.de>
4452
4453         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4454         print_objfile_section_info.
4455
4456 2019-08-15  Tom Tromey  <tom@tromey.com>
4457
4458         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4459         calling update_cmdwin_start_line.
4460         * tui/tui-winsource.h (struct tui_source_window_base)
4461         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4462         <rerender>: Declare.
4463         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4464         Call rerender.
4465         (tui_source_window_base::set_new_height): Remove.
4466         (tui_source_window_base::rerender): Rename from
4467         do_make_visible_with_new_height.
4468         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4469         resize method.
4470         (tui_win_info::make_invisible_and_set_new_height)
4471         (tui_win_info::make_visible_with_new_height): Remove.
4472         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4473         Declare.
4474         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4475         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4476         do_make_visible_with_new_height>: Don't declare.
4477         <rerender>: Declare.
4478         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4479         set_new_height.
4480         (tui_data_window::do_make_visible_with_new_height): Remove.
4481         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4482         call tui_show_locator_content.
4483         (tui_gen_win_info::resize): Call rerender.
4484         (show_source_or_disasm_and_command): Don't call
4485         tui_show_locator_content.
4486         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4487         method.
4488         (struct tui_win_info) <rerender>: Declare.
4489         <set_new_height, make_invisible_and_set_new_height,
4490         make_visible_with_new_height>: Don't declare.
4491         * tui/tui-data.c (tui_win_list::rerender): New method.
4492         * tui/tui-command.h (struct tui_cmd_window)
4493         <do_make_visible_with_new_height>: Don't declare.
4494         * tui/tui-command.c
4495         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4496
4497 2019-08-15  Tom Tromey  <tromey@adacore.com>
4498
4499         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4500         * ada-lang.c (ada_enum_name): Likewise.
4501
4502 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4503
4504         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4505         leading underscore.
4506         (GdbOutputErrorFile): Likewise.
4507         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4508         accordingly.
4509         (execute_unwinders): Rename to have a leading underscore.
4510         (auto_load_packages): Likewise.
4511         (global scope): Adjust call to auto_load_packages accordingly.
4512         (GdbSetPythonDirectory): Likewise.
4513         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4514         instead of execute_unwinders.
4515
4516 2019-08-15  Tom Tromey  <tom@tromey.com>
4517
4518         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4519         (show_data): Don't change window visibility.
4520         (tui_gen_win_info::resize): Remove special case for command
4521         window.  Use wresize, when available.
4522         (show_source_or_disasm_and_command): Don't change window
4523         visibility.
4524         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4525         <make_visible>: New method.
4526         * tui/tui-command.c (tui_cmd_window::resize): New method.
4527
4528 2019-08-15  Tom Tromey  <tom@tromey.com>
4529
4530         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4531         (struct tui_source_windows): New.
4532         * tui/tui-winsource.c (tui_display_main): Update.
4533         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4534         (new_height_ok, parse_scrolling_args): Update.
4535         * tui/tui-layout.c (show_layout, show_data): Update.
4536         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4537         (tui_add_to_source_windows): Don't declare.
4538         * tui/tui-data.c (source_windows, tui_source_windows)
4539         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4540
4541 2019-08-15  Tom Tromey  <tom@tromey.com>
4542
4543         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4544         Rename from reset.
4545         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4546         * tui/tui-layout.c (show_source_disasm_command, show_data):
4547         Update.
4548         (tui_gen_win_info::resize): Rename.
4549         (show_source_or_disasm_and_command): Update.
4550         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4551         reset.
4552
4553 2019-08-15  Tom Tromey  <tom@tromey.com>
4554
4555         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4556         * tui/tui-interp.c (tui_interp::init): Don't call
4557         tui_initialize_static_data.
4558         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4559
4560 2019-08-15  Tom Tromey  <tom@tromey.com>
4561
4562         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4563         examine tui_win_list.
4564
4565 2019-08-15  Tom Tromey  <tom@tromey.com>
4566
4567         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4568         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4569         tui_clear_source_content.
4570         (tui_clear_source_content): Remove.
4571         (tui_source_window_base::do_erase_source_content): Hoist call to
4572         content.clear().
4573         * tui/tui-stack.c (tui_show_frame_info): Don't call
4574         tui_clear_source_content.
4575
4576 2019-08-15  Tom Tromey  <tom@tromey.com>
4577
4578         * tui/tui-winsource.h (struct tui_source_window_base)
4579         <do_erase_source_content>: New method.
4580         <erase_source_content>: New method.
4581         (tui_erase_source_content): Don't declare.
4582         * tui/tui-winsource.c (tui_clear_source_content): Update.
4583         (tui_source_window_base::do_erase_source_content): Rename from
4584         tui_erase_source_content.
4585         (tui_source_window_base::show_source_content): Update.
4586         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4587         * tui/tui-source.h (struct tui_source_window)
4588         <erase_source_content>: New method.
4589         * tui/tui-disasm.h (struct tui_disasm_window)
4590         <erase_source_content>: New method.
4591
4592 2019-08-15  Tom Tromey  <tom@tromey.com>
4593
4594         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4595         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4596         constructor.
4597         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4598         * tui/tui-source.c (tui_set_source_content): Update.
4599         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4600
4601 2019-08-15  Tom Tromey  <tom@tromey.com>
4602
4603         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4604         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4605         tui-source.c.
4606         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4607         Declare.
4608         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4609         method.
4610         (tui_source_window::maybe_update): Update.
4611
4612 2019-08-15  Tom Tromey  <tom@tromey.com>
4613
4614         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4615         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4616         tui-disasm.c.
4617         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4618         Declare.
4619         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4620         method.
4621         (tui_disasm_window::maybe_update): Update.
4622
4623 2019-08-15  Tom Tromey  <tom@tromey.com>
4624
4625         * tui/tui-winsource.h (struct tui_source_window_base)
4626         <maybe_update>: Declare.
4627         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4628         method.
4629         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4630         Declare.
4631         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4632         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4633         Declare.
4634         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4635
4636 2019-08-15  Tom Tromey  <tom@tromey.com>
4637
4638         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4639
4640 2019-08-15  Tom Tromey  <tom@tromey.com>
4641
4642         * tui/tui-wingeneral.c: Include tui-stack.h.
4643         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4644         (struct tui_locator_window): Move from tui-data.h.
4645         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4646         (tui_initialize_static_data): Move from tui-data.c.
4647         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4648         (struct tui_locator_window): Move to tui-stack.c.
4649         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4650         (tui_initialize_static_data): Move to tui-stack.c.
4651
4652 2019-08-15  Tom Tromey  <tom@tromey.com>
4653
4654         * tui/tui-layout.c (show_source_disasm_command)
4655         (show_source_or_disasm_and_command): Use make_visible method, not
4656         tui_make_window.
4657         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4658         Remove.
4659
4660 2019-08-15  Tom Tromey  <tom@tromey.com>
4661
4662         * tui/tui-wingeneral.h (tui_make_window): Update.
4663         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4664         parameter.
4665         (tui_gen_win_info::make_visible): Update.
4666         * tui/tui-regs.c (tui_data_window::display_registers_from):
4667         Update.
4668         * tui/tui-layout.c (show_source_disasm_command)
4669         (show_source_or_disasm_and_command): Update.
4670         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4671         (enum tui_box): Remove.
4672         (struct tui_win_info) <can_box>: New method.
4673         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4674         method.
4675
4676 2019-08-15  Tom de Vries  <tdevries@suse.de>
4677
4678         * linux-nat-trad.c: Include gdbarch.h.
4679
4680 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
4681
4682         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4683         register sizes.
4684
4685 2019-08-14  Tom Tromey  <tromey@adacore.com>
4686
4687         * darwin-nat.c: Include gdbarch.h.
4688         * darwin-nat-info.c: Include gdbarch.h.
4689
4690 2019-08-13  Tom Tromey  <tom@tromey.com>
4691
4692         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4693         Remove.
4694         * tui/tui-data.c (tui_initialize_static_data): Update.
4695
4696 2019-08-13  Tom Tromey  <tom@tromey.com>
4697
4698         * tui/tui-winsource.h (struct tui_exec_info_window)
4699         <~tui_exec_info_window, maybe_allocate_content, get_content,
4700         m_content>: Remove.
4701         (struct tui_source_window_base) <set_exec_info_content,
4702         show_exec_info_content>: Don't declare.
4703         * tui/tui-winsource.c
4704         (tui_exec_info_window::maybe_allocate_content): Remove.
4705         (tui_source_window_base::update_exec_info): Rename from
4706         set_exec_info_content.
4707         (tui_source_window_base::show_exec_info_content)
4708         (tui_source_window_base::update_exec_info): Remove.
4709
4710 2019-08-13  Tom Tromey  <tom@tromey.com>
4711
4712         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4713         declare.
4714         * tui/tui-winsource.c (tui_update_source_window_as_is)
4715         (tui_update_source_windows_with_addr, tui_erase_source_content):
4716         Update.
4717         (tui_clear_exec_info_content): Remove.
4718
4719 2019-08-13  Tom Tromey  <tom@tromey.com>
4720
4721         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4722         declare.
4723         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4724         call tui_erase_exec_info_content.
4725         (tui_clear_exec_info_content): Rename from
4726         tui_erase_exec_info_content.
4727         (tui_clear_exec_info_content): Delete.
4728
4729 2019-08-13  Tom Tromey  <tom@tromey.com>
4730
4731         * tui/tui-winsource.h (struct tui_source_window_base)
4732         <show_exec_info_content>: Declare.
4733         (tui_show_exec_info_content): Don't declare.
4734         * tui/tui-winsource.c
4735         (tui_source_window_base::show_exec_info_content): Rename from
4736         tui_show_exec_info_content.
4737         (tui_source_window_base::update_exec_info): Update.
4738
4739 2019-08-13  Tom Tromey  <tom@tromey.com>
4740
4741         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4742         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4743         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4744         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4745         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4746         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4747         ... here.
4748
4749 2019-08-13  Tom Tromey  <tom@tromey.com>
4750
4751         * tui/tui-winsource.h (struct tui_source_window_base)
4752         <update_exec_info>: Declare.
4753         (tui_update_exec_info): Don't declare.
4754         * tui/tui-winsource.c (tui_update_source_window_as_is)
4755         (tui_source_window_base::refresh_all)
4756         (tui_update_all_breakpoint_info): Update.
4757         (tui_source_window_base::update_exec_info): Rename from
4758         tui_update_exec_info.
4759         * tui/tui-stack.c (tui_show_frame_info): Update.
4760
4761 2019-08-13  Tom Tromey  <tom@tromey.com>
4762
4763         * tui/tui-winsource.h (struct tui_source_window_base)
4764         <set_exec_info_content>: Declare.
4765         (tui_set_exec_info_content): Don't declare.
4766         * tui/tui-winsource.c
4767         (tui_source_window_base::set_exec_info_content): Rename from
4768         tui_set_exec_info_content.
4769         (tui_update_exec_info): Update.
4770
4771 2019-08-13  Tom Tromey  <tom@tromey.com>
4772
4773         * tui/tui-winsource.h (struct tui_source_window_base)
4774         <show_source_content>: Declare.
4775         (tui_show_source_content): Don't declare.
4776         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4777         (tui_source_window_base::show_source_content): Rename from
4778         tui_show_source_content.
4779         (tui_source_window_base::refresh_all): Update.
4780         * tui/tui-layout.c (show_source_disasm_command)
4781         (show_source_or_disasm_and_command): Update.
4782
4783 2019-08-13  Tom Tromey  <tom@tromey.com>
4784
4785         * tui/tui-winsource.c (tui_erase_source_content)
4786         (tui_show_source_content, tui_source_window_base::refresh_all):
4787         Update.
4788         * tui/tui-wingeneral.h
4789         (tui_check_and_display_highlight_if_needed): Don't declare.
4790         * tui/tui-wingeneral.c
4791         (tui_win_info::check_and_display_highlight_if_needed): Rename from
4792         check_and_display_highlight_if_needed.
4793         * tui/tui-win.c (tui_rehighlight_all)
4794         (tui_win_info::make_visible_with_new_height): Update.
4795         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4796         (tui_data_window::erase_data_content)
4797         (tui_data_window::display_all_data): Update.
4798         * tui/tui-data.h (struct tui_win_info)
4799         <check_and_display_highlight_if_needed>: Declare.
4800
4801 2019-08-13  Tom Tromey  <tom@tromey.com>
4802
4803         * tui/tui-win.c (tui_resize_all): Call
4804         tui_delete_invisible_windows.
4805         * tui/tui-layout.c (show_layout): Call
4806         tui_delete_invisible_windows.
4807         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4808         * tui/tui-data.c (tui_delete_invisible_windows): New function.
4809
4810 2019-08-13  Tom Tromey  <tom@tromey.com>
4811
4812         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
4813         tui_add_win_to_layout.
4814
4815 2019-08-13  Tom Tromey  <tom@tromey.com>
4816
4817         * tui/tui-layout.h (tui_default_win_height): Don't declare.
4818         * tui/tui-layout.c (tui_default_win_height): Now static.
4819
4820 2019-08-13  Tom Tromey  <tom@tromey.com>
4821
4822         * tui/tui-layout.c (show_layout): Unify all layout cases into a
4823         single switch.
4824         (show_source_disasm_command, show_source_or_disasm_and_command):
4825         Don't check current layout.
4826
4827 2019-08-13  Tom Tromey  <tom@tromey.com>
4828
4829         * tui/tui-wingeneral.c (make_all_visible): Remove.
4830         (tui_make_all_invisible): Simplify.
4831         * tui/tui-layout.c (tui_make_all_invisible): Move from
4832         tui-wingeneral.c; simplify.
4833         (show_layout): Hoist call to tui_make_all_invisible.
4834         (show_data): Don't call tui_make_all_invisible.
4835
4836 2019-08-13  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4839         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4840
4841 2019-08-13  Tom Tromey  <tom@tromey.com>
4842
4843         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4844         tui-data.c.
4845         (show_source_disasm_command, show_data)
4846         (show_source_or_disasm_and_command): Don't use
4847         tui_set_current_layout_to.
4848         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4849         * tui/tui-data.c (current_layout, tui_current_layout): Move to
4850         tui-layout.c.
4851         (tui_set_current_layout_to): Remove.
4852
4853 2019-08-13  Tom Tromey  <tom@tromey.com>
4854
4855         * tui/tui-layout.c (tui_set_layout): Update.
4856         * tui/tui-data.h (struct tui_layout_def): Remove.
4857         (tui_layout_def): Don't declare.
4858         * tui/tui-data.c (layout_def): Remove.
4859         (tui_layout_def): Remove.
4860
4861 2019-08-13  Tom Tromey  <tom@tromey.com>
4862
4863         * tui/tui-winsource.h (struct tui_source_window_base)
4864         <clear_detail>: No longer "override".
4865         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4866         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4867         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4868         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4869         Remove.
4870         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4871
4872 2019-08-13  Tom Tromey  <tromey@adacore.com>
4873
4874         * tracepoint.c: Don't include readline.h or history.h.
4875
4876 2019-08-12  Tom Tromey  <tom@tromey.com>
4877
4878         * configure: Rebuild.
4879         * configure.ac: Check for readline 7.
4880         * NEWS: Mention readline 7 requirement.
4881         * README: Update.
4882
4883 2019-08-12  Tom Tromey  <tom@tromey.com>
4884
4885         * mingw-hdep.c (gdb_select): Remove readline hack.
4886
4887 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4888
4889         * blockframe.c (find_pc_partial_function): Set *block to nullptr
4890         when the function fails.
4891
4892 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
4893
4894         * s390-tdep.c (s390_type_align): New function.
4895         (s390_gdbarch_init): Set it as type_align gdbarch method.
4896
4897 2019-08-09  Tom de Vries  <tdevries@suse.de>
4898
4899         PR gdb/24591
4900         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
4901         pc_low with relocation offset.
4902
4903 2019-08-07  Tom Tromey  <tromey@adacore.com>
4904
4905         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4906         (print_frame_args): Update.
4907         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
4908         Update.
4909         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4910         * frame.h (struct frame_arg): Add initializers.
4911         <error>: Now a unique_xmalloc_ptr.
4912
4913 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
4914
4915         * NEWS: Expand the Pointer Authentication entry.
4916         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
4917         (aarch64_frame_unmask_lr): ... to this.
4918         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
4919         Call aarch64_frame_unmask_lr.
4920         * frame.c (struct frame_info): Add "masked" variable.
4921         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
4922         (fprint_frame): Check for masked pc.
4923         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
4924         declarations.
4925         * python/py-framefilter.c (py_print_frame): Check for masked pc.
4926         * stack.c (print_frame): Check for masked pc.
4927
4928 2019-08-06  Tom Tromey  <tom@tromey.com>
4929
4930         * stabsread.c (patch_block_stabs, read_one_struct_field)
4931         (read_enum_type): Use obstack_strndup.
4932         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
4933         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
4934         * dwarf2read.c (guess_full_die_structure_name)
4935         (anonymous_struct_prefix): Use obstack_strndup.
4936         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
4937         * c-exp.y (yylex): Use obstack_strndup.
4938         * ada-exp.y (write_object_renaming, write_ambiguous_var)
4939         (write_var_or_type): Use obstack_strndup.
4940
4941 2019-08-06  Tom Tromey  <tom@tromey.com>
4942
4943         * symfile.c (reread_symbols): Use obstack_strdup.
4944         * stabsread.c (read_type): Use obstack_strdup.
4945         * gdb_obstack.h (obstack_strdup): New overload.
4946         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
4947         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
4948         (dwarf2_canonicalize_name): Use obstack_strdup.
4949         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
4950         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
4951         Use obstack_strdup.
4952
4953 2019-08-06  Tom Tromey  <tom@tromey.com>
4954
4955         * gdb_obstack.h (obstack_strdup): Define.
4956         * gdb_obstack.c (obstack_strdup): Don't define.
4957
4958 2019-08-06  Tom Tromey  <tom@tromey.com>
4959
4960         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4961         obstack_strdup.
4962         * typeprint.c (typedef_hash_table::find_global_typedef): Use
4963         obstack_strdup.
4964         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4965         * stabsread.c (common_block_start): Use obstack_strdup.
4966         * objfiles.c (set_objfile_main_name, objfile): Use
4967         obstack_strdup.
4968         * namespace.c (add_using_directive): Use obstack_strdup.
4969         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
4970         * jit.c (finalize_symtab): Use obstack_strdup.
4971         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
4972         (guess_partial_die_structure_name, partial_die_info::fixup)
4973         (dwarf2_name): Use obstack_strdup.
4974         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
4975         obstack_strdup.
4976         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
4977         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4978         obstack_strdup.
4979         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
4980
4981 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4982
4983         * unittests/help-doc-selftests.c: New file.
4984         * Makefile.in: Add the new file.
4985
4986 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4987
4988         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4989         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
4990         the full first line, except when FOR_VALUE_PREFIX.  In this case,
4991         the trailing '.' is not output, and the first character is uppercased.
4992         (print_help_for_command): Update call to print_doc_line.
4993         (print_doc_of_command): Likewise.
4994         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4995         * cli/cli-option.c (append_indented_doc): Do not append newline.
4996         (build_help_option): Append newline after first appended_indented_doc
4997         only if a second call is done.
4998         (build_help): Append 2 new lines before each option, except the first
4999         one.
5000         * compile/compile.c (_initialize_compile): Add new lines after
5001         %OPTIONS%, when not at the end of the help.
5002         Change help doc or code
5003         producing the help doc to respect the invariants.
5004         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5005         Also removed the new line after 'Options:', as all other commands
5006         do not put an empty line between 'Options:' and the first option.
5007         * printcmd.c (_initialize_printcmd): Likewise.
5008         * stack.c (_initialize_stack): Likewise.
5009         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5010         incorrectly telling COMMAND is optional.
5011         * ada-lang.c (_initialize_ada_language): Change help doc or code
5012         producing the help doc to respect the invariants.
5013         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5014         * breakpoint.c (_initialize_breakpoint): Likewise.
5015         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5016         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5017         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5018         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5019         _initialize_cli_style): Likewise.
5020         * corelow.c (core_target_info): Likewise.
5021         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5022         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5023         * filesystem.c (_initialize_filesystem): Likewise.
5024         * frame.c (_initialize_frame): Likewise.
5025         * gnu-nat.c (add_task_commands): Likewise.
5026         * infcall.c (_initialize_infcall): Likewise.
5027         * infcmd.c (_initialize_infcmd): Likewise.
5028         * interps.c (_initialize_interpreter): Likewise.
5029         * language.c (_initialize_language): Likewise.
5030         * linux-fork.c (_initialize_linux_fork): Likewise.
5031         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5032         * maint.c (_initialize_maint_cmds): Likewise.
5033         * memattr.c (_initialize_mem): Likewise.
5034         * printcmd.c (_initialize_printcmd): Likewise.
5035         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5036         _RegEx): Likewise.
5037         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5038         * record-btrace.c (_initialize_record_btrace): Likewise.
5039         * record-full.c (_initialize_record_full): Likewise.
5040         * record.c (_initialize_record): Likewise.
5041         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5042         * regcache.c (_initialize_regcache): Likewise.
5043         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5044         _initialize_remote): Likewise.
5045         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5046         * serial.c (_initialize_serial): Likewise.
5047         * skip.c (_initialize_step_skip): Likewise.
5048         * source.c (_initialize_source): Likewise.
5049         * stack.c (_initialize_stack): Likewise.
5050         * symfile.c (_initialize_symfile): Likewise.
5051         * symtab.c (_initialize_symtab): Likewise.
5052         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5053         * top.c (init_main): Likewise.
5054         * tracefile-tfile.c (tfile_target_info): Likewise.
5055         * tracepoint.c (_initialize_tracepoint): Likewise.
5056         * tui/tui-win.c (_initialize_tui_win): Likewise.
5057         * utils.c (add_internal_problem_command): Likewise.
5058         * valprint.c (value_print_option_defs): Likewise.
5059
5060 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5061
5062         PR build/24886
5063         * configure.ac: Drop enable-libmcheck support.
5064         * configure, config.in: Rebuild.
5065         * libmcheck.m4: Remove.
5066         * acinclude.m4: Don't include it.
5067         * Makefile.in: Don't distribute it.
5068         * top.c (print_gdb_configuration): Don't mention it.
5069
5070 2019-08-06  Tom Tromey  <tom@tromey.com>
5071
5072         * utils.c (set_output_style): Sometimes pass stream to
5073         emit_style_escape.
5074         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5075         * record-btrace.c (btrace_insn_history): Update.
5076         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5077         method.
5078         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5079         Update initializers.
5080         <m_uiout>: New field.
5081         <m_di>: Move lower.
5082         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5083         Remove "uiout" parameter.
5084         (dump_insns): Update.
5085         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5086         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5087
5088 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5089
5090         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5091         (error_in_psymtab_expansion): Likewise.
5092         (lookup_symbol_via_quick_fns): Likewise.
5093         (basic_lookup_transparent_type_quick): Likewise.
5094         (basic_lookup_transparent_type_1): Likewise.
5095
5096 2019-08-06  Tom Tromey  <tromey@adacore.com>
5097
5098         * source.c (last_source_error): Now bool.
5099         (print_source_lines_base): Make "noprint" bool.  Only open
5100         source file when last_source_visited changes.
5101
5102 2019-08-06  Tom Tromey  <tromey@adacore.com>
5103
5104         * annotate.c (annotate_source_line): Use g_source_cache.
5105         * source-cache.c (source_cache::get_plain_source_lines): Change
5106         parameters.  Populate m_offset_cache.
5107         (source_cache::ensure): New method.
5108         (source_cache::get_line_charpos): New method.
5109         (extract_lines): Move lower.  Change parameters.
5110         (source_cache::get_source_lines): Move lower.
5111         * source-cache.h (class source_cache): Update comment.
5112         <get_line_charpos>: New method.
5113         <get_source_lines>: Update comment.
5114         <clear>: Clear m_offset_cache.
5115         <get_plain_source_lines>: Change parameters.
5116         <ensure>: New method
5117         <m_offset_cache>: New member.
5118         * source.c (forget_cached_source_info_for_objfile): Update.
5119         (info_source_command): Use g_source_cache.
5120         (find_source_lines, open_source_file_with_line_charpos): Remove.
5121         (print_source_lines_base, search_command_helper): Use g_source_cache.
5122         * source.h (open_source_file_with_line_charpos): Don't declare.
5123         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5124         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5125         Use g_source_cache.
5126
5127 2019-08-06  Tom Tromey  <tromey@adacore.com>
5128
5129         * source-cache.c (source_cache::get_plain_source_lines):
5130         Remove "first_line" and "last_line" parameters.
5131         (source_cache::get_source_lines): Cache plain text.
5132         * source-cache.h (class source_cache)
5133         <get_plain_source_lines>: Update.
5134
5135 2019-08-06  Tom Tromey  <tromey@adacore.com>
5136
5137         * source-cache.c (extract_lines): No longer a method.
5138         Changed type of parameter.  Include final newline.
5139         (selftests::extract_lines_test): New function.
5140         (_initialize_source_cache): Likewise.
5141         * source-cache.h (class source_cache)
5142         <extract_lines>: Don't declare.
5143
5144 2019-08-06  Tom Tromey  <tromey@adacore.com>
5145
5146         * breakpoint.c (init_breakpoint_sal): Update.
5147         (breakpoint): Update.
5148         * breakpoint.h (struct breakpoint) <filter>: Now a
5149         unique_xmalloc_ptr.
5150
5151 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5152
5153         * NEWS: Mention dictionary access on blocks.
5154         * python/py-block.c (blpy_getitem): New function.
5155         (block_object_as_mapping): New struct.
5156         (block_object_type): Use new struct for tp_as_mapping field.
5157
5158 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5159
5160         * objfiles.h (objfile): Add a comment describing partial symbols.
5161
5162 2019-08-05  Tom Tromey  <tromey@adacore.com>
5163
5164         * compile/compile.c (_initialize_compile): Use _(), not N_().
5165         * thread.c (_initialize_thread): Use _(), not N_().
5166         * stack.c (_initialize_stack): Use _(), not N_().
5167         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5168
5169 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5170
5171         * dwarf2read.c (struct dw2_symtab_iterator):
5172         <want_specific_block>: Remove.
5173         <block_index>: Change type to gdb::optional.
5174         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5175         change type of BLOCK_INDEX parameter to gdb::optional.
5176         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5177         (dw2_lookup_symbol): Don't pass argument for
5178         WANT_SPECIFIC_BLOCK.
5179         (dw2_expand_symtabs_for_function): Don't pass argument for
5180         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5181         (class dw2_debug_names_iterator)
5182         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5183         parameter, change BLOCK_INDEX type to gdb::optional.
5184         <m_want_specific_block>: Remove.
5185         <m_block_index>: Change type to gdb::optional.
5186         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5187         gdb::optional.  Re-write in function of gdb::optional.
5188         (dw2_debug_names_lookup_symbol): Don't pass argument for
5189         WANT_SPECIFIC_BLOCK.
5190         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5191         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5192         BLOCK_INDEX.
5193
5194 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5195
5196         * NEWS: Mention changes to "info sources" command.
5197
5198 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5199
5200         * symtab.c (filename_partial_match_opts): New struct type.
5201         (struct output_source_filename_data): New members
5202         regexp, c_regexp, partial_match.
5203         (output_source_filename): Use new members to decide to print file.
5204         (info_sources_option_defs): New variable.
5205         (make_info_sources_options_def_group, print_info_sources_header,
5206         info_sources_command_completer):
5207         New functions.
5208         (info_sources_command): Read new optional arguments.
5209         (_initialize_symtab): Update info sources help.
5210
5211 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5212
5213         * ada-lang.c (exception_support_info_v0): Renamed from...
5214         (default_exception_support_info): ... this.  Create new
5215         definition for v1.
5216         (ada_has_this_exception_support): Look up catch_handlers_sym.
5217         (ada_exception_support_info_sniffer): Try v0 after default.
5218
5219 2019-08-01  Tom Tromey  <tromey@adacore.com>
5220
5221         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5222         gdbarch.h.
5223
5224 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5225
5226         * s12z-tdep.c: Fix include path for s12z-opc.h.
5227
5228 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5229
5230         * NEWS: Require GNU make 3.82.
5231
5232 2019-07-16  Tom Tromey  <tom@tromey.com>
5233
5234         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5235         declare.
5236
5237 2019-07-30  Tom Tromey  <tromey@adacore.com>
5238
5239         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5240
5241 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5242
5243         * printcmd.c (print_address_symbolic): Print negative offsets.
5244         (build_address_symbolic): Force signed arithmetic when computing
5245         offset.
5246
5247 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5248
5249         PR/24474: Add a function to lookup static variables.
5250         * NEWS: Mention this new function.
5251         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5252         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5253         * python/python.c (python_GdbMethods): Add new function.
5254
5255 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5256
5257         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5258         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5259         (objfpy_lookup_static_symbol): New function.
5260         (objfile_object_methods): Add new functions.
5261
5262 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5263
5264         * NEWS: Mention 'set|show print frame-info'.  Mention new
5265         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5266         backtrace argument.  Mention that python frame filtering code
5267         is now consistent with what 'backtrace' command prints.
5268
5269 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5270
5271         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5272         comments.
5273         (print_frame_info_auto, print_frame_info_source_line,
5274         print_frame_info_location, print_frame_info_source_and_location,
5275         print_frame_info_location_and_address, print_frame_info_short_location):
5276         New declarations.
5277         (struct frame_print_options): New member print_frame_info.
5278         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5279         * stack.h (get_user_print_what_frame_info): New declaration.
5280         (frame_show_address): New declaration.
5281         * stack.c (print_frame_arguments_choices): New value 'presence'.
5282         (print_frame_info_auto, print_frame_info_source_line,
5283         print_frame_info_location, print_frame_info_source_and_location,
5284         print_frame_info_location_and_address, print_frame_info_short_location,
5285         print_frame_info_choices, print_frame_info_print_what): New definitions.
5286         (print_frame_args): Only print dots for args if print frame-arguments
5287         is 'presence'.
5288         (frame_print_option_defs): New element for "frame-info".
5289         (get_user_print_what_frame_info): New function.
5290         (frame_show_address): Make non static.  Move comment to stack.h.
5291         (print_frame_info_to_print_what): New function.
5292         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5293         to decide what to print.
5294         (backtrace_command_1): Handle the new print_frame_arguments_presence
5295         value.
5296         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5297         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5298         (py_print_frame): In non-mi mode, use LOCATION as default for
5299         print_what, similarly to frame information printed directly by
5300         backtrace command. Handle frame-info user option in non MI mode.
5301
5302 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5303
5304         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5305         Add case for debugging 32-bit target on 64-bit host.  Revise
5306         comment.
5307
5308 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5309
5310         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5311         instead of find_function_entry_range_from_pc.
5312
5313 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5314
5315         * stack.c (find_frame_funname): Remove code which preferred
5316         minsym over symtab sym in "certain pathological cases".
5317
5318         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5319         parameter.  Change type of "do_demangle" to bool.
5320         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5321         Pass suitable "prefer_sym_over_minsym" flag to
5322         build_address_symbolic().  Don't output "+" for negative offsets.
5323         * printcmd.c (print_address_symbolic): Update invocation of
5324         build_address_symbolic to include a "prefer_sym_over_minsym"
5325         flag.
5326         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5327         Restrict cases in which use of minimal symbol is preferred to that
5328         of a found symbol.  Update comments.
5329
5330         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5331         for entry pc when entry pc is out of range for that FDE.
5332
5333 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5334
5335         PR gdb/24839:
5336         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5337         type.
5338
5339 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5340
5341         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5342         this function's Python signature.
5343
5344
5345 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5346
5347         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5348         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5349         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5350         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5351         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5352
5353
5354 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5355
5356         * h8300-tdep.c (h8300_register_name_common): New.
5357         h8300_register_name): Use h8300_register_name_common.
5358         (h8300s_register_name): Likewise.
5359         (h8300sx_register_name): Likewise.
5360         (h8300h_register_nam): New.
5361         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5362
5363
5364 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5365
5366         * arm-tdep.c (arm_skip_cmse_entry): New function.
5367         (arm_is_sgstubs_section): New function.
5368         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5369
5370 2019-07-22  Tom Tromey  <tom@tromey.com>
5371
5372         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5373         Don't self-assign.
5374
5375 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5376
5377         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5378         type_print.
5379
5380 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5381
5382         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5383         so that GDB doesn't match any msymbols when searching in the
5384         TYPES_DOMAIN.
5385         (print_symbol_info): Print using typedef_print or type_print based
5386         on the type of the symbol.  Add updated FIXME comment moved from...
5387         (_initialize_symtab): ... move and update FIXME comment to above.
5388
5389 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5390
5391         * NEWS: Mention adding -q option to "info types".
5392         * symtab.c (struct info_types_options): New struct.
5393         (info_types_options_defs): New variable.
5394         (make_info_types_options_def_group): New function.
5395         (info_types_command): Use gdb::option framework to parse options.
5396         (info_types_command_completer): New function.
5397         (_initialize_symtab): Extend the help text on "info types" and
5398         register command completer.
5399
5400 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5401
5402         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5403         (lookup_symbol_in_objfile): Change int to block_enum and add a
5404         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5405
5406 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5407
5408         * MAINTAINERS (Write After Approval): Add self.
5409
5410 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5411
5412         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5413         instruction to the dummy code region.
5414
5415 2019-07-19  Tom Tromey  <tromey@adacore.com>
5416
5417         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5418         (ARGSUSED, PARAMS, __func__): Remove rules.
5419
5420 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5421
5422         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5423         * features/arm/arm-with-iwmmxt.c: Remove.
5424         * features/arm/arm-with-iwmmxt.xml: Remove.
5425         * features/arm/arm-with-m-fpa-layout.c: Remove.
5426         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5427         * features/arm/arm-with-m-vfp-d16.c: Remove.
5428         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5429         * features/arm/arm-with-m.c: Remove.
5430         * features/arm/arm-with-m.xml: Remove.
5431         * features/arm/arm-with-neon.c: Remove.
5432         * features/arm/arm-with-neon.xml: Remove.
5433         * features/arm/arm-with-vfpv2.c: Remove.
5434         * features/arm/arm-with-vfpv2.xml: Remove.
5435         * features/arm/arm-with-vfpv3.c: Remove.
5436         * features/arm/arm-with-vfpv3.xml: Remove.
5437
5438 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5439
5440         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5441
5442 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5443
5444         * arch/aarch32.c (aarch32_create_target_description): Create
5445         target descriptions using features.
5446         * arch/arm.c (arm_create_target_description)
5447         (arm_create_mprofile_target_description): Likewise.
5448         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5449
5450 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5451
5452         * Makefile.in: Add new files.
5453         * aarch32-tdep.c: New file.
5454         * aarch32-tdep.h: New file.
5455         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5456         Call aarch32_read_description.
5457         * arch/aarch32.c: New file.
5458         * arch/aarch32.h: New file.
5459         * arch/arm.c (arm_create_target_description)
5460         (arm_create_mprofile_target_description): New function.
5461         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5462         (arm_create_target_description)
5463         (arm_create_mprofile_target_description): New declaration.
5464         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5465         read_description functions.
5466         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5467         Likewise.
5468         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5469         * arm-tdep.c (tdesc_arm_list): New variable.
5470         (arm_register_g_packet_guesses): Call create description functions.
5471         (arm_read_description) (arm_read_mprofile_description): New
5472         function.
5473         * arm-tdep.h (arm_read_description)
5474         (arm_read_mprofile_description): Add declaration.
5475         * configure.tgt: Add new files.
5476
5477 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5478
5479         * top.c (new_ui_command): Open specified terminal just once.
5480
5481 2019-07-18  Tom Tromey  <tromey@adacore.com>
5482
5483         * symtab.c (main_name): Constify return type.
5484         * symfile.c (set_initial_language): Update.
5485         * symtab.h (main_name): Constify return type.
5486
5487 2019-07-17  Tom Tromey  <tom@tromey.com>
5488
5489         * tui/tui-winsource.c (tui_update_source_window)
5490         (tui_update_source_window_as_is)
5491         (tui_update_source_windows_with_line): Remove return.
5492         * tui/tui-disasm.c (tui_show_disassem)
5493         (tui_show_disassem_and_update_source): Remove return.
5494         * tui/tui.c (tui_reset): Remove return.
5495         * tui/tui-wingeneral.c
5496         (tui_check_and_display_highlight_if_needed): Remove return.
5497
5498 2019-07-17  Tom Tromey  <tom@tromey.com>
5499
5500         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5501
5502 2019-07-17  Tom Tromey  <tom@tromey.com>
5503
5504         * tui/tui-winsource.h (struct tui_exec_info_window)
5505         (struct tui_source_window_base): Move from tui-data.h.
5506         * tui/tui-winsource.c: Move many method definitions from
5507         elsewhere.  Remove "structuring" comments.
5508         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5509         (tui_source_window_base::refresh_window): Move to
5510         tui-winsource.c.
5511         * tui/tui-win.c (tui_source_window_base::refresh_all)
5512         (tui_source_window_base::update_tab_width)
5513         (tui_source_window_base::set_new_height)
5514         (tui_source_window_base::do_make_visible_with_new_height): Move to
5515         tui-winsource.c.
5516         * tui/tui-source.h: Update.
5517         * tui/tui-source.c (tui_source_window_base::reset): Move to
5518         tui-winsource.c.
5519         * tui/tui-disasm.h: Update.
5520         * tui/tui-data.h (struct tui_exec_info_window): Move to
5521         tui-winsource.h.
5522         (struct tui_source_window_base): Likewise.
5523         * tui/tui-data.c (tui_source_window_base::clear_detail)
5524         (tui_source_window_base, ~tui_source_window_base): Move to
5525         tui-winsource.c.
5526
5527 2019-07-17  Tom Tromey  <tom@tromey.com>
5528
5529         * tui/tui-win.c (tui_resize_all)
5530         (tui_source_window_base::update_tab_width)
5531         (tui_adjust_win_heights): Update.
5532         (tui_win_info::make_invisible_and_set_new_height): Rename from
5533         make_invisible_and_set_new_height.
5534         * tui/tui-data.h (struct tui_win_info)
5535         <make_invisible_and_set_new_height>: New method.
5536
5537 2019-07-17  Tom Tromey  <tom@tromey.com>
5538
5539         * tui/tui.c: Update.
5540         * tui/tui-source.h (struct tui_source_window): Move from
5541         tui-data.h.
5542         * tui/tui-layout.c: Update.
5543         * tui/tui-disasm.c: Update.
5544         * tui/tui-data.h (struct tui_source_window): Move to
5545         tui-source.h.
5546
5547 2019-07-17  Tom Tromey  <tom@tromey.com>
5548
5549         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5550         tui-data.h.
5551         * tui/tui-data.h (struct tui_disasm_window): Move to
5552         tui-disasm.h.
5553
5554 2019-07-17  Tom Tromey  <tom@tromey.com>
5555
5556         * tui/tui-regs.h (struct tui_data_item_window): Move from
5557         tui-data.h.
5558         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5559         * tui/tui-data.h (struct tui_data_item_window): Move to
5560         tui-regs.h.
5561         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5562
5563 2019-07-17  Tom Tromey  <tom@tromey.com>
5564
5565         * tui/tui.c: Update.
5566         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5567         (tui_cmd_window::max_height): Move to tui-command.c.
5568         * tui/tui-layout.c: Update.
5569         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5570         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5571         tui-command.c.
5572         * tui/tui-command.h (struct tui_cmd_window): Move from
5573         tui-data.h.
5574         * tui/tui-command.c: Remove "structuring" comments.
5575         (tui_cmd_window::clear_detail)
5576         (tui_cmd_window::do_make_visible_with_new_height)
5577         (tui_cmd_window::max_height): Move from elsewhere.
5578
5579 2019-07-17  Tom Tromey  <tom@tromey.com>
5580
5581         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5582         Now static.
5583         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5584         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5585
5586 2019-07-17  Tom Tromey  <tom@tromey.com>
5587
5588         * tui/tui.c: Update.
5589         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5590         tui-regs.c.
5591         * tui/tui-windata.h: Remove file.
5592         * tui/tui-windata.c: Remove file.
5593         * tui/tui-win.c (tui_data_window::set_new_height)
5594         (tui_data_window::do_make_visible_with_new_height): Move to
5595         tui-regs.c.
5596         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5597         * tui/tui-regs.c: Remove "structuring" comments.
5598         (tui_data_window::first_data_item_displayed)
5599         (tui_data_window::delete_data_content_windows)
5600         (tui_data_window::erase_data_content)
5601         (tui_data_window::display_all_data)
5602         (tui_data_window::refresh_all)
5603         (tui_data_window::do_scroll_vertical)
5604         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5605         (tui_data_window::do_make_visible_with_new_height)
5606         (tui_data_window::refresh_window): Move from elsewhere.
5607         (_initialize_tui_regs): Move to end of file.
5608         * tui/tui-layout.c: Update.
5609         * tui/tui-hooks.c: Update.
5610         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5611         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5612         tui-regs.c.
5613         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5614
5615 2019-07-17  Tom Tromey  <tom@tromey.com>
5616
5617         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5618         seen.
5619
5620 2019-07-17  Tom Tromey  <tom@tromey.com>
5621
5622         * tui/tui-win.c (tui_source_window_base::set_new_height)
5623         (tui_source_window_base::do_make_visible_with_new_height): Use
5624         m_has_locator field directly.
5625         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5626         method.
5627         (struct tui_source_window_base) <has_locator>: Likewise.
5628
5629 2019-07-17  Tom Tromey  <tom@tromey.com>
5630
5631         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5632         Don't declare.
5633         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5634         Remove.
5635         * tui/tui-win.c (tui_source_window_base::set_new_height)
5636         (tui_source_window_base::set_new_height)
5637         (make_invisible_and_set_new_height)
5638         (tui_source_window_base::do_make_visible_with_new_height)
5639         (tui_source_window_base::do_make_visible_with_new_height):
5640         Update.
5641         * tui/tui-layout.c (show_source_disasm_command, show_data)
5642         (show_source_or_disasm_and_command): Update.
5643         * tui/tui-layout.c (show_layout): Update.
5644
5645 2019-07-17  Tom Tromey  <tom@tromey.com>
5646
5647         * tui/tui-layout.c (make_data_window): Remove.
5648         (show_data): Unify creation and re-initialization cases.
5649
5650 2019-07-17  Tom Tromey  <tom@tromey.com>
5651
5652         * tui/tui-layout.c (make_source_window, make_disasm_window):
5653         Remove.
5654         (show_data): Unify creation and re-initialization cases.
5655
5656 2019-07-17  Tom Tromey  <tom@tromey.com>
5657
5658         * tui/tui-layout.c (make_command_window): Remove.
5659         (show_source_disasm_command, show_source_or_disasm_and_command):
5660         Unify creation and re-initialization cases.
5661
5662 2019-07-17  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5665         creation and re-initialization cases.
5666
5667 2019-07-17  Tom Tromey  <tom@tromey.com>
5668
5669         * tui/tui-regs.c (tui_get_register): Return void.
5670
5671 2019-07-17  Tom Tromey  <tom@tromey.com>
5672
5673         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5674         Simplify.
5675
5676 2019-07-17  Tom Tromey  <tom@tromey.com>
5677
5678         * tui/tui-layout.c (show_source_disasm_command): Simplify window
5679         resetting.
5680
5681 2019-07-17  Tom Tromey  <tom@tromey.com>
5682
5683         * tui/tui.h (tui_set_layout_by_name): Don't declare.
5684         * tui/tui-regs.c (tui_reg_layout): New function.
5685         (tui_show_registers, tui_reg_command): Use it.
5686         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5687         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
5688         parameters.
5689         (tui_layout_command): Remove.
5690
5691 2019-07-17  Tom Tromey  <tom@tromey.com>
5692
5693         * tui/tui-layout.h (tui/tui-layout): Return void.
5694         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
5695
5696 2019-07-17  Tom Tromey  <tom@tromey.com>
5697
5698         * tui/tui-layout.c (show_source_disasm_command, show_data):
5699         Update.
5700         (reset_locator): Remove.
5701         (show_source_or_disasm_and_command): Update.
5702
5703 2019-07-17  Tom Tromey  <tom@tromey.com>
5704
5705         * tui/tui-source.c (tui_source_window_base::reset): Remove
5706         win_type parameter.
5707         * tui/tui-layout.c (make_command_window, make_source_window)
5708         (make_disasm_window, make_data_window)
5709         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5710         (reset_locator, show_source_or_disasm_and_command): Update.
5711         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5712         win_type parameter.
5713         (struct tui_source_window_base) <reset>: Likewise.
5714
5715 2019-07-17  Tom Tromey  <tom@tromey.com>
5716
5717         * tui/tui-layout.c (show_source_disasm_command): Use
5718         reset_locator.
5719         (reset_locator): New function.
5720         (init_and_make_win): Remove.
5721         (show_source_or_disasm_and_command): Use reset_locator.
5722
5723 2019-07-17  Tom Tromey  <tom@tromey.com>
5724
5725         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5726         condition.
5727         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5728         Remove condition.
5729         * tui/tui-source.c (tui_source_window_base::reset): New method.
5730         * tui/tui-layout.c (make_command_window): Don't call
5731         init_and_make_win.
5732         (make_source_window, make_disasm_window): Don't call
5733         make_source_or_disasm_window.
5734         (make_data_window): Don't call init_and_make_win.  Change calling
5735         convention.
5736         (show_source_disasm_command, show_data): Simplify.
5737         (make_source_or_disasm_window): Remove.
5738         (show_source_or_disasm_and_command): Simplify.
5739         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5740         (struct tui_source_window_base) <reset>: Likewise.
5741         <execution_info>: Remove initializer.
5742         * tui/tui-data.c (tui_source_window_base): Initialize
5743         execution_info.
5744
5745 2019-07-17  Tom Tromey  <tom@tromey.com>
5746
5747         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5748         variable.
5749
5750 2019-07-17  Tom Tromey  <tom@tromey.com>
5751
5752         * tui/tui.c (tui_rl_other_window): Update.
5753         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5754         superclass method first.  Always iterate over regs_content.
5755         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5756         method.
5757         * tui/tui-win.c (tui_set_focus_command): Update.
5758
5759 2019-07-17  Tom Tromey  <tom@tromey.com>
5760
5761         * tui/tui-win.c (tui_set_focus_command): Rename from
5762         tui_set_focus.  Call tui_enable.
5763         (tui_set_focus_command): Remove.
5764
5765 2019-07-17  Tom Tromey  <tom@tromey.com>
5766
5767         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5768         refresh_window.
5769         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5770         touchwin.
5771         (tui_data_window::refresh_window): Call refresh_window on data
5772         items.  Always call superclass refresh_window.
5773         (tui_win_info::refresh): Remove.
5774         (tui_source_window_base::refresh_window): Update.
5775         (tui_refresh_all): Update.
5776         * tui/tui-layout.c (show_source_disasm_command): Remove call to
5777         refresh_window.
5778         (show_source_or_disasm_and_command): Likewise.
5779         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5780         (struct tui_source_window_base) <refresh>: Likewise.
5781
5782 2019-07-17  Tom Tromey  <tom@tromey.com>
5783
5784         * tui/tui-winsource.c (tui_clear_source_content)
5785         (tui_show_source_content): Update.
5786         * tui/tui-source.c (tui_source_window::showing_source_p): Check
5787         whether content is empty.
5788         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5789         Remove.
5790
5791 2019-07-17  Tom Tromey  <tom@tromey.com>
5792
5793         * tui/tui-winsource.c (tui_erase_source_content): Clear the
5794         window's contents.
5795         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5796         * tui/tui-source.c (tui_set_source_content_nil): Remove.
5797
5798 2019-07-17  Tom Tromey  <tom@tromey.com>
5799
5800         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5801         (struct tui_data_item_window): Update.
5802
5803 2019-07-17  Tom Tromey  <tom@tromey.com>
5804
5805         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5806         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5807         defines.
5808
5809 2019-07-17  Tom Tromey  <tom@tromey.com>
5810
5811         * tui/tui-winsource.h (tui_erase_source_content)
5812         (tui_clear_source_content): Remove "display_prompt" parameter.
5813         * tui/tui-winsource.c (tui_update_source_window_as_is)
5814         (tui_update_source_windows_with_addr): Update.
5815         (tui_clear_source_content): Remove "display_prompt" parameter.
5816         (tui_erase_source_content): Likewise.  Simplify.
5817         (tui_show_source_content): Update.
5818         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5819         * tui/tui-stack.c (tui_show_frame_info): Update.
5820         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5821         Remove defines.
5822
5823 2019-07-17  Tom Tromey  <tom@tromey.com>
5824
5825         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5826         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5827         parameter.
5828         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5829         parameter.
5830
5831 2019-07-17  Tom Tromey  <tom@tromey.com>
5832
5833         * tui/tui-winsource.c (tui_clear_source_content)
5834         (tui_show_source_content, tui_show_exec_info_content)
5835         (tui_clear_exec_info_content): Update.
5836         * tui/tui-stack.c (tui_show_locator_content): Update.
5837         (tui_show_frame_info): Update.
5838         * tui/tui-source.h (tui_source_window): Don't declare.
5839         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5840         from tui_source_is_displayed.
5841         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5842         Remove field.
5843         (struct tui_source_window_base) <content_in_use>: New field.  Now
5844         bool.
5845         (struct tui_source_window) <showing_source_p>: New method.
5846         (TUI_SRC_WIN): Change cast.
5847         * tui/tui-data.c (tui_initialize_static_data): Update.
5848
5849 2019-07-17  Tom Tromey  <tom@tromey.com>
5850
5851         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5852         location_matches_p.
5853         * tui/tui-source.c (tui_source_window::location_matches_p): New
5854         method.
5855         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5856         method.
5857         * tui/tui-data.h (struct tui_source_window_base)
5858         <location_matches_p>: New method.
5859         (struct tui_source_window, struct tui_disasm_window)
5860         <location_matches_p>: Likewise.
5861
5862 2019-07-17  Tom Tromey  <tom@tromey.com>
5863
5864         * tui/tui-win.c (tui_set_win_height_command): Rename from
5865         tui_set_win_height.
5866         (tui_set_win_height_command): Remove.
5867
5868 2019-07-17  Tom Tromey  <tom@tromey.com>
5869
5870         * tui/tui-source.c (tui_source_window): New constructor.  Add
5871         observer.
5872         (~tui_source_window): New destructor.
5873         (tui_source_window::style_changed): New method.
5874         * tui/tui-hooks.c (tui_redisplay_source): Remove.
5875         (tui_attach_detach_observers): Update.
5876         * tui/tui-data.h (struct tui_source_window): Make constructor not
5877         inline.  Add destructor.
5878         (struct tui_source_window) <style_changed>: New method.
5879         <m_observable>: New member.
5880
5881 2019-07-17  Tom Tromey  <tom@tromey.com>
5882
5883         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5884         * tui/tui-win.c (tui_resize_all): Fix typo.
5885
5886 2019-07-17  Tom Tromey  <tom@tromey.com>
5887
5888         * tui/tui-wingeneral.h (tui_refresh_all): Update.
5889         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5890         (tui_refresh_all): Remove "list" parameter.  Use foreach.
5891         * tui/tui-win.c (window_name_completer): Use foreach.
5892         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5893         (update_tab_width): Likewise.
5894         * tui/tui-layout.c (show_layout): Update.
5895         * tui/tui-data.h (class tui_window_iterator): New.
5896         (struct all_tui_windows): New.
5897         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5898
5899 2019-07-17  Tom Tromey  <tom@tromey.com>
5900
5901         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
5902         parameter.  Don't reference globals.
5903         (tui_reg_command): Update.
5904
5905 2019-07-17  Tom Tromey  <tom@tromey.com>
5906
5907         * tui/tui-regs.c (tui_show_registers): Simplify.
5908
5909 2019-07-17  Tom Tromey  <tom@tromey.com>
5910
5911         * tui/tui-regs.c (tui_show_registers): Update.
5912         (tui_show_register_group): Add win_info parameter.
5913
5914 2019-07-17  Tom Tromey  <tom@tromey.com>
5915
5916         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
5917         Rename from tui_display_reg_element_at_line.
5918         (tui_data_window::display_registers_from_line): Update.
5919         * tui/tui-data.h (struct tui_data_window)
5920         <display_reg_element_at_line>: New method.
5921
5922 2019-07-17  Tom Tromey  <tom@tromey.com>
5923
5924         * tui/tui-regs.h (tui_display_registers_from)
5925         (tui_display_registers_from_line): Don't declare.
5926         * tui/tui-windata.c (tui_data_window::display_all_data)
5927         (tui_data_window::refresh_all)
5928         (tui_data_window::do_scroll_vertical): Update.
5929         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
5930         from tui_display_registers_from.
5931         (tui_display_reg_element_at_line): Update.
5932         (tui_data_window::display_registers_from_line): Rename from
5933         tui_display_registers_from_line.
5934         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
5935         display_registers_from_line>: New methods.
5936
5937 2019-07-17  Tom Tromey  <tom@tromey.com>
5938
5939         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
5940         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
5941         from tui_erase_data_content.
5942         (tui_data_window::display_all_data)
5943         (tui_data_window::refresh_all)
5944         (tui_data_window::do_scroll_vertical): Update.
5945         * tui/tui-regs.c (tui_show_registers): Update.
5946         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
5947         New method.
5948
5949 2019-07-17  Tom Tromey  <tom@tromey.com>
5950
5951         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
5952         declare.
5953         * tui/tui-windata.c
5954         (tui_data_window::delete_data_content_windows): Rename from
5955         tui_delete_data_content_windows.
5956         (tui_data_window::display_all_data)
5957         (tui_data_window::do_scroll_vertical): Update.
5958         * tui/tui-data.h (struct tui_data_window)
5959         <delete_data_content_windows>: New method.
5960
5961 2019-07-17  Tom Tromey  <tom@tromey.com>
5962
5963         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5964         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5965
5966 2019-07-17  Tom Tromey  <tom@tromey.com>
5967
5968         * tui/tui-windata.h (tui_display_all_data): Don't declare.
5969         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
5970         from tui_display_all_data.
5971         * tui/tui-win.c
5972         (tui_data_window::do_make_visible_with_new_height): Update.
5973         * tui/tui-regs.c (tui_show_registers): Update.
5974         * tui/tui-layout.c (tui_set_layout): Update.
5975         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
5976         method.
5977
5978 2019-07-17  Tom Tromey  <tom@tromey.com>
5979
5980         * tui/tui-windata.h (tui_display_data_from): Don't declare.
5981         * tui/tui-windata.c (tui_display_data_from): Remove.
5982         (tui_data_window::refresh_all): Update.
5983
5984 2019-07-17  Tom Tromey  <tom@tromey.com>
5985
5986         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
5987         * tui/tui-windata.c (tui_display_data_from_line): Remove.
5988         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
5989         tui_display_registers_from_line.
5990         * tui/tui-regs.h (tui_display_registers_from_line): Update.
5991         * tui/tui-regs.c (tui_display_registers_from_line): Remove
5992         "force_display" parameter.
5993
5994 2019-07-17  Tom Tromey  <tom@tromey.com>
5995
5996         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5997         declare.
5998         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5999         Rename from tui_first_reg_element_no_inline.
6000         (tui_display_reg_element_at_line)
6001         (tui_display_registers_from_line): Update.
6002         * tui/tui-data.h (struct tui_data_window)
6003         <first_reg_element_no_inline>: New method.
6004
6005 2019-07-17  Tom Tromey  <tom@tromey.com>
6006
6007         * tui/tui-windata.c (tui_display_data_from)
6008         (tui_data_window::do_scroll_vertical): Update.
6009         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6010         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6011         Rename from tui_line_from_reg_element_no.
6012         (tui_display_registers_from_line): Update.
6013         * tui/tui-data.h (struct tui_data_window)
6014         <line_from_reg_element_no>: New method.
6015
6016 2019-07-17  Tom Tromey  <tom@tromey.com>
6017
6018         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6019         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6020         tui_last_regs_line_no.
6021         (tui_display_reg_element_at_line)
6022         (tui_display_registers_from_line): Update.
6023         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6024         method.
6025
6026 2019-07-17  Tom Tromey  <tom@tromey.com>
6027
6028         PR tui/24722:
6029         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6030         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6031         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6032         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6033         (tui_update_breakpoint_info): Likewise.
6034         * tui/tui-hooks.c (tui_event_create_breakpoint)
6035         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6036         Update.
6037
6038 2019-07-17  Tom Tromey  <tom@tromey.com>
6039
6040         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6041
6042 2019-07-17  Tom Tromey  <tom@tromey.com>
6043
6044         * tui/tui-winsource.c (tui_update_source_window_as_is)
6045         (tui_update_source_windows_with_addr): Update.
6046         * tui/tui-source.h (tui_set_source_content)
6047         (tui_show_symtab_source): Add "win_info" parameter.
6048         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6049         parameter.
6050         (tui_show_symtab_source): Likewise.
6051
6052 2019-07-17  Tom Tromey  <tom@tromey.com>
6053
6054         * tui/tui-wingeneral.c
6055         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6056
6057 2019-07-17  Tom Tromey  <tom@tromey.com>
6058
6059         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6060         (struct tui_cmd_window) <can_scroll>: New method.
6061         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6062         method.
6063
6064 2019-07-17  Tom Tromey  <tromey@adacore.com>
6065
6066         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6067         do_field_signed>: Rename.  Change type of "value".
6068         * ui-out.c (ui_out::field_signed): Rename from field_int.
6069         Change type of "value".
6070         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6071         type of "value".
6072         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6073         do_field_int.  Change type of "value".
6074         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6075         do_field_int.  Change type of "value".
6076         * tracepoint.c (trace_status_mi, tfind_1)
6077         (print_one_static_tracepoint_marker): Update.
6078         * thread.c (print_thread_info_1, print_selected_thread_frame):
6079         Update.
6080         * stack.c (print_frame, print_frame_info): Update.
6081         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6082         Update.
6083         * source.c (print_source_lines_base): Update.
6084         * skip.c (info_skip_command): Update.
6085         * record-btrace.c (btrace_ui_out_decode_error)
6086         (btrace_call_history_src_line): Update.
6087         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6088         Update.
6089         * progspace.c (print_program_space): Update.
6090         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6091         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6092         do_field_int.  Change type of "value".
6093         * mi/mi-out.c (mi_ui_out::do_table_begin)
6094         (mi_ui_out::do_table_header): Update.
6095         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6096         type of "value".
6097         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6098         (mi_cmd_data_list_changed_registers, output_register)
6099         (mi_cmd_data_read_memory, mi_load_progress)
6100         (mi_cmd_trace_frame_collected): Update.
6101         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6102         Update.
6103         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6104         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6105         (mi_cmd_var_list_children, varobj_update_one): Update.
6106         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6107         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6108         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6109         * inferior.c (print_inferior): Update.
6110         * gdb_bfd.c (print_one_bfd): Update.
6111         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6112         Update.
6113         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6114         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6115         do_field_int.  Change type of "value".
6116         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6117         do_field_int.  Change type of "value".
6118         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6119         (print_one_breakpoint_location, print_it_catch_fork)
6120         (print_one_catch_fork, print_it_catch_vfork)
6121         (print_one_catch_vfork, print_it_catch_solib)
6122         (print_it_catch_exec, print_it_ranged_breakpoint)
6123         (print_mention_watchpoint, print_mention_masked_watchpoint)
6124         (bkpt_print_it, update_static_tracepoint): Update.
6125         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6126         * break-catch-syscall.c (print_it_catch_syscall): Update.
6127         * ada-tasks.c (print_ada_task_info): Update.
6128         * ada-lang.c (print_it_exception, print_mention_exception):
6129         Update.
6130
6131 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6132
6133         PR breakpoints/24541
6134         * gdbarch.c: Regenerate.
6135         * gdbarch.h: Regenerate.
6136         * gdbarch.sh: Adjust return type and parameter types for
6137         'stap_adjust_register'.
6138         (i386_stap_adjust_register): Adjust signature and return new
6139         register name.
6140         * stap-probe.c (stap_parse_register_operand): Adjust use of
6141         'gdbarch_stap_adjust_register'.
6142
6143 2019-07-17  Tom Tromey  <tromey@adacore.com>
6144
6145         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6146         declare VEC.
6147         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6148         std::vector.
6149         (struct s390_process_info): Add initializers.
6150         (s390_add_process): Use new.
6151         (s390_linux_nat_target::low_forget_process): Use delete.
6152         (s390_linux_nat_target::low_new_fork)
6153         (s390_linux_nat_target::stopped_by_watchpoint)
6154         (s390_linux_nat_target::low_prepare_to_resume)
6155         (s390_linux_nat_target::insert_watchpoint)
6156         (s390_linux_nat_target::insert_hw_breakpoint)
6157         (s390_linux_nat_target::remove_watchpoint)
6158         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6159
6160 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6161
6162         * aarch64-fbsd-nat.c: Include regcache.h.
6163         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6164         argument.
6165         (aarch64_fbsd_nat_target::fetch_registers)
6166         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6167         variable.
6168         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6169
6170 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6171
6172         * fbsd-nat.c: Include gdbarch.h.
6173
6174 2019-07-15  Tom Tromey  <tromey@adacore.com>
6175
6176         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6177
6178 2019-07-15  Tom Tromey  <tromey@adacore.com>
6179
6180         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6181         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6182         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6183         * cli-out.c (cli_ui_out::do_field_int): New method.
6184         * ui-out.c (ui_out::field_unsigned): New method.
6185         * symfile.c (generic_load): Use field_unsigned.
6186         (print_transfer_performance): Likewise.
6187         * record-btrace.c (ui_out_field_uint): Remove.
6188         (btrace_call_history_insn_range, btrace_call_history): Use
6189         field_unsigned.
6190         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6191         field_unsigned.
6192         * ui-out.h (class ui_out) <field_unsigned>: New method.
6193         <do_field_unsigned>: Likewise.
6194
6195 2019-07-15  Tom Tromey  <tromey@adacore.com>
6196
6197         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6198         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6199         * target.c (flash_erase_command): Use field_string.
6200         * infrun.c (print_signal_received_reason): Use field_string.
6201         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6202         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6203         field_string.
6204         * ada-tasks.c (print_ada_task_info): Use field_string.
6205
6206 2019-07-15  Tom Tromey  <tromey@adacore.com>
6207
6208         * target.c (flash_erase_command): Use field_core_addr.
6209         * symfile.c (generic_load): Use field_core_addr.
6210         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6211         Use field_core_addr.
6212         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6213         field_core_addr.
6214
6215 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6216
6217         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6218         value if its desired type is smaller than a CORE_ADDR and signed.
6219
6220 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6221
6222         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6223         of changes to field names, and use new is_reference field to
6224         decide if a property is a reference or not.
6225         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6226         field.
6227         (struct dwarf2_property_baton): Update header comment, rename
6228         'referenced_type' to 'property_type' and update comments.
6229         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6230         default property type, store in property baton, update to take
6231         accound of renamed field.
6232         (read_func_scope): Update call to attr_to_dynamic_prop.
6233         (read_array_type): Likewise.
6234         (dwarf2_per_cu_addr_sized_int_type): New function.
6235         (read_subrange_index_type): Move type finding code to
6236         dwarf2_per_cu_addr_sized_int_type.
6237         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6238         (dwarf2_per_cu_addr_type): New function.
6239         (set_die_type): Update calls to attr_to_dynamic_prop.
6240
6241 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6242
6243         * dwarf2read.c (read_subrange_index_type): New function.
6244         (read_subrange_type): Move code into new function and call it.
6245         * gdbtypes.c (create_range_type): Add some asserts.
6246
6247 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6248
6249         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6250         update return statements.
6251         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6252         declaration, and update comment to match.
6253         * gdbtypes.c (resolve_dynamic_array): Update call to
6254         dwarf2_evaluate_property to match new return type.
6255
6256 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6257
6258         * valarith.c (value_subscripted_rvalue): Change lowerbound
6259         parameter type from int to LONGEST.
6260         * value.h (value_subscripted_rvalue): Likewise in declaration.
6261
6262 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6263
6264         * cli/cli-utils.c (info_print_command_completer): New function.
6265         * cli/cli-utils.h: Add 'completer.h' include, and forward
6266         declaration for 'struct cmd_list_element'.
6267         (info_print_command_completer): Declare.
6268         * stack.c (_initialize_stack): Add completer for 'info locals' and
6269         'info args'.
6270         * symtab.c (_initialize_symtab): Add completer for 'info
6271         variables' and 'info functions'.
6272         * NEWS: Mention completion for additional info commands.
6273
6274 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6275
6276         * cli/cli-utils.c (extract_info_print_args): Delete.
6277         (extract_arg_maybe_quoted): Delete.
6278         (info_print_options_defs): New variable.
6279         (make_info_print_options_def_group): New function.
6280         (extract_info_print_options): Define new function.
6281         * cli/cli-utils.h (extract_info_print_args): Delete.
6282         (struct info_print_options): New structure.
6283         (extract_info_print_options): Declare new function.
6284         * stack.c (info_locals_command): Update to use new
6285         extract_info_print_options, also add a header comment.
6286         (info_args_command): Likewise.
6287         * symtab.c (info_variables_command): Likewise.
6288         (info_functions_command): Likewise.
6289
6290 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6291
6292         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6293         to extract string arguments.
6294         * common/common-utils.c (extract_string_maybe_quoted): New function.
6295         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6296
6297 2019-07-11  Tom Tromey  <tromey@adacore.com>
6298
6299         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6300         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6301         * top.h (gdbinit): Don't declare.
6302         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6303         into...
6304         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6305         * top.c (gdb_init): Don't call init_cli_cmds.
6306         (gdbinit): Remove.
6307         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6308
6309 2019-07-11  Tom Tromey  <tromey@adacore.com>
6310
6311         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6312         after it has been moved.
6313
6314 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6315
6316         * valops.c (value_must_coerce_to_target): Change return type to
6317         bool.
6318         * value.h (value_must_coerce_to_target): Likewise.
6319
6320 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6321
6322         * breakpoint.c (is_hardware_watchpoint): Remove
6323         forward-declaration.
6324         (is_masked_watchpoint): Change return type to bool.
6325         (is_tracepoint): Likewise.
6326         (is_breakpoint): Likewise.
6327         (is_hardware_watchpoint): Likewise.
6328         (is_watchpoint): Likewise.
6329         (is_no_memory_software_watchpoint): Likewise.
6330         (is_catchpoint): Likewise.
6331         (breakpoint_1): Make FILTER parameter's return type bool.
6332         is_masked_watchpoint): Change return type to bool.
6333         (save_breakpoints): Make FILTER parameter's return type bool.
6334         * breakpoint.h (is_breakpoint): Change return type to bool.
6335         (is_watchpoint): Likewise.
6336         (is_catchpoint): Likewise.
6337         (is_tracepoint): Likewise.
6338
6339 2019-07-10  Tom Tromey  <tom@tromey.com>
6340
6341         * defs.h: Don't include gdbarch.h.
6342         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6343         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6344         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6345         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6346         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6347         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6348         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6349         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6350         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6351         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6352         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6353         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6354         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6355         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6356         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6357         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6358         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6359         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6360         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6361         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6362         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6363         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6364         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6365         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6366         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6367         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6368         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6369
6370 2019-07-10  Tom Tromey  <tromey@adacore.com>
6371
6372         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6373         * breakpoint.c (init_ada_exception_breakpoint): Register as
6374         bp_catchpoint.
6375         (print_one_breakpoint_location, print_one_breakpoint): Use
6376         is_ada_exception_catchpoint.
6377         * ada-lang.c (class ada_catchpoint_location): Pass
6378         bp_loc_software_breakpoint to bp_location constructor.
6379         (is_ada_exception_catchpoint): New function.
6380
6381 2019-07-10  Tom Tromey  <tromey@adacore.com>
6382
6383         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6384         VEC.
6385         (struct arm_exidx_entry): New method operator<.
6386         (struct arm_exidx_data) <section_maps>: Change type.
6387         (arm_exidx_data_free): Remove.
6388         (arm_exidx_data_key): Change type.  Move lower.
6389         (arm_exidx_new_objfile): Update.
6390         (arm_compare_exidx_entries): Remove.
6391         (arm_find_exidx_entry, _initialize_arm_tdep)
6392
6393 2019-07-10  Tom Tromey  <tromey@adacore.com>
6394
6395         * solib-spu.c (ocl_program_data_key): Change type.
6396         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6397         Update.
6398
6399 2019-07-10  Tom Tromey  <tromey@adacore.com>
6400
6401         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6402         (struct solib_aix_inferior_data) <library_list>: Change type.
6403         (solib_aix_inferior_data_handle): Change type.
6404         (get_solib_aix_inferior_data): Update.
6405         (solib_aix_free_library_list): Remove.
6406         (library_list_start_library): Update.
6407         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6408         return type.
6409         (solib_aix_get_library_list)
6410         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6411         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6412
6413 2019-07-10  Tom Tromey  <tromey@adacore.com>
6414
6415         * solib-dsbt.c (struct dsbt_info): Add initializers.
6416         (solib_dsbt_pspace_data): Change type.
6417         (dsbt_pspace_data_cleanup): Remove.
6418         (get_dsbt_info, _initialize_dsbt_solib): Update.
6419
6420 2019-07-10  Tom Tromey  <tromey@adacore.com>
6421
6422         * spu-tdep.c (spu_overlay_data): Change type.
6423         (spu_get_overlay_table, spu_overlay_new_objfile)
6424         (_initialize_spu_tdep): Update.
6425
6426 2019-07-10  Tom Tromey  <tromey@adacore.com>
6427
6428         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6429         destructor.
6430         (dbx_objfile_data_key): Change type and declare later.
6431         (DBX_SYMFILE_INFO): Rewrite.
6432         * dbxread.c (dbx_objfile_data_key): Change type.
6433         (dbx_symfile_init): Update.
6434         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6435         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6436         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6437
6438 2019-07-10  Tom Tromey  <tromey@adacore.com>
6439
6440         * jit.c (jit_program_space_key): Change type.  Move lower.
6441         (get_jit_program_space_data): Update.
6442         (jit_program_space_data_cleanup): Remove.
6443         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6444         Update.
6445         (struct jit_program_space_data): Add initializers.
6446
6447 2019-07-10  Tom Tromey  <tromey@adacore.com>
6448
6449         * solib-darwin.c (struct darwin_info): Add initializers.
6450         (solib_darwin_pspace_data): Change type.
6451         (darwin_pspace_data_cleanup): Remove.
6452         (get_darwin_info, _initialize_darwin_solib): Update.
6453
6454 2019-07-10  Tom Tromey  <tromey@adacore.com>
6455
6456         * remote-sim.c (struct sim_inferior_data): Add initializers,
6457         constructor, and destructor.
6458         (sim_inferior_data_key): Change type.  Move lower.
6459         (check_for_duplicate_sim_descriptor): Update.
6460         (get_sim_inferior_data): Use new.  Update.
6461         (~sim_inferior_data_cleanup): Rename from
6462         sim_inferior_data_cleanup.  Simplify.
6463         (gdbsim_close_inferior, simulator_command)
6464         (sim_command_completer, _initialize_remote_sim): Update.
6465         (next_pid, INITIAL_PID): Move earlier.
6466
6467 2019-07-10  Tom Tromey  <tromey@adacore.com>
6468
6469         * python/python-internal.h (create_thread_object): Return
6470         gdbpy_ref.
6471         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6472         * python/py-inferior.c (struct threadlist_entry): Add
6473         constructor.
6474         <thread_obj>: Now a gdbpy_ref.
6475         (thread_to_thread_object): Update.
6476         (add_thread_object): Use new.
6477         (delete_thread_object): Use delete.
6478         (infpy_threads): Update.
6479         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6480         GIL.
6481
6482 2019-07-10  Tom Tromey  <tromey@adacore.com>
6483
6484         * valops.c (value_cast): Specialize error message for Ada.
6485
6486 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6487
6488         * breakpoint.c (breakpoint_1): Update doc and parameter names.
6489
6490 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6491
6492         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6493         bpstat_should_step): Return bool, adjust comments.
6494         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6495         bpstat_should_step): Likewise.
6496
6497 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6498
6499         * features/Makefile: Use feature target descriptions for Arm.
6500         * features/arm/arm-core.c: Generate new file.
6501         * features/arm/arm-fpa.c: Likewise.
6502         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6503         * features/arm/arm-m-profile.c: Likewise.
6504         * features/arm/arm-vfpv2.c: Likewise.
6505         * features/arm/arm-vfpv3.c: Likewise.
6506         * features/arm/xscale-iwmmxt.c: Likewise.
6507         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6508
6509 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6510
6511         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6512         ptrace earlier.
6513
6514 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6515
6516         * features/aarch64-pauth.c: Regenerate.
6517
6518 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6519
6520         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6521         bool.
6522         (bpstat_what): Use false instead of 0.
6523
6524 2019-07-09  Pedro Alves  <palves@redhat.com>
6525
6526         * break-catch-throw.c (is_exception_catchpoint): New.
6527         * breakpoint.c (print_one_breakpoint_location): New parameter
6528         'raw_loc'.  Handle it.  Use
6529         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6530         looking at the breakpoint's type.
6531         (print_one_breakpoint): If handling "maint info breakpoints", also
6532         print locations of exception catchpoints.
6533         * breakpoint.h (is_exception_catchpoint): Declare.
6534
6535 2019-07-09  Pedro Alves  <palves@redhat.com>
6536
6537         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6538         "addr" field.
6539         (allocate_location_exception_catchpoint): New.
6540         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6541         (initialize_throw_catchpoint_ops): Install
6542         allocate_location_exception_catchpoint as allocate_location
6543         method.
6544         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6545         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6546         bp_loc_other.
6547         (breakpoint_address_is_meaningful): Delete.
6548         (bl_address_is_meaningful): New.
6549         (breakpoint_locations_match): Adjust comment.
6550         (bp_location_from_bp_type): New, factored out of...
6551         (bp_location::bp_location(breakpoint *)): ... this.
6552         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6553         factored out of...
6554         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6555         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6556         breakpoint_address_is_meaningful.
6557         (bp_locations_compare): Adjust comment.
6558         (update_global_location_list): Use bl_address_is_meaningful
6559         instead of breakpoint_address_is_meaningful.
6560         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6561         explicit.
6562         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6563         * python/py-breakpoint.c (bppy_get_location): No longer check
6564         whether location is null.
6565
6566 2019-07-09  Pedro Alves  <palves@redhat.com>
6567
6568         PR c++/15468
6569         * breakpoint.c (print_one_breakpoint_location): Remove
6570         single-location assert.
6571
6572 2019-07-09  Tom Tromey  <tom@tromey.com>
6573
6574         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6575         * configure: Rebuild.
6576         * configure.ac: Change common to gdbsupport.
6577         * gdbsupport: Rename from common.
6578         * acinclude.m4: Change common to gdbsupport.
6579         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6580         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6581         gdbsupport.
6582         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6583         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6584         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6585         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6586         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6587         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6588         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6589         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6590         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6591         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6592         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6593         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6594         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6595         coff-pe-read.c, command.h, compile/compile-c-support.c,
6596         compile/compile-c.h, compile/compile-cplus-symbols.c,
6597         compile/compile-cplus-types.c, compile/compile-cplus.h,
6598         compile/compile-loc2c.c, compile/compile.c, completer.c,
6599         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6600         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6601         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6602         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6603         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6604         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6605         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6606         features/aarch64-core.c, features/aarch64-fpu.c,
6607         features/aarch64-pauth.c, features/aarch64-sve.c,
6608         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6609         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6610         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6611         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6612         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6613         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6614         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6615         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6616         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6617         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6618         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6619         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6620         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6621         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6622         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6623         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6624         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6625         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6626         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6627         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6628         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6629         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6630         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6631         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6632         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6633         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6634         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6635         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6636         minsyms.c, mips-linux-tdep.c, namespace.h,
6637         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6638         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6639         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6640         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6641         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6642         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6643         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6644         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6645         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6646         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6647         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6648         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6649         procfs.c, producer.c, progspace.h, psymtab.h,
6650         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6651         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6652         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6653         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6654         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6655         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6656         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6657         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6658         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6659         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6660         target-memory.c, target.c, target.h, target/waitstatus.c,
6661         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6662         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6663         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6664         unittests/array-view-selftests.c,
6665         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6666         unittests/common-utils-selftests.c,
6667         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6668         unittests/format_pieces-selftests.c,
6669         unittests/function-view-selftests.c,
6670         unittests/lookup_name_info-selftests.c,
6671         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6672         unittests/mkdir-recursive-selftests.c,
6673         unittests/observable-selftests.c,
6674         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6675         unittests/parse-connection-spec-selftests.c,
6676         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6677         unittests/scoped_fd-selftests.c,
6678         unittests/scoped_mmap-selftests.c,
6679         unittests/scoped_restore-selftests.c,
6680         unittests/string_view-selftests.c, unittests/style-selftests.c,
6681         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6682         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6683         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6684         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6685         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6686         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6687
6688 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6689
6690         * linespec.c (decode_digits_list_mode): Set explicit_line to a
6691         bool value.
6692         (decode_digits_ordinary): Set explicit_line field in sal.
6693         * symtab.c (skip_prologue_sal): Don't skip prologue for a
6694         symtab_and_line that was set on an explicit line number in
6695         assembler code.  Do always update the recorded symtab and line if
6696         we do skip the prologue.
6697
6698 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6699
6700         * breakpoint.c (set_breakpoint_location_function): Remove
6701         explicit_loc parameter.
6702         (momentary_breakpoint_from_master): Update call to
6703         set_breakpoint_location_function.
6704         (add_location_to_breakpoint): Likewise.
6705
6706 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6707
6708         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6709         required features based on default bfd type when no specific bfd
6710         is present.
6711
6712 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6713
6714         * NEWS: Mention that GDB printf and eval commands can now print
6715         C-style and Ada-style convenience var strings without
6716         calling the inferior.
6717         * printcmd.c (printf_c_string): Locally print GDB internal var
6718         instead of transiting via the inferior.
6719         (printf_wide_c_string): Likewise.
6720
6721 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6722
6723         PR breakpoints/25011
6724         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6725
6726 2019-07-04  Tom Tromey  <tom@tromey.com>
6727
6728         PR tui/24724:
6729         * tui/tui-winsource.c (tui_clear_source_content): Update.
6730         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6731         (tui_update_breakpoint_info): Update.
6732         (tui_set_exec_info_content): Update.
6733         * tui/tui-source.c (tui_set_source_content_nil): Update.
6734         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6735         has_break.
6736         * tui/tui-data.h (enum tui_bp_flag): New.
6737         (tui_bp_flags): New enum flags type.
6738         (struct tui_source_element) <break_mode>: Change type.  Rename
6739         from has_break.
6740         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6741         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
6742         constants.
6743         * tui/tui-winsource.h: Fix comment.
6744
6745 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6746
6747         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6748         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6749         (store_fpregs_to_thread)
6750         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6751         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6752         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6753         (IWMMXT_REGS_SIZE): Add define.
6754         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6755         (fetch_vfp_regs, store_vfp_regs)
6756         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6757         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6758
6759 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6760
6761         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6762         defines.
6763         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6764         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6765         (ARM_INT_REGISTER_SIZE): ...to this.
6766         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6767         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6768         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6769         (arm_linux_collect_gregset, supply_nwfpe_register)
6770         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6771         defines.
6772         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6773         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6774         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6775         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6776         (arm_return_in_memory, arm_store_return_value)
6777         (arm_get_longjmp_target, arm_register_g_packet_guesses)
6778         (arm_record_ld_st_multiple): Likewise.
6779         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6780         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6781
6782 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6783
6784         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6785         AARCH64_DISPLACED_MODIFIED_INSNS.
6786         * aarch64-tdep.c (struct aarch64_displaced_step_data)
6787         (aarch64_displaced_step_copy_insn): Likewise.
6788         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6789         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6790         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6791         ARM_DISPLACED_MODIFIED_INSNS.
6792         * arm-tdep.c (arm_gdbarch_init): Likewise.
6793         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6794         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6795         (struct arm_displaced_step_closure): Use
6796         ARM_DISPLACED_MODIFIED_INSNS.
6797
6798 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6799
6800         * features/Makefile: Remove unused xml files.
6801         * features/aarch64.xml: Remove.
6802         * features/i386/amd64-avx-avx512-linux.xml: Remove.
6803         * features/i386/amd64-avx-avx512.xml: Remove.
6804         * features/i386/amd64-avx-linux.xml: Remove.
6805         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6806         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6807         * features/i386/amd64-avx-mpx-linux.xml: Remove.
6808         * features/i386/amd64-avx-mpx.xml: Remove.
6809         * features/i386/amd64-avx.xml: Remove.
6810         * features/i386/amd64-linux.xml: Remove.
6811         * features/i386/amd64-mpx-linux.xml: Remove.
6812         * features/i386/amd64-mpx.xml: Remove.
6813         * features/i386/amd64.xml: Remove.
6814         * features/i386/i386-avx-avx512-linux.xml: Remove.
6815         * features/i386/i386-avx-avx512.xml: Remove.
6816         * features/i386/i386-avx-linux.xml: Remove.
6817         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6818         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6819         * features/i386/i386-avx-mpx-linux.xml: Remove.
6820         * features/i386/i386-avx-mpx.xml: Remove.
6821         * features/i386/i386-avx.xml: Remove.
6822         * features/i386/i386-linux.xml: Remove.
6823         * features/i386/i386-mmx-linux.xml: Remove.
6824         * features/i386/i386-mmx.xml: Remove.
6825         * features/i386/i386-mpx-linux.xml: Remove.
6826         * features/i386/i386-mpx.xml: Remove.
6827         * features/i386/i386.xml: Remove.
6828         * features/i386/x32-avx-avx512-linux.xml: Remove.
6829         * features/i386/x32-avx-linux.xml: Remove.
6830         * features/i386/x32-linux.xml: Remove.
6831
6832 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6833
6834         * regformats/aarch64.dat: Remove.
6835         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6836         * regformats/i386/amd64-avx-linux.dat: Remove.
6837         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6838         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6839         * regformats/i386/amd64-linux.dat: Remove.
6840         * regformats/i386/amd64-mpx-linux.dat: Remove.
6841         * regformats/i386/amd64.dat: Remove.
6842         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6843         * regformats/i386/i386-avx-linux.dat: Remove.
6844         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6845         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6846         * regformats/i386/i386-linux.dat: Remove.
6847         * regformats/i386/i386-mmx-linux.dat: Remove.
6848         * regformats/i386/i386-mpx-linux.dat: Remove.
6849         * regformats/i386/i386.dat: Remove.
6850         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6851         * regformats/i386/x32-avx-linux.dat: Remove.
6852         * regformats/i386/x32-linux.dat: Remove.
6853
6854 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6855
6856         * aarch64-tdep.c: Remove xml self tests.
6857         * amd64-linux-tdep.c: Likewise.
6858         * amd64-tdep.c: Likewise.
6859         * i386-linux-tdep.c: Likewise.
6860         * i386-tdep.c: Likewise.
6861
6862 2019-07-03  Pedro Alves  <palves@redhat.com>
6863
6864         PR cli/24732
6865         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6866         (pipe_cmd_option_defs): New.
6867         (make_pipe_cmd_options_def_group): New.
6868         (pipe_command): Use gdb::option::process_options.
6869         (pipe_command_completer): New function.
6870         (_initialize_cli_cmds): Install completer for "pipe" command.
6871
6872 2019-07-03  Pedro Alves  <palves@redhat.com>
6873
6874         * cli/cli-option.c (union option_value) <string>: New field.
6875         (struct option_def_and_value): Add ctor, move ctor, dtor and
6876         use DISABLE_COPY_AND_ASSIGN.
6877         (option_def_and_value::clear_value): New.
6878         (parse_option, save_option_value_in_ctx, get_val_type_str)
6879         (add_setshow_cmds_for_options): Handle var_string.
6880         * cli-option.h (union option_def::var_address) <string>: New
6881         field.
6882         (struct string_option_def): New.
6883         * maint-test-options.c (struct test_options_opts): Add default
6884         ctor and use DISABLE_COPY_AND_ASSIGN.
6885         <string_opt>: New field.
6886         (test_options_opts::~test_options_opts): New.
6887         (test_options_opts::dump): Also dump "-string".
6888         (test_options_option_defs): Install "string.
6889
6890 2019-07-03  Pedro Alves  <palves@redhat.com>
6891
6892         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6893         option_value with a null enumeration.
6894         (complete_options): Save the option values in the context.
6895         (save_option_value_in_ctx): New, factored out from ...
6896         (process_options): ... here.
6897         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6898         of the function.
6899         * maint-test-options.c (test_options_opts::dump): New, factored
6900         out from ...
6901         (maintenance_test_options_command_mode): ... here.
6902         (maintenance_test_options_command_completion_result): Delete.
6903         (maintenance_test_options_command_completion_text): Update
6904         comment.
6905         (maintenance_show_test_options_completion_result): Change
6906         prototype.  Just print
6907         maintenance_test_options_command_completion_text.
6908         (save_completion_result): New.
6909         (maintenance_test_options_completer_mode): Pass options context to
6910         complete_options, and then save a dump.
6911         (_initialize_maint_test_options): Use add_cmd to install "maint
6912         show test-options-completion-result".
6913
6914 2019-07-03  Pedro Alves  <palves@redhat.com>
6915
6916         * NEWS (New commands): Mention "with" and "maint with".
6917         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
6918         (with_command, with_command_completer): New.
6919         (pipe_command): Adjust to new repeat_previous
6920         interface.
6921         (_initialize_cli_cmds): Install the "with" command and its "w"
6922         alias.
6923         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
6924         declarations.
6925         * cli/cli-setshow.c (parse_cli_var_uinteger)
6926         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
6927         argument strings for all var_types.
6928         (get_setshow_command_value_string): New, factored out from ...
6929         (do_show_command): ... this.
6930         * cli/cli-setshow.h: Include <string>.
6931         (get_setshow_command_value_string): Declare.
6932         * command.h (repeat_previous): Now returns const char *.  Adjust
6933         comment.
6934         * maint.c: Include "cli/cli-cmds.h".
6935         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
6936         (_initialize_maint_cmds): Register the "maintenance with" command.
6937         * top.c (repeat_previous): Move bits from pipe_command here:
6938         Return the saved command line, if any; error out if there's no
6939         command to relaunch.
6940
6941 2019-07-03  Pedro Alves  <palves@redhat.com>
6942
6943         * NEWS (New commands): Mention "maint set/show test-settings"
6944         instead of "maint test-settings".
6945         * maint-test-settings.c (maintenance_test_settings_list): Delete.
6946         (maintenance_test_settings_set_list): Rename to ...
6947         (maintenance_set_test_settings_list): ... this.
6948         (maintenance_test_settings_show_list): Rename to  ...
6949         (maintenance_show_test_settings_list): ... this.
6950         (maintenance_test_settings_cmd): Delete.
6951         (maintenance_test_settings_set_cmd): ...
6952         (maintenance_set_test_settings_cmd): ... this.
6953         (maintenance_test_settings_show_cmd): ...
6954         (maintenance_show_test_settings_cmd): ... this.
6955         (maintenance_test_settings_show_value_cmd):
6956         (maintenance_show_test_settings_value_cmd): ... this.
6957         (_initialize_maint_test_settings): No longer install the "maint
6958         test-settings" prefix command.  Rename "maint test-settings set"
6959         to "maint set test-settings", and "maint test-settings show" to
6960         "maint show test-settings".  Adjust all subcommands.
6961
6962 2019-07-03  Pedro Alves  <palves@redhat.com>
6963
6964         * maint-test-settings.c: Fix file's intro comment.  Replace all
6965         references to "test-options" with references to "test-settings",
6966         in comments.
6967
6968 2019-07-03  Pedro Alves  <palves@redhat.com>
6969
6970         * maint-test-settings.c (maintenance_test_settings_xxx)
6971         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
6972         New.
6973         (maintenance_test_settings_enums): Use them.
6974         (maintenance_test_settings_enum): Default to
6975         maintenance_test_settings_xxx.
6976         (_initialize_maint_test_settings): Initialize
6977         MAINTENANCE_TEST_SETTINGS_FILENAME.
6978
6979 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6980
6981         * breakpoint.h (remove_breakpoints_inf): Change return type to
6982         void, move function documentation here.
6983         * breakpoint.c (remove_breakpoints_inf): Change return type to
6984         void, move function documentation to header.
6985
6986 2019-07-02  Pedro Alves  <palves@redhat.com>
6987
6988         * NEWS (Completion improvements): Mention "info threads".
6989         * thread.c (struct info_threads_opts, info_threads_option_defs)
6990         (make_info_threads_options_def_group): New.
6991         (info_threads_command): Use gdb::option::process_options.
6992         (info_threads_command_completer): New.
6993         (_initialize_thread): Use gdb::option::build_help to build the
6994         help text for "info threads".
6995
6996 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6997
6998         * defs.h (generic_load): Move from here...
6999         * symfile.h (generic_load): ... to here.  Rename name parameter
7000         to args.
7001         * symfile.c (generic_load): Add comment.
7002
7003 2019-07-01  Tom Tromey  <tromey@adacore.com>
7004
7005         * dwarf2read.c
7006         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7007         declaration of without_params.  Fix formatting.
7008
7009 2019-07-01  Tom Tromey  <tromey@adacore.com>
7010
7011         * ada-exp.y (find_primitive_type): Update.
7012         * ada-lang.h (ada_lookup_symbol): Update.
7013         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7014         parameter.
7015         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7016
7017 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7018
7019         PR breakpoints/24541
7020         * gdbarch.c: Regenerate.
7021         * gdbarch.h: Regenerate.
7022         * gdbarch.sh: Add 'stap_adjust_register'.
7023         * i386-tdep.c: Include '<unordered_set>'.
7024         (i386_stap_adjust_register): New function.
7025         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7026         * stap-probe.c (stap_parse_register_operand): Call
7027         'gdbarch_stap_adjust_register'.
7028
7029 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7030
7031         PR python/24742
7032         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7033         * python/python.c (do_start_initialization): Use 'xmalloc'
7034         instead of 'PyMem_Malloc'.
7035
7036 2019-06-28  Tom Tromey  <tromey@adacore.com>
7037
7038         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7039         for Ada.
7040
7041 2019-06-27  Tom Tromey  <tromey@adacore.com>
7042
7043         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7044         objfile_key.
7045         (arm_find_mapping_symbol, arm_record_special_symbol)
7046         (_initialize_arm_tdep): Update.
7047         (arm_objfile_data_free): Remove.
7048
7049 2019-06-27  Tom Tromey  <tromey@adacore.com>
7050
7051         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7052         to cp_print_static_field.
7053
7054 2019-06-26  Tom Tromey  <tromey@adacore.com>
7055
7056         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7057         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7058         declare.
7059
7060 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7061
7062         * features/aarch64-core.c (create_feature_aarch64_core):
7063         Regenerate.
7064         * features/aarch64-core.xml: Add cpsr flags.
7065
7066 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7067
7068         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7069         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7070
7071 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7072
7073         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7074         field.
7075         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7076         use.
7077         (arm_record_special_symbol): Don't insert new symbol in sorted
7078         position, push it at the end.
7079
7080 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7081
7082         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7083         (arm_mapping_symbol_s): Remove.
7084         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7085         (arm_mapping_symbol_vec): New typedef.
7086         (struct arm_per_objfile): Add constructor.
7087         <section_maps>: Change type to
7088         std::unique_ptr<arm_mapping_symbol_vec[]>.
7089         (arm_compare_mapping_symbols): Remove.
7090         (arm_find_mapping_symbol): Adjust to section_maps type change.
7091         (arm_objfile_data_free): Call delete on arm_per_objfile.
7092         (arm_record_special_symbol): Adjust to section_maps type change.
7093         Allocate arm_per_objfile with new.
7094
7095 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7096
7097         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7098         with the command prefix.
7099
7100 2019-06-25  Tom Tromey  <tom@tromey.com>
7101
7102         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7103         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7104
7105 2019-06-25  Tom Tromey  <tom@tromey.com>
7106
7107         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7108         type.
7109         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7110         protected.
7111
7112 2019-06-25  Tom Tromey  <tom@tromey.com>
7113
7114         * tui/tui-winsource.c
7115         (tui_source_window_base::set_is_exec_point_at): Add check against
7116         LOA_ADDRESS.
7117
7118 2019-06-25  Tom Tromey  <tom@tromey.com>
7119
7120         * tui/tui-source.c (tui_set_source_content): Don't check before
7121         xfree.
7122         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7123
7124 2019-06-25  Tom Tromey  <tom@tromey.com>
7125
7126         * tui/tui-winsource.h (tui_update_source_window_as_is)
7127         (tui_alloc_source_buffer, tui_line_is_displayed)
7128         (tui_addr_is_displayed): Change type of win_info.
7129         * tui/tui-winsource.c (tui_update_source_window_as_is)
7130         (tui_clear_source_content, tui_show_source_line)
7131         (tui_show_source_content, tui_source_window_base::refill)
7132         (tui_source_window_base::set_is_exec_point_at)
7133         (tui_source_window_base::set_is_exec_point_at)
7134         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7135         (tui_alloc_source_buffer, tui_line_is_displayed)
7136         (tui_addr_is_displayed): Change type of win_info.  Update.
7137         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7138         (tui_source_window_base::do_make_visible_with_new_height):
7139         Update.
7140         * tui/tui-source.c (tui_set_source_content)
7141         (tui_set_source_content_nil)
7142         (tui_source_window::do_scroll_vertical): Update.
7143         * tui/tui-layout.c (show_layout): Update.
7144         * tui/tui-disasm.c (tui_set_disassem_content)
7145         (tui_disasm_window::do_scroll_vertical): Update.
7146         * tui/tui-data.h (tui_win_content): Remove.
7147         (struct tui_gen_win_info) <content, content_size>: Remove.
7148         (struct tui_source_element): Add initializers and destructor.
7149         (union tui_which_element, struct tui_win_element): Remove.
7150         (struct tui_source_window_base) <content>: New field.
7151         (struct tui_data_window): Remove destructor.
7152         (tui_alloc_content, tui_free_win_content)
7153         (tui_free_all_source_wins_content): Don't declare.
7154         * tui/tui-data.c (tui_initialize_static_data): Update.
7155         (init_content_element, tui_alloc_content): Remove.
7156         (~tui_gen_win_info): Update.
7157         (~tui_data_window, tui_free_all_source_wins_content)
7158         (tui_free_win_content, free_content, free_content_elements):
7159         Remove.
7160
7161 2019-06-25  Tom Tromey  <tom@tromey.com>
7162
7163         * tui/tui-winsource.h (tui_clear_source_content)
7164         (tui_erase_source_content, tui_show_source_content): Change type
7165         of win_info.
7166         * tui/tui-winsource.c (tui_clear_source_content)
7167         (tui_erase_source_content, tui_show_source_content): Change type
7168         of win_info.
7169         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7170         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7171         win_info.
7172         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7173         win_info.
7174         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7175
7176 2019-06-25  Tom Tromey  <tom@tromey.com>
7177
7178         * tui/tui-winsource.c (tui_clear_source_content)
7179         (tui_source_window_base::set_is_exec_point_at): Update.
7180         * tui/tui-source.c (tui_set_source_content_nil): Update.
7181         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7182         a bool.
7183         * tui/tui-data.c (init_content_element): Update.
7184
7185 2019-06-25  Tom Tromey  <tom@tromey.com>
7186
7187         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7188         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7189         * tui/tui-layout.c (init_and_make_win): Update.
7190         * tui/tui.h (enum tui_win_type): Update.
7191         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7192         tui_win_is_auxillary.
7193         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7194         tui_win_is_auxillary.
7195
7196 2019-06-25  Tom Tromey  <tom@tromey.com>
7197
7198         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7199         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7200         (tui_delete_data_content_windows, tui_display_all_data)
7201         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7202         Update.
7203         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7204         * tui/tui-regs.c (tui_last_regs_line_no)
7205         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7206         (tui_show_registers): Update.
7207         (tui_show_register_group): Return void.  Update.
7208         (tui_display_registers_from, tui_display_reg_element_at_line)
7209         (tui_display_registers_from_line, tui_check_register_values):
7210         Update.
7211         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7212         member.
7213         (struct tui_data_window) <regs_content>: Now a std::vector.
7214         <regs_content_count>: Remove.
7215         (tui_add_content_elements, tui_free_data_content): Don't declare.
7216         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7217         (init_content_element): Remove DATA_WIN case.  Add assert.
7218         (tui_add_content_elements): Remove.
7219         (tui_data_window): Update.
7220         (tui_free_data_content): Remove.
7221         (free_content_elements): Remove DATA_WIN case.
7222
7223 2019-06-25  Tom Tromey  <tom@tromey.com>
7224
7225         * tui/tui-data.c (tui_data_item_window): Update.
7226         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7227         * tui/tui-windata.c (tui_display_all_data)
7228         (tui_display_data_from_line): Update.
7229         (tui_check_data_values): Remove.
7230         * tui/tui-regs.c (tui_show_register_group)
7231         (tui_display_reg_element_at_line): Update.
7232         * tui/tui-hooks.c (tui_register_changed)
7233         (tui_refresh_frame_and_register_information): Call
7234         tui_check_register_values.
7235         * tui/tui-data.h (struct tui_data_window) <data_content,
7236         data_content_count, data_type>: Remove.
7237         (enum tui_data_type): Remove.
7238
7239         * tui/tui-data.c (tui_data_window::clear_detail)
7240         (~tui_data_window): Update.
7241
7242 2019-06-25  Tom Tromey  <tom@tromey.com>
7243
7244         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7245         declare.
7246         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7247         Rename from tui_first_data_item_displayed.  Update.
7248         (tui_data_window::refresh_all)
7249         (tui_data_window::do_scroll_vertical): Update.
7250         * tui/tui-data.h (struct tui_data_window)
7251         <first_data_item_displayed>: Declare new method.
7252
7253 2019-06-25  Tom Tromey  <tom@tromey.com>
7254
7255         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7256         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7257         contents...
7258         (tui_initialize_static_data): ...here.
7259
7260 2019-06-25  Tom Tromey  <tom@tromey.com>
7261
7262         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7263         (tui_display_registers_from, tui_check_register_values): Update.
7264         (tui_display_register): Remove win_info parameter; update.
7265         (tui_get_register): Change type of parameters.
7266         * tui/tui-data.h (struct tui_data_element): Remove.
7267         (union tui_which_element) <data>: Remove.
7268         <data_window>: Change type.
7269         (struct tui_data_item_window): New.
7270         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7271         case.  Add assert.
7272         (~tui_data_item_window): New destructor.
7273         (free_content_elements): Remove DATA_ITEM_WIN case.
7274
7275 2019-06-25  Tom Tromey  <tom@tromey.com>
7276
7277         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7278         Remove.
7279
7280 2019-06-25  Tom Tromey  <tom@tromey.com>
7281
7282         * tui/tui-data.h (struct tui_command_element): Remove.
7283         (union tui_which_element) <command>: Remove.
7284         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7285         assert.
7286         (free_content_elements): Remove CMD_WIN case.
7287
7288 2019-06-25  Tom Tromey  <tom@tromey.com>
7289
7290         * tui/tui-layout.c (tui_set_layout): Update.
7291         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7292         * tui/tui-data.c (layout_def): Update.
7293
7294 2019-06-25  Tom Tromey  <tom@tromey.com>
7295
7296         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7297         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7298         (tui_source_window_base::set_new_height): Update.
7299         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7300         Update.
7301         (tui_set_locator_fullname, tui_set_locator_info)
7302         (tui_show_frame_info): Update.
7303         * tui/tui-source.c (tui_set_source_content)
7304         (tui_source_is_displayed): Update.
7305         * tui/tui-layout.c (show_source_disasm_command, show_data)
7306         (show_source_or_disasm_and_command): Update.
7307         * tui/tui-disasm.c (tui_set_disassem_content)
7308         (tui_get_begin_asm_address): Update.
7309         * tui/tui-data.h (struct tui_locator_element): Remove.
7310         (union tui_which_element) <locator>: Remove.
7311         (struct tui_locator_window): New.
7312         (tui_locator_win_info_ptr): Change return type.
7313         * tui/tui-data.c (_locator): Change type.
7314         (tui_locator_win_info_ptr): Change return type.
7315         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7316         (tui_alloc_content): Add assert.
7317
7318 2019-06-25  Tom Tromey  <tom@tromey.com>
7319
7320         * tui/tui-winsource.c
7321         (tui_exec_info_window::maybe_allocate_content): New method.
7322         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7323         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7324         (make_source_or_disasm_window): Add cast.
7325         * tui/tui-data.h (union tui_which_element) <simple_string>:
7326         Remove.
7327         (struct tui_source_info): New.
7328         (struct tui_source_window_base) <execution_info>: Change type.
7329         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7330         case, and add assert.
7331         (tui_alloc_content): Add assert.
7332
7333 2019-06-25  Tom Tromey  <tom@tromey.com>
7334
7335         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7336         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7337         * tui/tui-data.c (tui_alloc_win_info): Remove.
7338
7339 2019-06-25  Tom Tromey  <tom@tromey.com>
7340
7341         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7342         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7343         can_highlight.
7344
7345 2019-06-25  Tom Tromey  <tom@tromey.com>
7346
7347         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7348         make_visible_with_new_height method.
7349         (tui_win_info::make_visible_with_new_height): New method.
7350         (tui_source_window_base::do_make_visible_with_new_height)
7351         (tui_data_window::do_make_visible_with_new_height)
7352         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7353         (make_visible_with_new_height): Remove.
7354         (tui_resize_all, tui_adjust_win_heights): Use
7355         make_visible_with_new_height method.
7356         * tui/tui-data.h (struct tui_win_info)
7357         <do_make_visible_with_new_height, make_visible_with_new_height>:
7358         New methods.
7359         (struct tui_source_window_base, struct tui_data_window)
7360         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7361         methods.
7362
7363 2019-06-25  Tom Tromey  <tom@tromey.com>
7364
7365         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7366         method.
7367         (update_tab_width): Call update_tab_width method.
7368         * tui/tui-data.h (struct tui_win_info)
7369         (struct tui_source_window_base) <update_tab_width>: New methods.
7370
7371 2019-06-25  Tom Tromey  <tom@tromey.com>
7372
7373         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7374         parameter.
7375         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7376         parameter.
7377         (tui_gen_win_info::make_visible): Update.
7378         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7379         parameter.
7380         * tui/tui-data.h (enum tui_box): New enum.
7381         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7382
7383 2019-06-25  Tom Tromey  <tom@tromey.com>
7384
7385         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7386         init_and_make_win for EXEC_INFO_WIN.
7387         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7388         longer inline.
7389         (struct tui_win_info) <~tui_win_info>: Inline.
7390         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7391         Don't declare.
7392         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7393         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7394         Remove.
7395         (tui_initialize_static_data): Update.
7396         (~tui_gen_win_info): Handle more cleanup here.
7397         (~tui_source_window_base): Delete "execution_info".
7398         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7399
7400 2019-06-25  Tom Tromey  <tom@tromey.com>
7401
7402         * tui/tui-layout.c (make_command_window): Don't set
7403         can_highlight.
7404         (show_source_disasm_command): Call the reset method.
7405         (show_data): Don't set can_highlight.  Call the reset method.
7406         (tui_gen_win_info::reset): Rename from init_gen_win_info
7407         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7408         (show_source_or_disasm_and_command): Call the reset method.
7409         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7410         (struct tui_cmd_window): Set can_highlight.
7411
7412 2019-06-25  Tom Tromey  <tom@tromey.com>
7413
7414         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7415         from make_visible.
7416         (tui_make_visible, tui_make_invisible): Rewrite.
7417         (tui_win_info::make_visible): Remove.
7418         (tui_source_window_base::make_visible): Update.
7419         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7420         method.  Moved from...
7421         (struct tui_win_info) <make_visible>: ...here.
7422
7423 2019-06-25  Tom Tromey  <tom@tromey.com>
7424
7425         * tui/tui-winsource.c
7426         (tui_source_window_base::do_scroll_horizontal): Remove direction
7427         parameter.
7428         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7429         direction parameter.
7430         * tui/tui-win.c (tui_win_info::forward_scroll)
7431         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7432         (tui_win_info::right_scroll): Update.
7433         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7434         direction parameter.
7435         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7436         direction parameter.
7437         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7438         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7439         Remove direction parameter.
7440         (struct tui_source_window_base, struct tui_source_window)
7441         (struct tui_disasm_window, struct tui_data_window)
7442         (struct tui_cmd_window): Update.
7443
7444 2019-06-25  Tom Tromey  <tom@tromey.com>
7445
7446         * tui/tui-winsource.h (tui_set_exec_info_content)
7447         (tui_show_exec_info_content, tui_erase_exec_info_content)
7448         (tui_clear_exec_info_content, tui_update_exec_info): Change
7449         argument to tui_source_window_base.
7450         * tui/tui-winsource.c (tui_set_exec_info_content)
7451         (tui_show_exec_info_content, tui_erase_exec_info_content)
7452         (tui_clear_exec_info_content, tui_update_exec_info): Change
7453         argument to tui_source_window_base.
7454
7455 2019-06-25  Tom Tromey  <tom@tromey.com>
7456
7457         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7458         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7459
7460 2019-06-25  Tom Tromey  <tom@tromey.com>
7461
7462         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7463         check.
7464
7465 2019-06-25  Tom Tromey  <tom@tromey.com>
7466
7467         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7468         type to void.
7469         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7470         type to void.
7471         * tui/tui-source.c (tui_set_source_content): Update.
7472         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7473
7474 2019-06-25  Tom Tromey  <tom@tromey.com>
7475
7476         * tui/tui-win.c (window_name_completer, tui_set_focus)
7477         (tui_all_windows_info): Use name method.
7478         * tui/tui-data.h (struct tui_gen_win_info)
7479         (struct tui_source_window, struct tui_disasm_window)
7480         (struct tui_data_window, struct tui_cmd_window) <name>: New
7481         method.
7482         (tui_win_name): Don't declare.
7483         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7484         (tui_win_name): Remove.
7485
7486 2019-06-25  Tom Tromey  <tom@tromey.com>
7487
7488         * tui/tui-winsource.h (tui_update_source_window)
7489         (tui_update_source_window_as_is): Change parameter type.
7490         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7491         to be a tui_source_window_base.
7492         (tui_update_source_window_as_is): Likewise.
7493         * tui/tui-win.c (make_visible_with_new_height): Update.
7494
7495 2019-06-25  Tom Tromey  <tom@tromey.com>
7496
7497         * tui/tui-winsource.c (tui_erase_source_content)
7498         (tui_show_source_content, tui_show_exec_info_content)
7499         (tui_erase_exec_info_content): Use refresh_window method.
7500         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7501         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7502         from tui_refresh_win.
7503         (tui_data_window::refresh_window): New method.
7504         (tui_win_info::refresh, tui_source_window_base::refresh)
7505         (tui_refresh_all): Use refresh_window method.
7506         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7507         method.
7508         * tui/tui-regs.c (tui_display_register): Call refresh_window
7509         method.
7510         * tui/tui-layout.c (show_source_disasm_command)
7511         (show_source_or_disasm_and_command): Call refresh_window method.
7512         * tui/tui-data.h (struct tui_gen_win_info)
7513         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7514         New method.
7515
7516 2019-06-25  Tom Tromey  <tom@tromey.com>
7517
7518         * tui/tui.c (tui_rl_other_window, tui_enable)
7519         (tui_is_window_visible, tui_get_command_dimension): Update.
7520         * tui/tui-winsource.c (tui_update_source_window_as_is)
7521         (tui_clear_source_content, tui_erase_source_content)
7522         (tui_show_source_line, tui_source_window_base::refill)
7523         (tui_source_window_base::do_scroll_horizontal)
7524         (tui_source_window_base::set_is_exec_point_at)
7525         (tui_update_breakpoint_info, tui_set_exec_info_content)
7526         (tui_alloc_source_buffer, tui_line_is_displayed)
7527         (tui_addr_is_displayed): Update.
7528         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7529         (tui_check_and_display_highlight_if_needed)
7530         (tui_win_info::make_visible, tui_win_info::refresh)
7531         (tui_refresh_all): Update.
7532         * tui/tui-windata.c (tui_first_data_item_displayed)
7533         (tui_delete_data_content_windows, tui_erase_data_content)
7534         (tui_display_all_data, tui_data_window::refresh_all)
7535         (tui_check_data_values): Update.
7536         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7537         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7538         (tui_win_info::backward_scroll, tui_refresh_all_win)
7539         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7540         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7541         (tui_source_window_base::set_new_height)
7542         (tui_data_window::set_new_height)
7543         (make_invisible_and_set_new_height)
7544         (make_visible_with_new_height, new_height_ok)
7545         (parse_scrolling_args): Update.
7546         * tui/tui-stack.c (tui_show_frame_info): Update.
7547         * tui/tui-source.c (tui_set_source_content)
7548         (tui_set_source_content_nil, tui_source_is_displayed)
7549         (tui_source_window::do_scroll_vertical): Update.
7550         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7551         (tui_display_registers_from, tui_display_reg_element_at_line)
7552         (tui_check_register_values, tui_reg_command): Update.
7553         * tui/tui-layout.c (tui_default_win_height)
7554         (show_source_disasm_command, show_data, init_and_make_win)
7555         (show_source_or_disasm_and_command): Update.
7556         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7557         (tui_redisplay_readline, tui_mld_flush)
7558         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7559         (tui_getc): Update.
7560         * tui/tui-disasm.c (tui_set_disassem_content)
7561         (tui_disasm_window::do_scroll_vertical): Update.
7562         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7563         Now virtual.
7564         (struct tui_win_info): Derive from tui_gen_win_info.
7565         <~tui_win_info>: Mark as override.
7566         <generic>: Remove member.
7567         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7568         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7569         (~tui_data_window, ~tui_win_info)
7570         (tui_free_all_source_wins_content): Update.
7571         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7572
7573 2019-06-25  Tom Tromey  <tom@tromey.com>
7574
7575         * tui/tui-layout.c (init_and_make_win): Use new.
7576         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7577         destructor, initializers.
7578         (tui_alloc_generic_win_info): Don't declare.
7579         * tui/tui-data.c (_locator): Add argument to constructor.
7580         (source_win, disasm_win): New globals.
7581         (exec_info): Remove.
7582         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7583         Update.
7584         (tui_alloc_generic_win_info): Remove.
7585         (init_content_element): Use new.
7586         (tui_win_info::tui_win_info): Update.
7587         (free_content_elements) <case DATA_WIN>: Use delete.
7588
7589 2019-06-25  Tom Tromey  <tom@tromey.com>
7590
7591         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7592         * tui/tui-windata.c (tui_first_data_item_displayed)
7593         (tui_delete_data_content_windows): Update.
7594         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7595         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7596         (tui_display_registers_from, tui_check_register_values): Update.
7597         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7598         pointer.
7599         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7600         window.
7601         (tui_free_data_content): Update.
7602         (free_content_elements) <case DATA_WIN>: Free the window.
7603
7604 2019-06-25  Tom Tromey  <tom@tromey.com>
7605
7606         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7607         Update.
7608         * tui/tui-layout.c (make_command_window)
7609         (show_source_disasm_command, show_data, init_and_make_win)
7610         (show_source_or_disasm_and_command): Update.
7611         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7612         method.
7613         <can_highight, is_highlighted>: Now bool.
7614         (tui_set_win_highlight): Don't declare.
7615         * tui/tui-data.c (tui_set_win_highlight): Remove.
7616
7617 2019-06-25  Tom Tromey  <tom@tromey.com>
7618
7619         * tui/tui-wingeneral.c (make_visible): Remove check of window
7620         type.
7621
7622 2019-06-25  Tom Tromey  <tom@tromey.com>
7623
7624         * tui/tui-win.c (tui_win_info::max_height)
7625         (tui_cmd_window::max_height): New methods.
7626         (new_height_ok): Call max_height.
7627         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7628         <max_height>: New method.
7629
7630 2019-06-25  Tom Tromey  <tom@tromey.com>
7631
7632         * tui/tui-win.c (tui_source_window_base::set_new_height)
7633         (tui_data_window::set_new_height): New methods.
7634         (make_invisible_and_set_new_height): Call set_new_height method.
7635         * tui/tui-data.h (struct tui_win_info)
7636         (struct tui_source_window_base, struct tui_data_window)
7637         <set_new_height>: New method.
7638
7639 2019-06-25  Tom Tromey  <tom@tromey.com>
7640
7641         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7642         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7643         tui_refresh_data_win.
7644         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7645         method.
7646         (tui_refresh_all_win): Call the refresh_all method.
7647         (tui_set_focus): Likewise.
7648         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7649         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7650         Likewise.
7651
7652 2019-06-25  Tom Tromey  <tom@tromey.com>
7653
7654         * tui/tui-winsource.h (tui_refill_source_window)
7655         (tui_set_is_exec_point_at): Don't declare.
7656         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7657         (tui_source_window_base::refill): Rename from
7658         tui_refill_source_window.
7659         (tui_source_window_base::do_scroll_horizontal): Update.
7660         (tui_source_window_base::set_is_exec_point_at): Rename from
7661         tui_set_is_exec_point_at.
7662         (tui_update_all_breakpoint_info): Update.
7663         * tui/tui-stack.c (tui_show_frame_info): Update.
7664         * tui/tui-layout.c (show_data): Add cast.
7665         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7666         * tui/tui-data.h (struct tui_source_window_base) <refill,
7667         set_is_exec_point_at>: New methods.
7668         (tui_source_windows, tui_add_to_source_windows): Update types.
7669         (tui_add_to_source_windows): Remove redundant declaration.
7670         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7671         (tui_source_windows): Change return type.
7672         (tui_clear_source_windows_detail): Update.
7673         (tui_add_to_source_windows): Change type of parameter.
7674         (tui_free_all_source_wins_content): Update.
7675
7676 2019-06-25  Tom Tromey  <tom@tromey.com>
7677
7678         * tui/tui-wingeneral.c (tui_win_info::refresh)
7679         (tui_source_window_base::refresh): New methods.
7680         (tui_refresh_all): Call the refresh method.
7681         * tui/tui-data.h (struct tui_win_info)
7682         (struct tui_source_window_base) <refresh>: New method.
7683
7684 2019-06-25  Tom Tromey  <tom@tromey.com>
7685
7686         * tui/tui.h (tui_is_window_visible): Return bool.
7687         * tui/tui.c (tui_is_window_visible): Return bool.
7688         * tui/tui-wingeneral.c (tui_make_window, make_visible)
7689         (tui_make_visible, tui_make_invisible)
7690         (tui_win_info::make_visible)
7691         (tui_source_window_base::make_visible, make_all_visible)
7692         (tui_make_all_visible, tui_make_all_invisible): Update.
7693         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7694         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7695         bool.
7696         (struct tui_win_info, struct tui_source_window_base)
7697         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7698         * tui/tui-data.c (tui_init_generic_part): Update.
7699
7700 2019-06-25  Tom Tromey  <tom@tromey.com>
7701
7702         * tui/tui-wingeneral.c (tui_win_info::make_visible)
7703         (tui_source_window_base::make_visible): New methods.
7704         (make_all_visible): Make method call.
7705         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7706         (struct tui_source_window_base, struct tui_cmd_window): Override
7707         make_visible.
7708         (tui_win_is_source_type): Don't declare.
7709         * tui/tui-data.c (tui_win_is_source_type): Remove.
7710
7711 2019-06-25  Tom Tromey  <tom@tromey.com>
7712
7713         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7714         NULL check.
7715
7716 2019-06-25  Tom Tromey  <tom@tromey.com>
7717
7718         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7719         Inline constructor.  Add initializers for members.
7720         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7721         constructors; now inline in class.
7722
7723 2019-06-25  Tom Tromey  <tom@tromey.com>
7724
7725         * tui/tui-regs.c (tui_show_registers): Update.
7726         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7727         bool.
7728         * tui/tui-data.c (tui_data_window::clear_detail)
7729         (tui_data_window): Update.
7730
7731 2019-06-25  Tom Tromey  <tom@tromey.com>
7732
7733         * tui/tui-windata.c (tui_display_all_data)
7734         (tui_display_data_from_line, tui_display_data_from)
7735         (tui_check_data_values, tui_data_window::do_scroll_vertical):
7736         Update.
7737         * tui/tui-regs.c (tui_last_regs_line_no)
7738         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7739         (tui_show_registers, tui_show_register_group)
7740         (tui_display_registers_from, tui_display_reg_element_at_line)
7741         (tui_display_registers_from_line, tui_check_register_values)
7742         (tui_reg_next, tui_reg_prev): Update.
7743         * tui/tui-layout.c (tui_set_layout, show_data): Update.
7744         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
7745         tui_data_window.
7746         (struct tui_win_info) <detail>: Remove.  Add new fields from
7747         tui_data_info.
7748         (TUI_DATA_WIN): Add cast.
7749         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7750         (~tui_data_window): Simplify.
7751
7752 2019-06-25  Tom Tromey  <tom@tromey.com>
7753
7754         * tui/tui-layout.c (show_source_disasm_command)
7755         (show_source_or_disasm_and_command): Update.
7756         * tui/tui-io.c (update_cmdwin_start_line)
7757         (tui_redisplay_readline): Update.
7758         * tui/tui-data.h (struct tui_command_info): Remove.
7759         (struct tui_win_info) <detail>: Remove command_info member.
7760         (struct tui_data_window) <start_line>: New member, from
7761         tui_command_info.
7762         (TUI_CMD_WIN): Add casts.
7763
7764 2019-06-25  Tom Tromey  <tom@tromey.com>
7765
7766         * tui/tui-winsource.c (tui_update_source_window)
7767         (tui_refill_source_window)
7768         (tui_source_window_base::do_scroll_horizontal)
7769         (tui_update_breakpoint_info, tui_set_exec_info_content)
7770         (tui_show_exec_info_content, tui_erase_exec_info_content)
7771         (tui_clear_exec_info_content): Update.
7772         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7773         Update.
7774         * tui/tui-win.c (make_invisible_and_set_new_height)
7775         (make_visible_with_new_height): Update.
7776         * tui/tui-source.c (tui_set_source_content)
7777         (tui_show_symtab_source): Update.
7778         * tui/tui-layout.c (extract_display_start_addr)
7779         (show_source_disasm_command, show_data)
7780         (make_source_or_disasm_window)
7781         (show_source_or_disasm_and_command): Update.
7782         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7783         (tui_disasm_window::do_scroll_vertical): Remove shadowing
7784         "gdbarch".
7785         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
7786         to tui_source_window_base.
7787         (struct tui_win_info) <detail>: Remove source_info member.
7788         (struct tui_source_window_base) <has_locator>: Inline.
7789         Move contents from tui_source_info; rename has_locator member to
7790         m_has_locator.
7791         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7792         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7793         header file.
7794         (tui_source_window_base::clear_detail, ~tui_source_window_base):
7795         Simplify.
7796         (tui_free_all_source_wins_content): Cast to
7797         tui_source_window_base.
7798
7799 2019-06-25  Tom Tromey  <tom@tromey.com>
7800
7801         * tui/tui-win.c (make_invisible_and_set_new_height)
7802         (make_visible_with_new_height): Call has_locator method.
7803         * tui/tui-layout.c (show_source_disasm_command, show_data)
7804         (show_source_or_disasm_and_command): Update for bool change.
7805         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7806         (tui_win_info) <has_locator>: New method.
7807         (struct tui_source_window_base) <has_locator>: New method.
7808         (tui_win_has_locator): Don't declare.
7809         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7810         from tui_win_has_locator.
7811         (tui_source_window_base): Use false, not FALSE.
7812
7813 2019-06-25  Tom Tromey  <tom@tromey.com>
7814
7815         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7816         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7817         clear_detail method directly.
7818         (tui_clear_win_detail): Remove.
7819
7820 2019-06-25  Tom Tromey  <tom@tromey.com>
7821
7822         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7823         "this", not TUI_DISASM_WIN.
7824
7825 2019-06-25  Tom Tromey  <tom@tromey.com>
7826
7827         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
7828         declare.
7829         * tui/tui-winsource.c
7830         (tui_source_window_base::do_scroll_horizontal): Rename from
7831         tui_horizontal_source_scroll.
7832         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7833         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7834         from tui_vertical_data_scroll.
7835         * tui/tui-win.h (tui_scroll): Don't declare.
7836         * tui/tui-win.c (tui_win_info::forward_scroll)
7837         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7838         (tui_win_info::right_scroll): Rename and update.
7839         (tui_scroll_forward_command, tui_scroll_backward_command)
7840         (tui_scroll_left_command, tui_scroll_right_command): Update.
7841         (tui_scroll): Remove.
7842         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7843         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7844         from tui_vertical_source_scroll.
7845         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7846         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7847         from tui_vertical_disassem_scroll.
7848         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7849         do_scroll_horizontal>: New methods.
7850         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7851         Likewise.
7852         (struct tui_source_window_base): Add do_scroll_horizontal.
7853         (struct tui_source_window, struct tui_disasm_window): Add
7854         do_scroll_vertical.
7855         (struct tui_data_window, struct tui_cmd_window): Add
7856         do_scroll_horizontal and do_scroll_vertical.
7857         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7858
7859 2019-06-25  Tom Tromey  <tom@tromey.com>
7860
7861         * tui/tui-data.h (struct tui_source_window_base): New struct.
7862         (struct tui_source_window): Derive from tui_source_window_base.
7863         (struct tui_disasm_window): New struct.
7864         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7865         from tui_source_window::clear_detail.
7866         (tui_source_window_base): Rename from tui_source_window.
7867         (~tui_source_window_base): Rename from ~tui_source_window.
7868         (tui_alloc_win_info): Create a tui_disasm_window.
7869
7870 2019-06-25  Tom Tromey  <tom@tromey.com>
7871
7872         * tui/tui-data.h (struct tui_source_window)
7873         (struct tui_data_window): Declare destructors.
7874         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7875         destructors.
7876         (tui_win_info): Simplify.
7877
7878 2019-06-25  Tom Tromey  <tom@tromey.com>
7879
7880         * tui/tui-winsource.c (tui_display_main)
7881         (tui_update_source_windows_with_addr)
7882         (tui_update_all_breakpoint_info): Update.
7883         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7884         (new_height_ok, parse_scrolling_args): Update.
7885         * tui/tui-stack.c (tui_show_frame_info): Update.
7886         * tui/tui-data.h (struct tui_list): Remove.
7887         (tui_source_windows): Return a reference to a std::vector.
7888         * tui/tui-data.c (source_windows): Now a std::vector.
7889         (tui_source_windows): Change return type.
7890         (tui_clear_source_windows): Rewrite.
7891         (tui_clear_source_windows_detail, tui_add_to_source_windows)
7892         (tui_free_all_source_wins_content): Rewrite.
7893
7894 2019-06-25  Tom Tromey  <tom@tromey.com>
7895
7896         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7897         (struct tui_data_window, struct tui_cmd_window): Declare
7898         clear_detail method.
7899         * tui/tui-data.c (tui_source_window::clear_detail)
7900         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
7901         methods.
7902         (tui_clear_win_detail): Simplify.
7903
7904 2019-06-25  Tom Tromey  <tom@tromey.com>
7905
7906         * tui/tui-layout.c (make_source_window, make_disasm_window)
7907         (make_source_or_disasm_window): Remove win_info_ptr parameter.
7908         Return the new window.
7909         (show_source_disasm_command, show_data)
7910         (show_source_or_disasm_and_command): Update.
7911
7912 2019-06-25  Tom Tromey  <tom@tromey.com>
7913
7914         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
7915         parameter.  Return the new window.
7916         (show_source_disasm_command): Update and remove NULL check.
7917         (show_source_or_disasm_and_command): Update.
7918
7919 2019-06-25  Tom Tromey  <tom@tromey.com>
7920
7921         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
7922
7923 2019-06-25  Tom Tromey  <tom@tromey.com>
7924
7925         * tui/tui-data.h (struct tui_win_info): Make constructor
7926         protected.  Make destructor virtual.  Add initializers.
7927         (tui_source_window, tui_data_window, tui_cmd_window): New
7928         classes.
7929         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
7930         constructor.  Add "type" parameter.
7931         (tui_source_window, tui_data_window, tui_cmd_window): New
7932         constructors.
7933         (tui_alloc_win_info): Instantiate the appropriate subclass.
7934
7935 2019-06-25  Tom Tromey  <tom@tromey.com>
7936
7937         * tui/tui-win.c (tui_resize_all): Use delete.
7938         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
7939         destructor.
7940         (tui_free_window): Don't declare.
7941         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
7942         Update.
7943
7944 2019-06-25  Tom Tromey  <tom@tromey.com>
7945
7946         * tui/tui-data.h (struct tui_win_info): Add constructor.
7947         * tui/tui-data.c (tui_alloc_win_info): Use new.
7948         (tui_free_window): Use delete.
7949
7950 2019-06-22  Tom Tromey  <tom@tromey.com>
7951
7952         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
7953         declare.
7954         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
7955
7956 2019-06-22  Tom Tromey  <tom@tromey.com>
7957
7958         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7959         declare.
7960         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7961
7962 2019-06-22  Tom de Vries  <tdevries@suse.de>
7963
7964         * dwarf2read.c (create_addrmap_from_aranges)
7965         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
7966         instead of '%zu'.
7967
7968 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
7969
7970         * dwarf2read.h (dwarf2_section_info_def): Remove.
7971         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
7972         * dwarf2read.c (struct dwo_sections) <types>: Change type to
7973         std::vector<dwarf2_section_info>.
7974         (struct dwo_file) <~dwo_file>: Remove.
7975         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
7976         types field.
7977         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
7978         (dwarf2_read_debug_names): Likewise.
7979         (create_debug_types_hash_table): Change parameter type to
7980         array_view, adjust code accordingly.
7981         (dwarf2_locate_dwo_sections): Adjust to std::vector.
7982         (partial_die_info::fixup): Likewise.
7983         (determine_prefix): Likewise.
7984         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
7985
7986 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7987
7988         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
7989         gdb_bfd_ref_ptr.
7990         <~dwo_file>: Remove call to gdb_bfd_unref.
7991         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7992         gdb_bfd_ref_ptr::get.
7993
7994 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7995
7996         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7997         type to htab_up.
7998         * dwarf2read.c (struct dwo_file): Initialize fields.
7999         <~dwo_file>: New.
8000         (free_dwo_file): Remove, move content to ~dwo_file.
8001         (struct dwo_file_deleter): Remove.
8002         (dwo_file_up>: Remove custom deleter.
8003         (free_dwo_files): Remove.
8004         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8005         dwo_files.
8006         (process_skeletonless_type_units): Call unique_ptr::get.
8007         (allocate_dwo_file_hash_table): Add deleter to created hash
8008         table.  Change return type to htab_up.
8009         (lookup_dwo_file_slot): Don't memset dwo_file, call
8010         unique_ptr::get.
8011         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8012         (create_dwo_unit_in_dwp_v2): Likewise.
8013         (open_and_init_dwo_file): Likewise.
8014         (free_dwo_file_from_slot): Remove.
8015
8016 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8017
8018         * dwarf2read.h (struct dwarf2_section_info) <readin,
8019         is_virtual>: Change type to bool.
8020         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8021         true instead of 1.
8022
8023 2019-06-19  Tom Tromey  <tom@tromey.com>
8024
8025         * tui/tui-data.h (tui_init_content_element): Don't declare.
8026
8027 2019-06-19  Tom Tromey  <tom@tromey.com>
8028
8029         * tui/tui-data.h (tui_init_win_info): Don't declare.
8030
8031 2019-06-19  Tom de Vries  <tdevries@suse.de>
8032
8033         * dwarf2read.h (abstract_to_concrete): Change type to
8034         std::unordered_map<sect_offset, std::vector<sect_offset>,
8035         gdb::hash_enum<sect_offset>>.
8036
8037 2019-06-19  Tom Tromey  <tromey@adacore.com>
8038
8039         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8040         EVAL_AVOID_SIDE_EFFECTS specially.
8041
8042 2019-06-19  Tom Tromey  <tromey@adacore.com>
8043
8044         * source-cache.c (highlighter): New global.
8045         (source_cache::get_source_lines): Create a highlighter on demand.
8046
8047 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8048
8049         * defs.h (deprecated_interactive_hook): Delete declaration.
8050         * interps.c (clear_interpreter_hooks): Remove use of
8051         deprecated_interactive_hook.
8052         * top.c (deprecated_interactive_hook): Delete definition.
8053         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8054
8055 2019-06-18  Tom de Vries  <tdevries@suse.de>
8056
8057         PR gdb/24515
8058         * dwarf2read.h (abstract_to_concrete): Change type from
8059         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8060         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8061         * dwarf2read.c (read_variable): Update.
8062         (dwarf2_fetch_die_loc_sect_off): Update.
8063
8064 2019-06-17  Tom de Vries  <tdevries@suse.de>
8065
8066         PR gdb/24617
8067         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8068         accessing parent[parent_len - 1].
8069
8070 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8071
8072         PR gdb/24364
8073         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8074         call dtrace_process_dof with NULL dof.
8075
8076 2019-06-16  Tom de Vries  <tdevries@suse.de>
8077
8078         PR gdb/24445
8079         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8080
8081 2019-06-16  Tom Tromey  <tom@tromey.com>
8082
8083         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8084         (make_all_visible): Use address of member.
8085
8086 2019-06-16  Tom Tromey  <tom@tromey.com>
8087
8088         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8089         (tui_free_window, free_content, free_content_elements): Remove
8090         unnecessary cast.
8091         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8092         cast.
8093         * tui/tui-regs.c (tui_show_register_group)
8094         (tui_display_registers_from, tui_display_reg_element_at_line):
8095         Remove unnecessary cast.
8096
8097 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8098
8099         * linux-nat.c (normal_mask): Delete.
8100         (_initialize_linux_nat): Don't initialise normal_mask.
8101
8102 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8103
8104         PR gdb/24445
8105         * dwarf-index-write.h (write_psymtabs_to_index): Add
8106         dwz_basename parameter.
8107         * dwarf-index-write.c (write_gdbindex): Move file writing to
8108         write_gdbindex_1.  Change return type void.
8109         (assert_file_size): Move up, remove filename parameter.
8110         (write_gdbindex_1): New function.
8111         (write_debug_names): Change return type to void, call
8112         assert_file_size.
8113         (struct index_wip_file): New struct.
8114         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8115         file logic to index_wip_file.  Write index for dwz file if
8116         needed.
8117         (save_gdb_index_command): Pass basename of dwz file, if present.
8118         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8119         build-id of dwz file, if present.
8120         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8121         (dwarf2_get_dwz_file): Likewise.
8122         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8123         (dwarf2_get_dwz_file): Likewise.
8124
8125 2019-06-16  Tom Tromey  <tom@tromey.com>
8126
8127         * coffread.c (process_coff_symbol): Use xstrdup.
8128         * value.c (create_internalvar): Use xstrdup.
8129
8130 2019-06-16  Tom Tromey  <tom@tromey.com>
8131
8132         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8133         * breakpoint.c (stopin_command, stopat_command)
8134         (until_break_command, decode_location_default): Remove unnecessary
8135         cast.
8136         * utils.c (subset_compare): Remove unnecessary cast.
8137         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8138         cast.
8139         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8140         cast.
8141         * infcmd.c (path_command): Remove unnecessary cast.
8142         * coffread.c (decode_type): Remove unnecessary cast.
8143         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8144         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8145         * tui/tui-stack.c (tui_show_locator_content)
8146         (tui_show_frame_info): Remove unnecessary cast.
8147         * tui/tui-win.c (tui_scroll_forward_command)
8148         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8149         (parse_scrolling_args): Remove unnecessary cast.
8150         * tui/tui-data.c (init_win_info, tui_del_window)
8151         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8152         (free_content_elements): Remove unnecessary cast.
8153         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8154         unnecessary cast.
8155         * tui/tui-source.c (tui_set_source_content)
8156         (tui_vertical_source_scroll): Remove unnecessary cast.
8157         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8158         cast.
8159         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8160         * tui/tui-regs.c (tui_display_registers_from)
8161         (tui_display_register): Remove unnecessary cast.
8162         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8163         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8164         (make_visible): Remove unnecessary cast.
8165         * tui/tui-winsource.c (tui_erase_source_content)
8166         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8167         unnecessary cast.
8168         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8169         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8170         * stabsread.c (read_type, read_array_type, read_range_type):
8171         Remove unnecessary cast.
8172         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8173         (parse_symbol, parse_type, upgrade_type, parse_external)
8174         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8175         unnecessary cast.
8176         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8177
8178 2019-06-16  Tom Tromey  <tom@tromey.com>
8179
8180         * tui/tui-data.c (tui_alloc_generic_win_info)
8181         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8182         checks.
8183
8184 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8185             Andrew Burgess  <andrew.burgess@embecosm.com>
8186
8187         * f-typeprint.c (f_print_type): Don't return early for not
8188         associated or not allocated types.
8189         (f_type_print_varspec_suffix): Add print_rank parameter and print
8190         ranks of array types in case they dangling.
8191         (f_type_print_base): Add print_rank parameter.
8192
8193 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8194
8195         * NEWS: Mention new MI commands.
8196         * break-catch-throw.c (enum exception_event_kind): Move to
8197         breakpoint.h.
8198         (print_mention_exception_catchpoint): Output text as a single
8199         message.
8200         (catch_exception_command_1): Rename to...
8201         (catch_exception_event): ...this, make non-static, update header
8202         command, and change some parameter types.
8203         (catch_catch_command): Update for changes to
8204         catch_exception_command_1.
8205         (catch_throw_command): Likewise.
8206         (catch_rethrow_command): Likewise.
8207         * breakpoint.c (enum exception_event_kind): Delete.
8208         * breakpoint.h (enum exception_event_kind): Moved here from
8209         break-catch-throw.c.
8210         (catch_exception_event): Declare.
8211         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8212         (mi_cmd_catch_throw): New function.
8213         (mi_cmd_catch_rethrow): New function.
8214         (mi_cmd_catch_catch): New function.
8215         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8216         'catch-catch' entries.
8217         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8218         (mi_cmd_catch_rethrow): Declare.
8219         (mi_cmd_catch_catch): Declare.
8220
8221 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8222
8223         * annotate.c (annotate_source_line): Change return type to void,
8224         update implementation to match.
8225         * annotate.h (annotate_source_line): Change return type to void,
8226         update header comment.
8227         * stack.c (print_frame_info): Don't change what frame information
8228         is printed based on whether annotations are on or not.
8229
8230 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8231
8232         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8233         (annotate_source): Make static.
8234         (annotate_source_line): Moved from source.c and renamed from
8235         identify_source_line.  Update the return type.
8236         * annotate.h (annotate_source): Delete declaration.
8237         (annotate_source_line): Declaration moved from source.h, and
8238         renamed from identify_source_line.  Return type updated.
8239         * source.c (identify_source_line): Moved to annotate.c and renamed
8240         to annotate_source_line.
8241         (info_line_command): Remove check of annotation_level.
8242         * source.h (identify_source_line): Move declaration to annotate.h
8243         and rename to annotate_source_line.
8244         * stack.c: Add 'annotate.h' include.
8245         (print_frame_info): Remove check of annotation_level before
8246         calling annotate_source_line.
8247
8248 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8249
8250         * source-cache.c (source_cache::get_plain_source_lines): Use
8251         open_source_file_with_line_charpos instead of just
8252         open_source_file, remove call to find_source_lines.
8253         (source_cache::get_source_lines): Likewise.
8254         * source.c (find_source_lines): Make static.
8255         (get_filename_and_charpos): Renamed into...
8256         (open_source_file_with_line_charpos): ..this along with changes to
8257         return a scoped_fd, and some other minor clean ups.
8258         (identify_source_line): Use open_source_file_with_line_charpos.
8259         (search_command_helper): Use open_source_file_with_line_charpos
8260         instead of just open_source_file, remove call to
8261         find_source_lines.
8262         * source.h (open_source_file_with_line_charpos): Declare new
8263         function.
8264         (find_source_lines): Delete declaration.
8265
8266 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8267
8268         * source.c (get_filename_and_charpos): Remove fullname
8269         parameter.
8270         (identify_source_line): Update call to get_filename_and_charpos.
8271
8272 2019-06-14  Tom Tromey  <tromey@adacore.com>
8273
8274         PR gdb/24502:
8275         * ui-style.h (skip_ansi_escape): Update comment.
8276         * ui-file.h (class no_terminal_escape_file): New class.
8277         * ui-file.c (no_terminal_escape_file::write)
8278         (no_terminal_escape_file::puts): New methods.
8279         * cli/cli-logging.c (handle_redirections): Use
8280         no_terminal_escape_file.
8281
8282 2019-06-14  Tom Tromey  <tromey@adacore.com>
8283
8284         * NEWS: Move convenience variable news above Python news.
8285
8286 2019-06-14  Tom Tromey  <tom@tromey.com>
8287
8288         * gnulib: Move directory to top-level.
8289         * configure.ac: Don't configure gnulib.
8290         * configure: Rebuild.
8291         * common/common-defs.h: Use new path to gnulib.
8292         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8293         (GNULIB_H): Remove.
8294         (INCGNU): Look in new gnulib location.
8295         (HFILES_NO_SRCDIR): Remove gnulib files.
8296         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8297         (generated_files): Remove GNULIB_H.
8298         ($(LIBGNU), all-lib): Remove targets.
8299         (distclean): Don't mention GNULIB_BUILDDIR.
8300         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8301
8302 2019-06-14  Tom Tromey  <tromey@adacore.com>
8303
8304         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8305         Warn if symbol file does not provide any symbols.
8306
8307 2019-06-14  Tom Tromey  <tromey@adacore.com>
8308
8309         * source.c (find_and_open_source): Respect basenames_may_differ.
8310
8311 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8312
8313         * annotate.c (annotate_breakpoints_invalid): Make use of
8314         scoped_restore_terminal_state.
8315         (annotate_frames_invalid): Likewise.
8316
8317 2019-06-14  Tom Tromey  <tromey@adacore.com>
8318
8319         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8320         allow assignment to an internalvar.
8321
8322 2019-06-14  Tom Tromey  <tromey@adacore.com>
8323
8324         * ada-lex.l: Allow "_" in attribute names.
8325
8326 2019-06-14  Tom Tromey  <tromey@adacore.com>
8327
8328         PR gdb/24653:
8329         * regcache.c (registers_changed): Don't call alloca.
8330         * top.c (execute_command): Don't call alloca.
8331
8332 2019-06-13  Pedro Alves  <palves@redhat.com>
8333
8334         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8335         'expression'.  When parsing an expression, error out if there's
8336         junk after "unlimited".
8337         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8338         (do_set_command): Adjust calls to is_unlimited_literal.
8339
8340 2019-06-13  Pedro Alves  <palves@redhat.com>
8341
8342         * compile/compile.c (make_compile_options_def_group): Add braces
8343         around array_view initializer.
8344         * thread.c (make_thread_apply_all_options_def_group)
8345         (make_thread_apply_all_options_def_group): Likewise.
8346
8347 2019-06-13  Pedro Alves  <palves@redhat.com>
8348
8349         * NEWS (New commands): Mention "maint test-options
8350         require-delimiter", "maint test-options unknown-is-error", "maint
8351         test-options unknown-is-operand" and "maint show
8352         test-options-completion-result".
8353         (New command options, command completion): New section.
8354         (Completion improvements): New section.
8355         Mention that you can abbreviate "unlimited".
8356
8357 2019-06-13  Pedro Alves  <palves@redhat.com>
8358
8359         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8360         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8361         * unittests/cli-utils-selftests.c (test_parse_flags)
8362         (test_parse_flags_qcs): Delete.
8363         (test_cli_utils): Don't call deleted functions.
8364
8365 2019-06-13  Pedro Alves  <palves@redhat.com>
8366
8367         * thread.c: Include "cli/cli-option.h".
8368         (tp_array_compar_ascending): Global.
8369         (tp_array_compar): Delete function.
8370         (tp_array_compar_ascending, tp_array_compar_descending): New
8371         functions.
8372         (ascending_option_def, qcs_flag_option_def)
8373         (thr_qcs_flags_option_defs)
8374         (make_thread_apply_all_options_def_group)
8375         (make_thread_apply_options_def_group): New.
8376         (thread_apply_all_command): Use gdb::option::process_options.
8377         (thread_apply_command_completer)
8378         (thread_apply_all_command_completer): New.
8379         (thread_apply_command): Use gdb::option::process_options.
8380         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8381         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8382         to generate help text of "thread apply".  Adjust "taas"'s help.
8383         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8384         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8385
8386 2019-06-13  Pedro Alves  <palves@redhat.com>
8387
8388         * thread.c (thread_apply_command): Check for invalid TID with
8389         isdigit instead of !isalpha.
8390
8391 2019-06-13  Pedro Alves  <palves@redhat.com>
8392
8393         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8394         (validate_flags_qcs): New.
8395         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8396         (validate_flags_qcs): Declare.
8397         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8398         (make_frame_apply_options_def_group): New.
8399         (frame_apply_command_count): Process options with
8400         gdb::option::process_options.
8401         (frame_apply_completer): New.
8402         (frame_apply_level_completer, frame_apply_all_completer)
8403         (frame_apply_completer): New.
8404         (_initialize_stack): Update help of "frame apply", "frame apply
8405         level", "frame apply all" and "faas" to mention supported options
8406         and install command completers.
8407         * stack.h (frame_apply_all_completer): Declare.
8408         * thread.c: Include "stack.h".
8409         (tfaas_command): Add "--".
8410         (_initialize_thread): Update help "tfaas" to mention supported
8411         options and install command completer.
8412
8413 2019-06-13  Pedro Alves  <palves@redhat.com>
8414
8415         * completer.c (complete_nested_command_line): New.
8416         (gdb_completion_word_break_characters_throw): Add assertion.
8417         * completer.h (complete_nested_command_line): Declare.
8418
8419 2019-06-13  Pedro Alves  <palves@redhat.com>
8420
8421         * stack.c (parse_backtrace_qualifiers): New.
8422         (backtrace_command): Use it.
8423         (backtrace_command_completer): Complete on qualifiers.
8424
8425 2019-06-13  Pedro Alves  <palves@redhat.com>
8426
8427         * frame.c: Include "cli/cli-option.h.
8428         (user_set_backtrace_options): New.
8429         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8430         Delete.
8431         (get_prev_frame): Adjust.
8432         (boolean_option_def, uinteger_option_def)
8433         (set_backtrace_option_defs): New.
8434         (_initialize_frame): Adjust and use
8435         gdb::option::add_setshow_cmds_for_options to install "set
8436         backtrace past-main" and "set backtrace past-entry".
8437         * frame.h: Include "cli/cli-option.h".
8438         (struct frame_print_options): Forward declare.
8439         (print_frame_arguments_all, print_frame_arguments_scalars)
8440         (print_frame_arguments_none): Declare.
8441         (print_entry_values): Delete declaration.
8442         (struct frame_print_options, user_frame_print_options): New.
8443         (struct set_backtrace_options): New.
8444         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8445         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8446         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8447         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8448         (list_args_or_locals): Add frame_print_options parameter.
8449         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8450         * python/py-framefilter.c (enumerate_args): Pass down
8451         USER_FRAME_PRINT_OPTIONS.
8452         * stack.c: Include "cli/cli-option.h".
8453         (print_frame_arguments_all, print_frame_arguments_scalars)
8454         (print_frame_arguments_none): Declare.
8455         (print_raw_frame_arguments, print_entry_values): Delete.
8456         (user_frame_print_options): New.
8457         (boolean_option_def, enum_option_def, frame_print_option_defs):
8458         New.
8459         (struct backtrace_cmd_options): New.
8460         (bt_flag_option_def): New.
8461         (backtrace_command_option_defs): New.
8462         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8463         (print_frame_arg, read_frame_arg, print_frame_args)
8464         (print_frame_info, print_frame): Add frame_print_options parameter
8465         and use it.
8466         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8467         (backtrace_command_1): Add frame_print_options and
8468         backtrace_cmd_options parameters and use them.
8469         (make_backtrace_options_def_group): New.
8470         (backtrace_command): Process command options with
8471         gdb::option::process_options.
8472         (backtrace_command_completer): New.
8473         (_initialize_stack): Extend "backtrace"'s help to mention
8474         supported options.  Install completer for "backtrace".
8475         Install some settings commands with add_setshow_cmds_for_options.
8476
8477 2019-06-13  Pedro Alves  <palves@redhat.com>
8478
8479         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8480         and that "set/show print raw frame-arguments" are now deprecated.
8481
8482         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8483         command.
8484         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8485         * stack.c (_initialize_stack): Install "set/show print
8486         raw-frame-arguments", and deprecate "set/show print raw
8487         frame-arguments".
8488         * valprint.c (_initialize_valprint): Deprecate "set/show print
8489         raw".
8490
8491 2019-06-13  Pedro Alves  <palves@redhat.com>
8492
8493         * compile/compile.c (struct compile_options): New.
8494         (compile_flag_option_def, compile_command_option_defs)
8495         (make_compile_options_def_group): New.
8496         (compile_file_command): Handle options with
8497         gdb::option::process_options.
8498         (compile_file_command_completer): New function.
8499         (compile_code_command): Handle options with
8500         gdb::option::process_options.
8501         (compile_code_command_completer): New function.
8502         (_initialize_compiler): Install completers for "compile code" and
8503         "compile file".  Mention available options in "compile code" and
8504         "compile code"'s help.
8505         * completer.c (advance_to_completion_word): New, factored out from
8506         ...
8507         (advance_to_expression_complete_word_point): ... this.
8508         (advance_to_filename_complete_word_point): New.
8509         * completer.h (advance_to_filename_complete_word_point): New
8510         declaration.
8511
8512 2019-06-13  Pedro Alves  <palves@redhat.com>
8513
8514         * compile/compile.c: Include "cli/cli-option.h".
8515         (compile_print_value): Scope data pointer is now a
8516         value_print_options pointer; adjust.
8517         (compile_print_command): Process options.  Scope data pointer is
8518         now a value_print_options pointer; adjust.
8519         (_initialize_compile): Update "compile print"'s help to include
8520         supported options.  Install a completer for "compile print".
8521         * cp-valprint.c (show_vtblprint, show_objectprint)
8522         (show_static_field_print): Delete.
8523         (_initialize_cp_valprint): Don't install "set print
8524         static-members", "set print vtbl", "set print object" here.
8525         * printcmd.c: Include "cli/cli-option.h" and
8526         "common/gdb_optional.h".
8527         (print_command_parse_format): Rework to fill in a
8528         value_print_options instead of a format_data.
8529         (print_value): Change parameter type from format_data pointer to
8530         value_print_options reference.  Adjust.
8531         (print_command_1): Process options.  Adjust to pass down a
8532         value_print_options.
8533         (print_command_completer): New.
8534         (_initialize_printcmd): Install print_command_completer as
8535         handle_brkchars completer for the "print" command.  Update
8536         "print"'s help to include supported options.
8537         * valprint.c: Include "cli/cli-option.h".
8538         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8539         here from cp-valprint.c.
8540         (boolean_option_def, uinteger_option_def)
8541         (value_print_option_defs, make_value_print_options_def_group):
8542         New.  Use gdb::option::add_setshow_cmds_for_options to install
8543         "set print elements", "set print null-stop", "set print repeats",
8544         "set print pretty", "set print union", "set print array", "set
8545         print address", "set print symbol", "set print array-indexes".
8546         * valprint.h: Include <string> and "cli/cli-option.h".
8547         (make_value_print_options_def_group): Declare.
8548         (print_value): Change parameter type from format_data pointer to
8549         value_print_options reference.
8550         (print_command_completer): Declare.
8551
8552 2019-06-13  Pedro Alves  <palves@redhat.com>
8553
8554         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8555         (COMMON_SFILES): Add maint-test-settings.c.
8556         * cli/cli-decode.c (boolean_enums): New global, factored out from
8557         ...
8558         (add_setshow_boolean_cmd): ... here.
8559         * cli/cli-decode.h (boolean_enums): Declare.
8560         * cli/cli-option.c: New file.
8561         * cli/cli-option.h: New file.
8562         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8563         factored out from ...
8564         (parse_cli_boolean_value(const char *)): ... this.
8565         (is_unlimited_literal): Change parameter type to pointer to
8566         pointer.  Adjust and advance ARG pointer.
8567         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8568         (parse_cli_var_enum): New, factored out from ...
8569         (do_set_command): ... this.  Adjust.
8570         * cli/cli-setshow.h (parse_cli_boolean_value)
8571         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8572         (parse_cli_var_enum): Declare.
8573         * cli/cli-utils.c: Include "cli/cli-option.h".
8574         (get_ulongest): New.
8575         * cli/cli-utils.h (get_ulongest): Declare.
8576         (check_for_argument): New overloads.
8577         * maint-test-options.c: New file.
8578
8579 2019-06-13  Pedro Alves  <palves@redhat.com>
8580
8581         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8582         parse a range if "-" is at the end of the string.
8583
8584 2019-06-13  Pedro Alves  <palves@redhat.com>
8585
8586         * cli/cli-setshow.c (parse_auto_binary_operation)
8587         (parse_cli_boolean_value): Don't allow "o".
8588
8589 2019-06-13  Pedro Alves  <palves@redhat.com>
8590
8591         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8592         * NEWS: Mention maint test-settings KIND.
8593         * maint-test-settings.c: New file.
8594
8595 2019-06-13  Pedro Alves  <palves@redhat.com>
8596
8597         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8598         completer.
8599         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8600         "set" completers.
8601
8602 2019-06-13  Pedro Alves  <palves@redhat.com>
8603
8604         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8605         after item.
8606
8607 2019-06-13  Pedro Alves  <palves@redhat.com>
8608
8609         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8610
8611 2019-06-13  Pedro Alves <palves@redhat.com>
8612
8613         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8614         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8615         call.
8616         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8617         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8618         calls.
8619         (check_for_argument): Skip spaces after argument.
8620
8621 2019-06-13  Pedro Alves  <palves@redhat.com>
8622
8623         * thread.c (thread_apply_command): Adjust TID parsing.
8624         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8625         detected before end of string.
8626         (tid_is_in_list): Error out if LIST is invalid.
8627
8628 2019-06-13  Pedro Alves  <palves@redhat.com>
8629
8630         * completer.c (complete_line_internal_1): Rewind completion word
8631         point.
8632         (completion_tracker::advance_custom_word_point_by): Change
8633         parameter type to int.
8634         * completer.h (completion_tracker::advance_custom_word_point_by):
8635         Likewise.
8636
8637 2019-06-13  Pedro Alves  <palves@redhat.com>
8638
8639         * completer.c (advance_to_completion_word): Handle delimiters.
8640
8641 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8642
8643         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8644
8645 2019-06-11  Tom Tromey  <tom@tromey.com>
8646
8647         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8648         (xmalloc_failed): Move to alloc.c.
8649         * alloc.c: New file.
8650         * Makefile.in (COMMON_SFILES): Add alloc.c.
8651
8652 2019-06-11  Tom Tromey  <tom@tromey.com>
8653
8654         * nat/linux-waitpid.c: Don't include server.h.
8655         (linux_debug): Remove.
8656         (my_waitpid): Update.
8657
8658 2019-06-11  Tom Tromey  <tromey@adacore.com>
8659
8660         * infcall.c (_initialize_infcall): Remove trailing newline from
8661         help.
8662         * user-regs.c (_initialize_user_regs): Remove trailing newline
8663         from help.
8664         * typeprint.c (_initialize_typeprint): Remove trailing newline
8665         from help.
8666         * reverse.c (_initialize_reverse): Remove trailing newlines from
8667         help.
8668         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8669         from help.
8670         * language.c (add_set_language_command): Remove trailing newline
8671         from help.
8672         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8673         help.
8674         * disasm.c (_initialize_disasm): Remove trailing newline from
8675         help.
8676         * top.c (init_main): Remove trailing newline from help.
8677         * interps.c (_initialize_interpreter): Remove trailing newline
8678         from help.
8679         * btrace.c (_initialize_btrace): Remove trailing newlines from
8680         help.
8681         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8682         from help.
8683         * python/python.c (_initialize_python): Remove trailing newline
8684         from help.
8685         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8686         help.
8687         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8688         from help.  Reformat some text.
8689         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8690         from help.
8691         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8692         newline from help.
8693
8694 2019-06-11  Tom Tromey  <tromey@adacore.com>
8695
8696         * darwin-nat.c (darwin_decode_exception_message)
8697         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8698
8699 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8700
8701         * valops.c (value_slice): Check for not allocated or not
8702         associated values.
8703
8704 2019-06-10  Tom de Vries  <tdevries@suse.de>
8705
8706         PR gdb/24618
8707         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8708         sure an empty slot (defined by a 32-bit zero pair) is recognized as
8709         invalid.
8710
8711 2019-06-10  Tom de Vries  <tdevries@suse.de>
8712
8713         PR gdb/24611
8714         * linespec.c (linespec_lexer_lex_string): Remove incorrect
8715         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
8716
8717 2019-06-10  Tom de Vries  <tdevries@suse.de>
8718
8719         PR symtab/24545
8720         * symtab.c (struct demangled_name_entry): Add language field.
8721         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
8722         static minimal symbol".  Set and use language field.
8723
8724 2019-06-10  Tom Tromey  <tromey@adacore.com>
8725
8726         * ada-lang.c (_initialize_ada_language): Update help text.
8727
8728 2019-06-10  Tom Tromey  <tromey@adacore.com>
8729
8730         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8731         with a newline.
8732         * guile/guile.c (handle_boot_error): Don't end warning with a
8733         newline.
8734         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8735         warning with a newline.
8736         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8737         newline.
8738         (s12z_frame_cache): Likewise.
8739         * dwarf-index-cache.c (index_cache::store): Don't end warning with
8740         a newline.
8741         * solib-svr4.c (disable_probes_interface): Don't end warning with
8742         a newline.
8743         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8744         newline.
8745         * python/python.c (do_finish_initialization): Don't end warning
8746         with a newline.
8747
8748 2019-06-10  Tom Tromey  <tom@tromey.com>
8749
8750         * python/py-breakpoint.c (gdbpy_breakpoint_created)
8751         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8752         gdbpy_enter.
8753
8754 2019-06-10  Tom Tromey  <tromey@adacore.com>
8755
8756         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8757         data.
8758         (elf_new_init): Don't call stabsread_new_init.
8759         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8760         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
8761         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8762
8763 2019-06-10  Tom de Vries  <tdevries@suse.de>
8764
8765         PR symtab/16264
8766         PR symtab/24517
8767         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8768
8769 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
8770
8771         * source.c (find_and_open_source): Also rewrite relative file
8772         names.
8773
8774 2019-04-26  Amos Bird  <amosbird@gmail.com>
8775
8776         * annotate.c (annotate_thread_exited): Add "thread-exited"
8777         annotation.
8778
8779 2019-06-06  Tom Tromey  <tromey@adacore.com>
8780
8781         * maint.h (class scoped_command_stats): Use
8782         DISABLE_COPY_AND_ASSIGN.
8783         <print_time>: New method.
8784         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8785         print_time.
8786         (scoped_command_stats::print_time): New method.
8787
8788 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
8789
8790         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8791         instructions of lengths 6 or 8 bytes.
8792
8793 2019-06-04  Pedro Alves  <palves@redhat.com>
8794
8795         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8796
8797         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8798         * breakpoint.c (condition_completer): Likewise.
8799         * cli/cli-dump.c (scan_expression): Likewise.
8800         * common/filestuff.c (mkdir_recursive): Likewise.
8801         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8802         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8803         (gdb_abspath): Likewise.
8804         * compile/compile-cplus-types.c
8805         (compile_cplus_instance::decl_name): Likewise.
8806         * completer.c (complete_explicit_location):
8807         (signal_completer, reg_or_group_completer_1): Likewise.
8808         * cp-support.c (cp_remove_params_if_any): Likewise.
8809         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8810         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8811         * infcmd.c (strip_bg_char): Likewise.
8812         * linespec.c (copy_token_string): Likewise.
8813         * mi/mi-main.c (output_cores): Likewise.
8814         * psymtab.c (psymtab_search_name):
8815         * symfile.c (test_set_ext_lang_command): Likewise.
8816         * target.c (target_fileio_read_stralloc): Likewise.
8817         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8818         * value.c (complete_internalvar): Likewise.
8819
8820 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
8821
8822         Add objfile property to gdb.Type.
8823         * NEWS: Mention Python API addition.
8824         * python/py-type.c (typy_get_objfile): New method.
8825
8826 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8827
8828         * NEWS: Mention the new set|show style [title|highlight].
8829         Mention changes to "show style", "help" and "apropos".
8830
8831 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8832
8833         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8834         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
8835         instead of print_help_for_command.
8836         (print_doc_of_command): New function.
8837         (help_list): Add 'apropos -v word' suggestion.
8838         (print_help_for_command): Style the command name using title style.
8839         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8840         (_initialize_cli_cmds): Describe -v in apropos_command help.
8841
8842 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8843
8844         * cli/cli-style.h (cli_style_option): Add name in constructor,
8845         add m_name class member, add constructor with intensity,
8846         add name class function.
8847         (cli_style_option::add_setshow_commands): Remove name argument.
8848         (highlight_style, title_style): New styles.
8849         * cli/cli-style.c (do_show): New function that shows a style
8850         characteristic styling the style name with itself.
8851         (set_style_name): New function.
8852         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8853         Update all callers according to the changes in cli/cli-style.h.
8854         * utils.h (fputs_highlighted): New function.
8855         * utils.c (fputs_highlighted): Likewise.
8856
8857 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8858
8859         * NEWS: Mention new pipe command and new convenience variables.
8860
8861 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8862
8863         * cli/cli-cmds.c (pipe_command): New function.
8864         (_initialize_cli_cmds): Call add_com for pipe_command.
8865         Define | as an alias for pipe.
8866         (exit_status_set_internal_vars): New function.
8867         (shell_escape): Call exit_status_set_internal_vars.
8868         cli/cli-decode.c (find_command_name_length): Recognize | as
8869         a single character command.
8870
8871 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8872
8873         * gdbcmd.h (execute_command_to_ui_file): New declaration.
8874         top.c (execute_command_to_ui_file): New function, mostly a copy
8875         of execute_command_to_string.
8876         (execute_command_to_string): Implement by calling
8877         execute_command_to_ui_file.
8878
8879 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8880
8881         * top.h (saved_command_line): Remove declaration.
8882         * top.c (previous_saved_command_line, previous_repeat_arguments):
8883         New variables.
8884         (saved_command_line): Make static, define together with other
8885         'repeat variables'.
8886         (dont_repeat): Clear repeat_arguments.
8887         (repeat_previous, get_saved_command_line, save_command_line):
8888         New functions.
8889         (gdb_init): Initialize saved_command_line
8890         and previous_saved_command_line.
8891         * main.c (captured_main_1): Remove saved_command_line initialization.
8892         * event-top.c (handle_line_of_input): Update to use
8893         the new 'repeat' related functions instead of direct access to
8894         saved_command_line.
8895         * command.h (repeat_previous, get_saved_command_line,
8896         save_command_line): New declarations.
8897         (dont_repeat): Add comment.
8898
8899 2019-05-30  Tom Tromey  <tromey@adacore.com>
8900
8901         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
8902         Fix comment.
8903         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
8904
8905 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
8906
8907         PR cli/24587
8908         * completer.c (complete): Initialize variable word.
8909
8910 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
8911
8912         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8913         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
8914         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
8915         'body' is NULL to the outter 'if', protecting the '!is_define'
8916         situation as well.
8917
8918 2019-05-29  Tom Tromey  <tromey@adacore.com>
8919
8920         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
8921         (dwarf_unknown): New function.
8922         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
8923         (dwarf_type_encoding_name): Use dwarf_unknown.
8924
8925 2019-05-29  Tom Tromey  <tromey@adacore.com>
8926
8927         PR c++/20020:
8928         * cp-valprint.c (cp_print_value_fields): Call
8929         cp_print_static_field inside "try".
8930
8931 2019-05-29  Tom Tromey  <tromey@adacore.com>
8932
8933         * inflow.c (struct terminal_info): Add default operator=.
8934         * configure: Rebuild.
8935         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
8936         -Wdeprecated-copy-dtor, -Wredundant-move.
8937
8938 2019-05-29  Tom Tromey  <tromey@adacore.com>
8939
8940         * NEWS: Add entry.
8941         * infcmd.c (print_return_value_1): Handle finish_print
8942         option.
8943         (show_print_finish): New function.
8944         (_initialize_infcmd): Add "set/show print finish" commands.
8945         * valprint.c (user_print_options): Initialize new member.
8946         * valprint.h (struct value_print_options) <finish_print>: New
8947         member.
8948
8949 2019-05-28  Tom Tromey  <tromey@adacore.com>
8950
8951         * ada-lang.c (ada_remove_Xbn_suffix)
8952         (find_old_style_renaming_symbol)
8953         (parse_old_style_renaming): Remove.
8954         (ada_find_renaming_symbol): Don't call
8955         find_old_style_renaming_symbol.
8956         (ada_is_renaming_symbol): Rename from
8957         ada_find_renaming_symbol.  Remove "block" parameter.  Return
8958         bool.  Now static.
8959         (ada_read_var_value): Update and simplify.
8960         * ada-exp.y (write_var_or_type): Remove old code.
8961
8962 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
8963
8964         PR gdb/25010
8965         * event-top.c: Remove include comment.
8966         * inflow.c (class scoped_ignore_sigttou): Move from here...
8967         * inflow.h (class scoped_ignore_sigttou): ...to here.
8968         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
8969         * top.c:  Remove include comment.
8970
8971 2019-05-27  Tom Tromey  <tom@tromey.com>
8972
8973         * NEWS: Fix typo.
8974
8975 2019-05-22  Tom Tromey  <tromey@adacore.com>
8976
8977         * target.c (target_follow_exec): Constify parameter.
8978         * target-delegates.c: Rebuild.
8979         * remote.c (remote_target::follow_exec): Constify parameter.
8980         * infrun.c (follow_exec): Constify parameter.
8981         * target.h (struct target_ops) <follow_exec>: Constify parameter.
8982         (target_follow_exec): Likewise.
8983
8984 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8985
8986         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
8987         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
8988
8989 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8990
8991         * NEWS: Add debugredirect and testsuite sections.
8992
8993 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
8994
8995         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8996         target descriptions using exclusively floating point register name
8997         aliases.
8998
8999 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9000
9001         PR gdb/18644:
9002         * f-lang.c (build_fortran_types): Handle the case where
9003         gdbarch_floatformat_for_type returns a nullptr.
9004
9005 2019-05-21  Tom de Vries  <tdevries@suse.de>
9006
9007         PR cli/24587
9008         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9009
9010 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9011
9012         PR gdb/18644:
9013         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9014         16-byte floats.
9015         * i386-tdep.c (i386_floatformat_for_type): Use
9016         floatformats_ia64_quad for the 16-byte floating point component
9017         within a fortran 32-byte complex number.
9018
9019 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9020
9021         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9022         delete default constructor.
9023         (find_partial_die): Update to return const struct.
9024         (partial_die_parent_scope): Move variable declaration into scope
9025         of its use and change its type to auto.
9026         (guess_partial_die_structure_name): Likewise.
9027         (partial_die_info::fixup): Likewise.
9028
9029 2019-05-17  Tom Tromey  <tromey@adacore.com>
9030
9031         * source.c (find_and_open_source): Remove cast.
9032
9033 2019-05-17  Tom Tromey  <tromey@adacore.com>
9034
9035         * annotate.c (annotate_source): Make "filename" const.
9036         * annotate.h (annotate_source): Use const.
9037
9038 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9039
9040         * disasm.c (set_disassembler_options): Send errors to stderr.
9041
9042 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9043
9044         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9045         (cli_interp_base::set_logging): Check debug_redirect.
9046         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9047         * cli/cli-logging.c (debug_redirect): Add static variable.
9048         (pop_output_files): Add default param.
9049         (handle_redirections): Print debug setting.
9050         (show_logging_command): Likewise.
9051         (_initialize_cli_logging): Add debugredirect command.
9052         * interps.c (current_interp_set_logging): Add debug_redirect
9053         parameter.
9054         * interps.h (set_logging): Add debug_redirect parameter.
9055         (current_interp_set_logging): Likewise.
9056         * mi/mi-common.h: Likewise.
9057         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9058
9059 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9060             Tom Tromey  <tromey@adacore.com>
9061
9062         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9063         directly.
9064         * cli/cli-interp.h (make_logging_output): Remove declaration.
9065         * cli/cli-logging.c (make_logging_output): Remove function.
9066         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9067         directly.
9068         * ui-file.c (tee_file::tee_file): Remove bools.
9069         (tee_file::~tee_file): Remove deletes.
9070         * ui-file.h (tee_file): Remove bools.
9071
9072 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9073
9074         * mi/mi-cmds.h (mi_cmd_complete): New function.
9075         * mi/mi-main.c (mi_cmd_complete): Likewise.
9076         * mi/mi-cmds.c: Define new MI command -complete.
9077         * NEWS: Mention new -complete command.
9078
9079 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9080
9081         * completer.h (complete): New function.
9082         * completer.c (complete): Likewise.
9083         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9084         function defined in completer.h.
9085
9086 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9087
9088         * MAINTAINERS (Write After Approval): Add myself.
9089
9090 2019-05-17  Tom de Vries  <tdevries@suse.de>
9091
9092         PR gdb/24094
9093         * dwarf2read.c (struct cu_partial_die_info): New struct.
9094         (find_partial_die): Return cu_partial_die_info.
9095         (partial_die_parent_scope, guess_partial_die_structure_name)
9096         (partial_die_info::fixup): Handle new return type of find_partial_die.
9097
9098 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9099
9100         PR breakpoints/24541
9101         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9102         "std::string", simplifying the algorithm.
9103
9104 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9105
9106         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9107         (stap_static_probe_ops::get_probes): Likewise.
9108
9109 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9110
9111         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9112         '-')" and "else if".
9113         (stap_parse_single_operand): Join checks for
9114         "gdbarch_stap_parse_special_token_p" and
9115         "gdbarch_stap_parse_special_token" in the same "if" statement.
9116         Invert check when verifying for operation on register
9117         displacement.
9118
9119 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9120
9121         * stap-probe.c (stap_get_opcode): Update comment.
9122         (stap_get_expected_argument_type): Likewise.
9123         (handle_stap_probe): Likewise.
9124
9125 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9126
9127         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9128         return type to 'bool'.  Adjust comment.  Use 'bool' when
9129         appropriate.
9130         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9131         * stap-probe.c (stap_parse_argument_1): Likewise.
9132         (stap_is_operator): Likewise.
9133         (stap_is_generic_prefix): Likewise.
9134         (stap_is_register_prefix): Likewise.
9135         (stap_is_register_indirection_prefix): Likewise.
9136         (stap_is_integer_prefix): Likewise.
9137         (stap_generic_check_suffix): Likewise.
9138         (stap_check_integer_suffix): Likewise.
9139         (stap_check_register_suffix): Likewise.
9140         (stap_check_register_indirection_suffix): Likewise.
9141         (stap_parse_register_operand): Likewise.
9142         (stap_parse_single_operand): Likewise.
9143         (stap_parse_argument_1): Likewise.
9144         (stap_probe::get_argument_count): Likewise.
9145         (stap_is_operator): Likewise.
9146
9147 2019-05-16  Tom Tromey  <tromey@adacore.com>
9148
9149         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9150         keyword to foreach.
9151
9152 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9153
9154         * linux-thread-db.c (try_thread_db_load_1): Change return type
9155         to bool.
9156         (try_thread_db_load): Likewise.
9157         (try_thread_db_load_from_pdir_1): Likewise.
9158         (try_thread_db_load_from_pdir): Likewise.
9159         (try_thread_db_load_from_sdir): Likewise.
9160         (try_thread_db_load_from_dir): Likewise.
9161         (thread_db_load_search): Likewise.
9162         (has_libpthread): Likewise.
9163         (thread_db_load): Likewise.
9164
9165 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9166
9167         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9168         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9169         NULL, and complain/return if that's the case.
9170
9171 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9172
9173         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9174         (advance, posn, abstract_read_memory): New functions.
9175         [struct mem_read_abstraction]: New struct.
9176         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9177
9178 2019-05-14  Tom Tromey  <tromey@adacore.com>
9179
9180         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9181         value is not lval_memory.
9182
9183 2019-05-14  Tom Tromey  <tromey@adacore.com>
9184
9185         * solib.c (info_sharedlibrary_command): Style the file name.
9186
9187 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9188
9189         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9190         (aarch64_vnv_type): Likewise.
9191         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9192         * common/tdesc.c: Likewise.
9193         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9194         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9195         * features/aarch64-fpu.xml: Add ieee half view.
9196         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9197         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9198         * gdbtypes.h (struct builtin_type): Likewise.
9199         (struct objfile_type): Likewise.
9200
9201 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9202
9203         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9204         typo.
9205         * location.h (string_to_event_location): Likewise.
9206
9207 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9208
9209         GDB 8.3 released.
9210
9211 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9212
9213         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9214         New variable declaration.
9215         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9216         New variable.
9217         (print_one_breakpoint): Use ui_out::test_flags and new global
9218         variable to compute use_fixed_output.
9219         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9220         Remove.
9221         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9222         (mi_multi_location_breakpoint_output_fixed): Remove.
9223         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9224         new variable.
9225         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9226         fix_multi_location_breakpoint_output flag if version >= 3.
9227         * ui-out.h (enum ui_out_flag)
9228         <fix_multi_location_breakpoint_output>: New enumerator.
9229
9230 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9231
9232         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9233
9234 2019-05-10  Tom Tromey  <tromey@adacore.com>
9235
9236         * ada-lang.c (catch_ada_completer): New function.
9237         (_initialize_ada_language): Use it.
9238
9239 2019-05-10  Tom Tromey  <tromey@adacore.com>
9240
9241         * thread.c (print_thread_info): Make "requested_threads" const.
9242         * gdbthread.h (print_thread_info): Make "requested_threads"
9243         const.
9244         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9245         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9246
9247 2019-05-08  Tom Tromey  <tom@tromey.com>
9248
9249         * gdbtypes.c (objfile_type_data): Change type.
9250         (objfile_type, _initialize_gdbtypes): Update.
9251
9252 2019-05-08  Tom Tromey  <tom@tromey.com>
9253
9254         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9255         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9256         (_initialize_dwarf2_frame): Update.
9257
9258 2019-05-08  Tom Tromey  <tom@tromey.com>
9259
9260         * objc-lang.c (objc_objfile_data): Change type.
9261         (find_methods): Update.
9262         (_initialize_objc_lang): Remove.
9263
9264 2019-05-08  Tom Tromey  <tom@tromey.com>
9265
9266         * stabsread.c (rs6000_builtin_type_data): Change type.
9267         (rs6000_builtin_type, _initialize_stabsread): Update.
9268
9269 2019-05-08  Tom Tromey  <tom@tromey.com>
9270
9271         * mips-tdep.c (mips_pdr_data): Remove.
9272         (_initialize_mips_tdep): Update.
9273
9274 2019-05-08  Tom Tromey  <tom@tromey.com>
9275
9276         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9277         (hppa_init_objfile_priv_data, read_unwind_info)
9278         (find_unwind_entry, _initialize_hppa_tdep): Update.
9279
9280 2019-05-08  Tom Tromey  <tom@tromey.com>
9281
9282         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9283         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9284         on obstack.
9285         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9286
9287 2019-05-08  Tom Tromey  <tom@tromey.com>
9288
9289         * mdebugread.c (basic_type_data): Change type.
9290         (basic_type, _initialize_mdebugread): Update.
9291
9292 2019-05-08  Tom Tromey  <tom@tromey.com>
9293
9294         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9295
9296 2019-05-08  Tom Tromey  <tom@tromey.com>
9297
9298         * nto-tdep.c (nto_inferior_data_reg): Change type.
9299         (nto_inferior_data): Update.
9300         (nto_inferior_data_cleanup, nto_new_inferior_data)
9301         (_initialize_nto_tdep): Remove.
9302         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9303
9304 2019-05-08  Tom Tromey  <tom@tromey.com>
9305
9306         * ada-lang.c (struct ada_inferior_data): Add initializers.
9307         (ada_inferior_data): Change type.
9308         (ada_inferior_data_cleanup): Remove.
9309         (get_ada_inferior_data, ada_inferior_exit)
9310         (struct ada_pspace_data): Add initializers, destructor.
9311         (ada_pspace_data_handle): Change type.
9312         (get_ada_pspace_data): Update.
9313         (ada_pspace_data_cleanup): Remove.
9314
9315 2019-05-08  Tom Tromey  <tom@tromey.com>
9316
9317         * coffread.c (struct coff_symfile_info): Add initializers.
9318         (coff_objfile_data_key): Move lower.  Change type.
9319         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9320         Update.
9321         (coff_free_info): Remove.
9322
9323 2019-05-08  Tom Tromey  <tom@tromey.com>
9324
9325         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9326         (fbsd_pspace_data_handle): Move lower.  Change type.
9327         (get_fbsd_pspace_data): Update.
9328         (fbsd_pspace_data_cleanup): Remove.
9329         (_initialize_fbsd_tdep): Update.
9330
9331 2019-05-08  Tom Tromey  <tom@tromey.com>
9332
9333         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9334         (get_ada_tasks_pspace_data): Update.
9335         (ada_tasks_pspace_data_cleanup): Remove.
9336         (_initialize_tasks): Update.
9337         (ada_tasks_inferior_data_handle): Change type.
9338         (get_ada_tasks_inferior_data): Update.
9339         (ada_tasks_inferior_data_cleanup): Remove.
9340         (struct ada_tasks_pspace_data): Add initializers.
9341
9342 2019-05-08  Tom Tromey  <tom@tromey.com>
9343
9344         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9345         * symfile-debug.c (debug_sym_get_probes): Change type.
9346         * stap-probe.c (handle_stap_probe):
9347         (stap_static_probe_ops::get_probes): Change type.
9348         * probe.h (class static_probe_ops) <get_probes>: Change type.
9349         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9350         (parse_probes_in_pspace): Update.
9351         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9352         Update.
9353         (any_static_probe_ops::get_probes): Change type.
9354         * elfread.c (elfread_data): New typedef.
9355         (probe_key): Change type.
9356         (elf_get_probes): Likewise.  Update.
9357         (probe_key_free): Remove.
9358         (_initialize_elfread): Update.
9359         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9360         Change type.
9361         (dtrace_process_dof_probe, dtrace_process_dof)
9362         (dtrace_static_probe_ops::get_probe): Change type.
9363
9364 2019-05-08  Tom Tromey  <tom@tromey.com>
9365
9366         * xcoffread.c (struct xcoff_symfile_info): Rename from
9367         coff_symfile_info.  Add initializers.
9368         (xcoff_objfile_data_key): Move lower.  Change type.
9369         (XCOFF_DATA): Rewrite.
9370         (xcoff_free_info): Remove.
9371         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9372         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9373         (xcoff_initial_scan): Update.
9374
9375 2019-05-08  Tom Tromey  <tom@tromey.com>
9376
9377         * solib-svr4.c (struct svr4_info): Add initializers and
9378         destructor.
9379         <probes_table>: Now an htab_up.
9380         (solib_svr4_pspace_data): Change type.
9381         (free_probes_table): Simplify.
9382         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9383         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9384         (probes_table_remove_objfile_probes, register_solib_event_probe)
9385         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9386         (_initialize_svr4_solib): Update.
9387
9388 2019-05-08  Tom Tromey  <tom@tromey.com>
9389
9390         * remote.c (remote_pspace_data): Change type.
9391         (remote_pspace_data_cleanup): Remove.
9392         (get_remote_exec_file, set_pspace_remote_exec_file)
9393         (_initialize_remote): Update.
9394
9395 2019-05-08  Tom Tromey  <tom@tromey.com>
9396
9397         * breakpoint.c (breakpoint_objfile_key): Change type.
9398         (get_breakpoint_objfile_data): Update.
9399         (free_breakpoint_objfile_data): Remove.
9400         (_initialize_breakpoint): Update.
9401
9402 2019-05-08  Tom Tromey  <tom@tromey.com>
9403
9404         * linux-tdep.c (struct linux_info): Add initializers.
9405         (linux_inferior_data): Move.  Change type.
9406         (invalidate_linux_cache_inf): Update.
9407         (linux_inferior_data_cleanup): Remove.
9408         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9409
9410 2019-05-08  Tom Tromey  <tom@tromey.com>
9411
9412         * auxv.c (auxv_inferior_data): Move.  Change type.
9413         (auxv_inferior_data_cleanup): Remove.
9414         (invalidate_auxv_cache_inf): Rewrite.
9415         (get_auxv_inferior_data, _initialize_auxv): Update.
9416
9417 2019-05-08  Tom Tromey  <tom@tromey.com>
9418
9419         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9420         (symfile_debug_objfile_data_key): Change type.
9421         (symfile_debug_installed, debug_qf_has_symbols)
9422         (debug_qf_find_last_source_symtab)
9423         (debug_qf_forget_cached_source_info)
9424         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9425         (debug_qf_print_stats, debug_qf_dump)
9426         (debug_qf_expand_symtabs_for_function)
9427         (debug_qf_expand_all_symtabs)
9428         (debug_qf_expand_symtabs_with_fullname)
9429         (debug_qf_map_matching_symbols)
9430         (debug_qf_expand_symtabs_matching)
9431         (debug_qf_find_pc_sect_compunit_symtab)
9432         (debug_qf_map_symbol_filenames)
9433         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9434         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9435         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9436         (debug_sym_read_linetable, debug_sym_relocate): Update.
9437         (symfile_debug_free_objfile): Remove.
9438         (install_symfile_debug_logging, _initialize_symfile_debug):
9439         Update.
9440
9441 2019-05-08  Tom Tromey  <tom@tromey.com>
9442
9443         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9444         allocate_on_obstack.
9445         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9446         (get_dwarf2_per_objfile): Update.
9447         (set_dwarf2_per_objfile): Remove.
9448         (dwarf2_has_info, dwarf2_get_section_info): Update.
9449         (dwarf2_free_objfile): Remove.
9450         (_initialize_dwarf2_read): Update.
9451
9452 2019-05-08  Tom Tromey  <tom@tromey.com>
9453
9454         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9455         initializers.
9456         <unsupported_script_warning_printed,
9457         script_not_found_warning_printed>: Now bool.
9458         (auto_load_pspace_data): Change type.
9459         (~auto_load_pspace_info): Rename from
9460         auto_load_pspace_data_cleanup.
9461         (get_auto_load_pspace_data, init_loaded_scripts_info)
9462         (clear_section_scripts, maybe_print_unsupported_script_warning)
9463         (maybe_print_script_not_found_warning, _initialize_auto_load):
9464         Update.
9465
9466 2019-05-08  Tom Tromey  <tom@tromey.com>
9467
9468         * objfiles.c (objfile_pspace_info): Add destructor and
9469         initializers.
9470         (objfiles_pspace_data): Change type.
9471         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9472         (get_objfile_pspace_data): Update.
9473         (objfiles_bfd_data): Change type.
9474         (get_objfile_bfd_data): Update.
9475         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9476
9477 2019-05-08  Tom Tromey  <tom@tromey.com>
9478
9479         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9480         Change type.
9481         (get_catch_syscall_inferior_data): Update.
9482         (catch_syscall_inferior_data_cleanup): Remove.
9483         (_initialize_break_catch_syscall): Update.
9484
9485 2019-05-08  Tom Tromey  <tom@tromey.com>
9486
9487         * inflow.c (struct terminal_info): Add destructor and
9488         initializers.
9489         (inflow_inferior_data): Change type.
9490         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9491         (get_inflow_inferior_data, inflow_inferior_exit)
9492         (swap_terminal_info, _initialize_inflow): Update.
9493
9494 2019-05-08  Tom Tromey  <tom@tromey.com>
9495
9496         * target-dcache.c (target_dcache_cleanup): Remove.
9497         (target_dcache_aspace_key): Change type.
9498         (target_dcache_init_p, target_dcache_invalidate)
9499         (target_dcache_get, target_dcache_get_or_init)
9500         (_initialize_target_dcache): Update.
9501         * dcache.h (struct dcache_deleter): New.
9502
9503 2019-05-08  Tom Tromey  <tom@tromey.com>
9504
9505         * symtab.c (struct symbol_cache): Add destructor and
9506         initializers.
9507         (symbol_cache_key): Move.  Change type.
9508         (make_symbol_cache, free_symbol_cache): Remove.
9509         (get_symbol_cache): Update.
9510         (symbol_cache_cleanup): Remove.
9511         (ALL_PSPACES, symbol_cache_flush)
9512         (maintenance_print_symbol_cache)
9513         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9514         Update.
9515
9516 2019-05-08  Tom Tromey  <tom@tromey.com>
9517
9518         * symtab.c (struct main_info): Add destructor and initializers.
9519         (main_progspace_key): Move.  Change type.
9520         (get_main_info): Update.
9521         (main_info_cleanup): Remove.
9522         (_initialize_symtab): Update.
9523
9524 2019-05-08  Tom Tromey  <tom@tromey.com>
9525
9526         * registry.h (DECLARE_REGISTRY): Define the _key class.
9527
9528 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9529
9530         * NEWS: Merge two 'New commands' sections.
9531
9532 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9533
9534         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9535         parameter and use Ada language definition instead.
9536         (ada_val_print_ptr): Remove unused language parameter.
9537         (ada_val_print_num): Remove language parameter and use Ada language
9538         definition instead.
9539         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9540         parameter.
9541         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9542         parameter and use Ada language definition instead.
9543         (ada_val_print_1): Update all ada_val_print_xxx calls.
9544         Remove language parameter.
9545         (ada_val_print): Update ada_val_print_1 call.
9546
9547 2019-05-08  Tom Tromey  <tromey@adacore.com>
9548
9549         * remote.c (remote_hw_watchpoint_limit)
9550         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9551         Now static.
9552
9553 2019-05-08  Tom Tromey  <tromey@adacore.com>
9554
9555         * maint.c (_initialize_maint_cmds): Move initialization code to
9556         remote.c.
9557         (watchdog, show_watchdog): Move to remote.c.
9558         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9559         "watchdog" static.
9560         (_initialize_remote): Move initialization code from maint.c.
9561         * defs.h (watchdog): Don't declare.
9562
9563 2019-05-08  Tom Tromey  <tromey@adacore.com>
9564
9565         * tui/tui-interp.c: Include main.h.
9566         * interps.c: Include main.h.
9567         * main.h (interpreter_p): Declare.
9568         * defs.h (interpreter_p): Don't declare.
9569
9570 2019-05-08  Tom Tromey  <tromey@adacore.com>
9571
9572         * dwarf2loc.c: Include dwarf2read.h.
9573         * defs.h (read_unsigned_leb128): Don't declare.
9574         * dwarf2read.h (read_unsigned_leb128): Declare.
9575
9576 2019-05-08  Tom Tromey  <tromey@adacore.com>
9577
9578         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9579         method.
9580
9581 2019-05-08  Tom Tromey  <tromey@adacore.com>
9582
9583         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9584         when no wrap column is set.
9585
9586 2019-05-08  Tom Tromey  <tromey@adacore.com>
9587
9588         * c-lang.c (c_get_string): Handle non-C-style arrays.
9589
9590 2019-05-08  Tom Tromey  <tromey@adacore.com>
9591
9592         * typeprint.c (print_offset_data::update): Print the bit offset,
9593         not the number of bits remaining.
9594
9595 2019-05-08  Tom Tromey  <tromey@adacore.com>
9596
9597         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9598         padding at end of comment.
9599
9600 2019-05-08  Tom Tromey  <tromey@adacore.com>
9601
9602         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9603         Compare main types.
9604
9605 2019-05-06  Tom Tromey  <tom@tromey.com>
9606
9607         * common/scoped_mmap.c: Include common-defs.h.
9608         * common/scoped_mmap.h: Don't include config.h.
9609
9610 2019-05-04  Tom Tromey  <tom@tromey.com>
9611
9612         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9613         (struct aarch64_call_info): Add initializers.
9614         <si>: Now a std::vector.
9615         (pass_on_stack, aarch64_push_dummy_call): Update.
9616
9617 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9618             Tom Tromey  <tom@tromey.com>
9619
9620         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9621         (ppc_threads): Now a std::vector.  Now static.
9622         (hwdebug_find_thread_points_by_tid)
9623         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9624         Update.
9625
9626 2019-05-04  Tom Tromey  <tom@tromey.com>
9627
9628         * arc-tdep.c (arc_tdesc_init): Return bool.
9629
9630 2019-05-04  Tom Tromey  <tom@tromey.com>
9631
9632         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9633         Use gdb_assert_not_reached.
9634
9635 2019-05-04  Tom Tromey  <tom@tromey.com>
9636
9637         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9638         "false".
9639
9640 2019-05-04  Tom Tromey  <tom@tromey.com>
9641
9642         * arc-tdep.c (arc_tdesc_init): Use bool.
9643
9644 2019-05-04  Tom Tromey  <tom@tromey.com>
9645
9646         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9647
9648 2019-05-04  Tom Tromey  <tom@tromey.com>
9649
9650         * cli/cli-cmds.c (valid_command_p): Return bool.
9651
9652 2019-05-04  Tom Tromey  <tom@tromey.com>
9653
9654         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9655         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9656
9657 2019-05-04  Raul Tambre  <raul@tambre.ee>
9658
9659         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9660         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9661         operator for comparison.
9662
9663 2019-05-04  Tom Tromey  <tom@tromey.com>
9664
9665         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9666         (lookup_partial_symbol, print_partial_symbols)
9667         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9668         (psymbol_compare): Update.
9669         (add_psymbol_to_bcache): Clear the entire psymbol.
9670         (maintenance_check_psymtabs): Update.
9671         * psympriv.h (struct partial_symbol): Don't derive from
9672         general_symbol_info.
9673         <obj_section, unrelocated_address, address,
9674         set_unrelocated_address>: Update.
9675         <ginfo>: New member.
9676         * dwarf-index-write.c (write_psymbols, debug_names::insert)
9677         (debug_names::write_psymbols): Update.
9678
9679 2019-05-04  Tom de Vries  <tdevries@suse.de>
9680
9681         * contrib/cc-with-tweaks.sh: Support -n arg.
9682
9683 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9684
9685         * corelow.c (core_target::detach): Ensure frame cache and
9686         register caches are cleared.
9687         inferior.c (exit_inferior_1): Likewise.
9688
9689 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
9690             Tom Tromey  <tom@tromey.com>
9691
9692         * dictionary.c (collate_pending_symbols_by_language): Remove
9693         "struct" from foreach.
9694         * symtab.c (lookup_global_symbol_from_objfile)
9695         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9696         foreach.
9697         * ser-tcp.c (net_open): Remove "struct" from foreach.
9698         * objfiles.c (objfile_relocate, objfile_rebase)
9699         (objfile_has_symbols): Remove "struct" from foreach.
9700         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9701         from foreach.
9702         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9703         foreach.
9704         * darwin-nat.c (thread_info_from_private_thread_info): Remove
9705         "struct" from foreach.
9706         * ada-lang.c (create_excep_cond_exprs)
9707         (ada_exception_catchpoint_cond_string): Remove "struct" from
9708         foreach.
9709
9710 2019-05-03  Tom Tromey  <tromey@adacore.com>
9711
9712         * ada-exp.y (convert_char_literal): Check suffix of each
9713         enumerator.
9714
9715 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
9716
9717         PR ada/21406:
9718         * ada-exp.y (yywrap): Don't define.
9719         * ada-lex.l (%option): Add noyywrap
9720         (yywrap): Remove.
9721
9722 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
9723
9724         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9725         _WIN32_WINNT to the XP level, unless already defined to a higher
9726         level.
9727
9728         * unittests/parse-connection-spec-selftests.c:
9729         * ser-tcp.c:
9730         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
9731         override.
9732
9733         * symfile.c (find_separate_debug_file): Remove colon from the
9734         drive spec of DOS/Windows file names of the target, so that the
9735         file name produced from DEBUGDIR and the target's directory will
9736         be valid on DOS/Windows systems.
9737
9738 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9739
9740         * rust-lang.c (val_print_struct): Handle printing structures
9741         containing strings.
9742
9743 2019-05-02  Tom Tromey  <tromey@adacore.com>
9744
9745         * valarith.c (_initialize_valarith): Remove.
9746
9747 2019-05-01  Tom Tromey  <tromey@adacore.com>
9748
9749         * ada-lang.c (ada_value_primitive_field): Treat more fields as
9750         bitfields.
9751
9752 2019-05-01  Tom Tromey  <tromey@adacore.com>
9753
9754         * ada-lang.c (ada_value_assign): Correctly compute starting offset
9755         for big-endian copies.
9756
9757 2019-04-30  Ali Tamur  <tamur@google.com>
9758         * gdb/dwarf2read.c (read_3_bytes): New declaration.
9759         (read_attribute_value): Added DW_FORM_strx1-4 cases.
9760         (read_3_bytes): New function.
9761
9762 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9763
9764         * windows-nat.c (main_thread_id): Delete.
9765         (handle_output_debug_string): Replace main_thread_id by
9766         current_event.dwThreadId.
9767         (fake_create_process): Likewise.
9768         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9769         Do not set main_thread_id.
9770         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9771         current_event.dwThreadId.
9772         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9773
9774 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9775
9776         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9777         Use current_event.dwThreadId instead of main_thread_id.
9778
9779 2019-04-30  Tom Tromey  <tromey@adacore.com>
9780
9781         * ada-lang.c (ada_lookup_simple_minsyms): New function.
9782         (create_excep_cond_exprs): Iterate over program spaces.
9783         (ada_exception_catchpoint_cond_string): Examine all minimal
9784         symbols for exception types.
9785
9786 2019-04-30  Tom Tromey  <tromey@adacore.com>
9787
9788         PR c++/24470:
9789         * dwarf2read.c (process_structure_scope): Handle case where type
9790         has template parameters but no symbol was created.
9791
9792 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9793             Chris January  <chris.january@arm.com>
9794
9795         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9796         qualifier.
9797         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9798
9799 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9800
9801         * f-typeprint.c (f_print_type): Update rules for printing
9802         whitespace.
9803         (f_type_print_varspec_suffix): Likewise.
9804
9805 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9806             Chris January  <chris.january@arm.com>
9807
9808         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9809         function arguments.
9810
9811 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9812
9813         * f-lang.c (build_fortran_types): Change name of void type to
9814         lower case.
9815         * f-typeprint.c (f_type_print_base): Print the name of the void
9816         type, rather than a fixed string.
9817         * f-valprint.c (f_decorations): Use lower case void string.
9818
9819 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9820             Chris January  <chris.january@arm.com>
9821
9822         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9823         types for Fortran.
9824
9825 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9826             Chris January  <chris.january@arm.com>
9827             David Lecomber  <david.lecomber@arm.com>
9828
9829         * f-exp.y (BINOP_INTRINSIC): New token.
9830         (exp): New parser rule handling BINOP_INTRINSIC.
9831         (f77_keywords): Add new builtin procedures.
9832         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9833         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9834         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9835         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9836         (print_unop_subexp_f): New function.
9837         (print_binop_subexp_f): New function.
9838         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9839         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9840         (dump_subexp_body_f): Likewise.
9841         (operator_check_f): Likewise.
9842         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9843         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9844
9845 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9846
9847         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9848         UNOP_KIND.
9849         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9850         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9851         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9852         (operator_length_f): New fuction.
9853         (print_subexp_f): New function.
9854         (op_name_f): New function.
9855         (dump_subexp_body_f): New function.
9856         (operator_check_f): New function.
9857         (exp_descriptor_f): Replace standard expression handling functions
9858         with new functions.
9859         * gdb/fortran-operator.def: New file.
9860         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9861         * gdb/std-operator.def: Remove UNOP_KIND.
9862
9863 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9864
9865         * std-operator.def: Remove unbalanced, stray double quote
9866         character.
9867
9868 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9869             Chris January  <chris.january@arm.com>
9870             Daniel Everett  <daniel.everett@arm.com>
9871             Nick Forrington  <nick.forrington@arm.com>
9872             Richard Bunt  <richard.bunt@arm.com>
9873
9874         * cp-valprint.c (cp_print_value_fields): Allow an additional level
9875         of depth when printing anonymous structs or unions.
9876         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9877         Don't print either the top-level value, or the children if the
9878         max-depth is exceeded.
9879         (ppscm_print_children): When printing the key of a map, allow one
9880         extra level of depth.
9881         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9882         print either the top-level value, or the children if the max-depth
9883         is exceeded.
9884         (print_children): When printing the key of a map, allow one extra
9885         level of depth.
9886         * python/py-value.c (valpy_format_string): Add max_depth keyword.
9887         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9888         (user_print_options): Initialise max_depth field.
9889         (val_print_scalar_or_string_type_p): New function.
9890         (val_print): Check to see if the max depth has been reached.
9891         (val_print_check_max_depth): Define new function.
9892         (show_print_max_depth): New function.
9893         (_initialize_valprint): Add 'print max-depth' option.
9894         * valprint.h (struct value_print_options) <max_depth>: New field.
9895         (val_print_check_max_depth): Declare new function.
9896         * NEWS: Document new feature.
9897
9898 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9899
9900         * ada-lang.c (ada_language_defn): Initialise new field.
9901         * c-lang.c (c_is_string_type_p): New function.
9902         (c_language_defn): Initialise new field.
9903         (cplus_language_defn): Initialise new field.
9904         (asm_language_defn): Initialise new field.
9905         (minimal_language_defn): Initialise new field.
9906         * c-lang.h (c_is_string_type_p): Declare new function.
9907         * d-lang.c (d_language_defn): Initialise new field.
9908         * f-lang.c (f_is_string_type_p): New function.
9909         (f_language_defn): Initialise new field.
9910         * go-lang.c (go_is_string_type_p): New function.
9911         (go_language_defn): Initialise new field.
9912         * language.c (default_is_string_type_p): New function.
9913         (unknown_language_defn): Initialise new field.
9914         (auto_language_defn): Initialise new field.
9915         * language.h (struct language_defn) <la_is_string_type_p>: New
9916         member variable.
9917         (default_is_string_type_p): Declare new function.
9918         * m2-lang.c (m2_language_defn): Initialise new field.
9919         * objc-lang.c (objc_language_defn): Initialise new field.
9920         * opencl-lang.c (opencl_language_defn): Initialise new field.
9921         * p-lang.c (pascal_is_string_type_p): New function.
9922         (pascal_language_defn): Initialise new field.
9923         * rust-lang.c (rust_is_string_type_p): New function.
9924         (rust_language_defn): Initialise new field.
9925
9926 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9927
9928         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
9929         New field.
9930         * ada-lang.c (ada_language_defn): Initialise new field.
9931         * c-lang.c (c_language_defn): Likewise.
9932         (cplus_language_defn): Likewise.
9933         (asm_language_defn): Likewise.
9934         (minimal_language_defn): Likewise.
9935         * d-lang.c (d_language_defn): Likewise.
9936         * f-lang.c (f_language_defn): Likewise.
9937         * go-lang.c (go_language_defn): Likewise.
9938         * language.c (unknown_language_defn): Likewise.
9939         (auto_language_defn): Likewise.
9940         * m2-lang.c (m2_language_defn): Likewise.
9941         * objc-lang.c (objc_language_defn): Likewise.
9942         * opencl-lang.c (opencl_language_defn): Likewise.
9943         * p-lang.c (pascal_language_defn): Likewise.
9944         * rust-lang.c (rust_language_defn): Likewise.
9945
9946 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9947
9948         * ada-lang.c (ada_is_character_type): Change return type to bool.
9949         (ada_is_string_type): Likewise.
9950         * ada-lang.h (ada_is_character_type): Update declaration
9951         (ada_is_string_type): Likewise.
9952
9953 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9954
9955         Support style in 'frame|thread apply'
9956
9957         * gdbcmd.h (execute_command_to_string): New term_out parameter.
9958         * record.c (record_start, record_stop): Update callers of
9959         execute_command_to_string with false.
9960         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9961         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
9962         methods.
9963         (class string_file): New constructor with term_out parameter.
9964         Override methods term_out and can_emit_style_escape.  New member
9965         term_out.
9966         (class stdio_file): Override can_emit_style_escape.
9967         (class tee_file): Override term_out and can_emit_style_escape.
9968         * utils.h (can_emit_style_escape): Remove.
9969         * utils.c (can_emit_style_escape): Likewise.
9970         Update all callers of can_emit_style_escape (SOMESTREAM) to
9971         SOMESTREAM->can_emit_style_escape.
9972         * source-cache.c (source_cache::get_source_lines): Likewise.
9973         * stack.c (frame_apply_command_count): Call execute_command_to_string
9974         passing the term_out characteristic of the current gdb_stdout.
9975         * thread.c (thr_try_catch_cmd): Likewise.
9976         * top.c (execute_command_to_string): pass term_out parameter
9977         to construct the string_file for the command output.
9978         * ui-file.c (term_cli_styling): New function (most code moved
9979         from utils.c can_emit_style_escape).
9980         (string_file::string_file, string_file::can_emit_style_escape,
9981         stdio_file::can_emit_style_escape, tee_file::term_out,
9982         tee_file::can_emit_style_escape): New functions.
9983
9984 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9985
9986         * NEWS: Mention the new set|show may-call-functions.
9987         * infcall.c (may_call_functions_p): New variable.
9988         (show_may_call_functions_p): New function.
9989         (call_function_by_hand_dummy): Throws an error if not
9990         may-call-functions.
9991         (_initialize_infcall): Call add_setshow_boolean_cmd for
9992         may-call-functions.
9993
9994 2019-04-25  Keith Seitz  <keiths@redhat.com>
9995
9996         PR c++/24367
9997         * cp-support.c (inspect_type): Don't attempt substitutions
9998         of symbol with the same name.
9999
10000 2019-04-25  Tom Tromey  <tromey@adacore.com>
10001
10002         PR gdb/24475:
10003         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10004         static.
10005
10006 2019-04-25  Tom Tromey  <tromey@adacore.com>
10007
10008         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10009         rvalue reference.
10010         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10011         (gdb_xml_parser::parse): Use std::move.
10012         * python/python-internal.h (gdbpy_convert_exception): Take a const
10013         reference.
10014         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10015         std::move.
10016         * python/py-utils.c (gdbpy_convert_exception): Take a const
10017         reference.
10018         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10019         Use std::move.
10020         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10021         Use std::move.
10022         * mi/mi-main.c (mi_print_exception): Take a const reference.
10023         * main.c (handle_command_errors): Take a const reference.
10024         * linespec.c (parse_linespec): Use std::move.
10025         * infcall.c (run_inferior_call): Use std::move.
10026         (call_function_by_hand_dummy): Use std::move.
10027         * exec.c (try_open_exec_file): Use std::move.
10028         * exceptions.h (exception_print, exception_fprintf)
10029         (exception_print_same): Update.
10030         * exceptions.c (print_exception, exception_print)
10031         (exception_fprintf, exception_print_same): Change parameters to
10032         const reference.
10033         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10034         * common/new-op.c: Use std::move.
10035         * common/common-exceptions.h (struct gdb_exception): Add move
10036         constructor.
10037         (struct gdb_exception_error, struct gdb_exception_quit, struct
10038         gdb_quit_bad_alloc): Change constructor to move constructor.
10039         (throw_exception): Change parameter to rvalue reference.
10040         * common/common-exceptions.c (throw_exception): Take rvalue
10041         reference.
10042         * cli/cli-interp.c (safe_execute_command): Use std::move.
10043         * breakpoint.c (insert_bp_location, location_to_sals): Use
10044         std::move.
10045
10046 2019-04-25  Tom Tromey  <tromey@adacore.com>
10047
10048         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10049         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10050         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10051         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10052         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10053         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10054         guile/scm-value.c: Use unpack.
10055         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10056         gdbscm_gdb_exception.
10057         (gdbscm_throw_gdb_exception): Likewise.
10058         (struct gdbscm_gdb_exception): New.
10059         (unpack): New function.
10060         (gdbscm_wrap): Use unpack.
10061
10062 2019-04-25  Tom Tromey  <tromey@adacore.com>
10063
10064         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10065         (gdb_rl_callback_handler): Use std::move.
10066         * common/common-exceptions.h (struct gdb_exception): Add move
10067         assignment operator.
10068         (throw_exception_sjlj): Change "exception" to const reference.
10069         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10070         (throw_exception_sjlj): Change "exception" to const reference.
10071
10072 2019-04-25  Tom Tromey  <tromey@adacore.com>
10073
10074         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10075         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10076         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10077         Update.
10078         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10079         Update.
10080         * mi/mi-interp.c (mi_interp::exec): Update.
10081         * linespec.c (parse_linespec): Update.
10082         * infcall.c (run_inferior_call): Update.
10083         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10084         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10085         (gdbscm_lookup_global_symbol): Update.
10086         * guile/scm-param.c (gdbscm_parameter_value): Update.
10087         * guile/scm-frame.c (gdbscm_frame_read_register)
10088         (gdbscm_frame_read_var): Update.
10089         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10090         * exec.c (try_open_exec_file): Update.
10091         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10092         (gdb_rl_callback_handler): Update.
10093         * common/common-exceptions.h (exception_none): Don't declare.
10094         * common/common-exceptions.c (exception_none): Don't define.
10095         (struct catcher) <exception>: Update.
10096         * cli/cli-interp.c (safe_execute_command): Update.
10097         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10098
10099 2019-04-25  Ali Tamur  <tamur@google.com>
10100
10101         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10102         (read_attribute_value): Likewise.
10103         (dwarf2_read_addr_index): Update comment.
10104         (read_str_index): Add DW_FORM_strx.
10105         (dwarf2_string_attr): Likewise.
10106         (dwarf2_const_value_attr): Likewise.
10107         (dump_die_shallow): Likewise.
10108         (dwarf2_fetch_constant_bytes): Likewise.
10109         (skip_form_bytes): Likewise.
10110         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10111
10112 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10113
10114         PR corefiles/11608
10115         PR corefiles/18187
10116         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10117         OFFSET.  Verify if current mapping contains an ELF header.
10118         (linux_find_memory_regions_full): Adjust call to
10119         dump_mapping_p.
10120
10121 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10122             Kang Li <kanglictf@gmail.com>
10123
10124         PR gdb/21600
10125
10126         * dwarf2-frame.c (read_initial_length): Be consistent about using
10127         unsigned representation of length.
10128         (decode_frame_entry_1): Likewise.  Check for wraparound of
10129         end pointer as well as buffer overflow.
10130
10131 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10132
10133         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10134         "vq".
10135
10136 2019-04-24  Tom Tromey  <tromey@adacore.com>
10137
10138         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10139
10140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10141
10142         * s12z-tdep.c (s12z_unwind_pc): Delete.
10143         (s12z_unwind_sp): Delete.
10144         (s12z_gdbarch_init): Don't register deleted functions with
10145         gdbarch.
10146
10147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10148
10149         * rl78-tdep.c (rl78_unwind_sp): Delete.
10150         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10151
10152 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10153
10154         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10155         (xstormy16_unwind_pc): Delete.
10156         (xstormy16_dummy_id): Delete.
10157         (xstormy16_gdbarch_init): Don't register deleted functions with
10158         gdbarch.
10159
10160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10161
10162         * vax-tdep.c (vax_unwind_pc): Delete.
10163         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10164
10165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10166
10167         * v850-tdep.c (v850_unwind_sp): Delete.
10168         (v850_unwind_pc): Delete.
10169         (v850_dummy_id): Delete.
10170         (v850_gdbarch_init): Don't register deleted functions with
10171         gdbarch.
10172
10173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10174
10175         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10176         (tilegx_unwind_pc): Delete.
10177         (tilegx_unwind_dummy_id): Delete.
10178         (tilegx_gdbarch_init): Don't register deleted functions with
10179         gdbarch.
10180
10181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10182
10183         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10184         (tic6x_dummy_id): Delete.
10185         (tic6x_gdbarch_init): Don't register deleted functions with
10186         gdbarch.
10187
10188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10189
10190         * sparc-tdep.c (sparc_unwind_pc): Delete.
10191         (sparc32_gdbarch_init): Don't register deleted function with
10192         gdbarch.
10193
10194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10195
10196         * sh-tdep.c (sh_unwind_sp): Delete.
10197         (sh_unwind_pc): Delete.
10198         (sh_dummy_id): Delete.
10199         (sh_gdbarch_init): Don't register deleted functions with
10200         gdbarch.
10201
10202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10203
10204         * score-tdep.c (score_unwind_sp): Delete.
10205         (score_unwind_pc): Delete.
10206         (score_dummy_id): Delete.
10207         (score_gdbarch_init): Don't register deleted functions with
10208         gdbarch.
10209
10210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10211
10212         * rx-tdep.c (rx_unwind_pc): Delete.
10213         (rx_unwind_sp): Delete.
10214         (rx_dummy_id): Delete.
10215         (rx_gdbarch_init): Don't register deleted functions with
10216         gdbarch.  Update comment.
10217
10218 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10219
10220         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10221         (rs6000_dummy_id): Delete.
10222         (rs6000_gdbarch_init): Don't register deleted functions with
10223         gdbarch.
10224
10225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10226
10227         * or1k-tdep.c (or1k_dummy_id): Delete.
10228         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10229
10230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10231
10232         * nios2-tdep.c (nios2_dummy_id): Delete.
10233         (nios2_unwind_sp): Delete.
10234         (nios2_gdbarch_init): Don't register deleted functions with
10235         gdbarch.
10236
10237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10238
10239         * nds32-tdep.c (nds32_dummy_id): Delete.
10240         (nds32_unwind_pc): Delete.
10241         (nds32_unwind_sp): Delete.
10242         (nds32_gdbarch_init): Don't register deleted functions with
10243         gdbarch.
10244
10245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10246
10247         * msp430-tdep.c (msp430_unwind_pc): Delete.
10248         (msp430_unwind_sp): Delete.
10249         (msp430_dummy_id): Delete.
10250         (msp430_gdbarch_init): Don't register deleted functions with
10251         gdbarch.
10252
10253 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10254
10255         * moxie-tdep.c (moxie_unwind_sp): Delete.
10256         (moxie_unwind_pc): Delete.
10257         (moxie_dummy_id): Delete.
10258         (moxie_gdbarch_init): Don't register deleted functions with
10259         gdbarch.
10260
10261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10262
10263         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10264         (mn10300_unwind_pc): Delete.
10265         (mn10300_unwind_sp): Delete.
10266         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10267         mn10300_unwind_sp.
10268         (mn10300_frame_unwind_init): Don't register deleted functions with
10269         gdbarch.
10270
10271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10272
10273         * mep-tdep.c (mep_unwind_pc): Delete.
10274         (mep_unwind_sp): Delete.
10275         (mep_dummy_id): Delete.
10276         (mep_gdbarch_init): Don't register deleted functions with
10277         gdbarch.
10278
10279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10280
10281         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10282         (m68hc11_unwind_sp): Delete.
10283         (m68hc11_gdbarch_init): Don't register deleted functions with
10284         gdbarch.
10285
10286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10287
10288         * m32r-tdep.c (m32r_unwind_sp): Delete.
10289         (m32r_unwind_pc): Delete.
10290         (m32r_dummy_id): Delete.
10291         (m32r_gdbarch_init): Don't register deleted functions with
10292         gdbarch.
10293
10294 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10295
10296         * m32c-tdep.c (m32c_unwind_pc): Delete.
10297         (m32c_unwind_sp): Delete.
10298         (m32c_dummy_id): Delete.
10299         (m32c_gdbarch_init): Don't register deleted functions with
10300         gdbarch.
10301
10302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10303
10304         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10305         (lm32_unwind_pc): Delete.
10306         (lm32_dummy_id): Delete.
10307         (lm32_gdbarch_init): Don't register deleted functions with
10308         gdbarch.
10309
10310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10311
10312         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10313         (iq2000_unwind_pc): Delete.
10314         (iq2000_dummy_id): Delete.
10315         (iq2000_gdbarch_init): Don't register deleted functions with
10316         gdbarch.
10317
10318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10319
10320         * nds32-tdep.c (nds32_type_align): Delete.
10321         (nds32_push_dummy_call): Use type_align instead.
10322
10323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10324
10325         * arm-tdep.c (arm_type_align): Only handle vector override case.
10326         (arm_push_dummy_call): Use type_align.
10327         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10328
10329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10330
10331         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10332         case.
10333         (pass_on_stack): Use type_align.
10334         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10335         function.
10336
10337 2019-04-23  Tom Tromey  <tromey@adacore.com>
10338
10339         * dwarf2read.c (line_header::file_name_at): Remove unused
10340         overload.
10341
10342 2019-04-23  Tom de Vries  <tdevries@suse.de>
10343
10344         PR gdb/24438
10345         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10346         invocation.
10347
10348
10349 2019-03-27  Ali Tamur  <tamur@google.com>
10350
10351         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10352         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10353         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10354         (dwarf_expr_context::get_addr_index): Likewise
10355         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10356         (symbol_needs_eval_context::get_addr_index): Likewise
10357         (disassemble_dwarf_expression): Add DW_OP_addrx
10358         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10359         (read_cutu_die_from_dwo): Update comment
10360         (skip_one_die): Add DW_FORM_addrx
10361         (read_attribute_value): Likewise
10362         (var_decode_location): Add DW_OP_addrx
10363         (dwarf2_const_value_attr): Add DW_FORM_addrx
10364         (dump_die_shallow): Likewise
10365         (dwarf2_fetch_constant_bytes): Likewise
10366         (decode_locdesc): Add DW_OP_addrx
10367         (skip_form_bytes): Add DW_FORM_addrx
10368
10369 2019-04-22  Ali Tamur  <tamur@google.com>
10370
10371         * MAINTAINERS (Write After Approval): Add self.
10372
10373 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10374
10375         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10376         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10377         (open_symbol_file_object): Likewise.
10378         (svr4_default_sos): Add info parameter.
10379         (svr4_read_so_list): Likewise.
10380         (svr4_current_sos_direct): Adjust functions calls to pass down
10381         info.
10382         (svr4_current_sos_1): Add info parameter.
10383         (svr4_current_sos): Call get_svr4_info, pass info down to
10384         svr4_current_sos_1.
10385         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10386         get_svr4_info.
10387         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10388         get_svr4_info.
10389         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10390         to get_svr4_info.
10391         (probes_table_remove_objfile_probes): Likewise.
10392         (register_solib_event_probe): Add info parameter.
10393         (solist_update_incremental): Pass info parameter down to
10394         svr4_read_so_list.
10395         (disable_probes_interface): Add info parameter.
10396         (svr4_handle_solib_event): Pass current_program_space to
10397         get_svr4_info.  Adjust disable_probes_interface cleanup.
10398         (svr4_create_probe_breakpoints): Add info parameter, pass it
10399         down to register_solib_event_probe.
10400         (svr4_create_solib_event_breakpoints): Add info parameter,
10401         pass it down to svr4_create_probe_breakpoints.
10402         (enable_break): Pass info down to
10403         svr4_create_solib_event_breakpoints.
10404         (svr4_solib_create_inferior_hook): Pass current_program_space to
10405         get_svr4_info.
10406         (svr4_clear_solib): Likewise.
10407
10408 2019-04-22  Pedro Alves  <palves@redhat.com>
10409
10410         * solib-svr4.c (svr4_free_objfile_observer): New.
10411         (probe_and_action::objfile): New field.
10412         (probes_table_htab_remove_objfile_probes)
10413         (probes_table_remove_objfile_probes): New functions.
10414         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10415         in the new probe_and_action.  Don't store the probe in 'lookup'.
10416         (svr4_create_probe_breakpoints): Pass objfile to
10417         register_solib_event_probe.
10418         (_initialize_svr4_solib): Register a free_objfile observer.
10419
10420 2019-04-19  Tom Tromey  <tom@tromey.com>
10421
10422         * common/queue.h: Remove.
10423
10424 2019-04-19  Tom Tromey  <tom@tromey.com>
10425
10426         * event-loop.c: Don't include "common/queue.h".
10427
10428 2019-04-19  Tom Tromey  <tom@tromey.com>
10429
10430         * remote.c (remote_target): Use delete.
10431         * remote-notif.h: Include <list>, not "common/queue.h".
10432         (notif_client_p): Remove typedef.
10433         (remote_notif_state): Add constructor, destructor, initializer.
10434         <notif_queue>: Now a std::list.
10435         (remote_notif_state_xfree): Don't declare.
10436         * remote-notif.c (remote_notif_process, handle_notification)
10437         (remote_notif_state_allocate): Update.
10438         (~remote_notif_state): Rename from remote_notif_state_xfree.
10439
10440 2019-04-19  Tom Tromey  <tom@tromey.com>
10441
10442         * symfile.c (reread_symbols): Update.
10443         * objfiles.c (objfile_register_static_link)
10444         (objfile_lookup_static_link): Update
10445         (~objfile) Don't delete static_links.
10446         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10447
10448 2019-04-19  Tom Tromey  <tom@tromey.com>
10449
10450         * type-stack.h (struct type_stack) <insert>: Constify string.
10451         * type-stack.c (type_stack::insert): Constify string.
10452         * gdbtypes.h (lookup_template_type): Update.
10453         (address_space_name_to_int): Update.
10454         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10455         const.
10456         (lookup_template_type): Make name const.
10457         * c-exp.y: Update rules.
10458         (lex_one_token, classify_name, classify_inner_name)
10459         (c_print_token): Update.
10460         * p-exp.y: Update rules.
10461         (yylex): Update.
10462         * f-exp.y: Update rules.
10463         (yylex): Update.
10464         * d-exp.y: Update rules.
10465         (lex_one_token, classify_name, classify_inner_name): Update.
10466         * parse.c (write_dollar_variable, copy_name): Return std::string.
10467         * parser-defs.h (copy_name): Change return type.
10468         * m2-exp.y: Update rules.
10469         (yylex): Update.
10470         * go-exp.y (lex_one_token): Update.
10471         Update rules.
10472         (classify_unsafe_function, classify_packaged_name)
10473         (classify_name, yylex): Update.
10474
10475 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10476
10477         * configure.ac: add --enable-source-highlight switch.
10478         * configure: Regenerate.
10479         * top.c (print_gdb_version): plumb --enable-source-highlight
10480         status to "show configuration".
10481
10482 2019-04-19  Tom Tromey  <tromey@adacore.com>
10483
10484         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10485         Check ADA_TYPE_P.
10486         (empty_record, ada_template_to_fixed_record_type_1)
10487         (template_to_static_fixed_type)
10488         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10489         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10490         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10491         macros.
10492
10493 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10494
10495         PR symtab/24423:
10496         * source.c (print_source_lines_base): Advance "iter" when a
10497         control character is seen.
10498
10499 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10500
10501         * inferior.h (struct infcall_suspend_state_deleter):
10502         Catch exception in destructor to avoid crash.
10503
10504 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10505
10506         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10507         close to the add_com "shell".
10508
10509 2019-04-18  Tom Tromey  <tromey@adacore.com>
10510
10511         * process-stratum-target.h (class process_stratum_target)
10512         <stratum>: Add "final".
10513
10514 2019-04-17  Tom Tromey  <tromey@adacore.com>
10515
10516         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10517         against nullptr before use.
10518
10519 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10520
10521         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10522
10523 2019-04-17  Jim Wilson  <jimw@sifive.com>
10524             Andrew Burgess  <andrew.burgess@embecosm.com>
10525
10526         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10527         code read might fail, assume 4-byte breakpoint in that case.
10528
10529 2019-04-15  Leszek Swirski  <leszeks@google.com>
10530
10531         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10532         rather than a hand-rolled POD check when checking for forced MEMORY
10533         classification.
10534
10535 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10536
10537         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10538         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10539         function.
10540         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10541         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10542         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10543         declaration.
10544
10545 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10546
10547         * aarch64-linux-nat.c
10548         (aarch64_linux_nat_target::thread_architecture): Add override.
10549         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10550         each VQ.
10551
10552 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10553
10554         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10555
10556 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10557
10558         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10559         target types of size 96-bits, add some additional comments, and
10560         check that the builtin type we found was the correct size.
10561
10562 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10563
10564         * utils.c (prompt_for_continue): Don't restore the styling at the
10565         end, as applied_style has the wrong value.  This fixes styling in
10566         long lists of file names that are interrupted by the "Continue?"
10567         prompt.
10568
10569 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10570
10571         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10572         * c-lang.c (c_language_defn): Likewise.
10573         (cplus_language_defn): Likewise.
10574         (asm_language_defn): Likewise.
10575         (minimal_language_defn): Likewise.
10576         * d-lang.c (d_language_defn): Likewise.
10577         * f-lang.c (f_language_defn): Likewise.
10578         * go-lang.c (go_language_defn): Likewise.
10579         * language.c (unknown_language_defn): Likewise.
10580         (auto_language_defn): Likewise.
10581         * language.h (struct language_defn): Remove la_magic field.
10582         (LANG_MAGIC): Delete.
10583         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10584         * objc-lang.c (objc_language_defn): Likewise.
10585         * opencl-lang.c (opencl_language_defn): Likewise.
10586         * p-lang.c (pascal_language_defn): Likewise.
10587         * rust-lang.c (rust_language_defn): Likewise.
10588
10589 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10590
10591         * riscv-tdep.c (riscv_type_align): New function.
10592         (riscv_type_alignment): Delete.
10593         (riscv_arg_location): Use 'type_align'.
10594         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10595
10596 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10597
10598         * gdbtypes.c (type_align): A struct with no non-static fields also
10599         has alignment of 1.
10600
10601 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10602
10603         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10604         component to 0.
10605         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10606         member.
10607         (riscv_struct_info::analyse): New implementation using new
10608         analyse_inner member function.
10609         (riscv_struct_info::field_offset): New member function.
10610         (riscv_struct_info::m_offsets): New member variable.
10611         (riscv_struct_info::analyse_inner): New private member function,
10612         takes the old implementation of riscv_struct_info::analyse but
10613         extended to track field offsets.
10614         (riscv_call_arg_struct): Update the struct folding special cases
10615         to handle cases where empty C++ structs, which are non-zero
10616         length, are found.
10617         (riscv_arg_location): Initialise the length of each location, a
10618         non-zero length now indicates the location is in use.
10619         (riscv_push_dummy_call): Allow for the first location having a
10620         non-zero offset when setting up arguments.
10621         (riscv_return_value): Likewise, but for return values.
10622
10623 2019-04-11  Tom Tromey  <tromey@adacore.com>
10624
10625         * utils.c (internal_vproblem): Make "msg" const.
10626
10627 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10628
10629         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10630         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10631         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10632         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10633
10634 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10635
10636         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10637         function.
10638         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10639         of amd64_collect_native_gregset.
10640         (amd64_linux_nat_target::store_registers): Likewise.
10641
10642 2019-04-10  Tom Tromey  <tom@tromey.com>
10643
10644         * symtab.c (lookup_global_symbol_from_objfile)
10645         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10646         * objfiles.h (class separate_debug_iterator): New.
10647         (class separate_debug_range): New.
10648         (struct objfile) <separate_debug_objfiles>: New method.
10649         (objfile_separate_debug_iterate): Don't declare.
10650         * objfiles.c (separate_debug_iterator::operator++): Rename from
10651         objfile_separate_debug_iterate.
10652         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10653         iterator.
10654         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10655         iterator.
10656
10657 2019-04-10  Tom Tromey  <tom@tromey.com>
10658
10659         * symfile.c (reread_symbols): Remove old comment.
10660         * objfiles.c (free_all_objfiles): Fix a typo.
10661
10662 2019-04-10  Tom Tromey  <tom@tromey.com>
10663
10664         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10665         * minsyms.c (lookup_minimal_symbol): Use foreach.
10666         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10667         (lookup_minimal_symbol_solib_trampoline): Likewise.
10668         * symfile.c (reread_symbols): Use foreach.
10669
10670 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10671             Tom Tromey  <tromey@adacore.com>
10672
10673         PR rust/24414:
10674         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10675         (rust_lex_int_test): Change "value" to be LONGEST.
10676         (rust_lex_tests): Add test for long integer literal.
10677
10678 2019-04-09  Tom Tromey  <tromey@adacore.com>
10679
10680         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10681         to bool.
10682         (extended_remote_target::attach): Update.
10683         (remote_target::remote_notice_new_inferior): Update.
10684         (remote_target::add_current_inferior_and_thread): Update.
10685         * inferior.c (exit_inferior_1): Use "false".
10686         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10687
10688 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
10689
10690         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10691         the "start" command.
10692
10693 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10694
10695         * python/py-inferior.c (infpy_thread_from_thread_handle):
10696         Adjust comments to reflect renaming of thread_from_thread_handle
10697         to thread_from_handle.  Adjust keywords.  Fix type error message.
10698         (inferior_object_methods): Add thread_from_handle.  Retain
10699         thread_from_thread_handle, but mark it as deprecated.
10700
10701 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10702
10703         * gdbthread.h (find_thread_by_handle): Revise declaration.
10704         * thread.c (find_thread_by_handle): Likewise.  Adjust
10705         implementation too.
10706         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10707         support for buffer objects as handles.
10708
10709 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10710
10711         * python/py-infthread.c (thpy_thread_handle): New function.
10712         (thread_object_methods): Register thpy_thread_handle.
10713
10714 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10715
10716         * gdbthread.h (thread_to_thread_handle): Declare.
10717         * thread.c (gdbtypes.h): Include.
10718         (thread_to_thread_handle): New function.
10719
10720         * target.h (struct target_ops): Add thread_info_to_thread_handle.
10721         (target_thread_info_to_thread_handle): Declare.
10722         * target.c (target_thread_info_to_thread_handle): New function.
10723         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10724         * target-delegates.c: Regenerate.
10725
10726         * linux-thread-db.c (class thread_db_target): Add method
10727         thread_info_to_thread_handle.
10728         (thread_db_target::thread_info_to_thread_handle): Define.
10729         * remote.c (class remote_target): Add new method
10730         thread_info_to_thread_handle.
10731         (remote_target::thread_info_to_thread_handle): Define.
10732
10733 2019-04-08  Pedro Alves  <palves@redhat.com>
10734
10735         * common/common-exceptions.c (throw_exception): Don't create
10736         named object to throw; throw directly.
10737         (throw_it): Likewise.  Don't initialize gdb_exception::message
10738         here, with new; pass FMT and AP to the ctor instead.
10739         * common/common-exceptions.h: Include <string>.
10740         (gdb_exception::gdb_exception(enum return_reason, enum errors,
10741         const char *, va_list)): New ctor.  Use std::make_shared.
10742         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10743         errors)): Delete.
10744         (gdb_exception_error::gdb_exception_error(enum errors, const char
10745         *, va_list)): New.
10746         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10747         Add assertion.
10748         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10749         errors)): Delete.
10750         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10751         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10752         Add assertion.
10753
10754 2019-04-08  Tom Tromey  <tom@tromey.com>
10755
10756         * valops.c (value_rtti_indirect_type): Replace throw_exception
10757         with throw.
10758         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10759         with throw.
10760         * thread.c (thr_try_catch_cmd): Replace throw_exception with
10761         throw.
10762         * target.c (target_translate_tls_address): Replace throw_exception
10763         with throw.
10764         * stack.c (frame_apply_command_count): Replace throw_exception
10765         with throw.
10766         * solib-spu.c (append_ocl_sos): Replace throw_exception with
10767         throw.
10768         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10769         with throw.
10770         * rs6000-tdep.c (rs6000_frame_cache)
10771         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10772         * remote.c: Replace throw_exception with throw.
10773         * record-full.c (record_full_message, record_full_wait_1)
10774         (record_full_restore): Replace throw_exception with throw.
10775         * record-btrace.c:
10776         (get_thread_current_frame_id, record_btrace_start_replaying)
10777         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10778         (cmd_record_btrace_start): Replace throw_exception with throw.
10779         * parse.c (parse_exp_in_context_1): Replace throw_exception with
10780         throw.
10781         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10782         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10783         * linespec.c:
10784         (find_linespec_symbols): Replace throw_exception with throw.
10785         * infrun.c (displaced_step_prepare, resume): Replace
10786         throw_exception with throw.
10787         * infcmd.c (post_create_inferior): Replace throw_exception with
10788         throw.
10789         * inf-loop.c (inferior_event_handler): Replace throw_exception
10790         with throw.
10791         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10792         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10793         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10794         (get_prev_frame_always, get_frame_pc_if_available)
10795         (get_frame_address_in_block_if_available, get_frame_language):
10796         Replace throw_exception with throw.
10797         * frame-unwind.c (frame_unwind_try_unwinder): Replace
10798         throw_exception with throw.
10799         * eval.c (fetch_subexp_value, evaluate_var_value)
10800         (evaluate_funcall, evaluate_subexp_standard): Replace
10801         throw_exception with throw.
10802         * dwarf2loc.c (call_site_find_chain)
10803         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10804         Replace throw_exception with throw.
10805         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10806         with throw.
10807         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10808         throw.
10809         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10810         * completer.c (complete_line_internal): Replace throw_exception
10811         with throw.
10812         * compile/compile-object-run.c (compile_object_run): Replace
10813         throw_exception with throw.
10814         * cli/cli-script.c (process_next_line): Replace throw_exception
10815         with throw.
10816         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10817         (btrace_enable, btrace_maint_update_pt_packets): Replace
10818         throw_exception with throw.
10819         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10820         throw_exception with throw.
10821         * break-catch-throw.c (re_set_exception_catchpoint): Replace
10822         throw_exception with throw.
10823         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10824         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10825         * aarch64-tdep.c (aarch64_make_prologue_cache)
10826         (aarch64_make_stub_cache): Replace throw_exception with throw.
10827
10828 2019-04-08  Tom Tromey  <tom@tromey.com>
10829
10830         * common/common-exceptions.c (throw_exception): Rename from
10831         throw_exception_cxx.  Remove old copy.  Make argument const.
10832         (throw_it): Create and throw exception objects directly.
10833         * common/common-exceptions.h (throw_exception): Make argument
10834         const.
10835         (struct gdb_exception_error): Add constructor.
10836         (struct gdb_exception_quit): Add constructor.
10837
10838 2019-04-08  Tom Tromey  <tom@tromey.com>
10839
10840         * common/common-exceptions.h (exception_rethrow): Don't declare.
10841         (TRY_SJLJ): Update comment.
10842         (TRY, CATCH, END_CATCH): Remove.
10843         * common/common-exceptions.c (exception_rethrow): Remove.
10844
10845 2019-04-08  Tom Tromey  <tom@tromey.com>
10846
10847         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10848         Remove.
10849         (gdb_exception_error): Rename from
10850         gdb_exception_RETURN_MASK_ERROR.
10851         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10852         (gdb_quit_bad_alloc): Update.
10853         * aarch64-tdep.c: Update.
10854         * ada-lang.c: Update.
10855         * ada-typeprint.c: Update.
10856         * ada-valprint.c: Update.
10857         * amd64-tdep.c: Update.
10858         * arch-utils.c: Update.
10859         * break-catch-throw.c: Update.
10860         * breakpoint.c: Update.
10861         * btrace.c: Update.
10862         * c-varobj.c: Update.
10863         * cli/cli-cmds.c: Update.
10864         * cli/cli-interp.c: Update.
10865         * cli/cli-script.c: Update.
10866         * common/common-exceptions.c: Update.
10867         * common/new-op.c: Update.
10868         * common/selftest.c: Update.
10869         * compile/compile-c-symbols.c: Update.
10870         * compile/compile-cplus-symbols.c: Update.
10871         * compile/compile-object-load.c: Update.
10872         * compile/compile-object-run.c: Update.
10873         * completer.c: Update.
10874         * corelow.c: Update.
10875         * cp-abi.c: Update.
10876         * cp-support.c: Update.
10877         * cp-valprint.c: Update.
10878         * darwin-nat.c: Update.
10879         * disasm-selftests.c: Update.
10880         * dtrace-probe.c: Update.
10881         * dwarf-index-cache.c: Update.
10882         * dwarf-index-write.c: Update.
10883         * dwarf2-frame-tailcall.c: Update.
10884         * dwarf2-frame.c: Update.
10885         * dwarf2loc.c: Update.
10886         * dwarf2read.c: Update.
10887         * eval.c: Update.
10888         * event-loop.c: Update.
10889         * event-top.c: Update.
10890         * exec.c: Update.
10891         * f-valprint.c: Update.
10892         * fbsd-tdep.c: Update.
10893         * frame-unwind.c: Update.
10894         * frame.c: Update.
10895         * gdbtypes.c: Update.
10896         * gnu-v3-abi.c: Update.
10897         * guile/guile-internal.h: Update.
10898         * guile/scm-block.c: Update.
10899         * guile/scm-breakpoint.c: Update.
10900         * guile/scm-cmd.c: Update.
10901         * guile/scm-disasm.c: Update.
10902         * guile/scm-frame.c: Update.
10903         * guile/scm-lazy-string.c: Update.
10904         * guile/scm-math.c: Update.
10905         * guile/scm-param.c: Update.
10906         * guile/scm-ports.c: Update.
10907         * guile/scm-pretty-print.c: Update.
10908         * guile/scm-symbol.c: Update.
10909         * guile/scm-symtab.c: Update.
10910         * guile/scm-type.c: Update.
10911         * guile/scm-value.c: Update.
10912         * i386-linux-tdep.c: Update.
10913         * i386-tdep.c: Update.
10914         * inf-loop.c: Update.
10915         * infcall.c: Update.
10916         * infcmd.c: Update.
10917         * infrun.c: Update.
10918         * jit.c: Update.
10919         * language.c: Update.
10920         * linespec.c: Update.
10921         * linux-fork.c: Update.
10922         * linux-nat.c: Update.
10923         * linux-tdep.c: Update.
10924         * linux-thread-db.c: Update.
10925         * main.c: Update.
10926         * mi/mi-cmd-break.c: Update.
10927         * mi/mi-cmd-stack.c: Update.
10928         * mi/mi-interp.c: Update.
10929         * mi/mi-main.c: Update.
10930         * objc-lang.c: Update.
10931         * p-valprint.c: Update.
10932         * parse.c: Update.
10933         * ppc-linux-tdep.c: Update.
10934         * printcmd.c: Update.
10935         * python/py-arch.c: Update.
10936         * python/py-breakpoint.c: Update.
10937         * python/py-cmd.c: Update.
10938         * python/py-finishbreakpoint.c: Update.
10939         * python/py-frame.c: Update.
10940         * python/py-framefilter.c: Update.
10941         * python/py-gdb-readline.c: Update.
10942         * python/py-inferior.c: Update.
10943         * python/py-infthread.c: Update.
10944         * python/py-lazy-string.c: Update.
10945         * python/py-linetable.c: Update.
10946         * python/py-objfile.c: Update.
10947         * python/py-param.c: Update.
10948         * python/py-prettyprint.c: Update.
10949         * python/py-progspace.c: Update.
10950         * python/py-record-btrace.c: Update.
10951         * python/py-record.c: Update.
10952         * python/py-symbol.c: Update.
10953         * python/py-type.c: Update.
10954         * python/py-unwind.c: Update.
10955         * python/py-utils.c: Update.
10956         * python/py-value.c: Update.
10957         * python/python.c: Update.
10958         * record-btrace.c: Update.
10959         * record-full.c: Update.
10960         * remote-fileio.c: Update.
10961         * remote.c: Update.
10962         * riscv-tdep.c: Update.
10963         * rs6000-aix-tdep.c: Update.
10964         * rs6000-tdep.c: Update.
10965         * rust-exp.y: Update.
10966         * rust-lang.c: Update.
10967         * s390-tdep.c: Update.
10968         * selftest-arch.c: Update.
10969         * solib-dsbt.c: Update.
10970         * solib-frv.c: Update.
10971         * solib-spu.c: Update.
10972         * solib-svr4.c: Update.
10973         * solib.c: Update.
10974         * sparc64-linux-tdep.c: Update.
10975         * stack.c: Update.
10976         * symfile-mem.c: Update.
10977         * symmisc.c: Update.
10978         * target.c: Update.
10979         * thread.c: Update.
10980         * top.c: Update.
10981         * tracefile-tfile.c: Update.
10982         * tui/tui.c: Update.
10983         * typeprint.c: Update.
10984         * unittests/cli-utils-selftests.c: Update.
10985         * unittests/parse-connection-spec-selftests.c: Update.
10986         * valops.c: Update.
10987         * valprint.c: Update.
10988         * value.c: Update.
10989         * varobj.c: Update.
10990         * windows-nat.c: Update.
10991         * x86-linux-nat.c: Update.
10992         * xml-support.c: Update.
10993
10994 2019-04-08  Tom Tromey  <tom@tromey.com>
10995
10996         * xml-support.c: Use C++ exception handling.
10997         * x86-linux-nat.c: Use C++ exception handling.
10998         * windows-nat.c: Use C++ exception handling.
10999         * varobj.c: Use C++ exception handling.
11000         * value.c: Use C++ exception handling.
11001         * valprint.c: Use C++ exception handling.
11002         * valops.c: Use C++ exception handling.
11003         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11004         handling.
11005         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11006         * typeprint.c: Use C++ exception handling.
11007         * tui/tui.c: Use C++ exception handling.
11008         * tracefile-tfile.c: Use C++ exception handling.
11009         * top.c: Use C++ exception handling.
11010         * thread.c: Use C++ exception handling.
11011         * target.c: Use C++ exception handling.
11012         * symmisc.c: Use C++ exception handling.
11013         * symfile-mem.c: Use C++ exception handling.
11014         * stack.c: Use C++ exception handling.
11015         * sparc64-linux-tdep.c: Use C++ exception handling.
11016         * solib.c: Use C++ exception handling.
11017         * solib-svr4.c: Use C++ exception handling.
11018         * solib-spu.c: Use C++ exception handling.
11019         * solib-frv.c: Use C++ exception handling.
11020         * solib-dsbt.c: Use C++ exception handling.
11021         * selftest-arch.c: Use C++ exception handling.
11022         * s390-tdep.c: Use C++ exception handling.
11023         * rust-lang.c: Use C++ exception handling.
11024         * rust-exp.y: Use C++ exception handling.
11025         * rs6000-tdep.c: Use C++ exception handling.
11026         * rs6000-aix-tdep.c: Use C++ exception handling.
11027         * riscv-tdep.c: Use C++ exception handling.
11028         * remote.c: Use C++ exception handling.
11029         * remote-fileio.c: Use C++ exception handling.
11030         * record-full.c: Use C++ exception handling.
11031         * record-btrace.c: Use C++ exception handling.
11032         * python/python.c: Use C++ exception handling.
11033         * python/py-value.c: Use C++ exception handling.
11034         * python/py-utils.c: Use C++ exception handling.
11035         * python/py-unwind.c: Use C++ exception handling.
11036         * python/py-type.c: Use C++ exception handling.
11037         * python/py-symbol.c: Use C++ exception handling.
11038         * python/py-record.c: Use C++ exception handling.
11039         * python/py-record-btrace.c: Use C++ exception handling.
11040         * python/py-progspace.c: Use C++ exception handling.
11041         * python/py-prettyprint.c: Use C++ exception handling.
11042         * python/py-param.c: Use C++ exception handling.
11043         * python/py-objfile.c: Use C++ exception handling.
11044         * python/py-linetable.c: Use C++ exception handling.
11045         * python/py-lazy-string.c: Use C++ exception handling.
11046         * python/py-infthread.c: Use C++ exception handling.
11047         * python/py-inferior.c: Use C++ exception handling.
11048         * python/py-gdb-readline.c: Use C++ exception handling.
11049         * python/py-framefilter.c: Use C++ exception handling.
11050         * python/py-frame.c: Use C++ exception handling.
11051         * python/py-finishbreakpoint.c: Use C++ exception handling.
11052         * python/py-cmd.c: Use C++ exception handling.
11053         * python/py-breakpoint.c: Use C++ exception handling.
11054         * python/py-arch.c: Use C++ exception handling.
11055         * printcmd.c: Use C++ exception handling.
11056         * ppc-linux-tdep.c: Use C++ exception handling.
11057         * parse.c: Use C++ exception handling.
11058         * p-valprint.c: Use C++ exception handling.
11059         * objc-lang.c: Use C++ exception handling.
11060         * mi/mi-main.c: Use C++ exception handling.
11061         * mi/mi-interp.c: Use C++ exception handling.
11062         * mi/mi-cmd-stack.c: Use C++ exception handling.
11063         * mi/mi-cmd-break.c: Use C++ exception handling.
11064         * main.c: Use C++ exception handling.
11065         * linux-thread-db.c: Use C++ exception handling.
11066         * linux-tdep.c: Use C++ exception handling.
11067         * linux-nat.c: Use C++ exception handling.
11068         * linux-fork.c: Use C++ exception handling.
11069         * linespec.c: Use C++ exception handling.
11070         * language.c: Use C++ exception handling.
11071         * jit.c: Use C++ exception handling.
11072         * infrun.c: Use C++ exception handling.
11073         * infcmd.c: Use C++ exception handling.
11074         * infcall.c: Use C++ exception handling.
11075         * inf-loop.c: Use C++ exception handling.
11076         * i386-tdep.c: Use C++ exception handling.
11077         * i386-linux-tdep.c: Use C++ exception handling.
11078         * guile/scm-value.c: Use C++ exception handling.
11079         * guile/scm-type.c: Use C++ exception handling.
11080         * guile/scm-symtab.c: Use C++ exception handling.
11081         * guile/scm-symbol.c: Use C++ exception handling.
11082         * guile/scm-pretty-print.c: Use C++ exception handling.
11083         * guile/scm-ports.c: Use C++ exception handling.
11084         * guile/scm-param.c: Use C++ exception handling.
11085         * guile/scm-math.c: Use C++ exception handling.
11086         * guile/scm-lazy-string.c: Use C++ exception handling.
11087         * guile/scm-frame.c: Use C++ exception handling.
11088         * guile/scm-disasm.c: Use C++ exception handling.
11089         * guile/scm-cmd.c: Use C++ exception handling.
11090         * guile/scm-breakpoint.c: Use C++ exception handling.
11091         * guile/scm-block.c: Use C++ exception handling.
11092         * guile/guile-internal.h: Use C++ exception handling.
11093         * gnu-v3-abi.c: Use C++ exception handling.
11094         * gdbtypes.c: Use C++ exception handling.
11095         * frame.c: Use C++ exception handling.
11096         * frame-unwind.c: Use C++ exception handling.
11097         * fbsd-tdep.c: Use C++ exception handling.
11098         * f-valprint.c: Use C++ exception handling.
11099         * exec.c: Use C++ exception handling.
11100         * event-top.c: Use C++ exception handling.
11101         * event-loop.c: Use C++ exception handling.
11102         * eval.c: Use C++ exception handling.
11103         * dwarf2read.c: Use C++ exception handling.
11104         * dwarf2loc.c: Use C++ exception handling.
11105         * dwarf2-frame.c: Use C++ exception handling.
11106         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11107         * dwarf-index-write.c: Use C++ exception handling.
11108         * dwarf-index-cache.c: Use C++ exception handling.
11109         * dtrace-probe.c: Use C++ exception handling.
11110         * disasm-selftests.c: Use C++ exception handling.
11111         * darwin-nat.c: Use C++ exception handling.
11112         * cp-valprint.c: Use C++ exception handling.
11113         * cp-support.c: Use C++ exception handling.
11114         * cp-abi.c: Use C++ exception handling.
11115         * corelow.c: Use C++ exception handling.
11116         * completer.c: Use C++ exception handling.
11117         * compile/compile-object-run.c: Use C++ exception handling.
11118         * compile/compile-object-load.c: Use C++ exception handling.
11119         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11120         * compile/compile-c-symbols.c: Use C++ exception handling.
11121         * common/selftest.c: Use C++ exception handling.
11122         * common/new-op.c: Use C++ exception handling.
11123         * cli/cli-script.c: Use C++ exception handling.
11124         * cli/cli-interp.c: Use C++ exception handling.
11125         * cli/cli-cmds.c: Use C++ exception handling.
11126         * c-varobj.c: Use C++ exception handling.
11127         * btrace.c: Use C++ exception handling.
11128         * breakpoint.c: Use C++ exception handling.
11129         * break-catch-throw.c: Use C++ exception handling.
11130         * arch-utils.c: Use C++ exception handling.
11131         * amd64-tdep.c: Use C++ exception handling.
11132         * ada-valprint.c: Use C++ exception handling.
11133         * ada-typeprint.c: Use C++ exception handling.
11134         * ada-lang.c: Use C++ exception handling.
11135         * aarch64-tdep.c: Use C++ exception handling.
11136
11137 2019-04-08  Tom Tromey  <tom@tromey.com>
11138
11139         * xml-support.c (gdb_xml_parser::parse): Update.
11140         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11141         * value.c (show_convenience): Update.
11142         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11143         (test_parse_flags_qcs): Update.
11144         * thread.c (thr_try_catch_cmd): Update.
11145         * target.c (target_translate_tls_address): Update.
11146         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11147         (info_frame_command_core, frame_apply_command_count): Update.
11148         * rust-exp.y (rust_lex_exception_test): Update.
11149         * riscv-tdep.c (riscv_print_one_register_info): Update.
11150         * remote.c (remote_target::enable_btrace): Update.
11151         * record-btrace.c (record_btrace_enable_warn): Update.
11152         * python/py-utils.c (gdbpy_convert_exception): Update.
11153         * printcmd.c (do_one_display, print_variable_and_value): Update.
11154         * mi/mi-main.c (mi_print_exception): Update.
11155         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11156         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11157         * linux-nat.c (linux_nat_target::attach): Update.
11158         * linux-fork.c (class scoped_switch_fork_info): Update.
11159         * infrun.c (displaced_step_prepare): Update.
11160         * infcall.c (call_function_by_hand_dummy): Update.
11161         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11162         * gnu-v3-abi.c (print_one_vtable): Update.
11163         * frame.c (get_prev_frame_always): Update.
11164         * f-valprint.c (info_common_command_for_block): Update.
11165         * exec.c (try_open_exec_file): Update.
11166         * exceptions.c (print_exception, exception_print)
11167         (exception_fprintf, exception_print_same): Update.
11168         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11169         * dwarf-index-cache.c (index_cache::store)
11170         (index_cache::lookup_gdb_index): Update.
11171         * darwin-nat.c (maybe_cache_shell): Update.
11172         * cp-valprint.c (cp_print_value_fields): Update.
11173         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11174         (gcc_cplus_symbol_address): Update.
11175         * compile/compile-c-symbols.c (gcc_convert_symbol)
11176         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11177         * common/selftest.c: Update.
11178         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11179         a std::string.
11180         (exception_try_scope_entry, exception_try_scope_exit): Don't
11181         declare.
11182         (struct exception_try_scope): Remove.
11183         (TRY): Don't use exception_try_scope.
11184         (struct gdb_exception): Add constructor, operator=.
11185         <what>: New method.
11186         (struct gdb_exception_RETURN_MASK_ALL)
11187         (struct gdb_exception_RETURN_MASK_ERROR)
11188         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11189         (struct gdb_quit_bad_alloc): Update.
11190         * common/common-exceptions.c (exception_none): Change
11191         initializer.
11192         (struct catcher) <state, exception>: Initialize inline.
11193         <prev>: Remove member.
11194         (current_catcher): Remove.
11195         (catchers): New global.
11196         (exceptions_state_mc_init): Simplify.
11197         (catcher_pop): Remove.
11198         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11199         (try_scope_depth, exception_try_scope_entry)
11200         (exception_try_scope_exit): Remove.
11201         (throw_exception_sjlj): Update.
11202         (exception_messages, exception_messages_size): Remove.
11203         (throw_it): Simplify.
11204         (gdb_exception_sliced_copy): Remove.
11205         (throw_exception_cxx): Update.
11206         * cli/cli-script.c (script_from_file): Update.
11207         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11208         Update.
11209         * ada-valprint.c (ada_val_print): Update.
11210         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11211         (create_excep_cond_exprs): Update.
11212
11213 2019-04-08  Tom Tromey  <tom@tromey.com>
11214
11215         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11216         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11217         (TRY, CATCH, END_CATCH): Remove some definitions.
11218         * common/common-exceptions.c: Don't use GDB_XCPT.
11219         (catcher_list_size): Remove.
11220         (throw_exception, throw_it): Simplify.
11221
11222 2019-04-05  Tom Tromey  <tom@tromey.com>
11223
11224         Revert the header-sorting patch.
11225         * ft32-tdep.c: Revert.
11226         * frv-tdep.c: Revert.
11227         * frv-linux-tdep.c: Revert.
11228         * frame.c: Revert.
11229         * frame-unwind.c: Revert.
11230         * frame-base.c: Revert.
11231         * fork-child.c: Revert.
11232         * findvar.c: Revert.
11233         * findcmd.c: Revert.
11234         * filesystem.c: Revert.
11235         * filename-seen-cache.h: Revert.
11236         * filename-seen-cache.c: Revert.
11237         * fbsd-tdep.c: Revert.
11238         * fbsd-nat.h: Revert.
11239         * fbsd-nat.c: Revert.
11240         * f-valprint.c: Revert.
11241         * f-typeprint.c: Revert.
11242         * f-lang.c: Revert.
11243         * extension.h: Revert.
11244         * extension.c: Revert.
11245         * extension-priv.h: Revert.
11246         * expprint.c: Revert.
11247         * exec.h: Revert.
11248         * exec.c: Revert.
11249         * exceptions.c: Revert.
11250         * event-top.c: Revert.
11251         * event-loop.c: Revert.
11252         * eval.c: Revert.
11253         * elfread.c: Revert.
11254         * dwarf2read.h: Revert.
11255         * dwarf2read.c: Revert.
11256         * dwarf2loc.c: Revert.
11257         * dwarf2expr.h: Revert.
11258         * dwarf2expr.c: Revert.
11259         * dwarf2-frame.c: Revert.
11260         * dwarf2-frame-tailcall.c: Revert.
11261         * dwarf-index-write.h: Revert.
11262         * dwarf-index-write.c: Revert.
11263         * dwarf-index-common.c: Revert.
11264         * dwarf-index-cache.h: Revert.
11265         * dwarf-index-cache.c: Revert.
11266         * dummy-frame.c: Revert.
11267         * dtrace-probe.c: Revert.
11268         * disasm.h: Revert.
11269         * disasm.c: Revert.
11270         * disasm-selftests.c: Revert.
11271         * dictionary.c: Revert.
11272         * dicos-tdep.c: Revert.
11273         * demangle.c: Revert.
11274         * dcache.h: Revert.
11275         * dcache.c: Revert.
11276         * darwin-nat.h: Revert.
11277         * darwin-nat.c: Revert.
11278         * darwin-nat-info.c: Revert.
11279         * d-valprint.c: Revert.
11280         * d-namespace.c: Revert.
11281         * d-lang.c: Revert.
11282         * ctf.c: Revert.
11283         * csky-tdep.c: Revert.
11284         * csky-linux-tdep.c: Revert.
11285         * cris-tdep.c: Revert.
11286         * cris-linux-tdep.c: Revert.
11287         * cp-valprint.c: Revert.
11288         * cp-support.c: Revert.
11289         * cp-namespace.c: Revert.
11290         * cp-abi.c: Revert.
11291         * corelow.c: Revert.
11292         * corefile.c: Revert.
11293         * continuations.c: Revert.
11294         * completer.h: Revert.
11295         * completer.c: Revert.
11296         * complaints.c: Revert.
11297         * coffread.c: Revert.
11298         * coff-pe-read.c: Revert.
11299         * cli-out.h: Revert.
11300         * cli-out.c: Revert.
11301         * charset.c: Revert.
11302         * c-varobj.c: Revert.
11303         * c-valprint.c: Revert.
11304         * c-typeprint.c: Revert.
11305         * c-lang.c: Revert.
11306         * buildsym.c: Revert.
11307         * buildsym-legacy.c: Revert.
11308         * build-id.h: Revert.
11309         * build-id.c: Revert.
11310         * btrace.c: Revert.
11311         * bsd-uthread.c: Revert.
11312         * breakpoint.h: Revert.
11313         * breakpoint.c: Revert.
11314         * break-catch-throw.c: Revert.
11315         * break-catch-syscall.c: Revert.
11316         * break-catch-sig.c: Revert.
11317         * blockframe.c: Revert.
11318         * block.c: Revert.
11319         * bfin-tdep.c: Revert.
11320         * bfin-linux-tdep.c: Revert.
11321         * bfd-target.c: Revert.
11322         * bcache.c: Revert.
11323         * ax-general.c: Revert.
11324         * ax-gdb.h: Revert.
11325         * ax-gdb.c: Revert.
11326         * avr-tdep.c: Revert.
11327         * auxv.c: Revert.
11328         * auto-load.c: Revert.
11329         * arm-wince-tdep.c: Revert.
11330         * arm-tdep.c: Revert.
11331         * arm-symbian-tdep.c: Revert.
11332         * arm-pikeos-tdep.c: Revert.
11333         * arm-obsd-tdep.c: Revert.
11334         * arm-nbsd-tdep.c: Revert.
11335         * arm-nbsd-nat.c: Revert.
11336         * arm-linux-tdep.c: Revert.
11337         * arm-linux-nat.c: Revert.
11338         * arm-fbsd-tdep.c: Revert.
11339         * arm-fbsd-nat.c: Revert.
11340         * arm-bsd-tdep.c: Revert.
11341         * arch-utils.c: Revert.
11342         * arc-tdep.c: Revert.
11343         * arc-newlib-tdep.c: Revert.
11344         * annotate.h: Revert.
11345         * annotate.c: Revert.
11346         * amd64-windows-tdep.c: Revert.
11347         * amd64-windows-nat.c: Revert.
11348         * amd64-tdep.c: Revert.
11349         * amd64-sol2-tdep.c: Revert.
11350         * amd64-obsd-tdep.c: Revert.
11351         * amd64-obsd-nat.c: Revert.
11352         * amd64-nbsd-tdep.c: Revert.
11353         * amd64-nbsd-nat.c: Revert.
11354         * amd64-nat.c: Revert.
11355         * amd64-linux-tdep.c: Revert.
11356         * amd64-linux-nat.c: Revert.
11357         * amd64-fbsd-tdep.c: Revert.
11358         * amd64-fbsd-nat.c: Revert.
11359         * amd64-dicos-tdep.c: Revert.
11360         * amd64-darwin-tdep.c: Revert.
11361         * amd64-bsd-nat.c: Revert.
11362         * alpha-tdep.c: Revert.
11363         * alpha-obsd-tdep.c: Revert.
11364         * alpha-nbsd-tdep.c: Revert.
11365         * alpha-mdebug-tdep.c: Revert.
11366         * alpha-linux-tdep.c: Revert.
11367         * alpha-linux-nat.c: Revert.
11368         * alpha-bsd-tdep.c: Revert.
11369         * alpha-bsd-nat.c: Revert.
11370         * aix-thread.c: Revert.
11371         * agent.c: Revert.
11372         * addrmap.c: Revert.
11373         * ada-varobj.c: Revert.
11374         * ada-valprint.c: Revert.
11375         * ada-typeprint.c: Revert.
11376         * ada-tasks.c: Revert.
11377         * ada-lang.c: Revert.
11378         * aarch64-tdep.c: Revert.
11379         * aarch64-ravenscar-thread.c: Revert.
11380         * aarch64-newlib-tdep.c: Revert.
11381         * aarch64-linux-tdep.c: Revert.
11382         * aarch64-linux-nat.c: Revert.
11383         * aarch64-fbsd-tdep.c: Revert.
11384         * aarch64-fbsd-nat.c: Revert.
11385         * aarch32-linux-nat.c: Revert.
11386
11387 2019-04-05  Tom Tromey  <tom@tromey.com>
11388
11389         * ft32-tdep.c: Sort headers.
11390         * frv-tdep.c: Sort headers.
11391         * frv-linux-tdep.c: Sort headers.
11392         * frame.c: Sort headers.
11393         * frame-unwind.c: Sort headers.
11394         * frame-base.c: Sort headers.
11395         * fork-child.c: Sort headers.
11396         * findvar.c: Sort headers.
11397         * findcmd.c: Sort headers.
11398         * filesystem.c: Sort headers.
11399         * filename-seen-cache.h: Sort headers.
11400         * filename-seen-cache.c: Sort headers.
11401         * fbsd-tdep.c: Sort headers.
11402         * fbsd-nat.h: Sort headers.
11403         * fbsd-nat.c: Sort headers.
11404         * f-valprint.c: Sort headers.
11405         * f-typeprint.c: Sort headers.
11406         * f-lang.c: Sort headers.
11407         * extension.h: Sort headers.
11408         * extension.c: Sort headers.
11409         * extension-priv.h: Sort headers.
11410         * expprint.c: Sort headers.
11411         * exec.h: Sort headers.
11412         * exec.c: Sort headers.
11413         * exceptions.c: Sort headers.
11414         * event-top.c: Sort headers.
11415         * event-loop.c: Sort headers.
11416         * eval.c: Sort headers.
11417         * elfread.c: Sort headers.
11418         * dwarf2read.h: Sort headers.
11419         * dwarf2read.c: Sort headers.
11420         * dwarf2loc.c: Sort headers.
11421         * dwarf2expr.h: Sort headers.
11422         * dwarf2expr.c: Sort headers.
11423         * dwarf2-frame.c: Sort headers.
11424         * dwarf2-frame-tailcall.c: Sort headers.
11425         * dwarf-index-write.h: Sort headers.
11426         * dwarf-index-write.c: Sort headers.
11427         * dwarf-index-common.c: Sort headers.
11428         * dwarf-index-cache.h: Sort headers.
11429         * dwarf-index-cache.c: Sort headers.
11430         * dummy-frame.c: Sort headers.
11431         * dtrace-probe.c: Sort headers.
11432         * disasm.h: Sort headers.
11433         * disasm.c: Sort headers.
11434         * disasm-selftests.c: Sort headers.
11435         * dictionary.c: Sort headers.
11436         * dicos-tdep.c: Sort headers.
11437         * demangle.c: Sort headers.
11438         * dcache.h: Sort headers.
11439         * dcache.c: Sort headers.
11440         * darwin-nat.h: Sort headers.
11441         * darwin-nat.c: Sort headers.
11442         * darwin-nat-info.c: Sort headers.
11443         * d-valprint.c: Sort headers.
11444         * d-namespace.c: Sort headers.
11445         * d-lang.c: Sort headers.
11446         * ctf.c: Sort headers.
11447         * csky-tdep.c: Sort headers.
11448         * csky-linux-tdep.c: Sort headers.
11449         * cris-tdep.c: Sort headers.
11450         * cris-linux-tdep.c: Sort headers.
11451         * cp-valprint.c: Sort headers.
11452         * cp-support.c: Sort headers.
11453         * cp-namespace.c: Sort headers.
11454         * cp-abi.c: Sort headers.
11455         * corelow.c: Sort headers.
11456         * corefile.c: Sort headers.
11457         * continuations.c: Sort headers.
11458         * completer.h: Sort headers.
11459         * completer.c: Sort headers.
11460         * complaints.c: Sort headers.
11461         * coffread.c: Sort headers.
11462         * coff-pe-read.c: Sort headers.
11463         * cli-out.h: Sort headers.
11464         * cli-out.c: Sort headers.
11465         * charset.c: Sort headers.
11466         * c-varobj.c: Sort headers.
11467         * c-valprint.c: Sort headers.
11468         * c-typeprint.c: Sort headers.
11469         * c-lang.c: Sort headers.
11470         * buildsym.c: Sort headers.
11471         * buildsym-legacy.c: Sort headers.
11472         * build-id.h: Sort headers.
11473         * build-id.c: Sort headers.
11474         * btrace.c: Sort headers.
11475         * bsd-uthread.c: Sort headers.
11476         * breakpoint.h: Sort headers.
11477         * breakpoint.c: Sort headers.
11478         * break-catch-throw.c: Sort headers.
11479         * break-catch-syscall.c: Sort headers.
11480         * break-catch-sig.c: Sort headers.
11481         * blockframe.c: Sort headers.
11482         * block.c: Sort headers.
11483         * bfin-tdep.c: Sort headers.
11484         * bfin-linux-tdep.c: Sort headers.
11485         * bfd-target.c: Sort headers.
11486         * bcache.c: Sort headers.
11487         * ax-general.c: Sort headers.
11488         * ax-gdb.h: Sort headers.
11489         * ax-gdb.c: Sort headers.
11490         * avr-tdep.c: Sort headers.
11491         * auxv.c: Sort headers.
11492         * auto-load.c: Sort headers.
11493         * arm-wince-tdep.c: Sort headers.
11494         * arm-tdep.c: Sort headers.
11495         * arm-symbian-tdep.c: Sort headers.
11496         * arm-pikeos-tdep.c: Sort headers.
11497         * arm-obsd-tdep.c: Sort headers.
11498         * arm-nbsd-tdep.c: Sort headers.
11499         * arm-nbsd-nat.c: Sort headers.
11500         * arm-linux-tdep.c: Sort headers.
11501         * arm-linux-nat.c: Sort headers.
11502         * arm-fbsd-tdep.c: Sort headers.
11503         * arm-fbsd-nat.c: Sort headers.
11504         * arm-bsd-tdep.c: Sort headers.
11505         * arch-utils.c: Sort headers.
11506         * arc-tdep.c: Sort headers.
11507         * arc-newlib-tdep.c: Sort headers.
11508         * annotate.h: Sort headers.
11509         * annotate.c: Sort headers.
11510         * amd64-windows-tdep.c: Sort headers.
11511         * amd64-windows-nat.c: Sort headers.
11512         * amd64-tdep.c: Sort headers.
11513         * amd64-sol2-tdep.c: Sort headers.
11514         * amd64-obsd-tdep.c: Sort headers.
11515         * amd64-obsd-nat.c: Sort headers.
11516         * amd64-nbsd-tdep.c: Sort headers.
11517         * amd64-nbsd-nat.c: Sort headers.
11518         * amd64-nat.c: Sort headers.
11519         * amd64-linux-tdep.c: Sort headers.
11520         * amd64-linux-nat.c: Sort headers.
11521         * amd64-fbsd-tdep.c: Sort headers.
11522         * amd64-fbsd-nat.c: Sort headers.
11523         * amd64-dicos-tdep.c: Sort headers.
11524         * amd64-darwin-tdep.c: Sort headers.
11525         * amd64-bsd-nat.c: Sort headers.
11526         * alpha-tdep.c: Sort headers.
11527         * alpha-obsd-tdep.c: Sort headers.
11528         * alpha-nbsd-tdep.c: Sort headers.
11529         * alpha-mdebug-tdep.c: Sort headers.
11530         * alpha-linux-tdep.c: Sort headers.
11531         * alpha-linux-nat.c: Sort headers.
11532         * alpha-bsd-tdep.c: Sort headers.
11533         * alpha-bsd-nat.c: Sort headers.
11534         * aix-thread.c: Sort headers.
11535         * agent.c: Sort headers.
11536         * addrmap.c: Sort headers.
11537         * ada-varobj.c: Sort headers.
11538         * ada-valprint.c: Sort headers.
11539         * ada-typeprint.c: Sort headers.
11540         * ada-tasks.c: Sort headers.
11541         * ada-lang.c: Sort headers.
11542         * aarch64-tdep.c: Sort headers.
11543         * aarch64-ravenscar-thread.c: Sort headers.
11544         * aarch64-newlib-tdep.c: Sort headers.
11545         * aarch64-linux-tdep.c: Sort headers.
11546         * aarch64-linux-nat.c: Sort headers.
11547         * aarch64-fbsd-tdep.c: Sort headers.
11548         * aarch64-fbsd-nat.c: Sort headers.
11549         * aarch32-linux-nat.c: Sort headers.
11550
11551 2019-04-04  Tom Tromey  <tom@tromey.com>
11552
11553         * varobj.c (varobj_create): Update.
11554         * rust-exp.y (struct rust_parser) <update_innermost_block,
11555         lookup_symbol>: New methods.
11556         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11557         Rename.
11558         (rust_parser::rust_lookup_type)
11559         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11560         * printcmd.c (display_command, do_one_display): Update.
11561         * parser-defs.h (struct parser_state) <parser_state>: Add
11562         "tracker" parameter.
11563         (block_tracker): New member.
11564         (class innermost_block_tracker) <innermost_block_tracker>: Add
11565         "types" parameter.
11566         <reset>: Remove method.
11567         (innermost_block): Don't declare.
11568         (null_post_parser): Update.
11569         * parse.c (innermost_block): Remove global.
11570         (write_dollar_variable): Update.
11571         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11572         Remove "tracker_types" parameter.
11573         (parse_expression): Add "tracker" parameter.
11574         (parse_expression_for_completion): Update.
11575         (null_post_parser): Add "tracker" parameter.
11576         * p-exp.y: Update rules.
11577         * m2-exp.y: Update rules.
11578         * language.h (struct language_defn) <la_post_parser>: Add
11579         "tracker" parameter.
11580         * go-exp.y: Update rules.
11581         * f-exp.y: Update rules.
11582         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11583         parameter.
11584         * d-exp.y: Update rules.
11585         * c-exp.y: Update rules.
11586         * breakpoint.c (set_breakpoint_condition): Create an
11587         innermost_block_tracker.
11588         (watch_command_1): Likewise.
11589         * ada-lang.c (resolve): Add "tracker" parameter.
11590         (resolve_subexp): Likewise.
11591         * ada-exp.y (write_var_from_sym): Update.
11592
11593 2019-04-04  Tom Tromey  <tom@tromey.com>
11594
11595         * type-stack.h: New file.
11596         * type-stack.c: New file.
11597         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11598         type-stack.h.
11599         (insert_into_type_stack, insert_type, push_type, push_type_int)
11600         (insert_type_address_space, pop_type, pop_type_int)
11601         (pop_typelist, pop_type_stack, append_type_stack)
11602         (push_type_stack, get_type_stack, push_typelist)
11603         (follow_type_instance_flags, follow_types): Don't declare.
11604         * parse.c (type_stack): Remove global.
11605         (parse_exp_in_context): Update.
11606         (insert_into_type_stack, insert_type, push_type, push_type_int)
11607         (insert_type_address_space, pop_type, pop_type_int)
11608         (pop_typelist, pop_type_stack, append_type_stack)
11609         (push_type_stack, get_type_stack, push_typelist)
11610         (follow_type_instance_flags, follow_types): Remove (moved to
11611         type-stack.c).
11612         * f-exp.y (type_stack): New global.
11613         Update rules.
11614         (push_kind_type, f_parse): Update.
11615         * d-exp.y (type_stack): New global.
11616         Update rules.
11617         (d_parse): Update.
11618         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11619         Update rules.
11620         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11621         (HFILES_NO_SRCDIR): Add type-stack.h.
11622
11623 2019-04-04  Tom Tromey  <tom@tromey.com>
11624
11625         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11626         (rust_parser::convert_ast_to_expression, rust_parse)
11627         (rust_lex_test_completion, rust_lex_tests): Update.
11628         * parser-defs.h (struct expr_completion_state): New.
11629         (struct parser_state) <parser_state>: Add completion parameter.
11630         <mark_struct_expression, mark_completion_tag>: New methods.
11631         <parse_completion, m_completion_state>: New members.
11632         (prefixify_expression, null_post_parser): Update.
11633         (mark_struct_expression, mark_completion_tag): Don't declare.
11634         * parse.c (parse_completion, expout_last_struct)
11635         (expout_tag_completion_type, expout_completion_name): Remove
11636         globals.
11637         (parser_state::mark_struct_expression)
11638         (parser_state::mark_completion_tag): Now methods.
11639         (prefixify_expression): Add last_struct parameter.
11640         (prefixify_subexp): Likewise.
11641         (parse_exp_1): Update.
11642         (parse_exp_in_context): Add cstate parameter.  Update.
11643         (parse_expression_for_completion): Create an
11644         expr_completion_state.
11645         (null_post_parser): Add "completion" parameter.
11646         * p-exp.y: Update rules.
11647         (yylex): Update.
11648         * language.h (struct language_defn) <la_post_parser>: Add
11649         "completing" parameter.
11650         * go-exp.y: Update rules.
11651         (lex_one_token): Update.
11652         * expression.h (parse_completion): Don't declare.
11653         * d-exp.y: Update rules.
11654         (lex_one_token): Update rules.
11655         * c-exp.y: Update rules.
11656         (lex_one_token): Update.
11657         * ada-lang.c (resolve): Add "parse_completion" parameter.
11658         (resolve_subexp): Likewise.
11659         (ada_resolve_function): Likewise.
11660
11661 2019-04-04  Tom Tromey  <tom@tromey.com>
11662
11663         * parser-defs.h (struct parser_state) <start_arglist,
11664         end_arglist>: New methods.
11665         <arglist_len, m_funcall_chain>: New members.
11666         (arglist_len, start_arglist, end_arglist): Don't declare.
11667         * parse.c (arglist_len, funcall_chain): Remove global.
11668         (start_arglist, end_arglist): Remove functions.
11669         (parse_exp_in_context): Update.
11670         * p-exp.y: Update rules.
11671         * m2-exp.y: Update rules.
11672         * go-exp.y: Update rules.
11673         * f-exp.y: Update rules.
11674         * d-exp.y: Update rules.
11675         * c-exp.y: Update rules.
11676
11677 2019-04-04  Tom Tromey  <tom@tromey.com>
11678
11679         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11680         lex_operator, push_back>: New methods.
11681         Update all rules.
11682         (rust_parser::lex_hex, lex_escape): Rename and update.
11683         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11684         (rust_parser::lex_operator): Rename and update.
11685         (rust_parser::lex_number, rustyylex, rustyyerror)
11686         (rust_lex_test_init, rust_lex_test_sequence)
11687         (rust_lex_test_push_back, rust_lex_tests): Update.
11688         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11689         parameter.
11690         <lexptr, prev_lexptr>: New members.
11691         (lexptr, prev_lexptr): Don't declare.
11692         * parse.c (lexptr, prev_lexptr): Remove globals.
11693         (parse_exp_in_context): Update.
11694         * p-exp.y (yylex, yyerror): Update.
11695         * m2-exp.y (parse_number, yylex, yyerror): Update.
11696         * go-exp.y (lex_one_token, yyerror): Update.
11697         * f-exp.y (match_string_literal, yylex, yyerror): Update.
11698         * d-exp.y (lex_one_token, yyerror): Update.
11699         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11700         (lex_one_token, yyerror): Update.
11701         * ada-lex.l (YY_INPUT): Update.
11702         (rewind_to_char): Update.
11703         * ada-exp.y (yyerror): Update.
11704
11705 2019-04-04  Tom Tromey  <tom@tromey.com>
11706
11707         * rust-exp.y (rustyylex, rust_lex_tests): Update.
11708         * parser-defs.h (struct parser_state) <parser_state>: Add new
11709         parameter.
11710         <comma_terminates>: New member.
11711         (comma_terminates): Don't declare global.
11712         * parse.c (comma_terminates): Remove global.
11713         (parse_exp_in_context): Update.
11714         * p-exp.y (yylex): Update.
11715         * m2-exp.y (yylex): Update.
11716         * go-exp.y (lex_one_token): Update.
11717         * f-exp.y (yylex): Update.
11718         * d-exp.y (lex_one_token): Update.
11719         * c-exp.y (lex_one_token): Update.
11720         * ada-lex.l: Update.
11721
11722 2019-04-04  Tom Tromey  <tom@tromey.com>
11723
11724         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11725         (rustyylex, rust_lex_test_init, rust_lex_test_one)
11726         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11727         * parser-defs.h (paren_depth): Don't declare.
11728         * parse.c (paren_depth): Remove global.
11729         (parse_exp_in_context): Update.
11730         * p-exp.y (paren_depth): New global.
11731         (pascal_parse): Initialize it.
11732         * m2-exp.y (paren_depth): New global.
11733         (m2_parse): Initialize it.
11734         * go-exp.y (paren_depth): New global.
11735         (go_parse): Initialize it.
11736         * f-exp.y (paren_depth): New global.
11737         (f_parse): Initialize it.
11738         * d-exp.y (paren_depth): New global.
11739         (d_parse): Initialize it.
11740         * c-exp.y (paren_depth): New global.
11741         (c_parse): Initialize it.
11742         * ada-lex.l (paren_depth): New global.
11743         (lexer_init): Initialize it.
11744
11745 2019-04-04  Tom Tromey  <tom@tromey.com>
11746
11747         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11748         (rust_parser::convert_ast_to_type)
11749         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11750         * parser-defs.h (struct parser_state) <parser_state>: Add
11751         parameters.  Initialize new members.
11752         <expression_context_block, expression_context_pc>: New members.
11753         * parse.c (expression_context_block, expression_context_pc):
11754         Remove globals.
11755         (parse_exp_in_context): Update.
11756         * p-exp.y: Update all rules.
11757         (yylex): Update.
11758         * m2-exp.y: Update all rules.
11759         (yylex): Update.
11760         * go-exp.y (yylex): Update.
11761         * f-exp.y (yylex): Update.
11762         * d-exp.y: Update all rules.
11763         (yylex): Update.
11764         * c-exp.y: Update all rules.
11765         (lex_one_token, classify_name, yylex, c_parse): Update.
11766         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11767
11768 2019-04-04  Tom Tromey  <tom@tromey.com>
11769
11770         * gdbarch.h, gdbarch.c: Rebuild.
11771         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11772         * stap-probe.h:
11773         (struct stap_parse_info): Replace "parser_state" with
11774         "expr_builder".
11775         * parser-defs.h (struct expr_builder): Rename from "parser_state".
11776         (parser_state): New class.
11777         * parse.c (expr_builder): Rename.
11778         (expr_builder::release): Rename.
11779         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11780         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11781         (write_exp_elt_longcst, write_exp_elt_floatcst)
11782         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11783         (write_exp_string_vector, write_exp_bitstring)
11784         (write_exp_msymbol, mark_struct_expression)
11785         (write_dollar_variable)
11786         (insert_type_address_space, increase_expout_size): Replace
11787         "parser_state" with "expr_builder".
11788         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11789         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11790         "parser_state" with "expr_builder".
11791
11792 2019-04-04  Tom Tromey  <tom@tromey.com>
11793
11794         * rust-exp.y: Replace "parse_language" with method call.
11795         * p-exp.y:
11796         (yylex): Replace "parse_language" with method call.
11797         * m2-exp.y:
11798         (yylex): Replace "parse_language" with method call.
11799         * go-exp.y (classify_name): Replace "parse_language" with method
11800         call.
11801         * f-exp.y (yylex): Replace "parse_language" with method call.
11802         * d-exp.y (lex_one_token): Replace "parse_language" with method
11803         call.
11804         * c-exp.y:
11805         (lex_one_token, classify_name, yylex): Replace "parse_language"
11806         with method call.
11807         * ada-exp.y (find_primitive_type, type_char)
11808         (type_system_address): Replace "parse_language" with method call.
11809
11810 2019-04-04  Tom Tromey  <tom@tromey.com>
11811
11812         * rust-exp.y: Replace "parse_gdbarch" with method call.
11813         * parse.c (write_dollar_variable, insert_type_address_space):
11814         Replace "parse_gdbarch" with method call.
11815         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11816         call.
11817         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11818         call.
11819         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11820         "parse_gdbarch" with method call.
11821         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11822         with method call.
11823         * f-exp.y (parse_type, parse_f_type, yylex): Replace
11824         "parse_gdbarch" with method call.
11825         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11826         "parse_gdbarch" with method call.
11827         * c-exp.y (parse_type, parse_number, classify_name): Replace
11828         "parse_gdbarch" with method call.
11829         * ada-lex.l: Replace "parse_gdbarch" with method call.
11830         * ada-exp.y (parse_type, find_primitive_type, type_char)
11831         (type_system_address): Replace "parse_gdbarch" with method call.
11832
11833 2019-04-04  Tom Tromey  <tom@tromey.com>
11834
11835         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11836         * stap-probe.c (stap_parse_argument): Update.
11837         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11838         initial_size parameter.
11839         * rust-exp.y (rust_lex_tests): Update.
11840         * parse.c (parser_state): Update.
11841         (parse_exp_in_context): Update.
11842         * parser-defs.h (struct parser_state) <parser_state>: Remove
11843         "initial_size" parameter.
11844
11845 2019-04-04  Tom Tromey  <tom@tromey.com>
11846
11847         * parser-defs.h (increase_expout_size): Don't declare.
11848         * parse.c (increase_expout_size): Now static.
11849
11850 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
11851
11852         * gnu-nat.c (gnu_nat_target::wait): Fix
11853         target_waitstatus_to_string call.
11854
11855 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11856
11857         * eval.c (evaluate_subexp_standard): Handle internal functions
11858         during Fortran function call handling.
11859
11860 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11861
11862         * NEWS: Mention new internal functions.
11863         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11864         (read_base_type): Use dwarf2_init_complex_target_type.
11865         * value.c (creal_internal_fn): New function.
11866         (cimag_internal_fn): New function.
11867         (_initialize_values): Register new internal functions.
11868
11869 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11870
11871         * infrun.c (stop_all_threads): If debug_infrun, always
11872         trace the wait status after wait_one, using
11873         target_waitstatus_to_string and target_pid_to_str.
11874         (handle_inferior_event): Replace various trace of
11875         wait status kind by a single trace.
11876         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11877         wait status kind image by target_waitstatus_to_string.
11878         * target/waitstatus.c (target_waitstatus_to_string): Fix
11879         obsolete comment.
11880
11881 2019-04-01  Tom Tromey  <tromey@adacore.com>
11882
11883         PR symtab/23331:
11884         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11885
11886 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
11887             Pedro Alves  <palves@redhat.com>
11888
11889         * top.c (quit_force): Call 'finalize_values'.
11890         * value.c (finalize_values): New function.
11891         * value.h (finalize_values): Declare.
11892
11893 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
11894
11895         * NEWS: Announce $_gdb_major and $_gdb_minor.
11896
11897         * top.c (init_gdb_version_vars): New function.
11898         (gdb_init): Call init_gdb_version_vars.
11899
11900 2019-03-29  Tom Tromey  <tromey@adacore.com>
11901
11902         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
11903         help text.  Remove dead code.
11904
11905 2019-03-29  Keith Seitz  <keiths@redhat.com>
11906
11907         From Siddhesh Poyarekar:
11908         * f-lang.h (f77_get_upperbound): Return LONGEST.
11909         (f77_get_lowerbound): Likewise.
11910         * f-typeprint.c (f_type_print_varspec_suffix): Expand
11911         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
11912         print them.
11913         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
11914         plongest to format print it.
11915         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
11916         (f77_get_upperbound): Likewise.
11917         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
11918         LOWER_BOUND to LONGEST.
11919         (f77_create_arrayprint_offset_tbl): Likewise.
11920
11921 2019-03-29  Keith Seitz  <keiths@redhat.com>
11922
11923         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
11924         %s/pulongest for TYPE_LENGTH instead of %d in format
11925         strings.
11926         * ada-typerint.c (ada_print_type): Likewise.
11927         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
11928         * compile/compile-c-support.c (generate_register_struct): Likewise.
11929         * gdbtypes.c (recursive_dump_type): Likewise.
11930         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
11931         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
11932         instead of %d in format strings.
11933         * riscv-tdep.c (riscv_type_alignment): Cast second argument
11934         to std::min to ULONGEST.
11935         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
11936         instead of %d in format strings.
11937         * tracepoint.c (info_scope_command): Likewise.
11938         * typeprint.c (print_offset_data::update)
11939         (print_offset_data::finish): Likewise.
11940         * xtensa-tdep.c (xtensa_store_return_value)
11941         (xtensa_push_dummy_call): Likewise.
11942
11943 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
11944
11945         * windows-nat.c (display_selector): Fixed format specifications
11946         for 64-bit Cygwin.
11947
11948 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11949
11950         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
11951
11952 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
11953
11954         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
11955         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11956         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11957         (nios2_linux_init_abi): Install it.
11958
11959 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11960
11961         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
11962
11963 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11964
11965         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
11966
11967 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11968             Tom Tromey  <tromey@adacore.com>
11969
11970         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
11971
11972 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
11973
11974         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
11975         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
11976         method to compute the bounds of range types. Also print "[evaluated]"
11977         if the bounds' values come from a dynamic evaluation.
11978
11979 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11980
11981         * cp-valprint.c (cp_print_value_fields): Don't print trailing
11982         whitespace when pretty printing is on.
11983
11984 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11985
11986         * ppc-linux-nat.c: Add include.
11987
11988 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11989
11990         * NEWS: Mention AArch64 Pointer Authentication.
11991
11992 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11993
11994         * arm-linux-nat.c: Add include.
11995
11996 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
11997
11998         * source-cache.c (source_cache::get_source_lines): Re-read
11999         fullname after calling open_source_file.
12000
12001 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12002
12003         * NEWS: Mention TLS support for FreeBSD.
12004
12005 2019-03-25  Tom Tromey  <tromey@adacore.com>
12006
12007         * minsyms.c (BUNCH_SIZE): Update comment.
12008         (~minimal_symbol_reader): Remove old comment.
12009         (compact_minimal_symbols): Update comment.
12010         (minimal_symbol_reader::install): Remove old comment.  Update
12011         other comments.
12012
12013 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12014
12015         * s390-linux-nat.c: Add include.
12016
12017 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12018
12019         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12020         Call linux_get_hwcap.
12021         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12022         Likewise.
12023         (aarch64_linux_get_hwcap): Remove function.
12024         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12025         declaration.
12026         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12027         linux_get_hwcap.
12028         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12029         * linux-tdep.c (linux_get_hwcap): Add function.
12030         (linux_get_hwcap2): Likewise.
12031         * linux-tdep.h (linux_get_hwcap): Add declaration.
12032         (linux_get_hwcap2): Likewise.
12033         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12034         (ppc_linux_get_hwcap2): Likewise.
12035         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12036         linux_get_hwcap.
12037         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12038         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12039         (ppc_linux_nat_target::read_description): Likewise.
12040         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12041         * s390-linux-nat.c: Likewise.
12042         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12043
12044 2019-03-24  Tom Tromey  <tom@tromey.com>
12045
12046         * ada-lang.c (standard_lookup): Simplify initialization.
12047         (ada_lookup_symbol_nonlocal): Simplify return.
12048         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12049         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12050         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12051         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12052         initialization.
12053         * solib.c (solib_global_lookup): Simplify.
12054         * symtab.c (null_block_symbol): Remove.
12055         (symbol_cache_lookup): Simplify returns.
12056         (lookup_language_this): Simplify returns.
12057         (lookup_symbol_aux): Simplify return.
12058         (lookup_local_symbol): Simplify returns.
12059         (lookup_global_symbol_from_objfile): Simplify return.
12060         (lookup_symbol_in_objfile_symtabs)
12061         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12062         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12063         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12064         * cp-namespace.c (cp_lookup_bare_symbol)
12065         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12066         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12067         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12068         (cp_lookup_symbol_via_imports): Simplify initialization.
12069         (find_symbol_in_baseclass): Likewise.
12070         * symtab.h (null_block_symbol): Remove.
12071         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12072         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12073         (d_lookup_symbol_module): Likewise.
12074         (find_symbol_in_baseclass): Simplify initialization.
12075
12076 2019-03-24  Tom Tromey  <tom@tromey.com>
12077
12078         * expression.h: Don't include symtab.h.
12079         (struct block): Forward declare.
12080
12081 2019-03-24  Tom Tromey  <tom@tromey.com>
12082
12083         * c-exp.y (typebase): Remove casts.
12084         * gdbtypes.c (lookup_unsigned_typename, )
12085         (lookup_signed_typename): Remove cast.
12086         * eval.c (parse_to_comma_and_eval): Remove cast.
12087         * parse.c (write_dollar_variable): Remove cast.
12088         * block.h (struct block) <superblock>: Now const.
12089         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12090         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12091         (map_block): Make "block" const.
12092         * symfile.h (struct quick_symbol_functions)
12093         <map_matching_symbols>: Constify block argument to "callback".
12094         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12095         const.
12096         (find_pc_sect_compunit_symtab): Make "b" const.
12097         (find_symbol_at_address): Likewise.
12098         (search_symbols): Likewise.
12099         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12100         (dw2_debug_names_lookup_symbol): Likewise.
12101         (dw2_map_matching_symbols): Update.
12102         * p-valprint.c (pascal_val_print): Remove "block".
12103         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12104         (aux_add_nonlocal_symbols): Make "block" const.
12105         (resolve_subexp): Remove cast.
12106         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12107         const.
12108         (iterate_over_file_blocks): Likewise.
12109         * f-exp.y (%union) <bval>: Remove.
12110         * coffread.c (patch_opaque_types): Make "b" const.
12111         * spu-tdep.c (spu_catch_start): Make "block" const.
12112         * c-valprint.c (print_unpacked_pointer): Remove "block".
12113         * symmisc.c (dump_symtab_1): Make "b" const.
12114         (block_depth): Make "block" const.
12115         * d-exp.y (%union) <bval>: Remove.
12116         * cp-support.h (cp_lookup_rtti_type): Update.
12117         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12118         * psymtab.c (psym_lookup_symbol): Make "block" const.
12119         (maintenance_check_psymtabs): Make "b" const.
12120         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12121         (enumerate_locals, enumerate_args): Update.
12122         * python/py-symtab.c (stpy_global_block): Make "block" const.
12123         (stpy_static_block): Likewise.
12124         * inline-frame.c (block_starting_point_at): Make "new_block"
12125         const.
12126         * block.c (find_block_in_blockvector): Make return type const.
12127         (blockvector_for_pc_sect): Make "b" const.
12128         (find_block_in_blockvector): Make "b" const.
12129
12130 2019-03-23  Tom Tromey  <tom@tromey.com>
12131
12132         * varobj.c (varobj_create): Update.
12133         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12134         * printcmd.c (display_command, do_one_display): Don't reset
12135         innermost_block.
12136         * parser-defs.h (enum innermost_block_tracker_type): Move to
12137         expression.h.
12138         (innermost_block): Update comment.
12139         * parse.c (parse_exp_1): Add tracker_types parameter.
12140         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12141         tracker_types parameter.  Reset innermost_block.
12142         (parse_exp_in_context): Remove.
12143         (parse_expression_for_completion): Update.
12144         * objfiles.c (~objfile): Don't reset expression_context_block or
12145         innermost_block.
12146         * expression.h (enum innermost_block_tracker_type): Move from
12147         parser-defs.h.
12148         (parse_exp_1): Add tracker_types parameter.
12149         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12150         reset innermost_block.
12151
12152 2019-03-23  Tom Tromey  <tom@tromey.com>
12153
12154         * objfiles.h: Include bcache.h.
12155
12156 2019-03-23  Tom Tromey  <tom@tromey.com>
12157
12158         * linespec.c (get_current_search_block): Use
12159         scoped_restore_current_language.
12160         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12161
12162 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12163             Jiong Wang  <jiong.wang@arm.com>
12164
12165         * aarch64-linux-tdep.c
12166         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12167         section.
12168         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12169
12170 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12171             Jiong Wang  <jiong.wang@arm.com>
12172
12173         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12174         instructions.
12175         (aarch64_analyze_prologue_test): Add PACIASP test.
12176         (aarch64_prologue_prev_register): Unmask PC value.
12177
12178 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12179             Jiong Wang  <jiong.wang@arm.com>
12180
12181         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12182         (aarch64_dwarf2_prev_register): Unmask PC value.
12183         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12184         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12185         DW_CFA_AARCH64_negate_ra_state.
12186         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12187
12188 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12189             Jiong Wang  <jiong.wang@arm.com>
12190
12191         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12192         registers.
12193         (aarch64_pseudo_register_name): Likewise.
12194         (aarch64_pseudo_register_type): Likewise.
12195         (aarch64_pseudo_register_reggroup_p): Likewise.
12196         (aarch64_gdbarch_init): Add pauth registers.
12197         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12198         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12199         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12200         (struct gdbarch_tdep): Add regnum for ra_state.
12201
12202 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12203             Jiong Wang  <jiong.wang@arm.com>
12204
12205         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12206
12207 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12208             Jiong Wang  <jiong.wang@arm.com>
12209
12210         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12211         function.
12212         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12213         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12214         (aarch64_gdbarch_init): Add puth registers.
12215         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12216         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12217         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12218
12219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12220             Jiong Wang  <jiong.wang@arm.com>
12221
12222         * aarch64-linux-nat.c
12223         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12224         * aarch64-linux-tdep.c
12225         (aarch64_linux_core_read_description): Likewise.
12226         (aarch64_linux_get_hwcap): New function.
12227         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12228         (aarch64_linux_get_hwcap): New declaration.
12229
12230 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12231             Jiong Wang  <jiong.wang@arm.com>
12232
12233         * aarch64-linux-nat.c
12234         (aarch64_linux_nat_target::read_description): Add pauth param.
12235         * aarch64-linux-tdep.c
12236         (aarch64_linux_core_read_description): Likewise.
12237         * aarch64-tdep.c (struct target_desc): Add in pauth.
12238         (aarch64_read_description): Add pauth param.
12239         (aarch64_gdbarch_init): Likewise.
12240         * aarch64-tdep.h (aarch64_read_description): Likewise.
12241         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12242         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12243         * features/Makefile: Add new files.
12244         * features/aarch64-pauth.c: New file.
12245         * features/aarch64-pauth.xml: New file.
12246
12247 2019-03-20  Tom Tromey  <tromey@adacore.com>
12248
12249         * infrun.c (handle_inferior_event): Rename from
12250         handle_inferior_event_1.  Create a scoped_value_mark.
12251         (handle_inferior_event): Remove.
12252
12253 2019-03-19  Tom Tromey  <tromey@adacore.com>
12254
12255         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12256         * infrun.h (print_stop_event): Add "displays" parameter.
12257         * infrun.c (print_stop_event): Add "displays" parameter.
12258
12259 2019-03-19  Pedro Alves  <palves@redhat.com>
12260
12261         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12262         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12263         to -1.  Fix TABs vs spaces.
12264         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12265         * tui/tui-out.h (tui_ui_out) Add intro comments.
12266         <m_line, m_start_of_line>: In-class initialize, and add describing
12267         comment.
12268
12269 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12270
12271         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12272         variable names.
12273         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12274
12275 2019-03-18  Pedro Alves  <palves@redhat.com>
12276             Eli Zaretskii <eliz@gnu.org>
12277
12278         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12279         m_line and m_start_of_line.
12280
12281 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12282
12283         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12284         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12285         it returns a newline.  This fixes a regression in TU mode, whereby
12286         the next line is output on the same screen line as the user input.
12287
12288 2019-03-18  Tom Tromey  <tromey@adacore.com>
12289
12290         * minsyms.c (minimal_symbol_reader::install): Remove call to
12291         obstack_blank.
12292
12293 2019-03-18  Pedro Alves  <palves@redhat.com>
12294
12295         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12296         New globals.
12297         (apply_style): New, factored out from ...
12298         (apply_ansi_escape): ... this.  Handle reverse video mode.
12299         (tui_set_reverse_mode): New function.
12300         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12301         * tui/tui-winsource.c (tui_show_source_line): Use
12302         tui_set_reverse_mode instead of setting A_STANDOUT.
12303         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12304         New setter methods.
12305
12306 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12307
12308         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12309         Handle tabs.
12310
12311 2019-03-18  Tom Tromey  <tromey@adacore.com>
12312
12313         * ada-lang.c (empty_array): Add "high" parameter.
12314         (ada_evaluate_subexp): Update.
12315
12316 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12317
12318         * unittests/string_view-selftests.c: Define
12319         _initialize_string_view_selftests unconditionally.
12320
12321 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12322
12323         PR gdb/24350
12324         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12325
12326 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12327
12328         PR gdb/24351
12329         * windows-nat.c (display_selector): Fix format specifiers.
12330
12331 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12332
12333         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12334         tui_refill_source_window instead of tui_refresh_win, to update the
12335         current execution line.  This fixes redisplay of the current line
12336         when stepping through the code with "next" or "step".
12337
12338 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12339
12340         * source-cache.c (source_cache::get_source_lines): Call
12341         find_source_lines to initialize s->nlines.  This fixes vertical
12342         scrolling of TUI source window when the DOWN arrow is pressed.
12343
12344 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12345
12346         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12347         linux-thread-db.c (_initialize_thread_db): Likewise.
12348
12349 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12350
12351         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12352         wclrtoeol in tui_show_source_line".  This reverts changes made in
12353         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12354
12355 2019-03-15  Tom Tromey  <tom@tromey.com>
12356
12357         * symtab.h (struct minimal_symbol): Derive from
12358         general_symbol_info.
12359         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12360         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12361         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12362         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12363         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12364         (MSYMBOL_SEARCH_NAME): Update.
12365         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12366         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12367         * minsyms.c (minimal_symbol_reader::record_full): Update.
12368
12369 2019-03-15  Tom Tromey  <tom@tromey.com>
12370
12371         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12372
12373 2019-03-15  Tom Tromey  <tom@tromey.com>
12374
12375         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12376         unique_xmalloc_ptr.
12377         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12378         Update.
12379         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12380         (build_minimal_symbol_hash_tables)
12381         (minimal_symbol_reader::install): Update.
12382
12383 2019-03-15  Tom Tromey  <tom@tromey.com>
12384
12385         * symtab.c (create_demangled_names_hash): Update.
12386         (symbol_set_names): Update.
12387         * objfiles.h (struct objfile_per_bfd_storage)
12388         <demangled_names_hash>: Now an htab_up.
12389         * objfiles.c (objfile_per_bfd_storage): Simplify.
12390
12391 2019-03-15  Tom Tromey  <tom@tromey.com>
12392
12393         * objfiles.h (struct objfile_per_bfd_storage): Declare
12394         destructor.
12395         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12396         New.
12397         (get_objfile_bfd_data): Use new.  Don't initialize
12398         language_of_main.
12399         (free_objfile_per_bfd_storage): Remove.
12400         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12401
12402 2019-03-15  Tom Tromey  <tom@tromey.com>
12403
12404         * symfile.c (reread_symbols): Update.
12405         * objfiles.c (objfile::objfile): Update.
12406         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12407         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12408         comment.
12409         (minimal_symbol_reader::install): Update.
12410         (terminate_minimal_symbol_table): Remove.
12411         * jit.c (jit_object_close_impl): Update.
12412
12413 2019-03-15  Tom Tromey  <tom@tromey.com>
12414
12415         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12416         initializations.
12417
12418 2019-03-15  Tom Tromey  <tom@tromey.com>
12419
12420         * objfiles.h (struct objfile_per_bfd_storage)
12421         <demangled_hash_languages>: Now a bitset.
12422         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12423         (lookup_minimal_symbol): Update.
12424
12425 2019-03-15  Tom Tromey  <tom@tromey.com>
12426
12427         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12428         Don't return the symbol.
12429         * coffread.c (record_minimal_symbol): Use record_full.
12430
12431 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12432
12433         The MS-Windows port of ncurses fails to switch to a color pair if
12434         one or both of the colors are the implicit default colors.  This
12435         change records the default colors when TUI is initialized, and
12436         then specifies them explicitly when a color pair uses the default
12437         colors.  This allows color styling in TUI mode on MS-Windows.
12438
12439         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12440         ncurses_norm_attr.
12441         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12442         colors in ncurses_norm_attr.
12443         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12444         "none", replace it with the default color recorded in
12445         ncurses_norm_attr.
12446
12447 2019-03-14  Tom Tromey  <tromey@adacore.com>
12448
12449         * source-cache.h (class source_cache) <get_source_lines>: Return
12450         std::string.
12451         * source-cache.c (source_cache::extract_lines): Handle case where
12452         first_pos==npos.  Return std::string.
12453         (source_cache::get_source_lines): Update.
12454
12455 2019-03-14  Tom Tromey  <tromey@adacore.com>
12456
12457         * NEWS: Add item for "style sources" commands.
12458         * source-cache.c (source_cache::get_source_lines): Check
12459         source_styling.
12460         * cli/cli-style.c (source_styling): New global.
12461         (_initialize_cli_style): Add "style sources" commands.
12462         (show_style_sources): New function.
12463         * cli/cli-style.h (source_styling): Declare.
12464
12465 2019-03-14  Pedro Alves  <palves@redhat.com>
12466             Tom Tromey  <tromey@adacore.com>
12467
12468         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12469         * tui/tui-winsource.c (tui_refill_source_window): New function,
12470         from...
12471         (tui_horizontal_source_scroll): ... here.  Move some logic.
12472         * cli/cli-style.c (set_style_enabled): Notify new observable.
12473         * tui/tui-hooks.c (tui_redisplay_source): New function.
12474         (tui_attach_detach_observers): Attach or detach
12475         tui_redisplay_source.
12476         * observable.h (source_styling_changed): New observable.
12477         * observable.c: Define source_styling_changed observable.
12478
12479 2019-03-13  Tom Tromey  <tromey@adacore.com>
12480
12481         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12482         (i386_gnu_nat_target::store_registers): Update.
12483         * target-debug.h (target_debug_print_std_string): New macro.
12484         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12485         * windows-tdep.c (display_one_tib): Update.
12486         * tui/tui-stack.c (tui_make_status_line): Update.
12487         * top.c (print_inferior_quit_action): Update.
12488         * thread.c (thr_try_catch_cmd): Update.
12489         (add_thread_with_info): Update.
12490         (thread_target_id_str): Update.
12491         (thr_try_catch_cmd): Update.
12492         (thread_command): Update.
12493         (thread_find_command): Update.
12494         * record-btrace.c (record_btrace_target::info_record)
12495         (record_btrace_resume_thread, record_btrace_target::resume)
12496         (record_btrace_cancel_resume, record_btrace_step_thread)
12497         (record_btrace_target::wait, record_btrace_target::wait)
12498         (record_btrace_target::wait, record_btrace_target::stop): Update.
12499         * progspace.c (print_program_space): Update.
12500         * process-stratum-target.c
12501         (process_stratum_target::thread_address_space): Update.
12502         * linux-fork.c (linux_fork_mourn_inferior)
12503         (detach_checkpoint_command, info_checkpoints_command)
12504         (linux_fork_context): Update.
12505         (linux_fork_detach): Update.
12506         (class scoped_switch_fork_info): Update.
12507         (delete_checkpoint_command): Update.
12508         * infrun.c (follow_fork_inferior): Update.
12509         (follow_fork_inferior): Update.
12510         (proceed_after_vfork_done): Update.
12511         (handle_vfork_child_exec_or_exit): Update.
12512         (follow_exec): Update.
12513         (displaced_step_prepare_throw): Update.
12514         (displaced_step_restore): Update.
12515         (start_step_over): Update.
12516         (resume_1): Update.
12517         (clear_proceed_status_thread): Update.
12518         (proceed): Update.
12519         (print_target_wait_results): Update.
12520         (do_target_wait): Update.
12521         (context_switch): Update.
12522         (stop_all_threads): Update.
12523         (restart_threads): Update.
12524         (finish_step_over): Update.
12525         (handle_signal_stop): Update.
12526         (switch_back_to_stepped_thread): Update.
12527         (keep_going_pass_signal): Update.
12528         (print_exited_reason): Update.
12529         (normal_stop): Update.
12530         * inferior.c (inferior_pid_to_str): Change return type.
12531         (print_selected_inferior): Update.
12532         (add_inferior): Update.
12533         (detach_inferior): Update.
12534         * dummy-frame.c (fprint_dummy_frames): Update.
12535         * dcache.c (dcache_info_1): Update.
12536         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12537         (btrace_fetch, btrace_clear): Update.
12538         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12539         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12540         type.
12541         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12542         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12543         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12544         * gdbarch.c, gdbarch.h: Rebuild.
12545         * gdbarch.sh (core_pid_to_str): Change return type.
12546         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12547         return type.
12548         (windows_nat_target::pid_to_str): Change return type.
12549         (windows_delete_thread): Update.
12550         (windows_nat_target::attach): Update.
12551         (windows_nat_target::files_info): Update.
12552         * target-delegates.c: Rebuild.
12553         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12554         return type.
12555         (sol_thread_target::pid_to_str): Change return type.
12556         * remote.c (class remote_target) <pid_to_str>: Change return
12557         type.
12558         (remote_target::pid_to_str): Change return type.
12559         (extended_remote_target::attach, remote_target::remote_stop_ns)
12560         (remote_target::remote_notif_remove_queued_reply)
12561         (remote_target::push_stop_reply, remote_target::disable_btrace):
12562         Update.
12563         (extended_remote_target::attach): Update.
12564         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12565         type.
12566         (gdbsim_target::pid_to_str): Change return type.
12567         * ravenscar-thread.c (struct ravenscar_thread_target)
12568         <pid_to_str>: Change return type.
12569         (ravenscar_thread_target::pid_to_str): Change return type.
12570         * procfs.c (class procfs_target) <pid_to_str>: Change return
12571         type.
12572         (procfs_target::pid_to_str): Change return type.
12573         (procfs_target::attach): Update.
12574         (procfs_target::detach): Update.
12575         (procfs_target::fetch_registers): Update.
12576         (procfs_target::store_registers): Update.
12577         (procfs_target::wait): Update.
12578         (procfs_target::files_info): Update.
12579         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12580         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12581         return type.
12582         (nto_procfs_target::pid_to_str): Change return type.
12583         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12584         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12585         return type.
12586         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12587         (exit_lwp): Update.
12588         (attach_proc_task_lwp_callback, get_detach_signal)
12589         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12590         (linux_nat_target::resume, wait_lwp, stop_callback)
12591         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12592         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12593         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12594         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12595         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12596         type.
12597         (inf_ptrace_target::attach): Update.
12598         (inf_ptrace_target::files_info): Update.
12599         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12600         type.
12601         (go32_nat_target::pid_to_str): Change return type.
12602         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12603         (gnu_nat_target::wait): Update.
12604         (gnu_nat_target::wait): Update.
12605         (gnu_nat_target::resume): Update.
12606         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12607         (fbsd_nat_target::wait): Update.
12608         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12609         type.
12610         (darwin_nat_target::attach): Update.
12611         * corelow.c (class core_target) <pid_to_str>: Change return type.
12612         (core_target::pid_to_str): Change return type.
12613         * target.c (normal_pid_to_str): Change return type.
12614         (default_pid_to_str): Likewise.
12615         (target_pid_to_str): Change return type.
12616         (target_translate_tls_address): Update.
12617         (target_announce_detach): Update.
12618         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12619         return type.
12620         (bsd_uthread_target::pid_to_str): Change return type.
12621         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12622         type.
12623         (bsd_kvm_target::pid_to_str): Change return type.
12624         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12625         return type.
12626         (aix_thread_target::pid_to_str): Change return type.
12627         * target.h (struct target_ops) <pid_to_str>: Change return type.
12628         (target_pid_to_str, normal_pid_to_str): Likewise.
12629         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12630         type.
12631         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12632         type.
12633         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12634         return type.
12635         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12636         type.
12637         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12638         type.
12639         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12640         return type.
12641
12642 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12643
12644         * NEWS: Mention that the new default MI version is 3.  Mention
12645         changes to the output of commands and events that deal with
12646         multi-location breakpoints.
12647         * breakpoint.c: Include "mi/mi-out.h".
12648         (print_one_breakpoint): Change output syntax if using MI version
12649         >= 3.
12650         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12651         New.
12652         (mi_multi_location_breakpoint_output_fixed): New.
12653         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12654         (mi_cmd_fix_multi_location_breakpoint_output): New.
12655         (mi_multi_location_breakpoint_output_fixed): New.
12656         * mi/mi-cmds.c (mi_cmds): Register command
12657         -fix-multi-location-breakpoint-output.
12658         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12659         interpreter "mi".
12660
12661 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12662
12663         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12664         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12665         instantiate mi_ui_out based on interpreter name.
12666         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12667         * mi/mi-main.c (mi_load_progress): Likewise.
12668
12669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12670
12671         * NEWS: Combine separate "New targets" sections for 8.3.
12672
12673 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12674
12675         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12676         (ppcfbsd_init_abi): Install gdbarch
12677         "fetch_tls_load_module_address" and "get_thread_local_address"
12678         methods.
12679
12680 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12681
12682         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12683         (riscv_fbsd_init_abi): Install gdbarch
12684         "fetch_tls_load_module_address" and "get_thread_local_address"
12685         methods.
12686
12687 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12688
12689         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12690         (i386fbsd_init_abi): Install gdbarch
12691         "fetch_tls_load_module_address" and "get_thread_local_address"
12692         methods.
12693
12694 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12695
12696         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12697         (amd64fbsd_init_abi): Install gdbarch
12698         "fetch_tls_load_module_address" and "get_thread_local_address"
12699         methods.
12700
12701 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12702
12703         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12704         (struct fbsd_pspace_data): New type.
12705         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12706         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12707         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12708         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12709         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12710
12711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12712
12713         * gdbtypes.c (lookup_struct_elt): New function.
12714         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12715         * gdbtypes.h (struct struct_elt): New type.
12716         (lookup_struct_elt): New prototype.
12717
12718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12719
12720         * gdbtypes.c (lookup_struct_elt_type): Update comment and
12721         remove disabled code block.
12722
12723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12724
12725         * gdbarch.sh (get_thread_local_address): New method.
12726         * gdbarch.h, gdbarch.c: Regenerate.
12727         * target.c (target_translate_tls_address): Use
12728         gdbarch_get_thread_local_address if present instead of
12729         target::get_thread_local_address.
12730
12731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12732
12733         * target.h (target::get_thread_local_address): Update comment.
12734
12735 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12736
12737         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12738         objfile->separate_debug_objfile_backlink if not NULL.
12739
12740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12741
12742         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12743         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12744         (amd64bsd_store_inferior_registers): Likewise.
12745         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12746         Enable segment base registers.
12747         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12748         PT_GETFSBASE and PT_GETGSBASE.
12749         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12750         PT_SETGSBASE.
12751         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12752         segment base registers.
12753         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12754
12755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12756
12757         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12758         Update calls to i386_target_description to add 'segments'
12759         parameter.
12760         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
12761         add segment base registers.
12762         * arch/i386.c (i386_create_target_description): Add 'segments'
12763         parameter to enable segment base registers.
12764         * arch/i386.h (i386_create_target_description): Likewise.
12765         * features/i386/32bit-segments.xml: New file.
12766         * features/i386/32bit-segments.c: Generate.
12767         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12768         call to i386_target_description to add 'segments' parameter.
12769         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12770         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12771         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12772         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12773         if feature is present.
12774         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12775         Add 'segments' parameter to call to i386_target_description.
12776         (i386_target_description): Add 'segments' parameter to enable
12777         segment base registers.
12778         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12779         to call to i386_target_description.
12780         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12781         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12782         Define I386_NUM_REGS.
12783         (i386_target_description): Add 'segments' parameter to enable
12784         segment base registers.
12785
12786 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
12787
12788         PR/24325
12789         * source-cache.c: #undef open and close, to avoid unresolved
12790         externals during linking.
12791
12792 2019-03-12  Tom Tromey  <tromey@adacore.com>
12793
12794         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12795         const.  Add initializers.
12796         (_initialize_remote): Don't initialize ptid globals.
12797
12798 2019-03-12  Pedro Alves  <palves@redhat.com>
12799
12800         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12801
12802 2019-03-12  Pedro Alves  <palves@redhat.com>
12803
12804         * cp-name-parser.y (main): Remove unused 'len' variable.
12805
12806 2019-03-12  Tom Tromey  <tromey@adacore.com>
12807
12808         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12809         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12810
12811 2019-03-12  Tom Tromey  <tromey@adacore.com>
12812
12813         * linux-nat.c (iterate_over_lwps): Update.
12814         (stop_callback): Remove parameter.
12815         (stop_wait_callback, detach_callback, resume_set_callback)
12816         (select_singlestep_lwp_callback, set_ignore_sigint)
12817         (status_callback, resumed_callback, resume_clear_callback)
12818         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12819         data parameter.
12820         (linux_nat_target::detach, linux_nat_target::resume)
12821         (linux_stop_and_wait_all_lwps, select_event_lwp)
12822         (linux_nat_filter_event, linux_nat_wait_1)
12823         (linux_nat_target::kill, linux_nat_target::stop)
12824         (linux_nat_target::stop): Update.
12825         (linux_nat_resume_callback): Change type.
12826         (resume_stopped_resumed_lwps, count_events_callback)
12827         (select_event_lwp_callback): Likewise.
12828         (linux_stop_lwp, linux_nat_stop_lwp): Update.
12829         * arm-linux-nat.c (struct update_registers_data): Remove.
12830         (update_registers_callback): Change type.
12831         (arm_linux_insert_hw_breakpoint1): Update.
12832         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12833         parameter.
12834         (x86_linux_dr_set_addr): Update.
12835         (x86_linux_dr_set_control): Update.
12836         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12837         (iterate_over_lwps): Use gdb::function_view.
12838         * nat/aarch64-linux-hw-point.c (struct
12839         aarch64_dr_update_callback_param): Remove.
12840         (debug_reg_change_callback): Change type.
12841         (aarch64_notify_debug_reg_change): Update.
12842         * s390-linux-nat.c (s390_refresh_per_info): Update.
12843
12844 2019-03-11  Tom Tromey  <tromey@adacore.com>
12845
12846         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12847         redundant assignment to "this_cu".
12848
12849 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12850
12851         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12852
12853 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12854
12855         * gdbtypes.c (rank_one_type_parm_set): New function extracted
12856         from...
12857         (rank_one_type): ... this.
12858
12859 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12860
12861         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12862         from...
12863         (rank_one_type): ... this.
12864
12865 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12866
12867         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12868         from...
12869         (rank_one_type): ... this.
12870
12871 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12872
12873         * gdbtypes.c (rank_one_type_parm_float): New function extracted
12874         from...
12875         (rank_one_type): ... this.
12876
12877 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12878
12879         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12880         from...
12881         (rank_one_type): ... this.
12882
12883 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12884
12885         * gdbtypes.c (rank_one_type_parm_range): New function extracted
12886         from...
12887         (rank_one_type): ... this.
12888
12889 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12890
12891         * gdbtypes.c (rank_one_type_parm_char): New function extracted
12892         from...
12893         (rank_one_type): ... this.
12894
12895 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12896
12897         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12898         from...
12899         (rank_one_type): ... this.
12900
12901 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12902
12903         * gdbtypes.c (rank_one_type_parm_int): New function extracted
12904         from...
12905         (rank_one_type): ... this.
12906
12907 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12908
12909         * gdbtypes.c (rank_one_type_parm_func): New function extracted
12910         from...
12911         (rank_one_type): ... this.
12912
12913 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12914
12915         * gdbtypes.c (rank_one_type_parm_array): New function extracted
12916         from...
12917         (rank_one_type): ... this.
12918
12919 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12920
12921         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
12922         from...
12923         (rank_one_type): ... this.
12924
12925 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12926
12927         * inferior.c (initialize_inferiors): Ensure 'help set/show print
12928         inferior-events' shows the example events.
12929
12930 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
12931
12932         Support styling on native MS-Windows console
12933
12934         PR/24315
12935         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
12936         on MS-Windows if $TERM is not defined.
12937
12938         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
12939
12940         * posix-hdep.c (gdb_console_fputs):
12941         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
12942         functions.
12943         * ui-file.h (gdb_console_fputs): Add prototype.
12944
12945         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
12946         back to fputs only if the former returns zero.
12947
12948 2019-03-07  Tom Tromey  <tom@tromey.com>
12949
12950         * symmisc.c (print_symbol_bcache_statistics): Update.
12951         (print_objfile_statistics): Update.
12952         * symfile.c (allocate_symtab): Update.
12953         * stabsread.c: Don't include bcache.h.
12954         * psymtab.h (struct psymbol_bcache): Don't declare.
12955         (class psymtab_storage) <psymbol_cache>: Now a bcache.
12956         (psymbol_bcache_init, psymbol_bcache_free)
12957         (psymbol_bcache_get_bcache): Don't declare.
12958         * psymtab.c (struct psymbol_bcache): Remove.
12959         (psymtab_storage::psymtab_storage): Update.
12960         (psymtab_storage::~psymtab_storage): Update.
12961         (psymbol_bcache_init, psymbol_bcache_free)
12962         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12963         (add_psymbol_to_bcache): Update.
12964         (allocate_psymtab): Update.
12965         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
12966         macro_cache>: No longer pointers.
12967         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
12968         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
12969         * macrotab.c (macro_bcache): Update.
12970         * macroexp.c: Don't include bcache.h.
12971         * gdbtypes.c (check_types_worklist): Update.
12972         (types_deeply_equal): Remove TRY/CATCH.  Update.
12973         * elfread.c (elf_symtab_read): Update.
12974         * dwarf2read.c: Don't include bcache.h.
12975         * buildsym.c (buildsym_compunit::get_macro_table): Update.
12976         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
12977         (print_bcache_statistics, bcache_memory_used): Don't declare.
12978         (struct bcache): Move from bcache.c.  Add constructor, destructor,
12979         methods.  Rename all data members.
12980         * bcache.c (struct bcache): Move to bcache.h.
12981         (bcache::expand_hash_table): Rename from expand_hash_table.
12982         (bcache): Remove.
12983         (bcache::insert): Rename from bcache_full.
12984         (bcache::compare): Rename from bcache_compare.
12985         (bcache_xmalloc): Remove.
12986         (bcache::~bcache): Rename from bcache_xfree.
12987         (bcache::print_statistics): Rename from print_bcache_statistics.
12988         (bcache::memory_used): Rename from bcache_memory_used.
12989
12990 2019-03-07  Pedro Alves  <palves@redhat.com>
12991
12992         * infrun.c (normal_stop): Also check for
12993         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12994
12995 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
12996
12997         * f-lang.c (value_from_host_double): Moved to...
12998         * value.c (value_from_host_double): ...here.
12999         * value.h (value_from_host_double): Declare.
13000         * guile/scm-math.c (vlscm_convert_typed_number): Use
13001         value_from_host_double.
13002         (vlscm_convert_number): Likewise.
13003         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13004         * python/py-value.c (convert_value_from_python): Likewise.
13005
13006 2019-03-06  Tom Tromey  <tom@tromey.com>
13007
13008         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13009
13010 2019-03-06  Tom Tromey  <tom@tromey.com>
13011
13012         * utils.h (free_current_contents): Don't declare.
13013         * utils.c (free_current_contents): Remove.
13014
13015 2019-03-06  Tom Tromey  <tom@tromey.com>
13016
13017         * top.c (quit_force): Update.
13018         * main.c (captured_command_loop): Update.
13019         * common/new-op.c (operator new): Update.
13020         * common/common-exceptions.c (struct catcher)
13021         <save_cleanup_chain>: Remove member.
13022         (exceptions_state_mc_init): Update.
13023         (exception_try_scope_entry): Return nullptr.
13024         (exception_try_scope_exit, exception_rethrow)
13025         (throw_exception_sjlj, throw_exception_cxx): Update.
13026         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13027         (all_cleanups, do_cleanups, discard_cleanups)
13028         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13029         (restore_cleanups, restore_final_cleanups): Don't declare.
13030         (do_final_cleanups): Remove parameter.
13031         * common/cleanups.c (cleanup_chain, make_cleanup)
13032         (make_cleanup_dtor, all_cleanups, do_cleanups)
13033         (discard_my_cleanups, discard_cleanups)
13034         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13035         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13036         (null_cleanup): Remove.
13037         (do_final_cleanups): Remove parameter.
13038
13039 2019-03-06  Tom Tromey  <tom@tromey.com>
13040
13041         * remote.c (remote_target::remote_parse_stop_reply): Use
13042         unique_xmalloc_ptr.
13043
13044 2019-03-06  Tom Tromey  <tom@tromey.com>
13045
13046         * stabsread.c (struct stabs_field_info): Rename from field_info.
13047         <list, fnlist>: Add initializers.
13048         <obstack>: New member.
13049         (read_member_functions, read_struct_fields, read_baseclasses):
13050         Allocate on obstack.  Don't use cleanups.
13051         (read_one_struct_field, read_member_functions, read_struct_fields)
13052         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13053         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13054         (read_struct_type): Update.
13055
13056 2019-03-06  Tom Tromey  <tom@tromey.com>
13057
13058         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13059         * common/filestuff.h (make_cleanup_close): Don't declare.
13060         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13061         Remove.
13062
13063 2019-03-06  Tom Tromey  <tom@tromey.com>
13064
13065         * solib-aix.c: Use make_scope_exit.
13066
13067 2019-03-06  Tom Tromey  <tom@tromey.com>
13068
13069         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13070         Use make_scope_exit.
13071
13072 2019-03-06  Tom Tromey  <tom@tromey.com>
13073
13074         * solib-svr4.c (disable_probes_interface): Remove parameter.
13075         (svr4_handle_solib_event): Use make_scope_exit.
13076
13077 2019-03-06  Tom Tromey  <tom@tromey.com>
13078
13079         * remote.c (struct stop_reply_deleter): Remove.
13080         (stop_reply_up): Update.
13081         (struct stop_reply): Derive from notif_event.  Don't typedef.
13082         <regcache>: Now a std::vector.
13083         (stop_reply_xfree): Remove.
13084         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13085         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13086         (remote_target::discard_pending_stop_replies): Use delete.
13087         (remote_target::remote_parse_stop_reply): Update.
13088         (remote_target::process_stop_reply): Update.
13089         * remote-notif.h (struct notif_event): Add virtual destructor.
13090         Remove "dtr" member.
13091         (struct notif_client) <alloc_event>: Return a unique_ptr.
13092         (notif_event_xfree): Don't declare.
13093         (notif_event_up): New typedef.
13094         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13095         (notif_event_xfree, do_notif_event_xfree): Remove.
13096         (remote_notif_state_xfree): Update.
13097
13098 2019-03-06  Tom Tromey  <tom@tromey.com>
13099
13100         * infrun.c (displaced_step_clear_cleanup): Now a
13101         forward_scope_exit type.
13102         (displaced_step_prepare_throw): Update.
13103         (displaced_step_fixup): Update.
13104
13105 2019-03-06  Tom Tromey  <tom@tromey.com>
13106
13107         * inferior.h (class inferior): Update comment.
13108         * gdbthread.h (class thread_info): Update comment.
13109
13110 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13111             Tom Tromey  <tom@tromey.com>
13112
13113         * stabsread.h (struct stab_section_list): Remove.
13114         (coffstab_build_psymtabs): Update.
13115         * dbxread.c (symbuf_sections): Now a std::vector.
13116         (sect_idx): New global.
13117         (fill_symbuf): Update.
13118         (coffstab_build_psymtabs): Change type of stabsects parameter.
13119         Update.
13120         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13121         std::vector.
13122         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13123         (coff_locate_sections): Update.
13124         (coff_symfile_read): Remove cleanups.  Update.
13125         (init_stringtab): Add storage parameter.
13126         (free_stringtab, free_stringtab_cleanup): Remove.
13127         (init_lineno): Add storage parameter.
13128         (free_linetab, free_linetab_cleanup): Remove.
13129
13130 2019-03-06  Pedro Alves  <palves@redhat.com>
13131
13132         * linux-fork.c (fork_info::clobber_regs): Delete.
13133         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13134         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13135         comment.  Adjust.
13136         (scoped_switch_fork_info::scoped_switch_fork_info)
13137         (checkpoint_command, linux_fork_context): Adjust
13138         fork_save_infrun_state calls.
13139
13140 2019-03-06  Pedro Alves  <palves@redhat.com>
13141
13142         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13143         (inf_has_multiple_threads): Return 'bool' and rewrite using
13144         inferior_info::threads().
13145
13146 2019-03-06  Pedro Alves  <palves@redhat.com>
13147
13148         * linux-fork.c: Include <list>.
13149         (fork_list): Now a std::list instance.
13150         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13151         (forks_exist_p, find_last_fork): Adjust.
13152         (new_fork): Delete.
13153         (one_fork_p): New.
13154         (add_fork): Adjust.
13155         (free_fork): Delete, folded into fork_info::~fork_info().
13156         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13157         Adjust.
13158         (init_fork_list): Delete.
13159         (linux_fork_killall, linux_fork_mourn_inferior)
13160         (linux_fork_detach, info_checkpoints_command): Adjust.
13161         (_initialize_linux_fork): No longer call init_fork_list.
13162
13163 2019-03-06  Pedro Alves  <palves@redhat.com>
13164
13165         * linux-fork.c (new_fork): New, split out of ...
13166         (add_fork): ... this.  Return void.  Move "first fork" special
13167         case from here, to ...
13168         (checkpoint_command): ... here.
13169         * linux-linux.h (add_fork): Return void.
13170
13171 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13172
13173         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13174
13175 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13176             Chris January  <chris.january@arm.com>
13177             David Lecomber  <david.lecomber@arm.com>
13178
13179         * f-exp.y: New token, UNOP_INTRINSIC.
13180         (exp): New pattern using UNOP_INTRINSIC token.
13181         (f77_keywords): Add 'abs' keyword.
13182         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13183         (value_from_host_double): New function.
13184         (evaluate_subexp_f): Support UNOP_ABS.
13185
13186 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13187
13188         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13189         types.
13190
13191 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13192
13193         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13194         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13195         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13196
13197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13198
13199         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13200
13201 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13202             Chris January  <chris.january@arm.com>
13203
13204         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13205         * f-exp.y: Define 'KIND' token.
13206         (exp): New pattern for KIND expressions.
13207         (ptype): Handle types with a kind extension.
13208         (direct_abs_decl): Extend to spot kind extensions.
13209         (f77_keywords): Add 'kind' to the list.
13210         (push_kind_type): New function.
13211         (convert_to_kind_type): New function.
13212         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13213         * parse.c (operator_length_standard): Likewise.
13214         * parser-defs.h (enum type_pieces): Add tp_kind.
13215         * std-operator.def: Add UNOP_KIND.
13216
13217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13218
13219         * f-exp.y (f_parse): Set yydebug.
13220
13221 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13222
13223         * f-lang.c (evaluate_subexp_f): New function.
13224         (exp_descriptor_f): New global.
13225         (f_language_defn): Use exp_descriptor_f instead of
13226         exp_descriptor_standard.
13227
13228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13229
13230         * f-exp.y (struct token): Add comments.
13231         (dot_ops): Remove uppercase versions and the end marker.
13232         (f77_keywords): Likewise.
13233         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13234         entries in the dot_ops array are case insensitive, and use
13235         strncasecmp to compare strings.  Also some whitespace cleanup in
13236         this area.  Similar for the f77_keywords array, except entries in
13237         this list might be case sensitive.
13238
13239 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13240
13241         * f-exp.y (struct f77_boolean_val): Add comments.
13242         (boolean_values): Remove uppercase versions, and end marker.
13243         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13244         and use strncasecmp to achieve case insensitivity.  Additionally,
13245         perform whitespace cleanup around this code.
13246
13247 2019-03-06  Tom Tromey  <tromey@adacore.com>
13248
13249         * remote-sim.c (gdbsim_target_open): Use result of
13250         gdb_argv::release.
13251
13252 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13253         Dirk Schubert  <dirk.schubert@arm.com>
13254         Chris January  <chris.january@arm.com>
13255
13256         * eval.c (evaluate_subexp_standard): Call Fortran argument
13257         wrapping logic.
13258         * f-lang.c (struct value): A value which can be passed into a
13259         Fortran function call.
13260         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13261         where appropriate.
13262         (struct type): Value ready for a Fortran function call.
13263         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13264         is needed.
13265         * f-lang.h (fortran_argument_convert): Declaration.
13266         (fortran_preserve_arg_pointer): Declaration.
13267         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13268
13269 2019-03-05  Tom Tromey  <tromey@adacore.com>
13270
13271         * python/py-prettyprint.c (print_string_repr): Remove #if.
13272         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13273
13274 2019-03-05  Tom Tromey  <tromey@adacore.com>
13275
13276         * target.c (the_dummy_target): Move later.  Change type to
13277         "dummy_target".
13278         (initialize_targets): Don't initialize the_dummy_target.
13279
13280 2019-03-05  Tom Tromey  <tromey@adacore.com>
13281
13282         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13283         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13284
13285 2019-03-05  Tom Tromey  <tromey@adacore.com>
13286
13287         * windows-nat.c (windows_nat_target::attach)
13288         (windows_nat_target::detach): Don't call gdb_flush.
13289         * valprint.c (generic_val_print, val_print, val_print_string):
13290         Don't call gdb_flush.
13291         * utils.c (defaulted_query): Don't call gdb_flush.
13292         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13293         * target.c (target_announce_detach): Don't call gdb_flush.
13294         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13295         * remote.c (extended_remote_target::attach): Don't call
13296         gdb_flush.
13297         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13298         * printcmd.c (do_examine): Don't call gdb_flush.
13299         (info_display_command): Don't call gdb_flush.
13300         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13301         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13302         * memattr.c (info_mem_command): Don't call gdb_flush.
13303         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13304         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13305         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13306         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13307         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13308         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13309         (gnu_nat_target::detach): Don't call gdb_flush.
13310         * f-valprint.c (f_val_print): Don't call gdb_flush.
13311         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13312         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13313         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13314         gdb_flush.
13315         * c-valprint.c (c_val_print): Don't call gdb_flush.
13316         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13317
13318 2019-03-05  Tom Tromey  <tromey@adacore.com>
13319
13320         * varobj.c (update_dynamic_varobj_children): Update.
13321         (install_default_visualizer): Use reset, not release.
13322         * value.c (set_internalvar): Update.
13323         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13324         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13325         ATTRIBUTE_UNUSED_RESULT.
13326
13327 2019-03-05  Tom Tromey  <tromey@adacore.com>
13328
13329         * remote.c (class scoped_remote_fd) <release>: Add
13330         ATTRIBUTE_UNUSED_RESULT.
13331
13332 2019-03-05  Tom Tromey  <tromey@adacore.com>
13333
13334         * macroexp.c (struct macro_buffer) <release>: Add
13335         ATTRIBUTE_UNUSED_RESULT.
13336
13337 2019-03-05  Tom Tromey  <tromey@adacore.com>
13338
13339         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13340         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13341         ATTRIBUTE_UNUSED_RESULT.
13342
13343 2019-03-05  Tom Tromey  <tromey@adacore.com>
13344
13345         * common/scoped_fd.h (class scoped_fd) <release>: Add
13346         ATTRIBUTE_UNUSED_RESULT.
13347
13348 2019-03-05  Tom Tromey  <tromey@adacore.com>
13349
13350         * parser-defs.h (struct parser_state) <release>: Add
13351         ATTRIBUTE_UNUSED_RESULT.
13352
13353 2019-03-05  Tom Tromey  <tromey@adacore.com>
13354
13355         * utils.h (class gdb_argv) <release>: Add
13356         ATTRIBUTE_UNUSED_RESULT.
13357         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13358
13359 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13360
13361         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13362         for-loop range, to avoid compiler warnings.
13363
13364         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13365         avoid compiler warnings about unused variables.
13366
13367         * NEWS: Mention end of support for native debugging on MS-Windows
13368         before XP.
13369
13370         PR gdb/24292
13371         * common/netstuff.c:
13372         * gdbserver/gdbreplay.c
13373         * gdbserver/remote-utils.c:
13374         * ser-tcp.c:
13375         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13376         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13377         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13378         'getaddrinfo' and 'freeaddrinfo' were not available before
13379         Windows XP, and mingw.org's MinGW headers by default define
13380         _WIN32_WINNT to 0x500.
13381
13382 2019-03-01  Gary Benson <gbenson@redhat.com>
13383
13384         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13385
13386 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13387             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13388
13389         PR gdb/8527
13390         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13391         set_sigint_trap, clear_sigint_trap.
13392
13393 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13394
13395         * target.c (target_detach): Clear the regcache and the
13396         frame cache.
13397
13398 2019-02-27  Pedro Alves  <palves@redhat.com>
13399
13400         * utils.c (set_screen_size): When we cap the height/width sizes,
13401         tweak the corresponding command variable to show "unlimited":
13402
13403 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13404             Pedro Alves  <palves@redhat.com>
13405
13406         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13407         before calling rl_set_screen_size.
13408
13409 2019-02-27  Tom Tromey  <tromey@adacore.com>
13410
13411         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13412         define.
13413         * python/py-value.c: Remove Python 2.4 workaround.
13414         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13415         workaround.
13416         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13417         Python 2.4 workaround.
13418         * python/python-internal.h: Remove Python 2.4 comment.
13419         (Py_ssize_t): Don't define.
13420         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13421         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13422         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13423         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13424         * python/python.c (do_start_initialization): Remove Python 2.4
13425         workaround.
13426         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13427         (print_children): Remove Python 2.4 workaround.
13428         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13429         workaround.
13430         (CHARBUFFERPROC_NAME): Remove.
13431         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13432         Python 2.4 workaround.
13433
13434 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13435
13436         * NEWS: Note minimum Python version.
13437
13438 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13439
13440         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13441         code from these functions.  Remove corresponding ifdefs.  Use
13442         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13443         Remove gotos and target of gotos.
13444         (infpy_search_memory): Likewise.
13445
13446 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13447
13448         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13449         (hppa_gdbarch_init): Don't register deleted functions with
13450         gdbarch.
13451
13452 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13453
13454         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13455         (h8300_unwind_sp): Delete.
13456         (h8300_dummy_id): Delete.
13457         (h8300_gdbarch_init): Don't register deleted functions with
13458         gdbarch.
13459
13460 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13461
13462         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13463         (ft32_unwind_pc): Delete.
13464         (ft32_unwind_sp): Delete.
13465         (ft32_gdbarch_init): Don't register deleted functions with
13466         gdbarch.
13467
13468 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13469
13470         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13471         (frv_unwind_pc): Delete.
13472         (frv_unwind_sp): Delete.
13473         (frv_gdbarch_init): Don't register deleted functions with
13474         gdbarch.
13475
13476 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13477
13478         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13479         (riscv_unwind_pc): Delete.
13480         (riscv_unwind_sp): Delete.
13481         (riscv_gdbarch_init): Don't register deleted functions with
13482         gdbarch.
13483
13484 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13485
13486         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13487         (csky_unwind_pc): Delete.
13488         (csky_unwind_sp): Delete.
13489         (csky_gdbarch_init): Don't register deleted functions with
13490         gdbarch.
13491
13492 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13493
13494         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13495         (cris_unwind_pc): Delete.
13496         (cris_unwind_sp): Delete.
13497         (cris_gdbarch_init): Don't register deleted functions with
13498         gdbarch.
13499
13500 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13501
13502         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13503         (bfin_unwind_pc): Delete.
13504         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13505
13506 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13507
13508         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13509         (arm_unwind_pc): Delete.
13510         (arm_unwind_sp): Delete.
13511         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13512
13513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13514
13515         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13516         (arc_unwind_pc): Delete.
13517         (arc_unwind_sp): Delete.
13518         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13519
13520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13521
13522         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13523         (alpha_unwind_pc): Delete.
13524         (alpha_gdbarch_init): Don't register deleted functions with
13525         gdbarch.
13526
13527 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13528
13529         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13530         (aarch64_unwind_pc): Delete.
13531         (aarch64_unwind_sp): Delete.
13532         (aarch64_gdbarch_init): Don't register deleted functions with
13533         gdbarch.
13534
13535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13536
13537         * gdbtypes.c (type_align): Don't consider static members when
13538         computing structure alignment.
13539
13540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13541
13542         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13543         return 0 for other types.
13544         * arch-utils.c (default_type_align): Always return 0.
13545         * gdbarch.h: Regenerate.
13546         * gdbarch.sh (type_align): Extend comment.
13547         * gdbtypes.c (type_align): Add additional comments, always call
13548         gdbarch_type_align before applying the default rules.
13549         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13550         generic code will then apply a suitable default.
13551         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13552         types, return 0 for other types.
13553
13554 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13555
13556         * NEWS: Create a new section for the next release branch.
13557         Rename the section of the current branch, now that it has
13558         been cut.
13559
13560 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13561
13562         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13563         * version.in: Bump version to 8.3.50.DATE-git.
13564
13565 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13566
13567         * aix-thread.c (ptid_cmp): Remove unused variable.
13568         (get_signaled_thread): Likewise.
13569         (store_regs_user_thread): Likewise.
13570         (store_regs_kernel_thread): Likewise.
13571         (fetch_regs_kernel_thread): Remove shadowed variable.
13572
13573 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13574
13575         * features/riscv/32bit-cpu.xml: Add register numbers.
13576         * features/riscv/32bit-fpu.c: Regenerate.
13577         * features/riscv/32bit-fpu.xml: Add register numbers.
13578         * features/riscv/64bit-cpu.xml: Add register numbers.
13579         * features/riscv/64bit-fpu.c: Regenerate.
13580         * features/riscv/64bit-fpu.xml: Add register numbers.
13581
13582 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13583
13584         * NEWS: Mention two argument form of gdb.Value constructor.
13585         * python/py-value.c (convert_buffer_and_type_to_value): New
13586         function.
13587         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13588         Add support for handling an optional second argument.  Call
13589         convert_buffer_and_type_to_value as appropriate.
13590         * python/python-internal.h (Py_buffer_deleter): New struct.
13591         (Py_buffer_up): New typedef.
13592
13593 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13594
13595         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13596         instead of releasing ownership.
13597
13598 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13599
13600         * dwarf2read.c (open_and_init_dwp_file): Call
13601         elf_numsections instead of bfd_count_sections to initialize
13602         dwp_file->num_sections.
13603
13604 2019-02-25  Tom Tromey  <tromey@adacore.com>
13605
13606         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13607
13608 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13609
13610         * gcore.in: Add '--readnever' option when invoking GDB.
13611
13612 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13613
13614         * MAINTAINERS: Update my email address.
13615
13616 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13617
13618         * build-id.c (build_id_to_debug_bfd_1): New function.
13619         (build_id_to_debug_bfd): Look for separate debug file in
13620         sysroot.
13621
13622 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13623
13624         * gdbarch.sh: Update the copyright year range that is placed into
13625         generated files.
13626
13627 2019-02-22  Keith Seitz  <keiths@redhat.com>
13628
13629         PR symtab/23853
13630         * linespec.c (create_sals_line_offset): Search for the default
13631         symtab's filename instead of its fullname.
13632
13633 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13634
13635         * NEWS: Update style defaults.
13636
13637 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13638
13639         * main.c (captured_main_1): Disable styling in batch mode.
13640
13641 2019-02-20  Tom Tromey  <tom@tromey.com>
13642
13643         * symtab.c (symtab_symbol_info): Fix typos.
13644
13645 2019-02-20  Tom Tromey  <tromey@adacore.com>
13646
13647         * findcmd.c (_initialize_mem_search): Use upper case for
13648         metasyntactic variables.
13649
13650 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13651
13652         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13653         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13654
13655 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13656
13657         * top.h (source_file_name): Change to std::string.
13658         * top.c (source_file_name): Likewise.
13659         (command_line_input): Adjust.
13660         * cli/cli-script.c (script_from_file): Adjust.
13661
13662 2019-02-19  Tom Tromey  <tromey@adacore.com>
13663
13664         * ravenscar-thread.c
13665         (ravenscar_thread_target::update_thread_list): Don't call
13666         ada_build_task_list.
13667         * ada-lang.h (ada_build_task_list): Don't declare.
13668         * ada-tasks.c (struct ada_tasks_inferior_data)
13669         <task_list_valid_p>: Now bool.
13670         (read_known_tasks, ada_task_list_changed)
13671         (ada_tasks_invalidate_inferior_data): Update.
13672         (read_known_tasks_array): Return bool.
13673         (read_known_tasks_list): Likewise.
13674         (read_known_tasks): Return void.
13675         (ada_build_task_list): Now static.
13676
13677 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
13678
13679         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13680         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13681
13682 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13683
13684         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13685         variant for ada_tasks_pspace_data_handle and
13686         ada_tasks_inferior_data_handle.
13687         (ada_tasks_pspace_data_cleanup): New function.
13688         (ada_tasks_inferior_data_cleanup): New function.
13689
13690 2019-02-17  Tom Tromey  <tom@tromey.com>
13691
13692         * macrotab.h (macro_source_fullname): Return a std::string.
13693         * macrotab.c (macro_include, check_for_redefinition)
13694         (macro_undef, macro_lookup_definition, foreach_macro)
13695         (foreach_macro_in_scope): Update.
13696         (macro_source_fullname): Return a std::string.
13697         * macrocmd.c (show_pp_source_pos): Update.
13698
13699 2019-02-17  Tom Tromey  <tom@tromey.com>
13700
13701         * macrocmd.c (show_pp_source_pos): Style the file names.
13702
13703 2019-02-17  Tom Tromey  <tom@tromey.com>
13704
13705         PR tui/24197:
13706         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13707
13708 2019-02-17  Tom Tromey  <tom@tromey.com>
13709
13710         * ada-lang.c (user_select_syms): Use filtered printing.
13711         * utils.c (wrap_style): New global.
13712         (desired_style): Remove.
13713         (emit_style_escape): Add stream parameter.
13714         (set_output_style, reset_terminal_style, prompt_for_continue):
13715         Update.
13716         (flush_wrap_buffer): Only flush gdb_stdout.
13717         (wrap_here): Set wrap_style.
13718         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
13719         treat escape sequences as a character.  Change when wrap buffer is
13720         flushed.
13721         (fputs_styled): Do not set the output style when the default is
13722         requested.
13723         * ui-style.h (struct ui_file_style) <is_default>: New method.
13724         * source.c (print_source_lines_base): Emit escape sequences in one
13725         piece.
13726
13727 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13728
13729         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13730         integers and enumeration types.
13731
13732 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13733
13734         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13735         instead of lookup_symbol_in_language
13736         (do_exact_match): New function.
13737         (ada_get_symbol_name_matcher): Return do_exact_match when
13738         doing a verbatim match.
13739
13740 2019-02-15  Tom Tromey  <tromey@adacore.com>
13741
13742         * ravenscar-thread.c (ravenscar_thread_target::resume)
13743         (ravenscar_thread_target::wait): Special case wildcard requests.
13744
13745 2019-02-15  Tom Tromey  <tromey@adacore.com>
13746
13747         * ravenscar-thread.c (base_ptid): Remove.
13748         (struct ravenscar_thread_target) <close>: New method.
13749         <m_base_ptid>: New member.
13750         <update_inferior_ptid, active_task, task_is_currently_active,
13751         runtime_initialized>: Declare methods.
13752         <ravenscar_thread_target>: Add constructor.
13753         (ravenscar_thread_target::task_is_currently_active)
13754         (ravenscar_thread_target::update_inferior_ptid)
13755         (ravenscar_runtime_initialized): Rename.  Now methods.
13756         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13757         (ravenscar_thread_target::update_thread_list): Update.
13758         (ravenscar_thread_target::active_task): Now method.
13759         (ravenscar_thread_target::store_registers)
13760         (ravenscar_thread_target::prepare_to_store)
13761         (ravenscar_thread_target::prepare_to_store)
13762         (ravenscar_thread_target::mourn_inferior): Update.
13763         (ravenscar_inferior_created): Use "new" to create target.
13764         (ravenscar_thread_target::get_ada_task_ptid): Update.
13765         (_initialize_ravenscar): Don't initialize base_ptid.
13766         (ravenscar_ops): Remove global.
13767
13768 2019-02-15  Tom Tromey  <tromey@adacore.com>
13769
13770         * target.h (push_target): Declare new overload.
13771         * target.c (push_target): New overload, taking an rvalue reference.
13772         * remote.c (remote_target::open_1): Use push_target overload.
13773         * corelow.c (core_target_open): Use push_target overload.
13774
13775 2019-02-15  Tom Tromey  <tromey@adacore.com>
13776
13777         * ravenscar-thread.c (is_ravenscar_task)
13778         (ravenscar_task_is_currently_active): Return bool.
13779         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13780         (_initialize_ravenscar): Remove "(void)".
13781         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13782         Return bool.
13783
13784 2019-02-15  Tom Tromey  <tromey@adacore.com>
13785
13786         * ravenscar-thread.c (ravenscar_runtime_initializer)
13787         (has_ravenscar_runtime, get_running_thread_id)
13788         (ravenscar_thread_target::resume): Fix indentation.
13789
13790 2019-02-15  Tom Tromey  <tromey@adacore.com>
13791
13792         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13793         from ravenscar_arch_ops.
13794         (sparc_ravenscar_ops::fetch_registers)
13795         (sparc_ravenscar_ops::store_registers): Now methods.
13796         (sparc_ravenscar_prepare_to_store): Remove.
13797         (sparc_ravenscar_ops): Redefine.
13798         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13799         methods and destructor.  Remove members.
13800         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13801         (ravenscar_thread_target::store_registers)
13802         (ravenscar_thread_target::prepare_to_store): Update.
13803         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13804         Remove.
13805         (struct ppc_ravenscar_powerpc_ops): Derive from
13806         ravenscar_arch_ops.
13807         (ppc_ravenscar_powerpc_ops::fetch_registers)
13808         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13809         (ppc_ravenscar_powerpc_ops): Redefine.
13810         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13811         (ppc_ravenscar_e500_ops::fetch_registers)
13812         (ppc_ravenscar_e500_ops::store_registers): Now methods.
13813         (ppc_ravenscar_e500_ops): Redefine.
13814         * aarch64-ravenscar-thread.c
13815         (aarch64_ravenscar_generic_prepare_to_store): Remove.
13816         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13817         (aarch64_ravenscar_fetch_registers)
13818         (aarch64_ravenscar_store_registers): Now methods.
13819         (aarch64_ravenscar_ops): Redefine.
13820
13821 2019-02-15  Tom Tromey  <tromey@adacore.com>
13822
13823         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13824         (ravenscar_thread_target::stopped_by_hw_breakpoint)
13825         (ravenscar_thread_target::stopped_by_watchpoint)
13826         (ravenscar_thread_target::stopped_data_address)
13827         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13828
13829 2019-02-15  Tom Tromey  <tromey@adacore.com>
13830
13831         * ravenscar-thread.c: Fix some typos.
13832
13833 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13834             Tom Tromey  <tromey@adacore.com>
13835
13836         * ada-lang.c (ada_exception_sal): Change addr_string to a
13837         std::string.
13838         (create_ada_exception_catchpoint): Update.
13839
13840 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13841             Tom Tromey  <tromey@adacore.com>
13842
13843         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13844         (bp_location_ops): Remove.
13845         (base_breakpoint_allocate_location): Update.
13846         (free_bp_location): Update.
13847         * ada-lang.c (class ada_catchpoint_location)
13848         <ada_catchpoint_location>: Remove ops parameter.
13849         (ada_catchpoint_location_dtor): Remove.
13850         (ada_catchpoint_location_ops): Remove.
13851         (allocate_location_exception): Update.
13852         * breakpoint.h (struct bp_location_ops): Remove.
13853         (class bp_location) <bp_location>: Remove bp_location_ops
13854         parameter.
13855         <~bp_location>: Add destructor.
13856         <ops>: Remove.
13857
13858 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13859             Pedro Alves  <palves@redhat.com>
13860
13861         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13862         'PATH_MAX'.
13863
13864 2019-02-14  David Michael  <fedora.dm0@gmail.com>
13865             Samuel Thibault  <samuel.thibault@gnu.org>
13866             Thomas Schwinge  <thomas@codesourcery.com>
13867
13868         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13869         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13870
13871 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13872
13873         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13874         (check_empty): Use "const char *".
13875
13876         * gnu-nat.c (gnu_nat_target::detach): Instead of
13877         'detach_inferior (pid)' call
13878         'detach_inferior (find_inferior_pid (pid))'.
13879
13880         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13881         'nat/fork-inferior.o'.
13882         * gnu-nat.c: #include "nat/fork-inferior.h".
13883
13884         * gnu-nat.c (gnu_nat_target::detach): Instead of
13885         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13886         * gnu-nat.h: #include "inf-child.h".
13887         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13888         'i386_gnu_nat_target::fetch_registers'.
13889         (gnu_store_registers): Rename/move to
13890         'i386_gnu_nat_target::store_registers'.
13891
13892         * config/i386/nm-i386gnu.h: Don't "#include" any files.
13893         * gnu-nat.h (mach_thread_info): New function.
13894         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13895
13896         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13897
13898 2019-02-14  Frederic Konrad  <konrad@adacore.com>
13899
13900         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
13901
13902 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
13903
13904         * windows-nat.c (windows_add_thread): Add new parameter
13905         "main_thread_p" with default value set to false.  Update
13906         function documentation as well as all callers.
13907         (windows_delete_thread): Likewise.
13908         (fake_create_process): Update call to windows_add_thread.
13909         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
13910         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
13911         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
13912         call to windows_delete_thread.
13913
13914 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
13915
13916         * MAINTAINERS: Add Andrew Burgess as global maintainer.
13917
13918 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13919
13920         * symfile.c (find_separate_debug_file): Use canonical path of
13921         sysroot with child_path instead of gdb_sysroot if it is valid.
13922
13923 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13924
13925         * symfile.c (find_separate_debug_file): Use child_path to
13926         determine if an object file is under a sysroot.
13927
13928 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13929
13930         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
13931         unittests/child-path-selftests.c.
13932         * common/pathstuff.c (child_path): New function.
13933         * common/pathstuff.h (child_path): New prototype.
13934         * unittests/child-path-selftests.c: New file.
13935
13936 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13937
13938         * symfile.c (find_separate_debug_file): Look for separate debug
13939         files in debug directories under the sysroot.
13940
13941 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13942
13943         * symtab.h (struct minimal_symbol data_p): New const method.
13944         (struct minimal_symbol text_p): Likewise.
13945         * symtab.c (output_source_filename): Use file name style
13946         to print file name.
13947         (print_symbol_info): Likewise.
13948         (print_msymbol_info): Use address style to print addresses.
13949         Use function name style to print executable text symbols.
13950         (expand_symtab_containing_pc): Use data_p.
13951         (find_pc_sect_compunit_symtab): Likewise.
13952
13953 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13954
13955         * breakpoint.c (describe_other_breakpoints): Use address style
13956         to print addresses.
13957         (say_where): Likewise.
13958
13959 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13960
13961         * ada-typeprint.c (print_func_type): Print function name
13962         style to print function name.
13963         * c-typeprint.c (c_print_type_1): Likewise.
13964
13965 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
13966
13967         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
13968         for execve.
13969
13970 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13971
13972         * c-exp.y (direct_abs_decl): Use emplace_back to record the
13973         type_stack.
13974
13975 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
13976
13977         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
13978         TYPE_CODE_REF types.
13979
13980 2019-02-08  Jim Wilson  <jimw@sifive.com>
13981
13982         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
13983         (riscv_linux_fregset): New.
13984         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
13985
13986 2019-02-07  Tom Tromey  <tom@tromey.com>
13987
13988         * thread.c (thread_cancel_execution_command): Update.
13989         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13990         methods.
13991         (struct thread_fsm_ops): Remove.
13992         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13993         (thread_fsm_should_stop, thread_fsm_return_value)
13994         (thread_fsm_set_finished, thread_fsm_finished_p)
13995         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13996         Don't declare.
13997         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13998         * infrun.c (clear_proceed_status_thread)
13999         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14000         (print_stop_event): Update.
14001         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14002         Add constructor.
14003         (step_command_fsm_ops): Remove.
14004         (new_step_command_fsm): Remove.
14005         (step_1): Update.
14006         (step_command_fsm::should_stop): Rename from
14007         step_command_fsm_should_stop.
14008         (step_command_fsm::clean_up): Rename from
14009         step_command_fsm_clean_up.
14010         (step_command_fsm::do_async_reply_reason): Rename from
14011         step_command_fsm_async_reply_reason.
14012         (struct until_next_fsm): Inherit from thread_fsm.  Add
14013         constructor.
14014         (until_next_fsm_ops): Remove.
14015         (new_until_next_fsm): Remove.
14016         (until_next_fsm::should_stop): Rename from
14017         until_next_fsm_should_stop.
14018         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14019         (until_next_fsm::do_async_reply_reason): Rename from
14020         until_next_fsm_async_reply_reason.
14021         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14022         constructor.  Change type of breakpoint.
14023         (finish_command_fsm_ops): Remove.
14024         (new_finish_command_fsm): Remove.
14025         (finish_command_fsm::should_stop): Rename from
14026         finish_command_fsm_should_stop.
14027         (finish_command_fsm::clean_up): Rename from
14028         finish_command_fsm_clean_up.
14029         (finish_command_fsm::return_value): Rename from
14030         finish_command_fsm_return_value.
14031         (finish_command_fsm::do_async_reply_reason): Rename from
14032         finish_command_fsm_async_reply_reason.
14033         (finish_command): Update.
14034         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14035         Add constructor.
14036         (call_thread_fsm_ops): Remove.
14037         (call_thread_fsm::call_thread_fsm): Rename from
14038         new_call_thread_fsm.
14039         (call_thread_fsm::should_stop): Rename from
14040         call_thread_fsm_should_stop.
14041         (call_thread_fsm::should_notify_stop): Rename from
14042         call_thread_fsm_should_notify_stop.
14043         (run_inferior_call, call_function_by_hand_dummy): Update.
14044         * cli/cli-interp.c (should_print_stop_to_console): Update.
14045         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14046         Add constructor.  Change type of location_breakpoint,
14047         caller_breakpoint.
14048         (until_break_fsm_ops): Remove.
14049         (new_until_break_fsm): Remove.
14050         (until_break_fsm::should_stop): Rename from
14051         until_break_fsm_should_stop.
14052         (until_break_fsm::clean_up): Rename from
14053         until_break_fsm_clean_up.
14054         (until_break_fsm::do_async_reply_reason): Rename from
14055         until_break_fsm_async_reply_reason.
14056         (until_break_command): Update.
14057         * thread-fsm.c: Remove.
14058         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14059
14060 2019-02-07  Tom Tromey  <tom@tromey.com>
14061
14062         * yy-remap.h: Add include guard.
14063         * xtensa-tdep.h: Add include guard.
14064         * xcoffread.h: Rename include guard.
14065         * varobj-iter.h: Add include guard.
14066         * tui/tui.h: Rename include guard.
14067         * tui/tui-winsource.h: Rename include guard.
14068         * tui/tui-wingeneral.h: Rename include guard.
14069         * tui/tui-windata.h: Rename include guard.
14070         * tui/tui-win.h: Rename include guard.
14071         * tui/tui-stack.h: Rename include guard.
14072         * tui/tui-source.h: Rename include guard.
14073         * tui/tui-regs.h: Rename include guard.
14074         * tui/tui-out.h: Rename include guard.
14075         * tui/tui-layout.h: Rename include guard.
14076         * tui/tui-io.h: Rename include guard.
14077         * tui/tui-hooks.h: Rename include guard.
14078         * tui/tui-file.h: Rename include guard.
14079         * tui/tui-disasm.h: Rename include guard.
14080         * tui/tui-data.h: Rename include guard.
14081         * tui/tui-command.h: Rename include guard.
14082         * tic6x-tdep.h: Add include guard.
14083         * target/waitstatus.h: Rename include guard.
14084         * target/wait.h: Rename include guard.
14085         * target/target.h: Rename include guard.
14086         * target/resume.h: Rename include guard.
14087         * target-float.h: Rename include guard.
14088         * stabsread.h: Add include guard.
14089         * rs6000-tdep.h: Add include guard.
14090         * riscv-fbsd-tdep.h: Add include guard.
14091         * regformats/regdef.h: Rename include guard.
14092         * record.h: Rename include guard.
14093         * python/python.h: Rename include guard.
14094         * python/python-internal.h: Rename include guard.
14095         * python/py-stopevent.h: Rename include guard.
14096         * python/py-ref.h: Rename include guard.
14097         * python/py-record.h: Rename include guard.
14098         * python/py-record-full.h: Rename include guard.
14099         * python/py-record-btrace.h: Rename include guard.
14100         * python/py-instruction.h: Rename include guard.
14101         * python/py-events.h: Rename include guard.
14102         * python/py-event.h: Rename include guard.
14103         * procfs.h: Add include guard.
14104         * proc-utils.h: Add include guard.
14105         * p-lang.h: Add include guard.
14106         * or1k-tdep.h: Rename include guard.
14107         * observable.h: Rename include guard.
14108         * nto-tdep.h: Rename include guard.
14109         * nat/x86-linux.h: Rename include guard.
14110         * nat/x86-linux-dregs.h: Rename include guard.
14111         * nat/x86-gcc-cpuid.h: Add include guard.
14112         * nat/x86-dregs.h: Rename include guard.
14113         * nat/x86-cpuid.h: Rename include guard.
14114         * nat/ppc-linux.h: Rename include guard.
14115         * nat/mips-linux-watch.h: Rename include guard.
14116         * nat/linux-waitpid.h: Rename include guard.
14117         * nat/linux-ptrace.h: Rename include guard.
14118         * nat/linux-procfs.h: Rename include guard.
14119         * nat/linux-osdata.h: Rename include guard.
14120         * nat/linux-nat.h: Rename include guard.
14121         * nat/linux-namespaces.h: Rename include guard.
14122         * nat/linux-btrace.h: Rename include guard.
14123         * nat/glibc_thread_db.h: Rename include guard.
14124         * nat/gdb_thread_db.h: Rename include guard.
14125         * nat/gdb_ptrace.h: Rename include guard.
14126         * nat/fork-inferior.h: Rename include guard.
14127         * nat/amd64-linux-siginfo.h: Rename include guard.
14128         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14129         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14130         * nat/aarch64-linux.h: Rename include guard.
14131         * nat/aarch64-linux-hw-point.h: Rename include guard.
14132         * mn10300-tdep.h: Add include guard.
14133         * mips-linux-tdep.h: Add include guard.
14134         * mi/mi-parse.h: Rename include guard.
14135         * mi/mi-out.h: Rename include guard.
14136         * mi/mi-main.h: Rename include guard.
14137         * mi/mi-interp.h: Rename include guard.
14138         * mi/mi-getopt.h: Rename include guard.
14139         * mi/mi-console.h: Rename include guard.
14140         * mi/mi-common.h: Rename include guard.
14141         * mi/mi-cmds.h: Rename include guard.
14142         * mi/mi-cmd-break.h: Rename include guard.
14143         * m2-lang.h: Add include guard.
14144         * location.h: Rename include guard.
14145         * linux-record.h: Rename include guard.
14146         * linux-nat.h: Add include guard.
14147         * linux-fork.h: Add include guard.
14148         * i386-darwin-tdep.h: Rename include guard.
14149         * hppa-linux-offsets.h: Add include guard.
14150         * guile/guile.h: Rename include guard.
14151         * guile/guile-internal.h: Rename include guard.
14152         * gnu-nat.h: Rename include guard.
14153         * gdb-stabs.h: Rename include guard.
14154         * frv-tdep.h: Add include guard.
14155         * f-lang.h: Add include guard.
14156         * event-loop.h: Add include guard.
14157         * darwin-nat.h: Rename include guard.
14158         * cp-abi.h: Rename include guard.
14159         * config/sparc/nm-sol2.h: Rename include guard.
14160         * config/nm-nto.h: Rename include guard.
14161         * config/nm-linux.h: Add include guard.
14162         * config/i386/nm-i386gnu.h: Rename include guard.
14163         * config/djgpp/nl_types.h: Rename include guard.
14164         * config/djgpp/langinfo.h: Rename include guard.
14165         * compile/gcc-cp-plugin.h: Add include guard.
14166         * compile/gcc-c-plugin.h: Add include guard.
14167         * compile/compile.h: Rename include guard.
14168         * compile/compile-object-run.h: Rename include guard.
14169         * compile/compile-object-load.h: Rename include guard.
14170         * compile/compile-internal.h: Rename include guard.
14171         * compile/compile-cplus.h: Rename include guard.
14172         * compile/compile-c.h: Rename include guard.
14173         * common/xml-utils.h: Rename include guard.
14174         * common/x86-xstate.h: Rename include guard.
14175         * common/version.h: Rename include guard.
14176         * common/vec.h: Rename include guard.
14177         * common/tdesc.h: Rename include guard.
14178         * common/selftest.h: Rename include guard.
14179         * common/scoped_restore.h: Rename include guard.
14180         * common/scoped_mmap.h: Rename include guard.
14181         * common/scoped_fd.h: Rename include guard.
14182         * common/safe-iterator.h: Rename include guard.
14183         * common/run-time-clock.h: Rename include guard.
14184         * common/refcounted-object.h: Rename include guard.
14185         * common/queue.h: Rename include guard.
14186         * common/ptid.h: Rename include guard.
14187         * common/print-utils.h: Rename include guard.
14188         * common/preprocessor.h: Rename include guard.
14189         * common/pathstuff.h: Rename include guard.
14190         * common/observable.h: Rename include guard.
14191         * common/netstuff.h: Rename include guard.
14192         * common/job-control.h: Rename include guard.
14193         * common/host-defs.h: Rename include guard.
14194         * common/gdb_wait.h: Rename include guard.
14195         * common/gdb_vecs.h: Rename include guard.
14196         * common/gdb_unlinker.h: Rename include guard.
14197         * common/gdb_unique_ptr.h: Rename include guard.
14198         * common/gdb_tilde_expand.h: Rename include guard.
14199         * common/gdb_sys_time.h: Rename include guard.
14200         * common/gdb_string_view.h: Rename include guard.
14201         * common/gdb_splay_tree.h: Rename include guard.
14202         * common/gdb_setjmp.h: Rename include guard.
14203         * common/gdb_ref_ptr.h: Rename include guard.
14204         * common/gdb_optional.h: Rename include guard.
14205         * common/gdb_locale.h: Rename include guard.
14206         * common/gdb_assert.h: Rename include guard.
14207         * common/filtered-iterator.h: Rename include guard.
14208         * common/filestuff.h: Rename include guard.
14209         * common/fileio.h: Rename include guard.
14210         * common/environ.h: Rename include guard.
14211         * common/common-utils.h: Rename include guard.
14212         * common/common-types.h: Rename include guard.
14213         * common/common-regcache.h: Rename include guard.
14214         * common/common-inferior.h: Rename include guard.
14215         * common/common-gdbthread.h: Rename include guard.
14216         * common/common-exceptions.h: Rename include guard.
14217         * common/common-defs.h: Rename include guard.
14218         * common/common-debug.h: Rename include guard.
14219         * common/cleanups.h: Rename include guard.
14220         * common/buffer.h: Rename include guard.
14221         * common/btrace-common.h: Rename include guard.
14222         * common/break-common.h: Rename include guard.
14223         * cli/cli-utils.h: Rename include guard.
14224         * cli/cli-style.h: Rename include guard.
14225         * cli/cli-setshow.h: Rename include guard.
14226         * cli/cli-script.h: Rename include guard.
14227         * cli/cli-interp.h: Rename include guard.
14228         * cli/cli-decode.h: Rename include guard.
14229         * cli/cli-cmds.h: Rename include guard.
14230         * charset-list.h: Add include guard.
14231         * buildsym-legacy.h: Rename include guard.
14232         * bfin-tdep.h: Add include guard.
14233         * ax.h: Rename include guard.
14234         * arm-linux-tdep.h: Add include guard.
14235         * arm-fbsd-tdep.h: Add include guard.
14236         * arch/xtensa.h: Rename include guard.
14237         * arch/tic6x.h: Add include guard.
14238         * arch/i386.h: Add include guard.
14239         * arch/arm.h: Rename include guard.
14240         * arch/arm-linux.h: Rename include guard.
14241         * arch/arm-get-next-pcs.h: Rename include guard.
14242         * arch/amd64.h: Add include guard.
14243         * arch/aarch64-insn.h: Rename include guard.
14244         * arch-utils.h: Rename include guard.
14245         * annotate.h: Add include guard.
14246         * amd64-darwin-tdep.h: Rename include guard.
14247         * aarch64-linux-tdep.h: Add include guard.
14248         * aarch64-fbsd-tdep.h: Add include guard.
14249         * aarch32-linux-nat.h: Add include guard.
14250
14251 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14252
14253         * macrotab.c (macro_define_internal): New function that
14254         factorizes macro_define_object_internal and macro_define_function
14255         code.
14256         (macro_define_object_internal): Use macro_define_internal.
14257         (macro_define_function): Likewise.
14258
14259 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14260
14261         * macrocmd.c (extract_identifier): Return
14262         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14263         callers.
14264
14265 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14266
14267         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14268
14269 2019-02-05  Tom Tromey  <tom@tromey.com>
14270
14271         * target.c (target_stack::unpush): Move assertion earlier.
14272
14273 2019-01-30  Tom Tromey  <tom@tromey.com>
14274
14275         PR python/23615:
14276         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14277         (gdbpy_parse_and_eval): Likewise.
14278         * python/python-internal.h (gdbpy_allow_threads): New class.
14279
14280 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14281
14282         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14283         (aarch64_fbsd_fpregmap): Move earlier.
14284         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14285         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14286         instead of individual calls to trad_frame_set_reg_addr.
14287         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14288         earlier.
14289         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14290         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14291         instead of individual calls to trad_frame_set_reg_addr.
14292
14293 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14294
14295         * CONTRIBUTE: Replace contribution list with wiki link.
14296
14297 2019-01-25  Tom Tromey  <tom@tromey.com>
14298
14299         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14300
14301 2019-01-25  Tom Tromey  <tom@tromey.com>
14302
14303         * xtensa-linux-nat.c: Fix common/ includes.
14304         * xml-support.h: Fix common/ includes.
14305         * xml-support.c: Fix common/ includes.
14306         * x86-linux-nat.c: Fix common/ includes.
14307         * windows-nat.c: Fix common/ includes.
14308         * varobj.h: Fix common/ includes.
14309         * varobj.c: Fix common/ includes.
14310         * value.c: Fix common/ includes.
14311         * valops.c: Fix common/ includes.
14312         * utils.c: Fix common/ includes.
14313         * unittests/xml-utils-selftests.c: Fix common/ includes.
14314         * unittests/utils-selftests.c: Fix common/ includes.
14315         * unittests/unpack-selftests.c: Fix common/ includes.
14316         * unittests/tracepoint-selftests.c: Fix common/ includes.
14317         * unittests/style-selftests.c: Fix common/ includes.
14318         * unittests/string_view-selftests.c: Fix common/ includes.
14319         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14320         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14321         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14322         * unittests/rsp-low-selftests.c: Fix common/ includes.
14323         * unittests/parse-connection-spec-selftests.c: Fix common/
14324         includes.
14325         * unittests/optional-selftests.c: Fix common/ includes.
14326         * unittests/offset-type-selftests.c: Fix common/ includes.
14327         * unittests/observable-selftests.c: Fix common/ includes.
14328         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14329         * unittests/memrange-selftests.c: Fix common/ includes.
14330         * unittests/memory-map-selftests.c: Fix common/ includes.
14331         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14332         * unittests/function-view-selftests.c: Fix common/ includes.
14333         * unittests/environ-selftests.c: Fix common/ includes.
14334         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14335         * unittests/common-utils-selftests.c: Fix common/ includes.
14336         * unittests/cli-utils-selftests.c: Fix common/ includes.
14337         * unittests/array-view-selftests.c: Fix common/ includes.
14338         * ui-file.c: Fix common/ includes.
14339         * tui/tui-io.c: Fix common/ includes.
14340         * tracepoint.h: Fix common/ includes.
14341         * tracepoint.c: Fix common/ includes.
14342         * tracefile-tfile.c: Fix common/ includes.
14343         * top.h: Fix common/ includes.
14344         * top.c: Fix common/ includes.
14345         * thread.c: Fix common/ includes.
14346         * target/waitstatus.h: Fix common/ includes.
14347         * target/waitstatus.c: Fix common/ includes.
14348         * target.h: Fix common/ includes.
14349         * target.c: Fix common/ includes.
14350         * target-memory.c: Fix common/ includes.
14351         * target-descriptions.c: Fix common/ includes.
14352         * symtab.h: Fix common/ includes.
14353         * symfile.c: Fix common/ includes.
14354         * stap-probe.c: Fix common/ includes.
14355         * spu-linux-nat.c: Fix common/ includes.
14356         * sparc-nat.c: Fix common/ includes.
14357         * source.c: Fix common/ includes.
14358         * solib.c: Fix common/ includes.
14359         * solib-target.c: Fix common/ includes.
14360         * ser-unix.c: Fix common/ includes.
14361         * ser-tcp.c: Fix common/ includes.
14362         * ser-pipe.c: Fix common/ includes.
14363         * ser-base.c: Fix common/ includes.
14364         * selftest-arch.c: Fix common/ includes.
14365         * s12z-tdep.c: Fix common/ includes.
14366         * rust-exp.y: Fix common/ includes.
14367         * rs6000-aix-tdep.c: Fix common/ includes.
14368         * riscv-tdep.c: Fix common/ includes.
14369         * remote.c: Fix common/ includes.
14370         * remote-notif.h: Fix common/ includes.
14371         * remote-fileio.h: Fix common/ includes.
14372         * remote-fileio.c: Fix common/ includes.
14373         * regcache.h: Fix common/ includes.
14374         * regcache.c: Fix common/ includes.
14375         * record-btrace.c: Fix common/ includes.
14376         * python/python.c: Fix common/ includes.
14377         * python/py-type.c: Fix common/ includes.
14378         * python/py-inferior.c: Fix common/ includes.
14379         * progspace.h: Fix common/ includes.
14380         * producer.c: Fix common/ includes.
14381         * procfs.c: Fix common/ includes.
14382         * proc-api.c: Fix common/ includes.
14383         * printcmd.c: Fix common/ includes.
14384         * ppc-linux-nat.c: Fix common/ includes.
14385         * parser-defs.h: Fix common/ includes.
14386         * osdata.c: Fix common/ includes.
14387         * obsd-nat.c: Fix common/ includes.
14388         * nat/x86-linux.c: Fix common/ includes.
14389         * nat/x86-linux-dregs.c: Fix common/ includes.
14390         * nat/x86-dregs.h: Fix common/ includes.
14391         * nat/x86-dregs.c: Fix common/ includes.
14392         * nat/ppc-linux.c: Fix common/ includes.
14393         * nat/mips-linux-watch.h: Fix common/ includes.
14394         * nat/mips-linux-watch.c: Fix common/ includes.
14395         * nat/linux-waitpid.c: Fix common/ includes.
14396         * nat/linux-ptrace.h: Fix common/ includes.
14397         * nat/linux-ptrace.c: Fix common/ includes.
14398         * nat/linux-procfs.c: Fix common/ includes.
14399         * nat/linux-personality.c: Fix common/ includes.
14400         * nat/linux-osdata.c: Fix common/ includes.
14401         * nat/linux-namespaces.c: Fix common/ includes.
14402         * nat/linux-btrace.h: Fix common/ includes.
14403         * nat/linux-btrace.c: Fix common/ includes.
14404         * nat/fork-inferior.c: Fix common/ includes.
14405         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14406         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14407         * nat/aarch64-linux.c: Fix common/ includes.
14408         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14409         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14410         * namespace.h: Fix common/ includes.
14411         * mips-linux-tdep.c: Fix common/ includes.
14412         * minsyms.c: Fix common/ includes.
14413         * mi/mi-parse.h: Fix common/ includes.
14414         * mi/mi-main.c: Fix common/ includes.
14415         * mi/mi-cmd-env.c: Fix common/ includes.
14416         * memrange.h: Fix common/ includes.
14417         * memattr.c: Fix common/ includes.
14418         * maint.h: Fix common/ includes.
14419         * maint.c: Fix common/ includes.
14420         * main.c: Fix common/ includes.
14421         * machoread.c: Fix common/ includes.
14422         * location.c: Fix common/ includes.
14423         * linux-thread-db.c: Fix common/ includes.
14424         * linux-nat.c: Fix common/ includes.
14425         * linux-fork.c: Fix common/ includes.
14426         * inline-frame.c: Fix common/ includes.
14427         * infrun.c: Fix common/ includes.
14428         * inflow.c: Fix common/ includes.
14429         * inferior.h: Fix common/ includes.
14430         * inferior.c: Fix common/ includes.
14431         * infcmd.c: Fix common/ includes.
14432         * inf-ptrace.c: Fix common/ includes.
14433         * inf-child.c: Fix common/ includes.
14434         * ia64-linux-nat.c: Fix common/ includes.
14435         * i387-tdep.c: Fix common/ includes.
14436         * i386-tdep.c: Fix common/ includes.
14437         * i386-linux-tdep.c: Fix common/ includes.
14438         * i386-linux-nat.c: Fix common/ includes.
14439         * i386-go32-tdep.c: Fix common/ includes.
14440         * i386-fbsd-tdep.c: Fix common/ includes.
14441         * i386-fbsd-nat.c: Fix common/ includes.
14442         * guile/scm-type.c: Fix common/ includes.
14443         * guile/guile.c: Fix common/ includes.
14444         * go32-nat.c: Fix common/ includes.
14445         * gnu-nat.c: Fix common/ includes.
14446         * gdbthread.h: Fix common/ includes.
14447         * gdbarch-selftests.c: Fix common/ includes.
14448         * gdb_usleep.c: Fix common/ includes.
14449         * gdb_select.h: Fix common/ includes.
14450         * gdb_bfd.c: Fix common/ includes.
14451         * gcore.c: Fix common/ includes.
14452         * fork-child.c: Fix common/ includes.
14453         * findvar.c: Fix common/ includes.
14454         * fbsd-nat.c: Fix common/ includes.
14455         * event-top.c: Fix common/ includes.
14456         * event-loop.c: Fix common/ includes.
14457         * dwarf2read.c: Fix common/ includes.
14458         * dwarf2loc.c: Fix common/ includes.
14459         * dwarf2-frame.c: Fix common/ includes.
14460         * dwarf-index-cache.c: Fix common/ includes.
14461         * dtrace-probe.c: Fix common/ includes.
14462         * disasm-selftests.c: Fix common/ includes.
14463         * defs.h: Fix common/ includes.
14464         * csky-tdep.c: Fix common/ includes.
14465         * cp-valprint.c: Fix common/ includes.
14466         * cp-support.h: Fix common/ includes.
14467         * cp-support.c: Fix common/ includes.
14468         * corelow.c: Fix common/ includes.
14469         * completer.h: Fix common/ includes.
14470         * completer.c: Fix common/ includes.
14471         * compile/compile.c: Fix common/ includes.
14472         * compile/compile-loc2c.c: Fix common/ includes.
14473         * compile/compile-cplus-types.c: Fix common/ includes.
14474         * compile/compile-cplus-symbols.c: Fix common/ includes.
14475         * command.h: Fix common/ includes.
14476         * cli/cli-dump.c: Fix common/ includes.
14477         * cli/cli-cmds.c: Fix common/ includes.
14478         * charset.c: Fix common/ includes.
14479         * build-id.c: Fix common/ includes.
14480         * btrace.h: Fix common/ includes.
14481         * btrace.c: Fix common/ includes.
14482         * breakpoint.h: Fix common/ includes.
14483         * breakpoint.c: Fix common/ includes.
14484         * ax.h:
14485         (enum agent_op): Fix common/ includes.
14486         * ax-general.c (struct aop_map): Fix common/ includes.
14487         * ax-gdb.c: Fix common/ includes.
14488         * auxv.c: Fix common/ includes.
14489         * auto-load.c: Fix common/ includes.
14490         * arm-tdep.c: Fix common/ includes.
14491         * arch/riscv.c: Fix common/ includes.
14492         * arch/ppc-linux-common.c: Fix common/ includes.
14493         * arch/i386.c: Fix common/ includes.
14494         * arch/arm.c: Fix common/ includes.
14495         * arch/arm-linux.c: Fix common/ includes.
14496         * arch/arm-get-next-pcs.c: Fix common/ includes.
14497         * arch/amd64.c: Fix common/ includes.
14498         * arch/aarch64.c: Fix common/ includes.
14499         * arch/aarch64-insn.c: Fix common/ includes.
14500         * arch-utils.c: Fix common/ includes.
14501         * amd64-windows-tdep.c: Fix common/ includes.
14502         * amd64-tdep.c: Fix common/ includes.
14503         * amd64-sol2-tdep.c: Fix common/ includes.
14504         * amd64-obsd-tdep.c: Fix common/ includes.
14505         * amd64-nbsd-tdep.c: Fix common/ includes.
14506         * amd64-linux-tdep.c: Fix common/ includes.
14507         * amd64-linux-nat.c: Fix common/ includes.
14508         * amd64-fbsd-tdep.c: Fix common/ includes.
14509         * amd64-fbsd-nat.c: Fix common/ includes.
14510         * amd64-dicos-tdep.c: Fix common/ includes.
14511         * amd64-darwin-tdep.c: Fix common/ includes.
14512         * agent.c: Fix common/ includes.
14513         * ada-lang.h: Fix common/ includes.
14514         * ada-lang.c: Fix common/ includes.
14515         * aarch64-tdep.c: Fix common/ includes.
14516
14517 2019-01-25  Tom Tromey  <tom@tromey.com>
14518
14519         * common/create-version.sh: Use common/version.h.
14520
14521 2019-01-24  Pedro Alves  <palves@redhat.com>
14522
14523         * infrun.c (signal_stop, signal_print, signal_program)
14524         (signal_catch, signal_pass): Now arrays instead of pointers.
14525         (update_signals_program_target, do_target_resume)
14526         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14527         * linux-nat.c (linux_nat_target::pass_signals)
14528         (linux_nat_target::create_inferior, linux_nat_target::attach):
14529         Adjust.
14530         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14531         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14532         * procfs.c (procfs_target::pass_signals): Adjust.
14533         * record-full.c (record_full_target::resume): Adjust.
14534         * remote.c (remote_target::pass_signals)
14535         (remote_target::program_signals): Adjust.
14536         * target-debug.h (target_debug_print_signals): Now takes a
14537         gdb::array_view as parameter.  Adjust.
14538         * target.h (target_ops) <pass_signals, program_signals>: Replace
14539         pointer and length parameters with gdb::array_view.
14540         (target_pass_signals, target_program_signals): Likewise.
14541         * target-delegates.c: Regenerate.
14542
14543 2019-01-24  Pedro Alves  <palves@redhat.com>
14544
14545         * common/forward-scope-exit.h
14546         (forward_scope_exit::forward_scope_exit): Pass arguments to
14547         m_bind_function directly, instead of creating a std::bind and
14548         copying that.
14549
14550 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14551
14552         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14553         for static members.
14554         (pass_in_v_vfp_candidate): Likewise.
14555
14556 2019-01-23  Tom Tromey  <tom@tromey.com>
14557             Pedro Alves  <palves@redhat.com>
14558
14559         * regcache.c (class regcache_invalidator): Remove.
14560         (regcache::raw_write): Use make_scope_exit.
14561
14562 2019-01-23  Tom Tromey  <tom@tromey.com>
14563
14564         * ui-out.h (class ui_out_emit_type): Update comment.
14565
14566 2019-01-23  Tom Tromey  <tom@tromey.com>
14567
14568         * infrun.c (fetch_inferior_event): Update comment.
14569
14570 2019-01-23  Tom Tromey  <tom@tromey.com>
14571             Pedro Alves  <palves@redhat.com>
14572
14573         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14574         parameter.
14575         (fetch_inferior_event): Use SCOPE_EXIT.
14576
14577
14578 2019-01-23  Tom Tromey  <tom@tromey.com>
14579             Pedro Alves  <palves@redhat.com>
14580
14581         * infrun.c (disable_thread_events): Delete.
14582         (stop_all_threads): Use SCOPE_EXIT.
14583
14584 2019-01-23  Tom Tromey  <tom@tromey.com>
14585             Pedro Alves  <palves@redhat.com>
14586
14587         * symfile.c: Include forward-scope-exit.h.
14588         (clear_symtab_users_cleanup): Replace forward declaration with
14589         a FORWARD_SCOPE_EXIT.
14590         (syms_from_objfile_1): Use the forward_scope_exit and
14591         gdb::optional instead of cleanup_function.
14592         (reread_symbols): Use the forward_scope_exit instead of
14593         cleanup_function.
14594         (clear_symtab_users_cleanup): Remove function.
14595
14596 2019-01-23  Tom Tromey  <tom@tromey.com>
14597             Pedro Alves  <palves@redhat.com>
14598
14599         * linux-nat.c: Include scope-exit.h.
14600         (cleanup_target_stop): Remove.
14601         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14602         SCOPE_EXIT.
14603
14604 2019-01-23  Tom Tromey  <tom@tromey.com>
14605             Pedro Alves  <palves@redhat.com>
14606
14607         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14608         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14609
14610 2019-01-23  Tom Tromey  <tom@tromey.com>
14611             Andrew Burgess  <andrew.burgess@embecosm.com>
14612             Pedro Alves  <palves@redhat.com>
14613
14614         * infrun.c (fetch_inferior_event): Use scope_exit.
14615         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14616         * top.c (execute_command): Use scope_exit.
14617         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14618         * utils.c (do_bpstat_clear_actions_cleanup)
14619         (make_bpstat_clear_actions_cleanup): Remove.
14620
14621 2019-01-23  Tom Tromey  <tom@tromey.com>
14622             Pedro Alves  <palves@redhat.com>
14623
14624         * infrun.c: Include "common/scope-exit.h"
14625         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14626         (wait_for_inferior): Use SCOPE_EXIT.
14627         (fetch_inferior_event): Use scope_exit.
14628
14629 2019-01-23  Tom Tromey  <tom@tromey.com>
14630             Pedro Alves  <palves@redhat.com>
14631
14632         * breakpoint.c (create_breakpoint): Remove cleanup.
14633
14634 2019-01-23  Tom Tromey  <tom@tromey.com>
14635             Andrew Burgess  <andrew.burgess@embecosm.com>
14636             Pedro Alves  <palves@redhat.com>
14637
14638 2019-01-23  Pedro Alves  <palves@redhat.com>
14639
14640         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14641
14642 2019-01-23  Pedro Alves  <palves@redhat.com>
14643             Andrew Burgess  <andrew.burgess@embecosm.com>
14644
14645         * gdbthread.h: Include "common/forward-scope-exit.h".
14646         (scoped_finish_thread_state): Redefine custom class in terms of
14647         forward_scope_exit.
14648
14649 2019-01-23  Pedro Alves  <palves@redhat.com>
14650             Andrew Burgess  <andrew.burgess@embecosm.com>
14651
14652         * common/forward-scope-exit.h: New file.
14653
14654 2019-01-23  Pedro Alves  <palves@redhat.com>
14655             Andrew Burgess  <andrew.burgess@embecosm.com>
14656             Tom Tromey  <tom@tromey.com>
14657
14658         * common/scope-exit.h: New file.
14659
14660 2019-01-23  Pedro Alves  <palves@redhat.com>
14661
14662         * common/preprocessor.h (ESC): Rename to ...
14663         (ESC_PARENS): ... this.
14664         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14665         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14666
14667 2019-01-23  Tom Tromey  <tom@tromey.com>
14668
14669         * language.h (class scoped_switch_to_sym_language_if_auto):
14670         Initialize m_lang in both cases.
14671
14672 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14673
14674         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14675         with XCNEW.
14676
14677 2019-01-22  Tom Tromey  <tom@tromey.com>
14678
14679         * corelow.c: Do not include sys/file.h.
14680
14681 2019-01-22  Tom Tromey  <tom@tromey.com>
14682
14683         * tui/tui-wingeneral.h: Include gdb_curses.h.
14684
14685 2019-01-22  Tom Tromey  <tom@tromey.com>
14686
14687         * source-cache.h (class source_cache) <get_source_lines,
14688         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14689
14690 2019-01-22  Tom Tromey  <tom@tromey.com>
14691
14692         * remote-fileio.h (struct remote_target): Declare.
14693
14694 2019-01-22  Tom Tromey  <tom@tromey.com>
14695
14696         * python/py-arch.c: Do not include py-ref.h.
14697         * python/py-bpevent.c: Do not include py-ref.h.
14698         * python/py-cmd.c: Do not include py-ref.h.
14699         * python/py-continueevent.c: Do not include py-ref.h.
14700         * python/py-event.h: Do not include py-ref.h.
14701         * python/py-evtregistry.c: Do not include py-ref.h.
14702         * python/py-finishbreakpoint.c: Do not include py-ref.h.
14703         * python/py-frame.c: Do not include py-ref.h.
14704         * python/py-framefilter.c: Do not include py-ref.h.
14705         * python/py-function.c: Do not include py-ref.h.
14706         * python/py-infevents.c: Do not include py-ref.h.
14707         * python/py-linetable.c: Do not include py-ref.h.
14708         * python/py-objfile.c: Do not include py-ref.h.
14709         * python/py-param.c: Do not include py-ref.h.
14710         * python/py-prettyprint.c: Do not include py-ref.h.
14711         * python/py-progspace.c: Do not include py-ref.h.
14712         * python/py-symbol.c: Do not include py-ref.h.
14713         * python/py-symtab.c: Do not include py-ref.h.
14714         * python/py-type.c: Do not include py-ref.h.
14715         * python/py-unwind.c: Do not include py-ref.h.
14716         * python/py-utils.c: Do not include py-ref.h.
14717         * python/py-value.c: Do not include py-ref.h.
14718         * python/py-varobj.c: Do not include py-ref.h.
14719         * python/py-xmethods.c: Do not include py-ref.h.
14720         * python/python.c: Do not include py-ref.h.
14721         * varobj.c: Do not include py-ref.h.
14722
14723 2019-01-22  Tom Tromey  <tom@tromey.com>
14724
14725         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14726         keyword for bcache.
14727
14728 2019-01-22  Tom Tromey  <tom@tromey.com>
14729
14730         * compile/compile-cplus-types.c: Remove a comment by #include.
14731
14732 2019-01-22  Tom Tromey  <tom@tromey.com>
14733
14734         * compile/gcc-c-plugin.h: Include compile-internal.h.
14735
14736 2019-01-22  Tom Tromey  <tom@tromey.com>
14737
14738         * stabsread.c (EXTERN): Do not define.
14739         (symnum, next_symbol_text_func, processing_gcc_compilation)
14740         (within_function, global_sym_chain, global_stabs)
14741         (previous_stab_code, this_object_header_files)
14742         (n_this_object_header_files)
14743         (n_allocated_this_object_header_files): Define.
14744         * stabsread.h (EXTERN): Never define.  Use "extern".
14745
14746 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14747
14748         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14749         history_value.
14750
14751 2019-01-21  Tom Tromey  <tom@tromey.com>
14752
14753         * ui-out.c: Fix includes.
14754         * tui/tui-source.c: Fix includes.
14755         * target.c: Fix includes.
14756         * remote.c: Fix includes.
14757         * regcache.c: Fix includes.
14758         * python/py-block.c: Fix includes.
14759         * printcmd.c: Fix includes.
14760         * or1k-tdep.c: Fix includes.
14761         * mi/mi-main.c: Fix includes.
14762         * m32r-tdep.c: Fix includes.
14763         * csky-tdep.c: Fix includes.
14764         * compile/compile-cplus-types.c: Fix includes.
14765         * cli/cli-interp.c: Fix includes.
14766
14767 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
14768
14769         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14770         for padding.
14771
14772 2019-01-16  Tom Tromey  <tom@tromey.com>
14773
14774         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
14775         earlier.
14776         (struct objfile) <msymbols_range>: Move from top level.
14777         <msymbols>: New method.
14778         (class objfile_msymbols): Remove.
14779         * symtab.c (default_collect_symbol_completion_matches_break_on):
14780         Update.
14781         * symmisc.c (dump_msymbols): Update.
14782         * stabsread.c (scan_file_globals): Update.
14783         * objc-lang.c (info_selectors_command, info_classes_command)
14784         (find_methods): Update.
14785         * minsyms.c (find_solib_trampoline_target): Update.
14786         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14787         * coffread.c (coff_symfile_read): Update.
14788         * ada-lang.c (ada_lookup_simple_minsym)
14789         (ada_collect_symbol_completion_matches): Update.
14790
14791 2019-01-16  Tom Tromey  <tom@tromey.com>
14792
14793         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14794         type.  Remove no-argument constructor.
14795         <iterator::operator++>: Simplify.
14796         <begin>: Update.
14797         <end>: Use minimal_symbol_count.
14798
14799 2019-01-16  Tom Tromey  <tom@tromey.com>
14800
14801         * objfiles.h (struct objfile) <psymtabs>: New method.
14802         (class objfile_psymtabs): Remove.
14803         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14804         typedef.
14805         <range>: New method.
14806         (require_partial_symbols): Change return type.
14807         * psymtab.c (require_partial_symbols)
14808         (psym_expand_symtabs_matching): Update.
14809         * mdebugread.c (parse_partial_symbols): Update.
14810         * dbxread.c (dbx_end_psymtab): Update.
14811
14812 2019-01-15  Tom Tromey  <tom@tromey.com>
14813
14814         * symtab.c (lookup_objfile_from_block)
14815         (lookup_symbol_in_objfile_symtabs)
14816         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14817         (find_line_symtab, info_sources_command)
14818         (default_collect_symbol_completion_matches_break_on)
14819         (make_source_files_completion_list): Update.
14820         * symmisc.c (print_objfile_statistics, dump_objfile)
14821         (maintenance_print_symbols, maintenance_info_symtabs)
14822         (maintenance_check_symtabs, maintenance_info_line_tables):
14823         Update.
14824         * source.c (select_source_symtab)
14825         (forget_cached_source_info_for_objfile): Update.
14826         * objfiles.h (class objfile_compunits): Remove.
14827         (struct objfile) <compunits_range>: New typedef.
14828         (compunits): New method.
14829         * objfiles.c (objfile_relocate1): Update.
14830         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14831         * maint.c (count_symtabs_and_blocks): Update.
14832         * linespec.c (iterate_over_all_matching_symtabs): Update.
14833         * cp-support.c (add_symbol_overload_list_qualified): Update.
14834         * coffread.c (coff_symtab_read): Update.
14835         * ada-lang.c (add_nonlocal_symbols)
14836         (ada_collect_symbol_completion_matches)
14837         (ada_add_global_exceptions): Update.
14838
14839 2019-01-15  Tom Tromey  <tom@tromey.com>
14840
14841         * progspace.h (program_space) <objfiles_safe_range>: New
14842         typedef.
14843         <objfiles_safe>: New method.
14844         * objfiles.h (class all_objfiles_safe): Remove.
14845         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14846         * jit.c (jit_inferior_exit_hook): Update.
14847
14848 2019-01-17  Tom Tromey  <tom@tromey.com>
14849
14850         * progspace.h (program_space) <objfiles_range>: New typedef.
14851         <objfiles>: New method.
14852         <objfiles_head>: Rename from objfiles.
14853         (object_files): Update.
14854         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14855         * guile/scm-pretty-print.c
14856         (ppscm_find_pretty_printer_from_objfiles): Update.
14857         * guile/scm-objfile.c (gdbscm_objfiles): Update.
14858         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14859         Update.
14860         * python/py-progspace.c (pspy_get_objfiles): Update.
14861         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14862         Update.
14863         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14864         (objfpy_lookup_objfile_by_build_id): Update.
14865         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14866         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14867         Update.
14868         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14869         (expand_symtab_containing_pc, lookup_objfile_from_block)
14870         (lookup_static_symbol, basic_lookup_transparent_type)
14871         (find_pc_sect_compunit_symtab, find_symbol_at_address)
14872         (find_line_symtab, info_sources_command)
14873         (default_collect_symbol_completion_matches_break_on)
14874         (make_source_files_completion_list, find_main_name): Update.
14875         * symmisc.c (print_symbol_bcache_statistics)
14876         (print_objfile_statistics, maintenance_print_symbols)
14877         (maintenance_print_msymbols, maintenance_print_objfiles)
14878         (maintenance_info_symtabs, maintenance_check_symtabs)
14879         (maintenance_expand_symtabs, maintenance_info_line_tables):
14880         Update.
14881         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14882         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14883         (map_overlay_command, unmap_overlay_command)
14884         (simple_overlay_update, expand_symtabs_matching)
14885         (map_symbol_filenames): Update.
14886         * symfile-debug.c (set_debug_symfile): Update.
14887         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14888         Update.
14889         * source.c (select_source_symtab, forget_cached_source_info):
14890         Update.
14891         * solib.c (solib_read_symbols): Update.
14892         * solib-spu.c (append_ocl_sos): Update.
14893         * psymtab.c (maintenance_print_psymbols)
14894         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14895         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14896         * printcmd.c (info_symbol_command): Update.
14897         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14898         Update.
14899         * objfiles.h (class all_objfiles): Remove.
14900         * objfiles.c (have_partial_symbols, have_full_symbols)
14901         (have_minimal_symbols, qsort_cmp, update_section_map)
14902         (shared_objfile_contains_address_p)
14903         (default_iterate_over_objfiles_in_search_order): Update.
14904         * objc-lang.c (info_selectors_command, info_classes_command)
14905         (find_methods): Update.
14906         * minsyms.c (find_solib_trampoline_target): Update.
14907         * maint.c (maintenance_info_sections)
14908         (maintenance_translate_address, count_symtabs_and_blocks):
14909         Update.
14910         * main.c (captured_main_1): Update.
14911         * linux-thread-db.c (try_thread_db_load_from_pdir)
14912         (has_libpthread): Update.
14913         * linespec.c (iterate_over_all_matching_symtabs)
14914         (search_minsyms_for_name): Update.
14915         * jit.c (jit_find_objf_with_entry_addr): Update.
14916         * hppa-tdep.c (find_unwind_entry)
14917         (hppa_lookup_stub_minimal_symbol): Update.
14918         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
14919         Update.
14920         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14921         (elf_gnu_ifunc_resolve_by_got): Update.
14922         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
14923         * dwarf-index-write.c (save_gdb_index_command): Update.
14924         * cp-support.c (add_symbol_overload_list_qualified): Update.
14925         * breakpoint.c (create_overlay_event_breakpoint)
14926         (create_longjmp_master_breakpoint)
14927         (create_std_terminate_master_breakpoint)
14928         (create_exception_master_breakpoint): Update.
14929         * blockframe.c (find_pc_partial_function): Update.
14930         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
14931         (ada_collect_symbol_completion_matches)
14932         (ada_add_global_exceptions): Update.
14933
14934 2019-01-17  Tom Tromey  <tom@tromey.com>
14935
14936         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
14937         declare VEC.
14938         (solib_target_parse_libraries): Change return type.
14939         (library_list_start_segment, library_list_start_section)
14940         (library_list_end_library, library_list_start_library); Update.
14941         (solib_target_free_library_list): Remove.
14942         (solib_target_parse_libraries): Remove cleanup.  Change return
14943         type.
14944         (solib_target_current_sos): Update.
14945
14946 2019-01-17  Tom Tromey  <tromey@bapiya>
14947
14948         * valprint.c: Replace "the the" with "the".
14949         * symtab.c: Replace "the the" with "the".
14950         * solib.c: Replace "the the" with "the".
14951         * solib-dsbt.c: Replace "the the" with "the".
14952         * linespec.c: Replace "the the" with "the".
14953         * dwarf2loc.h: Replace "the the" with "the".
14954         * amd64-windows-tdep.c: Replace "the the" with "the".
14955         * aarch64-tdep.c: Replace "the the" with "the".
14956
14957 2019-01-16  Keith Seitz  <keiths@redhat.com>
14958
14959         PR gdb/23773
14960         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14961         <builder>: Rename to ..
14962         <m_builder>: ... this and make private.
14963         (dwarf2_cu::get_builder): New method.  Change all users of
14964         `builder' to use this method.
14965         (dwarf2_start_symtab): Move to ...
14966         (dwarf2_cu::start_symtab): ... here.  Update all callers
14967         (setup_type_unit_groups): Move to ...
14968         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
14969         callers.
14970         (dwarf2_cu::reset_builder): New method.
14971         (process_full_compunit, process_full_type_unit): Use
14972         dwarf2_cu::reset_builder.
14973         (follow_die_offset): Record the ancestor CU if it is different
14974         from the followed DIE's CU.
14975         (follow_die_sig_1): Likewise.
14976
14977 2019-01-15  Tom Tromey  <tom@tromey.com>
14978
14979         * remote.c (class remote_state) <buf>: Now a char_vector.
14980         <buf_size>: Remove.
14981         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
14982         parameter.
14983         (remote_target::getpkt_or_notif_sane_1)
14984         (remote_target::getpkt_sane)
14985         (remote_target::getpkt_or_notif_sane): Likewise.
14986         (class remote_target) <putpkt>: New overload.
14987         (remote_target::read_frame): Change type of "buf_p".  Remove
14988         sizeof_p parameter.
14989         (packet_ok): New overload.
14990         (packet_check_result): New overload.
14991         Update all uses.
14992
14993 2019-01-14  Tom Tromey  <tom@tromey.com>
14994
14995         * remote-notif.c (handle_notification, remote_notif_ack)
14996         (remote_notif_parse): Make "buf" const.
14997         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14998         const.
14999         (remote_notif_parse, remote_notif_ack, handle_notification):
15000         Likewise.
15001         * remote.c (remote_notif_stop_parse): Make "buf" const.
15002         (remote_target::remote_parse_stop_reply): Make "buf" const.
15003         (remote_notif_stop_ack): Make "buf" const.
15004
15005 2019-01-14  Tom Tromey  <tom@tromey.com>
15006
15007         * remote.c (remote_console_output): Make parameter const.
15008
15009 2019-01-14  Tom Tromey  <tom@tromey.com>
15010
15011         * target-debug.h (target_debug_print_signals): Constify.
15012         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15013         * procfs.c (procfs_target::pass_signals): Update.
15014         * linux-nat.c (linux_nat_target::pass_signals): Update.
15015         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15016         * target-delegates.c: Rebuild.
15017         * remote.c (remote_target::program_signals): Update.
15018         (remote_target::pass_signals): Update.
15019         * target.c (target_pass_signals): Constify argument.
15020         (target_program_signals): Likewise.
15021         * target.h (struct target_ops) <pass_signals, program_signals>:
15022         Constify argument.
15023         (target_pass_signals, target_program_signals): Constify argument.
15024
15025 2019-01-14  Tom Tromey  <tom@tromey.com>
15026
15027         PR tui/28819:
15028         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15029
15030 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15031
15032         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15033         field.
15034         * rs6000-tdep.c: Include reggroups.h.
15035         (IS_V_ALIAS_PSEUDOREG): Define.
15036         (rs6000_register_name): Return names for the "vX" aliases.
15037         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15038         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15039         aliases.  Call default_register_reggroup_p for all other
15040         pseudo-registers.
15041         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15042         New functions.
15043         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15044         Handle "vX" aliases.
15045         (v_alias_pseudo_register_collect): New function.
15046         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15047         (rs6000_gdbarch_init): Initialize "vX" aliases as
15048         pseudo-registers.  Restore registration of
15049         rs6000_pseudo_register_reggroup_p with
15050         set_tdesc_pseudo_register_reggroup_p.
15051
15052 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15053
15054         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15055         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15056         set_gdbarch_num_pseudo_regs.
15057
15058 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15059
15060         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15061         Remove arg prefixname, add do_set and do_show.
15062         Add member functions set_list and show_list.
15063         * cli/cli-style.c (class cli_style_option): Update accordingly.
15064         (style_set_list): Move to file scope.
15065         (style_show_list): Likewise.
15066         (set_style): Call help_list.
15067         (show_style): Call cmd_show_list.
15068         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15069         Update to use the new macro.
15070
15071 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15072
15073         * ada-lang.c (_initialize_ada_language): Expand the help text
15074         for the "catch exception" command.
15075
15076 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15077
15078         * symtab.c (matching_obj_sections): Initialize obj,
15079         declare it closer to its usage.
15080
15081 2019-01-10  Tom Tromey  <tom@tromey.com>
15082
15083         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15084         (basic_inf_threads_range): Remove.
15085         (inf_threads_range, inf_non_exited_threads_range)
15086         (safe_inf_threads_range): Use next_adapter.
15087
15088 2019-01-10  Keith Seitz  <keiths@redhat.com>
15089
15090         PR gdb/23712
15091         PR symtab/23010
15092         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15093         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15094
15095 2019-01-10  Keith Seitz  <keiths@redhat.com>
15096
15097         PR gdb/23712
15098         PR symtab/23010
15099         * dictionary.c (pending_to_vector): Remove.
15100         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15101         Remove _1 suffix, replacing functions of the same name.  Update
15102         all callers.
15103         (dict_create_hashed, dict_create_hashed_expandable)
15104         (dict_create_linear, dict_create_linear_expandable, dict_free)
15105         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15106         Make functions static.
15107
15108 2019-01-10  Keith Seitz  <keiths@redhat.com>
15109
15110         PR gdb/23712
15111         PR symtab/23010
15112         * dictionary.h (struct dictionary): Replace declaration with
15113         multidictionary.
15114         (dict_create_hashed, dict_create_hashed_expandable)
15115         (dict_create_linear, dict_create_linear_expandable)
15116         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15117         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15118         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15119         taking multidictionary argument.
15120         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15121         * block.h (struct block) <dict>: Change to multidictionary
15122         and rename `multidict'.
15123         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15124         symmisc.c: Update all dictionary references to multidictionary.
15125
15126 2019-01-10  Keith Seitz  <keiths@redhat.com>
15127
15128         PR gdb/23712
15129         PR symtab/23010
15130         * dictionary.c: Include unordered_map.
15131         (pending_to_vector): New function.
15132         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15133         Rewrite the non-"_1" functions to take vector instead
15134         of linked list.
15135         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15136         "new" _1 versions of the same name.
15137         (multidictionary): Define.
15138         (std::hash<enum language): New definition.
15139         (collate_pending_symbols_by_language, mdict_create_hashed)
15140         (mdict_create_hashed_expandable, mdict_create_linear)
15141         (mdict_create_linear_expandable, mdict_free)
15142         (find_language_dictionary, create_new_language_dictionary)
15143         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15144         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15145         (mdict_size, mdict_empty): New functions.
15146         * dictionary.h (mdict_iterator): Define.
15147
15148 2019-01-10  Pedro Alves  <palves@redhat.com>
15149
15150         * breakpoint.c (read_uploaded_action)
15151         (create_tracepoint_from_upload): Adjust to use
15152         gdb::unique_xmalloc_ptr.
15153         * ctf.c (ctf_write_uploaded_tp):
15154         (SET_ARRAY_FIELD): Use emplace_back.
15155         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15156         * tracefile-tfile.c (tfile_write_uploaded_tp):
15157         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15158         gdb::unique_xmalloc_ptr.
15159         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15160         at_string, cond_string, cmd_strings>: Replace char pointers
15161         with gdb::unique_xmalloc_ptr.
15162
15163 2019-01-10  Pedro Alves  <palves@redhat.com>
15164
15165         * solib-target.c (library_list_start_library): Don't xstrdup name.
15166
15167 2019-01-10  Pedro Alves  <palves@redhat.com>
15168
15169         * mdebugread.c (parse_partial_symbols): Use
15170         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15171
15172 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15173
15174         * linux-fork.c (scoped_switch_fork_info)
15175         <~scoped_switch_fork_info>: Fix incorrect variable name.
15176
15177 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15178
15179         * linux-fork.c (scoped_switch_fork_info)
15180         <scoped_switch_fork_info>: Make explicit.
15181         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15182
15183 2019-01-10  Tom Tromey  <tom@tromey.com>
15184
15185         * objfiles.h (objfile::reset_psymtabs): Update.
15186         * objfiles.c (objfile::objfile): Update.
15187         * psymtab.h (psymtab_storage::obstack): Update.
15188         (psymtab_storage::m_obstack): Use gdb::optional.
15189         (class psymtab_storage): Update comment.  Remove objfile
15190         parameter.
15191         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15192
15193 2019-01-10  Tom Tromey  <tom@tromey.com>
15194
15195         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15196         <free_psymtabs>: Now private.
15197         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15198         (allocate_psymtab): Use new method.
15199
15200 2019-01-10  Tom Tromey  <tom@tromey.com>
15201
15202         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15203         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15204         * mdebugread.c (parse_partial_symbols): Use
15205         allocate_dependencies.
15206         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15207         allocate_dependencies.
15208         (process_psymtab_comp_unit_reader)
15209         (build_type_psymtab_dependencies): Likewise.
15210         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15211
15212 2019-01-10  Tom Tromey  <tom@tromey.com>
15213
15214         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15215         PSYMBOL_SET_LANGUAGE.
15216         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15217
15218 2019-01-10  Tom Tromey  <tom@tromey.com>
15219
15220         * psymtab.h (psymtab_storage::obstack): New method.
15221         <m_obstack>: Rename from obstack; now private.
15222         * psymtab.c (psymtab_storage): Update.
15223         * dwarf2read.c (create_addrmap_from_index)
15224         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15225         Update.
15226
15227 2019-01-10  Tom Tromey  <tom@tromey.com>
15228
15229         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15230         * objfiles.h (objfile::reset_psymtabs): New method.
15231
15232 2019-01-10  Tom Tromey  <tom@tromey.com>
15233
15234         * symmisc.c (print_symbol_bcache_statistics): Update.
15235         (print_objfile_statistics): Update.
15236         * symfile.c (reread_symbols): Update.
15237         * psymtab.h (class psymtab_storage): New.
15238         * psymtab.c (psymtab_storage): New constructor.
15239         (~psymtab_storage): New destructor.
15240         (require_partial_symbols): Update.
15241         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15242         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15243         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15244         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15245         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15246         (start_psymtab_common, end_psymtab_common)
15247         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15248         (allocate_psymtab): Update.
15249         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15250         Update.
15251         (dump_psymtab_addrmap, maintenance_print_psymbols)
15252         (maintenance_check_psymtabs): Update.
15253         (class objfile_psymtabs): Move to objfiles.h.
15254         * psympriv.h (discard_psymtab): Now inline.
15255         (psymtab_discarder::psymtab_discarder): Update.
15256         (psymtab_discarder::~psymtab_discarder): Update.
15257         (ALL_OBJFILE_PSYMTABS): Rewrite.
15258         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15259         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15260         Remove fields.
15261         <partial_symtabs>: New field.
15262         (class objfile_psymtabs): Move from psymtab.h.  Update.
15263         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15264         psymbol_cache.
15265         (objfile::~objfile): Don't destroy psymbol_cache.
15266         * mdebugread.c (parse_partial_symbols): Update.
15267         * dwarf2read.c (create_addrmap_from_index)
15268         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15269         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15270         (add_partial_subprogram, dwarf2_ranges_read): Update.
15271         * dwarf-index-write.c (write_address_map)
15272         (write_one_signatured_type, recursively_write_psymbols)
15273         (class debug_names, class debug_names, write_psymtabs_to_index):
15274         Update.
15275
15276 2019-01-10  Tom Tromey  <tom@tromey.com>
15277
15278         * symtab.h (SYMBOL_SET_NAMES): Update.
15279         (symbol_set_names): Update.
15280         (MSYMBOL_SET_NAMES): Update.
15281         * symtab.c (symbol_set_names): Change argument to be an
15282         objfile_per_bfd_storage.
15283         * psymtab.c (add_psymbol_to_bcache): Update.
15284         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15285
15286 2019-01-10  Tom Tromey  <tom@tromey.com>
15287
15288         * symtab.c (create_demangled_names_hash): Change argument to be an
15289         objfile_per_bfd_storage.
15290         (symbol_set_names): Update.
15291
15292 2019-01-10  Tom Tromey  <tom@tromey.com>
15293
15294         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15295         init_psymbol_list.
15296         * psymtab.c (init_psymbol_list): Do nothing if already called.
15297         * psympriv.h (init_psymbol_list): Add comment.
15298         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15299         init_psymbol_list.
15300         * dbxread.c (dbx_symfile_read): Unconditionally call
15301         init_psymbol_list.
15302
15303 2019-01-10  Tom Tromey  <tom@tromey.com>
15304
15305         * xcoffread.c (scan_xcoff_symtab): Update.
15306         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15307         "where".
15308         * mdebugread.c (parse_partial_symbols)
15309         (handle_psymbol_enumerators): Update.
15310         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15311         * dbxread.c (read_dbx_symtab): Update.
15312         * psympriv.h (psymbol_placement): New enum.
15313         (add_psymbol_to_list): Update.
15314
15315 2019-01-10  Tom Tromey  <tom@tromey.com>
15316
15317         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15318         static_psymbols parameters.
15319         (scan_xcoff_symtab): Update.
15320         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15321         static_psymbols parameters.
15322         * psympriv.h (start_psymtab_common): Update.
15323         * mdebugread.c (parse_partial_symbols): Update.
15324         * dwarf2read.c (create_partial_symtab): Update.
15325         * dbxread.c (read_dbx_symtab): Update.
15326         (start_psymtab): Remove global_psymbols and static_psymbols
15327         parameters.
15328
15329 2019-01-10  Tom Tromey  <tom@tromey.com>
15330
15331         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15332         * psymtab.c (allocate_psymtab): Add comment.
15333         * psympriv.h (allocate_psymtab): Add comment.
15334         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15335         initializations.
15336         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15337
15338 2019-01-10  Tom Tromey  <tom@tromey.com>
15339
15340         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15341         Don't declare.
15342         * mipsread.c: Include mdebugread.h.
15343         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15344         Declare.
15345         * elfread.c: Include mdebugread.h.
15346
15347 2019-01-09  Tom Tromey  <tom@tromey.com>
15348
15349         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15350         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15351         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15352         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15353         (psym_lookup_symbol, psym_find_last_source_symtab)
15354         (psym_forget_cached_source_info, psym_print_stats)
15355         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15356         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15357         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15358         (psym_find_compunit_symtab_by_address)
15359         (maintenance_print_psymbols, maintenance_info_psymtabs)
15360         (maintenance_check_psymtabs): Use ranged for.
15361         * psymtab.h (class objfile_psymtabs): New.
15362         (require_partial_symbols): Return objfile_psymtabs.
15363         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15364
15365 2019-01-09  Tom Tromey  <tom@tromey.com>
15366
15367         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15368         (find_pc_mapped_section, list_overlays_command)
15369         (map_overlay_command, unmap_overlay_command)
15370         (simple_overlay_update): Use all_objfiles.
15371         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15372         * printcmd.c (info_symbol_command): Use all_objfiles.
15373         * objfiles.h (ALL_OBJSECTIONS): Remove.
15374         * maint.c (maintenance_translate_address): Use all_objfiles.
15375         * gcore.c (gcore_create_callback): Use all_objfiles.
15376         (objfile_find_memory_regions): Likewise.
15377
15378 2019-01-09  Tom Tromey  <tom@tromey.com>
15379
15380         * symtab.c (find_line_symtab, info_sources_command)
15381         (make_source_files_completion_list): Use objfile_compunits.
15382         * source.c (select_source_symtab): Use objfile_compunits.
15383         * objfiles.h (struct objfile): Update comment.
15384         (ALL_OBJFILES): Remove.
15385         (ALL_FILETABS): Remove.
15386         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15387         objfile_compunits.
15388
15389 2019-01-09  Tom Tromey  <tom@tromey.com>
15390
15391         * symmisc.c (print_objfile_statistics, dump_objfile)
15392         (maintenance_print_symbols): Use compunit_filetabs.
15393         * source.c (forget_cached_source_info_for_objfile): Use
15394         compunit_filetabs.
15395         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15396         (ALL_FILETABS): Use compunit_filetabs.
15397         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15398         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15399
15400 2019-01-09  Tom Tromey  <tom@tromey.com>
15401
15402         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15403         (compunit_filetabs): New.
15404         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15405         compunit_filetabs.
15406         (info_sources_command, make_source_files_completion_list): Remove
15407         declaration.
15408         * symmisc.c (print_objfile_statistics, dump_objfile)
15409         (maintenance_print_symbols): Remove declaration.
15410         (maintenance_info_symtabs): Use compunit_filetabs.
15411         (maintenance_info_line_tables): Likewise.
15412         * source.c (select_source_symtab): Change local variable name.
15413         (forget_cached_source_info_for_objfile): Remove declaration.
15414         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15415         * objfiles.c (objfile_relocate1): Remove declaration.
15416         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15417         declaration.
15418         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15419         * coffread.c (coff_symtab_read): Remove declaration.
15420         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15421         compunit_filetabs.
15422
15423 2019-01-09  Tom Tromey  <tom@tromey.com>
15424
15425         * symtab.c (lookup_objfile_from_block)
15426         (find_pc_sect_compunit_symtab, search_symbols)
15427         (default_collect_symbol_completion_matches_break_on): Use
15428         objfile_compunits.
15429         * objfiles.h (ALL_COMPUNITS): Remove.
15430         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15431         * cp-support.c (add_symbol_overload_list_qualified): Use
15432         objfile_compunits.
15433         * ada-lang.c (ada_collect_symbol_completion_matches)
15434         (ada_add_global_exceptions): Use objfile_compunits.
15435
15436 2019-01-09  Tom Tromey  <tom@tromey.com>
15437
15438         * source.c (select_source_symtab)
15439         (forget_cached_source_info_for_objfile): Remove declaration.
15440         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15441         declaration.
15442         * maint.c (count_symtabs_and_blocks): Remove declaration.
15443         * cp-support.c (add_symbol_overload_list_qualified): Remove
15444         declaration.
15445         * coffread.c (coff_symtab_read): Remove declaration.
15446         * symtab.c (lookup_symbol_in_objfile_symtabs)
15447         (basic_lookup_transparent_type_1): Use objfile_compunits.
15448         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15449         (info_sources_command, search_symbols)
15450         (default_collect_symbol_completion_matches_break_on)
15451         (make_source_files_completion_list): Remove declaration.
15452         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15453         (ada_collect_symbol_completion_matches)
15454         (ada_add_global_exceptions): Remove declaration.
15455         * linespec.c (iterate_over_all_matching_symtabs): Use
15456         objfile_compunits.
15457         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15458         (class objfile_compunits): New.
15459         (ALL_COMPUNITS): Use objfile_compunits.
15460         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15461         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15462         objfile_compunits.
15463         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15464
15465 2019-01-09  Tom Tromey  <tom@tromey.com>
15466
15467         * symtab.c (search_symbols)
15468         (default_collect_symbol_completion_matches_break_on): Use
15469         objfile_msymbols.
15470         * ada-lang.c (ada_lookup_simple_minsym)
15471         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15472         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15473         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15474         objfile_msymbols.
15475         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15476         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15477         * objc-lang.c (find_methods): Use objfile_msymbols.
15478         (info_selectors_command, info_classes_command): Likewise.
15479         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15480         * objfiles.h (class objfile_msymbols): New.
15481         (ALL_OBJFILE_MSYMBOLS): Remove.
15482         (ALL_MSYMBOLS): Remove.
15483
15484 2019-01-09  Tom Tromey  <tom@tromey.com>
15485
15486         * common/next-iterator.h (next_adapter): Add Iterator template
15487         parameter.
15488         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15489         (class all_objfiles_safe): New.
15490         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15491         * objfiles.c (put_objfile_before): Update comment.
15492         (add_separate_debug_objfile): Likewise.
15493         (free_all_objfiles): Use all_objfiles_safe.
15494         (objfile_purge_solibs): Likewise.
15495
15496 2019-01-09  Tom Tromey  <tom@tromey.com>
15497
15498         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15499         (expand_symtab_containing_pc, lookup_static_symbol)
15500         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15501         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15502         all_objfiles.
15503         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15504         * breakpoint.c (create_overlay_event_breakpoint)
15505         (create_longjmp_master_breakpoint)
15506         (create_std_terminate_master_breakpoint)
15507         (create_exception_master_breakpoint): Use all_objfiles.
15508         * linux-thread-db.c (try_thread_db_load_from_pdir)
15509         (has_libpthread): Use all_objfiles.
15510         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15511         * linespec.c (iterate_over_all_matching_symtabs)
15512         (search_minsyms_for_name): Use all_objfiles.
15513         * maint.c (maintenance_info_sections): Use all_objfiles.
15514         * main.c (captured_main_1): Use all_objfiles.
15515         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15516         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15517         * guile/scm-pretty-print.c
15518         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15519         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15520         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15521         (maintenance_print_msymbols): Use all_objfiles.
15522         * source.c (select_source_symtab): Use all_objfiles.
15523         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15524         * symfile.c (remove_symbol_file_command)
15525         (expand_symtabs_matching, map_symbol_filenames): Use
15526         all_objfiles.
15527         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15528         all_objfiles.
15529         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15530         * objc-lang.c (find_methods): Use all_objfiles.
15531         * objfiles.c (have_partial_symbols, have_full_symbols)
15532         (have_minimal_symbols, qsort_cmp)
15533         (default_iterate_over_objfiles_in_search_order): Use
15534         all_objfiles.
15535         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15536         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15537         (maintenance_check_psymtabs): Use all_objfiles.
15538         (ALL_PSYMTABS): Remove.
15539         * compile/compile-object-run.c (do_module_cleanup): Use
15540         all_objfiles.
15541         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15542         * cp-support.c (add_symbol_overload_list_qualified): Use
15543         all_objfiles.
15544         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15545         Use all_objfiles.
15546         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15547         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15548         all_objfiles.
15549         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15550         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15551         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15552         Uses all_objfiles.
15553         * solib.c (solib_read_symbols): Use all_objfiles
15554
15555 2019-01-09  Tom Tromey  <tom@tromey.com>
15556
15557         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15558         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15559         all_objfiles.
15560         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15561         * symmisc.c (print_symbol_bcache_statistics)
15562         (print_objfile_statistics, maintenance_print_objfiles)
15563         (maintenance_info_symtabs, maintenance_check_symtabs)
15564         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15565         all_objfiles.
15566         * source.c (forget_cached_source_info): Use all_objfiles.
15567         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15568         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15569         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15570         * objfiles.c (update_section_map): Use all_objfiles.
15571         (shared_objfile_contains_address_p): Likewise.
15572         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15573         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15574
15575 2019-01-09  Tom Tromey  <tom@tromey.com>
15576
15577         * common/next-iterator.h: New file.
15578         * objfiles.h (class all_objfiles): New.
15579         (struct objfile_iterator): New.
15580
15581 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15582
15583         * NEWS: Move the description of the changed "frame", "select-frame",
15584          and "info frame" commands to the Changed commands section.
15585
15586 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15587
15588         * gdbtypes.c (check_stub_method_group): Remove handling of old
15589         mangling schemes.
15590         * linespec.c (find_methods): Likewise.
15591         * stabsread.c (read_member_functions): Likewise.
15592         * valops.c (search_struct_method): Likewise.
15593         (value_struct_elt_for_reference): Likewise.
15594         * NEWS: Mention this change.
15595
15596 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15597
15598         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15599         print_source_lines.
15600         * source.c (print_source_lines_base): Update line number check.
15601         (print_source_lines): New function.
15602         (source_lines_range::source_lines_range): New function.
15603         * source.h (class source_lines_range): New class.
15604         (print_source_lines): New declaration.
15605
15606 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15607
15608         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15609
15610 2019-01-08  Tom Tromey  <tom@tromey.com>
15611             Simon Marchi  <simon.marchi@ericsson.com>
15612
15613         PR gdb/24060
15614         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15615         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15616         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15617         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15618         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15619         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15620
15621 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15622
15623         * source.c (select_source_symtab): Move header comment to
15624         declaration in source.h.
15625         (forget_cached_source_info_for_objfile): Likewise.
15626         (forget_cached_source_info): Likewise.
15627         (identify_source_line): Likewise.
15628         * source.h (identify_source_line): Move declaration from symtab.h
15629         and add comment from source.c
15630         (print_source_lines): Likewise.
15631         (forget_cached_source_info_for_objfile): Likewise.
15632         (forget_cached_source_info): Likewise.
15633         (select_source_symtab): Likewise.
15634         (enum print_source_lines_flag): Move definition from symtab.h.
15635         * symtab.h (identify_source_line): Move declaration to source.h.
15636         (print_source_lines): Likewise.
15637         (forget_cached_source_info_for_objfile): Likewise.
15638         (forget_cached_source_info): Likewise.
15639         (select_source_symtab): Likewise.
15640         (enum print_source_lines_flag): Move definition to source.h.
15641         * tui/tui-hooks.c: Add 'source.h' include.
15642
15643 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15644
15645         * source.c (print_source_lines_base): Handle requests to print
15646         reverse line number sequences, and guard against empty lines
15647         string.
15648
15649 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15650
15651         * source.c (print_source_lines_base): Fix skip of '\r' if next
15652         character is '\n'.
15653
15654 2019-01-06  Tom Tromey  <tom@tromey.com>
15655
15656         * c-exp.y (struct c_parse_state) <macro_original_text,
15657         expansion_obstack>: New member.
15658         (macro_original_text, expansion_obstack): Remove globals.
15659         (scan_macro_expansion, scanning_macro_expansion)
15660         (finished_macro_expansion): Update.
15661         (scan_macro_cleanup): Remove.
15662         (yylex, c_parse): Update.
15663
15664 2019-01-06  Tom Tromey  <tom@tromey.com>
15665
15666         * c-exp.y (struct c_parse_state) <strings>: New member.
15667         (operator_stoken): Update.
15668
15669 2019-01-06  Tom Tromey  <tom@tromey.com>
15670
15671         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15672         (union type_stack_elt) <typelist_val>: Now a pointer to
15673         std::vector.
15674         (type_stack_cleanup): Don't declare.
15675         (push_typelist): Update.
15676         * parse.c (pop_typelist): Return a std::vector.
15677         (push_typelist): Take a std::vector.
15678         (follow_types): Update.  Do not free args.
15679         (type_stack_cleanup): Remove.
15680         * c-exp.y (struct c_parse_state): New.
15681         (cpstate): New global.
15682         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15683         (nonempty_typelist): Update.
15684         (func_mod): Create a new vector.
15685         (c_parse): Create a c_parse_state.
15686         (check_parameter_typelist): Do not delete params.
15687         (function_method): Update.  Do not delete type_list.
15688
15689 2019-01-06  Tom Tromey  <tom@tromey.com>
15690
15691         PR gdb/28155:
15692         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15693         check_typedef.
15694         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15695         (print_return_value): Likewise.
15696
15697 2019-01-05  Tom Tromey  <tom@tromey.com>
15698
15699         * contrib/cleanup_check.py: Remove.
15700         * contrib/gcc-with-excheck: Remove.
15701         * contrib/exsummary.py: Remove.
15702         * contrib/excheck.py: Remove.
15703
15704 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
15705
15706         * thread.c (delete_thread_1): Add gdb_assert that THR is not
15707         NULL. Initialize tpprev to NULL instead of assigning it
15708         to NULL on the next statement.
15709         * windows-nat.c (windows_delete_thread): Remove check for
15710         main_thread_id before printing thread exit notifications.
15711         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15712         Remove thread ID check against main_thread_id.
15713         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15714         windows_delete_thread.
15715         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15716
15717 2019-01-04  Tom Tromey  <tom@tromey.com>
15718
15719         * compile/compile.c (_initialize_compile): Use upper case for
15720         metasyntactic variables.
15721         * symmisc.c (_initialize_symmisc): Use upper case for
15722         metasyntactic variables.
15723         * psymtab.c (_initialize_psymtab): Use upper case for
15724         metasyntactic variables.
15725         * demangle.c (demangle_command): Use upper case for metasyntactic
15726         variables.
15727         (_initialize_demangler): Likewise.
15728         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15729         variables.
15730
15731 2019-01-03  Tom Tromey  <tom@tromey.com>
15732
15733         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15734
15735 2019-01-03  Tom Tromey  <tom@tromey.com>
15736
15737         * python/py-symtab.c (salpy_str): Update.
15738         (struct salpy_sal_object) <symtab>: Now a PyObject.
15739         (salpy_dealloc): Update.
15740         (del_objfile_sal): Use gdbpy_ref.
15741
15742 2019-01-03  Tom Tromey  <tom@tromey.com>
15743
15744         * python/py-type.c (convert_field): Use new_reference.  Return
15745         gdbpy_ref.
15746         (make_fielditem): Return gdbpy_ref.
15747         (typy_fields): Update.
15748         (typy_getitem): Update.
15749         (field_name): Return gdbpy_ref.  Use new_reference.
15750         (typy_iterator_iternext): Update.
15751
15752 2019-01-03  Tom Tromey  <tom@tromey.com>
15753
15754         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15755
15756 2019-01-03  Tom Tromey  <tom@tromey.com>
15757
15758         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15759         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15760         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15761         (pspy_set_frame_filters, pspy_set_frame_unwinders)
15762         (pspy_set_type_printers): Likewise.
15763         * python/py-function.c (fnpy_init): Use gdbpy_ref.
15764         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15765         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15766         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15767         (objfpy_set_type_printers): Likewise.
15768
15769 2019-01-03  Tom Tromey  <tom@tromey.com>
15770
15771         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15772         (gdbpy_print_stack): Use gdbpy_err_fetch.
15773         * python/python-internal.h (class gdbpy_err_fetch): New class.
15774         (class gdbpy_enter) <m_error_type, m_error_value,
15775         m_error_traceback>: Remove.
15776         <m_error>: New member.
15777         (gdbpy_exception_to_string): Don't declare.
15778         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15779         * python/py-value.c (convert_value_from_python): Use
15780         gdbpy_err_fetch.
15781         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15782         gdbpy_exception_to_string.
15783         (gdbpy_handle_exception): Use gdbpy_err_fetch.
15784         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15785         gdbpy_err_fetch.
15786
15787 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15788
15789         * linux-nat.c (delete_lwp_cleanup): Delete.
15790         (struct lwp_deleter): New struct.
15791         (lwp_info_up): New typedef.
15792         (linux_nat_target::follow_fork): Delete cleanup, and make use of
15793         lwp_info_up.
15794
15795 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15796
15797         * linux-fork.c (class scoped_switch_fork_info): New class.
15798         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15799
15800 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15801
15802         * valops.c (find_overload_match): Remove use of null_cleanup, and
15803         calls to do_cleanups.
15804
15805 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15806
15807         * compile/compile-cplus-types.c
15808         (compile_cplus_instance::decl_name): Handle changes to
15809         cp_func_name.
15810         * cp-support.c (cp_func_name): Update header comment, update
15811         return type.
15812         * cp-support.h (cp_func_name): Update return type in declaration.
15813         * valops.c (find_overload_match): Move temp_func local to top
15814         level of function and change its type.  Use temp_func to hold and
15815         delete temporary string obtained from cp_func_name.
15816
15817 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15818
15819         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15820         gdb::char_vector, remove cleanup, and update uses of `msg`.
15821
15822 2019-01-03  Jim Wilson  <jimw@sifive.com>
15823
15824         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15825
15826 2019-01-02  Tom Tromey  <tom@tromey.com>
15827
15828         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15829         (tdesc_parse_xml): Remove cleanups.
15830         * target-descriptions.h (make_cleanup_free_target_description):
15831         Don't declare.
15832         (target_desc_deleter): New struct.
15833         (target_desc_up): New typedef.
15834         * target-descriptions.c (target_desc_deleter::operator()): Rename
15835         from free_target_description.
15836         (make_cleanup_free_target_description): Remove.
15837
15838 2019-01-02  Tom Tromey  <tom@tromey.com>
15839
15840         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
15841         constructor, destructor.
15842         (linespec_parser): Remove typedef.
15843         (~linespec_parser): Rename from linespec_parser_delete.
15844         (linespec_lex_to_end, linespec_complete_label)
15845         (linespec_complete): Update.
15846         (decode_line_full): Remove cleanups.
15847         (decode_line_1): Update.
15848
15849 2019-01-02  Tom Tromey  <tom@tromey.com>
15850
15851         * python/python-internal.h (inferior_to_inferior_object): Change
15852         return type.
15853         * python/py-exitedevent.c (create_exited_event_object): Update.
15854         * python/py-inferior.c (inferior_to_inferior_object): Return
15855         gdbpy_ref.
15856         (python_new_inferior, python_inferior_deleted)
15857         (thread_to_thread_object, delete_thread_object)
15858         (build_inferior_list, gdbpy_selected_inferior): Update.
15859         * python/py-infthread.c (create_thread_object): Update.  Also fail
15860         if inferior_to_inferior_object fails.
15861
15862 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
15863
15864         * inferior.h (class inferior) <displaced_step_state>: New field.
15865         * infrun.h (struct displaced_step_state): Move here from
15866         infrun.c.  Initialize fields, add constructor.
15867         <inf>: Remove field.
15868         <reset>: New method.
15869         * infrun.c (struct displaced_step_inferior_state): Move to
15870         infrun.h.
15871         (displaced_step_inferior_states): Remove.
15872         (get_displaced_stepping_state): Adust.
15873         (displaced_step_in_progress_any_inferior): Adjust.
15874         (displaced_step_in_progress_thread): Adjust.
15875         (displaced_step_in_progress): Adjust.
15876         (add_displaced_stepping_state): Remove.
15877         (get_displaced_step_closure_by_addr): Adjust.
15878         (remove_displaced_stepping_state): Remove.
15879         (infrun_inferior_exit): Call displaced_step_state.reset.
15880         (use_displaced_stepping): Don't check for NULL.
15881         (displaced_step_prepare_throw): Call
15882         get_displaced_stepping_state.
15883         (displaced_step_fixup): Don't check for NULL.
15884         (prepare_for_detach): Don't check for NULL.
15885
15886 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15887
15888         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15889          in case of call that did not complete.
15890
15891 2019-01-02  Andrey Utkin  <autkin@undo.io>
15892
15893         * symfile.c (find_separate_debug_file): Fix search of debug files for
15894         remote debuggee.
15895
15896 2019-01-02  Tom Tromey  <tom@tromey.com>
15897
15898         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15899         indentation.
15900         * python/py-frame.c (frapy_older): Remove cast.
15901         (frapy_newer): Likewise.
15902         * python/py-breakpoint.c (local_setattro): Remove cast.
15903         * python/py-arch.c (archpy_name): Remove local variable.
15904         * python/py-type.c (gdbpy_lookup_type): Remove cast.
15905
15906 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
15907
15908         * unittests/basic_string_view/element_access/char/empty.cc:
15909         Fix year range in copyright header.
15910
15911 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
15912
15913         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
15914         Delete.
15915         <operator==>: Update with for removed field.
15916         <hash>: Likewise.
15917         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
15918         <isa_features>: ...this.
15919         <abi_features>: New field.
15920         (riscv_isa_flen): Update comment.
15921         (riscv_abi_xlen): New declaration.
15922         (riscv_abi_flen): New declaration.
15923         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
15924         isa_features.
15925         (riscv_abi_xlen): New function.
15926         (riscv_isa_flen): Update to get answer from isa_features.
15927         (riscv_abi_flen): New function.
15928         (riscv_has_fp_abi): Update to get answer from abi_features.
15929         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
15930         xlen and flen.
15931         (riscv_call_info) <xlen, flen>: Update comment.
15932         (riscv_call_arg_struct): Remove invalid assertions
15933         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
15934         is removed.
15935         (riscv_gdbarch_init): Gather isa features and abi features
15936         separately, ensure both match on the gdbarch when reusing an old
15937         gdbarch.  Relax an error check to allow 32-bit abi float to run on
15938         a target with 64-bit float hardware.
15939
15940 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15941
15942         * source.c (search_command_helper): Stop reverse search
15943         when line 1 has been searched.
15944
15945 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15946
15947         * record-full.c (record_full_base_target::close): Rewrite
15948         record_full_core_buf_list free logic.
15949
15950 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15951
15952         * break-catch-syscall.c (print_one_catch_syscall): xfree
15953         the last text.
15954
15955 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15956
15957         * top.c (print_gdb_version): Update Copyright year in version
15958         message.
15959
15960 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15961
15962         Update copyright year range in all GDB files.
15963
15964 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
15965
15966         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
15967
15968 For older changes see ChangeLog-2018.
15969 \f
15970 Local Variables:
15971 mode: change-log
15972 left-margin: 8
15973 fill-column: 74
15974 version-control: never
15975 coding: utf-8
15976 End:
15977