gdb/ChangeLog

   1 2019-10-15  Tom Tromey  <tromey@adacore.com>
   2
   3         * windows-nat.c (windows_nat_target::resume): Use %x when logging
   4         TID.
   5
   6 2019-10-15  Tom Tromey  <tromey@adacore.com>
   7
   8         * windows-nat.c (windows_nat_target::fetch_registers)
   9         (windows_nat_target::store_registers): Rename "pid" to "tid".
  10
  11 2019-10-15  Tom Tromey  <tromey@adacore.com>
  12
  13         * gdbarch.h, gdbarch.c: Rebuild.
  14         * gdbarch.sh (gcc_target_options): Change return type to
  15         std::string.
  16         * compile/compile.c (get_args): Update.
  17         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
  18         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
  19         std::string.
  20         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
  21         std::string.
  22         * arch-utils.c (default_gcc_target_options): Return std::string.
  23         * arch-utils.h (default_gcc_target_options): Return std::string.
  24         * s390-tdep.c (s390_gcc_target_options): Return std::string.
  25
  26 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
  27
  28         * breakpoint.c (breakpoint_chain): Make static.
  29         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
  30         of accessing breakpoint_chain.
  31
  32 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
  33
  34         * breakpoint.c (iterate_over_breakpoints): Change function pointer
  35         to a gdb::function_view and return value to bool.
  36         * breakpoint.h (iterate_over_breakpoints): Likewise.
  37         * dummy-frame.c (pop_dummy_frame_bpt): Update.
  38         (pop_dummy_frame): Update.
  39         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
  40         (gdbscm_breakpoints): Update.
  41         * python/py-breakpoint.c (build_bp_list): Update.
  42         (gdbpy_breakpoints): Update.
  43         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
  44         Update.
  45         (bpfinishpy_handle_stop): Update.
  46         (bpfinishpy_handle_exit): Update.
  47         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
  48         (svr4_update_solib_event_breakpoints): Update.
  49
  50 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
  51
  52         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
  53         when unwrapping single-field structs.
  54
  55 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
  56
  57         * dwarf2read.c: Remove includes.
  58
  59 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
  60
  61         * ui-out.c (ui_out::call_do_message): Silence
  62         -Wformat-nonliteral warning.
  63
  64 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
  65
  66         * breakpoint.c: Remove some includes: continuations.h, skip.h,
  67         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
  68         include: readline/tilde.h.
  69
  70 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
  71
  72         * remote.c (remote_target::get_trace_status): Remove declaration of
  73         trace_regblock_size.
  74
  75 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
  76
  77         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
  78         (show_user): Remove declaration of cmdlist.
  79         * cli/cli-cmds.h (max_user_call_depth): Declare.
  80         * cli/cli-script.c (execute_user_command): Remove declaration
  81         of max_user_call_depth.
  82
  83 2019-10-11  Jim Wilson  <jimw@sifive.com>
  84
  85         * gdbsupport/print-utils.h (pulongest): Fix comment.
  86         (plongest): Likewise.
  87         (phex): Add missing comment, mention leading zeros.
  88         (phex_nz): Add mention of no leading zeros to comment.
  89
  90         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
  91         plongest instead of unsigned long long cast.
  92
  93 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
  94
  95         * main.c (captured_main_1): Include gdbtk.h and remove declarations
  96         for external_editor_command and gdbtk_test.
  97
  98 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
  99
 100         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 101         * varobj.c (varobjdebug): Move comment to...
 102         * varobj.h (varobjdebug): ...here, and declare.
 103
 104 2019-10-09  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 107         erase_data_content.
 108
 109 2019-10-09  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 112         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 113         * tui/tui-command.c (tui_cmd_window::resize)
 114         (tui_refresh_cmd_win): Update.
 115         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 116         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 117         * tui/tui-data.c (~tui_gen_win_info): Remove.
 118         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 119         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 120         (tui_redisplay_readline, tui_mld_flush)
 121         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 122         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 123         (tui_data_window::erase_data_content)
 124         (tui_data_item_window::rerender)
 125         (tui_data_item_window::refresh_window): Update.
 126         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 127         (box_win, tui_gen_win_info::make_window)
 128         (tui_gen_win_info::make_visible): Update.
 129         (tui_delete_win): Remove.
 130         * tui/tui-winsource.c
 131         (tui_source_window_base::do_erase_source_content): Update.
 132         (tui_show_source_line, tui_source_window_base::update_tab_width)
 133         (tui_source_window_base::update_exec_info): Update.
 134         * tui/tui-data.h (struct curses_deleter): New.
 135         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 136         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 137
 138 2019-10-09  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 141
 142 2019-10-09  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 145         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 146
 147 2019-10-09  Tom Tromey  <tom@tromey.com>
 148
 149         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 150         window height directly.
 151         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 152         declare.
 153         * tui/tui-layout.c (tui_default_win_height): Remove.
 154         (tui_default_win_viewport_height): Remove.
 155
 156 2019-10-09  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui.h: Remove comments.
 159
 160 2019-10-09  Tom de Vries  <tdevries@suse.de>
 161
 162         * python/lib/gdb/printer/bound_registers.py: Use
 163         '^builtin_type_bound128' as regexp argument for
 164         add_builtin_pretty_printer.
 165
 166 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 167
 168         * guile/guile.c (guile_extension_script_ops): Remove forward
 169         declaration and mark as static.
 170         (guile_script_ops): Likewise.
 171         (extension_language_guile): Move further down in the file so
 172         it can reference the definitions for guile_{extension_,}script_ops.
 173
 174 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 175
 176         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 177         except SORTL, DFLTCC, and KDSA.
 178
 179 2019-10-08  Tom Tromey  <tromey@adacore.com>
 180
 181         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 182         (struct safe_symbol_file_add_args): Remove.
 183
 184 2019-10-08  Tom Tromey  <tromey@adacore.com>
 185
 186         * windows-nat.c: Don't include buildsym-legacy.h.
 187
 188 2019-10-08  Tom Tromey  <tromey@adacore.com>
 189
 190         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 191
 192 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 193
 194         * gdbtypes.c (overload_debug): Move comment to header.
 195         * gdbtypes.h (overload_debug): Declare.
 196         * valops.c: Remove declaration of overload_debug, instead
 197         include gdbtypes.h.
 198
 199 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 200
 201         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 202         through _().
 203         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 204         move comment...
 205         * language.h (lang_frame_mismatch_warn): ... here. Also add
 206         declaration.
 207         * top.c (lang_frame_mismatch_warn): Remove declaration.
 208         (check_frame_language_change): Pass lang_frame_mismatch_warn
 209         through _().
 210
 211 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 212
 213         * c-lang.h (vtbl_ptr_name): Declare.
 214         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 215         it from the header.
 216         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 217
 218 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 219
 220         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 221         gdb_static_assert.
 222
 223 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 224
 225         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 226         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 227         * ctfread.c: New file.
 228         * ctfread.h: New file.
 229         * elfread.c: Include ctfread.h.
 230         (struct elfinfo text_p): New member ctfsect.
 231         (elf_locate_sections): Mark CTF section.
 232         (elf_symfile_read): Call elfctf_build_psymtabs.
 233         * Makefile.in (LIBCTF): Add.
 234         (CLIBS): Use it.
 235         (CDEPS): Likewise.
 236         (DIST): Add ctfread.c.
 237
 238 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 239
 240         * ctfread.c (struct nextfield): Renamed to ...
 241         (struct ctf_nextfield): ... this.
 242         (struct field_info): Renamed to ...
 243         (strut ctf_field_info): ... this.
 244         (attach_fields_to_type): Update for renamed structures.
 245         (ctf_add_member_cb): Likewise.
 246         (ctf_add_enum_member_cb): Likewise.
 247         (process_struct_members): Likewise.
 248         (process_enum_type): Likewise.
 249
 250 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 251
 252         * tracectf.h: Rename, was ctf.h.
 253         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 254         * tracefile.c: Likewise.
 255         * tracepoint.c: Remove unused include ctf.h.
 256         * mi/mi-main.c: Likewise.
 257         * Makefile.in Replace ctf.c with tracectf.c.
 258
 259 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 260
 261         * version.in: Change version number to "9.0.50.DATE-git".
 262
 263 2019-10-03  Tom Tromey  <tom@tromey.com>
 264
 265         PR rust/24976:
 266         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 267
 268 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 269
 270         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 271         cp_search_name_hash.
 272         * NEWS: Add entry about nested function support.
 273
 274 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 275             Andrew Burgess  <andrew.burgess@embecosm.com>
 276
 277         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 278         for nested static variables when searchin VAR_DOMAIN.
 279         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 280         global scope, update comment.
 281         (add_partial_subprogram): Call add_partial_subprogram recursively
 282         for nested subroutines when processinng Fortran.
 283         (load_partial_dies): Process the child entities of a subprogram
 284         when processing Fortran.
 285         (partial_die_parent_scope): Handle building scope
 286         for Fortran nested functions.
 287         (process_die): Record that nested functions have a scope.
 288         (new_symbol): Always record Fortran subprograms on the global
 289         symbol list.
 290         (determine_prefix): How to build the prefix for Fortran
 291         subprograms.
 292
 293 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 294
 295         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 296         have just sent the thread a SIGSTOP and are waiting for it to
 297         arrive.
 298
 299 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 300
 301         * btrace.c (btrace_add_pc): Remove whitespace before the template
 302         parameter in 'std::vector <...>'.
 303         (parse_xml_btrace_block): Likewise.
 304         (btrace_maint_decode_pt): Likewise.
 305         (btrace_maint_update_packets): Likewise.
 306         (btrace_maint_print_packets): Likewise.
 307         * btrace.h (struct btrace_maint_info): Likewise.
 308         * dwarf2read.c (struct type_unit_group): Likewise.
 309         (build_type_psymtabs_reader): Likewise.
 310         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 311         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 312         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 313
 314 2019-10-03  Tom de Vries  <tdevries@suse.de>
 315
 316         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 317         the first line of the help text for set/show style metadata.
 318
 319 2019-10-02  Tom Tromey  <tromey@adacore.com>
 320
 321         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 322         * gdbsupport/common-inferior.c: New file.
 323         * infcmd.c (startup_with_shell): Don't define.
 324         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 325         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 326         * inferior.h (startup_with_shell): Don't declare.
 327
 328 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 329
 330         * gdbsupport/gdb_assert.h: Include errors.h.
 331         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 332
 333 2019-10-02  Tom Tromey  <tromey@adacore.com>
 334
 335         * NEWS: Add $_ada_exception entry.
 336         * ada-lang.c (struct ada_catchpoint): Add constructor.
 337         <m_kind>: New member.
 338         (allocate_location_exception, re_set_exception): Remove
 339         "ex" parameter.
 340         (should_stop_exception): Compute $_ada_exception.
 341         (check_status_exception, print_it_exception)
 342         (print_one_exception, print_mention_exception): Remove
 343         "ex" parameter.
 344         (allocate_location_catch_exception, re_set_catch_exception)
 345         (check_status_exception, print_it_catch_exception)
 346         (print_one_catch_exception, print_mention_catch_exception)
 347         (print_recreate_catch_exception)
 348         (allocate_location_catch_exception_unhandled)
 349         (re_set_catch_exception_unhandled)
 350         (check_status_exception, print_it_catch_exception_unhandled)
 351         (print_one_catch_exception_unhandled)
 352         (print_mention_catch_exception_unhandled)
 353         (print_recreate_catch_exception_unhandled)
 354         (allocate_location_catch_assert, re_set_catch_assert)
 355         (check_status_assert, print_it_catch_assert)
 356         (print_one_catch_assert, print_mention_catch_assert)
 357         (print_recreate_catch_assert)
 358         (allocate_location_catch_handlers, re_set_catch_handlers)
 359         (check_status_handlers, print_it_catch_handlers)
 360         (print_one_catch_handlers, print_mention_catch_handlers)
 361         (print_recreate_catch_handlers): Remove.
 362         (create_ada_exception_catchpoint): Update.
 363         (initialize_ada_catchpoint_ops): Update.
 364
 365 2019-10-02  Tom Tromey  <tromey@adacore.com>
 366
 367         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 368         (create_excep_cond_exprs): Simplify exception string computation.
 369         (ada_exception_catchpoint_cond_string): Likewise.
 370
 371 2019-10-02  Tom Tromey  <tromey@adacore.com>
 372
 373         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 374         * ada-lang.c (lesseq_defined_than): Handle
 375         LOC_STATIC.
 376         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 377         parameter.
 378         (dwarf2_has_info): Likewise.
 379         (new_symbol): Set maybe_copied on symbol when
 380         appropriate.
 381         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 382         parameter.
 383         <can_copy>: New member.
 384         * elfread.c (record_minimal_symbol): Set maybe_copied
 385         on symbol when appropriate.
 386         (elf_symfile_read): Update call to dwarf2_has_info.
 387         * minsyms.c (lookup_minimal_symbol_linkage): New
 388         function.
 389         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 390         * symtab.c (get_symbol_address, get_msymbol_address):
 391         New functions.
 392         * symtab.h (get_symbol_address, get_msymbol_address):
 393         Declare.
 394         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 395         maybe_copied.
 396         (struct symbol, struct minimal_symbol) <maybe_copied>:
 397         New member.
 398
 399 2019-10-02  Tom Tromey  <tromey@adacore.com>
 400
 401         * source.c (struct current_source_location): New.
 402         (current_source_key): New global.
 403         (current_source_symtab, current_source_line)
 404         (current_source_pspace): Remove.
 405         (get_source_location): New function.
 406         (get_current_source_symtab_and_line)
 407         (set_default_source_symtab_and_line)
 408         (set_current_source_symtab_and_line)
 409         (clear_current_source_symtab_and_line, select_source_symtab)
 410         (info_source_command, print_source_lines_base)
 411         (info_line_command, search_command_helper, _initialize_source):
 412         Update.
 413
 414 2019-10-02  Tom Tromey  <tromey@adacore.com>
 415
 416         * source.c (select_source_symtab): Don't call
 417         decode_line_with_current_source.
 418
 419 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 420
 421         * symtab.c (lookup_global_symbol): Search global block.
 422
 423 2019-10-02  Tom Tromey  <tromey@adacore.com>
 424
 425         * coffread.c (process_coff_symbol): Update.
 426         * dwarf2read.c (var_decode_location, new_symbol): Update.
 427         * mdebugread.c (parse_symbol): Update.
 428         * objfiles.c (relocate_one_symbol): Update.
 429         * stabsread.c (define_symbol, fix_common_block)
 430         (scan_file_globals): Update.
 431         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 432         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 433         * xcoffread.c (process_xcoff_symbol): Update.
 434
 435 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 436
 437         * MAINTAINERS: Update my email address.
 438
 439 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 440
 441         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 442         std::vector.
 443         (build_type_psymtabs_reader): Update for std::vector.
 444         (build_type_psymtab_dependencies): Likewise.
 445         * dwarf2read.h: Remove use of DEF_VEC_P.
 446         (typedef sig_type_ptr): Delete.
 447
 448 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 449
 450         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 451         to std::vector.
 452         (btrace_maint_decode_pt): Likewise, and move allocation of the
 453         vector outside of the loop.
 454         (btrace_maint_update_packets): Update to handle change from VEC to
 455         std::vector.
 456         (btrace_maint_print_packets): Likewise.
 457         (maint_info_btrace_cmd): Likewise.
 458         * btrace.h: Remove use of DEF_VEC_O.
 459         (typedef btrace_pt_packet_s): Delete.
 460         (struct btrace_maint_info) <packets>: Change fromm VEC to
 461         std::vector.
 462         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 463
 464 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 465
 466         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 467         make accesses into the vector constant references.
 468         (btrace_add_pc): Update for std::vector.
 469         (btrace_stitch_bts): Likewise.
 470         (parse_xml_btrace_block): Likewise.
 471         (btrace_maint_update_packets): Likewise.
 472         (btrace_maint_print_packets): Likewise.
 473         (maint_info_btrace_cmd): Likewise.
 474         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 475         std::vector.
 476         (btrace_data::empty): Likewise.
 477         (btrace_data_append): Likewise.
 478         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 479         (typedef btrace_block_s): Delete.
 480         (struct btrace_block): Add constructor.
 481         (struct btrace_data_bts) <blocks>: Change to std::vector.
 482         * nat/linux-btrace.c (perf_event_read_bts): Update for
 483         std::vector.
 484         (linux_read_bts): Likewise.
 485
 486 2019-10-01  Tom Tromey  <tom@tromey.com>
 487
 488         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 489
 490 2019-10-01  Tom Tromey  <tom@tromey.com>
 491
 492         * stack.c (print_frame, info_frame_command_core): Use
 493         styled_string.
 494         * linux-thread-db.c (try_thread_db_load_1)
 495         (try_thread_db_load_from_pdir_1): Use styled_string.
 496         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 497         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 498         (maybe_print_unsupported_script_warning)
 499         (maybe_print_script_not_found_warning): Use styled_string.
 500         * ada-lang.c (user_select_syms): Use styled_string.
 501
 502 2019-10-01  Tom Tromey  <tom@tromey.com>
 503
 504         * p-lang.c (pascal_printstr): Use metadata style.
 505         * value.c (show_convenience): Use metadata style.
 506         * valprint.c (valprint_check_validity, val_print_optimized_out)
 507         (val_print_not_saved, val_print_unavailable)
 508         (val_print_invalid_address, generic_val_print, val_print)
 509         (value_check_printable, val_print_array_elements): Use metadata
 510         style.
 511         * ui-out.h (class ui_out) <field_fmt>: New overload.
 512         <do_field_fmt>: Add style parameter.
 513         * ui-out.c (ui_out::field_fmt): New overload.
 514         * typeprint.c (type_print_unknown_return_type)
 515         (val_print_not_allocated, val_print_not_associated): Use metadata
 516         style.
 517         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 518         parameter.
 519         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 520         * tracepoint.c (tvariables_info_1): Use metadata style.
 521         * stack.c (print_frame_arg, print_frame_info, print_frame)
 522         (info_frame_command_core): Use metadata style.
 523         * skip.c (info_skip_command): Use metadata style.
 524         * rust-lang.c (rust_print_enum): Use metadata style.
 525         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 526         metadata style.
 527         * python/py-framefilter.c (py_print_single_arg): Use metadata
 528         style.
 529         * printcmd.c (do_one_display, print_variable_and_value): Use
 530         metadata style.
 531         * p-valprint.c (pascal_val_print)
 532         (pascal_object_print_value_fields): Use metadata style.
 533         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 534         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 535         parameter.
 536         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 537         * m2-valprint.c (m2_print_long_set): Use metadata style.
 538         * m2-typeprint.c (m2_print_type): Use metadata style.
 539         * infcmd.c (print_return_value_1): Use metadata style.
 540         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 541         * f-valprint.c (info_common_command_for_block): Use metadata
 542         style.
 543         * f-typeprint.c (f_type_print_base): Use metadata style.
 544         * expprint.c (print_subexp_standard): Use metadata style.
 545         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 546         * cli/cli-style.h (class cli_style_option): Add constructor.
 547         (metadata_style): Declare.
 548         * cli/cli-style.c (metadata_style): New global.
 549         (_initialize_cli_style): Register metadata style.
 550         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 551         parameter.
 552         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 553         * c-typeprint.c (c_type_print_base_struct_union)
 554         (c_type_print_base_1): Use metadata style.
 555         * breakpoint.c (watchpoint_value_print)
 556         (print_one_breakpoint_location): Use metadata style.
 557         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 558         style.
 559         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 560         style.
 561         * ada-valprint.c (val_print_packed_array_elements, printstr)
 562         (print_field_values, ada_val_print_ref, ada_val_print): Use
 563         metadata style.
 564         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 565         style.
 566         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 567         style.
 568         * ada-lang.c (user_select_syms): Use metadata style.
 569
 570 2019-10-01  Tom Tromey  <tom@tromey.com>
 571
 572         * cli/cli-cmds.c (pwd_command): Style output.
 573
 574 2019-10-01  Pedro Alves  <palves@redhat.com>
 575             Tom Tromey  <tom@tromey.com>
 576
 577         * symtab.c (print_symbol_info): Use %ps.
 578         (print_msymbol_info): Use %ps.
 579         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 580         * printcmd.c (print_variable_and_value): Use %ps.
 581         * macrocmd.c (show_pp_source_pos): Use %ps.
 582         * infrun.c (print_exited_reason): Use ui_out::message.
 583         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 584         (describe_other_breakpoints): Use ui_out::message and new
 585         formats.
 586         (say_where): Use new formats.
 587         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 588         and new formats.
 589
 590 2019-10-01  Pedro Alves  <palves@redhat.com>
 591             Tom Tromey  <tom@tromey.com>
 592
 593         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 594         (test_gdb_formats): New function.
 595         (run_tests): Call it.
 596         (test_format_specifier): Update.
 597         * utils.h (fputs_filtered): Update comment.
 598         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 599         (fputs_styled_unfiltered): Declare.
 600         * utils.c (fputs_styled_unfiltered): New function.
 601         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 602         (vfprintf_filtered): Update.
 603         (vfprintf_unfiltered, vprintf_filtered): Update.
 604         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 605         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 606         disallow_ui_out_field>: New constants.
 607         (enum class field_kind): New.
 608         (struct base_field_s, struct signed_field_s): New.
 609         (signed_field): New function.
 610         (struct string_field_s): New.
 611         (string_field): New function.
 612         (struct styled_string_s): New.
 613         (styled_string): New function.
 614         (class ui_out) <message>: Add comment.
 615         <vmessage, call_do_message>: New methods.
 616         <do_message>: Add style parameter.
 617         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 618         methods.
 619         (ui_out::message): Rewrite.
 620         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 621         parameter.
 622         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 623         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 624         gdb_extensions parameter.
 625         (class format_piece): Add parameter to constructor.
 626         (n_int_args): New field.
 627         * gdbsupport/format.c (format_pieces::format_pieces): Add
 628         gdb_extensions parameter.  Handle '*'.
 629         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 630         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 631         vfprintf_styled_no_gdbfmt.
 632         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 633         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 634         unfiltered output.
 635         * ui-style.h (struct ui_file_style) <ptr>: New method.
 636
 637 2019-10-01  Tom Tromey  <tom@tromey.com>
 638
 639         * unittests/format_pieces-selftests.c: Update.  Add final format.
 640         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 641         empty literal pieces.
 642
 643 2019-10-01  Tom Tromey  <tom@tromey.com>
 644
 645         * ui-out.h (enum class ui_out_style_kind): Remove.
 646         (class ui_out) <field_string, field_stsream, do_field_string>:
 647         Change type of "style".
 648         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 649         (ui_out::field_string): Update.
 650         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 651         of "style".
 652         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 653         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 654         * stack.c (print_frame_arg, print_frame_info, print_frame):
 655         Update.
 656         * source.c (print_source_lines_base): Update.
 657         * solib.c (info_sharedlibrary_command): Update.
 658         * skip.c (info_skip_command): Update.
 659         * record-btrace.c (btrace_call_history_src_line)
 660         (btrace_call_history): Update.
 661         * python/py-framefilter.c (py_print_frame): Update.
 662         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 663         "style".
 664         * mi/mi-out.c (mi_ui_out::do_table_header)
 665         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 666         (mi_ui_out::do_field_string): Update.
 667         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 668         Update.
 669         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 670         "style".
 671         * cli-out.c (cli_ui_out::do_table_header)
 672         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 673         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 674         (cli_ui_out::do_field_fmt): Update.
 675         * breakpoint.c (print_breakpoint_location): Update.
 676         (update_static_tracepoint): Update.
 677
 678 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 679
 680         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 681         conversion of gdb_datadir.
 682         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 683         remove not needed c_str ().
 684
 685 2019-09-30  Ali Tamur <tamur@google.com>
 686
 687         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 688         (dwarf2_string_attr): Likewise.
 689
 690 2019-09-30  Ali Tamur <tamur@google.com>
 691
 692         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 693         (process_full_type_unit): Likewise.
 694         (dump_die_shallow): Likewise.
 695         (cu_debug_loc_section): Likewise.
 696
 697 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 698
 699         * minsyms.c (compare_minimal_symbols): Rename to...
 700         (minimal_symbol_is_less_than): ...this, and adjust to STL
 701         conventions (return bool, take arguments as references)
 702         (minimal_symbol_reader::install): Call std::sort instead
 703         of qsort.
 704
 705 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 706
 707         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 708         hash and why.
 709         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 710         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 711
 712 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 713
 714         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 715         * psympriv.h (add_psymbol_to_list): Move comment here and update
 716         it.
 717
 718 2019-09-29  Tom de Vries  <tdevries@suse.de>
 719
 720         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 721         Use $tmpdir/$(basename "$output_file").dwz instead of
 722         "${output_file}.dwz".
 723
 724 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 725
 726         PR gdb/25045
 727         * hppa-linux-nat.c: Include gdbarch.h.
 728
 729 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 730
 731         * blockframe.c (find_pc_partial_function): Change return type to bool.
 732         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 733         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 734         (stub_gnu_ifunc_resolve_name): Likewise.
 735         * symtab.c (compare_filenames_for_search): Likewise.
 736         (compare_glob_filenames_for_search): Likewise.
 737         (matching_obj_sections): Likewise.
 738         (symbol_matches_domain): Likewise.
 739         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 740         (find_line_pc): Change return type to bool.
 741         (find_line_pc_range): Likewise.
 742         (producer_is_realview): Likewise.
 743         * symtab.h (symbol_matches_domain): Likewise.
 744         (find_pc_partial_function): Likewise.
 745         (find_pc_line_pc_range): Likewise.
 746         (in_gnu_ifunc_stub): Likewise.
 747         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 748         (find_line_pc): Likewise.
 749         (find_line_pc_range): Likewise.
 750         (matching_obj_sections): Likewise.
 751         (find_line_symtab): Change out parameter to bool.
 752         (producer_is_realview): Change return type to bool.
 753         (compare_filenames_for_search): Likewise.
 754         (compare_glob_filenames_for_search): Likewise.
 755
 756 2019-09-26  Tom Tromey  <tom@tromey.com>
 757
 758         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 759         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 760         * gdb_usleep.h: Remove.
 761         * gdb_usleep.c: Remove.
 762         * utils.c: Don't include gdb_usleep.h.
 763
 764 2019-09-26  Tom Tromey  <tromey@adacore.com>
 765
 766         * python/py-type.c (type_to_type_object): Call check_typedef
 767         for stub types.
 768
 769 2019-09-26  Tom Tromey  <tom@tromey.com>
 770
 771         * utils.h (initialize_utils): Don't declare.
 772         * top.c (gdb_init): Don't call initialize_utils.
 773         * utils.c (initialize_utils): Remove.  Move contents...
 774         (_initialize_utils): ... here.
 775
 776 2019-09-25  Tom Tromey  <tom@tromey.com>
 777
 778         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 779         * utils.h (make_hex_string): Don't declare.
 780         * utils.c (make_hex_string): Remove.
 781
 782 2019-09-24  Tom de Vries  <tdevries@suse.de>
 783
 784         PR gdb/23815
 785         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 786         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 787
 788 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 789
 790         * NEWS: Mention new simulator port for PRU.
 791
 792 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 793
 794         * ada-exp.y (write_object_remaining): Update.
 795         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 796         and eliminate the static buffer.
 797         (ada_decode_symbol): Update.
 798         (ada_la_decode): Update.
 799         (ada_sniff_from_mangled_name): Update.
 800         (is_valid_name_for_wild_match): Update.
 801         (ada_lookup_name_info::matches): Update and simplify.
 802         (name_matches_regex): Update.
 803         (ada_add_global_exceptions): Update.
 804         * ada-lang.h (ada_decode): Update signature.
 805         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 806         * dwarf-index-write.c (debug_names::insert): Update.
 807
 808 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 809
 810         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 811         formatting.
 812
 813 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 814
 815         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 816         Change "nonzero" to "true" in documentation.
 817
 818 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 819
 820         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 821         (_initialize_darwin_solib): Don't set
 822         darwin_so_ops.lookup_lib_global_symbol.
 823         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 824         set_gdbarch_iterate_over_objfiles_in_search_order.
 825         (elf_lookup_lib_symbol): Rename to...
 826         (svr4_iterate_over_objfiles_in_search_order): this, and update
 827         to iterate semantics.
 828         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 829         * solib.c (solib_global_lookup): Remove.
 830         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 831         (solib_global_lookup): Remove.
 832         * symtab.c (lookup_global_or_static_symbol): Remove call to
 833         solib_global_lookup.
 834
 835 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 836
 837         * NEWS: Move entries about default MI version now being
 838         version 3, and about the GDB/MI fix for multi-location
 839         breakpoints to the "since GDB 8.3" section.
 840
 841 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 842
 843         GDB 8.3.1 released.
 844
 845 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 846
 847         * NEWS: Mention that Cell/B.E. debugging support was removed.
 848         * MAINTAINERS: Remove spu target.
 849
 850         * config/djgpp/fnchange.lst: Remove entries for removed files.
 851
 852         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 853         spu-multiarch.o, and spu-tdep.o.
 854         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 855         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 856         spu-multiarch.c, and spu-tdep.c.
 857         * spu-linux-nat.c: Remove file.
 858         * spu-multiarch.c: Remove file.
 859         * spu-tdep.c: Remove file.
 860         * spu-tdep.h: Remove file.
 861         * solib-spu.c: Remove file.
 862         * solib-spu.h: Remove file.
 863
 864         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 865         * configure.nat (spu-linux): Remove.
 866         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 867         solib-multiarch.o from gdb_target_obs.
 868         (spu*-*-*): Remove.
 869
 870         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 871         feature flag.
 872         (ppc_linux_no_features): Update.
 873         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 874         Cell/B.E. support.
 875         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 876         (tdesc_powerpc_cell64l): Likewise.
 877         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 878         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 879         Cell/B.E. support.
 880         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 881         Do not include "features/rs6000/powerpc-cell32l.c" or
 882         "features/rs6000/powerpc-cell64l.c".
 883         (ppc_linux_spu_section): Remove.
 884         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 885         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 886         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 887         (ppc_linux_spe_context_lookup): Remove.
 888         (ppc_linux_spe_context_inferior_created): Remove.
 889         (ppc_linux_spe_context_solib_loaded): Remove.
 890         (ppc_linux_spe_context_solib_unloaded): Remove.
 891         (ppc_linux_spe_context): Remove.
 892         (struct ppu2spu_cache): Remove.
 893         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 894         (struct ppu2spu_data): Remove.
 895         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 896         ppu2spu_unwind): Remove.
 897         (ppc_linux_init_abi): Remove Cell/B.E. support.
 898         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 899
 900         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 901         (rs6000/powerpc-cell64l-expedite): Likewise
 902         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 903         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 904         rs6000/powerpc-cell64l.xml.
 905         * features/rs6000/powerpc-cell32l.xml: Remove.
 906         * features/rs6000/powerpc-cell64l.xml: Likewise.
 907         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 908         * features/rs6000/powerpc-cell64l.c: Likewise.
 909         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 910         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 911         * regformats/reg-spu.dat: Remove.
 912
 913         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 914         * corelow.c (struct spuid_list): Remove.
 915         (add_to_spuid_list): Remove.
 916         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 917         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 918         (remote_protocol_features): Remove associated entries.
 919         (_initialize_remote): No longer initialize them.
 920         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 921         * linux-nat.c (SPUFS_MAGIC): Remove.
 922         (linux_proc_xfer_spu): Remove.
 923         (spu_enumerate_spu_ids): Remove.
 924         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 925         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 926         (linux_make_corefile_notes): No longer call it.
 927
 928         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 929         (cooked_write_test): Likewise.
 930
 931 2019-09-20  Tom Tromey  <tom@tromey.com>
 932
 933         * NEWS: Mention case-sensitivity of TUI commands.
 934         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 935         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 936         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 937
 938 2019-09-20  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-source.c (tui_source_window::set_contents): Use
 941         make_unique_xstrdup.
 942         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 943         make_unique_xstrdup.
 944
 945 2019-09-20  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-data.c: Remove separator comments.
 948         * tui/tui-layout.c: Remove separator comments.
 949         * tui/tui-win.c: Remove separator comments.
 950         * tui/tui-wingeneral.c: Remove separator comments.
 951
 952 2019-09-20  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui.h (strcat_to_buf): Don't declare.
 955         * tui/tui.c (strcat_to_buf): Remove.
 956
 957 2019-09-20  Tom Tromey  <tom@tromey.com>
 958
 959         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 960         from "fullname".
 961         * tui/tui-source.c (tui_source_window::set_contents)
 962         (tui_source_window::location_matches_p)
 963         (tui_source_window::maybe_update): Update.
 964
 965 2019-09-20  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 968         Update.
 969         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 970         prefix.
 971         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 972         (tui_data_window::line_from_reg_element_no)
 973         (tui_data_window::first_reg_element_no_inline)
 974         (tui_data_window::show_registers)
 975         (tui_data_window::show_register_group)
 976         (tui_data_window::display_registers_from)
 977         (tui_data_window::display_registers_from_line)
 978         (tui_data_window::first_data_item_displayed)
 979         (tui_data_window::delete_data_content_windows)
 980         (tui_data_window::erase_data_content)
 981         (tui_data_window::do_scroll_vertical)
 982         (tui_data_window::refresh_window)
 983         (tui_data_window::check_register_values): Update.
 984
 985 2019-09-20  Tom Tromey  <tom@tromey.com>
 986
 987         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 988         (struct tui_locator_window) <full_name, proc_name>: Now
 989         std::string.
 990         * tui/tui-stack.c (tui_locator_window::make_status_line)
 991         (tui_locator_window::set_locator_fullname)
 992         (tui_locator_window::set_locator_info): Update.
 993         * tui/tui-source.c (tui_source_window::set_contents)
 994         (tui_source_window::showing_source_p): Update.
 995
 996 2019-09-20  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 999         Don't call tui_locator_win_info_ptr.
1000
1001 2019-09-20  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1004
1005 2019-09-20  Tom Tromey  <tom@tromey.com>
1006
1007         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1008         height for locator.
1009         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1010         * tui/tui-layout.c (show_source_disasm_command, show_data)
1011         (show_source_or_disasm_and_command): Use 1 as height for locator.
1012
1013 2019-09-20  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui.c (tui_enable): Update.
1016         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1017         Update.
1018         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1019         Update.
1020         * tui/tui-data.c (win_resized): Now bool.
1021         (tui_win_resized): Return bool.
1022         (tui_set_win_resized_to): Accept a bool.
1023
1024 2019-09-20  Tom Tromey  <tom@tromey.com>
1025
1026         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1027         Change type of "refresh_values_only".
1028         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1029         type of "refresh_values_only".
1030
1031 2019-09-20  Tom Tromey  <tom@tromey.com>
1032
1033         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1034         std::string.
1035         (tui_disassemble): Add "pos" parameter.
1036         (tui_disasm_window::set_contents): Simplify.
1037
1038 2019-09-20  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-winsource.h (struct tui_source_window_base)
1041         <show_source_content>: Now private.
1042         * tui/tui-winsource.c
1043         (tui_source_window_base::show_source_content): Don't handle empty
1044         content case.
1045
1046 2019-09-20  Tom Tromey  <tom@tromey.com>
1047
1048         * tui/tui-layout.c (show_source_disasm_command)
1049         (show_source_or_disasm_and_command): Don't call
1050         show_source_content.
1051
1052 2019-09-20  Tom Tromey  <tom@tromey.com>
1053
1054         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1055         Declare.
1056         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1057         from tui_make_status_line.
1058         (tui_locator_window::rerender): Update.
1059
1060 2019-09-20  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1063         (tui_locator_window::rerender): Update.
1064
1065 2019-09-20  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-winsource.h (struct tui_source_window_base)
1068         <~tui_source_window_base>: Don't declare.
1069         <fullname>: Remove.
1070         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1071         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1072         member.
1073         * tui/tui-source.c (tui_source_window::set_contents): Update.
1074         (tui_source_window::location_matches_p)
1075         (tui_source_window::maybe_update): Update.
1076
1077 2019-09-20  Tom Tromey  <tom@tromey.com>
1078
1079         * tui/tui-winsource.h (~tui_source_element): Remove.
1080         (tui_source_element): Update.
1081         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1082         * tui/tui-winsource.c (tui_show_source_line): Update.
1083         * tui/tui-source.c (tui_source_window::set_contents): Update.
1084         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1085
1086 2019-09-20  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1089         declare.
1090         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1091         tui_clear_source_windows_detail.
1092         * tui/tui-winsource.h (struct tui_source_window_base)
1093         <clear_detail>: Don't declare.
1094         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1095         Remove.
1096         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1097
1098 2019-09-20  Tom Tromey  <tromey@adacore.com>
1099
1100         PR ada/24919:
1101         * block.c (contained_in): Fix final return value.
1102
1103 2019-09-20  Alan Modra  <amodra@gmail.com>
1104
1105         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1106         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1107         (read_indirect_string_from_dwz): Use bfd accessor.
1108         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1109         * machoread.c (macho_symfile_read_all_oso): Likewise.
1110         * solib.c (solib_bfd_open): Likewise.
1111
1112 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1113
1114         * eval.c: Move declaration of overload_resolution to...
1115         * value.h: ...here.
1116
1117 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1118
1119         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1120         * arm-linux-tdep.c: Likewise.
1121         * arm-nbsd-nat.c: Likewise.
1122         * arm-tdep.h: Declare arm_apcs_32.
1123         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1124
1125 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1126
1127         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1128         * dwarf2read.h: Declare dwarf_always_disassemble.
1129
1130 2019-09-19  Tom de Vries  <tdevries@suse.de>
1131
1132         PR gdb/25009
1133         * source-cache.c (source_cache::ensure): Catch exception thrown during
1134         construction of the highlighter.
1135
1136 2019-09-18  Alan Modra  <amodra@gmail.com>
1137
1138         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1139         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1140         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1141         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1142         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1143         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1144         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1145         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1146         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1147         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1148         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1149         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1150         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1151         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1152         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1153         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1154         * mi/mi-interp.c: Update throughout for bfd section macro and
1155         function changes.
1156         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1157         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1158
1159 2019-09-18  Tom Tromey  <tom@tromey.com>
1160
1161         * NEWS: Add entry.
1162         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1163         call rl_initialize.
1164         (tui_enable): Do not call rl_initialize.
1165
1166 2019-09-18  Christian Groessler  <chris@groessler.org>
1167
1168         * alpha-linux-nat.c: Include gdbarch.h.
1169
1170 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1171
1172         * ui-file.c: Include cli/cli-style.h.
1173         (term_cli_styling): Remove cli_styling declaration.
1174
1175 2019-09-18  Alan Modra  <amodra@gmail.com>
1176
1177         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1178         to bfd_asymbol_section.
1179
1180 2019-09-18  Alan Modra  <amodra@gmail.com>
1181
1182         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1183         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1184         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1185
1186 2019-09-18  Alan Modra  <amodra@gmail.com>
1187
1188         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1189         * spu-linux-nat.c (spu_bfd_open): Likewise.
1190
1191 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1192
1193         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1194         to bool to match definition in dwarf2read.c.
1195
1196 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1197
1198         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1199         (print_signatures): Likewise.
1200         (trust_pad_over_xvs): Likewise.
1201         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1202         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1203         * arm-linux-nat.c (arm_apcs_32): Likewise.
1204         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1205         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1206         * arm-tdep.c (arm_debug): Likewise.
1207         (arm_apcs_32): Likewise.
1208         * auto-load.c (debug_auto_load): Likewise.
1209         (auto_load_gdb_scripts): Likewise.
1210         (global_auto_load): Likewise.
1211         (auto_load_local_gdbinit): Likewise.
1212         (auto_load_local_gdbinit_loaded): Likewise.
1213         * auto-load.h (global_auto_load): Likewise.
1214         (auto_load_local_gdbinit): Likewise.
1215         (auto_load_local_gdbinit_loaded): Likewise.
1216         * breakpoint.c (disconnected_dprintf): Likewise.
1217         (breakpoint_proceeded): Likewise.
1218         (automatic_hardware_breakpoints): Likewise.
1219         (always_inserted_mode): Likewise.
1220         (target_exact_watchpoints): Likewise.
1221         (_initialize_breakpoint): Update.
1222         * breakpoint.h (target_exact_watchpoints): Change to bool.
1223         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1224         * cli/cli-cmds.c (trace_commands): Likewise.
1225         * cli/cli-cmds.h (trace_commands): Likewise.
1226         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1227         to bool*.
1228         * cli/cli-logging.c (logging_overwrite): Change to bool.
1229         (logging_redirect): Likewise.
1230         (debug_redirect): Likewise.
1231         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1232         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1233         to bool.
1234         <boolean_option_def>: Update.
1235         (struct flag_option_def): Change default type of Context to bool
1236         from int.
1237         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1238         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1239         (get_setshow_command_value_string): Likewise.
1240         * cli/cli-style.c (cli_styling): Change to bool.
1241         (source_styling): Likewise.
1242         * cli/cli-style.h (source_styling): Likewise.
1243         (cli_styling): Likewise.
1244         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1245         to bool.
1246         * command.h (var_types): Update comment.
1247         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1248         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1249         bool.
1250         (debug_compile_cplus_scopes): Likewise.
1251         * compile/compile-internal.h (compile_debug): Likewise.
1252         * compile/compile.c (compile_debug): Likewise.
1253         (struct compile_options) <raw>: Likewise.
1254         * cp-support.c (catch_demangler_crashes): Likewise.
1255         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1256         (usr_cmd_cris_dwarf2_cfi): Likewise.
1257         * csky-tdep.c (csky_debug): Likewise.
1258         * darwin-nat.c (enable_mach_exceptions): Likewise.
1259         * dcache.c (dcache_enabled_p): Likewise.
1260         * defs.h (info_verbose): Likewise.
1261         * demangle.c (demangle): Likewise.
1262         (asm_demangle): Likewise.
1263         * dwarf-index-cache.c (debug_index_cache): Likewise.
1264         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1265         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1266         * dwarf2read.c (check_physname): Likewise.
1267         (use_deprecated_index_sections): Likewise.
1268         (dwarf_always_disassemble): Likewise.
1269         * eval.c (overload_resolution): Likewise.
1270         * event-top.c (set_editing_cmd_var): Likewise.
1271         (exec_done_display_p): Likewise.
1272         * event-top.h (set_editing_cmd_var): Likewise.
1273         (exec_done_display_p): Likewise.
1274         * exec.c (write_files): Likewise.
1275         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1276         (debug_fbsd_nat): Likewise.
1277         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1278         Likewise.
1279         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1280         <backtrace_past_entry> Likewise.
1281         * gdb-demangle.h (demangle): Likewise.
1282         (asm_demangle): Likewise.
1283         * gdb_bfd.c (bfd_sharing): Likewise.
1284         * gdbcore.h (write_files): Likewise.
1285         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1286         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1287         * gdbthread.h (print_thread_events): Likewise.
1288         * gdbtypes.c (opaque_type_resolution): Likewise.
1289         (strict_type_checking): Likewise.
1290         * gnu-nat.c (gnu_debug_flag): Likewise.
1291         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1292         * guile/scm-param.c (pascm_variable): Add boolval.
1293         (add_setshow_generic): Update.
1294         (pascm_param_value): Update.
1295         (pascm_set_param_value_x): Update.
1296         * hppa-tdep.c (hppa_debug): Change to bool..
1297         * infcall.c (may_call_functions_p): Likewise.
1298         (coerce_float_to_double_p): Likewise.
1299         (unwind_on_signal_p): Likewise.
1300         (unwind_on_terminating_exception_p): Likewise.
1301         * infcmd.c (startup_with_shell): Likewise.
1302         * inferior.c (print_inferior_events): Likewise.
1303         * inferior.h (startup_with_shell): Likewise.
1304         (print_inferior_events): Likewise.
1305         * infrun.c (step_stop_if_no_debug): Likewise.
1306         (detach_fork): Likewise.
1307         (debug_displaced): Likewise.
1308         (disable_randomization): Likewise.
1309         (non_stop): Likewise.
1310         (non_stop_1): Likewise.
1311         (observer_mode): Likewise.
1312         (observer_mode_1): Likewise.
1313         (set_observer_mode): Update.
1314         (sched_multi): Change to bool.
1315         * infrun.h (debug_displaced): Likewise.
1316         (sched_multi): Likewise.
1317         (step_stop_if_no_debug): Likewise.
1318         (non_stop): Likewise.
1319         (disable_randomization): Likewise.
1320         * linux-tdep.c (use_coredump_filter): Likewise.
1321         (dump_excluded_mappings): Likewise.
1322         * linux-thread-db.c (auto_load_thread_db): Likewise.
1323         (check_thread_db_on_load): Likewise.
1324         * main.c (captured_main_1): Update.
1325         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1326         xx2_opt, boolean_opt>: Change to bool.
1327         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1328         * maint.c (maintenance_profile_p): Likewise.
1329         (per_command_time): Likewise.
1330         (per_command_space): Likewise.
1331         (per_command_symtab): Likewise.
1332         * memattr.c (inaccessible_by_default): Likewise.
1333         * mi/mi-main.c (mi_async): Likewise.
1334         (mi_async_1): Likewise.
1335         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1336         * nat/fork-inferior.h (startup_with_shell): Likewise.
1337         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1338         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1339         * nios2-tdep.c (nios2_debug): Likewise.
1340         * or1k-tdep.c (or1k_debug): Likewise.
1341         * parse.c (parser_debug): Likewise.
1342         * parser-defs.h (parser_debug): Likewise.
1343         * printcmd.c (print_symbol_filename): Likewise.
1344         * proc-api.c (procfs_trace): Likewise.
1345         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1346         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1347         (set_parameter_value): Update.
1348         (add_setshow_generic): Update.
1349         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1350         to bool*.
1351         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1352         int*.
1353         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1354         * record-btrace.c (record_btrace_target::store_registers): Update.
1355         * record-full.c (record_full_memory_query): Change to bool.
1356         (record_full_stop_at_limit): Likewise.
1357         * record-full.h (record_full_memory_query): Likewise.
1358         * remote-notif.c (notif_debug): Likewise.
1359         * remote-notif.h (notif_debug): Likewise.
1360         * remote.c (use_range_stepping): Likewise.
1361         (interrupt_on_connect): Likewise.
1362         (remote_break): Likewise.
1363         * ser-tcp.c (tcp_auto_retry): Likewise.
1364         * ser-unix.c (serial_hwflow): Likewise.
1365         * skip.c (debug_skip): Likewise.
1366         * solib-aix.c (solib_aix_debug): Likewise.
1367         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1368         (spu_auto_flush_cache_p): Likewise.
1369         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1370         Likewise.
1371         (struct info_print_options) <quiet>: Likewise.
1372         * symfile-debug.c (debug_symfile): Likewise.
1373         * symfile.c (auto_solib_add): Likewise.
1374         (separate_debug_file_debug): Likewise.
1375         * symfile.h (auto_solib_add): Likewise.
1376         (separate_debug_file_debug): Likewise.
1377         * symtab.c (basenames_may_differ): Likewise.
1378         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1379         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1380         (struct info_types_options) <quiet>: Likewise.
1381         * symtab.h (demangle): Likewise.
1382         (basenames_may_differ): Likewise.
1383         * target-dcache.c (stack_cache_enabled_1): Likewise.
1384         (code_cache_enabled_1): Likewise.
1385         * target.c (trust_readonly): Likewise.
1386         (may_write_registers): Likewise.
1387         (may_write_memory): Likewise.
1388         (may_insert_breakpoints): Likewise.
1389         (may_insert_tracepoints): Likewise.
1390         (may_insert_fast_tracepoints): Likewise.
1391         (may_stop): Likewise.
1392         (auto_connect_native_target): Likewise.
1393         (target_stop_and_wait): Update.
1394         (target_async_permitted): Change to bool.
1395         (target_async_permitted_1): Likewise.
1396         (may_write_registers_1): Likewise.
1397         (may_write_memory_1): Likewise.
1398         (may_insert_breakpoints_1): Likewise.
1399         (may_insert_tracepoints_1): Likewise.
1400         (may_insert_fast_tracepoints_1): Likewise.
1401         (may_stop_1): Likewise.
1402         * target.h (target_async_permitted): Likewise.
1403         (may_write_registers): Likewise.
1404         (may_write_memory): Likewise.
1405         (may_insert_breakpoints): Likewise.
1406         (may_insert_tracepoints): Likewise.
1407         (may_insert_fast_tracepoints): Likewise.
1408         (may_stop): Likewise.
1409         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1410         (make_thread_apply_all_options_def_group): Change argument from int*
1411         to bool*.
1412         (thread_apply_all_command): Update.
1413         (print_thread_events): Change to bool.
1414         * top.c (confirm): Likewise.
1415         (command_editing_p): Likewise.
1416         (history_expansion_p): Likewise.
1417         (write_history_p): Likewise.
1418         (info_verbose): Likewise.
1419         * top.h (confirm): Likewise.
1420         (history_expansion_p): Likewise.
1421         * tracepoint.c (disconnected_tracing): Likewise.
1422         (circular_trace_buffer): Likewise.
1423         * typeprint.c (print_methods): Likewise.
1424         (print_typedefs): Likewise.
1425         * utils.c (debug_timestamp): Likewise.
1426         (sevenbit_strings): Likewise.
1427         (pagination_enabled): Likewise.
1428         * utils.h (sevenbit_strings): Likewise.
1429         (pagination_enabled): Likewise.
1430         * valops.c (overload_resolution): Likewise.
1431         * valprint.h (struct value_print_options) <prettyformat_arrays,
1432         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1433         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1434         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1435         Likewise.
1436         * windows-nat.c (new_console): Likewise.
1437         (cygwin_exceptions): Likewise.
1438         (new_group): Likewise.
1439         (debug_exec): Likewise.
1440         (debug_events): Likewise.
1441         (debug_memory): Likewise.
1442         (debug_exceptions): Likewise.
1443         (useshell): Likewise.
1444         * windows-tdep.c (maint_display_all_tib): Likewise.
1445         * xml-support.c (debug_xml): Likewise.
1446
1447 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1448
1449         * source.c (prepare_path_for_appending): New function.
1450         (openp): Make use of new function.
1451         (find_and_open_source): Search for the compilation directory and
1452         source file as a relative path beneath the directory search path.
1453
1454 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1455
1456         * source-cache.c (source_cache::get_line_charpos): Catch
1457         exceptions and return false, this matches the behaviour documented
1458         in the header file.
1459
1460 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1461
1462         * ada-tasks.c (info_task): Remove quoting of the task's name.
1463
1464 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1465
1466         * symfile.c (auto_solib_add): Replace comment with a reference
1467         to the header file.
1468
1469 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1470
1471         * NEWS: Mention that gdb can now be compiled with Python 3
1472         on Windows.
1473
1474 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1475
1476         * maint.c (maint_print_section_data::maint_print_section_data):
1477         Force use of 'float log10 (float)' by casting the argument to
1478         float.
1479
1480 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1481
1482         * maint.c: Add 'cmath' include.
1483         (struct maint_print_section_data): New structure.
1484         (print_section_index): New function.
1485         (print_bfd_section_info): Add header comment, small whitespace
1486         cleanup, and update to call new print_section_index function.
1487         (print_objfile_section_info): Likewise.
1488         (maint_obj_section_from_bfd_section): New function.
1489         (print_bfd_section_info_maybe_relocated): New function.
1490         (maintenance_info_sections): Add header comment, always use
1491         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1492
1493 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1494
1495         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1496         inner scope, add check that the objfile has psymtabs before
1497         checking psymtabs_addrmap.
1498         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1499
1500 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1501
1502         * NEWS: Announce that Ada task names are now shown at more places,
1503         and between quotes (except in info task output).
1504         * gdb/ada-tasks.c (task_to_str): New function.
1505         (display_current_task_id): Call task_to_str.
1506         (task_command_1): Likewise.
1507         (print_ada_task_info): In non-mi mode, Properly align headers and data
1508         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1509
1510 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1511
1512         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1513         prstatus.pr_lwp.pr_info instead of making it up.
1514
1515 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1516
1517         * auto-load.c (auto_load_expand_dir_vars): Update.
1518         * defs.h (gdb_datadir): Change to std::string.
1519         (python_libdir): Likewise.
1520         (relocate_gdb_directory): Change return type to std::string.
1521         * guile/guile.c (gdbscm_data_directory): Update.
1522         (initialize_scheme_side): Update.
1523         * jit.c (jit_reader_dir): Change to std::string.
1524         (jit_reader_load_command): Update.
1525         * main.c (gdb_datadir): Change to std::string.
1526         (python_libdir): Likewise.
1527         (set_gdb_data_directory): Update.
1528         (relocate_path): Change to return std::string.
1529         (relocate_gdb_directory): Change to return std::string.
1530         (relocate_gdbinit_path_maybe_in_datadir): Update.
1531         (captured_main_1): Update.
1532         * python/python.c (do_start_initialization): Update.
1533         * top.c (show_gdb_datadir): Update.
1534         * xml-syscall.c (xml_init_syscalls_info): Update.
1535         (init_syscalls_info): Update.
1536
1537 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1538
1539         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1540         out of get_init_files.
1541         (get_init_files): Update.
1542
1543 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1544
1545         * main.c (get_init_files): Change to use std::string.
1546         (captured_main_1): Update.
1547         (print_gdb_help): Update.
1548
1549 2019-09-11  Ali Tamur  <tamur@google.com>
1550
1551         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1552         implementation.
1553
1554 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1555
1556         * dbxread.c (read_dbx_symtab): Update.
1557         * dwarf2read.c (load_partial_dies): Update.
1558         * mdebugread.c (parse_partial_symbols): Update.
1559         (handle_psymbol_enumerators): Update.
1560         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1561         * psymtab.c (add_psymbol_to_bcache): Likewise.
1562         (add_psymbol_to_list): Likewise.
1563         * symtab.c (symbol_set_names): Likewise.
1564         * symtab.h (symbol_set_names): Likewise.
1565         * xcoffread.c (scan_xcoff_symtab): Update.
1566
1567 2019-09-11  Tom Tromey  <tom@tromey.com>
1568
1569         * symfile-mem.c (symbol_file_add_from_memory): Use
1570         bfd_set_filename.
1571         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1572         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1573
1574 2019-09-10  Tom Tromey  <tromey@adacore.com>
1575
1576         * dwarf-index-write.c (write_psymbols): Extend error message.
1577         (debug_names::insert): Add Ada code.
1578         (debug_names::write_psymbols): Remove Ada check.
1579         (debug_names) <m_string_obstack>: New member.
1580         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1581         (gdb_index_symbol_name_matcher::matches): Remove.
1582         (mapped_index_base::find_name_components_bounds): Add "lang"
1583         parameter.
1584         (mapped_index_base::build_name_components): Also split names
1585         according to Ada syntax.
1586         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1587         type of "match_callback".
1588         (check_match, check_find_bounds_finds)
1589         (dw2_expand_symtabs_matching): Update.
1590         (dw2_debug_names_iterator): Add new constructor.
1591         (dw2_debug_names_map_matching_symbols): New function.
1592         (dw2_debug_names_expand_symtabs_matching): Update.
1593         (dwarf2_debug_names_functions): Use
1594         dw2_debug_names_map_matching_symbols.
1595
1596 2019-09-10  Tom Tromey  <tromey@adacore.com>
1597
1598         * dwarf2read.c (dw2_get_file_names_reader): Add the
1599         CU's file name to the results.
1600
1601 2019-09-10  Tom Tromey  <tromey@adacore.com>
1602
1603         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1604         map_matching_symbols.  Update.
1605         * dwarf2read.c (dw2_map_matching_symbols): Update.
1606         * psymtab.c (match_partial_symbol): Change type; update.
1607         (psym_map_matching_symbols): Likewise.
1608         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1609         type; update.
1610         * symfile.h (struct quick_symbol_functions)
1611         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1612         Remove "match".
1613
1614 2019-09-10  Tom Tromey  <tromey@adacore.com>
1615
1616         * psymtab.c (map_block): Remove.
1617         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1618         * symtab.c (iterate_over_symbols_terminated): New function.
1619         * symtab.c (iterate_over_symbols_terminated): Declare.
1620
1621 2019-09-10  Tom Tromey  <tromey@adacore.com>
1622
1623         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1624         * language.h (struct language_defn) <la_iterate_over_symbols>:
1625         Return bool.
1626         * symtab.c (iterate_over_symbols): Return bool.
1627         * symtab.h (iterate_over_symbols): Return bool.
1628
1629 2019-09-10  Tom Tromey  <tromey@adacore.com>
1630
1631         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1632         (add_nonlocal_symbols): Update.
1633         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1634         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1635         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1636         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1637         Change type of "callback".  Remove "data".
1638
1639
1640 2019-09-09  Ali Tamur  <tamur@google.com>
1641
1642         * dwarf2read.c (comp_unit_head): Update comment.
1643         (dwarf2_dwo_name): New function declaration.
1644         (dwarf_unit_type_name): New function declaration.
1645         (read_comp_unit_head): Add support for new compilation units,
1646         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1647         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1648         (currently named as "signature") in their header. Also clarify error
1649         messages.
1650         (lookup_dwo_id): New function. Returns the dwo id of the given
1651         compile unit.
1652         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1653         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1654         functions.
1655         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1656         (dwarf2_dwo_name): Get the dwo name if present.
1657         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1658         purposes.
1659
1660 2019-09-09  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1663
1664 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1665
1666         * python/python.c (do_start_initialization): Make progname_copy static,
1667         to avoid a leak report.
1668
1669 2019-09-08  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1672
1673 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1674
1675         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1676         Change type to gdb::optional<block_enum>.
1677         (dw2_symtab_iter_init): Change block_index parameter type
1678         to gdb::optional<block_enum>.
1679         (dw2_lookup_symbol): Change block_index parameter
1680         type to block_enum.c
1681         (dw2_debug_names_lookup_symbol): Likewise.
1682         * psymtab.c (psym_lookup_symbol): Likewise.
1683         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1684         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1685         Likewise.
1686
1687 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1688
1689         * defs.h (relocate_gdb_directory): Change int to bool in
1690         signature and rename flag to relocatable.
1691         * main.c (relocate_path): Likewise.
1692         (relocate_gdb_directory): Likewise.
1693
1694 2019-09-06  Alan Modra  <amodra@gmail.com>
1695
1696         * coffread.c (coff_symfile_read): Constify filename variable.
1697         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1698         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1699         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1700         * solib.c (reload_shared_libraries_1): Likewise.
1701         * symfile.c (reread_symbols): Likewise.
1702         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1703         * solib-darwin.c (darwin_bfd_open): Likewise.
1704         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1705
1706 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1707
1708         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1709         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1710
1711 2019-09-03  Tom Tromey  <tromey@adacore.com>
1712
1713         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1714         types.
1715         (has_negatives): Unbias a range type bound.
1716         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1717         * gdbtypes.c (operator==): Handle new field.
1718         (create_range_type): Add "bias" parameter.
1719         (create_static_range_type, resolve_dynamic_range): Update.
1720         * gdbtypes.h (struct range_bounds) <bias>: New member.
1721         (create_range_type): Add bias parameter.
1722         * printcmd.c (print_scalar_formatted): Unbias range types.
1723         * value.c (unpack_long): Unbias range types.
1724         (pack_long): Bias range types.
1725
1726 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1727
1728         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1729         probe arguments.
1730
1731 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1732
1733         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1734         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1735         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1736         (compile_probe_arg): Likewise.
1737         * probe.h (get_argument_count): Likewise.
1738         * solib-svr4.c (solib_event_probe_action): Likewise.
1739         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1740
1741 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1742
1743         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1744         code to here...
1745         (svr4_create_solib_event_breakpoints): ...from here.
1746
1747 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1748
1749         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1750         suffix from warning message.
1751
1752 2019-08-30  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-winsource.h (struct tui_source_window_base)
1755         <refresh_all>: Don't declare.
1756         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1757         Remove.
1758         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1759         tui_show_locator_content.
1760         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1761         declare.
1762         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1763         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1764         declare.
1765
1766 2019-08-30  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1769
1770 2019-08-30  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1773         Remove unnecessary forward declarations.
1774
1775 2019-08-30  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1778         rerender.
1779         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1780         tui_show_locator_content.
1781
1782 2019-08-30  Tom Tromey  <tom@tromey.com>
1783
1784         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1785         (tui_locator_window::rerender): Rewrite using body of previous
1786         tui_show_locator_content.
1787
1788 2019-08-30  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1791         set_locator_fullname>: New methods.
1792         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1793         Rename from tui_set_locator_fullname.
1794         (tui_locator_window::set_locator_info): Rename from
1795         tui_set_locator_info.  Return bool.
1796         (tui_update_locator_fullname, tui_show_frame_info): Update.
1797
1798 2019-08-30  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1801
1802 2019-08-30  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1805         call touchwin.
1806
1807 2019-08-30  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-wingeneral.c (box_win): Assume win_info and
1810         win_info->handle cannot be NULL.
1811
1812 2019-08-30  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1815         refresh_window>: Declare.
1816         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1817         resize.
1818         (tui_data_item_window::rerender): Rename from
1819         tui_display_register.
1820         (tui_data_item_window::refresh_window): New method.
1821         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1822         no-op.
1823
1824 2019-08-30  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1827         regs_column_count, current_group>: Move later.  Now private.
1828         <get_current_group>: New method.
1829         * tui/tui-regs.c (tui_reg_command): Update.
1830         * tui/tui-layout.c (tui_set_layout): Update.
1831
1832 2019-08-30  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1835         (tui_data_window::rerender): Don't call
1836         check_and_display_highlight_if_needed.
1837         (tui_data_window::refresh_all): Remove call to
1838         erase_data_content.
1839
1840 2019-08-30  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1843         (tui_data_window::display_registers_from)
1844         (tui_data_window::display_reg_element_at_line)
1845         (tui_data_window::display_registers_from_line): Remove checks of
1846         "empty".
1847
1848 2019-08-30  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1851         Don't declare.
1852         * tui/tui-regs.c (tui_data_window::show_registers): Call
1853         rerender.
1854         (tui_data_window::rerender): Rename from display_all_data.
1855         (tui_data_window::rerender): Remove old implementation.
1856
1857 2019-08-30  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1860         text.
1861         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1862
1863 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1864             Sergio Durigan Junior  <sergiodj@redhat.com>
1865
1866         PR win32/24284
1867         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1868
1869 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1870
1871         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1872         when searching for types.
1873
1874 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1875
1876         * f-lang.c (f_language_defn): Use f_print_typedef.
1877         * f-lang.h (f_print_typedef): Declare.
1878         * f-typeprint.c (f_print_typedef): Define.
1879
1880 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1881
1882         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1883
1884 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1885
1886         * cli/cli-utils.c (info_print_options_defs): Delete.
1887         (make_info_print_options_def_group): Delete.
1888         (extract_info_print_options): Delete.
1889         (info_print_command_completer): Delete.
1890         (info_print_args_help): Add extra parameter, and optionally
1891         include text about -n flag.
1892         * cli/cli-utils.h (struct info_print_options): Delete.
1893         (extract_info_print_options): Delete declaration.
1894         (info_print_command_completer): Delete declaration.
1895         (info_print_args_help): Add extra parameter, extend header
1896         comment.
1897         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1898         search_symbols.
1899         * stack.c (struct info_print_options): New type.
1900         (info_print_options_defs): New file scoped variable.
1901         (make_info_print_options_def_group): New static function.
1902         (info_print_command_completer): New static function.
1903         (info_locals_command): Update to use new local functions.
1904         (info_args_command): Likewise.
1905         (_initialize_stack): Add extra parameter to calls to
1906         info_print_args_help.
1907         * symtab.c (search_symbols): Add extra parameter, use this to
1908         possibly excluse non-debug symbols.
1909         (symtab_symbol_info): Add extra parameter, which is passed on to
1910         search_symbols.
1911         (struct info_print_options): New type.
1912         (info_print_options_defs): New file scoped variable.
1913         (make_info_print_options_def_group): New static function.
1914         (info_print_command_completer): New static function.
1915         (info_variables_command): Update to use local functions, and pass
1916         extra parameter through to symtab_symbol_info.
1917         (info_functions_command): Likewise.
1918         (info_types_command): Pass additional argument through to
1919         symtab_symbol_info.
1920         (rbreak_command): Pass extra argument to search_symbols.
1921         (_initialize_symtab): Add extra arguments for calls to
1922         info_print_args_help, and update help text for 'info variables',
1923         'whereis', and 'info functions' commands.
1924         * symtab.h (search_symbols): Add extra argument to declaration.
1925         * NEWS: Mention new flags.
1926
1927 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1928
1929         * symtab.c (lookup_static_symbol): Call the new function (and move
1930         it down to be next to lookup_global_symbol).
1931         (struct global_sym_lookup_data): Add block_enum member and rename to...
1932         (struct global_or_static_sym_lookup_data): ...this.
1933         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1934         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1935         (lookup_symbol_global_or_static_iterator_cb): ...this.
1936         (lookup_global_or_static_symbol): New function.
1937         (lookup_global_symbol): Call new function.
1938
1939 2019-08-26  Tom de Vries  <tdevries@suse.de>
1940
1941         PR c++/24852
1942         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1943         when pc_probe.prob == NULL.
1944
1945 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1946
1947         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1948         variable symbol_linkage to symbol_linkage_.
1949
1950 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1951
1952         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1953         represent whether the symbol is static, dynamic, or we don't
1954         know.
1955
1956 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1957
1958         * gdb/rx-tdep.c (rx_register_names): New.
1959         (rx_register_name): Delete.
1960         (rx_psw_type): Delete.
1961         (rx_fpsw_type): Delete.
1962         (rx_register_type): Delete.
1963         (rx_gdbarch_init): Convert target-descriptions.
1964         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1965         * gdb/features/Makefile: Add rx.xml.
1966         * gdb/features/rx.xml: New.
1967         * gdb/features/rx.c: Generated.
1968         * gdb/NEWS: Mention target description support.
1969
1970 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1971
1972         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1973         *slot_ptr.
1974
1975 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1976
1977         * configure.ac: Don't check for 'dlfcn.h' (moved to
1978         gdbsupport/common.m4).
1979         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1980         'gdbsupport/'.
1981         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1982         * compile/compile-c-support.c: Include
1983         'gdbsupport/gdb-dlfcn.h'.
1984         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1985         * gdb-dlfcn.c: Move to...
1986         * gdbsupport/gdb-dlfcn.c: ... here.
1987         * gdb-dlfcn.h: Move to...
1988         * gdbsupport/gdb-dlfcn.h: ... here.
1989
1990 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1991
1992         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1993         the offset field signed.
1994
1995 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1996
1997         * python/lib/gdb/__init__.py (_execute_file): New function.
1998         * python/python.c (python_run_simple_file): Call gdb._execute_file
1999         on Windows.
2000
2001 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2002
2003         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2004         all uses as this was never set to anything but a zero value.
2005
2006 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2007
2008         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2009
2010 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2011
2012         * tui/tui-data.h (tui_gen_win_info): Add an =default
2013         move constructor, required by some GCC versions.
2014
2015 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2016
2017         * go32-nat.c (go32_sysinfo): Add hygon_p.
2018
2019 2019-08-20  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2022         line_from_reg_element_no, first_reg_element_no_inline,
2023         display_all_data, delete_data_content_windows,
2024         erase_data_content>: Now private.
2025
2026 2019-08-20  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2029         (tui_unhighlight_win, tui_highlight_win)
2030         (tui_win_info::make_window): Update.
2031         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2032
2033 2019-08-20  Tom Tromey  <tom@tromey.com>
2034
2035         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2036         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2037         (MAX_PID_WIDTH): Move to tui-stack.c.
2038         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2039         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2040         (MAX_PID_WIDTH): Move from tui-data.h.
2041
2042 2019-08-20  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2045         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2046         (box_win): Update.
2047         (tui_gen_win_info::make_window): Rename from tui_make_window.
2048         (tui_win_info::make_window): New method.
2049         (tui_gen_win_info::make_visible): Update.
2050         * tui/tui-source.c (tui_source_window::set_contents): Update.
2051         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2052         (tui_data_window::display_registers_from): Update.
2053         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2054         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2055         Declare.
2056         <can_box>: Remove.
2057         <title>: Remove.
2058         (struct tui_win_info) <make_window>: Declare.
2059         <can_box>: Now virtual.
2060         <title>: New member.
2061         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2062         * tui/tui-command.c (tui_cmd_window::resize): Update.
2063
2064 2019-08-20  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2067         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2068         (tui_data_window::check_register_values): Update.
2069
2070 2019-08-20  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-regs.h (struct tui_data_window): Use
2073         DISABLE_COPY_AND_ASSIGN.
2074         <regs_content>: Change type, removing unique_ptr.
2075         <tui_data_window>: Add move constructor.
2076         * tui/tui-regs.c (tui_data_window::show_registers)
2077         (tui_data_window::show_register_group)
2078         (tui_data_window::display_registers_from)
2079         (tui_data_window::display_registers_from)
2080         (tui_data_window::first_data_item_displayed)
2081         (tui_data_window::delete_data_content_windows)
2082         (tui_data_window::rerender, tui_data_window::refresh_window)
2083         (tui_data_window::check_register_values): Update.
2084
2085 2019-08-20  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2088         show_register_group>: Declare.
2089         (tui_show_register_group): Don't declare.
2090         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2091         tui_show_registers.
2092         (tui_data_window::show_register_group): Rename from
2093         tui_show_register_group.
2094         (tui_data_window::check_register_values, tui_reg_command):
2095         Update.
2096         * tui/tui-layout.c (tui_set_layout): Update.
2097
2098 2019-08-20  Tom Tromey  <tom@tromey.com>
2099
2100         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2101         Declare.
2102         (tui_check_register_values): Don't declare.
2103         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2104         from tui_check_register_values.
2105         * tui/tui-hooks.c (tui_register_changed): Update.
2106
2107 2019-08-20  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui-regs.c (tui_reg_layout): Move later.
2110         (tui_show_registers): Don't enable TUI mode or change layout.
2111
2112 2019-08-20  Tom Tromey  <tom@tromey.com>
2113
2114         * tui/tui-regs.h (struct tui_data_item_window)
2115         <~tui_data_item_window>: Remove.
2116         <content>: Now a unique_xmalloc_ptr.
2117         * tui/tui-regs.c (tui_register_format): Return a
2118         unique_xmalloc_ptr.
2119         (tui_get_register): Update.
2120         (~tui_data_item_window): Remove.
2121         (tui_data_window::display_registers_from, tui_display_register):
2122         Update.
2123         * tui/tui-io.h (tui_expand_tabs): Update.
2124         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2125         Remove "col" parameter.
2126
2127 2019-08-20  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2130         field.
2131         * tui/tui-regs.c (~tui_data_item_window): Update.
2132
2133 2019-08-20  Tom Tromey  <tom@tromey.com>
2134
2135         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2136         earlier.
2137
2138 2019-08-20  Tom Tromey  <tom@tromey.com>
2139
2140         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2141
2142 2019-08-20  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-source.h (struct tui_source_window): Update.
2145         * tui/tui-regs.c (tui_show_registers): Update.
2146         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2147         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2148         (NO_REGS_STRING): Remove defines.
2149
2150 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2151
2152         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2153         unnecessary thread walk if remote doesn't support the packet.
2154
2155 2019-08-19  Tom Tromey  <tromey@adacore.com>
2156
2157         * python/py-value.c (value_has_field): Fix indentation.
2158
2159 2019-08-19  Tom Tromey  <tromey@adacore.com>
2160
2161         * printcmd.c (do_one_display, info_display_command): Update.
2162         * block.h (contained_in): Return bool.  Add allow_nested
2163         parameter.
2164         * block.c (contained_in): Return bool.  Add allow_nested
2165         parameter.
2166
2167 2019-08-19  Tom Tromey  <tom@tromey.com>
2168
2169         * configure: Rebuild.
2170         * configure.ac: Disallow the combination of -static-libstdc++ and
2171         source highlight.
2172         * source-cache.c (get_language_name): Handle rust.
2173         (source_cache::get_source_lines): Ignore highlighting exceptions.
2174
2175 2019-08-16  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2178         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2179         (struct tui_source_window_base) <make_visible, refresh_window,
2180         resize>: Remove methods.
2181         <execution_info>: Remove field.
2182         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2183         (tui_show_source_line, tui_source_window_base)
2184         (~tui_source_window_base): Update.
2185         (tui_source_window_base::resize)
2186         (tui_source_window_base::make_visible)
2187         (tui_source_window_base::refresh_window): Remove.
2188         (tui_source_window_base::update_exec_info): Update.
2189         * tui/tui-source.c (tui_source_window::set_contents): Update.
2190         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2191
2192 2019-08-16  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2195         deprecated_query_hook.
2196
2197 2019-08-16  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2200         (tui_update_source_windows_with_line): Update.
2201         * tui/tui-source.h (struct tui_source_window)
2202         <show_symtab_source>: Declare.
2203         (tui_show_symtab_source): Don't declare.
2204         * tui/tui-source.c (tui_show_symtab_source): Rename from
2205         tui_show_symtab_source.
2206
2207 2019-08-16  Tom Tromey  <tom@tromey.com>
2208
2209         * tui/tui-winsource.h (struct tui_source_window_base)
2210         <set_contents>: Declare.
2211         * tui/tui-winsource.c
2212         (tui_source_window_base::update_source_window_as_is): Update.
2213         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2214         Declare.
2215         (tui_set_source_content): Don't declare.
2216         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2217         tui_set_source_content.
2218         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2219         Declare.
2220         (tui_set_disassem_content): Don't declare.
2221         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2222         tui_set_disassem_content.
2223
2224 2019-08-16  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-winsource.h (struct tui_source_window_base)
2227         <update_breakpoint_info>: Declare.
2228         (tui_update_breakpoint_info): Don't declare.
2229         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2230         (tui_update_all_breakpoint_info): Update.
2231         (tui_source_window_base::update_breakpoint_info): Rename from
2232         tui_update_breakpoint_info.
2233         (tui_source_window_base::update_exec_info): Update.
2234
2235 2019-08-16  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-winsource.h (struct tui_source_window_base)
2238         <update_source_window>: Declare.
2239         (tui_update_source_window): Don't declare.
2240         * tui/tui-winsource.c
2241         (tui_source_window_base::update_source_window): Rename from
2242         tui_update_source_window.
2243         (tui_source_window_base::rerender): Update.
2244         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2245         * tui/tui-disasm.c (tui_show_disassem)
2246         (tui_show_disassem_and_update_source)
2247         (tui_disasm_window::maybe_update): Update.
2248
2249 2019-08-16  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-winsource.h (struct tui_source_window_base)
2252         <update_source_window_as_is>: Declare.
2253         (tui_update_source_window_as_is): Don't declare.
2254         * tui/tui-winsource.c (tui_update_source_window): Update
2255         (tui_source_window_base::update_source_window_as_is): Rename from
2256         tui_update_source_window_as_is.
2257         (tui_source_window_base::refill): Update.
2258         * tui/tui-source.c (tui_show_symtab_source): Update.
2259         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2260         Update.
2261
2262 2019-08-16  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-winsource.h (tui_update_source_window)
2265         (tui_update_source_window_as_is): Remove "noerror" parameter.
2266         * tui/tui-winsource.c (tui_update_source_window)
2267         (tui_update_source_window_as_is): Remove "noerror" parameter.
2268         (tui_update_source_windows_with_addr)
2269         (tui_update_source_windows_with_line)
2270         (tui_source_window_base::rerender)
2271         (tui_source_window_base::refill): Update.
2272         * tui/tui-source.h (tui_set_source_content)
2273         (tui_show_symtab_source): Remove "noerror" parameter.
2274         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2275         parameter.
2276         (tui_show_symtab_source): Likewise.
2277         (tui_source_window::maybe_update): Update.
2278         * tui/tui-disasm.c (tui_show_disassem)
2279         (tui_show_disassem_and_update_source)
2280         (tui_disasm_window::do_scroll_vertical)
2281         (tui_disasm_window::maybe_update): Update.
2282
2283 2019-08-16  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui.c (tui_is_window_visible): Update.
2286         * tui/tui-wingeneral.c (tui_make_window)
2287         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2288         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2289         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2290         (tui_set_win_height_command, parse_scrolling_args): Update.
2291         * tui/tui-source.c (tui_source_window::style_changed): Update.
2292         * tui/tui-regs.c (tui_show_registers)
2293         (tui_data_window::first_data_item_displayed)
2294         (tui_data_window::delete_data_content_windows)
2295         (tui_check_register_values, tui_reg_command): Update.
2296         * tui/tui-disasm.c (tui_show_disassem): Update.
2297         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2298         method.
2299         <is_visible>: Remove field.
2300         * tui/tui-data.c (tui_next_win, tui_prev_win)
2301         (tui_delete_invisible_windows): Update.
2302
2303 2019-08-16  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-winsource.h (struct tui_source_window_base)
2306         <m_has_locator>: Remove.
2307         * tui/tui-layout.c (show_source_disasm_command, show_data)
2308         (show_source_or_disasm_and_command): Update.
2309
2310 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2311
2312         * NEWS (Other MI changes): New subsection.
2313         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2314         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2315         * arch-utils.c (default_get_pc_address_flags): New function.
2316         * arch-utils.h (default_get_pc_address_flags): New declaration.
2317         * gdbarch.sh: Add get_pc_address_flags.
2318         * gdbarch.c: Regenerate.
2319         * gdbarch.h: Likewise.
2320         * stack.c (print_pc): New function.
2321         (print_frame_info) (print_frame): Call print_pc.
2322
2323 2019-08-16  Tom de Vries  <tdevries@suse.de>
2324
2325         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2326         print_objfile_section_info.
2327
2328 2019-08-15  Tom Tromey  <tom@tromey.com>
2329
2330         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2331         calling update_cmdwin_start_line.
2332         * tui/tui-winsource.h (struct tui_source_window_base)
2333         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2334         <rerender>: Declare.
2335         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2336         Call rerender.
2337         (tui_source_window_base::set_new_height): Remove.
2338         (tui_source_window_base::rerender): Rename from
2339         do_make_visible_with_new_height.
2340         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2341         resize method.
2342         (tui_win_info::make_invisible_and_set_new_height)
2343         (tui_win_info::make_visible_with_new_height): Remove.
2344         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2345         Declare.
2346         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2347         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2348         do_make_visible_with_new_height>: Don't declare.
2349         <rerender>: Declare.
2350         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2351         set_new_height.
2352         (tui_data_window::do_make_visible_with_new_height): Remove.
2353         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2354         call tui_show_locator_content.
2355         (tui_gen_win_info::resize): Call rerender.
2356         (show_source_or_disasm_and_command): Don't call
2357         tui_show_locator_content.
2358         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2359         method.
2360         (struct tui_win_info) <rerender>: Declare.
2361         <set_new_height, make_invisible_and_set_new_height,
2362         make_visible_with_new_height>: Don't declare.
2363         * tui/tui-data.c (tui_win_list::rerender): New method.
2364         * tui/tui-command.h (struct tui_cmd_window)
2365         <do_make_visible_with_new_height>: Don't declare.
2366         * tui/tui-command.c
2367         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2368
2369 2019-08-15  Tom Tromey  <tromey@adacore.com>
2370
2371         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2372         * ada-lang.c (ada_enum_name): Likewise.
2373
2374 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2375
2376         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2377         leading underscore.
2378         (GdbOutputErrorFile): Likewise.
2379         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2380         accordingly.
2381         (execute_unwinders): Rename to have a leading underscore.
2382         (auto_load_packages): Likewise.
2383         (global scope): Adjust call to auto_load_packages accordingly.
2384         (GdbSetPythonDirectory): Likewise.
2385         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2386         instead of execute_unwinders.
2387
2388 2019-08-15  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2391         (show_data): Don't change window visibility.
2392         (tui_gen_win_info::resize): Remove special case for command
2393         window.  Use wresize, when available.
2394         (show_source_or_disasm_and_command): Don't change window
2395         visibility.
2396         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2397         <make_visible>: New method.
2398         * tui/tui-command.c (tui_cmd_window::resize): New method.
2399
2400 2019-08-15  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2403         (struct tui_source_windows): New.
2404         * tui/tui-winsource.c (tui_display_main): Update.
2405         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2406         (new_height_ok, parse_scrolling_args): Update.
2407         * tui/tui-layout.c (show_layout, show_data): Update.
2408         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2409         (tui_add_to_source_windows): Don't declare.
2410         * tui/tui-data.c (source_windows, tui_source_windows)
2411         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2412
2413 2019-08-15  Tom Tromey  <tom@tromey.com>
2414
2415         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2416         Rename from reset.
2417         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2418         * tui/tui-layout.c (show_source_disasm_command, show_data):
2419         Update.
2420         (tui_gen_win_info::resize): Rename.
2421         (show_source_or_disasm_and_command): Update.
2422         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2423         reset.
2424
2425 2019-08-15  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2428         * tui/tui-interp.c (tui_interp::init): Don't call
2429         tui_initialize_static_data.
2430         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2431
2432 2019-08-15  Tom Tromey  <tom@tromey.com>
2433
2434         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2435         examine tui_win_list.
2436
2437 2019-08-15  Tom Tromey  <tom@tromey.com>
2438
2439         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2440         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2441         tui_clear_source_content.
2442         (tui_clear_source_content): Remove.
2443         (tui_source_window_base::do_erase_source_content): Hoist call to
2444         content.clear().
2445         * tui/tui-stack.c (tui_show_frame_info): Don't call
2446         tui_clear_source_content.
2447
2448 2019-08-15  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui-winsource.h (struct tui_source_window_base)
2451         <do_erase_source_content>: New method.
2452         <erase_source_content>: New method.
2453         (tui_erase_source_content): Don't declare.
2454         * tui/tui-winsource.c (tui_clear_source_content): Update.
2455         (tui_source_window_base::do_erase_source_content): Rename from
2456         tui_erase_source_content.
2457         (tui_source_window_base::show_source_content): Update.
2458         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2459         * tui/tui-source.h (struct tui_source_window)
2460         <erase_source_content>: New method.
2461         * tui/tui-disasm.h (struct tui_disasm_window)
2462         <erase_source_content>: New method.
2463
2464 2019-08-15  Tom Tromey  <tom@tromey.com>
2465
2466         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2467         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2468         constructor.
2469         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2470         * tui/tui-source.c (tui_set_source_content): Update.
2471         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2472
2473 2019-08-15  Tom Tromey  <tom@tromey.com>
2474
2475         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2476         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2477         tui-source.c.
2478         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2479         Declare.
2480         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2481         method.
2482         (tui_source_window::maybe_update): Update.
2483
2484 2019-08-15  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2487         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2488         tui-disasm.c.
2489         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2490         Declare.
2491         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2492         method.
2493         (tui_disasm_window::maybe_update): Update.
2494
2495 2019-08-15  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-winsource.h (struct tui_source_window_base)
2498         <maybe_update>: Declare.
2499         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2500         method.
2501         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2502         Declare.
2503         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2504         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2505         Declare.
2506         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2507
2508 2019-08-15  Tom Tromey  <tom@tromey.com>
2509
2510         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2511
2512 2019-08-15  Tom Tromey  <tom@tromey.com>
2513
2514         * tui/tui-wingeneral.c: Include tui-stack.h.
2515         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2516         (struct tui_locator_window): Move from tui-data.h.
2517         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2518         (tui_initialize_static_data): Move from tui-data.c.
2519         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2520         (struct tui_locator_window): Move to tui-stack.c.
2521         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2522         (tui_initialize_static_data): Move to tui-stack.c.
2523
2524 2019-08-15  Tom Tromey  <tom@tromey.com>
2525
2526         * tui/tui-layout.c (show_source_disasm_command)
2527         (show_source_or_disasm_and_command): Use make_visible method, not
2528         tui_make_window.
2529         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2530         Remove.
2531
2532 2019-08-15  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-wingeneral.h (tui_make_window): Update.
2535         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2536         parameter.
2537         (tui_gen_win_info::make_visible): Update.
2538         * tui/tui-regs.c (tui_data_window::display_registers_from):
2539         Update.
2540         * tui/tui-layout.c (show_source_disasm_command)
2541         (show_source_or_disasm_and_command): Update.
2542         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2543         (enum tui_box): Remove.
2544         (struct tui_win_info) <can_box>: New method.
2545         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2546         method.
2547
2548 2019-08-15  Tom de Vries  <tdevries@suse.de>
2549
2550         * linux-nat-trad.c: Include gdbarch.h.
2551
2552 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2553
2554         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2555         register sizes.
2556
2557 2019-08-14  Tom Tromey  <tromey@adacore.com>
2558
2559         * darwin-nat.c: Include gdbarch.h.
2560         * darwin-nat-info.c: Include gdbarch.h.
2561
2562 2019-08-13  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2565         Remove.
2566         * tui/tui-data.c (tui_initialize_static_data): Update.
2567
2568 2019-08-13  Tom Tromey  <tom@tromey.com>
2569
2570         * tui/tui-winsource.h (struct tui_exec_info_window)
2571         <~tui_exec_info_window, maybe_allocate_content, get_content,
2572         m_content>: Remove.
2573         (struct tui_source_window_base) <set_exec_info_content,
2574         show_exec_info_content>: Don't declare.
2575         * tui/tui-winsource.c
2576         (tui_exec_info_window::maybe_allocate_content): Remove.
2577         (tui_source_window_base::update_exec_info): Rename from
2578         set_exec_info_content.
2579         (tui_source_window_base::show_exec_info_content)
2580         (tui_source_window_base::update_exec_info): Remove.
2581
2582 2019-08-13  Tom Tromey  <tom@tromey.com>
2583
2584         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2585         declare.
2586         * tui/tui-winsource.c (tui_update_source_window_as_is)
2587         (tui_update_source_windows_with_addr, tui_erase_source_content):
2588         Update.
2589         (tui_clear_exec_info_content): Remove.
2590
2591 2019-08-13  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2594         declare.
2595         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2596         call tui_erase_exec_info_content.
2597         (tui_clear_exec_info_content): Rename from
2598         tui_erase_exec_info_content.
2599         (tui_clear_exec_info_content): Delete.
2600
2601 2019-08-13  Tom Tromey  <tom@tromey.com>
2602
2603         * tui/tui-winsource.h (struct tui_source_window_base)
2604         <show_exec_info_content>: Declare.
2605         (tui_show_exec_info_content): Don't declare.
2606         * tui/tui-winsource.c
2607         (tui_source_window_base::show_exec_info_content): Rename from
2608         tui_show_exec_info_content.
2609         (tui_source_window_base::update_exec_info): Update.
2610
2611 2019-08-13  Tom Tromey  <tom@tromey.com>
2612
2613         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2614         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2615         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2616         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2617         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2618         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2619         ... here.
2620
2621 2019-08-13  Tom Tromey  <tom@tromey.com>
2622
2623         * tui/tui-winsource.h (struct tui_source_window_base)
2624         <update_exec_info>: Declare.
2625         (tui_update_exec_info): Don't declare.
2626         * tui/tui-winsource.c (tui_update_source_window_as_is)
2627         (tui_source_window_base::refresh_all)
2628         (tui_update_all_breakpoint_info): Update.
2629         (tui_source_window_base::update_exec_info): Rename from
2630         tui_update_exec_info.
2631         * tui/tui-stack.c (tui_show_frame_info): Update.
2632
2633 2019-08-13  Tom Tromey  <tom@tromey.com>
2634
2635         * tui/tui-winsource.h (struct tui_source_window_base)
2636         <set_exec_info_content>: Declare.
2637         (tui_set_exec_info_content): Don't declare.
2638         * tui/tui-winsource.c
2639         (tui_source_window_base::set_exec_info_content): Rename from
2640         tui_set_exec_info_content.
2641         (tui_update_exec_info): Update.
2642
2643 2019-08-13  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-winsource.h (struct tui_source_window_base)
2646         <show_source_content>: Declare.
2647         (tui_show_source_content): Don't declare.
2648         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2649         (tui_source_window_base::show_source_content): Rename from
2650         tui_show_source_content.
2651         (tui_source_window_base::refresh_all): Update.
2652         * tui/tui-layout.c (show_source_disasm_command)
2653         (show_source_or_disasm_and_command): Update.
2654
2655 2019-08-13  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui-winsource.c (tui_erase_source_content)
2658         (tui_show_source_content, tui_source_window_base::refresh_all):
2659         Update.
2660         * tui/tui-wingeneral.h
2661         (tui_check_and_display_highlight_if_needed): Don't declare.
2662         * tui/tui-wingeneral.c
2663         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2664         check_and_display_highlight_if_needed.
2665         * tui/tui-win.c (tui_rehighlight_all)
2666         (tui_win_info::make_visible_with_new_height): Update.
2667         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2668         (tui_data_window::erase_data_content)
2669         (tui_data_window::display_all_data): Update.
2670         * tui/tui-data.h (struct tui_win_info)
2671         <check_and_display_highlight_if_needed>: Declare.
2672
2673 2019-08-13  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-win.c (tui_resize_all): Call
2676         tui_delete_invisible_windows.
2677         * tui/tui-layout.c (show_layout): Call
2678         tui_delete_invisible_windows.
2679         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2680         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2681
2682 2019-08-13  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2685         tui_add_win_to_layout.
2686
2687 2019-08-13  Tom Tromey  <tom@tromey.com>
2688
2689         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2690         * tui/tui-layout.c (tui_default_win_height): Now static.
2691
2692 2019-08-13  Tom Tromey  <tom@tromey.com>
2693
2694         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2695         single switch.
2696         (show_source_disasm_command, show_source_or_disasm_and_command):
2697         Don't check current layout.
2698
2699 2019-08-13  Tom Tromey  <tom@tromey.com>
2700
2701         * tui/tui-wingeneral.c (make_all_visible): Remove.
2702         (tui_make_all_invisible): Simplify.
2703         * tui/tui-layout.c (tui_make_all_invisible): Move from
2704         tui-wingeneral.c; simplify.
2705         (show_layout): Hoist call to tui_make_all_invisible.
2706         (show_data): Don't call tui_make_all_invisible.
2707
2708 2019-08-13  Tom Tromey  <tom@tromey.com>
2709
2710         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2711         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2712
2713 2019-08-13  Tom Tromey  <tom@tromey.com>
2714
2715         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2716         tui-data.c.
2717         (show_source_disasm_command, show_data)
2718         (show_source_or_disasm_and_command): Don't use
2719         tui_set_current_layout_to.
2720         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2721         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2722         tui-layout.c.
2723         (tui_set_current_layout_to): Remove.
2724
2725 2019-08-13  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-layout.c (tui_set_layout): Update.
2728         * tui/tui-data.h (struct tui_layout_def): Remove.
2729         (tui_layout_def): Don't declare.
2730         * tui/tui-data.c (layout_def): Remove.
2731         (tui_layout_def): Remove.
2732
2733 2019-08-13  Tom Tromey  <tom@tromey.com>
2734
2735         * tui/tui-winsource.h (struct tui_source_window_base)
2736         <clear_detail>: No longer "override".
2737         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2738         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2739         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2740         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2741         Remove.
2742         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2743
2744 2019-08-13  Tom Tromey  <tromey@adacore.com>
2745
2746         * tracepoint.c: Don't include readline.h or history.h.
2747
2748 2019-08-12  Tom Tromey  <tom@tromey.com>
2749
2750         * configure: Rebuild.
2751         * configure.ac: Check for readline 7.
2752         * NEWS: Mention readline 7 requirement.
2753         * README: Update.
2754
2755 2019-08-12  Tom Tromey  <tom@tromey.com>
2756
2757         * mingw-hdep.c (gdb_select): Remove readline hack.
2758
2759 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2760
2761         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2762         when the function fails.
2763
2764 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2765
2766         * s390-tdep.c (s390_type_align): New function.
2767         (s390_gdbarch_init): Set it as type_align gdbarch method.
2768
2769 2019-08-09  Tom de Vries  <tdevries@suse.de>
2770
2771         PR gdb/24591
2772         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2773         pc_low with relocation offset.
2774
2775 2019-08-07  Tom Tromey  <tromey@adacore.com>
2776
2777         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2778         (print_frame_args): Update.
2779         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2780         Update.
2781         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2782         * frame.h (struct frame_arg): Add initializers.
2783         <error>: Now a unique_xmalloc_ptr.
2784
2785 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2786
2787         * NEWS: Expand the Pointer Authentication entry.
2788         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2789         (aarch64_frame_unmask_lr): ... to this.
2790         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2791         Call aarch64_frame_unmask_lr.
2792         * frame.c (struct frame_info): Add "masked" variable.
2793         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2794         (fprint_frame): Check for masked pc.
2795         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2796         declarations.
2797         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2798         * stack.c (print_frame): Check for masked pc.
2799
2800 2019-08-06  Tom Tromey  <tom@tromey.com>
2801
2802         * stabsread.c (patch_block_stabs, read_one_struct_field)
2803         (read_enum_type): Use obstack_strndup.
2804         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2805         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2806         * dwarf2read.c (guess_full_die_structure_name)
2807         (anonymous_struct_prefix): Use obstack_strndup.
2808         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2809         * c-exp.y (yylex): Use obstack_strndup.
2810         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2811         (write_var_or_type): Use obstack_strndup.
2812
2813 2019-08-06  Tom Tromey  <tom@tromey.com>
2814
2815         * symfile.c (reread_symbols): Use obstack_strdup.
2816         * stabsread.c (read_type): Use obstack_strdup.
2817         * gdb_obstack.h (obstack_strdup): New overload.
2818         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2819         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2820         (dwarf2_canonicalize_name): Use obstack_strdup.
2821         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2822         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2823         Use obstack_strdup.
2824
2825 2019-08-06  Tom Tromey  <tom@tromey.com>
2826
2827         * gdb_obstack.h (obstack_strdup): Define.
2828         * gdb_obstack.c (obstack_strdup): Don't define.
2829
2830 2019-08-06  Tom Tromey  <tom@tromey.com>
2831
2832         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2833         obstack_strdup.
2834         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2835         obstack_strdup.
2836         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2837         * stabsread.c (common_block_start): Use obstack_strdup.
2838         * objfiles.c (set_objfile_main_name, objfile): Use
2839         obstack_strdup.
2840         * namespace.c (add_using_directive): Use obstack_strdup.
2841         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2842         * jit.c (finalize_symtab): Use obstack_strdup.
2843         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2844         (guess_partial_die_structure_name, partial_die_info::fixup)
2845         (dwarf2_name): Use obstack_strdup.
2846         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2847         obstack_strdup.
2848         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2849         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2850         obstack_strdup.
2851         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2852
2853 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2854
2855         * unittests/help-doc-selftests.c: New file.
2856         * Makefile.in: Add the new file.
2857
2858 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2859
2860         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2861         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2862         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2863         the trailing '.' is not output, and the first character is uppercased.
2864         (print_help_for_command): Update call to print_doc_line.
2865         (print_doc_of_command): Likewise.
2866         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2867         * cli/cli-option.c (append_indented_doc): Do not append newline.
2868         (build_help_option): Append newline after first appended_indented_doc
2869         only if a second call is done.
2870         (build_help): Append 2 new lines before each option, except the first
2871         one.
2872         * compile/compile.c (_initialize_compile): Add new lines after
2873         %OPTIONS%, when not at the end of the help.
2874         Change help doc or code
2875         producing the help doc to respect the invariants.
2876         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2877         Also removed the new line after 'Options:', as all other commands
2878         do not put an empty line between 'Options:' and the first option.
2879         * printcmd.c (_initialize_printcmd): Likewise.
2880         * stack.c (_initialize_stack): Likewise.
2881         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2882         incorrectly telling COMMAND is optional.
2883         * ada-lang.c (_initialize_ada_language): Change help doc or code
2884         producing the help doc to respect the invariants.
2885         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2886         * breakpoint.c (_initialize_breakpoint): Likewise.
2887         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2888         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2889         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2890         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2891         _initialize_cli_style): Likewise.
2892         * corelow.c (core_target_info): Likewise.
2893         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2894         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2895         * filesystem.c (_initialize_filesystem): Likewise.
2896         * frame.c (_initialize_frame): Likewise.
2897         * gnu-nat.c (add_task_commands): Likewise.
2898         * infcall.c (_initialize_infcall): Likewise.
2899         * infcmd.c (_initialize_infcmd): Likewise.
2900         * interps.c (_initialize_interpreter): Likewise.
2901         * language.c (_initialize_language): Likewise.
2902         * linux-fork.c (_initialize_linux_fork): Likewise.
2903         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2904         * maint.c (_initialize_maint_cmds): Likewise.
2905         * memattr.c (_initialize_mem): Likewise.
2906         * printcmd.c (_initialize_printcmd): Likewise.
2907         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2908         _RegEx): Likewise.
2909         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2910         * record-btrace.c (_initialize_record_btrace): Likewise.
2911         * record-full.c (_initialize_record_full): Likewise.
2912         * record.c (_initialize_record): Likewise.
2913         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2914         * regcache.c (_initialize_regcache): Likewise.
2915         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2916         _initialize_remote): Likewise.
2917         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2918         * serial.c (_initialize_serial): Likewise.
2919         * skip.c (_initialize_step_skip): Likewise.
2920         * source.c (_initialize_source): Likewise.
2921         * stack.c (_initialize_stack): Likewise.
2922         * symfile.c (_initialize_symfile): Likewise.
2923         * symtab.c (_initialize_symtab): Likewise.
2924         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2925         * top.c (init_main): Likewise.
2926         * tracefile-tfile.c (tfile_target_info): Likewise.
2927         * tracepoint.c (_initialize_tracepoint): Likewise.
2928         * tui/tui-win.c (_initialize_tui_win): Likewise.
2929         * utils.c (add_internal_problem_command): Likewise.
2930         * valprint.c (value_print_option_defs): Likewise.
2931
2932 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2933
2934         PR build/24886
2935         * configure.ac: Drop enable-libmcheck support.
2936         * configure, config.in: Rebuild.
2937         * libmcheck.m4: Remove.
2938         * acinclude.m4: Don't include it.
2939         * Makefile.in: Don't distribute it.
2940         * top.c (print_gdb_configuration): Don't mention it.
2941
2942 2019-08-06  Tom Tromey  <tom@tromey.com>
2943
2944         * utils.c (set_output_style): Sometimes pass stream to
2945         emit_style_escape.
2946         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2947         * record-btrace.c (btrace_insn_history): Update.
2948         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2949         method.
2950         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2951         Update initializers.
2952         <m_uiout>: New field.
2953         <m_di>: Move lower.
2954         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2955         Remove "uiout" parameter.
2956         (dump_insns): Update.
2957         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2958         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2959
2960 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2961
2962         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2963         (error_in_psymtab_expansion): Likewise.
2964         (lookup_symbol_via_quick_fns): Likewise.
2965         (basic_lookup_transparent_type_quick): Likewise.
2966         (basic_lookup_transparent_type_1): Likewise.
2967
2968 2019-08-06  Tom Tromey  <tromey@adacore.com>
2969
2970         * source.c (last_source_error): Now bool.
2971         (print_source_lines_base): Make "noprint" bool.  Only open
2972         source file when last_source_visited changes.
2973
2974 2019-08-06  Tom Tromey  <tromey@adacore.com>
2975
2976         * annotate.c (annotate_source_line): Use g_source_cache.
2977         * source-cache.c (source_cache::get_plain_source_lines): Change
2978         parameters.  Populate m_offset_cache.
2979         (source_cache::ensure): New method.
2980         (source_cache::get_line_charpos): New method.
2981         (extract_lines): Move lower.  Change parameters.
2982         (source_cache::get_source_lines): Move lower.
2983         * source-cache.h (class source_cache): Update comment.
2984         <get_line_charpos>: New method.
2985         <get_source_lines>: Update comment.
2986         <clear>: Clear m_offset_cache.
2987         <get_plain_source_lines>: Change parameters.
2988         <ensure>: New method
2989         <m_offset_cache>: New member.
2990         * source.c (forget_cached_source_info_for_objfile): Update.
2991         (info_source_command): Use g_source_cache.
2992         (find_source_lines, open_source_file_with_line_charpos): Remove.
2993         (print_source_lines_base, search_command_helper): Use g_source_cache.
2994         * source.h (open_source_file_with_line_charpos): Don't declare.
2995         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2996         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2997         Use g_source_cache.
2998
2999 2019-08-06  Tom Tromey  <tromey@adacore.com>
3000
3001         * source-cache.c (source_cache::get_plain_source_lines):
3002         Remove "first_line" and "last_line" parameters.
3003         (source_cache::get_source_lines): Cache plain text.
3004         * source-cache.h (class source_cache)
3005         <get_plain_source_lines>: Update.
3006
3007 2019-08-06  Tom Tromey  <tromey@adacore.com>
3008
3009         * source-cache.c (extract_lines): No longer a method.
3010         Changed type of parameter.  Include final newline.
3011         (selftests::extract_lines_test): New function.
3012         (_initialize_source_cache): Likewise.
3013         * source-cache.h (class source_cache)
3014         <extract_lines>: Don't declare.
3015
3016 2019-08-06  Tom Tromey  <tromey@adacore.com>
3017
3018         * breakpoint.c (init_breakpoint_sal): Update.
3019         (breakpoint): Update.
3020         * breakpoint.h (struct breakpoint) <filter>: Now a
3021         unique_xmalloc_ptr.
3022
3023 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3024
3025         * NEWS: Mention dictionary access on blocks.
3026         * python/py-block.c (blpy_getitem): New function.
3027         (block_object_as_mapping): New struct.
3028         (block_object_type): Use new struct for tp_as_mapping field.
3029
3030 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3031
3032         * objfiles.h (objfile): Add a comment describing partial symbols.
3033
3034 2019-08-05  Tom Tromey  <tromey@adacore.com>
3035
3036         * compile/compile.c (_initialize_compile): Use _(), not N_().
3037         * thread.c (_initialize_thread): Use _(), not N_().
3038         * stack.c (_initialize_stack): Use _(), not N_().
3039         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3040
3041 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3042
3043         * dwarf2read.c (struct dw2_symtab_iterator):
3044         <want_specific_block>: Remove.
3045         <block_index>: Change type to gdb::optional.
3046         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3047         change type of BLOCK_INDEX parameter to gdb::optional.
3048         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3049         (dw2_lookup_symbol): Don't pass argument for
3050         WANT_SPECIFIC_BLOCK.
3051         (dw2_expand_symtabs_for_function): Don't pass argument for
3052         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3053         (class dw2_debug_names_iterator)
3054         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3055         parameter, change BLOCK_INDEX type to gdb::optional.
3056         <m_want_specific_block>: Remove.
3057         <m_block_index>: Change type to gdb::optional.
3058         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3059         gdb::optional.  Re-write in function of gdb::optional.
3060         (dw2_debug_names_lookup_symbol): Don't pass argument for
3061         WANT_SPECIFIC_BLOCK.
3062         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3063         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3064         BLOCK_INDEX.
3065
3066 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3067
3068         * NEWS: Mention changes to "info sources" command.
3069
3070 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3071
3072         * symtab.c (filename_partial_match_opts): New struct type.
3073         (struct output_source_filename_data): New members
3074         regexp, c_regexp, partial_match.
3075         (output_source_filename): Use new members to decide to print file.
3076         (info_sources_option_defs): New variable.
3077         (make_info_sources_options_def_group, print_info_sources_header,
3078         info_sources_command_completer):
3079         New functions.
3080         (info_sources_command): Read new optional arguments.
3081         (_initialize_symtab): Update info sources help.
3082
3083 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3084
3085         * ada-lang.c (exception_support_info_v0): Renamed from...
3086         (default_exception_support_info): ... this.  Create new
3087         definition for v1.
3088         (ada_has_this_exception_support): Look up catch_handlers_sym.
3089         (ada_exception_support_info_sniffer): Try v0 after default.
3090
3091 2019-08-01  Tom Tromey  <tromey@adacore.com>
3092
3093         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3094         gdbarch.h.
3095
3096 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3097
3098         * s12z-tdep.c: Fix include path for s12z-opc.h.
3099
3100 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3101
3102         * NEWS: Require GNU make 3.82.
3103
3104 2019-07-16  Tom Tromey  <tom@tromey.com>
3105
3106         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3107         declare.
3108
3109 2019-07-30  Tom Tromey  <tromey@adacore.com>
3110
3111         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3112
3113 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3114
3115         * printcmd.c (print_address_symbolic): Print negative offsets.
3116         (build_address_symbolic): Force signed arithmetic when computing
3117         offset.
3118
3119 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3120
3121         PR/24474: Add a function to lookup static variables.
3122         * NEWS: Mention this new function.
3123         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3124         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3125         * python/python.c (python_GdbMethods): Add new function.
3126
3127 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3128
3129         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3130         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3131         (objfpy_lookup_static_symbol): New function.
3132         (objfile_object_methods): Add new functions.
3133
3134 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3135
3136         * NEWS: Mention 'set|show print frame-info'.  Mention new
3137         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3138         backtrace argument.  Mention that python frame filtering code
3139         is now consistent with what 'backtrace' command prints.
3140
3141 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3142
3143         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3144         comments.
3145         (print_frame_info_auto, print_frame_info_source_line,
3146         print_frame_info_location, print_frame_info_source_and_location,
3147         print_frame_info_location_and_address, print_frame_info_short_location):
3148         New declarations.
3149         (struct frame_print_options): New member print_frame_info.
3150         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3151         * stack.h (get_user_print_what_frame_info): New declaration.
3152         (frame_show_address): New declaration.
3153         * stack.c (print_frame_arguments_choices): New value 'presence'.
3154         (print_frame_info_auto, print_frame_info_source_line,
3155         print_frame_info_location, print_frame_info_source_and_location,
3156         print_frame_info_location_and_address, print_frame_info_short_location,
3157         print_frame_info_choices, print_frame_info_print_what): New definitions.
3158         (print_frame_args): Only print dots for args if print frame-arguments
3159         is 'presence'.
3160         (frame_print_option_defs): New element for "frame-info".
3161         (get_user_print_what_frame_info): New function.
3162         (frame_show_address): Make non static.  Move comment to stack.h.
3163         (print_frame_info_to_print_what): New function.
3164         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3165         to decide what to print.
3166         (backtrace_command_1): Handle the new print_frame_arguments_presence
3167         value.
3168         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3169         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3170         (py_print_frame): In non-mi mode, use LOCATION as default for
3171         print_what, similarly to frame information printed directly by
3172         backtrace command. Handle frame-info user option in non MI mode.
3173
3174 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3175
3176         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3177         Add case for debugging 32-bit target on 64-bit host.  Revise
3178         comment.
3179
3180 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3181
3182         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3183         instead of find_function_entry_range_from_pc.
3184
3185 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3186
3187         * stack.c (find_frame_funname): Remove code which preferred
3188         minsym over symtab sym in "certain pathological cases".
3189
3190         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3191         parameter.  Change type of "do_demangle" to bool.
3192         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3193         Pass suitable "prefer_sym_over_minsym" flag to
3194         build_address_symbolic().  Don't output "+" for negative offsets.
3195         * printcmd.c (print_address_symbolic): Update invocation of
3196         build_address_symbolic to include a "prefer_sym_over_minsym"
3197         flag.
3198         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3199         Restrict cases in which use of minimal symbol is preferred to that
3200         of a found symbol.  Update comments.
3201
3202         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3203         for entry pc when entry pc is out of range for that FDE.
3204
3205 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3206
3207         PR gdb/24839:
3208         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3209         type.
3210
3211 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3212
3213         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3214         this function's Python signature.
3215
3216
3217 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3218
3219         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3220         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3221         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3222         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3223         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3224
3225
3226 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3227
3228         * h8300-tdep.c (h8300_register_name_common): New.
3229         h8300_register_name): Use h8300_register_name_common.
3230         (h8300s_register_name): Likewise.
3231         (h8300sx_register_name): Likewise.
3232         (h8300h_register_nam): New.
3233         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3234
3235
3236 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3237
3238         * arm-tdep.c (arm_skip_cmse_entry): New function.
3239         (arm_is_sgstubs_section): New function.
3240         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3241
3242 2019-07-22  Tom Tromey  <tom@tromey.com>
3243
3244         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3245         Don't self-assign.
3246
3247 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3248
3249         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3250         type_print.
3251
3252 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3253
3254         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3255         so that GDB doesn't match any msymbols when searching in the
3256         TYPES_DOMAIN.
3257         (print_symbol_info): Print using typedef_print or type_print based
3258         on the type of the symbol.  Add updated FIXME comment moved from...
3259         (_initialize_symtab): ... move and update FIXME comment to above.
3260
3261 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3262
3263         * NEWS: Mention adding -q option to "info types".
3264         * symtab.c (struct info_types_options): New struct.
3265         (info_types_options_defs): New variable.
3266         (make_info_types_options_def_group): New function.
3267         (info_types_command): Use gdb::option framework to parse options.
3268         (info_types_command_completer): New function.
3269         (_initialize_symtab): Extend the help text on "info types" and
3270         register command completer.
3271
3272 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3273
3274         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3275         (lookup_symbol_in_objfile): Change int to block_enum and add a
3276         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3277
3278 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3279
3280         * MAINTAINERS (Write After Approval): Add self.
3281
3282 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3283
3284         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3285         instruction to the dummy code region.
3286
3287 2019-07-19  Tom Tromey  <tromey@adacore.com>
3288
3289         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3290         (ARGSUSED, PARAMS, __func__): Remove rules.
3291
3292 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3293
3294         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3295         * features/arm/arm-with-iwmmxt.c: Remove.
3296         * features/arm/arm-with-iwmmxt.xml: Remove.
3297         * features/arm/arm-with-m-fpa-layout.c: Remove.
3298         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3299         * features/arm/arm-with-m-vfp-d16.c: Remove.
3300         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3301         * features/arm/arm-with-m.c: Remove.
3302         * features/arm/arm-with-m.xml: Remove.
3303         * features/arm/arm-with-neon.c: Remove.
3304         * features/arm/arm-with-neon.xml: Remove.
3305         * features/arm/arm-with-vfpv2.c: Remove.
3306         * features/arm/arm-with-vfpv2.xml: Remove.
3307         * features/arm/arm-with-vfpv3.c: Remove.
3308         * features/arm/arm-with-vfpv3.xml: Remove.
3309
3310 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3311
3312         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3313
3314 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3315
3316         * arch/aarch32.c (aarch32_create_target_description): Create
3317         target descriptions using features.
3318         * arch/arm.c (arm_create_target_description)
3319         (arm_create_mprofile_target_description): Likewise.
3320         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3321
3322 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3323
3324         * Makefile.in: Add new files.
3325         * aarch32-tdep.c: New file.
3326         * aarch32-tdep.h: New file.
3327         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3328         Call aarch32_read_description.
3329         * arch/aarch32.c: New file.
3330         * arch/aarch32.h: New file.
3331         * arch/arm.c (arm_create_target_description)
3332         (arm_create_mprofile_target_description): New function.
3333         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3334         (arm_create_target_description)
3335         (arm_create_mprofile_target_description): New declaration.
3336         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3337         read_description functions.
3338         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3339         Likewise.
3340         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3341         * arm-tdep.c (tdesc_arm_list): New variable.
3342         (arm_register_g_packet_guesses): Call create description functions.
3343         (arm_read_description) (arm_read_mprofile_description): New
3344         function.
3345         * arm-tdep.h (arm_read_description)
3346         (arm_read_mprofile_description): Add declaration.
3347         * configure.tgt: Add new files.
3348
3349 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3350
3351         * top.c (new_ui_command): Open specified terminal just once.
3352
3353 2019-07-18  Tom Tromey  <tromey@adacore.com>
3354
3355         * symtab.c (main_name): Constify return type.
3356         * symfile.c (set_initial_language): Update.
3357         * symtab.h (main_name): Constify return type.
3358
3359 2019-07-17  Tom Tromey  <tom@tromey.com>
3360
3361         * tui/tui-winsource.c (tui_update_source_window)
3362         (tui_update_source_window_as_is)
3363         (tui_update_source_windows_with_line): Remove return.
3364         * tui/tui-disasm.c (tui_show_disassem)
3365         (tui_show_disassem_and_update_source): Remove return.
3366         * tui/tui.c (tui_reset): Remove return.
3367         * tui/tui-wingeneral.c
3368         (tui_check_and_display_highlight_if_needed): Remove return.
3369
3370 2019-07-17  Tom Tromey  <tom@tromey.com>
3371
3372         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3373
3374 2019-07-17  Tom Tromey  <tom@tromey.com>
3375
3376         * tui/tui-winsource.h (struct tui_exec_info_window)
3377         (struct tui_source_window_base): Move from tui-data.h.
3378         * tui/tui-winsource.c: Move many method definitions from
3379         elsewhere.  Remove "structuring" comments.
3380         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3381         (tui_source_window_base::refresh_window): Move to
3382         tui-winsource.c.
3383         * tui/tui-win.c (tui_source_window_base::refresh_all)
3384         (tui_source_window_base::update_tab_width)
3385         (tui_source_window_base::set_new_height)
3386         (tui_source_window_base::do_make_visible_with_new_height): Move to
3387         tui-winsource.c.
3388         * tui/tui-source.h: Update.
3389         * tui/tui-source.c (tui_source_window_base::reset): Move to
3390         tui-winsource.c.
3391         * tui/tui-disasm.h: Update.
3392         * tui/tui-data.h (struct tui_exec_info_window): Move to
3393         tui-winsource.h.
3394         (struct tui_source_window_base): Likewise.
3395         * tui/tui-data.c (tui_source_window_base::clear_detail)
3396         (tui_source_window_base, ~tui_source_window_base): Move to
3397         tui-winsource.c.
3398
3399 2019-07-17  Tom Tromey  <tom@tromey.com>
3400
3401         * tui/tui-win.c (tui_resize_all)
3402         (tui_source_window_base::update_tab_width)
3403         (tui_adjust_win_heights): Update.
3404         (tui_win_info::make_invisible_and_set_new_height): Rename from
3405         make_invisible_and_set_new_height.
3406         * tui/tui-data.h (struct tui_win_info)
3407         <make_invisible_and_set_new_height>: New method.
3408
3409 2019-07-17  Tom Tromey  <tom@tromey.com>
3410
3411         * tui/tui.c: Update.
3412         * tui/tui-source.h (struct tui_source_window): Move from
3413         tui-data.h.
3414         * tui/tui-layout.c: Update.
3415         * tui/tui-disasm.c: Update.
3416         * tui/tui-data.h (struct tui_source_window): Move to
3417         tui-source.h.
3418
3419 2019-07-17  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3422         tui-data.h.
3423         * tui/tui-data.h (struct tui_disasm_window): Move to
3424         tui-disasm.h.
3425
3426 2019-07-17  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-regs.h (struct tui_data_item_window): Move from
3429         tui-data.h.
3430         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3431         * tui/tui-data.h (struct tui_data_item_window): Move to
3432         tui-regs.h.
3433         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3434
3435 2019-07-17  Tom Tromey  <tom@tromey.com>
3436
3437         * tui/tui.c: Update.
3438         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3439         (tui_cmd_window::max_height): Move to tui-command.c.
3440         * tui/tui-layout.c: Update.
3441         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3442         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3443         tui-command.c.
3444         * tui/tui-command.h (struct tui_cmd_window): Move from
3445         tui-data.h.
3446         * tui/tui-command.c: Remove "structuring" comments.
3447         (tui_cmd_window::clear_detail)
3448         (tui_cmd_window::do_make_visible_with_new_height)
3449         (tui_cmd_window::max_height): Move from elsewhere.
3450
3451 2019-07-17  Tom Tromey  <tom@tromey.com>
3452
3453         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3454         Now static.
3455         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3456         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3457
3458 2019-07-17  Tom Tromey  <tom@tromey.com>
3459
3460         * tui/tui.c: Update.
3461         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3462         tui-regs.c.
3463         * tui/tui-windata.h: Remove file.
3464         * tui/tui-windata.c: Remove file.
3465         * tui/tui-win.c (tui_data_window::set_new_height)
3466         (tui_data_window::do_make_visible_with_new_height): Move to
3467         tui-regs.c.
3468         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3469         * tui/tui-regs.c: Remove "structuring" comments.
3470         (tui_data_window::first_data_item_displayed)
3471         (tui_data_window::delete_data_content_windows)
3472         (tui_data_window::erase_data_content)
3473         (tui_data_window::display_all_data)
3474         (tui_data_window::refresh_all)
3475         (tui_data_window::do_scroll_vertical)
3476         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3477         (tui_data_window::do_make_visible_with_new_height)
3478         (tui_data_window::refresh_window): Move from elsewhere.
3479         (_initialize_tui_regs): Move to end of file.
3480         * tui/tui-layout.c: Update.
3481         * tui/tui-hooks.c: Update.
3482         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3483         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3484         tui-regs.c.
3485         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3486
3487 2019-07-17  Tom Tromey  <tom@tromey.com>
3488
3489         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3490         seen.
3491
3492 2019-07-17  Tom Tromey  <tom@tromey.com>
3493
3494         * tui/tui-win.c (tui_source_window_base::set_new_height)
3495         (tui_source_window_base::do_make_visible_with_new_height): Use
3496         m_has_locator field directly.
3497         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3498         method.
3499         (struct tui_source_window_base) <has_locator>: Likewise.
3500
3501 2019-07-17  Tom Tromey  <tom@tromey.com>
3502
3503         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3504         Don't declare.
3505         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3506         Remove.
3507         * tui/tui-win.c (tui_source_window_base::set_new_height)
3508         (tui_source_window_base::set_new_height)
3509         (make_invisible_and_set_new_height)
3510         (tui_source_window_base::do_make_visible_with_new_height)
3511         (tui_source_window_base::do_make_visible_with_new_height):
3512         Update.
3513         * tui/tui-layout.c (show_source_disasm_command, show_data)
3514         (show_source_or_disasm_and_command): Update.
3515         * tui/tui-layout.c (show_layout): Update.
3516
3517 2019-07-17  Tom Tromey  <tom@tromey.com>
3518
3519         * tui/tui-layout.c (make_data_window): Remove.
3520         (show_data): Unify creation and re-initialization cases.
3521
3522 2019-07-17  Tom Tromey  <tom@tromey.com>
3523
3524         * tui/tui-layout.c (make_source_window, make_disasm_window):
3525         Remove.
3526         (show_data): Unify creation and re-initialization cases.
3527
3528 2019-07-17  Tom Tromey  <tom@tromey.com>
3529
3530         * tui/tui-layout.c (make_command_window): Remove.
3531         (show_source_disasm_command, show_source_or_disasm_and_command):
3532         Unify creation and re-initialization cases.
3533
3534 2019-07-17  Tom Tromey  <tom@tromey.com>
3535
3536         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3537         creation and re-initialization cases.
3538
3539 2019-07-17  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-regs.c (tui_get_register): Return void.
3542
3543 2019-07-17  Tom Tromey  <tom@tromey.com>
3544
3545         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3546         Simplify.
3547
3548 2019-07-17  Tom Tromey  <tom@tromey.com>
3549
3550         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3551         resetting.
3552
3553 2019-07-17  Tom Tromey  <tom@tromey.com>
3554
3555         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3556         * tui/tui-regs.c (tui_reg_layout): New function.
3557         (tui_show_registers, tui_reg_command): Use it.
3558         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3559         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3560         parameters.
3561         (tui_layout_command): Remove.
3562
3563 2019-07-17  Tom Tromey  <tom@tromey.com>
3564
3565         * tui/tui-layout.h (tui/tui-layout): Return void.
3566         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3567
3568 2019-07-17  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui-layout.c (show_source_disasm_command, show_data):
3571         Update.
3572         (reset_locator): Remove.
3573         (show_source_or_disasm_and_command): Update.
3574
3575 2019-07-17  Tom Tromey  <tom@tromey.com>
3576
3577         * tui/tui-source.c (tui_source_window_base::reset): Remove
3578         win_type parameter.
3579         * tui/tui-layout.c (make_command_window, make_source_window)
3580         (make_disasm_window, make_data_window)
3581         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3582         (reset_locator, show_source_or_disasm_and_command): Update.
3583         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3584         win_type parameter.
3585         (struct tui_source_window_base) <reset>: Likewise.
3586
3587 2019-07-17  Tom Tromey  <tom@tromey.com>
3588
3589         * tui/tui-layout.c (show_source_disasm_command): Use
3590         reset_locator.
3591         (reset_locator): New function.
3592         (init_and_make_win): Remove.
3593         (show_source_or_disasm_and_command): Use reset_locator.
3594
3595 2019-07-17  Tom Tromey  <tom@tromey.com>
3596
3597         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3598         condition.
3599         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3600         Remove condition.
3601         * tui/tui-source.c (tui_source_window_base::reset): New method.
3602         * tui/tui-layout.c (make_command_window): Don't call
3603         init_and_make_win.
3604         (make_source_window, make_disasm_window): Don't call
3605         make_source_or_disasm_window.
3606         (make_data_window): Don't call init_and_make_win.  Change calling
3607         convention.
3608         (show_source_disasm_command, show_data): Simplify.
3609         (make_source_or_disasm_window): Remove.
3610         (show_source_or_disasm_and_command): Simplify.
3611         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3612         (struct tui_source_window_base) <reset>: Likewise.
3613         <execution_info>: Remove initializer.
3614         * tui/tui-data.c (tui_source_window_base): Initialize
3615         execution_info.
3616
3617 2019-07-17  Tom Tromey  <tom@tromey.com>
3618
3619         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3620         variable.
3621
3622 2019-07-17  Tom Tromey  <tom@tromey.com>
3623
3624         * tui/tui.c (tui_rl_other_window): Update.
3625         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3626         superclass method first.  Always iterate over regs_content.
3627         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3628         method.
3629         * tui/tui-win.c (tui_set_focus_command): Update.
3630
3631 2019-07-17  Tom Tromey  <tom@tromey.com>
3632
3633         * tui/tui-win.c (tui_set_focus_command): Rename from
3634         tui_set_focus.  Call tui_enable.
3635         (tui_set_focus_command): Remove.
3636
3637 2019-07-17  Tom Tromey  <tom@tromey.com>
3638
3639         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3640         refresh_window.
3641         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3642         touchwin.
3643         (tui_data_window::refresh_window): Call refresh_window on data
3644         items.  Always call superclass refresh_window.
3645         (tui_win_info::refresh): Remove.
3646         (tui_source_window_base::refresh_window): Update.
3647         (tui_refresh_all): Update.
3648         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3649         refresh_window.
3650         (show_source_or_disasm_and_command): Likewise.
3651         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3652         (struct tui_source_window_base) <refresh>: Likewise.
3653
3654 2019-07-17  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui-winsource.c (tui_clear_source_content)
3657         (tui_show_source_content): Update.
3658         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3659         whether content is empty.
3660         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3661         Remove.
3662
3663 2019-07-17  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3666         window's contents.
3667         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3668         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3669
3670 2019-07-17  Tom Tromey  <tom@tromey.com>
3671
3672         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3673         (struct tui_data_item_window): Update.
3674
3675 2019-07-17  Tom Tromey  <tom@tromey.com>
3676
3677         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3678         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3679         defines.
3680
3681 2019-07-17  Tom Tromey  <tom@tromey.com>
3682
3683         * tui/tui-winsource.h (tui_erase_source_content)
3684         (tui_clear_source_content): Remove "display_prompt" parameter.
3685         * tui/tui-winsource.c (tui_update_source_window_as_is)
3686         (tui_update_source_windows_with_addr): Update.
3687         (tui_clear_source_content): Remove "display_prompt" parameter.
3688         (tui_erase_source_content): Likewise.  Simplify.
3689         (tui_show_source_content): Update.
3690         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3691         * tui/tui-stack.c (tui_show_frame_info): Update.
3692         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3693         Remove defines.
3694
3695 2019-07-17  Tom Tromey  <tom@tromey.com>
3696
3697         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3698         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3699         parameter.
3700         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3701         parameter.
3702
3703 2019-07-17  Tom Tromey  <tom@tromey.com>
3704
3705         * tui/tui-winsource.c (tui_clear_source_content)
3706         (tui_show_source_content, tui_show_exec_info_content)
3707         (tui_clear_exec_info_content): Update.
3708         * tui/tui-stack.c (tui_show_locator_content): Update.
3709         (tui_show_frame_info): Update.
3710         * tui/tui-source.h (tui_source_window): Don't declare.
3711         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3712         from tui_source_is_displayed.
3713         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3714         Remove field.
3715         (struct tui_source_window_base) <content_in_use>: New field.  Now
3716         bool.
3717         (struct tui_source_window) <showing_source_p>: New method.
3718         (TUI_SRC_WIN): Change cast.
3719         * tui/tui-data.c (tui_initialize_static_data): Update.
3720
3721 2019-07-17  Tom Tromey  <tom@tromey.com>
3722
3723         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3724         location_matches_p.
3725         * tui/tui-source.c (tui_source_window::location_matches_p): New
3726         method.
3727         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3728         method.
3729         * tui/tui-data.h (struct tui_source_window_base)
3730         <location_matches_p>: New method.
3731         (struct tui_source_window, struct tui_disasm_window)
3732         <location_matches_p>: Likewise.
3733
3734 2019-07-17  Tom Tromey  <tom@tromey.com>
3735
3736         * tui/tui-win.c (tui_set_win_height_command): Rename from
3737         tui_set_win_height.
3738         (tui_set_win_height_command): Remove.
3739
3740 2019-07-17  Tom Tromey  <tom@tromey.com>
3741
3742         * tui/tui-source.c (tui_source_window): New constructor.  Add
3743         observer.
3744         (~tui_source_window): New destructor.
3745         (tui_source_window::style_changed): New method.
3746         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3747         (tui_attach_detach_observers): Update.
3748         * tui/tui-data.h (struct tui_source_window): Make constructor not
3749         inline.  Add destructor.
3750         (struct tui_source_window) <style_changed>: New method.
3751         <m_observable>: New member.
3752
3753 2019-07-17  Tom Tromey  <tom@tromey.com>
3754
3755         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3756         * tui/tui-win.c (tui_resize_all): Fix typo.
3757
3758 2019-07-17  Tom Tromey  <tom@tromey.com>
3759
3760         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3761         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3762         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3763         * tui/tui-win.c (window_name_completer): Use foreach.
3764         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3765         (update_tab_width): Likewise.
3766         * tui/tui-layout.c (show_layout): Update.
3767         * tui/tui-data.h (class tui_window_iterator): New.
3768         (struct all_tui_windows): New.
3769         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3770
3771 2019-07-17  Tom Tromey  <tom@tromey.com>
3772
3773         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3774         parameter.  Don't reference globals.
3775         (tui_reg_command): Update.
3776
3777 2019-07-17  Tom Tromey  <tom@tromey.com>
3778
3779         * tui/tui-regs.c (tui_show_registers): Simplify.
3780
3781 2019-07-17  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-regs.c (tui_show_registers): Update.
3784         (tui_show_register_group): Add win_info parameter.
3785
3786 2019-07-17  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3789         Rename from tui_display_reg_element_at_line.
3790         (tui_data_window::display_registers_from_line): Update.
3791         * tui/tui-data.h (struct tui_data_window)
3792         <display_reg_element_at_line>: New method.
3793
3794 2019-07-17  Tom Tromey  <tom@tromey.com>
3795
3796         * tui/tui-regs.h (tui_display_registers_from)
3797         (tui_display_registers_from_line): Don't declare.
3798         * tui/tui-windata.c (tui_data_window::display_all_data)
3799         (tui_data_window::refresh_all)
3800         (tui_data_window::do_scroll_vertical): Update.
3801         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3802         from tui_display_registers_from.
3803         (tui_display_reg_element_at_line): Update.
3804         (tui_data_window::display_registers_from_line): Rename from
3805         tui_display_registers_from_line.
3806         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3807         display_registers_from_line>: New methods.
3808
3809 2019-07-17  Tom Tromey  <tom@tromey.com>
3810
3811         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3812         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3813         from tui_erase_data_content.
3814         (tui_data_window::display_all_data)
3815         (tui_data_window::refresh_all)
3816         (tui_data_window::do_scroll_vertical): Update.
3817         * tui/tui-regs.c (tui_show_registers): Update.
3818         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3819         New method.
3820
3821 2019-07-17  Tom Tromey  <tom@tromey.com>
3822
3823         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3824         declare.
3825         * tui/tui-windata.c
3826         (tui_data_window::delete_data_content_windows): Rename from
3827         tui_delete_data_content_windows.
3828         (tui_data_window::display_all_data)
3829         (tui_data_window::do_scroll_vertical): Update.
3830         * tui/tui-data.h (struct tui_data_window)
3831         <delete_data_content_windows>: New method.
3832
3833 2019-07-17  Tom Tromey  <tom@tromey.com>
3834
3835         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3836         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3837
3838 2019-07-17  Tom Tromey  <tom@tromey.com>
3839
3840         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3841         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3842         from tui_display_all_data.
3843         * tui/tui-win.c
3844         (tui_data_window::do_make_visible_with_new_height): Update.
3845         * tui/tui-regs.c (tui_show_registers): Update.
3846         * tui/tui-layout.c (tui_set_layout): Update.
3847         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3848         method.
3849
3850 2019-07-17  Tom Tromey  <tom@tromey.com>
3851
3852         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3853         * tui/tui-windata.c (tui_display_data_from): Remove.
3854         (tui_data_window::refresh_all): Update.
3855
3856 2019-07-17  Tom Tromey  <tom@tromey.com>
3857
3858         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3859         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3860         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3861         tui_display_registers_from_line.
3862         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3863         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3864         "force_display" parameter.
3865
3866 2019-07-17  Tom Tromey  <tom@tromey.com>
3867
3868         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3869         declare.
3870         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3871         Rename from tui_first_reg_element_no_inline.
3872         (tui_display_reg_element_at_line)
3873         (tui_display_registers_from_line): Update.
3874         * tui/tui-data.h (struct tui_data_window)
3875         <first_reg_element_no_inline>: New method.
3876
3877 2019-07-17  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-windata.c (tui_display_data_from)
3880         (tui_data_window::do_scroll_vertical): Update.
3881         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3882         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3883         Rename from tui_line_from_reg_element_no.
3884         (tui_display_registers_from_line): Update.
3885         * tui/tui-data.h (struct tui_data_window)
3886         <line_from_reg_element_no>: New method.
3887
3888 2019-07-17  Tom Tromey  <tom@tromey.com>
3889
3890         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3891         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3892         tui_last_regs_line_no.
3893         (tui_display_reg_element_at_line)
3894         (tui_display_registers_from_line): Update.
3895         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3896         method.
3897
3898 2019-07-17  Tom Tromey  <tom@tromey.com>
3899
3900         PR tui/24722:
3901         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3902         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3903         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3904         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3905         (tui_update_breakpoint_info): Likewise.
3906         * tui/tui-hooks.c (tui_event_create_breakpoint)
3907         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3908         Update.
3909
3910 2019-07-17  Tom Tromey  <tom@tromey.com>
3911
3912         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3913
3914 2019-07-17  Tom Tromey  <tom@tromey.com>
3915
3916         * tui/tui-winsource.c (tui_update_source_window_as_is)
3917         (tui_update_source_windows_with_addr): Update.
3918         * tui/tui-source.h (tui_set_source_content)
3919         (tui_show_symtab_source): Add "win_info" parameter.
3920         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3921         parameter.
3922         (tui_show_symtab_source): Likewise.
3923
3924 2019-07-17  Tom Tromey  <tom@tromey.com>
3925
3926         * tui/tui-wingeneral.c
3927         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3928
3929 2019-07-17  Tom Tromey  <tom@tromey.com>
3930
3931         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3932         (struct tui_cmd_window) <can_scroll>: New method.
3933         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3934         method.
3935
3936 2019-07-17  Tom Tromey  <tromey@adacore.com>
3937
3938         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3939         do_field_signed>: Rename.  Change type of "value".
3940         * ui-out.c (ui_out::field_signed): Rename from field_int.
3941         Change type of "value".
3942         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3943         type of "value".
3944         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3945         do_field_int.  Change type of "value".
3946         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3947         do_field_int.  Change type of "value".
3948         * tracepoint.c (trace_status_mi, tfind_1)
3949         (print_one_static_tracepoint_marker): Update.
3950         * thread.c (print_thread_info_1, print_selected_thread_frame):
3951         Update.
3952         * stack.c (print_frame, print_frame_info): Update.
3953         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3954         Update.
3955         * source.c (print_source_lines_base): Update.
3956         * skip.c (info_skip_command): Update.
3957         * record-btrace.c (btrace_ui_out_decode_error)
3958         (btrace_call_history_src_line): Update.
3959         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3960         Update.
3961         * progspace.c (print_program_space): Update.
3962         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3963         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3964         do_field_int.  Change type of "value".
3965         * mi/mi-out.c (mi_ui_out::do_table_begin)
3966         (mi_ui_out::do_table_header): Update.
3967         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3968         type of "value".
3969         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3970         (mi_cmd_data_list_changed_registers, output_register)
3971         (mi_cmd_data_read_memory, mi_load_progress)
3972         (mi_cmd_trace_frame_collected): Update.
3973         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3974         Update.
3975         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3976         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3977         (mi_cmd_var_list_children, varobj_update_one): Update.
3978         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3979         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3980         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3981         * inferior.c (print_inferior): Update.
3982         * gdb_bfd.c (print_one_bfd): Update.
3983         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3984         Update.
3985         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3986         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3987         do_field_int.  Change type of "value".
3988         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3989         do_field_int.  Change type of "value".
3990         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3991         (print_one_breakpoint_location, print_it_catch_fork)
3992         (print_one_catch_fork, print_it_catch_vfork)
3993         (print_one_catch_vfork, print_it_catch_solib)
3994         (print_it_catch_exec, print_it_ranged_breakpoint)
3995         (print_mention_watchpoint, print_mention_masked_watchpoint)
3996         (bkpt_print_it, update_static_tracepoint): Update.
3997         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3998         * break-catch-syscall.c (print_it_catch_syscall): Update.
3999         * ada-tasks.c (print_ada_task_info): Update.
4000         * ada-lang.c (print_it_exception, print_mention_exception):
4001         Update.
4002
4003 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4004
4005         PR breakpoints/24541
4006         * gdbarch.c: Regenerate.
4007         * gdbarch.h: Regenerate.
4008         * gdbarch.sh: Adjust return type and parameter types for
4009         'stap_adjust_register'.
4010         (i386_stap_adjust_register): Adjust signature and return new
4011         register name.
4012         * stap-probe.c (stap_parse_register_operand): Adjust use of
4013         'gdbarch_stap_adjust_register'.
4014
4015 2019-07-17  Tom Tromey  <tromey@adacore.com>
4016
4017         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4018         declare VEC.
4019         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4020         std::vector.
4021         (struct s390_process_info): Add initializers.
4022         (s390_add_process): Use new.
4023         (s390_linux_nat_target::low_forget_process): Use delete.
4024         (s390_linux_nat_target::low_new_fork)
4025         (s390_linux_nat_target::stopped_by_watchpoint)
4026         (s390_linux_nat_target::low_prepare_to_resume)
4027         (s390_linux_nat_target::insert_watchpoint)
4028         (s390_linux_nat_target::insert_hw_breakpoint)
4029         (s390_linux_nat_target::remove_watchpoint)
4030         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4031
4032 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4033
4034         * aarch64-fbsd-nat.c: Include regcache.h.
4035         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4036         argument.
4037         (aarch64_fbsd_nat_target::fetch_registers)
4038         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4039         variable.
4040         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4041
4042 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4043
4044         * fbsd-nat.c: Include gdbarch.h.
4045
4046 2019-07-15  Tom Tromey  <tromey@adacore.com>
4047
4048         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4049
4050 2019-07-15  Tom Tromey  <tromey@adacore.com>
4051
4052         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4053         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4054         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4055         * cli-out.c (cli_ui_out::do_field_int): New method.
4056         * ui-out.c (ui_out::field_unsigned): New method.
4057         * symfile.c (generic_load): Use field_unsigned.
4058         (print_transfer_performance): Likewise.
4059         * record-btrace.c (ui_out_field_uint): Remove.
4060         (btrace_call_history_insn_range, btrace_call_history): Use
4061         field_unsigned.
4062         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4063         field_unsigned.
4064         * ui-out.h (class ui_out) <field_unsigned>: New method.
4065         <do_field_unsigned>: Likewise.
4066
4067 2019-07-15  Tom Tromey  <tromey@adacore.com>
4068
4069         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4070         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4071         * target.c (flash_erase_command): Use field_string.
4072         * infrun.c (print_signal_received_reason): Use field_string.
4073         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4074         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4075         field_string.
4076         * ada-tasks.c (print_ada_task_info): Use field_string.
4077
4078 2019-07-15  Tom Tromey  <tromey@adacore.com>
4079
4080         * target.c (flash_erase_command): Use field_core_addr.
4081         * symfile.c (generic_load): Use field_core_addr.
4082         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4083         Use field_core_addr.
4084         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4085         field_core_addr.
4086
4087 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4088
4089         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4090         value if its desired type is smaller than a CORE_ADDR and signed.
4091
4092 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4093
4094         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4095         of changes to field names, and use new is_reference field to
4096         decide if a property is a reference or not.
4097         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4098         field.
4099         (struct dwarf2_property_baton): Update header comment, rename
4100         'referenced_type' to 'property_type' and update comments.
4101         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4102         default property type, store in property baton, update to take
4103         accound of renamed field.
4104         (read_func_scope): Update call to attr_to_dynamic_prop.
4105         (read_array_type): Likewise.
4106         (dwarf2_per_cu_addr_sized_int_type): New function.
4107         (read_subrange_index_type): Move type finding code to
4108         dwarf2_per_cu_addr_sized_int_type.
4109         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4110         (dwarf2_per_cu_addr_type): New function.
4111         (set_die_type): Update calls to attr_to_dynamic_prop.
4112
4113 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * dwarf2read.c (read_subrange_index_type): New function.
4116         (read_subrange_type): Move code into new function and call it.
4117         * gdbtypes.c (create_range_type): Add some asserts.
4118
4119 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4120
4121         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4122         update return statements.
4123         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4124         declaration, and update comment to match.
4125         * gdbtypes.c (resolve_dynamic_array): Update call to
4126         dwarf2_evaluate_property to match new return type.
4127
4128 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4129
4130         * valarith.c (value_subscripted_rvalue): Change lowerbound
4131         parameter type from int to LONGEST.
4132         * value.h (value_subscripted_rvalue): Likewise in declaration.
4133
4134 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4135
4136         * cli/cli-utils.c (info_print_command_completer): New function.
4137         * cli/cli-utils.h: Add 'completer.h' include, and forward
4138         declaration for 'struct cmd_list_element'.
4139         (info_print_command_completer): Declare.
4140         * stack.c (_initialize_stack): Add completer for 'info locals' and
4141         'info args'.
4142         * symtab.c (_initialize_symtab): Add completer for 'info
4143         variables' and 'info functions'.
4144         * NEWS: Mention completion for additional info commands.
4145
4146 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * cli/cli-utils.c (extract_info_print_args): Delete.
4149         (extract_arg_maybe_quoted): Delete.
4150         (info_print_options_defs): New variable.
4151         (make_info_print_options_def_group): New function.
4152         (extract_info_print_options): Define new function.
4153         * cli/cli-utils.h (extract_info_print_args): Delete.
4154         (struct info_print_options): New structure.
4155         (extract_info_print_options): Declare new function.
4156         * stack.c (info_locals_command): Update to use new
4157         extract_info_print_options, also add a header comment.
4158         (info_args_command): Likewise.
4159         * symtab.c (info_variables_command): Likewise.
4160         (info_functions_command): Likewise.
4161
4162 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4163
4164         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4165         to extract string arguments.
4166         * common/common-utils.c (extract_string_maybe_quoted): New function.
4167         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4168
4169 2019-07-11  Tom Tromey  <tromey@adacore.com>
4170
4171         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4172         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4173         * top.h (gdbinit): Don't declare.
4174         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4175         into...
4176         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4177         * top.c (gdb_init): Don't call init_cli_cmds.
4178         (gdbinit): Remove.
4179         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4180
4181 2019-07-11  Tom Tromey  <tromey@adacore.com>
4182
4183         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4184         after it has been moved.
4185
4186 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4187
4188         * valops.c (value_must_coerce_to_target): Change return type to
4189         bool.
4190         * value.h (value_must_coerce_to_target): Likewise.
4191
4192 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4193
4194         * breakpoint.c (is_hardware_watchpoint): Remove
4195         forward-declaration.
4196         (is_masked_watchpoint): Change return type to bool.
4197         (is_tracepoint): Likewise.
4198         (is_breakpoint): Likewise.
4199         (is_hardware_watchpoint): Likewise.
4200         (is_watchpoint): Likewise.
4201         (is_no_memory_software_watchpoint): Likewise.
4202         (is_catchpoint): Likewise.
4203         (breakpoint_1): Make FILTER parameter's return type bool.
4204         is_masked_watchpoint): Change return type to bool.
4205         (save_breakpoints): Make FILTER parameter's return type bool.
4206         * breakpoint.h (is_breakpoint): Change return type to bool.
4207         (is_watchpoint): Likewise.
4208         (is_catchpoint): Likewise.
4209         (is_tracepoint): Likewise.
4210
4211 2019-07-10  Tom Tromey  <tom@tromey.com>
4212
4213         * defs.h: Don't include gdbarch.h.
4214         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4215         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4216         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4217         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4218         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4219         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4220         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4221         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4222         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4223         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4224         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4225         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4226         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4227         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4228         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4229         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4230         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4231         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4232         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4233         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4234         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4235         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4236         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4237         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4238         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4239         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4240         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4241
4242 2019-07-10  Tom Tromey  <tromey@adacore.com>
4243
4244         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4245         * breakpoint.c (init_ada_exception_breakpoint): Register as
4246         bp_catchpoint.
4247         (print_one_breakpoint_location, print_one_breakpoint): Use
4248         is_ada_exception_catchpoint.
4249         * ada-lang.c (class ada_catchpoint_location): Pass
4250         bp_loc_software_breakpoint to bp_location constructor.
4251         (is_ada_exception_catchpoint): New function.
4252
4253 2019-07-10  Tom Tromey  <tromey@adacore.com>
4254
4255         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4256         VEC.
4257         (struct arm_exidx_entry): New method operator<.
4258         (struct arm_exidx_data) <section_maps>: Change type.
4259         (arm_exidx_data_free): Remove.
4260         (arm_exidx_data_key): Change type.  Move lower.
4261         (arm_exidx_new_objfile): Update.
4262         (arm_compare_exidx_entries): Remove.
4263         (arm_find_exidx_entry, _initialize_arm_tdep)
4264
4265 2019-07-10  Tom Tromey  <tromey@adacore.com>
4266
4267         * solib-spu.c (ocl_program_data_key): Change type.
4268         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4269         Update.
4270
4271 2019-07-10  Tom Tromey  <tromey@adacore.com>
4272
4273         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4274         (struct solib_aix_inferior_data) <library_list>: Change type.
4275         (solib_aix_inferior_data_handle): Change type.
4276         (get_solib_aix_inferior_data): Update.
4277         (solib_aix_free_library_list): Remove.
4278         (library_list_start_library): Update.
4279         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4280         return type.
4281         (solib_aix_get_library_list)
4282         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4283         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4284
4285 2019-07-10  Tom Tromey  <tromey@adacore.com>
4286
4287         * solib-dsbt.c (struct dsbt_info): Add initializers.
4288         (solib_dsbt_pspace_data): Change type.
4289         (dsbt_pspace_data_cleanup): Remove.
4290         (get_dsbt_info, _initialize_dsbt_solib): Update.
4291
4292 2019-07-10  Tom Tromey  <tromey@adacore.com>
4293
4294         * spu-tdep.c (spu_overlay_data): Change type.
4295         (spu_get_overlay_table, spu_overlay_new_objfile)
4296         (_initialize_spu_tdep): Update.
4297
4298 2019-07-10  Tom Tromey  <tromey@adacore.com>
4299
4300         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4301         destructor.
4302         (dbx_objfile_data_key): Change type and declare later.
4303         (DBX_SYMFILE_INFO): Rewrite.
4304         * dbxread.c (dbx_objfile_data_key): Change type.
4305         (dbx_symfile_init): Update.
4306         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4307         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4308         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4309
4310 2019-07-10  Tom Tromey  <tromey@adacore.com>
4311
4312         * jit.c (jit_program_space_key): Change type.  Move lower.
4313         (get_jit_program_space_data): Update.
4314         (jit_program_space_data_cleanup): Remove.
4315         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4316         Update.
4317         (struct jit_program_space_data): Add initializers.
4318
4319 2019-07-10  Tom Tromey  <tromey@adacore.com>
4320
4321         * solib-darwin.c (struct darwin_info): Add initializers.
4322         (solib_darwin_pspace_data): Change type.
4323         (darwin_pspace_data_cleanup): Remove.
4324         (get_darwin_info, _initialize_darwin_solib): Update.
4325
4326 2019-07-10  Tom Tromey  <tromey@adacore.com>
4327
4328         * remote-sim.c (struct sim_inferior_data): Add initializers,
4329         constructor, and destructor.
4330         (sim_inferior_data_key): Change type.  Move lower.
4331         (check_for_duplicate_sim_descriptor): Update.
4332         (get_sim_inferior_data): Use new.  Update.
4333         (~sim_inferior_data_cleanup): Rename from
4334         sim_inferior_data_cleanup.  Simplify.
4335         (gdbsim_close_inferior, simulator_command)
4336         (sim_command_completer, _initialize_remote_sim): Update.
4337         (next_pid, INITIAL_PID): Move earlier.
4338
4339 2019-07-10  Tom Tromey  <tromey@adacore.com>
4340
4341         * python/python-internal.h (create_thread_object): Return
4342         gdbpy_ref.
4343         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4344         * python/py-inferior.c (struct threadlist_entry): Add
4345         constructor.
4346         <thread_obj>: Now a gdbpy_ref.
4347         (thread_to_thread_object): Update.
4348         (add_thread_object): Use new.
4349         (delete_thread_object): Use delete.
4350         (infpy_threads): Update.
4351         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4352         GIL.
4353
4354 2019-07-10  Tom Tromey  <tromey@adacore.com>
4355
4356         * valops.c (value_cast): Specialize error message for Ada.
4357
4358 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4359
4360         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4361
4362 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4363
4364         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4365         bpstat_should_step): Return bool, adjust comments.
4366         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4367         bpstat_should_step): Likewise.
4368
4369 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4370
4371         * features/Makefile: Use feature target descriptions for Arm.
4372         * features/arm/arm-core.c: Generate new file.
4373         * features/arm/arm-fpa.c: Likewise.
4374         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4375         * features/arm/arm-m-profile.c: Likewise.
4376         * features/arm/arm-vfpv2.c: Likewise.
4377         * features/arm/arm-vfpv3.c: Likewise.
4378         * features/arm/xscale-iwmmxt.c: Likewise.
4379         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4380
4381 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4382
4383         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4384         ptrace earlier.
4385
4386 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4387
4388         * features/aarch64-pauth.c: Regenerate.
4389
4390 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4391
4392         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4393         bool.
4394         (bpstat_what): Use false instead of 0.
4395
4396 2019-07-09  Pedro Alves  <palves@redhat.com>
4397
4398         * break-catch-throw.c (is_exception_catchpoint): New.
4399         * breakpoint.c (print_one_breakpoint_location): New parameter
4400         'raw_loc'.  Handle it.  Use
4401         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4402         looking at the breakpoint's type.
4403         (print_one_breakpoint): If handling "maint info breakpoints", also
4404         print locations of exception catchpoints.
4405         * breakpoint.h (is_exception_catchpoint): Declare.
4406
4407 2019-07-09  Pedro Alves  <palves@redhat.com>
4408
4409         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4410         "addr" field.
4411         (allocate_location_exception_catchpoint): New.
4412         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4413         (initialize_throw_catchpoint_ops): Install
4414         allocate_location_exception_catchpoint as allocate_location
4415         method.
4416         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4417         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4418         bp_loc_other.
4419         (breakpoint_address_is_meaningful): Delete.
4420         (bl_address_is_meaningful): New.
4421         (breakpoint_locations_match): Adjust comment.
4422         (bp_location_from_bp_type): New, factored out of...
4423         (bp_location::bp_location(breakpoint *)): ... this.
4424         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4425         factored out of...
4426         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4427         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4428         breakpoint_address_is_meaningful.
4429         (bp_locations_compare): Adjust comment.
4430         (update_global_location_list): Use bl_address_is_meaningful
4431         instead of breakpoint_address_is_meaningful.
4432         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4433         explicit.
4434         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4435         * python/py-breakpoint.c (bppy_get_location): No longer check
4436         whether location is null.
4437
4438 2019-07-09  Pedro Alves  <palves@redhat.com>
4439
4440         PR c++/15468
4441         * breakpoint.c (print_one_breakpoint_location): Remove
4442         single-location assert.
4443
4444 2019-07-09  Tom Tromey  <tom@tromey.com>
4445
4446         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4447         * configure: Rebuild.
4448         * configure.ac: Change common to gdbsupport.
4449         * gdbsupport: Rename from common.
4450         * acinclude.m4: Change common to gdbsupport.
4451         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4452         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4453         gdbsupport.
4454         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4455         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4456         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4457         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4458         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4459         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4460         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4461         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4462         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4463         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4464         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4465         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4466         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4467         coff-pe-read.c, command.h, compile/compile-c-support.c,
4468         compile/compile-c.h, compile/compile-cplus-symbols.c,
4469         compile/compile-cplus-types.c, compile/compile-cplus.h,
4470         compile/compile-loc2c.c, compile/compile.c, completer.c,
4471         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4472         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4473         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4474         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4475         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4476         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4477         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4478         features/aarch64-core.c, features/aarch64-fpu.c,
4479         features/aarch64-pauth.c, features/aarch64-sve.c,
4480         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4481         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4482         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4483         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4484         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4485         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4486         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4487         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4488         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4489         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4490         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4491         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4492         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4493         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4494         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4495         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4496         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4497         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4498         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4499         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4500         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4501         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4502         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4503         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4504         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4505         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4506         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4507         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4508         minsyms.c, mips-linux-tdep.c, namespace.h,
4509         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4510         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4511         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4512         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4513         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4514         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4515         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4516         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4517         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4518         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4519         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4520         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4521         procfs.c, producer.c, progspace.h, psymtab.h,
4522         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4523         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4524         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4525         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4526         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4527         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4528         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4529         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4530         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4531         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4532         target-memory.c, target.c, target.h, target/waitstatus.c,
4533         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4534         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4535         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4536         unittests/array-view-selftests.c,
4537         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4538         unittests/common-utils-selftests.c,
4539         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4540         unittests/format_pieces-selftests.c,
4541         unittests/function-view-selftests.c,
4542         unittests/lookup_name_info-selftests.c,
4543         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4544         unittests/mkdir-recursive-selftests.c,
4545         unittests/observable-selftests.c,
4546         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4547         unittests/parse-connection-spec-selftests.c,
4548         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4549         unittests/scoped_fd-selftests.c,
4550         unittests/scoped_mmap-selftests.c,
4551         unittests/scoped_restore-selftests.c,
4552         unittests/string_view-selftests.c, unittests/style-selftests.c,
4553         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4554         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4555         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4556         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4557         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4558         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4559
4560 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4561
4562         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4563         bool value.
4564         (decode_digits_ordinary): Set explicit_line field in sal.
4565         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4566         symtab_and_line that was set on an explicit line number in
4567         assembler code.  Do always update the recorded symtab and line if
4568         we do skip the prologue.
4569
4570 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4571
4572         * breakpoint.c (set_breakpoint_location_function): Remove
4573         explicit_loc parameter.
4574         (momentary_breakpoint_from_master): Update call to
4575         set_breakpoint_location_function.
4576         (add_location_to_breakpoint): Likewise.
4577
4578 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4579
4580         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4581         required features based on default bfd type when no specific bfd
4582         is present.
4583
4584 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4585
4586         * NEWS: Mention that GDB printf and eval commands can now print
4587         C-style and Ada-style convenience var strings without
4588         calling the inferior.
4589         * printcmd.c (printf_c_string): Locally print GDB internal var
4590         instead of transiting via the inferior.
4591         (printf_wide_c_string): Likewise.
4592
4593 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4594
4595         PR breakpoints/25011
4596         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4597
4598 2019-07-04  Tom Tromey  <tom@tromey.com>
4599
4600         PR tui/24724:
4601         * tui/tui-winsource.c (tui_clear_source_content): Update.
4602         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4603         (tui_update_breakpoint_info): Update.
4604         (tui_set_exec_info_content): Update.
4605         * tui/tui-source.c (tui_set_source_content_nil): Update.
4606         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4607         has_break.
4608         * tui/tui-data.h (enum tui_bp_flag): New.
4609         (tui_bp_flags): New enum flags type.
4610         (struct tui_source_element) <break_mode>: Change type.  Rename
4611         from has_break.
4612         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4613         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4614         constants.
4615         * tui/tui-winsource.h: Fix comment.
4616
4617 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4618
4619         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4620         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4621         (store_fpregs_to_thread)
4622         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4623         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4624         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4625         (IWMMXT_REGS_SIZE): Add define.
4626         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4627         (fetch_vfp_regs, store_vfp_regs)
4628         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4629         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4630
4631 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4632
4633         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4634         defines.
4635         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4636         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4637         (ARM_INT_REGISTER_SIZE): ...to this.
4638         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4639         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4640         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4641         (arm_linux_collect_gregset, supply_nwfpe_register)
4642         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4643         defines.
4644         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4645         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4646         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4647         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4648         (arm_return_in_memory, arm_store_return_value)
4649         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4650         (arm_record_ld_st_multiple): Likewise.
4651         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4652         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4653
4654 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4655
4656         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4657         AARCH64_DISPLACED_MODIFIED_INSNS.
4658         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4659         (aarch64_displaced_step_copy_insn): Likewise.
4660         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4661         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4662         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4663         ARM_DISPLACED_MODIFIED_INSNS.
4664         * arm-tdep.c (arm_gdbarch_init): Likewise.
4665         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4666         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4667         (struct arm_displaced_step_closure): Use
4668         ARM_DISPLACED_MODIFIED_INSNS.
4669
4670 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4671
4672         * features/Makefile: Remove unused xml files.
4673         * features/aarch64.xml: Remove.
4674         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4675         * features/i386/amd64-avx-avx512.xml: Remove.
4676         * features/i386/amd64-avx-linux.xml: Remove.
4677         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4678         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4679         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4680         * features/i386/amd64-avx-mpx.xml: Remove.
4681         * features/i386/amd64-avx.xml: Remove.
4682         * features/i386/amd64-linux.xml: Remove.
4683         * features/i386/amd64-mpx-linux.xml: Remove.
4684         * features/i386/amd64-mpx.xml: Remove.
4685         * features/i386/amd64.xml: Remove.
4686         * features/i386/i386-avx-avx512-linux.xml: Remove.
4687         * features/i386/i386-avx-avx512.xml: Remove.
4688         * features/i386/i386-avx-linux.xml: Remove.
4689         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4690         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4691         * features/i386/i386-avx-mpx-linux.xml: Remove.
4692         * features/i386/i386-avx-mpx.xml: Remove.
4693         * features/i386/i386-avx.xml: Remove.
4694         * features/i386/i386-linux.xml: Remove.
4695         * features/i386/i386-mmx-linux.xml: Remove.
4696         * features/i386/i386-mmx.xml: Remove.
4697         * features/i386/i386-mpx-linux.xml: Remove.
4698         * features/i386/i386-mpx.xml: Remove.
4699         * features/i386/i386.xml: Remove.
4700         * features/i386/x32-avx-avx512-linux.xml: Remove.
4701         * features/i386/x32-avx-linux.xml: Remove.
4702         * features/i386/x32-linux.xml: Remove.
4703
4704 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4705
4706         * regformats/aarch64.dat: Remove.
4707         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4708         * regformats/i386/amd64-avx-linux.dat: Remove.
4709         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4710         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4711         * regformats/i386/amd64-linux.dat: Remove.
4712         * regformats/i386/amd64-mpx-linux.dat: Remove.
4713         * regformats/i386/amd64.dat: Remove.
4714         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4715         * regformats/i386/i386-avx-linux.dat: Remove.
4716         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4717         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4718         * regformats/i386/i386-linux.dat: Remove.
4719         * regformats/i386/i386-mmx-linux.dat: Remove.
4720         * regformats/i386/i386-mpx-linux.dat: Remove.
4721         * regformats/i386/i386.dat: Remove.
4722         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4723         * regformats/i386/x32-avx-linux.dat: Remove.
4724         * regformats/i386/x32-linux.dat: Remove.
4725
4726 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4727
4728         * aarch64-tdep.c: Remove xml self tests.
4729         * amd64-linux-tdep.c: Likewise.
4730         * amd64-tdep.c: Likewise.
4731         * i386-linux-tdep.c: Likewise.
4732         * i386-tdep.c: Likewise.
4733
4734 2019-07-03  Pedro Alves  <palves@redhat.com>
4735
4736         PR cli/24732
4737         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4738         (pipe_cmd_option_defs): New.
4739         (make_pipe_cmd_options_def_group): New.
4740         (pipe_command): Use gdb::option::process_options.
4741         (pipe_command_completer): New function.
4742         (_initialize_cli_cmds): Install completer for "pipe" command.
4743
4744 2019-07-03  Pedro Alves  <palves@redhat.com>
4745
4746         * cli/cli-option.c (union option_value) <string>: New field.
4747         (struct option_def_and_value): Add ctor, move ctor, dtor and
4748         use DISABLE_COPY_AND_ASSIGN.
4749         (option_def_and_value::clear_value): New.
4750         (parse_option, save_option_value_in_ctx, get_val_type_str)
4751         (add_setshow_cmds_for_options): Handle var_string.
4752         * cli-option.h (union option_def::var_address) <string>: New
4753         field.
4754         (struct string_option_def): New.
4755         * maint-test-options.c (struct test_options_opts): Add default
4756         ctor and use DISABLE_COPY_AND_ASSIGN.
4757         <string_opt>: New field.
4758         (test_options_opts::~test_options_opts): New.
4759         (test_options_opts::dump): Also dump "-string".
4760         (test_options_option_defs): Install "string.
4761
4762 2019-07-03  Pedro Alves  <palves@redhat.com>
4763
4764         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4765         option_value with a null enumeration.
4766         (complete_options): Save the option values in the context.
4767         (save_option_value_in_ctx): New, factored out from ...
4768         (process_options): ... here.
4769         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4770         of the function.
4771         * maint-test-options.c (test_options_opts::dump): New, factored
4772         out from ...
4773         (maintenance_test_options_command_mode): ... here.
4774         (maintenance_test_options_command_completion_result): Delete.
4775         (maintenance_test_options_command_completion_text): Update
4776         comment.
4777         (maintenance_show_test_options_completion_result): Change
4778         prototype.  Just print
4779         maintenance_test_options_command_completion_text.
4780         (save_completion_result): New.
4781         (maintenance_test_options_completer_mode): Pass options context to
4782         complete_options, and then save a dump.
4783         (_initialize_maint_test_options): Use add_cmd to install "maint
4784         show test-options-completion-result".
4785
4786 2019-07-03  Pedro Alves  <palves@redhat.com>
4787
4788         * NEWS (New commands): Mention "with" and "maint with".
4789         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4790         (with_command, with_command_completer): New.
4791         (pipe_command): Adjust to new repeat_previous
4792         interface.
4793         (_initialize_cli_cmds): Install the "with" command and its "w"
4794         alias.
4795         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4796         declarations.
4797         * cli/cli-setshow.c (parse_cli_var_uinteger)
4798         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4799         argument strings for all var_types.
4800         (get_setshow_command_value_string): New, factored out from ...
4801         (do_show_command): ... this.
4802         * cli/cli-setshow.h: Include <string>.
4803         (get_setshow_command_value_string): Declare.
4804         * command.h (repeat_previous): Now returns const char *.  Adjust
4805         comment.
4806         * maint.c: Include "cli/cli-cmds.h".
4807         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4808         (_initialize_maint_cmds): Register the "maintenance with" command.
4809         * top.c (repeat_previous): Move bits from pipe_command here:
4810         Return the saved command line, if any; error out if there's no
4811         command to relaunch.
4812
4813 2019-07-03  Pedro Alves  <palves@redhat.com>
4814
4815         * NEWS (New commands): Mention "maint set/show test-settings"
4816         instead of "maint test-settings".
4817         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4818         (maintenance_test_settings_set_list): Rename to ...
4819         (maintenance_set_test_settings_list): ... this.
4820         (maintenance_test_settings_show_list): Rename to  ...
4821         (maintenance_show_test_settings_list): ... this.
4822         (maintenance_test_settings_cmd): Delete.
4823         (maintenance_test_settings_set_cmd): ...
4824         (maintenance_set_test_settings_cmd): ... this.
4825         (maintenance_test_settings_show_cmd): ...
4826         (maintenance_show_test_settings_cmd): ... this.
4827         (maintenance_test_settings_show_value_cmd):
4828         (maintenance_show_test_settings_value_cmd): ... this.
4829         (_initialize_maint_test_settings): No longer install the "maint
4830         test-settings" prefix command.  Rename "maint test-settings set"
4831         to "maint set test-settings", and "maint test-settings show" to
4832         "maint show test-settings".  Adjust all subcommands.
4833
4834 2019-07-03  Pedro Alves  <palves@redhat.com>
4835
4836         * maint-test-settings.c: Fix file's intro comment.  Replace all
4837         references to "test-options" with references to "test-settings",
4838         in comments.
4839
4840 2019-07-03  Pedro Alves  <palves@redhat.com>
4841
4842         * maint-test-settings.c (maintenance_test_settings_xxx)
4843         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4844         New.
4845         (maintenance_test_settings_enums): Use them.
4846         (maintenance_test_settings_enum): Default to
4847         maintenance_test_settings_xxx.
4848         (_initialize_maint_test_settings): Initialize
4849         MAINTENANCE_TEST_SETTINGS_FILENAME.
4850
4851 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4852
4853         * breakpoint.h (remove_breakpoints_inf): Change return type to
4854         void, move function documentation here.
4855         * breakpoint.c (remove_breakpoints_inf): Change return type to
4856         void, move function documentation to header.
4857
4858 2019-07-02  Pedro Alves  <palves@redhat.com>
4859
4860         * NEWS (Completion improvements): Mention "info threads".
4861         * thread.c (struct info_threads_opts, info_threads_option_defs)
4862         (make_info_threads_options_def_group): New.
4863         (info_threads_command): Use gdb::option::process_options.
4864         (info_threads_command_completer): New.
4865         (_initialize_thread): Use gdb::option::build_help to build the
4866         help text for "info threads".
4867
4868 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4869
4870         * defs.h (generic_load): Move from here...
4871         * symfile.h (generic_load): ... to here.  Rename name parameter
4872         to args.
4873         * symfile.c (generic_load): Add comment.
4874
4875 2019-07-01  Tom Tromey  <tromey@adacore.com>
4876
4877         * dwarf2read.c
4878         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4879         declaration of without_params.  Fix formatting.
4880
4881 2019-07-01  Tom Tromey  <tromey@adacore.com>
4882
4883         * ada-exp.y (find_primitive_type): Update.
4884         * ada-lang.h (ada_lookup_symbol): Update.
4885         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4886         parameter.
4887         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4888
4889 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4890
4891         PR breakpoints/24541
4892         * gdbarch.c: Regenerate.
4893         * gdbarch.h: Regenerate.
4894         * gdbarch.sh: Add 'stap_adjust_register'.
4895         * i386-tdep.c: Include '<unordered_set>'.
4896         (i386_stap_adjust_register): New function.
4897         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4898         * stap-probe.c (stap_parse_register_operand): Call
4899         'gdbarch_stap_adjust_register'.
4900
4901 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4902
4903         PR python/24742
4904         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4905         * python/python.c (do_start_initialization): Use 'xmalloc'
4906         instead of 'PyMem_Malloc'.
4907
4908 2019-06-28  Tom Tromey  <tromey@adacore.com>
4909
4910         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4911         for Ada.
4912
4913 2019-06-27  Tom Tromey  <tromey@adacore.com>
4914
4915         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4916         objfile_key.
4917         (arm_find_mapping_symbol, arm_record_special_symbol)
4918         (_initialize_arm_tdep): Update.
4919         (arm_objfile_data_free): Remove.
4920
4921 2019-06-27  Tom Tromey  <tromey@adacore.com>
4922
4923         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4924         to cp_print_static_field.
4925
4926 2019-06-26  Tom Tromey  <tromey@adacore.com>
4927
4928         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4929         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4930         declare.
4931
4932 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4933
4934         * features/aarch64-core.c (create_feature_aarch64_core):
4935         Regenerate.
4936         * features/aarch64-core.xml: Add cpsr flags.
4937
4938 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4939
4940         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4941         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4942
4943 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4944
4945         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4946         field.
4947         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4948         use.
4949         (arm_record_special_symbol): Don't insert new symbol in sorted
4950         position, push it at the end.
4951
4952 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4953
4954         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4955         (arm_mapping_symbol_s): Remove.
4956         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4957         (arm_mapping_symbol_vec): New typedef.
4958         (struct arm_per_objfile): Add constructor.
4959         <section_maps>: Change type to
4960         std::unique_ptr<arm_mapping_symbol_vec[]>.
4961         (arm_compare_mapping_symbols): Remove.
4962         (arm_find_mapping_symbol): Adjust to section_maps type change.
4963         (arm_objfile_data_free): Call delete on arm_per_objfile.
4964         (arm_record_special_symbol): Adjust to section_maps type change.
4965         Allocate arm_per_objfile with new.
4966
4967 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4968
4969         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4970         with the command prefix.
4971
4972 2019-06-25  Tom Tromey  <tom@tromey.com>
4973
4974         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4975         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4976
4977 2019-06-25  Tom Tromey  <tom@tromey.com>
4978
4979         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4980         type.
4981         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4982         protected.
4983
4984 2019-06-25  Tom Tromey  <tom@tromey.com>
4985
4986         * tui/tui-winsource.c
4987         (tui_source_window_base::set_is_exec_point_at): Add check against
4988         LOA_ADDRESS.
4989
4990 2019-06-25  Tom Tromey  <tom@tromey.com>
4991
4992         * tui/tui-source.c (tui_set_source_content): Don't check before
4993         xfree.
4994         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4995
4996 2019-06-25  Tom Tromey  <tom@tromey.com>
4997
4998         * tui/tui-winsource.h (tui_update_source_window_as_is)
4999         (tui_alloc_source_buffer, tui_line_is_displayed)
5000         (tui_addr_is_displayed): Change type of win_info.
5001         * tui/tui-winsource.c (tui_update_source_window_as_is)
5002         (tui_clear_source_content, tui_show_source_line)
5003         (tui_show_source_content, tui_source_window_base::refill)
5004         (tui_source_window_base::set_is_exec_point_at)
5005         (tui_source_window_base::set_is_exec_point_at)
5006         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5007         (tui_alloc_source_buffer, tui_line_is_displayed)
5008         (tui_addr_is_displayed): Change type of win_info.  Update.
5009         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5010         (tui_source_window_base::do_make_visible_with_new_height):
5011         Update.
5012         * tui/tui-source.c (tui_set_source_content)
5013         (tui_set_source_content_nil)
5014         (tui_source_window::do_scroll_vertical): Update.
5015         * tui/tui-layout.c (show_layout): Update.
5016         * tui/tui-disasm.c (tui_set_disassem_content)
5017         (tui_disasm_window::do_scroll_vertical): Update.
5018         * tui/tui-data.h (tui_win_content): Remove.
5019         (struct tui_gen_win_info) <content, content_size>: Remove.
5020         (struct tui_source_element): Add initializers and destructor.
5021         (union tui_which_element, struct tui_win_element): Remove.
5022         (struct tui_source_window_base) <content>: New field.
5023         (struct tui_data_window): Remove destructor.
5024         (tui_alloc_content, tui_free_win_content)
5025         (tui_free_all_source_wins_content): Don't declare.
5026         * tui/tui-data.c (tui_initialize_static_data): Update.
5027         (init_content_element, tui_alloc_content): Remove.
5028         (~tui_gen_win_info): Update.
5029         (~tui_data_window, tui_free_all_source_wins_content)
5030         (tui_free_win_content, free_content, free_content_elements):
5031         Remove.
5032
5033 2019-06-25  Tom Tromey  <tom@tromey.com>
5034
5035         * tui/tui-winsource.h (tui_clear_source_content)
5036         (tui_erase_source_content, tui_show_source_content): Change type
5037         of win_info.
5038         * tui/tui-winsource.c (tui_clear_source_content)
5039         (tui_erase_source_content, tui_show_source_content): Change type
5040         of win_info.
5041         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5042         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5043         win_info.
5044         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5045         win_info.
5046         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5047
5048 2019-06-25  Tom Tromey  <tom@tromey.com>
5049
5050         * tui/tui-winsource.c (tui_clear_source_content)
5051         (tui_source_window_base::set_is_exec_point_at): Update.
5052         * tui/tui-source.c (tui_set_source_content_nil): Update.
5053         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5054         a bool.
5055         * tui/tui-data.c (init_content_element): Update.
5056
5057 2019-06-25  Tom Tromey  <tom@tromey.com>
5058
5059         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5060         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5061         * tui/tui-layout.c (init_and_make_win): Update.
5062         * tui/tui.h (enum tui_win_type): Update.
5063         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5064         tui_win_is_auxillary.
5065         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5066         tui_win_is_auxillary.
5067
5068 2019-06-25  Tom Tromey  <tom@tromey.com>
5069
5070         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5071         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5072         (tui_delete_data_content_windows, tui_display_all_data)
5073         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5074         Update.
5075         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5076         * tui/tui-regs.c (tui_last_regs_line_no)
5077         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5078         (tui_show_registers): Update.
5079         (tui_show_register_group): Return void.  Update.
5080         (tui_display_registers_from, tui_display_reg_element_at_line)
5081         (tui_display_registers_from_line, tui_check_register_values):
5082         Update.
5083         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5084         member.
5085         (struct tui_data_window) <regs_content>: Now a std::vector.
5086         <regs_content_count>: Remove.
5087         (tui_add_content_elements, tui_free_data_content): Don't declare.
5088         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5089         (init_content_element): Remove DATA_WIN case.  Add assert.
5090         (tui_add_content_elements): Remove.
5091         (tui_data_window): Update.
5092         (tui_free_data_content): Remove.
5093         (free_content_elements): Remove DATA_WIN case.
5094
5095 2019-06-25  Tom Tromey  <tom@tromey.com>
5096
5097         * tui/tui-data.c (tui_data_item_window): Update.
5098         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5099         * tui/tui-windata.c (tui_display_all_data)
5100         (tui_display_data_from_line): Update.
5101         (tui_check_data_values): Remove.
5102         * tui/tui-regs.c (tui_show_register_group)
5103         (tui_display_reg_element_at_line): Update.
5104         * tui/tui-hooks.c (tui_register_changed)
5105         (tui_refresh_frame_and_register_information): Call
5106         tui_check_register_values.
5107         * tui/tui-data.h (struct tui_data_window) <data_content,
5108         data_content_count, data_type>: Remove.
5109         (enum tui_data_type): Remove.
5110
5111         * tui/tui-data.c (tui_data_window::clear_detail)
5112         (~tui_data_window): Update.
5113
5114 2019-06-25  Tom Tromey  <tom@tromey.com>
5115
5116         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5117         declare.
5118         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5119         Rename from tui_first_data_item_displayed.  Update.
5120         (tui_data_window::refresh_all)
5121         (tui_data_window::do_scroll_vertical): Update.
5122         * tui/tui-data.h (struct tui_data_window)
5123         <first_data_item_displayed>: Declare new method.
5124
5125 2019-06-25  Tom Tromey  <tom@tromey.com>
5126
5127         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5128         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5129         contents...
5130         (tui_initialize_static_data): ...here.
5131
5132 2019-06-25  Tom Tromey  <tom@tromey.com>
5133
5134         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5135         (tui_display_registers_from, tui_check_register_values): Update.
5136         (tui_display_register): Remove win_info parameter; update.
5137         (tui_get_register): Change type of parameters.
5138         * tui/tui-data.h (struct tui_data_element): Remove.
5139         (union tui_which_element) <data>: Remove.
5140         <data_window>: Change type.
5141         (struct tui_data_item_window): New.
5142         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5143         case.  Add assert.
5144         (~tui_data_item_window): New destructor.
5145         (free_content_elements): Remove DATA_ITEM_WIN case.
5146
5147 2019-06-25  Tom Tromey  <tom@tromey.com>
5148
5149         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5150         Remove.
5151
5152 2019-06-25  Tom Tromey  <tom@tromey.com>
5153
5154         * tui/tui-data.h (struct tui_command_element): Remove.
5155         (union tui_which_element) <command>: Remove.
5156         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5157         assert.
5158         (free_content_elements): Remove CMD_WIN case.
5159
5160 2019-06-25  Tom Tromey  <tom@tromey.com>
5161
5162         * tui/tui-layout.c (tui_set_layout): Update.
5163         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5164         * tui/tui-data.c (layout_def): Update.
5165
5166 2019-06-25  Tom Tromey  <tom@tromey.com>
5167
5168         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5169         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5170         (tui_source_window_base::set_new_height): Update.
5171         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5172         Update.
5173         (tui_set_locator_fullname, tui_set_locator_info)
5174         (tui_show_frame_info): Update.
5175         * tui/tui-source.c (tui_set_source_content)
5176         (tui_source_is_displayed): Update.
5177         * tui/tui-layout.c (show_source_disasm_command, show_data)
5178         (show_source_or_disasm_and_command): Update.
5179         * tui/tui-disasm.c (tui_set_disassem_content)
5180         (tui_get_begin_asm_address): Update.
5181         * tui/tui-data.h (struct tui_locator_element): Remove.
5182         (union tui_which_element) <locator>: Remove.
5183         (struct tui_locator_window): New.
5184         (tui_locator_win_info_ptr): Change return type.
5185         * tui/tui-data.c (_locator): Change type.
5186         (tui_locator_win_info_ptr): Change return type.
5187         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5188         (tui_alloc_content): Add assert.
5189
5190 2019-06-25  Tom Tromey  <tom@tromey.com>
5191
5192         * tui/tui-winsource.c
5193         (tui_exec_info_window::maybe_allocate_content): New method.
5194         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5195         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5196         (make_source_or_disasm_window): Add cast.
5197         * tui/tui-data.h (union tui_which_element) <simple_string>:
5198         Remove.
5199         (struct tui_source_info): New.
5200         (struct tui_source_window_base) <execution_info>: Change type.
5201         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5202         case, and add assert.
5203         (tui_alloc_content): Add assert.
5204
5205 2019-06-25  Tom Tromey  <tom@tromey.com>
5206
5207         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5208         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5209         * tui/tui-data.c (tui_alloc_win_info): Remove.
5210
5211 2019-06-25  Tom Tromey  <tom@tromey.com>
5212
5213         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5214         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5215         can_highlight.
5216
5217 2019-06-25  Tom Tromey  <tom@tromey.com>
5218
5219         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5220         make_visible_with_new_height method.
5221         (tui_win_info::make_visible_with_new_height): New method.
5222         (tui_source_window_base::do_make_visible_with_new_height)
5223         (tui_data_window::do_make_visible_with_new_height)
5224         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5225         (make_visible_with_new_height): Remove.
5226         (tui_resize_all, tui_adjust_win_heights): Use
5227         make_visible_with_new_height method.
5228         * tui/tui-data.h (struct tui_win_info)
5229         <do_make_visible_with_new_height, make_visible_with_new_height>:
5230         New methods.
5231         (struct tui_source_window_base, struct tui_data_window)
5232         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5233         methods.
5234
5235 2019-06-25  Tom Tromey  <tom@tromey.com>
5236
5237         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5238         method.
5239         (update_tab_width): Call update_tab_width method.
5240         * tui/tui-data.h (struct tui_win_info)
5241         (struct tui_source_window_base) <update_tab_width>: New methods.
5242
5243 2019-06-25  Tom Tromey  <tom@tromey.com>
5244
5245         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5246         parameter.
5247         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5248         parameter.
5249         (tui_gen_win_info::make_visible): Update.
5250         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5251         parameter.
5252         * tui/tui-data.h (enum tui_box): New enum.
5253         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5254
5255 2019-06-25  Tom Tromey  <tom@tromey.com>
5256
5257         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5258         init_and_make_win for EXEC_INFO_WIN.
5259         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5260         longer inline.
5261         (struct tui_win_info) <~tui_win_info>: Inline.
5262         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5263         Don't declare.
5264         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5265         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5266         Remove.
5267         (tui_initialize_static_data): Update.
5268         (~tui_gen_win_info): Handle more cleanup here.
5269         (~tui_source_window_base): Delete "execution_info".
5270         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5271
5272 2019-06-25  Tom Tromey  <tom@tromey.com>
5273
5274         * tui/tui-layout.c (make_command_window): Don't set
5275         can_highlight.
5276         (show_source_disasm_command): Call the reset method.
5277         (show_data): Don't set can_highlight.  Call the reset method.
5278         (tui_gen_win_info::reset): Rename from init_gen_win_info
5279         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5280         (show_source_or_disasm_and_command): Call the reset method.
5281         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5282         (struct tui_cmd_window): Set can_highlight.
5283
5284 2019-06-25  Tom Tromey  <tom@tromey.com>
5285
5286         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5287         from make_visible.
5288         (tui_make_visible, tui_make_invisible): Rewrite.
5289         (tui_win_info::make_visible): Remove.
5290         (tui_source_window_base::make_visible): Update.
5291         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5292         method.  Moved from...
5293         (struct tui_win_info) <make_visible>: ...here.
5294
5295 2019-06-25  Tom Tromey  <tom@tromey.com>
5296
5297         * tui/tui-winsource.c
5298         (tui_source_window_base::do_scroll_horizontal): Remove direction
5299         parameter.
5300         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5301         direction parameter.
5302         * tui/tui-win.c (tui_win_info::forward_scroll)
5303         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5304         (tui_win_info::right_scroll): Update.
5305         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5306         direction parameter.
5307         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5308         direction parameter.
5309         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5310         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5311         Remove direction parameter.
5312         (struct tui_source_window_base, struct tui_source_window)
5313         (struct tui_disasm_window, struct tui_data_window)
5314         (struct tui_cmd_window): Update.
5315
5316 2019-06-25  Tom Tromey  <tom@tromey.com>
5317
5318         * tui/tui-winsource.h (tui_set_exec_info_content)
5319         (tui_show_exec_info_content, tui_erase_exec_info_content)
5320         (tui_clear_exec_info_content, tui_update_exec_info): Change
5321         argument to tui_source_window_base.
5322         * tui/tui-winsource.c (tui_set_exec_info_content)
5323         (tui_show_exec_info_content, tui_erase_exec_info_content)
5324         (tui_clear_exec_info_content, tui_update_exec_info): Change
5325         argument to tui_source_window_base.
5326
5327 2019-06-25  Tom Tromey  <tom@tromey.com>
5328
5329         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5330         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5331
5332 2019-06-25  Tom Tromey  <tom@tromey.com>
5333
5334         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5335         check.
5336
5337 2019-06-25  Tom Tromey  <tom@tromey.com>
5338
5339         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5340         type to void.
5341         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5342         type to void.
5343         * tui/tui-source.c (tui_set_source_content): Update.
5344         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5345
5346 2019-06-25  Tom Tromey  <tom@tromey.com>
5347
5348         * tui/tui-win.c (window_name_completer, tui_set_focus)
5349         (tui_all_windows_info): Use name method.
5350         * tui/tui-data.h (struct tui_gen_win_info)
5351         (struct tui_source_window, struct tui_disasm_window)
5352         (struct tui_data_window, struct tui_cmd_window) <name>: New
5353         method.
5354         (tui_win_name): Don't declare.
5355         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5356         (tui_win_name): Remove.
5357
5358 2019-06-25  Tom Tromey  <tom@tromey.com>
5359
5360         * tui/tui-winsource.h (tui_update_source_window)
5361         (tui_update_source_window_as_is): Change parameter type.
5362         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5363         to be a tui_source_window_base.
5364         (tui_update_source_window_as_is): Likewise.
5365         * tui/tui-win.c (make_visible_with_new_height): Update.
5366
5367 2019-06-25  Tom Tromey  <tom@tromey.com>
5368
5369         * tui/tui-winsource.c (tui_erase_source_content)
5370         (tui_show_source_content, tui_show_exec_info_content)
5371         (tui_erase_exec_info_content): Use refresh_window method.
5372         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5373         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5374         from tui_refresh_win.
5375         (tui_data_window::refresh_window): New method.
5376         (tui_win_info::refresh, tui_source_window_base::refresh)
5377         (tui_refresh_all): Use refresh_window method.
5378         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5379         method.
5380         * tui/tui-regs.c (tui_display_register): Call refresh_window
5381         method.
5382         * tui/tui-layout.c (show_source_disasm_command)
5383         (show_source_or_disasm_and_command): Call refresh_window method.
5384         * tui/tui-data.h (struct tui_gen_win_info)
5385         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5386         New method.
5387
5388 2019-06-25  Tom Tromey  <tom@tromey.com>
5389
5390         * tui/tui.c (tui_rl_other_window, tui_enable)
5391         (tui_is_window_visible, tui_get_command_dimension): Update.
5392         * tui/tui-winsource.c (tui_update_source_window_as_is)
5393         (tui_clear_source_content, tui_erase_source_content)
5394         (tui_show_source_line, tui_source_window_base::refill)
5395         (tui_source_window_base::do_scroll_horizontal)
5396         (tui_source_window_base::set_is_exec_point_at)
5397         (tui_update_breakpoint_info, tui_set_exec_info_content)
5398         (tui_alloc_source_buffer, tui_line_is_displayed)
5399         (tui_addr_is_displayed): Update.
5400         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5401         (tui_check_and_display_highlight_if_needed)
5402         (tui_win_info::make_visible, tui_win_info::refresh)
5403         (tui_refresh_all): Update.
5404         * tui/tui-windata.c (tui_first_data_item_displayed)
5405         (tui_delete_data_content_windows, tui_erase_data_content)
5406         (tui_display_all_data, tui_data_window::refresh_all)
5407         (tui_check_data_values): Update.
5408         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5409         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5410         (tui_win_info::backward_scroll, tui_refresh_all_win)
5411         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5412         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5413         (tui_source_window_base::set_new_height)
5414         (tui_data_window::set_new_height)
5415         (make_invisible_and_set_new_height)
5416         (make_visible_with_new_height, new_height_ok)
5417         (parse_scrolling_args): Update.
5418         * tui/tui-stack.c (tui_show_frame_info): Update.
5419         * tui/tui-source.c (tui_set_source_content)
5420         (tui_set_source_content_nil, tui_source_is_displayed)
5421         (tui_source_window::do_scroll_vertical): Update.
5422         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5423         (tui_display_registers_from, tui_display_reg_element_at_line)
5424         (tui_check_register_values, tui_reg_command): Update.
5425         * tui/tui-layout.c (tui_default_win_height)
5426         (show_source_disasm_command, show_data, init_and_make_win)
5427         (show_source_or_disasm_and_command): Update.
5428         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5429         (tui_redisplay_readline, tui_mld_flush)
5430         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5431         (tui_getc): Update.
5432         * tui/tui-disasm.c (tui_set_disassem_content)
5433         (tui_disasm_window::do_scroll_vertical): Update.
5434         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5435         Now virtual.
5436         (struct tui_win_info): Derive from tui_gen_win_info.
5437         <~tui_win_info>: Mark as override.
5438         <generic>: Remove member.
5439         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5440         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5441         (~tui_data_window, ~tui_win_info)
5442         (tui_free_all_source_wins_content): Update.
5443         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5444
5445 2019-06-25  Tom Tromey  <tom@tromey.com>
5446
5447         * tui/tui-layout.c (init_and_make_win): Use new.
5448         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5449         destructor, initializers.
5450         (tui_alloc_generic_win_info): Don't declare.
5451         * tui/tui-data.c (_locator): Add argument to constructor.
5452         (source_win, disasm_win): New globals.
5453         (exec_info): Remove.
5454         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5455         Update.
5456         (tui_alloc_generic_win_info): Remove.
5457         (init_content_element): Use new.
5458         (tui_win_info::tui_win_info): Update.
5459         (free_content_elements) <case DATA_WIN>: Use delete.
5460
5461 2019-06-25  Tom Tromey  <tom@tromey.com>
5462
5463         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5464         * tui/tui-windata.c (tui_first_data_item_displayed)
5465         (tui_delete_data_content_windows): Update.
5466         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5467         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5468         (tui_display_registers_from, tui_check_register_values): Update.
5469         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5470         pointer.
5471         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5472         window.
5473         (tui_free_data_content): Update.
5474         (free_content_elements) <case DATA_WIN>: Free the window.
5475
5476 2019-06-25  Tom Tromey  <tom@tromey.com>
5477
5478         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5479         Update.
5480         * tui/tui-layout.c (make_command_window)
5481         (show_source_disasm_command, show_data, init_and_make_win)
5482         (show_source_or_disasm_and_command): Update.
5483         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5484         method.
5485         <can_highight, is_highlighted>: Now bool.
5486         (tui_set_win_highlight): Don't declare.
5487         * tui/tui-data.c (tui_set_win_highlight): Remove.
5488
5489 2019-06-25  Tom Tromey  <tom@tromey.com>
5490
5491         * tui/tui-wingeneral.c (make_visible): Remove check of window
5492         type.
5493
5494 2019-06-25  Tom Tromey  <tom@tromey.com>
5495
5496         * tui/tui-win.c (tui_win_info::max_height)
5497         (tui_cmd_window::max_height): New methods.
5498         (new_height_ok): Call max_height.
5499         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5500         <max_height>: New method.
5501
5502 2019-06-25  Tom Tromey  <tom@tromey.com>
5503
5504         * tui/tui-win.c (tui_source_window_base::set_new_height)
5505         (tui_data_window::set_new_height): New methods.
5506         (make_invisible_and_set_new_height): Call set_new_height method.
5507         * tui/tui-data.h (struct tui_win_info)
5508         (struct tui_source_window_base, struct tui_data_window)
5509         <set_new_height>: New method.
5510
5511 2019-06-25  Tom Tromey  <tom@tromey.com>
5512
5513         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5514         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5515         tui_refresh_data_win.
5516         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5517         method.
5518         (tui_refresh_all_win): Call the refresh_all method.
5519         (tui_set_focus): Likewise.
5520         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5521         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5522         Likewise.
5523
5524 2019-06-25  Tom Tromey  <tom@tromey.com>
5525
5526         * tui/tui-winsource.h (tui_refill_source_window)
5527         (tui_set_is_exec_point_at): Don't declare.
5528         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5529         (tui_source_window_base::refill): Rename from
5530         tui_refill_source_window.
5531         (tui_source_window_base::do_scroll_horizontal): Update.
5532         (tui_source_window_base::set_is_exec_point_at): Rename from
5533         tui_set_is_exec_point_at.
5534         (tui_update_all_breakpoint_info): Update.
5535         * tui/tui-stack.c (tui_show_frame_info): Update.
5536         * tui/tui-layout.c (show_data): Add cast.
5537         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5538         * tui/tui-data.h (struct tui_source_window_base) <refill,
5539         set_is_exec_point_at>: New methods.
5540         (tui_source_windows, tui_add_to_source_windows): Update types.
5541         (tui_add_to_source_windows): Remove redundant declaration.
5542         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5543         (tui_source_windows): Change return type.
5544         (tui_clear_source_windows_detail): Update.
5545         (tui_add_to_source_windows): Change type of parameter.
5546         (tui_free_all_source_wins_content): Update.
5547
5548 2019-06-25  Tom Tromey  <tom@tromey.com>
5549
5550         * tui/tui-wingeneral.c (tui_win_info::refresh)
5551         (tui_source_window_base::refresh): New methods.
5552         (tui_refresh_all): Call the refresh method.
5553         * tui/tui-data.h (struct tui_win_info)
5554         (struct tui_source_window_base) <refresh>: New method.
5555
5556 2019-06-25  Tom Tromey  <tom@tromey.com>
5557
5558         * tui/tui.h (tui_is_window_visible): Return bool.
5559         * tui/tui.c (tui_is_window_visible): Return bool.
5560         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5561         (tui_make_visible, tui_make_invisible)
5562         (tui_win_info::make_visible)
5563         (tui_source_window_base::make_visible, make_all_visible)
5564         (tui_make_all_visible, tui_make_all_invisible): Update.
5565         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5566         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5567         bool.
5568         (struct tui_win_info, struct tui_source_window_base)
5569         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5570         * tui/tui-data.c (tui_init_generic_part): Update.
5571
5572 2019-06-25  Tom Tromey  <tom@tromey.com>
5573
5574         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5575         (tui_source_window_base::make_visible): New methods.
5576         (make_all_visible): Make method call.
5577         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5578         (struct tui_source_window_base, struct tui_cmd_window): Override
5579         make_visible.
5580         (tui_win_is_source_type): Don't declare.
5581         * tui/tui-data.c (tui_win_is_source_type): Remove.
5582
5583 2019-06-25  Tom Tromey  <tom@tromey.com>
5584
5585         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5586         NULL check.
5587
5588 2019-06-25  Tom Tromey  <tom@tromey.com>
5589
5590         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5591         Inline constructor.  Add initializers for members.
5592         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5593         constructors; now inline in class.
5594
5595 2019-06-25  Tom Tromey  <tom@tromey.com>
5596
5597         * tui/tui-regs.c (tui_show_registers): Update.
5598         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5599         bool.
5600         * tui/tui-data.c (tui_data_window::clear_detail)
5601         (tui_data_window): Update.
5602
5603 2019-06-25  Tom Tromey  <tom@tromey.com>
5604
5605         * tui/tui-windata.c (tui_display_all_data)
5606         (tui_display_data_from_line, tui_display_data_from)
5607         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5608         Update.
5609         * tui/tui-regs.c (tui_last_regs_line_no)
5610         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5611         (tui_show_registers, tui_show_register_group)
5612         (tui_display_registers_from, tui_display_reg_element_at_line)
5613         (tui_display_registers_from_line, tui_check_register_values)
5614         (tui_reg_next, tui_reg_prev): Update.
5615         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5616         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5617         tui_data_window.
5618         (struct tui_win_info) <detail>: Remove.  Add new fields from
5619         tui_data_info.
5620         (TUI_DATA_WIN): Add cast.
5621         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5622         (~tui_data_window): Simplify.
5623
5624 2019-06-25  Tom Tromey  <tom@tromey.com>
5625
5626         * tui/tui-layout.c (show_source_disasm_command)
5627         (show_source_or_disasm_and_command): Update.
5628         * tui/tui-io.c (update_cmdwin_start_line)
5629         (tui_redisplay_readline): Update.
5630         * tui/tui-data.h (struct tui_command_info): Remove.
5631         (struct tui_win_info) <detail>: Remove command_info member.
5632         (struct tui_data_window) <start_line>: New member, from
5633         tui_command_info.
5634         (TUI_CMD_WIN): Add casts.
5635
5636 2019-06-25  Tom Tromey  <tom@tromey.com>
5637
5638         * tui/tui-winsource.c (tui_update_source_window)
5639         (tui_refill_source_window)
5640         (tui_source_window_base::do_scroll_horizontal)
5641         (tui_update_breakpoint_info, tui_set_exec_info_content)
5642         (tui_show_exec_info_content, tui_erase_exec_info_content)
5643         (tui_clear_exec_info_content): Update.
5644         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5645         Update.
5646         * tui/tui-win.c (make_invisible_and_set_new_height)
5647         (make_visible_with_new_height): Update.
5648         * tui/tui-source.c (tui_set_source_content)
5649         (tui_show_symtab_source): Update.
5650         * tui/tui-layout.c (extract_display_start_addr)
5651         (show_source_disasm_command, show_data)
5652         (make_source_or_disasm_window)
5653         (show_source_or_disasm_and_command): Update.
5654         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5655         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5656         "gdbarch".
5657         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5658         to tui_source_window_base.
5659         (struct tui_win_info) <detail>: Remove source_info member.
5660         (struct tui_source_window_base) <has_locator>: Inline.
5661         Move contents from tui_source_info; rename has_locator member to
5662         m_has_locator.
5663         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5664         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5665         header file.
5666         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5667         Simplify.
5668         (tui_free_all_source_wins_content): Cast to
5669         tui_source_window_base.
5670
5671 2019-06-25  Tom Tromey  <tom@tromey.com>
5672
5673         * tui/tui-win.c (make_invisible_and_set_new_height)
5674         (make_visible_with_new_height): Call has_locator method.
5675         * tui/tui-layout.c (show_source_disasm_command, show_data)
5676         (show_source_or_disasm_and_command): Update for bool change.
5677         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5678         (tui_win_info) <has_locator>: New method.
5679         (struct tui_source_window_base) <has_locator>: New method.
5680         (tui_win_has_locator): Don't declare.
5681         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5682         from tui_win_has_locator.
5683         (tui_source_window_base): Use false, not FALSE.
5684
5685 2019-06-25  Tom Tromey  <tom@tromey.com>
5686
5687         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5688         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5689         clear_detail method directly.
5690         (tui_clear_win_detail): Remove.
5691
5692 2019-06-25  Tom Tromey  <tom@tromey.com>
5693
5694         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5695         "this", not TUI_DISASM_WIN.
5696
5697 2019-06-25  Tom Tromey  <tom@tromey.com>
5698
5699         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5700         declare.
5701         * tui/tui-winsource.c
5702         (tui_source_window_base::do_scroll_horizontal): Rename from
5703         tui_horizontal_source_scroll.
5704         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5705         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5706         from tui_vertical_data_scroll.
5707         * tui/tui-win.h (tui_scroll): Don't declare.
5708         * tui/tui-win.c (tui_win_info::forward_scroll)
5709         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5710         (tui_win_info::right_scroll): Rename and update.
5711         (tui_scroll_forward_command, tui_scroll_backward_command)
5712         (tui_scroll_left_command, tui_scroll_right_command): Update.
5713         (tui_scroll): Remove.
5714         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5715         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5716         from tui_vertical_source_scroll.
5717         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5718         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5719         from tui_vertical_disassem_scroll.
5720         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5721         do_scroll_horizontal>: New methods.
5722         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5723         Likewise.
5724         (struct tui_source_window_base): Add do_scroll_horizontal.
5725         (struct tui_source_window, struct tui_disasm_window): Add
5726         do_scroll_vertical.
5727         (struct tui_data_window, struct tui_cmd_window): Add
5728         do_scroll_horizontal and do_scroll_vertical.
5729         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5730
5731 2019-06-25  Tom Tromey  <tom@tromey.com>
5732
5733         * tui/tui-data.h (struct tui_source_window_base): New struct.
5734         (struct tui_source_window): Derive from tui_source_window_base.
5735         (struct tui_disasm_window): New struct.
5736         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5737         from tui_source_window::clear_detail.
5738         (tui_source_window_base): Rename from tui_source_window.
5739         (~tui_source_window_base): Rename from ~tui_source_window.
5740         (tui_alloc_win_info): Create a tui_disasm_window.
5741
5742 2019-06-25  Tom Tromey  <tom@tromey.com>
5743
5744         * tui/tui-data.h (struct tui_source_window)
5745         (struct tui_data_window): Declare destructors.
5746         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5747         destructors.
5748         (tui_win_info): Simplify.
5749
5750 2019-06-25  Tom Tromey  <tom@tromey.com>
5751
5752         * tui/tui-winsource.c (tui_display_main)
5753         (tui_update_source_windows_with_addr)
5754         (tui_update_all_breakpoint_info): Update.
5755         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5756         (new_height_ok, parse_scrolling_args): Update.
5757         * tui/tui-stack.c (tui_show_frame_info): Update.
5758         * tui/tui-data.h (struct tui_list): Remove.
5759         (tui_source_windows): Return a reference to a std::vector.
5760         * tui/tui-data.c (source_windows): Now a std::vector.
5761         (tui_source_windows): Change return type.
5762         (tui_clear_source_windows): Rewrite.
5763         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5764         (tui_free_all_source_wins_content): Rewrite.
5765
5766 2019-06-25  Tom Tromey  <tom@tromey.com>
5767
5768         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5769         (struct tui_data_window, struct tui_cmd_window): Declare
5770         clear_detail method.
5771         * tui/tui-data.c (tui_source_window::clear_detail)
5772         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5773         methods.
5774         (tui_clear_win_detail): Simplify.
5775
5776 2019-06-25  Tom Tromey  <tom@tromey.com>
5777
5778         * tui/tui-layout.c (make_source_window, make_disasm_window)
5779         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5780         Return the new window.
5781         (show_source_disasm_command, show_data)
5782         (show_source_or_disasm_and_command): Update.
5783
5784 2019-06-25  Tom Tromey  <tom@tromey.com>
5785
5786         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5787         parameter.  Return the new window.
5788         (show_source_disasm_command): Update and remove NULL check.
5789         (show_source_or_disasm_and_command): Update.
5790
5791 2019-06-25  Tom Tromey  <tom@tromey.com>
5792
5793         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5794
5795 2019-06-25  Tom Tromey  <tom@tromey.com>
5796
5797         * tui/tui-data.h (struct tui_win_info): Make constructor
5798         protected.  Make destructor virtual.  Add initializers.
5799         (tui_source_window, tui_data_window, tui_cmd_window): New
5800         classes.
5801         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5802         constructor.  Add "type" parameter.
5803         (tui_source_window, tui_data_window, tui_cmd_window): New
5804         constructors.
5805         (tui_alloc_win_info): Instantiate the appropriate subclass.
5806
5807 2019-06-25  Tom Tromey  <tom@tromey.com>
5808
5809         * tui/tui-win.c (tui_resize_all): Use delete.
5810         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5811         destructor.
5812         (tui_free_window): Don't declare.
5813         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5814         Update.
5815
5816 2019-06-25  Tom Tromey  <tom@tromey.com>
5817
5818         * tui/tui-data.h (struct tui_win_info): Add constructor.
5819         * tui/tui-data.c (tui_alloc_win_info): Use new.
5820         (tui_free_window): Use delete.
5821
5822 2019-06-22  Tom Tromey  <tom@tromey.com>
5823
5824         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5825         declare.
5826         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5827
5828 2019-06-22  Tom Tromey  <tom@tromey.com>
5829
5830         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5831         declare.
5832         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5833
5834 2019-06-22  Tom de Vries  <tdevries@suse.de>
5835
5836         * dwarf2read.c (create_addrmap_from_aranges)
5837         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5838         instead of '%zu'.
5839
5840 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5841
5842         * dwarf2read.h (dwarf2_section_info_def): Remove.
5843         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5844         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5845         std::vector<dwarf2_section_info>.
5846         (struct dwo_file) <~dwo_file>: Remove.
5847         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5848         types field.
5849         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5850         (dwarf2_read_debug_names): Likewise.
5851         (create_debug_types_hash_table): Change parameter type to
5852         array_view, adjust code accordingly.
5853         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5854         (partial_die_info::fixup): Likewise.
5855         (determine_prefix): Likewise.
5856         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5857
5858 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5859
5860         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5861         gdb_bfd_ref_ptr.
5862         <~dwo_file>: Remove call to gdb_bfd_unref.
5863         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5864         gdb_bfd_ref_ptr::get.
5865
5866 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5867
5868         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5869         type to htab_up.
5870         * dwarf2read.c (struct dwo_file): Initialize fields.
5871         <~dwo_file>: New.
5872         (free_dwo_file): Remove, move content to ~dwo_file.
5873         (struct dwo_file_deleter): Remove.
5874         (dwo_file_up>: Remove custom deleter.
5875         (free_dwo_files): Remove.
5876         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5877         dwo_files.
5878         (process_skeletonless_type_units): Call unique_ptr::get.
5879         (allocate_dwo_file_hash_table): Add deleter to created hash
5880         table.  Change return type to htab_up.
5881         (lookup_dwo_file_slot): Don't memset dwo_file, call
5882         unique_ptr::get.
5883         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5884         (create_dwo_unit_in_dwp_v2): Likewise.
5885         (open_and_init_dwo_file): Likewise.
5886         (free_dwo_file_from_slot): Remove.
5887
5888 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5889
5890         * dwarf2read.h (struct dwarf2_section_info) <readin,
5891         is_virtual>: Change type to bool.
5892         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5893         true instead of 1.
5894
5895 2019-06-19  Tom Tromey  <tom@tromey.com>
5896
5897         * tui/tui-data.h (tui_init_content_element): Don't declare.
5898
5899 2019-06-19  Tom Tromey  <tom@tromey.com>
5900
5901         * tui/tui-data.h (tui_init_win_info): Don't declare.
5902
5903 2019-06-19  Tom de Vries  <tdevries@suse.de>
5904
5905         * dwarf2read.h (abstract_to_concrete): Change type to
5906         std::unordered_map<sect_offset, std::vector<sect_offset>,
5907         gdb::hash_enum<sect_offset>>.
5908
5909 2019-06-19  Tom Tromey  <tromey@adacore.com>
5910
5911         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5912         EVAL_AVOID_SIDE_EFFECTS specially.
5913
5914 2019-06-19  Tom Tromey  <tromey@adacore.com>
5915
5916         * source-cache.c (highlighter): New global.
5917         (source_cache::get_source_lines): Create a highlighter on demand.
5918
5919 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5920
5921         * defs.h (deprecated_interactive_hook): Delete declaration.
5922         * interps.c (clear_interpreter_hooks): Remove use of
5923         deprecated_interactive_hook.
5924         * top.c (deprecated_interactive_hook): Delete definition.
5925         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5926
5927 2019-06-18  Tom de Vries  <tdevries@suse.de>
5928
5929         PR gdb/24515
5930         * dwarf2read.h (abstract_to_concrete): Change type from
5931         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5932         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5933         * dwarf2read.c (read_variable): Update.
5934         (dwarf2_fetch_die_loc_sect_off): Update.
5935
5936 2019-06-17  Tom de Vries  <tdevries@suse.de>
5937
5938         PR gdb/24617
5939         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5940         accessing parent[parent_len - 1].
5941
5942 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5943
5944         PR gdb/24364
5945         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5946         call dtrace_process_dof with NULL dof.
5947
5948 2019-06-16  Tom de Vries  <tdevries@suse.de>
5949
5950         PR gdb/24445
5951         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5952
5953 2019-06-16  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5956         (make_all_visible): Use address of member.
5957
5958 2019-06-16  Tom Tromey  <tom@tromey.com>
5959
5960         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5961         (tui_free_window, free_content, free_content_elements): Remove
5962         unnecessary cast.
5963         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5964         cast.
5965         * tui/tui-regs.c (tui_show_register_group)
5966         (tui_display_registers_from, tui_display_reg_element_at_line):
5967         Remove unnecessary cast.
5968
5969 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5970
5971         * linux-nat.c (normal_mask): Delete.
5972         (_initialize_linux_nat): Don't initialise normal_mask.
5973
5974 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5975
5976         PR gdb/24445
5977         * dwarf-index-write.h (write_psymtabs_to_index): Add
5978         dwz_basename parameter.
5979         * dwarf-index-write.c (write_gdbindex): Move file writing to
5980         write_gdbindex_1.  Change return type void.
5981         (assert_file_size): Move up, remove filename parameter.
5982         (write_gdbindex_1): New function.
5983         (write_debug_names): Change return type to void, call
5984         assert_file_size.
5985         (struct index_wip_file): New struct.
5986         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5987         file logic to index_wip_file.  Write index for dwz file if
5988         needed.
5989         (save_gdb_index_command): Pass basename of dwz file, if present.
5990         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5991         build-id of dwz file, if present.
5992         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5993         (dwarf2_get_dwz_file): Likewise.
5994         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5995         (dwarf2_get_dwz_file): Likewise.
5996
5997 2019-06-16  Tom Tromey  <tom@tromey.com>
5998
5999         * coffread.c (process_coff_symbol): Use xstrdup.
6000         * value.c (create_internalvar): Use xstrdup.
6001
6002 2019-06-16  Tom Tromey  <tom@tromey.com>
6003
6004         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6005         * breakpoint.c (stopin_command, stopat_command)
6006         (until_break_command, decode_location_default): Remove unnecessary
6007         cast.
6008         * utils.c (subset_compare): Remove unnecessary cast.
6009         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6010         cast.
6011         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6012         cast.
6013         * infcmd.c (path_command): Remove unnecessary cast.
6014         * coffread.c (decode_type): Remove unnecessary cast.
6015         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6016         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6017         * tui/tui-stack.c (tui_show_locator_content)
6018         (tui_show_frame_info): Remove unnecessary cast.
6019         * tui/tui-win.c (tui_scroll_forward_command)
6020         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6021         (parse_scrolling_args): Remove unnecessary cast.
6022         * tui/tui-data.c (init_win_info, tui_del_window)
6023         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6024         (free_content_elements): Remove unnecessary cast.
6025         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6026         unnecessary cast.
6027         * tui/tui-source.c (tui_set_source_content)
6028         (tui_vertical_source_scroll): Remove unnecessary cast.
6029         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6030         cast.
6031         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6032         * tui/tui-regs.c (tui_display_registers_from)
6033         (tui_display_register): Remove unnecessary cast.
6034         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6035         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6036         (make_visible): Remove unnecessary cast.
6037         * tui/tui-winsource.c (tui_erase_source_content)
6038         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6039         unnecessary cast.
6040         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6041         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6042         * stabsread.c (read_type, read_array_type, read_range_type):
6043         Remove unnecessary cast.
6044         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6045         (parse_symbol, parse_type, upgrade_type, parse_external)
6046         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6047         unnecessary cast.
6048         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6049
6050 2019-06-16  Tom Tromey  <tom@tromey.com>
6051
6052         * tui/tui-data.c (tui_alloc_generic_win_info)
6053         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6054         checks.
6055
6056 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6057             Andrew Burgess  <andrew.burgess@embecosm.com>
6058
6059         * f-typeprint.c (f_print_type): Don't return early for not
6060         associated or not allocated types.
6061         (f_type_print_varspec_suffix): Add print_rank parameter and print
6062         ranks of array types in case they dangling.
6063         (f_type_print_base): Add print_rank parameter.
6064
6065 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6066
6067         * NEWS: Mention new MI commands.
6068         * break-catch-throw.c (enum exception_event_kind): Move to
6069         breakpoint.h.
6070         (print_mention_exception_catchpoint): Output text as a single
6071         message.
6072         (catch_exception_command_1): Rename to...
6073         (catch_exception_event): ...this, make non-static, update header
6074         command, and change some parameter types.
6075         (catch_catch_command): Update for changes to
6076         catch_exception_command_1.
6077         (catch_throw_command): Likewise.
6078         (catch_rethrow_command): Likewise.
6079         * breakpoint.c (enum exception_event_kind): Delete.
6080         * breakpoint.h (enum exception_event_kind): Moved here from
6081         break-catch-throw.c.
6082         (catch_exception_event): Declare.
6083         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6084         (mi_cmd_catch_throw): New function.
6085         (mi_cmd_catch_rethrow): New function.
6086         (mi_cmd_catch_catch): New function.
6087         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6088         'catch-catch' entries.
6089         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6090         (mi_cmd_catch_rethrow): Declare.
6091         (mi_cmd_catch_catch): Declare.
6092
6093 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6094
6095         * annotate.c (annotate_source_line): Change return type to void,
6096         update implementation to match.
6097         * annotate.h (annotate_source_line): Change return type to void,
6098         update header comment.
6099         * stack.c (print_frame_info): Don't change what frame information
6100         is printed based on whether annotations are on or not.
6101
6102 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6103
6104         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6105         (annotate_source): Make static.
6106         (annotate_source_line): Moved from source.c and renamed from
6107         identify_source_line.  Update the return type.
6108         * annotate.h (annotate_source): Delete declaration.
6109         (annotate_source_line): Declaration moved from source.h, and
6110         renamed from identify_source_line.  Return type updated.
6111         * source.c (identify_source_line): Moved to annotate.c and renamed
6112         to annotate_source_line.
6113         (info_line_command): Remove check of annotation_level.
6114         * source.h (identify_source_line): Move declaration to annotate.h
6115         and rename to annotate_source_line.
6116         * stack.c: Add 'annotate.h' include.
6117         (print_frame_info): Remove check of annotation_level before
6118         calling annotate_source_line.
6119
6120 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6121
6122         * source-cache.c (source_cache::get_plain_source_lines): Use
6123         open_source_file_with_line_charpos instead of just
6124         open_source_file, remove call to find_source_lines.
6125         (source_cache::get_source_lines): Likewise.
6126         * source.c (find_source_lines): Make static.
6127         (get_filename_and_charpos): Renamed into...
6128         (open_source_file_with_line_charpos): ..this along with changes to
6129         return a scoped_fd, and some other minor clean ups.
6130         (identify_source_line): Use open_source_file_with_line_charpos.
6131         (search_command_helper): Use open_source_file_with_line_charpos
6132         instead of just open_source_file, remove call to
6133         find_source_lines.
6134         * source.h (open_source_file_with_line_charpos): Declare new
6135         function.
6136         (find_source_lines): Delete declaration.
6137
6138 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6139
6140         * source.c (get_filename_and_charpos): Remove fullname
6141         parameter.
6142         (identify_source_line): Update call to get_filename_and_charpos.
6143
6144 2019-06-14  Tom Tromey  <tromey@adacore.com>
6145
6146         PR gdb/24502:
6147         * ui-style.h (skip_ansi_escape): Update comment.
6148         * ui-file.h (class no_terminal_escape_file): New class.
6149         * ui-file.c (no_terminal_escape_file::write)
6150         (no_terminal_escape_file::puts): New methods.
6151         * cli/cli-logging.c (handle_redirections): Use
6152         no_terminal_escape_file.
6153
6154 2019-06-14  Tom Tromey  <tromey@adacore.com>
6155
6156         * NEWS: Move convenience variable news above Python news.
6157
6158 2019-06-14  Tom Tromey  <tom@tromey.com>
6159
6160         * gnulib: Move directory to top-level.
6161         * configure.ac: Don't configure gnulib.
6162         * configure: Rebuild.
6163         * common/common-defs.h: Use new path to gnulib.
6164         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6165         (GNULIB_H): Remove.
6166         (INCGNU): Look in new gnulib location.
6167         (HFILES_NO_SRCDIR): Remove gnulib files.
6168         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6169         (generated_files): Remove GNULIB_H.
6170         ($(LIBGNU), all-lib): Remove targets.
6171         (distclean): Don't mention GNULIB_BUILDDIR.
6172         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6173
6174 2019-06-14  Tom Tromey  <tromey@adacore.com>
6175
6176         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6177         Warn if symbol file does not provide any symbols.
6178
6179 2019-06-14  Tom Tromey  <tromey@adacore.com>
6180
6181         * source.c (find_and_open_source): Respect basenames_may_differ.
6182
6183 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6184
6185         * annotate.c (annotate_breakpoints_invalid): Make use of
6186         scoped_restore_terminal_state.
6187         (annotate_frames_invalid): Likewise.
6188
6189 2019-06-14  Tom Tromey  <tromey@adacore.com>
6190
6191         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6192         allow assignment to an internalvar.
6193
6194 2019-06-14  Tom Tromey  <tromey@adacore.com>
6195
6196         * ada-lex.l: Allow "_" in attribute names.
6197
6198 2019-06-14  Tom Tromey  <tromey@adacore.com>
6199
6200         PR gdb/24653:
6201         * regcache.c (registers_changed): Don't call alloca.
6202         * top.c (execute_command): Don't call alloca.
6203
6204 2019-06-13  Pedro Alves  <palves@redhat.com>
6205
6206         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6207         'expression'.  When parsing an expression, error out if there's
6208         junk after "unlimited".
6209         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6210         (do_set_command): Adjust calls to is_unlimited_literal.
6211
6212 2019-06-13  Pedro Alves  <palves@redhat.com>
6213
6214         * compile/compile.c (make_compile_options_def_group): Add braces
6215         around array_view initializer.
6216         * thread.c (make_thread_apply_all_options_def_group)
6217         (make_thread_apply_all_options_def_group): Likewise.
6218
6219 2019-06-13  Pedro Alves  <palves@redhat.com>
6220
6221         * NEWS (New commands): Mention "maint test-options
6222         require-delimiter", "maint test-options unknown-is-error", "maint
6223         test-options unknown-is-operand" and "maint show
6224         test-options-completion-result".
6225         (New command options, command completion): New section.
6226         (Completion improvements): New section.
6227         Mention that you can abbreviate "unlimited".
6228
6229 2019-06-13  Pedro Alves  <palves@redhat.com>
6230
6231         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6232         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6233         * unittests/cli-utils-selftests.c (test_parse_flags)
6234         (test_parse_flags_qcs): Delete.
6235         (test_cli_utils): Don't call deleted functions.
6236
6237 2019-06-13  Pedro Alves  <palves@redhat.com>
6238
6239         * thread.c: Include "cli/cli-option.h".
6240         (tp_array_compar_ascending): Global.
6241         (tp_array_compar): Delete function.
6242         (tp_array_compar_ascending, tp_array_compar_descending): New
6243         functions.
6244         (ascending_option_def, qcs_flag_option_def)
6245         (thr_qcs_flags_option_defs)
6246         (make_thread_apply_all_options_def_group)
6247         (make_thread_apply_options_def_group): New.
6248         (thread_apply_all_command): Use gdb::option::process_options.
6249         (thread_apply_command_completer)
6250         (thread_apply_all_command_completer): New.
6251         (thread_apply_command): Use gdb::option::process_options.
6252         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6253         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6254         to generate help text of "thread apply".  Adjust "taas"'s help.
6255         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6256         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6257
6258 2019-06-13  Pedro Alves  <palves@redhat.com>
6259
6260         * thread.c (thread_apply_command): Check for invalid TID with
6261         isdigit instead of !isalpha.
6262
6263 2019-06-13  Pedro Alves  <palves@redhat.com>
6264
6265         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6266         (validate_flags_qcs): New.
6267         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6268         (validate_flags_qcs): Declare.
6269         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6270         (make_frame_apply_options_def_group): New.
6271         (frame_apply_command_count): Process options with
6272         gdb::option::process_options.
6273         (frame_apply_completer): New.
6274         (frame_apply_level_completer, frame_apply_all_completer)
6275         (frame_apply_completer): New.
6276         (_initialize_stack): Update help of "frame apply", "frame apply
6277         level", "frame apply all" and "faas" to mention supported options
6278         and install command completers.
6279         * stack.h (frame_apply_all_completer): Declare.
6280         * thread.c: Include "stack.h".
6281         (tfaas_command): Add "--".
6282         (_initialize_thread): Update help "tfaas" to mention supported
6283         options and install command completer.
6284
6285 2019-06-13  Pedro Alves  <palves@redhat.com>
6286
6287         * completer.c (complete_nested_command_line): New.
6288         (gdb_completion_word_break_characters_throw): Add assertion.
6289         * completer.h (complete_nested_command_line): Declare.
6290
6291 2019-06-13  Pedro Alves  <palves@redhat.com>
6292
6293         * stack.c (parse_backtrace_qualifiers): New.
6294         (backtrace_command): Use it.
6295         (backtrace_command_completer): Complete on qualifiers.
6296
6297 2019-06-13  Pedro Alves  <palves@redhat.com>
6298
6299         * frame.c: Include "cli/cli-option.h.
6300         (user_set_backtrace_options): New.
6301         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6302         Delete.
6303         (get_prev_frame): Adjust.
6304         (boolean_option_def, uinteger_option_def)
6305         (set_backtrace_option_defs): New.
6306         (_initialize_frame): Adjust and use
6307         gdb::option::add_setshow_cmds_for_options to install "set
6308         backtrace past-main" and "set backtrace past-entry".
6309         * frame.h: Include "cli/cli-option.h".
6310         (struct frame_print_options): Forward declare.
6311         (print_frame_arguments_all, print_frame_arguments_scalars)
6312         (print_frame_arguments_none): Declare.
6313         (print_entry_values): Delete declaration.
6314         (struct frame_print_options, user_frame_print_options): New.
6315         (struct set_backtrace_options): New.
6316         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6317         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6318         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6319         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6320         (list_args_or_locals): Add frame_print_options parameter.
6321         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6322         * python/py-framefilter.c (enumerate_args): Pass down
6323         USER_FRAME_PRINT_OPTIONS.
6324         * stack.c: Include "cli/cli-option.h".
6325         (print_frame_arguments_all, print_frame_arguments_scalars)
6326         (print_frame_arguments_none): Declare.
6327         (print_raw_frame_arguments, print_entry_values): Delete.
6328         (user_frame_print_options): New.
6329         (boolean_option_def, enum_option_def, frame_print_option_defs):
6330         New.
6331         (struct backtrace_cmd_options): New.
6332         (bt_flag_option_def): New.
6333         (backtrace_command_option_defs): New.
6334         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6335         (print_frame_arg, read_frame_arg, print_frame_args)
6336         (print_frame_info, print_frame): Add frame_print_options parameter
6337         and use it.
6338         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6339         (backtrace_command_1): Add frame_print_options and
6340         backtrace_cmd_options parameters and use them.
6341         (make_backtrace_options_def_group): New.
6342         (backtrace_command): Process command options with
6343         gdb::option::process_options.
6344         (backtrace_command_completer): New.
6345         (_initialize_stack): Extend "backtrace"'s help to mention
6346         supported options.  Install completer for "backtrace".
6347         Install some settings commands with add_setshow_cmds_for_options.
6348
6349 2019-06-13  Pedro Alves  <palves@redhat.com>
6350
6351         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6352         and that "set/show print raw frame-arguments" are now deprecated.
6353
6354         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6355         command.
6356         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6357         * stack.c (_initialize_stack): Install "set/show print
6358         raw-frame-arguments", and deprecate "set/show print raw
6359         frame-arguments".
6360         * valprint.c (_initialize_valprint): Deprecate "set/show print
6361         raw".
6362
6363 2019-06-13  Pedro Alves  <palves@redhat.com>
6364
6365         * compile/compile.c (struct compile_options): New.
6366         (compile_flag_option_def, compile_command_option_defs)
6367         (make_compile_options_def_group): New.
6368         (compile_file_command): Handle options with
6369         gdb::option::process_options.
6370         (compile_file_command_completer): New function.
6371         (compile_code_command): Handle options with
6372         gdb::option::process_options.
6373         (compile_code_command_completer): New function.
6374         (_initialize_compiler): Install completers for "compile code" and
6375         "compile file".  Mention available options in "compile code" and
6376         "compile code"'s help.
6377         * completer.c (advance_to_completion_word): New, factored out from
6378         ...
6379         (advance_to_expression_complete_word_point): ... this.
6380         (advance_to_filename_complete_word_point): New.
6381         * completer.h (advance_to_filename_complete_word_point): New
6382         declaration.
6383
6384 2019-06-13  Pedro Alves  <palves@redhat.com>
6385
6386         * compile/compile.c: Include "cli/cli-option.h".
6387         (compile_print_value): Scope data pointer is now a
6388         value_print_options pointer; adjust.
6389         (compile_print_command): Process options.  Scope data pointer is
6390         now a value_print_options pointer; adjust.
6391         (_initialize_compile): Update "compile print"'s help to include
6392         supported options.  Install a completer for "compile print".
6393         * cp-valprint.c (show_vtblprint, show_objectprint)
6394         (show_static_field_print): Delete.
6395         (_initialize_cp_valprint): Don't install "set print
6396         static-members", "set print vtbl", "set print object" here.
6397         * printcmd.c: Include "cli/cli-option.h" and
6398         "common/gdb_optional.h".
6399         (print_command_parse_format): Rework to fill in a
6400         value_print_options instead of a format_data.
6401         (print_value): Change parameter type from format_data pointer to
6402         value_print_options reference.  Adjust.
6403         (print_command_1): Process options.  Adjust to pass down a
6404         value_print_options.
6405         (print_command_completer): New.
6406         (_initialize_printcmd): Install print_command_completer as
6407         handle_brkchars completer for the "print" command.  Update
6408         "print"'s help to include supported options.
6409         * valprint.c: Include "cli/cli-option.h".
6410         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6411         here from cp-valprint.c.
6412         (boolean_option_def, uinteger_option_def)
6413         (value_print_option_defs, make_value_print_options_def_group):
6414         New.  Use gdb::option::add_setshow_cmds_for_options to install
6415         "set print elements", "set print null-stop", "set print repeats",
6416         "set print pretty", "set print union", "set print array", "set
6417         print address", "set print symbol", "set print array-indexes".
6418         * valprint.h: Include <string> and "cli/cli-option.h".
6419         (make_value_print_options_def_group): Declare.
6420         (print_value): Change parameter type from format_data pointer to
6421         value_print_options reference.
6422         (print_command_completer): Declare.
6423
6424 2019-06-13  Pedro Alves  <palves@redhat.com>
6425
6426         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6427         (COMMON_SFILES): Add maint-test-settings.c.
6428         * cli/cli-decode.c (boolean_enums): New global, factored out from
6429         ...
6430         (add_setshow_boolean_cmd): ... here.
6431         * cli/cli-decode.h (boolean_enums): Declare.
6432         * cli/cli-option.c: New file.
6433         * cli/cli-option.h: New file.
6434         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6435         factored out from ...
6436         (parse_cli_boolean_value(const char *)): ... this.
6437         (is_unlimited_literal): Change parameter type to pointer to
6438         pointer.  Adjust and advance ARG pointer.
6439         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6440         (parse_cli_var_enum): New, factored out from ...
6441         (do_set_command): ... this.  Adjust.
6442         * cli/cli-setshow.h (parse_cli_boolean_value)
6443         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6444         (parse_cli_var_enum): Declare.
6445         * cli/cli-utils.c: Include "cli/cli-option.h".
6446         (get_ulongest): New.
6447         * cli/cli-utils.h (get_ulongest): Declare.
6448         (check_for_argument): New overloads.
6449         * maint-test-options.c: New file.
6450
6451 2019-06-13  Pedro Alves  <palves@redhat.com>
6452
6453         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6454         parse a range if "-" is at the end of the string.
6455
6456 2019-06-13  Pedro Alves  <palves@redhat.com>
6457
6458         * cli/cli-setshow.c (parse_auto_binary_operation)
6459         (parse_cli_boolean_value): Don't allow "o".
6460
6461 2019-06-13  Pedro Alves  <palves@redhat.com>
6462
6463         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6464         * NEWS: Mention maint test-settings KIND.
6465         * maint-test-settings.c: New file.
6466
6467 2019-06-13  Pedro Alves  <palves@redhat.com>
6468
6469         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6470         completer.
6471         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6472         "set" completers.
6473
6474 2019-06-13  Pedro Alves  <palves@redhat.com>
6475
6476         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6477         after item.
6478
6479 2019-06-13  Pedro Alves  <palves@redhat.com>
6480
6481         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6482
6483 2019-06-13  Pedro Alves <palves@redhat.com>
6484
6485         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6486         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6487         call.
6488         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6489         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6490         calls.
6491         (check_for_argument): Skip spaces after argument.
6492
6493 2019-06-13  Pedro Alves  <palves@redhat.com>
6494
6495         * thread.c (thread_apply_command): Adjust TID parsing.
6496         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6497         detected before end of string.
6498         (tid_is_in_list): Error out if LIST is invalid.
6499
6500 2019-06-13  Pedro Alves  <palves@redhat.com>
6501
6502         * completer.c (complete_line_internal_1): Rewind completion word
6503         point.
6504         (completion_tracker::advance_custom_word_point_by): Change
6505         parameter type to int.
6506         * completer.h (completion_tracker::advance_custom_word_point_by):
6507         Likewise.
6508
6509 2019-06-13  Pedro Alves  <palves@redhat.com>
6510
6511         * completer.c (advance_to_completion_word): Handle delimiters.
6512
6513 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6514
6515         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6516
6517 2019-06-11  Tom Tromey  <tom@tromey.com>
6518
6519         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6520         (xmalloc_failed): Move to alloc.c.
6521         * alloc.c: New file.
6522         * Makefile.in (COMMON_SFILES): Add alloc.c.
6523
6524 2019-06-11  Tom Tromey  <tom@tromey.com>
6525
6526         * nat/linux-waitpid.c: Don't include server.h.
6527         (linux_debug): Remove.
6528         (my_waitpid): Update.
6529
6530 2019-06-11  Tom Tromey  <tromey@adacore.com>
6531
6532         * infcall.c (_initialize_infcall): Remove trailing newline from
6533         help.
6534         * user-regs.c (_initialize_user_regs): Remove trailing newline
6535         from help.
6536         * typeprint.c (_initialize_typeprint): Remove trailing newline
6537         from help.
6538         * reverse.c (_initialize_reverse): Remove trailing newlines from
6539         help.
6540         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6541         from help.
6542         * language.c (add_set_language_command): Remove trailing newline
6543         from help.
6544         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6545         help.
6546         * disasm.c (_initialize_disasm): Remove trailing newline from
6547         help.
6548         * top.c (init_main): Remove trailing newline from help.
6549         * interps.c (_initialize_interpreter): Remove trailing newline
6550         from help.
6551         * btrace.c (_initialize_btrace): Remove trailing newlines from
6552         help.
6553         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6554         from help.
6555         * python/python.c (_initialize_python): Remove trailing newline
6556         from help.
6557         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6558         help.
6559         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6560         from help.  Reformat some text.
6561         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6562         from help.
6563         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6564         newline from help.
6565
6566 2019-06-11  Tom Tromey  <tromey@adacore.com>
6567
6568         * darwin-nat.c (darwin_decode_exception_message)
6569         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6570
6571 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6572
6573         * valops.c (value_slice): Check for not allocated or not
6574         associated values.
6575
6576 2019-06-10  Tom de Vries  <tdevries@suse.de>
6577
6578         PR gdb/24618
6579         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6580         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6581         invalid.
6582
6583 2019-06-10  Tom de Vries  <tdevries@suse.de>
6584
6585         PR gdb/24611
6586         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6587         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6588
6589 2019-06-10  Tom de Vries  <tdevries@suse.de>
6590
6591         PR symtab/24545
6592         * symtab.c (struct demangled_name_entry): Add language field.
6593         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6594         static minimal symbol".  Set and use language field.
6595
6596 2019-06-10  Tom Tromey  <tromey@adacore.com>
6597
6598         * ada-lang.c (_initialize_ada_language): Update help text.
6599
6600 2019-06-10  Tom Tromey  <tromey@adacore.com>
6601
6602         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6603         with a newline.
6604         * guile/guile.c (handle_boot_error): Don't end warning with a
6605         newline.
6606         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6607         warning with a newline.
6608         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6609         newline.
6610         (s12z_frame_cache): Likewise.
6611         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6612         a newline.
6613         * solib-svr4.c (disable_probes_interface): Don't end warning with
6614         a newline.
6615         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6616         newline.
6617         * python/python.c (do_finish_initialization): Don't end warning
6618         with a newline.
6619
6620 2019-06-10  Tom Tromey  <tom@tromey.com>
6621
6622         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6623         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6624         gdbpy_enter.
6625
6626 2019-06-10  Tom Tromey  <tromey@adacore.com>
6627
6628         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6629         data.
6630         (elf_new_init): Don't call stabsread_new_init.
6631         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6632         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6633         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6634
6635 2019-06-10  Tom de Vries  <tdevries@suse.de>
6636
6637         PR symtab/16264
6638         PR symtab/24517
6639         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6640
6641 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6642
6643         * source.c (find_and_open_source): Also rewrite relative file
6644         names.
6645
6646 2019-04-26  Amos Bird  <amosbird@gmail.com>
6647
6648         * annotate.c (annotate_thread_exited): Add "thread-exited"
6649         annotation.
6650
6651 2019-06-06  Tom Tromey  <tromey@adacore.com>
6652
6653         * maint.h (class scoped_command_stats): Use
6654         DISABLE_COPY_AND_ASSIGN.
6655         <print_time>: New method.
6656         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6657         print_time.
6658         (scoped_command_stats::print_time): New method.
6659
6660 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6663         instructions of lengths 6 or 8 bytes.
6664
6665 2019-06-04  Pedro Alves  <palves@redhat.com>
6666
6667         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6668
6669         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6670         * breakpoint.c (condition_completer): Likewise.
6671         * cli/cli-dump.c (scan_expression): Likewise.
6672         * common/filestuff.c (mkdir_recursive): Likewise.
6673         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6674         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6675         (gdb_abspath): Likewise.
6676         * compile/compile-cplus-types.c
6677         (compile_cplus_instance::decl_name): Likewise.
6678         * completer.c (complete_explicit_location):
6679         (signal_completer, reg_or_group_completer_1): Likewise.
6680         * cp-support.c (cp_remove_params_if_any): Likewise.
6681         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6682         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6683         * infcmd.c (strip_bg_char): Likewise.
6684         * linespec.c (copy_token_string): Likewise.
6685         * mi/mi-main.c (output_cores): Likewise.
6686         * psymtab.c (psymtab_search_name):
6687         * symfile.c (test_set_ext_lang_command): Likewise.
6688         * target.c (target_fileio_read_stralloc): Likewise.
6689         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6690         * value.c (complete_internalvar): Likewise.
6691
6692 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6693
6694         Add objfile property to gdb.Type.
6695         * NEWS: Mention Python API addition.
6696         * python/py-type.c (typy_get_objfile): New method.
6697
6698 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6699
6700         * NEWS: Mention the new set|show style [title|highlight].
6701         Mention changes to "show style", "help" and "apropos".
6702
6703 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6704
6705         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6706         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6707         instead of print_help_for_command.
6708         (print_doc_of_command): New function.
6709         (help_list): Add 'apropos -v word' suggestion.
6710         (print_help_for_command): Style the command name using title style.
6711         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6712         (_initialize_cli_cmds): Describe -v in apropos_command help.
6713
6714 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6715
6716         * cli/cli-style.h (cli_style_option): Add name in constructor,
6717         add m_name class member, add constructor with intensity,
6718         add name class function.
6719         (cli_style_option::add_setshow_commands): Remove name argument.
6720         (highlight_style, title_style): New styles.
6721         * cli/cli-style.c (do_show): New function that shows a style
6722         characteristic styling the style name with itself.
6723         (set_style_name): New function.
6724         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6725         Update all callers according to the changes in cli/cli-style.h.
6726         * utils.h (fputs_highlighted): New function.
6727         * utils.c (fputs_highlighted): Likewise.
6728
6729 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6730
6731         * NEWS: Mention new pipe command and new convenience variables.
6732
6733 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6734
6735         * cli/cli-cmds.c (pipe_command): New function.
6736         (_initialize_cli_cmds): Call add_com for pipe_command.
6737         Define | as an alias for pipe.
6738         (exit_status_set_internal_vars): New function.
6739         (shell_escape): Call exit_status_set_internal_vars.
6740         cli/cli-decode.c (find_command_name_length): Recognize | as
6741         a single character command.
6742
6743 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6744
6745         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6746         top.c (execute_command_to_ui_file): New function, mostly a copy
6747         of execute_command_to_string.
6748         (execute_command_to_string): Implement by calling
6749         execute_command_to_ui_file.
6750
6751 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6752
6753         * top.h (saved_command_line): Remove declaration.
6754         * top.c (previous_saved_command_line, previous_repeat_arguments):
6755         New variables.
6756         (saved_command_line): Make static, define together with other
6757         'repeat variables'.
6758         (dont_repeat): Clear repeat_arguments.
6759         (repeat_previous, get_saved_command_line, save_command_line):
6760         New functions.
6761         (gdb_init): Initialize saved_command_line
6762         and previous_saved_command_line.
6763         * main.c (captured_main_1): Remove saved_command_line initialization.
6764         * event-top.c (handle_line_of_input): Update to use
6765         the new 'repeat' related functions instead of direct access to
6766         saved_command_line.
6767         * command.h (repeat_previous, get_saved_command_line,
6768         save_command_line): New declarations.
6769         (dont_repeat): Add comment.
6770
6771 2019-05-30  Tom Tromey  <tromey@adacore.com>
6772
6773         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6774         Fix comment.
6775         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6776
6777 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6778
6779         PR cli/24587
6780         * completer.c (complete): Initialize variable word.
6781
6782 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6783
6784         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6785         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6786         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6787         'body' is NULL to the outter 'if', protecting the '!is_define'
6788         situation as well.
6789
6790 2019-05-29  Tom Tromey  <tromey@adacore.com>
6791
6792         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6793         (dwarf_unknown): New function.
6794         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6795         (dwarf_type_encoding_name): Use dwarf_unknown.
6796
6797 2019-05-29  Tom Tromey  <tromey@adacore.com>
6798
6799         PR c++/20020:
6800         * cp-valprint.c (cp_print_value_fields): Call
6801         cp_print_static_field inside "try".
6802
6803 2019-05-29  Tom Tromey  <tromey@adacore.com>
6804
6805         * inflow.c (struct terminal_info): Add default operator=.
6806         * configure: Rebuild.
6807         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6808         -Wdeprecated-copy-dtor, -Wredundant-move.
6809
6810 2019-05-29  Tom Tromey  <tromey@adacore.com>
6811
6812         * NEWS: Add entry.
6813         * infcmd.c (print_return_value_1): Handle finish_print
6814         option.
6815         (show_print_finish): New function.
6816         (_initialize_infcmd): Add "set/show print finish" commands.
6817         * valprint.c (user_print_options): Initialize new member.
6818         * valprint.h (struct value_print_options) <finish_print>: New
6819         member.
6820
6821 2019-05-28  Tom Tromey  <tromey@adacore.com>
6822
6823         * ada-lang.c (ada_remove_Xbn_suffix)
6824         (find_old_style_renaming_symbol)
6825         (parse_old_style_renaming): Remove.
6826         (ada_find_renaming_symbol): Don't call
6827         find_old_style_renaming_symbol.
6828         (ada_is_renaming_symbol): Rename from
6829         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6830         bool.  Now static.
6831         (ada_read_var_value): Update and simplify.
6832         * ada-exp.y (write_var_or_type): Remove old code.
6833
6834 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6835
6836         PR gdb/25010
6837         * event-top.c: Remove include comment.
6838         * inflow.c (class scoped_ignore_sigttou): Move from here...
6839         * inflow.h (class scoped_ignore_sigttou): ...to here.
6840         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6841         * top.c:  Remove include comment.
6842
6843 2019-05-27  Tom Tromey  <tom@tromey.com>
6844
6845         * NEWS: Fix typo.
6846
6847 2019-05-22  Tom Tromey  <tromey@adacore.com>
6848
6849         * target.c (target_follow_exec): Constify parameter.
6850         * target-delegates.c: Rebuild.
6851         * remote.c (remote_target::follow_exec): Constify parameter.
6852         * infrun.c (follow_exec): Constify parameter.
6853         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6854         (target_follow_exec): Likewise.
6855
6856 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6857
6858         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6859         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6860
6861 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6862
6863         * NEWS: Add debugredirect and testsuite sections.
6864
6865 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6866
6867         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6868         target descriptions using exclusively floating point register name
6869         aliases.
6870
6871 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6872
6873         PR gdb/18644:
6874         * f-lang.c (build_fortran_types): Handle the case where
6875         gdbarch_floatformat_for_type returns a nullptr.
6876
6877 2019-05-21  Tom de Vries  <tdevries@suse.de>
6878
6879         PR cli/24587
6880         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6881
6882 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6883
6884         PR gdb/18644:
6885         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6886         16-byte floats.
6887         * i386-tdep.c (i386_floatformat_for_type): Use
6888         floatformats_ia64_quad for the 16-byte floating point component
6889         within a fortran 32-byte complex number.
6890
6891 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6892
6893         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6894         delete default constructor.
6895         (find_partial_die): Update to return const struct.
6896         (partial_die_parent_scope): Move variable declaration into scope
6897         of its use and change its type to auto.
6898         (guess_partial_die_structure_name): Likewise.
6899         (partial_die_info::fixup): Likewise.
6900
6901 2019-05-17  Tom Tromey  <tromey@adacore.com>
6902
6903         * source.c (find_and_open_source): Remove cast.
6904
6905 2019-05-17  Tom Tromey  <tromey@adacore.com>
6906
6907         * annotate.c (annotate_source): Make "filename" const.
6908         * annotate.h (annotate_source): Use const.
6909
6910 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6911
6912         * disasm.c (set_disassembler_options): Send errors to stderr.
6913
6914 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6915
6916         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6917         (cli_interp_base::set_logging): Check debug_redirect.
6918         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6919         * cli/cli-logging.c (debug_redirect): Add static variable.
6920         (pop_output_files): Add default param.
6921         (handle_redirections): Print debug setting.
6922         (show_logging_command): Likewise.
6923         (_initialize_cli_logging): Add debugredirect command.
6924         * interps.c (current_interp_set_logging): Add debug_redirect
6925         parameter.
6926         * interps.h (set_logging): Add debug_redirect parameter.
6927         (current_interp_set_logging): Likewise.
6928         * mi/mi-common.h: Likewise.
6929         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6930
6931 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6932             Tom Tromey  <tromey@adacore.com>
6933
6934         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6935         directly.
6936         * cli/cli-interp.h (make_logging_output): Remove declaration.
6937         * cli/cli-logging.c (make_logging_output): Remove function.
6938         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6939         directly.
6940         * ui-file.c (tee_file::tee_file): Remove bools.
6941         (tee_file::~tee_file): Remove deletes.
6942         * ui-file.h (tee_file): Remove bools.
6943
6944 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6945
6946         * mi/mi-cmds.h (mi_cmd_complete): New function.
6947         * mi/mi-main.c (mi_cmd_complete): Likewise.
6948         * mi/mi-cmds.c: Define new MI command -complete.
6949         * NEWS: Mention new -complete command.
6950
6951 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6952
6953         * completer.h (complete): New function.
6954         * completer.c (complete): Likewise.
6955         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6956         function defined in completer.h.
6957
6958 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6959
6960         * MAINTAINERS (Write After Approval): Add myself.
6961
6962 2019-05-17  Tom de Vries  <tdevries@suse.de>
6963
6964         PR gdb/24094
6965         * dwarf2read.c (struct cu_partial_die_info): New struct.
6966         (find_partial_die): Return cu_partial_die_info.
6967         (partial_die_parent_scope, guess_partial_die_structure_name)
6968         (partial_die_info::fixup): Handle new return type of find_partial_die.
6969
6970 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6971
6972         PR breakpoints/24541
6973         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6974         "std::string", simplifying the algorithm.
6975
6976 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6977
6978         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6979         (stap_static_probe_ops::get_probes): Likewise.
6980
6981 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6982
6983         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6984         '-')" and "else if".
6985         (stap_parse_single_operand): Join checks for
6986         "gdbarch_stap_parse_special_token_p" and
6987         "gdbarch_stap_parse_special_token" in the same "if" statement.
6988         Invert check when verifying for operation on register
6989         displacement.
6990
6991 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6992
6993         * stap-probe.c (stap_get_opcode): Update comment.
6994         (stap_get_expected_argument_type): Likewise.
6995         (handle_stap_probe): Likewise.
6996
6997 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6998
6999         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7000         return type to 'bool'.  Adjust comment.  Use 'bool' when
7001         appropriate.
7002         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7003         * stap-probe.c (stap_parse_argument_1): Likewise.
7004         (stap_is_operator): Likewise.
7005         (stap_is_generic_prefix): Likewise.
7006         (stap_is_register_prefix): Likewise.
7007         (stap_is_register_indirection_prefix): Likewise.
7008         (stap_is_integer_prefix): Likewise.
7009         (stap_generic_check_suffix): Likewise.
7010         (stap_check_integer_suffix): Likewise.
7011         (stap_check_register_suffix): Likewise.
7012         (stap_check_register_indirection_suffix): Likewise.
7013         (stap_parse_register_operand): Likewise.
7014         (stap_parse_single_operand): Likewise.
7015         (stap_parse_argument_1): Likewise.
7016         (stap_probe::get_argument_count): Likewise.
7017         (stap_is_operator): Likewise.
7018
7019 2019-05-16  Tom Tromey  <tromey@adacore.com>
7020
7021         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7022         keyword to foreach.
7023
7024 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7025
7026         * linux-thread-db.c (try_thread_db_load_1): Change return type
7027         to bool.
7028         (try_thread_db_load): Likewise.
7029         (try_thread_db_load_from_pdir_1): Likewise.
7030         (try_thread_db_load_from_pdir): Likewise.
7031         (try_thread_db_load_from_sdir): Likewise.
7032         (try_thread_db_load_from_dir): Likewise.
7033         (thread_db_load_search): Likewise.
7034         (has_libpthread): Likewise.
7035         (thread_db_load): Likewise.
7036
7037 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7038
7039         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7040         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7041         NULL, and complain/return if that's the case.
7042
7043 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7044
7045         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7046         (advance, posn, abstract_read_memory): New functions.
7047         [struct mem_read_abstraction]: New struct.
7048         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7049
7050 2019-05-14  Tom Tromey  <tromey@adacore.com>
7051
7052         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7053         value is not lval_memory.
7054
7055 2019-05-14  Tom Tromey  <tromey@adacore.com>
7056
7057         * solib.c (info_sharedlibrary_command): Style the file name.
7058
7059 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7060
7061         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7062         (aarch64_vnv_type): Likewise.
7063         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7064         * common/tdesc.c: Likewise.
7065         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7066         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7067         * features/aarch64-fpu.xml: Add ieee half view.
7068         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7069         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7070         * gdbtypes.h (struct builtin_type): Likewise.
7071         (struct objfile_type): Likewise.
7072
7073 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7074
7075         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7076         typo.
7077         * location.h (string_to_event_location): Likewise.
7078
7079 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7080
7081         GDB 8.3 released.
7082
7083 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7084
7085         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7086         New variable declaration.
7087         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7088         New variable.
7089         (print_one_breakpoint): Use ui_out::test_flags and new global
7090         variable to compute use_fixed_output.
7091         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7092         Remove.
7093         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7094         (mi_multi_location_breakpoint_output_fixed): Remove.
7095         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7096         new variable.
7097         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7098         fix_multi_location_breakpoint_output flag if version >= 3.
7099         * ui-out.h (enum ui_out_flag)
7100         <fix_multi_location_breakpoint_output>: New enumerator.
7101
7102 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7103
7104         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7105
7106 2019-05-10  Tom Tromey  <tromey@adacore.com>
7107
7108         * ada-lang.c (catch_ada_completer): New function.
7109         (_initialize_ada_language): Use it.
7110
7111 2019-05-10  Tom Tromey  <tromey@adacore.com>
7112
7113         * thread.c (print_thread_info): Make "requested_threads" const.
7114         * gdbthread.h (print_thread_info): Make "requested_threads"
7115         const.
7116         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7117         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7118
7119 2019-05-08  Tom Tromey  <tom@tromey.com>
7120
7121         * gdbtypes.c (objfile_type_data): Change type.
7122         (objfile_type, _initialize_gdbtypes): Update.
7123
7124 2019-05-08  Tom Tromey  <tom@tromey.com>
7125
7126         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7127         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7128         (_initialize_dwarf2_frame): Update.
7129
7130 2019-05-08  Tom Tromey  <tom@tromey.com>
7131
7132         * objc-lang.c (objc_objfile_data): Change type.
7133         (find_methods): Update.
7134         (_initialize_objc_lang): Remove.
7135
7136 2019-05-08  Tom Tromey  <tom@tromey.com>
7137
7138         * stabsread.c (rs6000_builtin_type_data): Change type.
7139         (rs6000_builtin_type, _initialize_stabsread): Update.
7140
7141 2019-05-08  Tom Tromey  <tom@tromey.com>
7142
7143         * mips-tdep.c (mips_pdr_data): Remove.
7144         (_initialize_mips_tdep): Update.
7145
7146 2019-05-08  Tom Tromey  <tom@tromey.com>
7147
7148         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7149         (hppa_init_objfile_priv_data, read_unwind_info)
7150         (find_unwind_entry, _initialize_hppa_tdep): Update.
7151
7152 2019-05-08  Tom Tromey  <tom@tromey.com>
7153
7154         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7155         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7156         on obstack.
7157         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7158
7159 2019-05-08  Tom Tromey  <tom@tromey.com>
7160
7161         * mdebugread.c (basic_type_data): Change type.
7162         (basic_type, _initialize_mdebugread): Update.
7163
7164 2019-05-08  Tom Tromey  <tom@tromey.com>
7165
7166         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7167
7168 2019-05-08  Tom Tromey  <tom@tromey.com>
7169
7170         * nto-tdep.c (nto_inferior_data_reg): Change type.
7171         (nto_inferior_data): Update.
7172         (nto_inferior_data_cleanup, nto_new_inferior_data)
7173         (_initialize_nto_tdep): Remove.
7174         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7175
7176 2019-05-08  Tom Tromey  <tom@tromey.com>
7177
7178         * ada-lang.c (struct ada_inferior_data): Add initializers.
7179         (ada_inferior_data): Change type.
7180         (ada_inferior_data_cleanup): Remove.
7181         (get_ada_inferior_data, ada_inferior_exit)
7182         (struct ada_pspace_data): Add initializers, destructor.
7183         (ada_pspace_data_handle): Change type.
7184         (get_ada_pspace_data): Update.
7185         (ada_pspace_data_cleanup): Remove.
7186
7187 2019-05-08  Tom Tromey  <tom@tromey.com>
7188
7189         * coffread.c (struct coff_symfile_info): Add initializers.
7190         (coff_objfile_data_key): Move lower.  Change type.
7191         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7192         Update.
7193         (coff_free_info): Remove.
7194
7195 2019-05-08  Tom Tromey  <tom@tromey.com>
7196
7197         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7198         (fbsd_pspace_data_handle): Move lower.  Change type.
7199         (get_fbsd_pspace_data): Update.
7200         (fbsd_pspace_data_cleanup): Remove.
7201         (_initialize_fbsd_tdep): Update.
7202
7203 2019-05-08  Tom Tromey  <tom@tromey.com>
7204
7205         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7206         (get_ada_tasks_pspace_data): Update.
7207         (ada_tasks_pspace_data_cleanup): Remove.
7208         (_initialize_tasks): Update.
7209         (ada_tasks_inferior_data_handle): Change type.
7210         (get_ada_tasks_inferior_data): Update.
7211         (ada_tasks_inferior_data_cleanup): Remove.
7212         (struct ada_tasks_pspace_data): Add initializers.
7213
7214 2019-05-08  Tom Tromey  <tom@tromey.com>
7215
7216         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7217         * symfile-debug.c (debug_sym_get_probes): Change type.
7218         * stap-probe.c (handle_stap_probe):
7219         (stap_static_probe_ops::get_probes): Change type.
7220         * probe.h (class static_probe_ops) <get_probes>: Change type.
7221         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7222         (parse_probes_in_pspace): Update.
7223         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7224         Update.
7225         (any_static_probe_ops::get_probes): Change type.
7226         * elfread.c (elfread_data): New typedef.
7227         (probe_key): Change type.
7228         (elf_get_probes): Likewise.  Update.
7229         (probe_key_free): Remove.
7230         (_initialize_elfread): Update.
7231         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7232         Change type.
7233         (dtrace_process_dof_probe, dtrace_process_dof)
7234         (dtrace_static_probe_ops::get_probe): Change type.
7235
7236 2019-05-08  Tom Tromey  <tom@tromey.com>
7237
7238         * xcoffread.c (struct xcoff_symfile_info): Rename from
7239         coff_symfile_info.  Add initializers.
7240         (xcoff_objfile_data_key): Move lower.  Change type.
7241         (XCOFF_DATA): Rewrite.
7242         (xcoff_free_info): Remove.
7243         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7244         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7245         (xcoff_initial_scan): Update.
7246
7247 2019-05-08  Tom Tromey  <tom@tromey.com>
7248
7249         * solib-svr4.c (struct svr4_info): Add initializers and
7250         destructor.
7251         <probes_table>: Now an htab_up.
7252         (solib_svr4_pspace_data): Change type.
7253         (free_probes_table): Simplify.
7254         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7255         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7256         (probes_table_remove_objfile_probes, register_solib_event_probe)
7257         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7258         (_initialize_svr4_solib): Update.
7259
7260 2019-05-08  Tom Tromey  <tom@tromey.com>
7261
7262         * remote.c (remote_pspace_data): Change type.
7263         (remote_pspace_data_cleanup): Remove.
7264         (get_remote_exec_file, set_pspace_remote_exec_file)
7265         (_initialize_remote): Update.
7266
7267 2019-05-08  Tom Tromey  <tom@tromey.com>
7268
7269         * breakpoint.c (breakpoint_objfile_key): Change type.
7270         (get_breakpoint_objfile_data): Update.
7271         (free_breakpoint_objfile_data): Remove.
7272         (_initialize_breakpoint): Update.
7273
7274 2019-05-08  Tom Tromey  <tom@tromey.com>
7275
7276         * linux-tdep.c (struct linux_info): Add initializers.
7277         (linux_inferior_data): Move.  Change type.
7278         (invalidate_linux_cache_inf): Update.
7279         (linux_inferior_data_cleanup): Remove.
7280         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7281
7282 2019-05-08  Tom Tromey  <tom@tromey.com>
7283
7284         * auxv.c (auxv_inferior_data): Move.  Change type.
7285         (auxv_inferior_data_cleanup): Remove.
7286         (invalidate_auxv_cache_inf): Rewrite.
7287         (get_auxv_inferior_data, _initialize_auxv): Update.
7288
7289 2019-05-08  Tom Tromey  <tom@tromey.com>
7290
7291         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7292         (symfile_debug_objfile_data_key): Change type.
7293         (symfile_debug_installed, debug_qf_has_symbols)
7294         (debug_qf_find_last_source_symtab)
7295         (debug_qf_forget_cached_source_info)
7296         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7297         (debug_qf_print_stats, debug_qf_dump)
7298         (debug_qf_expand_symtabs_for_function)
7299         (debug_qf_expand_all_symtabs)
7300         (debug_qf_expand_symtabs_with_fullname)
7301         (debug_qf_map_matching_symbols)
7302         (debug_qf_expand_symtabs_matching)
7303         (debug_qf_find_pc_sect_compunit_symtab)
7304         (debug_qf_map_symbol_filenames)
7305         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7306         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7307         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7308         (debug_sym_read_linetable, debug_sym_relocate): Update.
7309         (symfile_debug_free_objfile): Remove.
7310         (install_symfile_debug_logging, _initialize_symfile_debug):
7311         Update.
7312
7313 2019-05-08  Tom Tromey  <tom@tromey.com>
7314
7315         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7316         allocate_on_obstack.
7317         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7318         (get_dwarf2_per_objfile): Update.
7319         (set_dwarf2_per_objfile): Remove.
7320         (dwarf2_has_info, dwarf2_get_section_info): Update.
7321         (dwarf2_free_objfile): Remove.
7322         (_initialize_dwarf2_read): Update.
7323
7324 2019-05-08  Tom Tromey  <tom@tromey.com>
7325
7326         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7327         initializers.
7328         <unsupported_script_warning_printed,
7329         script_not_found_warning_printed>: Now bool.
7330         (auto_load_pspace_data): Change type.
7331         (~auto_load_pspace_info): Rename from
7332         auto_load_pspace_data_cleanup.
7333         (get_auto_load_pspace_data, init_loaded_scripts_info)
7334         (clear_section_scripts, maybe_print_unsupported_script_warning)
7335         (maybe_print_script_not_found_warning, _initialize_auto_load):
7336         Update.
7337
7338 2019-05-08  Tom Tromey  <tom@tromey.com>
7339
7340         * objfiles.c (objfile_pspace_info): Add destructor and
7341         initializers.
7342         (objfiles_pspace_data): Change type.
7343         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7344         (get_objfile_pspace_data): Update.
7345         (objfiles_bfd_data): Change type.
7346         (get_objfile_bfd_data): Update.
7347         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7348
7349 2019-05-08  Tom Tromey  <tom@tromey.com>
7350
7351         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7352         Change type.
7353         (get_catch_syscall_inferior_data): Update.
7354         (catch_syscall_inferior_data_cleanup): Remove.
7355         (_initialize_break_catch_syscall): Update.
7356
7357 2019-05-08  Tom Tromey  <tom@tromey.com>
7358
7359         * inflow.c (struct terminal_info): Add destructor and
7360         initializers.
7361         (inflow_inferior_data): Change type.
7362         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7363         (get_inflow_inferior_data, inflow_inferior_exit)
7364         (swap_terminal_info, _initialize_inflow): Update.
7365
7366 2019-05-08  Tom Tromey  <tom@tromey.com>
7367
7368         * target-dcache.c (target_dcache_cleanup): Remove.
7369         (target_dcache_aspace_key): Change type.
7370         (target_dcache_init_p, target_dcache_invalidate)
7371         (target_dcache_get, target_dcache_get_or_init)
7372         (_initialize_target_dcache): Update.
7373         * dcache.h (struct dcache_deleter): New.
7374
7375 2019-05-08  Tom Tromey  <tom@tromey.com>
7376
7377         * symtab.c (struct symbol_cache): Add destructor and
7378         initializers.
7379         (symbol_cache_key): Move.  Change type.
7380         (make_symbol_cache, free_symbol_cache): Remove.
7381         (get_symbol_cache): Update.
7382         (symbol_cache_cleanup): Remove.
7383         (ALL_PSPACES, symbol_cache_flush)
7384         (maintenance_print_symbol_cache)
7385         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7386         Update.
7387
7388 2019-05-08  Tom Tromey  <tom@tromey.com>
7389
7390         * symtab.c (struct main_info): Add destructor and initializers.
7391         (main_progspace_key): Move.  Change type.
7392         (get_main_info): Update.
7393         (main_info_cleanup): Remove.
7394         (_initialize_symtab): Update.
7395
7396 2019-05-08  Tom Tromey  <tom@tromey.com>
7397
7398         * registry.h (DECLARE_REGISTRY): Define the _key class.
7399
7400 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7401
7402         * NEWS: Merge two 'New commands' sections.
7403
7404 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7405
7406         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7407         parameter and use Ada language definition instead.
7408         (ada_val_print_ptr): Remove unused language parameter.
7409         (ada_val_print_num): Remove language parameter and use Ada language
7410         definition instead.
7411         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7412         parameter.
7413         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7414         parameter and use Ada language definition instead.
7415         (ada_val_print_1): Update all ada_val_print_xxx calls.
7416         Remove language parameter.
7417         (ada_val_print): Update ada_val_print_1 call.
7418
7419 2019-05-08  Tom Tromey  <tromey@adacore.com>
7420
7421         * remote.c (remote_hw_watchpoint_limit)
7422         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7423         Now static.
7424
7425 2019-05-08  Tom Tromey  <tromey@adacore.com>
7426
7427         * maint.c (_initialize_maint_cmds): Move initialization code to
7428         remote.c.
7429         (watchdog, show_watchdog): Move to remote.c.
7430         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7431         "watchdog" static.
7432         (_initialize_remote): Move initialization code from maint.c.
7433         * defs.h (watchdog): Don't declare.
7434
7435 2019-05-08  Tom Tromey  <tromey@adacore.com>
7436
7437         * tui/tui-interp.c: Include main.h.
7438         * interps.c: Include main.h.
7439         * main.h (interpreter_p): Declare.
7440         * defs.h (interpreter_p): Don't declare.
7441
7442 2019-05-08  Tom Tromey  <tromey@adacore.com>
7443
7444         * dwarf2loc.c: Include dwarf2read.h.
7445         * defs.h (read_unsigned_leb128): Don't declare.
7446         * dwarf2read.h (read_unsigned_leb128): Declare.
7447
7448 2019-05-08  Tom Tromey  <tromey@adacore.com>
7449
7450         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7451         method.
7452
7453 2019-05-08  Tom Tromey  <tromey@adacore.com>
7454
7455         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7456         when no wrap column is set.
7457
7458 2019-05-08  Tom Tromey  <tromey@adacore.com>
7459
7460         * c-lang.c (c_get_string): Handle non-C-style arrays.
7461
7462 2019-05-08  Tom Tromey  <tromey@adacore.com>
7463
7464         * typeprint.c (print_offset_data::update): Print the bit offset,
7465         not the number of bits remaining.
7466
7467 2019-05-08  Tom Tromey  <tromey@adacore.com>
7468
7469         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7470         padding at end of comment.
7471
7472 2019-05-08  Tom Tromey  <tromey@adacore.com>
7473
7474         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7475         Compare main types.
7476
7477 2019-05-06  Tom Tromey  <tom@tromey.com>
7478
7479         * common/scoped_mmap.c: Include common-defs.h.
7480         * common/scoped_mmap.h: Don't include config.h.
7481
7482 2019-05-04  Tom Tromey  <tom@tromey.com>
7483
7484         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7485         (struct aarch64_call_info): Add initializers.
7486         <si>: Now a std::vector.
7487         (pass_on_stack, aarch64_push_dummy_call): Update.
7488
7489 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7490             Tom Tromey  <tom@tromey.com>
7491
7492         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7493         (ppc_threads): Now a std::vector.  Now static.
7494         (hwdebug_find_thread_points_by_tid)
7495         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7496         Update.
7497
7498 2019-05-04  Tom Tromey  <tom@tromey.com>
7499
7500         * arc-tdep.c (arc_tdesc_init): Return bool.
7501
7502 2019-05-04  Tom Tromey  <tom@tromey.com>
7503
7504         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7505         Use gdb_assert_not_reached.
7506
7507 2019-05-04  Tom Tromey  <tom@tromey.com>
7508
7509         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7510         "false".
7511
7512 2019-05-04  Tom Tromey  <tom@tromey.com>
7513
7514         * arc-tdep.c (arc_tdesc_init): Use bool.
7515
7516 2019-05-04  Tom Tromey  <tom@tromey.com>
7517
7518         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7519
7520 2019-05-04  Tom Tromey  <tom@tromey.com>
7521
7522         * cli/cli-cmds.c (valid_command_p): Return bool.
7523
7524 2019-05-04  Tom Tromey  <tom@tromey.com>
7525
7526         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7527         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7528
7529 2019-05-04  Raul Tambre  <raul@tambre.ee>
7530
7531         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7532         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7533         operator for comparison.
7534
7535 2019-05-04  Tom Tromey  <tom@tromey.com>
7536
7537         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7538         (lookup_partial_symbol, print_partial_symbols)
7539         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7540         (psymbol_compare): Update.
7541         (add_psymbol_to_bcache): Clear the entire psymbol.
7542         (maintenance_check_psymtabs): Update.
7543         * psympriv.h (struct partial_symbol): Don't derive from
7544         general_symbol_info.
7545         <obj_section, unrelocated_address, address,
7546         set_unrelocated_address>: Update.
7547         <ginfo>: New member.
7548         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7549         (debug_names::write_psymbols): Update.
7550
7551 2019-05-04  Tom de Vries  <tdevries@suse.de>
7552
7553         * contrib/cc-with-tweaks.sh: Support -n arg.
7554
7555 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7556
7557         * corelow.c (core_target::detach): Ensure frame cache and
7558         register caches are cleared.
7559         inferior.c (exit_inferior_1): Likewise.
7560
7561 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7562             Tom Tromey  <tom@tromey.com>
7563
7564         * dictionary.c (collate_pending_symbols_by_language): Remove
7565         "struct" from foreach.
7566         * symtab.c (lookup_global_symbol_from_objfile)
7567         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7568         foreach.
7569         * ser-tcp.c (net_open): Remove "struct" from foreach.
7570         * objfiles.c (objfile_relocate, objfile_rebase)
7571         (objfile_has_symbols): Remove "struct" from foreach.
7572         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7573         from foreach.
7574         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7575         foreach.
7576         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7577         "struct" from foreach.
7578         * ada-lang.c (create_excep_cond_exprs)
7579         (ada_exception_catchpoint_cond_string): Remove "struct" from
7580         foreach.
7581
7582 2019-05-03  Tom Tromey  <tromey@adacore.com>
7583
7584         * ada-exp.y (convert_char_literal): Check suffix of each
7585         enumerator.
7586
7587 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7588
7589         PR ada/21406:
7590         * ada-exp.y (yywrap): Don't define.
7591         * ada-lex.l (%option): Add noyywrap
7592         (yywrap): Remove.
7593
7594 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7595
7596         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7597         _WIN32_WINNT to the XP level, unless already defined to a higher
7598         level.
7599
7600         * unittests/parse-connection-spec-selftests.c:
7601         * ser-tcp.c:
7602         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7603         override.
7604
7605         * symfile.c (find_separate_debug_file): Remove colon from the
7606         drive spec of DOS/Windows file names of the target, so that the
7607         file name produced from DEBUGDIR and the target's directory will
7608         be valid on DOS/Windows systems.
7609
7610 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7611
7612         * rust-lang.c (val_print_struct): Handle printing structures
7613         containing strings.
7614
7615 2019-05-02  Tom Tromey  <tromey@adacore.com>
7616
7617         * valarith.c (_initialize_valarith): Remove.
7618
7619 2019-05-01  Tom Tromey  <tromey@adacore.com>
7620
7621         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7622         bitfields.
7623
7624 2019-05-01  Tom Tromey  <tromey@adacore.com>
7625
7626         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7627         for big-endian copies.
7628
7629 2019-04-30  Ali Tamur  <tamur@google.com>
7630         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7631         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7632         (read_3_bytes): New function.
7633
7634 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7635
7636         * windows-nat.c (main_thread_id): Delete.
7637         (handle_output_debug_string): Replace main_thread_id by
7638         current_event.dwThreadId.
7639         (fake_create_process): Likewise.
7640         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7641         Do not set main_thread_id.
7642         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7643         current_event.dwThreadId.
7644         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7645
7646 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7647
7648         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7649         Use current_event.dwThreadId instead of main_thread_id.
7650
7651 2019-04-30  Tom Tromey  <tromey@adacore.com>
7652
7653         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7654         (create_excep_cond_exprs): Iterate over program spaces.
7655         (ada_exception_catchpoint_cond_string): Examine all minimal
7656         symbols for exception types.
7657
7658 2019-04-30  Tom Tromey  <tromey@adacore.com>
7659
7660         PR c++/24470:
7661         * dwarf2read.c (process_structure_scope): Handle case where type
7662         has template parameters but no symbol was created.
7663
7664 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7665             Chris January  <chris.january@arm.com>
7666
7667         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7668         qualifier.
7669         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7670
7671 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7672
7673         * f-typeprint.c (f_print_type): Update rules for printing
7674         whitespace.
7675         (f_type_print_varspec_suffix): Likewise.
7676
7677 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7678             Chris January  <chris.january@arm.com>
7679
7680         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7681         function arguments.
7682
7683 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7684
7685         * f-lang.c (build_fortran_types): Change name of void type to
7686         lower case.
7687         * f-typeprint.c (f_type_print_base): Print the name of the void
7688         type, rather than a fixed string.
7689         * f-valprint.c (f_decorations): Use lower case void string.
7690
7691 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7692             Chris January  <chris.january@arm.com>
7693
7694         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7695         types for Fortran.
7696
7697 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7698             Chris January  <chris.january@arm.com>
7699             David Lecomber  <david.lecomber@arm.com>
7700
7701         * f-exp.y (BINOP_INTRINSIC): New token.
7702         (exp): New parser rule handling BINOP_INTRINSIC.
7703         (f77_keywords): Add new builtin procedures.
7704         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7705         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7706         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7707         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7708         (print_unop_subexp_f): New function.
7709         (print_binop_subexp_f): New function.
7710         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7711         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7712         (dump_subexp_body_f): Likewise.
7713         (operator_check_f): Likewise.
7714         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7715         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7716
7717 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7718
7719         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7720         UNOP_KIND.
7721         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7722         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7723         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7724         (operator_length_f): New fuction.
7725         (print_subexp_f): New function.
7726         (op_name_f): New function.
7727         (dump_subexp_body_f): New function.
7728         (operator_check_f): New function.
7729         (exp_descriptor_f): Replace standard expression handling functions
7730         with new functions.
7731         * gdb/fortran-operator.def: New file.
7732         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7733         * gdb/std-operator.def: Remove UNOP_KIND.
7734
7735 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7736
7737         * std-operator.def: Remove unbalanced, stray double quote
7738         character.
7739
7740 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7741             Chris January  <chris.january@arm.com>
7742             Daniel Everett  <daniel.everett@arm.com>
7743             Nick Forrington  <nick.forrington@arm.com>
7744             Richard Bunt  <richard.bunt@arm.com>
7745
7746         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7747         of depth when printing anonymous structs or unions.
7748         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7749         Don't print either the top-level value, or the children if the
7750         max-depth is exceeded.
7751         (ppscm_print_children): When printing the key of a map, allow one
7752         extra level of depth.
7753         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7754         print either the top-level value, or the children if the max-depth
7755         is exceeded.
7756         (print_children): When printing the key of a map, allow one extra
7757         level of depth.
7758         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7759         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7760         (user_print_options): Initialise max_depth field.
7761         (val_print_scalar_or_string_type_p): New function.
7762         (val_print): Check to see if the max depth has been reached.
7763         (val_print_check_max_depth): Define new function.
7764         (show_print_max_depth): New function.
7765         (_initialize_valprint): Add 'print max-depth' option.
7766         * valprint.h (struct value_print_options) <max_depth>: New field.
7767         (val_print_check_max_depth): Declare new function.
7768         * NEWS: Document new feature.
7769
7770 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7771
7772         * ada-lang.c (ada_language_defn): Initialise new field.
7773         * c-lang.c (c_is_string_type_p): New function.
7774         (c_language_defn): Initialise new field.
7775         (cplus_language_defn): Initialise new field.
7776         (asm_language_defn): Initialise new field.
7777         (minimal_language_defn): Initialise new field.
7778         * c-lang.h (c_is_string_type_p): Declare new function.
7779         * d-lang.c (d_language_defn): Initialise new field.
7780         * f-lang.c (f_is_string_type_p): New function.
7781         (f_language_defn): Initialise new field.
7782         * go-lang.c (go_is_string_type_p): New function.
7783         (go_language_defn): Initialise new field.
7784         * language.c (default_is_string_type_p): New function.
7785         (unknown_language_defn): Initialise new field.
7786         (auto_language_defn): Initialise new field.
7787         * language.h (struct language_defn) <la_is_string_type_p>: New
7788         member variable.
7789         (default_is_string_type_p): Declare new function.
7790         * m2-lang.c (m2_language_defn): Initialise new field.
7791         * objc-lang.c (objc_language_defn): Initialise new field.
7792         * opencl-lang.c (opencl_language_defn): Initialise new field.
7793         * p-lang.c (pascal_is_string_type_p): New function.
7794         (pascal_language_defn): Initialise new field.
7795         * rust-lang.c (rust_is_string_type_p): New function.
7796         (rust_language_defn): Initialise new field.
7797
7798 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7799
7800         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7801         New field.
7802         * ada-lang.c (ada_language_defn): Initialise new field.
7803         * c-lang.c (c_language_defn): Likewise.
7804         (cplus_language_defn): Likewise.
7805         (asm_language_defn): Likewise.
7806         (minimal_language_defn): Likewise.
7807         * d-lang.c (d_language_defn): Likewise.
7808         * f-lang.c (f_language_defn): Likewise.
7809         * go-lang.c (go_language_defn): Likewise.
7810         * language.c (unknown_language_defn): Likewise.
7811         (auto_language_defn): Likewise.
7812         * m2-lang.c (m2_language_defn): Likewise.
7813         * objc-lang.c (objc_language_defn): Likewise.
7814         * opencl-lang.c (opencl_language_defn): Likewise.
7815         * p-lang.c (pascal_language_defn): Likewise.
7816         * rust-lang.c (rust_language_defn): Likewise.
7817
7818 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7819
7820         * ada-lang.c (ada_is_character_type): Change return type to bool.
7821         (ada_is_string_type): Likewise.
7822         * ada-lang.h (ada_is_character_type): Update declaration
7823         (ada_is_string_type): Likewise.
7824
7825 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7826
7827         Support style in 'frame|thread apply'
7828
7829         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7830         * record.c (record_start, record_stop): Update callers of
7831         execute_command_to_string with false.
7832         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7833         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7834         methods.
7835         (class string_file): New constructor with term_out parameter.
7836         Override methods term_out and can_emit_style_escape.  New member
7837         term_out.
7838         (class stdio_file): Override can_emit_style_escape.
7839         (class tee_file): Override term_out and can_emit_style_escape.
7840         * utils.h (can_emit_style_escape): Remove.
7841         * utils.c (can_emit_style_escape): Likewise.
7842         Update all callers of can_emit_style_escape (SOMESTREAM) to
7843         SOMESTREAM->can_emit_style_escape.
7844         * source-cache.c (source_cache::get_source_lines): Likewise.
7845         * stack.c (frame_apply_command_count): Call execute_command_to_string
7846         passing the term_out characteristic of the current gdb_stdout.
7847         * thread.c (thr_try_catch_cmd): Likewise.
7848         * top.c (execute_command_to_string): pass term_out parameter
7849         to construct the string_file for the command output.
7850         * ui-file.c (term_cli_styling): New function (most code moved
7851         from utils.c can_emit_style_escape).
7852         (string_file::string_file, string_file::can_emit_style_escape,
7853         stdio_file::can_emit_style_escape, tee_file::term_out,
7854         tee_file::can_emit_style_escape): New functions.
7855
7856 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7857
7858         * NEWS: Mention the new set|show may-call-functions.
7859         * infcall.c (may_call_functions_p): New variable.
7860         (show_may_call_functions_p): New function.
7861         (call_function_by_hand_dummy): Throws an error if not
7862         may-call-functions.
7863         (_initialize_infcall): Call add_setshow_boolean_cmd for
7864         may-call-functions.
7865
7866 2019-04-25  Keith Seitz  <keiths@redhat.com>
7867
7868         PR c++/24367
7869         * cp-support.c (inspect_type): Don't attempt substitutions
7870         of symbol with the same name.
7871
7872 2019-04-25  Tom Tromey  <tromey@adacore.com>
7873
7874         PR gdb/24475:
7875         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7876         static.
7877
7878 2019-04-25  Tom Tromey  <tromey@adacore.com>
7879
7880         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7881         rvalue reference.
7882         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7883         (gdb_xml_parser::parse): Use std::move.
7884         * python/python-internal.h (gdbpy_convert_exception): Take a const
7885         reference.
7886         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7887         std::move.
7888         * python/py-utils.c (gdbpy_convert_exception): Take a const
7889         reference.
7890         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7891         Use std::move.
7892         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7893         Use std::move.
7894         * mi/mi-main.c (mi_print_exception): Take a const reference.
7895         * main.c (handle_command_errors): Take a const reference.
7896         * linespec.c (parse_linespec): Use std::move.
7897         * infcall.c (run_inferior_call): Use std::move.
7898         (call_function_by_hand_dummy): Use std::move.
7899         * exec.c (try_open_exec_file): Use std::move.
7900         * exceptions.h (exception_print, exception_fprintf)
7901         (exception_print_same): Update.
7902         * exceptions.c (print_exception, exception_print)
7903         (exception_fprintf, exception_print_same): Change parameters to
7904         const reference.
7905         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7906         * common/new-op.c: Use std::move.
7907         * common/common-exceptions.h (struct gdb_exception): Add move
7908         constructor.
7909         (struct gdb_exception_error, struct gdb_exception_quit, struct
7910         gdb_quit_bad_alloc): Change constructor to move constructor.
7911         (throw_exception): Change parameter to rvalue reference.
7912         * common/common-exceptions.c (throw_exception): Take rvalue
7913         reference.
7914         * cli/cli-interp.c (safe_execute_command): Use std::move.
7915         * breakpoint.c (insert_bp_location, location_to_sals): Use
7916         std::move.
7917
7918 2019-04-25  Tom Tromey  <tromey@adacore.com>
7919
7920         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7921         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7922         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7923         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7924         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7925         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7926         guile/scm-value.c: Use unpack.
7927         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7928         gdbscm_gdb_exception.
7929         (gdbscm_throw_gdb_exception): Likewise.
7930         (struct gdbscm_gdb_exception): New.
7931         (unpack): New function.
7932         (gdbscm_wrap): Use unpack.
7933
7934 2019-04-25  Tom Tromey  <tromey@adacore.com>
7935
7936         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7937         (gdb_rl_callback_handler): Use std::move.
7938         * common/common-exceptions.h (struct gdb_exception): Add move
7939         assignment operator.
7940         (throw_exception_sjlj): Change "exception" to const reference.
7941         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7942         (throw_exception_sjlj): Change "exception" to const reference.
7943
7944 2019-04-25  Tom Tromey  <tromey@adacore.com>
7945
7946         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7947         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7948         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7949         Update.
7950         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7951         Update.
7952         * mi/mi-interp.c (mi_interp::exec): Update.
7953         * linespec.c (parse_linespec): Update.
7954         * infcall.c (run_inferior_call): Update.
7955         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7956         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7957         (gdbscm_lookup_global_symbol): Update.
7958         * guile/scm-param.c (gdbscm_parameter_value): Update.
7959         * guile/scm-frame.c (gdbscm_frame_read_register)
7960         (gdbscm_frame_read_var): Update.
7961         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7962         * exec.c (try_open_exec_file): Update.
7963         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7964         (gdb_rl_callback_handler): Update.
7965         * common/common-exceptions.h (exception_none): Don't declare.
7966         * common/common-exceptions.c (exception_none): Don't define.
7967         (struct catcher) <exception>: Update.
7968         * cli/cli-interp.c (safe_execute_command): Update.
7969         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7970
7971 2019-04-25  Ali Tamur  <tamur@google.com>
7972
7973         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7974         (read_attribute_value): Likewise.
7975         (dwarf2_read_addr_index): Update comment.
7976         (read_str_index): Add DW_FORM_strx.
7977         (dwarf2_string_attr): Likewise.
7978         (dwarf2_const_value_attr): Likewise.
7979         (dump_die_shallow): Likewise.
7980         (dwarf2_fetch_constant_bytes): Likewise.
7981         (skip_form_bytes): Likewise.
7982         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7983
7984 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7985
7986         PR corefiles/11608
7987         PR corefiles/18187
7988         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7989         OFFSET.  Verify if current mapping contains an ELF header.
7990         (linux_find_memory_regions_full): Adjust call to
7991         dump_mapping_p.
7992
7993 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7994             Kang Li <kanglictf@gmail.com>
7995
7996         PR gdb/21600
7997
7998         * dwarf2-frame.c (read_initial_length): Be consistent about using
7999         unsigned representation of length.
8000         (decode_frame_entry_1): Likewise.  Check for wraparound of
8001         end pointer as well as buffer overflow.
8002
8003 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8004
8005         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8006         "vq".
8007
8008 2019-04-24  Tom Tromey  <tromey@adacore.com>
8009
8010         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8011
8012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8013
8014         * s12z-tdep.c (s12z_unwind_pc): Delete.
8015         (s12z_unwind_sp): Delete.
8016         (s12z_gdbarch_init): Don't register deleted functions with
8017         gdbarch.
8018
8019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8020
8021         * rl78-tdep.c (rl78_unwind_sp): Delete.
8022         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8023
8024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8025
8026         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8027         (xstormy16_unwind_pc): Delete.
8028         (xstormy16_dummy_id): Delete.
8029         (xstormy16_gdbarch_init): Don't register deleted functions with
8030         gdbarch.
8031
8032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8033
8034         * vax-tdep.c (vax_unwind_pc): Delete.
8035         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8036
8037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8038
8039         * v850-tdep.c (v850_unwind_sp): Delete.
8040         (v850_unwind_pc): Delete.
8041         (v850_dummy_id): Delete.
8042         (v850_gdbarch_init): Don't register deleted functions with
8043         gdbarch.
8044
8045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8046
8047         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8048         (tilegx_unwind_pc): Delete.
8049         (tilegx_unwind_dummy_id): Delete.
8050         (tilegx_gdbarch_init): Don't register deleted functions with
8051         gdbarch.
8052
8053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8054
8055         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8056         (tic6x_dummy_id): Delete.
8057         (tic6x_gdbarch_init): Don't register deleted functions with
8058         gdbarch.
8059
8060 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8061
8062         * sparc-tdep.c (sparc_unwind_pc): Delete.
8063         (sparc32_gdbarch_init): Don't register deleted function with
8064         gdbarch.
8065
8066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8067
8068         * sh-tdep.c (sh_unwind_sp): Delete.
8069         (sh_unwind_pc): Delete.
8070         (sh_dummy_id): Delete.
8071         (sh_gdbarch_init): Don't register deleted functions with
8072         gdbarch.
8073
8074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8075
8076         * score-tdep.c (score_unwind_sp): Delete.
8077         (score_unwind_pc): Delete.
8078         (score_dummy_id): Delete.
8079         (score_gdbarch_init): Don't register deleted functions with
8080         gdbarch.
8081
8082 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8083
8084         * rx-tdep.c (rx_unwind_pc): Delete.
8085         (rx_unwind_sp): Delete.
8086         (rx_dummy_id): Delete.
8087         (rx_gdbarch_init): Don't register deleted functions with
8088         gdbarch.  Update comment.
8089
8090 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8091
8092         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8093         (rs6000_dummy_id): Delete.
8094         (rs6000_gdbarch_init): Don't register deleted functions with
8095         gdbarch.
8096
8097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8098
8099         * or1k-tdep.c (or1k_dummy_id): Delete.
8100         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8101
8102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8103
8104         * nios2-tdep.c (nios2_dummy_id): Delete.
8105         (nios2_unwind_sp): Delete.
8106         (nios2_gdbarch_init): Don't register deleted functions with
8107         gdbarch.
8108
8109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8110
8111         * nds32-tdep.c (nds32_dummy_id): Delete.
8112         (nds32_unwind_pc): Delete.
8113         (nds32_unwind_sp): Delete.
8114         (nds32_gdbarch_init): Don't register deleted functions with
8115         gdbarch.
8116
8117 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8118
8119         * msp430-tdep.c (msp430_unwind_pc): Delete.
8120         (msp430_unwind_sp): Delete.
8121         (msp430_dummy_id): Delete.
8122         (msp430_gdbarch_init): Don't register deleted functions with
8123         gdbarch.
8124
8125 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8126
8127         * moxie-tdep.c (moxie_unwind_sp): Delete.
8128         (moxie_unwind_pc): Delete.
8129         (moxie_dummy_id): Delete.
8130         (moxie_gdbarch_init): Don't register deleted functions with
8131         gdbarch.
8132
8133 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8134
8135         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8136         (mn10300_unwind_pc): Delete.
8137         (mn10300_unwind_sp): Delete.
8138         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8139         mn10300_unwind_sp.
8140         (mn10300_frame_unwind_init): Don't register deleted functions with
8141         gdbarch.
8142
8143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8144
8145         * mep-tdep.c (mep_unwind_pc): Delete.
8146         (mep_unwind_sp): Delete.
8147         (mep_dummy_id): Delete.
8148         (mep_gdbarch_init): Don't register deleted functions with
8149         gdbarch.
8150
8151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8152
8153         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8154         (m68hc11_unwind_sp): Delete.
8155         (m68hc11_gdbarch_init): Don't register deleted functions with
8156         gdbarch.
8157
8158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8159
8160         * m32r-tdep.c (m32r_unwind_sp): Delete.
8161         (m32r_unwind_pc): Delete.
8162         (m32r_dummy_id): Delete.
8163         (m32r_gdbarch_init): Don't register deleted functions with
8164         gdbarch.
8165
8166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8167
8168         * m32c-tdep.c (m32c_unwind_pc): Delete.
8169         (m32c_unwind_sp): Delete.
8170         (m32c_dummy_id): Delete.
8171         (m32c_gdbarch_init): Don't register deleted functions with
8172         gdbarch.
8173
8174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8175
8176         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8177         (lm32_unwind_pc): Delete.
8178         (lm32_dummy_id): Delete.
8179         (lm32_gdbarch_init): Don't register deleted functions with
8180         gdbarch.
8181
8182 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8183
8184         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8185         (iq2000_unwind_pc): Delete.
8186         (iq2000_dummy_id): Delete.
8187         (iq2000_gdbarch_init): Don't register deleted functions with
8188         gdbarch.
8189
8190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8191
8192         * nds32-tdep.c (nds32_type_align): Delete.
8193         (nds32_push_dummy_call): Use type_align instead.
8194
8195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8196
8197         * arm-tdep.c (arm_type_align): Only handle vector override case.
8198         (arm_push_dummy_call): Use type_align.
8199         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8200
8201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8202
8203         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8204         case.
8205         (pass_on_stack): Use type_align.
8206         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8207         function.
8208
8209 2019-04-23  Tom Tromey  <tromey@adacore.com>
8210
8211         * dwarf2read.c (line_header::file_name_at): Remove unused
8212         overload.
8213
8214 2019-04-23  Tom de Vries  <tdevries@suse.de>
8215
8216         PR gdb/24438
8217         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8218         invocation.
8219
8220
8221 2019-03-27  Ali Tamur  <tamur@google.com>
8222
8223         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8224         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8225         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8226         (dwarf_expr_context::get_addr_index): Likewise
8227         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8228         (symbol_needs_eval_context::get_addr_index): Likewise
8229         (disassemble_dwarf_expression): Add DW_OP_addrx
8230         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8231         (read_cutu_die_from_dwo): Update comment
8232         (skip_one_die): Add DW_FORM_addrx
8233         (read_attribute_value): Likewise
8234         (var_decode_location): Add DW_OP_addrx
8235         (dwarf2_const_value_attr): Add DW_FORM_addrx
8236         (dump_die_shallow): Likewise
8237         (dwarf2_fetch_constant_bytes): Likewise
8238         (decode_locdesc): Add DW_OP_addrx
8239         (skip_form_bytes): Add DW_FORM_addrx
8240
8241 2019-04-22  Ali Tamur  <tamur@google.com>
8242
8243         * MAINTAINERS (Write After Approval): Add self.
8244
8245 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8246
8247         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8248         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8249         (open_symbol_file_object): Likewise.
8250         (svr4_default_sos): Add info parameter.
8251         (svr4_read_so_list): Likewise.
8252         (svr4_current_sos_direct): Adjust functions calls to pass down
8253         info.
8254         (svr4_current_sos_1): Add info parameter.
8255         (svr4_current_sos): Call get_svr4_info, pass info down to
8256         svr4_current_sos_1.
8257         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8258         get_svr4_info.
8259         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8260         get_svr4_info.
8261         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8262         to get_svr4_info.
8263         (probes_table_remove_objfile_probes): Likewise.
8264         (register_solib_event_probe): Add info parameter.
8265         (solist_update_incremental): Pass info parameter down to
8266         svr4_read_so_list.
8267         (disable_probes_interface): Add info parameter.
8268         (svr4_handle_solib_event): Pass current_program_space to
8269         get_svr4_info.  Adjust disable_probes_interface cleanup.
8270         (svr4_create_probe_breakpoints): Add info parameter, pass it
8271         down to register_solib_event_probe.
8272         (svr4_create_solib_event_breakpoints): Add info parameter,
8273         pass it down to svr4_create_probe_breakpoints.
8274         (enable_break): Pass info down to
8275         svr4_create_solib_event_breakpoints.
8276         (svr4_solib_create_inferior_hook): Pass current_program_space to
8277         get_svr4_info.
8278         (svr4_clear_solib): Likewise.
8279
8280 2019-04-22  Pedro Alves  <palves@redhat.com>
8281
8282         * solib-svr4.c (svr4_free_objfile_observer): New.
8283         (probe_and_action::objfile): New field.
8284         (probes_table_htab_remove_objfile_probes)
8285         (probes_table_remove_objfile_probes): New functions.
8286         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8287         in the new probe_and_action.  Don't store the probe in 'lookup'.
8288         (svr4_create_probe_breakpoints): Pass objfile to
8289         register_solib_event_probe.
8290         (_initialize_svr4_solib): Register a free_objfile observer.
8291
8292 2019-04-19  Tom Tromey  <tom@tromey.com>
8293
8294         * common/queue.h: Remove.
8295
8296 2019-04-19  Tom Tromey  <tom@tromey.com>
8297
8298         * event-loop.c: Don't include "common/queue.h".
8299
8300 2019-04-19  Tom Tromey  <tom@tromey.com>
8301
8302         * remote.c (remote_target): Use delete.
8303         * remote-notif.h: Include <list>, not "common/queue.h".
8304         (notif_client_p): Remove typedef.
8305         (remote_notif_state): Add constructor, destructor, initializer.
8306         <notif_queue>: Now a std::list.
8307         (remote_notif_state_xfree): Don't declare.
8308         * remote-notif.c (remote_notif_process, handle_notification)
8309         (remote_notif_state_allocate): Update.
8310         (~remote_notif_state): Rename from remote_notif_state_xfree.
8311
8312 2019-04-19  Tom Tromey  <tom@tromey.com>
8313
8314         * symfile.c (reread_symbols): Update.
8315         * objfiles.c (objfile_register_static_link)
8316         (objfile_lookup_static_link): Update
8317         (~objfile) Don't delete static_links.
8318         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8319
8320 2019-04-19  Tom Tromey  <tom@tromey.com>
8321
8322         * type-stack.h (struct type_stack) <insert>: Constify string.
8323         * type-stack.c (type_stack::insert): Constify string.
8324         * gdbtypes.h (lookup_template_type): Update.
8325         (address_space_name_to_int): Update.
8326         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8327         const.
8328         (lookup_template_type): Make name const.
8329         * c-exp.y: Update rules.
8330         (lex_one_token, classify_name, classify_inner_name)
8331         (c_print_token): Update.
8332         * p-exp.y: Update rules.
8333         (yylex): Update.
8334         * f-exp.y: Update rules.
8335         (yylex): Update.
8336         * d-exp.y: Update rules.
8337         (lex_one_token, classify_name, classify_inner_name): Update.
8338         * parse.c (write_dollar_variable, copy_name): Return std::string.
8339         * parser-defs.h (copy_name): Change return type.
8340         * m2-exp.y: Update rules.
8341         (yylex): Update.
8342         * go-exp.y (lex_one_token): Update.
8343         Update rules.
8344         (classify_unsafe_function, classify_packaged_name)
8345         (classify_name, yylex): Update.
8346
8347 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8348
8349         * configure.ac: add --enable-source-highlight switch.
8350         * configure: Regenerate.
8351         * top.c (print_gdb_version): plumb --enable-source-highlight
8352         status to "show configuration".
8353
8354 2019-04-19  Tom Tromey  <tromey@adacore.com>
8355
8356         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8357         Check ADA_TYPE_P.
8358         (empty_record, ada_template_to_fixed_record_type_1)
8359         (template_to_static_fixed_type)
8360         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8361         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8362         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8363         macros.
8364
8365 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8366
8367         PR symtab/24423:
8368         * source.c (print_source_lines_base): Advance "iter" when a
8369         control character is seen.
8370
8371 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8372
8373         * inferior.h (struct infcall_suspend_state_deleter):
8374         Catch exception in destructor to avoid crash.
8375
8376 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8377
8378         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8379         close to the add_com "shell".
8380
8381 2019-04-18  Tom Tromey  <tromey@adacore.com>
8382
8383         * process-stratum-target.h (class process_stratum_target)
8384         <stratum>: Add "final".
8385
8386 2019-04-17  Tom Tromey  <tromey@adacore.com>
8387
8388         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8389         against nullptr before use.
8390
8391 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8392
8393         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8394
8395 2019-04-17  Jim Wilson  <jimw@sifive.com>
8396             Andrew Burgess  <andrew.burgess@embecosm.com>
8397
8398         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8399         code read might fail, assume 4-byte breakpoint in that case.
8400
8401 2019-04-15  Leszek Swirski  <leszeks@google.com>
8402
8403         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8404         rather than a hand-rolled POD check when checking for forced MEMORY
8405         classification.
8406
8407 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8408
8409         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8410         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8411         function.
8412         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8413         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8414         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8415         declaration.
8416
8417 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8418
8419         * aarch64-linux-nat.c
8420         (aarch64_linux_nat_target::thread_architecture): Add override.
8421         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8422         each VQ.
8423
8424 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8425
8426         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8427
8428 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8429
8430         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8431         target types of size 96-bits, add some additional comments, and
8432         check that the builtin type we found was the correct size.
8433
8434 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8435
8436         * utils.c (prompt_for_continue): Don't restore the styling at the
8437         end, as applied_style has the wrong value.  This fixes styling in
8438         long lists of file names that are interrupted by the "Continue?"
8439         prompt.
8440
8441 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8442
8443         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8444         * c-lang.c (c_language_defn): Likewise.
8445         (cplus_language_defn): Likewise.
8446         (asm_language_defn): Likewise.
8447         (minimal_language_defn): Likewise.
8448         * d-lang.c (d_language_defn): Likewise.
8449         * f-lang.c (f_language_defn): Likewise.
8450         * go-lang.c (go_language_defn): Likewise.
8451         * language.c (unknown_language_defn): Likewise.
8452         (auto_language_defn): Likewise.
8453         * language.h (struct language_defn): Remove la_magic field.
8454         (LANG_MAGIC): Delete.
8455         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8456         * objc-lang.c (objc_language_defn): Likewise.
8457         * opencl-lang.c (opencl_language_defn): Likewise.
8458         * p-lang.c (pascal_language_defn): Likewise.
8459         * rust-lang.c (rust_language_defn): Likewise.
8460
8461 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8462
8463         * riscv-tdep.c (riscv_type_align): New function.
8464         (riscv_type_alignment): Delete.
8465         (riscv_arg_location): Use 'type_align'.
8466         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8467
8468 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8469
8470         * gdbtypes.c (type_align): A struct with no non-static fields also
8471         has alignment of 1.
8472
8473 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8474
8475         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8476         component to 0.
8477         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8478         member.
8479         (riscv_struct_info::analyse): New implementation using new
8480         analyse_inner member function.
8481         (riscv_struct_info::field_offset): New member function.
8482         (riscv_struct_info::m_offsets): New member variable.
8483         (riscv_struct_info::analyse_inner): New private member function,
8484         takes the old implementation of riscv_struct_info::analyse but
8485         extended to track field offsets.
8486         (riscv_call_arg_struct): Update the struct folding special cases
8487         to handle cases where empty C++ structs, which are non-zero
8488         length, are found.
8489         (riscv_arg_location): Initialise the length of each location, a
8490         non-zero length now indicates the location is in use.
8491         (riscv_push_dummy_call): Allow for the first location having a
8492         non-zero offset when setting up arguments.
8493         (riscv_return_value): Likewise, but for return values.
8494
8495 2019-04-11  Tom Tromey  <tromey@adacore.com>
8496
8497         * utils.c (internal_vproblem): Make "msg" const.
8498
8499 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8500
8501         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8502         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8503         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8504         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8505
8506 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8507
8508         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8509         function.
8510         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8511         of amd64_collect_native_gregset.
8512         (amd64_linux_nat_target::store_registers): Likewise.
8513
8514 2019-04-10  Tom Tromey  <tom@tromey.com>
8515
8516         * symtab.c (lookup_global_symbol_from_objfile)
8517         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8518         * objfiles.h (class separate_debug_iterator): New.
8519         (class separate_debug_range): New.
8520         (struct objfile) <separate_debug_objfiles>: New method.
8521         (objfile_separate_debug_iterate): Don't declare.
8522         * objfiles.c (separate_debug_iterator::operator++): Rename from
8523         objfile_separate_debug_iterate.
8524         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8525         iterator.
8526         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8527         iterator.
8528
8529 2019-04-10  Tom Tromey  <tom@tromey.com>
8530
8531         * symfile.c (reread_symbols): Remove old comment.
8532         * objfiles.c (free_all_objfiles): Fix a typo.
8533
8534 2019-04-10  Tom Tromey  <tom@tromey.com>
8535
8536         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8537         * minsyms.c (lookup_minimal_symbol): Use foreach.
8538         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8539         (lookup_minimal_symbol_solib_trampoline): Likewise.
8540         * symfile.c (reread_symbols): Use foreach.
8541
8542 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8543             Tom Tromey  <tromey@adacore.com>
8544
8545         PR rust/24414:
8546         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8547         (rust_lex_int_test): Change "value" to be LONGEST.
8548         (rust_lex_tests): Add test for long integer literal.
8549
8550 2019-04-09  Tom Tromey  <tromey@adacore.com>
8551
8552         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8553         to bool.
8554         (extended_remote_target::attach): Update.
8555         (remote_target::remote_notice_new_inferior): Update.
8556         (remote_target::add_current_inferior_and_thread): Update.
8557         * inferior.c (exit_inferior_1): Use "false".
8558         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8559
8560 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8561
8562         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8563         the "start" command.
8564
8565 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8566
8567         * python/py-inferior.c (infpy_thread_from_thread_handle):
8568         Adjust comments to reflect renaming of thread_from_thread_handle
8569         to thread_from_handle.  Adjust keywords.  Fix type error message.
8570         (inferior_object_methods): Add thread_from_handle.  Retain
8571         thread_from_thread_handle, but mark it as deprecated.
8572
8573 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8574
8575         * gdbthread.h (find_thread_by_handle): Revise declaration.
8576         * thread.c (find_thread_by_handle): Likewise.  Adjust
8577         implementation too.
8578         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8579         support for buffer objects as handles.
8580
8581 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8582
8583         * python/py-infthread.c (thpy_thread_handle): New function.
8584         (thread_object_methods): Register thpy_thread_handle.
8585
8586 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8587
8588         * gdbthread.h (thread_to_thread_handle): Declare.
8589         * thread.c (gdbtypes.h): Include.
8590         (thread_to_thread_handle): New function.
8591
8592         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8593         (target_thread_info_to_thread_handle): Declare.
8594         * target.c (target_thread_info_to_thread_handle): New function.
8595         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8596         * target-delegates.c: Regenerate.
8597
8598         * linux-thread-db.c (class thread_db_target): Add method
8599         thread_info_to_thread_handle.
8600         (thread_db_target::thread_info_to_thread_handle): Define.
8601         * remote.c (class remote_target): Add new method
8602         thread_info_to_thread_handle.
8603         (remote_target::thread_info_to_thread_handle): Define.
8604
8605 2019-04-08  Pedro Alves  <palves@redhat.com>
8606
8607         * common/common-exceptions.c (throw_exception): Don't create
8608         named object to throw; throw directly.
8609         (throw_it): Likewise.  Don't initialize gdb_exception::message
8610         here, with new; pass FMT and AP to the ctor instead.
8611         * common/common-exceptions.h: Include <string>.
8612         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8613         const char *, va_list)): New ctor.  Use std::make_shared.
8614         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8615         errors)): Delete.
8616         (gdb_exception_error::gdb_exception_error(enum errors, const char
8617         *, va_list)): New.
8618         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8619         Add assertion.
8620         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8621         errors)): Delete.
8622         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8623         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8624         Add assertion.
8625
8626 2019-04-08  Tom Tromey  <tom@tromey.com>
8627
8628         * valops.c (value_rtti_indirect_type): Replace throw_exception
8629         with throw.
8630         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8631         with throw.
8632         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8633         throw.
8634         * target.c (target_translate_tls_address): Replace throw_exception
8635         with throw.
8636         * stack.c (frame_apply_command_count): Replace throw_exception
8637         with throw.
8638         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8639         throw.
8640         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8641         with throw.
8642         * rs6000-tdep.c (rs6000_frame_cache)
8643         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8644         * remote.c: Replace throw_exception with throw.
8645         * record-full.c (record_full_message, record_full_wait_1)
8646         (record_full_restore): Replace throw_exception with throw.
8647         * record-btrace.c:
8648         (get_thread_current_frame_id, record_btrace_start_replaying)
8649         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8650         (cmd_record_btrace_start): Replace throw_exception with throw.
8651         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8652         throw.
8653         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8654         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8655         * linespec.c:
8656         (find_linespec_symbols): Replace throw_exception with throw.
8657         * infrun.c (displaced_step_prepare, resume): Replace
8658         throw_exception with throw.
8659         * infcmd.c (post_create_inferior): Replace throw_exception with
8660         throw.
8661         * inf-loop.c (inferior_event_handler): Replace throw_exception
8662         with throw.
8663         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8664         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8665         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8666         (get_prev_frame_always, get_frame_pc_if_available)
8667         (get_frame_address_in_block_if_available, get_frame_language):
8668         Replace throw_exception with throw.
8669         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8670         throw_exception with throw.
8671         * eval.c (fetch_subexp_value, evaluate_var_value)
8672         (evaluate_funcall, evaluate_subexp_standard): Replace
8673         throw_exception with throw.
8674         * dwarf2loc.c (call_site_find_chain)
8675         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8676         Replace throw_exception with throw.
8677         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8678         with throw.
8679         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8680         throw.
8681         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8682         * completer.c (complete_line_internal): Replace throw_exception
8683         with throw.
8684         * compile/compile-object-run.c (compile_object_run): Replace
8685         throw_exception with throw.
8686         * cli/cli-script.c (process_next_line): Replace throw_exception
8687         with throw.
8688         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8689         (btrace_enable, btrace_maint_update_pt_packets): Replace
8690         throw_exception with throw.
8691         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8692         throw_exception with throw.
8693         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8694         throw_exception with throw.
8695         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8696         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8697         * aarch64-tdep.c (aarch64_make_prologue_cache)
8698         (aarch64_make_stub_cache): Replace throw_exception with throw.
8699
8700 2019-04-08  Tom Tromey  <tom@tromey.com>
8701
8702         * common/common-exceptions.c (throw_exception): Rename from
8703         throw_exception_cxx.  Remove old copy.  Make argument const.
8704         (throw_it): Create and throw exception objects directly.
8705         * common/common-exceptions.h (throw_exception): Make argument
8706         const.
8707         (struct gdb_exception_error): Add constructor.
8708         (struct gdb_exception_quit): Add constructor.
8709
8710 2019-04-08  Tom Tromey  <tom@tromey.com>
8711
8712         * common/common-exceptions.h (exception_rethrow): Don't declare.
8713         (TRY_SJLJ): Update comment.
8714         (TRY, CATCH, END_CATCH): Remove.
8715         * common/common-exceptions.c (exception_rethrow): Remove.
8716
8717 2019-04-08  Tom Tromey  <tom@tromey.com>
8718
8719         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8720         Remove.
8721         (gdb_exception_error): Rename from
8722         gdb_exception_RETURN_MASK_ERROR.
8723         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8724         (gdb_quit_bad_alloc): Update.
8725         * aarch64-tdep.c: Update.
8726         * ada-lang.c: Update.
8727         * ada-typeprint.c: Update.
8728         * ada-valprint.c: Update.
8729         * amd64-tdep.c: Update.
8730         * arch-utils.c: Update.
8731         * break-catch-throw.c: Update.
8732         * breakpoint.c: Update.
8733         * btrace.c: Update.
8734         * c-varobj.c: Update.
8735         * cli/cli-cmds.c: Update.
8736         * cli/cli-interp.c: Update.
8737         * cli/cli-script.c: Update.
8738         * common/common-exceptions.c: Update.
8739         * common/new-op.c: Update.
8740         * common/selftest.c: Update.
8741         * compile/compile-c-symbols.c: Update.
8742         * compile/compile-cplus-symbols.c: Update.
8743         * compile/compile-object-load.c: Update.
8744         * compile/compile-object-run.c: Update.
8745         * completer.c: Update.
8746         * corelow.c: Update.
8747         * cp-abi.c: Update.
8748         * cp-support.c: Update.
8749         * cp-valprint.c: Update.
8750         * darwin-nat.c: Update.
8751         * disasm-selftests.c: Update.
8752         * dtrace-probe.c: Update.
8753         * dwarf-index-cache.c: Update.
8754         * dwarf-index-write.c: Update.
8755         * dwarf2-frame-tailcall.c: Update.
8756         * dwarf2-frame.c: Update.
8757         * dwarf2loc.c: Update.
8758         * dwarf2read.c: Update.
8759         * eval.c: Update.
8760         * event-loop.c: Update.
8761         * event-top.c: Update.
8762         * exec.c: Update.
8763         * f-valprint.c: Update.
8764         * fbsd-tdep.c: Update.
8765         * frame-unwind.c: Update.
8766         * frame.c: Update.
8767         * gdbtypes.c: Update.
8768         * gnu-v3-abi.c: Update.
8769         * guile/guile-internal.h: Update.
8770         * guile/scm-block.c: Update.
8771         * guile/scm-breakpoint.c: Update.
8772         * guile/scm-cmd.c: Update.
8773         * guile/scm-disasm.c: Update.
8774         * guile/scm-frame.c: Update.
8775         * guile/scm-lazy-string.c: Update.
8776         * guile/scm-math.c: Update.
8777         * guile/scm-param.c: Update.
8778         * guile/scm-ports.c: Update.
8779         * guile/scm-pretty-print.c: Update.
8780         * guile/scm-symbol.c: Update.
8781         * guile/scm-symtab.c: Update.
8782         * guile/scm-type.c: Update.
8783         * guile/scm-value.c: Update.
8784         * i386-linux-tdep.c: Update.
8785         * i386-tdep.c: Update.
8786         * inf-loop.c: Update.
8787         * infcall.c: Update.
8788         * infcmd.c: Update.
8789         * infrun.c: Update.
8790         * jit.c: Update.
8791         * language.c: Update.
8792         * linespec.c: Update.
8793         * linux-fork.c: Update.
8794         * linux-nat.c: Update.
8795         * linux-tdep.c: Update.
8796         * linux-thread-db.c: Update.
8797         * main.c: Update.
8798         * mi/mi-cmd-break.c: Update.
8799         * mi/mi-cmd-stack.c: Update.
8800         * mi/mi-interp.c: Update.
8801         * mi/mi-main.c: Update.
8802         * objc-lang.c: Update.
8803         * p-valprint.c: Update.
8804         * parse.c: Update.
8805         * ppc-linux-tdep.c: Update.
8806         * printcmd.c: Update.
8807         * python/py-arch.c: Update.
8808         * python/py-breakpoint.c: Update.
8809         * python/py-cmd.c: Update.
8810         * python/py-finishbreakpoint.c: Update.
8811         * python/py-frame.c: Update.
8812         * python/py-framefilter.c: Update.
8813         * python/py-gdb-readline.c: Update.
8814         * python/py-inferior.c: Update.
8815         * python/py-infthread.c: Update.
8816         * python/py-lazy-string.c: Update.
8817         * python/py-linetable.c: Update.
8818         * python/py-objfile.c: Update.
8819         * python/py-param.c: Update.
8820         * python/py-prettyprint.c: Update.
8821         * python/py-progspace.c: Update.
8822         * python/py-record-btrace.c: Update.
8823         * python/py-record.c: Update.
8824         * python/py-symbol.c: Update.
8825         * python/py-type.c: Update.
8826         * python/py-unwind.c: Update.
8827         * python/py-utils.c: Update.
8828         * python/py-value.c: Update.
8829         * python/python.c: Update.
8830         * record-btrace.c: Update.
8831         * record-full.c: Update.
8832         * remote-fileio.c: Update.
8833         * remote.c: Update.
8834         * riscv-tdep.c: Update.
8835         * rs6000-aix-tdep.c: Update.
8836         * rs6000-tdep.c: Update.
8837         * rust-exp.y: Update.
8838         * rust-lang.c: Update.
8839         * s390-tdep.c: Update.
8840         * selftest-arch.c: Update.
8841         * solib-dsbt.c: Update.
8842         * solib-frv.c: Update.
8843         * solib-spu.c: Update.
8844         * solib-svr4.c: Update.
8845         * solib.c: Update.
8846         * sparc64-linux-tdep.c: Update.
8847         * stack.c: Update.
8848         * symfile-mem.c: Update.
8849         * symmisc.c: Update.
8850         * target.c: Update.
8851         * thread.c: Update.
8852         * top.c: Update.
8853         * tracefile-tfile.c: Update.
8854         * tui/tui.c: Update.
8855         * typeprint.c: Update.
8856         * unittests/cli-utils-selftests.c: Update.
8857         * unittests/parse-connection-spec-selftests.c: Update.
8858         * valops.c: Update.
8859         * valprint.c: Update.
8860         * value.c: Update.
8861         * varobj.c: Update.
8862         * windows-nat.c: Update.
8863         * x86-linux-nat.c: Update.
8864         * xml-support.c: Update.
8865
8866 2019-04-08  Tom Tromey  <tom@tromey.com>
8867
8868         * xml-support.c: Use C++ exception handling.
8869         * x86-linux-nat.c: Use C++ exception handling.
8870         * windows-nat.c: Use C++ exception handling.
8871         * varobj.c: Use C++ exception handling.
8872         * value.c: Use C++ exception handling.
8873         * valprint.c: Use C++ exception handling.
8874         * valops.c: Use C++ exception handling.
8875         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8876         handling.
8877         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8878         * typeprint.c: Use C++ exception handling.
8879         * tui/tui.c: Use C++ exception handling.
8880         * tracefile-tfile.c: Use C++ exception handling.
8881         * top.c: Use C++ exception handling.
8882         * thread.c: Use C++ exception handling.
8883         * target.c: Use C++ exception handling.
8884         * symmisc.c: Use C++ exception handling.
8885         * symfile-mem.c: Use C++ exception handling.
8886         * stack.c: Use C++ exception handling.
8887         * sparc64-linux-tdep.c: Use C++ exception handling.
8888         * solib.c: Use C++ exception handling.
8889         * solib-svr4.c: Use C++ exception handling.
8890         * solib-spu.c: Use C++ exception handling.
8891         * solib-frv.c: Use C++ exception handling.
8892         * solib-dsbt.c: Use C++ exception handling.
8893         * selftest-arch.c: Use C++ exception handling.
8894         * s390-tdep.c: Use C++ exception handling.
8895         * rust-lang.c: Use C++ exception handling.
8896         * rust-exp.y: Use C++ exception handling.
8897         * rs6000-tdep.c: Use C++ exception handling.
8898         * rs6000-aix-tdep.c: Use C++ exception handling.
8899         * riscv-tdep.c: Use C++ exception handling.
8900         * remote.c: Use C++ exception handling.
8901         * remote-fileio.c: Use C++ exception handling.
8902         * record-full.c: Use C++ exception handling.
8903         * record-btrace.c: Use C++ exception handling.
8904         * python/python.c: Use C++ exception handling.
8905         * python/py-value.c: Use C++ exception handling.
8906         * python/py-utils.c: Use C++ exception handling.
8907         * python/py-unwind.c: Use C++ exception handling.
8908         * python/py-type.c: Use C++ exception handling.
8909         * python/py-symbol.c: Use C++ exception handling.
8910         * python/py-record.c: Use C++ exception handling.
8911         * python/py-record-btrace.c: Use C++ exception handling.
8912         * python/py-progspace.c: Use C++ exception handling.
8913         * python/py-prettyprint.c: Use C++ exception handling.
8914         * python/py-param.c: Use C++ exception handling.
8915         * python/py-objfile.c: Use C++ exception handling.
8916         * python/py-linetable.c: Use C++ exception handling.
8917         * python/py-lazy-string.c: Use C++ exception handling.
8918         * python/py-infthread.c: Use C++ exception handling.
8919         * python/py-inferior.c: Use C++ exception handling.
8920         * python/py-gdb-readline.c: Use C++ exception handling.
8921         * python/py-framefilter.c: Use C++ exception handling.
8922         * python/py-frame.c: Use C++ exception handling.
8923         * python/py-finishbreakpoint.c: Use C++ exception handling.
8924         * python/py-cmd.c: Use C++ exception handling.
8925         * python/py-breakpoint.c: Use C++ exception handling.
8926         * python/py-arch.c: Use C++ exception handling.
8927         * printcmd.c: Use C++ exception handling.
8928         * ppc-linux-tdep.c: Use C++ exception handling.
8929         * parse.c: Use C++ exception handling.
8930         * p-valprint.c: Use C++ exception handling.
8931         * objc-lang.c: Use C++ exception handling.
8932         * mi/mi-main.c: Use C++ exception handling.
8933         * mi/mi-interp.c: Use C++ exception handling.
8934         * mi/mi-cmd-stack.c: Use C++ exception handling.
8935         * mi/mi-cmd-break.c: Use C++ exception handling.
8936         * main.c: Use C++ exception handling.
8937         * linux-thread-db.c: Use C++ exception handling.
8938         * linux-tdep.c: Use C++ exception handling.
8939         * linux-nat.c: Use C++ exception handling.
8940         * linux-fork.c: Use C++ exception handling.
8941         * linespec.c: Use C++ exception handling.
8942         * language.c: Use C++ exception handling.
8943         * jit.c: Use C++ exception handling.
8944         * infrun.c: Use C++ exception handling.
8945         * infcmd.c: Use C++ exception handling.
8946         * infcall.c: Use C++ exception handling.
8947         * inf-loop.c: Use C++ exception handling.
8948         * i386-tdep.c: Use C++ exception handling.
8949         * i386-linux-tdep.c: Use C++ exception handling.
8950         * guile/scm-value.c: Use C++ exception handling.
8951         * guile/scm-type.c: Use C++ exception handling.
8952         * guile/scm-symtab.c: Use C++ exception handling.
8953         * guile/scm-symbol.c: Use C++ exception handling.
8954         * guile/scm-pretty-print.c: Use C++ exception handling.
8955         * guile/scm-ports.c: Use C++ exception handling.
8956         * guile/scm-param.c: Use C++ exception handling.
8957         * guile/scm-math.c: Use C++ exception handling.
8958         * guile/scm-lazy-string.c: Use C++ exception handling.
8959         * guile/scm-frame.c: Use C++ exception handling.
8960         * guile/scm-disasm.c: Use C++ exception handling.
8961         * guile/scm-cmd.c: Use C++ exception handling.
8962         * guile/scm-breakpoint.c: Use C++ exception handling.
8963         * guile/scm-block.c: Use C++ exception handling.
8964         * guile/guile-internal.h: Use C++ exception handling.
8965         * gnu-v3-abi.c: Use C++ exception handling.
8966         * gdbtypes.c: Use C++ exception handling.
8967         * frame.c: Use C++ exception handling.
8968         * frame-unwind.c: Use C++ exception handling.
8969         * fbsd-tdep.c: Use C++ exception handling.
8970         * f-valprint.c: Use C++ exception handling.
8971         * exec.c: Use C++ exception handling.
8972         * event-top.c: Use C++ exception handling.
8973         * event-loop.c: Use C++ exception handling.
8974         * eval.c: Use C++ exception handling.
8975         * dwarf2read.c: Use C++ exception handling.
8976         * dwarf2loc.c: Use C++ exception handling.
8977         * dwarf2-frame.c: Use C++ exception handling.
8978         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8979         * dwarf-index-write.c: Use C++ exception handling.
8980         * dwarf-index-cache.c: Use C++ exception handling.
8981         * dtrace-probe.c: Use C++ exception handling.
8982         * disasm-selftests.c: Use C++ exception handling.
8983         * darwin-nat.c: Use C++ exception handling.
8984         * cp-valprint.c: Use C++ exception handling.
8985         * cp-support.c: Use C++ exception handling.
8986         * cp-abi.c: Use C++ exception handling.
8987         * corelow.c: Use C++ exception handling.
8988         * completer.c: Use C++ exception handling.
8989         * compile/compile-object-run.c: Use C++ exception handling.
8990         * compile/compile-object-load.c: Use C++ exception handling.
8991         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8992         * compile/compile-c-symbols.c: Use C++ exception handling.
8993         * common/selftest.c: Use C++ exception handling.
8994         * common/new-op.c: Use C++ exception handling.
8995         * cli/cli-script.c: Use C++ exception handling.
8996         * cli/cli-interp.c: Use C++ exception handling.
8997         * cli/cli-cmds.c: Use C++ exception handling.
8998         * c-varobj.c: Use C++ exception handling.
8999         * btrace.c: Use C++ exception handling.
9000         * breakpoint.c: Use C++ exception handling.
9001         * break-catch-throw.c: Use C++ exception handling.
9002         * arch-utils.c: Use C++ exception handling.
9003         * amd64-tdep.c: Use C++ exception handling.
9004         * ada-valprint.c: Use C++ exception handling.
9005         * ada-typeprint.c: Use C++ exception handling.
9006         * ada-lang.c: Use C++ exception handling.
9007         * aarch64-tdep.c: Use C++ exception handling.
9008
9009 2019-04-08  Tom Tromey  <tom@tromey.com>
9010
9011         * xml-support.c (gdb_xml_parser::parse): Update.
9012         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9013         * value.c (show_convenience): Update.
9014         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9015         (test_parse_flags_qcs): Update.
9016         * thread.c (thr_try_catch_cmd): Update.
9017         * target.c (target_translate_tls_address): Update.
9018         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9019         (info_frame_command_core, frame_apply_command_count): Update.
9020         * rust-exp.y (rust_lex_exception_test): Update.
9021         * riscv-tdep.c (riscv_print_one_register_info): Update.
9022         * remote.c (remote_target::enable_btrace): Update.
9023         * record-btrace.c (record_btrace_enable_warn): Update.
9024         * python/py-utils.c (gdbpy_convert_exception): Update.
9025         * printcmd.c (do_one_display, print_variable_and_value): Update.
9026         * mi/mi-main.c (mi_print_exception): Update.
9027         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9028         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9029         * linux-nat.c (linux_nat_target::attach): Update.
9030         * linux-fork.c (class scoped_switch_fork_info): Update.
9031         * infrun.c (displaced_step_prepare): Update.
9032         * infcall.c (call_function_by_hand_dummy): Update.
9033         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9034         * gnu-v3-abi.c (print_one_vtable): Update.
9035         * frame.c (get_prev_frame_always): Update.
9036         * f-valprint.c (info_common_command_for_block): Update.
9037         * exec.c (try_open_exec_file): Update.
9038         * exceptions.c (print_exception, exception_print)
9039         (exception_fprintf, exception_print_same): Update.
9040         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9041         * dwarf-index-cache.c (index_cache::store)
9042         (index_cache::lookup_gdb_index): Update.
9043         * darwin-nat.c (maybe_cache_shell): Update.
9044         * cp-valprint.c (cp_print_value_fields): Update.
9045         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9046         (gcc_cplus_symbol_address): Update.
9047         * compile/compile-c-symbols.c (gcc_convert_symbol)
9048         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9049         * common/selftest.c: Update.
9050         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9051         a std::string.
9052         (exception_try_scope_entry, exception_try_scope_exit): Don't
9053         declare.
9054         (struct exception_try_scope): Remove.
9055         (TRY): Don't use exception_try_scope.
9056         (struct gdb_exception): Add constructor, operator=.
9057         <what>: New method.
9058         (struct gdb_exception_RETURN_MASK_ALL)
9059         (struct gdb_exception_RETURN_MASK_ERROR)
9060         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9061         (struct gdb_quit_bad_alloc): Update.
9062         * common/common-exceptions.c (exception_none): Change
9063         initializer.
9064         (struct catcher) <state, exception>: Initialize inline.
9065         <prev>: Remove member.
9066         (current_catcher): Remove.
9067         (catchers): New global.
9068         (exceptions_state_mc_init): Simplify.
9069         (catcher_pop): Remove.
9070         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9071         (try_scope_depth, exception_try_scope_entry)
9072         (exception_try_scope_exit): Remove.
9073         (throw_exception_sjlj): Update.
9074         (exception_messages, exception_messages_size): Remove.
9075         (throw_it): Simplify.
9076         (gdb_exception_sliced_copy): Remove.
9077         (throw_exception_cxx): Update.
9078         * cli/cli-script.c (script_from_file): Update.
9079         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9080         Update.
9081         * ada-valprint.c (ada_val_print): Update.
9082         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9083         (create_excep_cond_exprs): Update.
9084
9085 2019-04-08  Tom Tromey  <tom@tromey.com>
9086
9087         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9088         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9089         (TRY, CATCH, END_CATCH): Remove some definitions.
9090         * common/common-exceptions.c: Don't use GDB_XCPT.
9091         (catcher_list_size): Remove.
9092         (throw_exception, throw_it): Simplify.
9093
9094 2019-04-05  Tom Tromey  <tom@tromey.com>
9095
9096         Revert the header-sorting patch.
9097         * ft32-tdep.c: Revert.
9098         * frv-tdep.c: Revert.
9099         * frv-linux-tdep.c: Revert.
9100         * frame.c: Revert.
9101         * frame-unwind.c: Revert.
9102         * frame-base.c: Revert.
9103         * fork-child.c: Revert.
9104         * findvar.c: Revert.
9105         * findcmd.c: Revert.
9106         * filesystem.c: Revert.
9107         * filename-seen-cache.h: Revert.
9108         * filename-seen-cache.c: Revert.
9109         * fbsd-tdep.c: Revert.
9110         * fbsd-nat.h: Revert.
9111         * fbsd-nat.c: Revert.
9112         * f-valprint.c: Revert.
9113         * f-typeprint.c: Revert.
9114         * f-lang.c: Revert.
9115         * extension.h: Revert.
9116         * extension.c: Revert.
9117         * extension-priv.h: Revert.
9118         * expprint.c: Revert.
9119         * exec.h: Revert.
9120         * exec.c: Revert.
9121         * exceptions.c: Revert.
9122         * event-top.c: Revert.
9123         * event-loop.c: Revert.
9124         * eval.c: Revert.
9125         * elfread.c: Revert.
9126         * dwarf2read.h: Revert.
9127         * dwarf2read.c: Revert.
9128         * dwarf2loc.c: Revert.
9129         * dwarf2expr.h: Revert.
9130         * dwarf2expr.c: Revert.
9131         * dwarf2-frame.c: Revert.
9132         * dwarf2-frame-tailcall.c: Revert.
9133         * dwarf-index-write.h: Revert.
9134         * dwarf-index-write.c: Revert.
9135         * dwarf-index-common.c: Revert.
9136         * dwarf-index-cache.h: Revert.
9137         * dwarf-index-cache.c: Revert.
9138         * dummy-frame.c: Revert.
9139         * dtrace-probe.c: Revert.
9140         * disasm.h: Revert.
9141         * disasm.c: Revert.
9142         * disasm-selftests.c: Revert.
9143         * dictionary.c: Revert.
9144         * dicos-tdep.c: Revert.
9145         * demangle.c: Revert.
9146         * dcache.h: Revert.
9147         * dcache.c: Revert.
9148         * darwin-nat.h: Revert.
9149         * darwin-nat.c: Revert.
9150         * darwin-nat-info.c: Revert.
9151         * d-valprint.c: Revert.
9152         * d-namespace.c: Revert.
9153         * d-lang.c: Revert.
9154         * ctf.c: Revert.
9155         * csky-tdep.c: Revert.
9156         * csky-linux-tdep.c: Revert.
9157         * cris-tdep.c: Revert.
9158         * cris-linux-tdep.c: Revert.
9159         * cp-valprint.c: Revert.
9160         * cp-support.c: Revert.
9161         * cp-namespace.c: Revert.
9162         * cp-abi.c: Revert.
9163         * corelow.c: Revert.
9164         * corefile.c: Revert.
9165         * continuations.c: Revert.
9166         * completer.h: Revert.
9167         * completer.c: Revert.
9168         * complaints.c: Revert.
9169         * coffread.c: Revert.
9170         * coff-pe-read.c: Revert.
9171         * cli-out.h: Revert.
9172         * cli-out.c: Revert.
9173         * charset.c: Revert.
9174         * c-varobj.c: Revert.
9175         * c-valprint.c: Revert.
9176         * c-typeprint.c: Revert.
9177         * c-lang.c: Revert.
9178         * buildsym.c: Revert.
9179         * buildsym-legacy.c: Revert.
9180         * build-id.h: Revert.
9181         * build-id.c: Revert.
9182         * btrace.c: Revert.
9183         * bsd-uthread.c: Revert.
9184         * breakpoint.h: Revert.
9185         * breakpoint.c: Revert.
9186         * break-catch-throw.c: Revert.
9187         * break-catch-syscall.c: Revert.
9188         * break-catch-sig.c: Revert.
9189         * blockframe.c: Revert.
9190         * block.c: Revert.
9191         * bfin-tdep.c: Revert.
9192         * bfin-linux-tdep.c: Revert.
9193         * bfd-target.c: Revert.
9194         * bcache.c: Revert.
9195         * ax-general.c: Revert.
9196         * ax-gdb.h: Revert.
9197         * ax-gdb.c: Revert.
9198         * avr-tdep.c: Revert.
9199         * auxv.c: Revert.
9200         * auto-load.c: Revert.
9201         * arm-wince-tdep.c: Revert.
9202         * arm-tdep.c: Revert.
9203         * arm-symbian-tdep.c: Revert.
9204         * arm-pikeos-tdep.c: Revert.
9205         * arm-obsd-tdep.c: Revert.
9206         * arm-nbsd-tdep.c: Revert.
9207         * arm-nbsd-nat.c: Revert.
9208         * arm-linux-tdep.c: Revert.
9209         * arm-linux-nat.c: Revert.
9210         * arm-fbsd-tdep.c: Revert.
9211         * arm-fbsd-nat.c: Revert.
9212         * arm-bsd-tdep.c: Revert.
9213         * arch-utils.c: Revert.
9214         * arc-tdep.c: Revert.
9215         * arc-newlib-tdep.c: Revert.
9216         * annotate.h: Revert.
9217         * annotate.c: Revert.
9218         * amd64-windows-tdep.c: Revert.
9219         * amd64-windows-nat.c: Revert.
9220         * amd64-tdep.c: Revert.
9221         * amd64-sol2-tdep.c: Revert.
9222         * amd64-obsd-tdep.c: Revert.
9223         * amd64-obsd-nat.c: Revert.
9224         * amd64-nbsd-tdep.c: Revert.
9225         * amd64-nbsd-nat.c: Revert.
9226         * amd64-nat.c: Revert.
9227         * amd64-linux-tdep.c: Revert.
9228         * amd64-linux-nat.c: Revert.
9229         * amd64-fbsd-tdep.c: Revert.
9230         * amd64-fbsd-nat.c: Revert.
9231         * amd64-dicos-tdep.c: Revert.
9232         * amd64-darwin-tdep.c: Revert.
9233         * amd64-bsd-nat.c: Revert.
9234         * alpha-tdep.c: Revert.
9235         * alpha-obsd-tdep.c: Revert.
9236         * alpha-nbsd-tdep.c: Revert.
9237         * alpha-mdebug-tdep.c: Revert.
9238         * alpha-linux-tdep.c: Revert.
9239         * alpha-linux-nat.c: Revert.
9240         * alpha-bsd-tdep.c: Revert.
9241         * alpha-bsd-nat.c: Revert.
9242         * aix-thread.c: Revert.
9243         * agent.c: Revert.
9244         * addrmap.c: Revert.
9245         * ada-varobj.c: Revert.
9246         * ada-valprint.c: Revert.
9247         * ada-typeprint.c: Revert.
9248         * ada-tasks.c: Revert.
9249         * ada-lang.c: Revert.
9250         * aarch64-tdep.c: Revert.
9251         * aarch64-ravenscar-thread.c: Revert.
9252         * aarch64-newlib-tdep.c: Revert.
9253         * aarch64-linux-tdep.c: Revert.
9254         * aarch64-linux-nat.c: Revert.
9255         * aarch64-fbsd-tdep.c: Revert.
9256         * aarch64-fbsd-nat.c: Revert.
9257         * aarch32-linux-nat.c: Revert.
9258
9259 2019-04-05  Tom Tromey  <tom@tromey.com>
9260
9261         * ft32-tdep.c: Sort headers.
9262         * frv-tdep.c: Sort headers.
9263         * frv-linux-tdep.c: Sort headers.
9264         * frame.c: Sort headers.
9265         * frame-unwind.c: Sort headers.
9266         * frame-base.c: Sort headers.
9267         * fork-child.c: Sort headers.
9268         * findvar.c: Sort headers.
9269         * findcmd.c: Sort headers.
9270         * filesystem.c: Sort headers.
9271         * filename-seen-cache.h: Sort headers.
9272         * filename-seen-cache.c: Sort headers.
9273         * fbsd-tdep.c: Sort headers.
9274         * fbsd-nat.h: Sort headers.
9275         * fbsd-nat.c: Sort headers.
9276         * f-valprint.c: Sort headers.
9277         * f-typeprint.c: Sort headers.
9278         * f-lang.c: Sort headers.
9279         * extension.h: Sort headers.
9280         * extension.c: Sort headers.
9281         * extension-priv.h: Sort headers.
9282         * expprint.c: Sort headers.
9283         * exec.h: Sort headers.
9284         * exec.c: Sort headers.
9285         * exceptions.c: Sort headers.
9286         * event-top.c: Sort headers.
9287         * event-loop.c: Sort headers.
9288         * eval.c: Sort headers.
9289         * elfread.c: Sort headers.
9290         * dwarf2read.h: Sort headers.
9291         * dwarf2read.c: Sort headers.
9292         * dwarf2loc.c: Sort headers.
9293         * dwarf2expr.h: Sort headers.
9294         * dwarf2expr.c: Sort headers.
9295         * dwarf2-frame.c: Sort headers.
9296         * dwarf2-frame-tailcall.c: Sort headers.
9297         * dwarf-index-write.h: Sort headers.
9298         * dwarf-index-write.c: Sort headers.
9299         * dwarf-index-common.c: Sort headers.
9300         * dwarf-index-cache.h: Sort headers.
9301         * dwarf-index-cache.c: Sort headers.
9302         * dummy-frame.c: Sort headers.
9303         * dtrace-probe.c: Sort headers.
9304         * disasm.h: Sort headers.
9305         * disasm.c: Sort headers.
9306         * disasm-selftests.c: Sort headers.
9307         * dictionary.c: Sort headers.
9308         * dicos-tdep.c: Sort headers.
9309         * demangle.c: Sort headers.
9310         * dcache.h: Sort headers.
9311         * dcache.c: Sort headers.
9312         * darwin-nat.h: Sort headers.
9313         * darwin-nat.c: Sort headers.
9314         * darwin-nat-info.c: Sort headers.
9315         * d-valprint.c: Sort headers.
9316         * d-namespace.c: Sort headers.
9317         * d-lang.c: Sort headers.
9318         * ctf.c: Sort headers.
9319         * csky-tdep.c: Sort headers.
9320         * csky-linux-tdep.c: Sort headers.
9321         * cris-tdep.c: Sort headers.
9322         * cris-linux-tdep.c: Sort headers.
9323         * cp-valprint.c: Sort headers.
9324         * cp-support.c: Sort headers.
9325         * cp-namespace.c: Sort headers.
9326         * cp-abi.c: Sort headers.
9327         * corelow.c: Sort headers.
9328         * corefile.c: Sort headers.
9329         * continuations.c: Sort headers.
9330         * completer.h: Sort headers.
9331         * completer.c: Sort headers.
9332         * complaints.c: Sort headers.
9333         * coffread.c: Sort headers.
9334         * coff-pe-read.c: Sort headers.
9335         * cli-out.h: Sort headers.
9336         * cli-out.c: Sort headers.
9337         * charset.c: Sort headers.
9338         * c-varobj.c: Sort headers.
9339         * c-valprint.c: Sort headers.
9340         * c-typeprint.c: Sort headers.
9341         * c-lang.c: Sort headers.
9342         * buildsym.c: Sort headers.
9343         * buildsym-legacy.c: Sort headers.
9344         * build-id.h: Sort headers.
9345         * build-id.c: Sort headers.
9346         * btrace.c: Sort headers.
9347         * bsd-uthread.c: Sort headers.
9348         * breakpoint.h: Sort headers.
9349         * breakpoint.c: Sort headers.
9350         * break-catch-throw.c: Sort headers.
9351         * break-catch-syscall.c: Sort headers.
9352         * break-catch-sig.c: Sort headers.
9353         * blockframe.c: Sort headers.
9354         * block.c: Sort headers.
9355         * bfin-tdep.c: Sort headers.
9356         * bfin-linux-tdep.c: Sort headers.
9357         * bfd-target.c: Sort headers.
9358         * bcache.c: Sort headers.
9359         * ax-general.c: Sort headers.
9360         * ax-gdb.h: Sort headers.
9361         * ax-gdb.c: Sort headers.
9362         * avr-tdep.c: Sort headers.
9363         * auxv.c: Sort headers.
9364         * auto-load.c: Sort headers.
9365         * arm-wince-tdep.c: Sort headers.
9366         * arm-tdep.c: Sort headers.
9367         * arm-symbian-tdep.c: Sort headers.
9368         * arm-pikeos-tdep.c: Sort headers.
9369         * arm-obsd-tdep.c: Sort headers.
9370         * arm-nbsd-tdep.c: Sort headers.
9371         * arm-nbsd-nat.c: Sort headers.
9372         * arm-linux-tdep.c: Sort headers.
9373         * arm-linux-nat.c: Sort headers.
9374         * arm-fbsd-tdep.c: Sort headers.
9375         * arm-fbsd-nat.c: Sort headers.
9376         * arm-bsd-tdep.c: Sort headers.
9377         * arch-utils.c: Sort headers.
9378         * arc-tdep.c: Sort headers.
9379         * arc-newlib-tdep.c: Sort headers.
9380         * annotate.h: Sort headers.
9381         * annotate.c: Sort headers.
9382         * amd64-windows-tdep.c: Sort headers.
9383         * amd64-windows-nat.c: Sort headers.
9384         * amd64-tdep.c: Sort headers.
9385         * amd64-sol2-tdep.c: Sort headers.
9386         * amd64-obsd-tdep.c: Sort headers.
9387         * amd64-obsd-nat.c: Sort headers.
9388         * amd64-nbsd-tdep.c: Sort headers.
9389         * amd64-nbsd-nat.c: Sort headers.
9390         * amd64-nat.c: Sort headers.
9391         * amd64-linux-tdep.c: Sort headers.
9392         * amd64-linux-nat.c: Sort headers.
9393         * amd64-fbsd-tdep.c: Sort headers.
9394         * amd64-fbsd-nat.c: Sort headers.
9395         * amd64-dicos-tdep.c: Sort headers.
9396         * amd64-darwin-tdep.c: Sort headers.
9397         * amd64-bsd-nat.c: Sort headers.
9398         * alpha-tdep.c: Sort headers.
9399         * alpha-obsd-tdep.c: Sort headers.
9400         * alpha-nbsd-tdep.c: Sort headers.
9401         * alpha-mdebug-tdep.c: Sort headers.
9402         * alpha-linux-tdep.c: Sort headers.
9403         * alpha-linux-nat.c: Sort headers.
9404         * alpha-bsd-tdep.c: Sort headers.
9405         * alpha-bsd-nat.c: Sort headers.
9406         * aix-thread.c: Sort headers.
9407         * agent.c: Sort headers.
9408         * addrmap.c: Sort headers.
9409         * ada-varobj.c: Sort headers.
9410         * ada-valprint.c: Sort headers.
9411         * ada-typeprint.c: Sort headers.
9412         * ada-tasks.c: Sort headers.
9413         * ada-lang.c: Sort headers.
9414         * aarch64-tdep.c: Sort headers.
9415         * aarch64-ravenscar-thread.c: Sort headers.
9416         * aarch64-newlib-tdep.c: Sort headers.
9417         * aarch64-linux-tdep.c: Sort headers.
9418         * aarch64-linux-nat.c: Sort headers.
9419         * aarch64-fbsd-tdep.c: Sort headers.
9420         * aarch64-fbsd-nat.c: Sort headers.
9421         * aarch32-linux-nat.c: Sort headers.
9422
9423 2019-04-04  Tom Tromey  <tom@tromey.com>
9424
9425         * varobj.c (varobj_create): Update.
9426         * rust-exp.y (struct rust_parser) <update_innermost_block,
9427         lookup_symbol>: New methods.
9428         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9429         Rename.
9430         (rust_parser::rust_lookup_type)
9431         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9432         * printcmd.c (display_command, do_one_display): Update.
9433         * parser-defs.h (struct parser_state) <parser_state>: Add
9434         "tracker" parameter.
9435         (block_tracker): New member.
9436         (class innermost_block_tracker) <innermost_block_tracker>: Add
9437         "types" parameter.
9438         <reset>: Remove method.
9439         (innermost_block): Don't declare.
9440         (null_post_parser): Update.
9441         * parse.c (innermost_block): Remove global.
9442         (write_dollar_variable): Update.
9443         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9444         Remove "tracker_types" parameter.
9445         (parse_expression): Add "tracker" parameter.
9446         (parse_expression_for_completion): Update.
9447         (null_post_parser): Add "tracker" parameter.
9448         * p-exp.y: Update rules.
9449         * m2-exp.y: Update rules.
9450         * language.h (struct language_defn) <la_post_parser>: Add
9451         "tracker" parameter.
9452         * go-exp.y: Update rules.
9453         * f-exp.y: Update rules.
9454         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9455         parameter.
9456         * d-exp.y: Update rules.
9457         * c-exp.y: Update rules.
9458         * breakpoint.c (set_breakpoint_condition): Create an
9459         innermost_block_tracker.
9460         (watch_command_1): Likewise.
9461         * ada-lang.c (resolve): Add "tracker" parameter.
9462         (resolve_subexp): Likewise.
9463         * ada-exp.y (write_var_from_sym): Update.
9464
9465 2019-04-04  Tom Tromey  <tom@tromey.com>
9466
9467         * type-stack.h: New file.
9468         * type-stack.c: New file.
9469         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9470         type-stack.h.
9471         (insert_into_type_stack, insert_type, push_type, push_type_int)
9472         (insert_type_address_space, pop_type, pop_type_int)
9473         (pop_typelist, pop_type_stack, append_type_stack)
9474         (push_type_stack, get_type_stack, push_typelist)
9475         (follow_type_instance_flags, follow_types): Don't declare.
9476         * parse.c (type_stack): Remove global.
9477         (parse_exp_in_context): Update.
9478         (insert_into_type_stack, insert_type, push_type, push_type_int)
9479         (insert_type_address_space, pop_type, pop_type_int)
9480         (pop_typelist, pop_type_stack, append_type_stack)
9481         (push_type_stack, get_type_stack, push_typelist)
9482         (follow_type_instance_flags, follow_types): Remove (moved to
9483         type-stack.c).
9484         * f-exp.y (type_stack): New global.
9485         Update rules.
9486         (push_kind_type, f_parse): Update.
9487         * d-exp.y (type_stack): New global.
9488         Update rules.
9489         (d_parse): Update.
9490         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9491         Update rules.
9492         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9493         (HFILES_NO_SRCDIR): Add type-stack.h.
9494
9495 2019-04-04  Tom Tromey  <tom@tromey.com>
9496
9497         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9498         (rust_parser::convert_ast_to_expression, rust_parse)
9499         (rust_lex_test_completion, rust_lex_tests): Update.
9500         * parser-defs.h (struct expr_completion_state): New.
9501         (struct parser_state) <parser_state>: Add completion parameter.
9502         <mark_struct_expression, mark_completion_tag>: New methods.
9503         <parse_completion, m_completion_state>: New members.
9504         (prefixify_expression, null_post_parser): Update.
9505         (mark_struct_expression, mark_completion_tag): Don't declare.
9506         * parse.c (parse_completion, expout_last_struct)
9507         (expout_tag_completion_type, expout_completion_name): Remove
9508         globals.
9509         (parser_state::mark_struct_expression)
9510         (parser_state::mark_completion_tag): Now methods.
9511         (prefixify_expression): Add last_struct parameter.
9512         (prefixify_subexp): Likewise.
9513         (parse_exp_1): Update.
9514         (parse_exp_in_context): Add cstate parameter.  Update.
9515         (parse_expression_for_completion): Create an
9516         expr_completion_state.
9517         (null_post_parser): Add "completion" parameter.
9518         * p-exp.y: Update rules.
9519         (yylex): Update.
9520         * language.h (struct language_defn) <la_post_parser>: Add
9521         "completing" parameter.
9522         * go-exp.y: Update rules.
9523         (lex_one_token): Update.
9524         * expression.h (parse_completion): Don't declare.
9525         * d-exp.y: Update rules.
9526         (lex_one_token): Update rules.
9527         * c-exp.y: Update rules.
9528         (lex_one_token): Update.
9529         * ada-lang.c (resolve): Add "parse_completion" parameter.
9530         (resolve_subexp): Likewise.
9531         (ada_resolve_function): Likewise.
9532
9533 2019-04-04  Tom Tromey  <tom@tromey.com>
9534
9535         * parser-defs.h (struct parser_state) <start_arglist,
9536         end_arglist>: New methods.
9537         <arglist_len, m_funcall_chain>: New members.
9538         (arglist_len, start_arglist, end_arglist): Don't declare.
9539         * parse.c (arglist_len, funcall_chain): Remove global.
9540         (start_arglist, end_arglist): Remove functions.
9541         (parse_exp_in_context): Update.
9542         * p-exp.y: Update rules.
9543         * m2-exp.y: Update rules.
9544         * go-exp.y: Update rules.
9545         * f-exp.y: Update rules.
9546         * d-exp.y: Update rules.
9547         * c-exp.y: Update rules.
9548
9549 2019-04-04  Tom Tromey  <tom@tromey.com>
9550
9551         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9552         lex_operator, push_back>: New methods.
9553         Update all rules.
9554         (rust_parser::lex_hex, lex_escape): Rename and update.
9555         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9556         (rust_parser::lex_operator): Rename and update.
9557         (rust_parser::lex_number, rustyylex, rustyyerror)
9558         (rust_lex_test_init, rust_lex_test_sequence)
9559         (rust_lex_test_push_back, rust_lex_tests): Update.
9560         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9561         parameter.
9562         <lexptr, prev_lexptr>: New members.
9563         (lexptr, prev_lexptr): Don't declare.
9564         * parse.c (lexptr, prev_lexptr): Remove globals.
9565         (parse_exp_in_context): Update.
9566         * p-exp.y (yylex, yyerror): Update.
9567         * m2-exp.y (parse_number, yylex, yyerror): Update.
9568         * go-exp.y (lex_one_token, yyerror): Update.
9569         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9570         * d-exp.y (lex_one_token, yyerror): Update.
9571         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9572         (lex_one_token, yyerror): Update.
9573         * ada-lex.l (YY_INPUT): Update.
9574         (rewind_to_char): Update.
9575         * ada-exp.y (yyerror): Update.
9576
9577 2019-04-04  Tom Tromey  <tom@tromey.com>
9578
9579         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9580         * parser-defs.h (struct parser_state) <parser_state>: Add new
9581         parameter.
9582         <comma_terminates>: New member.
9583         (comma_terminates): Don't declare global.
9584         * parse.c (comma_terminates): Remove global.
9585         (parse_exp_in_context): Update.
9586         * p-exp.y (yylex): Update.
9587         * m2-exp.y (yylex): Update.
9588         * go-exp.y (lex_one_token): Update.
9589         * f-exp.y (yylex): Update.
9590         * d-exp.y (lex_one_token): Update.
9591         * c-exp.y (lex_one_token): Update.
9592         * ada-lex.l: Update.
9593
9594 2019-04-04  Tom Tromey  <tom@tromey.com>
9595
9596         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9597         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9598         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9599         * parser-defs.h (paren_depth): Don't declare.
9600         * parse.c (paren_depth): Remove global.
9601         (parse_exp_in_context): Update.
9602         * p-exp.y (paren_depth): New global.
9603         (pascal_parse): Initialize it.
9604         * m2-exp.y (paren_depth): New global.
9605         (m2_parse): Initialize it.
9606         * go-exp.y (paren_depth): New global.
9607         (go_parse): Initialize it.
9608         * f-exp.y (paren_depth): New global.
9609         (f_parse): Initialize it.
9610         * d-exp.y (paren_depth): New global.
9611         (d_parse): Initialize it.
9612         * c-exp.y (paren_depth): New global.
9613         (c_parse): Initialize it.
9614         * ada-lex.l (paren_depth): New global.
9615         (lexer_init): Initialize it.
9616
9617 2019-04-04  Tom Tromey  <tom@tromey.com>
9618
9619         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9620         (rust_parser::convert_ast_to_type)
9621         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9622         * parser-defs.h (struct parser_state) <parser_state>: Add
9623         parameters.  Initialize new members.
9624         <expression_context_block, expression_context_pc>: New members.
9625         * parse.c (expression_context_block, expression_context_pc):
9626         Remove globals.
9627         (parse_exp_in_context): Update.
9628         * p-exp.y: Update all rules.
9629         (yylex): Update.
9630         * m2-exp.y: Update all rules.
9631         (yylex): Update.
9632         * go-exp.y (yylex): Update.
9633         * f-exp.y (yylex): Update.
9634         * d-exp.y: Update all rules.
9635         (yylex): Update.
9636         * c-exp.y: Update all rules.
9637         (lex_one_token, classify_name, yylex, c_parse): Update.
9638         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9639
9640 2019-04-04  Tom Tromey  <tom@tromey.com>
9641
9642         * gdbarch.h, gdbarch.c: Rebuild.
9643         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9644         * stap-probe.h:
9645         (struct stap_parse_info): Replace "parser_state" with
9646         "expr_builder".
9647         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9648         (parser_state): New class.
9649         * parse.c (expr_builder): Rename.
9650         (expr_builder::release): Rename.
9651         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9652         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9653         (write_exp_elt_longcst, write_exp_elt_floatcst)
9654         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9655         (write_exp_string_vector, write_exp_bitstring)
9656         (write_exp_msymbol, mark_struct_expression)
9657         (write_dollar_variable)
9658         (insert_type_address_space, increase_expout_size): Replace
9659         "parser_state" with "expr_builder".
9660         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9661         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9662         "parser_state" with "expr_builder".
9663
9664 2019-04-04  Tom Tromey  <tom@tromey.com>
9665
9666         * rust-exp.y: Replace "parse_language" with method call.
9667         * p-exp.y:
9668         (yylex): Replace "parse_language" with method call.
9669         * m2-exp.y:
9670         (yylex): Replace "parse_language" with method call.
9671         * go-exp.y (classify_name): Replace "parse_language" with method
9672         call.
9673         * f-exp.y (yylex): Replace "parse_language" with method call.
9674         * d-exp.y (lex_one_token): Replace "parse_language" with method
9675         call.
9676         * c-exp.y:
9677         (lex_one_token, classify_name, yylex): Replace "parse_language"
9678         with method call.
9679         * ada-exp.y (find_primitive_type, type_char)
9680         (type_system_address): Replace "parse_language" with method call.
9681
9682 2019-04-04  Tom Tromey  <tom@tromey.com>
9683
9684         * rust-exp.y: Replace "parse_gdbarch" with method call.
9685         * parse.c (write_dollar_variable, insert_type_address_space):
9686         Replace "parse_gdbarch" with method call.
9687         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9688         call.
9689         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9690         call.
9691         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9692         "parse_gdbarch" with method call.
9693         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9694         with method call.
9695         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9696         "parse_gdbarch" with method call.
9697         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9698         "parse_gdbarch" with method call.
9699         * c-exp.y (parse_type, parse_number, classify_name): Replace
9700         "parse_gdbarch" with method call.
9701         * ada-lex.l: Replace "parse_gdbarch" with method call.
9702         * ada-exp.y (parse_type, find_primitive_type, type_char)
9703         (type_system_address): Replace "parse_gdbarch" with method call.
9704
9705 2019-04-04  Tom Tromey  <tom@tromey.com>
9706
9707         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9708         * stap-probe.c (stap_parse_argument): Update.
9709         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9710         initial_size parameter.
9711         * rust-exp.y (rust_lex_tests): Update.
9712         * parse.c (parser_state): Update.
9713         (parse_exp_in_context): Update.
9714         * parser-defs.h (struct parser_state) <parser_state>: Remove
9715         "initial_size" parameter.
9716
9717 2019-04-04  Tom Tromey  <tom@tromey.com>
9718
9719         * parser-defs.h (increase_expout_size): Don't declare.
9720         * parse.c (increase_expout_size): Now static.
9721
9722 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9723
9724         * gnu-nat.c (gnu_nat_target::wait): Fix
9725         target_waitstatus_to_string call.
9726
9727 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9728
9729         * eval.c (evaluate_subexp_standard): Handle internal functions
9730         during Fortran function call handling.
9731
9732 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9733
9734         * NEWS: Mention new internal functions.
9735         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9736         (read_base_type): Use dwarf2_init_complex_target_type.
9737         * value.c (creal_internal_fn): New function.
9738         (cimag_internal_fn): New function.
9739         (_initialize_values): Register new internal functions.
9740
9741 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9742
9743         * infrun.c (stop_all_threads): If debug_infrun, always
9744         trace the wait status after wait_one, using
9745         target_waitstatus_to_string and target_pid_to_str.
9746         (handle_inferior_event): Replace various trace of
9747         wait status kind by a single trace.
9748         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9749         wait status kind image by target_waitstatus_to_string.
9750         * target/waitstatus.c (target_waitstatus_to_string): Fix
9751         obsolete comment.
9752
9753 2019-04-01  Tom Tromey  <tromey@adacore.com>
9754
9755         PR symtab/23331:
9756         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9757
9758 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9759             Pedro Alves  <palves@redhat.com>
9760
9761         * top.c (quit_force): Call 'finalize_values'.
9762         * value.c (finalize_values): New function.
9763         * value.h (finalize_values): Declare.
9764
9765 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9766
9767         * NEWS: Announce $_gdb_major and $_gdb_minor.
9768
9769         * top.c (init_gdb_version_vars): New function.
9770         (gdb_init): Call init_gdb_version_vars.
9771
9772 2019-03-29  Tom Tromey  <tromey@adacore.com>
9773
9774         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9775         help text.  Remove dead code.
9776
9777 2019-03-29  Keith Seitz  <keiths@redhat.com>
9778
9779         From Siddhesh Poyarekar:
9780         * f-lang.h (f77_get_upperbound): Return LONGEST.
9781         (f77_get_lowerbound): Likewise.
9782         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9783         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9784         print them.
9785         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9786         plongest to format print it.
9787         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9788         (f77_get_upperbound): Likewise.
9789         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9790         LOWER_BOUND to LONGEST.
9791         (f77_create_arrayprint_offset_tbl): Likewise.
9792
9793 2019-03-29  Keith Seitz  <keiths@redhat.com>
9794
9795         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9796         %s/pulongest for TYPE_LENGTH instead of %d in format
9797         strings.
9798         * ada-typerint.c (ada_print_type): Likewise.
9799         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9800         * compile/compile-c-support.c (generate_register_struct): Likewise.
9801         * gdbtypes.c (recursive_dump_type): Likewise.
9802         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9803         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9804         instead of %d in format strings.
9805         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9806         to std::min to ULONGEST.
9807         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9808         instead of %d in format strings.
9809         * tracepoint.c (info_scope_command): Likewise.
9810         * typeprint.c (print_offset_data::update)
9811         (print_offset_data::finish): Likewise.
9812         * xtensa-tdep.c (xtensa_store_return_value)
9813         (xtensa_push_dummy_call): Likewise.
9814
9815 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9816
9817         * windows-nat.c (display_selector): Fixed format specifications
9818         for 64-bit Cygwin.
9819
9820 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9821
9822         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9823
9824 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9825
9826         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9827         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9828         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9829         (nios2_linux_init_abi): Install it.
9830
9831 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9832
9833         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9834
9835 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9836
9837         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9838
9839 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9840             Tom Tromey  <tromey@adacore.com>
9841
9842         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9843
9844 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9845
9846         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9847         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9848         method to compute the bounds of range types. Also print "[evaluated]"
9849         if the bounds' values come from a dynamic evaluation.
9850
9851 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9852
9853         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9854         whitespace when pretty printing is on.
9855
9856 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9857
9858         * ppc-linux-nat.c: Add include.
9859
9860 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9861
9862         * NEWS: Mention AArch64 Pointer Authentication.
9863
9864 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9865
9866         * arm-linux-nat.c: Add include.
9867
9868 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9869
9870         * source-cache.c (source_cache::get_source_lines): Re-read
9871         fullname after calling open_source_file.
9872
9873 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9874
9875         * NEWS: Mention TLS support for FreeBSD.
9876
9877 2019-03-25  Tom Tromey  <tromey@adacore.com>
9878
9879         * minsyms.c (BUNCH_SIZE): Update comment.
9880         (~minimal_symbol_reader): Remove old comment.
9881         (compact_minimal_symbols): Update comment.
9882         (minimal_symbol_reader::install): Remove old comment.  Update
9883         other comments.
9884
9885 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9886
9887         * s390-linux-nat.c: Add include.
9888
9889 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9890
9891         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9892         Call linux_get_hwcap.
9893         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9894         Likewise.
9895         (aarch64_linux_get_hwcap): Remove function.
9896         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9897         declaration.
9898         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9899         linux_get_hwcap.
9900         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9901         * linux-tdep.c (linux_get_hwcap): Add function.
9902         (linux_get_hwcap2): Likewise.
9903         * linux-tdep.h (linux_get_hwcap): Add declaration.
9904         (linux_get_hwcap2): Likewise.
9905         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9906         (ppc_linux_get_hwcap2): Likewise.
9907         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9908         linux_get_hwcap.
9909         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9910         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9911         (ppc_linux_nat_target::read_description): Likewise.
9912         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9913         * s390-linux-nat.c: Likewise.
9914         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9915
9916 2019-03-24  Tom Tromey  <tom@tromey.com>
9917
9918         * ada-lang.c (standard_lookup): Simplify initialization.
9919         (ada_lookup_symbol_nonlocal): Simplify return.
9920         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9921         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9922         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9923         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9924         initialization.
9925         * solib.c (solib_global_lookup): Simplify.
9926         * symtab.c (null_block_symbol): Remove.
9927         (symbol_cache_lookup): Simplify returns.
9928         (lookup_language_this): Simplify returns.
9929         (lookup_symbol_aux): Simplify return.
9930         (lookup_local_symbol): Simplify returns.
9931         (lookup_global_symbol_from_objfile): Simplify return.
9932         (lookup_symbol_in_objfile_symtabs)
9933         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9934         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9935         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9936         * cp-namespace.c (cp_lookup_bare_symbol)
9937         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9938         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9939         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9940         (cp_lookup_symbol_via_imports): Simplify initialization.
9941         (find_symbol_in_baseclass): Likewise.
9942         * symtab.h (null_block_symbol): Remove.
9943         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9944         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9945         (d_lookup_symbol_module): Likewise.
9946         (find_symbol_in_baseclass): Simplify initialization.
9947
9948 2019-03-24  Tom Tromey  <tom@tromey.com>
9949
9950         * expression.h: Don't include symtab.h.
9951         (struct block): Forward declare.
9952
9953 2019-03-24  Tom Tromey  <tom@tromey.com>
9954
9955         * c-exp.y (typebase): Remove casts.
9956         * gdbtypes.c (lookup_unsigned_typename, )
9957         (lookup_signed_typename): Remove cast.
9958         * eval.c (parse_to_comma_and_eval): Remove cast.
9959         * parse.c (write_dollar_variable): Remove cast.
9960         * block.h (struct block) <superblock>: Now const.
9961         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9962         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9963         (map_block): Make "block" const.
9964         * symfile.h (struct quick_symbol_functions)
9965         <map_matching_symbols>: Constify block argument to "callback".
9966         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9967         const.
9968         (find_pc_sect_compunit_symtab): Make "b" const.
9969         (find_symbol_at_address): Likewise.
9970         (search_symbols): Likewise.
9971         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9972         (dw2_debug_names_lookup_symbol): Likewise.
9973         (dw2_map_matching_symbols): Update.
9974         * p-valprint.c (pascal_val_print): Remove "block".
9975         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9976         (aux_add_nonlocal_symbols): Make "block" const.
9977         (resolve_subexp): Remove cast.
9978         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9979         const.
9980         (iterate_over_file_blocks): Likewise.
9981         * f-exp.y (%union) <bval>: Remove.
9982         * coffread.c (patch_opaque_types): Make "b" const.
9983         * spu-tdep.c (spu_catch_start): Make "block" const.
9984         * c-valprint.c (print_unpacked_pointer): Remove "block".
9985         * symmisc.c (dump_symtab_1): Make "b" const.
9986         (block_depth): Make "block" const.
9987         * d-exp.y (%union) <bval>: Remove.
9988         * cp-support.h (cp_lookup_rtti_type): Update.
9989         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9990         * psymtab.c (psym_lookup_symbol): Make "block" const.
9991         (maintenance_check_psymtabs): Make "b" const.
9992         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9993         (enumerate_locals, enumerate_args): Update.
9994         * python/py-symtab.c (stpy_global_block): Make "block" const.
9995         (stpy_static_block): Likewise.
9996         * inline-frame.c (block_starting_point_at): Make "new_block"
9997         const.
9998         * block.c (find_block_in_blockvector): Make return type const.
9999         (blockvector_for_pc_sect): Make "b" const.
10000         (find_block_in_blockvector): Make "b" const.
10001
10002 2019-03-23  Tom Tromey  <tom@tromey.com>
10003
10004         * varobj.c (varobj_create): Update.
10005         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10006         * printcmd.c (display_command, do_one_display): Don't reset
10007         innermost_block.
10008         * parser-defs.h (enum innermost_block_tracker_type): Move to
10009         expression.h.
10010         (innermost_block): Update comment.
10011         * parse.c (parse_exp_1): Add tracker_types parameter.
10012         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10013         tracker_types parameter.  Reset innermost_block.
10014         (parse_exp_in_context): Remove.
10015         (parse_expression_for_completion): Update.
10016         * objfiles.c (~objfile): Don't reset expression_context_block or
10017         innermost_block.
10018         * expression.h (enum innermost_block_tracker_type): Move from
10019         parser-defs.h.
10020         (parse_exp_1): Add tracker_types parameter.
10021         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10022         reset innermost_block.
10023
10024 2019-03-23  Tom Tromey  <tom@tromey.com>
10025
10026         * objfiles.h: Include bcache.h.
10027
10028 2019-03-23  Tom Tromey  <tom@tromey.com>
10029
10030         * linespec.c (get_current_search_block): Use
10031         scoped_restore_current_language.
10032         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10033
10034 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10035             Jiong Wang  <jiong.wang@arm.com>
10036
10037         * aarch64-linux-tdep.c
10038         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10039         section.
10040         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10041
10042 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10043             Jiong Wang  <jiong.wang@arm.com>
10044
10045         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10046         instructions.
10047         (aarch64_analyze_prologue_test): Add PACIASP test.
10048         (aarch64_prologue_prev_register): Unmask PC value.
10049
10050 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10051             Jiong Wang  <jiong.wang@arm.com>
10052
10053         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10054         (aarch64_dwarf2_prev_register): Unmask PC value.
10055         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10056         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10057         DW_CFA_AARCH64_negate_ra_state.
10058         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10059
10060 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10061             Jiong Wang  <jiong.wang@arm.com>
10062
10063         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10064         registers.
10065         (aarch64_pseudo_register_name): Likewise.
10066         (aarch64_pseudo_register_type): Likewise.
10067         (aarch64_pseudo_register_reggroup_p): Likewise.
10068         (aarch64_gdbarch_init): Add pauth registers.
10069         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10070         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10071         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10072         (struct gdbarch_tdep): Add regnum for ra_state.
10073
10074 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10075             Jiong Wang  <jiong.wang@arm.com>
10076
10077         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10078
10079 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10080             Jiong Wang  <jiong.wang@arm.com>
10081
10082         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10083         function.
10084         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10085         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10086         (aarch64_gdbarch_init): Add puth registers.
10087         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10088         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10089         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10090
10091 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10092             Jiong Wang  <jiong.wang@arm.com>
10093
10094         * aarch64-linux-nat.c
10095         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10096         * aarch64-linux-tdep.c
10097         (aarch64_linux_core_read_description): Likewise.
10098         (aarch64_linux_get_hwcap): New function.
10099         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10100         (aarch64_linux_get_hwcap): New declaration.
10101
10102 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10103             Jiong Wang  <jiong.wang@arm.com>
10104
10105         * aarch64-linux-nat.c
10106         (aarch64_linux_nat_target::read_description): Add pauth param.
10107         * aarch64-linux-tdep.c
10108         (aarch64_linux_core_read_description): Likewise.
10109         * aarch64-tdep.c (struct target_desc): Add in pauth.
10110         (aarch64_read_description): Add pauth param.
10111         (aarch64_gdbarch_init): Likewise.
10112         * aarch64-tdep.h (aarch64_read_description): Likewise.
10113         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10114         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10115         * features/Makefile: Add new files.
10116         * features/aarch64-pauth.c: New file.
10117         * features/aarch64-pauth.xml: New file.
10118
10119 2019-03-20  Tom Tromey  <tromey@adacore.com>
10120
10121         * infrun.c (handle_inferior_event): Rename from
10122         handle_inferior_event_1.  Create a scoped_value_mark.
10123         (handle_inferior_event): Remove.
10124
10125 2019-03-19  Tom Tromey  <tromey@adacore.com>
10126
10127         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10128         * infrun.h (print_stop_event): Add "displays" parameter.
10129         * infrun.c (print_stop_event): Add "displays" parameter.
10130
10131 2019-03-19  Pedro Alves  <palves@redhat.com>
10132
10133         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10134         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10135         to -1.  Fix TABs vs spaces.
10136         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10137         * tui/tui-out.h (tui_ui_out) Add intro comments.
10138         <m_line, m_start_of_line>: In-class initialize, and add describing
10139         comment.
10140
10141 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10142
10143         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10144         variable names.
10145         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10146
10147 2019-03-18  Pedro Alves  <palves@redhat.com>
10148             Eli Zaretskii <eliz@gnu.org>
10149
10150         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10151         m_line and m_start_of_line.
10152
10153 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10154
10155         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10156         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10157         it returns a newline.  This fixes a regression in TU mode, whereby
10158         the next line is output on the same screen line as the user input.
10159
10160 2019-03-18  Tom Tromey  <tromey@adacore.com>
10161
10162         * minsyms.c (minimal_symbol_reader::install): Remove call to
10163         obstack_blank.
10164
10165 2019-03-18  Pedro Alves  <palves@redhat.com>
10166
10167         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10168         New globals.
10169         (apply_style): New, factored out from ...
10170         (apply_ansi_escape): ... this.  Handle reverse video mode.
10171         (tui_set_reverse_mode): New function.
10172         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10173         * tui/tui-winsource.c (tui_show_source_line): Use
10174         tui_set_reverse_mode instead of setting A_STANDOUT.
10175         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10176         New setter methods.
10177
10178 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10179
10180         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10181         Handle tabs.
10182
10183 2019-03-18  Tom Tromey  <tromey@adacore.com>
10184
10185         * ada-lang.c (empty_array): Add "high" parameter.
10186         (ada_evaluate_subexp): Update.
10187
10188 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10189
10190         * unittests/string_view-selftests.c: Define
10191         _initialize_string_view_selftests unconditionally.
10192
10193 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10194
10195         PR gdb/24350
10196         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10197
10198 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10199
10200         PR gdb/24351
10201         * windows-nat.c (display_selector): Fix format specifiers.
10202
10203 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10204
10205         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10206         tui_refill_source_window instead of tui_refresh_win, to update the
10207         current execution line.  This fixes redisplay of the current line
10208         when stepping through the code with "next" or "step".
10209
10210 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10211
10212         * source-cache.c (source_cache::get_source_lines): Call
10213         find_source_lines to initialize s->nlines.  This fixes vertical
10214         scrolling of TUI source window when the DOWN arrow is pressed.
10215
10216 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10217
10218         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10219         linux-thread-db.c (_initialize_thread_db): Likewise.
10220
10221 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10222
10223         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10224         wclrtoeol in tui_show_source_line".  This reverts changes made in
10225         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10226
10227 2019-03-15  Tom Tromey  <tom@tromey.com>
10228
10229         * symtab.h (struct minimal_symbol): Derive from
10230         general_symbol_info.
10231         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10232         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10233         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10234         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10235         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10236         (MSYMBOL_SEARCH_NAME): Update.
10237         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10238         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10239         * minsyms.c (minimal_symbol_reader::record_full): Update.
10240
10241 2019-03-15  Tom Tromey  <tom@tromey.com>
10242
10243         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10244
10245 2019-03-15  Tom Tromey  <tom@tromey.com>
10246
10247         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10248         unique_xmalloc_ptr.
10249         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10250         Update.
10251         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10252         (build_minimal_symbol_hash_tables)
10253         (minimal_symbol_reader::install): Update.
10254
10255 2019-03-15  Tom Tromey  <tom@tromey.com>
10256
10257         * symtab.c (create_demangled_names_hash): Update.
10258         (symbol_set_names): Update.
10259         * objfiles.h (struct objfile_per_bfd_storage)
10260         <demangled_names_hash>: Now an htab_up.
10261         * objfiles.c (objfile_per_bfd_storage): Simplify.
10262
10263 2019-03-15  Tom Tromey  <tom@tromey.com>
10264
10265         * objfiles.h (struct objfile_per_bfd_storage): Declare
10266         destructor.
10267         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10268         New.
10269         (get_objfile_bfd_data): Use new.  Don't initialize
10270         language_of_main.
10271         (free_objfile_per_bfd_storage): Remove.
10272         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10273
10274 2019-03-15  Tom Tromey  <tom@tromey.com>
10275
10276         * symfile.c (reread_symbols): Update.
10277         * objfiles.c (objfile::objfile): Update.
10278         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10279         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10280         comment.
10281         (minimal_symbol_reader::install): Update.
10282         (terminate_minimal_symbol_table): Remove.
10283         * jit.c (jit_object_close_impl): Update.
10284
10285 2019-03-15  Tom Tromey  <tom@tromey.com>
10286
10287         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10288         initializations.
10289
10290 2019-03-15  Tom Tromey  <tom@tromey.com>
10291
10292         * objfiles.h (struct objfile_per_bfd_storage)
10293         <demangled_hash_languages>: Now a bitset.
10294         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10295         (lookup_minimal_symbol): Update.
10296
10297 2019-03-15  Tom Tromey  <tom@tromey.com>
10298
10299         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10300         Don't return the symbol.
10301         * coffread.c (record_minimal_symbol): Use record_full.
10302
10303 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10304
10305         The MS-Windows port of ncurses fails to switch to a color pair if
10306         one or both of the colors are the implicit default colors.  This
10307         change records the default colors when TUI is initialized, and
10308         then specifies them explicitly when a color pair uses the default
10309         colors.  This allows color styling in TUI mode on MS-Windows.
10310
10311         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10312         ncurses_norm_attr.
10313         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10314         colors in ncurses_norm_attr.
10315         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10316         "none", replace it with the default color recorded in
10317         ncurses_norm_attr.
10318
10319 2019-03-14  Tom Tromey  <tromey@adacore.com>
10320
10321         * source-cache.h (class source_cache) <get_source_lines>: Return
10322         std::string.
10323         * source-cache.c (source_cache::extract_lines): Handle case where
10324         first_pos==npos.  Return std::string.
10325         (source_cache::get_source_lines): Update.
10326
10327 2019-03-14  Tom Tromey  <tromey@adacore.com>
10328
10329         * NEWS: Add item for "style sources" commands.
10330         * source-cache.c (source_cache::get_source_lines): Check
10331         source_styling.
10332         * cli/cli-style.c (source_styling): New global.
10333         (_initialize_cli_style): Add "style sources" commands.
10334         (show_style_sources): New function.
10335         * cli/cli-style.h (source_styling): Declare.
10336
10337 2019-03-14  Pedro Alves  <palves@redhat.com>
10338             Tom Tromey  <tromey@adacore.com>
10339
10340         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10341         * tui/tui-winsource.c (tui_refill_source_window): New function,
10342         from...
10343         (tui_horizontal_source_scroll): ... here.  Move some logic.
10344         * cli/cli-style.c (set_style_enabled): Notify new observable.
10345         * tui/tui-hooks.c (tui_redisplay_source): New function.
10346         (tui_attach_detach_observers): Attach or detach
10347         tui_redisplay_source.
10348         * observable.h (source_styling_changed): New observable.
10349         * observable.c: Define source_styling_changed observable.
10350
10351 2019-03-13  Tom Tromey  <tromey@adacore.com>
10352
10353         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10354         (i386_gnu_nat_target::store_registers): Update.
10355         * target-debug.h (target_debug_print_std_string): New macro.
10356         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10357         * windows-tdep.c (display_one_tib): Update.
10358         * tui/tui-stack.c (tui_make_status_line): Update.
10359         * top.c (print_inferior_quit_action): Update.
10360         * thread.c (thr_try_catch_cmd): Update.
10361         (add_thread_with_info): Update.
10362         (thread_target_id_str): Update.
10363         (thr_try_catch_cmd): Update.
10364         (thread_command): Update.
10365         (thread_find_command): Update.
10366         * record-btrace.c (record_btrace_target::info_record)
10367         (record_btrace_resume_thread, record_btrace_target::resume)
10368         (record_btrace_cancel_resume, record_btrace_step_thread)
10369         (record_btrace_target::wait, record_btrace_target::wait)
10370         (record_btrace_target::wait, record_btrace_target::stop): Update.
10371         * progspace.c (print_program_space): Update.
10372         * process-stratum-target.c
10373         (process_stratum_target::thread_address_space): Update.
10374         * linux-fork.c (linux_fork_mourn_inferior)
10375         (detach_checkpoint_command, info_checkpoints_command)
10376         (linux_fork_context): Update.
10377         (linux_fork_detach): Update.
10378         (class scoped_switch_fork_info): Update.
10379         (delete_checkpoint_command): Update.
10380         * infrun.c (follow_fork_inferior): Update.
10381         (follow_fork_inferior): Update.
10382         (proceed_after_vfork_done): Update.
10383         (handle_vfork_child_exec_or_exit): Update.
10384         (follow_exec): Update.
10385         (displaced_step_prepare_throw): Update.
10386         (displaced_step_restore): Update.
10387         (start_step_over): Update.
10388         (resume_1): Update.
10389         (clear_proceed_status_thread): Update.
10390         (proceed): Update.
10391         (print_target_wait_results): Update.
10392         (do_target_wait): Update.
10393         (context_switch): Update.
10394         (stop_all_threads): Update.
10395         (restart_threads): Update.
10396         (finish_step_over): Update.
10397         (handle_signal_stop): Update.
10398         (switch_back_to_stepped_thread): Update.
10399         (keep_going_pass_signal): Update.
10400         (print_exited_reason): Update.
10401         (normal_stop): Update.
10402         * inferior.c (inferior_pid_to_str): Change return type.
10403         (print_selected_inferior): Update.
10404         (add_inferior): Update.
10405         (detach_inferior): Update.
10406         * dummy-frame.c (fprint_dummy_frames): Update.
10407         * dcache.c (dcache_info_1): Update.
10408         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10409         (btrace_fetch, btrace_clear): Update.
10410         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10411         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10412         type.
10413         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10414         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10415         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10416         * gdbarch.c, gdbarch.h: Rebuild.
10417         * gdbarch.sh (core_pid_to_str): Change return type.
10418         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10419         return type.
10420         (windows_nat_target::pid_to_str): Change return type.
10421         (windows_delete_thread): Update.
10422         (windows_nat_target::attach): Update.
10423         (windows_nat_target::files_info): Update.
10424         * target-delegates.c: Rebuild.
10425         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10426         return type.
10427         (sol_thread_target::pid_to_str): Change return type.
10428         * remote.c (class remote_target) <pid_to_str>: Change return
10429         type.
10430         (remote_target::pid_to_str): Change return type.
10431         (extended_remote_target::attach, remote_target::remote_stop_ns)
10432         (remote_target::remote_notif_remove_queued_reply)
10433         (remote_target::push_stop_reply, remote_target::disable_btrace):
10434         Update.
10435         (extended_remote_target::attach): Update.
10436         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10437         type.
10438         (gdbsim_target::pid_to_str): Change return type.
10439         * ravenscar-thread.c (struct ravenscar_thread_target)
10440         <pid_to_str>: Change return type.
10441         (ravenscar_thread_target::pid_to_str): Change return type.
10442         * procfs.c (class procfs_target) <pid_to_str>: Change return
10443         type.
10444         (procfs_target::pid_to_str): Change return type.
10445         (procfs_target::attach): Update.
10446         (procfs_target::detach): Update.
10447         (procfs_target::fetch_registers): Update.
10448         (procfs_target::store_registers): Update.
10449         (procfs_target::wait): Update.
10450         (procfs_target::files_info): Update.
10451         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10452         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10453         return type.
10454         (nto_procfs_target::pid_to_str): Change return type.
10455         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10456         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10457         return type.
10458         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10459         (exit_lwp): Update.
10460         (attach_proc_task_lwp_callback, get_detach_signal)
10461         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10462         (linux_nat_target::resume, wait_lwp, stop_callback)
10463         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10464         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10465         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10466         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10467         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10468         type.
10469         (inf_ptrace_target::attach): Update.
10470         (inf_ptrace_target::files_info): Update.
10471         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10472         type.
10473         (go32_nat_target::pid_to_str): Change return type.
10474         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10475         (gnu_nat_target::wait): Update.
10476         (gnu_nat_target::wait): Update.
10477         (gnu_nat_target::resume): Update.
10478         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10479         (fbsd_nat_target::wait): Update.
10480         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10481         type.
10482         (darwin_nat_target::attach): Update.
10483         * corelow.c (class core_target) <pid_to_str>: Change return type.
10484         (core_target::pid_to_str): Change return type.
10485         * target.c (normal_pid_to_str): Change return type.
10486         (default_pid_to_str): Likewise.
10487         (target_pid_to_str): Change return type.
10488         (target_translate_tls_address): Update.
10489         (target_announce_detach): Update.
10490         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10491         return type.
10492         (bsd_uthread_target::pid_to_str): Change return type.
10493         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10494         type.
10495         (bsd_kvm_target::pid_to_str): Change return type.
10496         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10497         return type.
10498         (aix_thread_target::pid_to_str): Change return type.
10499         * target.h (struct target_ops) <pid_to_str>: Change return type.
10500         (target_pid_to_str, normal_pid_to_str): Likewise.
10501         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10502         type.
10503         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10504         type.
10505         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10506         return type.
10507         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10508         type.
10509         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10510         type.
10511         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10512         return type.
10513
10514 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10515
10516         * NEWS: Mention that the new default MI version is 3.  Mention
10517         changes to the output of commands and events that deal with
10518         multi-location breakpoints.
10519         * breakpoint.c: Include "mi/mi-out.h".
10520         (print_one_breakpoint): Change output syntax if using MI version
10521         >= 3.
10522         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10523         New.
10524         (mi_multi_location_breakpoint_output_fixed): New.
10525         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10526         (mi_cmd_fix_multi_location_breakpoint_output): New.
10527         (mi_multi_location_breakpoint_output_fixed): New.
10528         * mi/mi-cmds.c (mi_cmds): Register command
10529         -fix-multi-location-breakpoint-output.
10530         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10531         interpreter "mi".
10532
10533 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10534
10535         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10536         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10537         instantiate mi_ui_out based on interpreter name.
10538         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10539         * mi/mi-main.c (mi_load_progress): Likewise.
10540
10541 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10542
10543         * NEWS: Combine separate "New targets" sections for 8.3.
10544
10545 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10546
10547         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10548         (ppcfbsd_init_abi): Install gdbarch
10549         "fetch_tls_load_module_address" and "get_thread_local_address"
10550         methods.
10551
10552 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10553
10554         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10555         (riscv_fbsd_init_abi): Install gdbarch
10556         "fetch_tls_load_module_address" and "get_thread_local_address"
10557         methods.
10558
10559 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10560
10561         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10562         (i386fbsd_init_abi): Install gdbarch
10563         "fetch_tls_load_module_address" and "get_thread_local_address"
10564         methods.
10565
10566 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10567
10568         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10569         (amd64fbsd_init_abi): Install gdbarch
10570         "fetch_tls_load_module_address" and "get_thread_local_address"
10571         methods.
10572
10573 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10574
10575         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10576         (struct fbsd_pspace_data): New type.
10577         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10578         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10579         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10580         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10581         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10582
10583 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10584
10585         * gdbtypes.c (lookup_struct_elt): New function.
10586         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10587         * gdbtypes.h (struct struct_elt): New type.
10588         (lookup_struct_elt): New prototype.
10589
10590 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10591
10592         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10593         remove disabled code block.
10594
10595 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10596
10597         * gdbarch.sh (get_thread_local_address): New method.
10598         * gdbarch.h, gdbarch.c: Regenerate.
10599         * target.c (target_translate_tls_address): Use
10600         gdbarch_get_thread_local_address if present instead of
10601         target::get_thread_local_address.
10602
10603 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10604
10605         * target.h (target::get_thread_local_address): Update comment.
10606
10607 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10608
10609         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10610         objfile->separate_debug_objfile_backlink if not NULL.
10611
10612 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10613
10614         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10615         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10616         (amd64bsd_store_inferior_registers): Likewise.
10617         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10618         Enable segment base registers.
10619         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10620         PT_GETFSBASE and PT_GETGSBASE.
10621         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10622         PT_SETGSBASE.
10623         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10624         segment base registers.
10625         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10626
10627 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10628
10629         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10630         Update calls to i386_target_description to add 'segments'
10631         parameter.
10632         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10633         add segment base registers.
10634         * arch/i386.c (i386_create_target_description): Add 'segments'
10635         parameter to enable segment base registers.
10636         * arch/i386.h (i386_create_target_description): Likewise.
10637         * features/i386/32bit-segments.xml: New file.
10638         * features/i386/32bit-segments.c: Generate.
10639         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10640         call to i386_target_description to add 'segments' parameter.
10641         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10642         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10643         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10644         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10645         if feature is present.
10646         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10647         Add 'segments' parameter to call to i386_target_description.
10648         (i386_target_description): Add 'segments' parameter to enable
10649         segment base registers.
10650         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10651         to call to i386_target_description.
10652         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10653         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10654         Define I386_NUM_REGS.
10655         (i386_target_description): Add 'segments' parameter to enable
10656         segment base registers.
10657
10658 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10659
10660         PR/24325
10661         * source-cache.c: #undef open and close, to avoid unresolved
10662         externals during linking.
10663
10664 2019-03-12  Tom Tromey  <tromey@adacore.com>
10665
10666         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10667         const.  Add initializers.
10668         (_initialize_remote): Don't initialize ptid globals.
10669
10670 2019-03-12  Pedro Alves  <palves@redhat.com>
10671
10672         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10673
10674 2019-03-12  Pedro Alves  <palves@redhat.com>
10675
10676         * cp-name-parser.y (main): Remove unused 'len' variable.
10677
10678 2019-03-12  Tom Tromey  <tromey@adacore.com>
10679
10680         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10681         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10682
10683 2019-03-12  Tom Tromey  <tromey@adacore.com>
10684
10685         * linux-nat.c (iterate_over_lwps): Update.
10686         (stop_callback): Remove parameter.
10687         (stop_wait_callback, detach_callback, resume_set_callback)
10688         (select_singlestep_lwp_callback, set_ignore_sigint)
10689         (status_callback, resumed_callback, resume_clear_callback)
10690         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10691         data parameter.
10692         (linux_nat_target::detach, linux_nat_target::resume)
10693         (linux_stop_and_wait_all_lwps, select_event_lwp)
10694         (linux_nat_filter_event, linux_nat_wait_1)
10695         (linux_nat_target::kill, linux_nat_target::stop)
10696         (linux_nat_target::stop): Update.
10697         (linux_nat_resume_callback): Change type.
10698         (resume_stopped_resumed_lwps, count_events_callback)
10699         (select_event_lwp_callback): Likewise.
10700         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10701         * arm-linux-nat.c (struct update_registers_data): Remove.
10702         (update_registers_callback): Change type.
10703         (arm_linux_insert_hw_breakpoint1): Update.
10704         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10705         parameter.
10706         (x86_linux_dr_set_addr): Update.
10707         (x86_linux_dr_set_control): Update.
10708         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10709         (iterate_over_lwps): Use gdb::function_view.
10710         * nat/aarch64-linux-hw-point.c (struct
10711         aarch64_dr_update_callback_param): Remove.
10712         (debug_reg_change_callback): Change type.
10713         (aarch64_notify_debug_reg_change): Update.
10714         * s390-linux-nat.c (s390_refresh_per_info): Update.
10715
10716 2019-03-11  Tom Tromey  <tromey@adacore.com>
10717
10718         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10719         redundant assignment to "this_cu".
10720
10721 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10722
10723         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10724
10725 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10726
10727         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10728         from...
10729         (rank_one_type): ... this.
10730
10731 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10732
10733         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10734         from...
10735         (rank_one_type): ... this.
10736
10737 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10738
10739         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10740         from...
10741         (rank_one_type): ... this.
10742
10743 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10744
10745         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10746         from...
10747         (rank_one_type): ... this.
10748
10749 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10750
10751         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10752         from...
10753         (rank_one_type): ... this.
10754
10755 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10756
10757         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10758         from...
10759         (rank_one_type): ... this.
10760
10761 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10762
10763         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10764         from...
10765         (rank_one_type): ... this.
10766
10767 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10768
10769         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10770         from...
10771         (rank_one_type): ... this.
10772
10773 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10774
10775         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10776         from...
10777         (rank_one_type): ... this.
10778
10779 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10780
10781         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10782         from...
10783         (rank_one_type): ... this.
10784
10785 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10786
10787         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10788         from...
10789         (rank_one_type): ... this.
10790
10791 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10792
10793         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10794         from...
10795         (rank_one_type): ... this.
10796
10797 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10798
10799         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10800         inferior-events' shows the example events.
10801
10802 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10803
10804         Support styling on native MS-Windows console
10805
10806         PR/24315
10807         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10808         on MS-Windows if $TERM is not defined.
10809
10810         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10811
10812         * posix-hdep.c (gdb_console_fputs):
10813         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10814         functions.
10815         * ui-file.h (gdb_console_fputs): Add prototype.
10816
10817         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10818         back to fputs only if the former returns zero.
10819
10820 2019-03-07  Tom Tromey  <tom@tromey.com>
10821
10822         * symmisc.c (print_symbol_bcache_statistics): Update.
10823         (print_objfile_statistics): Update.
10824         * symfile.c (allocate_symtab): Update.
10825         * stabsread.c: Don't include bcache.h.
10826         * psymtab.h (struct psymbol_bcache): Don't declare.
10827         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10828         (psymbol_bcache_init, psymbol_bcache_free)
10829         (psymbol_bcache_get_bcache): Don't declare.
10830         * psymtab.c (struct psymbol_bcache): Remove.
10831         (psymtab_storage::psymtab_storage): Update.
10832         (psymtab_storage::~psymtab_storage): Update.
10833         (psymbol_bcache_init, psymbol_bcache_free)
10834         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10835         (add_psymbol_to_bcache): Update.
10836         (allocate_psymtab): Update.
10837         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10838         macro_cache>: No longer pointers.
10839         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10840         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10841         * macrotab.c (macro_bcache): Update.
10842         * macroexp.c: Don't include bcache.h.
10843         * gdbtypes.c (check_types_worklist): Update.
10844         (types_deeply_equal): Remove TRY/CATCH.  Update.
10845         * elfread.c (elf_symtab_read): Update.
10846         * dwarf2read.c: Don't include bcache.h.
10847         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10848         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10849         (print_bcache_statistics, bcache_memory_used): Don't declare.
10850         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10851         methods.  Rename all data members.
10852         * bcache.c (struct bcache): Move to bcache.h.
10853         (bcache::expand_hash_table): Rename from expand_hash_table.
10854         (bcache): Remove.
10855         (bcache::insert): Rename from bcache_full.
10856         (bcache::compare): Rename from bcache_compare.
10857         (bcache_xmalloc): Remove.
10858         (bcache::~bcache): Rename from bcache_xfree.
10859         (bcache::print_statistics): Rename from print_bcache_statistics.
10860         (bcache::memory_used): Rename from bcache_memory_used.
10861
10862 2019-03-07  Pedro Alves  <palves@redhat.com>
10863
10864         * infrun.c (normal_stop): Also check for
10865         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10866
10867 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10868
10869         * f-lang.c (value_from_host_double): Moved to...
10870         * value.c (value_from_host_double): ...here.
10871         * value.h (value_from_host_double): Declare.
10872         * guile/scm-math.c (vlscm_convert_typed_number): Use
10873         value_from_host_double.
10874         (vlscm_convert_number): Likewise.
10875         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10876         * python/py-value.c (convert_value_from_python): Likewise.
10877
10878 2019-03-06  Tom Tromey  <tom@tromey.com>
10879
10880         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10881
10882 2019-03-06  Tom Tromey  <tom@tromey.com>
10883
10884         * utils.h (free_current_contents): Don't declare.
10885         * utils.c (free_current_contents): Remove.
10886
10887 2019-03-06  Tom Tromey  <tom@tromey.com>
10888
10889         * top.c (quit_force): Update.
10890         * main.c (captured_command_loop): Update.
10891         * common/new-op.c (operator new): Update.
10892         * common/common-exceptions.c (struct catcher)
10893         <save_cleanup_chain>: Remove member.
10894         (exceptions_state_mc_init): Update.
10895         (exception_try_scope_entry): Return nullptr.
10896         (exception_try_scope_exit, exception_rethrow)
10897         (throw_exception_sjlj, throw_exception_cxx): Update.
10898         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10899         (all_cleanups, do_cleanups, discard_cleanups)
10900         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10901         (restore_cleanups, restore_final_cleanups): Don't declare.
10902         (do_final_cleanups): Remove parameter.
10903         * common/cleanups.c (cleanup_chain, make_cleanup)
10904         (make_cleanup_dtor, all_cleanups, do_cleanups)
10905         (discard_my_cleanups, discard_cleanups)
10906         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10907         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10908         (null_cleanup): Remove.
10909         (do_final_cleanups): Remove parameter.
10910
10911 2019-03-06  Tom Tromey  <tom@tromey.com>
10912
10913         * remote.c (remote_target::remote_parse_stop_reply): Use
10914         unique_xmalloc_ptr.
10915
10916 2019-03-06  Tom Tromey  <tom@tromey.com>
10917
10918         * stabsread.c (struct stabs_field_info): Rename from field_info.
10919         <list, fnlist>: Add initializers.
10920         <obstack>: New member.
10921         (read_member_functions, read_struct_fields, read_baseclasses):
10922         Allocate on obstack.  Don't use cleanups.
10923         (read_one_struct_field, read_member_functions, read_struct_fields)
10924         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10925         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10926         (read_struct_type): Update.
10927
10928 2019-03-06  Tom Tromey  <tom@tromey.com>
10929
10930         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10931         * common/filestuff.h (make_cleanup_close): Don't declare.
10932         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10933         Remove.
10934
10935 2019-03-06  Tom Tromey  <tom@tromey.com>
10936
10937         * solib-aix.c: Use make_scope_exit.
10938
10939 2019-03-06  Tom Tromey  <tom@tromey.com>
10940
10941         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10942         Use make_scope_exit.
10943
10944 2019-03-06  Tom Tromey  <tom@tromey.com>
10945
10946         * solib-svr4.c (disable_probes_interface): Remove parameter.
10947         (svr4_handle_solib_event): Use make_scope_exit.
10948
10949 2019-03-06  Tom Tromey  <tom@tromey.com>
10950
10951         * remote.c (struct stop_reply_deleter): Remove.
10952         (stop_reply_up): Update.
10953         (struct stop_reply): Derive from notif_event.  Don't typedef.
10954         <regcache>: Now a std::vector.
10955         (stop_reply_xfree): Remove.
10956         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10957         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10958         (remote_target::discard_pending_stop_replies): Use delete.
10959         (remote_target::remote_parse_stop_reply): Update.
10960         (remote_target::process_stop_reply): Update.
10961         * remote-notif.h (struct notif_event): Add virtual destructor.
10962         Remove "dtr" member.
10963         (struct notif_client) <alloc_event>: Return a unique_ptr.
10964         (notif_event_xfree): Don't declare.
10965         (notif_event_up): New typedef.
10966         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10967         (notif_event_xfree, do_notif_event_xfree): Remove.
10968         (remote_notif_state_xfree): Update.
10969
10970 2019-03-06  Tom Tromey  <tom@tromey.com>
10971
10972         * infrun.c (displaced_step_clear_cleanup): Now a
10973         forward_scope_exit type.
10974         (displaced_step_prepare_throw): Update.
10975         (displaced_step_fixup): Update.
10976
10977 2019-03-06  Tom Tromey  <tom@tromey.com>
10978
10979         * inferior.h (class inferior): Update comment.
10980         * gdbthread.h (class thread_info): Update comment.
10981
10982 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10983             Tom Tromey  <tom@tromey.com>
10984
10985         * stabsread.h (struct stab_section_list): Remove.
10986         (coffstab_build_psymtabs): Update.
10987         * dbxread.c (symbuf_sections): Now a std::vector.
10988         (sect_idx): New global.
10989         (fill_symbuf): Update.
10990         (coffstab_build_psymtabs): Change type of stabsects parameter.
10991         Update.
10992         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10993         std::vector.
10994         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10995         (coff_locate_sections): Update.
10996         (coff_symfile_read): Remove cleanups.  Update.
10997         (init_stringtab): Add storage parameter.
10998         (free_stringtab, free_stringtab_cleanup): Remove.
10999         (init_lineno): Add storage parameter.
11000         (free_linetab, free_linetab_cleanup): Remove.
11001
11002 2019-03-06  Pedro Alves  <palves@redhat.com>
11003
11004         * linux-fork.c (fork_info::clobber_regs): Delete.
11005         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11006         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11007         comment.  Adjust.
11008         (scoped_switch_fork_info::scoped_switch_fork_info)
11009         (checkpoint_command, linux_fork_context): Adjust
11010         fork_save_infrun_state calls.
11011
11012 2019-03-06  Pedro Alves  <palves@redhat.com>
11013
11014         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11015         (inf_has_multiple_threads): Return 'bool' and rewrite using
11016         inferior_info::threads().
11017
11018 2019-03-06  Pedro Alves  <palves@redhat.com>
11019
11020         * linux-fork.c: Include <list>.
11021         (fork_list): Now a std::list instance.
11022         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11023         (forks_exist_p, find_last_fork): Adjust.
11024         (new_fork): Delete.
11025         (one_fork_p): New.
11026         (add_fork): Adjust.
11027         (free_fork): Delete, folded into fork_info::~fork_info().
11028         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11029         Adjust.
11030         (init_fork_list): Delete.
11031         (linux_fork_killall, linux_fork_mourn_inferior)
11032         (linux_fork_detach, info_checkpoints_command): Adjust.
11033         (_initialize_linux_fork): No longer call init_fork_list.
11034
11035 2019-03-06  Pedro Alves  <palves@redhat.com>
11036
11037         * linux-fork.c (new_fork): New, split out of ...
11038         (add_fork): ... this.  Return void.  Move "first fork" special
11039         case from here, to ...
11040         (checkpoint_command): ... here.
11041         * linux-linux.h (add_fork): Return void.
11042
11043 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11044
11045         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11046
11047 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11048             Chris January  <chris.january@arm.com>
11049             David Lecomber  <david.lecomber@arm.com>
11050
11051         * f-exp.y: New token, UNOP_INTRINSIC.
11052         (exp): New pattern using UNOP_INTRINSIC token.
11053         (f77_keywords): Add 'abs' keyword.
11054         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11055         (value_from_host_double): New function.
11056         (evaluate_subexp_f): Support UNOP_ABS.
11057
11058 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11059
11060         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11061         types.
11062
11063 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11064
11065         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11066         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11067         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11068
11069 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11070
11071         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11072
11073 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11074             Chris January  <chris.january@arm.com>
11075
11076         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11077         * f-exp.y: Define 'KIND' token.
11078         (exp): New pattern for KIND expressions.
11079         (ptype): Handle types with a kind extension.
11080         (direct_abs_decl): Extend to spot kind extensions.
11081         (f77_keywords): Add 'kind' to the list.
11082         (push_kind_type): New function.
11083         (convert_to_kind_type): New function.
11084         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11085         * parse.c (operator_length_standard): Likewise.
11086         * parser-defs.h (enum type_pieces): Add tp_kind.
11087         * std-operator.def: Add UNOP_KIND.
11088
11089 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11090
11091         * f-exp.y (f_parse): Set yydebug.
11092
11093 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11094
11095         * f-lang.c (evaluate_subexp_f): New function.
11096         (exp_descriptor_f): New global.
11097         (f_language_defn): Use exp_descriptor_f instead of
11098         exp_descriptor_standard.
11099
11100 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11101
11102         * f-exp.y (struct token): Add comments.
11103         (dot_ops): Remove uppercase versions and the end marker.
11104         (f77_keywords): Likewise.
11105         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11106         entries in the dot_ops array are case insensitive, and use
11107         strncasecmp to compare strings.  Also some whitespace cleanup in
11108         this area.  Similar for the f77_keywords array, except entries in
11109         this list might be case sensitive.
11110
11111 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11112
11113         * f-exp.y (struct f77_boolean_val): Add comments.
11114         (boolean_values): Remove uppercase versions, and end marker.
11115         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11116         and use strncasecmp to achieve case insensitivity.  Additionally,
11117         perform whitespace cleanup around this code.
11118
11119 2019-03-06  Tom Tromey  <tromey@adacore.com>
11120
11121         * remote-sim.c (gdbsim_target_open): Use result of
11122         gdb_argv::release.
11123
11124 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11125         Dirk Schubert  <dirk.schubert@arm.com>
11126         Chris January  <chris.january@arm.com>
11127
11128         * eval.c (evaluate_subexp_standard): Call Fortran argument
11129         wrapping logic.
11130         * f-lang.c (struct value): A value which can be passed into a
11131         Fortran function call.
11132         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11133         where appropriate.
11134         (struct type): Value ready for a Fortran function call.
11135         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11136         is needed.
11137         * f-lang.h (fortran_argument_convert): Declaration.
11138         (fortran_preserve_arg_pointer): Declaration.
11139         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11140
11141 2019-03-05  Tom Tromey  <tromey@adacore.com>
11142
11143         * python/py-prettyprint.c (print_string_repr): Remove #if.
11144         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11145
11146 2019-03-05  Tom Tromey  <tromey@adacore.com>
11147
11148         * target.c (the_dummy_target): Move later.  Change type to
11149         "dummy_target".
11150         (initialize_targets): Don't initialize the_dummy_target.
11151
11152 2019-03-05  Tom Tromey  <tromey@adacore.com>
11153
11154         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11155         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11156
11157 2019-03-05  Tom Tromey  <tromey@adacore.com>
11158
11159         * windows-nat.c (windows_nat_target::attach)
11160         (windows_nat_target::detach): Don't call gdb_flush.
11161         * valprint.c (generic_val_print, val_print, val_print_string):
11162         Don't call gdb_flush.
11163         * utils.c (defaulted_query): Don't call gdb_flush.
11164         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11165         * target.c (target_announce_detach): Don't call gdb_flush.
11166         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11167         * remote.c (extended_remote_target::attach): Don't call
11168         gdb_flush.
11169         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11170         * printcmd.c (do_examine): Don't call gdb_flush.
11171         (info_display_command): Don't call gdb_flush.
11172         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11173         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11174         * memattr.c (info_mem_command): Don't call gdb_flush.
11175         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11176         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11177         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11178         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11179         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11180         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11181         (gnu_nat_target::detach): Don't call gdb_flush.
11182         * f-valprint.c (f_val_print): Don't call gdb_flush.
11183         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11184         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11185         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11186         gdb_flush.
11187         * c-valprint.c (c_val_print): Don't call gdb_flush.
11188         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11189
11190 2019-03-05  Tom Tromey  <tromey@adacore.com>
11191
11192         * varobj.c (update_dynamic_varobj_children): Update.
11193         (install_default_visualizer): Use reset, not release.
11194         * value.c (set_internalvar): Update.
11195         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11196         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11197         ATTRIBUTE_UNUSED_RESULT.
11198
11199 2019-03-05  Tom Tromey  <tromey@adacore.com>
11200
11201         * remote.c (class scoped_remote_fd) <release>: Add
11202         ATTRIBUTE_UNUSED_RESULT.
11203
11204 2019-03-05  Tom Tromey  <tromey@adacore.com>
11205
11206         * macroexp.c (struct macro_buffer) <release>: Add
11207         ATTRIBUTE_UNUSED_RESULT.
11208
11209 2019-03-05  Tom Tromey  <tromey@adacore.com>
11210
11211         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11212         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11213         ATTRIBUTE_UNUSED_RESULT.
11214
11215 2019-03-05  Tom Tromey  <tromey@adacore.com>
11216
11217         * common/scoped_fd.h (class scoped_fd) <release>: Add
11218         ATTRIBUTE_UNUSED_RESULT.
11219
11220 2019-03-05  Tom Tromey  <tromey@adacore.com>
11221
11222         * parser-defs.h (struct parser_state) <release>: Add
11223         ATTRIBUTE_UNUSED_RESULT.
11224
11225 2019-03-05  Tom Tromey  <tromey@adacore.com>
11226
11227         * utils.h (class gdb_argv) <release>: Add
11228         ATTRIBUTE_UNUSED_RESULT.
11229         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11230
11231 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11232
11233         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11234         for-loop range, to avoid compiler warnings.
11235
11236         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11237         avoid compiler warnings about unused variables.
11238
11239         * NEWS: Mention end of support for native debugging on MS-Windows
11240         before XP.
11241
11242         PR gdb/24292
11243         * common/netstuff.c:
11244         * gdbserver/gdbreplay.c
11245         * gdbserver/remote-utils.c:
11246         * ser-tcp.c:
11247         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11248         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11249         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11250         'getaddrinfo' and 'freeaddrinfo' were not available before
11251         Windows XP, and mingw.org's MinGW headers by default define
11252         _WIN32_WINNT to 0x500.
11253
11254 2019-03-01  Gary Benson <gbenson@redhat.com>
11255
11256         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11257
11258 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11259             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11260
11261         PR gdb/8527
11262         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11263         set_sigint_trap, clear_sigint_trap.
11264
11265 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11266
11267         * target.c (target_detach): Clear the regcache and the
11268         frame cache.
11269
11270 2019-02-27  Pedro Alves  <palves@redhat.com>
11271
11272         * utils.c (set_screen_size): When we cap the height/width sizes,
11273         tweak the corresponding command variable to show "unlimited":
11274
11275 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11276             Pedro Alves  <palves@redhat.com>
11277
11278         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11279         before calling rl_set_screen_size.
11280
11281 2019-02-27  Tom Tromey  <tromey@adacore.com>
11282
11283         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11284         define.
11285         * python/py-value.c: Remove Python 2.4 workaround.
11286         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11287         workaround.
11288         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11289         Python 2.4 workaround.
11290         * python/python-internal.h: Remove Python 2.4 comment.
11291         (Py_ssize_t): Don't define.
11292         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11293         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11294         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11295         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11296         * python/python.c (do_start_initialization): Remove Python 2.4
11297         workaround.
11298         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11299         (print_children): Remove Python 2.4 workaround.
11300         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11301         workaround.
11302         (CHARBUFFERPROC_NAME): Remove.
11303         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11304         Python 2.4 workaround.
11305
11306 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11307
11308         * NEWS: Note minimum Python version.
11309
11310 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11311
11312         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11313         code from these functions.  Remove corresponding ifdefs.  Use
11314         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11315         Remove gotos and target of gotos.
11316         (infpy_search_memory): Likewise.
11317
11318 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11319
11320         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11321         (hppa_gdbarch_init): Don't register deleted functions with
11322         gdbarch.
11323
11324 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11325
11326         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11327         (h8300_unwind_sp): Delete.
11328         (h8300_dummy_id): Delete.
11329         (h8300_gdbarch_init): Don't register deleted functions with
11330         gdbarch.
11331
11332 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11333
11334         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11335         (ft32_unwind_pc): Delete.
11336         (ft32_unwind_sp): Delete.
11337         (ft32_gdbarch_init): Don't register deleted functions with
11338         gdbarch.
11339
11340 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11341
11342         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11343         (frv_unwind_pc): Delete.
11344         (frv_unwind_sp): Delete.
11345         (frv_gdbarch_init): Don't register deleted functions with
11346         gdbarch.
11347
11348 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11349
11350         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11351         (riscv_unwind_pc): Delete.
11352         (riscv_unwind_sp): Delete.
11353         (riscv_gdbarch_init): Don't register deleted functions with
11354         gdbarch.
11355
11356 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11357
11358         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11359         (csky_unwind_pc): Delete.
11360         (csky_unwind_sp): Delete.
11361         (csky_gdbarch_init): Don't register deleted functions with
11362         gdbarch.
11363
11364 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11365
11366         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11367         (cris_unwind_pc): Delete.
11368         (cris_unwind_sp): Delete.
11369         (cris_gdbarch_init): Don't register deleted functions with
11370         gdbarch.
11371
11372 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11373
11374         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11375         (bfin_unwind_pc): Delete.
11376         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11377
11378 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11379
11380         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11381         (arm_unwind_pc): Delete.
11382         (arm_unwind_sp): Delete.
11383         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11384
11385 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11386
11387         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11388         (arc_unwind_pc): Delete.
11389         (arc_unwind_sp): Delete.
11390         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11391
11392 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11393
11394         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11395         (alpha_unwind_pc): Delete.
11396         (alpha_gdbarch_init): Don't register deleted functions with
11397         gdbarch.
11398
11399 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11400
11401         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11402         (aarch64_unwind_pc): Delete.
11403         (aarch64_unwind_sp): Delete.
11404         (aarch64_gdbarch_init): Don't register deleted functions with
11405         gdbarch.
11406
11407 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11408
11409         * gdbtypes.c (type_align): Don't consider static members when
11410         computing structure alignment.
11411
11412 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11413
11414         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11415         return 0 for other types.
11416         * arch-utils.c (default_type_align): Always return 0.
11417         * gdbarch.h: Regenerate.
11418         * gdbarch.sh (type_align): Extend comment.
11419         * gdbtypes.c (type_align): Add additional comments, always call
11420         gdbarch_type_align before applying the default rules.
11421         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11422         generic code will then apply a suitable default.
11423         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11424         types, return 0 for other types.
11425
11426 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11427
11428         * NEWS: Create a new section for the next release branch.
11429         Rename the section of the current branch, now that it has
11430         been cut.
11431
11432 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11433
11434         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11435         * version.in: Bump version to 8.3.50.DATE-git.
11436
11437 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11438
11439         * aix-thread.c (ptid_cmp): Remove unused variable.
11440         (get_signaled_thread): Likewise.
11441         (store_regs_user_thread): Likewise.
11442         (store_regs_kernel_thread): Likewise.
11443         (fetch_regs_kernel_thread): Remove shadowed variable.
11444
11445 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11446
11447         * features/riscv/32bit-cpu.xml: Add register numbers.
11448         * features/riscv/32bit-fpu.c: Regenerate.
11449         * features/riscv/32bit-fpu.xml: Add register numbers.
11450         * features/riscv/64bit-cpu.xml: Add register numbers.
11451         * features/riscv/64bit-fpu.c: Regenerate.
11452         * features/riscv/64bit-fpu.xml: Add register numbers.
11453
11454 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11455
11456         * NEWS: Mention two argument form of gdb.Value constructor.
11457         * python/py-value.c (convert_buffer_and_type_to_value): New
11458         function.
11459         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11460         Add support for handling an optional second argument.  Call
11461         convert_buffer_and_type_to_value as appropriate.
11462         * python/python-internal.h (Py_buffer_deleter): New struct.
11463         (Py_buffer_up): New typedef.
11464
11465 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11466
11467         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11468         instead of releasing ownership.
11469
11470 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11471
11472         * dwarf2read.c (open_and_init_dwp_file): Call
11473         elf_numsections instead of bfd_count_sections to initialize
11474         dwp_file->num_sections.
11475
11476 2019-02-25  Tom Tromey  <tromey@adacore.com>
11477
11478         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11479
11480 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11481
11482         * gcore.in: Add '--readnever' option when invoking GDB.
11483
11484 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11485
11486         * MAINTAINERS: Update my email address.
11487
11488 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11489
11490         * build-id.c (build_id_to_debug_bfd_1): New function.
11491         (build_id_to_debug_bfd): Look for separate debug file in
11492         sysroot.
11493
11494 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11495
11496         * gdbarch.sh: Update the copyright year range that is placed into
11497         generated files.
11498
11499 2019-02-22  Keith Seitz  <keiths@redhat.com>
11500
11501         PR symtab/23853
11502         * linespec.c (create_sals_line_offset): Search for the default
11503         symtab's filename instead of its fullname.
11504
11505 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11506
11507         * NEWS: Update style defaults.
11508
11509 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11510
11511         * main.c (captured_main_1): Disable styling in batch mode.
11512
11513 2019-02-20  Tom Tromey  <tom@tromey.com>
11514
11515         * symtab.c (symtab_symbol_info): Fix typos.
11516
11517 2019-02-20  Tom Tromey  <tromey@adacore.com>
11518
11519         * findcmd.c (_initialize_mem_search): Use upper case for
11520         metasyntactic variables.
11521
11522 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11523
11524         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11525         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11526
11527 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11528
11529         * top.h (source_file_name): Change to std::string.
11530         * top.c (source_file_name): Likewise.
11531         (command_line_input): Adjust.
11532         * cli/cli-script.c (script_from_file): Adjust.
11533
11534 2019-02-19  Tom Tromey  <tromey@adacore.com>
11535
11536         * ravenscar-thread.c
11537         (ravenscar_thread_target::update_thread_list): Don't call
11538         ada_build_task_list.
11539         * ada-lang.h (ada_build_task_list): Don't declare.
11540         * ada-tasks.c (struct ada_tasks_inferior_data)
11541         <task_list_valid_p>: Now bool.
11542         (read_known_tasks, ada_task_list_changed)
11543         (ada_tasks_invalidate_inferior_data): Update.
11544         (read_known_tasks_array): Return bool.
11545         (read_known_tasks_list): Likewise.
11546         (read_known_tasks): Return void.
11547         (ada_build_task_list): Now static.
11548
11549 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11550
11551         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11552         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11553
11554 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11555
11556         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11557         variant for ada_tasks_pspace_data_handle and
11558         ada_tasks_inferior_data_handle.
11559         (ada_tasks_pspace_data_cleanup): New function.
11560         (ada_tasks_inferior_data_cleanup): New function.
11561
11562 2019-02-17  Tom Tromey  <tom@tromey.com>
11563
11564         * macrotab.h (macro_source_fullname): Return a std::string.
11565         * macrotab.c (macro_include, check_for_redefinition)
11566         (macro_undef, macro_lookup_definition, foreach_macro)
11567         (foreach_macro_in_scope): Update.
11568         (macro_source_fullname): Return a std::string.
11569         * macrocmd.c (show_pp_source_pos): Update.
11570
11571 2019-02-17  Tom Tromey  <tom@tromey.com>
11572
11573         * macrocmd.c (show_pp_source_pos): Style the file names.
11574
11575 2019-02-17  Tom Tromey  <tom@tromey.com>
11576
11577         PR tui/24197:
11578         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11579
11580 2019-02-17  Tom Tromey  <tom@tromey.com>
11581
11582         * ada-lang.c (user_select_syms): Use filtered printing.
11583         * utils.c (wrap_style): New global.
11584         (desired_style): Remove.
11585         (emit_style_escape): Add stream parameter.
11586         (set_output_style, reset_terminal_style, prompt_for_continue):
11587         Update.
11588         (flush_wrap_buffer): Only flush gdb_stdout.
11589         (wrap_here): Set wrap_style.
11590         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11591         treat escape sequences as a character.  Change when wrap buffer is
11592         flushed.
11593         (fputs_styled): Do not set the output style when the default is
11594         requested.
11595         * ui-style.h (struct ui_file_style) <is_default>: New method.
11596         * source.c (print_source_lines_base): Emit escape sequences in one
11597         piece.
11598
11599 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11600
11601         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11602         integers and enumeration types.
11603
11604 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11605
11606         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11607         instead of lookup_symbol_in_language
11608         (do_exact_match): New function.
11609         (ada_get_symbol_name_matcher): Return do_exact_match when
11610         doing a verbatim match.
11611
11612 2019-02-15  Tom Tromey  <tromey@adacore.com>
11613
11614         * ravenscar-thread.c (ravenscar_thread_target::resume)
11615         (ravenscar_thread_target::wait): Special case wildcard requests.
11616
11617 2019-02-15  Tom Tromey  <tromey@adacore.com>
11618
11619         * ravenscar-thread.c (base_ptid): Remove.
11620         (struct ravenscar_thread_target) <close>: New method.
11621         <m_base_ptid>: New member.
11622         <update_inferior_ptid, active_task, task_is_currently_active,
11623         runtime_initialized>: Declare methods.
11624         <ravenscar_thread_target>: Add constructor.
11625         (ravenscar_thread_target::task_is_currently_active)
11626         (ravenscar_thread_target::update_inferior_ptid)
11627         (ravenscar_runtime_initialized): Rename.  Now methods.
11628         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11629         (ravenscar_thread_target::update_thread_list): Update.
11630         (ravenscar_thread_target::active_task): Now method.
11631         (ravenscar_thread_target::store_registers)
11632         (ravenscar_thread_target::prepare_to_store)
11633         (ravenscar_thread_target::prepare_to_store)
11634         (ravenscar_thread_target::mourn_inferior): Update.
11635         (ravenscar_inferior_created): Use "new" to create target.
11636         (ravenscar_thread_target::get_ada_task_ptid): Update.
11637         (_initialize_ravenscar): Don't initialize base_ptid.
11638         (ravenscar_ops): Remove global.
11639
11640 2019-02-15  Tom Tromey  <tromey@adacore.com>
11641
11642         * target.h (push_target): Declare new overload.
11643         * target.c (push_target): New overload, taking an rvalue reference.
11644         * remote.c (remote_target::open_1): Use push_target overload.
11645         * corelow.c (core_target_open): Use push_target overload.
11646
11647 2019-02-15  Tom Tromey  <tromey@adacore.com>
11648
11649         * ravenscar-thread.c (is_ravenscar_task)
11650         (ravenscar_task_is_currently_active): Return bool.
11651         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11652         (_initialize_ravenscar): Remove "(void)".
11653         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11654         Return bool.
11655
11656 2019-02-15  Tom Tromey  <tromey@adacore.com>
11657
11658         * ravenscar-thread.c (ravenscar_runtime_initializer)
11659         (has_ravenscar_runtime, get_running_thread_id)
11660         (ravenscar_thread_target::resume): Fix indentation.
11661
11662 2019-02-15  Tom Tromey  <tromey@adacore.com>
11663
11664         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11665         from ravenscar_arch_ops.
11666         (sparc_ravenscar_ops::fetch_registers)
11667         (sparc_ravenscar_ops::store_registers): Now methods.
11668         (sparc_ravenscar_prepare_to_store): Remove.
11669         (sparc_ravenscar_ops): Redefine.
11670         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11671         methods and destructor.  Remove members.
11672         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11673         (ravenscar_thread_target::store_registers)
11674         (ravenscar_thread_target::prepare_to_store): Update.
11675         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11676         Remove.
11677         (struct ppc_ravenscar_powerpc_ops): Derive from
11678         ravenscar_arch_ops.
11679         (ppc_ravenscar_powerpc_ops::fetch_registers)
11680         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11681         (ppc_ravenscar_powerpc_ops): Redefine.
11682         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11683         (ppc_ravenscar_e500_ops::fetch_registers)
11684         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11685         (ppc_ravenscar_e500_ops): Redefine.
11686         * aarch64-ravenscar-thread.c
11687         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11688         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11689         (aarch64_ravenscar_fetch_registers)
11690         (aarch64_ravenscar_store_registers): Now methods.
11691         (aarch64_ravenscar_ops): Redefine.
11692
11693 2019-02-15  Tom Tromey  <tromey@adacore.com>
11694
11695         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11696         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11697         (ravenscar_thread_target::stopped_by_watchpoint)
11698         (ravenscar_thread_target::stopped_data_address)
11699         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11700
11701 2019-02-15  Tom Tromey  <tromey@adacore.com>
11702
11703         * ravenscar-thread.c: Fix some typos.
11704
11705 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11706             Tom Tromey  <tromey@adacore.com>
11707
11708         * ada-lang.c (ada_exception_sal): Change addr_string to a
11709         std::string.
11710         (create_ada_exception_catchpoint): Update.
11711
11712 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11713             Tom Tromey  <tromey@adacore.com>
11714
11715         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11716         (bp_location_ops): Remove.
11717         (base_breakpoint_allocate_location): Update.
11718         (free_bp_location): Update.
11719         * ada-lang.c (class ada_catchpoint_location)
11720         <ada_catchpoint_location>: Remove ops parameter.
11721         (ada_catchpoint_location_dtor): Remove.
11722         (ada_catchpoint_location_ops): Remove.
11723         (allocate_location_exception): Update.
11724         * breakpoint.h (struct bp_location_ops): Remove.
11725         (class bp_location) <bp_location>: Remove bp_location_ops
11726         parameter.
11727         <~bp_location>: Add destructor.
11728         <ops>: Remove.
11729
11730 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11731             Pedro Alves  <palves@redhat.com>
11732
11733         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11734         'PATH_MAX'.
11735
11736 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11737             Samuel Thibault  <samuel.thibault@gnu.org>
11738             Thomas Schwinge  <thomas@codesourcery.com>
11739
11740         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11741         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11742
11743 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11744
11745         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11746         (check_empty): Use "const char *".
11747
11748         * gnu-nat.c (gnu_nat_target::detach): Instead of
11749         'detach_inferior (pid)' call
11750         'detach_inferior (find_inferior_pid (pid))'.
11751
11752         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11753         'nat/fork-inferior.o'.
11754         * gnu-nat.c: #include "nat/fork-inferior.h".
11755
11756         * gnu-nat.c (gnu_nat_target::detach): Instead of
11757         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11758         * gnu-nat.h: #include "inf-child.h".
11759         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11760         'i386_gnu_nat_target::fetch_registers'.
11761         (gnu_store_registers): Rename/move to
11762         'i386_gnu_nat_target::store_registers'.
11763
11764         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11765         * gnu-nat.h (mach_thread_info): New function.
11766         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11767
11768         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11769
11770 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11771
11772         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11773
11774 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11775
11776         * windows-nat.c (windows_add_thread): Add new parameter
11777         "main_thread_p" with default value set to false.  Update
11778         function documentation as well as all callers.
11779         (windows_delete_thread): Likewise.
11780         (fake_create_process): Update call to windows_add_thread.
11781         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11782         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11783         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11784         call to windows_delete_thread.
11785
11786 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11787
11788         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11789
11790 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11791
11792         * symfile.c (find_separate_debug_file): Use canonical path of
11793         sysroot with child_path instead of gdb_sysroot if it is valid.
11794
11795 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11796
11797         * symfile.c (find_separate_debug_file): Use child_path to
11798         determine if an object file is under a sysroot.
11799
11800 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11801
11802         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11803         unittests/child-path-selftests.c.
11804         * common/pathstuff.c (child_path): New function.
11805         * common/pathstuff.h (child_path): New prototype.
11806         * unittests/child-path-selftests.c: New file.
11807
11808 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11809
11810         * symfile.c (find_separate_debug_file): Look for separate debug
11811         files in debug directories under the sysroot.
11812
11813 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11814
11815         * symtab.h (struct minimal_symbol data_p): New const method.
11816         (struct minimal_symbol text_p): Likewise.
11817         * symtab.c (output_source_filename): Use file name style
11818         to print file name.
11819         (print_symbol_info): Likewise.
11820         (print_msymbol_info): Use address style to print addresses.
11821         Use function name style to print executable text symbols.
11822         (expand_symtab_containing_pc): Use data_p.
11823         (find_pc_sect_compunit_symtab): Likewise.
11824
11825 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11826
11827         * breakpoint.c (describe_other_breakpoints): Use address style
11828         to print addresses.
11829         (say_where): Likewise.
11830
11831 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11832
11833         * ada-typeprint.c (print_func_type): Print function name
11834         style to print function name.
11835         * c-typeprint.c (c_print_type_1): Likewise.
11836
11837 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11838
11839         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11840         for execve.
11841
11842 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11843
11844         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11845         type_stack.
11846
11847 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11848
11849         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11850         TYPE_CODE_REF types.
11851
11852 2019-02-08  Jim Wilson  <jimw@sifive.com>
11853
11854         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11855         (riscv_linux_fregset): New.
11856         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11857
11858 2019-02-07  Tom Tromey  <tom@tromey.com>
11859
11860         * thread.c (thread_cancel_execution_command): Update.
11861         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11862         methods.
11863         (struct thread_fsm_ops): Remove.
11864         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11865         (thread_fsm_should_stop, thread_fsm_return_value)
11866         (thread_fsm_set_finished, thread_fsm_finished_p)
11867         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11868         Don't declare.
11869         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11870         * infrun.c (clear_proceed_status_thread)
11871         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11872         (print_stop_event): Update.
11873         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11874         Add constructor.
11875         (step_command_fsm_ops): Remove.
11876         (new_step_command_fsm): Remove.
11877         (step_1): Update.
11878         (step_command_fsm::should_stop): Rename from
11879         step_command_fsm_should_stop.
11880         (step_command_fsm::clean_up): Rename from
11881         step_command_fsm_clean_up.
11882         (step_command_fsm::do_async_reply_reason): Rename from
11883         step_command_fsm_async_reply_reason.
11884         (struct until_next_fsm): Inherit from thread_fsm.  Add
11885         constructor.
11886         (until_next_fsm_ops): Remove.
11887         (new_until_next_fsm): Remove.
11888         (until_next_fsm::should_stop): Rename from
11889         until_next_fsm_should_stop.
11890         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11891         (until_next_fsm::do_async_reply_reason): Rename from
11892         until_next_fsm_async_reply_reason.
11893         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11894         constructor.  Change type of breakpoint.
11895         (finish_command_fsm_ops): Remove.
11896         (new_finish_command_fsm): Remove.
11897         (finish_command_fsm::should_stop): Rename from
11898         finish_command_fsm_should_stop.
11899         (finish_command_fsm::clean_up): Rename from
11900         finish_command_fsm_clean_up.
11901         (finish_command_fsm::return_value): Rename from
11902         finish_command_fsm_return_value.
11903         (finish_command_fsm::do_async_reply_reason): Rename from
11904         finish_command_fsm_async_reply_reason.
11905         (finish_command): Update.
11906         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11907         Add constructor.
11908         (call_thread_fsm_ops): Remove.
11909         (call_thread_fsm::call_thread_fsm): Rename from
11910         new_call_thread_fsm.
11911         (call_thread_fsm::should_stop): Rename from
11912         call_thread_fsm_should_stop.
11913         (call_thread_fsm::should_notify_stop): Rename from
11914         call_thread_fsm_should_notify_stop.
11915         (run_inferior_call, call_function_by_hand_dummy): Update.
11916         * cli/cli-interp.c (should_print_stop_to_console): Update.
11917         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11918         Add constructor.  Change type of location_breakpoint,
11919         caller_breakpoint.
11920         (until_break_fsm_ops): Remove.
11921         (new_until_break_fsm): Remove.
11922         (until_break_fsm::should_stop): Rename from
11923         until_break_fsm_should_stop.
11924         (until_break_fsm::clean_up): Rename from
11925         until_break_fsm_clean_up.
11926         (until_break_fsm::do_async_reply_reason): Rename from
11927         until_break_fsm_async_reply_reason.
11928         (until_break_command): Update.
11929         * thread-fsm.c: Remove.
11930         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11931
11932 2019-02-07  Tom Tromey  <tom@tromey.com>
11933
11934         * yy-remap.h: Add include guard.
11935         * xtensa-tdep.h: Add include guard.
11936         * xcoffread.h: Rename include guard.
11937         * varobj-iter.h: Add include guard.
11938         * tui/tui.h: Rename include guard.
11939         * tui/tui-winsource.h: Rename include guard.
11940         * tui/tui-wingeneral.h: Rename include guard.
11941         * tui/tui-windata.h: Rename include guard.
11942         * tui/tui-win.h: Rename include guard.
11943         * tui/tui-stack.h: Rename include guard.
11944         * tui/tui-source.h: Rename include guard.
11945         * tui/tui-regs.h: Rename include guard.
11946         * tui/tui-out.h: Rename include guard.
11947         * tui/tui-layout.h: Rename include guard.
11948         * tui/tui-io.h: Rename include guard.
11949         * tui/tui-hooks.h: Rename include guard.
11950         * tui/tui-file.h: Rename include guard.
11951         * tui/tui-disasm.h: Rename include guard.
11952         * tui/tui-data.h: Rename include guard.
11953         * tui/tui-command.h: Rename include guard.
11954         * tic6x-tdep.h: Add include guard.
11955         * target/waitstatus.h: Rename include guard.
11956         * target/wait.h: Rename include guard.
11957         * target/target.h: Rename include guard.
11958         * target/resume.h: Rename include guard.
11959         * target-float.h: Rename include guard.
11960         * stabsread.h: Add include guard.
11961         * rs6000-tdep.h: Add include guard.
11962         * riscv-fbsd-tdep.h: Add include guard.
11963         * regformats/regdef.h: Rename include guard.
11964         * record.h: Rename include guard.
11965         * python/python.h: Rename include guard.
11966         * python/python-internal.h: Rename include guard.
11967         * python/py-stopevent.h: Rename include guard.
11968         * python/py-ref.h: Rename include guard.
11969         * python/py-record.h: Rename include guard.
11970         * python/py-record-full.h: Rename include guard.
11971         * python/py-record-btrace.h: Rename include guard.
11972         * python/py-instruction.h: Rename include guard.
11973         * python/py-events.h: Rename include guard.
11974         * python/py-event.h: Rename include guard.
11975         * procfs.h: Add include guard.
11976         * proc-utils.h: Add include guard.
11977         * p-lang.h: Add include guard.
11978         * or1k-tdep.h: Rename include guard.
11979         * observable.h: Rename include guard.
11980         * nto-tdep.h: Rename include guard.
11981         * nat/x86-linux.h: Rename include guard.
11982         * nat/x86-linux-dregs.h: Rename include guard.
11983         * nat/x86-gcc-cpuid.h: Add include guard.
11984         * nat/x86-dregs.h: Rename include guard.
11985         * nat/x86-cpuid.h: Rename include guard.
11986         * nat/ppc-linux.h: Rename include guard.
11987         * nat/mips-linux-watch.h: Rename include guard.
11988         * nat/linux-waitpid.h: Rename include guard.
11989         * nat/linux-ptrace.h: Rename include guard.
11990         * nat/linux-procfs.h: Rename include guard.
11991         * nat/linux-osdata.h: Rename include guard.
11992         * nat/linux-nat.h: Rename include guard.
11993         * nat/linux-namespaces.h: Rename include guard.
11994         * nat/linux-btrace.h: Rename include guard.
11995         * nat/glibc_thread_db.h: Rename include guard.
11996         * nat/gdb_thread_db.h: Rename include guard.
11997         * nat/gdb_ptrace.h: Rename include guard.
11998         * nat/fork-inferior.h: Rename include guard.
11999         * nat/amd64-linux-siginfo.h: Rename include guard.
12000         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12001         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12002         * nat/aarch64-linux.h: Rename include guard.
12003         * nat/aarch64-linux-hw-point.h: Rename include guard.
12004         * mn10300-tdep.h: Add include guard.
12005         * mips-linux-tdep.h: Add include guard.
12006         * mi/mi-parse.h: Rename include guard.
12007         * mi/mi-out.h: Rename include guard.
12008         * mi/mi-main.h: Rename include guard.
12009         * mi/mi-interp.h: Rename include guard.
12010         * mi/mi-getopt.h: Rename include guard.
12011         * mi/mi-console.h: Rename include guard.
12012         * mi/mi-common.h: Rename include guard.
12013         * mi/mi-cmds.h: Rename include guard.
12014         * mi/mi-cmd-break.h: Rename include guard.
12015         * m2-lang.h: Add include guard.
12016         * location.h: Rename include guard.
12017         * linux-record.h: Rename include guard.
12018         * linux-nat.h: Add include guard.
12019         * linux-fork.h: Add include guard.
12020         * i386-darwin-tdep.h: Rename include guard.
12021         * hppa-linux-offsets.h: Add include guard.
12022         * guile/guile.h: Rename include guard.
12023         * guile/guile-internal.h: Rename include guard.
12024         * gnu-nat.h: Rename include guard.
12025         * gdb-stabs.h: Rename include guard.
12026         * frv-tdep.h: Add include guard.
12027         * f-lang.h: Add include guard.
12028         * event-loop.h: Add include guard.
12029         * darwin-nat.h: Rename include guard.
12030         * cp-abi.h: Rename include guard.
12031         * config/sparc/nm-sol2.h: Rename include guard.
12032         * config/nm-nto.h: Rename include guard.
12033         * config/nm-linux.h: Add include guard.
12034         * config/i386/nm-i386gnu.h: Rename include guard.
12035         * config/djgpp/nl_types.h: Rename include guard.
12036         * config/djgpp/langinfo.h: Rename include guard.
12037         * compile/gcc-cp-plugin.h: Add include guard.
12038         * compile/gcc-c-plugin.h: Add include guard.
12039         * compile/compile.h: Rename include guard.
12040         * compile/compile-object-run.h: Rename include guard.
12041         * compile/compile-object-load.h: Rename include guard.
12042         * compile/compile-internal.h: Rename include guard.
12043         * compile/compile-cplus.h: Rename include guard.
12044         * compile/compile-c.h: Rename include guard.
12045         * common/xml-utils.h: Rename include guard.
12046         * common/x86-xstate.h: Rename include guard.
12047         * common/version.h: Rename include guard.
12048         * common/vec.h: Rename include guard.
12049         * common/tdesc.h: Rename include guard.
12050         * common/selftest.h: Rename include guard.
12051         * common/scoped_restore.h: Rename include guard.
12052         * common/scoped_mmap.h: Rename include guard.
12053         * common/scoped_fd.h: Rename include guard.
12054         * common/safe-iterator.h: Rename include guard.
12055         * common/run-time-clock.h: Rename include guard.
12056         * common/refcounted-object.h: Rename include guard.
12057         * common/queue.h: Rename include guard.
12058         * common/ptid.h: Rename include guard.
12059         * common/print-utils.h: Rename include guard.
12060         * common/preprocessor.h: Rename include guard.
12061         * common/pathstuff.h: Rename include guard.
12062         * common/observable.h: Rename include guard.
12063         * common/netstuff.h: Rename include guard.
12064         * common/job-control.h: Rename include guard.
12065         * common/host-defs.h: Rename include guard.
12066         * common/gdb_wait.h: Rename include guard.
12067         * common/gdb_vecs.h: Rename include guard.
12068         * common/gdb_unlinker.h: Rename include guard.
12069         * common/gdb_unique_ptr.h: Rename include guard.
12070         * common/gdb_tilde_expand.h: Rename include guard.
12071         * common/gdb_sys_time.h: Rename include guard.
12072         * common/gdb_string_view.h: Rename include guard.
12073         * common/gdb_splay_tree.h: Rename include guard.
12074         * common/gdb_setjmp.h: Rename include guard.
12075         * common/gdb_ref_ptr.h: Rename include guard.
12076         * common/gdb_optional.h: Rename include guard.
12077         * common/gdb_locale.h: Rename include guard.
12078         * common/gdb_assert.h: Rename include guard.
12079         * common/filtered-iterator.h: Rename include guard.
12080         * common/filestuff.h: Rename include guard.
12081         * common/fileio.h: Rename include guard.
12082         * common/environ.h: Rename include guard.
12083         * common/common-utils.h: Rename include guard.
12084         * common/common-types.h: Rename include guard.
12085         * common/common-regcache.h: Rename include guard.
12086         * common/common-inferior.h: Rename include guard.
12087         * common/common-gdbthread.h: Rename include guard.
12088         * common/common-exceptions.h: Rename include guard.
12089         * common/common-defs.h: Rename include guard.
12090         * common/common-debug.h: Rename include guard.
12091         * common/cleanups.h: Rename include guard.
12092         * common/buffer.h: Rename include guard.
12093         * common/btrace-common.h: Rename include guard.
12094         * common/break-common.h: Rename include guard.
12095         * cli/cli-utils.h: Rename include guard.
12096         * cli/cli-style.h: Rename include guard.
12097         * cli/cli-setshow.h: Rename include guard.
12098         * cli/cli-script.h: Rename include guard.
12099         * cli/cli-interp.h: Rename include guard.
12100         * cli/cli-decode.h: Rename include guard.
12101         * cli/cli-cmds.h: Rename include guard.
12102         * charset-list.h: Add include guard.
12103         * buildsym-legacy.h: Rename include guard.
12104         * bfin-tdep.h: Add include guard.
12105         * ax.h: Rename include guard.
12106         * arm-linux-tdep.h: Add include guard.
12107         * arm-fbsd-tdep.h: Add include guard.
12108         * arch/xtensa.h: Rename include guard.
12109         * arch/tic6x.h: Add include guard.
12110         * arch/i386.h: Add include guard.
12111         * arch/arm.h: Rename include guard.
12112         * arch/arm-linux.h: Rename include guard.
12113         * arch/arm-get-next-pcs.h: Rename include guard.
12114         * arch/amd64.h: Add include guard.
12115         * arch/aarch64-insn.h: Rename include guard.
12116         * arch-utils.h: Rename include guard.
12117         * annotate.h: Add include guard.
12118         * amd64-darwin-tdep.h: Rename include guard.
12119         * aarch64-linux-tdep.h: Add include guard.
12120         * aarch64-fbsd-tdep.h: Add include guard.
12121         * aarch32-linux-nat.h: Add include guard.
12122
12123 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12124
12125         * macrotab.c (macro_define_internal): New function that
12126         factorizes macro_define_object_internal and macro_define_function
12127         code.
12128         (macro_define_object_internal): Use macro_define_internal.
12129         (macro_define_function): Likewise.
12130
12131 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12132
12133         * macrocmd.c (extract_identifier): Return
12134         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12135         callers.
12136
12137 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12138
12139         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12140
12141 2019-02-05  Tom Tromey  <tom@tromey.com>
12142
12143         * target.c (target_stack::unpush): Move assertion earlier.
12144
12145 2019-01-30  Tom Tromey  <tom@tromey.com>
12146
12147         PR python/23615:
12148         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12149         (gdbpy_parse_and_eval): Likewise.
12150         * python/python-internal.h (gdbpy_allow_threads): New class.
12151
12152 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12153
12154         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12155         (aarch64_fbsd_fpregmap): Move earlier.
12156         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12157         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12158         instead of individual calls to trad_frame_set_reg_addr.
12159         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12160         earlier.
12161         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12162         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12163         instead of individual calls to trad_frame_set_reg_addr.
12164
12165 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12166
12167         * CONTRIBUTE: Replace contribution list with wiki link.
12168
12169 2019-01-25  Tom Tromey  <tom@tromey.com>
12170
12171         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12172
12173 2019-01-25  Tom Tromey  <tom@tromey.com>
12174
12175         * xtensa-linux-nat.c: Fix common/ includes.
12176         * xml-support.h: Fix common/ includes.
12177         * xml-support.c: Fix common/ includes.
12178         * x86-linux-nat.c: Fix common/ includes.
12179         * windows-nat.c: Fix common/ includes.
12180         * varobj.h: Fix common/ includes.
12181         * varobj.c: Fix common/ includes.
12182         * value.c: Fix common/ includes.
12183         * valops.c: Fix common/ includes.
12184         * utils.c: Fix common/ includes.
12185         * unittests/xml-utils-selftests.c: Fix common/ includes.
12186         * unittests/utils-selftests.c: Fix common/ includes.
12187         * unittests/unpack-selftests.c: Fix common/ includes.
12188         * unittests/tracepoint-selftests.c: Fix common/ includes.
12189         * unittests/style-selftests.c: Fix common/ includes.
12190         * unittests/string_view-selftests.c: Fix common/ includes.
12191         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12192         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12193         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12194         * unittests/rsp-low-selftests.c: Fix common/ includes.
12195         * unittests/parse-connection-spec-selftests.c: Fix common/
12196         includes.
12197         * unittests/optional-selftests.c: Fix common/ includes.
12198         * unittests/offset-type-selftests.c: Fix common/ includes.
12199         * unittests/observable-selftests.c: Fix common/ includes.
12200         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12201         * unittests/memrange-selftests.c: Fix common/ includes.
12202         * unittests/memory-map-selftests.c: Fix common/ includes.
12203         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12204         * unittests/function-view-selftests.c: Fix common/ includes.
12205         * unittests/environ-selftests.c: Fix common/ includes.
12206         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12207         * unittests/common-utils-selftests.c: Fix common/ includes.
12208         * unittests/cli-utils-selftests.c: Fix common/ includes.
12209         * unittests/array-view-selftests.c: Fix common/ includes.
12210         * ui-file.c: Fix common/ includes.
12211         * tui/tui-io.c: Fix common/ includes.
12212         * tracepoint.h: Fix common/ includes.
12213         * tracepoint.c: Fix common/ includes.
12214         * tracefile-tfile.c: Fix common/ includes.
12215         * top.h: Fix common/ includes.
12216         * top.c: Fix common/ includes.
12217         * thread.c: Fix common/ includes.
12218         * target/waitstatus.h: Fix common/ includes.
12219         * target/waitstatus.c: Fix common/ includes.
12220         * target.h: Fix common/ includes.
12221         * target.c: Fix common/ includes.
12222         * target-memory.c: Fix common/ includes.
12223         * target-descriptions.c: Fix common/ includes.
12224         * symtab.h: Fix common/ includes.
12225         * symfile.c: Fix common/ includes.
12226         * stap-probe.c: Fix common/ includes.
12227         * spu-linux-nat.c: Fix common/ includes.
12228         * sparc-nat.c: Fix common/ includes.
12229         * source.c: Fix common/ includes.
12230         * solib.c: Fix common/ includes.
12231         * solib-target.c: Fix common/ includes.
12232         * ser-unix.c: Fix common/ includes.
12233         * ser-tcp.c: Fix common/ includes.
12234         * ser-pipe.c: Fix common/ includes.
12235         * ser-base.c: Fix common/ includes.
12236         * selftest-arch.c: Fix common/ includes.
12237         * s12z-tdep.c: Fix common/ includes.
12238         * rust-exp.y: Fix common/ includes.
12239         * rs6000-aix-tdep.c: Fix common/ includes.
12240         * riscv-tdep.c: Fix common/ includes.
12241         * remote.c: Fix common/ includes.
12242         * remote-notif.h: Fix common/ includes.
12243         * remote-fileio.h: Fix common/ includes.
12244         * remote-fileio.c: Fix common/ includes.
12245         * regcache.h: Fix common/ includes.
12246         * regcache.c: Fix common/ includes.
12247         * record-btrace.c: Fix common/ includes.
12248         * python/python.c: Fix common/ includes.
12249         * python/py-type.c: Fix common/ includes.
12250         * python/py-inferior.c: Fix common/ includes.
12251         * progspace.h: Fix common/ includes.
12252         * producer.c: Fix common/ includes.
12253         * procfs.c: Fix common/ includes.
12254         * proc-api.c: Fix common/ includes.
12255         * printcmd.c: Fix common/ includes.
12256         * ppc-linux-nat.c: Fix common/ includes.
12257         * parser-defs.h: Fix common/ includes.
12258         * osdata.c: Fix common/ includes.
12259         * obsd-nat.c: Fix common/ includes.
12260         * nat/x86-linux.c: Fix common/ includes.
12261         * nat/x86-linux-dregs.c: Fix common/ includes.
12262         * nat/x86-dregs.h: Fix common/ includes.
12263         * nat/x86-dregs.c: Fix common/ includes.
12264         * nat/ppc-linux.c: Fix common/ includes.
12265         * nat/mips-linux-watch.h: Fix common/ includes.
12266         * nat/mips-linux-watch.c: Fix common/ includes.
12267         * nat/linux-waitpid.c: Fix common/ includes.
12268         * nat/linux-ptrace.h: Fix common/ includes.
12269         * nat/linux-ptrace.c: Fix common/ includes.
12270         * nat/linux-procfs.c: Fix common/ includes.
12271         * nat/linux-personality.c: Fix common/ includes.
12272         * nat/linux-osdata.c: Fix common/ includes.
12273         * nat/linux-namespaces.c: Fix common/ includes.
12274         * nat/linux-btrace.h: Fix common/ includes.
12275         * nat/linux-btrace.c: Fix common/ includes.
12276         * nat/fork-inferior.c: Fix common/ includes.
12277         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12278         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12279         * nat/aarch64-linux.c: Fix common/ includes.
12280         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12281         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12282         * namespace.h: Fix common/ includes.
12283         * mips-linux-tdep.c: Fix common/ includes.
12284         * minsyms.c: Fix common/ includes.
12285         * mi/mi-parse.h: Fix common/ includes.
12286         * mi/mi-main.c: Fix common/ includes.
12287         * mi/mi-cmd-env.c: Fix common/ includes.
12288         * memrange.h: Fix common/ includes.
12289         * memattr.c: Fix common/ includes.
12290         * maint.h: Fix common/ includes.
12291         * maint.c: Fix common/ includes.
12292         * main.c: Fix common/ includes.
12293         * machoread.c: Fix common/ includes.
12294         * location.c: Fix common/ includes.
12295         * linux-thread-db.c: Fix common/ includes.
12296         * linux-nat.c: Fix common/ includes.
12297         * linux-fork.c: Fix common/ includes.
12298         * inline-frame.c: Fix common/ includes.
12299         * infrun.c: Fix common/ includes.
12300         * inflow.c: Fix common/ includes.
12301         * inferior.h: Fix common/ includes.
12302         * inferior.c: Fix common/ includes.
12303         * infcmd.c: Fix common/ includes.
12304         * inf-ptrace.c: Fix common/ includes.
12305         * inf-child.c: Fix common/ includes.
12306         * ia64-linux-nat.c: Fix common/ includes.
12307         * i387-tdep.c: Fix common/ includes.
12308         * i386-tdep.c: Fix common/ includes.
12309         * i386-linux-tdep.c: Fix common/ includes.
12310         * i386-linux-nat.c: Fix common/ includes.
12311         * i386-go32-tdep.c: Fix common/ includes.
12312         * i386-fbsd-tdep.c: Fix common/ includes.
12313         * i386-fbsd-nat.c: Fix common/ includes.
12314         * guile/scm-type.c: Fix common/ includes.
12315         * guile/guile.c: Fix common/ includes.
12316         * go32-nat.c: Fix common/ includes.
12317         * gnu-nat.c: Fix common/ includes.
12318         * gdbthread.h: Fix common/ includes.
12319         * gdbarch-selftests.c: Fix common/ includes.
12320         * gdb_usleep.c: Fix common/ includes.
12321         * gdb_select.h: Fix common/ includes.
12322         * gdb_bfd.c: Fix common/ includes.
12323         * gcore.c: Fix common/ includes.
12324         * fork-child.c: Fix common/ includes.
12325         * findvar.c: Fix common/ includes.
12326         * fbsd-nat.c: Fix common/ includes.
12327         * event-top.c: Fix common/ includes.
12328         * event-loop.c: Fix common/ includes.
12329         * dwarf2read.c: Fix common/ includes.
12330         * dwarf2loc.c: Fix common/ includes.
12331         * dwarf2-frame.c: Fix common/ includes.
12332         * dwarf-index-cache.c: Fix common/ includes.
12333         * dtrace-probe.c: Fix common/ includes.
12334         * disasm-selftests.c: Fix common/ includes.
12335         * defs.h: Fix common/ includes.
12336         * csky-tdep.c: Fix common/ includes.
12337         * cp-valprint.c: Fix common/ includes.
12338         * cp-support.h: Fix common/ includes.
12339         * cp-support.c: Fix common/ includes.
12340         * corelow.c: Fix common/ includes.
12341         * completer.h: Fix common/ includes.
12342         * completer.c: Fix common/ includes.
12343         * compile/compile.c: Fix common/ includes.
12344         * compile/compile-loc2c.c: Fix common/ includes.
12345         * compile/compile-cplus-types.c: Fix common/ includes.
12346         * compile/compile-cplus-symbols.c: Fix common/ includes.
12347         * command.h: Fix common/ includes.
12348         * cli/cli-dump.c: Fix common/ includes.
12349         * cli/cli-cmds.c: Fix common/ includes.
12350         * charset.c: Fix common/ includes.
12351         * build-id.c: Fix common/ includes.
12352         * btrace.h: Fix common/ includes.
12353         * btrace.c: Fix common/ includes.
12354         * breakpoint.h: Fix common/ includes.
12355         * breakpoint.c: Fix common/ includes.
12356         * ax.h:
12357         (enum agent_op): Fix common/ includes.
12358         * ax-general.c (struct aop_map): Fix common/ includes.
12359         * ax-gdb.c: Fix common/ includes.
12360         * auxv.c: Fix common/ includes.
12361         * auto-load.c: Fix common/ includes.
12362         * arm-tdep.c: Fix common/ includes.
12363         * arch/riscv.c: Fix common/ includes.
12364         * arch/ppc-linux-common.c: Fix common/ includes.
12365         * arch/i386.c: Fix common/ includes.
12366         * arch/arm.c: Fix common/ includes.
12367         * arch/arm-linux.c: Fix common/ includes.
12368         * arch/arm-get-next-pcs.c: Fix common/ includes.
12369         * arch/amd64.c: Fix common/ includes.
12370         * arch/aarch64.c: Fix common/ includes.
12371         * arch/aarch64-insn.c: Fix common/ includes.
12372         * arch-utils.c: Fix common/ includes.
12373         * amd64-windows-tdep.c: Fix common/ includes.
12374         * amd64-tdep.c: Fix common/ includes.
12375         * amd64-sol2-tdep.c: Fix common/ includes.
12376         * amd64-obsd-tdep.c: Fix common/ includes.
12377         * amd64-nbsd-tdep.c: Fix common/ includes.
12378         * amd64-linux-tdep.c: Fix common/ includes.
12379         * amd64-linux-nat.c: Fix common/ includes.
12380         * amd64-fbsd-tdep.c: Fix common/ includes.
12381         * amd64-fbsd-nat.c: Fix common/ includes.
12382         * amd64-dicos-tdep.c: Fix common/ includes.
12383         * amd64-darwin-tdep.c: Fix common/ includes.
12384         * agent.c: Fix common/ includes.
12385         * ada-lang.h: Fix common/ includes.
12386         * ada-lang.c: Fix common/ includes.
12387         * aarch64-tdep.c: Fix common/ includes.
12388
12389 2019-01-25  Tom Tromey  <tom@tromey.com>
12390
12391         * common/create-version.sh: Use common/version.h.
12392
12393 2019-01-24  Pedro Alves  <palves@redhat.com>
12394
12395         * infrun.c (signal_stop, signal_print, signal_program)
12396         (signal_catch, signal_pass): Now arrays instead of pointers.
12397         (update_signals_program_target, do_target_resume)
12398         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12399         * linux-nat.c (linux_nat_target::pass_signals)
12400         (linux_nat_target::create_inferior, linux_nat_target::attach):
12401         Adjust.
12402         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12403         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12404         * procfs.c (procfs_target::pass_signals): Adjust.
12405         * record-full.c (record_full_target::resume): Adjust.
12406         * remote.c (remote_target::pass_signals)
12407         (remote_target::program_signals): Adjust.
12408         * target-debug.h (target_debug_print_signals): Now takes a
12409         gdb::array_view as parameter.  Adjust.
12410         * target.h (target_ops) <pass_signals, program_signals>: Replace
12411         pointer and length parameters with gdb::array_view.
12412         (target_pass_signals, target_program_signals): Likewise.
12413         * target-delegates.c: Regenerate.
12414
12415 2019-01-24  Pedro Alves  <palves@redhat.com>
12416
12417         * common/forward-scope-exit.h
12418         (forward_scope_exit::forward_scope_exit): Pass arguments to
12419         m_bind_function directly, instead of creating a std::bind and
12420         copying that.
12421
12422 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12423
12424         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12425         for static members.
12426         (pass_in_v_vfp_candidate): Likewise.
12427
12428 2019-01-23  Tom Tromey  <tom@tromey.com>
12429             Pedro Alves  <palves@redhat.com>
12430
12431         * regcache.c (class regcache_invalidator): Remove.
12432         (regcache::raw_write): Use make_scope_exit.
12433
12434 2019-01-23  Tom Tromey  <tom@tromey.com>
12435
12436         * ui-out.h (class ui_out_emit_type): Update comment.
12437
12438 2019-01-23  Tom Tromey  <tom@tromey.com>
12439
12440         * infrun.c (fetch_inferior_event): Update comment.
12441
12442 2019-01-23  Tom Tromey  <tom@tromey.com>
12443             Pedro Alves  <palves@redhat.com>
12444
12445         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12446         parameter.
12447         (fetch_inferior_event): Use SCOPE_EXIT.
12448
12449
12450 2019-01-23  Tom Tromey  <tom@tromey.com>
12451             Pedro Alves  <palves@redhat.com>
12452
12453         * infrun.c (disable_thread_events): Delete.
12454         (stop_all_threads): Use SCOPE_EXIT.
12455
12456 2019-01-23  Tom Tromey  <tom@tromey.com>
12457             Pedro Alves  <palves@redhat.com>
12458
12459         * symfile.c: Include forward-scope-exit.h.
12460         (clear_symtab_users_cleanup): Replace forward declaration with
12461         a FORWARD_SCOPE_EXIT.
12462         (syms_from_objfile_1): Use the forward_scope_exit and
12463         gdb::optional instead of cleanup_function.
12464         (reread_symbols): Use the forward_scope_exit instead of
12465         cleanup_function.
12466         (clear_symtab_users_cleanup): Remove function.
12467
12468 2019-01-23  Tom Tromey  <tom@tromey.com>
12469             Pedro Alves  <palves@redhat.com>
12470
12471         * linux-nat.c: Include scope-exit.h.
12472         (cleanup_target_stop): Remove.
12473         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12474         SCOPE_EXIT.
12475
12476 2019-01-23  Tom Tromey  <tom@tromey.com>
12477             Pedro Alves  <palves@redhat.com>
12478
12479         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12480         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12481
12482 2019-01-23  Tom Tromey  <tom@tromey.com>
12483             Andrew Burgess  <andrew.burgess@embecosm.com>
12484             Pedro Alves  <palves@redhat.com>
12485
12486         * infrun.c (fetch_inferior_event): Use scope_exit.
12487         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12488         * top.c (execute_command): Use scope_exit.
12489         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12490         * utils.c (do_bpstat_clear_actions_cleanup)
12491         (make_bpstat_clear_actions_cleanup): Remove.
12492
12493 2019-01-23  Tom Tromey  <tom@tromey.com>
12494             Pedro Alves  <palves@redhat.com>
12495
12496         * infrun.c: Include "common/scope-exit.h"
12497         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12498         (wait_for_inferior): Use SCOPE_EXIT.
12499         (fetch_inferior_event): Use scope_exit.
12500
12501 2019-01-23  Tom Tromey  <tom@tromey.com>
12502             Pedro Alves  <palves@redhat.com>
12503
12504         * breakpoint.c (create_breakpoint): Remove cleanup.
12505
12506 2019-01-23  Tom Tromey  <tom@tromey.com>
12507             Andrew Burgess  <andrew.burgess@embecosm.com>
12508             Pedro Alves  <palves@redhat.com>
12509
12510 2019-01-23  Pedro Alves  <palves@redhat.com>
12511
12512         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12513
12514 2019-01-23  Pedro Alves  <palves@redhat.com>
12515             Andrew Burgess  <andrew.burgess@embecosm.com>
12516
12517         * gdbthread.h: Include "common/forward-scope-exit.h".
12518         (scoped_finish_thread_state): Redefine custom class in terms of
12519         forward_scope_exit.
12520
12521 2019-01-23  Pedro Alves  <palves@redhat.com>
12522             Andrew Burgess  <andrew.burgess@embecosm.com>
12523
12524         * common/forward-scope-exit.h: New file.
12525
12526 2019-01-23  Pedro Alves  <palves@redhat.com>
12527             Andrew Burgess  <andrew.burgess@embecosm.com>
12528             Tom Tromey  <tom@tromey.com>
12529
12530         * common/scope-exit.h: New file.
12531
12532 2019-01-23  Pedro Alves  <palves@redhat.com>
12533
12534         * common/preprocessor.h (ESC): Rename to ...
12535         (ESC_PARENS): ... this.
12536         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12537         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12538
12539 2019-01-23  Tom Tromey  <tom@tromey.com>
12540
12541         * language.h (class scoped_switch_to_sym_language_if_auto):
12542         Initialize m_lang in both cases.
12543
12544 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12545
12546         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12547         with XCNEW.
12548
12549 2019-01-22  Tom Tromey  <tom@tromey.com>
12550
12551         * corelow.c: Do not include sys/file.h.
12552
12553 2019-01-22  Tom Tromey  <tom@tromey.com>
12554
12555         * tui/tui-wingeneral.h: Include gdb_curses.h.
12556
12557 2019-01-22  Tom Tromey  <tom@tromey.com>
12558
12559         * source-cache.h (class source_cache) <get_source_lines,
12560         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12561
12562 2019-01-22  Tom Tromey  <tom@tromey.com>
12563
12564         * remote-fileio.h (struct remote_target): Declare.
12565
12566 2019-01-22  Tom Tromey  <tom@tromey.com>
12567
12568         * python/py-arch.c: Do not include py-ref.h.
12569         * python/py-bpevent.c: Do not include py-ref.h.
12570         * python/py-cmd.c: Do not include py-ref.h.
12571         * python/py-continueevent.c: Do not include py-ref.h.
12572         * python/py-event.h: Do not include py-ref.h.
12573         * python/py-evtregistry.c: Do not include py-ref.h.
12574         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12575         * python/py-frame.c: Do not include py-ref.h.
12576         * python/py-framefilter.c: Do not include py-ref.h.
12577         * python/py-function.c: Do not include py-ref.h.
12578         * python/py-infevents.c: Do not include py-ref.h.
12579         * python/py-linetable.c: Do not include py-ref.h.
12580         * python/py-objfile.c: Do not include py-ref.h.
12581         * python/py-param.c: Do not include py-ref.h.
12582         * python/py-prettyprint.c: Do not include py-ref.h.
12583         * python/py-progspace.c: Do not include py-ref.h.
12584         * python/py-symbol.c: Do not include py-ref.h.
12585         * python/py-symtab.c: Do not include py-ref.h.
12586         * python/py-type.c: Do not include py-ref.h.
12587         * python/py-unwind.c: Do not include py-ref.h.
12588         * python/py-utils.c: Do not include py-ref.h.
12589         * python/py-value.c: Do not include py-ref.h.
12590         * python/py-varobj.c: Do not include py-ref.h.
12591         * python/py-xmethods.c: Do not include py-ref.h.
12592         * python/python.c: Do not include py-ref.h.
12593         * varobj.c: Do not include py-ref.h.
12594
12595 2019-01-22  Tom Tromey  <tom@tromey.com>
12596
12597         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12598         keyword for bcache.
12599
12600 2019-01-22  Tom Tromey  <tom@tromey.com>
12601
12602         * compile/compile-cplus-types.c: Remove a comment by #include.
12603
12604 2019-01-22  Tom Tromey  <tom@tromey.com>
12605
12606         * compile/gcc-c-plugin.h: Include compile-internal.h.
12607
12608 2019-01-22  Tom Tromey  <tom@tromey.com>
12609
12610         * stabsread.c (EXTERN): Do not define.
12611         (symnum, next_symbol_text_func, processing_gcc_compilation)
12612         (within_function, global_sym_chain, global_stabs)
12613         (previous_stab_code, this_object_header_files)
12614         (n_this_object_header_files)
12615         (n_allocated_this_object_header_files): Define.
12616         * stabsread.h (EXTERN): Never define.  Use "extern".
12617
12618 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12619
12620         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12621         history_value.
12622
12623 2019-01-21  Tom Tromey  <tom@tromey.com>
12624
12625         * ui-out.c: Fix includes.
12626         * tui/tui-source.c: Fix includes.
12627         * target.c: Fix includes.
12628         * remote.c: Fix includes.
12629         * regcache.c: Fix includes.
12630         * python/py-block.c: Fix includes.
12631         * printcmd.c: Fix includes.
12632         * or1k-tdep.c: Fix includes.
12633         * mi/mi-main.c: Fix includes.
12634         * m32r-tdep.c: Fix includes.
12635         * csky-tdep.c: Fix includes.
12636         * compile/compile-cplus-types.c: Fix includes.
12637         * cli/cli-interp.c: Fix includes.
12638
12639 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12640
12641         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12642         for padding.
12643
12644 2019-01-16  Tom Tromey  <tom@tromey.com>
12645
12646         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12647         earlier.
12648         (struct objfile) <msymbols_range>: Move from top level.
12649         <msymbols>: New method.
12650         (class objfile_msymbols): Remove.
12651         * symtab.c (default_collect_symbol_completion_matches_break_on):
12652         Update.
12653         * symmisc.c (dump_msymbols): Update.
12654         * stabsread.c (scan_file_globals): Update.
12655         * objc-lang.c (info_selectors_command, info_classes_command)
12656         (find_methods): Update.
12657         * minsyms.c (find_solib_trampoline_target): Update.
12658         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12659         * coffread.c (coff_symfile_read): Update.
12660         * ada-lang.c (ada_lookup_simple_minsym)
12661         (ada_collect_symbol_completion_matches): Update.
12662
12663 2019-01-16  Tom Tromey  <tom@tromey.com>
12664
12665         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12666         type.  Remove no-argument constructor.
12667         <iterator::operator++>: Simplify.
12668         <begin>: Update.
12669         <end>: Use minimal_symbol_count.
12670
12671 2019-01-16  Tom Tromey  <tom@tromey.com>
12672
12673         * objfiles.h (struct objfile) <psymtabs>: New method.
12674         (class objfile_psymtabs): Remove.
12675         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12676         typedef.
12677         <range>: New method.
12678         (require_partial_symbols): Change return type.
12679         * psymtab.c (require_partial_symbols)
12680         (psym_expand_symtabs_matching): Update.
12681         * mdebugread.c (parse_partial_symbols): Update.
12682         * dbxread.c (dbx_end_psymtab): Update.
12683
12684 2019-01-15  Tom Tromey  <tom@tromey.com>
12685
12686         * symtab.c (lookup_objfile_from_block)
12687         (lookup_symbol_in_objfile_symtabs)
12688         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12689         (find_line_symtab, info_sources_command)
12690         (default_collect_symbol_completion_matches_break_on)
12691         (make_source_files_completion_list): Update.
12692         * symmisc.c (print_objfile_statistics, dump_objfile)
12693         (maintenance_print_symbols, maintenance_info_symtabs)
12694         (maintenance_check_symtabs, maintenance_info_line_tables):
12695         Update.
12696         * source.c (select_source_symtab)
12697         (forget_cached_source_info_for_objfile): Update.
12698         * objfiles.h (class objfile_compunits): Remove.
12699         (struct objfile) <compunits_range>: New typedef.
12700         (compunits): New method.
12701         * objfiles.c (objfile_relocate1): Update.
12702         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12703         * maint.c (count_symtabs_and_blocks): Update.
12704         * linespec.c (iterate_over_all_matching_symtabs): Update.
12705         * cp-support.c (add_symbol_overload_list_qualified): Update.
12706         * coffread.c (coff_symtab_read): Update.
12707         * ada-lang.c (add_nonlocal_symbols)
12708         (ada_collect_symbol_completion_matches)
12709         (ada_add_global_exceptions): Update.
12710
12711 2019-01-15  Tom Tromey  <tom@tromey.com>
12712
12713         * progspace.h (program_space) <objfiles_safe_range>: New
12714         typedef.
12715         <objfiles_safe>: New method.
12716         * objfiles.h (class all_objfiles_safe): Remove.
12717         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12718         * jit.c (jit_inferior_exit_hook): Update.
12719
12720 2019-01-17  Tom Tromey  <tom@tromey.com>
12721
12722         * progspace.h (program_space) <objfiles_range>: New typedef.
12723         <objfiles>: New method.
12724         <objfiles_head>: Rename from objfiles.
12725         (object_files): Update.
12726         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12727         * guile/scm-pretty-print.c
12728         (ppscm_find_pretty_printer_from_objfiles): Update.
12729         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12730         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12731         Update.
12732         * python/py-progspace.c (pspy_get_objfiles): Update.
12733         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12734         Update.
12735         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12736         (objfpy_lookup_objfile_by_build_id): Update.
12737         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12738         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12739         Update.
12740         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12741         (expand_symtab_containing_pc, lookup_objfile_from_block)
12742         (lookup_static_symbol, basic_lookup_transparent_type)
12743         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12744         (find_line_symtab, info_sources_command)
12745         (default_collect_symbol_completion_matches_break_on)
12746         (make_source_files_completion_list, find_main_name): Update.
12747         * symmisc.c (print_symbol_bcache_statistics)
12748         (print_objfile_statistics, maintenance_print_symbols)
12749         (maintenance_print_msymbols, maintenance_print_objfiles)
12750         (maintenance_info_symtabs, maintenance_check_symtabs)
12751         (maintenance_expand_symtabs, maintenance_info_line_tables):
12752         Update.
12753         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12754         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12755         (map_overlay_command, unmap_overlay_command)
12756         (simple_overlay_update, expand_symtabs_matching)
12757         (map_symbol_filenames): Update.
12758         * symfile-debug.c (set_debug_symfile): Update.
12759         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12760         Update.
12761         * source.c (select_source_symtab, forget_cached_source_info):
12762         Update.
12763         * solib.c (solib_read_symbols): Update.
12764         * solib-spu.c (append_ocl_sos): Update.
12765         * psymtab.c (maintenance_print_psymbols)
12766         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12767         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12768         * printcmd.c (info_symbol_command): Update.
12769         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12770         Update.
12771         * objfiles.h (class all_objfiles): Remove.
12772         * objfiles.c (have_partial_symbols, have_full_symbols)
12773         (have_minimal_symbols, qsort_cmp, update_section_map)
12774         (shared_objfile_contains_address_p)
12775         (default_iterate_over_objfiles_in_search_order): Update.
12776         * objc-lang.c (info_selectors_command, info_classes_command)
12777         (find_methods): Update.
12778         * minsyms.c (find_solib_trampoline_target): Update.
12779         * maint.c (maintenance_info_sections)
12780         (maintenance_translate_address, count_symtabs_and_blocks):
12781         Update.
12782         * main.c (captured_main_1): Update.
12783         * linux-thread-db.c (try_thread_db_load_from_pdir)
12784         (has_libpthread): Update.
12785         * linespec.c (iterate_over_all_matching_symtabs)
12786         (search_minsyms_for_name): Update.
12787         * jit.c (jit_find_objf_with_entry_addr): Update.
12788         * hppa-tdep.c (find_unwind_entry)
12789         (hppa_lookup_stub_minimal_symbol): Update.
12790         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12791         Update.
12792         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12793         (elf_gnu_ifunc_resolve_by_got): Update.
12794         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12795         * dwarf-index-write.c (save_gdb_index_command): Update.
12796         * cp-support.c (add_symbol_overload_list_qualified): Update.
12797         * breakpoint.c (create_overlay_event_breakpoint)
12798         (create_longjmp_master_breakpoint)
12799         (create_std_terminate_master_breakpoint)
12800         (create_exception_master_breakpoint): Update.
12801         * blockframe.c (find_pc_partial_function): Update.
12802         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12803         (ada_collect_symbol_completion_matches)
12804         (ada_add_global_exceptions): Update.
12805
12806 2019-01-17  Tom Tromey  <tom@tromey.com>
12807
12808         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12809         declare VEC.
12810         (solib_target_parse_libraries): Change return type.
12811         (library_list_start_segment, library_list_start_section)
12812         (library_list_end_library, library_list_start_library); Update.
12813         (solib_target_free_library_list): Remove.
12814         (solib_target_parse_libraries): Remove cleanup.  Change return
12815         type.
12816         (solib_target_current_sos): Update.
12817
12818 2019-01-17  Tom Tromey  <tromey@bapiya>
12819
12820         * valprint.c: Replace "the the" with "the".
12821         * symtab.c: Replace "the the" with "the".
12822         * solib.c: Replace "the the" with "the".
12823         * solib-dsbt.c: Replace "the the" with "the".
12824         * linespec.c: Replace "the the" with "the".
12825         * dwarf2loc.h: Replace "the the" with "the".
12826         * amd64-windows-tdep.c: Replace "the the" with "the".
12827         * aarch64-tdep.c: Replace "the the" with "the".
12828
12829 2019-01-16  Keith Seitz  <keiths@redhat.com>
12830
12831         PR gdb/23773
12832         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12833         <builder>: Rename to ..
12834         <m_builder>: ... this and make private.
12835         (dwarf2_cu::get_builder): New method.  Change all users of
12836         `builder' to use this method.
12837         (dwarf2_start_symtab): Move to ...
12838         (dwarf2_cu::start_symtab): ... here.  Update all callers
12839         (setup_type_unit_groups): Move to ...
12840         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12841         callers.
12842         (dwarf2_cu::reset_builder): New method.
12843         (process_full_compunit, process_full_type_unit): Use
12844         dwarf2_cu::reset_builder.
12845         (follow_die_offset): Record the ancestor CU if it is different
12846         from the followed DIE's CU.
12847         (follow_die_sig_1): Likewise.
12848
12849 2019-01-15  Tom Tromey  <tom@tromey.com>
12850
12851         * remote.c (class remote_state) <buf>: Now a char_vector.
12852         <buf_size>: Remove.
12853         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12854         parameter.
12855         (remote_target::getpkt_or_notif_sane_1)
12856         (remote_target::getpkt_sane)
12857         (remote_target::getpkt_or_notif_sane): Likewise.
12858         (class remote_target) <putpkt>: New overload.
12859         (remote_target::read_frame): Change type of "buf_p".  Remove
12860         sizeof_p parameter.
12861         (packet_ok): New overload.
12862         (packet_check_result): New overload.
12863         Update all uses.
12864
12865 2019-01-14  Tom Tromey  <tom@tromey.com>
12866
12867         * remote-notif.c (handle_notification, remote_notif_ack)
12868         (remote_notif_parse): Make "buf" const.
12869         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12870         const.
12871         (remote_notif_parse, remote_notif_ack, handle_notification):
12872         Likewise.
12873         * remote.c (remote_notif_stop_parse): Make "buf" const.
12874         (remote_target::remote_parse_stop_reply): Make "buf" const.
12875         (remote_notif_stop_ack): Make "buf" const.
12876
12877 2019-01-14  Tom Tromey  <tom@tromey.com>
12878
12879         * remote.c (remote_console_output): Make parameter const.
12880
12881 2019-01-14  Tom Tromey  <tom@tromey.com>
12882
12883         * target-debug.h (target_debug_print_signals): Constify.
12884         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12885         * procfs.c (procfs_target::pass_signals): Update.
12886         * linux-nat.c (linux_nat_target::pass_signals): Update.
12887         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12888         * target-delegates.c: Rebuild.
12889         * remote.c (remote_target::program_signals): Update.
12890         (remote_target::pass_signals): Update.
12891         * target.c (target_pass_signals): Constify argument.
12892         (target_program_signals): Likewise.
12893         * target.h (struct target_ops) <pass_signals, program_signals>:
12894         Constify argument.
12895         (target_pass_signals, target_program_signals): Constify argument.
12896
12897 2019-01-14  Tom Tromey  <tom@tromey.com>
12898
12899         PR tui/28819:
12900         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12901
12902 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12903
12904         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12905         field.
12906         * rs6000-tdep.c: Include reggroups.h.
12907         (IS_V_ALIAS_PSEUDOREG): Define.
12908         (rs6000_register_name): Return names for the "vX" aliases.
12909         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12910         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12911         aliases.  Call default_register_reggroup_p for all other
12912         pseudo-registers.
12913         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12914         New functions.
12915         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12916         Handle "vX" aliases.
12917         (v_alias_pseudo_register_collect): New function.
12918         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12919         (rs6000_gdbarch_init): Initialize "vX" aliases as
12920         pseudo-registers.  Restore registration of
12921         rs6000_pseudo_register_reggroup_p with
12922         set_tdesc_pseudo_register_reggroup_p.
12923
12924 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12925
12926         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12927         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12928         set_gdbarch_num_pseudo_regs.
12929
12930 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12931
12932         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12933         Remove arg prefixname, add do_set and do_show.
12934         Add member functions set_list and show_list.
12935         * cli/cli-style.c (class cli_style_option): Update accordingly.
12936         (style_set_list): Move to file scope.
12937         (style_show_list): Likewise.
12938         (set_style): Call help_list.
12939         (show_style): Call cmd_show_list.
12940         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12941         Update to use the new macro.
12942
12943 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12944
12945         * ada-lang.c (_initialize_ada_language): Expand the help text
12946         for the "catch exception" command.
12947
12948 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12949
12950         * symtab.c (matching_obj_sections): Initialize obj,
12951         declare it closer to its usage.
12952
12953 2019-01-10  Tom Tromey  <tom@tromey.com>
12954
12955         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12956         (basic_inf_threads_range): Remove.
12957         (inf_threads_range, inf_non_exited_threads_range)
12958         (safe_inf_threads_range): Use next_adapter.
12959
12960 2019-01-10  Keith Seitz  <keiths@redhat.com>
12961
12962         PR gdb/23712
12963         PR symtab/23010
12964         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12965         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12966
12967 2019-01-10  Keith Seitz  <keiths@redhat.com>
12968
12969         PR gdb/23712
12970         PR symtab/23010
12971         * dictionary.c (pending_to_vector): Remove.
12972         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12973         Remove _1 suffix, replacing functions of the same name.  Update
12974         all callers.
12975         (dict_create_hashed, dict_create_hashed_expandable)
12976         (dict_create_linear, dict_create_linear_expandable, dict_free)
12977         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12978         Make functions static.
12979
12980 2019-01-10  Keith Seitz  <keiths@redhat.com>
12981
12982         PR gdb/23712
12983         PR symtab/23010
12984         * dictionary.h (struct dictionary): Replace declaration with
12985         multidictionary.
12986         (dict_create_hashed, dict_create_hashed_expandable)
12987         (dict_create_linear, dict_create_linear_expandable)
12988         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12989         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12990         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12991         taking multidictionary argument.
12992         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12993         * block.h (struct block) <dict>: Change to multidictionary
12994         and rename `multidict'.
12995         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12996         symmisc.c: Update all dictionary references to multidictionary.
12997
12998 2019-01-10  Keith Seitz  <keiths@redhat.com>
12999
13000         PR gdb/23712
13001         PR symtab/23010
13002         * dictionary.c: Include unordered_map.
13003         (pending_to_vector): New function.
13004         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13005         Rewrite the non-"_1" functions to take vector instead
13006         of linked list.
13007         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13008         "new" _1 versions of the same name.
13009         (multidictionary): Define.
13010         (std::hash<enum language): New definition.
13011         (collate_pending_symbols_by_language, mdict_create_hashed)
13012         (mdict_create_hashed_expandable, mdict_create_linear)
13013         (mdict_create_linear_expandable, mdict_free)
13014         (find_language_dictionary, create_new_language_dictionary)
13015         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13016         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13017         (mdict_size, mdict_empty): New functions.
13018         * dictionary.h (mdict_iterator): Define.
13019
13020 2019-01-10  Pedro Alves  <palves@redhat.com>
13021
13022         * breakpoint.c (read_uploaded_action)
13023         (create_tracepoint_from_upload): Adjust to use
13024         gdb::unique_xmalloc_ptr.
13025         * ctf.c (ctf_write_uploaded_tp):
13026         (SET_ARRAY_FIELD): Use emplace_back.
13027         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13028         * tracefile-tfile.c (tfile_write_uploaded_tp):
13029         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13030         gdb::unique_xmalloc_ptr.
13031         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13032         at_string, cond_string, cmd_strings>: Replace char pointers
13033         with gdb::unique_xmalloc_ptr.
13034
13035 2019-01-10  Pedro Alves  <palves@redhat.com>
13036
13037         * solib-target.c (library_list_start_library): Don't xstrdup name.
13038
13039 2019-01-10  Pedro Alves  <palves@redhat.com>
13040
13041         * mdebugread.c (parse_partial_symbols): Use
13042         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13043
13044 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13045
13046         * linux-fork.c (scoped_switch_fork_info)
13047         <~scoped_switch_fork_info>: Fix incorrect variable name.
13048
13049 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13050
13051         * linux-fork.c (scoped_switch_fork_info)
13052         <scoped_switch_fork_info>: Make explicit.
13053         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13054
13055 2019-01-10  Tom Tromey  <tom@tromey.com>
13056
13057         * objfiles.h (objfile::reset_psymtabs): Update.
13058         * objfiles.c (objfile::objfile): Update.
13059         * psymtab.h (psymtab_storage::obstack): Update.
13060         (psymtab_storage::m_obstack): Use gdb::optional.
13061         (class psymtab_storage): Update comment.  Remove objfile
13062         parameter.
13063         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13064
13065 2019-01-10  Tom Tromey  <tom@tromey.com>
13066
13067         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13068         <free_psymtabs>: Now private.
13069         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13070         (allocate_psymtab): Use new method.
13071
13072 2019-01-10  Tom Tromey  <tom@tromey.com>
13073
13074         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13075         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13076         * mdebugread.c (parse_partial_symbols): Use
13077         allocate_dependencies.
13078         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13079         allocate_dependencies.
13080         (process_psymtab_comp_unit_reader)
13081         (build_type_psymtab_dependencies): Likewise.
13082         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13083
13084 2019-01-10  Tom Tromey  <tom@tromey.com>
13085
13086         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13087         PSYMBOL_SET_LANGUAGE.
13088         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13089
13090 2019-01-10  Tom Tromey  <tom@tromey.com>
13091
13092         * psymtab.h (psymtab_storage::obstack): New method.
13093         <m_obstack>: Rename from obstack; now private.
13094         * psymtab.c (psymtab_storage): Update.
13095         * dwarf2read.c (create_addrmap_from_index)
13096         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13097         Update.
13098
13099 2019-01-10  Tom Tromey  <tom@tromey.com>
13100
13101         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13102         * objfiles.h (objfile::reset_psymtabs): New method.
13103
13104 2019-01-10  Tom Tromey  <tom@tromey.com>
13105
13106         * symmisc.c (print_symbol_bcache_statistics): Update.
13107         (print_objfile_statistics): Update.
13108         * symfile.c (reread_symbols): Update.
13109         * psymtab.h (class psymtab_storage): New.
13110         * psymtab.c (psymtab_storage): New constructor.
13111         (~psymtab_storage): New destructor.
13112         (require_partial_symbols): Update.
13113         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13114         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13115         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13116         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13117         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13118         (start_psymtab_common, end_psymtab_common)
13119         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13120         (allocate_psymtab): Update.
13121         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13122         Update.
13123         (dump_psymtab_addrmap, maintenance_print_psymbols)
13124         (maintenance_check_psymtabs): Update.
13125         (class objfile_psymtabs): Move to objfiles.h.
13126         * psympriv.h (discard_psymtab): Now inline.
13127         (psymtab_discarder::psymtab_discarder): Update.
13128         (psymtab_discarder::~psymtab_discarder): Update.
13129         (ALL_OBJFILE_PSYMTABS): Rewrite.
13130         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13131         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13132         Remove fields.
13133         <partial_symtabs>: New field.
13134         (class objfile_psymtabs): Move from psymtab.h.  Update.
13135         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13136         psymbol_cache.
13137         (objfile::~objfile): Don't destroy psymbol_cache.
13138         * mdebugread.c (parse_partial_symbols): Update.
13139         * dwarf2read.c (create_addrmap_from_index)
13140         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13141         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13142         (add_partial_subprogram, dwarf2_ranges_read): Update.
13143         * dwarf-index-write.c (write_address_map)
13144         (write_one_signatured_type, recursively_write_psymbols)
13145         (class debug_names, class debug_names, write_psymtabs_to_index):
13146         Update.
13147
13148 2019-01-10  Tom Tromey  <tom@tromey.com>
13149
13150         * symtab.h (SYMBOL_SET_NAMES): Update.
13151         (symbol_set_names): Update.
13152         (MSYMBOL_SET_NAMES): Update.
13153         * symtab.c (symbol_set_names): Change argument to be an
13154         objfile_per_bfd_storage.
13155         * psymtab.c (add_psymbol_to_bcache): Update.
13156         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13157
13158 2019-01-10  Tom Tromey  <tom@tromey.com>
13159
13160         * symtab.c (create_demangled_names_hash): Change argument to be an
13161         objfile_per_bfd_storage.
13162         (symbol_set_names): Update.
13163
13164 2019-01-10  Tom Tromey  <tom@tromey.com>
13165
13166         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13167         init_psymbol_list.
13168         * psymtab.c (init_psymbol_list): Do nothing if already called.
13169         * psympriv.h (init_psymbol_list): Add comment.
13170         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13171         init_psymbol_list.
13172         * dbxread.c (dbx_symfile_read): Unconditionally call
13173         init_psymbol_list.
13174
13175 2019-01-10  Tom Tromey  <tom@tromey.com>
13176
13177         * xcoffread.c (scan_xcoff_symtab): Update.
13178         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13179         "where".
13180         * mdebugread.c (parse_partial_symbols)
13181         (handle_psymbol_enumerators): Update.
13182         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13183         * dbxread.c (read_dbx_symtab): Update.
13184         * psympriv.h (psymbol_placement): New enum.
13185         (add_psymbol_to_list): Update.
13186
13187 2019-01-10  Tom Tromey  <tom@tromey.com>
13188
13189         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13190         static_psymbols parameters.
13191         (scan_xcoff_symtab): Update.
13192         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13193         static_psymbols parameters.
13194         * psympriv.h (start_psymtab_common): Update.
13195         * mdebugread.c (parse_partial_symbols): Update.
13196         * dwarf2read.c (create_partial_symtab): Update.
13197         * dbxread.c (read_dbx_symtab): Update.
13198         (start_psymtab): Remove global_psymbols and static_psymbols
13199         parameters.
13200
13201 2019-01-10  Tom Tromey  <tom@tromey.com>
13202
13203         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13204         * psymtab.c (allocate_psymtab): Add comment.
13205         * psympriv.h (allocate_psymtab): Add comment.
13206         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13207         initializations.
13208         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13209
13210 2019-01-10  Tom Tromey  <tom@tromey.com>
13211
13212         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13213         Don't declare.
13214         * mipsread.c: Include mdebugread.h.
13215         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13216         Declare.
13217         * elfread.c: Include mdebugread.h.
13218
13219 2019-01-09  Tom Tromey  <tom@tromey.com>
13220
13221         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13222         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13223         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13224         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13225         (psym_lookup_symbol, psym_find_last_source_symtab)
13226         (psym_forget_cached_source_info, psym_print_stats)
13227         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13228         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13229         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13230         (psym_find_compunit_symtab_by_address)
13231         (maintenance_print_psymbols, maintenance_info_psymtabs)
13232         (maintenance_check_psymtabs): Use ranged for.
13233         * psymtab.h (class objfile_psymtabs): New.
13234         (require_partial_symbols): Return objfile_psymtabs.
13235         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13236
13237 2019-01-09  Tom Tromey  <tom@tromey.com>
13238
13239         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13240         (find_pc_mapped_section, list_overlays_command)
13241         (map_overlay_command, unmap_overlay_command)
13242         (simple_overlay_update): Use all_objfiles.
13243         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13244         * printcmd.c (info_symbol_command): Use all_objfiles.
13245         * objfiles.h (ALL_OBJSECTIONS): Remove.
13246         * maint.c (maintenance_translate_address): Use all_objfiles.
13247         * gcore.c (gcore_create_callback): Use all_objfiles.
13248         (objfile_find_memory_regions): Likewise.
13249
13250 2019-01-09  Tom Tromey  <tom@tromey.com>
13251
13252         * symtab.c (find_line_symtab, info_sources_command)
13253         (make_source_files_completion_list): Use objfile_compunits.
13254         * source.c (select_source_symtab): Use objfile_compunits.
13255         * objfiles.h (struct objfile): Update comment.
13256         (ALL_OBJFILES): Remove.
13257         (ALL_FILETABS): Remove.
13258         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13259         objfile_compunits.
13260
13261 2019-01-09  Tom Tromey  <tom@tromey.com>
13262
13263         * symmisc.c (print_objfile_statistics, dump_objfile)
13264         (maintenance_print_symbols): Use compunit_filetabs.
13265         * source.c (forget_cached_source_info_for_objfile): Use
13266         compunit_filetabs.
13267         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13268         (ALL_FILETABS): Use compunit_filetabs.
13269         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13270         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13271
13272 2019-01-09  Tom Tromey  <tom@tromey.com>
13273
13274         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13275         (compunit_filetabs): New.
13276         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13277         compunit_filetabs.
13278         (info_sources_command, make_source_files_completion_list): Remove
13279         declaration.
13280         * symmisc.c (print_objfile_statistics, dump_objfile)
13281         (maintenance_print_symbols): Remove declaration.
13282         (maintenance_info_symtabs): Use compunit_filetabs.
13283         (maintenance_info_line_tables): Likewise.
13284         * source.c (select_source_symtab): Change local variable name.
13285         (forget_cached_source_info_for_objfile): Remove declaration.
13286         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13287         * objfiles.c (objfile_relocate1): Remove declaration.
13288         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13289         declaration.
13290         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13291         * coffread.c (coff_symtab_read): Remove declaration.
13292         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13293         compunit_filetabs.
13294
13295 2019-01-09  Tom Tromey  <tom@tromey.com>
13296
13297         * symtab.c (lookup_objfile_from_block)
13298         (find_pc_sect_compunit_symtab, search_symbols)
13299         (default_collect_symbol_completion_matches_break_on): Use
13300         objfile_compunits.
13301         * objfiles.h (ALL_COMPUNITS): Remove.
13302         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13303         * cp-support.c (add_symbol_overload_list_qualified): Use
13304         objfile_compunits.
13305         * ada-lang.c (ada_collect_symbol_completion_matches)
13306         (ada_add_global_exceptions): Use objfile_compunits.
13307
13308 2019-01-09  Tom Tromey  <tom@tromey.com>
13309
13310         * source.c (select_source_symtab)
13311         (forget_cached_source_info_for_objfile): Remove declaration.
13312         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13313         declaration.
13314         * maint.c (count_symtabs_and_blocks): Remove declaration.
13315         * cp-support.c (add_symbol_overload_list_qualified): Remove
13316         declaration.
13317         * coffread.c (coff_symtab_read): Remove declaration.
13318         * symtab.c (lookup_symbol_in_objfile_symtabs)
13319         (basic_lookup_transparent_type_1): Use objfile_compunits.
13320         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13321         (info_sources_command, search_symbols)
13322         (default_collect_symbol_completion_matches_break_on)
13323         (make_source_files_completion_list): Remove declaration.
13324         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13325         (ada_collect_symbol_completion_matches)
13326         (ada_add_global_exceptions): Remove declaration.
13327         * linespec.c (iterate_over_all_matching_symtabs): Use
13328         objfile_compunits.
13329         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13330         (class objfile_compunits): New.
13331         (ALL_COMPUNITS): Use objfile_compunits.
13332         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13333         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13334         objfile_compunits.
13335         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13336
13337 2019-01-09  Tom Tromey  <tom@tromey.com>
13338
13339         * symtab.c (search_symbols)
13340         (default_collect_symbol_completion_matches_break_on): Use
13341         objfile_msymbols.
13342         * ada-lang.c (ada_lookup_simple_minsym)
13343         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13344         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13345         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13346         objfile_msymbols.
13347         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13348         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13349         * objc-lang.c (find_methods): Use objfile_msymbols.
13350         (info_selectors_command, info_classes_command): Likewise.
13351         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13352         * objfiles.h (class objfile_msymbols): New.
13353         (ALL_OBJFILE_MSYMBOLS): Remove.
13354         (ALL_MSYMBOLS): Remove.
13355
13356 2019-01-09  Tom Tromey  <tom@tromey.com>
13357
13358         * common/next-iterator.h (next_adapter): Add Iterator template
13359         parameter.
13360         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13361         (class all_objfiles_safe): New.
13362         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13363         * objfiles.c (put_objfile_before): Update comment.
13364         (add_separate_debug_objfile): Likewise.
13365         (free_all_objfiles): Use all_objfiles_safe.
13366         (objfile_purge_solibs): Likewise.
13367
13368 2019-01-09  Tom Tromey  <tom@tromey.com>
13369
13370         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13371         (expand_symtab_containing_pc, lookup_static_symbol)
13372         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13373         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13374         all_objfiles.
13375         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13376         * breakpoint.c (create_overlay_event_breakpoint)
13377         (create_longjmp_master_breakpoint)
13378         (create_std_terminate_master_breakpoint)
13379         (create_exception_master_breakpoint): Use all_objfiles.
13380         * linux-thread-db.c (try_thread_db_load_from_pdir)
13381         (has_libpthread): Use all_objfiles.
13382         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13383         * linespec.c (iterate_over_all_matching_symtabs)
13384         (search_minsyms_for_name): Use all_objfiles.
13385         * maint.c (maintenance_info_sections): Use all_objfiles.
13386         * main.c (captured_main_1): Use all_objfiles.
13387         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13388         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13389         * guile/scm-pretty-print.c
13390         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13391         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13392         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13393         (maintenance_print_msymbols): Use all_objfiles.
13394         * source.c (select_source_symtab): Use all_objfiles.
13395         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13396         * symfile.c (remove_symbol_file_command)
13397         (expand_symtabs_matching, map_symbol_filenames): Use
13398         all_objfiles.
13399         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13400         all_objfiles.
13401         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13402         * objc-lang.c (find_methods): Use all_objfiles.
13403         * objfiles.c (have_partial_symbols, have_full_symbols)
13404         (have_minimal_symbols, qsort_cmp)
13405         (default_iterate_over_objfiles_in_search_order): Use
13406         all_objfiles.
13407         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13408         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13409         (maintenance_check_psymtabs): Use all_objfiles.
13410         (ALL_PSYMTABS): Remove.
13411         * compile/compile-object-run.c (do_module_cleanup): Use
13412         all_objfiles.
13413         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13414         * cp-support.c (add_symbol_overload_list_qualified): Use
13415         all_objfiles.
13416         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13417         Use all_objfiles.
13418         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13419         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13420         all_objfiles.
13421         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13422         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13423         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13424         Uses all_objfiles.
13425         * solib.c (solib_read_symbols): Use all_objfiles
13426
13427 2019-01-09  Tom Tromey  <tom@tromey.com>
13428
13429         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13430         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13431         all_objfiles.
13432         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13433         * symmisc.c (print_symbol_bcache_statistics)
13434         (print_objfile_statistics, maintenance_print_objfiles)
13435         (maintenance_info_symtabs, maintenance_check_symtabs)
13436         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13437         all_objfiles.
13438         * source.c (forget_cached_source_info): Use all_objfiles.
13439         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13440         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13441         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13442         * objfiles.c (update_section_map): Use all_objfiles.
13443         (shared_objfile_contains_address_p): Likewise.
13444         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13445         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13446
13447 2019-01-09  Tom Tromey  <tom@tromey.com>
13448
13449         * common/next-iterator.h: New file.
13450         * objfiles.h (class all_objfiles): New.
13451         (struct objfile_iterator): New.
13452
13453 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13454
13455         * NEWS: Move the description of the changed "frame", "select-frame",
13456          and "info frame" commands to the Changed commands section.
13457
13458 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13459
13460         * gdbtypes.c (check_stub_method_group): Remove handling of old
13461         mangling schemes.
13462         * linespec.c (find_methods): Likewise.
13463         * stabsread.c (read_member_functions): Likewise.
13464         * valops.c (search_struct_method): Likewise.
13465         (value_struct_elt_for_reference): Likewise.
13466         * NEWS: Mention this change.
13467
13468 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13469
13470         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13471         print_source_lines.
13472         * source.c (print_source_lines_base): Update line number check.
13473         (print_source_lines): New function.
13474         (source_lines_range::source_lines_range): New function.
13475         * source.h (class source_lines_range): New class.
13476         (print_source_lines): New declaration.
13477
13478 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13479
13480         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13481
13482 2019-01-08  Tom Tromey  <tom@tromey.com>
13483             Simon Marchi  <simon.marchi@ericsson.com>
13484
13485         PR gdb/24060
13486         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13487         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13488         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13489         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13490         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13491         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13492
13493 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13494
13495         * source.c (select_source_symtab): Move header comment to
13496         declaration in source.h.
13497         (forget_cached_source_info_for_objfile): Likewise.
13498         (forget_cached_source_info): Likewise.
13499         (identify_source_line): Likewise.
13500         * source.h (identify_source_line): Move declaration from symtab.h
13501         and add comment from source.c
13502         (print_source_lines): Likewise.
13503         (forget_cached_source_info_for_objfile): Likewise.
13504         (forget_cached_source_info): Likewise.
13505         (select_source_symtab): Likewise.
13506         (enum print_source_lines_flag): Move definition from symtab.h.
13507         * symtab.h (identify_source_line): Move declaration to source.h.
13508         (print_source_lines): Likewise.
13509         (forget_cached_source_info_for_objfile): Likewise.
13510         (forget_cached_source_info): Likewise.
13511         (select_source_symtab): Likewise.
13512         (enum print_source_lines_flag): Move definition to source.h.
13513         * tui/tui-hooks.c: Add 'source.h' include.
13514
13515 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13516
13517         * source.c (print_source_lines_base): Handle requests to print
13518         reverse line number sequences, and guard against empty lines
13519         string.
13520
13521 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13522
13523         * source.c (print_source_lines_base): Fix skip of '\r' if next
13524         character is '\n'.
13525
13526 2019-01-06  Tom Tromey  <tom@tromey.com>
13527
13528         * c-exp.y (struct c_parse_state) <macro_original_text,
13529         expansion_obstack>: New member.
13530         (macro_original_text, expansion_obstack): Remove globals.
13531         (scan_macro_expansion, scanning_macro_expansion)
13532         (finished_macro_expansion): Update.
13533         (scan_macro_cleanup): Remove.
13534         (yylex, c_parse): Update.
13535
13536 2019-01-06  Tom Tromey  <tom@tromey.com>
13537
13538         * c-exp.y (struct c_parse_state) <strings>: New member.
13539         (operator_stoken): Update.
13540
13541 2019-01-06  Tom Tromey  <tom@tromey.com>
13542
13543         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13544         (union type_stack_elt) <typelist_val>: Now a pointer to
13545         std::vector.
13546         (type_stack_cleanup): Don't declare.
13547         (push_typelist): Update.
13548         * parse.c (pop_typelist): Return a std::vector.
13549         (push_typelist): Take a std::vector.
13550         (follow_types): Update.  Do not free args.
13551         (type_stack_cleanup): Remove.
13552         * c-exp.y (struct c_parse_state): New.
13553         (cpstate): New global.
13554         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13555         (nonempty_typelist): Update.
13556         (func_mod): Create a new vector.
13557         (c_parse): Create a c_parse_state.
13558         (check_parameter_typelist): Do not delete params.
13559         (function_method): Update.  Do not delete type_list.
13560
13561 2019-01-06  Tom Tromey  <tom@tromey.com>
13562
13563         PR gdb/28155:
13564         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13565         check_typedef.
13566         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13567         (print_return_value): Likewise.
13568
13569 2019-01-05  Tom Tromey  <tom@tromey.com>
13570
13571         * contrib/cleanup_check.py: Remove.
13572         * contrib/gcc-with-excheck: Remove.
13573         * contrib/exsummary.py: Remove.
13574         * contrib/excheck.py: Remove.
13575
13576 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13577
13578         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13579         NULL. Initialize tpprev to NULL instead of assigning it
13580         to NULL on the next statement.
13581         * windows-nat.c (windows_delete_thread): Remove check for
13582         main_thread_id before printing thread exit notifications.
13583         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13584         Remove thread ID check against main_thread_id.
13585         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13586         windows_delete_thread.
13587         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13588
13589 2019-01-04  Tom Tromey  <tom@tromey.com>
13590
13591         * compile/compile.c (_initialize_compile): Use upper case for
13592         metasyntactic variables.
13593         * symmisc.c (_initialize_symmisc): Use upper case for
13594         metasyntactic variables.
13595         * psymtab.c (_initialize_psymtab): Use upper case for
13596         metasyntactic variables.
13597         * demangle.c (demangle_command): Use upper case for metasyntactic
13598         variables.
13599         (_initialize_demangler): Likewise.
13600         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13601         variables.
13602
13603 2019-01-03  Tom Tromey  <tom@tromey.com>
13604
13605         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13606
13607 2019-01-03  Tom Tromey  <tom@tromey.com>
13608
13609         * python/py-symtab.c (salpy_str): Update.
13610         (struct salpy_sal_object) <symtab>: Now a PyObject.
13611         (salpy_dealloc): Update.
13612         (del_objfile_sal): Use gdbpy_ref.
13613
13614 2019-01-03  Tom Tromey  <tom@tromey.com>
13615
13616         * python/py-type.c (convert_field): Use new_reference.  Return
13617         gdbpy_ref.
13618         (make_fielditem): Return gdbpy_ref.
13619         (typy_fields): Update.
13620         (typy_getitem): Update.
13621         (field_name): Return gdbpy_ref.  Use new_reference.
13622         (typy_iterator_iternext): Update.
13623
13624 2019-01-03  Tom Tromey  <tom@tromey.com>
13625
13626         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13627
13628 2019-01-03  Tom Tromey  <tom@tromey.com>
13629
13630         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13631         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13632         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13633         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13634         (pspy_set_type_printers): Likewise.
13635         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13636         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13637         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13638         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13639         (objfpy_set_type_printers): Likewise.
13640
13641 2019-01-03  Tom Tromey  <tom@tromey.com>
13642
13643         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13644         (gdbpy_print_stack): Use gdbpy_err_fetch.
13645         * python/python-internal.h (class gdbpy_err_fetch): New class.
13646         (class gdbpy_enter) <m_error_type, m_error_value,
13647         m_error_traceback>: Remove.
13648         <m_error>: New member.
13649         (gdbpy_exception_to_string): Don't declare.
13650         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13651         * python/py-value.c (convert_value_from_python): Use
13652         gdbpy_err_fetch.
13653         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13654         gdbpy_exception_to_string.
13655         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13656         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13657         gdbpy_err_fetch.
13658
13659 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13660
13661         * linux-nat.c (delete_lwp_cleanup): Delete.
13662         (struct lwp_deleter): New struct.
13663         (lwp_info_up): New typedef.
13664         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13665         lwp_info_up.
13666
13667 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13668
13669         * linux-fork.c (class scoped_switch_fork_info): New class.
13670         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13671
13672 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13673
13674         * valops.c (find_overload_match): Remove use of null_cleanup, and
13675         calls to do_cleanups.
13676
13677 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13678
13679         * compile/compile-cplus-types.c
13680         (compile_cplus_instance::decl_name): Handle changes to
13681         cp_func_name.
13682         * cp-support.c (cp_func_name): Update header comment, update
13683         return type.
13684         * cp-support.h (cp_func_name): Update return type in declaration.
13685         * valops.c (find_overload_match): Move temp_func local to top
13686         level of function and change its type.  Use temp_func to hold and
13687         delete temporary string obtained from cp_func_name.
13688
13689 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13690
13691         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13692         gdb::char_vector, remove cleanup, and update uses of `msg`.
13693
13694 2019-01-03  Jim Wilson  <jimw@sifive.com>
13695
13696         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13697
13698 2019-01-02  Tom Tromey  <tom@tromey.com>
13699
13700         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13701         (tdesc_parse_xml): Remove cleanups.
13702         * target-descriptions.h (make_cleanup_free_target_description):
13703         Don't declare.
13704         (target_desc_deleter): New struct.
13705         (target_desc_up): New typedef.
13706         * target-descriptions.c (target_desc_deleter::operator()): Rename
13707         from free_target_description.
13708         (make_cleanup_free_target_description): Remove.
13709
13710 2019-01-02  Tom Tromey  <tom@tromey.com>
13711
13712         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13713         constructor, destructor.
13714         (linespec_parser): Remove typedef.
13715         (~linespec_parser): Rename from linespec_parser_delete.
13716         (linespec_lex_to_end, linespec_complete_label)
13717         (linespec_complete): Update.
13718         (decode_line_full): Remove cleanups.
13719         (decode_line_1): Update.
13720
13721 2019-01-02  Tom Tromey  <tom@tromey.com>
13722
13723         * python/python-internal.h (inferior_to_inferior_object): Change
13724         return type.
13725         * python/py-exitedevent.c (create_exited_event_object): Update.
13726         * python/py-inferior.c (inferior_to_inferior_object): Return
13727         gdbpy_ref.
13728         (python_new_inferior, python_inferior_deleted)
13729         (thread_to_thread_object, delete_thread_object)
13730         (build_inferior_list, gdbpy_selected_inferior): Update.
13731         * python/py-infthread.c (create_thread_object): Update.  Also fail
13732         if inferior_to_inferior_object fails.
13733
13734 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13735
13736         * inferior.h (class inferior) <displaced_step_state>: New field.
13737         * infrun.h (struct displaced_step_state): Move here from
13738         infrun.c.  Initialize fields, add constructor.
13739         <inf>: Remove field.
13740         <reset>: New method.
13741         * infrun.c (struct displaced_step_inferior_state): Move to
13742         infrun.h.
13743         (displaced_step_inferior_states): Remove.
13744         (get_displaced_stepping_state): Adust.
13745         (displaced_step_in_progress_any_inferior): Adjust.
13746         (displaced_step_in_progress_thread): Adjust.
13747         (displaced_step_in_progress): Adjust.
13748         (add_displaced_stepping_state): Remove.
13749         (get_displaced_step_closure_by_addr): Adjust.
13750         (remove_displaced_stepping_state): Remove.
13751         (infrun_inferior_exit): Call displaced_step_state.reset.
13752         (use_displaced_stepping): Don't check for NULL.
13753         (displaced_step_prepare_throw): Call
13754         get_displaced_stepping_state.
13755         (displaced_step_fixup): Don't check for NULL.
13756         (prepare_for_detach): Don't check for NULL.
13757
13758 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13759
13760         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13761          in case of call that did not complete.
13762
13763 2019-01-02  Andrey Utkin  <autkin@undo.io>
13764
13765         * symfile.c (find_separate_debug_file): Fix search of debug files for
13766         remote debuggee.
13767
13768 2019-01-02  Tom Tromey  <tom@tromey.com>
13769
13770         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13771         indentation.
13772         * python/py-frame.c (frapy_older): Remove cast.
13773         (frapy_newer): Likewise.
13774         * python/py-breakpoint.c (local_setattro): Remove cast.
13775         * python/py-arch.c (archpy_name): Remove local variable.
13776         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13777
13778 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13779
13780         * unittests/basic_string_view/element_access/char/empty.cc:
13781         Fix year range in copyright header.
13782
13783 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13784
13785         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13786         Delete.
13787         <operator==>: Update with for removed field.
13788         <hash>: Likewise.
13789         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13790         <isa_features>: ...this.
13791         <abi_features>: New field.
13792         (riscv_isa_flen): Update comment.
13793         (riscv_abi_xlen): New declaration.
13794         (riscv_abi_flen): New declaration.
13795         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13796         isa_features.
13797         (riscv_abi_xlen): New function.
13798         (riscv_isa_flen): Update to get answer from isa_features.
13799         (riscv_abi_flen): New function.
13800         (riscv_has_fp_abi): Update to get answer from abi_features.
13801         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13802         xlen and flen.
13803         (riscv_call_info) <xlen, flen>: Update comment.
13804         (riscv_call_arg_struct): Remove invalid assertions
13805         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13806         is removed.
13807         (riscv_gdbarch_init): Gather isa features and abi features
13808         separately, ensure both match on the gdbarch when reusing an old
13809         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13810         a target with 64-bit float hardware.
13811
13812 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13813
13814         * source.c (search_command_helper): Stop reverse search
13815         when line 1 has been searched.
13816
13817 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13818
13819         * record-full.c (record_full_base_target::close): Rewrite
13820         record_full_core_buf_list free logic.
13821
13822 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13823
13824         * break-catch-syscall.c (print_one_catch_syscall): xfree
13825         the last text.
13826
13827 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13828
13829         * top.c (print_gdb_version): Update Copyright year in version
13830         message.
13831
13832 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13833
13834         Update copyright year range in all GDB files.
13835
13836 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13837
13838         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13839
13840 For older changes see ChangeLog-2018.
13841 \f
13842 Local Variables:
13843 mode: change-log
13844 left-margin: 8
13845 fill-column: 74
13846 version-control: never
13847 coding: utf-8
13848 End:
13849