gdb/ChangeLog

   1 2019-11-26  Tom Tromey  <tromey@adacore.com>
   2
   3         * cp-support.c (_initialize_cp_support): Conditionally initialize
   4         gdb_demangle_attempt_core_dump.
   5
   6 2019-11-26  Tom Tromey  <tom@tromey.com>
   7
   8         * python/py-function.c (fnpy_init): Update.
   9         * value.h (add_internal_function): Adjust declaration.
  10         * value.c (function_destroyer): Remove.
  11         (do_add_internal_function): Don't set destroyer or copy name.
  12         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
  13         Set name_allocated.
  14         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
  15         (cmdpy_init): Set name_allocated.
  16         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
  17         member.
  18         (~cmd_list_element): Free "name" if needed.
  19
  20 2019-11-26  Tom Tromey  <tom@tromey.com>
  21
  22         * value.h (add_internal_function): Add new overload.  Move
  23         documentation from value.h.
  24         * value.c (do_add_internal_function): New function.
  25         (add_internal_function): Use it.  Add new overload.
  26         (function_destroyer): Don't free doc.
  27         * python/py-function.c (fnpy_init): Update.
  28
  29 2019-11-26  Tom Tromey  <tom@tromey.com>
  30
  31         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
  32         (cmdpy_init): Set "doc_allocated".
  33
  34 2019-11-26  Tom Tromey  <tom@tromey.com>
  35
  36         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
  37         name of worker thread.
  38         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
  39         pthread_setname_np.
  40         * configure, config.in: Rebuild.
  41
  42 2019-11-26  Tom Tromey  <tom@tromey.com>
  43
  44         * python/python.c (class gdbpy_gil): New.
  45         (struct gdbpy_event): Add constructor, destructor, operator().
  46         (gdbpy_post_event): Use run_on_main_thread.
  47         (gdbpy_initialize_events): Remove.
  48         (do_start_initialization): Update.
  49
  50 2019-11-26  Tom Tromey  <tom@tromey.com>
  51
  52         * NEWS: Add entry.
  53         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
  54         commands.  Call update_thread_pool_size.
  55         (update_thread_pool_size, maintenance_set_worker_threads): New
  56         functions.
  57         (n_worker_threads): New global.
  58
  59 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
  60             Tom Tromey  <tom@tromey.com>
  61
  62         * minsyms.c (minimal_symbol_reader::install): Use
  63         parallel_for_each.
  64         * gdbsupport/parallel-for.h: New file.
  65         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
  66
  67 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
  68             Tom Tromey  <tom@tromey.com>
  69
  70         * gdbsupport/thread-pool.h: New file.
  71         * gdbsupport/thread-pool.c: New file.
  72         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
  73         (HFILES_NO_SRCDIR): Add thread-pool.h.
  74
  75 2019-11-26  Tom Tromey  <tom@tromey.com>
  76
  77         * event-top.h (thread_local_segv_handler): Declare.
  78         * event-top.c (thread_local_segv_handler): New global.
  79         (install_handle_sigsegv, handle_sigsegv): New functions.
  80         (async_init_signals): Install SIGSEGV handler.
  81         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
  82         thread-local.
  83         (report_failed_demangle): New function.
  84         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
  85         handler-setting code, instead use segv_handler.  Run warning code
  86         on main thread.
  87
  88 2019-11-26  Tom Tromey  <tom@tromey.com>
  89
  90         * run-on-main-thread.c: New file.
  91         * run-on-main-thread.h: New file.
  92         * unittests/main-thread-selftests.c: New file.
  93         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
  94         main-thread-selftests.c.
  95         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
  96         (COMMON_SFILES): Add run-on-main-thread.c.
  97
  98 2019-11-26  Tom Tromey  <tom@tromey.com>
  99
 100         * main.c (setup_alternate_signal_stack): Remove.
 101         (captured_main_1): Use gdb::alternate_signal_stack.
 102         * gdbsupport/alt-stack.h: New file.
 103
 104 2019-11-26  Tom Tromey  <tom@tromey.com>
 105
 106         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 107         Remove comment.
 108         (save_original_signals_state, restore_original_signals_state): Use
 109         gdb_sigmask.
 110         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 111         (_initialize_linux_nat): Use gdb_sigmask.
 112         * guile/guile.c (_initialize_guile): Use block_signals.
 113         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 114         * gdbsupport/gdb-sigmask.h: New file.
 115         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 116         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 117         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 118         pthread_sigmask.
 119         * configure, config.in: Rebuild.
 120         * gdbsupport/block-signals.h: New file.
 121
 122 2019-11-26  Tom Tromey  <tom@tromey.com>
 123
 124         * acinclude.m4: Include ax_pthread.m4.
 125         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 126         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 127         (CLIBS): Use PTHREAD_LIBS.
 128         (aclocal_m4_deps): Add ax_pthread.m4.
 129         * config.in, configure: Rebuild.
 130         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 131
 132 2019-11-26  Tom Tromey  <tom@tromey.com>
 133
 134         * symtab.h (struct minimal_symbol) <name_set>: New member.
 135         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 136         Don't call symbol_set_names.
 137         (minimal_symbol_reader::install): Call symbol_set_names.
 138
 139 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 140
 141         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 142         restore_active_ext_lang, as GIL is needed for (indirectly)
 143         called PyOS_InterruptOccurred.
 144
 145 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 146
 147         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 148         definition.
 149
 150 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 151
 152         * remote-sim.c (simulator_command): Make static, remove
 153         declaration.
 154
 155 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 156
 157         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 158         static.
 159         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 160         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 161         (main): Likewise.
 162         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 163         (main): Likewise.
 164         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 165         (main): Likewise.
 166         * unittests/basic_string_view/element_access/char/1.cc (test01):
 167         Likewise.
 168         (main): Likewise.
 169         * unittests/basic_string_view/element_access/char/empty.cc (main):
 170         Likewise.
 171         * unittests/basic_string_view/element_access/char/front_back.cc
 172         (test01): Likewise.
 173         (main): Likewise.
 174         * unittests/basic_string_view/inserters/char/2.cc (test05):
 175         Likewise.
 176         (main): Likewise.
 177         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 178         (test01): Likewise.
 179         (main): Likewise.
 180         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 181         (test01): Likewise.
 182         (main): Likewise.
 183         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 184         Likewise.
 185         * unittests/basic_string_view/operations/compare/char/1.cc
 186         (test01): Likewise.
 187         (main): Likewise.
 188         * unittests/basic_string_view/operations/compare/char/13650.cc
 189         (test01): Likewise.
 190         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 191         Likewise.
 192         (main): Likewise.
 193         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 194         Likewise.
 195         (main): Likewise.
 196         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 197         Likewise.
 198         (main): Likewise.
 199         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 200         Likewise.
 201         (main): Likewise.
 202         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 203         Likewise.
 204         (main): Likewise.
 205         * unittests/basic_string_view/operations/find/char/4.cc (main):
 206         Likewise.
 207         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 208         Likewise.
 209         (main): Likewise.
 210         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 211         Likewise.
 212         (main): Likewise.
 213         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 214         Likewise.
 215         (main): Likewise.
 216         * unittests/basic_string_view/operations/substr/char/1.cc
 217         (test01): Likewise.
 218         (main): Likewise.
 219         * unittests/basic_string_view/operators/char/2.cc (main):
 220         Likewise.
 221         * unittests/optional/assignment/1.cc (test): Likewise.
 222         * unittests/optional/assignment/2.cc (test): Likewise.
 223         * unittests/optional/assignment/3.cc (test): Likewise.
 224         * unittests/optional/assignment/4.cc (test): Likewise.
 225         * unittests/optional/assignment/5.cc (test): Likewise.
 226         * unittests/optional/assignment/6.cc (test): Likewise.
 227         * unittests/optional/assignment/7.cc (test): Likewise.
 228         * unittests/optional/cons/copy.cc (test): Likewise.
 229         * unittests/optional/cons/default.cc (test): Likewise.
 230         * unittests/optional/cons/move.cc (test): Likewise.
 231         * unittests/optional/cons/value.cc (test): Likewise.
 232         * unittests/optional/in_place.cc (test): Likewise.
 233         * unittests/optional/observers/1.cc (test): Likewise.
 234         * unittests/optional/observers/2.cc (test): Likewise.
 235
 236 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 237
 238         * tui-win.h (tui_set_var_cmd): Remove.
 239         * tui-win.c (tui_set_var_cmd): Make static.
 240
 241 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 242
 243         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 244         rbreak_command_wrapper): Remove.
 245         * symtab.c (rbreak_command_wrapper): Remove.
 246
 247 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 248
 249         * inferior.h (info_terminal_command): Remove declaration.
 250         * inflow.c (info_terminal_command): Make static.
 251
 252 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 253
 254         * inferior.c (exit_inferior_silent): Remove.
 255
 256 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 257
 258         * dictionary.c (dict_empty, mdict_empty): Remove.
 259         * dictionary.c (mdict_empty): Remove.
 260
 261 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 262
 263          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 264          (arc_insn_get_memory_offset): Likewise.
 265          (arc_insn_dump): Likewise.
 266          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 267          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 268          * dictionary.c (dict_iterator_next): Likewise.
 269          (dict_iter_match_first): Likewise.
 270          (dict_iter_match_next): Likewise.
 271          * f-lang.c (evaluate_subexp_f): Likewise.
 272          * hppa-tdep.c (hppa_read_pc): Likewise.
 273          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 274          * parse.c (write_exp_elt_msym): Likewise.
 275          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 276          * remote.c (remote_packet_size): Likewise.
 277          (remote_notif_stop_parse): Likewise.
 278          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 279          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 280          * source.c (prepare_path_for_appending): Likewise.
 281          * sparc64-linux-tdep.c
 282          (sparc64_linux_handle_segmentation_fault); Likewise.
 283          * stack.c (frame_selection_by_function_completer): Likewise.
 284
 285 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 286
 287         * completer.c (set_gdb_completion_word_break_characters):
 288         Remove.
 289
 290 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 291
 292         * dwarf-index-write.c: Include dwarf-index-write.h.
 293         * mi/mi-interp.c: Include mi/mi-interp.h.
 294
 295 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 296
 297         * aarch32-tdep.c: Include aarch32-tdep.h.
 298         * aarch32-tdep.h: Forward-declare struct target_desc.
 299
 300 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 301
 302         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 303         strerror.
 304         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 305         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 306
 307 2019-11-25  Tom de Vries  <tdevries@suse.de>
 308
 309         * contrib/words.sh: Add -c option.
 310
 311 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
 312
 313         * solib.c (solib_find_1): Change int to bool.
 314         (exec_file_find): Change int to bool.
 315         (solib_find): Change int to bool.
 316         (solib_read_symbols): Change int to bool.
 317         (solib_used): Change int to bool.
 318         (solib_add): Change int to bool.
 319         (info_sharedlibrary_command): Change int to bool.
 320         (solib_contains_address_p): Change int to bool.
 321         (solib_keep_data_in_core): Change int to bool.
 322         (in_solib_dynsym_resolve_code): Change int to bool.
 323         (reload_shared_libraries_1): Change int to bool.
 324         (gdb_sysroot_changed): Change int to bool.
 325         * solib.h (solib_read_symbols): Change int to bool.
 326         (solib_contains_address_p): Change int to bool.
 327         (solib_keep_data_in_core): Change int to bool.
 328         (in_solib_dynsym_resolve_code): Change int to bool.
 329         (libpthread_name_p): Change int to bool.
 330
 331 2019-11-25  Luis Machado  <luis.machado@linaro.org>
 332
 333         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
 334         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
 335         (remote_packet_max_chars): New static global.
 336         (show_remote_packet_max_chars): New function.
 337         (remote_target::putpkt_binary): Adjust to use new
 338         remote_packet_max_chars option.
 339         (remote_target::getpkt_or_notif_sane_1): Likewise.
 340         (_initialize_remote): Register new remote-packet-max-chars option.
 341
 342 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
 343
 344         * m68k-linux-nat.c: Include gdbarch.h.
 345
 346 2019-11-24  Tom Tromey  <tom@tromey.com>
 347
 348         * symfile.c (read_symbols): Update.
 349         * psymtab.c (require_partial_symbols): Change type of "verbose" to
 350         bool.
 351         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 352         (psym_lookup_symbol, psym_find_last_source_symtab)
 353         (psym_forget_cached_source_info, psym_print_stats)
 354         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 355         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 356         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 357         (psym_find_compunit_symtab_by_address)
 358         (maintenance_print_psymbols, maintenance_info_psymtabs)
 359         (maintenance_check_psymtabs): Update.
 360         * psymtab.h (require_partial_symbols): Change type of "verbose" to
 361         bool.
 362
 363 2019-11-22  Tom Tromey  <tom@tromey.com>
 364
 365         * observable.h: Update comments.
 366
 367 2019-11-22  Tom Tromey  <tromey@adacore.com>
 368
 369         * ada-tasks.c (ada_task_is_alive): Make parameter const.
 370         (print_ada_task_info): Don't try to fetch thread id if task is not
 371         alive.
 372
 373 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 374
 375         * ada-exp.y: Update.
 376         * ada-lang.c (sort_choices): Update.
 377         (ada_print_symbol_signature): Update.
 378         (resolve_subexp): Update.
 379         (ada_parse_renaming): Update.
 380         (ada_read_renaming_var_value): Update.
 381         (lesseq_defined_than): Update.
 382         (remove_extra_symbols): Update.
 383         (remove_irrelevant_renamings): Update.
 384         (ada_add_block_symbols): Update.
 385         (ada_collect_symbol_completion_matches): Update.
 386         (ada_is_renaming_symbol): Update.
 387         (aggregate_assign_from_choices): Update.
 388         (ada_evaluate_subexp): Update.
 389         (ada_has_this_exception_support): Update.
 390         (ada_is_non_standard_exception_sym): Update.
 391         (ada_add_exceptions_from_frame): Update.
 392         (ada_add_global_exceptions): Update.
 393         (ada_print_subexp): Update.
 394         * ax-gdb.c (gen_var_ref): Update.
 395         (gen_maybe_namespace_elt): Update.
 396         (gen_expr_for_cast): Update.
 397         (gen_expr): Update.
 398         * block.h: Update.
 399         * blockframe.c (find_pc_partial_function): Update.
 400         * breakpoint.c (print_breakpoint_location): Update.
 401         (update_static_tracepoint): Update.
 402         * btrace.c (ftrace_print_function_name): Update.
 403         (ftrace_function_switched): Update.
 404         * buildsym.c (find_symbol_in_list): Update.
 405         * c-exp.y: Update.
 406         * c-typeprint.c (c_print_typedef): Update.
 407         (c_type_print_template_args): Update.
 408         * cli/cli-cmds.c (edit_command): Update.
 409         (list_command): Update.
 410         (print_sal_location): Update.
 411         * coffread.c (patch_opaque_types): Update.
 412         (process_coff_symbol): Update.
 413         (coff_read_enum_type): Update.
 414         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
 415         (convert_one_symbol): Update.
 416         (hash_symname): Update.
 417         (eq_symname): Update.
 418         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
 419         * compile/compile-cplus-types.c (debug_print_scope): Update.
 420         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 421         * compile/compile-object-load.c (get_out_value_type): Update.
 422         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
 423         (search_symbol_list): Update.
 424         (cp_lookup_symbol_imports_or_template): Update.
 425         * cp-support.c (overload_list_add_symbol): Update.
 426         * ctfread.c (psymtab_to_symtab): Update.
 427         * dbxread.c (cp_set_block_scope): Update.
 428         * dictionary.c (iter_match_first_hashed): Update.
 429         (iter_match_next_hashed): Update.
 430         (insert_symbol_hashed): Update.
 431         (iter_match_next_linear): Update.
 432         * dictionary.h: Update.
 433         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
 434         (locexpr_describe_location_piece): Update.
 435         (locexpr_describe_location_1): Update.
 436         (locexpr_generate_c_location): Update.
 437         (loclist_describe_location): Update.
 438         (loclist_generate_c_location): Update.
 439         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
 440         (read_func_scope): Update.
 441         (process_enumeration_scope): Update.
 442         (new_symbol): Update.
 443         (dwarf2_const_value): Update.
 444         (dwarf2_symbol_mark_computed): Update.
 445         * eval.c (evaluate_funcall): Update.
 446         (evaluate_subexp_standard): Update.
 447         * expprint.c (print_subexp_standard): Update.
 448         (dump_subexp_body_standard): Update.
 449         * f-valprint.c (info_common_command_for_block): Update.
 450         * findvar.c (get_hosting_frame): Update.
 451         (default_read_var_value): Update.
 452         * go-lang.c (go_symbol_package_name): Update.
 453         * guile/scm-block.c (bkscm_print_block_smob): Update.
 454         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
 455         (gdbscm_symbol_name): Update.
 456         (gdbscm_symbol_linkage_name): Update.
 457         (gdbscm_symbol_print_name): Update.
 458         * infcall.c (get_function_name): Update.
 459         * infcmd.c (jump_command): Update.
 460         (finish_command): Update.
 461         * infrun.c (insert_exception_resume_breakpoint): Update.
 462         * linespec.c (canonicalize_linespec): Update.
 463         (create_sals_line_offset): Update.
 464         (convert_linespec_to_sals): Update.
 465         (complete_label): Update.
 466         (find_label_symbols_in_block): Update.
 467         * m2-typeprint.c (m2_print_typedef): Update.
 468         * mdebugread.c (mdebug_reg_to_regnum): Update.
 469         (parse_symbol): Update.
 470         (mylookup_symbol): Update.
 471         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 472         (list_args_or_locals): Update.
 473         * objc-lang.c (compare_selectors): Update.
 474         (info_selectors_command): Update.
 475         (compare_classes): Update.
 476         (info_classes_command): Update.
 477         (find_imps): Update.
 478         * p-typeprint.c (pascal_print_typedef): Update.
 479         * printcmd.c (build_address_symbolic): Update.
 480         (info_address_command): Update.
 481         (print_variable_and_value): Update.
 482         * python/py-framefilter.c (extract_sym): Update.
 483         (py_print_single_arg): Update.
 484         * python/py-symbol.c (sympy_str): Update.
 485         (sympy_get_name): Update.
 486         (sympy_get_linkage_name): Update.
 487         * python/python.c (gdbpy_rbreak): Update.
 488         * record-btrace.c (btrace_get_bfun_name): Update.
 489         (btrace_call_history): Update.
 490         * rust-lang.c (rust_print_typedef): Update.
 491         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 492         * stabsread.c (stab_reg_to_regnum): Update.
 493         (define_symbol): Update.
 494         (read_enum_type): Update.
 495         (common_block_end): Update.
 496         (cleanup_undefined_types_1): Update.
 497         (scan_file_globals): Update.
 498         * stack.c (print_frame_arg): Update.
 499         (print_frame_args): Update.
 500         (find_frame_funname): Update.
 501         (info_frame_command_core): Update.
 502         (iterate_over_block_locals): Update.
 503         (print_block_frame_labels): Update.
 504         (do_print_variable_and_value): Update.
 505         (iterate_over_block_arg_vars): Update.
 506         (return_command): Update.
 507         * symmisc.c (dump_symtab_1): Update.
 508         (print_symbol): Update.
 509         * symtab.c (eq_symbol_entry): Update.
 510         (symbol_cache_dump): Update.
 511         (lookup_language_this): Update.
 512         (find_pc_sect_line): Update.
 513         (skip_prologue_sal): Update.
 514         (symbol_search::compare_search_syms): Update.
 515         (treg_matches_sym_type_name): Update.
 516         (search_symbols): Update.
 517         (print_symbol_info): Update.
 518         (rbreak_command): Update.
 519         (completion_list_add_symbol): Update.
 520         (find_gnu_ifunc): Update.
 521         (get_symbol_address): Update.
 522         (search_module_symbols): Update.
 523         (info_module_subcommand): Update.
 524         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 525         (SYMBOL_LINKAGE_NAME): Remove.
 526         (SYMBOL_DEMANGLED_NAME): Remove.
 527         (SYMBOL_PRINT_NAME): Remove.
 528         (SYMBOL_SEARCH_NAME): Remove.
 529         * tracepoint.c (set_traceframe_context): Update.
 530         (validate_actionline): Update.
 531         (collection_list::collect_symbol): Update.
 532         (encode_actions_1): Update.
 533         (info_scope_command): Update.
 534         (print_one_static_tracepoint_marker): Update.
 535         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 536         * valops.c (address_of_variable): Update.
 537         (find_overload_match): Update.
 538         (find_oload_champ): Update.
 539
 540 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 541
 542         * ada-lang.c (ada_lookup_simple_minsym): Update.
 543         (ada_collect_symbol_completion_matches): Update.
 544         * ada-tasks.c (read_atcb): Update.
 545         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 546         (amd64_windows_skip_trampoline_code): Update.
 547         * arm-tdep.c (skip_prologue_function): Update.
 548         (arm_skip_stack_protector): Update.
 549         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
 550         (arm_wince_skip_main_prologue): Update.
 551         * ax-gdb.c (gen_expr): Update.
 552         * block.c (call_site_for_pc): Update.
 553         * blockframe.c (find_pc_partial_function): Update.
 554         * breakpoint.c (set_breakpoint_location_function): Update.
 555         * btrace.c (ftrace_print_function_name): Update.
 556         (ftrace_function_switched): Update.
 557         * c-valprint.c (print_unpacked_pointer): Update.
 558         * coffread.c (coff_symfile_read): Update.
 559         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
 560         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
 561         * dwarf-index-write.c (write_psymbols): Update.
 562         * dwarf2loc.c (call_site_to_target_addr): Update.
 563         (func_verify_no_selftailcall): Update.
 564         (tailcall_dump): Update.
 565         (call_site_find_chain_1): Update.
 566         (dwarf_expr_reg_to_entry_parameter): Update.
 567         * elfread.c (elf_gnu_ifunc_record_cache): Update.
 568         * eval.c (evaluate_funcall): Update.
 569         (evaluate_subexp_standard): Update.
 570         (evaluate_subexp_for_sizeof): Update.
 571         * expprint.c (print_subexp_standard): Update.
 572         (dump_subexp_body_standard): Update.
 573         * frame.c (get_prev_frame_always_1): Update.
 574         * frv-tdep.c (frv_skip_main_prologue): Update.
 575         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
 576         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
 577         (gnuv3_get_typename_from_type_info): Update.
 578         (gnuv3_skip_trampoline): Update.
 579         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 580         * i386-tdep.c (i386_skip_main_prologue): Update.
 581         (i386_pe_skip_trampoline_code): Update.
 582         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
 583         * infcall.c (get_function_name): Update.
 584         * linespec.c (minsym_found): Update.
 585         * linux-fork.c (info_checkpoints_command): Update.
 586         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
 587         (m32c_m16c_pointer_to_address): Update.
 588         * maint.c (maintenance_translate_address): Update.
 589         * minsyms.c (add_minsym_to_hash_table): Update.
 590         (add_minsym_to_demangled_hash_table): Update.
 591         (lookup_minimal_symbol_mangled): Update.
 592         (lookup_minimal_symbol_demangled): Update.
 593         (lookup_minimal_symbol_linkage): Update.
 594         (lookup_minimal_symbol_text): Update.
 595         (lookup_minimal_symbol_by_pc_name): Update.
 596         (minimal_symbol_is_less_than): Update.
 597         (compact_minimal_symbols): Update.
 598         (build_minimal_symbol_hash_tables): Update.
 599         (find_solib_trampoline_target): Update.
 600         * mips-tdep.c (mips_stub_frame_sniffer): Update.
 601         (mips_skip_pic_trampoline_code): Update.
 602         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
 603         * objc-lang.c (info_selectors_command): Update.
 604         (info_classes_command): Update.
 605         (find_methods): Update.
 606         (find_imps): Update.
 607         * p-valprint.c (pascal_val_print): Update.
 608         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
 609         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
 610         * printcmd.c (build_address_symbolic): Update.
 611         (info_symbol_command): Update.
 612         * psymtab.c (psymbol_name_matches): Update.
 613         (match_partial_symbol): Update.
 614         (lookup_partial_symbol): Update.
 615         (print_partial_symbols): Update.
 616         (sort_pst_symbols): Update.
 617         (maintenance_check_psymtabs): Update.
 618         * python/py-framefilter.c (py_print_frame): Update.
 619         * python/python.c (gdbpy_rbreak): Update.
 620         * record-btrace.c (btrace_get_bfun_name): Update.
 621         (btrace_call_history): Update.
 622         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
 623         (rs6000_skip_trampoline_code): Update.
 624         * sol-thread.c (info_cb): Update.
 625         * stabsread.c (scan_file_globals): Update.
 626         * stack.c (find_frame_funname): Update.
 627         (info_frame_command_core): Update.
 628         * symmisc.c (dump_msymbols): Update.
 629         * symtab.c (symbol_natural_name): Rename to..,
 630         (general_symbol_info::natural_name): ...this.
 631         (symbol_demangled_name): Rename to...
 632         (general_symbol_info::demangled_name): ...this.
 633         (symbol_search_name): Rename to...
 634         (general_symbol_info::search_name): ...this.
 635         (symbol_matches_search_name): Update.
 636         (find_pc_sect_line): Update.
 637         (skip_prologue_sal): Update.
 638         (search_symbols): Update.
 639         (print_msymbol_info): Update.
 640         (rbreak_command): Update.
 641         (completion_list_add_msymbol): Update.
 642         (completion_list_objc_symbol): Update.
 643         (get_msymbol_address): Update.
 644         * symtab.h (struct general_symbol_info): Add member functions
 645         natural_name (), linkage_name (), print_name (), demangled_name (),
 646         and search_name ().
 647         (SYMBOL_NATURAL_NAME): Update.
 648         (symbol_natural_name): Move to a member function on general_symbol_info.
 649         (SYMBOL_DEMANGLED_NAME): Update.
 650         (symbol_demangled_name): Move to a member function on
 651         general_symbol_info.
 652         (SYMBOL_SEARCH_NAME): Update.
 653         (symbol_search_name): Move to a member function on general_symbol_info.
 654         (MSYMBOL_NATURAL_NAME): Remove.
 655         (MSYMBOL_LINKAGE_NAME): Remove.
 656         (MSYMBOL_PRINT_NAME): Remove.
 657         (MSYMBOL_DEMANGLED_NAME): Remove.
 658         (MSYMBOL_SEARCH_NAME): Remove.
 659         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
 660
 661 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 662
 663         * symtab.c (create_demangled_names_hash): Use per_bfd->
 664         minimal_symbol_count for computing the initial size, if greater
 665         than our default size.
 666
 667 2019-11-22  Tom de Vries  <tdevries@suse.de>
 668
 669         * contrib/words.sh: Improve words extraction.
 670
 671 2019-11-22  Tom de Vries  <tdevries@suse.de>
 672
 673         * contrib/words.sh: Combine sed invocations.
 674
 675 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
 676
 677         * Makefile.in: Update.
 678         * demangle.c: Rename to...
 679         * gdb-demangle.c: ..this.
 680         (is_cplus_marker): Change return type to bool.
 681         (_initialize_demangler): Rename to...
 682         (_initialize_gdb_demangle): ...this.
 683         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
 684         * symtab.h (demangle): Remove declaration; instead include
 685         gdb-demangle.h.
 686
 687 2019-11-21  Tom Tromey  <tromey@adacore.com>
 688
 689         * gdbsupport/format.c (format_pieces): Parse %I64d.
 690         * unittests/format_pieces-selftests.c (test_windows_formats): New
 691         function.
 692         (run_tests): Call it.
 693
 694 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
 695
 696         Byte reverse display of variables with DW_END_big, DW_END_little
 697         (DW_AT_endianity) dwarf attributes if different than the native
 698         byte order.
 699         * ada-lang.c (ada_value_binop):
 700         Use type_byte_order instead of gdbarch_byte_order.
 701         * ada-valprint.c (printstr):
 702         (ada_val_print_string):
 703         * ada-lang.c (value_pointer):
 704         (ada_value_binop):
 705         Use type_byte_order instead of gdbarch_byte_order.
 706         * c-lang.c (c_get_string):
 707         Use type_byte_order instead of gdbarch_byte_order.
 708         * c-valprint.c (c_val_print_array):
 709         Use type_byte_order instead of gdbarch_byte_order.
 710         * cp-valprint.c (cp_print_class_member):
 711         Use type_byte_order instead of gdbarch_byte_order.
 712         * dwarf2loc.c (rw_pieced_value):
 713         Use type_byte_order instead of gdbarch_byte_order.
 714         * dwarf2read.c (read_base_type): Handle DW_END_big,
 715         DW_END_little
 716         * f-lang.c (f_get_encoding):
 717         Use type_byte_order instead of gdbarch_byte_order.
 718         * findvar.c (default_read_var_value):
 719         Use type_byte_order instead of gdbarch_byte_order.
 720         * gdbtypes.c (check_types_equal):
 721         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
 722         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
 723         and TYPE_ENDIANITY_LITTLE if set.
 724         (type_byte_order): new function.
 725         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
 726         (struct main_type) <flag_endianity_not_default>:
 727         New field.
 728         (type_byte_order): New function.
 729         * infcmd.c (default_print_one_register_info):
 730         Use type_byte_order instead of gdbarch_byte_order.
 731         * p-lang.c (pascal_printstr):
 732         Use type_byte_order instead of gdbarch_byte_order.
 733         * p-valprint.c (pascal_val_print):
 734         Use type_byte_order instead of gdbarch_byte_order.
 735         * printcmd.c (print_scalar_formatted):
 736         Use type_byte_order instead of gdbarch_byte_order.
 737         * solib-darwin.c (darwin_current_sos):
 738         Use type_byte_order instead of gdbarch_byte_order.
 739         * solib-svr4.c (solib_svr4_r_ldsomap):
 740         Use type_byte_order instead of gdbarch_byte_order.
 741         * stap-probe.c (stap_modify_semaphore):
 742         Use type_byte_order instead of gdbarch_byte_order.
 743         * target-float.c (target_float_same_format_p):
 744         Use type_byte_order instead of gdbarch_byte_order.
 745         * valarith.c (scalar_binop):
 746         (value_bit_index):
 747         Use type_byte_order instead of gdbarch_byte_order.
 748         * valops.c (value_cast):
 749         Use type_byte_order instead of gdbarch_byte_order.
 750         * valprint.c (generic_emit_char):
 751         (generic_printstr):
 752         (val_print_string):
 753         Use type_byte_order instead of gdbarch_byte_order.
 754         * value.c (unpack_long):
 755         (unpack_bits_as_long):
 756         (unpack_value_bitfield):
 757         (modify_field):
 758         (pack_long):
 759         (pack_unsigned_long):
 760         Use type_byte_order instead of gdbarch_byte_order.
 761         * findvar.c (unsigned_pointer_to_address):
 762         (signed_pointer_to_address):
 763         (unsigned_address_to_pointer):
 764         (address_to_signed_pointer):
 765         (default_read_var_value):
 766         (default_value_from_register):
 767         Use type_byte_order instead of gdbarch_byte_order.
 768         * gnu-v3-abi.c (gnuv3_make_method_ptr):
 769         Use type_byte_order instead of gdbarch_byte_order.
 770         * riscv-tdep.c (riscv_print_one_register_info):
 771         Use type_byte_order instead of gdbarch_byte_order.
 772
 773 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
 774
 775         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
 776         (current_ui_gdb_stdin_ptr): Likewise.
 777         (current_ui_gdb_stderr_ptr): Likewise.
 778         (current_ui_gdb_stdlog_ptr): Likewise.
 779         (current_ui_current_uiout_ptr): Likewise.
 780         (gen_ret_current_ui_field_ptr): Remove.
 781
 782 2019-11-21  Tom de Vries  <tdevries@suse.de>
 783
 784         PR gdb/24956
 785         * cli/cli-script.c (execute_control_command): Only switch to
 786         INTERP_CONSOLE's ui_out when INTERP_MI is active.
 787
 788 2019-11-19  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
 791         Now static.  Change type of "name".
 792         (tui_set_win_height_command): Don't copy "arg".
 793         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
 794         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
 795
 796 2019-11-19  Ali Tamur <tamur@google.com>
 797
 798         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
 799         "if (attr != nullptr)".
 800         (dwarf2_find_base_address): Likewise.
 801         (dwarf2_build_include_psymtabs): Likewise.
 802         (read_cutu_die_from_dwo): Likewise.
 803         (read_func_scope): Likewise.
 804         (read_call_site_scope): Likewise.
 805         (dwarf2_get_pc_bounds): Likewise.
 806         (dwarf2_record_block_ranges): Likewise.
 807         (dwarf2_add_field): Likewise.
 808         (dwarf2_add_member_fn): Likewise.
 809         (read_structure_type): Likewise.
 810         (read_enumeration_type): Likewise.
 811         (read_array_type): Likewise.
 812         (read_array_order): Likewise.
 813         (read_set_type): Likewise.
 814         (read_common_block): Likewise.
 815         (read_tag_reference_type): Likewise.
 816         (read_tag_string_type): Likewise.
 817         (read_subroutine_type): Likewise.
 818         (read_base_type): Likewise.
 819         (read_subrange_type): Likewise.
 820         (new_symbol): Likewise.
 821         (prepare_one_comp_unit): Likewise.
 822
 823 2019-11-19  Tom Tromey  <tromey@adacore.com>
 824
 825         * windows-nat.c (windows_nat_target::attach): Include GetLastError
 826         result in error when DebugActiveProcess fails.
 827
 828 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
 829             Pedro Alves  <palves@redhat.com>
 830
 831         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
 832         * target.c (target_stack::push): Call 'unpush' if there's a
 833         target on top of the stack.
 834
 835 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 836
 837         * python/py-block.c (blpy_dealloc): Call tp_free.
 838         (blpy_block_syms_dealloc): Likewise.
 839         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
 840         * python/py-inferior.c (infpy_dealloc): Likewise.
 841         * python/py-lazy-string.c (stpy_dealloc): Likewise.
 842         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
 843         * python/py-symbol.c (sympy_dealloc): Likewise.
 844         * python/py-symtab.c (stpy_dealloc): Likewise.
 845         * python/py-type.c (typy_iterator_dealloc): Likewise.
 846
 847 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
 848
 849         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
 850         constructor instead of using a class initializer.
 851
 852 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 853
 854         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
 855         * configure: Regenerate.
 856         * configure.ac: Don't source common.host.
 857         * gdbsupport/common.host: Remove.
 858         * gdbsupport/mingw-strerror.c: Remove.
 859         * gdbsupport/posix-strerror.c: Rename to...
 860         * gdbsupport/safe-strerror.c: ...this.
 861
 862 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 863
 864         * maint.c (scoped_command_stats::print_time): Use localtime_r
 865         instead of localtime (provided through gnulib if necessary).
 866         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
 867         of ctime.
 868
 869 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 870
 871         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
 872         avoid compile errors.
 873
 874 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
 875
 876         * config.in: Regenerate.
 877         * configure: Regenerate.
 878         * gdbsupport/common.m4: No longer check for strerror_r.
 879         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
 880         POSIX version of strerror_r, now that gnulib provides it if
 881         necessary.
 882
 883 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
 884
 885         * README (`configure' options): Update.
 886
 887 2019-11-14  Tom Tromey  <tromey@adacore.com>
 888
 889         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
 890         expected type for the RHS if the LHS is a convenience variable.
 891
 892 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
 893
 894         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
 895         Provide explicit default and copy constructor.
 896
 897 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 898
 899         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
 900         only call Py_INCREF (newbp) in the bppy_pending_object case.
 901
 902 2019-11-13  Tom Tromey  <tromey@adacore.com>
 903
 904         PR build/25182:
 905         * psympriv.h (partial_symbol): Remove static assert.
 906         * symtab.h (general_symbol_info, symbol): Remove static assert.
 907
 908 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         * gdbsupport/format.c (format_pieces::format_pieces): Support
 911         printf 'z' size modifier.
 912         * gdbsupport/format.h (enum argclass): Add size_t_arg.
 913         * printcmd.c (ui_printf):  Handle size_t_arg.
 914         * ui-out.c (ui_out::vmessage): Likewise.
 915         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
 916         function.
 917         (run_tests): Call test_format_int_sizes.
 918
 919 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
 920
 921         * ada-exp.y (write_ambiguous_var): Update.
 922         * buildsym.c (add_symbol_to_list): Update.
 923         * dwarf2read.c (read_variable): Update.
 924         (new_symbol): Update.
 925         * jit.c (finalize_symtab): Update.
 926         * language.c (language_alloc_type_symbol): Update.
 927         * symtab.c (fixup_symbol_section): Update.
 928         (initialize_objfile_symbol_1): Move code to...
 929         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
 930         (allocate_symbol): Update.
 931         (allocate_template_symbol): Update.
 932         (get_symbol_address): Update.
 933         * symtab.h (struct symbol): Inherit from general_symbol_info instead
 934         of having as a field, and add a constructor.
 935         (SYMBOL_VALUE): Update.
 936         (SYMBOL_VALUE_ADDRESS): Update.
 937         (SET_SYMBOL_VALUE_ADDRESS): Update.
 938         (SYMBOL_VALUE_BYTES): Update.
 939         (SYMBOL_VALUE_COMMON_BLOCK): Update.
 940         (SYMBOL_BLOCK_VALUE): Update.
 941         (SYMBOL_VALUE_CHAIN): Update.
 942         (SYMBOL_LANGUAGE): Update.
 943         (SYMBOL_SECTION): Update.
 944         (SYMBOL_OBJ_SECTION): Update.
 945         (SYMBOL_SET_LANGUAGE): Update.
 946         (SYMBOL_SET_LINKAGE_NAME): Update.
 947         (SYMBOL_SET_NAMES): Update.
 948         (SYMBOL_NATURAL_NAME): Update.
 949         (SYMBOL_LINKAGE_NAME): Update.
 950         (SYMBOL_DEMANGLED_NAME): Update.
 951         (SYMBOL_SEARCH_NAME): Update.
 952         (SYMBOL_MATCHES_SEARCH_NAME): Update.
 953         (struct symbol): Update.
 954         (struct template_symbol): Update.
 955         (struct rust_vtable_symbol): Update.
 956         * xcoffread.c (SYMBOL_DUP): Update.
 957
 958 2019-11-12  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-layout.c (show_layout): Set current_layout.
 961         (show_source_disasm_command, show_data)
 962         (show_source_or_disasm_and_command): Don't set current_layout.
 963
 964 2019-11-12  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
 967
 968 2019-11-12  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-win.c (resize_message): New global.
 971         (show_tui_resize_message): New function.
 972         (tui_async_resize_screen): Print message if requested.
 973         (_initialize_tui_win): Add tui-resize-message setting.
 974         * NEWS: Add entry for new commands.
 975
 976 2019-11-11  Tom Tromey  <tom@tromey.com>
 977
 978         * tui/tui.c (tui_initialize_readline): Add new bindable readline
 979         functions.
 980
 981 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
 982
 983         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
 984
 985 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 986
 987         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
 988         function.
 989         * python/python-internal.h (gdbpy_lookup_static_symbols):
 990         Declare new function.
 991         * python/python.c (python_GdbMethods): Add
 992         gdb.lookup_static_symbols method.
 993         * NEWS: Mention gdb.lookup_static_symbols.
 994
 995 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 996
 997         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
 998         static block of current object file first.  Also fix typo in
 999         header comment.
1000
1001 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1002
1003         * stack.c (set_last_displayed_sal): Delete.
1004         (last_displayed_sal_valid): Delete.
1005         (last_displayed_pspace): Delete.
1006         (last_displayed_addr): Delete.
1007         (last_displayed_symtab): Delete.
1008         (last_displayed_line): Delete.
1009         (class last_displayed_symtab_info_type): New.
1010         (last_displayed_symtab_info): New static global variable.
1011         (print_frame_info): Call methods on last_displayed_symtab_info.
1012         (clear_last_displayed_sal): Update header comment, and make use of
1013         last_displayed_symtab_info.
1014         (last_displayed_sal_is_valid): Likewise.
1015         (get_last_displayed_pspace): Likewise.
1016         (get_last_displayed_addr): Likewise.
1017         (get_last_displayed_symtab): Likewise.
1018         (get_last_displayed_line): Likewise.
1019         (get_last_displayed_sal): Likewise.
1020         * stack.h (clear_last_displayed_sal): Update header comment.
1021         (last_displayed_sal_is_valid): Likewise.
1022         (get_last_displayed_pspace): Likewise.
1023         (get_last_displayed_addr): Likewise.
1024         (get_last_displayed_symtab): Likewise.
1025         (get_last_displayed_line): Likewise.
1026         (get_last_displayed_sal): Likewise.
1027
1028 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1029
1030         * stack.c (frame_show_address): Convert return type to bool.
1031         * stack.h (frame_show_address): Likewise, and update header
1032         comment.
1033
1034 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1035
1036         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1037         * unittests/vec-utils-selftests.c: New file.
1038         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1039
1040 2019-11-10  Tom Tromey  <tom@tromey.com>
1041
1042         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1043         (tui_highlight_win): Likewise.
1044         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1045         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1046         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1047         Don't set can_highlight.
1048
1049 2019-11-10  Tom Tromey  <tom@tromey.com>
1050
1051         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1052         Remove unused declaration.
1053
1054 2019-11-08  Tom Tromey  <tromey@adacore.com>
1055
1056         * top.c (read_command_file): Update.
1057         (command_line_input): Make return type const.
1058         * python/py-gdb-readline.c: Update.
1059         * linespec.c (decode_line_2): Update.
1060         * defs.h (command_line_input): Make return type const.
1061         * cli/cli-script.c (read_next_line): Make return type const.
1062         * ada-lang.c (get_selections): Update.
1063
1064 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1065
1066         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1067         * mi/mi-main.c (output_cores): Likewise.
1068         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1069         (linux_xfer_osdata_modules): Likewise.
1070         * remote.c (register_remote_support_xml): Likewise.
1071         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1072         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1073
1074 2019-11-06  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-interp.c: Don't include readline.h.
1077         * tui/tui-hooks.c: Don't include readline.h.
1078         * symmisc.c: Include tilde.h, not readline.h.
1079         * symfile.c: Include tilde.h, not readline.h.
1080         * source.c: Include tilde.h, not readline.h.
1081         * solib.c: Include tilde.h, not readline.h.
1082         * psymtab.c: Include tilde.h, not readline.h.
1083         * exec.c: Include tilde.h, not readline.h.
1084         * corelow.c: Include tilde.h, not readline.h.
1085         * cli/cli-dump.c: Include tilde.h, not readline.h.
1086         * cli/cli-cmds.c: Don't include readline.h.
1087
1088 2019-11-05  Tom Tromey  <tom@tromey.com>
1089
1090         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1091         (tui_disassemble): Set addr_size.
1092         (tui_disasm_window::set_contents): Use addr_size.
1093
1094 2019-11-05  Tom Tromey  <tom@tromey.com>
1095
1096         * rust-lang.c (rust_language_defn): Update.
1097         * python/py-value.c (valpy_string): Call c_get_string.
1098         * p-lang.c (pascal_language_defn): Update.
1099         * opencl-lang.c (opencl_language_defn): Update.
1100         * objc-lang.c (objc_language_defn): Update.
1101         * m2-lang.c (m2_language_defn): Update.
1102         * language.c (unknown_language_defn, auto_language_defn): Update.
1103         (default_get_string): Remove.
1104         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1105         * go-lang.c (go_language_defn): Update.
1106         * f-lang.c (f_language_defn): Update.
1107         * d-lang.c (d_language_defn): Update.
1108         * c-lang.c (c_language_defn, cplus_language_defn)
1109         (asm_language_defn, minimal_language_defn): Update.
1110         * ada-lang.c (ada_language_defn): Update.
1111         * language.h (struct language_defn) <la_get_string>: Remove.
1112         (LA_GET_STRING): Remove.
1113         (default_get_string): Don't declare.
1114
1115 2019-11-05  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui-source.h (struct tui_source_window): Inline
1118         constructor.  Remove destructor.
1119         <style_changed, m_observable>: Move to superclass.
1120         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1121         (struct tui_source_window_base): Move private members to end.
1122         <style_changed, m_observable>: Move from tui_source_window.
1123         * tui/tui-winsource.c (tui_copy_source_line): Move from
1124         tui-source.c.  Rename from copy_source_line.  Add special handling
1125         for negative line number.
1126         (tui_source_window_base::style_changed): Move from
1127         tui_source_window.
1128         (tui_source_window_base): Register observer.
1129         (~tui_source_window_base): New.
1130         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1131         rename.
1132         (tui_source_window::set_contents): Use tui_copy_source_line.
1133         (tui_source_window::tui_source_window): Move to tui-source.h.
1134         (tui_source_window::~tui_source_window): Remove.
1135         (tui_source_window::style_changed): Move to superclass.
1136         * tui/tui-disasm.c (tui_disassemble): Create string file with
1137         styling, when possible.  Add "addr_size" parameter.
1138         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1139         Don't compute maximum size.
1140         (len_without_escapes): New function
1141
1142 2019-11-05  Tom Tromey  <tom@tromey.com>
1143
1144         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1145         std::string.
1146         * tui/tui-winsource.c (tui_show_source_line): Update.
1147         * tui/tui-source.c (tui_source_window::set_contents): Update.
1148         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1149
1150 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1151
1152         * symtab.h (gdb_static_assert): Put && operator at the beginning
1153         of the line instead of the end.
1154
1155 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1156
1157         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1158         and sizeof (symbol).
1159         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1160
1161 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1162
1163         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1164         * configure.host: Mark *-*-solaris2.10* obsolete.
1165         * configure.tgt: Mark Solaris < 11 obsolete.
1166         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1167         Update target triplet.
1168
1169 2019-11-01  Tom Tromey  <tromey@adacore.com>
1170
1171         * utils.c (print_sys_errmsg): Simplify.
1172
1173 2019-11-01  Tom Tromey  <tromey@adacore.com>
1174
1175         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1176
1177 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1178
1179         * configure: Regenerate.
1180         * configure.ac: Remove check for strerror_r.
1181         * gdbsupport/common.m4: Check for strerror_r.
1182
1183 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1184
1185         PR gdb/25124
1186
1187         * arm-tdep.c (arm_per_objfile): Rename to ...
1188         (arm_per_bfd): ... this.
1189         (arm_objfile_data_key): Rename to ...
1190         (arm_bfd_data_key): ... this.
1191         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1192         data.
1193         (arm_record_special_symbol): Likewise.
1194
1195 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1196
1197         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1198         end.
1199         * c-typeprint.c (c_print_typedef): Likewise.
1200         * f-typeprint.c (f_print_typedef): Likewise.
1201         * m2-typeprint.c (m2_print_typedef): Likewise.
1202         * p-typeprint.c (pascal_print_typedef): Likewise.
1203         * rust-lang.c (rust_print_typedef): Likewise.
1204         * symtab.c (print_symbol_info): Print a newline after calling
1205         typedef_print.
1206
1207 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1208
1209         * symtab.c (info_module_cmdlist): New variable.
1210         (info_module_command): New function.
1211         (search_module_symbols): New function.
1212         (info_module_subcommand): New function.
1213         (struct info_modules_var_func_options): New struct.
1214         (info_modules_var_func_options_defs): New variable.
1215         (make_info_modules_var_func_options_def_group): New function.
1216         (info_module_functions_command): New function.
1217         (info_module_variables_command): New function.
1218         (info_module_var_func_command_completer): New function.
1219         (_initialize_symtab): Register new 'info module functions' and
1220         'info module variables' commands.
1221         * symtab.h (typedef symbol_search_in_module): New typedef.
1222         (search_module_symbols): Declare new function.
1223         * NEWS: Mention new commands.
1224
1225 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1226
1227         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1228         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1229         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1230         MODULES_DOMAIN.
1231         (scan_partial_symbols): Only create partial module symbols for non
1232         declarations.
1233         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1234         and MODULES_DOMAIN.
1235         * symtab.c (search_domain_name): Likewise.
1236         (search_symbols): Likewise.
1237         (print_symbol_info): Likewise.
1238         (symtab_symbol_info): Likewise.
1239         (info_modules_command): New function.
1240         (_initialize_symtab): Register 'info modules' command.
1241         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1242         * NEWS: Mention new 'info modules' command.
1243
1244 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1245
1246         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1247         and $_gdb_maint_setting_str.
1248
1249 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1250
1251         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1252         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1253         (str_value_from_setting, gdb_setting_str_internal_fn)
1254         (gdb_maint_setting_str_internal_fn): New functions.
1255         (_initialize_cli_cmds): Define the new convenience functions.
1256         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1257         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1258
1259 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1260
1261         * agent.c (set_can_use_agent): When the setting is turned on,
1262         look up agent symbols if we don't have them yet.
1263         (agent_new_objfile): Don't look up agent symbols when the agent
1264         setting is off.
1265
1266 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1267
1268         * config.in: Regenerate.
1269
1270 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1271
1272         * configure: Regenerate.
1273         * configure.ac: Check for strerror_r.
1274         * gdbsupport/common-utils.h (safe_strerror): Change return value
1275         to const char * and document that this function is now threadsafe.
1276         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1277         thread_local and call strerror_r, if available.
1278         * utils.c (perror_string): Update.
1279         (print_sys_errmsg): Update.
1280
1281 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1282
1283         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1284         objfile_key.
1285         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1286         objfile to fetch per-bfd data.
1287         (arm_find_exidx_entry): Likewise.
1288
1289 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1290
1291         * gdbsupport/agent.c (debug_agent): Change type to bool.
1292         (use_agent): Likewise.
1293         (all_agent_symbols_look_up): Likewise.
1294         (agent_loaded_p): Change return value to bool.
1295         (agent_look_up_symbols): Update.
1296         (agent_capability_check): Change return value to bool.
1297         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1298         (debug_agent): Change type to bool.
1299         (use_agent): Likewise.
1300         (agent_capability_check): Change return value to bool.
1301
1302 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1303
1304         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1305         (build_minimal_symbol_hash_tables): Code to clear the table moved
1306         to clear_minimal_symbol_hash_tables.
1307         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1308         when needed.
1309
1310 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1311
1312         * infcmd.c: Remove includes.
1313         * infrun.c: Remove includes.
1314
1315 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1316
1317         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1318         (grow_vect): Remove declaration.
1319         (ada_type_of_array): Remove declaration.
1320         (ada_update_initial_language): Remove declaration.
1321         (ada_fold_name): Remove declaration.
1322         (ada_fill_in_ada_prototype): Remove declaration.
1323         (user_select_syms): Remove declaration.
1324         (get_selections): Remove declaration.
1325         (ada_tag_type): Remove declaration.
1326         (ada_value_tag): Remove declaration.
1327         (ada_is_others_clause): Remove declaration.
1328         (ada_in_variant): Remove declaration.
1329         (ada_value_struct_elt): Remove declaration.
1330         (ada_attribute_name): Remove declaration.
1331         (ada_system_address_type): Remove declaration.
1332         * ada-lang.c (ada_watch_location_expression): Make static.
1333         (GROW_VECT): Move here from ada-lang.h.
1334         (grow_vect): Make static.
1335         (ada_update_initial_language): Make static.
1336         (ada_fold_name): Make static.
1337         (ada_type_of_array): Make static.
1338         (encoded_ordered_before): Move up.
1339         (sort_choices): Move up.
1340         (print_signatures): Move up.
1341         (ada_print_symbol_signature): Move up.
1342         (get_selections): Move up and make static.
1343         (user_select_syms): Move up and make static.
1344         (ada_value_struct_elt): Move up and make static.
1345         (ada_tag_type): Make static.
1346         (ada_value_tag): Make static.
1347         (ada_is_others_clause): Make static.
1348         (ada_in_variant): Make static.
1349         (ada_attribute_name): Make static.
1350
1351 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1352
1353         * ada-lang.c: Remove includes.
1354         * ada-typeprint.c: Remove includes.
1355         * ada-valprint.c: Remove includes.
1356
1357 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1358
1359         * addrmap.c: Add static assertions of type size, moved from
1360         _initialize_addrmap.
1361         (_initialize_addrmap): Remove.
1362
1363 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1364
1365         * coffread.c (record_minimal_symbol): Update.
1366         (process_coff_symbol): Update.
1367         * dbxread.c (read_dbx_symtab): Update.
1368         * dwarf2read.c (add_partial_symbol): Update.
1369         (fixup_go_packaging): Update.
1370         (load_partial_dies): Update.
1371         (new_symbol): Update.
1372         * elfread.c (record_minimal_symbol): Change signature to use
1373         gdb::string_view instead of name+len.
1374         (elf_symtab_read): Update.
1375         (elf_rel_plt_read): Update.
1376         * mdebugread.c (parse_partial_symbols): Update.
1377         (handle_psymbol_enumerators): Update.
1378         (new_symbol): Update.
1379         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1380         to use gdb::string_view instead of name+len.
1381         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1382         * psympriv.h (add_psymbol_to_list): Likewise.
1383         * psymtab.c (add_psymbol_to_bcache): Likewise.
1384         (add_psymbol_to_list): Likewise.
1385         * stabsread.c (define_symbol): Update.
1386         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1387         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1388         (symbol_set_names): Likewise.
1389         * xcoffread.c (scan_xcoff_symtab): Update.
1390
1391 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1392
1393         * symtab.h (symbol_set_names): Document that copy_name must be
1394         set to true for non-nullterminated strings.
1395         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1396         linkage_name if the entry was not found and we need to demangle.
1397
1398 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1399
1400         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1401         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1402         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1403         * gdbsupport/gdb_binary_search.h: New file.
1404
1405 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1406
1407         * NEWS: Mention new --with-system-gdbinit-dir option.
1408         * config.in: Regenerate.
1409         * configure: Regenerate.
1410         * configure.ac: Add new option --with-system-gdbinit-dir.
1411         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1412         for a ".gdb" suffix.
1413         * main.c (get_init_files): Change system_gdbinit argument to
1414         a vector and return the files in SYSTEM_GDBINIT_DIR in
1415         addition to SYSTEM_GDBINIT.
1416         (captured_main_1): Update.
1417         (print_gdb_help): Update.
1418         * top.c (print_gdb_configuration): Also print the value of
1419         SYSTEM_GDBINIT_DIR.
1420
1421 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1422
1423         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1424         that takes gdb::string_view arguments.
1425
1426 2019-10-26  Tom de Vries  <tdevries@suse.de>
1427
1428         * aarch64-linux-tdep.c: Fix typos in comments.
1429         * aarch64-tdep.c: Same.
1430         * ada-lang.c: Same.
1431         * amd64-nat.c: Same.
1432         * arc-tdep.c: Same.
1433         * arch/aarch64-insn.c: Same.
1434         * block.c: Same.
1435         * breakpoint.h: Same.
1436         * btrace.h: Same.
1437         * c-varobj.c: Same.
1438         * cli/cli-decode.c: Same.
1439         * cli/cli-script.c: Same.
1440         * cli/cli-utils.h: Same.
1441         * coff-pe-read.c: Same.
1442         * coffread.c: Same.
1443         * compile/compile-cplus-symbols.c: Same.
1444         * compile/compile-object-run.c: Same.
1445         * completer.c: Same.
1446         * corelow.c: Same.
1447         * cp-support.c: Same.
1448         * demangle.c: Same.
1449         * dwarf-index-write.c: Same.
1450         * dwarf2-frame.c: Same.
1451         * dwarf2-frame.h: Same.
1452         * eval.c: Same.
1453         * frame-base.h: Same.
1454         * frame.h: Same.
1455         * gdbcmd.h: Same.
1456         * gdbtypes.h: Same.
1457         * gnu-nat.c: Same.
1458         * guile/scm-objfile.c: Same.
1459         * i386-tdep.c: Same.
1460         * i386-tdep.h: Same.
1461         * infcall.c: Same.
1462         * infcall.h: Same.
1463         * linux-nat.c: Same.
1464         * m68k-tdep.c: Same.
1465         * macroexp.c: Same.
1466         * memattr.c: Same.
1467         * mi/mi-cmd-disas.c: Same.
1468         * mi/mi-getopt.h: Same.
1469         * mi/mi-main.c: Same.
1470         * minsyms.c: Same.
1471         * nat/aarch64-sve-linux-sigcontext.h: Same.
1472         * objfiles.h: Same.
1473         * ppc-linux-nat.c: Same.
1474         * ppc-linux-tdep.c: Same.
1475         * ppc-tdep.h: Same.
1476         * progspace.h: Same.
1477         * prologue-value.h: Same.
1478         * python/py-evtregistry.c: Same.
1479         * python/py-instruction.h: Same.
1480         * record-btrace.c: Same.
1481         * record-full.c: Same.
1482         * remote.c: Same.
1483         * rs6000-tdep.c: Same.
1484         * ser-tcp.c: Same.
1485         * sol-thread.c: Same.
1486         * sparc-sol2-tdep.c: Same.
1487         * sparc64-tdep.c: Same.
1488         * stabsread.c: Same.
1489         * symfile.c: Same.
1490         * symtab.h: Same.
1491         * target.c: Same.
1492         * tracepoint.c: Same.
1493         * tui/tui-data.h: Same.
1494         * tui/tui-io.c: Same.
1495         * tui/tui-win.c: Same.
1496         * tui/tui.c: Same.
1497         * unittests/rsp-low-selftests.c: Same.
1498         * user-regs.h: Same.
1499         * utils.c: Same.
1500         * utils.h: Same.
1501         * valarith.c: Same.
1502         * valops.c: Same.
1503         * valprint.c: Same.
1504         * valprint.h: Same.
1505         * value.c: Same.
1506         * value.h: Same.
1507         * varobj.c: Same.
1508         * x86-nat.h: Same.
1509         * xtensa-tdep.c: Same.
1510
1511 2019-10-25  Ali Tamur <tamur@google.com>
1512
1513         * charset.c (find_charset_names): Reflect API change.
1514
1515 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1516
1517         * symtab.c (struct demangled_name_entry): Change demangled name
1518         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1519         part of the struct anymore.
1520         (symbol_set_names): No longer obstack allocate + copy the demangled
1521         name, just store the allocated name from bfd.
1522
1523 2019-10-25  Tom Tromey  <tromey@adacore.com>
1524
1525         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1526         (bsearch_cie_cmp, add_cie): Remove.
1527         (find_cie): Reimplement.
1528         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1529         (dwarf2_build_frame_info): Update.
1530
1531 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1532
1533         PR gdb/25126
1534         * symfile.c (reread_symbols): Call forget_cached_source_info to
1535         clear the stale source cache.
1536
1537 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1538
1539         * configure: Regenerate.
1540         * configure.ac: Remove code that sets python_has_threads.
1541
1542 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1543
1544         * config.in: Regenerate.
1545         * configure: Regenerate.
1546         * configure.ac: Remove the code that uses sed to get the python
1547         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1548
1549 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1550
1551         * python/py-progspace.c (pspy_block_for_pc): Return None for all
1552         error paths.
1553
1554 2019-10-23  Tom Tromey  <tom@tromey.com>
1555
1556         * arc-tdep.c: Remove ".." from include.
1557         * frv-tdep.c: Remove ".." from include.
1558         * lm32-tdep.c: Remove ".." from include.
1559         * microblaze-tdep.c: Remove ".." from include.
1560         * or1k-tdep.h: Remove ".." from include.
1561         * s12z-tdep.c: Remove ".." from include.
1562         * Makefile.in (OPCODES_CFLAGS): Add comment.
1563         (TOP_CFLAGS): New variable.
1564         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1565
1566 2019-10-23  Tom Tromey  <tom@tromey.com>
1567
1568         * Makefile.in (READLINE_DIR): Update.
1569
1570 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1571
1572         * infcall.c (call_function_by_hand_dummy): Fix the function
1573         comment.  And extract out a code section into...
1574         (reserve_stack_space): ...this new function.
1575
1576 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1577
1578         * infcall.c (value_arg_coerce): Remove an unused parameter.
1579         (call_function_by_hand_dummy): Update the call to
1580         'value_arg_coerce'.
1581
1582 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1583
1584         * infcall.c (call_function_by_hand_dummy): Refactor.
1585
1586 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1587
1588         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1589
1590 2019-10-23  Tom Tromey  <tom@tromey.com>
1591
1592         * configure: Rebuild.
1593         * configure.ac: Don't check for sigprocmask.
1594         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1595
1596 2019-10-23  Tom Tromey  <tom@tromey.com>
1597
1598         * configure: Rebuild.
1599         * acinclude.m4: Use m4_include, not sinclude.
1600
1601 2019-10-23  Tom de Vries  <tdevries@suse.de>
1602
1603         PR breakpoints/24687
1604         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1605
1606 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1607
1608         * symtab.c (struct demangled_name_entry) <language>: Change from
1609         bitfield to regular variable.
1610
1611 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1612
1613         * symtab.c (struct demangled_name_entry): Add a constructor.
1614         (free_demangled_name_entry): New function to call the destructor
1615         for demangled_name_entry.
1616         (create_demangled_names_hash): Pass free_demangled_name_entry to
1617         htab_create_alloc.
1618         (symbol_set_names): Call placement new for demangled_name_entry.
1619         * utils.c: No longer include xxhash.h here, now that fast_hash
1620         is inlined in the header.
1621         * utils.h: Instead, include it here.
1622
1623 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1624
1625         * Makefile.in: Link with libxxhash.
1626         * config.in: Regenerate.
1627         * configure: Regenerate.
1628         * configure.ac: Search for libxxhash.
1629         * utils.c (fast_hash): Use xxhash if present.
1630
1631 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1632
1633         * utils.h (fast_hash): New function.
1634         * symtab.c (hash_demangled_name_entry): Call new function
1635         fast_hash.
1636
1637 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1638
1639         * symtab.c (struct demangled_name_entry): Change type of mangled
1640         to gdb::string_view. Also adds a constructor that takes the
1641         mangled name.
1642         (hash_demangled_name_entry): Update.
1643         (eq_demangled_name_entry): Update.
1644         (free_demangled_name_entry): New function to call the destructor
1645         now that this is not a POD anymore.
1646         (create_demangled_names_hash): Pass free_demangled_name_entry to
1647         htab_create_alloc.
1648         (symbol_set_names): Update.
1649
1650 2019-10-21  Ali Tamur  <tamu@google.com>
1651
1652         * dwarf2read.c (dir_index): Change type.
1653         (file_name_index): Likewise.
1654         (line_header::include_dir_at): Change comment and implementation on
1655         whether it is DWARF 5.
1656         (line_header::is_valid_file_index): New function.
1657         (line_header::file_name_at): Change comment and implementation on
1658         whether it is DWARF 5.
1659         (line_header::file_names): Change to private field renamed as
1660         m_file_names and introduce a new accessor method.
1661         (line_header::file_names_size): New method.
1662         (line_header::include_dirs): Change to private field and rename as
1663         m_include_dirs.
1664         (dw2_get_file_names_reader): Define local var at a smaller scope and
1665         reflect API change.
1666         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1667         (process_structure_scope): Likewise.
1668         (line_header::add_include_dir): Change message and reflect renaming.
1669         (line_header::add_file_name): Likewise.
1670         (read_formatted_entries): Handle DW_FORM_data16.
1671         (dwarf_decode_line_header): Fix line header length calculation.
1672         (psymtab_include_file_name): Change comment and API.
1673         (lnp_state_machine::m_file): Update comment and reflect type change.
1674         (lnp_state_machine::record_line): Reflect type change.
1675         (dwarf_decode_lines): Reflect API change.
1676         (file_file_name): Likewise.
1677         (file_full_name): Likewise.
1678
1679 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1680
1681         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1682
1683 2019-10-21  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1686
1687 2019-10-21  Tom Tromey  <tom@tromey.com>
1688
1689         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
1690         NM_H.   Use AC_CONFIG_LINKS.
1691         * configure: Rebuild.
1692         * Makefile.in (NM_H): New variable.
1693         (generated_files): Add NM_H.  Remove gcore.
1694         (nm.h, stamp-nmh): New targets.
1695
1696 2019-10-20  Tom Tromey  <tom@tromey.com>
1697
1698         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1699         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
1700         obsolete comment.
1701         (put_objfile_before): Now static.
1702
1703 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
1704
1705         * gdbsupport/common-utils.h (startswith): Change return type to
1706         bool.
1707
1708 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
1709
1710         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1711         * breakpoint.c (bp_locations_compare): Rename to...
1712         (bp_location_is_less_than): ...this, and change to std::sort semantics.
1713         (update_global_location_list): Use std::sort instead of qsort.
1714         * buildsym.c (compare_line_numbers): Rename to...
1715         (lte_is_less_than): ...this, and change to std::sort semantics.
1716         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1717         instead of qsort.
1718         * disasm.c (compare_lines): Rename to...
1719         (line_is_less_than): ...this, and change to std::sort semantics.
1720         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1721         of qsort.
1722         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1723         (fde_is_less_than): ...this, and change to std::sort semantics.
1724         (dwarf2_build_frame_info): Call std::sort instead of qsort.
1725         * mdebugread.c (compare_blocks):
1726         (block_is_less_than): ...this, and change to std::sort semantics.
1727         (sort_blocks): Call std::sort instead of qsort.
1728         * objfiles.c (qsort_cmp): Rename to...
1729         (sort_cmp): ...this, and change to std::sort semantics.
1730         (update_section_map): Call std::sort instead of qsort.
1731         * remote.c (compare_pnums): Remove.
1732         (map_regcache_remote_table): Call std::sort instead of qsort.
1733         * utils.c (compare_positive_ints): Remove.
1734         * utils.h (compare_positive_ints): Remove.
1735         * xcoffread.c (compare_lte): Remove.
1736         (arrange_linetable): Call std::sort instead of qsort.
1737
1738 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
1739
1740         * symfile.c (init_entry_point_info): Fix typo.
1741         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1742
1743 2019-10-18  Tom de Vries  <tdevries@suse.de>
1744
1745         * aarch64-tdep.c: Fix typos in comments.
1746         * ada-lang.c: Same.
1747         * ada-tasks.c: Same.
1748         * alpha-tdep.c: Same.
1749         * alpha-tdep.h: Same.
1750         * amd64-nat.c: Same.
1751         * amd64-windows-tdep.c: Same.
1752         * arc-tdep.c: Same.
1753         * arc-tdep.h: Same.
1754         * arch-utils.c: Same.
1755         * arm-nbsd-tdep.c: Same.
1756         * arm-tdep.c: Same.
1757         * ax-gdb.c: Same.
1758         * blockframe.c: Same.
1759         * btrace.c: Same.
1760         * c-varobj.c: Same.
1761         * coff-pe-read.c: Same.
1762         * coffread.c: Same.
1763         * cris-tdep.c: Same.
1764         * darwin-nat.c: Same.
1765         * dbxread.c: Same.
1766         * dcache.c: Same.
1767         * disasm.c: Same.
1768         * dtrace-probe.c: Same.
1769         * dwarf-index-write.c: Same.
1770         * dwarf2-frame-tailcall.c: Same.
1771         * dwarf2-frame.c: Same.
1772         * dwarf2read.c: Same.
1773         * eval.c: Same.
1774         * exceptions.c: Same.
1775         * fbsd-tdep.c: Same.
1776         * findvar.c: Same.
1777         * frame.c: Same.
1778         * frv-tdep.c: Same.
1779         * gnu-v3-abi.c: Same.
1780         * go32-nat.c: Same.
1781         * h8300-tdep.c: Same.
1782         * hppa-tdep.c: Same.
1783         * i386-linux-tdep.c: Same.
1784         * i386-tdep.c: Same.
1785         * ia64-libunwind-tdep.c: Same.
1786         * ia64-tdep.c: Same.
1787         * infcmd.c: Same.
1788         * infrun.c: Same.
1789         * linespec.c: Same.
1790         * linux-nat.c: Same.
1791         * linux-thread-db.c: Same.
1792         * machoread.c: Same.
1793         * mdebugread.c: Same.
1794         * mep-tdep.c: Same.
1795         * mn10300-tdep.c: Same.
1796         * namespace.c: Same.
1797         * objfiles.c: Same.
1798         * opencl-lang.c: Same.
1799         * or1k-tdep.c: Same.
1800         * osabi.c: Same.
1801         * ppc-linux-nat.c: Same.
1802         * ppc-linux-tdep.c: Same.
1803         * ppc-sysv-tdep.c: Same.
1804         * printcmd.c: Same.
1805         * procfs.c: Same.
1806         * record-btrace.c: Same.
1807         * record-full.c: Same.
1808         * remote-fileio.c: Same.
1809         * remote.c: Same.
1810         * rs6000-tdep.c: Same.
1811         * s12z-tdep.c: Same.
1812         * score-tdep.c: Same.
1813         * ser-base.c: Same.
1814         * ser-go32.c: Same.
1815         * skip.c: Same.
1816         * sol-thread.c: Same.
1817         * solib-svr4.c: Same.
1818         * solib.c: Same.
1819         * source.c: Same.
1820         * sparc-nat.c: Same.
1821         * sparc-sol2-tdep.c: Same.
1822         * sparc-tdep.c: Same.
1823         * sparc64-tdep.c: Same.
1824         * stabsread.c: Same.
1825         * stack.c: Same.
1826         * symfile.c: Same.
1827         * symtab.c: Same.
1828         * target-descriptions.c: Same.
1829         * target-float.c: Same.
1830         * thread.c: Same.
1831         * utils.c: Same.
1832         * valops.c: Same.
1833         * valprint.c: Same.
1834         * value.c: Same.
1835         * varobj.c: Same.
1836         * windows-nat.c: Same.
1837         * xcoffread.c: Same.
1838         * xstormy16-tdep.c: Same.
1839         * xtensa-tdep.c: Same.
1840
1841 2019-10-17  Tom Tromey  <tromey@adacore.com>
1842
1843         * configure: Rebuild.
1844         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
1845         in AC_CONFIG_FILES invocation.
1846         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
1847         new-style config.status invocation.
1848
1849 2019-10-17  Tom de Vries  <tdevries@suse.de>
1850
1851         * arm-nbsd-nat.c: Fix typos in comments.
1852         * arm-tdep.c: Same.
1853         * darwin-nat-info.c: Same.
1854         * dwarf2read.c: Same.
1855         * elfread.c: Same.
1856         * event-top.c: Same.
1857         * findvar.c: Same.
1858         * gdbtypes.c: Same.
1859         * hppa-tdep.c: Same.
1860         * i386-tdep.c: Same.
1861         * jit.c: Same.
1862         * main.c: Same.
1863         * mdebugread.c: Same.
1864         * moxie-tdep.c: Same.
1865         * nto-procfs.c: Same.
1866         * osabi.c: Same.
1867         * ppc-linux-tdep.c: Same.
1868         * remote.c: Same.
1869         * riscv-tdep.c: Same.
1870         * s390-tdep.c: Same.
1871         * sh-tdep.c: Same.
1872         * sparc-linux-tdep.c: Same.
1873         * sparc-nat.c: Same.
1874         * stack.c: Same.
1875         * target-descriptions.c: Same.
1876         * top.c: Same.
1877         * varobj.c: Same.
1878
1879 2019-10-16  Tom Tromey  <tom@tromey.com>
1880
1881         * objfiles.h (struct objfile) <original_name>: Now const.
1882
1883 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1884
1885         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1886         pass on to sigsetjmp's second argument.
1887         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1888
1889 2019-10-16  Keith Seitz  <keiths@redhat.com>
1890
1891         PR gdb/23567
1892         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1893         sections whose size is greater than the file size.
1894
1895 2019-10-16  Jim Wilson  <jimw@sifive.com>
1896
1897         * riscv-tdep.c (riscv_gcc_target_options): New.
1898         (riscv_gnu_triplet_regexp): New.
1899         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1900         set_gdbarch_gnu_triplet_regexp.
1901
1902 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
1903
1904         * Makefile.in: Add xml-builtin.h.
1905         * features/feature_to_c.sh: Add an include for xml-builtin.h
1906         to ensure that the compiler checks that the types match.
1907         * xml-builtin.h: New file.
1908         * xml-support.c (fetch_xml_builtin): Add missing const.
1909         * xml-support.h: Remove declaration of xml_builtins.
1910
1911 2019-10-16  Tom de Vries  <tdevries@suse.de>
1912
1913         PR tdep/25096
1914         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1915         (amd64_classify_aggregate): ... here.
1916         (amd64_classify_aggregate_field): Handled fiels of nested structs
1917         recursively.
1918
1919 2019-10-16  Tom de Vries  <tdevries@suse.de>
1920
1921         PR tdep/24104
1922         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1923         that handles 'theclass'.
1924
1925 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1926
1927         * linespec.c (decode_digits_ordinary): Update comment.
1928         * make-target-delegates: No longer need to handle VEC case.
1929         * memrange.c (normalize_mem_ranges): Update comment.
1930         * namespace.c (add_using_directive): Update comment.
1931         * objc-lang.c (uniquify_strings): Update comment.
1932         * ppc-linux-nat.c (struct thread_points): Update comment.
1933         * probe.h (find_probes_in_objfile): Update comment.
1934         * target.h (enum flash_preserve_mode): Update comment.
1935         * varobj.c (varobj_restrict_range): Update comment.
1936         * varobj.h (varobj_list_children): Update comment.
1937
1938 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1939
1940         * Makefile.in: Remove references to vec.h and vec.c.
1941         * aarch64-tdep.c: No longer include vec.h.
1942         * ada-lang.c: Likewise.
1943         * ada-lang.h: Likewise.
1944         * arm-tdep.c: Likewise.
1945         * ax.h: Likewise.
1946         * breakpoint.h: Likewise.
1947         * charset.c: Likewise.
1948         * cp-support.h: Likewise.
1949         * dtrace-probe.c: Likewise.
1950         * dwarf2read.c: Likewise.
1951         * extension.h: Likewise.
1952         * gdb_bfd.c: Likewise.
1953         * gdbsupport/gdb_vecs.h: Likewise.
1954         * gdbsupport/vec.c: Remove.
1955         * gdbsupport/vec.h: Remove.
1956         * gdbthread.h: Likewise.
1957         * guile/scm-type.c: Likewise.
1958         * inline-frame.c: Likewise.
1959         * machoread.c: Likewise.
1960         * memattr.c: Likewise.
1961         * memrange.h: Likewise.
1962         * namespace.h: Likewise.
1963         * nat/linux-btrace.h: Likewise.
1964         * osdata.c: Likewise.
1965         * parser-defs.h: Likewise.
1966         * progspace.h: Likewise.
1967         * python/py-type.c: Likewise.
1968         * record-btrace.c: Likewise.
1969         * rust-exp.y: Likewise.
1970         * solib-target.c: Likewise.
1971         * stap-probe.c: Likewise.
1972         * target-descriptions.c: Likewise.
1973         * target-memory.c: Likewise.
1974         * target.h: Likewise.
1975         * varobj.c: Likewise.
1976         * varobj.h: Likewise.
1977         * xml-support.h: Likewise.
1978
1979 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1980
1981         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1982         Update for new std::vector based implementation.
1983         (process_psymtab_comp_unit_reader): Likewise.
1984         (scan_partial_symbols): Likewise.
1985         (recursively_compute_inclusions): Likewise.
1986         (compute_compunit_symtab_includes): Likewise.
1987         (process_imported_unit_die): Likewise.
1988         (queue_and_load_dwo_tu): Likewise.
1989         (follow_die_sig_1): Likewise.
1990         * gdb/dwarf2read.h: Remove DEF_VEC_P.
1991         (typedef dwarf2_per_cu_ptr): Remove.
1992         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1993         function.
1994         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1995         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1996         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1997         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1998         std::vector.
1999
2000 2019-10-15  Tom Tromey  <tromey@adacore.com>
2001
2002         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2003         TID.
2004
2005 2019-10-15  Tom Tromey  <tromey@adacore.com>
2006
2007         * windows-nat.c (windows_nat_target::fetch_registers)
2008         (windows_nat_target::store_registers): Rename "pid" to "tid".
2009
2010 2019-10-15  Tom Tromey  <tromey@adacore.com>
2011
2012         * gdbarch.h, gdbarch.c: Rebuild.
2013         * gdbarch.sh (gcc_target_options): Change return type to
2014         std::string.
2015         * compile/compile.c (get_args): Update.
2016         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2017         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2018         std::string.
2019         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2020         std::string.
2021         * arch-utils.c (default_gcc_target_options): Return std::string.
2022         * arch-utils.h (default_gcc_target_options): Return std::string.
2023         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2024
2025 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2026
2027         * breakpoint.c (breakpoint_chain): Make static.
2028         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2029         of accessing breakpoint_chain.
2030
2031 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2032
2033         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2034         to a gdb::function_view and return value to bool.
2035         * breakpoint.h (iterate_over_breakpoints): Likewise.
2036         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2037         (pop_dummy_frame): Update.
2038         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2039         (gdbscm_breakpoints): Update.
2040         * python/py-breakpoint.c (build_bp_list): Update.
2041         (gdbpy_breakpoints): Update.
2042         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2043         Update.
2044         (bpfinishpy_handle_stop): Update.
2045         (bpfinishpy_handle_exit): Update.
2046         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2047         (svr4_update_solib_event_breakpoints): Update.
2048
2049 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2050
2051         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2052         when unwrapping single-field structs.
2053
2054 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2055
2056         * dwarf2read.c: Remove includes.
2057
2058 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2059
2060         * ui-out.c (ui_out::call_do_message): Silence
2061         -Wformat-nonliteral warning.
2062
2063 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2064
2065         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2066         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2067         include: readline/tilde.h.
2068
2069 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2070
2071         * remote.c (remote_target::get_trace_status): Remove declaration of
2072         trace_regblock_size.
2073
2074 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2075
2076         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2077         (show_user): Remove declaration of cmdlist.
2078         * cli/cli-cmds.h (max_user_call_depth): Declare.
2079         * cli/cli-script.c (execute_user_command): Remove declaration
2080         of max_user_call_depth.
2081
2082 2019-10-11  Jim Wilson  <jimw@sifive.com>
2083
2084         * gdbsupport/print-utils.h (pulongest): Fix comment.
2085         (plongest): Likewise.
2086         (phex): Add missing comment, mention leading zeros.
2087         (phex_nz): Add mention of no leading zeros to comment.
2088
2089         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2090         plongest instead of unsigned long long cast.
2091
2092 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2093
2094         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2095         for external_editor_command and gdbtk_test.
2096
2097 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2098
2099         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2100         * varobj.c (varobjdebug): Move comment to...
2101         * varobj.h (varobjdebug): ...here, and declare.
2102
2103 2019-10-09  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2106         erase_data_content.
2107
2108 2019-10-09  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2111         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2112         * tui/tui-command.c (tui_cmd_window::resize)
2113         (tui_refresh_cmd_win): Update.
2114         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2115         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2116         * tui/tui-data.c (~tui_gen_win_info): Remove.
2117         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2118         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2119         (tui_redisplay_readline, tui_mld_flush)
2120         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2121         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2122         (tui_data_window::erase_data_content)
2123         (tui_data_item_window::rerender)
2124         (tui_data_item_window::refresh_window): Update.
2125         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2126         (box_win, tui_gen_win_info::make_window)
2127         (tui_gen_win_info::make_visible): Update.
2128         (tui_delete_win): Remove.
2129         * tui/tui-winsource.c
2130         (tui_source_window_base::do_erase_source_content): Update.
2131         (tui_show_source_line, tui_source_window_base::update_tab_width)
2132         (tui_source_window_base::update_exec_info): Update.
2133         * tui/tui-data.h (struct curses_deleter): New.
2134         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2135         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2136
2137 2019-10-09  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2140
2141 2019-10-09  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2144         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2145
2146 2019-10-09  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2149         window height directly.
2150         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2151         declare.
2152         * tui/tui-layout.c (tui_default_win_height): Remove.
2153         (tui_default_win_viewport_height): Remove.
2154
2155 2019-10-09  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui.h: Remove comments.
2158
2159 2019-10-09  Tom de Vries  <tdevries@suse.de>
2160
2161         * python/lib/gdb/printer/bound_registers.py: Use
2162         '^builtin_type_bound128' as regexp argument for
2163         add_builtin_pretty_printer.
2164
2165 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2166
2167         * guile/guile.c (guile_extension_script_ops): Remove forward
2168         declaration and mark as static.
2169         (guile_script_ops): Likewise.
2170         (extension_language_guile): Move further down in the file so
2171         it can reference the definitions for guile_{extension_,}script_ops.
2172
2173 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2174
2175         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2176         except SORTL, DFLTCC, and KDSA.
2177
2178 2019-10-08  Tom Tromey  <tromey@adacore.com>
2179
2180         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2181         (struct safe_symbol_file_add_args): Remove.
2182
2183 2019-10-08  Tom Tromey  <tromey@adacore.com>
2184
2185         * windows-nat.c: Don't include buildsym-legacy.h.
2186
2187 2019-10-08  Tom Tromey  <tromey@adacore.com>
2188
2189         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2190
2191 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2192
2193         * gdbtypes.c (overload_debug): Move comment to header.
2194         * gdbtypes.h (overload_debug): Declare.
2195         * valops.c: Remove declaration of overload_debug, instead
2196         include gdbtypes.h.
2197
2198 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2199
2200         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2201         through _().
2202         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2203         move comment...
2204         * language.h (lang_frame_mismatch_warn): ... here. Also add
2205         declaration.
2206         * top.c (lang_frame_mismatch_warn): Remove declaration.
2207         (check_frame_language_change): Pass lang_frame_mismatch_warn
2208         through _().
2209
2210 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2211
2212         * c-lang.h (vtbl_ptr_name): Declare.
2213         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2214         it from the header.
2215         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2216
2217 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2218
2219         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2220         gdb_static_assert.
2221
2222 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2223
2224         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2225         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2226         * ctfread.c: New file.
2227         * ctfread.h: New file.
2228         * elfread.c: Include ctfread.h.
2229         (struct elfinfo text_p): New member ctfsect.
2230         (elf_locate_sections): Mark CTF section.
2231         (elf_symfile_read): Call elfctf_build_psymtabs.
2232         * Makefile.in (LIBCTF): Add.
2233         (CLIBS): Use it.
2234         (CDEPS): Likewise.
2235         (DIST): Add ctfread.c.
2236
2237 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2238
2239         * ctfread.c (struct nextfield): Renamed to ...
2240         (struct ctf_nextfield): ... this.
2241         (struct field_info): Renamed to ...
2242         (strut ctf_field_info): ... this.
2243         (attach_fields_to_type): Update for renamed structures.
2244         (ctf_add_member_cb): Likewise.
2245         (ctf_add_enum_member_cb): Likewise.
2246         (process_struct_members): Likewise.
2247         (process_enum_type): Likewise.
2248
2249 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2250
2251         * tracectf.h: Rename, was ctf.h.
2252         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2253         * tracefile.c: Likewise.
2254         * tracepoint.c: Remove unused include ctf.h.
2255         * mi/mi-main.c: Likewise.
2256         * Makefile.in Replace ctf.c with tracectf.c.
2257
2258 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2259
2260         * version.in: Change version number to "9.0.50.DATE-git".
2261
2262 2019-10-03  Tom Tromey  <tom@tromey.com>
2263
2264         PR rust/24976:
2265         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2266
2267 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2268
2269         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2270         cp_search_name_hash.
2271         * NEWS: Add entry about nested function support.
2272
2273 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2274             Andrew Burgess  <andrew.burgess@embecosm.com>
2275
2276         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2277         for nested static variables when searchin VAR_DOMAIN.
2278         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2279         global scope, update comment.
2280         (add_partial_subprogram): Call add_partial_subprogram recursively
2281         for nested subroutines when processinng Fortran.
2282         (load_partial_dies): Process the child entities of a subprogram
2283         when processing Fortran.
2284         (partial_die_parent_scope): Handle building scope
2285         for Fortran nested functions.
2286         (process_die): Record that nested functions have a scope.
2287         (new_symbol): Always record Fortran subprograms on the global
2288         symbol list.
2289         (determine_prefix): How to build the prefix for Fortran
2290         subprograms.
2291
2292 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2293
2294         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2295         have just sent the thread a SIGSTOP and are waiting for it to
2296         arrive.
2297
2298 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2299
2300         * btrace.c (btrace_add_pc): Remove whitespace before the template
2301         parameter in 'std::vector <...>'.
2302         (parse_xml_btrace_block): Likewise.
2303         (btrace_maint_decode_pt): Likewise.
2304         (btrace_maint_update_packets): Likewise.
2305         (btrace_maint_print_packets): Likewise.
2306         * btrace.h (struct btrace_maint_info): Likewise.
2307         * dwarf2read.c (struct type_unit_group): Likewise.
2308         (build_type_psymtabs_reader): Likewise.
2309         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2310         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2311         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2312
2313 2019-10-03  Tom de Vries  <tdevries@suse.de>
2314
2315         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2316         the first line of the help text for set/show style metadata.
2317
2318 2019-10-02  Tom Tromey  <tromey@adacore.com>
2319
2320         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2321         * gdbsupport/common-inferior.c: New file.
2322         * infcmd.c (startup_with_shell): Don't define.
2323         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2324         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2325         * inferior.h (startup_with_shell): Don't declare.
2326
2327 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2328
2329         * gdbsupport/gdb_assert.h: Include errors.h.
2330         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2331
2332 2019-10-02  Tom Tromey  <tromey@adacore.com>
2333
2334         * NEWS: Add $_ada_exception entry.
2335         * ada-lang.c (struct ada_catchpoint): Add constructor.
2336         <m_kind>: New member.
2337         (allocate_location_exception, re_set_exception): Remove
2338         "ex" parameter.
2339         (should_stop_exception): Compute $_ada_exception.
2340         (check_status_exception, print_it_exception)
2341         (print_one_exception, print_mention_exception): Remove
2342         "ex" parameter.
2343         (allocate_location_catch_exception, re_set_catch_exception)
2344         (check_status_exception, print_it_catch_exception)
2345         (print_one_catch_exception, print_mention_catch_exception)
2346         (print_recreate_catch_exception)
2347         (allocate_location_catch_exception_unhandled)
2348         (re_set_catch_exception_unhandled)
2349         (check_status_exception, print_it_catch_exception_unhandled)
2350         (print_one_catch_exception_unhandled)
2351         (print_mention_catch_exception_unhandled)
2352         (print_recreate_catch_exception_unhandled)
2353         (allocate_location_catch_assert, re_set_catch_assert)
2354         (check_status_assert, print_it_catch_assert)
2355         (print_one_catch_assert, print_mention_catch_assert)
2356         (print_recreate_catch_assert)
2357         (allocate_location_catch_handlers, re_set_catch_handlers)
2358         (check_status_handlers, print_it_catch_handlers)
2359         (print_one_catch_handlers, print_mention_catch_handlers)
2360         (print_recreate_catch_handlers): Remove.
2361         (create_ada_exception_catchpoint): Update.
2362         (initialize_ada_catchpoint_ops): Update.
2363
2364 2019-10-02  Tom Tromey  <tromey@adacore.com>
2365
2366         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2367         (create_excep_cond_exprs): Simplify exception string computation.
2368         (ada_exception_catchpoint_cond_string): Likewise.
2369
2370 2019-10-02  Tom Tromey  <tromey@adacore.com>
2371
2372         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2373         * ada-lang.c (lesseq_defined_than): Handle
2374         LOC_STATIC.
2375         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2376         parameter.
2377         (dwarf2_has_info): Likewise.
2378         (new_symbol): Set maybe_copied on symbol when
2379         appropriate.
2380         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2381         parameter.
2382         <can_copy>: New member.
2383         * elfread.c (record_minimal_symbol): Set maybe_copied
2384         on symbol when appropriate.
2385         (elf_symfile_read): Update call to dwarf2_has_info.
2386         * minsyms.c (lookup_minimal_symbol_linkage): New
2387         function.
2388         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2389         * symtab.c (get_symbol_address, get_msymbol_address):
2390         New functions.
2391         * symtab.h (get_symbol_address, get_msymbol_address):
2392         Declare.
2393         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2394         maybe_copied.
2395         (struct symbol, struct minimal_symbol) <maybe_copied>:
2396         New member.
2397
2398 2019-10-02  Tom Tromey  <tromey@adacore.com>
2399
2400         * source.c (struct current_source_location): New.
2401         (current_source_key): New global.
2402         (current_source_symtab, current_source_line)
2403         (current_source_pspace): Remove.
2404         (get_source_location): New function.
2405         (get_current_source_symtab_and_line)
2406         (set_default_source_symtab_and_line)
2407         (set_current_source_symtab_and_line)
2408         (clear_current_source_symtab_and_line, select_source_symtab)
2409         (info_source_command, print_source_lines_base)
2410         (info_line_command, search_command_helper, _initialize_source):
2411         Update.
2412
2413 2019-10-02  Tom Tromey  <tromey@adacore.com>
2414
2415         * source.c (select_source_symtab): Don't call
2416         decode_line_with_current_source.
2417
2418 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2419
2420         * symtab.c (lookup_global_symbol): Search global block.
2421
2422 2019-10-02  Tom Tromey  <tromey@adacore.com>
2423
2424         * coffread.c (process_coff_symbol): Update.
2425         * dwarf2read.c (var_decode_location, new_symbol): Update.
2426         * mdebugread.c (parse_symbol): Update.
2427         * objfiles.c (relocate_one_symbol): Update.
2428         * stabsread.c (define_symbol, fix_common_block)
2429         (scan_file_globals): Update.
2430         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2431         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2432         * xcoffread.c (process_xcoff_symbol): Update.
2433
2434 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2435
2436         * MAINTAINERS: Update my email address.
2437
2438 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2439
2440         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2441         std::vector.
2442         (build_type_psymtabs_reader): Update for std::vector.
2443         (build_type_psymtab_dependencies): Likewise.
2444         * dwarf2read.h: Remove use of DEF_VEC_P.
2445         (typedef sig_type_ptr): Delete.
2446
2447 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2448
2449         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2450         to std::vector.
2451         (btrace_maint_decode_pt): Likewise, and move allocation of the
2452         vector outside of the loop.
2453         (btrace_maint_update_packets): Update to handle change from VEC to
2454         std::vector.
2455         (btrace_maint_print_packets): Likewise.
2456         (maint_info_btrace_cmd): Likewise.
2457         * btrace.h: Remove use of DEF_VEC_O.
2458         (typedef btrace_pt_packet_s): Delete.
2459         (struct btrace_maint_info) <packets>: Change fromm VEC to
2460         std::vector.
2461         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2462
2463 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2464
2465         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2466         make accesses into the vector constant references.
2467         (btrace_add_pc): Update for std::vector.
2468         (btrace_stitch_bts): Likewise.
2469         (parse_xml_btrace_block): Likewise.
2470         (btrace_maint_update_packets): Likewise.
2471         (btrace_maint_print_packets): Likewise.
2472         (maint_info_btrace_cmd): Likewise.
2473         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2474         std::vector.
2475         (btrace_data::empty): Likewise.
2476         (btrace_data_append): Likewise.
2477         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2478         (typedef btrace_block_s): Delete.
2479         (struct btrace_block): Add constructor.
2480         (struct btrace_data_bts) <blocks>: Change to std::vector.
2481         * nat/linux-btrace.c (perf_event_read_bts): Update for
2482         std::vector.
2483         (linux_read_bts): Likewise.
2484
2485 2019-10-01  Tom Tromey  <tom@tromey.com>
2486
2487         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2488
2489 2019-10-01  Tom Tromey  <tom@tromey.com>
2490
2491         * stack.c (print_frame, info_frame_command_core): Use
2492         styled_string.
2493         * linux-thread-db.c (try_thread_db_load_1)
2494         (try_thread_db_load_from_pdir_1): Use styled_string.
2495         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2496         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2497         (maybe_print_unsupported_script_warning)
2498         (maybe_print_script_not_found_warning): Use styled_string.
2499         * ada-lang.c (user_select_syms): Use styled_string.
2500
2501 2019-10-01  Tom Tromey  <tom@tromey.com>
2502
2503         * p-lang.c (pascal_printstr): Use metadata style.
2504         * value.c (show_convenience): Use metadata style.
2505         * valprint.c (valprint_check_validity, val_print_optimized_out)
2506         (val_print_not_saved, val_print_unavailable)
2507         (val_print_invalid_address, generic_val_print, val_print)
2508         (value_check_printable, val_print_array_elements): Use metadata
2509         style.
2510         * ui-out.h (class ui_out) <field_fmt>: New overload.
2511         <do_field_fmt>: Add style parameter.
2512         * ui-out.c (ui_out::field_fmt): New overload.
2513         * typeprint.c (type_print_unknown_return_type)
2514         (val_print_not_allocated, val_print_not_associated): Use metadata
2515         style.
2516         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2517         parameter.
2518         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2519         * tracepoint.c (tvariables_info_1): Use metadata style.
2520         * stack.c (print_frame_arg, print_frame_info, print_frame)
2521         (info_frame_command_core): Use metadata style.
2522         * skip.c (info_skip_command): Use metadata style.
2523         * rust-lang.c (rust_print_enum): Use metadata style.
2524         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2525         metadata style.
2526         * python/py-framefilter.c (py_print_single_arg): Use metadata
2527         style.
2528         * printcmd.c (do_one_display, print_variable_and_value): Use
2529         metadata style.
2530         * p-valprint.c (pascal_val_print)
2531         (pascal_object_print_value_fields): Use metadata style.
2532         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2533         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2534         parameter.
2535         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2536         * m2-valprint.c (m2_print_long_set): Use metadata style.
2537         * m2-typeprint.c (m2_print_type): Use metadata style.
2538         * infcmd.c (print_return_value_1): Use metadata style.
2539         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2540         * f-valprint.c (info_common_command_for_block): Use metadata
2541         style.
2542         * f-typeprint.c (f_type_print_base): Use metadata style.
2543         * expprint.c (print_subexp_standard): Use metadata style.
2544         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2545         * cli/cli-style.h (class cli_style_option): Add constructor.
2546         (metadata_style): Declare.
2547         * cli/cli-style.c (metadata_style): New global.
2548         (_initialize_cli_style): Register metadata style.
2549         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2550         parameter.
2551         * cli-out.c (cli_ui_out::do_field_fmt): Update.
2552         * c-typeprint.c (c_type_print_base_struct_union)
2553         (c_type_print_base_1): Use metadata style.
2554         * breakpoint.c (watchpoint_value_print)
2555         (print_one_breakpoint_location): Use metadata style.
2556         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2557         style.
2558         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2559         style.
2560         * ada-valprint.c (val_print_packed_array_elements, printstr)
2561         (print_field_values, ada_val_print_ref, ada_val_print): Use
2562         metadata style.
2563         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2564         style.
2565         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2566         style.
2567         * ada-lang.c (user_select_syms): Use metadata style.
2568
2569 2019-10-01  Tom Tromey  <tom@tromey.com>
2570
2571         * cli/cli-cmds.c (pwd_command): Style output.
2572
2573 2019-10-01  Pedro Alves  <palves@redhat.com>
2574             Tom Tromey  <tom@tromey.com>
2575
2576         * symtab.c (print_symbol_info): Use %ps.
2577         (print_msymbol_info): Use %ps.
2578         * symfile.c (symbol_file_add_with_addrs): Use %ps.
2579         * printcmd.c (print_variable_and_value): Use %ps.
2580         * macrocmd.c (show_pp_source_pos): Use %ps.
2581         * infrun.c (print_exited_reason): Use ui_out::message.
2582         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2583         (describe_other_breakpoints): Use ui_out::message and new
2584         formats.
2585         (say_where): Use new formats.
2586         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2587         and new formats.
2588
2589 2019-10-01  Pedro Alves  <palves@redhat.com>
2590             Tom Tromey  <tom@tromey.com>
2591
2592         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2593         (test_gdb_formats): New function.
2594         (run_tests): Call it.
2595         (test_format_specifier): Update.
2596         * utils.h (fputs_filtered): Update comment.
2597         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2598         (fputs_styled_unfiltered): Declare.
2599         * utils.c (fputs_styled_unfiltered): New function.
2600         (vfprintf_maybe_filtered): Add gdbfmt parameter.
2601         (vfprintf_filtered): Update.
2602         (vfprintf_unfiltered, vprintf_filtered): Update.
2603         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2604         * ui-out.h (enum ui_out_flag) <unfiltered_output,
2605         disallow_ui_out_field>: New constants.
2606         (enum class field_kind): New.
2607         (struct base_field_s, struct signed_field_s): New.
2608         (signed_field): New function.
2609         (struct string_field_s): New.
2610         (string_field): New function.
2611         (struct styled_string_s): New.
2612         (styled_string): New function.
2613         (class ui_out) <message>: Add comment.
2614         <vmessage, call_do_message>: New methods.
2615         <do_message>: Add style parameter.
2616         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2617         methods.
2618         (ui_out::message): Rewrite.
2619         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2620         parameter.
2621         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2622         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2623         gdb_extensions parameter.
2624         (class format_piece): Add parameter to constructor.
2625         (n_int_args): New field.
2626         * gdbsupport/format.c (format_pieces::format_pieces): Add
2627         gdb_extensions parameter.  Handle '*'.
2628         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2629         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
2630         vfprintf_styled_no_gdbfmt.
2631         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2632         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2633         unfiltered output.
2634         * ui-style.h (struct ui_file_style) <ptr>: New method.
2635
2636 2019-10-01  Tom Tromey  <tom@tromey.com>
2637
2638         * unittests/format_pieces-selftests.c: Update.  Add final format.
2639         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2640         empty literal pieces.
2641
2642 2019-10-01  Tom Tromey  <tom@tromey.com>
2643
2644         * ui-out.h (enum class ui_out_style_kind): Remove.
2645         (class ui_out) <field_string, field_stsream, do_field_string>:
2646         Change type of "style".
2647         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2648         (ui_out::field_string): Update.
2649         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2650         of "style".
2651         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2652         * tracepoint.c (print_one_static_tracepoint_marker): Update.
2653         * stack.c (print_frame_arg, print_frame_info, print_frame):
2654         Update.
2655         * source.c (print_source_lines_base): Update.
2656         * solib.c (info_sharedlibrary_command): Update.
2657         * skip.c (info_skip_command): Update.
2658         * record-btrace.c (btrace_call_history_src_line)
2659         (btrace_call_history): Update.
2660         * python/py-framefilter.c (py_print_frame): Update.
2661         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2662         "style".
2663         * mi/mi-out.c (mi_ui_out::do_table_header)
2664         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2665         (mi_ui_out::do_field_string): Update.
2666         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2667         Update.
2668         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2669         "style".
2670         * cli-out.c (cli_ui_out::do_table_header)
2671         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2672         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2673         (cli_ui_out::do_field_fmt): Update.
2674         * breakpoint.c (print_breakpoint_location): Update.
2675         (update_static_tracepoint): Update.
2676
2677 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2678
2679         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2680         conversion of gdb_datadir.
2681         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2682         remove not needed c_str ().
2683
2684 2019-09-30  Ali Tamur <tamur@google.com>
2685
2686         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2687         (dwarf2_string_attr): Likewise.
2688
2689 2019-09-30  Ali Tamur <tamur@google.com>
2690
2691         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2692         (process_full_type_unit): Likewise.
2693         (dump_die_shallow): Likewise.
2694         (cu_debug_loc_section): Likewise.
2695
2696 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
2697
2698         * minsyms.c (compare_minimal_symbols): Rename to...
2699         (minimal_symbol_is_less_than): ...this, and adjust to STL
2700         conventions (return bool, take arguments as references)
2701         (minimal_symbol_reader::install): Call std::sort instead
2702         of qsort.
2703
2704 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
2705
2706         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2707         hash and why.
2708         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2709         msymbol_hash, msymbol_demangled_hash>: Improve comments.
2710
2711 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
2712
2713         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2714         * psympriv.h (add_psymbol_to_list): Move comment here and update
2715         it.
2716
2717 2019-09-29  Tom de Vries  <tdevries@suse.de>
2718
2719         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2720         Use $tmpdir/$(basename "$output_file").dwz instead of
2721         "${output_file}.dwz".
2722
2723 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
2724
2725         PR gdb/25045
2726         * hppa-linux-nat.c: Include gdbarch.h.
2727
2728 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
2729
2730         * blockframe.c (find_pc_partial_function): Change return type to bool.
2731         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2732         * minsyms.c (in_gnu_ifunc_stub): Likewise.
2733         (stub_gnu_ifunc_resolve_name): Likewise.
2734         * symtab.c (compare_filenames_for_search): Likewise.
2735         (compare_glob_filenames_for_search): Likewise.
2736         (matching_obj_sections): Likewise.
2737         (symbol_matches_domain): Likewise.
2738         (find_line_symtab): Change out param EXACT_MATCH to bool *.
2739         (find_line_pc): Change return type to bool.
2740         (find_line_pc_range): Likewise.
2741         (producer_is_realview): Likewise.
2742         * symtab.h (symbol_matches_domain): Likewise.
2743         (find_pc_partial_function): Likewise.
2744         (find_pc_line_pc_range): Likewise.
2745         (in_gnu_ifunc_stub): Likewise.
2746         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2747         (find_line_pc): Likewise.
2748         (find_line_pc_range): Likewise.
2749         (matching_obj_sections): Likewise.
2750         (find_line_symtab): Change out parameter to bool.
2751         (producer_is_realview): Change return type to bool.
2752         (compare_filenames_for_search): Likewise.
2753         (compare_glob_filenames_for_search): Likewise.
2754
2755 2019-09-26  Tom Tromey  <tom@tromey.com>
2756
2757         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2758         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2759         * gdb_usleep.h: Remove.
2760         * gdb_usleep.c: Remove.
2761         * utils.c: Don't include gdb_usleep.h.
2762
2763 2019-09-26  Tom Tromey  <tromey@adacore.com>
2764
2765         * python/py-type.c (type_to_type_object): Call check_typedef
2766         for stub types.
2767
2768 2019-09-26  Tom Tromey  <tom@tromey.com>
2769
2770         * utils.h (initialize_utils): Don't declare.
2771         * top.c (gdb_init): Don't call initialize_utils.
2772         * utils.c (initialize_utils): Remove.  Move contents...
2773         (_initialize_utils): ... here.
2774
2775 2019-09-25  Tom Tromey  <tom@tromey.com>
2776
2777         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
2778         * utils.h (make_hex_string): Don't declare.
2779         * utils.c (make_hex_string): Remove.
2780
2781 2019-09-24  Tom de Vries  <tdevries@suse.de>
2782
2783         PR gdb/23815
2784         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
2785         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
2786
2787 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
2788
2789         * NEWS: Mention new simulator port for PRU.
2790
2791 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
2792
2793         * ada-exp.y (write_object_remaining): Update.
2794         * ada-lang.c (ada_decode): Return a std::string instead of a char*
2795         and eliminate the static buffer.
2796         (ada_decode_symbol): Update.
2797         (ada_la_decode): Update.
2798         (ada_sniff_from_mangled_name): Update.
2799         (is_valid_name_for_wild_match): Update.
2800         (ada_lookup_name_info::matches): Update and simplify.
2801         (name_matches_regex): Update.
2802         (ada_add_global_exceptions): Update.
2803         * ada-lang.h (ada_decode): Update signature.
2804         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
2805         * dwarf-index-write.c (debug_names::insert): Update.
2806
2807 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2808
2809         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
2810         formatting.
2811
2812 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
2813
2814         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
2815         Change "nonzero" to "true" in documentation.
2816
2817 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
2818
2819         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
2820         (_initialize_darwin_solib): Don't set
2821         darwin_so_ops.lookup_lib_global_symbol.
2822         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
2823         set_gdbarch_iterate_over_objfiles_in_search_order.
2824         (elf_lookup_lib_symbol): Rename to...
2825         (svr4_iterate_over_objfiles_in_search_order): this, and update
2826         to iterate semantics.
2827         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2828         * solib.c (solib_global_lookup): Remove.
2829         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2830         (solib_global_lookup): Remove.
2831         * symtab.c (lookup_global_or_static_symbol): Remove call to
2832         solib_global_lookup.
2833
2834 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2835
2836         * NEWS: Move entries about default MI version now being
2837         version 3, and about the GDB/MI fix for multi-location
2838         breakpoints to the "since GDB 8.3" section.
2839
2840 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
2841
2842         GDB 8.3.1 released.
2843
2844 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
2845
2846         * NEWS: Mention that Cell/B.E. debugging support was removed.
2847         * MAINTAINERS: Remove spu target.
2848
2849         * config/djgpp/fnchange.lst: Remove entries for removed files.
2850
2851         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
2852         spu-multiarch.o, and spu-tdep.o.
2853         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
2854         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
2855         spu-multiarch.c, and spu-tdep.c.
2856         * spu-linux-nat.c: Remove file.
2857         * spu-multiarch.c: Remove file.
2858         * spu-tdep.c: Remove file.
2859         * spu-tdep.h: Remove file.
2860         * solib-spu.c: Remove file.
2861         * solib-spu.h: Remove file.
2862
2863         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2864         * configure.nat (spu-linux): Remove.
2865         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2866         solib-multiarch.o from gdb_target_obs.
2867         (spu*-*-*): Remove.
2868
2869         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2870         feature flag.
2871         (ppc_linux_no_features): Update.
2872         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2873         Cell/B.E. support.
2874         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2875         (tdesc_powerpc_cell64l): Likewise.
2876         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2877         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2878         Cell/B.E. support.
2879         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2880         Do not include "features/rs6000/powerpc-cell32l.c" or
2881         "features/rs6000/powerpc-cell64l.c".
2882         (ppc_linux_spu_section): Remove.
2883         (ppc_linux_core_read_description): Remove Cell/B.E. support.
2884         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2885         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2886         (ppc_linux_spe_context_lookup): Remove.
2887         (ppc_linux_spe_context_inferior_created): Remove.
2888         (ppc_linux_spe_context_solib_loaded): Remove.
2889         (ppc_linux_spe_context_solib_unloaded): Remove.
2890         (ppc_linux_spe_context): Remove.
2891         (struct ppu2spu_cache): Remove.
2892         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2893         (struct ppu2spu_data): Remove.
2894         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2895         ppu2spu_unwind): Remove.
2896         (ppc_linux_init_abi): Remove Cell/B.E. support.
2897         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2898
2899         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2900         (rs6000/powerpc-cell64l-expedite): Likewise
2901         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2902         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2903         rs6000/powerpc-cell64l.xml.
2904         * features/rs6000/powerpc-cell32l.xml: Remove.
2905         * features/rs6000/powerpc-cell64l.xml: Likewise.
2906         * features/rs6000/powerpc-cell32l.c: Remove generated file.
2907         * features/rs6000/powerpc-cell64l.c: Likewise.
2908         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2909         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2910         * regformats/reg-spu.dat: Remove.
2911
2912         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2913         * corelow.c (struct spuid_list): Remove.
2914         (add_to_spuid_list): Remove.
2915         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2916         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2917         (remote_protocol_features): Remove associated entries.
2918         (_initialize_remote): No longer initialize them.
2919         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2920         * linux-nat.c (SPUFS_MAGIC): Remove.
2921         (linux_proc_xfer_spu): Remove.
2922         (spu_enumerate_spu_ids): Remove.
2923         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2924         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2925         (linux_make_corefile_notes): No longer call it.
2926
2927         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2928         (cooked_write_test): Likewise.
2929
2930 2019-09-20  Tom Tromey  <tom@tromey.com>
2931
2932         * NEWS: Mention case-sensitivity of TUI commands.
2933         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2934         (tui_set_win_height_command, parse_scrolling_args): Likewise.
2935         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2936
2937 2019-09-20  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-source.c (tui_source_window::set_contents): Use
2940         make_unique_xstrdup.
2941         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2942         make_unique_xstrdup.
2943
2944 2019-09-20  Tom Tromey  <tom@tromey.com>
2945
2946         * tui/tui-data.c: Remove separator comments.
2947         * tui/tui-layout.c: Remove separator comments.
2948         * tui/tui-win.c: Remove separator comments.
2949         * tui/tui-wingeneral.c: Remove separator comments.
2950
2951 2019-09-20  Tom Tromey  <tom@tromey.com>
2952
2953         * tui/tui.h (strcat_to_buf): Don't declare.
2954         * tui/tui.c (strcat_to_buf): Remove.
2955
2956 2019-09-20  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2959         from "fullname".
2960         * tui/tui-source.c (tui_source_window::set_contents)
2961         (tui_source_window::location_matches_p)
2962         (tui_source_window::maybe_update): Update.
2963
2964 2019-09-20  Tom Tromey  <tom@tromey.com>
2965
2966         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2967         Update.
2968         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2969         prefix.
2970         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2971         (tui_data_window::line_from_reg_element_no)
2972         (tui_data_window::first_reg_element_no_inline)
2973         (tui_data_window::show_registers)
2974         (tui_data_window::show_register_group)
2975         (tui_data_window::display_registers_from)
2976         (tui_data_window::display_registers_from_line)
2977         (tui_data_window::first_data_item_displayed)
2978         (tui_data_window::delete_data_content_windows)
2979         (tui_data_window::erase_data_content)
2980         (tui_data_window::do_scroll_vertical)
2981         (tui_data_window::refresh_window)
2982         (tui_data_window::check_register_values): Update.
2983
2984 2019-09-20  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2987         (struct tui_locator_window) <full_name, proc_name>: Now
2988         std::string.
2989         * tui/tui-stack.c (tui_locator_window::make_status_line)
2990         (tui_locator_window::set_locator_fullname)
2991         (tui_locator_window::set_locator_info): Update.
2992         * tui/tui-source.c (tui_source_window::set_contents)
2993         (tui_source_window::showing_source_p): Update.
2994
2995 2019-09-20  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2998         Don't call tui_locator_win_info_ptr.
2999
3000 2019-09-20  Tom Tromey  <tom@tromey.com>
3001
3002         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3003
3004 2019-09-20  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3007         height for locator.
3008         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3009         * tui/tui-layout.c (show_source_disasm_command, show_data)
3010         (show_source_or_disasm_and_command): Use 1 as height for locator.
3011
3012 2019-09-20  Tom Tromey  <tom@tromey.com>
3013
3014         * tui/tui.c (tui_enable): Update.
3015         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3016         Update.
3017         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3018         Update.
3019         * tui/tui-data.c (win_resized): Now bool.
3020         (tui_win_resized): Return bool.
3021         (tui_set_win_resized_to): Accept a bool.
3022
3023 2019-09-20  Tom Tromey  <tom@tromey.com>
3024
3025         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3026         Change type of "refresh_values_only".
3027         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3028         type of "refresh_values_only".
3029
3030 2019-09-20  Tom Tromey  <tom@tromey.com>
3031
3032         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3033         std::string.
3034         (tui_disassemble): Add "pos" parameter.
3035         (tui_disasm_window::set_contents): Simplify.
3036
3037 2019-09-20  Tom Tromey  <tom@tromey.com>
3038
3039         * tui/tui-winsource.h (struct tui_source_window_base)
3040         <show_source_content>: Now private.
3041         * tui/tui-winsource.c
3042         (tui_source_window_base::show_source_content): Don't handle empty
3043         content case.
3044
3045 2019-09-20  Tom Tromey  <tom@tromey.com>
3046
3047         * tui/tui-layout.c (show_source_disasm_command)
3048         (show_source_or_disasm_and_command): Don't call
3049         show_source_content.
3050
3051 2019-09-20  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3054         Declare.
3055         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3056         from tui_make_status_line.
3057         (tui_locator_window::rerender): Update.
3058
3059 2019-09-20  Tom Tromey  <tom@tromey.com>
3060
3061         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3062         (tui_locator_window::rerender): Update.
3063
3064 2019-09-20  Tom Tromey  <tom@tromey.com>
3065
3066         * tui/tui-winsource.h (struct tui_source_window_base)
3067         <~tui_source_window_base>: Don't declare.
3068         <fullname>: Remove.
3069         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3070         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3071         member.
3072         * tui/tui-source.c (tui_source_window::set_contents): Update.
3073         (tui_source_window::location_matches_p)
3074         (tui_source_window::maybe_update): Update.
3075
3076 2019-09-20  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-winsource.h (~tui_source_element): Remove.
3079         (tui_source_element): Update.
3080         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3081         * tui/tui-winsource.c (tui_show_source_line): Update.
3082         * tui/tui-source.c (tui_source_window::set_contents): Update.
3083         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3084
3085 2019-09-20  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3088         declare.
3089         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3090         tui_clear_source_windows_detail.
3091         * tui/tui-winsource.h (struct tui_source_window_base)
3092         <clear_detail>: Don't declare.
3093         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3094         Remove.
3095         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3096
3097 2019-09-20  Tom Tromey  <tromey@adacore.com>
3098
3099         PR ada/24919:
3100         * block.c (contained_in): Fix final return value.
3101
3102 2019-09-20  Alan Modra  <amodra@gmail.com>
3103
3104         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3105         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3106         (read_indirect_string_from_dwz): Use bfd accessor.
3107         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3108         * machoread.c (macho_symfile_read_all_oso): Likewise.
3109         * solib.c (solib_bfd_open): Likewise.
3110
3111 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3112
3113         * eval.c: Move declaration of overload_resolution to...
3114         * value.h: ...here.
3115
3116 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3117
3118         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3119         * arm-linux-tdep.c: Likewise.
3120         * arm-nbsd-nat.c: Likewise.
3121         * arm-tdep.h: Declare arm_apcs_32.
3122         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3123
3124 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3125
3126         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3127         * dwarf2read.h: Declare dwarf_always_disassemble.
3128
3129 2019-09-19  Tom de Vries  <tdevries@suse.de>
3130
3131         PR gdb/25009
3132         * source-cache.c (source_cache::ensure): Catch exception thrown during
3133         construction of the highlighter.
3134
3135 2019-09-18  Alan Modra  <amodra@gmail.com>
3136
3137         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3138         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3139         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3140         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3141         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3142         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3143         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3144         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3145         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3146         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3147         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3148         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3149         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3150         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3151         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3152         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3153         * mi/mi-interp.c: Update throughout for bfd section macro and
3154         function changes.
3155         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3156         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3157
3158 2019-09-18  Tom Tromey  <tom@tromey.com>
3159
3160         * NEWS: Add entry.
3161         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3162         call rl_initialize.
3163         (tui_enable): Do not call rl_initialize.
3164
3165 2019-09-18  Christian Groessler  <chris@groessler.org>
3166
3167         * alpha-linux-nat.c: Include gdbarch.h.
3168
3169 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3170
3171         * ui-file.c: Include cli/cli-style.h.
3172         (term_cli_styling): Remove cli_styling declaration.
3173
3174 2019-09-18  Alan Modra  <amodra@gmail.com>
3175
3176         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3177         to bfd_asymbol_section.
3178
3179 2019-09-18  Alan Modra  <amodra@gmail.com>
3180
3181         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3182         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3183         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3184
3185 2019-09-18  Alan Modra  <amodra@gmail.com>
3186
3187         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3188         * spu-linux-nat.c (spu_bfd_open): Likewise.
3189
3190 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3191
3192         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3193         to bool to match definition in dwarf2read.c.
3194
3195 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3196
3197         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3198         (print_signatures): Likewise.
3199         (trust_pad_over_xvs): Likewise.
3200         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3201         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3202         * arm-linux-nat.c (arm_apcs_32): Likewise.
3203         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3204         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3205         * arm-tdep.c (arm_debug): Likewise.
3206         (arm_apcs_32): Likewise.
3207         * auto-load.c (debug_auto_load): Likewise.
3208         (auto_load_gdb_scripts): Likewise.
3209         (global_auto_load): Likewise.
3210         (auto_load_local_gdbinit): Likewise.
3211         (auto_load_local_gdbinit_loaded): Likewise.
3212         * auto-load.h (global_auto_load): Likewise.
3213         (auto_load_local_gdbinit): Likewise.
3214         (auto_load_local_gdbinit_loaded): Likewise.
3215         * breakpoint.c (disconnected_dprintf): Likewise.
3216         (breakpoint_proceeded): Likewise.
3217         (automatic_hardware_breakpoints): Likewise.
3218         (always_inserted_mode): Likewise.
3219         (target_exact_watchpoints): Likewise.
3220         (_initialize_breakpoint): Update.
3221         * breakpoint.h (target_exact_watchpoints): Change to bool.
3222         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3223         * cli/cli-cmds.c (trace_commands): Likewise.
3224         * cli/cli-cmds.h (trace_commands): Likewise.
3225         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3226         to bool*.
3227         * cli/cli-logging.c (logging_overwrite): Change to bool.
3228         (logging_redirect): Likewise.
3229         (debug_redirect): Likewise.
3230         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3231         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3232         to bool.
3233         <boolean_option_def>: Update.
3234         (struct flag_option_def): Change default type of Context to bool
3235         from int.
3236         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3237         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3238         (get_setshow_command_value_string): Likewise.
3239         * cli/cli-style.c (cli_styling): Change to bool.
3240         (source_styling): Likewise.
3241         * cli/cli-style.h (source_styling): Likewise.
3242         (cli_styling): Likewise.
3243         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3244         to bool.
3245         * command.h (var_types): Update comment.
3246         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3247         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3248         bool.
3249         (debug_compile_cplus_scopes): Likewise.
3250         * compile/compile-internal.h (compile_debug): Likewise.
3251         * compile/compile.c (compile_debug): Likewise.
3252         (struct compile_options) <raw>: Likewise.
3253         * cp-support.c (catch_demangler_crashes): Likewise.
3254         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3255         (usr_cmd_cris_dwarf2_cfi): Likewise.
3256         * csky-tdep.c (csky_debug): Likewise.
3257         * darwin-nat.c (enable_mach_exceptions): Likewise.
3258         * dcache.c (dcache_enabled_p): Likewise.
3259         * defs.h (info_verbose): Likewise.
3260         * demangle.c (demangle): Likewise.
3261         (asm_demangle): Likewise.
3262         * dwarf-index-cache.c (debug_index_cache): Likewise.
3263         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3264         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3265         * dwarf2read.c (check_physname): Likewise.
3266         (use_deprecated_index_sections): Likewise.
3267         (dwarf_always_disassemble): Likewise.
3268         * eval.c (overload_resolution): Likewise.
3269         * event-top.c (set_editing_cmd_var): Likewise.
3270         (exec_done_display_p): Likewise.
3271         * event-top.h (set_editing_cmd_var): Likewise.
3272         (exec_done_display_p): Likewise.
3273         * exec.c (write_files): Likewise.
3274         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3275         (debug_fbsd_nat): Likewise.
3276         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3277         Likewise.
3278         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3279         <backtrace_past_entry> Likewise.
3280         * gdb-demangle.h (demangle): Likewise.
3281         (asm_demangle): Likewise.
3282         * gdb_bfd.c (bfd_sharing): Likewise.
3283         * gdbcore.h (write_files): Likewise.
3284         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3285         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3286         * gdbthread.h (print_thread_events): Likewise.
3287         * gdbtypes.c (opaque_type_resolution): Likewise.
3288         (strict_type_checking): Likewise.
3289         * gnu-nat.c (gnu_debug_flag): Likewise.
3290         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3291         * guile/scm-param.c (pascm_variable): Add boolval.
3292         (add_setshow_generic): Update.
3293         (pascm_param_value): Update.
3294         (pascm_set_param_value_x): Update.
3295         * hppa-tdep.c (hppa_debug): Change to bool..
3296         * infcall.c (may_call_functions_p): Likewise.
3297         (coerce_float_to_double_p): Likewise.
3298         (unwind_on_signal_p): Likewise.
3299         (unwind_on_terminating_exception_p): Likewise.
3300         * infcmd.c (startup_with_shell): Likewise.
3301         * inferior.c (print_inferior_events): Likewise.
3302         * inferior.h (startup_with_shell): Likewise.
3303         (print_inferior_events): Likewise.
3304         * infrun.c (step_stop_if_no_debug): Likewise.
3305         (detach_fork): Likewise.
3306         (debug_displaced): Likewise.
3307         (disable_randomization): Likewise.
3308         (non_stop): Likewise.
3309         (non_stop_1): Likewise.
3310         (observer_mode): Likewise.
3311         (observer_mode_1): Likewise.
3312         (set_observer_mode): Update.
3313         (sched_multi): Change to bool.
3314         * infrun.h (debug_displaced): Likewise.
3315         (sched_multi): Likewise.
3316         (step_stop_if_no_debug): Likewise.
3317         (non_stop): Likewise.
3318         (disable_randomization): Likewise.
3319         * linux-tdep.c (use_coredump_filter): Likewise.
3320         (dump_excluded_mappings): Likewise.
3321         * linux-thread-db.c (auto_load_thread_db): Likewise.
3322         (check_thread_db_on_load): Likewise.
3323         * main.c (captured_main_1): Update.
3324         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3325         xx2_opt, boolean_opt>: Change to bool.
3326         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3327         * maint.c (maintenance_profile_p): Likewise.
3328         (per_command_time): Likewise.
3329         (per_command_space): Likewise.
3330         (per_command_symtab): Likewise.
3331         * memattr.c (inaccessible_by_default): Likewise.
3332         * mi/mi-main.c (mi_async): Likewise.
3333         (mi_async_1): Likewise.
3334         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3335         * nat/fork-inferior.h (startup_with_shell): Likewise.
3336         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3337         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3338         * nios2-tdep.c (nios2_debug): Likewise.
3339         * or1k-tdep.c (or1k_debug): Likewise.
3340         * parse.c (parser_debug): Likewise.
3341         * parser-defs.h (parser_debug): Likewise.
3342         * printcmd.c (print_symbol_filename): Likewise.
3343         * proc-api.c (procfs_trace): Likewise.
3344         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3345         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3346         (set_parameter_value): Update.
3347         (add_setshow_generic): Update.
3348         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3349         to bool*.
3350         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3351         int*.
3352         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3353         * record-btrace.c (record_btrace_target::store_registers): Update.
3354         * record-full.c (record_full_memory_query): Change to bool.
3355         (record_full_stop_at_limit): Likewise.
3356         * record-full.h (record_full_memory_query): Likewise.
3357         * remote-notif.c (notif_debug): Likewise.
3358         * remote-notif.h (notif_debug): Likewise.
3359         * remote.c (use_range_stepping): Likewise.
3360         (interrupt_on_connect): Likewise.
3361         (remote_break): Likewise.
3362         * ser-tcp.c (tcp_auto_retry): Likewise.
3363         * ser-unix.c (serial_hwflow): Likewise.
3364         * skip.c (debug_skip): Likewise.
3365         * solib-aix.c (solib_aix_debug): Likewise.
3366         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3367         (spu_auto_flush_cache_p): Likewise.
3368         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3369         Likewise.
3370         (struct info_print_options) <quiet>: Likewise.
3371         * symfile-debug.c (debug_symfile): Likewise.
3372         * symfile.c (auto_solib_add): Likewise.
3373         (separate_debug_file_debug): Likewise.
3374         * symfile.h (auto_solib_add): Likewise.
3375         (separate_debug_file_debug): Likewise.
3376         * symtab.c (basenames_may_differ): Likewise.
3377         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3378         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3379         (struct info_types_options) <quiet>: Likewise.
3380         * symtab.h (demangle): Likewise.
3381         (basenames_may_differ): Likewise.
3382         * target-dcache.c (stack_cache_enabled_1): Likewise.
3383         (code_cache_enabled_1): Likewise.
3384         * target.c (trust_readonly): Likewise.
3385         (may_write_registers): Likewise.
3386         (may_write_memory): Likewise.
3387         (may_insert_breakpoints): Likewise.
3388         (may_insert_tracepoints): Likewise.
3389         (may_insert_fast_tracepoints): Likewise.
3390         (may_stop): Likewise.
3391         (auto_connect_native_target): Likewise.
3392         (target_stop_and_wait): Update.
3393         (target_async_permitted): Change to bool.
3394         (target_async_permitted_1): Likewise.
3395         (may_write_registers_1): Likewise.
3396         (may_write_memory_1): Likewise.
3397         (may_insert_breakpoints_1): Likewise.
3398         (may_insert_tracepoints_1): Likewise.
3399         (may_insert_fast_tracepoints_1): Likewise.
3400         (may_stop_1): Likewise.
3401         * target.h (target_async_permitted): Likewise.
3402         (may_write_registers): Likewise.
3403         (may_write_memory): Likewise.
3404         (may_insert_breakpoints): Likewise.
3405         (may_insert_tracepoints): Likewise.
3406         (may_insert_fast_tracepoints): Likewise.
3407         (may_stop): Likewise.
3408         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3409         (make_thread_apply_all_options_def_group): Change argument from int*
3410         to bool*.
3411         (thread_apply_all_command): Update.
3412         (print_thread_events): Change to bool.
3413         * top.c (confirm): Likewise.
3414         (command_editing_p): Likewise.
3415         (history_expansion_p): Likewise.
3416         (write_history_p): Likewise.
3417         (info_verbose): Likewise.
3418         * top.h (confirm): Likewise.
3419         (history_expansion_p): Likewise.
3420         * tracepoint.c (disconnected_tracing): Likewise.
3421         (circular_trace_buffer): Likewise.
3422         * typeprint.c (print_methods): Likewise.
3423         (print_typedefs): Likewise.
3424         * utils.c (debug_timestamp): Likewise.
3425         (sevenbit_strings): Likewise.
3426         (pagination_enabled): Likewise.
3427         * utils.h (sevenbit_strings): Likewise.
3428         (pagination_enabled): Likewise.
3429         * valops.c (overload_resolution): Likewise.
3430         * valprint.h (struct value_print_options) <prettyformat_arrays,
3431         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3432         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3433         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3434         Likewise.
3435         * windows-nat.c (new_console): Likewise.
3436         (cygwin_exceptions): Likewise.
3437         (new_group): Likewise.
3438         (debug_exec): Likewise.
3439         (debug_events): Likewise.
3440         (debug_memory): Likewise.
3441         (debug_exceptions): Likewise.
3442         (useshell): Likewise.
3443         * windows-tdep.c (maint_display_all_tib): Likewise.
3444         * xml-support.c (debug_xml): Likewise.
3445
3446 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3447
3448         * source.c (prepare_path_for_appending): New function.
3449         (openp): Make use of new function.
3450         (find_and_open_source): Search for the compilation directory and
3451         source file as a relative path beneath the directory search path.
3452
3453 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3454
3455         * source-cache.c (source_cache::get_line_charpos): Catch
3456         exceptions and return false, this matches the behaviour documented
3457         in the header file.
3458
3459 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3460
3461         * ada-tasks.c (info_task): Remove quoting of the task's name.
3462
3463 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3464
3465         * symfile.c (auto_solib_add): Replace comment with a reference
3466         to the header file.
3467
3468 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3469
3470         * NEWS: Mention that gdb can now be compiled with Python 3
3471         on Windows.
3472
3473 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3474
3475         * maint.c (maint_print_section_data::maint_print_section_data):
3476         Force use of 'float log10 (float)' by casting the argument to
3477         float.
3478
3479 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3480
3481         * maint.c: Add 'cmath' include.
3482         (struct maint_print_section_data): New structure.
3483         (print_section_index): New function.
3484         (print_bfd_section_info): Add header comment, small whitespace
3485         cleanup, and update to call new print_section_index function.
3486         (print_objfile_section_info): Likewise.
3487         (maint_obj_section_from_bfd_section): New function.
3488         (print_bfd_section_info_maybe_relocated): New function.
3489         (maintenance_info_sections): Add header comment, always use
3490         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3491
3492 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3493
3494         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3495         inner scope, add check that the objfile has psymtabs before
3496         checking psymtabs_addrmap.
3497         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3498
3499 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3500
3501         * NEWS: Announce that Ada task names are now shown at more places,
3502         and between quotes (except in info task output).
3503         * gdb/ada-tasks.c (task_to_str): New function.
3504         (display_current_task_id): Call task_to_str.
3505         (task_command_1): Likewise.
3506         (print_ada_task_info): In non-mi mode, Properly align headers and data
3507         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3508
3509 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3510
3511         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3512         prstatus.pr_lwp.pr_info instead of making it up.
3513
3514 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3515
3516         * auto-load.c (auto_load_expand_dir_vars): Update.
3517         * defs.h (gdb_datadir): Change to std::string.
3518         (python_libdir): Likewise.
3519         (relocate_gdb_directory): Change return type to std::string.
3520         * guile/guile.c (gdbscm_data_directory): Update.
3521         (initialize_scheme_side): Update.
3522         * jit.c (jit_reader_dir): Change to std::string.
3523         (jit_reader_load_command): Update.
3524         * main.c (gdb_datadir): Change to std::string.
3525         (python_libdir): Likewise.
3526         (set_gdb_data_directory): Update.
3527         (relocate_path): Change to return std::string.
3528         (relocate_gdb_directory): Change to return std::string.
3529         (relocate_gdbinit_path_maybe_in_datadir): Update.
3530         (captured_main_1): Update.
3531         * python/python.c (do_start_initialization): Update.
3532         * top.c (show_gdb_datadir): Update.
3533         * xml-syscall.c (xml_init_syscalls_info): Update.
3534         (init_syscalls_info): Update.
3535
3536 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3537
3538         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3539         out of get_init_files.
3540         (get_init_files): Update.
3541
3542 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3543
3544         * main.c (get_init_files): Change to use std::string.
3545         (captured_main_1): Update.
3546         (print_gdb_help): Update.
3547
3548 2019-09-11  Ali Tamur  <tamur@google.com>
3549
3550         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3551         implementation.
3552
3553 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3554
3555         * dbxread.c (read_dbx_symtab): Update.
3556         * dwarf2read.c (load_partial_dies): Update.
3557         * mdebugread.c (parse_partial_symbols): Update.
3558         (handle_psymbol_enumerators): Update.
3559         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3560         * psymtab.c (add_psymbol_to_bcache): Likewise.
3561         (add_psymbol_to_list): Likewise.
3562         * symtab.c (symbol_set_names): Likewise.
3563         * symtab.h (symbol_set_names): Likewise.
3564         * xcoffread.c (scan_xcoff_symtab): Update.
3565
3566 2019-09-11  Tom Tromey  <tom@tromey.com>
3567
3568         * symfile-mem.c (symbol_file_add_from_memory): Use
3569         bfd_set_filename.
3570         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3571         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3572
3573 2019-09-10  Tom Tromey  <tromey@adacore.com>
3574
3575         * dwarf-index-write.c (write_psymbols): Extend error message.
3576         (debug_names::insert): Add Ada code.
3577         (debug_names::write_psymbols): Remove Ada check.
3578         (debug_names) <m_string_obstack>: New member.
3579         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3580         (gdb_index_symbol_name_matcher::matches): Remove.
3581         (mapped_index_base::find_name_components_bounds): Add "lang"
3582         parameter.
3583         (mapped_index_base::build_name_components): Also split names
3584         according to Ada syntax.
3585         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
3586         type of "match_callback".
3587         (check_match, check_find_bounds_finds)
3588         (dw2_expand_symtabs_matching): Update.
3589         (dw2_debug_names_iterator): Add new constructor.
3590         (dw2_debug_names_map_matching_symbols): New function.
3591         (dw2_debug_names_expand_symtabs_matching): Update.
3592         (dwarf2_debug_names_functions): Use
3593         dw2_debug_names_map_matching_symbols.
3594
3595 2019-09-10  Tom Tromey  <tromey@adacore.com>
3596
3597         * dwarf2read.c (dw2_get_file_names_reader): Add the
3598         CU's file name to the results.
3599
3600 2019-09-10  Tom Tromey  <tromey@adacore.com>
3601
3602         * ada-lang.c (add_nonlocal_symbols): Combine calls to
3603         map_matching_symbols.  Update.
3604         * dwarf2read.c (dw2_map_matching_symbols): Update.
3605         * psymtab.c (match_partial_symbol): Change type; update.
3606         (psym_map_matching_symbols): Likewise.
3607         * symfile-debug.c (debug_qf_map_matching_symbols): Change
3608         type; update.
3609         * symfile.h (struct quick_symbol_functions)
3610         <map_matching_symbols>: Change "name" to be a lookup_name_info.
3611         Remove "match".
3612
3613 2019-09-10  Tom Tromey  <tromey@adacore.com>
3614
3615         * psymtab.c (map_block): Remove.
3616         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3617         * symtab.c (iterate_over_symbols_terminated): New function.
3618         * symtab.c (iterate_over_symbols_terminated): Declare.
3619
3620 2019-09-10  Tom Tromey  <tromey@adacore.com>
3621
3622         * ada-lang.c (ada_iterate_over_symbols): Return bool.
3623         * language.h (struct language_defn) <la_iterate_over_symbols>:
3624         Return bool.
3625         * symtab.c (iterate_over_symbols): Return bool.
3626         * symtab.h (iterate_over_symbols): Return bool.
3627
3628 2019-09-10  Tom Tromey  <tromey@adacore.com>
3629
3630         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3631         (add_nonlocal_symbols): Update.
3632         * dwarf2read.c (dw2_map_matching_symbols): Change type.
3633         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3634         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3635         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3636         Change type of "callback".  Remove "data".
3637
3638
3639 2019-09-09  Ali Tamur  <tamur@google.com>
3640
3641         * dwarf2read.c (comp_unit_head): Update comment.
3642         (dwarf2_dwo_name): New function declaration.
3643         (dwarf_unit_type_name): New function declaration.
3644         (read_comp_unit_head): Add support for new compilation units,
3645         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3646         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3647         (currently named as "signature") in their header. Also clarify error
3648         messages.
3649         (lookup_dwo_id): New function. Returns the dwo id of the given
3650         compile unit.
3651         (lookup_dwo_unit): Use the new lookup_dwo_id function.
3652         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3653         functions.
3654         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3655         (dwarf2_dwo_name): Get the dwo name if present.
3656         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3657         purposes.
3658
3659 2019-09-09  Tom Tromey  <tom@tromey.com>
3660
3661         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3662
3663 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3664
3665         * python/python.c (do_start_initialization): Make progname_copy static,
3666         to avoid a leak report.
3667
3668 2019-09-08  Tom Tromey  <tom@tromey.com>
3669
3670         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3671
3672 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
3673
3674         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3675         Change type to gdb::optional<block_enum>.
3676         (dw2_symtab_iter_init): Change block_index parameter type
3677         to gdb::optional<block_enum>.
3678         (dw2_lookup_symbol): Change block_index parameter
3679         type to block_enum.c
3680         (dw2_debug_names_lookup_symbol): Likewise.
3681         * psymtab.c (psym_lookup_symbol): Likewise.
3682         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3683         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3684         Likewise.
3685
3686 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
3687
3688         * defs.h (relocate_gdb_directory): Change int to bool in
3689         signature and rename flag to relocatable.
3690         * main.c (relocate_path): Likewise.
3691         (relocate_gdb_directory): Likewise.
3692
3693 2019-09-06  Alan Modra  <amodra@gmail.com>
3694
3695         * coffread.c (coff_symfile_read): Constify filename variable.
3696         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3697         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3698         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3699         * solib.c (reload_shared_libraries_1): Likewise.
3700         * symfile.c (reread_symbols): Likewise.
3701         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3702         * solib-darwin.c (darwin_bfd_open): Likewise.
3703         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3704
3705 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3706
3707         * psymtab.c (print_partial_symbols): Handle missing domain_enum
3708         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3709
3710 2019-09-03  Tom Tromey  <tromey@adacore.com>
3711
3712         * ada-valprint.c (ada_val_print_num): Don't recurse for range
3713         types.
3714         (has_negatives): Unbias a range type bound.
3715         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3716         * gdbtypes.c (operator==): Handle new field.
3717         (create_range_type): Add "bias" parameter.
3718         (create_static_range_type, resolve_dynamic_range): Update.
3719         * gdbtypes.h (struct range_bounds) <bias>: New member.
3720         (create_range_type): Add bias parameter.
3721         * printcmd.c (print_scalar_formatted): Unbias range types.
3722         * value.c (unpack_long): Unbias range types.
3723         (pack_long): Bias range types.
3724
3725 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3726
3727         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3728         probe arguments.
3729
3730 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3731
3732         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3733         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3734         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3735         (compile_probe_arg): Likewise.
3736         * probe.h (get_argument_count): Likewise.
3737         * solib-svr4.c (solib_event_probe_action): Likewise.
3738         * stap-probe.c (stap_probe::get_argument_count): Likewise.
3739
3740 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3741
3742         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3743         code to here...
3744         (svr4_create_solib_event_breakpoints): ...from here.
3745
3746 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
3747
3748         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3749         suffix from warning message.
3750
3751 2019-08-30  Tom Tromey  <tom@tromey.com>
3752
3753         * tui/tui-winsource.h (struct tui_source_window_base)
3754         <refresh_all>: Don't declare.
3755         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3756         Remove.
3757         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3758         tui_show_locator_content.
3759         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3760         declare.
3761         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3762         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3763         declare.
3764
3765 2019-08-30  Tom Tromey  <tom@tromey.com>
3766
3767         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3768
3769 2019-08-30  Tom Tromey  <tom@tromey.com>
3770
3771         * tui/tui-stack.c (_initialize_tui_stack): Move later.
3772         Remove unnecessary forward declarations.
3773
3774 2019-08-30  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
3777         rerender.
3778         (tui_update_locator_fullname, tui_show_frame_info): Don't call
3779         tui_show_locator_content.
3780
3781 2019-08-30  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
3784         (tui_locator_window::rerender): Rewrite using body of previous
3785         tui_show_locator_content.
3786
3787 2019-08-30  Tom Tromey  <tom@tromey.com>
3788
3789         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
3790         set_locator_fullname>: New methods.
3791         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3792         Rename from tui_set_locator_fullname.
3793         (tui_locator_window::set_locator_info): Rename from
3794         tui_set_locator_info.  Return bool.
3795         (tui_update_locator_fullname, tui_show_frame_info): Update.
3796
3797 2019-08-30  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
3800
3801 2019-08-30  Tom Tromey  <tom@tromey.com>
3802
3803         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
3804         call touchwin.
3805
3806 2019-08-30  Tom Tromey  <tom@tromey.com>
3807
3808         * tui/tui-wingeneral.c (box_win): Assume win_info and
3809         win_info->handle cannot be NULL.
3810
3811 2019-08-30  Tom Tromey  <tom@tromey.com>
3812
3813         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
3814         refresh_window>: Declare.
3815         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
3816         resize.
3817         (tui_data_item_window::rerender): Rename from
3818         tui_display_register.
3819         (tui_data_item_window::refresh_window): New method.
3820         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
3821         no-op.
3822
3823 2019-08-30  Tom Tromey  <tom@tromey.com>
3824
3825         * tui/tui-regs.h (struct tui_data_window) <regs_content,
3826         regs_column_count, current_group>: Move later.  Now private.
3827         <get_current_group>: New method.
3828         * tui/tui-regs.c (tui_reg_command): Update.
3829         * tui/tui-layout.c (tui_set_layout): Update.
3830
3831 2019-08-30  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3834         (tui_data_window::rerender): Don't call
3835         check_and_display_highlight_if_needed.
3836         (tui_data_window::refresh_all): Remove call to
3837         erase_data_content.
3838
3839 2019-08-30  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3842         (tui_data_window::display_registers_from)
3843         (tui_data_window::display_reg_element_at_line)
3844         (tui_data_window::display_registers_from_line): Remove checks of
3845         "empty".
3846
3847 2019-08-30  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
3850         Don't declare.
3851         * tui/tui-regs.c (tui_data_window::show_registers): Call
3852         rerender.
3853         (tui_data_window::rerender): Rename from display_all_data.
3854         (tui_data_window::rerender): Remove old implementation.
3855
3856 2019-08-30  Tom Tromey  <tom@tromey.com>
3857
3858         * tui/tui-regs.c (tui_data_window::display_all_data): Change
3859         text.
3860         * tui/tui-data.h (NO_DATA_STRING): Remove define.
3861
3862 2019-08-29  Bernhard Wodok  <barto@gmx.net>
3863             Sergio Durigan Junior  <sergiodj@redhat.com>
3864
3865         PR win32/24284
3866         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3867
3868 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3869
3870         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3871         when searching for types.
3872
3873 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
3874
3875         * f-lang.c (f_language_defn): Use f_print_typedef.
3876         * f-lang.h (f_print_typedef): Declare.
3877         * f-typeprint.c (f_print_typedef): Define.
3878
3879 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
3880
3881         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3882
3883 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * cli/cli-utils.c (info_print_options_defs): Delete.
3886         (make_info_print_options_def_group): Delete.
3887         (extract_info_print_options): Delete.
3888         (info_print_command_completer): Delete.
3889         (info_print_args_help): Add extra parameter, and optionally
3890         include text about -n flag.
3891         * cli/cli-utils.h (struct info_print_options): Delete.
3892         (extract_info_print_options): Delete declaration.
3893         (info_print_command_completer): Delete declaration.
3894         (info_print_args_help): Add extra parameter, extend header
3895         comment.
3896         * python/python.c (gdbpy_rbreak): Pass additional parameter to
3897         search_symbols.
3898         * stack.c (struct info_print_options): New type.
3899         (info_print_options_defs): New file scoped variable.
3900         (make_info_print_options_def_group): New static function.
3901         (info_print_command_completer): New static function.
3902         (info_locals_command): Update to use new local functions.
3903         (info_args_command): Likewise.
3904         (_initialize_stack): Add extra parameter to calls to
3905         info_print_args_help.
3906         * symtab.c (search_symbols): Add extra parameter, use this to
3907         possibly excluse non-debug symbols.
3908         (symtab_symbol_info): Add extra parameter, which is passed on to
3909         search_symbols.
3910         (struct info_print_options): New type.
3911         (info_print_options_defs): New file scoped variable.
3912         (make_info_print_options_def_group): New static function.
3913         (info_print_command_completer): New static function.
3914         (info_variables_command): Update to use local functions, and pass
3915         extra parameter through to symtab_symbol_info.
3916         (info_functions_command): Likewise.
3917         (info_types_command): Pass additional argument through to
3918         symtab_symbol_info.
3919         (rbreak_command): Pass extra argument to search_symbols.
3920         (_initialize_symtab): Add extra arguments for calls to
3921         info_print_args_help, and update help text for 'info variables',
3922         'whereis', and 'info functions' commands.
3923         * symtab.h (search_symbols): Add extra argument to declaration.
3924         * NEWS: Mention new flags.
3925
3926 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
3927
3928         * symtab.c (lookup_static_symbol): Call the new function (and move
3929         it down to be next to lookup_global_symbol).
3930         (struct global_sym_lookup_data): Add block_enum member and rename to...
3931         (struct global_or_static_sym_lookup_data): ...this.
3932         (lookup_symbol_global_iterator_cb): Pass block_index instead of
3933         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3934         (lookup_symbol_global_or_static_iterator_cb): ...this.
3935         (lookup_global_or_static_symbol): New function.
3936         (lookup_global_symbol): Call new function.
3937
3938 2019-08-26  Tom de Vries  <tdevries@suse.de>
3939
3940         PR c++/24852
3941         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3942         when pc_probe.prob == NULL.
3943
3944 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3945
3946         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3947         variable symbol_linkage to symbol_linkage_.
3948
3949 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
3950
3951         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3952         represent whether the symbol is static, dynamic, or we don't
3953         know.
3954
3955 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
3956
3957         * gdb/rx-tdep.c (rx_register_names): New.
3958         (rx_register_name): Delete.
3959         (rx_psw_type): Delete.
3960         (rx_fpsw_type): Delete.
3961         (rx_register_type): Delete.
3962         (rx_gdbarch_init): Convert target-descriptions.
3963         (_initialize_rx_tdep): Add initialize_tdesc_rx.
3964         * gdb/features/Makefile: Add rx.xml.
3965         * gdb/features/rx.xml: New.
3966         * gdb/features/rx.c: Generated.
3967         * gdb/NEWS: Mention target description support.
3968
3969 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3970
3971         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3972         *slot_ptr.
3973
3974 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3975
3976         * configure.ac: Don't check for 'dlfcn.h' (moved to
3977         gdbsupport/common.m4).
3978         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3979         'gdbsupport/'.
3980         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3981         * compile/compile-c-support.c: Include
3982         'gdbsupport/gdb-dlfcn.h'.
3983         * gdbsupport/common.m4: Check for 'dlfcn.h'.
3984         * gdb-dlfcn.c: Move to...
3985         * gdbsupport/gdb-dlfcn.c: ... here.
3986         * gdb-dlfcn.h: Move to...
3987         * gdbsupport/gdb-dlfcn.h: ... here.
3988
3989 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
3990
3991         * nios2-tdep.c (struct reg_value): Improve comments.  Make
3992         the offset field signed.
3993
3994 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
3995
3996         * python/lib/gdb/__init__.py (_execute_file): New function.
3997         * python/python.c (python_run_simple_file): Call gdb._execute_file
3998         on Windows.
3999
4000 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4001
4002         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4003         all uses as this was never set to anything but a zero value.
4004
4005 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4006
4007         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4008
4009 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4010
4011         * tui/tui-data.h (tui_gen_win_info): Add an =default
4012         move constructor, required by some GCC versions.
4013
4014 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4015
4016         * go32-nat.c (go32_sysinfo): Add hygon_p.
4017
4018 2019-08-20  Tom Tromey  <tom@tromey.com>
4019
4020         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4021         line_from_reg_element_no, first_reg_element_no_inline,
4022         display_all_data, delete_data_content_windows,
4023         erase_data_content>: Now private.
4024
4025 2019-08-20  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4028         (tui_unhighlight_win, tui_highlight_win)
4029         (tui_win_info::make_window): Update.
4030         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4031
4032 2019-08-20  Tom Tromey  <tom@tromey.com>
4033
4034         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4035         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4036         (MAX_PID_WIDTH): Move to tui-stack.c.
4037         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4038         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4039         (MAX_PID_WIDTH): Move from tui-data.h.
4040
4041 2019-08-20  Tom Tromey  <tom@tromey.com>
4042
4043         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4044         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4045         (box_win): Update.
4046         (tui_gen_win_info::make_window): Rename from tui_make_window.
4047         (tui_win_info::make_window): New method.
4048         (tui_gen_win_info::make_visible): Update.
4049         * tui/tui-source.c (tui_source_window::set_contents): Update.
4050         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4051         (tui_data_window::display_registers_from): Update.
4052         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4053         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4054         Declare.
4055         <can_box>: Remove.
4056         <title>: Remove.
4057         (struct tui_win_info) <make_window>: Declare.
4058         <can_box>: Now virtual.
4059         <title>: New member.
4060         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4061         * tui/tui-command.c (tui_cmd_window::resize): Update.
4062
4063 2019-08-20  Tom Tromey  <tom@tromey.com>
4064
4065         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4066         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4067         (tui_data_window::check_register_values): Update.
4068
4069 2019-08-20  Tom Tromey  <tom@tromey.com>
4070
4071         * tui/tui-regs.h (struct tui_data_window): Use
4072         DISABLE_COPY_AND_ASSIGN.
4073         <regs_content>: Change type, removing unique_ptr.
4074         <tui_data_window>: Add move constructor.
4075         * tui/tui-regs.c (tui_data_window::show_registers)
4076         (tui_data_window::show_register_group)
4077         (tui_data_window::display_registers_from)
4078         (tui_data_window::display_registers_from)
4079         (tui_data_window::first_data_item_displayed)
4080         (tui_data_window::delete_data_content_windows)
4081         (tui_data_window::rerender, tui_data_window::refresh_window)
4082         (tui_data_window::check_register_values): Update.
4083
4084 2019-08-20  Tom Tromey  <tom@tromey.com>
4085
4086         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4087         show_register_group>: Declare.
4088         (tui_show_register_group): Don't declare.
4089         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4090         tui_show_registers.
4091         (tui_data_window::show_register_group): Rename from
4092         tui_show_register_group.
4093         (tui_data_window::check_register_values, tui_reg_command):
4094         Update.
4095         * tui/tui-layout.c (tui_set_layout): Update.
4096
4097 2019-08-20  Tom Tromey  <tom@tromey.com>
4098
4099         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4100         Declare.
4101         (tui_check_register_values): Don't declare.
4102         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4103         from tui_check_register_values.
4104         * tui/tui-hooks.c (tui_register_changed): Update.
4105
4106 2019-08-20  Tom Tromey  <tom@tromey.com>
4107
4108         * tui/tui-regs.c (tui_reg_layout): Move later.
4109         (tui_show_registers): Don't enable TUI mode or change layout.
4110
4111 2019-08-20  Tom Tromey  <tom@tromey.com>
4112
4113         * tui/tui-regs.h (struct tui_data_item_window)
4114         <~tui_data_item_window>: Remove.
4115         <content>: Now a unique_xmalloc_ptr.
4116         * tui/tui-regs.c (tui_register_format): Return a
4117         unique_xmalloc_ptr.
4118         (tui_get_register): Update.
4119         (~tui_data_item_window): Remove.
4120         (tui_data_window::display_registers_from, tui_display_register):
4121         Update.
4122         * tui/tui-io.h (tui_expand_tabs): Update.
4123         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4124         Remove "col" parameter.
4125
4126 2019-08-20  Tom Tromey  <tom@tromey.com>
4127
4128         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4129         field.
4130         * tui/tui-regs.c (~tui_data_item_window): Update.
4131
4132 2019-08-20  Tom Tromey  <tom@tromey.com>
4133
4134         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4135         earlier.
4136
4137 2019-08-20  Tom Tromey  <tom@tromey.com>
4138
4139         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4140
4141 2019-08-20  Tom Tromey  <tom@tromey.com>
4142
4143         * tui/tui-source.h (struct tui_source_window): Update.
4144         * tui/tui-regs.c (tui_show_registers): Update.
4145         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4146         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4147         (NO_REGS_STRING): Remove defines.
4148
4149 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4150
4151         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4152         unnecessary thread walk if remote doesn't support the packet.
4153
4154 2019-08-19  Tom Tromey  <tromey@adacore.com>
4155
4156         * python/py-value.c (value_has_field): Fix indentation.
4157
4158 2019-08-19  Tom Tromey  <tromey@adacore.com>
4159
4160         * printcmd.c (do_one_display, info_display_command): Update.
4161         * block.h (contained_in): Return bool.  Add allow_nested
4162         parameter.
4163         * block.c (contained_in): Return bool.  Add allow_nested
4164         parameter.
4165
4166 2019-08-19  Tom Tromey  <tom@tromey.com>
4167
4168         * configure: Rebuild.
4169         * configure.ac: Disallow the combination of -static-libstdc++ and
4170         source highlight.
4171         * source-cache.c (get_language_name): Handle rust.
4172         (source_cache::get_source_lines): Ignore highlighting exceptions.
4173
4174 2019-08-16  Tom Tromey  <tom@tromey.com>
4175
4176         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4177         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4178         (struct tui_source_window_base) <make_visible, refresh_window,
4179         resize>: Remove methods.
4180         <execution_info>: Remove field.
4181         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4182         (tui_show_source_line, tui_source_window_base)
4183         (~tui_source_window_base): Update.
4184         (tui_source_window_base::resize)
4185         (tui_source_window_base::make_visible)
4186         (tui_source_window_base::refresh_window): Remove.
4187         (tui_source_window_base::update_exec_info): Update.
4188         * tui/tui-source.c (tui_source_window::set_contents): Update.
4189         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4190
4191 2019-08-16  Tom Tromey  <tom@tromey.com>
4192
4193         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4194         deprecated_query_hook.
4195
4196 2019-08-16  Tom Tromey  <tom@tromey.com>
4197
4198         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4199         (tui_update_source_windows_with_line): Update.
4200         * tui/tui-source.h (struct tui_source_window)
4201         <show_symtab_source>: Declare.
4202         (tui_show_symtab_source): Don't declare.
4203         * tui/tui-source.c (tui_show_symtab_source): Rename from
4204         tui_show_symtab_source.
4205
4206 2019-08-16  Tom Tromey  <tom@tromey.com>
4207
4208         * tui/tui-winsource.h (struct tui_source_window_base)
4209         <set_contents>: Declare.
4210         * tui/tui-winsource.c
4211         (tui_source_window_base::update_source_window_as_is): Update.
4212         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4213         Declare.
4214         (tui_set_source_content): Don't declare.
4215         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4216         tui_set_source_content.
4217         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4218         Declare.
4219         (tui_set_disassem_content): Don't declare.
4220         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4221         tui_set_disassem_content.
4222
4223 2019-08-16  Tom Tromey  <tom@tromey.com>
4224
4225         * tui/tui-winsource.h (struct tui_source_window_base)
4226         <update_breakpoint_info>: Declare.
4227         (tui_update_breakpoint_info): Don't declare.
4228         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4229         (tui_update_all_breakpoint_info): Update.
4230         (tui_source_window_base::update_breakpoint_info): Rename from
4231         tui_update_breakpoint_info.
4232         (tui_source_window_base::update_exec_info): Update.
4233
4234 2019-08-16  Tom Tromey  <tom@tromey.com>
4235
4236         * tui/tui-winsource.h (struct tui_source_window_base)
4237         <update_source_window>: Declare.
4238         (tui_update_source_window): Don't declare.
4239         * tui/tui-winsource.c
4240         (tui_source_window_base::update_source_window): Rename from
4241         tui_update_source_window.
4242         (tui_source_window_base::rerender): Update.
4243         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4244         * tui/tui-disasm.c (tui_show_disassem)
4245         (tui_show_disassem_and_update_source)
4246         (tui_disasm_window::maybe_update): Update.
4247
4248 2019-08-16  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui-winsource.h (struct tui_source_window_base)
4251         <update_source_window_as_is>: Declare.
4252         (tui_update_source_window_as_is): Don't declare.
4253         * tui/tui-winsource.c (tui_update_source_window): Update
4254         (tui_source_window_base::update_source_window_as_is): Rename from
4255         tui_update_source_window_as_is.
4256         (tui_source_window_base::refill): Update.
4257         * tui/tui-source.c (tui_show_symtab_source): Update.
4258         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4259         Update.
4260
4261 2019-08-16  Tom Tromey  <tom@tromey.com>
4262
4263         * tui/tui-winsource.h (tui_update_source_window)
4264         (tui_update_source_window_as_is): Remove "noerror" parameter.
4265         * tui/tui-winsource.c (tui_update_source_window)
4266         (tui_update_source_window_as_is): Remove "noerror" parameter.
4267         (tui_update_source_windows_with_addr)
4268         (tui_update_source_windows_with_line)
4269         (tui_source_window_base::rerender)
4270         (tui_source_window_base::refill): Update.
4271         * tui/tui-source.h (tui_set_source_content)
4272         (tui_show_symtab_source): Remove "noerror" parameter.
4273         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4274         parameter.
4275         (tui_show_symtab_source): Likewise.
4276         (tui_source_window::maybe_update): Update.
4277         * tui/tui-disasm.c (tui_show_disassem)
4278         (tui_show_disassem_and_update_source)
4279         (tui_disasm_window::do_scroll_vertical)
4280         (tui_disasm_window::maybe_update): Update.
4281
4282 2019-08-16  Tom Tromey  <tom@tromey.com>
4283
4284         * tui/tui.c (tui_is_window_visible): Update.
4285         * tui/tui-wingeneral.c (tui_make_window)
4286         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4287         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4288         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4289         (tui_set_win_height_command, parse_scrolling_args): Update.
4290         * tui/tui-source.c (tui_source_window::style_changed): Update.
4291         * tui/tui-regs.c (tui_show_registers)
4292         (tui_data_window::first_data_item_displayed)
4293         (tui_data_window::delete_data_content_windows)
4294         (tui_check_register_values, tui_reg_command): Update.
4295         * tui/tui-disasm.c (tui_show_disassem): Update.
4296         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4297         method.
4298         <is_visible>: Remove field.
4299         * tui/tui-data.c (tui_next_win, tui_prev_win)
4300         (tui_delete_invisible_windows): Update.
4301
4302 2019-08-16  Tom Tromey  <tom@tromey.com>
4303
4304         * tui/tui-winsource.h (struct tui_source_window_base)
4305         <m_has_locator>: Remove.
4306         * tui/tui-layout.c (show_source_disasm_command, show_data)
4307         (show_source_or_disasm_and_command): Update.
4308
4309 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4310
4311         * NEWS (Other MI changes): New subsection.
4312         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4313         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4314         * arch-utils.c (default_get_pc_address_flags): New function.
4315         * arch-utils.h (default_get_pc_address_flags): New declaration.
4316         * gdbarch.sh: Add get_pc_address_flags.
4317         * gdbarch.c: Regenerate.
4318         * gdbarch.h: Likewise.
4319         * stack.c (print_pc): New function.
4320         (print_frame_info) (print_frame): Call print_pc.
4321
4322 2019-08-16  Tom de Vries  <tdevries@suse.de>
4323
4324         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4325         print_objfile_section_info.
4326
4327 2019-08-15  Tom Tromey  <tom@tromey.com>
4328
4329         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4330         calling update_cmdwin_start_line.
4331         * tui/tui-winsource.h (struct tui_source_window_base)
4332         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4333         <rerender>: Declare.
4334         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4335         Call rerender.
4336         (tui_source_window_base::set_new_height): Remove.
4337         (tui_source_window_base::rerender): Rename from
4338         do_make_visible_with_new_height.
4339         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4340         resize method.
4341         (tui_win_info::make_invisible_and_set_new_height)
4342         (tui_win_info::make_visible_with_new_height): Remove.
4343         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4344         Declare.
4345         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4346         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4347         do_make_visible_with_new_height>: Don't declare.
4348         <rerender>: Declare.
4349         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4350         set_new_height.
4351         (tui_data_window::do_make_visible_with_new_height): Remove.
4352         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4353         call tui_show_locator_content.
4354         (tui_gen_win_info::resize): Call rerender.
4355         (show_source_or_disasm_and_command): Don't call
4356         tui_show_locator_content.
4357         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4358         method.
4359         (struct tui_win_info) <rerender>: Declare.
4360         <set_new_height, make_invisible_and_set_new_height,
4361         make_visible_with_new_height>: Don't declare.
4362         * tui/tui-data.c (tui_win_list::rerender): New method.
4363         * tui/tui-command.h (struct tui_cmd_window)
4364         <do_make_visible_with_new_height>: Don't declare.
4365         * tui/tui-command.c
4366         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4367
4368 2019-08-15  Tom Tromey  <tromey@adacore.com>
4369
4370         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4371         * ada-lang.c (ada_enum_name): Likewise.
4372
4373 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4374
4375         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4376         leading underscore.
4377         (GdbOutputErrorFile): Likewise.
4378         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4379         accordingly.
4380         (execute_unwinders): Rename to have a leading underscore.
4381         (auto_load_packages): Likewise.
4382         (global scope): Adjust call to auto_load_packages accordingly.
4383         (GdbSetPythonDirectory): Likewise.
4384         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4385         instead of execute_unwinders.
4386
4387 2019-08-15  Tom Tromey  <tom@tromey.com>
4388
4389         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4390         (show_data): Don't change window visibility.
4391         (tui_gen_win_info::resize): Remove special case for command
4392         window.  Use wresize, when available.
4393         (show_source_or_disasm_and_command): Don't change window
4394         visibility.
4395         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4396         <make_visible>: New method.
4397         * tui/tui-command.c (tui_cmd_window::resize): New method.
4398
4399 2019-08-15  Tom Tromey  <tom@tromey.com>
4400
4401         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4402         (struct tui_source_windows): New.
4403         * tui/tui-winsource.c (tui_display_main): Update.
4404         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4405         (new_height_ok, parse_scrolling_args): Update.
4406         * tui/tui-layout.c (show_layout, show_data): Update.
4407         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4408         (tui_add_to_source_windows): Don't declare.
4409         * tui/tui-data.c (source_windows, tui_source_windows)
4410         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4411
4412 2019-08-15  Tom Tromey  <tom@tromey.com>
4413
4414         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4415         Rename from reset.
4416         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4417         * tui/tui-layout.c (show_source_disasm_command, show_data):
4418         Update.
4419         (tui_gen_win_info::resize): Rename.
4420         (show_source_or_disasm_and_command): Update.
4421         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4422         reset.
4423
4424 2019-08-15  Tom Tromey  <tom@tromey.com>
4425
4426         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4427         * tui/tui-interp.c (tui_interp::init): Don't call
4428         tui_initialize_static_data.
4429         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4430
4431 2019-08-15  Tom Tromey  <tom@tromey.com>
4432
4433         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4434         examine tui_win_list.
4435
4436 2019-08-15  Tom Tromey  <tom@tromey.com>
4437
4438         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4439         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4440         tui_clear_source_content.
4441         (tui_clear_source_content): Remove.
4442         (tui_source_window_base::do_erase_source_content): Hoist call to
4443         content.clear().
4444         * tui/tui-stack.c (tui_show_frame_info): Don't call
4445         tui_clear_source_content.
4446
4447 2019-08-15  Tom Tromey  <tom@tromey.com>
4448
4449         * tui/tui-winsource.h (struct tui_source_window_base)
4450         <do_erase_source_content>: New method.
4451         <erase_source_content>: New method.
4452         (tui_erase_source_content): Don't declare.
4453         * tui/tui-winsource.c (tui_clear_source_content): Update.
4454         (tui_source_window_base::do_erase_source_content): Rename from
4455         tui_erase_source_content.
4456         (tui_source_window_base::show_source_content): Update.
4457         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4458         * tui/tui-source.h (struct tui_source_window)
4459         <erase_source_content>: New method.
4460         * tui/tui-disasm.h (struct tui_disasm_window)
4461         <erase_source_content>: New method.
4462
4463 2019-08-15  Tom Tromey  <tom@tromey.com>
4464
4465         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4466         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4467         constructor.
4468         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4469         * tui/tui-source.c (tui_set_source_content): Update.
4470         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4471
4472 2019-08-15  Tom Tromey  <tom@tromey.com>
4473
4474         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4475         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4476         tui-source.c.
4477         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4478         Declare.
4479         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4480         method.
4481         (tui_source_window::maybe_update): Update.
4482
4483 2019-08-15  Tom Tromey  <tom@tromey.com>
4484
4485         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4486         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4487         tui-disasm.c.
4488         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4489         Declare.
4490         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4491         method.
4492         (tui_disasm_window::maybe_update): Update.
4493
4494 2019-08-15  Tom Tromey  <tom@tromey.com>
4495
4496         * tui/tui-winsource.h (struct tui_source_window_base)
4497         <maybe_update>: Declare.
4498         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4499         method.
4500         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4501         Declare.
4502         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4503         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4504         Declare.
4505         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4506
4507 2019-08-15  Tom Tromey  <tom@tromey.com>
4508
4509         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4510
4511 2019-08-15  Tom Tromey  <tom@tromey.com>
4512
4513         * tui/tui-wingeneral.c: Include tui-stack.h.
4514         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4515         (struct tui_locator_window): Move from tui-data.h.
4516         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4517         (tui_initialize_static_data): Move from tui-data.c.
4518         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4519         (struct tui_locator_window): Move to tui-stack.c.
4520         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4521         (tui_initialize_static_data): Move to tui-stack.c.
4522
4523 2019-08-15  Tom Tromey  <tom@tromey.com>
4524
4525         * tui/tui-layout.c (show_source_disasm_command)
4526         (show_source_or_disasm_and_command): Use make_visible method, not
4527         tui_make_window.
4528         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4529         Remove.
4530
4531 2019-08-15  Tom Tromey  <tom@tromey.com>
4532
4533         * tui/tui-wingeneral.h (tui_make_window): Update.
4534         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4535         parameter.
4536         (tui_gen_win_info::make_visible): Update.
4537         * tui/tui-regs.c (tui_data_window::display_registers_from):
4538         Update.
4539         * tui/tui-layout.c (show_source_disasm_command)
4540         (show_source_or_disasm_and_command): Update.
4541         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4542         (enum tui_box): Remove.
4543         (struct tui_win_info) <can_box>: New method.
4544         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4545         method.
4546
4547 2019-08-15  Tom de Vries  <tdevries@suse.de>
4548
4549         * linux-nat-trad.c: Include gdbarch.h.
4550
4551 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
4552
4553         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4554         register sizes.
4555
4556 2019-08-14  Tom Tromey  <tromey@adacore.com>
4557
4558         * darwin-nat.c: Include gdbarch.h.
4559         * darwin-nat-info.c: Include gdbarch.h.
4560
4561 2019-08-13  Tom Tromey  <tom@tromey.com>
4562
4563         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4564         Remove.
4565         * tui/tui-data.c (tui_initialize_static_data): Update.
4566
4567 2019-08-13  Tom Tromey  <tom@tromey.com>
4568
4569         * tui/tui-winsource.h (struct tui_exec_info_window)
4570         <~tui_exec_info_window, maybe_allocate_content, get_content,
4571         m_content>: Remove.
4572         (struct tui_source_window_base) <set_exec_info_content,
4573         show_exec_info_content>: Don't declare.
4574         * tui/tui-winsource.c
4575         (tui_exec_info_window::maybe_allocate_content): Remove.
4576         (tui_source_window_base::update_exec_info): Rename from
4577         set_exec_info_content.
4578         (tui_source_window_base::show_exec_info_content)
4579         (tui_source_window_base::update_exec_info): Remove.
4580
4581 2019-08-13  Tom Tromey  <tom@tromey.com>
4582
4583         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4584         declare.
4585         * tui/tui-winsource.c (tui_update_source_window_as_is)
4586         (tui_update_source_windows_with_addr, tui_erase_source_content):
4587         Update.
4588         (tui_clear_exec_info_content): Remove.
4589
4590 2019-08-13  Tom Tromey  <tom@tromey.com>
4591
4592         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4593         declare.
4594         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4595         call tui_erase_exec_info_content.
4596         (tui_clear_exec_info_content): Rename from
4597         tui_erase_exec_info_content.
4598         (tui_clear_exec_info_content): Delete.
4599
4600 2019-08-13  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-winsource.h (struct tui_source_window_base)
4603         <show_exec_info_content>: Declare.
4604         (tui_show_exec_info_content): Don't declare.
4605         * tui/tui-winsource.c
4606         (tui_source_window_base::show_exec_info_content): Rename from
4607         tui_show_exec_info_content.
4608         (tui_source_window_base::update_exec_info): Update.
4609
4610 2019-08-13  Tom Tromey  <tom@tromey.com>
4611
4612         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4613         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4614         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4615         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4616         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4617         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4618         ... here.
4619
4620 2019-08-13  Tom Tromey  <tom@tromey.com>
4621
4622         * tui/tui-winsource.h (struct tui_source_window_base)
4623         <update_exec_info>: Declare.
4624         (tui_update_exec_info): Don't declare.
4625         * tui/tui-winsource.c (tui_update_source_window_as_is)
4626         (tui_source_window_base::refresh_all)
4627         (tui_update_all_breakpoint_info): Update.
4628         (tui_source_window_base::update_exec_info): Rename from
4629         tui_update_exec_info.
4630         * tui/tui-stack.c (tui_show_frame_info): Update.
4631
4632 2019-08-13  Tom Tromey  <tom@tromey.com>
4633
4634         * tui/tui-winsource.h (struct tui_source_window_base)
4635         <set_exec_info_content>: Declare.
4636         (tui_set_exec_info_content): Don't declare.
4637         * tui/tui-winsource.c
4638         (tui_source_window_base::set_exec_info_content): Rename from
4639         tui_set_exec_info_content.
4640         (tui_update_exec_info): Update.
4641
4642 2019-08-13  Tom Tromey  <tom@tromey.com>
4643
4644         * tui/tui-winsource.h (struct tui_source_window_base)
4645         <show_source_content>: Declare.
4646         (tui_show_source_content): Don't declare.
4647         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4648         (tui_source_window_base::show_source_content): Rename from
4649         tui_show_source_content.
4650         (tui_source_window_base::refresh_all): Update.
4651         * tui/tui-layout.c (show_source_disasm_command)
4652         (show_source_or_disasm_and_command): Update.
4653
4654 2019-08-13  Tom Tromey  <tom@tromey.com>
4655
4656         * tui/tui-winsource.c (tui_erase_source_content)
4657         (tui_show_source_content, tui_source_window_base::refresh_all):
4658         Update.
4659         * tui/tui-wingeneral.h
4660         (tui_check_and_display_highlight_if_needed): Don't declare.
4661         * tui/tui-wingeneral.c
4662         (tui_win_info::check_and_display_highlight_if_needed): Rename from
4663         check_and_display_highlight_if_needed.
4664         * tui/tui-win.c (tui_rehighlight_all)
4665         (tui_win_info::make_visible_with_new_height): Update.
4666         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4667         (tui_data_window::erase_data_content)
4668         (tui_data_window::display_all_data): Update.
4669         * tui/tui-data.h (struct tui_win_info)
4670         <check_and_display_highlight_if_needed>: Declare.
4671
4672 2019-08-13  Tom Tromey  <tom@tromey.com>
4673
4674         * tui/tui-win.c (tui_resize_all): Call
4675         tui_delete_invisible_windows.
4676         * tui/tui-layout.c (show_layout): Call
4677         tui_delete_invisible_windows.
4678         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4679         * tui/tui-data.c (tui_delete_invisible_windows): New function.
4680
4681 2019-08-13  Tom Tromey  <tom@tromey.com>
4682
4683         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
4684         tui_add_win_to_layout.
4685
4686 2019-08-13  Tom Tromey  <tom@tromey.com>
4687
4688         * tui/tui-layout.h (tui_default_win_height): Don't declare.
4689         * tui/tui-layout.c (tui_default_win_height): Now static.
4690
4691 2019-08-13  Tom Tromey  <tom@tromey.com>
4692
4693         * tui/tui-layout.c (show_layout): Unify all layout cases into a
4694         single switch.
4695         (show_source_disasm_command, show_source_or_disasm_and_command):
4696         Don't check current layout.
4697
4698 2019-08-13  Tom Tromey  <tom@tromey.com>
4699
4700         * tui/tui-wingeneral.c (make_all_visible): Remove.
4701         (tui_make_all_invisible): Simplify.
4702         * tui/tui-layout.c (tui_make_all_invisible): Move from
4703         tui-wingeneral.c; simplify.
4704         (show_layout): Hoist call to tui_make_all_invisible.
4705         (show_data): Don't call tui_make_all_invisible.
4706
4707 2019-08-13  Tom Tromey  <tom@tromey.com>
4708
4709         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4710         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4711
4712 2019-08-13  Tom Tromey  <tom@tromey.com>
4713
4714         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4715         tui-data.c.
4716         (show_source_disasm_command, show_data)
4717         (show_source_or_disasm_and_command): Don't use
4718         tui_set_current_layout_to.
4719         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4720         * tui/tui-data.c (current_layout, tui_current_layout): Move to
4721         tui-layout.c.
4722         (tui_set_current_layout_to): Remove.
4723
4724 2019-08-13  Tom Tromey  <tom@tromey.com>
4725
4726         * tui/tui-layout.c (tui_set_layout): Update.
4727         * tui/tui-data.h (struct tui_layout_def): Remove.
4728         (tui_layout_def): Don't declare.
4729         * tui/tui-data.c (layout_def): Remove.
4730         (tui_layout_def): Remove.
4731
4732 2019-08-13  Tom Tromey  <tom@tromey.com>
4733
4734         * tui/tui-winsource.h (struct tui_source_window_base)
4735         <clear_detail>: No longer "override".
4736         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4737         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4738         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4739         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4740         Remove.
4741         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4742
4743 2019-08-13  Tom Tromey  <tromey@adacore.com>
4744
4745         * tracepoint.c: Don't include readline.h or history.h.
4746
4747 2019-08-12  Tom Tromey  <tom@tromey.com>
4748
4749         * configure: Rebuild.
4750         * configure.ac: Check for readline 7.
4751         * NEWS: Mention readline 7 requirement.
4752         * README: Update.
4753
4754 2019-08-12  Tom Tromey  <tom@tromey.com>
4755
4756         * mingw-hdep.c (gdb_select): Remove readline hack.
4757
4758 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4759
4760         * blockframe.c (find_pc_partial_function): Set *block to nullptr
4761         when the function fails.
4762
4763 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
4764
4765         * s390-tdep.c (s390_type_align): New function.
4766         (s390_gdbarch_init): Set it as type_align gdbarch method.
4767
4768 2019-08-09  Tom de Vries  <tdevries@suse.de>
4769
4770         PR gdb/24591
4771         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
4772         pc_low with relocation offset.
4773
4774 2019-08-07  Tom Tromey  <tromey@adacore.com>
4775
4776         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4777         (print_frame_args): Update.
4778         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
4779         Update.
4780         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4781         * frame.h (struct frame_arg): Add initializers.
4782         <error>: Now a unique_xmalloc_ptr.
4783
4784 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
4785
4786         * NEWS: Expand the Pointer Authentication entry.
4787         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
4788         (aarch64_frame_unmask_lr): ... to this.
4789         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
4790         Call aarch64_frame_unmask_lr.
4791         * frame.c (struct frame_info): Add "masked" variable.
4792         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
4793         (fprint_frame): Check for masked pc.
4794         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
4795         declarations.
4796         * python/py-framefilter.c (py_print_frame): Check for masked pc.
4797         * stack.c (print_frame): Check for masked pc.
4798
4799 2019-08-06  Tom Tromey  <tom@tromey.com>
4800
4801         * stabsread.c (patch_block_stabs, read_one_struct_field)
4802         (read_enum_type): Use obstack_strndup.
4803         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
4804         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
4805         * dwarf2read.c (guess_full_die_structure_name)
4806         (anonymous_struct_prefix): Use obstack_strndup.
4807         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
4808         * c-exp.y (yylex): Use obstack_strndup.
4809         * ada-exp.y (write_object_renaming, write_ambiguous_var)
4810         (write_var_or_type): Use obstack_strndup.
4811
4812 2019-08-06  Tom Tromey  <tom@tromey.com>
4813
4814         * symfile.c (reread_symbols): Use obstack_strdup.
4815         * stabsread.c (read_type): Use obstack_strdup.
4816         * gdb_obstack.h (obstack_strdup): New overload.
4817         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
4818         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
4819         (dwarf2_canonicalize_name): Use obstack_strdup.
4820         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
4821         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
4822         Use obstack_strdup.
4823
4824 2019-08-06  Tom Tromey  <tom@tromey.com>
4825
4826         * gdb_obstack.h (obstack_strdup): Define.
4827         * gdb_obstack.c (obstack_strdup): Don't define.
4828
4829 2019-08-06  Tom Tromey  <tom@tromey.com>
4830
4831         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4832         obstack_strdup.
4833         * typeprint.c (typedef_hash_table::find_global_typedef): Use
4834         obstack_strdup.
4835         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4836         * stabsread.c (common_block_start): Use obstack_strdup.
4837         * objfiles.c (set_objfile_main_name, objfile): Use
4838         obstack_strdup.
4839         * namespace.c (add_using_directive): Use obstack_strdup.
4840         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
4841         * jit.c (finalize_symtab): Use obstack_strdup.
4842         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
4843         (guess_partial_die_structure_name, partial_die_info::fixup)
4844         (dwarf2_name): Use obstack_strdup.
4845         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
4846         obstack_strdup.
4847         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
4848         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4849         obstack_strdup.
4850         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
4851
4852 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4853
4854         * unittests/help-doc-selftests.c: New file.
4855         * Makefile.in: Add the new file.
4856
4857 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4858
4859         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4860         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
4861         the full first line, except when FOR_VALUE_PREFIX.  In this case,
4862         the trailing '.' is not output, and the first character is uppercased.
4863         (print_help_for_command): Update call to print_doc_line.
4864         (print_doc_of_command): Likewise.
4865         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4866         * cli/cli-option.c (append_indented_doc): Do not append newline.
4867         (build_help_option): Append newline after first appended_indented_doc
4868         only if a second call is done.
4869         (build_help): Append 2 new lines before each option, except the first
4870         one.
4871         * compile/compile.c (_initialize_compile): Add new lines after
4872         %OPTIONS%, when not at the end of the help.
4873         Change help doc or code
4874         producing the help doc to respect the invariants.
4875         * maint-test-options.c (_initialize_maint_test_options): Likewise.
4876         Also removed the new line after 'Options:', as all other commands
4877         do not put an empty line between 'Options:' and the first option.
4878         * printcmd.c (_initialize_printcmd): Likewise.
4879         * stack.c (_initialize_stack): Likewise.
4880         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4881         incorrectly telling COMMAND is optional.
4882         * ada-lang.c (_initialize_ada_language): Change help doc or code
4883         producing the help doc to respect the invariants.
4884         * ada-tasks.c (_initialize_ada_tasks): Likewise.
4885         * breakpoint.c (_initialize_breakpoint): Likewise.
4886         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4887         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4888         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4889         * cli/cli-style.c (cli_style_option::add_setshow_commands,
4890         _initialize_cli_style): Likewise.
4891         * corelow.c (core_target_info): Likewise.
4892         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4893         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4894         * filesystem.c (_initialize_filesystem): Likewise.
4895         * frame.c (_initialize_frame): Likewise.
4896         * gnu-nat.c (add_task_commands): Likewise.
4897         * infcall.c (_initialize_infcall): Likewise.
4898         * infcmd.c (_initialize_infcmd): Likewise.
4899         * interps.c (_initialize_interpreter): Likewise.
4900         * language.c (_initialize_language): Likewise.
4901         * linux-fork.c (_initialize_linux_fork): Likewise.
4902         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4903         * maint.c (_initialize_maint_cmds): Likewise.
4904         * memattr.c (_initialize_mem): Likewise.
4905         * printcmd.c (_initialize_printcmd): Likewise.
4906         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4907         _RegEx): Likewise.
4908         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4909         * record-btrace.c (_initialize_record_btrace): Likewise.
4910         * record-full.c (_initialize_record_full): Likewise.
4911         * record.c (_initialize_record): Likewise.
4912         * regcache-dump.c (_initialize_regcache_dump): Likewise.
4913         * regcache.c (_initialize_regcache): Likewise.
4914         * remote.c (add_packet_config_cmd, init_remote_threadtests,
4915         _initialize_remote): Likewise.
4916         * ser-tcp.c (_initialize_ser_tcp): Likewise.
4917         * serial.c (_initialize_serial): Likewise.
4918         * skip.c (_initialize_step_skip): Likewise.
4919         * source.c (_initialize_source): Likewise.
4920         * stack.c (_initialize_stack): Likewise.
4921         * symfile.c (_initialize_symfile): Likewise.
4922         * symtab.c (_initialize_symtab): Likewise.
4923         * target-descriptions.c (_initialize_target_descriptions): Likewise.
4924         * top.c (init_main): Likewise.
4925         * tracefile-tfile.c (tfile_target_info): Likewise.
4926         * tracepoint.c (_initialize_tracepoint): Likewise.
4927         * tui/tui-win.c (_initialize_tui_win): Likewise.
4928         * utils.c (add_internal_problem_command): Likewise.
4929         * valprint.c (value_print_option_defs): Likewise.
4930
4931 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
4932
4933         PR build/24886
4934         * configure.ac: Drop enable-libmcheck support.
4935         * configure, config.in: Rebuild.
4936         * libmcheck.m4: Remove.
4937         * acinclude.m4: Don't include it.
4938         * Makefile.in: Don't distribute it.
4939         * top.c (print_gdb_configuration): Don't mention it.
4940
4941 2019-08-06  Tom Tromey  <tom@tromey.com>
4942
4943         * utils.c (set_output_style): Sometimes pass stream to
4944         emit_style_escape.
4945         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4946         * record-btrace.c (btrace_insn_history): Update.
4947         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4948         method.
4949         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4950         Update initializers.
4951         <m_uiout>: New field.
4952         <m_di>: Move lower.
4953         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4954         Remove "uiout" parameter.
4955         (dump_insns): Update.
4956         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4957         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4958
4959 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
4960
4961         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4962         (error_in_psymtab_expansion): Likewise.
4963         (lookup_symbol_via_quick_fns): Likewise.
4964         (basic_lookup_transparent_type_quick): Likewise.
4965         (basic_lookup_transparent_type_1): Likewise.
4966
4967 2019-08-06  Tom Tromey  <tromey@adacore.com>
4968
4969         * source.c (last_source_error): Now bool.
4970         (print_source_lines_base): Make "noprint" bool.  Only open
4971         source file when last_source_visited changes.
4972
4973 2019-08-06  Tom Tromey  <tromey@adacore.com>
4974
4975         * annotate.c (annotate_source_line): Use g_source_cache.
4976         * source-cache.c (source_cache::get_plain_source_lines): Change
4977         parameters.  Populate m_offset_cache.
4978         (source_cache::ensure): New method.
4979         (source_cache::get_line_charpos): New method.
4980         (extract_lines): Move lower.  Change parameters.
4981         (source_cache::get_source_lines): Move lower.
4982         * source-cache.h (class source_cache): Update comment.
4983         <get_line_charpos>: New method.
4984         <get_source_lines>: Update comment.
4985         <clear>: Clear m_offset_cache.
4986         <get_plain_source_lines>: Change parameters.
4987         <ensure>: New method
4988         <m_offset_cache>: New member.
4989         * source.c (forget_cached_source_info_for_objfile): Update.
4990         (info_source_command): Use g_source_cache.
4991         (find_source_lines, open_source_file_with_line_charpos): Remove.
4992         (print_source_lines_base, search_command_helper): Use g_source_cache.
4993         * source.h (open_source_file_with_line_charpos): Don't declare.
4994         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4995         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4996         Use g_source_cache.
4997
4998 2019-08-06  Tom Tromey  <tromey@adacore.com>
4999
5000         * source-cache.c (source_cache::get_plain_source_lines):
5001         Remove "first_line" and "last_line" parameters.
5002         (source_cache::get_source_lines): Cache plain text.
5003         * source-cache.h (class source_cache)
5004         <get_plain_source_lines>: Update.
5005
5006 2019-08-06  Tom Tromey  <tromey@adacore.com>
5007
5008         * source-cache.c (extract_lines): No longer a method.
5009         Changed type of parameter.  Include final newline.
5010         (selftests::extract_lines_test): New function.
5011         (_initialize_source_cache): Likewise.
5012         * source-cache.h (class source_cache)
5013         <extract_lines>: Don't declare.
5014
5015 2019-08-06  Tom Tromey  <tromey@adacore.com>
5016
5017         * breakpoint.c (init_breakpoint_sal): Update.
5018         (breakpoint): Update.
5019         * breakpoint.h (struct breakpoint) <filter>: Now a
5020         unique_xmalloc_ptr.
5021
5022 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5023
5024         * NEWS: Mention dictionary access on blocks.
5025         * python/py-block.c (blpy_getitem): New function.
5026         (block_object_as_mapping): New struct.
5027         (block_object_type): Use new struct for tp_as_mapping field.
5028
5029 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5030
5031         * objfiles.h (objfile): Add a comment describing partial symbols.
5032
5033 2019-08-05  Tom Tromey  <tromey@adacore.com>
5034
5035         * compile/compile.c (_initialize_compile): Use _(), not N_().
5036         * thread.c (_initialize_thread): Use _(), not N_().
5037         * stack.c (_initialize_stack): Use _(), not N_().
5038         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5039
5040 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5041
5042         * dwarf2read.c (struct dw2_symtab_iterator):
5043         <want_specific_block>: Remove.
5044         <block_index>: Change type to gdb::optional.
5045         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5046         change type of BLOCK_INDEX parameter to gdb::optional.
5047         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5048         (dw2_lookup_symbol): Don't pass argument for
5049         WANT_SPECIFIC_BLOCK.
5050         (dw2_expand_symtabs_for_function): Don't pass argument for
5051         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5052         (class dw2_debug_names_iterator)
5053         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5054         parameter, change BLOCK_INDEX type to gdb::optional.
5055         <m_want_specific_block>: Remove.
5056         <m_block_index>: Change type to gdb::optional.
5057         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5058         gdb::optional.  Re-write in function of gdb::optional.
5059         (dw2_debug_names_lookup_symbol): Don't pass argument for
5060         WANT_SPECIFIC_BLOCK.
5061         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5062         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5063         BLOCK_INDEX.
5064
5065 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5066
5067         * NEWS: Mention changes to "info sources" command.
5068
5069 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5070
5071         * symtab.c (filename_partial_match_opts): New struct type.
5072         (struct output_source_filename_data): New members
5073         regexp, c_regexp, partial_match.
5074         (output_source_filename): Use new members to decide to print file.
5075         (info_sources_option_defs): New variable.
5076         (make_info_sources_options_def_group, print_info_sources_header,
5077         info_sources_command_completer):
5078         New functions.
5079         (info_sources_command): Read new optional arguments.
5080         (_initialize_symtab): Update info sources help.
5081
5082 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5083
5084         * ada-lang.c (exception_support_info_v0): Renamed from...
5085         (default_exception_support_info): ... this.  Create new
5086         definition for v1.
5087         (ada_has_this_exception_support): Look up catch_handlers_sym.
5088         (ada_exception_support_info_sniffer): Try v0 after default.
5089
5090 2019-08-01  Tom Tromey  <tromey@adacore.com>
5091
5092         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5093         gdbarch.h.
5094
5095 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5096
5097         * s12z-tdep.c: Fix include path for s12z-opc.h.
5098
5099 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5100
5101         * NEWS: Require GNU make 3.82.
5102
5103 2019-07-16  Tom Tromey  <tom@tromey.com>
5104
5105         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5106         declare.
5107
5108 2019-07-30  Tom Tromey  <tromey@adacore.com>
5109
5110         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5111
5112 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5113
5114         * printcmd.c (print_address_symbolic): Print negative offsets.
5115         (build_address_symbolic): Force signed arithmetic when computing
5116         offset.
5117
5118 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5119
5120         PR/24474: Add a function to lookup static variables.
5121         * NEWS: Mention this new function.
5122         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5123         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5124         * python/python.c (python_GdbMethods): Add new function.
5125
5126 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5127
5128         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5129         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5130         (objfpy_lookup_static_symbol): New function.
5131         (objfile_object_methods): Add new functions.
5132
5133 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5134
5135         * NEWS: Mention 'set|show print frame-info'.  Mention new
5136         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5137         backtrace argument.  Mention that python frame filtering code
5138         is now consistent with what 'backtrace' command prints.
5139
5140 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5141
5142         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5143         comments.
5144         (print_frame_info_auto, print_frame_info_source_line,
5145         print_frame_info_location, print_frame_info_source_and_location,
5146         print_frame_info_location_and_address, print_frame_info_short_location):
5147         New declarations.
5148         (struct frame_print_options): New member print_frame_info.
5149         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5150         * stack.h (get_user_print_what_frame_info): New declaration.
5151         (frame_show_address): New declaration.
5152         * stack.c (print_frame_arguments_choices): New value 'presence'.
5153         (print_frame_info_auto, print_frame_info_source_line,
5154         print_frame_info_location, print_frame_info_source_and_location,
5155         print_frame_info_location_and_address, print_frame_info_short_location,
5156         print_frame_info_choices, print_frame_info_print_what): New definitions.
5157         (print_frame_args): Only print dots for args if print frame-arguments
5158         is 'presence'.
5159         (frame_print_option_defs): New element for "frame-info".
5160         (get_user_print_what_frame_info): New function.
5161         (frame_show_address): Make non static.  Move comment to stack.h.
5162         (print_frame_info_to_print_what): New function.
5163         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5164         to decide what to print.
5165         (backtrace_command_1): Handle the new print_frame_arguments_presence
5166         value.
5167         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5168         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5169         (py_print_frame): In non-mi mode, use LOCATION as default for
5170         print_what, similarly to frame information printed directly by
5171         backtrace command. Handle frame-info user option in non MI mode.
5172
5173 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5174
5175         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5176         Add case for debugging 32-bit target on 64-bit host.  Revise
5177         comment.
5178
5179 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5180
5181         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5182         instead of find_function_entry_range_from_pc.
5183
5184 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5185
5186         * stack.c (find_frame_funname): Remove code which preferred
5187         minsym over symtab sym in "certain pathological cases".
5188
5189         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5190         parameter.  Change type of "do_demangle" to bool.
5191         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5192         Pass suitable "prefer_sym_over_minsym" flag to
5193         build_address_symbolic().  Don't output "+" for negative offsets.
5194         * printcmd.c (print_address_symbolic): Update invocation of
5195         build_address_symbolic to include a "prefer_sym_over_minsym"
5196         flag.
5197         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5198         Restrict cases in which use of minimal symbol is preferred to that
5199         of a found symbol.  Update comments.
5200
5201         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5202         for entry pc when entry pc is out of range for that FDE.
5203
5204 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5205
5206         PR gdb/24839:
5207         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5208         type.
5209
5210 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5211
5212         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5213         this function's Python signature.
5214
5215
5216 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5217
5218         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5219         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5220         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5221         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5222         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5223
5224
5225 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5226
5227         * h8300-tdep.c (h8300_register_name_common): New.
5228         h8300_register_name): Use h8300_register_name_common.
5229         (h8300s_register_name): Likewise.
5230         (h8300sx_register_name): Likewise.
5231         (h8300h_register_nam): New.
5232         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5233
5234
5235 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5236
5237         * arm-tdep.c (arm_skip_cmse_entry): New function.
5238         (arm_is_sgstubs_section): New function.
5239         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5240
5241 2019-07-22  Tom Tromey  <tom@tromey.com>
5242
5243         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5244         Don't self-assign.
5245
5246 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5247
5248         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5249         type_print.
5250
5251 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5252
5253         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5254         so that GDB doesn't match any msymbols when searching in the
5255         TYPES_DOMAIN.
5256         (print_symbol_info): Print using typedef_print or type_print based
5257         on the type of the symbol.  Add updated FIXME comment moved from...
5258         (_initialize_symtab): ... move and update FIXME comment to above.
5259
5260 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5261
5262         * NEWS: Mention adding -q option to "info types".
5263         * symtab.c (struct info_types_options): New struct.
5264         (info_types_options_defs): New variable.
5265         (make_info_types_options_def_group): New function.
5266         (info_types_command): Use gdb::option framework to parse options.
5267         (info_types_command_completer): New function.
5268         (_initialize_symtab): Extend the help text on "info types" and
5269         register command completer.
5270
5271 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5272
5273         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5274         (lookup_symbol_in_objfile): Change int to block_enum and add a
5275         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5276
5277 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5278
5279         * MAINTAINERS (Write After Approval): Add self.
5280
5281 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5282
5283         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5284         instruction to the dummy code region.
5285
5286 2019-07-19  Tom Tromey  <tromey@adacore.com>
5287
5288         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5289         (ARGSUSED, PARAMS, __func__): Remove rules.
5290
5291 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5292
5293         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5294         * features/arm/arm-with-iwmmxt.c: Remove.
5295         * features/arm/arm-with-iwmmxt.xml: Remove.
5296         * features/arm/arm-with-m-fpa-layout.c: Remove.
5297         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5298         * features/arm/arm-with-m-vfp-d16.c: Remove.
5299         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5300         * features/arm/arm-with-m.c: Remove.
5301         * features/arm/arm-with-m.xml: Remove.
5302         * features/arm/arm-with-neon.c: Remove.
5303         * features/arm/arm-with-neon.xml: Remove.
5304         * features/arm/arm-with-vfpv2.c: Remove.
5305         * features/arm/arm-with-vfpv2.xml: Remove.
5306         * features/arm/arm-with-vfpv3.c: Remove.
5307         * features/arm/arm-with-vfpv3.xml: Remove.
5308
5309 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5310
5311         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5312
5313 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5314
5315         * arch/aarch32.c (aarch32_create_target_description): Create
5316         target descriptions using features.
5317         * arch/arm.c (arm_create_target_description)
5318         (arm_create_mprofile_target_description): Likewise.
5319         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5320
5321 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5322
5323         * Makefile.in: Add new files.
5324         * aarch32-tdep.c: New file.
5325         * aarch32-tdep.h: New file.
5326         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5327         Call aarch32_read_description.
5328         * arch/aarch32.c: New file.
5329         * arch/aarch32.h: New file.
5330         * arch/arm.c (arm_create_target_description)
5331         (arm_create_mprofile_target_description): New function.
5332         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5333         (arm_create_target_description)
5334         (arm_create_mprofile_target_description): New declaration.
5335         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5336         read_description functions.
5337         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5338         Likewise.
5339         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5340         * arm-tdep.c (tdesc_arm_list): New variable.
5341         (arm_register_g_packet_guesses): Call create description functions.
5342         (arm_read_description) (arm_read_mprofile_description): New
5343         function.
5344         * arm-tdep.h (arm_read_description)
5345         (arm_read_mprofile_description): Add declaration.
5346         * configure.tgt: Add new files.
5347
5348 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5349
5350         * top.c (new_ui_command): Open specified terminal just once.
5351
5352 2019-07-18  Tom Tromey  <tromey@adacore.com>
5353
5354         * symtab.c (main_name): Constify return type.
5355         * symfile.c (set_initial_language): Update.
5356         * symtab.h (main_name): Constify return type.
5357
5358 2019-07-17  Tom Tromey  <tom@tromey.com>
5359
5360         * tui/tui-winsource.c (tui_update_source_window)
5361         (tui_update_source_window_as_is)
5362         (tui_update_source_windows_with_line): Remove return.
5363         * tui/tui-disasm.c (tui_show_disassem)
5364         (tui_show_disassem_and_update_source): Remove return.
5365         * tui/tui.c (tui_reset): Remove return.
5366         * tui/tui-wingeneral.c
5367         (tui_check_and_display_highlight_if_needed): Remove return.
5368
5369 2019-07-17  Tom Tromey  <tom@tromey.com>
5370
5371         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5372
5373 2019-07-17  Tom Tromey  <tom@tromey.com>
5374
5375         * tui/tui-winsource.h (struct tui_exec_info_window)
5376         (struct tui_source_window_base): Move from tui-data.h.
5377         * tui/tui-winsource.c: Move many method definitions from
5378         elsewhere.  Remove "structuring" comments.
5379         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5380         (tui_source_window_base::refresh_window): Move to
5381         tui-winsource.c.
5382         * tui/tui-win.c (tui_source_window_base::refresh_all)
5383         (tui_source_window_base::update_tab_width)
5384         (tui_source_window_base::set_new_height)
5385         (tui_source_window_base::do_make_visible_with_new_height): Move to
5386         tui-winsource.c.
5387         * tui/tui-source.h: Update.
5388         * tui/tui-source.c (tui_source_window_base::reset): Move to
5389         tui-winsource.c.
5390         * tui/tui-disasm.h: Update.
5391         * tui/tui-data.h (struct tui_exec_info_window): Move to
5392         tui-winsource.h.
5393         (struct tui_source_window_base): Likewise.
5394         * tui/tui-data.c (tui_source_window_base::clear_detail)
5395         (tui_source_window_base, ~tui_source_window_base): Move to
5396         tui-winsource.c.
5397
5398 2019-07-17  Tom Tromey  <tom@tromey.com>
5399
5400         * tui/tui-win.c (tui_resize_all)
5401         (tui_source_window_base::update_tab_width)
5402         (tui_adjust_win_heights): Update.
5403         (tui_win_info::make_invisible_and_set_new_height): Rename from
5404         make_invisible_and_set_new_height.
5405         * tui/tui-data.h (struct tui_win_info)
5406         <make_invisible_and_set_new_height>: New method.
5407
5408 2019-07-17  Tom Tromey  <tom@tromey.com>
5409
5410         * tui/tui.c: Update.
5411         * tui/tui-source.h (struct tui_source_window): Move from
5412         tui-data.h.
5413         * tui/tui-layout.c: Update.
5414         * tui/tui-disasm.c: Update.
5415         * tui/tui-data.h (struct tui_source_window): Move to
5416         tui-source.h.
5417
5418 2019-07-17  Tom Tromey  <tom@tromey.com>
5419
5420         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5421         tui-data.h.
5422         * tui/tui-data.h (struct tui_disasm_window): Move to
5423         tui-disasm.h.
5424
5425 2019-07-17  Tom Tromey  <tom@tromey.com>
5426
5427         * tui/tui-regs.h (struct tui_data_item_window): Move from
5428         tui-data.h.
5429         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5430         * tui/tui-data.h (struct tui_data_item_window): Move to
5431         tui-regs.h.
5432         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5433
5434 2019-07-17  Tom Tromey  <tom@tromey.com>
5435
5436         * tui/tui.c: Update.
5437         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5438         (tui_cmd_window::max_height): Move to tui-command.c.
5439         * tui/tui-layout.c: Update.
5440         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5441         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5442         tui-command.c.
5443         * tui/tui-command.h (struct tui_cmd_window): Move from
5444         tui-data.h.
5445         * tui/tui-command.c: Remove "structuring" comments.
5446         (tui_cmd_window::clear_detail)
5447         (tui_cmd_window::do_make_visible_with_new_height)
5448         (tui_cmd_window::max_height): Move from elsewhere.
5449
5450 2019-07-17  Tom Tromey  <tom@tromey.com>
5451
5452         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5453         Now static.
5454         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5455         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5456
5457 2019-07-17  Tom Tromey  <tom@tromey.com>
5458
5459         * tui/tui.c: Update.
5460         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5461         tui-regs.c.
5462         * tui/tui-windata.h: Remove file.
5463         * tui/tui-windata.c: Remove file.
5464         * tui/tui-win.c (tui_data_window::set_new_height)
5465         (tui_data_window::do_make_visible_with_new_height): Move to
5466         tui-regs.c.
5467         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5468         * tui/tui-regs.c: Remove "structuring" comments.
5469         (tui_data_window::first_data_item_displayed)
5470         (tui_data_window::delete_data_content_windows)
5471         (tui_data_window::erase_data_content)
5472         (tui_data_window::display_all_data)
5473         (tui_data_window::refresh_all)
5474         (tui_data_window::do_scroll_vertical)
5475         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5476         (tui_data_window::do_make_visible_with_new_height)
5477         (tui_data_window::refresh_window): Move from elsewhere.
5478         (_initialize_tui_regs): Move to end of file.
5479         * tui/tui-layout.c: Update.
5480         * tui/tui-hooks.c: Update.
5481         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5482         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5483         tui-regs.c.
5484         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5485
5486 2019-07-17  Tom Tromey  <tom@tromey.com>
5487
5488         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5489         seen.
5490
5491 2019-07-17  Tom Tromey  <tom@tromey.com>
5492
5493         * tui/tui-win.c (tui_source_window_base::set_new_height)
5494         (tui_source_window_base::do_make_visible_with_new_height): Use
5495         m_has_locator field directly.
5496         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5497         method.
5498         (struct tui_source_window_base) <has_locator>: Likewise.
5499
5500 2019-07-17  Tom Tromey  <tom@tromey.com>
5501
5502         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5503         Don't declare.
5504         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5505         Remove.
5506         * tui/tui-win.c (tui_source_window_base::set_new_height)
5507         (tui_source_window_base::set_new_height)
5508         (make_invisible_and_set_new_height)
5509         (tui_source_window_base::do_make_visible_with_new_height)
5510         (tui_source_window_base::do_make_visible_with_new_height):
5511         Update.
5512         * tui/tui-layout.c (show_source_disasm_command, show_data)
5513         (show_source_or_disasm_and_command): Update.
5514         * tui/tui-layout.c (show_layout): Update.
5515
5516 2019-07-17  Tom Tromey  <tom@tromey.com>
5517
5518         * tui/tui-layout.c (make_data_window): Remove.
5519         (show_data): Unify creation and re-initialization cases.
5520
5521 2019-07-17  Tom Tromey  <tom@tromey.com>
5522
5523         * tui/tui-layout.c (make_source_window, make_disasm_window):
5524         Remove.
5525         (show_data): Unify creation and re-initialization cases.
5526
5527 2019-07-17  Tom Tromey  <tom@tromey.com>
5528
5529         * tui/tui-layout.c (make_command_window): Remove.
5530         (show_source_disasm_command, show_source_or_disasm_and_command):
5531         Unify creation and re-initialization cases.
5532
5533 2019-07-17  Tom Tromey  <tom@tromey.com>
5534
5535         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5536         creation and re-initialization cases.
5537
5538 2019-07-17  Tom Tromey  <tom@tromey.com>
5539
5540         * tui/tui-regs.c (tui_get_register): Return void.
5541
5542 2019-07-17  Tom Tromey  <tom@tromey.com>
5543
5544         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5545         Simplify.
5546
5547 2019-07-17  Tom Tromey  <tom@tromey.com>
5548
5549         * tui/tui-layout.c (show_source_disasm_command): Simplify window
5550         resetting.
5551
5552 2019-07-17  Tom Tromey  <tom@tromey.com>
5553
5554         * tui/tui.h (tui_set_layout_by_name): Don't declare.
5555         * tui/tui-regs.c (tui_reg_layout): New function.
5556         (tui_show_registers, tui_reg_command): Use it.
5557         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5558         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
5559         parameters.
5560         (tui_layout_command): Remove.
5561
5562 2019-07-17  Tom Tromey  <tom@tromey.com>
5563
5564         * tui/tui-layout.h (tui/tui-layout): Return void.
5565         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
5566
5567 2019-07-17  Tom Tromey  <tom@tromey.com>
5568
5569         * tui/tui-layout.c (show_source_disasm_command, show_data):
5570         Update.
5571         (reset_locator): Remove.
5572         (show_source_or_disasm_and_command): Update.
5573
5574 2019-07-17  Tom Tromey  <tom@tromey.com>
5575
5576         * tui/tui-source.c (tui_source_window_base::reset): Remove
5577         win_type parameter.
5578         * tui/tui-layout.c (make_command_window, make_source_window)
5579         (make_disasm_window, make_data_window)
5580         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5581         (reset_locator, show_source_or_disasm_and_command): Update.
5582         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5583         win_type parameter.
5584         (struct tui_source_window_base) <reset>: Likewise.
5585
5586 2019-07-17  Tom Tromey  <tom@tromey.com>
5587
5588         * tui/tui-layout.c (show_source_disasm_command): Use
5589         reset_locator.
5590         (reset_locator): New function.
5591         (init_and_make_win): Remove.
5592         (show_source_or_disasm_and_command): Use reset_locator.
5593
5594 2019-07-17  Tom Tromey  <tom@tromey.com>
5595
5596         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5597         condition.
5598         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5599         Remove condition.
5600         * tui/tui-source.c (tui_source_window_base::reset): New method.
5601         * tui/tui-layout.c (make_command_window): Don't call
5602         init_and_make_win.
5603         (make_source_window, make_disasm_window): Don't call
5604         make_source_or_disasm_window.
5605         (make_data_window): Don't call init_and_make_win.  Change calling
5606         convention.
5607         (show_source_disasm_command, show_data): Simplify.
5608         (make_source_or_disasm_window): Remove.
5609         (show_source_or_disasm_and_command): Simplify.
5610         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5611         (struct tui_source_window_base) <reset>: Likewise.
5612         <execution_info>: Remove initializer.
5613         * tui/tui-data.c (tui_source_window_base): Initialize
5614         execution_info.
5615
5616 2019-07-17  Tom Tromey  <tom@tromey.com>
5617
5618         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5619         variable.
5620
5621 2019-07-17  Tom Tromey  <tom@tromey.com>
5622
5623         * tui/tui.c (tui_rl_other_window): Update.
5624         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5625         superclass method first.  Always iterate over regs_content.
5626         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5627         method.
5628         * tui/tui-win.c (tui_set_focus_command): Update.
5629
5630 2019-07-17  Tom Tromey  <tom@tromey.com>
5631
5632         * tui/tui-win.c (tui_set_focus_command): Rename from
5633         tui_set_focus.  Call tui_enable.
5634         (tui_set_focus_command): Remove.
5635
5636 2019-07-17  Tom Tromey  <tom@tromey.com>
5637
5638         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5639         refresh_window.
5640         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5641         touchwin.
5642         (tui_data_window::refresh_window): Call refresh_window on data
5643         items.  Always call superclass refresh_window.
5644         (tui_win_info::refresh): Remove.
5645         (tui_source_window_base::refresh_window): Update.
5646         (tui_refresh_all): Update.
5647         * tui/tui-layout.c (show_source_disasm_command): Remove call to
5648         refresh_window.
5649         (show_source_or_disasm_and_command): Likewise.
5650         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5651         (struct tui_source_window_base) <refresh>: Likewise.
5652
5653 2019-07-17  Tom Tromey  <tom@tromey.com>
5654
5655         * tui/tui-winsource.c (tui_clear_source_content)
5656         (tui_show_source_content): Update.
5657         * tui/tui-source.c (tui_source_window::showing_source_p): Check
5658         whether content is empty.
5659         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5660         Remove.
5661
5662 2019-07-17  Tom Tromey  <tom@tromey.com>
5663
5664         * tui/tui-winsource.c (tui_erase_source_content): Clear the
5665         window's contents.
5666         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5667         * tui/tui-source.c (tui_set_source_content_nil): Remove.
5668
5669 2019-07-17  Tom Tromey  <tom@tromey.com>
5670
5671         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5672         (struct tui_data_item_window): Update.
5673
5674 2019-07-17  Tom Tromey  <tom@tromey.com>
5675
5676         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5677         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5678         defines.
5679
5680 2019-07-17  Tom Tromey  <tom@tromey.com>
5681
5682         * tui/tui-winsource.h (tui_erase_source_content)
5683         (tui_clear_source_content): Remove "display_prompt" parameter.
5684         * tui/tui-winsource.c (tui_update_source_window_as_is)
5685         (tui_update_source_windows_with_addr): Update.
5686         (tui_clear_source_content): Remove "display_prompt" parameter.
5687         (tui_erase_source_content): Likewise.  Simplify.
5688         (tui_show_source_content): Update.
5689         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5690         * tui/tui-stack.c (tui_show_frame_info): Update.
5691         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5692         Remove defines.
5693
5694 2019-07-17  Tom Tromey  <tom@tromey.com>
5695
5696         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5697         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5698         parameter.
5699         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5700         parameter.
5701
5702 2019-07-17  Tom Tromey  <tom@tromey.com>
5703
5704         * tui/tui-winsource.c (tui_clear_source_content)
5705         (tui_show_source_content, tui_show_exec_info_content)
5706         (tui_clear_exec_info_content): Update.
5707         * tui/tui-stack.c (tui_show_locator_content): Update.
5708         (tui_show_frame_info): Update.
5709         * tui/tui-source.h (tui_source_window): Don't declare.
5710         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5711         from tui_source_is_displayed.
5712         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5713         Remove field.
5714         (struct tui_source_window_base) <content_in_use>: New field.  Now
5715         bool.
5716         (struct tui_source_window) <showing_source_p>: New method.
5717         (TUI_SRC_WIN): Change cast.
5718         * tui/tui-data.c (tui_initialize_static_data): Update.
5719
5720 2019-07-17  Tom Tromey  <tom@tromey.com>
5721
5722         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5723         location_matches_p.
5724         * tui/tui-source.c (tui_source_window::location_matches_p): New
5725         method.
5726         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5727         method.
5728         * tui/tui-data.h (struct tui_source_window_base)
5729         <location_matches_p>: New method.
5730         (struct tui_source_window, struct tui_disasm_window)
5731         <location_matches_p>: Likewise.
5732
5733 2019-07-17  Tom Tromey  <tom@tromey.com>
5734
5735         * tui/tui-win.c (tui_set_win_height_command): Rename from
5736         tui_set_win_height.
5737         (tui_set_win_height_command): Remove.
5738
5739 2019-07-17  Tom Tromey  <tom@tromey.com>
5740
5741         * tui/tui-source.c (tui_source_window): New constructor.  Add
5742         observer.
5743         (~tui_source_window): New destructor.
5744         (tui_source_window::style_changed): New method.
5745         * tui/tui-hooks.c (tui_redisplay_source): Remove.
5746         (tui_attach_detach_observers): Update.
5747         * tui/tui-data.h (struct tui_source_window): Make constructor not
5748         inline.  Add destructor.
5749         (struct tui_source_window) <style_changed>: New method.
5750         <m_observable>: New member.
5751
5752 2019-07-17  Tom Tromey  <tom@tromey.com>
5753
5754         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5755         * tui/tui-win.c (tui_resize_all): Fix typo.
5756
5757 2019-07-17  Tom Tromey  <tom@tromey.com>
5758
5759         * tui/tui-wingeneral.h (tui_refresh_all): Update.
5760         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5761         (tui_refresh_all): Remove "list" parameter.  Use foreach.
5762         * tui/tui-win.c (window_name_completer): Use foreach.
5763         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5764         (update_tab_width): Likewise.
5765         * tui/tui-layout.c (show_layout): Update.
5766         * tui/tui-data.h (class tui_window_iterator): New.
5767         (struct all_tui_windows): New.
5768         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5769
5770 2019-07-17  Tom Tromey  <tom@tromey.com>
5771
5772         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
5773         parameter.  Don't reference globals.
5774         (tui_reg_command): Update.
5775
5776 2019-07-17  Tom Tromey  <tom@tromey.com>
5777
5778         * tui/tui-regs.c (tui_show_registers): Simplify.
5779
5780 2019-07-17  Tom Tromey  <tom@tromey.com>
5781
5782         * tui/tui-regs.c (tui_show_registers): Update.
5783         (tui_show_register_group): Add win_info parameter.
5784
5785 2019-07-17  Tom Tromey  <tom@tromey.com>
5786
5787         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
5788         Rename from tui_display_reg_element_at_line.
5789         (tui_data_window::display_registers_from_line): Update.
5790         * tui/tui-data.h (struct tui_data_window)
5791         <display_reg_element_at_line>: New method.
5792
5793 2019-07-17  Tom Tromey  <tom@tromey.com>
5794
5795         * tui/tui-regs.h (tui_display_registers_from)
5796         (tui_display_registers_from_line): Don't declare.
5797         * tui/tui-windata.c (tui_data_window::display_all_data)
5798         (tui_data_window::refresh_all)
5799         (tui_data_window::do_scroll_vertical): Update.
5800         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
5801         from tui_display_registers_from.
5802         (tui_display_reg_element_at_line): Update.
5803         (tui_data_window::display_registers_from_line): Rename from
5804         tui_display_registers_from_line.
5805         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
5806         display_registers_from_line>: New methods.
5807
5808 2019-07-17  Tom Tromey  <tom@tromey.com>
5809
5810         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
5811         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
5812         from tui_erase_data_content.
5813         (tui_data_window::display_all_data)
5814         (tui_data_window::refresh_all)
5815         (tui_data_window::do_scroll_vertical): Update.
5816         * tui/tui-regs.c (tui_show_registers): Update.
5817         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
5818         New method.
5819
5820 2019-07-17  Tom Tromey  <tom@tromey.com>
5821
5822         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
5823         declare.
5824         * tui/tui-windata.c
5825         (tui_data_window::delete_data_content_windows): Rename from
5826         tui_delete_data_content_windows.
5827         (tui_data_window::display_all_data)
5828         (tui_data_window::do_scroll_vertical): Update.
5829         * tui/tui-data.h (struct tui_data_window)
5830         <delete_data_content_windows>: New method.
5831
5832 2019-07-17  Tom Tromey  <tom@tromey.com>
5833
5834         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5835         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5836
5837 2019-07-17  Tom Tromey  <tom@tromey.com>
5838
5839         * tui/tui-windata.h (tui_display_all_data): Don't declare.
5840         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
5841         from tui_display_all_data.
5842         * tui/tui-win.c
5843         (tui_data_window::do_make_visible_with_new_height): Update.
5844         * tui/tui-regs.c (tui_show_registers): Update.
5845         * tui/tui-layout.c (tui_set_layout): Update.
5846         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
5847         method.
5848
5849 2019-07-17  Tom Tromey  <tom@tromey.com>
5850
5851         * tui/tui-windata.h (tui_display_data_from): Don't declare.
5852         * tui/tui-windata.c (tui_display_data_from): Remove.
5853         (tui_data_window::refresh_all): Update.
5854
5855 2019-07-17  Tom Tromey  <tom@tromey.com>
5856
5857         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
5858         * tui/tui-windata.c (tui_display_data_from_line): Remove.
5859         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
5860         tui_display_registers_from_line.
5861         * tui/tui-regs.h (tui_display_registers_from_line): Update.
5862         * tui/tui-regs.c (tui_display_registers_from_line): Remove
5863         "force_display" parameter.
5864
5865 2019-07-17  Tom Tromey  <tom@tromey.com>
5866
5867         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5868         declare.
5869         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5870         Rename from tui_first_reg_element_no_inline.
5871         (tui_display_reg_element_at_line)
5872         (tui_display_registers_from_line): Update.
5873         * tui/tui-data.h (struct tui_data_window)
5874         <first_reg_element_no_inline>: New method.
5875
5876 2019-07-17  Tom Tromey  <tom@tromey.com>
5877
5878         * tui/tui-windata.c (tui_display_data_from)
5879         (tui_data_window::do_scroll_vertical): Update.
5880         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5881         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5882         Rename from tui_line_from_reg_element_no.
5883         (tui_display_registers_from_line): Update.
5884         * tui/tui-data.h (struct tui_data_window)
5885         <line_from_reg_element_no>: New method.
5886
5887 2019-07-17  Tom Tromey  <tom@tromey.com>
5888
5889         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5890         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5891         tui_last_regs_line_no.
5892         (tui_display_reg_element_at_line)
5893         (tui_display_registers_from_line): Update.
5894         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5895         method.
5896
5897 2019-07-17  Tom Tromey  <tom@tromey.com>
5898
5899         PR tui/24722:
5900         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5901         (tui_update_breakpoint_info): Add "being_deleted" parameter.
5902         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5903         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5904         (tui_update_breakpoint_info): Likewise.
5905         * tui/tui-hooks.c (tui_event_create_breakpoint)
5906         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5907         Update.
5908
5909 2019-07-17  Tom Tromey  <tom@tromey.com>
5910
5911         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5912
5913 2019-07-17  Tom Tromey  <tom@tromey.com>
5914
5915         * tui/tui-winsource.c (tui_update_source_window_as_is)
5916         (tui_update_source_windows_with_addr): Update.
5917         * tui/tui-source.h (tui_set_source_content)
5918         (tui_show_symtab_source): Add "win_info" parameter.
5919         * tui/tui-source.c (tui_set_source_content): Add "win_info"
5920         parameter.
5921         (tui_show_symtab_source): Likewise.
5922
5923 2019-07-17  Tom Tromey  <tom@tromey.com>
5924
5925         * tui/tui-wingeneral.c
5926         (tui_check_and_display_highlight_if_needed): Check can_highlight.
5927
5928 2019-07-17  Tom Tromey  <tom@tromey.com>
5929
5930         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5931         (struct tui_cmd_window) <can_scroll>: New method.
5932         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5933         method.
5934
5935 2019-07-17  Tom Tromey  <tromey@adacore.com>
5936
5937         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5938         do_field_signed>: Rename.  Change type of "value".
5939         * ui-out.c (ui_out::field_signed): Rename from field_int.
5940         Change type of "value".
5941         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
5942         type of "value".
5943         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5944         do_field_int.  Change type of "value".
5945         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5946         do_field_int.  Change type of "value".
5947         * tracepoint.c (trace_status_mi, tfind_1)
5948         (print_one_static_tracepoint_marker): Update.
5949         * thread.c (print_thread_info_1, print_selected_thread_frame):
5950         Update.
5951         * stack.c (print_frame, print_frame_info): Update.
5952         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5953         Update.
5954         * source.c (print_source_lines_base): Update.
5955         * skip.c (info_skip_command): Update.
5956         * record-btrace.c (btrace_ui_out_decode_error)
5957         (btrace_call_history_src_line): Update.
5958         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5959         Update.
5960         * progspace.c (print_program_space): Update.
5961         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5962         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5963         do_field_int.  Change type of "value".
5964         * mi/mi-out.c (mi_ui_out::do_table_begin)
5965         (mi_ui_out::do_table_header): Update.
5966         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
5967         type of "value".
5968         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5969         (mi_cmd_data_list_changed_registers, output_register)
5970         (mi_cmd_data_read_memory, mi_load_progress)
5971         (mi_cmd_trace_frame_collected): Update.
5972         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5973         Update.
5974         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5975         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5976         (mi_cmd_var_list_children, varobj_update_one): Update.
5977         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5978         (mi_cmd_stack_list_args, list_arg_or_local): Update.
5979         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5980         * inferior.c (print_inferior): Update.
5981         * gdb_bfd.c (print_one_bfd): Update.
5982         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5983         Update.
5984         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5985         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5986         do_field_int.  Change type of "value".
5987         * cli-out.c (cli_ui_out::do_field_signed): Rename from
5988         do_field_int.  Change type of "value".
5989         * breakpoint.c (watchpoint_check, print_breakpoint_location)
5990         (print_one_breakpoint_location, print_it_catch_fork)
5991         (print_one_catch_fork, print_it_catch_vfork)
5992         (print_one_catch_vfork, print_it_catch_solib)
5993         (print_it_catch_exec, print_it_ranged_breakpoint)
5994         (print_mention_watchpoint, print_mention_masked_watchpoint)
5995         (bkpt_print_it, update_static_tracepoint): Update.
5996         * break-catch-throw.c (print_it_exception_catchpoint): Update.
5997         * break-catch-syscall.c (print_it_catch_syscall): Update.
5998         * ada-tasks.c (print_ada_task_info): Update.
5999         * ada-lang.c (print_it_exception, print_mention_exception):
6000         Update.
6001
6002 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6003
6004         PR breakpoints/24541
6005         * gdbarch.c: Regenerate.
6006         * gdbarch.h: Regenerate.
6007         * gdbarch.sh: Adjust return type and parameter types for
6008         'stap_adjust_register'.
6009         (i386_stap_adjust_register): Adjust signature and return new
6010         register name.
6011         * stap-probe.c (stap_parse_register_operand): Adjust use of
6012         'gdbarch_stap_adjust_register'.
6013
6014 2019-07-17  Tom Tromey  <tromey@adacore.com>
6015
6016         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6017         declare VEC.
6018         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6019         std::vector.
6020         (struct s390_process_info): Add initializers.
6021         (s390_add_process): Use new.
6022         (s390_linux_nat_target::low_forget_process): Use delete.
6023         (s390_linux_nat_target::low_new_fork)
6024         (s390_linux_nat_target::stopped_by_watchpoint)
6025         (s390_linux_nat_target::low_prepare_to_resume)
6026         (s390_linux_nat_target::insert_watchpoint)
6027         (s390_linux_nat_target::insert_hw_breakpoint)
6028         (s390_linux_nat_target::remove_watchpoint)
6029         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6030
6031 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6032
6033         * aarch64-fbsd-nat.c: Include regcache.h.
6034         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6035         argument.
6036         (aarch64_fbsd_nat_target::fetch_registers)
6037         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6038         variable.
6039         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6040
6041 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6042
6043         * fbsd-nat.c: Include gdbarch.h.
6044
6045 2019-07-15  Tom Tromey  <tromey@adacore.com>
6046
6047         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6048
6049 2019-07-15  Tom Tromey  <tromey@adacore.com>
6050
6051         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6052         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6053         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6054         * cli-out.c (cli_ui_out::do_field_int): New method.
6055         * ui-out.c (ui_out::field_unsigned): New method.
6056         * symfile.c (generic_load): Use field_unsigned.
6057         (print_transfer_performance): Likewise.
6058         * record-btrace.c (ui_out_field_uint): Remove.
6059         (btrace_call_history_insn_range, btrace_call_history): Use
6060         field_unsigned.
6061         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6062         field_unsigned.
6063         * ui-out.h (class ui_out) <field_unsigned>: New method.
6064         <do_field_unsigned>: Likewise.
6065
6066 2019-07-15  Tom Tromey  <tromey@adacore.com>
6067
6068         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6069         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6070         * target.c (flash_erase_command): Use field_string.
6071         * infrun.c (print_signal_received_reason): Use field_string.
6072         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6073         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6074         field_string.
6075         * ada-tasks.c (print_ada_task_info): Use field_string.
6076
6077 2019-07-15  Tom Tromey  <tromey@adacore.com>
6078
6079         * target.c (flash_erase_command): Use field_core_addr.
6080         * symfile.c (generic_load): Use field_core_addr.
6081         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6082         Use field_core_addr.
6083         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6084         field_core_addr.
6085
6086 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6087
6088         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6089         value if its desired type is smaller than a CORE_ADDR and signed.
6090
6091 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6092
6093         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6094         of changes to field names, and use new is_reference field to
6095         decide if a property is a reference or not.
6096         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6097         field.
6098         (struct dwarf2_property_baton): Update header comment, rename
6099         'referenced_type' to 'property_type' and update comments.
6100         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6101         default property type, store in property baton, update to take
6102         accound of renamed field.
6103         (read_func_scope): Update call to attr_to_dynamic_prop.
6104         (read_array_type): Likewise.
6105         (dwarf2_per_cu_addr_sized_int_type): New function.
6106         (read_subrange_index_type): Move type finding code to
6107         dwarf2_per_cu_addr_sized_int_type.
6108         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6109         (dwarf2_per_cu_addr_type): New function.
6110         (set_die_type): Update calls to attr_to_dynamic_prop.
6111
6112 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6113
6114         * dwarf2read.c (read_subrange_index_type): New function.
6115         (read_subrange_type): Move code into new function and call it.
6116         * gdbtypes.c (create_range_type): Add some asserts.
6117
6118 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6119
6120         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6121         update return statements.
6122         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6123         declaration, and update comment to match.
6124         * gdbtypes.c (resolve_dynamic_array): Update call to
6125         dwarf2_evaluate_property to match new return type.
6126
6127 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6128
6129         * valarith.c (value_subscripted_rvalue): Change lowerbound
6130         parameter type from int to LONGEST.
6131         * value.h (value_subscripted_rvalue): Likewise in declaration.
6132
6133 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6134
6135         * cli/cli-utils.c (info_print_command_completer): New function.
6136         * cli/cli-utils.h: Add 'completer.h' include, and forward
6137         declaration for 'struct cmd_list_element'.
6138         (info_print_command_completer): Declare.
6139         * stack.c (_initialize_stack): Add completer for 'info locals' and
6140         'info args'.
6141         * symtab.c (_initialize_symtab): Add completer for 'info
6142         variables' and 'info functions'.
6143         * NEWS: Mention completion for additional info commands.
6144
6145 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6146
6147         * cli/cli-utils.c (extract_info_print_args): Delete.
6148         (extract_arg_maybe_quoted): Delete.
6149         (info_print_options_defs): New variable.
6150         (make_info_print_options_def_group): New function.
6151         (extract_info_print_options): Define new function.
6152         * cli/cli-utils.h (extract_info_print_args): Delete.
6153         (struct info_print_options): New structure.
6154         (extract_info_print_options): Declare new function.
6155         * stack.c (info_locals_command): Update to use new
6156         extract_info_print_options, also add a header comment.
6157         (info_args_command): Likewise.
6158         * symtab.c (info_variables_command): Likewise.
6159         (info_functions_command): Likewise.
6160
6161 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6162
6163         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6164         to extract string arguments.
6165         * common/common-utils.c (extract_string_maybe_quoted): New function.
6166         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6167
6168 2019-07-11  Tom Tromey  <tromey@adacore.com>
6169
6170         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6171         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6172         * top.h (gdbinit): Don't declare.
6173         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6174         into...
6175         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6176         * top.c (gdb_init): Don't call init_cli_cmds.
6177         (gdbinit): Remove.
6178         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6179
6180 2019-07-11  Tom Tromey  <tromey@adacore.com>
6181
6182         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6183         after it has been moved.
6184
6185 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6186
6187         * valops.c (value_must_coerce_to_target): Change return type to
6188         bool.
6189         * value.h (value_must_coerce_to_target): Likewise.
6190
6191 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6192
6193         * breakpoint.c (is_hardware_watchpoint): Remove
6194         forward-declaration.
6195         (is_masked_watchpoint): Change return type to bool.
6196         (is_tracepoint): Likewise.
6197         (is_breakpoint): Likewise.
6198         (is_hardware_watchpoint): Likewise.
6199         (is_watchpoint): Likewise.
6200         (is_no_memory_software_watchpoint): Likewise.
6201         (is_catchpoint): Likewise.
6202         (breakpoint_1): Make FILTER parameter's return type bool.
6203         is_masked_watchpoint): Change return type to bool.
6204         (save_breakpoints): Make FILTER parameter's return type bool.
6205         * breakpoint.h (is_breakpoint): Change return type to bool.
6206         (is_watchpoint): Likewise.
6207         (is_catchpoint): Likewise.
6208         (is_tracepoint): Likewise.
6209
6210 2019-07-10  Tom Tromey  <tom@tromey.com>
6211
6212         * defs.h: Don't include gdbarch.h.
6213         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6214         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6215         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6216         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6217         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6218         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6219         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6220         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6221         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6222         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6223         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6224         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6225         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6226         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6227         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6228         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6229         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6230         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6231         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6232         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6233         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6234         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6235         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6236         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6237         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6238         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6239         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6240
6241 2019-07-10  Tom Tromey  <tromey@adacore.com>
6242
6243         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6244         * breakpoint.c (init_ada_exception_breakpoint): Register as
6245         bp_catchpoint.
6246         (print_one_breakpoint_location, print_one_breakpoint): Use
6247         is_ada_exception_catchpoint.
6248         * ada-lang.c (class ada_catchpoint_location): Pass
6249         bp_loc_software_breakpoint to bp_location constructor.
6250         (is_ada_exception_catchpoint): New function.
6251
6252 2019-07-10  Tom Tromey  <tromey@adacore.com>
6253
6254         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6255         VEC.
6256         (struct arm_exidx_entry): New method operator<.
6257         (struct arm_exidx_data) <section_maps>: Change type.
6258         (arm_exidx_data_free): Remove.
6259         (arm_exidx_data_key): Change type.  Move lower.
6260         (arm_exidx_new_objfile): Update.
6261         (arm_compare_exidx_entries): Remove.
6262         (arm_find_exidx_entry, _initialize_arm_tdep)
6263
6264 2019-07-10  Tom Tromey  <tromey@adacore.com>
6265
6266         * solib-spu.c (ocl_program_data_key): Change type.
6267         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6268         Update.
6269
6270 2019-07-10  Tom Tromey  <tromey@adacore.com>
6271
6272         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6273         (struct solib_aix_inferior_data) <library_list>: Change type.
6274         (solib_aix_inferior_data_handle): Change type.
6275         (get_solib_aix_inferior_data): Update.
6276         (solib_aix_free_library_list): Remove.
6277         (library_list_start_library): Update.
6278         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6279         return type.
6280         (solib_aix_get_library_list)
6281         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6282         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6283
6284 2019-07-10  Tom Tromey  <tromey@adacore.com>
6285
6286         * solib-dsbt.c (struct dsbt_info): Add initializers.
6287         (solib_dsbt_pspace_data): Change type.
6288         (dsbt_pspace_data_cleanup): Remove.
6289         (get_dsbt_info, _initialize_dsbt_solib): Update.
6290
6291 2019-07-10  Tom Tromey  <tromey@adacore.com>
6292
6293         * spu-tdep.c (spu_overlay_data): Change type.
6294         (spu_get_overlay_table, spu_overlay_new_objfile)
6295         (_initialize_spu_tdep): Update.
6296
6297 2019-07-10  Tom Tromey  <tromey@adacore.com>
6298
6299         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6300         destructor.
6301         (dbx_objfile_data_key): Change type and declare later.
6302         (DBX_SYMFILE_INFO): Rewrite.
6303         * dbxread.c (dbx_objfile_data_key): Change type.
6304         (dbx_symfile_init): Update.
6305         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6306         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6307         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6308
6309 2019-07-10  Tom Tromey  <tromey@adacore.com>
6310
6311         * jit.c (jit_program_space_key): Change type.  Move lower.
6312         (get_jit_program_space_data): Update.
6313         (jit_program_space_data_cleanup): Remove.
6314         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6315         Update.
6316         (struct jit_program_space_data): Add initializers.
6317
6318 2019-07-10  Tom Tromey  <tromey@adacore.com>
6319
6320         * solib-darwin.c (struct darwin_info): Add initializers.
6321         (solib_darwin_pspace_data): Change type.
6322         (darwin_pspace_data_cleanup): Remove.
6323         (get_darwin_info, _initialize_darwin_solib): Update.
6324
6325 2019-07-10  Tom Tromey  <tromey@adacore.com>
6326
6327         * remote-sim.c (struct sim_inferior_data): Add initializers,
6328         constructor, and destructor.
6329         (sim_inferior_data_key): Change type.  Move lower.
6330         (check_for_duplicate_sim_descriptor): Update.
6331         (get_sim_inferior_data): Use new.  Update.
6332         (~sim_inferior_data_cleanup): Rename from
6333         sim_inferior_data_cleanup.  Simplify.
6334         (gdbsim_close_inferior, simulator_command)
6335         (sim_command_completer, _initialize_remote_sim): Update.
6336         (next_pid, INITIAL_PID): Move earlier.
6337
6338 2019-07-10  Tom Tromey  <tromey@adacore.com>
6339
6340         * python/python-internal.h (create_thread_object): Return
6341         gdbpy_ref.
6342         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6343         * python/py-inferior.c (struct threadlist_entry): Add
6344         constructor.
6345         <thread_obj>: Now a gdbpy_ref.
6346         (thread_to_thread_object): Update.
6347         (add_thread_object): Use new.
6348         (delete_thread_object): Use delete.
6349         (infpy_threads): Update.
6350         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6351         GIL.
6352
6353 2019-07-10  Tom Tromey  <tromey@adacore.com>
6354
6355         * valops.c (value_cast): Specialize error message for Ada.
6356
6357 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6358
6359         * breakpoint.c (breakpoint_1): Update doc and parameter names.
6360
6361 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6362
6363         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6364         bpstat_should_step): Return bool, adjust comments.
6365         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6366         bpstat_should_step): Likewise.
6367
6368 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6369
6370         * features/Makefile: Use feature target descriptions for Arm.
6371         * features/arm/arm-core.c: Generate new file.
6372         * features/arm/arm-fpa.c: Likewise.
6373         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6374         * features/arm/arm-m-profile.c: Likewise.
6375         * features/arm/arm-vfpv2.c: Likewise.
6376         * features/arm/arm-vfpv3.c: Likewise.
6377         * features/arm/xscale-iwmmxt.c: Likewise.
6378         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6379
6380 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6381
6382         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6383         ptrace earlier.
6384
6385 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6386
6387         * features/aarch64-pauth.c: Regenerate.
6388
6389 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6390
6391         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6392         bool.
6393         (bpstat_what): Use false instead of 0.
6394
6395 2019-07-09  Pedro Alves  <palves@redhat.com>
6396
6397         * break-catch-throw.c (is_exception_catchpoint): New.
6398         * breakpoint.c (print_one_breakpoint_location): New parameter
6399         'raw_loc'.  Handle it.  Use
6400         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6401         looking at the breakpoint's type.
6402         (print_one_breakpoint): If handling "maint info breakpoints", also
6403         print locations of exception catchpoints.
6404         * breakpoint.h (is_exception_catchpoint): Declare.
6405
6406 2019-07-09  Pedro Alves  <palves@redhat.com>
6407
6408         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6409         "addr" field.
6410         (allocate_location_exception_catchpoint): New.
6411         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6412         (initialize_throw_catchpoint_ops): Install
6413         allocate_location_exception_catchpoint as allocate_location
6414         method.
6415         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6416         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6417         bp_loc_other.
6418         (breakpoint_address_is_meaningful): Delete.
6419         (bl_address_is_meaningful): New.
6420         (breakpoint_locations_match): Adjust comment.
6421         (bp_location_from_bp_type): New, factored out of...
6422         (bp_location::bp_location(breakpoint *)): ... this.
6423         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6424         factored out of...
6425         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6426         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6427         breakpoint_address_is_meaningful.
6428         (bp_locations_compare): Adjust comment.
6429         (update_global_location_list): Use bl_address_is_meaningful
6430         instead of breakpoint_address_is_meaningful.
6431         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6432         explicit.
6433         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6434         * python/py-breakpoint.c (bppy_get_location): No longer check
6435         whether location is null.
6436
6437 2019-07-09  Pedro Alves  <palves@redhat.com>
6438
6439         PR c++/15468
6440         * breakpoint.c (print_one_breakpoint_location): Remove
6441         single-location assert.
6442
6443 2019-07-09  Tom Tromey  <tom@tromey.com>
6444
6445         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6446         * configure: Rebuild.
6447         * configure.ac: Change common to gdbsupport.
6448         * gdbsupport: Rename from common.
6449         * acinclude.m4: Change common to gdbsupport.
6450         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6451         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6452         gdbsupport.
6453         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6454         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6455         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6456         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6457         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6458         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6459         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6460         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6461         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6462         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6463         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6464         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6465         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6466         coff-pe-read.c, command.h, compile/compile-c-support.c,
6467         compile/compile-c.h, compile/compile-cplus-symbols.c,
6468         compile/compile-cplus-types.c, compile/compile-cplus.h,
6469         compile/compile-loc2c.c, compile/compile.c, completer.c,
6470         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6471         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6472         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6473         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6474         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6475         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6476         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6477         features/aarch64-core.c, features/aarch64-fpu.c,
6478         features/aarch64-pauth.c, features/aarch64-sve.c,
6479         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6480         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6481         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6482         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6483         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6484         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6485         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6486         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6487         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6488         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6489         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6490         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6491         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6492         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6493         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6494         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6495         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6496         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6497         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6498         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6499         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6500         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6501         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6502         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6503         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6504         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6505         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6506         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6507         minsyms.c, mips-linux-tdep.c, namespace.h,
6508         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6509         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6510         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6511         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6512         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6513         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6514         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6515         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6516         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6517         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6518         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6519         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6520         procfs.c, producer.c, progspace.h, psymtab.h,
6521         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6522         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6523         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6524         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6525         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6526         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6527         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6528         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6529         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6530         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6531         target-memory.c, target.c, target.h, target/waitstatus.c,
6532         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6533         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6534         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6535         unittests/array-view-selftests.c,
6536         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6537         unittests/common-utils-selftests.c,
6538         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6539         unittests/format_pieces-selftests.c,
6540         unittests/function-view-selftests.c,
6541         unittests/lookup_name_info-selftests.c,
6542         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6543         unittests/mkdir-recursive-selftests.c,
6544         unittests/observable-selftests.c,
6545         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6546         unittests/parse-connection-spec-selftests.c,
6547         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6548         unittests/scoped_fd-selftests.c,
6549         unittests/scoped_mmap-selftests.c,
6550         unittests/scoped_restore-selftests.c,
6551         unittests/string_view-selftests.c, unittests/style-selftests.c,
6552         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6553         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6554         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6555         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6556         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6557         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6558
6559 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6560
6561         * linespec.c (decode_digits_list_mode): Set explicit_line to a
6562         bool value.
6563         (decode_digits_ordinary): Set explicit_line field in sal.
6564         * symtab.c (skip_prologue_sal): Don't skip prologue for a
6565         symtab_and_line that was set on an explicit line number in
6566         assembler code.  Do always update the recorded symtab and line if
6567         we do skip the prologue.
6568
6569 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6570
6571         * breakpoint.c (set_breakpoint_location_function): Remove
6572         explicit_loc parameter.
6573         (momentary_breakpoint_from_master): Update call to
6574         set_breakpoint_location_function.
6575         (add_location_to_breakpoint): Likewise.
6576
6577 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6578
6579         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6580         required features based on default bfd type when no specific bfd
6581         is present.
6582
6583 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6584
6585         * NEWS: Mention that GDB printf and eval commands can now print
6586         C-style and Ada-style convenience var strings without
6587         calling the inferior.
6588         * printcmd.c (printf_c_string): Locally print GDB internal var
6589         instead of transiting via the inferior.
6590         (printf_wide_c_string): Likewise.
6591
6592 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6593
6594         PR breakpoints/25011
6595         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6596
6597 2019-07-04  Tom Tromey  <tom@tromey.com>
6598
6599         PR tui/24724:
6600         * tui/tui-winsource.c (tui_clear_source_content): Update.
6601         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6602         (tui_update_breakpoint_info): Update.
6603         (tui_set_exec_info_content): Update.
6604         * tui/tui-source.c (tui_set_source_content_nil): Update.
6605         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6606         has_break.
6607         * tui/tui-data.h (enum tui_bp_flag): New.
6608         (tui_bp_flags): New enum flags type.
6609         (struct tui_source_element) <break_mode>: Change type.  Rename
6610         from has_break.
6611         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6612         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
6613         constants.
6614         * tui/tui-winsource.h: Fix comment.
6615
6616 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6617
6618         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6619         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6620         (store_fpregs_to_thread)
6621         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6622         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6623         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6624         (IWMMXT_REGS_SIZE): Add define.
6625         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6626         (fetch_vfp_regs, store_vfp_regs)
6627         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6628         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6629
6630 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6631
6632         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6633         defines.
6634         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6635         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6636         (ARM_INT_REGISTER_SIZE): ...to this.
6637         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6638         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6639         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6640         (arm_linux_collect_gregset, supply_nwfpe_register)
6641         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6642         defines.
6643         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6644         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6645         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6646         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6647         (arm_return_in_memory, arm_store_return_value)
6648         (arm_get_longjmp_target, arm_register_g_packet_guesses)
6649         (arm_record_ld_st_multiple): Likewise.
6650         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6651         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6652
6653 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6654
6655         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6656         AARCH64_DISPLACED_MODIFIED_INSNS.
6657         * aarch64-tdep.c (struct aarch64_displaced_step_data)
6658         (aarch64_displaced_step_copy_insn): Likewise.
6659         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6660         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6661         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6662         ARM_DISPLACED_MODIFIED_INSNS.
6663         * arm-tdep.c (arm_gdbarch_init): Likewise.
6664         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6665         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6666         (struct arm_displaced_step_closure): Use
6667         ARM_DISPLACED_MODIFIED_INSNS.
6668
6669 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6670
6671         * features/Makefile: Remove unused xml files.
6672         * features/aarch64.xml: Remove.
6673         * features/i386/amd64-avx-avx512-linux.xml: Remove.
6674         * features/i386/amd64-avx-avx512.xml: Remove.
6675         * features/i386/amd64-avx-linux.xml: Remove.
6676         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6677         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6678         * features/i386/amd64-avx-mpx-linux.xml: Remove.
6679         * features/i386/amd64-avx-mpx.xml: Remove.
6680         * features/i386/amd64-avx.xml: Remove.
6681         * features/i386/amd64-linux.xml: Remove.
6682         * features/i386/amd64-mpx-linux.xml: Remove.
6683         * features/i386/amd64-mpx.xml: Remove.
6684         * features/i386/amd64.xml: Remove.
6685         * features/i386/i386-avx-avx512-linux.xml: Remove.
6686         * features/i386/i386-avx-avx512.xml: Remove.
6687         * features/i386/i386-avx-linux.xml: Remove.
6688         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6689         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6690         * features/i386/i386-avx-mpx-linux.xml: Remove.
6691         * features/i386/i386-avx-mpx.xml: Remove.
6692         * features/i386/i386-avx.xml: Remove.
6693         * features/i386/i386-linux.xml: Remove.
6694         * features/i386/i386-mmx-linux.xml: Remove.
6695         * features/i386/i386-mmx.xml: Remove.
6696         * features/i386/i386-mpx-linux.xml: Remove.
6697         * features/i386/i386-mpx.xml: Remove.
6698         * features/i386/i386.xml: Remove.
6699         * features/i386/x32-avx-avx512-linux.xml: Remove.
6700         * features/i386/x32-avx-linux.xml: Remove.
6701         * features/i386/x32-linux.xml: Remove.
6702
6703 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6704
6705         * regformats/aarch64.dat: Remove.
6706         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6707         * regformats/i386/amd64-avx-linux.dat: Remove.
6708         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6709         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6710         * regformats/i386/amd64-linux.dat: Remove.
6711         * regformats/i386/amd64-mpx-linux.dat: Remove.
6712         * regformats/i386/amd64.dat: Remove.
6713         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6714         * regformats/i386/i386-avx-linux.dat: Remove.
6715         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6716         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6717         * regformats/i386/i386-linux.dat: Remove.
6718         * regformats/i386/i386-mmx-linux.dat: Remove.
6719         * regformats/i386/i386-mpx-linux.dat: Remove.
6720         * regformats/i386/i386.dat: Remove.
6721         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6722         * regformats/i386/x32-avx-linux.dat: Remove.
6723         * regformats/i386/x32-linux.dat: Remove.
6724
6725 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6726
6727         * aarch64-tdep.c: Remove xml self tests.
6728         * amd64-linux-tdep.c: Likewise.
6729         * amd64-tdep.c: Likewise.
6730         * i386-linux-tdep.c: Likewise.
6731         * i386-tdep.c: Likewise.
6732
6733 2019-07-03  Pedro Alves  <palves@redhat.com>
6734
6735         PR cli/24732
6736         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6737         (pipe_cmd_option_defs): New.
6738         (make_pipe_cmd_options_def_group): New.
6739         (pipe_command): Use gdb::option::process_options.
6740         (pipe_command_completer): New function.
6741         (_initialize_cli_cmds): Install completer for "pipe" command.
6742
6743 2019-07-03  Pedro Alves  <palves@redhat.com>
6744
6745         * cli/cli-option.c (union option_value) <string>: New field.
6746         (struct option_def_and_value): Add ctor, move ctor, dtor and
6747         use DISABLE_COPY_AND_ASSIGN.
6748         (option_def_and_value::clear_value): New.
6749         (parse_option, save_option_value_in_ctx, get_val_type_str)
6750         (add_setshow_cmds_for_options): Handle var_string.
6751         * cli-option.h (union option_def::var_address) <string>: New
6752         field.
6753         (struct string_option_def): New.
6754         * maint-test-options.c (struct test_options_opts): Add default
6755         ctor and use DISABLE_COPY_AND_ASSIGN.
6756         <string_opt>: New field.
6757         (test_options_opts::~test_options_opts): New.
6758         (test_options_opts::dump): Also dump "-string".
6759         (test_options_option_defs): Install "string.
6760
6761 2019-07-03  Pedro Alves  <palves@redhat.com>
6762
6763         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6764         option_value with a null enumeration.
6765         (complete_options): Save the option values in the context.
6766         (save_option_value_in_ctx): New, factored out from ...
6767         (process_options): ... here.
6768         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6769         of the function.
6770         * maint-test-options.c (test_options_opts::dump): New, factored
6771         out from ...
6772         (maintenance_test_options_command_mode): ... here.
6773         (maintenance_test_options_command_completion_result): Delete.
6774         (maintenance_test_options_command_completion_text): Update
6775         comment.
6776         (maintenance_show_test_options_completion_result): Change
6777         prototype.  Just print
6778         maintenance_test_options_command_completion_text.
6779         (save_completion_result): New.
6780         (maintenance_test_options_completer_mode): Pass options context to
6781         complete_options, and then save a dump.
6782         (_initialize_maint_test_options): Use add_cmd to install "maint
6783         show test-options-completion-result".
6784
6785 2019-07-03  Pedro Alves  <palves@redhat.com>
6786
6787         * NEWS (New commands): Mention "with" and "maint with".
6788         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
6789         (with_command, with_command_completer): New.
6790         (pipe_command): Adjust to new repeat_previous
6791         interface.
6792         (_initialize_cli_cmds): Install the "with" command and its "w"
6793         alias.
6794         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
6795         declarations.
6796         * cli/cli-setshow.c (parse_cli_var_uinteger)
6797         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
6798         argument strings for all var_types.
6799         (get_setshow_command_value_string): New, factored out from ...
6800         (do_show_command): ... this.
6801         * cli/cli-setshow.h: Include <string>.
6802         (get_setshow_command_value_string): Declare.
6803         * command.h (repeat_previous): Now returns const char *.  Adjust
6804         comment.
6805         * maint.c: Include "cli/cli-cmds.h".
6806         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
6807         (_initialize_maint_cmds): Register the "maintenance with" command.
6808         * top.c (repeat_previous): Move bits from pipe_command here:
6809         Return the saved command line, if any; error out if there's no
6810         command to relaunch.
6811
6812 2019-07-03  Pedro Alves  <palves@redhat.com>
6813
6814         * NEWS (New commands): Mention "maint set/show test-settings"
6815         instead of "maint test-settings".
6816         * maint-test-settings.c (maintenance_test_settings_list): Delete.
6817         (maintenance_test_settings_set_list): Rename to ...
6818         (maintenance_set_test_settings_list): ... this.
6819         (maintenance_test_settings_show_list): Rename to  ...
6820         (maintenance_show_test_settings_list): ... this.
6821         (maintenance_test_settings_cmd): Delete.
6822         (maintenance_test_settings_set_cmd): ...
6823         (maintenance_set_test_settings_cmd): ... this.
6824         (maintenance_test_settings_show_cmd): ...
6825         (maintenance_show_test_settings_cmd): ... this.
6826         (maintenance_test_settings_show_value_cmd):
6827         (maintenance_show_test_settings_value_cmd): ... this.
6828         (_initialize_maint_test_settings): No longer install the "maint
6829         test-settings" prefix command.  Rename "maint test-settings set"
6830         to "maint set test-settings", and "maint test-settings show" to
6831         "maint show test-settings".  Adjust all subcommands.
6832
6833 2019-07-03  Pedro Alves  <palves@redhat.com>
6834
6835         * maint-test-settings.c: Fix file's intro comment.  Replace all
6836         references to "test-options" with references to "test-settings",
6837         in comments.
6838
6839 2019-07-03  Pedro Alves  <palves@redhat.com>
6840
6841         * maint-test-settings.c (maintenance_test_settings_xxx)
6842         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
6843         New.
6844         (maintenance_test_settings_enums): Use them.
6845         (maintenance_test_settings_enum): Default to
6846         maintenance_test_settings_xxx.
6847         (_initialize_maint_test_settings): Initialize
6848         MAINTENANCE_TEST_SETTINGS_FILENAME.
6849
6850 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6851
6852         * breakpoint.h (remove_breakpoints_inf): Change return type to
6853         void, move function documentation here.
6854         * breakpoint.c (remove_breakpoints_inf): Change return type to
6855         void, move function documentation to header.
6856
6857 2019-07-02  Pedro Alves  <palves@redhat.com>
6858
6859         * NEWS (Completion improvements): Mention "info threads".
6860         * thread.c (struct info_threads_opts, info_threads_option_defs)
6861         (make_info_threads_options_def_group): New.
6862         (info_threads_command): Use gdb::option::process_options.
6863         (info_threads_command_completer): New.
6864         (_initialize_thread): Use gdb::option::build_help to build the
6865         help text for "info threads".
6866
6867 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
6868
6869         * defs.h (generic_load): Move from here...
6870         * symfile.h (generic_load): ... to here.  Rename name parameter
6871         to args.
6872         * symfile.c (generic_load): Add comment.
6873
6874 2019-07-01  Tom Tromey  <tromey@adacore.com>
6875
6876         * dwarf2read.c
6877         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6878         declaration of without_params.  Fix formatting.
6879
6880 2019-07-01  Tom Tromey  <tromey@adacore.com>
6881
6882         * ada-exp.y (find_primitive_type): Update.
6883         * ada-lang.h (ada_lookup_symbol): Update.
6884         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6885         parameter.
6886         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6887
6888 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6889
6890         PR breakpoints/24541
6891         * gdbarch.c: Regenerate.
6892         * gdbarch.h: Regenerate.
6893         * gdbarch.sh: Add 'stap_adjust_register'.
6894         * i386-tdep.c: Include '<unordered_set>'.
6895         (i386_stap_adjust_register): New function.
6896         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6897         * stap-probe.c (stap_parse_register_operand): Call
6898         'gdbarch_stap_adjust_register'.
6899
6900 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
6901
6902         PR python/24742
6903         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6904         * python/python.c (do_start_initialization): Use 'xmalloc'
6905         instead of 'PyMem_Malloc'.
6906
6907 2019-06-28  Tom Tromey  <tromey@adacore.com>
6908
6909         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6910         for Ada.
6911
6912 2019-06-27  Tom Tromey  <tromey@adacore.com>
6913
6914         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
6915         objfile_key.
6916         (arm_find_mapping_symbol, arm_record_special_symbol)
6917         (_initialize_arm_tdep): Update.
6918         (arm_objfile_data_free): Remove.
6919
6920 2019-06-27  Tom Tromey  <tromey@adacore.com>
6921
6922         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6923         to cp_print_static_field.
6924
6925 2019-06-26  Tom Tromey  <tromey@adacore.com>
6926
6927         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6928         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6929         declare.
6930
6931 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6932
6933         * features/aarch64-core.c (create_feature_aarch64_core):
6934         Regenerate.
6935         * features/aarch64-core.xml: Add cpsr flags.
6936
6937 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
6938
6939         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6940         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6941
6942 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6943
6944         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6945         field.
6946         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6947         use.
6948         (arm_record_special_symbol): Don't insert new symbol in sorted
6949         position, push it at the end.
6950
6951 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
6952
6953         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6954         (arm_mapping_symbol_s): Remove.
6955         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6956         (arm_mapping_symbol_vec): New typedef.
6957         (struct arm_per_objfile): Add constructor.
6958         <section_maps>: Change type to
6959         std::unique_ptr<arm_mapping_symbol_vec[]>.
6960         (arm_compare_mapping_symbols): Remove.
6961         (arm_find_mapping_symbol): Adjust to section_maps type change.
6962         (arm_objfile_data_free): Call delete on arm_per_objfile.
6963         (arm_record_special_symbol): Adjust to section_maps type change.
6964         Allocate arm_per_objfile with new.
6965
6966 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6967
6968         * cli/cli-cmds.c (alias_command): Compare the alias prefix
6969         with the command prefix.
6970
6971 2019-06-25  Tom Tromey  <tom@tromey.com>
6972
6973         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6974         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6975
6976 2019-06-25  Tom Tromey  <tom@tromey.com>
6977
6978         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6979         type.
6980         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6981         protected.
6982
6983 2019-06-25  Tom Tromey  <tom@tromey.com>
6984
6985         * tui/tui-winsource.c
6986         (tui_source_window_base::set_is_exec_point_at): Add check against
6987         LOA_ADDRESS.
6988
6989 2019-06-25  Tom Tromey  <tom@tromey.com>
6990
6991         * tui/tui-source.c (tui_set_source_content): Don't check before
6992         xfree.
6993         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6994
6995 2019-06-25  Tom Tromey  <tom@tromey.com>
6996
6997         * tui/tui-winsource.h (tui_update_source_window_as_is)
6998         (tui_alloc_source_buffer, tui_line_is_displayed)
6999         (tui_addr_is_displayed): Change type of win_info.
7000         * tui/tui-winsource.c (tui_update_source_window_as_is)
7001         (tui_clear_source_content, tui_show_source_line)
7002         (tui_show_source_content, tui_source_window_base::refill)
7003         (tui_source_window_base::set_is_exec_point_at)
7004         (tui_source_window_base::set_is_exec_point_at)
7005         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7006         (tui_alloc_source_buffer, tui_line_is_displayed)
7007         (tui_addr_is_displayed): Change type of win_info.  Update.
7008         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7009         (tui_source_window_base::do_make_visible_with_new_height):
7010         Update.
7011         * tui/tui-source.c (tui_set_source_content)
7012         (tui_set_source_content_nil)
7013         (tui_source_window::do_scroll_vertical): Update.
7014         * tui/tui-layout.c (show_layout): Update.
7015         * tui/tui-disasm.c (tui_set_disassem_content)
7016         (tui_disasm_window::do_scroll_vertical): Update.
7017         * tui/tui-data.h (tui_win_content): Remove.
7018         (struct tui_gen_win_info) <content, content_size>: Remove.
7019         (struct tui_source_element): Add initializers and destructor.
7020         (union tui_which_element, struct tui_win_element): Remove.
7021         (struct tui_source_window_base) <content>: New field.
7022         (struct tui_data_window): Remove destructor.
7023         (tui_alloc_content, tui_free_win_content)
7024         (tui_free_all_source_wins_content): Don't declare.
7025         * tui/tui-data.c (tui_initialize_static_data): Update.
7026         (init_content_element, tui_alloc_content): Remove.
7027         (~tui_gen_win_info): Update.
7028         (~tui_data_window, tui_free_all_source_wins_content)
7029         (tui_free_win_content, free_content, free_content_elements):
7030         Remove.
7031
7032 2019-06-25  Tom Tromey  <tom@tromey.com>
7033
7034         * tui/tui-winsource.h (tui_clear_source_content)
7035         (tui_erase_source_content, tui_show_source_content): Change type
7036         of win_info.
7037         * tui/tui-winsource.c (tui_clear_source_content)
7038         (tui_erase_source_content, tui_show_source_content): Change type
7039         of win_info.
7040         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7041         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7042         win_info.
7043         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7044         win_info.
7045         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7046
7047 2019-06-25  Tom Tromey  <tom@tromey.com>
7048
7049         * tui/tui-winsource.c (tui_clear_source_content)
7050         (tui_source_window_base::set_is_exec_point_at): Update.
7051         * tui/tui-source.c (tui_set_source_content_nil): Update.
7052         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7053         a bool.
7054         * tui/tui-data.c (init_content_element): Update.
7055
7056 2019-06-25  Tom Tromey  <tom@tromey.com>
7057
7058         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7059         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7060         * tui/tui-layout.c (init_and_make_win): Update.
7061         * tui/tui.h (enum tui_win_type): Update.
7062         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7063         tui_win_is_auxillary.
7064         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7065         tui_win_is_auxillary.
7066
7067 2019-06-25  Tom Tromey  <tom@tromey.com>
7068
7069         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7070         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7071         (tui_delete_data_content_windows, tui_display_all_data)
7072         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7073         Update.
7074         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7075         * tui/tui-regs.c (tui_last_regs_line_no)
7076         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7077         (tui_show_registers): Update.
7078         (tui_show_register_group): Return void.  Update.
7079         (tui_display_registers_from, tui_display_reg_element_at_line)
7080         (tui_display_registers_from_line, tui_check_register_values):
7081         Update.
7082         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7083         member.
7084         (struct tui_data_window) <regs_content>: Now a std::vector.
7085         <regs_content_count>: Remove.
7086         (tui_add_content_elements, tui_free_data_content): Don't declare.
7087         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7088         (init_content_element): Remove DATA_WIN case.  Add assert.
7089         (tui_add_content_elements): Remove.
7090         (tui_data_window): Update.
7091         (tui_free_data_content): Remove.
7092         (free_content_elements): Remove DATA_WIN case.
7093
7094 2019-06-25  Tom Tromey  <tom@tromey.com>
7095
7096         * tui/tui-data.c (tui_data_item_window): Update.
7097         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7098         * tui/tui-windata.c (tui_display_all_data)
7099         (tui_display_data_from_line): Update.
7100         (tui_check_data_values): Remove.
7101         * tui/tui-regs.c (tui_show_register_group)
7102         (tui_display_reg_element_at_line): Update.
7103         * tui/tui-hooks.c (tui_register_changed)
7104         (tui_refresh_frame_and_register_information): Call
7105         tui_check_register_values.
7106         * tui/tui-data.h (struct tui_data_window) <data_content,
7107         data_content_count, data_type>: Remove.
7108         (enum tui_data_type): Remove.
7109
7110         * tui/tui-data.c (tui_data_window::clear_detail)
7111         (~tui_data_window): Update.
7112
7113 2019-06-25  Tom Tromey  <tom@tromey.com>
7114
7115         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7116         declare.
7117         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7118         Rename from tui_first_data_item_displayed.  Update.
7119         (tui_data_window::refresh_all)
7120         (tui_data_window::do_scroll_vertical): Update.
7121         * tui/tui-data.h (struct tui_data_window)
7122         <first_data_item_displayed>: Declare new method.
7123
7124 2019-06-25  Tom Tromey  <tom@tromey.com>
7125
7126         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7127         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7128         contents...
7129         (tui_initialize_static_data): ...here.
7130
7131 2019-06-25  Tom Tromey  <tom@tromey.com>
7132
7133         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7134         (tui_display_registers_from, tui_check_register_values): Update.
7135         (tui_display_register): Remove win_info parameter; update.
7136         (tui_get_register): Change type of parameters.
7137         * tui/tui-data.h (struct tui_data_element): Remove.
7138         (union tui_which_element) <data>: Remove.
7139         <data_window>: Change type.
7140         (struct tui_data_item_window): New.
7141         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7142         case.  Add assert.
7143         (~tui_data_item_window): New destructor.
7144         (free_content_elements): Remove DATA_ITEM_WIN case.
7145
7146 2019-06-25  Tom Tromey  <tom@tromey.com>
7147
7148         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7149         Remove.
7150
7151 2019-06-25  Tom Tromey  <tom@tromey.com>
7152
7153         * tui/tui-data.h (struct tui_command_element): Remove.
7154         (union tui_which_element) <command>: Remove.
7155         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7156         assert.
7157         (free_content_elements): Remove CMD_WIN case.
7158
7159 2019-06-25  Tom Tromey  <tom@tromey.com>
7160
7161         * tui/tui-layout.c (tui_set_layout): Update.
7162         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7163         * tui/tui-data.c (layout_def): Update.
7164
7165 2019-06-25  Tom Tromey  <tom@tromey.com>
7166
7167         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7168         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7169         (tui_source_window_base::set_new_height): Update.
7170         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7171         Update.
7172         (tui_set_locator_fullname, tui_set_locator_info)
7173         (tui_show_frame_info): Update.
7174         * tui/tui-source.c (tui_set_source_content)
7175         (tui_source_is_displayed): Update.
7176         * tui/tui-layout.c (show_source_disasm_command, show_data)
7177         (show_source_or_disasm_and_command): Update.
7178         * tui/tui-disasm.c (tui_set_disassem_content)
7179         (tui_get_begin_asm_address): Update.
7180         * tui/tui-data.h (struct tui_locator_element): Remove.
7181         (union tui_which_element) <locator>: Remove.
7182         (struct tui_locator_window): New.
7183         (tui_locator_win_info_ptr): Change return type.
7184         * tui/tui-data.c (_locator): Change type.
7185         (tui_locator_win_info_ptr): Change return type.
7186         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7187         (tui_alloc_content): Add assert.
7188
7189 2019-06-25  Tom Tromey  <tom@tromey.com>
7190
7191         * tui/tui-winsource.c
7192         (tui_exec_info_window::maybe_allocate_content): New method.
7193         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7194         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7195         (make_source_or_disasm_window): Add cast.
7196         * tui/tui-data.h (union tui_which_element) <simple_string>:
7197         Remove.
7198         (struct tui_source_info): New.
7199         (struct tui_source_window_base) <execution_info>: Change type.
7200         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7201         case, and add assert.
7202         (tui_alloc_content): Add assert.
7203
7204 2019-06-25  Tom Tromey  <tom@tromey.com>
7205
7206         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7207         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7208         * tui/tui-data.c (tui_alloc_win_info): Remove.
7209
7210 2019-06-25  Tom Tromey  <tom@tromey.com>
7211
7212         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7213         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7214         can_highlight.
7215
7216 2019-06-25  Tom Tromey  <tom@tromey.com>
7217
7218         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7219         make_visible_with_new_height method.
7220         (tui_win_info::make_visible_with_new_height): New method.
7221         (tui_source_window_base::do_make_visible_with_new_height)
7222         (tui_data_window::do_make_visible_with_new_height)
7223         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7224         (make_visible_with_new_height): Remove.
7225         (tui_resize_all, tui_adjust_win_heights): Use
7226         make_visible_with_new_height method.
7227         * tui/tui-data.h (struct tui_win_info)
7228         <do_make_visible_with_new_height, make_visible_with_new_height>:
7229         New methods.
7230         (struct tui_source_window_base, struct tui_data_window)
7231         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7232         methods.
7233
7234 2019-06-25  Tom Tromey  <tom@tromey.com>
7235
7236         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7237         method.
7238         (update_tab_width): Call update_tab_width method.
7239         * tui/tui-data.h (struct tui_win_info)
7240         (struct tui_source_window_base) <update_tab_width>: New methods.
7241
7242 2019-06-25  Tom Tromey  <tom@tromey.com>
7243
7244         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7245         parameter.
7246         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7247         parameter.
7248         (tui_gen_win_info::make_visible): Update.
7249         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7250         parameter.
7251         * tui/tui-data.h (enum tui_box): New enum.
7252         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7253
7254 2019-06-25  Tom Tromey  <tom@tromey.com>
7255
7256         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7257         init_and_make_win for EXEC_INFO_WIN.
7258         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7259         longer inline.
7260         (struct tui_win_info) <~tui_win_info>: Inline.
7261         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7262         Don't declare.
7263         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7264         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7265         Remove.
7266         (tui_initialize_static_data): Update.
7267         (~tui_gen_win_info): Handle more cleanup here.
7268         (~tui_source_window_base): Delete "execution_info".
7269         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7270
7271 2019-06-25  Tom Tromey  <tom@tromey.com>
7272
7273         * tui/tui-layout.c (make_command_window): Don't set
7274         can_highlight.
7275         (show_source_disasm_command): Call the reset method.
7276         (show_data): Don't set can_highlight.  Call the reset method.
7277         (tui_gen_win_info::reset): Rename from init_gen_win_info
7278         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7279         (show_source_or_disasm_and_command): Call the reset method.
7280         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7281         (struct tui_cmd_window): Set can_highlight.
7282
7283 2019-06-25  Tom Tromey  <tom@tromey.com>
7284
7285         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7286         from make_visible.
7287         (tui_make_visible, tui_make_invisible): Rewrite.
7288         (tui_win_info::make_visible): Remove.
7289         (tui_source_window_base::make_visible): Update.
7290         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7291         method.  Moved from...
7292         (struct tui_win_info) <make_visible>: ...here.
7293
7294 2019-06-25  Tom Tromey  <tom@tromey.com>
7295
7296         * tui/tui-winsource.c
7297         (tui_source_window_base::do_scroll_horizontal): Remove direction
7298         parameter.
7299         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7300         direction parameter.
7301         * tui/tui-win.c (tui_win_info::forward_scroll)
7302         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7303         (tui_win_info::right_scroll): Update.
7304         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7305         direction parameter.
7306         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7307         direction parameter.
7308         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7309         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7310         Remove direction parameter.
7311         (struct tui_source_window_base, struct tui_source_window)
7312         (struct tui_disasm_window, struct tui_data_window)
7313         (struct tui_cmd_window): Update.
7314
7315 2019-06-25  Tom Tromey  <tom@tromey.com>
7316
7317         * tui/tui-winsource.h (tui_set_exec_info_content)
7318         (tui_show_exec_info_content, tui_erase_exec_info_content)
7319         (tui_clear_exec_info_content, tui_update_exec_info): Change
7320         argument to tui_source_window_base.
7321         * tui/tui-winsource.c (tui_set_exec_info_content)
7322         (tui_show_exec_info_content, tui_erase_exec_info_content)
7323         (tui_clear_exec_info_content, tui_update_exec_info): Change
7324         argument to tui_source_window_base.
7325
7326 2019-06-25  Tom Tromey  <tom@tromey.com>
7327
7328         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7329         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7330
7331 2019-06-25  Tom Tromey  <tom@tromey.com>
7332
7333         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7334         check.
7335
7336 2019-06-25  Tom Tromey  <tom@tromey.com>
7337
7338         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7339         type to void.
7340         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7341         type to void.
7342         * tui/tui-source.c (tui_set_source_content): Update.
7343         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7344
7345 2019-06-25  Tom Tromey  <tom@tromey.com>
7346
7347         * tui/tui-win.c (window_name_completer, tui_set_focus)
7348         (tui_all_windows_info): Use name method.
7349         * tui/tui-data.h (struct tui_gen_win_info)
7350         (struct tui_source_window, struct tui_disasm_window)
7351         (struct tui_data_window, struct tui_cmd_window) <name>: New
7352         method.
7353         (tui_win_name): Don't declare.
7354         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7355         (tui_win_name): Remove.
7356
7357 2019-06-25  Tom Tromey  <tom@tromey.com>
7358
7359         * tui/tui-winsource.h (tui_update_source_window)
7360         (tui_update_source_window_as_is): Change parameter type.
7361         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7362         to be a tui_source_window_base.
7363         (tui_update_source_window_as_is): Likewise.
7364         * tui/tui-win.c (make_visible_with_new_height): Update.
7365
7366 2019-06-25  Tom Tromey  <tom@tromey.com>
7367
7368         * tui/tui-winsource.c (tui_erase_source_content)
7369         (tui_show_source_content, tui_show_exec_info_content)
7370         (tui_erase_exec_info_content): Use refresh_window method.
7371         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7372         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7373         from tui_refresh_win.
7374         (tui_data_window::refresh_window): New method.
7375         (tui_win_info::refresh, tui_source_window_base::refresh)
7376         (tui_refresh_all): Use refresh_window method.
7377         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7378         method.
7379         * tui/tui-regs.c (tui_display_register): Call refresh_window
7380         method.
7381         * tui/tui-layout.c (show_source_disasm_command)
7382         (show_source_or_disasm_and_command): Call refresh_window method.
7383         * tui/tui-data.h (struct tui_gen_win_info)
7384         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7385         New method.
7386
7387 2019-06-25  Tom Tromey  <tom@tromey.com>
7388
7389         * tui/tui.c (tui_rl_other_window, tui_enable)
7390         (tui_is_window_visible, tui_get_command_dimension): Update.
7391         * tui/tui-winsource.c (tui_update_source_window_as_is)
7392         (tui_clear_source_content, tui_erase_source_content)
7393         (tui_show_source_line, tui_source_window_base::refill)
7394         (tui_source_window_base::do_scroll_horizontal)
7395         (tui_source_window_base::set_is_exec_point_at)
7396         (tui_update_breakpoint_info, tui_set_exec_info_content)
7397         (tui_alloc_source_buffer, tui_line_is_displayed)
7398         (tui_addr_is_displayed): Update.
7399         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7400         (tui_check_and_display_highlight_if_needed)
7401         (tui_win_info::make_visible, tui_win_info::refresh)
7402         (tui_refresh_all): Update.
7403         * tui/tui-windata.c (tui_first_data_item_displayed)
7404         (tui_delete_data_content_windows, tui_erase_data_content)
7405         (tui_display_all_data, tui_data_window::refresh_all)
7406         (tui_check_data_values): Update.
7407         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7408         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7409         (tui_win_info::backward_scroll, tui_refresh_all_win)
7410         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7411         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7412         (tui_source_window_base::set_new_height)
7413         (tui_data_window::set_new_height)
7414         (make_invisible_and_set_new_height)
7415         (make_visible_with_new_height, new_height_ok)
7416         (parse_scrolling_args): Update.
7417         * tui/tui-stack.c (tui_show_frame_info): Update.
7418         * tui/tui-source.c (tui_set_source_content)
7419         (tui_set_source_content_nil, tui_source_is_displayed)
7420         (tui_source_window::do_scroll_vertical): Update.
7421         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7422         (tui_display_registers_from, tui_display_reg_element_at_line)
7423         (tui_check_register_values, tui_reg_command): Update.
7424         * tui/tui-layout.c (tui_default_win_height)
7425         (show_source_disasm_command, show_data, init_and_make_win)
7426         (show_source_or_disasm_and_command): Update.
7427         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7428         (tui_redisplay_readline, tui_mld_flush)
7429         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7430         (tui_getc): Update.
7431         * tui/tui-disasm.c (tui_set_disassem_content)
7432         (tui_disasm_window::do_scroll_vertical): Update.
7433         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7434         Now virtual.
7435         (struct tui_win_info): Derive from tui_gen_win_info.
7436         <~tui_win_info>: Mark as override.
7437         <generic>: Remove member.
7438         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7439         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7440         (~tui_data_window, ~tui_win_info)
7441         (tui_free_all_source_wins_content): Update.
7442         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7443
7444 2019-06-25  Tom Tromey  <tom@tromey.com>
7445
7446         * tui/tui-layout.c (init_and_make_win): Use new.
7447         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7448         destructor, initializers.
7449         (tui_alloc_generic_win_info): Don't declare.
7450         * tui/tui-data.c (_locator): Add argument to constructor.
7451         (source_win, disasm_win): New globals.
7452         (exec_info): Remove.
7453         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7454         Update.
7455         (tui_alloc_generic_win_info): Remove.
7456         (init_content_element): Use new.
7457         (tui_win_info::tui_win_info): Update.
7458         (free_content_elements) <case DATA_WIN>: Use delete.
7459
7460 2019-06-25  Tom Tromey  <tom@tromey.com>
7461
7462         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7463         * tui/tui-windata.c (tui_first_data_item_displayed)
7464         (tui_delete_data_content_windows): Update.
7465         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7466         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7467         (tui_display_registers_from, tui_check_register_values): Update.
7468         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7469         pointer.
7470         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7471         window.
7472         (tui_free_data_content): Update.
7473         (free_content_elements) <case DATA_WIN>: Free the window.
7474
7475 2019-06-25  Tom Tromey  <tom@tromey.com>
7476
7477         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7478         Update.
7479         * tui/tui-layout.c (make_command_window)
7480         (show_source_disasm_command, show_data, init_and_make_win)
7481         (show_source_or_disasm_and_command): Update.
7482         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7483         method.
7484         <can_highight, is_highlighted>: Now bool.
7485         (tui_set_win_highlight): Don't declare.
7486         * tui/tui-data.c (tui_set_win_highlight): Remove.
7487
7488 2019-06-25  Tom Tromey  <tom@tromey.com>
7489
7490         * tui/tui-wingeneral.c (make_visible): Remove check of window
7491         type.
7492
7493 2019-06-25  Tom Tromey  <tom@tromey.com>
7494
7495         * tui/tui-win.c (tui_win_info::max_height)
7496         (tui_cmd_window::max_height): New methods.
7497         (new_height_ok): Call max_height.
7498         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7499         <max_height>: New method.
7500
7501 2019-06-25  Tom Tromey  <tom@tromey.com>
7502
7503         * tui/tui-win.c (tui_source_window_base::set_new_height)
7504         (tui_data_window::set_new_height): New methods.
7505         (make_invisible_and_set_new_height): Call set_new_height method.
7506         * tui/tui-data.h (struct tui_win_info)
7507         (struct tui_source_window_base, struct tui_data_window)
7508         <set_new_height>: New method.
7509
7510 2019-06-25  Tom Tromey  <tom@tromey.com>
7511
7512         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7513         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7514         tui_refresh_data_win.
7515         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7516         method.
7517         (tui_refresh_all_win): Call the refresh_all method.
7518         (tui_set_focus): Likewise.
7519         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7520         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7521         Likewise.
7522
7523 2019-06-25  Tom Tromey  <tom@tromey.com>
7524
7525         * tui/tui-winsource.h (tui_refill_source_window)
7526         (tui_set_is_exec_point_at): Don't declare.
7527         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7528         (tui_source_window_base::refill): Rename from
7529         tui_refill_source_window.
7530         (tui_source_window_base::do_scroll_horizontal): Update.
7531         (tui_source_window_base::set_is_exec_point_at): Rename from
7532         tui_set_is_exec_point_at.
7533         (tui_update_all_breakpoint_info): Update.
7534         * tui/tui-stack.c (tui_show_frame_info): Update.
7535         * tui/tui-layout.c (show_data): Add cast.
7536         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7537         * tui/tui-data.h (struct tui_source_window_base) <refill,
7538         set_is_exec_point_at>: New methods.
7539         (tui_source_windows, tui_add_to_source_windows): Update types.
7540         (tui_add_to_source_windows): Remove redundant declaration.
7541         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7542         (tui_source_windows): Change return type.
7543         (tui_clear_source_windows_detail): Update.
7544         (tui_add_to_source_windows): Change type of parameter.
7545         (tui_free_all_source_wins_content): Update.
7546
7547 2019-06-25  Tom Tromey  <tom@tromey.com>
7548
7549         * tui/tui-wingeneral.c (tui_win_info::refresh)
7550         (tui_source_window_base::refresh): New methods.
7551         (tui_refresh_all): Call the refresh method.
7552         * tui/tui-data.h (struct tui_win_info)
7553         (struct tui_source_window_base) <refresh>: New method.
7554
7555 2019-06-25  Tom Tromey  <tom@tromey.com>
7556
7557         * tui/tui.h (tui_is_window_visible): Return bool.
7558         * tui/tui.c (tui_is_window_visible): Return bool.
7559         * tui/tui-wingeneral.c (tui_make_window, make_visible)
7560         (tui_make_visible, tui_make_invisible)
7561         (tui_win_info::make_visible)
7562         (tui_source_window_base::make_visible, make_all_visible)
7563         (tui_make_all_visible, tui_make_all_invisible): Update.
7564         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7565         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7566         bool.
7567         (struct tui_win_info, struct tui_source_window_base)
7568         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7569         * tui/tui-data.c (tui_init_generic_part): Update.
7570
7571 2019-06-25  Tom Tromey  <tom@tromey.com>
7572
7573         * tui/tui-wingeneral.c (tui_win_info::make_visible)
7574         (tui_source_window_base::make_visible): New methods.
7575         (make_all_visible): Make method call.
7576         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7577         (struct tui_source_window_base, struct tui_cmd_window): Override
7578         make_visible.
7579         (tui_win_is_source_type): Don't declare.
7580         * tui/tui-data.c (tui_win_is_source_type): Remove.
7581
7582 2019-06-25  Tom Tromey  <tom@tromey.com>
7583
7584         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7585         NULL check.
7586
7587 2019-06-25  Tom Tromey  <tom@tromey.com>
7588
7589         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7590         Inline constructor.  Add initializers for members.
7591         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7592         constructors; now inline in class.
7593
7594 2019-06-25  Tom Tromey  <tom@tromey.com>
7595
7596         * tui/tui-regs.c (tui_show_registers): Update.
7597         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7598         bool.
7599         * tui/tui-data.c (tui_data_window::clear_detail)
7600         (tui_data_window): Update.
7601
7602 2019-06-25  Tom Tromey  <tom@tromey.com>
7603
7604         * tui/tui-windata.c (tui_display_all_data)
7605         (tui_display_data_from_line, tui_display_data_from)
7606         (tui_check_data_values, tui_data_window::do_scroll_vertical):
7607         Update.
7608         * tui/tui-regs.c (tui_last_regs_line_no)
7609         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7610         (tui_show_registers, tui_show_register_group)
7611         (tui_display_registers_from, tui_display_reg_element_at_line)
7612         (tui_display_registers_from_line, tui_check_register_values)
7613         (tui_reg_next, tui_reg_prev): Update.
7614         * tui/tui-layout.c (tui_set_layout, show_data): Update.
7615         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
7616         tui_data_window.
7617         (struct tui_win_info) <detail>: Remove.  Add new fields from
7618         tui_data_info.
7619         (TUI_DATA_WIN): Add cast.
7620         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7621         (~tui_data_window): Simplify.
7622
7623 2019-06-25  Tom Tromey  <tom@tromey.com>
7624
7625         * tui/tui-layout.c (show_source_disasm_command)
7626         (show_source_or_disasm_and_command): Update.
7627         * tui/tui-io.c (update_cmdwin_start_line)
7628         (tui_redisplay_readline): Update.
7629         * tui/tui-data.h (struct tui_command_info): Remove.
7630         (struct tui_win_info) <detail>: Remove command_info member.
7631         (struct tui_data_window) <start_line>: New member, from
7632         tui_command_info.
7633         (TUI_CMD_WIN): Add casts.
7634
7635 2019-06-25  Tom Tromey  <tom@tromey.com>
7636
7637         * tui/tui-winsource.c (tui_update_source_window)
7638         (tui_refill_source_window)
7639         (tui_source_window_base::do_scroll_horizontal)
7640         (tui_update_breakpoint_info, tui_set_exec_info_content)
7641         (tui_show_exec_info_content, tui_erase_exec_info_content)
7642         (tui_clear_exec_info_content): Update.
7643         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7644         Update.
7645         * tui/tui-win.c (make_invisible_and_set_new_height)
7646         (make_visible_with_new_height): Update.
7647         * tui/tui-source.c (tui_set_source_content)
7648         (tui_show_symtab_source): Update.
7649         * tui/tui-layout.c (extract_display_start_addr)
7650         (show_source_disasm_command, show_data)
7651         (make_source_or_disasm_window)
7652         (show_source_or_disasm_and_command): Update.
7653         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7654         (tui_disasm_window::do_scroll_vertical): Remove shadowing
7655         "gdbarch".
7656         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
7657         to tui_source_window_base.
7658         (struct tui_win_info) <detail>: Remove source_info member.
7659         (struct tui_source_window_base) <has_locator>: Inline.
7660         Move contents from tui_source_info; rename has_locator member to
7661         m_has_locator.
7662         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7663         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7664         header file.
7665         (tui_source_window_base::clear_detail, ~tui_source_window_base):
7666         Simplify.
7667         (tui_free_all_source_wins_content): Cast to
7668         tui_source_window_base.
7669
7670 2019-06-25  Tom Tromey  <tom@tromey.com>
7671
7672         * tui/tui-win.c (make_invisible_and_set_new_height)
7673         (make_visible_with_new_height): Call has_locator method.
7674         * tui/tui-layout.c (show_source_disasm_command, show_data)
7675         (show_source_or_disasm_and_command): Update for bool change.
7676         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7677         (tui_win_info) <has_locator>: New method.
7678         (struct tui_source_window_base) <has_locator>: New method.
7679         (tui_win_has_locator): Don't declare.
7680         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7681         from tui_win_has_locator.
7682         (tui_source_window_base): Use false, not FALSE.
7683
7684 2019-06-25  Tom Tromey  <tom@tromey.com>
7685
7686         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7687         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7688         clear_detail method directly.
7689         (tui_clear_win_detail): Remove.
7690
7691 2019-06-25  Tom Tromey  <tom@tromey.com>
7692
7693         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7694         "this", not TUI_DISASM_WIN.
7695
7696 2019-06-25  Tom Tromey  <tom@tromey.com>
7697
7698         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
7699         declare.
7700         * tui/tui-winsource.c
7701         (tui_source_window_base::do_scroll_horizontal): Rename from
7702         tui_horizontal_source_scroll.
7703         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7704         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7705         from tui_vertical_data_scroll.
7706         * tui/tui-win.h (tui_scroll): Don't declare.
7707         * tui/tui-win.c (tui_win_info::forward_scroll)
7708         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7709         (tui_win_info::right_scroll): Rename and update.
7710         (tui_scroll_forward_command, tui_scroll_backward_command)
7711         (tui_scroll_left_command, tui_scroll_right_command): Update.
7712         (tui_scroll): Remove.
7713         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7714         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7715         from tui_vertical_source_scroll.
7716         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7717         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7718         from tui_vertical_disassem_scroll.
7719         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7720         do_scroll_horizontal>: New methods.
7721         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7722         Likewise.
7723         (struct tui_source_window_base): Add do_scroll_horizontal.
7724         (struct tui_source_window, struct tui_disasm_window): Add
7725         do_scroll_vertical.
7726         (struct tui_data_window, struct tui_cmd_window): Add
7727         do_scroll_horizontal and do_scroll_vertical.
7728         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7729
7730 2019-06-25  Tom Tromey  <tom@tromey.com>
7731
7732         * tui/tui-data.h (struct tui_source_window_base): New struct.
7733         (struct tui_source_window): Derive from tui_source_window_base.
7734         (struct tui_disasm_window): New struct.
7735         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7736         from tui_source_window::clear_detail.
7737         (tui_source_window_base): Rename from tui_source_window.
7738         (~tui_source_window_base): Rename from ~tui_source_window.
7739         (tui_alloc_win_info): Create a tui_disasm_window.
7740
7741 2019-06-25  Tom Tromey  <tom@tromey.com>
7742
7743         * tui/tui-data.h (struct tui_source_window)
7744         (struct tui_data_window): Declare destructors.
7745         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7746         destructors.
7747         (tui_win_info): Simplify.
7748
7749 2019-06-25  Tom Tromey  <tom@tromey.com>
7750
7751         * tui/tui-winsource.c (tui_display_main)
7752         (tui_update_source_windows_with_addr)
7753         (tui_update_all_breakpoint_info): Update.
7754         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7755         (new_height_ok, parse_scrolling_args): Update.
7756         * tui/tui-stack.c (tui_show_frame_info): Update.
7757         * tui/tui-data.h (struct tui_list): Remove.
7758         (tui_source_windows): Return a reference to a std::vector.
7759         * tui/tui-data.c (source_windows): Now a std::vector.
7760         (tui_source_windows): Change return type.
7761         (tui_clear_source_windows): Rewrite.
7762         (tui_clear_source_windows_detail, tui_add_to_source_windows)
7763         (tui_free_all_source_wins_content): Rewrite.
7764
7765 2019-06-25  Tom Tromey  <tom@tromey.com>
7766
7767         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7768         (struct tui_data_window, struct tui_cmd_window): Declare
7769         clear_detail method.
7770         * tui/tui-data.c (tui_source_window::clear_detail)
7771         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
7772         methods.
7773         (tui_clear_win_detail): Simplify.
7774
7775 2019-06-25  Tom Tromey  <tom@tromey.com>
7776
7777         * tui/tui-layout.c (make_source_window, make_disasm_window)
7778         (make_source_or_disasm_window): Remove win_info_ptr parameter.
7779         Return the new window.
7780         (show_source_disasm_command, show_data)
7781         (show_source_or_disasm_and_command): Update.
7782
7783 2019-06-25  Tom Tromey  <tom@tromey.com>
7784
7785         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
7786         parameter.  Return the new window.
7787         (show_source_disasm_command): Update and remove NULL check.
7788         (show_source_or_disasm_and_command): Update.
7789
7790 2019-06-25  Tom Tromey  <tom@tromey.com>
7791
7792         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
7793
7794 2019-06-25  Tom Tromey  <tom@tromey.com>
7795
7796         * tui/tui-data.h (struct tui_win_info): Make constructor
7797         protected.  Make destructor virtual.  Add initializers.
7798         (tui_source_window, tui_data_window, tui_cmd_window): New
7799         classes.
7800         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
7801         constructor.  Add "type" parameter.
7802         (tui_source_window, tui_data_window, tui_cmd_window): New
7803         constructors.
7804         (tui_alloc_win_info): Instantiate the appropriate subclass.
7805
7806 2019-06-25  Tom Tromey  <tom@tromey.com>
7807
7808         * tui/tui-win.c (tui_resize_all): Use delete.
7809         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
7810         destructor.
7811         (tui_free_window): Don't declare.
7812         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
7813         Update.
7814
7815 2019-06-25  Tom Tromey  <tom@tromey.com>
7816
7817         * tui/tui-data.h (struct tui_win_info): Add constructor.
7818         * tui/tui-data.c (tui_alloc_win_info): Use new.
7819         (tui_free_window): Use delete.
7820
7821 2019-06-22  Tom Tromey  <tom@tromey.com>
7822
7823         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
7824         declare.
7825         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
7826
7827 2019-06-22  Tom Tromey  <tom@tromey.com>
7828
7829         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7830         declare.
7831         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7832
7833 2019-06-22  Tom de Vries  <tdevries@suse.de>
7834
7835         * dwarf2read.c (create_addrmap_from_aranges)
7836         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
7837         instead of '%zu'.
7838
7839 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
7840
7841         * dwarf2read.h (dwarf2_section_info_def): Remove.
7842         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
7843         * dwarf2read.c (struct dwo_sections) <types>: Change type to
7844         std::vector<dwarf2_section_info>.
7845         (struct dwo_file) <~dwo_file>: Remove.
7846         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
7847         types field.
7848         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
7849         (dwarf2_read_debug_names): Likewise.
7850         (create_debug_types_hash_table): Change parameter type to
7851         array_view, adjust code accordingly.
7852         (dwarf2_locate_dwo_sections): Adjust to std::vector.
7853         (partial_die_info::fixup): Likewise.
7854         (determine_prefix): Likewise.
7855         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
7856
7857 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7858
7859         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
7860         gdb_bfd_ref_ptr.
7861         <~dwo_file>: Remove call to gdb_bfd_unref.
7862         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7863         gdb_bfd_ref_ptr::get.
7864
7865 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7866
7867         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7868         type to htab_up.
7869         * dwarf2read.c (struct dwo_file): Initialize fields.
7870         <~dwo_file>: New.
7871         (free_dwo_file): Remove, move content to ~dwo_file.
7872         (struct dwo_file_deleter): Remove.
7873         (dwo_file_up>: Remove custom deleter.
7874         (free_dwo_files): Remove.
7875         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7876         dwo_files.
7877         (process_skeletonless_type_units): Call unique_ptr::get.
7878         (allocate_dwo_file_hash_table): Add deleter to created hash
7879         table.  Change return type to htab_up.
7880         (lookup_dwo_file_slot): Don't memset dwo_file, call
7881         unique_ptr::get.
7882         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7883         (create_dwo_unit_in_dwp_v2): Likewise.
7884         (open_and_init_dwo_file): Likewise.
7885         (free_dwo_file_from_slot): Remove.
7886
7887 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
7888
7889         * dwarf2read.h (struct dwarf2_section_info) <readin,
7890         is_virtual>: Change type to bool.
7891         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7892         true instead of 1.
7893
7894 2019-06-19  Tom Tromey  <tom@tromey.com>
7895
7896         * tui/tui-data.h (tui_init_content_element): Don't declare.
7897
7898 2019-06-19  Tom Tromey  <tom@tromey.com>
7899
7900         * tui/tui-data.h (tui_init_win_info): Don't declare.
7901
7902 2019-06-19  Tom de Vries  <tdevries@suse.de>
7903
7904         * dwarf2read.h (abstract_to_concrete): Change type to
7905         std::unordered_map<sect_offset, std::vector<sect_offset>,
7906         gdb::hash_enum<sect_offset>>.
7907
7908 2019-06-19  Tom Tromey  <tromey@adacore.com>
7909
7910         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7911         EVAL_AVOID_SIDE_EFFECTS specially.
7912
7913 2019-06-19  Tom Tromey  <tromey@adacore.com>
7914
7915         * source-cache.c (highlighter): New global.
7916         (source_cache::get_source_lines): Create a highlighter on demand.
7917
7918 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7919
7920         * defs.h (deprecated_interactive_hook): Delete declaration.
7921         * interps.c (clear_interpreter_hooks): Remove use of
7922         deprecated_interactive_hook.
7923         * top.c (deprecated_interactive_hook): Delete definition.
7924         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7925
7926 2019-06-18  Tom de Vries  <tdevries@suse.de>
7927
7928         PR gdb/24515
7929         * dwarf2read.h (abstract_to_concrete): Change type from
7930         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7931         std::unordered_map<sect_offset, std::vector<sect_offset>>.
7932         * dwarf2read.c (read_variable): Update.
7933         (dwarf2_fetch_die_loc_sect_off): Update.
7934
7935 2019-06-17  Tom de Vries  <tdevries@suse.de>
7936
7937         PR gdb/24617
7938         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7939         accessing parent[parent_len - 1].
7940
7941 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
7942
7943         PR gdb/24364
7944         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7945         call dtrace_process_dof with NULL dof.
7946
7947 2019-06-16  Tom de Vries  <tdevries@suse.de>
7948
7949         PR gdb/24445
7950         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7951
7952 2019-06-16  Tom Tromey  <tom@tromey.com>
7953
7954         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7955         (make_all_visible): Use address of member.
7956
7957 2019-06-16  Tom Tromey  <tom@tromey.com>
7958
7959         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7960         (tui_free_window, free_content, free_content_elements): Remove
7961         unnecessary cast.
7962         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7963         cast.
7964         * tui/tui-regs.c (tui_show_register_group)
7965         (tui_display_registers_from, tui_display_reg_element_at_line):
7966         Remove unnecessary cast.
7967
7968 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
7969
7970         * linux-nat.c (normal_mask): Delete.
7971         (_initialize_linux_nat): Don't initialise normal_mask.
7972
7973 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
7974
7975         PR gdb/24445
7976         * dwarf-index-write.h (write_psymtabs_to_index): Add
7977         dwz_basename parameter.
7978         * dwarf-index-write.c (write_gdbindex): Move file writing to
7979         write_gdbindex_1.  Change return type void.
7980         (assert_file_size): Move up, remove filename parameter.
7981         (write_gdbindex_1): New function.
7982         (write_debug_names): Change return type to void, call
7983         assert_file_size.
7984         (struct index_wip_file): New struct.
7985         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
7986         file logic to index_wip_file.  Write index for dwz file if
7987         needed.
7988         (save_gdb_index_command): Pass basename of dwz file, if present.
7989         * dwarf-index-cache.c (index_cache::store): Obtain and pass
7990         build-id of dwz file, if present.
7991         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7992         (dwarf2_get_dwz_file): Likewise.
7993         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7994         (dwarf2_get_dwz_file): Likewise.
7995
7996 2019-06-16  Tom Tromey  <tom@tromey.com>
7997
7998         * coffread.c (process_coff_symbol): Use xstrdup.
7999         * value.c (create_internalvar): Use xstrdup.
8000
8001 2019-06-16  Tom Tromey  <tom@tromey.com>
8002
8003         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8004         * breakpoint.c (stopin_command, stopat_command)
8005         (until_break_command, decode_location_default): Remove unnecessary
8006         cast.
8007         * utils.c (subset_compare): Remove unnecessary cast.
8008         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8009         cast.
8010         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8011         cast.
8012         * infcmd.c (path_command): Remove unnecessary cast.
8013         * coffread.c (decode_type): Remove unnecessary cast.
8014         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8015         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8016         * tui/tui-stack.c (tui_show_locator_content)
8017         (tui_show_frame_info): Remove unnecessary cast.
8018         * tui/tui-win.c (tui_scroll_forward_command)
8019         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8020         (parse_scrolling_args): Remove unnecessary cast.
8021         * tui/tui-data.c (init_win_info, tui_del_window)
8022         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8023         (free_content_elements): Remove unnecessary cast.
8024         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8025         unnecessary cast.
8026         * tui/tui-source.c (tui_set_source_content)
8027         (tui_vertical_source_scroll): Remove unnecessary cast.
8028         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8029         cast.
8030         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8031         * tui/tui-regs.c (tui_display_registers_from)
8032         (tui_display_register): Remove unnecessary cast.
8033         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8034         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8035         (make_visible): Remove unnecessary cast.
8036         * tui/tui-winsource.c (tui_erase_source_content)
8037         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8038         unnecessary cast.
8039         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8040         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8041         * stabsread.c (read_type, read_array_type, read_range_type):
8042         Remove unnecessary cast.
8043         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8044         (parse_symbol, parse_type, upgrade_type, parse_external)
8045         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8046         unnecessary cast.
8047         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8048
8049 2019-06-16  Tom Tromey  <tom@tromey.com>
8050
8051         * tui/tui-data.c (tui_alloc_generic_win_info)
8052         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8053         checks.
8054
8055 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8056             Andrew Burgess  <andrew.burgess@embecosm.com>
8057
8058         * f-typeprint.c (f_print_type): Don't return early for not
8059         associated or not allocated types.
8060         (f_type_print_varspec_suffix): Add print_rank parameter and print
8061         ranks of array types in case they dangling.
8062         (f_type_print_base): Add print_rank parameter.
8063
8064 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8065
8066         * NEWS: Mention new MI commands.
8067         * break-catch-throw.c (enum exception_event_kind): Move to
8068         breakpoint.h.
8069         (print_mention_exception_catchpoint): Output text as a single
8070         message.
8071         (catch_exception_command_1): Rename to...
8072         (catch_exception_event): ...this, make non-static, update header
8073         command, and change some parameter types.
8074         (catch_catch_command): Update for changes to
8075         catch_exception_command_1.
8076         (catch_throw_command): Likewise.
8077         (catch_rethrow_command): Likewise.
8078         * breakpoint.c (enum exception_event_kind): Delete.
8079         * breakpoint.h (enum exception_event_kind): Moved here from
8080         break-catch-throw.c.
8081         (catch_exception_event): Declare.
8082         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8083         (mi_cmd_catch_throw): New function.
8084         (mi_cmd_catch_rethrow): New function.
8085         (mi_cmd_catch_catch): New function.
8086         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8087         'catch-catch' entries.
8088         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8089         (mi_cmd_catch_rethrow): Declare.
8090         (mi_cmd_catch_catch): Declare.
8091
8092 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8093
8094         * annotate.c (annotate_source_line): Change return type to void,
8095         update implementation to match.
8096         * annotate.h (annotate_source_line): Change return type to void,
8097         update header comment.
8098         * stack.c (print_frame_info): Don't change what frame information
8099         is printed based on whether annotations are on or not.
8100
8101 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8102
8103         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8104         (annotate_source): Make static.
8105         (annotate_source_line): Moved from source.c and renamed from
8106         identify_source_line.  Update the return type.
8107         * annotate.h (annotate_source): Delete declaration.
8108         (annotate_source_line): Declaration moved from source.h, and
8109         renamed from identify_source_line.  Return type updated.
8110         * source.c (identify_source_line): Moved to annotate.c and renamed
8111         to annotate_source_line.
8112         (info_line_command): Remove check of annotation_level.
8113         * source.h (identify_source_line): Move declaration to annotate.h
8114         and rename to annotate_source_line.
8115         * stack.c: Add 'annotate.h' include.
8116         (print_frame_info): Remove check of annotation_level before
8117         calling annotate_source_line.
8118
8119 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8120
8121         * source-cache.c (source_cache::get_plain_source_lines): Use
8122         open_source_file_with_line_charpos instead of just
8123         open_source_file, remove call to find_source_lines.
8124         (source_cache::get_source_lines): Likewise.
8125         * source.c (find_source_lines): Make static.
8126         (get_filename_and_charpos): Renamed into...
8127         (open_source_file_with_line_charpos): ..this along with changes to
8128         return a scoped_fd, and some other minor clean ups.
8129         (identify_source_line): Use open_source_file_with_line_charpos.
8130         (search_command_helper): Use open_source_file_with_line_charpos
8131         instead of just open_source_file, remove call to
8132         find_source_lines.
8133         * source.h (open_source_file_with_line_charpos): Declare new
8134         function.
8135         (find_source_lines): Delete declaration.
8136
8137 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8138
8139         * source.c (get_filename_and_charpos): Remove fullname
8140         parameter.
8141         (identify_source_line): Update call to get_filename_and_charpos.
8142
8143 2019-06-14  Tom Tromey  <tromey@adacore.com>
8144
8145         PR gdb/24502:
8146         * ui-style.h (skip_ansi_escape): Update comment.
8147         * ui-file.h (class no_terminal_escape_file): New class.
8148         * ui-file.c (no_terminal_escape_file::write)
8149         (no_terminal_escape_file::puts): New methods.
8150         * cli/cli-logging.c (handle_redirections): Use
8151         no_terminal_escape_file.
8152
8153 2019-06-14  Tom Tromey  <tromey@adacore.com>
8154
8155         * NEWS: Move convenience variable news above Python news.
8156
8157 2019-06-14  Tom Tromey  <tom@tromey.com>
8158
8159         * gnulib: Move directory to top-level.
8160         * configure.ac: Don't configure gnulib.
8161         * configure: Rebuild.
8162         * common/common-defs.h: Use new path to gnulib.
8163         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8164         (GNULIB_H): Remove.
8165         (INCGNU): Look in new gnulib location.
8166         (HFILES_NO_SRCDIR): Remove gnulib files.
8167         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8168         (generated_files): Remove GNULIB_H.
8169         ($(LIBGNU), all-lib): Remove targets.
8170         (distclean): Don't mention GNULIB_BUILDDIR.
8171         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8172
8173 2019-06-14  Tom Tromey  <tromey@adacore.com>
8174
8175         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8176         Warn if symbol file does not provide any symbols.
8177
8178 2019-06-14  Tom Tromey  <tromey@adacore.com>
8179
8180         * source.c (find_and_open_source): Respect basenames_may_differ.
8181
8182 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8183
8184         * annotate.c (annotate_breakpoints_invalid): Make use of
8185         scoped_restore_terminal_state.
8186         (annotate_frames_invalid): Likewise.
8187
8188 2019-06-14  Tom Tromey  <tromey@adacore.com>
8189
8190         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8191         allow assignment to an internalvar.
8192
8193 2019-06-14  Tom Tromey  <tromey@adacore.com>
8194
8195         * ada-lex.l: Allow "_" in attribute names.
8196
8197 2019-06-14  Tom Tromey  <tromey@adacore.com>
8198
8199         PR gdb/24653:
8200         * regcache.c (registers_changed): Don't call alloca.
8201         * top.c (execute_command): Don't call alloca.
8202
8203 2019-06-13  Pedro Alves  <palves@redhat.com>
8204
8205         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8206         'expression'.  When parsing an expression, error out if there's
8207         junk after "unlimited".
8208         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8209         (do_set_command): Adjust calls to is_unlimited_literal.
8210
8211 2019-06-13  Pedro Alves  <palves@redhat.com>
8212
8213         * compile/compile.c (make_compile_options_def_group): Add braces
8214         around array_view initializer.
8215         * thread.c (make_thread_apply_all_options_def_group)
8216         (make_thread_apply_all_options_def_group): Likewise.
8217
8218 2019-06-13  Pedro Alves  <palves@redhat.com>
8219
8220         * NEWS (New commands): Mention "maint test-options
8221         require-delimiter", "maint test-options unknown-is-error", "maint
8222         test-options unknown-is-operand" and "maint show
8223         test-options-completion-result".
8224         (New command options, command completion): New section.
8225         (Completion improvements): New section.
8226         Mention that you can abbreviate "unlimited".
8227
8228 2019-06-13  Pedro Alves  <palves@redhat.com>
8229
8230         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8231         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8232         * unittests/cli-utils-selftests.c (test_parse_flags)
8233         (test_parse_flags_qcs): Delete.
8234         (test_cli_utils): Don't call deleted functions.
8235
8236 2019-06-13  Pedro Alves  <palves@redhat.com>
8237
8238         * thread.c: Include "cli/cli-option.h".
8239         (tp_array_compar_ascending): Global.
8240         (tp_array_compar): Delete function.
8241         (tp_array_compar_ascending, tp_array_compar_descending): New
8242         functions.
8243         (ascending_option_def, qcs_flag_option_def)
8244         (thr_qcs_flags_option_defs)
8245         (make_thread_apply_all_options_def_group)
8246         (make_thread_apply_options_def_group): New.
8247         (thread_apply_all_command): Use gdb::option::process_options.
8248         (thread_apply_command_completer)
8249         (thread_apply_all_command_completer): New.
8250         (thread_apply_command): Use gdb::option::process_options.
8251         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8252         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8253         to generate help text of "thread apply".  Adjust "taas"'s help.
8254         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8255         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8256
8257 2019-06-13  Pedro Alves  <palves@redhat.com>
8258
8259         * thread.c (thread_apply_command): Check for invalid TID with
8260         isdigit instead of !isalpha.
8261
8262 2019-06-13  Pedro Alves  <palves@redhat.com>
8263
8264         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8265         (validate_flags_qcs): New.
8266         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8267         (validate_flags_qcs): Declare.
8268         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8269         (make_frame_apply_options_def_group): New.
8270         (frame_apply_command_count): Process options with
8271         gdb::option::process_options.
8272         (frame_apply_completer): New.
8273         (frame_apply_level_completer, frame_apply_all_completer)
8274         (frame_apply_completer): New.
8275         (_initialize_stack): Update help of "frame apply", "frame apply
8276         level", "frame apply all" and "faas" to mention supported options
8277         and install command completers.
8278         * stack.h (frame_apply_all_completer): Declare.
8279         * thread.c: Include "stack.h".
8280         (tfaas_command): Add "--".
8281         (_initialize_thread): Update help "tfaas" to mention supported
8282         options and install command completer.
8283
8284 2019-06-13  Pedro Alves  <palves@redhat.com>
8285
8286         * completer.c (complete_nested_command_line): New.
8287         (gdb_completion_word_break_characters_throw): Add assertion.
8288         * completer.h (complete_nested_command_line): Declare.
8289
8290 2019-06-13  Pedro Alves  <palves@redhat.com>
8291
8292         * stack.c (parse_backtrace_qualifiers): New.
8293         (backtrace_command): Use it.
8294         (backtrace_command_completer): Complete on qualifiers.
8295
8296 2019-06-13  Pedro Alves  <palves@redhat.com>
8297
8298         * frame.c: Include "cli/cli-option.h.
8299         (user_set_backtrace_options): New.
8300         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8301         Delete.
8302         (get_prev_frame): Adjust.
8303         (boolean_option_def, uinteger_option_def)
8304         (set_backtrace_option_defs): New.
8305         (_initialize_frame): Adjust and use
8306         gdb::option::add_setshow_cmds_for_options to install "set
8307         backtrace past-main" and "set backtrace past-entry".
8308         * frame.h: Include "cli/cli-option.h".
8309         (struct frame_print_options): Forward declare.
8310         (print_frame_arguments_all, print_frame_arguments_scalars)
8311         (print_frame_arguments_none): Declare.
8312         (print_entry_values): Delete declaration.
8313         (struct frame_print_options, user_frame_print_options): New.
8314         (struct set_backtrace_options): New.
8315         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8316         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8317         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8318         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8319         (list_args_or_locals): Add frame_print_options parameter.
8320         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8321         * python/py-framefilter.c (enumerate_args): Pass down
8322         USER_FRAME_PRINT_OPTIONS.
8323         * stack.c: Include "cli/cli-option.h".
8324         (print_frame_arguments_all, print_frame_arguments_scalars)
8325         (print_frame_arguments_none): Declare.
8326         (print_raw_frame_arguments, print_entry_values): Delete.
8327         (user_frame_print_options): New.
8328         (boolean_option_def, enum_option_def, frame_print_option_defs):
8329         New.
8330         (struct backtrace_cmd_options): New.
8331         (bt_flag_option_def): New.
8332         (backtrace_command_option_defs): New.
8333         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8334         (print_frame_arg, read_frame_arg, print_frame_args)
8335         (print_frame_info, print_frame): Add frame_print_options parameter
8336         and use it.
8337         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8338         (backtrace_command_1): Add frame_print_options and
8339         backtrace_cmd_options parameters and use them.
8340         (make_backtrace_options_def_group): New.
8341         (backtrace_command): Process command options with
8342         gdb::option::process_options.
8343         (backtrace_command_completer): New.
8344         (_initialize_stack): Extend "backtrace"'s help to mention
8345         supported options.  Install completer for "backtrace".
8346         Install some settings commands with add_setshow_cmds_for_options.
8347
8348 2019-06-13  Pedro Alves  <palves@redhat.com>
8349
8350         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8351         and that "set/show print raw frame-arguments" are now deprecated.
8352
8353         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8354         command.
8355         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8356         * stack.c (_initialize_stack): Install "set/show print
8357         raw-frame-arguments", and deprecate "set/show print raw
8358         frame-arguments".
8359         * valprint.c (_initialize_valprint): Deprecate "set/show print
8360         raw".
8361
8362 2019-06-13  Pedro Alves  <palves@redhat.com>
8363
8364         * compile/compile.c (struct compile_options): New.
8365         (compile_flag_option_def, compile_command_option_defs)
8366         (make_compile_options_def_group): New.
8367         (compile_file_command): Handle options with
8368         gdb::option::process_options.
8369         (compile_file_command_completer): New function.
8370         (compile_code_command): Handle options with
8371         gdb::option::process_options.
8372         (compile_code_command_completer): New function.
8373         (_initialize_compiler): Install completers for "compile code" and
8374         "compile file".  Mention available options in "compile code" and
8375         "compile code"'s help.
8376         * completer.c (advance_to_completion_word): New, factored out from
8377         ...
8378         (advance_to_expression_complete_word_point): ... this.
8379         (advance_to_filename_complete_word_point): New.
8380         * completer.h (advance_to_filename_complete_word_point): New
8381         declaration.
8382
8383 2019-06-13  Pedro Alves  <palves@redhat.com>
8384
8385         * compile/compile.c: Include "cli/cli-option.h".
8386         (compile_print_value): Scope data pointer is now a
8387         value_print_options pointer; adjust.
8388         (compile_print_command): Process options.  Scope data pointer is
8389         now a value_print_options pointer; adjust.
8390         (_initialize_compile): Update "compile print"'s help to include
8391         supported options.  Install a completer for "compile print".
8392         * cp-valprint.c (show_vtblprint, show_objectprint)
8393         (show_static_field_print): Delete.
8394         (_initialize_cp_valprint): Don't install "set print
8395         static-members", "set print vtbl", "set print object" here.
8396         * printcmd.c: Include "cli/cli-option.h" and
8397         "common/gdb_optional.h".
8398         (print_command_parse_format): Rework to fill in a
8399         value_print_options instead of a format_data.
8400         (print_value): Change parameter type from format_data pointer to
8401         value_print_options reference.  Adjust.
8402         (print_command_1): Process options.  Adjust to pass down a
8403         value_print_options.
8404         (print_command_completer): New.
8405         (_initialize_printcmd): Install print_command_completer as
8406         handle_brkchars completer for the "print" command.  Update
8407         "print"'s help to include supported options.
8408         * valprint.c: Include "cli/cli-option.h".
8409         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8410         here from cp-valprint.c.
8411         (boolean_option_def, uinteger_option_def)
8412         (value_print_option_defs, make_value_print_options_def_group):
8413         New.  Use gdb::option::add_setshow_cmds_for_options to install
8414         "set print elements", "set print null-stop", "set print repeats",
8415         "set print pretty", "set print union", "set print array", "set
8416         print address", "set print symbol", "set print array-indexes".
8417         * valprint.h: Include <string> and "cli/cli-option.h".
8418         (make_value_print_options_def_group): Declare.
8419         (print_value): Change parameter type from format_data pointer to
8420         value_print_options reference.
8421         (print_command_completer): Declare.
8422
8423 2019-06-13  Pedro Alves  <palves@redhat.com>
8424
8425         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8426         (COMMON_SFILES): Add maint-test-settings.c.
8427         * cli/cli-decode.c (boolean_enums): New global, factored out from
8428         ...
8429         (add_setshow_boolean_cmd): ... here.
8430         * cli/cli-decode.h (boolean_enums): Declare.
8431         * cli/cli-option.c: New file.
8432         * cli/cli-option.h: New file.
8433         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8434         factored out from ...
8435         (parse_cli_boolean_value(const char *)): ... this.
8436         (is_unlimited_literal): Change parameter type to pointer to
8437         pointer.  Adjust and advance ARG pointer.
8438         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8439         (parse_cli_var_enum): New, factored out from ...
8440         (do_set_command): ... this.  Adjust.
8441         * cli/cli-setshow.h (parse_cli_boolean_value)
8442         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8443         (parse_cli_var_enum): Declare.
8444         * cli/cli-utils.c: Include "cli/cli-option.h".
8445         (get_ulongest): New.
8446         * cli/cli-utils.h (get_ulongest): Declare.
8447         (check_for_argument): New overloads.
8448         * maint-test-options.c: New file.
8449
8450 2019-06-13  Pedro Alves  <palves@redhat.com>
8451
8452         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8453         parse a range if "-" is at the end of the string.
8454
8455 2019-06-13  Pedro Alves  <palves@redhat.com>
8456
8457         * cli/cli-setshow.c (parse_auto_binary_operation)
8458         (parse_cli_boolean_value): Don't allow "o".
8459
8460 2019-06-13  Pedro Alves  <palves@redhat.com>
8461
8462         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8463         * NEWS: Mention maint test-settings KIND.
8464         * maint-test-settings.c: New file.
8465
8466 2019-06-13  Pedro Alves  <palves@redhat.com>
8467
8468         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8469         completer.
8470         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8471         "set" completers.
8472
8473 2019-06-13  Pedro Alves  <palves@redhat.com>
8474
8475         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8476         after item.
8477
8478 2019-06-13  Pedro Alves  <palves@redhat.com>
8479
8480         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8481
8482 2019-06-13  Pedro Alves <palves@redhat.com>
8483
8484         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8485         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8486         call.
8487         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8488         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8489         calls.
8490         (check_for_argument): Skip spaces after argument.
8491
8492 2019-06-13  Pedro Alves  <palves@redhat.com>
8493
8494         * thread.c (thread_apply_command): Adjust TID parsing.
8495         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8496         detected before end of string.
8497         (tid_is_in_list): Error out if LIST is invalid.
8498
8499 2019-06-13  Pedro Alves  <palves@redhat.com>
8500
8501         * completer.c (complete_line_internal_1): Rewind completion word
8502         point.
8503         (completion_tracker::advance_custom_word_point_by): Change
8504         parameter type to int.
8505         * completer.h (completion_tracker::advance_custom_word_point_by):
8506         Likewise.
8507
8508 2019-06-13  Pedro Alves  <palves@redhat.com>
8509
8510         * completer.c (advance_to_completion_word): Handle delimiters.
8511
8512 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8513
8514         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8515
8516 2019-06-11  Tom Tromey  <tom@tromey.com>
8517
8518         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8519         (xmalloc_failed): Move to alloc.c.
8520         * alloc.c: New file.
8521         * Makefile.in (COMMON_SFILES): Add alloc.c.
8522
8523 2019-06-11  Tom Tromey  <tom@tromey.com>
8524
8525         * nat/linux-waitpid.c: Don't include server.h.
8526         (linux_debug): Remove.
8527         (my_waitpid): Update.
8528
8529 2019-06-11  Tom Tromey  <tromey@adacore.com>
8530
8531         * infcall.c (_initialize_infcall): Remove trailing newline from
8532         help.
8533         * user-regs.c (_initialize_user_regs): Remove trailing newline
8534         from help.
8535         * typeprint.c (_initialize_typeprint): Remove trailing newline
8536         from help.
8537         * reverse.c (_initialize_reverse): Remove trailing newlines from
8538         help.
8539         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8540         from help.
8541         * language.c (add_set_language_command): Remove trailing newline
8542         from help.
8543         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8544         help.
8545         * disasm.c (_initialize_disasm): Remove trailing newline from
8546         help.
8547         * top.c (init_main): Remove trailing newline from help.
8548         * interps.c (_initialize_interpreter): Remove trailing newline
8549         from help.
8550         * btrace.c (_initialize_btrace): Remove trailing newlines from
8551         help.
8552         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8553         from help.
8554         * python/python.c (_initialize_python): Remove trailing newline
8555         from help.
8556         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8557         help.
8558         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8559         from help.  Reformat some text.
8560         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8561         from help.
8562         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8563         newline from help.
8564
8565 2019-06-11  Tom Tromey  <tromey@adacore.com>
8566
8567         * darwin-nat.c (darwin_decode_exception_message)
8568         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8569
8570 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8571
8572         * valops.c (value_slice): Check for not allocated or not
8573         associated values.
8574
8575 2019-06-10  Tom de Vries  <tdevries@suse.de>
8576
8577         PR gdb/24618
8578         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8579         sure an empty slot (defined by a 32-bit zero pair) is recognized as
8580         invalid.
8581
8582 2019-06-10  Tom de Vries  <tdevries@suse.de>
8583
8584         PR gdb/24611
8585         * linespec.c (linespec_lexer_lex_string): Remove incorrect
8586         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
8587
8588 2019-06-10  Tom de Vries  <tdevries@suse.de>
8589
8590         PR symtab/24545
8591         * symtab.c (struct demangled_name_entry): Add language field.
8592         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
8593         static minimal symbol".  Set and use language field.
8594
8595 2019-06-10  Tom Tromey  <tromey@adacore.com>
8596
8597         * ada-lang.c (_initialize_ada_language): Update help text.
8598
8599 2019-06-10  Tom Tromey  <tromey@adacore.com>
8600
8601         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8602         with a newline.
8603         * guile/guile.c (handle_boot_error): Don't end warning with a
8604         newline.
8605         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8606         warning with a newline.
8607         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8608         newline.
8609         (s12z_frame_cache): Likewise.
8610         * dwarf-index-cache.c (index_cache::store): Don't end warning with
8611         a newline.
8612         * solib-svr4.c (disable_probes_interface): Don't end warning with
8613         a newline.
8614         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8615         newline.
8616         * python/python.c (do_finish_initialization): Don't end warning
8617         with a newline.
8618
8619 2019-06-10  Tom Tromey  <tom@tromey.com>
8620
8621         * python/py-breakpoint.c (gdbpy_breakpoint_created)
8622         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8623         gdbpy_enter.
8624
8625 2019-06-10  Tom Tromey  <tromey@adacore.com>
8626
8627         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8628         data.
8629         (elf_new_init): Don't call stabsread_new_init.
8630         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8631         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
8632         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8633
8634 2019-06-10  Tom de Vries  <tdevries@suse.de>
8635
8636         PR symtab/16264
8637         PR symtab/24517
8638         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8639
8640 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
8641
8642         * source.c (find_and_open_source): Also rewrite relative file
8643         names.
8644
8645 2019-04-26  Amos Bird  <amosbird@gmail.com>
8646
8647         * annotate.c (annotate_thread_exited): Add "thread-exited"
8648         annotation.
8649
8650 2019-06-06  Tom Tromey  <tromey@adacore.com>
8651
8652         * maint.h (class scoped_command_stats): Use
8653         DISABLE_COPY_AND_ASSIGN.
8654         <print_time>: New method.
8655         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8656         print_time.
8657         (scoped_command_stats::print_time): New method.
8658
8659 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
8660
8661         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8662         instructions of lengths 6 or 8 bytes.
8663
8664 2019-06-04  Pedro Alves  <palves@redhat.com>
8665
8666         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8667
8668         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8669         * breakpoint.c (condition_completer): Likewise.
8670         * cli/cli-dump.c (scan_expression): Likewise.
8671         * common/filestuff.c (mkdir_recursive): Likewise.
8672         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8673         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8674         (gdb_abspath): Likewise.
8675         * compile/compile-cplus-types.c
8676         (compile_cplus_instance::decl_name): Likewise.
8677         * completer.c (complete_explicit_location):
8678         (signal_completer, reg_or_group_completer_1): Likewise.
8679         * cp-support.c (cp_remove_params_if_any): Likewise.
8680         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8681         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8682         * infcmd.c (strip_bg_char): Likewise.
8683         * linespec.c (copy_token_string): Likewise.
8684         * mi/mi-main.c (output_cores): Likewise.
8685         * psymtab.c (psymtab_search_name):
8686         * symfile.c (test_set_ext_lang_command): Likewise.
8687         * target.c (target_fileio_read_stralloc): Likewise.
8688         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8689         * value.c (complete_internalvar): Likewise.
8690
8691 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
8692
8693         Add objfile property to gdb.Type.
8694         * NEWS: Mention Python API addition.
8695         * python/py-type.c (typy_get_objfile): New method.
8696
8697 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8698
8699         * NEWS: Mention the new set|show style [title|highlight].
8700         Mention changes to "show style", "help" and "apropos".
8701
8702 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8703
8704         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8705         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
8706         instead of print_help_for_command.
8707         (print_doc_of_command): New function.
8708         (help_list): Add 'apropos -v word' suggestion.
8709         (print_help_for_command): Style the command name using title style.
8710         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8711         (_initialize_cli_cmds): Describe -v in apropos_command help.
8712
8713 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8714
8715         * cli/cli-style.h (cli_style_option): Add name in constructor,
8716         add m_name class member, add constructor with intensity,
8717         add name class function.
8718         (cli_style_option::add_setshow_commands): Remove name argument.
8719         (highlight_style, title_style): New styles.
8720         * cli/cli-style.c (do_show): New function that shows a style
8721         characteristic styling the style name with itself.
8722         (set_style_name): New function.
8723         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8724         Update all callers according to the changes in cli/cli-style.h.
8725         * utils.h (fputs_highlighted): New function.
8726         * utils.c (fputs_highlighted): Likewise.
8727
8728 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8729
8730         * NEWS: Mention new pipe command and new convenience variables.
8731
8732 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8733
8734         * cli/cli-cmds.c (pipe_command): New function.
8735         (_initialize_cli_cmds): Call add_com for pipe_command.
8736         Define | as an alias for pipe.
8737         (exit_status_set_internal_vars): New function.
8738         (shell_escape): Call exit_status_set_internal_vars.
8739         cli/cli-decode.c (find_command_name_length): Recognize | as
8740         a single character command.
8741
8742 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8743
8744         * gdbcmd.h (execute_command_to_ui_file): New declaration.
8745         top.c (execute_command_to_ui_file): New function, mostly a copy
8746         of execute_command_to_string.
8747         (execute_command_to_string): Implement by calling
8748         execute_command_to_ui_file.
8749
8750 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8751
8752         * top.h (saved_command_line): Remove declaration.
8753         * top.c (previous_saved_command_line, previous_repeat_arguments):
8754         New variables.
8755         (saved_command_line): Make static, define together with other
8756         'repeat variables'.
8757         (dont_repeat): Clear repeat_arguments.
8758         (repeat_previous, get_saved_command_line, save_command_line):
8759         New functions.
8760         (gdb_init): Initialize saved_command_line
8761         and previous_saved_command_line.
8762         * main.c (captured_main_1): Remove saved_command_line initialization.
8763         * event-top.c (handle_line_of_input): Update to use
8764         the new 'repeat' related functions instead of direct access to
8765         saved_command_line.
8766         * command.h (repeat_previous, get_saved_command_line,
8767         save_command_line): New declarations.
8768         (dont_repeat): Add comment.
8769
8770 2019-05-30  Tom Tromey  <tromey@adacore.com>
8771
8772         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
8773         Fix comment.
8774         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
8775
8776 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
8777
8778         PR cli/24587
8779         * completer.c (complete): Initialize variable word.
8780
8781 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
8782
8783         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8784         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
8785         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
8786         'body' is NULL to the outter 'if', protecting the '!is_define'
8787         situation as well.
8788
8789 2019-05-29  Tom Tromey  <tromey@adacore.com>
8790
8791         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
8792         (dwarf_unknown): New function.
8793         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
8794         (dwarf_type_encoding_name): Use dwarf_unknown.
8795
8796 2019-05-29  Tom Tromey  <tromey@adacore.com>
8797
8798         PR c++/20020:
8799         * cp-valprint.c (cp_print_value_fields): Call
8800         cp_print_static_field inside "try".
8801
8802 2019-05-29  Tom Tromey  <tromey@adacore.com>
8803
8804         * inflow.c (struct terminal_info): Add default operator=.
8805         * configure: Rebuild.
8806         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
8807         -Wdeprecated-copy-dtor, -Wredundant-move.
8808
8809 2019-05-29  Tom Tromey  <tromey@adacore.com>
8810
8811         * NEWS: Add entry.
8812         * infcmd.c (print_return_value_1): Handle finish_print
8813         option.
8814         (show_print_finish): New function.
8815         (_initialize_infcmd): Add "set/show print finish" commands.
8816         * valprint.c (user_print_options): Initialize new member.
8817         * valprint.h (struct value_print_options) <finish_print>: New
8818         member.
8819
8820 2019-05-28  Tom Tromey  <tromey@adacore.com>
8821
8822         * ada-lang.c (ada_remove_Xbn_suffix)
8823         (find_old_style_renaming_symbol)
8824         (parse_old_style_renaming): Remove.
8825         (ada_find_renaming_symbol): Don't call
8826         find_old_style_renaming_symbol.
8827         (ada_is_renaming_symbol): Rename from
8828         ada_find_renaming_symbol.  Remove "block" parameter.  Return
8829         bool.  Now static.
8830         (ada_read_var_value): Update and simplify.
8831         * ada-exp.y (write_var_or_type): Remove old code.
8832
8833 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
8834
8835         PR gdb/25010
8836         * event-top.c: Remove include comment.
8837         * inflow.c (class scoped_ignore_sigttou): Move from here...
8838         * inflow.h (class scoped_ignore_sigttou): ...to here.
8839         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
8840         * top.c:  Remove include comment.
8841
8842 2019-05-27  Tom Tromey  <tom@tromey.com>
8843
8844         * NEWS: Fix typo.
8845
8846 2019-05-22  Tom Tromey  <tromey@adacore.com>
8847
8848         * target.c (target_follow_exec): Constify parameter.
8849         * target-delegates.c: Rebuild.
8850         * remote.c (remote_target::follow_exec): Constify parameter.
8851         * infrun.c (follow_exec): Constify parameter.
8852         * target.h (struct target_ops) <follow_exec>: Constify parameter.
8853         (target_follow_exec): Likewise.
8854
8855 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8856
8857         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
8858         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
8859
8860 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
8861
8862         * NEWS: Add debugredirect and testsuite sections.
8863
8864 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
8865
8866         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8867         target descriptions using exclusively floating point register name
8868         aliases.
8869
8870 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
8871
8872         PR gdb/18644:
8873         * f-lang.c (build_fortran_types): Handle the case where
8874         gdbarch_floatformat_for_type returns a nullptr.
8875
8876 2019-05-21  Tom de Vries  <tdevries@suse.de>
8877
8878         PR cli/24587
8879         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8880
8881 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8882
8883         PR gdb/18644:
8884         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8885         16-byte floats.
8886         * i386-tdep.c (i386_floatformat_for_type): Use
8887         floatformats_ia64_quad for the 16-byte floating point component
8888         within a fortran 32-byte complex number.
8889
8890 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8891
8892         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8893         delete default constructor.
8894         (find_partial_die): Update to return const struct.
8895         (partial_die_parent_scope): Move variable declaration into scope
8896         of its use and change its type to auto.
8897         (guess_partial_die_structure_name): Likewise.
8898         (partial_die_info::fixup): Likewise.
8899
8900 2019-05-17  Tom Tromey  <tromey@adacore.com>
8901
8902         * source.c (find_and_open_source): Remove cast.
8903
8904 2019-05-17  Tom Tromey  <tromey@adacore.com>
8905
8906         * annotate.c (annotate_source): Make "filename" const.
8907         * annotate.h (annotate_source): Use const.
8908
8909 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8910
8911         * disasm.c (set_disassembler_options): Send errors to stderr.
8912
8913 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8914
8915         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8916         (cli_interp_base::set_logging): Check debug_redirect.
8917         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8918         * cli/cli-logging.c (debug_redirect): Add static variable.
8919         (pop_output_files): Add default param.
8920         (handle_redirections): Print debug setting.
8921         (show_logging_command): Likewise.
8922         (_initialize_cli_logging): Add debugredirect command.
8923         * interps.c (current_interp_set_logging): Add debug_redirect
8924         parameter.
8925         * interps.h (set_logging): Add debug_redirect parameter.
8926         (current_interp_set_logging): Likewise.
8927         * mi/mi-common.h: Likewise.
8928         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8929
8930 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
8931             Tom Tromey  <tromey@adacore.com>
8932
8933         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8934         directly.
8935         * cli/cli-interp.h (make_logging_output): Remove declaration.
8936         * cli/cli-logging.c (make_logging_output): Remove function.
8937         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8938         directly.
8939         * ui-file.c (tee_file::tee_file): Remove bools.
8940         (tee_file::~tee_file): Remove deletes.
8941         * ui-file.h (tee_file): Remove bools.
8942
8943 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
8944
8945         * mi/mi-cmds.h (mi_cmd_complete): New function.
8946         * mi/mi-main.c (mi_cmd_complete): Likewise.
8947         * mi/mi-cmds.c: Define new MI command -complete.
8948         * NEWS: Mention new -complete command.
8949
8950 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
8951
8952         * completer.h (complete): New function.
8953         * completer.c (complete): Likewise.
8954         * cli/cli-cmds.c: (complete_command): Update to use new complete()
8955         function defined in completer.h.
8956
8957 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
8958
8959         * MAINTAINERS (Write After Approval): Add myself.
8960
8961 2019-05-17  Tom de Vries  <tdevries@suse.de>
8962
8963         PR gdb/24094
8964         * dwarf2read.c (struct cu_partial_die_info): New struct.
8965         (find_partial_die): Return cu_partial_die_info.
8966         (partial_die_parent_scope, guess_partial_die_structure_name)
8967         (partial_die_info::fixup): Handle new return type of find_partial_die.
8968
8969 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8970
8971         PR breakpoints/24541
8972         * stap-probe.c (stap_parse_register_operand): Make "regname" an
8973         "std::string", simplifying the algorithm.
8974
8975 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8976
8977         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8978         (stap_static_probe_ops::get_probes): Likewise.
8979
8980 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8981
8982         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8983         '-')" and "else if".
8984         (stap_parse_single_operand): Join checks for
8985         "gdbarch_stap_parse_special_token_p" and
8986         "gdbarch_stap_parse_special_token" in the same "if" statement.
8987         Invert check when verifying for operation on register
8988         displacement.
8989
8990 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8991
8992         * stap-probe.c (stap_get_opcode): Update comment.
8993         (stap_get_expected_argument_type): Likewise.
8994         (handle_stap_probe): Likewise.
8995
8996 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
8997
8998         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8999         return type to 'bool'.  Adjust comment.  Use 'bool' when
9000         appropriate.
9001         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9002         * stap-probe.c (stap_parse_argument_1): Likewise.
9003         (stap_is_operator): Likewise.
9004         (stap_is_generic_prefix): Likewise.
9005         (stap_is_register_prefix): Likewise.
9006         (stap_is_register_indirection_prefix): Likewise.
9007         (stap_is_integer_prefix): Likewise.
9008         (stap_generic_check_suffix): Likewise.
9009         (stap_check_integer_suffix): Likewise.
9010         (stap_check_register_suffix): Likewise.
9011         (stap_check_register_indirection_suffix): Likewise.
9012         (stap_parse_register_operand): Likewise.
9013         (stap_parse_single_operand): Likewise.
9014         (stap_parse_argument_1): Likewise.
9015         (stap_probe::get_argument_count): Likewise.
9016         (stap_is_operator): Likewise.
9017
9018 2019-05-16  Tom Tromey  <tromey@adacore.com>
9019
9020         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9021         keyword to foreach.
9022
9023 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9024
9025         * linux-thread-db.c (try_thread_db_load_1): Change return type
9026         to bool.
9027         (try_thread_db_load): Likewise.
9028         (try_thread_db_load_from_pdir_1): Likewise.
9029         (try_thread_db_load_from_pdir): Likewise.
9030         (try_thread_db_load_from_sdir): Likewise.
9031         (try_thread_db_load_from_dir): Likewise.
9032         (thread_db_load_search): Likewise.
9033         (has_libpthread): Likewise.
9034         (thread_db_load): Likewise.
9035
9036 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9037
9038         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9039         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9040         NULL, and complain/return if that's the case.
9041
9042 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9043
9044         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9045         (advance, posn, abstract_read_memory): New functions.
9046         [struct mem_read_abstraction]: New struct.
9047         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9048
9049 2019-05-14  Tom Tromey  <tromey@adacore.com>
9050
9051         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9052         value is not lval_memory.
9053
9054 2019-05-14  Tom Tromey  <tromey@adacore.com>
9055
9056         * solib.c (info_sharedlibrary_command): Style the file name.
9057
9058 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9059
9060         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9061         (aarch64_vnv_type): Likewise.
9062         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9063         * common/tdesc.c: Likewise.
9064         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9065         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9066         * features/aarch64-fpu.xml: Add ieee half view.
9067         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9068         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9069         * gdbtypes.h (struct builtin_type): Likewise.
9070         (struct objfile_type): Likewise.
9071
9072 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9073
9074         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9075         typo.
9076         * location.h (string_to_event_location): Likewise.
9077
9078 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9079
9080         GDB 8.3 released.
9081
9082 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9083
9084         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9085         New variable declaration.
9086         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9087         New variable.
9088         (print_one_breakpoint): Use ui_out::test_flags and new global
9089         variable to compute use_fixed_output.
9090         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9091         Remove.
9092         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9093         (mi_multi_location_breakpoint_output_fixed): Remove.
9094         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9095         new variable.
9096         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9097         fix_multi_location_breakpoint_output flag if version >= 3.
9098         * ui-out.h (enum ui_out_flag)
9099         <fix_multi_location_breakpoint_output>: New enumerator.
9100
9101 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9102
9103         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9104
9105 2019-05-10  Tom Tromey  <tromey@adacore.com>
9106
9107         * ada-lang.c (catch_ada_completer): New function.
9108         (_initialize_ada_language): Use it.
9109
9110 2019-05-10  Tom Tromey  <tromey@adacore.com>
9111
9112         * thread.c (print_thread_info): Make "requested_threads" const.
9113         * gdbthread.h (print_thread_info): Make "requested_threads"
9114         const.
9115         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9116         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9117
9118 2019-05-08  Tom Tromey  <tom@tromey.com>
9119
9120         * gdbtypes.c (objfile_type_data): Change type.
9121         (objfile_type, _initialize_gdbtypes): Update.
9122
9123 2019-05-08  Tom Tromey  <tom@tromey.com>
9124
9125         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9126         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9127         (_initialize_dwarf2_frame): Update.
9128
9129 2019-05-08  Tom Tromey  <tom@tromey.com>
9130
9131         * objc-lang.c (objc_objfile_data): Change type.
9132         (find_methods): Update.
9133         (_initialize_objc_lang): Remove.
9134
9135 2019-05-08  Tom Tromey  <tom@tromey.com>
9136
9137         * stabsread.c (rs6000_builtin_type_data): Change type.
9138         (rs6000_builtin_type, _initialize_stabsread): Update.
9139
9140 2019-05-08  Tom Tromey  <tom@tromey.com>
9141
9142         * mips-tdep.c (mips_pdr_data): Remove.
9143         (_initialize_mips_tdep): Update.
9144
9145 2019-05-08  Tom Tromey  <tom@tromey.com>
9146
9147         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9148         (hppa_init_objfile_priv_data, read_unwind_info)
9149         (find_unwind_entry, _initialize_hppa_tdep): Update.
9150
9151 2019-05-08  Tom Tromey  <tom@tromey.com>
9152
9153         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9154         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9155         on obstack.
9156         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9157
9158 2019-05-08  Tom Tromey  <tom@tromey.com>
9159
9160         * mdebugread.c (basic_type_data): Change type.
9161         (basic_type, _initialize_mdebugread): Update.
9162
9163 2019-05-08  Tom Tromey  <tom@tromey.com>
9164
9165         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9166
9167 2019-05-08  Tom Tromey  <tom@tromey.com>
9168
9169         * nto-tdep.c (nto_inferior_data_reg): Change type.
9170         (nto_inferior_data): Update.
9171         (nto_inferior_data_cleanup, nto_new_inferior_data)
9172         (_initialize_nto_tdep): Remove.
9173         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9174
9175 2019-05-08  Tom Tromey  <tom@tromey.com>
9176
9177         * ada-lang.c (struct ada_inferior_data): Add initializers.
9178         (ada_inferior_data): Change type.
9179         (ada_inferior_data_cleanup): Remove.
9180         (get_ada_inferior_data, ada_inferior_exit)
9181         (struct ada_pspace_data): Add initializers, destructor.
9182         (ada_pspace_data_handle): Change type.
9183         (get_ada_pspace_data): Update.
9184         (ada_pspace_data_cleanup): Remove.
9185
9186 2019-05-08  Tom Tromey  <tom@tromey.com>
9187
9188         * coffread.c (struct coff_symfile_info): Add initializers.
9189         (coff_objfile_data_key): Move lower.  Change type.
9190         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9191         Update.
9192         (coff_free_info): Remove.
9193
9194 2019-05-08  Tom Tromey  <tom@tromey.com>
9195
9196         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9197         (fbsd_pspace_data_handle): Move lower.  Change type.
9198         (get_fbsd_pspace_data): Update.
9199         (fbsd_pspace_data_cleanup): Remove.
9200         (_initialize_fbsd_tdep): Update.
9201
9202 2019-05-08  Tom Tromey  <tom@tromey.com>
9203
9204         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9205         (get_ada_tasks_pspace_data): Update.
9206         (ada_tasks_pspace_data_cleanup): Remove.
9207         (_initialize_tasks): Update.
9208         (ada_tasks_inferior_data_handle): Change type.
9209         (get_ada_tasks_inferior_data): Update.
9210         (ada_tasks_inferior_data_cleanup): Remove.
9211         (struct ada_tasks_pspace_data): Add initializers.
9212
9213 2019-05-08  Tom Tromey  <tom@tromey.com>
9214
9215         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9216         * symfile-debug.c (debug_sym_get_probes): Change type.
9217         * stap-probe.c (handle_stap_probe):
9218         (stap_static_probe_ops::get_probes): Change type.
9219         * probe.h (class static_probe_ops) <get_probes>: Change type.
9220         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9221         (parse_probes_in_pspace): Update.
9222         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9223         Update.
9224         (any_static_probe_ops::get_probes): Change type.
9225         * elfread.c (elfread_data): New typedef.
9226         (probe_key): Change type.
9227         (elf_get_probes): Likewise.  Update.
9228         (probe_key_free): Remove.
9229         (_initialize_elfread): Update.
9230         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9231         Change type.
9232         (dtrace_process_dof_probe, dtrace_process_dof)
9233         (dtrace_static_probe_ops::get_probe): Change type.
9234
9235 2019-05-08  Tom Tromey  <tom@tromey.com>
9236
9237         * xcoffread.c (struct xcoff_symfile_info): Rename from
9238         coff_symfile_info.  Add initializers.
9239         (xcoff_objfile_data_key): Move lower.  Change type.
9240         (XCOFF_DATA): Rewrite.
9241         (xcoff_free_info): Remove.
9242         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9243         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9244         (xcoff_initial_scan): Update.
9245
9246 2019-05-08  Tom Tromey  <tom@tromey.com>
9247
9248         * solib-svr4.c (struct svr4_info): Add initializers and
9249         destructor.
9250         <probes_table>: Now an htab_up.
9251         (solib_svr4_pspace_data): Change type.
9252         (free_probes_table): Simplify.
9253         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9254         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9255         (probes_table_remove_objfile_probes, register_solib_event_probe)
9256         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9257         (_initialize_svr4_solib): Update.
9258
9259 2019-05-08  Tom Tromey  <tom@tromey.com>
9260
9261         * remote.c (remote_pspace_data): Change type.
9262         (remote_pspace_data_cleanup): Remove.
9263         (get_remote_exec_file, set_pspace_remote_exec_file)
9264         (_initialize_remote): Update.
9265
9266 2019-05-08  Tom Tromey  <tom@tromey.com>
9267
9268         * breakpoint.c (breakpoint_objfile_key): Change type.
9269         (get_breakpoint_objfile_data): Update.
9270         (free_breakpoint_objfile_data): Remove.
9271         (_initialize_breakpoint): Update.
9272
9273 2019-05-08  Tom Tromey  <tom@tromey.com>
9274
9275         * linux-tdep.c (struct linux_info): Add initializers.
9276         (linux_inferior_data): Move.  Change type.
9277         (invalidate_linux_cache_inf): Update.
9278         (linux_inferior_data_cleanup): Remove.
9279         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9280
9281 2019-05-08  Tom Tromey  <tom@tromey.com>
9282
9283         * auxv.c (auxv_inferior_data): Move.  Change type.
9284         (auxv_inferior_data_cleanup): Remove.
9285         (invalidate_auxv_cache_inf): Rewrite.
9286         (get_auxv_inferior_data, _initialize_auxv): Update.
9287
9288 2019-05-08  Tom Tromey  <tom@tromey.com>
9289
9290         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9291         (symfile_debug_objfile_data_key): Change type.
9292         (symfile_debug_installed, debug_qf_has_symbols)
9293         (debug_qf_find_last_source_symtab)
9294         (debug_qf_forget_cached_source_info)
9295         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9296         (debug_qf_print_stats, debug_qf_dump)
9297         (debug_qf_expand_symtabs_for_function)
9298         (debug_qf_expand_all_symtabs)
9299         (debug_qf_expand_symtabs_with_fullname)
9300         (debug_qf_map_matching_symbols)
9301         (debug_qf_expand_symtabs_matching)
9302         (debug_qf_find_pc_sect_compunit_symtab)
9303         (debug_qf_map_symbol_filenames)
9304         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9305         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9306         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9307         (debug_sym_read_linetable, debug_sym_relocate): Update.
9308         (symfile_debug_free_objfile): Remove.
9309         (install_symfile_debug_logging, _initialize_symfile_debug):
9310         Update.
9311
9312 2019-05-08  Tom Tromey  <tom@tromey.com>
9313
9314         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9315         allocate_on_obstack.
9316         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9317         (get_dwarf2_per_objfile): Update.
9318         (set_dwarf2_per_objfile): Remove.
9319         (dwarf2_has_info, dwarf2_get_section_info): Update.
9320         (dwarf2_free_objfile): Remove.
9321         (_initialize_dwarf2_read): Update.
9322
9323 2019-05-08  Tom Tromey  <tom@tromey.com>
9324
9325         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9326         initializers.
9327         <unsupported_script_warning_printed,
9328         script_not_found_warning_printed>: Now bool.
9329         (auto_load_pspace_data): Change type.
9330         (~auto_load_pspace_info): Rename from
9331         auto_load_pspace_data_cleanup.
9332         (get_auto_load_pspace_data, init_loaded_scripts_info)
9333         (clear_section_scripts, maybe_print_unsupported_script_warning)
9334         (maybe_print_script_not_found_warning, _initialize_auto_load):
9335         Update.
9336
9337 2019-05-08  Tom Tromey  <tom@tromey.com>
9338
9339         * objfiles.c (objfile_pspace_info): Add destructor and
9340         initializers.
9341         (objfiles_pspace_data): Change type.
9342         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9343         (get_objfile_pspace_data): Update.
9344         (objfiles_bfd_data): Change type.
9345         (get_objfile_bfd_data): Update.
9346         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9347
9348 2019-05-08  Tom Tromey  <tom@tromey.com>
9349
9350         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9351         Change type.
9352         (get_catch_syscall_inferior_data): Update.
9353         (catch_syscall_inferior_data_cleanup): Remove.
9354         (_initialize_break_catch_syscall): Update.
9355
9356 2019-05-08  Tom Tromey  <tom@tromey.com>
9357
9358         * inflow.c (struct terminal_info): Add destructor and
9359         initializers.
9360         (inflow_inferior_data): Change type.
9361         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9362         (get_inflow_inferior_data, inflow_inferior_exit)
9363         (swap_terminal_info, _initialize_inflow): Update.
9364
9365 2019-05-08  Tom Tromey  <tom@tromey.com>
9366
9367         * target-dcache.c (target_dcache_cleanup): Remove.
9368         (target_dcache_aspace_key): Change type.
9369         (target_dcache_init_p, target_dcache_invalidate)
9370         (target_dcache_get, target_dcache_get_or_init)
9371         (_initialize_target_dcache): Update.
9372         * dcache.h (struct dcache_deleter): New.
9373
9374 2019-05-08  Tom Tromey  <tom@tromey.com>
9375
9376         * symtab.c (struct symbol_cache): Add destructor and
9377         initializers.
9378         (symbol_cache_key): Move.  Change type.
9379         (make_symbol_cache, free_symbol_cache): Remove.
9380         (get_symbol_cache): Update.
9381         (symbol_cache_cleanup): Remove.
9382         (ALL_PSPACES, symbol_cache_flush)
9383         (maintenance_print_symbol_cache)
9384         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9385         Update.
9386
9387 2019-05-08  Tom Tromey  <tom@tromey.com>
9388
9389         * symtab.c (struct main_info): Add destructor and initializers.
9390         (main_progspace_key): Move.  Change type.
9391         (get_main_info): Update.
9392         (main_info_cleanup): Remove.
9393         (_initialize_symtab): Update.
9394
9395 2019-05-08  Tom Tromey  <tom@tromey.com>
9396
9397         * registry.h (DECLARE_REGISTRY): Define the _key class.
9398
9399 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9400
9401         * NEWS: Merge two 'New commands' sections.
9402
9403 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9404
9405         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9406         parameter and use Ada language definition instead.
9407         (ada_val_print_ptr): Remove unused language parameter.
9408         (ada_val_print_num): Remove language parameter and use Ada language
9409         definition instead.
9410         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9411         parameter.
9412         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9413         parameter and use Ada language definition instead.
9414         (ada_val_print_1): Update all ada_val_print_xxx calls.
9415         Remove language parameter.
9416         (ada_val_print): Update ada_val_print_1 call.
9417
9418 2019-05-08  Tom Tromey  <tromey@adacore.com>
9419
9420         * remote.c (remote_hw_watchpoint_limit)
9421         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9422         Now static.
9423
9424 2019-05-08  Tom Tromey  <tromey@adacore.com>
9425
9426         * maint.c (_initialize_maint_cmds): Move initialization code to
9427         remote.c.
9428         (watchdog, show_watchdog): Move to remote.c.
9429         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9430         "watchdog" static.
9431         (_initialize_remote): Move initialization code from maint.c.
9432         * defs.h (watchdog): Don't declare.
9433
9434 2019-05-08  Tom Tromey  <tromey@adacore.com>
9435
9436         * tui/tui-interp.c: Include main.h.
9437         * interps.c: Include main.h.
9438         * main.h (interpreter_p): Declare.
9439         * defs.h (interpreter_p): Don't declare.
9440
9441 2019-05-08  Tom Tromey  <tromey@adacore.com>
9442
9443         * dwarf2loc.c: Include dwarf2read.h.
9444         * defs.h (read_unsigned_leb128): Don't declare.
9445         * dwarf2read.h (read_unsigned_leb128): Declare.
9446
9447 2019-05-08  Tom Tromey  <tromey@adacore.com>
9448
9449         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9450         method.
9451
9452 2019-05-08  Tom Tromey  <tromey@adacore.com>
9453
9454         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9455         when no wrap column is set.
9456
9457 2019-05-08  Tom Tromey  <tromey@adacore.com>
9458
9459         * c-lang.c (c_get_string): Handle non-C-style arrays.
9460
9461 2019-05-08  Tom Tromey  <tromey@adacore.com>
9462
9463         * typeprint.c (print_offset_data::update): Print the bit offset,
9464         not the number of bits remaining.
9465
9466 2019-05-08  Tom Tromey  <tromey@adacore.com>
9467
9468         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9469         padding at end of comment.
9470
9471 2019-05-08  Tom Tromey  <tromey@adacore.com>
9472
9473         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9474         Compare main types.
9475
9476 2019-05-06  Tom Tromey  <tom@tromey.com>
9477
9478         * common/scoped_mmap.c: Include common-defs.h.
9479         * common/scoped_mmap.h: Don't include config.h.
9480
9481 2019-05-04  Tom Tromey  <tom@tromey.com>
9482
9483         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9484         (struct aarch64_call_info): Add initializers.
9485         <si>: Now a std::vector.
9486         (pass_on_stack, aarch64_push_dummy_call): Update.
9487
9488 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9489             Tom Tromey  <tom@tromey.com>
9490
9491         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9492         (ppc_threads): Now a std::vector.  Now static.
9493         (hwdebug_find_thread_points_by_tid)
9494         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9495         Update.
9496
9497 2019-05-04  Tom Tromey  <tom@tromey.com>
9498
9499         * arc-tdep.c (arc_tdesc_init): Return bool.
9500
9501 2019-05-04  Tom Tromey  <tom@tromey.com>
9502
9503         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9504         Use gdb_assert_not_reached.
9505
9506 2019-05-04  Tom Tromey  <tom@tromey.com>
9507
9508         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9509         "false".
9510
9511 2019-05-04  Tom Tromey  <tom@tromey.com>
9512
9513         * arc-tdep.c (arc_tdesc_init): Use bool.
9514
9515 2019-05-04  Tom Tromey  <tom@tromey.com>
9516
9517         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9518
9519 2019-05-04  Tom Tromey  <tom@tromey.com>
9520
9521         * cli/cli-cmds.c (valid_command_p): Return bool.
9522
9523 2019-05-04  Tom Tromey  <tom@tromey.com>
9524
9525         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9526         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9527
9528 2019-05-04  Raul Tambre  <raul@tambre.ee>
9529
9530         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9531         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9532         operator for comparison.
9533
9534 2019-05-04  Tom Tromey  <tom@tromey.com>
9535
9536         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9537         (lookup_partial_symbol, print_partial_symbols)
9538         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9539         (psymbol_compare): Update.
9540         (add_psymbol_to_bcache): Clear the entire psymbol.
9541         (maintenance_check_psymtabs): Update.
9542         * psympriv.h (struct partial_symbol): Don't derive from
9543         general_symbol_info.
9544         <obj_section, unrelocated_address, address,
9545         set_unrelocated_address>: Update.
9546         <ginfo>: New member.
9547         * dwarf-index-write.c (write_psymbols, debug_names::insert)
9548         (debug_names::write_psymbols): Update.
9549
9550 2019-05-04  Tom de Vries  <tdevries@suse.de>
9551
9552         * contrib/cc-with-tweaks.sh: Support -n arg.
9553
9554 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9555
9556         * corelow.c (core_target::detach): Ensure frame cache and
9557         register caches are cleared.
9558         inferior.c (exit_inferior_1): Likewise.
9559
9560 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
9561             Tom Tromey  <tom@tromey.com>
9562
9563         * dictionary.c (collate_pending_symbols_by_language): Remove
9564         "struct" from foreach.
9565         * symtab.c (lookup_global_symbol_from_objfile)
9566         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9567         foreach.
9568         * ser-tcp.c (net_open): Remove "struct" from foreach.
9569         * objfiles.c (objfile_relocate, objfile_rebase)
9570         (objfile_has_symbols): Remove "struct" from foreach.
9571         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9572         from foreach.
9573         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9574         foreach.
9575         * darwin-nat.c (thread_info_from_private_thread_info): Remove
9576         "struct" from foreach.
9577         * ada-lang.c (create_excep_cond_exprs)
9578         (ada_exception_catchpoint_cond_string): Remove "struct" from
9579         foreach.
9580
9581 2019-05-03  Tom Tromey  <tromey@adacore.com>
9582
9583         * ada-exp.y (convert_char_literal): Check suffix of each
9584         enumerator.
9585
9586 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
9587
9588         PR ada/21406:
9589         * ada-exp.y (yywrap): Don't define.
9590         * ada-lex.l (%option): Add noyywrap
9591         (yywrap): Remove.
9592
9593 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
9594
9595         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9596         _WIN32_WINNT to the XP level, unless already defined to a higher
9597         level.
9598
9599         * unittests/parse-connection-spec-selftests.c:
9600         * ser-tcp.c:
9601         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
9602         override.
9603
9604         * symfile.c (find_separate_debug_file): Remove colon from the
9605         drive spec of DOS/Windows file names of the target, so that the
9606         file name produced from DEBUGDIR and the target's directory will
9607         be valid on DOS/Windows systems.
9608
9609 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9610
9611         * rust-lang.c (val_print_struct): Handle printing structures
9612         containing strings.
9613
9614 2019-05-02  Tom Tromey  <tromey@adacore.com>
9615
9616         * valarith.c (_initialize_valarith): Remove.
9617
9618 2019-05-01  Tom Tromey  <tromey@adacore.com>
9619
9620         * ada-lang.c (ada_value_primitive_field): Treat more fields as
9621         bitfields.
9622
9623 2019-05-01  Tom Tromey  <tromey@adacore.com>
9624
9625         * ada-lang.c (ada_value_assign): Correctly compute starting offset
9626         for big-endian copies.
9627
9628 2019-04-30  Ali Tamur  <tamur@google.com>
9629         * gdb/dwarf2read.c (read_3_bytes): New declaration.
9630         (read_attribute_value): Added DW_FORM_strx1-4 cases.
9631         (read_3_bytes): New function.
9632
9633 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9634
9635         * windows-nat.c (main_thread_id): Delete.
9636         (handle_output_debug_string): Replace main_thread_id by
9637         current_event.dwThreadId.
9638         (fake_create_process): Likewise.
9639         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9640         Do not set main_thread_id.
9641         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9642         current_event.dwThreadId.
9643         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9644
9645 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9646
9647         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9648         Use current_event.dwThreadId instead of main_thread_id.
9649
9650 2019-04-30  Tom Tromey  <tromey@adacore.com>
9651
9652         * ada-lang.c (ada_lookup_simple_minsyms): New function.
9653         (create_excep_cond_exprs): Iterate over program spaces.
9654         (ada_exception_catchpoint_cond_string): Examine all minimal
9655         symbols for exception types.
9656
9657 2019-04-30  Tom Tromey  <tromey@adacore.com>
9658
9659         PR c++/24470:
9660         * dwarf2read.c (process_structure_scope): Handle case where type
9661         has template parameters but no symbol was created.
9662
9663 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9664             Chris January  <chris.january@arm.com>
9665
9666         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9667         qualifier.
9668         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9669
9670 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9671
9672         * f-typeprint.c (f_print_type): Update rules for printing
9673         whitespace.
9674         (f_type_print_varspec_suffix): Likewise.
9675
9676 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9677             Chris January  <chris.january@arm.com>
9678
9679         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9680         function arguments.
9681
9682 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9683
9684         * f-lang.c (build_fortran_types): Change name of void type to
9685         lower case.
9686         * f-typeprint.c (f_type_print_base): Print the name of the void
9687         type, rather than a fixed string.
9688         * f-valprint.c (f_decorations): Use lower case void string.
9689
9690 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9691             Chris January  <chris.january@arm.com>
9692
9693         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9694         types for Fortran.
9695
9696 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9697             Chris January  <chris.january@arm.com>
9698             David Lecomber  <david.lecomber@arm.com>
9699
9700         * f-exp.y (BINOP_INTRINSIC): New token.
9701         (exp): New parser rule handling BINOP_INTRINSIC.
9702         (f77_keywords): Add new builtin procedures.
9703         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9704         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9705         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9706         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9707         (print_unop_subexp_f): New function.
9708         (print_binop_subexp_f): New function.
9709         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9710         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9711         (dump_subexp_body_f): Likewise.
9712         (operator_check_f): Likewise.
9713         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9714         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9715
9716 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9717
9718         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9719         UNOP_KIND.
9720         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9721         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9722         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9723         (operator_length_f): New fuction.
9724         (print_subexp_f): New function.
9725         (op_name_f): New function.
9726         (dump_subexp_body_f): New function.
9727         (operator_check_f): New function.
9728         (exp_descriptor_f): Replace standard expression handling functions
9729         with new functions.
9730         * gdb/fortran-operator.def: New file.
9731         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9732         * gdb/std-operator.def: Remove UNOP_KIND.
9733
9734 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9735
9736         * std-operator.def: Remove unbalanced, stray double quote
9737         character.
9738
9739 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9740             Chris January  <chris.january@arm.com>
9741             Daniel Everett  <daniel.everett@arm.com>
9742             Nick Forrington  <nick.forrington@arm.com>
9743             Richard Bunt  <richard.bunt@arm.com>
9744
9745         * cp-valprint.c (cp_print_value_fields): Allow an additional level
9746         of depth when printing anonymous structs or unions.
9747         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9748         Don't print either the top-level value, or the children if the
9749         max-depth is exceeded.
9750         (ppscm_print_children): When printing the key of a map, allow one
9751         extra level of depth.
9752         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9753         print either the top-level value, or the children if the max-depth
9754         is exceeded.
9755         (print_children): When printing the key of a map, allow one extra
9756         level of depth.
9757         * python/py-value.c (valpy_format_string): Add max_depth keyword.
9758         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9759         (user_print_options): Initialise max_depth field.
9760         (val_print_scalar_or_string_type_p): New function.
9761         (val_print): Check to see if the max depth has been reached.
9762         (val_print_check_max_depth): Define new function.
9763         (show_print_max_depth): New function.
9764         (_initialize_valprint): Add 'print max-depth' option.
9765         * valprint.h (struct value_print_options) <max_depth>: New field.
9766         (val_print_check_max_depth): Declare new function.
9767         * NEWS: Document new feature.
9768
9769 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9770
9771         * ada-lang.c (ada_language_defn): Initialise new field.
9772         * c-lang.c (c_is_string_type_p): New function.
9773         (c_language_defn): Initialise new field.
9774         (cplus_language_defn): Initialise new field.
9775         (asm_language_defn): Initialise new field.
9776         (minimal_language_defn): Initialise new field.
9777         * c-lang.h (c_is_string_type_p): Declare new function.
9778         * d-lang.c (d_language_defn): Initialise new field.
9779         * f-lang.c (f_is_string_type_p): New function.
9780         (f_language_defn): Initialise new field.
9781         * go-lang.c (go_is_string_type_p): New function.
9782         (go_language_defn): Initialise new field.
9783         * language.c (default_is_string_type_p): New function.
9784         (unknown_language_defn): Initialise new field.
9785         (auto_language_defn): Initialise new field.
9786         * language.h (struct language_defn) <la_is_string_type_p>: New
9787         member variable.
9788         (default_is_string_type_p): Declare new function.
9789         * m2-lang.c (m2_language_defn): Initialise new field.
9790         * objc-lang.c (objc_language_defn): Initialise new field.
9791         * opencl-lang.c (opencl_language_defn): Initialise new field.
9792         * p-lang.c (pascal_is_string_type_p): New function.
9793         (pascal_language_defn): Initialise new field.
9794         * rust-lang.c (rust_is_string_type_p): New function.
9795         (rust_language_defn): Initialise new field.
9796
9797 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9798
9799         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
9800         New field.
9801         * ada-lang.c (ada_language_defn): Initialise new field.
9802         * c-lang.c (c_language_defn): Likewise.
9803         (cplus_language_defn): Likewise.
9804         (asm_language_defn): Likewise.
9805         (minimal_language_defn): Likewise.
9806         * d-lang.c (d_language_defn): Likewise.
9807         * f-lang.c (f_language_defn): Likewise.
9808         * go-lang.c (go_language_defn): Likewise.
9809         * language.c (unknown_language_defn): Likewise.
9810         (auto_language_defn): Likewise.
9811         * m2-lang.c (m2_language_defn): Likewise.
9812         * objc-lang.c (objc_language_defn): Likewise.
9813         * opencl-lang.c (opencl_language_defn): Likewise.
9814         * p-lang.c (pascal_language_defn): Likewise.
9815         * rust-lang.c (rust_language_defn): Likewise.
9816
9817 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9818
9819         * ada-lang.c (ada_is_character_type): Change return type to bool.
9820         (ada_is_string_type): Likewise.
9821         * ada-lang.h (ada_is_character_type): Update declaration
9822         (ada_is_string_type): Likewise.
9823
9824 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9825
9826         Support style in 'frame|thread apply'
9827
9828         * gdbcmd.h (execute_command_to_string): New term_out parameter.
9829         * record.c (record_start, record_stop): Update callers of
9830         execute_command_to_string with false.
9831         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9832         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
9833         methods.
9834         (class string_file): New constructor with term_out parameter.
9835         Override methods term_out and can_emit_style_escape.  New member
9836         term_out.
9837         (class stdio_file): Override can_emit_style_escape.
9838         (class tee_file): Override term_out and can_emit_style_escape.
9839         * utils.h (can_emit_style_escape): Remove.
9840         * utils.c (can_emit_style_escape): Likewise.
9841         Update all callers of can_emit_style_escape (SOMESTREAM) to
9842         SOMESTREAM->can_emit_style_escape.
9843         * source-cache.c (source_cache::get_source_lines): Likewise.
9844         * stack.c (frame_apply_command_count): Call execute_command_to_string
9845         passing the term_out characteristic of the current gdb_stdout.
9846         * thread.c (thr_try_catch_cmd): Likewise.
9847         * top.c (execute_command_to_string): pass term_out parameter
9848         to construct the string_file for the command output.
9849         * ui-file.c (term_cli_styling): New function (most code moved
9850         from utils.c can_emit_style_escape).
9851         (string_file::string_file, string_file::can_emit_style_escape,
9852         stdio_file::can_emit_style_escape, tee_file::term_out,
9853         tee_file::can_emit_style_escape): New functions.
9854
9855 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9856
9857         * NEWS: Mention the new set|show may-call-functions.
9858         * infcall.c (may_call_functions_p): New variable.
9859         (show_may_call_functions_p): New function.
9860         (call_function_by_hand_dummy): Throws an error if not
9861         may-call-functions.
9862         (_initialize_infcall): Call add_setshow_boolean_cmd for
9863         may-call-functions.
9864
9865 2019-04-25  Keith Seitz  <keiths@redhat.com>
9866
9867         PR c++/24367
9868         * cp-support.c (inspect_type): Don't attempt substitutions
9869         of symbol with the same name.
9870
9871 2019-04-25  Tom Tromey  <tromey@adacore.com>
9872
9873         PR gdb/24475:
9874         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9875         static.
9876
9877 2019-04-25  Tom Tromey  <tromey@adacore.com>
9878
9879         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9880         rvalue reference.
9881         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9882         (gdb_xml_parser::parse): Use std::move.
9883         * python/python-internal.h (gdbpy_convert_exception): Take a const
9884         reference.
9885         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9886         std::move.
9887         * python/py-utils.c (gdbpy_convert_exception): Take a const
9888         reference.
9889         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9890         Use std::move.
9891         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9892         Use std::move.
9893         * mi/mi-main.c (mi_print_exception): Take a const reference.
9894         * main.c (handle_command_errors): Take a const reference.
9895         * linespec.c (parse_linespec): Use std::move.
9896         * infcall.c (run_inferior_call): Use std::move.
9897         (call_function_by_hand_dummy): Use std::move.
9898         * exec.c (try_open_exec_file): Use std::move.
9899         * exceptions.h (exception_print, exception_fprintf)
9900         (exception_print_same): Update.
9901         * exceptions.c (print_exception, exception_print)
9902         (exception_fprintf, exception_print_same): Change parameters to
9903         const reference.
9904         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9905         * common/new-op.c: Use std::move.
9906         * common/common-exceptions.h (struct gdb_exception): Add move
9907         constructor.
9908         (struct gdb_exception_error, struct gdb_exception_quit, struct
9909         gdb_quit_bad_alloc): Change constructor to move constructor.
9910         (throw_exception): Change parameter to rvalue reference.
9911         * common/common-exceptions.c (throw_exception): Take rvalue
9912         reference.
9913         * cli/cli-interp.c (safe_execute_command): Use std::move.
9914         * breakpoint.c (insert_bp_location, location_to_sals): Use
9915         std::move.
9916
9917 2019-04-25  Tom Tromey  <tromey@adacore.com>
9918
9919         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9920         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9921         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9922         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9923         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9924         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9925         guile/scm-value.c: Use unpack.
9926         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9927         gdbscm_gdb_exception.
9928         (gdbscm_throw_gdb_exception): Likewise.
9929         (struct gdbscm_gdb_exception): New.
9930         (unpack): New function.
9931         (gdbscm_wrap): Use unpack.
9932
9933 2019-04-25  Tom Tromey  <tromey@adacore.com>
9934
9935         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9936         (gdb_rl_callback_handler): Use std::move.
9937         * common/common-exceptions.h (struct gdb_exception): Add move
9938         assignment operator.
9939         (throw_exception_sjlj): Change "exception" to const reference.
9940         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9941         (throw_exception_sjlj): Change "exception" to const reference.
9942
9943 2019-04-25  Tom Tromey  <tromey@adacore.com>
9944
9945         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9946         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9947         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9948         Update.
9949         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9950         Update.
9951         * mi/mi-interp.c (mi_interp::exec): Update.
9952         * linespec.c (parse_linespec): Update.
9953         * infcall.c (run_inferior_call): Update.
9954         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9955         * guile/scm-symbol.c (gdbscm_lookup_symbol)
9956         (gdbscm_lookup_global_symbol): Update.
9957         * guile/scm-param.c (gdbscm_parameter_value): Update.
9958         * guile/scm-frame.c (gdbscm_frame_read_register)
9959         (gdbscm_frame_read_var): Update.
9960         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9961         * exec.c (try_open_exec_file): Update.
9962         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9963         (gdb_rl_callback_handler): Update.
9964         * common/common-exceptions.h (exception_none): Don't declare.
9965         * common/common-exceptions.c (exception_none): Don't define.
9966         (struct catcher) <exception>: Update.
9967         * cli/cli-interp.c (safe_execute_command): Update.
9968         * breakpoint.c (insert_bp_location, location_to_sals): Update.
9969
9970 2019-04-25  Ali Tamur  <tamur@google.com>
9971
9972         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9973         (read_attribute_value): Likewise.
9974         (dwarf2_read_addr_index): Update comment.
9975         (read_str_index): Add DW_FORM_strx.
9976         (dwarf2_string_attr): Likewise.
9977         (dwarf2_const_value_attr): Likewise.
9978         (dump_die_shallow): Likewise.
9979         (dwarf2_fetch_constant_bytes): Likewise.
9980         (skip_form_bytes): Likewise.
9981         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9982
9983 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
9984
9985         PR corefiles/11608
9986         PR corefiles/18187
9987         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9988         OFFSET.  Verify if current mapping contains an ELF header.
9989         (linux_find_memory_regions_full): Adjust call to
9990         dump_mapping_p.
9991
9992 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
9993             Kang Li <kanglictf@gmail.com>
9994
9995         PR gdb/21600
9996
9997         * dwarf2-frame.c (read_initial_length): Be consistent about using
9998         unsigned representation of length.
9999         (decode_frame_entry_1): Likewise.  Check for wraparound of
10000         end pointer as well as buffer overflow.
10001
10002 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10003
10004         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10005         "vq".
10006
10007 2019-04-24  Tom Tromey  <tromey@adacore.com>
10008
10009         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10010
10011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10012
10013         * s12z-tdep.c (s12z_unwind_pc): Delete.
10014         (s12z_unwind_sp): Delete.
10015         (s12z_gdbarch_init): Don't register deleted functions with
10016         gdbarch.
10017
10018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10019
10020         * rl78-tdep.c (rl78_unwind_sp): Delete.
10021         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10022
10023 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10024
10025         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10026         (xstormy16_unwind_pc): Delete.
10027         (xstormy16_dummy_id): Delete.
10028         (xstormy16_gdbarch_init): Don't register deleted functions with
10029         gdbarch.
10030
10031 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10032
10033         * vax-tdep.c (vax_unwind_pc): Delete.
10034         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10035
10036 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10037
10038         * v850-tdep.c (v850_unwind_sp): Delete.
10039         (v850_unwind_pc): Delete.
10040         (v850_dummy_id): Delete.
10041         (v850_gdbarch_init): Don't register deleted functions with
10042         gdbarch.
10043
10044 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10045
10046         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10047         (tilegx_unwind_pc): Delete.
10048         (tilegx_unwind_dummy_id): Delete.
10049         (tilegx_gdbarch_init): Don't register deleted functions with
10050         gdbarch.
10051
10052 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10053
10054         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10055         (tic6x_dummy_id): Delete.
10056         (tic6x_gdbarch_init): Don't register deleted functions with
10057         gdbarch.
10058
10059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10060
10061         * sparc-tdep.c (sparc_unwind_pc): Delete.
10062         (sparc32_gdbarch_init): Don't register deleted function with
10063         gdbarch.
10064
10065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10066
10067         * sh-tdep.c (sh_unwind_sp): Delete.
10068         (sh_unwind_pc): Delete.
10069         (sh_dummy_id): Delete.
10070         (sh_gdbarch_init): Don't register deleted functions with
10071         gdbarch.
10072
10073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10074
10075         * score-tdep.c (score_unwind_sp): Delete.
10076         (score_unwind_pc): Delete.
10077         (score_dummy_id): Delete.
10078         (score_gdbarch_init): Don't register deleted functions with
10079         gdbarch.
10080
10081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10082
10083         * rx-tdep.c (rx_unwind_pc): Delete.
10084         (rx_unwind_sp): Delete.
10085         (rx_dummy_id): Delete.
10086         (rx_gdbarch_init): Don't register deleted functions with
10087         gdbarch.  Update comment.
10088
10089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10090
10091         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10092         (rs6000_dummy_id): Delete.
10093         (rs6000_gdbarch_init): Don't register deleted functions with
10094         gdbarch.
10095
10096 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10097
10098         * or1k-tdep.c (or1k_dummy_id): Delete.
10099         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10100
10101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10102
10103         * nios2-tdep.c (nios2_dummy_id): Delete.
10104         (nios2_unwind_sp): Delete.
10105         (nios2_gdbarch_init): Don't register deleted functions with
10106         gdbarch.
10107
10108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10109
10110         * nds32-tdep.c (nds32_dummy_id): Delete.
10111         (nds32_unwind_pc): Delete.
10112         (nds32_unwind_sp): Delete.
10113         (nds32_gdbarch_init): Don't register deleted functions with
10114         gdbarch.
10115
10116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10117
10118         * msp430-tdep.c (msp430_unwind_pc): Delete.
10119         (msp430_unwind_sp): Delete.
10120         (msp430_dummy_id): Delete.
10121         (msp430_gdbarch_init): Don't register deleted functions with
10122         gdbarch.
10123
10124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10125
10126         * moxie-tdep.c (moxie_unwind_sp): Delete.
10127         (moxie_unwind_pc): Delete.
10128         (moxie_dummy_id): Delete.
10129         (moxie_gdbarch_init): Don't register deleted functions with
10130         gdbarch.
10131
10132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10133
10134         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10135         (mn10300_unwind_pc): Delete.
10136         (mn10300_unwind_sp): Delete.
10137         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10138         mn10300_unwind_sp.
10139         (mn10300_frame_unwind_init): Don't register deleted functions with
10140         gdbarch.
10141
10142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10143
10144         * mep-tdep.c (mep_unwind_pc): Delete.
10145         (mep_unwind_sp): Delete.
10146         (mep_dummy_id): Delete.
10147         (mep_gdbarch_init): Don't register deleted functions with
10148         gdbarch.
10149
10150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10151
10152         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10153         (m68hc11_unwind_sp): Delete.
10154         (m68hc11_gdbarch_init): Don't register deleted functions with
10155         gdbarch.
10156
10157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10158
10159         * m32r-tdep.c (m32r_unwind_sp): Delete.
10160         (m32r_unwind_pc): Delete.
10161         (m32r_dummy_id): Delete.
10162         (m32r_gdbarch_init): Don't register deleted functions with
10163         gdbarch.
10164
10165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10166
10167         * m32c-tdep.c (m32c_unwind_pc): Delete.
10168         (m32c_unwind_sp): Delete.
10169         (m32c_dummy_id): Delete.
10170         (m32c_gdbarch_init): Don't register deleted functions with
10171         gdbarch.
10172
10173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10174
10175         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10176         (lm32_unwind_pc): Delete.
10177         (lm32_dummy_id): Delete.
10178         (lm32_gdbarch_init): Don't register deleted functions with
10179         gdbarch.
10180
10181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10182
10183         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10184         (iq2000_unwind_pc): Delete.
10185         (iq2000_dummy_id): Delete.
10186         (iq2000_gdbarch_init): Don't register deleted functions with
10187         gdbarch.
10188
10189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10190
10191         * nds32-tdep.c (nds32_type_align): Delete.
10192         (nds32_push_dummy_call): Use type_align instead.
10193
10194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10195
10196         * arm-tdep.c (arm_type_align): Only handle vector override case.
10197         (arm_push_dummy_call): Use type_align.
10198         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10199
10200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10201
10202         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10203         case.
10204         (pass_on_stack): Use type_align.
10205         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10206         function.
10207
10208 2019-04-23  Tom Tromey  <tromey@adacore.com>
10209
10210         * dwarf2read.c (line_header::file_name_at): Remove unused
10211         overload.
10212
10213 2019-04-23  Tom de Vries  <tdevries@suse.de>
10214
10215         PR gdb/24438
10216         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10217         invocation.
10218
10219
10220 2019-03-27  Ali Tamur  <tamur@google.com>
10221
10222         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10223         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10224         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10225         (dwarf_expr_context::get_addr_index): Likewise
10226         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10227         (symbol_needs_eval_context::get_addr_index): Likewise
10228         (disassemble_dwarf_expression): Add DW_OP_addrx
10229         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10230         (read_cutu_die_from_dwo): Update comment
10231         (skip_one_die): Add DW_FORM_addrx
10232         (read_attribute_value): Likewise
10233         (var_decode_location): Add DW_OP_addrx
10234         (dwarf2_const_value_attr): Add DW_FORM_addrx
10235         (dump_die_shallow): Likewise
10236         (dwarf2_fetch_constant_bytes): Likewise
10237         (decode_locdesc): Add DW_OP_addrx
10238         (skip_form_bytes): Add DW_FORM_addrx
10239
10240 2019-04-22  Ali Tamur  <tamur@google.com>
10241
10242         * MAINTAINERS (Write After Approval): Add self.
10243
10244 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10245
10246         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10247         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10248         (open_symbol_file_object): Likewise.
10249         (svr4_default_sos): Add info parameter.
10250         (svr4_read_so_list): Likewise.
10251         (svr4_current_sos_direct): Adjust functions calls to pass down
10252         info.
10253         (svr4_current_sos_1): Add info parameter.
10254         (svr4_current_sos): Call get_svr4_info, pass info down to
10255         svr4_current_sos_1.
10256         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10257         get_svr4_info.
10258         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10259         get_svr4_info.
10260         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10261         to get_svr4_info.
10262         (probes_table_remove_objfile_probes): Likewise.
10263         (register_solib_event_probe): Add info parameter.
10264         (solist_update_incremental): Pass info parameter down to
10265         svr4_read_so_list.
10266         (disable_probes_interface): Add info parameter.
10267         (svr4_handle_solib_event): Pass current_program_space to
10268         get_svr4_info.  Adjust disable_probes_interface cleanup.
10269         (svr4_create_probe_breakpoints): Add info parameter, pass it
10270         down to register_solib_event_probe.
10271         (svr4_create_solib_event_breakpoints): Add info parameter,
10272         pass it down to svr4_create_probe_breakpoints.
10273         (enable_break): Pass info down to
10274         svr4_create_solib_event_breakpoints.
10275         (svr4_solib_create_inferior_hook): Pass current_program_space to
10276         get_svr4_info.
10277         (svr4_clear_solib): Likewise.
10278
10279 2019-04-22  Pedro Alves  <palves@redhat.com>
10280
10281         * solib-svr4.c (svr4_free_objfile_observer): New.
10282         (probe_and_action::objfile): New field.
10283         (probes_table_htab_remove_objfile_probes)
10284         (probes_table_remove_objfile_probes): New functions.
10285         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10286         in the new probe_and_action.  Don't store the probe in 'lookup'.
10287         (svr4_create_probe_breakpoints): Pass objfile to
10288         register_solib_event_probe.
10289         (_initialize_svr4_solib): Register a free_objfile observer.
10290
10291 2019-04-19  Tom Tromey  <tom@tromey.com>
10292
10293         * common/queue.h: Remove.
10294
10295 2019-04-19  Tom Tromey  <tom@tromey.com>
10296
10297         * event-loop.c: Don't include "common/queue.h".
10298
10299 2019-04-19  Tom Tromey  <tom@tromey.com>
10300
10301         * remote.c (remote_target): Use delete.
10302         * remote-notif.h: Include <list>, not "common/queue.h".
10303         (notif_client_p): Remove typedef.
10304         (remote_notif_state): Add constructor, destructor, initializer.
10305         <notif_queue>: Now a std::list.
10306         (remote_notif_state_xfree): Don't declare.
10307         * remote-notif.c (remote_notif_process, handle_notification)
10308         (remote_notif_state_allocate): Update.
10309         (~remote_notif_state): Rename from remote_notif_state_xfree.
10310
10311 2019-04-19  Tom Tromey  <tom@tromey.com>
10312
10313         * symfile.c (reread_symbols): Update.
10314         * objfiles.c (objfile_register_static_link)
10315         (objfile_lookup_static_link): Update
10316         (~objfile) Don't delete static_links.
10317         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10318
10319 2019-04-19  Tom Tromey  <tom@tromey.com>
10320
10321         * type-stack.h (struct type_stack) <insert>: Constify string.
10322         * type-stack.c (type_stack::insert): Constify string.
10323         * gdbtypes.h (lookup_template_type): Update.
10324         (address_space_name_to_int): Update.
10325         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10326         const.
10327         (lookup_template_type): Make name const.
10328         * c-exp.y: Update rules.
10329         (lex_one_token, classify_name, classify_inner_name)
10330         (c_print_token): Update.
10331         * p-exp.y: Update rules.
10332         (yylex): Update.
10333         * f-exp.y: Update rules.
10334         (yylex): Update.
10335         * d-exp.y: Update rules.
10336         (lex_one_token, classify_name, classify_inner_name): Update.
10337         * parse.c (write_dollar_variable, copy_name): Return std::string.
10338         * parser-defs.h (copy_name): Change return type.
10339         * m2-exp.y: Update rules.
10340         (yylex): Update.
10341         * go-exp.y (lex_one_token): Update.
10342         Update rules.
10343         (classify_unsafe_function, classify_packaged_name)
10344         (classify_name, yylex): Update.
10345
10346 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10347
10348         * configure.ac: add --enable-source-highlight switch.
10349         * configure: Regenerate.
10350         * top.c (print_gdb_version): plumb --enable-source-highlight
10351         status to "show configuration".
10352
10353 2019-04-19  Tom Tromey  <tromey@adacore.com>
10354
10355         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10356         Check ADA_TYPE_P.
10357         (empty_record, ada_template_to_fixed_record_type_1)
10358         (template_to_static_fixed_type)
10359         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10360         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10361         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10362         macros.
10363
10364 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10365
10366         PR symtab/24423:
10367         * source.c (print_source_lines_base): Advance "iter" when a
10368         control character is seen.
10369
10370 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10371
10372         * inferior.h (struct infcall_suspend_state_deleter):
10373         Catch exception in destructor to avoid crash.
10374
10375 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10376
10377         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10378         close to the add_com "shell".
10379
10380 2019-04-18  Tom Tromey  <tromey@adacore.com>
10381
10382         * process-stratum-target.h (class process_stratum_target)
10383         <stratum>: Add "final".
10384
10385 2019-04-17  Tom Tromey  <tromey@adacore.com>
10386
10387         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10388         against nullptr before use.
10389
10390 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10391
10392         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10393
10394 2019-04-17  Jim Wilson  <jimw@sifive.com>
10395             Andrew Burgess  <andrew.burgess@embecosm.com>
10396
10397         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10398         code read might fail, assume 4-byte breakpoint in that case.
10399
10400 2019-04-15  Leszek Swirski  <leszeks@google.com>
10401
10402         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10403         rather than a hand-rolled POD check when checking for forced MEMORY
10404         classification.
10405
10406 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10407
10408         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10409         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10410         function.
10411         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10412         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10413         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10414         declaration.
10415
10416 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10417
10418         * aarch64-linux-nat.c
10419         (aarch64_linux_nat_target::thread_architecture): Add override.
10420         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10421         each VQ.
10422
10423 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10424
10425         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10426
10427 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10428
10429         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10430         target types of size 96-bits, add some additional comments, and
10431         check that the builtin type we found was the correct size.
10432
10433 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10434
10435         * utils.c (prompt_for_continue): Don't restore the styling at the
10436         end, as applied_style has the wrong value.  This fixes styling in
10437         long lists of file names that are interrupted by the "Continue?"
10438         prompt.
10439
10440 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10441
10442         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10443         * c-lang.c (c_language_defn): Likewise.
10444         (cplus_language_defn): Likewise.
10445         (asm_language_defn): Likewise.
10446         (minimal_language_defn): Likewise.
10447         * d-lang.c (d_language_defn): Likewise.
10448         * f-lang.c (f_language_defn): Likewise.
10449         * go-lang.c (go_language_defn): Likewise.
10450         * language.c (unknown_language_defn): Likewise.
10451         (auto_language_defn): Likewise.
10452         * language.h (struct language_defn): Remove la_magic field.
10453         (LANG_MAGIC): Delete.
10454         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10455         * objc-lang.c (objc_language_defn): Likewise.
10456         * opencl-lang.c (opencl_language_defn): Likewise.
10457         * p-lang.c (pascal_language_defn): Likewise.
10458         * rust-lang.c (rust_language_defn): Likewise.
10459
10460 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10461
10462         * riscv-tdep.c (riscv_type_align): New function.
10463         (riscv_type_alignment): Delete.
10464         (riscv_arg_location): Use 'type_align'.
10465         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10466
10467 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10468
10469         * gdbtypes.c (type_align): A struct with no non-static fields also
10470         has alignment of 1.
10471
10472 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10473
10474         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10475         component to 0.
10476         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10477         member.
10478         (riscv_struct_info::analyse): New implementation using new
10479         analyse_inner member function.
10480         (riscv_struct_info::field_offset): New member function.
10481         (riscv_struct_info::m_offsets): New member variable.
10482         (riscv_struct_info::analyse_inner): New private member function,
10483         takes the old implementation of riscv_struct_info::analyse but
10484         extended to track field offsets.
10485         (riscv_call_arg_struct): Update the struct folding special cases
10486         to handle cases where empty C++ structs, which are non-zero
10487         length, are found.
10488         (riscv_arg_location): Initialise the length of each location, a
10489         non-zero length now indicates the location is in use.
10490         (riscv_push_dummy_call): Allow for the first location having a
10491         non-zero offset when setting up arguments.
10492         (riscv_return_value): Likewise, but for return values.
10493
10494 2019-04-11  Tom Tromey  <tromey@adacore.com>
10495
10496         * utils.c (internal_vproblem): Make "msg" const.
10497
10498 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10499
10500         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10501         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10502         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10503         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10504
10505 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10506
10507         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10508         function.
10509         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10510         of amd64_collect_native_gregset.
10511         (amd64_linux_nat_target::store_registers): Likewise.
10512
10513 2019-04-10  Tom Tromey  <tom@tromey.com>
10514
10515         * symtab.c (lookup_global_symbol_from_objfile)
10516         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10517         * objfiles.h (class separate_debug_iterator): New.
10518         (class separate_debug_range): New.
10519         (struct objfile) <separate_debug_objfiles>: New method.
10520         (objfile_separate_debug_iterate): Don't declare.
10521         * objfiles.c (separate_debug_iterator::operator++): Rename from
10522         objfile_separate_debug_iterate.
10523         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10524         iterator.
10525         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10526         iterator.
10527
10528 2019-04-10  Tom Tromey  <tom@tromey.com>
10529
10530         * symfile.c (reread_symbols): Remove old comment.
10531         * objfiles.c (free_all_objfiles): Fix a typo.
10532
10533 2019-04-10  Tom Tromey  <tom@tromey.com>
10534
10535         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10536         * minsyms.c (lookup_minimal_symbol): Use foreach.
10537         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10538         (lookup_minimal_symbol_solib_trampoline): Likewise.
10539         * symfile.c (reread_symbols): Use foreach.
10540
10541 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10542             Tom Tromey  <tromey@adacore.com>
10543
10544         PR rust/24414:
10545         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10546         (rust_lex_int_test): Change "value" to be LONGEST.
10547         (rust_lex_tests): Add test for long integer literal.
10548
10549 2019-04-09  Tom Tromey  <tromey@adacore.com>
10550
10551         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10552         to bool.
10553         (extended_remote_target::attach): Update.
10554         (remote_target::remote_notice_new_inferior): Update.
10555         (remote_target::add_current_inferior_and_thread): Update.
10556         * inferior.c (exit_inferior_1): Use "false".
10557         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10558
10559 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
10560
10561         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10562         the "start" command.
10563
10564 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10565
10566         * python/py-inferior.c (infpy_thread_from_thread_handle):
10567         Adjust comments to reflect renaming of thread_from_thread_handle
10568         to thread_from_handle.  Adjust keywords.  Fix type error message.
10569         (inferior_object_methods): Add thread_from_handle.  Retain
10570         thread_from_thread_handle, but mark it as deprecated.
10571
10572 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10573
10574         * gdbthread.h (find_thread_by_handle): Revise declaration.
10575         * thread.c (find_thread_by_handle): Likewise.  Adjust
10576         implementation too.
10577         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10578         support for buffer objects as handles.
10579
10580 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10581
10582         * python/py-infthread.c (thpy_thread_handle): New function.
10583         (thread_object_methods): Register thpy_thread_handle.
10584
10585 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10586
10587         * gdbthread.h (thread_to_thread_handle): Declare.
10588         * thread.c (gdbtypes.h): Include.
10589         (thread_to_thread_handle): New function.
10590
10591         * target.h (struct target_ops): Add thread_info_to_thread_handle.
10592         (target_thread_info_to_thread_handle): Declare.
10593         * target.c (target_thread_info_to_thread_handle): New function.
10594         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10595         * target-delegates.c: Regenerate.
10596
10597         * linux-thread-db.c (class thread_db_target): Add method
10598         thread_info_to_thread_handle.
10599         (thread_db_target::thread_info_to_thread_handle): Define.
10600         * remote.c (class remote_target): Add new method
10601         thread_info_to_thread_handle.
10602         (remote_target::thread_info_to_thread_handle): Define.
10603
10604 2019-04-08  Pedro Alves  <palves@redhat.com>
10605
10606         * common/common-exceptions.c (throw_exception): Don't create
10607         named object to throw; throw directly.
10608         (throw_it): Likewise.  Don't initialize gdb_exception::message
10609         here, with new; pass FMT and AP to the ctor instead.
10610         * common/common-exceptions.h: Include <string>.
10611         (gdb_exception::gdb_exception(enum return_reason, enum errors,
10612         const char *, va_list)): New ctor.  Use std::make_shared.
10613         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10614         errors)): Delete.
10615         (gdb_exception_error::gdb_exception_error(enum errors, const char
10616         *, va_list)): New.
10617         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10618         Add assertion.
10619         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10620         errors)): Delete.
10621         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10622         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10623         Add assertion.
10624
10625 2019-04-08  Tom Tromey  <tom@tromey.com>
10626
10627         * valops.c (value_rtti_indirect_type): Replace throw_exception
10628         with throw.
10629         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10630         with throw.
10631         * thread.c (thr_try_catch_cmd): Replace throw_exception with
10632         throw.
10633         * target.c (target_translate_tls_address): Replace throw_exception
10634         with throw.
10635         * stack.c (frame_apply_command_count): Replace throw_exception
10636         with throw.
10637         * solib-spu.c (append_ocl_sos): Replace throw_exception with
10638         throw.
10639         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10640         with throw.
10641         * rs6000-tdep.c (rs6000_frame_cache)
10642         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10643         * remote.c: Replace throw_exception with throw.
10644         * record-full.c (record_full_message, record_full_wait_1)
10645         (record_full_restore): Replace throw_exception with throw.
10646         * record-btrace.c:
10647         (get_thread_current_frame_id, record_btrace_start_replaying)
10648         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10649         (cmd_record_btrace_start): Replace throw_exception with throw.
10650         * parse.c (parse_exp_in_context_1): Replace throw_exception with
10651         throw.
10652         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10653         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10654         * linespec.c:
10655         (find_linespec_symbols): Replace throw_exception with throw.
10656         * infrun.c (displaced_step_prepare, resume): Replace
10657         throw_exception with throw.
10658         * infcmd.c (post_create_inferior): Replace throw_exception with
10659         throw.
10660         * inf-loop.c (inferior_event_handler): Replace throw_exception
10661         with throw.
10662         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10663         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10664         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10665         (get_prev_frame_always, get_frame_pc_if_available)
10666         (get_frame_address_in_block_if_available, get_frame_language):
10667         Replace throw_exception with throw.
10668         * frame-unwind.c (frame_unwind_try_unwinder): Replace
10669         throw_exception with throw.
10670         * eval.c (fetch_subexp_value, evaluate_var_value)
10671         (evaluate_funcall, evaluate_subexp_standard): Replace
10672         throw_exception with throw.
10673         * dwarf2loc.c (call_site_find_chain)
10674         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10675         Replace throw_exception with throw.
10676         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10677         with throw.
10678         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10679         throw.
10680         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10681         * completer.c (complete_line_internal): Replace throw_exception
10682         with throw.
10683         * compile/compile-object-run.c (compile_object_run): Replace
10684         throw_exception with throw.
10685         * cli/cli-script.c (process_next_line): Replace throw_exception
10686         with throw.
10687         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10688         (btrace_enable, btrace_maint_update_pt_packets): Replace
10689         throw_exception with throw.
10690         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10691         throw_exception with throw.
10692         * break-catch-throw.c (re_set_exception_catchpoint): Replace
10693         throw_exception with throw.
10694         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10695         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10696         * aarch64-tdep.c (aarch64_make_prologue_cache)
10697         (aarch64_make_stub_cache): Replace throw_exception with throw.
10698
10699 2019-04-08  Tom Tromey  <tom@tromey.com>
10700
10701         * common/common-exceptions.c (throw_exception): Rename from
10702         throw_exception_cxx.  Remove old copy.  Make argument const.
10703         (throw_it): Create and throw exception objects directly.
10704         * common/common-exceptions.h (throw_exception): Make argument
10705         const.
10706         (struct gdb_exception_error): Add constructor.
10707         (struct gdb_exception_quit): Add constructor.
10708
10709 2019-04-08  Tom Tromey  <tom@tromey.com>
10710
10711         * common/common-exceptions.h (exception_rethrow): Don't declare.
10712         (TRY_SJLJ): Update comment.
10713         (TRY, CATCH, END_CATCH): Remove.
10714         * common/common-exceptions.c (exception_rethrow): Remove.
10715
10716 2019-04-08  Tom Tromey  <tom@tromey.com>
10717
10718         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10719         Remove.
10720         (gdb_exception_error): Rename from
10721         gdb_exception_RETURN_MASK_ERROR.
10722         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10723         (gdb_quit_bad_alloc): Update.
10724         * aarch64-tdep.c: Update.
10725         * ada-lang.c: Update.
10726         * ada-typeprint.c: Update.
10727         * ada-valprint.c: Update.
10728         * amd64-tdep.c: Update.
10729         * arch-utils.c: Update.
10730         * break-catch-throw.c: Update.
10731         * breakpoint.c: Update.
10732         * btrace.c: Update.
10733         * c-varobj.c: Update.
10734         * cli/cli-cmds.c: Update.
10735         * cli/cli-interp.c: Update.
10736         * cli/cli-script.c: Update.
10737         * common/common-exceptions.c: Update.
10738         * common/new-op.c: Update.
10739         * common/selftest.c: Update.
10740         * compile/compile-c-symbols.c: Update.
10741         * compile/compile-cplus-symbols.c: Update.
10742         * compile/compile-object-load.c: Update.
10743         * compile/compile-object-run.c: Update.
10744         * completer.c: Update.
10745         * corelow.c: Update.
10746         * cp-abi.c: Update.
10747         * cp-support.c: Update.
10748         * cp-valprint.c: Update.
10749         * darwin-nat.c: Update.
10750         * disasm-selftests.c: Update.
10751         * dtrace-probe.c: Update.
10752         * dwarf-index-cache.c: Update.
10753         * dwarf-index-write.c: Update.
10754         * dwarf2-frame-tailcall.c: Update.
10755         * dwarf2-frame.c: Update.
10756         * dwarf2loc.c: Update.
10757         * dwarf2read.c: Update.
10758         * eval.c: Update.
10759         * event-loop.c: Update.
10760         * event-top.c: Update.
10761         * exec.c: Update.
10762         * f-valprint.c: Update.
10763         * fbsd-tdep.c: Update.
10764         * frame-unwind.c: Update.
10765         * frame.c: Update.
10766         * gdbtypes.c: Update.
10767         * gnu-v3-abi.c: Update.
10768         * guile/guile-internal.h: Update.
10769         * guile/scm-block.c: Update.
10770         * guile/scm-breakpoint.c: Update.
10771         * guile/scm-cmd.c: Update.
10772         * guile/scm-disasm.c: Update.
10773         * guile/scm-frame.c: Update.
10774         * guile/scm-lazy-string.c: Update.
10775         * guile/scm-math.c: Update.
10776         * guile/scm-param.c: Update.
10777         * guile/scm-ports.c: Update.
10778         * guile/scm-pretty-print.c: Update.
10779         * guile/scm-symbol.c: Update.
10780         * guile/scm-symtab.c: Update.
10781         * guile/scm-type.c: Update.
10782         * guile/scm-value.c: Update.
10783         * i386-linux-tdep.c: Update.
10784         * i386-tdep.c: Update.
10785         * inf-loop.c: Update.
10786         * infcall.c: Update.
10787         * infcmd.c: Update.
10788         * infrun.c: Update.
10789         * jit.c: Update.
10790         * language.c: Update.
10791         * linespec.c: Update.
10792         * linux-fork.c: Update.
10793         * linux-nat.c: Update.
10794         * linux-tdep.c: Update.
10795         * linux-thread-db.c: Update.
10796         * main.c: Update.
10797         * mi/mi-cmd-break.c: Update.
10798         * mi/mi-cmd-stack.c: Update.
10799         * mi/mi-interp.c: Update.
10800         * mi/mi-main.c: Update.
10801         * objc-lang.c: Update.
10802         * p-valprint.c: Update.
10803         * parse.c: Update.
10804         * ppc-linux-tdep.c: Update.
10805         * printcmd.c: Update.
10806         * python/py-arch.c: Update.
10807         * python/py-breakpoint.c: Update.
10808         * python/py-cmd.c: Update.
10809         * python/py-finishbreakpoint.c: Update.
10810         * python/py-frame.c: Update.
10811         * python/py-framefilter.c: Update.
10812         * python/py-gdb-readline.c: Update.
10813         * python/py-inferior.c: Update.
10814         * python/py-infthread.c: Update.
10815         * python/py-lazy-string.c: Update.
10816         * python/py-linetable.c: Update.
10817         * python/py-objfile.c: Update.
10818         * python/py-param.c: Update.
10819         * python/py-prettyprint.c: Update.
10820         * python/py-progspace.c: Update.
10821         * python/py-record-btrace.c: Update.
10822         * python/py-record.c: Update.
10823         * python/py-symbol.c: Update.
10824         * python/py-type.c: Update.
10825         * python/py-unwind.c: Update.
10826         * python/py-utils.c: Update.
10827         * python/py-value.c: Update.
10828         * python/python.c: Update.
10829         * record-btrace.c: Update.
10830         * record-full.c: Update.
10831         * remote-fileio.c: Update.
10832         * remote.c: Update.
10833         * riscv-tdep.c: Update.
10834         * rs6000-aix-tdep.c: Update.
10835         * rs6000-tdep.c: Update.
10836         * rust-exp.y: Update.
10837         * rust-lang.c: Update.
10838         * s390-tdep.c: Update.
10839         * selftest-arch.c: Update.
10840         * solib-dsbt.c: Update.
10841         * solib-frv.c: Update.
10842         * solib-spu.c: Update.
10843         * solib-svr4.c: Update.
10844         * solib.c: Update.
10845         * sparc64-linux-tdep.c: Update.
10846         * stack.c: Update.
10847         * symfile-mem.c: Update.
10848         * symmisc.c: Update.
10849         * target.c: Update.
10850         * thread.c: Update.
10851         * top.c: Update.
10852         * tracefile-tfile.c: Update.
10853         * tui/tui.c: Update.
10854         * typeprint.c: Update.
10855         * unittests/cli-utils-selftests.c: Update.
10856         * unittests/parse-connection-spec-selftests.c: Update.
10857         * valops.c: Update.
10858         * valprint.c: Update.
10859         * value.c: Update.
10860         * varobj.c: Update.
10861         * windows-nat.c: Update.
10862         * x86-linux-nat.c: Update.
10863         * xml-support.c: Update.
10864
10865 2019-04-08  Tom Tromey  <tom@tromey.com>
10866
10867         * xml-support.c: Use C++ exception handling.
10868         * x86-linux-nat.c: Use C++ exception handling.
10869         * windows-nat.c: Use C++ exception handling.
10870         * varobj.c: Use C++ exception handling.
10871         * value.c: Use C++ exception handling.
10872         * valprint.c: Use C++ exception handling.
10873         * valops.c: Use C++ exception handling.
10874         * unittests/parse-connection-spec-selftests.c: Use C++ exception
10875         handling.
10876         * unittests/cli-utils-selftests.c: Use C++ exception handling.
10877         * typeprint.c: Use C++ exception handling.
10878         * tui/tui.c: Use C++ exception handling.
10879         * tracefile-tfile.c: Use C++ exception handling.
10880         * top.c: Use C++ exception handling.
10881         * thread.c: Use C++ exception handling.
10882         * target.c: Use C++ exception handling.
10883         * symmisc.c: Use C++ exception handling.
10884         * symfile-mem.c: Use C++ exception handling.
10885         * stack.c: Use C++ exception handling.
10886         * sparc64-linux-tdep.c: Use C++ exception handling.
10887         * solib.c: Use C++ exception handling.
10888         * solib-svr4.c: Use C++ exception handling.
10889         * solib-spu.c: Use C++ exception handling.
10890         * solib-frv.c: Use C++ exception handling.
10891         * solib-dsbt.c: Use C++ exception handling.
10892         * selftest-arch.c: Use C++ exception handling.
10893         * s390-tdep.c: Use C++ exception handling.
10894         * rust-lang.c: Use C++ exception handling.
10895         * rust-exp.y: Use C++ exception handling.
10896         * rs6000-tdep.c: Use C++ exception handling.
10897         * rs6000-aix-tdep.c: Use C++ exception handling.
10898         * riscv-tdep.c: Use C++ exception handling.
10899         * remote.c: Use C++ exception handling.
10900         * remote-fileio.c: Use C++ exception handling.
10901         * record-full.c: Use C++ exception handling.
10902         * record-btrace.c: Use C++ exception handling.
10903         * python/python.c: Use C++ exception handling.
10904         * python/py-value.c: Use C++ exception handling.
10905         * python/py-utils.c: Use C++ exception handling.
10906         * python/py-unwind.c: Use C++ exception handling.
10907         * python/py-type.c: Use C++ exception handling.
10908         * python/py-symbol.c: Use C++ exception handling.
10909         * python/py-record.c: Use C++ exception handling.
10910         * python/py-record-btrace.c: Use C++ exception handling.
10911         * python/py-progspace.c: Use C++ exception handling.
10912         * python/py-prettyprint.c: Use C++ exception handling.
10913         * python/py-param.c: Use C++ exception handling.
10914         * python/py-objfile.c: Use C++ exception handling.
10915         * python/py-linetable.c: Use C++ exception handling.
10916         * python/py-lazy-string.c: Use C++ exception handling.
10917         * python/py-infthread.c: Use C++ exception handling.
10918         * python/py-inferior.c: Use C++ exception handling.
10919         * python/py-gdb-readline.c: Use C++ exception handling.
10920         * python/py-framefilter.c: Use C++ exception handling.
10921         * python/py-frame.c: Use C++ exception handling.
10922         * python/py-finishbreakpoint.c: Use C++ exception handling.
10923         * python/py-cmd.c: Use C++ exception handling.
10924         * python/py-breakpoint.c: Use C++ exception handling.
10925         * python/py-arch.c: Use C++ exception handling.
10926         * printcmd.c: Use C++ exception handling.
10927         * ppc-linux-tdep.c: Use C++ exception handling.
10928         * parse.c: Use C++ exception handling.
10929         * p-valprint.c: Use C++ exception handling.
10930         * objc-lang.c: Use C++ exception handling.
10931         * mi/mi-main.c: Use C++ exception handling.
10932         * mi/mi-interp.c: Use C++ exception handling.
10933         * mi/mi-cmd-stack.c: Use C++ exception handling.
10934         * mi/mi-cmd-break.c: Use C++ exception handling.
10935         * main.c: Use C++ exception handling.
10936         * linux-thread-db.c: Use C++ exception handling.
10937         * linux-tdep.c: Use C++ exception handling.
10938         * linux-nat.c: Use C++ exception handling.
10939         * linux-fork.c: Use C++ exception handling.
10940         * linespec.c: Use C++ exception handling.
10941         * language.c: Use C++ exception handling.
10942         * jit.c: Use C++ exception handling.
10943         * infrun.c: Use C++ exception handling.
10944         * infcmd.c: Use C++ exception handling.
10945         * infcall.c: Use C++ exception handling.
10946         * inf-loop.c: Use C++ exception handling.
10947         * i386-tdep.c: Use C++ exception handling.
10948         * i386-linux-tdep.c: Use C++ exception handling.
10949         * guile/scm-value.c: Use C++ exception handling.
10950         * guile/scm-type.c: Use C++ exception handling.
10951         * guile/scm-symtab.c: Use C++ exception handling.
10952         * guile/scm-symbol.c: Use C++ exception handling.
10953         * guile/scm-pretty-print.c: Use C++ exception handling.
10954         * guile/scm-ports.c: Use C++ exception handling.
10955         * guile/scm-param.c: Use C++ exception handling.
10956         * guile/scm-math.c: Use C++ exception handling.
10957         * guile/scm-lazy-string.c: Use C++ exception handling.
10958         * guile/scm-frame.c: Use C++ exception handling.
10959         * guile/scm-disasm.c: Use C++ exception handling.
10960         * guile/scm-cmd.c: Use C++ exception handling.
10961         * guile/scm-breakpoint.c: Use C++ exception handling.
10962         * guile/scm-block.c: Use C++ exception handling.
10963         * guile/guile-internal.h: Use C++ exception handling.
10964         * gnu-v3-abi.c: Use C++ exception handling.
10965         * gdbtypes.c: Use C++ exception handling.
10966         * frame.c: Use C++ exception handling.
10967         * frame-unwind.c: Use C++ exception handling.
10968         * fbsd-tdep.c: Use C++ exception handling.
10969         * f-valprint.c: Use C++ exception handling.
10970         * exec.c: Use C++ exception handling.
10971         * event-top.c: Use C++ exception handling.
10972         * event-loop.c: Use C++ exception handling.
10973         * eval.c: Use C++ exception handling.
10974         * dwarf2read.c: Use C++ exception handling.
10975         * dwarf2loc.c: Use C++ exception handling.
10976         * dwarf2-frame.c: Use C++ exception handling.
10977         * dwarf2-frame-tailcall.c: Use C++ exception handling.
10978         * dwarf-index-write.c: Use C++ exception handling.
10979         * dwarf-index-cache.c: Use C++ exception handling.
10980         * dtrace-probe.c: Use C++ exception handling.
10981         * disasm-selftests.c: Use C++ exception handling.
10982         * darwin-nat.c: Use C++ exception handling.
10983         * cp-valprint.c: Use C++ exception handling.
10984         * cp-support.c: Use C++ exception handling.
10985         * cp-abi.c: Use C++ exception handling.
10986         * corelow.c: Use C++ exception handling.
10987         * completer.c: Use C++ exception handling.
10988         * compile/compile-object-run.c: Use C++ exception handling.
10989         * compile/compile-object-load.c: Use C++ exception handling.
10990         * compile/compile-cplus-symbols.c: Use C++ exception handling.
10991         * compile/compile-c-symbols.c: Use C++ exception handling.
10992         * common/selftest.c: Use C++ exception handling.
10993         * common/new-op.c: Use C++ exception handling.
10994         * cli/cli-script.c: Use C++ exception handling.
10995         * cli/cli-interp.c: Use C++ exception handling.
10996         * cli/cli-cmds.c: Use C++ exception handling.
10997         * c-varobj.c: Use C++ exception handling.
10998         * btrace.c: Use C++ exception handling.
10999         * breakpoint.c: Use C++ exception handling.
11000         * break-catch-throw.c: Use C++ exception handling.
11001         * arch-utils.c: Use C++ exception handling.
11002         * amd64-tdep.c: Use C++ exception handling.
11003         * ada-valprint.c: Use C++ exception handling.
11004         * ada-typeprint.c: Use C++ exception handling.
11005         * ada-lang.c: Use C++ exception handling.
11006         * aarch64-tdep.c: Use C++ exception handling.
11007
11008 2019-04-08  Tom Tromey  <tom@tromey.com>
11009
11010         * xml-support.c (gdb_xml_parser::parse): Update.
11011         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11012         * value.c (show_convenience): Update.
11013         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11014         (test_parse_flags_qcs): Update.
11015         * thread.c (thr_try_catch_cmd): Update.
11016         * target.c (target_translate_tls_address): Update.
11017         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11018         (info_frame_command_core, frame_apply_command_count): Update.
11019         * rust-exp.y (rust_lex_exception_test): Update.
11020         * riscv-tdep.c (riscv_print_one_register_info): Update.
11021         * remote.c (remote_target::enable_btrace): Update.
11022         * record-btrace.c (record_btrace_enable_warn): Update.
11023         * python/py-utils.c (gdbpy_convert_exception): Update.
11024         * printcmd.c (do_one_display, print_variable_and_value): Update.
11025         * mi/mi-main.c (mi_print_exception): Update.
11026         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11027         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11028         * linux-nat.c (linux_nat_target::attach): Update.
11029         * linux-fork.c (class scoped_switch_fork_info): Update.
11030         * infrun.c (displaced_step_prepare): Update.
11031         * infcall.c (call_function_by_hand_dummy): Update.
11032         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11033         * gnu-v3-abi.c (print_one_vtable): Update.
11034         * frame.c (get_prev_frame_always): Update.
11035         * f-valprint.c (info_common_command_for_block): Update.
11036         * exec.c (try_open_exec_file): Update.
11037         * exceptions.c (print_exception, exception_print)
11038         (exception_fprintf, exception_print_same): Update.
11039         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11040         * dwarf-index-cache.c (index_cache::store)
11041         (index_cache::lookup_gdb_index): Update.
11042         * darwin-nat.c (maybe_cache_shell): Update.
11043         * cp-valprint.c (cp_print_value_fields): Update.
11044         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11045         (gcc_cplus_symbol_address): Update.
11046         * compile/compile-c-symbols.c (gcc_convert_symbol)
11047         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11048         * common/selftest.c: Update.
11049         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11050         a std::string.
11051         (exception_try_scope_entry, exception_try_scope_exit): Don't
11052         declare.
11053         (struct exception_try_scope): Remove.
11054         (TRY): Don't use exception_try_scope.
11055         (struct gdb_exception): Add constructor, operator=.
11056         <what>: New method.
11057         (struct gdb_exception_RETURN_MASK_ALL)
11058         (struct gdb_exception_RETURN_MASK_ERROR)
11059         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11060         (struct gdb_quit_bad_alloc): Update.
11061         * common/common-exceptions.c (exception_none): Change
11062         initializer.
11063         (struct catcher) <state, exception>: Initialize inline.
11064         <prev>: Remove member.
11065         (current_catcher): Remove.
11066         (catchers): New global.
11067         (exceptions_state_mc_init): Simplify.
11068         (catcher_pop): Remove.
11069         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11070         (try_scope_depth, exception_try_scope_entry)
11071         (exception_try_scope_exit): Remove.
11072         (throw_exception_sjlj): Update.
11073         (exception_messages, exception_messages_size): Remove.
11074         (throw_it): Simplify.
11075         (gdb_exception_sliced_copy): Remove.
11076         (throw_exception_cxx): Update.
11077         * cli/cli-script.c (script_from_file): Update.
11078         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11079         Update.
11080         * ada-valprint.c (ada_val_print): Update.
11081         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11082         (create_excep_cond_exprs): Update.
11083
11084 2019-04-08  Tom Tromey  <tom@tromey.com>
11085
11086         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11087         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11088         (TRY, CATCH, END_CATCH): Remove some definitions.
11089         * common/common-exceptions.c: Don't use GDB_XCPT.
11090         (catcher_list_size): Remove.
11091         (throw_exception, throw_it): Simplify.
11092
11093 2019-04-05  Tom Tromey  <tom@tromey.com>
11094
11095         Revert the header-sorting patch.
11096         * ft32-tdep.c: Revert.
11097         * frv-tdep.c: Revert.
11098         * frv-linux-tdep.c: Revert.
11099         * frame.c: Revert.
11100         * frame-unwind.c: Revert.
11101         * frame-base.c: Revert.
11102         * fork-child.c: Revert.
11103         * findvar.c: Revert.
11104         * findcmd.c: Revert.
11105         * filesystem.c: Revert.
11106         * filename-seen-cache.h: Revert.
11107         * filename-seen-cache.c: Revert.
11108         * fbsd-tdep.c: Revert.
11109         * fbsd-nat.h: Revert.
11110         * fbsd-nat.c: Revert.
11111         * f-valprint.c: Revert.
11112         * f-typeprint.c: Revert.
11113         * f-lang.c: Revert.
11114         * extension.h: Revert.
11115         * extension.c: Revert.
11116         * extension-priv.h: Revert.
11117         * expprint.c: Revert.
11118         * exec.h: Revert.
11119         * exec.c: Revert.
11120         * exceptions.c: Revert.
11121         * event-top.c: Revert.
11122         * event-loop.c: Revert.
11123         * eval.c: Revert.
11124         * elfread.c: Revert.
11125         * dwarf2read.h: Revert.
11126         * dwarf2read.c: Revert.
11127         * dwarf2loc.c: Revert.
11128         * dwarf2expr.h: Revert.
11129         * dwarf2expr.c: Revert.
11130         * dwarf2-frame.c: Revert.
11131         * dwarf2-frame-tailcall.c: Revert.
11132         * dwarf-index-write.h: Revert.
11133         * dwarf-index-write.c: Revert.
11134         * dwarf-index-common.c: Revert.
11135         * dwarf-index-cache.h: Revert.
11136         * dwarf-index-cache.c: Revert.
11137         * dummy-frame.c: Revert.
11138         * dtrace-probe.c: Revert.
11139         * disasm.h: Revert.
11140         * disasm.c: Revert.
11141         * disasm-selftests.c: Revert.
11142         * dictionary.c: Revert.
11143         * dicos-tdep.c: Revert.
11144         * demangle.c: Revert.
11145         * dcache.h: Revert.
11146         * dcache.c: Revert.
11147         * darwin-nat.h: Revert.
11148         * darwin-nat.c: Revert.
11149         * darwin-nat-info.c: Revert.
11150         * d-valprint.c: Revert.
11151         * d-namespace.c: Revert.
11152         * d-lang.c: Revert.
11153         * ctf.c: Revert.
11154         * csky-tdep.c: Revert.
11155         * csky-linux-tdep.c: Revert.
11156         * cris-tdep.c: Revert.
11157         * cris-linux-tdep.c: Revert.
11158         * cp-valprint.c: Revert.
11159         * cp-support.c: Revert.
11160         * cp-namespace.c: Revert.
11161         * cp-abi.c: Revert.
11162         * corelow.c: Revert.
11163         * corefile.c: Revert.
11164         * continuations.c: Revert.
11165         * completer.h: Revert.
11166         * completer.c: Revert.
11167         * complaints.c: Revert.
11168         * coffread.c: Revert.
11169         * coff-pe-read.c: Revert.
11170         * cli-out.h: Revert.
11171         * cli-out.c: Revert.
11172         * charset.c: Revert.
11173         * c-varobj.c: Revert.
11174         * c-valprint.c: Revert.
11175         * c-typeprint.c: Revert.
11176         * c-lang.c: Revert.
11177         * buildsym.c: Revert.
11178         * buildsym-legacy.c: Revert.
11179         * build-id.h: Revert.
11180         * build-id.c: Revert.
11181         * btrace.c: Revert.
11182         * bsd-uthread.c: Revert.
11183         * breakpoint.h: Revert.
11184         * breakpoint.c: Revert.
11185         * break-catch-throw.c: Revert.
11186         * break-catch-syscall.c: Revert.
11187         * break-catch-sig.c: Revert.
11188         * blockframe.c: Revert.
11189         * block.c: Revert.
11190         * bfin-tdep.c: Revert.
11191         * bfin-linux-tdep.c: Revert.
11192         * bfd-target.c: Revert.
11193         * bcache.c: Revert.
11194         * ax-general.c: Revert.
11195         * ax-gdb.h: Revert.
11196         * ax-gdb.c: Revert.
11197         * avr-tdep.c: Revert.
11198         * auxv.c: Revert.
11199         * auto-load.c: Revert.
11200         * arm-wince-tdep.c: Revert.
11201         * arm-tdep.c: Revert.
11202         * arm-symbian-tdep.c: Revert.
11203         * arm-pikeos-tdep.c: Revert.
11204         * arm-obsd-tdep.c: Revert.
11205         * arm-nbsd-tdep.c: Revert.
11206         * arm-nbsd-nat.c: Revert.
11207         * arm-linux-tdep.c: Revert.
11208         * arm-linux-nat.c: Revert.
11209         * arm-fbsd-tdep.c: Revert.
11210         * arm-fbsd-nat.c: Revert.
11211         * arm-bsd-tdep.c: Revert.
11212         * arch-utils.c: Revert.
11213         * arc-tdep.c: Revert.
11214         * arc-newlib-tdep.c: Revert.
11215         * annotate.h: Revert.
11216         * annotate.c: Revert.
11217         * amd64-windows-tdep.c: Revert.
11218         * amd64-windows-nat.c: Revert.
11219         * amd64-tdep.c: Revert.
11220         * amd64-sol2-tdep.c: Revert.
11221         * amd64-obsd-tdep.c: Revert.
11222         * amd64-obsd-nat.c: Revert.
11223         * amd64-nbsd-tdep.c: Revert.
11224         * amd64-nbsd-nat.c: Revert.
11225         * amd64-nat.c: Revert.
11226         * amd64-linux-tdep.c: Revert.
11227         * amd64-linux-nat.c: Revert.
11228         * amd64-fbsd-tdep.c: Revert.
11229         * amd64-fbsd-nat.c: Revert.
11230         * amd64-dicos-tdep.c: Revert.
11231         * amd64-darwin-tdep.c: Revert.
11232         * amd64-bsd-nat.c: Revert.
11233         * alpha-tdep.c: Revert.
11234         * alpha-obsd-tdep.c: Revert.
11235         * alpha-nbsd-tdep.c: Revert.
11236         * alpha-mdebug-tdep.c: Revert.
11237         * alpha-linux-tdep.c: Revert.
11238         * alpha-linux-nat.c: Revert.
11239         * alpha-bsd-tdep.c: Revert.
11240         * alpha-bsd-nat.c: Revert.
11241         * aix-thread.c: Revert.
11242         * agent.c: Revert.
11243         * addrmap.c: Revert.
11244         * ada-varobj.c: Revert.
11245         * ada-valprint.c: Revert.
11246         * ada-typeprint.c: Revert.
11247         * ada-tasks.c: Revert.
11248         * ada-lang.c: Revert.
11249         * aarch64-tdep.c: Revert.
11250         * aarch64-ravenscar-thread.c: Revert.
11251         * aarch64-newlib-tdep.c: Revert.
11252         * aarch64-linux-tdep.c: Revert.
11253         * aarch64-linux-nat.c: Revert.
11254         * aarch64-fbsd-tdep.c: Revert.
11255         * aarch64-fbsd-nat.c: Revert.
11256         * aarch32-linux-nat.c: Revert.
11257
11258 2019-04-05  Tom Tromey  <tom@tromey.com>
11259
11260         * ft32-tdep.c: Sort headers.
11261         * frv-tdep.c: Sort headers.
11262         * frv-linux-tdep.c: Sort headers.
11263         * frame.c: Sort headers.
11264         * frame-unwind.c: Sort headers.
11265         * frame-base.c: Sort headers.
11266         * fork-child.c: Sort headers.
11267         * findvar.c: Sort headers.
11268         * findcmd.c: Sort headers.
11269         * filesystem.c: Sort headers.
11270         * filename-seen-cache.h: Sort headers.
11271         * filename-seen-cache.c: Sort headers.
11272         * fbsd-tdep.c: Sort headers.
11273         * fbsd-nat.h: Sort headers.
11274         * fbsd-nat.c: Sort headers.
11275         * f-valprint.c: Sort headers.
11276         * f-typeprint.c: Sort headers.
11277         * f-lang.c: Sort headers.
11278         * extension.h: Sort headers.
11279         * extension.c: Sort headers.
11280         * extension-priv.h: Sort headers.
11281         * expprint.c: Sort headers.
11282         * exec.h: Sort headers.
11283         * exec.c: Sort headers.
11284         * exceptions.c: Sort headers.
11285         * event-top.c: Sort headers.
11286         * event-loop.c: Sort headers.
11287         * eval.c: Sort headers.
11288         * elfread.c: Sort headers.
11289         * dwarf2read.h: Sort headers.
11290         * dwarf2read.c: Sort headers.
11291         * dwarf2loc.c: Sort headers.
11292         * dwarf2expr.h: Sort headers.
11293         * dwarf2expr.c: Sort headers.
11294         * dwarf2-frame.c: Sort headers.
11295         * dwarf2-frame-tailcall.c: Sort headers.
11296         * dwarf-index-write.h: Sort headers.
11297         * dwarf-index-write.c: Sort headers.
11298         * dwarf-index-common.c: Sort headers.
11299         * dwarf-index-cache.h: Sort headers.
11300         * dwarf-index-cache.c: Sort headers.
11301         * dummy-frame.c: Sort headers.
11302         * dtrace-probe.c: Sort headers.
11303         * disasm.h: Sort headers.
11304         * disasm.c: Sort headers.
11305         * disasm-selftests.c: Sort headers.
11306         * dictionary.c: Sort headers.
11307         * dicos-tdep.c: Sort headers.
11308         * demangle.c: Sort headers.
11309         * dcache.h: Sort headers.
11310         * dcache.c: Sort headers.
11311         * darwin-nat.h: Sort headers.
11312         * darwin-nat.c: Sort headers.
11313         * darwin-nat-info.c: Sort headers.
11314         * d-valprint.c: Sort headers.
11315         * d-namespace.c: Sort headers.
11316         * d-lang.c: Sort headers.
11317         * ctf.c: Sort headers.
11318         * csky-tdep.c: Sort headers.
11319         * csky-linux-tdep.c: Sort headers.
11320         * cris-tdep.c: Sort headers.
11321         * cris-linux-tdep.c: Sort headers.
11322         * cp-valprint.c: Sort headers.
11323         * cp-support.c: Sort headers.
11324         * cp-namespace.c: Sort headers.
11325         * cp-abi.c: Sort headers.
11326         * corelow.c: Sort headers.
11327         * corefile.c: Sort headers.
11328         * continuations.c: Sort headers.
11329         * completer.h: Sort headers.
11330         * completer.c: Sort headers.
11331         * complaints.c: Sort headers.
11332         * coffread.c: Sort headers.
11333         * coff-pe-read.c: Sort headers.
11334         * cli-out.h: Sort headers.
11335         * cli-out.c: Sort headers.
11336         * charset.c: Sort headers.
11337         * c-varobj.c: Sort headers.
11338         * c-valprint.c: Sort headers.
11339         * c-typeprint.c: Sort headers.
11340         * c-lang.c: Sort headers.
11341         * buildsym.c: Sort headers.
11342         * buildsym-legacy.c: Sort headers.
11343         * build-id.h: Sort headers.
11344         * build-id.c: Sort headers.
11345         * btrace.c: Sort headers.
11346         * bsd-uthread.c: Sort headers.
11347         * breakpoint.h: Sort headers.
11348         * breakpoint.c: Sort headers.
11349         * break-catch-throw.c: Sort headers.
11350         * break-catch-syscall.c: Sort headers.
11351         * break-catch-sig.c: Sort headers.
11352         * blockframe.c: Sort headers.
11353         * block.c: Sort headers.
11354         * bfin-tdep.c: Sort headers.
11355         * bfin-linux-tdep.c: Sort headers.
11356         * bfd-target.c: Sort headers.
11357         * bcache.c: Sort headers.
11358         * ax-general.c: Sort headers.
11359         * ax-gdb.h: Sort headers.
11360         * ax-gdb.c: Sort headers.
11361         * avr-tdep.c: Sort headers.
11362         * auxv.c: Sort headers.
11363         * auto-load.c: Sort headers.
11364         * arm-wince-tdep.c: Sort headers.
11365         * arm-tdep.c: Sort headers.
11366         * arm-symbian-tdep.c: Sort headers.
11367         * arm-pikeos-tdep.c: Sort headers.
11368         * arm-obsd-tdep.c: Sort headers.
11369         * arm-nbsd-tdep.c: Sort headers.
11370         * arm-nbsd-nat.c: Sort headers.
11371         * arm-linux-tdep.c: Sort headers.
11372         * arm-linux-nat.c: Sort headers.
11373         * arm-fbsd-tdep.c: Sort headers.
11374         * arm-fbsd-nat.c: Sort headers.
11375         * arm-bsd-tdep.c: Sort headers.
11376         * arch-utils.c: Sort headers.
11377         * arc-tdep.c: Sort headers.
11378         * arc-newlib-tdep.c: Sort headers.
11379         * annotate.h: Sort headers.
11380         * annotate.c: Sort headers.
11381         * amd64-windows-tdep.c: Sort headers.
11382         * amd64-windows-nat.c: Sort headers.
11383         * amd64-tdep.c: Sort headers.
11384         * amd64-sol2-tdep.c: Sort headers.
11385         * amd64-obsd-tdep.c: Sort headers.
11386         * amd64-obsd-nat.c: Sort headers.
11387         * amd64-nbsd-tdep.c: Sort headers.
11388         * amd64-nbsd-nat.c: Sort headers.
11389         * amd64-nat.c: Sort headers.
11390         * amd64-linux-tdep.c: Sort headers.
11391         * amd64-linux-nat.c: Sort headers.
11392         * amd64-fbsd-tdep.c: Sort headers.
11393         * amd64-fbsd-nat.c: Sort headers.
11394         * amd64-dicos-tdep.c: Sort headers.
11395         * amd64-darwin-tdep.c: Sort headers.
11396         * amd64-bsd-nat.c: Sort headers.
11397         * alpha-tdep.c: Sort headers.
11398         * alpha-obsd-tdep.c: Sort headers.
11399         * alpha-nbsd-tdep.c: Sort headers.
11400         * alpha-mdebug-tdep.c: Sort headers.
11401         * alpha-linux-tdep.c: Sort headers.
11402         * alpha-linux-nat.c: Sort headers.
11403         * alpha-bsd-tdep.c: Sort headers.
11404         * alpha-bsd-nat.c: Sort headers.
11405         * aix-thread.c: Sort headers.
11406         * agent.c: Sort headers.
11407         * addrmap.c: Sort headers.
11408         * ada-varobj.c: Sort headers.
11409         * ada-valprint.c: Sort headers.
11410         * ada-typeprint.c: Sort headers.
11411         * ada-tasks.c: Sort headers.
11412         * ada-lang.c: Sort headers.
11413         * aarch64-tdep.c: Sort headers.
11414         * aarch64-ravenscar-thread.c: Sort headers.
11415         * aarch64-newlib-tdep.c: Sort headers.
11416         * aarch64-linux-tdep.c: Sort headers.
11417         * aarch64-linux-nat.c: Sort headers.
11418         * aarch64-fbsd-tdep.c: Sort headers.
11419         * aarch64-fbsd-nat.c: Sort headers.
11420         * aarch32-linux-nat.c: Sort headers.
11421
11422 2019-04-04  Tom Tromey  <tom@tromey.com>
11423
11424         * varobj.c (varobj_create): Update.
11425         * rust-exp.y (struct rust_parser) <update_innermost_block,
11426         lookup_symbol>: New methods.
11427         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11428         Rename.
11429         (rust_parser::rust_lookup_type)
11430         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11431         * printcmd.c (display_command, do_one_display): Update.
11432         * parser-defs.h (struct parser_state) <parser_state>: Add
11433         "tracker" parameter.
11434         (block_tracker): New member.
11435         (class innermost_block_tracker) <innermost_block_tracker>: Add
11436         "types" parameter.
11437         <reset>: Remove method.
11438         (innermost_block): Don't declare.
11439         (null_post_parser): Update.
11440         * parse.c (innermost_block): Remove global.
11441         (write_dollar_variable): Update.
11442         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11443         Remove "tracker_types" parameter.
11444         (parse_expression): Add "tracker" parameter.
11445         (parse_expression_for_completion): Update.
11446         (null_post_parser): Add "tracker" parameter.
11447         * p-exp.y: Update rules.
11448         * m2-exp.y: Update rules.
11449         * language.h (struct language_defn) <la_post_parser>: Add
11450         "tracker" parameter.
11451         * go-exp.y: Update rules.
11452         * f-exp.y: Update rules.
11453         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11454         parameter.
11455         * d-exp.y: Update rules.
11456         * c-exp.y: Update rules.
11457         * breakpoint.c (set_breakpoint_condition): Create an
11458         innermost_block_tracker.
11459         (watch_command_1): Likewise.
11460         * ada-lang.c (resolve): Add "tracker" parameter.
11461         (resolve_subexp): Likewise.
11462         * ada-exp.y (write_var_from_sym): Update.
11463
11464 2019-04-04  Tom Tromey  <tom@tromey.com>
11465
11466         * type-stack.h: New file.
11467         * type-stack.c: New file.
11468         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11469         type-stack.h.
11470         (insert_into_type_stack, insert_type, push_type, push_type_int)
11471         (insert_type_address_space, pop_type, pop_type_int)
11472         (pop_typelist, pop_type_stack, append_type_stack)
11473         (push_type_stack, get_type_stack, push_typelist)
11474         (follow_type_instance_flags, follow_types): Don't declare.
11475         * parse.c (type_stack): Remove global.
11476         (parse_exp_in_context): Update.
11477         (insert_into_type_stack, insert_type, push_type, push_type_int)
11478         (insert_type_address_space, pop_type, pop_type_int)
11479         (pop_typelist, pop_type_stack, append_type_stack)
11480         (push_type_stack, get_type_stack, push_typelist)
11481         (follow_type_instance_flags, follow_types): Remove (moved to
11482         type-stack.c).
11483         * f-exp.y (type_stack): New global.
11484         Update rules.
11485         (push_kind_type, f_parse): Update.
11486         * d-exp.y (type_stack): New global.
11487         Update rules.
11488         (d_parse): Update.
11489         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11490         Update rules.
11491         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11492         (HFILES_NO_SRCDIR): Add type-stack.h.
11493
11494 2019-04-04  Tom Tromey  <tom@tromey.com>
11495
11496         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11497         (rust_parser::convert_ast_to_expression, rust_parse)
11498         (rust_lex_test_completion, rust_lex_tests): Update.
11499         * parser-defs.h (struct expr_completion_state): New.
11500         (struct parser_state) <parser_state>: Add completion parameter.
11501         <mark_struct_expression, mark_completion_tag>: New methods.
11502         <parse_completion, m_completion_state>: New members.
11503         (prefixify_expression, null_post_parser): Update.
11504         (mark_struct_expression, mark_completion_tag): Don't declare.
11505         * parse.c (parse_completion, expout_last_struct)
11506         (expout_tag_completion_type, expout_completion_name): Remove
11507         globals.
11508         (parser_state::mark_struct_expression)
11509         (parser_state::mark_completion_tag): Now methods.
11510         (prefixify_expression): Add last_struct parameter.
11511         (prefixify_subexp): Likewise.
11512         (parse_exp_1): Update.
11513         (parse_exp_in_context): Add cstate parameter.  Update.
11514         (parse_expression_for_completion): Create an
11515         expr_completion_state.
11516         (null_post_parser): Add "completion" parameter.
11517         * p-exp.y: Update rules.
11518         (yylex): Update.
11519         * language.h (struct language_defn) <la_post_parser>: Add
11520         "completing" parameter.
11521         * go-exp.y: Update rules.
11522         (lex_one_token): Update.
11523         * expression.h (parse_completion): Don't declare.
11524         * d-exp.y: Update rules.
11525         (lex_one_token): Update rules.
11526         * c-exp.y: Update rules.
11527         (lex_one_token): Update.
11528         * ada-lang.c (resolve): Add "parse_completion" parameter.
11529         (resolve_subexp): Likewise.
11530         (ada_resolve_function): Likewise.
11531
11532 2019-04-04  Tom Tromey  <tom@tromey.com>
11533
11534         * parser-defs.h (struct parser_state) <start_arglist,
11535         end_arglist>: New methods.
11536         <arglist_len, m_funcall_chain>: New members.
11537         (arglist_len, start_arglist, end_arglist): Don't declare.
11538         * parse.c (arglist_len, funcall_chain): Remove global.
11539         (start_arglist, end_arglist): Remove functions.
11540         (parse_exp_in_context): Update.
11541         * p-exp.y: Update rules.
11542         * m2-exp.y: Update rules.
11543         * go-exp.y: Update rules.
11544         * f-exp.y: Update rules.
11545         * d-exp.y: Update rules.
11546         * c-exp.y: Update rules.
11547
11548 2019-04-04  Tom Tromey  <tom@tromey.com>
11549
11550         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11551         lex_operator, push_back>: New methods.
11552         Update all rules.
11553         (rust_parser::lex_hex, lex_escape): Rename and update.
11554         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11555         (rust_parser::lex_operator): Rename and update.
11556         (rust_parser::lex_number, rustyylex, rustyyerror)
11557         (rust_lex_test_init, rust_lex_test_sequence)
11558         (rust_lex_test_push_back, rust_lex_tests): Update.
11559         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11560         parameter.
11561         <lexptr, prev_lexptr>: New members.
11562         (lexptr, prev_lexptr): Don't declare.
11563         * parse.c (lexptr, prev_lexptr): Remove globals.
11564         (parse_exp_in_context): Update.
11565         * p-exp.y (yylex, yyerror): Update.
11566         * m2-exp.y (parse_number, yylex, yyerror): Update.
11567         * go-exp.y (lex_one_token, yyerror): Update.
11568         * f-exp.y (match_string_literal, yylex, yyerror): Update.
11569         * d-exp.y (lex_one_token, yyerror): Update.
11570         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11571         (lex_one_token, yyerror): Update.
11572         * ada-lex.l (YY_INPUT): Update.
11573         (rewind_to_char): Update.
11574         * ada-exp.y (yyerror): Update.
11575
11576 2019-04-04  Tom Tromey  <tom@tromey.com>
11577
11578         * rust-exp.y (rustyylex, rust_lex_tests): Update.
11579         * parser-defs.h (struct parser_state) <parser_state>: Add new
11580         parameter.
11581         <comma_terminates>: New member.
11582         (comma_terminates): Don't declare global.
11583         * parse.c (comma_terminates): Remove global.
11584         (parse_exp_in_context): Update.
11585         * p-exp.y (yylex): Update.
11586         * m2-exp.y (yylex): Update.
11587         * go-exp.y (lex_one_token): Update.
11588         * f-exp.y (yylex): Update.
11589         * d-exp.y (lex_one_token): Update.
11590         * c-exp.y (lex_one_token): Update.
11591         * ada-lex.l: Update.
11592
11593 2019-04-04  Tom Tromey  <tom@tromey.com>
11594
11595         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11596         (rustyylex, rust_lex_test_init, rust_lex_test_one)
11597         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11598         * parser-defs.h (paren_depth): Don't declare.
11599         * parse.c (paren_depth): Remove global.
11600         (parse_exp_in_context): Update.
11601         * p-exp.y (paren_depth): New global.
11602         (pascal_parse): Initialize it.
11603         * m2-exp.y (paren_depth): New global.
11604         (m2_parse): Initialize it.
11605         * go-exp.y (paren_depth): New global.
11606         (go_parse): Initialize it.
11607         * f-exp.y (paren_depth): New global.
11608         (f_parse): Initialize it.
11609         * d-exp.y (paren_depth): New global.
11610         (d_parse): Initialize it.
11611         * c-exp.y (paren_depth): New global.
11612         (c_parse): Initialize it.
11613         * ada-lex.l (paren_depth): New global.
11614         (lexer_init): Initialize it.
11615
11616 2019-04-04  Tom Tromey  <tom@tromey.com>
11617
11618         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11619         (rust_parser::convert_ast_to_type)
11620         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11621         * parser-defs.h (struct parser_state) <parser_state>: Add
11622         parameters.  Initialize new members.
11623         <expression_context_block, expression_context_pc>: New members.
11624         * parse.c (expression_context_block, expression_context_pc):
11625         Remove globals.
11626         (parse_exp_in_context): Update.
11627         * p-exp.y: Update all rules.
11628         (yylex): Update.
11629         * m2-exp.y: Update all rules.
11630         (yylex): Update.
11631         * go-exp.y (yylex): Update.
11632         * f-exp.y (yylex): Update.
11633         * d-exp.y: Update all rules.
11634         (yylex): Update.
11635         * c-exp.y: Update all rules.
11636         (lex_one_token, classify_name, yylex, c_parse): Update.
11637         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11638
11639 2019-04-04  Tom Tromey  <tom@tromey.com>
11640
11641         * gdbarch.h, gdbarch.c: Rebuild.
11642         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11643         * stap-probe.h:
11644         (struct stap_parse_info): Replace "parser_state" with
11645         "expr_builder".
11646         * parser-defs.h (struct expr_builder): Rename from "parser_state".
11647         (parser_state): New class.
11648         * parse.c (expr_builder): Rename.
11649         (expr_builder::release): Rename.
11650         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11651         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11652         (write_exp_elt_longcst, write_exp_elt_floatcst)
11653         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11654         (write_exp_string_vector, write_exp_bitstring)
11655         (write_exp_msymbol, mark_struct_expression)
11656         (write_dollar_variable)
11657         (insert_type_address_space, increase_expout_size): Replace
11658         "parser_state" with "expr_builder".
11659         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11660         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11661         "parser_state" with "expr_builder".
11662
11663 2019-04-04  Tom Tromey  <tom@tromey.com>
11664
11665         * rust-exp.y: Replace "parse_language" with method call.
11666         * p-exp.y:
11667         (yylex): Replace "parse_language" with method call.
11668         * m2-exp.y:
11669         (yylex): Replace "parse_language" with method call.
11670         * go-exp.y (classify_name): Replace "parse_language" with method
11671         call.
11672         * f-exp.y (yylex): Replace "parse_language" with method call.
11673         * d-exp.y (lex_one_token): Replace "parse_language" with method
11674         call.
11675         * c-exp.y:
11676         (lex_one_token, classify_name, yylex): Replace "parse_language"
11677         with method call.
11678         * ada-exp.y (find_primitive_type, type_char)
11679         (type_system_address): Replace "parse_language" with method call.
11680
11681 2019-04-04  Tom Tromey  <tom@tromey.com>
11682
11683         * rust-exp.y: Replace "parse_gdbarch" with method call.
11684         * parse.c (write_dollar_variable, insert_type_address_space):
11685         Replace "parse_gdbarch" with method call.
11686         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11687         call.
11688         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11689         call.
11690         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11691         "parse_gdbarch" with method call.
11692         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11693         with method call.
11694         * f-exp.y (parse_type, parse_f_type, yylex): Replace
11695         "parse_gdbarch" with method call.
11696         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11697         "parse_gdbarch" with method call.
11698         * c-exp.y (parse_type, parse_number, classify_name): Replace
11699         "parse_gdbarch" with method call.
11700         * ada-lex.l: Replace "parse_gdbarch" with method call.
11701         * ada-exp.y (parse_type, find_primitive_type, type_char)
11702         (type_system_address): Replace "parse_gdbarch" with method call.
11703
11704 2019-04-04  Tom Tromey  <tom@tromey.com>
11705
11706         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11707         * stap-probe.c (stap_parse_argument): Update.
11708         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11709         initial_size parameter.
11710         * rust-exp.y (rust_lex_tests): Update.
11711         * parse.c (parser_state): Update.
11712         (parse_exp_in_context): Update.
11713         * parser-defs.h (struct parser_state) <parser_state>: Remove
11714         "initial_size" parameter.
11715
11716 2019-04-04  Tom Tromey  <tom@tromey.com>
11717
11718         * parser-defs.h (increase_expout_size): Don't declare.
11719         * parse.c (increase_expout_size): Now static.
11720
11721 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
11722
11723         * gnu-nat.c (gnu_nat_target::wait): Fix
11724         target_waitstatus_to_string call.
11725
11726 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11727
11728         * eval.c (evaluate_subexp_standard): Handle internal functions
11729         during Fortran function call handling.
11730
11731 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11732
11733         * NEWS: Mention new internal functions.
11734         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11735         (read_base_type): Use dwarf2_init_complex_target_type.
11736         * value.c (creal_internal_fn): New function.
11737         (cimag_internal_fn): New function.
11738         (_initialize_values): Register new internal functions.
11739
11740 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11741
11742         * infrun.c (stop_all_threads): If debug_infrun, always
11743         trace the wait status after wait_one, using
11744         target_waitstatus_to_string and target_pid_to_str.
11745         (handle_inferior_event): Replace various trace of
11746         wait status kind by a single trace.
11747         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11748         wait status kind image by target_waitstatus_to_string.
11749         * target/waitstatus.c (target_waitstatus_to_string): Fix
11750         obsolete comment.
11751
11752 2019-04-01  Tom Tromey  <tromey@adacore.com>
11753
11754         PR symtab/23331:
11755         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11756
11757 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
11758             Pedro Alves  <palves@redhat.com>
11759
11760         * top.c (quit_force): Call 'finalize_values'.
11761         * value.c (finalize_values): New function.
11762         * value.h (finalize_values): Declare.
11763
11764 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
11765
11766         * NEWS: Announce $_gdb_major and $_gdb_minor.
11767
11768         * top.c (init_gdb_version_vars): New function.
11769         (gdb_init): Call init_gdb_version_vars.
11770
11771 2019-03-29  Tom Tromey  <tromey@adacore.com>
11772
11773         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
11774         help text.  Remove dead code.
11775
11776 2019-03-29  Keith Seitz  <keiths@redhat.com>
11777
11778         From Siddhesh Poyarekar:
11779         * f-lang.h (f77_get_upperbound): Return LONGEST.
11780         (f77_get_lowerbound): Likewise.
11781         * f-typeprint.c (f_type_print_varspec_suffix): Expand
11782         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
11783         print them.
11784         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
11785         plongest to format print it.
11786         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
11787         (f77_get_upperbound): Likewise.
11788         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
11789         LOWER_BOUND to LONGEST.
11790         (f77_create_arrayprint_offset_tbl): Likewise.
11791
11792 2019-03-29  Keith Seitz  <keiths@redhat.com>
11793
11794         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
11795         %s/pulongest for TYPE_LENGTH instead of %d in format
11796         strings.
11797         * ada-typerint.c (ada_print_type): Likewise.
11798         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
11799         * compile/compile-c-support.c (generate_register_struct): Likewise.
11800         * gdbtypes.c (recursive_dump_type): Likewise.
11801         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
11802         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
11803         instead of %d in format strings.
11804         * riscv-tdep.c (riscv_type_alignment): Cast second argument
11805         to std::min to ULONGEST.
11806         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
11807         instead of %d in format strings.
11808         * tracepoint.c (info_scope_command): Likewise.
11809         * typeprint.c (print_offset_data::update)
11810         (print_offset_data::finish): Likewise.
11811         * xtensa-tdep.c (xtensa_store_return_value)
11812         (xtensa_push_dummy_call): Likewise.
11813
11814 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
11815
11816         * windows-nat.c (display_selector): Fixed format specifications
11817         for 64-bit Cygwin.
11818
11819 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11820
11821         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
11822
11823 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
11824
11825         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
11826         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11827         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11828         (nios2_linux_init_abi): Install it.
11829
11830 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11831
11832         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
11833
11834 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
11835
11836         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
11837
11838 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11839             Tom Tromey  <tromey@adacore.com>
11840
11841         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
11842
11843 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
11844
11845         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
11846         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
11847         method to compute the bounds of range types. Also print "[evaluated]"
11848         if the bounds' values come from a dynamic evaluation.
11849
11850 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11851
11852         * cp-valprint.c (cp_print_value_fields): Don't print trailing
11853         whitespace when pretty printing is on.
11854
11855 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11856
11857         * ppc-linux-nat.c: Add include.
11858
11859 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11860
11861         * NEWS: Mention AArch64 Pointer Authentication.
11862
11863 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
11864
11865         * arm-linux-nat.c: Add include.
11866
11867 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
11868
11869         * source-cache.c (source_cache::get_source_lines): Re-read
11870         fullname after calling open_source_file.
11871
11872 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
11873
11874         * NEWS: Mention TLS support for FreeBSD.
11875
11876 2019-03-25  Tom Tromey  <tromey@adacore.com>
11877
11878         * minsyms.c (BUNCH_SIZE): Update comment.
11879         (~minimal_symbol_reader): Remove old comment.
11880         (compact_minimal_symbols): Update comment.
11881         (minimal_symbol_reader::install): Remove old comment.  Update
11882         other comments.
11883
11884 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11885
11886         * s390-linux-nat.c: Add include.
11887
11888 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
11889
11890         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11891         Call linux_get_hwcap.
11892         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11893         Likewise.
11894         (aarch64_linux_get_hwcap): Remove function.
11895         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11896         declaration.
11897         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11898         linux_get_hwcap.
11899         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11900         * linux-tdep.c (linux_get_hwcap): Add function.
11901         (linux_get_hwcap2): Likewise.
11902         * linux-tdep.h (linux_get_hwcap): Add declaration.
11903         (linux_get_hwcap2): Likewise.
11904         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11905         (ppc_linux_get_hwcap2): Likewise.
11906         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11907         linux_get_hwcap.
11908         (ppc_linux_nat_target::insert_watchpoint): Likewise.
11909         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11910         (ppc_linux_nat_target::read_description): Likewise.
11911         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11912         * s390-linux-nat.c: Likewise.
11913         * s390-linux-tdep.c (s390_core_read_description): Likewise.
11914
11915 2019-03-24  Tom Tromey  <tom@tromey.com>
11916
11917         * ada-lang.c (standard_lookup): Simplify initialization.
11918         (ada_lookup_symbol_nonlocal): Simplify return.
11919         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11920         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11921         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11922         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11923         initialization.
11924         * solib.c (solib_global_lookup): Simplify.
11925         * symtab.c (null_block_symbol): Remove.
11926         (symbol_cache_lookup): Simplify returns.
11927         (lookup_language_this): Simplify returns.
11928         (lookup_symbol_aux): Simplify return.
11929         (lookup_local_symbol): Simplify returns.
11930         (lookup_global_symbol_from_objfile): Simplify return.
11931         (lookup_symbol_in_objfile_symtabs)
11932         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11933         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11934         (lookup_static_symbol, lookup_global_symbol): Simplify return.
11935         * cp-namespace.c (cp_lookup_bare_symbol)
11936         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11937         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11938         (cp_lookup_nested_symbol): Don't use null_block_symbol.
11939         (cp_lookup_symbol_via_imports): Simplify initialization.
11940         (find_symbol_in_baseclass): Likewise.
11941         * symtab.h (null_block_symbol): Remove.
11942         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11943         (d_lookup_nested_symbol, d_lookup_symbol_imports)
11944         (d_lookup_symbol_module): Likewise.
11945         (find_symbol_in_baseclass): Simplify initialization.
11946
11947 2019-03-24  Tom Tromey  <tom@tromey.com>
11948
11949         * expression.h: Don't include symtab.h.
11950         (struct block): Forward declare.
11951
11952 2019-03-24  Tom Tromey  <tom@tromey.com>
11953
11954         * c-exp.y (typebase): Remove casts.
11955         * gdbtypes.c (lookup_unsigned_typename, )
11956         (lookup_signed_typename): Remove cast.
11957         * eval.c (parse_to_comma_and_eval): Remove cast.
11958         * parse.c (write_dollar_variable): Remove cast.
11959         * block.h (struct block) <superblock>: Now const.
11960         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11961         * psymtab.c (psym_map_matching_symbols): Make "block" const.
11962         (map_block): Make "block" const.
11963         * symfile.h (struct quick_symbol_functions)
11964         <map_matching_symbols>: Constify block argument to "callback".
11965         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11966         const.
11967         (find_pc_sect_compunit_symtab): Make "b" const.
11968         (find_symbol_at_address): Likewise.
11969         (search_symbols): Likewise.
11970         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11971         (dw2_debug_names_lookup_symbol): Likewise.
11972         (dw2_map_matching_symbols): Update.
11973         * p-valprint.c (pascal_val_print): Remove "block".
11974         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11975         (aux_add_nonlocal_symbols): Make "block" const.
11976         (resolve_subexp): Remove cast.
11977         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11978         const.
11979         (iterate_over_file_blocks): Likewise.
11980         * f-exp.y (%union) <bval>: Remove.
11981         * coffread.c (patch_opaque_types): Make "b" const.
11982         * spu-tdep.c (spu_catch_start): Make "block" const.
11983         * c-valprint.c (print_unpacked_pointer): Remove "block".
11984         * symmisc.c (dump_symtab_1): Make "b" const.
11985         (block_depth): Make "block" const.
11986         * d-exp.y (%union) <bval>: Remove.
11987         * cp-support.h (cp_lookup_rtti_type): Update.
11988         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11989         * psymtab.c (psym_lookup_symbol): Make "block" const.
11990         (maintenance_check_psymtabs): Make "b" const.
11991         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11992         (enumerate_locals, enumerate_args): Update.
11993         * python/py-symtab.c (stpy_global_block): Make "block" const.
11994         (stpy_static_block): Likewise.
11995         * inline-frame.c (block_starting_point_at): Make "new_block"
11996         const.
11997         * block.c (find_block_in_blockvector): Make return type const.
11998         (blockvector_for_pc_sect): Make "b" const.
11999         (find_block_in_blockvector): Make "b" const.
12000
12001 2019-03-23  Tom Tromey  <tom@tromey.com>
12002
12003         * varobj.c (varobj_create): Update.
12004         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12005         * printcmd.c (display_command, do_one_display): Don't reset
12006         innermost_block.
12007         * parser-defs.h (enum innermost_block_tracker_type): Move to
12008         expression.h.
12009         (innermost_block): Update comment.
12010         * parse.c (parse_exp_1): Add tracker_types parameter.
12011         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12012         tracker_types parameter.  Reset innermost_block.
12013         (parse_exp_in_context): Remove.
12014         (parse_expression_for_completion): Update.
12015         * objfiles.c (~objfile): Don't reset expression_context_block or
12016         innermost_block.
12017         * expression.h (enum innermost_block_tracker_type): Move from
12018         parser-defs.h.
12019         (parse_exp_1): Add tracker_types parameter.
12020         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12021         reset innermost_block.
12022
12023 2019-03-23  Tom Tromey  <tom@tromey.com>
12024
12025         * objfiles.h: Include bcache.h.
12026
12027 2019-03-23  Tom Tromey  <tom@tromey.com>
12028
12029         * linespec.c (get_current_search_block): Use
12030         scoped_restore_current_language.
12031         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12032
12033 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12034             Jiong Wang  <jiong.wang@arm.com>
12035
12036         * aarch64-linux-tdep.c
12037         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12038         section.
12039         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12040
12041 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12042             Jiong Wang  <jiong.wang@arm.com>
12043
12044         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12045         instructions.
12046         (aarch64_analyze_prologue_test): Add PACIASP test.
12047         (aarch64_prologue_prev_register): Unmask PC value.
12048
12049 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12050             Jiong Wang  <jiong.wang@arm.com>
12051
12052         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12053         (aarch64_dwarf2_prev_register): Unmask PC value.
12054         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12055         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12056         DW_CFA_AARCH64_negate_ra_state.
12057         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12058
12059 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12060             Jiong Wang  <jiong.wang@arm.com>
12061
12062         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12063         registers.
12064         (aarch64_pseudo_register_name): Likewise.
12065         (aarch64_pseudo_register_type): Likewise.
12066         (aarch64_pseudo_register_reggroup_p): Likewise.
12067         (aarch64_gdbarch_init): Add pauth registers.
12068         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12069         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12070         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12071         (struct gdbarch_tdep): Add regnum for ra_state.
12072
12073 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12074             Jiong Wang  <jiong.wang@arm.com>
12075
12076         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12077
12078 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12079             Jiong Wang  <jiong.wang@arm.com>
12080
12081         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12082         function.
12083         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12084         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12085         (aarch64_gdbarch_init): Add puth registers.
12086         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12087         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12088         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12089
12090 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12091             Jiong Wang  <jiong.wang@arm.com>
12092
12093         * aarch64-linux-nat.c
12094         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12095         * aarch64-linux-tdep.c
12096         (aarch64_linux_core_read_description): Likewise.
12097         (aarch64_linux_get_hwcap): New function.
12098         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12099         (aarch64_linux_get_hwcap): New declaration.
12100
12101 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12102             Jiong Wang  <jiong.wang@arm.com>
12103
12104         * aarch64-linux-nat.c
12105         (aarch64_linux_nat_target::read_description): Add pauth param.
12106         * aarch64-linux-tdep.c
12107         (aarch64_linux_core_read_description): Likewise.
12108         * aarch64-tdep.c (struct target_desc): Add in pauth.
12109         (aarch64_read_description): Add pauth param.
12110         (aarch64_gdbarch_init): Likewise.
12111         * aarch64-tdep.h (aarch64_read_description): Likewise.
12112         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12113         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12114         * features/Makefile: Add new files.
12115         * features/aarch64-pauth.c: New file.
12116         * features/aarch64-pauth.xml: New file.
12117
12118 2019-03-20  Tom Tromey  <tromey@adacore.com>
12119
12120         * infrun.c (handle_inferior_event): Rename from
12121         handle_inferior_event_1.  Create a scoped_value_mark.
12122         (handle_inferior_event): Remove.
12123
12124 2019-03-19  Tom Tromey  <tromey@adacore.com>
12125
12126         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12127         * infrun.h (print_stop_event): Add "displays" parameter.
12128         * infrun.c (print_stop_event): Add "displays" parameter.
12129
12130 2019-03-19  Pedro Alves  <palves@redhat.com>
12131
12132         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12133         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12134         to -1.  Fix TABs vs spaces.
12135         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12136         * tui/tui-out.h (tui_ui_out) Add intro comments.
12137         <m_line, m_start_of_line>: In-class initialize, and add describing
12138         comment.
12139
12140 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12141
12142         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12143         variable names.
12144         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12145
12146 2019-03-18  Pedro Alves  <palves@redhat.com>
12147             Eli Zaretskii <eliz@gnu.org>
12148
12149         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12150         m_line and m_start_of_line.
12151
12152 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12153
12154         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12155         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12156         it returns a newline.  This fixes a regression in TU mode, whereby
12157         the next line is output on the same screen line as the user input.
12158
12159 2019-03-18  Tom Tromey  <tromey@adacore.com>
12160
12161         * minsyms.c (minimal_symbol_reader::install): Remove call to
12162         obstack_blank.
12163
12164 2019-03-18  Pedro Alves  <palves@redhat.com>
12165
12166         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12167         New globals.
12168         (apply_style): New, factored out from ...
12169         (apply_ansi_escape): ... this.  Handle reverse video mode.
12170         (tui_set_reverse_mode): New function.
12171         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12172         * tui/tui-winsource.c (tui_show_source_line): Use
12173         tui_set_reverse_mode instead of setting A_STANDOUT.
12174         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12175         New setter methods.
12176
12177 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12178
12179         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12180         Handle tabs.
12181
12182 2019-03-18  Tom Tromey  <tromey@adacore.com>
12183
12184         * ada-lang.c (empty_array): Add "high" parameter.
12185         (ada_evaluate_subexp): Update.
12186
12187 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12188
12189         * unittests/string_view-selftests.c: Define
12190         _initialize_string_view_selftests unconditionally.
12191
12192 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12193
12194         PR gdb/24350
12195         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12196
12197 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12198
12199         PR gdb/24351
12200         * windows-nat.c (display_selector): Fix format specifiers.
12201
12202 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12203
12204         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12205         tui_refill_source_window instead of tui_refresh_win, to update the
12206         current execution line.  This fixes redisplay of the current line
12207         when stepping through the code with "next" or "step".
12208
12209 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12210
12211         * source-cache.c (source_cache::get_source_lines): Call
12212         find_source_lines to initialize s->nlines.  This fixes vertical
12213         scrolling of TUI source window when the DOWN arrow is pressed.
12214
12215 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12216
12217         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12218         linux-thread-db.c (_initialize_thread_db): Likewise.
12219
12220 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12221
12222         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12223         wclrtoeol in tui_show_source_line".  This reverts changes made in
12224         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12225
12226 2019-03-15  Tom Tromey  <tom@tromey.com>
12227
12228         * symtab.h (struct minimal_symbol): Derive from
12229         general_symbol_info.
12230         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12231         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12232         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12233         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12234         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12235         (MSYMBOL_SEARCH_NAME): Update.
12236         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12237         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12238         * minsyms.c (minimal_symbol_reader::record_full): Update.
12239
12240 2019-03-15  Tom Tromey  <tom@tromey.com>
12241
12242         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12243
12244 2019-03-15  Tom Tromey  <tom@tromey.com>
12245
12246         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12247         unique_xmalloc_ptr.
12248         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12249         Update.
12250         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12251         (build_minimal_symbol_hash_tables)
12252         (minimal_symbol_reader::install): Update.
12253
12254 2019-03-15  Tom Tromey  <tom@tromey.com>
12255
12256         * symtab.c (create_demangled_names_hash): Update.
12257         (symbol_set_names): Update.
12258         * objfiles.h (struct objfile_per_bfd_storage)
12259         <demangled_names_hash>: Now an htab_up.
12260         * objfiles.c (objfile_per_bfd_storage): Simplify.
12261
12262 2019-03-15  Tom Tromey  <tom@tromey.com>
12263
12264         * objfiles.h (struct objfile_per_bfd_storage): Declare
12265         destructor.
12266         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12267         New.
12268         (get_objfile_bfd_data): Use new.  Don't initialize
12269         language_of_main.
12270         (free_objfile_per_bfd_storage): Remove.
12271         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12272
12273 2019-03-15  Tom Tromey  <tom@tromey.com>
12274
12275         * symfile.c (reread_symbols): Update.
12276         * objfiles.c (objfile::objfile): Update.
12277         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12278         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12279         comment.
12280         (minimal_symbol_reader::install): Update.
12281         (terminate_minimal_symbol_table): Remove.
12282         * jit.c (jit_object_close_impl): Update.
12283
12284 2019-03-15  Tom Tromey  <tom@tromey.com>
12285
12286         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12287         initializations.
12288
12289 2019-03-15  Tom Tromey  <tom@tromey.com>
12290
12291         * objfiles.h (struct objfile_per_bfd_storage)
12292         <demangled_hash_languages>: Now a bitset.
12293         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12294         (lookup_minimal_symbol): Update.
12295
12296 2019-03-15  Tom Tromey  <tom@tromey.com>
12297
12298         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12299         Don't return the symbol.
12300         * coffread.c (record_minimal_symbol): Use record_full.
12301
12302 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12303
12304         The MS-Windows port of ncurses fails to switch to a color pair if
12305         one or both of the colors are the implicit default colors.  This
12306         change records the default colors when TUI is initialized, and
12307         then specifies them explicitly when a color pair uses the default
12308         colors.  This allows color styling in TUI mode on MS-Windows.
12309
12310         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12311         ncurses_norm_attr.
12312         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12313         colors in ncurses_norm_attr.
12314         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12315         "none", replace it with the default color recorded in
12316         ncurses_norm_attr.
12317
12318 2019-03-14  Tom Tromey  <tromey@adacore.com>
12319
12320         * source-cache.h (class source_cache) <get_source_lines>: Return
12321         std::string.
12322         * source-cache.c (source_cache::extract_lines): Handle case where
12323         first_pos==npos.  Return std::string.
12324         (source_cache::get_source_lines): Update.
12325
12326 2019-03-14  Tom Tromey  <tromey@adacore.com>
12327
12328         * NEWS: Add item for "style sources" commands.
12329         * source-cache.c (source_cache::get_source_lines): Check
12330         source_styling.
12331         * cli/cli-style.c (source_styling): New global.
12332         (_initialize_cli_style): Add "style sources" commands.
12333         (show_style_sources): New function.
12334         * cli/cli-style.h (source_styling): Declare.
12335
12336 2019-03-14  Pedro Alves  <palves@redhat.com>
12337             Tom Tromey  <tromey@adacore.com>
12338
12339         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12340         * tui/tui-winsource.c (tui_refill_source_window): New function,
12341         from...
12342         (tui_horizontal_source_scroll): ... here.  Move some logic.
12343         * cli/cli-style.c (set_style_enabled): Notify new observable.
12344         * tui/tui-hooks.c (tui_redisplay_source): New function.
12345         (tui_attach_detach_observers): Attach or detach
12346         tui_redisplay_source.
12347         * observable.h (source_styling_changed): New observable.
12348         * observable.c: Define source_styling_changed observable.
12349
12350 2019-03-13  Tom Tromey  <tromey@adacore.com>
12351
12352         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12353         (i386_gnu_nat_target::store_registers): Update.
12354         * target-debug.h (target_debug_print_std_string): New macro.
12355         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12356         * windows-tdep.c (display_one_tib): Update.
12357         * tui/tui-stack.c (tui_make_status_line): Update.
12358         * top.c (print_inferior_quit_action): Update.
12359         * thread.c (thr_try_catch_cmd): Update.
12360         (add_thread_with_info): Update.
12361         (thread_target_id_str): Update.
12362         (thr_try_catch_cmd): Update.
12363         (thread_command): Update.
12364         (thread_find_command): Update.
12365         * record-btrace.c (record_btrace_target::info_record)
12366         (record_btrace_resume_thread, record_btrace_target::resume)
12367         (record_btrace_cancel_resume, record_btrace_step_thread)
12368         (record_btrace_target::wait, record_btrace_target::wait)
12369         (record_btrace_target::wait, record_btrace_target::stop): Update.
12370         * progspace.c (print_program_space): Update.
12371         * process-stratum-target.c
12372         (process_stratum_target::thread_address_space): Update.
12373         * linux-fork.c (linux_fork_mourn_inferior)
12374         (detach_checkpoint_command, info_checkpoints_command)
12375         (linux_fork_context): Update.
12376         (linux_fork_detach): Update.
12377         (class scoped_switch_fork_info): Update.
12378         (delete_checkpoint_command): Update.
12379         * infrun.c (follow_fork_inferior): Update.
12380         (follow_fork_inferior): Update.
12381         (proceed_after_vfork_done): Update.
12382         (handle_vfork_child_exec_or_exit): Update.
12383         (follow_exec): Update.
12384         (displaced_step_prepare_throw): Update.
12385         (displaced_step_restore): Update.
12386         (start_step_over): Update.
12387         (resume_1): Update.
12388         (clear_proceed_status_thread): Update.
12389         (proceed): Update.
12390         (print_target_wait_results): Update.
12391         (do_target_wait): Update.
12392         (context_switch): Update.
12393         (stop_all_threads): Update.
12394         (restart_threads): Update.
12395         (finish_step_over): Update.
12396         (handle_signal_stop): Update.
12397         (switch_back_to_stepped_thread): Update.
12398         (keep_going_pass_signal): Update.
12399         (print_exited_reason): Update.
12400         (normal_stop): Update.
12401         * inferior.c (inferior_pid_to_str): Change return type.
12402         (print_selected_inferior): Update.
12403         (add_inferior): Update.
12404         (detach_inferior): Update.
12405         * dummy-frame.c (fprint_dummy_frames): Update.
12406         * dcache.c (dcache_info_1): Update.
12407         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12408         (btrace_fetch, btrace_clear): Update.
12409         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12410         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12411         type.
12412         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12413         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12414         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12415         * gdbarch.c, gdbarch.h: Rebuild.
12416         * gdbarch.sh (core_pid_to_str): Change return type.
12417         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12418         return type.
12419         (windows_nat_target::pid_to_str): Change return type.
12420         (windows_delete_thread): Update.
12421         (windows_nat_target::attach): Update.
12422         (windows_nat_target::files_info): Update.
12423         * target-delegates.c: Rebuild.
12424         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12425         return type.
12426         (sol_thread_target::pid_to_str): Change return type.
12427         * remote.c (class remote_target) <pid_to_str>: Change return
12428         type.
12429         (remote_target::pid_to_str): Change return type.
12430         (extended_remote_target::attach, remote_target::remote_stop_ns)
12431         (remote_target::remote_notif_remove_queued_reply)
12432         (remote_target::push_stop_reply, remote_target::disable_btrace):
12433         Update.
12434         (extended_remote_target::attach): Update.
12435         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12436         type.
12437         (gdbsim_target::pid_to_str): Change return type.
12438         * ravenscar-thread.c (struct ravenscar_thread_target)
12439         <pid_to_str>: Change return type.
12440         (ravenscar_thread_target::pid_to_str): Change return type.
12441         * procfs.c (class procfs_target) <pid_to_str>: Change return
12442         type.
12443         (procfs_target::pid_to_str): Change return type.
12444         (procfs_target::attach): Update.
12445         (procfs_target::detach): Update.
12446         (procfs_target::fetch_registers): Update.
12447         (procfs_target::store_registers): Update.
12448         (procfs_target::wait): Update.
12449         (procfs_target::files_info): Update.
12450         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12451         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12452         return type.
12453         (nto_procfs_target::pid_to_str): Change return type.
12454         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12455         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12456         return type.
12457         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12458         (exit_lwp): Update.
12459         (attach_proc_task_lwp_callback, get_detach_signal)
12460         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12461         (linux_nat_target::resume, wait_lwp, stop_callback)
12462         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12463         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12464         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12465         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12466         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12467         type.
12468         (inf_ptrace_target::attach): Update.
12469         (inf_ptrace_target::files_info): Update.
12470         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12471         type.
12472         (go32_nat_target::pid_to_str): Change return type.
12473         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12474         (gnu_nat_target::wait): Update.
12475         (gnu_nat_target::wait): Update.
12476         (gnu_nat_target::resume): Update.
12477         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12478         (fbsd_nat_target::wait): Update.
12479         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12480         type.
12481         (darwin_nat_target::attach): Update.
12482         * corelow.c (class core_target) <pid_to_str>: Change return type.
12483         (core_target::pid_to_str): Change return type.
12484         * target.c (normal_pid_to_str): Change return type.
12485         (default_pid_to_str): Likewise.
12486         (target_pid_to_str): Change return type.
12487         (target_translate_tls_address): Update.
12488         (target_announce_detach): Update.
12489         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12490         return type.
12491         (bsd_uthread_target::pid_to_str): Change return type.
12492         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12493         type.
12494         (bsd_kvm_target::pid_to_str): Change return type.
12495         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12496         return type.
12497         (aix_thread_target::pid_to_str): Change return type.
12498         * target.h (struct target_ops) <pid_to_str>: Change return type.
12499         (target_pid_to_str, normal_pid_to_str): Likewise.
12500         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12501         type.
12502         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12503         type.
12504         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12505         return type.
12506         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12507         type.
12508         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12509         type.
12510         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12511         return type.
12512
12513 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12514
12515         * NEWS: Mention that the new default MI version is 3.  Mention
12516         changes to the output of commands and events that deal with
12517         multi-location breakpoints.
12518         * breakpoint.c: Include "mi/mi-out.h".
12519         (print_one_breakpoint): Change output syntax if using MI version
12520         >= 3.
12521         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12522         New.
12523         (mi_multi_location_breakpoint_output_fixed): New.
12524         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12525         (mi_cmd_fix_multi_location_breakpoint_output): New.
12526         (mi_multi_location_breakpoint_output_fixed): New.
12527         * mi/mi-cmds.c (mi_cmds): Register command
12528         -fix-multi-location-breakpoint-output.
12529         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12530         interpreter "mi".
12531
12532 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12533
12534         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12535         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12536         instantiate mi_ui_out based on interpreter name.
12537         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12538         * mi/mi-main.c (mi_load_progress): Likewise.
12539
12540 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12541
12542         * NEWS: Combine separate "New targets" sections for 8.3.
12543
12544 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12545
12546         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12547         (ppcfbsd_init_abi): Install gdbarch
12548         "fetch_tls_load_module_address" and "get_thread_local_address"
12549         methods.
12550
12551 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12552
12553         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12554         (riscv_fbsd_init_abi): Install gdbarch
12555         "fetch_tls_load_module_address" and "get_thread_local_address"
12556         methods.
12557
12558 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12559
12560         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12561         (i386fbsd_init_abi): Install gdbarch
12562         "fetch_tls_load_module_address" and "get_thread_local_address"
12563         methods.
12564
12565 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12566
12567         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12568         (amd64fbsd_init_abi): Install gdbarch
12569         "fetch_tls_load_module_address" and "get_thread_local_address"
12570         methods.
12571
12572 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12573
12574         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12575         (struct fbsd_pspace_data): New type.
12576         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12577         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12578         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12579         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12580         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12581
12582 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12583
12584         * gdbtypes.c (lookup_struct_elt): New function.
12585         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12586         * gdbtypes.h (struct struct_elt): New type.
12587         (lookup_struct_elt): New prototype.
12588
12589 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12590
12591         * gdbtypes.c (lookup_struct_elt_type): Update comment and
12592         remove disabled code block.
12593
12594 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12595
12596         * gdbarch.sh (get_thread_local_address): New method.
12597         * gdbarch.h, gdbarch.c: Regenerate.
12598         * target.c (target_translate_tls_address): Use
12599         gdbarch_get_thread_local_address if present instead of
12600         target::get_thread_local_address.
12601
12602 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12603
12604         * target.h (target::get_thread_local_address): Update comment.
12605
12606 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12607
12608         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12609         objfile->separate_debug_objfile_backlink if not NULL.
12610
12611 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12612
12613         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12614         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12615         (amd64bsd_store_inferior_registers): Likewise.
12616         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12617         Enable segment base registers.
12618         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12619         PT_GETFSBASE and PT_GETGSBASE.
12620         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12621         PT_SETGSBASE.
12622         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12623         segment base registers.
12624         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12625
12626 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12627
12628         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12629         Update calls to i386_target_description to add 'segments'
12630         parameter.
12631         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
12632         add segment base registers.
12633         * arch/i386.c (i386_create_target_description): Add 'segments'
12634         parameter to enable segment base registers.
12635         * arch/i386.h (i386_create_target_description): Likewise.
12636         * features/i386/32bit-segments.xml: New file.
12637         * features/i386/32bit-segments.c: Generate.
12638         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12639         call to i386_target_description to add 'segments' parameter.
12640         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12641         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12642         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12643         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12644         if feature is present.
12645         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12646         Add 'segments' parameter to call to i386_target_description.
12647         (i386_target_description): Add 'segments' parameter to enable
12648         segment base registers.
12649         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12650         to call to i386_target_description.
12651         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12652         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12653         Define I386_NUM_REGS.
12654         (i386_target_description): Add 'segments' parameter to enable
12655         segment base registers.
12656
12657 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
12658
12659         PR/24325
12660         * source-cache.c: #undef open and close, to avoid unresolved
12661         externals during linking.
12662
12663 2019-03-12  Tom Tromey  <tromey@adacore.com>
12664
12665         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12666         const.  Add initializers.
12667         (_initialize_remote): Don't initialize ptid globals.
12668
12669 2019-03-12  Pedro Alves  <palves@redhat.com>
12670
12671         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12672
12673 2019-03-12  Pedro Alves  <palves@redhat.com>
12674
12675         * cp-name-parser.y (main): Remove unused 'len' variable.
12676
12677 2019-03-12  Tom Tromey  <tromey@adacore.com>
12678
12679         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12680         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12681
12682 2019-03-12  Tom Tromey  <tromey@adacore.com>
12683
12684         * linux-nat.c (iterate_over_lwps): Update.
12685         (stop_callback): Remove parameter.
12686         (stop_wait_callback, detach_callback, resume_set_callback)
12687         (select_singlestep_lwp_callback, set_ignore_sigint)
12688         (status_callback, resumed_callback, resume_clear_callback)
12689         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12690         data parameter.
12691         (linux_nat_target::detach, linux_nat_target::resume)
12692         (linux_stop_and_wait_all_lwps, select_event_lwp)
12693         (linux_nat_filter_event, linux_nat_wait_1)
12694         (linux_nat_target::kill, linux_nat_target::stop)
12695         (linux_nat_target::stop): Update.
12696         (linux_nat_resume_callback): Change type.
12697         (resume_stopped_resumed_lwps, count_events_callback)
12698         (select_event_lwp_callback): Likewise.
12699         (linux_stop_lwp, linux_nat_stop_lwp): Update.
12700         * arm-linux-nat.c (struct update_registers_data): Remove.
12701         (update_registers_callback): Change type.
12702         (arm_linux_insert_hw_breakpoint1): Update.
12703         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12704         parameter.
12705         (x86_linux_dr_set_addr): Update.
12706         (x86_linux_dr_set_control): Update.
12707         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12708         (iterate_over_lwps): Use gdb::function_view.
12709         * nat/aarch64-linux-hw-point.c (struct
12710         aarch64_dr_update_callback_param): Remove.
12711         (debug_reg_change_callback): Change type.
12712         (aarch64_notify_debug_reg_change): Update.
12713         * s390-linux-nat.c (s390_refresh_per_info): Update.
12714
12715 2019-03-11  Tom Tromey  <tromey@adacore.com>
12716
12717         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12718         redundant assignment to "this_cu".
12719
12720 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12721
12722         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12723
12724 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12725
12726         * gdbtypes.c (rank_one_type_parm_set): New function extracted
12727         from...
12728         (rank_one_type): ... this.
12729
12730 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12731
12732         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12733         from...
12734         (rank_one_type): ... this.
12735
12736 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12737
12738         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12739         from...
12740         (rank_one_type): ... this.
12741
12742 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12743
12744         * gdbtypes.c (rank_one_type_parm_float): New function extracted
12745         from...
12746         (rank_one_type): ... this.
12747
12748 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12749
12750         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12751         from...
12752         (rank_one_type): ... this.
12753
12754 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12755
12756         * gdbtypes.c (rank_one_type_parm_range): New function extracted
12757         from...
12758         (rank_one_type): ... this.
12759
12760 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12761
12762         * gdbtypes.c (rank_one_type_parm_char): New function extracted
12763         from...
12764         (rank_one_type): ... this.
12765
12766 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12767
12768         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12769         from...
12770         (rank_one_type): ... this.
12771
12772 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12773
12774         * gdbtypes.c (rank_one_type_parm_int): New function extracted
12775         from...
12776         (rank_one_type): ... this.
12777
12778 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12779
12780         * gdbtypes.c (rank_one_type_parm_func): New function extracted
12781         from...
12782         (rank_one_type): ... this.
12783
12784 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12785
12786         * gdbtypes.c (rank_one_type_parm_array): New function extracted
12787         from...
12788         (rank_one_type): ... this.
12789
12790 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12791
12792         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
12793         from...
12794         (rank_one_type): ... this.
12795
12796 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12797
12798         * inferior.c (initialize_inferiors): Ensure 'help set/show print
12799         inferior-events' shows the example events.
12800
12801 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
12802
12803         Support styling on native MS-Windows console
12804
12805         PR/24315
12806         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
12807         on MS-Windows if $TERM is not defined.
12808
12809         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
12810
12811         * posix-hdep.c (gdb_console_fputs):
12812         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
12813         functions.
12814         * ui-file.h (gdb_console_fputs): Add prototype.
12815
12816         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
12817         back to fputs only if the former returns zero.
12818
12819 2019-03-07  Tom Tromey  <tom@tromey.com>
12820
12821         * symmisc.c (print_symbol_bcache_statistics): Update.
12822         (print_objfile_statistics): Update.
12823         * symfile.c (allocate_symtab): Update.
12824         * stabsread.c: Don't include bcache.h.
12825         * psymtab.h (struct psymbol_bcache): Don't declare.
12826         (class psymtab_storage) <psymbol_cache>: Now a bcache.
12827         (psymbol_bcache_init, psymbol_bcache_free)
12828         (psymbol_bcache_get_bcache): Don't declare.
12829         * psymtab.c (struct psymbol_bcache): Remove.
12830         (psymtab_storage::psymtab_storage): Update.
12831         (psymtab_storage::~psymtab_storage): Update.
12832         (psymbol_bcache_init, psymbol_bcache_free)
12833         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12834         (add_psymbol_to_bcache): Update.
12835         (allocate_psymtab): Update.
12836         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
12837         macro_cache>: No longer pointers.
12838         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
12839         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
12840         * macrotab.c (macro_bcache): Update.
12841         * macroexp.c: Don't include bcache.h.
12842         * gdbtypes.c (check_types_worklist): Update.
12843         (types_deeply_equal): Remove TRY/CATCH.  Update.
12844         * elfread.c (elf_symtab_read): Update.
12845         * dwarf2read.c: Don't include bcache.h.
12846         * buildsym.c (buildsym_compunit::get_macro_table): Update.
12847         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
12848         (print_bcache_statistics, bcache_memory_used): Don't declare.
12849         (struct bcache): Move from bcache.c.  Add constructor, destructor,
12850         methods.  Rename all data members.
12851         * bcache.c (struct bcache): Move to bcache.h.
12852         (bcache::expand_hash_table): Rename from expand_hash_table.
12853         (bcache): Remove.
12854         (bcache::insert): Rename from bcache_full.
12855         (bcache::compare): Rename from bcache_compare.
12856         (bcache_xmalloc): Remove.
12857         (bcache::~bcache): Rename from bcache_xfree.
12858         (bcache::print_statistics): Rename from print_bcache_statistics.
12859         (bcache::memory_used): Rename from bcache_memory_used.
12860
12861 2019-03-07  Pedro Alves  <palves@redhat.com>
12862
12863         * infrun.c (normal_stop): Also check for
12864         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12865
12866 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
12867
12868         * f-lang.c (value_from_host_double): Moved to...
12869         * value.c (value_from_host_double): ...here.
12870         * value.h (value_from_host_double): Declare.
12871         * guile/scm-math.c (vlscm_convert_typed_number): Use
12872         value_from_host_double.
12873         (vlscm_convert_number): Likewise.
12874         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12875         * python/py-value.c (convert_value_from_python): Likewise.
12876
12877 2019-03-06  Tom Tromey  <tom@tromey.com>
12878
12879         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12880
12881 2019-03-06  Tom Tromey  <tom@tromey.com>
12882
12883         * utils.h (free_current_contents): Don't declare.
12884         * utils.c (free_current_contents): Remove.
12885
12886 2019-03-06  Tom Tromey  <tom@tromey.com>
12887
12888         * top.c (quit_force): Update.
12889         * main.c (captured_command_loop): Update.
12890         * common/new-op.c (operator new): Update.
12891         * common/common-exceptions.c (struct catcher)
12892         <save_cleanup_chain>: Remove member.
12893         (exceptions_state_mc_init): Update.
12894         (exception_try_scope_entry): Return nullptr.
12895         (exception_try_scope_exit, exception_rethrow)
12896         (throw_exception_sjlj, throw_exception_cxx): Update.
12897         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12898         (all_cleanups, do_cleanups, discard_cleanups)
12899         (discard_final_cleanups, save_cleanups, save_final_cleanups)
12900         (restore_cleanups, restore_final_cleanups): Don't declare.
12901         (do_final_cleanups): Remove parameter.
12902         * common/cleanups.c (cleanup_chain, make_cleanup)
12903         (make_cleanup_dtor, all_cleanups, do_cleanups)
12904         (discard_my_cleanups, discard_cleanups)
12905         (discard_final_cleanups, save_my_cleanups, save_cleanups)
12906         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12907         (null_cleanup): Remove.
12908         (do_final_cleanups): Remove parameter.
12909
12910 2019-03-06  Tom Tromey  <tom@tromey.com>
12911
12912         * remote.c (remote_target::remote_parse_stop_reply): Use
12913         unique_xmalloc_ptr.
12914
12915 2019-03-06  Tom Tromey  <tom@tromey.com>
12916
12917         * stabsread.c (struct stabs_field_info): Rename from field_info.
12918         <list, fnlist>: Add initializers.
12919         <obstack>: New member.
12920         (read_member_functions, read_struct_fields, read_baseclasses):
12921         Allocate on obstack.  Don't use cleanups.
12922         (read_one_struct_field, read_member_functions, read_struct_fields)
12923         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12924         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12925         (read_struct_type): Update.
12926
12927 2019-03-06  Tom Tromey  <tom@tromey.com>
12928
12929         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12930         * common/filestuff.h (make_cleanup_close): Don't declare.
12931         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12932         Remove.
12933
12934 2019-03-06  Tom Tromey  <tom@tromey.com>
12935
12936         * solib-aix.c: Use make_scope_exit.
12937
12938 2019-03-06  Tom Tromey  <tom@tromey.com>
12939
12940         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12941         Use make_scope_exit.
12942
12943 2019-03-06  Tom Tromey  <tom@tromey.com>
12944
12945         * solib-svr4.c (disable_probes_interface): Remove parameter.
12946         (svr4_handle_solib_event): Use make_scope_exit.
12947
12948 2019-03-06  Tom Tromey  <tom@tromey.com>
12949
12950         * remote.c (struct stop_reply_deleter): Remove.
12951         (stop_reply_up): Update.
12952         (struct stop_reply): Derive from notif_event.  Don't typedef.
12953         <regcache>: Now a std::vector.
12954         (stop_reply_xfree): Remove.
12955         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12956         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
12957         (remote_target::discard_pending_stop_replies): Use delete.
12958         (remote_target::remote_parse_stop_reply): Update.
12959         (remote_target::process_stop_reply): Update.
12960         * remote-notif.h (struct notif_event): Add virtual destructor.
12961         Remove "dtr" member.
12962         (struct notif_client) <alloc_event>: Return a unique_ptr.
12963         (notif_event_xfree): Don't declare.
12964         (notif_event_up): New typedef.
12965         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12966         (notif_event_xfree, do_notif_event_xfree): Remove.
12967         (remote_notif_state_xfree): Update.
12968
12969 2019-03-06  Tom Tromey  <tom@tromey.com>
12970
12971         * infrun.c (displaced_step_clear_cleanup): Now a
12972         forward_scope_exit type.
12973         (displaced_step_prepare_throw): Update.
12974         (displaced_step_fixup): Update.
12975
12976 2019-03-06  Tom Tromey  <tom@tromey.com>
12977
12978         * inferior.h (class inferior): Update comment.
12979         * gdbthread.h (class thread_info): Update comment.
12980
12981 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
12982             Tom Tromey  <tom@tromey.com>
12983
12984         * stabsread.h (struct stab_section_list): Remove.
12985         (coffstab_build_psymtabs): Update.
12986         * dbxread.c (symbuf_sections): Now a std::vector.
12987         (sect_idx): New global.
12988         (fill_symbuf): Update.
12989         (coffstab_build_psymtabs): Change type of stabsects parameter.
12990         Update.
12991         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12992         std::vector.
12993         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12994         (coff_locate_sections): Update.
12995         (coff_symfile_read): Remove cleanups.  Update.
12996         (init_stringtab): Add storage parameter.
12997         (free_stringtab, free_stringtab_cleanup): Remove.
12998         (init_lineno): Add storage parameter.
12999         (free_linetab, free_linetab_cleanup): Remove.
13000
13001 2019-03-06  Pedro Alves  <palves@redhat.com>
13002
13003         * linux-fork.c (fork_info::clobber_regs): Delete.
13004         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13005         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13006         comment.  Adjust.
13007         (scoped_switch_fork_info::scoped_switch_fork_info)
13008         (checkpoint_command, linux_fork_context): Adjust
13009         fork_save_infrun_state calls.
13010
13011 2019-03-06  Pedro Alves  <palves@redhat.com>
13012
13013         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13014         (inf_has_multiple_threads): Return 'bool' and rewrite using
13015         inferior_info::threads().
13016
13017 2019-03-06  Pedro Alves  <palves@redhat.com>
13018
13019         * linux-fork.c: Include <list>.
13020         (fork_list): Now a std::list instance.
13021         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13022         (forks_exist_p, find_last_fork): Adjust.
13023         (new_fork): Delete.
13024         (one_fork_p): New.
13025         (add_fork): Adjust.
13026         (free_fork): Delete, folded into fork_info::~fork_info().
13027         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13028         Adjust.
13029         (init_fork_list): Delete.
13030         (linux_fork_killall, linux_fork_mourn_inferior)
13031         (linux_fork_detach, info_checkpoints_command): Adjust.
13032         (_initialize_linux_fork): No longer call init_fork_list.
13033
13034 2019-03-06  Pedro Alves  <palves@redhat.com>
13035
13036         * linux-fork.c (new_fork): New, split out of ...
13037         (add_fork): ... this.  Return void.  Move "first fork" special
13038         case from here, to ...
13039         (checkpoint_command): ... here.
13040         * linux-linux.h (add_fork): Return void.
13041
13042 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13043
13044         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13045
13046 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13047             Chris January  <chris.january@arm.com>
13048             David Lecomber  <david.lecomber@arm.com>
13049
13050         * f-exp.y: New token, UNOP_INTRINSIC.
13051         (exp): New pattern using UNOP_INTRINSIC token.
13052         (f77_keywords): Add 'abs' keyword.
13053         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13054         (value_from_host_double): New function.
13055         (evaluate_subexp_f): Support UNOP_ABS.
13056
13057 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13058
13059         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13060         types.
13061
13062 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13063
13064         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13065         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13066         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13067
13068 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13069
13070         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13071
13072 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13073             Chris January  <chris.january@arm.com>
13074
13075         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13076         * f-exp.y: Define 'KIND' token.
13077         (exp): New pattern for KIND expressions.
13078         (ptype): Handle types with a kind extension.
13079         (direct_abs_decl): Extend to spot kind extensions.
13080         (f77_keywords): Add 'kind' to the list.
13081         (push_kind_type): New function.
13082         (convert_to_kind_type): New function.
13083         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13084         * parse.c (operator_length_standard): Likewise.
13085         * parser-defs.h (enum type_pieces): Add tp_kind.
13086         * std-operator.def: Add UNOP_KIND.
13087
13088 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13089
13090         * f-exp.y (f_parse): Set yydebug.
13091
13092 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13093
13094         * f-lang.c (evaluate_subexp_f): New function.
13095         (exp_descriptor_f): New global.
13096         (f_language_defn): Use exp_descriptor_f instead of
13097         exp_descriptor_standard.
13098
13099 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13100
13101         * f-exp.y (struct token): Add comments.
13102         (dot_ops): Remove uppercase versions and the end marker.
13103         (f77_keywords): Likewise.
13104         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13105         entries in the dot_ops array are case insensitive, and use
13106         strncasecmp to compare strings.  Also some whitespace cleanup in
13107         this area.  Similar for the f77_keywords array, except entries in
13108         this list might be case sensitive.
13109
13110 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13111
13112         * f-exp.y (struct f77_boolean_val): Add comments.
13113         (boolean_values): Remove uppercase versions, and end marker.
13114         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13115         and use strncasecmp to achieve case insensitivity.  Additionally,
13116         perform whitespace cleanup around this code.
13117
13118 2019-03-06  Tom Tromey  <tromey@adacore.com>
13119
13120         * remote-sim.c (gdbsim_target_open): Use result of
13121         gdb_argv::release.
13122
13123 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13124         Dirk Schubert  <dirk.schubert@arm.com>
13125         Chris January  <chris.january@arm.com>
13126
13127         * eval.c (evaluate_subexp_standard): Call Fortran argument
13128         wrapping logic.
13129         * f-lang.c (struct value): A value which can be passed into a
13130         Fortran function call.
13131         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13132         where appropriate.
13133         (struct type): Value ready for a Fortran function call.
13134         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13135         is needed.
13136         * f-lang.h (fortran_argument_convert): Declaration.
13137         (fortran_preserve_arg_pointer): Declaration.
13138         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13139
13140 2019-03-05  Tom Tromey  <tromey@adacore.com>
13141
13142         * python/py-prettyprint.c (print_string_repr): Remove #if.
13143         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13144
13145 2019-03-05  Tom Tromey  <tromey@adacore.com>
13146
13147         * target.c (the_dummy_target): Move later.  Change type to
13148         "dummy_target".
13149         (initialize_targets): Don't initialize the_dummy_target.
13150
13151 2019-03-05  Tom Tromey  <tromey@adacore.com>
13152
13153         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13154         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13155
13156 2019-03-05  Tom Tromey  <tromey@adacore.com>
13157
13158         * windows-nat.c (windows_nat_target::attach)
13159         (windows_nat_target::detach): Don't call gdb_flush.
13160         * valprint.c (generic_val_print, val_print, val_print_string):
13161         Don't call gdb_flush.
13162         * utils.c (defaulted_query): Don't call gdb_flush.
13163         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13164         * target.c (target_announce_detach): Don't call gdb_flush.
13165         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13166         * remote.c (extended_remote_target::attach): Don't call
13167         gdb_flush.
13168         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13169         * printcmd.c (do_examine): Don't call gdb_flush.
13170         (info_display_command): Don't call gdb_flush.
13171         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13172         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13173         * memattr.c (info_mem_command): Don't call gdb_flush.
13174         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13175         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13176         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13177         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13178         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13179         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13180         (gnu_nat_target::detach): Don't call gdb_flush.
13181         * f-valprint.c (f_val_print): Don't call gdb_flush.
13182         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13183         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13184         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13185         gdb_flush.
13186         * c-valprint.c (c_val_print): Don't call gdb_flush.
13187         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13188
13189 2019-03-05  Tom Tromey  <tromey@adacore.com>
13190
13191         * varobj.c (update_dynamic_varobj_children): Update.
13192         (install_default_visualizer): Use reset, not release.
13193         * value.c (set_internalvar): Update.
13194         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13195         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13196         ATTRIBUTE_UNUSED_RESULT.
13197
13198 2019-03-05  Tom Tromey  <tromey@adacore.com>
13199
13200         * remote.c (class scoped_remote_fd) <release>: Add
13201         ATTRIBUTE_UNUSED_RESULT.
13202
13203 2019-03-05  Tom Tromey  <tromey@adacore.com>
13204
13205         * macroexp.c (struct macro_buffer) <release>: Add
13206         ATTRIBUTE_UNUSED_RESULT.
13207
13208 2019-03-05  Tom Tromey  <tromey@adacore.com>
13209
13210         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13211         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13212         ATTRIBUTE_UNUSED_RESULT.
13213
13214 2019-03-05  Tom Tromey  <tromey@adacore.com>
13215
13216         * common/scoped_fd.h (class scoped_fd) <release>: Add
13217         ATTRIBUTE_UNUSED_RESULT.
13218
13219 2019-03-05  Tom Tromey  <tromey@adacore.com>
13220
13221         * parser-defs.h (struct parser_state) <release>: Add
13222         ATTRIBUTE_UNUSED_RESULT.
13223
13224 2019-03-05  Tom Tromey  <tromey@adacore.com>
13225
13226         * utils.h (class gdb_argv) <release>: Add
13227         ATTRIBUTE_UNUSED_RESULT.
13228         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13229
13230 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13231
13232         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13233         for-loop range, to avoid compiler warnings.
13234
13235         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13236         avoid compiler warnings about unused variables.
13237
13238         * NEWS: Mention end of support for native debugging on MS-Windows
13239         before XP.
13240
13241         PR gdb/24292
13242         * common/netstuff.c:
13243         * gdbserver/gdbreplay.c
13244         * gdbserver/remote-utils.c:
13245         * ser-tcp.c:
13246         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13247         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13248         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13249         'getaddrinfo' and 'freeaddrinfo' were not available before
13250         Windows XP, and mingw.org's MinGW headers by default define
13251         _WIN32_WINNT to 0x500.
13252
13253 2019-03-01  Gary Benson <gbenson@redhat.com>
13254
13255         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13256
13257 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13258             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13259
13260         PR gdb/8527
13261         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13262         set_sigint_trap, clear_sigint_trap.
13263
13264 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13265
13266         * target.c (target_detach): Clear the regcache and the
13267         frame cache.
13268
13269 2019-02-27  Pedro Alves  <palves@redhat.com>
13270
13271         * utils.c (set_screen_size): When we cap the height/width sizes,
13272         tweak the corresponding command variable to show "unlimited":
13273
13274 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13275             Pedro Alves  <palves@redhat.com>
13276
13277         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13278         before calling rl_set_screen_size.
13279
13280 2019-02-27  Tom Tromey  <tromey@adacore.com>
13281
13282         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13283         define.
13284         * python/py-value.c: Remove Python 2.4 workaround.
13285         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13286         workaround.
13287         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13288         Python 2.4 workaround.
13289         * python/python-internal.h: Remove Python 2.4 comment.
13290         (Py_ssize_t): Don't define.
13291         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13292         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13293         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13294         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13295         * python/python.c (do_start_initialization): Remove Python 2.4
13296         workaround.
13297         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13298         (print_children): Remove Python 2.4 workaround.
13299         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13300         workaround.
13301         (CHARBUFFERPROC_NAME): Remove.
13302         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13303         Python 2.4 workaround.
13304
13305 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13306
13307         * NEWS: Note minimum Python version.
13308
13309 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13310
13311         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13312         code from these functions.  Remove corresponding ifdefs.  Use
13313         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13314         Remove gotos and target of gotos.
13315         (infpy_search_memory): Likewise.
13316
13317 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13318
13319         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13320         (hppa_gdbarch_init): Don't register deleted functions with
13321         gdbarch.
13322
13323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13324
13325         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13326         (h8300_unwind_sp): Delete.
13327         (h8300_dummy_id): Delete.
13328         (h8300_gdbarch_init): Don't register deleted functions with
13329         gdbarch.
13330
13331 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13332
13333         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13334         (ft32_unwind_pc): Delete.
13335         (ft32_unwind_sp): Delete.
13336         (ft32_gdbarch_init): Don't register deleted functions with
13337         gdbarch.
13338
13339 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13340
13341         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13342         (frv_unwind_pc): Delete.
13343         (frv_unwind_sp): Delete.
13344         (frv_gdbarch_init): Don't register deleted functions with
13345         gdbarch.
13346
13347 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13348
13349         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13350         (riscv_unwind_pc): Delete.
13351         (riscv_unwind_sp): Delete.
13352         (riscv_gdbarch_init): Don't register deleted functions with
13353         gdbarch.
13354
13355 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13356
13357         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13358         (csky_unwind_pc): Delete.
13359         (csky_unwind_sp): Delete.
13360         (csky_gdbarch_init): Don't register deleted functions with
13361         gdbarch.
13362
13363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13364
13365         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13366         (cris_unwind_pc): Delete.
13367         (cris_unwind_sp): Delete.
13368         (cris_gdbarch_init): Don't register deleted functions with
13369         gdbarch.
13370
13371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13372
13373         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13374         (bfin_unwind_pc): Delete.
13375         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13376
13377 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13378
13379         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13380         (arm_unwind_pc): Delete.
13381         (arm_unwind_sp): Delete.
13382         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13383
13384 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13385
13386         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13387         (arc_unwind_pc): Delete.
13388         (arc_unwind_sp): Delete.
13389         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13390
13391 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13392
13393         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13394         (alpha_unwind_pc): Delete.
13395         (alpha_gdbarch_init): Don't register deleted functions with
13396         gdbarch.
13397
13398 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13399
13400         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13401         (aarch64_unwind_pc): Delete.
13402         (aarch64_unwind_sp): Delete.
13403         (aarch64_gdbarch_init): Don't register deleted functions with
13404         gdbarch.
13405
13406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13407
13408         * gdbtypes.c (type_align): Don't consider static members when
13409         computing structure alignment.
13410
13411 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13412
13413         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13414         return 0 for other types.
13415         * arch-utils.c (default_type_align): Always return 0.
13416         * gdbarch.h: Regenerate.
13417         * gdbarch.sh (type_align): Extend comment.
13418         * gdbtypes.c (type_align): Add additional comments, always call
13419         gdbarch_type_align before applying the default rules.
13420         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13421         generic code will then apply a suitable default.
13422         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13423         types, return 0 for other types.
13424
13425 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13426
13427         * NEWS: Create a new section for the next release branch.
13428         Rename the section of the current branch, now that it has
13429         been cut.
13430
13431 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13432
13433         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13434         * version.in: Bump version to 8.3.50.DATE-git.
13435
13436 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13437
13438         * aix-thread.c (ptid_cmp): Remove unused variable.
13439         (get_signaled_thread): Likewise.
13440         (store_regs_user_thread): Likewise.
13441         (store_regs_kernel_thread): Likewise.
13442         (fetch_regs_kernel_thread): Remove shadowed variable.
13443
13444 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13445
13446         * features/riscv/32bit-cpu.xml: Add register numbers.
13447         * features/riscv/32bit-fpu.c: Regenerate.
13448         * features/riscv/32bit-fpu.xml: Add register numbers.
13449         * features/riscv/64bit-cpu.xml: Add register numbers.
13450         * features/riscv/64bit-fpu.c: Regenerate.
13451         * features/riscv/64bit-fpu.xml: Add register numbers.
13452
13453 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13454
13455         * NEWS: Mention two argument form of gdb.Value constructor.
13456         * python/py-value.c (convert_buffer_and_type_to_value): New
13457         function.
13458         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13459         Add support for handling an optional second argument.  Call
13460         convert_buffer_and_type_to_value as appropriate.
13461         * python/python-internal.h (Py_buffer_deleter): New struct.
13462         (Py_buffer_up): New typedef.
13463
13464 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13465
13466         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13467         instead of releasing ownership.
13468
13469 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13470
13471         * dwarf2read.c (open_and_init_dwp_file): Call
13472         elf_numsections instead of bfd_count_sections to initialize
13473         dwp_file->num_sections.
13474
13475 2019-02-25  Tom Tromey  <tromey@adacore.com>
13476
13477         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13478
13479 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13480
13481         * gcore.in: Add '--readnever' option when invoking GDB.
13482
13483 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13484
13485         * MAINTAINERS: Update my email address.
13486
13487 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13488
13489         * build-id.c (build_id_to_debug_bfd_1): New function.
13490         (build_id_to_debug_bfd): Look for separate debug file in
13491         sysroot.
13492
13493 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13494
13495         * gdbarch.sh: Update the copyright year range that is placed into
13496         generated files.
13497
13498 2019-02-22  Keith Seitz  <keiths@redhat.com>
13499
13500         PR symtab/23853
13501         * linespec.c (create_sals_line_offset): Search for the default
13502         symtab's filename instead of its fullname.
13503
13504 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13505
13506         * NEWS: Update style defaults.
13507
13508 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13509
13510         * main.c (captured_main_1): Disable styling in batch mode.
13511
13512 2019-02-20  Tom Tromey  <tom@tromey.com>
13513
13514         * symtab.c (symtab_symbol_info): Fix typos.
13515
13516 2019-02-20  Tom Tromey  <tromey@adacore.com>
13517
13518         * findcmd.c (_initialize_mem_search): Use upper case for
13519         metasyntactic variables.
13520
13521 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13522
13523         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13524         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13525
13526 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13527
13528         * top.h (source_file_name): Change to std::string.
13529         * top.c (source_file_name): Likewise.
13530         (command_line_input): Adjust.
13531         * cli/cli-script.c (script_from_file): Adjust.
13532
13533 2019-02-19  Tom Tromey  <tromey@adacore.com>
13534
13535         * ravenscar-thread.c
13536         (ravenscar_thread_target::update_thread_list): Don't call
13537         ada_build_task_list.
13538         * ada-lang.h (ada_build_task_list): Don't declare.
13539         * ada-tasks.c (struct ada_tasks_inferior_data)
13540         <task_list_valid_p>: Now bool.
13541         (read_known_tasks, ada_task_list_changed)
13542         (ada_tasks_invalidate_inferior_data): Update.
13543         (read_known_tasks_array): Return bool.
13544         (read_known_tasks_list): Likewise.
13545         (read_known_tasks): Return void.
13546         (ada_build_task_list): Now static.
13547
13548 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
13549
13550         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13551         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13552
13553 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13554
13555         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13556         variant for ada_tasks_pspace_data_handle and
13557         ada_tasks_inferior_data_handle.
13558         (ada_tasks_pspace_data_cleanup): New function.
13559         (ada_tasks_inferior_data_cleanup): New function.
13560
13561 2019-02-17  Tom Tromey  <tom@tromey.com>
13562
13563         * macrotab.h (macro_source_fullname): Return a std::string.
13564         * macrotab.c (macro_include, check_for_redefinition)
13565         (macro_undef, macro_lookup_definition, foreach_macro)
13566         (foreach_macro_in_scope): Update.
13567         (macro_source_fullname): Return a std::string.
13568         * macrocmd.c (show_pp_source_pos): Update.
13569
13570 2019-02-17  Tom Tromey  <tom@tromey.com>
13571
13572         * macrocmd.c (show_pp_source_pos): Style the file names.
13573
13574 2019-02-17  Tom Tromey  <tom@tromey.com>
13575
13576         PR tui/24197:
13577         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13578
13579 2019-02-17  Tom Tromey  <tom@tromey.com>
13580
13581         * ada-lang.c (user_select_syms): Use filtered printing.
13582         * utils.c (wrap_style): New global.
13583         (desired_style): Remove.
13584         (emit_style_escape): Add stream parameter.
13585         (set_output_style, reset_terminal_style, prompt_for_continue):
13586         Update.
13587         (flush_wrap_buffer): Only flush gdb_stdout.
13588         (wrap_here): Set wrap_style.
13589         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
13590         treat escape sequences as a character.  Change when wrap buffer is
13591         flushed.
13592         (fputs_styled): Do not set the output style when the default is
13593         requested.
13594         * ui-style.h (struct ui_file_style) <is_default>: New method.
13595         * source.c (print_source_lines_base): Emit escape sequences in one
13596         piece.
13597
13598 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13599
13600         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13601         integers and enumeration types.
13602
13603 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13604
13605         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13606         instead of lookup_symbol_in_language
13607         (do_exact_match): New function.
13608         (ada_get_symbol_name_matcher): Return do_exact_match when
13609         doing a verbatim match.
13610
13611 2019-02-15  Tom Tromey  <tromey@adacore.com>
13612
13613         * ravenscar-thread.c (ravenscar_thread_target::resume)
13614         (ravenscar_thread_target::wait): Special case wildcard requests.
13615
13616 2019-02-15  Tom Tromey  <tromey@adacore.com>
13617
13618         * ravenscar-thread.c (base_ptid): Remove.
13619         (struct ravenscar_thread_target) <close>: New method.
13620         <m_base_ptid>: New member.
13621         <update_inferior_ptid, active_task, task_is_currently_active,
13622         runtime_initialized>: Declare methods.
13623         <ravenscar_thread_target>: Add constructor.
13624         (ravenscar_thread_target::task_is_currently_active)
13625         (ravenscar_thread_target::update_inferior_ptid)
13626         (ravenscar_runtime_initialized): Rename.  Now methods.
13627         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13628         (ravenscar_thread_target::update_thread_list): Update.
13629         (ravenscar_thread_target::active_task): Now method.
13630         (ravenscar_thread_target::store_registers)
13631         (ravenscar_thread_target::prepare_to_store)
13632         (ravenscar_thread_target::prepare_to_store)
13633         (ravenscar_thread_target::mourn_inferior): Update.
13634         (ravenscar_inferior_created): Use "new" to create target.
13635         (ravenscar_thread_target::get_ada_task_ptid): Update.
13636         (_initialize_ravenscar): Don't initialize base_ptid.
13637         (ravenscar_ops): Remove global.
13638
13639 2019-02-15  Tom Tromey  <tromey@adacore.com>
13640
13641         * target.h (push_target): Declare new overload.
13642         * target.c (push_target): New overload, taking an rvalue reference.
13643         * remote.c (remote_target::open_1): Use push_target overload.
13644         * corelow.c (core_target_open): Use push_target overload.
13645
13646 2019-02-15  Tom Tromey  <tromey@adacore.com>
13647
13648         * ravenscar-thread.c (is_ravenscar_task)
13649         (ravenscar_task_is_currently_active): Return bool.
13650         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13651         (_initialize_ravenscar): Remove "(void)".
13652         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13653         Return bool.
13654
13655 2019-02-15  Tom Tromey  <tromey@adacore.com>
13656
13657         * ravenscar-thread.c (ravenscar_runtime_initializer)
13658         (has_ravenscar_runtime, get_running_thread_id)
13659         (ravenscar_thread_target::resume): Fix indentation.
13660
13661 2019-02-15  Tom Tromey  <tromey@adacore.com>
13662
13663         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13664         from ravenscar_arch_ops.
13665         (sparc_ravenscar_ops::fetch_registers)
13666         (sparc_ravenscar_ops::store_registers): Now methods.
13667         (sparc_ravenscar_prepare_to_store): Remove.
13668         (sparc_ravenscar_ops): Redefine.
13669         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13670         methods and destructor.  Remove members.
13671         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13672         (ravenscar_thread_target::store_registers)
13673         (ravenscar_thread_target::prepare_to_store): Update.
13674         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13675         Remove.
13676         (struct ppc_ravenscar_powerpc_ops): Derive from
13677         ravenscar_arch_ops.
13678         (ppc_ravenscar_powerpc_ops::fetch_registers)
13679         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13680         (ppc_ravenscar_powerpc_ops): Redefine.
13681         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13682         (ppc_ravenscar_e500_ops::fetch_registers)
13683         (ppc_ravenscar_e500_ops::store_registers): Now methods.
13684         (ppc_ravenscar_e500_ops): Redefine.
13685         * aarch64-ravenscar-thread.c
13686         (aarch64_ravenscar_generic_prepare_to_store): Remove.
13687         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13688         (aarch64_ravenscar_fetch_registers)
13689         (aarch64_ravenscar_store_registers): Now methods.
13690         (aarch64_ravenscar_ops): Redefine.
13691
13692 2019-02-15  Tom Tromey  <tromey@adacore.com>
13693
13694         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13695         (ravenscar_thread_target::stopped_by_hw_breakpoint)
13696         (ravenscar_thread_target::stopped_by_watchpoint)
13697         (ravenscar_thread_target::stopped_data_address)
13698         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13699
13700 2019-02-15  Tom Tromey  <tromey@adacore.com>
13701
13702         * ravenscar-thread.c: Fix some typos.
13703
13704 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13705             Tom Tromey  <tromey@adacore.com>
13706
13707         * ada-lang.c (ada_exception_sal): Change addr_string to a
13708         std::string.
13709         (create_ada_exception_catchpoint): Update.
13710
13711 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13712             Tom Tromey  <tromey@adacore.com>
13713
13714         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13715         (bp_location_ops): Remove.
13716         (base_breakpoint_allocate_location): Update.
13717         (free_bp_location): Update.
13718         * ada-lang.c (class ada_catchpoint_location)
13719         <ada_catchpoint_location>: Remove ops parameter.
13720         (ada_catchpoint_location_dtor): Remove.
13721         (ada_catchpoint_location_ops): Remove.
13722         (allocate_location_exception): Update.
13723         * breakpoint.h (struct bp_location_ops): Remove.
13724         (class bp_location) <bp_location>: Remove bp_location_ops
13725         parameter.
13726         <~bp_location>: Add destructor.
13727         <ops>: Remove.
13728
13729 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13730             Pedro Alves  <palves@redhat.com>
13731
13732         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13733         'PATH_MAX'.
13734
13735 2019-02-14  David Michael  <fedora.dm0@gmail.com>
13736             Samuel Thibault  <samuel.thibault@gnu.org>
13737             Thomas Schwinge  <thomas@codesourcery.com>
13738
13739         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13740         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13741
13742 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13743
13744         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13745         (check_empty): Use "const char *".
13746
13747         * gnu-nat.c (gnu_nat_target::detach): Instead of
13748         'detach_inferior (pid)' call
13749         'detach_inferior (find_inferior_pid (pid))'.
13750
13751         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13752         'nat/fork-inferior.o'.
13753         * gnu-nat.c: #include "nat/fork-inferior.h".
13754
13755         * gnu-nat.c (gnu_nat_target::detach): Instead of
13756         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13757         * gnu-nat.h: #include "inf-child.h".
13758         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13759         'i386_gnu_nat_target::fetch_registers'.
13760         (gnu_store_registers): Rename/move to
13761         'i386_gnu_nat_target::store_registers'.
13762
13763         * config/i386/nm-i386gnu.h: Don't "#include" any files.
13764         * gnu-nat.h (mach_thread_info): New function.
13765         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13766
13767         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13768
13769 2019-02-14  Frederic Konrad  <konrad@adacore.com>
13770
13771         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
13772
13773 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
13774
13775         * windows-nat.c (windows_add_thread): Add new parameter
13776         "main_thread_p" with default value set to false.  Update
13777         function documentation as well as all callers.
13778         (windows_delete_thread): Likewise.
13779         (fake_create_process): Update call to windows_add_thread.
13780         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
13781         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
13782         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
13783         call to windows_delete_thread.
13784
13785 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
13786
13787         * MAINTAINERS: Add Andrew Burgess as global maintainer.
13788
13789 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13790
13791         * symfile.c (find_separate_debug_file): Use canonical path of
13792         sysroot with child_path instead of gdb_sysroot if it is valid.
13793
13794 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13795
13796         * symfile.c (find_separate_debug_file): Use child_path to
13797         determine if an object file is under a sysroot.
13798
13799 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13800
13801         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
13802         unittests/child-path-selftests.c.
13803         * common/pathstuff.c (child_path): New function.
13804         * common/pathstuff.h (child_path): New prototype.
13805         * unittests/child-path-selftests.c: New file.
13806
13807 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
13808
13809         * symfile.c (find_separate_debug_file): Look for separate debug
13810         files in debug directories under the sysroot.
13811
13812 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13813
13814         * symtab.h (struct minimal_symbol data_p): New const method.
13815         (struct minimal_symbol text_p): Likewise.
13816         * symtab.c (output_source_filename): Use file name style
13817         to print file name.
13818         (print_symbol_info): Likewise.
13819         (print_msymbol_info): Use address style to print addresses.
13820         Use function name style to print executable text symbols.
13821         (expand_symtab_containing_pc): Use data_p.
13822         (find_pc_sect_compunit_symtab): Likewise.
13823
13824 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13825
13826         * breakpoint.c (describe_other_breakpoints): Use address style
13827         to print addresses.
13828         (say_where): Likewise.
13829
13830 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13831
13832         * ada-typeprint.c (print_func_type): Print function name
13833         style to print function name.
13834         * c-typeprint.c (c_print_type_1): Likewise.
13835
13836 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
13837
13838         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
13839         for execve.
13840
13841 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13842
13843         * c-exp.y (direct_abs_decl): Use emplace_back to record the
13844         type_stack.
13845
13846 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
13847
13848         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
13849         TYPE_CODE_REF types.
13850
13851 2019-02-08  Jim Wilson  <jimw@sifive.com>
13852
13853         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
13854         (riscv_linux_fregset): New.
13855         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
13856
13857 2019-02-07  Tom Tromey  <tom@tromey.com>
13858
13859         * thread.c (thread_cancel_execution_command): Update.
13860         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13861         methods.
13862         (struct thread_fsm_ops): Remove.
13863         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13864         (thread_fsm_should_stop, thread_fsm_return_value)
13865         (thread_fsm_set_finished, thread_fsm_finished_p)
13866         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13867         Don't declare.
13868         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13869         * infrun.c (clear_proceed_status_thread)
13870         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13871         (print_stop_event): Update.
13872         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13873         Add constructor.
13874         (step_command_fsm_ops): Remove.
13875         (new_step_command_fsm): Remove.
13876         (step_1): Update.
13877         (step_command_fsm::should_stop): Rename from
13878         step_command_fsm_should_stop.
13879         (step_command_fsm::clean_up): Rename from
13880         step_command_fsm_clean_up.
13881         (step_command_fsm::do_async_reply_reason): Rename from
13882         step_command_fsm_async_reply_reason.
13883         (struct until_next_fsm): Inherit from thread_fsm.  Add
13884         constructor.
13885         (until_next_fsm_ops): Remove.
13886         (new_until_next_fsm): Remove.
13887         (until_next_fsm::should_stop): Rename from
13888         until_next_fsm_should_stop.
13889         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13890         (until_next_fsm::do_async_reply_reason): Rename from
13891         until_next_fsm_async_reply_reason.
13892         (struct finish_command_fsm): Inherit from thread_fsm.  Add
13893         constructor.  Change type of breakpoint.
13894         (finish_command_fsm_ops): Remove.
13895         (new_finish_command_fsm): Remove.
13896         (finish_command_fsm::should_stop): Rename from
13897         finish_command_fsm_should_stop.
13898         (finish_command_fsm::clean_up): Rename from
13899         finish_command_fsm_clean_up.
13900         (finish_command_fsm::return_value): Rename from
13901         finish_command_fsm_return_value.
13902         (finish_command_fsm::do_async_reply_reason): Rename from
13903         finish_command_fsm_async_reply_reason.
13904         (finish_command): Update.
13905         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13906         Add constructor.
13907         (call_thread_fsm_ops): Remove.
13908         (call_thread_fsm::call_thread_fsm): Rename from
13909         new_call_thread_fsm.
13910         (call_thread_fsm::should_stop): Rename from
13911         call_thread_fsm_should_stop.
13912         (call_thread_fsm::should_notify_stop): Rename from
13913         call_thread_fsm_should_notify_stop.
13914         (run_inferior_call, call_function_by_hand_dummy): Update.
13915         * cli/cli-interp.c (should_print_stop_to_console): Update.
13916         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13917         Add constructor.  Change type of location_breakpoint,
13918         caller_breakpoint.
13919         (until_break_fsm_ops): Remove.
13920         (new_until_break_fsm): Remove.
13921         (until_break_fsm::should_stop): Rename from
13922         until_break_fsm_should_stop.
13923         (until_break_fsm::clean_up): Rename from
13924         until_break_fsm_clean_up.
13925         (until_break_fsm::do_async_reply_reason): Rename from
13926         until_break_fsm_async_reply_reason.
13927         (until_break_command): Update.
13928         * thread-fsm.c: Remove.
13929         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13930
13931 2019-02-07  Tom Tromey  <tom@tromey.com>
13932
13933         * yy-remap.h: Add include guard.
13934         * xtensa-tdep.h: Add include guard.
13935         * xcoffread.h: Rename include guard.
13936         * varobj-iter.h: Add include guard.
13937         * tui/tui.h: Rename include guard.
13938         * tui/tui-winsource.h: Rename include guard.
13939         * tui/tui-wingeneral.h: Rename include guard.
13940         * tui/tui-windata.h: Rename include guard.
13941         * tui/tui-win.h: Rename include guard.
13942         * tui/tui-stack.h: Rename include guard.
13943         * tui/tui-source.h: Rename include guard.
13944         * tui/tui-regs.h: Rename include guard.
13945         * tui/tui-out.h: Rename include guard.
13946         * tui/tui-layout.h: Rename include guard.
13947         * tui/tui-io.h: Rename include guard.
13948         * tui/tui-hooks.h: Rename include guard.
13949         * tui/tui-file.h: Rename include guard.
13950         * tui/tui-disasm.h: Rename include guard.
13951         * tui/tui-data.h: Rename include guard.
13952         * tui/tui-command.h: Rename include guard.
13953         * tic6x-tdep.h: Add include guard.
13954         * target/waitstatus.h: Rename include guard.
13955         * target/wait.h: Rename include guard.
13956         * target/target.h: Rename include guard.
13957         * target/resume.h: Rename include guard.
13958         * target-float.h: Rename include guard.
13959         * stabsread.h: Add include guard.
13960         * rs6000-tdep.h: Add include guard.
13961         * riscv-fbsd-tdep.h: Add include guard.
13962         * regformats/regdef.h: Rename include guard.
13963         * record.h: Rename include guard.
13964         * python/python.h: Rename include guard.
13965         * python/python-internal.h: Rename include guard.
13966         * python/py-stopevent.h: Rename include guard.
13967         * python/py-ref.h: Rename include guard.
13968         * python/py-record.h: Rename include guard.
13969         * python/py-record-full.h: Rename include guard.
13970         * python/py-record-btrace.h: Rename include guard.
13971         * python/py-instruction.h: Rename include guard.
13972         * python/py-events.h: Rename include guard.
13973         * python/py-event.h: Rename include guard.
13974         * procfs.h: Add include guard.
13975         * proc-utils.h: Add include guard.
13976         * p-lang.h: Add include guard.
13977         * or1k-tdep.h: Rename include guard.
13978         * observable.h: Rename include guard.
13979         * nto-tdep.h: Rename include guard.
13980         * nat/x86-linux.h: Rename include guard.
13981         * nat/x86-linux-dregs.h: Rename include guard.
13982         * nat/x86-gcc-cpuid.h: Add include guard.
13983         * nat/x86-dregs.h: Rename include guard.
13984         * nat/x86-cpuid.h: Rename include guard.
13985         * nat/ppc-linux.h: Rename include guard.
13986         * nat/mips-linux-watch.h: Rename include guard.
13987         * nat/linux-waitpid.h: Rename include guard.
13988         * nat/linux-ptrace.h: Rename include guard.
13989         * nat/linux-procfs.h: Rename include guard.
13990         * nat/linux-osdata.h: Rename include guard.
13991         * nat/linux-nat.h: Rename include guard.
13992         * nat/linux-namespaces.h: Rename include guard.
13993         * nat/linux-btrace.h: Rename include guard.
13994         * nat/glibc_thread_db.h: Rename include guard.
13995         * nat/gdb_thread_db.h: Rename include guard.
13996         * nat/gdb_ptrace.h: Rename include guard.
13997         * nat/fork-inferior.h: Rename include guard.
13998         * nat/amd64-linux-siginfo.h: Rename include guard.
13999         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14000         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14001         * nat/aarch64-linux.h: Rename include guard.
14002         * nat/aarch64-linux-hw-point.h: Rename include guard.
14003         * mn10300-tdep.h: Add include guard.
14004         * mips-linux-tdep.h: Add include guard.
14005         * mi/mi-parse.h: Rename include guard.
14006         * mi/mi-out.h: Rename include guard.
14007         * mi/mi-main.h: Rename include guard.
14008         * mi/mi-interp.h: Rename include guard.
14009         * mi/mi-getopt.h: Rename include guard.
14010         * mi/mi-console.h: Rename include guard.
14011         * mi/mi-common.h: Rename include guard.
14012         * mi/mi-cmds.h: Rename include guard.
14013         * mi/mi-cmd-break.h: Rename include guard.
14014         * m2-lang.h: Add include guard.
14015         * location.h: Rename include guard.
14016         * linux-record.h: Rename include guard.
14017         * linux-nat.h: Add include guard.
14018         * linux-fork.h: Add include guard.
14019         * i386-darwin-tdep.h: Rename include guard.
14020         * hppa-linux-offsets.h: Add include guard.
14021         * guile/guile.h: Rename include guard.
14022         * guile/guile-internal.h: Rename include guard.
14023         * gnu-nat.h: Rename include guard.
14024         * gdb-stabs.h: Rename include guard.
14025         * frv-tdep.h: Add include guard.
14026         * f-lang.h: Add include guard.
14027         * event-loop.h: Add include guard.
14028         * darwin-nat.h: Rename include guard.
14029         * cp-abi.h: Rename include guard.
14030         * config/sparc/nm-sol2.h: Rename include guard.
14031         * config/nm-nto.h: Rename include guard.
14032         * config/nm-linux.h: Add include guard.
14033         * config/i386/nm-i386gnu.h: Rename include guard.
14034         * config/djgpp/nl_types.h: Rename include guard.
14035         * config/djgpp/langinfo.h: Rename include guard.
14036         * compile/gcc-cp-plugin.h: Add include guard.
14037         * compile/gcc-c-plugin.h: Add include guard.
14038         * compile/compile.h: Rename include guard.
14039         * compile/compile-object-run.h: Rename include guard.
14040         * compile/compile-object-load.h: Rename include guard.
14041         * compile/compile-internal.h: Rename include guard.
14042         * compile/compile-cplus.h: Rename include guard.
14043         * compile/compile-c.h: Rename include guard.
14044         * common/xml-utils.h: Rename include guard.
14045         * common/x86-xstate.h: Rename include guard.
14046         * common/version.h: Rename include guard.
14047         * common/vec.h: Rename include guard.
14048         * common/tdesc.h: Rename include guard.
14049         * common/selftest.h: Rename include guard.
14050         * common/scoped_restore.h: Rename include guard.
14051         * common/scoped_mmap.h: Rename include guard.
14052         * common/scoped_fd.h: Rename include guard.
14053         * common/safe-iterator.h: Rename include guard.
14054         * common/run-time-clock.h: Rename include guard.
14055         * common/refcounted-object.h: Rename include guard.
14056         * common/queue.h: Rename include guard.
14057         * common/ptid.h: Rename include guard.
14058         * common/print-utils.h: Rename include guard.
14059         * common/preprocessor.h: Rename include guard.
14060         * common/pathstuff.h: Rename include guard.
14061         * common/observable.h: Rename include guard.
14062         * common/netstuff.h: Rename include guard.
14063         * common/job-control.h: Rename include guard.
14064         * common/host-defs.h: Rename include guard.
14065         * common/gdb_wait.h: Rename include guard.
14066         * common/gdb_vecs.h: Rename include guard.
14067         * common/gdb_unlinker.h: Rename include guard.
14068         * common/gdb_unique_ptr.h: Rename include guard.
14069         * common/gdb_tilde_expand.h: Rename include guard.
14070         * common/gdb_sys_time.h: Rename include guard.
14071         * common/gdb_string_view.h: Rename include guard.
14072         * common/gdb_splay_tree.h: Rename include guard.
14073         * common/gdb_setjmp.h: Rename include guard.
14074         * common/gdb_ref_ptr.h: Rename include guard.
14075         * common/gdb_optional.h: Rename include guard.
14076         * common/gdb_locale.h: Rename include guard.
14077         * common/gdb_assert.h: Rename include guard.
14078         * common/filtered-iterator.h: Rename include guard.
14079         * common/filestuff.h: Rename include guard.
14080         * common/fileio.h: Rename include guard.
14081         * common/environ.h: Rename include guard.
14082         * common/common-utils.h: Rename include guard.
14083         * common/common-types.h: Rename include guard.
14084         * common/common-regcache.h: Rename include guard.
14085         * common/common-inferior.h: Rename include guard.
14086         * common/common-gdbthread.h: Rename include guard.
14087         * common/common-exceptions.h: Rename include guard.
14088         * common/common-defs.h: Rename include guard.
14089         * common/common-debug.h: Rename include guard.
14090         * common/cleanups.h: Rename include guard.
14091         * common/buffer.h: Rename include guard.
14092         * common/btrace-common.h: Rename include guard.
14093         * common/break-common.h: Rename include guard.
14094         * cli/cli-utils.h: Rename include guard.
14095         * cli/cli-style.h: Rename include guard.
14096         * cli/cli-setshow.h: Rename include guard.
14097         * cli/cli-script.h: Rename include guard.
14098         * cli/cli-interp.h: Rename include guard.
14099         * cli/cli-decode.h: Rename include guard.
14100         * cli/cli-cmds.h: Rename include guard.
14101         * charset-list.h: Add include guard.
14102         * buildsym-legacy.h: Rename include guard.
14103         * bfin-tdep.h: Add include guard.
14104         * ax.h: Rename include guard.
14105         * arm-linux-tdep.h: Add include guard.
14106         * arm-fbsd-tdep.h: Add include guard.
14107         * arch/xtensa.h: Rename include guard.
14108         * arch/tic6x.h: Add include guard.
14109         * arch/i386.h: Add include guard.
14110         * arch/arm.h: Rename include guard.
14111         * arch/arm-linux.h: Rename include guard.
14112         * arch/arm-get-next-pcs.h: Rename include guard.
14113         * arch/amd64.h: Add include guard.
14114         * arch/aarch64-insn.h: Rename include guard.
14115         * arch-utils.h: Rename include guard.
14116         * annotate.h: Add include guard.
14117         * amd64-darwin-tdep.h: Rename include guard.
14118         * aarch64-linux-tdep.h: Add include guard.
14119         * aarch64-fbsd-tdep.h: Add include guard.
14120         * aarch32-linux-nat.h: Add include guard.
14121
14122 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14123
14124         * macrotab.c (macro_define_internal): New function that
14125         factorizes macro_define_object_internal and macro_define_function
14126         code.
14127         (macro_define_object_internal): Use macro_define_internal.
14128         (macro_define_function): Likewise.
14129
14130 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14131
14132         * macrocmd.c (extract_identifier): Return
14133         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14134         callers.
14135
14136 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14137
14138         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14139
14140 2019-02-05  Tom Tromey  <tom@tromey.com>
14141
14142         * target.c (target_stack::unpush): Move assertion earlier.
14143
14144 2019-01-30  Tom Tromey  <tom@tromey.com>
14145
14146         PR python/23615:
14147         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14148         (gdbpy_parse_and_eval): Likewise.
14149         * python/python-internal.h (gdbpy_allow_threads): New class.
14150
14151 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14152
14153         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14154         (aarch64_fbsd_fpregmap): Move earlier.
14155         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14156         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14157         instead of individual calls to trad_frame_set_reg_addr.
14158         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14159         earlier.
14160         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14161         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14162         instead of individual calls to trad_frame_set_reg_addr.
14163
14164 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14165
14166         * CONTRIBUTE: Replace contribution list with wiki link.
14167
14168 2019-01-25  Tom Tromey  <tom@tromey.com>
14169
14170         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14171
14172 2019-01-25  Tom Tromey  <tom@tromey.com>
14173
14174         * xtensa-linux-nat.c: Fix common/ includes.
14175         * xml-support.h: Fix common/ includes.
14176         * xml-support.c: Fix common/ includes.
14177         * x86-linux-nat.c: Fix common/ includes.
14178         * windows-nat.c: Fix common/ includes.
14179         * varobj.h: Fix common/ includes.
14180         * varobj.c: Fix common/ includes.
14181         * value.c: Fix common/ includes.
14182         * valops.c: Fix common/ includes.
14183         * utils.c: Fix common/ includes.
14184         * unittests/xml-utils-selftests.c: Fix common/ includes.
14185         * unittests/utils-selftests.c: Fix common/ includes.
14186         * unittests/unpack-selftests.c: Fix common/ includes.
14187         * unittests/tracepoint-selftests.c: Fix common/ includes.
14188         * unittests/style-selftests.c: Fix common/ includes.
14189         * unittests/string_view-selftests.c: Fix common/ includes.
14190         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14191         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14192         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14193         * unittests/rsp-low-selftests.c: Fix common/ includes.
14194         * unittests/parse-connection-spec-selftests.c: Fix common/
14195         includes.
14196         * unittests/optional-selftests.c: Fix common/ includes.
14197         * unittests/offset-type-selftests.c: Fix common/ includes.
14198         * unittests/observable-selftests.c: Fix common/ includes.
14199         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14200         * unittests/memrange-selftests.c: Fix common/ includes.
14201         * unittests/memory-map-selftests.c: Fix common/ includes.
14202         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14203         * unittests/function-view-selftests.c: Fix common/ includes.
14204         * unittests/environ-selftests.c: Fix common/ includes.
14205         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14206         * unittests/common-utils-selftests.c: Fix common/ includes.
14207         * unittests/cli-utils-selftests.c: Fix common/ includes.
14208         * unittests/array-view-selftests.c: Fix common/ includes.
14209         * ui-file.c: Fix common/ includes.
14210         * tui/tui-io.c: Fix common/ includes.
14211         * tracepoint.h: Fix common/ includes.
14212         * tracepoint.c: Fix common/ includes.
14213         * tracefile-tfile.c: Fix common/ includes.
14214         * top.h: Fix common/ includes.
14215         * top.c: Fix common/ includes.
14216         * thread.c: Fix common/ includes.
14217         * target/waitstatus.h: Fix common/ includes.
14218         * target/waitstatus.c: Fix common/ includes.
14219         * target.h: Fix common/ includes.
14220         * target.c: Fix common/ includes.
14221         * target-memory.c: Fix common/ includes.
14222         * target-descriptions.c: Fix common/ includes.
14223         * symtab.h: Fix common/ includes.
14224         * symfile.c: Fix common/ includes.
14225         * stap-probe.c: Fix common/ includes.
14226         * spu-linux-nat.c: Fix common/ includes.
14227         * sparc-nat.c: Fix common/ includes.
14228         * source.c: Fix common/ includes.
14229         * solib.c: Fix common/ includes.
14230         * solib-target.c: Fix common/ includes.
14231         * ser-unix.c: Fix common/ includes.
14232         * ser-tcp.c: Fix common/ includes.
14233         * ser-pipe.c: Fix common/ includes.
14234         * ser-base.c: Fix common/ includes.
14235         * selftest-arch.c: Fix common/ includes.
14236         * s12z-tdep.c: Fix common/ includes.
14237         * rust-exp.y: Fix common/ includes.
14238         * rs6000-aix-tdep.c: Fix common/ includes.
14239         * riscv-tdep.c: Fix common/ includes.
14240         * remote.c: Fix common/ includes.
14241         * remote-notif.h: Fix common/ includes.
14242         * remote-fileio.h: Fix common/ includes.
14243         * remote-fileio.c: Fix common/ includes.
14244         * regcache.h: Fix common/ includes.
14245         * regcache.c: Fix common/ includes.
14246         * record-btrace.c: Fix common/ includes.
14247         * python/python.c: Fix common/ includes.
14248         * python/py-type.c: Fix common/ includes.
14249         * python/py-inferior.c: Fix common/ includes.
14250         * progspace.h: Fix common/ includes.
14251         * producer.c: Fix common/ includes.
14252         * procfs.c: Fix common/ includes.
14253         * proc-api.c: Fix common/ includes.
14254         * printcmd.c: Fix common/ includes.
14255         * ppc-linux-nat.c: Fix common/ includes.
14256         * parser-defs.h: Fix common/ includes.
14257         * osdata.c: Fix common/ includes.
14258         * obsd-nat.c: Fix common/ includes.
14259         * nat/x86-linux.c: Fix common/ includes.
14260         * nat/x86-linux-dregs.c: Fix common/ includes.
14261         * nat/x86-dregs.h: Fix common/ includes.
14262         * nat/x86-dregs.c: Fix common/ includes.
14263         * nat/ppc-linux.c: Fix common/ includes.
14264         * nat/mips-linux-watch.h: Fix common/ includes.
14265         * nat/mips-linux-watch.c: Fix common/ includes.
14266         * nat/linux-waitpid.c: Fix common/ includes.
14267         * nat/linux-ptrace.h: Fix common/ includes.
14268         * nat/linux-ptrace.c: Fix common/ includes.
14269         * nat/linux-procfs.c: Fix common/ includes.
14270         * nat/linux-personality.c: Fix common/ includes.
14271         * nat/linux-osdata.c: Fix common/ includes.
14272         * nat/linux-namespaces.c: Fix common/ includes.
14273         * nat/linux-btrace.h: Fix common/ includes.
14274         * nat/linux-btrace.c: Fix common/ includes.
14275         * nat/fork-inferior.c: Fix common/ includes.
14276         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14277         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14278         * nat/aarch64-linux.c: Fix common/ includes.
14279         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14280         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14281         * namespace.h: Fix common/ includes.
14282         * mips-linux-tdep.c: Fix common/ includes.
14283         * minsyms.c: Fix common/ includes.
14284         * mi/mi-parse.h: Fix common/ includes.
14285         * mi/mi-main.c: Fix common/ includes.
14286         * mi/mi-cmd-env.c: Fix common/ includes.
14287         * memrange.h: Fix common/ includes.
14288         * memattr.c: Fix common/ includes.
14289         * maint.h: Fix common/ includes.
14290         * maint.c: Fix common/ includes.
14291         * main.c: Fix common/ includes.
14292         * machoread.c: Fix common/ includes.
14293         * location.c: Fix common/ includes.
14294         * linux-thread-db.c: Fix common/ includes.
14295         * linux-nat.c: Fix common/ includes.
14296         * linux-fork.c: Fix common/ includes.
14297         * inline-frame.c: Fix common/ includes.
14298         * infrun.c: Fix common/ includes.
14299         * inflow.c: Fix common/ includes.
14300         * inferior.h: Fix common/ includes.
14301         * inferior.c: Fix common/ includes.
14302         * infcmd.c: Fix common/ includes.
14303         * inf-ptrace.c: Fix common/ includes.
14304         * inf-child.c: Fix common/ includes.
14305         * ia64-linux-nat.c: Fix common/ includes.
14306         * i387-tdep.c: Fix common/ includes.
14307         * i386-tdep.c: Fix common/ includes.
14308         * i386-linux-tdep.c: Fix common/ includes.
14309         * i386-linux-nat.c: Fix common/ includes.
14310         * i386-go32-tdep.c: Fix common/ includes.
14311         * i386-fbsd-tdep.c: Fix common/ includes.
14312         * i386-fbsd-nat.c: Fix common/ includes.
14313         * guile/scm-type.c: Fix common/ includes.
14314         * guile/guile.c: Fix common/ includes.
14315         * go32-nat.c: Fix common/ includes.
14316         * gnu-nat.c: Fix common/ includes.
14317         * gdbthread.h: Fix common/ includes.
14318         * gdbarch-selftests.c: Fix common/ includes.
14319         * gdb_usleep.c: Fix common/ includes.
14320         * gdb_select.h: Fix common/ includes.
14321         * gdb_bfd.c: Fix common/ includes.
14322         * gcore.c: Fix common/ includes.
14323         * fork-child.c: Fix common/ includes.
14324         * findvar.c: Fix common/ includes.
14325         * fbsd-nat.c: Fix common/ includes.
14326         * event-top.c: Fix common/ includes.
14327         * event-loop.c: Fix common/ includes.
14328         * dwarf2read.c: Fix common/ includes.
14329         * dwarf2loc.c: Fix common/ includes.
14330         * dwarf2-frame.c: Fix common/ includes.
14331         * dwarf-index-cache.c: Fix common/ includes.
14332         * dtrace-probe.c: Fix common/ includes.
14333         * disasm-selftests.c: Fix common/ includes.
14334         * defs.h: Fix common/ includes.
14335         * csky-tdep.c: Fix common/ includes.
14336         * cp-valprint.c: Fix common/ includes.
14337         * cp-support.h: Fix common/ includes.
14338         * cp-support.c: Fix common/ includes.
14339         * corelow.c: Fix common/ includes.
14340         * completer.h: Fix common/ includes.
14341         * completer.c: Fix common/ includes.
14342         * compile/compile.c: Fix common/ includes.
14343         * compile/compile-loc2c.c: Fix common/ includes.
14344         * compile/compile-cplus-types.c: Fix common/ includes.
14345         * compile/compile-cplus-symbols.c: Fix common/ includes.
14346         * command.h: Fix common/ includes.
14347         * cli/cli-dump.c: Fix common/ includes.
14348         * cli/cli-cmds.c: Fix common/ includes.
14349         * charset.c: Fix common/ includes.
14350         * build-id.c: Fix common/ includes.
14351         * btrace.h: Fix common/ includes.
14352         * btrace.c: Fix common/ includes.
14353         * breakpoint.h: Fix common/ includes.
14354         * breakpoint.c: Fix common/ includes.
14355         * ax.h:
14356         (enum agent_op): Fix common/ includes.
14357         * ax-general.c (struct aop_map): Fix common/ includes.
14358         * ax-gdb.c: Fix common/ includes.
14359         * auxv.c: Fix common/ includes.
14360         * auto-load.c: Fix common/ includes.
14361         * arm-tdep.c: Fix common/ includes.
14362         * arch/riscv.c: Fix common/ includes.
14363         * arch/ppc-linux-common.c: Fix common/ includes.
14364         * arch/i386.c: Fix common/ includes.
14365         * arch/arm.c: Fix common/ includes.
14366         * arch/arm-linux.c: Fix common/ includes.
14367         * arch/arm-get-next-pcs.c: Fix common/ includes.
14368         * arch/amd64.c: Fix common/ includes.
14369         * arch/aarch64.c: Fix common/ includes.
14370         * arch/aarch64-insn.c: Fix common/ includes.
14371         * arch-utils.c: Fix common/ includes.
14372         * amd64-windows-tdep.c: Fix common/ includes.
14373         * amd64-tdep.c: Fix common/ includes.
14374         * amd64-sol2-tdep.c: Fix common/ includes.
14375         * amd64-obsd-tdep.c: Fix common/ includes.
14376         * amd64-nbsd-tdep.c: Fix common/ includes.
14377         * amd64-linux-tdep.c: Fix common/ includes.
14378         * amd64-linux-nat.c: Fix common/ includes.
14379         * amd64-fbsd-tdep.c: Fix common/ includes.
14380         * amd64-fbsd-nat.c: Fix common/ includes.
14381         * amd64-dicos-tdep.c: Fix common/ includes.
14382         * amd64-darwin-tdep.c: Fix common/ includes.
14383         * agent.c: Fix common/ includes.
14384         * ada-lang.h: Fix common/ includes.
14385         * ada-lang.c: Fix common/ includes.
14386         * aarch64-tdep.c: Fix common/ includes.
14387
14388 2019-01-25  Tom Tromey  <tom@tromey.com>
14389
14390         * common/create-version.sh: Use common/version.h.
14391
14392 2019-01-24  Pedro Alves  <palves@redhat.com>
14393
14394         * infrun.c (signal_stop, signal_print, signal_program)
14395         (signal_catch, signal_pass): Now arrays instead of pointers.
14396         (update_signals_program_target, do_target_resume)
14397         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14398         * linux-nat.c (linux_nat_target::pass_signals)
14399         (linux_nat_target::create_inferior, linux_nat_target::attach):
14400         Adjust.
14401         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14402         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14403         * procfs.c (procfs_target::pass_signals): Adjust.
14404         * record-full.c (record_full_target::resume): Adjust.
14405         * remote.c (remote_target::pass_signals)
14406         (remote_target::program_signals): Adjust.
14407         * target-debug.h (target_debug_print_signals): Now takes a
14408         gdb::array_view as parameter.  Adjust.
14409         * target.h (target_ops) <pass_signals, program_signals>: Replace
14410         pointer and length parameters with gdb::array_view.
14411         (target_pass_signals, target_program_signals): Likewise.
14412         * target-delegates.c: Regenerate.
14413
14414 2019-01-24  Pedro Alves  <palves@redhat.com>
14415
14416         * common/forward-scope-exit.h
14417         (forward_scope_exit::forward_scope_exit): Pass arguments to
14418         m_bind_function directly, instead of creating a std::bind and
14419         copying that.
14420
14421 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14422
14423         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14424         for static members.
14425         (pass_in_v_vfp_candidate): Likewise.
14426
14427 2019-01-23  Tom Tromey  <tom@tromey.com>
14428             Pedro Alves  <palves@redhat.com>
14429
14430         * regcache.c (class regcache_invalidator): Remove.
14431         (regcache::raw_write): Use make_scope_exit.
14432
14433 2019-01-23  Tom Tromey  <tom@tromey.com>
14434
14435         * ui-out.h (class ui_out_emit_type): Update comment.
14436
14437 2019-01-23  Tom Tromey  <tom@tromey.com>
14438
14439         * infrun.c (fetch_inferior_event): Update comment.
14440
14441 2019-01-23  Tom Tromey  <tom@tromey.com>
14442             Pedro Alves  <palves@redhat.com>
14443
14444         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14445         parameter.
14446         (fetch_inferior_event): Use SCOPE_EXIT.
14447
14448
14449 2019-01-23  Tom Tromey  <tom@tromey.com>
14450             Pedro Alves  <palves@redhat.com>
14451
14452         * infrun.c (disable_thread_events): Delete.
14453         (stop_all_threads): Use SCOPE_EXIT.
14454
14455 2019-01-23  Tom Tromey  <tom@tromey.com>
14456             Pedro Alves  <palves@redhat.com>
14457
14458         * symfile.c: Include forward-scope-exit.h.
14459         (clear_symtab_users_cleanup): Replace forward declaration with
14460         a FORWARD_SCOPE_EXIT.
14461         (syms_from_objfile_1): Use the forward_scope_exit and
14462         gdb::optional instead of cleanup_function.
14463         (reread_symbols): Use the forward_scope_exit instead of
14464         cleanup_function.
14465         (clear_symtab_users_cleanup): Remove function.
14466
14467 2019-01-23  Tom Tromey  <tom@tromey.com>
14468             Pedro Alves  <palves@redhat.com>
14469
14470         * linux-nat.c: Include scope-exit.h.
14471         (cleanup_target_stop): Remove.
14472         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14473         SCOPE_EXIT.
14474
14475 2019-01-23  Tom Tromey  <tom@tromey.com>
14476             Pedro Alves  <palves@redhat.com>
14477
14478         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14479         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14480
14481 2019-01-23  Tom Tromey  <tom@tromey.com>
14482             Andrew Burgess  <andrew.burgess@embecosm.com>
14483             Pedro Alves  <palves@redhat.com>
14484
14485         * infrun.c (fetch_inferior_event): Use scope_exit.
14486         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14487         * top.c (execute_command): Use scope_exit.
14488         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14489         * utils.c (do_bpstat_clear_actions_cleanup)
14490         (make_bpstat_clear_actions_cleanup): Remove.
14491
14492 2019-01-23  Tom Tromey  <tom@tromey.com>
14493             Pedro Alves  <palves@redhat.com>
14494
14495         * infrun.c: Include "common/scope-exit.h"
14496         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14497         (wait_for_inferior): Use SCOPE_EXIT.
14498         (fetch_inferior_event): Use scope_exit.
14499
14500 2019-01-23  Tom Tromey  <tom@tromey.com>
14501             Pedro Alves  <palves@redhat.com>
14502
14503         * breakpoint.c (create_breakpoint): Remove cleanup.
14504
14505 2019-01-23  Tom Tromey  <tom@tromey.com>
14506             Andrew Burgess  <andrew.burgess@embecosm.com>
14507             Pedro Alves  <palves@redhat.com>
14508
14509 2019-01-23  Pedro Alves  <palves@redhat.com>
14510
14511         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14512
14513 2019-01-23  Pedro Alves  <palves@redhat.com>
14514             Andrew Burgess  <andrew.burgess@embecosm.com>
14515
14516         * gdbthread.h: Include "common/forward-scope-exit.h".
14517         (scoped_finish_thread_state): Redefine custom class in terms of
14518         forward_scope_exit.
14519
14520 2019-01-23  Pedro Alves  <palves@redhat.com>
14521             Andrew Burgess  <andrew.burgess@embecosm.com>
14522
14523         * common/forward-scope-exit.h: New file.
14524
14525 2019-01-23  Pedro Alves  <palves@redhat.com>
14526             Andrew Burgess  <andrew.burgess@embecosm.com>
14527             Tom Tromey  <tom@tromey.com>
14528
14529         * common/scope-exit.h: New file.
14530
14531 2019-01-23  Pedro Alves  <palves@redhat.com>
14532
14533         * common/preprocessor.h (ESC): Rename to ...
14534         (ESC_PARENS): ... this.
14535         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14536         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14537
14538 2019-01-23  Tom Tromey  <tom@tromey.com>
14539
14540         * language.h (class scoped_switch_to_sym_language_if_auto):
14541         Initialize m_lang in both cases.
14542
14543 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14544
14545         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14546         with XCNEW.
14547
14548 2019-01-22  Tom Tromey  <tom@tromey.com>
14549
14550         * corelow.c: Do not include sys/file.h.
14551
14552 2019-01-22  Tom Tromey  <tom@tromey.com>
14553
14554         * tui/tui-wingeneral.h: Include gdb_curses.h.
14555
14556 2019-01-22  Tom Tromey  <tom@tromey.com>
14557
14558         * source-cache.h (class source_cache) <get_source_lines,
14559         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14560
14561 2019-01-22  Tom Tromey  <tom@tromey.com>
14562
14563         * remote-fileio.h (struct remote_target): Declare.
14564
14565 2019-01-22  Tom Tromey  <tom@tromey.com>
14566
14567         * python/py-arch.c: Do not include py-ref.h.
14568         * python/py-bpevent.c: Do not include py-ref.h.
14569         * python/py-cmd.c: Do not include py-ref.h.
14570         * python/py-continueevent.c: Do not include py-ref.h.
14571         * python/py-event.h: Do not include py-ref.h.
14572         * python/py-evtregistry.c: Do not include py-ref.h.
14573         * python/py-finishbreakpoint.c: Do not include py-ref.h.
14574         * python/py-frame.c: Do not include py-ref.h.
14575         * python/py-framefilter.c: Do not include py-ref.h.
14576         * python/py-function.c: Do not include py-ref.h.
14577         * python/py-infevents.c: Do not include py-ref.h.
14578         * python/py-linetable.c: Do not include py-ref.h.
14579         * python/py-objfile.c: Do not include py-ref.h.
14580         * python/py-param.c: Do not include py-ref.h.
14581         * python/py-prettyprint.c: Do not include py-ref.h.
14582         * python/py-progspace.c: Do not include py-ref.h.
14583         * python/py-symbol.c: Do not include py-ref.h.
14584         * python/py-symtab.c: Do not include py-ref.h.
14585         * python/py-type.c: Do not include py-ref.h.
14586         * python/py-unwind.c: Do not include py-ref.h.
14587         * python/py-utils.c: Do not include py-ref.h.
14588         * python/py-value.c: Do not include py-ref.h.
14589         * python/py-varobj.c: Do not include py-ref.h.
14590         * python/py-xmethods.c: Do not include py-ref.h.
14591         * python/python.c: Do not include py-ref.h.
14592         * varobj.c: Do not include py-ref.h.
14593
14594 2019-01-22  Tom Tromey  <tom@tromey.com>
14595
14596         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14597         keyword for bcache.
14598
14599 2019-01-22  Tom Tromey  <tom@tromey.com>
14600
14601         * compile/compile-cplus-types.c: Remove a comment by #include.
14602
14603 2019-01-22  Tom Tromey  <tom@tromey.com>
14604
14605         * compile/gcc-c-plugin.h: Include compile-internal.h.
14606
14607 2019-01-22  Tom Tromey  <tom@tromey.com>
14608
14609         * stabsread.c (EXTERN): Do not define.
14610         (symnum, next_symbol_text_func, processing_gcc_compilation)
14611         (within_function, global_sym_chain, global_stabs)
14612         (previous_stab_code, this_object_header_files)
14613         (n_this_object_header_files)
14614         (n_allocated_this_object_header_files): Define.
14615         * stabsread.h (EXTERN): Never define.  Use "extern".
14616
14617 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14618
14619         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14620         history_value.
14621
14622 2019-01-21  Tom Tromey  <tom@tromey.com>
14623
14624         * ui-out.c: Fix includes.
14625         * tui/tui-source.c: Fix includes.
14626         * target.c: Fix includes.
14627         * remote.c: Fix includes.
14628         * regcache.c: Fix includes.
14629         * python/py-block.c: Fix includes.
14630         * printcmd.c: Fix includes.
14631         * or1k-tdep.c: Fix includes.
14632         * mi/mi-main.c: Fix includes.
14633         * m32r-tdep.c: Fix includes.
14634         * csky-tdep.c: Fix includes.
14635         * compile/compile-cplus-types.c: Fix includes.
14636         * cli/cli-interp.c: Fix includes.
14637
14638 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
14639
14640         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14641         for padding.
14642
14643 2019-01-16  Tom Tromey  <tom@tromey.com>
14644
14645         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
14646         earlier.
14647         (struct objfile) <msymbols_range>: Move from top level.
14648         <msymbols>: New method.
14649         (class objfile_msymbols): Remove.
14650         * symtab.c (default_collect_symbol_completion_matches_break_on):
14651         Update.
14652         * symmisc.c (dump_msymbols): Update.
14653         * stabsread.c (scan_file_globals): Update.
14654         * objc-lang.c (info_selectors_command, info_classes_command)
14655         (find_methods): Update.
14656         * minsyms.c (find_solib_trampoline_target): Update.
14657         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14658         * coffread.c (coff_symfile_read): Update.
14659         * ada-lang.c (ada_lookup_simple_minsym)
14660         (ada_collect_symbol_completion_matches): Update.
14661
14662 2019-01-16  Tom Tromey  <tom@tromey.com>
14663
14664         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14665         type.  Remove no-argument constructor.
14666         <iterator::operator++>: Simplify.
14667         <begin>: Update.
14668         <end>: Use minimal_symbol_count.
14669
14670 2019-01-16  Tom Tromey  <tom@tromey.com>
14671
14672         * objfiles.h (struct objfile) <psymtabs>: New method.
14673         (class objfile_psymtabs): Remove.
14674         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14675         typedef.
14676         <range>: New method.
14677         (require_partial_symbols): Change return type.
14678         * psymtab.c (require_partial_symbols)
14679         (psym_expand_symtabs_matching): Update.
14680         * mdebugread.c (parse_partial_symbols): Update.
14681         * dbxread.c (dbx_end_psymtab): Update.
14682
14683 2019-01-15  Tom Tromey  <tom@tromey.com>
14684
14685         * symtab.c (lookup_objfile_from_block)
14686         (lookup_symbol_in_objfile_symtabs)
14687         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14688         (find_line_symtab, info_sources_command)
14689         (default_collect_symbol_completion_matches_break_on)
14690         (make_source_files_completion_list): Update.
14691         * symmisc.c (print_objfile_statistics, dump_objfile)
14692         (maintenance_print_symbols, maintenance_info_symtabs)
14693         (maintenance_check_symtabs, maintenance_info_line_tables):
14694         Update.
14695         * source.c (select_source_symtab)
14696         (forget_cached_source_info_for_objfile): Update.
14697         * objfiles.h (class objfile_compunits): Remove.
14698         (struct objfile) <compunits_range>: New typedef.
14699         (compunits): New method.
14700         * objfiles.c (objfile_relocate1): Update.
14701         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14702         * maint.c (count_symtabs_and_blocks): Update.
14703         * linespec.c (iterate_over_all_matching_symtabs): Update.
14704         * cp-support.c (add_symbol_overload_list_qualified): Update.
14705         * coffread.c (coff_symtab_read): Update.
14706         * ada-lang.c (add_nonlocal_symbols)
14707         (ada_collect_symbol_completion_matches)
14708         (ada_add_global_exceptions): Update.
14709
14710 2019-01-15  Tom Tromey  <tom@tromey.com>
14711
14712         * progspace.h (program_space) <objfiles_safe_range>: New
14713         typedef.
14714         <objfiles_safe>: New method.
14715         * objfiles.h (class all_objfiles_safe): Remove.
14716         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14717         * jit.c (jit_inferior_exit_hook): Update.
14718
14719 2019-01-17  Tom Tromey  <tom@tromey.com>
14720
14721         * progspace.h (program_space) <objfiles_range>: New typedef.
14722         <objfiles>: New method.
14723         <objfiles_head>: Rename from objfiles.
14724         (object_files): Update.
14725         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14726         * guile/scm-pretty-print.c
14727         (ppscm_find_pretty_printer_from_objfiles): Update.
14728         * guile/scm-objfile.c (gdbscm_objfiles): Update.
14729         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14730         Update.
14731         * python/py-progspace.c (pspy_get_objfiles): Update.
14732         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14733         Update.
14734         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14735         (objfpy_lookup_objfile_by_build_id): Update.
14736         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14737         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14738         Update.
14739         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14740         (expand_symtab_containing_pc, lookup_objfile_from_block)
14741         (lookup_static_symbol, basic_lookup_transparent_type)
14742         (find_pc_sect_compunit_symtab, find_symbol_at_address)
14743         (find_line_symtab, info_sources_command)
14744         (default_collect_symbol_completion_matches_break_on)
14745         (make_source_files_completion_list, find_main_name): Update.
14746         * symmisc.c (print_symbol_bcache_statistics)
14747         (print_objfile_statistics, maintenance_print_symbols)
14748         (maintenance_print_msymbols, maintenance_print_objfiles)
14749         (maintenance_info_symtabs, maintenance_check_symtabs)
14750         (maintenance_expand_symtabs, maintenance_info_line_tables):
14751         Update.
14752         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14753         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14754         (map_overlay_command, unmap_overlay_command)
14755         (simple_overlay_update, expand_symtabs_matching)
14756         (map_symbol_filenames): Update.
14757         * symfile-debug.c (set_debug_symfile): Update.
14758         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14759         Update.
14760         * source.c (select_source_symtab, forget_cached_source_info):
14761         Update.
14762         * solib.c (solib_read_symbols): Update.
14763         * solib-spu.c (append_ocl_sos): Update.
14764         * psymtab.c (maintenance_print_psymbols)
14765         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14766         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14767         * printcmd.c (info_symbol_command): Update.
14768         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14769         Update.
14770         * objfiles.h (class all_objfiles): Remove.
14771         * objfiles.c (have_partial_symbols, have_full_symbols)
14772         (have_minimal_symbols, qsort_cmp, update_section_map)
14773         (shared_objfile_contains_address_p)
14774         (default_iterate_over_objfiles_in_search_order): Update.
14775         * objc-lang.c (info_selectors_command, info_classes_command)
14776         (find_methods): Update.
14777         * minsyms.c (find_solib_trampoline_target): Update.
14778         * maint.c (maintenance_info_sections)
14779         (maintenance_translate_address, count_symtabs_and_blocks):
14780         Update.
14781         * main.c (captured_main_1): Update.
14782         * linux-thread-db.c (try_thread_db_load_from_pdir)
14783         (has_libpthread): Update.
14784         * linespec.c (iterate_over_all_matching_symtabs)
14785         (search_minsyms_for_name): Update.
14786         * jit.c (jit_find_objf_with_entry_addr): Update.
14787         * hppa-tdep.c (find_unwind_entry)
14788         (hppa_lookup_stub_minimal_symbol): Update.
14789         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
14790         Update.
14791         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14792         (elf_gnu_ifunc_resolve_by_got): Update.
14793         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
14794         * dwarf-index-write.c (save_gdb_index_command): Update.
14795         * cp-support.c (add_symbol_overload_list_qualified): Update.
14796         * breakpoint.c (create_overlay_event_breakpoint)
14797         (create_longjmp_master_breakpoint)
14798         (create_std_terminate_master_breakpoint)
14799         (create_exception_master_breakpoint): Update.
14800         * blockframe.c (find_pc_partial_function): Update.
14801         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
14802         (ada_collect_symbol_completion_matches)
14803         (ada_add_global_exceptions): Update.
14804
14805 2019-01-17  Tom Tromey  <tom@tromey.com>
14806
14807         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
14808         declare VEC.
14809         (solib_target_parse_libraries): Change return type.
14810         (library_list_start_segment, library_list_start_section)
14811         (library_list_end_library, library_list_start_library); Update.
14812         (solib_target_free_library_list): Remove.
14813         (solib_target_parse_libraries): Remove cleanup.  Change return
14814         type.
14815         (solib_target_current_sos): Update.
14816
14817 2019-01-17  Tom Tromey  <tromey@bapiya>
14818
14819         * valprint.c: Replace "the the" with "the".
14820         * symtab.c: Replace "the the" with "the".
14821         * solib.c: Replace "the the" with "the".
14822         * solib-dsbt.c: Replace "the the" with "the".
14823         * linespec.c: Replace "the the" with "the".
14824         * dwarf2loc.h: Replace "the the" with "the".
14825         * amd64-windows-tdep.c: Replace "the the" with "the".
14826         * aarch64-tdep.c: Replace "the the" with "the".
14827
14828 2019-01-16  Keith Seitz  <keiths@redhat.com>
14829
14830         PR gdb/23773
14831         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14832         <builder>: Rename to ..
14833         <m_builder>: ... this and make private.
14834         (dwarf2_cu::get_builder): New method.  Change all users of
14835         `builder' to use this method.
14836         (dwarf2_start_symtab): Move to ...
14837         (dwarf2_cu::start_symtab): ... here.  Update all callers
14838         (setup_type_unit_groups): Move to ...
14839         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
14840         callers.
14841         (dwarf2_cu::reset_builder): New method.
14842         (process_full_compunit, process_full_type_unit): Use
14843         dwarf2_cu::reset_builder.
14844         (follow_die_offset): Record the ancestor CU if it is different
14845         from the followed DIE's CU.
14846         (follow_die_sig_1): Likewise.
14847
14848 2019-01-15  Tom Tromey  <tom@tromey.com>
14849
14850         * remote.c (class remote_state) <buf>: Now a char_vector.
14851         <buf_size>: Remove.
14852         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
14853         parameter.
14854         (remote_target::getpkt_or_notif_sane_1)
14855         (remote_target::getpkt_sane)
14856         (remote_target::getpkt_or_notif_sane): Likewise.
14857         (class remote_target) <putpkt>: New overload.
14858         (remote_target::read_frame): Change type of "buf_p".  Remove
14859         sizeof_p parameter.
14860         (packet_ok): New overload.
14861         (packet_check_result): New overload.
14862         Update all uses.
14863
14864 2019-01-14  Tom Tromey  <tom@tromey.com>
14865
14866         * remote-notif.c (handle_notification, remote_notif_ack)
14867         (remote_notif_parse): Make "buf" const.
14868         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14869         const.
14870         (remote_notif_parse, remote_notif_ack, handle_notification):
14871         Likewise.
14872         * remote.c (remote_notif_stop_parse): Make "buf" const.
14873         (remote_target::remote_parse_stop_reply): Make "buf" const.
14874         (remote_notif_stop_ack): Make "buf" const.
14875
14876 2019-01-14  Tom Tromey  <tom@tromey.com>
14877
14878         * remote.c (remote_console_output): Make parameter const.
14879
14880 2019-01-14  Tom Tromey  <tom@tromey.com>
14881
14882         * target-debug.h (target_debug_print_signals): Constify.
14883         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14884         * procfs.c (procfs_target::pass_signals): Update.
14885         * linux-nat.c (linux_nat_target::pass_signals): Update.
14886         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14887         * target-delegates.c: Rebuild.
14888         * remote.c (remote_target::program_signals): Update.
14889         (remote_target::pass_signals): Update.
14890         * target.c (target_pass_signals): Constify argument.
14891         (target_program_signals): Likewise.
14892         * target.h (struct target_ops) <pass_signals, program_signals>:
14893         Constify argument.
14894         (target_pass_signals, target_program_signals): Constify argument.
14895
14896 2019-01-14  Tom Tromey  <tom@tromey.com>
14897
14898         PR tui/28819:
14899         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14900
14901 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
14902
14903         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14904         field.
14905         * rs6000-tdep.c: Include reggroups.h.
14906         (IS_V_ALIAS_PSEUDOREG): Define.
14907         (rs6000_register_name): Return names for the "vX" aliases.
14908         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14909         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
14910         aliases.  Call default_register_reggroup_p for all other
14911         pseudo-registers.
14912         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14913         New functions.
14914         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14915         Handle "vX" aliases.
14916         (v_alias_pseudo_register_collect): New function.
14917         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14918         (rs6000_gdbarch_init): Initialize "vX" aliases as
14919         pseudo-registers.  Restore registration of
14920         rs6000_pseudo_register_reggroup_p with
14921         set_tdesc_pseudo_register_reggroup_p.
14922
14923 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
14924
14925         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14926         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14927         set_gdbarch_num_pseudo_regs.
14928
14929 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14930
14931         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14932         Remove arg prefixname, add do_set and do_show.
14933         Add member functions set_list and show_list.
14934         * cli/cli-style.c (class cli_style_option): Update accordingly.
14935         (style_set_list): Move to file scope.
14936         (style_show_list): Likewise.
14937         (set_style): Call help_list.
14938         (show_style): Call cmd_show_list.
14939         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14940         Update to use the new macro.
14941
14942 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
14943
14944         * ada-lang.c (_initialize_ada_language): Expand the help text
14945         for the "catch exception" command.
14946
14947 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14948
14949         * symtab.c (matching_obj_sections): Initialize obj,
14950         declare it closer to its usage.
14951
14952 2019-01-10  Tom Tromey  <tom@tromey.com>
14953
14954         * thread-iter.h (inf_threads_iterator): Use next_iterator.
14955         (basic_inf_threads_range): Remove.
14956         (inf_threads_range, inf_non_exited_threads_range)
14957         (safe_inf_threads_range): Use next_adapter.
14958
14959 2019-01-10  Keith Seitz  <keiths@redhat.com>
14960
14961         PR gdb/23712
14962         PR symtab/23010
14963         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14964         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14965
14966 2019-01-10  Keith Seitz  <keiths@redhat.com>
14967
14968         PR gdb/23712
14969         PR symtab/23010
14970         * dictionary.c (pending_to_vector): Remove.
14971         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14972         Remove _1 suffix, replacing functions of the same name.  Update
14973         all callers.
14974         (dict_create_hashed, dict_create_hashed_expandable)
14975         (dict_create_linear, dict_create_linear_expandable, dict_free)
14976         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14977         Make functions static.
14978
14979 2019-01-10  Keith Seitz  <keiths@redhat.com>
14980
14981         PR gdb/23712
14982         PR symtab/23010
14983         * dictionary.h (struct dictionary): Replace declaration with
14984         multidictionary.
14985         (dict_create_hashed, dict_create_hashed_expandable)
14986         (dict_create_linear, dict_create_linear_expandable)
14987         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14988         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14989         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14990         taking multidictionary argument.
14991         [ALL_DICT_SYMBOLS]: Update for multidictionary.
14992         * block.h (struct block) <dict>: Change to multidictionary
14993         and rename `multidict'.
14994         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14995         symmisc.c: Update all dictionary references to multidictionary.
14996
14997 2019-01-10  Keith Seitz  <keiths@redhat.com>
14998
14999         PR gdb/23712
15000         PR symtab/23010
15001         * dictionary.c: Include unordered_map.
15002         (pending_to_vector): New function.
15003         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15004         Rewrite the non-"_1" functions to take vector instead
15005         of linked list.
15006         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15007         "new" _1 versions of the same name.
15008         (multidictionary): Define.
15009         (std::hash<enum language): New definition.
15010         (collate_pending_symbols_by_language, mdict_create_hashed)
15011         (mdict_create_hashed_expandable, mdict_create_linear)
15012         (mdict_create_linear_expandable, mdict_free)
15013         (find_language_dictionary, create_new_language_dictionary)
15014         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15015         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15016         (mdict_size, mdict_empty): New functions.
15017         * dictionary.h (mdict_iterator): Define.
15018
15019 2019-01-10  Pedro Alves  <palves@redhat.com>
15020
15021         * breakpoint.c (read_uploaded_action)
15022         (create_tracepoint_from_upload): Adjust to use
15023         gdb::unique_xmalloc_ptr.
15024         * ctf.c (ctf_write_uploaded_tp):
15025         (SET_ARRAY_FIELD): Use emplace_back.
15026         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15027         * tracefile-tfile.c (tfile_write_uploaded_tp):
15028         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15029         gdb::unique_xmalloc_ptr.
15030         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15031         at_string, cond_string, cmd_strings>: Replace char pointers
15032         with gdb::unique_xmalloc_ptr.
15033
15034 2019-01-10  Pedro Alves  <palves@redhat.com>
15035
15036         * solib-target.c (library_list_start_library): Don't xstrdup name.
15037
15038 2019-01-10  Pedro Alves  <palves@redhat.com>
15039
15040         * mdebugread.c (parse_partial_symbols): Use
15041         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15042
15043 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15044
15045         * linux-fork.c (scoped_switch_fork_info)
15046         <~scoped_switch_fork_info>: Fix incorrect variable name.
15047
15048 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15049
15050         * linux-fork.c (scoped_switch_fork_info)
15051         <scoped_switch_fork_info>: Make explicit.
15052         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15053
15054 2019-01-10  Tom Tromey  <tom@tromey.com>
15055
15056         * objfiles.h (objfile::reset_psymtabs): Update.
15057         * objfiles.c (objfile::objfile): Update.
15058         * psymtab.h (psymtab_storage::obstack): Update.
15059         (psymtab_storage::m_obstack): Use gdb::optional.
15060         (class psymtab_storage): Update comment.  Remove objfile
15061         parameter.
15062         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15063
15064 2019-01-10  Tom Tromey  <tom@tromey.com>
15065
15066         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15067         <free_psymtabs>: Now private.
15068         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15069         (allocate_psymtab): Use new method.
15070
15071 2019-01-10  Tom Tromey  <tom@tromey.com>
15072
15073         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15074         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15075         * mdebugread.c (parse_partial_symbols): Use
15076         allocate_dependencies.
15077         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15078         allocate_dependencies.
15079         (process_psymtab_comp_unit_reader)
15080         (build_type_psymtab_dependencies): Likewise.
15081         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15082
15083 2019-01-10  Tom Tromey  <tom@tromey.com>
15084
15085         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15086         PSYMBOL_SET_LANGUAGE.
15087         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15088
15089 2019-01-10  Tom Tromey  <tom@tromey.com>
15090
15091         * psymtab.h (psymtab_storage::obstack): New method.
15092         <m_obstack>: Rename from obstack; now private.
15093         * psymtab.c (psymtab_storage): Update.
15094         * dwarf2read.c (create_addrmap_from_index)
15095         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15096         Update.
15097
15098 2019-01-10  Tom Tromey  <tom@tromey.com>
15099
15100         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15101         * objfiles.h (objfile::reset_psymtabs): New method.
15102
15103 2019-01-10  Tom Tromey  <tom@tromey.com>
15104
15105         * symmisc.c (print_symbol_bcache_statistics): Update.
15106         (print_objfile_statistics): Update.
15107         * symfile.c (reread_symbols): Update.
15108         * psymtab.h (class psymtab_storage): New.
15109         * psymtab.c (psymtab_storage): New constructor.
15110         (~psymtab_storage): New destructor.
15111         (require_partial_symbols): Update.
15112         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15113         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15114         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15115         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15116         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15117         (start_psymtab_common, end_psymtab_common)
15118         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15119         (allocate_psymtab): Update.
15120         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15121         Update.
15122         (dump_psymtab_addrmap, maintenance_print_psymbols)
15123         (maintenance_check_psymtabs): Update.
15124         (class objfile_psymtabs): Move to objfiles.h.
15125         * psympriv.h (discard_psymtab): Now inline.
15126         (psymtab_discarder::psymtab_discarder): Update.
15127         (psymtab_discarder::~psymtab_discarder): Update.
15128         (ALL_OBJFILE_PSYMTABS): Rewrite.
15129         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15130         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15131         Remove fields.
15132         <partial_symtabs>: New field.
15133         (class objfile_psymtabs): Move from psymtab.h.  Update.
15134         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15135         psymbol_cache.
15136         (objfile::~objfile): Don't destroy psymbol_cache.
15137         * mdebugread.c (parse_partial_symbols): Update.
15138         * dwarf2read.c (create_addrmap_from_index)
15139         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15140         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15141         (add_partial_subprogram, dwarf2_ranges_read): Update.
15142         * dwarf-index-write.c (write_address_map)
15143         (write_one_signatured_type, recursively_write_psymbols)
15144         (class debug_names, class debug_names, write_psymtabs_to_index):
15145         Update.
15146
15147 2019-01-10  Tom Tromey  <tom@tromey.com>
15148
15149         * symtab.h (SYMBOL_SET_NAMES): Update.
15150         (symbol_set_names): Update.
15151         (MSYMBOL_SET_NAMES): Update.
15152         * symtab.c (symbol_set_names): Change argument to be an
15153         objfile_per_bfd_storage.
15154         * psymtab.c (add_psymbol_to_bcache): Update.
15155         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15156
15157 2019-01-10  Tom Tromey  <tom@tromey.com>
15158
15159         * symtab.c (create_demangled_names_hash): Change argument to be an
15160         objfile_per_bfd_storage.
15161         (symbol_set_names): Update.
15162
15163 2019-01-10  Tom Tromey  <tom@tromey.com>
15164
15165         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15166         init_psymbol_list.
15167         * psymtab.c (init_psymbol_list): Do nothing if already called.
15168         * psympriv.h (init_psymbol_list): Add comment.
15169         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15170         init_psymbol_list.
15171         * dbxread.c (dbx_symfile_read): Unconditionally call
15172         init_psymbol_list.
15173
15174 2019-01-10  Tom Tromey  <tom@tromey.com>
15175
15176         * xcoffread.c (scan_xcoff_symtab): Update.
15177         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15178         "where".
15179         * mdebugread.c (parse_partial_symbols)
15180         (handle_psymbol_enumerators): Update.
15181         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15182         * dbxread.c (read_dbx_symtab): Update.
15183         * psympriv.h (psymbol_placement): New enum.
15184         (add_psymbol_to_list): Update.
15185
15186 2019-01-10  Tom Tromey  <tom@tromey.com>
15187
15188         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15189         static_psymbols parameters.
15190         (scan_xcoff_symtab): Update.
15191         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15192         static_psymbols parameters.
15193         * psympriv.h (start_psymtab_common): Update.
15194         * mdebugread.c (parse_partial_symbols): Update.
15195         * dwarf2read.c (create_partial_symtab): Update.
15196         * dbxread.c (read_dbx_symtab): Update.
15197         (start_psymtab): Remove global_psymbols and static_psymbols
15198         parameters.
15199
15200 2019-01-10  Tom Tromey  <tom@tromey.com>
15201
15202         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15203         * psymtab.c (allocate_psymtab): Add comment.
15204         * psympriv.h (allocate_psymtab): Add comment.
15205         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15206         initializations.
15207         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15208
15209 2019-01-10  Tom Tromey  <tom@tromey.com>
15210
15211         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15212         Don't declare.
15213         * mipsread.c: Include mdebugread.h.
15214         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15215         Declare.
15216         * elfread.c: Include mdebugread.h.
15217
15218 2019-01-09  Tom Tromey  <tom@tromey.com>
15219
15220         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15221         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15222         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15223         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15224         (psym_lookup_symbol, psym_find_last_source_symtab)
15225         (psym_forget_cached_source_info, psym_print_stats)
15226         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15227         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15228         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15229         (psym_find_compunit_symtab_by_address)
15230         (maintenance_print_psymbols, maintenance_info_psymtabs)
15231         (maintenance_check_psymtabs): Use ranged for.
15232         * psymtab.h (class objfile_psymtabs): New.
15233         (require_partial_symbols): Return objfile_psymtabs.
15234         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15235
15236 2019-01-09  Tom Tromey  <tom@tromey.com>
15237
15238         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15239         (find_pc_mapped_section, list_overlays_command)
15240         (map_overlay_command, unmap_overlay_command)
15241         (simple_overlay_update): Use all_objfiles.
15242         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15243         * printcmd.c (info_symbol_command): Use all_objfiles.
15244         * objfiles.h (ALL_OBJSECTIONS): Remove.
15245         * maint.c (maintenance_translate_address): Use all_objfiles.
15246         * gcore.c (gcore_create_callback): Use all_objfiles.
15247         (objfile_find_memory_regions): Likewise.
15248
15249 2019-01-09  Tom Tromey  <tom@tromey.com>
15250
15251         * symtab.c (find_line_symtab, info_sources_command)
15252         (make_source_files_completion_list): Use objfile_compunits.
15253         * source.c (select_source_symtab): Use objfile_compunits.
15254         * objfiles.h (struct objfile): Update comment.
15255         (ALL_OBJFILES): Remove.
15256         (ALL_FILETABS): Remove.
15257         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15258         objfile_compunits.
15259
15260 2019-01-09  Tom Tromey  <tom@tromey.com>
15261
15262         * symmisc.c (print_objfile_statistics, dump_objfile)
15263         (maintenance_print_symbols): Use compunit_filetabs.
15264         * source.c (forget_cached_source_info_for_objfile): Use
15265         compunit_filetabs.
15266         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15267         (ALL_FILETABS): Use compunit_filetabs.
15268         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15269         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15270
15271 2019-01-09  Tom Tromey  <tom@tromey.com>
15272
15273         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15274         (compunit_filetabs): New.
15275         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15276         compunit_filetabs.
15277         (info_sources_command, make_source_files_completion_list): Remove
15278         declaration.
15279         * symmisc.c (print_objfile_statistics, dump_objfile)
15280         (maintenance_print_symbols): Remove declaration.
15281         (maintenance_info_symtabs): Use compunit_filetabs.
15282         (maintenance_info_line_tables): Likewise.
15283         * source.c (select_source_symtab): Change local variable name.
15284         (forget_cached_source_info_for_objfile): Remove declaration.
15285         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15286         * objfiles.c (objfile_relocate1): Remove declaration.
15287         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15288         declaration.
15289         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15290         * coffread.c (coff_symtab_read): Remove declaration.
15291         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15292         compunit_filetabs.
15293
15294 2019-01-09  Tom Tromey  <tom@tromey.com>
15295
15296         * symtab.c (lookup_objfile_from_block)
15297         (find_pc_sect_compunit_symtab, search_symbols)
15298         (default_collect_symbol_completion_matches_break_on): Use
15299         objfile_compunits.
15300         * objfiles.h (ALL_COMPUNITS): Remove.
15301         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15302         * cp-support.c (add_symbol_overload_list_qualified): Use
15303         objfile_compunits.
15304         * ada-lang.c (ada_collect_symbol_completion_matches)
15305         (ada_add_global_exceptions): Use objfile_compunits.
15306
15307 2019-01-09  Tom Tromey  <tom@tromey.com>
15308
15309         * source.c (select_source_symtab)
15310         (forget_cached_source_info_for_objfile): Remove declaration.
15311         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15312         declaration.
15313         * maint.c (count_symtabs_and_blocks): Remove declaration.
15314         * cp-support.c (add_symbol_overload_list_qualified): Remove
15315         declaration.
15316         * coffread.c (coff_symtab_read): Remove declaration.
15317         * symtab.c (lookup_symbol_in_objfile_symtabs)
15318         (basic_lookup_transparent_type_1): Use objfile_compunits.
15319         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15320         (info_sources_command, search_symbols)
15321         (default_collect_symbol_completion_matches_break_on)
15322         (make_source_files_completion_list): Remove declaration.
15323         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15324         (ada_collect_symbol_completion_matches)
15325         (ada_add_global_exceptions): Remove declaration.
15326         * linespec.c (iterate_over_all_matching_symtabs): Use
15327         objfile_compunits.
15328         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15329         (class objfile_compunits): New.
15330         (ALL_COMPUNITS): Use objfile_compunits.
15331         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15332         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15333         objfile_compunits.
15334         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15335
15336 2019-01-09  Tom Tromey  <tom@tromey.com>
15337
15338         * symtab.c (search_symbols)
15339         (default_collect_symbol_completion_matches_break_on): Use
15340         objfile_msymbols.
15341         * ada-lang.c (ada_lookup_simple_minsym)
15342         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15343         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15344         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15345         objfile_msymbols.
15346         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15347         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15348         * objc-lang.c (find_methods): Use objfile_msymbols.
15349         (info_selectors_command, info_classes_command): Likewise.
15350         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15351         * objfiles.h (class objfile_msymbols): New.
15352         (ALL_OBJFILE_MSYMBOLS): Remove.
15353         (ALL_MSYMBOLS): Remove.
15354
15355 2019-01-09  Tom Tromey  <tom@tromey.com>
15356
15357         * common/next-iterator.h (next_adapter): Add Iterator template
15358         parameter.
15359         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15360         (class all_objfiles_safe): New.
15361         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15362         * objfiles.c (put_objfile_before): Update comment.
15363         (add_separate_debug_objfile): Likewise.
15364         (free_all_objfiles): Use all_objfiles_safe.
15365         (objfile_purge_solibs): Likewise.
15366
15367 2019-01-09  Tom Tromey  <tom@tromey.com>
15368
15369         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15370         (expand_symtab_containing_pc, lookup_static_symbol)
15371         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15372         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15373         all_objfiles.
15374         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15375         * breakpoint.c (create_overlay_event_breakpoint)
15376         (create_longjmp_master_breakpoint)
15377         (create_std_terminate_master_breakpoint)
15378         (create_exception_master_breakpoint): Use all_objfiles.
15379         * linux-thread-db.c (try_thread_db_load_from_pdir)
15380         (has_libpthread): Use all_objfiles.
15381         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15382         * linespec.c (iterate_over_all_matching_symtabs)
15383         (search_minsyms_for_name): Use all_objfiles.
15384         * maint.c (maintenance_info_sections): Use all_objfiles.
15385         * main.c (captured_main_1): Use all_objfiles.
15386         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15387         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15388         * guile/scm-pretty-print.c
15389         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15390         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15391         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15392         (maintenance_print_msymbols): Use all_objfiles.
15393         * source.c (select_source_symtab): Use all_objfiles.
15394         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15395         * symfile.c (remove_symbol_file_command)
15396         (expand_symtabs_matching, map_symbol_filenames): Use
15397         all_objfiles.
15398         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15399         all_objfiles.
15400         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15401         * objc-lang.c (find_methods): Use all_objfiles.
15402         * objfiles.c (have_partial_symbols, have_full_symbols)
15403         (have_minimal_symbols, qsort_cmp)
15404         (default_iterate_over_objfiles_in_search_order): Use
15405         all_objfiles.
15406         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15407         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15408         (maintenance_check_psymtabs): Use all_objfiles.
15409         (ALL_PSYMTABS): Remove.
15410         * compile/compile-object-run.c (do_module_cleanup): Use
15411         all_objfiles.
15412         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15413         * cp-support.c (add_symbol_overload_list_qualified): Use
15414         all_objfiles.
15415         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15416         Use all_objfiles.
15417         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15418         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15419         all_objfiles.
15420         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15421         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15422         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15423         Uses all_objfiles.
15424         * solib.c (solib_read_symbols): Use all_objfiles
15425
15426 2019-01-09  Tom Tromey  <tom@tromey.com>
15427
15428         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15429         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15430         all_objfiles.
15431         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15432         * symmisc.c (print_symbol_bcache_statistics)
15433         (print_objfile_statistics, maintenance_print_objfiles)
15434         (maintenance_info_symtabs, maintenance_check_symtabs)
15435         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15436         all_objfiles.
15437         * source.c (forget_cached_source_info): Use all_objfiles.
15438         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15439         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15440         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15441         * objfiles.c (update_section_map): Use all_objfiles.
15442         (shared_objfile_contains_address_p): Likewise.
15443         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15444         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15445
15446 2019-01-09  Tom Tromey  <tom@tromey.com>
15447
15448         * common/next-iterator.h: New file.
15449         * objfiles.h (class all_objfiles): New.
15450         (struct objfile_iterator): New.
15451
15452 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15453
15454         * NEWS: Move the description of the changed "frame", "select-frame",
15455          and "info frame" commands to the Changed commands section.
15456
15457 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15458
15459         * gdbtypes.c (check_stub_method_group): Remove handling of old
15460         mangling schemes.
15461         * linespec.c (find_methods): Likewise.
15462         * stabsread.c (read_member_functions): Likewise.
15463         * valops.c (search_struct_method): Likewise.
15464         (value_struct_elt_for_reference): Likewise.
15465         * NEWS: Mention this change.
15466
15467 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15468
15469         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15470         print_source_lines.
15471         * source.c (print_source_lines_base): Update line number check.
15472         (print_source_lines): New function.
15473         (source_lines_range::source_lines_range): New function.
15474         * source.h (class source_lines_range): New class.
15475         (print_source_lines): New declaration.
15476
15477 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15478
15479         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15480
15481 2019-01-08  Tom Tromey  <tom@tromey.com>
15482             Simon Marchi  <simon.marchi@ericsson.com>
15483
15484         PR gdb/24060
15485         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15486         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15487         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15488         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15489         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15490         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15491
15492 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15493
15494         * source.c (select_source_symtab): Move header comment to
15495         declaration in source.h.
15496         (forget_cached_source_info_for_objfile): Likewise.
15497         (forget_cached_source_info): Likewise.
15498         (identify_source_line): Likewise.
15499         * source.h (identify_source_line): Move declaration from symtab.h
15500         and add comment from source.c
15501         (print_source_lines): Likewise.
15502         (forget_cached_source_info_for_objfile): Likewise.
15503         (forget_cached_source_info): Likewise.
15504         (select_source_symtab): Likewise.
15505         (enum print_source_lines_flag): Move definition from symtab.h.
15506         * symtab.h (identify_source_line): Move declaration to source.h.
15507         (print_source_lines): Likewise.
15508         (forget_cached_source_info_for_objfile): Likewise.
15509         (forget_cached_source_info): Likewise.
15510         (select_source_symtab): Likewise.
15511         (enum print_source_lines_flag): Move definition to source.h.
15512         * tui/tui-hooks.c: Add 'source.h' include.
15513
15514 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15515
15516         * source.c (print_source_lines_base): Handle requests to print
15517         reverse line number sequences, and guard against empty lines
15518         string.
15519
15520 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15521
15522         * source.c (print_source_lines_base): Fix skip of '\r' if next
15523         character is '\n'.
15524
15525 2019-01-06  Tom Tromey  <tom@tromey.com>
15526
15527         * c-exp.y (struct c_parse_state) <macro_original_text,
15528         expansion_obstack>: New member.
15529         (macro_original_text, expansion_obstack): Remove globals.
15530         (scan_macro_expansion, scanning_macro_expansion)
15531         (finished_macro_expansion): Update.
15532         (scan_macro_cleanup): Remove.
15533         (yylex, c_parse): Update.
15534
15535 2019-01-06  Tom Tromey  <tom@tromey.com>
15536
15537         * c-exp.y (struct c_parse_state) <strings>: New member.
15538         (operator_stoken): Update.
15539
15540 2019-01-06  Tom Tromey  <tom@tromey.com>
15541
15542         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15543         (union type_stack_elt) <typelist_val>: Now a pointer to
15544         std::vector.
15545         (type_stack_cleanup): Don't declare.
15546         (push_typelist): Update.
15547         * parse.c (pop_typelist): Return a std::vector.
15548         (push_typelist): Take a std::vector.
15549         (follow_types): Update.  Do not free args.
15550         (type_stack_cleanup): Remove.
15551         * c-exp.y (struct c_parse_state): New.
15552         (cpstate): New global.
15553         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15554         (nonempty_typelist): Update.
15555         (func_mod): Create a new vector.
15556         (c_parse): Create a c_parse_state.
15557         (check_parameter_typelist): Do not delete params.
15558         (function_method): Update.  Do not delete type_list.
15559
15560 2019-01-06  Tom Tromey  <tom@tromey.com>
15561
15562         PR gdb/28155:
15563         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15564         check_typedef.
15565         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15566         (print_return_value): Likewise.
15567
15568 2019-01-05  Tom Tromey  <tom@tromey.com>
15569
15570         * contrib/cleanup_check.py: Remove.
15571         * contrib/gcc-with-excheck: Remove.
15572         * contrib/exsummary.py: Remove.
15573         * contrib/excheck.py: Remove.
15574
15575 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
15576
15577         * thread.c (delete_thread_1): Add gdb_assert that THR is not
15578         NULL. Initialize tpprev to NULL instead of assigning it
15579         to NULL on the next statement.
15580         * windows-nat.c (windows_delete_thread): Remove check for
15581         main_thread_id before printing thread exit notifications.
15582         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15583         Remove thread ID check against main_thread_id.
15584         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15585         windows_delete_thread.
15586         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15587
15588 2019-01-04  Tom Tromey  <tom@tromey.com>
15589
15590         * compile/compile.c (_initialize_compile): Use upper case for
15591         metasyntactic variables.
15592         * symmisc.c (_initialize_symmisc): Use upper case for
15593         metasyntactic variables.
15594         * psymtab.c (_initialize_psymtab): Use upper case for
15595         metasyntactic variables.
15596         * demangle.c (demangle_command): Use upper case for metasyntactic
15597         variables.
15598         (_initialize_demangler): Likewise.
15599         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15600         variables.
15601
15602 2019-01-03  Tom Tromey  <tom@tromey.com>
15603
15604         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15605
15606 2019-01-03  Tom Tromey  <tom@tromey.com>
15607
15608         * python/py-symtab.c (salpy_str): Update.
15609         (struct salpy_sal_object) <symtab>: Now a PyObject.
15610         (salpy_dealloc): Update.
15611         (del_objfile_sal): Use gdbpy_ref.
15612
15613 2019-01-03  Tom Tromey  <tom@tromey.com>
15614
15615         * python/py-type.c (convert_field): Use new_reference.  Return
15616         gdbpy_ref.
15617         (make_fielditem): Return gdbpy_ref.
15618         (typy_fields): Update.
15619         (typy_getitem): Update.
15620         (field_name): Return gdbpy_ref.  Use new_reference.
15621         (typy_iterator_iternext): Update.
15622
15623 2019-01-03  Tom Tromey  <tom@tromey.com>
15624
15625         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15626
15627 2019-01-03  Tom Tromey  <tom@tromey.com>
15628
15629         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15630         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15631         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15632         (pspy_set_frame_filters, pspy_set_frame_unwinders)
15633         (pspy_set_type_printers): Likewise.
15634         * python/py-function.c (fnpy_init): Use gdbpy_ref.
15635         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15636         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15637         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15638         (objfpy_set_type_printers): Likewise.
15639
15640 2019-01-03  Tom Tromey  <tom@tromey.com>
15641
15642         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15643         (gdbpy_print_stack): Use gdbpy_err_fetch.
15644         * python/python-internal.h (class gdbpy_err_fetch): New class.
15645         (class gdbpy_enter) <m_error_type, m_error_value,
15646         m_error_traceback>: Remove.
15647         <m_error>: New member.
15648         (gdbpy_exception_to_string): Don't declare.
15649         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15650         * python/py-value.c (convert_value_from_python): Use
15651         gdbpy_err_fetch.
15652         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15653         gdbpy_exception_to_string.
15654         (gdbpy_handle_exception): Use gdbpy_err_fetch.
15655         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15656         gdbpy_err_fetch.
15657
15658 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15659
15660         * linux-nat.c (delete_lwp_cleanup): Delete.
15661         (struct lwp_deleter): New struct.
15662         (lwp_info_up): New typedef.
15663         (linux_nat_target::follow_fork): Delete cleanup, and make use of
15664         lwp_info_up.
15665
15666 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15667
15668         * linux-fork.c (class scoped_switch_fork_info): New class.
15669         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15670
15671 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15672
15673         * valops.c (find_overload_match): Remove use of null_cleanup, and
15674         calls to do_cleanups.
15675
15676 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15677
15678         * compile/compile-cplus-types.c
15679         (compile_cplus_instance::decl_name): Handle changes to
15680         cp_func_name.
15681         * cp-support.c (cp_func_name): Update header comment, update
15682         return type.
15683         * cp-support.h (cp_func_name): Update return type in declaration.
15684         * valops.c (find_overload_match): Move temp_func local to top
15685         level of function and change its type.  Use temp_func to hold and
15686         delete temporary string obtained from cp_func_name.
15687
15688 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15689
15690         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15691         gdb::char_vector, remove cleanup, and update uses of `msg`.
15692
15693 2019-01-03  Jim Wilson  <jimw@sifive.com>
15694
15695         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15696
15697 2019-01-02  Tom Tromey  <tom@tromey.com>
15698
15699         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15700         (tdesc_parse_xml): Remove cleanups.
15701         * target-descriptions.h (make_cleanup_free_target_description):
15702         Don't declare.
15703         (target_desc_deleter): New struct.
15704         (target_desc_up): New typedef.
15705         * target-descriptions.c (target_desc_deleter::operator()): Rename
15706         from free_target_description.
15707         (make_cleanup_free_target_description): Remove.
15708
15709 2019-01-02  Tom Tromey  <tom@tromey.com>
15710
15711         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
15712         constructor, destructor.
15713         (linespec_parser): Remove typedef.
15714         (~linespec_parser): Rename from linespec_parser_delete.
15715         (linespec_lex_to_end, linespec_complete_label)
15716         (linespec_complete): Update.
15717         (decode_line_full): Remove cleanups.
15718         (decode_line_1): Update.
15719
15720 2019-01-02  Tom Tromey  <tom@tromey.com>
15721
15722         * python/python-internal.h (inferior_to_inferior_object): Change
15723         return type.
15724         * python/py-exitedevent.c (create_exited_event_object): Update.
15725         * python/py-inferior.c (inferior_to_inferior_object): Return
15726         gdbpy_ref.
15727         (python_new_inferior, python_inferior_deleted)
15728         (thread_to_thread_object, delete_thread_object)
15729         (build_inferior_list, gdbpy_selected_inferior): Update.
15730         * python/py-infthread.c (create_thread_object): Update.  Also fail
15731         if inferior_to_inferior_object fails.
15732
15733 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
15734
15735         * inferior.h (class inferior) <displaced_step_state>: New field.
15736         * infrun.h (struct displaced_step_state): Move here from
15737         infrun.c.  Initialize fields, add constructor.
15738         <inf>: Remove field.
15739         <reset>: New method.
15740         * infrun.c (struct displaced_step_inferior_state): Move to
15741         infrun.h.
15742         (displaced_step_inferior_states): Remove.
15743         (get_displaced_stepping_state): Adust.
15744         (displaced_step_in_progress_any_inferior): Adjust.
15745         (displaced_step_in_progress_thread): Adjust.
15746         (displaced_step_in_progress): Adjust.
15747         (add_displaced_stepping_state): Remove.
15748         (get_displaced_step_closure_by_addr): Adjust.
15749         (remove_displaced_stepping_state): Remove.
15750         (infrun_inferior_exit): Call displaced_step_state.reset.
15751         (use_displaced_stepping): Don't check for NULL.
15752         (displaced_step_prepare_throw): Call
15753         get_displaced_stepping_state.
15754         (displaced_step_fixup): Don't check for NULL.
15755         (prepare_for_detach): Don't check for NULL.
15756
15757 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15758
15759         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15760          in case of call that did not complete.
15761
15762 2019-01-02  Andrey Utkin  <autkin@undo.io>
15763
15764         * symfile.c (find_separate_debug_file): Fix search of debug files for
15765         remote debuggee.
15766
15767 2019-01-02  Tom Tromey  <tom@tromey.com>
15768
15769         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15770         indentation.
15771         * python/py-frame.c (frapy_older): Remove cast.
15772         (frapy_newer): Likewise.
15773         * python/py-breakpoint.c (local_setattro): Remove cast.
15774         * python/py-arch.c (archpy_name): Remove local variable.
15775         * python/py-type.c (gdbpy_lookup_type): Remove cast.
15776
15777 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
15778
15779         * unittests/basic_string_view/element_access/char/empty.cc:
15780         Fix year range in copyright header.
15781
15782 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
15783
15784         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
15785         Delete.
15786         <operator==>: Update with for removed field.
15787         <hash>: Likewise.
15788         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
15789         <isa_features>: ...this.
15790         <abi_features>: New field.
15791         (riscv_isa_flen): Update comment.
15792         (riscv_abi_xlen): New declaration.
15793         (riscv_abi_flen): New declaration.
15794         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
15795         isa_features.
15796         (riscv_abi_xlen): New function.
15797         (riscv_isa_flen): Update to get answer from isa_features.
15798         (riscv_abi_flen): New function.
15799         (riscv_has_fp_abi): Update to get answer from abi_features.
15800         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
15801         xlen and flen.
15802         (riscv_call_info) <xlen, flen>: Update comment.
15803         (riscv_call_arg_struct): Remove invalid assertions
15804         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
15805         is removed.
15806         (riscv_gdbarch_init): Gather isa features and abi features
15807         separately, ensure both match on the gdbarch when reusing an old
15808         gdbarch.  Relax an error check to allow 32-bit abi float to run on
15809         a target with 64-bit float hardware.
15810
15811 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15812
15813         * source.c (search_command_helper): Stop reverse search
15814         when line 1 has been searched.
15815
15816 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15817
15818         * record-full.c (record_full_base_target::close): Rewrite
15819         record_full_core_buf_list free logic.
15820
15821 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15822
15823         * break-catch-syscall.c (print_one_catch_syscall): xfree
15824         the last text.
15825
15826 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15827
15828         * top.c (print_gdb_version): Update Copyright year in version
15829         message.
15830
15831 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
15832
15833         Update copyright year range in all GDB files.
15834
15835 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
15836
15837         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
15838
15839 For older changes see ChangeLog-2018.
15840 \f
15841 Local Variables:
15842 mode: change-log
15843 left-margin: 8
15844 fill-column: 74
15845 version-control: never
15846 coding: utf-8
15847 End:
15848