gdb/ChangeLog

   1 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * NEWS: Mention changes to help and apropos.
   4
   5 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   6
   7         * command.h (enum command_class): Improve comments, document
   8         that class_alias is for user-defined aliases, give the class
   9         name for each class, remove unused class_xdb.
  10         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
  11         * breakpoint.c (_initialize_breakpoint): Replace class_alias
  12         by a precise class.
  13         * infcmd.c (_initialize_infcmd): Likewise.
  14         * reverse.c (_initialize_reverse): Likewise.
  15         * stack.c (_initialize_stack): Likewise.
  16         * symfile.c (_initialize_symfile): Likewise.
  17         * tracepoint.c (_initialize_tracepoint): Likewise.
  18
  19 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  20
  21         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
  22         when their aliased command is traversed.
  23         (help_cmd): Add fput_command_names_styled call to
  24         output command name and aliases when command has an alias.
  25
  26 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  27
  28         * cli/cli-decode.h (help_cmd_list): Remove declaration.
  29         * cli/cli-decode.c (help_cmd_list): Declare as static,
  30         remove prefix argument, use bool for recurse arg, rework to show the aliases of
  31         a command together with the command.
  32         (fput_command_name_styled, fput_command_names_styled): New functions.
  33         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
  34         fput_command_name_styled.
  35         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
  36         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
  37
  38 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  39
  40         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
  41         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
  42         * command.h (cmd_show_list): Likewise.
  43         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
  44         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
  45
  46 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  47
  48         * unittests/command-def-selftests.c (traverse_command_structure):
  49         Verify all commands of a list have the same prefix command and
  50         that only the top cmdlist commands have a null prefix.
  51
  52 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  53
  54         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
  55         as prefix, not one of its aliases.
  56         (set_cmd_prefix): Remove.
  57         (do_add_cmd): Centralize the setting of the prefix of a command, when
  58         command is defined after its full chain of prefix commands.
  59         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
  60         (add_setshow_cmd_full): Likewise.
  61         (update_prefix_field_of_prefixed_commands): New function.
  62         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
  63         update_prefix_field_of_prefixed_commands.
  64         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
  65         addresses of remote_set_cmdlist and remote_show_cmdlist given
  66         as argument, not the address of an argument.
  67         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
  68         * gdb/remote.c (_initialize_remote): Likewise.
  69
  70 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  71
  72         * cli/cli-cmds.c (alias_command): Check for an existing alias
  73         using lookup_cmd_composition, as valid_command_p is too strict
  74         and forbids aliases that are the prefix of an existing alias
  75         or command.
  76         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
  77         command is properly recognised as a valid command.
  78
  79 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  80
  81         * unittests/help-doc-selftests.c: Rename to
  82         unittests/command-def-selftests.c
  83         * unittests/command-def-selftests.c (help_doc_tests): Update some
  84         comments.
  85         (command_structure_tests, traverse_command_structure): New namespace
  86         and function.
  87         (command_structure_invariants_tests): New function.
  88         (_initialize_command_def_selftests) Renamed from
  89         _initialize_help_doc_selftests, register command_structure_invariants
  90         selftest.
  91
  92 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  93
  94         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
  95         an alias of 'show'.
  96
  97 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
  98
  99         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
 100         ada_is_fixed_point_type.  Update all callers.
 101         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
 102         all callers.
 103         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
 104         Update all callers.
 105         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
 106         print_fixed_point_type.  Update all callers.
 107         * ada-valprint.c (ada_value_print_num): Replace call to
 108         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
 109
 110 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
 111
 112         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
 113         processors.
 114         (cpu_supports_bts): Add CV_AMD case.
 115
 116 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
 117             Simon Marchi  <simon.marchi@efficios.com>
 118
 119         * infrun.c (stop_all_threads): Collect multiple wait events at
 120         each pass.
 121
 122 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
 123
 124         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
 125         type::code instead.
 126
 127 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
 128
 129         * gdbtypes.h (struct type) <code, set_code>: New methods.
 130         (TYPE_CODE): Use type::code.  Change all call sites used to set
 131         the code to use type::set_code instead.
 132
 133 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 134             Tom de Vries  <tdevries@suse.de>
 135             Pedro Alves  <palves@redhat.com>
 136
 137         PR threads/25478
 138         * infrun.c (stop_all_threads): Do NOT ignore
 139         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
 140         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
 141         received.
 142         (handle_no_resumed): Remove code handling a live inferior with no
 143         threads.
 144         * remote.c (has_single_non_exited_thread): New.
 145         (remote_target::update_thread_list): Do not delete a thread if is
 146         the last thread of the process.
 147         * thread.c (thread_select): Call delete_exited_threads instead of
 148         prune_threads.
 149
 150 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 151
 152         * infrun.c (stop_all_threads): Enable/disable thread events of all
 153         targets.  Move a debug message denoting the end of the function
 154         into the SCOPED_EXIT block.
 155
 156 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 157
 158         * process-stratum-target.h: Include <set>.
 159         (all_non_exited_process_targets, switch_to_target_no_thread): New
 160         function declarations.
 161         * process-stratum-target.c (all_non_exited_process_targets)
 162         (switch_to_target_no_thread): New function implementations.
 163
 164 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 165
 166         * infrun.c (handle_inferior_event): Extract out a piece of code
 167         into...
 168         (mark_non_executing_threads): ...this new function.
 169
 170 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 171
 172         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
 173         use.
 174
 175 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 176
 177         * regcache.c (regcache_read_pc_protected): New function
 178         implementation that returns 0 if the PC cannot read via
 179         'regcache_read_pc'.
 180         * infrun.c (proceed): Call 'regcache_read_pc_protected'
 181         instead of 'regcache_read_pc'.
 182         (keep_going_pass_signal): Ditto.
 183
 184 2020-05-13  Tom Tromey  <tromey@adacore.com>
 185
 186         * ada-lang.c (align_value): Remove.
 187         (ada_template_to_fixed_record_type_1): Use align_up.
 188
 189 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 190
 191         * async-event.c: Update the copyright year.
 192         * async-event.h: Update the copyright year.
 193
 194 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
 195
 196         * objfiles.h (is_addr_in_objfile,
 197         shared_objfile_contains_address_p): Return bool.
 198         * objfile.c (is_addr_in_objfile,
 199         shared_objfile_contains_address_p): Return bool.
 200
 201 2020-05-11  Tom Tromey  <tromey@adacore.com>
 202
 203         * cli/cli-cmds.c (info_command): Restore.
 204         (_initialize_cli_cmds): Use add_prefix_command for "info".
 205         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
 206
 207 2020-05-11  Tom Tromey  <tromey@adacore.com>
 208
 209         * ada-lang.c (ada_value_primitive_field): Now public.
 210         * ada-lang.h (ada_value_primitive_field): Declare.
 211         * ada-valprint.c (print_field_values): Use
 212         ada_value_primitive_field for wrapper fields.
 213
 214 2020-05-11  Tom de Vries  <tdevries@suse.de>
 215
 216         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
 217         MODULE_DOMAIN.
 218
 219 2020-05-11  Tom de Vries  <tdevries@suse.de>
 220
 221         PR symtab/25941
 222         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
 223         with length 0, if not gdb-produced.
 224         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
 225
 226 2020-05-09  Tom de Vries  <tdevries@suse.de>
 227
 228         PR gdb/25955
 229         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
 230         calculation.
 231
 232 2020-05-09  Tom Tromey  <tom@tromey.com>
 233
 234         * top.c (server_command): Now bool.
 235         * top.h (server_command): Now bool.
 236
 237 2020-05-08  Tom Tromey  <tromey@adacore.com>
 238
 239         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
 240         already being processed.
 241
 242 2020-05-08  Tom Tromey  <tom@tromey.com>
 243
 244         * printcmd.c (struct display) <next>: Remove.
 245         <display>: New constructor.
 246         <exp_string>: Now a std::string.
 247         <enabled_p>: Now a bool.
 248         (display_number): Move definition earlier.
 249         (displays): Rename from display_chain.  Now a std::vector.
 250         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
 251         (display_command): Update.
 252         (do_one_display, disable_display)
 253         (enable_disable_display_command, do_enable_disable_display):
 254         Update.
 255         (free_display): Remove.
 256         (clear_displays): Rewrite.
 257         (delete_display): Update.
 258         (map_display_numbers): Use function_view.  Remove "data"
 259         parameter.  Update.
 260         (do_delete_display): Remove.
 261         (undisplay_command): Update.
 262         (do_one_display, do_displays, disable_display)
 263         (info_display_command): Update.
 264         (do_enable_disable_display): Remove.
 265         (enable_disable_display_command)
 266         (clear_dangling_display_expressions): Update.
 267
 268 2020-05-08  Tom Tromey  <tom@tromey.com>
 269
 270         * symtab.c (set_symbol_cache_size)
 271         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
 272         (maintenance_print_symbol_cache_statistics): Update.
 273         * symmisc.c (print_symbol_bcache_statistics)
 274         (print_objfile_statistics, maintenance_print_objfiles)
 275         (maintenance_info_symtabs, maintenance_check_symtabs)
 276         (maintenance_expand_symtabs, maintenance_info_line_tables):
 277         Update.
 278         * symfile-debug.c (set_debug_symfile): Update.
 279         * source.c (forget_cached_source_info): Update.
 280         * python/python.c (gdbpy_progspaces): Update.
 281         * psymtab.c (maintenance_info_psymtabs): Update.
 282         * probe.c (parse_probes): Update.
 283         * linespec.c (iterate_over_all_matching_symtabs)
 284         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
 285         * guile/scm-progspace.c (gdbscm_progspaces): Update.
 286         * exec.c (exec_target::close): Update.
 287         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
 288         * breakpoint.c (print_one_breakpoint_location)
 289         (create_longjmp_master_breakpoint)
 290         (create_std_terminate_master_breakpoint): Update.
 291         * progspace.c (program_spaces): Now a std::vector.
 292         (maybe_new_address_space): Update.
 293         (add_program_space): Remove.
 294         (program_space::program_space): Update.
 295         (remove_program_space): Update.
 296         (number_of_program_spaces): Remove.
 297         (print_program_space, update_address_spaces): Update.
 298         * progspace.h (program_spaces): Change type.
 299         (ALL_PSPACES): Remove.
 300         (number_of_program_spaces): Don't declare.
 301         (struct program_space) <next>: Remove.
 302
 303 2020-05-08  Tom Tromey  <tom@tromey.com>
 304
 305         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
 306         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
 307         (enable_break): Update.
 308         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
 309         (frv_fdpic_find_canonical_descriptor): Update.
 310         (frv_fetch_objfile_link_map): Update.
 311         * progspace.c (program_space::free_all_objfiles): Update.
 312         (program_space::solibs): New method.
 313         * progspace.h (struct program_space) <solibs>: New method.
 314         * solist.h (master_so_list): Don't declare.
 315         (ALL_SO_LIBS): Remove.
 316         * solib.h (so_list_head): Remove.
 317         (update_solib_list): Update comment.
 318         * solib.c (master_so_list): Remove.
 319         (solib_used, update_solib_list, solib_add)
 320         (info_sharedlibrary_command, clear_solib)
 321         (reload_shared_libraries_1, remove_user_added_objfile): Update.
 322
 323 2020-05-08  Tom Tromey  <tom@tromey.com>
 324
 325         * extension.c (extension_languages): Now a std::array.
 326         (ALL_EXTENSION_LANGUAGES): Remove.
 327         (get_ext_lang_defn, get_ext_lang_of_file)
 328         (eval_ext_lang_from_control_command): Update.
 329         (finish_ext_lang_initialization)
 330         (auto_load_ext_lang_scripts_for_objfile)
 331         (ext_lang_type_printers::ext_lang_type_printers)
 332         (apply_ext_lang_type_printers)
 333         (ext_lang_type_printers::~ext_lang_type_printers)
 334         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
 335         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
 336         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
 337         (get_matching_xmethod_workers, ext_lang_colorize)
 338         (ext_lang_before_prompt): Update.
 339         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
 340
 341 2020-05-08  Tom Tromey  <tom@tromey.com>
 342
 343         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
 344         overload.
 345         <swap_string, m_string>: Remove.
 346         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
 347         Update.
 348         * stabsread.c (define_symbol, read_type): Update.
 349         * linespec.c (find_linespec_symbols): Update.
 350         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
 351         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
 352         * dbxread.c (read_dbx_symtab): Update.
 353         * cp-support.h (cp_canonicalize_string_full)
 354         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
 355         Return unique_xmalloc_ptr.
 356         * cp-support.c (inspect_type): Update.
 357         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
 358         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
 359         Likewise.
 360         * c-typeprint.c (print_name_maybe_canonical): Update.
 361         * break-catch-throw.c (check_status_exception_catchpoint):
 362         Update.
 363
 364 2020-05-08  Tom de Vries  <tdevries@suse.de>
 365
 366         * infrun.c (follow_fork): Copy current_line and current_symtab to
 367         child thread.
 368
 369 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 370
 371         * async-event.c (struct async_signal_handler, struct
 372         async_event_handler): Reformat, remove typedef.
 373
 374 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 375
 376         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
 377         access thistype->main_type->dyn_prop_list directly.
 378
 379 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 380
 381         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
 382         (remove_dyn_prop): Remove.  Update all users to use
 383         type::remove_dyn_prop.
 384         * gdbtypes.c (remove_dyn_prop): Rename to...
 385         (type::remove_dyn_prop): ... this.
 386
 387 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
 388
 389         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
 390         (add_dyn_prop): Remove.  Update all users to use
 391         type::add_dyn_prop.
 392         * gdbtypes.c (add_dyn_prop): Rename to...
 393         (type::add_dyn_prop): ... this.
 394
 395 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 396
 397         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
 398         (get_dyn_prop): Remove.  Update all users to use
 399         type::dyn_prop.
 400         * gdbtypes.c (get_dyn_prop): Rename to...
 401         (type::dyn_prop): ... this.
 402
 403 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
 404
 405         * gdbtypes.h (struct main_type) <flag_static>: Remove.
 406
 407 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
 408
 409         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
 410         instruction, skip it if it's there.
 411
 412 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
 413
 414         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
 415
 416 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
 417
 418         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
 419         * gdbtypes.c (recursive_dump_type): Remove use of
 420         TYPE_INCOMPLETE.
 421
 422 2020-05-03  Tom Tromey  <tom@tromey.com>
 423
 424         * breakpoint.c (catch_command, tcatch_command): Remove.
 425         (_initialize_breakpoint): Use add_basic_prefix_cmd,
 426         add_show_prefix_cmd.
 427         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
 428         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
 429         Remove.
 430         (add_internal_problem_command): Use add_basic_prefix_cmd,
 431         add_show_prefix_cmd.
 432         * mips-tdep.c (set_mipsfpu_command): Remove.
 433         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
 434         * dwarf2/index-cache.c (set_index_cache_command): Remove.
 435         (_initialize_index_cache): Use add_basic_prefix_cmd.
 436         * memattr.c (dummy_cmd): Remove.
 437         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
 438         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
 439         (_initialize_tui_win): Use add_basic_prefix_cmd,
 440         add_show_prefix_cmd.
 441         * cli/cli-logging.c (set_logging_command): Remove.
 442         (_initialize_cli_logging): Use add_basic_prefix_cmd,
 443         add_show_prefix_cmd.
 444         (show_logging_command): Remove.
 445         * target.c (target_command): Remove.
 446         (add_target): Use add_basic_prefix_cmd.
 447
 448 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
 449
 450         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
 451
 452 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 453
 454         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
 455         info_command.
 456
 457 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
 458
 459         * nbsd-nat.c (nbsd_enable_proc_events)
 460         (nbsd_nat_target::post_startup_inferior): Add.
 461         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
 462         (nbsd_nat_target::update_thread_list): Rewrite.
 463         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
 464         "PTRACE_LWP_CREATE".
 465         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
 466
 467 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 468
 469         * stack.c (_initialize_stack): Remove duplicated creation
 470         of "frame" command and "f" alias.
 471
 472 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 473
 474         PR gdb/18706
 475         * gdbtypes.c (check_typedef): Calculate size of array of
 476         stubbed type.
 477
 478 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 479
 480         PR gdb/15559
 481         * i386-tdep.c (i386_push_dummy_call): Call
 482         i386_thiscall_push_dummy_call.
 483         (i386_thiscall_push_dummy_call): New function.
 484         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
 485         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
 486         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
 487
 488 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 489
 490         * gdbarch.sh (do_read): Add shellcheck disable directive for
 491         warning SC2162.
 492
 493 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 494
 495         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
 496         "referenced but not assigned" warning.
 497
 498 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 499
 500         * gdbarch.sh: Remove code that sets fallbackdefault.
 501
 502 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 503
 504         * gdbarch.sh: Use shell operators && and || instead of
 505         -a and -o.
 506
 507 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 508
 509         * gdbarch.sh: Use $(...) instead of `...`.
 510
 511 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 512
 513         * gdbarch.sh: Use double quotes around variables.
 514
 515 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 516
 517         * gdbarch.sh: Use %s with printf, instead of variables in the
 518         format string.
 519
 520 2020-04-29  Tom Tromey  <tromey@adacore.com>
 521
 522         PR ada/25875:
 523         * dwarf2/read.c (update_enumeration_type_from_children): Compute
 524         type fields here.
 525         (read_enumeration_type): Call
 526         update_enumeration_type_from_children later.  Update comments.
 527         (process_enumeration_scope): Don't create type fields.
 528
 529 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 530
 531         * nbsd-tdep.c: Include "xml-syscall.h".
 532         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
 533
 534 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 535
 536         * nbsd-nat.c: Include "sys/wait.h".
 537         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
 538         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
 539         (nbsd_nat_target::remove_exec_catchpoint)
 540         (nbsd_nat_target::set_syscall_catchpoint): Add.
 541         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
 542         (nbsd_nat_target::insert_exec_catchpoint)
 543         (nbsd_nat_target::remove_exec_catchpoint)
 544         (nbsd_nat_target::set_syscall_catchpoint): Add.
 545         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
 546         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
 547         `nbsd_get_syscall_number'.
 548
 549 2020-04-29  Tom Tromey  <tom@tromey.com>
 550
 551         * stack.c (print_block_frame_labels): Remove.
 552
 553 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
 554
 555         PR gdb/17320
 556         * ada-valprint.c (val_print_packed_array_elements): Move array
 557         end bracket to new line.
 558         (ada_val_print_string): Remove extra spaces before first array
 559         element.
 560         * c-valprint.c (c_value_print_array): Likewise.
 561         * m2-valprint.c (m2_print_array_contents): Likewise.
 562         (m2_value_print_inner): Likewise.
 563         * p-valprint.c (pascal_value_print_inner): Likewise.
 564         * valprint.c (generic_val_print_array): Likewise.
 565         (value_print_array_elements): Move first array element and array
 566         end bracket to new line.
 567
 568 2020-04-29  Tom de Vries  <tdevries@suse.de>
 569
 570         PR symtab/25889
 571         * linespec.c (find_method): Fix ix calculation.
 572
 573 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
 574
 575         * syscalls/update-netbsd.sh: New file.
 576         * syscalls/netbsd.xml: Regenerate.
 577         * data-directory/Makefile.in: Register `netbsd.xml' in
 578         `SYSCALLS_FILES'.
 579
 580 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 581
 582         * syscalls/update-freebsd.sh: Add double quotes.
 583
 584 2020-04-28  Tom Tromey  <tom@tromey.com>
 585
 586         * NEWS: Update.
 587         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
 588         (cmdpy_init): Allow class_tui.
 589
 590 2020-04-28 Mark Williams <mark@myosotissp.com>
 591
 592         PR gdb/24480
 593         * dwarf2read.c: Add missing assingments to list_in_scope when
 594         start_symtab was already called.
 595
 596 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 597
 598         PR gdb/25881
 599         * dwarf2/read.c (offset_map_type): Use
 600         gdb:hash_enum<sect_offset> as hash function.
 601
 602 2020-04-28  Tom de Vries  <tdevries@suse.de>
 603
 604         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
 605         with DW_AT_signature.
 606
 607 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
 608
 609         * configure.ac: Remove check for fs_base/gs_base in
 610         user_regs_struct.
 611         * configure: Re-generate.
 612         * config.in: Re-generate.
 613         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
 614         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
 615         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
 616
 617 2020-04-27  Luis Machado  <luis.machado@linaro.org>
 618
 619         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
 620         problematic inline frame unwinding situation.
 621         * frame.c (frame_id_computed_p): New function.
 622         * frame.h (frame_id_computed_p): New prototype.
 623
 624 2020-04-26  Tom Tromey  <tom@tromey.com>
 625
 626         * command.h (enum command_class) <class_pseudo>: Remove.
 627
 628 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 629
 630         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
 631         and whitespace.
 632
 633 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
 634
 635        * inf-ptrace.c (inf_ptrace_target::wait): Remove
 636        `PT_GET_PROCESS_STATE' block.
 637
 638 2020-04-24  Tom Tromey  <tom@tromey.com>
 639
 640         * symtab.h (symbol_get_demangled_name): Don't declare.
 641         * symtab.c (symbol_get_demangled_name): Remove.
 642         (general_symbol_info::natural_name)
 643         (general_symbol_info::demangled_name): Update.
 644
 645 2020-04-24  Tom Tromey  <tom@tromey.com>
 646
 647         PR rust/25025:
 648         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
 649
 650 2020-04-24  Tom Tromey  <tom@tromey.com>
 651
 652         PR symtab/12707:
 653         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
 654         exists.
 655         (new_symbol): Likewise.
 656         * compile/compile-object-load.c (get_out_value_type): Use
 657         symbol_matches_search_name.
 658
 659 2020-04-24  Tom Tromey  <tom@tromey.com>
 660
 661         * dwarf2/read.c (add_partial_symbol): Do not call
 662         compute_and_set_names.
 663
 664 2020-04-24  Tom Tromey  <tom@tromey.com>
 665
 666         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
 667         overload.
 668
 669 2020-04-24  Tom Tromey  <tom@tromey.com>
 670
 671         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
 672         (add_psymbol_to_list): New overload.  Make old overload call new
 673         one.
 674         * psympriv.h (add_psymbol_to_list): New overload.
 675
 676 2020-04-24  Tom Tromey  <tom@tromey.com>
 677
 678         * dwarf2/read.c (partial_die_info::read) <case
 679         DW_AT_linkage_name>: Use value_as_string.
 680         (dwarf2_string_attr): Use value_as_string.
 681         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
 682         method.
 683         * dwarf2/attribute.c (attribute::value_as_string): New method.
 684
 685 2020-04-24  Tom Tromey  <tom@tromey.com>
 686
 687         * symtab.c (general_symbol_info::natural_name)
 688         (general_symbol_info::demangled_name): Check for language_rust.
 689
 690 2020-04-24  Tom Tromey  <tom@tromey.com>
 691
 692         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
 693         (dwarf2_physname): ... from here.
 694         (partial_die_info::read): Add Rust "{" hack.
 695
 696 2020-04-24  Tom Tromey  <tom@tromey.com>
 697
 698         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
 699         method.
 700         (symbol_set_demangled_name): Don't declare.
 701         * symtab.c (general_symbol_info::set_demangled_name): Rename from
 702         symbol_set_demangled_name.
 703         (general_symbol_info::set_language)
 704         (general_symbol_info::compute_and_set_names): Update.
 705         * minsyms.c (minimal_symbol_reader::install): Update.
 706         * dwarf2/read.c (new_symbol): Update.
 707
 708 2020-04-24  Tom Tromey  <tromey@adacore.com>
 709
 710         PR python/23662:
 711         * python/py-type.c (convert_field): Handle
 712         FIELD_LOC_KIND_DWARF_BLOCK.
 713         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
 714         (typy_get_dynamic): Nw function.
 715         (type_object_getset): Add "dynamic".
 716         * NEWS: Add entry.
 717
 718 2020-04-24  Tom Tromey  <tromey@adacore.com>
 719
 720         * ada-typeprint.c (print_choices, print_variant_part)
 721         (print_record_field_types_dynamic): New functions.
 722         (print_record_field_types): Use print_record_field_types_dynamic.
 723
 724 2020-04-24  Tom Tromey  <tromey@adacore.com>
 725
 726         * dwarf2/read.c (handle_data_member_location): New overload.
 727         (dwarf2_add_field): Use it.
 728         (decode_locdesc): Add "computed" parameter.  Update comment.
 729         * gdbtypes.c (is_dynamic_type_internal): Also look for
 730         FIELD_LOC_KIND_DWARF_BLOCK.
 731         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
 732         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
 733         virtual base classes.
 734         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
 735         FIELD_LOC_KIND_DWARF_BLOCK.
 736
 737 2020-04-24  Tom Tromey  <tromey@adacore.com>
 738
 739         * dwarf2/read.c (read_structure_type): Handle dynamic length.
 740         * gdbtypes.c (is_dynamic_type_internal): Check
 741         TYPE_HAS_DYNAMIC_LENGTH.
 742         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
 743         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
 744         New macros.
 745         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
 746         constant.
 747
 748 2020-04-24  Tom Tromey  <tromey@adacore.com>
 749
 750         * dwarf2/read.c (struct variant_field): Rewrite.
 751         (struct variant_part_builder): New.
 752         (struct nextfield): Remove "variant" field.  Add "offset".
 753         (struct field_info): Add "current_variant_part" and
 754         "variant_parts".
 755         (alloc_discriminant_info): Remove.
 756         (alloc_rust_variant): New function.
 757         (quirk_rust_enum): Update.
 758         (dwarf2_add_field): Set "offset" member.  Don't handle
 759         DW_TAG_variant_part.
 760         (offset_map_type): New typedef.
 761         (convert_variant_range, create_one_variant)
 762         (create_one_variant_part, create_variant_parts)
 763         (add_variant_property): New functions.
 764         (dwarf2_attach_fields_to_type): Call add_variant_property.
 765         (read_structure_type): Don't handle DW_TAG_variant_part.
 766         (handle_variant_part, handle_variant): New functions.
 767         (handle_struct_member_die): Use them.
 768         (process_structure_scope): Don't handle variant parts.
 769         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
 770         (struct discriminant_info): Remove.
 771         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
 772         (struct main_type) <flag_discriminated_union>: Remove.
 773         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
 774         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
 775         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
 776         Update.
 777         * valops.c (value_union_variant): Remove.
 778         * value.h (value_union_variant): Don't declare.
 779
 780 2020-04-24  Tom Tromey  <tromey@adacore.com>
 781
 782         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
 783         (ada_value_primitive_packed_val): Update.
 784         * ada-valprint.c (ada_value_print_1): Update.
 785         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
 786         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
 787         just an address.  Use evaluate_for_locexpr_baton.
 788         (dwarf2_evaluate_property): Update.
 789         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
 790         array_view.
 791         * findvar.c (default_read_var_value): Update.
 792         * gdbtypes.c (compute_variant_fields_inner)
 793         (resolve_dynamic_type_internal): Update.
 794         (resolve_dynamic_type): Change type of valaddr parameter.
 795         * gdbtypes.h (resolve_dynamic_type): Update.
 796         * valarith.c (value_subscripted_rvalue): Update.
 797         * value.c (value_from_contents_and_address): Update.
 798
 799 2020-04-24  Tom Tromey  <tromey@adacore.com>
 800
 801         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
 802         "push_initial_value" parameter.
 803         (dwarf2_evaluate_property): Likewise.
 804         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
 805
 806 2020-04-24  Tom Tromey  <tromey@adacore.com>
 807
 808         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
 809         (variant::matches, compute_variant_fields_recurse)
 810         (compute_variant_fields_inner, compute_variant_fields): New
 811         functions.
 812         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
 813         Use resolved_type after type is made.
 814         (operator==): Add new cases.
 815         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
 816         (struct discriminant_range, struct variant, struct variant_part):
 817         New.
 818         (union dynamic_prop_data) <variant_parts, original_type>: New
 819         members.
 820         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
 821         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
 822         constants.
 823         * value.c (unpack_bits_as_long): Now public.
 824         * value.h (unpack_bits_as_long): Declare.
 825
 826 2020-04-24  Tom Tromey  <tromey@adacore.com>
 827
 828         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
 829         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
 830
 831 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
 832
 833         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
 834
 835 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
 836
 837         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
 838         (remove_fork_catchpoint, post_startup_inferior)
 839         (post_attach): Move...
 840         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
 841         (remove_fork_catchpoint, post_startup_inferior)
 842         (post_attach): ...here.
 843         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
 844         (remove_fork_catchpoint, post_startup_inferior)
 845         (post_attach): Move...
 846         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
 847         (remove_fork_catchpoint, post_startup_inferior)
 848         (post_attach): ...here.
 849
 850 2020-04-24  Tom Tromey  <tromey@adacore.com>
 851
 852         * nat/windows-nat.h (struct windows_thread_info)
 853         <pc_adjusted>: New member.
 854         * windows-nat.c (windows_fetch_one_register): Check
 855         pc_adjusted.
 856         (windows_nat_target::get_windows_debug_event)
 857         (windows_nat_target::wait): Set pc_adjusted.
 858
 859 2020-04-24  Tom de Vries  <tdevries@suse.de>
 860
 861         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
 862         Run gdb-add-index inside temp dir.
 863
 864 2020-04-23  Tom Tromey  <tromey@adacore.com>
 865
 866         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
 867         in loop.
 868
 869 2020-04-23  Luis Machado  <luis.machado@linaro.org>
 870
 871         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
 872         get_frame_register instead of gdbarch_unwind_pc.
 873
 874 2020-04-23  Tom de Vries  <tdevries@suse.de>
 875
 876         * symtab.c (lookup_global_symbol): Prefer def over decl.
 877
 878 2020-04-23  Tom de Vries  <tdevries@suse.de>
 879
 880         PR symtab/25807
 881         * block.c (best_symbol, better_symbol): Promote to external.
 882         * block.h (best_symbol, better_symbol): Declare.
 883         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
 884         decl.
 885
 886 2020-04-23  Tom Tromey  <tromey@adacore.com>
 887
 888         PR ada/25837:
 889         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
 890         "const char *", not a "const std::string &".
 891         <name_and_matcher::operator==>: Update.
 892         * unittests/lookup_name_info-selftests.c: Change type of
 893         "result".
 894
 895 2020-04-23  Tom Tromey  <tom@tromey.com>
 896
 897         * inferior.h (iterate_over_inferiors): Don't declare.
 898         * inferior.c (iterate_over_inferiors): Remove.
 899         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
 900         Remove.
 901         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
 902         use iterate_over_inferiors.
 903         (darwin_resume_inferior_it)
 904         (struct resume_inferior_threads_param)
 905         (darwin_resume_inferior_threads_it): Remove.
 906         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
 907
 908 2020-04-23  Tom de Vries  <tdevries@suse.de>
 909
 910         * blockframe.c (find_pc_partial_function): Use
 911         find_pc_sect_compunit_symtab rather than
 912         objfile->sf->qf->find_pc_sect_compunit_symtab.
 913
 914 2020-04-22  Tom de Vries  <tdevries@suse.de>
 915
 916         PR symtab/25764
 917         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
 918         in psymtabs.
 919
 920 2020-04-22  Tom de Vries  <tdevries@suse.de>
 921
 922         PR symtab/25801
 923         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
 924         symtabs.
 925
 926 2020-04-22  Tom de Vries  <tdevries@suse.de>
 927
 928         PR symtab/25700
 929         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
 930         CU if already created.
 931
 932 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 933
 934         * infrun.c (displaced_step_fixup): Switch to the event_thread
 935         before calling displaced_step_restore, not after.
 936
 937 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 938
 939         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
 940         its inferior is not recorded by us.
 941         (record_btrace_target_open): Replace call to
 942         all_non_exited_threads () with call to current_inferior
 943         ()->non_exited_threads ().
 944         (record_btrace_target::stop_recording): Likewise.
 945         (record_btrace_target::close): Likewise.
 946         (record_btrace_target::wait): Likewise.
 947         (record_btrace_target::record_stop_replaying): Likewise.
 948
 949 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 950
 951         * btrace.c (btrace_enable): Throw an error on double enables and
 952         when enabling recording fails.
 953         (btrace_disable): Throw an error if the thread is not recorded.
 954
 955 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 956
 957         * record-btrace.c (record_btrace_target::fetch_registers): Forward
 958         request if we do not have a thread_info.
 959
 960 2020-04-21  Tom de Vries  <tdevries@suse.de>
 961
 962         PR gdb/25471
 963         * thread.c
 964         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
 965         exception in get_frame_id.
 966
 967 2020-04-20  Tom Tromey  <tromey@adacore.com>
 968
 969         * python/python.c (struct gdbpy_event): Mark move constructor as
 970         noexcept.
 971         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
 972         constructor as noexcept.
 973         * completer.h (struct completion_result): Mark move constructor as
 974         noexcept.
 975         * completer.c (completion_result::completion_result): Use
 976         initialization style.  Don't call reset_match_list.
 977
 978 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
 979
 980         * MAINTAINERS (Write After Approval): Add myself.
 981
 982 2020-04-18  Tom Tromey  <tom@tromey.com>
 983
 984         * windows-tdep.c (init_w32_command_list)
 985         (w32_prefix_command_valid): Restore.
 986         (_initialize_windows_tdep): Call init_w32_command_list.
 987
 988 2020-04-18  Tom Tromey  <tom@tromey.com>
 989
 990         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
 991         * value.c (value_fn_field): Update.
 992         * valops.c (find_function_in_inferior)
 993         (value_allocate_space_in_inferior): Update.
 994         * tui/tui-winsource.c (tui_update_source_windows_with_line):
 995         Update.
 996         * tui/tui-source.c (tui_source_window::set_contents): Update.
 997         * symtab.c (lookup_global_or_static_symbol)
 998         (find_function_start_sal_1, skip_prologue_sal)
 999         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
1000         * symmisc.c (dump_msymbols, dump_symtab_1)
1001         (maintenance_print_one_line_table): Update.
1002         * symfile.c (init_entry_point_info, section_is_mapped)
1003         (list_overlays_command, simple_read_overlay_table)
1004         (simple_overlay_update_1): Update.
1005         * stap-probe.c (handle_stap_probe): Update.
1006         * stabsread.c (dbx_init_float_type, define_symbol)
1007         (read_one_struct_field, read_enum_type, read_range_type): Update.
1008         * source.c (info_line_command): Update.
1009         * python/python.c (gdbpy_source_objfile_script)
1010         (gdbpy_execute_objfile_script): Update.
1011         * python/py-type.c (save_objfile_types): Update.
1012         * python/py-objfile.c (py_free_objfile): Update.
1013         * python/py-inferior.c (python_new_objfile): Update.
1014         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
1015         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
1016         (maintenance_check_psymtabs): Update.
1017         * printcmd.c (info_address_command): Update.
1018         * objfiles.h (struct objfile) <arch>: New method, from
1019         get_objfile_arch.
1020         (get_objfile_arch): Don't declare.
1021         * objfiles.c (get_objfile_arch): Remove.
1022         (filter_overlapping_sections): Update.
1023         * minsyms.c (msymbol_is_function): Update.
1024         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
1025         (output_nondebug_symbol): Update.
1026         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
1027         (mdebug_expand_psymtab): Update.
1028         * machoread.c (macho_add_oso_symfile): Update.
1029         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
1030         Update.
1031         * linux-fork.c (checkpoint_command): Update.
1032         * linespec.c (convert_linespec_to_sals): Update.
1033         * jit.c (finalize_symtab): Update.
1034         * infrun.c (insert_exception_resume_from_probe): Update.
1035         * ia64-tdep.c (ia64_find_unwind_table): Update.
1036         * hppa-tdep.c (internalize_unwinds): Update.
1037         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
1038         Update.
1039         * gcore.c (call_target_sbrk): Update.
1040         * elfread.c (record_minimal_symbol, elf_symtab_read)
1041         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
1042         (elf_gnu_ifunc_resolve_by_got): Update.
1043         * dwarf2/read.c (create_addrmap_from_index)
1044         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1045         (read_debug_names_from_section)
1046         (process_psymtab_comp_unit_reader, add_partial_symbol)
1047         (add_partial_subprogram, process_full_comp_unit)
1048         (read_file_scope, read_func_scope, read_lexical_block_scope)
1049         (read_call_site_scope, dwarf2_ranges_read)
1050         (dwarf2_record_block_ranges, dwarf2_add_field)
1051         (mark_common_block_symbol_computed, read_tag_pointer_type)
1052         (read_tag_string_type, dwarf2_init_float_type)
1053         (dwarf2_init_complex_target_type, read_base_type)
1054         (partial_die_info::read, partial_die_info::read)
1055         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
1056         (dwarf2_fetch_die_loc_sect_off): Update.
1057         * dwarf2/loc.c (dwarf2_find_location_expression)
1058         (class dwarf_evaluate_loc_desc, rw_pieced_value)
1059         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
1060         (dwarf2_loc_desc_get_symbol_read_needs)
1061         (locexpr_describe_location_piece, locexpr_describe_location_1)
1062         (loclist_describe_location): Update.
1063         * dwarf2/index-write.c (write_debug_names): Update.
1064         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
1065         * dtrace-probe.c (dtrace_process_dof): Update.
1066         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
1067         (process_one_symbol): Update.
1068         * ctfread.c (ctf_init_float_type, read_base_type): Update.
1069         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
1070         (coff_read_enum_type): Update.
1071         * cli/cli-cmds.c (edit_command, list_command): Update.
1072         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
1073         * breakpoint.c (create_overlay_event_breakpoint)
1074         (create_longjmp_master_breakpoint)
1075         (create_std_terminate_master_breakpoint)
1076         (create_exception_master_breakpoint, get_sal_arch): Update.
1077         * block.c (block_gdbarch): Update.
1078         * annotate.c (annotate_source_line): Update.
1079
1080 2020-04-17  Tom Tromey  <tromey@adacore.com>
1081
1082         * auto-load.c (show_auto_load_cmd): Remove.
1083         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
1084         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
1085         (maintenance_print_arc_command): Remove.
1086         * tui/tui-win.c (tui_command): Remove.
1087         (tui_get_cmd_list): Use add_basic_prefix_cmd.
1088         * tui/tui-layout.c (tui_layout_command): Remove.
1089         (_initialize_tui_layout): Use add_basic_prefix_cmd.
1090         * python/python.c (user_set_python, user_show_python): Remove.
1091         (_initialize_python): Use add_basic_prefix_cmd,
1092         add_show_prefix_cmd.
1093         * guile/guile.c (set_guile_command, show_guile_command): Remove.
1094         (install_gdb_commands): Use add_basic_prefix_cmd,
1095         add_show_prefix_cmd.
1096         (info_guile_command): Remove.
1097         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
1098         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
1099         add_show_prefix_cmd.
1100         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1101         Remove do_set and do_show parameters.
1102         * cli/cli-style.c (set_style, show_style): Remove.
1103         (_initialize_cli_style): Use add_basic_prefix_cmd,
1104         add_show_prefix_cmd.
1105         (cli_style_option::add_setshow_commands): Remove do_set and
1106         do_show parameters.
1107         (cli_style_option::add_setshow_commands): Use
1108         add_basic_prefix_cmd, add_show_prefix_cmd.
1109         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
1110         (set_style_name): Remove.
1111         * cli/cli-dump.c (dump_command, append_command): Remove.
1112         (srec_dump_command, ihex_dump_command, verilog_dump_command)
1113         (tekhex_dump_command, binary_dump_command)
1114         (binary_append_command): Remove.
1115         (_initialize_cli_dump): Use add_basic_prefix_cmd.
1116         * windows-tdep.c (w32_prefix_command_valid): Remove global.
1117         (init_w32_command_list): Remove; move into ...
1118         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
1119         * valprint.c (set_print, show_print, set_print_raw)
1120         (show_print_raw): Remove.
1121         (_initialize_valprint): Use add_basic_prefix_cmd,
1122         add_show_prefix_cmd.
1123         * typeprint.c (set_print_type, show_print_type): Remove.
1124         (_initialize_typeprint): Use add_basic_prefix_cmd,
1125         add_show_prefix_cmd.
1126         * record.c (set_record_command, show_record_command): Remove.
1127         (_initialize_record): Use add_basic_prefix_cmd,
1128         add_show_prefix_cmd.
1129         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
1130         add_show_prefix_cmd.
1131         (info_command, show_command, set_debug, show_debug): Remove.
1132         * top.h (set_history, show_history): Don't declare.
1133         * top.c (set_history, show_history): Remove.
1134         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
1135         (unset_tdesc_cmd): Remove.
1136         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
1137         add_show_prefix_cmd.
1138         * symtab.c (info_module_command): Remove.
1139         (_initialize_symtab): Use add_basic_prefix_cmd.
1140         * symfile.c (overlay_command): Remove.
1141         (_initialize_symfile): Use add_basic_prefix_cmd.
1142         * sparc64-tdep.c (info_adi_command): Remove.
1143         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
1144         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
1145         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
1146         add_show_prefix_cmd.
1147         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
1148         (_initialize_serial): Use add_basic_prefix_cmd,
1149         add_show_prefix_cmd.
1150         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
1151         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
1152         add_show_prefix_cmd.
1153         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
1154         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
1155         add_show_prefix_cmd.
1156         * riscv-tdep.c (show_riscv_command, set_riscv_command)
1157         (show_debug_riscv_command, set_debug_riscv_command): Remove.
1158         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
1159         add_show_prefix_cmd.
1160         * remote.c (remote_command, set_remote_cmd): Remove.
1161         (_initialize_remote): Use add_basic_prefix_cmd.
1162         * record-full.c (set_record_full_command)
1163         (show_record_full_command): Remove.
1164         (_initialize_record_full): Use add_basic_prefix_cmd,
1165         add_show_prefix_cmd.
1166         * record-btrace.c (cmd_set_record_btrace)
1167         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
1168         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
1169         (cmd_show_record_btrace_pt): Remove.
1170         (_initialize_record_btrace): Use add_basic_prefix_cmd,
1171         add_show_prefix_cmd.
1172         * ravenscar-thread.c (set_ravenscar_command)
1173         (show_ravenscar_command): Remove.
1174         (_initialize_ravenscar): Use add_basic_prefix_cmd,
1175         add_show_prefix_cmd.
1176         * mips-tdep.c (show_mips_command, set_mips_command)
1177         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
1178         add_show_prefix_cmd.
1179         * maint.c (maintenance_command, maintenance_info_command)
1180         (maintenance_check_command, maintenance_print_command)
1181         (maintenance_set_cmd, maintenance_show_cmd): Remove.
1182         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
1183         add_show_prefix_cmd.
1184         (show_per_command_cmd): Remove.
1185         * maint-test-settings.c (maintenance_set_test_settings_cmd):
1186         Remove.
1187         (maintenance_show_test_settings_cmd): Remove.
1188         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
1189         add_show_prefix_cmd.
1190         * maint-test-options.c (maintenance_test_options_command):
1191         Remove.
1192         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
1193         * macrocmd.c (macro_command): Remove
1194         (_initialize_macrocmd): Use add_basic_prefix_cmd.
1195         * language.c (set_check, show_check): Remove.
1196         (_initialize_language): Use add_basic_prefix_cmd,
1197         add_show_prefix_cmd.
1198         * infcmd.c (unset_command): Remove.
1199         (_initialize_infcmd): Use add_basic_prefix_cmd.
1200         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
1201         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
1202         add_show_prefix_cmd.
1203         * go32-nat.c (go32_info_dos_command): Remove.
1204         (_initialize_go32_nat): Use add_basic_prefix_cmd.
1205         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
1206         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
1207         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
1208         (_initialize_frame): Use add_basic_prefix_cmd,
1209         add_show_prefix_cmd.
1210         * dcache.c (set_dcache_command, show_dcache_command): Remove.
1211         (_initialize_dcache): Use add_basic_prefix_cmd,
1212         add_show_prefix_cmd.
1213         * cp-support.c (maint_cplus_command): Remove.
1214         (_initialize_cp_support): Use add_basic_prefix_cmd.
1215         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
1216         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
1217         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
1218         add_basic_prefix_cmd, add_show_prefix_cmd.
1219         * breakpoint.c (save_command): Remove.
1220         (_initialize_breakpoint): Use add_basic_prefix_cmd.
1221         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
1222         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
1223         add_show_prefix_cmd.
1224         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
1225         (set_ada_command, show_ada_command): Remove.
1226         (_initialize_ada_language): Use add_basic_prefix_cmd,
1227         add_show_prefix_cmd.
1228         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
1229
1230 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
1231
1232         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
1233         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
1234
1235 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
1236
1237         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
1238         warning messages.
1239
1240 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
1241
1242         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
1243         import table is not at beginning of .idata section.
1244
1245 2020-04-16  Pedro Alves  <palves@redhat.com>
1246
1247         * inferior.c (delete_inferior): Use delete operator directly
1248         instead of delete_program_space.
1249         * progspace.c (add_program_space): New, factored out from
1250         program_space::program_space.
1251         (remove_program_space): New, factored out from
1252         delete_program_space.
1253         (program_space::program_space): Remove intro comment.  Rewrite.
1254         (program_space::~program_space): Remove intro comment.  Call
1255         remove_program_space.
1256         (delete_program_space): Delete.
1257         * progspace.h (program_space::program_space): Make explicit.  Move
1258         intro comment here, adjusted.
1259         (program_space::~program_space): Move intro comment here,
1260         adjusted.
1261         (delete_program_space): Remove.
1262
1263 2020-04-16  Tom Tromey  <tromey@adacore.com>
1264
1265         * windows-nat.c (windows_nat::handle_access_violation): New
1266         function.
1267         * nat/windows-nat.h (handle_access_violation): Declare.
1268         * nat/windows-nat.c (handle_exception): Move Cygwin code to
1269         windows-nat.c.  Call handle_access_violation.
1270
1271 2020-04-16  Tom de Vries  <tdevries@suse.de>
1272
1273         PR symtab/25791
1274         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
1275         CUs without psymtab.
1276
1277 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
1278
1279         * python/python.c (do_start_initialization): Don't call
1280         PyEval_InitThreads for Python 3.9 and beyond.
1281
1282 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
1283
1284         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
1285         thread functions.
1286         (obsd_nat_target::wait): Likewise.
1287
1288 2020-04-15  Tom Tromey  <tromey@adacore.com>
1289
1290         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
1291         (DEBUG_EXCEPT): Use debug_printf.
1292
1293 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1294
1295         * completer.c (class completion_tracker::completion_hash_entry)
1296         <hash_name>: New member function.
1297         (completion_tracker::discard_completions): New callback to hash a
1298         completion_hash_entry, pass this to htab_create_alloc.
1299
1300 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
1301
1302         * windows-nat.c (windows_make_so): Warn rather than stopping with
1303         an error if realpath() fails.
1304
1305 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
1306
1307         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
1308         (nbsd_nat_target::info_proc): Add do_status.
1309
1310 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
1311             Tom de Vries  <tdevries@suse.de>
1312
1313         PR symtab/25718
1314         * psympriv.h (struct partial_symtab::read_symtab)
1315         (struct partial_symtab::expand_psymtab)
1316         (struct partial_symtab::read_dependencies): Update comments.
1317         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
1318         read_symtab for includer.
1319         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
1320         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
1321         (struct dwarf2_include_psymtab::m_readin): Remove.
1322         (struct dwarf2_include_psymtab::includer): New member function.
1323         (dwarf2_psymtab::expand_psymtab): Assert !readin.
1324
1325 2020-04-14  Tom de Vries  <tdevries@suse.de>
1326
1327         PR symtab/25720
1328         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
1329         with NULL symbol_matcher and lookup_name.
1330         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
1331         and lookup_name.
1332         * dwarf2/read.c (dw2_expand_symtabs_matching)
1333         (dw2_debug_names_expand_symtabs_matching): Same.
1334         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
1335         Make lookup_name a pointer.  Update comment.
1336         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
1337         lookup_name being a pointer.
1338         * symfile.c (expand_symtabs_matching): Same.
1339         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
1340         * linespec.c (iterate_over_all_matching_symtabs): Same.
1341
1342 2020-04-13  Tom Tromey  <tom@tromey.com>
1343
1344         * run-on-main-thread.c: Update include.
1345         * unittests/main-thread-selftests.c: Update include.
1346         * tui/tui-win.c: Update include.
1347         * tui/tui-io.c: Update include.
1348         * tui/tui-interp.c: Update include.
1349         * tui/tui-hooks.c: Update include.
1350         * top.h: Update include.
1351         * top.c: Update include.
1352         * ser-base.c: Update include.
1353         * remote.c: Update include.
1354         * remote-notif.c: Update include.
1355         * remote-fileio.c: Update include.
1356         * record-full.c: Update include.
1357         * record-btrace.c: Update include.
1358         * python/python.c: Update include.
1359         * posix-hdep.c: Update include.
1360         * mingw-hdep.c: Update include.
1361         * mi/mi-main.c: Update include.
1362         * mi/mi-interp.c: Update include.
1363         * main.c: Update include.
1364         * linux-nat.c: Update include.
1365         * interps.c: Update include.
1366         * infrun.c: Update include.
1367         * inf-loop.c: Update include.
1368         * event-top.c: Update include.
1369         * event-loop.c: Move to ../gdbsupport/.
1370         * event-loop.h: Move to ../gdbsupport/.
1371         * async-event.h: Update include.
1372         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
1373
1374 2020-04-13  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-win.c: Include async-event.h.
1377         * remote.c: Include async-event.h.
1378         * remote-notif.c: Include async-event.h.
1379         * record-full.c: Include async-event.h.
1380         * record-btrace.c: Include async-event.h.
1381         * infrun.c: Include async-event.h.
1382         * event-top.c: Include async-event.h.
1383         * event-loop.h: Move some declarations to async-event.h.
1384         * event-loop.c: Don't include ser-event.h or top.h.  Move some
1385         code to async-event.c.
1386         * async-event.h: New file.
1387         * async-event.c: New file.
1388         * Makefile.in (COMMON_SFILES): Add async-event.c.
1389         (HFILES_NO_SRCDIR): Add async-event.h.
1390
1391 2020-04-13  Tom Tromey  <tom@tromey.com>
1392
1393         * utils.c (flush_streams): New function.
1394         * event-loop.c (gdb_wait_for_event): Call flush_streams.
1395
1396 2020-04-13  Tom Tromey  <tom@tromey.com>
1397
1398         * event-loop.c (handle_file_event): Use warning, not
1399         printf_unfiltered.
1400
1401 2020-04-13  Tom Tromey  <tom@tromey.com>
1402
1403         * event-loop.c: Include <chrono>.
1404
1405 2020-04-13  Tom Tromey  <tom@tromey.com>
1406
1407         * gdb_select.h: Move to ../gdbsupport/.
1408         * event-loop.c: Update include path.
1409         * top.c: Update include path.
1410         * ser-base.c: Update include path.
1411         * ui-file.c: Update include path.
1412         * ser-tcp.c: Update include path.
1413         * guile/scm-ports.c: Update include path.
1414         * posix-hdep.c: Update include path.
1415         * ser-unix.c: Update include path.
1416         * gdb_usleep.c: Update include path.
1417         * mingw-hdep.c: Update include path.
1418         * inflow.c: Update include path.
1419         * infrun.c: Update include path.
1420         * event-top.c: Update include path.
1421
1422 2020-04-13  Tom Tromey  <tom@tromey.com>
1423
1424         * configure: Rebuild.
1425         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
1426
1427 2020-04-13  Tom Tromey  <tom@tromey.com>
1428
1429         * event-loop.h (start_event_loop): Don't declare.
1430         * event-loop.c (start_event_loop): Move...
1431         * main.c (start_event_loop): ...here.  Now static.
1432
1433 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
1434
1435         * MAINTAINERS: Update my email address.
1436
1437 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1438
1439         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
1440         IP_ALL.
1441
1442 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1443
1444         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
1445         (nbsd_nat_target::info_proc): Add do_cmdline.
1446
1447 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1448
1449         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
1450         (nbsd_nat_target::info_proc): Add do_cwd.
1451
1452 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1453
1454         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
1455
1456 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
1457
1458         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
1459         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
1460         (nbsd_nat_target::info_proc): New functions.
1461         * nbsd-nat.c (kinfo_get_vmmap): New function.
1462         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
1463         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
1464         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
1465         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
1466         functions.
1467         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
1468         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
1469         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
1470         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
1471         (KINFO_VME_FLAG_GROWS_DOWN): New.
1472
1473 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
1474
1475         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
1476         bit shift.
1477
1478 2020-04-10  Tom Tromey  <tromey@adacore.com>
1479
1480         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
1481
1482 2020-04-10  Tom Tromey  <tromey@adacore.com>
1483
1484         * symtab.c (get_symbol_address, get_msymbol_address): Skip
1485         separate debug files.
1486
1487 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
1488
1489         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1490         Move to...
1491         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1492         ... here.
1493         * windows-nat.c (windows_nat_target::get_windows_debug_event):
1494         Check for STATUS_WX86_BREAKPOINT.
1495         (windows_nat_target::wait): Same.
1496
1497 2020-04-10  Tom de Vries  <tdevries@suse.de>
1498
1499         PR cli/25808
1500         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
1501
1502 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
1503
1504         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
1505         (Write After Approval): Remove Tom de Vries.
1506
1507 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1508
1509         revert partially:
1510         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1511
1512         * buildsym.c (record_line): Fix undefined behavior and preserve
1513         lines at eof.
1514
1515 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
1516
1517         * auxv.h (svr4_auxv_parse): New.
1518         * auxv.c (default_auxv_parse): Split into default_auxv_parse
1519         and generic_auxv_parse.
1520         (svr4_auxv_parse): Add.
1521         * obsd-tdep.c: Include "auxv.h".
1522         (obsd_auxv_parse): Remove.
1523         (obsd_init_abi): Remove comment.
1524         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
1525         from `obsd_auxv_parse' to `svr4_auxv_parse'.
1526         * nbsd-tdep.c: Include "auxv.h".
1527         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
1528
1529 2020-04-08  Tom Tromey  <tromey@adacore.com>
1530
1531         * nat/windows-nat.h (last_wait_event): Don't declare.
1532         (wait_for_debug_event): Update comment.
1533         * nat/windows-nat.c (last_wait_event): Now static.
1534
1535 2020-04-08  Tom Tromey  <tromey@adacore.com>
1536
1537         * windows-nat.c (wait_for_debug_event): Move to
1538         nat/windows-nat.c.
1539         * nat/windows-nat.h (wait_for_debug_event): Declare.
1540         * nat/windows-nat.c (wait_for_debug_event): Move from
1541         windows-nat.c.  No longer static.
1542
1543 2020-04-08  Tom Tromey  <tromey@adacore.com>
1544
1545         * windows-nat.c (get_windows_debug_event): Use
1546         fetch_pending_stop.
1547         * nat/windows-nat.h (fetch_pending_stop): Declare.
1548         * nat/windows-nat.c (fetch_pending_stop): New function.
1549
1550 2020-04-08  Tom Tromey  <tromey@adacore.com>
1551
1552         * windows-nat.c (windows_continue): Use matching_pending_stop and
1553         continue_last_debug_event.
1554         * nat/windows-nat.h (matching_pending_stop)
1555         (continue_last_debug_event): Declare.
1556         * nat/windows-nat.c (DEBUG_EVENTS): New define.
1557         (matching_pending_stop, continue_last_debug_event): New
1558         functions.
1559
1560 2020-04-08  Tom Tromey  <tromey@adacore.com>
1561
1562         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
1563         (handle_exception_result): Move to nat/windows-nat.h.
1564         (DEBUG_EXCEPTION_SIMPLE): Remove.
1565         (windows_nat::handle_ms_vc_exception): New function.
1566         (handle_exception): Move to nat/windows-nat.c.
1567         (get_windows_debug_event): Update.
1568         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
1569         nat/windows-nat.c.
1570         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
1571         (handle_exception_result): Move from windows-nat.c.
1572         (handle_exception): Declare.
1573         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
1574         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
1575         windows-nat.c.
1576
1577 2020-04-08  Tom Tromey  <tromey@adacore.com>
1578
1579         * windows-nat.c (exception_count, event_count): Remove.
1580         (handle_exception, get_windows_debug_event)
1581         (do_initial_windows_stuff): Update.
1582
1583 2020-04-08  Tom Tromey  <tromey@adacore.com>
1584
1585         * windows-nat.c (windows_nat::handle_load_dll)
1586         (windows_nat::handle_unload_dll): Rename.  No longer static.
1587         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
1588         Declare.
1589
1590 2020-04-08  Tom Tromey  <tromey@adacore.com>
1591
1592         * complaints.h (stop_whining): Declare at top-level.
1593         (complaint): Don't declare stop_whining.
1594
1595 2020-04-08  Tom Tromey  <tromey@adacore.com>
1596
1597         * windows-nat.c (windows_nat::handle_output_debug_string):
1598         Rename.  No longer static.
1599         * nat/windows-nat.h (handle_output_debug_string): Declare.
1600
1601 2020-04-08  Tom Tromey  <tromey@adacore.com>
1602
1603         * windows-nat.c (current_process_handle, current_process_id)
1604         (main_thread_id, last_sig, current_event, last_wait_event)
1605         (current_windows_thread, desired_stop_thread_id, pending_stops)
1606         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
1607         (display_selectors, fake_create_process)
1608         (get_windows_debug_event): Update.
1609         * nat/windows-nat.h (current_process_handle, current_process_id)
1610         (main_thread_id, last_sig, current_event, last_wait_event)
1611         (current_windows_thread, desired_stop_thread_id, pending_stops)
1612         (struct pending_stop, siginfo_er): Move from windows-nat.c.
1613         * nat/windows-nat.c (current_process_handle, current_process_id)
1614         (main_thread_id, last_sig, current_event, last_wait_event)
1615         (current_windows_thread, desired_stop_thread_id, pending_stops)
1616         (siginfo_er): New globals.  Move from windows-nat.c.
1617
1618 2020-04-08  Tom Tromey  <tromey@adacore.com>
1619
1620         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
1621         (handle_load_dll): Update.
1622         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
1623
1624 2020-04-08  Tom Tromey  <tromey@adacore.com>
1625
1626         * windows-nat.c (enum thread_disposition_type): Move to
1627         nat/windows-nat.h.
1628         (windows_nat::thread_rec): Rename from thread_rec.  No longer
1629         static.
1630         (windows_add_thread, windows_nat_target::fetch_registers)
1631         (windows_nat_target::store_registers, handle_exception)
1632         (windows_nat_target::resume, get_windows_debug_event)
1633         (windows_nat_target::get_tib_address)
1634         (windows_nat_target::thread_name)
1635         (windows_nat_target::thread_alive): Update.
1636         * nat/windows-nat.h (enum thread_disposition_type): Move from
1637         windows-nat.c.
1638         (thread_rec): Declare.
1639
1640 2020-04-08  Tom Tromey  <tromey@adacore.com>
1641
1642         * windows-nat.c: Add "using namespace".
1643         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
1644         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
1645
1646 2020-04-08  Tom Tromey  <tromey@adacore.com>
1647
1648         * nat/windows-nat.h (struct windows_thread_info): Declare
1649         destructor.
1650         * nat/windows-nat.c (~windows_thread_info): New.
1651
1652 2020-04-08  Tom Tromey  <tromey@adacore.com>
1653
1654         PR gdb/22992
1655         * windows-nat.c (current_event): Update comment.
1656         (last_wait_event, desired_stop_thread_id): New globals.
1657         (struct pending_stop): New.
1658         (pending_stops): New global.
1659         (windows_nat_target) <stopped_by_sw_breakpoint>
1660         <supports_stopped_by_sw_breakpoint>: New methods.
1661         (windows_fetch_one_register): Add assertions.  Adjust PC.
1662         (windows_continue): Handle pending stops.  Suspend other threads
1663         when stepping.  Use last_wait_event
1664         (wait_for_debug_event): New function.
1665         (get_windows_debug_event): Use wait_for_debug_event.  Handle
1666         pending stops.  Queue spurious stops.
1667         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
1668         (windows_nat_target::kill): Use wait_for_debug_event.
1669         * nat/windows-nat.h (struct windows_thread_info)
1670         <stopped_at_software_breakpoint>: New field.
1671         * nat/windows-nat.c (windows_thread_info::resume): Clear
1672         stopped_at_software_breakpoint.
1673
1674 2020-04-08  Tom Tromey  <tromey@adacore.com>
1675
1676         * windows-nat.c (enum thread_disposition_type): New.
1677         (thread_rec): Replace "get_context" parameter with "disposition";
1678         change type.
1679         (windows_add_thread, windows_nat_target::fetch_registers)
1680         (windows_nat_target::store_registers, handle_exception)
1681         (windows_nat_target::resume, get_windows_debug_event)
1682         (windows_nat_target::get_tib_address)
1683         (windows_nat_target::thread_name)
1684         (windows_nat_target::thread_alive): Update.
1685
1686 2020-04-08  Tom Tromey  <tromey@adacore.com>
1687
1688         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
1689         (windows_continue): Use windows_continue::resume.
1690         * nat/windows-nat.h (struct windows_thread_info) <suspend,
1691         resume>: Declare new methods.
1692         * nat/windows-nat.c: New file.
1693         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
1694
1695 2020-04-08  Tom Tromey  <tromey@adacore.com>
1696
1697         * windows-nat.c (windows_add_thread, windows_delete_thread)
1698         (windows_nat_target::fetch_registers)
1699         (windows_nat_target::store_registers, fake_create_process)
1700         (windows_nat_target::resume, windows_nat_target::resume)
1701         (get_windows_debug_event, windows_nat_target::wait)
1702         (windows_nat_target::pid_to_str)
1703         (windows_nat_target::get_tib_address)
1704         (windows_nat_target::get_ada_task_ptid)
1705         (windows_nat_target::thread_name)
1706         (windows_nat_target::thread_alive): Use lwp, not tid.
1707
1708 2020-04-08  Tom Tromey  <tromey@adacore.com>
1709
1710         * windows-nat.c (handle_exception)
1711         (windows_nat_target::thread_name): Update.
1712         * nat/windows-nat.h (windows_thread_info): Remove destructor.
1713         <name>: Now unique_xmalloc_ptr.
1714
1715 2020-04-08  Tom Tromey  <tromey@adacore.com>
1716
1717         * windows-nat.c (thread_rec)
1718         (windows_nat_target::fetch_registers): Update.
1719         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
1720         Update comment.
1721         <debug_registers_changed, reload_context>: Now bool.
1722
1723 2020-04-08  Tom Tromey  <tromey@adacore.com>
1724
1725         * windows-nat.c (windows_add_thread): Use new.
1726         (windows_init_thread_list, windows_delete_thread): Use delete.
1727         (get_windows_debug_event): Update.
1728         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
1729         destructor, and initializers.
1730
1731 2020-04-08  Tom Tromey  <tromey@adacore.com>
1732
1733         * windows-nat.c (struct windows_thread_info): Remove.
1734         * nat/windows-nat.h: New file.
1735
1736 2020-04-08  Tom Tromey  <tromey@adacore.com>
1737
1738         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
1739         (thread_rec, windows_add_thread, windows_delete_thread)
1740         (windows_continue): Update.
1741
1742 2020-04-08  Tom Tromey  <tromey@adacore.com>
1743
1744         * windows-nat.c (struct windows_thread_info): Remove typedef.
1745         (thread_head): Remove.
1746         (thread_list): New global.
1747         (thread_rec, windows_add_thread, windows_init_thread_list)
1748         (windows_delete_thread, windows_continue): Update.
1749
1750 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1751
1752         * windows-tdep.h (windows_init_abi): Add comment.
1753         (cygwin_init_abi): New declaration.
1754         * windows-tdep.c: Split signal enumeration in two, one for
1755         Windows and one for Cygwin.
1756         (windows_gdb_signal_to_target): Only deal with signal of the
1757         Windows OS ABI.
1758         (cygwin_gdb_signal_to_target): New function.
1759         (windows_init_abi): Rename to windows_init_abi_common, don't set
1760         gdb_signal_to_target gdbarch method.  Add new new function with
1761         this name.
1762         (cygwin_init_abi): New function.
1763         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
1764         comment.  Don't call windows_init_abi.
1765         (amd64_windows_init_abi): Add comment, call windows_init_abi.
1766         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
1767         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
1768         i386_windows_init_abi_common, don't call windows_init_abi.  Add
1769         a new function of this name.
1770         (i386_cygwin_init_abi): New function.
1771         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
1772         OS ABI Cygwin.
1773
1774 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1775
1776         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
1777         parameter.c.
1778         (dwarf2_read_gdb_index): Update.
1779
1780 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
1781
1782         * nbsd-tdep.c: Include "objfiles.h".
1783         (nbsd_skip_solib_resolver): New.
1784         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
1785
1786 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1787
1788         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
1789         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
1790         with DW_LLE_base_addressx are being emitted in DWARFv5.
1791         Add the newly added kind DW_LOC_OFFSET_PAIR also.
1792         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
1793         unsigned integer.
1794
1795 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1796
1797         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
1798         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
1799         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
1800         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
1801         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
1802         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
1803         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
1804
1805
1806 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1807
1808         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
1809         (read_loclist_index): New function definition.
1810         (lookup_loclist_base): New function definition.
1811         (read_loclist_header): New function definition.
1812         (dwarf2_cu): Add loclist_base and loclist_header field.
1813         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
1814         (read_full_die_1): Read the value of DW_AT_loclists_base.
1815         (read_attribute_reprocess): Handle DW_FORM_loclistx.
1816         (read_attribute_value): Handle DW_FORM_loclistx.
1817         (skip_one_die): Handle DW_FORM_loclistx.
1818         (loclist_header): New structure declaration.
1819         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
1820
1821 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1822
1823         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
1824         constructor.  Remove `addr` parameter from other constructor and
1825         add `per_cu` parameter.
1826         * dwarf2/read.c (create_partial_symtab): Update.
1827
1828 2020-04-07  Tom de Vries  <tdevries@suse.de>
1829
1830         PR symtab/25796
1831         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
1832         (partial_die_info::fixup): Inherit has_const_value.
1833
1834 2020-04-07  Tom de Vries  <tdevries@suse.de>
1835
1836         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
1837         symbols without address.
1838
1839 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1840
1841         * nbsd-nat.h (struct thread_info): Add forward declaration.
1842         (nbsd_nat_target::thread_alive): Add.
1843         (nbsd_nat_target::thread_name): Likewise.
1844         (nbsd_nat_target::update_thread_list): Likewise.
1845         (update_thread_list::post_attach): Likewise.
1846         (post_attach::pid_to_str): Likewise.
1847         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
1848         (nbsd_thread_lister): Add.
1849         (nbsd_nat_target::thread_alive): Likewise.
1850         (nbsd_nat_target::thread_name): Likewise.
1851         (nbsd_add_threads): Likewise.
1852         (update_thread_list::post_attach): Likewise.
1853         (nbsd_nat_target::update_thread_list): Likewise.
1854         (post_attach::pid_to_str): Likewise.
1855
1856 2020-04-06  Tom Tromey  <tromey@adacore.com>
1857
1858         * ada-valprint.c (print_variant_part): Extract the variant field.
1859         (print_field_values): Use the field as the outer value when
1860         recursing.
1861
1862 2020-04-06  Tom Tromey  <tromey@adacore.com>
1863
1864         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
1865         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
1866         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
1867         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
1868         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
1869
1870 2020-04-06  Tom Tromey  <tromey@adacore.com>
1871
1872         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
1873         TYPE_CODE_ERROR.
1874
1875 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1876
1877         * nbsd-tdep.c: Include "gdbarch.h".
1878         Define enum with NetBSD signal numbers.
1879         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
1880         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
1881         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
1882         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
1883         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
1884         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
1885         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
1886         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
1887         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
1888         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
1889         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
1890         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
1891
1892 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
1893
1894         PR gdb/25325
1895         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
1896
1897 2020-04-03  Tom Tromey  <tromey@adacore.com>
1898
1899         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
1900         Read constant block.
1901
1902 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1903
1904         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
1905         (gdb_bfd_get_full_section_contents): New declaration.
1906         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
1907         * windows-tdep.c (is_linked_with_cygwin_dll): Use
1908         gdb_bfd_get_full_section_contents.
1909
1910 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1911
1912         * exec.c (build_section_table): Replace internal_error with
1913         gdb_assert.
1914         (section_table_xfer_memory_partial): Likewise.
1915         * mdebugread.c (parse_partial_symbols): Likewise.
1916         * psymtab.c (lookup_partial_symbol): Likewise.
1917         * utils.c (wrap_here): Likewise.
1918
1919 2020-04-02  Tom Tromey  <tromey@adacore.com>
1920
1921         * f-lang.c (build_fortran_types): Use arch_type to initialize
1922         builtin_complex_s32 in the TYPE_CODE_ERROR case.
1923
1924 2020-04-02  Tom Tromey  <tromey@adacore.com>
1925
1926         * dwarf2/read.c (partial_die_info::read): Do not create a vector
1927         of attributes.
1928
1929 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1930             Bernd Edlinger <bernd.edlinger@hotmail.de>
1931             Tom Tromey  <tromey@adacore.com>
1932
1933         * buildsym.c (buildsym_compunit::record_line): Remove
1934         deduplication code.
1935
1936 2020-04-02  Tom de Vries  <tdevries@suse.de>
1937
1938         PR ada/24671
1939         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
1940
1941 2020-04-02  Tom de Vries  <tdevries@suse.de>
1942
1943         * dwarf2/read.c (dwarf2_gdb_index_functions,
1944         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
1945         NULL.
1946         * psymtab.c (psym_lookup_global_symbol_language): New function.
1947         (psym_functions): Init psym_lookup_global_symbol_language with
1948         psym_lookup_global_symbol_language.
1949         * symfile-debug.c (debug_sym_quick_functions): Init
1950         lookup_global_symbol_language with NULL.
1951         * symfile.c (set_initial_language): Remove fixme comment.
1952         * symfile.h (struct quick_symbol_functions): Add
1953         lookup_global_symbol_language.
1954         * symtab.c (find_quick_global_symbol_language): New function.
1955         (find_main_name): Use find_quick_global_symbol_language.
1956
1957 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
1958
1959         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
1960
1961 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1962
1963         * buildsym.c (record_line): Fix undefined behavior and preserve
1964         lines at eof.
1965
1966 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1967
1968         * buildsym.c (record_line): Fix the resizing condition.
1969
1970 2020-04-01  Tom Tromey  <tom@tromey.com>
1971
1972         * value.h (value_literal_complex): Add comment.
1973         * valops.c (value_literal_complex): Refer to value.h.
1974
1975 2020-04-01  Tom Tromey  <tom@tromey.com>
1976
1977         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
1978         (scalar_type): New rule, from typebase.
1979         (typebase): Use scalar_type.  Recognize complex types.
1980         (field_name): Handle FLOAT_KEYWORD.
1981         (ident_tokens): Add _Complex and __complex__.
1982
1983 2020-04-01  Tom Tromey  <tom@tromey.com>
1984
1985         PR exp/25299:
1986         * valarith.c (promotion_type, complex_binop): New functions.
1987         (scalar_binop): Handle complex numbers.  Use promotion_type.
1988         (value_pos, value_neg, value_complement): Handle complex numbers.
1989
1990 2020-04-01  Tom Tromey  <tom@tromey.com>
1991
1992         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
1993         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
1994         (parse_number): Handle complex numbers.
1995
1996 2020-04-01  Tom Tromey  <tom@tromey.com>
1997
1998         * c-valprint.c (c_decorations): Change complex suffix to "i".
1999
2000 2020-04-01  Tom Tromey  <tom@tromey.com>
2001
2002         * valprint.c (generic_value_print_complex): Use accessors.
2003         * value.h (value_real_part, value_imaginary_part): Declare.
2004         * valops.c (value_real_part, value_imaginary_part): New
2005         functions.
2006         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
2007
2008 2020-04-01  Tom Tromey  <tom@tromey.com>
2009
2010         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
2011         (read_range_type): Update.
2012         * mdebugread.c (basic_type): Update.
2013         * go-lang.c (build_go_types): Use init_complex_type.
2014         * gdbtypes.h (struct main_type) <complex_type>: New member.
2015         (init_complex_type): Update.
2016         (arch_complex_type): Don't declare.
2017         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
2018         Make name if none given.  Use alloc_type_copy.  Look for cached
2019         complex type.
2020         (arch_complex_type): Remove.
2021         (gdbtypes_post_init): Use init_complex_type.
2022         * f-lang.c (build_fortran_types): Use init_complex_type.
2023         * dwarf2/read.c (read_base_type): Update.
2024         * d-lang.c (build_d_types): Use init_complex_type.
2025         * ctfread.c (read_base_type): Update.
2026
2027 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2028
2029         * infrun.c (stop_all_threads): Update assertion, plus when
2030         stopping threads, take into account that we might be trying
2031         to stop an all-stop target.
2032         (stop_waiting): Call 'stop_all_threads' if there exists a
2033         non-stop target.
2034
2035 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2036
2037         * target.h (exists_non_stop_target): New function declaration.
2038         * target.c (exists_non_stop_target): New function.
2039
2040 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
2041
2042         PR gdb/24789
2043         * eval.c (is_integral_or_integral_reference): New function.
2044         (evaluate_subexp_standard): Allow integer references in
2045         pointer arithmetic.
2046
2047 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2048
2049         * remote.c (remote_target::remote_parse_stop_reply): Remove the
2050         check for no ptid in the stop reply when the target is non-stop.
2051
2052 2020-04-01  Tom Tromey  <tromey@adacore.com>
2053
2054         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
2055         "name" parameter to rvalue reference.  Initialize m_name_holder.
2056         <lookup_name_info>: New overloads.
2057         <name>: Return gdb::string_view.
2058         <c_str>: New method.
2059         <make_ignore_params>: Update.
2060         <search_name_hash>: Update.
2061         <language_lookup_name>: Return const char *.
2062         <m_name>: Change type.
2063         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
2064         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
2065         (lookup_name_info::match_any): Update.
2066         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
2067         Update.
2068         * minsyms.c (linkage_name_str): Update.
2069         * language.c (default_symbol_name_matcher): Update.
2070         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
2071         Update.
2072         * ada-lang.c (ada_fold_name): Change parameter to string_view.
2073         (ada_lookup_name_info::ada_lookup_name_info): Update.
2074         (literal_symbol_name_matcher): Update.
2075
2076 2020-04-01  Tom Tromey  <tromey@adacore.com>
2077
2078         * psymtab.c (psymtab_search_name): Remove function.
2079         (psym_lookup_symbol): Create search name and lookup name here.
2080         (lookup_partial_symbol): Remove "name" parameter; add
2081         lookup_name.
2082         (psym_expand_symtabs_for_function): Update.
2083
2084 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
2085
2086         PR tui/25597:
2087         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
2088
2089 2020-03-31  Tom Tromey  <tromey@adacore.com>
2090
2091         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
2092         memcpy.
2093
2094 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
2095
2096         * features/riscv/32bit-csr.xml: Regenerated.
2097         * features/riscv/64bit-csr.xml: Regenerated.
2098
2099 2020-03-30  Tom Tromey  <tromey@adacore.com>
2100
2101         * ada-valprint.c (print_variant_part): Update.
2102         * ada-lang.h (ada_which_variant_applies): Update.
2103         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
2104         outer_valaddr parameters; replace with "outer" value parameter.
2105         (to_fixed_variant_branch_type): Update.
2106
2107 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2108
2109         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
2110         <list>.  Remove inclusion of observable.h.
2111         (PPC_DEBUG_CURRENT_VERSION): Move up define.
2112         (struct arch_lwp_info): New struct.
2113         (class ppc_linux_dreg_interface): New class.
2114         (struct ppc_linux_process_info): New struct.
2115         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
2116         <low_new_clone, low_forget_process, low_prepare_to_resume>
2117         <copy_thread_dreg_state, mark_thread_stale>
2118         <mark_debug_registers_changed, register_hw_breakpoint>
2119         <clear_hw_breakpoint, register_wp, clear_wp>
2120         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
2121         <num_memory_accesses, get_trigger_type>
2122         <create_watchpoint_request, hwdebug_point_cmp>
2123         <init_arch_lwp_info, get_arch_lwp_info>
2124         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
2125         methods.
2126         <struct ptid_hash>: New inner struct.
2127         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
2128         members.
2129         (saved_dabr_value, hwdebug_info, max_slots_number)
2130         (struct hw_break_tuple, struct thread_points, ppc_threads)
2131         (have_ptrace_hwdebug_interface)
2132         (hwdebug_find_thread_points_by_tid)
2133         (hwdebug_insert_point, hwdebug_remove_point): Remove.
2134         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
2135         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
2136         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
2137         use m_dreg_interface.
2138         (hwdebug_point_cmp): Change to...
2139         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
2140         reference arguments instead of pointers.
2141         (ppc_linux_nat_target::ranged_break_num_registers): Use
2142         m_dreg_interface.
2143         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
2144         m_dreg_interface.  Call register_hw_breakpoint.
2145         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
2146         m_dreg_interface.  Call clear_hw_breakpoint.
2147         (get_trigger_type): Change to...
2148         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
2149         comment.
2150         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
2151         use m_dreg_interface.  Call register_hw_breakpoint.
2152         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
2153         use m_dreg_interface.  Call clear_hw_breakpoint.
2154         (can_use_watchpoint_cond_accel): Change to...
2155         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
2156         method.  Update comment, use m_dreg_interface and
2157         m_process_info.
2158         (calculate_dvc): Change to...
2159         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
2160         m_dreg_interface.
2161         (num_memory_accesses): Change to...
2162         (ppc_linux_nat_target::num_memory_accesses): ...this method.
2163         (check_condition): Change to...
2164         (ppc_linux_nat_target::check_condition): ...this method.
2165         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
2166         comment, use m_dreg_interface.
2167         (create_watchpoint_request): Change to...
2168         (ppc_linux_nat_target::create_watchpoint_request): ...this
2169         method.  Use m_dreg_interface.
2170         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
2171         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
2172         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
2173         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
2174         (ppc_linux_nat_target::low_forget_process)
2175         (ppc_linux_nat_target::low_new_fork)
2176         (ppc_linux_nat_target::low_new_clone)
2177         (ppc_linux_nat_target::low_delete_thread)
2178         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
2179         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
2180         only call mark_thread_stale.
2181         (ppc_linux_thread_exit): Remove.
2182         (ppc_linux_nat_target::stopped_data_address): Change to...
2183         (ppc_linux_nat_target::low_stopped_data_address): This. Add
2184         comment, use m_dreg_interface and m_thread_hw_breakpoints.
2185         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
2186         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
2187         comment.  Call low_stopped_data_address.
2188         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
2189         m_dreg_interface.
2190         (ppc_linux_nat_target::masked_watch_num_registers): Use
2191         m_dreg_interface.
2192         (ppc_linux_nat_target::copy_thread_dreg_state)
2193         (ppc_linux_nat_target::mark_thread_stale)
2194         (ppc_linux_nat_target::mark_debug_registers_changed)
2195         (ppc_linux_nat_target::register_hw_breakpoint)
2196         (ppc_linux_nat_target::clear_hw_breakpoint)
2197         (ppc_linux_nat_target::register_wp)
2198         (ppc_linux_nat_target::clear_wp)
2199         (ppc_linux_nat_target::init_arch_lwp_info)
2200         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
2201         (_initialize_ppc_linux_nat): Remove observer callback.
2202
2203 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2204
2205         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
2206         (ppc_linux_nat_target::auxv_parse)
2207         (ppc_linux_nat_target::read_description)
2208         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
2209         Move up.
2210
2211 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2212
2213         * linux-nat.h (low_new_clone): New method.
2214         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
2215
2216 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2217
2218         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
2219         (dbx_expand_psymtab): ... this.
2220         (start_psymtab): Update.
2221         * mdebugread.c (psymtab_to_symtab_1): Rename to...
2222         (mdebug_expand_psymtab): ... this.
2223         (parse_partial_symbols): Update.
2224         (new_psymtab): Update.
2225         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
2226         (xcoff_expand_psymtab): ... this.
2227         (xcoff_start_psymtab): Update.
2228
2229 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2230
2231         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
2232         <expand_dependencies>: ... this.
2233         * psymtab.c (partial_symtab::read_dependencies): Rename to...
2234         (partial_symtab::expand_dependencies): ... this.
2235         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
2236         Update.
2237         (dwarf2_psymtab::expand_psymtab): Update.
2238         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
2239         * mdebugread.c (psymtab_to_symtab_1): Update.
2240         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
2241
2242 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2243
2244         * psympriv.h (discard_psymtab): Remove.
2245         * dbxread.c (dbx_end_psymtab): Update.
2246         * xcoffread.c (xcoff_end_psymtab): Update.
2247
2248 2020-03-28  Tom Tromey  <tom@tromey.com>
2249
2250         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
2251         comment.
2252
2253 2020-03-28  Tom Tromey  <tom@tromey.com>
2254
2255         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
2256
2257 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
2258
2259         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2260
2261 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
2262
2263         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
2264
2265 2020-03-26  Tom Tromey  <tom@tromey.com>
2266
2267         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
2268         (mark_common_block_symbol_computed, read_tag_string_type)
2269         (attr_to_dynamic_prop, read_subrange_type): Update.
2270         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
2271         to be methods on struct attribute.
2272         (skip_one_die, process_imported_unit_die, read_namespace_alias)
2273         (read_call_site_scope, partial_die_info::read)
2274         (partial_die_info::read, lookup_die_type, follow_die_ref):
2275         Update.
2276         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
2277         from dwarf2_get_ref_die_offset.
2278         (attribute::constant_value): New method, from
2279         dwarf2_get_attr_constant_value.
2280         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
2281         Declare method.
2282         <constant_value>: New method.
2283
2284 2020-03-26  Tom Tromey  <tom@tromey.com>
2285
2286         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
2287         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
2288         (dwarf_type_encoding_name): Move to stringify.c.
2289         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
2290         * dwarf2/stringify.c: New file.
2291         * dwarf2/stringify.h: New file.
2292
2293 2020-03-26  Tom Tromey  <tom@tromey.com>
2294
2295         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
2296         Rewrite.
2297
2298 2020-03-26  Tom Tromey  <tom@tromey.com>
2299
2300         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
2301         methods.
2302         * dwarf2/read.c (lookup_addr_base): Move to die.h.
2303         (lookup_ranges_base): Likewise.
2304         (read_cutu_die_from_dwo, read_full_die_1): Update.
2305
2306 2020-03-26  Tom Tromey  <tom@tromey.com>
2307
2308         * dwarf2/read.c (read_import_statement, read_file_scope)
2309         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
2310         (read_lexical_block_scope, read_call_site_scope)
2311         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
2312         (handle_struct_member_die, process_structure_scope)
2313         (update_enumeration_type_from_children)
2314         (process_enumeration_scope, read_array_type, read_common_block)
2315         (read_namespace, read_module, read_subroutine_type): Update.
2316         (sibling_die): Remove.
2317
2318 2020-03-26  Tom Tromey  <tom@tromey.com>
2319
2320         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
2321         (build_type_psymtabs_reader, read_structure_type)
2322         (read_enumeration_type, read_full_die_1): Update.
2323         (dwarf2_attr_no_follow): Move to die.h.
2324         * dwarf2/die.h (struct die_info) <attr>: New method.
2325
2326 2020-03-26  Tom Tromey  <tom@tromey.com>
2327
2328         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
2329         <base_address>: Now an optional.
2330         (dwarf2_find_base_address, dwarf2_rnglists_process)
2331         (dwarf2_ranges_process, fill_in_loclist_baton)
2332         (dwarf2_symbol_mark_computed): Update.
2333
2334 2020-03-26  Tom Tromey  <tom@tromey.com>
2335
2336         * dwarf2/read.c (struct die_info): Move to die.h.
2337         * dwarf2/die.h: New file.
2338
2339 2020-03-26  Tom Tromey  <tom@tromey.com>
2340
2341         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
2342         * dwarf2/read.c
2343         (dwarf2_statement_list_fits_in_line_number_section_complaint):
2344         Move to line-header.c.
2345         (read_checked_initial_length_and_offset, read_formatted_entries):
2346         Likewise.
2347         (dwarf_decode_line_header): Split into two.
2348         * dwarf2/line-header.c
2349         (dwarf2_statement_list_fits_in_line_number_section_complaint):
2350         Move from read.c.
2351         (read_checked_initial_length_and_offset, read_formatted_entries):
2352         Likewise.
2353         (dwarf_decode_line_header): New function, split from read.c.
2354
2355 2020-03-26  Tom Tromey  <tom@tromey.com>
2356
2357         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
2358         Declare method.
2359         * dwarf2/read.c (read_attribute_value): Update.
2360         (dwarf2_per_objfile::read_line_string): Rename from
2361         read_indirect_line_string.
2362         (read_formatted_entries): Update.
2363
2364 2020-03-26  Tom Tromey  <tom@tromey.com>
2365
2366         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
2367         variable.
2368
2369 2020-03-26  Tom Tromey  <tom@tromey.com>
2370
2371         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
2372         const.
2373         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
2374         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
2375         parameter const.
2376
2377 2020-03-26  Tom Tromey  <tom@tromey.com>
2378
2379         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
2380         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
2381         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
2382         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
2383
2384 2020-03-26  Tom Tromey  <tom@tromey.com>
2385
2386         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
2387         file_names_size, file_full_name, file_file_name>: Use const.
2388         <file_name_at, file_names>: Add const overload.
2389         * dwarf2/line-header.c (line_header::file_file_name)
2390         (line_header::file_full_name): Update.
2391
2392 2020-03-26  Tom Tromey  <tom@tromey.com>
2393
2394         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
2395         (macro_start_file, consume_improper_spaces)
2396         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
2397         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
2398         (dwarf_decode_macros): Move to macro.c.
2399         * dwarf2/macro.c: New file.
2400         * dwarf2/macro.h: New file.
2401         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
2402
2403 2020-03-26  Tom Tromey  <tom@tromey.com>
2404
2405         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
2406         method.
2407         * dwarf2/section.c: New method.  From
2408         read_indirect_string_at_offset_from.
2409         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
2410         (read_indirect_string_at_offset_from): Move to section.c.
2411         (read_indirect_string_at_offset): Rewrite.
2412         (read_indirect_line_string_at_offset): Remove.
2413         (read_indirect_string, read_indirect_line_string)
2414         (dwarf_decode_macro_bytes): Update.
2415
2416 2020-03-26  Tom Tromey  <tom@tromey.com>
2417
2418         * dwarf2/section.h (struct dwarf2_section_info)
2419         <overload_complaint>: Declare.
2420         (dwarf2_section_buffer_overflow_complaint): Don't declare.
2421         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
2422         Rename from dwarf2_section_buffer_overflow_complaint.
2423         * dwarf2/read.c (skip_one_die, partial_die_info::read)
2424         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
2425
2426 2020-03-26  Tom Tromey  <tom@tromey.com>
2427
2428         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
2429         Declare.
2430         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
2431         Move from read.c.
2432         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
2433         to section.c.
2434
2435 2020-03-26  Tom Tromey  <tom@tromey.com>
2436
2437         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
2438
2439 2020-03-26  Tom Tromey  <tom@tromey.com>
2440
2441         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
2442         "builder".
2443         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
2444         parameter.
2445         (dwarf_decode_macros): Update.
2446
2447 2020-03-26  Tom Tromey  <tom@tromey.com>
2448
2449         * dwarf2/read.c (read_attribute_value): Update.
2450         (read_indirect_string_from_dwz): Move to dwz.c; change into
2451         method.
2452         (dwarf_decode_macro_bytes): Update.
2453         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
2454         * dwarf2/dwz.c: New file.
2455         * Makefile.in (COMMON_SFILES): Add dwz.c.
2456
2457 2020-03-26  Tom Tromey  <tom@tromey.com>
2458
2459         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
2460         * dwarf2/read.c: Add include.
2461         * dwarf2/index-write.c: Add include.
2462         * dwarf2/index-cache.c: Add include.
2463         * dwarf2/dwz.h: New file.
2464
2465 2020-03-25  Tom Tromey  <tom@tromey.com>
2466
2467         * compile/compile-object-load.c (get_out_value_type): Mention
2468         correct symbol name in error message.
2469
2470 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
2471
2472         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2473
2474 2020-03-25  Tom de Vries  <tdevries@suse.de>
2475
2476         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
2477         * symmisc.c (dump_symtab_1): Print user and includes fields.
2478         (maintenance_info_symtabs): Same.
2479
2480 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2481
2482         PR gdb/25534
2483         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
2484         (riscv_regcache_cooked_write): New function.
2485         (riscv_push_dummy_call): Use new function.
2486         (riscv_return_value): Likewise.
2487
2488 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
2489
2490         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
2491         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
2492         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
2493         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
2494         * infrun.c (follow_fork): Likewise.
2495         (follow_fork_inferior): Likewise.
2496         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
2497         * linux-nat.h (class linux_nat_target): Likewise.
2498         * remote.c (class remote_target) <follow_fork>: Likewise.
2499         (remote_target::follow_fork): Likewise.
2500         * target-delegates.c: Re-generate.
2501         * target.c (default_follow_fork): Likewise.
2502         (target_follow_fork): Likewise.
2503         * target.h (struct target_ops) <follow_fork>: Likewise.
2504         (target_follow_fork): Likewise.
2505
2506 2020-03-24  Tom de Vries  <tdevries@suse.de>
2507
2508         * psymtab.c (maintenance_info_psymtabs): Print user field.
2509
2510 2020-03-20  Tom Tromey  <tromey@adacore.com>
2511
2512         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
2513         const.
2514         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
2515         const.
2516
2517 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
2518
2519         * ptrace.m4: Don't check for ptrace declaration.
2520         * config.in: Re-generate.
2521         * configure: Re-generate.
2522         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
2523         not defined.
2524
2525 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2526
2527         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
2528         `PTRACE_TYPE_RET'.
2529         * i386-bsd-nat.c (gdb_ptrace): Likewise.
2530         * sparc-nat.c (gdb_ptrace): Likewise.
2531         * x86-bsd-nat.c (gdb_ptrace): Likewise.
2532
2533 2020-03-20  Tom Tromey  <tromey@adacore.com>
2534
2535         * c-exp.y (lex_one_token): Fix assert.
2536
2537 2020-03-20  Tom Tromey  <tromey@adacore.com>
2538
2539         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
2540         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
2541         strncpy call.
2542
2543 2020-03-20  Tom Tromey  <tromey@adacore.com>
2544
2545         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
2546
2547 2020-03-20  Tom Tromey  <tromey@adacore.com>
2548
2549         * ada-valprint.c (print_variant_part): Remove parameters; switch
2550         to value-based API.
2551         (print_field_values): Likewise.
2552         (ada_val_print_struct_union): Likewise.
2553         (ada_value_print_1): Update.
2554
2555 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2556
2557         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
2558         nbsd_nat_target instead of inf_ptrace_target.
2559         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2560         nbsd_nat_target.
2561
2562 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2563
2564         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
2565         it to the ptrace call.
2566         * (store_registers): Likewise.
2567
2568 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2569
2570         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
2571         it to the ptrace call.
2572         * (store_registers): Likewise.
2573
2574 2020-03-19  Luis Machado  <luis.machado@linaro.org>
2575
2576         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
2577         valid, fetch vg value from ptrace.
2578
2579 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2580         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
2581         * inf-ptrace.c: Likewise.
2582         * (gdb_ptrace): Add.
2583         * (inf_ptrace_target::resume): Update.
2584         * (inf_ptrace_target::xfer_partial): Likewise.
2585         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
2586         * (inf_ptrace_peek_poke): Update.
2587
2588 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2589
2590         * x86-bsd-nat.c (gdb_ptrace): New.
2591         * (x86bsd_dr_set): Add new argument `ptid'.
2592         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
2593         x86bsd_dr_set_addr): Update.
2594
2595 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2596
2597         * remote.c (remote_target::process_stop_reply): Handle events for
2598         all threads differently.
2599
2600 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2601
2602         * completer.c (completion_tracker::remove_completion): Define new
2603         function.
2604         * completer.h (completion_tracker::remove_completion): Declare new
2605         function.
2606         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
2607         when adding a C++ function symbol.
2608
2609 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2610
2611         * completer.c (completion_tracker::completion_hash_entry): Define
2612         new class.
2613         (advance_to_filename_complete_word_point): Call
2614         recompute_lowest_common_denominator.
2615         (completion_tracker::completion_tracker): Call discard_completions
2616         to setup the hash table.
2617         (completion_tracker::discard_completions): Allow for being called
2618         from the constructor, pass new equal function, and element deleter
2619         when constructing the hash table.  Initialise new class member
2620         variables.
2621         (completion_tracker::maybe_add_completion): Remove use of
2622         m_entries_vec, and store more information into m_entries_hash.
2623         (completion_tracker::recompute_lcd_visitor): New function, most
2624         content taken from...
2625         (completion_tracker::recompute_lowest_common_denominator):
2626         ...here, this now just visits each item in the hash calling the
2627         above visitor.
2628         (completion_tracker::build_completion_result): Remove use of
2629         m_entries_vec, call recompute_lowest_common_denominator.
2630         * completer.h (completion_tracker::have_completions): Remove use
2631         of m_entries_vec.
2632         (completion_tracker::completion_hash_entry): Declare new class.
2633         (completion_tracker::recompute_lowest_common_denominator): Change
2634         function signature.
2635         (completion_tracker::recompute_lcd_visitor): Declare new function.
2636         (completion_tracker::m_entries_vec): Delete.
2637         (completion_tracker::m_entries_hash): Initialize to NULL.
2638         (completion_tracker::m_lowest_common_denominator_valid): New
2639         member variable.
2640         (completion_tracker::m_lowest_common_denominator_max_length): New
2641         member variable.
2642
2643 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2644
2645         * regformats/regdef.h: Put reg in gdb namespace.
2646
2647 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2648
2649         * i386-bsd-nat.c (gdb_ptrace): New.
2650         * (i386bsd_fetch_inferior_registers,
2651         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2652         * (i386bsd_fetch_inferior_registers,
2653         i386bsd_store_inferior_registers) Use gdb_ptrace.
2654
2655 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2656
2657         * amd64-bsd-nat.c (gdb_ptrace): New.
2658         * (amd64bsd_fetch_inferior_registers,
2659         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2660         * (amd64bsd_fetch_inferior_registers,
2661         amd64bsd_store_inferior_registers) Use gdb_ptrace.
2662
2663 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2664
2665         * user-regs.c (user_reg::read): Rename to...
2666         (user_reg::xread): ...this.
2667         * (append_user_reg): Rename argument `read' to `xread'.
2668         * (user_reg_add_builtin): Likewise.
2669         * (user_reg_add): Likewise.
2670         * (value_of_user_reg): Likewise.
2671
2672 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2673
2674         * sparc-nat.c (gdb_ptrace): New.
2675         * sparc-nat.c (sparc_fetch_inferior_registers)
2676         (sparc_store_inferior_registers) Remove obsolete comment.
2677         * sparc-nat.c (sparc_fetch_inferior_registers)
2678         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
2679         * sparc-nat.c (sparc_fetch_inferior_registers)
2680         (sparc_store_inferior_registers) Use gdb_ptrace.
2681
2682 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2683
2684         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
2685         it to the ptrace call.
2686         * sh-nbsd-nat.c (store_registers): Likewise.
2687
2688 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2689
2690         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
2691         nbsd_nat_target instead of inf_ptrace_target.
2692         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2693         nbsd_nat_target.
2694
2695 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2696
2697         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
2698
2699 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2700
2701         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
2702         <sys/sysctl.h>.
2703         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
2704
2705 2020-03-17  Tom de Vries  <tdevries@suse.de>
2706
2707         PR gdb/23710
2708         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
2709         fields.
2710         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
2711         fields.
2712         (process_imported_unit_die): Skip import of c++ CUs.
2713
2714 2020-03-16  Tom Tromey  <tom@tromey.com>
2715
2716         * p-valprint.c (pascal_object_print_value): Initialize
2717         base_value.
2718
2719 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
2720             Shahab Vahedi  <shahab@synopsys.com>
2721
2722         * Makefile.in: Add arch/arc.o
2723         * configure.tgt: Likewise.
2724         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
2725         (_initialize_arc_tdep): Don't initialize old target descriptions.
2726         (arc_read_description): New function to cache target descriptions.
2727         * arc-tdep.h (arc_read_description): Add proto type.
2728         * arch/arc.c: New file.
2729         * arch/arc.h: Likewise.
2730         * features/Makefile: Replace old target descriptions with new.
2731         * features/arc-arcompact.c: Remove.
2732         * features/arc-arcompact.xml: Likewise.
2733         * features/arc-v2.c: Likewise
2734         * features/arc-v2.xml: Likewise
2735         * features/arc/aux-arcompact.xml: New file.
2736         * features/arc/aux-v2.xml: Likewise.
2737         * features/arc/core-arcompact.xml: Likewise.
2738         * features/arc/core-v2.xml: Likewise.
2739         * features/arc/aux-arcompact.c: Generate.
2740         * features/arc/aux-v2.c: Likewise.
2741         * features/arc/core-arcompact.c: Likewise.
2742         * features/arc/core-v2.c: Likewise.
2743         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
2744
2745 2020-03-16  Tom Tromey  <tromey@adacore.com>
2746
2747         PR gdb/25663:
2748         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
2749         putting value into bcache.
2750
2751 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2752
2753         PR gdb/21500
2754         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
2755         to...
2756         (amd64_windows_init_abi_common): ... this.  Don't set size of
2757         long type.
2758         (amd64_windows_init_abi): New function.
2759         (amd64_cygwin_init_abi): New function.
2760         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
2761         the Cygwin OS ABI.
2762         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
2763         comment.
2764
2765 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2766
2767         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
2768         * windows-tdep.c (CYGWIN_DLL_NAME): New.
2769         (pe_import_directory_entry): New struct type.
2770         (is_linked_with_cygwin_dll): New function.
2771         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
2772         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
2773         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
2774
2775 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2776
2777         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
2778         i386_cygwin_core_osabi_sniffer.
2779
2780 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2781
2782         * i386-cygwin-tdep.c: Rename to...
2783         * i386-windows-tdep.c: ... this.
2784         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
2785         i386-windows-tdep.c.
2786         * configure.tgt: Likewise.
2787
2788 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2789
2790         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
2791         * osabi.c (gdb_osabi_names): Add "Windows".
2792         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
2793         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
2794         (i386_cygwin_core_osabi_sniffer): New function, extracted from
2795         i386_cygwin_osabi_sniffer.
2796         (_initialize_i386_cygwin_tdep): Register OS ABI
2797         GDB_OSABI_WINDOWS for i386.
2798         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
2799         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
2800         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
2801         for x86-64.
2802         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
2803         when the target matches '*-*-mingw*'.
2804
2805 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2806
2807         * defs.h (enum gdb_osabi): Move to...
2808         * osabi.h (enum gdb_osabi): ... here.
2809         * gdbarch.sh: Include osabi.h in gdbarch.h.
2810         * gdbarch.h: Re-generate.
2811
2812 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2813
2814         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
2815         function.
2816         (_initialize_amd64_windows_tdep): Register osabi sniffer.
2817
2818 2020-03-14  Tom Tromey  <tom@tromey.com>
2819
2820         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
2821         for C++.
2822         (c_type_print_modifier): Likewise.  Add "language" parameter.
2823         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
2824         (c_type_print_base_1): Update.
2825         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
2826         constants.
2827         * type-stack.c (type_stack::insert): Handle tp_atomic and
2828         tp_restrict.
2829         (type_stack::follow_type_instance_flags): Likewise.
2830         (type_stack::follow_types): Likewise.  Merge type-following code.
2831         * c-exp.y (RESTRICT, ATOMIC): New tokens.
2832         (space_identifier, cv_with_space_id)
2833         (const_or_volatile_or_space_identifier_noopt)
2834         (const_or_volatile_or_space_identifier): Remove.
2835         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
2836         rules.
2837         (ptr_operator, typebase): Update.
2838         (enum token_flag) <FLAG_C>: New constant.
2839         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
2840         "_Atomic".
2841         (lex_one_token): Handle FLAG_C.
2842
2843 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2844
2845         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
2846         it to the ptrace call.
2847         * m68k-bsd-nat.c (store_registers): Likewise.
2848
2849 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2850
2851         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
2852         gdb_byte *.
2853         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
2854         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
2855         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
2856
2857 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2858
2859         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
2860         nbsd_nat_target instead of inf_ptrace_target.
2861         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2862         nbsd_nat_target.
2863
2864 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2865
2866         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
2867         register_t.
2868
2869 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2870
2871         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
2872         it to the ptrace call.
2873         * alpha-bsd-nat.c (store_registers): Likewise.
2874
2875 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2876
2877         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
2878         includes.
2879         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
2880         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
2881         fill_fpregset): Likewise.
2882
2883 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2884
2885         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
2886         nbsd_nat_target instead of inf_ptrace_target.
2887         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2888         nbsd_nat_target.
2889
2890 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2891
2892         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
2893         register_t.
2894
2895 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2896
2897         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
2898         it to the ptrace call.
2899         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
2900         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
2901         * arm-nbsd-nat.c (store_register): Likewise.
2902         * arm-nbsd-nat.c (store_regs): Likewise.
2903         * arm-nbsd-nat.c (store_fp_register): Likewise.
2904         * arm-nbsd-nat.c (store_fp_regs): Likewise.
2905
2906 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2907
2908         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
2909         nbsd_nat_target instead of inf_ptrace_target.
2910         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2911         nbsd_nat_target.
2912
2913 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2914
2915         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
2916         it to the ptrace call.
2917         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
2918
2919 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2920
2921         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
2922         it to the ptrace call.
2923         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
2924
2925 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2926
2927         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
2928         gdb_byte *.
2929         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
2930
2931 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2932
2933         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
2934         instead of inf_ptrace_target.
2935         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2936         nbsd_nat_target.
2937
2938 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2939
2940         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2941         register_t.
2942
2943 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2944
2945         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2946         register_t.
2947
2948 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2949
2950         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
2951         register_t.
2952
2953 2020-03-13  Tom Tromey  <tom@tromey.com>
2954
2955         * value.h (val_print): Don't declare.
2956         * valprint.h (val_print_array_elements)
2957         (val_print_scalar_formatted, generic_val_print): Don't declare.
2958         * valprint.c (generic_val_print_array): Take a struct value.
2959         (generic_val_print_ptr, generic_val_print_memberptr)
2960         (generic_val_print_bool, generic_val_print_int)
2961         (generic_val_print_char, generic_val_print_complex)
2962         (generic_val_print): Remove.
2963         (generic_value_print): Update.
2964         (do_val_print): Remove unused parameters.  Don't call
2965         la_val_print.
2966         (val_print): Remove.
2967         (common_val_print): Update.  Don't call value_check_printable.
2968         (val_print_scalar_formatted, val_print_array_elements): Remove.
2969         * rust-lang.c (rust_val_print): Remove.
2970         (rust_language_defn): Update.
2971         * p-valprint.c (pascal_val_print): Remove.
2972         (pascal_value_print_inner): Update.
2973         (pascal_object_print_val_fields, pascal_object_print_val):
2974         Remove.
2975         (pascal_object_print_static_field): Update.
2976         * p-lang.h (pascal_val_print): Don't declare.
2977         * p-lang.c (pascal_language_defn): Update.
2978         * opencl-lang.c (opencl_language_defn): Update.
2979         * objc-lang.c (objc_language_defn): Update.
2980         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
2981         * m2-lang.h (m2_val_print): Don't declare.
2982         * m2-lang.c (m2_language_defn): Update.
2983         * language.h (struct language_defn) <la_val_print>: Remove.
2984         * language.c (unk_lang_value_print_inner): Rename.  Change
2985         argument types.
2986         (unknown_language_defn, auto_language_defn): Update.
2987         * go-valprint.c (go_val_print): Remove.
2988         * go-lang.h (go_val_print): Don't declare.
2989         * go-lang.c (go_language_defn): Update.
2990         * f-valprint.c (f_val_print): Remove.
2991         * f-lang.h (f_value_print): Don't declare.
2992         * f-lang.c (f_language_defn): Update.
2993         * d-valprint.c (d_val_print): Remove.
2994         * d-lang.h (d_value_print): Don't declare.
2995         * d-lang.c (d_language_defn): Update.
2996         * cp-valprint.c (cp_print_value_fields)
2997         (cp_print_value_fields_rtti, cp_print_value): Remove.
2998         (cp_print_static_field): Update.
2999         * c-valprint.c (c_val_print_array, c_val_print_ptr)
3000         (c_val_print_struct, c_val_print_union, c_val_print_int)
3001         (c_val_print_memberptr, c_val_print): Remove.
3002         * c-lang.h (c_val_print_array, cp_print_value_fields)
3003         (cp_print_value_fields_rtti): Don't declare.
3004         * c-lang.c (c_language_defn, cplus_language_defn)
3005         (asm_language_defn, minimal_language_defn): Update.
3006         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
3007         (ada_val_print_enum): Take a struct value.
3008         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
3009         (ada_val_print): Remove.
3010         (ada_value_print_1): Update.
3011         (printable_val_type): Remove.
3012         * ada-lang.h (ada_val_print): Don't declare.
3013         * ada-lang.c (ada_language_defn): Update.
3014
3015 2020-03-13  Tom Tromey  <tom@tromey.com>
3016
3017         * valprint.c (do_val_print): Update.
3018         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
3019         a struct value.
3020         (value_to_value_object_no_release): Declare.
3021         * python/py-value.c (value_to_value_object_no_release): New
3022         function.
3023         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
3024         struct value.
3025         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
3026         function.
3027         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
3028         a struct value.
3029         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
3030         Declare.
3031         (gdbscm_apply_val_pretty_printer): Take a struct value.
3032         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
3033         value.
3034         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
3035         value.
3036         * extension-priv.h (struct extension_language_ops)
3037         <apply_val_pretty_printer>: Take a struct value.
3038         * cp-valprint.c (cp_print_value): Create a struct value.
3039         (cp_print_value): Update.
3040
3041 2020-03-13  Tom Tromey  <tom@tromey.com>
3042
3043         * ada-valprint.c (print_field_values): Call common_val_print.
3044
3045 2020-03-13  Tom Tromey  <tom@tromey.com>
3046
3047         * ada-valprint.c (val_print_packed_array_elements): Remove
3048         bitoffset and val parameters.  Call common_val_print.
3049         (ada_val_print_string): Remove offset, address, and original_value
3050         parameters.
3051         (ada_val_print_array): Update.
3052         (ada_value_print_array): New function.
3053         (ada_value_print_1): Call it.
3054
3055 2020-03-13  Tom Tromey  <tom@tromey.com>
3056
3057         * ada-valprint.c (ada_value_print): Use common_val_print.
3058
3059 2020-03-13  Tom Tromey  <tom@tromey.com>
3060
3061         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
3062
3063 2020-03-13  Tom Tromey  <tom@tromey.com>
3064
3065         * ada-valprint.c (ada_value_print_num): New function.
3066         (ada_value_print_1): Use it.
3067
3068 2020-03-13  Tom Tromey  <tom@tromey.com>
3069
3070         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
3071
3072 2020-03-13  Tom Tromey  <tom@tromey.com>
3073
3074         * ada-valprint.c (ada_value_print_ptr): New function.
3075         (ada_value_print_1): Use it.
3076
3077 2020-03-13  Tom Tromey  <tom@tromey.com>
3078
3079         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
3080         call common_val_print.
3081         (ada_val_print_1): Update.
3082         (ada_value_print_1): New function.
3083         (ada_value_print_inner): Rewrite.
3084
3085 2020-03-13  Tom Tromey  <tom@tromey.com>
3086
3087         * cp-valprint.c (cp_print_value_fields): Update.
3088         (cp_print_value): New function.
3089
3090 2020-03-13  Tom Tromey  <tom@tromey.com>
3091
3092         * m2-valprint.c (m2_value_print_inner): Use
3093         cp_print_value_fields.
3094         * cp-valprint.c (cp_print_value_fields): New function.
3095         * c-valprint.c (c_value_print_struct): New function.
3096         (c_value_print_inner): Use c_value_print_struct.
3097         * c-lang.h (cp_print_value_fields): Declare.
3098
3099 2020-03-13  Tom Tromey  <tom@tromey.com>
3100
3101         * c-valprint.c (c_value_print_array): New function.
3102         (c_value_print_inner): Use it.
3103
3104 2020-03-13  Tom Tromey  <tom@tromey.com>
3105
3106         * c-valprint.c (c_value_print_memberptr): New function.
3107         (c_value_print_inner): Use it.
3108
3109 2020-03-13  Tom Tromey  <tom@tromey.com>
3110
3111         * c-valprint.c (c_value_print_int): New function.
3112         (c_value_print_inner): Use it.
3113
3114 2020-03-13  Tom Tromey  <tom@tromey.com>
3115
3116         * c-valprint.c (c_value_print_ptr): New function.
3117         (c_value_print_inner): Use it.
3118
3119 2020-03-13  Tom Tromey  <tom@tromey.com>
3120
3121         * c-valprint.c (c_value_print_inner): Rewrite.
3122
3123 2020-03-13  Tom Tromey  <tom@tromey.com>
3124
3125         * valprint.c (generic_value_print_complex): New function.
3126         (generic_value_print): Use it.
3127
3128 2020-03-13  Tom Tromey  <tom@tromey.com>
3129
3130         * valprint.c (generic_val_print_float): Don't call
3131         val_print_scalar_formatted.
3132         (generic_val_print, generic_value_print): Update.
3133
3134 2020-03-13  Tom Tromey  <tom@tromey.com>
3135
3136         * valprint.c (generic_value_print_char): New function
3137         (generic_value_print): Use it.
3138
3139 2020-03-13  Tom Tromey  <tom@tromey.com>
3140
3141         * valprint.c (generic_value_print_int): New function.
3142         (generic_value_print): Use it.
3143
3144 2020-03-13  Tom Tromey  <tom@tromey.com>
3145
3146         * valprint.c (generic_value_print_bool): New function.
3147         (generic_value_print): Use it.
3148
3149 2020-03-13  Tom Tromey  <tom@tromey.com>
3150
3151         * valprint.c (generic_val_print_func): Simplify.
3152         (generic_val_print, generic_value_print): Update.
3153
3154 2020-03-13  Tom Tromey  <tom@tromey.com>
3155
3156         * valprint.c (generic_val_print_flags): Remove.
3157         (generic_val_print, generic_value_print): Update.
3158         (val_print_type_code_flags): Add original_value parameter.
3159
3160 2020-03-13  Tom Tromey  <tom@tromey.com>
3161
3162         * valprint.c (generic_val_print): Update.
3163         (generic_value_print): Update.
3164         * valprint.c (generic_val_print_enum): Don't call
3165         val_print_scalar_formatted.
3166
3167 2020-03-13  Tom Tromey  <tom@tromey.com>
3168
3169         * valprint.c (generic_value_print): Call generic_value_print_ptr.
3170         * valprint.c (generic_value_print_ptr): New function.
3171
3172 2020-03-13  Tom Tromey  <tom@tromey.com>
3173
3174         * valprint.c (generic_value_print): Rewrite.
3175
3176 2020-03-13  Tom Tromey  <tom@tromey.com>
3177
3178         * p-valprint.c (pascal_object_print_value_fields)
3179         (pascal_object_print_value): New functions.
3180
3181 2020-03-13  Tom Tromey  <tom@tromey.com>
3182
3183         * p-valprint.c (pascal_value_print_inner): Rewrite.
3184
3185 2020-03-13  Tom Tromey  <tom@tromey.com>
3186
3187         * f-valprint.c (f_value_print_innner): Rewrite.
3188
3189 2020-03-13  Tom Tromey  <tom@tromey.com>
3190
3191         * m2-valprint.c (m2_print_unbounded_array): New overload.
3192         (m2_print_unbounded_array): Update.
3193         (m2_print_array_contents): Take a struct value.
3194         (m2_value_print_inner): Rewrite.
3195
3196 2020-03-13  Tom Tromey  <tom@tromey.com>
3197
3198         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
3199         (d_value_print_inner): New function.
3200         * d-lang.h (d_value_print_inner): Declare.
3201         * d-lang.c (d_language_defn): Use d_value_print_inner.
3202
3203 2020-03-13  Tom Tromey  <tom@tromey.com>
3204
3205         * go-valprint.c (go_value_print_inner): New function.
3206         * go-lang.h (go_value_print_inner): Declare.
3207         * go-lang.c (go_language_defn): Use go_value_print_inner.
3208
3209 2020-03-13  Tom Tromey  <tom@tromey.com>
3210
3211         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
3212         API.
3213         (rust_val_print): Rewrite.
3214         (rust_value_print_inner): New function, from rust_val_print.
3215         (rust_language_defn): Use rust_value_print_inner.
3216
3217 2020-03-13  Tom Tromey  <tom@tromey.com>
3218
3219         * ada-valprint.c (ada_value_print_inner): New function.
3220         * ada-lang.h (ada_value_print_inner): Declare.
3221         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
3222
3223 2020-03-13  Tom Tromey  <tom@tromey.com>
3224
3225         * f-valprint.c (f_value_print_innner): New function.
3226         * f-lang.h (f_value_print_innner): Declare.
3227         * f-lang.c (f_language_defn): Use f_value_print_innner.
3228
3229 2020-03-13  Tom Tromey  <tom@tromey.com>
3230
3231         * p-valprint.c (pascal_value_print_inner): New function.
3232         * p-lang.h (pascal_value_print_inner): Declare.
3233         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
3234
3235 2020-03-13  Tom Tromey  <tom@tromey.com>
3236
3237         * m2-valprint.c (m2_value_print_inner): New function.
3238         * m2-lang.h (m2_value_print_inner): Declare.
3239         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
3240
3241 2020-03-13  Tom Tromey  <tom@tromey.com>
3242
3243         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
3244         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
3245         * c-valprint.c (c_value_print_inner): New function.
3246         * c-lang.h (c_value_print_inner): Declare.
3247         * c-lang.c (c_language_defn, cplus_language_defn)
3248         (asm_language_defn, minimal_language_defn): Use
3249         c_value_print_inner.
3250
3251 2020-03-13  Tom Tromey  <tom@tromey.com>
3252
3253         * p-valprint.c (pascal_object_print_value_fields): Now static.
3254         * p-lang.h (pascal_object_print_value_fields): Don't declare.
3255
3256 2020-03-13  Tom Tromey  <tom@tromey.com>
3257
3258         * c-valprint.c (c_val_print_array): Simplify.
3259
3260 2020-03-13  Tom Tromey  <tom@tromey.com>
3261
3262         * valprint.c (value_print_array_elements): New function.
3263         * valprint.h (value_print_array_elements): Declare.
3264
3265 2020-03-13  Tom Tromey  <tom@tromey.com>
3266
3267         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
3268         * mips-tdep.c (mips_print_register): Use
3269         value_print_scalar_formatted.
3270
3271 2020-03-13  Tom Tromey  <tom@tromey.com>
3272
3273         * valprint.h (value_print_scalar_formatted): Declare.
3274         * valprint.c (value_print_scalar_formatted): New function.
3275
3276 2020-03-13  Tom Tromey  <tom@tromey.com>
3277
3278         * valprint.h (generic_value_print): Declare.
3279         * valprint.c (generic_value_print): New function.
3280
3281 2020-03-13  Tom Tromey  <tom@tromey.com>
3282
3283         * valprint.c (do_val_print): Call la_value_print_inner, if
3284         available.
3285         * rust-lang.c (rust_language_defn): Update.
3286         * p-lang.c (pascal_language_defn): Update.
3287         * opencl-lang.c (opencl_language_defn): Update.
3288         * objc-lang.c (objc_language_defn): Update.
3289         * m2-lang.c (m2_language_defn): Update.
3290         * language.h (struct language_defn) <la_value_print_inner>: New
3291         member.
3292         * language.c (unknown_language_defn, auto_language_defn): Update.
3293         * go-lang.c (go_language_defn): Update.
3294         * f-lang.c (f_language_defn): Update.
3295         * d-lang.c (d_language_defn): Update.
3296         * c-lang.c (c_language_defn, cplus_language_defn)
3297         (asm_language_defn, minimal_language_defn): Update.
3298         * ada-lang.c (ada_language_defn): Update.
3299
3300 2020-03-13  Tom Tromey  <tom@tromey.com>
3301
3302         * c-valprint.c (c_value_print): Use common_val_print.
3303
3304 2020-03-13  Tom Tromey  <tom@tromey.com>
3305
3306         * cp-valprint.c (cp_print_static_field): Use common_val_print.
3307
3308 2020-03-13  Tom Tromey  <tom@tromey.com>
3309
3310         * f-valprint.c (f77_print_array_1, f_val_print): Use
3311         common_val_print.
3312
3313 2020-03-13  Tom Tromey  <tom@tromey.com>
3314
3315         * riscv-tdep.c (riscv_print_one_register_info): Use
3316         common_val_print.
3317
3318 2020-03-13  Tom Tromey  <tom@tromey.com>
3319
3320         * mi/mi-main.c (output_register): Use common_val_print.
3321
3322 2020-03-13  Tom Tromey  <tom@tromey.com>
3323
3324         * infcmd.c (default_print_one_register_info): Use
3325         common_val_print.
3326
3327 2020-03-13  Tom Tromey  <tom@tromey.com>
3328
3329         * valprint.h (common_val_print_checked): Declare.
3330         * valprint.c (common_val_print_checked): New function.
3331         * stack.c (print_frame_arg): Use common_val_print_checked.
3332
3333 2020-03-13  Tom Tromey  <tom@tromey.com>
3334
3335         * valprint.c (do_val_print): New function, from val_print.
3336         (val_print): Use do_val_print.
3337         (common_val_print): Use do_val_print.
3338
3339 2020-03-13  Tom Tromey  <tom@tromey.com>
3340
3341         * valprint.c (value_print): Use scoped_value_mark.
3342
3343 2020-03-13  Tom de Vries  <tdevries@suse.de>
3344
3345         PR symtab/25646
3346         * psymtab.c (partial_symtab::partial_symtab): Don't set
3347         globals_offset and statics_offset.  Push element onto
3348         current_global_psymbols and current_static_psymbols stacks.
3349         (concat): New function.
3350         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
3351         element from current_global_psymbols and current_static_psymbols
3352         stacks.  Concat popped elements to global_psymbols and
3353         static_symbols.
3354         (add_psymbol_to_list): Use current_global_psymbols and
3355         current_static_psymbols stacks.
3356         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
3357         current_static_psymbols fields.
3358
3359 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3360
3361         * corelow.c (sniff_core_bfd): Remove.
3362         (class core_target) <m_core_vec>: Remove.
3363         (core_target::core_target): Update.
3364         (core_file_fns): Remove.
3365         (deprecated_add_core_fns): Remove.
3366         (default_core_sniffer): Remove.
3367         (sniff_core_bfd): Remove.
3368         (default_check_format): Remove.
3369         (gdb_check_format): Remove.
3370         (core_target_open): Update.
3371         (core_target::get_core_register_section): Update.
3372         (get_core_registers_cb): Update.
3373         (core_target::fetch_registers): Update.
3374         * gdbcore.h (struct core_fns): Remove.
3375         (deprecated_add_core_fns): Remove.
3376         (default_core_sniffer): Remove.
3377         (default_check_format): Remove.
3378
3379 2020-03-12  Tom Tromey  <tom@tromey.com>
3380
3381         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
3382         CORE_ADDR.
3383         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
3384
3385 2020-03-12  Tom Tromey  <tom@tromey.com>
3386
3387         * remote.c (remote_target::download_tracepoint)
3388         (remote_target::enable_tracepoint)
3389         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
3390         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
3391         sprintf_vma.
3392
3393 2020-03-12  Tom Tromey  <tom@tromey.com>
3394
3395         * symfile-mem.c: Update CORE_ADDR size assert.
3396
3397 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3398
3399         * selftest.m4: Move to gdbsupport/.
3400         * acinclude.m4: Update path to selftest.m4.
3401
3402 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3403
3404         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
3405         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
3406         gdbarch-selfselftests.c and selftest-arch.c.
3407         (SUBDIR_UNITTESTS_OBS): Rename to...
3408         (SELFTESTS_OBS): ... this.
3409         (COMMON_SFILES): Remove disasm-selftests.c and
3410         gdbarch-selftests.c.
3411         * configure.ac: Don't add selftest-arch.{c,o} to
3412         CONFIG_{SRCS,OBS}.
3413         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
3414         preprocessor conditions.
3415
3416 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3417
3418         * configure.ac: Don't source bfd/development.sh.
3419         * selftest.m4: Modify comment.
3420         * configure: Re-generate.
3421
3422 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3423
3424         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
3425         not "true" or "false".
3426         * configure: Re-generate.
3427
3428 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3429
3430         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
3431         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
3432         renamed to arm_nbsd_supply_gregset.
3433         (fetch_register): Update to call arm_nbsd_supply_gregset.
3434         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
3435         (arm_netbsd_nat_target::fetch_registers): Update.
3436         (fetch_elfcore_registers): Removed.
3437         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
3438         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
3439         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
3440         not require NetBSD system headers.
3441         (arm_nbsd_regset): New struct.
3442         (arm_nbsd_iterate_over_regset_sections): New function.
3443         (arm_netbsd_init_abi_common): Updated to call
3444         set_gdbarch_iterate_over_regset_sections.
3445         * arm-nbsd-tdep.h: New file.
3446
3447 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
3448
3449         * symtab.c (find_pc_sect_line): Add check which prevents infinite
3450         recursion.
3451
3452 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
3453
3454         * configure: Re-generate.
3455
3456 2020-03-11  Tom Tromey  <tromey@adacore.com>
3457
3458         * ada-typeprint.c (print_choices): Fix comment.
3459
3460 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3461
3462         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
3463         previous item in the list, when the list has no items.
3464
3465 2020-03-11  Tom de Vries  <tdevries@suse.de>
3466
3467         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
3468         PROP_LOCLIST handling code.
3469
3470 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3471
3472         * buildsym-legacy.c (record_line): Pass extra parameter to
3473         record_line.
3474         * buildsym.c (buildsym_compunit::record_line): Take an extra
3475         parameter, reduce duplication in the line table, and record the
3476         is_stmt flag in the line table.
3477         * buildsym.h (buildsym_compunit::record_line): Add extra
3478         parameter.
3479         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
3480         non-statement lines.
3481         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
3482         this to the symtab builder.
3483         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
3484         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
3485         through to dwarf_record_line_1.
3486         * infrun.c (process_event_stop_test): When stepping, don't stop at
3487         a non-statement instruction, and only refresh the step info when
3488         we land in the middle of a line's range.  Also add an extra
3489         comment.
3490         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
3491         field.
3492         * record-btrace.c (btrace_find_line_range): Only record lines
3493         marked as is-statement.
3494         * stack.c (frame_show_address): Show the frame address if we are
3495         in a non-statement sal.
3496         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
3497         (maintenance_print_one_line_table): Print a header for the is_stmt
3498         column, and include is_stmt information in the output.
3499         * symtab.c (find_pc_sect_line): Find lines marked as statements in
3500         preference to non-statements.
3501         (find_pcs_for_symtab_line): Prefer is-statement entries.
3502         (find_line_common): Likewise.
3503         * symtab.h (struct linetable_entry): Add is_stmt field.
3504         (struct symtab_and_line): Likewise.
3505         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
3506         arranging the line table.
3507
3508 2020-03-07  Tom de Vries  <tdevries@suse.de>
3509
3510         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
3511         DIE.
3512
3513 2020-03-07  Tom Tromey  <tom@tromey.com>
3514
3515         * valops.c (value_literal_complex): Remove obsolete comment.
3516         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
3517         comment.
3518
3519 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
3520
3521         * infrun.h: Forward-declare thread_info.
3522         (set_step_info): Add thread_info parameter, add doc.
3523         * infrun.c (set_step_info): Add thread_info parameter, move doc
3524         to header.
3525         * infrun.c (process_event_stop_test): Pass thread to
3526         set_step_info call.
3527         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
3528         set_step_info.
3529         (prepare_one_step): Add thread_info parameter, pass it to
3530         set_step_frame and prepare_one_step (recursive) call.
3531         (step_1): Pass thread to prepare_one_step call.
3532         (step_command_fsm::should_stop): Pass thread to
3533         prepare_one_step.
3534         (until_next_fsm): Pass thread to set_step_frame call.
3535         (finish_command): Pass thread to set_step_info call.
3536
3537 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
3538
3539         * windows-tdep.c (windows_solib_create_inferior_hook):
3540         Check if inferior is running.
3541
3542 2020-03-06  Tom de Vries  <tdevries@suse.de>
3543
3544         * NEWS: Fix "the the".
3545         * ctfread.c: Same.
3546
3547 2020-03-06  Tom de Vries  <tdevries@suse.de>
3548
3549         * psymtab.c (psymtab_to_symtab): Don't print "done.".
3550
3551 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3552
3553         * .dir-locals.el: Add a comment referencing the other copies of
3554         this file.
3555
3556 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
3557
3558         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
3559         psargs.
3560
3561 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3562
3563         * .gitattributes: New file.
3564
3565 2020-03-04  Tom Tromey  <tom@tromey.com>
3566
3567         * symmisc.c (print_symbol_bcache_statistics)
3568         (print_objfile_statistics): Update.
3569         * symfile.c (allocate_symtab): Use intern.
3570         * psymtab.c (partial_symtab::partial_symtab): Use intern.
3571         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3572         macro_cache>: Remove.
3573         <string_cache>: New member.
3574         (struct objfile) <intern>: New methods.
3575         * elfread.c (elf_symtab_read): Use intern.
3576         * dwarf2/read.c (fixup_go_packaging): Intern package name.
3577         (dwarf2_compute_name, dwarf2_physname)
3578         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
3579         names.
3580         (guess_partial_die_structure_name): Update.
3581         (partial_die_info::fixup): Intern name.
3582         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
3583         name.
3584         (dwarf2_name): Intern name.  Update.
3585         * buildsym.c (buildsym_compunit::get_macro_table): Use
3586         string_cache.
3587
3588 2020-03-04  Tom Tromey  <tom@tromey.com>
3589
3590         * jit.c (bfd_open_from_target_memory): Make "target" const.
3591         * corefile.c (gnutarget): Now const.
3592         * gdbcore.h (gnutarget): Now const.
3593
3594 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
3595
3596         * NEWS: Mention support for WOW64 processes.
3597         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
3598         (amd64_windows_segment_register_p): Remove static.
3599         (_initialize_amd64_windows_nat): Update.
3600         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
3601         * i386-windows-nat.c (context_offset): Update.
3602         (i386_mappings): Rename and remove static.
3603         (i386_windows_segment_register_p): Remove static.
3604         (_initialize_i386_windows_nat): Update.
3605         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
3606         (STATUS_WX86_SINGLE_STEP): New macro.
3607         (EnumProcessModulesEx): New macro.
3608         (Wow64SuspendThread): New macro.
3609         (Wow64GetThreadContext): New macro.
3610         (Wow64SetThreadContext): New macro.
3611         (Wow64GetThreadSelectorEntry): New macro.
3612         (windows_set_context_register_offsets): Add static.
3613         (windows_set_segment_register_p): Likewise.
3614         (windows_add_thread): Adapt for WOW64 processes.
3615         (windows_fetch_one_register): Likewise.
3616         (windows_nat_target::fetch_registers): Likewise.
3617         (windows_store_one_register): Likewise.
3618         (display_selector): Likewise.
3619         (display_selectors): Likewise.
3620         (handle_exception): Likewise.
3621         (windows_continue): Likewise.
3622         (windows_nat_target::resume): Likewise.
3623         (windows_add_all_dlls): Likewise.
3624         (do_initial_windows_stuff): Likewise.
3625         (windows_nat_target::attach): Likewise.
3626         (windows_get_exec_module_filename): Likewise.
3627         (windows_nat_target::create_inferior): Likewise.
3628         (windows_xfer_siginfo): Likewise.
3629         (_initialize_loadable): Initialize Wow64SuspendThread,
3630         Wow64GetThreadContext, Wow64SetThreadContext,
3631         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
3632         * windows-nat.h (windows_set_context_register_offsets):
3633         Remove declaration.
3634         (windows_set_segment_register_p): Likewise.
3635         (i386_windows_segment_register_p): Add declaration.
3636         (amd64_windows_segment_register_p): Likewise.
3637
3638 2020-03-04  Luis Machado  <luis.machado@linaro.org>
3639
3640         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
3641         in "info registers" for AArch64/ARM.
3642
3643         The change caused "info registers" to not print GPR's.
3644
3645         gdb/ChangeLog:
3646
3647         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3648
3649         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3650         when reg->group is empty and reggroup is not.
3651
3652 2020-03-03  Tom Tromey  <tromey@adacore.com>
3653
3654         * dwarf2/frame.c (struct dwarf2_frame_cache)
3655         <checked_tailcall_bottom, entry_cfa_sp_offset,
3656         entry_cfa_sp_offset_p>: Remove members.
3657         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
3658         (dwarf2_frame_prev_register): Don't call
3659         dwarf2_tailcall_sniffer_first.
3660         (dwarf2_append_unwinders): Don't append tailcall unwinder.
3661         * frame-unwind.c (add_unwinder): New fuction.
3662         (frame_unwind_init): Use it.  Add tailcall unwinder.
3663
3664 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3665             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3666
3667         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
3668         value should be printed as true.
3669
3670 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
3671
3672         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
3673         (windows_init_abi): Set and use windows_so_ops.
3674
3675 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
3676
3677         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
3678         when verifying if dealing with a convenience variable.
3679
3680 2020-03-03  Luis Machado  <luis.machado@linaro.org>
3681
3682         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
3683
3684 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3685
3686         * infrun.c (gdbarch_supports_displaced_stepping): New.
3687         (use_displaced_stepping): Break up conditions in smaller pieces.
3688         Use gdbarch_supports_displaced_stepping.
3689         (displaced_step_prepare_throw): Use
3690         gdbarch_supports_displaced_stepping.
3691
3692 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3693
3694         * NEWS: Mention new behaviour of the history filename.
3695         * top.c (write_history_p): Add comment.
3696         (show_write_history_p): Add header comment, give a different
3697         message when history writing is on, but the history filename is
3698         empty.
3699         (history_filename): Add comment.
3700         (history_filename_empty): New function.
3701         (show_history_filename): Add header comment, give a different
3702         message when the filename is empty.
3703         (init_history): Compare history_filename against nullptr, and only
3704         read history if the filename is not empty.
3705         (set_history_filename): Add header comment, and only make
3706         non-empty filenames absolute.
3707         (init_main): Make the filename argument to 'set history filename'
3708         optional.
3709
3710 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
3711
3712         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
3713         (arm_supply_vfpregset): ...this, and update to use VFP registers.
3714         (fetch_fp_register): Update.
3715         (fetch_fp_regs): Update.
3716         (store_fp_register): Update.
3717         (store_fp_regs): Update.
3718         (arm_netbsd_nat_target::read_description): New function.
3719         (fetch_elfcore_registers): Update.
3720
3721 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3722
3723         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
3724         general_thread if the stop reply is missing a thread-id.
3725         (remote_target::process_stop_reply): Use the first non-exited
3726         thread if the target didn't pass a thread-id.
3727         * infrun.c (do_target_wait): Move call to
3728         switch_to_inferior_no_thread to ....
3729         (do_target_wait_1): ... here.
3730
3731 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
3732
3733         * debuginfod-support.c: Include defs.h first.
3734
3735 2020-02-28  Tom de Vries  <tdevries@suse.de>
3736
3737         * symfile.c (set_initial_language): Use default language for lookup.
3738
3739 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
3740
3741         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
3742         reader variable, pass `this` to read_cutu_die_from_dwo.
3743
3744 2020-02-27  Aaron Merey  <amerey@redhat.com>
3745
3746         * source.c (open_source_file): Check for nullptr when computing
3747         srcpath.
3748
3749 2020-02-27  Tom Tromey  <tromey@adacore.com>
3750
3751         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
3752         member.
3753         (dwarf2_add_field): Don't update nfields.
3754         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
3755
3756 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3757
3758         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
3759         abs.
3760
3761 2020-02-26  Tom Tromey  <tom@tromey.com>
3762
3763         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
3764         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
3765         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
3766         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
3767         per_cu_data.
3768
3769 2020-02-26  Tom Tromey  <tom@tromey.com>
3770
3771         * dwarf2/index-write.c (psym_index_map): Change type.
3772         (add_address_entry_worker, write_one_signatured_type)
3773         (recursively_count_psymbols, recursively_write_psymbols)
3774         (class debug_names, psyms_seen_size, write_gdbindex)
3775         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
3776
3777 2020-02-26  Aaron Merey  <amerey@redhat.com>
3778
3779         * Makefile.in: Handle optional debuginfod support.
3780         * NEWS: Update.
3781         * README: Add --with-debuginfod summary.
3782         * config.in: Regenerate.
3783         * configure: Regenerate.
3784         * configure.ac: Handle optional debuginfod support.
3785         * debuginfod-support.c: debuginfod helper functions.
3786         * debuginfod-support.h: Ditto.
3787         * doc/gdb.texinfo: Add --with-debuginfod to configure options
3788         summary.
3789         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
3790         when a dwz file cannot be found.
3791         * elfread.c (elf_symfile_read): Query debuginfod servers when a
3792         debuginfo file cannot be found.
3793         * source.c (open_source_file): Query debuginfod servers when a
3794         source file cannot be found.
3795         * top.c (print_gdb_configuration): Include
3796         --{with,without}-debuginfod in the output.
3797
3798 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
3799
3800         * thread.c (thr_try_catch_cmd): Print thread name.
3801
3802 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
3803
3804         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
3805         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3806         dwarf2_fetch_die_type_sect_off): Move to...
3807         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
3808         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3809         dwarf2_fetch_die_type_sect_off): ... here.
3810         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
3811         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3812         dwarf2_fetch_die_type_sect_off): Move doc to header file.
3813
3814 2020-02-26  Tom de Vries  <tdevries@suse.de>
3815
3816         PR gdb/25603
3817         * symfile.c (set_initial_language): Exit-early if
3818         language_mode == language_mode_manual.
3819
3820 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3821
3822         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
3823         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
3824         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
3825
3826 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
3827
3828         * gdbtypes.c (create_array_type_with_stride): Handle negative
3829         array strides.
3830         * valarith.c (value_subscripted_rvalue): Likewise.
3831
3832 2020-02-25  Luis Machado  <luis.machado@linaro.org>
3833
3834         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
3835
3836 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3837
3838         * loc.h (dwarf2_get_die_type): Move to...
3839         * read.h (dwarf2_get_die_type): ... here.
3840         * read.c (dwarf2_get_die_type): Move doc to header.
3841
3842 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
3843
3844         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
3845         'gnulib/Makefile.in' to the list.
3846
3847 2020-02-24  Tom Tromey  <tom@tromey.com>
3848
3849         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
3850         Remove.
3851         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
3852         XOBNEWVEC.
3853
3854 2020-02-24  Tom Tromey  <tom@tromey.com>
3855
3856         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
3857         New method.
3858         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
3859         (dw2_do_instantiate_symtab, dw2_get_file_names)
3860         (build_type_psymtab_dependencies, load_full_type_unit): Update.
3861
3862 2020-02-24  Tom Tromey  <tom@tromey.com>
3863
3864         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
3865         make_scoped_restore.
3866         (dwarf2_psymtab::read_symtab): Don't clear
3867         reading_partial_symbols.
3868
3869 2020-02-24  Tom de Vries  <tdevries@suse.de>
3870
3871         PR gdb/25592
3872         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
3873
3874 2020-02-24  Tom de Vries  <tdevries@suse.de>
3875
3876         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
3877         commands layout next/prev/regs.
3878
3879 2020-02-22  Tom Tromey  <tom@tromey.com>
3880
3881         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
3882         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
3883
3884 2020-02-22  Tom Tromey  <tom@tromey.com>
3885
3886         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
3887
3888 2020-02-22  Tom Tromey  <tom@tromey.com>
3889
3890         * tui/tui-win.c (_initialize_tui_win): Add usage text.
3891         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
3892         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
3893         * tui/tui.c (_initialize_tui): Add usage text.
3894
3895 2020-02-22  Tom Tromey  <tom@tromey.com>
3896
3897         * tui/tui-win.c (tui_set_focus_command)
3898         (tui_set_win_height_command): Use error_no_arg.
3899         (_initialize_tui_win): Update help text.
3900         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
3901
3902 2020-02-22  Tom Tromey  <tom@tromey.com>
3903
3904         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
3905         * tui/tui-disasm.h (struct tui_disasm_window)
3906         <display_start_addr>: Declare.
3907         * tui/tui-source.h (struct tui_source_window)
3908         <display_start_addr>: Declare.
3909         * tui/tui-winsource.h (struct tui_source_window_base)
3910         <show_source_line, display_start_addr>: New methods.
3911         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
3912         Rename and move to protected section.
3913         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
3914         (tui_source_window_base::do_erase_source_content): Update.
3915         (tui_source_window_base::show_source_line): Now a method.
3916         (tui_source_window_base::show_source_content)
3917         (tui_source_window_base::tui_source_window_base)
3918         (tui_source_window_base::rerender)
3919         (tui_source_window_base::refill)
3920         (tui_source_window_base::do_scroll_horizontal)
3921         (tui_source_window_base::set_is_exec_point_at)
3922         (tui_source_window_base::update_breakpoint_info)
3923         (tui_source_window_base::update_exec_info): Update.
3924         * tui/tui-source.c (tui_source_window::set_contents)
3925         (tui_source_window::showing_source_p)
3926         (tui_source_window::do_scroll_vertical)
3927         (tui_source_window::location_matches_p)
3928         (tui_source_window::line_is_displayed): Update.
3929         (tui_source_window::display_start_addr): New method.
3930         * tui/tui-disasm.c (tui_disasm_window::set_contents)
3931         (tui_disasm_window::do_scroll_vertical)
3932         (tui_disasm_window::location_matches_p): Update.
3933         (tui_disasm_window::display_start_addr): New method.
3934
3935 2020-02-22  Tom Tromey  <tom@tromey.com>
3936
3937         * NEWS: Add entry for gdb.register_window_type.
3938         * tui/tui-layout.h (window_factory): New typedef.
3939         (tui_register_window): Declare.
3940         * tui/tui-layout.c (saved_tui_windows): New global.
3941         (tui_apply_current_layout): Use it.
3942         (tui_register_window): New function.
3943         * python/python.c (do_start_initialization): Call
3944         gdbpy_initialize_tui.
3945         (python_GdbMethods): Add "register_window_type" function.
3946         * python/python-internal.h (gdbpy_register_tui_window)
3947         (gdbpy_initialize_tui): Declare.
3948         * python/py-tui.c: New file.
3949         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
3950
3951 2020-02-22  Tom Tromey  <tom@tromey.com>
3952
3953         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
3954
3955 2020-02-22  Tom Tromey  <tom@tromey.com>
3956
3957         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
3958         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
3959         * tui/tui-data.c (tui_set_win_with_focus): Remove.
3960         (tui_set_win_focus_to): Move from tui-win.c.
3961
3962 2020-02-22  Tom Tromey  <tom@tromey.com>
3963
3964         * tui/tui-layout.c (make_standard_window, get_locator_window): New
3965         functions.
3966         (known_window_types): New global.
3967         (tui_get_window_by_name): Reimplement.
3968         (initialize_known_windows): New function.
3969         (validate_window_name): Rewrite.
3970         (_initialize_tui_layout): Call initialize_known_windows.
3971
3972 2020-02-22  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
3975         Remove constants.
3976         * tui/tui-winsource.h (struct tui_source_window_base)
3977         <tui_source_window_base>: Remove parameter.
3978         * tui/tui-winsource.c
3979         (tui_source_window_base::tui_source_window_base): Remove
3980         parameter.
3981         (tui_source_window_base::refill): Update.
3982         * tui/tui-stack.h (struct tui_locator_window)
3983         <tui_locator_window>: Update.
3984         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
3985         Default the constructor.
3986         * tui/tui-regs.h (struct tui_data_item_window)
3987         <tui_data_item_window>: Default the constructor.
3988         (struct tui_data_window) <tui_data_window>: Likewise.
3989         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
3990         Default the constructor.
3991         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
3992         Default the constructor.
3993         <type>: Remove.
3994         (struct tui_win_info) <tui_win_info>: Default the constructor.
3995         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
3996         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
3997         Default the constructor.
3998
3999 2020-02-22  Tom Tromey  <tom@tromey.com>
4000
4001         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
4002         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
4003         * tui/tui-win.c (tui_resize_all): Don't call
4004         tui_delete_invisible_windows.
4005         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
4006         done.
4007         (tui_set_layout): Update.
4008         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
4009         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
4010         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
4011
4012 2020-02-22  Tom Tromey  <tom@tromey.com>
4013
4014         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
4015         correctly.
4016
4017 2020-02-22  Tom Tromey  <tom@tromey.com>
4018
4019         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
4020
4021 2020-02-22  Tom Tromey  <tom@tromey.com>
4022
4023         * tui/tui-winsource.h (struct tui_source_window_iterator)
4024         <inner_iterator>: New etytypedef.
4025         <tui_source_window_iterator>: Take "end" parameter.
4026         <tui_source_window_iterator>: Take iterator.
4027         <operator*, advance>: Update.
4028         <m_iter>: Change type.
4029         <m_end>: New field.
4030         (struct tui_source_windows) <begin, end>: Update.
4031         * tui/tui-layout.c (tui_windows): New global.
4032         (tui_apply_current_layout): Clear tui_windows.
4033         (tui_layout_window::apply): Update tui_windows.
4034         * tui/tui-data.h (tui_windows): Declare.
4035         (all_tui_windows): Now inline function.
4036         (class tui_window_iterator, struct all_tui_windows): Remove.
4037
4038 2020-02-22  Tom Tromey  <tom@tromey.com>
4039
4040         PR tui/17850:
4041         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
4042         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
4043         "height" argument.
4044         (class tui_layout_window) <get_sizes>: Likewise.
4045         (class tui_layout_split) <tui_layout_split>: Add "vertical"
4046         argument.
4047         <get_sizes>: Add "height" argument.
4048         <m_vertical>: New field.
4049         * tui/tui-layout.c (tui_layout_split::clone): Update.
4050         (tui_layout_split::get_sizes): Add "height" argument.
4051         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
4052         (tui_new_layout_command): Parse "-horizontal".
4053         (_initialize_tui_layout): Update help string.
4054         (tui_layout_split::specification): Add "-horizontal" when needed.
4055         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
4056         argument.
4057         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
4058         New methods.
4059
4060 2020-02-22  Tom Tromey  <tom@tromey.com>
4061
4062         * tui/tui-layout.h (enum tui_adjust_result): New.
4063         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
4064         (class tui_layout_window) <adjust_size>: Return
4065         tui_adjust_result.  Rewrite.
4066         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
4067         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
4068
4069 2020-02-22  Tom Tromey  <tom@tromey.com>
4070
4071         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
4072         parameter and return types.
4073         (class tui_layout_base) <specification>: Add "depth".
4074         (class tui_layout_window) <specification>: Add "depth".
4075         (class tui_layout_split) <specification>: Add "depth".
4076         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
4077         and return types.
4078         (tui_new_layout_command): Parse sub-layouts.
4079         (_initialize_tui_layout): Update help string.
4080         (tui_layout_window::specification): Add "depth".
4081         (add_layout_command): Update.
4082
4083 2020-02-22  Tom Tromey  <tom@tromey.com>
4084
4085         * NEWS: Add "tui new-layout" item.
4086         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
4087         Add new-layout command to help text.
4088         (validate_window_name): New function.
4089         (tui_new_layout_command): New function.
4090         (_initialize_tui_layout): Register "new-layout".
4091         (tui_layout_window::specification): New method.
4092         (tui_layout_window::specification): New method.
4093         * tui/tui-layout.h (class tui_layout_base) <specification>: New
4094         method.
4095         (class tui_layout_window) <specification>: New method.
4096         (class tui_layout_split) <specification>: New method.
4097
4098 2020-02-22  Tom Tromey  <tom@tromey.com>
4099
4100         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
4101         * tui/tui-win.c (window_name_completer): Update comment.
4102         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
4103         Declare method.
4104         (class tui_layout_window) <replace_window>: Likewise.
4105         (class tui_layout_split) <replace_window>: Likewise.
4106         (tui_set_layout): Don't declare.
4107         (tui_set_initial_layout): Declare function.
4108         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
4109         (asm_regs_layout): New globals.
4110         (tui_current_layout, show_layout): Remove.
4111         (tui_set_layout, tui_add_win_to_layout): Rewrite.
4112         (find_layout, tui_apply_layout): New function.
4113         (layout_completer): Remove.
4114         (tui_next_layout): Reimplement.
4115         (tui_next_layout_command): New function.
4116         (tui_set_initial_layout, tui_prev_layout_command): New functions.
4117         (tui_regs_layout): Reimplement.
4118         (tui_regs_layout_command): New function.
4119         (extract_display_start_addr): Rewrite.
4120         (next_layout, prev_layout): Remove.
4121         (tui_layout_window::replace_window): New method.
4122         (tui_layout_split::replace_window): New method.
4123         (destroy_layout): New function.
4124         (layout_list): New global.
4125         (add_layout_command): New function.
4126         (initialize_layouts): Update.
4127         (tui_layout_command): New function.
4128         (_initialize_tui_layout): Install "layout" commands.
4129         * tui/tui-data.h (enum tui_layout_type): Remove.
4130         (tui_current_layout): Don't declare.
4131
4132 2020-02-22  Tom Tromey  <tom@tromey.com>
4133
4134         * tui/tui-regs.c (tui_reg_layout): Remove.
4135         (tui_reg_command): Use tui_regs_layout.
4136         * tui/tui-layout.h (tui_reg_command): Declare.
4137         * tui/tui-layout.c (tui_reg_command): New function.
4138
4139 2020-02-22  Tom Tromey  <tom@tromey.com>
4140
4141         * tui/tui.c (tui_rl_delete_other_windows): Call
4142         tui_remove_some_windows.
4143         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
4144         Declare method.
4145         (class tui_layout_window) <remove_windows>: New method.
4146         (class tui_layout_split) <remove_windows>: Declare.
4147         (tui_remove_some_windows): Declare.
4148         * tui/tui-layout.c (tui_remove_some_windows): New function.
4149         (tui_layout_split::remove_windows): New method.
4150
4151 2020-02-22  Tom Tromey  <tom@tromey.com>
4152
4153         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
4154         * tui/tui-layout.h (tui_next_layout): Declare.
4155         * tui/tui-layout.c (tui_next_layout): New function.
4156
4157 2020-02-22  Tom Tromey  <tom@tromey.com>
4158
4159         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
4160         correct coordinates.
4161
4162 2020-02-22  Tom Tromey  <tom@tromey.com>
4163
4164         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
4165         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
4166         DATA_WIN case.
4167
4168 2020-02-22  Tom Tromey  <tom@tromey.com>
4169
4170         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
4171         TUI_DISASM_WIN, not tui_win_list.
4172
4173 2020-02-22  Tom Tromey  <tom@tromey.com>
4174
4175         * valprint.c (generic_val_print_enum_1)
4176         (val_print_type_code_flags): Style member names.
4177         * rust-lang.c (val_print_struct, rust_print_enum)
4178         (rust_print_struct_def, rust_internal_print_type): Style member
4179         names.
4180         * p-valprint.c (pascal_object_print_value_fields): Style member
4181         names.  Only call fprintf_symbol_filtered for static members.
4182         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
4183         * f-valprint.c (f_val_print): Style member names.
4184         * f-typeprint.c (f_type_print_base): Style member names.
4185         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
4186         call fprintf_symbol_filtered for static members.
4187         (cp_print_class_member): Style member names.
4188         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
4189         member names.
4190         * ada-valprint.c (ada_print_scalar): Style enum names.
4191         (ada_val_print_enum): Likewise.
4192         * ada-typeprint.c (print_enum_type): Style enum names.
4193
4194 2020-02-21  Tom Tromey  <tom@tromey.com>
4195
4196         * psympriv.h (struct partial_symtab): Update comment.
4197
4198 2020-02-21  Tom Tromey  <tromey@adacore.com>
4199
4200         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
4201         type is CORE_ADDR.
4202
4203 2020-02-21  Tom de Vries  <tdevries@suse.de>
4204
4205         PR gdb/25534
4206         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
4207         if dependencies[i]->user != NULL.
4208
4209 2020-02-21  Ali Tamur  <tamur@google.com>
4210
4211         * dwarf2/read.c (dwarf2_name): Add null check.
4212
4213 2020-02-20  Tom Tromey  <tom@tromey.com>
4214
4215         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
4216         ">=", in binary search.
4217         (dwarf2_find_containing_comp_unit): New overload.
4218         (run_test): New self-test.
4219         (_initialize_dwarf2_read): Register new test.
4220
4221 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
4222
4223         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
4224         * riscv-tdep.h: Likewise.
4225         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
4226         rv32-only CSR.
4227         * features/riscv/64bit-csr.xml: Regenerated.
4228
4229 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
4230             Tom Tromey  <tom@tromey.com>
4231
4232         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
4233         of 'fputc_unfiltered'.
4234         (putchar_unfiltered): Call 'fputc_unfiltered'.
4235         (fputc_unfiltered): Call 'fputs_unfiltered'.
4236
4237 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
4238
4239         * config.in: Regenerate.
4240         * configure: Regenerate.
4241         * configure.ac: Add --with-python-libdir option.
4242         * main.c: Use WITH_PYTHON_LIBDIR.
4243
4244 2020-02-19  Tom Tromey  <tom@tromey.com>
4245
4246         * symtab.c (general_symbol_info::compute_and_set_names): Use
4247         obstack_strndup.  Simplify call to symbol_set_demangled_name.
4248
4249 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
4250
4251         * dwarf2/read.c (allocate_signatured_type_table,
4252         allocate_dwo_unit_table, allocate_type_unit_groups_table,
4253         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
4254         Remove objfile parameter, update all callers.
4255
4256 2020-02-19  Doug Evans  <dje@google.com>
4257
4258         PR rust/25535
4259         * rust-lang.c (rust_print_enum): Apply embedded_offset to
4260         rust_enum_variant calculation.
4261
4262 2020-02-19  Tom Tromey  <tromey@adacore.com>
4263
4264         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
4265
4266 2020-02-19  Tom Tromey  <tromey@adacore.com>
4267
4268         * ada-lang.c (cache_symbol): Use obstack_strdup.
4269
4270 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * configure: Regenerate.
4273
4274 2020-02-19  Tom Tromey  <tromey@adacore.com>
4275
4276         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
4277         NULL check.
4278
4279 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
4280
4281         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
4282
4283 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4284
4285         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
4286         if GDBSERVER is not defined.
4287         (riscv_tdesc_cache): Likewise, also store const target_desc.
4288         (STATIC_IN_GDB): Define.
4289         (riscv_create_target_description): Update declaration with
4290         STATIC_IN_GDB.
4291         (riscv_lookup_target_description): New function, only define if
4292         GDBSERVER is not defined.
4293         * arch/riscv.h (riscv_create_target_description): Declare only
4294         when GDBSERVER is defined.
4295         (riscv_lookup_target_description): New declaration when GDBSERVER
4296         is not defined.
4297         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
4298         (riscv_linux_read_features): ...this, and return
4299         riscv_gdbarch_features instead of target_desc.
4300         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
4301         (riscv_linux_read_description): Rename to...
4302         (riscv_linux_read_features): ...this.
4303         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
4304         Update to use riscv_gdbarch_features and
4305         riscv_lookup_target_description.
4306         * riscv-tdep.c (riscv_find_default_target_description): Use
4307         riscv_lookup_target_description instead of
4308         riscv_create_target_description.
4309
4310 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4311
4312         * valprint.c (generic_val_print_enum_1): When printing a flag
4313         enum with value 0 and there is no enumerator with value 0, print
4314         just "0" instead of "(unknown: 0x0)".
4315
4316 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4317
4318         * valprint.c (generic_val_print_enum_1): Print unknown part of
4319         flag enum in hex.
4320
4321 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4322
4323         * dwarf2/read.c (update_enumeration_type_from_children): Allow
4324         flag enums to contain duplicate enumerators.
4325         * valprint.c (generic_val_print_enum_1): Update comment.
4326
4327 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4328
4329         * dwarf2/read.c: Include "count-one-bits.h".
4330         (update_enumeration_type_from_children): If an enumerator has
4331         multiple bits set, don't treat the enumeration as a "flag enum".
4332         * valprint.c (generic_val_print_enum_1): Assert that enumerators
4333         of flag enums have 0 or 1 bit set.
4334
4335 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4336
4337         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
4338         conversion.
4339         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4340         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4341         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4342         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4343         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4344
4345 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4346
4347         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
4348
4349 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4350
4351         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
4352         displaced_step_closure_up.
4353         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4354         (struct displaced_step_closure_up):
4355         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4356         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4357         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
4358         Likewise.
4359         * gdbarch.sh (displaced_step_copy_insn): Likewise.
4360         * gdbarch.c, gdbarch.h: Re-generate.
4361         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
4362         displaced_step_closure_up.
4363         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4364         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4365         * infrun.h (displaced_step_closure_up): New type alias.
4366         (struct displaced_step_inferior_state) <step_closure>: Change
4367         type to displaced_step_closure_up.
4368         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
4369         displaced_step_closure_up.
4370         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4371
4372 2020-02-14  Tom Tromey  <tom@tromey.com>
4373
4374         * minidebug.c (gnu_debug_key): New global.
4375         (find_separate_debug_file_in_section): Use it.
4376
4377 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4378
4379         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
4380         std::unique_ptr.
4381         * gdbarch.c: Re-generate.
4382         * gdbarch.h: Re-generate.
4383         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
4384         change.
4385         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
4386         type to std::unique_ptr.
4387         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4388         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4389         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4390         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4391         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
4392         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4393         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4394         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4395         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4396
4397 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4398
4399         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
4400         std::unique_ptr.
4401         (displaced_step_clear): Rename to...
4402         (displaced_step_reset): ... this.  Just call displaced->reset ().
4403         (displaced_step_clear_cleanup): Rename to...
4404         (displaced_step_reset_cleanup): ... this.
4405         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
4406         (displaced_step_fixup): Likewise.
4407         (resume_1): Likewise.
4408         (handle_inferior_event): Restore child's memory before calling
4409         displaced_step_fixup on the parent.
4410         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
4411         to std::unique_ptr.
4412         <step_closure>: Change type to std::unique_ptr.
4413
4414 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4415
4416         * arm-tdep.c: Include count-one-bits.h.
4417         (cleanup_block_store_pc): Use count_one_bits.
4418         (cleanup_block_load_pc): Use count_one_bits.
4419         (arm_copy_block_xfer): Use count_one_bits.
4420         (thumb2_copy_block_xfer): Use count_one_bits.
4421         (thumb_copy_pop_pc_16bit): Use count_one_bits.
4422         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
4423         (thumb_get_next_pcs_raw): Use count_one_bits.
4424         (arm_get_next_pcs_raw): Use count_one_bits_l.
4425         * arch/arm.c (bitcount): Remove.
4426         * arch/arm.h (bitcount): Remove.
4427
4428 2020-02-14  Tom Tromey  <tromey@adacore.com>
4429
4430         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
4431         Update.
4432         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
4433         * dwarf2/loc.c (call_site_find_chain_1): Return
4434         unique_xmalloc_ptr.
4435         (call_site_find_chain): Likewise.
4436
4437 2020-02-14  Richard Biener  <rguenther@suse.de>
4438
4439         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
4440         on expression with division operators.
4441
4442 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4443
4444         * MAINTAINERS (Write After Approval): Adding myself.
4445
4446 2020-02-12  Tom Tromey  <tom@tromey.com>
4447
4448         * event-loop.c (event_data, gdb_event, event_handler_func):
4449         Remove.
4450
4451 2020-02-12  Tom Tromey  <tom@tromey.com>
4452
4453         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
4454         (dwarf2_frame_objfile_data): Add comment.
4455         (find_comp_unit, set_comp_unit): New functions.
4456         (dwarf2_frame_find_fde): Use find_comp_unit.
4457         (dwarf2_build_frame_info): Use set_comp_unit.
4458
4459 2020-02-12  Tom Tromey  <tom@tromey.com>
4460
4461         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
4462         (comp_unit): Don't initialize objfile.
4463         (execute_cfa_program): Add text_offset parameter.
4464         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
4465         (dwarf2_frame_cache): Update.
4466         (dwarf2_build_frame_info): Don't set "objfile" member.
4467
4468 2020-02-12  Tom Tromey  <tom@tromey.com>
4469
4470         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
4471         (decode_frame_entry): Likewise.
4472         (dwarf2_build_frame_info): Update.
4473
4474 2020-02-12  Tom Tromey  <tom@tromey.com>
4475
4476         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
4477         (decode_frame_entry_1): Use the comp_unit obstack.
4478
4479 2020-02-12  Tom Tromey  <tom@tromey.com>
4480
4481         * dwarf2/frame.c (struct comp_unit): Add initializers and
4482         constructor.
4483         (dwarf2_frame_objfile_data): Store a comp_unit.
4484         (dwarf2_frame_find_fde): Update.
4485         (dwarf2_build_frame_info): Use "new".
4486
4487 2020-02-12  Tom Tromey  <tom@tromey.com>
4488
4489         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
4490         (dwarf2_fde_table): Typedef for std::vector.
4491         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
4492         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
4493         (decode_frame_entry): Update.
4494         (dwarf2_build_frame_info): Use "new".
4495
4496 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4497
4498         * arm-tdep.c (arm_gdbarch_init): Update.
4499         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
4500         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
4501         have_neon, is_m>: Change to bool.
4502
4503 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4504
4505         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
4506
4507 2020-02-12  Tom Tromey  <tom@tromey.com>
4508
4509         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
4510
4511 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
4512
4513         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
4514         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
4515
4516 2020-02-11  Tom Tromey  <tom@tromey.com>
4517
4518         * psymtab.h: Update comment.
4519
4520 2020-02-11  Tom Tromey  <tom@tromey.com>
4521
4522         * gdb_obstack.h (struct auto_obstack): Use
4523         DISABLE_COPY_AND_ASSIGN.
4524
4525 2020-02-11  Tom Tromey  <tom@tromey.com>
4526
4527         * dwarf2/frame.h (struct objfile): Don't forward declare.
4528
4529 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4530
4531         * cris-tdep.c (cris_supply_gregset): Change signature to match
4532         what struct regset expects.
4533         (cris_regset): New struct.
4534         (fetch_core_registers): Remove.
4535         (cris_iterate_over_regset_sections): New function.
4536         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
4537         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
4538
4539 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4540
4541         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
4542         registers.
4543
4544 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4545
4546         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
4547
4548 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4549
4550         * configure: Re-generate.
4551
4552 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4553
4554         * configure: Re-generate.
4555
4556 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4557
4558         * acinclude: Update warning.m4 path.
4559         * warning.m4: Move to gdbsupport.
4560
4561 2020-02-11  Tom Tromey  <tromey@adacore.com>
4562
4563         * remote.c (remote_console_output): Update.
4564         * printcmd.c (printf_command): Update.
4565         * event-loop.c (gdb_wait_for_event): Update.
4566         * linux-nat.c (sigchld_handler): Update.
4567         * remote-sim.c (gdb_os_write_stdout): Update.
4568         (gdb_os_flush_stdout): Update.
4569         (gdb_os_flush_stderr): Update.
4570         (gdb_os_write_stderr): Update.
4571         * exceptions.c (print_exception): Update.
4572         * remote-fileio.c (remote_fileio_func_read): Update.
4573         (remote_fileio_func_write): Update.
4574         * tui/tui.c (tui_enable): Update.
4575         * tui/tui-interp.c (tui_interp::init): Update.
4576         * utils.c (init_page_info): Update.
4577         (putchar_unfiltered, fputc_unfiltered): Update.
4578         (gdb_flush): Update.
4579         (emit_style_escape): Update.
4580         (flush_wrap_buffer, fputs_maybe_filtered): Update.
4581         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
4582         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
4583         (stderr_file::write): Update.
4584         (stderr_file::puts): Update.
4585         * ui-file.h (ui_file_isatty, ui_file_write)
4586         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
4587         (ui_file_puts): Don't declare.
4588
4589 2020-02-10  Tom de Vries  <tdevries@suse.de>
4590
4591         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
4592         sentinel to char *.
4593
4594 2020-02-09  Tom de Vries  <tdevries@suse.de>
4595
4596         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
4597         filename if it matches "<artificial>".
4598
4599 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4600
4601         * windows-tdep.c (struct enum_value_name): New struct.
4602         (create_enum): New function.
4603         (windows_get_siginfo_type): Create and use enum types.
4604
4605 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4606
4607         * NEWS: Mention $_siginfo support for Windows.
4608         * windows-nat.c (handle_exception): Set siginfo_er.
4609         (windows_nat_target::mourn_inferior): Reset siginfo_er.
4610         (windows_xfer_siginfo): New function.
4611         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
4612         * windows-tdep.c (struct windows_gdbarch_data): New struct.
4613         (init_windows_gdbarch_data): New function.
4614         (get_windows_gdbarch_data): New function.
4615         (windows_get_siginfo_type): New function.
4616         (windows_init_abi): Register windows_get_siginfo_type.
4617         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
4618
4619 2020-02-08  Tom Tromey  <tom@tromey.com>
4620
4621         * dwarf2/read.c (class cutu_reader) <cutu_reader,
4622         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
4623         <keep>: Declare method.
4624         <m_keep>: Remove member.
4625         <~cutu_reader>: Remove.
4626         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4627         (cutu_reader::cutu_reader): Update.
4628         (cutu_reader::keep): Rename from ~cutu_reader.
4629         (process_psymtab_comp_unit, build_type_psymtabs_1)
4630         (process_skeletonless_type_unit, load_partial_comp_unit)
4631         (load_full_comp_unit, dwarf2_read_addr_index)
4632         (read_signatured_type): Update.
4633
4634 2020-02-08  Tom Tromey  <tom@tromey.com>
4635
4636         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
4637         "want_partial_unit" parameter.
4638         (process_psymtab_comp_unit): Change want_partial_unit to bool.
4639         Inline check for DW_TAG_partial_unit.
4640         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
4641
4642 2020-02-08  Tom Tromey  <tom@tromey.com>
4643
4644         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
4645         read.c.
4646         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
4647         read.c.
4648
4649 2020-02-08  Tom Tromey  <tom@tromey.com>
4650
4651         * dwarf2/read.c (read_address): Move to comp-unit.c.
4652         (dwarf2_rnglists_process, dwarf2_ranges_process)
4653         (read_attribute_value, dwarf_decode_lines_1)
4654         (var_decode_location, decode_locdesc): Update.
4655         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
4656         read.c.  Remove "cu" parameter.
4657         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
4658         method.
4659
4660 2020-02-08  Tom Tromey  <tom@tromey.com>
4661
4662         * dwarf2/read.c (read_attribute_value, read_indirect_string)
4663         (read_indirect_line_string): Update.
4664         * dwarf2/comp-unit.c (read_offset): Remove.
4665         (read_comp_unit_head): Update.
4666         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
4667         method.
4668         (read_offset): Don't declare.
4669
4670 2020-02-08  Tom Tromey  <tom@tromey.com>
4671
4672         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
4673         * dwarf2/read.c (struct comp_unit_head): Move to
4674         dwarf2/comp-unit.h.
4675         (enum class rcuh_kind): Move to comp-unit.h.
4676         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
4677         (read_comp_unit_head, error_check_comp_unit_head)
4678         (read_and_check_comp_unit_head): Move to comp-unit.c.
4679         (read_offset, dwarf_unit_type_name): Likewise.
4680         (create_debug_type_hash_table, read_cutu_die_from_dwo)
4681         (cutu_reader::cutu_reader, read_call_site_scope)
4682         (find_partial_die, follow_die_offset): Update.
4683         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
4684
4685 2020-02-08  Tom Tromey  <tom@tromey.com>
4686
4687         * dwarf2/read.c (read_offset_1): Move to leb.c.
4688         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
4689         (dwarf_decode_macro_bytes): Update.
4690         * dwarf2/leb.c (read_offset): Rename; move from read.c.
4691         * dwarf2/leb.h (read_offset): Declare.
4692
4693 2020-02-08  Tom Tromey  <tom@tromey.com>
4694
4695         * dwarf2/read.c (dwarf2_section_size): Remove.
4696         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
4697         Update.
4698         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
4699
4700 2020-02-08  Tom Tromey  <tom@tromey.com>
4701
4702         * dwarf2/read.c (read_initial_length): Move to leb.c.
4703         * dwarf2/leb.h (read_initial_length): Declare.
4704         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
4705         handle_nonstd parameter.
4706         * dwarf2/frame.c (read_initial_length): Remove.
4707         (decode_frame_entry_1): Update.
4708
4709 2020-02-08  Tom Tromey  <tom@tromey.com>
4710
4711         * dwarf2/loc.c (dwarf2_find_location_expression)
4712         (dwarf_evaluate_loc_desc::get_tls_address)
4713         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
4714         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
4715         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
4716         (dwarf2_compile_property_to_c)
4717         (dwarf2_loc_desc_get_symbol_read_needs)
4718         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
4719         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
4720         (loclist_describe_location, loclist_tracepoint_var_ref)
4721         (loclist_generate_c_location): Update.
4722         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
4723         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
4724         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
4725         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
4726         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
4727         (dwarf2_per_cu_data::addr_size)
4728         (dwarf2_per_cu_data::ref_addr_size)
4729         (dwarf2_per_cu_data::text_offset)
4730         (dwarf2_per_cu_data::addr_type): Now methods.
4731         (per_cu_header_read_in): Make per_cu "const".
4732         (dwarf2_version): Remove.
4733         (dwarf2_per_cu_data::int_type): Now a method.
4734         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
4735         (set_die_type, read_array_type, read_subrange_index_type)
4736         (read_tag_string_type, read_subrange_type): Update.
4737         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
4738         offset_size, ref_addr_size, text_offset, addr_type, version,
4739         objfile, int_type, addr_sized_int_type>: Declare methods.
4740
4741 2020-02-08  Tom Tromey  <tom@tromey.com>
4742
4743         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
4744         Move earlier.
4745
4746 2020-02-08  Tom Tromey  <tom@tromey.com>
4747
4748         * dwarf2/read.h (dwarf_line_debug): Declare.
4749         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
4750         * dwarf2/read.c: Move line_header code to new files.
4751         (dwarf_line_debug): No longer static.
4752         * dwarf2/line-header.c: New file.
4753         * dwarf2/line-header.h: New file.
4754
4755 2020-02-08  Tom Tromey  <tom@tromey.com>
4756
4757         * dwarf2/read.c (struct line_header) <file_full_name,
4758         file_file_name>: Return unique_xmalloc_ptr.
4759         (line_header::file_file_name): Update.
4760         (line_header::file_full_name): Update.
4761         (dw2_get_file_names_reader): Update.
4762         (macro_start_file): Update.
4763
4764 2020-02-08  Tom Tromey  <tom@tromey.com>
4765
4766         * dwarf2/read.c (struct line_header) <file_full_name,
4767         file_file_name>: Declare methods.
4768         (dw2_get_file_names_reader): Update.
4769         (file_file_name): Now a method.
4770         (file_full_name): Likewise.
4771         (macro_start_file): Update.
4772
4773 2020-02-08  Tom Tromey  <tom@tromey.com>
4774
4775         * dwarf2/read.c (dwarf_always_disassemble)
4776         (show_dwarf_always_disassemble): Move to loc.c.
4777         (_initialize_dwarf2_read): Move "always-disassemble" registration
4778         to loc.c.
4779         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
4780         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
4781         static.
4782         (show_dwarf_always_disassemble): Move from read.c.
4783         (_initialize_dwarf2loc): Move always-disassemble from read.c.
4784
4785 2020-02-08  Tom Tromey  <tom@tromey.com>
4786
4787         * dwarf2/read.c (~dwarf2_per_objfile): Update.
4788         (create_quick_file_names_table): Return htab_up.
4789         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
4790         Update.
4791         * dwarf2/read.h (struct dwarf2_per_objfile)
4792         <quick_file_names_table>: Now htab_up.
4793
4794 2020-02-08  Tom Tromey  <tom@tromey.com>
4795
4796         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
4797
4798 2020-02-08  Tom Tromey  <tom@tromey.com>
4799
4800         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
4801         Rewrite.
4802         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
4803         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
4804         (abbrev_table::abbrev_table): No longer inline.
4805         (ABBREV_HASH_SIZE): Remove.
4806         (abbrev_table::m_abbrevs): Now an htab_up.
4807
4808 2020-02-08  Tom Tromey  <tom@tromey.com>
4809
4810         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
4811         (cutu_reader): Update.
4812         (build_type_psymtabs_1): Update.
4813         * dwarf2/abbrev.c (abbrev_table::read): Rename.
4814         (abbrev_table::alloc_abbrev): Update.
4815         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
4816         (abbrev_table::read): New static method, renamed from
4817         abbrev_table_read_table.
4818         (abbrev_table::alloc_abbrev)
4819         (abbrev_table::add_abbrev): Now private.
4820         (abbrev_table::abbrev_table): Now private.
4821         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
4822
4823 2020-02-08  Tom Tromey  <tom@tromey.com>
4824
4825         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
4826         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
4827         htab_up.
4828
4829 2020-02-08  Tom Tromey  <tom@tromey.com>
4830
4831         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
4832         htab_up.
4833         (lookup_dwo_unit_in_dwp): Update.
4834         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
4835         on obstack.
4836
4837 2020-02-08  Tom Tromey  <tom@tromey.com>
4838
4839         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
4840         obstack.
4841
4842 2020-02-08  Tom Tromey  <tom@tromey.com>
4843
4844         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
4845         line_header_hash.
4846         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
4847         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
4848         Change type to htab_up.
4849
4850 2020-02-08  Tom Tromey  <tom@tromey.com>
4851
4852         * dwarf2/read.c (allocate_type_unit_groups_table): Return
4853         htab_up.  Don't allocate on obstack.
4854         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
4855         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
4856         Change type to htab_up.
4857
4858 2020-02-08  Tom Tromey  <tom@tromey.com>
4859
4860         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
4861         Change type to htab_up.
4862         * dwarf2/read.c (create_signatured_type_table_from_index)
4863         (create_signatured_type_table_from_debug_names)
4864         (create_all_type_units, add_type_unit)
4865         (lookup_dwo_signatured_type, lookup_signatured_type)
4866         (process_skeletonless_type_unit): Update.
4867         (create_debug_type_hash_table, create_debug_types_hash_table):
4868         Change type of types_htab.
4869         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
4870         htab_up.  Don't allocate on obstack.
4871         (create_cus_hash_table): Change type of cus_htab parameter.
4872         (struct dwo_file) <cus, tus>: Now htab_up.
4873         (lookup_dwo_signatured_type, lookup_dwo_cutu)
4874         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
4875         (queue_and_load_all_dwo_tus): Update.
4876         * dwarf2/index-write.c (write_gdbindex): Update.
4877         (write_debug_names): Update.
4878
4879 2020-02-08  Tom Tromey  <tom@tromey.com>
4880
4881         * dwarf2/read.h (struct dwarf2_queue_item): Move from
4882         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
4883         destructor.
4884         (struct dwarf2_per_objfile) <queue>: New member.
4885         * dwarf2/read.c (struct dwarf2_queue_item): Move to
4886         dwarf2/read.h.
4887         (dwarf2_queue, dwarf2_queue_tail): Remove.
4888         (class dwarf2_queue_guard): Add parameter to constructor.  Use
4889         DISABLE_COPY_AND_ASSIGN.
4890         <m_per_objfile>: New member.
4891         <~dwarf2_queue_guard>: Rewrite.
4892         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
4893         Update.
4894         (~dwarf2_queue_item): New.
4895
4896 2020-02-08  Tom Tromey  <tom@tromey.com>
4897
4898         * dwarf2/read.c (struct die_info) <has_children>: New member.
4899         (dw2_get_file_names_reader): Remove has_children.
4900         (dw2_get_file_names): Update.
4901         (read_cutu_die_from_dwo): Remove has_children.
4902         (cutu_reader::init_tu_and_read_dwo_dies)
4903         (cutu_reader::cutu_reader): Update.
4904         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
4905         Remove has_children.
4906         (build_type_psymtabs_1, process_skeletonless_type_unit)
4907         (load_partial_comp_unit, load_full_comp_unit): Update.
4908         (create_dwo_cu_reader): Remove has_children.
4909         (create_cus_hash_table, read_die_and_children): Update.
4910         (read_full_die_1,read_full_die): Remove has_children.
4911         (read_signatured_type): Update.
4912         (class cutu_reader) <has_children>: Remove.
4913
4914 2020-02-08  Tom Tromey  <tom@tromey.com>
4915
4916         * dwarf2/expr.c: Rename from dwarf2expr.c.
4917         * dwarf2/expr.h: Rename from dwarf2expr.h.
4918         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
4919         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
4920         * dwarf2/frame.c: Rename from dwarf2-frame.c.
4921         * dwarf2/frame.h: Rename from dwarf2-frame.h.
4922         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
4923         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
4924         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
4925         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
4926         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
4927         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
4928         * dwarf2/loc.c: Rename from dwarf2loc.c.
4929         * dwarf2/loc.h: Rename from dwarf2loc.h.
4930         * dwarf2/read.c: Rename from dwarf2read.c.
4931         * dwarf2/read.h: Rename from dwarf2read.h.
4932         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
4933         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
4934         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
4935         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
4936         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
4937         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
4938         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
4939         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
4940         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
4941         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
4942         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
4943         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
4944         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
4945         Update.
4946         * Makefile.in (COMMON_SFILES): Update.
4947         (HFILES_NO_SRCDIR): Update.
4948
4949 2020-02-08  Tom Tromey  <tom@tromey.com>
4950
4951         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
4952         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
4953
4954 2020-02-08  Tom Tromey  <tom@tromey.com>
4955
4956         * dwarf2read.h (struct die_info): Don't declare.
4957
4958 2020-02-08  Tom Tromey  <tom@tromey.com>
4959
4960         * dwarf2read.h (die_info_ptr): Remove typedef.
4961
4962 2020-02-08  Tom Tromey  <tom@tromey.com>
4963
4964         * dwarf2read.c (read_call_site_scope)
4965         (handle_data_member_location, dwarf2_add_member_fn)
4966         (mark_common_block_symbol_computed, read_common_block)
4967         (attr_to_dynamic_prop, partial_die_info::read)
4968         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
4969         (dwarf2_symbol_mark_computed, set_die_type): Update.
4970         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
4971         method.
4972         (attr_form_is_block): Don't declare.
4973         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
4974
4975 2020-02-08  Tom Tromey  <tom@tromey.com>
4976
4977         * dwarf2read.c (dwarf2_find_base_address, )
4978         (read_call_site_scope, rust_containing_type)
4979         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
4980         (handle_data_member_location, dwarf2_add_member_fn)
4981         (get_alignment, read_structure_type, process_structure_scope)
4982         (mark_common_block_symbol_computed, read_common_block)
4983         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
4984         (partial_die_info::read, read_attribute_value, new_symbol)
4985         (lookup_die_type, dwarf2_get_ref_die_offset)
4986         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
4987         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
4988         (dwarf2_symbol_mark_computed): Update.
4989         * dwarf2/attribute.h (struct attribute) <value_as_address,
4990         form_is_section_offset, form_is_constant, form_is_ref>: Declare
4991         methods.
4992         (value_as_address, attr_form_is_section_offset)
4993         (attr_form_is_constant, attr_form_is_ref): Don't declare.
4994         * dwarf2/attribute.c (attribute::value_as_address)
4995         (attribute::form_is_section_offset, attribute::form_is_constant)
4996         (attribute::form_is_ref): Now methods.
4997
4998 2020-02-08  Tom Tromey  <tom@tromey.com>
4999
5000         * dwarf2read.c (struct attribute, DW_STRING)
5001         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
5002         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
5003         (attr_form_is_block, attr_form_is_section_offset)
5004         (attr_form_is_constant, attr_form_is_ref): Move.
5005         * dwarf2/attribute.h: New file.
5006         * dwarf2/attribute.c: New file, from dwarf2read.c.
5007         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
5008
5009 2020-02-08  Tom Tromey  <tom@tromey.com>
5010
5011         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
5012         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
5013         Move.
5014         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
5015         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
5016         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
5017         abbrev.c.
5018         * dwarf2/abbrev.h: New file.
5019         * dwarf2/abbrev.c: New file, from dwarf2read.c.
5020         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
5021
5022 2020-02-08  Tom Tromey  <tom@tromey.com>
5023
5024         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
5025         (dwarf2_section_size, dwarf2_get_section_info)
5026         (create_signatured_type_table_from_debug_names)
5027         (create_addrmap_from_aranges, read_debug_names_from_section)
5028         (get_gdb_index_contents_from_section, read_comp_unit_head)
5029         (error_check_comp_unit_head, read_abbrev_offset)
5030         (create_debug_type_hash_table, init_cu_die_reader)
5031         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
5032         (read_comp_units_from_section, create_cus_hash_table)
5033         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
5034         (create_dwp_v2_section, dwarf2_rnglists_process)
5035         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
5036         (abbrev_table_read_table, read_indirect_string_at_offset_from)
5037         (read_indirect_string_from_dwz, read_addr_index_1)
5038         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
5039         (dwarf_decode_macro_bytes, dwarf_decode_macros)
5040         (fill_in_loclist_baton): Update.
5041         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
5042         get_containing_section, get_bfd_owner, get_bfd_section,
5043         get_file_name, get_id, get_flags, empty, read>: Declare methods.
5044         (dwarf2_read_section, get_section_name, get_section_file_name)
5045         (get_containing_section, get_section_bfd_owner)
5046         (get_section_bfd_section, get_section_name, get_section_file_name)
5047         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
5048         declare.
5049         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
5050         (dwarf2_section_info::get_bfd_owner)
5051         (dwarf2_section_info::get_bfd_section)
5052         (dwarf2_section_info::get_name)
5053         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
5054         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
5055         (dwarf2_section_info::read): Now methods.
5056         * dwarf-index-write.c (class debug_names): Update.
5057
5058 2020-02-08  Tom Tromey  <tom@tromey.com>
5059
5060         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
5061         Move to dwarf2/section.h.
5062         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
5063         (get_section_bfd_section, get_section_name)
5064         (get_section_file_name, get_section_id, get_section_flags)
5065         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
5066         dwarf2/section.c.
5067         * dwarf2/section.h: New file.
5068         * dwarf2/section.c: New file, from dwarf2read.c.
5069         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
5070
5071 2020-02-08  Tom Tromey  <tom@tromey.com>
5072
5073         * dwarf2read.h (read_unsigned_leb128): Don't declare.
5074         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
5075         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
5076         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
5077         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
5078         * dwarf2/leb.h: New file, from dwarf2read.c.
5079         * dwarf2/leb.c: New file, from dwarf2read.c.
5080         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
5081         Remove.
5082         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
5083         (COMMON_SFILES): Add dwarf2/leb.c.
5084
5085 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
5086
5087         GDB 9.1 released.
5088
5089 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
5090
5091         PR gdb/25190:
5092         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
5093         * gdb/remote.c (remote_console_output): Update.
5094         * gdb/ui-file.c (fputs_unfiltered): Rename to...
5095         (ui_file_puts): ...this.
5096         * gdb/ui-file.h (ui_file_puts): Add declaration.
5097         * gdb/utils.c (emit_style_escape): Update.
5098         (flush_wrap_buffer): Update.
5099         (fputs_maybe_filtered): Update.
5100         (fputs_unfiltered): Add function.
5101
5102 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
5103
5104         * gdb/event-loop.c (gdb_wait_for_event): Update.
5105         * gdb/printcmd.c (printf_command): Update.
5106         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
5107         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
5108         (gdb_os_flush_stderr): Update.
5109         * gdb/remote.c (remote_console_output): Update.
5110         * gdb/ui-file.c (gdb_flush): Rename to...
5111         (ui_file_flush): ...this.
5112         (stderr_file::write): Update.
5113         (stderr_file::puts): Update.
5114         * gdb/ui-file.h (gdb_flush): Rename to...
5115         (ui_file_flush): ...this.
5116         * gdb/utils.c (gdb_flush): Add function.
5117         * gdb/utils.h (gdb_flush): Add declaration.
5118
5119 2020-02-07  Tom Tromey  <tromey@adacore.com>
5120
5121         PR breakpoints/24915:
5122         * source.c (find_and_open_source): Do not check basenames_may_differ.
5123
5124 2020-02-07  Tom Tromey  <tom@tromey.com>
5125
5126         * README: Update gdbserver documentation.
5127         * gdbserver: Move to top level.
5128         * configure.tgt (build_gdbserver): Remove.
5129         * configure.ac: Remove --enable-gdbserver.
5130         * configure: Rebuild.
5131         * Makefile.in (distclean): Don't mention gdbserver.
5132
5133 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
5134
5135         * source-cache.c (source_cache::ensure): Surround
5136         get_plain_source_lines with a try/catch.
5137         (source_cache::get_line_charpos): Get rid of try/catch
5138         and only check for the return value of "ensure".
5139         * tui/tui-source.c (tui_source_window::set_contents):
5140         Simplify "nlines" calculation.
5141
5142 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
5143
5144         * MAINTAINERS (Write After Approval): Add myself.
5145
5146 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
5147
5148         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
5149         function call.
5150
5151 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
5152
5153         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
5154
5155 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
5156
5157         * nat/riscv-linux-tdesc.h: New file.
5158         * nat/riscv-linux-tdesc.c: New file, taking code from...
5159         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
5160         ... here.
5161         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
5162         NATDEPFILES.
5163
5164 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
5165
5166         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
5167         we don't set the fake simulator ptid to the null_ptid.
5168
5169 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
5170
5171         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
5172         * gdbthread.h (class thread_info) <resumed>: Likewise.
5173         * infrun.c (resume_1): Likewise.
5174         (proceed): Likewise.
5175         (infrun_thread_stop_requested): Likewise.
5176         (stop_all_threads): Likewise.
5177         (handle_inferior_event): Likewise.
5178         (restart_threads): Likewise.
5179         (finish_step_over): Likewise.
5180         (keep_going_stepped_thread): Likewise.
5181         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
5182         (linux_handle_extended_wait): Likewise.
5183         * record-btrace.c (get_thread_current_frame_id): Likewise.
5184         * record-full.c (record_full_wait_1): Likewise.
5185         * remote.c (remote_target::process_initial_stop_replies): Likewise.
5186         * target.c (target_resume): Likewise.
5187         * thread.c (set_running_thread): Likewise.
5188
5189 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
5190
5191         * f-valprint.c (f77_print_array_1): Changed datatype of index
5192         variable to LONGEST from int to enable it to contain bound
5193         values correctly.
5194
5195 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
5196
5197         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
5198         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
5199         offsets according to FLEN determined.
5200         (riscv_linux_nat_target::read_description): Determine FLEN
5201         dynamically.
5202         (riscv_linux_nat_target::fetch_registers): Size regset buffer
5203         according to FLEN determined.
5204         (riscv_linux_nat_target::store_registers): Likewise.
5205
5206 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
5207
5208         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
5209         when reg->group is empty and reggroup is not.
5210
5211 2020-01-31  Tom Tromey  <tromey@adacore.com>
5212
5213         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
5214         Call beneath target's mourn_inferior after unpushing.
5215
5216 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
5217
5218         PR tui/9765
5219         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
5220         have enough lines to fill the screen, still return the lowest
5221         address we found.
5222
5223 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
5224
5225         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
5226         '-', '<', and '>' commands.
5227
5228 2020-01-29  Pedro Alves  <palves@redhat.com>
5229             Sergio Durigan Junior  <sergiodj@redhat.com>
5230
5231         * infcmd.c (construct_inferior_arguments): Assert that
5232         'argc' is greater than 0.
5233
5234 2020-01-29  Luis Machado  <luis.machado@linaro.org>
5235
5236         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
5237         (BRK_INSN_MASK): Define to 0xd4200000.
5238         (aarch64_program_breakpoint_here_p): New function.
5239         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
5240         * arch-utils.c (default_program_breakpoint_here_p): Moved from
5241         breakpoint.c.
5242         * arch-utils.h (default_program_breakpoint_here_p): Moved from
5243         breakpoint.h
5244         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
5245         call gdbarch_program_breakpoint_here_p.
5246         (program_breakpoint_here): Moved to arch-utils.c, renamed to
5247         default_program_breakpoint_here_p, changed return type to bool and
5248         simplified.
5249         * breakpoint.h (program_breakpoint_here): Moved prototype to
5250         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
5251         return type to bool.
5252         * gdbarch.c: Regenerate.
5253         * gdbarch.h: Regenerate.
5254         * gdbarch.sh (program_breakpoint_here_p): New method.
5255         * infrun.c (handle_signal_stop): Call
5256         gdbarch_program_breakpoint_here_p.
5257
5258 2020-01-26  Tom Tromey  <tom@tromey.com>
5259
5260         * ctfread.c (struct ctf_fp_info): Reindent.
5261         (_initialize_ctfread): Remove.
5262
5263 2020-01-26  Tom Tromey  <tom@tromey.com>
5264
5265         * psymtab.c (partial_map_expand_apply)
5266         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
5267         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
5268         (psym_print_stats, psym_expand_symtabs_for_function)
5269         (psym_map_symbol_filenames, psym_map_matching_symbols)
5270         (psym_expand_symtabs_matching)
5271         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
5272         (maintenance_check_psymtabs): Use new methods.
5273         * psympriv.h (struct partial_symtab) <readin_p,
5274         get_compunit_symtab>: New methods.
5275         <readin, compunit_symtab>: Remove members.
5276         (struct standard_psymtab): New.
5277         (struct legacy_psymtab): Derive from standard_psymtab.
5278         * dwarf2read.h (struct dwarf2_psymtab): Derive from
5279         standard_psymtab.
5280         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
5281
5282 2020-01-26  Tom Tromey  <tom@tromey.com>
5283
5284         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
5285         read_dependencies.  Add assert.
5286         * psymtab.c (partial_symtab::read_dependencies): New method.
5287         * psympriv.h (struct partial_symtab) <read_dependencies>: New
5288         method.
5289         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
5290         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
5291         read_dependencies.
5292         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
5293         Add assert.
5294
5295 2020-01-26  Tom Tromey  <tom@tromey.com>
5296
5297         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
5298         Call expand_psymtab.
5299         (xcoff_read_symtab): Call expand_psymtab.
5300         (xcoff_start_psymtab, xcoff_end_psymtab): Set
5301         legacy_expand_psymtab.
5302         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
5303         method.
5304         (struct legacy_psymtab) <expand_psymtab>: Implement.
5305         <legacy_expand_psymtab>: New member.
5306         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
5307         (parse_partial_symbols): Set legacy_expand_psymtab.
5308         (psymtab_to_symtab_1): Change argument order.  Call
5309         expand_psymtab.
5310         (new_psymtab): Set legacy_expand_psymtab.
5311         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
5312         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
5313         expand_psymtab.
5314         (dwarf2_psymtab::expand_psymtab): Rename from
5315         psymtab_to_symtab_1.  Call expand_psymtab.
5316         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
5317         (dbx_end_psymtab): Likewise.
5318         (dbx_psymtab_to_symtab_1): Change argument order. Call
5319         expand_psymtab.
5320         (dbx_read_symtab): Call expand_psymtab.
5321         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
5322         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
5323         (ctf_psymtab::read_symtab): Call expand_psymtab.
5324
5325 2020-01-26  Tom Tromey  <tom@tromey.com>
5326
5327         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
5328         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
5329         messages.
5330         * mdebugread.c (mdebug_read_symtab): Remove prints.
5331         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
5332         assert.
5333         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
5334
5335 2020-01-26  Tom Tromey  <tom@tromey.com>
5336
5337         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
5338         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
5339         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
5340         legacy_symtab.
5341         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
5342         * psymtab.c (psymtab_to_symtab): Call method.
5343         (dump_psymtab): Update.
5344         * psympriv.h (struct partial_symtab): Add virtual destructor.
5345         <read_symtab>: New method.
5346         (struct legacy_symtab): New.
5347         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
5348         (struct pst_map) <pst>: Now a legacy_psymtab.
5349         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
5350         (new_psymtab): Use legacy_psymtab.
5351         * dwarf2read.h (struct dwarf2_psymtab): New.
5352         (struct dwarf2_per_cu_data) <psymtab>: Use it.
5353         * dwarf2read.c (dwarf2_create_include_psymtab)
5354         (dwarf2_build_include_psymtabs, create_type_unit_group)
5355         (create_partial_symtab, process_psymtab_comp_unit_reader)
5356         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
5357         (set_partial_user): Use dwarf2_psymtab.
5358         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
5359         (psymtab_to_symtab_1, process_full_comp_unit)
5360         (process_full_type_unit, dwarf2_ranges_read)
5361         (dwarf2_get_pc_bounds, psymtab_include_file_name)
5362         (dwarf_decode_lines): Use dwarf2_psymtab.
5363         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
5364         (add_address_entry_worker, write_one_signatured_type)
5365         (recursively_count_psymbols, recursively_write_psymbols)
5366         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
5367         (write_debug_names): Likewise.
5368         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
5369         <pst>: Now a legacy_psymtab.
5370         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
5371         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
5372         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
5373         * ctfread.c (struct ctf_psymtab): New.
5374         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
5375         ctf_psymtab.
5376         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
5377         (create_partial_symtab): Return a ctf_psymtab.
5378         (scan_partial_symbols): Update.
5379
5380 2020-01-26  Tom Tromey  <tom@tromey.com>
5381
5382         * xcoffread.c (xcoff_start_psymtab): Use new.
5383         * psymtab.c (partial_symtab::partial_symtab): New constructor,
5384         renamed from start_psymtab_common.
5385         * psympriv.h (struct partial_symtab): Add new constructor.
5386         (start_psymtab_common): Don't declare.
5387         * mdebugread.c (parse_partial_symbols): Use new.
5388         * dwarf2read.c (create_partial_symtab): Use new.
5389         * dbxread.c (start_psymtab): Use new.
5390         * ctfread.c (create_partial_symtab): Use new.
5391
5392 2020-01-26  Tom Tromey  <tom@tromey.com>
5393
5394         * xcoffread.c (xcoff_end_psymtab): Use new.
5395         * psymtab.c (start_psymtab_common): Use new.
5396         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
5397         Update.
5398         * psympriv.h (struct partial_symtab): Add parameters to
5399         constructor.  Don't inline.
5400         (allocate_psymtab): Don't declare.
5401         * mdebugread.c (new_psymtab): Use new.
5402         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
5403         * dbxread.c (dbx_end_psymtab): Use new.
5404
5405 2020-01-26  Tom Tromey  <tom@tromey.com>
5406
5407         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
5408         allocate_psymtab.  Update documentation.
5409         * psymtab.c (psymtab_storage::install_psymtab): Rename from
5410         allocate_psymtab.  Do not use new.
5411         (allocate_psymtab): Use new.  Update.
5412
5413 2020-01-26  Tom Tromey  <tom@tromey.com>
5414
5415         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5416         * psymtab.c (psym_print_stats): Update.
5417         * psympriv.h (struct partial_symtab) <readin,
5418         psymtabs_addrmap_supported, anonymous>: Now bool.
5419         * mdebugread.c (psymtab_to_symtab_1): Update.
5420         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
5421         (build_type_psymtabs_reader, psymtab_to_symtab_1)
5422         (process_full_comp_unit, process_full_type_unit): Update.
5423         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5424         * ctfread.c (psymtab_to_symtab): Update.
5425
5426 2020-01-26  Tom Tromey  <tom@tromey.com>
5427
5428         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
5429         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
5430         * psymtab.c (psymtab_storage): Delete psymtabs.
5431         (psymtab_storage::allocate_psymtab): Use new.
5432         (psymtab_storage::discard_psymtab): Use delete.
5433         * psympriv.h (struct partial_symtab): Add constructor and
5434         initializers.
5435
5436 2020-01-26  Tom Tromey  <tom@tromey.com>
5437
5438         * machoread.c: Do not include psympriv.h.
5439
5440 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5441
5442         * NEWS: Mention the new option and the set/show commands.
5443
5444 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5445
5446         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
5447         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
5448         (validate_exec_file): New variables, enums, functions.
5449         (exec_file_locate_attach, print_section_info): Style the filenames.
5450         (_initialize_exec): Install show_exec_file_mismatch_command and
5451          set_exec_file_mismatch_command.
5452         * gdbcore.h (validate_exec_file): Declare.
5453         * infcmd.c (attach_command): Call validate_exec_file.
5454         * remote.c ( remote_target::remote_add_inferior): Likewise.
5455
5456 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5457
5458         * frame.c (find_frame_sal): Move call to get_next_frame into more
5459         inner scope.
5460         * inline-frame.c (inilne_state) <inline_state>: Update argument
5461         types.
5462         (inilne_state) <skipped_symbol>: Rename to...
5463         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
5464         (skip_inline_frames): Build vector of skipped symbols and use this
5465         to reate the inline_state.
5466         (inline_skipped_symbol): Add a comment and some assertions, fetch
5467         skipped symbol from the list.
5468
5469 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5470
5471         * buildsym.c (lte_is_less_than): Delete.
5472         (buildsym_compunit::end_symtab_with_blockvector): Create local
5473         lambda function to sort line table entries, and use
5474         std::stable_sort instead of std::sort.
5475         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
5476         markers when looking for a previous line.
5477
5478 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5479
5480         * dwarf2read.c (lnp_state_machine::record_line): Include
5481         end_sequence parameter in debug print out.  Record the line if we
5482         are at an end_sequence marker even if it's not the start of a
5483         statement.
5484         * symmisc.c (maintenance_print_one_line_table): Print end of
5485         sequence markers with 'END' not '0'.
5486
5487 2020-01-24  Pedro Alves  <palves@redhat.com>
5488
5489         PR gdb/25410
5490         * thread.c (scoped_restore_current_thread::restore): Use
5491         switch_to_inferior_no_thread.
5492         * exec.c: Include "progspace-and-thread.h".
5493         (add_target_sections, remove_target_sections):
5494         scoped_restore_current_pspace_and_thread instead of
5495         scoped_restore_current_thread.
5496         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
5497         and aspace to the inferior before calling clone_program_space.
5498         Remove stale comment.
5499
5500 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5501
5502         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
5503         (arm_netbsd_nat_target::fetch_registers): ...this.
5504         (arm_nbsd_nat_target::store_registers): Rename to...
5505         (arm_netbsd_nat_target::store_registers): ...this.
5506
5507 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5508
5509         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5510         register_t.
5511
5512 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5513
5514         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
5515         Update comment.
5516         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
5517         Likewise.
5518         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
5519         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
5520         the correct replacement (iterate_over_regset_sections).
5521         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
5522         Update comment.
5523
5524 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
5525
5526         PR gdb/23718
5527         * gdb/python/python.c (execute_gdb_command): Call
5528         async_enable_stdin in catch block.
5529
5530 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5531
5532         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
5533         SWITCH_THRU_ALL_UIS.
5534
5535 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5536
5537         PR tui/9765
5538         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
5539         comment, add extra parameter, and update to store previous symbol
5540         when appropriate.
5541         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
5542         add extra parameter.
5543         * tui/tui-disasm.c (tui_disassemble): Update header comment,
5544         remove unneeded parameter, add try/catch around gdb_print_insn,
5545         rewrite to add items to asm_lines vector.
5546         (tui_find_backward_disassembly_start_address): New function.
5547         (tui_find_disassembly_address): Updated throughout.
5548         (tui_disasm_window::set_contents): Update for changes to
5549         tui_disassemble.
5550         (tui_disasm_window::do_scroll_vertical): No need to adjust the
5551         number of lines to scroll.
5552
5553 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
5554
5555         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
5556         (SECT_OFF_DATA): Likewise.
5557         (SECT_OFF_RODATA): Likewise.
5558         (SECT_OFF_TEXT): Likewise.
5559         (SECT_OFF_BSS): Likewise.
5560         (struct objfile) <text_section_offset, data_section_offset>: New
5561         methods.
5562         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
5563         objfile::text_section_offset.
5564         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
5565         * coffread.c (coff_symtab_read): Likewise.
5566         (enter_linenos): Likewise.
5567         (process_coff_symbol): Likewise.
5568         * ctfread.c (get_objfile_text_range): Likewise.
5569         * dtrace-probe.c (dtrace_probe::get_relocated_address):
5570         Use objfile::data_section_offset.
5571         * dwarf2-frame.c (execute_cfa_program): Use
5572         objfile::text_section_offset.
5573         (dwarf2_frame_find_fde): Likewise.
5574         * dwarf2read.c (create_addrmap_from_index): Likewise.
5575         (create_addrmap_from_aranges): Likewise.
5576         (dw2_find_pc_sect_compunit_symtab): Likewise.
5577         (process_psymtab_comp_unit_reader): Likewise.
5578         (add_partial_symbol): Likewise.
5579         (add_partial_subprogram): Likewise.
5580         (process_full_comp_unit): Likewise.
5581         (read_file_scope): Likewise.
5582         (read_func_scope): Likewise.
5583         (read_lexical_block_scope): Likewise.
5584         (read_call_site_scope): Likewise.
5585         (dwarf2_rnglists_process): Likewise.
5586         (dwarf2_ranges_process): Likewise.
5587         (dwarf2_ranges_read): Likewise.
5588         (dwarf_decode_lines_1): Likewise.
5589         (new_symbol): Likewise.
5590         (dwarf2_fetch_die_loc_sect_off): Likewise.
5591         (dwarf2_per_cu_text_offset): Likewise.
5592         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
5593         * hppa-tdep.c (read_unwind_info): Likewise.
5594         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
5595         * psympriv.h (struct partial_symtab): Likewise.
5596         * psymtab.c (find_pc_sect_psymtab): Likewise.
5597         * solib-svr4.c (enable_break): Likewise.
5598         * stap-probe.c (relocate_address): Use
5599         objfile::data_section_offset.
5600         * xcoffread.c (enter_line_range): Use
5601         objfile::text_section_offset.
5602         (read_xcoff_symtab): Likewise.
5603
5604 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5605
5606         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
5607         declaration to narrower scopes.
5608
5609 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5610
5611         * darwin-nat.h (struct darwin_exception_msg, enum
5612         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
5613         Move up.
5614         (class darwin_nat_target) <wait_1, check_new_threads,
5615         decode_exception_message, decode_message, stop_inferior,
5616         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
5617         * darwin-nat.c (darwin_check_new_threads): Rename to...
5618         (darwin_nat_target::check_new_threads): ... this.
5619         (darwin_suspend_inferior_it): Remove.
5620         (darwin_decode_exception_message): Rename to...
5621         (darwin_nat_target::decode_exception_message): ... this.
5622         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
5623         (darwin_decode_message): Rename to...
5624         (darwin_nat_target::decode_message): ... this.
5625         (cancel_breakpoint): Rename to...
5626         (darwin_nat_target::cancel_breakpoint): ... this.
5627         (darwin_wait): Rename to...
5628         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
5629         instead of iterate_over_inferiors.
5630         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
5631         (darwin_stop_inferior): Rename to...
5632         (darwin_nat_target::stop_inferior): ... this.
5633         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
5634         (darwin_init_thread_list): Rename to...
5635         (darwin_nat_target::init_thread_list): ... this.
5636         (darwin_ptrace_him): Rename to...
5637         (darwin_nat_target::ptrace_him): ... this.
5638         (darwin_nat_target::create_inferior): Pass lambda function to
5639         fork_inferior.
5640         (darwin_nat_target::detach): Call stop_inferior instead of
5641         darwin_stop_inferior.
5642         * fork-inferior.h (fork_inferior): Change init_trace_fun
5643         parameter to gdb::function_view.
5644         * fork-inferior.c (fork_inferior): Likewise.
5645
5646 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
5647
5648         * i386-cygwin-tdep.c (core_process_module_section): Update.
5649         * windows-nat.c (struct lm_info_windows): Add text_offset.
5650         (windows_xfer_shared_libraries): Update.
5651         * windows-tdep.c (windows_xfer_shared_library):
5652         Add text_offset_cached argument.
5653         * windows-tdep.h (windows_xfer_shared_library): Update.
5654
5655 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5656
5657         * gdbarch.sh: Add declaration for _initialize_gdbarch.
5658
5659 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5660
5661         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
5662         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
5663         replace with range-based for.
5664         (gdbsim_interrupt_inferior): Remove.
5665         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
5666         with a range-based for.  Inline code from
5667         gdbsim_interrupt_inferior.
5668
5669 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5670
5671         * infrun.c (proceed): Fix indentation.
5672
5673 2020-01-21  Tom Tromey  <tromey@adacore.com>
5674
5675         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
5676         * python/python.c (python_extension_ops): Update.
5677         (gdbpy_colorize): New function.
5678         * python/lib/gdb/__init__.py (colorize): New function.
5679         * extension.h (ext_lang_colorize): Declare.
5680         * extension.c (ext_lang_colorize): New function.
5681         * extension-priv.h (struct extension_language_ops) <colorize>: New
5682         member.
5683         * cli/cli-style.c (_initialize_cli_style): Update help text.
5684
5685 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5686
5687         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
5688         <cond>: Change type to bool.
5689         (aarch64_displaced_step_b_cond): Update cond to use bool type.
5690         (aarch64_displaced_step_cb): Likewise.
5691         (aarch64_displaced_step_tb): Likewise.
5692
5693 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5694
5695         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
5696         output.
5697
5698 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5699
5700         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
5701         <pc_adjust>: Adjust the documentation.
5702         (aarch64_displaced_step_fixup): Check if PC really moved before
5703         adjusting it.
5704
5705 2020-01-19  Tom Tromey  <tom@tromey.com>
5706
5707         * disasm.c (~gdb_disassembler): New destructor.
5708         (gdb_buffered_insn_length): Call disassemble_free_target.
5709         * disasm.h (class gdb_disassembler): Declare destructor.  Use
5710         DISABLE_COPY_AND_ASSIGN.
5711
5712 2020-01-19  Tom Tromey  <tom@tromey.com>
5713
5714         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
5715         (die_reader_func_ftype): Remove.
5716         (cutu_reader): New class.
5717         (dw2_get_file_names_reader): Remove "data" parameter.
5718         (dw2_get_file_names): Use cutu_reader.
5719         (create_debug_type_hash_table): Update.
5720         (read_cutu_die_from_dwo): Update comment.
5721         (lookup_dwo_unit): Add dwo_name parameter.
5722         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
5723         die_reader_func_ftype and data parameters.
5724         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
5725         Remove die_reader_func_ftype and data parameters.
5726         (~cutu_reader): New; from init_cutu_and_read_dies.
5727         (cutu_reader::cutu_reader): Rename from
5728         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
5729         and data parameters.
5730         (init_cutu_and_read_dies_simple): Remove.
5731         (struct process_psymtab_comp_unit_data): Remove.
5732         (process_psymtab_comp_unit_reader): Remove data parameter; add
5733         want_partial_unit and pretend_language parameters.
5734         (process_psymtab_comp_unit): Use cutu_reader.
5735         (build_type_psymtabs_reader): Remove data parameter.
5736         (build_type_psymtabs_1): Use cutu_reader.
5737         (process_skeletonless_type_unit): Likewise.
5738         (load_partial_comp_unit_reader): Remove.
5739         (load_partial_comp_unit): Use cutu_reader.
5740         (load_full_comp_unit_reader): Remove.
5741         (load_full_comp_unit): Use cutu_reader.
5742         (struct create_dwo_cu_data): Remove.
5743         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
5744         dwo_unit parameters.
5745         (create_cus_hash_table): Use cutu_reader.
5746         (struct dwarf2_read_addr_index_data): Remove.
5747         (dwarf2_read_addr_index_reader): Remove.
5748         (dwarf2_read_addr_index): Use cutu_reader.
5749         (read_signatured_type_reader): Remove.
5750         (read_signatured_type): Use cutu_reader.
5751
5752 2020-01-19  Tom Tromey  <tom@tromey.com>
5753
5754         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
5755         * tui/tui-wingeneral.h (class tui_suppress_output): New.
5756         (tui_wrefresh): Declare.
5757         * tui/tui-wingeneral.c (suppress_output): New global.
5758         (tui_suppress_output, ~tui_suppress_output): New constructor and
5759         destructor.
5760         (tui_wrefresh): New function.
5761         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
5762         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
5763         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
5764         method.
5765         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
5766         tui_wrefresh.
5767         (tui_data_window::no_refresh): New method.
5768         (tui_data_item_window::refresh_window): Call tui_wrefresh.
5769         (tui_reg_command): Use tui_suppress_output
5770         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
5771         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
5772         method.
5773         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
5774
5775 2020-01-19  Tom Tromey  <tom@tromey.com>
5776
5777         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5778         Handle case where symtab is null.
5779
5780 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
5781
5782         * linux-fork.c (one_fork_p): Simplify.
5783
5784 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5785
5786         * top.c (struct qt_args): Remove.
5787         (kill_or_detach): Change return type to void, replace `void *`
5788         parameter with a proper one.
5789         (print_inferior_quit_action):  Likewise.
5790         (quit_confirm): Use range-based for loop to iterate over inferiors.
5791         (quit_force): Likewise.
5792
5793 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5794
5795         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
5796         `void *` parameter with proper parameters.
5797         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
5798         (print_one_inferior): Change return type to void, replace `void *`
5799         parameter with proper parameters.
5800         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
5801         inferiors.
5802         (get_other_inferior): Remove.
5803         (mi_cmd_remove_inferior): Use range-based loop to iterate over
5804         inferiors.
5805
5806 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5807
5808         * mi/mi-interp.c (report_initial_inferior): Remove.
5809         (mi_interp::init): Use range-based for to iterate over inferiors.
5810
5811 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5812
5813         * python/py-inferior.c (build_inferior_list): Remove.
5814         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
5815
5816 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
5817
5818         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
5819         (btrace_stitch_trace): Likewise.
5820         * charset.c (intermediate_encoding): Likewise (vaild).
5821         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
5822         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
5823         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
5824
5825 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
5826
5827         * windows-tdep.c (windows_get_tlb_type):
5828         Add rtl_user_process_parameters type.
5829
5830 2020-01-16  Pedro Alves  <palves@redhat.com>
5831             Norbert Lange  <nolange79@gmail.com>
5832
5833         PR build/24805
5834         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
5835         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
5836         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
5837         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
5838         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
5839         (ps_plog): Redeclare exported functions with default visibility.
5840
5841 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
5842
5843         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
5844         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
5845
5846 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
5847
5848         * infcmd.c (post_create_inferior): Use get_thread_regcache
5849         instead of get_current_regcache.
5850
5851 2020-01-14  Tom Tromey  <tom@tromey.com>
5852
5853         PR symtab/12535:
5854         * python/python.c (gdbpy_decode_line): Treat empty string the same
5855         as no argument.
5856
5857 2020-01-14  Tom Tromey  <tom@tromey.com>
5858
5859         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
5860
5861 2020-01-14  Tom Tromey  <tom@tromey.com>
5862
5863         * nat/linux-btrace.c: Don't include <config.h>.
5864         * nat/linux-ptrace.c: Don't include <config.h>.
5865         * nat/x86-linux-dregs.c: Don't include <config.h>.
5866
5867 2020-01-14  Tom Tromey  <tom@tromey.com>
5868
5869         * configure: Rebuild.
5870         * configure.ac: Move many checks to ../gdbsupport/common.m4.
5871
5872 2020-01-14  Tom Tromey  <tom@tromey.com>
5873
5874         * nat/x86-linux-dregs.c: Include configh.h.
5875         * nat/linux-ptrace.c: Include configh.h.
5876         * nat/linux-btrace.c: Include configh.h.
5877         * defs.h: Include config.h, bfd.h.
5878         * configure.ac: Don't source common.host.
5879         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
5880         * configure: Rebuild.
5881         * acinclude.m4: Update path.
5882         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
5883         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
5884         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
5885         (CLIBS): Add LIBSUPPORT.
5886         (CDEPS): Likewise.
5887         (COMMON_SFILES): Remove gdbsupport files.
5888         (HFILES_NO_SRCDIR): Likewise.
5889         (stamp-version): Update path to create-version.sh.
5890         (ALLDEPFILES): Remove gdbsupport files.
5891
5892 2020-01-14  Tom Tromey  <tom@tromey.com>
5893
5894         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
5895         USE_WIN32API when needed.
5896         * configure.ac (USE_WIN32API): Don't define.
5897         (WIN32LIBS): Use WIN32APILIBS.
5898         * configure: Rebuild.
5899
5900 2020-01-14  Tom Tromey  <tom@tromey.com>
5901
5902         * configure: Rebuild.
5903         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
5904
5905 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5906
5907         * skip.c (skip_function_command): Make skip w/o arguments use the
5908         name of the inlined function if pc is inside any inlined function.
5909
5910 2020-01-14  Luis Machado  <luis.machado@linaro.org>
5911
5912         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
5913         * infrun.c (resume_1): Likewise.
5914         (handle_inferior_event): Remove stale comment.
5915         * linux-nat.c (linux_nat_target::resume): Update comments.
5916         (save_stop_reason): Likewise.
5917         (linux_nat_filter_event): Likewise.
5918         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
5919
5920 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5921
5922         * elfread.c (record_minimal_symbol): Set section index to 0 for
5923         non-allocatable sections.
5924
5925
5926 2020-01-13  Ali Tamur <tamur@google.com>
5927
5928         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
5929         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
5930         to gdb::optional.  Update comments.
5931         (dwo_file): Update comments.
5932         (read_attribute): Update API to take an additional out parameter,
5933         need_reprocess.  This is used to mark attributes that need other
5934         attributes (e.g. str_offsets_base) for correct computation which may not
5935         have been read yet.
5936         (read_attribute_reprocess): New function declaration.
5937         (read_addr_index): Likewise.
5938         (read_dwo_str_index): Likewise.
5939         (read_stub_str_index): Likewise.
5940         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
5941         (lookup_addr_base): New function definition.
5942         (lookup_ranges_base): Likewise.
5943         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
5944         lookup_ranges_base.
5945         (init_cutu_and_read_dies): Update comments.
5946         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
5947         unit.  This is used to inherit parent's str_offsets_base and addr_base.
5948         Update comments.
5949         (init_cutu_and_read_dies_simple): Reflect API changes.
5950         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
5951         (create_cus_hash_table): Change API to take parent compile unit.
5952         Reflect API changes.
5953         (open_and_init_dwo_file): Reflect API changes.
5954         (dwarf2_get_pc_bounds): Update comments.
5955         (dwarf2_record_block_ranges): Likewise.
5956         (read_full_die_1): Change implementation to reprocess attributes that
5957         need str_offsets_base and addr_base.
5958         (partial_die_info::read): Likewise.
5959         (read_attribute_reprocess): New function definition.
5960         (read_attribute_value): Change API to take an additional out parameter,
5961         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
5962         when a non-dwo compile unit has index based attributes.
5963         (read_attribute): Reflect API changes.
5964         (read_addr_index_1): Reflect API changes.  Update comments.
5965         (dwarf2_read_addr_index_data): Reflect API changes.
5966         (dwarf2_read_addr_index): Likewise.
5967         (read_str_index): Change API and implementation.  This becomes a helper
5968         to be used by the new string index related methods.  Update error
5969         message and comments.
5970         (read_dwo_str_index): New function definition.
5971         (read_stub_str_index): Likewise.
5972         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
5973         * symfile.h (dwarf2_debug_sections): Likewise.
5974         * xcoffread.c (dwarf2_debug_sections): Likewise.
5975
5976 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5977
5978         * gdbcore.h (struct core_fns) <core_read_registers>: Change
5979         core_reg_sect type to gdb_byte *.
5980         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
5981         * cris-tdep.c (fetch_core_registers): Likewise.
5982         * corelow.c (core_target::get_core_register_section): Change
5983         type of `contents` to gdb::byte_vector.
5984
5985 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5986
5987         * tui/tui-wingeneral.c (box_win): Position the title in the center
5988         of the border.
5989
5990 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5991
5992         * corelow.c (core_target::get_core_register_section): Use
5993           std::vector instead of alloca.
5994
5995 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5996
5997         * warning.m4: Add -Wmissing-declarations to build_warnings.
5998         * configure: Re-generate.
5999
6000 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
6001
6002         * python/python.c (init__gdb_module): Add declaration.
6003
6004 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
6005
6006         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
6007         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
6008         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
6009         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
6010         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
6011         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
6012         * ada-exp.y (_initialize_ada_exp): Add declaration.
6013         * ada-lang.c (_initialize_ada_language): Add declaration.
6014         * ada-tasks.c (_initialize_tasks): Add declaration.
6015         * agent.c (_initialize_agent): Add declaration.
6016         * aix-thread.c (_initialize_aix_thread): Add declaration.
6017         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
6018         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
6019         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
6020         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
6021         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
6022         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
6023         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
6024         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
6025         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
6026         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
6027         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
6028         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
6029         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
6030         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
6031         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
6032         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
6033         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
6034         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
6035         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
6036         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
6037         * annotate.c (_initialize_annotate): Add declaration.
6038         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
6039         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
6040         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
6041         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
6042         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
6043         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
6044         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
6045         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
6046         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
6047         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
6048         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
6049         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
6050         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
6051         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
6052         * auto-load.c (_initialize_auto_load): Add declaration.
6053         * auxv.c (_initialize_auxv): Add declaration.
6054         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
6055         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
6056         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
6057         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
6058         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
6059         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
6060         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
6061         * breakpoint.c (_initialize_breakpoint): Add declaration.
6062         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
6063         * btrace.c (_initialize_btrace): Add declaration.
6064         * charset.c (_initialize_charset): Add declaration.
6065         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
6066         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
6067         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
6068         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
6069         * cli/cli-script.c (_initialize_cli_script): Add declaration.
6070         * cli/cli-style.c (_initialize_cli_style): Add declaration.
6071         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
6072         * coffread.c (_initialize_coffread): Add declaration.
6073         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
6074         * compile/compile.c (_initialize_compile): Add declaration.
6075         * complaints.c (_initialize_complaints): Add declaration.
6076         * completer.c (_initialize_completer): Add declaration.
6077         * copying.c (_initialize_copying): Add declaration.
6078         * corefile.c (_initialize_core): Add declaration.
6079         * corelow.c (_initialize_corelow): Add declaration.
6080         * cp-abi.c (_initialize_cp_abi): Add declaration.
6081         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
6082         * cp-support.c (_initialize_cp_support): Add declaration.
6083         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
6084         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
6085         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
6086         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
6087         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
6088         * ctfread.c (_initialize_ctfread): Add declaration.
6089         * d-lang.c (_initialize_d_language): Add declaration.
6090         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
6091         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
6092         * dbxread.c (_initialize_dbxread): Add declaration.
6093         * dcache.c (_initialize_dcache): Add declaration.
6094         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
6095         * disasm.c (_initialize_disasm): Add declaration.
6096         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
6097         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
6098         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
6099         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
6100         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
6101         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
6102         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
6103         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
6104         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
6105         * elfread.c (_initialize_elfread): Add declaration.
6106         * exec.c (_initialize_exec): Add declaration.
6107         * extension.c (_initialize_extension): Add declaration.
6108         * f-lang.c (_initialize_f_language): Add declaration.
6109         * f-valprint.c (_initialize_f_valprint): Add declaration.
6110         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
6111         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
6112         * filesystem.c (_initialize_filesystem): Add declaration.
6113         * findcmd.c (_initialize_mem_search): Add declaration.
6114         * findvar.c (_initialize_findvar): Add declaration.
6115         * fork-child.c (_initialize_fork_child): Add declaration.
6116         * frame-base.c (_initialize_frame_base): Add declaration.
6117         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
6118         * frame.c (_initialize_frame): Add declaration.
6119         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
6120         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
6121         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
6122         * gcore.c (_initialize_gcore): Add declaration.
6123         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
6124         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
6125         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
6126         * gdbarch.c (_initialize_gdbarch): Add declaration.
6127         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
6128         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
6129         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
6130         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
6131         * go-lang.c (_initialize_go_language): Add declaration.
6132         * go32-nat.c (_initialize_go32_nat): Add declaration.
6133         * guile/guile.c (_initialize_guile): Add declaration.
6134         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
6135         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
6136         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
6137         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
6138         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
6139         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
6140         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
6141         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
6142         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
6143         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
6144         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
6145         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
6146         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
6147         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
6148         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
6149         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
6150         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
6151         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
6152         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
6153         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
6154         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
6155         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
6156         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
6157         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
6158         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
6159         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
6160         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
6161         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
6162         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
6163         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
6164         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
6165         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
6166         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
6167         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
6168         * infcall.c (_initialize_infcall): Add declaration.
6169         * infcmd.c (_initialize_infcmd): Add declaration.
6170         * inflow.c (_initialize_inflow): Add declaration.
6171         * infrun.c (_initialize_infrun): Add declaration.
6172         * interps.c (_initialize_interpreter): Add declaration.
6173         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
6174         * jit.c (_initialize_jit): Add declaration.
6175         * language.c (_initialize_language): Add declaration.
6176         * linux-fork.c (_initialize_linux_fork): Add declaration.
6177         * linux-nat.c (_initialize_linux_nat): Add declaration.
6178         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
6179         * linux-thread-db.c (_initialize_thread_db): Add declaration.
6180         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
6181         * m2-lang.c (_initialize_m2_language): Add declaration.
6182         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
6183         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
6184         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
6185         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
6186         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
6187         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
6188         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
6189         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
6190         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
6191         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
6192         * machoread.c (_initialize_machoread): Add declaration.
6193         * macrocmd.c (_initialize_macrocmd): Add declaration.
6194         * macroscope.c (_initialize_macroscope): Add declaration.
6195         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
6196         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
6197         * maint.c (_initialize_maint_cmds): Add declaration.
6198         * mdebugread.c (_initialize_mdebugread): Add declaration.
6199         * memattr.c (_initialize_mem): Add declaration.
6200         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
6201         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
6202         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
6203         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
6204         * mi/mi-main.c (_initialize_mi_main): Add declaration.
6205         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
6206         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
6207         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
6208         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
6209         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
6210         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
6211         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
6212         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
6213         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
6214         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
6215         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
6216         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
6217         * mipsread.c (_initialize_mipsread): Add declaration.
6218         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
6219         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
6220         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
6221         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
6222         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
6223         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
6224         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
6225         * nto-procfs.c (_initialize_procfs): Add declaration.
6226         * objc-lang.c (_initialize_objc_language): Add declaration.
6227         * observable.c (_initialize_observer): Add declaration.
6228         * opencl-lang.c (_initialize_opencl_language): Add declaration.
6229         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
6230         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
6231         * osabi.c (_initialize_gdb_osabi): Add declaration.
6232         * osdata.c (_initialize_osdata): Add declaration.
6233         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
6234         * parse.c (_initialize_parse): Add declaration.
6235         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
6236         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
6237         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
6238         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
6239         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
6240         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
6241         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
6242         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
6243         * printcmd.c (_initialize_printcmd): Add declaration.
6244         * probe.c (_initialize_probe): Add declaration.
6245         * proc-api.c (_initialize_proc_api): Add declaration.
6246         * proc-events.c (_initialize_proc_events): Add declaration.
6247         * proc-service.c (_initialize_proc_service): Add declaration.
6248         * procfs.c (_initialize_procfs): Add declaration.
6249         * producer.c (_initialize_producer): Add declaration.
6250         * psymtab.c (_initialize_psymtab): Add declaration.
6251         * python/python.c (_initialize_python): Add declaration.
6252         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
6253         * record-btrace.c (_initialize_record_btrace): Add declaration.
6254         * record-full.c (_initialize_record_full): Add declaration.
6255         * record.c (_initialize_record): Add declaration.
6256         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
6257         * regcache.c (_initialize_regcache): Add declaration.
6258         * reggroups.c (_initialize_reggroup): Add declaration.
6259         * remote-notif.c (_initialize_notif): Add declaration.
6260         * remote-sim.c (_initialize_remote_sim): Add declaration.
6261         * remote.c (_initialize_remote): Add declaration.
6262         * reverse.c (_initialize_reverse): Add declaration.
6263         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
6264         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
6265         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
6266         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
6267         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
6268         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
6269         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
6270         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
6271         Add declaration.
6272         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
6273         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
6274         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
6275         * rust-exp.y (_initialize_rust_exp): Add declaration.
6276         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
6277         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
6278         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
6279         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
6280         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
6281         * score-tdep.c (_initialize_score_tdep): Add declaration.
6282         * ser-go32.c (_initialize_ser_dos): Add declaration.
6283         * ser-mingw.c (_initialize_ser_windows): Add declaration.
6284         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
6285         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
6286         * ser-uds.c (_initialize_ser_socket): Add declaration.
6287         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
6288         * serial.c (_initialize_serial): Add declaration.
6289         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
6290         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
6291         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
6292         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
6293         * skip.c (_initialize_step_skip): Add declaration.
6294         * sol-thread.c (_initialize_sol_thread): Add declaration.
6295         * solib-aix.c (_initialize_solib_aix): Add declaration.
6296         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
6297         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
6298         * solib-frv.c (_initialize_frv_solib): Add declaration.
6299         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
6300         * solib-target.c (_initialize_solib_target): Add declaration.
6301         * solib.c (_initialize_solib): Add declaration.
6302         * source-cache.c (_initialize_source_cache): Add declaration.
6303         * source.c (_initialize_source): Add declaration.
6304         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
6305         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
6306         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
6307         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
6308         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
6309         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
6310         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
6311         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
6312         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
6313         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
6314         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
6315         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
6316         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
6317         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
6318         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
6319         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
6320         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
6321         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
6322         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
6323         * stabsread.c (_initialize_stabsread): Add declaration.
6324         * stack.c (_initialize_stack): Add declaration.
6325         * stap-probe.c (_initialize_stap_probe): Add declaration.
6326         * std-regs.c (_initialize_frame_reg): Add declaration.
6327         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
6328         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
6329         * symfile.c (_initialize_symfile): Add declaration.
6330         * symmisc.c (_initialize_symmisc): Add declaration.
6331         * symtab.c (_initialize_symtab): Add declaration.
6332         * target.c (_initialize_target): Add declaration.
6333         * target-connection.c (_initialize_target_connection): Add
6334         declaration.
6335         * target-dcache.c (_initialize_target_dcache): Add declaration.
6336         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
6337         * thread.c (_initialize_thread): Add declaration.
6338         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
6339         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
6340         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
6341         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
6342         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
6343         * tracectf.c (_initialize_ctf): Add declaration.
6344         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
6345         * tracefile.c (_initialize_tracefile): Add declaration.
6346         * tracepoint.c (_initialize_tracepoint): Add declaration.
6347         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
6348         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
6349         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
6350         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
6351         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
6352         * tui/tui-win.c (_initialize_tui_win): Add declaration.
6353         * tui/tui.c (_initialize_tui): Add declaration.
6354         * typeprint.c (_initialize_typeprint): Add declaration.
6355         * ui-style.c (_initialize_ui_style): Add declaration.
6356         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
6357         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
6358         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
6359         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
6360         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
6361         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
6362         * unittests/filtered_iterator-selftests.c
6363         (_initialize_filtered_iterator_selftests): Add declaration.
6364         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
6365         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
6366         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
6367         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
6368         * unittests/main-thread-selftests.c
6369         (_initialize_main_thread_selftests): Add declaration.
6370         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
6371         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
6372         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
6373         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
6374         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
6375         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
6376         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
6377         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
6378         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
6379         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
6380         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
6381         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
6382         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
6383         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
6384         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
6385         declaration.
6386         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
6387         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
6388         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
6389         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
6390         * user-regs.c (_initialize_user_regs): Add declaration.
6391         * utils.c (_initialize_utils): Add declaration.
6392         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
6393         * valops.c (_initialize_valops): Add declaration.
6394         * valprint.c (_initialize_valprint): Add declaration.
6395         * value.c (_initialize_values): Add declaration.
6396         * varobj.c (_initialize_varobj): Add declaration.
6397         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
6398         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
6399         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
6400         * windows-nat.c (_initialize_windows_nat): Add declaration.
6401         (_initialize_check_for_gdb_ini): Add declaration.
6402         (_initialize_loadable): Add declaration.
6403         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
6404         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
6405         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
6406         * xcoffread.c (_initialize_xcoffread): Add declaration.
6407         * xml-support.c (_initialize_xml_support): Add declaration.
6408         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
6409         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
6410         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
6411         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
6412
6413 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6414
6415         * regformats/regdat.sh: Generate declaration for init function.
6416
6417 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6418
6419         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
6420         up.
6421         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
6422         close_one_inferior>: New methods.
6423         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
6424         pass down target to find_inferior_pid.
6425         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
6426         Pass down target to find_inferior_ptid.
6427         (gdbsim_target::create_inferior): Pass down target to
6428         add_thread_silent.
6429         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
6430         target down to find_inferior_ptid and switch_to_thread.
6431         (gdbsim_target::close): Update to call close_one_inferior.
6432         (struct resume_data): Remove.
6433         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
6434         directly, rather than through a void pointer.
6435         (gdbsim_target::resume): Update to call resume_one_inferior.
6436
6437 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
6438
6439         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
6440
6441 2020-01-12  Pedro Alves  <palves@redhat.com>
6442
6443         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
6444         directly for the current inferior instead of
6445         discard_all_inferiors.
6446         (discard_all_inferiors): Delete.
6447
6448 2020-01-11  Tom Tromey  <tom@tromey.com>
6449
6450         * tui/tui-wingeneral.c (box_win): Check cli_styling.
6451         * tui/tui-winsource.c (tui_source_window_base::refill): Use
6452         deprecated_safe_get_selected_frame.
6453
6454 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6455
6456         * inferior.c (print_inferior): Switch inferior before printing it.
6457
6458 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
6459             Pedro Alves  <palves@redhat.com>
6460
6461         * progspace-and-thread.c (switch_to_program_space_and_thread):
6462         Assert there's an inferior for PSPACE.  Use
6463         switch_to_inferior_no_thread to switch the inferior too.
6464         * progspace.c (program_space::~program_space): Call
6465         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
6466         (program_space::free_all_objfiles): Don't call clear_symtab_users
6467         here.
6468         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
6469
6470 2020-01-10  Pedro Alves  <palves@redhat.com>
6471
6472         * NEWS: Mention multi-target debugging, "info connections", and
6473         "add-inferior -no-connection".
6474
6475 2020-01-10  Pedro Alves  <palves@redhat.com>
6476
6477         * infrun.c: Include "target-connection.h".
6478         (check_multi_target_resumption): New.
6479         (proceed): Call it.
6480         * target-connection.c (make_target_connection_string): Make
6481         extern.
6482         * target-connection.h (make_target_connection_string): Declare.
6483
6484 2020-01-10  Pedro Alves  <palves@redhat.com>
6485
6486         * Makefile.in (COMMON_SFILES): Add target-connection.c.
6487         * inferior.c (uiout_field_connection): New function.
6488         (print_inferior): Add new "connection-id" column.
6489         (add_inferior_command): Show connection number/string of added
6490         inferior.
6491         * process-stratum-target.h
6492         (process_stratum_target::connection_string): New virtual method.
6493         (process_stratum_target::connection_number): New field.
6494         * remote.c (remote_target::connection_string): New override.
6495         * target-connection.c: New file.
6496         * target-connection.h: New file.
6497         * target.c (decref_target): Remove process_stratum targets from
6498         the connection list.
6499         (target_stack::push): Add process_stratum targets to the
6500         connection list.
6501
6502 2020-01-10  Pedro Alves  <palves@redhat.com>
6503
6504         Revert:
6505         2016-04-12  Pedro Alves  <palves@redhat.com>
6506         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
6507         Remove references to name.
6508         * serial.h (struct serial) <name>: Delete.
6509
6510 2020-01-10  Pedro Alves  <palves@redhat.com>
6511
6512         * gdbarch-selftests.c (register_to_value_test): Remove "target
6513         already pushed" check.
6514
6515 2020-01-10  Pedro Alves  <palves@redhat.com>
6516             John Baldwin  <jhb@FreeBSD.org>
6517
6518         * aarch64-linux-nat.c
6519         (aarch64_linux_nat_target::thread_architecture): Adjust.
6520         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
6521         (task_command_1): Likewise.
6522         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
6523         (aix_thread_target::wait, aix_thread_target::fetch_registers)
6524         (aix_thread_target::store_registers)
6525         (aix_thread_target::thread_alive): Adjust.
6526         * amd64-fbsd-tdep.c: Include "inferior.h".
6527         (amd64fbsd_get_thread_local_address): Pass down target.
6528         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
6529         thread's gdbarch instead of target_gdbarch.
6530         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
6531         get_last_target_status.
6532         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
6533         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
6534         inferiors.
6535         (update_inserted_breakpoint_locations): Skip if inferiors with no
6536         execution.
6537         (update_global_location_list): When handling moribund locations,
6538         find representative inferior for location's pspace, and use thread
6539         count of its process_stratum target.
6540         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
6541         * bsd-uthread.c (bsd_uthread_target::wait): Use
6542         as_process_stratum_target and adjust thread_change_ptid and
6543         add_thread calls.
6544         (bsd_uthread_target::update_thread_list): Use
6545         as_process_stratum_target and adjust find_thread_ptid,
6546         thread_change_ptid and add_thread calls.
6547         * btrace.c (maint_btrace_packet_history_cmd): Adjust
6548         find_thread_ptid call.
6549         * corelow.c (add_to_thread_list): Adjust add_thread call.
6550         (core_target_open): Adjust add_thread_silent and thread_count
6551         calls.
6552         (core_target::pid_to_str): Adjust find_inferior_ptid call.
6553         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
6554         * event-top.c (async_disconnect): Pop targets from all inferiors.
6555         * exec.c (add_target_sections): Push exec target on all inferiors
6556         sharing the program space.
6557         (remove_target_sections): Remove the exec target from all
6558         inferiors sharing the program space.
6559         (exec_on_vfork): New.
6560         * exec.h (exec_on_vfork): Declare.
6561         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
6562         Pass it down.
6563         (fbsd_nat_target::update_thread_list): Adjust.
6564         (fbsd_nat_target::resume): Adjust.
6565         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
6566         down.
6567         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
6568         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
6569         get_thread_arch_regcache call.
6570         * fork-child.c (gdb_startup_inferior): Pass target down to
6571         startup_inferior and set_executing.
6572         * gdbthread.h (struct process_stratum_target): Forward declare.
6573         (add_thread, add_thread_silent, add_thread_with_info)
6574         (in_thread_list): Add process_stratum_target parameter.
6575         (find_thread_ptid(inferior*, ptid_t)): New overload.
6576         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
6577         parameter.
6578         (all_threads()): Delete overload.
6579         (all_threads, all_non_exited_threads): Add process_stratum_target
6580         parameter.
6581         (all_threads_safe): Use brace initialization.
6582         (thread_count): Add process_stratum_target parameter.
6583         (set_resumed, set_running, set_stop_requested, set_executing)
6584         (threads_are_executing, finish_thread_state): Add
6585         process_stratum_target parameter.
6586         (switch_to_thread): Use is_current_thread.
6587         * i386-fbsd-tdep.c: Include "inferior.h".
6588         (i386fbsd_get_thread_local_address): Pass down target.
6589         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
6590         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
6591         have_inferiors check.
6592         * inf-ptrace.c (inf_ptrace_target::create_inferior)
6593         (inf_ptrace_target::attach): Adjust.
6594         * infcall.c (run_inferior_call): Adjust.
6595         * infcmd.c (run_command_1): Pass target to
6596         scoped_finish_thread_state.
6597         (proceed_thread_callback): Skip inferiors with no execution.
6598         (continue_command): Rename 'all_threads' local to avoid hiding
6599         'all_threads' function.  Adjust get_last_target_status call.
6600         (prepare_one_step): Adjust set_running call.
6601         (signal_command): Use user_visible_resume_target.  Compare thread
6602         pointers instead of inferior_ptid.
6603         (info_program_command): Adjust to pass down target.
6604         (attach_command): Mark target's 'thread_executing' flag.
6605         (stop_current_target_threads_ns): New, factored out from ...
6606         (interrupt_target_1): ... this.  Switch inferior before making
6607         target calls.
6608         * inferior-iter.h
6609         (struct all_inferiors_iterator, struct all_inferiors_range)
6610         (struct all_inferiors_safe_range)
6611         (struct all_non_exited_inferiors_range): Filter on
6612         process_stratum_target too.  Remove explicit.
6613         * inferior.c (inferior::inferior): Push dummy target on target
6614         stack.
6615         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
6616         Add process_stratum_target parameter, and pass it down.
6617         (have_live_inferiors): Adjust.
6618         (switch_to_inferior_and_push_target): New.
6619         (add_inferior_command, clone_inferior_command): Handle
6620         "-no-connection" parameter.  Use
6621         switch_to_inferior_and_push_target.
6622         (_initialize_inferior): Mention "-no-connection" option in
6623         the help of "add-inferior" and "clone-inferior" commands.
6624         * inferior.h: Include "process-stratum-target.h".
6625         (interrupt_target_1): Use bool.
6626         (struct inferior) <push_target, unpush_target, target_is_pushed,
6627         find_target_beneath, top_target, process_target, target_at,
6628         m_stack>: New.
6629         (discard_all_inferiors): Delete.
6630         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
6631         (all_inferiors, all_non_exited_inferiors): Add
6632         process_stratum_target parameter.
6633         * infrun.c: Include "gdb_select.h" and <unordered_map>.
6634         (target_last_proc_target): New global.
6635         (follow_fork_inferior): Push target on new inferior.  Pass target
6636         to add_thread_silent.  Call exec_on_vfork.  Handle target's
6637         reference count.
6638         (follow_fork): Adjust get_last_target_status call.  Also consider
6639         target.
6640         (follow_exec): Push target on new inferior.
6641         (struct execution_control_state) <target>: New field.
6642         (user_visible_resume_target): New.
6643         (do_target_resume): Call target_async.
6644         (resume_1): Set target's threads_executing flag.  Consider resume
6645         target.
6646         (commit_resume_all_targets): New.
6647         (proceed): Also consider resume target.  Skip threads of inferiors
6648         with no execution.  Commit resumtion in all targets.
6649         (start_remote): Pass current inferior to wait_for_inferior.
6650         (infrun_thread_stop_requested): Consider target as well.  Pass
6651         thread_info pointer to clear_inline_frame_state instead of ptid.
6652         (infrun_thread_thread_exit): Consider target as well.
6653         (random_pending_event_thread): New inferior parameter.  Use it.
6654         (do_target_wait): Rename to ...
6655         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
6656         down.
6657         (threads_are_resumed_pending_p, do_target_wait): New.
6658         (prepare_for_detach): Adjust calls.
6659         (wait_for_inferior): New inferior parameter.  Handle it.  Use
6660         do_target_wait_1 instead of do_target_wait.
6661         (fetch_inferior_event): Adjust.  Switch to representative
6662         inferior.  Pass target down.
6663         (set_last_target_status): Add process_stratum_target parameter.
6664         Save target in global.
6665         (get_last_target_status): Add process_stratum_target parameter and
6666         handle it.
6667         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
6668         (context_switch): Check inferior_ptid == null_ptid before calling
6669         inferior_thread().
6670         (get_inferior_stop_soon): Pass down target.
6671         (wait_one): Rename to ...
6672         (poll_one_curr_target): ... this.
6673         (struct wait_one_event): New.
6674         (wait_one): New.
6675         (stop_all_threads): Adjust.
6676         (handle_no_resumed, handle_inferior_event): Adjust to consider the
6677         event's target.
6678         (switch_back_to_stepped_thread): Also consider target.
6679         (print_stop_event): Update.
6680         (normal_stop): Update.  Also consider the resume target.
6681         * infrun.h (wait_for_inferior): Remove declaration.
6682         (user_visible_resume_target): New declaration.
6683         (get_last_target_status, set_last_target_status): New
6684         process_stratum_target parameter.
6685         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6686         process_stratum_target parameter, and use it.
6687         (clear_inline_frame_state (thread_info*)): New.
6688         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6689         process_stratum_target parameter.
6690         (clear_inline_frame_state (thread_info*)): Declare.
6691         * linux-fork.c (delete_checkpoint_command): Pass target down to
6692         find_thread_ptid.
6693         (checkpoint_command): Adjust.
6694         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
6695         instead of just tweaking inferior_ptid.
6696         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
6697         (exit_lwp): Pass target down to find_thread_ptid.
6698         (attach_proc_task_lwp_callback): Pass target down to
6699         add_thread/set_running/set_executing.
6700         (linux_nat_target::attach): Pass target down to
6701         thread_change_ptid.
6702         (get_detach_signal): Pass target down to find_thread_ptid.
6703         Consider last target status's target.
6704         (linux_resume_one_lwp_throw, resume_lwp)
6705         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
6706         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
6707         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
6708         (linux_nat_target::async_wait_fd): New.
6709         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
6710         target down.
6711         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
6712         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
6713         * linux-thread-db.c (struct thread_db_info::process_target): New
6714         field.
6715         (add_thread_db_info): Save target.
6716         (get_thread_db_info): New process_stratum_target parameter.  Also
6717         match target.
6718         (delete_thread_db_info): New process_stratum_target parameter.
6719         Also match target.
6720         (thread_from_lwp): Adjust to pass down target.
6721         (thread_db_notice_clone): Pass down target.
6722         (check_thread_db_callback): Pass down target.
6723         (try_thread_db_load_1): Always push the thread_db target.
6724         (try_thread_db_load, record_thread): Pass target down.
6725         (thread_db_target::detach): Pass target down.  Always unpush the
6726         thread_db target.
6727         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
6728         target down.  Always unpush the thread_db target.
6729         (find_new_threads_callback, thread_db_find_new_threads_2)
6730         (thread_db_target::update_thread_list): Pass target down.
6731         (thread_db_target::pid_to_str): Pass current inferior down.
6732         (thread_db_target::get_thread_local_address): Pass target down.
6733         (thread_db_target::resume, maintenance_check_libthread_db): Pass
6734         target down.
6735         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
6736         * procfs.c (procfs_target::procfs_init_inferior): Declare.
6737         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
6738         (procfs_init_inferior): Rename to ...
6739         (procfs_target::procfs_init_inferior): ... this and adjust.
6740         (procfs_target::create_inferior, procfs_notice_thread)
6741         (procfs_do_thread_registers): Adjust.
6742         * ppc-fbsd-tdep.c: Include "inferior.h".
6743         (ppcfbsd_get_thread_local_address): Pass down target.
6744         * proc-service.c (ps_xfer_memory): Switch current inferior and
6745         program space as well.
6746         (get_ps_regcache): Pass target down.
6747         * process-stratum-target.c
6748         (process_stratum_target::thread_address_space)
6749         (process_stratum_target::thread_architecture): Pass target down.
6750         * process-stratum-target.h
6751         (process_stratum_target::threads_executing): New field.
6752         (as_process_stratum_target): New.
6753         * ravenscar-thread.c
6754         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
6755         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
6756         down.
6757         * record-btrace.c (record_btrace_target::info_record): Adjust.
6758         (record_btrace_target::record_method)
6759         (record_btrace_target::record_is_replaying)
6760         (record_btrace_target::fetch_registers)
6761         (get_thread_current_frame_id, record_btrace_target::resume)
6762         (record_btrace_target::wait, record_btrace_target::stop): Pass
6763         target down.
6764         * record-full.c (record_full_wait_1): Switch to event thread.
6765         Pass target down.
6766         * regcache.c (regcache::regcache)
6767         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
6768         process_stratum_target parameter and handle it.
6769         (current_thread_target): New global.
6770         (get_thread_regcache): Add process_stratum_target parameter and
6771         handle it.  Switch inferior before calling target method.
6772         (get_thread_regcache): Pass target down.
6773         (get_thread_regcache_for_ptid): Pass target down.
6774         (registers_changed_ptid): Add process_stratum_target parameter and
6775         handle it.
6776         (registers_changed_thread, registers_changed): Pass target down.
6777         (test_get_thread_arch_aspace_regcache): New.
6778         (current_regcache_test): Define a couple local test_target_ops
6779         instances and use them for testing.
6780         (readwrite_regcache): Pass process_stratum_target parameter.
6781         (cooked_read_test, cooked_write_test): Pass mock_target down.
6782         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
6783         (get_thread_arch_aspace_regcache): Add process_stratum_target
6784         parameter.
6785         (regcache::target): New method.
6786         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
6787         (regcache::registers_changed_ptid): Add process_stratum_target
6788         parameter.
6789         (regcache::m_target): New field.
6790         (registers_changed_ptid): Add process_stratum_target parameter.
6791         * remote.c (remote_state::supports_vCont_probed): New field.
6792         (remote_target::async_wait_fd): New method.
6793         (remote_unpush_and_throw): Add remote_target parameter.
6794         (get_current_remote_target): Adjust.
6795         (remote_target::remote_add_inferior): Push target.
6796         (remote_target::remote_add_thread)
6797         (remote_target::remote_notice_new_inferior)
6798         (get_remote_thread_info): Pass target down.
6799         (remote_target::update_thread_list): Skip threads of inferiors
6800         bound to other targets.  (remote_target::close): Don't discard
6801         inferiors.  (remote_target::add_current_inferior_and_thread)
6802         (remote_target::process_initial_stop_replies)
6803         (remote_target::start_remote)
6804         (remote_target::remote_serial_quit_handler): Pass down target.
6805         (remote_target::remote_unpush_target): New remote_target
6806         parameter.  Unpush the target from all inferiors.
6807         (remote_target::remote_unpush_and_throw): New remote_target
6808         parameter.  Pass it down.
6809         (remote_target::open_1): Check whether the current inferior has
6810         execution instead of checking whether any inferior is live.  Pass
6811         target down.
6812         (remote_target::remote_detach_1): Pass down target.  Use
6813         remote_unpush_target.
6814         (extended_remote_target::attach): Pass down target.
6815         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
6816         (remote_target::append_resumption): Pass down target.
6817         (remote_target::append_pending_thread_resumptions)
6818         (remote_target::remote_resume_with_hc, remote_target::resume)
6819         (remote_target::commit_resume): Pass down target.
6820         (remote_target::remote_stop_ns): Check supports_vCont_probed.
6821         (remote_target::interrupt_query)
6822         (remote_target::remove_new_fork_children)
6823         (remote_target::check_pending_events_prevent_wildcard_vcont)
6824         (remote_target::remote_parse_stop_reply)
6825         (remote_target::process_stop_reply): Pass down target.
6826         (first_remote_resumed_thread): New remote_target parameter.  Pass
6827         it down.
6828         (remote_target::wait_as): Pass down target.
6829         (unpush_and_perror): New remote_target parameter.  Pass it down.
6830         (remote_target::readchar, remote_target::remote_serial_write)
6831         (remote_target::getpkt_or_notif_sane_1)
6832         (remote_target::kill_new_fork_children, remote_target::kill): Pass
6833         down target.
6834         (remote_target::mourn_inferior): Pass down target.  Use
6835         remote_unpush_target.
6836         (remote_target::core_of_thread)
6837         (remote_target::remote_btrace_maybe_reopen): Pass down target.
6838         (remote_target::pid_to_exec_file)
6839         (remote_target::thread_handle_to_thread_info): Pass down target.
6840         (remote_target::async_wait_fd): New.
6841         * riscv-fbsd-tdep.c: Include "inferior.h".
6842         (riscv_fbsd_get_thread_local_address): Pass down target.
6843         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
6844         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
6845         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
6846         Adjust.
6847         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
6848         * solib-svr4.c (enable_break): Pass down target.
6849         * spu-multiarch.c (parse_spufs_run): Pass down target.
6850         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
6851         * target-delegates.c: Regenerate.
6852         * target.c (g_target_stack): Delete.
6853         (current_top_target): Return the current inferior's top target.
6854         (target_has_execution_1): Refer to the passed-in inferior's top
6855         target.
6856         (target_supports_terminal_ours): Check whether the initial
6857         inferior was already created.
6858         (decref_target): New.
6859         (target_stack::push): Incref/decref the target.
6860         (push_target, push_target, unpush_target): Adjust.
6861         (target_stack::unpush): Defref target.
6862         (target_is_pushed): Return bool.  Adjust to refer to the current
6863         inferior's target stack.
6864         (dispose_inferior): Delete, and inline parts ...
6865         (target_preopen): ... here.  Only dispose of the current inferior.
6866         (target_detach): Hold strong target reference while detaching.
6867         Pass target down.
6868         (target_thread_name): Add assertion.
6869         (target_resume): Pass down target.
6870         (target_ops::beneath, find_target_at): Adjust to refer to the
6871         current inferior's target stack.
6872         (get_dummy_target): New.
6873         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
6874         has a thread running.
6875         (initialize_targets): Rename to ...
6876         (_initialize_target): ... this.
6877         * target.h: Include "gdbsupport/refcounted-object.h".
6878         (struct target_ops): Inherit refcounted_object.
6879         (target_ops::shortname, target_ops::longname): Make const.
6880         (target_ops::async_wait_fd): New method.
6881         (decref_target): Declare.
6882         (struct target_ops_ref_policy): New.
6883         (target_ops_ref): New typedef.
6884         (get_dummy_target): Declare function.
6885         (target_is_pushed): Return bool.
6886         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
6887         (all_matching_threads_iterator::all_matching_threads_iterator):
6888         Handle filter target.
6889         * thread-iter.h (struct all_matching_threads_iterator, struct
6890         all_matching_threads_range, class all_non_exited_threads_range):
6891         Filter by target too.  Remove explicit.
6892         * thread.c (threads_executing): Delete.
6893         (inferior_thread): Pass down current inferior.
6894         (clear_thread_inferior_resources): Pass down thread pointer
6895         instead of ptid_t.
6896         (add_thread_silent, add_thread_with_info, add_thread): Add
6897         process_stratum_target parameter.  Use it for thread and inferior
6898         searches.
6899         (is_current_thread): New.
6900         (thread_info::deletable): Use it.
6901         (find_thread_ptid, thread_count, in_thread_list)
6902         (thread_change_ptid, set_resumed, set_running): New
6903         process_stratum_target parameter.  Pass it down.
6904         (set_executing): New process_stratum_target parameter.  Pass it
6905         down.  Adjust reference to 'threads_executing'.
6906         (threads_are_executing): New process_stratum_target parameter.
6907         Adjust reference to 'threads_executing'.
6908         (set_stop_requested, finish_thread_state): New
6909         process_stratum_target parameter.  Pass it down.
6910         (switch_to_thread): Also match inferior.
6911         (switch_to_thread): New process_stratum_target parameter.  Pass it
6912         down.
6913         (update_threads_executing): Reimplement.
6914         * top.c (quit_force): Pop targets from all inferior.
6915         (gdb_init): Don't call initialize_targets.
6916         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
6917         Declare.
6918         (windows_add_thread, windows_delete_thread): Adjust.
6919         (get_windows_debug_event): Rename to ...
6920         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
6921         * tracefile-tfile.c (tfile_target_open): Pass down target.
6922         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
6923         Forward declare.
6924         (switch_to_thread): Add process_stratum_target parameter.
6925         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
6926         parameter.  Use it.
6927         (mi_on_resume): Pass target down.
6928         * nat/fork-inferior.c (startup_inferior): Add
6929         process_stratum_target parameter.  Pass it down.
6930         * nat/fork-inferior.h (startup_inferior): Add
6931         process_stratum_target parameter.
6932         * python/py-threadevent.c (py_get_event_thread): Pass target down.
6933
6934 2020-01-10  Pedro Alves  <palves@redhat.com>
6935
6936         * remote.c (remote_target::start_remote): Don't set inferior_ptid
6937         directly.  Instead find the first thread in the thread list and
6938         use switch_to_thread.
6939
6940 2020-01-10  Pedro Alves  <palves@redhat.com>
6941
6942         * remote.c (remote_target::remote_add_inferior): Don't bind a
6943         process to the current inferior if the current inferior is already
6944         bound to a process.
6945
6946 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6947             Pedro Alves  <palves@redhat.com>
6948
6949         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
6950         If no process is specified, return null_ptid instead of
6951         inferior_ptid.
6952         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
6953         TARGET_WAITKIND_SIGNALLED with no pid.
6954
6955 2020-01-10  Pedro Alves  <palves@redhat.com>
6956
6957         * remote.c (first_remote_resumed_thread): New.
6958         (remote_target::wait_as): Use it as default event_ptid instead of
6959         inferior_ptid.
6960
6961 2020-01-10  Pedro Alves  <palves@redhat.com>
6962
6963         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
6964
6965 2020-01-10  Pedro Alves  <palves@redhat.com>
6966
6967         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
6968         not -1.
6969
6970 2020-01-10  Pedro Alves  <palves@redhat.com>
6971
6972         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
6973         ptid to get_last_target_status.
6974         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
6975         ptid to get_last_target_status.
6976         * infcmd.c (continue_command): Don't pass a target_waitstatus to
6977         get_last_target_status.
6978         (info_program_command): Don't pass a target_waitstatus to
6979         get_last_target_status.
6980         * infrun.c (init_wait_for_inferior): Use
6981         nullify_last_target_wait_ptid.
6982         (get_last_target_status): Handle nullptr arguments.
6983         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
6984         (print_stop_event): Don't pass a ptid to get_last_target_status.
6985         (normal_stop): Don't pass a ptid to get_last_target_status.
6986         * infrun.h (get_last_target_status, set_last_target_status): Move
6987         comments here and update.
6988         (nullify_last_target_wait_ptid): Declare.
6989         * linux-fork.c (fork_load_infrun_state): Remove local extern
6990         declaration of nullify_last_target_wait_ptid.
6991         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
6992         to get_last_target_status.
6993
6994 2020-01-10  Pedro Alves  <palves@redhat.com>
6995
6996         * gdbthread.h (scoped_restore_current_thread)
6997         <dont_restore, restore, m_dont_restore>: Declare.
6998         * thread.c (thread_alive): Add assertion.  Return bool.
6999         (switch_to_thread_if_alive): New.
7000         (prune_threads): Switch inferior/thread.
7001         (print_thread_info_1): Switch thread before calling target methods.
7002         (scoped_restore_current_thread::restore): New, factored out from
7003         ...
7004         (scoped_restore_current_thread::~scoped_restore_current_thread):
7005         ... this.
7006         (scoped_restore_current_thread::scoped_restore_current_thread):
7007         Add assertion.
7008         (thread_apply_all_command, thread_select): Use
7009         switch_to_thread_if_alive.
7010         * infrun.c (proceed, restart_threads, handle_signal_stop)
7011         (switch_back_to_stepped_thread): Switch current thread before
7012         calling target methods.
7013
7014 2020-01-10  Pedro Alves <palves@redhat.com>
7015
7016         * inferior.c (switch_to_inferior_no_thread): New function,
7017         factored out from ...
7018         (inferior_command): ... here.
7019         * inferior.h (switch_to_inferior_no_thread): Declare.
7020         * mi/mi-main.c (run_one_inferior): Use
7021         switch_to_inferior_no_thread.
7022
7023 2020-01-10  Pedro Alves  <palves@redhat.com>
7024
7025         * infcmd.c (kill_command): Remove dead code.
7026
7027 2020-01-10  Pedro Alves  <palves@redhat.com>
7028
7029         * remote.c (remote_target::mourn_inferior): No longer check
7030         whether the target is running.
7031
7032 2020-01-10  Pedro Alves  <palves@redhat.com>
7033
7034         * corelow.c (core_target::has_execution): Change parameter type to
7035         inferior pointer.
7036         * inferior.c (number_of_live_inferiors): Use
7037         inferior::has_execution instead of target_has_execution_1.
7038         * inferior.h (inferior::has_execution): New.
7039         * linux-thread-db.c (thread_db_target::update_thread_list): Use
7040         inferior::has_execution instead of target_has_execution_1.
7041         * process-stratum-target.c
7042         (process_stratum_target::has_execution): Change parameter type to
7043         inferior pointer.  Check the inferior's PID instead of
7044         inferior_ptid.
7045         * process-stratum-target.h
7046         (process_stratum_target::has_execution): Change parameter type to
7047         inferior pointer.
7048         * record-full.c (record_full_core_target::has_execution): Change
7049         parameter type to inferior pointer.
7050         * target.c (target_has_execution_1): Change parameter type to
7051         inferior pointer.
7052         (target_has_execution_current): Adjust.
7053         * target.h (target_ops::has_execution): Change parameter type to
7054         inferior pointer.
7055         (target_has_execution_1): Change parameter type to inferior
7056         pointer.  Change return type to bool.
7057         * tracefile.h (tracefile_target::has_execution): Change parameter
7058         type to inferior pointer.
7059
7060 2020-01-10  Pedro Alves  <palves@redhat.com>
7061
7062         * exceptions.c (print_flush): Remove current_top_target() check.
7063
7064 2020-01-10  Pedro Alves  <palves@redhat.com>
7065
7066         * remote.c (show_remote_exec_file): Show the current inferior's
7067         exec-file instead of the command variable's value.
7068
7069 2020-01-10  Pedro Alves  <palves@redhat.com>
7070
7071         * record-full.c (record_full_resume_ptid): New global.
7072         (record_full_target::resume): Set it.
7073         (record_full_wait_1): Use record_full_resume_ptid instead of
7074         inferior_ptid.
7075
7076 2020-01-10  Pedro Alves  <palves@redhat.com>
7077
7078         * gdbthread.h (scoped_restore_current_thread)
7079         <dont_restore, restore, m_dont_restore>: Declare.
7080         * thread.c (thread_alive): Add assertion.  Return bool.
7081         (switch_to_thread_if_alive): New.
7082         (prune_threads): Switch inferior/thread.
7083         (print_thread_info_1): Switch thread before calling target methods.
7084         (scoped_restore_current_thread::restore): New, factored out from
7085         ...
7086         (scoped_restore_current_thread::~scoped_restore_current_thread):
7087         ... this.
7088         (scoped_restore_current_thread::scoped_restore_current_thread):
7089         Add assertion.
7090         (thread_apply_all_command, thread_select): Use
7091         switch_to_thread_if_alive.
7092
7093 2020-01-10  George Barrett  <bob@bob131.so>
7094
7095         * stap-probe.c (stap_modify_semaphore): Don't check for null
7096         semaphores.
7097         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
7098         for null semaphores.
7099
7100 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
7103         all source windows, and maintain horizontal scroll status while
7104         doing so.
7105
7106 2020-01-09  Tom Tromey  <tom@tromey.com>
7107
7108         PR tui/18932:
7109         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
7110         update_source_window, not print_source_lines.
7111
7112 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7113
7114         * tui/tui.c (tui_enable): Register tui hooks after calling
7115         tui_display_main.
7116
7117 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
7118
7119         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
7120
7121 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
7122
7123         * thread.c (print_thread_info_1): Fix indentation.
7124
7125 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
7126
7127         * symtab.c (general_symbol_info::compute_and_set_names): Move the
7128         unique_xmalloc_ptr outside the if to always free the demangled name.
7129
7130 2020-01-08  Tom Tromey  <tromey@adacore.com>
7131
7132         * xcoffread.c (enter_line_range, read_xcoff_symtab)
7133         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
7134         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
7135         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
7136         Remove.
7137         (section_offsets): New typedef.
7138         * symtab.c (fixup_section, get_msymbol_address): Update.
7139         * symmisc.c (dump_msymbols): Update.
7140         * symfile.h (relative_addr_info_to_section_offsets)
7141         (symfile_map_offsets_to_segments): Update.
7142         * symfile.c (build_section_addr_info_from_objfile)
7143         (init_objfile_sect_indices): Update.
7144         (struct place_section_arg): Change type of "offsets".
7145         (place_section): Update.
7146         (relative_addr_info_to_section_offsets): Change type of
7147         "section_offsets".  Remove "num_sections" parameter.
7148         (default_symfile_offsets, syms_from_objfile_1)
7149         (set_objfile_default_section_offset): Update.
7150         (reread_symbols): No need to preserve section offsets by hand.
7151         (symfile_map_offsets_to_segments): Change type of "offsets".
7152         * stap-probe.c (relocate_address): Update.
7153         * stabsread.h (process_one_symbol): Update.
7154         * solib-target.c (struct lm_info_target) <offsets>: Change type.
7155         (solib_target_relocate_section_addresses): Update.
7156         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
7157         Update.
7158         * solib-frv.c (frv_relocate_main_executable): Update.
7159         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
7160         * solib-aix.c (solib_aix_get_section_offsets): Change return
7161         type.
7162         (solib_aix_solib_create_inferior_hook): Update.
7163         * remote.c (remote_target::get_offsets): Update.
7164         * psymtab.c (find_pc_sect_psymtab): Update.
7165         * psympriv.h (struct partial_symbol) <address, text_low,
7166         text_high>: Update.
7167         * objfiles.h (obj_section_offset): Update.
7168         (struct objfile) <section_offsets>: Change type.
7169         <num_sections>: Remove.
7170         (objfile_relocate): Update.
7171         * objfiles.c (entry_point_address_query): Update
7172         (relocate_one_symbol): Change type of "section_offsets".
7173         (objfile_relocate1, objfile_relocate1): Change type of
7174         "new_offsets".
7175         (objfile_rebase1): Update.
7176         * mipsread.c (mipscoff_symfile_read): Update.
7177         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
7178         parameter.
7179         * mdebugread.c (parse_symbol): Change type of "section_offsets".
7180         (parse_external, psymtab_to_symtab_1): Update.
7181         * machoread.c (macho_symfile_offsets): Update.
7182         * ia64-tdep.c (ia64_find_unwind_table): Update.
7183         * hppa-tdep.c (read_unwind_info): Update.
7184         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
7185         * dwarf2read.c (create_addrmap_from_index)
7186         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7187         (process_psymtab_comp_unit_reader, add_partial_symbol)
7188         (add_partial_subprogram, process_full_comp_unit)
7189         (read_file_scope, read_func_scope, read_lexical_block_scope)
7190         (read_call_site_scope, dwarf2_rnglists_process)
7191         (dwarf2_ranges_process, dwarf2_ranges_read)
7192         (dwarf_decode_lines_1, var_decode_location, new_symbol)
7193         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
7194         Update.
7195         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
7196         Update.
7197         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
7198         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
7199         (process_one_symbol): Change type of "section_offsets".
7200         * ctfread.c (get_objfile_text_range): Update.
7201         * coffread.c (coff_symtab_read, enter_linenos)
7202         (process_coff_symbol): Update.
7203         * coff-pe-read.c (add_pe_forwarded_sym): Update.
7204         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
7205
7206 2020-01-08  Tom Tromey  <tromey@adacore.com>
7207
7208         * dwarf2read.c (parse_macro_definition): Use std::string.
7209         (parse_macro_definition): Likewise.
7210
7211 2020-01-08  Tom Tromey  <tromey@adacore.com>
7212
7213         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
7214         (ATTR_ALLOC_CHUNK): Remove.
7215
7216 2020-01-08  Tom Tromey  <tromey@adacore.com>
7217
7218         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
7219
7220 2020-01-08  Tom Tromey  <tromey@adacore.com>
7221
7222         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
7223         (dwarf2_compute_name, open_dwo_file): Likewise.
7224         (process_enumeration_scope): Use std::vector.
7225         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
7226         (partial_die_info::fixup, dwarf2_start_subfile)
7227         (guess_full_die_structure_name, dwarf2_name): Likewise.
7228         (determine_prefix): Update.
7229         (guess_full_die_structure_name): Make return type const.
7230         (partial_die_full_name): Return unique_xmalloc_ptr.
7231         (DW_FIELD_ALLOC_CHUNK): Remove.
7232
7233 2020-01-07  Tom Tromey  <tromey@adacore.com>
7234
7235         PR build/24937:
7236         * stap-probe.c (class stap_static_probe_ops): Add constructor.
7237
7238 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
7239
7240         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
7241
7242 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7243
7244         * stack.c (print_frame_info): Move disassemble_next_line code
7245         inside source_print block.
7246
7247 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7248
7249         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
7250         gdb/signals.h, as we are now using native signal symbols.
7251
7252 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
7253
7254         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
7255         overflow by an early check of content vs threshold.
7256         * tui/tui-source.c (tui_source_window::line_is_displayed):
7257         Likewise.
7258
7259 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7260
7261         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
7262
7263 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
7264
7265         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
7266         export table if no section contains it's RVA.
7267
7268 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7269
7270         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
7271
7272 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
7273
7274         * source.c (print_source_lines_base): Set last_line_listed.
7275
7276 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
7277
7278         * tui/tui-disasm.c: Remove trailing spaces.
7279
7280 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7281             Pedro Alves  <palves@redhat.com>
7282
7283         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
7284         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
7285         (windows_gdb_signal_to_target): New function, uses the above
7286         enumeration to convert GDB internal signal codes to equivalent
7287         Windows codes.
7288         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
7289         * windows-nat.c: Include "gdb_wait.h".
7290         (get_windows_debug_event): Extract the fatal exception from the
7291         exit status and convert to the equivalent Posix signal number.
7292         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
7293         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
7294         * gdbsupport/gdb_wait.c: New file, implements
7295         windows_status_to_termsig.
7296         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
7297         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
7298
7299 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7300
7301         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
7302         show_layout.
7303
7304 2020-01-05  Luis Machado  <luis.machado@linaro.org>
7305
7306         * aarch64-linux-nat.c
7307         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
7308         and bfd_mach_aarch64.
7309
7310 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7311
7312         * ui-file.c (stdio_file::can_emit_style_escape)
7313         (tee_file::can_emit_style_escape): Ensure style is used also on
7314         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
7315         to gdb_stdout.
7316         * main.c (set_gdb_data_directory): Use file style to output the
7317         warning that the given pathname is not a directory.
7318         * top.c (show_history_filename, gdb_safe_append_history)
7319         (show_gdb_datadir): Use file style.
7320
7321 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
7322
7323         * solib-target.c (struct lm_info_target):
7324         Change offsets to be a unique_xmalloc_ptr.
7325         (solib_target_relocate_section_addresses): Update.
7326
7327 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
7328
7329         * windows-nat.c (windows_clear_solib): Free so_list linked list.
7330
7331 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7332
7333         * MAINTAINERS (Write After Approval): Add myself.
7334
7335 2020-01-02  Luis Machado  <luis.machado@linaro.org>
7336
7337         * proc-service.c (get_ps_regcache): Remove reference to obsolete
7338         Cell BE architecture.
7339         * target.h (struct target_ops) <thread_architecture>: Likewise.
7340
7341 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
7342
7343         * Makefile.in: Use INSTALL_PROGRAM_ENV.
7344
7345 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
7346
7347         * MAINTAINERS (Write After Approval): Add myself.
7348
7349 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7350
7351         * gdbarch.sh: Update copyright year range of generated files.
7352
7353 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7354
7355         Update copyright year range in all GDB files.
7356
7357 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7358
7359         * copyright.py: Convert to Python 3.
7360
7361 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7362
7363         * copyright.py: Adapt after move of gnulib directory from gdb
7364         directory to toplevel directory.
7365
7366 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7367
7368         * copyright.py (main): Exit if run from the wrong directory.
7369
7370 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7371
7372         * top.c (print_gdb_version): Change copyright year to 2020.
7373
7374 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7375
7376         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
7377
7378 For older changes see ChangeLog-2019.
7379 \f
7380 Local Variables:
7381 mode: change-log
7382 left-margin: 8
7383 fill-column: 74
7384 version-control: never
7385 coding: utf-8
7386 End: