gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (struct tui_source_window_base): New struct.
   4         (struct tui_source_window): Derive from tui_source_window_base.
   5         (struct tui_disasm_window): New struct.
   6         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
   7         from tui_source_window::clear_detail.
   8         (tui_source_window_base): Rename from tui_source_window.
   9         (~tui_source_window_base): Rename from ~tui_source_window.
  10         (tui_alloc_win_info): Create a tui_disasm_window.
  11
  12 2019-06-25  Tom Tromey  <tom@tromey.com>
  13
  14         * tui/tui-data.h (struct tui_source_window)
  15         (struct tui_data_window): Declare destructors.
  16         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
  17         destructors.
  18         (tui_win_info): Simplify.
  19
  20 2019-06-25  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-winsource.c (tui_display_main)
  23         (tui_update_source_windows_with_addr)
  24         (tui_update_all_breakpoint_info): Update.
  25         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  26         (new_height_ok, parse_scrolling_args): Update.
  27         * tui/tui-stack.c (tui_show_frame_info): Update.
  28         * tui/tui-data.h (struct tui_list): Remove.
  29         (tui_source_windows): Return a reference to a std::vector.
  30         * tui/tui-data.c (source_windows): Now a std::vector.
  31         (tui_source_windows): Change return type.
  32         (tui_clear_source_windows): Rewrite.
  33         (tui_clear_source_windows_detail, tui_add_to_source_windows)
  34         (tui_free_all_source_wins_content): Rewrite.
  35
  36 2019-06-25  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
  39         (struct tui_data_window, struct tui_cmd_window): Declare
  40         clear_detail method.
  41         * tui/tui-data.c (tui_source_window::clear_detail)
  42         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
  43         methods.
  44         (tui_clear_win_detail): Simplify.
  45
  46 2019-06-25  Tom Tromey  <tom@tromey.com>
  47
  48         * tui/tui-layout.c (make_source_window, make_disasm_window)
  49         (make_source_or_disasm_window): Remove win_info_ptr parameter.
  50         Return the new window.
  51         (show_source_disasm_command, show_data)
  52         (show_source_or_disasm_and_command): Update.
  53
  54 2019-06-25  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
  57         parameter.  Return the new window.
  58         (show_source_disasm_command): Update and remove NULL check.
  59         (show_source_or_disasm_and_command): Update.
  60
  61 2019-06-25  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
  64
  65 2019-06-25  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-data.h (struct tui_win_info): Make constructor
  68         protected.  Make destructor virtual.  Add initializers.
  69         (tui_source_window, tui_data_window, tui_cmd_window): New
  70         classes.
  71         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
  72         constructor.  Add "type" parameter.
  73         (tui_source_window, tui_data_window, tui_cmd_window): New
  74         constructors.
  75         (tui_alloc_win_info): Instantiate the appropriate subclass.
  76
  77 2019-06-25  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-win.c (tui_resize_all): Use delete.
  80         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
  81         destructor.
  82         (tui_free_window): Don't declare.
  83         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
  84         Update.
  85
  86 2019-06-25  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-data.h (struct tui_win_info): Add constructor.
  89         * tui/tui-data.c (tui_alloc_win_info): Use new.
  90         (tui_free_window): Use delete.
  91
  92 2019-06-22  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
  95         declare.
  96         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
  97
  98 2019-06-22  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 101         declare.
 102         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 103
 104 2019-06-22  Tom de Vries  <tdevries@suse.de>
 105
 106         * dwarf2read.c (create_addrmap_from_aranges)
 107         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 108         instead of '%zu'.
 109
 110 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 111
 112         * dwarf2read.h (dwarf2_section_info_def): Remove.
 113         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 114         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 115         std::vector<dwarf2_section_info>.
 116         (struct dwo_file) <~dwo_file>: Remove.
 117         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 118         types field.
 119         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 120         (dwarf2_read_debug_names): Likewise.
 121         (create_debug_types_hash_table): Change parameter type to
 122         array_view, adjust code accordingly.
 123         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 124         (partial_die_info::fixup): Likewise.
 125         (determine_prefix): Likewise.
 126         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 127
 128 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 129
 130         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 131         gdb_bfd_ref_ptr.
 132         <~dwo_file>: Remove call to gdb_bfd_unref.
 133         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 134         gdb_bfd_ref_ptr::get.
 135
 136 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 137
 138         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 139         type to htab_up.
 140         * dwarf2read.c (struct dwo_file): Initialize fields.
 141         <~dwo_file>: New.
 142         (free_dwo_file): Remove, move content to ~dwo_file.
 143         (struct dwo_file_deleter): Remove.
 144         (dwo_file_up>: Remove custom deleter.
 145         (free_dwo_files): Remove.
 146         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 147         dwo_files.
 148         (process_skeletonless_type_units): Call unique_ptr::get.
 149         (allocate_dwo_file_hash_table): Add deleter to created hash
 150         table.  Change return type to htab_up.
 151         (lookup_dwo_file_slot): Don't memset dwo_file, call
 152         unique_ptr::get.
 153         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 154         (create_dwo_unit_in_dwp_v2): Likewise.
 155         (open_and_init_dwo_file): Likewise.
 156         (free_dwo_file_from_slot): Remove.
 157
 158 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 159
 160         * dwarf2read.h (struct dwarf2_section_info) <readin,
 161         is_virtual>: Change type to bool.
 162         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 163         true instead of 1.
 164
 165 2019-06-19  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-data.h (tui_init_content_element): Don't declare.
 168
 169 2019-06-19  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-data.h (tui_init_win_info): Don't declare.
 172
 173 2019-06-19  Tom de Vries  <tdevries@suse.de>
 174
 175         * dwarf2read.h (abstract_to_concrete): Change type to
 176         std::unordered_map<sect_offset, std::vector<sect_offset>,
 177         gdb::hash_enum<sect_offset>>.
 178
 179 2019-06-19  Tom Tromey  <tromey@adacore.com>
 180
 181         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 182         EVAL_AVOID_SIDE_EFFECTS specially.
 183
 184 2019-06-19  Tom Tromey  <tromey@adacore.com>
 185
 186         * source-cache.c (highlighter): New global.
 187         (source_cache::get_source_lines): Create a highlighter on demand.
 188
 189 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 190
 191         * defs.h (deprecated_interactive_hook): Delete declaration.
 192         * interps.c (clear_interpreter_hooks): Remove use of
 193         deprecated_interactive_hook.
 194         * top.c (deprecated_interactive_hook): Delete definition.
 195         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 196
 197 2019-06-18  Tom de Vries  <tdevries@suse.de>
 198
 199         PR gdb/24515
 200         * dwarf2read.h (abstract_to_concrete): Change type from
 201         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 202         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 203         * dwarf2read.c (read_variable): Update.
 204         (dwarf2_fetch_die_loc_sect_off): Update.
 205
 206 2019-06-17  Tom de Vries  <tdevries@suse.de>
 207
 208         PR gdb/24617
 209         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 210         accessing parent[parent_len - 1].
 211
 212 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 213
 214         PR gdb/24364
 215         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 216         call dtrace_process_dof with NULL dof.
 217
 218 2019-06-16  Tom de Vries  <tdevries@suse.de>
 219
 220         PR gdb/24445
 221         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 222
 223 2019-06-16  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 226         (make_all_visible): Use address of member.
 227
 228 2019-06-16  Tom Tromey  <tom@tromey.com>
 229
 230         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 231         (tui_free_window, free_content, free_content_elements): Remove
 232         unnecessary cast.
 233         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 234         cast.
 235         * tui/tui-regs.c (tui_show_register_group)
 236         (tui_display_registers_from, tui_display_reg_element_at_line):
 237         Remove unnecessary cast.
 238
 239 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 240
 241         * linux-nat.c (normal_mask): Delete.
 242         (_initialize_linux_nat): Don't initialise normal_mask.
 243
 244 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 245
 246         PR gdb/24445
 247         * dwarf-index-write.h (write_psymtabs_to_index): Add
 248         dwz_basename parameter.
 249         * dwarf-index-write.c (write_gdbindex): Move file writing to
 250         write_gdbindex_1.  Change return type void.
 251         (assert_file_size): Move up, remove filename parameter.
 252         (write_gdbindex_1): New function.
 253         (write_debug_names): Change return type to void, call
 254         assert_file_size.
 255         (struct index_wip_file): New struct.
 256         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 257         file logic to index_wip_file.  Write index for dwz file if
 258         needed.
 259         (save_gdb_index_command): Pass basename of dwz file, if present.
 260         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 261         build-id of dwz file, if present.
 262         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 263         (dwarf2_get_dwz_file): Likewise.
 264         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 265         (dwarf2_get_dwz_file): Likewise.
 266
 267 2019-06-16  Tom Tromey  <tom@tromey.com>
 268
 269         * coffread.c (process_coff_symbol): Use xstrdup.
 270         * value.c (create_internalvar): Use xstrdup.
 271
 272 2019-06-16  Tom Tromey  <tom@tromey.com>
 273
 274         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 275         * breakpoint.c (stopin_command, stopat_command)
 276         (until_break_command, decode_location_default): Remove unnecessary
 277         cast.
 278         * utils.c (subset_compare): Remove unnecessary cast.
 279         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 280         cast.
 281         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 282         cast.
 283         * infcmd.c (path_command): Remove unnecessary cast.
 284         * coffread.c (decode_type): Remove unnecessary cast.
 285         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 286         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 287         * tui/tui-stack.c (tui_show_locator_content)
 288         (tui_show_frame_info): Remove unnecessary cast.
 289         * tui/tui-win.c (tui_scroll_forward_command)
 290         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 291         (parse_scrolling_args): Remove unnecessary cast.
 292         * tui/tui-data.c (init_win_info, tui_del_window)
 293         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 294         (free_content_elements): Remove unnecessary cast.
 295         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 296         unnecessary cast.
 297         * tui/tui-source.c (tui_set_source_content)
 298         (tui_vertical_source_scroll): Remove unnecessary cast.
 299         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 300         cast.
 301         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 302         * tui/tui-regs.c (tui_display_registers_from)
 303         (tui_display_register): Remove unnecessary cast.
 304         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 305         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 306         (make_visible): Remove unnecessary cast.
 307         * tui/tui-winsource.c (tui_erase_source_content)
 308         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 309         unnecessary cast.
 310         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 311         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 312         * stabsread.c (read_type, read_array_type, read_range_type):
 313         Remove unnecessary cast.
 314         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 315         (parse_symbol, parse_type, upgrade_type, parse_external)
 316         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 317         unnecessary cast.
 318         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 319
 320 2019-06-16  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-data.c (tui_alloc_generic_win_info)
 323         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 324         checks.
 325
 326 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 327             Andrew Burgess  <andrew.burgess@embecosm.com>
 328
 329         * f-typeprint.c (f_print_type): Don't return early for not
 330         associated or not allocated types.
 331         (f_type_print_varspec_suffix): Add print_rank parameter and print
 332         ranks of array types in case they dangling.
 333         (f_type_print_base): Add print_rank parameter.
 334
 335 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 336
 337         * NEWS: Mention new MI commands.
 338         * break-catch-throw.c (enum exception_event_kind): Move to
 339         breakpoint.h.
 340         (print_mention_exception_catchpoint): Output text as a single
 341         message.
 342         (catch_exception_command_1): Rename to...
 343         (catch_exception_event): ...this, make non-static, update header
 344         command, and change some parameter types.
 345         (catch_catch_command): Update for changes to
 346         catch_exception_command_1.
 347         (catch_throw_command): Likewise.
 348         (catch_rethrow_command): Likewise.
 349         * breakpoint.c (enum exception_event_kind): Delete.
 350         * breakpoint.h (enum exception_event_kind): Moved here from
 351         break-catch-throw.c.
 352         (catch_exception_event): Declare.
 353         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 354         (mi_cmd_catch_throw): New function.
 355         (mi_cmd_catch_rethrow): New function.
 356         (mi_cmd_catch_catch): New function.
 357         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 358         'catch-catch' entries.
 359         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 360         (mi_cmd_catch_rethrow): Declare.
 361         (mi_cmd_catch_catch): Declare.
 362
 363 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 364
 365         * annotate.c (annotate_source_line): Change return type to void,
 366         update implementation to match.
 367         * annotate.h (annotate_source_line): Change return type to void,
 368         update header comment.
 369         * stack.c (print_frame_info): Don't change what frame information
 370         is printed based on whether annotations are on or not.
 371
 372 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 373
 374         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 375         (annotate_source): Make static.
 376         (annotate_source_line): Moved from source.c and renamed from
 377         identify_source_line.  Update the return type.
 378         * annotate.h (annotate_source): Delete declaration.
 379         (annotate_source_line): Declaration moved from source.h, and
 380         renamed from identify_source_line.  Return type updated.
 381         * source.c (identify_source_line): Moved to annotate.c and renamed
 382         to annotate_source_line.
 383         (info_line_command): Remove check of annotation_level.
 384         * source.h (identify_source_line): Move declaration to annotate.h
 385         and rename to annotate_source_line.
 386         * stack.c: Add 'annotate.h' include.
 387         (print_frame_info): Remove check of annotation_level before
 388         calling annotate_source_line.
 389
 390 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 391
 392         * source-cache.c (source_cache::get_plain_source_lines): Use
 393         open_source_file_with_line_charpos instead of just
 394         open_source_file, remove call to find_source_lines.
 395         (source_cache::get_source_lines): Likewise.
 396         * source.c (find_source_lines): Make static.
 397         (get_filename_and_charpos): Renamed into...
 398         (open_source_file_with_line_charpos): ..this along with changes to
 399         return a scoped_fd, and some other minor clean ups.
 400         (identify_source_line): Use open_source_file_with_line_charpos.
 401         (search_command_helper): Use open_source_file_with_line_charpos
 402         instead of just open_source_file, remove call to
 403         find_source_lines.
 404         * source.h (open_source_file_with_line_charpos): Declare new
 405         function.
 406         (find_source_lines): Delete declaration.
 407
 408 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 409
 410         * source.c (get_filename_and_charpos): Remove fullname
 411         parameter.
 412         (identify_source_line): Update call to get_filename_and_charpos.
 413
 414 2019-06-14  Tom Tromey  <tromey@adacore.com>
 415
 416         PR gdb/24502:
 417         * ui-style.h (skip_ansi_escape): Update comment.
 418         * ui-file.h (class no_terminal_escape_file): New class.
 419         * ui-file.c (no_terminal_escape_file::write)
 420         (no_terminal_escape_file::puts): New methods.
 421         * cli/cli-logging.c (handle_redirections): Use
 422         no_terminal_escape_file.
 423
 424 2019-06-14  Tom Tromey  <tromey@adacore.com>
 425
 426         * NEWS: Move convenience variable news above Python news.
 427
 428 2019-06-14  Tom Tromey  <tom@tromey.com>
 429
 430         * gnulib: Move directory to top-level.
 431         * configure.ac: Don't configure gnulib.
 432         * configure: Rebuild.
 433         * common/common-defs.h: Use new path to gnulib.
 434         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 435         (GNULIB_H): Remove.
 436         (INCGNU): Look in new gnulib location.
 437         (HFILES_NO_SRCDIR): Remove gnulib files.
 438         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 439         (generated_files): Remove GNULIB_H.
 440         ($(LIBGNU), all-lib): Remove targets.
 441         (distclean): Don't mention GNULIB_BUILDDIR.
 442         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 443
 444 2019-06-14  Tom Tromey  <tromey@adacore.com>
 445
 446         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 447         Warn if symbol file does not provide any symbols.
 448
 449 2019-06-14  Tom Tromey  <tromey@adacore.com>
 450
 451         * source.c (find_and_open_source): Respect basenames_may_differ.
 452
 453 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 454
 455         * annotate.c (annotate_breakpoints_invalid): Make use of
 456         scoped_restore_terminal_state.
 457         (annotate_frames_invalid): Likewise.
 458
 459 2019-06-14  Tom Tromey  <tromey@adacore.com>
 460
 461         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 462         allow assignment to an internalvar.
 463
 464 2019-06-14  Tom Tromey  <tromey@adacore.com>
 465
 466         * ada-lex.l: Allow "_" in attribute names.
 467
 468 2019-06-14  Tom Tromey  <tromey@adacore.com>
 469
 470         PR gdb/24653:
 471         * regcache.c (registers_changed): Don't call alloca.
 472         * top.c (execute_command): Don't call alloca.
 473
 474 2019-06-13  Pedro Alves  <palves@redhat.com>
 475
 476         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 477         'expression'.  When parsing an expression, error out if there's
 478         junk after "unlimited".
 479         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 480         (do_set_command): Adjust calls to is_unlimited_literal.
 481
 482 2019-06-13  Pedro Alves  <palves@redhat.com>
 483
 484         * compile/compile.c (make_compile_options_def_group): Add braces
 485         around array_view initializer.
 486         * thread.c (make_thread_apply_all_options_def_group)
 487         (make_thread_apply_all_options_def_group): Likewise.
 488
 489 2019-06-13  Pedro Alves  <palves@redhat.com>
 490
 491         * NEWS (New commands): Mention "maint test-options
 492         require-delimiter", "maint test-options unknown-is-error", "maint
 493         test-options unknown-is-operand" and "maint show
 494         test-options-completion-result".
 495         (New command options, command completion): New section.
 496         (Completion improvements): New section.
 497         Mention that you can abbreviate "unlimited".
 498
 499 2019-06-13  Pedro Alves  <palves@redhat.com>
 500
 501         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 502         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 503         * unittests/cli-utils-selftests.c (test_parse_flags)
 504         (test_parse_flags_qcs): Delete.
 505         (test_cli_utils): Don't call deleted functions.
 506
 507 2019-06-13  Pedro Alves  <palves@redhat.com>
 508
 509         * thread.c: Include "cli/cli-option.h".
 510         (tp_array_compar_ascending): Global.
 511         (tp_array_compar): Delete function.
 512         (tp_array_compar_ascending, tp_array_compar_descending): New
 513         functions.
 514         (ascending_option_def, qcs_flag_option_def)
 515         (thr_qcs_flags_option_defs)
 516         (make_thread_apply_all_options_def_group)
 517         (make_thread_apply_options_def_group): New.
 518         (thread_apply_all_command): Use gdb::option::process_options.
 519         (thread_apply_command_completer)
 520         (thread_apply_all_command_completer): New.
 521         (thread_apply_command): Use gdb::option::process_options.
 522         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 523         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 524         to generate help text of "thread apply".  Adjust "taas"'s help.
 525         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 526         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 527
 528 2019-06-13  Pedro Alves  <palves@redhat.com>
 529
 530         * thread.c (thread_apply_command): Check for invalid TID with
 531         isdigit instead of !isalpha.
 532
 533 2019-06-13  Pedro Alves  <palves@redhat.com>
 534
 535         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 536         (validate_flags_qcs): New.
 537         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 538         (validate_flags_qcs): Declare.
 539         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 540         (make_frame_apply_options_def_group): New.
 541         (frame_apply_command_count): Process options with
 542         gdb::option::process_options.
 543         (frame_apply_completer): New.
 544         (frame_apply_level_completer, frame_apply_all_completer)
 545         (frame_apply_completer): New.
 546         (_initialize_stack): Update help of "frame apply", "frame apply
 547         level", "frame apply all" and "faas" to mention supported options
 548         and install command completers.
 549         * stack.h (frame_apply_all_completer): Declare.
 550         * thread.c: Include "stack.h".
 551         (tfaas_command): Add "--".
 552         (_initialize_thread): Update help "tfaas" to mention supported
 553         options and install command completer.
 554
 555 2019-06-13  Pedro Alves  <palves@redhat.com>
 556
 557         * completer.c (complete_nested_command_line): New.
 558         (gdb_completion_word_break_characters_throw): Add assertion.
 559         * completer.h (complete_nested_command_line): Declare.
 560
 561 2019-06-13  Pedro Alves  <palves@redhat.com>
 562
 563         * stack.c (parse_backtrace_qualifiers): New.
 564         (backtrace_command): Use it.
 565         (backtrace_command_completer): Complete on qualifiers.
 566
 567 2019-06-13  Pedro Alves  <palves@redhat.com>
 568
 569         * frame.c: Include "cli/cli-option.h.
 570         (user_set_backtrace_options): New.
 571         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 572         Delete.
 573         (get_prev_frame): Adjust.
 574         (boolean_option_def, uinteger_option_def)
 575         (set_backtrace_option_defs): New.
 576         (_initialize_frame): Adjust and use
 577         gdb::option::add_setshow_cmds_for_options to install "set
 578         backtrace past-main" and "set backtrace past-entry".
 579         * frame.h: Include "cli/cli-option.h".
 580         (struct frame_print_options): Forward declare.
 581         (print_frame_arguments_all, print_frame_arguments_scalars)
 582         (print_frame_arguments_none): Declare.
 583         (print_entry_values): Delete declaration.
 584         (struct frame_print_options, user_frame_print_options): New.
 585         (struct set_backtrace_options): New.
 586         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 587         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 588         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 589         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 590         (list_args_or_locals): Add frame_print_options parameter.
 591         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 592         * python/py-framefilter.c (enumerate_args): Pass down
 593         USER_FRAME_PRINT_OPTIONS.
 594         * stack.c: Include "cli/cli-option.h".
 595         (print_frame_arguments_all, print_frame_arguments_scalars)
 596         (print_frame_arguments_none): Declare.
 597         (print_raw_frame_arguments, print_entry_values): Delete.
 598         (user_frame_print_options): New.
 599         (boolean_option_def, enum_option_def, frame_print_option_defs):
 600         New.
 601         (struct backtrace_cmd_options): New.
 602         (bt_flag_option_def): New.
 603         (backtrace_command_option_defs): New.
 604         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 605         (print_frame_arg, read_frame_arg, print_frame_args)
 606         (print_frame_info, print_frame): Add frame_print_options parameter
 607         and use it.
 608         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 609         (backtrace_command_1): Add frame_print_options and
 610         backtrace_cmd_options parameters and use them.
 611         (make_backtrace_options_def_group): New.
 612         (backtrace_command): Process command options with
 613         gdb::option::process_options.
 614         (backtrace_command_completer): New.
 615         (_initialize_stack): Extend "backtrace"'s help to mention
 616         supported options.  Install completer for "backtrace".
 617         Install some settings commands with add_setshow_cmds_for_options.
 618
 619 2019-06-13  Pedro Alves  <palves@redhat.com>
 620
 621         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 622         and that "set/show print raw frame-arguments" are now deprecated.
 623
 624         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 625         command.
 626         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 627         * stack.c (_initialize_stack): Install "set/show print
 628         raw-frame-arguments", and deprecate "set/show print raw
 629         frame-arguments".
 630         * valprint.c (_initialize_valprint): Deprecate "set/show print
 631         raw".
 632
 633 2019-06-13  Pedro Alves  <palves@redhat.com>
 634
 635         * compile/compile.c (struct compile_options): New.
 636         (compile_flag_option_def, compile_command_option_defs)
 637         (make_compile_options_def_group): New.
 638         (compile_file_command): Handle options with
 639         gdb::option::process_options.
 640         (compile_file_command_completer): New function.
 641         (compile_code_command): Handle options with
 642         gdb::option::process_options.
 643         (compile_code_command_completer): New function.
 644         (_initialize_compiler): Install completers for "compile code" and
 645         "compile file".  Mention available options in "compile code" and
 646         "compile code"'s help.
 647         * completer.c (advance_to_completion_word): New, factored out from
 648         ...
 649         (advance_to_expression_complete_word_point): ... this.
 650         (advance_to_filename_complete_word_point): New.
 651         * completer.h (advance_to_filename_complete_word_point): New
 652         declaration.
 653
 654 2019-06-13  Pedro Alves  <palves@redhat.com>
 655
 656         * compile/compile.c: Include "cli/cli-option.h".
 657         (compile_print_value): Scope data pointer is now a
 658         value_print_options pointer; adjust.
 659         (compile_print_command): Process options.  Scope data pointer is
 660         now a value_print_options pointer; adjust.
 661         (_initialize_compile): Update "compile print"'s help to include
 662         supported options.  Install a completer for "compile print".
 663         * cp-valprint.c (show_vtblprint, show_objectprint)
 664         (show_static_field_print): Delete.
 665         (_initialize_cp_valprint): Don't install "set print
 666         static-members", "set print vtbl", "set print object" here.
 667         * printcmd.c: Include "cli/cli-option.h" and
 668         "common/gdb_optional.h".
 669         (print_command_parse_format): Rework to fill in a
 670         value_print_options instead of a format_data.
 671         (print_value): Change parameter type from format_data pointer to
 672         value_print_options reference.  Adjust.
 673         (print_command_1): Process options.  Adjust to pass down a
 674         value_print_options.
 675         (print_command_completer): New.
 676         (_initialize_printcmd): Install print_command_completer as
 677         handle_brkchars completer for the "print" command.  Update
 678         "print"'s help to include supported options.
 679         * valprint.c: Include "cli/cli-option.h".
 680         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 681         here from cp-valprint.c.
 682         (boolean_option_def, uinteger_option_def)
 683         (value_print_option_defs, make_value_print_options_def_group):
 684         New.  Use gdb::option::add_setshow_cmds_for_options to install
 685         "set print elements", "set print null-stop", "set print repeats",
 686         "set print pretty", "set print union", "set print array", "set
 687         print address", "set print symbol", "set print array-indexes".
 688         * valprint.h: Include <string> and "cli/cli-option.h".
 689         (make_value_print_options_def_group): Declare.
 690         (print_value): Change parameter type from format_data pointer to
 691         value_print_options reference.
 692         (print_command_completer): Declare.
 693
 694 2019-06-13  Pedro Alves  <palves@redhat.com>
 695
 696         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 697         (COMMON_SFILES): Add maint-test-settings.c.
 698         * cli/cli-decode.c (boolean_enums): New global, factored out from
 699         ...
 700         (add_setshow_boolean_cmd): ... here.
 701         * cli/cli-decode.h (boolean_enums): Declare.
 702         * cli/cli-option.c: New file.
 703         * cli/cli-option.h: New file.
 704         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 705         factored out from ...
 706         (parse_cli_boolean_value(const char *)): ... this.
 707         (is_unlimited_literal): Change parameter type to pointer to
 708         pointer.  Adjust and advance ARG pointer.
 709         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 710         (parse_cli_var_enum): New, factored out from ...
 711         (do_set_command): ... this.  Adjust.
 712         * cli/cli-setshow.h (parse_cli_boolean_value)
 713         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 714         (parse_cli_var_enum): Declare.
 715         * cli/cli-utils.c: Include "cli/cli-option.h".
 716         (get_ulongest): New.
 717         * cli/cli-utils.h (get_ulongest): Declare.
 718         (check_for_argument): New overloads.
 719         * maint-test-options.c: New file.
 720
 721 2019-06-13  Pedro Alves  <palves@redhat.com>
 722
 723         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 724         parse a range if "-" is at the end of the string.
 725
 726 2019-06-13  Pedro Alves  <palves@redhat.com>
 727
 728         * cli/cli-setshow.c (parse_auto_binary_operation)
 729         (parse_cli_boolean_value): Don't allow "o".
 730
 731 2019-06-13  Pedro Alves  <palves@redhat.com>
 732
 733         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 734         * NEWS: Mention maint test-settings KIND.
 735         * maint-test-settings.c: New file.
 736
 737 2019-06-13  Pedro Alves  <palves@redhat.com>
 738
 739         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 740         completer.
 741         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 742         "set" completers.
 743
 744 2019-06-13  Pedro Alves  <palves@redhat.com>
 745
 746         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 747         after item.
 748
 749 2019-06-13  Pedro Alves  <palves@redhat.com>
 750
 751         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 752
 753 2019-06-13  Pedro Alves <palves@redhat.com>
 754
 755         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 756         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 757         call.
 758         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 759         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 760         calls.
 761         (check_for_argument): Skip spaces after argument.
 762
 763 2019-06-13  Pedro Alves  <palves@redhat.com>
 764
 765         * thread.c (thread_apply_command): Adjust TID parsing.
 766         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 767         detected before end of string.
 768         (tid_is_in_list): Error out if LIST is invalid.
 769
 770 2019-06-13  Pedro Alves  <palves@redhat.com>
 771
 772         * completer.c (complete_line_internal_1): Rewind completion word
 773         point.
 774         (completion_tracker::advance_custom_word_point_by): Change
 775         parameter type to int.
 776         * completer.h (completion_tracker::advance_custom_word_point_by):
 777         Likewise.
 778
 779 2019-06-13  Pedro Alves  <palves@redhat.com>
 780
 781         * completer.c (advance_to_completion_word): Handle delimiters.
 782
 783 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 784
 785         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 786
 787 2019-06-11  Tom Tromey  <tom@tromey.com>
 788
 789         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 790         (xmalloc_failed): Move to alloc.c.
 791         * alloc.c: New file.
 792         * Makefile.in (COMMON_SFILES): Add alloc.c.
 793
 794 2019-06-11  Tom Tromey  <tom@tromey.com>
 795
 796         * nat/linux-waitpid.c: Don't include server.h.
 797         (linux_debug): Remove.
 798         (my_waitpid): Update.
 799
 800 2019-06-11  Tom Tromey  <tromey@adacore.com>
 801
 802         * infcall.c (_initialize_infcall): Remove trailing newline from
 803         help.
 804         * user-regs.c (_initialize_user_regs): Remove trailing newline
 805         from help.
 806         * typeprint.c (_initialize_typeprint): Remove trailing newline
 807         from help.
 808         * reverse.c (_initialize_reverse): Remove trailing newlines from
 809         help.
 810         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 811         from help.
 812         * language.c (add_set_language_command): Remove trailing newline
 813         from help.
 814         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 815         help.
 816         * disasm.c (_initialize_disasm): Remove trailing newline from
 817         help.
 818         * top.c (init_main): Remove trailing newline from help.
 819         * interps.c (_initialize_interpreter): Remove trailing newline
 820         from help.
 821         * btrace.c (_initialize_btrace): Remove trailing newlines from
 822         help.
 823         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 824         from help.
 825         * python/python.c (_initialize_python): Remove trailing newline
 826         from help.
 827         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 828         help.
 829         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 830         from help.  Reformat some text.
 831         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 832         from help.
 833         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 834         newline from help.
 835
 836 2019-06-11  Tom Tromey  <tromey@adacore.com>
 837
 838         * darwin-nat.c (darwin_decode_exception_message)
 839         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 840
 841 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 842
 843         * valops.c (value_slice): Check for not allocated or not
 844         associated values.
 845
 846 2019-06-10  Tom de Vries  <tdevries@suse.de>
 847
 848         PR gdb/24618
 849         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 850         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 851         invalid.
 852
 853 2019-06-10  Tom de Vries  <tdevries@suse.de>
 854
 855         PR gdb/24611
 856         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 857         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 858
 859 2019-06-10  Tom de Vries  <tdevries@suse.de>
 860
 861         PR symtab/24545
 862         * symtab.c (struct demangled_name_entry): Add language field.
 863         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 864         static minimal symbol".  Set and use language field.
 865
 866 2019-06-10  Tom Tromey  <tromey@adacore.com>
 867
 868         * ada-lang.c (_initialize_ada_language): Update help text.
 869
 870 2019-06-10  Tom Tromey  <tromey@adacore.com>
 871
 872         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 873         with a newline.
 874         * guile/guile.c (handle_boot_error): Don't end warning with a
 875         newline.
 876         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 877         warning with a newline.
 878         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 879         newline.
 880         (s12z_frame_cache): Likewise.
 881         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 882         a newline.
 883         * solib-svr4.c (disable_probes_interface): Don't end warning with
 884         a newline.
 885         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 886         newline.
 887         * python/python.c (do_finish_initialization): Don't end warning
 888         with a newline.
 889
 890 2019-06-10  Tom Tromey  <tom@tromey.com>
 891
 892         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 893         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 894         gdbpy_enter.
 895
 896 2019-06-10  Tom Tromey  <tromey@adacore.com>
 897
 898         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 899         data.
 900         (elf_new_init): Don't call stabsread_new_init.
 901         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 902         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 903         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 904
 905 2019-06-10  Tom de Vries  <tdevries@suse.de>
 906
 907         PR symtab/16264
 908         PR symtab/24517
 909         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 910
 911 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 912
 913         * source.c (find_and_open_source): Also rewrite relative file
 914         names.
 915
 916 2019-04-26  Amos Bird  <amosbird@gmail.com>
 917
 918         * annotate.c (annotate_thread_exited): Add "thread-exited"
 919         annotation.
 920
 921 2019-06-06  Tom Tromey  <tromey@adacore.com>
 922
 923         * maint.h (class scoped_command_stats): Use
 924         DISABLE_COPY_AND_ASSIGN.
 925         <print_time>: New method.
 926         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 927         print_time.
 928         (scoped_command_stats::print_time): New method.
 929
 930 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 931
 932         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 933         instructions of lengths 6 or 8 bytes.
 934
 935 2019-06-04  Pedro Alves  <palves@redhat.com>
 936
 937         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 938
 939         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 940         * breakpoint.c (condition_completer): Likewise.
 941         * cli/cli-dump.c (scan_expression): Likewise.
 942         * common/filestuff.c (mkdir_recursive): Likewise.
 943         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 944         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 945         (gdb_abspath): Likewise.
 946         * compile/compile-cplus-types.c
 947         (compile_cplus_instance::decl_name): Likewise.
 948         * completer.c (complete_explicit_location):
 949         (signal_completer, reg_or_group_completer_1): Likewise.
 950         * cp-support.c (cp_remove_params_if_any): Likewise.
 951         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 952         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 953         * infcmd.c (strip_bg_char): Likewise.
 954         * linespec.c (copy_token_string): Likewise.
 955         * mi/mi-main.c (output_cores): Likewise.
 956         * psymtab.c (psymtab_search_name):
 957         * symfile.c (test_set_ext_lang_command): Likewise.
 958         * target.c (target_fileio_read_stralloc): Likewise.
 959         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 960         * value.c (complete_internalvar): Likewise.
 961
 962 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 963
 964         Add objfile property to gdb.Type.
 965         * NEWS: Mention Python API addition.
 966         * python/py-type.c (typy_get_objfile): New method.
 967
 968 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 969
 970         * NEWS: Mention the new set|show style [title|highlight].
 971         Mention changes to "show style", "help" and "apropos".
 972
 973 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 974
 975         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 976         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 977         instead of print_help_for_command.
 978         (print_doc_of_command): New function.
 979         (help_list): Add 'apropos -v word' suggestion.
 980         (print_help_for_command): Style the command name using title style.
 981         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 982         (_initialize_cli_cmds): Describe -v in apropos_command help.
 983
 984 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 985
 986         * cli/cli-style.h (cli_style_option): Add name in constructor,
 987         add m_name class member, add constructor with intensity,
 988         add name class function.
 989         (cli_style_option::add_setshow_commands): Remove name argument.
 990         (highlight_style, title_style): New styles.
 991         * cli/cli-style.c (do_show): New function that shows a style
 992         characteristic styling the style name with itself.
 993         (set_style_name): New function.
 994         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 995         Update all callers according to the changes in cli/cli-style.h.
 996         * utils.h (fputs_highlighted): New function.
 997         * utils.c (fputs_highlighted): Likewise.
 998
 999 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1000
1001         * NEWS: Mention new pipe command and new convenience variables.
1002
1003 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1004
1005         * cli/cli-cmds.c (pipe_command): New function.
1006         (_initialize_cli_cmds): Call add_com for pipe_command.
1007         Define | as an alias for pipe.
1008         (exit_status_set_internal_vars): New function.
1009         (shell_escape): Call exit_status_set_internal_vars.
1010         cli/cli-decode.c (find_command_name_length): Recognize | as
1011         a single character command.
1012
1013 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1014
1015         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1016         top.c (execute_command_to_ui_file): New function, mostly a copy
1017         of execute_command_to_string.
1018         (execute_command_to_string): Implement by calling
1019         execute_command_to_ui_file.
1020
1021 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1022
1023         * top.h (saved_command_line): Remove declaration.
1024         * top.c (previous_saved_command_line, previous_repeat_arguments):
1025         New variables.
1026         (saved_command_line): Make static, define together with other
1027         'repeat variables'.
1028         (dont_repeat): Clear repeat_arguments.
1029         (repeat_previous, get_saved_command_line, save_command_line):
1030         New functions.
1031         (gdb_init): Initialize saved_command_line
1032         and previous_saved_command_line.
1033         * main.c (captured_main_1): Remove saved_command_line initialization.
1034         * event-top.c (handle_line_of_input): Update to use
1035         the new 'repeat' related functions instead of direct access to
1036         saved_command_line.
1037         * command.h (repeat_previous, get_saved_command_line,
1038         save_command_line): New declarations.
1039         (dont_repeat): Add comment.
1040
1041 2019-05-30  Tom Tromey  <tromey@adacore.com>
1042
1043         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1044         Fix comment.
1045         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1046
1047 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1048
1049         PR cli/24587
1050         * completer.c (complete): Initialize variable word.
1051
1052 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1053
1054         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1055         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1056         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1057         'body' is NULL to the outter 'if', protecting the '!is_define'
1058         situation as well.
1059
1060 2019-05-29  Tom Tromey  <tromey@adacore.com>
1061
1062         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1063         (dwarf_unknown): New function.
1064         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1065         (dwarf_type_encoding_name): Use dwarf_unknown.
1066
1067 2019-05-29  Tom Tromey  <tromey@adacore.com>
1068
1069         PR c++/20020:
1070         * cp-valprint.c (cp_print_value_fields): Call
1071         cp_print_static_field inside "try".
1072
1073 2019-05-29  Tom Tromey  <tromey@adacore.com>
1074
1075         * inflow.c (struct terminal_info): Add default operator=.
1076         * configure: Rebuild.
1077         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1078         -Wdeprecated-copy-dtor, -Wredundant-move.
1079
1080 2019-05-29  Tom Tromey  <tromey@adacore.com>
1081
1082         * NEWS: Add entry.
1083         * infcmd.c (print_return_value_1): Handle finish_print
1084         option.
1085         (show_print_finish): New function.
1086         (_initialize_infcmd): Add "set/show print finish" commands.
1087         * valprint.c (user_print_options): Initialize new member.
1088         * valprint.h (struct value_print_options) <finish_print>: New
1089         member.
1090
1091 2019-05-28  Tom Tromey  <tromey@adacore.com>
1092
1093         * ada-lang.c (ada_remove_Xbn_suffix)
1094         (find_old_style_renaming_symbol)
1095         (parse_old_style_renaming): Remove.
1096         (ada_find_renaming_symbol): Don't call
1097         find_old_style_renaming_symbol.
1098         (ada_is_renaming_symbol): Rename from
1099         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1100         bool.  Now static.
1101         (ada_read_var_value): Update and simplify.
1102         * ada-exp.y (write_var_or_type): Remove old code.
1103
1104 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1105
1106         * event-top.c: Remove include comment.
1107         * inflow.c (class scoped_ignore_sigttou): Move from here...
1108         * inflow.h (class scoped_ignore_sigttou): ...to here.
1109         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1110         * top.c:  Remove include comment.
1111
1112 2019-05-27  Tom Tromey  <tom@tromey.com>
1113
1114         * NEWS: Fix typo.
1115
1116 2019-05-22  Tom Tromey  <tromey@adacore.com>
1117
1118         * target.c (target_follow_exec): Constify parameter.
1119         * target-delegates.c: Rebuild.
1120         * remote.c (remote_target::follow_exec): Constify parameter.
1121         * infrun.c (follow_exec): Constify parameter.
1122         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1123         (target_follow_exec): Likewise.
1124
1125 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1126
1127         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1128         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1129
1130 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1131
1132         * NEWS: Add debugredirect and testsuite sections.
1133
1134 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1135
1136         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1137         target descriptions using exclusively floating point register name
1138         aliases.
1139
1140 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1141
1142         PR gdb/18644:
1143         * f-lang.c (build_fortran_types): Handle the case where
1144         gdbarch_floatformat_for_type returns a nullptr.
1145
1146 2019-05-21  Tom de Vries  <tdevries@suse.de>
1147
1148         PR cli/24587
1149         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1150
1151 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1152
1153         PR gdb/18644:
1154         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1155         16-byte floats.
1156         * i386-tdep.c (i386_floatformat_for_type): Use
1157         floatformats_ia64_quad for the 16-byte floating point component
1158         within a fortran 32-byte complex number.
1159
1160 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1161
1162         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1163         delete default constructor.
1164         (find_partial_die): Update to return const struct.
1165         (partial_die_parent_scope): Move variable declaration into scope
1166         of its use and change its type to auto.
1167         (guess_partial_die_structure_name): Likewise.
1168         (partial_die_info::fixup): Likewise.
1169
1170 2019-05-17  Tom Tromey  <tromey@adacore.com>
1171
1172         * source.c (find_and_open_source): Remove cast.
1173
1174 2019-05-17  Tom Tromey  <tromey@adacore.com>
1175
1176         * annotate.c (annotate_source): Make "filename" const.
1177         * annotate.h (annotate_source): Use const.
1178
1179 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1180
1181         * disasm.c (set_disassembler_options): Send errors to stderr.
1182
1183 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1184
1185         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1186         (cli_interp_base::set_logging): Check debug_redirect.
1187         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1188         * cli/cli-logging.c (debug_redirect): Add static variable.
1189         (pop_output_files): Add default param.
1190         (handle_redirections): Print debug setting.
1191         (show_logging_command): Likewise.
1192         (_initialize_cli_logging): Add debugredirect command.
1193         * interps.c (current_interp_set_logging): Add debug_redirect
1194         parameter.
1195         * interps.h (set_logging): Add debug_redirect parameter.
1196         (current_interp_set_logging): Likewise.
1197         * mi/mi-common.h: Likewise.
1198         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1199
1200 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1201             Tom Tromey  <tromey@adacore.com>
1202
1203         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1204         directly.
1205         * cli/cli-interp.h (make_logging_output): Remove declaration.
1206         * cli/cli-logging.c (make_logging_output): Remove function.
1207         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1208         directly.
1209         * ui-file.c (tee_file::tee_file): Remove bools.
1210         (tee_file::~tee_file): Remove deletes.
1211         * ui-file.h (tee_file): Remove bools.
1212
1213 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1214
1215         * mi/mi-cmds.h (mi_cmd_complete): New function.
1216         * mi/mi-main.c (mi_cmd_complete): Likewise.
1217         * mi/mi-cmds.c: Define new MI command -complete.
1218         * NEWS: Mention new -complete command.
1219
1220 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1221
1222         * completer.h (complete): New function.
1223         * completer.c (complete): Likewise.
1224         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1225         function defined in completer.h.
1226
1227 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1228
1229         * MAINTAINERS (Write After Approval): Add myself.
1230
1231 2019-05-17  Tom de Vries  <tdevries@suse.de>
1232
1233         PR gdb/24094
1234         * dwarf2read.c (struct cu_partial_die_info): New struct.
1235         (find_partial_die): Return cu_partial_die_info.
1236         (partial_die_parent_scope, guess_partial_die_structure_name)
1237         (partial_die_info::fixup): Handle new return type of find_partial_die.
1238
1239 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1240
1241         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1242         "std::string", simplifying the algorithm.
1243
1244 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1245
1246         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1247         (stap_static_probe_ops::get_probes): Likewise.
1248
1249 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1250
1251         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1252         '-')" and "else if".
1253         (stap_parse_single_operand): Join checks for
1254         "gdbarch_stap_parse_special_token_p" and
1255         "gdbarch_stap_parse_special_token" in the same "if" statement.
1256         Invert check when verifying for operation on register
1257         displacement.
1258
1259 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1260
1261         * stap-probe.c (stap_get_opcode): Update comment.
1262         (stap_get_expected_argument_type): Likewise.
1263         (handle_stap_probe): Likewise.
1264
1265 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1266
1267         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1268         return type to 'bool'.  Adjust comment.  Use 'bool' when
1269         appropriate.
1270         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1271         * stap-probe.c (stap_parse_argument_1): Likewise.
1272         (stap_is_operator): Likewise.
1273         (stap_is_generic_prefix): Likewise.
1274         (stap_is_register_prefix): Likewise.
1275         (stap_is_register_indirection_prefix): Likewise.
1276         (stap_is_integer_prefix): Likewise.
1277         (stap_generic_check_suffix): Likewise.
1278         (stap_check_integer_suffix): Likewise.
1279         (stap_check_register_suffix): Likewise.
1280         (stap_check_register_indirection_suffix): Likewise.
1281         (stap_parse_register_operand): Likewise.
1282         (stap_parse_single_operand): Likewise.
1283         (stap_parse_argument_1): Likewise.
1284         (stap_probe::get_argument_count): Likewise.
1285         (stap_is_operator): Likewise.
1286
1287 2019-05-16  Tom Tromey  <tromey@adacore.com>
1288
1289         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1290         keyword to foreach.
1291
1292 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1293
1294         * linux-thread-db.c (try_thread_db_load_1): Change return type
1295         to bool.
1296         (try_thread_db_load): Likewise.
1297         (try_thread_db_load_from_pdir_1): Likewise.
1298         (try_thread_db_load_from_pdir): Likewise.
1299         (try_thread_db_load_from_sdir): Likewise.
1300         (try_thread_db_load_from_dir): Likewise.
1301         (thread_db_load_search): Likewise.
1302         (has_libpthread): Likewise.
1303         (thread_db_load): Likewise.
1304
1305 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1306
1307         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1308         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1309         NULL, and complain/return if that's the case.
1310
1311 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1312
1313         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1314         (advance, posn, abstract_read_memory): New functions.
1315         [struct mem_read_abstraction]: New struct.
1316         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1317
1318 2019-05-14  Tom Tromey  <tromey@adacore.com>
1319
1320         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1321         value is not lval_memory.
1322
1323 2019-05-14  Tom Tromey  <tromey@adacore.com>
1324
1325         * solib.c (info_sharedlibrary_command): Style the file name.
1326
1327 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1328
1329         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1330         (aarch64_vnv_type): Likewise.
1331         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1332         * common/tdesc.c: Likewise.
1333         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1334         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1335         * features/aarch64-fpu.xml: Add ieee half view.
1336         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1337         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1338         * gdbtypes.h (struct builtin_type): Likewise.
1339         (struct objfile_type): Likewise.
1340
1341 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1342
1343         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1344         typo.
1345         * location.h (string_to_event_location): Likewise.
1346
1347 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1348
1349         GDB 8.3 released.
1350
1351 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1352
1353         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1354         New variable declaration.
1355         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1356         New variable.
1357         (print_one_breakpoint): Use ui_out::test_flags and new global
1358         variable to compute use_fixed_output.
1359         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1360         Remove.
1361         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1362         (mi_multi_location_breakpoint_output_fixed): Remove.
1363         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1364         new variable.
1365         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1366         fix_multi_location_breakpoint_output flag if version >= 3.
1367         * ui-out.h (enum ui_out_flag)
1368         <fix_multi_location_breakpoint_output>: New enumerator.
1369
1370 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1371
1372         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1373
1374 2019-05-10  Tom Tromey  <tromey@adacore.com>
1375
1376         * ada-lang.c (catch_ada_completer): New function.
1377         (_initialize_ada_language): Use it.
1378
1379 2019-05-10  Tom Tromey  <tromey@adacore.com>
1380
1381         * thread.c (print_thread_info): Make "requested_threads" const.
1382         * gdbthread.h (print_thread_info): Make "requested_threads"
1383         const.
1384         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1385         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1386
1387 2019-05-08  Tom Tromey  <tom@tromey.com>
1388
1389         * gdbtypes.c (objfile_type_data): Change type.
1390         (objfile_type, _initialize_gdbtypes): Update.
1391
1392 2019-05-08  Tom Tromey  <tom@tromey.com>
1393
1394         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1395         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1396         (_initialize_dwarf2_frame): Update.
1397
1398 2019-05-08  Tom Tromey  <tom@tromey.com>
1399
1400         * objc-lang.c (objc_objfile_data): Change type.
1401         (find_methods): Update.
1402         (_initialize_objc_lang): Remove.
1403
1404 2019-05-08  Tom Tromey  <tom@tromey.com>
1405
1406         * stabsread.c (rs6000_builtin_type_data): Change type.
1407         (rs6000_builtin_type, _initialize_stabsread): Update.
1408
1409 2019-05-08  Tom Tromey  <tom@tromey.com>
1410
1411         * mips-tdep.c (mips_pdr_data): Remove.
1412         (_initialize_mips_tdep): Update.
1413
1414 2019-05-08  Tom Tromey  <tom@tromey.com>
1415
1416         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1417         (hppa_init_objfile_priv_data, read_unwind_info)
1418         (find_unwind_entry, _initialize_hppa_tdep): Update.
1419
1420 2019-05-08  Tom Tromey  <tom@tromey.com>
1421
1422         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1423         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1424         on obstack.
1425         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1426
1427 2019-05-08  Tom Tromey  <tom@tromey.com>
1428
1429         * mdebugread.c (basic_type_data): Change type.
1430         (basic_type, _initialize_mdebugread): Update.
1431
1432 2019-05-08  Tom Tromey  <tom@tromey.com>
1433
1434         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1435
1436 2019-05-08  Tom Tromey  <tom@tromey.com>
1437
1438         * nto-tdep.c (nto_inferior_data_reg): Change type.
1439         (nto_inferior_data): Update.
1440         (nto_inferior_data_cleanup, nto_new_inferior_data)
1441         (_initialize_nto_tdep): Remove.
1442         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1443
1444 2019-05-08  Tom Tromey  <tom@tromey.com>
1445
1446         * ada-lang.c (struct ada_inferior_data): Add initializers.
1447         (ada_inferior_data): Change type.
1448         (ada_inferior_data_cleanup): Remove.
1449         (get_ada_inferior_data, ada_inferior_exit)
1450         (struct ada_pspace_data): Add initializers, destructor.
1451         (ada_pspace_data_handle): Change type.
1452         (get_ada_pspace_data): Update.
1453         (ada_pspace_data_cleanup): Remove.
1454
1455 2019-05-08  Tom Tromey  <tom@tromey.com>
1456
1457         * coffread.c (struct coff_symfile_info): Add initializers.
1458         (coff_objfile_data_key): Move lower.  Change type.
1459         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1460         Update.
1461         (coff_free_info): Remove.
1462
1463 2019-05-08  Tom Tromey  <tom@tromey.com>
1464
1465         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1466         (fbsd_pspace_data_handle): Move lower.  Change type.
1467         (get_fbsd_pspace_data): Update.
1468         (fbsd_pspace_data_cleanup): Remove.
1469         (_initialize_fbsd_tdep): Update.
1470
1471 2019-05-08  Tom Tromey  <tom@tromey.com>
1472
1473         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1474         (get_ada_tasks_pspace_data): Update.
1475         (ada_tasks_pspace_data_cleanup): Remove.
1476         (_initialize_tasks): Update.
1477         (ada_tasks_inferior_data_handle): Change type.
1478         (get_ada_tasks_inferior_data): Update.
1479         (ada_tasks_inferior_data_cleanup): Remove.
1480         (struct ada_tasks_pspace_data): Add initializers.
1481
1482 2019-05-08  Tom Tromey  <tom@tromey.com>
1483
1484         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1485         * symfile-debug.c (debug_sym_get_probes): Change type.
1486         * stap-probe.c (handle_stap_probe):
1487         (stap_static_probe_ops::get_probes): Change type.
1488         * probe.h (class static_probe_ops) <get_probes>: Change type.
1489         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1490         (parse_probes_in_pspace): Update.
1491         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1492         Update.
1493         (any_static_probe_ops::get_probes): Change type.
1494         * elfread.c (elfread_data): New typedef.
1495         (probe_key): Change type.
1496         (elf_get_probes): Likewise.  Update.
1497         (probe_key_free): Remove.
1498         (_initialize_elfread): Update.
1499         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1500         Change type.
1501         (dtrace_process_dof_probe, dtrace_process_dof)
1502         (dtrace_static_probe_ops::get_probe): Change type.
1503
1504 2019-05-08  Tom Tromey  <tom@tromey.com>
1505
1506         * xcoffread.c (struct xcoff_symfile_info): Rename from
1507         coff_symfile_info.  Add initializers.
1508         (xcoff_objfile_data_key): Move lower.  Change type.
1509         (XCOFF_DATA): Rewrite.
1510         (xcoff_free_info): Remove.
1511         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1512         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1513         (xcoff_initial_scan): Update.
1514
1515 2019-05-08  Tom Tromey  <tom@tromey.com>
1516
1517         * solib-svr4.c (struct svr4_info): Add initializers and
1518         destructor.
1519         <probes_table>: Now an htab_up.
1520         (solib_svr4_pspace_data): Change type.
1521         (free_probes_table): Simplify.
1522         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1523         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1524         (probes_table_remove_objfile_probes, register_solib_event_probe)
1525         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1526         (_initialize_svr4_solib): Update.
1527
1528 2019-05-08  Tom Tromey  <tom@tromey.com>
1529
1530         * remote.c (remote_pspace_data): Change type.
1531         (remote_pspace_data_cleanup): Remove.
1532         (get_remote_exec_file, set_pspace_remote_exec_file)
1533         (_initialize_remote): Update.
1534
1535 2019-05-08  Tom Tromey  <tom@tromey.com>
1536
1537         * breakpoint.c (breakpoint_objfile_key): Change type.
1538         (get_breakpoint_objfile_data): Update.
1539         (free_breakpoint_objfile_data): Remove.
1540         (_initialize_breakpoint): Update.
1541
1542 2019-05-08  Tom Tromey  <tom@tromey.com>
1543
1544         * linux-tdep.c (struct linux_info): Add initializers.
1545         (linux_inferior_data): Move.  Change type.
1546         (invalidate_linux_cache_inf): Update.
1547         (linux_inferior_data_cleanup): Remove.
1548         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1549
1550 2019-05-08  Tom Tromey  <tom@tromey.com>
1551
1552         * auxv.c (auxv_inferior_data): Move.  Change type.
1553         (auxv_inferior_data_cleanup): Remove.
1554         (invalidate_auxv_cache_inf): Rewrite.
1555         (get_auxv_inferior_data, _initialize_auxv): Update.
1556
1557 2019-05-08  Tom Tromey  <tom@tromey.com>
1558
1559         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1560         (symfile_debug_objfile_data_key): Change type.
1561         (symfile_debug_installed, debug_qf_has_symbols)
1562         (debug_qf_find_last_source_symtab)
1563         (debug_qf_forget_cached_source_info)
1564         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1565         (debug_qf_print_stats, debug_qf_dump)
1566         (debug_qf_expand_symtabs_for_function)
1567         (debug_qf_expand_all_symtabs)
1568         (debug_qf_expand_symtabs_with_fullname)
1569         (debug_qf_map_matching_symbols)
1570         (debug_qf_expand_symtabs_matching)
1571         (debug_qf_find_pc_sect_compunit_symtab)
1572         (debug_qf_map_symbol_filenames)
1573         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1574         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1575         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1576         (debug_sym_read_linetable, debug_sym_relocate): Update.
1577         (symfile_debug_free_objfile): Remove.
1578         (install_symfile_debug_logging, _initialize_symfile_debug):
1579         Update.
1580
1581 2019-05-08  Tom Tromey  <tom@tromey.com>
1582
1583         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1584         allocate_on_obstack.
1585         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1586         (get_dwarf2_per_objfile): Update.
1587         (set_dwarf2_per_objfile): Remove.
1588         (dwarf2_has_info, dwarf2_get_section_info): Update.
1589         (dwarf2_free_objfile): Remove.
1590         (_initialize_dwarf2_read): Update.
1591
1592 2019-05-08  Tom Tromey  <tom@tromey.com>
1593
1594         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1595         initializers.
1596         <unsupported_script_warning_printed,
1597         script_not_found_warning_printed>: Now bool.
1598         (auto_load_pspace_data): Change type.
1599         (~auto_load_pspace_info): Rename from
1600         auto_load_pspace_data_cleanup.
1601         (get_auto_load_pspace_data, init_loaded_scripts_info)
1602         (clear_section_scripts, maybe_print_unsupported_script_warning)
1603         (maybe_print_script_not_found_warning, _initialize_auto_load):
1604         Update.
1605
1606 2019-05-08  Tom Tromey  <tom@tromey.com>
1607
1608         * objfiles.c (objfile_pspace_info): Add destructor and
1609         initializers.
1610         (objfiles_pspace_data): Change type.
1611         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1612         (get_objfile_pspace_data): Update.
1613         (objfiles_bfd_data): Change type.
1614         (get_objfile_bfd_data): Update.
1615         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1616
1617 2019-05-08  Tom Tromey  <tom@tromey.com>
1618
1619         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1620         Change type.
1621         (get_catch_syscall_inferior_data): Update.
1622         (catch_syscall_inferior_data_cleanup): Remove.
1623         (_initialize_break_catch_syscall): Update.
1624
1625 2019-05-08  Tom Tromey  <tom@tromey.com>
1626
1627         * inflow.c (struct terminal_info): Add destructor and
1628         initializers.
1629         (inflow_inferior_data): Change type.
1630         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1631         (get_inflow_inferior_data, inflow_inferior_exit)
1632         (swap_terminal_info, _initialize_inflow): Update.
1633
1634 2019-05-08  Tom Tromey  <tom@tromey.com>
1635
1636         * target-dcache.c (target_dcache_cleanup): Remove.
1637         (target_dcache_aspace_key): Change type.
1638         (target_dcache_init_p, target_dcache_invalidate)
1639         (target_dcache_get, target_dcache_get_or_init)
1640         (_initialize_target_dcache): Update.
1641         * dcache.h (struct dcache_deleter): New.
1642
1643 2019-05-08  Tom Tromey  <tom@tromey.com>
1644
1645         * symtab.c (struct symbol_cache): Add destructor and
1646         initializers.
1647         (symbol_cache_key): Move.  Change type.
1648         (make_symbol_cache, free_symbol_cache): Remove.
1649         (get_symbol_cache): Update.
1650         (symbol_cache_cleanup): Remove.
1651         (ALL_PSPACES, symbol_cache_flush)
1652         (maintenance_print_symbol_cache)
1653         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1654         Update.
1655
1656 2019-05-08  Tom Tromey  <tom@tromey.com>
1657
1658         * symtab.c (struct main_info): Add destructor and initializers.
1659         (main_progspace_key): Move.  Change type.
1660         (get_main_info): Update.
1661         (main_info_cleanup): Remove.
1662         (_initialize_symtab): Update.
1663
1664 2019-05-08  Tom Tromey  <tom@tromey.com>
1665
1666         * registry.h (DECLARE_REGISTRY): Define the _key class.
1667
1668 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1669
1670         * NEWS: Merge two 'New commands' sections.
1671
1672 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1673
1674         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1675         parameter and use Ada language definition instead.
1676         (ada_val_print_ptr): Remove unused language parameter.
1677         (ada_val_print_num): Remove language parameter and use Ada language
1678         definition instead.
1679         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1680         parameter.
1681         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1682         parameter and use Ada language definition instead.
1683         (ada_val_print_1): Update all ada_val_print_xxx calls.
1684         Remove language parameter.
1685         (ada_val_print): Update ada_val_print_1 call.
1686
1687 2019-05-08  Tom Tromey  <tromey@adacore.com>
1688
1689         * remote.c (remote_hw_watchpoint_limit)
1690         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1691         Now static.
1692
1693 2019-05-08  Tom Tromey  <tromey@adacore.com>
1694
1695         * maint.c (_initialize_maint_cmds): Move initialization code to
1696         remote.c.
1697         (watchdog, show_watchdog): Move to remote.c.
1698         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1699         "watchdog" static.
1700         (_initialize_remote): Move initialization code from maint.c.
1701         * defs.h (watchdog): Don't declare.
1702
1703 2019-05-08  Tom Tromey  <tromey@adacore.com>
1704
1705         * tui/tui-interp.c: Include main.h.
1706         * interps.c: Include main.h.
1707         * main.h (interpreter_p): Declare.
1708         * defs.h (interpreter_p): Don't declare.
1709
1710 2019-05-08  Tom Tromey  <tromey@adacore.com>
1711
1712         * dwarf2loc.c: Include dwarf2read.h.
1713         * defs.h (read_unsigned_leb128): Don't declare.
1714         * dwarf2read.h (read_unsigned_leb128): Declare.
1715
1716 2019-05-08  Tom Tromey  <tromey@adacore.com>
1717
1718         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1719         method.
1720
1721 2019-05-08  Tom Tromey  <tromey@adacore.com>
1722
1723         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1724         when no wrap column is set.
1725
1726 2019-05-08  Tom Tromey  <tromey@adacore.com>
1727
1728         * c-lang.c (c_get_string): Handle non-C-style arrays.
1729
1730 2019-05-08  Tom Tromey  <tromey@adacore.com>
1731
1732         * typeprint.c (print_offset_data::update): Print the bit offset,
1733         not the number of bits remaining.
1734
1735 2019-05-08  Tom Tromey  <tromey@adacore.com>
1736
1737         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1738         padding at end of comment.
1739
1740 2019-05-08  Tom Tromey  <tromey@adacore.com>
1741
1742         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1743         Compare main types.
1744
1745 2019-05-06  Tom Tromey  <tom@tromey.com>
1746
1747         * common/scoped_mmap.c: Include common-defs.h.
1748         * common/scoped_mmap.h: Don't include config.h.
1749
1750 2019-05-04  Tom Tromey  <tom@tromey.com>
1751
1752         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1753         (struct aarch64_call_info): Add initializers.
1754         <si>: Now a std::vector.
1755         (pass_on_stack, aarch64_push_dummy_call): Update.
1756
1757 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1758             Tom Tromey  <tom@tromey.com>
1759
1760         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1761         (ppc_threads): Now a std::vector.  Now static.
1762         (hwdebug_find_thread_points_by_tid)
1763         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1764         Update.
1765
1766 2019-05-04  Tom Tromey  <tom@tromey.com>
1767
1768         * arc-tdep.c (arc_tdesc_init): Return bool.
1769
1770 2019-05-04  Tom Tromey  <tom@tromey.com>
1771
1772         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1773         Use gdb_assert_not_reached.
1774
1775 2019-05-04  Tom Tromey  <tom@tromey.com>
1776
1777         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1778         "false".
1779
1780 2019-05-04  Tom Tromey  <tom@tromey.com>
1781
1782         * arc-tdep.c (arc_tdesc_init): Use bool.
1783
1784 2019-05-04  Tom Tromey  <tom@tromey.com>
1785
1786         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1787
1788 2019-05-04  Tom Tromey  <tom@tromey.com>
1789
1790         * cli/cli-cmds.c (valid_command_p): Return bool.
1791
1792 2019-05-04  Tom Tromey  <tom@tromey.com>
1793
1794         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1795         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1796
1797 2019-05-04  Raul Tambre  <raul@tambre.ee>
1798
1799         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1800         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1801         operator for comparison.
1802
1803 2019-05-04  Tom Tromey  <tom@tromey.com>
1804
1805         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1806         (lookup_partial_symbol, print_partial_symbols)
1807         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1808         (psymbol_compare): Update.
1809         (add_psymbol_to_bcache): Clear the entire psymbol.
1810         (maintenance_check_psymtabs): Update.
1811         * psympriv.h (struct partial_symbol): Don't derive from
1812         general_symbol_info.
1813         <obj_section, unrelocated_address, address,
1814         set_unrelocated_address>: Update.
1815         <ginfo>: New member.
1816         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1817         (debug_names::write_psymbols): Update.
1818
1819 2019-05-04  Tom de Vries  <tdevries@suse.de>
1820
1821         * contrib/cc-with-tweaks.sh: Support -n arg.
1822
1823 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1824
1825         * corelow.c (core_target::detach): Ensure frame cache and
1826         register caches are cleared.
1827         inferior.c (exit_inferior_1): Likewise.
1828
1829 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1830             Tom Tromey  <tom@tromey.com>
1831
1832         * dictionary.c (collate_pending_symbols_by_language): Remove
1833         "struct" from foreach.
1834         * symtab.c (lookup_global_symbol_from_objfile)
1835         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1836         foreach.
1837         * ser-tcp.c (net_open): Remove "struct" from foreach.
1838         * objfiles.c (objfile_relocate, objfile_rebase)
1839         (objfile_has_symbols): Remove "struct" from foreach.
1840         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1841         from foreach.
1842         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1843         foreach.
1844         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1845         "struct" from foreach.
1846         * ada-lang.c (create_excep_cond_exprs)
1847         (ada_exception_catchpoint_cond_string): Remove "struct" from
1848         foreach.
1849
1850 2019-05-03  Tom Tromey  <tromey@adacore.com>
1851
1852         * ada-exp.y (convert_char_literal): Check suffix of each
1853         enumerator.
1854
1855 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1856
1857         PR ada/21406:
1858         * ada-exp.y (yywrap): Don't define.
1859         * ada-lex.l (%option): Add noyywrap
1860         (yywrap): Remove.
1861
1862 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1863
1864         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1865         _WIN32_WINNT to the XP level, unless already defined to a higher
1866         level.
1867
1868         * unittests/parse-connection-spec-selftests.c:
1869         * ser-tcp.c:
1870         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1871         override.
1872
1873         * symfile.c (find_separate_debug_file): Remove colon from the
1874         drive spec of DOS/Windows file names of the target, so that the
1875         file name produced from DEBUGDIR and the target's directory will
1876         be valid on DOS/Windows systems.
1877
1878 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1879
1880         * rust-lang.c (val_print_struct): Handle printing structures
1881         containing strings.
1882
1883 2019-05-02  Tom Tromey  <tromey@adacore.com>
1884
1885         * valarith.c (_initialize_valarith): Remove.
1886
1887 2019-05-01  Tom Tromey  <tromey@adacore.com>
1888
1889         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1890         bitfields.
1891
1892 2019-05-01  Tom Tromey  <tromey@adacore.com>
1893
1894         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1895         for big-endian copies.
1896
1897 2019-04-30  Ali Tamur  <tamur@google.com>
1898         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1899         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1900         (read_3_bytes): New function.
1901
1902 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1903
1904         * windows-nat.c (main_thread_id): Delete.
1905         (handle_output_debug_string): Replace main_thread_id by
1906         current_event.dwThreadId.
1907         (fake_create_process): Likewise.
1908         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1909         Do not set main_thread_id.
1910         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1911         current_event.dwThreadId.
1912         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1913
1914 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1915
1916         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1917         Use current_event.dwThreadId instead of main_thread_id.
1918
1919 2019-04-30  Tom Tromey  <tromey@adacore.com>
1920
1921         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1922         (create_excep_cond_exprs): Iterate over program spaces.
1923         (ada_exception_catchpoint_cond_string): Examine all minimal
1924         symbols for exception types.
1925
1926 2019-04-30  Tom Tromey  <tromey@adacore.com>
1927
1928         PR c++/24470:
1929         * dwarf2read.c (process_structure_scope): Handle case where type
1930         has template parameters but no symbol was created.
1931
1932 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1933             Chris January  <chris.january@arm.com>
1934
1935         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1936         qualifier.
1937         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1938
1939 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1940
1941         * f-typeprint.c (f_print_type): Update rules for printing
1942         whitespace.
1943         (f_type_print_varspec_suffix): Likewise.
1944
1945 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1946             Chris January  <chris.january@arm.com>
1947
1948         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1949         function arguments.
1950
1951 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1952
1953         * f-lang.c (build_fortran_types): Change name of void type to
1954         lower case.
1955         * f-typeprint.c (f_type_print_base): Print the name of the void
1956         type, rather than a fixed string.
1957         * f-valprint.c (f_decorations): Use lower case void string.
1958
1959 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1960             Chris January  <chris.january@arm.com>
1961
1962         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1963         types for Fortran.
1964
1965 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1966             Chris January  <chris.january@arm.com>
1967             David Lecomber  <david.lecomber@arm.com>
1968
1969         * f-exp.y (BINOP_INTRINSIC): New token.
1970         (exp): New parser rule handling BINOP_INTRINSIC.
1971         (f77_keywords): Add new builtin procedures.
1972         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1973         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1974         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1975         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1976         (print_unop_subexp_f): New function.
1977         (print_binop_subexp_f): New function.
1978         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1979         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1980         (dump_subexp_body_f): Likewise.
1981         (operator_check_f): Likewise.
1982         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1983         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1984
1985 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1988         UNOP_KIND.
1989         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1990         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1991         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1992         (operator_length_f): New fuction.
1993         (print_subexp_f): New function.
1994         (op_name_f): New function.
1995         (dump_subexp_body_f): New function.
1996         (operator_check_f): New function.
1997         (exp_descriptor_f): Replace standard expression handling functions
1998         with new functions.
1999         * gdb/fortran-operator.def: New file.
2000         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2001         * gdb/std-operator.def: Remove UNOP_KIND.
2002
2003 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2004
2005         * std-operator.def: Remove unbalanced, stray double quote
2006         character.
2007
2008 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2009             Chris January  <chris.january@arm.com>
2010             Daniel Everett  <daniel.everett@arm.com>
2011             Nick Forrington  <nick.forrington@arm.com>
2012             Richard Bunt  <richard.bunt@arm.com>
2013
2014         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2015         of depth when printing anonymous structs or unions.
2016         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2017         Don't print either the top-level value, or the children if the
2018         max-depth is exceeded.
2019         (ppscm_print_children): When printing the key of a map, allow one
2020         extra level of depth.
2021         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2022         print either the top-level value, or the children if the max-depth
2023         is exceeded.
2024         (print_children): When printing the key of a map, allow one extra
2025         level of depth.
2026         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2027         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2028         (user_print_options): Initialise max_depth field.
2029         (val_print_scalar_or_string_type_p): New function.
2030         (val_print): Check to see if the max depth has been reached.
2031         (val_print_check_max_depth): Define new function.
2032         (show_print_max_depth): New function.
2033         (_initialize_valprint): Add 'print max-depth' option.
2034         * valprint.h (struct value_print_options) <max_depth>: New field.
2035         (val_print_check_max_depth): Declare new function.
2036         * NEWS: Document new feature.
2037
2038 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2039
2040         * ada-lang.c (ada_language_defn): Initialise new field.
2041         * c-lang.c (c_is_string_type_p): New function.
2042         (c_language_defn): Initialise new field.
2043         (cplus_language_defn): Initialise new field.
2044         (asm_language_defn): Initialise new field.
2045         (minimal_language_defn): Initialise new field.
2046         * c-lang.h (c_is_string_type_p): Declare new function.
2047         * d-lang.c (d_language_defn): Initialise new field.
2048         * f-lang.c (f_is_string_type_p): New function.
2049         (f_language_defn): Initialise new field.
2050         * go-lang.c (go_is_string_type_p): New function.
2051         (go_language_defn): Initialise new field.
2052         * language.c (default_is_string_type_p): New function.
2053         (unknown_language_defn): Initialise new field.
2054         (auto_language_defn): Initialise new field.
2055         * language.h (struct language_defn) <la_is_string_type_p>: New
2056         member variable.
2057         (default_is_string_type_p): Declare new function.
2058         * m2-lang.c (m2_language_defn): Initialise new field.
2059         * objc-lang.c (objc_language_defn): Initialise new field.
2060         * opencl-lang.c (opencl_language_defn): Initialise new field.
2061         * p-lang.c (pascal_is_string_type_p): New function.
2062         (pascal_language_defn): Initialise new field.
2063         * rust-lang.c (rust_is_string_type_p): New function.
2064         (rust_language_defn): Initialise new field.
2065
2066 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2067
2068         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2069         New field.
2070         * ada-lang.c (ada_language_defn): Initialise new field.
2071         * c-lang.c (c_language_defn): Likewise.
2072         (cplus_language_defn): Likewise.
2073         (asm_language_defn): Likewise.
2074         (minimal_language_defn): Likewise.
2075         * d-lang.c (d_language_defn): Likewise.
2076         * f-lang.c (f_language_defn): Likewise.
2077         * go-lang.c (go_language_defn): Likewise.
2078         * language.c (unknown_language_defn): Likewise.
2079         (auto_language_defn): Likewise.
2080         * m2-lang.c (m2_language_defn): Likewise.
2081         * objc-lang.c (objc_language_defn): Likewise.
2082         * opencl-lang.c (opencl_language_defn): Likewise.
2083         * p-lang.c (pascal_language_defn): Likewise.
2084         * rust-lang.c (rust_language_defn): Likewise.
2085
2086 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2087
2088         * ada-lang.c (ada_is_character_type): Change return type to bool.
2089         (ada_is_string_type): Likewise.
2090         * ada-lang.h (ada_is_character_type): Update declaration
2091         (ada_is_string_type): Likewise.
2092
2093 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2094
2095         Support style in 'frame|thread apply'
2096
2097         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2098         * record.c (record_start, record_stop): Update callers of
2099         execute_command_to_string with false.
2100         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2101         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2102         methods.
2103         (class string_file): New constructor with term_out parameter.
2104         Override methods term_out and can_emit_style_escape.  New member
2105         term_out.
2106         (class stdio_file): Override can_emit_style_escape.
2107         (class tee_file): Override term_out and can_emit_style_escape.
2108         * utils.h (can_emit_style_escape): Remove.
2109         * utils.c (can_emit_style_escape): Likewise.
2110         Update all callers of can_emit_style_escape (SOMESTREAM) to
2111         SOMESTREAM->can_emit_style_escape.
2112         * source-cache.c (source_cache::get_source_lines): Likewise.
2113         * stack.c (frame_apply_command_count): Call execute_command_to_string
2114         passing the term_out characteristic of the current gdb_stdout.
2115         * thread.c (thr_try_catch_cmd): Likewise.
2116         * top.c (execute_command_to_string): pass term_out parameter
2117         to construct the string_file for the command output.
2118         * ui-file.c (term_cli_styling): New function (most code moved
2119         from utils.c can_emit_style_escape).
2120         (string_file::string_file, string_file::can_emit_style_escape,
2121         stdio_file::can_emit_style_escape, tee_file::term_out,
2122         tee_file::can_emit_style_escape): New functions.
2123
2124 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2125
2126         * NEWS: Mention the new set|show may-call-functions.
2127         * infcall.c (may_call_functions_p): New variable.
2128         (show_may_call_functions_p): New function.
2129         (call_function_by_hand_dummy): Throws an error if not
2130         may-call-functions.
2131         (_initialize_infcall): Call add_setshow_boolean_cmd for
2132         may-call-functions.
2133
2134 2019-04-25  Keith Seitz  <keiths@redhat.com>
2135
2136         PR c++/24367
2137         * cp-support.c (inspect_type): Don't attempt substitutions
2138         of symbol with the same name.
2139
2140 2019-04-25  Tom Tromey  <tromey@adacore.com>
2141
2142         PR gdb/24475:
2143         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2144         static.
2145
2146 2019-04-25  Tom Tromey  <tromey@adacore.com>
2147
2148         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2149         rvalue reference.
2150         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2151         (gdb_xml_parser::parse): Use std::move.
2152         * python/python-internal.h (gdbpy_convert_exception): Take a const
2153         reference.
2154         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2155         std::move.
2156         * python/py-utils.c (gdbpy_convert_exception): Take a const
2157         reference.
2158         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2159         Use std::move.
2160         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2161         Use std::move.
2162         * mi/mi-main.c (mi_print_exception): Take a const reference.
2163         * main.c (handle_command_errors): Take a const reference.
2164         * linespec.c (parse_linespec): Use std::move.
2165         * infcall.c (run_inferior_call): Use std::move.
2166         (call_function_by_hand_dummy): Use std::move.
2167         * exec.c (try_open_exec_file): Use std::move.
2168         * exceptions.h (exception_print, exception_fprintf)
2169         (exception_print_same): Update.
2170         * exceptions.c (print_exception, exception_print)
2171         (exception_fprintf, exception_print_same): Change parameters to
2172         const reference.
2173         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2174         * common/new-op.c: Use std::move.
2175         * common/common-exceptions.h (struct gdb_exception): Add move
2176         constructor.
2177         (struct gdb_exception_error, struct gdb_exception_quit, struct
2178         gdb_quit_bad_alloc): Change constructor to move constructor.
2179         (throw_exception): Change parameter to rvalue reference.
2180         * common/common-exceptions.c (throw_exception): Take rvalue
2181         reference.
2182         * cli/cli-interp.c (safe_execute_command): Use std::move.
2183         * breakpoint.c (insert_bp_location, location_to_sals): Use
2184         std::move.
2185
2186 2019-04-25  Tom Tromey  <tromey@adacore.com>
2187
2188         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2189         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2190         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2191         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2192         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2193         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2194         guile/scm-value.c: Use unpack.
2195         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2196         gdbscm_gdb_exception.
2197         (gdbscm_throw_gdb_exception): Likewise.
2198         (struct gdbscm_gdb_exception): New.
2199         (unpack): New function.
2200         (gdbscm_wrap): Use unpack.
2201
2202 2019-04-25  Tom Tromey  <tromey@adacore.com>
2203
2204         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2205         (gdb_rl_callback_handler): Use std::move.
2206         * common/common-exceptions.h (struct gdb_exception): Add move
2207         assignment operator.
2208         (throw_exception_sjlj): Change "exception" to const reference.
2209         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2210         (throw_exception_sjlj): Change "exception" to const reference.
2211
2212 2019-04-25  Tom Tromey  <tromey@adacore.com>
2213
2214         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2215         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2216         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2217         Update.
2218         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2219         Update.
2220         * mi/mi-interp.c (mi_interp::exec): Update.
2221         * linespec.c (parse_linespec): Update.
2222         * infcall.c (run_inferior_call): Update.
2223         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2224         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2225         (gdbscm_lookup_global_symbol): Update.
2226         * guile/scm-param.c (gdbscm_parameter_value): Update.
2227         * guile/scm-frame.c (gdbscm_frame_read_register)
2228         (gdbscm_frame_read_var): Update.
2229         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2230         * exec.c (try_open_exec_file): Update.
2231         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2232         (gdb_rl_callback_handler): Update.
2233         * common/common-exceptions.h (exception_none): Don't declare.
2234         * common/common-exceptions.c (exception_none): Don't define.
2235         (struct catcher) <exception>: Update.
2236         * cli/cli-interp.c (safe_execute_command): Update.
2237         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2238
2239 2019-04-25  Ali Tamur  <tamur@google.com>
2240
2241         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2242         (read_attribute_value): Likewise.
2243         (dwarf2_read_addr_index): Update comment.
2244         (read_str_index): Add DW_FORM_strx.
2245         (dwarf2_string_attr): Likewise.
2246         (dwarf2_const_value_attr): Likewise.
2247         (dump_die_shallow): Likewise.
2248         (dwarf2_fetch_constant_bytes): Likewise.
2249         (skip_form_bytes): Likewise.
2250         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2251
2252 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2253
2254         PR corefiles/11608
2255         PR corefiles/18187
2256         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2257         OFFSET.  Verify if current mapping contains an ELF header.
2258         (linux_find_memory_regions_full): Adjust call to
2259         dump_mapping_p.
2260
2261 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2262             Kang Li <kanglictf@gmail.com>
2263
2264         PR gdb/21600
2265
2266         * dwarf2-frame.c (read_initial_length): Be consistent about using
2267         unsigned representation of length.
2268         (decode_frame_entry_1): Likewise.  Check for wraparound of
2269         end pointer as well as buffer overflow.
2270
2271 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2272
2273         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2274         "vq".
2275
2276 2019-04-24  Tom Tromey  <tromey@adacore.com>
2277
2278         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2279
2280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * s12z-tdep.c (s12z_unwind_pc): Delete.
2283         (s12z_unwind_sp): Delete.
2284         (s12z_gdbarch_init): Don't register deleted functions with
2285         gdbarch.
2286
2287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2288
2289         * rl78-tdep.c (rl78_unwind_sp): Delete.
2290         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2291
2292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2293
2294         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2295         (xstormy16_unwind_pc): Delete.
2296         (xstormy16_dummy_id): Delete.
2297         (xstormy16_gdbarch_init): Don't register deleted functions with
2298         gdbarch.
2299
2300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * vax-tdep.c (vax_unwind_pc): Delete.
2303         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2304
2305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2306
2307         * v850-tdep.c (v850_unwind_sp): Delete.
2308         (v850_unwind_pc): Delete.
2309         (v850_dummy_id): Delete.
2310         (v850_gdbarch_init): Don't register deleted functions with
2311         gdbarch.
2312
2313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2314
2315         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2316         (tilegx_unwind_pc): Delete.
2317         (tilegx_unwind_dummy_id): Delete.
2318         (tilegx_gdbarch_init): Don't register deleted functions with
2319         gdbarch.
2320
2321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2322
2323         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2324         (tic6x_dummy_id): Delete.
2325         (tic6x_gdbarch_init): Don't register deleted functions with
2326         gdbarch.
2327
2328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2329
2330         * sparc-tdep.c (sparc_unwind_pc): Delete.
2331         (sparc32_gdbarch_init): Don't register deleted function with
2332         gdbarch.
2333
2334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2335
2336         * sh-tdep.c (sh_unwind_sp): Delete.
2337         (sh_unwind_pc): Delete.
2338         (sh_dummy_id): Delete.
2339         (sh_gdbarch_init): Don't register deleted functions with
2340         gdbarch.
2341
2342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2343
2344         * score-tdep.c (score_unwind_sp): Delete.
2345         (score_unwind_pc): Delete.
2346         (score_dummy_id): Delete.
2347         (score_gdbarch_init): Don't register deleted functions with
2348         gdbarch.
2349
2350 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2351
2352         * rx-tdep.c (rx_unwind_pc): Delete.
2353         (rx_unwind_sp): Delete.
2354         (rx_dummy_id): Delete.
2355         (rx_gdbarch_init): Don't register deleted functions with
2356         gdbarch.  Update comment.
2357
2358 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2359
2360         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2361         (rs6000_dummy_id): Delete.
2362         (rs6000_gdbarch_init): Don't register deleted functions with
2363         gdbarch.
2364
2365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2366
2367         * or1k-tdep.c (or1k_dummy_id): Delete.
2368         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2369
2370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2371
2372         * nios2-tdep.c (nios2_dummy_id): Delete.
2373         (nios2_unwind_sp): Delete.
2374         (nios2_gdbarch_init): Don't register deleted functions with
2375         gdbarch.
2376
2377 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2378
2379         * nds32-tdep.c (nds32_dummy_id): Delete.
2380         (nds32_unwind_pc): Delete.
2381         (nds32_unwind_sp): Delete.
2382         (nds32_gdbarch_init): Don't register deleted functions with
2383         gdbarch.
2384
2385 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2386
2387         * msp430-tdep.c (msp430_unwind_pc): Delete.
2388         (msp430_unwind_sp): Delete.
2389         (msp430_dummy_id): Delete.
2390         (msp430_gdbarch_init): Don't register deleted functions with
2391         gdbarch.
2392
2393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2394
2395         * moxie-tdep.c (moxie_unwind_sp): Delete.
2396         (moxie_unwind_pc): Delete.
2397         (moxie_dummy_id): Delete.
2398         (moxie_gdbarch_init): Don't register deleted functions with
2399         gdbarch.
2400
2401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2402
2403         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2404         (mn10300_unwind_pc): Delete.
2405         (mn10300_unwind_sp): Delete.
2406         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2407         mn10300_unwind_sp.
2408         (mn10300_frame_unwind_init): Don't register deleted functions with
2409         gdbarch.
2410
2411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2412
2413         * mep-tdep.c (mep_unwind_pc): Delete.
2414         (mep_unwind_sp): Delete.
2415         (mep_dummy_id): Delete.
2416         (mep_gdbarch_init): Don't register deleted functions with
2417         gdbarch.
2418
2419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2420
2421         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2422         (m68hc11_unwind_sp): Delete.
2423         (m68hc11_gdbarch_init): Don't register deleted functions with
2424         gdbarch.
2425
2426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2427
2428         * m32r-tdep.c (m32r_unwind_sp): Delete.
2429         (m32r_unwind_pc): Delete.
2430         (m32r_dummy_id): Delete.
2431         (m32r_gdbarch_init): Don't register deleted functions with
2432         gdbarch.
2433
2434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2435
2436         * m32c-tdep.c (m32c_unwind_pc): Delete.
2437         (m32c_unwind_sp): Delete.
2438         (m32c_dummy_id): Delete.
2439         (m32c_gdbarch_init): Don't register deleted functions with
2440         gdbarch.
2441
2442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2443
2444         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2445         (lm32_unwind_pc): Delete.
2446         (lm32_dummy_id): Delete.
2447         (lm32_gdbarch_init): Don't register deleted functions with
2448         gdbarch.
2449
2450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2451
2452         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2453         (iq2000_unwind_pc): Delete.
2454         (iq2000_dummy_id): Delete.
2455         (iq2000_gdbarch_init): Don't register deleted functions with
2456         gdbarch.
2457
2458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2459
2460         * nds32-tdep.c (nds32_type_align): Delete.
2461         (nds32_push_dummy_call): Use type_align instead.
2462
2463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2464
2465         * arm-tdep.c (arm_type_align): Only handle vector override case.
2466         (arm_push_dummy_call): Use type_align.
2467         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2468
2469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2470
2471         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2472         case.
2473         (pass_on_stack): Use type_align.
2474         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2475         function.
2476
2477 2019-04-23  Tom Tromey  <tromey@adacore.com>
2478
2479         * dwarf2read.c (line_header::file_name_at): Remove unused
2480         overload.
2481
2482 2019-04-23  Tom de Vries  <tdevries@suse.de>
2483
2484         PR gdb/24438
2485         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2486         invocation.
2487
2488
2489 2019-03-27  Ali Tamur  <tamur@google.com>
2490
2491         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2492         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2493         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2494         (dwarf_expr_context::get_addr_index): Likewise
2495         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2496         (symbol_needs_eval_context::get_addr_index): Likewise
2497         (disassemble_dwarf_expression): Add DW_OP_addrx
2498         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2499         (read_cutu_die_from_dwo): Update comment
2500         (skip_one_die): Add DW_FORM_addrx
2501         (read_attribute_value): Likewise
2502         (var_decode_location): Add DW_OP_addrx
2503         (dwarf2_const_value_attr): Add DW_FORM_addrx
2504         (dump_die_shallow): Likewise
2505         (dwarf2_fetch_constant_bytes): Likewise
2506         (decode_locdesc): Add DW_OP_addrx
2507         (skip_form_bytes): Add DW_FORM_addrx
2508
2509 2019-04-22  Ali Tamur  <tamur@google.com>
2510
2511         * MAINTAINERS (Write After Approval): Add self.
2512
2513 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2514
2515         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2516         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2517         (open_symbol_file_object): Likewise.
2518         (svr4_default_sos): Add info parameter.
2519         (svr4_read_so_list): Likewise.
2520         (svr4_current_sos_direct): Adjust functions calls to pass down
2521         info.
2522         (svr4_current_sos_1): Add info parameter.
2523         (svr4_current_sos): Call get_svr4_info, pass info down to
2524         svr4_current_sos_1.
2525         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2526         get_svr4_info.
2527         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2528         get_svr4_info.
2529         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2530         to get_svr4_info.
2531         (probes_table_remove_objfile_probes): Likewise.
2532         (register_solib_event_probe): Add info parameter.
2533         (solist_update_incremental): Pass info parameter down to
2534         svr4_read_so_list.
2535         (disable_probes_interface): Add info parameter.
2536         (svr4_handle_solib_event): Pass current_program_space to
2537         get_svr4_info.  Adjust disable_probes_interface cleanup.
2538         (svr4_create_probe_breakpoints): Add info parameter, pass it
2539         down to register_solib_event_probe.
2540         (svr4_create_solib_event_breakpoints): Add info parameter,
2541         pass it down to svr4_create_probe_breakpoints.
2542         (enable_break): Pass info down to
2543         svr4_create_solib_event_breakpoints.
2544         (svr4_solib_create_inferior_hook): Pass current_program_space to
2545         get_svr4_info.
2546         (svr4_clear_solib): Likewise.
2547
2548 2019-04-22  Pedro Alves  <palves@redhat.com>
2549
2550         * solib-svr4.c (svr4_free_objfile_observer): New.
2551         (probe_and_action::objfile): New field.
2552         (probes_table_htab_remove_objfile_probes)
2553         (probes_table_remove_objfile_probes): New functions.
2554         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2555         in the new probe_and_action.  Don't store the probe in 'lookup'.
2556         (svr4_create_probe_breakpoints): Pass objfile to
2557         register_solib_event_probe.
2558         (_initialize_svr4_solib): Register a free_objfile observer.
2559
2560 2019-04-19  Tom Tromey  <tom@tromey.com>
2561
2562         * common/queue.h: Remove.
2563
2564 2019-04-19  Tom Tromey  <tom@tromey.com>
2565
2566         * event-loop.c: Don't include "common/queue.h".
2567
2568 2019-04-19  Tom Tromey  <tom@tromey.com>
2569
2570         * remote.c (remote_target): Use delete.
2571         * remote-notif.h: Include <list>, not "common/queue.h".
2572         (notif_client_p): Remove typedef.
2573         (remote_notif_state): Add constructor, destructor, initializer.
2574         <notif_queue>: Now a std::list.
2575         (remote_notif_state_xfree): Don't declare.
2576         * remote-notif.c (remote_notif_process, handle_notification)
2577         (remote_notif_state_allocate): Update.
2578         (~remote_notif_state): Rename from remote_notif_state_xfree.
2579
2580 2019-04-19  Tom Tromey  <tom@tromey.com>
2581
2582         * symfile.c (reread_symbols): Update.
2583         * objfiles.c (objfile_register_static_link)
2584         (objfile_lookup_static_link): Update
2585         (~objfile) Don't delete static_links.
2586         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2587
2588 2019-04-19  Tom Tromey  <tom@tromey.com>
2589
2590         * type-stack.h (struct type_stack) <insert>: Constify string.
2591         * type-stack.c (type_stack::insert): Constify string.
2592         * gdbtypes.h (lookup_template_type): Update.
2593         (address_space_name_to_int): Update.
2594         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2595         const.
2596         (lookup_template_type): Make name const.
2597         * c-exp.y: Update rules.
2598         (lex_one_token, classify_name, classify_inner_name)
2599         (c_print_token): Update.
2600         * p-exp.y: Update rules.
2601         (yylex): Update.
2602         * f-exp.y: Update rules.
2603         (yylex): Update.
2604         * d-exp.y: Update rules.
2605         (lex_one_token, classify_name, classify_inner_name): Update.
2606         * parse.c (write_dollar_variable, copy_name): Return std::string.
2607         * parser-defs.h (copy_name): Change return type.
2608         * m2-exp.y: Update rules.
2609         (yylex): Update.
2610         * go-exp.y (lex_one_token): Update.
2611         Update rules.
2612         (classify_unsafe_function, classify_packaged_name)
2613         (classify_name, yylex): Update.
2614
2615 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2616
2617         * configure.ac: add --enable-source-highlight switch.
2618         * configure: Regenerate.
2619         * top.c (print_gdb_version): plumb --enable-source-highlight
2620         status to "show configuration".
2621
2622 2019-04-19  Tom Tromey  <tromey@adacore.com>
2623
2624         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2625         Check ADA_TYPE_P.
2626         (empty_record, ada_template_to_fixed_record_type_1)
2627         (template_to_static_fixed_type)
2628         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2629         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2630         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2631         macros.
2632
2633 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2634
2635         PR symtab/24423:
2636         * source.c (print_source_lines_base): Advance "iter" when a
2637         control character is seen.
2638
2639 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2640
2641         * inferior.h (struct infcall_suspend_state_deleter):
2642         Catch exception in destructor to avoid crash.
2643
2644 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2645
2646         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2647         close to the add_com "shell".
2648
2649 2019-04-18  Tom Tromey  <tromey@adacore.com>
2650
2651         * process-stratum-target.h (class process_stratum_target)
2652         <stratum>: Add "final".
2653
2654 2019-04-17  Tom Tromey  <tromey@adacore.com>
2655
2656         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2657         against nullptr before use.
2658
2659 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2660
2661         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2662
2663 2019-04-17  Jim Wilson  <jimw@sifive.com>
2664             Andrew Burgess  <andrew.burgess@embecosm.com>
2665
2666         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2667         code read might fail, assume 4-byte breakpoint in that case.
2668
2669 2019-04-15  Leszek Swirski  <leszeks@google.com>
2670
2671         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2672         rather than a hand-rolled POD check when checking for forced MEMORY
2673         classification.
2674
2675 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2676
2677         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2678         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2679         function.
2680         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2681         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2682         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2683         declaration.
2684
2685 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2686
2687         * aarch64-linux-nat.c
2688         (aarch64_linux_nat_target::thread_architecture): Add override.
2689         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2690         each VQ.
2691
2692 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2693
2694         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2695
2696 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2697
2698         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2699         target types of size 96-bits, add some additional comments, and
2700         check that the builtin type we found was the correct size.
2701
2702 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2703
2704         * utils.c (prompt_for_continue): Don't restore the styling at the
2705         end, as applied_style has the wrong value.  This fixes styling in
2706         long lists of file names that are interrupted by the "Continue?"
2707         prompt.
2708
2709 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2710
2711         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2712         * c-lang.c (c_language_defn): Likewise.
2713         (cplus_language_defn): Likewise.
2714         (asm_language_defn): Likewise.
2715         (minimal_language_defn): Likewise.
2716         * d-lang.c (d_language_defn): Likewise.
2717         * f-lang.c (f_language_defn): Likewise.
2718         * go-lang.c (go_language_defn): Likewise.
2719         * language.c (unknown_language_defn): Likewise.
2720         (auto_language_defn): Likewise.
2721         * language.h (struct language_defn): Remove la_magic field.
2722         (LANG_MAGIC): Delete.
2723         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2724         * objc-lang.c (objc_language_defn): Likewise.
2725         * opencl-lang.c (opencl_language_defn): Likewise.
2726         * p-lang.c (pascal_language_defn): Likewise.
2727         * rust-lang.c (rust_language_defn): Likewise.
2728
2729 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2730
2731         * riscv-tdep.c (riscv_type_align): New function.
2732         (riscv_type_alignment): Delete.
2733         (riscv_arg_location): Use 'type_align'.
2734         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2735
2736 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2737
2738         * gdbtypes.c (type_align): A struct with no non-static fields also
2739         has alignment of 1.
2740
2741 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2742
2743         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2744         component to 0.
2745         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2746         member.
2747         (riscv_struct_info::analyse): New implementation using new
2748         analyse_inner member function.
2749         (riscv_struct_info::field_offset): New member function.
2750         (riscv_struct_info::m_offsets): New member variable.
2751         (riscv_struct_info::analyse_inner): New private member function,
2752         takes the old implementation of riscv_struct_info::analyse but
2753         extended to track field offsets.
2754         (riscv_call_arg_struct): Update the struct folding special cases
2755         to handle cases where empty C++ structs, which are non-zero
2756         length, are found.
2757         (riscv_arg_location): Initialise the length of each location, a
2758         non-zero length now indicates the location is in use.
2759         (riscv_push_dummy_call): Allow for the first location having a
2760         non-zero offset when setting up arguments.
2761         (riscv_return_value): Likewise, but for return values.
2762
2763 2019-04-11  Tom Tromey  <tromey@adacore.com>
2764
2765         * utils.c (internal_vproblem): Make "msg" const.
2766
2767 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2768
2769         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2770         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2771         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2772         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2773
2774 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2775
2776         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2777         function.
2778         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2779         of amd64_collect_native_gregset.
2780         (amd64_linux_nat_target::store_registers): Likewise.
2781
2782 2019-04-10  Tom Tromey  <tom@tromey.com>
2783
2784         * symtab.c (lookup_global_symbol_from_objfile)
2785         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2786         * objfiles.h (class separate_debug_iterator): New.
2787         (class separate_debug_range): New.
2788         (struct objfile) <separate_debug_objfiles>: New method.
2789         (objfile_separate_debug_iterate): Don't declare.
2790         * objfiles.c (separate_debug_iterator::operator++): Rename from
2791         objfile_separate_debug_iterate.
2792         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2793         iterator.
2794         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2795         iterator.
2796
2797 2019-04-10  Tom Tromey  <tom@tromey.com>
2798
2799         * symfile.c (reread_symbols): Remove old comment.
2800         * objfiles.c (free_all_objfiles): Fix a typo.
2801
2802 2019-04-10  Tom Tromey  <tom@tromey.com>
2803
2804         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2805         * minsyms.c (lookup_minimal_symbol): Use foreach.
2806         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2807         (lookup_minimal_symbol_solib_trampoline): Likewise.
2808         * symfile.c (reread_symbols): Use foreach.
2809
2810 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2811             Tom Tromey  <tromey@adacore.com>
2812
2813         PR rust/24414:
2814         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2815         (rust_lex_int_test): Change "value" to be LONGEST.
2816         (rust_lex_tests): Add test for long integer literal.
2817
2818 2019-04-09  Tom Tromey  <tromey@adacore.com>
2819
2820         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2821         to bool.
2822         (extended_remote_target::attach): Update.
2823         (remote_target::remote_notice_new_inferior): Update.
2824         (remote_target::add_current_inferior_and_thread): Update.
2825         * inferior.c (exit_inferior_1): Use "false".
2826         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2827
2828 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2829
2830         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2831         the "start" command.
2832
2833 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2834
2835         * python/py-inferior.c (infpy_thread_from_thread_handle):
2836         Adjust comments to reflect renaming of thread_from_thread_handle
2837         to thread_from_handle.  Adjust keywords.  Fix type error message.
2838         (inferior_object_methods): Add thread_from_handle.  Retain
2839         thread_from_thread_handle, but mark it as deprecated.
2840
2841 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2842
2843         * gdbthread.h (find_thread_by_handle): Revise declaration.
2844         * thread.c (find_thread_by_handle): Likewise.  Adjust
2845         implementation too.
2846         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2847         support for buffer objects as handles.
2848
2849 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2850
2851         * python/py-infthread.c (thpy_thread_handle): New function.
2852         (thread_object_methods): Register thpy_thread_handle.
2853
2854 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2855
2856         * gdbthread.h (thread_to_thread_handle): Declare.
2857         * thread.c (gdbtypes.h): Include.
2858         (thread_to_thread_handle): New function.
2859
2860         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2861         (target_thread_info_to_thread_handle): Declare.
2862         * target.c (target_thread_info_to_thread_handle): New function.
2863         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2864         * target-delegates.c: Regenerate.
2865
2866         * linux-thread-db.c (class thread_db_target): Add method
2867         thread_info_to_thread_handle.
2868         (thread_db_target::thread_info_to_thread_handle): Define.
2869         * remote.c (class remote_target): Add new method
2870         thread_info_to_thread_handle.
2871         (remote_target::thread_info_to_thread_handle): Define.
2872
2873 2019-04-08  Pedro Alves  <palves@redhat.com>
2874
2875         * common/common-exceptions.c (throw_exception): Don't create
2876         named object to throw; throw directly.
2877         (throw_it): Likewise.  Don't initialize gdb_exception::message
2878         here, with new; pass FMT and AP to the ctor instead.
2879         * common/common-exceptions.h: Include <string>.
2880         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2881         const char *, va_list)): New ctor.  Use std::make_shared.
2882         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2883         errors)): Delete.
2884         (gdb_exception_error::gdb_exception_error(enum errors, const char
2885         *, va_list)): New.
2886         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2887         Add assertion.
2888         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2889         errors)): Delete.
2890         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2891         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2892         Add assertion.
2893
2894 2019-04-08  Tom Tromey  <tom@tromey.com>
2895
2896         * valops.c (value_rtti_indirect_type): Replace throw_exception
2897         with throw.
2898         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2899         with throw.
2900         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2901         throw.
2902         * target.c (target_translate_tls_address): Replace throw_exception
2903         with throw.
2904         * stack.c (frame_apply_command_count): Replace throw_exception
2905         with throw.
2906         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2907         throw.
2908         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2909         with throw.
2910         * rs6000-tdep.c (rs6000_frame_cache)
2911         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2912         * remote.c: Replace throw_exception with throw.
2913         * record-full.c (record_full_message, record_full_wait_1)
2914         (record_full_restore): Replace throw_exception with throw.
2915         * record-btrace.c:
2916         (get_thread_current_frame_id, record_btrace_start_replaying)
2917         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2918         (cmd_record_btrace_start): Replace throw_exception with throw.
2919         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2920         throw.
2921         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2922         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2923         * linespec.c:
2924         (find_linespec_symbols): Replace throw_exception with throw.
2925         * infrun.c (displaced_step_prepare, resume): Replace
2926         throw_exception with throw.
2927         * infcmd.c (post_create_inferior): Replace throw_exception with
2928         throw.
2929         * inf-loop.c (inferior_event_handler): Replace throw_exception
2930         with throw.
2931         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2932         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2933         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2934         (get_prev_frame_always, get_frame_pc_if_available)
2935         (get_frame_address_in_block_if_available, get_frame_language):
2936         Replace throw_exception with throw.
2937         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2938         throw_exception with throw.
2939         * eval.c (fetch_subexp_value, evaluate_var_value)
2940         (evaluate_funcall, evaluate_subexp_standard): Replace
2941         throw_exception with throw.
2942         * dwarf2loc.c (call_site_find_chain)
2943         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2944         Replace throw_exception with throw.
2945         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2946         with throw.
2947         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2948         throw.
2949         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2950         * completer.c (complete_line_internal): Replace throw_exception
2951         with throw.
2952         * compile/compile-object-run.c (compile_object_run): Replace
2953         throw_exception with throw.
2954         * cli/cli-script.c (process_next_line): Replace throw_exception
2955         with throw.
2956         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2957         (btrace_enable, btrace_maint_update_pt_packets): Replace
2958         throw_exception with throw.
2959         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2960         throw_exception with throw.
2961         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2962         throw_exception with throw.
2963         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2964         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2965         * aarch64-tdep.c (aarch64_make_prologue_cache)
2966         (aarch64_make_stub_cache): Replace throw_exception with throw.
2967
2968 2019-04-08  Tom Tromey  <tom@tromey.com>
2969
2970         * common/common-exceptions.c (throw_exception): Rename from
2971         throw_exception_cxx.  Remove old copy.  Make argument const.
2972         (throw_it): Create and throw exception objects directly.
2973         * common/common-exceptions.h (throw_exception): Make argument
2974         const.
2975         (struct gdb_exception_error): Add constructor.
2976         (struct gdb_exception_quit): Add constructor.
2977
2978 2019-04-08  Tom Tromey  <tom@tromey.com>
2979
2980         * common/common-exceptions.h (exception_rethrow): Don't declare.
2981         (TRY_SJLJ): Update comment.
2982         (TRY, CATCH, END_CATCH): Remove.
2983         * common/common-exceptions.c (exception_rethrow): Remove.
2984
2985 2019-04-08  Tom Tromey  <tom@tromey.com>
2986
2987         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2988         Remove.
2989         (gdb_exception_error): Rename from
2990         gdb_exception_RETURN_MASK_ERROR.
2991         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2992         (gdb_quit_bad_alloc): Update.
2993         * aarch64-tdep.c: Update.
2994         * ada-lang.c: Update.
2995         * ada-typeprint.c: Update.
2996         * ada-valprint.c: Update.
2997         * amd64-tdep.c: Update.
2998         * arch-utils.c: Update.
2999         * break-catch-throw.c: Update.
3000         * breakpoint.c: Update.
3001         * btrace.c: Update.
3002         * c-varobj.c: Update.
3003         * cli/cli-cmds.c: Update.
3004         * cli/cli-interp.c: Update.
3005         * cli/cli-script.c: Update.
3006         * common/common-exceptions.c: Update.
3007         * common/new-op.c: Update.
3008         * common/selftest.c: Update.
3009         * compile/compile-c-symbols.c: Update.
3010         * compile/compile-cplus-symbols.c: Update.
3011         * compile/compile-object-load.c: Update.
3012         * compile/compile-object-run.c: Update.
3013         * completer.c: Update.
3014         * corelow.c: Update.
3015         * cp-abi.c: Update.
3016         * cp-support.c: Update.
3017         * cp-valprint.c: Update.
3018         * darwin-nat.c: Update.
3019         * disasm-selftests.c: Update.
3020         * dtrace-probe.c: Update.
3021         * dwarf-index-cache.c: Update.
3022         * dwarf-index-write.c: Update.
3023         * dwarf2-frame-tailcall.c: Update.
3024         * dwarf2-frame.c: Update.
3025         * dwarf2loc.c: Update.
3026         * dwarf2read.c: Update.
3027         * eval.c: Update.
3028         * event-loop.c: Update.
3029         * event-top.c: Update.
3030         * exec.c: Update.
3031         * f-valprint.c: Update.
3032         * fbsd-tdep.c: Update.
3033         * frame-unwind.c: Update.
3034         * frame.c: Update.
3035         * gdbtypes.c: Update.
3036         * gnu-v3-abi.c: Update.
3037         * guile/guile-internal.h: Update.
3038         * guile/scm-block.c: Update.
3039         * guile/scm-breakpoint.c: Update.
3040         * guile/scm-cmd.c: Update.
3041         * guile/scm-disasm.c: Update.
3042         * guile/scm-frame.c: Update.
3043         * guile/scm-lazy-string.c: Update.
3044         * guile/scm-math.c: Update.
3045         * guile/scm-param.c: Update.
3046         * guile/scm-ports.c: Update.
3047         * guile/scm-pretty-print.c: Update.
3048         * guile/scm-symbol.c: Update.
3049         * guile/scm-symtab.c: Update.
3050         * guile/scm-type.c: Update.
3051         * guile/scm-value.c: Update.
3052         * i386-linux-tdep.c: Update.
3053         * i386-tdep.c: Update.
3054         * inf-loop.c: Update.
3055         * infcall.c: Update.
3056         * infcmd.c: Update.
3057         * infrun.c: Update.
3058         * jit.c: Update.
3059         * language.c: Update.
3060         * linespec.c: Update.
3061         * linux-fork.c: Update.
3062         * linux-nat.c: Update.
3063         * linux-tdep.c: Update.
3064         * linux-thread-db.c: Update.
3065         * main.c: Update.
3066         * mi/mi-cmd-break.c: Update.
3067         * mi/mi-cmd-stack.c: Update.
3068         * mi/mi-interp.c: Update.
3069         * mi/mi-main.c: Update.
3070         * objc-lang.c: Update.
3071         * p-valprint.c: Update.
3072         * parse.c: Update.
3073         * ppc-linux-tdep.c: Update.
3074         * printcmd.c: Update.
3075         * python/py-arch.c: Update.
3076         * python/py-breakpoint.c: Update.
3077         * python/py-cmd.c: Update.
3078         * python/py-finishbreakpoint.c: Update.
3079         * python/py-frame.c: Update.
3080         * python/py-framefilter.c: Update.
3081         * python/py-gdb-readline.c: Update.
3082         * python/py-inferior.c: Update.
3083         * python/py-infthread.c: Update.
3084         * python/py-lazy-string.c: Update.
3085         * python/py-linetable.c: Update.
3086         * python/py-objfile.c: Update.
3087         * python/py-param.c: Update.
3088         * python/py-prettyprint.c: Update.
3089         * python/py-progspace.c: Update.
3090         * python/py-record-btrace.c: Update.
3091         * python/py-record.c: Update.
3092         * python/py-symbol.c: Update.
3093         * python/py-type.c: Update.
3094         * python/py-unwind.c: Update.
3095         * python/py-utils.c: Update.
3096         * python/py-value.c: Update.
3097         * python/python.c: Update.
3098         * record-btrace.c: Update.
3099         * record-full.c: Update.
3100         * remote-fileio.c: Update.
3101         * remote.c: Update.
3102         * riscv-tdep.c: Update.
3103         * rs6000-aix-tdep.c: Update.
3104         * rs6000-tdep.c: Update.
3105         * rust-exp.y: Update.
3106         * rust-lang.c: Update.
3107         * s390-tdep.c: Update.
3108         * selftest-arch.c: Update.
3109         * solib-dsbt.c: Update.
3110         * solib-frv.c: Update.
3111         * solib-spu.c: Update.
3112         * solib-svr4.c: Update.
3113         * solib.c: Update.
3114         * sparc64-linux-tdep.c: Update.
3115         * stack.c: Update.
3116         * symfile-mem.c: Update.
3117         * symmisc.c: Update.
3118         * target.c: Update.
3119         * thread.c: Update.
3120         * top.c: Update.
3121         * tracefile-tfile.c: Update.
3122         * tui/tui.c: Update.
3123         * typeprint.c: Update.
3124         * unittests/cli-utils-selftests.c: Update.
3125         * unittests/parse-connection-spec-selftests.c: Update.
3126         * valops.c: Update.
3127         * valprint.c: Update.
3128         * value.c: Update.
3129         * varobj.c: Update.
3130         * windows-nat.c: Update.
3131         * x86-linux-nat.c: Update.
3132         * xml-support.c: Update.
3133
3134 2019-04-08  Tom Tromey  <tom@tromey.com>
3135
3136         * xml-support.c: Use C++ exception handling.
3137         * x86-linux-nat.c: Use C++ exception handling.
3138         * windows-nat.c: Use C++ exception handling.
3139         * varobj.c: Use C++ exception handling.
3140         * value.c: Use C++ exception handling.
3141         * valprint.c: Use C++ exception handling.
3142         * valops.c: Use C++ exception handling.
3143         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3144         handling.
3145         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3146         * typeprint.c: Use C++ exception handling.
3147         * tui/tui.c: Use C++ exception handling.
3148         * tracefile-tfile.c: Use C++ exception handling.
3149         * top.c: Use C++ exception handling.
3150         * thread.c: Use C++ exception handling.
3151         * target.c: Use C++ exception handling.
3152         * symmisc.c: Use C++ exception handling.
3153         * symfile-mem.c: Use C++ exception handling.
3154         * stack.c: Use C++ exception handling.
3155         * sparc64-linux-tdep.c: Use C++ exception handling.
3156         * solib.c: Use C++ exception handling.
3157         * solib-svr4.c: Use C++ exception handling.
3158         * solib-spu.c: Use C++ exception handling.
3159         * solib-frv.c: Use C++ exception handling.
3160         * solib-dsbt.c: Use C++ exception handling.
3161         * selftest-arch.c: Use C++ exception handling.
3162         * s390-tdep.c: Use C++ exception handling.
3163         * rust-lang.c: Use C++ exception handling.
3164         * rust-exp.y: Use C++ exception handling.
3165         * rs6000-tdep.c: Use C++ exception handling.
3166         * rs6000-aix-tdep.c: Use C++ exception handling.
3167         * riscv-tdep.c: Use C++ exception handling.
3168         * remote.c: Use C++ exception handling.
3169         * remote-fileio.c: Use C++ exception handling.
3170         * record-full.c: Use C++ exception handling.
3171         * record-btrace.c: Use C++ exception handling.
3172         * python/python.c: Use C++ exception handling.
3173         * python/py-value.c: Use C++ exception handling.
3174         * python/py-utils.c: Use C++ exception handling.
3175         * python/py-unwind.c: Use C++ exception handling.
3176         * python/py-type.c: Use C++ exception handling.
3177         * python/py-symbol.c: Use C++ exception handling.
3178         * python/py-record.c: Use C++ exception handling.
3179         * python/py-record-btrace.c: Use C++ exception handling.
3180         * python/py-progspace.c: Use C++ exception handling.
3181         * python/py-prettyprint.c: Use C++ exception handling.
3182         * python/py-param.c: Use C++ exception handling.
3183         * python/py-objfile.c: Use C++ exception handling.
3184         * python/py-linetable.c: Use C++ exception handling.
3185         * python/py-lazy-string.c: Use C++ exception handling.
3186         * python/py-infthread.c: Use C++ exception handling.
3187         * python/py-inferior.c: Use C++ exception handling.
3188         * python/py-gdb-readline.c: Use C++ exception handling.
3189         * python/py-framefilter.c: Use C++ exception handling.
3190         * python/py-frame.c: Use C++ exception handling.
3191         * python/py-finishbreakpoint.c: Use C++ exception handling.
3192         * python/py-cmd.c: Use C++ exception handling.
3193         * python/py-breakpoint.c: Use C++ exception handling.
3194         * python/py-arch.c: Use C++ exception handling.
3195         * printcmd.c: Use C++ exception handling.
3196         * ppc-linux-tdep.c: Use C++ exception handling.
3197         * parse.c: Use C++ exception handling.
3198         * p-valprint.c: Use C++ exception handling.
3199         * objc-lang.c: Use C++ exception handling.
3200         * mi/mi-main.c: Use C++ exception handling.
3201         * mi/mi-interp.c: Use C++ exception handling.
3202         * mi/mi-cmd-stack.c: Use C++ exception handling.
3203         * mi/mi-cmd-break.c: Use C++ exception handling.
3204         * main.c: Use C++ exception handling.
3205         * linux-thread-db.c: Use C++ exception handling.
3206         * linux-tdep.c: Use C++ exception handling.
3207         * linux-nat.c: Use C++ exception handling.
3208         * linux-fork.c: Use C++ exception handling.
3209         * linespec.c: Use C++ exception handling.
3210         * language.c: Use C++ exception handling.
3211         * jit.c: Use C++ exception handling.
3212         * infrun.c: Use C++ exception handling.
3213         * infcmd.c: Use C++ exception handling.
3214         * infcall.c: Use C++ exception handling.
3215         * inf-loop.c: Use C++ exception handling.
3216         * i386-tdep.c: Use C++ exception handling.
3217         * i386-linux-tdep.c: Use C++ exception handling.
3218         * guile/scm-value.c: Use C++ exception handling.
3219         * guile/scm-type.c: Use C++ exception handling.
3220         * guile/scm-symtab.c: Use C++ exception handling.
3221         * guile/scm-symbol.c: Use C++ exception handling.
3222         * guile/scm-pretty-print.c: Use C++ exception handling.
3223         * guile/scm-ports.c: Use C++ exception handling.
3224         * guile/scm-param.c: Use C++ exception handling.
3225         * guile/scm-math.c: Use C++ exception handling.
3226         * guile/scm-lazy-string.c: Use C++ exception handling.
3227         * guile/scm-frame.c: Use C++ exception handling.
3228         * guile/scm-disasm.c: Use C++ exception handling.
3229         * guile/scm-cmd.c: Use C++ exception handling.
3230         * guile/scm-breakpoint.c: Use C++ exception handling.
3231         * guile/scm-block.c: Use C++ exception handling.
3232         * guile/guile-internal.h: Use C++ exception handling.
3233         * gnu-v3-abi.c: Use C++ exception handling.
3234         * gdbtypes.c: Use C++ exception handling.
3235         * frame.c: Use C++ exception handling.
3236         * frame-unwind.c: Use C++ exception handling.
3237         * fbsd-tdep.c: Use C++ exception handling.
3238         * f-valprint.c: Use C++ exception handling.
3239         * exec.c: Use C++ exception handling.
3240         * event-top.c: Use C++ exception handling.
3241         * event-loop.c: Use C++ exception handling.
3242         * eval.c: Use C++ exception handling.
3243         * dwarf2read.c: Use C++ exception handling.
3244         * dwarf2loc.c: Use C++ exception handling.
3245         * dwarf2-frame.c: Use C++ exception handling.
3246         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3247         * dwarf-index-write.c: Use C++ exception handling.
3248         * dwarf-index-cache.c: Use C++ exception handling.
3249         * dtrace-probe.c: Use C++ exception handling.
3250         * disasm-selftests.c: Use C++ exception handling.
3251         * darwin-nat.c: Use C++ exception handling.
3252         * cp-valprint.c: Use C++ exception handling.
3253         * cp-support.c: Use C++ exception handling.
3254         * cp-abi.c: Use C++ exception handling.
3255         * corelow.c: Use C++ exception handling.
3256         * completer.c: Use C++ exception handling.
3257         * compile/compile-object-run.c: Use C++ exception handling.
3258         * compile/compile-object-load.c: Use C++ exception handling.
3259         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3260         * compile/compile-c-symbols.c: Use C++ exception handling.
3261         * common/selftest.c: Use C++ exception handling.
3262         * common/new-op.c: Use C++ exception handling.
3263         * cli/cli-script.c: Use C++ exception handling.
3264         * cli/cli-interp.c: Use C++ exception handling.
3265         * cli/cli-cmds.c: Use C++ exception handling.
3266         * c-varobj.c: Use C++ exception handling.
3267         * btrace.c: Use C++ exception handling.
3268         * breakpoint.c: Use C++ exception handling.
3269         * break-catch-throw.c: Use C++ exception handling.
3270         * arch-utils.c: Use C++ exception handling.
3271         * amd64-tdep.c: Use C++ exception handling.
3272         * ada-valprint.c: Use C++ exception handling.
3273         * ada-typeprint.c: Use C++ exception handling.
3274         * ada-lang.c: Use C++ exception handling.
3275         * aarch64-tdep.c: Use C++ exception handling.
3276
3277 2019-04-08  Tom Tromey  <tom@tromey.com>
3278
3279         * xml-support.c (gdb_xml_parser::parse): Update.
3280         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3281         * value.c (show_convenience): Update.
3282         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3283         (test_parse_flags_qcs): Update.
3284         * thread.c (thr_try_catch_cmd): Update.
3285         * target.c (target_translate_tls_address): Update.
3286         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3287         (info_frame_command_core, frame_apply_command_count): Update.
3288         * rust-exp.y (rust_lex_exception_test): Update.
3289         * riscv-tdep.c (riscv_print_one_register_info): Update.
3290         * remote.c (remote_target::enable_btrace): Update.
3291         * record-btrace.c (record_btrace_enable_warn): Update.
3292         * python/py-utils.c (gdbpy_convert_exception): Update.
3293         * printcmd.c (do_one_display, print_variable_and_value): Update.
3294         * mi/mi-main.c (mi_print_exception): Update.
3295         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3296         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3297         * linux-nat.c (linux_nat_target::attach): Update.
3298         * linux-fork.c (class scoped_switch_fork_info): Update.
3299         * infrun.c (displaced_step_prepare): Update.
3300         * infcall.c (call_function_by_hand_dummy): Update.
3301         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3302         * gnu-v3-abi.c (print_one_vtable): Update.
3303         * frame.c (get_prev_frame_always): Update.
3304         * f-valprint.c (info_common_command_for_block): Update.
3305         * exec.c (try_open_exec_file): Update.
3306         * exceptions.c (print_exception, exception_print)
3307         (exception_fprintf, exception_print_same): Update.
3308         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3309         * dwarf-index-cache.c (index_cache::store)
3310         (index_cache::lookup_gdb_index): Update.
3311         * darwin-nat.c (maybe_cache_shell): Update.
3312         * cp-valprint.c (cp_print_value_fields): Update.
3313         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3314         (gcc_cplus_symbol_address): Update.
3315         * compile/compile-c-symbols.c (gcc_convert_symbol)
3316         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3317         * common/selftest.c: Update.
3318         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3319         a std::string.
3320         (exception_try_scope_entry, exception_try_scope_exit): Don't
3321         declare.
3322         (struct exception_try_scope): Remove.
3323         (TRY): Don't use exception_try_scope.
3324         (struct gdb_exception): Add constructor, operator=.
3325         <what>: New method.
3326         (struct gdb_exception_RETURN_MASK_ALL)
3327         (struct gdb_exception_RETURN_MASK_ERROR)
3328         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3329         (struct gdb_quit_bad_alloc): Update.
3330         * common/common-exceptions.c (exception_none): Change
3331         initializer.
3332         (struct catcher) <state, exception>: Initialize inline.
3333         <prev>: Remove member.
3334         (current_catcher): Remove.
3335         (catchers): New global.
3336         (exceptions_state_mc_init): Simplify.
3337         (catcher_pop): Remove.
3338         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3339         (try_scope_depth, exception_try_scope_entry)
3340         (exception_try_scope_exit): Remove.
3341         (throw_exception_sjlj): Update.
3342         (exception_messages, exception_messages_size): Remove.
3343         (throw_it): Simplify.
3344         (gdb_exception_sliced_copy): Remove.
3345         (throw_exception_cxx): Update.
3346         * cli/cli-script.c (script_from_file): Update.
3347         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3348         Update.
3349         * ada-valprint.c (ada_val_print): Update.
3350         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3351         (create_excep_cond_exprs): Update.
3352
3353 2019-04-08  Tom Tromey  <tom@tromey.com>
3354
3355         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3356         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3357         (TRY, CATCH, END_CATCH): Remove some definitions.
3358         * common/common-exceptions.c: Don't use GDB_XCPT.
3359         (catcher_list_size): Remove.
3360         (throw_exception, throw_it): Simplify.
3361
3362 2019-04-05  Tom Tromey  <tom@tromey.com>
3363
3364         Revert the header-sorting patch.
3365         * ft32-tdep.c: Revert.
3366         * frv-tdep.c: Revert.
3367         * frv-linux-tdep.c: Revert.
3368         * frame.c: Revert.
3369         * frame-unwind.c: Revert.
3370         * frame-base.c: Revert.
3371         * fork-child.c: Revert.
3372         * findvar.c: Revert.
3373         * findcmd.c: Revert.
3374         * filesystem.c: Revert.
3375         * filename-seen-cache.h: Revert.
3376         * filename-seen-cache.c: Revert.
3377         * fbsd-tdep.c: Revert.
3378         * fbsd-nat.h: Revert.
3379         * fbsd-nat.c: Revert.
3380         * f-valprint.c: Revert.
3381         * f-typeprint.c: Revert.
3382         * f-lang.c: Revert.
3383         * extension.h: Revert.
3384         * extension.c: Revert.
3385         * extension-priv.h: Revert.
3386         * expprint.c: Revert.
3387         * exec.h: Revert.
3388         * exec.c: Revert.
3389         * exceptions.c: Revert.
3390         * event-top.c: Revert.
3391         * event-loop.c: Revert.
3392         * eval.c: Revert.
3393         * elfread.c: Revert.
3394         * dwarf2read.h: Revert.
3395         * dwarf2read.c: Revert.
3396         * dwarf2loc.c: Revert.
3397         * dwarf2expr.h: Revert.
3398         * dwarf2expr.c: Revert.
3399         * dwarf2-frame.c: Revert.
3400         * dwarf2-frame-tailcall.c: Revert.
3401         * dwarf-index-write.h: Revert.
3402         * dwarf-index-write.c: Revert.
3403         * dwarf-index-common.c: Revert.
3404         * dwarf-index-cache.h: Revert.
3405         * dwarf-index-cache.c: Revert.
3406         * dummy-frame.c: Revert.
3407         * dtrace-probe.c: Revert.
3408         * disasm.h: Revert.
3409         * disasm.c: Revert.
3410         * disasm-selftests.c: Revert.
3411         * dictionary.c: Revert.
3412         * dicos-tdep.c: Revert.
3413         * demangle.c: Revert.
3414         * dcache.h: Revert.
3415         * dcache.c: Revert.
3416         * darwin-nat.h: Revert.
3417         * darwin-nat.c: Revert.
3418         * darwin-nat-info.c: Revert.
3419         * d-valprint.c: Revert.
3420         * d-namespace.c: Revert.
3421         * d-lang.c: Revert.
3422         * ctf.c: Revert.
3423         * csky-tdep.c: Revert.
3424         * csky-linux-tdep.c: Revert.
3425         * cris-tdep.c: Revert.
3426         * cris-linux-tdep.c: Revert.
3427         * cp-valprint.c: Revert.
3428         * cp-support.c: Revert.
3429         * cp-namespace.c: Revert.
3430         * cp-abi.c: Revert.
3431         * corelow.c: Revert.
3432         * corefile.c: Revert.
3433         * continuations.c: Revert.
3434         * completer.h: Revert.
3435         * completer.c: Revert.
3436         * complaints.c: Revert.
3437         * coffread.c: Revert.
3438         * coff-pe-read.c: Revert.
3439         * cli-out.h: Revert.
3440         * cli-out.c: Revert.
3441         * charset.c: Revert.
3442         * c-varobj.c: Revert.
3443         * c-valprint.c: Revert.
3444         * c-typeprint.c: Revert.
3445         * c-lang.c: Revert.
3446         * buildsym.c: Revert.
3447         * buildsym-legacy.c: Revert.
3448         * build-id.h: Revert.
3449         * build-id.c: Revert.
3450         * btrace.c: Revert.
3451         * bsd-uthread.c: Revert.
3452         * breakpoint.h: Revert.
3453         * breakpoint.c: Revert.
3454         * break-catch-throw.c: Revert.
3455         * break-catch-syscall.c: Revert.
3456         * break-catch-sig.c: Revert.
3457         * blockframe.c: Revert.
3458         * block.c: Revert.
3459         * bfin-tdep.c: Revert.
3460         * bfin-linux-tdep.c: Revert.
3461         * bfd-target.c: Revert.
3462         * bcache.c: Revert.
3463         * ax-general.c: Revert.
3464         * ax-gdb.h: Revert.
3465         * ax-gdb.c: Revert.
3466         * avr-tdep.c: Revert.
3467         * auxv.c: Revert.
3468         * auto-load.c: Revert.
3469         * arm-wince-tdep.c: Revert.
3470         * arm-tdep.c: Revert.
3471         * arm-symbian-tdep.c: Revert.
3472         * arm-pikeos-tdep.c: Revert.
3473         * arm-obsd-tdep.c: Revert.
3474         * arm-nbsd-tdep.c: Revert.
3475         * arm-nbsd-nat.c: Revert.
3476         * arm-linux-tdep.c: Revert.
3477         * arm-linux-nat.c: Revert.
3478         * arm-fbsd-tdep.c: Revert.
3479         * arm-fbsd-nat.c: Revert.
3480         * arm-bsd-tdep.c: Revert.
3481         * arch-utils.c: Revert.
3482         * arc-tdep.c: Revert.
3483         * arc-newlib-tdep.c: Revert.
3484         * annotate.h: Revert.
3485         * annotate.c: Revert.
3486         * amd64-windows-tdep.c: Revert.
3487         * amd64-windows-nat.c: Revert.
3488         * amd64-tdep.c: Revert.
3489         * amd64-sol2-tdep.c: Revert.
3490         * amd64-obsd-tdep.c: Revert.
3491         * amd64-obsd-nat.c: Revert.
3492         * amd64-nbsd-tdep.c: Revert.
3493         * amd64-nbsd-nat.c: Revert.
3494         * amd64-nat.c: Revert.
3495         * amd64-linux-tdep.c: Revert.
3496         * amd64-linux-nat.c: Revert.
3497         * amd64-fbsd-tdep.c: Revert.
3498         * amd64-fbsd-nat.c: Revert.
3499         * amd64-dicos-tdep.c: Revert.
3500         * amd64-darwin-tdep.c: Revert.
3501         * amd64-bsd-nat.c: Revert.
3502         * alpha-tdep.c: Revert.
3503         * alpha-obsd-tdep.c: Revert.
3504         * alpha-nbsd-tdep.c: Revert.
3505         * alpha-mdebug-tdep.c: Revert.
3506         * alpha-linux-tdep.c: Revert.
3507         * alpha-linux-nat.c: Revert.
3508         * alpha-bsd-tdep.c: Revert.
3509         * alpha-bsd-nat.c: Revert.
3510         * aix-thread.c: Revert.
3511         * agent.c: Revert.
3512         * addrmap.c: Revert.
3513         * ada-varobj.c: Revert.
3514         * ada-valprint.c: Revert.
3515         * ada-typeprint.c: Revert.
3516         * ada-tasks.c: Revert.
3517         * ada-lang.c: Revert.
3518         * aarch64-tdep.c: Revert.
3519         * aarch64-ravenscar-thread.c: Revert.
3520         * aarch64-newlib-tdep.c: Revert.
3521         * aarch64-linux-tdep.c: Revert.
3522         * aarch64-linux-nat.c: Revert.
3523         * aarch64-fbsd-tdep.c: Revert.
3524         * aarch64-fbsd-nat.c: Revert.
3525         * aarch32-linux-nat.c: Revert.
3526
3527 2019-04-05  Tom Tromey  <tom@tromey.com>
3528
3529         * ft32-tdep.c: Sort headers.
3530         * frv-tdep.c: Sort headers.
3531         * frv-linux-tdep.c: Sort headers.
3532         * frame.c: Sort headers.
3533         * frame-unwind.c: Sort headers.
3534         * frame-base.c: Sort headers.
3535         * fork-child.c: Sort headers.
3536         * findvar.c: Sort headers.
3537         * findcmd.c: Sort headers.
3538         * filesystem.c: Sort headers.
3539         * filename-seen-cache.h: Sort headers.
3540         * filename-seen-cache.c: Sort headers.
3541         * fbsd-tdep.c: Sort headers.
3542         * fbsd-nat.h: Sort headers.
3543         * fbsd-nat.c: Sort headers.
3544         * f-valprint.c: Sort headers.
3545         * f-typeprint.c: Sort headers.
3546         * f-lang.c: Sort headers.
3547         * extension.h: Sort headers.
3548         * extension.c: Sort headers.
3549         * extension-priv.h: Sort headers.
3550         * expprint.c: Sort headers.
3551         * exec.h: Sort headers.
3552         * exec.c: Sort headers.
3553         * exceptions.c: Sort headers.
3554         * event-top.c: Sort headers.
3555         * event-loop.c: Sort headers.
3556         * eval.c: Sort headers.
3557         * elfread.c: Sort headers.
3558         * dwarf2read.h: Sort headers.
3559         * dwarf2read.c: Sort headers.
3560         * dwarf2loc.c: Sort headers.
3561         * dwarf2expr.h: Sort headers.
3562         * dwarf2expr.c: Sort headers.
3563         * dwarf2-frame.c: Sort headers.
3564         * dwarf2-frame-tailcall.c: Sort headers.
3565         * dwarf-index-write.h: Sort headers.
3566         * dwarf-index-write.c: Sort headers.
3567         * dwarf-index-common.c: Sort headers.
3568         * dwarf-index-cache.h: Sort headers.
3569         * dwarf-index-cache.c: Sort headers.
3570         * dummy-frame.c: Sort headers.
3571         * dtrace-probe.c: Sort headers.
3572         * disasm.h: Sort headers.
3573         * disasm.c: Sort headers.
3574         * disasm-selftests.c: Sort headers.
3575         * dictionary.c: Sort headers.
3576         * dicos-tdep.c: Sort headers.
3577         * demangle.c: Sort headers.
3578         * dcache.h: Sort headers.
3579         * dcache.c: Sort headers.
3580         * darwin-nat.h: Sort headers.
3581         * darwin-nat.c: Sort headers.
3582         * darwin-nat-info.c: Sort headers.
3583         * d-valprint.c: Sort headers.
3584         * d-namespace.c: Sort headers.
3585         * d-lang.c: Sort headers.
3586         * ctf.c: Sort headers.
3587         * csky-tdep.c: Sort headers.
3588         * csky-linux-tdep.c: Sort headers.
3589         * cris-tdep.c: Sort headers.
3590         * cris-linux-tdep.c: Sort headers.
3591         * cp-valprint.c: Sort headers.
3592         * cp-support.c: Sort headers.
3593         * cp-namespace.c: Sort headers.
3594         * cp-abi.c: Sort headers.
3595         * corelow.c: Sort headers.
3596         * corefile.c: Sort headers.
3597         * continuations.c: Sort headers.
3598         * completer.h: Sort headers.
3599         * completer.c: Sort headers.
3600         * complaints.c: Sort headers.
3601         * coffread.c: Sort headers.
3602         * coff-pe-read.c: Sort headers.
3603         * cli-out.h: Sort headers.
3604         * cli-out.c: Sort headers.
3605         * charset.c: Sort headers.
3606         * c-varobj.c: Sort headers.
3607         * c-valprint.c: Sort headers.
3608         * c-typeprint.c: Sort headers.
3609         * c-lang.c: Sort headers.
3610         * buildsym.c: Sort headers.
3611         * buildsym-legacy.c: Sort headers.
3612         * build-id.h: Sort headers.
3613         * build-id.c: Sort headers.
3614         * btrace.c: Sort headers.
3615         * bsd-uthread.c: Sort headers.
3616         * breakpoint.h: Sort headers.
3617         * breakpoint.c: Sort headers.
3618         * break-catch-throw.c: Sort headers.
3619         * break-catch-syscall.c: Sort headers.
3620         * break-catch-sig.c: Sort headers.
3621         * blockframe.c: Sort headers.
3622         * block.c: Sort headers.
3623         * bfin-tdep.c: Sort headers.
3624         * bfin-linux-tdep.c: Sort headers.
3625         * bfd-target.c: Sort headers.
3626         * bcache.c: Sort headers.
3627         * ax-general.c: Sort headers.
3628         * ax-gdb.h: Sort headers.
3629         * ax-gdb.c: Sort headers.
3630         * avr-tdep.c: Sort headers.
3631         * auxv.c: Sort headers.
3632         * auto-load.c: Sort headers.
3633         * arm-wince-tdep.c: Sort headers.
3634         * arm-tdep.c: Sort headers.
3635         * arm-symbian-tdep.c: Sort headers.
3636         * arm-pikeos-tdep.c: Sort headers.
3637         * arm-obsd-tdep.c: Sort headers.
3638         * arm-nbsd-tdep.c: Sort headers.
3639         * arm-nbsd-nat.c: Sort headers.
3640         * arm-linux-tdep.c: Sort headers.
3641         * arm-linux-nat.c: Sort headers.
3642         * arm-fbsd-tdep.c: Sort headers.
3643         * arm-fbsd-nat.c: Sort headers.
3644         * arm-bsd-tdep.c: Sort headers.
3645         * arch-utils.c: Sort headers.
3646         * arc-tdep.c: Sort headers.
3647         * arc-newlib-tdep.c: Sort headers.
3648         * annotate.h: Sort headers.
3649         * annotate.c: Sort headers.
3650         * amd64-windows-tdep.c: Sort headers.
3651         * amd64-windows-nat.c: Sort headers.
3652         * amd64-tdep.c: Sort headers.
3653         * amd64-sol2-tdep.c: Sort headers.
3654         * amd64-obsd-tdep.c: Sort headers.
3655         * amd64-obsd-nat.c: Sort headers.
3656         * amd64-nbsd-tdep.c: Sort headers.
3657         * amd64-nbsd-nat.c: Sort headers.
3658         * amd64-nat.c: Sort headers.
3659         * amd64-linux-tdep.c: Sort headers.
3660         * amd64-linux-nat.c: Sort headers.
3661         * amd64-fbsd-tdep.c: Sort headers.
3662         * amd64-fbsd-nat.c: Sort headers.
3663         * amd64-dicos-tdep.c: Sort headers.
3664         * amd64-darwin-tdep.c: Sort headers.
3665         * amd64-bsd-nat.c: Sort headers.
3666         * alpha-tdep.c: Sort headers.
3667         * alpha-obsd-tdep.c: Sort headers.
3668         * alpha-nbsd-tdep.c: Sort headers.
3669         * alpha-mdebug-tdep.c: Sort headers.
3670         * alpha-linux-tdep.c: Sort headers.
3671         * alpha-linux-nat.c: Sort headers.
3672         * alpha-bsd-tdep.c: Sort headers.
3673         * alpha-bsd-nat.c: Sort headers.
3674         * aix-thread.c: Sort headers.
3675         * agent.c: Sort headers.
3676         * addrmap.c: Sort headers.
3677         * ada-varobj.c: Sort headers.
3678         * ada-valprint.c: Sort headers.
3679         * ada-typeprint.c: Sort headers.
3680         * ada-tasks.c: Sort headers.
3681         * ada-lang.c: Sort headers.
3682         * aarch64-tdep.c: Sort headers.
3683         * aarch64-ravenscar-thread.c: Sort headers.
3684         * aarch64-newlib-tdep.c: Sort headers.
3685         * aarch64-linux-tdep.c: Sort headers.
3686         * aarch64-linux-nat.c: Sort headers.
3687         * aarch64-fbsd-tdep.c: Sort headers.
3688         * aarch64-fbsd-nat.c: Sort headers.
3689         * aarch32-linux-nat.c: Sort headers.
3690
3691 2019-04-04  Tom Tromey  <tom@tromey.com>
3692
3693         * varobj.c (varobj_create): Update.
3694         * rust-exp.y (struct rust_parser) <update_innermost_block,
3695         lookup_symbol>: New methods.
3696         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3697         Rename.
3698         (rust_parser::rust_lookup_type)
3699         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3700         * printcmd.c (display_command, do_one_display): Update.
3701         * parser-defs.h (struct parser_state) <parser_state>: Add
3702         "tracker" parameter.
3703         (block_tracker): New member.
3704         (class innermost_block_tracker) <innermost_block_tracker>: Add
3705         "types" parameter.
3706         <reset>: Remove method.
3707         (innermost_block): Don't declare.
3708         (null_post_parser): Update.
3709         * parse.c (innermost_block): Remove global.
3710         (write_dollar_variable): Update.
3711         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3712         Remove "tracker_types" parameter.
3713         (parse_expression): Add "tracker" parameter.
3714         (parse_expression_for_completion): Update.
3715         (null_post_parser): Add "tracker" parameter.
3716         * p-exp.y: Update rules.
3717         * m2-exp.y: Update rules.
3718         * language.h (struct language_defn) <la_post_parser>: Add
3719         "tracker" parameter.
3720         * go-exp.y: Update rules.
3721         * f-exp.y: Update rules.
3722         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3723         parameter.
3724         * d-exp.y: Update rules.
3725         * c-exp.y: Update rules.
3726         * breakpoint.c (set_breakpoint_condition): Create an
3727         innermost_block_tracker.
3728         (watch_command_1): Likewise.
3729         * ada-lang.c (resolve): Add "tracker" parameter.
3730         (resolve_subexp): Likewise.
3731         * ada-exp.y (write_var_from_sym): Update.
3732
3733 2019-04-04  Tom Tromey  <tom@tromey.com>
3734
3735         * type-stack.h: New file.
3736         * type-stack.c: New file.
3737         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3738         type-stack.h.
3739         (insert_into_type_stack, insert_type, push_type, push_type_int)
3740         (insert_type_address_space, pop_type, pop_type_int)
3741         (pop_typelist, pop_type_stack, append_type_stack)
3742         (push_type_stack, get_type_stack, push_typelist)
3743         (follow_type_instance_flags, follow_types): Don't declare.
3744         * parse.c (type_stack): Remove global.
3745         (parse_exp_in_context): Update.
3746         (insert_into_type_stack, insert_type, push_type, push_type_int)
3747         (insert_type_address_space, pop_type, pop_type_int)
3748         (pop_typelist, pop_type_stack, append_type_stack)
3749         (push_type_stack, get_type_stack, push_typelist)
3750         (follow_type_instance_flags, follow_types): Remove (moved to
3751         type-stack.c).
3752         * f-exp.y (type_stack): New global.
3753         Update rules.
3754         (push_kind_type, f_parse): Update.
3755         * d-exp.y (type_stack): New global.
3756         Update rules.
3757         (d_parse): Update.
3758         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3759         Update rules.
3760         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3761         (HFILES_NO_SRCDIR): Add type-stack.h.
3762
3763 2019-04-04  Tom Tromey  <tom@tromey.com>
3764
3765         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3766         (rust_parser::convert_ast_to_expression, rust_parse)
3767         (rust_lex_test_completion, rust_lex_tests): Update.
3768         * parser-defs.h (struct expr_completion_state): New.
3769         (struct parser_state) <parser_state>: Add completion parameter.
3770         <mark_struct_expression, mark_completion_tag>: New methods.
3771         <parse_completion, m_completion_state>: New members.
3772         (prefixify_expression, null_post_parser): Update.
3773         (mark_struct_expression, mark_completion_tag): Don't declare.
3774         * parse.c (parse_completion, expout_last_struct)
3775         (expout_tag_completion_type, expout_completion_name): Remove
3776         globals.
3777         (parser_state::mark_struct_expression)
3778         (parser_state::mark_completion_tag): Now methods.
3779         (prefixify_expression): Add last_struct parameter.
3780         (prefixify_subexp): Likewise.
3781         (parse_exp_1): Update.
3782         (parse_exp_in_context): Add cstate parameter.  Update.
3783         (parse_expression_for_completion): Create an
3784         expr_completion_state.
3785         (null_post_parser): Add "completion" parameter.
3786         * p-exp.y: Update rules.
3787         (yylex): Update.
3788         * language.h (struct language_defn) <la_post_parser>: Add
3789         "completing" parameter.
3790         * go-exp.y: Update rules.
3791         (lex_one_token): Update.
3792         * expression.h (parse_completion): Don't declare.
3793         * d-exp.y: Update rules.
3794         (lex_one_token): Update rules.
3795         * c-exp.y: Update rules.
3796         (lex_one_token): Update.
3797         * ada-lang.c (resolve): Add "parse_completion" parameter.
3798         (resolve_subexp): Likewise.
3799         (ada_resolve_function): Likewise.
3800
3801 2019-04-04  Tom Tromey  <tom@tromey.com>
3802
3803         * parser-defs.h (struct parser_state) <start_arglist,
3804         end_arglist>: New methods.
3805         <arglist_len, m_funcall_chain>: New members.
3806         (arglist_len, start_arglist, end_arglist): Don't declare.
3807         * parse.c (arglist_len, funcall_chain): Remove global.
3808         (start_arglist, end_arglist): Remove functions.
3809         (parse_exp_in_context): Update.
3810         * p-exp.y: Update rules.
3811         * m2-exp.y: Update rules.
3812         * go-exp.y: Update rules.
3813         * f-exp.y: Update rules.
3814         * d-exp.y: Update rules.
3815         * c-exp.y: Update rules.
3816
3817 2019-04-04  Tom Tromey  <tom@tromey.com>
3818
3819         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3820         lex_operator, push_back>: New methods.
3821         Update all rules.
3822         (rust_parser::lex_hex, lex_escape): Rename and update.
3823         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3824         (rust_parser::lex_operator): Rename and update.
3825         (rust_parser::lex_number, rustyylex, rustyyerror)
3826         (rust_lex_test_init, rust_lex_test_sequence)
3827         (rust_lex_test_push_back, rust_lex_tests): Update.
3828         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3829         parameter.
3830         <lexptr, prev_lexptr>: New members.
3831         (lexptr, prev_lexptr): Don't declare.
3832         * parse.c (lexptr, prev_lexptr): Remove globals.
3833         (parse_exp_in_context): Update.
3834         * p-exp.y (yylex, yyerror): Update.
3835         * m2-exp.y (parse_number, yylex, yyerror): Update.
3836         * go-exp.y (lex_one_token, yyerror): Update.
3837         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3838         * d-exp.y (lex_one_token, yyerror): Update.
3839         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3840         (lex_one_token, yyerror): Update.
3841         * ada-lex.l (YY_INPUT): Update.
3842         (rewind_to_char): Update.
3843         * ada-exp.y (yyerror): Update.
3844
3845 2019-04-04  Tom Tromey  <tom@tromey.com>
3846
3847         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3848         * parser-defs.h (struct parser_state) <parser_state>: Add new
3849         parameter.
3850         <comma_terminates>: New member.
3851         (comma_terminates): Don't declare global.
3852         * parse.c (comma_terminates): Remove global.
3853         (parse_exp_in_context): Update.
3854         * p-exp.y (yylex): Update.
3855         * m2-exp.y (yylex): Update.
3856         * go-exp.y (lex_one_token): Update.
3857         * f-exp.y (yylex): Update.
3858         * d-exp.y (lex_one_token): Update.
3859         * c-exp.y (lex_one_token): Update.
3860         * ada-lex.l: Update.
3861
3862 2019-04-04  Tom Tromey  <tom@tromey.com>
3863
3864         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3865         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3866         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3867         * parser-defs.h (paren_depth): Don't declare.
3868         * parse.c (paren_depth): Remove global.
3869         (parse_exp_in_context): Update.
3870         * p-exp.y (paren_depth): New global.
3871         (pascal_parse): Initialize it.
3872         * m2-exp.y (paren_depth): New global.
3873         (m2_parse): Initialize it.
3874         * go-exp.y (paren_depth): New global.
3875         (go_parse): Initialize it.
3876         * f-exp.y (paren_depth): New global.
3877         (f_parse): Initialize it.
3878         * d-exp.y (paren_depth): New global.
3879         (d_parse): Initialize it.
3880         * c-exp.y (paren_depth): New global.
3881         (c_parse): Initialize it.
3882         * ada-lex.l (paren_depth): New global.
3883         (lexer_init): Initialize it.
3884
3885 2019-04-04  Tom Tromey  <tom@tromey.com>
3886
3887         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3888         (rust_parser::convert_ast_to_type)
3889         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3890         * parser-defs.h (struct parser_state) <parser_state>: Add
3891         parameters.  Initialize new members.
3892         <expression_context_block, expression_context_pc>: New members.
3893         * parse.c (expression_context_block, expression_context_pc):
3894         Remove globals.
3895         (parse_exp_in_context): Update.
3896         * p-exp.y: Update all rules.
3897         (yylex): Update.
3898         * m2-exp.y: Update all rules.
3899         (yylex): Update.
3900         * go-exp.y (yylex): Update.
3901         * f-exp.y (yylex): Update.
3902         * d-exp.y: Update all rules.
3903         (yylex): Update.
3904         * c-exp.y: Update all rules.
3905         (lex_one_token, classify_name, yylex, c_parse): Update.
3906         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3907
3908 2019-04-04  Tom Tromey  <tom@tromey.com>
3909
3910         * gdbarch.h, gdbarch.c: Rebuild.
3911         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3912         * stap-probe.h:
3913         (struct stap_parse_info): Replace "parser_state" with
3914         "expr_builder".
3915         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3916         (parser_state): New class.
3917         * parse.c (expr_builder): Rename.
3918         (expr_builder::release): Rename.
3919         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3920         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3921         (write_exp_elt_longcst, write_exp_elt_floatcst)
3922         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3923         (write_exp_string_vector, write_exp_bitstring)
3924         (write_exp_msymbol, mark_struct_expression)
3925         (write_dollar_variable)
3926         (insert_type_address_space, increase_expout_size): Replace
3927         "parser_state" with "expr_builder".
3928         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3929         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3930         "parser_state" with "expr_builder".
3931
3932 2019-04-04  Tom Tromey  <tom@tromey.com>
3933
3934         * rust-exp.y: Replace "parse_language" with method call.
3935         * p-exp.y:
3936         (yylex): Replace "parse_language" with method call.
3937         * m2-exp.y:
3938         (yylex): Replace "parse_language" with method call.
3939         * go-exp.y (classify_name): Replace "parse_language" with method
3940         call.
3941         * f-exp.y (yylex): Replace "parse_language" with method call.
3942         * d-exp.y (lex_one_token): Replace "parse_language" with method
3943         call.
3944         * c-exp.y:
3945         (lex_one_token, classify_name, yylex): Replace "parse_language"
3946         with method call.
3947         * ada-exp.y (find_primitive_type, type_char)
3948         (type_system_address): Replace "parse_language" with method call.
3949
3950 2019-04-04  Tom Tromey  <tom@tromey.com>
3951
3952         * rust-exp.y: Replace "parse_gdbarch" with method call.
3953         * parse.c (write_dollar_variable, insert_type_address_space):
3954         Replace "parse_gdbarch" with method call.
3955         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3956         call.
3957         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3958         call.
3959         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3960         "parse_gdbarch" with method call.
3961         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3962         with method call.
3963         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3964         "parse_gdbarch" with method call.
3965         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3966         "parse_gdbarch" with method call.
3967         * c-exp.y (parse_type, parse_number, classify_name): Replace
3968         "parse_gdbarch" with method call.
3969         * ada-lex.l: Replace "parse_gdbarch" with method call.
3970         * ada-exp.y (parse_type, find_primitive_type, type_char)
3971         (type_system_address): Replace "parse_gdbarch" with method call.
3972
3973 2019-04-04  Tom Tromey  <tom@tromey.com>
3974
3975         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3976         * stap-probe.c (stap_parse_argument): Update.
3977         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3978         initial_size parameter.
3979         * rust-exp.y (rust_lex_tests): Update.
3980         * parse.c (parser_state): Update.
3981         (parse_exp_in_context): Update.
3982         * parser-defs.h (struct parser_state) <parser_state>: Remove
3983         "initial_size" parameter.
3984
3985 2019-04-04  Tom Tromey  <tom@tromey.com>
3986
3987         * parser-defs.h (increase_expout_size): Don't declare.
3988         * parse.c (increase_expout_size): Now static.
3989
3990 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3991
3992         * gnu-nat.c (gnu_nat_target::wait): Fix
3993         target_waitstatus_to_string call.
3994
3995 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3996
3997         * eval.c (evaluate_subexp_standard): Handle internal functions
3998         during Fortran function call handling.
3999
4000 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4001
4002         * NEWS: Mention new internal functions.
4003         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4004         (read_base_type): Use dwarf2_init_complex_target_type.
4005         * value.c (creal_internal_fn): New function.
4006         (cimag_internal_fn): New function.
4007         (_initialize_values): Register new internal functions.
4008
4009 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4010
4011         * infrun.c (stop_all_threads): If debug_infrun, always
4012         trace the wait status after wait_one, using
4013         target_waitstatus_to_string and target_pid_to_str.
4014         (handle_inferior_event): Replace various trace of
4015         wait status kind by a single trace.
4016         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4017         wait status kind image by target_waitstatus_to_string.
4018         * target/waitstatus.c (target_waitstatus_to_string): Fix
4019         obsolete comment.
4020
4021 2019-04-01  Tom Tromey  <tromey@adacore.com>
4022
4023         PR symtab/23331:
4024         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4025
4026 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4027             Pedro Alves  <palves@redhat.com>
4028
4029         * top.c (quit_force): Call 'finalize_values'.
4030         * value.c (finalize_values): New function.
4031         * value.h (finalize_values): Declare.
4032
4033 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4034
4035         * NEWS: Announce $_gdb_major and $_gdb_minor.
4036
4037         * top.c (init_gdb_version_vars): New function.
4038         (gdb_init): Call init_gdb_version_vars.
4039
4040 2019-03-29  Tom Tromey  <tromey@adacore.com>
4041
4042         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4043         help text.  Remove dead code.
4044
4045 2019-03-29  Keith Seitz  <keiths@redhat.com>
4046
4047         From Siddhesh Poyarekar:
4048         * f-lang.h (f77_get_upperbound): Return LONGEST.
4049         (f77_get_lowerbound): Likewise.
4050         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4051         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4052         print them.
4053         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4054         plongest to format print it.
4055         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4056         (f77_get_upperbound): Likewise.
4057         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4058         LOWER_BOUND to LONGEST.
4059         (f77_create_arrayprint_offset_tbl): Likewise.
4060
4061 2019-03-29  Keith Seitz  <keiths@redhat.com>
4062
4063         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4064         %s/pulongest for TYPE_LENGTH instead of %d in format
4065         strings.
4066         * ada-typerint.c (ada_print_type): Likewise.
4067         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4068         * compile/compile-c-support.c (generate_register_struct): Likewise.
4069         * gdbtypes.c (recursive_dump_type): Likewise.
4070         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4071         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4072         instead of %d in format strings.
4073         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4074         to std::min to ULONGEST.
4075         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4076         instead of %d in format strings.
4077         * tracepoint.c (info_scope_command): Likewise.
4078         * typeprint.c (print_offset_data::update)
4079         (print_offset_data::finish): Likewise.
4080         * xtensa-tdep.c (xtensa_store_return_value)
4081         (xtensa_push_dummy_call): Likewise.
4082
4083 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4084
4085         * windows-nat.c (display_selector): Fixed format specifications
4086         for 64-bit Cygwin.
4087
4088 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4089
4090         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4091
4092 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4093
4094         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4095         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4096         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4097         (nios2_linux_init_abi): Install it.
4098
4099 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4100
4101         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4102
4103 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4104
4105         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4106
4107 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4108             Tom Tromey  <tromey@adacore.com>
4109
4110         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4111
4112 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4113
4114         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4115         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4116         method to compute the bounds of range types. Also print "[evaluated]"
4117         if the bounds' values come from a dynamic evaluation.
4118
4119 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4120
4121         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4122         whitespace when pretty printing is on.
4123
4124 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4125
4126         * ppc-linux-nat.c: Add include.
4127
4128 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4129
4130         * NEWS: Mention AArch64 Pointer Authentication.
4131
4132 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4133
4134         * arm-linux-nat.c: Add include.
4135
4136 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4137
4138         * source-cache.c (source_cache::get_source_lines): Re-read
4139         fullname after calling open_source_file.
4140
4141 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4142
4143         * NEWS: Mention TLS support for FreeBSD.
4144
4145 2019-03-25  Tom Tromey  <tromey@adacore.com>
4146
4147         * minsyms.c (BUNCH_SIZE): Update comment.
4148         (~minimal_symbol_reader): Remove old comment.
4149         (compact_minimal_symbols): Update comment.
4150         (minimal_symbol_reader::install): Remove old comment.  Update
4151         other comments.
4152
4153 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4154
4155         * s390-linux-nat.c: Add include.
4156
4157 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4158
4159         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4160         Call linux_get_hwcap.
4161         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4162         Likewise.
4163         (aarch64_linux_get_hwcap): Remove function.
4164         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4165         declaration.
4166         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4167         linux_get_hwcap.
4168         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4169         * linux-tdep.c (linux_get_hwcap): Add function.
4170         (linux_get_hwcap2): Likewise.
4171         * linux-tdep.h (linux_get_hwcap): Add declaration.
4172         (linux_get_hwcap2): Likewise.
4173         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4174         (ppc_linux_get_hwcap2): Likewise.
4175         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4176         linux_get_hwcap.
4177         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4178         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4179         (ppc_linux_nat_target::read_description): Likewise.
4180         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4181         * s390-linux-nat.c: Likewise.
4182         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4183
4184 2019-03-24  Tom Tromey  <tom@tromey.com>
4185
4186         * ada-lang.c (standard_lookup): Simplify initialization.
4187         (ada_lookup_symbol_nonlocal): Simplify return.
4188         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4189         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4190         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4191         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4192         initialization.
4193         * solib.c (solib_global_lookup): Simplify.
4194         * symtab.c (null_block_symbol): Remove.
4195         (symbol_cache_lookup): Simplify returns.
4196         (lookup_language_this): Simplify returns.
4197         (lookup_symbol_aux): Simplify return.
4198         (lookup_local_symbol): Simplify returns.
4199         (lookup_global_symbol_from_objfile): Simplify return.
4200         (lookup_symbol_in_objfile_symtabs)
4201         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4202         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4203         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4204         * cp-namespace.c (cp_lookup_bare_symbol)
4205         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4206         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4207         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4208         (cp_lookup_symbol_via_imports): Simplify initialization.
4209         (find_symbol_in_baseclass): Likewise.
4210         * symtab.h (null_block_symbol): Remove.
4211         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4212         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4213         (d_lookup_symbol_module): Likewise.
4214         (find_symbol_in_baseclass): Simplify initialization.
4215
4216 2019-03-24  Tom Tromey  <tom@tromey.com>
4217
4218         * expression.h: Don't include symtab.h.
4219         (struct block): Forward declare.
4220
4221 2019-03-24  Tom Tromey  <tom@tromey.com>
4222
4223         * c-exp.y (typebase): Remove casts.
4224         * gdbtypes.c (lookup_unsigned_typename, )
4225         (lookup_signed_typename): Remove cast.
4226         * eval.c (parse_to_comma_and_eval): Remove cast.
4227         * parse.c (write_dollar_variable): Remove cast.
4228         * block.h (struct block) <superblock>: Now const.
4229         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4230         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4231         (map_block): Make "block" const.
4232         * symfile.h (struct quick_symbol_functions)
4233         <map_matching_symbols>: Constify block argument to "callback".
4234         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4235         const.
4236         (find_pc_sect_compunit_symtab): Make "b" const.
4237         (find_symbol_at_address): Likewise.
4238         (search_symbols): Likewise.
4239         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4240         (dw2_debug_names_lookup_symbol): Likewise.
4241         (dw2_map_matching_symbols): Update.
4242         * p-valprint.c (pascal_val_print): Remove "block".
4243         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4244         (aux_add_nonlocal_symbols): Make "block" const.
4245         (resolve_subexp): Remove cast.
4246         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4247         const.
4248         (iterate_over_file_blocks): Likewise.
4249         * f-exp.y (%union) <bval>: Remove.
4250         * coffread.c (patch_opaque_types): Make "b" const.
4251         * spu-tdep.c (spu_catch_start): Make "block" const.
4252         * c-valprint.c (print_unpacked_pointer): Remove "block".
4253         * symmisc.c (dump_symtab_1): Make "b" const.
4254         (block_depth): Make "block" const.
4255         * d-exp.y (%union) <bval>: Remove.
4256         * cp-support.h (cp_lookup_rtti_type): Update.
4257         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4258         * psymtab.c (psym_lookup_symbol): Make "block" const.
4259         (maintenance_check_psymtabs): Make "b" const.
4260         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4261         (enumerate_locals, enumerate_args): Update.
4262         * python/py-symtab.c (stpy_global_block): Make "block" const.
4263         (stpy_static_block): Likewise.
4264         * inline-frame.c (block_starting_point_at): Make "new_block"
4265         const.
4266         * block.c (find_block_in_blockvector): Make return type const.
4267         (blockvector_for_pc_sect): Make "b" const.
4268         (find_block_in_blockvector): Make "b" const.
4269
4270 2019-03-23  Tom Tromey  <tom@tromey.com>
4271
4272         * varobj.c (varobj_create): Update.
4273         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4274         * printcmd.c (display_command, do_one_display): Don't reset
4275         innermost_block.
4276         * parser-defs.h (enum innermost_block_tracker_type): Move to
4277         expression.h.
4278         (innermost_block): Update comment.
4279         * parse.c (parse_exp_1): Add tracker_types parameter.
4280         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4281         tracker_types parameter.  Reset innermost_block.
4282         (parse_exp_in_context): Remove.
4283         (parse_expression_for_completion): Update.
4284         * objfiles.c (~objfile): Don't reset expression_context_block or
4285         innermost_block.
4286         * expression.h (enum innermost_block_tracker_type): Move from
4287         parser-defs.h.
4288         (parse_exp_1): Add tracker_types parameter.
4289         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4290         reset innermost_block.
4291
4292 2019-03-23  Tom Tromey  <tom@tromey.com>
4293
4294         * objfiles.h: Include bcache.h.
4295
4296 2019-03-23  Tom Tromey  <tom@tromey.com>
4297
4298         * linespec.c (get_current_search_block): Use
4299         scoped_restore_current_language.
4300         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4301
4302 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4303             Jiong Wang  <jiong.wang@arm.com>
4304
4305         * aarch64-linux-tdep.c
4306         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4307         section.
4308         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4309
4310 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4311             Jiong Wang  <jiong.wang@arm.com>
4312
4313         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4314         instructions.
4315         (aarch64_analyze_prologue_test): Add PACIASP test.
4316         (aarch64_prologue_prev_register): Unmask PC value.
4317
4318 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4319             Jiong Wang  <jiong.wang@arm.com>
4320
4321         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4322         (aarch64_dwarf2_prev_register): Unmask PC value.
4323         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4324         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4325         DW_CFA_AARCH64_negate_ra_state.
4326         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4327
4328 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4329             Jiong Wang  <jiong.wang@arm.com>
4330
4331         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4332         registers.
4333         (aarch64_pseudo_register_name): Likewise.
4334         (aarch64_pseudo_register_type): Likewise.
4335         (aarch64_pseudo_register_reggroup_p): Likewise.
4336         (aarch64_gdbarch_init): Add pauth registers.
4337         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4338         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4339         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4340         (struct gdbarch_tdep): Add regnum for ra_state.
4341
4342 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4343             Jiong Wang  <jiong.wang@arm.com>
4344
4345         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4346
4347 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4348             Jiong Wang  <jiong.wang@arm.com>
4349
4350         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4351         function.
4352         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4353         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4354         (aarch64_gdbarch_init): Add puth registers.
4355         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4356         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4357         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4358
4359 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4360             Jiong Wang  <jiong.wang@arm.com>
4361
4362         * aarch64-linux-nat.c
4363         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4364         * aarch64-linux-tdep.c
4365         (aarch64_linux_core_read_description): Likewise.
4366         (aarch64_linux_get_hwcap): New function.
4367         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4368         (aarch64_linux_get_hwcap): New declaration.
4369
4370 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4371             Jiong Wang  <jiong.wang@arm.com>
4372
4373         * aarch64-linux-nat.c
4374         (aarch64_linux_nat_target::read_description): Add pauth param.
4375         * aarch64-linux-tdep.c
4376         (aarch64_linux_core_read_description): Likewise.
4377         * aarch64-tdep.c (struct target_desc): Add in pauth.
4378         (aarch64_read_description): Add pauth param.
4379         (aarch64_gdbarch_init): Likewise.
4380         * aarch64-tdep.h (aarch64_read_description): Likewise.
4381         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4382         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4383         * features/Makefile: Add new files.
4384         * features/aarch64-pauth.c: New file.
4385         * features/aarch64-pauth.xml: New file.
4386
4387 2019-03-20  Tom Tromey  <tromey@adacore.com>
4388
4389         * infrun.c (handle_inferior_event): Rename from
4390         handle_inferior_event_1.  Create a scoped_value_mark.
4391         (handle_inferior_event): Remove.
4392
4393 2019-03-19  Tom Tromey  <tromey@adacore.com>
4394
4395         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4396         * infrun.h (print_stop_event): Add "displays" parameter.
4397         * infrun.c (print_stop_event): Add "displays" parameter.
4398
4399 2019-03-19  Pedro Alves  <palves@redhat.com>
4400
4401         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4402         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4403         to -1.  Fix TABs vs spaces.
4404         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4405         * tui/tui-out.h (tui_ui_out) Add intro comments.
4406         <m_line, m_start_of_line>: In-class initialize, and add describing
4407         comment.
4408
4409 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4410
4411         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4412         variable names.
4413         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4414
4415 2019-03-18  Pedro Alves  <palves@redhat.com>
4416             Eli Zaretskii <eliz@gnu.org>
4417
4418         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4419         m_line and m_start_of_line.
4420
4421 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4422
4423         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4424         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4425         it returns a newline.  This fixes a regression in TU mode, whereby
4426         the next line is output on the same screen line as the user input.
4427
4428 2019-03-18  Tom Tromey  <tromey@adacore.com>
4429
4430         * minsyms.c (minimal_symbol_reader::install): Remove call to
4431         obstack_blank.
4432
4433 2019-03-18  Pedro Alves  <palves@redhat.com>
4434
4435         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4436         New globals.
4437         (apply_style): New, factored out from ...
4438         (apply_ansi_escape): ... this.  Handle reverse video mode.
4439         (tui_set_reverse_mode): New function.
4440         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4441         * tui/tui-winsource.c (tui_show_source_line): Use
4442         tui_set_reverse_mode instead of setting A_STANDOUT.
4443         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4444         New setter methods.
4445
4446 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4447
4448         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4449         Handle tabs.
4450
4451 2019-03-18  Tom Tromey  <tromey@adacore.com>
4452
4453         * ada-lang.c (empty_array): Add "high" parameter.
4454         (ada_evaluate_subexp): Update.
4455
4456 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4457
4458         * unittests/string_view-selftests.c: Define
4459         _initialize_string_view_selftests unconditionally.
4460
4461 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4462
4463         PR gdb/24350
4464         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4465
4466 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4467
4468         PR gdb/24351
4469         * windows-nat.c (display_selector): Fix format specifiers.
4470
4471 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4472
4473         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4474         tui_refill_source_window instead of tui_refresh_win, to update the
4475         current execution line.  This fixes redisplay of the current line
4476         when stepping through the code with "next" or "step".
4477
4478 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4479
4480         * source-cache.c (source_cache::get_source_lines): Call
4481         find_source_lines to initialize s->nlines.  This fixes vertical
4482         scrolling of TUI source window when the DOWN arrow is pressed.
4483
4484 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4485
4486         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4487         linux-thread-db.c (_initialize_thread_db): Likewise.
4488
4489 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4490
4491         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4492         wclrtoeol in tui_show_source_line".  This reverts changes made in
4493         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4494
4495 2019-03-15  Tom Tromey  <tom@tromey.com>
4496
4497         * symtab.h (struct minimal_symbol): Derive from
4498         general_symbol_info.
4499         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4500         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4501         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4502         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4503         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4504         (MSYMBOL_SEARCH_NAME): Update.
4505         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4506         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4507         * minsyms.c (minimal_symbol_reader::record_full): Update.
4508
4509 2019-03-15  Tom Tromey  <tom@tromey.com>
4510
4511         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4512
4513 2019-03-15  Tom Tromey  <tom@tromey.com>
4514
4515         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4516         unique_xmalloc_ptr.
4517         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4518         Update.
4519         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4520         (build_minimal_symbol_hash_tables)
4521         (minimal_symbol_reader::install): Update.
4522
4523 2019-03-15  Tom Tromey  <tom@tromey.com>
4524
4525         * symtab.c (create_demangled_names_hash): Update.
4526         (symbol_set_names): Update.
4527         * objfiles.h (struct objfile_per_bfd_storage)
4528         <demangled_names_hash>: Now an htab_up.
4529         * objfiles.c (objfile_per_bfd_storage): Simplify.
4530
4531 2019-03-15  Tom Tromey  <tom@tromey.com>
4532
4533         * objfiles.h (struct objfile_per_bfd_storage): Declare
4534         destructor.
4535         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4536         New.
4537         (get_objfile_bfd_data): Use new.  Don't initialize
4538         language_of_main.
4539         (free_objfile_per_bfd_storage): Remove.
4540         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4541
4542 2019-03-15  Tom Tromey  <tom@tromey.com>
4543
4544         * symfile.c (reread_symbols): Update.
4545         * objfiles.c (objfile::objfile): Update.
4546         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4547         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4548         comment.
4549         (minimal_symbol_reader::install): Update.
4550         (terminate_minimal_symbol_table): Remove.
4551         * jit.c (jit_object_close_impl): Update.
4552
4553 2019-03-15  Tom Tromey  <tom@tromey.com>
4554
4555         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4556         initializations.
4557
4558 2019-03-15  Tom Tromey  <tom@tromey.com>
4559
4560         * objfiles.h (struct objfile_per_bfd_storage)
4561         <demangled_hash_languages>: Now a bitset.
4562         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4563         (lookup_minimal_symbol): Update.
4564
4565 2019-03-15  Tom Tromey  <tom@tromey.com>
4566
4567         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4568         Don't return the symbol.
4569         * coffread.c (record_minimal_symbol): Use record_full.
4570
4571 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4572
4573         The MS-Windows port of ncurses fails to switch to a color pair if
4574         one or both of the colors are the implicit default colors.  This
4575         change records the default colors when TUI is initialized, and
4576         then specifies them explicitly when a color pair uses the default
4577         colors.  This allows color styling in TUI mode on MS-Windows.
4578
4579         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4580         ncurses_norm_attr.
4581         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4582         colors in ncurses_norm_attr.
4583         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4584         "none", replace it with the default color recorded in
4585         ncurses_norm_attr.
4586
4587 2019-03-14  Tom Tromey  <tromey@adacore.com>
4588
4589         * source-cache.h (class source_cache) <get_source_lines>: Return
4590         std::string.
4591         * source-cache.c (source_cache::extract_lines): Handle case where
4592         first_pos==npos.  Return std::string.
4593         (source_cache::get_source_lines): Update.
4594
4595 2019-03-14  Tom Tromey  <tromey@adacore.com>
4596
4597         * NEWS: Add item for "style sources" commands.
4598         * source-cache.c (source_cache::get_source_lines): Check
4599         source_styling.
4600         * cli/cli-style.c (source_styling): New global.
4601         (_initialize_cli_style): Add "style sources" commands.
4602         (show_style_sources): New function.
4603         * cli/cli-style.h (source_styling): Declare.
4604
4605 2019-03-14  Pedro Alves  <palves@redhat.com>
4606             Tom Tromey  <tromey@adacore.com>
4607
4608         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4609         * tui/tui-winsource.c (tui_refill_source_window): New function,
4610         from...
4611         (tui_horizontal_source_scroll): ... here.  Move some logic.
4612         * cli/cli-style.c (set_style_enabled): Notify new observable.
4613         * tui/tui-hooks.c (tui_redisplay_source): New function.
4614         (tui_attach_detach_observers): Attach or detach
4615         tui_redisplay_source.
4616         * observable.h (source_styling_changed): New observable.
4617         * observable.c: Define source_styling_changed observable.
4618
4619 2019-03-13  Tom Tromey  <tromey@adacore.com>
4620
4621         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4622         (i386_gnu_nat_target::store_registers): Update.
4623         * target-debug.h (target_debug_print_std_string): New macro.
4624         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4625         * windows-tdep.c (display_one_tib): Update.
4626         * tui/tui-stack.c (tui_make_status_line): Update.
4627         * top.c (print_inferior_quit_action): Update.
4628         * thread.c (thr_try_catch_cmd): Update.
4629         (add_thread_with_info): Update.
4630         (thread_target_id_str): Update.
4631         (thr_try_catch_cmd): Update.
4632         (thread_command): Update.
4633         (thread_find_command): Update.
4634         * record-btrace.c (record_btrace_target::info_record)
4635         (record_btrace_resume_thread, record_btrace_target::resume)
4636         (record_btrace_cancel_resume, record_btrace_step_thread)
4637         (record_btrace_target::wait, record_btrace_target::wait)
4638         (record_btrace_target::wait, record_btrace_target::stop): Update.
4639         * progspace.c (print_program_space): Update.
4640         * process-stratum-target.c
4641         (process_stratum_target::thread_address_space): Update.
4642         * linux-fork.c (linux_fork_mourn_inferior)
4643         (detach_checkpoint_command, info_checkpoints_command)
4644         (linux_fork_context): Update.
4645         (linux_fork_detach): Update.
4646         (class scoped_switch_fork_info): Update.
4647         (delete_checkpoint_command): Update.
4648         * infrun.c (follow_fork_inferior): Update.
4649         (follow_fork_inferior): Update.
4650         (proceed_after_vfork_done): Update.
4651         (handle_vfork_child_exec_or_exit): Update.
4652         (follow_exec): Update.
4653         (displaced_step_prepare_throw): Update.
4654         (displaced_step_restore): Update.
4655         (start_step_over): Update.
4656         (resume_1): Update.
4657         (clear_proceed_status_thread): Update.
4658         (proceed): Update.
4659         (print_target_wait_results): Update.
4660         (do_target_wait): Update.
4661         (context_switch): Update.
4662         (stop_all_threads): Update.
4663         (restart_threads): Update.
4664         (finish_step_over): Update.
4665         (handle_signal_stop): Update.
4666         (switch_back_to_stepped_thread): Update.
4667         (keep_going_pass_signal): Update.
4668         (print_exited_reason): Update.
4669         (normal_stop): Update.
4670         * inferior.c (inferior_pid_to_str): Change return type.
4671         (print_selected_inferior): Update.
4672         (add_inferior): Update.
4673         (detach_inferior): Update.
4674         * dummy-frame.c (fprint_dummy_frames): Update.
4675         * dcache.c (dcache_info_1): Update.
4676         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4677         (btrace_fetch, btrace_clear): Update.
4678         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4679         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4680         type.
4681         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4682         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4683         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4684         * gdbarch.c, gdbarch.h: Rebuild.
4685         * gdbarch.sh (core_pid_to_str): Change return type.
4686         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4687         return type.
4688         (windows_nat_target::pid_to_str): Change return type.
4689         (windows_delete_thread): Update.
4690         (windows_nat_target::attach): Update.
4691         (windows_nat_target::files_info): Update.
4692         * target-delegates.c: Rebuild.
4693         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4694         return type.
4695         (sol_thread_target::pid_to_str): Change return type.
4696         * remote.c (class remote_target) <pid_to_str>: Change return
4697         type.
4698         (remote_target::pid_to_str): Change return type.
4699         (extended_remote_target::attach, remote_target::remote_stop_ns)
4700         (remote_target::remote_notif_remove_queued_reply)
4701         (remote_target::push_stop_reply, remote_target::disable_btrace):
4702         Update.
4703         (extended_remote_target::attach): Update.
4704         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4705         type.
4706         (gdbsim_target::pid_to_str): Change return type.
4707         * ravenscar-thread.c (struct ravenscar_thread_target)
4708         <pid_to_str>: Change return type.
4709         (ravenscar_thread_target::pid_to_str): Change return type.
4710         * procfs.c (class procfs_target) <pid_to_str>: Change return
4711         type.
4712         (procfs_target::pid_to_str): Change return type.
4713         (procfs_target::attach): Update.
4714         (procfs_target::detach): Update.
4715         (procfs_target::fetch_registers): Update.
4716         (procfs_target::store_registers): Update.
4717         (procfs_target::wait): Update.
4718         (procfs_target::files_info): Update.
4719         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4720         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4721         return type.
4722         (nto_procfs_target::pid_to_str): Change return type.
4723         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4724         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4725         return type.
4726         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4727         (exit_lwp): Update.
4728         (attach_proc_task_lwp_callback, get_detach_signal)
4729         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4730         (linux_nat_target::resume, wait_lwp, stop_callback)
4731         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4732         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4733         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4734         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4735         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4736         type.
4737         (inf_ptrace_target::attach): Update.
4738         (inf_ptrace_target::files_info): Update.
4739         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4740         type.
4741         (go32_nat_target::pid_to_str): Change return type.
4742         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4743         (gnu_nat_target::wait): Update.
4744         (gnu_nat_target::wait): Update.
4745         (gnu_nat_target::resume): Update.
4746         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4747         (fbsd_nat_target::wait): Update.
4748         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4749         type.
4750         (darwin_nat_target::attach): Update.
4751         * corelow.c (class core_target) <pid_to_str>: Change return type.
4752         (core_target::pid_to_str): Change return type.
4753         * target.c (normal_pid_to_str): Change return type.
4754         (default_pid_to_str): Likewise.
4755         (target_pid_to_str): Change return type.
4756         (target_translate_tls_address): Update.
4757         (target_announce_detach): Update.
4758         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4759         return type.
4760         (bsd_uthread_target::pid_to_str): Change return type.
4761         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4762         type.
4763         (bsd_kvm_target::pid_to_str): Change return type.
4764         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4765         return type.
4766         (aix_thread_target::pid_to_str): Change return type.
4767         * target.h (struct target_ops) <pid_to_str>: Change return type.
4768         (target_pid_to_str, normal_pid_to_str): Likewise.
4769         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4770         type.
4771         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4772         type.
4773         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4774         return type.
4775         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4776         type.
4777         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4778         type.
4779         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4780         return type.
4781
4782 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4783
4784         * NEWS: Mention that the new default MI version is 3.  Mention
4785         changes to the output of commands and events that deal with
4786         multi-location breakpoints.
4787         * breakpoint.c: Include "mi/mi-out.h".
4788         (print_one_breakpoint): Change output syntax if using MI version
4789         >= 3.
4790         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4791         New.
4792         (mi_multi_location_breakpoint_output_fixed): New.
4793         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4794         (mi_cmd_fix_multi_location_breakpoint_output): New.
4795         (mi_multi_location_breakpoint_output_fixed): New.
4796         * mi/mi-cmds.c (mi_cmds): Register command
4797         -fix-multi-location-breakpoint-output.
4798         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4799         interpreter "mi".
4800
4801 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4802
4803         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4804         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4805         instantiate mi_ui_out based on interpreter name.
4806         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4807         * mi/mi-main.c (mi_load_progress): Likewise.
4808
4809 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4810
4811         * NEWS: Combine separate "New targets" sections for 8.3.
4812
4813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4814
4815         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4816         (ppcfbsd_init_abi): Install gdbarch
4817         "fetch_tls_load_module_address" and "get_thread_local_address"
4818         methods.
4819
4820 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4821
4822         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4823         (riscv_fbsd_init_abi): Install gdbarch
4824         "fetch_tls_load_module_address" and "get_thread_local_address"
4825         methods.
4826
4827 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4828
4829         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4830         (i386fbsd_init_abi): Install gdbarch
4831         "fetch_tls_load_module_address" and "get_thread_local_address"
4832         methods.
4833
4834 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4835
4836         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4837         (amd64fbsd_init_abi): Install gdbarch
4838         "fetch_tls_load_module_address" and "get_thread_local_address"
4839         methods.
4840
4841 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4842
4843         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4844         (struct fbsd_pspace_data): New type.
4845         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4846         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4847         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4848         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4849         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4850
4851 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4852
4853         * gdbtypes.c (lookup_struct_elt): New function.
4854         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4855         * gdbtypes.h (struct struct_elt): New type.
4856         (lookup_struct_elt): New prototype.
4857
4858 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4859
4860         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4861         remove disabled code block.
4862
4863 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4864
4865         * gdbarch.sh (get_thread_local_address): New method.
4866         * gdbarch.h, gdbarch.c: Regenerate.
4867         * target.c (target_translate_tls_address): Use
4868         gdbarch_get_thread_local_address if present instead of
4869         target::get_thread_local_address.
4870
4871 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4872
4873         * target.h (target::get_thread_local_address): Update comment.
4874
4875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4876
4877         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4878         objfile->separate_debug_objfile_backlink if not NULL.
4879
4880 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4881
4882         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4883         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4884         (amd64bsd_store_inferior_registers): Likewise.
4885         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4886         Enable segment base registers.
4887         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4888         PT_GETFSBASE and PT_GETGSBASE.
4889         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4890         PT_SETGSBASE.
4891         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4892         segment base registers.
4893         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4894
4895 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4896
4897         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4898         Update calls to i386_target_description to add 'segments'
4899         parameter.
4900         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4901         add segment base registers.
4902         * arch/i386.c (i386_create_target_description): Add 'segments'
4903         parameter to enable segment base registers.
4904         * arch/i386.h (i386_create_target_description): Likewise.
4905         * features/i386/32bit-segments.xml: New file.
4906         * features/i386/32bit-segments.c: Generate.
4907         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4908         call to i386_target_description to add 'segments' parameter.
4909         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4910         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4911         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4912         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4913         if feature is present.
4914         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4915         Add 'segments' parameter to call to i386_target_description.
4916         (i386_target_description): Add 'segments' parameter to enable
4917         segment base registers.
4918         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4919         to call to i386_target_description.
4920         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4921         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4922         Define I386_NUM_REGS.
4923         (i386_target_description): Add 'segments' parameter to enable
4924         segment base registers.
4925
4926 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4927
4928         PR/24325
4929         * source-cache.c: #undef open and close, to avoid unresolved
4930         externals during linking.
4931
4932 2019-03-12  Tom Tromey  <tromey@adacore.com>
4933
4934         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4935         const.  Add initializers.
4936         (_initialize_remote): Don't initialize ptid globals.
4937
4938 2019-03-12  Pedro Alves  <palves@redhat.com>
4939
4940         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4941
4942 2019-03-12  Pedro Alves  <palves@redhat.com>
4943
4944         * cp-name-parser.y (main): Remove unused 'len' variable.
4945
4946 2019-03-12  Tom Tromey  <tromey@adacore.com>
4947
4948         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4949         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4950
4951 2019-03-12  Tom Tromey  <tromey@adacore.com>
4952
4953         * linux-nat.c (iterate_over_lwps): Update.
4954         (stop_callback): Remove parameter.
4955         (stop_wait_callback, detach_callback, resume_set_callback)
4956         (select_singlestep_lwp_callback, set_ignore_sigint)
4957         (status_callback, resumed_callback, resume_clear_callback)
4958         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4959         data parameter.
4960         (linux_nat_target::detach, linux_nat_target::resume)
4961         (linux_stop_and_wait_all_lwps, select_event_lwp)
4962         (linux_nat_filter_event, linux_nat_wait_1)
4963         (linux_nat_target::kill, linux_nat_target::stop)
4964         (linux_nat_target::stop): Update.
4965         (linux_nat_resume_callback): Change type.
4966         (resume_stopped_resumed_lwps, count_events_callback)
4967         (select_event_lwp_callback): Likewise.
4968         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4969         * arm-linux-nat.c (struct update_registers_data): Remove.
4970         (update_registers_callback): Change type.
4971         (arm_linux_insert_hw_breakpoint1): Update.
4972         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4973         parameter.
4974         (x86_linux_dr_set_addr): Update.
4975         (x86_linux_dr_set_control): Update.
4976         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4977         (iterate_over_lwps): Use gdb::function_view.
4978         * nat/aarch64-linux-hw-point.c (struct
4979         aarch64_dr_update_callback_param): Remove.
4980         (debug_reg_change_callback): Change type.
4981         (aarch64_notify_debug_reg_change): Update.
4982         * s390-linux-nat.c (s390_refresh_per_info): Update.
4983
4984 2019-03-11  Tom Tromey  <tromey@adacore.com>
4985
4986         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4987         redundant assignment to "this_cu".
4988
4989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4990
4991         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4992
4993 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4994
4995         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4996         from...
4997         (rank_one_type): ... this.
4998
4999 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5000
5001         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5002         from...
5003         (rank_one_type): ... this.
5004
5005 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5006
5007         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5008         from...
5009         (rank_one_type): ... this.
5010
5011 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5012
5013         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5014         from...
5015         (rank_one_type): ... this.
5016
5017 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5018
5019         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5020         from...
5021         (rank_one_type): ... this.
5022
5023 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5024
5025         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5026         from...
5027         (rank_one_type): ... this.
5028
5029 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5030
5031         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5032         from...
5033         (rank_one_type): ... this.
5034
5035 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5036
5037         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5038         from...
5039         (rank_one_type): ... this.
5040
5041 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5042
5043         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5044         from...
5045         (rank_one_type): ... this.
5046
5047 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5048
5049         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5050         from...
5051         (rank_one_type): ... this.
5052
5053 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5054
5055         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5056         from...
5057         (rank_one_type): ... this.
5058
5059 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5060
5061         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5062         from...
5063         (rank_one_type): ... this.
5064
5065 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5066
5067         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5068         inferior-events' shows the example events.
5069
5070 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5071
5072         Support styling on native MS-Windows console
5073
5074         PR/24315
5075         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5076         on MS-Windows if $TERM is not defined.
5077
5078         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5079
5080         * posix-hdep.c (gdb_console_fputs):
5081         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5082         functions.
5083         * ui-file.h (gdb_console_fputs): Add prototype.
5084
5085         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5086         back to fputs only if the former returns zero.
5087
5088 2019-03-07  Tom Tromey  <tom@tromey.com>
5089
5090         * symmisc.c (print_symbol_bcache_statistics): Update.
5091         (print_objfile_statistics): Update.
5092         * symfile.c (allocate_symtab): Update.
5093         * stabsread.c: Don't include bcache.h.
5094         * psymtab.h (struct psymbol_bcache): Don't declare.
5095         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5096         (psymbol_bcache_init, psymbol_bcache_free)
5097         (psymbol_bcache_get_bcache): Don't declare.
5098         * psymtab.c (struct psymbol_bcache): Remove.
5099         (psymtab_storage::psymtab_storage): Update.
5100         (psymtab_storage::~psymtab_storage): Update.
5101         (psymbol_bcache_init, psymbol_bcache_free)
5102         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5103         (add_psymbol_to_bcache): Update.
5104         (allocate_psymtab): Update.
5105         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5106         macro_cache>: No longer pointers.
5107         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5108         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5109         * macrotab.c (macro_bcache): Update.
5110         * macroexp.c: Don't include bcache.h.
5111         * gdbtypes.c (check_types_worklist): Update.
5112         (types_deeply_equal): Remove TRY/CATCH.  Update.
5113         * elfread.c (elf_symtab_read): Update.
5114         * dwarf2read.c: Don't include bcache.h.
5115         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5116         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5117         (print_bcache_statistics, bcache_memory_used): Don't declare.
5118         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5119         methods.  Rename all data members.
5120         * bcache.c (struct bcache): Move to bcache.h.
5121         (bcache::expand_hash_table): Rename from expand_hash_table.
5122         (bcache): Remove.
5123         (bcache::insert): Rename from bcache_full.
5124         (bcache::compare): Rename from bcache_compare.
5125         (bcache_xmalloc): Remove.
5126         (bcache::~bcache): Rename from bcache_xfree.
5127         (bcache::print_statistics): Rename from print_bcache_statistics.
5128         (bcache::memory_used): Rename from bcache_memory_used.
5129
5130 2019-03-07  Pedro Alves  <palves@redhat.com>
5131
5132         * infrun.c (normal_stop): Also check for
5133         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5134
5135 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5136
5137         * f-lang.c (value_from_host_double): Moved to...
5138         * value.c (value_from_host_double): ...here.
5139         * value.h (value_from_host_double): Declare.
5140         * guile/scm-math.c (vlscm_convert_typed_number): Use
5141         value_from_host_double.
5142         (vlscm_convert_number): Likewise.
5143         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5144         * python/py-value.c (convert_value_from_python): Likewise.
5145
5146 2019-03-06  Tom Tromey  <tom@tromey.com>
5147
5148         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5149
5150 2019-03-06  Tom Tromey  <tom@tromey.com>
5151
5152         * utils.h (free_current_contents): Don't declare.
5153         * utils.c (free_current_contents): Remove.
5154
5155 2019-03-06  Tom Tromey  <tom@tromey.com>
5156
5157         * top.c (quit_force): Update.
5158         * main.c (captured_command_loop): Update.
5159         * common/new-op.c (operator new): Update.
5160         * common/common-exceptions.c (struct catcher)
5161         <save_cleanup_chain>: Remove member.
5162         (exceptions_state_mc_init): Update.
5163         (exception_try_scope_entry): Return nullptr.
5164         (exception_try_scope_exit, exception_rethrow)
5165         (throw_exception_sjlj, throw_exception_cxx): Update.
5166         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5167         (all_cleanups, do_cleanups, discard_cleanups)
5168         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5169         (restore_cleanups, restore_final_cleanups): Don't declare.
5170         (do_final_cleanups): Remove parameter.
5171         * common/cleanups.c (cleanup_chain, make_cleanup)
5172         (make_cleanup_dtor, all_cleanups, do_cleanups)
5173         (discard_my_cleanups, discard_cleanups)
5174         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5175         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5176         (null_cleanup): Remove.
5177         (do_final_cleanups): Remove parameter.
5178
5179 2019-03-06  Tom Tromey  <tom@tromey.com>
5180
5181         * remote.c (remote_target::remote_parse_stop_reply): Use
5182         unique_xmalloc_ptr.
5183
5184 2019-03-06  Tom Tromey  <tom@tromey.com>
5185
5186         * stabsread.c (struct stabs_field_info): Rename from field_info.
5187         <list, fnlist>: Add initializers.
5188         <obstack>: New member.
5189         (read_member_functions, read_struct_fields, read_baseclasses):
5190         Allocate on obstack.  Don't use cleanups.
5191         (read_one_struct_field, read_member_functions, read_struct_fields)
5192         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5193         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5194         (read_struct_type): Update.
5195
5196 2019-03-06  Tom Tromey  <tom@tromey.com>
5197
5198         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5199         * common/filestuff.h (make_cleanup_close): Don't declare.
5200         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5201         Remove.
5202
5203 2019-03-06  Tom Tromey  <tom@tromey.com>
5204
5205         * solib-aix.c: Use make_scope_exit.
5206
5207 2019-03-06  Tom Tromey  <tom@tromey.com>
5208
5209         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5210         Use make_scope_exit.
5211
5212 2019-03-06  Tom Tromey  <tom@tromey.com>
5213
5214         * solib-svr4.c (disable_probes_interface): Remove parameter.
5215         (svr4_handle_solib_event): Use make_scope_exit.
5216
5217 2019-03-06  Tom Tromey  <tom@tromey.com>
5218
5219         * remote.c (struct stop_reply_deleter): Remove.
5220         (stop_reply_up): Update.
5221         (struct stop_reply): Derive from notif_event.  Don't typedef.
5222         <regcache>: Now a std::vector.
5223         (stop_reply_xfree): Remove.
5224         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5225         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5226         (remote_target::discard_pending_stop_replies): Use delete.
5227         (remote_target::remote_parse_stop_reply): Update.
5228         (remote_target::process_stop_reply): Update.
5229         * remote-notif.h (struct notif_event): Add virtual destructor.
5230         Remove "dtr" member.
5231         (struct notif_client) <alloc_event>: Return a unique_ptr.
5232         (notif_event_xfree): Don't declare.
5233         (notif_event_up): New typedef.
5234         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5235         (notif_event_xfree, do_notif_event_xfree): Remove.
5236         (remote_notif_state_xfree): Update.
5237
5238 2019-03-06  Tom Tromey  <tom@tromey.com>
5239
5240         * infrun.c (displaced_step_clear_cleanup): Now a
5241         forward_scope_exit type.
5242         (displaced_step_prepare_throw): Update.
5243         (displaced_step_fixup): Update.
5244
5245 2019-03-06  Tom Tromey  <tom@tromey.com>
5246
5247         * inferior.h (class inferior): Update comment.
5248         * gdbthread.h (class thread_info): Update comment.
5249
5250 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5251             Tom Tromey  <tom@tromey.com>
5252
5253         * stabsread.h (struct stab_section_list): Remove.
5254         (coffstab_build_psymtabs): Update.
5255         * dbxread.c (symbuf_sections): Now a std::vector.
5256         (sect_idx): New global.
5257         (fill_symbuf): Update.
5258         (coffstab_build_psymtabs): Change type of stabsects parameter.
5259         Update.
5260         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5261         std::vector.
5262         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5263         (coff_locate_sections): Update.
5264         (coff_symfile_read): Remove cleanups.  Update.
5265         (init_stringtab): Add storage parameter.
5266         (free_stringtab, free_stringtab_cleanup): Remove.
5267         (init_lineno): Add storage parameter.
5268         (free_linetab, free_linetab_cleanup): Remove.
5269
5270 2019-03-06  Pedro Alves  <palves@redhat.com>
5271
5272         * linux-fork.c (fork_info::clobber_regs): Delete.
5273         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5274         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5275         comment.  Adjust.
5276         (scoped_switch_fork_info::scoped_switch_fork_info)
5277         (checkpoint_command, linux_fork_context): Adjust
5278         fork_save_infrun_state calls.
5279
5280 2019-03-06  Pedro Alves  <palves@redhat.com>
5281
5282         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5283         (inf_has_multiple_threads): Return 'bool' and rewrite using
5284         inferior_info::threads().
5285
5286 2019-03-06  Pedro Alves  <palves@redhat.com>
5287
5288         * linux-fork.c: Include <list>.
5289         (fork_list): Now a std::list instance.
5290         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5291         (forks_exist_p, find_last_fork): Adjust.
5292         (new_fork): Delete.
5293         (one_fork_p): New.
5294         (add_fork): Adjust.
5295         (free_fork): Delete, folded into fork_info::~fork_info().
5296         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5297         Adjust.
5298         (init_fork_list): Delete.
5299         (linux_fork_killall, linux_fork_mourn_inferior)
5300         (linux_fork_detach, info_checkpoints_command): Adjust.
5301         (_initialize_linux_fork): No longer call init_fork_list.
5302
5303 2019-03-06  Pedro Alves  <palves@redhat.com>
5304
5305         * linux-fork.c (new_fork): New, split out of ...
5306         (add_fork): ... this.  Return void.  Move "first fork" special
5307         case from here, to ...
5308         (checkpoint_command): ... here.
5309         * linux-linux.h (add_fork): Return void.
5310
5311 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5312
5313         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5314
5315 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5316             Chris January  <chris.january@arm.com>
5317             David Lecomber  <david.lecomber@arm.com>
5318
5319         * f-exp.y: New token, UNOP_INTRINSIC.
5320         (exp): New pattern using UNOP_INTRINSIC token.
5321         (f77_keywords): Add 'abs' keyword.
5322         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5323         (value_from_host_double): New function.
5324         (evaluate_subexp_f): Support UNOP_ABS.
5325
5326 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5327
5328         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5329         types.
5330
5331 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5332
5333         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5334         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5335         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5336
5337 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5338
5339         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5340
5341 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5342             Chris January  <chris.january@arm.com>
5343
5344         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5345         * f-exp.y: Define 'KIND' token.
5346         (exp): New pattern for KIND expressions.
5347         (ptype): Handle types with a kind extension.
5348         (direct_abs_decl): Extend to spot kind extensions.
5349         (f77_keywords): Add 'kind' to the list.
5350         (push_kind_type): New function.
5351         (convert_to_kind_type): New function.
5352         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5353         * parse.c (operator_length_standard): Likewise.
5354         * parser-defs.h (enum type_pieces): Add tp_kind.
5355         * std-operator.def: Add UNOP_KIND.
5356
5357 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5358
5359         * f-exp.y (f_parse): Set yydebug.
5360
5361 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5362
5363         * f-lang.c (evaluate_subexp_f): New function.
5364         (exp_descriptor_f): New global.
5365         (f_language_defn): Use exp_descriptor_f instead of
5366         exp_descriptor_standard.
5367
5368 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5369
5370         * f-exp.y (struct token): Add comments.
5371         (dot_ops): Remove uppercase versions and the end marker.
5372         (f77_keywords): Likewise.
5373         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5374         entries in the dot_ops array are case insensitive, and use
5375         strncasecmp to compare strings.  Also some whitespace cleanup in
5376         this area.  Similar for the f77_keywords array, except entries in
5377         this list might be case sensitive.
5378
5379 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5380
5381         * f-exp.y (struct f77_boolean_val): Add comments.
5382         (boolean_values): Remove uppercase versions, and end marker.
5383         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5384         and use strncasecmp to achieve case insensitivity.  Additionally,
5385         perform whitespace cleanup around this code.
5386
5387 2019-03-06  Tom Tromey  <tromey@adacore.com>
5388
5389         * remote-sim.c (gdbsim_target_open): Use result of
5390         gdb_argv::release.
5391
5392 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5393         Dirk Schubert  <dirk.schubert@arm.com>
5394         Chris January  <chris.january@arm.com>
5395
5396         * eval.c (evaluate_subexp_standard): Call Fortran argument
5397         wrapping logic.
5398         * f-lang.c (struct value): A value which can be passed into a
5399         Fortran function call.
5400         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5401         where appropriate.
5402         (struct type): Value ready for a Fortran function call.
5403         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5404         is needed.
5405         * f-lang.h (fortran_argument_convert): Declaration.
5406         (fortran_preserve_arg_pointer): Declaration.
5407         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5408
5409 2019-03-05  Tom Tromey  <tromey@adacore.com>
5410
5411         * python/py-prettyprint.c (print_string_repr): Remove #if.
5412         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5413
5414 2019-03-05  Tom Tromey  <tromey@adacore.com>
5415
5416         * target.c (the_dummy_target): Move later.  Change type to
5417         "dummy_target".
5418         (initialize_targets): Don't initialize the_dummy_target.
5419
5420 2019-03-05  Tom Tromey  <tromey@adacore.com>
5421
5422         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5423         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5424
5425 2019-03-05  Tom Tromey  <tromey@adacore.com>
5426
5427         * windows-nat.c (windows_nat_target::attach)
5428         (windows_nat_target::detach): Don't call gdb_flush.
5429         * valprint.c (generic_val_print, val_print, val_print_string):
5430         Don't call gdb_flush.
5431         * utils.c (defaulted_query): Don't call gdb_flush.
5432         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5433         * target.c (target_announce_detach): Don't call gdb_flush.
5434         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5435         * remote.c (extended_remote_target::attach): Don't call
5436         gdb_flush.
5437         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5438         * printcmd.c (do_examine): Don't call gdb_flush.
5439         (info_display_command): Don't call gdb_flush.
5440         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5441         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5442         * memattr.c (info_mem_command): Don't call gdb_flush.
5443         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5444         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5445         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5446         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5447         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5448         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5449         (gnu_nat_target::detach): Don't call gdb_flush.
5450         * f-valprint.c (f_val_print): Don't call gdb_flush.
5451         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5452         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5453         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5454         gdb_flush.
5455         * c-valprint.c (c_val_print): Don't call gdb_flush.
5456         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5457
5458 2019-03-05  Tom Tromey  <tromey@adacore.com>
5459
5460         * varobj.c (update_dynamic_varobj_children): Update.
5461         (install_default_visualizer): Use reset, not release.
5462         * value.c (set_internalvar): Update.
5463         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5464         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5465         ATTRIBUTE_UNUSED_RESULT.
5466
5467 2019-03-05  Tom Tromey  <tromey@adacore.com>
5468
5469         * remote.c (class scoped_remote_fd) <release>: Add
5470         ATTRIBUTE_UNUSED_RESULT.
5471
5472 2019-03-05  Tom Tromey  <tromey@adacore.com>
5473
5474         * macroexp.c (struct macro_buffer) <release>: Add
5475         ATTRIBUTE_UNUSED_RESULT.
5476
5477 2019-03-05  Tom Tromey  <tromey@adacore.com>
5478
5479         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5480         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5481         ATTRIBUTE_UNUSED_RESULT.
5482
5483 2019-03-05  Tom Tromey  <tromey@adacore.com>
5484
5485         * common/scoped_fd.h (class scoped_fd) <release>: Add
5486         ATTRIBUTE_UNUSED_RESULT.
5487
5488 2019-03-05  Tom Tromey  <tromey@adacore.com>
5489
5490         * parser-defs.h (struct parser_state) <release>: Add
5491         ATTRIBUTE_UNUSED_RESULT.
5492
5493 2019-03-05  Tom Tromey  <tromey@adacore.com>
5494
5495         * utils.h (class gdb_argv) <release>: Add
5496         ATTRIBUTE_UNUSED_RESULT.
5497         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5498
5499 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5500
5501         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5502         for-loop range, to avoid compiler warnings.
5503
5504         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5505         avoid compiler warnings about unused variables.
5506
5507         * NEWS: Mention end of support for native debugging on MS-Windows
5508         before XP.
5509
5510         PR gdb/24292
5511         * common/netstuff.c:
5512         * gdbserver/gdbreplay.c
5513         * gdbserver/remote-utils.c:
5514         * ser-tcp.c:
5515         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5516         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5517         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5518         'getaddrinfo' and 'freeaddrinfo' were not available before
5519         Windows XP, and mingw.org's MinGW headers by default define
5520         _WIN32_WINNT to 0x500.
5521
5522 2019-03-01  Gary Benson <gbenson@redhat.com>
5523
5524         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5525
5526 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5527             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5528
5529         PR gdb/8527
5530         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5531         set_sigint_trap, clear_sigint_trap.
5532
5533 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5534
5535         * target.c (target_detach): Clear the regcache and the
5536         frame cache.
5537
5538 2019-02-27  Pedro Alves  <palves@redhat.com>
5539
5540         * utils.c (set_screen_size): When we cap the height/width sizes,
5541         tweak the corresponding command variable to show "unlimited":
5542
5543 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5544             Pedro Alves  <palves@redhat.com>
5545
5546         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5547         before calling rl_set_screen_size.
5548
5549 2019-02-27  Tom Tromey  <tromey@adacore.com>
5550
5551         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5552         define.
5553         * python/py-value.c: Remove Python 2.4 workaround.
5554         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5555         workaround.
5556         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5557         Python 2.4 workaround.
5558         * python/python-internal.h: Remove Python 2.4 comment.
5559         (Py_ssize_t): Don't define.
5560         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5561         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5562         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5563         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5564         * python/python.c (do_start_initialization): Remove Python 2.4
5565         workaround.
5566         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5567         (print_children): Remove Python 2.4 workaround.
5568         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5569         workaround.
5570         (CHARBUFFERPROC_NAME): Remove.
5571         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5572         Python 2.4 workaround.
5573
5574 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5575
5576         * NEWS: Note minimum Python version.
5577
5578 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5579
5580         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5581         code from these functions.  Remove corresponding ifdefs.  Use
5582         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5583         Remove gotos and target of gotos.
5584         (infpy_search_memory): Likewise.
5585
5586 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5587
5588         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5589         (hppa_gdbarch_init): Don't register deleted functions with
5590         gdbarch.
5591
5592 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5593
5594         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5595         (h8300_unwind_sp): Delete.
5596         (h8300_dummy_id): Delete.
5597         (h8300_gdbarch_init): Don't register deleted functions with
5598         gdbarch.
5599
5600 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5601
5602         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5603         (ft32_unwind_pc): Delete.
5604         (ft32_unwind_sp): Delete.
5605         (ft32_gdbarch_init): Don't register deleted functions with
5606         gdbarch.
5607
5608 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5609
5610         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5611         (frv_unwind_pc): Delete.
5612         (frv_unwind_sp): Delete.
5613         (frv_gdbarch_init): Don't register deleted functions with
5614         gdbarch.
5615
5616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5617
5618         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5619         (riscv_unwind_pc): Delete.
5620         (riscv_unwind_sp): Delete.
5621         (riscv_gdbarch_init): Don't register deleted functions with
5622         gdbarch.
5623
5624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5625
5626         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5627         (csky_unwind_pc): Delete.
5628         (csky_unwind_sp): Delete.
5629         (csky_gdbarch_init): Don't register deleted functions with
5630         gdbarch.
5631
5632 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5633
5634         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5635         (cris_unwind_pc): Delete.
5636         (cris_unwind_sp): Delete.
5637         (cris_gdbarch_init): Don't register deleted functions with
5638         gdbarch.
5639
5640 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5641
5642         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5643         (bfin_unwind_pc): Delete.
5644         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5645
5646 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5647
5648         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5649         (arm_unwind_pc): Delete.
5650         (arm_unwind_sp): Delete.
5651         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5652
5653 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5654
5655         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5656         (arc_unwind_pc): Delete.
5657         (arc_unwind_sp): Delete.
5658         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5659
5660 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5661
5662         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5663         (alpha_unwind_pc): Delete.
5664         (alpha_gdbarch_init): Don't register deleted functions with
5665         gdbarch.
5666
5667 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5668
5669         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5670         (aarch64_unwind_pc): Delete.
5671         (aarch64_unwind_sp): Delete.
5672         (aarch64_gdbarch_init): Don't register deleted functions with
5673         gdbarch.
5674
5675 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5676
5677         * gdbtypes.c (type_align): Don't consider static members when
5678         computing structure alignment.
5679
5680 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5681
5682         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5683         return 0 for other types.
5684         * arch-utils.c (default_type_align): Always return 0.
5685         * gdbarch.h: Regenerate.
5686         * gdbarch.sh (type_align): Extend comment.
5687         * gdbtypes.c (type_align): Add additional comments, always call
5688         gdbarch_type_align before applying the default rules.
5689         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5690         generic code will then apply a suitable default.
5691         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5692         types, return 0 for other types.
5693
5694 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5695
5696         * NEWS: Create a new section for the next release branch.
5697         Rename the section of the current branch, now that it has
5698         been cut.
5699
5700 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5701
5702         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5703         * version.in: Bump version to 8.3.50.DATE-git.
5704
5705 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5706
5707         * aix-thread.c (ptid_cmp): Remove unused variable.
5708         (get_signaled_thread): Likewise.
5709         (store_regs_user_thread): Likewise.
5710         (store_regs_kernel_thread): Likewise.
5711         (fetch_regs_kernel_thread): Remove shadowed variable.
5712
5713 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5714
5715         * features/riscv/32bit-cpu.xml: Add register numbers.
5716         * features/riscv/32bit-fpu.c: Regenerate.
5717         * features/riscv/32bit-fpu.xml: Add register numbers.
5718         * features/riscv/64bit-cpu.xml: Add register numbers.
5719         * features/riscv/64bit-fpu.c: Regenerate.
5720         * features/riscv/64bit-fpu.xml: Add register numbers.
5721
5722 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5723
5724         * NEWS: Mention two argument form of gdb.Value constructor.
5725         * python/py-value.c (convert_buffer_and_type_to_value): New
5726         function.
5727         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5728         Add support for handling an optional second argument.  Call
5729         convert_buffer_and_type_to_value as appropriate.
5730         * python/python-internal.h (Py_buffer_deleter): New struct.
5731         (Py_buffer_up): New typedef.
5732
5733 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5734
5735         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5736         instead of releasing ownership.
5737
5738 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5739
5740         * dwarf2read.c (open_and_init_dwp_file): Call
5741         elf_numsections instead of bfd_count_sections to initialize
5742         dwp_file->num_sections.
5743
5744 2019-02-25  Tom Tromey  <tromey@adacore.com>
5745
5746         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5747
5748 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5749
5750         * gcore.in: Add '--readnever' option when invoking GDB.
5751
5752 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5753
5754         * MAINTAINERS: Update my email address.
5755
5756 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5757
5758         * build-id.c (build_id_to_debug_bfd_1): New function.
5759         (build_id_to_debug_bfd): Look for separate debug file in
5760         sysroot.
5761
5762 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5763
5764         * gdbarch.sh: Update the copyright year range that is placed into
5765         generated files.
5766
5767 2019-02-22  Keith Seitz  <keiths@redhat.com>
5768
5769         PR symtab/23853
5770         * linespec.c (create_sals_line_offset): Search for the default
5771         symtab's filename instead of its fullname.
5772
5773 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5774
5775         * NEWS: Update style defaults.
5776
5777 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5778
5779         * main.c (captured_main_1): Disable styling in batch mode.
5780
5781 2019-02-20  Tom Tromey  <tom@tromey.com>
5782
5783         * symtab.c (symtab_symbol_info): Fix typos.
5784
5785 2019-02-20  Tom Tromey  <tromey@adacore.com>
5786
5787         * findcmd.c (_initialize_mem_search): Use upper case for
5788         metasyntactic variables.
5789
5790 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5791
5792         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5793         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5794
5795 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5796
5797         * top.h (source_file_name): Change to std::string.
5798         * top.c (source_file_name): Likewise.
5799         (command_line_input): Adjust.
5800         * cli/cli-script.c (script_from_file): Adjust.
5801
5802 2019-02-19  Tom Tromey  <tromey@adacore.com>
5803
5804         * ravenscar-thread.c
5805         (ravenscar_thread_target::update_thread_list): Don't call
5806         ada_build_task_list.
5807         * ada-lang.h (ada_build_task_list): Don't declare.
5808         * ada-tasks.c (struct ada_tasks_inferior_data)
5809         <task_list_valid_p>: Now bool.
5810         (read_known_tasks, ada_task_list_changed)
5811         (ada_tasks_invalidate_inferior_data): Update.
5812         (read_known_tasks_array): Return bool.
5813         (read_known_tasks_list): Likewise.
5814         (read_known_tasks): Return void.
5815         (ada_build_task_list): Now static.
5816
5817 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5818
5819         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5820         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5821
5822 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5823
5824         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5825         variant for ada_tasks_pspace_data_handle and
5826         ada_tasks_inferior_data_handle.
5827         (ada_tasks_pspace_data_cleanup): New function.
5828         (ada_tasks_inferior_data_cleanup): New function.
5829
5830 2019-02-17  Tom Tromey  <tom@tromey.com>
5831
5832         * macrotab.h (macro_source_fullname): Return a std::string.
5833         * macrotab.c (macro_include, check_for_redefinition)
5834         (macro_undef, macro_lookup_definition, foreach_macro)
5835         (foreach_macro_in_scope): Update.
5836         (macro_source_fullname): Return a std::string.
5837         * macrocmd.c (show_pp_source_pos): Update.
5838
5839 2019-02-17  Tom Tromey  <tom@tromey.com>
5840
5841         * macrocmd.c (show_pp_source_pos): Style the file names.
5842
5843 2019-02-17  Tom Tromey  <tom@tromey.com>
5844
5845         PR tui/24197:
5846         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5847
5848 2019-02-17  Tom Tromey  <tom@tromey.com>
5849
5850         * ada-lang.c (user_select_syms): Use filtered printing.
5851         * utils.c (wrap_style): New global.
5852         (desired_style): Remove.
5853         (emit_style_escape): Add stream parameter.
5854         (set_output_style, reset_terminal_style, prompt_for_continue):
5855         Update.
5856         (flush_wrap_buffer): Only flush gdb_stdout.
5857         (wrap_here): Set wrap_style.
5858         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5859         treat escape sequences as a character.  Change when wrap buffer is
5860         flushed.
5861         (fputs_styled): Do not set the output style when the default is
5862         requested.
5863         * ui-style.h (struct ui_file_style) <is_default>: New method.
5864         * source.c (print_source_lines_base): Emit escape sequences in one
5865         piece.
5866
5867 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5868
5869         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5870         integers and enumeration types.
5871
5872 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5873
5874         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5875         instead of lookup_symbol_in_language
5876         (do_exact_match): New function.
5877         (ada_get_symbol_name_matcher): Return do_exact_match when
5878         doing a verbatim match.
5879
5880 2019-02-15  Tom Tromey  <tromey@adacore.com>
5881
5882         * ravenscar-thread.c (ravenscar_thread_target::resume)
5883         (ravenscar_thread_target::wait): Special case wildcard requests.
5884
5885 2019-02-15  Tom Tromey  <tromey@adacore.com>
5886
5887         * ravenscar-thread.c (base_ptid): Remove.
5888         (struct ravenscar_thread_target) <close>: New method.
5889         <m_base_ptid>: New member.
5890         <update_inferior_ptid, active_task, task_is_currently_active,
5891         runtime_initialized>: Declare methods.
5892         <ravenscar_thread_target>: Add constructor.
5893         (ravenscar_thread_target::task_is_currently_active)
5894         (ravenscar_thread_target::update_inferior_ptid)
5895         (ravenscar_runtime_initialized): Rename.  Now methods.
5896         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5897         (ravenscar_thread_target::update_thread_list): Update.
5898         (ravenscar_thread_target::active_task): Now method.
5899         (ravenscar_thread_target::store_registers)
5900         (ravenscar_thread_target::prepare_to_store)
5901         (ravenscar_thread_target::prepare_to_store)
5902         (ravenscar_thread_target::mourn_inferior): Update.
5903         (ravenscar_inferior_created): Use "new" to create target.
5904         (ravenscar_thread_target::get_ada_task_ptid): Update.
5905         (_initialize_ravenscar): Don't initialize base_ptid.
5906         (ravenscar_ops): Remove global.
5907
5908 2019-02-15  Tom Tromey  <tromey@adacore.com>
5909
5910         * target.h (push_target): Declare new overload.
5911         * target.c (push_target): New overload, taking an rvalue reference.
5912         * remote.c (remote_target::open_1): Use push_target overload.
5913         * corelow.c (core_target_open): Use push_target overload.
5914
5915 2019-02-15  Tom Tromey  <tromey@adacore.com>
5916
5917         * ravenscar-thread.c (is_ravenscar_task)
5918         (ravenscar_task_is_currently_active): Return bool.
5919         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5920         (_initialize_ravenscar): Remove "(void)".
5921         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5922         Return bool.
5923
5924 2019-02-15  Tom Tromey  <tromey@adacore.com>
5925
5926         * ravenscar-thread.c (ravenscar_runtime_initializer)
5927         (has_ravenscar_runtime, get_running_thread_id)
5928         (ravenscar_thread_target::resume): Fix indentation.
5929
5930 2019-02-15  Tom Tromey  <tromey@adacore.com>
5931
5932         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5933         from ravenscar_arch_ops.
5934         (sparc_ravenscar_ops::fetch_registers)
5935         (sparc_ravenscar_ops::store_registers): Now methods.
5936         (sparc_ravenscar_prepare_to_store): Remove.
5937         (sparc_ravenscar_ops): Redefine.
5938         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5939         methods and destructor.  Remove members.
5940         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5941         (ravenscar_thread_target::store_registers)
5942         (ravenscar_thread_target::prepare_to_store): Update.
5943         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5944         Remove.
5945         (struct ppc_ravenscar_powerpc_ops): Derive from
5946         ravenscar_arch_ops.
5947         (ppc_ravenscar_powerpc_ops::fetch_registers)
5948         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5949         (ppc_ravenscar_powerpc_ops): Redefine.
5950         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5951         (ppc_ravenscar_e500_ops::fetch_registers)
5952         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5953         (ppc_ravenscar_e500_ops): Redefine.
5954         * aarch64-ravenscar-thread.c
5955         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5956         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5957         (aarch64_ravenscar_fetch_registers)
5958         (aarch64_ravenscar_store_registers): Now methods.
5959         (aarch64_ravenscar_ops): Redefine.
5960
5961 2019-02-15  Tom Tromey  <tromey@adacore.com>
5962
5963         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5964         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5965         (ravenscar_thread_target::stopped_by_watchpoint)
5966         (ravenscar_thread_target::stopped_data_address)
5967         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5968
5969 2019-02-15  Tom Tromey  <tromey@adacore.com>
5970
5971         * ravenscar-thread.c: Fix some typos.
5972
5973 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5974             Tom Tromey  <tromey@adacore.com>
5975
5976         * ada-lang.c (ada_exception_sal): Change addr_string to a
5977         std::string.
5978         (create_ada_exception_catchpoint): Update.
5979
5980 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5981             Tom Tromey  <tromey@adacore.com>
5982
5983         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5984         (bp_location_ops): Remove.
5985         (base_breakpoint_allocate_location): Update.
5986         (free_bp_location): Update.
5987         * ada-lang.c (class ada_catchpoint_location)
5988         <ada_catchpoint_location>: Remove ops parameter.
5989         (ada_catchpoint_location_dtor): Remove.
5990         (ada_catchpoint_location_ops): Remove.
5991         (allocate_location_exception): Update.
5992         * breakpoint.h (struct bp_location_ops): Remove.
5993         (class bp_location) <bp_location>: Remove bp_location_ops
5994         parameter.
5995         <~bp_location>: Add destructor.
5996         <ops>: Remove.
5997
5998 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5999             Pedro Alves  <palves@redhat.com>
6000
6001         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6002         'PATH_MAX'.
6003
6004 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6005             Samuel Thibault  <samuel.thibault@gnu.org>
6006             Thomas Schwinge  <thomas@codesourcery.com>
6007
6008         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6009         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6010
6011 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6012
6013         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6014         (check_empty): Use "const char *".
6015
6016         * gnu-nat.c (gnu_nat_target::detach): Instead of
6017         'detach_inferior (pid)' call
6018         'detach_inferior (find_inferior_pid (pid))'.
6019
6020         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6021         'nat/fork-inferior.o'.
6022         * gnu-nat.c: #include "nat/fork-inferior.h".
6023
6024         * gnu-nat.c (gnu_nat_target::detach): Instead of
6025         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6026         * gnu-nat.h: #include "inf-child.h".
6027         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6028         'i386_gnu_nat_target::fetch_registers'.
6029         (gnu_store_registers): Rename/move to
6030         'i386_gnu_nat_target::store_registers'.
6031
6032         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6033         * gnu-nat.h (mach_thread_info): New function.
6034         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6035
6036         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6037
6038 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6039
6040         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6041
6042 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6043
6044         * windows-nat.c (windows_add_thread): Add new parameter
6045         "main_thread_p" with default value set to false.  Update
6046         function documentation as well as all callers.
6047         (windows_delete_thread): Likewise.
6048         (fake_create_process): Update call to windows_add_thread.
6049         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6050         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6051         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6052         call to windows_delete_thread.
6053
6054 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6055
6056         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6057
6058 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6059
6060         * symfile.c (find_separate_debug_file): Use canonical path of
6061         sysroot with child_path instead of gdb_sysroot if it is valid.
6062
6063 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6064
6065         * symfile.c (find_separate_debug_file): Use child_path to
6066         determine if an object file is under a sysroot.
6067
6068 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6069
6070         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6071         unittests/child-path-selftests.c.
6072         * common/pathstuff.c (child_path): New function.
6073         * common/pathstuff.h (child_path): New prototype.
6074         * unittests/child-path-selftests.c: New file.
6075
6076 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6077
6078         * symfile.c (find_separate_debug_file): Look for separate debug
6079         files in debug directories under the sysroot.
6080
6081 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6082
6083         * symtab.h (struct minimal_symbol data_p): New const method.
6084         (struct minimal_symbol text_p): Likewise.
6085         * symtab.c (output_source_filename): Use file name style
6086         to print file name.
6087         (print_symbol_info): Likewise.
6088         (print_msymbol_info): Use address style to print addresses.
6089         Use function name style to print executable text symbols.
6090         (expand_symtab_containing_pc): Use data_p.
6091         (find_pc_sect_compunit_symtab): Likewise.
6092
6093 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6094
6095         * breakpoint.c (describe_other_breakpoints): Use address style
6096         to print addresses.
6097         (say_where): Likewise.
6098
6099 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6100
6101         * ada-typeprint.c (print_func_type): Print function name
6102         style to print function name.
6103         * c-typeprint.c (c_print_type_1): Likewise.
6104
6105 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6106
6107         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6108         for execve.
6109
6110 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6111
6112         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6113         type_stack.
6114
6115 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6116
6117         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6118         TYPE_CODE_REF types.
6119
6120 2019-02-08  Jim Wilson  <jimw@sifive.com>
6121
6122         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6123         (riscv_linux_fregset): New.
6124         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6125
6126 2019-02-07  Tom Tromey  <tom@tromey.com>
6127
6128         * thread.c (thread_cancel_execution_command): Update.
6129         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6130         methods.
6131         (struct thread_fsm_ops): Remove.
6132         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6133         (thread_fsm_should_stop, thread_fsm_return_value)
6134         (thread_fsm_set_finished, thread_fsm_finished_p)
6135         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6136         Don't declare.
6137         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6138         * infrun.c (clear_proceed_status_thread)
6139         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6140         (print_stop_event): Update.
6141         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6142         Add constructor.
6143         (step_command_fsm_ops): Remove.
6144         (new_step_command_fsm): Remove.
6145         (step_1): Update.
6146         (step_command_fsm::should_stop): Rename from
6147         step_command_fsm_should_stop.
6148         (step_command_fsm::clean_up): Rename from
6149         step_command_fsm_clean_up.
6150         (step_command_fsm::do_async_reply_reason): Rename from
6151         step_command_fsm_async_reply_reason.
6152         (struct until_next_fsm): Inherit from thread_fsm.  Add
6153         constructor.
6154         (until_next_fsm_ops): Remove.
6155         (new_until_next_fsm): Remove.
6156         (until_next_fsm::should_stop): Rename from
6157         until_next_fsm_should_stop.
6158         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6159         (until_next_fsm::do_async_reply_reason): Rename from
6160         until_next_fsm_async_reply_reason.
6161         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6162         constructor.  Change type of breakpoint.
6163         (finish_command_fsm_ops): Remove.
6164         (new_finish_command_fsm): Remove.
6165         (finish_command_fsm::should_stop): Rename from
6166         finish_command_fsm_should_stop.
6167         (finish_command_fsm::clean_up): Rename from
6168         finish_command_fsm_clean_up.
6169         (finish_command_fsm::return_value): Rename from
6170         finish_command_fsm_return_value.
6171         (finish_command_fsm::do_async_reply_reason): Rename from
6172         finish_command_fsm_async_reply_reason.
6173         (finish_command): Update.
6174         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6175         Add constructor.
6176         (call_thread_fsm_ops): Remove.
6177         (call_thread_fsm::call_thread_fsm): Rename from
6178         new_call_thread_fsm.
6179         (call_thread_fsm::should_stop): Rename from
6180         call_thread_fsm_should_stop.
6181         (call_thread_fsm::should_notify_stop): Rename from
6182         call_thread_fsm_should_notify_stop.
6183         (run_inferior_call, call_function_by_hand_dummy): Update.
6184         * cli/cli-interp.c (should_print_stop_to_console): Update.
6185         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6186         Add constructor.  Change type of location_breakpoint,
6187         caller_breakpoint.
6188         (until_break_fsm_ops): Remove.
6189         (new_until_break_fsm): Remove.
6190         (until_break_fsm::should_stop): Rename from
6191         until_break_fsm_should_stop.
6192         (until_break_fsm::clean_up): Rename from
6193         until_break_fsm_clean_up.
6194         (until_break_fsm::do_async_reply_reason): Rename from
6195         until_break_fsm_async_reply_reason.
6196         (until_break_command): Update.
6197         * thread-fsm.c: Remove.
6198         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6199
6200 2019-02-07  Tom Tromey  <tom@tromey.com>
6201
6202         * yy-remap.h: Add include guard.
6203         * xtensa-tdep.h: Add include guard.
6204         * xcoffread.h: Rename include guard.
6205         * varobj-iter.h: Add include guard.
6206         * tui/tui.h: Rename include guard.
6207         * tui/tui-winsource.h: Rename include guard.
6208         * tui/tui-wingeneral.h: Rename include guard.
6209         * tui/tui-windata.h: Rename include guard.
6210         * tui/tui-win.h: Rename include guard.
6211         * tui/tui-stack.h: Rename include guard.
6212         * tui/tui-source.h: Rename include guard.
6213         * tui/tui-regs.h: Rename include guard.
6214         * tui/tui-out.h: Rename include guard.
6215         * tui/tui-layout.h: Rename include guard.
6216         * tui/tui-io.h: Rename include guard.
6217         * tui/tui-hooks.h: Rename include guard.
6218         * tui/tui-file.h: Rename include guard.
6219         * tui/tui-disasm.h: Rename include guard.
6220         * tui/tui-data.h: Rename include guard.
6221         * tui/tui-command.h: Rename include guard.
6222         * tic6x-tdep.h: Add include guard.
6223         * target/waitstatus.h: Rename include guard.
6224         * target/wait.h: Rename include guard.
6225         * target/target.h: Rename include guard.
6226         * target/resume.h: Rename include guard.
6227         * target-float.h: Rename include guard.
6228         * stabsread.h: Add include guard.
6229         * rs6000-tdep.h: Add include guard.
6230         * riscv-fbsd-tdep.h: Add include guard.
6231         * regformats/regdef.h: Rename include guard.
6232         * record.h: Rename include guard.
6233         * python/python.h: Rename include guard.
6234         * python/python-internal.h: Rename include guard.
6235         * python/py-stopevent.h: Rename include guard.
6236         * python/py-ref.h: Rename include guard.
6237         * python/py-record.h: Rename include guard.
6238         * python/py-record-full.h: Rename include guard.
6239         * python/py-record-btrace.h: Rename include guard.
6240         * python/py-instruction.h: Rename include guard.
6241         * python/py-events.h: Rename include guard.
6242         * python/py-event.h: Rename include guard.
6243         * procfs.h: Add include guard.
6244         * proc-utils.h: Add include guard.
6245         * p-lang.h: Add include guard.
6246         * or1k-tdep.h: Rename include guard.
6247         * observable.h: Rename include guard.
6248         * nto-tdep.h: Rename include guard.
6249         * nat/x86-linux.h: Rename include guard.
6250         * nat/x86-linux-dregs.h: Rename include guard.
6251         * nat/x86-gcc-cpuid.h: Add include guard.
6252         * nat/x86-dregs.h: Rename include guard.
6253         * nat/x86-cpuid.h: Rename include guard.
6254         * nat/ppc-linux.h: Rename include guard.
6255         * nat/mips-linux-watch.h: Rename include guard.
6256         * nat/linux-waitpid.h: Rename include guard.
6257         * nat/linux-ptrace.h: Rename include guard.
6258         * nat/linux-procfs.h: Rename include guard.
6259         * nat/linux-osdata.h: Rename include guard.
6260         * nat/linux-nat.h: Rename include guard.
6261         * nat/linux-namespaces.h: Rename include guard.
6262         * nat/linux-btrace.h: Rename include guard.
6263         * nat/glibc_thread_db.h: Rename include guard.
6264         * nat/gdb_thread_db.h: Rename include guard.
6265         * nat/gdb_ptrace.h: Rename include guard.
6266         * nat/fork-inferior.h: Rename include guard.
6267         * nat/amd64-linux-siginfo.h: Rename include guard.
6268         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6269         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6270         * nat/aarch64-linux.h: Rename include guard.
6271         * nat/aarch64-linux-hw-point.h: Rename include guard.
6272         * mn10300-tdep.h: Add include guard.
6273         * mips-linux-tdep.h: Add include guard.
6274         * mi/mi-parse.h: Rename include guard.
6275         * mi/mi-out.h: Rename include guard.
6276         * mi/mi-main.h: Rename include guard.
6277         * mi/mi-interp.h: Rename include guard.
6278         * mi/mi-getopt.h: Rename include guard.
6279         * mi/mi-console.h: Rename include guard.
6280         * mi/mi-common.h: Rename include guard.
6281         * mi/mi-cmds.h: Rename include guard.
6282         * mi/mi-cmd-break.h: Rename include guard.
6283         * m2-lang.h: Add include guard.
6284         * location.h: Rename include guard.
6285         * linux-record.h: Rename include guard.
6286         * linux-nat.h: Add include guard.
6287         * linux-fork.h: Add include guard.
6288         * i386-darwin-tdep.h: Rename include guard.
6289         * hppa-linux-offsets.h: Add include guard.
6290         * guile/guile.h: Rename include guard.
6291         * guile/guile-internal.h: Rename include guard.
6292         * gnu-nat.h: Rename include guard.
6293         * gdb-stabs.h: Rename include guard.
6294         * frv-tdep.h: Add include guard.
6295         * f-lang.h: Add include guard.
6296         * event-loop.h: Add include guard.
6297         * darwin-nat.h: Rename include guard.
6298         * cp-abi.h: Rename include guard.
6299         * config/sparc/nm-sol2.h: Rename include guard.
6300         * config/nm-nto.h: Rename include guard.
6301         * config/nm-linux.h: Add include guard.
6302         * config/i386/nm-i386gnu.h: Rename include guard.
6303         * config/djgpp/nl_types.h: Rename include guard.
6304         * config/djgpp/langinfo.h: Rename include guard.
6305         * compile/gcc-cp-plugin.h: Add include guard.
6306         * compile/gcc-c-plugin.h: Add include guard.
6307         * compile/compile.h: Rename include guard.
6308         * compile/compile-object-run.h: Rename include guard.
6309         * compile/compile-object-load.h: Rename include guard.
6310         * compile/compile-internal.h: Rename include guard.
6311         * compile/compile-cplus.h: Rename include guard.
6312         * compile/compile-c.h: Rename include guard.
6313         * common/xml-utils.h: Rename include guard.
6314         * common/x86-xstate.h: Rename include guard.
6315         * common/version.h: Rename include guard.
6316         * common/vec.h: Rename include guard.
6317         * common/tdesc.h: Rename include guard.
6318         * common/selftest.h: Rename include guard.
6319         * common/scoped_restore.h: Rename include guard.
6320         * common/scoped_mmap.h: Rename include guard.
6321         * common/scoped_fd.h: Rename include guard.
6322         * common/safe-iterator.h: Rename include guard.
6323         * common/run-time-clock.h: Rename include guard.
6324         * common/refcounted-object.h: Rename include guard.
6325         * common/queue.h: Rename include guard.
6326         * common/ptid.h: Rename include guard.
6327         * common/print-utils.h: Rename include guard.
6328         * common/preprocessor.h: Rename include guard.
6329         * common/pathstuff.h: Rename include guard.
6330         * common/observable.h: Rename include guard.
6331         * common/netstuff.h: Rename include guard.
6332         * common/job-control.h: Rename include guard.
6333         * common/host-defs.h: Rename include guard.
6334         * common/gdb_wait.h: Rename include guard.
6335         * common/gdb_vecs.h: Rename include guard.
6336         * common/gdb_unlinker.h: Rename include guard.
6337         * common/gdb_unique_ptr.h: Rename include guard.
6338         * common/gdb_tilde_expand.h: Rename include guard.
6339         * common/gdb_sys_time.h: Rename include guard.
6340         * common/gdb_string_view.h: Rename include guard.
6341         * common/gdb_splay_tree.h: Rename include guard.
6342         * common/gdb_setjmp.h: Rename include guard.
6343         * common/gdb_ref_ptr.h: Rename include guard.
6344         * common/gdb_optional.h: Rename include guard.
6345         * common/gdb_locale.h: Rename include guard.
6346         * common/gdb_assert.h: Rename include guard.
6347         * common/filtered-iterator.h: Rename include guard.
6348         * common/filestuff.h: Rename include guard.
6349         * common/fileio.h: Rename include guard.
6350         * common/environ.h: Rename include guard.
6351         * common/common-utils.h: Rename include guard.
6352         * common/common-types.h: Rename include guard.
6353         * common/common-regcache.h: Rename include guard.
6354         * common/common-inferior.h: Rename include guard.
6355         * common/common-gdbthread.h: Rename include guard.
6356         * common/common-exceptions.h: Rename include guard.
6357         * common/common-defs.h: Rename include guard.
6358         * common/common-debug.h: Rename include guard.
6359         * common/cleanups.h: Rename include guard.
6360         * common/buffer.h: Rename include guard.
6361         * common/btrace-common.h: Rename include guard.
6362         * common/break-common.h: Rename include guard.
6363         * cli/cli-utils.h: Rename include guard.
6364         * cli/cli-style.h: Rename include guard.
6365         * cli/cli-setshow.h: Rename include guard.
6366         * cli/cli-script.h: Rename include guard.
6367         * cli/cli-interp.h: Rename include guard.
6368         * cli/cli-decode.h: Rename include guard.
6369         * cli/cli-cmds.h: Rename include guard.
6370         * charset-list.h: Add include guard.
6371         * buildsym-legacy.h: Rename include guard.
6372         * bfin-tdep.h: Add include guard.
6373         * ax.h: Rename include guard.
6374         * arm-linux-tdep.h: Add include guard.
6375         * arm-fbsd-tdep.h: Add include guard.
6376         * arch/xtensa.h: Rename include guard.
6377         * arch/tic6x.h: Add include guard.
6378         * arch/i386.h: Add include guard.
6379         * arch/arm.h: Rename include guard.
6380         * arch/arm-linux.h: Rename include guard.
6381         * arch/arm-get-next-pcs.h: Rename include guard.
6382         * arch/amd64.h: Add include guard.
6383         * arch/aarch64-insn.h: Rename include guard.
6384         * arch-utils.h: Rename include guard.
6385         * annotate.h: Add include guard.
6386         * amd64-darwin-tdep.h: Rename include guard.
6387         * aarch64-linux-tdep.h: Add include guard.
6388         * aarch64-fbsd-tdep.h: Add include guard.
6389         * aarch32-linux-nat.h: Add include guard.
6390
6391 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6392
6393         * macrotab.c (macro_define_internal): New function that
6394         factorizes macro_define_object_internal and macro_define_function
6395         code.
6396         (macro_define_object_internal): Use macro_define_internal.
6397         (macro_define_function): Likewise.
6398
6399 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6400
6401         * macrocmd.c (extract_identifier): Return
6402         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6403         callers.
6404
6405 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6406
6407         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6408
6409 2019-02-05  Tom Tromey  <tom@tromey.com>
6410
6411         * target.c (target_stack::unpush): Move assertion earlier.
6412
6413 2019-01-30  Tom Tromey  <tom@tromey.com>
6414
6415         PR python/23615:
6416         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6417         (gdbpy_parse_and_eval): Likewise.
6418         * python/python-internal.h (gdbpy_allow_threads): New class.
6419
6420 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6421
6422         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6423         (aarch64_fbsd_fpregmap): Move earlier.
6424         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6425         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6426         instead of individual calls to trad_frame_set_reg_addr.
6427         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6428         earlier.
6429         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6430         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6431         instead of individual calls to trad_frame_set_reg_addr.
6432
6433 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6434
6435         * CONTRIBUTE: Replace contribution list with wiki link.
6436
6437 2019-01-25  Tom Tromey  <tom@tromey.com>
6438
6439         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6440
6441 2019-01-25  Tom Tromey  <tom@tromey.com>
6442
6443         * xtensa-linux-nat.c: Fix common/ includes.
6444         * xml-support.h: Fix common/ includes.
6445         * xml-support.c: Fix common/ includes.
6446         * x86-linux-nat.c: Fix common/ includes.
6447         * windows-nat.c: Fix common/ includes.
6448         * varobj.h: Fix common/ includes.
6449         * varobj.c: Fix common/ includes.
6450         * value.c: Fix common/ includes.
6451         * valops.c: Fix common/ includes.
6452         * utils.c: Fix common/ includes.
6453         * unittests/xml-utils-selftests.c: Fix common/ includes.
6454         * unittests/utils-selftests.c: Fix common/ includes.
6455         * unittests/unpack-selftests.c: Fix common/ includes.
6456         * unittests/tracepoint-selftests.c: Fix common/ includes.
6457         * unittests/style-selftests.c: Fix common/ includes.
6458         * unittests/string_view-selftests.c: Fix common/ includes.
6459         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6460         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6461         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6462         * unittests/rsp-low-selftests.c: Fix common/ includes.
6463         * unittests/parse-connection-spec-selftests.c: Fix common/
6464         includes.
6465         * unittests/optional-selftests.c: Fix common/ includes.
6466         * unittests/offset-type-selftests.c: Fix common/ includes.
6467         * unittests/observable-selftests.c: Fix common/ includes.
6468         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6469         * unittests/memrange-selftests.c: Fix common/ includes.
6470         * unittests/memory-map-selftests.c: Fix common/ includes.
6471         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6472         * unittests/function-view-selftests.c: Fix common/ includes.
6473         * unittests/environ-selftests.c: Fix common/ includes.
6474         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6475         * unittests/common-utils-selftests.c: Fix common/ includes.
6476         * unittests/cli-utils-selftests.c: Fix common/ includes.
6477         * unittests/array-view-selftests.c: Fix common/ includes.
6478         * ui-file.c: Fix common/ includes.
6479         * tui/tui-io.c: Fix common/ includes.
6480         * tracepoint.h: Fix common/ includes.
6481         * tracepoint.c: Fix common/ includes.
6482         * tracefile-tfile.c: Fix common/ includes.
6483         * top.h: Fix common/ includes.
6484         * top.c: Fix common/ includes.
6485         * thread.c: Fix common/ includes.
6486         * target/waitstatus.h: Fix common/ includes.
6487         * target/waitstatus.c: Fix common/ includes.
6488         * target.h: Fix common/ includes.
6489         * target.c: Fix common/ includes.
6490         * target-memory.c: Fix common/ includes.
6491         * target-descriptions.c: Fix common/ includes.
6492         * symtab.h: Fix common/ includes.
6493         * symfile.c: Fix common/ includes.
6494         * stap-probe.c: Fix common/ includes.
6495         * spu-linux-nat.c: Fix common/ includes.
6496         * sparc-nat.c: Fix common/ includes.
6497         * source.c: Fix common/ includes.
6498         * solib.c: Fix common/ includes.
6499         * solib-target.c: Fix common/ includes.
6500         * ser-unix.c: Fix common/ includes.
6501         * ser-tcp.c: Fix common/ includes.
6502         * ser-pipe.c: Fix common/ includes.
6503         * ser-base.c: Fix common/ includes.
6504         * selftest-arch.c: Fix common/ includes.
6505         * s12z-tdep.c: Fix common/ includes.
6506         * rust-exp.y: Fix common/ includes.
6507         * rs6000-aix-tdep.c: Fix common/ includes.
6508         * riscv-tdep.c: Fix common/ includes.
6509         * remote.c: Fix common/ includes.
6510         * remote-notif.h: Fix common/ includes.
6511         * remote-fileio.h: Fix common/ includes.
6512         * remote-fileio.c: Fix common/ includes.
6513         * regcache.h: Fix common/ includes.
6514         * regcache.c: Fix common/ includes.
6515         * record-btrace.c: Fix common/ includes.
6516         * python/python.c: Fix common/ includes.
6517         * python/py-type.c: Fix common/ includes.
6518         * python/py-inferior.c: Fix common/ includes.
6519         * progspace.h: Fix common/ includes.
6520         * producer.c: Fix common/ includes.
6521         * procfs.c: Fix common/ includes.
6522         * proc-api.c: Fix common/ includes.
6523         * printcmd.c: Fix common/ includes.
6524         * ppc-linux-nat.c: Fix common/ includes.
6525         * parser-defs.h: Fix common/ includes.
6526         * osdata.c: Fix common/ includes.
6527         * obsd-nat.c: Fix common/ includes.
6528         * nat/x86-linux.c: Fix common/ includes.
6529         * nat/x86-linux-dregs.c: Fix common/ includes.
6530         * nat/x86-dregs.h: Fix common/ includes.
6531         * nat/x86-dregs.c: Fix common/ includes.
6532         * nat/ppc-linux.c: Fix common/ includes.
6533         * nat/mips-linux-watch.h: Fix common/ includes.
6534         * nat/mips-linux-watch.c: Fix common/ includes.
6535         * nat/linux-waitpid.c: Fix common/ includes.
6536         * nat/linux-ptrace.h: Fix common/ includes.
6537         * nat/linux-ptrace.c: Fix common/ includes.
6538         * nat/linux-procfs.c: Fix common/ includes.
6539         * nat/linux-personality.c: Fix common/ includes.
6540         * nat/linux-osdata.c: Fix common/ includes.
6541         * nat/linux-namespaces.c: Fix common/ includes.
6542         * nat/linux-btrace.h: Fix common/ includes.
6543         * nat/linux-btrace.c: Fix common/ includes.
6544         * nat/fork-inferior.c: Fix common/ includes.
6545         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6546         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6547         * nat/aarch64-linux.c: Fix common/ includes.
6548         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6549         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6550         * namespace.h: Fix common/ includes.
6551         * mips-linux-tdep.c: Fix common/ includes.
6552         * minsyms.c: Fix common/ includes.
6553         * mi/mi-parse.h: Fix common/ includes.
6554         * mi/mi-main.c: Fix common/ includes.
6555         * mi/mi-cmd-env.c: Fix common/ includes.
6556         * memrange.h: Fix common/ includes.
6557         * memattr.c: Fix common/ includes.
6558         * maint.h: Fix common/ includes.
6559         * maint.c: Fix common/ includes.
6560         * main.c: Fix common/ includes.
6561         * machoread.c: Fix common/ includes.
6562         * location.c: Fix common/ includes.
6563         * linux-thread-db.c: Fix common/ includes.
6564         * linux-nat.c: Fix common/ includes.
6565         * linux-fork.c: Fix common/ includes.
6566         * inline-frame.c: Fix common/ includes.
6567         * infrun.c: Fix common/ includes.
6568         * inflow.c: Fix common/ includes.
6569         * inferior.h: Fix common/ includes.
6570         * inferior.c: Fix common/ includes.
6571         * infcmd.c: Fix common/ includes.
6572         * inf-ptrace.c: Fix common/ includes.
6573         * inf-child.c: Fix common/ includes.
6574         * ia64-linux-nat.c: Fix common/ includes.
6575         * i387-tdep.c: Fix common/ includes.
6576         * i386-tdep.c: Fix common/ includes.
6577         * i386-linux-tdep.c: Fix common/ includes.
6578         * i386-linux-nat.c: Fix common/ includes.
6579         * i386-go32-tdep.c: Fix common/ includes.
6580         * i386-fbsd-tdep.c: Fix common/ includes.
6581         * i386-fbsd-nat.c: Fix common/ includes.
6582         * guile/scm-type.c: Fix common/ includes.
6583         * guile/guile.c: Fix common/ includes.
6584         * go32-nat.c: Fix common/ includes.
6585         * gnu-nat.c: Fix common/ includes.
6586         * gdbthread.h: Fix common/ includes.
6587         * gdbarch-selftests.c: Fix common/ includes.
6588         * gdb_usleep.c: Fix common/ includes.
6589         * gdb_select.h: Fix common/ includes.
6590         * gdb_bfd.c: Fix common/ includes.
6591         * gcore.c: Fix common/ includes.
6592         * fork-child.c: Fix common/ includes.
6593         * findvar.c: Fix common/ includes.
6594         * fbsd-nat.c: Fix common/ includes.
6595         * event-top.c: Fix common/ includes.
6596         * event-loop.c: Fix common/ includes.
6597         * dwarf2read.c: Fix common/ includes.
6598         * dwarf2loc.c: Fix common/ includes.
6599         * dwarf2-frame.c: Fix common/ includes.
6600         * dwarf-index-cache.c: Fix common/ includes.
6601         * dtrace-probe.c: Fix common/ includes.
6602         * disasm-selftests.c: Fix common/ includes.
6603         * defs.h: Fix common/ includes.
6604         * csky-tdep.c: Fix common/ includes.
6605         * cp-valprint.c: Fix common/ includes.
6606         * cp-support.h: Fix common/ includes.
6607         * cp-support.c: Fix common/ includes.
6608         * corelow.c: Fix common/ includes.
6609         * completer.h: Fix common/ includes.
6610         * completer.c: Fix common/ includes.
6611         * compile/compile.c: Fix common/ includes.
6612         * compile/compile-loc2c.c: Fix common/ includes.
6613         * compile/compile-cplus-types.c: Fix common/ includes.
6614         * compile/compile-cplus-symbols.c: Fix common/ includes.
6615         * command.h: Fix common/ includes.
6616         * cli/cli-dump.c: Fix common/ includes.
6617         * cli/cli-cmds.c: Fix common/ includes.
6618         * charset.c: Fix common/ includes.
6619         * build-id.c: Fix common/ includes.
6620         * btrace.h: Fix common/ includes.
6621         * btrace.c: Fix common/ includes.
6622         * breakpoint.h: Fix common/ includes.
6623         * breakpoint.c: Fix common/ includes.
6624         * ax.h:
6625         (enum agent_op): Fix common/ includes.
6626         * ax-general.c (struct aop_map): Fix common/ includes.
6627         * ax-gdb.c: Fix common/ includes.
6628         * auxv.c: Fix common/ includes.
6629         * auto-load.c: Fix common/ includes.
6630         * arm-tdep.c: Fix common/ includes.
6631         * arch/riscv.c: Fix common/ includes.
6632         * arch/ppc-linux-common.c: Fix common/ includes.
6633         * arch/i386.c: Fix common/ includes.
6634         * arch/arm.c: Fix common/ includes.
6635         * arch/arm-linux.c: Fix common/ includes.
6636         * arch/arm-get-next-pcs.c: Fix common/ includes.
6637         * arch/amd64.c: Fix common/ includes.
6638         * arch/aarch64.c: Fix common/ includes.
6639         * arch/aarch64-insn.c: Fix common/ includes.
6640         * arch-utils.c: Fix common/ includes.
6641         * amd64-windows-tdep.c: Fix common/ includes.
6642         * amd64-tdep.c: Fix common/ includes.
6643         * amd64-sol2-tdep.c: Fix common/ includes.
6644         * amd64-obsd-tdep.c: Fix common/ includes.
6645         * amd64-nbsd-tdep.c: Fix common/ includes.
6646         * amd64-linux-tdep.c: Fix common/ includes.
6647         * amd64-linux-nat.c: Fix common/ includes.
6648         * amd64-fbsd-tdep.c: Fix common/ includes.
6649         * amd64-fbsd-nat.c: Fix common/ includes.
6650         * amd64-dicos-tdep.c: Fix common/ includes.
6651         * amd64-darwin-tdep.c: Fix common/ includes.
6652         * agent.c: Fix common/ includes.
6653         * ada-lang.h: Fix common/ includes.
6654         * ada-lang.c: Fix common/ includes.
6655         * aarch64-tdep.c: Fix common/ includes.
6656
6657 2019-01-25  Tom Tromey  <tom@tromey.com>
6658
6659         * common/create-version.sh: Use common/version.h.
6660
6661 2019-01-24  Pedro Alves  <palves@redhat.com>
6662
6663         * infrun.c (signal_stop, signal_print, signal_program)
6664         (signal_catch, signal_pass): Now arrays instead of pointers.
6665         (update_signals_program_target, do_target_resume)
6666         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6667         * linux-nat.c (linux_nat_target::pass_signals)
6668         (linux_nat_target::create_inferior, linux_nat_target::attach):
6669         Adjust.
6670         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6671         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6672         * procfs.c (procfs_target::pass_signals): Adjust.
6673         * record-full.c (record_full_target::resume): Adjust.
6674         * remote.c (remote_target::pass_signals)
6675         (remote_target::program_signals): Adjust.
6676         * target-debug.h (target_debug_print_signals): Now takes a
6677         gdb::array_view as parameter.  Adjust.
6678         * target.h (target_ops) <pass_signals, program_signals>: Replace
6679         pointer and length parameters with gdb::array_view.
6680         (target_pass_signals, target_program_signals): Likewise.
6681         * target-delegates.c: Regenerate.
6682
6683 2019-01-24  Pedro Alves  <palves@redhat.com>
6684
6685         * common/forward-scope-exit.h
6686         (forward_scope_exit::forward_scope_exit): Pass arguments to
6687         m_bind_function directly, instead of creating a std::bind and
6688         copying that.
6689
6690 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6691
6692         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6693         for static members.
6694         (pass_in_v_vfp_candidate): Likewise.
6695
6696 2019-01-23  Tom Tromey  <tom@tromey.com>
6697             Pedro Alves  <palves@redhat.com>
6698
6699         * regcache.c (class regcache_invalidator): Remove.
6700         (regcache::raw_write): Use make_scope_exit.
6701
6702 2019-01-23  Tom Tromey  <tom@tromey.com>
6703
6704         * ui-out.h (class ui_out_emit_type): Update comment.
6705
6706 2019-01-23  Tom Tromey  <tom@tromey.com>
6707
6708         * infrun.c (fetch_inferior_event): Update comment.
6709
6710 2019-01-23  Tom Tromey  <tom@tromey.com>
6711             Pedro Alves  <palves@redhat.com>
6712
6713         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6714         parameter.
6715         (fetch_inferior_event): Use SCOPE_EXIT.
6716
6717
6718 2019-01-23  Tom Tromey  <tom@tromey.com>
6719             Pedro Alves  <palves@redhat.com>
6720
6721         * infrun.c (disable_thread_events): Delete.
6722         (stop_all_threads): Use SCOPE_EXIT.
6723
6724 2019-01-23  Tom Tromey  <tom@tromey.com>
6725             Pedro Alves  <palves@redhat.com>
6726
6727         * symfile.c: Include forward-scope-exit.h.
6728         (clear_symtab_users_cleanup): Replace forward declaration with
6729         a FORWARD_SCOPE_EXIT.
6730         (syms_from_objfile_1): Use the forward_scope_exit and
6731         gdb::optional instead of cleanup_function.
6732         (reread_symbols): Use the forward_scope_exit instead of
6733         cleanup_function.
6734         (clear_symtab_users_cleanup): Remove function.
6735
6736 2019-01-23  Tom Tromey  <tom@tromey.com>
6737             Pedro Alves  <palves@redhat.com>
6738
6739         * linux-nat.c: Include scope-exit.h.
6740         (cleanup_target_stop): Remove.
6741         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6742         SCOPE_EXIT.
6743
6744 2019-01-23  Tom Tromey  <tom@tromey.com>
6745             Pedro Alves  <palves@redhat.com>
6746
6747         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6748         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6749
6750 2019-01-23  Tom Tromey  <tom@tromey.com>
6751             Andrew Burgess  <andrew.burgess@embecosm.com>
6752             Pedro Alves  <palves@redhat.com>
6753
6754         * infrun.c (fetch_inferior_event): Use scope_exit.
6755         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6756         * top.c (execute_command): Use scope_exit.
6757         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6758         * utils.c (do_bpstat_clear_actions_cleanup)
6759         (make_bpstat_clear_actions_cleanup): Remove.
6760
6761 2019-01-23  Tom Tromey  <tom@tromey.com>
6762             Pedro Alves  <palves@redhat.com>
6763
6764         * infrun.c: Include "common/scope-exit.h"
6765         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6766         (wait_for_inferior): Use SCOPE_EXIT.
6767         (fetch_inferior_event): Use scope_exit.
6768
6769 2019-01-23  Tom Tromey  <tom@tromey.com>
6770             Pedro Alves  <palves@redhat.com>
6771
6772         * breakpoint.c (create_breakpoint): Remove cleanup.
6773
6774 2019-01-23  Tom Tromey  <tom@tromey.com>
6775             Andrew Burgess  <andrew.burgess@embecosm.com>
6776             Pedro Alves  <palves@redhat.com>
6777
6778 2019-01-23  Pedro Alves  <palves@redhat.com>
6779
6780         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6781
6782 2019-01-23  Pedro Alves  <palves@redhat.com>
6783             Andrew Burgess  <andrew.burgess@embecosm.com>
6784
6785         * gdbthread.h: Include "common/forward-scope-exit.h".
6786         (scoped_finish_thread_state): Redefine custom class in terms of
6787         forward_scope_exit.
6788
6789 2019-01-23  Pedro Alves  <palves@redhat.com>
6790             Andrew Burgess  <andrew.burgess@embecosm.com>
6791
6792         * common/forward-scope-exit.h: New file.
6793
6794 2019-01-23  Pedro Alves  <palves@redhat.com>
6795             Andrew Burgess  <andrew.burgess@embecosm.com>
6796             Tom Tromey  <tom@tromey.com>
6797
6798         * common/scope-exit.h: New file.
6799
6800 2019-01-23  Pedro Alves  <palves@redhat.com>
6801
6802         * common/preprocessor.h (ESC): Rename to ...
6803         (ESC_PARENS): ... this.
6804         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6805         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6806
6807 2019-01-23  Tom Tromey  <tom@tromey.com>
6808
6809         * language.h (class scoped_switch_to_sym_language_if_auto):
6810         Initialize m_lang in both cases.
6811
6812 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6813
6814         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6815         with XCNEW.
6816
6817 2019-01-22  Tom Tromey  <tom@tromey.com>
6818
6819         * corelow.c: Do not include sys/file.h.
6820
6821 2019-01-22  Tom Tromey  <tom@tromey.com>
6822
6823         * tui/tui-wingeneral.h: Include gdb_curses.h.
6824
6825 2019-01-22  Tom Tromey  <tom@tromey.com>
6826
6827         * source-cache.h (class source_cache) <get_source_lines,
6828         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6829
6830 2019-01-22  Tom Tromey  <tom@tromey.com>
6831
6832         * remote-fileio.h (struct remote_target): Declare.
6833
6834 2019-01-22  Tom Tromey  <tom@tromey.com>
6835
6836         * python/py-arch.c: Do not include py-ref.h.
6837         * python/py-bpevent.c: Do not include py-ref.h.
6838         * python/py-cmd.c: Do not include py-ref.h.
6839         * python/py-continueevent.c: Do not include py-ref.h.
6840         * python/py-event.h: Do not include py-ref.h.
6841         * python/py-evtregistry.c: Do not include py-ref.h.
6842         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6843         * python/py-frame.c: Do not include py-ref.h.
6844         * python/py-framefilter.c: Do not include py-ref.h.
6845         * python/py-function.c: Do not include py-ref.h.
6846         * python/py-infevents.c: Do not include py-ref.h.
6847         * python/py-linetable.c: Do not include py-ref.h.
6848         * python/py-objfile.c: Do not include py-ref.h.
6849         * python/py-param.c: Do not include py-ref.h.
6850         * python/py-prettyprint.c: Do not include py-ref.h.
6851         * python/py-progspace.c: Do not include py-ref.h.
6852         * python/py-symbol.c: Do not include py-ref.h.
6853         * python/py-symtab.c: Do not include py-ref.h.
6854         * python/py-type.c: Do not include py-ref.h.
6855         * python/py-unwind.c: Do not include py-ref.h.
6856         * python/py-utils.c: Do not include py-ref.h.
6857         * python/py-value.c: Do not include py-ref.h.
6858         * python/py-varobj.c: Do not include py-ref.h.
6859         * python/py-xmethods.c: Do not include py-ref.h.
6860         * python/python.c: Do not include py-ref.h.
6861         * varobj.c: Do not include py-ref.h.
6862
6863 2019-01-22  Tom Tromey  <tom@tromey.com>
6864
6865         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6866         keyword for bcache.
6867
6868 2019-01-22  Tom Tromey  <tom@tromey.com>
6869
6870         * compile/compile-cplus-types.c: Remove a comment by #include.
6871
6872 2019-01-22  Tom Tromey  <tom@tromey.com>
6873
6874         * compile/gcc-c-plugin.h: Include compile-internal.h.
6875
6876 2019-01-22  Tom Tromey  <tom@tromey.com>
6877
6878         * stabsread.c (EXTERN): Do not define.
6879         (symnum, next_symbol_text_func, processing_gcc_compilation)
6880         (within_function, global_sym_chain, global_stabs)
6881         (previous_stab_code, this_object_header_files)
6882         (n_this_object_header_files)
6883         (n_allocated_this_object_header_files): Define.
6884         * stabsread.h (EXTERN): Never define.  Use "extern".
6885
6886 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6887
6888         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6889         history_value.
6890
6891 2019-01-21  Tom Tromey  <tom@tromey.com>
6892
6893         * ui-out.c: Fix includes.
6894         * tui/tui-source.c: Fix includes.
6895         * target.c: Fix includes.
6896         * remote.c: Fix includes.
6897         * regcache.c: Fix includes.
6898         * python/py-block.c: Fix includes.
6899         * printcmd.c: Fix includes.
6900         * or1k-tdep.c: Fix includes.
6901         * mi/mi-main.c: Fix includes.
6902         * m32r-tdep.c: Fix includes.
6903         * csky-tdep.c: Fix includes.
6904         * compile/compile-cplus-types.c: Fix includes.
6905         * cli/cli-interp.c: Fix includes.
6906
6907 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6908
6909         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6910         for padding.
6911
6912 2019-01-16  Tom Tromey  <tom@tromey.com>
6913
6914         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6915         earlier.
6916         (struct objfile) <msymbols_range>: Move from top level.
6917         <msymbols>: New method.
6918         (class objfile_msymbols): Remove.
6919         * symtab.c (default_collect_symbol_completion_matches_break_on):
6920         Update.
6921         * symmisc.c (dump_msymbols): Update.
6922         * stabsread.c (scan_file_globals): Update.
6923         * objc-lang.c (info_selectors_command, info_classes_command)
6924         (find_methods): Update.
6925         * minsyms.c (find_solib_trampoline_target): Update.
6926         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6927         * coffread.c (coff_symfile_read): Update.
6928         * ada-lang.c (ada_lookup_simple_minsym)
6929         (ada_collect_symbol_completion_matches): Update.
6930
6931 2019-01-16  Tom Tromey  <tom@tromey.com>
6932
6933         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6934         type.  Remove no-argument constructor.
6935         <iterator::operator++>: Simplify.
6936         <begin>: Update.
6937         <end>: Use minimal_symbol_count.
6938
6939 2019-01-16  Tom Tromey  <tom@tromey.com>
6940
6941         * objfiles.h (struct objfile) <psymtabs>: New method.
6942         (class objfile_psymtabs): Remove.
6943         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6944         typedef.
6945         <range>: New method.
6946         (require_partial_symbols): Change return type.
6947         * psymtab.c (require_partial_symbols)
6948         (psym_expand_symtabs_matching): Update.
6949         * mdebugread.c (parse_partial_symbols): Update.
6950         * dbxread.c (dbx_end_psymtab): Update.
6951
6952 2019-01-15  Tom Tromey  <tom@tromey.com>
6953
6954         * symtab.c (lookup_objfile_from_block)
6955         (lookup_symbol_in_objfile_symtabs)
6956         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6957         (find_line_symtab, info_sources_command)
6958         (default_collect_symbol_completion_matches_break_on)
6959         (make_source_files_completion_list): Update.
6960         * symmisc.c (print_objfile_statistics, dump_objfile)
6961         (maintenance_print_symbols, maintenance_info_symtabs)
6962         (maintenance_check_symtabs, maintenance_info_line_tables):
6963         Update.
6964         * source.c (select_source_symtab)
6965         (forget_cached_source_info_for_objfile): Update.
6966         * objfiles.h (class objfile_compunits): Remove.
6967         (struct objfile) <compunits_range>: New typedef.
6968         (compunits): New method.
6969         * objfiles.c (objfile_relocate1): Update.
6970         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6971         * maint.c (count_symtabs_and_blocks): Update.
6972         * linespec.c (iterate_over_all_matching_symtabs): Update.
6973         * cp-support.c (add_symbol_overload_list_qualified): Update.
6974         * coffread.c (coff_symtab_read): Update.
6975         * ada-lang.c (add_nonlocal_symbols)
6976         (ada_collect_symbol_completion_matches)
6977         (ada_add_global_exceptions): Update.
6978
6979 2019-01-15  Tom Tromey  <tom@tromey.com>
6980
6981         * progspace.h (program_space) <objfiles_safe_range>: New
6982         typedef.
6983         <objfiles_safe>: New method.
6984         * objfiles.h (class all_objfiles_safe): Remove.
6985         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6986         * jit.c (jit_inferior_exit_hook): Update.
6987
6988 2019-01-17  Tom Tromey  <tom@tromey.com>
6989
6990         * progspace.h (program_space) <objfiles_range>: New typedef.
6991         <objfiles>: New method.
6992         <objfiles_head>: Rename from objfiles.
6993         (object_files): Update.
6994         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6995         * guile/scm-pretty-print.c
6996         (ppscm_find_pretty_printer_from_objfiles): Update.
6997         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6998         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6999         Update.
7000         * python/py-progspace.c (pspy_get_objfiles): Update.
7001         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7002         Update.
7003         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7004         (objfpy_lookup_objfile_by_build_id): Update.
7005         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7006         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7007         Update.
7008         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7009         (expand_symtab_containing_pc, lookup_objfile_from_block)
7010         (lookup_static_symbol, basic_lookup_transparent_type)
7011         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7012         (find_line_symtab, info_sources_command)
7013         (default_collect_symbol_completion_matches_break_on)
7014         (make_source_files_completion_list, find_main_name): Update.
7015         * symmisc.c (print_symbol_bcache_statistics)
7016         (print_objfile_statistics, maintenance_print_symbols)
7017         (maintenance_print_msymbols, maintenance_print_objfiles)
7018         (maintenance_info_symtabs, maintenance_check_symtabs)
7019         (maintenance_expand_symtabs, maintenance_info_line_tables):
7020         Update.
7021         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7022         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7023         (map_overlay_command, unmap_overlay_command)
7024         (simple_overlay_update, expand_symtabs_matching)
7025         (map_symbol_filenames): Update.
7026         * symfile-debug.c (set_debug_symfile): Update.
7027         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7028         Update.
7029         * source.c (select_source_symtab, forget_cached_source_info):
7030         Update.
7031         * solib.c (solib_read_symbols): Update.
7032         * solib-spu.c (append_ocl_sos): Update.
7033         * psymtab.c (maintenance_print_psymbols)
7034         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7035         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7036         * printcmd.c (info_symbol_command): Update.
7037         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7038         Update.
7039         * objfiles.h (class all_objfiles): Remove.
7040         * objfiles.c (have_partial_symbols, have_full_symbols)
7041         (have_minimal_symbols, qsort_cmp, update_section_map)
7042         (shared_objfile_contains_address_p)
7043         (default_iterate_over_objfiles_in_search_order): Update.
7044         * objc-lang.c (info_selectors_command, info_classes_command)
7045         (find_methods): Update.
7046         * minsyms.c (find_solib_trampoline_target): Update.
7047         * maint.c (maintenance_info_sections)
7048         (maintenance_translate_address, count_symtabs_and_blocks):
7049         Update.
7050         * main.c (captured_main_1): Update.
7051         * linux-thread-db.c (try_thread_db_load_from_pdir)
7052         (has_libpthread): Update.
7053         * linespec.c (iterate_over_all_matching_symtabs)
7054         (search_minsyms_for_name): Update.
7055         * jit.c (jit_find_objf_with_entry_addr): Update.
7056         * hppa-tdep.c (find_unwind_entry)
7057         (hppa_lookup_stub_minimal_symbol): Update.
7058         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7059         Update.
7060         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7061         (elf_gnu_ifunc_resolve_by_got): Update.
7062         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7063         * dwarf-index-write.c (save_gdb_index_command): Update.
7064         * cp-support.c (add_symbol_overload_list_qualified): Update.
7065         * breakpoint.c (create_overlay_event_breakpoint)
7066         (create_longjmp_master_breakpoint)
7067         (create_std_terminate_master_breakpoint)
7068         (create_exception_master_breakpoint): Update.
7069         * blockframe.c (find_pc_partial_function): Update.
7070         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7071         (ada_collect_symbol_completion_matches)
7072         (ada_add_global_exceptions): Update.
7073
7074 2019-01-17  Tom Tromey  <tom@tromey.com>
7075
7076         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7077         declare VEC.
7078         (solib_target_parse_libraries): Change return type.
7079         (library_list_start_segment, library_list_start_section)
7080         (library_list_end_library, library_list_start_library); Update.
7081         (solib_target_free_library_list): Remove.
7082         (solib_target_parse_libraries): Remove cleanup.  Change return
7083         type.
7084         (solib_target_current_sos): Update.
7085
7086 2019-01-17  Tom Tromey  <tromey@bapiya>
7087
7088         * valprint.c: Replace "the the" with "the".
7089         * symtab.c: Replace "the the" with "the".
7090         * solib.c: Replace "the the" with "the".
7091         * solib-dsbt.c: Replace "the the" with "the".
7092         * linespec.c: Replace "the the" with "the".
7093         * dwarf2loc.h: Replace "the the" with "the".
7094         * amd64-windows-tdep.c: Replace "the the" with "the".
7095         * aarch64-tdep.c: Replace "the the" with "the".
7096
7097 2019-01-16  Keith Seitz  <keiths@redhat.com>
7098
7099         PR gdb/23773
7100         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7101         <builder>: Rename to ..
7102         <m_builder>: ... this and make private.
7103         (dwarf2_cu::get_builder): New method.  Change all users of
7104         `builder' to use this method.
7105         (dwarf2_start_symtab): Move to ...
7106         (dwarf2_cu::start_symtab): ... here.  Update all callers
7107         (setup_type_unit_groups): Move to ...
7108         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7109         callers.
7110         (dwarf2_cu::reset_builder): New method.
7111         (process_full_compunit, process_full_type_unit): Use
7112         dwarf2_cu::reset_builder.
7113         (follow_die_offset): Record the ancestor CU if it is different
7114         from the followed DIE's CU.
7115         (follow_die_sig_1): Likewise.
7116
7117 2019-01-15  Tom Tromey  <tom@tromey.com>
7118
7119         * remote.c (class remote_state) <buf>: Now a char_vector.
7120         <buf_size>: Remove.
7121         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7122         parameter.
7123         (remote_target::getpkt_or_notif_sane_1)
7124         (remote_target::getpkt_sane)
7125         (remote_target::getpkt_or_notif_sane): Likewise.
7126         (class remote_target) <putpkt>: New overload.
7127         (remote_target::read_frame): Change type of "buf_p".  Remove
7128         sizeof_p parameter.
7129         (packet_ok): New overload.
7130         (packet_check_result): New overload.
7131         Update all uses.
7132
7133 2019-01-14  Tom Tromey  <tom@tromey.com>
7134
7135         * remote-notif.c (handle_notification, remote_notif_ack)
7136         (remote_notif_parse): Make "buf" const.
7137         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7138         const.
7139         (remote_notif_parse, remote_notif_ack, handle_notification):
7140         Likewise.
7141         * remote.c (remote_notif_stop_parse): Make "buf" const.
7142         (remote_target::remote_parse_stop_reply): Make "buf" const.
7143         (remote_notif_stop_ack): Make "buf" const.
7144
7145 2019-01-14  Tom Tromey  <tom@tromey.com>
7146
7147         * remote.c (remote_console_output): Make parameter const.
7148
7149 2019-01-14  Tom Tromey  <tom@tromey.com>
7150
7151         * target-debug.h (target_debug_print_signals): Constify.
7152         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7153         * procfs.c (procfs_target::pass_signals): Update.
7154         * linux-nat.c (linux_nat_target::pass_signals): Update.
7155         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7156         * target-delegates.c: Rebuild.
7157         * remote.c (remote_target::program_signals): Update.
7158         (remote_target::pass_signals): Update.
7159         * target.c (target_pass_signals): Constify argument.
7160         (target_program_signals): Likewise.
7161         * target.h (struct target_ops) <pass_signals, program_signals>:
7162         Constify argument.
7163         (target_pass_signals, target_program_signals): Constify argument.
7164
7165 2019-01-14  Tom Tromey  <tom@tromey.com>
7166
7167         PR tui/28819:
7168         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7169
7170 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7171
7172         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7173         field.
7174         * rs6000-tdep.c: Include reggroups.h.
7175         (IS_V_ALIAS_PSEUDOREG): Define.
7176         (rs6000_register_name): Return names for the "vX" aliases.
7177         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7178         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7179         aliases.  Call default_register_reggroup_p for all other
7180         pseudo-registers.
7181         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7182         New functions.
7183         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7184         Handle "vX" aliases.
7185         (v_alias_pseudo_register_collect): New function.
7186         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7187         (rs6000_gdbarch_init): Initialize "vX" aliases as
7188         pseudo-registers.  Restore registration of
7189         rs6000_pseudo_register_reggroup_p with
7190         set_tdesc_pseudo_register_reggroup_p.
7191
7192 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7193
7194         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7195         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7196         set_gdbarch_num_pseudo_regs.
7197
7198 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7199
7200         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7201         Remove arg prefixname, add do_set and do_show.
7202         Add member functions set_list and show_list.
7203         * cli/cli-style.c (class cli_style_option): Update accordingly.
7204         (style_set_list): Move to file scope.
7205         (style_show_list): Likewise.
7206         (set_style): Call help_list.
7207         (show_style): Call cmd_show_list.
7208         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7209         Update to use the new macro.
7210
7211 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7212
7213         * ada-lang.c (_initialize_ada_language): Expand the help text
7214         for the "catch exception" command.
7215
7216 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7217
7218         * symtab.c (matching_obj_sections): Initialize obj,
7219         declare it closer to its usage.
7220
7221 2019-01-10  Tom Tromey  <tom@tromey.com>
7222
7223         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7224         (basic_inf_threads_range): Remove.
7225         (inf_threads_range, inf_non_exited_threads_range)
7226         (safe_inf_threads_range): Use next_adapter.
7227
7228 2019-01-10  Keith Seitz  <keiths@redhat.com>
7229
7230         PR gdb/23712
7231         PR symtab/23010
7232         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7233         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7234
7235 2019-01-10  Keith Seitz  <keiths@redhat.com>
7236
7237         PR gdb/23712
7238         PR symtab/23010
7239         * dictionary.c (pending_to_vector): Remove.
7240         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7241         Remove _1 suffix, replacing functions of the same name.  Update
7242         all callers.
7243         (dict_create_hashed, dict_create_hashed_expandable)
7244         (dict_create_linear, dict_create_linear_expandable, dict_free)
7245         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7246         Make functions static.
7247
7248 2019-01-10  Keith Seitz  <keiths@redhat.com>
7249
7250         PR gdb/23712
7251         PR symtab/23010
7252         * dictionary.h (struct dictionary): Replace declaration with
7253         multidictionary.
7254         (dict_create_hashed, dict_create_hashed_expandable)
7255         (dict_create_linear, dict_create_linear_expandable)
7256         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7257         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7258         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7259         taking multidictionary argument.
7260         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7261         * block.h (struct block) <dict>: Change to multidictionary
7262         and rename `multidict'.
7263         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7264         symmisc.c: Update all dictionary references to multidictionary.
7265
7266 2019-01-10  Keith Seitz  <keiths@redhat.com>
7267
7268         PR gdb/23712
7269         PR symtab/23010
7270         * dictionary.c: Include unordered_map.
7271         (pending_to_vector): New function.
7272         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7273         Rewrite the non-"_1" functions to take vector instead
7274         of linked list.
7275         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7276         "new" _1 versions of the same name.
7277         (multidictionary): Define.
7278         (std::hash<enum language): New definition.
7279         (collate_pending_symbols_by_language, mdict_create_hashed)
7280         (mdict_create_hashed_expandable, mdict_create_linear)
7281         (mdict_create_linear_expandable, mdict_free)
7282         (find_language_dictionary, create_new_language_dictionary)
7283         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7284         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7285         (mdict_size, mdict_empty): New functions.
7286         * dictionary.h (mdict_iterator): Define.
7287
7288 2019-01-10  Pedro Alves  <palves@redhat.com>
7289
7290         * breakpoint.c (read_uploaded_action)
7291         (create_tracepoint_from_upload): Adjust to use
7292         gdb::unique_xmalloc_ptr.
7293         * ctf.c (ctf_write_uploaded_tp):
7294         (SET_ARRAY_FIELD): Use emplace_back.
7295         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7296         * tracefile-tfile.c (tfile_write_uploaded_tp):
7297         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7298         gdb::unique_xmalloc_ptr.
7299         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7300         at_string, cond_string, cmd_strings>: Replace char pointers
7301         with gdb::unique_xmalloc_ptr.
7302
7303 2019-01-10  Pedro Alves  <palves@redhat.com>
7304
7305         * solib-target.c (library_list_start_library): Don't xstrdup name.
7306
7307 2019-01-10  Pedro Alves  <palves@redhat.com>
7308
7309         * mdebugread.c (parse_partial_symbols): Use
7310         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7311
7312 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7313
7314         * linux-fork.c (scoped_switch_fork_info)
7315         <~scoped_switch_fork_info>: Fix incorrect variable name.
7316
7317 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7318
7319         * linux-fork.c (scoped_switch_fork_info)
7320         <scoped_switch_fork_info>: Make explicit.
7321         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7322
7323 2019-01-10  Tom Tromey  <tom@tromey.com>
7324
7325         * objfiles.h (objfile::reset_psymtabs): Update.
7326         * objfiles.c (objfile::objfile): Update.
7327         * psymtab.h (psymtab_storage::obstack): Update.
7328         (psymtab_storage::m_obstack): Use gdb::optional.
7329         (class psymtab_storage): Update comment.  Remove objfile
7330         parameter.
7331         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7332
7333 2019-01-10  Tom Tromey  <tom@tromey.com>
7334
7335         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7336         <free_psymtabs>: Now private.
7337         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7338         (allocate_psymtab): Use new method.
7339
7340 2019-01-10  Tom Tromey  <tom@tromey.com>
7341
7342         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7343         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7344         * mdebugread.c (parse_partial_symbols): Use
7345         allocate_dependencies.
7346         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7347         allocate_dependencies.
7348         (process_psymtab_comp_unit_reader)
7349         (build_type_psymtab_dependencies): Likewise.
7350         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7351
7352 2019-01-10  Tom Tromey  <tom@tromey.com>
7353
7354         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7355         PSYMBOL_SET_LANGUAGE.
7356         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7357
7358 2019-01-10  Tom Tromey  <tom@tromey.com>
7359
7360         * psymtab.h (psymtab_storage::obstack): New method.
7361         <m_obstack>: Rename from obstack; now private.
7362         * psymtab.c (psymtab_storage): Update.
7363         * dwarf2read.c (create_addrmap_from_index)
7364         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7365         Update.
7366
7367 2019-01-10  Tom Tromey  <tom@tromey.com>
7368
7369         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7370         * objfiles.h (objfile::reset_psymtabs): New method.
7371
7372 2019-01-10  Tom Tromey  <tom@tromey.com>
7373
7374         * symmisc.c (print_symbol_bcache_statistics): Update.
7375         (print_objfile_statistics): Update.
7376         * symfile.c (reread_symbols): Update.
7377         * psymtab.h (class psymtab_storage): New.
7378         * psymtab.c (psymtab_storage): New constructor.
7379         (~psymtab_storage): New destructor.
7380         (require_partial_symbols): Update.
7381         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7382         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7383         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7384         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7385         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7386         (start_psymtab_common, end_psymtab_common)
7387         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7388         (allocate_psymtab): Update.
7389         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7390         Update.
7391         (dump_psymtab_addrmap, maintenance_print_psymbols)
7392         (maintenance_check_psymtabs): Update.
7393         (class objfile_psymtabs): Move to objfiles.h.
7394         * psympriv.h (discard_psymtab): Now inline.
7395         (psymtab_discarder::psymtab_discarder): Update.
7396         (psymtab_discarder::~psymtab_discarder): Update.
7397         (ALL_OBJFILE_PSYMTABS): Rewrite.
7398         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7399         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7400         Remove fields.
7401         <partial_symtabs>: New field.
7402         (class objfile_psymtabs): Move from psymtab.h.  Update.
7403         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7404         psymbol_cache.
7405         (objfile::~objfile): Don't destroy psymbol_cache.
7406         * mdebugread.c (parse_partial_symbols): Update.
7407         * dwarf2read.c (create_addrmap_from_index)
7408         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7409         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7410         (add_partial_subprogram, dwarf2_ranges_read): Update.
7411         * dwarf-index-write.c (write_address_map)
7412         (write_one_signatured_type, recursively_write_psymbols)
7413         (class debug_names, class debug_names, write_psymtabs_to_index):
7414         Update.
7415
7416 2019-01-10  Tom Tromey  <tom@tromey.com>
7417
7418         * symtab.h (SYMBOL_SET_NAMES): Update.
7419         (symbol_set_names): Update.
7420         (MSYMBOL_SET_NAMES): Update.
7421         * symtab.c (symbol_set_names): Change argument to be an
7422         objfile_per_bfd_storage.
7423         * psymtab.c (add_psymbol_to_bcache): Update.
7424         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7425
7426 2019-01-10  Tom Tromey  <tom@tromey.com>
7427
7428         * symtab.c (create_demangled_names_hash): Change argument to be an
7429         objfile_per_bfd_storage.
7430         (symbol_set_names): Update.
7431
7432 2019-01-10  Tom Tromey  <tom@tromey.com>
7433
7434         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7435         init_psymbol_list.
7436         * psymtab.c (init_psymbol_list): Do nothing if already called.
7437         * psympriv.h (init_psymbol_list): Add comment.
7438         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7439         init_psymbol_list.
7440         * dbxread.c (dbx_symfile_read): Unconditionally call
7441         init_psymbol_list.
7442
7443 2019-01-10  Tom Tromey  <tom@tromey.com>
7444
7445         * xcoffread.c (scan_xcoff_symtab): Update.
7446         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7447         "where".
7448         * mdebugread.c (parse_partial_symbols)
7449         (handle_psymbol_enumerators): Update.
7450         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7451         * dbxread.c (read_dbx_symtab): Update.
7452         * psympriv.h (psymbol_placement): New enum.
7453         (add_psymbol_to_list): Update.
7454
7455 2019-01-10  Tom Tromey  <tom@tromey.com>
7456
7457         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7458         static_psymbols parameters.
7459         (scan_xcoff_symtab): Update.
7460         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7461         static_psymbols parameters.
7462         * psympriv.h (start_psymtab_common): Update.
7463         * mdebugread.c (parse_partial_symbols): Update.
7464         * dwarf2read.c (create_partial_symtab): Update.
7465         * dbxread.c (read_dbx_symtab): Update.
7466         (start_psymtab): Remove global_psymbols and static_psymbols
7467         parameters.
7468
7469 2019-01-10  Tom Tromey  <tom@tromey.com>
7470
7471         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7472         * psymtab.c (allocate_psymtab): Add comment.
7473         * psympriv.h (allocate_psymtab): Add comment.
7474         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7475         initializations.
7476         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7477
7478 2019-01-10  Tom Tromey  <tom@tromey.com>
7479
7480         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7481         Don't declare.
7482         * mipsread.c: Include mdebugread.h.
7483         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7484         Declare.
7485         * elfread.c: Include mdebugread.h.
7486
7487 2019-01-09  Tom Tromey  <tom@tromey.com>
7488
7489         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7490         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7491         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7492         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7493         (psym_lookup_symbol, psym_find_last_source_symtab)
7494         (psym_forget_cached_source_info, psym_print_stats)
7495         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7496         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7497         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7498         (psym_find_compunit_symtab_by_address)
7499         (maintenance_print_psymbols, maintenance_info_psymtabs)
7500         (maintenance_check_psymtabs): Use ranged for.
7501         * psymtab.h (class objfile_psymtabs): New.
7502         (require_partial_symbols): Return objfile_psymtabs.
7503         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7504
7505 2019-01-09  Tom Tromey  <tom@tromey.com>
7506
7507         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7508         (find_pc_mapped_section, list_overlays_command)
7509         (map_overlay_command, unmap_overlay_command)
7510         (simple_overlay_update): Use all_objfiles.
7511         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7512         * printcmd.c (info_symbol_command): Use all_objfiles.
7513         * objfiles.h (ALL_OBJSECTIONS): Remove.
7514         * maint.c (maintenance_translate_address): Use all_objfiles.
7515         * gcore.c (gcore_create_callback): Use all_objfiles.
7516         (objfile_find_memory_regions): Likewise.
7517
7518 2019-01-09  Tom Tromey  <tom@tromey.com>
7519
7520         * symtab.c (find_line_symtab, info_sources_command)
7521         (make_source_files_completion_list): Use objfile_compunits.
7522         * source.c (select_source_symtab): Use objfile_compunits.
7523         * objfiles.h (struct objfile): Update comment.
7524         (ALL_OBJFILES): Remove.
7525         (ALL_FILETABS): Remove.
7526         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7527         objfile_compunits.
7528
7529 2019-01-09  Tom Tromey  <tom@tromey.com>
7530
7531         * symmisc.c (print_objfile_statistics, dump_objfile)
7532         (maintenance_print_symbols): Use compunit_filetabs.
7533         * source.c (forget_cached_source_info_for_objfile): Use
7534         compunit_filetabs.
7535         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7536         (ALL_FILETABS): Use compunit_filetabs.
7537         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7538         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7539
7540 2019-01-09  Tom Tromey  <tom@tromey.com>
7541
7542         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7543         (compunit_filetabs): New.
7544         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7545         compunit_filetabs.
7546         (info_sources_command, make_source_files_completion_list): Remove
7547         declaration.
7548         * symmisc.c (print_objfile_statistics, dump_objfile)
7549         (maintenance_print_symbols): Remove declaration.
7550         (maintenance_info_symtabs): Use compunit_filetabs.
7551         (maintenance_info_line_tables): Likewise.
7552         * source.c (select_source_symtab): Change local variable name.
7553         (forget_cached_source_info_for_objfile): Remove declaration.
7554         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7555         * objfiles.c (objfile_relocate1): Remove declaration.
7556         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7557         declaration.
7558         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7559         * coffread.c (coff_symtab_read): Remove declaration.
7560         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7561         compunit_filetabs.
7562
7563 2019-01-09  Tom Tromey  <tom@tromey.com>
7564
7565         * symtab.c (lookup_objfile_from_block)
7566         (find_pc_sect_compunit_symtab, search_symbols)
7567         (default_collect_symbol_completion_matches_break_on): Use
7568         objfile_compunits.
7569         * objfiles.h (ALL_COMPUNITS): Remove.
7570         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7571         * cp-support.c (add_symbol_overload_list_qualified): Use
7572         objfile_compunits.
7573         * ada-lang.c (ada_collect_symbol_completion_matches)
7574         (ada_add_global_exceptions): Use objfile_compunits.
7575
7576 2019-01-09  Tom Tromey  <tom@tromey.com>
7577
7578         * source.c (select_source_symtab)
7579         (forget_cached_source_info_for_objfile): Remove declaration.
7580         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7581         declaration.
7582         * maint.c (count_symtabs_and_blocks): Remove declaration.
7583         * cp-support.c (add_symbol_overload_list_qualified): Remove
7584         declaration.
7585         * coffread.c (coff_symtab_read): Remove declaration.
7586         * symtab.c (lookup_symbol_in_objfile_symtabs)
7587         (basic_lookup_transparent_type_1): Use objfile_compunits.
7588         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7589         (info_sources_command, search_symbols)
7590         (default_collect_symbol_completion_matches_break_on)
7591         (make_source_files_completion_list): Remove declaration.
7592         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7593         (ada_collect_symbol_completion_matches)
7594         (ada_add_global_exceptions): Remove declaration.
7595         * linespec.c (iterate_over_all_matching_symtabs): Use
7596         objfile_compunits.
7597         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7598         (class objfile_compunits): New.
7599         (ALL_COMPUNITS): Use objfile_compunits.
7600         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7601         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7602         objfile_compunits.
7603         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7604
7605 2019-01-09  Tom Tromey  <tom@tromey.com>
7606
7607         * symtab.c (search_symbols)
7608         (default_collect_symbol_completion_matches_break_on): Use
7609         objfile_msymbols.
7610         * ada-lang.c (ada_lookup_simple_minsym)
7611         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7612         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7613         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7614         objfile_msymbols.
7615         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7616         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7617         * objc-lang.c (find_methods): Use objfile_msymbols.
7618         (info_selectors_command, info_classes_command): Likewise.
7619         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7620         * objfiles.h (class objfile_msymbols): New.
7621         (ALL_OBJFILE_MSYMBOLS): Remove.
7622         (ALL_MSYMBOLS): Remove.
7623
7624 2019-01-09  Tom Tromey  <tom@tromey.com>
7625
7626         * common/next-iterator.h (next_adapter): Add Iterator template
7627         parameter.
7628         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7629         (class all_objfiles_safe): New.
7630         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7631         * objfiles.c (put_objfile_before): Update comment.
7632         (add_separate_debug_objfile): Likewise.
7633         (free_all_objfiles): Use all_objfiles_safe.
7634         (objfile_purge_solibs): Likewise.
7635
7636 2019-01-09  Tom Tromey  <tom@tromey.com>
7637
7638         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7639         (expand_symtab_containing_pc, lookup_static_symbol)
7640         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7641         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7642         all_objfiles.
7643         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7644         * breakpoint.c (create_overlay_event_breakpoint)
7645         (create_longjmp_master_breakpoint)
7646         (create_std_terminate_master_breakpoint)
7647         (create_exception_master_breakpoint): Use all_objfiles.
7648         * linux-thread-db.c (try_thread_db_load_from_pdir)
7649         (has_libpthread): Use all_objfiles.
7650         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7651         * linespec.c (iterate_over_all_matching_symtabs)
7652         (search_minsyms_for_name): Use all_objfiles.
7653         * maint.c (maintenance_info_sections): Use all_objfiles.
7654         * main.c (captured_main_1): Use all_objfiles.
7655         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7656         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7657         * guile/scm-pretty-print.c
7658         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7659         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7660         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7661         (maintenance_print_msymbols): Use all_objfiles.
7662         * source.c (select_source_symtab): Use all_objfiles.
7663         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7664         * symfile.c (remove_symbol_file_command)
7665         (expand_symtabs_matching, map_symbol_filenames): Use
7666         all_objfiles.
7667         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7668         all_objfiles.
7669         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7670         * objc-lang.c (find_methods): Use all_objfiles.
7671         * objfiles.c (have_partial_symbols, have_full_symbols)
7672         (have_minimal_symbols, qsort_cmp)
7673         (default_iterate_over_objfiles_in_search_order): Use
7674         all_objfiles.
7675         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7676         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7677         (maintenance_check_psymtabs): Use all_objfiles.
7678         (ALL_PSYMTABS): Remove.
7679         * compile/compile-object-run.c (do_module_cleanup): Use
7680         all_objfiles.
7681         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7682         * cp-support.c (add_symbol_overload_list_qualified): Use
7683         all_objfiles.
7684         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7685         Use all_objfiles.
7686         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7687         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7688         all_objfiles.
7689         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7690         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7691         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7692         Uses all_objfiles.
7693         * solib.c (solib_read_symbols): Use all_objfiles
7694
7695 2019-01-09  Tom Tromey  <tom@tromey.com>
7696
7697         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7698         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7699         all_objfiles.
7700         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7701         * symmisc.c (print_symbol_bcache_statistics)
7702         (print_objfile_statistics, maintenance_print_objfiles)
7703         (maintenance_info_symtabs, maintenance_check_symtabs)
7704         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7705         all_objfiles.
7706         * source.c (forget_cached_source_info): Use all_objfiles.
7707         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7708         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7709         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7710         * objfiles.c (update_section_map): Use all_objfiles.
7711         (shared_objfile_contains_address_p): Likewise.
7712         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7713         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7714
7715 2019-01-09  Tom Tromey  <tom@tromey.com>
7716
7717         * common/next-iterator.h: New file.
7718         * objfiles.h (class all_objfiles): New.
7719         (struct objfile_iterator): New.
7720
7721 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7722
7723         * NEWS: Move the description of the changed "frame", "select-frame",
7724          and "info frame" commands to the Changed commands section.
7725
7726 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7727
7728         * gdbtypes.c (check_stub_method_group): Remove handling of old
7729         mangling schemes.
7730         * linespec.c (find_methods): Likewise.
7731         * stabsread.c (read_member_functions): Likewise.
7732         * valops.c (search_struct_method): Likewise.
7733         (value_struct_elt_for_reference): Likewise.
7734         * NEWS: Mention this change.
7735
7736 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7737
7738         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7739         print_source_lines.
7740         * source.c (print_source_lines_base): Update line number check.
7741         (print_source_lines): New function.
7742         (source_lines_range::source_lines_range): New function.
7743         * source.h (class source_lines_range): New class.
7744         (print_source_lines): New declaration.
7745
7746 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7747
7748         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7749
7750 2019-01-08  Tom Tromey  <tom@tromey.com>
7751             Simon Marchi  <simon.marchi@ericsson.com>
7752
7753         PR gdb/24060
7754         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7755         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7756         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7757         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7758         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7759         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7760
7761 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7762
7763         * source.c (select_source_symtab): Move header comment to
7764         declaration in source.h.
7765         (forget_cached_source_info_for_objfile): Likewise.
7766         (forget_cached_source_info): Likewise.
7767         (identify_source_line): Likewise.
7768         * source.h (identify_source_line): Move declaration from symtab.h
7769         and add comment from source.c
7770         (print_source_lines): Likewise.
7771         (forget_cached_source_info_for_objfile): Likewise.
7772         (forget_cached_source_info): Likewise.
7773         (select_source_symtab): Likewise.
7774         (enum print_source_lines_flag): Move definition from symtab.h.
7775         * symtab.h (identify_source_line): Move declaration to source.h.
7776         (print_source_lines): Likewise.
7777         (forget_cached_source_info_for_objfile): Likewise.
7778         (forget_cached_source_info): Likewise.
7779         (select_source_symtab): Likewise.
7780         (enum print_source_lines_flag): Move definition to source.h.
7781         * tui/tui-hooks.c: Add 'source.h' include.
7782
7783 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7784
7785         * source.c (print_source_lines_base): Handle requests to print
7786         reverse line number sequences, and guard against empty lines
7787         string.
7788
7789 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7790
7791         * source.c (print_source_lines_base): Fix skip of '\r' if next
7792         character is '\n'.
7793
7794 2019-01-06  Tom Tromey  <tom@tromey.com>
7795
7796         * c-exp.y (struct c_parse_state) <macro_original_text,
7797         expansion_obstack>: New member.
7798         (macro_original_text, expansion_obstack): Remove globals.
7799         (scan_macro_expansion, scanning_macro_expansion)
7800         (finished_macro_expansion): Update.
7801         (scan_macro_cleanup): Remove.
7802         (yylex, c_parse): Update.
7803
7804 2019-01-06  Tom Tromey  <tom@tromey.com>
7805
7806         * c-exp.y (struct c_parse_state) <strings>: New member.
7807         (operator_stoken): Update.
7808
7809 2019-01-06  Tom Tromey  <tom@tromey.com>
7810
7811         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7812         (union type_stack_elt) <typelist_val>: Now a pointer to
7813         std::vector.
7814         (type_stack_cleanup): Don't declare.
7815         (push_typelist): Update.
7816         * parse.c (pop_typelist): Return a std::vector.
7817         (push_typelist): Take a std::vector.
7818         (follow_types): Update.  Do not free args.
7819         (type_stack_cleanup): Remove.
7820         * c-exp.y (struct c_parse_state): New.
7821         (cpstate): New global.
7822         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7823         (nonempty_typelist): Update.
7824         (func_mod): Create a new vector.
7825         (c_parse): Create a c_parse_state.
7826         (check_parameter_typelist): Do not delete params.
7827         (function_method): Update.  Do not delete type_list.
7828
7829 2019-01-06  Tom Tromey  <tom@tromey.com>
7830
7831         PR gdb/28155:
7832         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7833         check_typedef.
7834         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7835         (print_return_value): Likewise.
7836
7837 2019-01-05  Tom Tromey  <tom@tromey.com>
7838
7839         * contrib/cleanup_check.py: Remove.
7840         * contrib/gcc-with-excheck: Remove.
7841         * contrib/exsummary.py: Remove.
7842         * contrib/excheck.py: Remove.
7843
7844 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7845
7846         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7847         NULL. Initialize tpprev to NULL instead of assigning it
7848         to NULL on the next statement.
7849         * windows-nat.c (windows_delete_thread): Remove check for
7850         main_thread_id before printing thread exit notifications.
7851         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7852         Remove thread ID check against main_thread_id.
7853         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7854         windows_delete_thread.
7855         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7856
7857 2019-01-04  Tom Tromey  <tom@tromey.com>
7858
7859         * compile/compile.c (_initialize_compile): Use upper case for
7860         metasyntactic variables.
7861         * symmisc.c (_initialize_symmisc): Use upper case for
7862         metasyntactic variables.
7863         * psymtab.c (_initialize_psymtab): Use upper case for
7864         metasyntactic variables.
7865         * demangle.c (demangle_command): Use upper case for metasyntactic
7866         variables.
7867         (_initialize_demangler): Likewise.
7868         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7869         variables.
7870
7871 2019-01-03  Tom Tromey  <tom@tromey.com>
7872
7873         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7874
7875 2019-01-03  Tom Tromey  <tom@tromey.com>
7876
7877         * python/py-symtab.c (salpy_str): Update.
7878         (struct salpy_sal_object) <symtab>: Now a PyObject.
7879         (salpy_dealloc): Update.
7880         (del_objfile_sal): Use gdbpy_ref.
7881
7882 2019-01-03  Tom Tromey  <tom@tromey.com>
7883
7884         * python/py-type.c (convert_field): Use new_reference.  Return
7885         gdbpy_ref.
7886         (make_fielditem): Return gdbpy_ref.
7887         (typy_fields): Update.
7888         (typy_getitem): Update.
7889         (field_name): Return gdbpy_ref.  Use new_reference.
7890         (typy_iterator_iternext): Update.
7891
7892 2019-01-03  Tom Tromey  <tom@tromey.com>
7893
7894         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7895
7896 2019-01-03  Tom Tromey  <tom@tromey.com>
7897
7898         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7899         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7900         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7901         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7902         (pspy_set_type_printers): Likewise.
7903         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7904         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7905         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7906         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7907         (objfpy_set_type_printers): Likewise.
7908
7909 2019-01-03  Tom Tromey  <tom@tromey.com>
7910
7911         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7912         (gdbpy_print_stack): Use gdbpy_err_fetch.
7913         * python/python-internal.h (class gdbpy_err_fetch): New class.
7914         (class gdbpy_enter) <m_error_type, m_error_value,
7915         m_error_traceback>: Remove.
7916         <m_error>: New member.
7917         (gdbpy_exception_to_string): Don't declare.
7918         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7919         * python/py-value.c (convert_value_from_python): Use
7920         gdbpy_err_fetch.
7921         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7922         gdbpy_exception_to_string.
7923         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7924         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7925         gdbpy_err_fetch.
7926
7927 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7928
7929         * linux-nat.c (delete_lwp_cleanup): Delete.
7930         (struct lwp_deleter): New struct.
7931         (lwp_info_up): New typedef.
7932         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7933         lwp_info_up.
7934
7935 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7936
7937         * linux-fork.c (class scoped_switch_fork_info): New class.
7938         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7939
7940 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7941
7942         * valops.c (find_overload_match): Remove use of null_cleanup, and
7943         calls to do_cleanups.
7944
7945 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7946
7947         * compile/compile-cplus-types.c
7948         (compile_cplus_instance::decl_name): Handle changes to
7949         cp_func_name.
7950         * cp-support.c (cp_func_name): Update header comment, update
7951         return type.
7952         * cp-support.h (cp_func_name): Update return type in declaration.
7953         * valops.c (find_overload_match): Move temp_func local to top
7954         level of function and change its type.  Use temp_func to hold and
7955         delete temporary string obtained from cp_func_name.
7956
7957 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7958
7959         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7960         gdb::char_vector, remove cleanup, and update uses of `msg`.
7961
7962 2019-01-03  Jim Wilson  <jimw@sifive.com>
7963
7964         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7965
7966 2019-01-02  Tom Tromey  <tom@tromey.com>
7967
7968         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7969         (tdesc_parse_xml): Remove cleanups.
7970         * target-descriptions.h (make_cleanup_free_target_description):
7971         Don't declare.
7972         (target_desc_deleter): New struct.
7973         (target_desc_up): New typedef.
7974         * target-descriptions.c (target_desc_deleter::operator()): Rename
7975         from free_target_description.
7976         (make_cleanup_free_target_description): Remove.
7977
7978 2019-01-02  Tom Tromey  <tom@tromey.com>
7979
7980         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7981         constructor, destructor.
7982         (linespec_parser): Remove typedef.
7983         (~linespec_parser): Rename from linespec_parser_delete.
7984         (linespec_lex_to_end, linespec_complete_label)
7985         (linespec_complete): Update.
7986         (decode_line_full): Remove cleanups.
7987         (decode_line_1): Update.
7988
7989 2019-01-02  Tom Tromey  <tom@tromey.com>
7990
7991         * python/python-internal.h (inferior_to_inferior_object): Change
7992         return type.
7993         * python/py-exitedevent.c (create_exited_event_object): Update.
7994         * python/py-inferior.c (inferior_to_inferior_object): Return
7995         gdbpy_ref.
7996         (python_new_inferior, python_inferior_deleted)
7997         (thread_to_thread_object, delete_thread_object)
7998         (build_inferior_list, gdbpy_selected_inferior): Update.
7999         * python/py-infthread.c (create_thread_object): Update.  Also fail
8000         if inferior_to_inferior_object fails.
8001
8002 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8003
8004         * inferior.h (class inferior) <displaced_step_state>: New field.
8005         * infrun.h (struct displaced_step_state): Move here from
8006         infrun.c.  Initialize fields, add constructor.
8007         <inf>: Remove field.
8008         <reset>: New method.
8009         * infrun.c (struct displaced_step_inferior_state): Move to
8010         infrun.h.
8011         (displaced_step_inferior_states): Remove.
8012         (get_displaced_stepping_state): Adust.
8013         (displaced_step_in_progress_any_inferior): Adjust.
8014         (displaced_step_in_progress_thread): Adjust.
8015         (displaced_step_in_progress): Adjust.
8016         (add_displaced_stepping_state): Remove.
8017         (get_displaced_step_closure_by_addr): Adjust.
8018         (remove_displaced_stepping_state): Remove.
8019         (infrun_inferior_exit): Call displaced_step_state.reset.
8020         (use_displaced_stepping): Don't check for NULL.
8021         (displaced_step_prepare_throw): Call
8022         get_displaced_stepping_state.
8023         (displaced_step_fixup): Don't check for NULL.
8024         (prepare_for_detach): Don't check for NULL.
8025
8026 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8027
8028         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8029          in case of call that did not complete.
8030
8031 2019-01-02  Andrey Utkin  <autkin@undo.io>
8032
8033         * symfile.c (find_separate_debug_file): Fix search of debug files for
8034         remote debuggee.
8035
8036 2019-01-02  Tom Tromey  <tom@tromey.com>
8037
8038         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8039         indentation.
8040         * python/py-frame.c (frapy_older): Remove cast.
8041         (frapy_newer): Likewise.
8042         * python/py-breakpoint.c (local_setattro): Remove cast.
8043         * python/py-arch.c (archpy_name): Remove local variable.
8044         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8045
8046 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8047
8048         * unittests/basic_string_view/element_access/char/empty.cc:
8049         Fix year range in copyright header.
8050
8051 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8052
8053         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8054         Delete.
8055         <operator==>: Update with for removed field.
8056         <hash>: Likewise.
8057         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8058         <isa_features>: ...this.
8059         <abi_features>: New field.
8060         (riscv_isa_flen): Update comment.
8061         (riscv_abi_xlen): New declaration.
8062         (riscv_abi_flen): New declaration.
8063         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8064         isa_features.
8065         (riscv_abi_xlen): New function.
8066         (riscv_isa_flen): Update to get answer from isa_features.
8067         (riscv_abi_flen): New function.
8068         (riscv_has_fp_abi): Update to get answer from abi_features.
8069         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8070         xlen and flen.
8071         (riscv_call_info) <xlen, flen>: Update comment.
8072         (riscv_call_arg_struct): Remove invalid assertions
8073         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8074         is removed.
8075         (riscv_gdbarch_init): Gather isa features and abi features
8076         separately, ensure both match on the gdbarch when reusing an old
8077         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8078         a target with 64-bit float hardware.
8079
8080 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8081
8082         * source.c (search_command_helper): Stop reverse search
8083         when line 1 has been searched.
8084
8085 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8086
8087         * record-full.c (record_full_base_target::close): Rewrite
8088         record_full_core_buf_list free logic.
8089
8090 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8091
8092         * break-catch-syscall.c (print_one_catch_syscall): xfree
8093         the last text.
8094
8095 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8096
8097         * top.c (print_gdb_version): Update Copyright year in version
8098         message.
8099
8100 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8101
8102         Update copyright year range in all GDB files.
8103
8104 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8105
8106         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8107
8108 For older changes see ChangeLog-2018.
8109 \f
8110 Local Variables:
8111 mode: change-log
8112 left-margin: 8
8113 fill-column: 74
8114 version-control: never
8115 coding: utf-8
8116 End:
8117