gdb/ChangeLog

   1 2019-08-12  Tom Tromey  <tom@tromey.com>
   2
   3         * mingw-hdep.c (gdb_select): Remove readline hack.
   4
   5 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
   6
   7         * blockframe.c (find_pc_partial_function): Set *block to nullptr
   8         when the function fails.
   9
  10 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
  11
  12         * s390-tdep.c (s390_type_align): New function.
  13         (s390_gdbarch_init): Set it as type_align gdbarch method.
  14
  15 2019-08-09  Tom de Vries  <tdevries@suse.de>
  16
  17         PR gdb/24591
  18         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
  19         pc_low with relocation offset.
  20
  21 2019-08-07  Tom Tromey  <tromey@adacore.com>
  22
  23         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
  24         (print_frame_args): Update.
  25         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
  26         Update.
  27         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
  28         * frame.h (struct frame_arg): Add initializers.
  29         <error>: Now a unique_xmalloc_ptr.
  30
  31 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
  32
  33         * NEWS: Expand the Pointer Authentication entry.
  34         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
  35         (aarch64_frame_unmask_lr): ... to this.
  36         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
  37         Call aarch64_frame_unmask_lr.
  38         * frame.c (struct frame_info): Add "masked" variable.
  39         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
  40         (fprint_frame): Check for masked pc.
  41         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
  42         declarations.
  43         * python/py-framefilter.c (py_print_frame): Check for masked pc.
  44         * stack.c (print_frame): Check for masked pc.
  45
  46 2019-08-06  Tom Tromey  <tom@tromey.com>
  47
  48         * stabsread.c (patch_block_stabs, read_one_struct_field)
  49         (read_enum_type): Use obstack_strndup.
  50         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
  51         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
  52         * dwarf2read.c (guess_full_die_structure_name)
  53         (anonymous_struct_prefix): Use obstack_strndup.
  54         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
  55         * c-exp.y (yylex): Use obstack_strndup.
  56         * ada-exp.y (write_object_renaming, write_ambiguous_var)
  57         (write_var_or_type): Use obstack_strndup.
  58
  59 2019-08-06  Tom Tromey  <tom@tromey.com>
  60
  61         * symfile.c (reread_symbols): Use obstack_strdup.
  62         * stabsread.c (read_type): Use obstack_strdup.
  63         * gdb_obstack.h (obstack_strdup): New overload.
  64         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
  65         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
  66         (dwarf2_canonicalize_name): Use obstack_strdup.
  67         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
  68         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
  69         Use obstack_strdup.
  70
  71 2019-08-06  Tom Tromey  <tom@tromey.com>
  72
  73         * gdb_obstack.h (obstack_strdup): Define.
  74         * gdb_obstack.c (obstack_strdup): Don't define.
  75
  76 2019-08-06  Tom Tromey  <tom@tromey.com>
  77
  78         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
  79         obstack_strdup.
  80         * typeprint.c (typedef_hash_table::find_global_typedef): Use
  81         obstack_strdup.
  82         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
  83         * stabsread.c (common_block_start): Use obstack_strdup.
  84         * objfiles.c (set_objfile_main_name, objfile): Use
  85         obstack_strdup.
  86         * namespace.c (add_using_directive): Use obstack_strdup.
  87         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
  88         * jit.c (finalize_symtab): Use obstack_strdup.
  89         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
  90         (guess_partial_die_structure_name, partial_die_info::fixup)
  91         (dwarf2_name): Use obstack_strdup.
  92         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
  93         obstack_strdup.
  94         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
  95         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
  96         obstack_strdup.
  97         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
  98
  99 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 100
 101         * unittests/help-doc-selftests.c: New file.
 102         * Makefile.in: Add the new file.
 103
 104 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 105
 106         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 107         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 108         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 109         the trailing '.' is not output, and the first character is uppercased.
 110         (print_help_for_command): Update call to print_doc_line.
 111         (print_doc_of_command): Likewise.
 112         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 113         * cli/cli-option.c (append_indented_doc): Do not append newline.
 114         (build_help_option): Append newline after first appended_indented_doc
 115         only if a second call is done.
 116         (build_help): Append 2 new lines before each option, except the first
 117         one.
 118         * compile/compile.c (_initialize_compile): Add new lines after
 119         %OPTIONS%, when not at the end of the help.
 120         Change help doc or code
 121         producing the help doc to respect the invariants.
 122         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 123         Also removed the new line after 'Options:', as all other commands
 124         do not put an empty line between 'Options:' and the first option.
 125         * printcmd.c (_initialize_printcmd): Likewise.
 126         * stack.c (_initialize_stack): Likewise.
 127         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 128         incorrectly telling COMMAND is optional.
 129         * ada-lang.c (_initialize_ada_language): Change help doc or code
 130         producing the help doc to respect the invariants.
 131         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 132         * breakpoint.c (_initialize_breakpoint): Likewise.
 133         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 134         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 135         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 136         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 137         _initialize_cli_style): Likewise.
 138         * corelow.c (core_target_info): Likewise.
 139         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 140         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 141         * filesystem.c (_initialize_filesystem): Likewise.
 142         * frame.c (_initialize_frame): Likewise.
 143         * gnu-nat.c (add_task_commands): Likewise.
 144         * infcall.c (_initialize_infcall): Likewise.
 145         * infcmd.c (_initialize_infcmd): Likewise.
 146         * interps.c (_initialize_interpreter): Likewise.
 147         * language.c (_initialize_language): Likewise.
 148         * linux-fork.c (_initialize_linux_fork): Likewise.
 149         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 150         * maint.c (_initialize_maint_cmds): Likewise.
 151         * memattr.c (_initialize_mem): Likewise.
 152         * printcmd.c (_initialize_printcmd): Likewise.
 153         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 154         _RegEx): Likewise.
 155         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 156         * record-btrace.c (_initialize_record_btrace): Likewise.
 157         * record-full.c (_initialize_record_full): Likewise.
 158         * record.c (_initialize_record): Likewise.
 159         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 160         * regcache.c (_initialize_regcache): Likewise.
 161         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 162         _initialize_remote): Likewise.
 163         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 164         * serial.c (_initialize_serial): Likewise.
 165         * skip.c (_initialize_step_skip): Likewise.
 166         * source.c (_initialize_source): Likewise.
 167         * stack.c (_initialize_stack): Likewise.
 168         * symfile.c (_initialize_symfile): Likewise.
 169         * symtab.c (_initialize_symtab): Likewise.
 170         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 171         * top.c (init_main): Likewise.
 172         * tracefile-tfile.c (tfile_target_info): Likewise.
 173         * tracepoint.c (_initialize_tracepoint): Likewise.
 174         * tui/tui-win.c (_initialize_tui_win): Likewise.
 175         * utils.c (add_internal_problem_command): Likewise.
 176         * valprint.c (value_print_option_defs): Likewise.
 177
 178 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 179
 180         PR build/24886
 181         * configure.ac: Drop enable-libmcheck support.
 182         * configure, config.in: Rebuild.
 183         * libmcheck.m4: Remove.
 184         * acinclude.m4: Don't include it.
 185         * Makefile.in: Don't distribute it.
 186         * top.c (print_gdb_configuration): Don't mention it.
 187
 188 2019-08-06  Tom Tromey  <tom@tromey.com>
 189
 190         * utils.c (set_output_style): Sometimes pass stream to
 191         emit_style_escape.
 192         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 193         * record-btrace.c (btrace_insn_history): Update.
 194         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 195         method.
 196         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 197         Update initializers.
 198         <m_uiout>: New field.
 199         <m_di>: Move lower.
 200         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 201         Remove "uiout" parameter.
 202         (dump_insns): Update.
 203         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 204         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 205
 206 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 207
 208         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 209         (error_in_psymtab_expansion): Likewise.
 210         (lookup_symbol_via_quick_fns): Likewise.
 211         (basic_lookup_transparent_type_quick): Likewise.
 212         (basic_lookup_transparent_type_1): Likewise.
 213
 214 2019-08-06  Tom Tromey  <tromey@adacore.com>
 215
 216         * source.c (last_source_error): Now bool.
 217         (print_source_lines_base): Make "noprint" bool.  Only open
 218         source file when last_source_visited changes.
 219
 220 2019-08-06  Tom Tromey  <tromey@adacore.com>
 221
 222         * annotate.c (annotate_source_line): Use g_source_cache.
 223         * source-cache.c (source_cache::get_plain_source_lines): Change
 224         parameters.  Populate m_offset_cache.
 225         (source_cache::ensure): New method.
 226         (source_cache::get_line_charpos): New method.
 227         (extract_lines): Move lower.  Change parameters.
 228         (source_cache::get_source_lines): Move lower.
 229         * source-cache.h (class source_cache): Update comment.
 230         <get_line_charpos>: New method.
 231         <get_source_lines>: Update comment.
 232         <clear>: Clear m_offset_cache.
 233         <get_plain_source_lines>: Change parameters.
 234         <ensure>: New method
 235         <m_offset_cache>: New member.
 236         * source.c (forget_cached_source_info_for_objfile): Update.
 237         (info_source_command): Use g_source_cache.
 238         (find_source_lines, open_source_file_with_line_charpos): Remove.
 239         (print_source_lines_base, search_command_helper): Use g_source_cache.
 240         * source.h (open_source_file_with_line_charpos): Don't declare.
 241         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 242         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 243         Use g_source_cache.
 244
 245 2019-08-06  Tom Tromey  <tromey@adacore.com>
 246
 247         * source-cache.c (source_cache::get_plain_source_lines):
 248         Remove "first_line" and "last_line" parameters.
 249         (source_cache::get_source_lines): Cache plain text.
 250         * source-cache.h (class source_cache)
 251         <get_plain_source_lines>: Update.
 252
 253 2019-08-06  Tom Tromey  <tromey@adacore.com>
 254
 255         * source-cache.c (extract_lines): No longer a method.
 256         Changed type of parameter.  Include final newline.
 257         (selftests::extract_lines_test): New function.
 258         (_initialize_source_cache): Likewise.
 259         * source-cache.h (class source_cache)
 260         <extract_lines>: Don't declare.
 261
 262 2019-08-06  Tom Tromey  <tromey@adacore.com>
 263
 264         * breakpoint.c (init_breakpoint_sal): Update.
 265         (breakpoint): Update.
 266         * breakpoint.h (struct breakpoint) <filter>: Now a
 267         unique_xmalloc_ptr.
 268
 269 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 270
 271         * NEWS: Mention dictionary access on blocks.
 272         * python/py-block.c (blpy_getitem): New function.
 273         (block_object_as_mapping): New struct.
 274         (block_object_type): Use new struct for tp_as_mapping field.
 275
 276 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 277
 278         * objfiles.h (objfile): Add a comment describing partial symbols.
 279
 280 2019-08-05  Tom Tromey  <tromey@adacore.com>
 281
 282         * compile/compile.c (_initialize_compile): Use _(), not N_().
 283         * thread.c (_initialize_thread): Use _(), not N_().
 284         * stack.c (_initialize_stack): Use _(), not N_().
 285         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 286
 287 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 288
 289         * dwarf2read.c (struct dw2_symtab_iterator):
 290         <want_specific_block>: Remove.
 291         <block_index>: Change type to gdb::optional.
 292         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 293         change type of BLOCK_INDEX parameter to gdb::optional.
 294         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 295         (dw2_lookup_symbol): Don't pass argument for
 296         WANT_SPECIFIC_BLOCK.
 297         (dw2_expand_symtabs_for_function): Don't pass argument for
 298         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 299         (class dw2_debug_names_iterator)
 300         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 301         parameter, change BLOCK_INDEX type to gdb::optional.
 302         <m_want_specific_block>: Remove.
 303         <m_block_index>: Change type to gdb::optional.
 304         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 305         gdb::optional.  Re-write in function of gdb::optional.
 306         (dw2_debug_names_lookup_symbol): Don't pass argument for
 307         WANT_SPECIFIC_BLOCK.
 308         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 309         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 310         BLOCK_INDEX.
 311
 312 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 313
 314         * NEWS: Mention changes to "info sources" command.
 315
 316 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 317
 318         * symtab.c (filename_partial_match_opts): New struct type.
 319         (struct output_source_filename_data): New members
 320         regexp, c_regexp, partial_match.
 321         (output_source_filename): Use new members to decide to print file.
 322         (info_sources_option_defs): New variable.
 323         (make_info_sources_options_def_group, print_info_sources_header,
 324         info_sources_command_completer):
 325         New functions.
 326         (info_sources_command): Read new optional arguments.
 327         (_initialize_symtab): Update info sources help.
 328
 329 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 330
 331         * ada-lang.c (exception_support_info_v0): Renamed from...
 332         (default_exception_support_info): ... this.  Create new
 333         definition for v1.
 334         (ada_has_this_exception_support): Look up catch_handlers_sym.
 335         (ada_exception_support_info_sniffer): Try v0 after default.
 336
 337 2019-08-01  Tom Tromey  <tromey@adacore.com>
 338
 339         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 340         gdbarch.h.
 341
 342 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 343
 344         * s12z-tdep.c: Fix include path for s12z-opc.h.
 345
 346 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 347
 348         * NEWS: Require GNU make 3.82.
 349
 350 2019-07-16  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 353         declare.
 354
 355 2019-07-30  Tom Tromey  <tromey@adacore.com>
 356
 357         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 358
 359 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 360
 361         * printcmd.c (print_address_symbolic): Print negative offsets.
 362         (build_address_symbolic): Force signed arithmetic when computing
 363         offset.
 364
 365 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 366
 367         PR/24474: Add a function to lookup static variables.
 368         * NEWS: Mention this new function.
 369         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 370         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 371         * python/python.c (python_GdbMethods): Add new function.
 372
 373 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 374
 375         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 376         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 377         (objfpy_lookup_static_symbol): New function.
 378         (objfile_object_methods): Add new functions.
 379
 380 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 381
 382         * NEWS: Mention 'set|show print frame-info'.  Mention new
 383         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 384         backtrace argument.  Mention that python frame filtering code
 385         is now consistent with what 'backtrace' command prints.
 386
 387 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 388
 389         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 390         comments.
 391         (print_frame_info_auto, print_frame_info_source_line,
 392         print_frame_info_location, print_frame_info_source_and_location,
 393         print_frame_info_location_and_address, print_frame_info_short_location):
 394         New declarations.
 395         (struct frame_print_options): New member print_frame_info.
 396         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 397         * stack.h (get_user_print_what_frame_info): New declaration.
 398         (frame_show_address): New declaration.
 399         * stack.c (print_frame_arguments_choices): New value 'presence'.
 400         (print_frame_info_auto, print_frame_info_source_line,
 401         print_frame_info_location, print_frame_info_source_and_location,
 402         print_frame_info_location_and_address, print_frame_info_short_location,
 403         print_frame_info_choices, print_frame_info_print_what): New definitions.
 404         (print_frame_args): Only print dots for args if print frame-arguments
 405         is 'presence'.
 406         (frame_print_option_defs): New element for "frame-info".
 407         (get_user_print_what_frame_info): New function.
 408         (frame_show_address): Make non static.  Move comment to stack.h.
 409         (print_frame_info_to_print_what): New function.
 410         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 411         to decide what to print.
 412         (backtrace_command_1): Handle the new print_frame_arguments_presence
 413         value.
 414         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 415         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 416         (py_print_frame): In non-mi mode, use LOCATION as default for
 417         print_what, similarly to frame information printed directly by
 418         backtrace command. Handle frame-info user option in non MI mode.
 419
 420 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 421
 422         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 423         Add case for debugging 32-bit target on 64-bit host.  Revise
 424         comment.
 425
 426 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 427
 428         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 429         instead of find_function_entry_range_from_pc.
 430
 431 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 432
 433         * stack.c (find_frame_funname): Remove code which preferred
 434         minsym over symtab sym in "certain pathological cases".
 435
 436         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 437         parameter.  Change type of "do_demangle" to bool.
 438         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 439         Pass suitable "prefer_sym_over_minsym" flag to
 440         build_address_symbolic().  Don't output "+" for negative offsets.
 441         * printcmd.c (print_address_symbolic): Update invocation of
 442         build_address_symbolic to include a "prefer_sym_over_minsym"
 443         flag.
 444         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 445         Restrict cases in which use of minimal symbol is preferred to that
 446         of a found symbol.  Update comments.
 447
 448         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 449         for entry pc when entry pc is out of range for that FDE.
 450
 451 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 452
 453         PR gdb/24839:
 454         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 455         type.
 456
 457 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 458
 459         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 460         this function's Python signature.
 461
 462
 463 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 464
 465         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 466         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 467         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 468         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 469         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 470
 471
 472 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 473
 474         * h8300-tdep.c (h8300_register_name_common): New.
 475         h8300_register_name): Use h8300_register_name_common.
 476         (h8300s_register_name): Likewise.
 477         (h8300sx_register_name): Likewise.
 478         (h8300h_register_nam): New.
 479         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 480
 481
 482 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 483
 484         * arm-tdep.c (arm_skip_cmse_entry): New function.
 485         (arm_is_sgstubs_section): New function.
 486         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 487
 488 2019-07-22  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 491         Don't self-assign.
 492
 493 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 494
 495         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 496         type_print.
 497
 498 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 501         so that GDB doesn't match any msymbols when searching in the
 502         TYPES_DOMAIN.
 503         (print_symbol_info): Print using typedef_print or type_print based
 504         on the type of the symbol.  Add updated FIXME comment moved from...
 505         (_initialize_symtab): ... move and update FIXME comment to above.
 506
 507 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 508
 509         * NEWS: Mention adding -q option to "info types".
 510         * symtab.c (struct info_types_options): New struct.
 511         (info_types_options_defs): New variable.
 512         (make_info_types_options_def_group): New function.
 513         (info_types_command): Use gdb::option framework to parse options.
 514         (info_types_command_completer): New function.
 515         (_initialize_symtab): Extend the help text on "info types" and
 516         register command completer.
 517
 518 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 519
 520         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 521         (lookup_symbol_in_objfile): Change int to block_enum and add a
 522         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 523
 524 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 525
 526         * MAINTAINERS (Write After Approval): Add self.
 527
 528 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 529
 530         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 531         instruction to the dummy code region.
 532
 533 2019-07-19  Tom Tromey  <tromey@adacore.com>
 534
 535         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 536         (ARGSUSED, PARAMS, __func__): Remove rules.
 537
 538 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 539
 540         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 541         * features/arm/arm-with-iwmmxt.c: Remove.
 542         * features/arm/arm-with-iwmmxt.xml: Remove.
 543         * features/arm/arm-with-m-fpa-layout.c: Remove.
 544         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 545         * features/arm/arm-with-m-vfp-d16.c: Remove.
 546         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 547         * features/arm/arm-with-m.c: Remove.
 548         * features/arm/arm-with-m.xml: Remove.
 549         * features/arm/arm-with-neon.c: Remove.
 550         * features/arm/arm-with-neon.xml: Remove.
 551         * features/arm/arm-with-vfpv2.c: Remove.
 552         * features/arm/arm-with-vfpv2.xml: Remove.
 553         * features/arm/arm-with-vfpv3.c: Remove.
 554         * features/arm/arm-with-vfpv3.xml: Remove.
 555
 556 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 557
 558         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 559
 560 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 561
 562         * arch/aarch32.c (aarch32_create_target_description): Create
 563         target descriptions using features.
 564         * arch/arm.c (arm_create_target_description)
 565         (arm_create_mprofile_target_description): Likewise.
 566         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 567
 568 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 569
 570         * Makefile.in: Add new files.
 571         * aarch32-tdep.c: New file.
 572         * aarch32-tdep.h: New file.
 573         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 574         Call aarch32_read_description.
 575         * arch/aarch32.c: New file.
 576         * arch/aarch32.h: New file.
 577         * arch/arm.c (arm_create_target_description)
 578         (arm_create_mprofile_target_description): New function.
 579         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 580         (arm_create_target_description)
 581         (arm_create_mprofile_target_description): New declaration.
 582         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 583         read_description functions.
 584         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 585         Likewise.
 586         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 587         * arm-tdep.c (tdesc_arm_list): New variable.
 588         (arm_register_g_packet_guesses): Call create description functions.
 589         (arm_read_description) (arm_read_mprofile_description): New
 590         function.
 591         * arm-tdep.h (arm_read_description)
 592         (arm_read_mprofile_description): Add declaration.
 593         * configure.tgt: Add new files.
 594
 595 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 596
 597         * top.c (new_ui_command): Open specified terminal just once.
 598
 599 2019-07-18  Tom Tromey  <tromey@adacore.com>
 600
 601         * symtab.c (main_name): Constify return type.
 602         * symfile.c (set_initial_language): Update.
 603         * symtab.h (main_name): Constify return type.
 604
 605 2019-07-17  Tom Tromey  <tom@tromey.com>
 606
 607         * tui/tui-winsource.c (tui_update_source_window)
 608         (tui_update_source_window_as_is)
 609         (tui_update_source_windows_with_line): Remove return.
 610         * tui/tui-disasm.c (tui_show_disassem)
 611         (tui_show_disassem_and_update_source): Remove return.
 612         * tui/tui.c (tui_reset): Remove return.
 613         * tui/tui-wingeneral.c
 614         (tui_check_and_display_highlight_if_needed): Remove return.
 615
 616 2019-07-17  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 619
 620 2019-07-17  Tom Tromey  <tom@tromey.com>
 621
 622         * tui/tui-winsource.h (struct tui_exec_info_window)
 623         (struct tui_source_window_base): Move from tui-data.h.
 624         * tui/tui-winsource.c: Move many method definitions from
 625         elsewhere.  Remove "structuring" comments.
 626         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 627         (tui_source_window_base::refresh_window): Move to
 628         tui-winsource.c.
 629         * tui/tui-win.c (tui_source_window_base::refresh_all)
 630         (tui_source_window_base::update_tab_width)
 631         (tui_source_window_base::set_new_height)
 632         (tui_source_window_base::do_make_visible_with_new_height): Move to
 633         tui-winsource.c.
 634         * tui/tui-source.h: Update.
 635         * tui/tui-source.c (tui_source_window_base::reset): Move to
 636         tui-winsource.c.
 637         * tui/tui-disasm.h: Update.
 638         * tui/tui-data.h (struct tui_exec_info_window): Move to
 639         tui-winsource.h.
 640         (struct tui_source_window_base): Likewise.
 641         * tui/tui-data.c (tui_source_window_base::clear_detail)
 642         (tui_source_window_base, ~tui_source_window_base): Move to
 643         tui-winsource.c.
 644
 645 2019-07-17  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui-win.c (tui_resize_all)
 648         (tui_source_window_base::update_tab_width)
 649         (tui_adjust_win_heights): Update.
 650         (tui_win_info::make_invisible_and_set_new_height): Rename from
 651         make_invisible_and_set_new_height.
 652         * tui/tui-data.h (struct tui_win_info)
 653         <make_invisible_and_set_new_height>: New method.
 654
 655 2019-07-17  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui.c: Update.
 658         * tui/tui-source.h (struct tui_source_window): Move from
 659         tui-data.h.
 660         * tui/tui-layout.c: Update.
 661         * tui/tui-disasm.c: Update.
 662         * tui/tui-data.h (struct tui_source_window): Move to
 663         tui-source.h.
 664
 665 2019-07-17  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 668         tui-data.h.
 669         * tui/tui-data.h (struct tui_disasm_window): Move to
 670         tui-disasm.h.
 671
 672 2019-07-17  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-regs.h (struct tui_data_item_window): Move from
 675         tui-data.h.
 676         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 677         * tui/tui-data.h (struct tui_data_item_window): Move to
 678         tui-regs.h.
 679         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 680
 681 2019-07-17  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui.c: Update.
 684         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 685         (tui_cmd_window::max_height): Move to tui-command.c.
 686         * tui/tui-layout.c: Update.
 687         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 688         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 689         tui-command.c.
 690         * tui/tui-command.h (struct tui_cmd_window): Move from
 691         tui-data.h.
 692         * tui/tui-command.c: Remove "structuring" comments.
 693         (tui_cmd_window::clear_detail)
 694         (tui_cmd_window::do_make_visible_with_new_height)
 695         (tui_cmd_window::max_height): Move from elsewhere.
 696
 697 2019-07-17  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 700         Now static.
 701         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 702         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 703
 704 2019-07-17  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui.c: Update.
 707         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 708         tui-regs.c.
 709         * tui/tui-windata.h: Remove file.
 710         * tui/tui-windata.c: Remove file.
 711         * tui/tui-win.c (tui_data_window::set_new_height)
 712         (tui_data_window::do_make_visible_with_new_height): Move to
 713         tui-regs.c.
 714         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 715         * tui/tui-regs.c: Remove "structuring" comments.
 716         (tui_data_window::first_data_item_displayed)
 717         (tui_data_window::delete_data_content_windows)
 718         (tui_data_window::erase_data_content)
 719         (tui_data_window::display_all_data)
 720         (tui_data_window::refresh_all)
 721         (tui_data_window::do_scroll_vertical)
 722         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 723         (tui_data_window::do_make_visible_with_new_height)
 724         (tui_data_window::refresh_window): Move from elsewhere.
 725         (_initialize_tui_regs): Move to end of file.
 726         * tui/tui-layout.c: Update.
 727         * tui/tui-hooks.c: Update.
 728         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 729         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 730         tui-regs.c.
 731         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 732
 733 2019-07-17  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 736         seen.
 737
 738 2019-07-17  Tom Tromey  <tom@tromey.com>
 739
 740         * tui/tui-win.c (tui_source_window_base::set_new_height)
 741         (tui_source_window_base::do_make_visible_with_new_height): Use
 742         m_has_locator field directly.
 743         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 744         method.
 745         (struct tui_source_window_base) <has_locator>: Likewise.
 746
 747 2019-07-17  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 750         Don't declare.
 751         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 752         Remove.
 753         * tui/tui-win.c (tui_source_window_base::set_new_height)
 754         (tui_source_window_base::set_new_height)
 755         (make_invisible_and_set_new_height)
 756         (tui_source_window_base::do_make_visible_with_new_height)
 757         (tui_source_window_base::do_make_visible_with_new_height):
 758         Update.
 759         * tui/tui-layout.c (show_source_disasm_command, show_data)
 760         (show_source_or_disasm_and_command): Update.
 761         * tui/tui-layout.c (show_layout): Update.
 762
 763 2019-07-17  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-layout.c (make_data_window): Remove.
 766         (show_data): Unify creation and re-initialization cases.
 767
 768 2019-07-17  Tom Tromey  <tom@tromey.com>
 769
 770         * tui/tui-layout.c (make_source_window, make_disasm_window):
 771         Remove.
 772         (show_data): Unify creation and re-initialization cases.
 773
 774 2019-07-17  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-layout.c (make_command_window): Remove.
 777         (show_source_disasm_command, show_source_or_disasm_and_command):
 778         Unify creation and re-initialization cases.
 779
 780 2019-07-17  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 783         creation and re-initialization cases.
 784
 785 2019-07-17  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-regs.c (tui_get_register): Return void.
 788
 789 2019-07-17  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 792         Simplify.
 793
 794 2019-07-17  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 797         resetting.
 798
 799 2019-07-17  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 802         * tui/tui-regs.c (tui_reg_layout): New function.
 803         (tui_show_registers, tui_reg_command): Use it.
 804         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 805         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 806         parameters.
 807         (tui_layout_command): Remove.
 808
 809 2019-07-17  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-layout.h (tui/tui-layout): Return void.
 812         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 813
 814 2019-07-17  Tom Tromey  <tom@tromey.com>
 815
 816         * tui/tui-layout.c (show_source_disasm_command, show_data):
 817         Update.
 818         (reset_locator): Remove.
 819         (show_source_or_disasm_and_command): Update.
 820
 821 2019-07-17  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-source.c (tui_source_window_base::reset): Remove
 824         win_type parameter.
 825         * tui/tui-layout.c (make_command_window, make_source_window)
 826         (make_disasm_window, make_data_window)
 827         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 828         (reset_locator, show_source_or_disasm_and_command): Update.
 829         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 830         win_type parameter.
 831         (struct tui_source_window_base) <reset>: Likewise.
 832
 833 2019-07-17  Tom Tromey  <tom@tromey.com>
 834
 835         * tui/tui-layout.c (show_source_disasm_command): Use
 836         reset_locator.
 837         (reset_locator): New function.
 838         (init_and_make_win): Remove.
 839         (show_source_or_disasm_and_command): Use reset_locator.
 840
 841 2019-07-17  Tom Tromey  <tom@tromey.com>
 842
 843         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 844         condition.
 845         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 846         Remove condition.
 847         * tui/tui-source.c (tui_source_window_base::reset): New method.
 848         * tui/tui-layout.c (make_command_window): Don't call
 849         init_and_make_win.
 850         (make_source_window, make_disasm_window): Don't call
 851         make_source_or_disasm_window.
 852         (make_data_window): Don't call init_and_make_win.  Change calling
 853         convention.
 854         (show_source_disasm_command, show_data): Simplify.
 855         (make_source_or_disasm_window): Remove.
 856         (show_source_or_disasm_and_command): Simplify.
 857         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 858         (struct tui_source_window_base) <reset>: Likewise.
 859         <execution_info>: Remove initializer.
 860         * tui/tui-data.c (tui_source_window_base): Initialize
 861         execution_info.
 862
 863 2019-07-17  Tom Tromey  <tom@tromey.com>
 864
 865         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 866         variable.
 867
 868 2019-07-17  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui.c (tui_rl_other_window): Update.
 871         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 872         superclass method first.  Always iterate over regs_content.
 873         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 874         method.
 875         * tui/tui-win.c (tui_set_focus_command): Update.
 876
 877 2019-07-17  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-win.c (tui_set_focus_command): Rename from
 880         tui_set_focus.  Call tui_enable.
 881         (tui_set_focus_command): Remove.
 882
 883 2019-07-17  Tom Tromey  <tom@tromey.com>
 884
 885         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 886         refresh_window.
 887         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 888         touchwin.
 889         (tui_data_window::refresh_window): Call refresh_window on data
 890         items.  Always call superclass refresh_window.
 891         (tui_win_info::refresh): Remove.
 892         (tui_source_window_base::refresh_window): Update.
 893         (tui_refresh_all): Update.
 894         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 895         refresh_window.
 896         (show_source_or_disasm_and_command): Likewise.
 897         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 898         (struct tui_source_window_base) <refresh>: Likewise.
 899
 900 2019-07-17  Tom Tromey  <tom@tromey.com>
 901
 902         * tui/tui-winsource.c (tui_clear_source_content)
 903         (tui_show_source_content): Update.
 904         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 905         whether content is empty.
 906         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 907         Remove.
 908
 909 2019-07-17  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 912         window's contents.
 913         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 914         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 915
 916 2019-07-17  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 919         (struct tui_data_item_window): Update.
 920
 921 2019-07-17  Tom Tromey  <tom@tromey.com>
 922
 923         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 924         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 925         defines.
 926
 927 2019-07-17  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-winsource.h (tui_erase_source_content)
 930         (tui_clear_source_content): Remove "display_prompt" parameter.
 931         * tui/tui-winsource.c (tui_update_source_window_as_is)
 932         (tui_update_source_windows_with_addr): Update.
 933         (tui_clear_source_content): Remove "display_prompt" parameter.
 934         (tui_erase_source_content): Likewise.  Simplify.
 935         (tui_show_source_content): Update.
 936         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 937         * tui/tui-stack.c (tui_show_frame_info): Update.
 938         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 939         Remove defines.
 940
 941 2019-07-17  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 944         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 945         parameter.
 946         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 947         parameter.
 948
 949 2019-07-17  Tom Tromey  <tom@tromey.com>
 950
 951         * tui/tui-winsource.c (tui_clear_source_content)
 952         (tui_show_source_content, tui_show_exec_info_content)
 953         (tui_clear_exec_info_content): Update.
 954         * tui/tui-stack.c (tui_show_locator_content): Update.
 955         (tui_show_frame_info): Update.
 956         * tui/tui-source.h (tui_source_window): Don't declare.
 957         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 958         from tui_source_is_displayed.
 959         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 960         Remove field.
 961         (struct tui_source_window_base) <content_in_use>: New field.  Now
 962         bool.
 963         (struct tui_source_window) <showing_source_p>: New method.
 964         (TUI_SRC_WIN): Change cast.
 965         * tui/tui-data.c (tui_initialize_static_data): Update.
 966
 967 2019-07-17  Tom Tromey  <tom@tromey.com>
 968
 969         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 970         location_matches_p.
 971         * tui/tui-source.c (tui_source_window::location_matches_p): New
 972         method.
 973         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 974         method.
 975         * tui/tui-data.h (struct tui_source_window_base)
 976         <location_matches_p>: New method.
 977         (struct tui_source_window, struct tui_disasm_window)
 978         <location_matches_p>: Likewise.
 979
 980 2019-07-17  Tom Tromey  <tom@tromey.com>
 981
 982         * tui/tui-win.c (tui_set_win_height_command): Rename from
 983         tui_set_win_height.
 984         (tui_set_win_height_command): Remove.
 985
 986 2019-07-17  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui-source.c (tui_source_window): New constructor.  Add
 989         observer.
 990         (~tui_source_window): New destructor.
 991         (tui_source_window::style_changed): New method.
 992         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 993         (tui_attach_detach_observers): Update.
 994         * tui/tui-data.h (struct tui_source_window): Make constructor not
 995         inline.  Add destructor.
 996         (struct tui_source_window) <style_changed>: New method.
 997         <m_observable>: New member.
 998
 999 2019-07-17  Tom Tromey  <tom@tromey.com>
1000
1001         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1002         * tui/tui-win.c (tui_resize_all): Fix typo.
1003
1004 2019-07-17  Tom Tromey  <tom@tromey.com>
1005
1006         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1007         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1008         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1009         * tui/tui-win.c (window_name_completer): Use foreach.
1010         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1011         (update_tab_width): Likewise.
1012         * tui/tui-layout.c (show_layout): Update.
1013         * tui/tui-data.h (class tui_window_iterator): New.
1014         (struct all_tui_windows): New.
1015         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1016
1017 2019-07-17  Tom Tromey  <tom@tromey.com>
1018
1019         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1020         parameter.  Don't reference globals.
1021         (tui_reg_command): Update.
1022
1023 2019-07-17  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-regs.c (tui_show_registers): Simplify.
1026
1027 2019-07-17  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-regs.c (tui_show_registers): Update.
1030         (tui_show_register_group): Add win_info parameter.
1031
1032 2019-07-17  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1035         Rename from tui_display_reg_element_at_line.
1036         (tui_data_window::display_registers_from_line): Update.
1037         * tui/tui-data.h (struct tui_data_window)
1038         <display_reg_element_at_line>: New method.
1039
1040 2019-07-17  Tom Tromey  <tom@tromey.com>
1041
1042         * tui/tui-regs.h (tui_display_registers_from)
1043         (tui_display_registers_from_line): Don't declare.
1044         * tui/tui-windata.c (tui_data_window::display_all_data)
1045         (tui_data_window::refresh_all)
1046         (tui_data_window::do_scroll_vertical): Update.
1047         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1048         from tui_display_registers_from.
1049         (tui_display_reg_element_at_line): Update.
1050         (tui_data_window::display_registers_from_line): Rename from
1051         tui_display_registers_from_line.
1052         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1053         display_registers_from_line>: New methods.
1054
1055 2019-07-17  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1058         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1059         from tui_erase_data_content.
1060         (tui_data_window::display_all_data)
1061         (tui_data_window::refresh_all)
1062         (tui_data_window::do_scroll_vertical): Update.
1063         * tui/tui-regs.c (tui_show_registers): Update.
1064         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1065         New method.
1066
1067 2019-07-17  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1070         declare.
1071         * tui/tui-windata.c
1072         (tui_data_window::delete_data_content_windows): Rename from
1073         tui_delete_data_content_windows.
1074         (tui_data_window::display_all_data)
1075         (tui_data_window::do_scroll_vertical): Update.
1076         * tui/tui-data.h (struct tui_data_window)
1077         <delete_data_content_windows>: New method.
1078
1079 2019-07-17  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1082         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1083
1084 2019-07-17  Tom Tromey  <tom@tromey.com>
1085
1086         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1087         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1088         from tui_display_all_data.
1089         * tui/tui-win.c
1090         (tui_data_window::do_make_visible_with_new_height): Update.
1091         * tui/tui-regs.c (tui_show_registers): Update.
1092         * tui/tui-layout.c (tui_set_layout): Update.
1093         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1094         method.
1095
1096 2019-07-17  Tom Tromey  <tom@tromey.com>
1097
1098         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1099         * tui/tui-windata.c (tui_display_data_from): Remove.
1100         (tui_data_window::refresh_all): Update.
1101
1102 2019-07-17  Tom Tromey  <tom@tromey.com>
1103
1104         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1105         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1106         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1107         tui_display_registers_from_line.
1108         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1109         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1110         "force_display" parameter.
1111
1112 2019-07-17  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1115         declare.
1116         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1117         Rename from tui_first_reg_element_no_inline.
1118         (tui_display_reg_element_at_line)
1119         (tui_display_registers_from_line): Update.
1120         * tui/tui-data.h (struct tui_data_window)
1121         <first_reg_element_no_inline>: New method.
1122
1123 2019-07-17  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-windata.c (tui_display_data_from)
1126         (tui_data_window::do_scroll_vertical): Update.
1127         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1128         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1129         Rename from tui_line_from_reg_element_no.
1130         (tui_display_registers_from_line): Update.
1131         * tui/tui-data.h (struct tui_data_window)
1132         <line_from_reg_element_no>: New method.
1133
1134 2019-07-17  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1137         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1138         tui_last_regs_line_no.
1139         (tui_display_reg_element_at_line)
1140         (tui_display_registers_from_line): Update.
1141         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1142         method.
1143
1144 2019-07-17  Tom Tromey  <tom@tromey.com>
1145
1146         PR tui/24722:
1147         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1148         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1149         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1150         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1151         (tui_update_breakpoint_info): Likewise.
1152         * tui/tui-hooks.c (tui_event_create_breakpoint)
1153         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1154         Update.
1155
1156 2019-07-17  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1159
1160 2019-07-17  Tom Tromey  <tom@tromey.com>
1161
1162         * tui/tui-winsource.c (tui_update_source_window_as_is)
1163         (tui_update_source_windows_with_addr): Update.
1164         * tui/tui-source.h (tui_set_source_content)
1165         (tui_show_symtab_source): Add "win_info" parameter.
1166         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1167         parameter.
1168         (tui_show_symtab_source): Likewise.
1169
1170 2019-07-17  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-wingeneral.c
1173         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1174
1175 2019-07-17  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1178         (struct tui_cmd_window) <can_scroll>: New method.
1179         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1180         method.
1181
1182 2019-07-17  Tom Tromey  <tromey@adacore.com>
1183
1184         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1185         do_field_signed>: Rename.  Change type of "value".
1186         * ui-out.c (ui_out::field_signed): Rename from field_int.
1187         Change type of "value".
1188         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1189         type of "value".
1190         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1191         do_field_int.  Change type of "value".
1192         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1193         do_field_int.  Change type of "value".
1194         * tracepoint.c (trace_status_mi, tfind_1)
1195         (print_one_static_tracepoint_marker): Update.
1196         * thread.c (print_thread_info_1, print_selected_thread_frame):
1197         Update.
1198         * stack.c (print_frame, print_frame_info): Update.
1199         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1200         Update.
1201         * source.c (print_source_lines_base): Update.
1202         * skip.c (info_skip_command): Update.
1203         * record-btrace.c (btrace_ui_out_decode_error)
1204         (btrace_call_history_src_line): Update.
1205         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1206         Update.
1207         * progspace.c (print_program_space): Update.
1208         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1209         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1210         do_field_int.  Change type of "value".
1211         * mi/mi-out.c (mi_ui_out::do_table_begin)
1212         (mi_ui_out::do_table_header): Update.
1213         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1214         type of "value".
1215         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1216         (mi_cmd_data_list_changed_registers, output_register)
1217         (mi_cmd_data_read_memory, mi_load_progress)
1218         (mi_cmd_trace_frame_collected): Update.
1219         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1220         Update.
1221         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1222         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1223         (mi_cmd_var_list_children, varobj_update_one): Update.
1224         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1225         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1226         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1227         * inferior.c (print_inferior): Update.
1228         * gdb_bfd.c (print_one_bfd): Update.
1229         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1230         Update.
1231         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1232         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1233         do_field_int.  Change type of "value".
1234         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1235         do_field_int.  Change type of "value".
1236         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1237         (print_one_breakpoint_location, print_it_catch_fork)
1238         (print_one_catch_fork, print_it_catch_vfork)
1239         (print_one_catch_vfork, print_it_catch_solib)
1240         (print_it_catch_exec, print_it_ranged_breakpoint)
1241         (print_mention_watchpoint, print_mention_masked_watchpoint)
1242         (bkpt_print_it, update_static_tracepoint): Update.
1243         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1244         * break-catch-syscall.c (print_it_catch_syscall): Update.
1245         * ada-tasks.c (print_ada_task_info): Update.
1246         * ada-lang.c (print_it_exception, print_mention_exception):
1247         Update.
1248
1249 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1250
1251         PR breakpoints/24541
1252         * gdbarch.c: Regenerate.
1253         * gdbarch.h: Regenerate.
1254         * gdbarch.sh: Adjust return type and parameter types for
1255         'stap_adjust_register'.
1256         (i386_stap_adjust_register): Adjust signature and return new
1257         register name.
1258         * stap-probe.c (stap_parse_register_operand): Adjust use of
1259         'gdbarch_stap_adjust_register'.
1260
1261 2019-07-17  Tom Tromey  <tromey@adacore.com>
1262
1263         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1264         declare VEC.
1265         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1266         std::vector.
1267         (struct s390_process_info): Add initializers.
1268         (s390_add_process): Use new.
1269         (s390_linux_nat_target::low_forget_process): Use delete.
1270         (s390_linux_nat_target::low_new_fork)
1271         (s390_linux_nat_target::stopped_by_watchpoint)
1272         (s390_linux_nat_target::low_prepare_to_resume)
1273         (s390_linux_nat_target::insert_watchpoint)
1274         (s390_linux_nat_target::insert_hw_breakpoint)
1275         (s390_linux_nat_target::remove_watchpoint)
1276         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1277
1278 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1279
1280         * aarch64-fbsd-nat.c: Include regcache.h.
1281         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1282         argument.
1283         (aarch64_fbsd_nat_target::fetch_registers)
1284         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1285         variable.
1286         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1287
1288 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1289
1290         * fbsd-nat.c: Include gdbarch.h.
1291
1292 2019-07-15  Tom Tromey  <tromey@adacore.com>
1293
1294         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1295
1296 2019-07-15  Tom Tromey  <tromey@adacore.com>
1297
1298         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1299         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1300         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1301         * cli-out.c (cli_ui_out::do_field_int): New method.
1302         * ui-out.c (ui_out::field_unsigned): New method.
1303         * symfile.c (generic_load): Use field_unsigned.
1304         (print_transfer_performance): Likewise.
1305         * record-btrace.c (ui_out_field_uint): Remove.
1306         (btrace_call_history_insn_range, btrace_call_history): Use
1307         field_unsigned.
1308         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1309         field_unsigned.
1310         * ui-out.h (class ui_out) <field_unsigned>: New method.
1311         <do_field_unsigned>: Likewise.
1312
1313 2019-07-15  Tom Tromey  <tromey@adacore.com>
1314
1315         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1316         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1317         * target.c (flash_erase_command): Use field_string.
1318         * infrun.c (print_signal_received_reason): Use field_string.
1319         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1320         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1321         field_string.
1322         * ada-tasks.c (print_ada_task_info): Use field_string.
1323
1324 2019-07-15  Tom Tromey  <tromey@adacore.com>
1325
1326         * target.c (flash_erase_command): Use field_core_addr.
1327         * symfile.c (generic_load): Use field_core_addr.
1328         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1329         Use field_core_addr.
1330         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1331         field_core_addr.
1332
1333 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1334
1335         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1336         value if its desired type is smaller than a CORE_ADDR and signed.
1337
1338 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1339
1340         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1341         of changes to field names, and use new is_reference field to
1342         decide if a property is a reference or not.
1343         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1344         field.
1345         (struct dwarf2_property_baton): Update header comment, rename
1346         'referenced_type' to 'property_type' and update comments.
1347         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1348         default property type, store in property baton, update to take
1349         accound of renamed field.
1350         (read_func_scope): Update call to attr_to_dynamic_prop.
1351         (read_array_type): Likewise.
1352         (dwarf2_per_cu_addr_sized_int_type): New function.
1353         (read_subrange_index_type): Move type finding code to
1354         dwarf2_per_cu_addr_sized_int_type.
1355         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1356         (dwarf2_per_cu_addr_type): New function.
1357         (set_die_type): Update calls to attr_to_dynamic_prop.
1358
1359 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1360
1361         * dwarf2read.c (read_subrange_index_type): New function.
1362         (read_subrange_type): Move code into new function and call it.
1363         * gdbtypes.c (create_range_type): Add some asserts.
1364
1365 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1366
1367         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1368         update return statements.
1369         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1370         declaration, and update comment to match.
1371         * gdbtypes.c (resolve_dynamic_array): Update call to
1372         dwarf2_evaluate_property to match new return type.
1373
1374 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1375
1376         * valarith.c (value_subscripted_rvalue): Change lowerbound
1377         parameter type from int to LONGEST.
1378         * value.h (value_subscripted_rvalue): Likewise in declaration.
1379
1380 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         * cli/cli-utils.c (info_print_command_completer): New function.
1383         * cli/cli-utils.h: Add 'completer.h' include, and forward
1384         declaration for 'struct cmd_list_element'.
1385         (info_print_command_completer): Declare.
1386         * stack.c (_initialize_stack): Add completer for 'info locals' and
1387         'info args'.
1388         * symtab.c (_initialize_symtab): Add completer for 'info
1389         variables' and 'info functions'.
1390         * NEWS: Mention completion for additional info commands.
1391
1392 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1393
1394         * cli/cli-utils.c (extract_info_print_args): Delete.
1395         (extract_arg_maybe_quoted): Delete.
1396         (info_print_options_defs): New variable.
1397         (make_info_print_options_def_group): New function.
1398         (extract_info_print_options): Define new function.
1399         * cli/cli-utils.h (extract_info_print_args): Delete.
1400         (struct info_print_options): New structure.
1401         (extract_info_print_options): Declare new function.
1402         * stack.c (info_locals_command): Update to use new
1403         extract_info_print_options, also add a header comment.
1404         (info_args_command): Likewise.
1405         * symtab.c (info_variables_command): Likewise.
1406         (info_functions_command): Likewise.
1407
1408 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1409
1410         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1411         to extract string arguments.
1412         * common/common-utils.c (extract_string_maybe_quoted): New function.
1413         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1414
1415 2019-07-11  Tom Tromey  <tromey@adacore.com>
1416
1417         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1418         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1419         * top.h (gdbinit): Don't declare.
1420         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1421         into...
1422         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1423         * top.c (gdb_init): Don't call init_cli_cmds.
1424         (gdbinit): Remove.
1425         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1426
1427 2019-07-11  Tom Tromey  <tromey@adacore.com>
1428
1429         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1430         after it has been moved.
1431
1432 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1433
1434         * valops.c (value_must_coerce_to_target): Change return type to
1435         bool.
1436         * value.h (value_must_coerce_to_target): Likewise.
1437
1438 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1439
1440         * breakpoint.c (is_hardware_watchpoint): Remove
1441         forward-declaration.
1442         (is_masked_watchpoint): Change return type to bool.
1443         (is_tracepoint): Likewise.
1444         (is_breakpoint): Likewise.
1445         (is_hardware_watchpoint): Likewise.
1446         (is_watchpoint): Likewise.
1447         (is_no_memory_software_watchpoint): Likewise.
1448         (is_catchpoint): Likewise.
1449         (breakpoint_1): Make FILTER parameter's return type bool.
1450         is_masked_watchpoint): Change return type to bool.
1451         (save_breakpoints): Make FILTER parameter's return type bool.
1452         * breakpoint.h (is_breakpoint): Change return type to bool.
1453         (is_watchpoint): Likewise.
1454         (is_catchpoint): Likewise.
1455         (is_tracepoint): Likewise.
1456
1457 2019-07-10  Tom Tromey  <tom@tromey.com>
1458
1459         * defs.h: Don't include gdbarch.h.
1460         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1461         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1462         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1463         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1464         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1465         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1466         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1467         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1468         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1469         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1470         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1471         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1472         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1473         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1474         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1475         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1476         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1477         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1478         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1479         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1480         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1481         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1482         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1483         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1484         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1485         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1486         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1487
1488 2019-07-10  Tom Tromey  <tromey@adacore.com>
1489
1490         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1491         * breakpoint.c (init_ada_exception_breakpoint): Register as
1492         bp_catchpoint.
1493         (print_one_breakpoint_location, print_one_breakpoint): Use
1494         is_ada_exception_catchpoint.
1495         * ada-lang.c (class ada_catchpoint_location): Pass
1496         bp_loc_software_breakpoint to bp_location constructor.
1497         (is_ada_exception_catchpoint): New function.
1498
1499 2019-07-10  Tom Tromey  <tromey@adacore.com>
1500
1501         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1502         VEC.
1503         (struct arm_exidx_entry): New method operator<.
1504         (struct arm_exidx_data) <section_maps>: Change type.
1505         (arm_exidx_data_free): Remove.
1506         (arm_exidx_data_key): Change type.  Move lower.
1507         (arm_exidx_new_objfile): Update.
1508         (arm_compare_exidx_entries): Remove.
1509         (arm_find_exidx_entry, _initialize_arm_tdep)
1510
1511 2019-07-10  Tom Tromey  <tromey@adacore.com>
1512
1513         * solib-spu.c (ocl_program_data_key): Change type.
1514         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1515         Update.
1516
1517 2019-07-10  Tom Tromey  <tromey@adacore.com>
1518
1519         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1520         (struct solib_aix_inferior_data) <library_list>: Change type.
1521         (solib_aix_inferior_data_handle): Change type.
1522         (get_solib_aix_inferior_data): Update.
1523         (solib_aix_free_library_list): Remove.
1524         (library_list_start_library): Update.
1525         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1526         return type.
1527         (solib_aix_get_library_list)
1528         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1529         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1530
1531 2019-07-10  Tom Tromey  <tromey@adacore.com>
1532
1533         * solib-dsbt.c (struct dsbt_info): Add initializers.
1534         (solib_dsbt_pspace_data): Change type.
1535         (dsbt_pspace_data_cleanup): Remove.
1536         (get_dsbt_info, _initialize_dsbt_solib): Update.
1537
1538 2019-07-10  Tom Tromey  <tromey@adacore.com>
1539
1540         * spu-tdep.c (spu_overlay_data): Change type.
1541         (spu_get_overlay_table, spu_overlay_new_objfile)
1542         (_initialize_spu_tdep): Update.
1543
1544 2019-07-10  Tom Tromey  <tromey@adacore.com>
1545
1546         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1547         destructor.
1548         (dbx_objfile_data_key): Change type and declare later.
1549         (DBX_SYMFILE_INFO): Rewrite.
1550         * dbxread.c (dbx_objfile_data_key): Change type.
1551         (dbx_symfile_init): Update.
1552         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1553         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1554         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1555
1556 2019-07-10  Tom Tromey  <tromey@adacore.com>
1557
1558         * jit.c (jit_program_space_key): Change type.  Move lower.
1559         (get_jit_program_space_data): Update.
1560         (jit_program_space_data_cleanup): Remove.
1561         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1562         Update.
1563         (struct jit_program_space_data): Add initializers.
1564
1565 2019-07-10  Tom Tromey  <tromey@adacore.com>
1566
1567         * solib-darwin.c (struct darwin_info): Add initializers.
1568         (solib_darwin_pspace_data): Change type.
1569         (darwin_pspace_data_cleanup): Remove.
1570         (get_darwin_info, _initialize_darwin_solib): Update.
1571
1572 2019-07-10  Tom Tromey  <tromey@adacore.com>
1573
1574         * remote-sim.c (struct sim_inferior_data): Add initializers,
1575         constructor, and destructor.
1576         (sim_inferior_data_key): Change type.  Move lower.
1577         (check_for_duplicate_sim_descriptor): Update.
1578         (get_sim_inferior_data): Use new.  Update.
1579         (~sim_inferior_data_cleanup): Rename from
1580         sim_inferior_data_cleanup.  Simplify.
1581         (gdbsim_close_inferior, simulator_command)
1582         (sim_command_completer, _initialize_remote_sim): Update.
1583         (next_pid, INITIAL_PID): Move earlier.
1584
1585 2019-07-10  Tom Tromey  <tromey@adacore.com>
1586
1587         * python/python-internal.h (create_thread_object): Return
1588         gdbpy_ref.
1589         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1590         * python/py-inferior.c (struct threadlist_entry): Add
1591         constructor.
1592         <thread_obj>: Now a gdbpy_ref.
1593         (thread_to_thread_object): Update.
1594         (add_thread_object): Use new.
1595         (delete_thread_object): Use delete.
1596         (infpy_threads): Update.
1597         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1598         GIL.
1599
1600 2019-07-10  Tom Tromey  <tromey@adacore.com>
1601
1602         * valops.c (value_cast): Specialize error message for Ada.
1603
1604 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1605
1606         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1607
1608 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1609
1610         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1611         bpstat_should_step): Return bool, adjust comments.
1612         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1613         bpstat_should_step): Likewise.
1614
1615 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1616
1617         * features/Makefile: Use feature target descriptions for Arm.
1618         * features/arm/arm-core.c: Generate new file.
1619         * features/arm/arm-fpa.c: Likewise.
1620         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1621         * features/arm/arm-m-profile.c: Likewise.
1622         * features/arm/arm-vfpv2.c: Likewise.
1623         * features/arm/arm-vfpv3.c: Likewise.
1624         * features/arm/xscale-iwmmxt.c: Likewise.
1625         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1626
1627 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1628
1629         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1630         ptrace earlier.
1631
1632 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1633
1634         * features/aarch64-pauth.c: Regenerate.
1635
1636 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1637
1638         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1639         bool.
1640         (bpstat_what): Use false instead of 0.
1641
1642 2019-07-09  Pedro Alves  <palves@redhat.com>
1643
1644         * break-catch-throw.c (is_exception_catchpoint): New.
1645         * breakpoint.c (print_one_breakpoint_location): New parameter
1646         'raw_loc'.  Handle it.  Use
1647         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1648         looking at the breakpoint's type.
1649         (print_one_breakpoint): If handling "maint info breakpoints", also
1650         print locations of exception catchpoints.
1651         * breakpoint.h (is_exception_catchpoint): Declare.
1652
1653 2019-07-09  Pedro Alves  <palves@redhat.com>
1654
1655         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1656         "addr" field.
1657         (allocate_location_exception_catchpoint): New.
1658         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1659         (initialize_throw_catchpoint_ops): Install
1660         allocate_location_exception_catchpoint as allocate_location
1661         method.
1662         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1663         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1664         bp_loc_other.
1665         (breakpoint_address_is_meaningful): Delete.
1666         (bl_address_is_meaningful): New.
1667         (breakpoint_locations_match): Adjust comment.
1668         (bp_location_from_bp_type): New, factored out of...
1669         (bp_location::bp_location(breakpoint *)): ... this.
1670         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1671         factored out of...
1672         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1673         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1674         breakpoint_address_is_meaningful.
1675         (bp_locations_compare): Adjust comment.
1676         (update_global_location_list): Use bl_address_is_meaningful
1677         instead of breakpoint_address_is_meaningful.
1678         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1679         explicit.
1680         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1681         * python/py-breakpoint.c (bppy_get_location): No longer check
1682         whether location is null.
1683
1684 2019-07-09  Pedro Alves  <palves@redhat.com>
1685
1686         PR c++/15468
1687         * breakpoint.c (print_one_breakpoint_location): Remove
1688         single-location assert.
1689
1690 2019-07-09  Tom Tromey  <tom@tromey.com>
1691
1692         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1693         * configure: Rebuild.
1694         * configure.ac: Change common to gdbsupport.
1695         * gdbsupport: Rename from common.
1696         * acinclude.m4: Change common to gdbsupport.
1697         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1698         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1699         gdbsupport.
1700         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1701         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1702         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1703         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1704         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1705         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1706         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1707         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1708         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1709         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1710         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1711         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1712         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1713         coff-pe-read.c, command.h, compile/compile-c-support.c,
1714         compile/compile-c.h, compile/compile-cplus-symbols.c,
1715         compile/compile-cplus-types.c, compile/compile-cplus.h,
1716         compile/compile-loc2c.c, compile/compile.c, completer.c,
1717         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1718         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1719         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1720         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1721         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1722         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1723         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1724         features/aarch64-core.c, features/aarch64-fpu.c,
1725         features/aarch64-pauth.c, features/aarch64-sve.c,
1726         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1727         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1728         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1729         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1730         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1731         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1732         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1733         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1734         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1735         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1736         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1737         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1738         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1739         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1740         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1741         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1742         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1743         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1744         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1745         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1746         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1747         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1748         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1749         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1750         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1751         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1752         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1753         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1754         minsyms.c, mips-linux-tdep.c, namespace.h,
1755         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1756         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1757         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1758         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1759         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1760         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1761         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1762         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1763         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1764         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1765         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1766         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1767         procfs.c, producer.c, progspace.h, psymtab.h,
1768         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1769         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1770         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1771         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1772         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1773         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1774         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1775         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1776         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1777         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1778         target-memory.c, target.c, target.h, target/waitstatus.c,
1779         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1780         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1781         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1782         unittests/array-view-selftests.c,
1783         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1784         unittests/common-utils-selftests.c,
1785         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1786         unittests/format_pieces-selftests.c,
1787         unittests/function-view-selftests.c,
1788         unittests/lookup_name_info-selftests.c,
1789         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1790         unittests/mkdir-recursive-selftests.c,
1791         unittests/observable-selftests.c,
1792         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1793         unittests/parse-connection-spec-selftests.c,
1794         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1795         unittests/scoped_fd-selftests.c,
1796         unittests/scoped_mmap-selftests.c,
1797         unittests/scoped_restore-selftests.c,
1798         unittests/string_view-selftests.c, unittests/style-selftests.c,
1799         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1800         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1801         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1802         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1803         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1804         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1805
1806 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1807
1808         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1809         bool value.
1810         (decode_digits_ordinary): Set explicit_line field in sal.
1811         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1812         symtab_and_line that was set on an explicit line number in
1813         assembler code.  Do always update the recorded symtab and line if
1814         we do skip the prologue.
1815
1816 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1817
1818         * breakpoint.c (set_breakpoint_location_function): Remove
1819         explicit_loc parameter.
1820         (momentary_breakpoint_from_master): Update call to
1821         set_breakpoint_location_function.
1822         (add_location_to_breakpoint): Likewise.
1823
1824 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1825
1826         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1827         required features based on default bfd type when no specific bfd
1828         is present.
1829
1830 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1831
1832         * NEWS: Mention that GDB printf and eval commands can now print
1833         C-style and Ada-style convenience var strings without
1834         calling the inferior.
1835         * printcmd.c (printf_c_string): Locally print GDB internal var
1836         instead of transiting via the inferior.
1837         (printf_wide_c_string): Likewise.
1838
1839 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1840
1841         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1842
1843 2019-07-04  Tom Tromey  <tom@tromey.com>
1844
1845         PR tui/24724:
1846         * tui/tui-winsource.c (tui_clear_source_content): Update.
1847         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1848         (tui_update_breakpoint_info): Update.
1849         (tui_set_exec_info_content): Update.
1850         * tui/tui-source.c (tui_set_source_content_nil): Update.
1851         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1852         has_break.
1853         * tui/tui-data.h (enum tui_bp_flag): New.
1854         (tui_bp_flags): New enum flags type.
1855         (struct tui_source_element) <break_mode>: Change type.  Rename
1856         from has_break.
1857         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1858         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1859         constants.
1860         * tui/tui-winsource.h: Fix comment.
1861
1862 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1863
1864         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1865         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1866         (store_fpregs_to_thread)
1867         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1868         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1869         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1870         (IWMMXT_REGS_SIZE): Add define.
1871         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1872         (fetch_vfp_regs, store_vfp_regs)
1873         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1874         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1875
1876 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1877
1878         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1879         defines.
1880         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1881         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1882         (ARM_INT_REGISTER_SIZE): ...to this.
1883         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1884         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1885         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1886         (arm_linux_collect_gregset, supply_nwfpe_register)
1887         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1888         defines.
1889         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1890         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1891         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1892         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1893         (arm_return_in_memory, arm_store_return_value)
1894         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1895         (arm_record_ld_st_multiple): Likewise.
1896         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1897         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1898
1899 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1900
1901         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1902         AARCH64_DISPLACED_MODIFIED_INSNS.
1903         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1904         (aarch64_displaced_step_copy_insn): Likewise.
1905         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1906         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1907         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1908         ARM_DISPLACED_MODIFIED_INSNS.
1909         * arm-tdep.c (arm_gdbarch_init): Likewise.
1910         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1911         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1912         (struct arm_displaced_step_closure): Use
1913         ARM_DISPLACED_MODIFIED_INSNS.
1914
1915 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1916
1917         * features/Makefile: Remove unused xml files.
1918         * features/aarch64.xml: Remove.
1919         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1920         * features/i386/amd64-avx-avx512.xml: Remove.
1921         * features/i386/amd64-avx-linux.xml: Remove.
1922         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1923         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1924         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1925         * features/i386/amd64-avx-mpx.xml: Remove.
1926         * features/i386/amd64-avx.xml: Remove.
1927         * features/i386/amd64-linux.xml: Remove.
1928         * features/i386/amd64-mpx-linux.xml: Remove.
1929         * features/i386/amd64-mpx.xml: Remove.
1930         * features/i386/amd64.xml: Remove.
1931         * features/i386/i386-avx-avx512-linux.xml: Remove.
1932         * features/i386/i386-avx-avx512.xml: Remove.
1933         * features/i386/i386-avx-linux.xml: Remove.
1934         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1935         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1936         * features/i386/i386-avx-mpx-linux.xml: Remove.
1937         * features/i386/i386-avx-mpx.xml: Remove.
1938         * features/i386/i386-avx.xml: Remove.
1939         * features/i386/i386-linux.xml: Remove.
1940         * features/i386/i386-mmx-linux.xml: Remove.
1941         * features/i386/i386-mmx.xml: Remove.
1942         * features/i386/i386-mpx-linux.xml: Remove.
1943         * features/i386/i386-mpx.xml: Remove.
1944         * features/i386/i386.xml: Remove.
1945         * features/i386/x32-avx-avx512-linux.xml: Remove.
1946         * features/i386/x32-avx-linux.xml: Remove.
1947         * features/i386/x32-linux.xml: Remove.
1948
1949 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1950
1951         * regformats/aarch64.dat: Remove.
1952         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1953         * regformats/i386/amd64-avx-linux.dat: Remove.
1954         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1955         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1956         * regformats/i386/amd64-linux.dat: Remove.
1957         * regformats/i386/amd64-mpx-linux.dat: Remove.
1958         * regformats/i386/amd64.dat: Remove.
1959         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1960         * regformats/i386/i386-avx-linux.dat: Remove.
1961         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1962         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1963         * regformats/i386/i386-linux.dat: Remove.
1964         * regformats/i386/i386-mmx-linux.dat: Remove.
1965         * regformats/i386/i386-mpx-linux.dat: Remove.
1966         * regformats/i386/i386.dat: Remove.
1967         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1968         * regformats/i386/x32-avx-linux.dat: Remove.
1969         * regformats/i386/x32-linux.dat: Remove.
1970
1971 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1972
1973         * aarch64-tdep.c: Remove xml self tests.
1974         * amd64-linux-tdep.c: Likewise.
1975         * amd64-tdep.c: Likewise.
1976         * i386-linux-tdep.c: Likewise.
1977         * i386-tdep.c: Likewise.
1978
1979 2019-07-03  Pedro Alves  <palves@redhat.com>
1980
1981         PR cli/24732
1982         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1983         (pipe_cmd_option_defs): New.
1984         (make_pipe_cmd_options_def_group): New.
1985         (pipe_command): Use gdb::option::process_options.
1986         (pipe_command_completer): New function.
1987         (_initialize_cli_cmds): Install completer for "pipe" command.
1988
1989 2019-07-03  Pedro Alves  <palves@redhat.com>
1990
1991         * cli/cli-option.c (union option_value) <string>: New field.
1992         (struct option_def_and_value): Add ctor, move ctor, dtor and
1993         use DISABLE_COPY_AND_ASSIGN.
1994         (option_def_and_value::clear_value): New.
1995         (parse_option, save_option_value_in_ctx, get_val_type_str)
1996         (add_setshow_cmds_for_options): Handle var_string.
1997         * cli-option.h (union option_def::var_address) <string>: New
1998         field.
1999         (struct string_option_def): New.
2000         * maint-test-options.c (struct test_options_opts): Add default
2001         ctor and use DISABLE_COPY_AND_ASSIGN.
2002         <string_opt>: New field.
2003         (test_options_opts::~test_options_opts): New.
2004         (test_options_opts::dump): Also dump "-string".
2005         (test_options_option_defs): Install "string.
2006
2007 2019-07-03  Pedro Alves  <palves@redhat.com>
2008
2009         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2010         option_value with a null enumeration.
2011         (complete_options): Save the option values in the context.
2012         (save_option_value_in_ctx): New, factored out from ...
2013         (process_options): ... here.
2014         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2015         of the function.
2016         * maint-test-options.c (test_options_opts::dump): New, factored
2017         out from ...
2018         (maintenance_test_options_command_mode): ... here.
2019         (maintenance_test_options_command_completion_result): Delete.
2020         (maintenance_test_options_command_completion_text): Update
2021         comment.
2022         (maintenance_show_test_options_completion_result): Change
2023         prototype.  Just print
2024         maintenance_test_options_command_completion_text.
2025         (save_completion_result): New.
2026         (maintenance_test_options_completer_mode): Pass options context to
2027         complete_options, and then save a dump.
2028         (_initialize_maint_test_options): Use add_cmd to install "maint
2029         show test-options-completion-result".
2030
2031 2019-07-03  Pedro Alves  <palves@redhat.com>
2032
2033         * NEWS (New commands): Mention "with" and "maint with".
2034         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2035         (with_command, with_command_completer): New.
2036         (pipe_command): Adjust to new repeat_previous
2037         interface.
2038         (_initialize_cli_cmds): Install the "with" command and its "w"
2039         alias.
2040         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2041         declarations.
2042         * cli/cli-setshow.c (parse_cli_var_uinteger)
2043         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2044         argument strings for all var_types.
2045         (get_setshow_command_value_string): New, factored out from ...
2046         (do_show_command): ... this.
2047         * cli/cli-setshow.h: Include <string>.
2048         (get_setshow_command_value_string): Declare.
2049         * command.h (repeat_previous): Now returns const char *.  Adjust
2050         comment.
2051         * maint.c: Include "cli/cli-cmds.h".
2052         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2053         (_initialize_maint_cmds): Register the "maintenance with" command.
2054         * top.c (repeat_previous): Move bits from pipe_command here:
2055         Return the saved command line, if any; error out if there's no
2056         command to relaunch.
2057
2058 2019-07-03  Pedro Alves  <palves@redhat.com>
2059
2060         * NEWS (New commands): Mention "maint set/show test-settings"
2061         instead of "maint test-settings".
2062         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2063         (maintenance_test_settings_set_list): Rename to ...
2064         (maintenance_set_test_settings_list): ... this.
2065         (maintenance_test_settings_show_list): Rename to  ...
2066         (maintenance_show_test_settings_list): ... this.
2067         (maintenance_test_settings_cmd): Delete.
2068         (maintenance_test_settings_set_cmd): ...
2069         (maintenance_set_test_settings_cmd): ... this.
2070         (maintenance_test_settings_show_cmd): ...
2071         (maintenance_show_test_settings_cmd): ... this.
2072         (maintenance_test_settings_show_value_cmd):
2073         (maintenance_show_test_settings_value_cmd): ... this.
2074         (_initialize_maint_test_settings): No longer install the "maint
2075         test-settings" prefix command.  Rename "maint test-settings set"
2076         to "maint set test-settings", and "maint test-settings show" to
2077         "maint show test-settings".  Adjust all subcommands.
2078
2079 2019-07-03  Pedro Alves  <palves@redhat.com>
2080
2081         * maint-test-settings.c: Fix file's intro comment.  Replace all
2082         references to "test-options" with references to "test-settings",
2083         in comments.
2084
2085 2019-07-03  Pedro Alves  <palves@redhat.com>
2086
2087         * maint-test-settings.c (maintenance_test_settings_xxx)
2088         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2089         New.
2090         (maintenance_test_settings_enums): Use them.
2091         (maintenance_test_settings_enum): Default to
2092         maintenance_test_settings_xxx.
2093         (_initialize_maint_test_settings): Initialize
2094         MAINTENANCE_TEST_SETTINGS_FILENAME.
2095
2096 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2097
2098         * breakpoint.h (remove_breakpoints_inf): Change return type to
2099         void, move function documentation here.
2100         * breakpoint.c (remove_breakpoints_inf): Change return type to
2101         void, move function documentation to header.
2102
2103 2019-07-02  Pedro Alves  <palves@redhat.com>
2104
2105         * NEWS (Completion improvements): Mention "info threads".
2106         * thread.c (struct info_threads_opts, info_threads_option_defs)
2107         (make_info_threads_options_def_group): New.
2108         (info_threads_command): Use gdb::option::process_options.
2109         (info_threads_command_completer): New.
2110         (_initialize_thread): Use gdb::option::build_help to build the
2111         help text for "info threads".
2112
2113 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2114
2115         * defs.h (generic_load): Move from here...
2116         * symfile.h (generic_load): ... to here.  Rename name parameter
2117         to args.
2118         * symfile.c (generic_load): Add comment.
2119
2120 2019-07-01  Tom Tromey  <tromey@adacore.com>
2121
2122         * dwarf2read.c
2123         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2124         declaration of without_params.  Fix formatting.
2125
2126 2019-07-01  Tom Tromey  <tromey@adacore.com>
2127
2128         * ada-exp.y (find_primitive_type): Update.
2129         * ada-lang.h (ada_lookup_symbol): Update.
2130         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2131         parameter.
2132         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2133
2134 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2135
2136         PR breakpoints/24541
2137         * gdbarch.c: Regenerate.
2138         * gdbarch.h: Regenerate.
2139         * gdbarch.sh: Add 'stap_adjust_register'.
2140         * i386-tdep.c: Include '<unordered_set>'.
2141         (i386_stap_adjust_register): New function.
2142         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2143         * stap-probe.c (stap_parse_register_operand): Call
2144         'gdbarch_stap_adjust_register'.
2145
2146 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2147
2148         PR python/24742
2149         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2150         * python/python.c (do_start_initialization): Use 'xmalloc'
2151         instead of 'PyMem_Malloc'.
2152
2153 2019-06-28  Tom Tromey  <tromey@adacore.com>
2154
2155         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2156         for Ada.
2157
2158 2019-06-27  Tom Tromey  <tromey@adacore.com>
2159
2160         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2161         objfile_key.
2162         (arm_find_mapping_symbol, arm_record_special_symbol)
2163         (_initialize_arm_tdep): Update.
2164         (arm_objfile_data_free): Remove.
2165
2166 2019-06-27  Tom Tromey  <tromey@adacore.com>
2167
2168         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2169         to cp_print_static_field.
2170
2171 2019-06-26  Tom Tromey  <tromey@adacore.com>
2172
2173         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2174         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2175         declare.
2176
2177 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2178
2179         * features/aarch64-core.c (create_feature_aarch64_core):
2180         Regenerate.
2181         * features/aarch64-core.xml: Add cpsr flags.
2182
2183 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2184
2185         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2186         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2187
2188 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2189
2190         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2191         field.
2192         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2193         use.
2194         (arm_record_special_symbol): Don't insert new symbol in sorted
2195         position, push it at the end.
2196
2197 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2198
2199         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2200         (arm_mapping_symbol_s): Remove.
2201         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2202         (arm_mapping_symbol_vec): New typedef.
2203         (struct arm_per_objfile): Add constructor.
2204         <section_maps>: Change type to
2205         std::unique_ptr<arm_mapping_symbol_vec[]>.
2206         (arm_compare_mapping_symbols): Remove.
2207         (arm_find_mapping_symbol): Adjust to section_maps type change.
2208         (arm_objfile_data_free): Call delete on arm_per_objfile.
2209         (arm_record_special_symbol): Adjust to section_maps type change.
2210         Allocate arm_per_objfile with new.
2211
2212 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2213
2214         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2215         with the command prefix.
2216
2217 2019-06-25  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2220         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2221
2222 2019-06-25  Tom Tromey  <tom@tromey.com>
2223
2224         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2225         type.
2226         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2227         protected.
2228
2229 2019-06-25  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-winsource.c
2232         (tui_source_window_base::set_is_exec_point_at): Add check against
2233         LOA_ADDRESS.
2234
2235 2019-06-25  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-source.c (tui_set_source_content): Don't check before
2238         xfree.
2239         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2240
2241 2019-06-25  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-winsource.h (tui_update_source_window_as_is)
2244         (tui_alloc_source_buffer, tui_line_is_displayed)
2245         (tui_addr_is_displayed): Change type of win_info.
2246         * tui/tui-winsource.c (tui_update_source_window_as_is)
2247         (tui_clear_source_content, tui_show_source_line)
2248         (tui_show_source_content, tui_source_window_base::refill)
2249         (tui_source_window_base::set_is_exec_point_at)
2250         (tui_source_window_base::set_is_exec_point_at)
2251         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2252         (tui_alloc_source_buffer, tui_line_is_displayed)
2253         (tui_addr_is_displayed): Change type of win_info.  Update.
2254         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2255         (tui_source_window_base::do_make_visible_with_new_height):
2256         Update.
2257         * tui/tui-source.c (tui_set_source_content)
2258         (tui_set_source_content_nil)
2259         (tui_source_window::do_scroll_vertical): Update.
2260         * tui/tui-layout.c (show_layout): Update.
2261         * tui/tui-disasm.c (tui_set_disassem_content)
2262         (tui_disasm_window::do_scroll_vertical): Update.
2263         * tui/tui-data.h (tui_win_content): Remove.
2264         (struct tui_gen_win_info) <content, content_size>: Remove.
2265         (struct tui_source_element): Add initializers and destructor.
2266         (union tui_which_element, struct tui_win_element): Remove.
2267         (struct tui_source_window_base) <content>: New field.
2268         (struct tui_data_window): Remove destructor.
2269         (tui_alloc_content, tui_free_win_content)
2270         (tui_free_all_source_wins_content): Don't declare.
2271         * tui/tui-data.c (tui_initialize_static_data): Update.
2272         (init_content_element, tui_alloc_content): Remove.
2273         (~tui_gen_win_info): Update.
2274         (~tui_data_window, tui_free_all_source_wins_content)
2275         (tui_free_win_content, free_content, free_content_elements):
2276         Remove.
2277
2278 2019-06-25  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-winsource.h (tui_clear_source_content)
2281         (tui_erase_source_content, tui_show_source_content): Change type
2282         of win_info.
2283         * tui/tui-winsource.c (tui_clear_source_content)
2284         (tui_erase_source_content, tui_show_source_content): Change type
2285         of win_info.
2286         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2287         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2288         win_info.
2289         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2290         win_info.
2291         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2292
2293 2019-06-25  Tom Tromey  <tom@tromey.com>
2294
2295         * tui/tui-winsource.c (tui_clear_source_content)
2296         (tui_source_window_base::set_is_exec_point_at): Update.
2297         * tui/tui-source.c (tui_set_source_content_nil): Update.
2298         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2299         a bool.
2300         * tui/tui-data.c (init_content_element): Update.
2301
2302 2019-06-25  Tom Tromey  <tom@tromey.com>
2303
2304         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2305         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2306         * tui/tui-layout.c (init_and_make_win): Update.
2307         * tui/tui.h (enum tui_win_type): Update.
2308         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2309         tui_win_is_auxillary.
2310         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2311         tui_win_is_auxillary.
2312
2313 2019-06-25  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2316         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2317         (tui_delete_data_content_windows, tui_display_all_data)
2318         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2319         Update.
2320         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2321         * tui/tui-regs.c (tui_last_regs_line_no)
2322         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2323         (tui_show_registers): Update.
2324         (tui_show_register_group): Return void.  Update.
2325         (tui_display_registers_from, tui_display_reg_element_at_line)
2326         (tui_display_registers_from_line, tui_check_register_values):
2327         Update.
2328         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2329         member.
2330         (struct tui_data_window) <regs_content>: Now a std::vector.
2331         <regs_content_count>: Remove.
2332         (tui_add_content_elements, tui_free_data_content): Don't declare.
2333         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2334         (init_content_element): Remove DATA_WIN case.  Add assert.
2335         (tui_add_content_elements): Remove.
2336         (tui_data_window): Update.
2337         (tui_free_data_content): Remove.
2338         (free_content_elements): Remove DATA_WIN case.
2339
2340 2019-06-25  Tom Tromey  <tom@tromey.com>
2341
2342         * tui/tui-data.c (tui_data_item_window): Update.
2343         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2344         * tui/tui-windata.c (tui_display_all_data)
2345         (tui_display_data_from_line): Update.
2346         (tui_check_data_values): Remove.
2347         * tui/tui-regs.c (tui_show_register_group)
2348         (tui_display_reg_element_at_line): Update.
2349         * tui/tui-hooks.c (tui_register_changed)
2350         (tui_refresh_frame_and_register_information): Call
2351         tui_check_register_values.
2352         * tui/tui-data.h (struct tui_data_window) <data_content,
2353         data_content_count, data_type>: Remove.
2354         (enum tui_data_type): Remove.
2355
2356         * tui/tui-data.c (tui_data_window::clear_detail)
2357         (~tui_data_window): Update.
2358
2359 2019-06-25  Tom Tromey  <tom@tromey.com>
2360
2361         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2362         declare.
2363         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2364         Rename from tui_first_data_item_displayed.  Update.
2365         (tui_data_window::refresh_all)
2366         (tui_data_window::do_scroll_vertical): Update.
2367         * tui/tui-data.h (struct tui_data_window)
2368         <first_data_item_displayed>: Declare new method.
2369
2370 2019-06-25  Tom Tromey  <tom@tromey.com>
2371
2372         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2373         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2374         contents...
2375         (tui_initialize_static_data): ...here.
2376
2377 2019-06-25  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2380         (tui_display_registers_from, tui_check_register_values): Update.
2381         (tui_display_register): Remove win_info parameter; update.
2382         (tui_get_register): Change type of parameters.
2383         * tui/tui-data.h (struct tui_data_element): Remove.
2384         (union tui_which_element) <data>: Remove.
2385         <data_window>: Change type.
2386         (struct tui_data_item_window): New.
2387         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2388         case.  Add assert.
2389         (~tui_data_item_window): New destructor.
2390         (free_content_elements): Remove DATA_ITEM_WIN case.
2391
2392 2019-06-25  Tom Tromey  <tom@tromey.com>
2393
2394         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2395         Remove.
2396
2397 2019-06-25  Tom Tromey  <tom@tromey.com>
2398
2399         * tui/tui-data.h (struct tui_command_element): Remove.
2400         (union tui_which_element) <command>: Remove.
2401         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2402         assert.
2403         (free_content_elements): Remove CMD_WIN case.
2404
2405 2019-06-25  Tom Tromey  <tom@tromey.com>
2406
2407         * tui/tui-layout.c (tui_set_layout): Update.
2408         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2409         * tui/tui-data.c (layout_def): Update.
2410
2411 2019-06-25  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2414         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2415         (tui_source_window_base::set_new_height): Update.
2416         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2417         Update.
2418         (tui_set_locator_fullname, tui_set_locator_info)
2419         (tui_show_frame_info): Update.
2420         * tui/tui-source.c (tui_set_source_content)
2421         (tui_source_is_displayed): Update.
2422         * tui/tui-layout.c (show_source_disasm_command, show_data)
2423         (show_source_or_disasm_and_command): Update.
2424         * tui/tui-disasm.c (tui_set_disassem_content)
2425         (tui_get_begin_asm_address): Update.
2426         * tui/tui-data.h (struct tui_locator_element): Remove.
2427         (union tui_which_element) <locator>: Remove.
2428         (struct tui_locator_window): New.
2429         (tui_locator_win_info_ptr): Change return type.
2430         * tui/tui-data.c (_locator): Change type.
2431         (tui_locator_win_info_ptr): Change return type.
2432         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2433         (tui_alloc_content): Add assert.
2434
2435 2019-06-25  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-winsource.c
2438         (tui_exec_info_window::maybe_allocate_content): New method.
2439         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2440         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2441         (make_source_or_disasm_window): Add cast.
2442         * tui/tui-data.h (union tui_which_element) <simple_string>:
2443         Remove.
2444         (struct tui_source_info): New.
2445         (struct tui_source_window_base) <execution_info>: Change type.
2446         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2447         case, and add assert.
2448         (tui_alloc_content): Add assert.
2449
2450 2019-06-25  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2453         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2454         * tui/tui-data.c (tui_alloc_win_info): Remove.
2455
2456 2019-06-25  Tom Tromey  <tom@tromey.com>
2457
2458         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2459         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2460         can_highlight.
2461
2462 2019-06-25  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2465         make_visible_with_new_height method.
2466         (tui_win_info::make_visible_with_new_height): New method.
2467         (tui_source_window_base::do_make_visible_with_new_height)
2468         (tui_data_window::do_make_visible_with_new_height)
2469         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2470         (make_visible_with_new_height): Remove.
2471         (tui_resize_all, tui_adjust_win_heights): Use
2472         make_visible_with_new_height method.
2473         * tui/tui-data.h (struct tui_win_info)
2474         <do_make_visible_with_new_height, make_visible_with_new_height>:
2475         New methods.
2476         (struct tui_source_window_base, struct tui_data_window)
2477         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2478         methods.
2479
2480 2019-06-25  Tom Tromey  <tom@tromey.com>
2481
2482         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2483         method.
2484         (update_tab_width): Call update_tab_width method.
2485         * tui/tui-data.h (struct tui_win_info)
2486         (struct tui_source_window_base) <update_tab_width>: New methods.
2487
2488 2019-06-25  Tom Tromey  <tom@tromey.com>
2489
2490         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2491         parameter.
2492         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2493         parameter.
2494         (tui_gen_win_info::make_visible): Update.
2495         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2496         parameter.
2497         * tui/tui-data.h (enum tui_box): New enum.
2498         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2499
2500 2019-06-25  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2503         init_and_make_win for EXEC_INFO_WIN.
2504         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2505         longer inline.
2506         (struct tui_win_info) <~tui_win_info>: Inline.
2507         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2508         Don't declare.
2509         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2510         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2511         Remove.
2512         (tui_initialize_static_data): Update.
2513         (~tui_gen_win_info): Handle more cleanup here.
2514         (~tui_source_window_base): Delete "execution_info".
2515         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2516
2517 2019-06-25  Tom Tromey  <tom@tromey.com>
2518
2519         * tui/tui-layout.c (make_command_window): Don't set
2520         can_highlight.
2521         (show_source_disasm_command): Call the reset method.
2522         (show_data): Don't set can_highlight.  Call the reset method.
2523         (tui_gen_win_info::reset): Rename from init_gen_win_info
2524         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2525         (show_source_or_disasm_and_command): Call the reset method.
2526         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2527         (struct tui_cmd_window): Set can_highlight.
2528
2529 2019-06-25  Tom Tromey  <tom@tromey.com>
2530
2531         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2532         from make_visible.
2533         (tui_make_visible, tui_make_invisible): Rewrite.
2534         (tui_win_info::make_visible): Remove.
2535         (tui_source_window_base::make_visible): Update.
2536         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2537         method.  Moved from...
2538         (struct tui_win_info) <make_visible>: ...here.
2539
2540 2019-06-25  Tom Tromey  <tom@tromey.com>
2541
2542         * tui/tui-winsource.c
2543         (tui_source_window_base::do_scroll_horizontal): Remove direction
2544         parameter.
2545         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2546         direction parameter.
2547         * tui/tui-win.c (tui_win_info::forward_scroll)
2548         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2549         (tui_win_info::right_scroll): Update.
2550         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2551         direction parameter.
2552         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2553         direction parameter.
2554         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2555         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2556         Remove direction parameter.
2557         (struct tui_source_window_base, struct tui_source_window)
2558         (struct tui_disasm_window, struct tui_data_window)
2559         (struct tui_cmd_window): Update.
2560
2561 2019-06-25  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-winsource.h (tui_set_exec_info_content)
2564         (tui_show_exec_info_content, tui_erase_exec_info_content)
2565         (tui_clear_exec_info_content, tui_update_exec_info): Change
2566         argument to tui_source_window_base.
2567         * tui/tui-winsource.c (tui_set_exec_info_content)
2568         (tui_show_exec_info_content, tui_erase_exec_info_content)
2569         (tui_clear_exec_info_content, tui_update_exec_info): Change
2570         argument to tui_source_window_base.
2571
2572 2019-06-25  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2575         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2576
2577 2019-06-25  Tom Tromey  <tom@tromey.com>
2578
2579         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2580         check.
2581
2582 2019-06-25  Tom Tromey  <tom@tromey.com>
2583
2584         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2585         type to void.
2586         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2587         type to void.
2588         * tui/tui-source.c (tui_set_source_content): Update.
2589         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2590
2591 2019-06-25  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-win.c (window_name_completer, tui_set_focus)
2594         (tui_all_windows_info): Use name method.
2595         * tui/tui-data.h (struct tui_gen_win_info)
2596         (struct tui_source_window, struct tui_disasm_window)
2597         (struct tui_data_window, struct tui_cmd_window) <name>: New
2598         method.
2599         (tui_win_name): Don't declare.
2600         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2601         (tui_win_name): Remove.
2602
2603 2019-06-25  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-winsource.h (tui_update_source_window)
2606         (tui_update_source_window_as_is): Change parameter type.
2607         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2608         to be a tui_source_window_base.
2609         (tui_update_source_window_as_is): Likewise.
2610         * tui/tui-win.c (make_visible_with_new_height): Update.
2611
2612 2019-06-25  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-winsource.c (tui_erase_source_content)
2615         (tui_show_source_content, tui_show_exec_info_content)
2616         (tui_erase_exec_info_content): Use refresh_window method.
2617         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2618         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2619         from tui_refresh_win.
2620         (tui_data_window::refresh_window): New method.
2621         (tui_win_info::refresh, tui_source_window_base::refresh)
2622         (tui_refresh_all): Use refresh_window method.
2623         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2624         method.
2625         * tui/tui-regs.c (tui_display_register): Call refresh_window
2626         method.
2627         * tui/tui-layout.c (show_source_disasm_command)
2628         (show_source_or_disasm_and_command): Call refresh_window method.
2629         * tui/tui-data.h (struct tui_gen_win_info)
2630         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2631         New method.
2632
2633 2019-06-25  Tom Tromey  <tom@tromey.com>
2634
2635         * tui/tui.c (tui_rl_other_window, tui_enable)
2636         (tui_is_window_visible, tui_get_command_dimension): Update.
2637         * tui/tui-winsource.c (tui_update_source_window_as_is)
2638         (tui_clear_source_content, tui_erase_source_content)
2639         (tui_show_source_line, tui_source_window_base::refill)
2640         (tui_source_window_base::do_scroll_horizontal)
2641         (tui_source_window_base::set_is_exec_point_at)
2642         (tui_update_breakpoint_info, tui_set_exec_info_content)
2643         (tui_alloc_source_buffer, tui_line_is_displayed)
2644         (tui_addr_is_displayed): Update.
2645         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2646         (tui_check_and_display_highlight_if_needed)
2647         (tui_win_info::make_visible, tui_win_info::refresh)
2648         (tui_refresh_all): Update.
2649         * tui/tui-windata.c (tui_first_data_item_displayed)
2650         (tui_delete_data_content_windows, tui_erase_data_content)
2651         (tui_display_all_data, tui_data_window::refresh_all)
2652         (tui_check_data_values): Update.
2653         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2654         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2655         (tui_win_info::backward_scroll, tui_refresh_all_win)
2656         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2657         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2658         (tui_source_window_base::set_new_height)
2659         (tui_data_window::set_new_height)
2660         (make_invisible_and_set_new_height)
2661         (make_visible_with_new_height, new_height_ok)
2662         (parse_scrolling_args): Update.
2663         * tui/tui-stack.c (tui_show_frame_info): Update.
2664         * tui/tui-source.c (tui_set_source_content)
2665         (tui_set_source_content_nil, tui_source_is_displayed)
2666         (tui_source_window::do_scroll_vertical): Update.
2667         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2668         (tui_display_registers_from, tui_display_reg_element_at_line)
2669         (tui_check_register_values, tui_reg_command): Update.
2670         * tui/tui-layout.c (tui_default_win_height)
2671         (show_source_disasm_command, show_data, init_and_make_win)
2672         (show_source_or_disasm_and_command): Update.
2673         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2674         (tui_redisplay_readline, tui_mld_flush)
2675         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2676         (tui_getc): Update.
2677         * tui/tui-disasm.c (tui_set_disassem_content)
2678         (tui_disasm_window::do_scroll_vertical): Update.
2679         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2680         Now virtual.
2681         (struct tui_win_info): Derive from tui_gen_win_info.
2682         <~tui_win_info>: Mark as override.
2683         <generic>: Remove member.
2684         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2685         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2686         (~tui_data_window, ~tui_win_info)
2687         (tui_free_all_source_wins_content): Update.
2688         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2689
2690 2019-06-25  Tom Tromey  <tom@tromey.com>
2691
2692         * tui/tui-layout.c (init_and_make_win): Use new.
2693         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2694         destructor, initializers.
2695         (tui_alloc_generic_win_info): Don't declare.
2696         * tui/tui-data.c (_locator): Add argument to constructor.
2697         (source_win, disasm_win): New globals.
2698         (exec_info): Remove.
2699         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2700         Update.
2701         (tui_alloc_generic_win_info): Remove.
2702         (init_content_element): Use new.
2703         (tui_win_info::tui_win_info): Update.
2704         (free_content_elements) <case DATA_WIN>: Use delete.
2705
2706 2019-06-25  Tom Tromey  <tom@tromey.com>
2707
2708         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2709         * tui/tui-windata.c (tui_first_data_item_displayed)
2710         (tui_delete_data_content_windows): Update.
2711         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2712         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2713         (tui_display_registers_from, tui_check_register_values): Update.
2714         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2715         pointer.
2716         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2717         window.
2718         (tui_free_data_content): Update.
2719         (free_content_elements) <case DATA_WIN>: Free the window.
2720
2721 2019-06-25  Tom Tromey  <tom@tromey.com>
2722
2723         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2724         Update.
2725         * tui/tui-layout.c (make_command_window)
2726         (show_source_disasm_command, show_data, init_and_make_win)
2727         (show_source_or_disasm_and_command): Update.
2728         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2729         method.
2730         <can_highight, is_highlighted>: Now bool.
2731         (tui_set_win_highlight): Don't declare.
2732         * tui/tui-data.c (tui_set_win_highlight): Remove.
2733
2734 2019-06-25  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-wingeneral.c (make_visible): Remove check of window
2737         type.
2738
2739 2019-06-25  Tom Tromey  <tom@tromey.com>
2740
2741         * tui/tui-win.c (tui_win_info::max_height)
2742         (tui_cmd_window::max_height): New methods.
2743         (new_height_ok): Call max_height.
2744         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2745         <max_height>: New method.
2746
2747 2019-06-25  Tom Tromey  <tom@tromey.com>
2748
2749         * tui/tui-win.c (tui_source_window_base::set_new_height)
2750         (tui_data_window::set_new_height): New methods.
2751         (make_invisible_and_set_new_height): Call set_new_height method.
2752         * tui/tui-data.h (struct tui_win_info)
2753         (struct tui_source_window_base, struct tui_data_window)
2754         <set_new_height>: New method.
2755
2756 2019-06-25  Tom Tromey  <tom@tromey.com>
2757
2758         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2759         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2760         tui_refresh_data_win.
2761         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2762         method.
2763         (tui_refresh_all_win): Call the refresh_all method.
2764         (tui_set_focus): Likewise.
2765         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2766         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2767         Likewise.
2768
2769 2019-06-25  Tom Tromey  <tom@tromey.com>
2770
2771         * tui/tui-winsource.h (tui_refill_source_window)
2772         (tui_set_is_exec_point_at): Don't declare.
2773         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2774         (tui_source_window_base::refill): Rename from
2775         tui_refill_source_window.
2776         (tui_source_window_base::do_scroll_horizontal): Update.
2777         (tui_source_window_base::set_is_exec_point_at): Rename from
2778         tui_set_is_exec_point_at.
2779         (tui_update_all_breakpoint_info): Update.
2780         * tui/tui-stack.c (tui_show_frame_info): Update.
2781         * tui/tui-layout.c (show_data): Add cast.
2782         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2783         * tui/tui-data.h (struct tui_source_window_base) <refill,
2784         set_is_exec_point_at>: New methods.
2785         (tui_source_windows, tui_add_to_source_windows): Update types.
2786         (tui_add_to_source_windows): Remove redundant declaration.
2787         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2788         (tui_source_windows): Change return type.
2789         (tui_clear_source_windows_detail): Update.
2790         (tui_add_to_source_windows): Change type of parameter.
2791         (tui_free_all_source_wins_content): Update.
2792
2793 2019-06-25  Tom Tromey  <tom@tromey.com>
2794
2795         * tui/tui-wingeneral.c (tui_win_info::refresh)
2796         (tui_source_window_base::refresh): New methods.
2797         (tui_refresh_all): Call the refresh method.
2798         * tui/tui-data.h (struct tui_win_info)
2799         (struct tui_source_window_base) <refresh>: New method.
2800
2801 2019-06-25  Tom Tromey  <tom@tromey.com>
2802
2803         * tui/tui.h (tui_is_window_visible): Return bool.
2804         * tui/tui.c (tui_is_window_visible): Return bool.
2805         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2806         (tui_make_visible, tui_make_invisible)
2807         (tui_win_info::make_visible)
2808         (tui_source_window_base::make_visible, make_all_visible)
2809         (tui_make_all_visible, tui_make_all_invisible): Update.
2810         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2811         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2812         bool.
2813         (struct tui_win_info, struct tui_source_window_base)
2814         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2815         * tui/tui-data.c (tui_init_generic_part): Update.
2816
2817 2019-06-25  Tom Tromey  <tom@tromey.com>
2818
2819         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2820         (tui_source_window_base::make_visible): New methods.
2821         (make_all_visible): Make method call.
2822         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2823         (struct tui_source_window_base, struct tui_cmd_window): Override
2824         make_visible.
2825         (tui_win_is_source_type): Don't declare.
2826         * tui/tui-data.c (tui_win_is_source_type): Remove.
2827
2828 2019-06-25  Tom Tromey  <tom@tromey.com>
2829
2830         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2831         NULL check.
2832
2833 2019-06-25  Tom Tromey  <tom@tromey.com>
2834
2835         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2836         Inline constructor.  Add initializers for members.
2837         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2838         constructors; now inline in class.
2839
2840 2019-06-25  Tom Tromey  <tom@tromey.com>
2841
2842         * tui/tui-regs.c (tui_show_registers): Update.
2843         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2844         bool.
2845         * tui/tui-data.c (tui_data_window::clear_detail)
2846         (tui_data_window): Update.
2847
2848 2019-06-25  Tom Tromey  <tom@tromey.com>
2849
2850         * tui/tui-windata.c (tui_display_all_data)
2851         (tui_display_data_from_line, tui_display_data_from)
2852         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2853         Update.
2854         * tui/tui-regs.c (tui_last_regs_line_no)
2855         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2856         (tui_show_registers, tui_show_register_group)
2857         (tui_display_registers_from, tui_display_reg_element_at_line)
2858         (tui_display_registers_from_line, tui_check_register_values)
2859         (tui_reg_next, tui_reg_prev): Update.
2860         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2861         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2862         tui_data_window.
2863         (struct tui_win_info) <detail>: Remove.  Add new fields from
2864         tui_data_info.
2865         (TUI_DATA_WIN): Add cast.
2866         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2867         (~tui_data_window): Simplify.
2868
2869 2019-06-25  Tom Tromey  <tom@tromey.com>
2870
2871         * tui/tui-layout.c (show_source_disasm_command)
2872         (show_source_or_disasm_and_command): Update.
2873         * tui/tui-io.c (update_cmdwin_start_line)
2874         (tui_redisplay_readline): Update.
2875         * tui/tui-data.h (struct tui_command_info): Remove.
2876         (struct tui_win_info) <detail>: Remove command_info member.
2877         (struct tui_data_window) <start_line>: New member, from
2878         tui_command_info.
2879         (TUI_CMD_WIN): Add casts.
2880
2881 2019-06-25  Tom Tromey  <tom@tromey.com>
2882
2883         * tui/tui-winsource.c (tui_update_source_window)
2884         (tui_refill_source_window)
2885         (tui_source_window_base::do_scroll_horizontal)
2886         (tui_update_breakpoint_info, tui_set_exec_info_content)
2887         (tui_show_exec_info_content, tui_erase_exec_info_content)
2888         (tui_clear_exec_info_content): Update.
2889         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2890         Update.
2891         * tui/tui-win.c (make_invisible_and_set_new_height)
2892         (make_visible_with_new_height): Update.
2893         * tui/tui-source.c (tui_set_source_content)
2894         (tui_show_symtab_source): Update.
2895         * tui/tui-layout.c (extract_display_start_addr)
2896         (show_source_disasm_command, show_data)
2897         (make_source_or_disasm_window)
2898         (show_source_or_disasm_and_command): Update.
2899         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2900         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2901         "gdbarch".
2902         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2903         to tui_source_window_base.
2904         (struct tui_win_info) <detail>: Remove source_info member.
2905         (struct tui_source_window_base) <has_locator>: Inline.
2906         Move contents from tui_source_info; rename has_locator member to
2907         m_has_locator.
2908         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2909         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2910         header file.
2911         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2912         Simplify.
2913         (tui_free_all_source_wins_content): Cast to
2914         tui_source_window_base.
2915
2916 2019-06-25  Tom Tromey  <tom@tromey.com>
2917
2918         * tui/tui-win.c (make_invisible_and_set_new_height)
2919         (make_visible_with_new_height): Call has_locator method.
2920         * tui/tui-layout.c (show_source_disasm_command, show_data)
2921         (show_source_or_disasm_and_command): Update for bool change.
2922         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2923         (tui_win_info) <has_locator>: New method.
2924         (struct tui_source_window_base) <has_locator>: New method.
2925         (tui_win_has_locator): Don't declare.
2926         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2927         from tui_win_has_locator.
2928         (tui_source_window_base): Use false, not FALSE.
2929
2930 2019-06-25  Tom Tromey  <tom@tromey.com>
2931
2932         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2933         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2934         clear_detail method directly.
2935         (tui_clear_win_detail): Remove.
2936
2937 2019-06-25  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2940         "this", not TUI_DISASM_WIN.
2941
2942 2019-06-25  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2945         declare.
2946         * tui/tui-winsource.c
2947         (tui_source_window_base::do_scroll_horizontal): Rename from
2948         tui_horizontal_source_scroll.
2949         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2950         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2951         from tui_vertical_data_scroll.
2952         * tui/tui-win.h (tui_scroll): Don't declare.
2953         * tui/tui-win.c (tui_win_info::forward_scroll)
2954         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2955         (tui_win_info::right_scroll): Rename and update.
2956         (tui_scroll_forward_command, tui_scroll_backward_command)
2957         (tui_scroll_left_command, tui_scroll_right_command): Update.
2958         (tui_scroll): Remove.
2959         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2960         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2961         from tui_vertical_source_scroll.
2962         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2963         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2964         from tui_vertical_disassem_scroll.
2965         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2966         do_scroll_horizontal>: New methods.
2967         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2968         Likewise.
2969         (struct tui_source_window_base): Add do_scroll_horizontal.
2970         (struct tui_source_window, struct tui_disasm_window): Add
2971         do_scroll_vertical.
2972         (struct tui_data_window, struct tui_cmd_window): Add
2973         do_scroll_horizontal and do_scroll_vertical.
2974         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2975
2976 2019-06-25  Tom Tromey  <tom@tromey.com>
2977
2978         * tui/tui-data.h (struct tui_source_window_base): New struct.
2979         (struct tui_source_window): Derive from tui_source_window_base.
2980         (struct tui_disasm_window): New struct.
2981         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2982         from tui_source_window::clear_detail.
2983         (tui_source_window_base): Rename from tui_source_window.
2984         (~tui_source_window_base): Rename from ~tui_source_window.
2985         (tui_alloc_win_info): Create a tui_disasm_window.
2986
2987 2019-06-25  Tom Tromey  <tom@tromey.com>
2988
2989         * tui/tui-data.h (struct tui_source_window)
2990         (struct tui_data_window): Declare destructors.
2991         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2992         destructors.
2993         (tui_win_info): Simplify.
2994
2995 2019-06-25  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui-winsource.c (tui_display_main)
2998         (tui_update_source_windows_with_addr)
2999         (tui_update_all_breakpoint_info): Update.
3000         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3001         (new_height_ok, parse_scrolling_args): Update.
3002         * tui/tui-stack.c (tui_show_frame_info): Update.
3003         * tui/tui-data.h (struct tui_list): Remove.
3004         (tui_source_windows): Return a reference to a std::vector.
3005         * tui/tui-data.c (source_windows): Now a std::vector.
3006         (tui_source_windows): Change return type.
3007         (tui_clear_source_windows): Rewrite.
3008         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3009         (tui_free_all_source_wins_content): Rewrite.
3010
3011 2019-06-25  Tom Tromey  <tom@tromey.com>
3012
3013         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3014         (struct tui_data_window, struct tui_cmd_window): Declare
3015         clear_detail method.
3016         * tui/tui-data.c (tui_source_window::clear_detail)
3017         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3018         methods.
3019         (tui_clear_win_detail): Simplify.
3020
3021 2019-06-25  Tom Tromey  <tom@tromey.com>
3022
3023         * tui/tui-layout.c (make_source_window, make_disasm_window)
3024         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3025         Return the new window.
3026         (show_source_disasm_command, show_data)
3027         (show_source_or_disasm_and_command): Update.
3028
3029 2019-06-25  Tom Tromey  <tom@tromey.com>
3030
3031         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3032         parameter.  Return the new window.
3033         (show_source_disasm_command): Update and remove NULL check.
3034         (show_source_or_disasm_and_command): Update.
3035
3036 2019-06-25  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3039
3040 2019-06-25  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui-data.h (struct tui_win_info): Make constructor
3043         protected.  Make destructor virtual.  Add initializers.
3044         (tui_source_window, tui_data_window, tui_cmd_window): New
3045         classes.
3046         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3047         constructor.  Add "type" parameter.
3048         (tui_source_window, tui_data_window, tui_cmd_window): New
3049         constructors.
3050         (tui_alloc_win_info): Instantiate the appropriate subclass.
3051
3052 2019-06-25  Tom Tromey  <tom@tromey.com>
3053
3054         * tui/tui-win.c (tui_resize_all): Use delete.
3055         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3056         destructor.
3057         (tui_free_window): Don't declare.
3058         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3059         Update.
3060
3061 2019-06-25  Tom Tromey  <tom@tromey.com>
3062
3063         * tui/tui-data.h (struct tui_win_info): Add constructor.
3064         * tui/tui-data.c (tui_alloc_win_info): Use new.
3065         (tui_free_window): Use delete.
3066
3067 2019-06-22  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3070         declare.
3071         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3072
3073 2019-06-22  Tom Tromey  <tom@tromey.com>
3074
3075         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3076         declare.
3077         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3078
3079 2019-06-22  Tom de Vries  <tdevries@suse.de>
3080
3081         * dwarf2read.c (create_addrmap_from_aranges)
3082         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3083         instead of '%zu'.
3084
3085 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3086
3087         * dwarf2read.h (dwarf2_section_info_def): Remove.
3088         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3089         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3090         std::vector<dwarf2_section_info>.
3091         (struct dwo_file) <~dwo_file>: Remove.
3092         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3093         types field.
3094         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3095         (dwarf2_read_debug_names): Likewise.
3096         (create_debug_types_hash_table): Change parameter type to
3097         array_view, adjust code accordingly.
3098         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3099         (partial_die_info::fixup): Likewise.
3100         (determine_prefix): Likewise.
3101         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3102
3103 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3104
3105         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3106         gdb_bfd_ref_ptr.
3107         <~dwo_file>: Remove call to gdb_bfd_unref.
3108         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3109         gdb_bfd_ref_ptr::get.
3110
3111 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3112
3113         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3114         type to htab_up.
3115         * dwarf2read.c (struct dwo_file): Initialize fields.
3116         <~dwo_file>: New.
3117         (free_dwo_file): Remove, move content to ~dwo_file.
3118         (struct dwo_file_deleter): Remove.
3119         (dwo_file_up>: Remove custom deleter.
3120         (free_dwo_files): Remove.
3121         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3122         dwo_files.
3123         (process_skeletonless_type_units): Call unique_ptr::get.
3124         (allocate_dwo_file_hash_table): Add deleter to created hash
3125         table.  Change return type to htab_up.
3126         (lookup_dwo_file_slot): Don't memset dwo_file, call
3127         unique_ptr::get.
3128         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3129         (create_dwo_unit_in_dwp_v2): Likewise.
3130         (open_and_init_dwo_file): Likewise.
3131         (free_dwo_file_from_slot): Remove.
3132
3133 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3134
3135         * dwarf2read.h (struct dwarf2_section_info) <readin,
3136         is_virtual>: Change type to bool.
3137         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3138         true instead of 1.
3139
3140 2019-06-19  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-data.h (tui_init_content_element): Don't declare.
3143
3144 2019-06-19  Tom Tromey  <tom@tromey.com>
3145
3146         * tui/tui-data.h (tui_init_win_info): Don't declare.
3147
3148 2019-06-19  Tom de Vries  <tdevries@suse.de>
3149
3150         * dwarf2read.h (abstract_to_concrete): Change type to
3151         std::unordered_map<sect_offset, std::vector<sect_offset>,
3152         gdb::hash_enum<sect_offset>>.
3153
3154 2019-06-19  Tom Tromey  <tromey@adacore.com>
3155
3156         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3157         EVAL_AVOID_SIDE_EFFECTS specially.
3158
3159 2019-06-19  Tom Tromey  <tromey@adacore.com>
3160
3161         * source-cache.c (highlighter): New global.
3162         (source_cache::get_source_lines): Create a highlighter on demand.
3163
3164 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3165
3166         * defs.h (deprecated_interactive_hook): Delete declaration.
3167         * interps.c (clear_interpreter_hooks): Remove use of
3168         deprecated_interactive_hook.
3169         * top.c (deprecated_interactive_hook): Delete definition.
3170         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3171
3172 2019-06-18  Tom de Vries  <tdevries@suse.de>
3173
3174         PR gdb/24515
3175         * dwarf2read.h (abstract_to_concrete): Change type from
3176         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3177         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3178         * dwarf2read.c (read_variable): Update.
3179         (dwarf2_fetch_die_loc_sect_off): Update.
3180
3181 2019-06-17  Tom de Vries  <tdevries@suse.de>
3182
3183         PR gdb/24617
3184         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3185         accessing parent[parent_len - 1].
3186
3187 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3188
3189         PR gdb/24364
3190         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3191         call dtrace_process_dof with NULL dof.
3192
3193 2019-06-16  Tom de Vries  <tdevries@suse.de>
3194
3195         PR gdb/24445
3196         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3197
3198 2019-06-16  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3201         (make_all_visible): Use address of member.
3202
3203 2019-06-16  Tom Tromey  <tom@tromey.com>
3204
3205         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3206         (tui_free_window, free_content, free_content_elements): Remove
3207         unnecessary cast.
3208         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3209         cast.
3210         * tui/tui-regs.c (tui_show_register_group)
3211         (tui_display_registers_from, tui_display_reg_element_at_line):
3212         Remove unnecessary cast.
3213
3214 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3215
3216         * linux-nat.c (normal_mask): Delete.
3217         (_initialize_linux_nat): Don't initialise normal_mask.
3218
3219 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3220
3221         PR gdb/24445
3222         * dwarf-index-write.h (write_psymtabs_to_index): Add
3223         dwz_basename parameter.
3224         * dwarf-index-write.c (write_gdbindex): Move file writing to
3225         write_gdbindex_1.  Change return type void.
3226         (assert_file_size): Move up, remove filename parameter.
3227         (write_gdbindex_1): New function.
3228         (write_debug_names): Change return type to void, call
3229         assert_file_size.
3230         (struct index_wip_file): New struct.
3231         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3232         file logic to index_wip_file.  Write index for dwz file if
3233         needed.
3234         (save_gdb_index_command): Pass basename of dwz file, if present.
3235         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3236         build-id of dwz file, if present.
3237         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3238         (dwarf2_get_dwz_file): Likewise.
3239         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3240         (dwarf2_get_dwz_file): Likewise.
3241
3242 2019-06-16  Tom Tromey  <tom@tromey.com>
3243
3244         * coffread.c (process_coff_symbol): Use xstrdup.
3245         * value.c (create_internalvar): Use xstrdup.
3246
3247 2019-06-16  Tom Tromey  <tom@tromey.com>
3248
3249         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3250         * breakpoint.c (stopin_command, stopat_command)
3251         (until_break_command, decode_location_default): Remove unnecessary
3252         cast.
3253         * utils.c (subset_compare): Remove unnecessary cast.
3254         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3255         cast.
3256         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3257         cast.
3258         * infcmd.c (path_command): Remove unnecessary cast.
3259         * coffread.c (decode_type): Remove unnecessary cast.
3260         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3261         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3262         * tui/tui-stack.c (tui_show_locator_content)
3263         (tui_show_frame_info): Remove unnecessary cast.
3264         * tui/tui-win.c (tui_scroll_forward_command)
3265         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3266         (parse_scrolling_args): Remove unnecessary cast.
3267         * tui/tui-data.c (init_win_info, tui_del_window)
3268         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3269         (free_content_elements): Remove unnecessary cast.
3270         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3271         unnecessary cast.
3272         * tui/tui-source.c (tui_set_source_content)
3273         (tui_vertical_source_scroll): Remove unnecessary cast.
3274         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3275         cast.
3276         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3277         * tui/tui-regs.c (tui_display_registers_from)
3278         (tui_display_register): Remove unnecessary cast.
3279         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3280         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3281         (make_visible): Remove unnecessary cast.
3282         * tui/tui-winsource.c (tui_erase_source_content)
3283         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3284         unnecessary cast.
3285         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3286         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3287         * stabsread.c (read_type, read_array_type, read_range_type):
3288         Remove unnecessary cast.
3289         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3290         (parse_symbol, parse_type, upgrade_type, parse_external)
3291         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3292         unnecessary cast.
3293         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3294
3295 2019-06-16  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-data.c (tui_alloc_generic_win_info)
3298         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3299         checks.
3300
3301 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3302             Andrew Burgess  <andrew.burgess@embecosm.com>
3303
3304         * f-typeprint.c (f_print_type): Don't return early for not
3305         associated or not allocated types.
3306         (f_type_print_varspec_suffix): Add print_rank parameter and print
3307         ranks of array types in case they dangling.
3308         (f_type_print_base): Add print_rank parameter.
3309
3310 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3311
3312         * NEWS: Mention new MI commands.
3313         * break-catch-throw.c (enum exception_event_kind): Move to
3314         breakpoint.h.
3315         (print_mention_exception_catchpoint): Output text as a single
3316         message.
3317         (catch_exception_command_1): Rename to...
3318         (catch_exception_event): ...this, make non-static, update header
3319         command, and change some parameter types.
3320         (catch_catch_command): Update for changes to
3321         catch_exception_command_1.
3322         (catch_throw_command): Likewise.
3323         (catch_rethrow_command): Likewise.
3324         * breakpoint.c (enum exception_event_kind): Delete.
3325         * breakpoint.h (enum exception_event_kind): Moved here from
3326         break-catch-throw.c.
3327         (catch_exception_event): Declare.
3328         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3329         (mi_cmd_catch_throw): New function.
3330         (mi_cmd_catch_rethrow): New function.
3331         (mi_cmd_catch_catch): New function.
3332         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3333         'catch-catch' entries.
3334         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3335         (mi_cmd_catch_rethrow): Declare.
3336         (mi_cmd_catch_catch): Declare.
3337
3338 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3339
3340         * annotate.c (annotate_source_line): Change return type to void,
3341         update implementation to match.
3342         * annotate.h (annotate_source_line): Change return type to void,
3343         update header comment.
3344         * stack.c (print_frame_info): Don't change what frame information
3345         is printed based on whether annotations are on or not.
3346
3347 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3348
3349         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3350         (annotate_source): Make static.
3351         (annotate_source_line): Moved from source.c and renamed from
3352         identify_source_line.  Update the return type.
3353         * annotate.h (annotate_source): Delete declaration.
3354         (annotate_source_line): Declaration moved from source.h, and
3355         renamed from identify_source_line.  Return type updated.
3356         * source.c (identify_source_line): Moved to annotate.c and renamed
3357         to annotate_source_line.
3358         (info_line_command): Remove check of annotation_level.
3359         * source.h (identify_source_line): Move declaration to annotate.h
3360         and rename to annotate_source_line.
3361         * stack.c: Add 'annotate.h' include.
3362         (print_frame_info): Remove check of annotation_level before
3363         calling annotate_source_line.
3364
3365 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3366
3367         * source-cache.c (source_cache::get_plain_source_lines): Use
3368         open_source_file_with_line_charpos instead of just
3369         open_source_file, remove call to find_source_lines.
3370         (source_cache::get_source_lines): Likewise.
3371         * source.c (find_source_lines): Make static.
3372         (get_filename_and_charpos): Renamed into...
3373         (open_source_file_with_line_charpos): ..this along with changes to
3374         return a scoped_fd, and some other minor clean ups.
3375         (identify_source_line): Use open_source_file_with_line_charpos.
3376         (search_command_helper): Use open_source_file_with_line_charpos
3377         instead of just open_source_file, remove call to
3378         find_source_lines.
3379         * source.h (open_source_file_with_line_charpos): Declare new
3380         function.
3381         (find_source_lines): Delete declaration.
3382
3383 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         * source.c (get_filename_and_charpos): Remove fullname
3386         parameter.
3387         (identify_source_line): Update call to get_filename_and_charpos.
3388
3389 2019-06-14  Tom Tromey  <tromey@adacore.com>
3390
3391         PR gdb/24502:
3392         * ui-style.h (skip_ansi_escape): Update comment.
3393         * ui-file.h (class no_terminal_escape_file): New class.
3394         * ui-file.c (no_terminal_escape_file::write)
3395         (no_terminal_escape_file::puts): New methods.
3396         * cli/cli-logging.c (handle_redirections): Use
3397         no_terminal_escape_file.
3398
3399 2019-06-14  Tom Tromey  <tromey@adacore.com>
3400
3401         * NEWS: Move convenience variable news above Python news.
3402
3403 2019-06-14  Tom Tromey  <tom@tromey.com>
3404
3405         * gnulib: Move directory to top-level.
3406         * configure.ac: Don't configure gnulib.
3407         * configure: Rebuild.
3408         * common/common-defs.h: Use new path to gnulib.
3409         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3410         (GNULIB_H): Remove.
3411         (INCGNU): Look in new gnulib location.
3412         (HFILES_NO_SRCDIR): Remove gnulib files.
3413         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3414         (generated_files): Remove GNULIB_H.
3415         ($(LIBGNU), all-lib): Remove targets.
3416         (distclean): Don't mention GNULIB_BUILDDIR.
3417         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3418
3419 2019-06-14  Tom Tromey  <tromey@adacore.com>
3420
3421         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3422         Warn if symbol file does not provide any symbols.
3423
3424 2019-06-14  Tom Tromey  <tromey@adacore.com>
3425
3426         * source.c (find_and_open_source): Respect basenames_may_differ.
3427
3428 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3429
3430         * annotate.c (annotate_breakpoints_invalid): Make use of
3431         scoped_restore_terminal_state.
3432         (annotate_frames_invalid): Likewise.
3433
3434 2019-06-14  Tom Tromey  <tromey@adacore.com>
3435
3436         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3437         allow assignment to an internalvar.
3438
3439 2019-06-14  Tom Tromey  <tromey@adacore.com>
3440
3441         * ada-lex.l: Allow "_" in attribute names.
3442
3443 2019-06-14  Tom Tromey  <tromey@adacore.com>
3444
3445         PR gdb/24653:
3446         * regcache.c (registers_changed): Don't call alloca.
3447         * top.c (execute_command): Don't call alloca.
3448
3449 2019-06-13  Pedro Alves  <palves@redhat.com>
3450
3451         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3452         'expression'.  When parsing an expression, error out if there's
3453         junk after "unlimited".
3454         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3455         (do_set_command): Adjust calls to is_unlimited_literal.
3456
3457 2019-06-13  Pedro Alves  <palves@redhat.com>
3458
3459         * compile/compile.c (make_compile_options_def_group): Add braces
3460         around array_view initializer.
3461         * thread.c (make_thread_apply_all_options_def_group)
3462         (make_thread_apply_all_options_def_group): Likewise.
3463
3464 2019-06-13  Pedro Alves  <palves@redhat.com>
3465
3466         * NEWS (New commands): Mention "maint test-options
3467         require-delimiter", "maint test-options unknown-is-error", "maint
3468         test-options unknown-is-operand" and "maint show
3469         test-options-completion-result".
3470         (New command options, command completion): New section.
3471         (Completion improvements): New section.
3472         Mention that you can abbreviate "unlimited".
3473
3474 2019-06-13  Pedro Alves  <palves@redhat.com>
3475
3476         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3477         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3478         * unittests/cli-utils-selftests.c (test_parse_flags)
3479         (test_parse_flags_qcs): Delete.
3480         (test_cli_utils): Don't call deleted functions.
3481
3482 2019-06-13  Pedro Alves  <palves@redhat.com>
3483
3484         * thread.c: Include "cli/cli-option.h".
3485         (tp_array_compar_ascending): Global.
3486         (tp_array_compar): Delete function.
3487         (tp_array_compar_ascending, tp_array_compar_descending): New
3488         functions.
3489         (ascending_option_def, qcs_flag_option_def)
3490         (thr_qcs_flags_option_defs)
3491         (make_thread_apply_all_options_def_group)
3492         (make_thread_apply_options_def_group): New.
3493         (thread_apply_all_command): Use gdb::option::process_options.
3494         (thread_apply_command_completer)
3495         (thread_apply_all_command_completer): New.
3496         (thread_apply_command): Use gdb::option::process_options.
3497         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3498         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3499         to generate help text of "thread apply".  Adjust "taas"'s help.
3500         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3501         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3502
3503 2019-06-13  Pedro Alves  <palves@redhat.com>
3504
3505         * thread.c (thread_apply_command): Check for invalid TID with
3506         isdigit instead of !isalpha.
3507
3508 2019-06-13  Pedro Alves  <palves@redhat.com>
3509
3510         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3511         (validate_flags_qcs): New.
3512         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3513         (validate_flags_qcs): Declare.
3514         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3515         (make_frame_apply_options_def_group): New.
3516         (frame_apply_command_count): Process options with
3517         gdb::option::process_options.
3518         (frame_apply_completer): New.
3519         (frame_apply_level_completer, frame_apply_all_completer)
3520         (frame_apply_completer): New.
3521         (_initialize_stack): Update help of "frame apply", "frame apply
3522         level", "frame apply all" and "faas" to mention supported options
3523         and install command completers.
3524         * stack.h (frame_apply_all_completer): Declare.
3525         * thread.c: Include "stack.h".
3526         (tfaas_command): Add "--".
3527         (_initialize_thread): Update help "tfaas" to mention supported
3528         options and install command completer.
3529
3530 2019-06-13  Pedro Alves  <palves@redhat.com>
3531
3532         * completer.c (complete_nested_command_line): New.
3533         (gdb_completion_word_break_characters_throw): Add assertion.
3534         * completer.h (complete_nested_command_line): Declare.
3535
3536 2019-06-13  Pedro Alves  <palves@redhat.com>
3537
3538         * stack.c (parse_backtrace_qualifiers): New.
3539         (backtrace_command): Use it.
3540         (backtrace_command_completer): Complete on qualifiers.
3541
3542 2019-06-13  Pedro Alves  <palves@redhat.com>
3543
3544         * frame.c: Include "cli/cli-option.h.
3545         (user_set_backtrace_options): New.
3546         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3547         Delete.
3548         (get_prev_frame): Adjust.
3549         (boolean_option_def, uinteger_option_def)
3550         (set_backtrace_option_defs): New.
3551         (_initialize_frame): Adjust and use
3552         gdb::option::add_setshow_cmds_for_options to install "set
3553         backtrace past-main" and "set backtrace past-entry".
3554         * frame.h: Include "cli/cli-option.h".
3555         (struct frame_print_options): Forward declare.
3556         (print_frame_arguments_all, print_frame_arguments_scalars)
3557         (print_frame_arguments_none): Declare.
3558         (print_entry_values): Delete declaration.
3559         (struct frame_print_options, user_frame_print_options): New.
3560         (struct set_backtrace_options): New.
3561         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3562         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3563         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3564         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3565         (list_args_or_locals): Add frame_print_options parameter.
3566         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3567         * python/py-framefilter.c (enumerate_args): Pass down
3568         USER_FRAME_PRINT_OPTIONS.
3569         * stack.c: Include "cli/cli-option.h".
3570         (print_frame_arguments_all, print_frame_arguments_scalars)
3571         (print_frame_arguments_none): Declare.
3572         (print_raw_frame_arguments, print_entry_values): Delete.
3573         (user_frame_print_options): New.
3574         (boolean_option_def, enum_option_def, frame_print_option_defs):
3575         New.
3576         (struct backtrace_cmd_options): New.
3577         (bt_flag_option_def): New.
3578         (backtrace_command_option_defs): New.
3579         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3580         (print_frame_arg, read_frame_arg, print_frame_args)
3581         (print_frame_info, print_frame): Add frame_print_options parameter
3582         and use it.
3583         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3584         (backtrace_command_1): Add frame_print_options and
3585         backtrace_cmd_options parameters and use them.
3586         (make_backtrace_options_def_group): New.
3587         (backtrace_command): Process command options with
3588         gdb::option::process_options.
3589         (backtrace_command_completer): New.
3590         (_initialize_stack): Extend "backtrace"'s help to mention
3591         supported options.  Install completer for "backtrace".
3592         Install some settings commands with add_setshow_cmds_for_options.
3593
3594 2019-06-13  Pedro Alves  <palves@redhat.com>
3595
3596         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3597         and that "set/show print raw frame-arguments" are now deprecated.
3598
3599         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3600         command.
3601         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3602         * stack.c (_initialize_stack): Install "set/show print
3603         raw-frame-arguments", and deprecate "set/show print raw
3604         frame-arguments".
3605         * valprint.c (_initialize_valprint): Deprecate "set/show print
3606         raw".
3607
3608 2019-06-13  Pedro Alves  <palves@redhat.com>
3609
3610         * compile/compile.c (struct compile_options): New.
3611         (compile_flag_option_def, compile_command_option_defs)
3612         (make_compile_options_def_group): New.
3613         (compile_file_command): Handle options with
3614         gdb::option::process_options.
3615         (compile_file_command_completer): New function.
3616         (compile_code_command): Handle options with
3617         gdb::option::process_options.
3618         (compile_code_command_completer): New function.
3619         (_initialize_compiler): Install completers for "compile code" and
3620         "compile file".  Mention available options in "compile code" and
3621         "compile code"'s help.
3622         * completer.c (advance_to_completion_word): New, factored out from
3623         ...
3624         (advance_to_expression_complete_word_point): ... this.
3625         (advance_to_filename_complete_word_point): New.
3626         * completer.h (advance_to_filename_complete_word_point): New
3627         declaration.
3628
3629 2019-06-13  Pedro Alves  <palves@redhat.com>
3630
3631         * compile/compile.c: Include "cli/cli-option.h".
3632         (compile_print_value): Scope data pointer is now a
3633         value_print_options pointer; adjust.
3634         (compile_print_command): Process options.  Scope data pointer is
3635         now a value_print_options pointer; adjust.
3636         (_initialize_compile): Update "compile print"'s help to include
3637         supported options.  Install a completer for "compile print".
3638         * cp-valprint.c (show_vtblprint, show_objectprint)
3639         (show_static_field_print): Delete.
3640         (_initialize_cp_valprint): Don't install "set print
3641         static-members", "set print vtbl", "set print object" here.
3642         * printcmd.c: Include "cli/cli-option.h" and
3643         "common/gdb_optional.h".
3644         (print_command_parse_format): Rework to fill in a
3645         value_print_options instead of a format_data.
3646         (print_value): Change parameter type from format_data pointer to
3647         value_print_options reference.  Adjust.
3648         (print_command_1): Process options.  Adjust to pass down a
3649         value_print_options.
3650         (print_command_completer): New.
3651         (_initialize_printcmd): Install print_command_completer as
3652         handle_brkchars completer for the "print" command.  Update
3653         "print"'s help to include supported options.
3654         * valprint.c: Include "cli/cli-option.h".
3655         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3656         here from cp-valprint.c.
3657         (boolean_option_def, uinteger_option_def)
3658         (value_print_option_defs, make_value_print_options_def_group):
3659         New.  Use gdb::option::add_setshow_cmds_for_options to install
3660         "set print elements", "set print null-stop", "set print repeats",
3661         "set print pretty", "set print union", "set print array", "set
3662         print address", "set print symbol", "set print array-indexes".
3663         * valprint.h: Include <string> and "cli/cli-option.h".
3664         (make_value_print_options_def_group): Declare.
3665         (print_value): Change parameter type from format_data pointer to
3666         value_print_options reference.
3667         (print_command_completer): Declare.
3668
3669 2019-06-13  Pedro Alves  <palves@redhat.com>
3670
3671         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3672         (COMMON_SFILES): Add maint-test-settings.c.
3673         * cli/cli-decode.c (boolean_enums): New global, factored out from
3674         ...
3675         (add_setshow_boolean_cmd): ... here.
3676         * cli/cli-decode.h (boolean_enums): Declare.
3677         * cli/cli-option.c: New file.
3678         * cli/cli-option.h: New file.
3679         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3680         factored out from ...
3681         (parse_cli_boolean_value(const char *)): ... this.
3682         (is_unlimited_literal): Change parameter type to pointer to
3683         pointer.  Adjust and advance ARG pointer.
3684         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3685         (parse_cli_var_enum): New, factored out from ...
3686         (do_set_command): ... this.  Adjust.
3687         * cli/cli-setshow.h (parse_cli_boolean_value)
3688         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3689         (parse_cli_var_enum): Declare.
3690         * cli/cli-utils.c: Include "cli/cli-option.h".
3691         (get_ulongest): New.
3692         * cli/cli-utils.h (get_ulongest): Declare.
3693         (check_for_argument): New overloads.
3694         * maint-test-options.c: New file.
3695
3696 2019-06-13  Pedro Alves  <palves@redhat.com>
3697
3698         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3699         parse a range if "-" is at the end of the string.
3700
3701 2019-06-13  Pedro Alves  <palves@redhat.com>
3702
3703         * cli/cli-setshow.c (parse_auto_binary_operation)
3704         (parse_cli_boolean_value): Don't allow "o".
3705
3706 2019-06-13  Pedro Alves  <palves@redhat.com>
3707
3708         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3709         * NEWS: Mention maint test-settings KIND.
3710         * maint-test-settings.c: New file.
3711
3712 2019-06-13  Pedro Alves  <palves@redhat.com>
3713
3714         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3715         completer.
3716         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3717         "set" completers.
3718
3719 2019-06-13  Pedro Alves  <palves@redhat.com>
3720
3721         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3722         after item.
3723
3724 2019-06-13  Pedro Alves  <palves@redhat.com>
3725
3726         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3727
3728 2019-06-13  Pedro Alves <palves@redhat.com>
3729
3730         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3731         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3732         call.
3733         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3734         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3735         calls.
3736         (check_for_argument): Skip spaces after argument.
3737
3738 2019-06-13  Pedro Alves  <palves@redhat.com>
3739
3740         * thread.c (thread_apply_command): Adjust TID parsing.
3741         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3742         detected before end of string.
3743         (tid_is_in_list): Error out if LIST is invalid.
3744
3745 2019-06-13  Pedro Alves  <palves@redhat.com>
3746
3747         * completer.c (complete_line_internal_1): Rewind completion word
3748         point.
3749         (completion_tracker::advance_custom_word_point_by): Change
3750         parameter type to int.
3751         * completer.h (completion_tracker::advance_custom_word_point_by):
3752         Likewise.
3753
3754 2019-06-13  Pedro Alves  <palves@redhat.com>
3755
3756         * completer.c (advance_to_completion_word): Handle delimiters.
3757
3758 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3759
3760         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3761
3762 2019-06-11  Tom Tromey  <tom@tromey.com>
3763
3764         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3765         (xmalloc_failed): Move to alloc.c.
3766         * alloc.c: New file.
3767         * Makefile.in (COMMON_SFILES): Add alloc.c.
3768
3769 2019-06-11  Tom Tromey  <tom@tromey.com>
3770
3771         * nat/linux-waitpid.c: Don't include server.h.
3772         (linux_debug): Remove.
3773         (my_waitpid): Update.
3774
3775 2019-06-11  Tom Tromey  <tromey@adacore.com>
3776
3777         * infcall.c (_initialize_infcall): Remove trailing newline from
3778         help.
3779         * user-regs.c (_initialize_user_regs): Remove trailing newline
3780         from help.
3781         * typeprint.c (_initialize_typeprint): Remove trailing newline
3782         from help.
3783         * reverse.c (_initialize_reverse): Remove trailing newlines from
3784         help.
3785         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3786         from help.
3787         * language.c (add_set_language_command): Remove trailing newline
3788         from help.
3789         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3790         help.
3791         * disasm.c (_initialize_disasm): Remove trailing newline from
3792         help.
3793         * top.c (init_main): Remove trailing newline from help.
3794         * interps.c (_initialize_interpreter): Remove trailing newline
3795         from help.
3796         * btrace.c (_initialize_btrace): Remove trailing newlines from
3797         help.
3798         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3799         from help.
3800         * python/python.c (_initialize_python): Remove trailing newline
3801         from help.
3802         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3803         help.
3804         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3805         from help.  Reformat some text.
3806         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3807         from help.
3808         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3809         newline from help.
3810
3811 2019-06-11  Tom Tromey  <tromey@adacore.com>
3812
3813         * darwin-nat.c (darwin_decode_exception_message)
3814         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3815
3816 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3817
3818         * valops.c (value_slice): Check for not allocated or not
3819         associated values.
3820
3821 2019-06-10  Tom de Vries  <tdevries@suse.de>
3822
3823         PR gdb/24618
3824         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3825         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3826         invalid.
3827
3828 2019-06-10  Tom de Vries  <tdevries@suse.de>
3829
3830         PR gdb/24611
3831         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3832         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3833
3834 2019-06-10  Tom de Vries  <tdevries@suse.de>
3835
3836         PR symtab/24545
3837         * symtab.c (struct demangled_name_entry): Add language field.
3838         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3839         static minimal symbol".  Set and use language field.
3840
3841 2019-06-10  Tom Tromey  <tromey@adacore.com>
3842
3843         * ada-lang.c (_initialize_ada_language): Update help text.
3844
3845 2019-06-10  Tom Tromey  <tromey@adacore.com>
3846
3847         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3848         with a newline.
3849         * guile/guile.c (handle_boot_error): Don't end warning with a
3850         newline.
3851         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3852         warning with a newline.
3853         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3854         newline.
3855         (s12z_frame_cache): Likewise.
3856         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3857         a newline.
3858         * solib-svr4.c (disable_probes_interface): Don't end warning with
3859         a newline.
3860         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3861         newline.
3862         * python/python.c (do_finish_initialization): Don't end warning
3863         with a newline.
3864
3865 2019-06-10  Tom Tromey  <tom@tromey.com>
3866
3867         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3868         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3869         gdbpy_enter.
3870
3871 2019-06-10  Tom Tromey  <tromey@adacore.com>
3872
3873         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3874         data.
3875         (elf_new_init): Don't call stabsread_new_init.
3876         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3877         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3878         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3879
3880 2019-06-10  Tom de Vries  <tdevries@suse.de>
3881
3882         PR symtab/16264
3883         PR symtab/24517
3884         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3885
3886 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3887
3888         * source.c (find_and_open_source): Also rewrite relative file
3889         names.
3890
3891 2019-04-26  Amos Bird  <amosbird@gmail.com>
3892
3893         * annotate.c (annotate_thread_exited): Add "thread-exited"
3894         annotation.
3895
3896 2019-06-06  Tom Tromey  <tromey@adacore.com>
3897
3898         * maint.h (class scoped_command_stats): Use
3899         DISABLE_COPY_AND_ASSIGN.
3900         <print_time>: New method.
3901         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3902         print_time.
3903         (scoped_command_stats::print_time): New method.
3904
3905 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3906
3907         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3908         instructions of lengths 6 or 8 bytes.
3909
3910 2019-06-04  Pedro Alves  <palves@redhat.com>
3911
3912         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3913
3914         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3915         * breakpoint.c (condition_completer): Likewise.
3916         * cli/cli-dump.c (scan_expression): Likewise.
3917         * common/filestuff.c (mkdir_recursive): Likewise.
3918         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3919         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3920         (gdb_abspath): Likewise.
3921         * compile/compile-cplus-types.c
3922         (compile_cplus_instance::decl_name): Likewise.
3923         * completer.c (complete_explicit_location):
3924         (signal_completer, reg_or_group_completer_1): Likewise.
3925         * cp-support.c (cp_remove_params_if_any): Likewise.
3926         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3927         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3928         * infcmd.c (strip_bg_char): Likewise.
3929         * linespec.c (copy_token_string): Likewise.
3930         * mi/mi-main.c (output_cores): Likewise.
3931         * psymtab.c (psymtab_search_name):
3932         * symfile.c (test_set_ext_lang_command): Likewise.
3933         * target.c (target_fileio_read_stralloc): Likewise.
3934         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3935         * value.c (complete_internalvar): Likewise.
3936
3937 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3938
3939         Add objfile property to gdb.Type.
3940         * NEWS: Mention Python API addition.
3941         * python/py-type.c (typy_get_objfile): New method.
3942
3943 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3944
3945         * NEWS: Mention the new set|show style [title|highlight].
3946         Mention changes to "show style", "help" and "apropos".
3947
3948 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3949
3950         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3951         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3952         instead of print_help_for_command.
3953         (print_doc_of_command): New function.
3954         (help_list): Add 'apropos -v word' suggestion.
3955         (print_help_for_command): Style the command name using title style.
3956         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3957         (_initialize_cli_cmds): Describe -v in apropos_command help.
3958
3959 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3960
3961         * cli/cli-style.h (cli_style_option): Add name in constructor,
3962         add m_name class member, add constructor with intensity,
3963         add name class function.
3964         (cli_style_option::add_setshow_commands): Remove name argument.
3965         (highlight_style, title_style): New styles.
3966         * cli/cli-style.c (do_show): New function that shows a style
3967         characteristic styling the style name with itself.
3968         (set_style_name): New function.
3969         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3970         Update all callers according to the changes in cli/cli-style.h.
3971         * utils.h (fputs_highlighted): New function.
3972         * utils.c (fputs_highlighted): Likewise.
3973
3974 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3975
3976         * NEWS: Mention new pipe command and new convenience variables.
3977
3978 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3979
3980         * cli/cli-cmds.c (pipe_command): New function.
3981         (_initialize_cli_cmds): Call add_com for pipe_command.
3982         Define | as an alias for pipe.
3983         (exit_status_set_internal_vars): New function.
3984         (shell_escape): Call exit_status_set_internal_vars.
3985         cli/cli-decode.c (find_command_name_length): Recognize | as
3986         a single character command.
3987
3988 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3989
3990         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3991         top.c (execute_command_to_ui_file): New function, mostly a copy
3992         of execute_command_to_string.
3993         (execute_command_to_string): Implement by calling
3994         execute_command_to_ui_file.
3995
3996 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3997
3998         * top.h (saved_command_line): Remove declaration.
3999         * top.c (previous_saved_command_line, previous_repeat_arguments):
4000         New variables.
4001         (saved_command_line): Make static, define together with other
4002         'repeat variables'.
4003         (dont_repeat): Clear repeat_arguments.
4004         (repeat_previous, get_saved_command_line, save_command_line):
4005         New functions.
4006         (gdb_init): Initialize saved_command_line
4007         and previous_saved_command_line.
4008         * main.c (captured_main_1): Remove saved_command_line initialization.
4009         * event-top.c (handle_line_of_input): Update to use
4010         the new 'repeat' related functions instead of direct access to
4011         saved_command_line.
4012         * command.h (repeat_previous, get_saved_command_line,
4013         save_command_line): New declarations.
4014         (dont_repeat): Add comment.
4015
4016 2019-05-30  Tom Tromey  <tromey@adacore.com>
4017
4018         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4019         Fix comment.
4020         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4021
4022 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4023
4024         PR cli/24587
4025         * completer.c (complete): Initialize variable word.
4026
4027 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4028
4029         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4030         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4031         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4032         'body' is NULL to the outter 'if', protecting the '!is_define'
4033         situation as well.
4034
4035 2019-05-29  Tom Tromey  <tromey@adacore.com>
4036
4037         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4038         (dwarf_unknown): New function.
4039         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4040         (dwarf_type_encoding_name): Use dwarf_unknown.
4041
4042 2019-05-29  Tom Tromey  <tromey@adacore.com>
4043
4044         PR c++/20020:
4045         * cp-valprint.c (cp_print_value_fields): Call
4046         cp_print_static_field inside "try".
4047
4048 2019-05-29  Tom Tromey  <tromey@adacore.com>
4049
4050         * inflow.c (struct terminal_info): Add default operator=.
4051         * configure: Rebuild.
4052         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4053         -Wdeprecated-copy-dtor, -Wredundant-move.
4054
4055 2019-05-29  Tom Tromey  <tromey@adacore.com>
4056
4057         * NEWS: Add entry.
4058         * infcmd.c (print_return_value_1): Handle finish_print
4059         option.
4060         (show_print_finish): New function.
4061         (_initialize_infcmd): Add "set/show print finish" commands.
4062         * valprint.c (user_print_options): Initialize new member.
4063         * valprint.h (struct value_print_options) <finish_print>: New
4064         member.
4065
4066 2019-05-28  Tom Tromey  <tromey@adacore.com>
4067
4068         * ada-lang.c (ada_remove_Xbn_suffix)
4069         (find_old_style_renaming_symbol)
4070         (parse_old_style_renaming): Remove.
4071         (ada_find_renaming_symbol): Don't call
4072         find_old_style_renaming_symbol.
4073         (ada_is_renaming_symbol): Rename from
4074         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4075         bool.  Now static.
4076         (ada_read_var_value): Update and simplify.
4077         * ada-exp.y (write_var_or_type): Remove old code.
4078
4079 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4080
4081         * event-top.c: Remove include comment.
4082         * inflow.c (class scoped_ignore_sigttou): Move from here...
4083         * inflow.h (class scoped_ignore_sigttou): ...to here.
4084         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4085         * top.c:  Remove include comment.
4086
4087 2019-05-27  Tom Tromey  <tom@tromey.com>
4088
4089         * NEWS: Fix typo.
4090
4091 2019-05-22  Tom Tromey  <tromey@adacore.com>
4092
4093         * target.c (target_follow_exec): Constify parameter.
4094         * target-delegates.c: Rebuild.
4095         * remote.c (remote_target::follow_exec): Constify parameter.
4096         * infrun.c (follow_exec): Constify parameter.
4097         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4098         (target_follow_exec): Likewise.
4099
4100 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4101
4102         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4103         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4104
4105 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4106
4107         * NEWS: Add debugredirect and testsuite sections.
4108
4109 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4110
4111         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4112         target descriptions using exclusively floating point register name
4113         aliases.
4114
4115 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4116
4117         PR gdb/18644:
4118         * f-lang.c (build_fortran_types): Handle the case where
4119         gdbarch_floatformat_for_type returns a nullptr.
4120
4121 2019-05-21  Tom de Vries  <tdevries@suse.de>
4122
4123         PR cli/24587
4124         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4125
4126 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4127
4128         PR gdb/18644:
4129         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4130         16-byte floats.
4131         * i386-tdep.c (i386_floatformat_for_type): Use
4132         floatformats_ia64_quad for the 16-byte floating point component
4133         within a fortran 32-byte complex number.
4134
4135 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4136
4137         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4138         delete default constructor.
4139         (find_partial_die): Update to return const struct.
4140         (partial_die_parent_scope): Move variable declaration into scope
4141         of its use and change its type to auto.
4142         (guess_partial_die_structure_name): Likewise.
4143         (partial_die_info::fixup): Likewise.
4144
4145 2019-05-17  Tom Tromey  <tromey@adacore.com>
4146
4147         * source.c (find_and_open_source): Remove cast.
4148
4149 2019-05-17  Tom Tromey  <tromey@adacore.com>
4150
4151         * annotate.c (annotate_source): Make "filename" const.
4152         * annotate.h (annotate_source): Use const.
4153
4154 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4155
4156         * disasm.c (set_disassembler_options): Send errors to stderr.
4157
4158 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4159
4160         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4161         (cli_interp_base::set_logging): Check debug_redirect.
4162         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4163         * cli/cli-logging.c (debug_redirect): Add static variable.
4164         (pop_output_files): Add default param.
4165         (handle_redirections): Print debug setting.
4166         (show_logging_command): Likewise.
4167         (_initialize_cli_logging): Add debugredirect command.
4168         * interps.c (current_interp_set_logging): Add debug_redirect
4169         parameter.
4170         * interps.h (set_logging): Add debug_redirect parameter.
4171         (current_interp_set_logging): Likewise.
4172         * mi/mi-common.h: Likewise.
4173         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4174
4175 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4176             Tom Tromey  <tromey@adacore.com>
4177
4178         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4179         directly.
4180         * cli/cli-interp.h (make_logging_output): Remove declaration.
4181         * cli/cli-logging.c (make_logging_output): Remove function.
4182         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4183         directly.
4184         * ui-file.c (tee_file::tee_file): Remove bools.
4185         (tee_file::~tee_file): Remove deletes.
4186         * ui-file.h (tee_file): Remove bools.
4187
4188 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4189
4190         * mi/mi-cmds.h (mi_cmd_complete): New function.
4191         * mi/mi-main.c (mi_cmd_complete): Likewise.
4192         * mi/mi-cmds.c: Define new MI command -complete.
4193         * NEWS: Mention new -complete command.
4194
4195 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4196
4197         * completer.h (complete): New function.
4198         * completer.c (complete): Likewise.
4199         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4200         function defined in completer.h.
4201
4202 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4203
4204         * MAINTAINERS (Write After Approval): Add myself.
4205
4206 2019-05-17  Tom de Vries  <tdevries@suse.de>
4207
4208         PR gdb/24094
4209         * dwarf2read.c (struct cu_partial_die_info): New struct.
4210         (find_partial_die): Return cu_partial_die_info.
4211         (partial_die_parent_scope, guess_partial_die_structure_name)
4212         (partial_die_info::fixup): Handle new return type of find_partial_die.
4213
4214 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4215
4216         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4217         "std::string", simplifying the algorithm.
4218
4219 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4220
4221         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4222         (stap_static_probe_ops::get_probes): Likewise.
4223
4224 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4225
4226         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4227         '-')" and "else if".
4228         (stap_parse_single_operand): Join checks for
4229         "gdbarch_stap_parse_special_token_p" and
4230         "gdbarch_stap_parse_special_token" in the same "if" statement.
4231         Invert check when verifying for operation on register
4232         displacement.
4233
4234 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4235
4236         * stap-probe.c (stap_get_opcode): Update comment.
4237         (stap_get_expected_argument_type): Likewise.
4238         (handle_stap_probe): Likewise.
4239
4240 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4241
4242         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4243         return type to 'bool'.  Adjust comment.  Use 'bool' when
4244         appropriate.
4245         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4246         * stap-probe.c (stap_parse_argument_1): Likewise.
4247         (stap_is_operator): Likewise.
4248         (stap_is_generic_prefix): Likewise.
4249         (stap_is_register_prefix): Likewise.
4250         (stap_is_register_indirection_prefix): Likewise.
4251         (stap_is_integer_prefix): Likewise.
4252         (stap_generic_check_suffix): Likewise.
4253         (stap_check_integer_suffix): Likewise.
4254         (stap_check_register_suffix): Likewise.
4255         (stap_check_register_indirection_suffix): Likewise.
4256         (stap_parse_register_operand): Likewise.
4257         (stap_parse_single_operand): Likewise.
4258         (stap_parse_argument_1): Likewise.
4259         (stap_probe::get_argument_count): Likewise.
4260         (stap_is_operator): Likewise.
4261
4262 2019-05-16  Tom Tromey  <tromey@adacore.com>
4263
4264         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4265         keyword to foreach.
4266
4267 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4268
4269         * linux-thread-db.c (try_thread_db_load_1): Change return type
4270         to bool.
4271         (try_thread_db_load): Likewise.
4272         (try_thread_db_load_from_pdir_1): Likewise.
4273         (try_thread_db_load_from_pdir): Likewise.
4274         (try_thread_db_load_from_sdir): Likewise.
4275         (try_thread_db_load_from_dir): Likewise.
4276         (thread_db_load_search): Likewise.
4277         (has_libpthread): Likewise.
4278         (thread_db_load): Likewise.
4279
4280 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4281
4282         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4283         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4284         NULL, and complain/return if that's the case.
4285
4286 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4287
4288         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4289         (advance, posn, abstract_read_memory): New functions.
4290         [struct mem_read_abstraction]: New struct.
4291         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4292
4293 2019-05-14  Tom Tromey  <tromey@adacore.com>
4294
4295         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4296         value is not lval_memory.
4297
4298 2019-05-14  Tom Tromey  <tromey@adacore.com>
4299
4300         * solib.c (info_sharedlibrary_command): Style the file name.
4301
4302 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4303
4304         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4305         (aarch64_vnv_type): Likewise.
4306         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4307         * common/tdesc.c: Likewise.
4308         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4309         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4310         * features/aarch64-fpu.xml: Add ieee half view.
4311         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4312         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4313         * gdbtypes.h (struct builtin_type): Likewise.
4314         (struct objfile_type): Likewise.
4315
4316 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4317
4318         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4319         typo.
4320         * location.h (string_to_event_location): Likewise.
4321
4322 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4323
4324         GDB 8.3 released.
4325
4326 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4327
4328         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4329         New variable declaration.
4330         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4331         New variable.
4332         (print_one_breakpoint): Use ui_out::test_flags and new global
4333         variable to compute use_fixed_output.
4334         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4335         Remove.
4336         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4337         (mi_multi_location_breakpoint_output_fixed): Remove.
4338         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4339         new variable.
4340         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4341         fix_multi_location_breakpoint_output flag if version >= 3.
4342         * ui-out.h (enum ui_out_flag)
4343         <fix_multi_location_breakpoint_output>: New enumerator.
4344
4345 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4346
4347         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4348
4349 2019-05-10  Tom Tromey  <tromey@adacore.com>
4350
4351         * ada-lang.c (catch_ada_completer): New function.
4352         (_initialize_ada_language): Use it.
4353
4354 2019-05-10  Tom Tromey  <tromey@adacore.com>
4355
4356         * thread.c (print_thread_info): Make "requested_threads" const.
4357         * gdbthread.h (print_thread_info): Make "requested_threads"
4358         const.
4359         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4360         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4361
4362 2019-05-08  Tom Tromey  <tom@tromey.com>
4363
4364         * gdbtypes.c (objfile_type_data): Change type.
4365         (objfile_type, _initialize_gdbtypes): Update.
4366
4367 2019-05-08  Tom Tromey  <tom@tromey.com>
4368
4369         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4370         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4371         (_initialize_dwarf2_frame): Update.
4372
4373 2019-05-08  Tom Tromey  <tom@tromey.com>
4374
4375         * objc-lang.c (objc_objfile_data): Change type.
4376         (find_methods): Update.
4377         (_initialize_objc_lang): Remove.
4378
4379 2019-05-08  Tom Tromey  <tom@tromey.com>
4380
4381         * stabsread.c (rs6000_builtin_type_data): Change type.
4382         (rs6000_builtin_type, _initialize_stabsread): Update.
4383
4384 2019-05-08  Tom Tromey  <tom@tromey.com>
4385
4386         * mips-tdep.c (mips_pdr_data): Remove.
4387         (_initialize_mips_tdep): Update.
4388
4389 2019-05-08  Tom Tromey  <tom@tromey.com>
4390
4391         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4392         (hppa_init_objfile_priv_data, read_unwind_info)
4393         (find_unwind_entry, _initialize_hppa_tdep): Update.
4394
4395 2019-05-08  Tom Tromey  <tom@tromey.com>
4396
4397         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4398         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4399         on obstack.
4400         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4401
4402 2019-05-08  Tom Tromey  <tom@tromey.com>
4403
4404         * mdebugread.c (basic_type_data): Change type.
4405         (basic_type, _initialize_mdebugread): Update.
4406
4407 2019-05-08  Tom Tromey  <tom@tromey.com>
4408
4409         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4410
4411 2019-05-08  Tom Tromey  <tom@tromey.com>
4412
4413         * nto-tdep.c (nto_inferior_data_reg): Change type.
4414         (nto_inferior_data): Update.
4415         (nto_inferior_data_cleanup, nto_new_inferior_data)
4416         (_initialize_nto_tdep): Remove.
4417         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4418
4419 2019-05-08  Tom Tromey  <tom@tromey.com>
4420
4421         * ada-lang.c (struct ada_inferior_data): Add initializers.
4422         (ada_inferior_data): Change type.
4423         (ada_inferior_data_cleanup): Remove.
4424         (get_ada_inferior_data, ada_inferior_exit)
4425         (struct ada_pspace_data): Add initializers, destructor.
4426         (ada_pspace_data_handle): Change type.
4427         (get_ada_pspace_data): Update.
4428         (ada_pspace_data_cleanup): Remove.
4429
4430 2019-05-08  Tom Tromey  <tom@tromey.com>
4431
4432         * coffread.c (struct coff_symfile_info): Add initializers.
4433         (coff_objfile_data_key): Move lower.  Change type.
4434         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4435         Update.
4436         (coff_free_info): Remove.
4437
4438 2019-05-08  Tom Tromey  <tom@tromey.com>
4439
4440         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4441         (fbsd_pspace_data_handle): Move lower.  Change type.
4442         (get_fbsd_pspace_data): Update.
4443         (fbsd_pspace_data_cleanup): Remove.
4444         (_initialize_fbsd_tdep): Update.
4445
4446 2019-05-08  Tom Tromey  <tom@tromey.com>
4447
4448         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4449         (get_ada_tasks_pspace_data): Update.
4450         (ada_tasks_pspace_data_cleanup): Remove.
4451         (_initialize_tasks): Update.
4452         (ada_tasks_inferior_data_handle): Change type.
4453         (get_ada_tasks_inferior_data): Update.
4454         (ada_tasks_inferior_data_cleanup): Remove.
4455         (struct ada_tasks_pspace_data): Add initializers.
4456
4457 2019-05-08  Tom Tromey  <tom@tromey.com>
4458
4459         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4460         * symfile-debug.c (debug_sym_get_probes): Change type.
4461         * stap-probe.c (handle_stap_probe):
4462         (stap_static_probe_ops::get_probes): Change type.
4463         * probe.h (class static_probe_ops) <get_probes>: Change type.
4464         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4465         (parse_probes_in_pspace): Update.
4466         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4467         Update.
4468         (any_static_probe_ops::get_probes): Change type.
4469         * elfread.c (elfread_data): New typedef.
4470         (probe_key): Change type.
4471         (elf_get_probes): Likewise.  Update.
4472         (probe_key_free): Remove.
4473         (_initialize_elfread): Update.
4474         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4475         Change type.
4476         (dtrace_process_dof_probe, dtrace_process_dof)
4477         (dtrace_static_probe_ops::get_probe): Change type.
4478
4479 2019-05-08  Tom Tromey  <tom@tromey.com>
4480
4481         * xcoffread.c (struct xcoff_symfile_info): Rename from
4482         coff_symfile_info.  Add initializers.
4483         (xcoff_objfile_data_key): Move lower.  Change type.
4484         (XCOFF_DATA): Rewrite.
4485         (xcoff_free_info): Remove.
4486         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4487         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4488         (xcoff_initial_scan): Update.
4489
4490 2019-05-08  Tom Tromey  <tom@tromey.com>
4491
4492         * solib-svr4.c (struct svr4_info): Add initializers and
4493         destructor.
4494         <probes_table>: Now an htab_up.
4495         (solib_svr4_pspace_data): Change type.
4496         (free_probes_table): Simplify.
4497         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4498         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4499         (probes_table_remove_objfile_probes, register_solib_event_probe)
4500         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4501         (_initialize_svr4_solib): Update.
4502
4503 2019-05-08  Tom Tromey  <tom@tromey.com>
4504
4505         * remote.c (remote_pspace_data): Change type.
4506         (remote_pspace_data_cleanup): Remove.
4507         (get_remote_exec_file, set_pspace_remote_exec_file)
4508         (_initialize_remote): Update.
4509
4510 2019-05-08  Tom Tromey  <tom@tromey.com>
4511
4512         * breakpoint.c (breakpoint_objfile_key): Change type.
4513         (get_breakpoint_objfile_data): Update.
4514         (free_breakpoint_objfile_data): Remove.
4515         (_initialize_breakpoint): Update.
4516
4517 2019-05-08  Tom Tromey  <tom@tromey.com>
4518
4519         * linux-tdep.c (struct linux_info): Add initializers.
4520         (linux_inferior_data): Move.  Change type.
4521         (invalidate_linux_cache_inf): Update.
4522         (linux_inferior_data_cleanup): Remove.
4523         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4524
4525 2019-05-08  Tom Tromey  <tom@tromey.com>
4526
4527         * auxv.c (auxv_inferior_data): Move.  Change type.
4528         (auxv_inferior_data_cleanup): Remove.
4529         (invalidate_auxv_cache_inf): Rewrite.
4530         (get_auxv_inferior_data, _initialize_auxv): Update.
4531
4532 2019-05-08  Tom Tromey  <tom@tromey.com>
4533
4534         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4535         (symfile_debug_objfile_data_key): Change type.
4536         (symfile_debug_installed, debug_qf_has_symbols)
4537         (debug_qf_find_last_source_symtab)
4538         (debug_qf_forget_cached_source_info)
4539         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4540         (debug_qf_print_stats, debug_qf_dump)
4541         (debug_qf_expand_symtabs_for_function)
4542         (debug_qf_expand_all_symtabs)
4543         (debug_qf_expand_symtabs_with_fullname)
4544         (debug_qf_map_matching_symbols)
4545         (debug_qf_expand_symtabs_matching)
4546         (debug_qf_find_pc_sect_compunit_symtab)
4547         (debug_qf_map_symbol_filenames)
4548         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4549         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4550         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4551         (debug_sym_read_linetable, debug_sym_relocate): Update.
4552         (symfile_debug_free_objfile): Remove.
4553         (install_symfile_debug_logging, _initialize_symfile_debug):
4554         Update.
4555
4556 2019-05-08  Tom Tromey  <tom@tromey.com>
4557
4558         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4559         allocate_on_obstack.
4560         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4561         (get_dwarf2_per_objfile): Update.
4562         (set_dwarf2_per_objfile): Remove.
4563         (dwarf2_has_info, dwarf2_get_section_info): Update.
4564         (dwarf2_free_objfile): Remove.
4565         (_initialize_dwarf2_read): Update.
4566
4567 2019-05-08  Tom Tromey  <tom@tromey.com>
4568
4569         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4570         initializers.
4571         <unsupported_script_warning_printed,
4572         script_not_found_warning_printed>: Now bool.
4573         (auto_load_pspace_data): Change type.
4574         (~auto_load_pspace_info): Rename from
4575         auto_load_pspace_data_cleanup.
4576         (get_auto_load_pspace_data, init_loaded_scripts_info)
4577         (clear_section_scripts, maybe_print_unsupported_script_warning)
4578         (maybe_print_script_not_found_warning, _initialize_auto_load):
4579         Update.
4580
4581 2019-05-08  Tom Tromey  <tom@tromey.com>
4582
4583         * objfiles.c (objfile_pspace_info): Add destructor and
4584         initializers.
4585         (objfiles_pspace_data): Change type.
4586         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4587         (get_objfile_pspace_data): Update.
4588         (objfiles_bfd_data): Change type.
4589         (get_objfile_bfd_data): Update.
4590         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4591
4592 2019-05-08  Tom Tromey  <tom@tromey.com>
4593
4594         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4595         Change type.
4596         (get_catch_syscall_inferior_data): Update.
4597         (catch_syscall_inferior_data_cleanup): Remove.
4598         (_initialize_break_catch_syscall): Update.
4599
4600 2019-05-08  Tom Tromey  <tom@tromey.com>
4601
4602         * inflow.c (struct terminal_info): Add destructor and
4603         initializers.
4604         (inflow_inferior_data): Change type.
4605         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4606         (get_inflow_inferior_data, inflow_inferior_exit)
4607         (swap_terminal_info, _initialize_inflow): Update.
4608
4609 2019-05-08  Tom Tromey  <tom@tromey.com>
4610
4611         * target-dcache.c (target_dcache_cleanup): Remove.
4612         (target_dcache_aspace_key): Change type.
4613         (target_dcache_init_p, target_dcache_invalidate)
4614         (target_dcache_get, target_dcache_get_or_init)
4615         (_initialize_target_dcache): Update.
4616         * dcache.h (struct dcache_deleter): New.
4617
4618 2019-05-08  Tom Tromey  <tom@tromey.com>
4619
4620         * symtab.c (struct symbol_cache): Add destructor and
4621         initializers.
4622         (symbol_cache_key): Move.  Change type.
4623         (make_symbol_cache, free_symbol_cache): Remove.
4624         (get_symbol_cache): Update.
4625         (symbol_cache_cleanup): Remove.
4626         (ALL_PSPACES, symbol_cache_flush)
4627         (maintenance_print_symbol_cache)
4628         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4629         Update.
4630
4631 2019-05-08  Tom Tromey  <tom@tromey.com>
4632
4633         * symtab.c (struct main_info): Add destructor and initializers.
4634         (main_progspace_key): Move.  Change type.
4635         (get_main_info): Update.
4636         (main_info_cleanup): Remove.
4637         (_initialize_symtab): Update.
4638
4639 2019-05-08  Tom Tromey  <tom@tromey.com>
4640
4641         * registry.h (DECLARE_REGISTRY): Define the _key class.
4642
4643 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4644
4645         * NEWS: Merge two 'New commands' sections.
4646
4647 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4648
4649         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4650         parameter and use Ada language definition instead.
4651         (ada_val_print_ptr): Remove unused language parameter.
4652         (ada_val_print_num): Remove language parameter and use Ada language
4653         definition instead.
4654         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4655         parameter.
4656         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4657         parameter and use Ada language definition instead.
4658         (ada_val_print_1): Update all ada_val_print_xxx calls.
4659         Remove language parameter.
4660         (ada_val_print): Update ada_val_print_1 call.
4661
4662 2019-05-08  Tom Tromey  <tromey@adacore.com>
4663
4664         * remote.c (remote_hw_watchpoint_limit)
4665         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4666         Now static.
4667
4668 2019-05-08  Tom Tromey  <tromey@adacore.com>
4669
4670         * maint.c (_initialize_maint_cmds): Move initialization code to
4671         remote.c.
4672         (watchdog, show_watchdog): Move to remote.c.
4673         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4674         "watchdog" static.
4675         (_initialize_remote): Move initialization code from maint.c.
4676         * defs.h (watchdog): Don't declare.
4677
4678 2019-05-08  Tom Tromey  <tromey@adacore.com>
4679
4680         * tui/tui-interp.c: Include main.h.
4681         * interps.c: Include main.h.
4682         * main.h (interpreter_p): Declare.
4683         * defs.h (interpreter_p): Don't declare.
4684
4685 2019-05-08  Tom Tromey  <tromey@adacore.com>
4686
4687         * dwarf2loc.c: Include dwarf2read.h.
4688         * defs.h (read_unsigned_leb128): Don't declare.
4689         * dwarf2read.h (read_unsigned_leb128): Declare.
4690
4691 2019-05-08  Tom Tromey  <tromey@adacore.com>
4692
4693         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4694         method.
4695
4696 2019-05-08  Tom Tromey  <tromey@adacore.com>
4697
4698         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4699         when no wrap column is set.
4700
4701 2019-05-08  Tom Tromey  <tromey@adacore.com>
4702
4703         * c-lang.c (c_get_string): Handle non-C-style arrays.
4704
4705 2019-05-08  Tom Tromey  <tromey@adacore.com>
4706
4707         * typeprint.c (print_offset_data::update): Print the bit offset,
4708         not the number of bits remaining.
4709
4710 2019-05-08  Tom Tromey  <tromey@adacore.com>
4711
4712         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4713         padding at end of comment.
4714
4715 2019-05-08  Tom Tromey  <tromey@adacore.com>
4716
4717         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4718         Compare main types.
4719
4720 2019-05-06  Tom Tromey  <tom@tromey.com>
4721
4722         * common/scoped_mmap.c: Include common-defs.h.
4723         * common/scoped_mmap.h: Don't include config.h.
4724
4725 2019-05-04  Tom Tromey  <tom@tromey.com>
4726
4727         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4728         (struct aarch64_call_info): Add initializers.
4729         <si>: Now a std::vector.
4730         (pass_on_stack, aarch64_push_dummy_call): Update.
4731
4732 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4733             Tom Tromey  <tom@tromey.com>
4734
4735         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4736         (ppc_threads): Now a std::vector.  Now static.
4737         (hwdebug_find_thread_points_by_tid)
4738         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4739         Update.
4740
4741 2019-05-04  Tom Tromey  <tom@tromey.com>
4742
4743         * arc-tdep.c (arc_tdesc_init): Return bool.
4744
4745 2019-05-04  Tom Tromey  <tom@tromey.com>
4746
4747         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4748         Use gdb_assert_not_reached.
4749
4750 2019-05-04  Tom Tromey  <tom@tromey.com>
4751
4752         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4753         "false".
4754
4755 2019-05-04  Tom Tromey  <tom@tromey.com>
4756
4757         * arc-tdep.c (arc_tdesc_init): Use bool.
4758
4759 2019-05-04  Tom Tromey  <tom@tromey.com>
4760
4761         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4762
4763 2019-05-04  Tom Tromey  <tom@tromey.com>
4764
4765         * cli/cli-cmds.c (valid_command_p): Return bool.
4766
4767 2019-05-04  Tom Tromey  <tom@tromey.com>
4768
4769         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4770         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4771
4772 2019-05-04  Raul Tambre  <raul@tambre.ee>
4773
4774         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4775         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4776         operator for comparison.
4777
4778 2019-05-04  Tom Tromey  <tom@tromey.com>
4779
4780         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4781         (lookup_partial_symbol, print_partial_symbols)
4782         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4783         (psymbol_compare): Update.
4784         (add_psymbol_to_bcache): Clear the entire psymbol.
4785         (maintenance_check_psymtabs): Update.
4786         * psympriv.h (struct partial_symbol): Don't derive from
4787         general_symbol_info.
4788         <obj_section, unrelocated_address, address,
4789         set_unrelocated_address>: Update.
4790         <ginfo>: New member.
4791         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4792         (debug_names::write_psymbols): Update.
4793
4794 2019-05-04  Tom de Vries  <tdevries@suse.de>
4795
4796         * contrib/cc-with-tweaks.sh: Support -n arg.
4797
4798 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4799
4800         * corelow.c (core_target::detach): Ensure frame cache and
4801         register caches are cleared.
4802         inferior.c (exit_inferior_1): Likewise.
4803
4804 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4805             Tom Tromey  <tom@tromey.com>
4806
4807         * dictionary.c (collate_pending_symbols_by_language): Remove
4808         "struct" from foreach.
4809         * symtab.c (lookup_global_symbol_from_objfile)
4810         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4811         foreach.
4812         * ser-tcp.c (net_open): Remove "struct" from foreach.
4813         * objfiles.c (objfile_relocate, objfile_rebase)
4814         (objfile_has_symbols): Remove "struct" from foreach.
4815         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4816         from foreach.
4817         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4818         foreach.
4819         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4820         "struct" from foreach.
4821         * ada-lang.c (create_excep_cond_exprs)
4822         (ada_exception_catchpoint_cond_string): Remove "struct" from
4823         foreach.
4824
4825 2019-05-03  Tom Tromey  <tromey@adacore.com>
4826
4827         * ada-exp.y (convert_char_literal): Check suffix of each
4828         enumerator.
4829
4830 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4831
4832         PR ada/21406:
4833         * ada-exp.y (yywrap): Don't define.
4834         * ada-lex.l (%option): Add noyywrap
4835         (yywrap): Remove.
4836
4837 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4838
4839         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4840         _WIN32_WINNT to the XP level, unless already defined to a higher
4841         level.
4842
4843         * unittests/parse-connection-spec-selftests.c:
4844         * ser-tcp.c:
4845         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4846         override.
4847
4848         * symfile.c (find_separate_debug_file): Remove colon from the
4849         drive spec of DOS/Windows file names of the target, so that the
4850         file name produced from DEBUGDIR and the target's directory will
4851         be valid on DOS/Windows systems.
4852
4853 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4854
4855         * rust-lang.c (val_print_struct): Handle printing structures
4856         containing strings.
4857
4858 2019-05-02  Tom Tromey  <tromey@adacore.com>
4859
4860         * valarith.c (_initialize_valarith): Remove.
4861
4862 2019-05-01  Tom Tromey  <tromey@adacore.com>
4863
4864         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4865         bitfields.
4866
4867 2019-05-01  Tom Tromey  <tromey@adacore.com>
4868
4869         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4870         for big-endian copies.
4871
4872 2019-04-30  Ali Tamur  <tamur@google.com>
4873         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4874         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4875         (read_3_bytes): New function.
4876
4877 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4878
4879         * windows-nat.c (main_thread_id): Delete.
4880         (handle_output_debug_string): Replace main_thread_id by
4881         current_event.dwThreadId.
4882         (fake_create_process): Likewise.
4883         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4884         Do not set main_thread_id.
4885         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4886         current_event.dwThreadId.
4887         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4888
4889 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4890
4891         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4892         Use current_event.dwThreadId instead of main_thread_id.
4893
4894 2019-04-30  Tom Tromey  <tromey@adacore.com>
4895
4896         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4897         (create_excep_cond_exprs): Iterate over program spaces.
4898         (ada_exception_catchpoint_cond_string): Examine all minimal
4899         symbols for exception types.
4900
4901 2019-04-30  Tom Tromey  <tromey@adacore.com>
4902
4903         PR c++/24470:
4904         * dwarf2read.c (process_structure_scope): Handle case where type
4905         has template parameters but no symbol was created.
4906
4907 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4908             Chris January  <chris.january@arm.com>
4909
4910         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4911         qualifier.
4912         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4913
4914 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4915
4916         * f-typeprint.c (f_print_type): Update rules for printing
4917         whitespace.
4918         (f_type_print_varspec_suffix): Likewise.
4919
4920 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4921             Chris January  <chris.january@arm.com>
4922
4923         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4924         function arguments.
4925
4926 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4927
4928         * f-lang.c (build_fortran_types): Change name of void type to
4929         lower case.
4930         * f-typeprint.c (f_type_print_base): Print the name of the void
4931         type, rather than a fixed string.
4932         * f-valprint.c (f_decorations): Use lower case void string.
4933
4934 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4935             Chris January  <chris.january@arm.com>
4936
4937         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4938         types for Fortran.
4939
4940 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4941             Chris January  <chris.january@arm.com>
4942             David Lecomber  <david.lecomber@arm.com>
4943
4944         * f-exp.y (BINOP_INTRINSIC): New token.
4945         (exp): New parser rule handling BINOP_INTRINSIC.
4946         (f77_keywords): Add new builtin procedures.
4947         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4948         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4949         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4950         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4951         (print_unop_subexp_f): New function.
4952         (print_binop_subexp_f): New function.
4953         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4954         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4955         (dump_subexp_body_f): Likewise.
4956         (operator_check_f): Likewise.
4957         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4958         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4959
4960 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4963         UNOP_KIND.
4964         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4965         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4966         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4967         (operator_length_f): New fuction.
4968         (print_subexp_f): New function.
4969         (op_name_f): New function.
4970         (dump_subexp_body_f): New function.
4971         (operator_check_f): New function.
4972         (exp_descriptor_f): Replace standard expression handling functions
4973         with new functions.
4974         * gdb/fortran-operator.def: New file.
4975         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4976         * gdb/std-operator.def: Remove UNOP_KIND.
4977
4978 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4979
4980         * std-operator.def: Remove unbalanced, stray double quote
4981         character.
4982
4983 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4984             Chris January  <chris.january@arm.com>
4985             Daniel Everett  <daniel.everett@arm.com>
4986             Nick Forrington  <nick.forrington@arm.com>
4987             Richard Bunt  <richard.bunt@arm.com>
4988
4989         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4990         of depth when printing anonymous structs or unions.
4991         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4992         Don't print either the top-level value, or the children if the
4993         max-depth is exceeded.
4994         (ppscm_print_children): When printing the key of a map, allow one
4995         extra level of depth.
4996         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4997         print either the top-level value, or the children if the max-depth
4998         is exceeded.
4999         (print_children): When printing the key of a map, allow one extra
5000         level of depth.
5001         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5002         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5003         (user_print_options): Initialise max_depth field.
5004         (val_print_scalar_or_string_type_p): New function.
5005         (val_print): Check to see if the max depth has been reached.
5006         (val_print_check_max_depth): Define new function.
5007         (show_print_max_depth): New function.
5008         (_initialize_valprint): Add 'print max-depth' option.
5009         * valprint.h (struct value_print_options) <max_depth>: New field.
5010         (val_print_check_max_depth): Declare new function.
5011         * NEWS: Document new feature.
5012
5013 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5014
5015         * ada-lang.c (ada_language_defn): Initialise new field.
5016         * c-lang.c (c_is_string_type_p): New function.
5017         (c_language_defn): Initialise new field.
5018         (cplus_language_defn): Initialise new field.
5019         (asm_language_defn): Initialise new field.
5020         (minimal_language_defn): Initialise new field.
5021         * c-lang.h (c_is_string_type_p): Declare new function.
5022         * d-lang.c (d_language_defn): Initialise new field.
5023         * f-lang.c (f_is_string_type_p): New function.
5024         (f_language_defn): Initialise new field.
5025         * go-lang.c (go_is_string_type_p): New function.
5026         (go_language_defn): Initialise new field.
5027         * language.c (default_is_string_type_p): New function.
5028         (unknown_language_defn): Initialise new field.
5029         (auto_language_defn): Initialise new field.
5030         * language.h (struct language_defn) <la_is_string_type_p>: New
5031         member variable.
5032         (default_is_string_type_p): Declare new function.
5033         * m2-lang.c (m2_language_defn): Initialise new field.
5034         * objc-lang.c (objc_language_defn): Initialise new field.
5035         * opencl-lang.c (opencl_language_defn): Initialise new field.
5036         * p-lang.c (pascal_is_string_type_p): New function.
5037         (pascal_language_defn): Initialise new field.
5038         * rust-lang.c (rust_is_string_type_p): New function.
5039         (rust_language_defn): Initialise new field.
5040
5041 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5042
5043         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5044         New field.
5045         * ada-lang.c (ada_language_defn): Initialise new field.
5046         * c-lang.c (c_language_defn): Likewise.
5047         (cplus_language_defn): Likewise.
5048         (asm_language_defn): Likewise.
5049         (minimal_language_defn): Likewise.
5050         * d-lang.c (d_language_defn): Likewise.
5051         * f-lang.c (f_language_defn): Likewise.
5052         * go-lang.c (go_language_defn): Likewise.
5053         * language.c (unknown_language_defn): Likewise.
5054         (auto_language_defn): Likewise.
5055         * m2-lang.c (m2_language_defn): Likewise.
5056         * objc-lang.c (objc_language_defn): Likewise.
5057         * opencl-lang.c (opencl_language_defn): Likewise.
5058         * p-lang.c (pascal_language_defn): Likewise.
5059         * rust-lang.c (rust_language_defn): Likewise.
5060
5061 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5062
5063         * ada-lang.c (ada_is_character_type): Change return type to bool.
5064         (ada_is_string_type): Likewise.
5065         * ada-lang.h (ada_is_character_type): Update declaration
5066         (ada_is_string_type): Likewise.
5067
5068 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5069
5070         Support style in 'frame|thread apply'
5071
5072         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5073         * record.c (record_start, record_stop): Update callers of
5074         execute_command_to_string with false.
5075         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5076         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5077         methods.
5078         (class string_file): New constructor with term_out parameter.
5079         Override methods term_out and can_emit_style_escape.  New member
5080         term_out.
5081         (class stdio_file): Override can_emit_style_escape.
5082         (class tee_file): Override term_out and can_emit_style_escape.
5083         * utils.h (can_emit_style_escape): Remove.
5084         * utils.c (can_emit_style_escape): Likewise.
5085         Update all callers of can_emit_style_escape (SOMESTREAM) to
5086         SOMESTREAM->can_emit_style_escape.
5087         * source-cache.c (source_cache::get_source_lines): Likewise.
5088         * stack.c (frame_apply_command_count): Call execute_command_to_string
5089         passing the term_out characteristic of the current gdb_stdout.
5090         * thread.c (thr_try_catch_cmd): Likewise.
5091         * top.c (execute_command_to_string): pass term_out parameter
5092         to construct the string_file for the command output.
5093         * ui-file.c (term_cli_styling): New function (most code moved
5094         from utils.c can_emit_style_escape).
5095         (string_file::string_file, string_file::can_emit_style_escape,
5096         stdio_file::can_emit_style_escape, tee_file::term_out,
5097         tee_file::can_emit_style_escape): New functions.
5098
5099 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5100
5101         * NEWS: Mention the new set|show may-call-functions.
5102         * infcall.c (may_call_functions_p): New variable.
5103         (show_may_call_functions_p): New function.
5104         (call_function_by_hand_dummy): Throws an error if not
5105         may-call-functions.
5106         (_initialize_infcall): Call add_setshow_boolean_cmd for
5107         may-call-functions.
5108
5109 2019-04-25  Keith Seitz  <keiths@redhat.com>
5110
5111         PR c++/24367
5112         * cp-support.c (inspect_type): Don't attempt substitutions
5113         of symbol with the same name.
5114
5115 2019-04-25  Tom Tromey  <tromey@adacore.com>
5116
5117         PR gdb/24475:
5118         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5119         static.
5120
5121 2019-04-25  Tom Tromey  <tromey@adacore.com>
5122
5123         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5124         rvalue reference.
5125         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5126         (gdb_xml_parser::parse): Use std::move.
5127         * python/python-internal.h (gdbpy_convert_exception): Take a const
5128         reference.
5129         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5130         std::move.
5131         * python/py-utils.c (gdbpy_convert_exception): Take a const
5132         reference.
5133         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5134         Use std::move.
5135         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5136         Use std::move.
5137         * mi/mi-main.c (mi_print_exception): Take a const reference.
5138         * main.c (handle_command_errors): Take a const reference.
5139         * linespec.c (parse_linespec): Use std::move.
5140         * infcall.c (run_inferior_call): Use std::move.
5141         (call_function_by_hand_dummy): Use std::move.
5142         * exec.c (try_open_exec_file): Use std::move.
5143         * exceptions.h (exception_print, exception_fprintf)
5144         (exception_print_same): Update.
5145         * exceptions.c (print_exception, exception_print)
5146         (exception_fprintf, exception_print_same): Change parameters to
5147         const reference.
5148         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5149         * common/new-op.c: Use std::move.
5150         * common/common-exceptions.h (struct gdb_exception): Add move
5151         constructor.
5152         (struct gdb_exception_error, struct gdb_exception_quit, struct
5153         gdb_quit_bad_alloc): Change constructor to move constructor.
5154         (throw_exception): Change parameter to rvalue reference.
5155         * common/common-exceptions.c (throw_exception): Take rvalue
5156         reference.
5157         * cli/cli-interp.c (safe_execute_command): Use std::move.
5158         * breakpoint.c (insert_bp_location, location_to_sals): Use
5159         std::move.
5160
5161 2019-04-25  Tom Tromey  <tromey@adacore.com>
5162
5163         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5164         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5165         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5166         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5167         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5168         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5169         guile/scm-value.c: Use unpack.
5170         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5171         gdbscm_gdb_exception.
5172         (gdbscm_throw_gdb_exception): Likewise.
5173         (struct gdbscm_gdb_exception): New.
5174         (unpack): New function.
5175         (gdbscm_wrap): Use unpack.
5176
5177 2019-04-25  Tom Tromey  <tromey@adacore.com>
5178
5179         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5180         (gdb_rl_callback_handler): Use std::move.
5181         * common/common-exceptions.h (struct gdb_exception): Add move
5182         assignment operator.
5183         (throw_exception_sjlj): Change "exception" to const reference.
5184         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5185         (throw_exception_sjlj): Change "exception" to const reference.
5186
5187 2019-04-25  Tom Tromey  <tromey@adacore.com>
5188
5189         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5190         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5191         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5192         Update.
5193         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5194         Update.
5195         * mi/mi-interp.c (mi_interp::exec): Update.
5196         * linespec.c (parse_linespec): Update.
5197         * infcall.c (run_inferior_call): Update.
5198         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5199         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5200         (gdbscm_lookup_global_symbol): Update.
5201         * guile/scm-param.c (gdbscm_parameter_value): Update.
5202         * guile/scm-frame.c (gdbscm_frame_read_register)
5203         (gdbscm_frame_read_var): Update.
5204         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5205         * exec.c (try_open_exec_file): Update.
5206         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5207         (gdb_rl_callback_handler): Update.
5208         * common/common-exceptions.h (exception_none): Don't declare.
5209         * common/common-exceptions.c (exception_none): Don't define.
5210         (struct catcher) <exception>: Update.
5211         * cli/cli-interp.c (safe_execute_command): Update.
5212         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5213
5214 2019-04-25  Ali Tamur  <tamur@google.com>
5215
5216         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5217         (read_attribute_value): Likewise.
5218         (dwarf2_read_addr_index): Update comment.
5219         (read_str_index): Add DW_FORM_strx.
5220         (dwarf2_string_attr): Likewise.
5221         (dwarf2_const_value_attr): Likewise.
5222         (dump_die_shallow): Likewise.
5223         (dwarf2_fetch_constant_bytes): Likewise.
5224         (skip_form_bytes): Likewise.
5225         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5226
5227 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5228
5229         PR corefiles/11608
5230         PR corefiles/18187
5231         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5232         OFFSET.  Verify if current mapping contains an ELF header.
5233         (linux_find_memory_regions_full): Adjust call to
5234         dump_mapping_p.
5235
5236 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5237             Kang Li <kanglictf@gmail.com>
5238
5239         PR gdb/21600
5240
5241         * dwarf2-frame.c (read_initial_length): Be consistent about using
5242         unsigned representation of length.
5243         (decode_frame_entry_1): Likewise.  Check for wraparound of
5244         end pointer as well as buffer overflow.
5245
5246 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5247
5248         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5249         "vq".
5250
5251 2019-04-24  Tom Tromey  <tromey@adacore.com>
5252
5253         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5254
5255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5256
5257         * s12z-tdep.c (s12z_unwind_pc): Delete.
5258         (s12z_unwind_sp): Delete.
5259         (s12z_gdbarch_init): Don't register deleted functions with
5260         gdbarch.
5261
5262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5263
5264         * rl78-tdep.c (rl78_unwind_sp): Delete.
5265         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5266
5267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5268
5269         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5270         (xstormy16_unwind_pc): Delete.
5271         (xstormy16_dummy_id): Delete.
5272         (xstormy16_gdbarch_init): Don't register deleted functions with
5273         gdbarch.
5274
5275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5276
5277         * vax-tdep.c (vax_unwind_pc): Delete.
5278         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5279
5280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5281
5282         * v850-tdep.c (v850_unwind_sp): Delete.
5283         (v850_unwind_pc): Delete.
5284         (v850_dummy_id): Delete.
5285         (v850_gdbarch_init): Don't register deleted functions with
5286         gdbarch.
5287
5288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5289
5290         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5291         (tilegx_unwind_pc): Delete.
5292         (tilegx_unwind_dummy_id): Delete.
5293         (tilegx_gdbarch_init): Don't register deleted functions with
5294         gdbarch.
5295
5296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5297
5298         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5299         (tic6x_dummy_id): Delete.
5300         (tic6x_gdbarch_init): Don't register deleted functions with
5301         gdbarch.
5302
5303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5304
5305         * sparc-tdep.c (sparc_unwind_pc): Delete.
5306         (sparc32_gdbarch_init): Don't register deleted function with
5307         gdbarch.
5308
5309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5310
5311         * sh-tdep.c (sh_unwind_sp): Delete.
5312         (sh_unwind_pc): Delete.
5313         (sh_dummy_id): Delete.
5314         (sh_gdbarch_init): Don't register deleted functions with
5315         gdbarch.
5316
5317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5318
5319         * score-tdep.c (score_unwind_sp): Delete.
5320         (score_unwind_pc): Delete.
5321         (score_dummy_id): Delete.
5322         (score_gdbarch_init): Don't register deleted functions with
5323         gdbarch.
5324
5325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5326
5327         * rx-tdep.c (rx_unwind_pc): Delete.
5328         (rx_unwind_sp): Delete.
5329         (rx_dummy_id): Delete.
5330         (rx_gdbarch_init): Don't register deleted functions with
5331         gdbarch.  Update comment.
5332
5333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5334
5335         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5336         (rs6000_dummy_id): Delete.
5337         (rs6000_gdbarch_init): Don't register deleted functions with
5338         gdbarch.
5339
5340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5341
5342         * or1k-tdep.c (or1k_dummy_id): Delete.
5343         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5344
5345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5346
5347         * nios2-tdep.c (nios2_dummy_id): Delete.
5348         (nios2_unwind_sp): Delete.
5349         (nios2_gdbarch_init): Don't register deleted functions with
5350         gdbarch.
5351
5352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5353
5354         * nds32-tdep.c (nds32_dummy_id): Delete.
5355         (nds32_unwind_pc): Delete.
5356         (nds32_unwind_sp): Delete.
5357         (nds32_gdbarch_init): Don't register deleted functions with
5358         gdbarch.
5359
5360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5361
5362         * msp430-tdep.c (msp430_unwind_pc): Delete.
5363         (msp430_unwind_sp): Delete.
5364         (msp430_dummy_id): Delete.
5365         (msp430_gdbarch_init): Don't register deleted functions with
5366         gdbarch.
5367
5368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5369
5370         * moxie-tdep.c (moxie_unwind_sp): Delete.
5371         (moxie_unwind_pc): Delete.
5372         (moxie_dummy_id): Delete.
5373         (moxie_gdbarch_init): Don't register deleted functions with
5374         gdbarch.
5375
5376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5377
5378         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5379         (mn10300_unwind_pc): Delete.
5380         (mn10300_unwind_sp): Delete.
5381         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5382         mn10300_unwind_sp.
5383         (mn10300_frame_unwind_init): Don't register deleted functions with
5384         gdbarch.
5385
5386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5387
5388         * mep-tdep.c (mep_unwind_pc): Delete.
5389         (mep_unwind_sp): Delete.
5390         (mep_dummy_id): Delete.
5391         (mep_gdbarch_init): Don't register deleted functions with
5392         gdbarch.
5393
5394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5395
5396         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5397         (m68hc11_unwind_sp): Delete.
5398         (m68hc11_gdbarch_init): Don't register deleted functions with
5399         gdbarch.
5400
5401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5402
5403         * m32r-tdep.c (m32r_unwind_sp): Delete.
5404         (m32r_unwind_pc): Delete.
5405         (m32r_dummy_id): Delete.
5406         (m32r_gdbarch_init): Don't register deleted functions with
5407         gdbarch.
5408
5409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5410
5411         * m32c-tdep.c (m32c_unwind_pc): Delete.
5412         (m32c_unwind_sp): Delete.
5413         (m32c_dummy_id): Delete.
5414         (m32c_gdbarch_init): Don't register deleted functions with
5415         gdbarch.
5416
5417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5418
5419         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5420         (lm32_unwind_pc): Delete.
5421         (lm32_dummy_id): Delete.
5422         (lm32_gdbarch_init): Don't register deleted functions with
5423         gdbarch.
5424
5425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5426
5427         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5428         (iq2000_unwind_pc): Delete.
5429         (iq2000_dummy_id): Delete.
5430         (iq2000_gdbarch_init): Don't register deleted functions with
5431         gdbarch.
5432
5433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5434
5435         * nds32-tdep.c (nds32_type_align): Delete.
5436         (nds32_push_dummy_call): Use type_align instead.
5437
5438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5439
5440         * arm-tdep.c (arm_type_align): Only handle vector override case.
5441         (arm_push_dummy_call): Use type_align.
5442         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5443
5444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5445
5446         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5447         case.
5448         (pass_on_stack): Use type_align.
5449         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5450         function.
5451
5452 2019-04-23  Tom Tromey  <tromey@adacore.com>
5453
5454         * dwarf2read.c (line_header::file_name_at): Remove unused
5455         overload.
5456
5457 2019-04-23  Tom de Vries  <tdevries@suse.de>
5458
5459         PR gdb/24438
5460         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5461         invocation.
5462
5463
5464 2019-03-27  Ali Tamur  <tamur@google.com>
5465
5466         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5467         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5468         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5469         (dwarf_expr_context::get_addr_index): Likewise
5470         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5471         (symbol_needs_eval_context::get_addr_index): Likewise
5472         (disassemble_dwarf_expression): Add DW_OP_addrx
5473         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5474         (read_cutu_die_from_dwo): Update comment
5475         (skip_one_die): Add DW_FORM_addrx
5476         (read_attribute_value): Likewise
5477         (var_decode_location): Add DW_OP_addrx
5478         (dwarf2_const_value_attr): Add DW_FORM_addrx
5479         (dump_die_shallow): Likewise
5480         (dwarf2_fetch_constant_bytes): Likewise
5481         (decode_locdesc): Add DW_OP_addrx
5482         (skip_form_bytes): Add DW_FORM_addrx
5483
5484 2019-04-22  Ali Tamur  <tamur@google.com>
5485
5486         * MAINTAINERS (Write After Approval): Add self.
5487
5488 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5489
5490         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5491         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5492         (open_symbol_file_object): Likewise.
5493         (svr4_default_sos): Add info parameter.
5494         (svr4_read_so_list): Likewise.
5495         (svr4_current_sos_direct): Adjust functions calls to pass down
5496         info.
5497         (svr4_current_sos_1): Add info parameter.
5498         (svr4_current_sos): Call get_svr4_info, pass info down to
5499         svr4_current_sos_1.
5500         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5501         get_svr4_info.
5502         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5503         get_svr4_info.
5504         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5505         to get_svr4_info.
5506         (probes_table_remove_objfile_probes): Likewise.
5507         (register_solib_event_probe): Add info parameter.
5508         (solist_update_incremental): Pass info parameter down to
5509         svr4_read_so_list.
5510         (disable_probes_interface): Add info parameter.
5511         (svr4_handle_solib_event): Pass current_program_space to
5512         get_svr4_info.  Adjust disable_probes_interface cleanup.
5513         (svr4_create_probe_breakpoints): Add info parameter, pass it
5514         down to register_solib_event_probe.
5515         (svr4_create_solib_event_breakpoints): Add info parameter,
5516         pass it down to svr4_create_probe_breakpoints.
5517         (enable_break): Pass info down to
5518         svr4_create_solib_event_breakpoints.
5519         (svr4_solib_create_inferior_hook): Pass current_program_space to
5520         get_svr4_info.
5521         (svr4_clear_solib): Likewise.
5522
5523 2019-04-22  Pedro Alves  <palves@redhat.com>
5524
5525         * solib-svr4.c (svr4_free_objfile_observer): New.
5526         (probe_and_action::objfile): New field.
5527         (probes_table_htab_remove_objfile_probes)
5528         (probes_table_remove_objfile_probes): New functions.
5529         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5530         in the new probe_and_action.  Don't store the probe in 'lookup'.
5531         (svr4_create_probe_breakpoints): Pass objfile to
5532         register_solib_event_probe.
5533         (_initialize_svr4_solib): Register a free_objfile observer.
5534
5535 2019-04-19  Tom Tromey  <tom@tromey.com>
5536
5537         * common/queue.h: Remove.
5538
5539 2019-04-19  Tom Tromey  <tom@tromey.com>
5540
5541         * event-loop.c: Don't include "common/queue.h".
5542
5543 2019-04-19  Tom Tromey  <tom@tromey.com>
5544
5545         * remote.c (remote_target): Use delete.
5546         * remote-notif.h: Include <list>, not "common/queue.h".
5547         (notif_client_p): Remove typedef.
5548         (remote_notif_state): Add constructor, destructor, initializer.
5549         <notif_queue>: Now a std::list.
5550         (remote_notif_state_xfree): Don't declare.
5551         * remote-notif.c (remote_notif_process, handle_notification)
5552         (remote_notif_state_allocate): Update.
5553         (~remote_notif_state): Rename from remote_notif_state_xfree.
5554
5555 2019-04-19  Tom Tromey  <tom@tromey.com>
5556
5557         * symfile.c (reread_symbols): Update.
5558         * objfiles.c (objfile_register_static_link)
5559         (objfile_lookup_static_link): Update
5560         (~objfile) Don't delete static_links.
5561         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5562
5563 2019-04-19  Tom Tromey  <tom@tromey.com>
5564
5565         * type-stack.h (struct type_stack) <insert>: Constify string.
5566         * type-stack.c (type_stack::insert): Constify string.
5567         * gdbtypes.h (lookup_template_type): Update.
5568         (address_space_name_to_int): Update.
5569         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5570         const.
5571         (lookup_template_type): Make name const.
5572         * c-exp.y: Update rules.
5573         (lex_one_token, classify_name, classify_inner_name)
5574         (c_print_token): Update.
5575         * p-exp.y: Update rules.
5576         (yylex): Update.
5577         * f-exp.y: Update rules.
5578         (yylex): Update.
5579         * d-exp.y: Update rules.
5580         (lex_one_token, classify_name, classify_inner_name): Update.
5581         * parse.c (write_dollar_variable, copy_name): Return std::string.
5582         * parser-defs.h (copy_name): Change return type.
5583         * m2-exp.y: Update rules.
5584         (yylex): Update.
5585         * go-exp.y (lex_one_token): Update.
5586         Update rules.
5587         (classify_unsafe_function, classify_packaged_name)
5588         (classify_name, yylex): Update.
5589
5590 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5591
5592         * configure.ac: add --enable-source-highlight switch.
5593         * configure: Regenerate.
5594         * top.c (print_gdb_version): plumb --enable-source-highlight
5595         status to "show configuration".
5596
5597 2019-04-19  Tom Tromey  <tromey@adacore.com>
5598
5599         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5600         Check ADA_TYPE_P.
5601         (empty_record, ada_template_to_fixed_record_type_1)
5602         (template_to_static_fixed_type)
5603         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5604         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5605         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5606         macros.
5607
5608 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5609
5610         PR symtab/24423:
5611         * source.c (print_source_lines_base): Advance "iter" when a
5612         control character is seen.
5613
5614 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5615
5616         * inferior.h (struct infcall_suspend_state_deleter):
5617         Catch exception in destructor to avoid crash.
5618
5619 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5620
5621         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5622         close to the add_com "shell".
5623
5624 2019-04-18  Tom Tromey  <tromey@adacore.com>
5625
5626         * process-stratum-target.h (class process_stratum_target)
5627         <stratum>: Add "final".
5628
5629 2019-04-17  Tom Tromey  <tromey@adacore.com>
5630
5631         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5632         against nullptr before use.
5633
5634 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5635
5636         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5637
5638 2019-04-17  Jim Wilson  <jimw@sifive.com>
5639             Andrew Burgess  <andrew.burgess@embecosm.com>
5640
5641         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5642         code read might fail, assume 4-byte breakpoint in that case.
5643
5644 2019-04-15  Leszek Swirski  <leszeks@google.com>
5645
5646         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5647         rather than a hand-rolled POD check when checking for forced MEMORY
5648         classification.
5649
5650 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5651
5652         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5653         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5654         function.
5655         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5656         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5657         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5658         declaration.
5659
5660 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5661
5662         * aarch64-linux-nat.c
5663         (aarch64_linux_nat_target::thread_architecture): Add override.
5664         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5665         each VQ.
5666
5667 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5668
5669         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5670
5671 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5672
5673         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5674         target types of size 96-bits, add some additional comments, and
5675         check that the builtin type we found was the correct size.
5676
5677 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5678
5679         * utils.c (prompt_for_continue): Don't restore the styling at the
5680         end, as applied_style has the wrong value.  This fixes styling in
5681         long lists of file names that are interrupted by the "Continue?"
5682         prompt.
5683
5684 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5685
5686         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5687         * c-lang.c (c_language_defn): Likewise.
5688         (cplus_language_defn): Likewise.
5689         (asm_language_defn): Likewise.
5690         (minimal_language_defn): Likewise.
5691         * d-lang.c (d_language_defn): Likewise.
5692         * f-lang.c (f_language_defn): Likewise.
5693         * go-lang.c (go_language_defn): Likewise.
5694         * language.c (unknown_language_defn): Likewise.
5695         (auto_language_defn): Likewise.
5696         * language.h (struct language_defn): Remove la_magic field.
5697         (LANG_MAGIC): Delete.
5698         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5699         * objc-lang.c (objc_language_defn): Likewise.
5700         * opencl-lang.c (opencl_language_defn): Likewise.
5701         * p-lang.c (pascal_language_defn): Likewise.
5702         * rust-lang.c (rust_language_defn): Likewise.
5703
5704 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5705
5706         * riscv-tdep.c (riscv_type_align): New function.
5707         (riscv_type_alignment): Delete.
5708         (riscv_arg_location): Use 'type_align'.
5709         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5710
5711 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5712
5713         * gdbtypes.c (type_align): A struct with no non-static fields also
5714         has alignment of 1.
5715
5716 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5717
5718         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5719         component to 0.
5720         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5721         member.
5722         (riscv_struct_info::analyse): New implementation using new
5723         analyse_inner member function.
5724         (riscv_struct_info::field_offset): New member function.
5725         (riscv_struct_info::m_offsets): New member variable.
5726         (riscv_struct_info::analyse_inner): New private member function,
5727         takes the old implementation of riscv_struct_info::analyse but
5728         extended to track field offsets.
5729         (riscv_call_arg_struct): Update the struct folding special cases
5730         to handle cases where empty C++ structs, which are non-zero
5731         length, are found.
5732         (riscv_arg_location): Initialise the length of each location, a
5733         non-zero length now indicates the location is in use.
5734         (riscv_push_dummy_call): Allow for the first location having a
5735         non-zero offset when setting up arguments.
5736         (riscv_return_value): Likewise, but for return values.
5737
5738 2019-04-11  Tom Tromey  <tromey@adacore.com>
5739
5740         * utils.c (internal_vproblem): Make "msg" const.
5741
5742 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5743
5744         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5745         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5746         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5747         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5748
5749 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5750
5751         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5752         function.
5753         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5754         of amd64_collect_native_gregset.
5755         (amd64_linux_nat_target::store_registers): Likewise.
5756
5757 2019-04-10  Tom Tromey  <tom@tromey.com>
5758
5759         * symtab.c (lookup_global_symbol_from_objfile)
5760         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5761         * objfiles.h (class separate_debug_iterator): New.
5762         (class separate_debug_range): New.
5763         (struct objfile) <separate_debug_objfiles>: New method.
5764         (objfile_separate_debug_iterate): Don't declare.
5765         * objfiles.c (separate_debug_iterator::operator++): Rename from
5766         objfile_separate_debug_iterate.
5767         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5768         iterator.
5769         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5770         iterator.
5771
5772 2019-04-10  Tom Tromey  <tom@tromey.com>
5773
5774         * symfile.c (reread_symbols): Remove old comment.
5775         * objfiles.c (free_all_objfiles): Fix a typo.
5776
5777 2019-04-10  Tom Tromey  <tom@tromey.com>
5778
5779         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5780         * minsyms.c (lookup_minimal_symbol): Use foreach.
5781         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5782         (lookup_minimal_symbol_solib_trampoline): Likewise.
5783         * symfile.c (reread_symbols): Use foreach.
5784
5785 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5786             Tom Tromey  <tromey@adacore.com>
5787
5788         PR rust/24414:
5789         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5790         (rust_lex_int_test): Change "value" to be LONGEST.
5791         (rust_lex_tests): Add test for long integer literal.
5792
5793 2019-04-09  Tom Tromey  <tromey@adacore.com>
5794
5795         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5796         to bool.
5797         (extended_remote_target::attach): Update.
5798         (remote_target::remote_notice_new_inferior): Update.
5799         (remote_target::add_current_inferior_and_thread): Update.
5800         * inferior.c (exit_inferior_1): Use "false".
5801         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5802
5803 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5804
5805         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5806         the "start" command.
5807
5808 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5809
5810         * python/py-inferior.c (infpy_thread_from_thread_handle):
5811         Adjust comments to reflect renaming of thread_from_thread_handle
5812         to thread_from_handle.  Adjust keywords.  Fix type error message.
5813         (inferior_object_methods): Add thread_from_handle.  Retain
5814         thread_from_thread_handle, but mark it as deprecated.
5815
5816 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5817
5818         * gdbthread.h (find_thread_by_handle): Revise declaration.
5819         * thread.c (find_thread_by_handle): Likewise.  Adjust
5820         implementation too.
5821         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5822         support for buffer objects as handles.
5823
5824 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5825
5826         * python/py-infthread.c (thpy_thread_handle): New function.
5827         (thread_object_methods): Register thpy_thread_handle.
5828
5829 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5830
5831         * gdbthread.h (thread_to_thread_handle): Declare.
5832         * thread.c (gdbtypes.h): Include.
5833         (thread_to_thread_handle): New function.
5834
5835         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5836         (target_thread_info_to_thread_handle): Declare.
5837         * target.c (target_thread_info_to_thread_handle): New function.
5838         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5839         * target-delegates.c: Regenerate.
5840
5841         * linux-thread-db.c (class thread_db_target): Add method
5842         thread_info_to_thread_handle.
5843         (thread_db_target::thread_info_to_thread_handle): Define.
5844         * remote.c (class remote_target): Add new method
5845         thread_info_to_thread_handle.
5846         (remote_target::thread_info_to_thread_handle): Define.
5847
5848 2019-04-08  Pedro Alves  <palves@redhat.com>
5849
5850         * common/common-exceptions.c (throw_exception): Don't create
5851         named object to throw; throw directly.
5852         (throw_it): Likewise.  Don't initialize gdb_exception::message
5853         here, with new; pass FMT and AP to the ctor instead.
5854         * common/common-exceptions.h: Include <string>.
5855         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5856         const char *, va_list)): New ctor.  Use std::make_shared.
5857         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5858         errors)): Delete.
5859         (gdb_exception_error::gdb_exception_error(enum errors, const char
5860         *, va_list)): New.
5861         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5862         Add assertion.
5863         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5864         errors)): Delete.
5865         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5866         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5867         Add assertion.
5868
5869 2019-04-08  Tom Tromey  <tom@tromey.com>
5870
5871         * valops.c (value_rtti_indirect_type): Replace throw_exception
5872         with throw.
5873         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5874         with throw.
5875         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5876         throw.
5877         * target.c (target_translate_tls_address): Replace throw_exception
5878         with throw.
5879         * stack.c (frame_apply_command_count): Replace throw_exception
5880         with throw.
5881         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5882         throw.
5883         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5884         with throw.
5885         * rs6000-tdep.c (rs6000_frame_cache)
5886         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5887         * remote.c: Replace throw_exception with throw.
5888         * record-full.c (record_full_message, record_full_wait_1)
5889         (record_full_restore): Replace throw_exception with throw.
5890         * record-btrace.c:
5891         (get_thread_current_frame_id, record_btrace_start_replaying)
5892         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5893         (cmd_record_btrace_start): Replace throw_exception with throw.
5894         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5895         throw.
5896         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5897         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5898         * linespec.c:
5899         (find_linespec_symbols): Replace throw_exception with throw.
5900         * infrun.c (displaced_step_prepare, resume): Replace
5901         throw_exception with throw.
5902         * infcmd.c (post_create_inferior): Replace throw_exception with
5903         throw.
5904         * inf-loop.c (inferior_event_handler): Replace throw_exception
5905         with throw.
5906         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5907         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5908         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5909         (get_prev_frame_always, get_frame_pc_if_available)
5910         (get_frame_address_in_block_if_available, get_frame_language):
5911         Replace throw_exception with throw.
5912         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5913         throw_exception with throw.
5914         * eval.c (fetch_subexp_value, evaluate_var_value)
5915         (evaluate_funcall, evaluate_subexp_standard): Replace
5916         throw_exception with throw.
5917         * dwarf2loc.c (call_site_find_chain)
5918         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5919         Replace throw_exception with throw.
5920         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5921         with throw.
5922         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5923         throw.
5924         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5925         * completer.c (complete_line_internal): Replace throw_exception
5926         with throw.
5927         * compile/compile-object-run.c (compile_object_run): Replace
5928         throw_exception with throw.
5929         * cli/cli-script.c (process_next_line): Replace throw_exception
5930         with throw.
5931         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5932         (btrace_enable, btrace_maint_update_pt_packets): Replace
5933         throw_exception with throw.
5934         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5935         throw_exception with throw.
5936         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5937         throw_exception with throw.
5938         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5939         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5940         * aarch64-tdep.c (aarch64_make_prologue_cache)
5941         (aarch64_make_stub_cache): Replace throw_exception with throw.
5942
5943 2019-04-08  Tom Tromey  <tom@tromey.com>
5944
5945         * common/common-exceptions.c (throw_exception): Rename from
5946         throw_exception_cxx.  Remove old copy.  Make argument const.
5947         (throw_it): Create and throw exception objects directly.
5948         * common/common-exceptions.h (throw_exception): Make argument
5949         const.
5950         (struct gdb_exception_error): Add constructor.
5951         (struct gdb_exception_quit): Add constructor.
5952
5953 2019-04-08  Tom Tromey  <tom@tromey.com>
5954
5955         * common/common-exceptions.h (exception_rethrow): Don't declare.
5956         (TRY_SJLJ): Update comment.
5957         (TRY, CATCH, END_CATCH): Remove.
5958         * common/common-exceptions.c (exception_rethrow): Remove.
5959
5960 2019-04-08  Tom Tromey  <tom@tromey.com>
5961
5962         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5963         Remove.
5964         (gdb_exception_error): Rename from
5965         gdb_exception_RETURN_MASK_ERROR.
5966         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5967         (gdb_quit_bad_alloc): Update.
5968         * aarch64-tdep.c: Update.
5969         * ada-lang.c: Update.
5970         * ada-typeprint.c: Update.
5971         * ada-valprint.c: Update.
5972         * amd64-tdep.c: Update.
5973         * arch-utils.c: Update.
5974         * break-catch-throw.c: Update.
5975         * breakpoint.c: Update.
5976         * btrace.c: Update.
5977         * c-varobj.c: Update.
5978         * cli/cli-cmds.c: Update.
5979         * cli/cli-interp.c: Update.
5980         * cli/cli-script.c: Update.
5981         * common/common-exceptions.c: Update.
5982         * common/new-op.c: Update.
5983         * common/selftest.c: Update.
5984         * compile/compile-c-symbols.c: Update.
5985         * compile/compile-cplus-symbols.c: Update.
5986         * compile/compile-object-load.c: Update.
5987         * compile/compile-object-run.c: Update.
5988         * completer.c: Update.
5989         * corelow.c: Update.
5990         * cp-abi.c: Update.
5991         * cp-support.c: Update.
5992         * cp-valprint.c: Update.
5993         * darwin-nat.c: Update.
5994         * disasm-selftests.c: Update.
5995         * dtrace-probe.c: Update.
5996         * dwarf-index-cache.c: Update.
5997         * dwarf-index-write.c: Update.
5998         * dwarf2-frame-tailcall.c: Update.
5999         * dwarf2-frame.c: Update.
6000         * dwarf2loc.c: Update.
6001         * dwarf2read.c: Update.
6002         * eval.c: Update.
6003         * event-loop.c: Update.
6004         * event-top.c: Update.
6005         * exec.c: Update.
6006         * f-valprint.c: Update.
6007         * fbsd-tdep.c: Update.
6008         * frame-unwind.c: Update.
6009         * frame.c: Update.
6010         * gdbtypes.c: Update.
6011         * gnu-v3-abi.c: Update.
6012         * guile/guile-internal.h: Update.
6013         * guile/scm-block.c: Update.
6014         * guile/scm-breakpoint.c: Update.
6015         * guile/scm-cmd.c: Update.
6016         * guile/scm-disasm.c: Update.
6017         * guile/scm-frame.c: Update.
6018         * guile/scm-lazy-string.c: Update.
6019         * guile/scm-math.c: Update.
6020         * guile/scm-param.c: Update.
6021         * guile/scm-ports.c: Update.
6022         * guile/scm-pretty-print.c: Update.
6023         * guile/scm-symbol.c: Update.
6024         * guile/scm-symtab.c: Update.
6025         * guile/scm-type.c: Update.
6026         * guile/scm-value.c: Update.
6027         * i386-linux-tdep.c: Update.
6028         * i386-tdep.c: Update.
6029         * inf-loop.c: Update.
6030         * infcall.c: Update.
6031         * infcmd.c: Update.
6032         * infrun.c: Update.
6033         * jit.c: Update.
6034         * language.c: Update.
6035         * linespec.c: Update.
6036         * linux-fork.c: Update.
6037         * linux-nat.c: Update.
6038         * linux-tdep.c: Update.
6039         * linux-thread-db.c: Update.
6040         * main.c: Update.
6041         * mi/mi-cmd-break.c: Update.
6042         * mi/mi-cmd-stack.c: Update.
6043         * mi/mi-interp.c: Update.
6044         * mi/mi-main.c: Update.
6045         * objc-lang.c: Update.
6046         * p-valprint.c: Update.
6047         * parse.c: Update.
6048         * ppc-linux-tdep.c: Update.
6049         * printcmd.c: Update.
6050         * python/py-arch.c: Update.
6051         * python/py-breakpoint.c: Update.
6052         * python/py-cmd.c: Update.
6053         * python/py-finishbreakpoint.c: Update.
6054         * python/py-frame.c: Update.
6055         * python/py-framefilter.c: Update.
6056         * python/py-gdb-readline.c: Update.
6057         * python/py-inferior.c: Update.
6058         * python/py-infthread.c: Update.
6059         * python/py-lazy-string.c: Update.
6060         * python/py-linetable.c: Update.
6061         * python/py-objfile.c: Update.
6062         * python/py-param.c: Update.
6063         * python/py-prettyprint.c: Update.
6064         * python/py-progspace.c: Update.
6065         * python/py-record-btrace.c: Update.
6066         * python/py-record.c: Update.
6067         * python/py-symbol.c: Update.
6068         * python/py-type.c: Update.
6069         * python/py-unwind.c: Update.
6070         * python/py-utils.c: Update.
6071         * python/py-value.c: Update.
6072         * python/python.c: Update.
6073         * record-btrace.c: Update.
6074         * record-full.c: Update.
6075         * remote-fileio.c: Update.
6076         * remote.c: Update.
6077         * riscv-tdep.c: Update.
6078         * rs6000-aix-tdep.c: Update.
6079         * rs6000-tdep.c: Update.
6080         * rust-exp.y: Update.
6081         * rust-lang.c: Update.
6082         * s390-tdep.c: Update.
6083         * selftest-arch.c: Update.
6084         * solib-dsbt.c: Update.
6085         * solib-frv.c: Update.
6086         * solib-spu.c: Update.
6087         * solib-svr4.c: Update.
6088         * solib.c: Update.
6089         * sparc64-linux-tdep.c: Update.
6090         * stack.c: Update.
6091         * symfile-mem.c: Update.
6092         * symmisc.c: Update.
6093         * target.c: Update.
6094         * thread.c: Update.
6095         * top.c: Update.
6096         * tracefile-tfile.c: Update.
6097         * tui/tui.c: Update.
6098         * typeprint.c: Update.
6099         * unittests/cli-utils-selftests.c: Update.
6100         * unittests/parse-connection-spec-selftests.c: Update.
6101         * valops.c: Update.
6102         * valprint.c: Update.
6103         * value.c: Update.
6104         * varobj.c: Update.
6105         * windows-nat.c: Update.
6106         * x86-linux-nat.c: Update.
6107         * xml-support.c: Update.
6108
6109 2019-04-08  Tom Tromey  <tom@tromey.com>
6110
6111         * xml-support.c: Use C++ exception handling.
6112         * x86-linux-nat.c: Use C++ exception handling.
6113         * windows-nat.c: Use C++ exception handling.
6114         * varobj.c: Use C++ exception handling.
6115         * value.c: Use C++ exception handling.
6116         * valprint.c: Use C++ exception handling.
6117         * valops.c: Use C++ exception handling.
6118         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6119         handling.
6120         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6121         * typeprint.c: Use C++ exception handling.
6122         * tui/tui.c: Use C++ exception handling.
6123         * tracefile-tfile.c: Use C++ exception handling.
6124         * top.c: Use C++ exception handling.
6125         * thread.c: Use C++ exception handling.
6126         * target.c: Use C++ exception handling.
6127         * symmisc.c: Use C++ exception handling.
6128         * symfile-mem.c: Use C++ exception handling.
6129         * stack.c: Use C++ exception handling.
6130         * sparc64-linux-tdep.c: Use C++ exception handling.
6131         * solib.c: Use C++ exception handling.
6132         * solib-svr4.c: Use C++ exception handling.
6133         * solib-spu.c: Use C++ exception handling.
6134         * solib-frv.c: Use C++ exception handling.
6135         * solib-dsbt.c: Use C++ exception handling.
6136         * selftest-arch.c: Use C++ exception handling.
6137         * s390-tdep.c: Use C++ exception handling.
6138         * rust-lang.c: Use C++ exception handling.
6139         * rust-exp.y: Use C++ exception handling.
6140         * rs6000-tdep.c: Use C++ exception handling.
6141         * rs6000-aix-tdep.c: Use C++ exception handling.
6142         * riscv-tdep.c: Use C++ exception handling.
6143         * remote.c: Use C++ exception handling.
6144         * remote-fileio.c: Use C++ exception handling.
6145         * record-full.c: Use C++ exception handling.
6146         * record-btrace.c: Use C++ exception handling.
6147         * python/python.c: Use C++ exception handling.
6148         * python/py-value.c: Use C++ exception handling.
6149         * python/py-utils.c: Use C++ exception handling.
6150         * python/py-unwind.c: Use C++ exception handling.
6151         * python/py-type.c: Use C++ exception handling.
6152         * python/py-symbol.c: Use C++ exception handling.
6153         * python/py-record.c: Use C++ exception handling.
6154         * python/py-record-btrace.c: Use C++ exception handling.
6155         * python/py-progspace.c: Use C++ exception handling.
6156         * python/py-prettyprint.c: Use C++ exception handling.
6157         * python/py-param.c: Use C++ exception handling.
6158         * python/py-objfile.c: Use C++ exception handling.
6159         * python/py-linetable.c: Use C++ exception handling.
6160         * python/py-lazy-string.c: Use C++ exception handling.
6161         * python/py-infthread.c: Use C++ exception handling.
6162         * python/py-inferior.c: Use C++ exception handling.
6163         * python/py-gdb-readline.c: Use C++ exception handling.
6164         * python/py-framefilter.c: Use C++ exception handling.
6165         * python/py-frame.c: Use C++ exception handling.
6166         * python/py-finishbreakpoint.c: Use C++ exception handling.
6167         * python/py-cmd.c: Use C++ exception handling.
6168         * python/py-breakpoint.c: Use C++ exception handling.
6169         * python/py-arch.c: Use C++ exception handling.
6170         * printcmd.c: Use C++ exception handling.
6171         * ppc-linux-tdep.c: Use C++ exception handling.
6172         * parse.c: Use C++ exception handling.
6173         * p-valprint.c: Use C++ exception handling.
6174         * objc-lang.c: Use C++ exception handling.
6175         * mi/mi-main.c: Use C++ exception handling.
6176         * mi/mi-interp.c: Use C++ exception handling.
6177         * mi/mi-cmd-stack.c: Use C++ exception handling.
6178         * mi/mi-cmd-break.c: Use C++ exception handling.
6179         * main.c: Use C++ exception handling.
6180         * linux-thread-db.c: Use C++ exception handling.
6181         * linux-tdep.c: Use C++ exception handling.
6182         * linux-nat.c: Use C++ exception handling.
6183         * linux-fork.c: Use C++ exception handling.
6184         * linespec.c: Use C++ exception handling.
6185         * language.c: Use C++ exception handling.
6186         * jit.c: Use C++ exception handling.
6187         * infrun.c: Use C++ exception handling.
6188         * infcmd.c: Use C++ exception handling.
6189         * infcall.c: Use C++ exception handling.
6190         * inf-loop.c: Use C++ exception handling.
6191         * i386-tdep.c: Use C++ exception handling.
6192         * i386-linux-tdep.c: Use C++ exception handling.
6193         * guile/scm-value.c: Use C++ exception handling.
6194         * guile/scm-type.c: Use C++ exception handling.
6195         * guile/scm-symtab.c: Use C++ exception handling.
6196         * guile/scm-symbol.c: Use C++ exception handling.
6197         * guile/scm-pretty-print.c: Use C++ exception handling.
6198         * guile/scm-ports.c: Use C++ exception handling.
6199         * guile/scm-param.c: Use C++ exception handling.
6200         * guile/scm-math.c: Use C++ exception handling.
6201         * guile/scm-lazy-string.c: Use C++ exception handling.
6202         * guile/scm-frame.c: Use C++ exception handling.
6203         * guile/scm-disasm.c: Use C++ exception handling.
6204         * guile/scm-cmd.c: Use C++ exception handling.
6205         * guile/scm-breakpoint.c: Use C++ exception handling.
6206         * guile/scm-block.c: Use C++ exception handling.
6207         * guile/guile-internal.h: Use C++ exception handling.
6208         * gnu-v3-abi.c: Use C++ exception handling.
6209         * gdbtypes.c: Use C++ exception handling.
6210         * frame.c: Use C++ exception handling.
6211         * frame-unwind.c: Use C++ exception handling.
6212         * fbsd-tdep.c: Use C++ exception handling.
6213         * f-valprint.c: Use C++ exception handling.
6214         * exec.c: Use C++ exception handling.
6215         * event-top.c: Use C++ exception handling.
6216         * event-loop.c: Use C++ exception handling.
6217         * eval.c: Use C++ exception handling.
6218         * dwarf2read.c: Use C++ exception handling.
6219         * dwarf2loc.c: Use C++ exception handling.
6220         * dwarf2-frame.c: Use C++ exception handling.
6221         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6222         * dwarf-index-write.c: Use C++ exception handling.
6223         * dwarf-index-cache.c: Use C++ exception handling.
6224         * dtrace-probe.c: Use C++ exception handling.
6225         * disasm-selftests.c: Use C++ exception handling.
6226         * darwin-nat.c: Use C++ exception handling.
6227         * cp-valprint.c: Use C++ exception handling.
6228         * cp-support.c: Use C++ exception handling.
6229         * cp-abi.c: Use C++ exception handling.
6230         * corelow.c: Use C++ exception handling.
6231         * completer.c: Use C++ exception handling.
6232         * compile/compile-object-run.c: Use C++ exception handling.
6233         * compile/compile-object-load.c: Use C++ exception handling.
6234         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6235         * compile/compile-c-symbols.c: Use C++ exception handling.
6236         * common/selftest.c: Use C++ exception handling.
6237         * common/new-op.c: Use C++ exception handling.
6238         * cli/cli-script.c: Use C++ exception handling.
6239         * cli/cli-interp.c: Use C++ exception handling.
6240         * cli/cli-cmds.c: Use C++ exception handling.
6241         * c-varobj.c: Use C++ exception handling.
6242         * btrace.c: Use C++ exception handling.
6243         * breakpoint.c: Use C++ exception handling.
6244         * break-catch-throw.c: Use C++ exception handling.
6245         * arch-utils.c: Use C++ exception handling.
6246         * amd64-tdep.c: Use C++ exception handling.
6247         * ada-valprint.c: Use C++ exception handling.
6248         * ada-typeprint.c: Use C++ exception handling.
6249         * ada-lang.c: Use C++ exception handling.
6250         * aarch64-tdep.c: Use C++ exception handling.
6251
6252 2019-04-08  Tom Tromey  <tom@tromey.com>
6253
6254         * xml-support.c (gdb_xml_parser::parse): Update.
6255         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6256         * value.c (show_convenience): Update.
6257         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6258         (test_parse_flags_qcs): Update.
6259         * thread.c (thr_try_catch_cmd): Update.
6260         * target.c (target_translate_tls_address): Update.
6261         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6262         (info_frame_command_core, frame_apply_command_count): Update.
6263         * rust-exp.y (rust_lex_exception_test): Update.
6264         * riscv-tdep.c (riscv_print_one_register_info): Update.
6265         * remote.c (remote_target::enable_btrace): Update.
6266         * record-btrace.c (record_btrace_enable_warn): Update.
6267         * python/py-utils.c (gdbpy_convert_exception): Update.
6268         * printcmd.c (do_one_display, print_variable_and_value): Update.
6269         * mi/mi-main.c (mi_print_exception): Update.
6270         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6271         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6272         * linux-nat.c (linux_nat_target::attach): Update.
6273         * linux-fork.c (class scoped_switch_fork_info): Update.
6274         * infrun.c (displaced_step_prepare): Update.
6275         * infcall.c (call_function_by_hand_dummy): Update.
6276         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6277         * gnu-v3-abi.c (print_one_vtable): Update.
6278         * frame.c (get_prev_frame_always): Update.
6279         * f-valprint.c (info_common_command_for_block): Update.
6280         * exec.c (try_open_exec_file): Update.
6281         * exceptions.c (print_exception, exception_print)
6282         (exception_fprintf, exception_print_same): Update.
6283         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6284         * dwarf-index-cache.c (index_cache::store)
6285         (index_cache::lookup_gdb_index): Update.
6286         * darwin-nat.c (maybe_cache_shell): Update.
6287         * cp-valprint.c (cp_print_value_fields): Update.
6288         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6289         (gcc_cplus_symbol_address): Update.
6290         * compile/compile-c-symbols.c (gcc_convert_symbol)
6291         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6292         * common/selftest.c: Update.
6293         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6294         a std::string.
6295         (exception_try_scope_entry, exception_try_scope_exit): Don't
6296         declare.
6297         (struct exception_try_scope): Remove.
6298         (TRY): Don't use exception_try_scope.
6299         (struct gdb_exception): Add constructor, operator=.
6300         <what>: New method.
6301         (struct gdb_exception_RETURN_MASK_ALL)
6302         (struct gdb_exception_RETURN_MASK_ERROR)
6303         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6304         (struct gdb_quit_bad_alloc): Update.
6305         * common/common-exceptions.c (exception_none): Change
6306         initializer.
6307         (struct catcher) <state, exception>: Initialize inline.
6308         <prev>: Remove member.
6309         (current_catcher): Remove.
6310         (catchers): New global.
6311         (exceptions_state_mc_init): Simplify.
6312         (catcher_pop): Remove.
6313         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6314         (try_scope_depth, exception_try_scope_entry)
6315         (exception_try_scope_exit): Remove.
6316         (throw_exception_sjlj): Update.
6317         (exception_messages, exception_messages_size): Remove.
6318         (throw_it): Simplify.
6319         (gdb_exception_sliced_copy): Remove.
6320         (throw_exception_cxx): Update.
6321         * cli/cli-script.c (script_from_file): Update.
6322         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6323         Update.
6324         * ada-valprint.c (ada_val_print): Update.
6325         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6326         (create_excep_cond_exprs): Update.
6327
6328 2019-04-08  Tom Tromey  <tom@tromey.com>
6329
6330         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6331         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6332         (TRY, CATCH, END_CATCH): Remove some definitions.
6333         * common/common-exceptions.c: Don't use GDB_XCPT.
6334         (catcher_list_size): Remove.
6335         (throw_exception, throw_it): Simplify.
6336
6337 2019-04-05  Tom Tromey  <tom@tromey.com>
6338
6339         Revert the header-sorting patch.
6340         * ft32-tdep.c: Revert.
6341         * frv-tdep.c: Revert.
6342         * frv-linux-tdep.c: Revert.
6343         * frame.c: Revert.
6344         * frame-unwind.c: Revert.
6345         * frame-base.c: Revert.
6346         * fork-child.c: Revert.
6347         * findvar.c: Revert.
6348         * findcmd.c: Revert.
6349         * filesystem.c: Revert.
6350         * filename-seen-cache.h: Revert.
6351         * filename-seen-cache.c: Revert.
6352         * fbsd-tdep.c: Revert.
6353         * fbsd-nat.h: Revert.
6354         * fbsd-nat.c: Revert.
6355         * f-valprint.c: Revert.
6356         * f-typeprint.c: Revert.
6357         * f-lang.c: Revert.
6358         * extension.h: Revert.
6359         * extension.c: Revert.
6360         * extension-priv.h: Revert.
6361         * expprint.c: Revert.
6362         * exec.h: Revert.
6363         * exec.c: Revert.
6364         * exceptions.c: Revert.
6365         * event-top.c: Revert.
6366         * event-loop.c: Revert.
6367         * eval.c: Revert.
6368         * elfread.c: Revert.
6369         * dwarf2read.h: Revert.
6370         * dwarf2read.c: Revert.
6371         * dwarf2loc.c: Revert.
6372         * dwarf2expr.h: Revert.
6373         * dwarf2expr.c: Revert.
6374         * dwarf2-frame.c: Revert.
6375         * dwarf2-frame-tailcall.c: Revert.
6376         * dwarf-index-write.h: Revert.
6377         * dwarf-index-write.c: Revert.
6378         * dwarf-index-common.c: Revert.
6379         * dwarf-index-cache.h: Revert.
6380         * dwarf-index-cache.c: Revert.
6381         * dummy-frame.c: Revert.
6382         * dtrace-probe.c: Revert.
6383         * disasm.h: Revert.
6384         * disasm.c: Revert.
6385         * disasm-selftests.c: Revert.
6386         * dictionary.c: Revert.
6387         * dicos-tdep.c: Revert.
6388         * demangle.c: Revert.
6389         * dcache.h: Revert.
6390         * dcache.c: Revert.
6391         * darwin-nat.h: Revert.
6392         * darwin-nat.c: Revert.
6393         * darwin-nat-info.c: Revert.
6394         * d-valprint.c: Revert.
6395         * d-namespace.c: Revert.
6396         * d-lang.c: Revert.
6397         * ctf.c: Revert.
6398         * csky-tdep.c: Revert.
6399         * csky-linux-tdep.c: Revert.
6400         * cris-tdep.c: Revert.
6401         * cris-linux-tdep.c: Revert.
6402         * cp-valprint.c: Revert.
6403         * cp-support.c: Revert.
6404         * cp-namespace.c: Revert.
6405         * cp-abi.c: Revert.
6406         * corelow.c: Revert.
6407         * corefile.c: Revert.
6408         * continuations.c: Revert.
6409         * completer.h: Revert.
6410         * completer.c: Revert.
6411         * complaints.c: Revert.
6412         * coffread.c: Revert.
6413         * coff-pe-read.c: Revert.
6414         * cli-out.h: Revert.
6415         * cli-out.c: Revert.
6416         * charset.c: Revert.
6417         * c-varobj.c: Revert.
6418         * c-valprint.c: Revert.
6419         * c-typeprint.c: Revert.
6420         * c-lang.c: Revert.
6421         * buildsym.c: Revert.
6422         * buildsym-legacy.c: Revert.
6423         * build-id.h: Revert.
6424         * build-id.c: Revert.
6425         * btrace.c: Revert.
6426         * bsd-uthread.c: Revert.
6427         * breakpoint.h: Revert.
6428         * breakpoint.c: Revert.
6429         * break-catch-throw.c: Revert.
6430         * break-catch-syscall.c: Revert.
6431         * break-catch-sig.c: Revert.
6432         * blockframe.c: Revert.
6433         * block.c: Revert.
6434         * bfin-tdep.c: Revert.
6435         * bfin-linux-tdep.c: Revert.
6436         * bfd-target.c: Revert.
6437         * bcache.c: Revert.
6438         * ax-general.c: Revert.
6439         * ax-gdb.h: Revert.
6440         * ax-gdb.c: Revert.
6441         * avr-tdep.c: Revert.
6442         * auxv.c: Revert.
6443         * auto-load.c: Revert.
6444         * arm-wince-tdep.c: Revert.
6445         * arm-tdep.c: Revert.
6446         * arm-symbian-tdep.c: Revert.
6447         * arm-pikeos-tdep.c: Revert.
6448         * arm-obsd-tdep.c: Revert.
6449         * arm-nbsd-tdep.c: Revert.
6450         * arm-nbsd-nat.c: Revert.
6451         * arm-linux-tdep.c: Revert.
6452         * arm-linux-nat.c: Revert.
6453         * arm-fbsd-tdep.c: Revert.
6454         * arm-fbsd-nat.c: Revert.
6455         * arm-bsd-tdep.c: Revert.
6456         * arch-utils.c: Revert.
6457         * arc-tdep.c: Revert.
6458         * arc-newlib-tdep.c: Revert.
6459         * annotate.h: Revert.
6460         * annotate.c: Revert.
6461         * amd64-windows-tdep.c: Revert.
6462         * amd64-windows-nat.c: Revert.
6463         * amd64-tdep.c: Revert.
6464         * amd64-sol2-tdep.c: Revert.
6465         * amd64-obsd-tdep.c: Revert.
6466         * amd64-obsd-nat.c: Revert.
6467         * amd64-nbsd-tdep.c: Revert.
6468         * amd64-nbsd-nat.c: Revert.
6469         * amd64-nat.c: Revert.
6470         * amd64-linux-tdep.c: Revert.
6471         * amd64-linux-nat.c: Revert.
6472         * amd64-fbsd-tdep.c: Revert.
6473         * amd64-fbsd-nat.c: Revert.
6474         * amd64-dicos-tdep.c: Revert.
6475         * amd64-darwin-tdep.c: Revert.
6476         * amd64-bsd-nat.c: Revert.
6477         * alpha-tdep.c: Revert.
6478         * alpha-obsd-tdep.c: Revert.
6479         * alpha-nbsd-tdep.c: Revert.
6480         * alpha-mdebug-tdep.c: Revert.
6481         * alpha-linux-tdep.c: Revert.
6482         * alpha-linux-nat.c: Revert.
6483         * alpha-bsd-tdep.c: Revert.
6484         * alpha-bsd-nat.c: Revert.
6485         * aix-thread.c: Revert.
6486         * agent.c: Revert.
6487         * addrmap.c: Revert.
6488         * ada-varobj.c: Revert.
6489         * ada-valprint.c: Revert.
6490         * ada-typeprint.c: Revert.
6491         * ada-tasks.c: Revert.
6492         * ada-lang.c: Revert.
6493         * aarch64-tdep.c: Revert.
6494         * aarch64-ravenscar-thread.c: Revert.
6495         * aarch64-newlib-tdep.c: Revert.
6496         * aarch64-linux-tdep.c: Revert.
6497         * aarch64-linux-nat.c: Revert.
6498         * aarch64-fbsd-tdep.c: Revert.
6499         * aarch64-fbsd-nat.c: Revert.
6500         * aarch32-linux-nat.c: Revert.
6501
6502 2019-04-05  Tom Tromey  <tom@tromey.com>
6503
6504         * ft32-tdep.c: Sort headers.
6505         * frv-tdep.c: Sort headers.
6506         * frv-linux-tdep.c: Sort headers.
6507         * frame.c: Sort headers.
6508         * frame-unwind.c: Sort headers.
6509         * frame-base.c: Sort headers.
6510         * fork-child.c: Sort headers.
6511         * findvar.c: Sort headers.
6512         * findcmd.c: Sort headers.
6513         * filesystem.c: Sort headers.
6514         * filename-seen-cache.h: Sort headers.
6515         * filename-seen-cache.c: Sort headers.
6516         * fbsd-tdep.c: Sort headers.
6517         * fbsd-nat.h: Sort headers.
6518         * fbsd-nat.c: Sort headers.
6519         * f-valprint.c: Sort headers.
6520         * f-typeprint.c: Sort headers.
6521         * f-lang.c: Sort headers.
6522         * extension.h: Sort headers.
6523         * extension.c: Sort headers.
6524         * extension-priv.h: Sort headers.
6525         * expprint.c: Sort headers.
6526         * exec.h: Sort headers.
6527         * exec.c: Sort headers.
6528         * exceptions.c: Sort headers.
6529         * event-top.c: Sort headers.
6530         * event-loop.c: Sort headers.
6531         * eval.c: Sort headers.
6532         * elfread.c: Sort headers.
6533         * dwarf2read.h: Sort headers.
6534         * dwarf2read.c: Sort headers.
6535         * dwarf2loc.c: Sort headers.
6536         * dwarf2expr.h: Sort headers.
6537         * dwarf2expr.c: Sort headers.
6538         * dwarf2-frame.c: Sort headers.
6539         * dwarf2-frame-tailcall.c: Sort headers.
6540         * dwarf-index-write.h: Sort headers.
6541         * dwarf-index-write.c: Sort headers.
6542         * dwarf-index-common.c: Sort headers.
6543         * dwarf-index-cache.h: Sort headers.
6544         * dwarf-index-cache.c: Sort headers.
6545         * dummy-frame.c: Sort headers.
6546         * dtrace-probe.c: Sort headers.
6547         * disasm.h: Sort headers.
6548         * disasm.c: Sort headers.
6549         * disasm-selftests.c: Sort headers.
6550         * dictionary.c: Sort headers.
6551         * dicos-tdep.c: Sort headers.
6552         * demangle.c: Sort headers.
6553         * dcache.h: Sort headers.
6554         * dcache.c: Sort headers.
6555         * darwin-nat.h: Sort headers.
6556         * darwin-nat.c: Sort headers.
6557         * darwin-nat-info.c: Sort headers.
6558         * d-valprint.c: Sort headers.
6559         * d-namespace.c: Sort headers.
6560         * d-lang.c: Sort headers.
6561         * ctf.c: Sort headers.
6562         * csky-tdep.c: Sort headers.
6563         * csky-linux-tdep.c: Sort headers.
6564         * cris-tdep.c: Sort headers.
6565         * cris-linux-tdep.c: Sort headers.
6566         * cp-valprint.c: Sort headers.
6567         * cp-support.c: Sort headers.
6568         * cp-namespace.c: Sort headers.
6569         * cp-abi.c: Sort headers.
6570         * corelow.c: Sort headers.
6571         * corefile.c: Sort headers.
6572         * continuations.c: Sort headers.
6573         * completer.h: Sort headers.
6574         * completer.c: Sort headers.
6575         * complaints.c: Sort headers.
6576         * coffread.c: Sort headers.
6577         * coff-pe-read.c: Sort headers.
6578         * cli-out.h: Sort headers.
6579         * cli-out.c: Sort headers.
6580         * charset.c: Sort headers.
6581         * c-varobj.c: Sort headers.
6582         * c-valprint.c: Sort headers.
6583         * c-typeprint.c: Sort headers.
6584         * c-lang.c: Sort headers.
6585         * buildsym.c: Sort headers.
6586         * buildsym-legacy.c: Sort headers.
6587         * build-id.h: Sort headers.
6588         * build-id.c: Sort headers.
6589         * btrace.c: Sort headers.
6590         * bsd-uthread.c: Sort headers.
6591         * breakpoint.h: Sort headers.
6592         * breakpoint.c: Sort headers.
6593         * break-catch-throw.c: Sort headers.
6594         * break-catch-syscall.c: Sort headers.
6595         * break-catch-sig.c: Sort headers.
6596         * blockframe.c: Sort headers.
6597         * block.c: Sort headers.
6598         * bfin-tdep.c: Sort headers.
6599         * bfin-linux-tdep.c: Sort headers.
6600         * bfd-target.c: Sort headers.
6601         * bcache.c: Sort headers.
6602         * ax-general.c: Sort headers.
6603         * ax-gdb.h: Sort headers.
6604         * ax-gdb.c: Sort headers.
6605         * avr-tdep.c: Sort headers.
6606         * auxv.c: Sort headers.
6607         * auto-load.c: Sort headers.
6608         * arm-wince-tdep.c: Sort headers.
6609         * arm-tdep.c: Sort headers.
6610         * arm-symbian-tdep.c: Sort headers.
6611         * arm-pikeos-tdep.c: Sort headers.
6612         * arm-obsd-tdep.c: Sort headers.
6613         * arm-nbsd-tdep.c: Sort headers.
6614         * arm-nbsd-nat.c: Sort headers.
6615         * arm-linux-tdep.c: Sort headers.
6616         * arm-linux-nat.c: Sort headers.
6617         * arm-fbsd-tdep.c: Sort headers.
6618         * arm-fbsd-nat.c: Sort headers.
6619         * arm-bsd-tdep.c: Sort headers.
6620         * arch-utils.c: Sort headers.
6621         * arc-tdep.c: Sort headers.
6622         * arc-newlib-tdep.c: Sort headers.
6623         * annotate.h: Sort headers.
6624         * annotate.c: Sort headers.
6625         * amd64-windows-tdep.c: Sort headers.
6626         * amd64-windows-nat.c: Sort headers.
6627         * amd64-tdep.c: Sort headers.
6628         * amd64-sol2-tdep.c: Sort headers.
6629         * amd64-obsd-tdep.c: Sort headers.
6630         * amd64-obsd-nat.c: Sort headers.
6631         * amd64-nbsd-tdep.c: Sort headers.
6632         * amd64-nbsd-nat.c: Sort headers.
6633         * amd64-nat.c: Sort headers.
6634         * amd64-linux-tdep.c: Sort headers.
6635         * amd64-linux-nat.c: Sort headers.
6636         * amd64-fbsd-tdep.c: Sort headers.
6637         * amd64-fbsd-nat.c: Sort headers.
6638         * amd64-dicos-tdep.c: Sort headers.
6639         * amd64-darwin-tdep.c: Sort headers.
6640         * amd64-bsd-nat.c: Sort headers.
6641         * alpha-tdep.c: Sort headers.
6642         * alpha-obsd-tdep.c: Sort headers.
6643         * alpha-nbsd-tdep.c: Sort headers.
6644         * alpha-mdebug-tdep.c: Sort headers.
6645         * alpha-linux-tdep.c: Sort headers.
6646         * alpha-linux-nat.c: Sort headers.
6647         * alpha-bsd-tdep.c: Sort headers.
6648         * alpha-bsd-nat.c: Sort headers.
6649         * aix-thread.c: Sort headers.
6650         * agent.c: Sort headers.
6651         * addrmap.c: Sort headers.
6652         * ada-varobj.c: Sort headers.
6653         * ada-valprint.c: Sort headers.
6654         * ada-typeprint.c: Sort headers.
6655         * ada-tasks.c: Sort headers.
6656         * ada-lang.c: Sort headers.
6657         * aarch64-tdep.c: Sort headers.
6658         * aarch64-ravenscar-thread.c: Sort headers.
6659         * aarch64-newlib-tdep.c: Sort headers.
6660         * aarch64-linux-tdep.c: Sort headers.
6661         * aarch64-linux-nat.c: Sort headers.
6662         * aarch64-fbsd-tdep.c: Sort headers.
6663         * aarch64-fbsd-nat.c: Sort headers.
6664         * aarch32-linux-nat.c: Sort headers.
6665
6666 2019-04-04  Tom Tromey  <tom@tromey.com>
6667
6668         * varobj.c (varobj_create): Update.
6669         * rust-exp.y (struct rust_parser) <update_innermost_block,
6670         lookup_symbol>: New methods.
6671         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6672         Rename.
6673         (rust_parser::rust_lookup_type)
6674         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6675         * printcmd.c (display_command, do_one_display): Update.
6676         * parser-defs.h (struct parser_state) <parser_state>: Add
6677         "tracker" parameter.
6678         (block_tracker): New member.
6679         (class innermost_block_tracker) <innermost_block_tracker>: Add
6680         "types" parameter.
6681         <reset>: Remove method.
6682         (innermost_block): Don't declare.
6683         (null_post_parser): Update.
6684         * parse.c (innermost_block): Remove global.
6685         (write_dollar_variable): Update.
6686         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6687         Remove "tracker_types" parameter.
6688         (parse_expression): Add "tracker" parameter.
6689         (parse_expression_for_completion): Update.
6690         (null_post_parser): Add "tracker" parameter.
6691         * p-exp.y: Update rules.
6692         * m2-exp.y: Update rules.
6693         * language.h (struct language_defn) <la_post_parser>: Add
6694         "tracker" parameter.
6695         * go-exp.y: Update rules.
6696         * f-exp.y: Update rules.
6697         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6698         parameter.
6699         * d-exp.y: Update rules.
6700         * c-exp.y: Update rules.
6701         * breakpoint.c (set_breakpoint_condition): Create an
6702         innermost_block_tracker.
6703         (watch_command_1): Likewise.
6704         * ada-lang.c (resolve): Add "tracker" parameter.
6705         (resolve_subexp): Likewise.
6706         * ada-exp.y (write_var_from_sym): Update.
6707
6708 2019-04-04  Tom Tromey  <tom@tromey.com>
6709
6710         * type-stack.h: New file.
6711         * type-stack.c: New file.
6712         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6713         type-stack.h.
6714         (insert_into_type_stack, insert_type, push_type, push_type_int)
6715         (insert_type_address_space, pop_type, pop_type_int)
6716         (pop_typelist, pop_type_stack, append_type_stack)
6717         (push_type_stack, get_type_stack, push_typelist)
6718         (follow_type_instance_flags, follow_types): Don't declare.
6719         * parse.c (type_stack): Remove global.
6720         (parse_exp_in_context): Update.
6721         (insert_into_type_stack, insert_type, push_type, push_type_int)
6722         (insert_type_address_space, pop_type, pop_type_int)
6723         (pop_typelist, pop_type_stack, append_type_stack)
6724         (push_type_stack, get_type_stack, push_typelist)
6725         (follow_type_instance_flags, follow_types): Remove (moved to
6726         type-stack.c).
6727         * f-exp.y (type_stack): New global.
6728         Update rules.
6729         (push_kind_type, f_parse): Update.
6730         * d-exp.y (type_stack): New global.
6731         Update rules.
6732         (d_parse): Update.
6733         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6734         Update rules.
6735         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6736         (HFILES_NO_SRCDIR): Add type-stack.h.
6737
6738 2019-04-04  Tom Tromey  <tom@tromey.com>
6739
6740         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6741         (rust_parser::convert_ast_to_expression, rust_parse)
6742         (rust_lex_test_completion, rust_lex_tests): Update.
6743         * parser-defs.h (struct expr_completion_state): New.
6744         (struct parser_state) <parser_state>: Add completion parameter.
6745         <mark_struct_expression, mark_completion_tag>: New methods.
6746         <parse_completion, m_completion_state>: New members.
6747         (prefixify_expression, null_post_parser): Update.
6748         (mark_struct_expression, mark_completion_tag): Don't declare.
6749         * parse.c (parse_completion, expout_last_struct)
6750         (expout_tag_completion_type, expout_completion_name): Remove
6751         globals.
6752         (parser_state::mark_struct_expression)
6753         (parser_state::mark_completion_tag): Now methods.
6754         (prefixify_expression): Add last_struct parameter.
6755         (prefixify_subexp): Likewise.
6756         (parse_exp_1): Update.
6757         (parse_exp_in_context): Add cstate parameter.  Update.
6758         (parse_expression_for_completion): Create an
6759         expr_completion_state.
6760         (null_post_parser): Add "completion" parameter.
6761         * p-exp.y: Update rules.
6762         (yylex): Update.
6763         * language.h (struct language_defn) <la_post_parser>: Add
6764         "completing" parameter.
6765         * go-exp.y: Update rules.
6766         (lex_one_token): Update.
6767         * expression.h (parse_completion): Don't declare.
6768         * d-exp.y: Update rules.
6769         (lex_one_token): Update rules.
6770         * c-exp.y: Update rules.
6771         (lex_one_token): Update.
6772         * ada-lang.c (resolve): Add "parse_completion" parameter.
6773         (resolve_subexp): Likewise.
6774         (ada_resolve_function): Likewise.
6775
6776 2019-04-04  Tom Tromey  <tom@tromey.com>
6777
6778         * parser-defs.h (struct parser_state) <start_arglist,
6779         end_arglist>: New methods.
6780         <arglist_len, m_funcall_chain>: New members.
6781         (arglist_len, start_arglist, end_arglist): Don't declare.
6782         * parse.c (arglist_len, funcall_chain): Remove global.
6783         (start_arglist, end_arglist): Remove functions.
6784         (parse_exp_in_context): Update.
6785         * p-exp.y: Update rules.
6786         * m2-exp.y: Update rules.
6787         * go-exp.y: Update rules.
6788         * f-exp.y: Update rules.
6789         * d-exp.y: Update rules.
6790         * c-exp.y: Update rules.
6791
6792 2019-04-04  Tom Tromey  <tom@tromey.com>
6793
6794         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6795         lex_operator, push_back>: New methods.
6796         Update all rules.
6797         (rust_parser::lex_hex, lex_escape): Rename and update.
6798         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6799         (rust_parser::lex_operator): Rename and update.
6800         (rust_parser::lex_number, rustyylex, rustyyerror)
6801         (rust_lex_test_init, rust_lex_test_sequence)
6802         (rust_lex_test_push_back, rust_lex_tests): Update.
6803         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6804         parameter.
6805         <lexptr, prev_lexptr>: New members.
6806         (lexptr, prev_lexptr): Don't declare.
6807         * parse.c (lexptr, prev_lexptr): Remove globals.
6808         (parse_exp_in_context): Update.
6809         * p-exp.y (yylex, yyerror): Update.
6810         * m2-exp.y (parse_number, yylex, yyerror): Update.
6811         * go-exp.y (lex_one_token, yyerror): Update.
6812         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6813         * d-exp.y (lex_one_token, yyerror): Update.
6814         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6815         (lex_one_token, yyerror): Update.
6816         * ada-lex.l (YY_INPUT): Update.
6817         (rewind_to_char): Update.
6818         * ada-exp.y (yyerror): Update.
6819
6820 2019-04-04  Tom Tromey  <tom@tromey.com>
6821
6822         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6823         * parser-defs.h (struct parser_state) <parser_state>: Add new
6824         parameter.
6825         <comma_terminates>: New member.
6826         (comma_terminates): Don't declare global.
6827         * parse.c (comma_terminates): Remove global.
6828         (parse_exp_in_context): Update.
6829         * p-exp.y (yylex): Update.
6830         * m2-exp.y (yylex): Update.
6831         * go-exp.y (lex_one_token): Update.
6832         * f-exp.y (yylex): Update.
6833         * d-exp.y (lex_one_token): Update.
6834         * c-exp.y (lex_one_token): Update.
6835         * ada-lex.l: Update.
6836
6837 2019-04-04  Tom Tromey  <tom@tromey.com>
6838
6839         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6840         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6841         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6842         * parser-defs.h (paren_depth): Don't declare.
6843         * parse.c (paren_depth): Remove global.
6844         (parse_exp_in_context): Update.
6845         * p-exp.y (paren_depth): New global.
6846         (pascal_parse): Initialize it.
6847         * m2-exp.y (paren_depth): New global.
6848         (m2_parse): Initialize it.
6849         * go-exp.y (paren_depth): New global.
6850         (go_parse): Initialize it.
6851         * f-exp.y (paren_depth): New global.
6852         (f_parse): Initialize it.
6853         * d-exp.y (paren_depth): New global.
6854         (d_parse): Initialize it.
6855         * c-exp.y (paren_depth): New global.
6856         (c_parse): Initialize it.
6857         * ada-lex.l (paren_depth): New global.
6858         (lexer_init): Initialize it.
6859
6860 2019-04-04  Tom Tromey  <tom@tromey.com>
6861
6862         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6863         (rust_parser::convert_ast_to_type)
6864         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6865         * parser-defs.h (struct parser_state) <parser_state>: Add
6866         parameters.  Initialize new members.
6867         <expression_context_block, expression_context_pc>: New members.
6868         * parse.c (expression_context_block, expression_context_pc):
6869         Remove globals.
6870         (parse_exp_in_context): Update.
6871         * p-exp.y: Update all rules.
6872         (yylex): Update.
6873         * m2-exp.y: Update all rules.
6874         (yylex): Update.
6875         * go-exp.y (yylex): Update.
6876         * f-exp.y (yylex): Update.
6877         * d-exp.y: Update all rules.
6878         (yylex): Update.
6879         * c-exp.y: Update all rules.
6880         (lex_one_token, classify_name, yylex, c_parse): Update.
6881         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6882
6883 2019-04-04  Tom Tromey  <tom@tromey.com>
6884
6885         * gdbarch.h, gdbarch.c: Rebuild.
6886         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6887         * stap-probe.h:
6888         (struct stap_parse_info): Replace "parser_state" with
6889         "expr_builder".
6890         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6891         (parser_state): New class.
6892         * parse.c (expr_builder): Rename.
6893         (expr_builder::release): Rename.
6894         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6895         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6896         (write_exp_elt_longcst, write_exp_elt_floatcst)
6897         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6898         (write_exp_string_vector, write_exp_bitstring)
6899         (write_exp_msymbol, mark_struct_expression)
6900         (write_dollar_variable)
6901         (insert_type_address_space, increase_expout_size): Replace
6902         "parser_state" with "expr_builder".
6903         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6904         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6905         "parser_state" with "expr_builder".
6906
6907 2019-04-04  Tom Tromey  <tom@tromey.com>
6908
6909         * rust-exp.y: Replace "parse_language" with method call.
6910         * p-exp.y:
6911         (yylex): Replace "parse_language" with method call.
6912         * m2-exp.y:
6913         (yylex): Replace "parse_language" with method call.
6914         * go-exp.y (classify_name): Replace "parse_language" with method
6915         call.
6916         * f-exp.y (yylex): Replace "parse_language" with method call.
6917         * d-exp.y (lex_one_token): Replace "parse_language" with method
6918         call.
6919         * c-exp.y:
6920         (lex_one_token, classify_name, yylex): Replace "parse_language"
6921         with method call.
6922         * ada-exp.y (find_primitive_type, type_char)
6923         (type_system_address): Replace "parse_language" with method call.
6924
6925 2019-04-04  Tom Tromey  <tom@tromey.com>
6926
6927         * rust-exp.y: Replace "parse_gdbarch" with method call.
6928         * parse.c (write_dollar_variable, insert_type_address_space):
6929         Replace "parse_gdbarch" with method call.
6930         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6931         call.
6932         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6933         call.
6934         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6935         "parse_gdbarch" with method call.
6936         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6937         with method call.
6938         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6939         "parse_gdbarch" with method call.
6940         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6941         "parse_gdbarch" with method call.
6942         * c-exp.y (parse_type, parse_number, classify_name): Replace
6943         "parse_gdbarch" with method call.
6944         * ada-lex.l: Replace "parse_gdbarch" with method call.
6945         * ada-exp.y (parse_type, find_primitive_type, type_char)
6946         (type_system_address): Replace "parse_gdbarch" with method call.
6947
6948 2019-04-04  Tom Tromey  <tom@tromey.com>
6949
6950         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6951         * stap-probe.c (stap_parse_argument): Update.
6952         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6953         initial_size parameter.
6954         * rust-exp.y (rust_lex_tests): Update.
6955         * parse.c (parser_state): Update.
6956         (parse_exp_in_context): Update.
6957         * parser-defs.h (struct parser_state) <parser_state>: Remove
6958         "initial_size" parameter.
6959
6960 2019-04-04  Tom Tromey  <tom@tromey.com>
6961
6962         * parser-defs.h (increase_expout_size): Don't declare.
6963         * parse.c (increase_expout_size): Now static.
6964
6965 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6966
6967         * gnu-nat.c (gnu_nat_target::wait): Fix
6968         target_waitstatus_to_string call.
6969
6970 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6971
6972         * eval.c (evaluate_subexp_standard): Handle internal functions
6973         during Fortran function call handling.
6974
6975 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6976
6977         * NEWS: Mention new internal functions.
6978         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6979         (read_base_type): Use dwarf2_init_complex_target_type.
6980         * value.c (creal_internal_fn): New function.
6981         (cimag_internal_fn): New function.
6982         (_initialize_values): Register new internal functions.
6983
6984 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6985
6986         * infrun.c (stop_all_threads): If debug_infrun, always
6987         trace the wait status after wait_one, using
6988         target_waitstatus_to_string and target_pid_to_str.
6989         (handle_inferior_event): Replace various trace of
6990         wait status kind by a single trace.
6991         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6992         wait status kind image by target_waitstatus_to_string.
6993         * target/waitstatus.c (target_waitstatus_to_string): Fix
6994         obsolete comment.
6995
6996 2019-04-01  Tom Tromey  <tromey@adacore.com>
6997
6998         PR symtab/23331:
6999         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7000
7001 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7002             Pedro Alves  <palves@redhat.com>
7003
7004         * top.c (quit_force): Call 'finalize_values'.
7005         * value.c (finalize_values): New function.
7006         * value.h (finalize_values): Declare.
7007
7008 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7009
7010         * NEWS: Announce $_gdb_major and $_gdb_minor.
7011
7012         * top.c (init_gdb_version_vars): New function.
7013         (gdb_init): Call init_gdb_version_vars.
7014
7015 2019-03-29  Tom Tromey  <tromey@adacore.com>
7016
7017         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7018         help text.  Remove dead code.
7019
7020 2019-03-29  Keith Seitz  <keiths@redhat.com>
7021
7022         From Siddhesh Poyarekar:
7023         * f-lang.h (f77_get_upperbound): Return LONGEST.
7024         (f77_get_lowerbound): Likewise.
7025         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7026         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7027         print them.
7028         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7029         plongest to format print it.
7030         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7031         (f77_get_upperbound): Likewise.
7032         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7033         LOWER_BOUND to LONGEST.
7034         (f77_create_arrayprint_offset_tbl): Likewise.
7035
7036 2019-03-29  Keith Seitz  <keiths@redhat.com>
7037
7038         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7039         %s/pulongest for TYPE_LENGTH instead of %d in format
7040         strings.
7041         * ada-typerint.c (ada_print_type): Likewise.
7042         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7043         * compile/compile-c-support.c (generate_register_struct): Likewise.
7044         * gdbtypes.c (recursive_dump_type): Likewise.
7045         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7046         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7047         instead of %d in format strings.
7048         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7049         to std::min to ULONGEST.
7050         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7051         instead of %d in format strings.
7052         * tracepoint.c (info_scope_command): Likewise.
7053         * typeprint.c (print_offset_data::update)
7054         (print_offset_data::finish): Likewise.
7055         * xtensa-tdep.c (xtensa_store_return_value)
7056         (xtensa_push_dummy_call): Likewise.
7057
7058 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7059
7060         * windows-nat.c (display_selector): Fixed format specifications
7061         for 64-bit Cygwin.
7062
7063 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7064
7065         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7066
7067 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7068
7069         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7070         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7071         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7072         (nios2_linux_init_abi): Install it.
7073
7074 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7075
7076         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7077
7078 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7079
7080         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7081
7082 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7083             Tom Tromey  <tromey@adacore.com>
7084
7085         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7086
7087 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7088
7089         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7090         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7091         method to compute the bounds of range types. Also print "[evaluated]"
7092         if the bounds' values come from a dynamic evaluation.
7093
7094 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7095
7096         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7097         whitespace when pretty printing is on.
7098
7099 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7100
7101         * ppc-linux-nat.c: Add include.
7102
7103 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7104
7105         * NEWS: Mention AArch64 Pointer Authentication.
7106
7107 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7108
7109         * arm-linux-nat.c: Add include.
7110
7111 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7112
7113         * source-cache.c (source_cache::get_source_lines): Re-read
7114         fullname after calling open_source_file.
7115
7116 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7117
7118         * NEWS: Mention TLS support for FreeBSD.
7119
7120 2019-03-25  Tom Tromey  <tromey@adacore.com>
7121
7122         * minsyms.c (BUNCH_SIZE): Update comment.
7123         (~minimal_symbol_reader): Remove old comment.
7124         (compact_minimal_symbols): Update comment.
7125         (minimal_symbol_reader::install): Remove old comment.  Update
7126         other comments.
7127
7128 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7129
7130         * s390-linux-nat.c: Add include.
7131
7132 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7133
7134         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7135         Call linux_get_hwcap.
7136         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7137         Likewise.
7138         (aarch64_linux_get_hwcap): Remove function.
7139         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7140         declaration.
7141         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7142         linux_get_hwcap.
7143         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7144         * linux-tdep.c (linux_get_hwcap): Add function.
7145         (linux_get_hwcap2): Likewise.
7146         * linux-tdep.h (linux_get_hwcap): Add declaration.
7147         (linux_get_hwcap2): Likewise.
7148         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7149         (ppc_linux_get_hwcap2): Likewise.
7150         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7151         linux_get_hwcap.
7152         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7153         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7154         (ppc_linux_nat_target::read_description): Likewise.
7155         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7156         * s390-linux-nat.c: Likewise.
7157         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7158
7159 2019-03-24  Tom Tromey  <tom@tromey.com>
7160
7161         * ada-lang.c (standard_lookup): Simplify initialization.
7162         (ada_lookup_symbol_nonlocal): Simplify return.
7163         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7164         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7165         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7166         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7167         initialization.
7168         * solib.c (solib_global_lookup): Simplify.
7169         * symtab.c (null_block_symbol): Remove.
7170         (symbol_cache_lookup): Simplify returns.
7171         (lookup_language_this): Simplify returns.
7172         (lookup_symbol_aux): Simplify return.
7173         (lookup_local_symbol): Simplify returns.
7174         (lookup_global_symbol_from_objfile): Simplify return.
7175         (lookup_symbol_in_objfile_symtabs)
7176         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7177         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7178         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7179         * cp-namespace.c (cp_lookup_bare_symbol)
7180         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7181         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7182         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7183         (cp_lookup_symbol_via_imports): Simplify initialization.
7184         (find_symbol_in_baseclass): Likewise.
7185         * symtab.h (null_block_symbol): Remove.
7186         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7187         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7188         (d_lookup_symbol_module): Likewise.
7189         (find_symbol_in_baseclass): Simplify initialization.
7190
7191 2019-03-24  Tom Tromey  <tom@tromey.com>
7192
7193         * expression.h: Don't include symtab.h.
7194         (struct block): Forward declare.
7195
7196 2019-03-24  Tom Tromey  <tom@tromey.com>
7197
7198         * c-exp.y (typebase): Remove casts.
7199         * gdbtypes.c (lookup_unsigned_typename, )
7200         (lookup_signed_typename): Remove cast.
7201         * eval.c (parse_to_comma_and_eval): Remove cast.
7202         * parse.c (write_dollar_variable): Remove cast.
7203         * block.h (struct block) <superblock>: Now const.
7204         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7205         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7206         (map_block): Make "block" const.
7207         * symfile.h (struct quick_symbol_functions)
7208         <map_matching_symbols>: Constify block argument to "callback".
7209         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7210         const.
7211         (find_pc_sect_compunit_symtab): Make "b" const.
7212         (find_symbol_at_address): Likewise.
7213         (search_symbols): Likewise.
7214         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7215         (dw2_debug_names_lookup_symbol): Likewise.
7216         (dw2_map_matching_symbols): Update.
7217         * p-valprint.c (pascal_val_print): Remove "block".
7218         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7219         (aux_add_nonlocal_symbols): Make "block" const.
7220         (resolve_subexp): Remove cast.
7221         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7222         const.
7223         (iterate_over_file_blocks): Likewise.
7224         * f-exp.y (%union) <bval>: Remove.
7225         * coffread.c (patch_opaque_types): Make "b" const.
7226         * spu-tdep.c (spu_catch_start): Make "block" const.
7227         * c-valprint.c (print_unpacked_pointer): Remove "block".
7228         * symmisc.c (dump_symtab_1): Make "b" const.
7229         (block_depth): Make "block" const.
7230         * d-exp.y (%union) <bval>: Remove.
7231         * cp-support.h (cp_lookup_rtti_type): Update.
7232         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7233         * psymtab.c (psym_lookup_symbol): Make "block" const.
7234         (maintenance_check_psymtabs): Make "b" const.
7235         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7236         (enumerate_locals, enumerate_args): Update.
7237         * python/py-symtab.c (stpy_global_block): Make "block" const.
7238         (stpy_static_block): Likewise.
7239         * inline-frame.c (block_starting_point_at): Make "new_block"
7240         const.
7241         * block.c (find_block_in_blockvector): Make return type const.
7242         (blockvector_for_pc_sect): Make "b" const.
7243         (find_block_in_blockvector): Make "b" const.
7244
7245 2019-03-23  Tom Tromey  <tom@tromey.com>
7246
7247         * varobj.c (varobj_create): Update.
7248         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7249         * printcmd.c (display_command, do_one_display): Don't reset
7250         innermost_block.
7251         * parser-defs.h (enum innermost_block_tracker_type): Move to
7252         expression.h.
7253         (innermost_block): Update comment.
7254         * parse.c (parse_exp_1): Add tracker_types parameter.
7255         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7256         tracker_types parameter.  Reset innermost_block.
7257         (parse_exp_in_context): Remove.
7258         (parse_expression_for_completion): Update.
7259         * objfiles.c (~objfile): Don't reset expression_context_block or
7260         innermost_block.
7261         * expression.h (enum innermost_block_tracker_type): Move from
7262         parser-defs.h.
7263         (parse_exp_1): Add tracker_types parameter.
7264         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7265         reset innermost_block.
7266
7267 2019-03-23  Tom Tromey  <tom@tromey.com>
7268
7269         * objfiles.h: Include bcache.h.
7270
7271 2019-03-23  Tom Tromey  <tom@tromey.com>
7272
7273         * linespec.c (get_current_search_block): Use
7274         scoped_restore_current_language.
7275         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7276
7277 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7278             Jiong Wang  <jiong.wang@arm.com>
7279
7280         * aarch64-linux-tdep.c
7281         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7282         section.
7283         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7284
7285 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7286             Jiong Wang  <jiong.wang@arm.com>
7287
7288         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7289         instructions.
7290         (aarch64_analyze_prologue_test): Add PACIASP test.
7291         (aarch64_prologue_prev_register): Unmask PC value.
7292
7293 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7294             Jiong Wang  <jiong.wang@arm.com>
7295
7296         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7297         (aarch64_dwarf2_prev_register): Unmask PC value.
7298         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7299         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7300         DW_CFA_AARCH64_negate_ra_state.
7301         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7302
7303 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7304             Jiong Wang  <jiong.wang@arm.com>
7305
7306         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7307         registers.
7308         (aarch64_pseudo_register_name): Likewise.
7309         (aarch64_pseudo_register_type): Likewise.
7310         (aarch64_pseudo_register_reggroup_p): Likewise.
7311         (aarch64_gdbarch_init): Add pauth registers.
7312         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7313         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7314         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7315         (struct gdbarch_tdep): Add regnum for ra_state.
7316
7317 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7318             Jiong Wang  <jiong.wang@arm.com>
7319
7320         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7321
7322 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7323             Jiong Wang  <jiong.wang@arm.com>
7324
7325         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7326         function.
7327         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7328         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7329         (aarch64_gdbarch_init): Add puth registers.
7330         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7331         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7332         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7333
7334 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7335             Jiong Wang  <jiong.wang@arm.com>
7336
7337         * aarch64-linux-nat.c
7338         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7339         * aarch64-linux-tdep.c
7340         (aarch64_linux_core_read_description): Likewise.
7341         (aarch64_linux_get_hwcap): New function.
7342         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7343         (aarch64_linux_get_hwcap): New declaration.
7344
7345 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7346             Jiong Wang  <jiong.wang@arm.com>
7347
7348         * aarch64-linux-nat.c
7349         (aarch64_linux_nat_target::read_description): Add pauth param.
7350         * aarch64-linux-tdep.c
7351         (aarch64_linux_core_read_description): Likewise.
7352         * aarch64-tdep.c (struct target_desc): Add in pauth.
7353         (aarch64_read_description): Add pauth param.
7354         (aarch64_gdbarch_init): Likewise.
7355         * aarch64-tdep.h (aarch64_read_description): Likewise.
7356         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7357         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7358         * features/Makefile: Add new files.
7359         * features/aarch64-pauth.c: New file.
7360         * features/aarch64-pauth.xml: New file.
7361
7362 2019-03-20  Tom Tromey  <tromey@adacore.com>
7363
7364         * infrun.c (handle_inferior_event): Rename from
7365         handle_inferior_event_1.  Create a scoped_value_mark.
7366         (handle_inferior_event): Remove.
7367
7368 2019-03-19  Tom Tromey  <tromey@adacore.com>
7369
7370         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7371         * infrun.h (print_stop_event): Add "displays" parameter.
7372         * infrun.c (print_stop_event): Add "displays" parameter.
7373
7374 2019-03-19  Pedro Alves  <palves@redhat.com>
7375
7376         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7377         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7378         to -1.  Fix TABs vs spaces.
7379         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7380         * tui/tui-out.h (tui_ui_out) Add intro comments.
7381         <m_line, m_start_of_line>: In-class initialize, and add describing
7382         comment.
7383
7384 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7385
7386         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7387         variable names.
7388         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7389
7390 2019-03-18  Pedro Alves  <palves@redhat.com>
7391             Eli Zaretskii <eliz@gnu.org>
7392
7393         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7394         m_line and m_start_of_line.
7395
7396 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7397
7398         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7399         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7400         it returns a newline.  This fixes a regression in TU mode, whereby
7401         the next line is output on the same screen line as the user input.
7402
7403 2019-03-18  Tom Tromey  <tromey@adacore.com>
7404
7405         * minsyms.c (minimal_symbol_reader::install): Remove call to
7406         obstack_blank.
7407
7408 2019-03-18  Pedro Alves  <palves@redhat.com>
7409
7410         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7411         New globals.
7412         (apply_style): New, factored out from ...
7413         (apply_ansi_escape): ... this.  Handle reverse video mode.
7414         (tui_set_reverse_mode): New function.
7415         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7416         * tui/tui-winsource.c (tui_show_source_line): Use
7417         tui_set_reverse_mode instead of setting A_STANDOUT.
7418         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7419         New setter methods.
7420
7421 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7422
7423         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7424         Handle tabs.
7425
7426 2019-03-18  Tom Tromey  <tromey@adacore.com>
7427
7428         * ada-lang.c (empty_array): Add "high" parameter.
7429         (ada_evaluate_subexp): Update.
7430
7431 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7432
7433         * unittests/string_view-selftests.c: Define
7434         _initialize_string_view_selftests unconditionally.
7435
7436 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7437
7438         PR gdb/24350
7439         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7440
7441 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7442
7443         PR gdb/24351
7444         * windows-nat.c (display_selector): Fix format specifiers.
7445
7446 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7447
7448         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7449         tui_refill_source_window instead of tui_refresh_win, to update the
7450         current execution line.  This fixes redisplay of the current line
7451         when stepping through the code with "next" or "step".
7452
7453 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7454
7455         * source-cache.c (source_cache::get_source_lines): Call
7456         find_source_lines to initialize s->nlines.  This fixes vertical
7457         scrolling of TUI source window when the DOWN arrow is pressed.
7458
7459 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7460
7461         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7462         linux-thread-db.c (_initialize_thread_db): Likewise.
7463
7464 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7465
7466         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7467         wclrtoeol in tui_show_source_line".  This reverts changes made in
7468         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7469
7470 2019-03-15  Tom Tromey  <tom@tromey.com>
7471
7472         * symtab.h (struct minimal_symbol): Derive from
7473         general_symbol_info.
7474         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7475         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7476         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7477         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7478         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7479         (MSYMBOL_SEARCH_NAME): Update.
7480         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7481         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7482         * minsyms.c (minimal_symbol_reader::record_full): Update.
7483
7484 2019-03-15  Tom Tromey  <tom@tromey.com>
7485
7486         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7487
7488 2019-03-15  Tom Tromey  <tom@tromey.com>
7489
7490         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7491         unique_xmalloc_ptr.
7492         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7493         Update.
7494         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7495         (build_minimal_symbol_hash_tables)
7496         (minimal_symbol_reader::install): Update.
7497
7498 2019-03-15  Tom Tromey  <tom@tromey.com>
7499
7500         * symtab.c (create_demangled_names_hash): Update.
7501         (symbol_set_names): Update.
7502         * objfiles.h (struct objfile_per_bfd_storage)
7503         <demangled_names_hash>: Now an htab_up.
7504         * objfiles.c (objfile_per_bfd_storage): Simplify.
7505
7506 2019-03-15  Tom Tromey  <tom@tromey.com>
7507
7508         * objfiles.h (struct objfile_per_bfd_storage): Declare
7509         destructor.
7510         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7511         New.
7512         (get_objfile_bfd_data): Use new.  Don't initialize
7513         language_of_main.
7514         (free_objfile_per_bfd_storage): Remove.
7515         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7516
7517 2019-03-15  Tom Tromey  <tom@tromey.com>
7518
7519         * symfile.c (reread_symbols): Update.
7520         * objfiles.c (objfile::objfile): Update.
7521         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7522         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7523         comment.
7524         (minimal_symbol_reader::install): Update.
7525         (terminate_minimal_symbol_table): Remove.
7526         * jit.c (jit_object_close_impl): Update.
7527
7528 2019-03-15  Tom Tromey  <tom@tromey.com>
7529
7530         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7531         initializations.
7532
7533 2019-03-15  Tom Tromey  <tom@tromey.com>
7534
7535         * objfiles.h (struct objfile_per_bfd_storage)
7536         <demangled_hash_languages>: Now a bitset.
7537         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7538         (lookup_minimal_symbol): Update.
7539
7540 2019-03-15  Tom Tromey  <tom@tromey.com>
7541
7542         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7543         Don't return the symbol.
7544         * coffread.c (record_minimal_symbol): Use record_full.
7545
7546 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7547
7548         The MS-Windows port of ncurses fails to switch to a color pair if
7549         one or both of the colors are the implicit default colors.  This
7550         change records the default colors when TUI is initialized, and
7551         then specifies them explicitly when a color pair uses the default
7552         colors.  This allows color styling in TUI mode on MS-Windows.
7553
7554         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7555         ncurses_norm_attr.
7556         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7557         colors in ncurses_norm_attr.
7558         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7559         "none", replace it with the default color recorded in
7560         ncurses_norm_attr.
7561
7562 2019-03-14  Tom Tromey  <tromey@adacore.com>
7563
7564         * source-cache.h (class source_cache) <get_source_lines>: Return
7565         std::string.
7566         * source-cache.c (source_cache::extract_lines): Handle case where
7567         first_pos==npos.  Return std::string.
7568         (source_cache::get_source_lines): Update.
7569
7570 2019-03-14  Tom Tromey  <tromey@adacore.com>
7571
7572         * NEWS: Add item for "style sources" commands.
7573         * source-cache.c (source_cache::get_source_lines): Check
7574         source_styling.
7575         * cli/cli-style.c (source_styling): New global.
7576         (_initialize_cli_style): Add "style sources" commands.
7577         (show_style_sources): New function.
7578         * cli/cli-style.h (source_styling): Declare.
7579
7580 2019-03-14  Pedro Alves  <palves@redhat.com>
7581             Tom Tromey  <tromey@adacore.com>
7582
7583         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7584         * tui/tui-winsource.c (tui_refill_source_window): New function,
7585         from...
7586         (tui_horizontal_source_scroll): ... here.  Move some logic.
7587         * cli/cli-style.c (set_style_enabled): Notify new observable.
7588         * tui/tui-hooks.c (tui_redisplay_source): New function.
7589         (tui_attach_detach_observers): Attach or detach
7590         tui_redisplay_source.
7591         * observable.h (source_styling_changed): New observable.
7592         * observable.c: Define source_styling_changed observable.
7593
7594 2019-03-13  Tom Tromey  <tromey@adacore.com>
7595
7596         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7597         (i386_gnu_nat_target::store_registers): Update.
7598         * target-debug.h (target_debug_print_std_string): New macro.
7599         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7600         * windows-tdep.c (display_one_tib): Update.
7601         * tui/tui-stack.c (tui_make_status_line): Update.
7602         * top.c (print_inferior_quit_action): Update.
7603         * thread.c (thr_try_catch_cmd): Update.
7604         (add_thread_with_info): Update.
7605         (thread_target_id_str): Update.
7606         (thr_try_catch_cmd): Update.
7607         (thread_command): Update.
7608         (thread_find_command): Update.
7609         * record-btrace.c (record_btrace_target::info_record)
7610         (record_btrace_resume_thread, record_btrace_target::resume)
7611         (record_btrace_cancel_resume, record_btrace_step_thread)
7612         (record_btrace_target::wait, record_btrace_target::wait)
7613         (record_btrace_target::wait, record_btrace_target::stop): Update.
7614         * progspace.c (print_program_space): Update.
7615         * process-stratum-target.c
7616         (process_stratum_target::thread_address_space): Update.
7617         * linux-fork.c (linux_fork_mourn_inferior)
7618         (detach_checkpoint_command, info_checkpoints_command)
7619         (linux_fork_context): Update.
7620         (linux_fork_detach): Update.
7621         (class scoped_switch_fork_info): Update.
7622         (delete_checkpoint_command): Update.
7623         * infrun.c (follow_fork_inferior): Update.
7624         (follow_fork_inferior): Update.
7625         (proceed_after_vfork_done): Update.
7626         (handle_vfork_child_exec_or_exit): Update.
7627         (follow_exec): Update.
7628         (displaced_step_prepare_throw): Update.
7629         (displaced_step_restore): Update.
7630         (start_step_over): Update.
7631         (resume_1): Update.
7632         (clear_proceed_status_thread): Update.
7633         (proceed): Update.
7634         (print_target_wait_results): Update.
7635         (do_target_wait): Update.
7636         (context_switch): Update.
7637         (stop_all_threads): Update.
7638         (restart_threads): Update.
7639         (finish_step_over): Update.
7640         (handle_signal_stop): Update.
7641         (switch_back_to_stepped_thread): Update.
7642         (keep_going_pass_signal): Update.
7643         (print_exited_reason): Update.
7644         (normal_stop): Update.
7645         * inferior.c (inferior_pid_to_str): Change return type.
7646         (print_selected_inferior): Update.
7647         (add_inferior): Update.
7648         (detach_inferior): Update.
7649         * dummy-frame.c (fprint_dummy_frames): Update.
7650         * dcache.c (dcache_info_1): Update.
7651         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7652         (btrace_fetch, btrace_clear): Update.
7653         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7654         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7655         type.
7656         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7657         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7658         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7659         * gdbarch.c, gdbarch.h: Rebuild.
7660         * gdbarch.sh (core_pid_to_str): Change return type.
7661         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7662         return type.
7663         (windows_nat_target::pid_to_str): Change return type.
7664         (windows_delete_thread): Update.
7665         (windows_nat_target::attach): Update.
7666         (windows_nat_target::files_info): Update.
7667         * target-delegates.c: Rebuild.
7668         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7669         return type.
7670         (sol_thread_target::pid_to_str): Change return type.
7671         * remote.c (class remote_target) <pid_to_str>: Change return
7672         type.
7673         (remote_target::pid_to_str): Change return type.
7674         (extended_remote_target::attach, remote_target::remote_stop_ns)
7675         (remote_target::remote_notif_remove_queued_reply)
7676         (remote_target::push_stop_reply, remote_target::disable_btrace):
7677         Update.
7678         (extended_remote_target::attach): Update.
7679         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7680         type.
7681         (gdbsim_target::pid_to_str): Change return type.
7682         * ravenscar-thread.c (struct ravenscar_thread_target)
7683         <pid_to_str>: Change return type.
7684         (ravenscar_thread_target::pid_to_str): Change return type.
7685         * procfs.c (class procfs_target) <pid_to_str>: Change return
7686         type.
7687         (procfs_target::pid_to_str): Change return type.
7688         (procfs_target::attach): Update.
7689         (procfs_target::detach): Update.
7690         (procfs_target::fetch_registers): Update.
7691         (procfs_target::store_registers): Update.
7692         (procfs_target::wait): Update.
7693         (procfs_target::files_info): Update.
7694         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7695         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7696         return type.
7697         (nto_procfs_target::pid_to_str): Change return type.
7698         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7699         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7700         return type.
7701         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7702         (exit_lwp): Update.
7703         (attach_proc_task_lwp_callback, get_detach_signal)
7704         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7705         (linux_nat_target::resume, wait_lwp, stop_callback)
7706         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7707         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7708         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7709         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7710         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7711         type.
7712         (inf_ptrace_target::attach): Update.
7713         (inf_ptrace_target::files_info): Update.
7714         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7715         type.
7716         (go32_nat_target::pid_to_str): Change return type.
7717         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7718         (gnu_nat_target::wait): Update.
7719         (gnu_nat_target::wait): Update.
7720         (gnu_nat_target::resume): Update.
7721         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7722         (fbsd_nat_target::wait): Update.
7723         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7724         type.
7725         (darwin_nat_target::attach): Update.
7726         * corelow.c (class core_target) <pid_to_str>: Change return type.
7727         (core_target::pid_to_str): Change return type.
7728         * target.c (normal_pid_to_str): Change return type.
7729         (default_pid_to_str): Likewise.
7730         (target_pid_to_str): Change return type.
7731         (target_translate_tls_address): Update.
7732         (target_announce_detach): Update.
7733         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7734         return type.
7735         (bsd_uthread_target::pid_to_str): Change return type.
7736         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7737         type.
7738         (bsd_kvm_target::pid_to_str): Change return type.
7739         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7740         return type.
7741         (aix_thread_target::pid_to_str): Change return type.
7742         * target.h (struct target_ops) <pid_to_str>: Change return type.
7743         (target_pid_to_str, normal_pid_to_str): Likewise.
7744         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7745         type.
7746         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7747         type.
7748         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7749         return type.
7750         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7751         type.
7752         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7753         type.
7754         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7755         return type.
7756
7757 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7758
7759         * NEWS: Mention that the new default MI version is 3.  Mention
7760         changes to the output of commands and events that deal with
7761         multi-location breakpoints.
7762         * breakpoint.c: Include "mi/mi-out.h".
7763         (print_one_breakpoint): Change output syntax if using MI version
7764         >= 3.
7765         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7766         New.
7767         (mi_multi_location_breakpoint_output_fixed): New.
7768         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7769         (mi_cmd_fix_multi_location_breakpoint_output): New.
7770         (mi_multi_location_breakpoint_output_fixed): New.
7771         * mi/mi-cmds.c (mi_cmds): Register command
7772         -fix-multi-location-breakpoint-output.
7773         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7774         interpreter "mi".
7775
7776 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7777
7778         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7779         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7780         instantiate mi_ui_out based on interpreter name.
7781         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7782         * mi/mi-main.c (mi_load_progress): Likewise.
7783
7784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7785
7786         * NEWS: Combine separate "New targets" sections for 8.3.
7787
7788 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7789
7790         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7791         (ppcfbsd_init_abi): Install gdbarch
7792         "fetch_tls_load_module_address" and "get_thread_local_address"
7793         methods.
7794
7795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7796
7797         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7798         (riscv_fbsd_init_abi): Install gdbarch
7799         "fetch_tls_load_module_address" and "get_thread_local_address"
7800         methods.
7801
7802 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7803
7804         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7805         (i386fbsd_init_abi): Install gdbarch
7806         "fetch_tls_load_module_address" and "get_thread_local_address"
7807         methods.
7808
7809 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7810
7811         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7812         (amd64fbsd_init_abi): Install gdbarch
7813         "fetch_tls_load_module_address" and "get_thread_local_address"
7814         methods.
7815
7816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7817
7818         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7819         (struct fbsd_pspace_data): New type.
7820         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7821         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7822         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7823         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7824         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7825
7826 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7827
7828         * gdbtypes.c (lookup_struct_elt): New function.
7829         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7830         * gdbtypes.h (struct struct_elt): New type.
7831         (lookup_struct_elt): New prototype.
7832
7833 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7834
7835         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7836         remove disabled code block.
7837
7838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7839
7840         * gdbarch.sh (get_thread_local_address): New method.
7841         * gdbarch.h, gdbarch.c: Regenerate.
7842         * target.c (target_translate_tls_address): Use
7843         gdbarch_get_thread_local_address if present instead of
7844         target::get_thread_local_address.
7845
7846 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7847
7848         * target.h (target::get_thread_local_address): Update comment.
7849
7850 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7851
7852         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7853         objfile->separate_debug_objfile_backlink if not NULL.
7854
7855 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7856
7857         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7858         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7859         (amd64bsd_store_inferior_registers): Likewise.
7860         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7861         Enable segment base registers.
7862         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7863         PT_GETFSBASE and PT_GETGSBASE.
7864         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7865         PT_SETGSBASE.
7866         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7867         segment base registers.
7868         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7869
7870 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7871
7872         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7873         Update calls to i386_target_description to add 'segments'
7874         parameter.
7875         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7876         add segment base registers.
7877         * arch/i386.c (i386_create_target_description): Add 'segments'
7878         parameter to enable segment base registers.
7879         * arch/i386.h (i386_create_target_description): Likewise.
7880         * features/i386/32bit-segments.xml: New file.
7881         * features/i386/32bit-segments.c: Generate.
7882         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7883         call to i386_target_description to add 'segments' parameter.
7884         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7885         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7886         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7887         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7888         if feature is present.
7889         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7890         Add 'segments' parameter to call to i386_target_description.
7891         (i386_target_description): Add 'segments' parameter to enable
7892         segment base registers.
7893         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7894         to call to i386_target_description.
7895         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7896         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7897         Define I386_NUM_REGS.
7898         (i386_target_description): Add 'segments' parameter to enable
7899         segment base registers.
7900
7901 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7902
7903         PR/24325
7904         * source-cache.c: #undef open and close, to avoid unresolved
7905         externals during linking.
7906
7907 2019-03-12  Tom Tromey  <tromey@adacore.com>
7908
7909         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7910         const.  Add initializers.
7911         (_initialize_remote): Don't initialize ptid globals.
7912
7913 2019-03-12  Pedro Alves  <palves@redhat.com>
7914
7915         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7916
7917 2019-03-12  Pedro Alves  <palves@redhat.com>
7918
7919         * cp-name-parser.y (main): Remove unused 'len' variable.
7920
7921 2019-03-12  Tom Tromey  <tromey@adacore.com>
7922
7923         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7924         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7925
7926 2019-03-12  Tom Tromey  <tromey@adacore.com>
7927
7928         * linux-nat.c (iterate_over_lwps): Update.
7929         (stop_callback): Remove parameter.
7930         (stop_wait_callback, detach_callback, resume_set_callback)
7931         (select_singlestep_lwp_callback, set_ignore_sigint)
7932         (status_callback, resumed_callback, resume_clear_callback)
7933         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7934         data parameter.
7935         (linux_nat_target::detach, linux_nat_target::resume)
7936         (linux_stop_and_wait_all_lwps, select_event_lwp)
7937         (linux_nat_filter_event, linux_nat_wait_1)
7938         (linux_nat_target::kill, linux_nat_target::stop)
7939         (linux_nat_target::stop): Update.
7940         (linux_nat_resume_callback): Change type.
7941         (resume_stopped_resumed_lwps, count_events_callback)
7942         (select_event_lwp_callback): Likewise.
7943         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7944         * arm-linux-nat.c (struct update_registers_data): Remove.
7945         (update_registers_callback): Change type.
7946         (arm_linux_insert_hw_breakpoint1): Update.
7947         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7948         parameter.
7949         (x86_linux_dr_set_addr): Update.
7950         (x86_linux_dr_set_control): Update.
7951         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7952         (iterate_over_lwps): Use gdb::function_view.
7953         * nat/aarch64-linux-hw-point.c (struct
7954         aarch64_dr_update_callback_param): Remove.
7955         (debug_reg_change_callback): Change type.
7956         (aarch64_notify_debug_reg_change): Update.
7957         * s390-linux-nat.c (s390_refresh_per_info): Update.
7958
7959 2019-03-11  Tom Tromey  <tromey@adacore.com>
7960
7961         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7962         redundant assignment to "this_cu".
7963
7964 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7965
7966         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7967
7968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7969
7970         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7971         from...
7972         (rank_one_type): ... this.
7973
7974 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7975
7976         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7977         from...
7978         (rank_one_type): ... this.
7979
7980 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7981
7982         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7983         from...
7984         (rank_one_type): ... this.
7985
7986 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7987
7988         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7989         from...
7990         (rank_one_type): ... this.
7991
7992 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7993
7994         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7995         from...
7996         (rank_one_type): ... this.
7997
7998 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7999
8000         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8001         from...
8002         (rank_one_type): ... this.
8003
8004 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8005
8006         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8007         from...
8008         (rank_one_type): ... this.
8009
8010 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8011
8012         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8013         from...
8014         (rank_one_type): ... this.
8015
8016 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8017
8018         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8019         from...
8020         (rank_one_type): ... this.
8021
8022 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8023
8024         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8025         from...
8026         (rank_one_type): ... this.
8027
8028 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8029
8030         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8031         from...
8032         (rank_one_type): ... this.
8033
8034 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8035
8036         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8037         from...
8038         (rank_one_type): ... this.
8039
8040 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8041
8042         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8043         inferior-events' shows the example events.
8044
8045 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8046
8047         Support styling on native MS-Windows console
8048
8049         PR/24315
8050         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8051         on MS-Windows if $TERM is not defined.
8052
8053         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8054
8055         * posix-hdep.c (gdb_console_fputs):
8056         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8057         functions.
8058         * ui-file.h (gdb_console_fputs): Add prototype.
8059
8060         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8061         back to fputs only if the former returns zero.
8062
8063 2019-03-07  Tom Tromey  <tom@tromey.com>
8064
8065         * symmisc.c (print_symbol_bcache_statistics): Update.
8066         (print_objfile_statistics): Update.
8067         * symfile.c (allocate_symtab): Update.
8068         * stabsread.c: Don't include bcache.h.
8069         * psymtab.h (struct psymbol_bcache): Don't declare.
8070         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8071         (psymbol_bcache_init, psymbol_bcache_free)
8072         (psymbol_bcache_get_bcache): Don't declare.
8073         * psymtab.c (struct psymbol_bcache): Remove.
8074         (psymtab_storage::psymtab_storage): Update.
8075         (psymtab_storage::~psymtab_storage): Update.
8076         (psymbol_bcache_init, psymbol_bcache_free)
8077         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8078         (add_psymbol_to_bcache): Update.
8079         (allocate_psymtab): Update.
8080         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8081         macro_cache>: No longer pointers.
8082         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8083         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8084         * macrotab.c (macro_bcache): Update.
8085         * macroexp.c: Don't include bcache.h.
8086         * gdbtypes.c (check_types_worklist): Update.
8087         (types_deeply_equal): Remove TRY/CATCH.  Update.
8088         * elfread.c (elf_symtab_read): Update.
8089         * dwarf2read.c: Don't include bcache.h.
8090         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8091         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8092         (print_bcache_statistics, bcache_memory_used): Don't declare.
8093         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8094         methods.  Rename all data members.
8095         * bcache.c (struct bcache): Move to bcache.h.
8096         (bcache::expand_hash_table): Rename from expand_hash_table.
8097         (bcache): Remove.
8098         (bcache::insert): Rename from bcache_full.
8099         (bcache::compare): Rename from bcache_compare.
8100         (bcache_xmalloc): Remove.
8101         (bcache::~bcache): Rename from bcache_xfree.
8102         (bcache::print_statistics): Rename from print_bcache_statistics.
8103         (bcache::memory_used): Rename from bcache_memory_used.
8104
8105 2019-03-07  Pedro Alves  <palves@redhat.com>
8106
8107         * infrun.c (normal_stop): Also check for
8108         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8109
8110 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8111
8112         * f-lang.c (value_from_host_double): Moved to...
8113         * value.c (value_from_host_double): ...here.
8114         * value.h (value_from_host_double): Declare.
8115         * guile/scm-math.c (vlscm_convert_typed_number): Use
8116         value_from_host_double.
8117         (vlscm_convert_number): Likewise.
8118         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8119         * python/py-value.c (convert_value_from_python): Likewise.
8120
8121 2019-03-06  Tom Tromey  <tom@tromey.com>
8122
8123         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8124
8125 2019-03-06  Tom Tromey  <tom@tromey.com>
8126
8127         * utils.h (free_current_contents): Don't declare.
8128         * utils.c (free_current_contents): Remove.
8129
8130 2019-03-06  Tom Tromey  <tom@tromey.com>
8131
8132         * top.c (quit_force): Update.
8133         * main.c (captured_command_loop): Update.
8134         * common/new-op.c (operator new): Update.
8135         * common/common-exceptions.c (struct catcher)
8136         <save_cleanup_chain>: Remove member.
8137         (exceptions_state_mc_init): Update.
8138         (exception_try_scope_entry): Return nullptr.
8139         (exception_try_scope_exit, exception_rethrow)
8140         (throw_exception_sjlj, throw_exception_cxx): Update.
8141         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8142         (all_cleanups, do_cleanups, discard_cleanups)
8143         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8144         (restore_cleanups, restore_final_cleanups): Don't declare.
8145         (do_final_cleanups): Remove parameter.
8146         * common/cleanups.c (cleanup_chain, make_cleanup)
8147         (make_cleanup_dtor, all_cleanups, do_cleanups)
8148         (discard_my_cleanups, discard_cleanups)
8149         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8150         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8151         (null_cleanup): Remove.
8152         (do_final_cleanups): Remove parameter.
8153
8154 2019-03-06  Tom Tromey  <tom@tromey.com>
8155
8156         * remote.c (remote_target::remote_parse_stop_reply): Use
8157         unique_xmalloc_ptr.
8158
8159 2019-03-06  Tom Tromey  <tom@tromey.com>
8160
8161         * stabsread.c (struct stabs_field_info): Rename from field_info.
8162         <list, fnlist>: Add initializers.
8163         <obstack>: New member.
8164         (read_member_functions, read_struct_fields, read_baseclasses):
8165         Allocate on obstack.  Don't use cleanups.
8166         (read_one_struct_field, read_member_functions, read_struct_fields)
8167         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8168         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8169         (read_struct_type): Update.
8170
8171 2019-03-06  Tom Tromey  <tom@tromey.com>
8172
8173         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8174         * common/filestuff.h (make_cleanup_close): Don't declare.
8175         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8176         Remove.
8177
8178 2019-03-06  Tom Tromey  <tom@tromey.com>
8179
8180         * solib-aix.c: Use make_scope_exit.
8181
8182 2019-03-06  Tom Tromey  <tom@tromey.com>
8183
8184         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8185         Use make_scope_exit.
8186
8187 2019-03-06  Tom Tromey  <tom@tromey.com>
8188
8189         * solib-svr4.c (disable_probes_interface): Remove parameter.
8190         (svr4_handle_solib_event): Use make_scope_exit.
8191
8192 2019-03-06  Tom Tromey  <tom@tromey.com>
8193
8194         * remote.c (struct stop_reply_deleter): Remove.
8195         (stop_reply_up): Update.
8196         (struct stop_reply): Derive from notif_event.  Don't typedef.
8197         <regcache>: Now a std::vector.
8198         (stop_reply_xfree): Remove.
8199         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8200         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8201         (remote_target::discard_pending_stop_replies): Use delete.
8202         (remote_target::remote_parse_stop_reply): Update.
8203         (remote_target::process_stop_reply): Update.
8204         * remote-notif.h (struct notif_event): Add virtual destructor.
8205         Remove "dtr" member.
8206         (struct notif_client) <alloc_event>: Return a unique_ptr.
8207         (notif_event_xfree): Don't declare.
8208         (notif_event_up): New typedef.
8209         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8210         (notif_event_xfree, do_notif_event_xfree): Remove.
8211         (remote_notif_state_xfree): Update.
8212
8213 2019-03-06  Tom Tromey  <tom@tromey.com>
8214
8215         * infrun.c (displaced_step_clear_cleanup): Now a
8216         forward_scope_exit type.
8217         (displaced_step_prepare_throw): Update.
8218         (displaced_step_fixup): Update.
8219
8220 2019-03-06  Tom Tromey  <tom@tromey.com>
8221
8222         * inferior.h (class inferior): Update comment.
8223         * gdbthread.h (class thread_info): Update comment.
8224
8225 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8226             Tom Tromey  <tom@tromey.com>
8227
8228         * stabsread.h (struct stab_section_list): Remove.
8229         (coffstab_build_psymtabs): Update.
8230         * dbxread.c (symbuf_sections): Now a std::vector.
8231         (sect_idx): New global.
8232         (fill_symbuf): Update.
8233         (coffstab_build_psymtabs): Change type of stabsects parameter.
8234         Update.
8235         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8236         std::vector.
8237         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8238         (coff_locate_sections): Update.
8239         (coff_symfile_read): Remove cleanups.  Update.
8240         (init_stringtab): Add storage parameter.
8241         (free_stringtab, free_stringtab_cleanup): Remove.
8242         (init_lineno): Add storage parameter.
8243         (free_linetab, free_linetab_cleanup): Remove.
8244
8245 2019-03-06  Pedro Alves  <palves@redhat.com>
8246
8247         * linux-fork.c (fork_info::clobber_regs): Delete.
8248         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8249         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8250         comment.  Adjust.
8251         (scoped_switch_fork_info::scoped_switch_fork_info)
8252         (checkpoint_command, linux_fork_context): Adjust
8253         fork_save_infrun_state calls.
8254
8255 2019-03-06  Pedro Alves  <palves@redhat.com>
8256
8257         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8258         (inf_has_multiple_threads): Return 'bool' and rewrite using
8259         inferior_info::threads().
8260
8261 2019-03-06  Pedro Alves  <palves@redhat.com>
8262
8263         * linux-fork.c: Include <list>.
8264         (fork_list): Now a std::list instance.
8265         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8266         (forks_exist_p, find_last_fork): Adjust.
8267         (new_fork): Delete.
8268         (one_fork_p): New.
8269         (add_fork): Adjust.
8270         (free_fork): Delete, folded into fork_info::~fork_info().
8271         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8272         Adjust.
8273         (init_fork_list): Delete.
8274         (linux_fork_killall, linux_fork_mourn_inferior)
8275         (linux_fork_detach, info_checkpoints_command): Adjust.
8276         (_initialize_linux_fork): No longer call init_fork_list.
8277
8278 2019-03-06  Pedro Alves  <palves@redhat.com>
8279
8280         * linux-fork.c (new_fork): New, split out of ...
8281         (add_fork): ... this.  Return void.  Move "first fork" special
8282         case from here, to ...
8283         (checkpoint_command): ... here.
8284         * linux-linux.h (add_fork): Return void.
8285
8286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8287
8288         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8289
8290 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8291             Chris January  <chris.january@arm.com>
8292             David Lecomber  <david.lecomber@arm.com>
8293
8294         * f-exp.y: New token, UNOP_INTRINSIC.
8295         (exp): New pattern using UNOP_INTRINSIC token.
8296         (f77_keywords): Add 'abs' keyword.
8297         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8298         (value_from_host_double): New function.
8299         (evaluate_subexp_f): Support UNOP_ABS.
8300
8301 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8302
8303         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8304         types.
8305
8306 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8307
8308         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8309         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8310         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8311
8312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8313
8314         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8315
8316 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8317             Chris January  <chris.january@arm.com>
8318
8319         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8320         * f-exp.y: Define 'KIND' token.
8321         (exp): New pattern for KIND expressions.
8322         (ptype): Handle types with a kind extension.
8323         (direct_abs_decl): Extend to spot kind extensions.
8324         (f77_keywords): Add 'kind' to the list.
8325         (push_kind_type): New function.
8326         (convert_to_kind_type): New function.
8327         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8328         * parse.c (operator_length_standard): Likewise.
8329         * parser-defs.h (enum type_pieces): Add tp_kind.
8330         * std-operator.def: Add UNOP_KIND.
8331
8332 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8333
8334         * f-exp.y (f_parse): Set yydebug.
8335
8336 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8337
8338         * f-lang.c (evaluate_subexp_f): New function.
8339         (exp_descriptor_f): New global.
8340         (f_language_defn): Use exp_descriptor_f instead of
8341         exp_descriptor_standard.
8342
8343 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8344
8345         * f-exp.y (struct token): Add comments.
8346         (dot_ops): Remove uppercase versions and the end marker.
8347         (f77_keywords): Likewise.
8348         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8349         entries in the dot_ops array are case insensitive, and use
8350         strncasecmp to compare strings.  Also some whitespace cleanup in
8351         this area.  Similar for the f77_keywords array, except entries in
8352         this list might be case sensitive.
8353
8354 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8355
8356         * f-exp.y (struct f77_boolean_val): Add comments.
8357         (boolean_values): Remove uppercase versions, and end marker.
8358         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8359         and use strncasecmp to achieve case insensitivity.  Additionally,
8360         perform whitespace cleanup around this code.
8361
8362 2019-03-06  Tom Tromey  <tromey@adacore.com>
8363
8364         * remote-sim.c (gdbsim_target_open): Use result of
8365         gdb_argv::release.
8366
8367 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8368         Dirk Schubert  <dirk.schubert@arm.com>
8369         Chris January  <chris.january@arm.com>
8370
8371         * eval.c (evaluate_subexp_standard): Call Fortran argument
8372         wrapping logic.
8373         * f-lang.c (struct value): A value which can be passed into a
8374         Fortran function call.
8375         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8376         where appropriate.
8377         (struct type): Value ready for a Fortran function call.
8378         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8379         is needed.
8380         * f-lang.h (fortran_argument_convert): Declaration.
8381         (fortran_preserve_arg_pointer): Declaration.
8382         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8383
8384 2019-03-05  Tom Tromey  <tromey@adacore.com>
8385
8386         * python/py-prettyprint.c (print_string_repr): Remove #if.
8387         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8388
8389 2019-03-05  Tom Tromey  <tromey@adacore.com>
8390
8391         * target.c (the_dummy_target): Move later.  Change type to
8392         "dummy_target".
8393         (initialize_targets): Don't initialize the_dummy_target.
8394
8395 2019-03-05  Tom Tromey  <tromey@adacore.com>
8396
8397         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8398         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8399
8400 2019-03-05  Tom Tromey  <tromey@adacore.com>
8401
8402         * windows-nat.c (windows_nat_target::attach)
8403         (windows_nat_target::detach): Don't call gdb_flush.
8404         * valprint.c (generic_val_print, val_print, val_print_string):
8405         Don't call gdb_flush.
8406         * utils.c (defaulted_query): Don't call gdb_flush.
8407         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8408         * target.c (target_announce_detach): Don't call gdb_flush.
8409         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8410         * remote.c (extended_remote_target::attach): Don't call
8411         gdb_flush.
8412         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8413         * printcmd.c (do_examine): Don't call gdb_flush.
8414         (info_display_command): Don't call gdb_flush.
8415         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8416         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8417         * memattr.c (info_mem_command): Don't call gdb_flush.
8418         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8419         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8420         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8421         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8422         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8423         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8424         (gnu_nat_target::detach): Don't call gdb_flush.
8425         * f-valprint.c (f_val_print): Don't call gdb_flush.
8426         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8427         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8428         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8429         gdb_flush.
8430         * c-valprint.c (c_val_print): Don't call gdb_flush.
8431         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8432
8433 2019-03-05  Tom Tromey  <tromey@adacore.com>
8434
8435         * varobj.c (update_dynamic_varobj_children): Update.
8436         (install_default_visualizer): Use reset, not release.
8437         * value.c (set_internalvar): Update.
8438         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8439         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8440         ATTRIBUTE_UNUSED_RESULT.
8441
8442 2019-03-05  Tom Tromey  <tromey@adacore.com>
8443
8444         * remote.c (class scoped_remote_fd) <release>: Add
8445         ATTRIBUTE_UNUSED_RESULT.
8446
8447 2019-03-05  Tom Tromey  <tromey@adacore.com>
8448
8449         * macroexp.c (struct macro_buffer) <release>: Add
8450         ATTRIBUTE_UNUSED_RESULT.
8451
8452 2019-03-05  Tom Tromey  <tromey@adacore.com>
8453
8454         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8455         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8456         ATTRIBUTE_UNUSED_RESULT.
8457
8458 2019-03-05  Tom Tromey  <tromey@adacore.com>
8459
8460         * common/scoped_fd.h (class scoped_fd) <release>: Add
8461         ATTRIBUTE_UNUSED_RESULT.
8462
8463 2019-03-05  Tom Tromey  <tromey@adacore.com>
8464
8465         * parser-defs.h (struct parser_state) <release>: Add
8466         ATTRIBUTE_UNUSED_RESULT.
8467
8468 2019-03-05  Tom Tromey  <tromey@adacore.com>
8469
8470         * utils.h (class gdb_argv) <release>: Add
8471         ATTRIBUTE_UNUSED_RESULT.
8472         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8473
8474 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8475
8476         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8477         for-loop range, to avoid compiler warnings.
8478
8479         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8480         avoid compiler warnings about unused variables.
8481
8482         * NEWS: Mention end of support for native debugging on MS-Windows
8483         before XP.
8484
8485         PR gdb/24292
8486         * common/netstuff.c:
8487         * gdbserver/gdbreplay.c
8488         * gdbserver/remote-utils.c:
8489         * ser-tcp.c:
8490         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8491         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8492         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8493         'getaddrinfo' and 'freeaddrinfo' were not available before
8494         Windows XP, and mingw.org's MinGW headers by default define
8495         _WIN32_WINNT to 0x500.
8496
8497 2019-03-01  Gary Benson <gbenson@redhat.com>
8498
8499         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8500
8501 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8502             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8503
8504         PR gdb/8527
8505         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8506         set_sigint_trap, clear_sigint_trap.
8507
8508 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8509
8510         * target.c (target_detach): Clear the regcache and the
8511         frame cache.
8512
8513 2019-02-27  Pedro Alves  <palves@redhat.com>
8514
8515         * utils.c (set_screen_size): When we cap the height/width sizes,
8516         tweak the corresponding command variable to show "unlimited":
8517
8518 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8519             Pedro Alves  <palves@redhat.com>
8520
8521         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8522         before calling rl_set_screen_size.
8523
8524 2019-02-27  Tom Tromey  <tromey@adacore.com>
8525
8526         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8527         define.
8528         * python/py-value.c: Remove Python 2.4 workaround.
8529         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8530         workaround.
8531         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8532         Python 2.4 workaround.
8533         * python/python-internal.h: Remove Python 2.4 comment.
8534         (Py_ssize_t): Don't define.
8535         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8536         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8537         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8538         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8539         * python/python.c (do_start_initialization): Remove Python 2.4
8540         workaround.
8541         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8542         (print_children): Remove Python 2.4 workaround.
8543         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8544         workaround.
8545         (CHARBUFFERPROC_NAME): Remove.
8546         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8547         Python 2.4 workaround.
8548
8549 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8550
8551         * NEWS: Note minimum Python version.
8552
8553 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8554
8555         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8556         code from these functions.  Remove corresponding ifdefs.  Use
8557         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8558         Remove gotos and target of gotos.
8559         (infpy_search_memory): Likewise.
8560
8561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8562
8563         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8564         (hppa_gdbarch_init): Don't register deleted functions with
8565         gdbarch.
8566
8567 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8568
8569         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8570         (h8300_unwind_sp): Delete.
8571         (h8300_dummy_id): Delete.
8572         (h8300_gdbarch_init): Don't register deleted functions with
8573         gdbarch.
8574
8575 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8576
8577         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8578         (ft32_unwind_pc): Delete.
8579         (ft32_unwind_sp): Delete.
8580         (ft32_gdbarch_init): Don't register deleted functions with
8581         gdbarch.
8582
8583 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8584
8585         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8586         (frv_unwind_pc): Delete.
8587         (frv_unwind_sp): Delete.
8588         (frv_gdbarch_init): Don't register deleted functions with
8589         gdbarch.
8590
8591 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8592
8593         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8594         (riscv_unwind_pc): Delete.
8595         (riscv_unwind_sp): Delete.
8596         (riscv_gdbarch_init): Don't register deleted functions with
8597         gdbarch.
8598
8599 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8600
8601         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8602         (csky_unwind_pc): Delete.
8603         (csky_unwind_sp): Delete.
8604         (csky_gdbarch_init): Don't register deleted functions with
8605         gdbarch.
8606
8607 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8608
8609         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8610         (cris_unwind_pc): Delete.
8611         (cris_unwind_sp): Delete.
8612         (cris_gdbarch_init): Don't register deleted functions with
8613         gdbarch.
8614
8615 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8616
8617         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8618         (bfin_unwind_pc): Delete.
8619         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8620
8621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8622
8623         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8624         (arm_unwind_pc): Delete.
8625         (arm_unwind_sp): Delete.
8626         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8627
8628 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8629
8630         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8631         (arc_unwind_pc): Delete.
8632         (arc_unwind_sp): Delete.
8633         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8634
8635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8636
8637         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8638         (alpha_unwind_pc): Delete.
8639         (alpha_gdbarch_init): Don't register deleted functions with
8640         gdbarch.
8641
8642 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8643
8644         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8645         (aarch64_unwind_pc): Delete.
8646         (aarch64_unwind_sp): Delete.
8647         (aarch64_gdbarch_init): Don't register deleted functions with
8648         gdbarch.
8649
8650 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8651
8652         * gdbtypes.c (type_align): Don't consider static members when
8653         computing structure alignment.
8654
8655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8656
8657         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8658         return 0 for other types.
8659         * arch-utils.c (default_type_align): Always return 0.
8660         * gdbarch.h: Regenerate.
8661         * gdbarch.sh (type_align): Extend comment.
8662         * gdbtypes.c (type_align): Add additional comments, always call
8663         gdbarch_type_align before applying the default rules.
8664         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8665         generic code will then apply a suitable default.
8666         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8667         types, return 0 for other types.
8668
8669 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8670
8671         * NEWS: Create a new section for the next release branch.
8672         Rename the section of the current branch, now that it has
8673         been cut.
8674
8675 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8676
8677         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8678         * version.in: Bump version to 8.3.50.DATE-git.
8679
8680 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8681
8682         * aix-thread.c (ptid_cmp): Remove unused variable.
8683         (get_signaled_thread): Likewise.
8684         (store_regs_user_thread): Likewise.
8685         (store_regs_kernel_thread): Likewise.
8686         (fetch_regs_kernel_thread): Remove shadowed variable.
8687
8688 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8689
8690         * features/riscv/32bit-cpu.xml: Add register numbers.
8691         * features/riscv/32bit-fpu.c: Regenerate.
8692         * features/riscv/32bit-fpu.xml: Add register numbers.
8693         * features/riscv/64bit-cpu.xml: Add register numbers.
8694         * features/riscv/64bit-fpu.c: Regenerate.
8695         * features/riscv/64bit-fpu.xml: Add register numbers.
8696
8697 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8698
8699         * NEWS: Mention two argument form of gdb.Value constructor.
8700         * python/py-value.c (convert_buffer_and_type_to_value): New
8701         function.
8702         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8703         Add support for handling an optional second argument.  Call
8704         convert_buffer_and_type_to_value as appropriate.
8705         * python/python-internal.h (Py_buffer_deleter): New struct.
8706         (Py_buffer_up): New typedef.
8707
8708 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8709
8710         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8711         instead of releasing ownership.
8712
8713 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8714
8715         * dwarf2read.c (open_and_init_dwp_file): Call
8716         elf_numsections instead of bfd_count_sections to initialize
8717         dwp_file->num_sections.
8718
8719 2019-02-25  Tom Tromey  <tromey@adacore.com>
8720
8721         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8722
8723 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8724
8725         * gcore.in: Add '--readnever' option when invoking GDB.
8726
8727 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8728
8729         * MAINTAINERS: Update my email address.
8730
8731 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8732
8733         * build-id.c (build_id_to_debug_bfd_1): New function.
8734         (build_id_to_debug_bfd): Look for separate debug file in
8735         sysroot.
8736
8737 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8738
8739         * gdbarch.sh: Update the copyright year range that is placed into
8740         generated files.
8741
8742 2019-02-22  Keith Seitz  <keiths@redhat.com>
8743
8744         PR symtab/23853
8745         * linespec.c (create_sals_line_offset): Search for the default
8746         symtab's filename instead of its fullname.
8747
8748 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8749
8750         * NEWS: Update style defaults.
8751
8752 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8753
8754         * main.c (captured_main_1): Disable styling in batch mode.
8755
8756 2019-02-20  Tom Tromey  <tom@tromey.com>
8757
8758         * symtab.c (symtab_symbol_info): Fix typos.
8759
8760 2019-02-20  Tom Tromey  <tromey@adacore.com>
8761
8762         * findcmd.c (_initialize_mem_search): Use upper case for
8763         metasyntactic variables.
8764
8765 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8766
8767         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8768         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8769
8770 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8771
8772         * top.h (source_file_name): Change to std::string.
8773         * top.c (source_file_name): Likewise.
8774         (command_line_input): Adjust.
8775         * cli/cli-script.c (script_from_file): Adjust.
8776
8777 2019-02-19  Tom Tromey  <tromey@adacore.com>
8778
8779         * ravenscar-thread.c
8780         (ravenscar_thread_target::update_thread_list): Don't call
8781         ada_build_task_list.
8782         * ada-lang.h (ada_build_task_list): Don't declare.
8783         * ada-tasks.c (struct ada_tasks_inferior_data)
8784         <task_list_valid_p>: Now bool.
8785         (read_known_tasks, ada_task_list_changed)
8786         (ada_tasks_invalidate_inferior_data): Update.
8787         (read_known_tasks_array): Return bool.
8788         (read_known_tasks_list): Likewise.
8789         (read_known_tasks): Return void.
8790         (ada_build_task_list): Now static.
8791
8792 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8793
8794         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8795         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8796
8797 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8798
8799         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8800         variant for ada_tasks_pspace_data_handle and
8801         ada_tasks_inferior_data_handle.
8802         (ada_tasks_pspace_data_cleanup): New function.
8803         (ada_tasks_inferior_data_cleanup): New function.
8804
8805 2019-02-17  Tom Tromey  <tom@tromey.com>
8806
8807         * macrotab.h (macro_source_fullname): Return a std::string.
8808         * macrotab.c (macro_include, check_for_redefinition)
8809         (macro_undef, macro_lookup_definition, foreach_macro)
8810         (foreach_macro_in_scope): Update.
8811         (macro_source_fullname): Return a std::string.
8812         * macrocmd.c (show_pp_source_pos): Update.
8813
8814 2019-02-17  Tom Tromey  <tom@tromey.com>
8815
8816         * macrocmd.c (show_pp_source_pos): Style the file names.
8817
8818 2019-02-17  Tom Tromey  <tom@tromey.com>
8819
8820         PR tui/24197:
8821         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8822
8823 2019-02-17  Tom Tromey  <tom@tromey.com>
8824
8825         * ada-lang.c (user_select_syms): Use filtered printing.
8826         * utils.c (wrap_style): New global.
8827         (desired_style): Remove.
8828         (emit_style_escape): Add stream parameter.
8829         (set_output_style, reset_terminal_style, prompt_for_continue):
8830         Update.
8831         (flush_wrap_buffer): Only flush gdb_stdout.
8832         (wrap_here): Set wrap_style.
8833         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8834         treat escape sequences as a character.  Change when wrap buffer is
8835         flushed.
8836         (fputs_styled): Do not set the output style when the default is
8837         requested.
8838         * ui-style.h (struct ui_file_style) <is_default>: New method.
8839         * source.c (print_source_lines_base): Emit escape sequences in one
8840         piece.
8841
8842 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8843
8844         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8845         integers and enumeration types.
8846
8847 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8848
8849         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8850         instead of lookup_symbol_in_language
8851         (do_exact_match): New function.
8852         (ada_get_symbol_name_matcher): Return do_exact_match when
8853         doing a verbatim match.
8854
8855 2019-02-15  Tom Tromey  <tromey@adacore.com>
8856
8857         * ravenscar-thread.c (ravenscar_thread_target::resume)
8858         (ravenscar_thread_target::wait): Special case wildcard requests.
8859
8860 2019-02-15  Tom Tromey  <tromey@adacore.com>
8861
8862         * ravenscar-thread.c (base_ptid): Remove.
8863         (struct ravenscar_thread_target) <close>: New method.
8864         <m_base_ptid>: New member.
8865         <update_inferior_ptid, active_task, task_is_currently_active,
8866         runtime_initialized>: Declare methods.
8867         <ravenscar_thread_target>: Add constructor.
8868         (ravenscar_thread_target::task_is_currently_active)
8869         (ravenscar_thread_target::update_inferior_ptid)
8870         (ravenscar_runtime_initialized): Rename.  Now methods.
8871         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8872         (ravenscar_thread_target::update_thread_list): Update.
8873         (ravenscar_thread_target::active_task): Now method.
8874         (ravenscar_thread_target::store_registers)
8875         (ravenscar_thread_target::prepare_to_store)
8876         (ravenscar_thread_target::prepare_to_store)
8877         (ravenscar_thread_target::mourn_inferior): Update.
8878         (ravenscar_inferior_created): Use "new" to create target.
8879         (ravenscar_thread_target::get_ada_task_ptid): Update.
8880         (_initialize_ravenscar): Don't initialize base_ptid.
8881         (ravenscar_ops): Remove global.
8882
8883 2019-02-15  Tom Tromey  <tromey@adacore.com>
8884
8885         * target.h (push_target): Declare new overload.
8886         * target.c (push_target): New overload, taking an rvalue reference.
8887         * remote.c (remote_target::open_1): Use push_target overload.
8888         * corelow.c (core_target_open): Use push_target overload.
8889
8890 2019-02-15  Tom Tromey  <tromey@adacore.com>
8891
8892         * ravenscar-thread.c (is_ravenscar_task)
8893         (ravenscar_task_is_currently_active): Return bool.
8894         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8895         (_initialize_ravenscar): Remove "(void)".
8896         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8897         Return bool.
8898
8899 2019-02-15  Tom Tromey  <tromey@adacore.com>
8900
8901         * ravenscar-thread.c (ravenscar_runtime_initializer)
8902         (has_ravenscar_runtime, get_running_thread_id)
8903         (ravenscar_thread_target::resume): Fix indentation.
8904
8905 2019-02-15  Tom Tromey  <tromey@adacore.com>
8906
8907         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8908         from ravenscar_arch_ops.
8909         (sparc_ravenscar_ops::fetch_registers)
8910         (sparc_ravenscar_ops::store_registers): Now methods.
8911         (sparc_ravenscar_prepare_to_store): Remove.
8912         (sparc_ravenscar_ops): Redefine.
8913         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8914         methods and destructor.  Remove members.
8915         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8916         (ravenscar_thread_target::store_registers)
8917         (ravenscar_thread_target::prepare_to_store): Update.
8918         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8919         Remove.
8920         (struct ppc_ravenscar_powerpc_ops): Derive from
8921         ravenscar_arch_ops.
8922         (ppc_ravenscar_powerpc_ops::fetch_registers)
8923         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8924         (ppc_ravenscar_powerpc_ops): Redefine.
8925         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8926         (ppc_ravenscar_e500_ops::fetch_registers)
8927         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8928         (ppc_ravenscar_e500_ops): Redefine.
8929         * aarch64-ravenscar-thread.c
8930         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8931         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8932         (aarch64_ravenscar_fetch_registers)
8933         (aarch64_ravenscar_store_registers): Now methods.
8934         (aarch64_ravenscar_ops): Redefine.
8935
8936 2019-02-15  Tom Tromey  <tromey@adacore.com>
8937
8938         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8939         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8940         (ravenscar_thread_target::stopped_by_watchpoint)
8941         (ravenscar_thread_target::stopped_data_address)
8942         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8943
8944 2019-02-15  Tom Tromey  <tromey@adacore.com>
8945
8946         * ravenscar-thread.c: Fix some typos.
8947
8948 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8949             Tom Tromey  <tromey@adacore.com>
8950
8951         * ada-lang.c (ada_exception_sal): Change addr_string to a
8952         std::string.
8953         (create_ada_exception_catchpoint): Update.
8954
8955 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8956             Tom Tromey  <tromey@adacore.com>
8957
8958         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8959         (bp_location_ops): Remove.
8960         (base_breakpoint_allocate_location): Update.
8961         (free_bp_location): Update.
8962         * ada-lang.c (class ada_catchpoint_location)
8963         <ada_catchpoint_location>: Remove ops parameter.
8964         (ada_catchpoint_location_dtor): Remove.
8965         (ada_catchpoint_location_ops): Remove.
8966         (allocate_location_exception): Update.
8967         * breakpoint.h (struct bp_location_ops): Remove.
8968         (class bp_location) <bp_location>: Remove bp_location_ops
8969         parameter.
8970         <~bp_location>: Add destructor.
8971         <ops>: Remove.
8972
8973 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8974             Pedro Alves  <palves@redhat.com>
8975
8976         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8977         'PATH_MAX'.
8978
8979 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8980             Samuel Thibault  <samuel.thibault@gnu.org>
8981             Thomas Schwinge  <thomas@codesourcery.com>
8982
8983         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8984         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8985
8986 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8987
8988         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8989         (check_empty): Use "const char *".
8990
8991         * gnu-nat.c (gnu_nat_target::detach): Instead of
8992         'detach_inferior (pid)' call
8993         'detach_inferior (find_inferior_pid (pid))'.
8994
8995         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8996         'nat/fork-inferior.o'.
8997         * gnu-nat.c: #include "nat/fork-inferior.h".
8998
8999         * gnu-nat.c (gnu_nat_target::detach): Instead of
9000         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9001         * gnu-nat.h: #include "inf-child.h".
9002         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9003         'i386_gnu_nat_target::fetch_registers'.
9004         (gnu_store_registers): Rename/move to
9005         'i386_gnu_nat_target::store_registers'.
9006
9007         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9008         * gnu-nat.h (mach_thread_info): New function.
9009         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9010
9011         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9012
9013 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9014
9015         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9016
9017 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9018
9019         * windows-nat.c (windows_add_thread): Add new parameter
9020         "main_thread_p" with default value set to false.  Update
9021         function documentation as well as all callers.
9022         (windows_delete_thread): Likewise.
9023         (fake_create_process): Update call to windows_add_thread.
9024         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9025         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9026         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9027         call to windows_delete_thread.
9028
9029 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9030
9031         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9032
9033 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9034
9035         * symfile.c (find_separate_debug_file): Use canonical path of
9036         sysroot with child_path instead of gdb_sysroot if it is valid.
9037
9038 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9039
9040         * symfile.c (find_separate_debug_file): Use child_path to
9041         determine if an object file is under a sysroot.
9042
9043 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9044
9045         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9046         unittests/child-path-selftests.c.
9047         * common/pathstuff.c (child_path): New function.
9048         * common/pathstuff.h (child_path): New prototype.
9049         * unittests/child-path-selftests.c: New file.
9050
9051 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9052
9053         * symfile.c (find_separate_debug_file): Look for separate debug
9054         files in debug directories under the sysroot.
9055
9056 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9057
9058         * symtab.h (struct minimal_symbol data_p): New const method.
9059         (struct minimal_symbol text_p): Likewise.
9060         * symtab.c (output_source_filename): Use file name style
9061         to print file name.
9062         (print_symbol_info): Likewise.
9063         (print_msymbol_info): Use address style to print addresses.
9064         Use function name style to print executable text symbols.
9065         (expand_symtab_containing_pc): Use data_p.
9066         (find_pc_sect_compunit_symtab): Likewise.
9067
9068 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9069
9070         * breakpoint.c (describe_other_breakpoints): Use address style
9071         to print addresses.
9072         (say_where): Likewise.
9073
9074 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9075
9076         * ada-typeprint.c (print_func_type): Print function name
9077         style to print function name.
9078         * c-typeprint.c (c_print_type_1): Likewise.
9079
9080 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9081
9082         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9083         for execve.
9084
9085 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9086
9087         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9088         type_stack.
9089
9090 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9091
9092         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9093         TYPE_CODE_REF types.
9094
9095 2019-02-08  Jim Wilson  <jimw@sifive.com>
9096
9097         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9098         (riscv_linux_fregset): New.
9099         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9100
9101 2019-02-07  Tom Tromey  <tom@tromey.com>
9102
9103         * thread.c (thread_cancel_execution_command): Update.
9104         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9105         methods.
9106         (struct thread_fsm_ops): Remove.
9107         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9108         (thread_fsm_should_stop, thread_fsm_return_value)
9109         (thread_fsm_set_finished, thread_fsm_finished_p)
9110         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9111         Don't declare.
9112         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9113         * infrun.c (clear_proceed_status_thread)
9114         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9115         (print_stop_event): Update.
9116         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9117         Add constructor.
9118         (step_command_fsm_ops): Remove.
9119         (new_step_command_fsm): Remove.
9120         (step_1): Update.
9121         (step_command_fsm::should_stop): Rename from
9122         step_command_fsm_should_stop.
9123         (step_command_fsm::clean_up): Rename from
9124         step_command_fsm_clean_up.
9125         (step_command_fsm::do_async_reply_reason): Rename from
9126         step_command_fsm_async_reply_reason.
9127         (struct until_next_fsm): Inherit from thread_fsm.  Add
9128         constructor.
9129         (until_next_fsm_ops): Remove.
9130         (new_until_next_fsm): Remove.
9131         (until_next_fsm::should_stop): Rename from
9132         until_next_fsm_should_stop.
9133         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9134         (until_next_fsm::do_async_reply_reason): Rename from
9135         until_next_fsm_async_reply_reason.
9136         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9137         constructor.  Change type of breakpoint.
9138         (finish_command_fsm_ops): Remove.
9139         (new_finish_command_fsm): Remove.
9140         (finish_command_fsm::should_stop): Rename from
9141         finish_command_fsm_should_stop.
9142         (finish_command_fsm::clean_up): Rename from
9143         finish_command_fsm_clean_up.
9144         (finish_command_fsm::return_value): Rename from
9145         finish_command_fsm_return_value.
9146         (finish_command_fsm::do_async_reply_reason): Rename from
9147         finish_command_fsm_async_reply_reason.
9148         (finish_command): Update.
9149         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9150         Add constructor.
9151         (call_thread_fsm_ops): Remove.
9152         (call_thread_fsm::call_thread_fsm): Rename from
9153         new_call_thread_fsm.
9154         (call_thread_fsm::should_stop): Rename from
9155         call_thread_fsm_should_stop.
9156         (call_thread_fsm::should_notify_stop): Rename from
9157         call_thread_fsm_should_notify_stop.
9158         (run_inferior_call, call_function_by_hand_dummy): Update.
9159         * cli/cli-interp.c (should_print_stop_to_console): Update.
9160         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9161         Add constructor.  Change type of location_breakpoint,
9162         caller_breakpoint.
9163         (until_break_fsm_ops): Remove.
9164         (new_until_break_fsm): Remove.
9165         (until_break_fsm::should_stop): Rename from
9166         until_break_fsm_should_stop.
9167         (until_break_fsm::clean_up): Rename from
9168         until_break_fsm_clean_up.
9169         (until_break_fsm::do_async_reply_reason): Rename from
9170         until_break_fsm_async_reply_reason.
9171         (until_break_command): Update.
9172         * thread-fsm.c: Remove.
9173         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9174
9175 2019-02-07  Tom Tromey  <tom@tromey.com>
9176
9177         * yy-remap.h: Add include guard.
9178         * xtensa-tdep.h: Add include guard.
9179         * xcoffread.h: Rename include guard.
9180         * varobj-iter.h: Add include guard.
9181         * tui/tui.h: Rename include guard.
9182         * tui/tui-winsource.h: Rename include guard.
9183         * tui/tui-wingeneral.h: Rename include guard.
9184         * tui/tui-windata.h: Rename include guard.
9185         * tui/tui-win.h: Rename include guard.
9186         * tui/tui-stack.h: Rename include guard.
9187         * tui/tui-source.h: Rename include guard.
9188         * tui/tui-regs.h: Rename include guard.
9189         * tui/tui-out.h: Rename include guard.
9190         * tui/tui-layout.h: Rename include guard.
9191         * tui/tui-io.h: Rename include guard.
9192         * tui/tui-hooks.h: Rename include guard.
9193         * tui/tui-file.h: Rename include guard.
9194         * tui/tui-disasm.h: Rename include guard.
9195         * tui/tui-data.h: Rename include guard.
9196         * tui/tui-command.h: Rename include guard.
9197         * tic6x-tdep.h: Add include guard.
9198         * target/waitstatus.h: Rename include guard.
9199         * target/wait.h: Rename include guard.
9200         * target/target.h: Rename include guard.
9201         * target/resume.h: Rename include guard.
9202         * target-float.h: Rename include guard.
9203         * stabsread.h: Add include guard.
9204         * rs6000-tdep.h: Add include guard.
9205         * riscv-fbsd-tdep.h: Add include guard.
9206         * regformats/regdef.h: Rename include guard.
9207         * record.h: Rename include guard.
9208         * python/python.h: Rename include guard.
9209         * python/python-internal.h: Rename include guard.
9210         * python/py-stopevent.h: Rename include guard.
9211         * python/py-ref.h: Rename include guard.
9212         * python/py-record.h: Rename include guard.
9213         * python/py-record-full.h: Rename include guard.
9214         * python/py-record-btrace.h: Rename include guard.
9215         * python/py-instruction.h: Rename include guard.
9216         * python/py-events.h: Rename include guard.
9217         * python/py-event.h: Rename include guard.
9218         * procfs.h: Add include guard.
9219         * proc-utils.h: Add include guard.
9220         * p-lang.h: Add include guard.
9221         * or1k-tdep.h: Rename include guard.
9222         * observable.h: Rename include guard.
9223         * nto-tdep.h: Rename include guard.
9224         * nat/x86-linux.h: Rename include guard.
9225         * nat/x86-linux-dregs.h: Rename include guard.
9226         * nat/x86-gcc-cpuid.h: Add include guard.
9227         * nat/x86-dregs.h: Rename include guard.
9228         * nat/x86-cpuid.h: Rename include guard.
9229         * nat/ppc-linux.h: Rename include guard.
9230         * nat/mips-linux-watch.h: Rename include guard.
9231         * nat/linux-waitpid.h: Rename include guard.
9232         * nat/linux-ptrace.h: Rename include guard.
9233         * nat/linux-procfs.h: Rename include guard.
9234         * nat/linux-osdata.h: Rename include guard.
9235         * nat/linux-nat.h: Rename include guard.
9236         * nat/linux-namespaces.h: Rename include guard.
9237         * nat/linux-btrace.h: Rename include guard.
9238         * nat/glibc_thread_db.h: Rename include guard.
9239         * nat/gdb_thread_db.h: Rename include guard.
9240         * nat/gdb_ptrace.h: Rename include guard.
9241         * nat/fork-inferior.h: Rename include guard.
9242         * nat/amd64-linux-siginfo.h: Rename include guard.
9243         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9244         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9245         * nat/aarch64-linux.h: Rename include guard.
9246         * nat/aarch64-linux-hw-point.h: Rename include guard.
9247         * mn10300-tdep.h: Add include guard.
9248         * mips-linux-tdep.h: Add include guard.
9249         * mi/mi-parse.h: Rename include guard.
9250         * mi/mi-out.h: Rename include guard.
9251         * mi/mi-main.h: Rename include guard.
9252         * mi/mi-interp.h: Rename include guard.
9253         * mi/mi-getopt.h: Rename include guard.
9254         * mi/mi-console.h: Rename include guard.
9255         * mi/mi-common.h: Rename include guard.
9256         * mi/mi-cmds.h: Rename include guard.
9257         * mi/mi-cmd-break.h: Rename include guard.
9258         * m2-lang.h: Add include guard.
9259         * location.h: Rename include guard.
9260         * linux-record.h: Rename include guard.
9261         * linux-nat.h: Add include guard.
9262         * linux-fork.h: Add include guard.
9263         * i386-darwin-tdep.h: Rename include guard.
9264         * hppa-linux-offsets.h: Add include guard.
9265         * guile/guile.h: Rename include guard.
9266         * guile/guile-internal.h: Rename include guard.
9267         * gnu-nat.h: Rename include guard.
9268         * gdb-stabs.h: Rename include guard.
9269         * frv-tdep.h: Add include guard.
9270         * f-lang.h: Add include guard.
9271         * event-loop.h: Add include guard.
9272         * darwin-nat.h: Rename include guard.
9273         * cp-abi.h: Rename include guard.
9274         * config/sparc/nm-sol2.h: Rename include guard.
9275         * config/nm-nto.h: Rename include guard.
9276         * config/nm-linux.h: Add include guard.
9277         * config/i386/nm-i386gnu.h: Rename include guard.
9278         * config/djgpp/nl_types.h: Rename include guard.
9279         * config/djgpp/langinfo.h: Rename include guard.
9280         * compile/gcc-cp-plugin.h: Add include guard.
9281         * compile/gcc-c-plugin.h: Add include guard.
9282         * compile/compile.h: Rename include guard.
9283         * compile/compile-object-run.h: Rename include guard.
9284         * compile/compile-object-load.h: Rename include guard.
9285         * compile/compile-internal.h: Rename include guard.
9286         * compile/compile-cplus.h: Rename include guard.
9287         * compile/compile-c.h: Rename include guard.
9288         * common/xml-utils.h: Rename include guard.
9289         * common/x86-xstate.h: Rename include guard.
9290         * common/version.h: Rename include guard.
9291         * common/vec.h: Rename include guard.
9292         * common/tdesc.h: Rename include guard.
9293         * common/selftest.h: Rename include guard.
9294         * common/scoped_restore.h: Rename include guard.
9295         * common/scoped_mmap.h: Rename include guard.
9296         * common/scoped_fd.h: Rename include guard.
9297         * common/safe-iterator.h: Rename include guard.
9298         * common/run-time-clock.h: Rename include guard.
9299         * common/refcounted-object.h: Rename include guard.
9300         * common/queue.h: Rename include guard.
9301         * common/ptid.h: Rename include guard.
9302         * common/print-utils.h: Rename include guard.
9303         * common/preprocessor.h: Rename include guard.
9304         * common/pathstuff.h: Rename include guard.
9305         * common/observable.h: Rename include guard.
9306         * common/netstuff.h: Rename include guard.
9307         * common/job-control.h: Rename include guard.
9308         * common/host-defs.h: Rename include guard.
9309         * common/gdb_wait.h: Rename include guard.
9310         * common/gdb_vecs.h: Rename include guard.
9311         * common/gdb_unlinker.h: Rename include guard.
9312         * common/gdb_unique_ptr.h: Rename include guard.
9313         * common/gdb_tilde_expand.h: Rename include guard.
9314         * common/gdb_sys_time.h: Rename include guard.
9315         * common/gdb_string_view.h: Rename include guard.
9316         * common/gdb_splay_tree.h: Rename include guard.
9317         * common/gdb_setjmp.h: Rename include guard.
9318         * common/gdb_ref_ptr.h: Rename include guard.
9319         * common/gdb_optional.h: Rename include guard.
9320         * common/gdb_locale.h: Rename include guard.
9321         * common/gdb_assert.h: Rename include guard.
9322         * common/filtered-iterator.h: Rename include guard.
9323         * common/filestuff.h: Rename include guard.
9324         * common/fileio.h: Rename include guard.
9325         * common/environ.h: Rename include guard.
9326         * common/common-utils.h: Rename include guard.
9327         * common/common-types.h: Rename include guard.
9328         * common/common-regcache.h: Rename include guard.
9329         * common/common-inferior.h: Rename include guard.
9330         * common/common-gdbthread.h: Rename include guard.
9331         * common/common-exceptions.h: Rename include guard.
9332         * common/common-defs.h: Rename include guard.
9333         * common/common-debug.h: Rename include guard.
9334         * common/cleanups.h: Rename include guard.
9335         * common/buffer.h: Rename include guard.
9336         * common/btrace-common.h: Rename include guard.
9337         * common/break-common.h: Rename include guard.
9338         * cli/cli-utils.h: Rename include guard.
9339         * cli/cli-style.h: Rename include guard.
9340         * cli/cli-setshow.h: Rename include guard.
9341         * cli/cli-script.h: Rename include guard.
9342         * cli/cli-interp.h: Rename include guard.
9343         * cli/cli-decode.h: Rename include guard.
9344         * cli/cli-cmds.h: Rename include guard.
9345         * charset-list.h: Add include guard.
9346         * buildsym-legacy.h: Rename include guard.
9347         * bfin-tdep.h: Add include guard.
9348         * ax.h: Rename include guard.
9349         * arm-linux-tdep.h: Add include guard.
9350         * arm-fbsd-tdep.h: Add include guard.
9351         * arch/xtensa.h: Rename include guard.
9352         * arch/tic6x.h: Add include guard.
9353         * arch/i386.h: Add include guard.
9354         * arch/arm.h: Rename include guard.
9355         * arch/arm-linux.h: Rename include guard.
9356         * arch/arm-get-next-pcs.h: Rename include guard.
9357         * arch/amd64.h: Add include guard.
9358         * arch/aarch64-insn.h: Rename include guard.
9359         * arch-utils.h: Rename include guard.
9360         * annotate.h: Add include guard.
9361         * amd64-darwin-tdep.h: Rename include guard.
9362         * aarch64-linux-tdep.h: Add include guard.
9363         * aarch64-fbsd-tdep.h: Add include guard.
9364         * aarch32-linux-nat.h: Add include guard.
9365
9366 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9367
9368         * macrotab.c (macro_define_internal): New function that
9369         factorizes macro_define_object_internal and macro_define_function
9370         code.
9371         (macro_define_object_internal): Use macro_define_internal.
9372         (macro_define_function): Likewise.
9373
9374 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9375
9376         * macrocmd.c (extract_identifier): Return
9377         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9378         callers.
9379
9380 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9381
9382         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9383
9384 2019-02-05  Tom Tromey  <tom@tromey.com>
9385
9386         * target.c (target_stack::unpush): Move assertion earlier.
9387
9388 2019-01-30  Tom Tromey  <tom@tromey.com>
9389
9390         PR python/23615:
9391         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9392         (gdbpy_parse_and_eval): Likewise.
9393         * python/python-internal.h (gdbpy_allow_threads): New class.
9394
9395 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9396
9397         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9398         (aarch64_fbsd_fpregmap): Move earlier.
9399         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9400         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9401         instead of individual calls to trad_frame_set_reg_addr.
9402         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9403         earlier.
9404         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9405         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9406         instead of individual calls to trad_frame_set_reg_addr.
9407
9408 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9409
9410         * CONTRIBUTE: Replace contribution list with wiki link.
9411
9412 2019-01-25  Tom Tromey  <tom@tromey.com>
9413
9414         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9415
9416 2019-01-25  Tom Tromey  <tom@tromey.com>
9417
9418         * xtensa-linux-nat.c: Fix common/ includes.
9419         * xml-support.h: Fix common/ includes.
9420         * xml-support.c: Fix common/ includes.
9421         * x86-linux-nat.c: Fix common/ includes.
9422         * windows-nat.c: Fix common/ includes.
9423         * varobj.h: Fix common/ includes.
9424         * varobj.c: Fix common/ includes.
9425         * value.c: Fix common/ includes.
9426         * valops.c: Fix common/ includes.
9427         * utils.c: Fix common/ includes.
9428         * unittests/xml-utils-selftests.c: Fix common/ includes.
9429         * unittests/utils-selftests.c: Fix common/ includes.
9430         * unittests/unpack-selftests.c: Fix common/ includes.
9431         * unittests/tracepoint-selftests.c: Fix common/ includes.
9432         * unittests/style-selftests.c: Fix common/ includes.
9433         * unittests/string_view-selftests.c: Fix common/ includes.
9434         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9435         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9436         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9437         * unittests/rsp-low-selftests.c: Fix common/ includes.
9438         * unittests/parse-connection-spec-selftests.c: Fix common/
9439         includes.
9440         * unittests/optional-selftests.c: Fix common/ includes.
9441         * unittests/offset-type-selftests.c: Fix common/ includes.
9442         * unittests/observable-selftests.c: Fix common/ includes.
9443         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9444         * unittests/memrange-selftests.c: Fix common/ includes.
9445         * unittests/memory-map-selftests.c: Fix common/ includes.
9446         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9447         * unittests/function-view-selftests.c: Fix common/ includes.
9448         * unittests/environ-selftests.c: Fix common/ includes.
9449         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9450         * unittests/common-utils-selftests.c: Fix common/ includes.
9451         * unittests/cli-utils-selftests.c: Fix common/ includes.
9452         * unittests/array-view-selftests.c: Fix common/ includes.
9453         * ui-file.c: Fix common/ includes.
9454         * tui/tui-io.c: Fix common/ includes.
9455         * tracepoint.h: Fix common/ includes.
9456         * tracepoint.c: Fix common/ includes.
9457         * tracefile-tfile.c: Fix common/ includes.
9458         * top.h: Fix common/ includes.
9459         * top.c: Fix common/ includes.
9460         * thread.c: Fix common/ includes.
9461         * target/waitstatus.h: Fix common/ includes.
9462         * target/waitstatus.c: Fix common/ includes.
9463         * target.h: Fix common/ includes.
9464         * target.c: Fix common/ includes.
9465         * target-memory.c: Fix common/ includes.
9466         * target-descriptions.c: Fix common/ includes.
9467         * symtab.h: Fix common/ includes.
9468         * symfile.c: Fix common/ includes.
9469         * stap-probe.c: Fix common/ includes.
9470         * spu-linux-nat.c: Fix common/ includes.
9471         * sparc-nat.c: Fix common/ includes.
9472         * source.c: Fix common/ includes.
9473         * solib.c: Fix common/ includes.
9474         * solib-target.c: Fix common/ includes.
9475         * ser-unix.c: Fix common/ includes.
9476         * ser-tcp.c: Fix common/ includes.
9477         * ser-pipe.c: Fix common/ includes.
9478         * ser-base.c: Fix common/ includes.
9479         * selftest-arch.c: Fix common/ includes.
9480         * s12z-tdep.c: Fix common/ includes.
9481         * rust-exp.y: Fix common/ includes.
9482         * rs6000-aix-tdep.c: Fix common/ includes.
9483         * riscv-tdep.c: Fix common/ includes.
9484         * remote.c: Fix common/ includes.
9485         * remote-notif.h: Fix common/ includes.
9486         * remote-fileio.h: Fix common/ includes.
9487         * remote-fileio.c: Fix common/ includes.
9488         * regcache.h: Fix common/ includes.
9489         * regcache.c: Fix common/ includes.
9490         * record-btrace.c: Fix common/ includes.
9491         * python/python.c: Fix common/ includes.
9492         * python/py-type.c: Fix common/ includes.
9493         * python/py-inferior.c: Fix common/ includes.
9494         * progspace.h: Fix common/ includes.
9495         * producer.c: Fix common/ includes.
9496         * procfs.c: Fix common/ includes.
9497         * proc-api.c: Fix common/ includes.
9498         * printcmd.c: Fix common/ includes.
9499         * ppc-linux-nat.c: Fix common/ includes.
9500         * parser-defs.h: Fix common/ includes.
9501         * osdata.c: Fix common/ includes.
9502         * obsd-nat.c: Fix common/ includes.
9503         * nat/x86-linux.c: Fix common/ includes.
9504         * nat/x86-linux-dregs.c: Fix common/ includes.
9505         * nat/x86-dregs.h: Fix common/ includes.
9506         * nat/x86-dregs.c: Fix common/ includes.
9507         * nat/ppc-linux.c: Fix common/ includes.
9508         * nat/mips-linux-watch.h: Fix common/ includes.
9509         * nat/mips-linux-watch.c: Fix common/ includes.
9510         * nat/linux-waitpid.c: Fix common/ includes.
9511         * nat/linux-ptrace.h: Fix common/ includes.
9512         * nat/linux-ptrace.c: Fix common/ includes.
9513         * nat/linux-procfs.c: Fix common/ includes.
9514         * nat/linux-personality.c: Fix common/ includes.
9515         * nat/linux-osdata.c: Fix common/ includes.
9516         * nat/linux-namespaces.c: Fix common/ includes.
9517         * nat/linux-btrace.h: Fix common/ includes.
9518         * nat/linux-btrace.c: Fix common/ includes.
9519         * nat/fork-inferior.c: Fix common/ includes.
9520         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9521         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9522         * nat/aarch64-linux.c: Fix common/ includes.
9523         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9524         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9525         * namespace.h: Fix common/ includes.
9526         * mips-linux-tdep.c: Fix common/ includes.
9527         * minsyms.c: Fix common/ includes.
9528         * mi/mi-parse.h: Fix common/ includes.
9529         * mi/mi-main.c: Fix common/ includes.
9530         * mi/mi-cmd-env.c: Fix common/ includes.
9531         * memrange.h: Fix common/ includes.
9532         * memattr.c: Fix common/ includes.
9533         * maint.h: Fix common/ includes.
9534         * maint.c: Fix common/ includes.
9535         * main.c: Fix common/ includes.
9536         * machoread.c: Fix common/ includes.
9537         * location.c: Fix common/ includes.
9538         * linux-thread-db.c: Fix common/ includes.
9539         * linux-nat.c: Fix common/ includes.
9540         * linux-fork.c: Fix common/ includes.
9541         * inline-frame.c: Fix common/ includes.
9542         * infrun.c: Fix common/ includes.
9543         * inflow.c: Fix common/ includes.
9544         * inferior.h: Fix common/ includes.
9545         * inferior.c: Fix common/ includes.
9546         * infcmd.c: Fix common/ includes.
9547         * inf-ptrace.c: Fix common/ includes.
9548         * inf-child.c: Fix common/ includes.
9549         * ia64-linux-nat.c: Fix common/ includes.
9550         * i387-tdep.c: Fix common/ includes.
9551         * i386-tdep.c: Fix common/ includes.
9552         * i386-linux-tdep.c: Fix common/ includes.
9553         * i386-linux-nat.c: Fix common/ includes.
9554         * i386-go32-tdep.c: Fix common/ includes.
9555         * i386-fbsd-tdep.c: Fix common/ includes.
9556         * i386-fbsd-nat.c: Fix common/ includes.
9557         * guile/scm-type.c: Fix common/ includes.
9558         * guile/guile.c: Fix common/ includes.
9559         * go32-nat.c: Fix common/ includes.
9560         * gnu-nat.c: Fix common/ includes.
9561         * gdbthread.h: Fix common/ includes.
9562         * gdbarch-selftests.c: Fix common/ includes.
9563         * gdb_usleep.c: Fix common/ includes.
9564         * gdb_select.h: Fix common/ includes.
9565         * gdb_bfd.c: Fix common/ includes.
9566         * gcore.c: Fix common/ includes.
9567         * fork-child.c: Fix common/ includes.
9568         * findvar.c: Fix common/ includes.
9569         * fbsd-nat.c: Fix common/ includes.
9570         * event-top.c: Fix common/ includes.
9571         * event-loop.c: Fix common/ includes.
9572         * dwarf2read.c: Fix common/ includes.
9573         * dwarf2loc.c: Fix common/ includes.
9574         * dwarf2-frame.c: Fix common/ includes.
9575         * dwarf-index-cache.c: Fix common/ includes.
9576         * dtrace-probe.c: Fix common/ includes.
9577         * disasm-selftests.c: Fix common/ includes.
9578         * defs.h: Fix common/ includes.
9579         * csky-tdep.c: Fix common/ includes.
9580         * cp-valprint.c: Fix common/ includes.
9581         * cp-support.h: Fix common/ includes.
9582         * cp-support.c: Fix common/ includes.
9583         * corelow.c: Fix common/ includes.
9584         * completer.h: Fix common/ includes.
9585         * completer.c: Fix common/ includes.
9586         * compile/compile.c: Fix common/ includes.
9587         * compile/compile-loc2c.c: Fix common/ includes.
9588         * compile/compile-cplus-types.c: Fix common/ includes.
9589         * compile/compile-cplus-symbols.c: Fix common/ includes.
9590         * command.h: Fix common/ includes.
9591         * cli/cli-dump.c: Fix common/ includes.
9592         * cli/cli-cmds.c: Fix common/ includes.
9593         * charset.c: Fix common/ includes.
9594         * build-id.c: Fix common/ includes.
9595         * btrace.h: Fix common/ includes.
9596         * btrace.c: Fix common/ includes.
9597         * breakpoint.h: Fix common/ includes.
9598         * breakpoint.c: Fix common/ includes.
9599         * ax.h:
9600         (enum agent_op): Fix common/ includes.
9601         * ax-general.c (struct aop_map): Fix common/ includes.
9602         * ax-gdb.c: Fix common/ includes.
9603         * auxv.c: Fix common/ includes.
9604         * auto-load.c: Fix common/ includes.
9605         * arm-tdep.c: Fix common/ includes.
9606         * arch/riscv.c: Fix common/ includes.
9607         * arch/ppc-linux-common.c: Fix common/ includes.
9608         * arch/i386.c: Fix common/ includes.
9609         * arch/arm.c: Fix common/ includes.
9610         * arch/arm-linux.c: Fix common/ includes.
9611         * arch/arm-get-next-pcs.c: Fix common/ includes.
9612         * arch/amd64.c: Fix common/ includes.
9613         * arch/aarch64.c: Fix common/ includes.
9614         * arch/aarch64-insn.c: Fix common/ includes.
9615         * arch-utils.c: Fix common/ includes.
9616         * amd64-windows-tdep.c: Fix common/ includes.
9617         * amd64-tdep.c: Fix common/ includes.
9618         * amd64-sol2-tdep.c: Fix common/ includes.
9619         * amd64-obsd-tdep.c: Fix common/ includes.
9620         * amd64-nbsd-tdep.c: Fix common/ includes.
9621         * amd64-linux-tdep.c: Fix common/ includes.
9622         * amd64-linux-nat.c: Fix common/ includes.
9623         * amd64-fbsd-tdep.c: Fix common/ includes.
9624         * amd64-fbsd-nat.c: Fix common/ includes.
9625         * amd64-dicos-tdep.c: Fix common/ includes.
9626         * amd64-darwin-tdep.c: Fix common/ includes.
9627         * agent.c: Fix common/ includes.
9628         * ada-lang.h: Fix common/ includes.
9629         * ada-lang.c: Fix common/ includes.
9630         * aarch64-tdep.c: Fix common/ includes.
9631
9632 2019-01-25  Tom Tromey  <tom@tromey.com>
9633
9634         * common/create-version.sh: Use common/version.h.
9635
9636 2019-01-24  Pedro Alves  <palves@redhat.com>
9637
9638         * infrun.c (signal_stop, signal_print, signal_program)
9639         (signal_catch, signal_pass): Now arrays instead of pointers.
9640         (update_signals_program_target, do_target_resume)
9641         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9642         * linux-nat.c (linux_nat_target::pass_signals)
9643         (linux_nat_target::create_inferior, linux_nat_target::attach):
9644         Adjust.
9645         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9646         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9647         * procfs.c (procfs_target::pass_signals): Adjust.
9648         * record-full.c (record_full_target::resume): Adjust.
9649         * remote.c (remote_target::pass_signals)
9650         (remote_target::program_signals): Adjust.
9651         * target-debug.h (target_debug_print_signals): Now takes a
9652         gdb::array_view as parameter.  Adjust.
9653         * target.h (target_ops) <pass_signals, program_signals>: Replace
9654         pointer and length parameters with gdb::array_view.
9655         (target_pass_signals, target_program_signals): Likewise.
9656         * target-delegates.c: Regenerate.
9657
9658 2019-01-24  Pedro Alves  <palves@redhat.com>
9659
9660         * common/forward-scope-exit.h
9661         (forward_scope_exit::forward_scope_exit): Pass arguments to
9662         m_bind_function directly, instead of creating a std::bind and
9663         copying that.
9664
9665 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9666
9667         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9668         for static members.
9669         (pass_in_v_vfp_candidate): Likewise.
9670
9671 2019-01-23  Tom Tromey  <tom@tromey.com>
9672             Pedro Alves  <palves@redhat.com>
9673
9674         * regcache.c (class regcache_invalidator): Remove.
9675         (regcache::raw_write): Use make_scope_exit.
9676
9677 2019-01-23  Tom Tromey  <tom@tromey.com>
9678
9679         * ui-out.h (class ui_out_emit_type): Update comment.
9680
9681 2019-01-23  Tom Tromey  <tom@tromey.com>
9682
9683         * infrun.c (fetch_inferior_event): Update comment.
9684
9685 2019-01-23  Tom Tromey  <tom@tromey.com>
9686             Pedro Alves  <palves@redhat.com>
9687
9688         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9689         parameter.
9690         (fetch_inferior_event): Use SCOPE_EXIT.
9691
9692
9693 2019-01-23  Tom Tromey  <tom@tromey.com>
9694             Pedro Alves  <palves@redhat.com>
9695
9696         * infrun.c (disable_thread_events): Delete.
9697         (stop_all_threads): Use SCOPE_EXIT.
9698
9699 2019-01-23  Tom Tromey  <tom@tromey.com>
9700             Pedro Alves  <palves@redhat.com>
9701
9702         * symfile.c: Include forward-scope-exit.h.
9703         (clear_symtab_users_cleanup): Replace forward declaration with
9704         a FORWARD_SCOPE_EXIT.
9705         (syms_from_objfile_1): Use the forward_scope_exit and
9706         gdb::optional instead of cleanup_function.
9707         (reread_symbols): Use the forward_scope_exit instead of
9708         cleanup_function.
9709         (clear_symtab_users_cleanup): Remove function.
9710
9711 2019-01-23  Tom Tromey  <tom@tromey.com>
9712             Pedro Alves  <palves@redhat.com>
9713
9714         * linux-nat.c: Include scope-exit.h.
9715         (cleanup_target_stop): Remove.
9716         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9717         SCOPE_EXIT.
9718
9719 2019-01-23  Tom Tromey  <tom@tromey.com>
9720             Pedro Alves  <palves@redhat.com>
9721
9722         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9723         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9724
9725 2019-01-23  Tom Tromey  <tom@tromey.com>
9726             Andrew Burgess  <andrew.burgess@embecosm.com>
9727             Pedro Alves  <palves@redhat.com>
9728
9729         * infrun.c (fetch_inferior_event): Use scope_exit.
9730         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9731         * top.c (execute_command): Use scope_exit.
9732         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9733         * utils.c (do_bpstat_clear_actions_cleanup)
9734         (make_bpstat_clear_actions_cleanup): Remove.
9735
9736 2019-01-23  Tom Tromey  <tom@tromey.com>
9737             Pedro Alves  <palves@redhat.com>
9738
9739         * infrun.c: Include "common/scope-exit.h"
9740         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9741         (wait_for_inferior): Use SCOPE_EXIT.
9742         (fetch_inferior_event): Use scope_exit.
9743
9744 2019-01-23  Tom Tromey  <tom@tromey.com>
9745             Pedro Alves  <palves@redhat.com>
9746
9747         * breakpoint.c (create_breakpoint): Remove cleanup.
9748
9749 2019-01-23  Tom Tromey  <tom@tromey.com>
9750             Andrew Burgess  <andrew.burgess@embecosm.com>
9751             Pedro Alves  <palves@redhat.com>
9752
9753 2019-01-23  Pedro Alves  <palves@redhat.com>
9754
9755         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9756
9757 2019-01-23  Pedro Alves  <palves@redhat.com>
9758             Andrew Burgess  <andrew.burgess@embecosm.com>
9759
9760         * gdbthread.h: Include "common/forward-scope-exit.h".
9761         (scoped_finish_thread_state): Redefine custom class in terms of
9762         forward_scope_exit.
9763
9764 2019-01-23  Pedro Alves  <palves@redhat.com>
9765             Andrew Burgess  <andrew.burgess@embecosm.com>
9766
9767         * common/forward-scope-exit.h: New file.
9768
9769 2019-01-23  Pedro Alves  <palves@redhat.com>
9770             Andrew Burgess  <andrew.burgess@embecosm.com>
9771             Tom Tromey  <tom@tromey.com>
9772
9773         * common/scope-exit.h: New file.
9774
9775 2019-01-23  Pedro Alves  <palves@redhat.com>
9776
9777         * common/preprocessor.h (ESC): Rename to ...
9778         (ESC_PARENS): ... this.
9779         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9780         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9781
9782 2019-01-23  Tom Tromey  <tom@tromey.com>
9783
9784         * language.h (class scoped_switch_to_sym_language_if_auto):
9785         Initialize m_lang in both cases.
9786
9787 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9788
9789         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9790         with XCNEW.
9791
9792 2019-01-22  Tom Tromey  <tom@tromey.com>
9793
9794         * corelow.c: Do not include sys/file.h.
9795
9796 2019-01-22  Tom Tromey  <tom@tromey.com>
9797
9798         * tui/tui-wingeneral.h: Include gdb_curses.h.
9799
9800 2019-01-22  Tom Tromey  <tom@tromey.com>
9801
9802         * source-cache.h (class source_cache) <get_source_lines,
9803         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9804
9805 2019-01-22  Tom Tromey  <tom@tromey.com>
9806
9807         * remote-fileio.h (struct remote_target): Declare.
9808
9809 2019-01-22  Tom Tromey  <tom@tromey.com>
9810
9811         * python/py-arch.c: Do not include py-ref.h.
9812         * python/py-bpevent.c: Do not include py-ref.h.
9813         * python/py-cmd.c: Do not include py-ref.h.
9814         * python/py-continueevent.c: Do not include py-ref.h.
9815         * python/py-event.h: Do not include py-ref.h.
9816         * python/py-evtregistry.c: Do not include py-ref.h.
9817         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9818         * python/py-frame.c: Do not include py-ref.h.
9819         * python/py-framefilter.c: Do not include py-ref.h.
9820         * python/py-function.c: Do not include py-ref.h.
9821         * python/py-infevents.c: Do not include py-ref.h.
9822         * python/py-linetable.c: Do not include py-ref.h.
9823         * python/py-objfile.c: Do not include py-ref.h.
9824         * python/py-param.c: Do not include py-ref.h.
9825         * python/py-prettyprint.c: Do not include py-ref.h.
9826         * python/py-progspace.c: Do not include py-ref.h.
9827         * python/py-symbol.c: Do not include py-ref.h.
9828         * python/py-symtab.c: Do not include py-ref.h.
9829         * python/py-type.c: Do not include py-ref.h.
9830         * python/py-unwind.c: Do not include py-ref.h.
9831         * python/py-utils.c: Do not include py-ref.h.
9832         * python/py-value.c: Do not include py-ref.h.
9833         * python/py-varobj.c: Do not include py-ref.h.
9834         * python/py-xmethods.c: Do not include py-ref.h.
9835         * python/python.c: Do not include py-ref.h.
9836         * varobj.c: Do not include py-ref.h.
9837
9838 2019-01-22  Tom Tromey  <tom@tromey.com>
9839
9840         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9841         keyword for bcache.
9842
9843 2019-01-22  Tom Tromey  <tom@tromey.com>
9844
9845         * compile/compile-cplus-types.c: Remove a comment by #include.
9846
9847 2019-01-22  Tom Tromey  <tom@tromey.com>
9848
9849         * compile/gcc-c-plugin.h: Include compile-internal.h.
9850
9851 2019-01-22  Tom Tromey  <tom@tromey.com>
9852
9853         * stabsread.c (EXTERN): Do not define.
9854         (symnum, next_symbol_text_func, processing_gcc_compilation)
9855         (within_function, global_sym_chain, global_stabs)
9856         (previous_stab_code, this_object_header_files)
9857         (n_this_object_header_files)
9858         (n_allocated_this_object_header_files): Define.
9859         * stabsread.h (EXTERN): Never define.  Use "extern".
9860
9861 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9862
9863         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9864         history_value.
9865
9866 2019-01-21  Tom Tromey  <tom@tromey.com>
9867
9868         * ui-out.c: Fix includes.
9869         * tui/tui-source.c: Fix includes.
9870         * target.c: Fix includes.
9871         * remote.c: Fix includes.
9872         * regcache.c: Fix includes.
9873         * python/py-block.c: Fix includes.
9874         * printcmd.c: Fix includes.
9875         * or1k-tdep.c: Fix includes.
9876         * mi/mi-main.c: Fix includes.
9877         * m32r-tdep.c: Fix includes.
9878         * csky-tdep.c: Fix includes.
9879         * compile/compile-cplus-types.c: Fix includes.
9880         * cli/cli-interp.c: Fix includes.
9881
9882 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9883
9884         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9885         for padding.
9886
9887 2019-01-16  Tom Tromey  <tom@tromey.com>
9888
9889         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9890         earlier.
9891         (struct objfile) <msymbols_range>: Move from top level.
9892         <msymbols>: New method.
9893         (class objfile_msymbols): Remove.
9894         * symtab.c (default_collect_symbol_completion_matches_break_on):
9895         Update.
9896         * symmisc.c (dump_msymbols): Update.
9897         * stabsread.c (scan_file_globals): Update.
9898         * objc-lang.c (info_selectors_command, info_classes_command)
9899         (find_methods): Update.
9900         * minsyms.c (find_solib_trampoline_target): Update.
9901         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9902         * coffread.c (coff_symfile_read): Update.
9903         * ada-lang.c (ada_lookup_simple_minsym)
9904         (ada_collect_symbol_completion_matches): Update.
9905
9906 2019-01-16  Tom Tromey  <tom@tromey.com>
9907
9908         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9909         type.  Remove no-argument constructor.
9910         <iterator::operator++>: Simplify.
9911         <begin>: Update.
9912         <end>: Use minimal_symbol_count.
9913
9914 2019-01-16  Tom Tromey  <tom@tromey.com>
9915
9916         * objfiles.h (struct objfile) <psymtabs>: New method.
9917         (class objfile_psymtabs): Remove.
9918         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9919         typedef.
9920         <range>: New method.
9921         (require_partial_symbols): Change return type.
9922         * psymtab.c (require_partial_symbols)
9923         (psym_expand_symtabs_matching): Update.
9924         * mdebugread.c (parse_partial_symbols): Update.
9925         * dbxread.c (dbx_end_psymtab): Update.
9926
9927 2019-01-15  Tom Tromey  <tom@tromey.com>
9928
9929         * symtab.c (lookup_objfile_from_block)
9930         (lookup_symbol_in_objfile_symtabs)
9931         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9932         (find_line_symtab, info_sources_command)
9933         (default_collect_symbol_completion_matches_break_on)
9934         (make_source_files_completion_list): Update.
9935         * symmisc.c (print_objfile_statistics, dump_objfile)
9936         (maintenance_print_symbols, maintenance_info_symtabs)
9937         (maintenance_check_symtabs, maintenance_info_line_tables):
9938         Update.
9939         * source.c (select_source_symtab)
9940         (forget_cached_source_info_for_objfile): Update.
9941         * objfiles.h (class objfile_compunits): Remove.
9942         (struct objfile) <compunits_range>: New typedef.
9943         (compunits): New method.
9944         * objfiles.c (objfile_relocate1): Update.
9945         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9946         * maint.c (count_symtabs_and_blocks): Update.
9947         * linespec.c (iterate_over_all_matching_symtabs): Update.
9948         * cp-support.c (add_symbol_overload_list_qualified): Update.
9949         * coffread.c (coff_symtab_read): Update.
9950         * ada-lang.c (add_nonlocal_symbols)
9951         (ada_collect_symbol_completion_matches)
9952         (ada_add_global_exceptions): Update.
9953
9954 2019-01-15  Tom Tromey  <tom@tromey.com>
9955
9956         * progspace.h (program_space) <objfiles_safe_range>: New
9957         typedef.
9958         <objfiles_safe>: New method.
9959         * objfiles.h (class all_objfiles_safe): Remove.
9960         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9961         * jit.c (jit_inferior_exit_hook): Update.
9962
9963 2019-01-17  Tom Tromey  <tom@tromey.com>
9964
9965         * progspace.h (program_space) <objfiles_range>: New typedef.
9966         <objfiles>: New method.
9967         <objfiles_head>: Rename from objfiles.
9968         (object_files): Update.
9969         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9970         * guile/scm-pretty-print.c
9971         (ppscm_find_pretty_printer_from_objfiles): Update.
9972         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9973         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9974         Update.
9975         * python/py-progspace.c (pspy_get_objfiles): Update.
9976         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9977         Update.
9978         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9979         (objfpy_lookup_objfile_by_build_id): Update.
9980         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9981         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9982         Update.
9983         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9984         (expand_symtab_containing_pc, lookup_objfile_from_block)
9985         (lookup_static_symbol, basic_lookup_transparent_type)
9986         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9987         (find_line_symtab, info_sources_command)
9988         (default_collect_symbol_completion_matches_break_on)
9989         (make_source_files_completion_list, find_main_name): Update.
9990         * symmisc.c (print_symbol_bcache_statistics)
9991         (print_objfile_statistics, maintenance_print_symbols)
9992         (maintenance_print_msymbols, maintenance_print_objfiles)
9993         (maintenance_info_symtabs, maintenance_check_symtabs)
9994         (maintenance_expand_symtabs, maintenance_info_line_tables):
9995         Update.
9996         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9997         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9998         (map_overlay_command, unmap_overlay_command)
9999         (simple_overlay_update, expand_symtabs_matching)
10000         (map_symbol_filenames): Update.
10001         * symfile-debug.c (set_debug_symfile): Update.
10002         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10003         Update.
10004         * source.c (select_source_symtab, forget_cached_source_info):
10005         Update.
10006         * solib.c (solib_read_symbols): Update.
10007         * solib-spu.c (append_ocl_sos): Update.
10008         * psymtab.c (maintenance_print_psymbols)
10009         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10010         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10011         * printcmd.c (info_symbol_command): Update.
10012         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10013         Update.
10014         * objfiles.h (class all_objfiles): Remove.
10015         * objfiles.c (have_partial_symbols, have_full_symbols)
10016         (have_minimal_symbols, qsort_cmp, update_section_map)
10017         (shared_objfile_contains_address_p)
10018         (default_iterate_over_objfiles_in_search_order): Update.
10019         * objc-lang.c (info_selectors_command, info_classes_command)
10020         (find_methods): Update.
10021         * minsyms.c (find_solib_trampoline_target): Update.
10022         * maint.c (maintenance_info_sections)
10023         (maintenance_translate_address, count_symtabs_and_blocks):
10024         Update.
10025         * main.c (captured_main_1): Update.
10026         * linux-thread-db.c (try_thread_db_load_from_pdir)
10027         (has_libpthread): Update.
10028         * linespec.c (iterate_over_all_matching_symtabs)
10029         (search_minsyms_for_name): Update.
10030         * jit.c (jit_find_objf_with_entry_addr): Update.
10031         * hppa-tdep.c (find_unwind_entry)
10032         (hppa_lookup_stub_minimal_symbol): Update.
10033         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10034         Update.
10035         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10036         (elf_gnu_ifunc_resolve_by_got): Update.
10037         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10038         * dwarf-index-write.c (save_gdb_index_command): Update.
10039         * cp-support.c (add_symbol_overload_list_qualified): Update.
10040         * breakpoint.c (create_overlay_event_breakpoint)
10041         (create_longjmp_master_breakpoint)
10042         (create_std_terminate_master_breakpoint)
10043         (create_exception_master_breakpoint): Update.
10044         * blockframe.c (find_pc_partial_function): Update.
10045         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10046         (ada_collect_symbol_completion_matches)
10047         (ada_add_global_exceptions): Update.
10048
10049 2019-01-17  Tom Tromey  <tom@tromey.com>
10050
10051         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10052         declare VEC.
10053         (solib_target_parse_libraries): Change return type.
10054         (library_list_start_segment, library_list_start_section)
10055         (library_list_end_library, library_list_start_library); Update.
10056         (solib_target_free_library_list): Remove.
10057         (solib_target_parse_libraries): Remove cleanup.  Change return
10058         type.
10059         (solib_target_current_sos): Update.
10060
10061 2019-01-17  Tom Tromey  <tromey@bapiya>
10062
10063         * valprint.c: Replace "the the" with "the".
10064         * symtab.c: Replace "the the" with "the".
10065         * solib.c: Replace "the the" with "the".
10066         * solib-dsbt.c: Replace "the the" with "the".
10067         * linespec.c: Replace "the the" with "the".
10068         * dwarf2loc.h: Replace "the the" with "the".
10069         * amd64-windows-tdep.c: Replace "the the" with "the".
10070         * aarch64-tdep.c: Replace "the the" with "the".
10071
10072 2019-01-16  Keith Seitz  <keiths@redhat.com>
10073
10074         PR gdb/23773
10075         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10076         <builder>: Rename to ..
10077         <m_builder>: ... this and make private.
10078         (dwarf2_cu::get_builder): New method.  Change all users of
10079         `builder' to use this method.
10080         (dwarf2_start_symtab): Move to ...
10081         (dwarf2_cu::start_symtab): ... here.  Update all callers
10082         (setup_type_unit_groups): Move to ...
10083         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10084         callers.
10085         (dwarf2_cu::reset_builder): New method.
10086         (process_full_compunit, process_full_type_unit): Use
10087         dwarf2_cu::reset_builder.
10088         (follow_die_offset): Record the ancestor CU if it is different
10089         from the followed DIE's CU.
10090         (follow_die_sig_1): Likewise.
10091
10092 2019-01-15  Tom Tromey  <tom@tromey.com>
10093
10094         * remote.c (class remote_state) <buf>: Now a char_vector.
10095         <buf_size>: Remove.
10096         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10097         parameter.
10098         (remote_target::getpkt_or_notif_sane_1)
10099         (remote_target::getpkt_sane)
10100         (remote_target::getpkt_or_notif_sane): Likewise.
10101         (class remote_target) <putpkt>: New overload.
10102         (remote_target::read_frame): Change type of "buf_p".  Remove
10103         sizeof_p parameter.
10104         (packet_ok): New overload.
10105         (packet_check_result): New overload.
10106         Update all uses.
10107
10108 2019-01-14  Tom Tromey  <tom@tromey.com>
10109
10110         * remote-notif.c (handle_notification, remote_notif_ack)
10111         (remote_notif_parse): Make "buf" const.
10112         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10113         const.
10114         (remote_notif_parse, remote_notif_ack, handle_notification):
10115         Likewise.
10116         * remote.c (remote_notif_stop_parse): Make "buf" const.
10117         (remote_target::remote_parse_stop_reply): Make "buf" const.
10118         (remote_notif_stop_ack): Make "buf" const.
10119
10120 2019-01-14  Tom Tromey  <tom@tromey.com>
10121
10122         * remote.c (remote_console_output): Make parameter const.
10123
10124 2019-01-14  Tom Tromey  <tom@tromey.com>
10125
10126         * target-debug.h (target_debug_print_signals): Constify.
10127         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10128         * procfs.c (procfs_target::pass_signals): Update.
10129         * linux-nat.c (linux_nat_target::pass_signals): Update.
10130         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10131         * target-delegates.c: Rebuild.
10132         * remote.c (remote_target::program_signals): Update.
10133         (remote_target::pass_signals): Update.
10134         * target.c (target_pass_signals): Constify argument.
10135         (target_program_signals): Likewise.
10136         * target.h (struct target_ops) <pass_signals, program_signals>:
10137         Constify argument.
10138         (target_pass_signals, target_program_signals): Constify argument.
10139
10140 2019-01-14  Tom Tromey  <tom@tromey.com>
10141
10142         PR tui/28819:
10143         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10144
10145 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10146
10147         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10148         field.
10149         * rs6000-tdep.c: Include reggroups.h.
10150         (IS_V_ALIAS_PSEUDOREG): Define.
10151         (rs6000_register_name): Return names for the "vX" aliases.
10152         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10153         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10154         aliases.  Call default_register_reggroup_p for all other
10155         pseudo-registers.
10156         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10157         New functions.
10158         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10159         Handle "vX" aliases.
10160         (v_alias_pseudo_register_collect): New function.
10161         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10162         (rs6000_gdbarch_init): Initialize "vX" aliases as
10163         pseudo-registers.  Restore registration of
10164         rs6000_pseudo_register_reggroup_p with
10165         set_tdesc_pseudo_register_reggroup_p.
10166
10167 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10168
10169         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10170         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10171         set_gdbarch_num_pseudo_regs.
10172
10173 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10174
10175         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10176         Remove arg prefixname, add do_set and do_show.
10177         Add member functions set_list and show_list.
10178         * cli/cli-style.c (class cli_style_option): Update accordingly.
10179         (style_set_list): Move to file scope.
10180         (style_show_list): Likewise.
10181         (set_style): Call help_list.
10182         (show_style): Call cmd_show_list.
10183         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10184         Update to use the new macro.
10185
10186 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10187
10188         * ada-lang.c (_initialize_ada_language): Expand the help text
10189         for the "catch exception" command.
10190
10191 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10192
10193         * symtab.c (matching_obj_sections): Initialize obj,
10194         declare it closer to its usage.
10195
10196 2019-01-10  Tom Tromey  <tom@tromey.com>
10197
10198         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10199         (basic_inf_threads_range): Remove.
10200         (inf_threads_range, inf_non_exited_threads_range)
10201         (safe_inf_threads_range): Use next_adapter.
10202
10203 2019-01-10  Keith Seitz  <keiths@redhat.com>
10204
10205         PR gdb/23712
10206         PR symtab/23010
10207         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10208         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10209
10210 2019-01-10  Keith Seitz  <keiths@redhat.com>
10211
10212         PR gdb/23712
10213         PR symtab/23010
10214         * dictionary.c (pending_to_vector): Remove.
10215         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10216         Remove _1 suffix, replacing functions of the same name.  Update
10217         all callers.
10218         (dict_create_hashed, dict_create_hashed_expandable)
10219         (dict_create_linear, dict_create_linear_expandable, dict_free)
10220         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10221         Make functions static.
10222
10223 2019-01-10  Keith Seitz  <keiths@redhat.com>
10224
10225         PR gdb/23712
10226         PR symtab/23010
10227         * dictionary.h (struct dictionary): Replace declaration with
10228         multidictionary.
10229         (dict_create_hashed, dict_create_hashed_expandable)
10230         (dict_create_linear, dict_create_linear_expandable)
10231         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10232         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10233         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10234         taking multidictionary argument.
10235         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10236         * block.h (struct block) <dict>: Change to multidictionary
10237         and rename `multidict'.
10238         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10239         symmisc.c: Update all dictionary references to multidictionary.
10240
10241 2019-01-10  Keith Seitz  <keiths@redhat.com>
10242
10243         PR gdb/23712
10244         PR symtab/23010
10245         * dictionary.c: Include unordered_map.
10246         (pending_to_vector): New function.
10247         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10248         Rewrite the non-"_1" functions to take vector instead
10249         of linked list.
10250         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10251         "new" _1 versions of the same name.
10252         (multidictionary): Define.
10253         (std::hash<enum language): New definition.
10254         (collate_pending_symbols_by_language, mdict_create_hashed)
10255         (mdict_create_hashed_expandable, mdict_create_linear)
10256         (mdict_create_linear_expandable, mdict_free)
10257         (find_language_dictionary, create_new_language_dictionary)
10258         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10259         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10260         (mdict_size, mdict_empty): New functions.
10261         * dictionary.h (mdict_iterator): Define.
10262
10263 2019-01-10  Pedro Alves  <palves@redhat.com>
10264
10265         * breakpoint.c (read_uploaded_action)
10266         (create_tracepoint_from_upload): Adjust to use
10267         gdb::unique_xmalloc_ptr.
10268         * ctf.c (ctf_write_uploaded_tp):
10269         (SET_ARRAY_FIELD): Use emplace_back.
10270         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10271         * tracefile-tfile.c (tfile_write_uploaded_tp):
10272         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10273         gdb::unique_xmalloc_ptr.
10274         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10275         at_string, cond_string, cmd_strings>: Replace char pointers
10276         with gdb::unique_xmalloc_ptr.
10277
10278 2019-01-10  Pedro Alves  <palves@redhat.com>
10279
10280         * solib-target.c (library_list_start_library): Don't xstrdup name.
10281
10282 2019-01-10  Pedro Alves  <palves@redhat.com>
10283
10284         * mdebugread.c (parse_partial_symbols): Use
10285         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10286
10287 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10288
10289         * linux-fork.c (scoped_switch_fork_info)
10290         <~scoped_switch_fork_info>: Fix incorrect variable name.
10291
10292 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10293
10294         * linux-fork.c (scoped_switch_fork_info)
10295         <scoped_switch_fork_info>: Make explicit.
10296         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10297
10298 2019-01-10  Tom Tromey  <tom@tromey.com>
10299
10300         * objfiles.h (objfile::reset_psymtabs): Update.
10301         * objfiles.c (objfile::objfile): Update.
10302         * psymtab.h (psymtab_storage::obstack): Update.
10303         (psymtab_storage::m_obstack): Use gdb::optional.
10304         (class psymtab_storage): Update comment.  Remove objfile
10305         parameter.
10306         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10307
10308 2019-01-10  Tom Tromey  <tom@tromey.com>
10309
10310         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10311         <free_psymtabs>: Now private.
10312         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10313         (allocate_psymtab): Use new method.
10314
10315 2019-01-10  Tom Tromey  <tom@tromey.com>
10316
10317         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10318         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10319         * mdebugread.c (parse_partial_symbols): Use
10320         allocate_dependencies.
10321         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10322         allocate_dependencies.
10323         (process_psymtab_comp_unit_reader)
10324         (build_type_psymtab_dependencies): Likewise.
10325         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10326
10327 2019-01-10  Tom Tromey  <tom@tromey.com>
10328
10329         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10330         PSYMBOL_SET_LANGUAGE.
10331         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10332
10333 2019-01-10  Tom Tromey  <tom@tromey.com>
10334
10335         * psymtab.h (psymtab_storage::obstack): New method.
10336         <m_obstack>: Rename from obstack; now private.
10337         * psymtab.c (psymtab_storage): Update.
10338         * dwarf2read.c (create_addrmap_from_index)
10339         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10340         Update.
10341
10342 2019-01-10  Tom Tromey  <tom@tromey.com>
10343
10344         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10345         * objfiles.h (objfile::reset_psymtabs): New method.
10346
10347 2019-01-10  Tom Tromey  <tom@tromey.com>
10348
10349         * symmisc.c (print_symbol_bcache_statistics): Update.
10350         (print_objfile_statistics): Update.
10351         * symfile.c (reread_symbols): Update.
10352         * psymtab.h (class psymtab_storage): New.
10353         * psymtab.c (psymtab_storage): New constructor.
10354         (~psymtab_storage): New destructor.
10355         (require_partial_symbols): Update.
10356         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10357         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10358         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10359         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10360         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10361         (start_psymtab_common, end_psymtab_common)
10362         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10363         (allocate_psymtab): Update.
10364         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10365         Update.
10366         (dump_psymtab_addrmap, maintenance_print_psymbols)
10367         (maintenance_check_psymtabs): Update.
10368         (class objfile_psymtabs): Move to objfiles.h.
10369         * psympriv.h (discard_psymtab): Now inline.
10370         (psymtab_discarder::psymtab_discarder): Update.
10371         (psymtab_discarder::~psymtab_discarder): Update.
10372         (ALL_OBJFILE_PSYMTABS): Rewrite.
10373         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10374         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10375         Remove fields.
10376         <partial_symtabs>: New field.
10377         (class objfile_psymtabs): Move from psymtab.h.  Update.
10378         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10379         psymbol_cache.
10380         (objfile::~objfile): Don't destroy psymbol_cache.
10381         * mdebugread.c (parse_partial_symbols): Update.
10382         * dwarf2read.c (create_addrmap_from_index)
10383         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10384         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10385         (add_partial_subprogram, dwarf2_ranges_read): Update.
10386         * dwarf-index-write.c (write_address_map)
10387         (write_one_signatured_type, recursively_write_psymbols)
10388         (class debug_names, class debug_names, write_psymtabs_to_index):
10389         Update.
10390
10391 2019-01-10  Tom Tromey  <tom@tromey.com>
10392
10393         * symtab.h (SYMBOL_SET_NAMES): Update.
10394         (symbol_set_names): Update.
10395         (MSYMBOL_SET_NAMES): Update.
10396         * symtab.c (symbol_set_names): Change argument to be an
10397         objfile_per_bfd_storage.
10398         * psymtab.c (add_psymbol_to_bcache): Update.
10399         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10400
10401 2019-01-10  Tom Tromey  <tom@tromey.com>
10402
10403         * symtab.c (create_demangled_names_hash): Change argument to be an
10404         objfile_per_bfd_storage.
10405         (symbol_set_names): Update.
10406
10407 2019-01-10  Tom Tromey  <tom@tromey.com>
10408
10409         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10410         init_psymbol_list.
10411         * psymtab.c (init_psymbol_list): Do nothing if already called.
10412         * psympriv.h (init_psymbol_list): Add comment.
10413         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10414         init_psymbol_list.
10415         * dbxread.c (dbx_symfile_read): Unconditionally call
10416         init_psymbol_list.
10417
10418 2019-01-10  Tom Tromey  <tom@tromey.com>
10419
10420         * xcoffread.c (scan_xcoff_symtab): Update.
10421         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10422         "where".
10423         * mdebugread.c (parse_partial_symbols)
10424         (handle_psymbol_enumerators): Update.
10425         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10426         * dbxread.c (read_dbx_symtab): Update.
10427         * psympriv.h (psymbol_placement): New enum.
10428         (add_psymbol_to_list): Update.
10429
10430 2019-01-10  Tom Tromey  <tom@tromey.com>
10431
10432         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10433         static_psymbols parameters.
10434         (scan_xcoff_symtab): Update.
10435         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10436         static_psymbols parameters.
10437         * psympriv.h (start_psymtab_common): Update.
10438         * mdebugread.c (parse_partial_symbols): Update.
10439         * dwarf2read.c (create_partial_symtab): Update.
10440         * dbxread.c (read_dbx_symtab): Update.
10441         (start_psymtab): Remove global_psymbols and static_psymbols
10442         parameters.
10443
10444 2019-01-10  Tom Tromey  <tom@tromey.com>
10445
10446         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10447         * psymtab.c (allocate_psymtab): Add comment.
10448         * psympriv.h (allocate_psymtab): Add comment.
10449         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10450         initializations.
10451         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10452
10453 2019-01-10  Tom Tromey  <tom@tromey.com>
10454
10455         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10456         Don't declare.
10457         * mipsread.c: Include mdebugread.h.
10458         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10459         Declare.
10460         * elfread.c: Include mdebugread.h.
10461
10462 2019-01-09  Tom Tromey  <tom@tromey.com>
10463
10464         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10465         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10466         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10467         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10468         (psym_lookup_symbol, psym_find_last_source_symtab)
10469         (psym_forget_cached_source_info, psym_print_stats)
10470         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10471         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10472         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10473         (psym_find_compunit_symtab_by_address)
10474         (maintenance_print_psymbols, maintenance_info_psymtabs)
10475         (maintenance_check_psymtabs): Use ranged for.
10476         * psymtab.h (class objfile_psymtabs): New.
10477         (require_partial_symbols): Return objfile_psymtabs.
10478         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10479
10480 2019-01-09  Tom Tromey  <tom@tromey.com>
10481
10482         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10483         (find_pc_mapped_section, list_overlays_command)
10484         (map_overlay_command, unmap_overlay_command)
10485         (simple_overlay_update): Use all_objfiles.
10486         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10487         * printcmd.c (info_symbol_command): Use all_objfiles.
10488         * objfiles.h (ALL_OBJSECTIONS): Remove.
10489         * maint.c (maintenance_translate_address): Use all_objfiles.
10490         * gcore.c (gcore_create_callback): Use all_objfiles.
10491         (objfile_find_memory_regions): Likewise.
10492
10493 2019-01-09  Tom Tromey  <tom@tromey.com>
10494
10495         * symtab.c (find_line_symtab, info_sources_command)
10496         (make_source_files_completion_list): Use objfile_compunits.
10497         * source.c (select_source_symtab): Use objfile_compunits.
10498         * objfiles.h (struct objfile): Update comment.
10499         (ALL_OBJFILES): Remove.
10500         (ALL_FILETABS): Remove.
10501         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10502         objfile_compunits.
10503
10504 2019-01-09  Tom Tromey  <tom@tromey.com>
10505
10506         * symmisc.c (print_objfile_statistics, dump_objfile)
10507         (maintenance_print_symbols): Use compunit_filetabs.
10508         * source.c (forget_cached_source_info_for_objfile): Use
10509         compunit_filetabs.
10510         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10511         (ALL_FILETABS): Use compunit_filetabs.
10512         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10513         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10514
10515 2019-01-09  Tom Tromey  <tom@tromey.com>
10516
10517         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10518         (compunit_filetabs): New.
10519         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10520         compunit_filetabs.
10521         (info_sources_command, make_source_files_completion_list): Remove
10522         declaration.
10523         * symmisc.c (print_objfile_statistics, dump_objfile)
10524         (maintenance_print_symbols): Remove declaration.
10525         (maintenance_info_symtabs): Use compunit_filetabs.
10526         (maintenance_info_line_tables): Likewise.
10527         * source.c (select_source_symtab): Change local variable name.
10528         (forget_cached_source_info_for_objfile): Remove declaration.
10529         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10530         * objfiles.c (objfile_relocate1): Remove declaration.
10531         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10532         declaration.
10533         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10534         * coffread.c (coff_symtab_read): Remove declaration.
10535         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10536         compunit_filetabs.
10537
10538 2019-01-09  Tom Tromey  <tom@tromey.com>
10539
10540         * symtab.c (lookup_objfile_from_block)
10541         (find_pc_sect_compunit_symtab, search_symbols)
10542         (default_collect_symbol_completion_matches_break_on): Use
10543         objfile_compunits.
10544         * objfiles.h (ALL_COMPUNITS): Remove.
10545         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10546         * cp-support.c (add_symbol_overload_list_qualified): Use
10547         objfile_compunits.
10548         * ada-lang.c (ada_collect_symbol_completion_matches)
10549         (ada_add_global_exceptions): Use objfile_compunits.
10550
10551 2019-01-09  Tom Tromey  <tom@tromey.com>
10552
10553         * source.c (select_source_symtab)
10554         (forget_cached_source_info_for_objfile): Remove declaration.
10555         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10556         declaration.
10557         * maint.c (count_symtabs_and_blocks): Remove declaration.
10558         * cp-support.c (add_symbol_overload_list_qualified): Remove
10559         declaration.
10560         * coffread.c (coff_symtab_read): Remove declaration.
10561         * symtab.c (lookup_symbol_in_objfile_symtabs)
10562         (basic_lookup_transparent_type_1): Use objfile_compunits.
10563         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10564         (info_sources_command, search_symbols)
10565         (default_collect_symbol_completion_matches_break_on)
10566         (make_source_files_completion_list): Remove declaration.
10567         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10568         (ada_collect_symbol_completion_matches)
10569         (ada_add_global_exceptions): Remove declaration.
10570         * linespec.c (iterate_over_all_matching_symtabs): Use
10571         objfile_compunits.
10572         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10573         (class objfile_compunits): New.
10574         (ALL_COMPUNITS): Use objfile_compunits.
10575         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10576         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10577         objfile_compunits.
10578         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10579
10580 2019-01-09  Tom Tromey  <tom@tromey.com>
10581
10582         * symtab.c (search_symbols)
10583         (default_collect_symbol_completion_matches_break_on): Use
10584         objfile_msymbols.
10585         * ada-lang.c (ada_lookup_simple_minsym)
10586         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10587         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10588         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10589         objfile_msymbols.
10590         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10591         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10592         * objc-lang.c (find_methods): Use objfile_msymbols.
10593         (info_selectors_command, info_classes_command): Likewise.
10594         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10595         * objfiles.h (class objfile_msymbols): New.
10596         (ALL_OBJFILE_MSYMBOLS): Remove.
10597         (ALL_MSYMBOLS): Remove.
10598
10599 2019-01-09  Tom Tromey  <tom@tromey.com>
10600
10601         * common/next-iterator.h (next_adapter): Add Iterator template
10602         parameter.
10603         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10604         (class all_objfiles_safe): New.
10605         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10606         * objfiles.c (put_objfile_before): Update comment.
10607         (add_separate_debug_objfile): Likewise.
10608         (free_all_objfiles): Use all_objfiles_safe.
10609         (objfile_purge_solibs): Likewise.
10610
10611 2019-01-09  Tom Tromey  <tom@tromey.com>
10612
10613         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10614         (expand_symtab_containing_pc, lookup_static_symbol)
10615         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10616         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10617         all_objfiles.
10618         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10619         * breakpoint.c (create_overlay_event_breakpoint)
10620         (create_longjmp_master_breakpoint)
10621         (create_std_terminate_master_breakpoint)
10622         (create_exception_master_breakpoint): Use all_objfiles.
10623         * linux-thread-db.c (try_thread_db_load_from_pdir)
10624         (has_libpthread): Use all_objfiles.
10625         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10626         * linespec.c (iterate_over_all_matching_symtabs)
10627         (search_minsyms_for_name): Use all_objfiles.
10628         * maint.c (maintenance_info_sections): Use all_objfiles.
10629         * main.c (captured_main_1): Use all_objfiles.
10630         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10631         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10632         * guile/scm-pretty-print.c
10633         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10634         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10635         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10636         (maintenance_print_msymbols): Use all_objfiles.
10637         * source.c (select_source_symtab): Use all_objfiles.
10638         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10639         * symfile.c (remove_symbol_file_command)
10640         (expand_symtabs_matching, map_symbol_filenames): Use
10641         all_objfiles.
10642         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10643         all_objfiles.
10644         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10645         * objc-lang.c (find_methods): Use all_objfiles.
10646         * objfiles.c (have_partial_symbols, have_full_symbols)
10647         (have_minimal_symbols, qsort_cmp)
10648         (default_iterate_over_objfiles_in_search_order): Use
10649         all_objfiles.
10650         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10651         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10652         (maintenance_check_psymtabs): Use all_objfiles.
10653         (ALL_PSYMTABS): Remove.
10654         * compile/compile-object-run.c (do_module_cleanup): Use
10655         all_objfiles.
10656         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10657         * cp-support.c (add_symbol_overload_list_qualified): Use
10658         all_objfiles.
10659         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10660         Use all_objfiles.
10661         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10662         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10663         all_objfiles.
10664         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10665         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10666         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10667         Uses all_objfiles.
10668         * solib.c (solib_read_symbols): Use all_objfiles
10669
10670 2019-01-09  Tom Tromey  <tom@tromey.com>
10671
10672         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10673         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10674         all_objfiles.
10675         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10676         * symmisc.c (print_symbol_bcache_statistics)
10677         (print_objfile_statistics, maintenance_print_objfiles)
10678         (maintenance_info_symtabs, maintenance_check_symtabs)
10679         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10680         all_objfiles.
10681         * source.c (forget_cached_source_info): Use all_objfiles.
10682         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10683         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10684         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10685         * objfiles.c (update_section_map): Use all_objfiles.
10686         (shared_objfile_contains_address_p): Likewise.
10687         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10688         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10689
10690 2019-01-09  Tom Tromey  <tom@tromey.com>
10691
10692         * common/next-iterator.h: New file.
10693         * objfiles.h (class all_objfiles): New.
10694         (struct objfile_iterator): New.
10695
10696 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10697
10698         * NEWS: Move the description of the changed "frame", "select-frame",
10699          and "info frame" commands to the Changed commands section.
10700
10701 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10702
10703         * gdbtypes.c (check_stub_method_group): Remove handling of old
10704         mangling schemes.
10705         * linespec.c (find_methods): Likewise.
10706         * stabsread.c (read_member_functions): Likewise.
10707         * valops.c (search_struct_method): Likewise.
10708         (value_struct_elt_for_reference): Likewise.
10709         * NEWS: Mention this change.
10710
10711 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10712
10713         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10714         print_source_lines.
10715         * source.c (print_source_lines_base): Update line number check.
10716         (print_source_lines): New function.
10717         (source_lines_range::source_lines_range): New function.
10718         * source.h (class source_lines_range): New class.
10719         (print_source_lines): New declaration.
10720
10721 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10722
10723         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10724
10725 2019-01-08  Tom Tromey  <tom@tromey.com>
10726             Simon Marchi  <simon.marchi@ericsson.com>
10727
10728         PR gdb/24060
10729         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10730         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10731         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10732         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10733         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10734         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10735
10736 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10737
10738         * source.c (select_source_symtab): Move header comment to
10739         declaration in source.h.
10740         (forget_cached_source_info_for_objfile): Likewise.
10741         (forget_cached_source_info): Likewise.
10742         (identify_source_line): Likewise.
10743         * source.h (identify_source_line): Move declaration from symtab.h
10744         and add comment from source.c
10745         (print_source_lines): Likewise.
10746         (forget_cached_source_info_for_objfile): Likewise.
10747         (forget_cached_source_info): Likewise.
10748         (select_source_symtab): Likewise.
10749         (enum print_source_lines_flag): Move definition from symtab.h.
10750         * symtab.h (identify_source_line): Move declaration to source.h.
10751         (print_source_lines): Likewise.
10752         (forget_cached_source_info_for_objfile): Likewise.
10753         (forget_cached_source_info): Likewise.
10754         (select_source_symtab): Likewise.
10755         (enum print_source_lines_flag): Move definition to source.h.
10756         * tui/tui-hooks.c: Add 'source.h' include.
10757
10758 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10759
10760         * source.c (print_source_lines_base): Handle requests to print
10761         reverse line number sequences, and guard against empty lines
10762         string.
10763
10764 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10765
10766         * source.c (print_source_lines_base): Fix skip of '\r' if next
10767         character is '\n'.
10768
10769 2019-01-06  Tom Tromey  <tom@tromey.com>
10770
10771         * c-exp.y (struct c_parse_state) <macro_original_text,
10772         expansion_obstack>: New member.
10773         (macro_original_text, expansion_obstack): Remove globals.
10774         (scan_macro_expansion, scanning_macro_expansion)
10775         (finished_macro_expansion): Update.
10776         (scan_macro_cleanup): Remove.
10777         (yylex, c_parse): Update.
10778
10779 2019-01-06  Tom Tromey  <tom@tromey.com>
10780
10781         * c-exp.y (struct c_parse_state) <strings>: New member.
10782         (operator_stoken): Update.
10783
10784 2019-01-06  Tom Tromey  <tom@tromey.com>
10785
10786         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10787         (union type_stack_elt) <typelist_val>: Now a pointer to
10788         std::vector.
10789         (type_stack_cleanup): Don't declare.
10790         (push_typelist): Update.
10791         * parse.c (pop_typelist): Return a std::vector.
10792         (push_typelist): Take a std::vector.
10793         (follow_types): Update.  Do not free args.
10794         (type_stack_cleanup): Remove.
10795         * c-exp.y (struct c_parse_state): New.
10796         (cpstate): New global.
10797         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10798         (nonempty_typelist): Update.
10799         (func_mod): Create a new vector.
10800         (c_parse): Create a c_parse_state.
10801         (check_parameter_typelist): Do not delete params.
10802         (function_method): Update.  Do not delete type_list.
10803
10804 2019-01-06  Tom Tromey  <tom@tromey.com>
10805
10806         PR gdb/28155:
10807         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10808         check_typedef.
10809         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10810         (print_return_value): Likewise.
10811
10812 2019-01-05  Tom Tromey  <tom@tromey.com>
10813
10814         * contrib/cleanup_check.py: Remove.
10815         * contrib/gcc-with-excheck: Remove.
10816         * contrib/exsummary.py: Remove.
10817         * contrib/excheck.py: Remove.
10818
10819 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10820
10821         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10822         NULL. Initialize tpprev to NULL instead of assigning it
10823         to NULL on the next statement.
10824         * windows-nat.c (windows_delete_thread): Remove check for
10825         main_thread_id before printing thread exit notifications.
10826         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10827         Remove thread ID check against main_thread_id.
10828         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10829         windows_delete_thread.
10830         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10831
10832 2019-01-04  Tom Tromey  <tom@tromey.com>
10833
10834         * compile/compile.c (_initialize_compile): Use upper case for
10835         metasyntactic variables.
10836         * symmisc.c (_initialize_symmisc): Use upper case for
10837         metasyntactic variables.
10838         * psymtab.c (_initialize_psymtab): Use upper case for
10839         metasyntactic variables.
10840         * demangle.c (demangle_command): Use upper case for metasyntactic
10841         variables.
10842         (_initialize_demangler): Likewise.
10843         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10844         variables.
10845
10846 2019-01-03  Tom Tromey  <tom@tromey.com>
10847
10848         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10849
10850 2019-01-03  Tom Tromey  <tom@tromey.com>
10851
10852         * python/py-symtab.c (salpy_str): Update.
10853         (struct salpy_sal_object) <symtab>: Now a PyObject.
10854         (salpy_dealloc): Update.
10855         (del_objfile_sal): Use gdbpy_ref.
10856
10857 2019-01-03  Tom Tromey  <tom@tromey.com>
10858
10859         * python/py-type.c (convert_field): Use new_reference.  Return
10860         gdbpy_ref.
10861         (make_fielditem): Return gdbpy_ref.
10862         (typy_fields): Update.
10863         (typy_getitem): Update.
10864         (field_name): Return gdbpy_ref.  Use new_reference.
10865         (typy_iterator_iternext): Update.
10866
10867 2019-01-03  Tom Tromey  <tom@tromey.com>
10868
10869         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10870
10871 2019-01-03  Tom Tromey  <tom@tromey.com>
10872
10873         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10874         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10875         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10876         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10877         (pspy_set_type_printers): Likewise.
10878         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10879         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10880         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10881         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10882         (objfpy_set_type_printers): Likewise.
10883
10884 2019-01-03  Tom Tromey  <tom@tromey.com>
10885
10886         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10887         (gdbpy_print_stack): Use gdbpy_err_fetch.
10888         * python/python-internal.h (class gdbpy_err_fetch): New class.
10889         (class gdbpy_enter) <m_error_type, m_error_value,
10890         m_error_traceback>: Remove.
10891         <m_error>: New member.
10892         (gdbpy_exception_to_string): Don't declare.
10893         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10894         * python/py-value.c (convert_value_from_python): Use
10895         gdbpy_err_fetch.
10896         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10897         gdbpy_exception_to_string.
10898         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10899         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10900         gdbpy_err_fetch.
10901
10902 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10903
10904         * linux-nat.c (delete_lwp_cleanup): Delete.
10905         (struct lwp_deleter): New struct.
10906         (lwp_info_up): New typedef.
10907         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10908         lwp_info_up.
10909
10910 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10911
10912         * linux-fork.c (class scoped_switch_fork_info): New class.
10913         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10914
10915 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10916
10917         * valops.c (find_overload_match): Remove use of null_cleanup, and
10918         calls to do_cleanups.
10919
10920 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10921
10922         * compile/compile-cplus-types.c
10923         (compile_cplus_instance::decl_name): Handle changes to
10924         cp_func_name.
10925         * cp-support.c (cp_func_name): Update header comment, update
10926         return type.
10927         * cp-support.h (cp_func_name): Update return type in declaration.
10928         * valops.c (find_overload_match): Move temp_func local to top
10929         level of function and change its type.  Use temp_func to hold and
10930         delete temporary string obtained from cp_func_name.
10931
10932 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10933
10934         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10935         gdb::char_vector, remove cleanup, and update uses of `msg`.
10936
10937 2019-01-03  Jim Wilson  <jimw@sifive.com>
10938
10939         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10940
10941 2019-01-02  Tom Tromey  <tom@tromey.com>
10942
10943         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10944         (tdesc_parse_xml): Remove cleanups.
10945         * target-descriptions.h (make_cleanup_free_target_description):
10946         Don't declare.
10947         (target_desc_deleter): New struct.
10948         (target_desc_up): New typedef.
10949         * target-descriptions.c (target_desc_deleter::operator()): Rename
10950         from free_target_description.
10951         (make_cleanup_free_target_description): Remove.
10952
10953 2019-01-02  Tom Tromey  <tom@tromey.com>
10954
10955         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10956         constructor, destructor.
10957         (linespec_parser): Remove typedef.
10958         (~linespec_parser): Rename from linespec_parser_delete.
10959         (linespec_lex_to_end, linespec_complete_label)
10960         (linespec_complete): Update.
10961         (decode_line_full): Remove cleanups.
10962         (decode_line_1): Update.
10963
10964 2019-01-02  Tom Tromey  <tom@tromey.com>
10965
10966         * python/python-internal.h (inferior_to_inferior_object): Change
10967         return type.
10968         * python/py-exitedevent.c (create_exited_event_object): Update.
10969         * python/py-inferior.c (inferior_to_inferior_object): Return
10970         gdbpy_ref.
10971         (python_new_inferior, python_inferior_deleted)
10972         (thread_to_thread_object, delete_thread_object)
10973         (build_inferior_list, gdbpy_selected_inferior): Update.
10974         * python/py-infthread.c (create_thread_object): Update.  Also fail
10975         if inferior_to_inferior_object fails.
10976
10977 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10978
10979         * inferior.h (class inferior) <displaced_step_state>: New field.
10980         * infrun.h (struct displaced_step_state): Move here from
10981         infrun.c.  Initialize fields, add constructor.
10982         <inf>: Remove field.
10983         <reset>: New method.
10984         * infrun.c (struct displaced_step_inferior_state): Move to
10985         infrun.h.
10986         (displaced_step_inferior_states): Remove.
10987         (get_displaced_stepping_state): Adust.
10988         (displaced_step_in_progress_any_inferior): Adjust.
10989         (displaced_step_in_progress_thread): Adjust.
10990         (displaced_step_in_progress): Adjust.
10991         (add_displaced_stepping_state): Remove.
10992         (get_displaced_step_closure_by_addr): Adjust.
10993         (remove_displaced_stepping_state): Remove.
10994         (infrun_inferior_exit): Call displaced_step_state.reset.
10995         (use_displaced_stepping): Don't check for NULL.
10996         (displaced_step_prepare_throw): Call
10997         get_displaced_stepping_state.
10998         (displaced_step_fixup): Don't check for NULL.
10999         (prepare_for_detach): Don't check for NULL.
11000
11001 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11002
11003         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11004          in case of call that did not complete.
11005
11006 2019-01-02  Andrey Utkin  <autkin@undo.io>
11007
11008         * symfile.c (find_separate_debug_file): Fix search of debug files for
11009         remote debuggee.
11010
11011 2019-01-02  Tom Tromey  <tom@tromey.com>
11012
11013         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11014         indentation.
11015         * python/py-frame.c (frapy_older): Remove cast.
11016         (frapy_newer): Likewise.
11017         * python/py-breakpoint.c (local_setattro): Remove cast.
11018         * python/py-arch.c (archpy_name): Remove local variable.
11019         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11020
11021 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11022
11023         * unittests/basic_string_view/element_access/char/empty.cc:
11024         Fix year range in copyright header.
11025
11026 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11027
11028         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11029         Delete.
11030         <operator==>: Update with for removed field.
11031         <hash>: Likewise.
11032         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11033         <isa_features>: ...this.
11034         <abi_features>: New field.
11035         (riscv_isa_flen): Update comment.
11036         (riscv_abi_xlen): New declaration.
11037         (riscv_abi_flen): New declaration.
11038         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11039         isa_features.
11040         (riscv_abi_xlen): New function.
11041         (riscv_isa_flen): Update to get answer from isa_features.
11042         (riscv_abi_flen): New function.
11043         (riscv_has_fp_abi): Update to get answer from abi_features.
11044         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11045         xlen and flen.
11046         (riscv_call_info) <xlen, flen>: Update comment.
11047         (riscv_call_arg_struct): Remove invalid assertions
11048         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11049         is removed.
11050         (riscv_gdbarch_init): Gather isa features and abi features
11051         separately, ensure both match on the gdbarch when reusing an old
11052         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11053         a target with 64-bit float hardware.
11054
11055 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11056
11057         * source.c (search_command_helper): Stop reverse search
11058         when line 1 has been searched.
11059
11060 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11061
11062         * record-full.c (record_full_base_target::close): Rewrite
11063         record_full_core_buf_list free logic.
11064
11065 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11066
11067         * break-catch-syscall.c (print_one_catch_syscall): xfree
11068         the last text.
11069
11070 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11071
11072         * top.c (print_gdb_version): Update Copyright year in version
11073         message.
11074
11075 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11076
11077         Update copyright year range in all GDB files.
11078
11079 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11080
11081         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11082
11083 For older changes see ChangeLog-2018.
11084 \f
11085 Local Variables:
11086 mode: change-log
11087 left-margin: 8
11088 fill-column: 74
11089 version-control: never
11090 coding: utf-8
11091 End:
11092