gdb/ChangeLog

   1 2019-09-30  Ali Tamur <tamur@google.com>
   2
   3         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
   4         (process_full_type_unit): Likewise.
   5         (dump_die_shallow): Likewise.
   6         (cu_debug_loc_section): Likewise.
   7
   8 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
   9
  10         * minsyms.c (compare_minimal_symbols): Rename to...
  11         (minimal_symbol_is_less_than): ...this, and adjust to STL
  12         conventions (return bool, take arguments as references)
  13         (minimal_symbol_reader::install): Call std::sort instead
  14         of qsort.
  15
  16 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
  17
  18         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
  19         hash and why.
  20         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
  21         msymbol_hash, msymbol_demangled_hash>: Improve comments.
  22
  23 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
  24
  25         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
  26         * psympriv.h (add_psymbol_to_list): Move comment here and update
  27         it.
  28
  29 2019-09-29  Tom de Vries  <tdevries@suse.de>
  30
  31         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
  32         Use $tmpdir/$(basename "$output_file").dwz instead of
  33         "${output_file}.dwz".
  34
  35 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
  36
  37         PR gdb/25045
  38         * hppa-linux-nat.c: Include gdbarch.h.
  39
  40 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
  41
  42         * blockframe.c (find_pc_partial_function): Change return type to bool.
  43         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
  44         * minsyms.c (in_gnu_ifunc_stub): Likewise.
  45         (stub_gnu_ifunc_resolve_name): Likewise.
  46         * symtab.c (compare_filenames_for_search): Likewise.
  47         (compare_glob_filenames_for_search): Likewise.
  48         (matching_obj_sections): Likewise.
  49         (symbol_matches_domain): Likewise.
  50         (find_line_symtab): Change out param EXACT_MATCH to bool *.
  51         (find_line_pc): Change return type to bool.
  52         (find_line_pc_range): Likewise.
  53         (producer_is_realview): Likewise.
  54         * symtab.h (symbol_matches_domain): Likewise.
  55         (find_pc_partial_function): Likewise.
  56         (find_pc_line_pc_range): Likewise.
  57         (in_gnu_ifunc_stub): Likewise.
  58         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
  59         (find_line_pc): Likewise.
  60         (find_line_pc_range): Likewise.
  61         (matching_obj_sections): Likewise.
  62         (find_line_symtab): Change out parameter to bool.
  63         (producer_is_realview): Change return type to bool.
  64         (compare_filenames_for_search): Likewise.
  65         (compare_glob_filenames_for_search): Likewise.
  66
  67 2019-09-26  Tom Tromey  <tom@tromey.com>
  68
  69         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
  70         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
  71         * gdb_usleep.h: Remove.
  72         * gdb_usleep.c: Remove.
  73         * utils.c: Don't include gdb_usleep.h.
  74
  75 2019-09-26  Tom Tromey  <tromey@adacore.com>
  76
  77         * python/py-type.c (type_to_type_object): Call check_typedef
  78         for stub types.
  79
  80 2019-09-26  Tom Tromey  <tom@tromey.com>
  81
  82         * utils.h (initialize_utils): Don't declare.
  83         * top.c (gdb_init): Don't call initialize_utils.
  84         * utils.c (initialize_utils): Remove.  Move contents...
  85         (_initialize_utils): ... here.
  86
  87 2019-09-25  Tom Tromey  <tom@tromey.com>
  88
  89         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
  90         * utils.h (make_hex_string): Don't declare.
  91         * utils.c (make_hex_string): Remove.
  92
  93 2019-09-24  Tom de Vries  <tdevries@suse.de>
  94
  95         PR gdb/23815
  96         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
  97         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
  98
  99 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 100
 101         * NEWS: Mention new simulator port for PRU.
 102
 103 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 104
 105         * ada-exp.y (write_object_remaining): Update.
 106         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 107         and eliminate the static buffer.
 108         (ada_decode_symbol): Update.
 109         (ada_la_decode): Update.
 110         (ada_sniff_from_mangled_name): Update.
 111         (is_valid_name_for_wild_match): Update.
 112         (ada_lookup_name_info::matches): Update and simplify.
 113         (name_matches_regex): Update.
 114         (ada_add_global_exceptions): Update.
 115         * ada-lang.h (ada_decode): Update signature.
 116         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 117         * dwarf-index-write.c (debug_names::insert): Update.
 118
 119 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 120
 121         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 122         formatting.
 123
 124 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 125
 126         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 127         Change "nonzero" to "true" in documentation.
 128
 129 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 130
 131         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 132         (_initialize_darwin_solib): Don't set
 133         darwin_so_ops.lookup_lib_global_symbol.
 134         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 135         set_gdbarch_iterate_over_objfiles_in_search_order.
 136         (elf_lookup_lib_symbol): Rename to...
 137         (svr4_iterate_over_objfiles_in_search_order): this, and update
 138         to iterate semantics.
 139         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 140         * solib.c (solib_global_lookup): Remove.
 141         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 142         (solib_global_lookup): Remove.
 143         * symtab.c (lookup_global_or_static_symbol): Remove call to
 144         solib_global_lookup.
 145
 146 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 147
 148         * NEWS: Move entries about default MI version now being
 149         version 3, and about the GDB/MI fix for multi-location
 150         breakpoints to the "since GDB 8.3" section.
 151
 152 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 153
 154         GDB 8.3.1 released.
 155
 156 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 157
 158         * NEWS: Mention that Cell/B.E. debugging support was removed.
 159         * MAINTAINERS: Remove spu target.
 160
 161         * config/djgpp/fnchange.lst: Remove entries for removed files.
 162
 163         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 164         spu-multiarch.o, and spu-tdep.o.
 165         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 166         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 167         spu-multiarch.c, and spu-tdep.c.
 168         * spu-linux-nat.c: Remove file.
 169         * spu-multiarch.c: Remove file.
 170         * spu-tdep.c: Remove file.
 171         * spu-tdep.h: Remove file.
 172         * solib-spu.c: Remove file.
 173         * solib-spu.h: Remove file.
 174
 175         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 176         * configure.nat (spu-linux): Remove.
 177         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 178         solib-multiarch.o from gdb_target_obs.
 179         (spu*-*-*): Remove.
 180
 181         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 182         feature flag.
 183         (ppc_linux_no_features): Update.
 184         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 185         Cell/B.E. support.
 186         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 187         (tdesc_powerpc_cell64l): Likewise.
 188         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 189         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 190         Cell/B.E. support.
 191         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 192         Do not include "features/rs6000/powerpc-cell32l.c" or
 193         "features/rs6000/powerpc-cell64l.c".
 194         (ppc_linux_spu_section): Remove.
 195         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 196         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 197         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 198         (ppc_linux_spe_context_lookup): Remove.
 199         (ppc_linux_spe_context_inferior_created): Remove.
 200         (ppc_linux_spe_context_solib_loaded): Remove.
 201         (ppc_linux_spe_context_solib_unloaded): Remove.
 202         (ppc_linux_spe_context): Remove.
 203         (struct ppu2spu_cache): Remove.
 204         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 205         (struct ppu2spu_data): Remove.
 206         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 207         ppu2spu_unwind): Remove.
 208         (ppc_linux_init_abi): Remove Cell/B.E. support.
 209         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 210
 211         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 212         (rs6000/powerpc-cell64l-expedite): Likewise
 213         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 214         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 215         rs6000/powerpc-cell64l.xml.
 216         * features/rs6000/powerpc-cell32l.xml: Remove.
 217         * features/rs6000/powerpc-cell64l.xml: Likewise.
 218         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 219         * features/rs6000/powerpc-cell64l.c: Likewise.
 220         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 221         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 222         * regformats/reg-spu.dat: Remove.
 223
 224         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 225         * corelow.c (struct spuid_list): Remove.
 226         (add_to_spuid_list): Remove.
 227         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 228         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 229         (remote_protocol_features): Remove associated entries.
 230         (_initialize_remote): No longer initialize them.
 231         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 232         * linux-nat.c (SPUFS_MAGIC): Remove.
 233         (linux_proc_xfer_spu): Remove.
 234         (spu_enumerate_spu_ids): Remove.
 235         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 236         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 237         (linux_make_corefile_notes): No longer call it.
 238
 239         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 240         (cooked_write_test): Likewise.
 241
 242 2019-09-20  Tom Tromey  <tom@tromey.com>
 243
 244         * NEWS: Mention case-sensitivity of TUI commands.
 245         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 246         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 247         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 248
 249 2019-09-20  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui-source.c (tui_source_window::set_contents): Use
 252         make_unique_xstrdup.
 253         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 254         make_unique_xstrdup.
 255
 256 2019-09-20  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-data.c: Remove separator comments.
 259         * tui/tui-layout.c: Remove separator comments.
 260         * tui/tui-win.c: Remove separator comments.
 261         * tui/tui-wingeneral.c: Remove separator comments.
 262
 263 2019-09-20  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui.h (strcat_to_buf): Don't declare.
 266         * tui/tui.c (strcat_to_buf): Remove.
 267
 268 2019-09-20  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 271         from "fullname".
 272         * tui/tui-source.c (tui_source_window::set_contents)
 273         (tui_source_window::location_matches_p)
 274         (tui_source_window::maybe_update): Update.
 275
 276 2019-09-20  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 279         Update.
 280         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 281         prefix.
 282         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 283         (tui_data_window::line_from_reg_element_no)
 284         (tui_data_window::first_reg_element_no_inline)
 285         (tui_data_window::show_registers)
 286         (tui_data_window::show_register_group)
 287         (tui_data_window::display_registers_from)
 288         (tui_data_window::display_registers_from_line)
 289         (tui_data_window::first_data_item_displayed)
 290         (tui_data_window::delete_data_content_windows)
 291         (tui_data_window::erase_data_content)
 292         (tui_data_window::do_scroll_vertical)
 293         (tui_data_window::refresh_window)
 294         (tui_data_window::check_register_values): Update.
 295
 296 2019-09-20  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 299         (struct tui_locator_window) <full_name, proc_name>: Now
 300         std::string.
 301         * tui/tui-stack.c (tui_locator_window::make_status_line)
 302         (tui_locator_window::set_locator_fullname)
 303         (tui_locator_window::set_locator_info): Update.
 304         * tui/tui-source.c (tui_source_window::set_contents)
 305         (tui_source_window::showing_source_p): Update.
 306
 307 2019-09-20  Tom Tromey  <tom@tromey.com>
 308
 309         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 310         Don't call tui_locator_win_info_ptr.
 311
 312 2019-09-20  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 315
 316 2019-09-20  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 319         height for locator.
 320         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 321         * tui/tui-layout.c (show_source_disasm_command, show_data)
 322         (show_source_or_disasm_and_command): Use 1 as height for locator.
 323
 324 2019-09-20  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui.c (tui_enable): Update.
 327         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 328         Update.
 329         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 330         Update.
 331         * tui/tui-data.c (win_resized): Now bool.
 332         (tui_win_resized): Return bool.
 333         (tui_set_win_resized_to): Accept a bool.
 334
 335 2019-09-20  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 338         Change type of "refresh_values_only".
 339         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 340         type of "refresh_values_only".
 341
 342 2019-09-20  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 345         std::string.
 346         (tui_disassemble): Add "pos" parameter.
 347         (tui_disasm_window::set_contents): Simplify.
 348
 349 2019-09-20  Tom Tromey  <tom@tromey.com>
 350
 351         * tui/tui-winsource.h (struct tui_source_window_base)
 352         <show_source_content>: Now private.
 353         * tui/tui-winsource.c
 354         (tui_source_window_base::show_source_content): Don't handle empty
 355         content case.
 356
 357 2019-09-20  Tom Tromey  <tom@tromey.com>
 358
 359         * tui/tui-layout.c (show_source_disasm_command)
 360         (show_source_or_disasm_and_command): Don't call
 361         show_source_content.
 362
 363 2019-09-20  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 366         Declare.
 367         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 368         from tui_make_status_line.
 369         (tui_locator_window::rerender): Update.
 370
 371 2019-09-20  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 374         (tui_locator_window::rerender): Update.
 375
 376 2019-09-20  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-winsource.h (struct tui_source_window_base)
 379         <~tui_source_window_base>: Don't declare.
 380         <fullname>: Remove.
 381         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 382         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 383         member.
 384         * tui/tui-source.c (tui_source_window::set_contents): Update.
 385         (tui_source_window::location_matches_p)
 386         (tui_source_window::maybe_update): Update.
 387
 388 2019-09-20  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-winsource.h (~tui_source_element): Remove.
 391         (tui_source_element): Update.
 392         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 393         * tui/tui-winsource.c (tui_show_source_line): Update.
 394         * tui/tui-source.c (tui_source_window::set_contents): Update.
 395         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 396
 397 2019-09-20  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 400         declare.
 401         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 402         tui_clear_source_windows_detail.
 403         * tui/tui-winsource.h (struct tui_source_window_base)
 404         <clear_detail>: Don't declare.
 405         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 406         Remove.
 407         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 408
 409 2019-09-20  Tom Tromey  <tromey@adacore.com>
 410
 411         PR ada/24919:
 412         * block.c (contained_in): Fix final return value.
 413
 414 2019-09-20  Alan Modra  <amodra@gmail.com>
 415
 416         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 417         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 418         (read_indirect_string_from_dwz): Use bfd accessor.
 419         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 420         * machoread.c (macho_symfile_read_all_oso): Likewise.
 421         * solib.c (solib_bfd_open): Likewise.
 422
 423 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 424
 425         * eval.c: Move declaration of overload_resolution to...
 426         * value.h: ...here.
 427
 428 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 429
 430         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 431         * arm-linux-tdep.c: Likewise.
 432         * arm-nbsd-nat.c: Likewise.
 433         * arm-tdep.h: Declare arm_apcs_32.
 434         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 435
 436 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 437
 438         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 439         * dwarf2read.h: Declare dwarf_always_disassemble.
 440
 441 2019-09-19  Tom de Vries  <tdevries@suse.de>
 442
 443         PR gdb/25009
 444         * source-cache.c (source_cache::ensure): Catch exception thrown during
 445         construction of the highlighter.
 446
 447 2019-09-18  Alan Modra  <amodra@gmail.com>
 448
 449         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 450         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 451         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 452         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 453         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 454         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 455         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 456         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 457         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 458         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 459         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 460         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 461         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 462         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 463         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 464         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 465         * mi/mi-interp.c: Update throughout for bfd section macro and
 466         function changes.
 467         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 468         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 469
 470 2019-09-18  Tom Tromey  <tom@tromey.com>
 471
 472         * NEWS: Add entry.
 473         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 474         call rl_initialize.
 475         (tui_enable): Do not call rl_initialize.
 476
 477 2019-09-18  Christian Groessler  <chris@groessler.org>
 478
 479         * alpha-linux-nat.c: Include gdbarch.h.
 480
 481 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 482
 483         * ui-file.c: Include cli/cli-style.h.
 484         (term_cli_styling): Remove cli_styling declaration.
 485
 486 2019-09-18  Alan Modra  <amodra@gmail.com>
 487
 488         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 489         to bfd_asymbol_section.
 490
 491 2019-09-18  Alan Modra  <amodra@gmail.com>
 492
 493         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 494         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 495         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 496
 497 2019-09-18  Alan Modra  <amodra@gmail.com>
 498
 499         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 500         * spu-linux-nat.c (spu_bfd_open): Likewise.
 501
 502 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 503
 504         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 505         to bool to match definition in dwarf2read.c.
 506
 507 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 508
 509         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 510         (print_signatures): Likewise.
 511         (trust_pad_over_xvs): Likewise.
 512         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 513         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 514         * arm-linux-nat.c (arm_apcs_32): Likewise.
 515         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 516         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 517         * arm-tdep.c (arm_debug): Likewise.
 518         (arm_apcs_32): Likewise.
 519         * auto-load.c (debug_auto_load): Likewise.
 520         (auto_load_gdb_scripts): Likewise.
 521         (global_auto_load): Likewise.
 522         (auto_load_local_gdbinit): Likewise.
 523         (auto_load_local_gdbinit_loaded): Likewise.
 524         * auto-load.h (global_auto_load): Likewise.
 525         (auto_load_local_gdbinit): Likewise.
 526         (auto_load_local_gdbinit_loaded): Likewise.
 527         * breakpoint.c (disconnected_dprintf): Likewise.
 528         (breakpoint_proceeded): Likewise.
 529         (automatic_hardware_breakpoints): Likewise.
 530         (always_inserted_mode): Likewise.
 531         (target_exact_watchpoints): Likewise.
 532         (_initialize_breakpoint): Update.
 533         * breakpoint.h (target_exact_watchpoints): Change to bool.
 534         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 535         * cli/cli-cmds.c (trace_commands): Likewise.
 536         * cli/cli-cmds.h (trace_commands): Likewise.
 537         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 538         to bool*.
 539         * cli/cli-logging.c (logging_overwrite): Change to bool.
 540         (logging_redirect): Likewise.
 541         (debug_redirect): Likewise.
 542         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 543         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 544         to bool.
 545         <boolean_option_def>: Update.
 546         (struct flag_option_def): Change default type of Context to bool
 547         from int.
 548         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 549         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 550         (get_setshow_command_value_string): Likewise.
 551         * cli/cli-style.c (cli_styling): Change to bool.
 552         (source_styling): Likewise.
 553         * cli/cli-style.h (source_styling): Likewise.
 554         (cli_styling): Likewise.
 555         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 556         to bool.
 557         * command.h (var_types): Update comment.
 558         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 559         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 560         bool.
 561         (debug_compile_cplus_scopes): Likewise.
 562         * compile/compile-internal.h (compile_debug): Likewise.
 563         * compile/compile.c (compile_debug): Likewise.
 564         (struct compile_options) <raw>: Likewise.
 565         * cp-support.c (catch_demangler_crashes): Likewise.
 566         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 567         (usr_cmd_cris_dwarf2_cfi): Likewise.
 568         * csky-tdep.c (csky_debug): Likewise.
 569         * darwin-nat.c (enable_mach_exceptions): Likewise.
 570         * dcache.c (dcache_enabled_p): Likewise.
 571         * defs.h (info_verbose): Likewise.
 572         * demangle.c (demangle): Likewise.
 573         (asm_demangle): Likewise.
 574         * dwarf-index-cache.c (debug_index_cache): Likewise.
 575         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 576         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 577         * dwarf2read.c (check_physname): Likewise.
 578         (use_deprecated_index_sections): Likewise.
 579         (dwarf_always_disassemble): Likewise.
 580         * eval.c (overload_resolution): Likewise.
 581         * event-top.c (set_editing_cmd_var): Likewise.
 582         (exec_done_display_p): Likewise.
 583         * event-top.h (set_editing_cmd_var): Likewise.
 584         (exec_done_display_p): Likewise.
 585         * exec.c (write_files): Likewise.
 586         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 587         (debug_fbsd_nat): Likewise.
 588         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 589         Likewise.
 590         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 591         <backtrace_past_entry> Likewise.
 592         * gdb-demangle.h (demangle): Likewise.
 593         (asm_demangle): Likewise.
 594         * gdb_bfd.c (bfd_sharing): Likewise.
 595         * gdbcore.h (write_files): Likewise.
 596         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 597         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 598         * gdbthread.h (print_thread_events): Likewise.
 599         * gdbtypes.c (opaque_type_resolution): Likewise.
 600         (strict_type_checking): Likewise.
 601         * gnu-nat.c (gnu_debug_flag): Likewise.
 602         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 603         * guile/scm-param.c (pascm_variable): Add boolval.
 604         (add_setshow_generic): Update.
 605         (pascm_param_value): Update.
 606         (pascm_set_param_value_x): Update.
 607         * hppa-tdep.c (hppa_debug): Change to bool..
 608         * infcall.c (may_call_functions_p): Likewise.
 609         (coerce_float_to_double_p): Likewise.
 610         (unwind_on_signal_p): Likewise.
 611         (unwind_on_terminating_exception_p): Likewise.
 612         * infcmd.c (startup_with_shell): Likewise.
 613         * inferior.c (print_inferior_events): Likewise.
 614         * inferior.h (startup_with_shell): Likewise.
 615         (print_inferior_events): Likewise.
 616         * infrun.c (step_stop_if_no_debug): Likewise.
 617         (detach_fork): Likewise.
 618         (debug_displaced): Likewise.
 619         (disable_randomization): Likewise.
 620         (non_stop): Likewise.
 621         (non_stop_1): Likewise.
 622         (observer_mode): Likewise.
 623         (observer_mode_1): Likewise.
 624         (set_observer_mode): Update.
 625         (sched_multi): Change to bool.
 626         * infrun.h (debug_displaced): Likewise.
 627         (sched_multi): Likewise.
 628         (step_stop_if_no_debug): Likewise.
 629         (non_stop): Likewise.
 630         (disable_randomization): Likewise.
 631         * linux-tdep.c (use_coredump_filter): Likewise.
 632         (dump_excluded_mappings): Likewise.
 633         * linux-thread-db.c (auto_load_thread_db): Likewise.
 634         (check_thread_db_on_load): Likewise.
 635         * main.c (captured_main_1): Update.
 636         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 637         xx2_opt, boolean_opt>: Change to bool.
 638         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 639         * maint.c (maintenance_profile_p): Likewise.
 640         (per_command_time): Likewise.
 641         (per_command_space): Likewise.
 642         (per_command_symtab): Likewise.
 643         * memattr.c (inaccessible_by_default): Likewise.
 644         * mi/mi-main.c (mi_async): Likewise.
 645         (mi_async_1): Likewise.
 646         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 647         * nat/fork-inferior.h (startup_with_shell): Likewise.
 648         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 649         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 650         * nios2-tdep.c (nios2_debug): Likewise.
 651         * or1k-tdep.c (or1k_debug): Likewise.
 652         * parse.c (parser_debug): Likewise.
 653         * parser-defs.h (parser_debug): Likewise.
 654         * printcmd.c (print_symbol_filename): Likewise.
 655         * proc-api.c (procfs_trace): Likewise.
 656         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 657         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 658         (set_parameter_value): Update.
 659         (add_setshow_generic): Update.
 660         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 661         to bool*.
 662         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 663         int*.
 664         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 665         * record-btrace.c (record_btrace_target::store_registers): Update.
 666         * record-full.c (record_full_memory_query): Change to bool.
 667         (record_full_stop_at_limit): Likewise.
 668         * record-full.h (record_full_memory_query): Likewise.
 669         * remote-notif.c (notif_debug): Likewise.
 670         * remote-notif.h (notif_debug): Likewise.
 671         * remote.c (use_range_stepping): Likewise.
 672         (interrupt_on_connect): Likewise.
 673         (remote_break): Likewise.
 674         * ser-tcp.c (tcp_auto_retry): Likewise.
 675         * ser-unix.c (serial_hwflow): Likewise.
 676         * skip.c (debug_skip): Likewise.
 677         * solib-aix.c (solib_aix_debug): Likewise.
 678         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 679         (spu_auto_flush_cache_p): Likewise.
 680         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 681         Likewise.
 682         (struct info_print_options) <quiet>: Likewise.
 683         * symfile-debug.c (debug_symfile): Likewise.
 684         * symfile.c (auto_solib_add): Likewise.
 685         (separate_debug_file_debug): Likewise.
 686         * symfile.h (auto_solib_add): Likewise.
 687         (separate_debug_file_debug): Likewise.
 688         * symtab.c (basenames_may_differ): Likewise.
 689         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 690         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 691         (struct info_types_options) <quiet>: Likewise.
 692         * symtab.h (demangle): Likewise.
 693         (basenames_may_differ): Likewise.
 694         * target-dcache.c (stack_cache_enabled_1): Likewise.
 695         (code_cache_enabled_1): Likewise.
 696         * target.c (trust_readonly): Likewise.
 697         (may_write_registers): Likewise.
 698         (may_write_memory): Likewise.
 699         (may_insert_breakpoints): Likewise.
 700         (may_insert_tracepoints): Likewise.
 701         (may_insert_fast_tracepoints): Likewise.
 702         (may_stop): Likewise.
 703         (auto_connect_native_target): Likewise.
 704         (target_stop_and_wait): Update.
 705         (target_async_permitted): Change to bool.
 706         (target_async_permitted_1): Likewise.
 707         (may_write_registers_1): Likewise.
 708         (may_write_memory_1): Likewise.
 709         (may_insert_breakpoints_1): Likewise.
 710         (may_insert_tracepoints_1): Likewise.
 711         (may_insert_fast_tracepoints_1): Likewise.
 712         (may_stop_1): Likewise.
 713         * target.h (target_async_permitted): Likewise.
 714         (may_write_registers): Likewise.
 715         (may_write_memory): Likewise.
 716         (may_insert_breakpoints): Likewise.
 717         (may_insert_tracepoints): Likewise.
 718         (may_insert_fast_tracepoints): Likewise.
 719         (may_stop): Likewise.
 720         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 721         (make_thread_apply_all_options_def_group): Change argument from int*
 722         to bool*.
 723         (thread_apply_all_command): Update.
 724         (print_thread_events): Change to bool.
 725         * top.c (confirm): Likewise.
 726         (command_editing_p): Likewise.
 727         (history_expansion_p): Likewise.
 728         (write_history_p): Likewise.
 729         (info_verbose): Likewise.
 730         * top.h (confirm): Likewise.
 731         (history_expansion_p): Likewise.
 732         * tracepoint.c (disconnected_tracing): Likewise.
 733         (circular_trace_buffer): Likewise.
 734         * typeprint.c (print_methods): Likewise.
 735         (print_typedefs): Likewise.
 736         * utils.c (debug_timestamp): Likewise.
 737         (sevenbit_strings): Likewise.
 738         (pagination_enabled): Likewise.
 739         * utils.h (sevenbit_strings): Likewise.
 740         (pagination_enabled): Likewise.
 741         * valops.c (overload_resolution): Likewise.
 742         * valprint.h (struct value_print_options) <prettyformat_arrays,
 743         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 744         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 745         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 746         Likewise.
 747         * windows-nat.c (new_console): Likewise.
 748         (cygwin_exceptions): Likewise.
 749         (new_group): Likewise.
 750         (debug_exec): Likewise.
 751         (debug_events): Likewise.
 752         (debug_memory): Likewise.
 753         (debug_exceptions): Likewise.
 754         (useshell): Likewise.
 755         * windows-tdep.c (maint_display_all_tib): Likewise.
 756         * xml-support.c (debug_xml): Likewise.
 757
 758 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 759
 760         * source.c (prepare_path_for_appending): New function.
 761         (openp): Make use of new function.
 762         (find_and_open_source): Search for the compilation directory and
 763         source file as a relative path beneath the directory search path.
 764
 765 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 766
 767         * source-cache.c (source_cache::get_line_charpos): Catch
 768         exceptions and return false, this matches the behaviour documented
 769         in the header file.
 770
 771 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 772
 773         * ada-tasks.c (info_task): Remove quoting of the task's name.
 774
 775 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 776
 777         * symfile.c (auto_solib_add): Replace comment with a reference
 778         to the header file.
 779
 780 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 781
 782         * NEWS: Mention that gdb can now be compiled with Python 3
 783         on Windows.
 784
 785 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 786
 787         * maint.c (maint_print_section_data::maint_print_section_data):
 788         Force use of 'float log10 (float)' by casting the argument to
 789         float.
 790
 791 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 792
 793         * maint.c: Add 'cmath' include.
 794         (struct maint_print_section_data): New structure.
 795         (print_section_index): New function.
 796         (print_bfd_section_info): Add header comment, small whitespace
 797         cleanup, and update to call new print_section_index function.
 798         (print_objfile_section_info): Likewise.
 799         (maint_obj_section_from_bfd_section): New function.
 800         (print_bfd_section_info_maybe_relocated): New function.
 801         (maintenance_info_sections): Add header comment, always use
 802         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 803
 804 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 805
 806         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 807         inner scope, add check that the objfile has psymtabs before
 808         checking psymtabs_addrmap.
 809         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 810
 811 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 812
 813         * NEWS: Announce that Ada task names are now shown at more places,
 814         and between quotes (except in info task output).
 815         * gdb/ada-tasks.c (task_to_str): New function.
 816         (display_current_task_id): Call task_to_str.
 817         (task_command_1): Likewise.
 818         (print_ada_task_info): In non-mi mode, Properly align headers and data
 819         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 820
 821 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 822
 823         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 824         prstatus.pr_lwp.pr_info instead of making it up.
 825
 826 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 827
 828         * auto-load.c (auto_load_expand_dir_vars): Update.
 829         * defs.h (gdb_datadir): Change to std::string.
 830         (python_libdir): Likewise.
 831         (relocate_gdb_directory): Change return type to std::string.
 832         * guile/guile.c (gdbscm_data_directory): Update.
 833         (initialize_scheme_side): Update.
 834         * jit.c (jit_reader_dir): Change to std::string.
 835         (jit_reader_load_command): Update.
 836         * main.c (gdb_datadir): Change to std::string.
 837         (python_libdir): Likewise.
 838         (set_gdb_data_directory): Update.
 839         (relocate_path): Change to return std::string.
 840         (relocate_gdb_directory): Change to return std::string.
 841         (relocate_gdbinit_path_maybe_in_datadir): Update.
 842         (captured_main_1): Update.
 843         * python/python.c (do_start_initialization): Update.
 844         * top.c (show_gdb_datadir): Update.
 845         * xml-syscall.c (xml_init_syscalls_info): Update.
 846         (init_syscalls_info): Update.
 847
 848 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 849
 850         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 851         out of get_init_files.
 852         (get_init_files): Update.
 853
 854 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 855
 856         * main.c (get_init_files): Change to use std::string.
 857         (captured_main_1): Update.
 858         (print_gdb_help): Update.
 859
 860 2019-09-11  Ali Tamur  <tamur@google.com>
 861
 862         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 863         implementation.
 864
 865 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 866
 867         * dbxread.c (read_dbx_symtab): Update.
 868         * dwarf2read.c (load_partial_dies): Update.
 869         * mdebugread.c (parse_partial_symbols): Update.
 870         (handle_psymbol_enumerators): Update.
 871         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 872         * psymtab.c (add_psymbol_to_bcache): Likewise.
 873         (add_psymbol_to_list): Likewise.
 874         * symtab.c (symbol_set_names): Likewise.
 875         * symtab.h (symbol_set_names): Likewise.
 876         * xcoffread.c (scan_xcoff_symtab): Update.
 877
 878 2019-09-11  Tom Tromey  <tom@tromey.com>
 879
 880         * symfile-mem.c (symbol_file_add_from_memory): Use
 881         bfd_set_filename.
 882         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 883         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 884
 885 2019-09-10  Tom Tromey  <tromey@adacore.com>
 886
 887         * dwarf-index-write.c (write_psymbols): Extend error message.
 888         (debug_names::insert): Add Ada code.
 889         (debug_names::write_psymbols): Remove Ada check.
 890         (debug_names) <m_string_obstack>: New member.
 891         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 892         (gdb_index_symbol_name_matcher::matches): Remove.
 893         (mapped_index_base::find_name_components_bounds): Add "lang"
 894         parameter.
 895         (mapped_index_base::build_name_components): Also split names
 896         according to Ada syntax.
 897         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 898         type of "match_callback".
 899         (check_match, check_find_bounds_finds)
 900         (dw2_expand_symtabs_matching): Update.
 901         (dw2_debug_names_iterator): Add new constructor.
 902         (dw2_debug_names_map_matching_symbols): New function.
 903         (dw2_debug_names_expand_symtabs_matching): Update.
 904         (dwarf2_debug_names_functions): Use
 905         dw2_debug_names_map_matching_symbols.
 906
 907 2019-09-10  Tom Tromey  <tromey@adacore.com>
 908
 909         * dwarf2read.c (dw2_get_file_names_reader): Add the
 910         CU's file name to the results.
 911
 912 2019-09-10  Tom Tromey  <tromey@adacore.com>
 913
 914         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 915         map_matching_symbols.  Update.
 916         * dwarf2read.c (dw2_map_matching_symbols): Update.
 917         * psymtab.c (match_partial_symbol): Change type; update.
 918         (psym_map_matching_symbols): Likewise.
 919         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 920         type; update.
 921         * symfile.h (struct quick_symbol_functions)
 922         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 923         Remove "match".
 924
 925 2019-09-10  Tom Tromey  <tromey@adacore.com>
 926
 927         * psymtab.c (map_block): Remove.
 928         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 929         * symtab.c (iterate_over_symbols_terminated): New function.
 930         * symtab.c (iterate_over_symbols_terminated): Declare.
 931
 932 2019-09-10  Tom Tromey  <tromey@adacore.com>
 933
 934         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 935         * language.h (struct language_defn) <la_iterate_over_symbols>:
 936         Return bool.
 937         * symtab.c (iterate_over_symbols): Return bool.
 938         * symtab.h (iterate_over_symbols): Return bool.
 939
 940 2019-09-10  Tom Tromey  <tromey@adacore.com>
 941
 942         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 943         (add_nonlocal_symbols): Update.
 944         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 945         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 946         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 947         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 948         Change type of "callback".  Remove "data".
 949
 950
 951 2019-09-09  Ali Tamur  <tamur@google.com>
 952
 953         * dwarf2read.c (comp_unit_head): Update comment.
 954         (dwarf2_dwo_name): New function declaration.
 955         (dwarf_unit_type_name): New function declaration.
 956         (read_comp_unit_head): Add support for new compilation units,
 957         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 958         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 959         (currently named as "signature") in their header. Also clarify error
 960         messages.
 961         (lookup_dwo_id): New function. Returns the dwo id of the given
 962         compile unit.
 963         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 964         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 965         functions.
 966         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 967         (dwarf2_dwo_name): Get the dwo name if present.
 968         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 969         purposes.
 970
 971 2019-09-09  Tom Tromey  <tom@tromey.com>
 972
 973         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 974
 975 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 976
 977         * python/python.c (do_start_initialization): Make progname_copy static,
 978         to avoid a leak report.
 979
 980 2019-09-08  Tom Tromey  <tom@tromey.com>
 981
 982         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 983
 984 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 985
 986         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 987         Change type to gdb::optional<block_enum>.
 988         (dw2_symtab_iter_init): Change block_index parameter type
 989         to gdb::optional<block_enum>.
 990         (dw2_lookup_symbol): Change block_index parameter
 991         type to block_enum.c
 992         (dw2_debug_names_lookup_symbol): Likewise.
 993         * psymtab.c (psym_lookup_symbol): Likewise.
 994         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 995         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 996         Likewise.
 997
 998 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 999
1000         * defs.h (relocate_gdb_directory): Change int to bool in
1001         signature and rename flag to relocatable.
1002         * main.c (relocate_path): Likewise.
1003         (relocate_gdb_directory): Likewise.
1004
1005 2019-09-06  Alan Modra  <amodra@gmail.com>
1006
1007         * coffread.c (coff_symfile_read): Constify filename variable.
1008         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1009         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1010         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1011         * solib.c (reload_shared_libraries_1): Likewise.
1012         * symfile.c (reread_symbols): Likewise.
1013         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1014         * solib-darwin.c (darwin_bfd_open): Likewise.
1015         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1016
1017 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1020         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1021
1022 2019-09-03  Tom Tromey  <tromey@adacore.com>
1023
1024         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1025         types.
1026         (has_negatives): Unbias a range type bound.
1027         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1028         * gdbtypes.c (operator==): Handle new field.
1029         (create_range_type): Add "bias" parameter.
1030         (create_static_range_type, resolve_dynamic_range): Update.
1031         * gdbtypes.h (struct range_bounds) <bias>: New member.
1032         (create_range_type): Add bias parameter.
1033         * printcmd.c (print_scalar_formatted): Unbias range types.
1034         * value.c (unpack_long): Unbias range types.
1035         (pack_long): Bias range types.
1036
1037 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1038
1039         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1040         probe arguments.
1041
1042 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1043
1044         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1045         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1046         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1047         (compile_probe_arg): Likewise.
1048         * probe.h (get_argument_count): Likewise.
1049         * solib-svr4.c (solib_event_probe_action): Likewise.
1050         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1051
1052 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1053
1054         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1055         code to here...
1056         (svr4_create_solib_event_breakpoints): ...from here.
1057
1058 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1059
1060         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1061         suffix from warning message.
1062
1063 2019-08-30  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-winsource.h (struct tui_source_window_base)
1066         <refresh_all>: Don't declare.
1067         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1068         Remove.
1069         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1070         tui_show_locator_content.
1071         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1072         declare.
1073         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1074         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1075         declare.
1076
1077 2019-08-30  Tom Tromey  <tom@tromey.com>
1078
1079         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1080
1081 2019-08-30  Tom Tromey  <tom@tromey.com>
1082
1083         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1084         Remove unnecessary forward declarations.
1085
1086 2019-08-30  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1089         rerender.
1090         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1091         tui_show_locator_content.
1092
1093 2019-08-30  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1096         (tui_locator_window::rerender): Rewrite using body of previous
1097         tui_show_locator_content.
1098
1099 2019-08-30  Tom Tromey  <tom@tromey.com>
1100
1101         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1102         set_locator_fullname>: New methods.
1103         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1104         Rename from tui_set_locator_fullname.
1105         (tui_locator_window::set_locator_info): Rename from
1106         tui_set_locator_info.  Return bool.
1107         (tui_update_locator_fullname, tui_show_frame_info): Update.
1108
1109 2019-08-30  Tom Tromey  <tom@tromey.com>
1110
1111         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1112
1113 2019-08-30  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1116         call touchwin.
1117
1118 2019-08-30  Tom Tromey  <tom@tromey.com>
1119
1120         * tui/tui-wingeneral.c (box_win): Assume win_info and
1121         win_info->handle cannot be NULL.
1122
1123 2019-08-30  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1126         refresh_window>: Declare.
1127         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1128         resize.
1129         (tui_data_item_window::rerender): Rename from
1130         tui_display_register.
1131         (tui_data_item_window::refresh_window): New method.
1132         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1133         no-op.
1134
1135 2019-08-30  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1138         regs_column_count, current_group>: Move later.  Now private.
1139         <get_current_group>: New method.
1140         * tui/tui-regs.c (tui_reg_command): Update.
1141         * tui/tui-layout.c (tui_set_layout): Update.
1142
1143 2019-08-30  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1146         (tui_data_window::rerender): Don't call
1147         check_and_display_highlight_if_needed.
1148         (tui_data_window::refresh_all): Remove call to
1149         erase_data_content.
1150
1151 2019-08-30  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1154         (tui_data_window::display_registers_from)
1155         (tui_data_window::display_reg_element_at_line)
1156         (tui_data_window::display_registers_from_line): Remove checks of
1157         "empty".
1158
1159 2019-08-30  Tom Tromey  <tom@tromey.com>
1160
1161         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1162         Don't declare.
1163         * tui/tui-regs.c (tui_data_window::show_registers): Call
1164         rerender.
1165         (tui_data_window::rerender): Rename from display_all_data.
1166         (tui_data_window::rerender): Remove old implementation.
1167
1168 2019-08-30  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1171         text.
1172         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1173
1174 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1175             Sergio Durigan Junior  <sergiodj@redhat.com>
1176
1177         PR win32/24284
1178         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1179
1180 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1183         when searching for types.
1184
1185 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1186
1187         * f-lang.c (f_language_defn): Use f_print_typedef.
1188         * f-lang.h (f_print_typedef): Declare.
1189         * f-typeprint.c (f_print_typedef): Define.
1190
1191 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1192
1193         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1194
1195 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1196
1197         * cli/cli-utils.c (info_print_options_defs): Delete.
1198         (make_info_print_options_def_group): Delete.
1199         (extract_info_print_options): Delete.
1200         (info_print_command_completer): Delete.
1201         (info_print_args_help): Add extra parameter, and optionally
1202         include text about -n flag.
1203         * cli/cli-utils.h (struct info_print_options): Delete.
1204         (extract_info_print_options): Delete declaration.
1205         (info_print_command_completer): Delete declaration.
1206         (info_print_args_help): Add extra parameter, extend header
1207         comment.
1208         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1209         search_symbols.
1210         * stack.c (struct info_print_options): New type.
1211         (info_print_options_defs): New file scoped variable.
1212         (make_info_print_options_def_group): New static function.
1213         (info_print_command_completer): New static function.
1214         (info_locals_command): Update to use new local functions.
1215         (info_args_command): Likewise.
1216         (_initialize_stack): Add extra parameter to calls to
1217         info_print_args_help.
1218         * symtab.c (search_symbols): Add extra parameter, use this to
1219         possibly excluse non-debug symbols.
1220         (symtab_symbol_info): Add extra parameter, which is passed on to
1221         search_symbols.
1222         (struct info_print_options): New type.
1223         (info_print_options_defs): New file scoped variable.
1224         (make_info_print_options_def_group): New static function.
1225         (info_print_command_completer): New static function.
1226         (info_variables_command): Update to use local functions, and pass
1227         extra parameter through to symtab_symbol_info.
1228         (info_functions_command): Likewise.
1229         (info_types_command): Pass additional argument through to
1230         symtab_symbol_info.
1231         (rbreak_command): Pass extra argument to search_symbols.
1232         (_initialize_symtab): Add extra arguments for calls to
1233         info_print_args_help, and update help text for 'info variables',
1234         'whereis', and 'info functions' commands.
1235         * symtab.h (search_symbols): Add extra argument to declaration.
1236         * NEWS: Mention new flags.
1237
1238 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1239
1240         * symtab.c (lookup_static_symbol): Call the new function (and move
1241         it down to be next to lookup_global_symbol).
1242         (struct global_sym_lookup_data): Add block_enum member and rename to...
1243         (struct global_or_static_sym_lookup_data): ...this.
1244         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1245         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1246         (lookup_symbol_global_or_static_iterator_cb): ...this.
1247         (lookup_global_or_static_symbol): New function.
1248         (lookup_global_symbol): Call new function.
1249
1250 2019-08-26  Tom de Vries  <tdevries@suse.de>
1251
1252         PR c++/24852
1253         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1254         when pc_probe.prob == NULL.
1255
1256 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1257
1258         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1259         variable symbol_linkage to symbol_linkage_.
1260
1261 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1262
1263         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1264         represent whether the symbol is static, dynamic, or we don't
1265         know.
1266
1267 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1268
1269         * gdb/rx-tdep.c (rx_register_names): New.
1270         (rx_register_name): Delete.
1271         (rx_psw_type): Delete.
1272         (rx_fpsw_type): Delete.
1273         (rx_register_type): Delete.
1274         (rx_gdbarch_init): Convert target-descriptions.
1275         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1276         * gdb/features/Makefile: Add rx.xml.
1277         * gdb/features/rx.xml: New.
1278         * gdb/features/rx.c: Generated.
1279         * gdb/NEWS: Mention target description support.
1280
1281 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1282
1283         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1284         *slot_ptr.
1285
1286 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1287
1288         * configure.ac: Don't check for 'dlfcn.h' (moved to
1289         gdbsupport/common.m4).
1290         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1291         'gdbsupport/'.
1292         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1293         * compile/compile-c-support.c: Include
1294         'gdbsupport/gdb-dlfcn.h'.
1295         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1296         * gdb-dlfcn.c: Move to...
1297         * gdbsupport/gdb-dlfcn.c: ... here.
1298         * gdb-dlfcn.h: Move to...
1299         * gdbsupport/gdb-dlfcn.h: ... here.
1300
1301 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1302
1303         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1304         the offset field signed.
1305
1306 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1307
1308         * python/lib/gdb/__init__.py (_execute_file): New function.
1309         * python/python.c (python_run_simple_file): Call gdb._execute_file
1310         on Windows.
1311
1312 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1313
1314         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1315         all uses as this was never set to anything but a zero value.
1316
1317 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1318
1319         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1320
1321 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1322
1323         * tui/tui-data.h (tui_gen_win_info): Add an =default
1324         move constructor, required by some GCC versions.
1325
1326 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1327
1328         * go32-nat.c (go32_sysinfo): Add hygon_p.
1329
1330 2019-08-20  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1333         line_from_reg_element_no, first_reg_element_no_inline,
1334         display_all_data, delete_data_content_windows,
1335         erase_data_content>: Now private.
1336
1337 2019-08-20  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1340         (tui_unhighlight_win, tui_highlight_win)
1341         (tui_win_info::make_window): Update.
1342         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1343
1344 2019-08-20  Tom Tromey  <tom@tromey.com>
1345
1346         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1347         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1348         (MAX_PID_WIDTH): Move to tui-stack.c.
1349         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1350         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1351         (MAX_PID_WIDTH): Move from tui-data.h.
1352
1353 2019-08-20  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1356         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1357         (box_win): Update.
1358         (tui_gen_win_info::make_window): Rename from tui_make_window.
1359         (tui_win_info::make_window): New method.
1360         (tui_gen_win_info::make_visible): Update.
1361         * tui/tui-source.c (tui_source_window::set_contents): Update.
1362         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1363         (tui_data_window::display_registers_from): Update.
1364         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1365         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1366         Declare.
1367         <can_box>: Remove.
1368         <title>: Remove.
1369         (struct tui_win_info) <make_window>: Declare.
1370         <can_box>: Now virtual.
1371         <title>: New member.
1372         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1373         * tui/tui-command.c (tui_cmd_window::resize): Update.
1374
1375 2019-08-20  Tom Tromey  <tom@tromey.com>
1376
1377         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1378         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1379         (tui_data_window::check_register_values): Update.
1380
1381 2019-08-20  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-regs.h (struct tui_data_window): Use
1384         DISABLE_COPY_AND_ASSIGN.
1385         <regs_content>: Change type, removing unique_ptr.
1386         <tui_data_window>: Add move constructor.
1387         * tui/tui-regs.c (tui_data_window::show_registers)
1388         (tui_data_window::show_register_group)
1389         (tui_data_window::display_registers_from)
1390         (tui_data_window::display_registers_from)
1391         (tui_data_window::first_data_item_displayed)
1392         (tui_data_window::delete_data_content_windows)
1393         (tui_data_window::rerender, tui_data_window::refresh_window)
1394         (tui_data_window::check_register_values): Update.
1395
1396 2019-08-20  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1399         show_register_group>: Declare.
1400         (tui_show_register_group): Don't declare.
1401         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1402         tui_show_registers.
1403         (tui_data_window::show_register_group): Rename from
1404         tui_show_register_group.
1405         (tui_data_window::check_register_values, tui_reg_command):
1406         Update.
1407         * tui/tui-layout.c (tui_set_layout): Update.
1408
1409 2019-08-20  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1412         Declare.
1413         (tui_check_register_values): Don't declare.
1414         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1415         from tui_check_register_values.
1416         * tui/tui-hooks.c (tui_register_changed): Update.
1417
1418 2019-08-20  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-regs.c (tui_reg_layout): Move later.
1421         (tui_show_registers): Don't enable TUI mode or change layout.
1422
1423 2019-08-20  Tom Tromey  <tom@tromey.com>
1424
1425         * tui/tui-regs.h (struct tui_data_item_window)
1426         <~tui_data_item_window>: Remove.
1427         <content>: Now a unique_xmalloc_ptr.
1428         * tui/tui-regs.c (tui_register_format): Return a
1429         unique_xmalloc_ptr.
1430         (tui_get_register): Update.
1431         (~tui_data_item_window): Remove.
1432         (tui_data_window::display_registers_from, tui_display_register):
1433         Update.
1434         * tui/tui-io.h (tui_expand_tabs): Update.
1435         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1436         Remove "col" parameter.
1437
1438 2019-08-20  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1441         field.
1442         * tui/tui-regs.c (~tui_data_item_window): Update.
1443
1444 2019-08-20  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1447         earlier.
1448
1449 2019-08-20  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1452
1453 2019-08-20  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-source.h (struct tui_source_window): Update.
1456         * tui/tui-regs.c (tui_show_registers): Update.
1457         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1458         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1459         (NO_REGS_STRING): Remove defines.
1460
1461 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1462
1463         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1464         unnecessary thread walk if remote doesn't support the packet.
1465
1466 2019-08-19  Tom Tromey  <tromey@adacore.com>
1467
1468         * python/py-value.c (value_has_field): Fix indentation.
1469
1470 2019-08-19  Tom Tromey  <tromey@adacore.com>
1471
1472         * printcmd.c (do_one_display, info_display_command): Update.
1473         * block.h (contained_in): Return bool.  Add allow_nested
1474         parameter.
1475         * block.c (contained_in): Return bool.  Add allow_nested
1476         parameter.
1477
1478 2019-08-19  Tom Tromey  <tom@tromey.com>
1479
1480         * configure: Rebuild.
1481         * configure.ac: Disallow the combination of -static-libstdc++ and
1482         source highlight.
1483         * source-cache.c (get_language_name): Handle rust.
1484         (source_cache::get_source_lines): Ignore highlighting exceptions.
1485
1486 2019-08-16  Tom Tromey  <tom@tromey.com>
1487
1488         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1489         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1490         (struct tui_source_window_base) <make_visible, refresh_window,
1491         resize>: Remove methods.
1492         <execution_info>: Remove field.
1493         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1494         (tui_show_source_line, tui_source_window_base)
1495         (~tui_source_window_base): Update.
1496         (tui_source_window_base::resize)
1497         (tui_source_window_base::make_visible)
1498         (tui_source_window_base::refresh_window): Remove.
1499         (tui_source_window_base::update_exec_info): Update.
1500         * tui/tui-source.c (tui_source_window::set_contents): Update.
1501         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1502
1503 2019-08-16  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1506         deprecated_query_hook.
1507
1508 2019-08-16  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1511         (tui_update_source_windows_with_line): Update.
1512         * tui/tui-source.h (struct tui_source_window)
1513         <show_symtab_source>: Declare.
1514         (tui_show_symtab_source): Don't declare.
1515         * tui/tui-source.c (tui_show_symtab_source): Rename from
1516         tui_show_symtab_source.
1517
1518 2019-08-16  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-winsource.h (struct tui_source_window_base)
1521         <set_contents>: Declare.
1522         * tui/tui-winsource.c
1523         (tui_source_window_base::update_source_window_as_is): Update.
1524         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1525         Declare.
1526         (tui_set_source_content): Don't declare.
1527         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1528         tui_set_source_content.
1529         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1530         Declare.
1531         (tui_set_disassem_content): Don't declare.
1532         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1533         tui_set_disassem_content.
1534
1535 2019-08-16  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui-winsource.h (struct tui_source_window_base)
1538         <update_breakpoint_info>: Declare.
1539         (tui_update_breakpoint_info): Don't declare.
1540         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1541         (tui_update_all_breakpoint_info): Update.
1542         (tui_source_window_base::update_breakpoint_info): Rename from
1543         tui_update_breakpoint_info.
1544         (tui_source_window_base::update_exec_info): Update.
1545
1546 2019-08-16  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-winsource.h (struct tui_source_window_base)
1549         <update_source_window>: Declare.
1550         (tui_update_source_window): Don't declare.
1551         * tui/tui-winsource.c
1552         (tui_source_window_base::update_source_window): Rename from
1553         tui_update_source_window.
1554         (tui_source_window_base::rerender): Update.
1555         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1556         * tui/tui-disasm.c (tui_show_disassem)
1557         (tui_show_disassem_and_update_source)
1558         (tui_disasm_window::maybe_update): Update.
1559
1560 2019-08-16  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-winsource.h (struct tui_source_window_base)
1563         <update_source_window_as_is>: Declare.
1564         (tui_update_source_window_as_is): Don't declare.
1565         * tui/tui-winsource.c (tui_update_source_window): Update
1566         (tui_source_window_base::update_source_window_as_is): Rename from
1567         tui_update_source_window_as_is.
1568         (tui_source_window_base::refill): Update.
1569         * tui/tui-source.c (tui_show_symtab_source): Update.
1570         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1571         Update.
1572
1573 2019-08-16  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-winsource.h (tui_update_source_window)
1576         (tui_update_source_window_as_is): Remove "noerror" parameter.
1577         * tui/tui-winsource.c (tui_update_source_window)
1578         (tui_update_source_window_as_is): Remove "noerror" parameter.
1579         (tui_update_source_windows_with_addr)
1580         (tui_update_source_windows_with_line)
1581         (tui_source_window_base::rerender)
1582         (tui_source_window_base::refill): Update.
1583         * tui/tui-source.h (tui_set_source_content)
1584         (tui_show_symtab_source): Remove "noerror" parameter.
1585         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1586         parameter.
1587         (tui_show_symtab_source): Likewise.
1588         (tui_source_window::maybe_update): Update.
1589         * tui/tui-disasm.c (tui_show_disassem)
1590         (tui_show_disassem_and_update_source)
1591         (tui_disasm_window::do_scroll_vertical)
1592         (tui_disasm_window::maybe_update): Update.
1593
1594 2019-08-16  Tom Tromey  <tom@tromey.com>
1595
1596         * tui/tui.c (tui_is_window_visible): Update.
1597         * tui/tui-wingeneral.c (tui_make_window)
1598         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1599         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1600         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1601         (tui_set_win_height_command, parse_scrolling_args): Update.
1602         * tui/tui-source.c (tui_source_window::style_changed): Update.
1603         * tui/tui-regs.c (tui_show_registers)
1604         (tui_data_window::first_data_item_displayed)
1605         (tui_data_window::delete_data_content_windows)
1606         (tui_check_register_values, tui_reg_command): Update.
1607         * tui/tui-disasm.c (tui_show_disassem): Update.
1608         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1609         method.
1610         <is_visible>: Remove field.
1611         * tui/tui-data.c (tui_next_win, tui_prev_win)
1612         (tui_delete_invisible_windows): Update.
1613
1614 2019-08-16  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-winsource.h (struct tui_source_window_base)
1617         <m_has_locator>: Remove.
1618         * tui/tui-layout.c (show_source_disasm_command, show_data)
1619         (show_source_or_disasm_and_command): Update.
1620
1621 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1622
1623         * NEWS (Other MI changes): New subsection.
1624         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1625         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1626         * arch-utils.c (default_get_pc_address_flags): New function.
1627         * arch-utils.h (default_get_pc_address_flags): New declaration.
1628         * gdbarch.sh: Add get_pc_address_flags.
1629         * gdbarch.c: Regenerate.
1630         * gdbarch.h: Likewise.
1631         * stack.c (print_pc): New function.
1632         (print_frame_info) (print_frame): Call print_pc.
1633
1634 2019-08-16  Tom de Vries  <tdevries@suse.de>
1635
1636         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1637         print_objfile_section_info.
1638
1639 2019-08-15  Tom Tromey  <tom@tromey.com>
1640
1641         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1642         calling update_cmdwin_start_line.
1643         * tui/tui-winsource.h (struct tui_source_window_base)
1644         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1645         <rerender>: Declare.
1646         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1647         Call rerender.
1648         (tui_source_window_base::set_new_height): Remove.
1649         (tui_source_window_base::rerender): Rename from
1650         do_make_visible_with_new_height.
1651         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1652         resize method.
1653         (tui_win_info::make_invisible_and_set_new_height)
1654         (tui_win_info::make_visible_with_new_height): Remove.
1655         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1656         Declare.
1657         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1658         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1659         do_make_visible_with_new_height>: Don't declare.
1660         <rerender>: Declare.
1661         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1662         set_new_height.
1663         (tui_data_window::do_make_visible_with_new_height): Remove.
1664         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1665         call tui_show_locator_content.
1666         (tui_gen_win_info::resize): Call rerender.
1667         (show_source_or_disasm_and_command): Don't call
1668         tui_show_locator_content.
1669         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1670         method.
1671         (struct tui_win_info) <rerender>: Declare.
1672         <set_new_height, make_invisible_and_set_new_height,
1673         make_visible_with_new_height>: Don't declare.
1674         * tui/tui-data.c (tui_win_list::rerender): New method.
1675         * tui/tui-command.h (struct tui_cmd_window)
1676         <do_make_visible_with_new_height>: Don't declare.
1677         * tui/tui-command.c
1678         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1679
1680 2019-08-15  Tom Tromey  <tromey@adacore.com>
1681
1682         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1683         * ada-lang.c (ada_enum_name): Likewise.
1684
1685 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1686
1687         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1688         leading underscore.
1689         (GdbOutputErrorFile): Likewise.
1690         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1691         accordingly.
1692         (execute_unwinders): Rename to have a leading underscore.
1693         (auto_load_packages): Likewise.
1694         (global scope): Adjust call to auto_load_packages accordingly.
1695         (GdbSetPythonDirectory): Likewise.
1696         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1697         instead of execute_unwinders.
1698
1699 2019-08-15  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1702         (show_data): Don't change window visibility.
1703         (tui_gen_win_info::resize): Remove special case for command
1704         window.  Use wresize, when available.
1705         (show_source_or_disasm_and_command): Don't change window
1706         visibility.
1707         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1708         <make_visible>: New method.
1709         * tui/tui-command.c (tui_cmd_window::resize): New method.
1710
1711 2019-08-15  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1714         (struct tui_source_windows): New.
1715         * tui/tui-winsource.c (tui_display_main): Update.
1716         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1717         (new_height_ok, parse_scrolling_args): Update.
1718         * tui/tui-layout.c (show_layout, show_data): Update.
1719         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1720         (tui_add_to_source_windows): Don't declare.
1721         * tui/tui-data.c (source_windows, tui_source_windows)
1722         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1723
1724 2019-08-15  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1727         Rename from reset.
1728         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1729         * tui/tui-layout.c (show_source_disasm_command, show_data):
1730         Update.
1731         (tui_gen_win_info::resize): Rename.
1732         (show_source_or_disasm_and_command): Update.
1733         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1734         reset.
1735
1736 2019-08-15  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1739         * tui/tui-interp.c (tui_interp::init): Don't call
1740         tui_initialize_static_data.
1741         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1742
1743 2019-08-15  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1746         examine tui_win_list.
1747
1748 2019-08-15  Tom Tromey  <tom@tromey.com>
1749
1750         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1751         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1752         tui_clear_source_content.
1753         (tui_clear_source_content): Remove.
1754         (tui_source_window_base::do_erase_source_content): Hoist call to
1755         content.clear().
1756         * tui/tui-stack.c (tui_show_frame_info): Don't call
1757         tui_clear_source_content.
1758
1759 2019-08-15  Tom Tromey  <tom@tromey.com>
1760
1761         * tui/tui-winsource.h (struct tui_source_window_base)
1762         <do_erase_source_content>: New method.
1763         <erase_source_content>: New method.
1764         (tui_erase_source_content): Don't declare.
1765         * tui/tui-winsource.c (tui_clear_source_content): Update.
1766         (tui_source_window_base::do_erase_source_content): Rename from
1767         tui_erase_source_content.
1768         (tui_source_window_base::show_source_content): Update.
1769         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1770         * tui/tui-source.h (struct tui_source_window)
1771         <erase_source_content>: New method.
1772         * tui/tui-disasm.h (struct tui_disasm_window)
1773         <erase_source_content>: New method.
1774
1775 2019-08-15  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1778         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1779         constructor.
1780         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1781         * tui/tui-source.c (tui_set_source_content): Update.
1782         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1783
1784 2019-08-15  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1787         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1788         tui-source.c.
1789         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1790         Declare.
1791         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1792         method.
1793         (tui_source_window::maybe_update): Update.
1794
1795 2019-08-15  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1798         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1799         tui-disasm.c.
1800         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1801         Declare.
1802         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1803         method.
1804         (tui_disasm_window::maybe_update): Update.
1805
1806 2019-08-15  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-winsource.h (struct tui_source_window_base)
1809         <maybe_update>: Declare.
1810         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1811         method.
1812         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1813         Declare.
1814         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1815         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1816         Declare.
1817         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1818
1819 2019-08-15  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1822
1823 2019-08-15  Tom Tromey  <tom@tromey.com>
1824
1825         * tui/tui-wingeneral.c: Include tui-stack.h.
1826         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1827         (struct tui_locator_window): Move from tui-data.h.
1828         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1829         (tui_initialize_static_data): Move from tui-data.c.
1830         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1831         (struct tui_locator_window): Move to tui-stack.c.
1832         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1833         (tui_initialize_static_data): Move to tui-stack.c.
1834
1835 2019-08-15  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-layout.c (show_source_disasm_command)
1838         (show_source_or_disasm_and_command): Use make_visible method, not
1839         tui_make_window.
1840         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1841         Remove.
1842
1843 2019-08-15  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-wingeneral.h (tui_make_window): Update.
1846         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1847         parameter.
1848         (tui_gen_win_info::make_visible): Update.
1849         * tui/tui-regs.c (tui_data_window::display_registers_from):
1850         Update.
1851         * tui/tui-layout.c (show_source_disasm_command)
1852         (show_source_or_disasm_and_command): Update.
1853         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1854         (enum tui_box): Remove.
1855         (struct tui_win_info) <can_box>: New method.
1856         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1857         method.
1858
1859 2019-08-15  Tom de Vries  <tdevries@suse.de>
1860
1861         * linux-nat-trad.c: Include gdbarch.h.
1862
1863 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1864
1865         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1866         register sizes.
1867
1868 2019-08-14  Tom Tromey  <tromey@adacore.com>
1869
1870         * darwin-nat.c: Include gdbarch.h.
1871         * darwin-nat-info.c: Include gdbarch.h.
1872
1873 2019-08-13  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1876         Remove.
1877         * tui/tui-data.c (tui_initialize_static_data): Update.
1878
1879 2019-08-13  Tom Tromey  <tom@tromey.com>
1880
1881         * tui/tui-winsource.h (struct tui_exec_info_window)
1882         <~tui_exec_info_window, maybe_allocate_content, get_content,
1883         m_content>: Remove.
1884         (struct tui_source_window_base) <set_exec_info_content,
1885         show_exec_info_content>: Don't declare.
1886         * tui/tui-winsource.c
1887         (tui_exec_info_window::maybe_allocate_content): Remove.
1888         (tui_source_window_base::update_exec_info): Rename from
1889         set_exec_info_content.
1890         (tui_source_window_base::show_exec_info_content)
1891         (tui_source_window_base::update_exec_info): Remove.
1892
1893 2019-08-13  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1896         declare.
1897         * tui/tui-winsource.c (tui_update_source_window_as_is)
1898         (tui_update_source_windows_with_addr, tui_erase_source_content):
1899         Update.
1900         (tui_clear_exec_info_content): Remove.
1901
1902 2019-08-13  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1905         declare.
1906         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1907         call tui_erase_exec_info_content.
1908         (tui_clear_exec_info_content): Rename from
1909         tui_erase_exec_info_content.
1910         (tui_clear_exec_info_content): Delete.
1911
1912 2019-08-13  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-winsource.h (struct tui_source_window_base)
1915         <show_exec_info_content>: Declare.
1916         (tui_show_exec_info_content): Don't declare.
1917         * tui/tui-winsource.c
1918         (tui_source_window_base::show_exec_info_content): Rename from
1919         tui_show_exec_info_content.
1920         (tui_source_window_base::update_exec_info): Update.
1921
1922 2019-08-13  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1925         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1926         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1927         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1928         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1929         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1930         ... here.
1931
1932 2019-08-13  Tom Tromey  <tom@tromey.com>
1933
1934         * tui/tui-winsource.h (struct tui_source_window_base)
1935         <update_exec_info>: Declare.
1936         (tui_update_exec_info): Don't declare.
1937         * tui/tui-winsource.c (tui_update_source_window_as_is)
1938         (tui_source_window_base::refresh_all)
1939         (tui_update_all_breakpoint_info): Update.
1940         (tui_source_window_base::update_exec_info): Rename from
1941         tui_update_exec_info.
1942         * tui/tui-stack.c (tui_show_frame_info): Update.
1943
1944 2019-08-13  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-winsource.h (struct tui_source_window_base)
1947         <set_exec_info_content>: Declare.
1948         (tui_set_exec_info_content): Don't declare.
1949         * tui/tui-winsource.c
1950         (tui_source_window_base::set_exec_info_content): Rename from
1951         tui_set_exec_info_content.
1952         (tui_update_exec_info): Update.
1953
1954 2019-08-13  Tom Tromey  <tom@tromey.com>
1955
1956         * tui/tui-winsource.h (struct tui_source_window_base)
1957         <show_source_content>: Declare.
1958         (tui_show_source_content): Don't declare.
1959         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1960         (tui_source_window_base::show_source_content): Rename from
1961         tui_show_source_content.
1962         (tui_source_window_base::refresh_all): Update.
1963         * tui/tui-layout.c (show_source_disasm_command)
1964         (show_source_or_disasm_and_command): Update.
1965
1966 2019-08-13  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-winsource.c (tui_erase_source_content)
1969         (tui_show_source_content, tui_source_window_base::refresh_all):
1970         Update.
1971         * tui/tui-wingeneral.h
1972         (tui_check_and_display_highlight_if_needed): Don't declare.
1973         * tui/tui-wingeneral.c
1974         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1975         check_and_display_highlight_if_needed.
1976         * tui/tui-win.c (tui_rehighlight_all)
1977         (tui_win_info::make_visible_with_new_height): Update.
1978         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1979         (tui_data_window::erase_data_content)
1980         (tui_data_window::display_all_data): Update.
1981         * tui/tui-data.h (struct tui_win_info)
1982         <check_and_display_highlight_if_needed>: Declare.
1983
1984 2019-08-13  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-win.c (tui_resize_all): Call
1987         tui_delete_invisible_windows.
1988         * tui/tui-layout.c (show_layout): Call
1989         tui_delete_invisible_windows.
1990         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1991         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1992
1993 2019-08-13  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1996         tui_add_win_to_layout.
1997
1998 2019-08-13  Tom Tromey  <tom@tromey.com>
1999
2000         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2001         * tui/tui-layout.c (tui_default_win_height): Now static.
2002
2003 2019-08-13  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2006         single switch.
2007         (show_source_disasm_command, show_source_or_disasm_and_command):
2008         Don't check current layout.
2009
2010 2019-08-13  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-wingeneral.c (make_all_visible): Remove.
2013         (tui_make_all_invisible): Simplify.
2014         * tui/tui-layout.c (tui_make_all_invisible): Move from
2015         tui-wingeneral.c; simplify.
2016         (show_layout): Hoist call to tui_make_all_invisible.
2017         (show_data): Don't call tui_make_all_invisible.
2018
2019 2019-08-13  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2022         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2023
2024 2019-08-13  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2027         tui-data.c.
2028         (show_source_disasm_command, show_data)
2029         (show_source_or_disasm_and_command): Don't use
2030         tui_set_current_layout_to.
2031         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2032         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2033         tui-layout.c.
2034         (tui_set_current_layout_to): Remove.
2035
2036 2019-08-13  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-layout.c (tui_set_layout): Update.
2039         * tui/tui-data.h (struct tui_layout_def): Remove.
2040         (tui_layout_def): Don't declare.
2041         * tui/tui-data.c (layout_def): Remove.
2042         (tui_layout_def): Remove.
2043
2044 2019-08-13  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-winsource.h (struct tui_source_window_base)
2047         <clear_detail>: No longer "override".
2048         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2049         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2050         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2051         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2052         Remove.
2053         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2054
2055 2019-08-13  Tom Tromey  <tromey@adacore.com>
2056
2057         * tracepoint.c: Don't include readline.h or history.h.
2058
2059 2019-08-12  Tom Tromey  <tom@tromey.com>
2060
2061         * configure: Rebuild.
2062         * configure.ac: Check for readline 7.
2063         * NEWS: Mention readline 7 requirement.
2064         * README: Update.
2065
2066 2019-08-12  Tom Tromey  <tom@tromey.com>
2067
2068         * mingw-hdep.c (gdb_select): Remove readline hack.
2069
2070 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2071
2072         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2073         when the function fails.
2074
2075 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2076
2077         * s390-tdep.c (s390_type_align): New function.
2078         (s390_gdbarch_init): Set it as type_align gdbarch method.
2079
2080 2019-08-09  Tom de Vries  <tdevries@suse.de>
2081
2082         PR gdb/24591
2083         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2084         pc_low with relocation offset.
2085
2086 2019-08-07  Tom Tromey  <tromey@adacore.com>
2087
2088         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2089         (print_frame_args): Update.
2090         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2091         Update.
2092         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2093         * frame.h (struct frame_arg): Add initializers.
2094         <error>: Now a unique_xmalloc_ptr.
2095
2096 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2097
2098         * NEWS: Expand the Pointer Authentication entry.
2099         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2100         (aarch64_frame_unmask_lr): ... to this.
2101         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2102         Call aarch64_frame_unmask_lr.
2103         * frame.c (struct frame_info): Add "masked" variable.
2104         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2105         (fprint_frame): Check for masked pc.
2106         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2107         declarations.
2108         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2109         * stack.c (print_frame): Check for masked pc.
2110
2111 2019-08-06  Tom Tromey  <tom@tromey.com>
2112
2113         * stabsread.c (patch_block_stabs, read_one_struct_field)
2114         (read_enum_type): Use obstack_strndup.
2115         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2116         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2117         * dwarf2read.c (guess_full_die_structure_name)
2118         (anonymous_struct_prefix): Use obstack_strndup.
2119         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2120         * c-exp.y (yylex): Use obstack_strndup.
2121         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2122         (write_var_or_type): Use obstack_strndup.
2123
2124 2019-08-06  Tom Tromey  <tom@tromey.com>
2125
2126         * symfile.c (reread_symbols): Use obstack_strdup.
2127         * stabsread.c (read_type): Use obstack_strdup.
2128         * gdb_obstack.h (obstack_strdup): New overload.
2129         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2130         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2131         (dwarf2_canonicalize_name): Use obstack_strdup.
2132         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2133         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2134         Use obstack_strdup.
2135
2136 2019-08-06  Tom Tromey  <tom@tromey.com>
2137
2138         * gdb_obstack.h (obstack_strdup): Define.
2139         * gdb_obstack.c (obstack_strdup): Don't define.
2140
2141 2019-08-06  Tom Tromey  <tom@tromey.com>
2142
2143         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2144         obstack_strdup.
2145         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2146         obstack_strdup.
2147         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2148         * stabsread.c (common_block_start): Use obstack_strdup.
2149         * objfiles.c (set_objfile_main_name, objfile): Use
2150         obstack_strdup.
2151         * namespace.c (add_using_directive): Use obstack_strdup.
2152         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2153         * jit.c (finalize_symtab): Use obstack_strdup.
2154         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2155         (guess_partial_die_structure_name, partial_die_info::fixup)
2156         (dwarf2_name): Use obstack_strdup.
2157         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2158         obstack_strdup.
2159         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2160         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2161         obstack_strdup.
2162         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2163
2164 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2165
2166         * unittests/help-doc-selftests.c: New file.
2167         * Makefile.in: Add the new file.
2168
2169 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2170
2171         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2172         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2173         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2174         the trailing '.' is not output, and the first character is uppercased.
2175         (print_help_for_command): Update call to print_doc_line.
2176         (print_doc_of_command): Likewise.
2177         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2178         * cli/cli-option.c (append_indented_doc): Do not append newline.
2179         (build_help_option): Append newline after first appended_indented_doc
2180         only if a second call is done.
2181         (build_help): Append 2 new lines before each option, except the first
2182         one.
2183         * compile/compile.c (_initialize_compile): Add new lines after
2184         %OPTIONS%, when not at the end of the help.
2185         Change help doc or code
2186         producing the help doc to respect the invariants.
2187         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2188         Also removed the new line after 'Options:', as all other commands
2189         do not put an empty line between 'Options:' and the first option.
2190         * printcmd.c (_initialize_printcmd): Likewise.
2191         * stack.c (_initialize_stack): Likewise.
2192         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2193         incorrectly telling COMMAND is optional.
2194         * ada-lang.c (_initialize_ada_language): Change help doc or code
2195         producing the help doc to respect the invariants.
2196         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2197         * breakpoint.c (_initialize_breakpoint): Likewise.
2198         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2199         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2200         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2201         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2202         _initialize_cli_style): Likewise.
2203         * corelow.c (core_target_info): Likewise.
2204         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2205         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2206         * filesystem.c (_initialize_filesystem): Likewise.
2207         * frame.c (_initialize_frame): Likewise.
2208         * gnu-nat.c (add_task_commands): Likewise.
2209         * infcall.c (_initialize_infcall): Likewise.
2210         * infcmd.c (_initialize_infcmd): Likewise.
2211         * interps.c (_initialize_interpreter): Likewise.
2212         * language.c (_initialize_language): Likewise.
2213         * linux-fork.c (_initialize_linux_fork): Likewise.
2214         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2215         * maint.c (_initialize_maint_cmds): Likewise.
2216         * memattr.c (_initialize_mem): Likewise.
2217         * printcmd.c (_initialize_printcmd): Likewise.
2218         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2219         _RegEx): Likewise.
2220         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2221         * record-btrace.c (_initialize_record_btrace): Likewise.
2222         * record-full.c (_initialize_record_full): Likewise.
2223         * record.c (_initialize_record): Likewise.
2224         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2225         * regcache.c (_initialize_regcache): Likewise.
2226         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2227         _initialize_remote): Likewise.
2228         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2229         * serial.c (_initialize_serial): Likewise.
2230         * skip.c (_initialize_step_skip): Likewise.
2231         * source.c (_initialize_source): Likewise.
2232         * stack.c (_initialize_stack): Likewise.
2233         * symfile.c (_initialize_symfile): Likewise.
2234         * symtab.c (_initialize_symtab): Likewise.
2235         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2236         * top.c (init_main): Likewise.
2237         * tracefile-tfile.c (tfile_target_info): Likewise.
2238         * tracepoint.c (_initialize_tracepoint): Likewise.
2239         * tui/tui-win.c (_initialize_tui_win): Likewise.
2240         * utils.c (add_internal_problem_command): Likewise.
2241         * valprint.c (value_print_option_defs): Likewise.
2242
2243 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2244
2245         PR build/24886
2246         * configure.ac: Drop enable-libmcheck support.
2247         * configure, config.in: Rebuild.
2248         * libmcheck.m4: Remove.
2249         * acinclude.m4: Don't include it.
2250         * Makefile.in: Don't distribute it.
2251         * top.c (print_gdb_configuration): Don't mention it.
2252
2253 2019-08-06  Tom Tromey  <tom@tromey.com>
2254
2255         * utils.c (set_output_style): Sometimes pass stream to
2256         emit_style_escape.
2257         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2258         * record-btrace.c (btrace_insn_history): Update.
2259         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2260         method.
2261         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2262         Update initializers.
2263         <m_uiout>: New field.
2264         <m_di>: Move lower.
2265         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2266         Remove "uiout" parameter.
2267         (dump_insns): Update.
2268         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2269         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2270
2271 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2272
2273         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2274         (error_in_psymtab_expansion): Likewise.
2275         (lookup_symbol_via_quick_fns): Likewise.
2276         (basic_lookup_transparent_type_quick): Likewise.
2277         (basic_lookup_transparent_type_1): Likewise.
2278
2279 2019-08-06  Tom Tromey  <tromey@adacore.com>
2280
2281         * source.c (last_source_error): Now bool.
2282         (print_source_lines_base): Make "noprint" bool.  Only open
2283         source file when last_source_visited changes.
2284
2285 2019-08-06  Tom Tromey  <tromey@adacore.com>
2286
2287         * annotate.c (annotate_source_line): Use g_source_cache.
2288         * source-cache.c (source_cache::get_plain_source_lines): Change
2289         parameters.  Populate m_offset_cache.
2290         (source_cache::ensure): New method.
2291         (source_cache::get_line_charpos): New method.
2292         (extract_lines): Move lower.  Change parameters.
2293         (source_cache::get_source_lines): Move lower.
2294         * source-cache.h (class source_cache): Update comment.
2295         <get_line_charpos>: New method.
2296         <get_source_lines>: Update comment.
2297         <clear>: Clear m_offset_cache.
2298         <get_plain_source_lines>: Change parameters.
2299         <ensure>: New method
2300         <m_offset_cache>: New member.
2301         * source.c (forget_cached_source_info_for_objfile): Update.
2302         (info_source_command): Use g_source_cache.
2303         (find_source_lines, open_source_file_with_line_charpos): Remove.
2304         (print_source_lines_base, search_command_helper): Use g_source_cache.
2305         * source.h (open_source_file_with_line_charpos): Don't declare.
2306         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2307         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2308         Use g_source_cache.
2309
2310 2019-08-06  Tom Tromey  <tromey@adacore.com>
2311
2312         * source-cache.c (source_cache::get_plain_source_lines):
2313         Remove "first_line" and "last_line" parameters.
2314         (source_cache::get_source_lines): Cache plain text.
2315         * source-cache.h (class source_cache)
2316         <get_plain_source_lines>: Update.
2317
2318 2019-08-06  Tom Tromey  <tromey@adacore.com>
2319
2320         * source-cache.c (extract_lines): No longer a method.
2321         Changed type of parameter.  Include final newline.
2322         (selftests::extract_lines_test): New function.
2323         (_initialize_source_cache): Likewise.
2324         * source-cache.h (class source_cache)
2325         <extract_lines>: Don't declare.
2326
2327 2019-08-06  Tom Tromey  <tromey@adacore.com>
2328
2329         * breakpoint.c (init_breakpoint_sal): Update.
2330         (breakpoint): Update.
2331         * breakpoint.h (struct breakpoint) <filter>: Now a
2332         unique_xmalloc_ptr.
2333
2334 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2335
2336         * NEWS: Mention dictionary access on blocks.
2337         * python/py-block.c (blpy_getitem): New function.
2338         (block_object_as_mapping): New struct.
2339         (block_object_type): Use new struct for tp_as_mapping field.
2340
2341 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2342
2343         * objfiles.h (objfile): Add a comment describing partial symbols.
2344
2345 2019-08-05  Tom Tromey  <tromey@adacore.com>
2346
2347         * compile/compile.c (_initialize_compile): Use _(), not N_().
2348         * thread.c (_initialize_thread): Use _(), not N_().
2349         * stack.c (_initialize_stack): Use _(), not N_().
2350         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2351
2352 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2353
2354         * dwarf2read.c (struct dw2_symtab_iterator):
2355         <want_specific_block>: Remove.
2356         <block_index>: Change type to gdb::optional.
2357         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2358         change type of BLOCK_INDEX parameter to gdb::optional.
2359         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2360         (dw2_lookup_symbol): Don't pass argument for
2361         WANT_SPECIFIC_BLOCK.
2362         (dw2_expand_symtabs_for_function): Don't pass argument for
2363         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2364         (class dw2_debug_names_iterator)
2365         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2366         parameter, change BLOCK_INDEX type to gdb::optional.
2367         <m_want_specific_block>: Remove.
2368         <m_block_index>: Change type to gdb::optional.
2369         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2370         gdb::optional.  Re-write in function of gdb::optional.
2371         (dw2_debug_names_lookup_symbol): Don't pass argument for
2372         WANT_SPECIFIC_BLOCK.
2373         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2374         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2375         BLOCK_INDEX.
2376
2377 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2378
2379         * NEWS: Mention changes to "info sources" command.
2380
2381 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2382
2383         * symtab.c (filename_partial_match_opts): New struct type.
2384         (struct output_source_filename_data): New members
2385         regexp, c_regexp, partial_match.
2386         (output_source_filename): Use new members to decide to print file.
2387         (info_sources_option_defs): New variable.
2388         (make_info_sources_options_def_group, print_info_sources_header,
2389         info_sources_command_completer):
2390         New functions.
2391         (info_sources_command): Read new optional arguments.
2392         (_initialize_symtab): Update info sources help.
2393
2394 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2395
2396         * ada-lang.c (exception_support_info_v0): Renamed from...
2397         (default_exception_support_info): ... this.  Create new
2398         definition for v1.
2399         (ada_has_this_exception_support): Look up catch_handlers_sym.
2400         (ada_exception_support_info_sniffer): Try v0 after default.
2401
2402 2019-08-01  Tom Tromey  <tromey@adacore.com>
2403
2404         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2405         gdbarch.h.
2406
2407 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2408
2409         * s12z-tdep.c: Fix include path for s12z-opc.h.
2410
2411 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2412
2413         * NEWS: Require GNU make 3.82.
2414
2415 2019-07-16  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2418         declare.
2419
2420 2019-07-30  Tom Tromey  <tromey@adacore.com>
2421
2422         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2423
2424 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2425
2426         * printcmd.c (print_address_symbolic): Print negative offsets.
2427         (build_address_symbolic): Force signed arithmetic when computing
2428         offset.
2429
2430 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2431
2432         PR/24474: Add a function to lookup static variables.
2433         * NEWS: Mention this new function.
2434         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2435         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2436         * python/python.c (python_GdbMethods): Add new function.
2437
2438 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2439
2440         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2441         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2442         (objfpy_lookup_static_symbol): New function.
2443         (objfile_object_methods): Add new functions.
2444
2445 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2446
2447         * NEWS: Mention 'set|show print frame-info'.  Mention new
2448         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2449         backtrace argument.  Mention that python frame filtering code
2450         is now consistent with what 'backtrace' command prints.
2451
2452 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2453
2454         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2455         comments.
2456         (print_frame_info_auto, print_frame_info_source_line,
2457         print_frame_info_location, print_frame_info_source_and_location,
2458         print_frame_info_location_and_address, print_frame_info_short_location):
2459         New declarations.
2460         (struct frame_print_options): New member print_frame_info.
2461         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2462         * stack.h (get_user_print_what_frame_info): New declaration.
2463         (frame_show_address): New declaration.
2464         * stack.c (print_frame_arguments_choices): New value 'presence'.
2465         (print_frame_info_auto, print_frame_info_source_line,
2466         print_frame_info_location, print_frame_info_source_and_location,
2467         print_frame_info_location_and_address, print_frame_info_short_location,
2468         print_frame_info_choices, print_frame_info_print_what): New definitions.
2469         (print_frame_args): Only print dots for args if print frame-arguments
2470         is 'presence'.
2471         (frame_print_option_defs): New element for "frame-info".
2472         (get_user_print_what_frame_info): New function.
2473         (frame_show_address): Make non static.  Move comment to stack.h.
2474         (print_frame_info_to_print_what): New function.
2475         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2476         to decide what to print.
2477         (backtrace_command_1): Handle the new print_frame_arguments_presence
2478         value.
2479         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2480         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2481         (py_print_frame): In non-mi mode, use LOCATION as default for
2482         print_what, similarly to frame information printed directly by
2483         backtrace command. Handle frame-info user option in non MI mode.
2484
2485 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2486
2487         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2488         Add case for debugging 32-bit target on 64-bit host.  Revise
2489         comment.
2490
2491 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2492
2493         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2494         instead of find_function_entry_range_from_pc.
2495
2496 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2497
2498         * stack.c (find_frame_funname): Remove code which preferred
2499         minsym over symtab sym in "certain pathological cases".
2500
2501         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2502         parameter.  Change type of "do_demangle" to bool.
2503         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2504         Pass suitable "prefer_sym_over_minsym" flag to
2505         build_address_symbolic().  Don't output "+" for negative offsets.
2506         * printcmd.c (print_address_symbolic): Update invocation of
2507         build_address_symbolic to include a "prefer_sym_over_minsym"
2508         flag.
2509         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2510         Restrict cases in which use of minimal symbol is preferred to that
2511         of a found symbol.  Update comments.
2512
2513         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2514         for entry pc when entry pc is out of range for that FDE.
2515
2516 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2517
2518         PR gdb/24839:
2519         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2520         type.
2521
2522 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2523
2524         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2525         this function's Python signature.
2526
2527
2528 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2529
2530         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2531         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2532         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2533         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2534         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2535
2536
2537 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2538
2539         * h8300-tdep.c (h8300_register_name_common): New.
2540         h8300_register_name): Use h8300_register_name_common.
2541         (h8300s_register_name): Likewise.
2542         (h8300sx_register_name): Likewise.
2543         (h8300h_register_nam): New.
2544         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2545
2546
2547 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2548
2549         * arm-tdep.c (arm_skip_cmse_entry): New function.
2550         (arm_is_sgstubs_section): New function.
2551         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2552
2553 2019-07-22  Tom Tromey  <tom@tromey.com>
2554
2555         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2556         Don't self-assign.
2557
2558 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2559
2560         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2561         type_print.
2562
2563 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2564
2565         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2566         so that GDB doesn't match any msymbols when searching in the
2567         TYPES_DOMAIN.
2568         (print_symbol_info): Print using typedef_print or type_print based
2569         on the type of the symbol.  Add updated FIXME comment moved from...
2570         (_initialize_symtab): ... move and update FIXME comment to above.
2571
2572 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2573
2574         * NEWS: Mention adding -q option to "info types".
2575         * symtab.c (struct info_types_options): New struct.
2576         (info_types_options_defs): New variable.
2577         (make_info_types_options_def_group): New function.
2578         (info_types_command): Use gdb::option framework to parse options.
2579         (info_types_command_completer): New function.
2580         (_initialize_symtab): Extend the help text on "info types" and
2581         register command completer.
2582
2583 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2584
2585         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2586         (lookup_symbol_in_objfile): Change int to block_enum and add a
2587         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2588
2589 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2590
2591         * MAINTAINERS (Write After Approval): Add self.
2592
2593 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2594
2595         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2596         instruction to the dummy code region.
2597
2598 2019-07-19  Tom Tromey  <tromey@adacore.com>
2599
2600         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2601         (ARGSUSED, PARAMS, __func__): Remove rules.
2602
2603 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2604
2605         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2606         * features/arm/arm-with-iwmmxt.c: Remove.
2607         * features/arm/arm-with-iwmmxt.xml: Remove.
2608         * features/arm/arm-with-m-fpa-layout.c: Remove.
2609         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2610         * features/arm/arm-with-m-vfp-d16.c: Remove.
2611         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2612         * features/arm/arm-with-m.c: Remove.
2613         * features/arm/arm-with-m.xml: Remove.
2614         * features/arm/arm-with-neon.c: Remove.
2615         * features/arm/arm-with-neon.xml: Remove.
2616         * features/arm/arm-with-vfpv2.c: Remove.
2617         * features/arm/arm-with-vfpv2.xml: Remove.
2618         * features/arm/arm-with-vfpv3.c: Remove.
2619         * features/arm/arm-with-vfpv3.xml: Remove.
2620
2621 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2622
2623         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2624
2625 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2626
2627         * arch/aarch32.c (aarch32_create_target_description): Create
2628         target descriptions using features.
2629         * arch/arm.c (arm_create_target_description)
2630         (arm_create_mprofile_target_description): Likewise.
2631         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2632
2633 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2634
2635         * Makefile.in: Add new files.
2636         * aarch32-tdep.c: New file.
2637         * aarch32-tdep.h: New file.
2638         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2639         Call aarch32_read_description.
2640         * arch/aarch32.c: New file.
2641         * arch/aarch32.h: New file.
2642         * arch/arm.c (arm_create_target_description)
2643         (arm_create_mprofile_target_description): New function.
2644         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2645         (arm_create_target_description)
2646         (arm_create_mprofile_target_description): New declaration.
2647         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2648         read_description functions.
2649         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2650         Likewise.
2651         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2652         * arm-tdep.c (tdesc_arm_list): New variable.
2653         (arm_register_g_packet_guesses): Call create description functions.
2654         (arm_read_description) (arm_read_mprofile_description): New
2655         function.
2656         * arm-tdep.h (arm_read_description)
2657         (arm_read_mprofile_description): Add declaration.
2658         * configure.tgt: Add new files.
2659
2660 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2661
2662         * top.c (new_ui_command): Open specified terminal just once.
2663
2664 2019-07-18  Tom Tromey  <tromey@adacore.com>
2665
2666         * symtab.c (main_name): Constify return type.
2667         * symfile.c (set_initial_language): Update.
2668         * symtab.h (main_name): Constify return type.
2669
2670 2019-07-17  Tom Tromey  <tom@tromey.com>
2671
2672         * tui/tui-winsource.c (tui_update_source_window)
2673         (tui_update_source_window_as_is)
2674         (tui_update_source_windows_with_line): Remove return.
2675         * tui/tui-disasm.c (tui_show_disassem)
2676         (tui_show_disassem_and_update_source): Remove return.
2677         * tui/tui.c (tui_reset): Remove return.
2678         * tui/tui-wingeneral.c
2679         (tui_check_and_display_highlight_if_needed): Remove return.
2680
2681 2019-07-17  Tom Tromey  <tom@tromey.com>
2682
2683         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2684
2685 2019-07-17  Tom Tromey  <tom@tromey.com>
2686
2687         * tui/tui-winsource.h (struct tui_exec_info_window)
2688         (struct tui_source_window_base): Move from tui-data.h.
2689         * tui/tui-winsource.c: Move many method definitions from
2690         elsewhere.  Remove "structuring" comments.
2691         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2692         (tui_source_window_base::refresh_window): Move to
2693         tui-winsource.c.
2694         * tui/tui-win.c (tui_source_window_base::refresh_all)
2695         (tui_source_window_base::update_tab_width)
2696         (tui_source_window_base::set_new_height)
2697         (tui_source_window_base::do_make_visible_with_new_height): Move to
2698         tui-winsource.c.
2699         * tui/tui-source.h: Update.
2700         * tui/tui-source.c (tui_source_window_base::reset): Move to
2701         tui-winsource.c.
2702         * tui/tui-disasm.h: Update.
2703         * tui/tui-data.h (struct tui_exec_info_window): Move to
2704         tui-winsource.h.
2705         (struct tui_source_window_base): Likewise.
2706         * tui/tui-data.c (tui_source_window_base::clear_detail)
2707         (tui_source_window_base, ~tui_source_window_base): Move to
2708         tui-winsource.c.
2709
2710 2019-07-17  Tom Tromey  <tom@tromey.com>
2711
2712         * tui/tui-win.c (tui_resize_all)
2713         (tui_source_window_base::update_tab_width)
2714         (tui_adjust_win_heights): Update.
2715         (tui_win_info::make_invisible_and_set_new_height): Rename from
2716         make_invisible_and_set_new_height.
2717         * tui/tui-data.h (struct tui_win_info)
2718         <make_invisible_and_set_new_height>: New method.
2719
2720 2019-07-17  Tom Tromey  <tom@tromey.com>
2721
2722         * tui/tui.c: Update.
2723         * tui/tui-source.h (struct tui_source_window): Move from
2724         tui-data.h.
2725         * tui/tui-layout.c: Update.
2726         * tui/tui-disasm.c: Update.
2727         * tui/tui-data.h (struct tui_source_window): Move to
2728         tui-source.h.
2729
2730 2019-07-17  Tom Tromey  <tom@tromey.com>
2731
2732         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2733         tui-data.h.
2734         * tui/tui-data.h (struct tui_disasm_window): Move to
2735         tui-disasm.h.
2736
2737 2019-07-17  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-regs.h (struct tui_data_item_window): Move from
2740         tui-data.h.
2741         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2742         * tui/tui-data.h (struct tui_data_item_window): Move to
2743         tui-regs.h.
2744         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2745
2746 2019-07-17  Tom Tromey  <tom@tromey.com>
2747
2748         * tui/tui.c: Update.
2749         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2750         (tui_cmd_window::max_height): Move to tui-command.c.
2751         * tui/tui-layout.c: Update.
2752         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2753         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2754         tui-command.c.
2755         * tui/tui-command.h (struct tui_cmd_window): Move from
2756         tui-data.h.
2757         * tui/tui-command.c: Remove "structuring" comments.
2758         (tui_cmd_window::clear_detail)
2759         (tui_cmd_window::do_make_visible_with_new_height)
2760         (tui_cmd_window::max_height): Move from elsewhere.
2761
2762 2019-07-17  Tom Tromey  <tom@tromey.com>
2763
2764         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2765         Now static.
2766         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2767         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2768
2769 2019-07-17  Tom Tromey  <tom@tromey.com>
2770
2771         * tui/tui.c: Update.
2772         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2773         tui-regs.c.
2774         * tui/tui-windata.h: Remove file.
2775         * tui/tui-windata.c: Remove file.
2776         * tui/tui-win.c (tui_data_window::set_new_height)
2777         (tui_data_window::do_make_visible_with_new_height): Move to
2778         tui-regs.c.
2779         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2780         * tui/tui-regs.c: Remove "structuring" comments.
2781         (tui_data_window::first_data_item_displayed)
2782         (tui_data_window::delete_data_content_windows)
2783         (tui_data_window::erase_data_content)
2784         (tui_data_window::display_all_data)
2785         (tui_data_window::refresh_all)
2786         (tui_data_window::do_scroll_vertical)
2787         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2788         (tui_data_window::do_make_visible_with_new_height)
2789         (tui_data_window::refresh_window): Move from elsewhere.
2790         (_initialize_tui_regs): Move to end of file.
2791         * tui/tui-layout.c: Update.
2792         * tui/tui-hooks.c: Update.
2793         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2794         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2795         tui-regs.c.
2796         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2797
2798 2019-07-17  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2801         seen.
2802
2803 2019-07-17  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui-win.c (tui_source_window_base::set_new_height)
2806         (tui_source_window_base::do_make_visible_with_new_height): Use
2807         m_has_locator field directly.
2808         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2809         method.
2810         (struct tui_source_window_base) <has_locator>: Likewise.
2811
2812 2019-07-17  Tom Tromey  <tom@tromey.com>
2813
2814         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2815         Don't declare.
2816         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2817         Remove.
2818         * tui/tui-win.c (tui_source_window_base::set_new_height)
2819         (tui_source_window_base::set_new_height)
2820         (make_invisible_and_set_new_height)
2821         (tui_source_window_base::do_make_visible_with_new_height)
2822         (tui_source_window_base::do_make_visible_with_new_height):
2823         Update.
2824         * tui/tui-layout.c (show_source_disasm_command, show_data)
2825         (show_source_or_disasm_and_command): Update.
2826         * tui/tui-layout.c (show_layout): Update.
2827
2828 2019-07-17  Tom Tromey  <tom@tromey.com>
2829
2830         * tui/tui-layout.c (make_data_window): Remove.
2831         (show_data): Unify creation and re-initialization cases.
2832
2833 2019-07-17  Tom Tromey  <tom@tromey.com>
2834
2835         * tui/tui-layout.c (make_source_window, make_disasm_window):
2836         Remove.
2837         (show_data): Unify creation and re-initialization cases.
2838
2839 2019-07-17  Tom Tromey  <tom@tromey.com>
2840
2841         * tui/tui-layout.c (make_command_window): Remove.
2842         (show_source_disasm_command, show_source_or_disasm_and_command):
2843         Unify creation and re-initialization cases.
2844
2845 2019-07-17  Tom Tromey  <tom@tromey.com>
2846
2847         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2848         creation and re-initialization cases.
2849
2850 2019-07-17  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-regs.c (tui_get_register): Return void.
2853
2854 2019-07-17  Tom Tromey  <tom@tromey.com>
2855
2856         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2857         Simplify.
2858
2859 2019-07-17  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2862         resetting.
2863
2864 2019-07-17  Tom Tromey  <tom@tromey.com>
2865
2866         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2867         * tui/tui-regs.c (tui_reg_layout): New function.
2868         (tui_show_registers, tui_reg_command): Use it.
2869         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2870         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2871         parameters.
2872         (tui_layout_command): Remove.
2873
2874 2019-07-17  Tom Tromey  <tom@tromey.com>
2875
2876         * tui/tui-layout.h (tui/tui-layout): Return void.
2877         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2878
2879 2019-07-17  Tom Tromey  <tom@tromey.com>
2880
2881         * tui/tui-layout.c (show_source_disasm_command, show_data):
2882         Update.
2883         (reset_locator): Remove.
2884         (show_source_or_disasm_and_command): Update.
2885
2886 2019-07-17  Tom Tromey  <tom@tromey.com>
2887
2888         * tui/tui-source.c (tui_source_window_base::reset): Remove
2889         win_type parameter.
2890         * tui/tui-layout.c (make_command_window, make_source_window)
2891         (make_disasm_window, make_data_window)
2892         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2893         (reset_locator, show_source_or_disasm_and_command): Update.
2894         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2895         win_type parameter.
2896         (struct tui_source_window_base) <reset>: Likewise.
2897
2898 2019-07-17  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-layout.c (show_source_disasm_command): Use
2901         reset_locator.
2902         (reset_locator): New function.
2903         (init_and_make_win): Remove.
2904         (show_source_or_disasm_and_command): Use reset_locator.
2905
2906 2019-07-17  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2909         condition.
2910         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2911         Remove condition.
2912         * tui/tui-source.c (tui_source_window_base::reset): New method.
2913         * tui/tui-layout.c (make_command_window): Don't call
2914         init_and_make_win.
2915         (make_source_window, make_disasm_window): Don't call
2916         make_source_or_disasm_window.
2917         (make_data_window): Don't call init_and_make_win.  Change calling
2918         convention.
2919         (show_source_disasm_command, show_data): Simplify.
2920         (make_source_or_disasm_window): Remove.
2921         (show_source_or_disasm_and_command): Simplify.
2922         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2923         (struct tui_source_window_base) <reset>: Likewise.
2924         <execution_info>: Remove initializer.
2925         * tui/tui-data.c (tui_source_window_base): Initialize
2926         execution_info.
2927
2928 2019-07-17  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2931         variable.
2932
2933 2019-07-17  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui.c (tui_rl_other_window): Update.
2936         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2937         superclass method first.  Always iterate over regs_content.
2938         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2939         method.
2940         * tui/tui-win.c (tui_set_focus_command): Update.
2941
2942 2019-07-17  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-win.c (tui_set_focus_command): Rename from
2945         tui_set_focus.  Call tui_enable.
2946         (tui_set_focus_command): Remove.
2947
2948 2019-07-17  Tom Tromey  <tom@tromey.com>
2949
2950         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2951         refresh_window.
2952         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2953         touchwin.
2954         (tui_data_window::refresh_window): Call refresh_window on data
2955         items.  Always call superclass refresh_window.
2956         (tui_win_info::refresh): Remove.
2957         (tui_source_window_base::refresh_window): Update.
2958         (tui_refresh_all): Update.
2959         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2960         refresh_window.
2961         (show_source_or_disasm_and_command): Likewise.
2962         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2963         (struct tui_source_window_base) <refresh>: Likewise.
2964
2965 2019-07-17  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-winsource.c (tui_clear_source_content)
2968         (tui_show_source_content): Update.
2969         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2970         whether content is empty.
2971         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2972         Remove.
2973
2974 2019-07-17  Tom Tromey  <tom@tromey.com>
2975
2976         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2977         window's contents.
2978         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2979         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2980
2981 2019-07-17  Tom Tromey  <tom@tromey.com>
2982
2983         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2984         (struct tui_data_item_window): Update.
2985
2986 2019-07-17  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2989         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2990         defines.
2991
2992 2019-07-17  Tom Tromey  <tom@tromey.com>
2993
2994         * tui/tui-winsource.h (tui_erase_source_content)
2995         (tui_clear_source_content): Remove "display_prompt" parameter.
2996         * tui/tui-winsource.c (tui_update_source_window_as_is)
2997         (tui_update_source_windows_with_addr): Update.
2998         (tui_clear_source_content): Remove "display_prompt" parameter.
2999         (tui_erase_source_content): Likewise.  Simplify.
3000         (tui_show_source_content): Update.
3001         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3002         * tui/tui-stack.c (tui_show_frame_info): Update.
3003         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3004         Remove defines.
3005
3006 2019-07-17  Tom Tromey  <tom@tromey.com>
3007
3008         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3009         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3010         parameter.
3011         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3012         parameter.
3013
3014 2019-07-17  Tom Tromey  <tom@tromey.com>
3015
3016         * tui/tui-winsource.c (tui_clear_source_content)
3017         (tui_show_source_content, tui_show_exec_info_content)
3018         (tui_clear_exec_info_content): Update.
3019         * tui/tui-stack.c (tui_show_locator_content): Update.
3020         (tui_show_frame_info): Update.
3021         * tui/tui-source.h (tui_source_window): Don't declare.
3022         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3023         from tui_source_is_displayed.
3024         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3025         Remove field.
3026         (struct tui_source_window_base) <content_in_use>: New field.  Now
3027         bool.
3028         (struct tui_source_window) <showing_source_p>: New method.
3029         (TUI_SRC_WIN): Change cast.
3030         * tui/tui-data.c (tui_initialize_static_data): Update.
3031
3032 2019-07-17  Tom Tromey  <tom@tromey.com>
3033
3034         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3035         location_matches_p.
3036         * tui/tui-source.c (tui_source_window::location_matches_p): New
3037         method.
3038         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3039         method.
3040         * tui/tui-data.h (struct tui_source_window_base)
3041         <location_matches_p>: New method.
3042         (struct tui_source_window, struct tui_disasm_window)
3043         <location_matches_p>: Likewise.
3044
3045 2019-07-17  Tom Tromey  <tom@tromey.com>
3046
3047         * tui/tui-win.c (tui_set_win_height_command): Rename from
3048         tui_set_win_height.
3049         (tui_set_win_height_command): Remove.
3050
3051 2019-07-17  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-source.c (tui_source_window): New constructor.  Add
3054         observer.
3055         (~tui_source_window): New destructor.
3056         (tui_source_window::style_changed): New method.
3057         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3058         (tui_attach_detach_observers): Update.
3059         * tui/tui-data.h (struct tui_source_window): Make constructor not
3060         inline.  Add destructor.
3061         (struct tui_source_window) <style_changed>: New method.
3062         <m_observable>: New member.
3063
3064 2019-07-17  Tom Tromey  <tom@tromey.com>
3065
3066         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3067         * tui/tui-win.c (tui_resize_all): Fix typo.
3068
3069 2019-07-17  Tom Tromey  <tom@tromey.com>
3070
3071         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3072         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3073         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3074         * tui/tui-win.c (window_name_completer): Use foreach.
3075         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3076         (update_tab_width): Likewise.
3077         * tui/tui-layout.c (show_layout): Update.
3078         * tui/tui-data.h (class tui_window_iterator): New.
3079         (struct all_tui_windows): New.
3080         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3081
3082 2019-07-17  Tom Tromey  <tom@tromey.com>
3083
3084         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3085         parameter.  Don't reference globals.
3086         (tui_reg_command): Update.
3087
3088 2019-07-17  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-regs.c (tui_show_registers): Simplify.
3091
3092 2019-07-17  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-regs.c (tui_show_registers): Update.
3095         (tui_show_register_group): Add win_info parameter.
3096
3097 2019-07-17  Tom Tromey  <tom@tromey.com>
3098
3099         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3100         Rename from tui_display_reg_element_at_line.
3101         (tui_data_window::display_registers_from_line): Update.
3102         * tui/tui-data.h (struct tui_data_window)
3103         <display_reg_element_at_line>: New method.
3104
3105 2019-07-17  Tom Tromey  <tom@tromey.com>
3106
3107         * tui/tui-regs.h (tui_display_registers_from)
3108         (tui_display_registers_from_line): Don't declare.
3109         * tui/tui-windata.c (tui_data_window::display_all_data)
3110         (tui_data_window::refresh_all)
3111         (tui_data_window::do_scroll_vertical): Update.
3112         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3113         from tui_display_registers_from.
3114         (tui_display_reg_element_at_line): Update.
3115         (tui_data_window::display_registers_from_line): Rename from
3116         tui_display_registers_from_line.
3117         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3118         display_registers_from_line>: New methods.
3119
3120 2019-07-17  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3123         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3124         from tui_erase_data_content.
3125         (tui_data_window::display_all_data)
3126         (tui_data_window::refresh_all)
3127         (tui_data_window::do_scroll_vertical): Update.
3128         * tui/tui-regs.c (tui_show_registers): Update.
3129         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3130         New method.
3131
3132 2019-07-17  Tom Tromey  <tom@tromey.com>
3133
3134         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3135         declare.
3136         * tui/tui-windata.c
3137         (tui_data_window::delete_data_content_windows): Rename from
3138         tui_delete_data_content_windows.
3139         (tui_data_window::display_all_data)
3140         (tui_data_window::do_scroll_vertical): Update.
3141         * tui/tui-data.h (struct tui_data_window)
3142         <delete_data_content_windows>: New method.
3143
3144 2019-07-17  Tom Tromey  <tom@tromey.com>
3145
3146         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3147         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3148
3149 2019-07-17  Tom Tromey  <tom@tromey.com>
3150
3151         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3152         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3153         from tui_display_all_data.
3154         * tui/tui-win.c
3155         (tui_data_window::do_make_visible_with_new_height): Update.
3156         * tui/tui-regs.c (tui_show_registers): Update.
3157         * tui/tui-layout.c (tui_set_layout): Update.
3158         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3159         method.
3160
3161 2019-07-17  Tom Tromey  <tom@tromey.com>
3162
3163         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3164         * tui/tui-windata.c (tui_display_data_from): Remove.
3165         (tui_data_window::refresh_all): Update.
3166
3167 2019-07-17  Tom Tromey  <tom@tromey.com>
3168
3169         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3170         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3171         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3172         tui_display_registers_from_line.
3173         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3174         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3175         "force_display" parameter.
3176
3177 2019-07-17  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3180         declare.
3181         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3182         Rename from tui_first_reg_element_no_inline.
3183         (tui_display_reg_element_at_line)
3184         (tui_display_registers_from_line): Update.
3185         * tui/tui-data.h (struct tui_data_window)
3186         <first_reg_element_no_inline>: New method.
3187
3188 2019-07-17  Tom Tromey  <tom@tromey.com>
3189
3190         * tui/tui-windata.c (tui_display_data_from)
3191         (tui_data_window::do_scroll_vertical): Update.
3192         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3193         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3194         Rename from tui_line_from_reg_element_no.
3195         (tui_display_registers_from_line): Update.
3196         * tui/tui-data.h (struct tui_data_window)
3197         <line_from_reg_element_no>: New method.
3198
3199 2019-07-17  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3202         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3203         tui_last_regs_line_no.
3204         (tui_display_reg_element_at_line)
3205         (tui_display_registers_from_line): Update.
3206         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3207         method.
3208
3209 2019-07-17  Tom Tromey  <tom@tromey.com>
3210
3211         PR tui/24722:
3212         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3213         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3214         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3215         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3216         (tui_update_breakpoint_info): Likewise.
3217         * tui/tui-hooks.c (tui_event_create_breakpoint)
3218         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3219         Update.
3220
3221 2019-07-17  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3224
3225 2019-07-17  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-winsource.c (tui_update_source_window_as_is)
3228         (tui_update_source_windows_with_addr): Update.
3229         * tui/tui-source.h (tui_set_source_content)
3230         (tui_show_symtab_source): Add "win_info" parameter.
3231         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3232         parameter.
3233         (tui_show_symtab_source): Likewise.
3234
3235 2019-07-17  Tom Tromey  <tom@tromey.com>
3236
3237         * tui/tui-wingeneral.c
3238         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3239
3240 2019-07-17  Tom Tromey  <tom@tromey.com>
3241
3242         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3243         (struct tui_cmd_window) <can_scroll>: New method.
3244         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3245         method.
3246
3247 2019-07-17  Tom Tromey  <tromey@adacore.com>
3248
3249         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3250         do_field_signed>: Rename.  Change type of "value".
3251         * ui-out.c (ui_out::field_signed): Rename from field_int.
3252         Change type of "value".
3253         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3254         type of "value".
3255         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3256         do_field_int.  Change type of "value".
3257         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3258         do_field_int.  Change type of "value".
3259         * tracepoint.c (trace_status_mi, tfind_1)
3260         (print_one_static_tracepoint_marker): Update.
3261         * thread.c (print_thread_info_1, print_selected_thread_frame):
3262         Update.
3263         * stack.c (print_frame, print_frame_info): Update.
3264         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3265         Update.
3266         * source.c (print_source_lines_base): Update.
3267         * skip.c (info_skip_command): Update.
3268         * record-btrace.c (btrace_ui_out_decode_error)
3269         (btrace_call_history_src_line): Update.
3270         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3271         Update.
3272         * progspace.c (print_program_space): Update.
3273         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3274         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3275         do_field_int.  Change type of "value".
3276         * mi/mi-out.c (mi_ui_out::do_table_begin)
3277         (mi_ui_out::do_table_header): Update.
3278         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3279         type of "value".
3280         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3281         (mi_cmd_data_list_changed_registers, output_register)
3282         (mi_cmd_data_read_memory, mi_load_progress)
3283         (mi_cmd_trace_frame_collected): Update.
3284         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3285         Update.
3286         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3287         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3288         (mi_cmd_var_list_children, varobj_update_one): Update.
3289         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3290         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3291         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3292         * inferior.c (print_inferior): Update.
3293         * gdb_bfd.c (print_one_bfd): Update.
3294         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3295         Update.
3296         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3297         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3298         do_field_int.  Change type of "value".
3299         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3300         do_field_int.  Change type of "value".
3301         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3302         (print_one_breakpoint_location, print_it_catch_fork)
3303         (print_one_catch_fork, print_it_catch_vfork)
3304         (print_one_catch_vfork, print_it_catch_solib)
3305         (print_it_catch_exec, print_it_ranged_breakpoint)
3306         (print_mention_watchpoint, print_mention_masked_watchpoint)
3307         (bkpt_print_it, update_static_tracepoint): Update.
3308         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3309         * break-catch-syscall.c (print_it_catch_syscall): Update.
3310         * ada-tasks.c (print_ada_task_info): Update.
3311         * ada-lang.c (print_it_exception, print_mention_exception):
3312         Update.
3313
3314 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3315
3316         PR breakpoints/24541
3317         * gdbarch.c: Regenerate.
3318         * gdbarch.h: Regenerate.
3319         * gdbarch.sh: Adjust return type and parameter types for
3320         'stap_adjust_register'.
3321         (i386_stap_adjust_register): Adjust signature and return new
3322         register name.
3323         * stap-probe.c (stap_parse_register_operand): Adjust use of
3324         'gdbarch_stap_adjust_register'.
3325
3326 2019-07-17  Tom Tromey  <tromey@adacore.com>
3327
3328         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3329         declare VEC.
3330         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3331         std::vector.
3332         (struct s390_process_info): Add initializers.
3333         (s390_add_process): Use new.
3334         (s390_linux_nat_target::low_forget_process): Use delete.
3335         (s390_linux_nat_target::low_new_fork)
3336         (s390_linux_nat_target::stopped_by_watchpoint)
3337         (s390_linux_nat_target::low_prepare_to_resume)
3338         (s390_linux_nat_target::insert_watchpoint)
3339         (s390_linux_nat_target::insert_hw_breakpoint)
3340         (s390_linux_nat_target::remove_watchpoint)
3341         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3342
3343 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3344
3345         * aarch64-fbsd-nat.c: Include regcache.h.
3346         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3347         argument.
3348         (aarch64_fbsd_nat_target::fetch_registers)
3349         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3350         variable.
3351         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3352
3353 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3354
3355         * fbsd-nat.c: Include gdbarch.h.
3356
3357 2019-07-15  Tom Tromey  <tromey@adacore.com>
3358
3359         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3360
3361 2019-07-15  Tom Tromey  <tromey@adacore.com>
3362
3363         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3364         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3365         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3366         * cli-out.c (cli_ui_out::do_field_int): New method.
3367         * ui-out.c (ui_out::field_unsigned): New method.
3368         * symfile.c (generic_load): Use field_unsigned.
3369         (print_transfer_performance): Likewise.
3370         * record-btrace.c (ui_out_field_uint): Remove.
3371         (btrace_call_history_insn_range, btrace_call_history): Use
3372         field_unsigned.
3373         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3374         field_unsigned.
3375         * ui-out.h (class ui_out) <field_unsigned>: New method.
3376         <do_field_unsigned>: Likewise.
3377
3378 2019-07-15  Tom Tromey  <tromey@adacore.com>
3379
3380         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3381         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3382         * target.c (flash_erase_command): Use field_string.
3383         * infrun.c (print_signal_received_reason): Use field_string.
3384         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3385         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3386         field_string.
3387         * ada-tasks.c (print_ada_task_info): Use field_string.
3388
3389 2019-07-15  Tom Tromey  <tromey@adacore.com>
3390
3391         * target.c (flash_erase_command): Use field_core_addr.
3392         * symfile.c (generic_load): Use field_core_addr.
3393         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3394         Use field_core_addr.
3395         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3396         field_core_addr.
3397
3398 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3399
3400         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3401         value if its desired type is smaller than a CORE_ADDR and signed.
3402
3403 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3404
3405         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3406         of changes to field names, and use new is_reference field to
3407         decide if a property is a reference or not.
3408         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3409         field.
3410         (struct dwarf2_property_baton): Update header comment, rename
3411         'referenced_type' to 'property_type' and update comments.
3412         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3413         default property type, store in property baton, update to take
3414         accound of renamed field.
3415         (read_func_scope): Update call to attr_to_dynamic_prop.
3416         (read_array_type): Likewise.
3417         (dwarf2_per_cu_addr_sized_int_type): New function.
3418         (read_subrange_index_type): Move type finding code to
3419         dwarf2_per_cu_addr_sized_int_type.
3420         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3421         (dwarf2_per_cu_addr_type): New function.
3422         (set_die_type): Update calls to attr_to_dynamic_prop.
3423
3424 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3425
3426         * dwarf2read.c (read_subrange_index_type): New function.
3427         (read_subrange_type): Move code into new function and call it.
3428         * gdbtypes.c (create_range_type): Add some asserts.
3429
3430 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3431
3432         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3433         update return statements.
3434         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3435         declaration, and update comment to match.
3436         * gdbtypes.c (resolve_dynamic_array): Update call to
3437         dwarf2_evaluate_property to match new return type.
3438
3439 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3440
3441         * valarith.c (value_subscripted_rvalue): Change lowerbound
3442         parameter type from int to LONGEST.
3443         * value.h (value_subscripted_rvalue): Likewise in declaration.
3444
3445 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3446
3447         * cli/cli-utils.c (info_print_command_completer): New function.
3448         * cli/cli-utils.h: Add 'completer.h' include, and forward
3449         declaration for 'struct cmd_list_element'.
3450         (info_print_command_completer): Declare.
3451         * stack.c (_initialize_stack): Add completer for 'info locals' and
3452         'info args'.
3453         * symtab.c (_initialize_symtab): Add completer for 'info
3454         variables' and 'info functions'.
3455         * NEWS: Mention completion for additional info commands.
3456
3457 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3458
3459         * cli/cli-utils.c (extract_info_print_args): Delete.
3460         (extract_arg_maybe_quoted): Delete.
3461         (info_print_options_defs): New variable.
3462         (make_info_print_options_def_group): New function.
3463         (extract_info_print_options): Define new function.
3464         * cli/cli-utils.h (extract_info_print_args): Delete.
3465         (struct info_print_options): New structure.
3466         (extract_info_print_options): Declare new function.
3467         * stack.c (info_locals_command): Update to use new
3468         extract_info_print_options, also add a header comment.
3469         (info_args_command): Likewise.
3470         * symtab.c (info_variables_command): Likewise.
3471         (info_functions_command): Likewise.
3472
3473 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3474
3475         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3476         to extract string arguments.
3477         * common/common-utils.c (extract_string_maybe_quoted): New function.
3478         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3479
3480 2019-07-11  Tom Tromey  <tromey@adacore.com>
3481
3482         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3483         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3484         * top.h (gdbinit): Don't declare.
3485         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3486         into...
3487         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3488         * top.c (gdb_init): Don't call init_cli_cmds.
3489         (gdbinit): Remove.
3490         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3491
3492 2019-07-11  Tom Tromey  <tromey@adacore.com>
3493
3494         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3495         after it has been moved.
3496
3497 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3498
3499         * valops.c (value_must_coerce_to_target): Change return type to
3500         bool.
3501         * value.h (value_must_coerce_to_target): Likewise.
3502
3503 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3504
3505         * breakpoint.c (is_hardware_watchpoint): Remove
3506         forward-declaration.
3507         (is_masked_watchpoint): Change return type to bool.
3508         (is_tracepoint): Likewise.
3509         (is_breakpoint): Likewise.
3510         (is_hardware_watchpoint): Likewise.
3511         (is_watchpoint): Likewise.
3512         (is_no_memory_software_watchpoint): Likewise.
3513         (is_catchpoint): Likewise.
3514         (breakpoint_1): Make FILTER parameter's return type bool.
3515         is_masked_watchpoint): Change return type to bool.
3516         (save_breakpoints): Make FILTER parameter's return type bool.
3517         * breakpoint.h (is_breakpoint): Change return type to bool.
3518         (is_watchpoint): Likewise.
3519         (is_catchpoint): Likewise.
3520         (is_tracepoint): Likewise.
3521
3522 2019-07-10  Tom Tromey  <tom@tromey.com>
3523
3524         * defs.h: Don't include gdbarch.h.
3525         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3526         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3527         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3528         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3529         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3530         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3531         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3532         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3533         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3534         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3535         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3536         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3537         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3538         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3539         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3540         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3541         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3542         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3543         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3544         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3545         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3546         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3547         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3548         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3549         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3550         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3551         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3552
3553 2019-07-10  Tom Tromey  <tromey@adacore.com>
3554
3555         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3556         * breakpoint.c (init_ada_exception_breakpoint): Register as
3557         bp_catchpoint.
3558         (print_one_breakpoint_location, print_one_breakpoint): Use
3559         is_ada_exception_catchpoint.
3560         * ada-lang.c (class ada_catchpoint_location): Pass
3561         bp_loc_software_breakpoint to bp_location constructor.
3562         (is_ada_exception_catchpoint): New function.
3563
3564 2019-07-10  Tom Tromey  <tromey@adacore.com>
3565
3566         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3567         VEC.
3568         (struct arm_exidx_entry): New method operator<.
3569         (struct arm_exidx_data) <section_maps>: Change type.
3570         (arm_exidx_data_free): Remove.
3571         (arm_exidx_data_key): Change type.  Move lower.
3572         (arm_exidx_new_objfile): Update.
3573         (arm_compare_exidx_entries): Remove.
3574         (arm_find_exidx_entry, _initialize_arm_tdep)
3575
3576 2019-07-10  Tom Tromey  <tromey@adacore.com>
3577
3578         * solib-spu.c (ocl_program_data_key): Change type.
3579         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3580         Update.
3581
3582 2019-07-10  Tom Tromey  <tromey@adacore.com>
3583
3584         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3585         (struct solib_aix_inferior_data) <library_list>: Change type.
3586         (solib_aix_inferior_data_handle): Change type.
3587         (get_solib_aix_inferior_data): Update.
3588         (solib_aix_free_library_list): Remove.
3589         (library_list_start_library): Update.
3590         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3591         return type.
3592         (solib_aix_get_library_list)
3593         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3594         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3595
3596 2019-07-10  Tom Tromey  <tromey@adacore.com>
3597
3598         * solib-dsbt.c (struct dsbt_info): Add initializers.
3599         (solib_dsbt_pspace_data): Change type.
3600         (dsbt_pspace_data_cleanup): Remove.
3601         (get_dsbt_info, _initialize_dsbt_solib): Update.
3602
3603 2019-07-10  Tom Tromey  <tromey@adacore.com>
3604
3605         * spu-tdep.c (spu_overlay_data): Change type.
3606         (spu_get_overlay_table, spu_overlay_new_objfile)
3607         (_initialize_spu_tdep): Update.
3608
3609 2019-07-10  Tom Tromey  <tromey@adacore.com>
3610
3611         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3612         destructor.
3613         (dbx_objfile_data_key): Change type and declare later.
3614         (DBX_SYMFILE_INFO): Rewrite.
3615         * dbxread.c (dbx_objfile_data_key): Change type.
3616         (dbx_symfile_init): Update.
3617         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3618         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3619         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3620
3621 2019-07-10  Tom Tromey  <tromey@adacore.com>
3622
3623         * jit.c (jit_program_space_key): Change type.  Move lower.
3624         (get_jit_program_space_data): Update.
3625         (jit_program_space_data_cleanup): Remove.
3626         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3627         Update.
3628         (struct jit_program_space_data): Add initializers.
3629
3630 2019-07-10  Tom Tromey  <tromey@adacore.com>
3631
3632         * solib-darwin.c (struct darwin_info): Add initializers.
3633         (solib_darwin_pspace_data): Change type.
3634         (darwin_pspace_data_cleanup): Remove.
3635         (get_darwin_info, _initialize_darwin_solib): Update.
3636
3637 2019-07-10  Tom Tromey  <tromey@adacore.com>
3638
3639         * remote-sim.c (struct sim_inferior_data): Add initializers,
3640         constructor, and destructor.
3641         (sim_inferior_data_key): Change type.  Move lower.
3642         (check_for_duplicate_sim_descriptor): Update.
3643         (get_sim_inferior_data): Use new.  Update.
3644         (~sim_inferior_data_cleanup): Rename from
3645         sim_inferior_data_cleanup.  Simplify.
3646         (gdbsim_close_inferior, simulator_command)
3647         (sim_command_completer, _initialize_remote_sim): Update.
3648         (next_pid, INITIAL_PID): Move earlier.
3649
3650 2019-07-10  Tom Tromey  <tromey@adacore.com>
3651
3652         * python/python-internal.h (create_thread_object): Return
3653         gdbpy_ref.
3654         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3655         * python/py-inferior.c (struct threadlist_entry): Add
3656         constructor.
3657         <thread_obj>: Now a gdbpy_ref.
3658         (thread_to_thread_object): Update.
3659         (add_thread_object): Use new.
3660         (delete_thread_object): Use delete.
3661         (infpy_threads): Update.
3662         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3663         GIL.
3664
3665 2019-07-10  Tom Tromey  <tromey@adacore.com>
3666
3667         * valops.c (value_cast): Specialize error message for Ada.
3668
3669 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3670
3671         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3672
3673 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3674
3675         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3676         bpstat_should_step): Return bool, adjust comments.
3677         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3678         bpstat_should_step): Likewise.
3679
3680 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3681
3682         * features/Makefile: Use feature target descriptions for Arm.
3683         * features/arm/arm-core.c: Generate new file.
3684         * features/arm/arm-fpa.c: Likewise.
3685         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3686         * features/arm/arm-m-profile.c: Likewise.
3687         * features/arm/arm-vfpv2.c: Likewise.
3688         * features/arm/arm-vfpv3.c: Likewise.
3689         * features/arm/xscale-iwmmxt.c: Likewise.
3690         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3691
3692 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3693
3694         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3695         ptrace earlier.
3696
3697 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3698
3699         * features/aarch64-pauth.c: Regenerate.
3700
3701 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3702
3703         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3704         bool.
3705         (bpstat_what): Use false instead of 0.
3706
3707 2019-07-09  Pedro Alves  <palves@redhat.com>
3708
3709         * break-catch-throw.c (is_exception_catchpoint): New.
3710         * breakpoint.c (print_one_breakpoint_location): New parameter
3711         'raw_loc'.  Handle it.  Use
3712         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3713         looking at the breakpoint's type.
3714         (print_one_breakpoint): If handling "maint info breakpoints", also
3715         print locations of exception catchpoints.
3716         * breakpoint.h (is_exception_catchpoint): Declare.
3717
3718 2019-07-09  Pedro Alves  <palves@redhat.com>
3719
3720         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3721         "addr" field.
3722         (allocate_location_exception_catchpoint): New.
3723         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3724         (initialize_throw_catchpoint_ops): Install
3725         allocate_location_exception_catchpoint as allocate_location
3726         method.
3727         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3728         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3729         bp_loc_other.
3730         (breakpoint_address_is_meaningful): Delete.
3731         (bl_address_is_meaningful): New.
3732         (breakpoint_locations_match): Adjust comment.
3733         (bp_location_from_bp_type): New, factored out of...
3734         (bp_location::bp_location(breakpoint *)): ... this.
3735         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3736         factored out of...
3737         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3738         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3739         breakpoint_address_is_meaningful.
3740         (bp_locations_compare): Adjust comment.
3741         (update_global_location_list): Use bl_address_is_meaningful
3742         instead of breakpoint_address_is_meaningful.
3743         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3744         explicit.
3745         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3746         * python/py-breakpoint.c (bppy_get_location): No longer check
3747         whether location is null.
3748
3749 2019-07-09  Pedro Alves  <palves@redhat.com>
3750
3751         PR c++/15468
3752         * breakpoint.c (print_one_breakpoint_location): Remove
3753         single-location assert.
3754
3755 2019-07-09  Tom Tromey  <tom@tromey.com>
3756
3757         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3758         * configure: Rebuild.
3759         * configure.ac: Change common to gdbsupport.
3760         * gdbsupport: Rename from common.
3761         * acinclude.m4: Change common to gdbsupport.
3762         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3763         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3764         gdbsupport.
3765         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3766         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3767         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3768         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3769         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3770         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3771         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3772         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3773         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3774         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3775         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3776         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3777         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3778         coff-pe-read.c, command.h, compile/compile-c-support.c,
3779         compile/compile-c.h, compile/compile-cplus-symbols.c,
3780         compile/compile-cplus-types.c, compile/compile-cplus.h,
3781         compile/compile-loc2c.c, compile/compile.c, completer.c,
3782         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3783         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3784         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3785         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3786         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3787         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3788         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3789         features/aarch64-core.c, features/aarch64-fpu.c,
3790         features/aarch64-pauth.c, features/aarch64-sve.c,
3791         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3792         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3793         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3794         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3795         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3796         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3797         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3798         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3799         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3800         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3801         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3802         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3803         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3804         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3805         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3806         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3807         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3808         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3809         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3810         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3811         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3812         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3813         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3814         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3815         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3816         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3817         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3818         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3819         minsyms.c, mips-linux-tdep.c, namespace.h,
3820         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3821         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3822         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3823         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3824         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3825         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3826         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3827         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3828         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3829         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3830         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3831         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3832         procfs.c, producer.c, progspace.h, psymtab.h,
3833         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3834         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3835         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3836         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3837         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3838         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3839         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3840         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3841         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3842         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3843         target-memory.c, target.c, target.h, target/waitstatus.c,
3844         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3845         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3846         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3847         unittests/array-view-selftests.c,
3848         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3849         unittests/common-utils-selftests.c,
3850         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3851         unittests/format_pieces-selftests.c,
3852         unittests/function-view-selftests.c,
3853         unittests/lookup_name_info-selftests.c,
3854         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3855         unittests/mkdir-recursive-selftests.c,
3856         unittests/observable-selftests.c,
3857         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3858         unittests/parse-connection-spec-selftests.c,
3859         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3860         unittests/scoped_fd-selftests.c,
3861         unittests/scoped_mmap-selftests.c,
3862         unittests/scoped_restore-selftests.c,
3863         unittests/string_view-selftests.c, unittests/style-selftests.c,
3864         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3865         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3866         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3867         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3868         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3869         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3870
3871 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3872
3873         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3874         bool value.
3875         (decode_digits_ordinary): Set explicit_line field in sal.
3876         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3877         symtab_and_line that was set on an explicit line number in
3878         assembler code.  Do always update the recorded symtab and line if
3879         we do skip the prologue.
3880
3881 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3882
3883         * breakpoint.c (set_breakpoint_location_function): Remove
3884         explicit_loc parameter.
3885         (momentary_breakpoint_from_master): Update call to
3886         set_breakpoint_location_function.
3887         (add_location_to_breakpoint): Likewise.
3888
3889 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3890
3891         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3892         required features based on default bfd type when no specific bfd
3893         is present.
3894
3895 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3896
3897         * NEWS: Mention that GDB printf and eval commands can now print
3898         C-style and Ada-style convenience var strings without
3899         calling the inferior.
3900         * printcmd.c (printf_c_string): Locally print GDB internal var
3901         instead of transiting via the inferior.
3902         (printf_wide_c_string): Likewise.
3903
3904 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3905
3906         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3907
3908 2019-07-04  Tom Tromey  <tom@tromey.com>
3909
3910         PR tui/24724:
3911         * tui/tui-winsource.c (tui_clear_source_content): Update.
3912         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3913         (tui_update_breakpoint_info): Update.
3914         (tui_set_exec_info_content): Update.
3915         * tui/tui-source.c (tui_set_source_content_nil): Update.
3916         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3917         has_break.
3918         * tui/tui-data.h (enum tui_bp_flag): New.
3919         (tui_bp_flags): New enum flags type.
3920         (struct tui_source_element) <break_mode>: Change type.  Rename
3921         from has_break.
3922         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3923         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3924         constants.
3925         * tui/tui-winsource.h: Fix comment.
3926
3927 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3928
3929         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3930         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3931         (store_fpregs_to_thread)
3932         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3933         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3934         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3935         (IWMMXT_REGS_SIZE): Add define.
3936         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3937         (fetch_vfp_regs, store_vfp_regs)
3938         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3939         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3940
3941 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3942
3943         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3944         defines.
3945         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3946         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3947         (ARM_INT_REGISTER_SIZE): ...to this.
3948         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3949         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3950         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3951         (arm_linux_collect_gregset, supply_nwfpe_register)
3952         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3953         defines.
3954         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3955         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3956         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3957         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3958         (arm_return_in_memory, arm_store_return_value)
3959         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3960         (arm_record_ld_st_multiple): Likewise.
3961         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3962         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3963
3964 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3965
3966         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3967         AARCH64_DISPLACED_MODIFIED_INSNS.
3968         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3969         (aarch64_displaced_step_copy_insn): Likewise.
3970         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3971         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3972         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3973         ARM_DISPLACED_MODIFIED_INSNS.
3974         * arm-tdep.c (arm_gdbarch_init): Likewise.
3975         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3976         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3977         (struct arm_displaced_step_closure): Use
3978         ARM_DISPLACED_MODIFIED_INSNS.
3979
3980 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3981
3982         * features/Makefile: Remove unused xml files.
3983         * features/aarch64.xml: Remove.
3984         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3985         * features/i386/amd64-avx-avx512.xml: Remove.
3986         * features/i386/amd64-avx-linux.xml: Remove.
3987         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3988         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3989         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3990         * features/i386/amd64-avx-mpx.xml: Remove.
3991         * features/i386/amd64-avx.xml: Remove.
3992         * features/i386/amd64-linux.xml: Remove.
3993         * features/i386/amd64-mpx-linux.xml: Remove.
3994         * features/i386/amd64-mpx.xml: Remove.
3995         * features/i386/amd64.xml: Remove.
3996         * features/i386/i386-avx-avx512-linux.xml: Remove.
3997         * features/i386/i386-avx-avx512.xml: Remove.
3998         * features/i386/i386-avx-linux.xml: Remove.
3999         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4000         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4001         * features/i386/i386-avx-mpx-linux.xml: Remove.
4002         * features/i386/i386-avx-mpx.xml: Remove.
4003         * features/i386/i386-avx.xml: Remove.
4004         * features/i386/i386-linux.xml: Remove.
4005         * features/i386/i386-mmx-linux.xml: Remove.
4006         * features/i386/i386-mmx.xml: Remove.
4007         * features/i386/i386-mpx-linux.xml: Remove.
4008         * features/i386/i386-mpx.xml: Remove.
4009         * features/i386/i386.xml: Remove.
4010         * features/i386/x32-avx-avx512-linux.xml: Remove.
4011         * features/i386/x32-avx-linux.xml: Remove.
4012         * features/i386/x32-linux.xml: Remove.
4013
4014 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4015
4016         * regformats/aarch64.dat: Remove.
4017         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4018         * regformats/i386/amd64-avx-linux.dat: Remove.
4019         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4020         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4021         * regformats/i386/amd64-linux.dat: Remove.
4022         * regformats/i386/amd64-mpx-linux.dat: Remove.
4023         * regformats/i386/amd64.dat: Remove.
4024         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4025         * regformats/i386/i386-avx-linux.dat: Remove.
4026         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4027         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4028         * regformats/i386/i386-linux.dat: Remove.
4029         * regformats/i386/i386-mmx-linux.dat: Remove.
4030         * regformats/i386/i386-mpx-linux.dat: Remove.
4031         * regformats/i386/i386.dat: Remove.
4032         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4033         * regformats/i386/x32-avx-linux.dat: Remove.
4034         * regformats/i386/x32-linux.dat: Remove.
4035
4036 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4037
4038         * aarch64-tdep.c: Remove xml self tests.
4039         * amd64-linux-tdep.c: Likewise.
4040         * amd64-tdep.c: Likewise.
4041         * i386-linux-tdep.c: Likewise.
4042         * i386-tdep.c: Likewise.
4043
4044 2019-07-03  Pedro Alves  <palves@redhat.com>
4045
4046         PR cli/24732
4047         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4048         (pipe_cmd_option_defs): New.
4049         (make_pipe_cmd_options_def_group): New.
4050         (pipe_command): Use gdb::option::process_options.
4051         (pipe_command_completer): New function.
4052         (_initialize_cli_cmds): Install completer for "pipe" command.
4053
4054 2019-07-03  Pedro Alves  <palves@redhat.com>
4055
4056         * cli/cli-option.c (union option_value) <string>: New field.
4057         (struct option_def_and_value): Add ctor, move ctor, dtor and
4058         use DISABLE_COPY_AND_ASSIGN.
4059         (option_def_and_value::clear_value): New.
4060         (parse_option, save_option_value_in_ctx, get_val_type_str)
4061         (add_setshow_cmds_for_options): Handle var_string.
4062         * cli-option.h (union option_def::var_address) <string>: New
4063         field.
4064         (struct string_option_def): New.
4065         * maint-test-options.c (struct test_options_opts): Add default
4066         ctor and use DISABLE_COPY_AND_ASSIGN.
4067         <string_opt>: New field.
4068         (test_options_opts::~test_options_opts): New.
4069         (test_options_opts::dump): Also dump "-string".
4070         (test_options_option_defs): Install "string.
4071
4072 2019-07-03  Pedro Alves  <palves@redhat.com>
4073
4074         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4075         option_value with a null enumeration.
4076         (complete_options): Save the option values in the context.
4077         (save_option_value_in_ctx): New, factored out from ...
4078         (process_options): ... here.
4079         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4080         of the function.
4081         * maint-test-options.c (test_options_opts::dump): New, factored
4082         out from ...
4083         (maintenance_test_options_command_mode): ... here.
4084         (maintenance_test_options_command_completion_result): Delete.
4085         (maintenance_test_options_command_completion_text): Update
4086         comment.
4087         (maintenance_show_test_options_completion_result): Change
4088         prototype.  Just print
4089         maintenance_test_options_command_completion_text.
4090         (save_completion_result): New.
4091         (maintenance_test_options_completer_mode): Pass options context to
4092         complete_options, and then save a dump.
4093         (_initialize_maint_test_options): Use add_cmd to install "maint
4094         show test-options-completion-result".
4095
4096 2019-07-03  Pedro Alves  <palves@redhat.com>
4097
4098         * NEWS (New commands): Mention "with" and "maint with".
4099         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4100         (with_command, with_command_completer): New.
4101         (pipe_command): Adjust to new repeat_previous
4102         interface.
4103         (_initialize_cli_cmds): Install the "with" command and its "w"
4104         alias.
4105         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4106         declarations.
4107         * cli/cli-setshow.c (parse_cli_var_uinteger)
4108         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4109         argument strings for all var_types.
4110         (get_setshow_command_value_string): New, factored out from ...
4111         (do_show_command): ... this.
4112         * cli/cli-setshow.h: Include <string>.
4113         (get_setshow_command_value_string): Declare.
4114         * command.h (repeat_previous): Now returns const char *.  Adjust
4115         comment.
4116         * maint.c: Include "cli/cli-cmds.h".
4117         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4118         (_initialize_maint_cmds): Register the "maintenance with" command.
4119         * top.c (repeat_previous): Move bits from pipe_command here:
4120         Return the saved command line, if any; error out if there's no
4121         command to relaunch.
4122
4123 2019-07-03  Pedro Alves  <palves@redhat.com>
4124
4125         * NEWS (New commands): Mention "maint set/show test-settings"
4126         instead of "maint test-settings".
4127         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4128         (maintenance_test_settings_set_list): Rename to ...
4129         (maintenance_set_test_settings_list): ... this.
4130         (maintenance_test_settings_show_list): Rename to  ...
4131         (maintenance_show_test_settings_list): ... this.
4132         (maintenance_test_settings_cmd): Delete.
4133         (maintenance_test_settings_set_cmd): ...
4134         (maintenance_set_test_settings_cmd): ... this.
4135         (maintenance_test_settings_show_cmd): ...
4136         (maintenance_show_test_settings_cmd): ... this.
4137         (maintenance_test_settings_show_value_cmd):
4138         (maintenance_show_test_settings_value_cmd): ... this.
4139         (_initialize_maint_test_settings): No longer install the "maint
4140         test-settings" prefix command.  Rename "maint test-settings set"
4141         to "maint set test-settings", and "maint test-settings show" to
4142         "maint show test-settings".  Adjust all subcommands.
4143
4144 2019-07-03  Pedro Alves  <palves@redhat.com>
4145
4146         * maint-test-settings.c: Fix file's intro comment.  Replace all
4147         references to "test-options" with references to "test-settings",
4148         in comments.
4149
4150 2019-07-03  Pedro Alves  <palves@redhat.com>
4151
4152         * maint-test-settings.c (maintenance_test_settings_xxx)
4153         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4154         New.
4155         (maintenance_test_settings_enums): Use them.
4156         (maintenance_test_settings_enum): Default to
4157         maintenance_test_settings_xxx.
4158         (_initialize_maint_test_settings): Initialize
4159         MAINTENANCE_TEST_SETTINGS_FILENAME.
4160
4161 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4162
4163         * breakpoint.h (remove_breakpoints_inf): Change return type to
4164         void, move function documentation here.
4165         * breakpoint.c (remove_breakpoints_inf): Change return type to
4166         void, move function documentation to header.
4167
4168 2019-07-02  Pedro Alves  <palves@redhat.com>
4169
4170         * NEWS (Completion improvements): Mention "info threads".
4171         * thread.c (struct info_threads_opts, info_threads_option_defs)
4172         (make_info_threads_options_def_group): New.
4173         (info_threads_command): Use gdb::option::process_options.
4174         (info_threads_command_completer): New.
4175         (_initialize_thread): Use gdb::option::build_help to build the
4176         help text for "info threads".
4177
4178 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4179
4180         * defs.h (generic_load): Move from here...
4181         * symfile.h (generic_load): ... to here.  Rename name parameter
4182         to args.
4183         * symfile.c (generic_load): Add comment.
4184
4185 2019-07-01  Tom Tromey  <tromey@adacore.com>
4186
4187         * dwarf2read.c
4188         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4189         declaration of without_params.  Fix formatting.
4190
4191 2019-07-01  Tom Tromey  <tromey@adacore.com>
4192
4193         * ada-exp.y (find_primitive_type): Update.
4194         * ada-lang.h (ada_lookup_symbol): Update.
4195         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4196         parameter.
4197         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4198
4199 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4200
4201         PR breakpoints/24541
4202         * gdbarch.c: Regenerate.
4203         * gdbarch.h: Regenerate.
4204         * gdbarch.sh: Add 'stap_adjust_register'.
4205         * i386-tdep.c: Include '<unordered_set>'.
4206         (i386_stap_adjust_register): New function.
4207         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4208         * stap-probe.c (stap_parse_register_operand): Call
4209         'gdbarch_stap_adjust_register'.
4210
4211 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4212
4213         PR python/24742
4214         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4215         * python/python.c (do_start_initialization): Use 'xmalloc'
4216         instead of 'PyMem_Malloc'.
4217
4218 2019-06-28  Tom Tromey  <tromey@adacore.com>
4219
4220         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4221         for Ada.
4222
4223 2019-06-27  Tom Tromey  <tromey@adacore.com>
4224
4225         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4226         objfile_key.
4227         (arm_find_mapping_symbol, arm_record_special_symbol)
4228         (_initialize_arm_tdep): Update.
4229         (arm_objfile_data_free): Remove.
4230
4231 2019-06-27  Tom Tromey  <tromey@adacore.com>
4232
4233         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4234         to cp_print_static_field.
4235
4236 2019-06-26  Tom Tromey  <tromey@adacore.com>
4237
4238         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4239         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4240         declare.
4241
4242 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4243
4244         * features/aarch64-core.c (create_feature_aarch64_core):
4245         Regenerate.
4246         * features/aarch64-core.xml: Add cpsr flags.
4247
4248 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4249
4250         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4251         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4252
4253 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4254
4255         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4256         field.
4257         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4258         use.
4259         (arm_record_special_symbol): Don't insert new symbol in sorted
4260         position, push it at the end.
4261
4262 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4263
4264         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4265         (arm_mapping_symbol_s): Remove.
4266         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4267         (arm_mapping_symbol_vec): New typedef.
4268         (struct arm_per_objfile): Add constructor.
4269         <section_maps>: Change type to
4270         std::unique_ptr<arm_mapping_symbol_vec[]>.
4271         (arm_compare_mapping_symbols): Remove.
4272         (arm_find_mapping_symbol): Adjust to section_maps type change.
4273         (arm_objfile_data_free): Call delete on arm_per_objfile.
4274         (arm_record_special_symbol): Adjust to section_maps type change.
4275         Allocate arm_per_objfile with new.
4276
4277 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4278
4279         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4280         with the command prefix.
4281
4282 2019-06-25  Tom Tromey  <tom@tromey.com>
4283
4284         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4285         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4286
4287 2019-06-25  Tom Tromey  <tom@tromey.com>
4288
4289         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4290         type.
4291         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4292         protected.
4293
4294 2019-06-25  Tom Tromey  <tom@tromey.com>
4295
4296         * tui/tui-winsource.c
4297         (tui_source_window_base::set_is_exec_point_at): Add check against
4298         LOA_ADDRESS.
4299
4300 2019-06-25  Tom Tromey  <tom@tromey.com>
4301
4302         * tui/tui-source.c (tui_set_source_content): Don't check before
4303         xfree.
4304         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4305
4306 2019-06-25  Tom Tromey  <tom@tromey.com>
4307
4308         * tui/tui-winsource.h (tui_update_source_window_as_is)
4309         (tui_alloc_source_buffer, tui_line_is_displayed)
4310         (tui_addr_is_displayed): Change type of win_info.
4311         * tui/tui-winsource.c (tui_update_source_window_as_is)
4312         (tui_clear_source_content, tui_show_source_line)
4313         (tui_show_source_content, tui_source_window_base::refill)
4314         (tui_source_window_base::set_is_exec_point_at)
4315         (tui_source_window_base::set_is_exec_point_at)
4316         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4317         (tui_alloc_source_buffer, tui_line_is_displayed)
4318         (tui_addr_is_displayed): Change type of win_info.  Update.
4319         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4320         (tui_source_window_base::do_make_visible_with_new_height):
4321         Update.
4322         * tui/tui-source.c (tui_set_source_content)
4323         (tui_set_source_content_nil)
4324         (tui_source_window::do_scroll_vertical): Update.
4325         * tui/tui-layout.c (show_layout): Update.
4326         * tui/tui-disasm.c (tui_set_disassem_content)
4327         (tui_disasm_window::do_scroll_vertical): Update.
4328         * tui/tui-data.h (tui_win_content): Remove.
4329         (struct tui_gen_win_info) <content, content_size>: Remove.
4330         (struct tui_source_element): Add initializers and destructor.
4331         (union tui_which_element, struct tui_win_element): Remove.
4332         (struct tui_source_window_base) <content>: New field.
4333         (struct tui_data_window): Remove destructor.
4334         (tui_alloc_content, tui_free_win_content)
4335         (tui_free_all_source_wins_content): Don't declare.
4336         * tui/tui-data.c (tui_initialize_static_data): Update.
4337         (init_content_element, tui_alloc_content): Remove.
4338         (~tui_gen_win_info): Update.
4339         (~tui_data_window, tui_free_all_source_wins_content)
4340         (tui_free_win_content, free_content, free_content_elements):
4341         Remove.
4342
4343 2019-06-25  Tom Tromey  <tom@tromey.com>
4344
4345         * tui/tui-winsource.h (tui_clear_source_content)
4346         (tui_erase_source_content, tui_show_source_content): Change type
4347         of win_info.
4348         * tui/tui-winsource.c (tui_clear_source_content)
4349         (tui_erase_source_content, tui_show_source_content): Change type
4350         of win_info.
4351         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4352         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4353         win_info.
4354         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4355         win_info.
4356         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4357
4358 2019-06-25  Tom Tromey  <tom@tromey.com>
4359
4360         * tui/tui-winsource.c (tui_clear_source_content)
4361         (tui_source_window_base::set_is_exec_point_at): Update.
4362         * tui/tui-source.c (tui_set_source_content_nil): Update.
4363         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4364         a bool.
4365         * tui/tui-data.c (init_content_element): Update.
4366
4367 2019-06-25  Tom Tromey  <tom@tromey.com>
4368
4369         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4370         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4371         * tui/tui-layout.c (init_and_make_win): Update.
4372         * tui/tui.h (enum tui_win_type): Update.
4373         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4374         tui_win_is_auxillary.
4375         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4376         tui_win_is_auxillary.
4377
4378 2019-06-25  Tom Tromey  <tom@tromey.com>
4379
4380         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4381         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4382         (tui_delete_data_content_windows, tui_display_all_data)
4383         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4384         Update.
4385         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4386         * tui/tui-regs.c (tui_last_regs_line_no)
4387         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4388         (tui_show_registers): Update.
4389         (tui_show_register_group): Return void.  Update.
4390         (tui_display_registers_from, tui_display_reg_element_at_line)
4391         (tui_display_registers_from_line, tui_check_register_values):
4392         Update.
4393         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4394         member.
4395         (struct tui_data_window) <regs_content>: Now a std::vector.
4396         <regs_content_count>: Remove.
4397         (tui_add_content_elements, tui_free_data_content): Don't declare.
4398         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4399         (init_content_element): Remove DATA_WIN case.  Add assert.
4400         (tui_add_content_elements): Remove.
4401         (tui_data_window): Update.
4402         (tui_free_data_content): Remove.
4403         (free_content_elements): Remove DATA_WIN case.
4404
4405 2019-06-25  Tom Tromey  <tom@tromey.com>
4406
4407         * tui/tui-data.c (tui_data_item_window): Update.
4408         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4409         * tui/tui-windata.c (tui_display_all_data)
4410         (tui_display_data_from_line): Update.
4411         (tui_check_data_values): Remove.
4412         * tui/tui-regs.c (tui_show_register_group)
4413         (tui_display_reg_element_at_line): Update.
4414         * tui/tui-hooks.c (tui_register_changed)
4415         (tui_refresh_frame_and_register_information): Call
4416         tui_check_register_values.
4417         * tui/tui-data.h (struct tui_data_window) <data_content,
4418         data_content_count, data_type>: Remove.
4419         (enum tui_data_type): Remove.
4420
4421         * tui/tui-data.c (tui_data_window::clear_detail)
4422         (~tui_data_window): Update.
4423
4424 2019-06-25  Tom Tromey  <tom@tromey.com>
4425
4426         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4427         declare.
4428         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4429         Rename from tui_first_data_item_displayed.  Update.
4430         (tui_data_window::refresh_all)
4431         (tui_data_window::do_scroll_vertical): Update.
4432         * tui/tui-data.h (struct tui_data_window)
4433         <first_data_item_displayed>: Declare new method.
4434
4435 2019-06-25  Tom Tromey  <tom@tromey.com>
4436
4437         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4438         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4439         contents...
4440         (tui_initialize_static_data): ...here.
4441
4442 2019-06-25  Tom Tromey  <tom@tromey.com>
4443
4444         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4445         (tui_display_registers_from, tui_check_register_values): Update.
4446         (tui_display_register): Remove win_info parameter; update.
4447         (tui_get_register): Change type of parameters.
4448         * tui/tui-data.h (struct tui_data_element): Remove.
4449         (union tui_which_element) <data>: Remove.
4450         <data_window>: Change type.
4451         (struct tui_data_item_window): New.
4452         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4453         case.  Add assert.
4454         (~tui_data_item_window): New destructor.
4455         (free_content_elements): Remove DATA_ITEM_WIN case.
4456
4457 2019-06-25  Tom Tromey  <tom@tromey.com>
4458
4459         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4460         Remove.
4461
4462 2019-06-25  Tom Tromey  <tom@tromey.com>
4463
4464         * tui/tui-data.h (struct tui_command_element): Remove.
4465         (union tui_which_element) <command>: Remove.
4466         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4467         assert.
4468         (free_content_elements): Remove CMD_WIN case.
4469
4470 2019-06-25  Tom Tromey  <tom@tromey.com>
4471
4472         * tui/tui-layout.c (tui_set_layout): Update.
4473         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4474         * tui/tui-data.c (layout_def): Update.
4475
4476 2019-06-25  Tom Tromey  <tom@tromey.com>
4477
4478         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4479         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4480         (tui_source_window_base::set_new_height): Update.
4481         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4482         Update.
4483         (tui_set_locator_fullname, tui_set_locator_info)
4484         (tui_show_frame_info): Update.
4485         * tui/tui-source.c (tui_set_source_content)
4486         (tui_source_is_displayed): Update.
4487         * tui/tui-layout.c (show_source_disasm_command, show_data)
4488         (show_source_or_disasm_and_command): Update.
4489         * tui/tui-disasm.c (tui_set_disassem_content)
4490         (tui_get_begin_asm_address): Update.
4491         * tui/tui-data.h (struct tui_locator_element): Remove.
4492         (union tui_which_element) <locator>: Remove.
4493         (struct tui_locator_window): New.
4494         (tui_locator_win_info_ptr): Change return type.
4495         * tui/tui-data.c (_locator): Change type.
4496         (tui_locator_win_info_ptr): Change return type.
4497         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4498         (tui_alloc_content): Add assert.
4499
4500 2019-06-25  Tom Tromey  <tom@tromey.com>
4501
4502         * tui/tui-winsource.c
4503         (tui_exec_info_window::maybe_allocate_content): New method.
4504         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4505         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4506         (make_source_or_disasm_window): Add cast.
4507         * tui/tui-data.h (union tui_which_element) <simple_string>:
4508         Remove.
4509         (struct tui_source_info): New.
4510         (struct tui_source_window_base) <execution_info>: Change type.
4511         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4512         case, and add assert.
4513         (tui_alloc_content): Add assert.
4514
4515 2019-06-25  Tom Tromey  <tom@tromey.com>
4516
4517         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4518         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4519         * tui/tui-data.c (tui_alloc_win_info): Remove.
4520
4521 2019-06-25  Tom Tromey  <tom@tromey.com>
4522
4523         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4524         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4525         can_highlight.
4526
4527 2019-06-25  Tom Tromey  <tom@tromey.com>
4528
4529         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4530         make_visible_with_new_height method.
4531         (tui_win_info::make_visible_with_new_height): New method.
4532         (tui_source_window_base::do_make_visible_with_new_height)
4533         (tui_data_window::do_make_visible_with_new_height)
4534         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4535         (make_visible_with_new_height): Remove.
4536         (tui_resize_all, tui_adjust_win_heights): Use
4537         make_visible_with_new_height method.
4538         * tui/tui-data.h (struct tui_win_info)
4539         <do_make_visible_with_new_height, make_visible_with_new_height>:
4540         New methods.
4541         (struct tui_source_window_base, struct tui_data_window)
4542         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4543         methods.
4544
4545 2019-06-25  Tom Tromey  <tom@tromey.com>
4546
4547         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4548         method.
4549         (update_tab_width): Call update_tab_width method.
4550         * tui/tui-data.h (struct tui_win_info)
4551         (struct tui_source_window_base) <update_tab_width>: New methods.
4552
4553 2019-06-25  Tom Tromey  <tom@tromey.com>
4554
4555         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4556         parameter.
4557         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4558         parameter.
4559         (tui_gen_win_info::make_visible): Update.
4560         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4561         parameter.
4562         * tui/tui-data.h (enum tui_box): New enum.
4563         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4564
4565 2019-06-25  Tom Tromey  <tom@tromey.com>
4566
4567         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4568         init_and_make_win for EXEC_INFO_WIN.
4569         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4570         longer inline.
4571         (struct tui_win_info) <~tui_win_info>: Inline.
4572         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4573         Don't declare.
4574         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4575         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4576         Remove.
4577         (tui_initialize_static_data): Update.
4578         (~tui_gen_win_info): Handle more cleanup here.
4579         (~tui_source_window_base): Delete "execution_info".
4580         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4581
4582 2019-06-25  Tom Tromey  <tom@tromey.com>
4583
4584         * tui/tui-layout.c (make_command_window): Don't set
4585         can_highlight.
4586         (show_source_disasm_command): Call the reset method.
4587         (show_data): Don't set can_highlight.  Call the reset method.
4588         (tui_gen_win_info::reset): Rename from init_gen_win_info
4589         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4590         (show_source_or_disasm_and_command): Call the reset method.
4591         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4592         (struct tui_cmd_window): Set can_highlight.
4593
4594 2019-06-25  Tom Tromey  <tom@tromey.com>
4595
4596         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4597         from make_visible.
4598         (tui_make_visible, tui_make_invisible): Rewrite.
4599         (tui_win_info::make_visible): Remove.
4600         (tui_source_window_base::make_visible): Update.
4601         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4602         method.  Moved from...
4603         (struct tui_win_info) <make_visible>: ...here.
4604
4605 2019-06-25  Tom Tromey  <tom@tromey.com>
4606
4607         * tui/tui-winsource.c
4608         (tui_source_window_base::do_scroll_horizontal): Remove direction
4609         parameter.
4610         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4611         direction parameter.
4612         * tui/tui-win.c (tui_win_info::forward_scroll)
4613         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4614         (tui_win_info::right_scroll): Update.
4615         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4616         direction parameter.
4617         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4618         direction parameter.
4619         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4620         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4621         Remove direction parameter.
4622         (struct tui_source_window_base, struct tui_source_window)
4623         (struct tui_disasm_window, struct tui_data_window)
4624         (struct tui_cmd_window): Update.
4625
4626 2019-06-25  Tom Tromey  <tom@tromey.com>
4627
4628         * tui/tui-winsource.h (tui_set_exec_info_content)
4629         (tui_show_exec_info_content, tui_erase_exec_info_content)
4630         (tui_clear_exec_info_content, tui_update_exec_info): Change
4631         argument to tui_source_window_base.
4632         * tui/tui-winsource.c (tui_set_exec_info_content)
4633         (tui_show_exec_info_content, tui_erase_exec_info_content)
4634         (tui_clear_exec_info_content, tui_update_exec_info): Change
4635         argument to tui_source_window_base.
4636
4637 2019-06-25  Tom Tromey  <tom@tromey.com>
4638
4639         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4640         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4641
4642 2019-06-25  Tom Tromey  <tom@tromey.com>
4643
4644         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4645         check.
4646
4647 2019-06-25  Tom Tromey  <tom@tromey.com>
4648
4649         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4650         type to void.
4651         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4652         type to void.
4653         * tui/tui-source.c (tui_set_source_content): Update.
4654         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4655
4656 2019-06-25  Tom Tromey  <tom@tromey.com>
4657
4658         * tui/tui-win.c (window_name_completer, tui_set_focus)
4659         (tui_all_windows_info): Use name method.
4660         * tui/tui-data.h (struct tui_gen_win_info)
4661         (struct tui_source_window, struct tui_disasm_window)
4662         (struct tui_data_window, struct tui_cmd_window) <name>: New
4663         method.
4664         (tui_win_name): Don't declare.
4665         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4666         (tui_win_name): Remove.
4667
4668 2019-06-25  Tom Tromey  <tom@tromey.com>
4669
4670         * tui/tui-winsource.h (tui_update_source_window)
4671         (tui_update_source_window_as_is): Change parameter type.
4672         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4673         to be a tui_source_window_base.
4674         (tui_update_source_window_as_is): Likewise.
4675         * tui/tui-win.c (make_visible_with_new_height): Update.
4676
4677 2019-06-25  Tom Tromey  <tom@tromey.com>
4678
4679         * tui/tui-winsource.c (tui_erase_source_content)
4680         (tui_show_source_content, tui_show_exec_info_content)
4681         (tui_erase_exec_info_content): Use refresh_window method.
4682         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4683         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4684         from tui_refresh_win.
4685         (tui_data_window::refresh_window): New method.
4686         (tui_win_info::refresh, tui_source_window_base::refresh)
4687         (tui_refresh_all): Use refresh_window method.
4688         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4689         method.
4690         * tui/tui-regs.c (tui_display_register): Call refresh_window
4691         method.
4692         * tui/tui-layout.c (show_source_disasm_command)
4693         (show_source_or_disasm_and_command): Call refresh_window method.
4694         * tui/tui-data.h (struct tui_gen_win_info)
4695         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4696         New method.
4697
4698 2019-06-25  Tom Tromey  <tom@tromey.com>
4699
4700         * tui/tui.c (tui_rl_other_window, tui_enable)
4701         (tui_is_window_visible, tui_get_command_dimension): Update.
4702         * tui/tui-winsource.c (tui_update_source_window_as_is)
4703         (tui_clear_source_content, tui_erase_source_content)
4704         (tui_show_source_line, tui_source_window_base::refill)
4705         (tui_source_window_base::do_scroll_horizontal)
4706         (tui_source_window_base::set_is_exec_point_at)
4707         (tui_update_breakpoint_info, tui_set_exec_info_content)
4708         (tui_alloc_source_buffer, tui_line_is_displayed)
4709         (tui_addr_is_displayed): Update.
4710         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4711         (tui_check_and_display_highlight_if_needed)
4712         (tui_win_info::make_visible, tui_win_info::refresh)
4713         (tui_refresh_all): Update.
4714         * tui/tui-windata.c (tui_first_data_item_displayed)
4715         (tui_delete_data_content_windows, tui_erase_data_content)
4716         (tui_display_all_data, tui_data_window::refresh_all)
4717         (tui_check_data_values): Update.
4718         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4719         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4720         (tui_win_info::backward_scroll, tui_refresh_all_win)
4721         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4722         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4723         (tui_source_window_base::set_new_height)
4724         (tui_data_window::set_new_height)
4725         (make_invisible_and_set_new_height)
4726         (make_visible_with_new_height, new_height_ok)
4727         (parse_scrolling_args): Update.
4728         * tui/tui-stack.c (tui_show_frame_info): Update.
4729         * tui/tui-source.c (tui_set_source_content)
4730         (tui_set_source_content_nil, tui_source_is_displayed)
4731         (tui_source_window::do_scroll_vertical): Update.
4732         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4733         (tui_display_registers_from, tui_display_reg_element_at_line)
4734         (tui_check_register_values, tui_reg_command): Update.
4735         * tui/tui-layout.c (tui_default_win_height)
4736         (show_source_disasm_command, show_data, init_and_make_win)
4737         (show_source_or_disasm_and_command): Update.
4738         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4739         (tui_redisplay_readline, tui_mld_flush)
4740         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4741         (tui_getc): Update.
4742         * tui/tui-disasm.c (tui_set_disassem_content)
4743         (tui_disasm_window::do_scroll_vertical): Update.
4744         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4745         Now virtual.
4746         (struct tui_win_info): Derive from tui_gen_win_info.
4747         <~tui_win_info>: Mark as override.
4748         <generic>: Remove member.
4749         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4750         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4751         (~tui_data_window, ~tui_win_info)
4752         (tui_free_all_source_wins_content): Update.
4753         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4754
4755 2019-06-25  Tom Tromey  <tom@tromey.com>
4756
4757         * tui/tui-layout.c (init_and_make_win): Use new.
4758         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4759         destructor, initializers.
4760         (tui_alloc_generic_win_info): Don't declare.
4761         * tui/tui-data.c (_locator): Add argument to constructor.
4762         (source_win, disasm_win): New globals.
4763         (exec_info): Remove.
4764         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4765         Update.
4766         (tui_alloc_generic_win_info): Remove.
4767         (init_content_element): Use new.
4768         (tui_win_info::tui_win_info): Update.
4769         (free_content_elements) <case DATA_WIN>: Use delete.
4770
4771 2019-06-25  Tom Tromey  <tom@tromey.com>
4772
4773         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4774         * tui/tui-windata.c (tui_first_data_item_displayed)
4775         (tui_delete_data_content_windows): Update.
4776         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4777         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4778         (tui_display_registers_from, tui_check_register_values): Update.
4779         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4780         pointer.
4781         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4782         window.
4783         (tui_free_data_content): Update.
4784         (free_content_elements) <case DATA_WIN>: Free the window.
4785
4786 2019-06-25  Tom Tromey  <tom@tromey.com>
4787
4788         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4789         Update.
4790         * tui/tui-layout.c (make_command_window)
4791         (show_source_disasm_command, show_data, init_and_make_win)
4792         (show_source_or_disasm_and_command): Update.
4793         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4794         method.
4795         <can_highight, is_highlighted>: Now bool.
4796         (tui_set_win_highlight): Don't declare.
4797         * tui/tui-data.c (tui_set_win_highlight): Remove.
4798
4799 2019-06-25  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui-wingeneral.c (make_visible): Remove check of window
4802         type.
4803
4804 2019-06-25  Tom Tromey  <tom@tromey.com>
4805
4806         * tui/tui-win.c (tui_win_info::max_height)
4807         (tui_cmd_window::max_height): New methods.
4808         (new_height_ok): Call max_height.
4809         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4810         <max_height>: New method.
4811
4812 2019-06-25  Tom Tromey  <tom@tromey.com>
4813
4814         * tui/tui-win.c (tui_source_window_base::set_new_height)
4815         (tui_data_window::set_new_height): New methods.
4816         (make_invisible_and_set_new_height): Call set_new_height method.
4817         * tui/tui-data.h (struct tui_win_info)
4818         (struct tui_source_window_base, struct tui_data_window)
4819         <set_new_height>: New method.
4820
4821 2019-06-25  Tom Tromey  <tom@tromey.com>
4822
4823         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4824         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4825         tui_refresh_data_win.
4826         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4827         method.
4828         (tui_refresh_all_win): Call the refresh_all method.
4829         (tui_set_focus): Likewise.
4830         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4831         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4832         Likewise.
4833
4834 2019-06-25  Tom Tromey  <tom@tromey.com>
4835
4836         * tui/tui-winsource.h (tui_refill_source_window)
4837         (tui_set_is_exec_point_at): Don't declare.
4838         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4839         (tui_source_window_base::refill): Rename from
4840         tui_refill_source_window.
4841         (tui_source_window_base::do_scroll_horizontal): Update.
4842         (tui_source_window_base::set_is_exec_point_at): Rename from
4843         tui_set_is_exec_point_at.
4844         (tui_update_all_breakpoint_info): Update.
4845         * tui/tui-stack.c (tui_show_frame_info): Update.
4846         * tui/tui-layout.c (show_data): Add cast.
4847         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4848         * tui/tui-data.h (struct tui_source_window_base) <refill,
4849         set_is_exec_point_at>: New methods.
4850         (tui_source_windows, tui_add_to_source_windows): Update types.
4851         (tui_add_to_source_windows): Remove redundant declaration.
4852         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4853         (tui_source_windows): Change return type.
4854         (tui_clear_source_windows_detail): Update.
4855         (tui_add_to_source_windows): Change type of parameter.
4856         (tui_free_all_source_wins_content): Update.
4857
4858 2019-06-25  Tom Tromey  <tom@tromey.com>
4859
4860         * tui/tui-wingeneral.c (tui_win_info::refresh)
4861         (tui_source_window_base::refresh): New methods.
4862         (tui_refresh_all): Call the refresh method.
4863         * tui/tui-data.h (struct tui_win_info)
4864         (struct tui_source_window_base) <refresh>: New method.
4865
4866 2019-06-25  Tom Tromey  <tom@tromey.com>
4867
4868         * tui/tui.h (tui_is_window_visible): Return bool.
4869         * tui/tui.c (tui_is_window_visible): Return bool.
4870         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4871         (tui_make_visible, tui_make_invisible)
4872         (tui_win_info::make_visible)
4873         (tui_source_window_base::make_visible, make_all_visible)
4874         (tui_make_all_visible, tui_make_all_invisible): Update.
4875         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4876         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4877         bool.
4878         (struct tui_win_info, struct tui_source_window_base)
4879         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4880         * tui/tui-data.c (tui_init_generic_part): Update.
4881
4882 2019-06-25  Tom Tromey  <tom@tromey.com>
4883
4884         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4885         (tui_source_window_base::make_visible): New methods.
4886         (make_all_visible): Make method call.
4887         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4888         (struct tui_source_window_base, struct tui_cmd_window): Override
4889         make_visible.
4890         (tui_win_is_source_type): Don't declare.
4891         * tui/tui-data.c (tui_win_is_source_type): Remove.
4892
4893 2019-06-25  Tom Tromey  <tom@tromey.com>
4894
4895         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4896         NULL check.
4897
4898 2019-06-25  Tom Tromey  <tom@tromey.com>
4899
4900         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4901         Inline constructor.  Add initializers for members.
4902         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4903         constructors; now inline in class.
4904
4905 2019-06-25  Tom Tromey  <tom@tromey.com>
4906
4907         * tui/tui-regs.c (tui_show_registers): Update.
4908         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4909         bool.
4910         * tui/tui-data.c (tui_data_window::clear_detail)
4911         (tui_data_window): Update.
4912
4913 2019-06-25  Tom Tromey  <tom@tromey.com>
4914
4915         * tui/tui-windata.c (tui_display_all_data)
4916         (tui_display_data_from_line, tui_display_data_from)
4917         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4918         Update.
4919         * tui/tui-regs.c (tui_last_regs_line_no)
4920         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4921         (tui_show_registers, tui_show_register_group)
4922         (tui_display_registers_from, tui_display_reg_element_at_line)
4923         (tui_display_registers_from_line, tui_check_register_values)
4924         (tui_reg_next, tui_reg_prev): Update.
4925         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4926         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4927         tui_data_window.
4928         (struct tui_win_info) <detail>: Remove.  Add new fields from
4929         tui_data_info.
4930         (TUI_DATA_WIN): Add cast.
4931         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4932         (~tui_data_window): Simplify.
4933
4934 2019-06-25  Tom Tromey  <tom@tromey.com>
4935
4936         * tui/tui-layout.c (show_source_disasm_command)
4937         (show_source_or_disasm_and_command): Update.
4938         * tui/tui-io.c (update_cmdwin_start_line)
4939         (tui_redisplay_readline): Update.
4940         * tui/tui-data.h (struct tui_command_info): Remove.
4941         (struct tui_win_info) <detail>: Remove command_info member.
4942         (struct tui_data_window) <start_line>: New member, from
4943         tui_command_info.
4944         (TUI_CMD_WIN): Add casts.
4945
4946 2019-06-25  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-winsource.c (tui_update_source_window)
4949         (tui_refill_source_window)
4950         (tui_source_window_base::do_scroll_horizontal)
4951         (tui_update_breakpoint_info, tui_set_exec_info_content)
4952         (tui_show_exec_info_content, tui_erase_exec_info_content)
4953         (tui_clear_exec_info_content): Update.
4954         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4955         Update.
4956         * tui/tui-win.c (make_invisible_and_set_new_height)
4957         (make_visible_with_new_height): Update.
4958         * tui/tui-source.c (tui_set_source_content)
4959         (tui_show_symtab_source): Update.
4960         * tui/tui-layout.c (extract_display_start_addr)
4961         (show_source_disasm_command, show_data)
4962         (make_source_or_disasm_window)
4963         (show_source_or_disasm_and_command): Update.
4964         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4965         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4966         "gdbarch".
4967         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4968         to tui_source_window_base.
4969         (struct tui_win_info) <detail>: Remove source_info member.
4970         (struct tui_source_window_base) <has_locator>: Inline.
4971         Move contents from tui_source_info; rename has_locator member to
4972         m_has_locator.
4973         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4974         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4975         header file.
4976         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4977         Simplify.
4978         (tui_free_all_source_wins_content): Cast to
4979         tui_source_window_base.
4980
4981 2019-06-25  Tom Tromey  <tom@tromey.com>
4982
4983         * tui/tui-win.c (make_invisible_and_set_new_height)
4984         (make_visible_with_new_height): Call has_locator method.
4985         * tui/tui-layout.c (show_source_disasm_command, show_data)
4986         (show_source_or_disasm_and_command): Update for bool change.
4987         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4988         (tui_win_info) <has_locator>: New method.
4989         (struct tui_source_window_base) <has_locator>: New method.
4990         (tui_win_has_locator): Don't declare.
4991         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4992         from tui_win_has_locator.
4993         (tui_source_window_base): Use false, not FALSE.
4994
4995 2019-06-25  Tom Tromey  <tom@tromey.com>
4996
4997         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4998         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4999         clear_detail method directly.
5000         (tui_clear_win_detail): Remove.
5001
5002 2019-06-25  Tom Tromey  <tom@tromey.com>
5003
5004         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5005         "this", not TUI_DISASM_WIN.
5006
5007 2019-06-25  Tom Tromey  <tom@tromey.com>
5008
5009         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5010         declare.
5011         * tui/tui-winsource.c
5012         (tui_source_window_base::do_scroll_horizontal): Rename from
5013         tui_horizontal_source_scroll.
5014         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5015         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5016         from tui_vertical_data_scroll.
5017         * tui/tui-win.h (tui_scroll): Don't declare.
5018         * tui/tui-win.c (tui_win_info::forward_scroll)
5019         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5020         (tui_win_info::right_scroll): Rename and update.
5021         (tui_scroll_forward_command, tui_scroll_backward_command)
5022         (tui_scroll_left_command, tui_scroll_right_command): Update.
5023         (tui_scroll): Remove.
5024         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5025         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5026         from tui_vertical_source_scroll.
5027         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5028         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5029         from tui_vertical_disassem_scroll.
5030         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5031         do_scroll_horizontal>: New methods.
5032         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5033         Likewise.
5034         (struct tui_source_window_base): Add do_scroll_horizontal.
5035         (struct tui_source_window, struct tui_disasm_window): Add
5036         do_scroll_vertical.
5037         (struct tui_data_window, struct tui_cmd_window): Add
5038         do_scroll_horizontal and do_scroll_vertical.
5039         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5040
5041 2019-06-25  Tom Tromey  <tom@tromey.com>
5042
5043         * tui/tui-data.h (struct tui_source_window_base): New struct.
5044         (struct tui_source_window): Derive from tui_source_window_base.
5045         (struct tui_disasm_window): New struct.
5046         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5047         from tui_source_window::clear_detail.
5048         (tui_source_window_base): Rename from tui_source_window.
5049         (~tui_source_window_base): Rename from ~tui_source_window.
5050         (tui_alloc_win_info): Create a tui_disasm_window.
5051
5052 2019-06-25  Tom Tromey  <tom@tromey.com>
5053
5054         * tui/tui-data.h (struct tui_source_window)
5055         (struct tui_data_window): Declare destructors.
5056         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5057         destructors.
5058         (tui_win_info): Simplify.
5059
5060 2019-06-25  Tom Tromey  <tom@tromey.com>
5061
5062         * tui/tui-winsource.c (tui_display_main)
5063         (tui_update_source_windows_with_addr)
5064         (tui_update_all_breakpoint_info): Update.
5065         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5066         (new_height_ok, parse_scrolling_args): Update.
5067         * tui/tui-stack.c (tui_show_frame_info): Update.
5068         * tui/tui-data.h (struct tui_list): Remove.
5069         (tui_source_windows): Return a reference to a std::vector.
5070         * tui/tui-data.c (source_windows): Now a std::vector.
5071         (tui_source_windows): Change return type.
5072         (tui_clear_source_windows): Rewrite.
5073         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5074         (tui_free_all_source_wins_content): Rewrite.
5075
5076 2019-06-25  Tom Tromey  <tom@tromey.com>
5077
5078         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5079         (struct tui_data_window, struct tui_cmd_window): Declare
5080         clear_detail method.
5081         * tui/tui-data.c (tui_source_window::clear_detail)
5082         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5083         methods.
5084         (tui_clear_win_detail): Simplify.
5085
5086 2019-06-25  Tom Tromey  <tom@tromey.com>
5087
5088         * tui/tui-layout.c (make_source_window, make_disasm_window)
5089         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5090         Return the new window.
5091         (show_source_disasm_command, show_data)
5092         (show_source_or_disasm_and_command): Update.
5093
5094 2019-06-25  Tom Tromey  <tom@tromey.com>
5095
5096         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5097         parameter.  Return the new window.
5098         (show_source_disasm_command): Update and remove NULL check.
5099         (show_source_or_disasm_and_command): Update.
5100
5101 2019-06-25  Tom Tromey  <tom@tromey.com>
5102
5103         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5104
5105 2019-06-25  Tom Tromey  <tom@tromey.com>
5106
5107         * tui/tui-data.h (struct tui_win_info): Make constructor
5108         protected.  Make destructor virtual.  Add initializers.
5109         (tui_source_window, tui_data_window, tui_cmd_window): New
5110         classes.
5111         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5112         constructor.  Add "type" parameter.
5113         (tui_source_window, tui_data_window, tui_cmd_window): New
5114         constructors.
5115         (tui_alloc_win_info): Instantiate the appropriate subclass.
5116
5117 2019-06-25  Tom Tromey  <tom@tromey.com>
5118
5119         * tui/tui-win.c (tui_resize_all): Use delete.
5120         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5121         destructor.
5122         (tui_free_window): Don't declare.
5123         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5124         Update.
5125
5126 2019-06-25  Tom Tromey  <tom@tromey.com>
5127
5128         * tui/tui-data.h (struct tui_win_info): Add constructor.
5129         * tui/tui-data.c (tui_alloc_win_info): Use new.
5130         (tui_free_window): Use delete.
5131
5132 2019-06-22  Tom Tromey  <tom@tromey.com>
5133
5134         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5135         declare.
5136         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5137
5138 2019-06-22  Tom Tromey  <tom@tromey.com>
5139
5140         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5141         declare.
5142         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5143
5144 2019-06-22  Tom de Vries  <tdevries@suse.de>
5145
5146         * dwarf2read.c (create_addrmap_from_aranges)
5147         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5148         instead of '%zu'.
5149
5150 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5151
5152         * dwarf2read.h (dwarf2_section_info_def): Remove.
5153         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5154         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5155         std::vector<dwarf2_section_info>.
5156         (struct dwo_file) <~dwo_file>: Remove.
5157         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5158         types field.
5159         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5160         (dwarf2_read_debug_names): Likewise.
5161         (create_debug_types_hash_table): Change parameter type to
5162         array_view, adjust code accordingly.
5163         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5164         (partial_die_info::fixup): Likewise.
5165         (determine_prefix): Likewise.
5166         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5167
5168 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5169
5170         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5171         gdb_bfd_ref_ptr.
5172         <~dwo_file>: Remove call to gdb_bfd_unref.
5173         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5174         gdb_bfd_ref_ptr::get.
5175
5176 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5177
5178         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5179         type to htab_up.
5180         * dwarf2read.c (struct dwo_file): Initialize fields.
5181         <~dwo_file>: New.
5182         (free_dwo_file): Remove, move content to ~dwo_file.
5183         (struct dwo_file_deleter): Remove.
5184         (dwo_file_up>: Remove custom deleter.
5185         (free_dwo_files): Remove.
5186         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5187         dwo_files.
5188         (process_skeletonless_type_units): Call unique_ptr::get.
5189         (allocate_dwo_file_hash_table): Add deleter to created hash
5190         table.  Change return type to htab_up.
5191         (lookup_dwo_file_slot): Don't memset dwo_file, call
5192         unique_ptr::get.
5193         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5194         (create_dwo_unit_in_dwp_v2): Likewise.
5195         (open_and_init_dwo_file): Likewise.
5196         (free_dwo_file_from_slot): Remove.
5197
5198 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5199
5200         * dwarf2read.h (struct dwarf2_section_info) <readin,
5201         is_virtual>: Change type to bool.
5202         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5203         true instead of 1.
5204
5205 2019-06-19  Tom Tromey  <tom@tromey.com>
5206
5207         * tui/tui-data.h (tui_init_content_element): Don't declare.
5208
5209 2019-06-19  Tom Tromey  <tom@tromey.com>
5210
5211         * tui/tui-data.h (tui_init_win_info): Don't declare.
5212
5213 2019-06-19  Tom de Vries  <tdevries@suse.de>
5214
5215         * dwarf2read.h (abstract_to_concrete): Change type to
5216         std::unordered_map<sect_offset, std::vector<sect_offset>,
5217         gdb::hash_enum<sect_offset>>.
5218
5219 2019-06-19  Tom Tromey  <tromey@adacore.com>
5220
5221         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5222         EVAL_AVOID_SIDE_EFFECTS specially.
5223
5224 2019-06-19  Tom Tromey  <tromey@adacore.com>
5225
5226         * source-cache.c (highlighter): New global.
5227         (source_cache::get_source_lines): Create a highlighter on demand.
5228
5229 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5230
5231         * defs.h (deprecated_interactive_hook): Delete declaration.
5232         * interps.c (clear_interpreter_hooks): Remove use of
5233         deprecated_interactive_hook.
5234         * top.c (deprecated_interactive_hook): Delete definition.
5235         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5236
5237 2019-06-18  Tom de Vries  <tdevries@suse.de>
5238
5239         PR gdb/24515
5240         * dwarf2read.h (abstract_to_concrete): Change type from
5241         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5242         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5243         * dwarf2read.c (read_variable): Update.
5244         (dwarf2_fetch_die_loc_sect_off): Update.
5245
5246 2019-06-17  Tom de Vries  <tdevries@suse.de>
5247
5248         PR gdb/24617
5249         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5250         accessing parent[parent_len - 1].
5251
5252 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5253
5254         PR gdb/24364
5255         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5256         call dtrace_process_dof with NULL dof.
5257
5258 2019-06-16  Tom de Vries  <tdevries@suse.de>
5259
5260         PR gdb/24445
5261         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5262
5263 2019-06-16  Tom Tromey  <tom@tromey.com>
5264
5265         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5266         (make_all_visible): Use address of member.
5267
5268 2019-06-16  Tom Tromey  <tom@tromey.com>
5269
5270         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5271         (tui_free_window, free_content, free_content_elements): Remove
5272         unnecessary cast.
5273         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5274         cast.
5275         * tui/tui-regs.c (tui_show_register_group)
5276         (tui_display_registers_from, tui_display_reg_element_at_line):
5277         Remove unnecessary cast.
5278
5279 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5280
5281         * linux-nat.c (normal_mask): Delete.
5282         (_initialize_linux_nat): Don't initialise normal_mask.
5283
5284 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5285
5286         PR gdb/24445
5287         * dwarf-index-write.h (write_psymtabs_to_index): Add
5288         dwz_basename parameter.
5289         * dwarf-index-write.c (write_gdbindex): Move file writing to
5290         write_gdbindex_1.  Change return type void.
5291         (assert_file_size): Move up, remove filename parameter.
5292         (write_gdbindex_1): New function.
5293         (write_debug_names): Change return type to void, call
5294         assert_file_size.
5295         (struct index_wip_file): New struct.
5296         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5297         file logic to index_wip_file.  Write index for dwz file if
5298         needed.
5299         (save_gdb_index_command): Pass basename of dwz file, if present.
5300         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5301         build-id of dwz file, if present.
5302         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5303         (dwarf2_get_dwz_file): Likewise.
5304         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5305         (dwarf2_get_dwz_file): Likewise.
5306
5307 2019-06-16  Tom Tromey  <tom@tromey.com>
5308
5309         * coffread.c (process_coff_symbol): Use xstrdup.
5310         * value.c (create_internalvar): Use xstrdup.
5311
5312 2019-06-16  Tom Tromey  <tom@tromey.com>
5313
5314         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5315         * breakpoint.c (stopin_command, stopat_command)
5316         (until_break_command, decode_location_default): Remove unnecessary
5317         cast.
5318         * utils.c (subset_compare): Remove unnecessary cast.
5319         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5320         cast.
5321         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5322         cast.
5323         * infcmd.c (path_command): Remove unnecessary cast.
5324         * coffread.c (decode_type): Remove unnecessary cast.
5325         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5326         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5327         * tui/tui-stack.c (tui_show_locator_content)
5328         (tui_show_frame_info): Remove unnecessary cast.
5329         * tui/tui-win.c (tui_scroll_forward_command)
5330         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5331         (parse_scrolling_args): Remove unnecessary cast.
5332         * tui/tui-data.c (init_win_info, tui_del_window)
5333         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5334         (free_content_elements): Remove unnecessary cast.
5335         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5336         unnecessary cast.
5337         * tui/tui-source.c (tui_set_source_content)
5338         (tui_vertical_source_scroll): Remove unnecessary cast.
5339         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5340         cast.
5341         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5342         * tui/tui-regs.c (tui_display_registers_from)
5343         (tui_display_register): Remove unnecessary cast.
5344         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5345         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5346         (make_visible): Remove unnecessary cast.
5347         * tui/tui-winsource.c (tui_erase_source_content)
5348         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5349         unnecessary cast.
5350         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5351         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5352         * stabsread.c (read_type, read_array_type, read_range_type):
5353         Remove unnecessary cast.
5354         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5355         (parse_symbol, parse_type, upgrade_type, parse_external)
5356         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5357         unnecessary cast.
5358         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5359
5360 2019-06-16  Tom Tromey  <tom@tromey.com>
5361
5362         * tui/tui-data.c (tui_alloc_generic_win_info)
5363         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5364         checks.
5365
5366 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5367             Andrew Burgess  <andrew.burgess@embecosm.com>
5368
5369         * f-typeprint.c (f_print_type): Don't return early for not
5370         associated or not allocated types.
5371         (f_type_print_varspec_suffix): Add print_rank parameter and print
5372         ranks of array types in case they dangling.
5373         (f_type_print_base): Add print_rank parameter.
5374
5375 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5376
5377         * NEWS: Mention new MI commands.
5378         * break-catch-throw.c (enum exception_event_kind): Move to
5379         breakpoint.h.
5380         (print_mention_exception_catchpoint): Output text as a single
5381         message.
5382         (catch_exception_command_1): Rename to...
5383         (catch_exception_event): ...this, make non-static, update header
5384         command, and change some parameter types.
5385         (catch_catch_command): Update for changes to
5386         catch_exception_command_1.
5387         (catch_throw_command): Likewise.
5388         (catch_rethrow_command): Likewise.
5389         * breakpoint.c (enum exception_event_kind): Delete.
5390         * breakpoint.h (enum exception_event_kind): Moved here from
5391         break-catch-throw.c.
5392         (catch_exception_event): Declare.
5393         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5394         (mi_cmd_catch_throw): New function.
5395         (mi_cmd_catch_rethrow): New function.
5396         (mi_cmd_catch_catch): New function.
5397         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5398         'catch-catch' entries.
5399         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5400         (mi_cmd_catch_rethrow): Declare.
5401         (mi_cmd_catch_catch): Declare.
5402
5403 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5404
5405         * annotate.c (annotate_source_line): Change return type to void,
5406         update implementation to match.
5407         * annotate.h (annotate_source_line): Change return type to void,
5408         update header comment.
5409         * stack.c (print_frame_info): Don't change what frame information
5410         is printed based on whether annotations are on or not.
5411
5412 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5413
5414         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5415         (annotate_source): Make static.
5416         (annotate_source_line): Moved from source.c and renamed from
5417         identify_source_line.  Update the return type.
5418         * annotate.h (annotate_source): Delete declaration.
5419         (annotate_source_line): Declaration moved from source.h, and
5420         renamed from identify_source_line.  Return type updated.
5421         * source.c (identify_source_line): Moved to annotate.c and renamed
5422         to annotate_source_line.
5423         (info_line_command): Remove check of annotation_level.
5424         * source.h (identify_source_line): Move declaration to annotate.h
5425         and rename to annotate_source_line.
5426         * stack.c: Add 'annotate.h' include.
5427         (print_frame_info): Remove check of annotation_level before
5428         calling annotate_source_line.
5429
5430 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5431
5432         * source-cache.c (source_cache::get_plain_source_lines): Use
5433         open_source_file_with_line_charpos instead of just
5434         open_source_file, remove call to find_source_lines.
5435         (source_cache::get_source_lines): Likewise.
5436         * source.c (find_source_lines): Make static.
5437         (get_filename_and_charpos): Renamed into...
5438         (open_source_file_with_line_charpos): ..this along with changes to
5439         return a scoped_fd, and some other minor clean ups.
5440         (identify_source_line): Use open_source_file_with_line_charpos.
5441         (search_command_helper): Use open_source_file_with_line_charpos
5442         instead of just open_source_file, remove call to
5443         find_source_lines.
5444         * source.h (open_source_file_with_line_charpos): Declare new
5445         function.
5446         (find_source_lines): Delete declaration.
5447
5448 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5449
5450         * source.c (get_filename_and_charpos): Remove fullname
5451         parameter.
5452         (identify_source_line): Update call to get_filename_and_charpos.
5453
5454 2019-06-14  Tom Tromey  <tromey@adacore.com>
5455
5456         PR gdb/24502:
5457         * ui-style.h (skip_ansi_escape): Update comment.
5458         * ui-file.h (class no_terminal_escape_file): New class.
5459         * ui-file.c (no_terminal_escape_file::write)
5460         (no_terminal_escape_file::puts): New methods.
5461         * cli/cli-logging.c (handle_redirections): Use
5462         no_terminal_escape_file.
5463
5464 2019-06-14  Tom Tromey  <tromey@adacore.com>
5465
5466         * NEWS: Move convenience variable news above Python news.
5467
5468 2019-06-14  Tom Tromey  <tom@tromey.com>
5469
5470         * gnulib: Move directory to top-level.
5471         * configure.ac: Don't configure gnulib.
5472         * configure: Rebuild.
5473         * common/common-defs.h: Use new path to gnulib.
5474         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5475         (GNULIB_H): Remove.
5476         (INCGNU): Look in new gnulib location.
5477         (HFILES_NO_SRCDIR): Remove gnulib files.
5478         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5479         (generated_files): Remove GNULIB_H.
5480         ($(LIBGNU), all-lib): Remove targets.
5481         (distclean): Don't mention GNULIB_BUILDDIR.
5482         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5483
5484 2019-06-14  Tom Tromey  <tromey@adacore.com>
5485
5486         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5487         Warn if symbol file does not provide any symbols.
5488
5489 2019-06-14  Tom Tromey  <tromey@adacore.com>
5490
5491         * source.c (find_and_open_source): Respect basenames_may_differ.
5492
5493 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5494
5495         * annotate.c (annotate_breakpoints_invalid): Make use of
5496         scoped_restore_terminal_state.
5497         (annotate_frames_invalid): Likewise.
5498
5499 2019-06-14  Tom Tromey  <tromey@adacore.com>
5500
5501         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5502         allow assignment to an internalvar.
5503
5504 2019-06-14  Tom Tromey  <tromey@adacore.com>
5505
5506         * ada-lex.l: Allow "_" in attribute names.
5507
5508 2019-06-14  Tom Tromey  <tromey@adacore.com>
5509
5510         PR gdb/24653:
5511         * regcache.c (registers_changed): Don't call alloca.
5512         * top.c (execute_command): Don't call alloca.
5513
5514 2019-06-13  Pedro Alves  <palves@redhat.com>
5515
5516         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5517         'expression'.  When parsing an expression, error out if there's
5518         junk after "unlimited".
5519         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5520         (do_set_command): Adjust calls to is_unlimited_literal.
5521
5522 2019-06-13  Pedro Alves  <palves@redhat.com>
5523
5524         * compile/compile.c (make_compile_options_def_group): Add braces
5525         around array_view initializer.
5526         * thread.c (make_thread_apply_all_options_def_group)
5527         (make_thread_apply_all_options_def_group): Likewise.
5528
5529 2019-06-13  Pedro Alves  <palves@redhat.com>
5530
5531         * NEWS (New commands): Mention "maint test-options
5532         require-delimiter", "maint test-options unknown-is-error", "maint
5533         test-options unknown-is-operand" and "maint show
5534         test-options-completion-result".
5535         (New command options, command completion): New section.
5536         (Completion improvements): New section.
5537         Mention that you can abbreviate "unlimited".
5538
5539 2019-06-13  Pedro Alves  <palves@redhat.com>
5540
5541         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5542         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5543         * unittests/cli-utils-selftests.c (test_parse_flags)
5544         (test_parse_flags_qcs): Delete.
5545         (test_cli_utils): Don't call deleted functions.
5546
5547 2019-06-13  Pedro Alves  <palves@redhat.com>
5548
5549         * thread.c: Include "cli/cli-option.h".
5550         (tp_array_compar_ascending): Global.
5551         (tp_array_compar): Delete function.
5552         (tp_array_compar_ascending, tp_array_compar_descending): New
5553         functions.
5554         (ascending_option_def, qcs_flag_option_def)
5555         (thr_qcs_flags_option_defs)
5556         (make_thread_apply_all_options_def_group)
5557         (make_thread_apply_options_def_group): New.
5558         (thread_apply_all_command): Use gdb::option::process_options.
5559         (thread_apply_command_completer)
5560         (thread_apply_all_command_completer): New.
5561         (thread_apply_command): Use gdb::option::process_options.
5562         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5563         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5564         to generate help text of "thread apply".  Adjust "taas"'s help.
5565         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5566         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5567
5568 2019-06-13  Pedro Alves  <palves@redhat.com>
5569
5570         * thread.c (thread_apply_command): Check for invalid TID with
5571         isdigit instead of !isalpha.
5572
5573 2019-06-13  Pedro Alves  <palves@redhat.com>
5574
5575         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5576         (validate_flags_qcs): New.
5577         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5578         (validate_flags_qcs): Declare.
5579         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5580         (make_frame_apply_options_def_group): New.
5581         (frame_apply_command_count): Process options with
5582         gdb::option::process_options.
5583         (frame_apply_completer): New.
5584         (frame_apply_level_completer, frame_apply_all_completer)
5585         (frame_apply_completer): New.
5586         (_initialize_stack): Update help of "frame apply", "frame apply
5587         level", "frame apply all" and "faas" to mention supported options
5588         and install command completers.
5589         * stack.h (frame_apply_all_completer): Declare.
5590         * thread.c: Include "stack.h".
5591         (tfaas_command): Add "--".
5592         (_initialize_thread): Update help "tfaas" to mention supported
5593         options and install command completer.
5594
5595 2019-06-13  Pedro Alves  <palves@redhat.com>
5596
5597         * completer.c (complete_nested_command_line): New.
5598         (gdb_completion_word_break_characters_throw): Add assertion.
5599         * completer.h (complete_nested_command_line): Declare.
5600
5601 2019-06-13  Pedro Alves  <palves@redhat.com>
5602
5603         * stack.c (parse_backtrace_qualifiers): New.
5604         (backtrace_command): Use it.
5605         (backtrace_command_completer): Complete on qualifiers.
5606
5607 2019-06-13  Pedro Alves  <palves@redhat.com>
5608
5609         * frame.c: Include "cli/cli-option.h.
5610         (user_set_backtrace_options): New.
5611         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5612         Delete.
5613         (get_prev_frame): Adjust.
5614         (boolean_option_def, uinteger_option_def)
5615         (set_backtrace_option_defs): New.
5616         (_initialize_frame): Adjust and use
5617         gdb::option::add_setshow_cmds_for_options to install "set
5618         backtrace past-main" and "set backtrace past-entry".
5619         * frame.h: Include "cli/cli-option.h".
5620         (struct frame_print_options): Forward declare.
5621         (print_frame_arguments_all, print_frame_arguments_scalars)
5622         (print_frame_arguments_none): Declare.
5623         (print_entry_values): Delete declaration.
5624         (struct frame_print_options, user_frame_print_options): New.
5625         (struct set_backtrace_options): New.
5626         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5627         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5628         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5629         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5630         (list_args_or_locals): Add frame_print_options parameter.
5631         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5632         * python/py-framefilter.c (enumerate_args): Pass down
5633         USER_FRAME_PRINT_OPTIONS.
5634         * stack.c: Include "cli/cli-option.h".
5635         (print_frame_arguments_all, print_frame_arguments_scalars)
5636         (print_frame_arguments_none): Declare.
5637         (print_raw_frame_arguments, print_entry_values): Delete.
5638         (user_frame_print_options): New.
5639         (boolean_option_def, enum_option_def, frame_print_option_defs):
5640         New.
5641         (struct backtrace_cmd_options): New.
5642         (bt_flag_option_def): New.
5643         (backtrace_command_option_defs): New.
5644         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5645         (print_frame_arg, read_frame_arg, print_frame_args)
5646         (print_frame_info, print_frame): Add frame_print_options parameter
5647         and use it.
5648         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5649         (backtrace_command_1): Add frame_print_options and
5650         backtrace_cmd_options parameters and use them.
5651         (make_backtrace_options_def_group): New.
5652         (backtrace_command): Process command options with
5653         gdb::option::process_options.
5654         (backtrace_command_completer): New.
5655         (_initialize_stack): Extend "backtrace"'s help to mention
5656         supported options.  Install completer for "backtrace".
5657         Install some settings commands with add_setshow_cmds_for_options.
5658
5659 2019-06-13  Pedro Alves  <palves@redhat.com>
5660
5661         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5662         and that "set/show print raw frame-arguments" are now deprecated.
5663
5664         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5665         command.
5666         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5667         * stack.c (_initialize_stack): Install "set/show print
5668         raw-frame-arguments", and deprecate "set/show print raw
5669         frame-arguments".
5670         * valprint.c (_initialize_valprint): Deprecate "set/show print
5671         raw".
5672
5673 2019-06-13  Pedro Alves  <palves@redhat.com>
5674
5675         * compile/compile.c (struct compile_options): New.
5676         (compile_flag_option_def, compile_command_option_defs)
5677         (make_compile_options_def_group): New.
5678         (compile_file_command): Handle options with
5679         gdb::option::process_options.
5680         (compile_file_command_completer): New function.
5681         (compile_code_command): Handle options with
5682         gdb::option::process_options.
5683         (compile_code_command_completer): New function.
5684         (_initialize_compiler): Install completers for "compile code" and
5685         "compile file".  Mention available options in "compile code" and
5686         "compile code"'s help.
5687         * completer.c (advance_to_completion_word): New, factored out from
5688         ...
5689         (advance_to_expression_complete_word_point): ... this.
5690         (advance_to_filename_complete_word_point): New.
5691         * completer.h (advance_to_filename_complete_word_point): New
5692         declaration.
5693
5694 2019-06-13  Pedro Alves  <palves@redhat.com>
5695
5696         * compile/compile.c: Include "cli/cli-option.h".
5697         (compile_print_value): Scope data pointer is now a
5698         value_print_options pointer; adjust.
5699         (compile_print_command): Process options.  Scope data pointer is
5700         now a value_print_options pointer; adjust.
5701         (_initialize_compile): Update "compile print"'s help to include
5702         supported options.  Install a completer for "compile print".
5703         * cp-valprint.c (show_vtblprint, show_objectprint)
5704         (show_static_field_print): Delete.
5705         (_initialize_cp_valprint): Don't install "set print
5706         static-members", "set print vtbl", "set print object" here.
5707         * printcmd.c: Include "cli/cli-option.h" and
5708         "common/gdb_optional.h".
5709         (print_command_parse_format): Rework to fill in a
5710         value_print_options instead of a format_data.
5711         (print_value): Change parameter type from format_data pointer to
5712         value_print_options reference.  Adjust.
5713         (print_command_1): Process options.  Adjust to pass down a
5714         value_print_options.
5715         (print_command_completer): New.
5716         (_initialize_printcmd): Install print_command_completer as
5717         handle_brkchars completer for the "print" command.  Update
5718         "print"'s help to include supported options.
5719         * valprint.c: Include "cli/cli-option.h".
5720         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5721         here from cp-valprint.c.
5722         (boolean_option_def, uinteger_option_def)
5723         (value_print_option_defs, make_value_print_options_def_group):
5724         New.  Use gdb::option::add_setshow_cmds_for_options to install
5725         "set print elements", "set print null-stop", "set print repeats",
5726         "set print pretty", "set print union", "set print array", "set
5727         print address", "set print symbol", "set print array-indexes".
5728         * valprint.h: Include <string> and "cli/cli-option.h".
5729         (make_value_print_options_def_group): Declare.
5730         (print_value): Change parameter type from format_data pointer to
5731         value_print_options reference.
5732         (print_command_completer): Declare.
5733
5734 2019-06-13  Pedro Alves  <palves@redhat.com>
5735
5736         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5737         (COMMON_SFILES): Add maint-test-settings.c.
5738         * cli/cli-decode.c (boolean_enums): New global, factored out from
5739         ...
5740         (add_setshow_boolean_cmd): ... here.
5741         * cli/cli-decode.h (boolean_enums): Declare.
5742         * cli/cli-option.c: New file.
5743         * cli/cli-option.h: New file.
5744         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5745         factored out from ...
5746         (parse_cli_boolean_value(const char *)): ... this.
5747         (is_unlimited_literal): Change parameter type to pointer to
5748         pointer.  Adjust and advance ARG pointer.
5749         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5750         (parse_cli_var_enum): New, factored out from ...
5751         (do_set_command): ... this.  Adjust.
5752         * cli/cli-setshow.h (parse_cli_boolean_value)
5753         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5754         (parse_cli_var_enum): Declare.
5755         * cli/cli-utils.c: Include "cli/cli-option.h".
5756         (get_ulongest): New.
5757         * cli/cli-utils.h (get_ulongest): Declare.
5758         (check_for_argument): New overloads.
5759         * maint-test-options.c: New file.
5760
5761 2019-06-13  Pedro Alves  <palves@redhat.com>
5762
5763         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5764         parse a range if "-" is at the end of the string.
5765
5766 2019-06-13  Pedro Alves  <palves@redhat.com>
5767
5768         * cli/cli-setshow.c (parse_auto_binary_operation)
5769         (parse_cli_boolean_value): Don't allow "o".
5770
5771 2019-06-13  Pedro Alves  <palves@redhat.com>
5772
5773         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5774         * NEWS: Mention maint test-settings KIND.
5775         * maint-test-settings.c: New file.
5776
5777 2019-06-13  Pedro Alves  <palves@redhat.com>
5778
5779         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5780         completer.
5781         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5782         "set" completers.
5783
5784 2019-06-13  Pedro Alves  <palves@redhat.com>
5785
5786         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5787         after item.
5788
5789 2019-06-13  Pedro Alves  <palves@redhat.com>
5790
5791         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5792
5793 2019-06-13  Pedro Alves <palves@redhat.com>
5794
5795         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5796         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5797         call.
5798         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5799         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5800         calls.
5801         (check_for_argument): Skip spaces after argument.
5802
5803 2019-06-13  Pedro Alves  <palves@redhat.com>
5804
5805         * thread.c (thread_apply_command): Adjust TID parsing.
5806         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5807         detected before end of string.
5808         (tid_is_in_list): Error out if LIST is invalid.
5809
5810 2019-06-13  Pedro Alves  <palves@redhat.com>
5811
5812         * completer.c (complete_line_internal_1): Rewind completion word
5813         point.
5814         (completion_tracker::advance_custom_word_point_by): Change
5815         parameter type to int.
5816         * completer.h (completion_tracker::advance_custom_word_point_by):
5817         Likewise.
5818
5819 2019-06-13  Pedro Alves  <palves@redhat.com>
5820
5821         * completer.c (advance_to_completion_word): Handle delimiters.
5822
5823 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5824
5825         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5826
5827 2019-06-11  Tom Tromey  <tom@tromey.com>
5828
5829         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5830         (xmalloc_failed): Move to alloc.c.
5831         * alloc.c: New file.
5832         * Makefile.in (COMMON_SFILES): Add alloc.c.
5833
5834 2019-06-11  Tom Tromey  <tom@tromey.com>
5835
5836         * nat/linux-waitpid.c: Don't include server.h.
5837         (linux_debug): Remove.
5838         (my_waitpid): Update.
5839
5840 2019-06-11  Tom Tromey  <tromey@adacore.com>
5841
5842         * infcall.c (_initialize_infcall): Remove trailing newline from
5843         help.
5844         * user-regs.c (_initialize_user_regs): Remove trailing newline
5845         from help.
5846         * typeprint.c (_initialize_typeprint): Remove trailing newline
5847         from help.
5848         * reverse.c (_initialize_reverse): Remove trailing newlines from
5849         help.
5850         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5851         from help.
5852         * language.c (add_set_language_command): Remove trailing newline
5853         from help.
5854         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5855         help.
5856         * disasm.c (_initialize_disasm): Remove trailing newline from
5857         help.
5858         * top.c (init_main): Remove trailing newline from help.
5859         * interps.c (_initialize_interpreter): Remove trailing newline
5860         from help.
5861         * btrace.c (_initialize_btrace): Remove trailing newlines from
5862         help.
5863         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5864         from help.
5865         * python/python.c (_initialize_python): Remove trailing newline
5866         from help.
5867         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5868         help.
5869         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5870         from help.  Reformat some text.
5871         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5872         from help.
5873         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5874         newline from help.
5875
5876 2019-06-11  Tom Tromey  <tromey@adacore.com>
5877
5878         * darwin-nat.c (darwin_decode_exception_message)
5879         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5880
5881 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5882
5883         * valops.c (value_slice): Check for not allocated or not
5884         associated values.
5885
5886 2019-06-10  Tom de Vries  <tdevries@suse.de>
5887
5888         PR gdb/24618
5889         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5890         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5891         invalid.
5892
5893 2019-06-10  Tom de Vries  <tdevries@suse.de>
5894
5895         PR gdb/24611
5896         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5897         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5898
5899 2019-06-10  Tom de Vries  <tdevries@suse.de>
5900
5901         PR symtab/24545
5902         * symtab.c (struct demangled_name_entry): Add language field.
5903         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5904         static minimal symbol".  Set and use language field.
5905
5906 2019-06-10  Tom Tromey  <tromey@adacore.com>
5907
5908         * ada-lang.c (_initialize_ada_language): Update help text.
5909
5910 2019-06-10  Tom Tromey  <tromey@adacore.com>
5911
5912         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5913         with a newline.
5914         * guile/guile.c (handle_boot_error): Don't end warning with a
5915         newline.
5916         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5917         warning with a newline.
5918         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5919         newline.
5920         (s12z_frame_cache): Likewise.
5921         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5922         a newline.
5923         * solib-svr4.c (disable_probes_interface): Don't end warning with
5924         a newline.
5925         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5926         newline.
5927         * python/python.c (do_finish_initialization): Don't end warning
5928         with a newline.
5929
5930 2019-06-10  Tom Tromey  <tom@tromey.com>
5931
5932         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5933         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5934         gdbpy_enter.
5935
5936 2019-06-10  Tom Tromey  <tromey@adacore.com>
5937
5938         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5939         data.
5940         (elf_new_init): Don't call stabsread_new_init.
5941         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5942         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5943         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5944
5945 2019-06-10  Tom de Vries  <tdevries@suse.de>
5946
5947         PR symtab/16264
5948         PR symtab/24517
5949         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5950
5951 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5952
5953         * source.c (find_and_open_source): Also rewrite relative file
5954         names.
5955
5956 2019-04-26  Amos Bird  <amosbird@gmail.com>
5957
5958         * annotate.c (annotate_thread_exited): Add "thread-exited"
5959         annotation.
5960
5961 2019-06-06  Tom Tromey  <tromey@adacore.com>
5962
5963         * maint.h (class scoped_command_stats): Use
5964         DISABLE_COPY_AND_ASSIGN.
5965         <print_time>: New method.
5966         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5967         print_time.
5968         (scoped_command_stats::print_time): New method.
5969
5970 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5971
5972         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5973         instructions of lengths 6 or 8 bytes.
5974
5975 2019-06-04  Pedro Alves  <palves@redhat.com>
5976
5977         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5978
5979         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5980         * breakpoint.c (condition_completer): Likewise.
5981         * cli/cli-dump.c (scan_expression): Likewise.
5982         * common/filestuff.c (mkdir_recursive): Likewise.
5983         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5984         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5985         (gdb_abspath): Likewise.
5986         * compile/compile-cplus-types.c
5987         (compile_cplus_instance::decl_name): Likewise.
5988         * completer.c (complete_explicit_location):
5989         (signal_completer, reg_or_group_completer_1): Likewise.
5990         * cp-support.c (cp_remove_params_if_any): Likewise.
5991         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5992         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5993         * infcmd.c (strip_bg_char): Likewise.
5994         * linespec.c (copy_token_string): Likewise.
5995         * mi/mi-main.c (output_cores): Likewise.
5996         * psymtab.c (psymtab_search_name):
5997         * symfile.c (test_set_ext_lang_command): Likewise.
5998         * target.c (target_fileio_read_stralloc): Likewise.
5999         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6000         * value.c (complete_internalvar): Likewise.
6001
6002 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6003
6004         Add objfile property to gdb.Type.
6005         * NEWS: Mention Python API addition.
6006         * python/py-type.c (typy_get_objfile): New method.
6007
6008 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6009
6010         * NEWS: Mention the new set|show style [title|highlight].
6011         Mention changes to "show style", "help" and "apropos".
6012
6013 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6014
6015         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6016         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6017         instead of print_help_for_command.
6018         (print_doc_of_command): New function.
6019         (help_list): Add 'apropos -v word' suggestion.
6020         (print_help_for_command): Style the command name using title style.
6021         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6022         (_initialize_cli_cmds): Describe -v in apropos_command help.
6023
6024 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6025
6026         * cli/cli-style.h (cli_style_option): Add name in constructor,
6027         add m_name class member, add constructor with intensity,
6028         add name class function.
6029         (cli_style_option::add_setshow_commands): Remove name argument.
6030         (highlight_style, title_style): New styles.
6031         * cli/cli-style.c (do_show): New function that shows a style
6032         characteristic styling the style name with itself.
6033         (set_style_name): New function.
6034         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6035         Update all callers according to the changes in cli/cli-style.h.
6036         * utils.h (fputs_highlighted): New function.
6037         * utils.c (fputs_highlighted): Likewise.
6038
6039 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6040
6041         * NEWS: Mention new pipe command and new convenience variables.
6042
6043 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6044
6045         * cli/cli-cmds.c (pipe_command): New function.
6046         (_initialize_cli_cmds): Call add_com for pipe_command.
6047         Define | as an alias for pipe.
6048         (exit_status_set_internal_vars): New function.
6049         (shell_escape): Call exit_status_set_internal_vars.
6050         cli/cli-decode.c (find_command_name_length): Recognize | as
6051         a single character command.
6052
6053 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6054
6055         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6056         top.c (execute_command_to_ui_file): New function, mostly a copy
6057         of execute_command_to_string.
6058         (execute_command_to_string): Implement by calling
6059         execute_command_to_ui_file.
6060
6061 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6062
6063         * top.h (saved_command_line): Remove declaration.
6064         * top.c (previous_saved_command_line, previous_repeat_arguments):
6065         New variables.
6066         (saved_command_line): Make static, define together with other
6067         'repeat variables'.
6068         (dont_repeat): Clear repeat_arguments.
6069         (repeat_previous, get_saved_command_line, save_command_line):
6070         New functions.
6071         (gdb_init): Initialize saved_command_line
6072         and previous_saved_command_line.
6073         * main.c (captured_main_1): Remove saved_command_line initialization.
6074         * event-top.c (handle_line_of_input): Update to use
6075         the new 'repeat' related functions instead of direct access to
6076         saved_command_line.
6077         * command.h (repeat_previous, get_saved_command_line,
6078         save_command_line): New declarations.
6079         (dont_repeat): Add comment.
6080
6081 2019-05-30  Tom Tromey  <tromey@adacore.com>
6082
6083         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6084         Fix comment.
6085         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6086
6087 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6088
6089         PR cli/24587
6090         * completer.c (complete): Initialize variable word.
6091
6092 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6093
6094         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6095         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6096         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6097         'body' is NULL to the outter 'if', protecting the '!is_define'
6098         situation as well.
6099
6100 2019-05-29  Tom Tromey  <tromey@adacore.com>
6101
6102         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6103         (dwarf_unknown): New function.
6104         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6105         (dwarf_type_encoding_name): Use dwarf_unknown.
6106
6107 2019-05-29  Tom Tromey  <tromey@adacore.com>
6108
6109         PR c++/20020:
6110         * cp-valprint.c (cp_print_value_fields): Call
6111         cp_print_static_field inside "try".
6112
6113 2019-05-29  Tom Tromey  <tromey@adacore.com>
6114
6115         * inflow.c (struct terminal_info): Add default operator=.
6116         * configure: Rebuild.
6117         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6118         -Wdeprecated-copy-dtor, -Wredundant-move.
6119
6120 2019-05-29  Tom Tromey  <tromey@adacore.com>
6121
6122         * NEWS: Add entry.
6123         * infcmd.c (print_return_value_1): Handle finish_print
6124         option.
6125         (show_print_finish): New function.
6126         (_initialize_infcmd): Add "set/show print finish" commands.
6127         * valprint.c (user_print_options): Initialize new member.
6128         * valprint.h (struct value_print_options) <finish_print>: New
6129         member.
6130
6131 2019-05-28  Tom Tromey  <tromey@adacore.com>
6132
6133         * ada-lang.c (ada_remove_Xbn_suffix)
6134         (find_old_style_renaming_symbol)
6135         (parse_old_style_renaming): Remove.
6136         (ada_find_renaming_symbol): Don't call
6137         find_old_style_renaming_symbol.
6138         (ada_is_renaming_symbol): Rename from
6139         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6140         bool.  Now static.
6141         (ada_read_var_value): Update and simplify.
6142         * ada-exp.y (write_var_or_type): Remove old code.
6143
6144 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6145
6146         * event-top.c: Remove include comment.
6147         * inflow.c (class scoped_ignore_sigttou): Move from here...
6148         * inflow.h (class scoped_ignore_sigttou): ...to here.
6149         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6150         * top.c:  Remove include comment.
6151
6152 2019-05-27  Tom Tromey  <tom@tromey.com>
6153
6154         * NEWS: Fix typo.
6155
6156 2019-05-22  Tom Tromey  <tromey@adacore.com>
6157
6158         * target.c (target_follow_exec): Constify parameter.
6159         * target-delegates.c: Rebuild.
6160         * remote.c (remote_target::follow_exec): Constify parameter.
6161         * infrun.c (follow_exec): Constify parameter.
6162         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6163         (target_follow_exec): Likewise.
6164
6165 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6166
6167         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6168         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6169
6170 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6171
6172         * NEWS: Add debugredirect and testsuite sections.
6173
6174 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6175
6176         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6177         target descriptions using exclusively floating point register name
6178         aliases.
6179
6180 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6181
6182         PR gdb/18644:
6183         * f-lang.c (build_fortran_types): Handle the case where
6184         gdbarch_floatformat_for_type returns a nullptr.
6185
6186 2019-05-21  Tom de Vries  <tdevries@suse.de>
6187
6188         PR cli/24587
6189         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6190
6191 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6192
6193         PR gdb/18644:
6194         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6195         16-byte floats.
6196         * i386-tdep.c (i386_floatformat_for_type): Use
6197         floatformats_ia64_quad for the 16-byte floating point component
6198         within a fortran 32-byte complex number.
6199
6200 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6201
6202         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6203         delete default constructor.
6204         (find_partial_die): Update to return const struct.
6205         (partial_die_parent_scope): Move variable declaration into scope
6206         of its use and change its type to auto.
6207         (guess_partial_die_structure_name): Likewise.
6208         (partial_die_info::fixup): Likewise.
6209
6210 2019-05-17  Tom Tromey  <tromey@adacore.com>
6211
6212         * source.c (find_and_open_source): Remove cast.
6213
6214 2019-05-17  Tom Tromey  <tromey@adacore.com>
6215
6216         * annotate.c (annotate_source): Make "filename" const.
6217         * annotate.h (annotate_source): Use const.
6218
6219 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6220
6221         * disasm.c (set_disassembler_options): Send errors to stderr.
6222
6223 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6224
6225         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6226         (cli_interp_base::set_logging): Check debug_redirect.
6227         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6228         * cli/cli-logging.c (debug_redirect): Add static variable.
6229         (pop_output_files): Add default param.
6230         (handle_redirections): Print debug setting.
6231         (show_logging_command): Likewise.
6232         (_initialize_cli_logging): Add debugredirect command.
6233         * interps.c (current_interp_set_logging): Add debug_redirect
6234         parameter.
6235         * interps.h (set_logging): Add debug_redirect parameter.
6236         (current_interp_set_logging): Likewise.
6237         * mi/mi-common.h: Likewise.
6238         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6239
6240 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6241             Tom Tromey  <tromey@adacore.com>
6242
6243         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6244         directly.
6245         * cli/cli-interp.h (make_logging_output): Remove declaration.
6246         * cli/cli-logging.c (make_logging_output): Remove function.
6247         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6248         directly.
6249         * ui-file.c (tee_file::tee_file): Remove bools.
6250         (tee_file::~tee_file): Remove deletes.
6251         * ui-file.h (tee_file): Remove bools.
6252
6253 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6254
6255         * mi/mi-cmds.h (mi_cmd_complete): New function.
6256         * mi/mi-main.c (mi_cmd_complete): Likewise.
6257         * mi/mi-cmds.c: Define new MI command -complete.
6258         * NEWS: Mention new -complete command.
6259
6260 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6261
6262         * completer.h (complete): New function.
6263         * completer.c (complete): Likewise.
6264         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6265         function defined in completer.h.
6266
6267 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6268
6269         * MAINTAINERS (Write After Approval): Add myself.
6270
6271 2019-05-17  Tom de Vries  <tdevries@suse.de>
6272
6273         PR gdb/24094
6274         * dwarf2read.c (struct cu_partial_die_info): New struct.
6275         (find_partial_die): Return cu_partial_die_info.
6276         (partial_die_parent_scope, guess_partial_die_structure_name)
6277         (partial_die_info::fixup): Handle new return type of find_partial_die.
6278
6279 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6280
6281         PR breakpoints/24541
6282         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6283         "std::string", simplifying the algorithm.
6284
6285 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6286
6287         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6288         (stap_static_probe_ops::get_probes): Likewise.
6289
6290 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6291
6292         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6293         '-')" and "else if".
6294         (stap_parse_single_operand): Join checks for
6295         "gdbarch_stap_parse_special_token_p" and
6296         "gdbarch_stap_parse_special_token" in the same "if" statement.
6297         Invert check when verifying for operation on register
6298         displacement.
6299
6300 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6301
6302         * stap-probe.c (stap_get_opcode): Update comment.
6303         (stap_get_expected_argument_type): Likewise.
6304         (handle_stap_probe): Likewise.
6305
6306 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6307
6308         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6309         return type to 'bool'.  Adjust comment.  Use 'bool' when
6310         appropriate.
6311         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6312         * stap-probe.c (stap_parse_argument_1): Likewise.
6313         (stap_is_operator): Likewise.
6314         (stap_is_generic_prefix): Likewise.
6315         (stap_is_register_prefix): Likewise.
6316         (stap_is_register_indirection_prefix): Likewise.
6317         (stap_is_integer_prefix): Likewise.
6318         (stap_generic_check_suffix): Likewise.
6319         (stap_check_integer_suffix): Likewise.
6320         (stap_check_register_suffix): Likewise.
6321         (stap_check_register_indirection_suffix): Likewise.
6322         (stap_parse_register_operand): Likewise.
6323         (stap_parse_single_operand): Likewise.
6324         (stap_parse_argument_1): Likewise.
6325         (stap_probe::get_argument_count): Likewise.
6326         (stap_is_operator): Likewise.
6327
6328 2019-05-16  Tom Tromey  <tromey@adacore.com>
6329
6330         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6331         keyword to foreach.
6332
6333 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6334
6335         * linux-thread-db.c (try_thread_db_load_1): Change return type
6336         to bool.
6337         (try_thread_db_load): Likewise.
6338         (try_thread_db_load_from_pdir_1): Likewise.
6339         (try_thread_db_load_from_pdir): Likewise.
6340         (try_thread_db_load_from_sdir): Likewise.
6341         (try_thread_db_load_from_dir): Likewise.
6342         (thread_db_load_search): Likewise.
6343         (has_libpthread): Likewise.
6344         (thread_db_load): Likewise.
6345
6346 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6347
6348         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6349         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6350         NULL, and complain/return if that's the case.
6351
6352 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6353
6354         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6355         (advance, posn, abstract_read_memory): New functions.
6356         [struct mem_read_abstraction]: New struct.
6357         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6358
6359 2019-05-14  Tom Tromey  <tromey@adacore.com>
6360
6361         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6362         value is not lval_memory.
6363
6364 2019-05-14  Tom Tromey  <tromey@adacore.com>
6365
6366         * solib.c (info_sharedlibrary_command): Style the file name.
6367
6368 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6369
6370         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6371         (aarch64_vnv_type): Likewise.
6372         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6373         * common/tdesc.c: Likewise.
6374         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6375         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6376         * features/aarch64-fpu.xml: Add ieee half view.
6377         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6378         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6379         * gdbtypes.h (struct builtin_type): Likewise.
6380         (struct objfile_type): Likewise.
6381
6382 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6383
6384         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6385         typo.
6386         * location.h (string_to_event_location): Likewise.
6387
6388 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6389
6390         GDB 8.3 released.
6391
6392 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6393
6394         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6395         New variable declaration.
6396         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6397         New variable.
6398         (print_one_breakpoint): Use ui_out::test_flags and new global
6399         variable to compute use_fixed_output.
6400         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6401         Remove.
6402         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6403         (mi_multi_location_breakpoint_output_fixed): Remove.
6404         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6405         new variable.
6406         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6407         fix_multi_location_breakpoint_output flag if version >= 3.
6408         * ui-out.h (enum ui_out_flag)
6409         <fix_multi_location_breakpoint_output>: New enumerator.
6410
6411 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6412
6413         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6414
6415 2019-05-10  Tom Tromey  <tromey@adacore.com>
6416
6417         * ada-lang.c (catch_ada_completer): New function.
6418         (_initialize_ada_language): Use it.
6419
6420 2019-05-10  Tom Tromey  <tromey@adacore.com>
6421
6422         * thread.c (print_thread_info): Make "requested_threads" const.
6423         * gdbthread.h (print_thread_info): Make "requested_threads"
6424         const.
6425         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6426         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6427
6428 2019-05-08  Tom Tromey  <tom@tromey.com>
6429
6430         * gdbtypes.c (objfile_type_data): Change type.
6431         (objfile_type, _initialize_gdbtypes): Update.
6432
6433 2019-05-08  Tom Tromey  <tom@tromey.com>
6434
6435         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6436         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6437         (_initialize_dwarf2_frame): Update.
6438
6439 2019-05-08  Tom Tromey  <tom@tromey.com>
6440
6441         * objc-lang.c (objc_objfile_data): Change type.
6442         (find_methods): Update.
6443         (_initialize_objc_lang): Remove.
6444
6445 2019-05-08  Tom Tromey  <tom@tromey.com>
6446
6447         * stabsread.c (rs6000_builtin_type_data): Change type.
6448         (rs6000_builtin_type, _initialize_stabsread): Update.
6449
6450 2019-05-08  Tom Tromey  <tom@tromey.com>
6451
6452         * mips-tdep.c (mips_pdr_data): Remove.
6453         (_initialize_mips_tdep): Update.
6454
6455 2019-05-08  Tom Tromey  <tom@tromey.com>
6456
6457         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6458         (hppa_init_objfile_priv_data, read_unwind_info)
6459         (find_unwind_entry, _initialize_hppa_tdep): Update.
6460
6461 2019-05-08  Tom Tromey  <tom@tromey.com>
6462
6463         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6464         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6465         on obstack.
6466         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6467
6468 2019-05-08  Tom Tromey  <tom@tromey.com>
6469
6470         * mdebugread.c (basic_type_data): Change type.
6471         (basic_type, _initialize_mdebugread): Update.
6472
6473 2019-05-08  Tom Tromey  <tom@tromey.com>
6474
6475         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6476
6477 2019-05-08  Tom Tromey  <tom@tromey.com>
6478
6479         * nto-tdep.c (nto_inferior_data_reg): Change type.
6480         (nto_inferior_data): Update.
6481         (nto_inferior_data_cleanup, nto_new_inferior_data)
6482         (_initialize_nto_tdep): Remove.
6483         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6484
6485 2019-05-08  Tom Tromey  <tom@tromey.com>
6486
6487         * ada-lang.c (struct ada_inferior_data): Add initializers.
6488         (ada_inferior_data): Change type.
6489         (ada_inferior_data_cleanup): Remove.
6490         (get_ada_inferior_data, ada_inferior_exit)
6491         (struct ada_pspace_data): Add initializers, destructor.
6492         (ada_pspace_data_handle): Change type.
6493         (get_ada_pspace_data): Update.
6494         (ada_pspace_data_cleanup): Remove.
6495
6496 2019-05-08  Tom Tromey  <tom@tromey.com>
6497
6498         * coffread.c (struct coff_symfile_info): Add initializers.
6499         (coff_objfile_data_key): Move lower.  Change type.
6500         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6501         Update.
6502         (coff_free_info): Remove.
6503
6504 2019-05-08  Tom Tromey  <tom@tromey.com>
6505
6506         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6507         (fbsd_pspace_data_handle): Move lower.  Change type.
6508         (get_fbsd_pspace_data): Update.
6509         (fbsd_pspace_data_cleanup): Remove.
6510         (_initialize_fbsd_tdep): Update.
6511
6512 2019-05-08  Tom Tromey  <tom@tromey.com>
6513
6514         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6515         (get_ada_tasks_pspace_data): Update.
6516         (ada_tasks_pspace_data_cleanup): Remove.
6517         (_initialize_tasks): Update.
6518         (ada_tasks_inferior_data_handle): Change type.
6519         (get_ada_tasks_inferior_data): Update.
6520         (ada_tasks_inferior_data_cleanup): Remove.
6521         (struct ada_tasks_pspace_data): Add initializers.
6522
6523 2019-05-08  Tom Tromey  <tom@tromey.com>
6524
6525         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6526         * symfile-debug.c (debug_sym_get_probes): Change type.
6527         * stap-probe.c (handle_stap_probe):
6528         (stap_static_probe_ops::get_probes): Change type.
6529         * probe.h (class static_probe_ops) <get_probes>: Change type.
6530         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6531         (parse_probes_in_pspace): Update.
6532         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6533         Update.
6534         (any_static_probe_ops::get_probes): Change type.
6535         * elfread.c (elfread_data): New typedef.
6536         (probe_key): Change type.
6537         (elf_get_probes): Likewise.  Update.
6538         (probe_key_free): Remove.
6539         (_initialize_elfread): Update.
6540         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6541         Change type.
6542         (dtrace_process_dof_probe, dtrace_process_dof)
6543         (dtrace_static_probe_ops::get_probe): Change type.
6544
6545 2019-05-08  Tom Tromey  <tom@tromey.com>
6546
6547         * xcoffread.c (struct xcoff_symfile_info): Rename from
6548         coff_symfile_info.  Add initializers.
6549         (xcoff_objfile_data_key): Move lower.  Change type.
6550         (XCOFF_DATA): Rewrite.
6551         (xcoff_free_info): Remove.
6552         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6553         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6554         (xcoff_initial_scan): Update.
6555
6556 2019-05-08  Tom Tromey  <tom@tromey.com>
6557
6558         * solib-svr4.c (struct svr4_info): Add initializers and
6559         destructor.
6560         <probes_table>: Now an htab_up.
6561         (solib_svr4_pspace_data): Change type.
6562         (free_probes_table): Simplify.
6563         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6564         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6565         (probes_table_remove_objfile_probes, register_solib_event_probe)
6566         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6567         (_initialize_svr4_solib): Update.
6568
6569 2019-05-08  Tom Tromey  <tom@tromey.com>
6570
6571         * remote.c (remote_pspace_data): Change type.
6572         (remote_pspace_data_cleanup): Remove.
6573         (get_remote_exec_file, set_pspace_remote_exec_file)
6574         (_initialize_remote): Update.
6575
6576 2019-05-08  Tom Tromey  <tom@tromey.com>
6577
6578         * breakpoint.c (breakpoint_objfile_key): Change type.
6579         (get_breakpoint_objfile_data): Update.
6580         (free_breakpoint_objfile_data): Remove.
6581         (_initialize_breakpoint): Update.
6582
6583 2019-05-08  Tom Tromey  <tom@tromey.com>
6584
6585         * linux-tdep.c (struct linux_info): Add initializers.
6586         (linux_inferior_data): Move.  Change type.
6587         (invalidate_linux_cache_inf): Update.
6588         (linux_inferior_data_cleanup): Remove.
6589         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6590
6591 2019-05-08  Tom Tromey  <tom@tromey.com>
6592
6593         * auxv.c (auxv_inferior_data): Move.  Change type.
6594         (auxv_inferior_data_cleanup): Remove.
6595         (invalidate_auxv_cache_inf): Rewrite.
6596         (get_auxv_inferior_data, _initialize_auxv): Update.
6597
6598 2019-05-08  Tom Tromey  <tom@tromey.com>
6599
6600         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6601         (symfile_debug_objfile_data_key): Change type.
6602         (symfile_debug_installed, debug_qf_has_symbols)
6603         (debug_qf_find_last_source_symtab)
6604         (debug_qf_forget_cached_source_info)
6605         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6606         (debug_qf_print_stats, debug_qf_dump)
6607         (debug_qf_expand_symtabs_for_function)
6608         (debug_qf_expand_all_symtabs)
6609         (debug_qf_expand_symtabs_with_fullname)
6610         (debug_qf_map_matching_symbols)
6611         (debug_qf_expand_symtabs_matching)
6612         (debug_qf_find_pc_sect_compunit_symtab)
6613         (debug_qf_map_symbol_filenames)
6614         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6615         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6616         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6617         (debug_sym_read_linetable, debug_sym_relocate): Update.
6618         (symfile_debug_free_objfile): Remove.
6619         (install_symfile_debug_logging, _initialize_symfile_debug):
6620         Update.
6621
6622 2019-05-08  Tom Tromey  <tom@tromey.com>
6623
6624         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6625         allocate_on_obstack.
6626         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6627         (get_dwarf2_per_objfile): Update.
6628         (set_dwarf2_per_objfile): Remove.
6629         (dwarf2_has_info, dwarf2_get_section_info): Update.
6630         (dwarf2_free_objfile): Remove.
6631         (_initialize_dwarf2_read): Update.
6632
6633 2019-05-08  Tom Tromey  <tom@tromey.com>
6634
6635         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6636         initializers.
6637         <unsupported_script_warning_printed,
6638         script_not_found_warning_printed>: Now bool.
6639         (auto_load_pspace_data): Change type.
6640         (~auto_load_pspace_info): Rename from
6641         auto_load_pspace_data_cleanup.
6642         (get_auto_load_pspace_data, init_loaded_scripts_info)
6643         (clear_section_scripts, maybe_print_unsupported_script_warning)
6644         (maybe_print_script_not_found_warning, _initialize_auto_load):
6645         Update.
6646
6647 2019-05-08  Tom Tromey  <tom@tromey.com>
6648
6649         * objfiles.c (objfile_pspace_info): Add destructor and
6650         initializers.
6651         (objfiles_pspace_data): Change type.
6652         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6653         (get_objfile_pspace_data): Update.
6654         (objfiles_bfd_data): Change type.
6655         (get_objfile_bfd_data): Update.
6656         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6657
6658 2019-05-08  Tom Tromey  <tom@tromey.com>
6659
6660         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6661         Change type.
6662         (get_catch_syscall_inferior_data): Update.
6663         (catch_syscall_inferior_data_cleanup): Remove.
6664         (_initialize_break_catch_syscall): Update.
6665
6666 2019-05-08  Tom Tromey  <tom@tromey.com>
6667
6668         * inflow.c (struct terminal_info): Add destructor and
6669         initializers.
6670         (inflow_inferior_data): Change type.
6671         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6672         (get_inflow_inferior_data, inflow_inferior_exit)
6673         (swap_terminal_info, _initialize_inflow): Update.
6674
6675 2019-05-08  Tom Tromey  <tom@tromey.com>
6676
6677         * target-dcache.c (target_dcache_cleanup): Remove.
6678         (target_dcache_aspace_key): Change type.
6679         (target_dcache_init_p, target_dcache_invalidate)
6680         (target_dcache_get, target_dcache_get_or_init)
6681         (_initialize_target_dcache): Update.
6682         * dcache.h (struct dcache_deleter): New.
6683
6684 2019-05-08  Tom Tromey  <tom@tromey.com>
6685
6686         * symtab.c (struct symbol_cache): Add destructor and
6687         initializers.
6688         (symbol_cache_key): Move.  Change type.
6689         (make_symbol_cache, free_symbol_cache): Remove.
6690         (get_symbol_cache): Update.
6691         (symbol_cache_cleanup): Remove.
6692         (ALL_PSPACES, symbol_cache_flush)
6693         (maintenance_print_symbol_cache)
6694         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6695         Update.
6696
6697 2019-05-08  Tom Tromey  <tom@tromey.com>
6698
6699         * symtab.c (struct main_info): Add destructor and initializers.
6700         (main_progspace_key): Move.  Change type.
6701         (get_main_info): Update.
6702         (main_info_cleanup): Remove.
6703         (_initialize_symtab): Update.
6704
6705 2019-05-08  Tom Tromey  <tom@tromey.com>
6706
6707         * registry.h (DECLARE_REGISTRY): Define the _key class.
6708
6709 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6710
6711         * NEWS: Merge two 'New commands' sections.
6712
6713 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6714
6715         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6716         parameter and use Ada language definition instead.
6717         (ada_val_print_ptr): Remove unused language parameter.
6718         (ada_val_print_num): Remove language parameter and use Ada language
6719         definition instead.
6720         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6721         parameter.
6722         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6723         parameter and use Ada language definition instead.
6724         (ada_val_print_1): Update all ada_val_print_xxx calls.
6725         Remove language parameter.
6726         (ada_val_print): Update ada_val_print_1 call.
6727
6728 2019-05-08  Tom Tromey  <tromey@adacore.com>
6729
6730         * remote.c (remote_hw_watchpoint_limit)
6731         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6732         Now static.
6733
6734 2019-05-08  Tom Tromey  <tromey@adacore.com>
6735
6736         * maint.c (_initialize_maint_cmds): Move initialization code to
6737         remote.c.
6738         (watchdog, show_watchdog): Move to remote.c.
6739         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6740         "watchdog" static.
6741         (_initialize_remote): Move initialization code from maint.c.
6742         * defs.h (watchdog): Don't declare.
6743
6744 2019-05-08  Tom Tromey  <tromey@adacore.com>
6745
6746         * tui/tui-interp.c: Include main.h.
6747         * interps.c: Include main.h.
6748         * main.h (interpreter_p): Declare.
6749         * defs.h (interpreter_p): Don't declare.
6750
6751 2019-05-08  Tom Tromey  <tromey@adacore.com>
6752
6753         * dwarf2loc.c: Include dwarf2read.h.
6754         * defs.h (read_unsigned_leb128): Don't declare.
6755         * dwarf2read.h (read_unsigned_leb128): Declare.
6756
6757 2019-05-08  Tom Tromey  <tromey@adacore.com>
6758
6759         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6760         method.
6761
6762 2019-05-08  Tom Tromey  <tromey@adacore.com>
6763
6764         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6765         when no wrap column is set.
6766
6767 2019-05-08  Tom Tromey  <tromey@adacore.com>
6768
6769         * c-lang.c (c_get_string): Handle non-C-style arrays.
6770
6771 2019-05-08  Tom Tromey  <tromey@adacore.com>
6772
6773         * typeprint.c (print_offset_data::update): Print the bit offset,
6774         not the number of bits remaining.
6775
6776 2019-05-08  Tom Tromey  <tromey@adacore.com>
6777
6778         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6779         padding at end of comment.
6780
6781 2019-05-08  Tom Tromey  <tromey@adacore.com>
6782
6783         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6784         Compare main types.
6785
6786 2019-05-06  Tom Tromey  <tom@tromey.com>
6787
6788         * common/scoped_mmap.c: Include common-defs.h.
6789         * common/scoped_mmap.h: Don't include config.h.
6790
6791 2019-05-04  Tom Tromey  <tom@tromey.com>
6792
6793         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6794         (struct aarch64_call_info): Add initializers.
6795         <si>: Now a std::vector.
6796         (pass_on_stack, aarch64_push_dummy_call): Update.
6797
6798 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6799             Tom Tromey  <tom@tromey.com>
6800
6801         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6802         (ppc_threads): Now a std::vector.  Now static.
6803         (hwdebug_find_thread_points_by_tid)
6804         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6805         Update.
6806
6807 2019-05-04  Tom Tromey  <tom@tromey.com>
6808
6809         * arc-tdep.c (arc_tdesc_init): Return bool.
6810
6811 2019-05-04  Tom Tromey  <tom@tromey.com>
6812
6813         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6814         Use gdb_assert_not_reached.
6815
6816 2019-05-04  Tom Tromey  <tom@tromey.com>
6817
6818         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6819         "false".
6820
6821 2019-05-04  Tom Tromey  <tom@tromey.com>
6822
6823         * arc-tdep.c (arc_tdesc_init): Use bool.
6824
6825 2019-05-04  Tom Tromey  <tom@tromey.com>
6826
6827         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6828
6829 2019-05-04  Tom Tromey  <tom@tromey.com>
6830
6831         * cli/cli-cmds.c (valid_command_p): Return bool.
6832
6833 2019-05-04  Tom Tromey  <tom@tromey.com>
6834
6835         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6836         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6837
6838 2019-05-04  Raul Tambre  <raul@tambre.ee>
6839
6840         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6841         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6842         operator for comparison.
6843
6844 2019-05-04  Tom Tromey  <tom@tromey.com>
6845
6846         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6847         (lookup_partial_symbol, print_partial_symbols)
6848         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6849         (psymbol_compare): Update.
6850         (add_psymbol_to_bcache): Clear the entire psymbol.
6851         (maintenance_check_psymtabs): Update.
6852         * psympriv.h (struct partial_symbol): Don't derive from
6853         general_symbol_info.
6854         <obj_section, unrelocated_address, address,
6855         set_unrelocated_address>: Update.
6856         <ginfo>: New member.
6857         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6858         (debug_names::write_psymbols): Update.
6859
6860 2019-05-04  Tom de Vries  <tdevries@suse.de>
6861
6862         * contrib/cc-with-tweaks.sh: Support -n arg.
6863
6864 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6865
6866         * corelow.c (core_target::detach): Ensure frame cache and
6867         register caches are cleared.
6868         inferior.c (exit_inferior_1): Likewise.
6869
6870 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6871             Tom Tromey  <tom@tromey.com>
6872
6873         * dictionary.c (collate_pending_symbols_by_language): Remove
6874         "struct" from foreach.
6875         * symtab.c (lookup_global_symbol_from_objfile)
6876         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6877         foreach.
6878         * ser-tcp.c (net_open): Remove "struct" from foreach.
6879         * objfiles.c (objfile_relocate, objfile_rebase)
6880         (objfile_has_symbols): Remove "struct" from foreach.
6881         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6882         from foreach.
6883         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6884         foreach.
6885         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6886         "struct" from foreach.
6887         * ada-lang.c (create_excep_cond_exprs)
6888         (ada_exception_catchpoint_cond_string): Remove "struct" from
6889         foreach.
6890
6891 2019-05-03  Tom Tromey  <tromey@adacore.com>
6892
6893         * ada-exp.y (convert_char_literal): Check suffix of each
6894         enumerator.
6895
6896 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6897
6898         PR ada/21406:
6899         * ada-exp.y (yywrap): Don't define.
6900         * ada-lex.l (%option): Add noyywrap
6901         (yywrap): Remove.
6902
6903 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6904
6905         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6906         _WIN32_WINNT to the XP level, unless already defined to a higher
6907         level.
6908
6909         * unittests/parse-connection-spec-selftests.c:
6910         * ser-tcp.c:
6911         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6912         override.
6913
6914         * symfile.c (find_separate_debug_file): Remove colon from the
6915         drive spec of DOS/Windows file names of the target, so that the
6916         file name produced from DEBUGDIR and the target's directory will
6917         be valid on DOS/Windows systems.
6918
6919 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6920
6921         * rust-lang.c (val_print_struct): Handle printing structures
6922         containing strings.
6923
6924 2019-05-02  Tom Tromey  <tromey@adacore.com>
6925
6926         * valarith.c (_initialize_valarith): Remove.
6927
6928 2019-05-01  Tom Tromey  <tromey@adacore.com>
6929
6930         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6931         bitfields.
6932
6933 2019-05-01  Tom Tromey  <tromey@adacore.com>
6934
6935         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6936         for big-endian copies.
6937
6938 2019-04-30  Ali Tamur  <tamur@google.com>
6939         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6940         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6941         (read_3_bytes): New function.
6942
6943 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6944
6945         * windows-nat.c (main_thread_id): Delete.
6946         (handle_output_debug_string): Replace main_thread_id by
6947         current_event.dwThreadId.
6948         (fake_create_process): Likewise.
6949         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6950         Do not set main_thread_id.
6951         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6952         current_event.dwThreadId.
6953         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6954
6955 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6956
6957         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6958         Use current_event.dwThreadId instead of main_thread_id.
6959
6960 2019-04-30  Tom Tromey  <tromey@adacore.com>
6961
6962         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6963         (create_excep_cond_exprs): Iterate over program spaces.
6964         (ada_exception_catchpoint_cond_string): Examine all minimal
6965         symbols for exception types.
6966
6967 2019-04-30  Tom Tromey  <tromey@adacore.com>
6968
6969         PR c++/24470:
6970         * dwarf2read.c (process_structure_scope): Handle case where type
6971         has template parameters but no symbol was created.
6972
6973 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6974             Chris January  <chris.january@arm.com>
6975
6976         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6977         qualifier.
6978         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6979
6980 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6981
6982         * f-typeprint.c (f_print_type): Update rules for printing
6983         whitespace.
6984         (f_type_print_varspec_suffix): Likewise.
6985
6986 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6987             Chris January  <chris.january@arm.com>
6988
6989         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6990         function arguments.
6991
6992 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6993
6994         * f-lang.c (build_fortran_types): Change name of void type to
6995         lower case.
6996         * f-typeprint.c (f_type_print_base): Print the name of the void
6997         type, rather than a fixed string.
6998         * f-valprint.c (f_decorations): Use lower case void string.
6999
7000 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7001             Chris January  <chris.january@arm.com>
7002
7003         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7004         types for Fortran.
7005
7006 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7007             Chris January  <chris.january@arm.com>
7008             David Lecomber  <david.lecomber@arm.com>
7009
7010         * f-exp.y (BINOP_INTRINSIC): New token.
7011         (exp): New parser rule handling BINOP_INTRINSIC.
7012         (f77_keywords): Add new builtin procedures.
7013         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7014         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7015         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7016         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7017         (print_unop_subexp_f): New function.
7018         (print_binop_subexp_f): New function.
7019         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7020         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7021         (dump_subexp_body_f): Likewise.
7022         (operator_check_f): Likewise.
7023         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7024         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7025
7026 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7027
7028         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7029         UNOP_KIND.
7030         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7031         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7032         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7033         (operator_length_f): New fuction.
7034         (print_subexp_f): New function.
7035         (op_name_f): New function.
7036         (dump_subexp_body_f): New function.
7037         (operator_check_f): New function.
7038         (exp_descriptor_f): Replace standard expression handling functions
7039         with new functions.
7040         * gdb/fortran-operator.def: New file.
7041         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7042         * gdb/std-operator.def: Remove UNOP_KIND.
7043
7044 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7045
7046         * std-operator.def: Remove unbalanced, stray double quote
7047         character.
7048
7049 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7050             Chris January  <chris.january@arm.com>
7051             Daniel Everett  <daniel.everett@arm.com>
7052             Nick Forrington  <nick.forrington@arm.com>
7053             Richard Bunt  <richard.bunt@arm.com>
7054
7055         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7056         of depth when printing anonymous structs or unions.
7057         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7058         Don't print either the top-level value, or the children if the
7059         max-depth is exceeded.
7060         (ppscm_print_children): When printing the key of a map, allow one
7061         extra level of depth.
7062         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7063         print either the top-level value, or the children if the max-depth
7064         is exceeded.
7065         (print_children): When printing the key of a map, allow one extra
7066         level of depth.
7067         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7068         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7069         (user_print_options): Initialise max_depth field.
7070         (val_print_scalar_or_string_type_p): New function.
7071         (val_print): Check to see if the max depth has been reached.
7072         (val_print_check_max_depth): Define new function.
7073         (show_print_max_depth): New function.
7074         (_initialize_valprint): Add 'print max-depth' option.
7075         * valprint.h (struct value_print_options) <max_depth>: New field.
7076         (val_print_check_max_depth): Declare new function.
7077         * NEWS: Document new feature.
7078
7079 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7080
7081         * ada-lang.c (ada_language_defn): Initialise new field.
7082         * c-lang.c (c_is_string_type_p): New function.
7083         (c_language_defn): Initialise new field.
7084         (cplus_language_defn): Initialise new field.
7085         (asm_language_defn): Initialise new field.
7086         (minimal_language_defn): Initialise new field.
7087         * c-lang.h (c_is_string_type_p): Declare new function.
7088         * d-lang.c (d_language_defn): Initialise new field.
7089         * f-lang.c (f_is_string_type_p): New function.
7090         (f_language_defn): Initialise new field.
7091         * go-lang.c (go_is_string_type_p): New function.
7092         (go_language_defn): Initialise new field.
7093         * language.c (default_is_string_type_p): New function.
7094         (unknown_language_defn): Initialise new field.
7095         (auto_language_defn): Initialise new field.
7096         * language.h (struct language_defn) <la_is_string_type_p>: New
7097         member variable.
7098         (default_is_string_type_p): Declare new function.
7099         * m2-lang.c (m2_language_defn): Initialise new field.
7100         * objc-lang.c (objc_language_defn): Initialise new field.
7101         * opencl-lang.c (opencl_language_defn): Initialise new field.
7102         * p-lang.c (pascal_is_string_type_p): New function.
7103         (pascal_language_defn): Initialise new field.
7104         * rust-lang.c (rust_is_string_type_p): New function.
7105         (rust_language_defn): Initialise new field.
7106
7107 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7108
7109         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7110         New field.
7111         * ada-lang.c (ada_language_defn): Initialise new field.
7112         * c-lang.c (c_language_defn): Likewise.
7113         (cplus_language_defn): Likewise.
7114         (asm_language_defn): Likewise.
7115         (minimal_language_defn): Likewise.
7116         * d-lang.c (d_language_defn): Likewise.
7117         * f-lang.c (f_language_defn): Likewise.
7118         * go-lang.c (go_language_defn): Likewise.
7119         * language.c (unknown_language_defn): Likewise.
7120         (auto_language_defn): Likewise.
7121         * m2-lang.c (m2_language_defn): Likewise.
7122         * objc-lang.c (objc_language_defn): Likewise.
7123         * opencl-lang.c (opencl_language_defn): Likewise.
7124         * p-lang.c (pascal_language_defn): Likewise.
7125         * rust-lang.c (rust_language_defn): Likewise.
7126
7127 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7128
7129         * ada-lang.c (ada_is_character_type): Change return type to bool.
7130         (ada_is_string_type): Likewise.
7131         * ada-lang.h (ada_is_character_type): Update declaration
7132         (ada_is_string_type): Likewise.
7133
7134 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7135
7136         Support style in 'frame|thread apply'
7137
7138         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7139         * record.c (record_start, record_stop): Update callers of
7140         execute_command_to_string with false.
7141         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7142         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7143         methods.
7144         (class string_file): New constructor with term_out parameter.
7145         Override methods term_out and can_emit_style_escape.  New member
7146         term_out.
7147         (class stdio_file): Override can_emit_style_escape.
7148         (class tee_file): Override term_out and can_emit_style_escape.
7149         * utils.h (can_emit_style_escape): Remove.
7150         * utils.c (can_emit_style_escape): Likewise.
7151         Update all callers of can_emit_style_escape (SOMESTREAM) to
7152         SOMESTREAM->can_emit_style_escape.
7153         * source-cache.c (source_cache::get_source_lines): Likewise.
7154         * stack.c (frame_apply_command_count): Call execute_command_to_string
7155         passing the term_out characteristic of the current gdb_stdout.
7156         * thread.c (thr_try_catch_cmd): Likewise.
7157         * top.c (execute_command_to_string): pass term_out parameter
7158         to construct the string_file for the command output.
7159         * ui-file.c (term_cli_styling): New function (most code moved
7160         from utils.c can_emit_style_escape).
7161         (string_file::string_file, string_file::can_emit_style_escape,
7162         stdio_file::can_emit_style_escape, tee_file::term_out,
7163         tee_file::can_emit_style_escape): New functions.
7164
7165 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7166
7167         * NEWS: Mention the new set|show may-call-functions.
7168         * infcall.c (may_call_functions_p): New variable.
7169         (show_may_call_functions_p): New function.
7170         (call_function_by_hand_dummy): Throws an error if not
7171         may-call-functions.
7172         (_initialize_infcall): Call add_setshow_boolean_cmd for
7173         may-call-functions.
7174
7175 2019-04-25  Keith Seitz  <keiths@redhat.com>
7176
7177         PR c++/24367
7178         * cp-support.c (inspect_type): Don't attempt substitutions
7179         of symbol with the same name.
7180
7181 2019-04-25  Tom Tromey  <tromey@adacore.com>
7182
7183         PR gdb/24475:
7184         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7185         static.
7186
7187 2019-04-25  Tom Tromey  <tromey@adacore.com>
7188
7189         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7190         rvalue reference.
7191         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7192         (gdb_xml_parser::parse): Use std::move.
7193         * python/python-internal.h (gdbpy_convert_exception): Take a const
7194         reference.
7195         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7196         std::move.
7197         * python/py-utils.c (gdbpy_convert_exception): Take a const
7198         reference.
7199         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7200         Use std::move.
7201         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7202         Use std::move.
7203         * mi/mi-main.c (mi_print_exception): Take a const reference.
7204         * main.c (handle_command_errors): Take a const reference.
7205         * linespec.c (parse_linespec): Use std::move.
7206         * infcall.c (run_inferior_call): Use std::move.
7207         (call_function_by_hand_dummy): Use std::move.
7208         * exec.c (try_open_exec_file): Use std::move.
7209         * exceptions.h (exception_print, exception_fprintf)
7210         (exception_print_same): Update.
7211         * exceptions.c (print_exception, exception_print)
7212         (exception_fprintf, exception_print_same): Change parameters to
7213         const reference.
7214         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7215         * common/new-op.c: Use std::move.
7216         * common/common-exceptions.h (struct gdb_exception): Add move
7217         constructor.
7218         (struct gdb_exception_error, struct gdb_exception_quit, struct
7219         gdb_quit_bad_alloc): Change constructor to move constructor.
7220         (throw_exception): Change parameter to rvalue reference.
7221         * common/common-exceptions.c (throw_exception): Take rvalue
7222         reference.
7223         * cli/cli-interp.c (safe_execute_command): Use std::move.
7224         * breakpoint.c (insert_bp_location, location_to_sals): Use
7225         std::move.
7226
7227 2019-04-25  Tom Tromey  <tromey@adacore.com>
7228
7229         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7230         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7231         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7232         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7233         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7234         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7235         guile/scm-value.c: Use unpack.
7236         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7237         gdbscm_gdb_exception.
7238         (gdbscm_throw_gdb_exception): Likewise.
7239         (struct gdbscm_gdb_exception): New.
7240         (unpack): New function.
7241         (gdbscm_wrap): Use unpack.
7242
7243 2019-04-25  Tom Tromey  <tromey@adacore.com>
7244
7245         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7246         (gdb_rl_callback_handler): Use std::move.
7247         * common/common-exceptions.h (struct gdb_exception): Add move
7248         assignment operator.
7249         (throw_exception_sjlj): Change "exception" to const reference.
7250         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7251         (throw_exception_sjlj): Change "exception" to const reference.
7252
7253 2019-04-25  Tom Tromey  <tromey@adacore.com>
7254
7255         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7256         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7257         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7258         Update.
7259         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7260         Update.
7261         * mi/mi-interp.c (mi_interp::exec): Update.
7262         * linespec.c (parse_linespec): Update.
7263         * infcall.c (run_inferior_call): Update.
7264         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7265         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7266         (gdbscm_lookup_global_symbol): Update.
7267         * guile/scm-param.c (gdbscm_parameter_value): Update.
7268         * guile/scm-frame.c (gdbscm_frame_read_register)
7269         (gdbscm_frame_read_var): Update.
7270         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7271         * exec.c (try_open_exec_file): Update.
7272         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7273         (gdb_rl_callback_handler): Update.
7274         * common/common-exceptions.h (exception_none): Don't declare.
7275         * common/common-exceptions.c (exception_none): Don't define.
7276         (struct catcher) <exception>: Update.
7277         * cli/cli-interp.c (safe_execute_command): Update.
7278         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7279
7280 2019-04-25  Ali Tamur  <tamur@google.com>
7281
7282         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7283         (read_attribute_value): Likewise.
7284         (dwarf2_read_addr_index): Update comment.
7285         (read_str_index): Add DW_FORM_strx.
7286         (dwarf2_string_attr): Likewise.
7287         (dwarf2_const_value_attr): Likewise.
7288         (dump_die_shallow): Likewise.
7289         (dwarf2_fetch_constant_bytes): Likewise.
7290         (skip_form_bytes): Likewise.
7291         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7292
7293 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7294
7295         PR corefiles/11608
7296         PR corefiles/18187
7297         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7298         OFFSET.  Verify if current mapping contains an ELF header.
7299         (linux_find_memory_regions_full): Adjust call to
7300         dump_mapping_p.
7301
7302 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7303             Kang Li <kanglictf@gmail.com>
7304
7305         PR gdb/21600
7306
7307         * dwarf2-frame.c (read_initial_length): Be consistent about using
7308         unsigned representation of length.
7309         (decode_frame_entry_1): Likewise.  Check for wraparound of
7310         end pointer as well as buffer overflow.
7311
7312 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7313
7314         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7315         "vq".
7316
7317 2019-04-24  Tom Tromey  <tromey@adacore.com>
7318
7319         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7320
7321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7322
7323         * s12z-tdep.c (s12z_unwind_pc): Delete.
7324         (s12z_unwind_sp): Delete.
7325         (s12z_gdbarch_init): Don't register deleted functions with
7326         gdbarch.
7327
7328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7329
7330         * rl78-tdep.c (rl78_unwind_sp): Delete.
7331         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7332
7333 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7334
7335         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7336         (xstormy16_unwind_pc): Delete.
7337         (xstormy16_dummy_id): Delete.
7338         (xstormy16_gdbarch_init): Don't register deleted functions with
7339         gdbarch.
7340
7341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7342
7343         * vax-tdep.c (vax_unwind_pc): Delete.
7344         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7345
7346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7347
7348         * v850-tdep.c (v850_unwind_sp): Delete.
7349         (v850_unwind_pc): Delete.
7350         (v850_dummy_id): Delete.
7351         (v850_gdbarch_init): Don't register deleted functions with
7352         gdbarch.
7353
7354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7355
7356         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7357         (tilegx_unwind_pc): Delete.
7358         (tilegx_unwind_dummy_id): Delete.
7359         (tilegx_gdbarch_init): Don't register deleted functions with
7360         gdbarch.
7361
7362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7363
7364         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7365         (tic6x_dummy_id): Delete.
7366         (tic6x_gdbarch_init): Don't register deleted functions with
7367         gdbarch.
7368
7369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7370
7371         * sparc-tdep.c (sparc_unwind_pc): Delete.
7372         (sparc32_gdbarch_init): Don't register deleted function with
7373         gdbarch.
7374
7375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7376
7377         * sh-tdep.c (sh_unwind_sp): Delete.
7378         (sh_unwind_pc): Delete.
7379         (sh_dummy_id): Delete.
7380         (sh_gdbarch_init): Don't register deleted functions with
7381         gdbarch.
7382
7383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7384
7385         * score-tdep.c (score_unwind_sp): Delete.
7386         (score_unwind_pc): Delete.
7387         (score_dummy_id): Delete.
7388         (score_gdbarch_init): Don't register deleted functions with
7389         gdbarch.
7390
7391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7392
7393         * rx-tdep.c (rx_unwind_pc): Delete.
7394         (rx_unwind_sp): Delete.
7395         (rx_dummy_id): Delete.
7396         (rx_gdbarch_init): Don't register deleted functions with
7397         gdbarch.  Update comment.
7398
7399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7400
7401         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7402         (rs6000_dummy_id): Delete.
7403         (rs6000_gdbarch_init): Don't register deleted functions with
7404         gdbarch.
7405
7406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7407
7408         * or1k-tdep.c (or1k_dummy_id): Delete.
7409         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7410
7411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7412
7413         * nios2-tdep.c (nios2_dummy_id): Delete.
7414         (nios2_unwind_sp): Delete.
7415         (nios2_gdbarch_init): Don't register deleted functions with
7416         gdbarch.
7417
7418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7419
7420         * nds32-tdep.c (nds32_dummy_id): Delete.
7421         (nds32_unwind_pc): Delete.
7422         (nds32_unwind_sp): Delete.
7423         (nds32_gdbarch_init): Don't register deleted functions with
7424         gdbarch.
7425
7426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7427
7428         * msp430-tdep.c (msp430_unwind_pc): Delete.
7429         (msp430_unwind_sp): Delete.
7430         (msp430_dummy_id): Delete.
7431         (msp430_gdbarch_init): Don't register deleted functions with
7432         gdbarch.
7433
7434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7435
7436         * moxie-tdep.c (moxie_unwind_sp): Delete.
7437         (moxie_unwind_pc): Delete.
7438         (moxie_dummy_id): Delete.
7439         (moxie_gdbarch_init): Don't register deleted functions with
7440         gdbarch.
7441
7442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7443
7444         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7445         (mn10300_unwind_pc): Delete.
7446         (mn10300_unwind_sp): Delete.
7447         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7448         mn10300_unwind_sp.
7449         (mn10300_frame_unwind_init): Don't register deleted functions with
7450         gdbarch.
7451
7452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7453
7454         * mep-tdep.c (mep_unwind_pc): Delete.
7455         (mep_unwind_sp): Delete.
7456         (mep_dummy_id): Delete.
7457         (mep_gdbarch_init): Don't register deleted functions with
7458         gdbarch.
7459
7460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7461
7462         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7463         (m68hc11_unwind_sp): Delete.
7464         (m68hc11_gdbarch_init): Don't register deleted functions with
7465         gdbarch.
7466
7467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7468
7469         * m32r-tdep.c (m32r_unwind_sp): Delete.
7470         (m32r_unwind_pc): Delete.
7471         (m32r_dummy_id): Delete.
7472         (m32r_gdbarch_init): Don't register deleted functions with
7473         gdbarch.
7474
7475 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7476
7477         * m32c-tdep.c (m32c_unwind_pc): Delete.
7478         (m32c_unwind_sp): Delete.
7479         (m32c_dummy_id): Delete.
7480         (m32c_gdbarch_init): Don't register deleted functions with
7481         gdbarch.
7482
7483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7484
7485         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7486         (lm32_unwind_pc): Delete.
7487         (lm32_dummy_id): Delete.
7488         (lm32_gdbarch_init): Don't register deleted functions with
7489         gdbarch.
7490
7491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7492
7493         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7494         (iq2000_unwind_pc): Delete.
7495         (iq2000_dummy_id): Delete.
7496         (iq2000_gdbarch_init): Don't register deleted functions with
7497         gdbarch.
7498
7499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7500
7501         * nds32-tdep.c (nds32_type_align): Delete.
7502         (nds32_push_dummy_call): Use type_align instead.
7503
7504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7505
7506         * arm-tdep.c (arm_type_align): Only handle vector override case.
7507         (arm_push_dummy_call): Use type_align.
7508         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7509
7510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7511
7512         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7513         case.
7514         (pass_on_stack): Use type_align.
7515         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7516         function.
7517
7518 2019-04-23  Tom Tromey  <tromey@adacore.com>
7519
7520         * dwarf2read.c (line_header::file_name_at): Remove unused
7521         overload.
7522
7523 2019-04-23  Tom de Vries  <tdevries@suse.de>
7524
7525         PR gdb/24438
7526         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7527         invocation.
7528
7529
7530 2019-03-27  Ali Tamur  <tamur@google.com>
7531
7532         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7533         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7534         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7535         (dwarf_expr_context::get_addr_index): Likewise
7536         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7537         (symbol_needs_eval_context::get_addr_index): Likewise
7538         (disassemble_dwarf_expression): Add DW_OP_addrx
7539         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7540         (read_cutu_die_from_dwo): Update comment
7541         (skip_one_die): Add DW_FORM_addrx
7542         (read_attribute_value): Likewise
7543         (var_decode_location): Add DW_OP_addrx
7544         (dwarf2_const_value_attr): Add DW_FORM_addrx
7545         (dump_die_shallow): Likewise
7546         (dwarf2_fetch_constant_bytes): Likewise
7547         (decode_locdesc): Add DW_OP_addrx
7548         (skip_form_bytes): Add DW_FORM_addrx
7549
7550 2019-04-22  Ali Tamur  <tamur@google.com>
7551
7552         * MAINTAINERS (Write After Approval): Add self.
7553
7554 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7555
7556         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7557         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7558         (open_symbol_file_object): Likewise.
7559         (svr4_default_sos): Add info parameter.
7560         (svr4_read_so_list): Likewise.
7561         (svr4_current_sos_direct): Adjust functions calls to pass down
7562         info.
7563         (svr4_current_sos_1): Add info parameter.
7564         (svr4_current_sos): Call get_svr4_info, pass info down to
7565         svr4_current_sos_1.
7566         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7567         get_svr4_info.
7568         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7569         get_svr4_info.
7570         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7571         to get_svr4_info.
7572         (probes_table_remove_objfile_probes): Likewise.
7573         (register_solib_event_probe): Add info parameter.
7574         (solist_update_incremental): Pass info parameter down to
7575         svr4_read_so_list.
7576         (disable_probes_interface): Add info parameter.
7577         (svr4_handle_solib_event): Pass current_program_space to
7578         get_svr4_info.  Adjust disable_probes_interface cleanup.
7579         (svr4_create_probe_breakpoints): Add info parameter, pass it
7580         down to register_solib_event_probe.
7581         (svr4_create_solib_event_breakpoints): Add info parameter,
7582         pass it down to svr4_create_probe_breakpoints.
7583         (enable_break): Pass info down to
7584         svr4_create_solib_event_breakpoints.
7585         (svr4_solib_create_inferior_hook): Pass current_program_space to
7586         get_svr4_info.
7587         (svr4_clear_solib): Likewise.
7588
7589 2019-04-22  Pedro Alves  <palves@redhat.com>
7590
7591         * solib-svr4.c (svr4_free_objfile_observer): New.
7592         (probe_and_action::objfile): New field.
7593         (probes_table_htab_remove_objfile_probes)
7594         (probes_table_remove_objfile_probes): New functions.
7595         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7596         in the new probe_and_action.  Don't store the probe in 'lookup'.
7597         (svr4_create_probe_breakpoints): Pass objfile to
7598         register_solib_event_probe.
7599         (_initialize_svr4_solib): Register a free_objfile observer.
7600
7601 2019-04-19  Tom Tromey  <tom@tromey.com>
7602
7603         * common/queue.h: Remove.
7604
7605 2019-04-19  Tom Tromey  <tom@tromey.com>
7606
7607         * event-loop.c: Don't include "common/queue.h".
7608
7609 2019-04-19  Tom Tromey  <tom@tromey.com>
7610
7611         * remote.c (remote_target): Use delete.
7612         * remote-notif.h: Include <list>, not "common/queue.h".
7613         (notif_client_p): Remove typedef.
7614         (remote_notif_state): Add constructor, destructor, initializer.
7615         <notif_queue>: Now a std::list.
7616         (remote_notif_state_xfree): Don't declare.
7617         * remote-notif.c (remote_notif_process, handle_notification)
7618         (remote_notif_state_allocate): Update.
7619         (~remote_notif_state): Rename from remote_notif_state_xfree.
7620
7621 2019-04-19  Tom Tromey  <tom@tromey.com>
7622
7623         * symfile.c (reread_symbols): Update.
7624         * objfiles.c (objfile_register_static_link)
7625         (objfile_lookup_static_link): Update
7626         (~objfile) Don't delete static_links.
7627         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7628
7629 2019-04-19  Tom Tromey  <tom@tromey.com>
7630
7631         * type-stack.h (struct type_stack) <insert>: Constify string.
7632         * type-stack.c (type_stack::insert): Constify string.
7633         * gdbtypes.h (lookup_template_type): Update.
7634         (address_space_name_to_int): Update.
7635         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7636         const.
7637         (lookup_template_type): Make name const.
7638         * c-exp.y: Update rules.
7639         (lex_one_token, classify_name, classify_inner_name)
7640         (c_print_token): Update.
7641         * p-exp.y: Update rules.
7642         (yylex): Update.
7643         * f-exp.y: Update rules.
7644         (yylex): Update.
7645         * d-exp.y: Update rules.
7646         (lex_one_token, classify_name, classify_inner_name): Update.
7647         * parse.c (write_dollar_variable, copy_name): Return std::string.
7648         * parser-defs.h (copy_name): Change return type.
7649         * m2-exp.y: Update rules.
7650         (yylex): Update.
7651         * go-exp.y (lex_one_token): Update.
7652         Update rules.
7653         (classify_unsafe_function, classify_packaged_name)
7654         (classify_name, yylex): Update.
7655
7656 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7657
7658         * configure.ac: add --enable-source-highlight switch.
7659         * configure: Regenerate.
7660         * top.c (print_gdb_version): plumb --enable-source-highlight
7661         status to "show configuration".
7662
7663 2019-04-19  Tom Tromey  <tromey@adacore.com>
7664
7665         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7666         Check ADA_TYPE_P.
7667         (empty_record, ada_template_to_fixed_record_type_1)
7668         (template_to_static_fixed_type)
7669         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7670         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7671         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7672         macros.
7673
7674 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7675
7676         PR symtab/24423:
7677         * source.c (print_source_lines_base): Advance "iter" when a
7678         control character is seen.
7679
7680 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7681
7682         * inferior.h (struct infcall_suspend_state_deleter):
7683         Catch exception in destructor to avoid crash.
7684
7685 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7686
7687         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7688         close to the add_com "shell".
7689
7690 2019-04-18  Tom Tromey  <tromey@adacore.com>
7691
7692         * process-stratum-target.h (class process_stratum_target)
7693         <stratum>: Add "final".
7694
7695 2019-04-17  Tom Tromey  <tromey@adacore.com>
7696
7697         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7698         against nullptr before use.
7699
7700 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7701
7702         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7703
7704 2019-04-17  Jim Wilson  <jimw@sifive.com>
7705             Andrew Burgess  <andrew.burgess@embecosm.com>
7706
7707         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7708         code read might fail, assume 4-byte breakpoint in that case.
7709
7710 2019-04-15  Leszek Swirski  <leszeks@google.com>
7711
7712         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7713         rather than a hand-rolled POD check when checking for forced MEMORY
7714         classification.
7715
7716 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7717
7718         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7719         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7720         function.
7721         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7722         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7723         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7724         declaration.
7725
7726 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7727
7728         * aarch64-linux-nat.c
7729         (aarch64_linux_nat_target::thread_architecture): Add override.
7730         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7731         each VQ.
7732
7733 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7734
7735         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7736
7737 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7738
7739         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7740         target types of size 96-bits, add some additional comments, and
7741         check that the builtin type we found was the correct size.
7742
7743 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7744
7745         * utils.c (prompt_for_continue): Don't restore the styling at the
7746         end, as applied_style has the wrong value.  This fixes styling in
7747         long lists of file names that are interrupted by the "Continue?"
7748         prompt.
7749
7750 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7751
7752         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7753         * c-lang.c (c_language_defn): Likewise.
7754         (cplus_language_defn): Likewise.
7755         (asm_language_defn): Likewise.
7756         (minimal_language_defn): Likewise.
7757         * d-lang.c (d_language_defn): Likewise.
7758         * f-lang.c (f_language_defn): Likewise.
7759         * go-lang.c (go_language_defn): Likewise.
7760         * language.c (unknown_language_defn): Likewise.
7761         (auto_language_defn): Likewise.
7762         * language.h (struct language_defn): Remove la_magic field.
7763         (LANG_MAGIC): Delete.
7764         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7765         * objc-lang.c (objc_language_defn): Likewise.
7766         * opencl-lang.c (opencl_language_defn): Likewise.
7767         * p-lang.c (pascal_language_defn): Likewise.
7768         * rust-lang.c (rust_language_defn): Likewise.
7769
7770 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7771
7772         * riscv-tdep.c (riscv_type_align): New function.
7773         (riscv_type_alignment): Delete.
7774         (riscv_arg_location): Use 'type_align'.
7775         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7776
7777 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7778
7779         * gdbtypes.c (type_align): A struct with no non-static fields also
7780         has alignment of 1.
7781
7782 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7783
7784         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7785         component to 0.
7786         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7787         member.
7788         (riscv_struct_info::analyse): New implementation using new
7789         analyse_inner member function.
7790         (riscv_struct_info::field_offset): New member function.
7791         (riscv_struct_info::m_offsets): New member variable.
7792         (riscv_struct_info::analyse_inner): New private member function,
7793         takes the old implementation of riscv_struct_info::analyse but
7794         extended to track field offsets.
7795         (riscv_call_arg_struct): Update the struct folding special cases
7796         to handle cases where empty C++ structs, which are non-zero
7797         length, are found.
7798         (riscv_arg_location): Initialise the length of each location, a
7799         non-zero length now indicates the location is in use.
7800         (riscv_push_dummy_call): Allow for the first location having a
7801         non-zero offset when setting up arguments.
7802         (riscv_return_value): Likewise, but for return values.
7803
7804 2019-04-11  Tom Tromey  <tromey@adacore.com>
7805
7806         * utils.c (internal_vproblem): Make "msg" const.
7807
7808 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7809
7810         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7811         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7812         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7813         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7814
7815 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7816
7817         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7818         function.
7819         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7820         of amd64_collect_native_gregset.
7821         (amd64_linux_nat_target::store_registers): Likewise.
7822
7823 2019-04-10  Tom Tromey  <tom@tromey.com>
7824
7825         * symtab.c (lookup_global_symbol_from_objfile)
7826         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7827         * objfiles.h (class separate_debug_iterator): New.
7828         (class separate_debug_range): New.
7829         (struct objfile) <separate_debug_objfiles>: New method.
7830         (objfile_separate_debug_iterate): Don't declare.
7831         * objfiles.c (separate_debug_iterator::operator++): Rename from
7832         objfile_separate_debug_iterate.
7833         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7834         iterator.
7835         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7836         iterator.
7837
7838 2019-04-10  Tom Tromey  <tom@tromey.com>
7839
7840         * symfile.c (reread_symbols): Remove old comment.
7841         * objfiles.c (free_all_objfiles): Fix a typo.
7842
7843 2019-04-10  Tom Tromey  <tom@tromey.com>
7844
7845         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7846         * minsyms.c (lookup_minimal_symbol): Use foreach.
7847         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7848         (lookup_minimal_symbol_solib_trampoline): Likewise.
7849         * symfile.c (reread_symbols): Use foreach.
7850
7851 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7852             Tom Tromey  <tromey@adacore.com>
7853
7854         PR rust/24414:
7855         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7856         (rust_lex_int_test): Change "value" to be LONGEST.
7857         (rust_lex_tests): Add test for long integer literal.
7858
7859 2019-04-09  Tom Tromey  <tromey@adacore.com>
7860
7861         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7862         to bool.
7863         (extended_remote_target::attach): Update.
7864         (remote_target::remote_notice_new_inferior): Update.
7865         (remote_target::add_current_inferior_and_thread): Update.
7866         * inferior.c (exit_inferior_1): Use "false".
7867         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7868
7869 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7870
7871         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7872         the "start" command.
7873
7874 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7875
7876         * python/py-inferior.c (infpy_thread_from_thread_handle):
7877         Adjust comments to reflect renaming of thread_from_thread_handle
7878         to thread_from_handle.  Adjust keywords.  Fix type error message.
7879         (inferior_object_methods): Add thread_from_handle.  Retain
7880         thread_from_thread_handle, but mark it as deprecated.
7881
7882 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7883
7884         * gdbthread.h (find_thread_by_handle): Revise declaration.
7885         * thread.c (find_thread_by_handle): Likewise.  Adjust
7886         implementation too.
7887         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7888         support for buffer objects as handles.
7889
7890 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7891
7892         * python/py-infthread.c (thpy_thread_handle): New function.
7893         (thread_object_methods): Register thpy_thread_handle.
7894
7895 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7896
7897         * gdbthread.h (thread_to_thread_handle): Declare.
7898         * thread.c (gdbtypes.h): Include.
7899         (thread_to_thread_handle): New function.
7900
7901         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7902         (target_thread_info_to_thread_handle): Declare.
7903         * target.c (target_thread_info_to_thread_handle): New function.
7904         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7905         * target-delegates.c: Regenerate.
7906
7907         * linux-thread-db.c (class thread_db_target): Add method
7908         thread_info_to_thread_handle.
7909         (thread_db_target::thread_info_to_thread_handle): Define.
7910         * remote.c (class remote_target): Add new method
7911         thread_info_to_thread_handle.
7912         (remote_target::thread_info_to_thread_handle): Define.
7913
7914 2019-04-08  Pedro Alves  <palves@redhat.com>
7915
7916         * common/common-exceptions.c (throw_exception): Don't create
7917         named object to throw; throw directly.
7918         (throw_it): Likewise.  Don't initialize gdb_exception::message
7919         here, with new; pass FMT and AP to the ctor instead.
7920         * common/common-exceptions.h: Include <string>.
7921         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7922         const char *, va_list)): New ctor.  Use std::make_shared.
7923         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7924         errors)): Delete.
7925         (gdb_exception_error::gdb_exception_error(enum errors, const char
7926         *, va_list)): New.
7927         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7928         Add assertion.
7929         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7930         errors)): Delete.
7931         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7932         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7933         Add assertion.
7934
7935 2019-04-08  Tom Tromey  <tom@tromey.com>
7936
7937         * valops.c (value_rtti_indirect_type): Replace throw_exception
7938         with throw.
7939         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7940         with throw.
7941         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7942         throw.
7943         * target.c (target_translate_tls_address): Replace throw_exception
7944         with throw.
7945         * stack.c (frame_apply_command_count): Replace throw_exception
7946         with throw.
7947         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7948         throw.
7949         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7950         with throw.
7951         * rs6000-tdep.c (rs6000_frame_cache)
7952         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7953         * remote.c: Replace throw_exception with throw.
7954         * record-full.c (record_full_message, record_full_wait_1)
7955         (record_full_restore): Replace throw_exception with throw.
7956         * record-btrace.c:
7957         (get_thread_current_frame_id, record_btrace_start_replaying)
7958         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7959         (cmd_record_btrace_start): Replace throw_exception with throw.
7960         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7961         throw.
7962         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7963         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7964         * linespec.c:
7965         (find_linespec_symbols): Replace throw_exception with throw.
7966         * infrun.c (displaced_step_prepare, resume): Replace
7967         throw_exception with throw.
7968         * infcmd.c (post_create_inferior): Replace throw_exception with
7969         throw.
7970         * inf-loop.c (inferior_event_handler): Replace throw_exception
7971         with throw.
7972         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7973         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7974         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7975         (get_prev_frame_always, get_frame_pc_if_available)
7976         (get_frame_address_in_block_if_available, get_frame_language):
7977         Replace throw_exception with throw.
7978         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7979         throw_exception with throw.
7980         * eval.c (fetch_subexp_value, evaluate_var_value)
7981         (evaluate_funcall, evaluate_subexp_standard): Replace
7982         throw_exception with throw.
7983         * dwarf2loc.c (call_site_find_chain)
7984         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7985         Replace throw_exception with throw.
7986         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7987         with throw.
7988         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7989         throw.
7990         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7991         * completer.c (complete_line_internal): Replace throw_exception
7992         with throw.
7993         * compile/compile-object-run.c (compile_object_run): Replace
7994         throw_exception with throw.
7995         * cli/cli-script.c (process_next_line): Replace throw_exception
7996         with throw.
7997         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7998         (btrace_enable, btrace_maint_update_pt_packets): Replace
7999         throw_exception with throw.
8000         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8001         throw_exception with throw.
8002         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8003         throw_exception with throw.
8004         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8005         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8006         * aarch64-tdep.c (aarch64_make_prologue_cache)
8007         (aarch64_make_stub_cache): Replace throw_exception with throw.
8008
8009 2019-04-08  Tom Tromey  <tom@tromey.com>
8010
8011         * common/common-exceptions.c (throw_exception): Rename from
8012         throw_exception_cxx.  Remove old copy.  Make argument const.
8013         (throw_it): Create and throw exception objects directly.
8014         * common/common-exceptions.h (throw_exception): Make argument
8015         const.
8016         (struct gdb_exception_error): Add constructor.
8017         (struct gdb_exception_quit): Add constructor.
8018
8019 2019-04-08  Tom Tromey  <tom@tromey.com>
8020
8021         * common/common-exceptions.h (exception_rethrow): Don't declare.
8022         (TRY_SJLJ): Update comment.
8023         (TRY, CATCH, END_CATCH): Remove.
8024         * common/common-exceptions.c (exception_rethrow): Remove.
8025
8026 2019-04-08  Tom Tromey  <tom@tromey.com>
8027
8028         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8029         Remove.
8030         (gdb_exception_error): Rename from
8031         gdb_exception_RETURN_MASK_ERROR.
8032         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8033         (gdb_quit_bad_alloc): Update.
8034         * aarch64-tdep.c: Update.
8035         * ada-lang.c: Update.
8036         * ada-typeprint.c: Update.
8037         * ada-valprint.c: Update.
8038         * amd64-tdep.c: Update.
8039         * arch-utils.c: Update.
8040         * break-catch-throw.c: Update.
8041         * breakpoint.c: Update.
8042         * btrace.c: Update.
8043         * c-varobj.c: Update.
8044         * cli/cli-cmds.c: Update.
8045         * cli/cli-interp.c: Update.
8046         * cli/cli-script.c: Update.
8047         * common/common-exceptions.c: Update.
8048         * common/new-op.c: Update.
8049         * common/selftest.c: Update.
8050         * compile/compile-c-symbols.c: Update.
8051         * compile/compile-cplus-symbols.c: Update.
8052         * compile/compile-object-load.c: Update.
8053         * compile/compile-object-run.c: Update.
8054         * completer.c: Update.
8055         * corelow.c: Update.
8056         * cp-abi.c: Update.
8057         * cp-support.c: Update.
8058         * cp-valprint.c: Update.
8059         * darwin-nat.c: Update.
8060         * disasm-selftests.c: Update.
8061         * dtrace-probe.c: Update.
8062         * dwarf-index-cache.c: Update.
8063         * dwarf-index-write.c: Update.
8064         * dwarf2-frame-tailcall.c: Update.
8065         * dwarf2-frame.c: Update.
8066         * dwarf2loc.c: Update.
8067         * dwarf2read.c: Update.
8068         * eval.c: Update.
8069         * event-loop.c: Update.
8070         * event-top.c: Update.
8071         * exec.c: Update.
8072         * f-valprint.c: Update.
8073         * fbsd-tdep.c: Update.
8074         * frame-unwind.c: Update.
8075         * frame.c: Update.
8076         * gdbtypes.c: Update.
8077         * gnu-v3-abi.c: Update.
8078         * guile/guile-internal.h: Update.
8079         * guile/scm-block.c: Update.
8080         * guile/scm-breakpoint.c: Update.
8081         * guile/scm-cmd.c: Update.
8082         * guile/scm-disasm.c: Update.
8083         * guile/scm-frame.c: Update.
8084         * guile/scm-lazy-string.c: Update.
8085         * guile/scm-math.c: Update.
8086         * guile/scm-param.c: Update.
8087         * guile/scm-ports.c: Update.
8088         * guile/scm-pretty-print.c: Update.
8089         * guile/scm-symbol.c: Update.
8090         * guile/scm-symtab.c: Update.
8091         * guile/scm-type.c: Update.
8092         * guile/scm-value.c: Update.
8093         * i386-linux-tdep.c: Update.
8094         * i386-tdep.c: Update.
8095         * inf-loop.c: Update.
8096         * infcall.c: Update.
8097         * infcmd.c: Update.
8098         * infrun.c: Update.
8099         * jit.c: Update.
8100         * language.c: Update.
8101         * linespec.c: Update.
8102         * linux-fork.c: Update.
8103         * linux-nat.c: Update.
8104         * linux-tdep.c: Update.
8105         * linux-thread-db.c: Update.
8106         * main.c: Update.
8107         * mi/mi-cmd-break.c: Update.
8108         * mi/mi-cmd-stack.c: Update.
8109         * mi/mi-interp.c: Update.
8110         * mi/mi-main.c: Update.
8111         * objc-lang.c: Update.
8112         * p-valprint.c: Update.
8113         * parse.c: Update.
8114         * ppc-linux-tdep.c: Update.
8115         * printcmd.c: Update.
8116         * python/py-arch.c: Update.
8117         * python/py-breakpoint.c: Update.
8118         * python/py-cmd.c: Update.
8119         * python/py-finishbreakpoint.c: Update.
8120         * python/py-frame.c: Update.
8121         * python/py-framefilter.c: Update.
8122         * python/py-gdb-readline.c: Update.
8123         * python/py-inferior.c: Update.
8124         * python/py-infthread.c: Update.
8125         * python/py-lazy-string.c: Update.
8126         * python/py-linetable.c: Update.
8127         * python/py-objfile.c: Update.
8128         * python/py-param.c: Update.
8129         * python/py-prettyprint.c: Update.
8130         * python/py-progspace.c: Update.
8131         * python/py-record-btrace.c: Update.
8132         * python/py-record.c: Update.
8133         * python/py-symbol.c: Update.
8134         * python/py-type.c: Update.
8135         * python/py-unwind.c: Update.
8136         * python/py-utils.c: Update.
8137         * python/py-value.c: Update.
8138         * python/python.c: Update.
8139         * record-btrace.c: Update.
8140         * record-full.c: Update.
8141         * remote-fileio.c: Update.
8142         * remote.c: Update.
8143         * riscv-tdep.c: Update.
8144         * rs6000-aix-tdep.c: Update.
8145         * rs6000-tdep.c: Update.
8146         * rust-exp.y: Update.
8147         * rust-lang.c: Update.
8148         * s390-tdep.c: Update.
8149         * selftest-arch.c: Update.
8150         * solib-dsbt.c: Update.
8151         * solib-frv.c: Update.
8152         * solib-spu.c: Update.
8153         * solib-svr4.c: Update.
8154         * solib.c: Update.
8155         * sparc64-linux-tdep.c: Update.
8156         * stack.c: Update.
8157         * symfile-mem.c: Update.
8158         * symmisc.c: Update.
8159         * target.c: Update.
8160         * thread.c: Update.
8161         * top.c: Update.
8162         * tracefile-tfile.c: Update.
8163         * tui/tui.c: Update.
8164         * typeprint.c: Update.
8165         * unittests/cli-utils-selftests.c: Update.
8166         * unittests/parse-connection-spec-selftests.c: Update.
8167         * valops.c: Update.
8168         * valprint.c: Update.
8169         * value.c: Update.
8170         * varobj.c: Update.
8171         * windows-nat.c: Update.
8172         * x86-linux-nat.c: Update.
8173         * xml-support.c: Update.
8174
8175 2019-04-08  Tom Tromey  <tom@tromey.com>
8176
8177         * xml-support.c: Use C++ exception handling.
8178         * x86-linux-nat.c: Use C++ exception handling.
8179         * windows-nat.c: Use C++ exception handling.
8180         * varobj.c: Use C++ exception handling.
8181         * value.c: Use C++ exception handling.
8182         * valprint.c: Use C++ exception handling.
8183         * valops.c: Use C++ exception handling.
8184         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8185         handling.
8186         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8187         * typeprint.c: Use C++ exception handling.
8188         * tui/tui.c: Use C++ exception handling.
8189         * tracefile-tfile.c: Use C++ exception handling.
8190         * top.c: Use C++ exception handling.
8191         * thread.c: Use C++ exception handling.
8192         * target.c: Use C++ exception handling.
8193         * symmisc.c: Use C++ exception handling.
8194         * symfile-mem.c: Use C++ exception handling.
8195         * stack.c: Use C++ exception handling.
8196         * sparc64-linux-tdep.c: Use C++ exception handling.
8197         * solib.c: Use C++ exception handling.
8198         * solib-svr4.c: Use C++ exception handling.
8199         * solib-spu.c: Use C++ exception handling.
8200         * solib-frv.c: Use C++ exception handling.
8201         * solib-dsbt.c: Use C++ exception handling.
8202         * selftest-arch.c: Use C++ exception handling.
8203         * s390-tdep.c: Use C++ exception handling.
8204         * rust-lang.c: Use C++ exception handling.
8205         * rust-exp.y: Use C++ exception handling.
8206         * rs6000-tdep.c: Use C++ exception handling.
8207         * rs6000-aix-tdep.c: Use C++ exception handling.
8208         * riscv-tdep.c: Use C++ exception handling.
8209         * remote.c: Use C++ exception handling.
8210         * remote-fileio.c: Use C++ exception handling.
8211         * record-full.c: Use C++ exception handling.
8212         * record-btrace.c: Use C++ exception handling.
8213         * python/python.c: Use C++ exception handling.
8214         * python/py-value.c: Use C++ exception handling.
8215         * python/py-utils.c: Use C++ exception handling.
8216         * python/py-unwind.c: Use C++ exception handling.
8217         * python/py-type.c: Use C++ exception handling.
8218         * python/py-symbol.c: Use C++ exception handling.
8219         * python/py-record.c: Use C++ exception handling.
8220         * python/py-record-btrace.c: Use C++ exception handling.
8221         * python/py-progspace.c: Use C++ exception handling.
8222         * python/py-prettyprint.c: Use C++ exception handling.
8223         * python/py-param.c: Use C++ exception handling.
8224         * python/py-objfile.c: Use C++ exception handling.
8225         * python/py-linetable.c: Use C++ exception handling.
8226         * python/py-lazy-string.c: Use C++ exception handling.
8227         * python/py-infthread.c: Use C++ exception handling.
8228         * python/py-inferior.c: Use C++ exception handling.
8229         * python/py-gdb-readline.c: Use C++ exception handling.
8230         * python/py-framefilter.c: Use C++ exception handling.
8231         * python/py-frame.c: Use C++ exception handling.
8232         * python/py-finishbreakpoint.c: Use C++ exception handling.
8233         * python/py-cmd.c: Use C++ exception handling.
8234         * python/py-breakpoint.c: Use C++ exception handling.
8235         * python/py-arch.c: Use C++ exception handling.
8236         * printcmd.c: Use C++ exception handling.
8237         * ppc-linux-tdep.c: Use C++ exception handling.
8238         * parse.c: Use C++ exception handling.
8239         * p-valprint.c: Use C++ exception handling.
8240         * objc-lang.c: Use C++ exception handling.
8241         * mi/mi-main.c: Use C++ exception handling.
8242         * mi/mi-interp.c: Use C++ exception handling.
8243         * mi/mi-cmd-stack.c: Use C++ exception handling.
8244         * mi/mi-cmd-break.c: Use C++ exception handling.
8245         * main.c: Use C++ exception handling.
8246         * linux-thread-db.c: Use C++ exception handling.
8247         * linux-tdep.c: Use C++ exception handling.
8248         * linux-nat.c: Use C++ exception handling.
8249         * linux-fork.c: Use C++ exception handling.
8250         * linespec.c: Use C++ exception handling.
8251         * language.c: Use C++ exception handling.
8252         * jit.c: Use C++ exception handling.
8253         * infrun.c: Use C++ exception handling.
8254         * infcmd.c: Use C++ exception handling.
8255         * infcall.c: Use C++ exception handling.
8256         * inf-loop.c: Use C++ exception handling.
8257         * i386-tdep.c: Use C++ exception handling.
8258         * i386-linux-tdep.c: Use C++ exception handling.
8259         * guile/scm-value.c: Use C++ exception handling.
8260         * guile/scm-type.c: Use C++ exception handling.
8261         * guile/scm-symtab.c: Use C++ exception handling.
8262         * guile/scm-symbol.c: Use C++ exception handling.
8263         * guile/scm-pretty-print.c: Use C++ exception handling.
8264         * guile/scm-ports.c: Use C++ exception handling.
8265         * guile/scm-param.c: Use C++ exception handling.
8266         * guile/scm-math.c: Use C++ exception handling.
8267         * guile/scm-lazy-string.c: Use C++ exception handling.
8268         * guile/scm-frame.c: Use C++ exception handling.
8269         * guile/scm-disasm.c: Use C++ exception handling.
8270         * guile/scm-cmd.c: Use C++ exception handling.
8271         * guile/scm-breakpoint.c: Use C++ exception handling.
8272         * guile/scm-block.c: Use C++ exception handling.
8273         * guile/guile-internal.h: Use C++ exception handling.
8274         * gnu-v3-abi.c: Use C++ exception handling.
8275         * gdbtypes.c: Use C++ exception handling.
8276         * frame.c: Use C++ exception handling.
8277         * frame-unwind.c: Use C++ exception handling.
8278         * fbsd-tdep.c: Use C++ exception handling.
8279         * f-valprint.c: Use C++ exception handling.
8280         * exec.c: Use C++ exception handling.
8281         * event-top.c: Use C++ exception handling.
8282         * event-loop.c: Use C++ exception handling.
8283         * eval.c: Use C++ exception handling.
8284         * dwarf2read.c: Use C++ exception handling.
8285         * dwarf2loc.c: Use C++ exception handling.
8286         * dwarf2-frame.c: Use C++ exception handling.
8287         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8288         * dwarf-index-write.c: Use C++ exception handling.
8289         * dwarf-index-cache.c: Use C++ exception handling.
8290         * dtrace-probe.c: Use C++ exception handling.
8291         * disasm-selftests.c: Use C++ exception handling.
8292         * darwin-nat.c: Use C++ exception handling.
8293         * cp-valprint.c: Use C++ exception handling.
8294         * cp-support.c: Use C++ exception handling.
8295         * cp-abi.c: Use C++ exception handling.
8296         * corelow.c: Use C++ exception handling.
8297         * completer.c: Use C++ exception handling.
8298         * compile/compile-object-run.c: Use C++ exception handling.
8299         * compile/compile-object-load.c: Use C++ exception handling.
8300         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8301         * compile/compile-c-symbols.c: Use C++ exception handling.
8302         * common/selftest.c: Use C++ exception handling.
8303         * common/new-op.c: Use C++ exception handling.
8304         * cli/cli-script.c: Use C++ exception handling.
8305         * cli/cli-interp.c: Use C++ exception handling.
8306         * cli/cli-cmds.c: Use C++ exception handling.
8307         * c-varobj.c: Use C++ exception handling.
8308         * btrace.c: Use C++ exception handling.
8309         * breakpoint.c: Use C++ exception handling.
8310         * break-catch-throw.c: Use C++ exception handling.
8311         * arch-utils.c: Use C++ exception handling.
8312         * amd64-tdep.c: Use C++ exception handling.
8313         * ada-valprint.c: Use C++ exception handling.
8314         * ada-typeprint.c: Use C++ exception handling.
8315         * ada-lang.c: Use C++ exception handling.
8316         * aarch64-tdep.c: Use C++ exception handling.
8317
8318 2019-04-08  Tom Tromey  <tom@tromey.com>
8319
8320         * xml-support.c (gdb_xml_parser::parse): Update.
8321         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8322         * value.c (show_convenience): Update.
8323         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8324         (test_parse_flags_qcs): Update.
8325         * thread.c (thr_try_catch_cmd): Update.
8326         * target.c (target_translate_tls_address): Update.
8327         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8328         (info_frame_command_core, frame_apply_command_count): Update.
8329         * rust-exp.y (rust_lex_exception_test): Update.
8330         * riscv-tdep.c (riscv_print_one_register_info): Update.
8331         * remote.c (remote_target::enable_btrace): Update.
8332         * record-btrace.c (record_btrace_enable_warn): Update.
8333         * python/py-utils.c (gdbpy_convert_exception): Update.
8334         * printcmd.c (do_one_display, print_variable_and_value): Update.
8335         * mi/mi-main.c (mi_print_exception): Update.
8336         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8337         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8338         * linux-nat.c (linux_nat_target::attach): Update.
8339         * linux-fork.c (class scoped_switch_fork_info): Update.
8340         * infrun.c (displaced_step_prepare): Update.
8341         * infcall.c (call_function_by_hand_dummy): Update.
8342         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8343         * gnu-v3-abi.c (print_one_vtable): Update.
8344         * frame.c (get_prev_frame_always): Update.
8345         * f-valprint.c (info_common_command_for_block): Update.
8346         * exec.c (try_open_exec_file): Update.
8347         * exceptions.c (print_exception, exception_print)
8348         (exception_fprintf, exception_print_same): Update.
8349         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8350         * dwarf-index-cache.c (index_cache::store)
8351         (index_cache::lookup_gdb_index): Update.
8352         * darwin-nat.c (maybe_cache_shell): Update.
8353         * cp-valprint.c (cp_print_value_fields): Update.
8354         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8355         (gcc_cplus_symbol_address): Update.
8356         * compile/compile-c-symbols.c (gcc_convert_symbol)
8357         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8358         * common/selftest.c: Update.
8359         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8360         a std::string.
8361         (exception_try_scope_entry, exception_try_scope_exit): Don't
8362         declare.
8363         (struct exception_try_scope): Remove.
8364         (TRY): Don't use exception_try_scope.
8365         (struct gdb_exception): Add constructor, operator=.
8366         <what>: New method.
8367         (struct gdb_exception_RETURN_MASK_ALL)
8368         (struct gdb_exception_RETURN_MASK_ERROR)
8369         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8370         (struct gdb_quit_bad_alloc): Update.
8371         * common/common-exceptions.c (exception_none): Change
8372         initializer.
8373         (struct catcher) <state, exception>: Initialize inline.
8374         <prev>: Remove member.
8375         (current_catcher): Remove.
8376         (catchers): New global.
8377         (exceptions_state_mc_init): Simplify.
8378         (catcher_pop): Remove.
8379         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8380         (try_scope_depth, exception_try_scope_entry)
8381         (exception_try_scope_exit): Remove.
8382         (throw_exception_sjlj): Update.
8383         (exception_messages, exception_messages_size): Remove.
8384         (throw_it): Simplify.
8385         (gdb_exception_sliced_copy): Remove.
8386         (throw_exception_cxx): Update.
8387         * cli/cli-script.c (script_from_file): Update.
8388         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8389         Update.
8390         * ada-valprint.c (ada_val_print): Update.
8391         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8392         (create_excep_cond_exprs): Update.
8393
8394 2019-04-08  Tom Tromey  <tom@tromey.com>
8395
8396         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8397         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8398         (TRY, CATCH, END_CATCH): Remove some definitions.
8399         * common/common-exceptions.c: Don't use GDB_XCPT.
8400         (catcher_list_size): Remove.
8401         (throw_exception, throw_it): Simplify.
8402
8403 2019-04-05  Tom Tromey  <tom@tromey.com>
8404
8405         Revert the header-sorting patch.
8406         * ft32-tdep.c: Revert.
8407         * frv-tdep.c: Revert.
8408         * frv-linux-tdep.c: Revert.
8409         * frame.c: Revert.
8410         * frame-unwind.c: Revert.
8411         * frame-base.c: Revert.
8412         * fork-child.c: Revert.
8413         * findvar.c: Revert.
8414         * findcmd.c: Revert.
8415         * filesystem.c: Revert.
8416         * filename-seen-cache.h: Revert.
8417         * filename-seen-cache.c: Revert.
8418         * fbsd-tdep.c: Revert.
8419         * fbsd-nat.h: Revert.
8420         * fbsd-nat.c: Revert.
8421         * f-valprint.c: Revert.
8422         * f-typeprint.c: Revert.
8423         * f-lang.c: Revert.
8424         * extension.h: Revert.
8425         * extension.c: Revert.
8426         * extension-priv.h: Revert.
8427         * expprint.c: Revert.
8428         * exec.h: Revert.
8429         * exec.c: Revert.
8430         * exceptions.c: Revert.
8431         * event-top.c: Revert.
8432         * event-loop.c: Revert.
8433         * eval.c: Revert.
8434         * elfread.c: Revert.
8435         * dwarf2read.h: Revert.
8436         * dwarf2read.c: Revert.
8437         * dwarf2loc.c: Revert.
8438         * dwarf2expr.h: Revert.
8439         * dwarf2expr.c: Revert.
8440         * dwarf2-frame.c: Revert.
8441         * dwarf2-frame-tailcall.c: Revert.
8442         * dwarf-index-write.h: Revert.
8443         * dwarf-index-write.c: Revert.
8444         * dwarf-index-common.c: Revert.
8445         * dwarf-index-cache.h: Revert.
8446         * dwarf-index-cache.c: Revert.
8447         * dummy-frame.c: Revert.
8448         * dtrace-probe.c: Revert.
8449         * disasm.h: Revert.
8450         * disasm.c: Revert.
8451         * disasm-selftests.c: Revert.
8452         * dictionary.c: Revert.
8453         * dicos-tdep.c: Revert.
8454         * demangle.c: Revert.
8455         * dcache.h: Revert.
8456         * dcache.c: Revert.
8457         * darwin-nat.h: Revert.
8458         * darwin-nat.c: Revert.
8459         * darwin-nat-info.c: Revert.
8460         * d-valprint.c: Revert.
8461         * d-namespace.c: Revert.
8462         * d-lang.c: Revert.
8463         * ctf.c: Revert.
8464         * csky-tdep.c: Revert.
8465         * csky-linux-tdep.c: Revert.
8466         * cris-tdep.c: Revert.
8467         * cris-linux-tdep.c: Revert.
8468         * cp-valprint.c: Revert.
8469         * cp-support.c: Revert.
8470         * cp-namespace.c: Revert.
8471         * cp-abi.c: Revert.
8472         * corelow.c: Revert.
8473         * corefile.c: Revert.
8474         * continuations.c: Revert.
8475         * completer.h: Revert.
8476         * completer.c: Revert.
8477         * complaints.c: Revert.
8478         * coffread.c: Revert.
8479         * coff-pe-read.c: Revert.
8480         * cli-out.h: Revert.
8481         * cli-out.c: Revert.
8482         * charset.c: Revert.
8483         * c-varobj.c: Revert.
8484         * c-valprint.c: Revert.
8485         * c-typeprint.c: Revert.
8486         * c-lang.c: Revert.
8487         * buildsym.c: Revert.
8488         * buildsym-legacy.c: Revert.
8489         * build-id.h: Revert.
8490         * build-id.c: Revert.
8491         * btrace.c: Revert.
8492         * bsd-uthread.c: Revert.
8493         * breakpoint.h: Revert.
8494         * breakpoint.c: Revert.
8495         * break-catch-throw.c: Revert.
8496         * break-catch-syscall.c: Revert.
8497         * break-catch-sig.c: Revert.
8498         * blockframe.c: Revert.
8499         * block.c: Revert.
8500         * bfin-tdep.c: Revert.
8501         * bfin-linux-tdep.c: Revert.
8502         * bfd-target.c: Revert.
8503         * bcache.c: Revert.
8504         * ax-general.c: Revert.
8505         * ax-gdb.h: Revert.
8506         * ax-gdb.c: Revert.
8507         * avr-tdep.c: Revert.
8508         * auxv.c: Revert.
8509         * auto-load.c: Revert.
8510         * arm-wince-tdep.c: Revert.
8511         * arm-tdep.c: Revert.
8512         * arm-symbian-tdep.c: Revert.
8513         * arm-pikeos-tdep.c: Revert.
8514         * arm-obsd-tdep.c: Revert.
8515         * arm-nbsd-tdep.c: Revert.
8516         * arm-nbsd-nat.c: Revert.
8517         * arm-linux-tdep.c: Revert.
8518         * arm-linux-nat.c: Revert.
8519         * arm-fbsd-tdep.c: Revert.
8520         * arm-fbsd-nat.c: Revert.
8521         * arm-bsd-tdep.c: Revert.
8522         * arch-utils.c: Revert.
8523         * arc-tdep.c: Revert.
8524         * arc-newlib-tdep.c: Revert.
8525         * annotate.h: Revert.
8526         * annotate.c: Revert.
8527         * amd64-windows-tdep.c: Revert.
8528         * amd64-windows-nat.c: Revert.
8529         * amd64-tdep.c: Revert.
8530         * amd64-sol2-tdep.c: Revert.
8531         * amd64-obsd-tdep.c: Revert.
8532         * amd64-obsd-nat.c: Revert.
8533         * amd64-nbsd-tdep.c: Revert.
8534         * amd64-nbsd-nat.c: Revert.
8535         * amd64-nat.c: Revert.
8536         * amd64-linux-tdep.c: Revert.
8537         * amd64-linux-nat.c: Revert.
8538         * amd64-fbsd-tdep.c: Revert.
8539         * amd64-fbsd-nat.c: Revert.
8540         * amd64-dicos-tdep.c: Revert.
8541         * amd64-darwin-tdep.c: Revert.
8542         * amd64-bsd-nat.c: Revert.
8543         * alpha-tdep.c: Revert.
8544         * alpha-obsd-tdep.c: Revert.
8545         * alpha-nbsd-tdep.c: Revert.
8546         * alpha-mdebug-tdep.c: Revert.
8547         * alpha-linux-tdep.c: Revert.
8548         * alpha-linux-nat.c: Revert.
8549         * alpha-bsd-tdep.c: Revert.
8550         * alpha-bsd-nat.c: Revert.
8551         * aix-thread.c: Revert.
8552         * agent.c: Revert.
8553         * addrmap.c: Revert.
8554         * ada-varobj.c: Revert.
8555         * ada-valprint.c: Revert.
8556         * ada-typeprint.c: Revert.
8557         * ada-tasks.c: Revert.
8558         * ada-lang.c: Revert.
8559         * aarch64-tdep.c: Revert.
8560         * aarch64-ravenscar-thread.c: Revert.
8561         * aarch64-newlib-tdep.c: Revert.
8562         * aarch64-linux-tdep.c: Revert.
8563         * aarch64-linux-nat.c: Revert.
8564         * aarch64-fbsd-tdep.c: Revert.
8565         * aarch64-fbsd-nat.c: Revert.
8566         * aarch32-linux-nat.c: Revert.
8567
8568 2019-04-05  Tom Tromey  <tom@tromey.com>
8569
8570         * ft32-tdep.c: Sort headers.
8571         * frv-tdep.c: Sort headers.
8572         * frv-linux-tdep.c: Sort headers.
8573         * frame.c: Sort headers.
8574         * frame-unwind.c: Sort headers.
8575         * frame-base.c: Sort headers.
8576         * fork-child.c: Sort headers.
8577         * findvar.c: Sort headers.
8578         * findcmd.c: Sort headers.
8579         * filesystem.c: Sort headers.
8580         * filename-seen-cache.h: Sort headers.
8581         * filename-seen-cache.c: Sort headers.
8582         * fbsd-tdep.c: Sort headers.
8583         * fbsd-nat.h: Sort headers.
8584         * fbsd-nat.c: Sort headers.
8585         * f-valprint.c: Sort headers.
8586         * f-typeprint.c: Sort headers.
8587         * f-lang.c: Sort headers.
8588         * extension.h: Sort headers.
8589         * extension.c: Sort headers.
8590         * extension-priv.h: Sort headers.
8591         * expprint.c: Sort headers.
8592         * exec.h: Sort headers.
8593         * exec.c: Sort headers.
8594         * exceptions.c: Sort headers.
8595         * event-top.c: Sort headers.
8596         * event-loop.c: Sort headers.
8597         * eval.c: Sort headers.
8598         * elfread.c: Sort headers.
8599         * dwarf2read.h: Sort headers.
8600         * dwarf2read.c: Sort headers.
8601         * dwarf2loc.c: Sort headers.
8602         * dwarf2expr.h: Sort headers.
8603         * dwarf2expr.c: Sort headers.
8604         * dwarf2-frame.c: Sort headers.
8605         * dwarf2-frame-tailcall.c: Sort headers.
8606         * dwarf-index-write.h: Sort headers.
8607         * dwarf-index-write.c: Sort headers.
8608         * dwarf-index-common.c: Sort headers.
8609         * dwarf-index-cache.h: Sort headers.
8610         * dwarf-index-cache.c: Sort headers.
8611         * dummy-frame.c: Sort headers.
8612         * dtrace-probe.c: Sort headers.
8613         * disasm.h: Sort headers.
8614         * disasm.c: Sort headers.
8615         * disasm-selftests.c: Sort headers.
8616         * dictionary.c: Sort headers.
8617         * dicos-tdep.c: Sort headers.
8618         * demangle.c: Sort headers.
8619         * dcache.h: Sort headers.
8620         * dcache.c: Sort headers.
8621         * darwin-nat.h: Sort headers.
8622         * darwin-nat.c: Sort headers.
8623         * darwin-nat-info.c: Sort headers.
8624         * d-valprint.c: Sort headers.
8625         * d-namespace.c: Sort headers.
8626         * d-lang.c: Sort headers.
8627         * ctf.c: Sort headers.
8628         * csky-tdep.c: Sort headers.
8629         * csky-linux-tdep.c: Sort headers.
8630         * cris-tdep.c: Sort headers.
8631         * cris-linux-tdep.c: Sort headers.
8632         * cp-valprint.c: Sort headers.
8633         * cp-support.c: Sort headers.
8634         * cp-namespace.c: Sort headers.
8635         * cp-abi.c: Sort headers.
8636         * corelow.c: Sort headers.
8637         * corefile.c: Sort headers.
8638         * continuations.c: Sort headers.
8639         * completer.h: Sort headers.
8640         * completer.c: Sort headers.
8641         * complaints.c: Sort headers.
8642         * coffread.c: Sort headers.
8643         * coff-pe-read.c: Sort headers.
8644         * cli-out.h: Sort headers.
8645         * cli-out.c: Sort headers.
8646         * charset.c: Sort headers.
8647         * c-varobj.c: Sort headers.
8648         * c-valprint.c: Sort headers.
8649         * c-typeprint.c: Sort headers.
8650         * c-lang.c: Sort headers.
8651         * buildsym.c: Sort headers.
8652         * buildsym-legacy.c: Sort headers.
8653         * build-id.h: Sort headers.
8654         * build-id.c: Sort headers.
8655         * btrace.c: Sort headers.
8656         * bsd-uthread.c: Sort headers.
8657         * breakpoint.h: Sort headers.
8658         * breakpoint.c: Sort headers.
8659         * break-catch-throw.c: Sort headers.
8660         * break-catch-syscall.c: Sort headers.
8661         * break-catch-sig.c: Sort headers.
8662         * blockframe.c: Sort headers.
8663         * block.c: Sort headers.
8664         * bfin-tdep.c: Sort headers.
8665         * bfin-linux-tdep.c: Sort headers.
8666         * bfd-target.c: Sort headers.
8667         * bcache.c: Sort headers.
8668         * ax-general.c: Sort headers.
8669         * ax-gdb.h: Sort headers.
8670         * ax-gdb.c: Sort headers.
8671         * avr-tdep.c: Sort headers.
8672         * auxv.c: Sort headers.
8673         * auto-load.c: Sort headers.
8674         * arm-wince-tdep.c: Sort headers.
8675         * arm-tdep.c: Sort headers.
8676         * arm-symbian-tdep.c: Sort headers.
8677         * arm-pikeos-tdep.c: Sort headers.
8678         * arm-obsd-tdep.c: Sort headers.
8679         * arm-nbsd-tdep.c: Sort headers.
8680         * arm-nbsd-nat.c: Sort headers.
8681         * arm-linux-tdep.c: Sort headers.
8682         * arm-linux-nat.c: Sort headers.
8683         * arm-fbsd-tdep.c: Sort headers.
8684         * arm-fbsd-nat.c: Sort headers.
8685         * arm-bsd-tdep.c: Sort headers.
8686         * arch-utils.c: Sort headers.
8687         * arc-tdep.c: Sort headers.
8688         * arc-newlib-tdep.c: Sort headers.
8689         * annotate.h: Sort headers.
8690         * annotate.c: Sort headers.
8691         * amd64-windows-tdep.c: Sort headers.
8692         * amd64-windows-nat.c: Sort headers.
8693         * amd64-tdep.c: Sort headers.
8694         * amd64-sol2-tdep.c: Sort headers.
8695         * amd64-obsd-tdep.c: Sort headers.
8696         * amd64-obsd-nat.c: Sort headers.
8697         * amd64-nbsd-tdep.c: Sort headers.
8698         * amd64-nbsd-nat.c: Sort headers.
8699         * amd64-nat.c: Sort headers.
8700         * amd64-linux-tdep.c: Sort headers.
8701         * amd64-linux-nat.c: Sort headers.
8702         * amd64-fbsd-tdep.c: Sort headers.
8703         * amd64-fbsd-nat.c: Sort headers.
8704         * amd64-dicos-tdep.c: Sort headers.
8705         * amd64-darwin-tdep.c: Sort headers.
8706         * amd64-bsd-nat.c: Sort headers.
8707         * alpha-tdep.c: Sort headers.
8708         * alpha-obsd-tdep.c: Sort headers.
8709         * alpha-nbsd-tdep.c: Sort headers.
8710         * alpha-mdebug-tdep.c: Sort headers.
8711         * alpha-linux-tdep.c: Sort headers.
8712         * alpha-linux-nat.c: Sort headers.
8713         * alpha-bsd-tdep.c: Sort headers.
8714         * alpha-bsd-nat.c: Sort headers.
8715         * aix-thread.c: Sort headers.
8716         * agent.c: Sort headers.
8717         * addrmap.c: Sort headers.
8718         * ada-varobj.c: Sort headers.
8719         * ada-valprint.c: Sort headers.
8720         * ada-typeprint.c: Sort headers.
8721         * ada-tasks.c: Sort headers.
8722         * ada-lang.c: Sort headers.
8723         * aarch64-tdep.c: Sort headers.
8724         * aarch64-ravenscar-thread.c: Sort headers.
8725         * aarch64-newlib-tdep.c: Sort headers.
8726         * aarch64-linux-tdep.c: Sort headers.
8727         * aarch64-linux-nat.c: Sort headers.
8728         * aarch64-fbsd-tdep.c: Sort headers.
8729         * aarch64-fbsd-nat.c: Sort headers.
8730         * aarch32-linux-nat.c: Sort headers.
8731
8732 2019-04-04  Tom Tromey  <tom@tromey.com>
8733
8734         * varobj.c (varobj_create): Update.
8735         * rust-exp.y (struct rust_parser) <update_innermost_block,
8736         lookup_symbol>: New methods.
8737         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8738         Rename.
8739         (rust_parser::rust_lookup_type)
8740         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8741         * printcmd.c (display_command, do_one_display): Update.
8742         * parser-defs.h (struct parser_state) <parser_state>: Add
8743         "tracker" parameter.
8744         (block_tracker): New member.
8745         (class innermost_block_tracker) <innermost_block_tracker>: Add
8746         "types" parameter.
8747         <reset>: Remove method.
8748         (innermost_block): Don't declare.
8749         (null_post_parser): Update.
8750         * parse.c (innermost_block): Remove global.
8751         (write_dollar_variable): Update.
8752         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8753         Remove "tracker_types" parameter.
8754         (parse_expression): Add "tracker" parameter.
8755         (parse_expression_for_completion): Update.
8756         (null_post_parser): Add "tracker" parameter.
8757         * p-exp.y: Update rules.
8758         * m2-exp.y: Update rules.
8759         * language.h (struct language_defn) <la_post_parser>: Add
8760         "tracker" parameter.
8761         * go-exp.y: Update rules.
8762         * f-exp.y: Update rules.
8763         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8764         parameter.
8765         * d-exp.y: Update rules.
8766         * c-exp.y: Update rules.
8767         * breakpoint.c (set_breakpoint_condition): Create an
8768         innermost_block_tracker.
8769         (watch_command_1): Likewise.
8770         * ada-lang.c (resolve): Add "tracker" parameter.
8771         (resolve_subexp): Likewise.
8772         * ada-exp.y (write_var_from_sym): Update.
8773
8774 2019-04-04  Tom Tromey  <tom@tromey.com>
8775
8776         * type-stack.h: New file.
8777         * type-stack.c: New file.
8778         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8779         type-stack.h.
8780         (insert_into_type_stack, insert_type, push_type, push_type_int)
8781         (insert_type_address_space, pop_type, pop_type_int)
8782         (pop_typelist, pop_type_stack, append_type_stack)
8783         (push_type_stack, get_type_stack, push_typelist)
8784         (follow_type_instance_flags, follow_types): Don't declare.
8785         * parse.c (type_stack): Remove global.
8786         (parse_exp_in_context): Update.
8787         (insert_into_type_stack, insert_type, push_type, push_type_int)
8788         (insert_type_address_space, pop_type, pop_type_int)
8789         (pop_typelist, pop_type_stack, append_type_stack)
8790         (push_type_stack, get_type_stack, push_typelist)
8791         (follow_type_instance_flags, follow_types): Remove (moved to
8792         type-stack.c).
8793         * f-exp.y (type_stack): New global.
8794         Update rules.
8795         (push_kind_type, f_parse): Update.
8796         * d-exp.y (type_stack): New global.
8797         Update rules.
8798         (d_parse): Update.
8799         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8800         Update rules.
8801         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8802         (HFILES_NO_SRCDIR): Add type-stack.h.
8803
8804 2019-04-04  Tom Tromey  <tom@tromey.com>
8805
8806         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8807         (rust_parser::convert_ast_to_expression, rust_parse)
8808         (rust_lex_test_completion, rust_lex_tests): Update.
8809         * parser-defs.h (struct expr_completion_state): New.
8810         (struct parser_state) <parser_state>: Add completion parameter.
8811         <mark_struct_expression, mark_completion_tag>: New methods.
8812         <parse_completion, m_completion_state>: New members.
8813         (prefixify_expression, null_post_parser): Update.
8814         (mark_struct_expression, mark_completion_tag): Don't declare.
8815         * parse.c (parse_completion, expout_last_struct)
8816         (expout_tag_completion_type, expout_completion_name): Remove
8817         globals.
8818         (parser_state::mark_struct_expression)
8819         (parser_state::mark_completion_tag): Now methods.
8820         (prefixify_expression): Add last_struct parameter.
8821         (prefixify_subexp): Likewise.
8822         (parse_exp_1): Update.
8823         (parse_exp_in_context): Add cstate parameter.  Update.
8824         (parse_expression_for_completion): Create an
8825         expr_completion_state.
8826         (null_post_parser): Add "completion" parameter.
8827         * p-exp.y: Update rules.
8828         (yylex): Update.
8829         * language.h (struct language_defn) <la_post_parser>: Add
8830         "completing" parameter.
8831         * go-exp.y: Update rules.
8832         (lex_one_token): Update.
8833         * expression.h (parse_completion): Don't declare.
8834         * d-exp.y: Update rules.
8835         (lex_one_token): Update rules.
8836         * c-exp.y: Update rules.
8837         (lex_one_token): Update.
8838         * ada-lang.c (resolve): Add "parse_completion" parameter.
8839         (resolve_subexp): Likewise.
8840         (ada_resolve_function): Likewise.
8841
8842 2019-04-04  Tom Tromey  <tom@tromey.com>
8843
8844         * parser-defs.h (struct parser_state) <start_arglist,
8845         end_arglist>: New methods.
8846         <arglist_len, m_funcall_chain>: New members.
8847         (arglist_len, start_arglist, end_arglist): Don't declare.
8848         * parse.c (arglist_len, funcall_chain): Remove global.
8849         (start_arglist, end_arglist): Remove functions.
8850         (parse_exp_in_context): Update.
8851         * p-exp.y: Update rules.
8852         * m2-exp.y: Update rules.
8853         * go-exp.y: Update rules.
8854         * f-exp.y: Update rules.
8855         * d-exp.y: Update rules.
8856         * c-exp.y: Update rules.
8857
8858 2019-04-04  Tom Tromey  <tom@tromey.com>
8859
8860         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8861         lex_operator, push_back>: New methods.
8862         Update all rules.
8863         (rust_parser::lex_hex, lex_escape): Rename and update.
8864         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8865         (rust_parser::lex_operator): Rename and update.
8866         (rust_parser::lex_number, rustyylex, rustyyerror)
8867         (rust_lex_test_init, rust_lex_test_sequence)
8868         (rust_lex_test_push_back, rust_lex_tests): Update.
8869         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8870         parameter.
8871         <lexptr, prev_lexptr>: New members.
8872         (lexptr, prev_lexptr): Don't declare.
8873         * parse.c (lexptr, prev_lexptr): Remove globals.
8874         (parse_exp_in_context): Update.
8875         * p-exp.y (yylex, yyerror): Update.
8876         * m2-exp.y (parse_number, yylex, yyerror): Update.
8877         * go-exp.y (lex_one_token, yyerror): Update.
8878         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8879         * d-exp.y (lex_one_token, yyerror): Update.
8880         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8881         (lex_one_token, yyerror): Update.
8882         * ada-lex.l (YY_INPUT): Update.
8883         (rewind_to_char): Update.
8884         * ada-exp.y (yyerror): Update.
8885
8886 2019-04-04  Tom Tromey  <tom@tromey.com>
8887
8888         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8889         * parser-defs.h (struct parser_state) <parser_state>: Add new
8890         parameter.
8891         <comma_terminates>: New member.
8892         (comma_terminates): Don't declare global.
8893         * parse.c (comma_terminates): Remove global.
8894         (parse_exp_in_context): Update.
8895         * p-exp.y (yylex): Update.
8896         * m2-exp.y (yylex): Update.
8897         * go-exp.y (lex_one_token): Update.
8898         * f-exp.y (yylex): Update.
8899         * d-exp.y (lex_one_token): Update.
8900         * c-exp.y (lex_one_token): Update.
8901         * ada-lex.l: Update.
8902
8903 2019-04-04  Tom Tromey  <tom@tromey.com>
8904
8905         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8906         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8907         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8908         * parser-defs.h (paren_depth): Don't declare.
8909         * parse.c (paren_depth): Remove global.
8910         (parse_exp_in_context): Update.
8911         * p-exp.y (paren_depth): New global.
8912         (pascal_parse): Initialize it.
8913         * m2-exp.y (paren_depth): New global.
8914         (m2_parse): Initialize it.
8915         * go-exp.y (paren_depth): New global.
8916         (go_parse): Initialize it.
8917         * f-exp.y (paren_depth): New global.
8918         (f_parse): Initialize it.
8919         * d-exp.y (paren_depth): New global.
8920         (d_parse): Initialize it.
8921         * c-exp.y (paren_depth): New global.
8922         (c_parse): Initialize it.
8923         * ada-lex.l (paren_depth): New global.
8924         (lexer_init): Initialize it.
8925
8926 2019-04-04  Tom Tromey  <tom@tromey.com>
8927
8928         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8929         (rust_parser::convert_ast_to_type)
8930         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8931         * parser-defs.h (struct parser_state) <parser_state>: Add
8932         parameters.  Initialize new members.
8933         <expression_context_block, expression_context_pc>: New members.
8934         * parse.c (expression_context_block, expression_context_pc):
8935         Remove globals.
8936         (parse_exp_in_context): Update.
8937         * p-exp.y: Update all rules.
8938         (yylex): Update.
8939         * m2-exp.y: Update all rules.
8940         (yylex): Update.
8941         * go-exp.y (yylex): Update.
8942         * f-exp.y (yylex): Update.
8943         * d-exp.y: Update all rules.
8944         (yylex): Update.
8945         * c-exp.y: Update all rules.
8946         (lex_one_token, classify_name, yylex, c_parse): Update.
8947         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8948
8949 2019-04-04  Tom Tromey  <tom@tromey.com>
8950
8951         * gdbarch.h, gdbarch.c: Rebuild.
8952         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8953         * stap-probe.h:
8954         (struct stap_parse_info): Replace "parser_state" with
8955         "expr_builder".
8956         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8957         (parser_state): New class.
8958         * parse.c (expr_builder): Rename.
8959         (expr_builder::release): Rename.
8960         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8961         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8962         (write_exp_elt_longcst, write_exp_elt_floatcst)
8963         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8964         (write_exp_string_vector, write_exp_bitstring)
8965         (write_exp_msymbol, mark_struct_expression)
8966         (write_dollar_variable)
8967         (insert_type_address_space, increase_expout_size): Replace
8968         "parser_state" with "expr_builder".
8969         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8970         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8971         "parser_state" with "expr_builder".
8972
8973 2019-04-04  Tom Tromey  <tom@tromey.com>
8974
8975         * rust-exp.y: Replace "parse_language" with method call.
8976         * p-exp.y:
8977         (yylex): Replace "parse_language" with method call.
8978         * m2-exp.y:
8979         (yylex): Replace "parse_language" with method call.
8980         * go-exp.y (classify_name): Replace "parse_language" with method
8981         call.
8982         * f-exp.y (yylex): Replace "parse_language" with method call.
8983         * d-exp.y (lex_one_token): Replace "parse_language" with method
8984         call.
8985         * c-exp.y:
8986         (lex_one_token, classify_name, yylex): Replace "parse_language"
8987         with method call.
8988         * ada-exp.y (find_primitive_type, type_char)
8989         (type_system_address): Replace "parse_language" with method call.
8990
8991 2019-04-04  Tom Tromey  <tom@tromey.com>
8992
8993         * rust-exp.y: Replace "parse_gdbarch" with method call.
8994         * parse.c (write_dollar_variable, insert_type_address_space):
8995         Replace "parse_gdbarch" with method call.
8996         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8997         call.
8998         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8999         call.
9000         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9001         "parse_gdbarch" with method call.
9002         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9003         with method call.
9004         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9005         "parse_gdbarch" with method call.
9006         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9007         "parse_gdbarch" with method call.
9008         * c-exp.y (parse_type, parse_number, classify_name): Replace
9009         "parse_gdbarch" with method call.
9010         * ada-lex.l: Replace "parse_gdbarch" with method call.
9011         * ada-exp.y (parse_type, find_primitive_type, type_char)
9012         (type_system_address): Replace "parse_gdbarch" with method call.
9013
9014 2019-04-04  Tom Tromey  <tom@tromey.com>
9015
9016         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9017         * stap-probe.c (stap_parse_argument): Update.
9018         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9019         initial_size parameter.
9020         * rust-exp.y (rust_lex_tests): Update.
9021         * parse.c (parser_state): Update.
9022         (parse_exp_in_context): Update.
9023         * parser-defs.h (struct parser_state) <parser_state>: Remove
9024         "initial_size" parameter.
9025
9026 2019-04-04  Tom Tromey  <tom@tromey.com>
9027
9028         * parser-defs.h (increase_expout_size): Don't declare.
9029         * parse.c (increase_expout_size): Now static.
9030
9031 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9032
9033         * gnu-nat.c (gnu_nat_target::wait): Fix
9034         target_waitstatus_to_string call.
9035
9036 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9037
9038         * eval.c (evaluate_subexp_standard): Handle internal functions
9039         during Fortran function call handling.
9040
9041 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9042
9043         * NEWS: Mention new internal functions.
9044         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9045         (read_base_type): Use dwarf2_init_complex_target_type.
9046         * value.c (creal_internal_fn): New function.
9047         (cimag_internal_fn): New function.
9048         (_initialize_values): Register new internal functions.
9049
9050 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9051
9052         * infrun.c (stop_all_threads): If debug_infrun, always
9053         trace the wait status after wait_one, using
9054         target_waitstatus_to_string and target_pid_to_str.
9055         (handle_inferior_event): Replace various trace of
9056         wait status kind by a single trace.
9057         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9058         wait status kind image by target_waitstatus_to_string.
9059         * target/waitstatus.c (target_waitstatus_to_string): Fix
9060         obsolete comment.
9061
9062 2019-04-01  Tom Tromey  <tromey@adacore.com>
9063
9064         PR symtab/23331:
9065         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9066
9067 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9068             Pedro Alves  <palves@redhat.com>
9069
9070         * top.c (quit_force): Call 'finalize_values'.
9071         * value.c (finalize_values): New function.
9072         * value.h (finalize_values): Declare.
9073
9074 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9075
9076         * NEWS: Announce $_gdb_major and $_gdb_minor.
9077
9078         * top.c (init_gdb_version_vars): New function.
9079         (gdb_init): Call init_gdb_version_vars.
9080
9081 2019-03-29  Tom Tromey  <tromey@adacore.com>
9082
9083         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9084         help text.  Remove dead code.
9085
9086 2019-03-29  Keith Seitz  <keiths@redhat.com>
9087
9088         From Siddhesh Poyarekar:
9089         * f-lang.h (f77_get_upperbound): Return LONGEST.
9090         (f77_get_lowerbound): Likewise.
9091         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9092         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9093         print them.
9094         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9095         plongest to format print it.
9096         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9097         (f77_get_upperbound): Likewise.
9098         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9099         LOWER_BOUND to LONGEST.
9100         (f77_create_arrayprint_offset_tbl): Likewise.
9101
9102 2019-03-29  Keith Seitz  <keiths@redhat.com>
9103
9104         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9105         %s/pulongest for TYPE_LENGTH instead of %d in format
9106         strings.
9107         * ada-typerint.c (ada_print_type): Likewise.
9108         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9109         * compile/compile-c-support.c (generate_register_struct): Likewise.
9110         * gdbtypes.c (recursive_dump_type): Likewise.
9111         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9112         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9113         instead of %d in format strings.
9114         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9115         to std::min to ULONGEST.
9116         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9117         instead of %d in format strings.
9118         * tracepoint.c (info_scope_command): Likewise.
9119         * typeprint.c (print_offset_data::update)
9120         (print_offset_data::finish): Likewise.
9121         * xtensa-tdep.c (xtensa_store_return_value)
9122         (xtensa_push_dummy_call): Likewise.
9123
9124 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9125
9126         * windows-nat.c (display_selector): Fixed format specifications
9127         for 64-bit Cygwin.
9128
9129 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9130
9131         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9132
9133 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9134
9135         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9136         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9137         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9138         (nios2_linux_init_abi): Install it.
9139
9140 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9141
9142         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9143
9144 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9145
9146         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9147
9148 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9149             Tom Tromey  <tromey@adacore.com>
9150
9151         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9152
9153 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9154
9155         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9156         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9157         method to compute the bounds of range types. Also print "[evaluated]"
9158         if the bounds' values come from a dynamic evaluation.
9159
9160 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9161
9162         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9163         whitespace when pretty printing is on.
9164
9165 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9166
9167         * ppc-linux-nat.c: Add include.
9168
9169 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9170
9171         * NEWS: Mention AArch64 Pointer Authentication.
9172
9173 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9174
9175         * arm-linux-nat.c: Add include.
9176
9177 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9178
9179         * source-cache.c (source_cache::get_source_lines): Re-read
9180         fullname after calling open_source_file.
9181
9182 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9183
9184         * NEWS: Mention TLS support for FreeBSD.
9185
9186 2019-03-25  Tom Tromey  <tromey@adacore.com>
9187
9188         * minsyms.c (BUNCH_SIZE): Update comment.
9189         (~minimal_symbol_reader): Remove old comment.
9190         (compact_minimal_symbols): Update comment.
9191         (minimal_symbol_reader::install): Remove old comment.  Update
9192         other comments.
9193
9194 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9195
9196         * s390-linux-nat.c: Add include.
9197
9198 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9199
9200         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9201         Call linux_get_hwcap.
9202         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9203         Likewise.
9204         (aarch64_linux_get_hwcap): Remove function.
9205         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9206         declaration.
9207         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9208         linux_get_hwcap.
9209         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9210         * linux-tdep.c (linux_get_hwcap): Add function.
9211         (linux_get_hwcap2): Likewise.
9212         * linux-tdep.h (linux_get_hwcap): Add declaration.
9213         (linux_get_hwcap2): Likewise.
9214         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9215         (ppc_linux_get_hwcap2): Likewise.
9216         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9217         linux_get_hwcap.
9218         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9219         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9220         (ppc_linux_nat_target::read_description): Likewise.
9221         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9222         * s390-linux-nat.c: Likewise.
9223         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9224
9225 2019-03-24  Tom Tromey  <tom@tromey.com>
9226
9227         * ada-lang.c (standard_lookup): Simplify initialization.
9228         (ada_lookup_symbol_nonlocal): Simplify return.
9229         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9230         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9231         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9232         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9233         initialization.
9234         * solib.c (solib_global_lookup): Simplify.
9235         * symtab.c (null_block_symbol): Remove.
9236         (symbol_cache_lookup): Simplify returns.
9237         (lookup_language_this): Simplify returns.
9238         (lookup_symbol_aux): Simplify return.
9239         (lookup_local_symbol): Simplify returns.
9240         (lookup_global_symbol_from_objfile): Simplify return.
9241         (lookup_symbol_in_objfile_symtabs)
9242         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9243         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9244         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9245         * cp-namespace.c (cp_lookup_bare_symbol)
9246         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9247         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9248         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9249         (cp_lookup_symbol_via_imports): Simplify initialization.
9250         (find_symbol_in_baseclass): Likewise.
9251         * symtab.h (null_block_symbol): Remove.
9252         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9253         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9254         (d_lookup_symbol_module): Likewise.
9255         (find_symbol_in_baseclass): Simplify initialization.
9256
9257 2019-03-24  Tom Tromey  <tom@tromey.com>
9258
9259         * expression.h: Don't include symtab.h.
9260         (struct block): Forward declare.
9261
9262 2019-03-24  Tom Tromey  <tom@tromey.com>
9263
9264         * c-exp.y (typebase): Remove casts.
9265         * gdbtypes.c (lookup_unsigned_typename, )
9266         (lookup_signed_typename): Remove cast.
9267         * eval.c (parse_to_comma_and_eval): Remove cast.
9268         * parse.c (write_dollar_variable): Remove cast.
9269         * block.h (struct block) <superblock>: Now const.
9270         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9271         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9272         (map_block): Make "block" const.
9273         * symfile.h (struct quick_symbol_functions)
9274         <map_matching_symbols>: Constify block argument to "callback".
9275         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9276         const.
9277         (find_pc_sect_compunit_symtab): Make "b" const.
9278         (find_symbol_at_address): Likewise.
9279         (search_symbols): Likewise.
9280         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9281         (dw2_debug_names_lookup_symbol): Likewise.
9282         (dw2_map_matching_symbols): Update.
9283         * p-valprint.c (pascal_val_print): Remove "block".
9284         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9285         (aux_add_nonlocal_symbols): Make "block" const.
9286         (resolve_subexp): Remove cast.
9287         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9288         const.
9289         (iterate_over_file_blocks): Likewise.
9290         * f-exp.y (%union) <bval>: Remove.
9291         * coffread.c (patch_opaque_types): Make "b" const.
9292         * spu-tdep.c (spu_catch_start): Make "block" const.
9293         * c-valprint.c (print_unpacked_pointer): Remove "block".
9294         * symmisc.c (dump_symtab_1): Make "b" const.
9295         (block_depth): Make "block" const.
9296         * d-exp.y (%union) <bval>: Remove.
9297         * cp-support.h (cp_lookup_rtti_type): Update.
9298         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9299         * psymtab.c (psym_lookup_symbol): Make "block" const.
9300         (maintenance_check_psymtabs): Make "b" const.
9301         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9302         (enumerate_locals, enumerate_args): Update.
9303         * python/py-symtab.c (stpy_global_block): Make "block" const.
9304         (stpy_static_block): Likewise.
9305         * inline-frame.c (block_starting_point_at): Make "new_block"
9306         const.
9307         * block.c (find_block_in_blockvector): Make return type const.
9308         (blockvector_for_pc_sect): Make "b" const.
9309         (find_block_in_blockvector): Make "b" const.
9310
9311 2019-03-23  Tom Tromey  <tom@tromey.com>
9312
9313         * varobj.c (varobj_create): Update.
9314         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9315         * printcmd.c (display_command, do_one_display): Don't reset
9316         innermost_block.
9317         * parser-defs.h (enum innermost_block_tracker_type): Move to
9318         expression.h.
9319         (innermost_block): Update comment.
9320         * parse.c (parse_exp_1): Add tracker_types parameter.
9321         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9322         tracker_types parameter.  Reset innermost_block.
9323         (parse_exp_in_context): Remove.
9324         (parse_expression_for_completion): Update.
9325         * objfiles.c (~objfile): Don't reset expression_context_block or
9326         innermost_block.
9327         * expression.h (enum innermost_block_tracker_type): Move from
9328         parser-defs.h.
9329         (parse_exp_1): Add tracker_types parameter.
9330         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9331         reset innermost_block.
9332
9333 2019-03-23  Tom Tromey  <tom@tromey.com>
9334
9335         * objfiles.h: Include bcache.h.
9336
9337 2019-03-23  Tom Tromey  <tom@tromey.com>
9338
9339         * linespec.c (get_current_search_block): Use
9340         scoped_restore_current_language.
9341         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9342
9343 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9344             Jiong Wang  <jiong.wang@arm.com>
9345
9346         * aarch64-linux-tdep.c
9347         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9348         section.
9349         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9350
9351 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9352             Jiong Wang  <jiong.wang@arm.com>
9353
9354         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9355         instructions.
9356         (aarch64_analyze_prologue_test): Add PACIASP test.
9357         (aarch64_prologue_prev_register): Unmask PC value.
9358
9359 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9360             Jiong Wang  <jiong.wang@arm.com>
9361
9362         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9363         (aarch64_dwarf2_prev_register): Unmask PC value.
9364         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9365         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9366         DW_CFA_AARCH64_negate_ra_state.
9367         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9368
9369 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9370             Jiong Wang  <jiong.wang@arm.com>
9371
9372         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9373         registers.
9374         (aarch64_pseudo_register_name): Likewise.
9375         (aarch64_pseudo_register_type): Likewise.
9376         (aarch64_pseudo_register_reggroup_p): Likewise.
9377         (aarch64_gdbarch_init): Add pauth registers.
9378         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9379         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9380         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9381         (struct gdbarch_tdep): Add regnum for ra_state.
9382
9383 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9384             Jiong Wang  <jiong.wang@arm.com>
9385
9386         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9387
9388 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9389             Jiong Wang  <jiong.wang@arm.com>
9390
9391         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9392         function.
9393         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9394         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9395         (aarch64_gdbarch_init): Add puth registers.
9396         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9397         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9398         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9399
9400 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9401             Jiong Wang  <jiong.wang@arm.com>
9402
9403         * aarch64-linux-nat.c
9404         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9405         * aarch64-linux-tdep.c
9406         (aarch64_linux_core_read_description): Likewise.
9407         (aarch64_linux_get_hwcap): New function.
9408         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9409         (aarch64_linux_get_hwcap): New declaration.
9410
9411 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9412             Jiong Wang  <jiong.wang@arm.com>
9413
9414         * aarch64-linux-nat.c
9415         (aarch64_linux_nat_target::read_description): Add pauth param.
9416         * aarch64-linux-tdep.c
9417         (aarch64_linux_core_read_description): Likewise.
9418         * aarch64-tdep.c (struct target_desc): Add in pauth.
9419         (aarch64_read_description): Add pauth param.
9420         (aarch64_gdbarch_init): Likewise.
9421         * aarch64-tdep.h (aarch64_read_description): Likewise.
9422         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9423         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9424         * features/Makefile: Add new files.
9425         * features/aarch64-pauth.c: New file.
9426         * features/aarch64-pauth.xml: New file.
9427
9428 2019-03-20  Tom Tromey  <tromey@adacore.com>
9429
9430         * infrun.c (handle_inferior_event): Rename from
9431         handle_inferior_event_1.  Create a scoped_value_mark.
9432         (handle_inferior_event): Remove.
9433
9434 2019-03-19  Tom Tromey  <tromey@adacore.com>
9435
9436         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9437         * infrun.h (print_stop_event): Add "displays" parameter.
9438         * infrun.c (print_stop_event): Add "displays" parameter.
9439
9440 2019-03-19  Pedro Alves  <palves@redhat.com>
9441
9442         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9443         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9444         to -1.  Fix TABs vs spaces.
9445         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9446         * tui/tui-out.h (tui_ui_out) Add intro comments.
9447         <m_line, m_start_of_line>: In-class initialize, and add describing
9448         comment.
9449
9450 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9451
9452         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9453         variable names.
9454         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9455
9456 2019-03-18  Pedro Alves  <palves@redhat.com>
9457             Eli Zaretskii <eliz@gnu.org>
9458
9459         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9460         m_line and m_start_of_line.
9461
9462 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9463
9464         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9465         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9466         it returns a newline.  This fixes a regression in TU mode, whereby
9467         the next line is output on the same screen line as the user input.
9468
9469 2019-03-18  Tom Tromey  <tromey@adacore.com>
9470
9471         * minsyms.c (minimal_symbol_reader::install): Remove call to
9472         obstack_blank.
9473
9474 2019-03-18  Pedro Alves  <palves@redhat.com>
9475
9476         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9477         New globals.
9478         (apply_style): New, factored out from ...
9479         (apply_ansi_escape): ... this.  Handle reverse video mode.
9480         (tui_set_reverse_mode): New function.
9481         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9482         * tui/tui-winsource.c (tui_show_source_line): Use
9483         tui_set_reverse_mode instead of setting A_STANDOUT.
9484         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9485         New setter methods.
9486
9487 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9488
9489         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9490         Handle tabs.
9491
9492 2019-03-18  Tom Tromey  <tromey@adacore.com>
9493
9494         * ada-lang.c (empty_array): Add "high" parameter.
9495         (ada_evaluate_subexp): Update.
9496
9497 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9498
9499         * unittests/string_view-selftests.c: Define
9500         _initialize_string_view_selftests unconditionally.
9501
9502 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9503
9504         PR gdb/24350
9505         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9506
9507 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9508
9509         PR gdb/24351
9510         * windows-nat.c (display_selector): Fix format specifiers.
9511
9512 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9513
9514         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9515         tui_refill_source_window instead of tui_refresh_win, to update the
9516         current execution line.  This fixes redisplay of the current line
9517         when stepping through the code with "next" or "step".
9518
9519 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9520
9521         * source-cache.c (source_cache::get_source_lines): Call
9522         find_source_lines to initialize s->nlines.  This fixes vertical
9523         scrolling of TUI source window when the DOWN arrow is pressed.
9524
9525 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9526
9527         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9528         linux-thread-db.c (_initialize_thread_db): Likewise.
9529
9530 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9531
9532         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9533         wclrtoeol in tui_show_source_line".  This reverts changes made in
9534         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9535
9536 2019-03-15  Tom Tromey  <tom@tromey.com>
9537
9538         * symtab.h (struct minimal_symbol): Derive from
9539         general_symbol_info.
9540         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9541         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9542         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9543         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9544         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9545         (MSYMBOL_SEARCH_NAME): Update.
9546         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9547         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9548         * minsyms.c (minimal_symbol_reader::record_full): Update.
9549
9550 2019-03-15  Tom Tromey  <tom@tromey.com>
9551
9552         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9553
9554 2019-03-15  Tom Tromey  <tom@tromey.com>
9555
9556         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9557         unique_xmalloc_ptr.
9558         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9559         Update.
9560         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9561         (build_minimal_symbol_hash_tables)
9562         (minimal_symbol_reader::install): Update.
9563
9564 2019-03-15  Tom Tromey  <tom@tromey.com>
9565
9566         * symtab.c (create_demangled_names_hash): Update.
9567         (symbol_set_names): Update.
9568         * objfiles.h (struct objfile_per_bfd_storage)
9569         <demangled_names_hash>: Now an htab_up.
9570         * objfiles.c (objfile_per_bfd_storage): Simplify.
9571
9572 2019-03-15  Tom Tromey  <tom@tromey.com>
9573
9574         * objfiles.h (struct objfile_per_bfd_storage): Declare
9575         destructor.
9576         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9577         New.
9578         (get_objfile_bfd_data): Use new.  Don't initialize
9579         language_of_main.
9580         (free_objfile_per_bfd_storage): Remove.
9581         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9582
9583 2019-03-15  Tom Tromey  <tom@tromey.com>
9584
9585         * symfile.c (reread_symbols): Update.
9586         * objfiles.c (objfile::objfile): Update.
9587         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9588         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9589         comment.
9590         (minimal_symbol_reader::install): Update.
9591         (terminate_minimal_symbol_table): Remove.
9592         * jit.c (jit_object_close_impl): Update.
9593
9594 2019-03-15  Tom Tromey  <tom@tromey.com>
9595
9596         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9597         initializations.
9598
9599 2019-03-15  Tom Tromey  <tom@tromey.com>
9600
9601         * objfiles.h (struct objfile_per_bfd_storage)
9602         <demangled_hash_languages>: Now a bitset.
9603         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9604         (lookup_minimal_symbol): Update.
9605
9606 2019-03-15  Tom Tromey  <tom@tromey.com>
9607
9608         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9609         Don't return the symbol.
9610         * coffread.c (record_minimal_symbol): Use record_full.
9611
9612 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9613
9614         The MS-Windows port of ncurses fails to switch to a color pair if
9615         one or both of the colors are the implicit default colors.  This
9616         change records the default colors when TUI is initialized, and
9617         then specifies them explicitly when a color pair uses the default
9618         colors.  This allows color styling in TUI mode on MS-Windows.
9619
9620         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9621         ncurses_norm_attr.
9622         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9623         colors in ncurses_norm_attr.
9624         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9625         "none", replace it with the default color recorded in
9626         ncurses_norm_attr.
9627
9628 2019-03-14  Tom Tromey  <tromey@adacore.com>
9629
9630         * source-cache.h (class source_cache) <get_source_lines>: Return
9631         std::string.
9632         * source-cache.c (source_cache::extract_lines): Handle case where
9633         first_pos==npos.  Return std::string.
9634         (source_cache::get_source_lines): Update.
9635
9636 2019-03-14  Tom Tromey  <tromey@adacore.com>
9637
9638         * NEWS: Add item for "style sources" commands.
9639         * source-cache.c (source_cache::get_source_lines): Check
9640         source_styling.
9641         * cli/cli-style.c (source_styling): New global.
9642         (_initialize_cli_style): Add "style sources" commands.
9643         (show_style_sources): New function.
9644         * cli/cli-style.h (source_styling): Declare.
9645
9646 2019-03-14  Pedro Alves  <palves@redhat.com>
9647             Tom Tromey  <tromey@adacore.com>
9648
9649         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9650         * tui/tui-winsource.c (tui_refill_source_window): New function,
9651         from...
9652         (tui_horizontal_source_scroll): ... here.  Move some logic.
9653         * cli/cli-style.c (set_style_enabled): Notify new observable.
9654         * tui/tui-hooks.c (tui_redisplay_source): New function.
9655         (tui_attach_detach_observers): Attach or detach
9656         tui_redisplay_source.
9657         * observable.h (source_styling_changed): New observable.
9658         * observable.c: Define source_styling_changed observable.
9659
9660 2019-03-13  Tom Tromey  <tromey@adacore.com>
9661
9662         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9663         (i386_gnu_nat_target::store_registers): Update.
9664         * target-debug.h (target_debug_print_std_string): New macro.
9665         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9666         * windows-tdep.c (display_one_tib): Update.
9667         * tui/tui-stack.c (tui_make_status_line): Update.
9668         * top.c (print_inferior_quit_action): Update.
9669         * thread.c (thr_try_catch_cmd): Update.
9670         (add_thread_with_info): Update.
9671         (thread_target_id_str): Update.
9672         (thr_try_catch_cmd): Update.
9673         (thread_command): Update.
9674         (thread_find_command): Update.
9675         * record-btrace.c (record_btrace_target::info_record)
9676         (record_btrace_resume_thread, record_btrace_target::resume)
9677         (record_btrace_cancel_resume, record_btrace_step_thread)
9678         (record_btrace_target::wait, record_btrace_target::wait)
9679         (record_btrace_target::wait, record_btrace_target::stop): Update.
9680         * progspace.c (print_program_space): Update.
9681         * process-stratum-target.c
9682         (process_stratum_target::thread_address_space): Update.
9683         * linux-fork.c (linux_fork_mourn_inferior)
9684         (detach_checkpoint_command, info_checkpoints_command)
9685         (linux_fork_context): Update.
9686         (linux_fork_detach): Update.
9687         (class scoped_switch_fork_info): Update.
9688         (delete_checkpoint_command): Update.
9689         * infrun.c (follow_fork_inferior): Update.
9690         (follow_fork_inferior): Update.
9691         (proceed_after_vfork_done): Update.
9692         (handle_vfork_child_exec_or_exit): Update.
9693         (follow_exec): Update.
9694         (displaced_step_prepare_throw): Update.
9695         (displaced_step_restore): Update.
9696         (start_step_over): Update.
9697         (resume_1): Update.
9698         (clear_proceed_status_thread): Update.
9699         (proceed): Update.
9700         (print_target_wait_results): Update.
9701         (do_target_wait): Update.
9702         (context_switch): Update.
9703         (stop_all_threads): Update.
9704         (restart_threads): Update.
9705         (finish_step_over): Update.
9706         (handle_signal_stop): Update.
9707         (switch_back_to_stepped_thread): Update.
9708         (keep_going_pass_signal): Update.
9709         (print_exited_reason): Update.
9710         (normal_stop): Update.
9711         * inferior.c (inferior_pid_to_str): Change return type.
9712         (print_selected_inferior): Update.
9713         (add_inferior): Update.
9714         (detach_inferior): Update.
9715         * dummy-frame.c (fprint_dummy_frames): Update.
9716         * dcache.c (dcache_info_1): Update.
9717         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9718         (btrace_fetch, btrace_clear): Update.
9719         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9720         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9721         type.
9722         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9723         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9724         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9725         * gdbarch.c, gdbarch.h: Rebuild.
9726         * gdbarch.sh (core_pid_to_str): Change return type.
9727         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9728         return type.
9729         (windows_nat_target::pid_to_str): Change return type.
9730         (windows_delete_thread): Update.
9731         (windows_nat_target::attach): Update.
9732         (windows_nat_target::files_info): Update.
9733         * target-delegates.c: Rebuild.
9734         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9735         return type.
9736         (sol_thread_target::pid_to_str): Change return type.
9737         * remote.c (class remote_target) <pid_to_str>: Change return
9738         type.
9739         (remote_target::pid_to_str): Change return type.
9740         (extended_remote_target::attach, remote_target::remote_stop_ns)
9741         (remote_target::remote_notif_remove_queued_reply)
9742         (remote_target::push_stop_reply, remote_target::disable_btrace):
9743         Update.
9744         (extended_remote_target::attach): Update.
9745         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9746         type.
9747         (gdbsim_target::pid_to_str): Change return type.
9748         * ravenscar-thread.c (struct ravenscar_thread_target)
9749         <pid_to_str>: Change return type.
9750         (ravenscar_thread_target::pid_to_str): Change return type.
9751         * procfs.c (class procfs_target) <pid_to_str>: Change return
9752         type.
9753         (procfs_target::pid_to_str): Change return type.
9754         (procfs_target::attach): Update.
9755         (procfs_target::detach): Update.
9756         (procfs_target::fetch_registers): Update.
9757         (procfs_target::store_registers): Update.
9758         (procfs_target::wait): Update.
9759         (procfs_target::files_info): Update.
9760         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9761         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9762         return type.
9763         (nto_procfs_target::pid_to_str): Change return type.
9764         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9765         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9766         return type.
9767         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9768         (exit_lwp): Update.
9769         (attach_proc_task_lwp_callback, get_detach_signal)
9770         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9771         (linux_nat_target::resume, wait_lwp, stop_callback)
9772         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9773         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9774         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9775         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9776         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9777         type.
9778         (inf_ptrace_target::attach): Update.
9779         (inf_ptrace_target::files_info): Update.
9780         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9781         type.
9782         (go32_nat_target::pid_to_str): Change return type.
9783         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9784         (gnu_nat_target::wait): Update.
9785         (gnu_nat_target::wait): Update.
9786         (gnu_nat_target::resume): Update.
9787         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9788         (fbsd_nat_target::wait): Update.
9789         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9790         type.
9791         (darwin_nat_target::attach): Update.
9792         * corelow.c (class core_target) <pid_to_str>: Change return type.
9793         (core_target::pid_to_str): Change return type.
9794         * target.c (normal_pid_to_str): Change return type.
9795         (default_pid_to_str): Likewise.
9796         (target_pid_to_str): Change return type.
9797         (target_translate_tls_address): Update.
9798         (target_announce_detach): Update.
9799         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9800         return type.
9801         (bsd_uthread_target::pid_to_str): Change return type.
9802         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9803         type.
9804         (bsd_kvm_target::pid_to_str): Change return type.
9805         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9806         return type.
9807         (aix_thread_target::pid_to_str): Change return type.
9808         * target.h (struct target_ops) <pid_to_str>: Change return type.
9809         (target_pid_to_str, normal_pid_to_str): Likewise.
9810         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9811         type.
9812         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9813         type.
9814         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9815         return type.
9816         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9817         type.
9818         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9819         type.
9820         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9821         return type.
9822
9823 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9824
9825         * NEWS: Mention that the new default MI version is 3.  Mention
9826         changes to the output of commands and events that deal with
9827         multi-location breakpoints.
9828         * breakpoint.c: Include "mi/mi-out.h".
9829         (print_one_breakpoint): Change output syntax if using MI version
9830         >= 3.
9831         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9832         New.
9833         (mi_multi_location_breakpoint_output_fixed): New.
9834         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9835         (mi_cmd_fix_multi_location_breakpoint_output): New.
9836         (mi_multi_location_breakpoint_output_fixed): New.
9837         * mi/mi-cmds.c (mi_cmds): Register command
9838         -fix-multi-location-breakpoint-output.
9839         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9840         interpreter "mi".
9841
9842 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9843
9844         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9845         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9846         instantiate mi_ui_out based on interpreter name.
9847         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9848         * mi/mi-main.c (mi_load_progress): Likewise.
9849
9850 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9851
9852         * NEWS: Combine separate "New targets" sections for 8.3.
9853
9854 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9855
9856         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9857         (ppcfbsd_init_abi): Install gdbarch
9858         "fetch_tls_load_module_address" and "get_thread_local_address"
9859         methods.
9860
9861 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9862
9863         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9864         (riscv_fbsd_init_abi): Install gdbarch
9865         "fetch_tls_load_module_address" and "get_thread_local_address"
9866         methods.
9867
9868 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9869
9870         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9871         (i386fbsd_init_abi): Install gdbarch
9872         "fetch_tls_load_module_address" and "get_thread_local_address"
9873         methods.
9874
9875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9876
9877         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9878         (amd64fbsd_init_abi): Install gdbarch
9879         "fetch_tls_load_module_address" and "get_thread_local_address"
9880         methods.
9881
9882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9883
9884         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9885         (struct fbsd_pspace_data): New type.
9886         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9887         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9888         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9889         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9890         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9891
9892 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9893
9894         * gdbtypes.c (lookup_struct_elt): New function.
9895         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9896         * gdbtypes.h (struct struct_elt): New type.
9897         (lookup_struct_elt): New prototype.
9898
9899 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9900
9901         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9902         remove disabled code block.
9903
9904 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9905
9906         * gdbarch.sh (get_thread_local_address): New method.
9907         * gdbarch.h, gdbarch.c: Regenerate.
9908         * target.c (target_translate_tls_address): Use
9909         gdbarch_get_thread_local_address if present instead of
9910         target::get_thread_local_address.
9911
9912 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9913
9914         * target.h (target::get_thread_local_address): Update comment.
9915
9916 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9917
9918         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9919         objfile->separate_debug_objfile_backlink if not NULL.
9920
9921 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9922
9923         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9924         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9925         (amd64bsd_store_inferior_registers): Likewise.
9926         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9927         Enable segment base registers.
9928         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9929         PT_GETFSBASE and PT_GETGSBASE.
9930         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9931         PT_SETGSBASE.
9932         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9933         segment base registers.
9934         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9935
9936 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9937
9938         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9939         Update calls to i386_target_description to add 'segments'
9940         parameter.
9941         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9942         add segment base registers.
9943         * arch/i386.c (i386_create_target_description): Add 'segments'
9944         parameter to enable segment base registers.
9945         * arch/i386.h (i386_create_target_description): Likewise.
9946         * features/i386/32bit-segments.xml: New file.
9947         * features/i386/32bit-segments.c: Generate.
9948         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9949         call to i386_target_description to add 'segments' parameter.
9950         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9951         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9952         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9953         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9954         if feature is present.
9955         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9956         Add 'segments' parameter to call to i386_target_description.
9957         (i386_target_description): Add 'segments' parameter to enable
9958         segment base registers.
9959         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9960         to call to i386_target_description.
9961         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9962         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9963         Define I386_NUM_REGS.
9964         (i386_target_description): Add 'segments' parameter to enable
9965         segment base registers.
9966
9967 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9968
9969         PR/24325
9970         * source-cache.c: #undef open and close, to avoid unresolved
9971         externals during linking.
9972
9973 2019-03-12  Tom Tromey  <tromey@adacore.com>
9974
9975         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9976         const.  Add initializers.
9977         (_initialize_remote): Don't initialize ptid globals.
9978
9979 2019-03-12  Pedro Alves  <palves@redhat.com>
9980
9981         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9982
9983 2019-03-12  Pedro Alves  <palves@redhat.com>
9984
9985         * cp-name-parser.y (main): Remove unused 'len' variable.
9986
9987 2019-03-12  Tom Tromey  <tromey@adacore.com>
9988
9989         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9990         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9991
9992 2019-03-12  Tom Tromey  <tromey@adacore.com>
9993
9994         * linux-nat.c (iterate_over_lwps): Update.
9995         (stop_callback): Remove parameter.
9996         (stop_wait_callback, detach_callback, resume_set_callback)
9997         (select_singlestep_lwp_callback, set_ignore_sigint)
9998         (status_callback, resumed_callback, resume_clear_callback)
9999         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10000         data parameter.
10001         (linux_nat_target::detach, linux_nat_target::resume)
10002         (linux_stop_and_wait_all_lwps, select_event_lwp)
10003         (linux_nat_filter_event, linux_nat_wait_1)
10004         (linux_nat_target::kill, linux_nat_target::stop)
10005         (linux_nat_target::stop): Update.
10006         (linux_nat_resume_callback): Change type.
10007         (resume_stopped_resumed_lwps, count_events_callback)
10008         (select_event_lwp_callback): Likewise.
10009         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10010         * arm-linux-nat.c (struct update_registers_data): Remove.
10011         (update_registers_callback): Change type.
10012         (arm_linux_insert_hw_breakpoint1): Update.
10013         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10014         parameter.
10015         (x86_linux_dr_set_addr): Update.
10016         (x86_linux_dr_set_control): Update.
10017         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10018         (iterate_over_lwps): Use gdb::function_view.
10019         * nat/aarch64-linux-hw-point.c (struct
10020         aarch64_dr_update_callback_param): Remove.
10021         (debug_reg_change_callback): Change type.
10022         (aarch64_notify_debug_reg_change): Update.
10023         * s390-linux-nat.c (s390_refresh_per_info): Update.
10024
10025 2019-03-11  Tom Tromey  <tromey@adacore.com>
10026
10027         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10028         redundant assignment to "this_cu".
10029
10030 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10031
10032         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10033
10034 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10035
10036         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10037         from...
10038         (rank_one_type): ... this.
10039
10040 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10041
10042         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10043         from...
10044         (rank_one_type): ... this.
10045
10046 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10047
10048         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10049         from...
10050         (rank_one_type): ... this.
10051
10052 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10053
10054         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10055         from...
10056         (rank_one_type): ... this.
10057
10058 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10059
10060         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10061         from...
10062         (rank_one_type): ... this.
10063
10064 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10065
10066         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10067         from...
10068         (rank_one_type): ... this.
10069
10070 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10071
10072         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10073         from...
10074         (rank_one_type): ... this.
10075
10076 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10077
10078         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10079         from...
10080         (rank_one_type): ... this.
10081
10082 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10083
10084         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10085         from...
10086         (rank_one_type): ... this.
10087
10088 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10089
10090         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10091         from...
10092         (rank_one_type): ... this.
10093
10094 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10095
10096         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10097         from...
10098         (rank_one_type): ... this.
10099
10100 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10101
10102         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10103         from...
10104         (rank_one_type): ... this.
10105
10106 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10107
10108         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10109         inferior-events' shows the example events.
10110
10111 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10112
10113         Support styling on native MS-Windows console
10114
10115         PR/24315
10116         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10117         on MS-Windows if $TERM is not defined.
10118
10119         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10120
10121         * posix-hdep.c (gdb_console_fputs):
10122         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10123         functions.
10124         * ui-file.h (gdb_console_fputs): Add prototype.
10125
10126         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10127         back to fputs only if the former returns zero.
10128
10129 2019-03-07  Tom Tromey  <tom@tromey.com>
10130
10131         * symmisc.c (print_symbol_bcache_statistics): Update.
10132         (print_objfile_statistics): Update.
10133         * symfile.c (allocate_symtab): Update.
10134         * stabsread.c: Don't include bcache.h.
10135         * psymtab.h (struct psymbol_bcache): Don't declare.
10136         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10137         (psymbol_bcache_init, psymbol_bcache_free)
10138         (psymbol_bcache_get_bcache): Don't declare.
10139         * psymtab.c (struct psymbol_bcache): Remove.
10140         (psymtab_storage::psymtab_storage): Update.
10141         (psymtab_storage::~psymtab_storage): Update.
10142         (psymbol_bcache_init, psymbol_bcache_free)
10143         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10144         (add_psymbol_to_bcache): Update.
10145         (allocate_psymtab): Update.
10146         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10147         macro_cache>: No longer pointers.
10148         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10149         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10150         * macrotab.c (macro_bcache): Update.
10151         * macroexp.c: Don't include bcache.h.
10152         * gdbtypes.c (check_types_worklist): Update.
10153         (types_deeply_equal): Remove TRY/CATCH.  Update.
10154         * elfread.c (elf_symtab_read): Update.
10155         * dwarf2read.c: Don't include bcache.h.
10156         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10157         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10158         (print_bcache_statistics, bcache_memory_used): Don't declare.
10159         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10160         methods.  Rename all data members.
10161         * bcache.c (struct bcache): Move to bcache.h.
10162         (bcache::expand_hash_table): Rename from expand_hash_table.
10163         (bcache): Remove.
10164         (bcache::insert): Rename from bcache_full.
10165         (bcache::compare): Rename from bcache_compare.
10166         (bcache_xmalloc): Remove.
10167         (bcache::~bcache): Rename from bcache_xfree.
10168         (bcache::print_statistics): Rename from print_bcache_statistics.
10169         (bcache::memory_used): Rename from bcache_memory_used.
10170
10171 2019-03-07  Pedro Alves  <palves@redhat.com>
10172
10173         * infrun.c (normal_stop): Also check for
10174         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10175
10176 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10177
10178         * f-lang.c (value_from_host_double): Moved to...
10179         * value.c (value_from_host_double): ...here.
10180         * value.h (value_from_host_double): Declare.
10181         * guile/scm-math.c (vlscm_convert_typed_number): Use
10182         value_from_host_double.
10183         (vlscm_convert_number): Likewise.
10184         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10185         * python/py-value.c (convert_value_from_python): Likewise.
10186
10187 2019-03-06  Tom Tromey  <tom@tromey.com>
10188
10189         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10190
10191 2019-03-06  Tom Tromey  <tom@tromey.com>
10192
10193         * utils.h (free_current_contents): Don't declare.
10194         * utils.c (free_current_contents): Remove.
10195
10196 2019-03-06  Tom Tromey  <tom@tromey.com>
10197
10198         * top.c (quit_force): Update.
10199         * main.c (captured_command_loop): Update.
10200         * common/new-op.c (operator new): Update.
10201         * common/common-exceptions.c (struct catcher)
10202         <save_cleanup_chain>: Remove member.
10203         (exceptions_state_mc_init): Update.
10204         (exception_try_scope_entry): Return nullptr.
10205         (exception_try_scope_exit, exception_rethrow)
10206         (throw_exception_sjlj, throw_exception_cxx): Update.
10207         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10208         (all_cleanups, do_cleanups, discard_cleanups)
10209         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10210         (restore_cleanups, restore_final_cleanups): Don't declare.
10211         (do_final_cleanups): Remove parameter.
10212         * common/cleanups.c (cleanup_chain, make_cleanup)
10213         (make_cleanup_dtor, all_cleanups, do_cleanups)
10214         (discard_my_cleanups, discard_cleanups)
10215         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10216         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10217         (null_cleanup): Remove.
10218         (do_final_cleanups): Remove parameter.
10219
10220 2019-03-06  Tom Tromey  <tom@tromey.com>
10221
10222         * remote.c (remote_target::remote_parse_stop_reply): Use
10223         unique_xmalloc_ptr.
10224
10225 2019-03-06  Tom Tromey  <tom@tromey.com>
10226
10227         * stabsread.c (struct stabs_field_info): Rename from field_info.
10228         <list, fnlist>: Add initializers.
10229         <obstack>: New member.
10230         (read_member_functions, read_struct_fields, read_baseclasses):
10231         Allocate on obstack.  Don't use cleanups.
10232         (read_one_struct_field, read_member_functions, read_struct_fields)
10233         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10234         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10235         (read_struct_type): Update.
10236
10237 2019-03-06  Tom Tromey  <tom@tromey.com>
10238
10239         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10240         * common/filestuff.h (make_cleanup_close): Don't declare.
10241         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10242         Remove.
10243
10244 2019-03-06  Tom Tromey  <tom@tromey.com>
10245
10246         * solib-aix.c: Use make_scope_exit.
10247
10248 2019-03-06  Tom Tromey  <tom@tromey.com>
10249
10250         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10251         Use make_scope_exit.
10252
10253 2019-03-06  Tom Tromey  <tom@tromey.com>
10254
10255         * solib-svr4.c (disable_probes_interface): Remove parameter.
10256         (svr4_handle_solib_event): Use make_scope_exit.
10257
10258 2019-03-06  Tom Tromey  <tom@tromey.com>
10259
10260         * remote.c (struct stop_reply_deleter): Remove.
10261         (stop_reply_up): Update.
10262         (struct stop_reply): Derive from notif_event.  Don't typedef.
10263         <regcache>: Now a std::vector.
10264         (stop_reply_xfree): Remove.
10265         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10266         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10267         (remote_target::discard_pending_stop_replies): Use delete.
10268         (remote_target::remote_parse_stop_reply): Update.
10269         (remote_target::process_stop_reply): Update.
10270         * remote-notif.h (struct notif_event): Add virtual destructor.
10271         Remove "dtr" member.
10272         (struct notif_client) <alloc_event>: Return a unique_ptr.
10273         (notif_event_xfree): Don't declare.
10274         (notif_event_up): New typedef.
10275         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10276         (notif_event_xfree, do_notif_event_xfree): Remove.
10277         (remote_notif_state_xfree): Update.
10278
10279 2019-03-06  Tom Tromey  <tom@tromey.com>
10280
10281         * infrun.c (displaced_step_clear_cleanup): Now a
10282         forward_scope_exit type.
10283         (displaced_step_prepare_throw): Update.
10284         (displaced_step_fixup): Update.
10285
10286 2019-03-06  Tom Tromey  <tom@tromey.com>
10287
10288         * inferior.h (class inferior): Update comment.
10289         * gdbthread.h (class thread_info): Update comment.
10290
10291 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10292             Tom Tromey  <tom@tromey.com>
10293
10294         * stabsread.h (struct stab_section_list): Remove.
10295         (coffstab_build_psymtabs): Update.
10296         * dbxread.c (symbuf_sections): Now a std::vector.
10297         (sect_idx): New global.
10298         (fill_symbuf): Update.
10299         (coffstab_build_psymtabs): Change type of stabsects parameter.
10300         Update.
10301         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10302         std::vector.
10303         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10304         (coff_locate_sections): Update.
10305         (coff_symfile_read): Remove cleanups.  Update.
10306         (init_stringtab): Add storage parameter.
10307         (free_stringtab, free_stringtab_cleanup): Remove.
10308         (init_lineno): Add storage parameter.
10309         (free_linetab, free_linetab_cleanup): Remove.
10310
10311 2019-03-06  Pedro Alves  <palves@redhat.com>
10312
10313         * linux-fork.c (fork_info::clobber_regs): Delete.
10314         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10315         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10316         comment.  Adjust.
10317         (scoped_switch_fork_info::scoped_switch_fork_info)
10318         (checkpoint_command, linux_fork_context): Adjust
10319         fork_save_infrun_state calls.
10320
10321 2019-03-06  Pedro Alves  <palves@redhat.com>
10322
10323         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10324         (inf_has_multiple_threads): Return 'bool' and rewrite using
10325         inferior_info::threads().
10326
10327 2019-03-06  Pedro Alves  <palves@redhat.com>
10328
10329         * linux-fork.c: Include <list>.
10330         (fork_list): Now a std::list instance.
10331         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10332         (forks_exist_p, find_last_fork): Adjust.
10333         (new_fork): Delete.
10334         (one_fork_p): New.
10335         (add_fork): Adjust.
10336         (free_fork): Delete, folded into fork_info::~fork_info().
10337         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10338         Adjust.
10339         (init_fork_list): Delete.
10340         (linux_fork_killall, linux_fork_mourn_inferior)
10341         (linux_fork_detach, info_checkpoints_command): Adjust.
10342         (_initialize_linux_fork): No longer call init_fork_list.
10343
10344 2019-03-06  Pedro Alves  <palves@redhat.com>
10345
10346         * linux-fork.c (new_fork): New, split out of ...
10347         (add_fork): ... this.  Return void.  Move "first fork" special
10348         case from here, to ...
10349         (checkpoint_command): ... here.
10350         * linux-linux.h (add_fork): Return void.
10351
10352 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10353
10354         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10355
10356 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10357             Chris January  <chris.january@arm.com>
10358             David Lecomber  <david.lecomber@arm.com>
10359
10360         * f-exp.y: New token, UNOP_INTRINSIC.
10361         (exp): New pattern using UNOP_INTRINSIC token.
10362         (f77_keywords): Add 'abs' keyword.
10363         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10364         (value_from_host_double): New function.
10365         (evaluate_subexp_f): Support UNOP_ABS.
10366
10367 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10368
10369         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10370         types.
10371
10372 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10373
10374         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10375         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10376         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10377
10378 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10379
10380         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10381
10382 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10383             Chris January  <chris.january@arm.com>
10384
10385         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10386         * f-exp.y: Define 'KIND' token.
10387         (exp): New pattern for KIND expressions.
10388         (ptype): Handle types with a kind extension.
10389         (direct_abs_decl): Extend to spot kind extensions.
10390         (f77_keywords): Add 'kind' to the list.
10391         (push_kind_type): New function.
10392         (convert_to_kind_type): New function.
10393         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10394         * parse.c (operator_length_standard): Likewise.
10395         * parser-defs.h (enum type_pieces): Add tp_kind.
10396         * std-operator.def: Add UNOP_KIND.
10397
10398 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10399
10400         * f-exp.y (f_parse): Set yydebug.
10401
10402 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10403
10404         * f-lang.c (evaluate_subexp_f): New function.
10405         (exp_descriptor_f): New global.
10406         (f_language_defn): Use exp_descriptor_f instead of
10407         exp_descriptor_standard.
10408
10409 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10410
10411         * f-exp.y (struct token): Add comments.
10412         (dot_ops): Remove uppercase versions and the end marker.
10413         (f77_keywords): Likewise.
10414         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10415         entries in the dot_ops array are case insensitive, and use
10416         strncasecmp to compare strings.  Also some whitespace cleanup in
10417         this area.  Similar for the f77_keywords array, except entries in
10418         this list might be case sensitive.
10419
10420 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10421
10422         * f-exp.y (struct f77_boolean_val): Add comments.
10423         (boolean_values): Remove uppercase versions, and end marker.
10424         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10425         and use strncasecmp to achieve case insensitivity.  Additionally,
10426         perform whitespace cleanup around this code.
10427
10428 2019-03-06  Tom Tromey  <tromey@adacore.com>
10429
10430         * remote-sim.c (gdbsim_target_open): Use result of
10431         gdb_argv::release.
10432
10433 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10434         Dirk Schubert  <dirk.schubert@arm.com>
10435         Chris January  <chris.january@arm.com>
10436
10437         * eval.c (evaluate_subexp_standard): Call Fortran argument
10438         wrapping logic.
10439         * f-lang.c (struct value): A value which can be passed into a
10440         Fortran function call.
10441         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10442         where appropriate.
10443         (struct type): Value ready for a Fortran function call.
10444         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10445         is needed.
10446         * f-lang.h (fortran_argument_convert): Declaration.
10447         (fortran_preserve_arg_pointer): Declaration.
10448         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10449
10450 2019-03-05  Tom Tromey  <tromey@adacore.com>
10451
10452         * python/py-prettyprint.c (print_string_repr): Remove #if.
10453         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10454
10455 2019-03-05  Tom Tromey  <tromey@adacore.com>
10456
10457         * target.c (the_dummy_target): Move later.  Change type to
10458         "dummy_target".
10459         (initialize_targets): Don't initialize the_dummy_target.
10460
10461 2019-03-05  Tom Tromey  <tromey@adacore.com>
10462
10463         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10464         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10465
10466 2019-03-05  Tom Tromey  <tromey@adacore.com>
10467
10468         * windows-nat.c (windows_nat_target::attach)
10469         (windows_nat_target::detach): Don't call gdb_flush.
10470         * valprint.c (generic_val_print, val_print, val_print_string):
10471         Don't call gdb_flush.
10472         * utils.c (defaulted_query): Don't call gdb_flush.
10473         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10474         * target.c (target_announce_detach): Don't call gdb_flush.
10475         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10476         * remote.c (extended_remote_target::attach): Don't call
10477         gdb_flush.
10478         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10479         * printcmd.c (do_examine): Don't call gdb_flush.
10480         (info_display_command): Don't call gdb_flush.
10481         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10482         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10483         * memattr.c (info_mem_command): Don't call gdb_flush.
10484         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10485         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10486         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10487         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10488         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10489         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10490         (gnu_nat_target::detach): Don't call gdb_flush.
10491         * f-valprint.c (f_val_print): Don't call gdb_flush.
10492         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10493         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10494         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10495         gdb_flush.
10496         * c-valprint.c (c_val_print): Don't call gdb_flush.
10497         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10498
10499 2019-03-05  Tom Tromey  <tromey@adacore.com>
10500
10501         * varobj.c (update_dynamic_varobj_children): Update.
10502         (install_default_visualizer): Use reset, not release.
10503         * value.c (set_internalvar): Update.
10504         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10505         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10506         ATTRIBUTE_UNUSED_RESULT.
10507
10508 2019-03-05  Tom Tromey  <tromey@adacore.com>
10509
10510         * remote.c (class scoped_remote_fd) <release>: Add
10511         ATTRIBUTE_UNUSED_RESULT.
10512
10513 2019-03-05  Tom Tromey  <tromey@adacore.com>
10514
10515         * macroexp.c (struct macro_buffer) <release>: Add
10516         ATTRIBUTE_UNUSED_RESULT.
10517
10518 2019-03-05  Tom Tromey  <tromey@adacore.com>
10519
10520         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10521         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10522         ATTRIBUTE_UNUSED_RESULT.
10523
10524 2019-03-05  Tom Tromey  <tromey@adacore.com>
10525
10526         * common/scoped_fd.h (class scoped_fd) <release>: Add
10527         ATTRIBUTE_UNUSED_RESULT.
10528
10529 2019-03-05  Tom Tromey  <tromey@adacore.com>
10530
10531         * parser-defs.h (struct parser_state) <release>: Add
10532         ATTRIBUTE_UNUSED_RESULT.
10533
10534 2019-03-05  Tom Tromey  <tromey@adacore.com>
10535
10536         * utils.h (class gdb_argv) <release>: Add
10537         ATTRIBUTE_UNUSED_RESULT.
10538         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10539
10540 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10541
10542         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10543         for-loop range, to avoid compiler warnings.
10544
10545         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10546         avoid compiler warnings about unused variables.
10547
10548         * NEWS: Mention end of support for native debugging on MS-Windows
10549         before XP.
10550
10551         PR gdb/24292
10552         * common/netstuff.c:
10553         * gdbserver/gdbreplay.c
10554         * gdbserver/remote-utils.c:
10555         * ser-tcp.c:
10556         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10557         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10558         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10559         'getaddrinfo' and 'freeaddrinfo' were not available before
10560         Windows XP, and mingw.org's MinGW headers by default define
10561         _WIN32_WINNT to 0x500.
10562
10563 2019-03-01  Gary Benson <gbenson@redhat.com>
10564
10565         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10566
10567 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10568             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10569
10570         PR gdb/8527
10571         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10572         set_sigint_trap, clear_sigint_trap.
10573
10574 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10575
10576         * target.c (target_detach): Clear the regcache and the
10577         frame cache.
10578
10579 2019-02-27  Pedro Alves  <palves@redhat.com>
10580
10581         * utils.c (set_screen_size): When we cap the height/width sizes,
10582         tweak the corresponding command variable to show "unlimited":
10583
10584 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10585             Pedro Alves  <palves@redhat.com>
10586
10587         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10588         before calling rl_set_screen_size.
10589
10590 2019-02-27  Tom Tromey  <tromey@adacore.com>
10591
10592         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10593         define.
10594         * python/py-value.c: Remove Python 2.4 workaround.
10595         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10596         workaround.
10597         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10598         Python 2.4 workaround.
10599         * python/python-internal.h: Remove Python 2.4 comment.
10600         (Py_ssize_t): Don't define.
10601         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10602         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10603         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10604         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10605         * python/python.c (do_start_initialization): Remove Python 2.4
10606         workaround.
10607         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10608         (print_children): Remove Python 2.4 workaround.
10609         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10610         workaround.
10611         (CHARBUFFERPROC_NAME): Remove.
10612         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10613         Python 2.4 workaround.
10614
10615 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10616
10617         * NEWS: Note minimum Python version.
10618
10619 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10620
10621         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10622         code from these functions.  Remove corresponding ifdefs.  Use
10623         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10624         Remove gotos and target of gotos.
10625         (infpy_search_memory): Likewise.
10626
10627 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10628
10629         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10630         (hppa_gdbarch_init): Don't register deleted functions with
10631         gdbarch.
10632
10633 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10634
10635         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10636         (h8300_unwind_sp): Delete.
10637         (h8300_dummy_id): Delete.
10638         (h8300_gdbarch_init): Don't register deleted functions with
10639         gdbarch.
10640
10641 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10642
10643         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10644         (ft32_unwind_pc): Delete.
10645         (ft32_unwind_sp): Delete.
10646         (ft32_gdbarch_init): Don't register deleted functions with
10647         gdbarch.
10648
10649 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10650
10651         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10652         (frv_unwind_pc): Delete.
10653         (frv_unwind_sp): Delete.
10654         (frv_gdbarch_init): Don't register deleted functions with
10655         gdbarch.
10656
10657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10658
10659         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10660         (riscv_unwind_pc): Delete.
10661         (riscv_unwind_sp): Delete.
10662         (riscv_gdbarch_init): Don't register deleted functions with
10663         gdbarch.
10664
10665 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10666
10667         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10668         (csky_unwind_pc): Delete.
10669         (csky_unwind_sp): Delete.
10670         (csky_gdbarch_init): Don't register deleted functions with
10671         gdbarch.
10672
10673 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10674
10675         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10676         (cris_unwind_pc): Delete.
10677         (cris_unwind_sp): Delete.
10678         (cris_gdbarch_init): Don't register deleted functions with
10679         gdbarch.
10680
10681 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10682
10683         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10684         (bfin_unwind_pc): Delete.
10685         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10686
10687 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10688
10689         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10690         (arm_unwind_pc): Delete.
10691         (arm_unwind_sp): Delete.
10692         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10693
10694 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10695
10696         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10697         (arc_unwind_pc): Delete.
10698         (arc_unwind_sp): Delete.
10699         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10700
10701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10702
10703         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10704         (alpha_unwind_pc): Delete.
10705         (alpha_gdbarch_init): Don't register deleted functions with
10706         gdbarch.
10707
10708 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10709
10710         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10711         (aarch64_unwind_pc): Delete.
10712         (aarch64_unwind_sp): Delete.
10713         (aarch64_gdbarch_init): Don't register deleted functions with
10714         gdbarch.
10715
10716 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10717
10718         * gdbtypes.c (type_align): Don't consider static members when
10719         computing structure alignment.
10720
10721 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10722
10723         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10724         return 0 for other types.
10725         * arch-utils.c (default_type_align): Always return 0.
10726         * gdbarch.h: Regenerate.
10727         * gdbarch.sh (type_align): Extend comment.
10728         * gdbtypes.c (type_align): Add additional comments, always call
10729         gdbarch_type_align before applying the default rules.
10730         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10731         generic code will then apply a suitable default.
10732         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10733         types, return 0 for other types.
10734
10735 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10736
10737         * NEWS: Create a new section for the next release branch.
10738         Rename the section of the current branch, now that it has
10739         been cut.
10740
10741 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10742
10743         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10744         * version.in: Bump version to 8.3.50.DATE-git.
10745
10746 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10747
10748         * aix-thread.c (ptid_cmp): Remove unused variable.
10749         (get_signaled_thread): Likewise.
10750         (store_regs_user_thread): Likewise.
10751         (store_regs_kernel_thread): Likewise.
10752         (fetch_regs_kernel_thread): Remove shadowed variable.
10753
10754 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10755
10756         * features/riscv/32bit-cpu.xml: Add register numbers.
10757         * features/riscv/32bit-fpu.c: Regenerate.
10758         * features/riscv/32bit-fpu.xml: Add register numbers.
10759         * features/riscv/64bit-cpu.xml: Add register numbers.
10760         * features/riscv/64bit-fpu.c: Regenerate.
10761         * features/riscv/64bit-fpu.xml: Add register numbers.
10762
10763 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10764
10765         * NEWS: Mention two argument form of gdb.Value constructor.
10766         * python/py-value.c (convert_buffer_and_type_to_value): New
10767         function.
10768         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10769         Add support for handling an optional second argument.  Call
10770         convert_buffer_and_type_to_value as appropriate.
10771         * python/python-internal.h (Py_buffer_deleter): New struct.
10772         (Py_buffer_up): New typedef.
10773
10774 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10775
10776         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10777         instead of releasing ownership.
10778
10779 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10780
10781         * dwarf2read.c (open_and_init_dwp_file): Call
10782         elf_numsections instead of bfd_count_sections to initialize
10783         dwp_file->num_sections.
10784
10785 2019-02-25  Tom Tromey  <tromey@adacore.com>
10786
10787         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10788
10789 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10790
10791         * gcore.in: Add '--readnever' option when invoking GDB.
10792
10793 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10794
10795         * MAINTAINERS: Update my email address.
10796
10797 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10798
10799         * build-id.c (build_id_to_debug_bfd_1): New function.
10800         (build_id_to_debug_bfd): Look for separate debug file in
10801         sysroot.
10802
10803 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10804
10805         * gdbarch.sh: Update the copyright year range that is placed into
10806         generated files.
10807
10808 2019-02-22  Keith Seitz  <keiths@redhat.com>
10809
10810         PR symtab/23853
10811         * linespec.c (create_sals_line_offset): Search for the default
10812         symtab's filename instead of its fullname.
10813
10814 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10815
10816         * NEWS: Update style defaults.
10817
10818 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10819
10820         * main.c (captured_main_1): Disable styling in batch mode.
10821
10822 2019-02-20  Tom Tromey  <tom@tromey.com>
10823
10824         * symtab.c (symtab_symbol_info): Fix typos.
10825
10826 2019-02-20  Tom Tromey  <tromey@adacore.com>
10827
10828         * findcmd.c (_initialize_mem_search): Use upper case for
10829         metasyntactic variables.
10830
10831 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10832
10833         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10834         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10835
10836 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10837
10838         * top.h (source_file_name): Change to std::string.
10839         * top.c (source_file_name): Likewise.
10840         (command_line_input): Adjust.
10841         * cli/cli-script.c (script_from_file): Adjust.
10842
10843 2019-02-19  Tom Tromey  <tromey@adacore.com>
10844
10845         * ravenscar-thread.c
10846         (ravenscar_thread_target::update_thread_list): Don't call
10847         ada_build_task_list.
10848         * ada-lang.h (ada_build_task_list): Don't declare.
10849         * ada-tasks.c (struct ada_tasks_inferior_data)
10850         <task_list_valid_p>: Now bool.
10851         (read_known_tasks, ada_task_list_changed)
10852         (ada_tasks_invalidate_inferior_data): Update.
10853         (read_known_tasks_array): Return bool.
10854         (read_known_tasks_list): Likewise.
10855         (read_known_tasks): Return void.
10856         (ada_build_task_list): Now static.
10857
10858 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10859
10860         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10861         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10862
10863 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10864
10865         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10866         variant for ada_tasks_pspace_data_handle and
10867         ada_tasks_inferior_data_handle.
10868         (ada_tasks_pspace_data_cleanup): New function.
10869         (ada_tasks_inferior_data_cleanup): New function.
10870
10871 2019-02-17  Tom Tromey  <tom@tromey.com>
10872
10873         * macrotab.h (macro_source_fullname): Return a std::string.
10874         * macrotab.c (macro_include, check_for_redefinition)
10875         (macro_undef, macro_lookup_definition, foreach_macro)
10876         (foreach_macro_in_scope): Update.
10877         (macro_source_fullname): Return a std::string.
10878         * macrocmd.c (show_pp_source_pos): Update.
10879
10880 2019-02-17  Tom Tromey  <tom@tromey.com>
10881
10882         * macrocmd.c (show_pp_source_pos): Style the file names.
10883
10884 2019-02-17  Tom Tromey  <tom@tromey.com>
10885
10886         PR tui/24197:
10887         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10888
10889 2019-02-17  Tom Tromey  <tom@tromey.com>
10890
10891         * ada-lang.c (user_select_syms): Use filtered printing.
10892         * utils.c (wrap_style): New global.
10893         (desired_style): Remove.
10894         (emit_style_escape): Add stream parameter.
10895         (set_output_style, reset_terminal_style, prompt_for_continue):
10896         Update.
10897         (flush_wrap_buffer): Only flush gdb_stdout.
10898         (wrap_here): Set wrap_style.
10899         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10900         treat escape sequences as a character.  Change when wrap buffer is
10901         flushed.
10902         (fputs_styled): Do not set the output style when the default is
10903         requested.
10904         * ui-style.h (struct ui_file_style) <is_default>: New method.
10905         * source.c (print_source_lines_base): Emit escape sequences in one
10906         piece.
10907
10908 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10909
10910         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10911         integers and enumeration types.
10912
10913 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10914
10915         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10916         instead of lookup_symbol_in_language
10917         (do_exact_match): New function.
10918         (ada_get_symbol_name_matcher): Return do_exact_match when
10919         doing a verbatim match.
10920
10921 2019-02-15  Tom Tromey  <tromey@adacore.com>
10922
10923         * ravenscar-thread.c (ravenscar_thread_target::resume)
10924         (ravenscar_thread_target::wait): Special case wildcard requests.
10925
10926 2019-02-15  Tom Tromey  <tromey@adacore.com>
10927
10928         * ravenscar-thread.c (base_ptid): Remove.
10929         (struct ravenscar_thread_target) <close>: New method.
10930         <m_base_ptid>: New member.
10931         <update_inferior_ptid, active_task, task_is_currently_active,
10932         runtime_initialized>: Declare methods.
10933         <ravenscar_thread_target>: Add constructor.
10934         (ravenscar_thread_target::task_is_currently_active)
10935         (ravenscar_thread_target::update_inferior_ptid)
10936         (ravenscar_runtime_initialized): Rename.  Now methods.
10937         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10938         (ravenscar_thread_target::update_thread_list): Update.
10939         (ravenscar_thread_target::active_task): Now method.
10940         (ravenscar_thread_target::store_registers)
10941         (ravenscar_thread_target::prepare_to_store)
10942         (ravenscar_thread_target::prepare_to_store)
10943         (ravenscar_thread_target::mourn_inferior): Update.
10944         (ravenscar_inferior_created): Use "new" to create target.
10945         (ravenscar_thread_target::get_ada_task_ptid): Update.
10946         (_initialize_ravenscar): Don't initialize base_ptid.
10947         (ravenscar_ops): Remove global.
10948
10949 2019-02-15  Tom Tromey  <tromey@adacore.com>
10950
10951         * target.h (push_target): Declare new overload.
10952         * target.c (push_target): New overload, taking an rvalue reference.
10953         * remote.c (remote_target::open_1): Use push_target overload.
10954         * corelow.c (core_target_open): Use push_target overload.
10955
10956 2019-02-15  Tom Tromey  <tromey@adacore.com>
10957
10958         * ravenscar-thread.c (is_ravenscar_task)
10959         (ravenscar_task_is_currently_active): Return bool.
10960         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10961         (_initialize_ravenscar): Remove "(void)".
10962         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10963         Return bool.
10964
10965 2019-02-15  Tom Tromey  <tromey@adacore.com>
10966
10967         * ravenscar-thread.c (ravenscar_runtime_initializer)
10968         (has_ravenscar_runtime, get_running_thread_id)
10969         (ravenscar_thread_target::resume): Fix indentation.
10970
10971 2019-02-15  Tom Tromey  <tromey@adacore.com>
10972
10973         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10974         from ravenscar_arch_ops.
10975         (sparc_ravenscar_ops::fetch_registers)
10976         (sparc_ravenscar_ops::store_registers): Now methods.
10977         (sparc_ravenscar_prepare_to_store): Remove.
10978         (sparc_ravenscar_ops): Redefine.
10979         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10980         methods and destructor.  Remove members.
10981         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10982         (ravenscar_thread_target::store_registers)
10983         (ravenscar_thread_target::prepare_to_store): Update.
10984         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10985         Remove.
10986         (struct ppc_ravenscar_powerpc_ops): Derive from
10987         ravenscar_arch_ops.
10988         (ppc_ravenscar_powerpc_ops::fetch_registers)
10989         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10990         (ppc_ravenscar_powerpc_ops): Redefine.
10991         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10992         (ppc_ravenscar_e500_ops::fetch_registers)
10993         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10994         (ppc_ravenscar_e500_ops): Redefine.
10995         * aarch64-ravenscar-thread.c
10996         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10997         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10998         (aarch64_ravenscar_fetch_registers)
10999         (aarch64_ravenscar_store_registers): Now methods.
11000         (aarch64_ravenscar_ops): Redefine.
11001
11002 2019-02-15  Tom Tromey  <tromey@adacore.com>
11003
11004         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11005         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11006         (ravenscar_thread_target::stopped_by_watchpoint)
11007         (ravenscar_thread_target::stopped_data_address)
11008         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11009
11010 2019-02-15  Tom Tromey  <tromey@adacore.com>
11011
11012         * ravenscar-thread.c: Fix some typos.
11013
11014 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11015             Tom Tromey  <tromey@adacore.com>
11016
11017         * ada-lang.c (ada_exception_sal): Change addr_string to a
11018         std::string.
11019         (create_ada_exception_catchpoint): Update.
11020
11021 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11022             Tom Tromey  <tromey@adacore.com>
11023
11024         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11025         (bp_location_ops): Remove.
11026         (base_breakpoint_allocate_location): Update.
11027         (free_bp_location): Update.
11028         * ada-lang.c (class ada_catchpoint_location)
11029         <ada_catchpoint_location>: Remove ops parameter.
11030         (ada_catchpoint_location_dtor): Remove.
11031         (ada_catchpoint_location_ops): Remove.
11032         (allocate_location_exception): Update.
11033         * breakpoint.h (struct bp_location_ops): Remove.
11034         (class bp_location) <bp_location>: Remove bp_location_ops
11035         parameter.
11036         <~bp_location>: Add destructor.
11037         <ops>: Remove.
11038
11039 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11040             Pedro Alves  <palves@redhat.com>
11041
11042         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11043         'PATH_MAX'.
11044
11045 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11046             Samuel Thibault  <samuel.thibault@gnu.org>
11047             Thomas Schwinge  <thomas@codesourcery.com>
11048
11049         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11050         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11051
11052 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11053
11054         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11055         (check_empty): Use "const char *".
11056
11057         * gnu-nat.c (gnu_nat_target::detach): Instead of
11058         'detach_inferior (pid)' call
11059         'detach_inferior (find_inferior_pid (pid))'.
11060
11061         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11062         'nat/fork-inferior.o'.
11063         * gnu-nat.c: #include "nat/fork-inferior.h".
11064
11065         * gnu-nat.c (gnu_nat_target::detach): Instead of
11066         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11067         * gnu-nat.h: #include "inf-child.h".
11068         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11069         'i386_gnu_nat_target::fetch_registers'.
11070         (gnu_store_registers): Rename/move to
11071         'i386_gnu_nat_target::store_registers'.
11072
11073         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11074         * gnu-nat.h (mach_thread_info): New function.
11075         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11076
11077         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11078
11079 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11080
11081         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11082
11083 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11084
11085         * windows-nat.c (windows_add_thread): Add new parameter
11086         "main_thread_p" with default value set to false.  Update
11087         function documentation as well as all callers.
11088         (windows_delete_thread): Likewise.
11089         (fake_create_process): Update call to windows_add_thread.
11090         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11091         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11092         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11093         call to windows_delete_thread.
11094
11095 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11096
11097         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11098
11099 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11100
11101         * symfile.c (find_separate_debug_file): Use canonical path of
11102         sysroot with child_path instead of gdb_sysroot if it is valid.
11103
11104 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11105
11106         * symfile.c (find_separate_debug_file): Use child_path to
11107         determine if an object file is under a sysroot.
11108
11109 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11110
11111         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11112         unittests/child-path-selftests.c.
11113         * common/pathstuff.c (child_path): New function.
11114         * common/pathstuff.h (child_path): New prototype.
11115         * unittests/child-path-selftests.c: New file.
11116
11117 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11118
11119         * symfile.c (find_separate_debug_file): Look for separate debug
11120         files in debug directories under the sysroot.
11121
11122 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11123
11124         * symtab.h (struct minimal_symbol data_p): New const method.
11125         (struct minimal_symbol text_p): Likewise.
11126         * symtab.c (output_source_filename): Use file name style
11127         to print file name.
11128         (print_symbol_info): Likewise.
11129         (print_msymbol_info): Use address style to print addresses.
11130         Use function name style to print executable text symbols.
11131         (expand_symtab_containing_pc): Use data_p.
11132         (find_pc_sect_compunit_symtab): Likewise.
11133
11134 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11135
11136         * breakpoint.c (describe_other_breakpoints): Use address style
11137         to print addresses.
11138         (say_where): Likewise.
11139
11140 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11141
11142         * ada-typeprint.c (print_func_type): Print function name
11143         style to print function name.
11144         * c-typeprint.c (c_print_type_1): Likewise.
11145
11146 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11147
11148         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11149         for execve.
11150
11151 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11152
11153         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11154         type_stack.
11155
11156 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11157
11158         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11159         TYPE_CODE_REF types.
11160
11161 2019-02-08  Jim Wilson  <jimw@sifive.com>
11162
11163         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11164         (riscv_linux_fregset): New.
11165         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11166
11167 2019-02-07  Tom Tromey  <tom@tromey.com>
11168
11169         * thread.c (thread_cancel_execution_command): Update.
11170         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11171         methods.
11172         (struct thread_fsm_ops): Remove.
11173         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11174         (thread_fsm_should_stop, thread_fsm_return_value)
11175         (thread_fsm_set_finished, thread_fsm_finished_p)
11176         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11177         Don't declare.
11178         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11179         * infrun.c (clear_proceed_status_thread)
11180         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11181         (print_stop_event): Update.
11182         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11183         Add constructor.
11184         (step_command_fsm_ops): Remove.
11185         (new_step_command_fsm): Remove.
11186         (step_1): Update.
11187         (step_command_fsm::should_stop): Rename from
11188         step_command_fsm_should_stop.
11189         (step_command_fsm::clean_up): Rename from
11190         step_command_fsm_clean_up.
11191         (step_command_fsm::do_async_reply_reason): Rename from
11192         step_command_fsm_async_reply_reason.
11193         (struct until_next_fsm): Inherit from thread_fsm.  Add
11194         constructor.
11195         (until_next_fsm_ops): Remove.
11196         (new_until_next_fsm): Remove.
11197         (until_next_fsm::should_stop): Rename from
11198         until_next_fsm_should_stop.
11199         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11200         (until_next_fsm::do_async_reply_reason): Rename from
11201         until_next_fsm_async_reply_reason.
11202         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11203         constructor.  Change type of breakpoint.
11204         (finish_command_fsm_ops): Remove.
11205         (new_finish_command_fsm): Remove.
11206         (finish_command_fsm::should_stop): Rename from
11207         finish_command_fsm_should_stop.
11208         (finish_command_fsm::clean_up): Rename from
11209         finish_command_fsm_clean_up.
11210         (finish_command_fsm::return_value): Rename from
11211         finish_command_fsm_return_value.
11212         (finish_command_fsm::do_async_reply_reason): Rename from
11213         finish_command_fsm_async_reply_reason.
11214         (finish_command): Update.
11215         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11216         Add constructor.
11217         (call_thread_fsm_ops): Remove.
11218         (call_thread_fsm::call_thread_fsm): Rename from
11219         new_call_thread_fsm.
11220         (call_thread_fsm::should_stop): Rename from
11221         call_thread_fsm_should_stop.
11222         (call_thread_fsm::should_notify_stop): Rename from
11223         call_thread_fsm_should_notify_stop.
11224         (run_inferior_call, call_function_by_hand_dummy): Update.
11225         * cli/cli-interp.c (should_print_stop_to_console): Update.
11226         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11227         Add constructor.  Change type of location_breakpoint,
11228         caller_breakpoint.
11229         (until_break_fsm_ops): Remove.
11230         (new_until_break_fsm): Remove.
11231         (until_break_fsm::should_stop): Rename from
11232         until_break_fsm_should_stop.
11233         (until_break_fsm::clean_up): Rename from
11234         until_break_fsm_clean_up.
11235         (until_break_fsm::do_async_reply_reason): Rename from
11236         until_break_fsm_async_reply_reason.
11237         (until_break_command): Update.
11238         * thread-fsm.c: Remove.
11239         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11240
11241 2019-02-07  Tom Tromey  <tom@tromey.com>
11242
11243         * yy-remap.h: Add include guard.
11244         * xtensa-tdep.h: Add include guard.
11245         * xcoffread.h: Rename include guard.
11246         * varobj-iter.h: Add include guard.
11247         * tui/tui.h: Rename include guard.
11248         * tui/tui-winsource.h: Rename include guard.
11249         * tui/tui-wingeneral.h: Rename include guard.
11250         * tui/tui-windata.h: Rename include guard.
11251         * tui/tui-win.h: Rename include guard.
11252         * tui/tui-stack.h: Rename include guard.
11253         * tui/tui-source.h: Rename include guard.
11254         * tui/tui-regs.h: Rename include guard.
11255         * tui/tui-out.h: Rename include guard.
11256         * tui/tui-layout.h: Rename include guard.
11257         * tui/tui-io.h: Rename include guard.
11258         * tui/tui-hooks.h: Rename include guard.
11259         * tui/tui-file.h: Rename include guard.
11260         * tui/tui-disasm.h: Rename include guard.
11261         * tui/tui-data.h: Rename include guard.
11262         * tui/tui-command.h: Rename include guard.
11263         * tic6x-tdep.h: Add include guard.
11264         * target/waitstatus.h: Rename include guard.
11265         * target/wait.h: Rename include guard.
11266         * target/target.h: Rename include guard.
11267         * target/resume.h: Rename include guard.
11268         * target-float.h: Rename include guard.
11269         * stabsread.h: Add include guard.
11270         * rs6000-tdep.h: Add include guard.
11271         * riscv-fbsd-tdep.h: Add include guard.
11272         * regformats/regdef.h: Rename include guard.
11273         * record.h: Rename include guard.
11274         * python/python.h: Rename include guard.
11275         * python/python-internal.h: Rename include guard.
11276         * python/py-stopevent.h: Rename include guard.
11277         * python/py-ref.h: Rename include guard.
11278         * python/py-record.h: Rename include guard.
11279         * python/py-record-full.h: Rename include guard.
11280         * python/py-record-btrace.h: Rename include guard.
11281         * python/py-instruction.h: Rename include guard.
11282         * python/py-events.h: Rename include guard.
11283         * python/py-event.h: Rename include guard.
11284         * procfs.h: Add include guard.
11285         * proc-utils.h: Add include guard.
11286         * p-lang.h: Add include guard.
11287         * or1k-tdep.h: Rename include guard.
11288         * observable.h: Rename include guard.
11289         * nto-tdep.h: Rename include guard.
11290         * nat/x86-linux.h: Rename include guard.
11291         * nat/x86-linux-dregs.h: Rename include guard.
11292         * nat/x86-gcc-cpuid.h: Add include guard.
11293         * nat/x86-dregs.h: Rename include guard.
11294         * nat/x86-cpuid.h: Rename include guard.
11295         * nat/ppc-linux.h: Rename include guard.
11296         * nat/mips-linux-watch.h: Rename include guard.
11297         * nat/linux-waitpid.h: Rename include guard.
11298         * nat/linux-ptrace.h: Rename include guard.
11299         * nat/linux-procfs.h: Rename include guard.
11300         * nat/linux-osdata.h: Rename include guard.
11301         * nat/linux-nat.h: Rename include guard.
11302         * nat/linux-namespaces.h: Rename include guard.
11303         * nat/linux-btrace.h: Rename include guard.
11304         * nat/glibc_thread_db.h: Rename include guard.
11305         * nat/gdb_thread_db.h: Rename include guard.
11306         * nat/gdb_ptrace.h: Rename include guard.
11307         * nat/fork-inferior.h: Rename include guard.
11308         * nat/amd64-linux-siginfo.h: Rename include guard.
11309         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11310         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11311         * nat/aarch64-linux.h: Rename include guard.
11312         * nat/aarch64-linux-hw-point.h: Rename include guard.
11313         * mn10300-tdep.h: Add include guard.
11314         * mips-linux-tdep.h: Add include guard.
11315         * mi/mi-parse.h: Rename include guard.
11316         * mi/mi-out.h: Rename include guard.
11317         * mi/mi-main.h: Rename include guard.
11318         * mi/mi-interp.h: Rename include guard.
11319         * mi/mi-getopt.h: Rename include guard.
11320         * mi/mi-console.h: Rename include guard.
11321         * mi/mi-common.h: Rename include guard.
11322         * mi/mi-cmds.h: Rename include guard.
11323         * mi/mi-cmd-break.h: Rename include guard.
11324         * m2-lang.h: Add include guard.
11325         * location.h: Rename include guard.
11326         * linux-record.h: Rename include guard.
11327         * linux-nat.h: Add include guard.
11328         * linux-fork.h: Add include guard.
11329         * i386-darwin-tdep.h: Rename include guard.
11330         * hppa-linux-offsets.h: Add include guard.
11331         * guile/guile.h: Rename include guard.
11332         * guile/guile-internal.h: Rename include guard.
11333         * gnu-nat.h: Rename include guard.
11334         * gdb-stabs.h: Rename include guard.
11335         * frv-tdep.h: Add include guard.
11336         * f-lang.h: Add include guard.
11337         * event-loop.h: Add include guard.
11338         * darwin-nat.h: Rename include guard.
11339         * cp-abi.h: Rename include guard.
11340         * config/sparc/nm-sol2.h: Rename include guard.
11341         * config/nm-nto.h: Rename include guard.
11342         * config/nm-linux.h: Add include guard.
11343         * config/i386/nm-i386gnu.h: Rename include guard.
11344         * config/djgpp/nl_types.h: Rename include guard.
11345         * config/djgpp/langinfo.h: Rename include guard.
11346         * compile/gcc-cp-plugin.h: Add include guard.
11347         * compile/gcc-c-plugin.h: Add include guard.
11348         * compile/compile.h: Rename include guard.
11349         * compile/compile-object-run.h: Rename include guard.
11350         * compile/compile-object-load.h: Rename include guard.
11351         * compile/compile-internal.h: Rename include guard.
11352         * compile/compile-cplus.h: Rename include guard.
11353         * compile/compile-c.h: Rename include guard.
11354         * common/xml-utils.h: Rename include guard.
11355         * common/x86-xstate.h: Rename include guard.
11356         * common/version.h: Rename include guard.
11357         * common/vec.h: Rename include guard.
11358         * common/tdesc.h: Rename include guard.
11359         * common/selftest.h: Rename include guard.
11360         * common/scoped_restore.h: Rename include guard.
11361         * common/scoped_mmap.h: Rename include guard.
11362         * common/scoped_fd.h: Rename include guard.
11363         * common/safe-iterator.h: Rename include guard.
11364         * common/run-time-clock.h: Rename include guard.
11365         * common/refcounted-object.h: Rename include guard.
11366         * common/queue.h: Rename include guard.
11367         * common/ptid.h: Rename include guard.
11368         * common/print-utils.h: Rename include guard.
11369         * common/preprocessor.h: Rename include guard.
11370         * common/pathstuff.h: Rename include guard.
11371         * common/observable.h: Rename include guard.
11372         * common/netstuff.h: Rename include guard.
11373         * common/job-control.h: Rename include guard.
11374         * common/host-defs.h: Rename include guard.
11375         * common/gdb_wait.h: Rename include guard.
11376         * common/gdb_vecs.h: Rename include guard.
11377         * common/gdb_unlinker.h: Rename include guard.
11378         * common/gdb_unique_ptr.h: Rename include guard.
11379         * common/gdb_tilde_expand.h: Rename include guard.
11380         * common/gdb_sys_time.h: Rename include guard.
11381         * common/gdb_string_view.h: Rename include guard.
11382         * common/gdb_splay_tree.h: Rename include guard.
11383         * common/gdb_setjmp.h: Rename include guard.
11384         * common/gdb_ref_ptr.h: Rename include guard.
11385         * common/gdb_optional.h: Rename include guard.
11386         * common/gdb_locale.h: Rename include guard.
11387         * common/gdb_assert.h: Rename include guard.
11388         * common/filtered-iterator.h: Rename include guard.
11389         * common/filestuff.h: Rename include guard.
11390         * common/fileio.h: Rename include guard.
11391         * common/environ.h: Rename include guard.
11392         * common/common-utils.h: Rename include guard.
11393         * common/common-types.h: Rename include guard.
11394         * common/common-regcache.h: Rename include guard.
11395         * common/common-inferior.h: Rename include guard.
11396         * common/common-gdbthread.h: Rename include guard.
11397         * common/common-exceptions.h: Rename include guard.
11398         * common/common-defs.h: Rename include guard.
11399         * common/common-debug.h: Rename include guard.
11400         * common/cleanups.h: Rename include guard.
11401         * common/buffer.h: Rename include guard.
11402         * common/btrace-common.h: Rename include guard.
11403         * common/break-common.h: Rename include guard.
11404         * cli/cli-utils.h: Rename include guard.
11405         * cli/cli-style.h: Rename include guard.
11406         * cli/cli-setshow.h: Rename include guard.
11407         * cli/cli-script.h: Rename include guard.
11408         * cli/cli-interp.h: Rename include guard.
11409         * cli/cli-decode.h: Rename include guard.
11410         * cli/cli-cmds.h: Rename include guard.
11411         * charset-list.h: Add include guard.
11412         * buildsym-legacy.h: Rename include guard.
11413         * bfin-tdep.h: Add include guard.
11414         * ax.h: Rename include guard.
11415         * arm-linux-tdep.h: Add include guard.
11416         * arm-fbsd-tdep.h: Add include guard.
11417         * arch/xtensa.h: Rename include guard.
11418         * arch/tic6x.h: Add include guard.
11419         * arch/i386.h: Add include guard.
11420         * arch/arm.h: Rename include guard.
11421         * arch/arm-linux.h: Rename include guard.
11422         * arch/arm-get-next-pcs.h: Rename include guard.
11423         * arch/amd64.h: Add include guard.
11424         * arch/aarch64-insn.h: Rename include guard.
11425         * arch-utils.h: Rename include guard.
11426         * annotate.h: Add include guard.
11427         * amd64-darwin-tdep.h: Rename include guard.
11428         * aarch64-linux-tdep.h: Add include guard.
11429         * aarch64-fbsd-tdep.h: Add include guard.
11430         * aarch32-linux-nat.h: Add include guard.
11431
11432 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11433
11434         * macrotab.c (macro_define_internal): New function that
11435         factorizes macro_define_object_internal and macro_define_function
11436         code.
11437         (macro_define_object_internal): Use macro_define_internal.
11438         (macro_define_function): Likewise.
11439
11440 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11441
11442         * macrocmd.c (extract_identifier): Return
11443         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11444         callers.
11445
11446 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11447
11448         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11449
11450 2019-02-05  Tom Tromey  <tom@tromey.com>
11451
11452         * target.c (target_stack::unpush): Move assertion earlier.
11453
11454 2019-01-30  Tom Tromey  <tom@tromey.com>
11455
11456         PR python/23615:
11457         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11458         (gdbpy_parse_and_eval): Likewise.
11459         * python/python-internal.h (gdbpy_allow_threads): New class.
11460
11461 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11462
11463         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11464         (aarch64_fbsd_fpregmap): Move earlier.
11465         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11466         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11467         instead of individual calls to trad_frame_set_reg_addr.
11468         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11469         earlier.
11470         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11471         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11472         instead of individual calls to trad_frame_set_reg_addr.
11473
11474 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11475
11476         * CONTRIBUTE: Replace contribution list with wiki link.
11477
11478 2019-01-25  Tom Tromey  <tom@tromey.com>
11479
11480         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11481
11482 2019-01-25  Tom Tromey  <tom@tromey.com>
11483
11484         * xtensa-linux-nat.c: Fix common/ includes.
11485         * xml-support.h: Fix common/ includes.
11486         * xml-support.c: Fix common/ includes.
11487         * x86-linux-nat.c: Fix common/ includes.
11488         * windows-nat.c: Fix common/ includes.
11489         * varobj.h: Fix common/ includes.
11490         * varobj.c: Fix common/ includes.
11491         * value.c: Fix common/ includes.
11492         * valops.c: Fix common/ includes.
11493         * utils.c: Fix common/ includes.
11494         * unittests/xml-utils-selftests.c: Fix common/ includes.
11495         * unittests/utils-selftests.c: Fix common/ includes.
11496         * unittests/unpack-selftests.c: Fix common/ includes.
11497         * unittests/tracepoint-selftests.c: Fix common/ includes.
11498         * unittests/style-selftests.c: Fix common/ includes.
11499         * unittests/string_view-selftests.c: Fix common/ includes.
11500         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11501         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11502         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11503         * unittests/rsp-low-selftests.c: Fix common/ includes.
11504         * unittests/parse-connection-spec-selftests.c: Fix common/
11505         includes.
11506         * unittests/optional-selftests.c: Fix common/ includes.
11507         * unittests/offset-type-selftests.c: Fix common/ includes.
11508         * unittests/observable-selftests.c: Fix common/ includes.
11509         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11510         * unittests/memrange-selftests.c: Fix common/ includes.
11511         * unittests/memory-map-selftests.c: Fix common/ includes.
11512         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11513         * unittests/function-view-selftests.c: Fix common/ includes.
11514         * unittests/environ-selftests.c: Fix common/ includes.
11515         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11516         * unittests/common-utils-selftests.c: Fix common/ includes.
11517         * unittests/cli-utils-selftests.c: Fix common/ includes.
11518         * unittests/array-view-selftests.c: Fix common/ includes.
11519         * ui-file.c: Fix common/ includes.
11520         * tui/tui-io.c: Fix common/ includes.
11521         * tracepoint.h: Fix common/ includes.
11522         * tracepoint.c: Fix common/ includes.
11523         * tracefile-tfile.c: Fix common/ includes.
11524         * top.h: Fix common/ includes.
11525         * top.c: Fix common/ includes.
11526         * thread.c: Fix common/ includes.
11527         * target/waitstatus.h: Fix common/ includes.
11528         * target/waitstatus.c: Fix common/ includes.
11529         * target.h: Fix common/ includes.
11530         * target.c: Fix common/ includes.
11531         * target-memory.c: Fix common/ includes.
11532         * target-descriptions.c: Fix common/ includes.
11533         * symtab.h: Fix common/ includes.
11534         * symfile.c: Fix common/ includes.
11535         * stap-probe.c: Fix common/ includes.
11536         * spu-linux-nat.c: Fix common/ includes.
11537         * sparc-nat.c: Fix common/ includes.
11538         * source.c: Fix common/ includes.
11539         * solib.c: Fix common/ includes.
11540         * solib-target.c: Fix common/ includes.
11541         * ser-unix.c: Fix common/ includes.
11542         * ser-tcp.c: Fix common/ includes.
11543         * ser-pipe.c: Fix common/ includes.
11544         * ser-base.c: Fix common/ includes.
11545         * selftest-arch.c: Fix common/ includes.
11546         * s12z-tdep.c: Fix common/ includes.
11547         * rust-exp.y: Fix common/ includes.
11548         * rs6000-aix-tdep.c: Fix common/ includes.
11549         * riscv-tdep.c: Fix common/ includes.
11550         * remote.c: Fix common/ includes.
11551         * remote-notif.h: Fix common/ includes.
11552         * remote-fileio.h: Fix common/ includes.
11553         * remote-fileio.c: Fix common/ includes.
11554         * regcache.h: Fix common/ includes.
11555         * regcache.c: Fix common/ includes.
11556         * record-btrace.c: Fix common/ includes.
11557         * python/python.c: Fix common/ includes.
11558         * python/py-type.c: Fix common/ includes.
11559         * python/py-inferior.c: Fix common/ includes.
11560         * progspace.h: Fix common/ includes.
11561         * producer.c: Fix common/ includes.
11562         * procfs.c: Fix common/ includes.
11563         * proc-api.c: Fix common/ includes.
11564         * printcmd.c: Fix common/ includes.
11565         * ppc-linux-nat.c: Fix common/ includes.
11566         * parser-defs.h: Fix common/ includes.
11567         * osdata.c: Fix common/ includes.
11568         * obsd-nat.c: Fix common/ includes.
11569         * nat/x86-linux.c: Fix common/ includes.
11570         * nat/x86-linux-dregs.c: Fix common/ includes.
11571         * nat/x86-dregs.h: Fix common/ includes.
11572         * nat/x86-dregs.c: Fix common/ includes.
11573         * nat/ppc-linux.c: Fix common/ includes.
11574         * nat/mips-linux-watch.h: Fix common/ includes.
11575         * nat/mips-linux-watch.c: Fix common/ includes.
11576         * nat/linux-waitpid.c: Fix common/ includes.
11577         * nat/linux-ptrace.h: Fix common/ includes.
11578         * nat/linux-ptrace.c: Fix common/ includes.
11579         * nat/linux-procfs.c: Fix common/ includes.
11580         * nat/linux-personality.c: Fix common/ includes.
11581         * nat/linux-osdata.c: Fix common/ includes.
11582         * nat/linux-namespaces.c: Fix common/ includes.
11583         * nat/linux-btrace.h: Fix common/ includes.
11584         * nat/linux-btrace.c: Fix common/ includes.
11585         * nat/fork-inferior.c: Fix common/ includes.
11586         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11587         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11588         * nat/aarch64-linux.c: Fix common/ includes.
11589         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11590         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11591         * namespace.h: Fix common/ includes.
11592         * mips-linux-tdep.c: Fix common/ includes.
11593         * minsyms.c: Fix common/ includes.
11594         * mi/mi-parse.h: Fix common/ includes.
11595         * mi/mi-main.c: Fix common/ includes.
11596         * mi/mi-cmd-env.c: Fix common/ includes.
11597         * memrange.h: Fix common/ includes.
11598         * memattr.c: Fix common/ includes.
11599         * maint.h: Fix common/ includes.
11600         * maint.c: Fix common/ includes.
11601         * main.c: Fix common/ includes.
11602         * machoread.c: Fix common/ includes.
11603         * location.c: Fix common/ includes.
11604         * linux-thread-db.c: Fix common/ includes.
11605         * linux-nat.c: Fix common/ includes.
11606         * linux-fork.c: Fix common/ includes.
11607         * inline-frame.c: Fix common/ includes.
11608         * infrun.c: Fix common/ includes.
11609         * inflow.c: Fix common/ includes.
11610         * inferior.h: Fix common/ includes.
11611         * inferior.c: Fix common/ includes.
11612         * infcmd.c: Fix common/ includes.
11613         * inf-ptrace.c: Fix common/ includes.
11614         * inf-child.c: Fix common/ includes.
11615         * ia64-linux-nat.c: Fix common/ includes.
11616         * i387-tdep.c: Fix common/ includes.
11617         * i386-tdep.c: Fix common/ includes.
11618         * i386-linux-tdep.c: Fix common/ includes.
11619         * i386-linux-nat.c: Fix common/ includes.
11620         * i386-go32-tdep.c: Fix common/ includes.
11621         * i386-fbsd-tdep.c: Fix common/ includes.
11622         * i386-fbsd-nat.c: Fix common/ includes.
11623         * guile/scm-type.c: Fix common/ includes.
11624         * guile/guile.c: Fix common/ includes.
11625         * go32-nat.c: Fix common/ includes.
11626         * gnu-nat.c: Fix common/ includes.
11627         * gdbthread.h: Fix common/ includes.
11628         * gdbarch-selftests.c: Fix common/ includes.
11629         * gdb_usleep.c: Fix common/ includes.
11630         * gdb_select.h: Fix common/ includes.
11631         * gdb_bfd.c: Fix common/ includes.
11632         * gcore.c: Fix common/ includes.
11633         * fork-child.c: Fix common/ includes.
11634         * findvar.c: Fix common/ includes.
11635         * fbsd-nat.c: Fix common/ includes.
11636         * event-top.c: Fix common/ includes.
11637         * event-loop.c: Fix common/ includes.
11638         * dwarf2read.c: Fix common/ includes.
11639         * dwarf2loc.c: Fix common/ includes.
11640         * dwarf2-frame.c: Fix common/ includes.
11641         * dwarf-index-cache.c: Fix common/ includes.
11642         * dtrace-probe.c: Fix common/ includes.
11643         * disasm-selftests.c: Fix common/ includes.
11644         * defs.h: Fix common/ includes.
11645         * csky-tdep.c: Fix common/ includes.
11646         * cp-valprint.c: Fix common/ includes.
11647         * cp-support.h: Fix common/ includes.
11648         * cp-support.c: Fix common/ includes.
11649         * corelow.c: Fix common/ includes.
11650         * completer.h: Fix common/ includes.
11651         * completer.c: Fix common/ includes.
11652         * compile/compile.c: Fix common/ includes.
11653         * compile/compile-loc2c.c: Fix common/ includes.
11654         * compile/compile-cplus-types.c: Fix common/ includes.
11655         * compile/compile-cplus-symbols.c: Fix common/ includes.
11656         * command.h: Fix common/ includes.
11657         * cli/cli-dump.c: Fix common/ includes.
11658         * cli/cli-cmds.c: Fix common/ includes.
11659         * charset.c: Fix common/ includes.
11660         * build-id.c: Fix common/ includes.
11661         * btrace.h: Fix common/ includes.
11662         * btrace.c: Fix common/ includes.
11663         * breakpoint.h: Fix common/ includes.
11664         * breakpoint.c: Fix common/ includes.
11665         * ax.h:
11666         (enum agent_op): Fix common/ includes.
11667         * ax-general.c (struct aop_map): Fix common/ includes.
11668         * ax-gdb.c: Fix common/ includes.
11669         * auxv.c: Fix common/ includes.
11670         * auto-load.c: Fix common/ includes.
11671         * arm-tdep.c: Fix common/ includes.
11672         * arch/riscv.c: Fix common/ includes.
11673         * arch/ppc-linux-common.c: Fix common/ includes.
11674         * arch/i386.c: Fix common/ includes.
11675         * arch/arm.c: Fix common/ includes.
11676         * arch/arm-linux.c: Fix common/ includes.
11677         * arch/arm-get-next-pcs.c: Fix common/ includes.
11678         * arch/amd64.c: Fix common/ includes.
11679         * arch/aarch64.c: Fix common/ includes.
11680         * arch/aarch64-insn.c: Fix common/ includes.
11681         * arch-utils.c: Fix common/ includes.
11682         * amd64-windows-tdep.c: Fix common/ includes.
11683         * amd64-tdep.c: Fix common/ includes.
11684         * amd64-sol2-tdep.c: Fix common/ includes.
11685         * amd64-obsd-tdep.c: Fix common/ includes.
11686         * amd64-nbsd-tdep.c: Fix common/ includes.
11687         * amd64-linux-tdep.c: Fix common/ includes.
11688         * amd64-linux-nat.c: Fix common/ includes.
11689         * amd64-fbsd-tdep.c: Fix common/ includes.
11690         * amd64-fbsd-nat.c: Fix common/ includes.
11691         * amd64-dicos-tdep.c: Fix common/ includes.
11692         * amd64-darwin-tdep.c: Fix common/ includes.
11693         * agent.c: Fix common/ includes.
11694         * ada-lang.h: Fix common/ includes.
11695         * ada-lang.c: Fix common/ includes.
11696         * aarch64-tdep.c: Fix common/ includes.
11697
11698 2019-01-25  Tom Tromey  <tom@tromey.com>
11699
11700         * common/create-version.sh: Use common/version.h.
11701
11702 2019-01-24  Pedro Alves  <palves@redhat.com>
11703
11704         * infrun.c (signal_stop, signal_print, signal_program)
11705         (signal_catch, signal_pass): Now arrays instead of pointers.
11706         (update_signals_program_target, do_target_resume)
11707         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11708         * linux-nat.c (linux_nat_target::pass_signals)
11709         (linux_nat_target::create_inferior, linux_nat_target::attach):
11710         Adjust.
11711         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11712         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11713         * procfs.c (procfs_target::pass_signals): Adjust.
11714         * record-full.c (record_full_target::resume): Adjust.
11715         * remote.c (remote_target::pass_signals)
11716         (remote_target::program_signals): Adjust.
11717         * target-debug.h (target_debug_print_signals): Now takes a
11718         gdb::array_view as parameter.  Adjust.
11719         * target.h (target_ops) <pass_signals, program_signals>: Replace
11720         pointer and length parameters with gdb::array_view.
11721         (target_pass_signals, target_program_signals): Likewise.
11722         * target-delegates.c: Regenerate.
11723
11724 2019-01-24  Pedro Alves  <palves@redhat.com>
11725
11726         * common/forward-scope-exit.h
11727         (forward_scope_exit::forward_scope_exit): Pass arguments to
11728         m_bind_function directly, instead of creating a std::bind and
11729         copying that.
11730
11731 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11732
11733         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11734         for static members.
11735         (pass_in_v_vfp_candidate): Likewise.
11736
11737 2019-01-23  Tom Tromey  <tom@tromey.com>
11738             Pedro Alves  <palves@redhat.com>
11739
11740         * regcache.c (class regcache_invalidator): Remove.
11741         (regcache::raw_write): Use make_scope_exit.
11742
11743 2019-01-23  Tom Tromey  <tom@tromey.com>
11744
11745         * ui-out.h (class ui_out_emit_type): Update comment.
11746
11747 2019-01-23  Tom Tromey  <tom@tromey.com>
11748
11749         * infrun.c (fetch_inferior_event): Update comment.
11750
11751 2019-01-23  Tom Tromey  <tom@tromey.com>
11752             Pedro Alves  <palves@redhat.com>
11753
11754         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11755         parameter.
11756         (fetch_inferior_event): Use SCOPE_EXIT.
11757
11758
11759 2019-01-23  Tom Tromey  <tom@tromey.com>
11760             Pedro Alves  <palves@redhat.com>
11761
11762         * infrun.c (disable_thread_events): Delete.
11763         (stop_all_threads): Use SCOPE_EXIT.
11764
11765 2019-01-23  Tom Tromey  <tom@tromey.com>
11766             Pedro Alves  <palves@redhat.com>
11767
11768         * symfile.c: Include forward-scope-exit.h.
11769         (clear_symtab_users_cleanup): Replace forward declaration with
11770         a FORWARD_SCOPE_EXIT.
11771         (syms_from_objfile_1): Use the forward_scope_exit and
11772         gdb::optional instead of cleanup_function.
11773         (reread_symbols): Use the forward_scope_exit instead of
11774         cleanup_function.
11775         (clear_symtab_users_cleanup): Remove function.
11776
11777 2019-01-23  Tom Tromey  <tom@tromey.com>
11778             Pedro Alves  <palves@redhat.com>
11779
11780         * linux-nat.c: Include scope-exit.h.
11781         (cleanup_target_stop): Remove.
11782         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11783         SCOPE_EXIT.
11784
11785 2019-01-23  Tom Tromey  <tom@tromey.com>
11786             Pedro Alves  <palves@redhat.com>
11787
11788         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11789         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11790
11791 2019-01-23  Tom Tromey  <tom@tromey.com>
11792             Andrew Burgess  <andrew.burgess@embecosm.com>
11793             Pedro Alves  <palves@redhat.com>
11794
11795         * infrun.c (fetch_inferior_event): Use scope_exit.
11796         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11797         * top.c (execute_command): Use scope_exit.
11798         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11799         * utils.c (do_bpstat_clear_actions_cleanup)
11800         (make_bpstat_clear_actions_cleanup): Remove.
11801
11802 2019-01-23  Tom Tromey  <tom@tromey.com>
11803             Pedro Alves  <palves@redhat.com>
11804
11805         * infrun.c: Include "common/scope-exit.h"
11806         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11807         (wait_for_inferior): Use SCOPE_EXIT.
11808         (fetch_inferior_event): Use scope_exit.
11809
11810 2019-01-23  Tom Tromey  <tom@tromey.com>
11811             Pedro Alves  <palves@redhat.com>
11812
11813         * breakpoint.c (create_breakpoint): Remove cleanup.
11814
11815 2019-01-23  Tom Tromey  <tom@tromey.com>
11816             Andrew Burgess  <andrew.burgess@embecosm.com>
11817             Pedro Alves  <palves@redhat.com>
11818
11819 2019-01-23  Pedro Alves  <palves@redhat.com>
11820
11821         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11822
11823 2019-01-23  Pedro Alves  <palves@redhat.com>
11824             Andrew Burgess  <andrew.burgess@embecosm.com>
11825
11826         * gdbthread.h: Include "common/forward-scope-exit.h".
11827         (scoped_finish_thread_state): Redefine custom class in terms of
11828         forward_scope_exit.
11829
11830 2019-01-23  Pedro Alves  <palves@redhat.com>
11831             Andrew Burgess  <andrew.burgess@embecosm.com>
11832
11833         * common/forward-scope-exit.h: New file.
11834
11835 2019-01-23  Pedro Alves  <palves@redhat.com>
11836             Andrew Burgess  <andrew.burgess@embecosm.com>
11837             Tom Tromey  <tom@tromey.com>
11838
11839         * common/scope-exit.h: New file.
11840
11841 2019-01-23  Pedro Alves  <palves@redhat.com>
11842
11843         * common/preprocessor.h (ESC): Rename to ...
11844         (ESC_PARENS): ... this.
11845         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11846         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11847
11848 2019-01-23  Tom Tromey  <tom@tromey.com>
11849
11850         * language.h (class scoped_switch_to_sym_language_if_auto):
11851         Initialize m_lang in both cases.
11852
11853 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11854
11855         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11856         with XCNEW.
11857
11858 2019-01-22  Tom Tromey  <tom@tromey.com>
11859
11860         * corelow.c: Do not include sys/file.h.
11861
11862 2019-01-22  Tom Tromey  <tom@tromey.com>
11863
11864         * tui/tui-wingeneral.h: Include gdb_curses.h.
11865
11866 2019-01-22  Tom Tromey  <tom@tromey.com>
11867
11868         * source-cache.h (class source_cache) <get_source_lines,
11869         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11870
11871 2019-01-22  Tom Tromey  <tom@tromey.com>
11872
11873         * remote-fileio.h (struct remote_target): Declare.
11874
11875 2019-01-22  Tom Tromey  <tom@tromey.com>
11876
11877         * python/py-arch.c: Do not include py-ref.h.
11878         * python/py-bpevent.c: Do not include py-ref.h.
11879         * python/py-cmd.c: Do not include py-ref.h.
11880         * python/py-continueevent.c: Do not include py-ref.h.
11881         * python/py-event.h: Do not include py-ref.h.
11882         * python/py-evtregistry.c: Do not include py-ref.h.
11883         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11884         * python/py-frame.c: Do not include py-ref.h.
11885         * python/py-framefilter.c: Do not include py-ref.h.
11886         * python/py-function.c: Do not include py-ref.h.
11887         * python/py-infevents.c: Do not include py-ref.h.
11888         * python/py-linetable.c: Do not include py-ref.h.
11889         * python/py-objfile.c: Do not include py-ref.h.
11890         * python/py-param.c: Do not include py-ref.h.
11891         * python/py-prettyprint.c: Do not include py-ref.h.
11892         * python/py-progspace.c: Do not include py-ref.h.
11893         * python/py-symbol.c: Do not include py-ref.h.
11894         * python/py-symtab.c: Do not include py-ref.h.
11895         * python/py-type.c: Do not include py-ref.h.
11896         * python/py-unwind.c: Do not include py-ref.h.
11897         * python/py-utils.c: Do not include py-ref.h.
11898         * python/py-value.c: Do not include py-ref.h.
11899         * python/py-varobj.c: Do not include py-ref.h.
11900         * python/py-xmethods.c: Do not include py-ref.h.
11901         * python/python.c: Do not include py-ref.h.
11902         * varobj.c: Do not include py-ref.h.
11903
11904 2019-01-22  Tom Tromey  <tom@tromey.com>
11905
11906         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11907         keyword for bcache.
11908
11909 2019-01-22  Tom Tromey  <tom@tromey.com>
11910
11911         * compile/compile-cplus-types.c: Remove a comment by #include.
11912
11913 2019-01-22  Tom Tromey  <tom@tromey.com>
11914
11915         * compile/gcc-c-plugin.h: Include compile-internal.h.
11916
11917 2019-01-22  Tom Tromey  <tom@tromey.com>
11918
11919         * stabsread.c (EXTERN): Do not define.
11920         (symnum, next_symbol_text_func, processing_gcc_compilation)
11921         (within_function, global_sym_chain, global_stabs)
11922         (previous_stab_code, this_object_header_files)
11923         (n_this_object_header_files)
11924         (n_allocated_this_object_header_files): Define.
11925         * stabsread.h (EXTERN): Never define.  Use "extern".
11926
11927 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11928
11929         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11930         history_value.
11931
11932 2019-01-21  Tom Tromey  <tom@tromey.com>
11933
11934         * ui-out.c: Fix includes.
11935         * tui/tui-source.c: Fix includes.
11936         * target.c: Fix includes.
11937         * remote.c: Fix includes.
11938         * regcache.c: Fix includes.
11939         * python/py-block.c: Fix includes.
11940         * printcmd.c: Fix includes.
11941         * or1k-tdep.c: Fix includes.
11942         * mi/mi-main.c: Fix includes.
11943         * m32r-tdep.c: Fix includes.
11944         * csky-tdep.c: Fix includes.
11945         * compile/compile-cplus-types.c: Fix includes.
11946         * cli/cli-interp.c: Fix includes.
11947
11948 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11949
11950         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11951         for padding.
11952
11953 2019-01-16  Tom Tromey  <tom@tromey.com>
11954
11955         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11956         earlier.
11957         (struct objfile) <msymbols_range>: Move from top level.
11958         <msymbols>: New method.
11959         (class objfile_msymbols): Remove.
11960         * symtab.c (default_collect_symbol_completion_matches_break_on):
11961         Update.
11962         * symmisc.c (dump_msymbols): Update.
11963         * stabsread.c (scan_file_globals): Update.
11964         * objc-lang.c (info_selectors_command, info_classes_command)
11965         (find_methods): Update.
11966         * minsyms.c (find_solib_trampoline_target): Update.
11967         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11968         * coffread.c (coff_symfile_read): Update.
11969         * ada-lang.c (ada_lookup_simple_minsym)
11970         (ada_collect_symbol_completion_matches): Update.
11971
11972 2019-01-16  Tom Tromey  <tom@tromey.com>
11973
11974         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11975         type.  Remove no-argument constructor.
11976         <iterator::operator++>: Simplify.
11977         <begin>: Update.
11978         <end>: Use minimal_symbol_count.
11979
11980 2019-01-16  Tom Tromey  <tom@tromey.com>
11981
11982         * objfiles.h (struct objfile) <psymtabs>: New method.
11983         (class objfile_psymtabs): Remove.
11984         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11985         typedef.
11986         <range>: New method.
11987         (require_partial_symbols): Change return type.
11988         * psymtab.c (require_partial_symbols)
11989         (psym_expand_symtabs_matching): Update.
11990         * mdebugread.c (parse_partial_symbols): Update.
11991         * dbxread.c (dbx_end_psymtab): Update.
11992
11993 2019-01-15  Tom Tromey  <tom@tromey.com>
11994
11995         * symtab.c (lookup_objfile_from_block)
11996         (lookup_symbol_in_objfile_symtabs)
11997         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11998         (find_line_symtab, info_sources_command)
11999         (default_collect_symbol_completion_matches_break_on)
12000         (make_source_files_completion_list): Update.
12001         * symmisc.c (print_objfile_statistics, dump_objfile)
12002         (maintenance_print_symbols, maintenance_info_symtabs)
12003         (maintenance_check_symtabs, maintenance_info_line_tables):
12004         Update.
12005         * source.c (select_source_symtab)
12006         (forget_cached_source_info_for_objfile): Update.
12007         * objfiles.h (class objfile_compunits): Remove.
12008         (struct objfile) <compunits_range>: New typedef.
12009         (compunits): New method.
12010         * objfiles.c (objfile_relocate1): Update.
12011         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12012         * maint.c (count_symtabs_and_blocks): Update.
12013         * linespec.c (iterate_over_all_matching_symtabs): Update.
12014         * cp-support.c (add_symbol_overload_list_qualified): Update.
12015         * coffread.c (coff_symtab_read): Update.
12016         * ada-lang.c (add_nonlocal_symbols)
12017         (ada_collect_symbol_completion_matches)
12018         (ada_add_global_exceptions): Update.
12019
12020 2019-01-15  Tom Tromey  <tom@tromey.com>
12021
12022         * progspace.h (program_space) <objfiles_safe_range>: New
12023         typedef.
12024         <objfiles_safe>: New method.
12025         * objfiles.h (class all_objfiles_safe): Remove.
12026         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12027         * jit.c (jit_inferior_exit_hook): Update.
12028
12029 2019-01-17  Tom Tromey  <tom@tromey.com>
12030
12031         * progspace.h (program_space) <objfiles_range>: New typedef.
12032         <objfiles>: New method.
12033         <objfiles_head>: Rename from objfiles.
12034         (object_files): Update.
12035         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12036         * guile/scm-pretty-print.c
12037         (ppscm_find_pretty_printer_from_objfiles): Update.
12038         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12039         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12040         Update.
12041         * python/py-progspace.c (pspy_get_objfiles): Update.
12042         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12043         Update.
12044         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12045         (objfpy_lookup_objfile_by_build_id): Update.
12046         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12047         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12048         Update.
12049         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12050         (expand_symtab_containing_pc, lookup_objfile_from_block)
12051         (lookup_static_symbol, basic_lookup_transparent_type)
12052         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12053         (find_line_symtab, info_sources_command)
12054         (default_collect_symbol_completion_matches_break_on)
12055         (make_source_files_completion_list, find_main_name): Update.
12056         * symmisc.c (print_symbol_bcache_statistics)
12057         (print_objfile_statistics, maintenance_print_symbols)
12058         (maintenance_print_msymbols, maintenance_print_objfiles)
12059         (maintenance_info_symtabs, maintenance_check_symtabs)
12060         (maintenance_expand_symtabs, maintenance_info_line_tables):
12061         Update.
12062         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12063         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12064         (map_overlay_command, unmap_overlay_command)
12065         (simple_overlay_update, expand_symtabs_matching)
12066         (map_symbol_filenames): Update.
12067         * symfile-debug.c (set_debug_symfile): Update.
12068         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12069         Update.
12070         * source.c (select_source_symtab, forget_cached_source_info):
12071         Update.
12072         * solib.c (solib_read_symbols): Update.
12073         * solib-spu.c (append_ocl_sos): Update.
12074         * psymtab.c (maintenance_print_psymbols)
12075         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12076         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12077         * printcmd.c (info_symbol_command): Update.
12078         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12079         Update.
12080         * objfiles.h (class all_objfiles): Remove.
12081         * objfiles.c (have_partial_symbols, have_full_symbols)
12082         (have_minimal_symbols, qsort_cmp, update_section_map)
12083         (shared_objfile_contains_address_p)
12084         (default_iterate_over_objfiles_in_search_order): Update.
12085         * objc-lang.c (info_selectors_command, info_classes_command)
12086         (find_methods): Update.
12087         * minsyms.c (find_solib_trampoline_target): Update.
12088         * maint.c (maintenance_info_sections)
12089         (maintenance_translate_address, count_symtabs_and_blocks):
12090         Update.
12091         * main.c (captured_main_1): Update.
12092         * linux-thread-db.c (try_thread_db_load_from_pdir)
12093         (has_libpthread): Update.
12094         * linespec.c (iterate_over_all_matching_symtabs)
12095         (search_minsyms_for_name): Update.
12096         * jit.c (jit_find_objf_with_entry_addr): Update.
12097         * hppa-tdep.c (find_unwind_entry)
12098         (hppa_lookup_stub_minimal_symbol): Update.
12099         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12100         Update.
12101         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12102         (elf_gnu_ifunc_resolve_by_got): Update.
12103         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12104         * dwarf-index-write.c (save_gdb_index_command): Update.
12105         * cp-support.c (add_symbol_overload_list_qualified): Update.
12106         * breakpoint.c (create_overlay_event_breakpoint)
12107         (create_longjmp_master_breakpoint)
12108         (create_std_terminate_master_breakpoint)
12109         (create_exception_master_breakpoint): Update.
12110         * blockframe.c (find_pc_partial_function): Update.
12111         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12112         (ada_collect_symbol_completion_matches)
12113         (ada_add_global_exceptions): Update.
12114
12115 2019-01-17  Tom Tromey  <tom@tromey.com>
12116
12117         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12118         declare VEC.
12119         (solib_target_parse_libraries): Change return type.
12120         (library_list_start_segment, library_list_start_section)
12121         (library_list_end_library, library_list_start_library); Update.
12122         (solib_target_free_library_list): Remove.
12123         (solib_target_parse_libraries): Remove cleanup.  Change return
12124         type.
12125         (solib_target_current_sos): Update.
12126
12127 2019-01-17  Tom Tromey  <tromey@bapiya>
12128
12129         * valprint.c: Replace "the the" with "the".
12130         * symtab.c: Replace "the the" with "the".
12131         * solib.c: Replace "the the" with "the".
12132         * solib-dsbt.c: Replace "the the" with "the".
12133         * linespec.c: Replace "the the" with "the".
12134         * dwarf2loc.h: Replace "the the" with "the".
12135         * amd64-windows-tdep.c: Replace "the the" with "the".
12136         * aarch64-tdep.c: Replace "the the" with "the".
12137
12138 2019-01-16  Keith Seitz  <keiths@redhat.com>
12139
12140         PR gdb/23773
12141         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12142         <builder>: Rename to ..
12143         <m_builder>: ... this and make private.
12144         (dwarf2_cu::get_builder): New method.  Change all users of
12145         `builder' to use this method.
12146         (dwarf2_start_symtab): Move to ...
12147         (dwarf2_cu::start_symtab): ... here.  Update all callers
12148         (setup_type_unit_groups): Move to ...
12149         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12150         callers.
12151         (dwarf2_cu::reset_builder): New method.
12152         (process_full_compunit, process_full_type_unit): Use
12153         dwarf2_cu::reset_builder.
12154         (follow_die_offset): Record the ancestor CU if it is different
12155         from the followed DIE's CU.
12156         (follow_die_sig_1): Likewise.
12157
12158 2019-01-15  Tom Tromey  <tom@tromey.com>
12159
12160         * remote.c (class remote_state) <buf>: Now a char_vector.
12161         <buf_size>: Remove.
12162         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12163         parameter.
12164         (remote_target::getpkt_or_notif_sane_1)
12165         (remote_target::getpkt_sane)
12166         (remote_target::getpkt_or_notif_sane): Likewise.
12167         (class remote_target) <putpkt>: New overload.
12168         (remote_target::read_frame): Change type of "buf_p".  Remove
12169         sizeof_p parameter.
12170         (packet_ok): New overload.
12171         (packet_check_result): New overload.
12172         Update all uses.
12173
12174 2019-01-14  Tom Tromey  <tom@tromey.com>
12175
12176         * remote-notif.c (handle_notification, remote_notif_ack)
12177         (remote_notif_parse): Make "buf" const.
12178         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12179         const.
12180         (remote_notif_parse, remote_notif_ack, handle_notification):
12181         Likewise.
12182         * remote.c (remote_notif_stop_parse): Make "buf" const.
12183         (remote_target::remote_parse_stop_reply): Make "buf" const.
12184         (remote_notif_stop_ack): Make "buf" const.
12185
12186 2019-01-14  Tom Tromey  <tom@tromey.com>
12187
12188         * remote.c (remote_console_output): Make parameter const.
12189
12190 2019-01-14  Tom Tromey  <tom@tromey.com>
12191
12192         * target-debug.h (target_debug_print_signals): Constify.
12193         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12194         * procfs.c (procfs_target::pass_signals): Update.
12195         * linux-nat.c (linux_nat_target::pass_signals): Update.
12196         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12197         * target-delegates.c: Rebuild.
12198         * remote.c (remote_target::program_signals): Update.
12199         (remote_target::pass_signals): Update.
12200         * target.c (target_pass_signals): Constify argument.
12201         (target_program_signals): Likewise.
12202         * target.h (struct target_ops) <pass_signals, program_signals>:
12203         Constify argument.
12204         (target_pass_signals, target_program_signals): Constify argument.
12205
12206 2019-01-14  Tom Tromey  <tom@tromey.com>
12207
12208         PR tui/28819:
12209         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12210
12211 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12212
12213         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12214         field.
12215         * rs6000-tdep.c: Include reggroups.h.
12216         (IS_V_ALIAS_PSEUDOREG): Define.
12217         (rs6000_register_name): Return names for the "vX" aliases.
12218         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12219         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12220         aliases.  Call default_register_reggroup_p for all other
12221         pseudo-registers.
12222         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12223         New functions.
12224         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12225         Handle "vX" aliases.
12226         (v_alias_pseudo_register_collect): New function.
12227         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12228         (rs6000_gdbarch_init): Initialize "vX" aliases as
12229         pseudo-registers.  Restore registration of
12230         rs6000_pseudo_register_reggroup_p with
12231         set_tdesc_pseudo_register_reggroup_p.
12232
12233 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12234
12235         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12236         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12237         set_gdbarch_num_pseudo_regs.
12238
12239 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12240
12241         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12242         Remove arg prefixname, add do_set and do_show.
12243         Add member functions set_list and show_list.
12244         * cli/cli-style.c (class cli_style_option): Update accordingly.
12245         (style_set_list): Move to file scope.
12246         (style_show_list): Likewise.
12247         (set_style): Call help_list.
12248         (show_style): Call cmd_show_list.
12249         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12250         Update to use the new macro.
12251
12252 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12253
12254         * ada-lang.c (_initialize_ada_language): Expand the help text
12255         for the "catch exception" command.
12256
12257 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12258
12259         * symtab.c (matching_obj_sections): Initialize obj,
12260         declare it closer to its usage.
12261
12262 2019-01-10  Tom Tromey  <tom@tromey.com>
12263
12264         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12265         (basic_inf_threads_range): Remove.
12266         (inf_threads_range, inf_non_exited_threads_range)
12267         (safe_inf_threads_range): Use next_adapter.
12268
12269 2019-01-10  Keith Seitz  <keiths@redhat.com>
12270
12271         PR gdb/23712
12272         PR symtab/23010
12273         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12274         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12275
12276 2019-01-10  Keith Seitz  <keiths@redhat.com>
12277
12278         PR gdb/23712
12279         PR symtab/23010
12280         * dictionary.c (pending_to_vector): Remove.
12281         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12282         Remove _1 suffix, replacing functions of the same name.  Update
12283         all callers.
12284         (dict_create_hashed, dict_create_hashed_expandable)
12285         (dict_create_linear, dict_create_linear_expandable, dict_free)
12286         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12287         Make functions static.
12288
12289 2019-01-10  Keith Seitz  <keiths@redhat.com>
12290
12291         PR gdb/23712
12292         PR symtab/23010
12293         * dictionary.h (struct dictionary): Replace declaration with
12294         multidictionary.
12295         (dict_create_hashed, dict_create_hashed_expandable)
12296         (dict_create_linear, dict_create_linear_expandable)
12297         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12298         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12299         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12300         taking multidictionary argument.
12301         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12302         * block.h (struct block) <dict>: Change to multidictionary
12303         and rename `multidict'.
12304         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12305         symmisc.c: Update all dictionary references to multidictionary.
12306
12307 2019-01-10  Keith Seitz  <keiths@redhat.com>
12308
12309         PR gdb/23712
12310         PR symtab/23010
12311         * dictionary.c: Include unordered_map.
12312         (pending_to_vector): New function.
12313         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12314         Rewrite the non-"_1" functions to take vector instead
12315         of linked list.
12316         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12317         "new" _1 versions of the same name.
12318         (multidictionary): Define.
12319         (std::hash<enum language): New definition.
12320         (collate_pending_symbols_by_language, mdict_create_hashed)
12321         (mdict_create_hashed_expandable, mdict_create_linear)
12322         (mdict_create_linear_expandable, mdict_free)
12323         (find_language_dictionary, create_new_language_dictionary)
12324         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12325         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12326         (mdict_size, mdict_empty): New functions.
12327         * dictionary.h (mdict_iterator): Define.
12328
12329 2019-01-10  Pedro Alves  <palves@redhat.com>
12330
12331         * breakpoint.c (read_uploaded_action)
12332         (create_tracepoint_from_upload): Adjust to use
12333         gdb::unique_xmalloc_ptr.
12334         * ctf.c (ctf_write_uploaded_tp):
12335         (SET_ARRAY_FIELD): Use emplace_back.
12336         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12337         * tracefile-tfile.c (tfile_write_uploaded_tp):
12338         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12339         gdb::unique_xmalloc_ptr.
12340         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12341         at_string, cond_string, cmd_strings>: Replace char pointers
12342         with gdb::unique_xmalloc_ptr.
12343
12344 2019-01-10  Pedro Alves  <palves@redhat.com>
12345
12346         * solib-target.c (library_list_start_library): Don't xstrdup name.
12347
12348 2019-01-10  Pedro Alves  <palves@redhat.com>
12349
12350         * mdebugread.c (parse_partial_symbols): Use
12351         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12352
12353 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12354
12355         * linux-fork.c (scoped_switch_fork_info)
12356         <~scoped_switch_fork_info>: Fix incorrect variable name.
12357
12358 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12359
12360         * linux-fork.c (scoped_switch_fork_info)
12361         <scoped_switch_fork_info>: Make explicit.
12362         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12363
12364 2019-01-10  Tom Tromey  <tom@tromey.com>
12365
12366         * objfiles.h (objfile::reset_psymtabs): Update.
12367         * objfiles.c (objfile::objfile): Update.
12368         * psymtab.h (psymtab_storage::obstack): Update.
12369         (psymtab_storage::m_obstack): Use gdb::optional.
12370         (class psymtab_storage): Update comment.  Remove objfile
12371         parameter.
12372         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12373
12374 2019-01-10  Tom Tromey  <tom@tromey.com>
12375
12376         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12377         <free_psymtabs>: Now private.
12378         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12379         (allocate_psymtab): Use new method.
12380
12381 2019-01-10  Tom Tromey  <tom@tromey.com>
12382
12383         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12384         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12385         * mdebugread.c (parse_partial_symbols): Use
12386         allocate_dependencies.
12387         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12388         allocate_dependencies.
12389         (process_psymtab_comp_unit_reader)
12390         (build_type_psymtab_dependencies): Likewise.
12391         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12392
12393 2019-01-10  Tom Tromey  <tom@tromey.com>
12394
12395         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12396         PSYMBOL_SET_LANGUAGE.
12397         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12398
12399 2019-01-10  Tom Tromey  <tom@tromey.com>
12400
12401         * psymtab.h (psymtab_storage::obstack): New method.
12402         <m_obstack>: Rename from obstack; now private.
12403         * psymtab.c (psymtab_storage): Update.
12404         * dwarf2read.c (create_addrmap_from_index)
12405         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12406         Update.
12407
12408 2019-01-10  Tom Tromey  <tom@tromey.com>
12409
12410         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12411         * objfiles.h (objfile::reset_psymtabs): New method.
12412
12413 2019-01-10  Tom Tromey  <tom@tromey.com>
12414
12415         * symmisc.c (print_symbol_bcache_statistics): Update.
12416         (print_objfile_statistics): Update.
12417         * symfile.c (reread_symbols): Update.
12418         * psymtab.h (class psymtab_storage): New.
12419         * psymtab.c (psymtab_storage): New constructor.
12420         (~psymtab_storage): New destructor.
12421         (require_partial_symbols): Update.
12422         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12423         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12424         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12425         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12426         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12427         (start_psymtab_common, end_psymtab_common)
12428         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12429         (allocate_psymtab): Update.
12430         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12431         Update.
12432         (dump_psymtab_addrmap, maintenance_print_psymbols)
12433         (maintenance_check_psymtabs): Update.
12434         (class objfile_psymtabs): Move to objfiles.h.
12435         * psympriv.h (discard_psymtab): Now inline.
12436         (psymtab_discarder::psymtab_discarder): Update.
12437         (psymtab_discarder::~psymtab_discarder): Update.
12438         (ALL_OBJFILE_PSYMTABS): Rewrite.
12439         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12440         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12441         Remove fields.
12442         <partial_symtabs>: New field.
12443         (class objfile_psymtabs): Move from psymtab.h.  Update.
12444         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12445         psymbol_cache.
12446         (objfile::~objfile): Don't destroy psymbol_cache.
12447         * mdebugread.c (parse_partial_symbols): Update.
12448         * dwarf2read.c (create_addrmap_from_index)
12449         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12450         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12451         (add_partial_subprogram, dwarf2_ranges_read): Update.
12452         * dwarf-index-write.c (write_address_map)
12453         (write_one_signatured_type, recursively_write_psymbols)
12454         (class debug_names, class debug_names, write_psymtabs_to_index):
12455         Update.
12456
12457 2019-01-10  Tom Tromey  <tom@tromey.com>
12458
12459         * symtab.h (SYMBOL_SET_NAMES): Update.
12460         (symbol_set_names): Update.
12461         (MSYMBOL_SET_NAMES): Update.
12462         * symtab.c (symbol_set_names): Change argument to be an
12463         objfile_per_bfd_storage.
12464         * psymtab.c (add_psymbol_to_bcache): Update.
12465         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12466
12467 2019-01-10  Tom Tromey  <tom@tromey.com>
12468
12469         * symtab.c (create_demangled_names_hash): Change argument to be an
12470         objfile_per_bfd_storage.
12471         (symbol_set_names): Update.
12472
12473 2019-01-10  Tom Tromey  <tom@tromey.com>
12474
12475         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12476         init_psymbol_list.
12477         * psymtab.c (init_psymbol_list): Do nothing if already called.
12478         * psympriv.h (init_psymbol_list): Add comment.
12479         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12480         init_psymbol_list.
12481         * dbxread.c (dbx_symfile_read): Unconditionally call
12482         init_psymbol_list.
12483
12484 2019-01-10  Tom Tromey  <tom@tromey.com>
12485
12486         * xcoffread.c (scan_xcoff_symtab): Update.
12487         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12488         "where".
12489         * mdebugread.c (parse_partial_symbols)
12490         (handle_psymbol_enumerators): Update.
12491         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12492         * dbxread.c (read_dbx_symtab): Update.
12493         * psympriv.h (psymbol_placement): New enum.
12494         (add_psymbol_to_list): Update.
12495
12496 2019-01-10  Tom Tromey  <tom@tromey.com>
12497
12498         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12499         static_psymbols parameters.
12500         (scan_xcoff_symtab): Update.
12501         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12502         static_psymbols parameters.
12503         * psympriv.h (start_psymtab_common): Update.
12504         * mdebugread.c (parse_partial_symbols): Update.
12505         * dwarf2read.c (create_partial_symtab): Update.
12506         * dbxread.c (read_dbx_symtab): Update.
12507         (start_psymtab): Remove global_psymbols and static_psymbols
12508         parameters.
12509
12510 2019-01-10  Tom Tromey  <tom@tromey.com>
12511
12512         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12513         * psymtab.c (allocate_psymtab): Add comment.
12514         * psympriv.h (allocate_psymtab): Add comment.
12515         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12516         initializations.
12517         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12518
12519 2019-01-10  Tom Tromey  <tom@tromey.com>
12520
12521         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12522         Don't declare.
12523         * mipsread.c: Include mdebugread.h.
12524         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12525         Declare.
12526         * elfread.c: Include mdebugread.h.
12527
12528 2019-01-09  Tom Tromey  <tom@tromey.com>
12529
12530         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12531         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12532         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12533         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12534         (psym_lookup_symbol, psym_find_last_source_symtab)
12535         (psym_forget_cached_source_info, psym_print_stats)
12536         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12537         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12538         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12539         (psym_find_compunit_symtab_by_address)
12540         (maintenance_print_psymbols, maintenance_info_psymtabs)
12541         (maintenance_check_psymtabs): Use ranged for.
12542         * psymtab.h (class objfile_psymtabs): New.
12543         (require_partial_symbols): Return objfile_psymtabs.
12544         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12545
12546 2019-01-09  Tom Tromey  <tom@tromey.com>
12547
12548         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12549         (find_pc_mapped_section, list_overlays_command)
12550         (map_overlay_command, unmap_overlay_command)
12551         (simple_overlay_update): Use all_objfiles.
12552         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12553         * printcmd.c (info_symbol_command): Use all_objfiles.
12554         * objfiles.h (ALL_OBJSECTIONS): Remove.
12555         * maint.c (maintenance_translate_address): Use all_objfiles.
12556         * gcore.c (gcore_create_callback): Use all_objfiles.
12557         (objfile_find_memory_regions): Likewise.
12558
12559 2019-01-09  Tom Tromey  <tom@tromey.com>
12560
12561         * symtab.c (find_line_symtab, info_sources_command)
12562         (make_source_files_completion_list): Use objfile_compunits.
12563         * source.c (select_source_symtab): Use objfile_compunits.
12564         * objfiles.h (struct objfile): Update comment.
12565         (ALL_OBJFILES): Remove.
12566         (ALL_FILETABS): Remove.
12567         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12568         objfile_compunits.
12569
12570 2019-01-09  Tom Tromey  <tom@tromey.com>
12571
12572         * symmisc.c (print_objfile_statistics, dump_objfile)
12573         (maintenance_print_symbols): Use compunit_filetabs.
12574         * source.c (forget_cached_source_info_for_objfile): Use
12575         compunit_filetabs.
12576         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12577         (ALL_FILETABS): Use compunit_filetabs.
12578         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12579         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12580
12581 2019-01-09  Tom Tromey  <tom@tromey.com>
12582
12583         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12584         (compunit_filetabs): New.
12585         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12586         compunit_filetabs.
12587         (info_sources_command, make_source_files_completion_list): Remove
12588         declaration.
12589         * symmisc.c (print_objfile_statistics, dump_objfile)
12590         (maintenance_print_symbols): Remove declaration.
12591         (maintenance_info_symtabs): Use compunit_filetabs.
12592         (maintenance_info_line_tables): Likewise.
12593         * source.c (select_source_symtab): Change local variable name.
12594         (forget_cached_source_info_for_objfile): Remove declaration.
12595         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12596         * objfiles.c (objfile_relocate1): Remove declaration.
12597         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12598         declaration.
12599         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12600         * coffread.c (coff_symtab_read): Remove declaration.
12601         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12602         compunit_filetabs.
12603
12604 2019-01-09  Tom Tromey  <tom@tromey.com>
12605
12606         * symtab.c (lookup_objfile_from_block)
12607         (find_pc_sect_compunit_symtab, search_symbols)
12608         (default_collect_symbol_completion_matches_break_on): Use
12609         objfile_compunits.
12610         * objfiles.h (ALL_COMPUNITS): Remove.
12611         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12612         * cp-support.c (add_symbol_overload_list_qualified): Use
12613         objfile_compunits.
12614         * ada-lang.c (ada_collect_symbol_completion_matches)
12615         (ada_add_global_exceptions): Use objfile_compunits.
12616
12617 2019-01-09  Tom Tromey  <tom@tromey.com>
12618
12619         * source.c (select_source_symtab)
12620         (forget_cached_source_info_for_objfile): Remove declaration.
12621         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12622         declaration.
12623         * maint.c (count_symtabs_and_blocks): Remove declaration.
12624         * cp-support.c (add_symbol_overload_list_qualified): Remove
12625         declaration.
12626         * coffread.c (coff_symtab_read): Remove declaration.
12627         * symtab.c (lookup_symbol_in_objfile_symtabs)
12628         (basic_lookup_transparent_type_1): Use objfile_compunits.
12629         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12630         (info_sources_command, search_symbols)
12631         (default_collect_symbol_completion_matches_break_on)
12632         (make_source_files_completion_list): Remove declaration.
12633         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12634         (ada_collect_symbol_completion_matches)
12635         (ada_add_global_exceptions): Remove declaration.
12636         * linespec.c (iterate_over_all_matching_symtabs): Use
12637         objfile_compunits.
12638         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12639         (class objfile_compunits): New.
12640         (ALL_COMPUNITS): Use objfile_compunits.
12641         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12642         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12643         objfile_compunits.
12644         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12645
12646 2019-01-09  Tom Tromey  <tom@tromey.com>
12647
12648         * symtab.c (search_symbols)
12649         (default_collect_symbol_completion_matches_break_on): Use
12650         objfile_msymbols.
12651         * ada-lang.c (ada_lookup_simple_minsym)
12652         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12653         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12654         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12655         objfile_msymbols.
12656         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12657         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12658         * objc-lang.c (find_methods): Use objfile_msymbols.
12659         (info_selectors_command, info_classes_command): Likewise.
12660         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12661         * objfiles.h (class objfile_msymbols): New.
12662         (ALL_OBJFILE_MSYMBOLS): Remove.
12663         (ALL_MSYMBOLS): Remove.
12664
12665 2019-01-09  Tom Tromey  <tom@tromey.com>
12666
12667         * common/next-iterator.h (next_adapter): Add Iterator template
12668         parameter.
12669         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12670         (class all_objfiles_safe): New.
12671         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12672         * objfiles.c (put_objfile_before): Update comment.
12673         (add_separate_debug_objfile): Likewise.
12674         (free_all_objfiles): Use all_objfiles_safe.
12675         (objfile_purge_solibs): Likewise.
12676
12677 2019-01-09  Tom Tromey  <tom@tromey.com>
12678
12679         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12680         (expand_symtab_containing_pc, lookup_static_symbol)
12681         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12682         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12683         all_objfiles.
12684         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12685         * breakpoint.c (create_overlay_event_breakpoint)
12686         (create_longjmp_master_breakpoint)
12687         (create_std_terminate_master_breakpoint)
12688         (create_exception_master_breakpoint): Use all_objfiles.
12689         * linux-thread-db.c (try_thread_db_load_from_pdir)
12690         (has_libpthread): Use all_objfiles.
12691         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12692         * linespec.c (iterate_over_all_matching_symtabs)
12693         (search_minsyms_for_name): Use all_objfiles.
12694         * maint.c (maintenance_info_sections): Use all_objfiles.
12695         * main.c (captured_main_1): Use all_objfiles.
12696         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12697         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12698         * guile/scm-pretty-print.c
12699         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12700         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12701         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12702         (maintenance_print_msymbols): Use all_objfiles.
12703         * source.c (select_source_symtab): Use all_objfiles.
12704         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12705         * symfile.c (remove_symbol_file_command)
12706         (expand_symtabs_matching, map_symbol_filenames): Use
12707         all_objfiles.
12708         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12709         all_objfiles.
12710         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12711         * objc-lang.c (find_methods): Use all_objfiles.
12712         * objfiles.c (have_partial_symbols, have_full_symbols)
12713         (have_minimal_symbols, qsort_cmp)
12714         (default_iterate_over_objfiles_in_search_order): Use
12715         all_objfiles.
12716         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12717         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12718         (maintenance_check_psymtabs): Use all_objfiles.
12719         (ALL_PSYMTABS): Remove.
12720         * compile/compile-object-run.c (do_module_cleanup): Use
12721         all_objfiles.
12722         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12723         * cp-support.c (add_symbol_overload_list_qualified): Use
12724         all_objfiles.
12725         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12726         Use all_objfiles.
12727         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12728         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12729         all_objfiles.
12730         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12731         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12732         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12733         Uses all_objfiles.
12734         * solib.c (solib_read_symbols): Use all_objfiles
12735
12736 2019-01-09  Tom Tromey  <tom@tromey.com>
12737
12738         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12739         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12740         all_objfiles.
12741         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12742         * symmisc.c (print_symbol_bcache_statistics)
12743         (print_objfile_statistics, maintenance_print_objfiles)
12744         (maintenance_info_symtabs, maintenance_check_symtabs)
12745         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12746         all_objfiles.
12747         * source.c (forget_cached_source_info): Use all_objfiles.
12748         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12749         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12750         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12751         * objfiles.c (update_section_map): Use all_objfiles.
12752         (shared_objfile_contains_address_p): Likewise.
12753         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12754         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12755
12756 2019-01-09  Tom Tromey  <tom@tromey.com>
12757
12758         * common/next-iterator.h: New file.
12759         * objfiles.h (class all_objfiles): New.
12760         (struct objfile_iterator): New.
12761
12762 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12763
12764         * NEWS: Move the description of the changed "frame", "select-frame",
12765          and "info frame" commands to the Changed commands section.
12766
12767 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12768
12769         * gdbtypes.c (check_stub_method_group): Remove handling of old
12770         mangling schemes.
12771         * linespec.c (find_methods): Likewise.
12772         * stabsread.c (read_member_functions): Likewise.
12773         * valops.c (search_struct_method): Likewise.
12774         (value_struct_elt_for_reference): Likewise.
12775         * NEWS: Mention this change.
12776
12777 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12778
12779         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12780         print_source_lines.
12781         * source.c (print_source_lines_base): Update line number check.
12782         (print_source_lines): New function.
12783         (source_lines_range::source_lines_range): New function.
12784         * source.h (class source_lines_range): New class.
12785         (print_source_lines): New declaration.
12786
12787 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12788
12789         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12790
12791 2019-01-08  Tom Tromey  <tom@tromey.com>
12792             Simon Marchi  <simon.marchi@ericsson.com>
12793
12794         PR gdb/24060
12795         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12796         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12797         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12798         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12799         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12800         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12801
12802 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12803
12804         * source.c (select_source_symtab): Move header comment to
12805         declaration in source.h.
12806         (forget_cached_source_info_for_objfile): Likewise.
12807         (forget_cached_source_info): Likewise.
12808         (identify_source_line): Likewise.
12809         * source.h (identify_source_line): Move declaration from symtab.h
12810         and add comment from source.c
12811         (print_source_lines): Likewise.
12812         (forget_cached_source_info_for_objfile): Likewise.
12813         (forget_cached_source_info): Likewise.
12814         (select_source_symtab): Likewise.
12815         (enum print_source_lines_flag): Move definition from symtab.h.
12816         * symtab.h (identify_source_line): Move declaration to source.h.
12817         (print_source_lines): Likewise.
12818         (forget_cached_source_info_for_objfile): Likewise.
12819         (forget_cached_source_info): Likewise.
12820         (select_source_symtab): Likewise.
12821         (enum print_source_lines_flag): Move definition to source.h.
12822         * tui/tui-hooks.c: Add 'source.h' include.
12823
12824 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12825
12826         * source.c (print_source_lines_base): Handle requests to print
12827         reverse line number sequences, and guard against empty lines
12828         string.
12829
12830 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12831
12832         * source.c (print_source_lines_base): Fix skip of '\r' if next
12833         character is '\n'.
12834
12835 2019-01-06  Tom Tromey  <tom@tromey.com>
12836
12837         * c-exp.y (struct c_parse_state) <macro_original_text,
12838         expansion_obstack>: New member.
12839         (macro_original_text, expansion_obstack): Remove globals.
12840         (scan_macro_expansion, scanning_macro_expansion)
12841         (finished_macro_expansion): Update.
12842         (scan_macro_cleanup): Remove.
12843         (yylex, c_parse): Update.
12844
12845 2019-01-06  Tom Tromey  <tom@tromey.com>
12846
12847         * c-exp.y (struct c_parse_state) <strings>: New member.
12848         (operator_stoken): Update.
12849
12850 2019-01-06  Tom Tromey  <tom@tromey.com>
12851
12852         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12853         (union type_stack_elt) <typelist_val>: Now a pointer to
12854         std::vector.
12855         (type_stack_cleanup): Don't declare.
12856         (push_typelist): Update.
12857         * parse.c (pop_typelist): Return a std::vector.
12858         (push_typelist): Take a std::vector.
12859         (follow_types): Update.  Do not free args.
12860         (type_stack_cleanup): Remove.
12861         * c-exp.y (struct c_parse_state): New.
12862         (cpstate): New global.
12863         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12864         (nonempty_typelist): Update.
12865         (func_mod): Create a new vector.
12866         (c_parse): Create a c_parse_state.
12867         (check_parameter_typelist): Do not delete params.
12868         (function_method): Update.  Do not delete type_list.
12869
12870 2019-01-06  Tom Tromey  <tom@tromey.com>
12871
12872         PR gdb/28155:
12873         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12874         check_typedef.
12875         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12876         (print_return_value): Likewise.
12877
12878 2019-01-05  Tom Tromey  <tom@tromey.com>
12879
12880         * contrib/cleanup_check.py: Remove.
12881         * contrib/gcc-with-excheck: Remove.
12882         * contrib/exsummary.py: Remove.
12883         * contrib/excheck.py: Remove.
12884
12885 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12886
12887         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12888         NULL. Initialize tpprev to NULL instead of assigning it
12889         to NULL on the next statement.
12890         * windows-nat.c (windows_delete_thread): Remove check for
12891         main_thread_id before printing thread exit notifications.
12892         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12893         Remove thread ID check against main_thread_id.
12894         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12895         windows_delete_thread.
12896         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12897
12898 2019-01-04  Tom Tromey  <tom@tromey.com>
12899
12900         * compile/compile.c (_initialize_compile): Use upper case for
12901         metasyntactic variables.
12902         * symmisc.c (_initialize_symmisc): Use upper case for
12903         metasyntactic variables.
12904         * psymtab.c (_initialize_psymtab): Use upper case for
12905         metasyntactic variables.
12906         * demangle.c (demangle_command): Use upper case for metasyntactic
12907         variables.
12908         (_initialize_demangler): Likewise.
12909         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12910         variables.
12911
12912 2019-01-03  Tom Tromey  <tom@tromey.com>
12913
12914         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12915
12916 2019-01-03  Tom Tromey  <tom@tromey.com>
12917
12918         * python/py-symtab.c (salpy_str): Update.
12919         (struct salpy_sal_object) <symtab>: Now a PyObject.
12920         (salpy_dealloc): Update.
12921         (del_objfile_sal): Use gdbpy_ref.
12922
12923 2019-01-03  Tom Tromey  <tom@tromey.com>
12924
12925         * python/py-type.c (convert_field): Use new_reference.  Return
12926         gdbpy_ref.
12927         (make_fielditem): Return gdbpy_ref.
12928         (typy_fields): Update.
12929         (typy_getitem): Update.
12930         (field_name): Return gdbpy_ref.  Use new_reference.
12931         (typy_iterator_iternext): Update.
12932
12933 2019-01-03  Tom Tromey  <tom@tromey.com>
12934
12935         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12936
12937 2019-01-03  Tom Tromey  <tom@tromey.com>
12938
12939         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12940         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12941         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12942         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12943         (pspy_set_type_printers): Likewise.
12944         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12945         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12946         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12947         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12948         (objfpy_set_type_printers): Likewise.
12949
12950 2019-01-03  Tom Tromey  <tom@tromey.com>
12951
12952         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12953         (gdbpy_print_stack): Use gdbpy_err_fetch.
12954         * python/python-internal.h (class gdbpy_err_fetch): New class.
12955         (class gdbpy_enter) <m_error_type, m_error_value,
12956         m_error_traceback>: Remove.
12957         <m_error>: New member.
12958         (gdbpy_exception_to_string): Don't declare.
12959         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12960         * python/py-value.c (convert_value_from_python): Use
12961         gdbpy_err_fetch.
12962         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12963         gdbpy_exception_to_string.
12964         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12965         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12966         gdbpy_err_fetch.
12967
12968 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12969
12970         * linux-nat.c (delete_lwp_cleanup): Delete.
12971         (struct lwp_deleter): New struct.
12972         (lwp_info_up): New typedef.
12973         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12974         lwp_info_up.
12975
12976 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12977
12978         * linux-fork.c (class scoped_switch_fork_info): New class.
12979         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12980
12981 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12982
12983         * valops.c (find_overload_match): Remove use of null_cleanup, and
12984         calls to do_cleanups.
12985
12986 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12987
12988         * compile/compile-cplus-types.c
12989         (compile_cplus_instance::decl_name): Handle changes to
12990         cp_func_name.
12991         * cp-support.c (cp_func_name): Update header comment, update
12992         return type.
12993         * cp-support.h (cp_func_name): Update return type in declaration.
12994         * valops.c (find_overload_match): Move temp_func local to top
12995         level of function and change its type.  Use temp_func to hold and
12996         delete temporary string obtained from cp_func_name.
12997
12998 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12999
13000         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13001         gdb::char_vector, remove cleanup, and update uses of `msg`.
13002
13003 2019-01-03  Jim Wilson  <jimw@sifive.com>
13004
13005         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13006
13007 2019-01-02  Tom Tromey  <tom@tromey.com>
13008
13009         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13010         (tdesc_parse_xml): Remove cleanups.
13011         * target-descriptions.h (make_cleanup_free_target_description):
13012         Don't declare.
13013         (target_desc_deleter): New struct.
13014         (target_desc_up): New typedef.
13015         * target-descriptions.c (target_desc_deleter::operator()): Rename
13016         from free_target_description.
13017         (make_cleanup_free_target_description): Remove.
13018
13019 2019-01-02  Tom Tromey  <tom@tromey.com>
13020
13021         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13022         constructor, destructor.
13023         (linespec_parser): Remove typedef.
13024         (~linespec_parser): Rename from linespec_parser_delete.
13025         (linespec_lex_to_end, linespec_complete_label)
13026         (linespec_complete): Update.
13027         (decode_line_full): Remove cleanups.
13028         (decode_line_1): Update.
13029
13030 2019-01-02  Tom Tromey  <tom@tromey.com>
13031
13032         * python/python-internal.h (inferior_to_inferior_object): Change
13033         return type.
13034         * python/py-exitedevent.c (create_exited_event_object): Update.
13035         * python/py-inferior.c (inferior_to_inferior_object): Return
13036         gdbpy_ref.
13037         (python_new_inferior, python_inferior_deleted)
13038         (thread_to_thread_object, delete_thread_object)
13039         (build_inferior_list, gdbpy_selected_inferior): Update.
13040         * python/py-infthread.c (create_thread_object): Update.  Also fail
13041         if inferior_to_inferior_object fails.
13042
13043 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13044
13045         * inferior.h (class inferior) <displaced_step_state>: New field.
13046         * infrun.h (struct displaced_step_state): Move here from
13047         infrun.c.  Initialize fields, add constructor.
13048         <inf>: Remove field.
13049         <reset>: New method.
13050         * infrun.c (struct displaced_step_inferior_state): Move to
13051         infrun.h.
13052         (displaced_step_inferior_states): Remove.
13053         (get_displaced_stepping_state): Adust.
13054         (displaced_step_in_progress_any_inferior): Adjust.
13055         (displaced_step_in_progress_thread): Adjust.
13056         (displaced_step_in_progress): Adjust.
13057         (add_displaced_stepping_state): Remove.
13058         (get_displaced_step_closure_by_addr): Adjust.
13059         (remove_displaced_stepping_state): Remove.
13060         (infrun_inferior_exit): Call displaced_step_state.reset.
13061         (use_displaced_stepping): Don't check for NULL.
13062         (displaced_step_prepare_throw): Call
13063         get_displaced_stepping_state.
13064         (displaced_step_fixup): Don't check for NULL.
13065         (prepare_for_detach): Don't check for NULL.
13066
13067 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13068
13069         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13070          in case of call that did not complete.
13071
13072 2019-01-02  Andrey Utkin  <autkin@undo.io>
13073
13074         * symfile.c (find_separate_debug_file): Fix search of debug files for
13075         remote debuggee.
13076
13077 2019-01-02  Tom Tromey  <tom@tromey.com>
13078
13079         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13080         indentation.
13081         * python/py-frame.c (frapy_older): Remove cast.
13082         (frapy_newer): Likewise.
13083         * python/py-breakpoint.c (local_setattro): Remove cast.
13084         * python/py-arch.c (archpy_name): Remove local variable.
13085         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13086
13087 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13088
13089         * unittests/basic_string_view/element_access/char/empty.cc:
13090         Fix year range in copyright header.
13091
13092 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13093
13094         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13095         Delete.
13096         <operator==>: Update with for removed field.
13097         <hash>: Likewise.
13098         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13099         <isa_features>: ...this.
13100         <abi_features>: New field.
13101         (riscv_isa_flen): Update comment.
13102         (riscv_abi_xlen): New declaration.
13103         (riscv_abi_flen): New declaration.
13104         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13105         isa_features.
13106         (riscv_abi_xlen): New function.
13107         (riscv_isa_flen): Update to get answer from isa_features.
13108         (riscv_abi_flen): New function.
13109         (riscv_has_fp_abi): Update to get answer from abi_features.
13110         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13111         xlen and flen.
13112         (riscv_call_info) <xlen, flen>: Update comment.
13113         (riscv_call_arg_struct): Remove invalid assertions
13114         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13115         is removed.
13116         (riscv_gdbarch_init): Gather isa features and abi features
13117         separately, ensure both match on the gdbarch when reusing an old
13118         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13119         a target with 64-bit float hardware.
13120
13121 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13122
13123         * source.c (search_command_helper): Stop reverse search
13124         when line 1 has been searched.
13125
13126 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13127
13128         * record-full.c (record_full_base_target::close): Rewrite
13129         record_full_core_buf_list free logic.
13130
13131 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13132
13133         * break-catch-syscall.c (print_one_catch_syscall): xfree
13134         the last text.
13135
13136 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13137
13138         * top.c (print_gdb_version): Update Copyright year in version
13139         message.
13140
13141 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13142
13143         Update copyright year range in all GDB files.
13144
13145 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13146
13147         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13148
13149 For older changes see ChangeLog-2018.
13150 \f
13151 Local Variables:
13152 mode: change-log
13153 left-margin: 8
13154 fill-column: 74
13155 version-control: never
13156 coding: utf-8
13157 End:
13158