gdb/ChangeLog

   1 2019-07-01  Tom Tromey  <tromey@adacore.com>
   2
   3         * ada-exp.y (find_primitive_type): Update.
   4         * ada-lang.h (ada_lookup_symbol): Update.
   5         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
   6         parameter.
   7         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
   8
   9 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  10
  11         PR breakpoints/24541
  12         * gdbarch.c: Regenerate.
  13         * gdbarch.h: Regenerate.
  14         * gdbarch.sh: Add 'stap_adjust_register'.
  15         * i386-tdep.c: Include '<unordered_set>'.
  16         (i386_stap_adjust_register): New function.
  17         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
  18         * stap-probe.c (stap_parse_register_operand): Call
  19         'gdbarch_stap_adjust_register'.
  20
  21 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  22
  23         PR python/24742
  24         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
  25         * python/python.c (do_start_initialization): Use 'xmalloc'
  26         instead of 'PyMem_Malloc'.
  27
  28 2019-06-28  Tom Tromey  <tromey@adacore.com>
  29
  30         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
  31         for Ada.
  32
  33 2019-06-27  Tom Tromey  <tromey@adacore.com>
  34
  35         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
  36         objfile_key.
  37         (arm_find_mapping_symbol, arm_record_special_symbol)
  38         (_initialize_arm_tdep): Update.
  39         (arm_objfile_data_free): Remove.
  40
  41 2019-06-27  Tom Tromey  <tromey@adacore.com>
  42
  43         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
  44         to cp_print_static_field.
  45
  46 2019-06-26  Tom Tromey  <tromey@adacore.com>
  47
  48         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
  49         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
  50         declare.
  51
  52 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  53
  54         * features/aarch64-core.c (create_feature_aarch64_core):
  55         Regenerate.
  56         * features/aarch64-core.xml: Add cpsr flags.
  57
  58 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  59
  60         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
  61         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
  62
  63 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  64
  65         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
  66         field.
  67         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
  68         use.
  69         (arm_record_special_symbol): Don't insert new symbol in sorted
  70         position, push it at the end.
  71
  72 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  73
  74         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
  75         (arm_mapping_symbol_s): Remove.
  76         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
  77         (arm_mapping_symbol_vec): New typedef.
  78         (struct arm_per_objfile): Add constructor.
  79         <section_maps>: Change type to
  80         std::unique_ptr<arm_mapping_symbol_vec[]>.
  81         (arm_compare_mapping_symbols): Remove.
  82         (arm_find_mapping_symbol): Adjust to section_maps type change.
  83         (arm_objfile_data_free): Call delete on arm_per_objfile.
  84         (arm_record_special_symbol): Adjust to section_maps type change.
  85         Allocate arm_per_objfile with new.
  86
  87 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  88
  89         * cli/cli-cmds.c (alias_command): Compare the alias prefix
  90         with the command prefix.
  91
  92 2019-06-25  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
  95         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
  96
  97 2019-06-25  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 100         type.
 101         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 102         protected.
 103
 104 2019-06-25  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-winsource.c
 107         (tui_source_window_base::set_is_exec_point_at): Add check against
 108         LOA_ADDRESS.
 109
 110 2019-06-25  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-source.c (tui_set_source_content): Don't check before
 113         xfree.
 114         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 115
 116 2019-06-25  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-winsource.h (tui_update_source_window_as_is)
 119         (tui_alloc_source_buffer, tui_line_is_displayed)
 120         (tui_addr_is_displayed): Change type of win_info.
 121         * tui/tui-winsource.c (tui_update_source_window_as_is)
 122         (tui_clear_source_content, tui_show_source_line)
 123         (tui_show_source_content, tui_source_window_base::refill)
 124         (tui_source_window_base::set_is_exec_point_at)
 125         (tui_source_window_base::set_is_exec_point_at)
 126         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 127         (tui_alloc_source_buffer, tui_line_is_displayed)
 128         (tui_addr_is_displayed): Change type of win_info.  Update.
 129         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 130         (tui_source_window_base::do_make_visible_with_new_height):
 131         Update.
 132         * tui/tui-source.c (tui_set_source_content)
 133         (tui_set_source_content_nil)
 134         (tui_source_window::do_scroll_vertical): Update.
 135         * tui/tui-layout.c (show_layout): Update.
 136         * tui/tui-disasm.c (tui_set_disassem_content)
 137         (tui_disasm_window::do_scroll_vertical): Update.
 138         * tui/tui-data.h (tui_win_content): Remove.
 139         (struct tui_gen_win_info) <content, content_size>: Remove.
 140         (struct tui_source_element): Add initializers and destructor.
 141         (union tui_which_element, struct tui_win_element): Remove.
 142         (struct tui_source_window_base) <content>: New field.
 143         (struct tui_data_window): Remove destructor.
 144         (tui_alloc_content, tui_free_win_content)
 145         (tui_free_all_source_wins_content): Don't declare.
 146         * tui/tui-data.c (tui_initialize_static_data): Update.
 147         (init_content_element, tui_alloc_content): Remove.
 148         (~tui_gen_win_info): Update.
 149         (~tui_data_window, tui_free_all_source_wins_content)
 150         (tui_free_win_content, free_content, free_content_elements):
 151         Remove.
 152
 153 2019-06-25  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-winsource.h (tui_clear_source_content)
 156         (tui_erase_source_content, tui_show_source_content): Change type
 157         of win_info.
 158         * tui/tui-winsource.c (tui_clear_source_content)
 159         (tui_erase_source_content, tui_show_source_content): Change type
 160         of win_info.
 161         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 162         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 163         win_info.
 164         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 165         win_info.
 166         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 167
 168 2019-06-25  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-winsource.c (tui_clear_source_content)
 171         (tui_source_window_base::set_is_exec_point_at): Update.
 172         * tui/tui-source.c (tui_set_source_content_nil): Update.
 173         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 174         a bool.
 175         * tui/tui-data.c (init_content_element): Update.
 176
 177 2019-06-25  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 180         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 181         * tui/tui-layout.c (init_and_make_win): Update.
 182         * tui/tui.h (enum tui_win_type): Update.
 183         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 184         tui_win_is_auxillary.
 185         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 186         tui_win_is_auxillary.
 187
 188 2019-06-25  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 191         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 192         (tui_delete_data_content_windows, tui_display_all_data)
 193         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 194         Update.
 195         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 196         * tui/tui-regs.c (tui_last_regs_line_no)
 197         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 198         (tui_show_registers): Update.
 199         (tui_show_register_group): Return void.  Update.
 200         (tui_display_registers_from, tui_display_reg_element_at_line)
 201         (tui_display_registers_from_line, tui_check_register_values):
 202         Update.
 203         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 204         member.
 205         (struct tui_data_window) <regs_content>: Now a std::vector.
 206         <regs_content_count>: Remove.
 207         (tui_add_content_elements, tui_free_data_content): Don't declare.
 208         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 209         (init_content_element): Remove DATA_WIN case.  Add assert.
 210         (tui_add_content_elements): Remove.
 211         (tui_data_window): Update.
 212         (tui_free_data_content): Remove.
 213         (free_content_elements): Remove DATA_WIN case.
 214
 215 2019-06-25  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-data.c (tui_data_item_window): Update.
 218         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 219         * tui/tui-windata.c (tui_display_all_data)
 220         (tui_display_data_from_line): Update.
 221         (tui_check_data_values): Remove.
 222         * tui/tui-regs.c (tui_show_register_group)
 223         (tui_display_reg_element_at_line): Update.
 224         * tui/tui-hooks.c (tui_register_changed)
 225         (tui_refresh_frame_and_register_information): Call
 226         tui_check_register_values.
 227         * tui/tui-data.h (struct tui_data_window) <data_content,
 228         data_content_count, data_type>: Remove.
 229         (enum tui_data_type): Remove.
 230
 231         * tui/tui-data.c (tui_data_window::clear_detail)
 232         (~tui_data_window): Update.
 233
 234 2019-06-25  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 237         declare.
 238         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 239         Rename from tui_first_data_item_displayed.  Update.
 240         (tui_data_window::refresh_all)
 241         (tui_data_window::do_scroll_vertical): Update.
 242         * tui/tui-data.h (struct tui_data_window)
 243         <first_data_item_displayed>: Declare new method.
 244
 245 2019-06-25  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 248         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 249         contents...
 250         (tui_initialize_static_data): ...here.
 251
 252 2019-06-25  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 255         (tui_display_registers_from, tui_check_register_values): Update.
 256         (tui_display_register): Remove win_info parameter; update.
 257         (tui_get_register): Change type of parameters.
 258         * tui/tui-data.h (struct tui_data_element): Remove.
 259         (union tui_which_element) <data>: Remove.
 260         <data_window>: Change type.
 261         (struct tui_data_item_window): New.
 262         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 263         case.  Add assert.
 264         (~tui_data_item_window): New destructor.
 265         (free_content_elements): Remove DATA_ITEM_WIN case.
 266
 267 2019-06-25  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 270         Remove.
 271
 272 2019-06-25  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-data.h (struct tui_command_element): Remove.
 275         (union tui_which_element) <command>: Remove.
 276         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 277         assert.
 278         (free_content_elements): Remove CMD_WIN case.
 279
 280 2019-06-25  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-layout.c (tui_set_layout): Update.
 283         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 284         * tui/tui-data.c (layout_def): Update.
 285
 286 2019-06-25  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 289         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 290         (tui_source_window_base::set_new_height): Update.
 291         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 292         Update.
 293         (tui_set_locator_fullname, tui_set_locator_info)
 294         (tui_show_frame_info): Update.
 295         * tui/tui-source.c (tui_set_source_content)
 296         (tui_source_is_displayed): Update.
 297         * tui/tui-layout.c (show_source_disasm_command, show_data)
 298         (show_source_or_disasm_and_command): Update.
 299         * tui/tui-disasm.c (tui_set_disassem_content)
 300         (tui_get_begin_asm_address): Update.
 301         * tui/tui-data.h (struct tui_locator_element): Remove.
 302         (union tui_which_element) <locator>: Remove.
 303         (struct tui_locator_window): New.
 304         (tui_locator_win_info_ptr): Change return type.
 305         * tui/tui-data.c (_locator): Change type.
 306         (tui_locator_win_info_ptr): Change return type.
 307         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 308         (tui_alloc_content): Add assert.
 309
 310 2019-06-25  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-winsource.c
 313         (tui_exec_info_window::maybe_allocate_content): New method.
 314         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 315         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 316         (make_source_or_disasm_window): Add cast.
 317         * tui/tui-data.h (union tui_which_element) <simple_string>:
 318         Remove.
 319         (struct tui_source_info): New.
 320         (struct tui_source_window_base) <execution_info>: Change type.
 321         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 322         case, and add assert.
 323         (tui_alloc_content): Add assert.
 324
 325 2019-06-25  Tom Tromey  <tom@tromey.com>
 326
 327         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 328         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 329         * tui/tui-data.c (tui_alloc_win_info): Remove.
 330
 331 2019-06-25  Tom Tromey  <tom@tromey.com>
 332
 333         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 334         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 335         can_highlight.
 336
 337 2019-06-25  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 340         make_visible_with_new_height method.
 341         (tui_win_info::make_visible_with_new_height): New method.
 342         (tui_source_window_base::do_make_visible_with_new_height)
 343         (tui_data_window::do_make_visible_with_new_height)
 344         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 345         (make_visible_with_new_height): Remove.
 346         (tui_resize_all, tui_adjust_win_heights): Use
 347         make_visible_with_new_height method.
 348         * tui/tui-data.h (struct tui_win_info)
 349         <do_make_visible_with_new_height, make_visible_with_new_height>:
 350         New methods.
 351         (struct tui_source_window_base, struct tui_data_window)
 352         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 353         methods.
 354
 355 2019-06-25  Tom Tromey  <tom@tromey.com>
 356
 357         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 358         method.
 359         (update_tab_width): Call update_tab_width method.
 360         * tui/tui-data.h (struct tui_win_info)
 361         (struct tui_source_window_base) <update_tab_width>: New methods.
 362
 363 2019-06-25  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 366         parameter.
 367         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 368         parameter.
 369         (tui_gen_win_info::make_visible): Update.
 370         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 371         parameter.
 372         * tui/tui-data.h (enum tui_box): New enum.
 373         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 374
 375 2019-06-25  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 378         init_and_make_win for EXEC_INFO_WIN.
 379         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 380         longer inline.
 381         (struct tui_win_info) <~tui_win_info>: Inline.
 382         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 383         Don't declare.
 384         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 385         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 386         Remove.
 387         (tui_initialize_static_data): Update.
 388         (~tui_gen_win_info): Handle more cleanup here.
 389         (~tui_source_window_base): Delete "execution_info".
 390         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 391
 392 2019-06-25  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-layout.c (make_command_window): Don't set
 395         can_highlight.
 396         (show_source_disasm_command): Call the reset method.
 397         (show_data): Don't set can_highlight.  Call the reset method.
 398         (tui_gen_win_info::reset): Rename from init_gen_win_info
 399         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 400         (show_source_or_disasm_and_command): Call the reset method.
 401         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 402         (struct tui_cmd_window): Set can_highlight.
 403
 404 2019-06-25  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 407         from make_visible.
 408         (tui_make_visible, tui_make_invisible): Rewrite.
 409         (tui_win_info::make_visible): Remove.
 410         (tui_source_window_base::make_visible): Update.
 411         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 412         method.  Moved from...
 413         (struct tui_win_info) <make_visible>: ...here.
 414
 415 2019-06-25  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-winsource.c
 418         (tui_source_window_base::do_scroll_horizontal): Remove direction
 419         parameter.
 420         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 421         direction parameter.
 422         * tui/tui-win.c (tui_win_info::forward_scroll)
 423         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 424         (tui_win_info::right_scroll): Update.
 425         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 426         direction parameter.
 427         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 428         direction parameter.
 429         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 430         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 431         Remove direction parameter.
 432         (struct tui_source_window_base, struct tui_source_window)
 433         (struct tui_disasm_window, struct tui_data_window)
 434         (struct tui_cmd_window): Update.
 435
 436 2019-06-25  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui-winsource.h (tui_set_exec_info_content)
 439         (tui_show_exec_info_content, tui_erase_exec_info_content)
 440         (tui_clear_exec_info_content, tui_update_exec_info): Change
 441         argument to tui_source_window_base.
 442         * tui/tui-winsource.c (tui_set_exec_info_content)
 443         (tui_show_exec_info_content, tui_erase_exec_info_content)
 444         (tui_clear_exec_info_content, tui_update_exec_info): Change
 445         argument to tui_source_window_base.
 446
 447 2019-06-25  Tom Tromey  <tom@tromey.com>
 448
 449         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 450         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 451
 452 2019-06-25  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 455         check.
 456
 457 2019-06-25  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 460         type to void.
 461         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 462         type to void.
 463         * tui/tui-source.c (tui_set_source_content): Update.
 464         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 465
 466 2019-06-25  Tom Tromey  <tom@tromey.com>
 467
 468         * tui/tui-win.c (window_name_completer, tui_set_focus)
 469         (tui_all_windows_info): Use name method.
 470         * tui/tui-data.h (struct tui_gen_win_info)
 471         (struct tui_source_window, struct tui_disasm_window)
 472         (struct tui_data_window, struct tui_cmd_window) <name>: New
 473         method.
 474         (tui_win_name): Don't declare.
 475         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 476         (tui_win_name): Remove.
 477
 478 2019-06-25  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-winsource.h (tui_update_source_window)
 481         (tui_update_source_window_as_is): Change parameter type.
 482         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 483         to be a tui_source_window_base.
 484         (tui_update_source_window_as_is): Likewise.
 485         * tui/tui-win.c (make_visible_with_new_height): Update.
 486
 487 2019-06-25  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-winsource.c (tui_erase_source_content)
 490         (tui_show_source_content, tui_show_exec_info_content)
 491         (tui_erase_exec_info_content): Use refresh_window method.
 492         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 493         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 494         from tui_refresh_win.
 495         (tui_data_window::refresh_window): New method.
 496         (tui_win_info::refresh, tui_source_window_base::refresh)
 497         (tui_refresh_all): Use refresh_window method.
 498         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 499         method.
 500         * tui/tui-regs.c (tui_display_register): Call refresh_window
 501         method.
 502         * tui/tui-layout.c (show_source_disasm_command)
 503         (show_source_or_disasm_and_command): Call refresh_window method.
 504         * tui/tui-data.h (struct tui_gen_win_info)
 505         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 506         New method.
 507
 508 2019-06-25  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui.c (tui_rl_other_window, tui_enable)
 511         (tui_is_window_visible, tui_get_command_dimension): Update.
 512         * tui/tui-winsource.c (tui_update_source_window_as_is)
 513         (tui_clear_source_content, tui_erase_source_content)
 514         (tui_show_source_line, tui_source_window_base::refill)
 515         (tui_source_window_base::do_scroll_horizontal)
 516         (tui_source_window_base::set_is_exec_point_at)
 517         (tui_update_breakpoint_info, tui_set_exec_info_content)
 518         (tui_alloc_source_buffer, tui_line_is_displayed)
 519         (tui_addr_is_displayed): Update.
 520         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 521         (tui_check_and_display_highlight_if_needed)
 522         (tui_win_info::make_visible, tui_win_info::refresh)
 523         (tui_refresh_all): Update.
 524         * tui/tui-windata.c (tui_first_data_item_displayed)
 525         (tui_delete_data_content_windows, tui_erase_data_content)
 526         (tui_display_all_data, tui_data_window::refresh_all)
 527         (tui_check_data_values): Update.
 528         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 529         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 530         (tui_win_info::backward_scroll, tui_refresh_all_win)
 531         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 532         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 533         (tui_source_window_base::set_new_height)
 534         (tui_data_window::set_new_height)
 535         (make_invisible_and_set_new_height)
 536         (make_visible_with_new_height, new_height_ok)
 537         (parse_scrolling_args): Update.
 538         * tui/tui-stack.c (tui_show_frame_info): Update.
 539         * tui/tui-source.c (tui_set_source_content)
 540         (tui_set_source_content_nil, tui_source_is_displayed)
 541         (tui_source_window::do_scroll_vertical): Update.
 542         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 543         (tui_display_registers_from, tui_display_reg_element_at_line)
 544         (tui_check_register_values, tui_reg_command): Update.
 545         * tui/tui-layout.c (tui_default_win_height)
 546         (show_source_disasm_command, show_data, init_and_make_win)
 547         (show_source_or_disasm_and_command): Update.
 548         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 549         (tui_redisplay_readline, tui_mld_flush)
 550         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 551         (tui_getc): Update.
 552         * tui/tui-disasm.c (tui_set_disassem_content)
 553         (tui_disasm_window::do_scroll_vertical): Update.
 554         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 555         Now virtual.
 556         (struct tui_win_info): Derive from tui_gen_win_info.
 557         <~tui_win_info>: Mark as override.
 558         <generic>: Remove member.
 559         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 560         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 561         (~tui_data_window, ~tui_win_info)
 562         (tui_free_all_source_wins_content): Update.
 563         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 564
 565 2019-06-25  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-layout.c (init_and_make_win): Use new.
 568         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 569         destructor, initializers.
 570         (tui_alloc_generic_win_info): Don't declare.
 571         * tui/tui-data.c (_locator): Add argument to constructor.
 572         (source_win, disasm_win): New globals.
 573         (exec_info): Remove.
 574         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 575         Update.
 576         (tui_alloc_generic_win_info): Remove.
 577         (init_content_element): Use new.
 578         (tui_win_info::tui_win_info): Update.
 579         (free_content_elements) <case DATA_WIN>: Use delete.
 580
 581 2019-06-25  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 584         * tui/tui-windata.c (tui_first_data_item_displayed)
 585         (tui_delete_data_content_windows): Update.
 586         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 587         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 588         (tui_display_registers_from, tui_check_register_values): Update.
 589         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 590         pointer.
 591         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 592         window.
 593         (tui_free_data_content): Update.
 594         (free_content_elements) <case DATA_WIN>: Free the window.
 595
 596 2019-06-25  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 599         Update.
 600         * tui/tui-layout.c (make_command_window)
 601         (show_source_disasm_command, show_data, init_and_make_win)
 602         (show_source_or_disasm_and_command): Update.
 603         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 604         method.
 605         <can_highight, is_highlighted>: Now bool.
 606         (tui_set_win_highlight): Don't declare.
 607         * tui/tui-data.c (tui_set_win_highlight): Remove.
 608
 609 2019-06-25  Tom Tromey  <tom@tromey.com>
 610
 611         * tui/tui-wingeneral.c (make_visible): Remove check of window
 612         type.
 613
 614 2019-06-25  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-win.c (tui_win_info::max_height)
 617         (tui_cmd_window::max_height): New methods.
 618         (new_height_ok): Call max_height.
 619         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 620         <max_height>: New method.
 621
 622 2019-06-25  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-win.c (tui_source_window_base::set_new_height)
 625         (tui_data_window::set_new_height): New methods.
 626         (make_invisible_and_set_new_height): Call set_new_height method.
 627         * tui/tui-data.h (struct tui_win_info)
 628         (struct tui_source_window_base, struct tui_data_window)
 629         <set_new_height>: New method.
 630
 631 2019-06-25  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 634         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 635         tui_refresh_data_win.
 636         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 637         method.
 638         (tui_refresh_all_win): Call the refresh_all method.
 639         (tui_set_focus): Likewise.
 640         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 641         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 642         Likewise.
 643
 644 2019-06-25  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-winsource.h (tui_refill_source_window)
 647         (tui_set_is_exec_point_at): Don't declare.
 648         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 649         (tui_source_window_base::refill): Rename from
 650         tui_refill_source_window.
 651         (tui_source_window_base::do_scroll_horizontal): Update.
 652         (tui_source_window_base::set_is_exec_point_at): Rename from
 653         tui_set_is_exec_point_at.
 654         (tui_update_all_breakpoint_info): Update.
 655         * tui/tui-stack.c (tui_show_frame_info): Update.
 656         * tui/tui-layout.c (show_data): Add cast.
 657         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 658         * tui/tui-data.h (struct tui_source_window_base) <refill,
 659         set_is_exec_point_at>: New methods.
 660         (tui_source_windows, tui_add_to_source_windows): Update types.
 661         (tui_add_to_source_windows): Remove redundant declaration.
 662         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 663         (tui_source_windows): Change return type.
 664         (tui_clear_source_windows_detail): Update.
 665         (tui_add_to_source_windows): Change type of parameter.
 666         (tui_free_all_source_wins_content): Update.
 667
 668 2019-06-25  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-wingeneral.c (tui_win_info::refresh)
 671         (tui_source_window_base::refresh): New methods.
 672         (tui_refresh_all): Call the refresh method.
 673         * tui/tui-data.h (struct tui_win_info)
 674         (struct tui_source_window_base) <refresh>: New method.
 675
 676 2019-06-25  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui.h (tui_is_window_visible): Return bool.
 679         * tui/tui.c (tui_is_window_visible): Return bool.
 680         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 681         (tui_make_visible, tui_make_invisible)
 682         (tui_win_info::make_visible)
 683         (tui_source_window_base::make_visible, make_all_visible)
 684         (tui_make_all_visible, tui_make_all_invisible): Update.
 685         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 686         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 687         bool.
 688         (struct tui_win_info, struct tui_source_window_base)
 689         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 690         * tui/tui-data.c (tui_init_generic_part): Update.
 691
 692 2019-06-25  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 695         (tui_source_window_base::make_visible): New methods.
 696         (make_all_visible): Make method call.
 697         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 698         (struct tui_source_window_base, struct tui_cmd_window): Override
 699         make_visible.
 700         (tui_win_is_source_type): Don't declare.
 701         * tui/tui-data.c (tui_win_is_source_type): Remove.
 702
 703 2019-06-25  Tom Tromey  <tom@tromey.com>
 704
 705         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 706         NULL check.
 707
 708 2019-06-25  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 711         Inline constructor.  Add initializers for members.
 712         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 713         constructors; now inline in class.
 714
 715 2019-06-25  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-regs.c (tui_show_registers): Update.
 718         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 719         bool.
 720         * tui/tui-data.c (tui_data_window::clear_detail)
 721         (tui_data_window): Update.
 722
 723 2019-06-25  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-windata.c (tui_display_all_data)
 726         (tui_display_data_from_line, tui_display_data_from)
 727         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 728         Update.
 729         * tui/tui-regs.c (tui_last_regs_line_no)
 730         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 731         (tui_show_registers, tui_show_register_group)
 732         (tui_display_registers_from, tui_display_reg_element_at_line)
 733         (tui_display_registers_from_line, tui_check_register_values)
 734         (tui_reg_next, tui_reg_prev): Update.
 735         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 736         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 737         tui_data_window.
 738         (struct tui_win_info) <detail>: Remove.  Add new fields from
 739         tui_data_info.
 740         (TUI_DATA_WIN): Add cast.
 741         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 742         (~tui_data_window): Simplify.
 743
 744 2019-06-25  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-layout.c (show_source_disasm_command)
 747         (show_source_or_disasm_and_command): Update.
 748         * tui/tui-io.c (update_cmdwin_start_line)
 749         (tui_redisplay_readline): Update.
 750         * tui/tui-data.h (struct tui_command_info): Remove.
 751         (struct tui_win_info) <detail>: Remove command_info member.
 752         (struct tui_data_window) <start_line>: New member, from
 753         tui_command_info.
 754         (TUI_CMD_WIN): Add casts.
 755
 756 2019-06-25  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-winsource.c (tui_update_source_window)
 759         (tui_refill_source_window)
 760         (tui_source_window_base::do_scroll_horizontal)
 761         (tui_update_breakpoint_info, tui_set_exec_info_content)
 762         (tui_show_exec_info_content, tui_erase_exec_info_content)
 763         (tui_clear_exec_info_content): Update.
 764         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 765         Update.
 766         * tui/tui-win.c (make_invisible_and_set_new_height)
 767         (make_visible_with_new_height): Update.
 768         * tui/tui-source.c (tui_set_source_content)
 769         (tui_show_symtab_source): Update.
 770         * tui/tui-layout.c (extract_display_start_addr)
 771         (show_source_disasm_command, show_data)
 772         (make_source_or_disasm_window)
 773         (show_source_or_disasm_and_command): Update.
 774         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 775         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 776         "gdbarch".
 777         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 778         to tui_source_window_base.
 779         (struct tui_win_info) <detail>: Remove source_info member.
 780         (struct tui_source_window_base) <has_locator>: Inline.
 781         Move contents from tui_source_info; rename has_locator member to
 782         m_has_locator.
 783         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 784         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 785         header file.
 786         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 787         Simplify.
 788         (tui_free_all_source_wins_content): Cast to
 789         tui_source_window_base.
 790
 791 2019-06-25  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-win.c (make_invisible_and_set_new_height)
 794         (make_visible_with_new_height): Call has_locator method.
 795         * tui/tui-layout.c (show_source_disasm_command, show_data)
 796         (show_source_or_disasm_and_command): Update for bool change.
 797         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 798         (tui_win_info) <has_locator>: New method.
 799         (struct tui_source_window_base) <has_locator>: New method.
 800         (tui_win_has_locator): Don't declare.
 801         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 802         from tui_win_has_locator.
 803         (tui_source_window_base): Use false, not FALSE.
 804
 805 2019-06-25  Tom Tromey  <tom@tromey.com>
 806
 807         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 808         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 809         clear_detail method directly.
 810         (tui_clear_win_detail): Remove.
 811
 812 2019-06-25  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 815         "this", not TUI_DISASM_WIN.
 816
 817 2019-06-25  Tom Tromey  <tom@tromey.com>
 818
 819         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 820         declare.
 821         * tui/tui-winsource.c
 822         (tui_source_window_base::do_scroll_horizontal): Rename from
 823         tui_horizontal_source_scroll.
 824         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 825         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 826         from tui_vertical_data_scroll.
 827         * tui/tui-win.h (tui_scroll): Don't declare.
 828         * tui/tui-win.c (tui_win_info::forward_scroll)
 829         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 830         (tui_win_info::right_scroll): Rename and update.
 831         (tui_scroll_forward_command, tui_scroll_backward_command)
 832         (tui_scroll_left_command, tui_scroll_right_command): Update.
 833         (tui_scroll): Remove.
 834         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 835         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 836         from tui_vertical_source_scroll.
 837         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 838         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 839         from tui_vertical_disassem_scroll.
 840         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 841         do_scroll_horizontal>: New methods.
 842         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 843         Likewise.
 844         (struct tui_source_window_base): Add do_scroll_horizontal.
 845         (struct tui_source_window, struct tui_disasm_window): Add
 846         do_scroll_vertical.
 847         (struct tui_data_window, struct tui_cmd_window): Add
 848         do_scroll_horizontal and do_scroll_vertical.
 849         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 850
 851 2019-06-25  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-data.h (struct tui_source_window_base): New struct.
 854         (struct tui_source_window): Derive from tui_source_window_base.
 855         (struct tui_disasm_window): New struct.
 856         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 857         from tui_source_window::clear_detail.
 858         (tui_source_window_base): Rename from tui_source_window.
 859         (~tui_source_window_base): Rename from ~tui_source_window.
 860         (tui_alloc_win_info): Create a tui_disasm_window.
 861
 862 2019-06-25  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-data.h (struct tui_source_window)
 865         (struct tui_data_window): Declare destructors.
 866         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 867         destructors.
 868         (tui_win_info): Simplify.
 869
 870 2019-06-25  Tom Tromey  <tom@tromey.com>
 871
 872         * tui/tui-winsource.c (tui_display_main)
 873         (tui_update_source_windows_with_addr)
 874         (tui_update_all_breakpoint_info): Update.
 875         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 876         (new_height_ok, parse_scrolling_args): Update.
 877         * tui/tui-stack.c (tui_show_frame_info): Update.
 878         * tui/tui-data.h (struct tui_list): Remove.
 879         (tui_source_windows): Return a reference to a std::vector.
 880         * tui/tui-data.c (source_windows): Now a std::vector.
 881         (tui_source_windows): Change return type.
 882         (tui_clear_source_windows): Rewrite.
 883         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 884         (tui_free_all_source_wins_content): Rewrite.
 885
 886 2019-06-25  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 889         (struct tui_data_window, struct tui_cmd_window): Declare
 890         clear_detail method.
 891         * tui/tui-data.c (tui_source_window::clear_detail)
 892         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 893         methods.
 894         (tui_clear_win_detail): Simplify.
 895
 896 2019-06-25  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-layout.c (make_source_window, make_disasm_window)
 899         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 900         Return the new window.
 901         (show_source_disasm_command, show_data)
 902         (show_source_or_disasm_and_command): Update.
 903
 904 2019-06-25  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 907         parameter.  Return the new window.
 908         (show_source_disasm_command): Update and remove NULL check.
 909         (show_source_or_disasm_and_command): Update.
 910
 911 2019-06-25  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 914
 915 2019-06-25  Tom Tromey  <tom@tromey.com>
 916
 917         * tui/tui-data.h (struct tui_win_info): Make constructor
 918         protected.  Make destructor virtual.  Add initializers.
 919         (tui_source_window, tui_data_window, tui_cmd_window): New
 920         classes.
 921         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 922         constructor.  Add "type" parameter.
 923         (tui_source_window, tui_data_window, tui_cmd_window): New
 924         constructors.
 925         (tui_alloc_win_info): Instantiate the appropriate subclass.
 926
 927 2019-06-25  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-win.c (tui_resize_all): Use delete.
 930         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 931         destructor.
 932         (tui_free_window): Don't declare.
 933         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 934         Update.
 935
 936 2019-06-25  Tom Tromey  <tom@tromey.com>
 937
 938         * tui/tui-data.h (struct tui_win_info): Add constructor.
 939         * tui/tui-data.c (tui_alloc_win_info): Use new.
 940         (tui_free_window): Use delete.
 941
 942 2019-06-22  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 945         declare.
 946         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 947
 948 2019-06-22  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 951         declare.
 952         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 953
 954 2019-06-22  Tom de Vries  <tdevries@suse.de>
 955
 956         * dwarf2read.c (create_addrmap_from_aranges)
 957         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 958         instead of '%zu'.
 959
 960 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 961
 962         * dwarf2read.h (dwarf2_section_info_def): Remove.
 963         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 964         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 965         std::vector<dwarf2_section_info>.
 966         (struct dwo_file) <~dwo_file>: Remove.
 967         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 968         types field.
 969         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 970         (dwarf2_read_debug_names): Likewise.
 971         (create_debug_types_hash_table): Change parameter type to
 972         array_view, adjust code accordingly.
 973         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 974         (partial_die_info::fixup): Likewise.
 975         (determine_prefix): Likewise.
 976         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 977
 978 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 979
 980         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 981         gdb_bfd_ref_ptr.
 982         <~dwo_file>: Remove call to gdb_bfd_unref.
 983         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 984         gdb_bfd_ref_ptr::get.
 985
 986 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 987
 988         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 989         type to htab_up.
 990         * dwarf2read.c (struct dwo_file): Initialize fields.
 991         <~dwo_file>: New.
 992         (free_dwo_file): Remove, move content to ~dwo_file.
 993         (struct dwo_file_deleter): Remove.
 994         (dwo_file_up>: Remove custom deleter.
 995         (free_dwo_files): Remove.
 996         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 997         dwo_files.
 998         (process_skeletonless_type_units): Call unique_ptr::get.
 999         (allocate_dwo_file_hash_table): Add deleter to created hash
1000         table.  Change return type to htab_up.
1001         (lookup_dwo_file_slot): Don't memset dwo_file, call
1002         unique_ptr::get.
1003         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1004         (create_dwo_unit_in_dwp_v2): Likewise.
1005         (open_and_init_dwo_file): Likewise.
1006         (free_dwo_file_from_slot): Remove.
1007
1008 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1009
1010         * dwarf2read.h (struct dwarf2_section_info) <readin,
1011         is_virtual>: Change type to bool.
1012         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1013         true instead of 1.
1014
1015 2019-06-19  Tom Tromey  <tom@tromey.com>
1016
1017         * tui/tui-data.h (tui_init_content_element): Don't declare.
1018
1019 2019-06-19  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-data.h (tui_init_win_info): Don't declare.
1022
1023 2019-06-19  Tom de Vries  <tdevries@suse.de>
1024
1025         * dwarf2read.h (abstract_to_concrete): Change type to
1026         std::unordered_map<sect_offset, std::vector<sect_offset>,
1027         gdb::hash_enum<sect_offset>>.
1028
1029 2019-06-19  Tom Tromey  <tromey@adacore.com>
1030
1031         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1032         EVAL_AVOID_SIDE_EFFECTS specially.
1033
1034 2019-06-19  Tom Tromey  <tromey@adacore.com>
1035
1036         * source-cache.c (highlighter): New global.
1037         (source_cache::get_source_lines): Create a highlighter on demand.
1038
1039 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1040
1041         * defs.h (deprecated_interactive_hook): Delete declaration.
1042         * interps.c (clear_interpreter_hooks): Remove use of
1043         deprecated_interactive_hook.
1044         * top.c (deprecated_interactive_hook): Delete definition.
1045         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1046
1047 2019-06-18  Tom de Vries  <tdevries@suse.de>
1048
1049         PR gdb/24515
1050         * dwarf2read.h (abstract_to_concrete): Change type from
1051         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1052         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1053         * dwarf2read.c (read_variable): Update.
1054         (dwarf2_fetch_die_loc_sect_off): Update.
1055
1056 2019-06-17  Tom de Vries  <tdevries@suse.de>
1057
1058         PR gdb/24617
1059         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1060         accessing parent[parent_len - 1].
1061
1062 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1063
1064         PR gdb/24364
1065         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1066         call dtrace_process_dof with NULL dof.
1067
1068 2019-06-16  Tom de Vries  <tdevries@suse.de>
1069
1070         PR gdb/24445
1071         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1072
1073 2019-06-16  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1076         (make_all_visible): Use address of member.
1077
1078 2019-06-16  Tom Tromey  <tom@tromey.com>
1079
1080         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1081         (tui_free_window, free_content, free_content_elements): Remove
1082         unnecessary cast.
1083         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1084         cast.
1085         * tui/tui-regs.c (tui_show_register_group)
1086         (tui_display_registers_from, tui_display_reg_element_at_line):
1087         Remove unnecessary cast.
1088
1089 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1090
1091         * linux-nat.c (normal_mask): Delete.
1092         (_initialize_linux_nat): Don't initialise normal_mask.
1093
1094 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1095
1096         PR gdb/24445
1097         * dwarf-index-write.h (write_psymtabs_to_index): Add
1098         dwz_basename parameter.
1099         * dwarf-index-write.c (write_gdbindex): Move file writing to
1100         write_gdbindex_1.  Change return type void.
1101         (assert_file_size): Move up, remove filename parameter.
1102         (write_gdbindex_1): New function.
1103         (write_debug_names): Change return type to void, call
1104         assert_file_size.
1105         (struct index_wip_file): New struct.
1106         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1107         file logic to index_wip_file.  Write index for dwz file if
1108         needed.
1109         (save_gdb_index_command): Pass basename of dwz file, if present.
1110         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1111         build-id of dwz file, if present.
1112         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1113         (dwarf2_get_dwz_file): Likewise.
1114         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1115         (dwarf2_get_dwz_file): Likewise.
1116
1117 2019-06-16  Tom Tromey  <tom@tromey.com>
1118
1119         * coffread.c (process_coff_symbol): Use xstrdup.
1120         * value.c (create_internalvar): Use xstrdup.
1121
1122 2019-06-16  Tom Tromey  <tom@tromey.com>
1123
1124         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1125         * breakpoint.c (stopin_command, stopat_command)
1126         (until_break_command, decode_location_default): Remove unnecessary
1127         cast.
1128         * utils.c (subset_compare): Remove unnecessary cast.
1129         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1130         cast.
1131         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1132         cast.
1133         * infcmd.c (path_command): Remove unnecessary cast.
1134         * coffread.c (decode_type): Remove unnecessary cast.
1135         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1136         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1137         * tui/tui-stack.c (tui_show_locator_content)
1138         (tui_show_frame_info): Remove unnecessary cast.
1139         * tui/tui-win.c (tui_scroll_forward_command)
1140         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1141         (parse_scrolling_args): Remove unnecessary cast.
1142         * tui/tui-data.c (init_win_info, tui_del_window)
1143         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1144         (free_content_elements): Remove unnecessary cast.
1145         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1146         unnecessary cast.
1147         * tui/tui-source.c (tui_set_source_content)
1148         (tui_vertical_source_scroll): Remove unnecessary cast.
1149         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1150         cast.
1151         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1152         * tui/tui-regs.c (tui_display_registers_from)
1153         (tui_display_register): Remove unnecessary cast.
1154         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1155         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1156         (make_visible): Remove unnecessary cast.
1157         * tui/tui-winsource.c (tui_erase_source_content)
1158         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1159         unnecessary cast.
1160         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1161         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1162         * stabsread.c (read_type, read_array_type, read_range_type):
1163         Remove unnecessary cast.
1164         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1165         (parse_symbol, parse_type, upgrade_type, parse_external)
1166         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1167         unnecessary cast.
1168         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1169
1170 2019-06-16  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-data.c (tui_alloc_generic_win_info)
1173         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1174         checks.
1175
1176 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1177             Andrew Burgess  <andrew.burgess@embecosm.com>
1178
1179         * f-typeprint.c (f_print_type): Don't return early for not
1180         associated or not allocated types.
1181         (f_type_print_varspec_suffix): Add print_rank parameter and print
1182         ranks of array types in case they dangling.
1183         (f_type_print_base): Add print_rank parameter.
1184
1185 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1186
1187         * NEWS: Mention new MI commands.
1188         * break-catch-throw.c (enum exception_event_kind): Move to
1189         breakpoint.h.
1190         (print_mention_exception_catchpoint): Output text as a single
1191         message.
1192         (catch_exception_command_1): Rename to...
1193         (catch_exception_event): ...this, make non-static, update header
1194         command, and change some parameter types.
1195         (catch_catch_command): Update for changes to
1196         catch_exception_command_1.
1197         (catch_throw_command): Likewise.
1198         (catch_rethrow_command): Likewise.
1199         * breakpoint.c (enum exception_event_kind): Delete.
1200         * breakpoint.h (enum exception_event_kind): Moved here from
1201         break-catch-throw.c.
1202         (catch_exception_event): Declare.
1203         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1204         (mi_cmd_catch_throw): New function.
1205         (mi_cmd_catch_rethrow): New function.
1206         (mi_cmd_catch_catch): New function.
1207         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1208         'catch-catch' entries.
1209         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1210         (mi_cmd_catch_rethrow): Declare.
1211         (mi_cmd_catch_catch): Declare.
1212
1213 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * annotate.c (annotate_source_line): Change return type to void,
1216         update implementation to match.
1217         * annotate.h (annotate_source_line): Change return type to void,
1218         update header comment.
1219         * stack.c (print_frame_info): Don't change what frame information
1220         is printed based on whether annotations are on or not.
1221
1222 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1223
1224         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1225         (annotate_source): Make static.
1226         (annotate_source_line): Moved from source.c and renamed from
1227         identify_source_line.  Update the return type.
1228         * annotate.h (annotate_source): Delete declaration.
1229         (annotate_source_line): Declaration moved from source.h, and
1230         renamed from identify_source_line.  Return type updated.
1231         * source.c (identify_source_line): Moved to annotate.c and renamed
1232         to annotate_source_line.
1233         (info_line_command): Remove check of annotation_level.
1234         * source.h (identify_source_line): Move declaration to annotate.h
1235         and rename to annotate_source_line.
1236         * stack.c: Add 'annotate.h' include.
1237         (print_frame_info): Remove check of annotation_level before
1238         calling annotate_source_line.
1239
1240 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * source-cache.c (source_cache::get_plain_source_lines): Use
1243         open_source_file_with_line_charpos instead of just
1244         open_source_file, remove call to find_source_lines.
1245         (source_cache::get_source_lines): Likewise.
1246         * source.c (find_source_lines): Make static.
1247         (get_filename_and_charpos): Renamed into...
1248         (open_source_file_with_line_charpos): ..this along with changes to
1249         return a scoped_fd, and some other minor clean ups.
1250         (identify_source_line): Use open_source_file_with_line_charpos.
1251         (search_command_helper): Use open_source_file_with_line_charpos
1252         instead of just open_source_file, remove call to
1253         find_source_lines.
1254         * source.h (open_source_file_with_line_charpos): Declare new
1255         function.
1256         (find_source_lines): Delete declaration.
1257
1258 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1259
1260         * source.c (get_filename_and_charpos): Remove fullname
1261         parameter.
1262         (identify_source_line): Update call to get_filename_and_charpos.
1263
1264 2019-06-14  Tom Tromey  <tromey@adacore.com>
1265
1266         PR gdb/24502:
1267         * ui-style.h (skip_ansi_escape): Update comment.
1268         * ui-file.h (class no_terminal_escape_file): New class.
1269         * ui-file.c (no_terminal_escape_file::write)
1270         (no_terminal_escape_file::puts): New methods.
1271         * cli/cli-logging.c (handle_redirections): Use
1272         no_terminal_escape_file.
1273
1274 2019-06-14  Tom Tromey  <tromey@adacore.com>
1275
1276         * NEWS: Move convenience variable news above Python news.
1277
1278 2019-06-14  Tom Tromey  <tom@tromey.com>
1279
1280         * gnulib: Move directory to top-level.
1281         * configure.ac: Don't configure gnulib.
1282         * configure: Rebuild.
1283         * common/common-defs.h: Use new path to gnulib.
1284         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1285         (GNULIB_H): Remove.
1286         (INCGNU): Look in new gnulib location.
1287         (HFILES_NO_SRCDIR): Remove gnulib files.
1288         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1289         (generated_files): Remove GNULIB_H.
1290         ($(LIBGNU), all-lib): Remove targets.
1291         (distclean): Don't mention GNULIB_BUILDDIR.
1292         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1293
1294 2019-06-14  Tom Tromey  <tromey@adacore.com>
1295
1296         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1297         Warn if symbol file does not provide any symbols.
1298
1299 2019-06-14  Tom Tromey  <tromey@adacore.com>
1300
1301         * source.c (find_and_open_source): Respect basenames_may_differ.
1302
1303 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1304
1305         * annotate.c (annotate_breakpoints_invalid): Make use of
1306         scoped_restore_terminal_state.
1307         (annotate_frames_invalid): Likewise.
1308
1309 2019-06-14  Tom Tromey  <tromey@adacore.com>
1310
1311         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1312         allow assignment to an internalvar.
1313
1314 2019-06-14  Tom Tromey  <tromey@adacore.com>
1315
1316         * ada-lex.l: Allow "_" in attribute names.
1317
1318 2019-06-14  Tom Tromey  <tromey@adacore.com>
1319
1320         PR gdb/24653:
1321         * regcache.c (registers_changed): Don't call alloca.
1322         * top.c (execute_command): Don't call alloca.
1323
1324 2019-06-13  Pedro Alves  <palves@redhat.com>
1325
1326         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1327         'expression'.  When parsing an expression, error out if there's
1328         junk after "unlimited".
1329         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1330         (do_set_command): Adjust calls to is_unlimited_literal.
1331
1332 2019-06-13  Pedro Alves  <palves@redhat.com>
1333
1334         * compile/compile.c (make_compile_options_def_group): Add braces
1335         around array_view initializer.
1336         * thread.c (make_thread_apply_all_options_def_group)
1337         (make_thread_apply_all_options_def_group): Likewise.
1338
1339 2019-06-13  Pedro Alves  <palves@redhat.com>
1340
1341         * NEWS (New commands): Mention "maint test-options
1342         require-delimiter", "maint test-options unknown-is-error", "maint
1343         test-options unknown-is-operand" and "maint show
1344         test-options-completion-result".
1345         (New command options, command completion): New section.
1346         (Completion improvements): New section.
1347         Mention that you can abbreviate "unlimited".
1348
1349 2019-06-13  Pedro Alves  <palves@redhat.com>
1350
1351         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1352         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1353         * unittests/cli-utils-selftests.c (test_parse_flags)
1354         (test_parse_flags_qcs): Delete.
1355         (test_cli_utils): Don't call deleted functions.
1356
1357 2019-06-13  Pedro Alves  <palves@redhat.com>
1358
1359         * thread.c: Include "cli/cli-option.h".
1360         (tp_array_compar_ascending): Global.
1361         (tp_array_compar): Delete function.
1362         (tp_array_compar_ascending, tp_array_compar_descending): New
1363         functions.
1364         (ascending_option_def, qcs_flag_option_def)
1365         (thr_qcs_flags_option_defs)
1366         (make_thread_apply_all_options_def_group)
1367         (make_thread_apply_options_def_group): New.
1368         (thread_apply_all_command): Use gdb::option::process_options.
1369         (thread_apply_command_completer)
1370         (thread_apply_all_command_completer): New.
1371         (thread_apply_command): Use gdb::option::process_options.
1372         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1373         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1374         to generate help text of "thread apply".  Adjust "taas"'s help.
1375         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1376         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1377
1378 2019-06-13  Pedro Alves  <palves@redhat.com>
1379
1380         * thread.c (thread_apply_command): Check for invalid TID with
1381         isdigit instead of !isalpha.
1382
1383 2019-06-13  Pedro Alves  <palves@redhat.com>
1384
1385         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1386         (validate_flags_qcs): New.
1387         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1388         (validate_flags_qcs): Declare.
1389         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1390         (make_frame_apply_options_def_group): New.
1391         (frame_apply_command_count): Process options with
1392         gdb::option::process_options.
1393         (frame_apply_completer): New.
1394         (frame_apply_level_completer, frame_apply_all_completer)
1395         (frame_apply_completer): New.
1396         (_initialize_stack): Update help of "frame apply", "frame apply
1397         level", "frame apply all" and "faas" to mention supported options
1398         and install command completers.
1399         * stack.h (frame_apply_all_completer): Declare.
1400         * thread.c: Include "stack.h".
1401         (tfaas_command): Add "--".
1402         (_initialize_thread): Update help "tfaas" to mention supported
1403         options and install command completer.
1404
1405 2019-06-13  Pedro Alves  <palves@redhat.com>
1406
1407         * completer.c (complete_nested_command_line): New.
1408         (gdb_completion_word_break_characters_throw): Add assertion.
1409         * completer.h (complete_nested_command_line): Declare.
1410
1411 2019-06-13  Pedro Alves  <palves@redhat.com>
1412
1413         * stack.c (parse_backtrace_qualifiers): New.
1414         (backtrace_command): Use it.
1415         (backtrace_command_completer): Complete on qualifiers.
1416
1417 2019-06-13  Pedro Alves  <palves@redhat.com>
1418
1419         * frame.c: Include "cli/cli-option.h.
1420         (user_set_backtrace_options): New.
1421         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1422         Delete.
1423         (get_prev_frame): Adjust.
1424         (boolean_option_def, uinteger_option_def)
1425         (set_backtrace_option_defs): New.
1426         (_initialize_frame): Adjust and use
1427         gdb::option::add_setshow_cmds_for_options to install "set
1428         backtrace past-main" and "set backtrace past-entry".
1429         * frame.h: Include "cli/cli-option.h".
1430         (struct frame_print_options): Forward declare.
1431         (print_frame_arguments_all, print_frame_arguments_scalars)
1432         (print_frame_arguments_none): Declare.
1433         (print_entry_values): Delete declaration.
1434         (struct frame_print_options, user_frame_print_options): New.
1435         (struct set_backtrace_options): New.
1436         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1437         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1438         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1439         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1440         (list_args_or_locals): Add frame_print_options parameter.
1441         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1442         * python/py-framefilter.c (enumerate_args): Pass down
1443         USER_FRAME_PRINT_OPTIONS.
1444         * stack.c: Include "cli/cli-option.h".
1445         (print_frame_arguments_all, print_frame_arguments_scalars)
1446         (print_frame_arguments_none): Declare.
1447         (print_raw_frame_arguments, print_entry_values): Delete.
1448         (user_frame_print_options): New.
1449         (boolean_option_def, enum_option_def, frame_print_option_defs):
1450         New.
1451         (struct backtrace_cmd_options): New.
1452         (bt_flag_option_def): New.
1453         (backtrace_command_option_defs): New.
1454         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1455         (print_frame_arg, read_frame_arg, print_frame_args)
1456         (print_frame_info, print_frame): Add frame_print_options parameter
1457         and use it.
1458         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1459         (backtrace_command_1): Add frame_print_options and
1460         backtrace_cmd_options parameters and use them.
1461         (make_backtrace_options_def_group): New.
1462         (backtrace_command): Process command options with
1463         gdb::option::process_options.
1464         (backtrace_command_completer): New.
1465         (_initialize_stack): Extend "backtrace"'s help to mention
1466         supported options.  Install completer for "backtrace".
1467         Install some settings commands with add_setshow_cmds_for_options.
1468
1469 2019-06-13  Pedro Alves  <palves@redhat.com>
1470
1471         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1472         and that "set/show print raw frame-arguments" are now deprecated.
1473
1474         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1475         command.
1476         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1477         * stack.c (_initialize_stack): Install "set/show print
1478         raw-frame-arguments", and deprecate "set/show print raw
1479         frame-arguments".
1480         * valprint.c (_initialize_valprint): Deprecate "set/show print
1481         raw".
1482
1483 2019-06-13  Pedro Alves  <palves@redhat.com>
1484
1485         * compile/compile.c (struct compile_options): New.
1486         (compile_flag_option_def, compile_command_option_defs)
1487         (make_compile_options_def_group): New.
1488         (compile_file_command): Handle options with
1489         gdb::option::process_options.
1490         (compile_file_command_completer): New function.
1491         (compile_code_command): Handle options with
1492         gdb::option::process_options.
1493         (compile_code_command_completer): New function.
1494         (_initialize_compiler): Install completers for "compile code" and
1495         "compile file".  Mention available options in "compile code" and
1496         "compile code"'s help.
1497         * completer.c (advance_to_completion_word): New, factored out from
1498         ...
1499         (advance_to_expression_complete_word_point): ... this.
1500         (advance_to_filename_complete_word_point): New.
1501         * completer.h (advance_to_filename_complete_word_point): New
1502         declaration.
1503
1504 2019-06-13  Pedro Alves  <palves@redhat.com>
1505
1506         * compile/compile.c: Include "cli/cli-option.h".
1507         (compile_print_value): Scope data pointer is now a
1508         value_print_options pointer; adjust.
1509         (compile_print_command): Process options.  Scope data pointer is
1510         now a value_print_options pointer; adjust.
1511         (_initialize_compile): Update "compile print"'s help to include
1512         supported options.  Install a completer for "compile print".
1513         * cp-valprint.c (show_vtblprint, show_objectprint)
1514         (show_static_field_print): Delete.
1515         (_initialize_cp_valprint): Don't install "set print
1516         static-members", "set print vtbl", "set print object" here.
1517         * printcmd.c: Include "cli/cli-option.h" and
1518         "common/gdb_optional.h".
1519         (print_command_parse_format): Rework to fill in a
1520         value_print_options instead of a format_data.
1521         (print_value): Change parameter type from format_data pointer to
1522         value_print_options reference.  Adjust.
1523         (print_command_1): Process options.  Adjust to pass down a
1524         value_print_options.
1525         (print_command_completer): New.
1526         (_initialize_printcmd): Install print_command_completer as
1527         handle_brkchars completer for the "print" command.  Update
1528         "print"'s help to include supported options.
1529         * valprint.c: Include "cli/cli-option.h".
1530         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1531         here from cp-valprint.c.
1532         (boolean_option_def, uinteger_option_def)
1533         (value_print_option_defs, make_value_print_options_def_group):
1534         New.  Use gdb::option::add_setshow_cmds_for_options to install
1535         "set print elements", "set print null-stop", "set print repeats",
1536         "set print pretty", "set print union", "set print array", "set
1537         print address", "set print symbol", "set print array-indexes".
1538         * valprint.h: Include <string> and "cli/cli-option.h".
1539         (make_value_print_options_def_group): Declare.
1540         (print_value): Change parameter type from format_data pointer to
1541         value_print_options reference.
1542         (print_command_completer): Declare.
1543
1544 2019-06-13  Pedro Alves  <palves@redhat.com>
1545
1546         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1547         (COMMON_SFILES): Add maint-test-settings.c.
1548         * cli/cli-decode.c (boolean_enums): New global, factored out from
1549         ...
1550         (add_setshow_boolean_cmd): ... here.
1551         * cli/cli-decode.h (boolean_enums): Declare.
1552         * cli/cli-option.c: New file.
1553         * cli/cli-option.h: New file.
1554         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1555         factored out from ...
1556         (parse_cli_boolean_value(const char *)): ... this.
1557         (is_unlimited_literal): Change parameter type to pointer to
1558         pointer.  Adjust and advance ARG pointer.
1559         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1560         (parse_cli_var_enum): New, factored out from ...
1561         (do_set_command): ... this.  Adjust.
1562         * cli/cli-setshow.h (parse_cli_boolean_value)
1563         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1564         (parse_cli_var_enum): Declare.
1565         * cli/cli-utils.c: Include "cli/cli-option.h".
1566         (get_ulongest): New.
1567         * cli/cli-utils.h (get_ulongest): Declare.
1568         (check_for_argument): New overloads.
1569         * maint-test-options.c: New file.
1570
1571 2019-06-13  Pedro Alves  <palves@redhat.com>
1572
1573         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1574         parse a range if "-" is at the end of the string.
1575
1576 2019-06-13  Pedro Alves  <palves@redhat.com>
1577
1578         * cli/cli-setshow.c (parse_auto_binary_operation)
1579         (parse_cli_boolean_value): Don't allow "o".
1580
1581 2019-06-13  Pedro Alves  <palves@redhat.com>
1582
1583         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1584         * NEWS: Mention maint test-settings KIND.
1585         * maint-test-settings.c: New file.
1586
1587 2019-06-13  Pedro Alves  <palves@redhat.com>
1588
1589         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1590         completer.
1591         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1592         "set" completers.
1593
1594 2019-06-13  Pedro Alves  <palves@redhat.com>
1595
1596         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1597         after item.
1598
1599 2019-06-13  Pedro Alves  <palves@redhat.com>
1600
1601         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1602
1603 2019-06-13  Pedro Alves <palves@redhat.com>
1604
1605         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1606         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1607         call.
1608         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1609         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1610         calls.
1611         (check_for_argument): Skip spaces after argument.
1612
1613 2019-06-13  Pedro Alves  <palves@redhat.com>
1614
1615         * thread.c (thread_apply_command): Adjust TID parsing.
1616         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1617         detected before end of string.
1618         (tid_is_in_list): Error out if LIST is invalid.
1619
1620 2019-06-13  Pedro Alves  <palves@redhat.com>
1621
1622         * completer.c (complete_line_internal_1): Rewind completion word
1623         point.
1624         (completion_tracker::advance_custom_word_point_by): Change
1625         parameter type to int.
1626         * completer.h (completion_tracker::advance_custom_word_point_by):
1627         Likewise.
1628
1629 2019-06-13  Pedro Alves  <palves@redhat.com>
1630
1631         * completer.c (advance_to_completion_word): Handle delimiters.
1632
1633 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1634
1635         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1636
1637 2019-06-11  Tom Tromey  <tom@tromey.com>
1638
1639         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1640         (xmalloc_failed): Move to alloc.c.
1641         * alloc.c: New file.
1642         * Makefile.in (COMMON_SFILES): Add alloc.c.
1643
1644 2019-06-11  Tom Tromey  <tom@tromey.com>
1645
1646         * nat/linux-waitpid.c: Don't include server.h.
1647         (linux_debug): Remove.
1648         (my_waitpid): Update.
1649
1650 2019-06-11  Tom Tromey  <tromey@adacore.com>
1651
1652         * infcall.c (_initialize_infcall): Remove trailing newline from
1653         help.
1654         * user-regs.c (_initialize_user_regs): Remove trailing newline
1655         from help.
1656         * typeprint.c (_initialize_typeprint): Remove trailing newline
1657         from help.
1658         * reverse.c (_initialize_reverse): Remove trailing newlines from
1659         help.
1660         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1661         from help.
1662         * language.c (add_set_language_command): Remove trailing newline
1663         from help.
1664         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1665         help.
1666         * disasm.c (_initialize_disasm): Remove trailing newline from
1667         help.
1668         * top.c (init_main): Remove trailing newline from help.
1669         * interps.c (_initialize_interpreter): Remove trailing newline
1670         from help.
1671         * btrace.c (_initialize_btrace): Remove trailing newlines from
1672         help.
1673         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1674         from help.
1675         * python/python.c (_initialize_python): Remove trailing newline
1676         from help.
1677         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1678         help.
1679         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1680         from help.  Reformat some text.
1681         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1682         from help.
1683         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1684         newline from help.
1685
1686 2019-06-11  Tom Tromey  <tromey@adacore.com>
1687
1688         * darwin-nat.c (darwin_decode_exception_message)
1689         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1690
1691 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1692
1693         * valops.c (value_slice): Check for not allocated or not
1694         associated values.
1695
1696 2019-06-10  Tom de Vries  <tdevries@suse.de>
1697
1698         PR gdb/24618
1699         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1700         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1701         invalid.
1702
1703 2019-06-10  Tom de Vries  <tdevries@suse.de>
1704
1705         PR gdb/24611
1706         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1707         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1708
1709 2019-06-10  Tom de Vries  <tdevries@suse.de>
1710
1711         PR symtab/24545
1712         * symtab.c (struct demangled_name_entry): Add language field.
1713         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1714         static minimal symbol".  Set and use language field.
1715
1716 2019-06-10  Tom Tromey  <tromey@adacore.com>
1717
1718         * ada-lang.c (_initialize_ada_language): Update help text.
1719
1720 2019-06-10  Tom Tromey  <tromey@adacore.com>
1721
1722         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1723         with a newline.
1724         * guile/guile.c (handle_boot_error): Don't end warning with a
1725         newline.
1726         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1727         warning with a newline.
1728         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1729         newline.
1730         (s12z_frame_cache): Likewise.
1731         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1732         a newline.
1733         * solib-svr4.c (disable_probes_interface): Don't end warning with
1734         a newline.
1735         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1736         newline.
1737         * python/python.c (do_finish_initialization): Don't end warning
1738         with a newline.
1739
1740 2019-06-10  Tom Tromey  <tom@tromey.com>
1741
1742         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1743         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1744         gdbpy_enter.
1745
1746 2019-06-10  Tom Tromey  <tromey@adacore.com>
1747
1748         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1749         data.
1750         (elf_new_init): Don't call stabsread_new_init.
1751         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1752         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1753         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1754
1755 2019-06-10  Tom de Vries  <tdevries@suse.de>
1756
1757         PR symtab/16264
1758         PR symtab/24517
1759         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1760
1761 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1762
1763         * source.c (find_and_open_source): Also rewrite relative file
1764         names.
1765
1766 2019-04-26  Amos Bird  <amosbird@gmail.com>
1767
1768         * annotate.c (annotate_thread_exited): Add "thread-exited"
1769         annotation.
1770
1771 2019-06-06  Tom Tromey  <tromey@adacore.com>
1772
1773         * maint.h (class scoped_command_stats): Use
1774         DISABLE_COPY_AND_ASSIGN.
1775         <print_time>: New method.
1776         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1777         print_time.
1778         (scoped_command_stats::print_time): New method.
1779
1780 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1781
1782         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1783         instructions of lengths 6 or 8 bytes.
1784
1785 2019-06-04  Pedro Alves  <palves@redhat.com>
1786
1787         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1788
1789         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1790         * breakpoint.c (condition_completer): Likewise.
1791         * cli/cli-dump.c (scan_expression): Likewise.
1792         * common/filestuff.c (mkdir_recursive): Likewise.
1793         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1794         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1795         (gdb_abspath): Likewise.
1796         * compile/compile-cplus-types.c
1797         (compile_cplus_instance::decl_name): Likewise.
1798         * completer.c (complete_explicit_location):
1799         (signal_completer, reg_or_group_completer_1): Likewise.
1800         * cp-support.c (cp_remove_params_if_any): Likewise.
1801         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1802         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1803         * infcmd.c (strip_bg_char): Likewise.
1804         * linespec.c (copy_token_string): Likewise.
1805         * mi/mi-main.c (output_cores): Likewise.
1806         * psymtab.c (psymtab_search_name):
1807         * symfile.c (test_set_ext_lang_command): Likewise.
1808         * target.c (target_fileio_read_stralloc): Likewise.
1809         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1810         * value.c (complete_internalvar): Likewise.
1811
1812 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1813
1814         Add objfile property to gdb.Type.
1815         * NEWS: Mention Python API addition.
1816         * python/py-type.c (typy_get_objfile): New method.
1817
1818 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1819
1820         * NEWS: Mention the new set|show style [title|highlight].
1821         Mention changes to "show style", "help" and "apropos".
1822
1823 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1824
1825         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1826         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1827         instead of print_help_for_command.
1828         (print_doc_of_command): New function.
1829         (help_list): Add 'apropos -v word' suggestion.
1830         (print_help_for_command): Style the command name using title style.
1831         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1832         (_initialize_cli_cmds): Describe -v in apropos_command help.
1833
1834 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1835
1836         * cli/cli-style.h (cli_style_option): Add name in constructor,
1837         add m_name class member, add constructor with intensity,
1838         add name class function.
1839         (cli_style_option::add_setshow_commands): Remove name argument.
1840         (highlight_style, title_style): New styles.
1841         * cli/cli-style.c (do_show): New function that shows a style
1842         characteristic styling the style name with itself.
1843         (set_style_name): New function.
1844         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1845         Update all callers according to the changes in cli/cli-style.h.
1846         * utils.h (fputs_highlighted): New function.
1847         * utils.c (fputs_highlighted): Likewise.
1848
1849 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1850
1851         * NEWS: Mention new pipe command and new convenience variables.
1852
1853 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1854
1855         * cli/cli-cmds.c (pipe_command): New function.
1856         (_initialize_cli_cmds): Call add_com for pipe_command.
1857         Define | as an alias for pipe.
1858         (exit_status_set_internal_vars): New function.
1859         (shell_escape): Call exit_status_set_internal_vars.
1860         cli/cli-decode.c (find_command_name_length): Recognize | as
1861         a single character command.
1862
1863 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1864
1865         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1866         top.c (execute_command_to_ui_file): New function, mostly a copy
1867         of execute_command_to_string.
1868         (execute_command_to_string): Implement by calling
1869         execute_command_to_ui_file.
1870
1871 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1872
1873         * top.h (saved_command_line): Remove declaration.
1874         * top.c (previous_saved_command_line, previous_repeat_arguments):
1875         New variables.
1876         (saved_command_line): Make static, define together with other
1877         'repeat variables'.
1878         (dont_repeat): Clear repeat_arguments.
1879         (repeat_previous, get_saved_command_line, save_command_line):
1880         New functions.
1881         (gdb_init): Initialize saved_command_line
1882         and previous_saved_command_line.
1883         * main.c (captured_main_1): Remove saved_command_line initialization.
1884         * event-top.c (handle_line_of_input): Update to use
1885         the new 'repeat' related functions instead of direct access to
1886         saved_command_line.
1887         * command.h (repeat_previous, get_saved_command_line,
1888         save_command_line): New declarations.
1889         (dont_repeat): Add comment.
1890
1891 2019-05-30  Tom Tromey  <tromey@adacore.com>
1892
1893         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1894         Fix comment.
1895         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1896
1897 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1898
1899         PR cli/24587
1900         * completer.c (complete): Initialize variable word.
1901
1902 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1903
1904         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1905         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1906         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1907         'body' is NULL to the outter 'if', protecting the '!is_define'
1908         situation as well.
1909
1910 2019-05-29  Tom Tromey  <tromey@adacore.com>
1911
1912         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1913         (dwarf_unknown): New function.
1914         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1915         (dwarf_type_encoding_name): Use dwarf_unknown.
1916
1917 2019-05-29  Tom Tromey  <tromey@adacore.com>
1918
1919         PR c++/20020:
1920         * cp-valprint.c (cp_print_value_fields): Call
1921         cp_print_static_field inside "try".
1922
1923 2019-05-29  Tom Tromey  <tromey@adacore.com>
1924
1925         * inflow.c (struct terminal_info): Add default operator=.
1926         * configure: Rebuild.
1927         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1928         -Wdeprecated-copy-dtor, -Wredundant-move.
1929
1930 2019-05-29  Tom Tromey  <tromey@adacore.com>
1931
1932         * NEWS: Add entry.
1933         * infcmd.c (print_return_value_1): Handle finish_print
1934         option.
1935         (show_print_finish): New function.
1936         (_initialize_infcmd): Add "set/show print finish" commands.
1937         * valprint.c (user_print_options): Initialize new member.
1938         * valprint.h (struct value_print_options) <finish_print>: New
1939         member.
1940
1941 2019-05-28  Tom Tromey  <tromey@adacore.com>
1942
1943         * ada-lang.c (ada_remove_Xbn_suffix)
1944         (find_old_style_renaming_symbol)
1945         (parse_old_style_renaming): Remove.
1946         (ada_find_renaming_symbol): Don't call
1947         find_old_style_renaming_symbol.
1948         (ada_is_renaming_symbol): Rename from
1949         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1950         bool.  Now static.
1951         (ada_read_var_value): Update and simplify.
1952         * ada-exp.y (write_var_or_type): Remove old code.
1953
1954 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1955
1956         * event-top.c: Remove include comment.
1957         * inflow.c (class scoped_ignore_sigttou): Move from here...
1958         * inflow.h (class scoped_ignore_sigttou): ...to here.
1959         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1960         * top.c:  Remove include comment.
1961
1962 2019-05-27  Tom Tromey  <tom@tromey.com>
1963
1964         * NEWS: Fix typo.
1965
1966 2019-05-22  Tom Tromey  <tromey@adacore.com>
1967
1968         * target.c (target_follow_exec): Constify parameter.
1969         * target-delegates.c: Rebuild.
1970         * remote.c (remote_target::follow_exec): Constify parameter.
1971         * infrun.c (follow_exec): Constify parameter.
1972         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1973         (target_follow_exec): Likewise.
1974
1975 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1976
1977         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1978         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1979
1980 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1981
1982         * NEWS: Add debugredirect and testsuite sections.
1983
1984 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1985
1986         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1987         target descriptions using exclusively floating point register name
1988         aliases.
1989
1990 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1991
1992         PR gdb/18644:
1993         * f-lang.c (build_fortran_types): Handle the case where
1994         gdbarch_floatformat_for_type returns a nullptr.
1995
1996 2019-05-21  Tom de Vries  <tdevries@suse.de>
1997
1998         PR cli/24587
1999         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2000
2001 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2002
2003         PR gdb/18644:
2004         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2005         16-byte floats.
2006         * i386-tdep.c (i386_floatformat_for_type): Use
2007         floatformats_ia64_quad for the 16-byte floating point component
2008         within a fortran 32-byte complex number.
2009
2010 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2011
2012         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2013         delete default constructor.
2014         (find_partial_die): Update to return const struct.
2015         (partial_die_parent_scope): Move variable declaration into scope
2016         of its use and change its type to auto.
2017         (guess_partial_die_structure_name): Likewise.
2018         (partial_die_info::fixup): Likewise.
2019
2020 2019-05-17  Tom Tromey  <tromey@adacore.com>
2021
2022         * source.c (find_and_open_source): Remove cast.
2023
2024 2019-05-17  Tom Tromey  <tromey@adacore.com>
2025
2026         * annotate.c (annotate_source): Make "filename" const.
2027         * annotate.h (annotate_source): Use const.
2028
2029 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2030
2031         * disasm.c (set_disassembler_options): Send errors to stderr.
2032
2033 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2034
2035         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2036         (cli_interp_base::set_logging): Check debug_redirect.
2037         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2038         * cli/cli-logging.c (debug_redirect): Add static variable.
2039         (pop_output_files): Add default param.
2040         (handle_redirections): Print debug setting.
2041         (show_logging_command): Likewise.
2042         (_initialize_cli_logging): Add debugredirect command.
2043         * interps.c (current_interp_set_logging): Add debug_redirect
2044         parameter.
2045         * interps.h (set_logging): Add debug_redirect parameter.
2046         (current_interp_set_logging): Likewise.
2047         * mi/mi-common.h: Likewise.
2048         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2049
2050 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2051             Tom Tromey  <tromey@adacore.com>
2052
2053         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2054         directly.
2055         * cli/cli-interp.h (make_logging_output): Remove declaration.
2056         * cli/cli-logging.c (make_logging_output): Remove function.
2057         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2058         directly.
2059         * ui-file.c (tee_file::tee_file): Remove bools.
2060         (tee_file::~tee_file): Remove deletes.
2061         * ui-file.h (tee_file): Remove bools.
2062
2063 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2064
2065         * mi/mi-cmds.h (mi_cmd_complete): New function.
2066         * mi/mi-main.c (mi_cmd_complete): Likewise.
2067         * mi/mi-cmds.c: Define new MI command -complete.
2068         * NEWS: Mention new -complete command.
2069
2070 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2071
2072         * completer.h (complete): New function.
2073         * completer.c (complete): Likewise.
2074         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2075         function defined in completer.h.
2076
2077 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2078
2079         * MAINTAINERS (Write After Approval): Add myself.
2080
2081 2019-05-17  Tom de Vries  <tdevries@suse.de>
2082
2083         PR gdb/24094
2084         * dwarf2read.c (struct cu_partial_die_info): New struct.
2085         (find_partial_die): Return cu_partial_die_info.
2086         (partial_die_parent_scope, guess_partial_die_structure_name)
2087         (partial_die_info::fixup): Handle new return type of find_partial_die.
2088
2089 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2090
2091         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2092         "std::string", simplifying the algorithm.
2093
2094 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2095
2096         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2097         (stap_static_probe_ops::get_probes): Likewise.
2098
2099 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2100
2101         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2102         '-')" and "else if".
2103         (stap_parse_single_operand): Join checks for
2104         "gdbarch_stap_parse_special_token_p" and
2105         "gdbarch_stap_parse_special_token" in the same "if" statement.
2106         Invert check when verifying for operation on register
2107         displacement.
2108
2109 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2110
2111         * stap-probe.c (stap_get_opcode): Update comment.
2112         (stap_get_expected_argument_type): Likewise.
2113         (handle_stap_probe): Likewise.
2114
2115 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2116
2117         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2118         return type to 'bool'.  Adjust comment.  Use 'bool' when
2119         appropriate.
2120         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2121         * stap-probe.c (stap_parse_argument_1): Likewise.
2122         (stap_is_operator): Likewise.
2123         (stap_is_generic_prefix): Likewise.
2124         (stap_is_register_prefix): Likewise.
2125         (stap_is_register_indirection_prefix): Likewise.
2126         (stap_is_integer_prefix): Likewise.
2127         (stap_generic_check_suffix): Likewise.
2128         (stap_check_integer_suffix): Likewise.
2129         (stap_check_register_suffix): Likewise.
2130         (stap_check_register_indirection_suffix): Likewise.
2131         (stap_parse_register_operand): Likewise.
2132         (stap_parse_single_operand): Likewise.
2133         (stap_parse_argument_1): Likewise.
2134         (stap_probe::get_argument_count): Likewise.
2135         (stap_is_operator): Likewise.
2136
2137 2019-05-16  Tom Tromey  <tromey@adacore.com>
2138
2139         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2140         keyword to foreach.
2141
2142 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2143
2144         * linux-thread-db.c (try_thread_db_load_1): Change return type
2145         to bool.
2146         (try_thread_db_load): Likewise.
2147         (try_thread_db_load_from_pdir_1): Likewise.
2148         (try_thread_db_load_from_pdir): Likewise.
2149         (try_thread_db_load_from_sdir): Likewise.
2150         (try_thread_db_load_from_dir): Likewise.
2151         (thread_db_load_search): Likewise.
2152         (has_libpthread): Likewise.
2153         (thread_db_load): Likewise.
2154
2155 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2156
2157         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2158         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2159         NULL, and complain/return if that's the case.
2160
2161 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2162
2163         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2164         (advance, posn, abstract_read_memory): New functions.
2165         [struct mem_read_abstraction]: New struct.
2166         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2167
2168 2019-05-14  Tom Tromey  <tromey@adacore.com>
2169
2170         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2171         value is not lval_memory.
2172
2173 2019-05-14  Tom Tromey  <tromey@adacore.com>
2174
2175         * solib.c (info_sharedlibrary_command): Style the file name.
2176
2177 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2178
2179         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2180         (aarch64_vnv_type): Likewise.
2181         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2182         * common/tdesc.c: Likewise.
2183         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2184         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2185         * features/aarch64-fpu.xml: Add ieee half view.
2186         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2187         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2188         * gdbtypes.h (struct builtin_type): Likewise.
2189         (struct objfile_type): Likewise.
2190
2191 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2192
2193         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2194         typo.
2195         * location.h (string_to_event_location): Likewise.
2196
2197 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2198
2199         GDB 8.3 released.
2200
2201 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2202
2203         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2204         New variable declaration.
2205         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2206         New variable.
2207         (print_one_breakpoint): Use ui_out::test_flags and new global
2208         variable to compute use_fixed_output.
2209         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2210         Remove.
2211         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2212         (mi_multi_location_breakpoint_output_fixed): Remove.
2213         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2214         new variable.
2215         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2216         fix_multi_location_breakpoint_output flag if version >= 3.
2217         * ui-out.h (enum ui_out_flag)
2218         <fix_multi_location_breakpoint_output>: New enumerator.
2219
2220 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2221
2222         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2223
2224 2019-05-10  Tom Tromey  <tromey@adacore.com>
2225
2226         * ada-lang.c (catch_ada_completer): New function.
2227         (_initialize_ada_language): Use it.
2228
2229 2019-05-10  Tom Tromey  <tromey@adacore.com>
2230
2231         * thread.c (print_thread_info): Make "requested_threads" const.
2232         * gdbthread.h (print_thread_info): Make "requested_threads"
2233         const.
2234         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2235         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2236
2237 2019-05-08  Tom Tromey  <tom@tromey.com>
2238
2239         * gdbtypes.c (objfile_type_data): Change type.
2240         (objfile_type, _initialize_gdbtypes): Update.
2241
2242 2019-05-08  Tom Tromey  <tom@tromey.com>
2243
2244         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2245         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2246         (_initialize_dwarf2_frame): Update.
2247
2248 2019-05-08  Tom Tromey  <tom@tromey.com>
2249
2250         * objc-lang.c (objc_objfile_data): Change type.
2251         (find_methods): Update.
2252         (_initialize_objc_lang): Remove.
2253
2254 2019-05-08  Tom Tromey  <tom@tromey.com>
2255
2256         * stabsread.c (rs6000_builtin_type_data): Change type.
2257         (rs6000_builtin_type, _initialize_stabsread): Update.
2258
2259 2019-05-08  Tom Tromey  <tom@tromey.com>
2260
2261         * mips-tdep.c (mips_pdr_data): Remove.
2262         (_initialize_mips_tdep): Update.
2263
2264 2019-05-08  Tom Tromey  <tom@tromey.com>
2265
2266         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2267         (hppa_init_objfile_priv_data, read_unwind_info)
2268         (find_unwind_entry, _initialize_hppa_tdep): Update.
2269
2270 2019-05-08  Tom Tromey  <tom@tromey.com>
2271
2272         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2273         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2274         on obstack.
2275         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2276
2277 2019-05-08  Tom Tromey  <tom@tromey.com>
2278
2279         * mdebugread.c (basic_type_data): Change type.
2280         (basic_type, _initialize_mdebugread): Update.
2281
2282 2019-05-08  Tom Tromey  <tom@tromey.com>
2283
2284         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2285
2286 2019-05-08  Tom Tromey  <tom@tromey.com>
2287
2288         * nto-tdep.c (nto_inferior_data_reg): Change type.
2289         (nto_inferior_data): Update.
2290         (nto_inferior_data_cleanup, nto_new_inferior_data)
2291         (_initialize_nto_tdep): Remove.
2292         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2293
2294 2019-05-08  Tom Tromey  <tom@tromey.com>
2295
2296         * ada-lang.c (struct ada_inferior_data): Add initializers.
2297         (ada_inferior_data): Change type.
2298         (ada_inferior_data_cleanup): Remove.
2299         (get_ada_inferior_data, ada_inferior_exit)
2300         (struct ada_pspace_data): Add initializers, destructor.
2301         (ada_pspace_data_handle): Change type.
2302         (get_ada_pspace_data): Update.
2303         (ada_pspace_data_cleanup): Remove.
2304
2305 2019-05-08  Tom Tromey  <tom@tromey.com>
2306
2307         * coffread.c (struct coff_symfile_info): Add initializers.
2308         (coff_objfile_data_key): Move lower.  Change type.
2309         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2310         Update.
2311         (coff_free_info): Remove.
2312
2313 2019-05-08  Tom Tromey  <tom@tromey.com>
2314
2315         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2316         (fbsd_pspace_data_handle): Move lower.  Change type.
2317         (get_fbsd_pspace_data): Update.
2318         (fbsd_pspace_data_cleanup): Remove.
2319         (_initialize_fbsd_tdep): Update.
2320
2321 2019-05-08  Tom Tromey  <tom@tromey.com>
2322
2323         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2324         (get_ada_tasks_pspace_data): Update.
2325         (ada_tasks_pspace_data_cleanup): Remove.
2326         (_initialize_tasks): Update.
2327         (ada_tasks_inferior_data_handle): Change type.
2328         (get_ada_tasks_inferior_data): Update.
2329         (ada_tasks_inferior_data_cleanup): Remove.
2330         (struct ada_tasks_pspace_data): Add initializers.
2331
2332 2019-05-08  Tom Tromey  <tom@tromey.com>
2333
2334         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2335         * symfile-debug.c (debug_sym_get_probes): Change type.
2336         * stap-probe.c (handle_stap_probe):
2337         (stap_static_probe_ops::get_probes): Change type.
2338         * probe.h (class static_probe_ops) <get_probes>: Change type.
2339         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2340         (parse_probes_in_pspace): Update.
2341         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2342         Update.
2343         (any_static_probe_ops::get_probes): Change type.
2344         * elfread.c (elfread_data): New typedef.
2345         (probe_key): Change type.
2346         (elf_get_probes): Likewise.  Update.
2347         (probe_key_free): Remove.
2348         (_initialize_elfread): Update.
2349         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2350         Change type.
2351         (dtrace_process_dof_probe, dtrace_process_dof)
2352         (dtrace_static_probe_ops::get_probe): Change type.
2353
2354 2019-05-08  Tom Tromey  <tom@tromey.com>
2355
2356         * xcoffread.c (struct xcoff_symfile_info): Rename from
2357         coff_symfile_info.  Add initializers.
2358         (xcoff_objfile_data_key): Move lower.  Change type.
2359         (XCOFF_DATA): Rewrite.
2360         (xcoff_free_info): Remove.
2361         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2362         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2363         (xcoff_initial_scan): Update.
2364
2365 2019-05-08  Tom Tromey  <tom@tromey.com>
2366
2367         * solib-svr4.c (struct svr4_info): Add initializers and
2368         destructor.
2369         <probes_table>: Now an htab_up.
2370         (solib_svr4_pspace_data): Change type.
2371         (free_probes_table): Simplify.
2372         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2373         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2374         (probes_table_remove_objfile_probes, register_solib_event_probe)
2375         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2376         (_initialize_svr4_solib): Update.
2377
2378 2019-05-08  Tom Tromey  <tom@tromey.com>
2379
2380         * remote.c (remote_pspace_data): Change type.
2381         (remote_pspace_data_cleanup): Remove.
2382         (get_remote_exec_file, set_pspace_remote_exec_file)
2383         (_initialize_remote): Update.
2384
2385 2019-05-08  Tom Tromey  <tom@tromey.com>
2386
2387         * breakpoint.c (breakpoint_objfile_key): Change type.
2388         (get_breakpoint_objfile_data): Update.
2389         (free_breakpoint_objfile_data): Remove.
2390         (_initialize_breakpoint): Update.
2391
2392 2019-05-08  Tom Tromey  <tom@tromey.com>
2393
2394         * linux-tdep.c (struct linux_info): Add initializers.
2395         (linux_inferior_data): Move.  Change type.
2396         (invalidate_linux_cache_inf): Update.
2397         (linux_inferior_data_cleanup): Remove.
2398         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2399
2400 2019-05-08  Tom Tromey  <tom@tromey.com>
2401
2402         * auxv.c (auxv_inferior_data): Move.  Change type.
2403         (auxv_inferior_data_cleanup): Remove.
2404         (invalidate_auxv_cache_inf): Rewrite.
2405         (get_auxv_inferior_data, _initialize_auxv): Update.
2406
2407 2019-05-08  Tom Tromey  <tom@tromey.com>
2408
2409         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2410         (symfile_debug_objfile_data_key): Change type.
2411         (symfile_debug_installed, debug_qf_has_symbols)
2412         (debug_qf_find_last_source_symtab)
2413         (debug_qf_forget_cached_source_info)
2414         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2415         (debug_qf_print_stats, debug_qf_dump)
2416         (debug_qf_expand_symtabs_for_function)
2417         (debug_qf_expand_all_symtabs)
2418         (debug_qf_expand_symtabs_with_fullname)
2419         (debug_qf_map_matching_symbols)
2420         (debug_qf_expand_symtabs_matching)
2421         (debug_qf_find_pc_sect_compunit_symtab)
2422         (debug_qf_map_symbol_filenames)
2423         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2424         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2425         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2426         (debug_sym_read_linetable, debug_sym_relocate): Update.
2427         (symfile_debug_free_objfile): Remove.
2428         (install_symfile_debug_logging, _initialize_symfile_debug):
2429         Update.
2430
2431 2019-05-08  Tom Tromey  <tom@tromey.com>
2432
2433         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2434         allocate_on_obstack.
2435         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2436         (get_dwarf2_per_objfile): Update.
2437         (set_dwarf2_per_objfile): Remove.
2438         (dwarf2_has_info, dwarf2_get_section_info): Update.
2439         (dwarf2_free_objfile): Remove.
2440         (_initialize_dwarf2_read): Update.
2441
2442 2019-05-08  Tom Tromey  <tom@tromey.com>
2443
2444         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2445         initializers.
2446         <unsupported_script_warning_printed,
2447         script_not_found_warning_printed>: Now bool.
2448         (auto_load_pspace_data): Change type.
2449         (~auto_load_pspace_info): Rename from
2450         auto_load_pspace_data_cleanup.
2451         (get_auto_load_pspace_data, init_loaded_scripts_info)
2452         (clear_section_scripts, maybe_print_unsupported_script_warning)
2453         (maybe_print_script_not_found_warning, _initialize_auto_load):
2454         Update.
2455
2456 2019-05-08  Tom Tromey  <tom@tromey.com>
2457
2458         * objfiles.c (objfile_pspace_info): Add destructor and
2459         initializers.
2460         (objfiles_pspace_data): Change type.
2461         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2462         (get_objfile_pspace_data): Update.
2463         (objfiles_bfd_data): Change type.
2464         (get_objfile_bfd_data): Update.
2465         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2466
2467 2019-05-08  Tom Tromey  <tom@tromey.com>
2468
2469         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2470         Change type.
2471         (get_catch_syscall_inferior_data): Update.
2472         (catch_syscall_inferior_data_cleanup): Remove.
2473         (_initialize_break_catch_syscall): Update.
2474
2475 2019-05-08  Tom Tromey  <tom@tromey.com>
2476
2477         * inflow.c (struct terminal_info): Add destructor and
2478         initializers.
2479         (inflow_inferior_data): Change type.
2480         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2481         (get_inflow_inferior_data, inflow_inferior_exit)
2482         (swap_terminal_info, _initialize_inflow): Update.
2483
2484 2019-05-08  Tom Tromey  <tom@tromey.com>
2485
2486         * target-dcache.c (target_dcache_cleanup): Remove.
2487         (target_dcache_aspace_key): Change type.
2488         (target_dcache_init_p, target_dcache_invalidate)
2489         (target_dcache_get, target_dcache_get_or_init)
2490         (_initialize_target_dcache): Update.
2491         * dcache.h (struct dcache_deleter): New.
2492
2493 2019-05-08  Tom Tromey  <tom@tromey.com>
2494
2495         * symtab.c (struct symbol_cache): Add destructor and
2496         initializers.
2497         (symbol_cache_key): Move.  Change type.
2498         (make_symbol_cache, free_symbol_cache): Remove.
2499         (get_symbol_cache): Update.
2500         (symbol_cache_cleanup): Remove.
2501         (ALL_PSPACES, symbol_cache_flush)
2502         (maintenance_print_symbol_cache)
2503         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2504         Update.
2505
2506 2019-05-08  Tom Tromey  <tom@tromey.com>
2507
2508         * symtab.c (struct main_info): Add destructor and initializers.
2509         (main_progspace_key): Move.  Change type.
2510         (get_main_info): Update.
2511         (main_info_cleanup): Remove.
2512         (_initialize_symtab): Update.
2513
2514 2019-05-08  Tom Tromey  <tom@tromey.com>
2515
2516         * registry.h (DECLARE_REGISTRY): Define the _key class.
2517
2518 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2519
2520         * NEWS: Merge two 'New commands' sections.
2521
2522 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2523
2524         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2525         parameter and use Ada language definition instead.
2526         (ada_val_print_ptr): Remove unused language parameter.
2527         (ada_val_print_num): Remove language parameter and use Ada language
2528         definition instead.
2529         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2530         parameter.
2531         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2532         parameter and use Ada language definition instead.
2533         (ada_val_print_1): Update all ada_val_print_xxx calls.
2534         Remove language parameter.
2535         (ada_val_print): Update ada_val_print_1 call.
2536
2537 2019-05-08  Tom Tromey  <tromey@adacore.com>
2538
2539         * remote.c (remote_hw_watchpoint_limit)
2540         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2541         Now static.
2542
2543 2019-05-08  Tom Tromey  <tromey@adacore.com>
2544
2545         * maint.c (_initialize_maint_cmds): Move initialization code to
2546         remote.c.
2547         (watchdog, show_watchdog): Move to remote.c.
2548         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2549         "watchdog" static.
2550         (_initialize_remote): Move initialization code from maint.c.
2551         * defs.h (watchdog): Don't declare.
2552
2553 2019-05-08  Tom Tromey  <tromey@adacore.com>
2554
2555         * tui/tui-interp.c: Include main.h.
2556         * interps.c: Include main.h.
2557         * main.h (interpreter_p): Declare.
2558         * defs.h (interpreter_p): Don't declare.
2559
2560 2019-05-08  Tom Tromey  <tromey@adacore.com>
2561
2562         * dwarf2loc.c: Include dwarf2read.h.
2563         * defs.h (read_unsigned_leb128): Don't declare.
2564         * dwarf2read.h (read_unsigned_leb128): Declare.
2565
2566 2019-05-08  Tom Tromey  <tromey@adacore.com>
2567
2568         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2569         method.
2570
2571 2019-05-08  Tom Tromey  <tromey@adacore.com>
2572
2573         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2574         when no wrap column is set.
2575
2576 2019-05-08  Tom Tromey  <tromey@adacore.com>
2577
2578         * c-lang.c (c_get_string): Handle non-C-style arrays.
2579
2580 2019-05-08  Tom Tromey  <tromey@adacore.com>
2581
2582         * typeprint.c (print_offset_data::update): Print the bit offset,
2583         not the number of bits remaining.
2584
2585 2019-05-08  Tom Tromey  <tromey@adacore.com>
2586
2587         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2588         padding at end of comment.
2589
2590 2019-05-08  Tom Tromey  <tromey@adacore.com>
2591
2592         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2593         Compare main types.
2594
2595 2019-05-06  Tom Tromey  <tom@tromey.com>
2596
2597         * common/scoped_mmap.c: Include common-defs.h.
2598         * common/scoped_mmap.h: Don't include config.h.
2599
2600 2019-05-04  Tom Tromey  <tom@tromey.com>
2601
2602         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2603         (struct aarch64_call_info): Add initializers.
2604         <si>: Now a std::vector.
2605         (pass_on_stack, aarch64_push_dummy_call): Update.
2606
2607 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2608             Tom Tromey  <tom@tromey.com>
2609
2610         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2611         (ppc_threads): Now a std::vector.  Now static.
2612         (hwdebug_find_thread_points_by_tid)
2613         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2614         Update.
2615
2616 2019-05-04  Tom Tromey  <tom@tromey.com>
2617
2618         * arc-tdep.c (arc_tdesc_init): Return bool.
2619
2620 2019-05-04  Tom Tromey  <tom@tromey.com>
2621
2622         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2623         Use gdb_assert_not_reached.
2624
2625 2019-05-04  Tom Tromey  <tom@tromey.com>
2626
2627         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2628         "false".
2629
2630 2019-05-04  Tom Tromey  <tom@tromey.com>
2631
2632         * arc-tdep.c (arc_tdesc_init): Use bool.
2633
2634 2019-05-04  Tom Tromey  <tom@tromey.com>
2635
2636         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2637
2638 2019-05-04  Tom Tromey  <tom@tromey.com>
2639
2640         * cli/cli-cmds.c (valid_command_p): Return bool.
2641
2642 2019-05-04  Tom Tromey  <tom@tromey.com>
2643
2644         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2645         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2646
2647 2019-05-04  Raul Tambre  <raul@tambre.ee>
2648
2649         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2650         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2651         operator for comparison.
2652
2653 2019-05-04  Tom Tromey  <tom@tromey.com>
2654
2655         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2656         (lookup_partial_symbol, print_partial_symbols)
2657         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2658         (psymbol_compare): Update.
2659         (add_psymbol_to_bcache): Clear the entire psymbol.
2660         (maintenance_check_psymtabs): Update.
2661         * psympriv.h (struct partial_symbol): Don't derive from
2662         general_symbol_info.
2663         <obj_section, unrelocated_address, address,
2664         set_unrelocated_address>: Update.
2665         <ginfo>: New member.
2666         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2667         (debug_names::write_psymbols): Update.
2668
2669 2019-05-04  Tom de Vries  <tdevries@suse.de>
2670
2671         * contrib/cc-with-tweaks.sh: Support -n arg.
2672
2673 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2674
2675         * corelow.c (core_target::detach): Ensure frame cache and
2676         register caches are cleared.
2677         inferior.c (exit_inferior_1): Likewise.
2678
2679 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2680             Tom Tromey  <tom@tromey.com>
2681
2682         * dictionary.c (collate_pending_symbols_by_language): Remove
2683         "struct" from foreach.
2684         * symtab.c (lookup_global_symbol_from_objfile)
2685         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2686         foreach.
2687         * ser-tcp.c (net_open): Remove "struct" from foreach.
2688         * objfiles.c (objfile_relocate, objfile_rebase)
2689         (objfile_has_symbols): Remove "struct" from foreach.
2690         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2691         from foreach.
2692         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2693         foreach.
2694         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2695         "struct" from foreach.
2696         * ada-lang.c (create_excep_cond_exprs)
2697         (ada_exception_catchpoint_cond_string): Remove "struct" from
2698         foreach.
2699
2700 2019-05-03  Tom Tromey  <tromey@adacore.com>
2701
2702         * ada-exp.y (convert_char_literal): Check suffix of each
2703         enumerator.
2704
2705 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2706
2707         PR ada/21406:
2708         * ada-exp.y (yywrap): Don't define.
2709         * ada-lex.l (%option): Add noyywrap
2710         (yywrap): Remove.
2711
2712 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2713
2714         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2715         _WIN32_WINNT to the XP level, unless already defined to a higher
2716         level.
2717
2718         * unittests/parse-connection-spec-selftests.c:
2719         * ser-tcp.c:
2720         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2721         override.
2722
2723         * symfile.c (find_separate_debug_file): Remove colon from the
2724         drive spec of DOS/Windows file names of the target, so that the
2725         file name produced from DEBUGDIR and the target's directory will
2726         be valid on DOS/Windows systems.
2727
2728 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2729
2730         * rust-lang.c (val_print_struct): Handle printing structures
2731         containing strings.
2732
2733 2019-05-02  Tom Tromey  <tromey@adacore.com>
2734
2735         * valarith.c (_initialize_valarith): Remove.
2736
2737 2019-05-01  Tom Tromey  <tromey@adacore.com>
2738
2739         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2740         bitfields.
2741
2742 2019-05-01  Tom Tromey  <tromey@adacore.com>
2743
2744         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2745         for big-endian copies.
2746
2747 2019-04-30  Ali Tamur  <tamur@google.com>
2748         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2749         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2750         (read_3_bytes): New function.
2751
2752 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2753
2754         * windows-nat.c (main_thread_id): Delete.
2755         (handle_output_debug_string): Replace main_thread_id by
2756         current_event.dwThreadId.
2757         (fake_create_process): Likewise.
2758         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2759         Do not set main_thread_id.
2760         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2761         current_event.dwThreadId.
2762         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2763
2764 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2765
2766         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2767         Use current_event.dwThreadId instead of main_thread_id.
2768
2769 2019-04-30  Tom Tromey  <tromey@adacore.com>
2770
2771         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2772         (create_excep_cond_exprs): Iterate over program spaces.
2773         (ada_exception_catchpoint_cond_string): Examine all minimal
2774         symbols for exception types.
2775
2776 2019-04-30  Tom Tromey  <tromey@adacore.com>
2777
2778         PR c++/24470:
2779         * dwarf2read.c (process_structure_scope): Handle case where type
2780         has template parameters but no symbol was created.
2781
2782 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2783             Chris January  <chris.january@arm.com>
2784
2785         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2786         qualifier.
2787         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2788
2789 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         * f-typeprint.c (f_print_type): Update rules for printing
2792         whitespace.
2793         (f_type_print_varspec_suffix): Likewise.
2794
2795 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2796             Chris January  <chris.january@arm.com>
2797
2798         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2799         function arguments.
2800
2801 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2802
2803         * f-lang.c (build_fortran_types): Change name of void type to
2804         lower case.
2805         * f-typeprint.c (f_type_print_base): Print the name of the void
2806         type, rather than a fixed string.
2807         * f-valprint.c (f_decorations): Use lower case void string.
2808
2809 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2810             Chris January  <chris.january@arm.com>
2811
2812         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2813         types for Fortran.
2814
2815 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2816             Chris January  <chris.january@arm.com>
2817             David Lecomber  <david.lecomber@arm.com>
2818
2819         * f-exp.y (BINOP_INTRINSIC): New token.
2820         (exp): New parser rule handling BINOP_INTRINSIC.
2821         (f77_keywords): Add new builtin procedures.
2822         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2823         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2824         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2825         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2826         (print_unop_subexp_f): New function.
2827         (print_binop_subexp_f): New function.
2828         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2829         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2830         (dump_subexp_body_f): Likewise.
2831         (operator_check_f): Likewise.
2832         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2833         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2834
2835 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2836
2837         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2838         UNOP_KIND.
2839         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2840         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2841         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2842         (operator_length_f): New fuction.
2843         (print_subexp_f): New function.
2844         (op_name_f): New function.
2845         (dump_subexp_body_f): New function.
2846         (operator_check_f): New function.
2847         (exp_descriptor_f): Replace standard expression handling functions
2848         with new functions.
2849         * gdb/fortran-operator.def: New file.
2850         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2851         * gdb/std-operator.def: Remove UNOP_KIND.
2852
2853 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2854
2855         * std-operator.def: Remove unbalanced, stray double quote
2856         character.
2857
2858 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2859             Chris January  <chris.january@arm.com>
2860             Daniel Everett  <daniel.everett@arm.com>
2861             Nick Forrington  <nick.forrington@arm.com>
2862             Richard Bunt  <richard.bunt@arm.com>
2863
2864         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2865         of depth when printing anonymous structs or unions.
2866         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2867         Don't print either the top-level value, or the children if the
2868         max-depth is exceeded.
2869         (ppscm_print_children): When printing the key of a map, allow one
2870         extra level of depth.
2871         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2872         print either the top-level value, or the children if the max-depth
2873         is exceeded.
2874         (print_children): When printing the key of a map, allow one extra
2875         level of depth.
2876         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2877         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2878         (user_print_options): Initialise max_depth field.
2879         (val_print_scalar_or_string_type_p): New function.
2880         (val_print): Check to see if the max depth has been reached.
2881         (val_print_check_max_depth): Define new function.
2882         (show_print_max_depth): New function.
2883         (_initialize_valprint): Add 'print max-depth' option.
2884         * valprint.h (struct value_print_options) <max_depth>: New field.
2885         (val_print_check_max_depth): Declare new function.
2886         * NEWS: Document new feature.
2887
2888 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2889
2890         * ada-lang.c (ada_language_defn): Initialise new field.
2891         * c-lang.c (c_is_string_type_p): New function.
2892         (c_language_defn): Initialise new field.
2893         (cplus_language_defn): Initialise new field.
2894         (asm_language_defn): Initialise new field.
2895         (minimal_language_defn): Initialise new field.
2896         * c-lang.h (c_is_string_type_p): Declare new function.
2897         * d-lang.c (d_language_defn): Initialise new field.
2898         * f-lang.c (f_is_string_type_p): New function.
2899         (f_language_defn): Initialise new field.
2900         * go-lang.c (go_is_string_type_p): New function.
2901         (go_language_defn): Initialise new field.
2902         * language.c (default_is_string_type_p): New function.
2903         (unknown_language_defn): Initialise new field.
2904         (auto_language_defn): Initialise new field.
2905         * language.h (struct language_defn) <la_is_string_type_p>: New
2906         member variable.
2907         (default_is_string_type_p): Declare new function.
2908         * m2-lang.c (m2_language_defn): Initialise new field.
2909         * objc-lang.c (objc_language_defn): Initialise new field.
2910         * opencl-lang.c (opencl_language_defn): Initialise new field.
2911         * p-lang.c (pascal_is_string_type_p): New function.
2912         (pascal_language_defn): Initialise new field.
2913         * rust-lang.c (rust_is_string_type_p): New function.
2914         (rust_language_defn): Initialise new field.
2915
2916 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2917
2918         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2919         New field.
2920         * ada-lang.c (ada_language_defn): Initialise new field.
2921         * c-lang.c (c_language_defn): Likewise.
2922         (cplus_language_defn): Likewise.
2923         (asm_language_defn): Likewise.
2924         (minimal_language_defn): Likewise.
2925         * d-lang.c (d_language_defn): Likewise.
2926         * f-lang.c (f_language_defn): Likewise.
2927         * go-lang.c (go_language_defn): Likewise.
2928         * language.c (unknown_language_defn): Likewise.
2929         (auto_language_defn): Likewise.
2930         * m2-lang.c (m2_language_defn): Likewise.
2931         * objc-lang.c (objc_language_defn): Likewise.
2932         * opencl-lang.c (opencl_language_defn): Likewise.
2933         * p-lang.c (pascal_language_defn): Likewise.
2934         * rust-lang.c (rust_language_defn): Likewise.
2935
2936 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2937
2938         * ada-lang.c (ada_is_character_type): Change return type to bool.
2939         (ada_is_string_type): Likewise.
2940         * ada-lang.h (ada_is_character_type): Update declaration
2941         (ada_is_string_type): Likewise.
2942
2943 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2944
2945         Support style in 'frame|thread apply'
2946
2947         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2948         * record.c (record_start, record_stop): Update callers of
2949         execute_command_to_string with false.
2950         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2951         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2952         methods.
2953         (class string_file): New constructor with term_out parameter.
2954         Override methods term_out and can_emit_style_escape.  New member
2955         term_out.
2956         (class stdio_file): Override can_emit_style_escape.
2957         (class tee_file): Override term_out and can_emit_style_escape.
2958         * utils.h (can_emit_style_escape): Remove.
2959         * utils.c (can_emit_style_escape): Likewise.
2960         Update all callers of can_emit_style_escape (SOMESTREAM) to
2961         SOMESTREAM->can_emit_style_escape.
2962         * source-cache.c (source_cache::get_source_lines): Likewise.
2963         * stack.c (frame_apply_command_count): Call execute_command_to_string
2964         passing the term_out characteristic of the current gdb_stdout.
2965         * thread.c (thr_try_catch_cmd): Likewise.
2966         * top.c (execute_command_to_string): pass term_out parameter
2967         to construct the string_file for the command output.
2968         * ui-file.c (term_cli_styling): New function (most code moved
2969         from utils.c can_emit_style_escape).
2970         (string_file::string_file, string_file::can_emit_style_escape,
2971         stdio_file::can_emit_style_escape, tee_file::term_out,
2972         tee_file::can_emit_style_escape): New functions.
2973
2974 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2975
2976         * NEWS: Mention the new set|show may-call-functions.
2977         * infcall.c (may_call_functions_p): New variable.
2978         (show_may_call_functions_p): New function.
2979         (call_function_by_hand_dummy): Throws an error if not
2980         may-call-functions.
2981         (_initialize_infcall): Call add_setshow_boolean_cmd for
2982         may-call-functions.
2983
2984 2019-04-25  Keith Seitz  <keiths@redhat.com>
2985
2986         PR c++/24367
2987         * cp-support.c (inspect_type): Don't attempt substitutions
2988         of symbol with the same name.
2989
2990 2019-04-25  Tom Tromey  <tromey@adacore.com>
2991
2992         PR gdb/24475:
2993         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2994         static.
2995
2996 2019-04-25  Tom Tromey  <tromey@adacore.com>
2997
2998         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2999         rvalue reference.
3000         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3001         (gdb_xml_parser::parse): Use std::move.
3002         * python/python-internal.h (gdbpy_convert_exception): Take a const
3003         reference.
3004         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3005         std::move.
3006         * python/py-utils.c (gdbpy_convert_exception): Take a const
3007         reference.
3008         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3009         Use std::move.
3010         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3011         Use std::move.
3012         * mi/mi-main.c (mi_print_exception): Take a const reference.
3013         * main.c (handle_command_errors): Take a const reference.
3014         * linespec.c (parse_linespec): Use std::move.
3015         * infcall.c (run_inferior_call): Use std::move.
3016         (call_function_by_hand_dummy): Use std::move.
3017         * exec.c (try_open_exec_file): Use std::move.
3018         * exceptions.h (exception_print, exception_fprintf)
3019         (exception_print_same): Update.
3020         * exceptions.c (print_exception, exception_print)
3021         (exception_fprintf, exception_print_same): Change parameters to
3022         const reference.
3023         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3024         * common/new-op.c: Use std::move.
3025         * common/common-exceptions.h (struct gdb_exception): Add move
3026         constructor.
3027         (struct gdb_exception_error, struct gdb_exception_quit, struct
3028         gdb_quit_bad_alloc): Change constructor to move constructor.
3029         (throw_exception): Change parameter to rvalue reference.
3030         * common/common-exceptions.c (throw_exception): Take rvalue
3031         reference.
3032         * cli/cli-interp.c (safe_execute_command): Use std::move.
3033         * breakpoint.c (insert_bp_location, location_to_sals): Use
3034         std::move.
3035
3036 2019-04-25  Tom Tromey  <tromey@adacore.com>
3037
3038         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3039         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3040         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3041         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3042         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3043         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3044         guile/scm-value.c: Use unpack.
3045         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3046         gdbscm_gdb_exception.
3047         (gdbscm_throw_gdb_exception): Likewise.
3048         (struct gdbscm_gdb_exception): New.
3049         (unpack): New function.
3050         (gdbscm_wrap): Use unpack.
3051
3052 2019-04-25  Tom Tromey  <tromey@adacore.com>
3053
3054         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3055         (gdb_rl_callback_handler): Use std::move.
3056         * common/common-exceptions.h (struct gdb_exception): Add move
3057         assignment operator.
3058         (throw_exception_sjlj): Change "exception" to const reference.
3059         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3060         (throw_exception_sjlj): Change "exception" to const reference.
3061
3062 2019-04-25  Tom Tromey  <tromey@adacore.com>
3063
3064         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3065         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3066         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3067         Update.
3068         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3069         Update.
3070         * mi/mi-interp.c (mi_interp::exec): Update.
3071         * linespec.c (parse_linespec): Update.
3072         * infcall.c (run_inferior_call): Update.
3073         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3074         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3075         (gdbscm_lookup_global_symbol): Update.
3076         * guile/scm-param.c (gdbscm_parameter_value): Update.
3077         * guile/scm-frame.c (gdbscm_frame_read_register)
3078         (gdbscm_frame_read_var): Update.
3079         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3080         * exec.c (try_open_exec_file): Update.
3081         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3082         (gdb_rl_callback_handler): Update.
3083         * common/common-exceptions.h (exception_none): Don't declare.
3084         * common/common-exceptions.c (exception_none): Don't define.
3085         (struct catcher) <exception>: Update.
3086         * cli/cli-interp.c (safe_execute_command): Update.
3087         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3088
3089 2019-04-25  Ali Tamur  <tamur@google.com>
3090
3091         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3092         (read_attribute_value): Likewise.
3093         (dwarf2_read_addr_index): Update comment.
3094         (read_str_index): Add DW_FORM_strx.
3095         (dwarf2_string_attr): Likewise.
3096         (dwarf2_const_value_attr): Likewise.
3097         (dump_die_shallow): Likewise.
3098         (dwarf2_fetch_constant_bytes): Likewise.
3099         (skip_form_bytes): Likewise.
3100         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3101
3102 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3103
3104         PR corefiles/11608
3105         PR corefiles/18187
3106         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3107         OFFSET.  Verify if current mapping contains an ELF header.
3108         (linux_find_memory_regions_full): Adjust call to
3109         dump_mapping_p.
3110
3111 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3112             Kang Li <kanglictf@gmail.com>
3113
3114         PR gdb/21600
3115
3116         * dwarf2-frame.c (read_initial_length): Be consistent about using
3117         unsigned representation of length.
3118         (decode_frame_entry_1): Likewise.  Check for wraparound of
3119         end pointer as well as buffer overflow.
3120
3121 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3122
3123         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3124         "vq".
3125
3126 2019-04-24  Tom Tromey  <tromey@adacore.com>
3127
3128         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3129
3130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3131
3132         * s12z-tdep.c (s12z_unwind_pc): Delete.
3133         (s12z_unwind_sp): Delete.
3134         (s12z_gdbarch_init): Don't register deleted functions with
3135         gdbarch.
3136
3137 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3138
3139         * rl78-tdep.c (rl78_unwind_sp): Delete.
3140         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3141
3142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3143
3144         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3145         (xstormy16_unwind_pc): Delete.
3146         (xstormy16_dummy_id): Delete.
3147         (xstormy16_gdbarch_init): Don't register deleted functions with
3148         gdbarch.
3149
3150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3151
3152         * vax-tdep.c (vax_unwind_pc): Delete.
3153         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3154
3155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3156
3157         * v850-tdep.c (v850_unwind_sp): Delete.
3158         (v850_unwind_pc): Delete.
3159         (v850_dummy_id): Delete.
3160         (v850_gdbarch_init): Don't register deleted functions with
3161         gdbarch.
3162
3163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3164
3165         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3166         (tilegx_unwind_pc): Delete.
3167         (tilegx_unwind_dummy_id): Delete.
3168         (tilegx_gdbarch_init): Don't register deleted functions with
3169         gdbarch.
3170
3171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3172
3173         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3174         (tic6x_dummy_id): Delete.
3175         (tic6x_gdbarch_init): Don't register deleted functions with
3176         gdbarch.
3177
3178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3179
3180         * sparc-tdep.c (sparc_unwind_pc): Delete.
3181         (sparc32_gdbarch_init): Don't register deleted function with
3182         gdbarch.
3183
3184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3185
3186         * sh-tdep.c (sh_unwind_sp): Delete.
3187         (sh_unwind_pc): Delete.
3188         (sh_dummy_id): Delete.
3189         (sh_gdbarch_init): Don't register deleted functions with
3190         gdbarch.
3191
3192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3193
3194         * score-tdep.c (score_unwind_sp): Delete.
3195         (score_unwind_pc): Delete.
3196         (score_dummy_id): Delete.
3197         (score_gdbarch_init): Don't register deleted functions with
3198         gdbarch.
3199
3200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3201
3202         * rx-tdep.c (rx_unwind_pc): Delete.
3203         (rx_unwind_sp): Delete.
3204         (rx_dummy_id): Delete.
3205         (rx_gdbarch_init): Don't register deleted functions with
3206         gdbarch.  Update comment.
3207
3208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3209
3210         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3211         (rs6000_dummy_id): Delete.
3212         (rs6000_gdbarch_init): Don't register deleted functions with
3213         gdbarch.
3214
3215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3216
3217         * or1k-tdep.c (or1k_dummy_id): Delete.
3218         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3219
3220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3221
3222         * nios2-tdep.c (nios2_dummy_id): Delete.
3223         (nios2_unwind_sp): Delete.
3224         (nios2_gdbarch_init): Don't register deleted functions with
3225         gdbarch.
3226
3227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3228
3229         * nds32-tdep.c (nds32_dummy_id): Delete.
3230         (nds32_unwind_pc): Delete.
3231         (nds32_unwind_sp): Delete.
3232         (nds32_gdbarch_init): Don't register deleted functions with
3233         gdbarch.
3234
3235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3236
3237         * msp430-tdep.c (msp430_unwind_pc): Delete.
3238         (msp430_unwind_sp): Delete.
3239         (msp430_dummy_id): Delete.
3240         (msp430_gdbarch_init): Don't register deleted functions with
3241         gdbarch.
3242
3243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3244
3245         * moxie-tdep.c (moxie_unwind_sp): Delete.
3246         (moxie_unwind_pc): Delete.
3247         (moxie_dummy_id): Delete.
3248         (moxie_gdbarch_init): Don't register deleted functions with
3249         gdbarch.
3250
3251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3252
3253         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3254         (mn10300_unwind_pc): Delete.
3255         (mn10300_unwind_sp): Delete.
3256         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3257         mn10300_unwind_sp.
3258         (mn10300_frame_unwind_init): Don't register deleted functions with
3259         gdbarch.
3260
3261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3262
3263         * mep-tdep.c (mep_unwind_pc): Delete.
3264         (mep_unwind_sp): Delete.
3265         (mep_dummy_id): Delete.
3266         (mep_gdbarch_init): Don't register deleted functions with
3267         gdbarch.
3268
3269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3270
3271         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3272         (m68hc11_unwind_sp): Delete.
3273         (m68hc11_gdbarch_init): Don't register deleted functions with
3274         gdbarch.
3275
3276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3277
3278         * m32r-tdep.c (m32r_unwind_sp): Delete.
3279         (m32r_unwind_pc): Delete.
3280         (m32r_dummy_id): Delete.
3281         (m32r_gdbarch_init): Don't register deleted functions with
3282         gdbarch.
3283
3284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3285
3286         * m32c-tdep.c (m32c_unwind_pc): Delete.
3287         (m32c_unwind_sp): Delete.
3288         (m32c_dummy_id): Delete.
3289         (m32c_gdbarch_init): Don't register deleted functions with
3290         gdbarch.
3291
3292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3293
3294         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3295         (lm32_unwind_pc): Delete.
3296         (lm32_dummy_id): Delete.
3297         (lm32_gdbarch_init): Don't register deleted functions with
3298         gdbarch.
3299
3300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3301
3302         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3303         (iq2000_unwind_pc): Delete.
3304         (iq2000_dummy_id): Delete.
3305         (iq2000_gdbarch_init): Don't register deleted functions with
3306         gdbarch.
3307
3308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3309
3310         * nds32-tdep.c (nds32_type_align): Delete.
3311         (nds32_push_dummy_call): Use type_align instead.
3312
3313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3314
3315         * arm-tdep.c (arm_type_align): Only handle vector override case.
3316         (arm_push_dummy_call): Use type_align.
3317         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3318
3319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3320
3321         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3322         case.
3323         (pass_on_stack): Use type_align.
3324         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3325         function.
3326
3327 2019-04-23  Tom Tromey  <tromey@adacore.com>
3328
3329         * dwarf2read.c (line_header::file_name_at): Remove unused
3330         overload.
3331
3332 2019-04-23  Tom de Vries  <tdevries@suse.de>
3333
3334         PR gdb/24438
3335         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3336         invocation.
3337
3338
3339 2019-03-27  Ali Tamur  <tamur@google.com>
3340
3341         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3342         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3343         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3344         (dwarf_expr_context::get_addr_index): Likewise
3345         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3346         (symbol_needs_eval_context::get_addr_index): Likewise
3347         (disassemble_dwarf_expression): Add DW_OP_addrx
3348         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3349         (read_cutu_die_from_dwo): Update comment
3350         (skip_one_die): Add DW_FORM_addrx
3351         (read_attribute_value): Likewise
3352         (var_decode_location): Add DW_OP_addrx
3353         (dwarf2_const_value_attr): Add DW_FORM_addrx
3354         (dump_die_shallow): Likewise
3355         (dwarf2_fetch_constant_bytes): Likewise
3356         (decode_locdesc): Add DW_OP_addrx
3357         (skip_form_bytes): Add DW_FORM_addrx
3358
3359 2019-04-22  Ali Tamur  <tamur@google.com>
3360
3361         * MAINTAINERS (Write After Approval): Add self.
3362
3363 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3364
3365         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3366         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3367         (open_symbol_file_object): Likewise.
3368         (svr4_default_sos): Add info parameter.
3369         (svr4_read_so_list): Likewise.
3370         (svr4_current_sos_direct): Adjust functions calls to pass down
3371         info.
3372         (svr4_current_sos_1): Add info parameter.
3373         (svr4_current_sos): Call get_svr4_info, pass info down to
3374         svr4_current_sos_1.
3375         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3376         get_svr4_info.
3377         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3378         get_svr4_info.
3379         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3380         to get_svr4_info.
3381         (probes_table_remove_objfile_probes): Likewise.
3382         (register_solib_event_probe): Add info parameter.
3383         (solist_update_incremental): Pass info parameter down to
3384         svr4_read_so_list.
3385         (disable_probes_interface): Add info parameter.
3386         (svr4_handle_solib_event): Pass current_program_space to
3387         get_svr4_info.  Adjust disable_probes_interface cleanup.
3388         (svr4_create_probe_breakpoints): Add info parameter, pass it
3389         down to register_solib_event_probe.
3390         (svr4_create_solib_event_breakpoints): Add info parameter,
3391         pass it down to svr4_create_probe_breakpoints.
3392         (enable_break): Pass info down to
3393         svr4_create_solib_event_breakpoints.
3394         (svr4_solib_create_inferior_hook): Pass current_program_space to
3395         get_svr4_info.
3396         (svr4_clear_solib): Likewise.
3397
3398 2019-04-22  Pedro Alves  <palves@redhat.com>
3399
3400         * solib-svr4.c (svr4_free_objfile_observer): New.
3401         (probe_and_action::objfile): New field.
3402         (probes_table_htab_remove_objfile_probes)
3403         (probes_table_remove_objfile_probes): New functions.
3404         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3405         in the new probe_and_action.  Don't store the probe in 'lookup'.
3406         (svr4_create_probe_breakpoints): Pass objfile to
3407         register_solib_event_probe.
3408         (_initialize_svr4_solib): Register a free_objfile observer.
3409
3410 2019-04-19  Tom Tromey  <tom@tromey.com>
3411
3412         * common/queue.h: Remove.
3413
3414 2019-04-19  Tom Tromey  <tom@tromey.com>
3415
3416         * event-loop.c: Don't include "common/queue.h".
3417
3418 2019-04-19  Tom Tromey  <tom@tromey.com>
3419
3420         * remote.c (remote_target): Use delete.
3421         * remote-notif.h: Include <list>, not "common/queue.h".
3422         (notif_client_p): Remove typedef.
3423         (remote_notif_state): Add constructor, destructor, initializer.
3424         <notif_queue>: Now a std::list.
3425         (remote_notif_state_xfree): Don't declare.
3426         * remote-notif.c (remote_notif_process, handle_notification)
3427         (remote_notif_state_allocate): Update.
3428         (~remote_notif_state): Rename from remote_notif_state_xfree.
3429
3430 2019-04-19  Tom Tromey  <tom@tromey.com>
3431
3432         * symfile.c (reread_symbols): Update.
3433         * objfiles.c (objfile_register_static_link)
3434         (objfile_lookup_static_link): Update
3435         (~objfile) Don't delete static_links.
3436         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3437
3438 2019-04-19  Tom Tromey  <tom@tromey.com>
3439
3440         * type-stack.h (struct type_stack) <insert>: Constify string.
3441         * type-stack.c (type_stack::insert): Constify string.
3442         * gdbtypes.h (lookup_template_type): Update.
3443         (address_space_name_to_int): Update.
3444         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3445         const.
3446         (lookup_template_type): Make name const.
3447         * c-exp.y: Update rules.
3448         (lex_one_token, classify_name, classify_inner_name)
3449         (c_print_token): Update.
3450         * p-exp.y: Update rules.
3451         (yylex): Update.
3452         * f-exp.y: Update rules.
3453         (yylex): Update.
3454         * d-exp.y: Update rules.
3455         (lex_one_token, classify_name, classify_inner_name): Update.
3456         * parse.c (write_dollar_variable, copy_name): Return std::string.
3457         * parser-defs.h (copy_name): Change return type.
3458         * m2-exp.y: Update rules.
3459         (yylex): Update.
3460         * go-exp.y (lex_one_token): Update.
3461         Update rules.
3462         (classify_unsafe_function, classify_packaged_name)
3463         (classify_name, yylex): Update.
3464
3465 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3466
3467         * configure.ac: add --enable-source-highlight switch.
3468         * configure: Regenerate.
3469         * top.c (print_gdb_version): plumb --enable-source-highlight
3470         status to "show configuration".
3471
3472 2019-04-19  Tom Tromey  <tromey@adacore.com>
3473
3474         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3475         Check ADA_TYPE_P.
3476         (empty_record, ada_template_to_fixed_record_type_1)
3477         (template_to_static_fixed_type)
3478         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3479         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3480         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3481         macros.
3482
3483 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3484
3485         PR symtab/24423:
3486         * source.c (print_source_lines_base): Advance "iter" when a
3487         control character is seen.
3488
3489 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3490
3491         * inferior.h (struct infcall_suspend_state_deleter):
3492         Catch exception in destructor to avoid crash.
3493
3494 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3495
3496         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3497         close to the add_com "shell".
3498
3499 2019-04-18  Tom Tromey  <tromey@adacore.com>
3500
3501         * process-stratum-target.h (class process_stratum_target)
3502         <stratum>: Add "final".
3503
3504 2019-04-17  Tom Tromey  <tromey@adacore.com>
3505
3506         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3507         against nullptr before use.
3508
3509 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3510
3511         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3512
3513 2019-04-17  Jim Wilson  <jimw@sifive.com>
3514             Andrew Burgess  <andrew.burgess@embecosm.com>
3515
3516         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3517         code read might fail, assume 4-byte breakpoint in that case.
3518
3519 2019-04-15  Leszek Swirski  <leszeks@google.com>
3520
3521         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3522         rather than a hand-rolled POD check when checking for forced MEMORY
3523         classification.
3524
3525 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3526
3527         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3528         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3529         function.
3530         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3531         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3532         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3533         declaration.
3534
3535 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3536
3537         * aarch64-linux-nat.c
3538         (aarch64_linux_nat_target::thread_architecture): Add override.
3539         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3540         each VQ.
3541
3542 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3543
3544         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3545
3546 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3547
3548         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3549         target types of size 96-bits, add some additional comments, and
3550         check that the builtin type we found was the correct size.
3551
3552 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3553
3554         * utils.c (prompt_for_continue): Don't restore the styling at the
3555         end, as applied_style has the wrong value.  This fixes styling in
3556         long lists of file names that are interrupted by the "Continue?"
3557         prompt.
3558
3559 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3560
3561         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3562         * c-lang.c (c_language_defn): Likewise.
3563         (cplus_language_defn): Likewise.
3564         (asm_language_defn): Likewise.
3565         (minimal_language_defn): Likewise.
3566         * d-lang.c (d_language_defn): Likewise.
3567         * f-lang.c (f_language_defn): Likewise.
3568         * go-lang.c (go_language_defn): Likewise.
3569         * language.c (unknown_language_defn): Likewise.
3570         (auto_language_defn): Likewise.
3571         * language.h (struct language_defn): Remove la_magic field.
3572         (LANG_MAGIC): Delete.
3573         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3574         * objc-lang.c (objc_language_defn): Likewise.
3575         * opencl-lang.c (opencl_language_defn): Likewise.
3576         * p-lang.c (pascal_language_defn): Likewise.
3577         * rust-lang.c (rust_language_defn): Likewise.
3578
3579 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3580
3581         * riscv-tdep.c (riscv_type_align): New function.
3582         (riscv_type_alignment): Delete.
3583         (riscv_arg_location): Use 'type_align'.
3584         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3585
3586 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3587
3588         * gdbtypes.c (type_align): A struct with no non-static fields also
3589         has alignment of 1.
3590
3591 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3592
3593         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3594         component to 0.
3595         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3596         member.
3597         (riscv_struct_info::analyse): New implementation using new
3598         analyse_inner member function.
3599         (riscv_struct_info::field_offset): New member function.
3600         (riscv_struct_info::m_offsets): New member variable.
3601         (riscv_struct_info::analyse_inner): New private member function,
3602         takes the old implementation of riscv_struct_info::analyse but
3603         extended to track field offsets.
3604         (riscv_call_arg_struct): Update the struct folding special cases
3605         to handle cases where empty C++ structs, which are non-zero
3606         length, are found.
3607         (riscv_arg_location): Initialise the length of each location, a
3608         non-zero length now indicates the location is in use.
3609         (riscv_push_dummy_call): Allow for the first location having a
3610         non-zero offset when setting up arguments.
3611         (riscv_return_value): Likewise, but for return values.
3612
3613 2019-04-11  Tom Tromey  <tromey@adacore.com>
3614
3615         * utils.c (internal_vproblem): Make "msg" const.
3616
3617 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3618
3619         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3620         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3621         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3622         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3623
3624 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3625
3626         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3627         function.
3628         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3629         of amd64_collect_native_gregset.
3630         (amd64_linux_nat_target::store_registers): Likewise.
3631
3632 2019-04-10  Tom Tromey  <tom@tromey.com>
3633
3634         * symtab.c (lookup_global_symbol_from_objfile)
3635         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3636         * objfiles.h (class separate_debug_iterator): New.
3637         (class separate_debug_range): New.
3638         (struct objfile) <separate_debug_objfiles>: New method.
3639         (objfile_separate_debug_iterate): Don't declare.
3640         * objfiles.c (separate_debug_iterator::operator++): Rename from
3641         objfile_separate_debug_iterate.
3642         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3643         iterator.
3644         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3645         iterator.
3646
3647 2019-04-10  Tom Tromey  <tom@tromey.com>
3648
3649         * symfile.c (reread_symbols): Remove old comment.
3650         * objfiles.c (free_all_objfiles): Fix a typo.
3651
3652 2019-04-10  Tom Tromey  <tom@tromey.com>
3653
3654         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3655         * minsyms.c (lookup_minimal_symbol): Use foreach.
3656         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3657         (lookup_minimal_symbol_solib_trampoline): Likewise.
3658         * symfile.c (reread_symbols): Use foreach.
3659
3660 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3661             Tom Tromey  <tromey@adacore.com>
3662
3663         PR rust/24414:
3664         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3665         (rust_lex_int_test): Change "value" to be LONGEST.
3666         (rust_lex_tests): Add test for long integer literal.
3667
3668 2019-04-09  Tom Tromey  <tromey@adacore.com>
3669
3670         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3671         to bool.
3672         (extended_remote_target::attach): Update.
3673         (remote_target::remote_notice_new_inferior): Update.
3674         (remote_target::add_current_inferior_and_thread): Update.
3675         * inferior.c (exit_inferior_1): Use "false".
3676         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3677
3678 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3679
3680         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3681         the "start" command.
3682
3683 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3684
3685         * python/py-inferior.c (infpy_thread_from_thread_handle):
3686         Adjust comments to reflect renaming of thread_from_thread_handle
3687         to thread_from_handle.  Adjust keywords.  Fix type error message.
3688         (inferior_object_methods): Add thread_from_handle.  Retain
3689         thread_from_thread_handle, but mark it as deprecated.
3690
3691 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3692
3693         * gdbthread.h (find_thread_by_handle): Revise declaration.
3694         * thread.c (find_thread_by_handle): Likewise.  Adjust
3695         implementation too.
3696         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3697         support for buffer objects as handles.
3698
3699 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3700
3701         * python/py-infthread.c (thpy_thread_handle): New function.
3702         (thread_object_methods): Register thpy_thread_handle.
3703
3704 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3705
3706         * gdbthread.h (thread_to_thread_handle): Declare.
3707         * thread.c (gdbtypes.h): Include.
3708         (thread_to_thread_handle): New function.
3709
3710         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3711         (target_thread_info_to_thread_handle): Declare.
3712         * target.c (target_thread_info_to_thread_handle): New function.
3713         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3714         * target-delegates.c: Regenerate.
3715
3716         * linux-thread-db.c (class thread_db_target): Add method
3717         thread_info_to_thread_handle.
3718         (thread_db_target::thread_info_to_thread_handle): Define.
3719         * remote.c (class remote_target): Add new method
3720         thread_info_to_thread_handle.
3721         (remote_target::thread_info_to_thread_handle): Define.
3722
3723 2019-04-08  Pedro Alves  <palves@redhat.com>
3724
3725         * common/common-exceptions.c (throw_exception): Don't create
3726         named object to throw; throw directly.
3727         (throw_it): Likewise.  Don't initialize gdb_exception::message
3728         here, with new; pass FMT and AP to the ctor instead.
3729         * common/common-exceptions.h: Include <string>.
3730         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3731         const char *, va_list)): New ctor.  Use std::make_shared.
3732         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3733         errors)): Delete.
3734         (gdb_exception_error::gdb_exception_error(enum errors, const char
3735         *, va_list)): New.
3736         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3737         Add assertion.
3738         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3739         errors)): Delete.
3740         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3741         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3742         Add assertion.
3743
3744 2019-04-08  Tom Tromey  <tom@tromey.com>
3745
3746         * valops.c (value_rtti_indirect_type): Replace throw_exception
3747         with throw.
3748         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3749         with throw.
3750         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3751         throw.
3752         * target.c (target_translate_tls_address): Replace throw_exception
3753         with throw.
3754         * stack.c (frame_apply_command_count): Replace throw_exception
3755         with throw.
3756         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3757         throw.
3758         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3759         with throw.
3760         * rs6000-tdep.c (rs6000_frame_cache)
3761         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3762         * remote.c: Replace throw_exception with throw.
3763         * record-full.c (record_full_message, record_full_wait_1)
3764         (record_full_restore): Replace throw_exception with throw.
3765         * record-btrace.c:
3766         (get_thread_current_frame_id, record_btrace_start_replaying)
3767         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3768         (cmd_record_btrace_start): Replace throw_exception with throw.
3769         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3770         throw.
3771         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3772         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3773         * linespec.c:
3774         (find_linespec_symbols): Replace throw_exception with throw.
3775         * infrun.c (displaced_step_prepare, resume): Replace
3776         throw_exception with throw.
3777         * infcmd.c (post_create_inferior): Replace throw_exception with
3778         throw.
3779         * inf-loop.c (inferior_event_handler): Replace throw_exception
3780         with throw.
3781         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3782         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3783         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3784         (get_prev_frame_always, get_frame_pc_if_available)
3785         (get_frame_address_in_block_if_available, get_frame_language):
3786         Replace throw_exception with throw.
3787         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3788         throw_exception with throw.
3789         * eval.c (fetch_subexp_value, evaluate_var_value)
3790         (evaluate_funcall, evaluate_subexp_standard): Replace
3791         throw_exception with throw.
3792         * dwarf2loc.c (call_site_find_chain)
3793         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3794         Replace throw_exception with throw.
3795         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3796         with throw.
3797         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3798         throw.
3799         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3800         * completer.c (complete_line_internal): Replace throw_exception
3801         with throw.
3802         * compile/compile-object-run.c (compile_object_run): Replace
3803         throw_exception with throw.
3804         * cli/cli-script.c (process_next_line): Replace throw_exception
3805         with throw.
3806         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3807         (btrace_enable, btrace_maint_update_pt_packets): Replace
3808         throw_exception with throw.
3809         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3810         throw_exception with throw.
3811         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3812         throw_exception with throw.
3813         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3814         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3815         * aarch64-tdep.c (aarch64_make_prologue_cache)
3816         (aarch64_make_stub_cache): Replace throw_exception with throw.
3817
3818 2019-04-08  Tom Tromey  <tom@tromey.com>
3819
3820         * common/common-exceptions.c (throw_exception): Rename from
3821         throw_exception_cxx.  Remove old copy.  Make argument const.
3822         (throw_it): Create and throw exception objects directly.
3823         * common/common-exceptions.h (throw_exception): Make argument
3824         const.
3825         (struct gdb_exception_error): Add constructor.
3826         (struct gdb_exception_quit): Add constructor.
3827
3828 2019-04-08  Tom Tromey  <tom@tromey.com>
3829
3830         * common/common-exceptions.h (exception_rethrow): Don't declare.
3831         (TRY_SJLJ): Update comment.
3832         (TRY, CATCH, END_CATCH): Remove.
3833         * common/common-exceptions.c (exception_rethrow): Remove.
3834
3835 2019-04-08  Tom Tromey  <tom@tromey.com>
3836
3837         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3838         Remove.
3839         (gdb_exception_error): Rename from
3840         gdb_exception_RETURN_MASK_ERROR.
3841         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3842         (gdb_quit_bad_alloc): Update.
3843         * aarch64-tdep.c: Update.
3844         * ada-lang.c: Update.
3845         * ada-typeprint.c: Update.
3846         * ada-valprint.c: Update.
3847         * amd64-tdep.c: Update.
3848         * arch-utils.c: Update.
3849         * break-catch-throw.c: Update.
3850         * breakpoint.c: Update.
3851         * btrace.c: Update.
3852         * c-varobj.c: Update.
3853         * cli/cli-cmds.c: Update.
3854         * cli/cli-interp.c: Update.
3855         * cli/cli-script.c: Update.
3856         * common/common-exceptions.c: Update.
3857         * common/new-op.c: Update.
3858         * common/selftest.c: Update.
3859         * compile/compile-c-symbols.c: Update.
3860         * compile/compile-cplus-symbols.c: Update.
3861         * compile/compile-object-load.c: Update.
3862         * compile/compile-object-run.c: Update.
3863         * completer.c: Update.
3864         * corelow.c: Update.
3865         * cp-abi.c: Update.
3866         * cp-support.c: Update.
3867         * cp-valprint.c: Update.
3868         * darwin-nat.c: Update.
3869         * disasm-selftests.c: Update.
3870         * dtrace-probe.c: Update.
3871         * dwarf-index-cache.c: Update.
3872         * dwarf-index-write.c: Update.
3873         * dwarf2-frame-tailcall.c: Update.
3874         * dwarf2-frame.c: Update.
3875         * dwarf2loc.c: Update.
3876         * dwarf2read.c: Update.
3877         * eval.c: Update.
3878         * event-loop.c: Update.
3879         * event-top.c: Update.
3880         * exec.c: Update.
3881         * f-valprint.c: Update.
3882         * fbsd-tdep.c: Update.
3883         * frame-unwind.c: Update.
3884         * frame.c: Update.
3885         * gdbtypes.c: Update.
3886         * gnu-v3-abi.c: Update.
3887         * guile/guile-internal.h: Update.
3888         * guile/scm-block.c: Update.
3889         * guile/scm-breakpoint.c: Update.
3890         * guile/scm-cmd.c: Update.
3891         * guile/scm-disasm.c: Update.
3892         * guile/scm-frame.c: Update.
3893         * guile/scm-lazy-string.c: Update.
3894         * guile/scm-math.c: Update.
3895         * guile/scm-param.c: Update.
3896         * guile/scm-ports.c: Update.
3897         * guile/scm-pretty-print.c: Update.
3898         * guile/scm-symbol.c: Update.
3899         * guile/scm-symtab.c: Update.
3900         * guile/scm-type.c: Update.
3901         * guile/scm-value.c: Update.
3902         * i386-linux-tdep.c: Update.
3903         * i386-tdep.c: Update.
3904         * inf-loop.c: Update.
3905         * infcall.c: Update.
3906         * infcmd.c: Update.
3907         * infrun.c: Update.
3908         * jit.c: Update.
3909         * language.c: Update.
3910         * linespec.c: Update.
3911         * linux-fork.c: Update.
3912         * linux-nat.c: Update.
3913         * linux-tdep.c: Update.
3914         * linux-thread-db.c: Update.
3915         * main.c: Update.
3916         * mi/mi-cmd-break.c: Update.
3917         * mi/mi-cmd-stack.c: Update.
3918         * mi/mi-interp.c: Update.
3919         * mi/mi-main.c: Update.
3920         * objc-lang.c: Update.
3921         * p-valprint.c: Update.
3922         * parse.c: Update.
3923         * ppc-linux-tdep.c: Update.
3924         * printcmd.c: Update.
3925         * python/py-arch.c: Update.
3926         * python/py-breakpoint.c: Update.
3927         * python/py-cmd.c: Update.
3928         * python/py-finishbreakpoint.c: Update.
3929         * python/py-frame.c: Update.
3930         * python/py-framefilter.c: Update.
3931         * python/py-gdb-readline.c: Update.
3932         * python/py-inferior.c: Update.
3933         * python/py-infthread.c: Update.
3934         * python/py-lazy-string.c: Update.
3935         * python/py-linetable.c: Update.
3936         * python/py-objfile.c: Update.
3937         * python/py-param.c: Update.
3938         * python/py-prettyprint.c: Update.
3939         * python/py-progspace.c: Update.
3940         * python/py-record-btrace.c: Update.
3941         * python/py-record.c: Update.
3942         * python/py-symbol.c: Update.
3943         * python/py-type.c: Update.
3944         * python/py-unwind.c: Update.
3945         * python/py-utils.c: Update.
3946         * python/py-value.c: Update.
3947         * python/python.c: Update.
3948         * record-btrace.c: Update.
3949         * record-full.c: Update.
3950         * remote-fileio.c: Update.
3951         * remote.c: Update.
3952         * riscv-tdep.c: Update.
3953         * rs6000-aix-tdep.c: Update.
3954         * rs6000-tdep.c: Update.
3955         * rust-exp.y: Update.
3956         * rust-lang.c: Update.
3957         * s390-tdep.c: Update.
3958         * selftest-arch.c: Update.
3959         * solib-dsbt.c: Update.
3960         * solib-frv.c: Update.
3961         * solib-spu.c: Update.
3962         * solib-svr4.c: Update.
3963         * solib.c: Update.
3964         * sparc64-linux-tdep.c: Update.
3965         * stack.c: Update.
3966         * symfile-mem.c: Update.
3967         * symmisc.c: Update.
3968         * target.c: Update.
3969         * thread.c: Update.
3970         * top.c: Update.
3971         * tracefile-tfile.c: Update.
3972         * tui/tui.c: Update.
3973         * typeprint.c: Update.
3974         * unittests/cli-utils-selftests.c: Update.
3975         * unittests/parse-connection-spec-selftests.c: Update.
3976         * valops.c: Update.
3977         * valprint.c: Update.
3978         * value.c: Update.
3979         * varobj.c: Update.
3980         * windows-nat.c: Update.
3981         * x86-linux-nat.c: Update.
3982         * xml-support.c: Update.
3983
3984 2019-04-08  Tom Tromey  <tom@tromey.com>
3985
3986         * xml-support.c: Use C++ exception handling.
3987         * x86-linux-nat.c: Use C++ exception handling.
3988         * windows-nat.c: Use C++ exception handling.
3989         * varobj.c: Use C++ exception handling.
3990         * value.c: Use C++ exception handling.
3991         * valprint.c: Use C++ exception handling.
3992         * valops.c: Use C++ exception handling.
3993         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3994         handling.
3995         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3996         * typeprint.c: Use C++ exception handling.
3997         * tui/tui.c: Use C++ exception handling.
3998         * tracefile-tfile.c: Use C++ exception handling.
3999         * top.c: Use C++ exception handling.
4000         * thread.c: Use C++ exception handling.
4001         * target.c: Use C++ exception handling.
4002         * symmisc.c: Use C++ exception handling.
4003         * symfile-mem.c: Use C++ exception handling.
4004         * stack.c: Use C++ exception handling.
4005         * sparc64-linux-tdep.c: Use C++ exception handling.
4006         * solib.c: Use C++ exception handling.
4007         * solib-svr4.c: Use C++ exception handling.
4008         * solib-spu.c: Use C++ exception handling.
4009         * solib-frv.c: Use C++ exception handling.
4010         * solib-dsbt.c: Use C++ exception handling.
4011         * selftest-arch.c: Use C++ exception handling.
4012         * s390-tdep.c: Use C++ exception handling.
4013         * rust-lang.c: Use C++ exception handling.
4014         * rust-exp.y: Use C++ exception handling.
4015         * rs6000-tdep.c: Use C++ exception handling.
4016         * rs6000-aix-tdep.c: Use C++ exception handling.
4017         * riscv-tdep.c: Use C++ exception handling.
4018         * remote.c: Use C++ exception handling.
4019         * remote-fileio.c: Use C++ exception handling.
4020         * record-full.c: Use C++ exception handling.
4021         * record-btrace.c: Use C++ exception handling.
4022         * python/python.c: Use C++ exception handling.
4023         * python/py-value.c: Use C++ exception handling.
4024         * python/py-utils.c: Use C++ exception handling.
4025         * python/py-unwind.c: Use C++ exception handling.
4026         * python/py-type.c: Use C++ exception handling.
4027         * python/py-symbol.c: Use C++ exception handling.
4028         * python/py-record.c: Use C++ exception handling.
4029         * python/py-record-btrace.c: Use C++ exception handling.
4030         * python/py-progspace.c: Use C++ exception handling.
4031         * python/py-prettyprint.c: Use C++ exception handling.
4032         * python/py-param.c: Use C++ exception handling.
4033         * python/py-objfile.c: Use C++ exception handling.
4034         * python/py-linetable.c: Use C++ exception handling.
4035         * python/py-lazy-string.c: Use C++ exception handling.
4036         * python/py-infthread.c: Use C++ exception handling.
4037         * python/py-inferior.c: Use C++ exception handling.
4038         * python/py-gdb-readline.c: Use C++ exception handling.
4039         * python/py-framefilter.c: Use C++ exception handling.
4040         * python/py-frame.c: Use C++ exception handling.
4041         * python/py-finishbreakpoint.c: Use C++ exception handling.
4042         * python/py-cmd.c: Use C++ exception handling.
4043         * python/py-breakpoint.c: Use C++ exception handling.
4044         * python/py-arch.c: Use C++ exception handling.
4045         * printcmd.c: Use C++ exception handling.
4046         * ppc-linux-tdep.c: Use C++ exception handling.
4047         * parse.c: Use C++ exception handling.
4048         * p-valprint.c: Use C++ exception handling.
4049         * objc-lang.c: Use C++ exception handling.
4050         * mi/mi-main.c: Use C++ exception handling.
4051         * mi/mi-interp.c: Use C++ exception handling.
4052         * mi/mi-cmd-stack.c: Use C++ exception handling.
4053         * mi/mi-cmd-break.c: Use C++ exception handling.
4054         * main.c: Use C++ exception handling.
4055         * linux-thread-db.c: Use C++ exception handling.
4056         * linux-tdep.c: Use C++ exception handling.
4057         * linux-nat.c: Use C++ exception handling.
4058         * linux-fork.c: Use C++ exception handling.
4059         * linespec.c: Use C++ exception handling.
4060         * language.c: Use C++ exception handling.
4061         * jit.c: Use C++ exception handling.
4062         * infrun.c: Use C++ exception handling.
4063         * infcmd.c: Use C++ exception handling.
4064         * infcall.c: Use C++ exception handling.
4065         * inf-loop.c: Use C++ exception handling.
4066         * i386-tdep.c: Use C++ exception handling.
4067         * i386-linux-tdep.c: Use C++ exception handling.
4068         * guile/scm-value.c: Use C++ exception handling.
4069         * guile/scm-type.c: Use C++ exception handling.
4070         * guile/scm-symtab.c: Use C++ exception handling.
4071         * guile/scm-symbol.c: Use C++ exception handling.
4072         * guile/scm-pretty-print.c: Use C++ exception handling.
4073         * guile/scm-ports.c: Use C++ exception handling.
4074         * guile/scm-param.c: Use C++ exception handling.
4075         * guile/scm-math.c: Use C++ exception handling.
4076         * guile/scm-lazy-string.c: Use C++ exception handling.
4077         * guile/scm-frame.c: Use C++ exception handling.
4078         * guile/scm-disasm.c: Use C++ exception handling.
4079         * guile/scm-cmd.c: Use C++ exception handling.
4080         * guile/scm-breakpoint.c: Use C++ exception handling.
4081         * guile/scm-block.c: Use C++ exception handling.
4082         * guile/guile-internal.h: Use C++ exception handling.
4083         * gnu-v3-abi.c: Use C++ exception handling.
4084         * gdbtypes.c: Use C++ exception handling.
4085         * frame.c: Use C++ exception handling.
4086         * frame-unwind.c: Use C++ exception handling.
4087         * fbsd-tdep.c: Use C++ exception handling.
4088         * f-valprint.c: Use C++ exception handling.
4089         * exec.c: Use C++ exception handling.
4090         * event-top.c: Use C++ exception handling.
4091         * event-loop.c: Use C++ exception handling.
4092         * eval.c: Use C++ exception handling.
4093         * dwarf2read.c: Use C++ exception handling.
4094         * dwarf2loc.c: Use C++ exception handling.
4095         * dwarf2-frame.c: Use C++ exception handling.
4096         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4097         * dwarf-index-write.c: Use C++ exception handling.
4098         * dwarf-index-cache.c: Use C++ exception handling.
4099         * dtrace-probe.c: Use C++ exception handling.
4100         * disasm-selftests.c: Use C++ exception handling.
4101         * darwin-nat.c: Use C++ exception handling.
4102         * cp-valprint.c: Use C++ exception handling.
4103         * cp-support.c: Use C++ exception handling.
4104         * cp-abi.c: Use C++ exception handling.
4105         * corelow.c: Use C++ exception handling.
4106         * completer.c: Use C++ exception handling.
4107         * compile/compile-object-run.c: Use C++ exception handling.
4108         * compile/compile-object-load.c: Use C++ exception handling.
4109         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4110         * compile/compile-c-symbols.c: Use C++ exception handling.
4111         * common/selftest.c: Use C++ exception handling.
4112         * common/new-op.c: Use C++ exception handling.
4113         * cli/cli-script.c: Use C++ exception handling.
4114         * cli/cli-interp.c: Use C++ exception handling.
4115         * cli/cli-cmds.c: Use C++ exception handling.
4116         * c-varobj.c: Use C++ exception handling.
4117         * btrace.c: Use C++ exception handling.
4118         * breakpoint.c: Use C++ exception handling.
4119         * break-catch-throw.c: Use C++ exception handling.
4120         * arch-utils.c: Use C++ exception handling.
4121         * amd64-tdep.c: Use C++ exception handling.
4122         * ada-valprint.c: Use C++ exception handling.
4123         * ada-typeprint.c: Use C++ exception handling.
4124         * ada-lang.c: Use C++ exception handling.
4125         * aarch64-tdep.c: Use C++ exception handling.
4126
4127 2019-04-08  Tom Tromey  <tom@tromey.com>
4128
4129         * xml-support.c (gdb_xml_parser::parse): Update.
4130         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4131         * value.c (show_convenience): Update.
4132         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4133         (test_parse_flags_qcs): Update.
4134         * thread.c (thr_try_catch_cmd): Update.
4135         * target.c (target_translate_tls_address): Update.
4136         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4137         (info_frame_command_core, frame_apply_command_count): Update.
4138         * rust-exp.y (rust_lex_exception_test): Update.
4139         * riscv-tdep.c (riscv_print_one_register_info): Update.
4140         * remote.c (remote_target::enable_btrace): Update.
4141         * record-btrace.c (record_btrace_enable_warn): Update.
4142         * python/py-utils.c (gdbpy_convert_exception): Update.
4143         * printcmd.c (do_one_display, print_variable_and_value): Update.
4144         * mi/mi-main.c (mi_print_exception): Update.
4145         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4146         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4147         * linux-nat.c (linux_nat_target::attach): Update.
4148         * linux-fork.c (class scoped_switch_fork_info): Update.
4149         * infrun.c (displaced_step_prepare): Update.
4150         * infcall.c (call_function_by_hand_dummy): Update.
4151         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4152         * gnu-v3-abi.c (print_one_vtable): Update.
4153         * frame.c (get_prev_frame_always): Update.
4154         * f-valprint.c (info_common_command_for_block): Update.
4155         * exec.c (try_open_exec_file): Update.
4156         * exceptions.c (print_exception, exception_print)
4157         (exception_fprintf, exception_print_same): Update.
4158         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4159         * dwarf-index-cache.c (index_cache::store)
4160         (index_cache::lookup_gdb_index): Update.
4161         * darwin-nat.c (maybe_cache_shell): Update.
4162         * cp-valprint.c (cp_print_value_fields): Update.
4163         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4164         (gcc_cplus_symbol_address): Update.
4165         * compile/compile-c-symbols.c (gcc_convert_symbol)
4166         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4167         * common/selftest.c: Update.
4168         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4169         a std::string.
4170         (exception_try_scope_entry, exception_try_scope_exit): Don't
4171         declare.
4172         (struct exception_try_scope): Remove.
4173         (TRY): Don't use exception_try_scope.
4174         (struct gdb_exception): Add constructor, operator=.
4175         <what>: New method.
4176         (struct gdb_exception_RETURN_MASK_ALL)
4177         (struct gdb_exception_RETURN_MASK_ERROR)
4178         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4179         (struct gdb_quit_bad_alloc): Update.
4180         * common/common-exceptions.c (exception_none): Change
4181         initializer.
4182         (struct catcher) <state, exception>: Initialize inline.
4183         <prev>: Remove member.
4184         (current_catcher): Remove.
4185         (catchers): New global.
4186         (exceptions_state_mc_init): Simplify.
4187         (catcher_pop): Remove.
4188         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4189         (try_scope_depth, exception_try_scope_entry)
4190         (exception_try_scope_exit): Remove.
4191         (throw_exception_sjlj): Update.
4192         (exception_messages, exception_messages_size): Remove.
4193         (throw_it): Simplify.
4194         (gdb_exception_sliced_copy): Remove.
4195         (throw_exception_cxx): Update.
4196         * cli/cli-script.c (script_from_file): Update.
4197         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4198         Update.
4199         * ada-valprint.c (ada_val_print): Update.
4200         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4201         (create_excep_cond_exprs): Update.
4202
4203 2019-04-08  Tom Tromey  <tom@tromey.com>
4204
4205         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4206         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4207         (TRY, CATCH, END_CATCH): Remove some definitions.
4208         * common/common-exceptions.c: Don't use GDB_XCPT.
4209         (catcher_list_size): Remove.
4210         (throw_exception, throw_it): Simplify.
4211
4212 2019-04-05  Tom Tromey  <tom@tromey.com>
4213
4214         Revert the header-sorting patch.
4215         * ft32-tdep.c: Revert.
4216         * frv-tdep.c: Revert.
4217         * frv-linux-tdep.c: Revert.
4218         * frame.c: Revert.
4219         * frame-unwind.c: Revert.
4220         * frame-base.c: Revert.
4221         * fork-child.c: Revert.
4222         * findvar.c: Revert.
4223         * findcmd.c: Revert.
4224         * filesystem.c: Revert.
4225         * filename-seen-cache.h: Revert.
4226         * filename-seen-cache.c: Revert.
4227         * fbsd-tdep.c: Revert.
4228         * fbsd-nat.h: Revert.
4229         * fbsd-nat.c: Revert.
4230         * f-valprint.c: Revert.
4231         * f-typeprint.c: Revert.
4232         * f-lang.c: Revert.
4233         * extension.h: Revert.
4234         * extension.c: Revert.
4235         * extension-priv.h: Revert.
4236         * expprint.c: Revert.
4237         * exec.h: Revert.
4238         * exec.c: Revert.
4239         * exceptions.c: Revert.
4240         * event-top.c: Revert.
4241         * event-loop.c: Revert.
4242         * eval.c: Revert.
4243         * elfread.c: Revert.
4244         * dwarf2read.h: Revert.
4245         * dwarf2read.c: Revert.
4246         * dwarf2loc.c: Revert.
4247         * dwarf2expr.h: Revert.
4248         * dwarf2expr.c: Revert.
4249         * dwarf2-frame.c: Revert.
4250         * dwarf2-frame-tailcall.c: Revert.
4251         * dwarf-index-write.h: Revert.
4252         * dwarf-index-write.c: Revert.
4253         * dwarf-index-common.c: Revert.
4254         * dwarf-index-cache.h: Revert.
4255         * dwarf-index-cache.c: Revert.
4256         * dummy-frame.c: Revert.
4257         * dtrace-probe.c: Revert.
4258         * disasm.h: Revert.
4259         * disasm.c: Revert.
4260         * disasm-selftests.c: Revert.
4261         * dictionary.c: Revert.
4262         * dicos-tdep.c: Revert.
4263         * demangle.c: Revert.
4264         * dcache.h: Revert.
4265         * dcache.c: Revert.
4266         * darwin-nat.h: Revert.
4267         * darwin-nat.c: Revert.
4268         * darwin-nat-info.c: Revert.
4269         * d-valprint.c: Revert.
4270         * d-namespace.c: Revert.
4271         * d-lang.c: Revert.
4272         * ctf.c: Revert.
4273         * csky-tdep.c: Revert.
4274         * csky-linux-tdep.c: Revert.
4275         * cris-tdep.c: Revert.
4276         * cris-linux-tdep.c: Revert.
4277         * cp-valprint.c: Revert.
4278         * cp-support.c: Revert.
4279         * cp-namespace.c: Revert.
4280         * cp-abi.c: Revert.
4281         * corelow.c: Revert.
4282         * corefile.c: Revert.
4283         * continuations.c: Revert.
4284         * completer.h: Revert.
4285         * completer.c: Revert.
4286         * complaints.c: Revert.
4287         * coffread.c: Revert.
4288         * coff-pe-read.c: Revert.
4289         * cli-out.h: Revert.
4290         * cli-out.c: Revert.
4291         * charset.c: Revert.
4292         * c-varobj.c: Revert.
4293         * c-valprint.c: Revert.
4294         * c-typeprint.c: Revert.
4295         * c-lang.c: Revert.
4296         * buildsym.c: Revert.
4297         * buildsym-legacy.c: Revert.
4298         * build-id.h: Revert.
4299         * build-id.c: Revert.
4300         * btrace.c: Revert.
4301         * bsd-uthread.c: Revert.
4302         * breakpoint.h: Revert.
4303         * breakpoint.c: Revert.
4304         * break-catch-throw.c: Revert.
4305         * break-catch-syscall.c: Revert.
4306         * break-catch-sig.c: Revert.
4307         * blockframe.c: Revert.
4308         * block.c: Revert.
4309         * bfin-tdep.c: Revert.
4310         * bfin-linux-tdep.c: Revert.
4311         * bfd-target.c: Revert.
4312         * bcache.c: Revert.
4313         * ax-general.c: Revert.
4314         * ax-gdb.h: Revert.
4315         * ax-gdb.c: Revert.
4316         * avr-tdep.c: Revert.
4317         * auxv.c: Revert.
4318         * auto-load.c: Revert.
4319         * arm-wince-tdep.c: Revert.
4320         * arm-tdep.c: Revert.
4321         * arm-symbian-tdep.c: Revert.
4322         * arm-pikeos-tdep.c: Revert.
4323         * arm-obsd-tdep.c: Revert.
4324         * arm-nbsd-tdep.c: Revert.
4325         * arm-nbsd-nat.c: Revert.
4326         * arm-linux-tdep.c: Revert.
4327         * arm-linux-nat.c: Revert.
4328         * arm-fbsd-tdep.c: Revert.
4329         * arm-fbsd-nat.c: Revert.
4330         * arm-bsd-tdep.c: Revert.
4331         * arch-utils.c: Revert.
4332         * arc-tdep.c: Revert.
4333         * arc-newlib-tdep.c: Revert.
4334         * annotate.h: Revert.
4335         * annotate.c: Revert.
4336         * amd64-windows-tdep.c: Revert.
4337         * amd64-windows-nat.c: Revert.
4338         * amd64-tdep.c: Revert.
4339         * amd64-sol2-tdep.c: Revert.
4340         * amd64-obsd-tdep.c: Revert.
4341         * amd64-obsd-nat.c: Revert.
4342         * amd64-nbsd-tdep.c: Revert.
4343         * amd64-nbsd-nat.c: Revert.
4344         * amd64-nat.c: Revert.
4345         * amd64-linux-tdep.c: Revert.
4346         * amd64-linux-nat.c: Revert.
4347         * amd64-fbsd-tdep.c: Revert.
4348         * amd64-fbsd-nat.c: Revert.
4349         * amd64-dicos-tdep.c: Revert.
4350         * amd64-darwin-tdep.c: Revert.
4351         * amd64-bsd-nat.c: Revert.
4352         * alpha-tdep.c: Revert.
4353         * alpha-obsd-tdep.c: Revert.
4354         * alpha-nbsd-tdep.c: Revert.
4355         * alpha-mdebug-tdep.c: Revert.
4356         * alpha-linux-tdep.c: Revert.
4357         * alpha-linux-nat.c: Revert.
4358         * alpha-bsd-tdep.c: Revert.
4359         * alpha-bsd-nat.c: Revert.
4360         * aix-thread.c: Revert.
4361         * agent.c: Revert.
4362         * addrmap.c: Revert.
4363         * ada-varobj.c: Revert.
4364         * ada-valprint.c: Revert.
4365         * ada-typeprint.c: Revert.
4366         * ada-tasks.c: Revert.
4367         * ada-lang.c: Revert.
4368         * aarch64-tdep.c: Revert.
4369         * aarch64-ravenscar-thread.c: Revert.
4370         * aarch64-newlib-tdep.c: Revert.
4371         * aarch64-linux-tdep.c: Revert.
4372         * aarch64-linux-nat.c: Revert.
4373         * aarch64-fbsd-tdep.c: Revert.
4374         * aarch64-fbsd-nat.c: Revert.
4375         * aarch32-linux-nat.c: Revert.
4376
4377 2019-04-05  Tom Tromey  <tom@tromey.com>
4378
4379         * ft32-tdep.c: Sort headers.
4380         * frv-tdep.c: Sort headers.
4381         * frv-linux-tdep.c: Sort headers.
4382         * frame.c: Sort headers.
4383         * frame-unwind.c: Sort headers.
4384         * frame-base.c: Sort headers.
4385         * fork-child.c: Sort headers.
4386         * findvar.c: Sort headers.
4387         * findcmd.c: Sort headers.
4388         * filesystem.c: Sort headers.
4389         * filename-seen-cache.h: Sort headers.
4390         * filename-seen-cache.c: Sort headers.
4391         * fbsd-tdep.c: Sort headers.
4392         * fbsd-nat.h: Sort headers.
4393         * fbsd-nat.c: Sort headers.
4394         * f-valprint.c: Sort headers.
4395         * f-typeprint.c: Sort headers.
4396         * f-lang.c: Sort headers.
4397         * extension.h: Sort headers.
4398         * extension.c: Sort headers.
4399         * extension-priv.h: Sort headers.
4400         * expprint.c: Sort headers.
4401         * exec.h: Sort headers.
4402         * exec.c: Sort headers.
4403         * exceptions.c: Sort headers.
4404         * event-top.c: Sort headers.
4405         * event-loop.c: Sort headers.
4406         * eval.c: Sort headers.
4407         * elfread.c: Sort headers.
4408         * dwarf2read.h: Sort headers.
4409         * dwarf2read.c: Sort headers.
4410         * dwarf2loc.c: Sort headers.
4411         * dwarf2expr.h: Sort headers.
4412         * dwarf2expr.c: Sort headers.
4413         * dwarf2-frame.c: Sort headers.
4414         * dwarf2-frame-tailcall.c: Sort headers.
4415         * dwarf-index-write.h: Sort headers.
4416         * dwarf-index-write.c: Sort headers.
4417         * dwarf-index-common.c: Sort headers.
4418         * dwarf-index-cache.h: Sort headers.
4419         * dwarf-index-cache.c: Sort headers.
4420         * dummy-frame.c: Sort headers.
4421         * dtrace-probe.c: Sort headers.
4422         * disasm.h: Sort headers.
4423         * disasm.c: Sort headers.
4424         * disasm-selftests.c: Sort headers.
4425         * dictionary.c: Sort headers.
4426         * dicos-tdep.c: Sort headers.
4427         * demangle.c: Sort headers.
4428         * dcache.h: Sort headers.
4429         * dcache.c: Sort headers.
4430         * darwin-nat.h: Sort headers.
4431         * darwin-nat.c: Sort headers.
4432         * darwin-nat-info.c: Sort headers.
4433         * d-valprint.c: Sort headers.
4434         * d-namespace.c: Sort headers.
4435         * d-lang.c: Sort headers.
4436         * ctf.c: Sort headers.
4437         * csky-tdep.c: Sort headers.
4438         * csky-linux-tdep.c: Sort headers.
4439         * cris-tdep.c: Sort headers.
4440         * cris-linux-tdep.c: Sort headers.
4441         * cp-valprint.c: Sort headers.
4442         * cp-support.c: Sort headers.
4443         * cp-namespace.c: Sort headers.
4444         * cp-abi.c: Sort headers.
4445         * corelow.c: Sort headers.
4446         * corefile.c: Sort headers.
4447         * continuations.c: Sort headers.
4448         * completer.h: Sort headers.
4449         * completer.c: Sort headers.
4450         * complaints.c: Sort headers.
4451         * coffread.c: Sort headers.
4452         * coff-pe-read.c: Sort headers.
4453         * cli-out.h: Sort headers.
4454         * cli-out.c: Sort headers.
4455         * charset.c: Sort headers.
4456         * c-varobj.c: Sort headers.
4457         * c-valprint.c: Sort headers.
4458         * c-typeprint.c: Sort headers.
4459         * c-lang.c: Sort headers.
4460         * buildsym.c: Sort headers.
4461         * buildsym-legacy.c: Sort headers.
4462         * build-id.h: Sort headers.
4463         * build-id.c: Sort headers.
4464         * btrace.c: Sort headers.
4465         * bsd-uthread.c: Sort headers.
4466         * breakpoint.h: Sort headers.
4467         * breakpoint.c: Sort headers.
4468         * break-catch-throw.c: Sort headers.
4469         * break-catch-syscall.c: Sort headers.
4470         * break-catch-sig.c: Sort headers.
4471         * blockframe.c: Sort headers.
4472         * block.c: Sort headers.
4473         * bfin-tdep.c: Sort headers.
4474         * bfin-linux-tdep.c: Sort headers.
4475         * bfd-target.c: Sort headers.
4476         * bcache.c: Sort headers.
4477         * ax-general.c: Sort headers.
4478         * ax-gdb.h: Sort headers.
4479         * ax-gdb.c: Sort headers.
4480         * avr-tdep.c: Sort headers.
4481         * auxv.c: Sort headers.
4482         * auto-load.c: Sort headers.
4483         * arm-wince-tdep.c: Sort headers.
4484         * arm-tdep.c: Sort headers.
4485         * arm-symbian-tdep.c: Sort headers.
4486         * arm-pikeos-tdep.c: Sort headers.
4487         * arm-obsd-tdep.c: Sort headers.
4488         * arm-nbsd-tdep.c: Sort headers.
4489         * arm-nbsd-nat.c: Sort headers.
4490         * arm-linux-tdep.c: Sort headers.
4491         * arm-linux-nat.c: Sort headers.
4492         * arm-fbsd-tdep.c: Sort headers.
4493         * arm-fbsd-nat.c: Sort headers.
4494         * arm-bsd-tdep.c: Sort headers.
4495         * arch-utils.c: Sort headers.
4496         * arc-tdep.c: Sort headers.
4497         * arc-newlib-tdep.c: Sort headers.
4498         * annotate.h: Sort headers.
4499         * annotate.c: Sort headers.
4500         * amd64-windows-tdep.c: Sort headers.
4501         * amd64-windows-nat.c: Sort headers.
4502         * amd64-tdep.c: Sort headers.
4503         * amd64-sol2-tdep.c: Sort headers.
4504         * amd64-obsd-tdep.c: Sort headers.
4505         * amd64-obsd-nat.c: Sort headers.
4506         * amd64-nbsd-tdep.c: Sort headers.
4507         * amd64-nbsd-nat.c: Sort headers.
4508         * amd64-nat.c: Sort headers.
4509         * amd64-linux-tdep.c: Sort headers.
4510         * amd64-linux-nat.c: Sort headers.
4511         * amd64-fbsd-tdep.c: Sort headers.
4512         * amd64-fbsd-nat.c: Sort headers.
4513         * amd64-dicos-tdep.c: Sort headers.
4514         * amd64-darwin-tdep.c: Sort headers.
4515         * amd64-bsd-nat.c: Sort headers.
4516         * alpha-tdep.c: Sort headers.
4517         * alpha-obsd-tdep.c: Sort headers.
4518         * alpha-nbsd-tdep.c: Sort headers.
4519         * alpha-mdebug-tdep.c: Sort headers.
4520         * alpha-linux-tdep.c: Sort headers.
4521         * alpha-linux-nat.c: Sort headers.
4522         * alpha-bsd-tdep.c: Sort headers.
4523         * alpha-bsd-nat.c: Sort headers.
4524         * aix-thread.c: Sort headers.
4525         * agent.c: Sort headers.
4526         * addrmap.c: Sort headers.
4527         * ada-varobj.c: Sort headers.
4528         * ada-valprint.c: Sort headers.
4529         * ada-typeprint.c: Sort headers.
4530         * ada-tasks.c: Sort headers.
4531         * ada-lang.c: Sort headers.
4532         * aarch64-tdep.c: Sort headers.
4533         * aarch64-ravenscar-thread.c: Sort headers.
4534         * aarch64-newlib-tdep.c: Sort headers.
4535         * aarch64-linux-tdep.c: Sort headers.
4536         * aarch64-linux-nat.c: Sort headers.
4537         * aarch64-fbsd-tdep.c: Sort headers.
4538         * aarch64-fbsd-nat.c: Sort headers.
4539         * aarch32-linux-nat.c: Sort headers.
4540
4541 2019-04-04  Tom Tromey  <tom@tromey.com>
4542
4543         * varobj.c (varobj_create): Update.
4544         * rust-exp.y (struct rust_parser) <update_innermost_block,
4545         lookup_symbol>: New methods.
4546         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4547         Rename.
4548         (rust_parser::rust_lookup_type)
4549         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4550         * printcmd.c (display_command, do_one_display): Update.
4551         * parser-defs.h (struct parser_state) <parser_state>: Add
4552         "tracker" parameter.
4553         (block_tracker): New member.
4554         (class innermost_block_tracker) <innermost_block_tracker>: Add
4555         "types" parameter.
4556         <reset>: Remove method.
4557         (innermost_block): Don't declare.
4558         (null_post_parser): Update.
4559         * parse.c (innermost_block): Remove global.
4560         (write_dollar_variable): Update.
4561         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4562         Remove "tracker_types" parameter.
4563         (parse_expression): Add "tracker" parameter.
4564         (parse_expression_for_completion): Update.
4565         (null_post_parser): Add "tracker" parameter.
4566         * p-exp.y: Update rules.
4567         * m2-exp.y: Update rules.
4568         * language.h (struct language_defn) <la_post_parser>: Add
4569         "tracker" parameter.
4570         * go-exp.y: Update rules.
4571         * f-exp.y: Update rules.
4572         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4573         parameter.
4574         * d-exp.y: Update rules.
4575         * c-exp.y: Update rules.
4576         * breakpoint.c (set_breakpoint_condition): Create an
4577         innermost_block_tracker.
4578         (watch_command_1): Likewise.
4579         * ada-lang.c (resolve): Add "tracker" parameter.
4580         (resolve_subexp): Likewise.
4581         * ada-exp.y (write_var_from_sym): Update.
4582
4583 2019-04-04  Tom Tromey  <tom@tromey.com>
4584
4585         * type-stack.h: New file.
4586         * type-stack.c: New file.
4587         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4588         type-stack.h.
4589         (insert_into_type_stack, insert_type, push_type, push_type_int)
4590         (insert_type_address_space, pop_type, pop_type_int)
4591         (pop_typelist, pop_type_stack, append_type_stack)
4592         (push_type_stack, get_type_stack, push_typelist)
4593         (follow_type_instance_flags, follow_types): Don't declare.
4594         * parse.c (type_stack): Remove global.
4595         (parse_exp_in_context): Update.
4596         (insert_into_type_stack, insert_type, push_type, push_type_int)
4597         (insert_type_address_space, pop_type, pop_type_int)
4598         (pop_typelist, pop_type_stack, append_type_stack)
4599         (push_type_stack, get_type_stack, push_typelist)
4600         (follow_type_instance_flags, follow_types): Remove (moved to
4601         type-stack.c).
4602         * f-exp.y (type_stack): New global.
4603         Update rules.
4604         (push_kind_type, f_parse): Update.
4605         * d-exp.y (type_stack): New global.
4606         Update rules.
4607         (d_parse): Update.
4608         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4609         Update rules.
4610         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4611         (HFILES_NO_SRCDIR): Add type-stack.h.
4612
4613 2019-04-04  Tom Tromey  <tom@tromey.com>
4614
4615         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4616         (rust_parser::convert_ast_to_expression, rust_parse)
4617         (rust_lex_test_completion, rust_lex_tests): Update.
4618         * parser-defs.h (struct expr_completion_state): New.
4619         (struct parser_state) <parser_state>: Add completion parameter.
4620         <mark_struct_expression, mark_completion_tag>: New methods.
4621         <parse_completion, m_completion_state>: New members.
4622         (prefixify_expression, null_post_parser): Update.
4623         (mark_struct_expression, mark_completion_tag): Don't declare.
4624         * parse.c (parse_completion, expout_last_struct)
4625         (expout_tag_completion_type, expout_completion_name): Remove
4626         globals.
4627         (parser_state::mark_struct_expression)
4628         (parser_state::mark_completion_tag): Now methods.
4629         (prefixify_expression): Add last_struct parameter.
4630         (prefixify_subexp): Likewise.
4631         (parse_exp_1): Update.
4632         (parse_exp_in_context): Add cstate parameter.  Update.
4633         (parse_expression_for_completion): Create an
4634         expr_completion_state.
4635         (null_post_parser): Add "completion" parameter.
4636         * p-exp.y: Update rules.
4637         (yylex): Update.
4638         * language.h (struct language_defn) <la_post_parser>: Add
4639         "completing" parameter.
4640         * go-exp.y: Update rules.
4641         (lex_one_token): Update.
4642         * expression.h (parse_completion): Don't declare.
4643         * d-exp.y: Update rules.
4644         (lex_one_token): Update rules.
4645         * c-exp.y: Update rules.
4646         (lex_one_token): Update.
4647         * ada-lang.c (resolve): Add "parse_completion" parameter.
4648         (resolve_subexp): Likewise.
4649         (ada_resolve_function): Likewise.
4650
4651 2019-04-04  Tom Tromey  <tom@tromey.com>
4652
4653         * parser-defs.h (struct parser_state) <start_arglist,
4654         end_arglist>: New methods.
4655         <arglist_len, m_funcall_chain>: New members.
4656         (arglist_len, start_arglist, end_arglist): Don't declare.
4657         * parse.c (arglist_len, funcall_chain): Remove global.
4658         (start_arglist, end_arglist): Remove functions.
4659         (parse_exp_in_context): Update.
4660         * p-exp.y: Update rules.
4661         * m2-exp.y: Update rules.
4662         * go-exp.y: Update rules.
4663         * f-exp.y: Update rules.
4664         * d-exp.y: Update rules.
4665         * c-exp.y: Update rules.
4666
4667 2019-04-04  Tom Tromey  <tom@tromey.com>
4668
4669         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4670         lex_operator, push_back>: New methods.
4671         Update all rules.
4672         (rust_parser::lex_hex, lex_escape): Rename and update.
4673         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4674         (rust_parser::lex_operator): Rename and update.
4675         (rust_parser::lex_number, rustyylex, rustyyerror)
4676         (rust_lex_test_init, rust_lex_test_sequence)
4677         (rust_lex_test_push_back, rust_lex_tests): Update.
4678         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4679         parameter.
4680         <lexptr, prev_lexptr>: New members.
4681         (lexptr, prev_lexptr): Don't declare.
4682         * parse.c (lexptr, prev_lexptr): Remove globals.
4683         (parse_exp_in_context): Update.
4684         * p-exp.y (yylex, yyerror): Update.
4685         * m2-exp.y (parse_number, yylex, yyerror): Update.
4686         * go-exp.y (lex_one_token, yyerror): Update.
4687         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4688         * d-exp.y (lex_one_token, yyerror): Update.
4689         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4690         (lex_one_token, yyerror): Update.
4691         * ada-lex.l (YY_INPUT): Update.
4692         (rewind_to_char): Update.
4693         * ada-exp.y (yyerror): Update.
4694
4695 2019-04-04  Tom Tromey  <tom@tromey.com>
4696
4697         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4698         * parser-defs.h (struct parser_state) <parser_state>: Add new
4699         parameter.
4700         <comma_terminates>: New member.
4701         (comma_terminates): Don't declare global.
4702         * parse.c (comma_terminates): Remove global.
4703         (parse_exp_in_context): Update.
4704         * p-exp.y (yylex): Update.
4705         * m2-exp.y (yylex): Update.
4706         * go-exp.y (lex_one_token): Update.
4707         * f-exp.y (yylex): Update.
4708         * d-exp.y (lex_one_token): Update.
4709         * c-exp.y (lex_one_token): Update.
4710         * ada-lex.l: Update.
4711
4712 2019-04-04  Tom Tromey  <tom@tromey.com>
4713
4714         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4715         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4716         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4717         * parser-defs.h (paren_depth): Don't declare.
4718         * parse.c (paren_depth): Remove global.
4719         (parse_exp_in_context): Update.
4720         * p-exp.y (paren_depth): New global.
4721         (pascal_parse): Initialize it.
4722         * m2-exp.y (paren_depth): New global.
4723         (m2_parse): Initialize it.
4724         * go-exp.y (paren_depth): New global.
4725         (go_parse): Initialize it.
4726         * f-exp.y (paren_depth): New global.
4727         (f_parse): Initialize it.
4728         * d-exp.y (paren_depth): New global.
4729         (d_parse): Initialize it.
4730         * c-exp.y (paren_depth): New global.
4731         (c_parse): Initialize it.
4732         * ada-lex.l (paren_depth): New global.
4733         (lexer_init): Initialize it.
4734
4735 2019-04-04  Tom Tromey  <tom@tromey.com>
4736
4737         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4738         (rust_parser::convert_ast_to_type)
4739         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4740         * parser-defs.h (struct parser_state) <parser_state>: Add
4741         parameters.  Initialize new members.
4742         <expression_context_block, expression_context_pc>: New members.
4743         * parse.c (expression_context_block, expression_context_pc):
4744         Remove globals.
4745         (parse_exp_in_context): Update.
4746         * p-exp.y: Update all rules.
4747         (yylex): Update.
4748         * m2-exp.y: Update all rules.
4749         (yylex): Update.
4750         * go-exp.y (yylex): Update.
4751         * f-exp.y (yylex): Update.
4752         * d-exp.y: Update all rules.
4753         (yylex): Update.
4754         * c-exp.y: Update all rules.
4755         (lex_one_token, classify_name, yylex, c_parse): Update.
4756         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4757
4758 2019-04-04  Tom Tromey  <tom@tromey.com>
4759
4760         * gdbarch.h, gdbarch.c: Rebuild.
4761         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4762         * stap-probe.h:
4763         (struct stap_parse_info): Replace "parser_state" with
4764         "expr_builder".
4765         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4766         (parser_state): New class.
4767         * parse.c (expr_builder): Rename.
4768         (expr_builder::release): Rename.
4769         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4770         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4771         (write_exp_elt_longcst, write_exp_elt_floatcst)
4772         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4773         (write_exp_string_vector, write_exp_bitstring)
4774         (write_exp_msymbol, mark_struct_expression)
4775         (write_dollar_variable)
4776         (insert_type_address_space, increase_expout_size): Replace
4777         "parser_state" with "expr_builder".
4778         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4779         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4780         "parser_state" with "expr_builder".
4781
4782 2019-04-04  Tom Tromey  <tom@tromey.com>
4783
4784         * rust-exp.y: Replace "parse_language" with method call.
4785         * p-exp.y:
4786         (yylex): Replace "parse_language" with method call.
4787         * m2-exp.y:
4788         (yylex): Replace "parse_language" with method call.
4789         * go-exp.y (classify_name): Replace "parse_language" with method
4790         call.
4791         * f-exp.y (yylex): Replace "parse_language" with method call.
4792         * d-exp.y (lex_one_token): Replace "parse_language" with method
4793         call.
4794         * c-exp.y:
4795         (lex_one_token, classify_name, yylex): Replace "parse_language"
4796         with method call.
4797         * ada-exp.y (find_primitive_type, type_char)
4798         (type_system_address): Replace "parse_language" with method call.
4799
4800 2019-04-04  Tom Tromey  <tom@tromey.com>
4801
4802         * rust-exp.y: Replace "parse_gdbarch" with method call.
4803         * parse.c (write_dollar_variable, insert_type_address_space):
4804         Replace "parse_gdbarch" with method call.
4805         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4806         call.
4807         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4808         call.
4809         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4810         "parse_gdbarch" with method call.
4811         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4812         with method call.
4813         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4814         "parse_gdbarch" with method call.
4815         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4816         "parse_gdbarch" with method call.
4817         * c-exp.y (parse_type, parse_number, classify_name): Replace
4818         "parse_gdbarch" with method call.
4819         * ada-lex.l: Replace "parse_gdbarch" with method call.
4820         * ada-exp.y (parse_type, find_primitive_type, type_char)
4821         (type_system_address): Replace "parse_gdbarch" with method call.
4822
4823 2019-04-04  Tom Tromey  <tom@tromey.com>
4824
4825         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4826         * stap-probe.c (stap_parse_argument): Update.
4827         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4828         initial_size parameter.
4829         * rust-exp.y (rust_lex_tests): Update.
4830         * parse.c (parser_state): Update.
4831         (parse_exp_in_context): Update.
4832         * parser-defs.h (struct parser_state) <parser_state>: Remove
4833         "initial_size" parameter.
4834
4835 2019-04-04  Tom Tromey  <tom@tromey.com>
4836
4837         * parser-defs.h (increase_expout_size): Don't declare.
4838         * parse.c (increase_expout_size): Now static.
4839
4840 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4841
4842         * gnu-nat.c (gnu_nat_target::wait): Fix
4843         target_waitstatus_to_string call.
4844
4845 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4846
4847         * eval.c (evaluate_subexp_standard): Handle internal functions
4848         during Fortran function call handling.
4849
4850 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4851
4852         * NEWS: Mention new internal functions.
4853         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4854         (read_base_type): Use dwarf2_init_complex_target_type.
4855         * value.c (creal_internal_fn): New function.
4856         (cimag_internal_fn): New function.
4857         (_initialize_values): Register new internal functions.
4858
4859 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4860
4861         * infrun.c (stop_all_threads): If debug_infrun, always
4862         trace the wait status after wait_one, using
4863         target_waitstatus_to_string and target_pid_to_str.
4864         (handle_inferior_event): Replace various trace of
4865         wait status kind by a single trace.
4866         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4867         wait status kind image by target_waitstatus_to_string.
4868         * target/waitstatus.c (target_waitstatus_to_string): Fix
4869         obsolete comment.
4870
4871 2019-04-01  Tom Tromey  <tromey@adacore.com>
4872
4873         PR symtab/23331:
4874         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4875
4876 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4877             Pedro Alves  <palves@redhat.com>
4878
4879         * top.c (quit_force): Call 'finalize_values'.
4880         * value.c (finalize_values): New function.
4881         * value.h (finalize_values): Declare.
4882
4883 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4884
4885         * NEWS: Announce $_gdb_major and $_gdb_minor.
4886
4887         * top.c (init_gdb_version_vars): New function.
4888         (gdb_init): Call init_gdb_version_vars.
4889
4890 2019-03-29  Tom Tromey  <tromey@adacore.com>
4891
4892         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4893         help text.  Remove dead code.
4894
4895 2019-03-29  Keith Seitz  <keiths@redhat.com>
4896
4897         From Siddhesh Poyarekar:
4898         * f-lang.h (f77_get_upperbound): Return LONGEST.
4899         (f77_get_lowerbound): Likewise.
4900         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4901         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4902         print them.
4903         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4904         plongest to format print it.
4905         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4906         (f77_get_upperbound): Likewise.
4907         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4908         LOWER_BOUND to LONGEST.
4909         (f77_create_arrayprint_offset_tbl): Likewise.
4910
4911 2019-03-29  Keith Seitz  <keiths@redhat.com>
4912
4913         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4914         %s/pulongest for TYPE_LENGTH instead of %d in format
4915         strings.
4916         * ada-typerint.c (ada_print_type): Likewise.
4917         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4918         * compile/compile-c-support.c (generate_register_struct): Likewise.
4919         * gdbtypes.c (recursive_dump_type): Likewise.
4920         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4921         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4922         instead of %d in format strings.
4923         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4924         to std::min to ULONGEST.
4925         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4926         instead of %d in format strings.
4927         * tracepoint.c (info_scope_command): Likewise.
4928         * typeprint.c (print_offset_data::update)
4929         (print_offset_data::finish): Likewise.
4930         * xtensa-tdep.c (xtensa_store_return_value)
4931         (xtensa_push_dummy_call): Likewise.
4932
4933 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4934
4935         * windows-nat.c (display_selector): Fixed format specifications
4936         for 64-bit Cygwin.
4937
4938 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4939
4940         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4941
4942 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4943
4944         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4945         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4946         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4947         (nios2_linux_init_abi): Install it.
4948
4949 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4950
4951         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4952
4953 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4954
4955         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4956
4957 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4958             Tom Tromey  <tromey@adacore.com>
4959
4960         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4961
4962 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4963
4964         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4965         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4966         method to compute the bounds of range types. Also print "[evaluated]"
4967         if the bounds' values come from a dynamic evaluation.
4968
4969 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4970
4971         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4972         whitespace when pretty printing is on.
4973
4974 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4975
4976         * ppc-linux-nat.c: Add include.
4977
4978 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4979
4980         * NEWS: Mention AArch64 Pointer Authentication.
4981
4982 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4983
4984         * arm-linux-nat.c: Add include.
4985
4986 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4987
4988         * source-cache.c (source_cache::get_source_lines): Re-read
4989         fullname after calling open_source_file.
4990
4991 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4992
4993         * NEWS: Mention TLS support for FreeBSD.
4994
4995 2019-03-25  Tom Tromey  <tromey@adacore.com>
4996
4997         * minsyms.c (BUNCH_SIZE): Update comment.
4998         (~minimal_symbol_reader): Remove old comment.
4999         (compact_minimal_symbols): Update comment.
5000         (minimal_symbol_reader::install): Remove old comment.  Update
5001         other comments.
5002
5003 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5004
5005         * s390-linux-nat.c: Add include.
5006
5007 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5008
5009         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5010         Call linux_get_hwcap.
5011         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5012         Likewise.
5013         (aarch64_linux_get_hwcap): Remove function.
5014         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5015         declaration.
5016         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5017         linux_get_hwcap.
5018         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5019         * linux-tdep.c (linux_get_hwcap): Add function.
5020         (linux_get_hwcap2): Likewise.
5021         * linux-tdep.h (linux_get_hwcap): Add declaration.
5022         (linux_get_hwcap2): Likewise.
5023         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5024         (ppc_linux_get_hwcap2): Likewise.
5025         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5026         linux_get_hwcap.
5027         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5028         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5029         (ppc_linux_nat_target::read_description): Likewise.
5030         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5031         * s390-linux-nat.c: Likewise.
5032         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5033
5034 2019-03-24  Tom Tromey  <tom@tromey.com>
5035
5036         * ada-lang.c (standard_lookup): Simplify initialization.
5037         (ada_lookup_symbol_nonlocal): Simplify return.
5038         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5039         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5040         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5041         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5042         initialization.
5043         * solib.c (solib_global_lookup): Simplify.
5044         * symtab.c (null_block_symbol): Remove.
5045         (symbol_cache_lookup): Simplify returns.
5046         (lookup_language_this): Simplify returns.
5047         (lookup_symbol_aux): Simplify return.
5048         (lookup_local_symbol): Simplify returns.
5049         (lookup_global_symbol_from_objfile): Simplify return.
5050         (lookup_symbol_in_objfile_symtabs)
5051         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5052         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5053         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5054         * cp-namespace.c (cp_lookup_bare_symbol)
5055         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5056         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5057         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5058         (cp_lookup_symbol_via_imports): Simplify initialization.
5059         (find_symbol_in_baseclass): Likewise.
5060         * symtab.h (null_block_symbol): Remove.
5061         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5062         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5063         (d_lookup_symbol_module): Likewise.
5064         (find_symbol_in_baseclass): Simplify initialization.
5065
5066 2019-03-24  Tom Tromey  <tom@tromey.com>
5067
5068         * expression.h: Don't include symtab.h.
5069         (struct block): Forward declare.
5070
5071 2019-03-24  Tom Tromey  <tom@tromey.com>
5072
5073         * c-exp.y (typebase): Remove casts.
5074         * gdbtypes.c (lookup_unsigned_typename, )
5075         (lookup_signed_typename): Remove cast.
5076         * eval.c (parse_to_comma_and_eval): Remove cast.
5077         * parse.c (write_dollar_variable): Remove cast.
5078         * block.h (struct block) <superblock>: Now const.
5079         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5080         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5081         (map_block): Make "block" const.
5082         * symfile.h (struct quick_symbol_functions)
5083         <map_matching_symbols>: Constify block argument to "callback".
5084         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5085         const.
5086         (find_pc_sect_compunit_symtab): Make "b" const.
5087         (find_symbol_at_address): Likewise.
5088         (search_symbols): Likewise.
5089         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5090         (dw2_debug_names_lookup_symbol): Likewise.
5091         (dw2_map_matching_symbols): Update.
5092         * p-valprint.c (pascal_val_print): Remove "block".
5093         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5094         (aux_add_nonlocal_symbols): Make "block" const.
5095         (resolve_subexp): Remove cast.
5096         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5097         const.
5098         (iterate_over_file_blocks): Likewise.
5099         * f-exp.y (%union) <bval>: Remove.
5100         * coffread.c (patch_opaque_types): Make "b" const.
5101         * spu-tdep.c (spu_catch_start): Make "block" const.
5102         * c-valprint.c (print_unpacked_pointer): Remove "block".
5103         * symmisc.c (dump_symtab_1): Make "b" const.
5104         (block_depth): Make "block" const.
5105         * d-exp.y (%union) <bval>: Remove.
5106         * cp-support.h (cp_lookup_rtti_type): Update.
5107         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5108         * psymtab.c (psym_lookup_symbol): Make "block" const.
5109         (maintenance_check_psymtabs): Make "b" const.
5110         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5111         (enumerate_locals, enumerate_args): Update.
5112         * python/py-symtab.c (stpy_global_block): Make "block" const.
5113         (stpy_static_block): Likewise.
5114         * inline-frame.c (block_starting_point_at): Make "new_block"
5115         const.
5116         * block.c (find_block_in_blockvector): Make return type const.
5117         (blockvector_for_pc_sect): Make "b" const.
5118         (find_block_in_blockvector): Make "b" const.
5119
5120 2019-03-23  Tom Tromey  <tom@tromey.com>
5121
5122         * varobj.c (varobj_create): Update.
5123         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5124         * printcmd.c (display_command, do_one_display): Don't reset
5125         innermost_block.
5126         * parser-defs.h (enum innermost_block_tracker_type): Move to
5127         expression.h.
5128         (innermost_block): Update comment.
5129         * parse.c (parse_exp_1): Add tracker_types parameter.
5130         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5131         tracker_types parameter.  Reset innermost_block.
5132         (parse_exp_in_context): Remove.
5133         (parse_expression_for_completion): Update.
5134         * objfiles.c (~objfile): Don't reset expression_context_block or
5135         innermost_block.
5136         * expression.h (enum innermost_block_tracker_type): Move from
5137         parser-defs.h.
5138         (parse_exp_1): Add tracker_types parameter.
5139         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5140         reset innermost_block.
5141
5142 2019-03-23  Tom Tromey  <tom@tromey.com>
5143
5144         * objfiles.h: Include bcache.h.
5145
5146 2019-03-23  Tom Tromey  <tom@tromey.com>
5147
5148         * linespec.c (get_current_search_block): Use
5149         scoped_restore_current_language.
5150         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5151
5152 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5153             Jiong Wang  <jiong.wang@arm.com>
5154
5155         * aarch64-linux-tdep.c
5156         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5157         section.
5158         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5159
5160 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5161             Jiong Wang  <jiong.wang@arm.com>
5162
5163         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5164         instructions.
5165         (aarch64_analyze_prologue_test): Add PACIASP test.
5166         (aarch64_prologue_prev_register): Unmask PC value.
5167
5168 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5169             Jiong Wang  <jiong.wang@arm.com>
5170
5171         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5172         (aarch64_dwarf2_prev_register): Unmask PC value.
5173         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5174         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5175         DW_CFA_AARCH64_negate_ra_state.
5176         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5177
5178 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5179             Jiong Wang  <jiong.wang@arm.com>
5180
5181         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5182         registers.
5183         (aarch64_pseudo_register_name): Likewise.
5184         (aarch64_pseudo_register_type): Likewise.
5185         (aarch64_pseudo_register_reggroup_p): Likewise.
5186         (aarch64_gdbarch_init): Add pauth registers.
5187         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5188         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5189         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5190         (struct gdbarch_tdep): Add regnum for ra_state.
5191
5192 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5193             Jiong Wang  <jiong.wang@arm.com>
5194
5195         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5196
5197 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5198             Jiong Wang  <jiong.wang@arm.com>
5199
5200         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5201         function.
5202         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5203         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5204         (aarch64_gdbarch_init): Add puth registers.
5205         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5206         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5207         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5208
5209 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5210             Jiong Wang  <jiong.wang@arm.com>
5211
5212         * aarch64-linux-nat.c
5213         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5214         * aarch64-linux-tdep.c
5215         (aarch64_linux_core_read_description): Likewise.
5216         (aarch64_linux_get_hwcap): New function.
5217         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5218         (aarch64_linux_get_hwcap): New declaration.
5219
5220 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5221             Jiong Wang  <jiong.wang@arm.com>
5222
5223         * aarch64-linux-nat.c
5224         (aarch64_linux_nat_target::read_description): Add pauth param.
5225         * aarch64-linux-tdep.c
5226         (aarch64_linux_core_read_description): Likewise.
5227         * aarch64-tdep.c (struct target_desc): Add in pauth.
5228         (aarch64_read_description): Add pauth param.
5229         (aarch64_gdbarch_init): Likewise.
5230         * aarch64-tdep.h (aarch64_read_description): Likewise.
5231         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5232         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5233         * features/Makefile: Add new files.
5234         * features/aarch64-pauth.c: New file.
5235         * features/aarch64-pauth.xml: New file.
5236
5237 2019-03-20  Tom Tromey  <tromey@adacore.com>
5238
5239         * infrun.c (handle_inferior_event): Rename from
5240         handle_inferior_event_1.  Create a scoped_value_mark.
5241         (handle_inferior_event): Remove.
5242
5243 2019-03-19  Tom Tromey  <tromey@adacore.com>
5244
5245         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5246         * infrun.h (print_stop_event): Add "displays" parameter.
5247         * infrun.c (print_stop_event): Add "displays" parameter.
5248
5249 2019-03-19  Pedro Alves  <palves@redhat.com>
5250
5251         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5252         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5253         to -1.  Fix TABs vs spaces.
5254         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5255         * tui/tui-out.h (tui_ui_out) Add intro comments.
5256         <m_line, m_start_of_line>: In-class initialize, and add describing
5257         comment.
5258
5259 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5260
5261         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5262         variable names.
5263         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5264
5265 2019-03-18  Pedro Alves  <palves@redhat.com>
5266             Eli Zaretskii <eliz@gnu.org>
5267
5268         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5269         m_line and m_start_of_line.
5270
5271 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5272
5273         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5274         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5275         it returns a newline.  This fixes a regression in TU mode, whereby
5276         the next line is output on the same screen line as the user input.
5277
5278 2019-03-18  Tom Tromey  <tromey@adacore.com>
5279
5280         * minsyms.c (minimal_symbol_reader::install): Remove call to
5281         obstack_blank.
5282
5283 2019-03-18  Pedro Alves  <palves@redhat.com>
5284
5285         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5286         New globals.
5287         (apply_style): New, factored out from ...
5288         (apply_ansi_escape): ... this.  Handle reverse video mode.
5289         (tui_set_reverse_mode): New function.
5290         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5291         * tui/tui-winsource.c (tui_show_source_line): Use
5292         tui_set_reverse_mode instead of setting A_STANDOUT.
5293         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5294         New setter methods.
5295
5296 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5297
5298         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5299         Handle tabs.
5300
5301 2019-03-18  Tom Tromey  <tromey@adacore.com>
5302
5303         * ada-lang.c (empty_array): Add "high" parameter.
5304         (ada_evaluate_subexp): Update.
5305
5306 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5307
5308         * unittests/string_view-selftests.c: Define
5309         _initialize_string_view_selftests unconditionally.
5310
5311 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5312
5313         PR gdb/24350
5314         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5315
5316 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5317
5318         PR gdb/24351
5319         * windows-nat.c (display_selector): Fix format specifiers.
5320
5321 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5322
5323         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5324         tui_refill_source_window instead of tui_refresh_win, to update the
5325         current execution line.  This fixes redisplay of the current line
5326         when stepping through the code with "next" or "step".
5327
5328 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5329
5330         * source-cache.c (source_cache::get_source_lines): Call
5331         find_source_lines to initialize s->nlines.  This fixes vertical
5332         scrolling of TUI source window when the DOWN arrow is pressed.
5333
5334 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5335
5336         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5337         linux-thread-db.c (_initialize_thread_db): Likewise.
5338
5339 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5340
5341         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5342         wclrtoeol in tui_show_source_line".  This reverts changes made in
5343         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5344
5345 2019-03-15  Tom Tromey  <tom@tromey.com>
5346
5347         * symtab.h (struct minimal_symbol): Derive from
5348         general_symbol_info.
5349         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5350         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5351         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5352         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5353         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5354         (MSYMBOL_SEARCH_NAME): Update.
5355         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5356         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5357         * minsyms.c (minimal_symbol_reader::record_full): Update.
5358
5359 2019-03-15  Tom Tromey  <tom@tromey.com>
5360
5361         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5362
5363 2019-03-15  Tom Tromey  <tom@tromey.com>
5364
5365         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5366         unique_xmalloc_ptr.
5367         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5368         Update.
5369         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5370         (build_minimal_symbol_hash_tables)
5371         (minimal_symbol_reader::install): Update.
5372
5373 2019-03-15  Tom Tromey  <tom@tromey.com>
5374
5375         * symtab.c (create_demangled_names_hash): Update.
5376         (symbol_set_names): Update.
5377         * objfiles.h (struct objfile_per_bfd_storage)
5378         <demangled_names_hash>: Now an htab_up.
5379         * objfiles.c (objfile_per_bfd_storage): Simplify.
5380
5381 2019-03-15  Tom Tromey  <tom@tromey.com>
5382
5383         * objfiles.h (struct objfile_per_bfd_storage): Declare
5384         destructor.
5385         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5386         New.
5387         (get_objfile_bfd_data): Use new.  Don't initialize
5388         language_of_main.
5389         (free_objfile_per_bfd_storage): Remove.
5390         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5391
5392 2019-03-15  Tom Tromey  <tom@tromey.com>
5393
5394         * symfile.c (reread_symbols): Update.
5395         * objfiles.c (objfile::objfile): Update.
5396         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5397         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5398         comment.
5399         (minimal_symbol_reader::install): Update.
5400         (terminate_minimal_symbol_table): Remove.
5401         * jit.c (jit_object_close_impl): Update.
5402
5403 2019-03-15  Tom Tromey  <tom@tromey.com>
5404
5405         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5406         initializations.
5407
5408 2019-03-15  Tom Tromey  <tom@tromey.com>
5409
5410         * objfiles.h (struct objfile_per_bfd_storage)
5411         <demangled_hash_languages>: Now a bitset.
5412         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5413         (lookup_minimal_symbol): Update.
5414
5415 2019-03-15  Tom Tromey  <tom@tromey.com>
5416
5417         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5418         Don't return the symbol.
5419         * coffread.c (record_minimal_symbol): Use record_full.
5420
5421 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5422
5423         The MS-Windows port of ncurses fails to switch to a color pair if
5424         one or both of the colors are the implicit default colors.  This
5425         change records the default colors when TUI is initialized, and
5426         then specifies them explicitly when a color pair uses the default
5427         colors.  This allows color styling in TUI mode on MS-Windows.
5428
5429         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5430         ncurses_norm_attr.
5431         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5432         colors in ncurses_norm_attr.
5433         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5434         "none", replace it with the default color recorded in
5435         ncurses_norm_attr.
5436
5437 2019-03-14  Tom Tromey  <tromey@adacore.com>
5438
5439         * source-cache.h (class source_cache) <get_source_lines>: Return
5440         std::string.
5441         * source-cache.c (source_cache::extract_lines): Handle case where
5442         first_pos==npos.  Return std::string.
5443         (source_cache::get_source_lines): Update.
5444
5445 2019-03-14  Tom Tromey  <tromey@adacore.com>
5446
5447         * NEWS: Add item for "style sources" commands.
5448         * source-cache.c (source_cache::get_source_lines): Check
5449         source_styling.
5450         * cli/cli-style.c (source_styling): New global.
5451         (_initialize_cli_style): Add "style sources" commands.
5452         (show_style_sources): New function.
5453         * cli/cli-style.h (source_styling): Declare.
5454
5455 2019-03-14  Pedro Alves  <palves@redhat.com>
5456             Tom Tromey  <tromey@adacore.com>
5457
5458         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5459         * tui/tui-winsource.c (tui_refill_source_window): New function,
5460         from...
5461         (tui_horizontal_source_scroll): ... here.  Move some logic.
5462         * cli/cli-style.c (set_style_enabled): Notify new observable.
5463         * tui/tui-hooks.c (tui_redisplay_source): New function.
5464         (tui_attach_detach_observers): Attach or detach
5465         tui_redisplay_source.
5466         * observable.h (source_styling_changed): New observable.
5467         * observable.c: Define source_styling_changed observable.
5468
5469 2019-03-13  Tom Tromey  <tromey@adacore.com>
5470
5471         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5472         (i386_gnu_nat_target::store_registers): Update.
5473         * target-debug.h (target_debug_print_std_string): New macro.
5474         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5475         * windows-tdep.c (display_one_tib): Update.
5476         * tui/tui-stack.c (tui_make_status_line): Update.
5477         * top.c (print_inferior_quit_action): Update.
5478         * thread.c (thr_try_catch_cmd): Update.
5479         (add_thread_with_info): Update.
5480         (thread_target_id_str): Update.
5481         (thr_try_catch_cmd): Update.
5482         (thread_command): Update.
5483         (thread_find_command): Update.
5484         * record-btrace.c (record_btrace_target::info_record)
5485         (record_btrace_resume_thread, record_btrace_target::resume)
5486         (record_btrace_cancel_resume, record_btrace_step_thread)
5487         (record_btrace_target::wait, record_btrace_target::wait)
5488         (record_btrace_target::wait, record_btrace_target::stop): Update.
5489         * progspace.c (print_program_space): Update.
5490         * process-stratum-target.c
5491         (process_stratum_target::thread_address_space): Update.
5492         * linux-fork.c (linux_fork_mourn_inferior)
5493         (detach_checkpoint_command, info_checkpoints_command)
5494         (linux_fork_context): Update.
5495         (linux_fork_detach): Update.
5496         (class scoped_switch_fork_info): Update.
5497         (delete_checkpoint_command): Update.
5498         * infrun.c (follow_fork_inferior): Update.
5499         (follow_fork_inferior): Update.
5500         (proceed_after_vfork_done): Update.
5501         (handle_vfork_child_exec_or_exit): Update.
5502         (follow_exec): Update.
5503         (displaced_step_prepare_throw): Update.
5504         (displaced_step_restore): Update.
5505         (start_step_over): Update.
5506         (resume_1): Update.
5507         (clear_proceed_status_thread): Update.
5508         (proceed): Update.
5509         (print_target_wait_results): Update.
5510         (do_target_wait): Update.
5511         (context_switch): Update.
5512         (stop_all_threads): Update.
5513         (restart_threads): Update.
5514         (finish_step_over): Update.
5515         (handle_signal_stop): Update.
5516         (switch_back_to_stepped_thread): Update.
5517         (keep_going_pass_signal): Update.
5518         (print_exited_reason): Update.
5519         (normal_stop): Update.
5520         * inferior.c (inferior_pid_to_str): Change return type.
5521         (print_selected_inferior): Update.
5522         (add_inferior): Update.
5523         (detach_inferior): Update.
5524         * dummy-frame.c (fprint_dummy_frames): Update.
5525         * dcache.c (dcache_info_1): Update.
5526         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5527         (btrace_fetch, btrace_clear): Update.
5528         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5529         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5530         type.
5531         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5532         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5533         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5534         * gdbarch.c, gdbarch.h: Rebuild.
5535         * gdbarch.sh (core_pid_to_str): Change return type.
5536         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5537         return type.
5538         (windows_nat_target::pid_to_str): Change return type.
5539         (windows_delete_thread): Update.
5540         (windows_nat_target::attach): Update.
5541         (windows_nat_target::files_info): Update.
5542         * target-delegates.c: Rebuild.
5543         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5544         return type.
5545         (sol_thread_target::pid_to_str): Change return type.
5546         * remote.c (class remote_target) <pid_to_str>: Change return
5547         type.
5548         (remote_target::pid_to_str): Change return type.
5549         (extended_remote_target::attach, remote_target::remote_stop_ns)
5550         (remote_target::remote_notif_remove_queued_reply)
5551         (remote_target::push_stop_reply, remote_target::disable_btrace):
5552         Update.
5553         (extended_remote_target::attach): Update.
5554         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5555         type.
5556         (gdbsim_target::pid_to_str): Change return type.
5557         * ravenscar-thread.c (struct ravenscar_thread_target)
5558         <pid_to_str>: Change return type.
5559         (ravenscar_thread_target::pid_to_str): Change return type.
5560         * procfs.c (class procfs_target) <pid_to_str>: Change return
5561         type.
5562         (procfs_target::pid_to_str): Change return type.
5563         (procfs_target::attach): Update.
5564         (procfs_target::detach): Update.
5565         (procfs_target::fetch_registers): Update.
5566         (procfs_target::store_registers): Update.
5567         (procfs_target::wait): Update.
5568         (procfs_target::files_info): Update.
5569         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5570         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5571         return type.
5572         (nto_procfs_target::pid_to_str): Change return type.
5573         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5574         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5575         return type.
5576         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5577         (exit_lwp): Update.
5578         (attach_proc_task_lwp_callback, get_detach_signal)
5579         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5580         (linux_nat_target::resume, wait_lwp, stop_callback)
5581         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5582         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5583         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5584         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5585         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5586         type.
5587         (inf_ptrace_target::attach): Update.
5588         (inf_ptrace_target::files_info): Update.
5589         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5590         type.
5591         (go32_nat_target::pid_to_str): Change return type.
5592         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5593         (gnu_nat_target::wait): Update.
5594         (gnu_nat_target::wait): Update.
5595         (gnu_nat_target::resume): Update.
5596         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5597         (fbsd_nat_target::wait): Update.
5598         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5599         type.
5600         (darwin_nat_target::attach): Update.
5601         * corelow.c (class core_target) <pid_to_str>: Change return type.
5602         (core_target::pid_to_str): Change return type.
5603         * target.c (normal_pid_to_str): Change return type.
5604         (default_pid_to_str): Likewise.
5605         (target_pid_to_str): Change return type.
5606         (target_translate_tls_address): Update.
5607         (target_announce_detach): Update.
5608         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5609         return type.
5610         (bsd_uthread_target::pid_to_str): Change return type.
5611         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5612         type.
5613         (bsd_kvm_target::pid_to_str): Change return type.
5614         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5615         return type.
5616         (aix_thread_target::pid_to_str): Change return type.
5617         * target.h (struct target_ops) <pid_to_str>: Change return type.
5618         (target_pid_to_str, normal_pid_to_str): Likewise.
5619         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5620         type.
5621         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5622         type.
5623         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5624         return type.
5625         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5626         type.
5627         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5628         type.
5629         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5630         return type.
5631
5632 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5633
5634         * NEWS: Mention that the new default MI version is 3.  Mention
5635         changes to the output of commands and events that deal with
5636         multi-location breakpoints.
5637         * breakpoint.c: Include "mi/mi-out.h".
5638         (print_one_breakpoint): Change output syntax if using MI version
5639         >= 3.
5640         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5641         New.
5642         (mi_multi_location_breakpoint_output_fixed): New.
5643         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5644         (mi_cmd_fix_multi_location_breakpoint_output): New.
5645         (mi_multi_location_breakpoint_output_fixed): New.
5646         * mi/mi-cmds.c (mi_cmds): Register command
5647         -fix-multi-location-breakpoint-output.
5648         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5649         interpreter "mi".
5650
5651 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5652
5653         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5654         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5655         instantiate mi_ui_out based on interpreter name.
5656         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5657         * mi/mi-main.c (mi_load_progress): Likewise.
5658
5659 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5660
5661         * NEWS: Combine separate "New targets" sections for 8.3.
5662
5663 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5664
5665         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5666         (ppcfbsd_init_abi): Install gdbarch
5667         "fetch_tls_load_module_address" and "get_thread_local_address"
5668         methods.
5669
5670 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5671
5672         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5673         (riscv_fbsd_init_abi): Install gdbarch
5674         "fetch_tls_load_module_address" and "get_thread_local_address"
5675         methods.
5676
5677 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5678
5679         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5680         (i386fbsd_init_abi): Install gdbarch
5681         "fetch_tls_load_module_address" and "get_thread_local_address"
5682         methods.
5683
5684 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5685
5686         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5687         (amd64fbsd_init_abi): Install gdbarch
5688         "fetch_tls_load_module_address" and "get_thread_local_address"
5689         methods.
5690
5691 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5692
5693         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5694         (struct fbsd_pspace_data): New type.
5695         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5696         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5697         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5698         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5699         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5700
5701 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5702
5703         * gdbtypes.c (lookup_struct_elt): New function.
5704         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5705         * gdbtypes.h (struct struct_elt): New type.
5706         (lookup_struct_elt): New prototype.
5707
5708 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5709
5710         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5711         remove disabled code block.
5712
5713 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5714
5715         * gdbarch.sh (get_thread_local_address): New method.
5716         * gdbarch.h, gdbarch.c: Regenerate.
5717         * target.c (target_translate_tls_address): Use
5718         gdbarch_get_thread_local_address if present instead of
5719         target::get_thread_local_address.
5720
5721 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5722
5723         * target.h (target::get_thread_local_address): Update comment.
5724
5725 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5726
5727         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5728         objfile->separate_debug_objfile_backlink if not NULL.
5729
5730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5731
5732         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5733         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5734         (amd64bsd_store_inferior_registers): Likewise.
5735         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5736         Enable segment base registers.
5737         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5738         PT_GETFSBASE and PT_GETGSBASE.
5739         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5740         PT_SETGSBASE.
5741         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5742         segment base registers.
5743         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5744
5745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5746
5747         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5748         Update calls to i386_target_description to add 'segments'
5749         parameter.
5750         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5751         add segment base registers.
5752         * arch/i386.c (i386_create_target_description): Add 'segments'
5753         parameter to enable segment base registers.
5754         * arch/i386.h (i386_create_target_description): Likewise.
5755         * features/i386/32bit-segments.xml: New file.
5756         * features/i386/32bit-segments.c: Generate.
5757         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5758         call to i386_target_description to add 'segments' parameter.
5759         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5760         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5761         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5762         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5763         if feature is present.
5764         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5765         Add 'segments' parameter to call to i386_target_description.
5766         (i386_target_description): Add 'segments' parameter to enable
5767         segment base registers.
5768         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5769         to call to i386_target_description.
5770         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5771         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5772         Define I386_NUM_REGS.
5773         (i386_target_description): Add 'segments' parameter to enable
5774         segment base registers.
5775
5776 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5777
5778         PR/24325
5779         * source-cache.c: #undef open and close, to avoid unresolved
5780         externals during linking.
5781
5782 2019-03-12  Tom Tromey  <tromey@adacore.com>
5783
5784         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5785         const.  Add initializers.
5786         (_initialize_remote): Don't initialize ptid globals.
5787
5788 2019-03-12  Pedro Alves  <palves@redhat.com>
5789
5790         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5791
5792 2019-03-12  Pedro Alves  <palves@redhat.com>
5793
5794         * cp-name-parser.y (main): Remove unused 'len' variable.
5795
5796 2019-03-12  Tom Tromey  <tromey@adacore.com>
5797
5798         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5799         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5800
5801 2019-03-12  Tom Tromey  <tromey@adacore.com>
5802
5803         * linux-nat.c (iterate_over_lwps): Update.
5804         (stop_callback): Remove parameter.
5805         (stop_wait_callback, detach_callback, resume_set_callback)
5806         (select_singlestep_lwp_callback, set_ignore_sigint)
5807         (status_callback, resumed_callback, resume_clear_callback)
5808         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5809         data parameter.
5810         (linux_nat_target::detach, linux_nat_target::resume)
5811         (linux_stop_and_wait_all_lwps, select_event_lwp)
5812         (linux_nat_filter_event, linux_nat_wait_1)
5813         (linux_nat_target::kill, linux_nat_target::stop)
5814         (linux_nat_target::stop): Update.
5815         (linux_nat_resume_callback): Change type.
5816         (resume_stopped_resumed_lwps, count_events_callback)
5817         (select_event_lwp_callback): Likewise.
5818         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5819         * arm-linux-nat.c (struct update_registers_data): Remove.
5820         (update_registers_callback): Change type.
5821         (arm_linux_insert_hw_breakpoint1): Update.
5822         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5823         parameter.
5824         (x86_linux_dr_set_addr): Update.
5825         (x86_linux_dr_set_control): Update.
5826         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5827         (iterate_over_lwps): Use gdb::function_view.
5828         * nat/aarch64-linux-hw-point.c (struct
5829         aarch64_dr_update_callback_param): Remove.
5830         (debug_reg_change_callback): Change type.
5831         (aarch64_notify_debug_reg_change): Update.
5832         * s390-linux-nat.c (s390_refresh_per_info): Update.
5833
5834 2019-03-11  Tom Tromey  <tromey@adacore.com>
5835
5836         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5837         redundant assignment to "this_cu".
5838
5839 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5840
5841         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5842
5843 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5844
5845         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5846         from...
5847         (rank_one_type): ... this.
5848
5849 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5850
5851         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5852         from...
5853         (rank_one_type): ... this.
5854
5855 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5856
5857         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5858         from...
5859         (rank_one_type): ... this.
5860
5861 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5862
5863         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5864         from...
5865         (rank_one_type): ... this.
5866
5867 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5868
5869         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5870         from...
5871         (rank_one_type): ... this.
5872
5873 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5874
5875         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5876         from...
5877         (rank_one_type): ... this.
5878
5879 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5880
5881         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5882         from...
5883         (rank_one_type): ... this.
5884
5885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5886
5887         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5888         from...
5889         (rank_one_type): ... this.
5890
5891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5892
5893         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5894         from...
5895         (rank_one_type): ... this.
5896
5897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5898
5899         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5900         from...
5901         (rank_one_type): ... this.
5902
5903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5904
5905         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5906         from...
5907         (rank_one_type): ... this.
5908
5909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5910
5911         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5912         from...
5913         (rank_one_type): ... this.
5914
5915 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5916
5917         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5918         inferior-events' shows the example events.
5919
5920 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5921
5922         Support styling on native MS-Windows console
5923
5924         PR/24315
5925         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5926         on MS-Windows if $TERM is not defined.
5927
5928         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5929
5930         * posix-hdep.c (gdb_console_fputs):
5931         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5932         functions.
5933         * ui-file.h (gdb_console_fputs): Add prototype.
5934
5935         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5936         back to fputs only if the former returns zero.
5937
5938 2019-03-07  Tom Tromey  <tom@tromey.com>
5939
5940         * symmisc.c (print_symbol_bcache_statistics): Update.
5941         (print_objfile_statistics): Update.
5942         * symfile.c (allocate_symtab): Update.
5943         * stabsread.c: Don't include bcache.h.
5944         * psymtab.h (struct psymbol_bcache): Don't declare.
5945         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5946         (psymbol_bcache_init, psymbol_bcache_free)
5947         (psymbol_bcache_get_bcache): Don't declare.
5948         * psymtab.c (struct psymbol_bcache): Remove.
5949         (psymtab_storage::psymtab_storage): Update.
5950         (psymtab_storage::~psymtab_storage): Update.
5951         (psymbol_bcache_init, psymbol_bcache_free)
5952         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5953         (add_psymbol_to_bcache): Update.
5954         (allocate_psymtab): Update.
5955         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5956         macro_cache>: No longer pointers.
5957         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5958         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5959         * macrotab.c (macro_bcache): Update.
5960         * macroexp.c: Don't include bcache.h.
5961         * gdbtypes.c (check_types_worklist): Update.
5962         (types_deeply_equal): Remove TRY/CATCH.  Update.
5963         * elfread.c (elf_symtab_read): Update.
5964         * dwarf2read.c: Don't include bcache.h.
5965         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5966         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5967         (print_bcache_statistics, bcache_memory_used): Don't declare.
5968         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5969         methods.  Rename all data members.
5970         * bcache.c (struct bcache): Move to bcache.h.
5971         (bcache::expand_hash_table): Rename from expand_hash_table.
5972         (bcache): Remove.
5973         (bcache::insert): Rename from bcache_full.
5974         (bcache::compare): Rename from bcache_compare.
5975         (bcache_xmalloc): Remove.
5976         (bcache::~bcache): Rename from bcache_xfree.
5977         (bcache::print_statistics): Rename from print_bcache_statistics.
5978         (bcache::memory_used): Rename from bcache_memory_used.
5979
5980 2019-03-07  Pedro Alves  <palves@redhat.com>
5981
5982         * infrun.c (normal_stop): Also check for
5983         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5984
5985 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5986
5987         * f-lang.c (value_from_host_double): Moved to...
5988         * value.c (value_from_host_double): ...here.
5989         * value.h (value_from_host_double): Declare.
5990         * guile/scm-math.c (vlscm_convert_typed_number): Use
5991         value_from_host_double.
5992         (vlscm_convert_number): Likewise.
5993         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5994         * python/py-value.c (convert_value_from_python): Likewise.
5995
5996 2019-03-06  Tom Tromey  <tom@tromey.com>
5997
5998         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5999
6000 2019-03-06  Tom Tromey  <tom@tromey.com>
6001
6002         * utils.h (free_current_contents): Don't declare.
6003         * utils.c (free_current_contents): Remove.
6004
6005 2019-03-06  Tom Tromey  <tom@tromey.com>
6006
6007         * top.c (quit_force): Update.
6008         * main.c (captured_command_loop): Update.
6009         * common/new-op.c (operator new): Update.
6010         * common/common-exceptions.c (struct catcher)
6011         <save_cleanup_chain>: Remove member.
6012         (exceptions_state_mc_init): Update.
6013         (exception_try_scope_entry): Return nullptr.
6014         (exception_try_scope_exit, exception_rethrow)
6015         (throw_exception_sjlj, throw_exception_cxx): Update.
6016         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6017         (all_cleanups, do_cleanups, discard_cleanups)
6018         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6019         (restore_cleanups, restore_final_cleanups): Don't declare.
6020         (do_final_cleanups): Remove parameter.
6021         * common/cleanups.c (cleanup_chain, make_cleanup)
6022         (make_cleanup_dtor, all_cleanups, do_cleanups)
6023         (discard_my_cleanups, discard_cleanups)
6024         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6025         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6026         (null_cleanup): Remove.
6027         (do_final_cleanups): Remove parameter.
6028
6029 2019-03-06  Tom Tromey  <tom@tromey.com>
6030
6031         * remote.c (remote_target::remote_parse_stop_reply): Use
6032         unique_xmalloc_ptr.
6033
6034 2019-03-06  Tom Tromey  <tom@tromey.com>
6035
6036         * stabsread.c (struct stabs_field_info): Rename from field_info.
6037         <list, fnlist>: Add initializers.
6038         <obstack>: New member.
6039         (read_member_functions, read_struct_fields, read_baseclasses):
6040         Allocate on obstack.  Don't use cleanups.
6041         (read_one_struct_field, read_member_functions, read_struct_fields)
6042         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6043         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6044         (read_struct_type): Update.
6045
6046 2019-03-06  Tom Tromey  <tom@tromey.com>
6047
6048         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6049         * common/filestuff.h (make_cleanup_close): Don't declare.
6050         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6051         Remove.
6052
6053 2019-03-06  Tom Tromey  <tom@tromey.com>
6054
6055         * solib-aix.c: Use make_scope_exit.
6056
6057 2019-03-06  Tom Tromey  <tom@tromey.com>
6058
6059         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6060         Use make_scope_exit.
6061
6062 2019-03-06  Tom Tromey  <tom@tromey.com>
6063
6064         * solib-svr4.c (disable_probes_interface): Remove parameter.
6065         (svr4_handle_solib_event): Use make_scope_exit.
6066
6067 2019-03-06  Tom Tromey  <tom@tromey.com>
6068
6069         * remote.c (struct stop_reply_deleter): Remove.
6070         (stop_reply_up): Update.
6071         (struct stop_reply): Derive from notif_event.  Don't typedef.
6072         <regcache>: Now a std::vector.
6073         (stop_reply_xfree): Remove.
6074         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6075         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6076         (remote_target::discard_pending_stop_replies): Use delete.
6077         (remote_target::remote_parse_stop_reply): Update.
6078         (remote_target::process_stop_reply): Update.
6079         * remote-notif.h (struct notif_event): Add virtual destructor.
6080         Remove "dtr" member.
6081         (struct notif_client) <alloc_event>: Return a unique_ptr.
6082         (notif_event_xfree): Don't declare.
6083         (notif_event_up): New typedef.
6084         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6085         (notif_event_xfree, do_notif_event_xfree): Remove.
6086         (remote_notif_state_xfree): Update.
6087
6088 2019-03-06  Tom Tromey  <tom@tromey.com>
6089
6090         * infrun.c (displaced_step_clear_cleanup): Now a
6091         forward_scope_exit type.
6092         (displaced_step_prepare_throw): Update.
6093         (displaced_step_fixup): Update.
6094
6095 2019-03-06  Tom Tromey  <tom@tromey.com>
6096
6097         * inferior.h (class inferior): Update comment.
6098         * gdbthread.h (class thread_info): Update comment.
6099
6100 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6101             Tom Tromey  <tom@tromey.com>
6102
6103         * stabsread.h (struct stab_section_list): Remove.
6104         (coffstab_build_psymtabs): Update.
6105         * dbxread.c (symbuf_sections): Now a std::vector.
6106         (sect_idx): New global.
6107         (fill_symbuf): Update.
6108         (coffstab_build_psymtabs): Change type of stabsects parameter.
6109         Update.
6110         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6111         std::vector.
6112         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6113         (coff_locate_sections): Update.
6114         (coff_symfile_read): Remove cleanups.  Update.
6115         (init_stringtab): Add storage parameter.
6116         (free_stringtab, free_stringtab_cleanup): Remove.
6117         (init_lineno): Add storage parameter.
6118         (free_linetab, free_linetab_cleanup): Remove.
6119
6120 2019-03-06  Pedro Alves  <palves@redhat.com>
6121
6122         * linux-fork.c (fork_info::clobber_regs): Delete.
6123         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6124         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6125         comment.  Adjust.
6126         (scoped_switch_fork_info::scoped_switch_fork_info)
6127         (checkpoint_command, linux_fork_context): Adjust
6128         fork_save_infrun_state calls.
6129
6130 2019-03-06  Pedro Alves  <palves@redhat.com>
6131
6132         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6133         (inf_has_multiple_threads): Return 'bool' and rewrite using
6134         inferior_info::threads().
6135
6136 2019-03-06  Pedro Alves  <palves@redhat.com>
6137
6138         * linux-fork.c: Include <list>.
6139         (fork_list): Now a std::list instance.
6140         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6141         (forks_exist_p, find_last_fork): Adjust.
6142         (new_fork): Delete.
6143         (one_fork_p): New.
6144         (add_fork): Adjust.
6145         (free_fork): Delete, folded into fork_info::~fork_info().
6146         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6147         Adjust.
6148         (init_fork_list): Delete.
6149         (linux_fork_killall, linux_fork_mourn_inferior)
6150         (linux_fork_detach, info_checkpoints_command): Adjust.
6151         (_initialize_linux_fork): No longer call init_fork_list.
6152
6153 2019-03-06  Pedro Alves  <palves@redhat.com>
6154
6155         * linux-fork.c (new_fork): New, split out of ...
6156         (add_fork): ... this.  Return void.  Move "first fork" special
6157         case from here, to ...
6158         (checkpoint_command): ... here.
6159         * linux-linux.h (add_fork): Return void.
6160
6161 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6162
6163         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6164
6165 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6166             Chris January  <chris.january@arm.com>
6167             David Lecomber  <david.lecomber@arm.com>
6168
6169         * f-exp.y: New token, UNOP_INTRINSIC.
6170         (exp): New pattern using UNOP_INTRINSIC token.
6171         (f77_keywords): Add 'abs' keyword.
6172         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6173         (value_from_host_double): New function.
6174         (evaluate_subexp_f): Support UNOP_ABS.
6175
6176 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6177
6178         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6179         types.
6180
6181 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6182
6183         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6184         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6185         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6186
6187 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6188
6189         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6190
6191 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6192             Chris January  <chris.january@arm.com>
6193
6194         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6195         * f-exp.y: Define 'KIND' token.
6196         (exp): New pattern for KIND expressions.
6197         (ptype): Handle types with a kind extension.
6198         (direct_abs_decl): Extend to spot kind extensions.
6199         (f77_keywords): Add 'kind' to the list.
6200         (push_kind_type): New function.
6201         (convert_to_kind_type): New function.
6202         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6203         * parse.c (operator_length_standard): Likewise.
6204         * parser-defs.h (enum type_pieces): Add tp_kind.
6205         * std-operator.def: Add UNOP_KIND.
6206
6207 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6208
6209         * f-exp.y (f_parse): Set yydebug.
6210
6211 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6212
6213         * f-lang.c (evaluate_subexp_f): New function.
6214         (exp_descriptor_f): New global.
6215         (f_language_defn): Use exp_descriptor_f instead of
6216         exp_descriptor_standard.
6217
6218 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6219
6220         * f-exp.y (struct token): Add comments.
6221         (dot_ops): Remove uppercase versions and the end marker.
6222         (f77_keywords): Likewise.
6223         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6224         entries in the dot_ops array are case insensitive, and use
6225         strncasecmp to compare strings.  Also some whitespace cleanup in
6226         this area.  Similar for the f77_keywords array, except entries in
6227         this list might be case sensitive.
6228
6229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6230
6231         * f-exp.y (struct f77_boolean_val): Add comments.
6232         (boolean_values): Remove uppercase versions, and end marker.
6233         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6234         and use strncasecmp to achieve case insensitivity.  Additionally,
6235         perform whitespace cleanup around this code.
6236
6237 2019-03-06  Tom Tromey  <tromey@adacore.com>
6238
6239         * remote-sim.c (gdbsim_target_open): Use result of
6240         gdb_argv::release.
6241
6242 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6243         Dirk Schubert  <dirk.schubert@arm.com>
6244         Chris January  <chris.january@arm.com>
6245
6246         * eval.c (evaluate_subexp_standard): Call Fortran argument
6247         wrapping logic.
6248         * f-lang.c (struct value): A value which can be passed into a
6249         Fortran function call.
6250         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6251         where appropriate.
6252         (struct type): Value ready for a Fortran function call.
6253         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6254         is needed.
6255         * f-lang.h (fortran_argument_convert): Declaration.
6256         (fortran_preserve_arg_pointer): Declaration.
6257         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6258
6259 2019-03-05  Tom Tromey  <tromey@adacore.com>
6260
6261         * python/py-prettyprint.c (print_string_repr): Remove #if.
6262         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6263
6264 2019-03-05  Tom Tromey  <tromey@adacore.com>
6265
6266         * target.c (the_dummy_target): Move later.  Change type to
6267         "dummy_target".
6268         (initialize_targets): Don't initialize the_dummy_target.
6269
6270 2019-03-05  Tom Tromey  <tromey@adacore.com>
6271
6272         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6273         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6274
6275 2019-03-05  Tom Tromey  <tromey@adacore.com>
6276
6277         * windows-nat.c (windows_nat_target::attach)
6278         (windows_nat_target::detach): Don't call gdb_flush.
6279         * valprint.c (generic_val_print, val_print, val_print_string):
6280         Don't call gdb_flush.
6281         * utils.c (defaulted_query): Don't call gdb_flush.
6282         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6283         * target.c (target_announce_detach): Don't call gdb_flush.
6284         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6285         * remote.c (extended_remote_target::attach): Don't call
6286         gdb_flush.
6287         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6288         * printcmd.c (do_examine): Don't call gdb_flush.
6289         (info_display_command): Don't call gdb_flush.
6290         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6291         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6292         * memattr.c (info_mem_command): Don't call gdb_flush.
6293         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6294         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6295         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6296         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6297         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6298         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6299         (gnu_nat_target::detach): Don't call gdb_flush.
6300         * f-valprint.c (f_val_print): Don't call gdb_flush.
6301         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6302         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6303         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6304         gdb_flush.
6305         * c-valprint.c (c_val_print): Don't call gdb_flush.
6306         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6307
6308 2019-03-05  Tom Tromey  <tromey@adacore.com>
6309
6310         * varobj.c (update_dynamic_varobj_children): Update.
6311         (install_default_visualizer): Use reset, not release.
6312         * value.c (set_internalvar): Update.
6313         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6314         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6315         ATTRIBUTE_UNUSED_RESULT.
6316
6317 2019-03-05  Tom Tromey  <tromey@adacore.com>
6318
6319         * remote.c (class scoped_remote_fd) <release>: Add
6320         ATTRIBUTE_UNUSED_RESULT.
6321
6322 2019-03-05  Tom Tromey  <tromey@adacore.com>
6323
6324         * macroexp.c (struct macro_buffer) <release>: Add
6325         ATTRIBUTE_UNUSED_RESULT.
6326
6327 2019-03-05  Tom Tromey  <tromey@adacore.com>
6328
6329         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6330         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6331         ATTRIBUTE_UNUSED_RESULT.
6332
6333 2019-03-05  Tom Tromey  <tromey@adacore.com>
6334
6335         * common/scoped_fd.h (class scoped_fd) <release>: Add
6336         ATTRIBUTE_UNUSED_RESULT.
6337
6338 2019-03-05  Tom Tromey  <tromey@adacore.com>
6339
6340         * parser-defs.h (struct parser_state) <release>: Add
6341         ATTRIBUTE_UNUSED_RESULT.
6342
6343 2019-03-05  Tom Tromey  <tromey@adacore.com>
6344
6345         * utils.h (class gdb_argv) <release>: Add
6346         ATTRIBUTE_UNUSED_RESULT.
6347         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6348
6349 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6350
6351         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6352         for-loop range, to avoid compiler warnings.
6353
6354         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6355         avoid compiler warnings about unused variables.
6356
6357         * NEWS: Mention end of support for native debugging on MS-Windows
6358         before XP.
6359
6360         PR gdb/24292
6361         * common/netstuff.c:
6362         * gdbserver/gdbreplay.c
6363         * gdbserver/remote-utils.c:
6364         * ser-tcp.c:
6365         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6366         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6367         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6368         'getaddrinfo' and 'freeaddrinfo' were not available before
6369         Windows XP, and mingw.org's MinGW headers by default define
6370         _WIN32_WINNT to 0x500.
6371
6372 2019-03-01  Gary Benson <gbenson@redhat.com>
6373
6374         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6375
6376 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6377             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6378
6379         PR gdb/8527
6380         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6381         set_sigint_trap, clear_sigint_trap.
6382
6383 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6384
6385         * target.c (target_detach): Clear the regcache and the
6386         frame cache.
6387
6388 2019-02-27  Pedro Alves  <palves@redhat.com>
6389
6390         * utils.c (set_screen_size): When we cap the height/width sizes,
6391         tweak the corresponding command variable to show "unlimited":
6392
6393 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6394             Pedro Alves  <palves@redhat.com>
6395
6396         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6397         before calling rl_set_screen_size.
6398
6399 2019-02-27  Tom Tromey  <tromey@adacore.com>
6400
6401         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6402         define.
6403         * python/py-value.c: Remove Python 2.4 workaround.
6404         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6405         workaround.
6406         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6407         Python 2.4 workaround.
6408         * python/python-internal.h: Remove Python 2.4 comment.
6409         (Py_ssize_t): Don't define.
6410         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6411         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6412         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6413         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6414         * python/python.c (do_start_initialization): Remove Python 2.4
6415         workaround.
6416         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6417         (print_children): Remove Python 2.4 workaround.
6418         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6419         workaround.
6420         (CHARBUFFERPROC_NAME): Remove.
6421         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6422         Python 2.4 workaround.
6423
6424 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6425
6426         * NEWS: Note minimum Python version.
6427
6428 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6429
6430         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6431         code from these functions.  Remove corresponding ifdefs.  Use
6432         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6433         Remove gotos and target of gotos.
6434         (infpy_search_memory): Likewise.
6435
6436 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6437
6438         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6439         (hppa_gdbarch_init): Don't register deleted functions with
6440         gdbarch.
6441
6442 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6443
6444         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6445         (h8300_unwind_sp): Delete.
6446         (h8300_dummy_id): Delete.
6447         (h8300_gdbarch_init): Don't register deleted functions with
6448         gdbarch.
6449
6450 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6451
6452         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6453         (ft32_unwind_pc): Delete.
6454         (ft32_unwind_sp): Delete.
6455         (ft32_gdbarch_init): Don't register deleted functions with
6456         gdbarch.
6457
6458 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6459
6460         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6461         (frv_unwind_pc): Delete.
6462         (frv_unwind_sp): Delete.
6463         (frv_gdbarch_init): Don't register deleted functions with
6464         gdbarch.
6465
6466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6467
6468         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6469         (riscv_unwind_pc): Delete.
6470         (riscv_unwind_sp): Delete.
6471         (riscv_gdbarch_init): Don't register deleted functions with
6472         gdbarch.
6473
6474 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6475
6476         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6477         (csky_unwind_pc): Delete.
6478         (csky_unwind_sp): Delete.
6479         (csky_gdbarch_init): Don't register deleted functions with
6480         gdbarch.
6481
6482 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6483
6484         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6485         (cris_unwind_pc): Delete.
6486         (cris_unwind_sp): Delete.
6487         (cris_gdbarch_init): Don't register deleted functions with
6488         gdbarch.
6489
6490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6491
6492         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6493         (bfin_unwind_pc): Delete.
6494         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6495
6496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6497
6498         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6499         (arm_unwind_pc): Delete.
6500         (arm_unwind_sp): Delete.
6501         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6502
6503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6504
6505         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6506         (arc_unwind_pc): Delete.
6507         (arc_unwind_sp): Delete.
6508         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6509
6510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6511
6512         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6513         (alpha_unwind_pc): Delete.
6514         (alpha_gdbarch_init): Don't register deleted functions with
6515         gdbarch.
6516
6517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6518
6519         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6520         (aarch64_unwind_pc): Delete.
6521         (aarch64_unwind_sp): Delete.
6522         (aarch64_gdbarch_init): Don't register deleted functions with
6523         gdbarch.
6524
6525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6526
6527         * gdbtypes.c (type_align): Don't consider static members when
6528         computing structure alignment.
6529
6530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6531
6532         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6533         return 0 for other types.
6534         * arch-utils.c (default_type_align): Always return 0.
6535         * gdbarch.h: Regenerate.
6536         * gdbarch.sh (type_align): Extend comment.
6537         * gdbtypes.c (type_align): Add additional comments, always call
6538         gdbarch_type_align before applying the default rules.
6539         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6540         generic code will then apply a suitable default.
6541         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6542         types, return 0 for other types.
6543
6544 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6545
6546         * NEWS: Create a new section for the next release branch.
6547         Rename the section of the current branch, now that it has
6548         been cut.
6549
6550 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6551
6552         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6553         * version.in: Bump version to 8.3.50.DATE-git.
6554
6555 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6556
6557         * aix-thread.c (ptid_cmp): Remove unused variable.
6558         (get_signaled_thread): Likewise.
6559         (store_regs_user_thread): Likewise.
6560         (store_regs_kernel_thread): Likewise.
6561         (fetch_regs_kernel_thread): Remove shadowed variable.
6562
6563 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6564
6565         * features/riscv/32bit-cpu.xml: Add register numbers.
6566         * features/riscv/32bit-fpu.c: Regenerate.
6567         * features/riscv/32bit-fpu.xml: Add register numbers.
6568         * features/riscv/64bit-cpu.xml: Add register numbers.
6569         * features/riscv/64bit-fpu.c: Regenerate.
6570         * features/riscv/64bit-fpu.xml: Add register numbers.
6571
6572 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6573
6574         * NEWS: Mention two argument form of gdb.Value constructor.
6575         * python/py-value.c (convert_buffer_and_type_to_value): New
6576         function.
6577         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6578         Add support for handling an optional second argument.  Call
6579         convert_buffer_and_type_to_value as appropriate.
6580         * python/python-internal.h (Py_buffer_deleter): New struct.
6581         (Py_buffer_up): New typedef.
6582
6583 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6584
6585         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6586         instead of releasing ownership.
6587
6588 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6589
6590         * dwarf2read.c (open_and_init_dwp_file): Call
6591         elf_numsections instead of bfd_count_sections to initialize
6592         dwp_file->num_sections.
6593
6594 2019-02-25  Tom Tromey  <tromey@adacore.com>
6595
6596         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6597
6598 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6599
6600         * gcore.in: Add '--readnever' option when invoking GDB.
6601
6602 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6603
6604         * MAINTAINERS: Update my email address.
6605
6606 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6607
6608         * build-id.c (build_id_to_debug_bfd_1): New function.
6609         (build_id_to_debug_bfd): Look for separate debug file in
6610         sysroot.
6611
6612 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6613
6614         * gdbarch.sh: Update the copyright year range that is placed into
6615         generated files.
6616
6617 2019-02-22  Keith Seitz  <keiths@redhat.com>
6618
6619         PR symtab/23853
6620         * linespec.c (create_sals_line_offset): Search for the default
6621         symtab's filename instead of its fullname.
6622
6623 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6624
6625         * NEWS: Update style defaults.
6626
6627 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6628
6629         * main.c (captured_main_1): Disable styling in batch mode.
6630
6631 2019-02-20  Tom Tromey  <tom@tromey.com>
6632
6633         * symtab.c (symtab_symbol_info): Fix typos.
6634
6635 2019-02-20  Tom Tromey  <tromey@adacore.com>
6636
6637         * findcmd.c (_initialize_mem_search): Use upper case for
6638         metasyntactic variables.
6639
6640 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6641
6642         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6643         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6644
6645 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6646
6647         * top.h (source_file_name): Change to std::string.
6648         * top.c (source_file_name): Likewise.
6649         (command_line_input): Adjust.
6650         * cli/cli-script.c (script_from_file): Adjust.
6651
6652 2019-02-19  Tom Tromey  <tromey@adacore.com>
6653
6654         * ravenscar-thread.c
6655         (ravenscar_thread_target::update_thread_list): Don't call
6656         ada_build_task_list.
6657         * ada-lang.h (ada_build_task_list): Don't declare.
6658         * ada-tasks.c (struct ada_tasks_inferior_data)
6659         <task_list_valid_p>: Now bool.
6660         (read_known_tasks, ada_task_list_changed)
6661         (ada_tasks_invalidate_inferior_data): Update.
6662         (read_known_tasks_array): Return bool.
6663         (read_known_tasks_list): Likewise.
6664         (read_known_tasks): Return void.
6665         (ada_build_task_list): Now static.
6666
6667 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6668
6669         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6670         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6671
6672 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6673
6674         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6675         variant for ada_tasks_pspace_data_handle and
6676         ada_tasks_inferior_data_handle.
6677         (ada_tasks_pspace_data_cleanup): New function.
6678         (ada_tasks_inferior_data_cleanup): New function.
6679
6680 2019-02-17  Tom Tromey  <tom@tromey.com>
6681
6682         * macrotab.h (macro_source_fullname): Return a std::string.
6683         * macrotab.c (macro_include, check_for_redefinition)
6684         (macro_undef, macro_lookup_definition, foreach_macro)
6685         (foreach_macro_in_scope): Update.
6686         (macro_source_fullname): Return a std::string.
6687         * macrocmd.c (show_pp_source_pos): Update.
6688
6689 2019-02-17  Tom Tromey  <tom@tromey.com>
6690
6691         * macrocmd.c (show_pp_source_pos): Style the file names.
6692
6693 2019-02-17  Tom Tromey  <tom@tromey.com>
6694
6695         PR tui/24197:
6696         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6697
6698 2019-02-17  Tom Tromey  <tom@tromey.com>
6699
6700         * ada-lang.c (user_select_syms): Use filtered printing.
6701         * utils.c (wrap_style): New global.
6702         (desired_style): Remove.
6703         (emit_style_escape): Add stream parameter.
6704         (set_output_style, reset_terminal_style, prompt_for_continue):
6705         Update.
6706         (flush_wrap_buffer): Only flush gdb_stdout.
6707         (wrap_here): Set wrap_style.
6708         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6709         treat escape sequences as a character.  Change when wrap buffer is
6710         flushed.
6711         (fputs_styled): Do not set the output style when the default is
6712         requested.
6713         * ui-style.h (struct ui_file_style) <is_default>: New method.
6714         * source.c (print_source_lines_base): Emit escape sequences in one
6715         piece.
6716
6717 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6718
6719         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6720         integers and enumeration types.
6721
6722 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6723
6724         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6725         instead of lookup_symbol_in_language
6726         (do_exact_match): New function.
6727         (ada_get_symbol_name_matcher): Return do_exact_match when
6728         doing a verbatim match.
6729
6730 2019-02-15  Tom Tromey  <tromey@adacore.com>
6731
6732         * ravenscar-thread.c (ravenscar_thread_target::resume)
6733         (ravenscar_thread_target::wait): Special case wildcard requests.
6734
6735 2019-02-15  Tom Tromey  <tromey@adacore.com>
6736
6737         * ravenscar-thread.c (base_ptid): Remove.
6738         (struct ravenscar_thread_target) <close>: New method.
6739         <m_base_ptid>: New member.
6740         <update_inferior_ptid, active_task, task_is_currently_active,
6741         runtime_initialized>: Declare methods.
6742         <ravenscar_thread_target>: Add constructor.
6743         (ravenscar_thread_target::task_is_currently_active)
6744         (ravenscar_thread_target::update_inferior_ptid)
6745         (ravenscar_runtime_initialized): Rename.  Now methods.
6746         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6747         (ravenscar_thread_target::update_thread_list): Update.
6748         (ravenscar_thread_target::active_task): Now method.
6749         (ravenscar_thread_target::store_registers)
6750         (ravenscar_thread_target::prepare_to_store)
6751         (ravenscar_thread_target::prepare_to_store)
6752         (ravenscar_thread_target::mourn_inferior): Update.
6753         (ravenscar_inferior_created): Use "new" to create target.
6754         (ravenscar_thread_target::get_ada_task_ptid): Update.
6755         (_initialize_ravenscar): Don't initialize base_ptid.
6756         (ravenscar_ops): Remove global.
6757
6758 2019-02-15  Tom Tromey  <tromey@adacore.com>
6759
6760         * target.h (push_target): Declare new overload.
6761         * target.c (push_target): New overload, taking an rvalue reference.
6762         * remote.c (remote_target::open_1): Use push_target overload.
6763         * corelow.c (core_target_open): Use push_target overload.
6764
6765 2019-02-15  Tom Tromey  <tromey@adacore.com>
6766
6767         * ravenscar-thread.c (is_ravenscar_task)
6768         (ravenscar_task_is_currently_active): Return bool.
6769         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6770         (_initialize_ravenscar): Remove "(void)".
6771         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6772         Return bool.
6773
6774 2019-02-15  Tom Tromey  <tromey@adacore.com>
6775
6776         * ravenscar-thread.c (ravenscar_runtime_initializer)
6777         (has_ravenscar_runtime, get_running_thread_id)
6778         (ravenscar_thread_target::resume): Fix indentation.
6779
6780 2019-02-15  Tom Tromey  <tromey@adacore.com>
6781
6782         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6783         from ravenscar_arch_ops.
6784         (sparc_ravenscar_ops::fetch_registers)
6785         (sparc_ravenscar_ops::store_registers): Now methods.
6786         (sparc_ravenscar_prepare_to_store): Remove.
6787         (sparc_ravenscar_ops): Redefine.
6788         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6789         methods and destructor.  Remove members.
6790         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6791         (ravenscar_thread_target::store_registers)
6792         (ravenscar_thread_target::prepare_to_store): Update.
6793         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6794         Remove.
6795         (struct ppc_ravenscar_powerpc_ops): Derive from
6796         ravenscar_arch_ops.
6797         (ppc_ravenscar_powerpc_ops::fetch_registers)
6798         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6799         (ppc_ravenscar_powerpc_ops): Redefine.
6800         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6801         (ppc_ravenscar_e500_ops::fetch_registers)
6802         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6803         (ppc_ravenscar_e500_ops): Redefine.
6804         * aarch64-ravenscar-thread.c
6805         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6806         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6807         (aarch64_ravenscar_fetch_registers)
6808         (aarch64_ravenscar_store_registers): Now methods.
6809         (aarch64_ravenscar_ops): Redefine.
6810
6811 2019-02-15  Tom Tromey  <tromey@adacore.com>
6812
6813         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6814         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6815         (ravenscar_thread_target::stopped_by_watchpoint)
6816         (ravenscar_thread_target::stopped_data_address)
6817         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6818
6819 2019-02-15  Tom Tromey  <tromey@adacore.com>
6820
6821         * ravenscar-thread.c: Fix some typos.
6822
6823 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6824             Tom Tromey  <tromey@adacore.com>
6825
6826         * ada-lang.c (ada_exception_sal): Change addr_string to a
6827         std::string.
6828         (create_ada_exception_catchpoint): Update.
6829
6830 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6831             Tom Tromey  <tromey@adacore.com>
6832
6833         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6834         (bp_location_ops): Remove.
6835         (base_breakpoint_allocate_location): Update.
6836         (free_bp_location): Update.
6837         * ada-lang.c (class ada_catchpoint_location)
6838         <ada_catchpoint_location>: Remove ops parameter.
6839         (ada_catchpoint_location_dtor): Remove.
6840         (ada_catchpoint_location_ops): Remove.
6841         (allocate_location_exception): Update.
6842         * breakpoint.h (struct bp_location_ops): Remove.
6843         (class bp_location) <bp_location>: Remove bp_location_ops
6844         parameter.
6845         <~bp_location>: Add destructor.
6846         <ops>: Remove.
6847
6848 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6849             Pedro Alves  <palves@redhat.com>
6850
6851         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6852         'PATH_MAX'.
6853
6854 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6855             Samuel Thibault  <samuel.thibault@gnu.org>
6856             Thomas Schwinge  <thomas@codesourcery.com>
6857
6858         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6859         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6860
6861 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6862
6863         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6864         (check_empty): Use "const char *".
6865
6866         * gnu-nat.c (gnu_nat_target::detach): Instead of
6867         'detach_inferior (pid)' call
6868         'detach_inferior (find_inferior_pid (pid))'.
6869
6870         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6871         'nat/fork-inferior.o'.
6872         * gnu-nat.c: #include "nat/fork-inferior.h".
6873
6874         * gnu-nat.c (gnu_nat_target::detach): Instead of
6875         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6876         * gnu-nat.h: #include "inf-child.h".
6877         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6878         'i386_gnu_nat_target::fetch_registers'.
6879         (gnu_store_registers): Rename/move to
6880         'i386_gnu_nat_target::store_registers'.
6881
6882         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6883         * gnu-nat.h (mach_thread_info): New function.
6884         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6885
6886         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6887
6888 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6889
6890         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6891
6892 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6893
6894         * windows-nat.c (windows_add_thread): Add new parameter
6895         "main_thread_p" with default value set to false.  Update
6896         function documentation as well as all callers.
6897         (windows_delete_thread): Likewise.
6898         (fake_create_process): Update call to windows_add_thread.
6899         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6900         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6901         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6902         call to windows_delete_thread.
6903
6904 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6905
6906         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6907
6908 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6909
6910         * symfile.c (find_separate_debug_file): Use canonical path of
6911         sysroot with child_path instead of gdb_sysroot if it is valid.
6912
6913 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6914
6915         * symfile.c (find_separate_debug_file): Use child_path to
6916         determine if an object file is under a sysroot.
6917
6918 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6919
6920         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6921         unittests/child-path-selftests.c.
6922         * common/pathstuff.c (child_path): New function.
6923         * common/pathstuff.h (child_path): New prototype.
6924         * unittests/child-path-selftests.c: New file.
6925
6926 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6927
6928         * symfile.c (find_separate_debug_file): Look for separate debug
6929         files in debug directories under the sysroot.
6930
6931 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6932
6933         * symtab.h (struct minimal_symbol data_p): New const method.
6934         (struct minimal_symbol text_p): Likewise.
6935         * symtab.c (output_source_filename): Use file name style
6936         to print file name.
6937         (print_symbol_info): Likewise.
6938         (print_msymbol_info): Use address style to print addresses.
6939         Use function name style to print executable text symbols.
6940         (expand_symtab_containing_pc): Use data_p.
6941         (find_pc_sect_compunit_symtab): Likewise.
6942
6943 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6944
6945         * breakpoint.c (describe_other_breakpoints): Use address style
6946         to print addresses.
6947         (say_where): Likewise.
6948
6949 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6950
6951         * ada-typeprint.c (print_func_type): Print function name
6952         style to print function name.
6953         * c-typeprint.c (c_print_type_1): Likewise.
6954
6955 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6956
6957         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6958         for execve.
6959
6960 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6961
6962         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6963         type_stack.
6964
6965 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6966
6967         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6968         TYPE_CODE_REF types.
6969
6970 2019-02-08  Jim Wilson  <jimw@sifive.com>
6971
6972         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6973         (riscv_linux_fregset): New.
6974         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6975
6976 2019-02-07  Tom Tromey  <tom@tromey.com>
6977
6978         * thread.c (thread_cancel_execution_command): Update.
6979         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6980         methods.
6981         (struct thread_fsm_ops): Remove.
6982         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6983         (thread_fsm_should_stop, thread_fsm_return_value)
6984         (thread_fsm_set_finished, thread_fsm_finished_p)
6985         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6986         Don't declare.
6987         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6988         * infrun.c (clear_proceed_status_thread)
6989         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6990         (print_stop_event): Update.
6991         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6992         Add constructor.
6993         (step_command_fsm_ops): Remove.
6994         (new_step_command_fsm): Remove.
6995         (step_1): Update.
6996         (step_command_fsm::should_stop): Rename from
6997         step_command_fsm_should_stop.
6998         (step_command_fsm::clean_up): Rename from
6999         step_command_fsm_clean_up.
7000         (step_command_fsm::do_async_reply_reason): Rename from
7001         step_command_fsm_async_reply_reason.
7002         (struct until_next_fsm): Inherit from thread_fsm.  Add
7003         constructor.
7004         (until_next_fsm_ops): Remove.
7005         (new_until_next_fsm): Remove.
7006         (until_next_fsm::should_stop): Rename from
7007         until_next_fsm_should_stop.
7008         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7009         (until_next_fsm::do_async_reply_reason): Rename from
7010         until_next_fsm_async_reply_reason.
7011         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7012         constructor.  Change type of breakpoint.
7013         (finish_command_fsm_ops): Remove.
7014         (new_finish_command_fsm): Remove.
7015         (finish_command_fsm::should_stop): Rename from
7016         finish_command_fsm_should_stop.
7017         (finish_command_fsm::clean_up): Rename from
7018         finish_command_fsm_clean_up.
7019         (finish_command_fsm::return_value): Rename from
7020         finish_command_fsm_return_value.
7021         (finish_command_fsm::do_async_reply_reason): Rename from
7022         finish_command_fsm_async_reply_reason.
7023         (finish_command): Update.
7024         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7025         Add constructor.
7026         (call_thread_fsm_ops): Remove.
7027         (call_thread_fsm::call_thread_fsm): Rename from
7028         new_call_thread_fsm.
7029         (call_thread_fsm::should_stop): Rename from
7030         call_thread_fsm_should_stop.
7031         (call_thread_fsm::should_notify_stop): Rename from
7032         call_thread_fsm_should_notify_stop.
7033         (run_inferior_call, call_function_by_hand_dummy): Update.
7034         * cli/cli-interp.c (should_print_stop_to_console): Update.
7035         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7036         Add constructor.  Change type of location_breakpoint,
7037         caller_breakpoint.
7038         (until_break_fsm_ops): Remove.
7039         (new_until_break_fsm): Remove.
7040         (until_break_fsm::should_stop): Rename from
7041         until_break_fsm_should_stop.
7042         (until_break_fsm::clean_up): Rename from
7043         until_break_fsm_clean_up.
7044         (until_break_fsm::do_async_reply_reason): Rename from
7045         until_break_fsm_async_reply_reason.
7046         (until_break_command): Update.
7047         * thread-fsm.c: Remove.
7048         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7049
7050 2019-02-07  Tom Tromey  <tom@tromey.com>
7051
7052         * yy-remap.h: Add include guard.
7053         * xtensa-tdep.h: Add include guard.
7054         * xcoffread.h: Rename include guard.
7055         * varobj-iter.h: Add include guard.
7056         * tui/tui.h: Rename include guard.
7057         * tui/tui-winsource.h: Rename include guard.
7058         * tui/tui-wingeneral.h: Rename include guard.
7059         * tui/tui-windata.h: Rename include guard.
7060         * tui/tui-win.h: Rename include guard.
7061         * tui/tui-stack.h: Rename include guard.
7062         * tui/tui-source.h: Rename include guard.
7063         * tui/tui-regs.h: Rename include guard.
7064         * tui/tui-out.h: Rename include guard.
7065         * tui/tui-layout.h: Rename include guard.
7066         * tui/tui-io.h: Rename include guard.
7067         * tui/tui-hooks.h: Rename include guard.
7068         * tui/tui-file.h: Rename include guard.
7069         * tui/tui-disasm.h: Rename include guard.
7070         * tui/tui-data.h: Rename include guard.
7071         * tui/tui-command.h: Rename include guard.
7072         * tic6x-tdep.h: Add include guard.
7073         * target/waitstatus.h: Rename include guard.
7074         * target/wait.h: Rename include guard.
7075         * target/target.h: Rename include guard.
7076         * target/resume.h: Rename include guard.
7077         * target-float.h: Rename include guard.
7078         * stabsread.h: Add include guard.
7079         * rs6000-tdep.h: Add include guard.
7080         * riscv-fbsd-tdep.h: Add include guard.
7081         * regformats/regdef.h: Rename include guard.
7082         * record.h: Rename include guard.
7083         * python/python.h: Rename include guard.
7084         * python/python-internal.h: Rename include guard.
7085         * python/py-stopevent.h: Rename include guard.
7086         * python/py-ref.h: Rename include guard.
7087         * python/py-record.h: Rename include guard.
7088         * python/py-record-full.h: Rename include guard.
7089         * python/py-record-btrace.h: Rename include guard.
7090         * python/py-instruction.h: Rename include guard.
7091         * python/py-events.h: Rename include guard.
7092         * python/py-event.h: Rename include guard.
7093         * procfs.h: Add include guard.
7094         * proc-utils.h: Add include guard.
7095         * p-lang.h: Add include guard.
7096         * or1k-tdep.h: Rename include guard.
7097         * observable.h: Rename include guard.
7098         * nto-tdep.h: Rename include guard.
7099         * nat/x86-linux.h: Rename include guard.
7100         * nat/x86-linux-dregs.h: Rename include guard.
7101         * nat/x86-gcc-cpuid.h: Add include guard.
7102         * nat/x86-dregs.h: Rename include guard.
7103         * nat/x86-cpuid.h: Rename include guard.
7104         * nat/ppc-linux.h: Rename include guard.
7105         * nat/mips-linux-watch.h: Rename include guard.
7106         * nat/linux-waitpid.h: Rename include guard.
7107         * nat/linux-ptrace.h: Rename include guard.
7108         * nat/linux-procfs.h: Rename include guard.
7109         * nat/linux-osdata.h: Rename include guard.
7110         * nat/linux-nat.h: Rename include guard.
7111         * nat/linux-namespaces.h: Rename include guard.
7112         * nat/linux-btrace.h: Rename include guard.
7113         * nat/glibc_thread_db.h: Rename include guard.
7114         * nat/gdb_thread_db.h: Rename include guard.
7115         * nat/gdb_ptrace.h: Rename include guard.
7116         * nat/fork-inferior.h: Rename include guard.
7117         * nat/amd64-linux-siginfo.h: Rename include guard.
7118         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7119         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7120         * nat/aarch64-linux.h: Rename include guard.
7121         * nat/aarch64-linux-hw-point.h: Rename include guard.
7122         * mn10300-tdep.h: Add include guard.
7123         * mips-linux-tdep.h: Add include guard.
7124         * mi/mi-parse.h: Rename include guard.
7125         * mi/mi-out.h: Rename include guard.
7126         * mi/mi-main.h: Rename include guard.
7127         * mi/mi-interp.h: Rename include guard.
7128         * mi/mi-getopt.h: Rename include guard.
7129         * mi/mi-console.h: Rename include guard.
7130         * mi/mi-common.h: Rename include guard.
7131         * mi/mi-cmds.h: Rename include guard.
7132         * mi/mi-cmd-break.h: Rename include guard.
7133         * m2-lang.h: Add include guard.
7134         * location.h: Rename include guard.
7135         * linux-record.h: Rename include guard.
7136         * linux-nat.h: Add include guard.
7137         * linux-fork.h: Add include guard.
7138         * i386-darwin-tdep.h: Rename include guard.
7139         * hppa-linux-offsets.h: Add include guard.
7140         * guile/guile.h: Rename include guard.
7141         * guile/guile-internal.h: Rename include guard.
7142         * gnu-nat.h: Rename include guard.
7143         * gdb-stabs.h: Rename include guard.
7144         * frv-tdep.h: Add include guard.
7145         * f-lang.h: Add include guard.
7146         * event-loop.h: Add include guard.
7147         * darwin-nat.h: Rename include guard.
7148         * cp-abi.h: Rename include guard.
7149         * config/sparc/nm-sol2.h: Rename include guard.
7150         * config/nm-nto.h: Rename include guard.
7151         * config/nm-linux.h: Add include guard.
7152         * config/i386/nm-i386gnu.h: Rename include guard.
7153         * config/djgpp/nl_types.h: Rename include guard.
7154         * config/djgpp/langinfo.h: Rename include guard.
7155         * compile/gcc-cp-plugin.h: Add include guard.
7156         * compile/gcc-c-plugin.h: Add include guard.
7157         * compile/compile.h: Rename include guard.
7158         * compile/compile-object-run.h: Rename include guard.
7159         * compile/compile-object-load.h: Rename include guard.
7160         * compile/compile-internal.h: Rename include guard.
7161         * compile/compile-cplus.h: Rename include guard.
7162         * compile/compile-c.h: Rename include guard.
7163         * common/xml-utils.h: Rename include guard.
7164         * common/x86-xstate.h: Rename include guard.
7165         * common/version.h: Rename include guard.
7166         * common/vec.h: Rename include guard.
7167         * common/tdesc.h: Rename include guard.
7168         * common/selftest.h: Rename include guard.
7169         * common/scoped_restore.h: Rename include guard.
7170         * common/scoped_mmap.h: Rename include guard.
7171         * common/scoped_fd.h: Rename include guard.
7172         * common/safe-iterator.h: Rename include guard.
7173         * common/run-time-clock.h: Rename include guard.
7174         * common/refcounted-object.h: Rename include guard.
7175         * common/queue.h: Rename include guard.
7176         * common/ptid.h: Rename include guard.
7177         * common/print-utils.h: Rename include guard.
7178         * common/preprocessor.h: Rename include guard.
7179         * common/pathstuff.h: Rename include guard.
7180         * common/observable.h: Rename include guard.
7181         * common/netstuff.h: Rename include guard.
7182         * common/job-control.h: Rename include guard.
7183         * common/host-defs.h: Rename include guard.
7184         * common/gdb_wait.h: Rename include guard.
7185         * common/gdb_vecs.h: Rename include guard.
7186         * common/gdb_unlinker.h: Rename include guard.
7187         * common/gdb_unique_ptr.h: Rename include guard.
7188         * common/gdb_tilde_expand.h: Rename include guard.
7189         * common/gdb_sys_time.h: Rename include guard.
7190         * common/gdb_string_view.h: Rename include guard.
7191         * common/gdb_splay_tree.h: Rename include guard.
7192         * common/gdb_setjmp.h: Rename include guard.
7193         * common/gdb_ref_ptr.h: Rename include guard.
7194         * common/gdb_optional.h: Rename include guard.
7195         * common/gdb_locale.h: Rename include guard.
7196         * common/gdb_assert.h: Rename include guard.
7197         * common/filtered-iterator.h: Rename include guard.
7198         * common/filestuff.h: Rename include guard.
7199         * common/fileio.h: Rename include guard.
7200         * common/environ.h: Rename include guard.
7201         * common/common-utils.h: Rename include guard.
7202         * common/common-types.h: Rename include guard.
7203         * common/common-regcache.h: Rename include guard.
7204         * common/common-inferior.h: Rename include guard.
7205         * common/common-gdbthread.h: Rename include guard.
7206         * common/common-exceptions.h: Rename include guard.
7207         * common/common-defs.h: Rename include guard.
7208         * common/common-debug.h: Rename include guard.
7209         * common/cleanups.h: Rename include guard.
7210         * common/buffer.h: Rename include guard.
7211         * common/btrace-common.h: Rename include guard.
7212         * common/break-common.h: Rename include guard.
7213         * cli/cli-utils.h: Rename include guard.
7214         * cli/cli-style.h: Rename include guard.
7215         * cli/cli-setshow.h: Rename include guard.
7216         * cli/cli-script.h: Rename include guard.
7217         * cli/cli-interp.h: Rename include guard.
7218         * cli/cli-decode.h: Rename include guard.
7219         * cli/cli-cmds.h: Rename include guard.
7220         * charset-list.h: Add include guard.
7221         * buildsym-legacy.h: Rename include guard.
7222         * bfin-tdep.h: Add include guard.
7223         * ax.h: Rename include guard.
7224         * arm-linux-tdep.h: Add include guard.
7225         * arm-fbsd-tdep.h: Add include guard.
7226         * arch/xtensa.h: Rename include guard.
7227         * arch/tic6x.h: Add include guard.
7228         * arch/i386.h: Add include guard.
7229         * arch/arm.h: Rename include guard.
7230         * arch/arm-linux.h: Rename include guard.
7231         * arch/arm-get-next-pcs.h: Rename include guard.
7232         * arch/amd64.h: Add include guard.
7233         * arch/aarch64-insn.h: Rename include guard.
7234         * arch-utils.h: Rename include guard.
7235         * annotate.h: Add include guard.
7236         * amd64-darwin-tdep.h: Rename include guard.
7237         * aarch64-linux-tdep.h: Add include guard.
7238         * aarch64-fbsd-tdep.h: Add include guard.
7239         * aarch32-linux-nat.h: Add include guard.
7240
7241 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7242
7243         * macrotab.c (macro_define_internal): New function that
7244         factorizes macro_define_object_internal and macro_define_function
7245         code.
7246         (macro_define_object_internal): Use macro_define_internal.
7247         (macro_define_function): Likewise.
7248
7249 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7250
7251         * macrocmd.c (extract_identifier): Return
7252         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7253         callers.
7254
7255 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7256
7257         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7258
7259 2019-02-05  Tom Tromey  <tom@tromey.com>
7260
7261         * target.c (target_stack::unpush): Move assertion earlier.
7262
7263 2019-01-30  Tom Tromey  <tom@tromey.com>
7264
7265         PR python/23615:
7266         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7267         (gdbpy_parse_and_eval): Likewise.
7268         * python/python-internal.h (gdbpy_allow_threads): New class.
7269
7270 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7271
7272         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7273         (aarch64_fbsd_fpregmap): Move earlier.
7274         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7275         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7276         instead of individual calls to trad_frame_set_reg_addr.
7277         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7278         earlier.
7279         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7280         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7281         instead of individual calls to trad_frame_set_reg_addr.
7282
7283 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7284
7285         * CONTRIBUTE: Replace contribution list with wiki link.
7286
7287 2019-01-25  Tom Tromey  <tom@tromey.com>
7288
7289         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7290
7291 2019-01-25  Tom Tromey  <tom@tromey.com>
7292
7293         * xtensa-linux-nat.c: Fix common/ includes.
7294         * xml-support.h: Fix common/ includes.
7295         * xml-support.c: Fix common/ includes.
7296         * x86-linux-nat.c: Fix common/ includes.
7297         * windows-nat.c: Fix common/ includes.
7298         * varobj.h: Fix common/ includes.
7299         * varobj.c: Fix common/ includes.
7300         * value.c: Fix common/ includes.
7301         * valops.c: Fix common/ includes.
7302         * utils.c: Fix common/ includes.
7303         * unittests/xml-utils-selftests.c: Fix common/ includes.
7304         * unittests/utils-selftests.c: Fix common/ includes.
7305         * unittests/unpack-selftests.c: Fix common/ includes.
7306         * unittests/tracepoint-selftests.c: Fix common/ includes.
7307         * unittests/style-selftests.c: Fix common/ includes.
7308         * unittests/string_view-selftests.c: Fix common/ includes.
7309         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7310         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7311         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7312         * unittests/rsp-low-selftests.c: Fix common/ includes.
7313         * unittests/parse-connection-spec-selftests.c: Fix common/
7314         includes.
7315         * unittests/optional-selftests.c: Fix common/ includes.
7316         * unittests/offset-type-selftests.c: Fix common/ includes.
7317         * unittests/observable-selftests.c: Fix common/ includes.
7318         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7319         * unittests/memrange-selftests.c: Fix common/ includes.
7320         * unittests/memory-map-selftests.c: Fix common/ includes.
7321         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7322         * unittests/function-view-selftests.c: Fix common/ includes.
7323         * unittests/environ-selftests.c: Fix common/ includes.
7324         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7325         * unittests/common-utils-selftests.c: Fix common/ includes.
7326         * unittests/cli-utils-selftests.c: Fix common/ includes.
7327         * unittests/array-view-selftests.c: Fix common/ includes.
7328         * ui-file.c: Fix common/ includes.
7329         * tui/tui-io.c: Fix common/ includes.
7330         * tracepoint.h: Fix common/ includes.
7331         * tracepoint.c: Fix common/ includes.
7332         * tracefile-tfile.c: Fix common/ includes.
7333         * top.h: Fix common/ includes.
7334         * top.c: Fix common/ includes.
7335         * thread.c: Fix common/ includes.
7336         * target/waitstatus.h: Fix common/ includes.
7337         * target/waitstatus.c: Fix common/ includes.
7338         * target.h: Fix common/ includes.
7339         * target.c: Fix common/ includes.
7340         * target-memory.c: Fix common/ includes.
7341         * target-descriptions.c: Fix common/ includes.
7342         * symtab.h: Fix common/ includes.
7343         * symfile.c: Fix common/ includes.
7344         * stap-probe.c: Fix common/ includes.
7345         * spu-linux-nat.c: Fix common/ includes.
7346         * sparc-nat.c: Fix common/ includes.
7347         * source.c: Fix common/ includes.
7348         * solib.c: Fix common/ includes.
7349         * solib-target.c: Fix common/ includes.
7350         * ser-unix.c: Fix common/ includes.
7351         * ser-tcp.c: Fix common/ includes.
7352         * ser-pipe.c: Fix common/ includes.
7353         * ser-base.c: Fix common/ includes.
7354         * selftest-arch.c: Fix common/ includes.
7355         * s12z-tdep.c: Fix common/ includes.
7356         * rust-exp.y: Fix common/ includes.
7357         * rs6000-aix-tdep.c: Fix common/ includes.
7358         * riscv-tdep.c: Fix common/ includes.
7359         * remote.c: Fix common/ includes.
7360         * remote-notif.h: Fix common/ includes.
7361         * remote-fileio.h: Fix common/ includes.
7362         * remote-fileio.c: Fix common/ includes.
7363         * regcache.h: Fix common/ includes.
7364         * regcache.c: Fix common/ includes.
7365         * record-btrace.c: Fix common/ includes.
7366         * python/python.c: Fix common/ includes.
7367         * python/py-type.c: Fix common/ includes.
7368         * python/py-inferior.c: Fix common/ includes.
7369         * progspace.h: Fix common/ includes.
7370         * producer.c: Fix common/ includes.
7371         * procfs.c: Fix common/ includes.
7372         * proc-api.c: Fix common/ includes.
7373         * printcmd.c: Fix common/ includes.
7374         * ppc-linux-nat.c: Fix common/ includes.
7375         * parser-defs.h: Fix common/ includes.
7376         * osdata.c: Fix common/ includes.
7377         * obsd-nat.c: Fix common/ includes.
7378         * nat/x86-linux.c: Fix common/ includes.
7379         * nat/x86-linux-dregs.c: Fix common/ includes.
7380         * nat/x86-dregs.h: Fix common/ includes.
7381         * nat/x86-dregs.c: Fix common/ includes.
7382         * nat/ppc-linux.c: Fix common/ includes.
7383         * nat/mips-linux-watch.h: Fix common/ includes.
7384         * nat/mips-linux-watch.c: Fix common/ includes.
7385         * nat/linux-waitpid.c: Fix common/ includes.
7386         * nat/linux-ptrace.h: Fix common/ includes.
7387         * nat/linux-ptrace.c: Fix common/ includes.
7388         * nat/linux-procfs.c: Fix common/ includes.
7389         * nat/linux-personality.c: Fix common/ includes.
7390         * nat/linux-osdata.c: Fix common/ includes.
7391         * nat/linux-namespaces.c: Fix common/ includes.
7392         * nat/linux-btrace.h: Fix common/ includes.
7393         * nat/linux-btrace.c: Fix common/ includes.
7394         * nat/fork-inferior.c: Fix common/ includes.
7395         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7396         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7397         * nat/aarch64-linux.c: Fix common/ includes.
7398         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7399         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7400         * namespace.h: Fix common/ includes.
7401         * mips-linux-tdep.c: Fix common/ includes.
7402         * minsyms.c: Fix common/ includes.
7403         * mi/mi-parse.h: Fix common/ includes.
7404         * mi/mi-main.c: Fix common/ includes.
7405         * mi/mi-cmd-env.c: Fix common/ includes.
7406         * memrange.h: Fix common/ includes.
7407         * memattr.c: Fix common/ includes.
7408         * maint.h: Fix common/ includes.
7409         * maint.c: Fix common/ includes.
7410         * main.c: Fix common/ includes.
7411         * machoread.c: Fix common/ includes.
7412         * location.c: Fix common/ includes.
7413         * linux-thread-db.c: Fix common/ includes.
7414         * linux-nat.c: Fix common/ includes.
7415         * linux-fork.c: Fix common/ includes.
7416         * inline-frame.c: Fix common/ includes.
7417         * infrun.c: Fix common/ includes.
7418         * inflow.c: Fix common/ includes.
7419         * inferior.h: Fix common/ includes.
7420         * inferior.c: Fix common/ includes.
7421         * infcmd.c: Fix common/ includes.
7422         * inf-ptrace.c: Fix common/ includes.
7423         * inf-child.c: Fix common/ includes.
7424         * ia64-linux-nat.c: Fix common/ includes.
7425         * i387-tdep.c: Fix common/ includes.
7426         * i386-tdep.c: Fix common/ includes.
7427         * i386-linux-tdep.c: Fix common/ includes.
7428         * i386-linux-nat.c: Fix common/ includes.
7429         * i386-go32-tdep.c: Fix common/ includes.
7430         * i386-fbsd-tdep.c: Fix common/ includes.
7431         * i386-fbsd-nat.c: Fix common/ includes.
7432         * guile/scm-type.c: Fix common/ includes.
7433         * guile/guile.c: Fix common/ includes.
7434         * go32-nat.c: Fix common/ includes.
7435         * gnu-nat.c: Fix common/ includes.
7436         * gdbthread.h: Fix common/ includes.
7437         * gdbarch-selftests.c: Fix common/ includes.
7438         * gdb_usleep.c: Fix common/ includes.
7439         * gdb_select.h: Fix common/ includes.
7440         * gdb_bfd.c: Fix common/ includes.
7441         * gcore.c: Fix common/ includes.
7442         * fork-child.c: Fix common/ includes.
7443         * findvar.c: Fix common/ includes.
7444         * fbsd-nat.c: Fix common/ includes.
7445         * event-top.c: Fix common/ includes.
7446         * event-loop.c: Fix common/ includes.
7447         * dwarf2read.c: Fix common/ includes.
7448         * dwarf2loc.c: Fix common/ includes.
7449         * dwarf2-frame.c: Fix common/ includes.
7450         * dwarf-index-cache.c: Fix common/ includes.
7451         * dtrace-probe.c: Fix common/ includes.
7452         * disasm-selftests.c: Fix common/ includes.
7453         * defs.h: Fix common/ includes.
7454         * csky-tdep.c: Fix common/ includes.
7455         * cp-valprint.c: Fix common/ includes.
7456         * cp-support.h: Fix common/ includes.
7457         * cp-support.c: Fix common/ includes.
7458         * corelow.c: Fix common/ includes.
7459         * completer.h: Fix common/ includes.
7460         * completer.c: Fix common/ includes.
7461         * compile/compile.c: Fix common/ includes.
7462         * compile/compile-loc2c.c: Fix common/ includes.
7463         * compile/compile-cplus-types.c: Fix common/ includes.
7464         * compile/compile-cplus-symbols.c: Fix common/ includes.
7465         * command.h: Fix common/ includes.
7466         * cli/cli-dump.c: Fix common/ includes.
7467         * cli/cli-cmds.c: Fix common/ includes.
7468         * charset.c: Fix common/ includes.
7469         * build-id.c: Fix common/ includes.
7470         * btrace.h: Fix common/ includes.
7471         * btrace.c: Fix common/ includes.
7472         * breakpoint.h: Fix common/ includes.
7473         * breakpoint.c: Fix common/ includes.
7474         * ax.h:
7475         (enum agent_op): Fix common/ includes.
7476         * ax-general.c (struct aop_map): Fix common/ includes.
7477         * ax-gdb.c: Fix common/ includes.
7478         * auxv.c: Fix common/ includes.
7479         * auto-load.c: Fix common/ includes.
7480         * arm-tdep.c: Fix common/ includes.
7481         * arch/riscv.c: Fix common/ includes.
7482         * arch/ppc-linux-common.c: Fix common/ includes.
7483         * arch/i386.c: Fix common/ includes.
7484         * arch/arm.c: Fix common/ includes.
7485         * arch/arm-linux.c: Fix common/ includes.
7486         * arch/arm-get-next-pcs.c: Fix common/ includes.
7487         * arch/amd64.c: Fix common/ includes.
7488         * arch/aarch64.c: Fix common/ includes.
7489         * arch/aarch64-insn.c: Fix common/ includes.
7490         * arch-utils.c: Fix common/ includes.
7491         * amd64-windows-tdep.c: Fix common/ includes.
7492         * amd64-tdep.c: Fix common/ includes.
7493         * amd64-sol2-tdep.c: Fix common/ includes.
7494         * amd64-obsd-tdep.c: Fix common/ includes.
7495         * amd64-nbsd-tdep.c: Fix common/ includes.
7496         * amd64-linux-tdep.c: Fix common/ includes.
7497         * amd64-linux-nat.c: Fix common/ includes.
7498         * amd64-fbsd-tdep.c: Fix common/ includes.
7499         * amd64-fbsd-nat.c: Fix common/ includes.
7500         * amd64-dicos-tdep.c: Fix common/ includes.
7501         * amd64-darwin-tdep.c: Fix common/ includes.
7502         * agent.c: Fix common/ includes.
7503         * ada-lang.h: Fix common/ includes.
7504         * ada-lang.c: Fix common/ includes.
7505         * aarch64-tdep.c: Fix common/ includes.
7506
7507 2019-01-25  Tom Tromey  <tom@tromey.com>
7508
7509         * common/create-version.sh: Use common/version.h.
7510
7511 2019-01-24  Pedro Alves  <palves@redhat.com>
7512
7513         * infrun.c (signal_stop, signal_print, signal_program)
7514         (signal_catch, signal_pass): Now arrays instead of pointers.
7515         (update_signals_program_target, do_target_resume)
7516         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7517         * linux-nat.c (linux_nat_target::pass_signals)
7518         (linux_nat_target::create_inferior, linux_nat_target::attach):
7519         Adjust.
7520         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7521         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7522         * procfs.c (procfs_target::pass_signals): Adjust.
7523         * record-full.c (record_full_target::resume): Adjust.
7524         * remote.c (remote_target::pass_signals)
7525         (remote_target::program_signals): Adjust.
7526         * target-debug.h (target_debug_print_signals): Now takes a
7527         gdb::array_view as parameter.  Adjust.
7528         * target.h (target_ops) <pass_signals, program_signals>: Replace
7529         pointer and length parameters with gdb::array_view.
7530         (target_pass_signals, target_program_signals): Likewise.
7531         * target-delegates.c: Regenerate.
7532
7533 2019-01-24  Pedro Alves  <palves@redhat.com>
7534
7535         * common/forward-scope-exit.h
7536         (forward_scope_exit::forward_scope_exit): Pass arguments to
7537         m_bind_function directly, instead of creating a std::bind and
7538         copying that.
7539
7540 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7541
7542         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7543         for static members.
7544         (pass_in_v_vfp_candidate): Likewise.
7545
7546 2019-01-23  Tom Tromey  <tom@tromey.com>
7547             Pedro Alves  <palves@redhat.com>
7548
7549         * regcache.c (class regcache_invalidator): Remove.
7550         (regcache::raw_write): Use make_scope_exit.
7551
7552 2019-01-23  Tom Tromey  <tom@tromey.com>
7553
7554         * ui-out.h (class ui_out_emit_type): Update comment.
7555
7556 2019-01-23  Tom Tromey  <tom@tromey.com>
7557
7558         * infrun.c (fetch_inferior_event): Update comment.
7559
7560 2019-01-23  Tom Tromey  <tom@tromey.com>
7561             Pedro Alves  <palves@redhat.com>
7562
7563         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7564         parameter.
7565         (fetch_inferior_event): Use SCOPE_EXIT.
7566
7567
7568 2019-01-23  Tom Tromey  <tom@tromey.com>
7569             Pedro Alves  <palves@redhat.com>
7570
7571         * infrun.c (disable_thread_events): Delete.
7572         (stop_all_threads): Use SCOPE_EXIT.
7573
7574 2019-01-23  Tom Tromey  <tom@tromey.com>
7575             Pedro Alves  <palves@redhat.com>
7576
7577         * symfile.c: Include forward-scope-exit.h.
7578         (clear_symtab_users_cleanup): Replace forward declaration with
7579         a FORWARD_SCOPE_EXIT.
7580         (syms_from_objfile_1): Use the forward_scope_exit and
7581         gdb::optional instead of cleanup_function.
7582         (reread_symbols): Use the forward_scope_exit instead of
7583         cleanup_function.
7584         (clear_symtab_users_cleanup): Remove function.
7585
7586 2019-01-23  Tom Tromey  <tom@tromey.com>
7587             Pedro Alves  <palves@redhat.com>
7588
7589         * linux-nat.c: Include scope-exit.h.
7590         (cleanup_target_stop): Remove.
7591         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7592         SCOPE_EXIT.
7593
7594 2019-01-23  Tom Tromey  <tom@tromey.com>
7595             Pedro Alves  <palves@redhat.com>
7596
7597         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7598         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7599
7600 2019-01-23  Tom Tromey  <tom@tromey.com>
7601             Andrew Burgess  <andrew.burgess@embecosm.com>
7602             Pedro Alves  <palves@redhat.com>
7603
7604         * infrun.c (fetch_inferior_event): Use scope_exit.
7605         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7606         * top.c (execute_command): Use scope_exit.
7607         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7608         * utils.c (do_bpstat_clear_actions_cleanup)
7609         (make_bpstat_clear_actions_cleanup): Remove.
7610
7611 2019-01-23  Tom Tromey  <tom@tromey.com>
7612             Pedro Alves  <palves@redhat.com>
7613
7614         * infrun.c: Include "common/scope-exit.h"
7615         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7616         (wait_for_inferior): Use SCOPE_EXIT.
7617         (fetch_inferior_event): Use scope_exit.
7618
7619 2019-01-23  Tom Tromey  <tom@tromey.com>
7620             Pedro Alves  <palves@redhat.com>
7621
7622         * breakpoint.c (create_breakpoint): Remove cleanup.
7623
7624 2019-01-23  Tom Tromey  <tom@tromey.com>
7625             Andrew Burgess  <andrew.burgess@embecosm.com>
7626             Pedro Alves  <palves@redhat.com>
7627
7628 2019-01-23  Pedro Alves  <palves@redhat.com>
7629
7630         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7631
7632 2019-01-23  Pedro Alves  <palves@redhat.com>
7633             Andrew Burgess  <andrew.burgess@embecosm.com>
7634
7635         * gdbthread.h: Include "common/forward-scope-exit.h".
7636         (scoped_finish_thread_state): Redefine custom class in terms of
7637         forward_scope_exit.
7638
7639 2019-01-23  Pedro Alves  <palves@redhat.com>
7640             Andrew Burgess  <andrew.burgess@embecosm.com>
7641
7642         * common/forward-scope-exit.h: New file.
7643
7644 2019-01-23  Pedro Alves  <palves@redhat.com>
7645             Andrew Burgess  <andrew.burgess@embecosm.com>
7646             Tom Tromey  <tom@tromey.com>
7647
7648         * common/scope-exit.h: New file.
7649
7650 2019-01-23  Pedro Alves  <palves@redhat.com>
7651
7652         * common/preprocessor.h (ESC): Rename to ...
7653         (ESC_PARENS): ... this.
7654         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7655         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7656
7657 2019-01-23  Tom Tromey  <tom@tromey.com>
7658
7659         * language.h (class scoped_switch_to_sym_language_if_auto):
7660         Initialize m_lang in both cases.
7661
7662 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7663
7664         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7665         with XCNEW.
7666
7667 2019-01-22  Tom Tromey  <tom@tromey.com>
7668
7669         * corelow.c: Do not include sys/file.h.
7670
7671 2019-01-22  Tom Tromey  <tom@tromey.com>
7672
7673         * tui/tui-wingeneral.h: Include gdb_curses.h.
7674
7675 2019-01-22  Tom Tromey  <tom@tromey.com>
7676
7677         * source-cache.h (class source_cache) <get_source_lines,
7678         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7679
7680 2019-01-22  Tom Tromey  <tom@tromey.com>
7681
7682         * remote-fileio.h (struct remote_target): Declare.
7683
7684 2019-01-22  Tom Tromey  <tom@tromey.com>
7685
7686         * python/py-arch.c: Do not include py-ref.h.
7687         * python/py-bpevent.c: Do not include py-ref.h.
7688         * python/py-cmd.c: Do not include py-ref.h.
7689         * python/py-continueevent.c: Do not include py-ref.h.
7690         * python/py-event.h: Do not include py-ref.h.
7691         * python/py-evtregistry.c: Do not include py-ref.h.
7692         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7693         * python/py-frame.c: Do not include py-ref.h.
7694         * python/py-framefilter.c: Do not include py-ref.h.
7695         * python/py-function.c: Do not include py-ref.h.
7696         * python/py-infevents.c: Do not include py-ref.h.
7697         * python/py-linetable.c: Do not include py-ref.h.
7698         * python/py-objfile.c: Do not include py-ref.h.
7699         * python/py-param.c: Do not include py-ref.h.
7700         * python/py-prettyprint.c: Do not include py-ref.h.
7701         * python/py-progspace.c: Do not include py-ref.h.
7702         * python/py-symbol.c: Do not include py-ref.h.
7703         * python/py-symtab.c: Do not include py-ref.h.
7704         * python/py-type.c: Do not include py-ref.h.
7705         * python/py-unwind.c: Do not include py-ref.h.
7706         * python/py-utils.c: Do not include py-ref.h.
7707         * python/py-value.c: Do not include py-ref.h.
7708         * python/py-varobj.c: Do not include py-ref.h.
7709         * python/py-xmethods.c: Do not include py-ref.h.
7710         * python/python.c: Do not include py-ref.h.
7711         * varobj.c: Do not include py-ref.h.
7712
7713 2019-01-22  Tom Tromey  <tom@tromey.com>
7714
7715         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7716         keyword for bcache.
7717
7718 2019-01-22  Tom Tromey  <tom@tromey.com>
7719
7720         * compile/compile-cplus-types.c: Remove a comment by #include.
7721
7722 2019-01-22  Tom Tromey  <tom@tromey.com>
7723
7724         * compile/gcc-c-plugin.h: Include compile-internal.h.
7725
7726 2019-01-22  Tom Tromey  <tom@tromey.com>
7727
7728         * stabsread.c (EXTERN): Do not define.
7729         (symnum, next_symbol_text_func, processing_gcc_compilation)
7730         (within_function, global_sym_chain, global_stabs)
7731         (previous_stab_code, this_object_header_files)
7732         (n_this_object_header_files)
7733         (n_allocated_this_object_header_files): Define.
7734         * stabsread.h (EXTERN): Never define.  Use "extern".
7735
7736 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7737
7738         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7739         history_value.
7740
7741 2019-01-21  Tom Tromey  <tom@tromey.com>
7742
7743         * ui-out.c: Fix includes.
7744         * tui/tui-source.c: Fix includes.
7745         * target.c: Fix includes.
7746         * remote.c: Fix includes.
7747         * regcache.c: Fix includes.
7748         * python/py-block.c: Fix includes.
7749         * printcmd.c: Fix includes.
7750         * or1k-tdep.c: Fix includes.
7751         * mi/mi-main.c: Fix includes.
7752         * m32r-tdep.c: Fix includes.
7753         * csky-tdep.c: Fix includes.
7754         * compile/compile-cplus-types.c: Fix includes.
7755         * cli/cli-interp.c: Fix includes.
7756
7757 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7758
7759         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7760         for padding.
7761
7762 2019-01-16  Tom Tromey  <tom@tromey.com>
7763
7764         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7765         earlier.
7766         (struct objfile) <msymbols_range>: Move from top level.
7767         <msymbols>: New method.
7768         (class objfile_msymbols): Remove.
7769         * symtab.c (default_collect_symbol_completion_matches_break_on):
7770         Update.
7771         * symmisc.c (dump_msymbols): Update.
7772         * stabsread.c (scan_file_globals): Update.
7773         * objc-lang.c (info_selectors_command, info_classes_command)
7774         (find_methods): Update.
7775         * minsyms.c (find_solib_trampoline_target): Update.
7776         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7777         * coffread.c (coff_symfile_read): Update.
7778         * ada-lang.c (ada_lookup_simple_minsym)
7779         (ada_collect_symbol_completion_matches): Update.
7780
7781 2019-01-16  Tom Tromey  <tom@tromey.com>
7782
7783         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7784         type.  Remove no-argument constructor.
7785         <iterator::operator++>: Simplify.
7786         <begin>: Update.
7787         <end>: Use minimal_symbol_count.
7788
7789 2019-01-16  Tom Tromey  <tom@tromey.com>
7790
7791         * objfiles.h (struct objfile) <psymtabs>: New method.
7792         (class objfile_psymtabs): Remove.
7793         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7794         typedef.
7795         <range>: New method.
7796         (require_partial_symbols): Change return type.
7797         * psymtab.c (require_partial_symbols)
7798         (psym_expand_symtabs_matching): Update.
7799         * mdebugread.c (parse_partial_symbols): Update.
7800         * dbxread.c (dbx_end_psymtab): Update.
7801
7802 2019-01-15  Tom Tromey  <tom@tromey.com>
7803
7804         * symtab.c (lookup_objfile_from_block)
7805         (lookup_symbol_in_objfile_symtabs)
7806         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7807         (find_line_symtab, info_sources_command)
7808         (default_collect_symbol_completion_matches_break_on)
7809         (make_source_files_completion_list): Update.
7810         * symmisc.c (print_objfile_statistics, dump_objfile)
7811         (maintenance_print_symbols, maintenance_info_symtabs)
7812         (maintenance_check_symtabs, maintenance_info_line_tables):
7813         Update.
7814         * source.c (select_source_symtab)
7815         (forget_cached_source_info_for_objfile): Update.
7816         * objfiles.h (class objfile_compunits): Remove.
7817         (struct objfile) <compunits_range>: New typedef.
7818         (compunits): New method.
7819         * objfiles.c (objfile_relocate1): Update.
7820         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7821         * maint.c (count_symtabs_and_blocks): Update.
7822         * linespec.c (iterate_over_all_matching_symtabs): Update.
7823         * cp-support.c (add_symbol_overload_list_qualified): Update.
7824         * coffread.c (coff_symtab_read): Update.
7825         * ada-lang.c (add_nonlocal_symbols)
7826         (ada_collect_symbol_completion_matches)
7827         (ada_add_global_exceptions): Update.
7828
7829 2019-01-15  Tom Tromey  <tom@tromey.com>
7830
7831         * progspace.h (program_space) <objfiles_safe_range>: New
7832         typedef.
7833         <objfiles_safe>: New method.
7834         * objfiles.h (class all_objfiles_safe): Remove.
7835         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7836         * jit.c (jit_inferior_exit_hook): Update.
7837
7838 2019-01-17  Tom Tromey  <tom@tromey.com>
7839
7840         * progspace.h (program_space) <objfiles_range>: New typedef.
7841         <objfiles>: New method.
7842         <objfiles_head>: Rename from objfiles.
7843         (object_files): Update.
7844         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7845         * guile/scm-pretty-print.c
7846         (ppscm_find_pretty_printer_from_objfiles): Update.
7847         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7848         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7849         Update.
7850         * python/py-progspace.c (pspy_get_objfiles): Update.
7851         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7852         Update.
7853         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7854         (objfpy_lookup_objfile_by_build_id): Update.
7855         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7856         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7857         Update.
7858         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7859         (expand_symtab_containing_pc, lookup_objfile_from_block)
7860         (lookup_static_symbol, basic_lookup_transparent_type)
7861         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7862         (find_line_symtab, info_sources_command)
7863         (default_collect_symbol_completion_matches_break_on)
7864         (make_source_files_completion_list, find_main_name): Update.
7865         * symmisc.c (print_symbol_bcache_statistics)
7866         (print_objfile_statistics, maintenance_print_symbols)
7867         (maintenance_print_msymbols, maintenance_print_objfiles)
7868         (maintenance_info_symtabs, maintenance_check_symtabs)
7869         (maintenance_expand_symtabs, maintenance_info_line_tables):
7870         Update.
7871         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7872         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7873         (map_overlay_command, unmap_overlay_command)
7874         (simple_overlay_update, expand_symtabs_matching)
7875         (map_symbol_filenames): Update.
7876         * symfile-debug.c (set_debug_symfile): Update.
7877         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7878         Update.
7879         * source.c (select_source_symtab, forget_cached_source_info):
7880         Update.
7881         * solib.c (solib_read_symbols): Update.
7882         * solib-spu.c (append_ocl_sos): Update.
7883         * psymtab.c (maintenance_print_psymbols)
7884         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7885         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7886         * printcmd.c (info_symbol_command): Update.
7887         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7888         Update.
7889         * objfiles.h (class all_objfiles): Remove.
7890         * objfiles.c (have_partial_symbols, have_full_symbols)
7891         (have_minimal_symbols, qsort_cmp, update_section_map)
7892         (shared_objfile_contains_address_p)
7893         (default_iterate_over_objfiles_in_search_order): Update.
7894         * objc-lang.c (info_selectors_command, info_classes_command)
7895         (find_methods): Update.
7896         * minsyms.c (find_solib_trampoline_target): Update.
7897         * maint.c (maintenance_info_sections)
7898         (maintenance_translate_address, count_symtabs_and_blocks):
7899         Update.
7900         * main.c (captured_main_1): Update.
7901         * linux-thread-db.c (try_thread_db_load_from_pdir)
7902         (has_libpthread): Update.
7903         * linespec.c (iterate_over_all_matching_symtabs)
7904         (search_minsyms_for_name): Update.
7905         * jit.c (jit_find_objf_with_entry_addr): Update.
7906         * hppa-tdep.c (find_unwind_entry)
7907         (hppa_lookup_stub_minimal_symbol): Update.
7908         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7909         Update.
7910         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7911         (elf_gnu_ifunc_resolve_by_got): Update.
7912         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7913         * dwarf-index-write.c (save_gdb_index_command): Update.
7914         * cp-support.c (add_symbol_overload_list_qualified): Update.
7915         * breakpoint.c (create_overlay_event_breakpoint)
7916         (create_longjmp_master_breakpoint)
7917         (create_std_terminate_master_breakpoint)
7918         (create_exception_master_breakpoint): Update.
7919         * blockframe.c (find_pc_partial_function): Update.
7920         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7921         (ada_collect_symbol_completion_matches)
7922         (ada_add_global_exceptions): Update.
7923
7924 2019-01-17  Tom Tromey  <tom@tromey.com>
7925
7926         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7927         declare VEC.
7928         (solib_target_parse_libraries): Change return type.
7929         (library_list_start_segment, library_list_start_section)
7930         (library_list_end_library, library_list_start_library); Update.
7931         (solib_target_free_library_list): Remove.
7932         (solib_target_parse_libraries): Remove cleanup.  Change return
7933         type.
7934         (solib_target_current_sos): Update.
7935
7936 2019-01-17  Tom Tromey  <tromey@bapiya>
7937
7938         * valprint.c: Replace "the the" with "the".
7939         * symtab.c: Replace "the the" with "the".
7940         * solib.c: Replace "the the" with "the".
7941         * solib-dsbt.c: Replace "the the" with "the".
7942         * linespec.c: Replace "the the" with "the".
7943         * dwarf2loc.h: Replace "the the" with "the".
7944         * amd64-windows-tdep.c: Replace "the the" with "the".
7945         * aarch64-tdep.c: Replace "the the" with "the".
7946
7947 2019-01-16  Keith Seitz  <keiths@redhat.com>
7948
7949         PR gdb/23773
7950         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7951         <builder>: Rename to ..
7952         <m_builder>: ... this and make private.
7953         (dwarf2_cu::get_builder): New method.  Change all users of
7954         `builder' to use this method.
7955         (dwarf2_start_symtab): Move to ...
7956         (dwarf2_cu::start_symtab): ... here.  Update all callers
7957         (setup_type_unit_groups): Move to ...
7958         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7959         callers.
7960         (dwarf2_cu::reset_builder): New method.
7961         (process_full_compunit, process_full_type_unit): Use
7962         dwarf2_cu::reset_builder.
7963         (follow_die_offset): Record the ancestor CU if it is different
7964         from the followed DIE's CU.
7965         (follow_die_sig_1): Likewise.
7966
7967 2019-01-15  Tom Tromey  <tom@tromey.com>
7968
7969         * remote.c (class remote_state) <buf>: Now a char_vector.
7970         <buf_size>: Remove.
7971         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7972         parameter.
7973         (remote_target::getpkt_or_notif_sane_1)
7974         (remote_target::getpkt_sane)
7975         (remote_target::getpkt_or_notif_sane): Likewise.
7976         (class remote_target) <putpkt>: New overload.
7977         (remote_target::read_frame): Change type of "buf_p".  Remove
7978         sizeof_p parameter.
7979         (packet_ok): New overload.
7980         (packet_check_result): New overload.
7981         Update all uses.
7982
7983 2019-01-14  Tom Tromey  <tom@tromey.com>
7984
7985         * remote-notif.c (handle_notification, remote_notif_ack)
7986         (remote_notif_parse): Make "buf" const.
7987         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7988         const.
7989         (remote_notif_parse, remote_notif_ack, handle_notification):
7990         Likewise.
7991         * remote.c (remote_notif_stop_parse): Make "buf" const.
7992         (remote_target::remote_parse_stop_reply): Make "buf" const.
7993         (remote_notif_stop_ack): Make "buf" const.
7994
7995 2019-01-14  Tom Tromey  <tom@tromey.com>
7996
7997         * remote.c (remote_console_output): Make parameter const.
7998
7999 2019-01-14  Tom Tromey  <tom@tromey.com>
8000
8001         * target-debug.h (target_debug_print_signals): Constify.
8002         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8003         * procfs.c (procfs_target::pass_signals): Update.
8004         * linux-nat.c (linux_nat_target::pass_signals): Update.
8005         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8006         * target-delegates.c: Rebuild.
8007         * remote.c (remote_target::program_signals): Update.
8008         (remote_target::pass_signals): Update.
8009         * target.c (target_pass_signals): Constify argument.
8010         (target_program_signals): Likewise.
8011         * target.h (struct target_ops) <pass_signals, program_signals>:
8012         Constify argument.
8013         (target_pass_signals, target_program_signals): Constify argument.
8014
8015 2019-01-14  Tom Tromey  <tom@tromey.com>
8016
8017         PR tui/28819:
8018         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8019
8020 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8021
8022         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8023         field.
8024         * rs6000-tdep.c: Include reggroups.h.
8025         (IS_V_ALIAS_PSEUDOREG): Define.
8026         (rs6000_register_name): Return names for the "vX" aliases.
8027         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8028         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8029         aliases.  Call default_register_reggroup_p for all other
8030         pseudo-registers.
8031         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8032         New functions.
8033         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8034         Handle "vX" aliases.
8035         (v_alias_pseudo_register_collect): New function.
8036         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8037         (rs6000_gdbarch_init): Initialize "vX" aliases as
8038         pseudo-registers.  Restore registration of
8039         rs6000_pseudo_register_reggroup_p with
8040         set_tdesc_pseudo_register_reggroup_p.
8041
8042 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8043
8044         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8045         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8046         set_gdbarch_num_pseudo_regs.
8047
8048 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8049
8050         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8051         Remove arg prefixname, add do_set and do_show.
8052         Add member functions set_list and show_list.
8053         * cli/cli-style.c (class cli_style_option): Update accordingly.
8054         (style_set_list): Move to file scope.
8055         (style_show_list): Likewise.
8056         (set_style): Call help_list.
8057         (show_style): Call cmd_show_list.
8058         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8059         Update to use the new macro.
8060
8061 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8062
8063         * ada-lang.c (_initialize_ada_language): Expand the help text
8064         for the "catch exception" command.
8065
8066 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8067
8068         * symtab.c (matching_obj_sections): Initialize obj,
8069         declare it closer to its usage.
8070
8071 2019-01-10  Tom Tromey  <tom@tromey.com>
8072
8073         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8074         (basic_inf_threads_range): Remove.
8075         (inf_threads_range, inf_non_exited_threads_range)
8076         (safe_inf_threads_range): Use next_adapter.
8077
8078 2019-01-10  Keith Seitz  <keiths@redhat.com>
8079
8080         PR gdb/23712
8081         PR symtab/23010
8082         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8083         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8084
8085 2019-01-10  Keith Seitz  <keiths@redhat.com>
8086
8087         PR gdb/23712
8088         PR symtab/23010
8089         * dictionary.c (pending_to_vector): Remove.
8090         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8091         Remove _1 suffix, replacing functions of the same name.  Update
8092         all callers.
8093         (dict_create_hashed, dict_create_hashed_expandable)
8094         (dict_create_linear, dict_create_linear_expandable, dict_free)
8095         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8096         Make functions static.
8097
8098 2019-01-10  Keith Seitz  <keiths@redhat.com>
8099
8100         PR gdb/23712
8101         PR symtab/23010
8102         * dictionary.h (struct dictionary): Replace declaration with
8103         multidictionary.
8104         (dict_create_hashed, dict_create_hashed_expandable)
8105         (dict_create_linear, dict_create_linear_expandable)
8106         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8107         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8108         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8109         taking multidictionary argument.
8110         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8111         * block.h (struct block) <dict>: Change to multidictionary
8112         and rename `multidict'.
8113         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8114         symmisc.c: Update all dictionary references to multidictionary.
8115
8116 2019-01-10  Keith Seitz  <keiths@redhat.com>
8117
8118         PR gdb/23712
8119         PR symtab/23010
8120         * dictionary.c: Include unordered_map.
8121         (pending_to_vector): New function.
8122         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8123         Rewrite the non-"_1" functions to take vector instead
8124         of linked list.
8125         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8126         "new" _1 versions of the same name.
8127         (multidictionary): Define.
8128         (std::hash<enum language): New definition.
8129         (collate_pending_symbols_by_language, mdict_create_hashed)
8130         (mdict_create_hashed_expandable, mdict_create_linear)
8131         (mdict_create_linear_expandable, mdict_free)
8132         (find_language_dictionary, create_new_language_dictionary)
8133         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8134         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8135         (mdict_size, mdict_empty): New functions.
8136         * dictionary.h (mdict_iterator): Define.
8137
8138 2019-01-10  Pedro Alves  <palves@redhat.com>
8139
8140         * breakpoint.c (read_uploaded_action)
8141         (create_tracepoint_from_upload): Adjust to use
8142         gdb::unique_xmalloc_ptr.
8143         * ctf.c (ctf_write_uploaded_tp):
8144         (SET_ARRAY_FIELD): Use emplace_back.
8145         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8146         * tracefile-tfile.c (tfile_write_uploaded_tp):
8147         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8148         gdb::unique_xmalloc_ptr.
8149         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8150         at_string, cond_string, cmd_strings>: Replace char pointers
8151         with gdb::unique_xmalloc_ptr.
8152
8153 2019-01-10  Pedro Alves  <palves@redhat.com>
8154
8155         * solib-target.c (library_list_start_library): Don't xstrdup name.
8156
8157 2019-01-10  Pedro Alves  <palves@redhat.com>
8158
8159         * mdebugread.c (parse_partial_symbols): Use
8160         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8161
8162 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8163
8164         * linux-fork.c (scoped_switch_fork_info)
8165         <~scoped_switch_fork_info>: Fix incorrect variable name.
8166
8167 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8168
8169         * linux-fork.c (scoped_switch_fork_info)
8170         <scoped_switch_fork_info>: Make explicit.
8171         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8172
8173 2019-01-10  Tom Tromey  <tom@tromey.com>
8174
8175         * objfiles.h (objfile::reset_psymtabs): Update.
8176         * objfiles.c (objfile::objfile): Update.
8177         * psymtab.h (psymtab_storage::obstack): Update.
8178         (psymtab_storage::m_obstack): Use gdb::optional.
8179         (class psymtab_storage): Update comment.  Remove objfile
8180         parameter.
8181         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8182
8183 2019-01-10  Tom Tromey  <tom@tromey.com>
8184
8185         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8186         <free_psymtabs>: Now private.
8187         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8188         (allocate_psymtab): Use new method.
8189
8190 2019-01-10  Tom Tromey  <tom@tromey.com>
8191
8192         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8193         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8194         * mdebugread.c (parse_partial_symbols): Use
8195         allocate_dependencies.
8196         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8197         allocate_dependencies.
8198         (process_psymtab_comp_unit_reader)
8199         (build_type_psymtab_dependencies): Likewise.
8200         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8201
8202 2019-01-10  Tom Tromey  <tom@tromey.com>
8203
8204         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8205         PSYMBOL_SET_LANGUAGE.
8206         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8207
8208 2019-01-10  Tom Tromey  <tom@tromey.com>
8209
8210         * psymtab.h (psymtab_storage::obstack): New method.
8211         <m_obstack>: Rename from obstack; now private.
8212         * psymtab.c (psymtab_storage): Update.
8213         * dwarf2read.c (create_addrmap_from_index)
8214         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8215         Update.
8216
8217 2019-01-10  Tom Tromey  <tom@tromey.com>
8218
8219         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8220         * objfiles.h (objfile::reset_psymtabs): New method.
8221
8222 2019-01-10  Tom Tromey  <tom@tromey.com>
8223
8224         * symmisc.c (print_symbol_bcache_statistics): Update.
8225         (print_objfile_statistics): Update.
8226         * symfile.c (reread_symbols): Update.
8227         * psymtab.h (class psymtab_storage): New.
8228         * psymtab.c (psymtab_storage): New constructor.
8229         (~psymtab_storage): New destructor.
8230         (require_partial_symbols): Update.
8231         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8232         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8233         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8234         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8235         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8236         (start_psymtab_common, end_psymtab_common)
8237         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8238         (allocate_psymtab): Update.
8239         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8240         Update.
8241         (dump_psymtab_addrmap, maintenance_print_psymbols)
8242         (maintenance_check_psymtabs): Update.
8243         (class objfile_psymtabs): Move to objfiles.h.
8244         * psympriv.h (discard_psymtab): Now inline.
8245         (psymtab_discarder::psymtab_discarder): Update.
8246         (psymtab_discarder::~psymtab_discarder): Update.
8247         (ALL_OBJFILE_PSYMTABS): Rewrite.
8248         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8249         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8250         Remove fields.
8251         <partial_symtabs>: New field.
8252         (class objfile_psymtabs): Move from psymtab.h.  Update.
8253         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8254         psymbol_cache.
8255         (objfile::~objfile): Don't destroy psymbol_cache.
8256         * mdebugread.c (parse_partial_symbols): Update.
8257         * dwarf2read.c (create_addrmap_from_index)
8258         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8259         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8260         (add_partial_subprogram, dwarf2_ranges_read): Update.
8261         * dwarf-index-write.c (write_address_map)
8262         (write_one_signatured_type, recursively_write_psymbols)
8263         (class debug_names, class debug_names, write_psymtabs_to_index):
8264         Update.
8265
8266 2019-01-10  Tom Tromey  <tom@tromey.com>
8267
8268         * symtab.h (SYMBOL_SET_NAMES): Update.
8269         (symbol_set_names): Update.
8270         (MSYMBOL_SET_NAMES): Update.
8271         * symtab.c (symbol_set_names): Change argument to be an
8272         objfile_per_bfd_storage.
8273         * psymtab.c (add_psymbol_to_bcache): Update.
8274         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8275
8276 2019-01-10  Tom Tromey  <tom@tromey.com>
8277
8278         * symtab.c (create_demangled_names_hash): Change argument to be an
8279         objfile_per_bfd_storage.
8280         (symbol_set_names): Update.
8281
8282 2019-01-10  Tom Tromey  <tom@tromey.com>
8283
8284         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8285         init_psymbol_list.
8286         * psymtab.c (init_psymbol_list): Do nothing if already called.
8287         * psympriv.h (init_psymbol_list): Add comment.
8288         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8289         init_psymbol_list.
8290         * dbxread.c (dbx_symfile_read): Unconditionally call
8291         init_psymbol_list.
8292
8293 2019-01-10  Tom Tromey  <tom@tromey.com>
8294
8295         * xcoffread.c (scan_xcoff_symtab): Update.
8296         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8297         "where".
8298         * mdebugread.c (parse_partial_symbols)
8299         (handle_psymbol_enumerators): Update.
8300         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8301         * dbxread.c (read_dbx_symtab): Update.
8302         * psympriv.h (psymbol_placement): New enum.
8303         (add_psymbol_to_list): Update.
8304
8305 2019-01-10  Tom Tromey  <tom@tromey.com>
8306
8307         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8308         static_psymbols parameters.
8309         (scan_xcoff_symtab): Update.
8310         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8311         static_psymbols parameters.
8312         * psympriv.h (start_psymtab_common): Update.
8313         * mdebugread.c (parse_partial_symbols): Update.
8314         * dwarf2read.c (create_partial_symtab): Update.
8315         * dbxread.c (read_dbx_symtab): Update.
8316         (start_psymtab): Remove global_psymbols and static_psymbols
8317         parameters.
8318
8319 2019-01-10  Tom Tromey  <tom@tromey.com>
8320
8321         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8322         * psymtab.c (allocate_psymtab): Add comment.
8323         * psympriv.h (allocate_psymtab): Add comment.
8324         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8325         initializations.
8326         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8327
8328 2019-01-10  Tom Tromey  <tom@tromey.com>
8329
8330         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8331         Don't declare.
8332         * mipsread.c: Include mdebugread.h.
8333         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8334         Declare.
8335         * elfread.c: Include mdebugread.h.
8336
8337 2019-01-09  Tom Tromey  <tom@tromey.com>
8338
8339         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8340         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8341         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8342         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8343         (psym_lookup_symbol, psym_find_last_source_symtab)
8344         (psym_forget_cached_source_info, psym_print_stats)
8345         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8346         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8347         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8348         (psym_find_compunit_symtab_by_address)
8349         (maintenance_print_psymbols, maintenance_info_psymtabs)
8350         (maintenance_check_psymtabs): Use ranged for.
8351         * psymtab.h (class objfile_psymtabs): New.
8352         (require_partial_symbols): Return objfile_psymtabs.
8353         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8354
8355 2019-01-09  Tom Tromey  <tom@tromey.com>
8356
8357         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8358         (find_pc_mapped_section, list_overlays_command)
8359         (map_overlay_command, unmap_overlay_command)
8360         (simple_overlay_update): Use all_objfiles.
8361         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8362         * printcmd.c (info_symbol_command): Use all_objfiles.
8363         * objfiles.h (ALL_OBJSECTIONS): Remove.
8364         * maint.c (maintenance_translate_address): Use all_objfiles.
8365         * gcore.c (gcore_create_callback): Use all_objfiles.
8366         (objfile_find_memory_regions): Likewise.
8367
8368 2019-01-09  Tom Tromey  <tom@tromey.com>
8369
8370         * symtab.c (find_line_symtab, info_sources_command)
8371         (make_source_files_completion_list): Use objfile_compunits.
8372         * source.c (select_source_symtab): Use objfile_compunits.
8373         * objfiles.h (struct objfile): Update comment.
8374         (ALL_OBJFILES): Remove.
8375         (ALL_FILETABS): Remove.
8376         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8377         objfile_compunits.
8378
8379 2019-01-09  Tom Tromey  <tom@tromey.com>
8380
8381         * symmisc.c (print_objfile_statistics, dump_objfile)
8382         (maintenance_print_symbols): Use compunit_filetabs.
8383         * source.c (forget_cached_source_info_for_objfile): Use
8384         compunit_filetabs.
8385         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8386         (ALL_FILETABS): Use compunit_filetabs.
8387         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8388         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8389
8390 2019-01-09  Tom Tromey  <tom@tromey.com>
8391
8392         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8393         (compunit_filetabs): New.
8394         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8395         compunit_filetabs.
8396         (info_sources_command, make_source_files_completion_list): Remove
8397         declaration.
8398         * symmisc.c (print_objfile_statistics, dump_objfile)
8399         (maintenance_print_symbols): Remove declaration.
8400         (maintenance_info_symtabs): Use compunit_filetabs.
8401         (maintenance_info_line_tables): Likewise.
8402         * source.c (select_source_symtab): Change local variable name.
8403         (forget_cached_source_info_for_objfile): Remove declaration.
8404         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8405         * objfiles.c (objfile_relocate1): Remove declaration.
8406         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8407         declaration.
8408         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8409         * coffread.c (coff_symtab_read): Remove declaration.
8410         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8411         compunit_filetabs.
8412
8413 2019-01-09  Tom Tromey  <tom@tromey.com>
8414
8415         * symtab.c (lookup_objfile_from_block)
8416         (find_pc_sect_compunit_symtab, search_symbols)
8417         (default_collect_symbol_completion_matches_break_on): Use
8418         objfile_compunits.
8419         * objfiles.h (ALL_COMPUNITS): Remove.
8420         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8421         * cp-support.c (add_symbol_overload_list_qualified): Use
8422         objfile_compunits.
8423         * ada-lang.c (ada_collect_symbol_completion_matches)
8424         (ada_add_global_exceptions): Use objfile_compunits.
8425
8426 2019-01-09  Tom Tromey  <tom@tromey.com>
8427
8428         * source.c (select_source_symtab)
8429         (forget_cached_source_info_for_objfile): Remove declaration.
8430         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8431         declaration.
8432         * maint.c (count_symtabs_and_blocks): Remove declaration.
8433         * cp-support.c (add_symbol_overload_list_qualified): Remove
8434         declaration.
8435         * coffread.c (coff_symtab_read): Remove declaration.
8436         * symtab.c (lookup_symbol_in_objfile_symtabs)
8437         (basic_lookup_transparent_type_1): Use objfile_compunits.
8438         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8439         (info_sources_command, search_symbols)
8440         (default_collect_symbol_completion_matches_break_on)
8441         (make_source_files_completion_list): Remove declaration.
8442         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8443         (ada_collect_symbol_completion_matches)
8444         (ada_add_global_exceptions): Remove declaration.
8445         * linespec.c (iterate_over_all_matching_symtabs): Use
8446         objfile_compunits.
8447         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8448         (class objfile_compunits): New.
8449         (ALL_COMPUNITS): Use objfile_compunits.
8450         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8451         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8452         objfile_compunits.
8453         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8454
8455 2019-01-09  Tom Tromey  <tom@tromey.com>
8456
8457         * symtab.c (search_symbols)
8458         (default_collect_symbol_completion_matches_break_on): Use
8459         objfile_msymbols.
8460         * ada-lang.c (ada_lookup_simple_minsym)
8461         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8462         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8463         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8464         objfile_msymbols.
8465         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8466         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8467         * objc-lang.c (find_methods): Use objfile_msymbols.
8468         (info_selectors_command, info_classes_command): Likewise.
8469         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8470         * objfiles.h (class objfile_msymbols): New.
8471         (ALL_OBJFILE_MSYMBOLS): Remove.
8472         (ALL_MSYMBOLS): Remove.
8473
8474 2019-01-09  Tom Tromey  <tom@tromey.com>
8475
8476         * common/next-iterator.h (next_adapter): Add Iterator template
8477         parameter.
8478         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8479         (class all_objfiles_safe): New.
8480         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8481         * objfiles.c (put_objfile_before): Update comment.
8482         (add_separate_debug_objfile): Likewise.
8483         (free_all_objfiles): Use all_objfiles_safe.
8484         (objfile_purge_solibs): Likewise.
8485
8486 2019-01-09  Tom Tromey  <tom@tromey.com>
8487
8488         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8489         (expand_symtab_containing_pc, lookup_static_symbol)
8490         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8491         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8492         all_objfiles.
8493         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8494         * breakpoint.c (create_overlay_event_breakpoint)
8495         (create_longjmp_master_breakpoint)
8496         (create_std_terminate_master_breakpoint)
8497         (create_exception_master_breakpoint): Use all_objfiles.
8498         * linux-thread-db.c (try_thread_db_load_from_pdir)
8499         (has_libpthread): Use all_objfiles.
8500         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8501         * linespec.c (iterate_over_all_matching_symtabs)
8502         (search_minsyms_for_name): Use all_objfiles.
8503         * maint.c (maintenance_info_sections): Use all_objfiles.
8504         * main.c (captured_main_1): Use all_objfiles.
8505         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8506         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8507         * guile/scm-pretty-print.c
8508         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8509         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8510         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8511         (maintenance_print_msymbols): Use all_objfiles.
8512         * source.c (select_source_symtab): Use all_objfiles.
8513         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8514         * symfile.c (remove_symbol_file_command)
8515         (expand_symtabs_matching, map_symbol_filenames): Use
8516         all_objfiles.
8517         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8518         all_objfiles.
8519         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8520         * objc-lang.c (find_methods): Use all_objfiles.
8521         * objfiles.c (have_partial_symbols, have_full_symbols)
8522         (have_minimal_symbols, qsort_cmp)
8523         (default_iterate_over_objfiles_in_search_order): Use
8524         all_objfiles.
8525         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8526         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8527         (maintenance_check_psymtabs): Use all_objfiles.
8528         (ALL_PSYMTABS): Remove.
8529         * compile/compile-object-run.c (do_module_cleanup): Use
8530         all_objfiles.
8531         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8532         * cp-support.c (add_symbol_overload_list_qualified): Use
8533         all_objfiles.
8534         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8535         Use all_objfiles.
8536         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8537         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8538         all_objfiles.
8539         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8540         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8541         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8542         Uses all_objfiles.
8543         * solib.c (solib_read_symbols): Use all_objfiles
8544
8545 2019-01-09  Tom Tromey  <tom@tromey.com>
8546
8547         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8548         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8549         all_objfiles.
8550         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8551         * symmisc.c (print_symbol_bcache_statistics)
8552         (print_objfile_statistics, maintenance_print_objfiles)
8553         (maintenance_info_symtabs, maintenance_check_symtabs)
8554         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8555         all_objfiles.
8556         * source.c (forget_cached_source_info): Use all_objfiles.
8557         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8558         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8559         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8560         * objfiles.c (update_section_map): Use all_objfiles.
8561         (shared_objfile_contains_address_p): Likewise.
8562         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8563         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8564
8565 2019-01-09  Tom Tromey  <tom@tromey.com>
8566
8567         * common/next-iterator.h: New file.
8568         * objfiles.h (class all_objfiles): New.
8569         (struct objfile_iterator): New.
8570
8571 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8572
8573         * NEWS: Move the description of the changed "frame", "select-frame",
8574          and "info frame" commands to the Changed commands section.
8575
8576 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8577
8578         * gdbtypes.c (check_stub_method_group): Remove handling of old
8579         mangling schemes.
8580         * linespec.c (find_methods): Likewise.
8581         * stabsread.c (read_member_functions): Likewise.
8582         * valops.c (search_struct_method): Likewise.
8583         (value_struct_elt_for_reference): Likewise.
8584         * NEWS: Mention this change.
8585
8586 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8587
8588         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8589         print_source_lines.
8590         * source.c (print_source_lines_base): Update line number check.
8591         (print_source_lines): New function.
8592         (source_lines_range::source_lines_range): New function.
8593         * source.h (class source_lines_range): New class.
8594         (print_source_lines): New declaration.
8595
8596 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8597
8598         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8599
8600 2019-01-08  Tom Tromey  <tom@tromey.com>
8601             Simon Marchi  <simon.marchi@ericsson.com>
8602
8603         PR gdb/24060
8604         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8605         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8606         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8607         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8608         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8609         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8610
8611 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8612
8613         * source.c (select_source_symtab): Move header comment to
8614         declaration in source.h.
8615         (forget_cached_source_info_for_objfile): Likewise.
8616         (forget_cached_source_info): Likewise.
8617         (identify_source_line): Likewise.
8618         * source.h (identify_source_line): Move declaration from symtab.h
8619         and add comment from source.c
8620         (print_source_lines): Likewise.
8621         (forget_cached_source_info_for_objfile): Likewise.
8622         (forget_cached_source_info): Likewise.
8623         (select_source_symtab): Likewise.
8624         (enum print_source_lines_flag): Move definition from symtab.h.
8625         * symtab.h (identify_source_line): Move declaration to source.h.
8626         (print_source_lines): Likewise.
8627         (forget_cached_source_info_for_objfile): Likewise.
8628         (forget_cached_source_info): Likewise.
8629         (select_source_symtab): Likewise.
8630         (enum print_source_lines_flag): Move definition to source.h.
8631         * tui/tui-hooks.c: Add 'source.h' include.
8632
8633 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8634
8635         * source.c (print_source_lines_base): Handle requests to print
8636         reverse line number sequences, and guard against empty lines
8637         string.
8638
8639 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8640
8641         * source.c (print_source_lines_base): Fix skip of '\r' if next
8642         character is '\n'.
8643
8644 2019-01-06  Tom Tromey  <tom@tromey.com>
8645
8646         * c-exp.y (struct c_parse_state) <macro_original_text,
8647         expansion_obstack>: New member.
8648         (macro_original_text, expansion_obstack): Remove globals.
8649         (scan_macro_expansion, scanning_macro_expansion)
8650         (finished_macro_expansion): Update.
8651         (scan_macro_cleanup): Remove.
8652         (yylex, c_parse): Update.
8653
8654 2019-01-06  Tom Tromey  <tom@tromey.com>
8655
8656         * c-exp.y (struct c_parse_state) <strings>: New member.
8657         (operator_stoken): Update.
8658
8659 2019-01-06  Tom Tromey  <tom@tromey.com>
8660
8661         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8662         (union type_stack_elt) <typelist_val>: Now a pointer to
8663         std::vector.
8664         (type_stack_cleanup): Don't declare.
8665         (push_typelist): Update.
8666         * parse.c (pop_typelist): Return a std::vector.
8667         (push_typelist): Take a std::vector.
8668         (follow_types): Update.  Do not free args.
8669         (type_stack_cleanup): Remove.
8670         * c-exp.y (struct c_parse_state): New.
8671         (cpstate): New global.
8672         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8673         (nonempty_typelist): Update.
8674         (func_mod): Create a new vector.
8675         (c_parse): Create a c_parse_state.
8676         (check_parameter_typelist): Do not delete params.
8677         (function_method): Update.  Do not delete type_list.
8678
8679 2019-01-06  Tom Tromey  <tom@tromey.com>
8680
8681         PR gdb/28155:
8682         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8683         check_typedef.
8684         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8685         (print_return_value): Likewise.
8686
8687 2019-01-05  Tom Tromey  <tom@tromey.com>
8688
8689         * contrib/cleanup_check.py: Remove.
8690         * contrib/gcc-with-excheck: Remove.
8691         * contrib/exsummary.py: Remove.
8692         * contrib/excheck.py: Remove.
8693
8694 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8695
8696         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8697         NULL. Initialize tpprev to NULL instead of assigning it
8698         to NULL on the next statement.
8699         * windows-nat.c (windows_delete_thread): Remove check for
8700         main_thread_id before printing thread exit notifications.
8701         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8702         Remove thread ID check against main_thread_id.
8703         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8704         windows_delete_thread.
8705         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8706
8707 2019-01-04  Tom Tromey  <tom@tromey.com>
8708
8709         * compile/compile.c (_initialize_compile): Use upper case for
8710         metasyntactic variables.
8711         * symmisc.c (_initialize_symmisc): Use upper case for
8712         metasyntactic variables.
8713         * psymtab.c (_initialize_psymtab): Use upper case for
8714         metasyntactic variables.
8715         * demangle.c (demangle_command): Use upper case for metasyntactic
8716         variables.
8717         (_initialize_demangler): Likewise.
8718         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8719         variables.
8720
8721 2019-01-03  Tom Tromey  <tom@tromey.com>
8722
8723         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8724
8725 2019-01-03  Tom Tromey  <tom@tromey.com>
8726
8727         * python/py-symtab.c (salpy_str): Update.
8728         (struct salpy_sal_object) <symtab>: Now a PyObject.
8729         (salpy_dealloc): Update.
8730         (del_objfile_sal): Use gdbpy_ref.
8731
8732 2019-01-03  Tom Tromey  <tom@tromey.com>
8733
8734         * python/py-type.c (convert_field): Use new_reference.  Return
8735         gdbpy_ref.
8736         (make_fielditem): Return gdbpy_ref.
8737         (typy_fields): Update.
8738         (typy_getitem): Update.
8739         (field_name): Return gdbpy_ref.  Use new_reference.
8740         (typy_iterator_iternext): Update.
8741
8742 2019-01-03  Tom Tromey  <tom@tromey.com>
8743
8744         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8745
8746 2019-01-03  Tom Tromey  <tom@tromey.com>
8747
8748         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8749         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8750         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8751         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8752         (pspy_set_type_printers): Likewise.
8753         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8754         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8755         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8756         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8757         (objfpy_set_type_printers): Likewise.
8758
8759 2019-01-03  Tom Tromey  <tom@tromey.com>
8760
8761         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8762         (gdbpy_print_stack): Use gdbpy_err_fetch.
8763         * python/python-internal.h (class gdbpy_err_fetch): New class.
8764         (class gdbpy_enter) <m_error_type, m_error_value,
8765         m_error_traceback>: Remove.
8766         <m_error>: New member.
8767         (gdbpy_exception_to_string): Don't declare.
8768         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8769         * python/py-value.c (convert_value_from_python): Use
8770         gdbpy_err_fetch.
8771         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8772         gdbpy_exception_to_string.
8773         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8774         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8775         gdbpy_err_fetch.
8776
8777 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8778
8779         * linux-nat.c (delete_lwp_cleanup): Delete.
8780         (struct lwp_deleter): New struct.
8781         (lwp_info_up): New typedef.
8782         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8783         lwp_info_up.
8784
8785 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8786
8787         * linux-fork.c (class scoped_switch_fork_info): New class.
8788         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8789
8790 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8791
8792         * valops.c (find_overload_match): Remove use of null_cleanup, and
8793         calls to do_cleanups.
8794
8795 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8796
8797         * compile/compile-cplus-types.c
8798         (compile_cplus_instance::decl_name): Handle changes to
8799         cp_func_name.
8800         * cp-support.c (cp_func_name): Update header comment, update
8801         return type.
8802         * cp-support.h (cp_func_name): Update return type in declaration.
8803         * valops.c (find_overload_match): Move temp_func local to top
8804         level of function and change its type.  Use temp_func to hold and
8805         delete temporary string obtained from cp_func_name.
8806
8807 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8808
8809         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8810         gdb::char_vector, remove cleanup, and update uses of `msg`.
8811
8812 2019-01-03  Jim Wilson  <jimw@sifive.com>
8813
8814         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8815
8816 2019-01-02  Tom Tromey  <tom@tromey.com>
8817
8818         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8819         (tdesc_parse_xml): Remove cleanups.
8820         * target-descriptions.h (make_cleanup_free_target_description):
8821         Don't declare.
8822         (target_desc_deleter): New struct.
8823         (target_desc_up): New typedef.
8824         * target-descriptions.c (target_desc_deleter::operator()): Rename
8825         from free_target_description.
8826         (make_cleanup_free_target_description): Remove.
8827
8828 2019-01-02  Tom Tromey  <tom@tromey.com>
8829
8830         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8831         constructor, destructor.
8832         (linespec_parser): Remove typedef.
8833         (~linespec_parser): Rename from linespec_parser_delete.
8834         (linespec_lex_to_end, linespec_complete_label)
8835         (linespec_complete): Update.
8836         (decode_line_full): Remove cleanups.
8837         (decode_line_1): Update.
8838
8839 2019-01-02  Tom Tromey  <tom@tromey.com>
8840
8841         * python/python-internal.h (inferior_to_inferior_object): Change
8842         return type.
8843         * python/py-exitedevent.c (create_exited_event_object): Update.
8844         * python/py-inferior.c (inferior_to_inferior_object): Return
8845         gdbpy_ref.
8846         (python_new_inferior, python_inferior_deleted)
8847         (thread_to_thread_object, delete_thread_object)
8848         (build_inferior_list, gdbpy_selected_inferior): Update.
8849         * python/py-infthread.c (create_thread_object): Update.  Also fail
8850         if inferior_to_inferior_object fails.
8851
8852 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8853
8854         * inferior.h (class inferior) <displaced_step_state>: New field.
8855         * infrun.h (struct displaced_step_state): Move here from
8856         infrun.c.  Initialize fields, add constructor.
8857         <inf>: Remove field.
8858         <reset>: New method.
8859         * infrun.c (struct displaced_step_inferior_state): Move to
8860         infrun.h.
8861         (displaced_step_inferior_states): Remove.
8862         (get_displaced_stepping_state): Adust.
8863         (displaced_step_in_progress_any_inferior): Adjust.
8864         (displaced_step_in_progress_thread): Adjust.
8865         (displaced_step_in_progress): Adjust.
8866         (add_displaced_stepping_state): Remove.
8867         (get_displaced_step_closure_by_addr): Adjust.
8868         (remove_displaced_stepping_state): Remove.
8869         (infrun_inferior_exit): Call displaced_step_state.reset.
8870         (use_displaced_stepping): Don't check for NULL.
8871         (displaced_step_prepare_throw): Call
8872         get_displaced_stepping_state.
8873         (displaced_step_fixup): Don't check for NULL.
8874         (prepare_for_detach): Don't check for NULL.
8875
8876 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8877
8878         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8879          in case of call that did not complete.
8880
8881 2019-01-02  Andrey Utkin  <autkin@undo.io>
8882
8883         * symfile.c (find_separate_debug_file): Fix search of debug files for
8884         remote debuggee.
8885
8886 2019-01-02  Tom Tromey  <tom@tromey.com>
8887
8888         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8889         indentation.
8890         * python/py-frame.c (frapy_older): Remove cast.
8891         (frapy_newer): Likewise.
8892         * python/py-breakpoint.c (local_setattro): Remove cast.
8893         * python/py-arch.c (archpy_name): Remove local variable.
8894         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8895
8896 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8897
8898         * unittests/basic_string_view/element_access/char/empty.cc:
8899         Fix year range in copyright header.
8900
8901 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8902
8903         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8904         Delete.
8905         <operator==>: Update with for removed field.
8906         <hash>: Likewise.
8907         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8908         <isa_features>: ...this.
8909         <abi_features>: New field.
8910         (riscv_isa_flen): Update comment.
8911         (riscv_abi_xlen): New declaration.
8912         (riscv_abi_flen): New declaration.
8913         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8914         isa_features.
8915         (riscv_abi_xlen): New function.
8916         (riscv_isa_flen): Update to get answer from isa_features.
8917         (riscv_abi_flen): New function.
8918         (riscv_has_fp_abi): Update to get answer from abi_features.
8919         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8920         xlen and flen.
8921         (riscv_call_info) <xlen, flen>: Update comment.
8922         (riscv_call_arg_struct): Remove invalid assertions
8923         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8924         is removed.
8925         (riscv_gdbarch_init): Gather isa features and abi features
8926         separately, ensure both match on the gdbarch when reusing an old
8927         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8928         a target with 64-bit float hardware.
8929
8930 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8931
8932         * source.c (search_command_helper): Stop reverse search
8933         when line 1 has been searched.
8934
8935 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8936
8937         * record-full.c (record_full_base_target::close): Rewrite
8938         record_full_core_buf_list free logic.
8939
8940 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8941
8942         * break-catch-syscall.c (print_one_catch_syscall): xfree
8943         the last text.
8944
8945 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8946
8947         * top.c (print_gdb_version): Update Copyright year in version
8948         message.
8949
8950 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8951
8952         Update copyright year range in all GDB files.
8953
8954 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8955
8956         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8957
8958 For older changes see ChangeLog-2018.
8959 \f
8960 Local Variables:
8961 mode: change-log
8962 left-margin: 8
8963 fill-column: 74
8964 version-control: never
8965 coding: utf-8
8966 End:
8967