gdb/ChangeLog

   1 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * dbxread.c (read_dbx_symtab): Update.
   4         * dwarf2read.c (load_partial_dies): Update.
   5         * mdebugread.c (parse_partial_symbols): Update.
   6         (handle_psymbol_enumerators): Update.
   7         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
   8         * psymtab.c (add_psymbol_to_bcache): Likewise.
   9         (add_psymbol_to_list): Likewise.
  10         * symtab.c (symbol_set_names): Likewise.
  11         * symtab.h (symbol_set_names): Likewise.
  12         * xcoffread.c (scan_xcoff_symtab): Update.
  13
  14 2019-09-11  Tom Tromey  <tom@tromey.com>
  15
  16         * symfile-mem.c (symbol_file_add_from_memory): Use
  17         bfd_set_filename.
  18         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
  19         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
  20
  21 2019-09-10  Tom Tromey  <tromey@adacore.com>
  22
  23         * dwarf-index-write.c (write_psymbols): Extend error message.
  24         (debug_names::insert): Add Ada code.
  25         (debug_names::write_psymbols): Remove Ada check.
  26         (debug_names) <m_string_obstack>: New member.
  27         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
  28         (gdb_index_symbol_name_matcher::matches): Remove.
  29         (mapped_index_base::find_name_components_bounds): Add "lang"
  30         parameter.
  31         (mapped_index_base::build_name_components): Also split names
  32         according to Ada syntax.
  33         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
  34         type of "match_callback".
  35         (check_match, check_find_bounds_finds)
  36         (dw2_expand_symtabs_matching): Update.
  37         (dw2_debug_names_iterator): Add new constructor.
  38         (dw2_debug_names_map_matching_symbols): New function.
  39         (dw2_debug_names_expand_symtabs_matching): Update.
  40         (dwarf2_debug_names_functions): Use
  41         dw2_debug_names_map_matching_symbols.
  42
  43 2019-09-10  Tom Tromey  <tromey@adacore.com>
  44
  45         * dwarf2read.c (dw2_get_file_names_reader): Add the
  46         CU's file name to the results.
  47
  48 2019-09-10  Tom Tromey  <tromey@adacore.com>
  49
  50         * ada-lang.c (add_nonlocal_symbols): Combine calls to
  51         map_matching_symbols.  Update.
  52         * dwarf2read.c (dw2_map_matching_symbols): Update.
  53         * psymtab.c (match_partial_symbol): Change type; update.
  54         (psym_map_matching_symbols): Likewise.
  55         * symfile-debug.c (debug_qf_map_matching_symbols): Change
  56         type; update.
  57         * symfile.h (struct quick_symbol_functions)
  58         <map_matching_symbols>: Change "name" to be a lookup_name_info.
  59         Remove "match".
  60
  61 2019-09-10  Tom Tromey  <tromey@adacore.com>
  62
  63         * psymtab.c (map_block): Remove.
  64         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
  65         * symtab.c (iterate_over_symbols_terminated): New function.
  66         * symtab.c (iterate_over_symbols_terminated): Declare.
  67
  68 2019-09-10  Tom Tromey  <tromey@adacore.com>
  69
  70         * ada-lang.c (ada_iterate_over_symbols): Return bool.
  71         * language.h (struct language_defn) <la_iterate_over_symbols>:
  72         Return bool.
  73         * symtab.c (iterate_over_symbols): Return bool.
  74         * symtab.h (iterate_over_symbols): Return bool.
  75
  76 2019-09-10  Tom Tromey  <tromey@adacore.com>
  77
  78         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
  79         (add_nonlocal_symbols): Update.
  80         * dwarf2read.c (dw2_map_matching_symbols): Change type.
  81         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
  82         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
  83         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
  84         Change type of "callback".  Remove "data".
  85
  86
  87 2019-09-09  Ali Tamur  <tamur@google.com>
  88
  89         * dwarf2read.c (comp_unit_head): Update comment.
  90         (dwarf2_dwo_name): New function declaration.
  91         (dwarf_unit_type_name): New function declaration.
  92         (read_comp_unit_head): Add support for new compilation units,
  93         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
  94         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
  95         (currently named as "signature") in their header. Also clarify error
  96         messages.
  97         (lookup_dwo_id): New function. Returns the dwo id of the given
  98         compile unit.
  99         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 100         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 101         functions.
 102         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 103         (dwarf2_dwo_name): Get the dwo name if present.
 104         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 105         purposes.
 106
 107 2019-09-09  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 110
 111 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 112
 113         * python/python.c (do_start_initialization): Make progname_copy static,
 114         to avoid a leak report.
 115
 116 2019-09-08  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 119
 120 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 121
 122         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 123         Change type to gdb::optional<block_enum>.
 124         (dw2_symtab_iter_init): Change block_index parameter type
 125         to gdb::optional<block_enum>.
 126         (dw2_lookup_symbol): Change block_index parameter
 127         type to block_enum.c
 128         (dw2_debug_names_lookup_symbol): Likewise.
 129         * psymtab.c (psym_lookup_symbol): Likewise.
 130         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 131         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 132         Likewise.
 133
 134 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 135
 136         * defs.h (relocate_gdb_directory): Change int to bool in
 137         signature and rename flag to relocatable.
 138         * main.c (relocate_path): Likewise.
 139         (relocate_gdb_directory): Likewise.
 140
 141 2019-09-06  Alan Modra  <amodra@gmail.com>
 142
 143         * coffread.c (coff_symfile_read): Constify filename variable.
 144         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 145         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 146         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 147         * solib.c (reload_shared_libraries_1): Likewise.
 148         * symfile.c (reread_symbols): Likewise.
 149         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 150         * solib-darwin.c (darwin_bfd_open): Likewise.
 151         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 152
 153 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 154
 155         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 156         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 157
 158 2019-09-03  Tom Tromey  <tromey@adacore.com>
 159
 160         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 161         types.
 162         (has_negatives): Unbias a range type bound.
 163         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 164         * gdbtypes.c (operator==): Handle new field.
 165         (create_range_type): Add "bias" parameter.
 166         (create_static_range_type, resolve_dynamic_range): Update.
 167         * gdbtypes.h (struct range_bounds) <bias>: New member.
 168         (create_range_type): Add bias parameter.
 169         * printcmd.c (print_scalar_formatted): Unbias range types.
 170         * value.c (unpack_long): Unbias range types.
 171         (pack_long): Bias range types.
 172
 173 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 174
 175         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 176         probe arguments.
 177
 178 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 179
 180         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 181         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 182         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 183         (compile_probe_arg): Likewise.
 184         * probe.h (get_argument_count): Likewise.
 185         * solib-svr4.c (solib_event_probe_action): Likewise.
 186         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 187
 188 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 189
 190         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 191         code to here...
 192         (svr4_create_solib_event_breakpoints): ...from here.
 193
 194 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 195
 196         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 197         suffix from warning message.
 198
 199 2019-08-30  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui-winsource.h (struct tui_source_window_base)
 202         <refresh_all>: Don't declare.
 203         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 204         Remove.
 205         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 206         tui_show_locator_content.
 207         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 208         declare.
 209         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 210         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 211         declare.
 212
 213 2019-08-30  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 216
 217 2019-08-30  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 220         Remove unnecessary forward declarations.
 221
 222 2019-08-30  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 225         rerender.
 226         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 227         tui_show_locator_content.
 228
 229 2019-08-30  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 232         (tui_locator_window::rerender): Rewrite using body of previous
 233         tui_show_locator_content.
 234
 235 2019-08-30  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 238         set_locator_fullname>: New methods.
 239         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 240         Rename from tui_set_locator_fullname.
 241         (tui_locator_window::set_locator_info): Rename from
 242         tui_set_locator_info.  Return bool.
 243         (tui_update_locator_fullname, tui_show_frame_info): Update.
 244
 245 2019-08-30  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 248
 249 2019-08-30  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 252         call touchwin.
 253
 254 2019-08-30  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-wingeneral.c (box_win): Assume win_info and
 257         win_info->handle cannot be NULL.
 258
 259 2019-08-30  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 262         refresh_window>: Declare.
 263         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 264         resize.
 265         (tui_data_item_window::rerender): Rename from
 266         tui_display_register.
 267         (tui_data_item_window::refresh_window): New method.
 268         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 269         no-op.
 270
 271 2019-08-30  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 274         regs_column_count, current_group>: Move later.  Now private.
 275         <get_current_group>: New method.
 276         * tui/tui-regs.c (tui_reg_command): Update.
 277         * tui/tui-layout.c (tui_set_layout): Update.
 278
 279 2019-08-30  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 282         (tui_data_window::rerender): Don't call
 283         check_and_display_highlight_if_needed.
 284         (tui_data_window::refresh_all): Remove call to
 285         erase_data_content.
 286
 287 2019-08-30  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 290         (tui_data_window::display_registers_from)
 291         (tui_data_window::display_reg_element_at_line)
 292         (tui_data_window::display_registers_from_line): Remove checks of
 293         "empty".
 294
 295 2019-08-30  Tom Tromey  <tom@tromey.com>
 296
 297         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 298         Don't declare.
 299         * tui/tui-regs.c (tui_data_window::show_registers): Call
 300         rerender.
 301         (tui_data_window::rerender): Rename from display_all_data.
 302         (tui_data_window::rerender): Remove old implementation.
 303
 304 2019-08-30  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 307         text.
 308         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 309
 310 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 311             Sergio Durigan Junior  <sergiodj@redhat.com>
 312
 313         PR win32/24284
 314         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 315
 316 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 317
 318         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 319         when searching for types.
 320
 321 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 322
 323         * f-lang.c (f_language_defn): Use f_print_typedef.
 324         * f-lang.h (f_print_typedef): Declare.
 325         * f-typeprint.c (f_print_typedef): Define.
 326
 327 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 328
 329         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 330
 331 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 332
 333         * cli/cli-utils.c (info_print_options_defs): Delete.
 334         (make_info_print_options_def_group): Delete.
 335         (extract_info_print_options): Delete.
 336         (info_print_command_completer): Delete.
 337         (info_print_args_help): Add extra parameter, and optionally
 338         include text about -n flag.
 339         * cli/cli-utils.h (struct info_print_options): Delete.
 340         (extract_info_print_options): Delete declaration.
 341         (info_print_command_completer): Delete declaration.
 342         (info_print_args_help): Add extra parameter, extend header
 343         comment.
 344         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 345         search_symbols.
 346         * stack.c (struct info_print_options): New type.
 347         (info_print_options_defs): New file scoped variable.
 348         (make_info_print_options_def_group): New static function.
 349         (info_print_command_completer): New static function.
 350         (info_locals_command): Update to use new local functions.
 351         (info_args_command): Likewise.
 352         (_initialize_stack): Add extra parameter to calls to
 353         info_print_args_help.
 354         * symtab.c (search_symbols): Add extra parameter, use this to
 355         possibly excluse non-debug symbols.
 356         (symtab_symbol_info): Add extra parameter, which is passed on to
 357         search_symbols.
 358         (struct info_print_options): New type.
 359         (info_print_options_defs): New file scoped variable.
 360         (make_info_print_options_def_group): New static function.
 361         (info_print_command_completer): New static function.
 362         (info_variables_command): Update to use local functions, and pass
 363         extra parameter through to symtab_symbol_info.
 364         (info_functions_command): Likewise.
 365         (info_types_command): Pass additional argument through to
 366         symtab_symbol_info.
 367         (rbreak_command): Pass extra argument to search_symbols.
 368         (_initialize_symtab): Add extra arguments for calls to
 369         info_print_args_help, and update help text for 'info variables',
 370         'whereis', and 'info functions' commands.
 371         * symtab.h (search_symbols): Add extra argument to declaration.
 372         * NEWS: Mention new flags.
 373
 374 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 375
 376         * symtab.c (lookup_static_symbol): Call the new function (and move
 377         it down to be next to lookup_global_symbol).
 378         (struct global_sym_lookup_data): Add block_enum member and rename to...
 379         (struct global_or_static_sym_lookup_data): ...this.
 380         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 381         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 382         (lookup_symbol_global_or_static_iterator_cb): ...this.
 383         (lookup_global_or_static_symbol): New function.
 384         (lookup_global_symbol): Call new function.
 385
 386 2019-08-26  Tom de Vries  <tdevries@suse.de>
 387
 388         PR c++/24852
 389         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 390         when pc_probe.prob == NULL.
 391
 392 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 393
 394         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 395         variable symbol_linkage to symbol_linkage_.
 396
 397 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 398
 399         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 400         represent whether the symbol is static, dynamic, or we don't
 401         know.
 402
 403 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 404
 405         * gdb/rx-tdep.c (rx_register_names): New.
 406         (rx_register_name): Delete.
 407         (rx_psw_type): Delete.
 408         (rx_fpsw_type): Delete.
 409         (rx_register_type): Delete.
 410         (rx_gdbarch_init): Convert target-descriptions.
 411         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 412         * gdb/features/Makefile: Add rx.xml.
 413         * gdb/features/rx.xml: New.
 414         * gdb/features/rx.c: Generated.
 415         * gdb/NEWS: Mention target description support.
 416
 417 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 418
 419         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 420         *slot_ptr.
 421
 422 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 423
 424         * configure.ac: Don't check for 'dlfcn.h' (moved to
 425         gdbsupport/common.m4).
 426         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 427         'gdbsupport/'.
 428         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 429         * compile/compile-c-support.c: Include
 430         'gdbsupport/gdb-dlfcn.h'.
 431         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 432         * gdb-dlfcn.c: Move to...
 433         * gdbsupport/gdb-dlfcn.c: ... here.
 434         * gdb-dlfcn.h: Move to...
 435         * gdbsupport/gdb-dlfcn.h: ... here.
 436
 437 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 438
 439         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 440         the offset field signed.
 441
 442 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 443
 444         * python/lib/gdb/__init__.py (_execute_file): New function.
 445         * python/python.c (python_run_simple_file): Call gdb._execute_file
 446         on Windows.
 447
 448 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 449
 450         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 451         all uses as this was never set to anything but a zero value.
 452
 453 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 454
 455         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 456
 457 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 458
 459         * tui/tui-data.h (tui_gen_win_info): Add an =default
 460         move constructor, required by some GCC versions.
 461
 462 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 463
 464         * go32-nat.c (go32_sysinfo): Add hygon_p.
 465
 466 2019-08-20  Tom Tromey  <tom@tromey.com>
 467
 468         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 469         line_from_reg_element_no, first_reg_element_no_inline,
 470         display_all_data, delete_data_content_windows,
 471         erase_data_content>: Now private.
 472
 473 2019-08-20  Tom Tromey  <tom@tromey.com>
 474
 475         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 476         (tui_unhighlight_win, tui_highlight_win)
 477         (tui_win_info::make_window): Update.
 478         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 479
 480 2019-08-20  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 483         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 484         (MAX_PID_WIDTH): Move to tui-stack.c.
 485         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 486         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 487         (MAX_PID_WIDTH): Move from tui-data.h.
 488
 489 2019-08-20  Tom Tromey  <tom@tromey.com>
 490
 491         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 492         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 493         (box_win): Update.
 494         (tui_gen_win_info::make_window): Rename from tui_make_window.
 495         (tui_win_info::make_window): New method.
 496         (tui_gen_win_info::make_visible): Update.
 497         * tui/tui-source.c (tui_source_window::set_contents): Update.
 498         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 499         (tui_data_window::display_registers_from): Update.
 500         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 501         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 502         Declare.
 503         <can_box>: Remove.
 504         <title>: Remove.
 505         (struct tui_win_info) <make_window>: Declare.
 506         <can_box>: Now virtual.
 507         <title>: New member.
 508         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 509         * tui/tui-command.c (tui_cmd_window::resize): Update.
 510
 511 2019-08-20  Tom Tromey  <tom@tromey.com>
 512
 513         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 514         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 515         (tui_data_window::check_register_values): Update.
 516
 517 2019-08-20  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-regs.h (struct tui_data_window): Use
 520         DISABLE_COPY_AND_ASSIGN.
 521         <regs_content>: Change type, removing unique_ptr.
 522         <tui_data_window>: Add move constructor.
 523         * tui/tui-regs.c (tui_data_window::show_registers)
 524         (tui_data_window::show_register_group)
 525         (tui_data_window::display_registers_from)
 526         (tui_data_window::display_registers_from)
 527         (tui_data_window::first_data_item_displayed)
 528         (tui_data_window::delete_data_content_windows)
 529         (tui_data_window::rerender, tui_data_window::refresh_window)
 530         (tui_data_window::check_register_values): Update.
 531
 532 2019-08-20  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 535         show_register_group>: Declare.
 536         (tui_show_register_group): Don't declare.
 537         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 538         tui_show_registers.
 539         (tui_data_window::show_register_group): Rename from
 540         tui_show_register_group.
 541         (tui_data_window::check_register_values, tui_reg_command):
 542         Update.
 543         * tui/tui-layout.c (tui_set_layout): Update.
 544
 545 2019-08-20  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 548         Declare.
 549         (tui_check_register_values): Don't declare.
 550         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 551         from tui_check_register_values.
 552         * tui/tui-hooks.c (tui_register_changed): Update.
 553
 554 2019-08-20  Tom Tromey  <tom@tromey.com>
 555
 556         * tui/tui-regs.c (tui_reg_layout): Move later.
 557         (tui_show_registers): Don't enable TUI mode or change layout.
 558
 559 2019-08-20  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-regs.h (struct tui_data_item_window)
 562         <~tui_data_item_window>: Remove.
 563         <content>: Now a unique_xmalloc_ptr.
 564         * tui/tui-regs.c (tui_register_format): Return a
 565         unique_xmalloc_ptr.
 566         (tui_get_register): Update.
 567         (~tui_data_item_window): Remove.
 568         (tui_data_window::display_registers_from, tui_display_register):
 569         Update.
 570         * tui/tui-io.h (tui_expand_tabs): Update.
 571         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 572         Remove "col" parameter.
 573
 574 2019-08-20  Tom Tromey  <tom@tromey.com>
 575
 576         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 577         field.
 578         * tui/tui-regs.c (~tui_data_item_window): Update.
 579
 580 2019-08-20  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 583         earlier.
 584
 585 2019-08-20  Tom Tromey  <tom@tromey.com>
 586
 587         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 588
 589 2019-08-20  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-source.h (struct tui_source_window): Update.
 592         * tui/tui-regs.c (tui_show_registers): Update.
 593         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 594         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 595         (NO_REGS_STRING): Remove defines.
 596
 597 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 598
 599         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 600         unnecessary thread walk if remote doesn't support the packet.
 601
 602 2019-08-19  Tom Tromey  <tromey@adacore.com>
 603
 604         * python/py-value.c (value_has_field): Fix indentation.
 605
 606 2019-08-19  Tom Tromey  <tromey@adacore.com>
 607
 608         * printcmd.c (do_one_display, info_display_command): Update.
 609         * block.h (contained_in): Return bool.  Add allow_nested
 610         parameter.
 611         * block.c (contained_in): Return bool.  Add allow_nested
 612         parameter.
 613
 614 2019-08-19  Tom Tromey  <tom@tromey.com>
 615
 616         * configure: Rebuild.
 617         * configure.ac: Disallow the combination of -static-libstdc++ and
 618         source highlight.
 619         * source-cache.c (get_language_name): Handle rust.
 620         (source_cache::get_source_lines): Ignore highlighting exceptions.
 621
 622 2019-08-16  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 625         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 626         (struct tui_source_window_base) <make_visible, refresh_window,
 627         resize>: Remove methods.
 628         <execution_info>: Remove field.
 629         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 630         (tui_show_source_line, tui_source_window_base)
 631         (~tui_source_window_base): Update.
 632         (tui_source_window_base::resize)
 633         (tui_source_window_base::make_visible)
 634         (tui_source_window_base::refresh_window): Remove.
 635         (tui_source_window_base::update_exec_info): Update.
 636         * tui/tui-source.c (tui_source_window::set_contents): Update.
 637         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 638
 639 2019-08-16  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 642         deprecated_query_hook.
 643
 644 2019-08-16  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 647         (tui_update_source_windows_with_line): Update.
 648         * tui/tui-source.h (struct tui_source_window)
 649         <show_symtab_source>: Declare.
 650         (tui_show_symtab_source): Don't declare.
 651         * tui/tui-source.c (tui_show_symtab_source): Rename from
 652         tui_show_symtab_source.
 653
 654 2019-08-16  Tom Tromey  <tom@tromey.com>
 655
 656         * tui/tui-winsource.h (struct tui_source_window_base)
 657         <set_contents>: Declare.
 658         * tui/tui-winsource.c
 659         (tui_source_window_base::update_source_window_as_is): Update.
 660         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 661         Declare.
 662         (tui_set_source_content): Don't declare.
 663         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 664         tui_set_source_content.
 665         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 666         Declare.
 667         (tui_set_disassem_content): Don't declare.
 668         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 669         tui_set_disassem_content.
 670
 671 2019-08-16  Tom Tromey  <tom@tromey.com>
 672
 673         * tui/tui-winsource.h (struct tui_source_window_base)
 674         <update_breakpoint_info>: Declare.
 675         (tui_update_breakpoint_info): Don't declare.
 676         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 677         (tui_update_all_breakpoint_info): Update.
 678         (tui_source_window_base::update_breakpoint_info): Rename from
 679         tui_update_breakpoint_info.
 680         (tui_source_window_base::update_exec_info): Update.
 681
 682 2019-08-16  Tom Tromey  <tom@tromey.com>
 683
 684         * tui/tui-winsource.h (struct tui_source_window_base)
 685         <update_source_window>: Declare.
 686         (tui_update_source_window): Don't declare.
 687         * tui/tui-winsource.c
 688         (tui_source_window_base::update_source_window): Rename from
 689         tui_update_source_window.
 690         (tui_source_window_base::rerender): Update.
 691         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 692         * tui/tui-disasm.c (tui_show_disassem)
 693         (tui_show_disassem_and_update_source)
 694         (tui_disasm_window::maybe_update): Update.
 695
 696 2019-08-16  Tom Tromey  <tom@tromey.com>
 697
 698         * tui/tui-winsource.h (struct tui_source_window_base)
 699         <update_source_window_as_is>: Declare.
 700         (tui_update_source_window_as_is): Don't declare.
 701         * tui/tui-winsource.c (tui_update_source_window): Update
 702         (tui_source_window_base::update_source_window_as_is): Rename from
 703         tui_update_source_window_as_is.
 704         (tui_source_window_base::refill): Update.
 705         * tui/tui-source.c (tui_show_symtab_source): Update.
 706         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 707         Update.
 708
 709 2019-08-16  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-winsource.h (tui_update_source_window)
 712         (tui_update_source_window_as_is): Remove "noerror" parameter.
 713         * tui/tui-winsource.c (tui_update_source_window)
 714         (tui_update_source_window_as_is): Remove "noerror" parameter.
 715         (tui_update_source_windows_with_addr)
 716         (tui_update_source_windows_with_line)
 717         (tui_source_window_base::rerender)
 718         (tui_source_window_base::refill): Update.
 719         * tui/tui-source.h (tui_set_source_content)
 720         (tui_show_symtab_source): Remove "noerror" parameter.
 721         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 722         parameter.
 723         (tui_show_symtab_source): Likewise.
 724         (tui_source_window::maybe_update): Update.
 725         * tui/tui-disasm.c (tui_show_disassem)
 726         (tui_show_disassem_and_update_source)
 727         (tui_disasm_window::do_scroll_vertical)
 728         (tui_disasm_window::maybe_update): Update.
 729
 730 2019-08-16  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui.c (tui_is_window_visible): Update.
 733         * tui/tui-wingeneral.c (tui_make_window)
 734         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 735         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 736         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 737         (tui_set_win_height_command, parse_scrolling_args): Update.
 738         * tui/tui-source.c (tui_source_window::style_changed): Update.
 739         * tui/tui-regs.c (tui_show_registers)
 740         (tui_data_window::first_data_item_displayed)
 741         (tui_data_window::delete_data_content_windows)
 742         (tui_check_register_values, tui_reg_command): Update.
 743         * tui/tui-disasm.c (tui_show_disassem): Update.
 744         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 745         method.
 746         <is_visible>: Remove field.
 747         * tui/tui-data.c (tui_next_win, tui_prev_win)
 748         (tui_delete_invisible_windows): Update.
 749
 750 2019-08-16  Tom Tromey  <tom@tromey.com>
 751
 752         * tui/tui-winsource.h (struct tui_source_window_base)
 753         <m_has_locator>: Remove.
 754         * tui/tui-layout.c (show_source_disasm_command, show_data)
 755         (show_source_or_disasm_and_command): Update.
 756
 757 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 758
 759         * NEWS (Other MI changes): New subsection.
 760         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 761         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 762         * arch-utils.c (default_get_pc_address_flags): New function.
 763         * arch-utils.h (default_get_pc_address_flags): New declaration.
 764         * gdbarch.sh: Add get_pc_address_flags.
 765         * gdbarch.c: Regenerate.
 766         * gdbarch.h: Likewise.
 767         * stack.c (print_pc): New function.
 768         (print_frame_info) (print_frame): Call print_pc.
 769
 770 2019-08-16  Tom de Vries  <tdevries@suse.de>
 771
 772         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 773         print_objfile_section_info.
 774
 775 2019-08-15  Tom Tromey  <tom@tromey.com>
 776
 777         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 778         calling update_cmdwin_start_line.
 779         * tui/tui-winsource.h (struct tui_source_window_base)
 780         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 781         <rerender>: Declare.
 782         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 783         Call rerender.
 784         (tui_source_window_base::set_new_height): Remove.
 785         (tui_source_window_base::rerender): Rename from
 786         do_make_visible_with_new_height.
 787         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 788         resize method.
 789         (tui_win_info::make_invisible_and_set_new_height)
 790         (tui_win_info::make_visible_with_new_height): Remove.
 791         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 792         Declare.
 793         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 794         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 795         do_make_visible_with_new_height>: Don't declare.
 796         <rerender>: Declare.
 797         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 798         set_new_height.
 799         (tui_data_window::do_make_visible_with_new_height): Remove.
 800         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 801         call tui_show_locator_content.
 802         (tui_gen_win_info::resize): Call rerender.
 803         (show_source_or_disasm_and_command): Don't call
 804         tui_show_locator_content.
 805         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 806         method.
 807         (struct tui_win_info) <rerender>: Declare.
 808         <set_new_height, make_invisible_and_set_new_height,
 809         make_visible_with_new_height>: Don't declare.
 810         * tui/tui-data.c (tui_win_list::rerender): New method.
 811         * tui/tui-command.h (struct tui_cmd_window)
 812         <do_make_visible_with_new_height>: Don't declare.
 813         * tui/tui-command.c
 814         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 815
 816 2019-08-15  Tom Tromey  <tromey@adacore.com>
 817
 818         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 819         * ada-lang.c (ada_enum_name): Likewise.
 820
 821 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 822
 823         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 824         leading underscore.
 825         (GdbOutputErrorFile): Likewise.
 826         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 827         accordingly.
 828         (execute_unwinders): Rename to have a leading underscore.
 829         (auto_load_packages): Likewise.
 830         (global scope): Adjust call to auto_load_packages accordingly.
 831         (GdbSetPythonDirectory): Likewise.
 832         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 833         instead of execute_unwinders.
 834
 835 2019-08-15  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 838         (show_data): Don't change window visibility.
 839         (tui_gen_win_info::resize): Remove special case for command
 840         window.  Use wresize, when available.
 841         (show_source_or_disasm_and_command): Don't change window
 842         visibility.
 843         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 844         <make_visible>: New method.
 845         * tui/tui-command.c (tui_cmd_window::resize): New method.
 846
 847 2019-08-15  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 850         (struct tui_source_windows): New.
 851         * tui/tui-winsource.c (tui_display_main): Update.
 852         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 853         (new_height_ok, parse_scrolling_args): Update.
 854         * tui/tui-layout.c (show_layout, show_data): Update.
 855         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 856         (tui_add_to_source_windows): Don't declare.
 857         * tui/tui-data.c (source_windows, tui_source_windows)
 858         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 859
 860 2019-08-15  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 863         Rename from reset.
 864         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 865         * tui/tui-layout.c (show_source_disasm_command, show_data):
 866         Update.
 867         (tui_gen_win_info::resize): Rename.
 868         (show_source_or_disasm_and_command): Update.
 869         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 870         reset.
 871
 872 2019-08-15  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 875         * tui/tui-interp.c (tui_interp::init): Don't call
 876         tui_initialize_static_data.
 877         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 878
 879 2019-08-15  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 882         examine tui_win_list.
 883
 884 2019-08-15  Tom Tromey  <tom@tromey.com>
 885
 886         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 887         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 888         tui_clear_source_content.
 889         (tui_clear_source_content): Remove.
 890         (tui_source_window_base::do_erase_source_content): Hoist call to
 891         content.clear().
 892         * tui/tui-stack.c (tui_show_frame_info): Don't call
 893         tui_clear_source_content.
 894
 895 2019-08-15  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-winsource.h (struct tui_source_window_base)
 898         <do_erase_source_content>: New method.
 899         <erase_source_content>: New method.
 900         (tui_erase_source_content): Don't declare.
 901         * tui/tui-winsource.c (tui_clear_source_content): Update.
 902         (tui_source_window_base::do_erase_source_content): Rename from
 903         tui_erase_source_content.
 904         (tui_source_window_base::show_source_content): Update.
 905         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 906         * tui/tui-source.h (struct tui_source_window)
 907         <erase_source_content>: New method.
 908         * tui/tui-disasm.h (struct tui_disasm_window)
 909         <erase_source_content>: New method.
 910
 911 2019-08-15  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 914         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 915         constructor.
 916         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 917         * tui/tui-source.c (tui_set_source_content): Update.
 918         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 919
 920 2019-08-15  Tom Tromey  <tom@tromey.com>
 921
 922         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 923         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 924         tui-source.c.
 925         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 926         Declare.
 927         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 928         method.
 929         (tui_source_window::maybe_update): Update.
 930
 931 2019-08-15  Tom Tromey  <tom@tromey.com>
 932
 933         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 934         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 935         tui-disasm.c.
 936         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 937         Declare.
 938         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 939         method.
 940         (tui_disasm_window::maybe_update): Update.
 941
 942 2019-08-15  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-winsource.h (struct tui_source_window_base)
 945         <maybe_update>: Declare.
 946         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 947         method.
 948         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 949         Declare.
 950         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 951         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 952         Declare.
 953         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 954
 955 2019-08-15  Tom Tromey  <tom@tromey.com>
 956
 957         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 958
 959 2019-08-15  Tom Tromey  <tom@tromey.com>
 960
 961         * tui/tui-wingeneral.c: Include tui-stack.h.
 962         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 963         (struct tui_locator_window): Move from tui-data.h.
 964         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 965         (tui_initialize_static_data): Move from tui-data.c.
 966         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 967         (struct tui_locator_window): Move to tui-stack.c.
 968         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 969         (tui_initialize_static_data): Move to tui-stack.c.
 970
 971 2019-08-15  Tom Tromey  <tom@tromey.com>
 972
 973         * tui/tui-layout.c (show_source_disasm_command)
 974         (show_source_or_disasm_and_command): Use make_visible method, not
 975         tui_make_window.
 976         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 977         Remove.
 978
 979 2019-08-15  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-wingeneral.h (tui_make_window): Update.
 982         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 983         parameter.
 984         (tui_gen_win_info::make_visible): Update.
 985         * tui/tui-regs.c (tui_data_window::display_registers_from):
 986         Update.
 987         * tui/tui-layout.c (show_source_disasm_command)
 988         (show_source_or_disasm_and_command): Update.
 989         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 990         (enum tui_box): Remove.
 991         (struct tui_win_info) <can_box>: New method.
 992         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 993         method.
 994
 995 2019-08-15  Tom de Vries  <tdevries@suse.de>
 996
 997         * linux-nat-trad.c: Include gdbarch.h.
 998
 999 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1000
1001         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1002         register sizes.
1003
1004 2019-08-14  Tom Tromey  <tromey@adacore.com>
1005
1006         * darwin-nat.c: Include gdbarch.h.
1007         * darwin-nat-info.c: Include gdbarch.h.
1008
1009 2019-08-13  Tom Tromey  <tom@tromey.com>
1010
1011         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1012         Remove.
1013         * tui/tui-data.c (tui_initialize_static_data): Update.
1014
1015 2019-08-13  Tom Tromey  <tom@tromey.com>
1016
1017         * tui/tui-winsource.h (struct tui_exec_info_window)
1018         <~tui_exec_info_window, maybe_allocate_content, get_content,
1019         m_content>: Remove.
1020         (struct tui_source_window_base) <set_exec_info_content,
1021         show_exec_info_content>: Don't declare.
1022         * tui/tui-winsource.c
1023         (tui_exec_info_window::maybe_allocate_content): Remove.
1024         (tui_source_window_base::update_exec_info): Rename from
1025         set_exec_info_content.
1026         (tui_source_window_base::show_exec_info_content)
1027         (tui_source_window_base::update_exec_info): Remove.
1028
1029 2019-08-13  Tom Tromey  <tom@tromey.com>
1030
1031         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1032         declare.
1033         * tui/tui-winsource.c (tui_update_source_window_as_is)
1034         (tui_update_source_windows_with_addr, tui_erase_source_content):
1035         Update.
1036         (tui_clear_exec_info_content): Remove.
1037
1038 2019-08-13  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1041         declare.
1042         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1043         call tui_erase_exec_info_content.
1044         (tui_clear_exec_info_content): Rename from
1045         tui_erase_exec_info_content.
1046         (tui_clear_exec_info_content): Delete.
1047
1048 2019-08-13  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-winsource.h (struct tui_source_window_base)
1051         <show_exec_info_content>: Declare.
1052         (tui_show_exec_info_content): Don't declare.
1053         * tui/tui-winsource.c
1054         (tui_source_window_base::show_exec_info_content): Rename from
1055         tui_show_exec_info_content.
1056         (tui_source_window_base::update_exec_info): Update.
1057
1058 2019-08-13  Tom Tromey  <tom@tromey.com>
1059
1060         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1061         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1062         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1063         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1064         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1065         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1066         ... here.
1067
1068 2019-08-13  Tom Tromey  <tom@tromey.com>
1069
1070         * tui/tui-winsource.h (struct tui_source_window_base)
1071         <update_exec_info>: Declare.
1072         (tui_update_exec_info): Don't declare.
1073         * tui/tui-winsource.c (tui_update_source_window_as_is)
1074         (tui_source_window_base::refresh_all)
1075         (tui_update_all_breakpoint_info): Update.
1076         (tui_source_window_base::update_exec_info): Rename from
1077         tui_update_exec_info.
1078         * tui/tui-stack.c (tui_show_frame_info): Update.
1079
1080 2019-08-13  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui-winsource.h (struct tui_source_window_base)
1083         <set_exec_info_content>: Declare.
1084         (tui_set_exec_info_content): Don't declare.
1085         * tui/tui-winsource.c
1086         (tui_source_window_base::set_exec_info_content): Rename from
1087         tui_set_exec_info_content.
1088         (tui_update_exec_info): Update.
1089
1090 2019-08-13  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui-winsource.h (struct tui_source_window_base)
1093         <show_source_content>: Declare.
1094         (tui_show_source_content): Don't declare.
1095         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1096         (tui_source_window_base::show_source_content): Rename from
1097         tui_show_source_content.
1098         (tui_source_window_base::refresh_all): Update.
1099         * tui/tui-layout.c (show_source_disasm_command)
1100         (show_source_or_disasm_and_command): Update.
1101
1102 2019-08-13  Tom Tromey  <tom@tromey.com>
1103
1104         * tui/tui-winsource.c (tui_erase_source_content)
1105         (tui_show_source_content, tui_source_window_base::refresh_all):
1106         Update.
1107         * tui/tui-wingeneral.h
1108         (tui_check_and_display_highlight_if_needed): Don't declare.
1109         * tui/tui-wingeneral.c
1110         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1111         check_and_display_highlight_if_needed.
1112         * tui/tui-win.c (tui_rehighlight_all)
1113         (tui_win_info::make_visible_with_new_height): Update.
1114         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1115         (tui_data_window::erase_data_content)
1116         (tui_data_window::display_all_data): Update.
1117         * tui/tui-data.h (struct tui_win_info)
1118         <check_and_display_highlight_if_needed>: Declare.
1119
1120 2019-08-13  Tom Tromey  <tom@tromey.com>
1121
1122         * tui/tui-win.c (tui_resize_all): Call
1123         tui_delete_invisible_windows.
1124         * tui/tui-layout.c (show_layout): Call
1125         tui_delete_invisible_windows.
1126         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1127         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1128
1129 2019-08-13  Tom Tromey  <tom@tromey.com>
1130
1131         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1132         tui_add_win_to_layout.
1133
1134 2019-08-13  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1137         * tui/tui-layout.c (tui_default_win_height): Now static.
1138
1139 2019-08-13  Tom Tromey  <tom@tromey.com>
1140
1141         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1142         single switch.
1143         (show_source_disasm_command, show_source_or_disasm_and_command):
1144         Don't check current layout.
1145
1146 2019-08-13  Tom Tromey  <tom@tromey.com>
1147
1148         * tui/tui-wingeneral.c (make_all_visible): Remove.
1149         (tui_make_all_invisible): Simplify.
1150         * tui/tui-layout.c (tui_make_all_invisible): Move from
1151         tui-wingeneral.c; simplify.
1152         (show_layout): Hoist call to tui_make_all_invisible.
1153         (show_data): Don't call tui_make_all_invisible.
1154
1155 2019-08-13  Tom Tromey  <tom@tromey.com>
1156
1157         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1158         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1159
1160 2019-08-13  Tom Tromey  <tom@tromey.com>
1161
1162         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1163         tui-data.c.
1164         (show_source_disasm_command, show_data)
1165         (show_source_or_disasm_and_command): Don't use
1166         tui_set_current_layout_to.
1167         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1168         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1169         tui-layout.c.
1170         (tui_set_current_layout_to): Remove.
1171
1172 2019-08-13  Tom Tromey  <tom@tromey.com>
1173
1174         * tui/tui-layout.c (tui_set_layout): Update.
1175         * tui/tui-data.h (struct tui_layout_def): Remove.
1176         (tui_layout_def): Don't declare.
1177         * tui/tui-data.c (layout_def): Remove.
1178         (tui_layout_def): Remove.
1179
1180 2019-08-13  Tom Tromey  <tom@tromey.com>
1181
1182         * tui/tui-winsource.h (struct tui_source_window_base)
1183         <clear_detail>: No longer "override".
1184         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1185         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1186         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1187         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1188         Remove.
1189         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1190
1191 2019-08-13  Tom Tromey  <tromey@adacore.com>
1192
1193         * tracepoint.c: Don't include readline.h or history.h.
1194
1195 2019-08-12  Tom Tromey  <tom@tromey.com>
1196
1197         * configure: Rebuild.
1198         * configure.ac: Check for readline 7.
1199         * NEWS: Mention readline 7 requirement.
1200         * README: Update.
1201
1202 2019-08-12  Tom Tromey  <tom@tromey.com>
1203
1204         * mingw-hdep.c (gdb_select): Remove readline hack.
1205
1206 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1207
1208         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1209         when the function fails.
1210
1211 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1212
1213         * s390-tdep.c (s390_type_align): New function.
1214         (s390_gdbarch_init): Set it as type_align gdbarch method.
1215
1216 2019-08-09  Tom de Vries  <tdevries@suse.de>
1217
1218         PR gdb/24591
1219         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1220         pc_low with relocation offset.
1221
1222 2019-08-07  Tom Tromey  <tromey@adacore.com>
1223
1224         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1225         (print_frame_args): Update.
1226         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1227         Update.
1228         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1229         * frame.h (struct frame_arg): Add initializers.
1230         <error>: Now a unique_xmalloc_ptr.
1231
1232 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1233
1234         * NEWS: Expand the Pointer Authentication entry.
1235         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1236         (aarch64_frame_unmask_lr): ... to this.
1237         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1238         Call aarch64_frame_unmask_lr.
1239         * frame.c (struct frame_info): Add "masked" variable.
1240         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1241         (fprint_frame): Check for masked pc.
1242         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1243         declarations.
1244         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1245         * stack.c (print_frame): Check for masked pc.
1246
1247 2019-08-06  Tom Tromey  <tom@tromey.com>
1248
1249         * stabsread.c (patch_block_stabs, read_one_struct_field)
1250         (read_enum_type): Use obstack_strndup.
1251         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1252         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1253         * dwarf2read.c (guess_full_die_structure_name)
1254         (anonymous_struct_prefix): Use obstack_strndup.
1255         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1256         * c-exp.y (yylex): Use obstack_strndup.
1257         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1258         (write_var_or_type): Use obstack_strndup.
1259
1260 2019-08-06  Tom Tromey  <tom@tromey.com>
1261
1262         * symfile.c (reread_symbols): Use obstack_strdup.
1263         * stabsread.c (read_type): Use obstack_strdup.
1264         * gdb_obstack.h (obstack_strdup): New overload.
1265         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1266         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1267         (dwarf2_canonicalize_name): Use obstack_strdup.
1268         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1269         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1270         Use obstack_strdup.
1271
1272 2019-08-06  Tom Tromey  <tom@tromey.com>
1273
1274         * gdb_obstack.h (obstack_strdup): Define.
1275         * gdb_obstack.c (obstack_strdup): Don't define.
1276
1277 2019-08-06  Tom Tromey  <tom@tromey.com>
1278
1279         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1280         obstack_strdup.
1281         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1282         obstack_strdup.
1283         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1284         * stabsread.c (common_block_start): Use obstack_strdup.
1285         * objfiles.c (set_objfile_main_name, objfile): Use
1286         obstack_strdup.
1287         * namespace.c (add_using_directive): Use obstack_strdup.
1288         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1289         * jit.c (finalize_symtab): Use obstack_strdup.
1290         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1291         (guess_partial_die_structure_name, partial_die_info::fixup)
1292         (dwarf2_name): Use obstack_strdup.
1293         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1294         obstack_strdup.
1295         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1296         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1297         obstack_strdup.
1298         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1299
1300 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1301
1302         * unittests/help-doc-selftests.c: New file.
1303         * Makefile.in: Add the new file.
1304
1305 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1306
1307         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1308         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1309         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1310         the trailing '.' is not output, and the first character is uppercased.
1311         (print_help_for_command): Update call to print_doc_line.
1312         (print_doc_of_command): Likewise.
1313         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1314         * cli/cli-option.c (append_indented_doc): Do not append newline.
1315         (build_help_option): Append newline after first appended_indented_doc
1316         only if a second call is done.
1317         (build_help): Append 2 new lines before each option, except the first
1318         one.
1319         * compile/compile.c (_initialize_compile): Add new lines after
1320         %OPTIONS%, when not at the end of the help.
1321         Change help doc or code
1322         producing the help doc to respect the invariants.
1323         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1324         Also removed the new line after 'Options:', as all other commands
1325         do not put an empty line between 'Options:' and the first option.
1326         * printcmd.c (_initialize_printcmd): Likewise.
1327         * stack.c (_initialize_stack): Likewise.
1328         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1329         incorrectly telling COMMAND is optional.
1330         * ada-lang.c (_initialize_ada_language): Change help doc or code
1331         producing the help doc to respect the invariants.
1332         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1333         * breakpoint.c (_initialize_breakpoint): Likewise.
1334         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1335         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1336         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1337         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1338         _initialize_cli_style): Likewise.
1339         * corelow.c (core_target_info): Likewise.
1340         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1341         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1342         * filesystem.c (_initialize_filesystem): Likewise.
1343         * frame.c (_initialize_frame): Likewise.
1344         * gnu-nat.c (add_task_commands): Likewise.
1345         * infcall.c (_initialize_infcall): Likewise.
1346         * infcmd.c (_initialize_infcmd): Likewise.
1347         * interps.c (_initialize_interpreter): Likewise.
1348         * language.c (_initialize_language): Likewise.
1349         * linux-fork.c (_initialize_linux_fork): Likewise.
1350         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1351         * maint.c (_initialize_maint_cmds): Likewise.
1352         * memattr.c (_initialize_mem): Likewise.
1353         * printcmd.c (_initialize_printcmd): Likewise.
1354         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1355         _RegEx): Likewise.
1356         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1357         * record-btrace.c (_initialize_record_btrace): Likewise.
1358         * record-full.c (_initialize_record_full): Likewise.
1359         * record.c (_initialize_record): Likewise.
1360         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1361         * regcache.c (_initialize_regcache): Likewise.
1362         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1363         _initialize_remote): Likewise.
1364         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1365         * serial.c (_initialize_serial): Likewise.
1366         * skip.c (_initialize_step_skip): Likewise.
1367         * source.c (_initialize_source): Likewise.
1368         * stack.c (_initialize_stack): Likewise.
1369         * symfile.c (_initialize_symfile): Likewise.
1370         * symtab.c (_initialize_symtab): Likewise.
1371         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1372         * top.c (init_main): Likewise.
1373         * tracefile-tfile.c (tfile_target_info): Likewise.
1374         * tracepoint.c (_initialize_tracepoint): Likewise.
1375         * tui/tui-win.c (_initialize_tui_win): Likewise.
1376         * utils.c (add_internal_problem_command): Likewise.
1377         * valprint.c (value_print_option_defs): Likewise.
1378
1379 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1380
1381         PR build/24886
1382         * configure.ac: Drop enable-libmcheck support.
1383         * configure, config.in: Rebuild.
1384         * libmcheck.m4: Remove.
1385         * acinclude.m4: Don't include it.
1386         * Makefile.in: Don't distribute it.
1387         * top.c (print_gdb_configuration): Don't mention it.
1388
1389 2019-08-06  Tom Tromey  <tom@tromey.com>
1390
1391         * utils.c (set_output_style): Sometimes pass stream to
1392         emit_style_escape.
1393         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1394         * record-btrace.c (btrace_insn_history): Update.
1395         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1396         method.
1397         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1398         Update initializers.
1399         <m_uiout>: New field.
1400         <m_di>: Move lower.
1401         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1402         Remove "uiout" parameter.
1403         (dump_insns): Update.
1404         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1405         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1406
1407 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1408
1409         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1410         (error_in_psymtab_expansion): Likewise.
1411         (lookup_symbol_via_quick_fns): Likewise.
1412         (basic_lookup_transparent_type_quick): Likewise.
1413         (basic_lookup_transparent_type_1): Likewise.
1414
1415 2019-08-06  Tom Tromey  <tromey@adacore.com>
1416
1417         * source.c (last_source_error): Now bool.
1418         (print_source_lines_base): Make "noprint" bool.  Only open
1419         source file when last_source_visited changes.
1420
1421 2019-08-06  Tom Tromey  <tromey@adacore.com>
1422
1423         * annotate.c (annotate_source_line): Use g_source_cache.
1424         * source-cache.c (source_cache::get_plain_source_lines): Change
1425         parameters.  Populate m_offset_cache.
1426         (source_cache::ensure): New method.
1427         (source_cache::get_line_charpos): New method.
1428         (extract_lines): Move lower.  Change parameters.
1429         (source_cache::get_source_lines): Move lower.
1430         * source-cache.h (class source_cache): Update comment.
1431         <get_line_charpos>: New method.
1432         <get_source_lines>: Update comment.
1433         <clear>: Clear m_offset_cache.
1434         <get_plain_source_lines>: Change parameters.
1435         <ensure>: New method
1436         <m_offset_cache>: New member.
1437         * source.c (forget_cached_source_info_for_objfile): Update.
1438         (info_source_command): Use g_source_cache.
1439         (find_source_lines, open_source_file_with_line_charpos): Remove.
1440         (print_source_lines_base, search_command_helper): Use g_source_cache.
1441         * source.h (open_source_file_with_line_charpos): Don't declare.
1442         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1443         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1444         Use g_source_cache.
1445
1446 2019-08-06  Tom Tromey  <tromey@adacore.com>
1447
1448         * source-cache.c (source_cache::get_plain_source_lines):
1449         Remove "first_line" and "last_line" parameters.
1450         (source_cache::get_source_lines): Cache plain text.
1451         * source-cache.h (class source_cache)
1452         <get_plain_source_lines>: Update.
1453
1454 2019-08-06  Tom Tromey  <tromey@adacore.com>
1455
1456         * source-cache.c (extract_lines): No longer a method.
1457         Changed type of parameter.  Include final newline.
1458         (selftests::extract_lines_test): New function.
1459         (_initialize_source_cache): Likewise.
1460         * source-cache.h (class source_cache)
1461         <extract_lines>: Don't declare.
1462
1463 2019-08-06  Tom Tromey  <tromey@adacore.com>
1464
1465         * breakpoint.c (init_breakpoint_sal): Update.
1466         (breakpoint): Update.
1467         * breakpoint.h (struct breakpoint) <filter>: Now a
1468         unique_xmalloc_ptr.
1469
1470 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1471
1472         * NEWS: Mention dictionary access on blocks.
1473         * python/py-block.c (blpy_getitem): New function.
1474         (block_object_as_mapping): New struct.
1475         (block_object_type): Use new struct for tp_as_mapping field.
1476
1477 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1478
1479         * objfiles.h (objfile): Add a comment describing partial symbols.
1480
1481 2019-08-05  Tom Tromey  <tromey@adacore.com>
1482
1483         * compile/compile.c (_initialize_compile): Use _(), not N_().
1484         * thread.c (_initialize_thread): Use _(), not N_().
1485         * stack.c (_initialize_stack): Use _(), not N_().
1486         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1487
1488 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1489
1490         * dwarf2read.c (struct dw2_symtab_iterator):
1491         <want_specific_block>: Remove.
1492         <block_index>: Change type to gdb::optional.
1493         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1494         change type of BLOCK_INDEX parameter to gdb::optional.
1495         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1496         (dw2_lookup_symbol): Don't pass argument for
1497         WANT_SPECIFIC_BLOCK.
1498         (dw2_expand_symtabs_for_function): Don't pass argument for
1499         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1500         (class dw2_debug_names_iterator)
1501         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1502         parameter, change BLOCK_INDEX type to gdb::optional.
1503         <m_want_specific_block>: Remove.
1504         <m_block_index>: Change type to gdb::optional.
1505         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1506         gdb::optional.  Re-write in function of gdb::optional.
1507         (dw2_debug_names_lookup_symbol): Don't pass argument for
1508         WANT_SPECIFIC_BLOCK.
1509         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1510         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1511         BLOCK_INDEX.
1512
1513 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1514
1515         * NEWS: Mention changes to "info sources" command.
1516
1517 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1518
1519         * symtab.c (filename_partial_match_opts): New struct type.
1520         (struct output_source_filename_data): New members
1521         regexp, c_regexp, partial_match.
1522         (output_source_filename): Use new members to decide to print file.
1523         (info_sources_option_defs): New variable.
1524         (make_info_sources_options_def_group, print_info_sources_header,
1525         info_sources_command_completer):
1526         New functions.
1527         (info_sources_command): Read new optional arguments.
1528         (_initialize_symtab): Update info sources help.
1529
1530 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1531
1532         * ada-lang.c (exception_support_info_v0): Renamed from...
1533         (default_exception_support_info): ... this.  Create new
1534         definition for v1.
1535         (ada_has_this_exception_support): Look up catch_handlers_sym.
1536         (ada_exception_support_info_sniffer): Try v0 after default.
1537
1538 2019-08-01  Tom Tromey  <tromey@adacore.com>
1539
1540         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1541         gdbarch.h.
1542
1543 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1544
1545         * s12z-tdep.c: Fix include path for s12z-opc.h.
1546
1547 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1548
1549         * NEWS: Require GNU make 3.82.
1550
1551 2019-07-16  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1554         declare.
1555
1556 2019-07-30  Tom Tromey  <tromey@adacore.com>
1557
1558         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1559
1560 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1561
1562         * printcmd.c (print_address_symbolic): Print negative offsets.
1563         (build_address_symbolic): Force signed arithmetic when computing
1564         offset.
1565
1566 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1567
1568         PR/24474: Add a function to lookup static variables.
1569         * NEWS: Mention this new function.
1570         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1571         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1572         * python/python.c (python_GdbMethods): Add new function.
1573
1574 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1575
1576         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1577         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1578         (objfpy_lookup_static_symbol): New function.
1579         (objfile_object_methods): Add new functions.
1580
1581 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1582
1583         * NEWS: Mention 'set|show print frame-info'.  Mention new
1584         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1585         backtrace argument.  Mention that python frame filtering code
1586         is now consistent with what 'backtrace' command prints.
1587
1588 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1589
1590         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1591         comments.
1592         (print_frame_info_auto, print_frame_info_source_line,
1593         print_frame_info_location, print_frame_info_source_and_location,
1594         print_frame_info_location_and_address, print_frame_info_short_location):
1595         New declarations.
1596         (struct frame_print_options): New member print_frame_info.
1597         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1598         * stack.h (get_user_print_what_frame_info): New declaration.
1599         (frame_show_address): New declaration.
1600         * stack.c (print_frame_arguments_choices): New value 'presence'.
1601         (print_frame_info_auto, print_frame_info_source_line,
1602         print_frame_info_location, print_frame_info_source_and_location,
1603         print_frame_info_location_and_address, print_frame_info_short_location,
1604         print_frame_info_choices, print_frame_info_print_what): New definitions.
1605         (print_frame_args): Only print dots for args if print frame-arguments
1606         is 'presence'.
1607         (frame_print_option_defs): New element for "frame-info".
1608         (get_user_print_what_frame_info): New function.
1609         (frame_show_address): Make non static.  Move comment to stack.h.
1610         (print_frame_info_to_print_what): New function.
1611         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1612         to decide what to print.
1613         (backtrace_command_1): Handle the new print_frame_arguments_presence
1614         value.
1615         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1616         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1617         (py_print_frame): In non-mi mode, use LOCATION as default for
1618         print_what, similarly to frame information printed directly by
1619         backtrace command. Handle frame-info user option in non MI mode.
1620
1621 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1622
1623         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1624         Add case for debugging 32-bit target on 64-bit host.  Revise
1625         comment.
1626
1627 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1628
1629         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1630         instead of find_function_entry_range_from_pc.
1631
1632 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1633
1634         * stack.c (find_frame_funname): Remove code which preferred
1635         minsym over symtab sym in "certain pathological cases".
1636
1637         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1638         parameter.  Change type of "do_demangle" to bool.
1639         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1640         Pass suitable "prefer_sym_over_minsym" flag to
1641         build_address_symbolic().  Don't output "+" for negative offsets.
1642         * printcmd.c (print_address_symbolic): Update invocation of
1643         build_address_symbolic to include a "prefer_sym_over_minsym"
1644         flag.
1645         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1646         Restrict cases in which use of minimal symbol is preferred to that
1647         of a found symbol.  Update comments.
1648
1649         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1650         for entry pc when entry pc is out of range for that FDE.
1651
1652 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1653
1654         PR gdb/24839:
1655         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1656         type.
1657
1658 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1659
1660         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1661         this function's Python signature.
1662
1663
1664 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1665
1666         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1667         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1668         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1669         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1670         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1671
1672
1673 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1674
1675         * h8300-tdep.c (h8300_register_name_common): New.
1676         h8300_register_name): Use h8300_register_name_common.
1677         (h8300s_register_name): Likewise.
1678         (h8300sx_register_name): Likewise.
1679         (h8300h_register_nam): New.
1680         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1681
1682
1683 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1684
1685         * arm-tdep.c (arm_skip_cmse_entry): New function.
1686         (arm_is_sgstubs_section): New function.
1687         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1688
1689 2019-07-22  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1692         Don't self-assign.
1693
1694 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1695
1696         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1697         type_print.
1698
1699 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1700
1701         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1702         so that GDB doesn't match any msymbols when searching in the
1703         TYPES_DOMAIN.
1704         (print_symbol_info): Print using typedef_print or type_print based
1705         on the type of the symbol.  Add updated FIXME comment moved from...
1706         (_initialize_symtab): ... move and update FIXME comment to above.
1707
1708 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1709
1710         * NEWS: Mention adding -q option to "info types".
1711         * symtab.c (struct info_types_options): New struct.
1712         (info_types_options_defs): New variable.
1713         (make_info_types_options_def_group): New function.
1714         (info_types_command): Use gdb::option framework to parse options.
1715         (info_types_command_completer): New function.
1716         (_initialize_symtab): Extend the help text on "info types" and
1717         register command completer.
1718
1719 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1720
1721         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1722         (lookup_symbol_in_objfile): Change int to block_enum and add a
1723         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1724
1725 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1726
1727         * MAINTAINERS (Write After Approval): Add self.
1728
1729 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1730
1731         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1732         instruction to the dummy code region.
1733
1734 2019-07-19  Tom Tromey  <tromey@adacore.com>
1735
1736         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1737         (ARGSUSED, PARAMS, __func__): Remove rules.
1738
1739 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1740
1741         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1742         * features/arm/arm-with-iwmmxt.c: Remove.
1743         * features/arm/arm-with-iwmmxt.xml: Remove.
1744         * features/arm/arm-with-m-fpa-layout.c: Remove.
1745         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1746         * features/arm/arm-with-m-vfp-d16.c: Remove.
1747         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1748         * features/arm/arm-with-m.c: Remove.
1749         * features/arm/arm-with-m.xml: Remove.
1750         * features/arm/arm-with-neon.c: Remove.
1751         * features/arm/arm-with-neon.xml: Remove.
1752         * features/arm/arm-with-vfpv2.c: Remove.
1753         * features/arm/arm-with-vfpv2.xml: Remove.
1754         * features/arm/arm-with-vfpv3.c: Remove.
1755         * features/arm/arm-with-vfpv3.xml: Remove.
1756
1757 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1758
1759         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1760
1761 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1762
1763         * arch/aarch32.c (aarch32_create_target_description): Create
1764         target descriptions using features.
1765         * arch/arm.c (arm_create_target_description)
1766         (arm_create_mprofile_target_description): Likewise.
1767         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1768
1769 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1770
1771         * Makefile.in: Add new files.
1772         * aarch32-tdep.c: New file.
1773         * aarch32-tdep.h: New file.
1774         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1775         Call aarch32_read_description.
1776         * arch/aarch32.c: New file.
1777         * arch/aarch32.h: New file.
1778         * arch/arm.c (arm_create_target_description)
1779         (arm_create_mprofile_target_description): New function.
1780         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1781         (arm_create_target_description)
1782         (arm_create_mprofile_target_description): New declaration.
1783         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1784         read_description functions.
1785         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1786         Likewise.
1787         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1788         * arm-tdep.c (tdesc_arm_list): New variable.
1789         (arm_register_g_packet_guesses): Call create description functions.
1790         (arm_read_description) (arm_read_mprofile_description): New
1791         function.
1792         * arm-tdep.h (arm_read_description)
1793         (arm_read_mprofile_description): Add declaration.
1794         * configure.tgt: Add new files.
1795
1796 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1797
1798         * top.c (new_ui_command): Open specified terminal just once.
1799
1800 2019-07-18  Tom Tromey  <tromey@adacore.com>
1801
1802         * symtab.c (main_name): Constify return type.
1803         * symfile.c (set_initial_language): Update.
1804         * symtab.h (main_name): Constify return type.
1805
1806 2019-07-17  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-winsource.c (tui_update_source_window)
1809         (tui_update_source_window_as_is)
1810         (tui_update_source_windows_with_line): Remove return.
1811         * tui/tui-disasm.c (tui_show_disassem)
1812         (tui_show_disassem_and_update_source): Remove return.
1813         * tui/tui.c (tui_reset): Remove return.
1814         * tui/tui-wingeneral.c
1815         (tui_check_and_display_highlight_if_needed): Remove return.
1816
1817 2019-07-17  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1820
1821 2019-07-17  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-winsource.h (struct tui_exec_info_window)
1824         (struct tui_source_window_base): Move from tui-data.h.
1825         * tui/tui-winsource.c: Move many method definitions from
1826         elsewhere.  Remove "structuring" comments.
1827         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1828         (tui_source_window_base::refresh_window): Move to
1829         tui-winsource.c.
1830         * tui/tui-win.c (tui_source_window_base::refresh_all)
1831         (tui_source_window_base::update_tab_width)
1832         (tui_source_window_base::set_new_height)
1833         (tui_source_window_base::do_make_visible_with_new_height): Move to
1834         tui-winsource.c.
1835         * tui/tui-source.h: Update.
1836         * tui/tui-source.c (tui_source_window_base::reset): Move to
1837         tui-winsource.c.
1838         * tui/tui-disasm.h: Update.
1839         * tui/tui-data.h (struct tui_exec_info_window): Move to
1840         tui-winsource.h.
1841         (struct tui_source_window_base): Likewise.
1842         * tui/tui-data.c (tui_source_window_base::clear_detail)
1843         (tui_source_window_base, ~tui_source_window_base): Move to
1844         tui-winsource.c.
1845
1846 2019-07-17  Tom Tromey  <tom@tromey.com>
1847
1848         * tui/tui-win.c (tui_resize_all)
1849         (tui_source_window_base::update_tab_width)
1850         (tui_adjust_win_heights): Update.
1851         (tui_win_info::make_invisible_and_set_new_height): Rename from
1852         make_invisible_and_set_new_height.
1853         * tui/tui-data.h (struct tui_win_info)
1854         <make_invisible_and_set_new_height>: New method.
1855
1856 2019-07-17  Tom Tromey  <tom@tromey.com>
1857
1858         * tui/tui.c: Update.
1859         * tui/tui-source.h (struct tui_source_window): Move from
1860         tui-data.h.
1861         * tui/tui-layout.c: Update.
1862         * tui/tui-disasm.c: Update.
1863         * tui/tui-data.h (struct tui_source_window): Move to
1864         tui-source.h.
1865
1866 2019-07-17  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1869         tui-data.h.
1870         * tui/tui-data.h (struct tui_disasm_window): Move to
1871         tui-disasm.h.
1872
1873 2019-07-17  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-regs.h (struct tui_data_item_window): Move from
1876         tui-data.h.
1877         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1878         * tui/tui-data.h (struct tui_data_item_window): Move to
1879         tui-regs.h.
1880         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1881
1882 2019-07-17  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui.c: Update.
1885         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1886         (tui_cmd_window::max_height): Move to tui-command.c.
1887         * tui/tui-layout.c: Update.
1888         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1889         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1890         tui-command.c.
1891         * tui/tui-command.h (struct tui_cmd_window): Move from
1892         tui-data.h.
1893         * tui/tui-command.c: Remove "structuring" comments.
1894         (tui_cmd_window::clear_detail)
1895         (tui_cmd_window::do_make_visible_with_new_height)
1896         (tui_cmd_window::max_height): Move from elsewhere.
1897
1898 2019-07-17  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1901         Now static.
1902         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1903         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1904
1905 2019-07-17  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui.c: Update.
1908         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1909         tui-regs.c.
1910         * tui/tui-windata.h: Remove file.
1911         * tui/tui-windata.c: Remove file.
1912         * tui/tui-win.c (tui_data_window::set_new_height)
1913         (tui_data_window::do_make_visible_with_new_height): Move to
1914         tui-regs.c.
1915         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1916         * tui/tui-regs.c: Remove "structuring" comments.
1917         (tui_data_window::first_data_item_displayed)
1918         (tui_data_window::delete_data_content_windows)
1919         (tui_data_window::erase_data_content)
1920         (tui_data_window::display_all_data)
1921         (tui_data_window::refresh_all)
1922         (tui_data_window::do_scroll_vertical)
1923         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1924         (tui_data_window::do_make_visible_with_new_height)
1925         (tui_data_window::refresh_window): Move from elsewhere.
1926         (_initialize_tui_regs): Move to end of file.
1927         * tui/tui-layout.c: Update.
1928         * tui/tui-hooks.c: Update.
1929         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1930         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1931         tui-regs.c.
1932         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1933
1934 2019-07-17  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1937         seen.
1938
1939 2019-07-17  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-win.c (tui_source_window_base::set_new_height)
1942         (tui_source_window_base::do_make_visible_with_new_height): Use
1943         m_has_locator field directly.
1944         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1945         method.
1946         (struct tui_source_window_base) <has_locator>: Likewise.
1947
1948 2019-07-17  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1951         Don't declare.
1952         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1953         Remove.
1954         * tui/tui-win.c (tui_source_window_base::set_new_height)
1955         (tui_source_window_base::set_new_height)
1956         (make_invisible_and_set_new_height)
1957         (tui_source_window_base::do_make_visible_with_new_height)
1958         (tui_source_window_base::do_make_visible_with_new_height):
1959         Update.
1960         * tui/tui-layout.c (show_source_disasm_command, show_data)
1961         (show_source_or_disasm_and_command): Update.
1962         * tui/tui-layout.c (show_layout): Update.
1963
1964 2019-07-17  Tom Tromey  <tom@tromey.com>
1965
1966         * tui/tui-layout.c (make_data_window): Remove.
1967         (show_data): Unify creation and re-initialization cases.
1968
1969 2019-07-17  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-layout.c (make_source_window, make_disasm_window):
1972         Remove.
1973         (show_data): Unify creation and re-initialization cases.
1974
1975 2019-07-17  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-layout.c (make_command_window): Remove.
1978         (show_source_disasm_command, show_source_or_disasm_and_command):
1979         Unify creation and re-initialization cases.
1980
1981 2019-07-17  Tom Tromey  <tom@tromey.com>
1982
1983         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1984         creation and re-initialization cases.
1985
1986 2019-07-17  Tom Tromey  <tom@tromey.com>
1987
1988         * tui/tui-regs.c (tui_get_register): Return void.
1989
1990 2019-07-17  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1993         Simplify.
1994
1995 2019-07-17  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1998         resetting.
1999
2000 2019-07-17  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2003         * tui/tui-regs.c (tui_reg_layout): New function.
2004         (tui_show_registers, tui_reg_command): Use it.
2005         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2006         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2007         parameters.
2008         (tui_layout_command): Remove.
2009
2010 2019-07-17  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-layout.h (tui/tui-layout): Return void.
2013         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2014
2015 2019-07-17  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-layout.c (show_source_disasm_command, show_data):
2018         Update.
2019         (reset_locator): Remove.
2020         (show_source_or_disasm_and_command): Update.
2021
2022 2019-07-17  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-source.c (tui_source_window_base::reset): Remove
2025         win_type parameter.
2026         * tui/tui-layout.c (make_command_window, make_source_window)
2027         (make_disasm_window, make_data_window)
2028         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2029         (reset_locator, show_source_or_disasm_and_command): Update.
2030         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2031         win_type parameter.
2032         (struct tui_source_window_base) <reset>: Likewise.
2033
2034 2019-07-17  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-layout.c (show_source_disasm_command): Use
2037         reset_locator.
2038         (reset_locator): New function.
2039         (init_and_make_win): Remove.
2040         (show_source_or_disasm_and_command): Use reset_locator.
2041
2042 2019-07-17  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2045         condition.
2046         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2047         Remove condition.
2048         * tui/tui-source.c (tui_source_window_base::reset): New method.
2049         * tui/tui-layout.c (make_command_window): Don't call
2050         init_and_make_win.
2051         (make_source_window, make_disasm_window): Don't call
2052         make_source_or_disasm_window.
2053         (make_data_window): Don't call init_and_make_win.  Change calling
2054         convention.
2055         (show_source_disasm_command, show_data): Simplify.
2056         (make_source_or_disasm_window): Remove.
2057         (show_source_or_disasm_and_command): Simplify.
2058         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2059         (struct tui_source_window_base) <reset>: Likewise.
2060         <execution_info>: Remove initializer.
2061         * tui/tui-data.c (tui_source_window_base): Initialize
2062         execution_info.
2063
2064 2019-07-17  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2067         variable.
2068
2069 2019-07-17  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui.c (tui_rl_other_window): Update.
2072         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2073         superclass method first.  Always iterate over regs_content.
2074         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2075         method.
2076         * tui/tui-win.c (tui_set_focus_command): Update.
2077
2078 2019-07-17  Tom Tromey  <tom@tromey.com>
2079
2080         * tui/tui-win.c (tui_set_focus_command): Rename from
2081         tui_set_focus.  Call tui_enable.
2082         (tui_set_focus_command): Remove.
2083
2084 2019-07-17  Tom Tromey  <tom@tromey.com>
2085
2086         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2087         refresh_window.
2088         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2089         touchwin.
2090         (tui_data_window::refresh_window): Call refresh_window on data
2091         items.  Always call superclass refresh_window.
2092         (tui_win_info::refresh): Remove.
2093         (tui_source_window_base::refresh_window): Update.
2094         (tui_refresh_all): Update.
2095         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2096         refresh_window.
2097         (show_source_or_disasm_and_command): Likewise.
2098         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2099         (struct tui_source_window_base) <refresh>: Likewise.
2100
2101 2019-07-17  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-winsource.c (tui_clear_source_content)
2104         (tui_show_source_content): Update.
2105         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2106         whether content is empty.
2107         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2108         Remove.
2109
2110 2019-07-17  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2113         window's contents.
2114         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2115         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2116
2117 2019-07-17  Tom Tromey  <tom@tromey.com>
2118
2119         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2120         (struct tui_data_item_window): Update.
2121
2122 2019-07-17  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2125         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2126         defines.
2127
2128 2019-07-17  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-winsource.h (tui_erase_source_content)
2131         (tui_clear_source_content): Remove "display_prompt" parameter.
2132         * tui/tui-winsource.c (tui_update_source_window_as_is)
2133         (tui_update_source_windows_with_addr): Update.
2134         (tui_clear_source_content): Remove "display_prompt" parameter.
2135         (tui_erase_source_content): Likewise.  Simplify.
2136         (tui_show_source_content): Update.
2137         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2138         * tui/tui-stack.c (tui_show_frame_info): Update.
2139         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2140         Remove defines.
2141
2142 2019-07-17  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2145         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2146         parameter.
2147         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2148         parameter.
2149
2150 2019-07-17  Tom Tromey  <tom@tromey.com>
2151
2152         * tui/tui-winsource.c (tui_clear_source_content)
2153         (tui_show_source_content, tui_show_exec_info_content)
2154         (tui_clear_exec_info_content): Update.
2155         * tui/tui-stack.c (tui_show_locator_content): Update.
2156         (tui_show_frame_info): Update.
2157         * tui/tui-source.h (tui_source_window): Don't declare.
2158         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2159         from tui_source_is_displayed.
2160         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2161         Remove field.
2162         (struct tui_source_window_base) <content_in_use>: New field.  Now
2163         bool.
2164         (struct tui_source_window) <showing_source_p>: New method.
2165         (TUI_SRC_WIN): Change cast.
2166         * tui/tui-data.c (tui_initialize_static_data): Update.
2167
2168 2019-07-17  Tom Tromey  <tom@tromey.com>
2169
2170         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2171         location_matches_p.
2172         * tui/tui-source.c (tui_source_window::location_matches_p): New
2173         method.
2174         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2175         method.
2176         * tui/tui-data.h (struct tui_source_window_base)
2177         <location_matches_p>: New method.
2178         (struct tui_source_window, struct tui_disasm_window)
2179         <location_matches_p>: Likewise.
2180
2181 2019-07-17  Tom Tromey  <tom@tromey.com>
2182
2183         * tui/tui-win.c (tui_set_win_height_command): Rename from
2184         tui_set_win_height.
2185         (tui_set_win_height_command): Remove.
2186
2187 2019-07-17  Tom Tromey  <tom@tromey.com>
2188
2189         * tui/tui-source.c (tui_source_window): New constructor.  Add
2190         observer.
2191         (~tui_source_window): New destructor.
2192         (tui_source_window::style_changed): New method.
2193         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2194         (tui_attach_detach_observers): Update.
2195         * tui/tui-data.h (struct tui_source_window): Make constructor not
2196         inline.  Add destructor.
2197         (struct tui_source_window) <style_changed>: New method.
2198         <m_observable>: New member.
2199
2200 2019-07-17  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2203         * tui/tui-win.c (tui_resize_all): Fix typo.
2204
2205 2019-07-17  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2208         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2209         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2210         * tui/tui-win.c (window_name_completer): Use foreach.
2211         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2212         (update_tab_width): Likewise.
2213         * tui/tui-layout.c (show_layout): Update.
2214         * tui/tui-data.h (class tui_window_iterator): New.
2215         (struct all_tui_windows): New.
2216         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2217
2218 2019-07-17  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2221         parameter.  Don't reference globals.
2222         (tui_reg_command): Update.
2223
2224 2019-07-17  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-regs.c (tui_show_registers): Simplify.
2227
2228 2019-07-17  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-regs.c (tui_show_registers): Update.
2231         (tui_show_register_group): Add win_info parameter.
2232
2233 2019-07-17  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2236         Rename from tui_display_reg_element_at_line.
2237         (tui_data_window::display_registers_from_line): Update.
2238         * tui/tui-data.h (struct tui_data_window)
2239         <display_reg_element_at_line>: New method.
2240
2241 2019-07-17  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-regs.h (tui_display_registers_from)
2244         (tui_display_registers_from_line): Don't declare.
2245         * tui/tui-windata.c (tui_data_window::display_all_data)
2246         (tui_data_window::refresh_all)
2247         (tui_data_window::do_scroll_vertical): Update.
2248         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2249         from tui_display_registers_from.
2250         (tui_display_reg_element_at_line): Update.
2251         (tui_data_window::display_registers_from_line): Rename from
2252         tui_display_registers_from_line.
2253         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2254         display_registers_from_line>: New methods.
2255
2256 2019-07-17  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2259         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2260         from tui_erase_data_content.
2261         (tui_data_window::display_all_data)
2262         (tui_data_window::refresh_all)
2263         (tui_data_window::do_scroll_vertical): Update.
2264         * tui/tui-regs.c (tui_show_registers): Update.
2265         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2266         New method.
2267
2268 2019-07-17  Tom Tromey  <tom@tromey.com>
2269
2270         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2271         declare.
2272         * tui/tui-windata.c
2273         (tui_data_window::delete_data_content_windows): Rename from
2274         tui_delete_data_content_windows.
2275         (tui_data_window::display_all_data)
2276         (tui_data_window::do_scroll_vertical): Update.
2277         * tui/tui-data.h (struct tui_data_window)
2278         <delete_data_content_windows>: New method.
2279
2280 2019-07-17  Tom Tromey  <tom@tromey.com>
2281
2282         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2283         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2284
2285 2019-07-17  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2288         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2289         from tui_display_all_data.
2290         * tui/tui-win.c
2291         (tui_data_window::do_make_visible_with_new_height): Update.
2292         * tui/tui-regs.c (tui_show_registers): Update.
2293         * tui/tui-layout.c (tui_set_layout): Update.
2294         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2295         method.
2296
2297 2019-07-17  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2300         * tui/tui-windata.c (tui_display_data_from): Remove.
2301         (tui_data_window::refresh_all): Update.
2302
2303 2019-07-17  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2306         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2307         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2308         tui_display_registers_from_line.
2309         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2310         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2311         "force_display" parameter.
2312
2313 2019-07-17  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2316         declare.
2317         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2318         Rename from tui_first_reg_element_no_inline.
2319         (tui_display_reg_element_at_line)
2320         (tui_display_registers_from_line): Update.
2321         * tui/tui-data.h (struct tui_data_window)
2322         <first_reg_element_no_inline>: New method.
2323
2324 2019-07-17  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-windata.c (tui_display_data_from)
2327         (tui_data_window::do_scroll_vertical): Update.
2328         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2329         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2330         Rename from tui_line_from_reg_element_no.
2331         (tui_display_registers_from_line): Update.
2332         * tui/tui-data.h (struct tui_data_window)
2333         <line_from_reg_element_no>: New method.
2334
2335 2019-07-17  Tom Tromey  <tom@tromey.com>
2336
2337         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2338         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2339         tui_last_regs_line_no.
2340         (tui_display_reg_element_at_line)
2341         (tui_display_registers_from_line): Update.
2342         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2343         method.
2344
2345 2019-07-17  Tom Tromey  <tom@tromey.com>
2346
2347         PR tui/24722:
2348         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2349         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2350         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2351         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2352         (tui_update_breakpoint_info): Likewise.
2353         * tui/tui-hooks.c (tui_event_create_breakpoint)
2354         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2355         Update.
2356
2357 2019-07-17  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2360
2361 2019-07-17  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-winsource.c (tui_update_source_window_as_is)
2364         (tui_update_source_windows_with_addr): Update.
2365         * tui/tui-source.h (tui_set_source_content)
2366         (tui_show_symtab_source): Add "win_info" parameter.
2367         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2368         parameter.
2369         (tui_show_symtab_source): Likewise.
2370
2371 2019-07-17  Tom Tromey  <tom@tromey.com>
2372
2373         * tui/tui-wingeneral.c
2374         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2375
2376 2019-07-17  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2379         (struct tui_cmd_window) <can_scroll>: New method.
2380         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2381         method.
2382
2383 2019-07-17  Tom Tromey  <tromey@adacore.com>
2384
2385         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2386         do_field_signed>: Rename.  Change type of "value".
2387         * ui-out.c (ui_out::field_signed): Rename from field_int.
2388         Change type of "value".
2389         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2390         type of "value".
2391         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2392         do_field_int.  Change type of "value".
2393         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2394         do_field_int.  Change type of "value".
2395         * tracepoint.c (trace_status_mi, tfind_1)
2396         (print_one_static_tracepoint_marker): Update.
2397         * thread.c (print_thread_info_1, print_selected_thread_frame):
2398         Update.
2399         * stack.c (print_frame, print_frame_info): Update.
2400         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2401         Update.
2402         * source.c (print_source_lines_base): Update.
2403         * skip.c (info_skip_command): Update.
2404         * record-btrace.c (btrace_ui_out_decode_error)
2405         (btrace_call_history_src_line): Update.
2406         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2407         Update.
2408         * progspace.c (print_program_space): Update.
2409         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2410         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2411         do_field_int.  Change type of "value".
2412         * mi/mi-out.c (mi_ui_out::do_table_begin)
2413         (mi_ui_out::do_table_header): Update.
2414         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2415         type of "value".
2416         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2417         (mi_cmd_data_list_changed_registers, output_register)
2418         (mi_cmd_data_read_memory, mi_load_progress)
2419         (mi_cmd_trace_frame_collected): Update.
2420         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2421         Update.
2422         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2423         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2424         (mi_cmd_var_list_children, varobj_update_one): Update.
2425         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2426         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2427         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2428         * inferior.c (print_inferior): Update.
2429         * gdb_bfd.c (print_one_bfd): Update.
2430         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2431         Update.
2432         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2433         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2434         do_field_int.  Change type of "value".
2435         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2436         do_field_int.  Change type of "value".
2437         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2438         (print_one_breakpoint_location, print_it_catch_fork)
2439         (print_one_catch_fork, print_it_catch_vfork)
2440         (print_one_catch_vfork, print_it_catch_solib)
2441         (print_it_catch_exec, print_it_ranged_breakpoint)
2442         (print_mention_watchpoint, print_mention_masked_watchpoint)
2443         (bkpt_print_it, update_static_tracepoint): Update.
2444         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2445         * break-catch-syscall.c (print_it_catch_syscall): Update.
2446         * ada-tasks.c (print_ada_task_info): Update.
2447         * ada-lang.c (print_it_exception, print_mention_exception):
2448         Update.
2449
2450 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2451
2452         PR breakpoints/24541
2453         * gdbarch.c: Regenerate.
2454         * gdbarch.h: Regenerate.
2455         * gdbarch.sh: Adjust return type and parameter types for
2456         'stap_adjust_register'.
2457         (i386_stap_adjust_register): Adjust signature and return new
2458         register name.
2459         * stap-probe.c (stap_parse_register_operand): Adjust use of
2460         'gdbarch_stap_adjust_register'.
2461
2462 2019-07-17  Tom Tromey  <tromey@adacore.com>
2463
2464         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2465         declare VEC.
2466         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2467         std::vector.
2468         (struct s390_process_info): Add initializers.
2469         (s390_add_process): Use new.
2470         (s390_linux_nat_target::low_forget_process): Use delete.
2471         (s390_linux_nat_target::low_new_fork)
2472         (s390_linux_nat_target::stopped_by_watchpoint)
2473         (s390_linux_nat_target::low_prepare_to_resume)
2474         (s390_linux_nat_target::insert_watchpoint)
2475         (s390_linux_nat_target::insert_hw_breakpoint)
2476         (s390_linux_nat_target::remove_watchpoint)
2477         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2478
2479 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2480
2481         * aarch64-fbsd-nat.c: Include regcache.h.
2482         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2483         argument.
2484         (aarch64_fbsd_nat_target::fetch_registers)
2485         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2486         variable.
2487         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2488
2489 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2490
2491         * fbsd-nat.c: Include gdbarch.h.
2492
2493 2019-07-15  Tom Tromey  <tromey@adacore.com>
2494
2495         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2496
2497 2019-07-15  Tom Tromey  <tromey@adacore.com>
2498
2499         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2500         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2501         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2502         * cli-out.c (cli_ui_out::do_field_int): New method.
2503         * ui-out.c (ui_out::field_unsigned): New method.
2504         * symfile.c (generic_load): Use field_unsigned.
2505         (print_transfer_performance): Likewise.
2506         * record-btrace.c (ui_out_field_uint): Remove.
2507         (btrace_call_history_insn_range, btrace_call_history): Use
2508         field_unsigned.
2509         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2510         field_unsigned.
2511         * ui-out.h (class ui_out) <field_unsigned>: New method.
2512         <do_field_unsigned>: Likewise.
2513
2514 2019-07-15  Tom Tromey  <tromey@adacore.com>
2515
2516         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2517         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2518         * target.c (flash_erase_command): Use field_string.
2519         * infrun.c (print_signal_received_reason): Use field_string.
2520         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2521         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2522         field_string.
2523         * ada-tasks.c (print_ada_task_info): Use field_string.
2524
2525 2019-07-15  Tom Tromey  <tromey@adacore.com>
2526
2527         * target.c (flash_erase_command): Use field_core_addr.
2528         * symfile.c (generic_load): Use field_core_addr.
2529         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2530         Use field_core_addr.
2531         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2532         field_core_addr.
2533
2534 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2535
2536         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2537         value if its desired type is smaller than a CORE_ADDR and signed.
2538
2539 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2540
2541         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2542         of changes to field names, and use new is_reference field to
2543         decide if a property is a reference or not.
2544         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2545         field.
2546         (struct dwarf2_property_baton): Update header comment, rename
2547         'referenced_type' to 'property_type' and update comments.
2548         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2549         default property type, store in property baton, update to take
2550         accound of renamed field.
2551         (read_func_scope): Update call to attr_to_dynamic_prop.
2552         (read_array_type): Likewise.
2553         (dwarf2_per_cu_addr_sized_int_type): New function.
2554         (read_subrange_index_type): Move type finding code to
2555         dwarf2_per_cu_addr_sized_int_type.
2556         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2557         (dwarf2_per_cu_addr_type): New function.
2558         (set_die_type): Update calls to attr_to_dynamic_prop.
2559
2560 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2561
2562         * dwarf2read.c (read_subrange_index_type): New function.
2563         (read_subrange_type): Move code into new function and call it.
2564         * gdbtypes.c (create_range_type): Add some asserts.
2565
2566 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2567
2568         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2569         update return statements.
2570         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2571         declaration, and update comment to match.
2572         * gdbtypes.c (resolve_dynamic_array): Update call to
2573         dwarf2_evaluate_property to match new return type.
2574
2575 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2576
2577         * valarith.c (value_subscripted_rvalue): Change lowerbound
2578         parameter type from int to LONGEST.
2579         * value.h (value_subscripted_rvalue): Likewise in declaration.
2580
2581 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2582
2583         * cli/cli-utils.c (info_print_command_completer): New function.
2584         * cli/cli-utils.h: Add 'completer.h' include, and forward
2585         declaration for 'struct cmd_list_element'.
2586         (info_print_command_completer): Declare.
2587         * stack.c (_initialize_stack): Add completer for 'info locals' and
2588         'info args'.
2589         * symtab.c (_initialize_symtab): Add completer for 'info
2590         variables' and 'info functions'.
2591         * NEWS: Mention completion for additional info commands.
2592
2593 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2594
2595         * cli/cli-utils.c (extract_info_print_args): Delete.
2596         (extract_arg_maybe_quoted): Delete.
2597         (info_print_options_defs): New variable.
2598         (make_info_print_options_def_group): New function.
2599         (extract_info_print_options): Define new function.
2600         * cli/cli-utils.h (extract_info_print_args): Delete.
2601         (struct info_print_options): New structure.
2602         (extract_info_print_options): Declare new function.
2603         * stack.c (info_locals_command): Update to use new
2604         extract_info_print_options, also add a header comment.
2605         (info_args_command): Likewise.
2606         * symtab.c (info_variables_command): Likewise.
2607         (info_functions_command): Likewise.
2608
2609 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2610
2611         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2612         to extract string arguments.
2613         * common/common-utils.c (extract_string_maybe_quoted): New function.
2614         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2615
2616 2019-07-11  Tom Tromey  <tromey@adacore.com>
2617
2618         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2619         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2620         * top.h (gdbinit): Don't declare.
2621         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2622         into...
2623         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2624         * top.c (gdb_init): Don't call init_cli_cmds.
2625         (gdbinit): Remove.
2626         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2627
2628 2019-07-11  Tom Tromey  <tromey@adacore.com>
2629
2630         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2631         after it has been moved.
2632
2633 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2634
2635         * valops.c (value_must_coerce_to_target): Change return type to
2636         bool.
2637         * value.h (value_must_coerce_to_target): Likewise.
2638
2639 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2640
2641         * breakpoint.c (is_hardware_watchpoint): Remove
2642         forward-declaration.
2643         (is_masked_watchpoint): Change return type to bool.
2644         (is_tracepoint): Likewise.
2645         (is_breakpoint): Likewise.
2646         (is_hardware_watchpoint): Likewise.
2647         (is_watchpoint): Likewise.
2648         (is_no_memory_software_watchpoint): Likewise.
2649         (is_catchpoint): Likewise.
2650         (breakpoint_1): Make FILTER parameter's return type bool.
2651         is_masked_watchpoint): Change return type to bool.
2652         (save_breakpoints): Make FILTER parameter's return type bool.
2653         * breakpoint.h (is_breakpoint): Change return type to bool.
2654         (is_watchpoint): Likewise.
2655         (is_catchpoint): Likewise.
2656         (is_tracepoint): Likewise.
2657
2658 2019-07-10  Tom Tromey  <tom@tromey.com>
2659
2660         * defs.h: Don't include gdbarch.h.
2661         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2662         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2663         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2664         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2665         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2666         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2667         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2668         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2669         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2670         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2671         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2672         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2673         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2674         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2675         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2676         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2677         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2678         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2679         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2680         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2681         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2682         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2683         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2684         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2685         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2686         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2687         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2688
2689 2019-07-10  Tom Tromey  <tromey@adacore.com>
2690
2691         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2692         * breakpoint.c (init_ada_exception_breakpoint): Register as
2693         bp_catchpoint.
2694         (print_one_breakpoint_location, print_one_breakpoint): Use
2695         is_ada_exception_catchpoint.
2696         * ada-lang.c (class ada_catchpoint_location): Pass
2697         bp_loc_software_breakpoint to bp_location constructor.
2698         (is_ada_exception_catchpoint): New function.
2699
2700 2019-07-10  Tom Tromey  <tromey@adacore.com>
2701
2702         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2703         VEC.
2704         (struct arm_exidx_entry): New method operator<.
2705         (struct arm_exidx_data) <section_maps>: Change type.
2706         (arm_exidx_data_free): Remove.
2707         (arm_exidx_data_key): Change type.  Move lower.
2708         (arm_exidx_new_objfile): Update.
2709         (arm_compare_exidx_entries): Remove.
2710         (arm_find_exidx_entry, _initialize_arm_tdep)
2711
2712 2019-07-10  Tom Tromey  <tromey@adacore.com>
2713
2714         * solib-spu.c (ocl_program_data_key): Change type.
2715         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2716         Update.
2717
2718 2019-07-10  Tom Tromey  <tromey@adacore.com>
2719
2720         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2721         (struct solib_aix_inferior_data) <library_list>: Change type.
2722         (solib_aix_inferior_data_handle): Change type.
2723         (get_solib_aix_inferior_data): Update.
2724         (solib_aix_free_library_list): Remove.
2725         (library_list_start_library): Update.
2726         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2727         return type.
2728         (solib_aix_get_library_list)
2729         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2730         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2731
2732 2019-07-10  Tom Tromey  <tromey@adacore.com>
2733
2734         * solib-dsbt.c (struct dsbt_info): Add initializers.
2735         (solib_dsbt_pspace_data): Change type.
2736         (dsbt_pspace_data_cleanup): Remove.
2737         (get_dsbt_info, _initialize_dsbt_solib): Update.
2738
2739 2019-07-10  Tom Tromey  <tromey@adacore.com>
2740
2741         * spu-tdep.c (spu_overlay_data): Change type.
2742         (spu_get_overlay_table, spu_overlay_new_objfile)
2743         (_initialize_spu_tdep): Update.
2744
2745 2019-07-10  Tom Tromey  <tromey@adacore.com>
2746
2747         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2748         destructor.
2749         (dbx_objfile_data_key): Change type and declare later.
2750         (DBX_SYMFILE_INFO): Rewrite.
2751         * dbxread.c (dbx_objfile_data_key): Change type.
2752         (dbx_symfile_init): Update.
2753         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2754         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2755         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2756
2757 2019-07-10  Tom Tromey  <tromey@adacore.com>
2758
2759         * jit.c (jit_program_space_key): Change type.  Move lower.
2760         (get_jit_program_space_data): Update.
2761         (jit_program_space_data_cleanup): Remove.
2762         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2763         Update.
2764         (struct jit_program_space_data): Add initializers.
2765
2766 2019-07-10  Tom Tromey  <tromey@adacore.com>
2767
2768         * solib-darwin.c (struct darwin_info): Add initializers.
2769         (solib_darwin_pspace_data): Change type.
2770         (darwin_pspace_data_cleanup): Remove.
2771         (get_darwin_info, _initialize_darwin_solib): Update.
2772
2773 2019-07-10  Tom Tromey  <tromey@adacore.com>
2774
2775         * remote-sim.c (struct sim_inferior_data): Add initializers,
2776         constructor, and destructor.
2777         (sim_inferior_data_key): Change type.  Move lower.
2778         (check_for_duplicate_sim_descriptor): Update.
2779         (get_sim_inferior_data): Use new.  Update.
2780         (~sim_inferior_data_cleanup): Rename from
2781         sim_inferior_data_cleanup.  Simplify.
2782         (gdbsim_close_inferior, simulator_command)
2783         (sim_command_completer, _initialize_remote_sim): Update.
2784         (next_pid, INITIAL_PID): Move earlier.
2785
2786 2019-07-10  Tom Tromey  <tromey@adacore.com>
2787
2788         * python/python-internal.h (create_thread_object): Return
2789         gdbpy_ref.
2790         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2791         * python/py-inferior.c (struct threadlist_entry): Add
2792         constructor.
2793         <thread_obj>: Now a gdbpy_ref.
2794         (thread_to_thread_object): Update.
2795         (add_thread_object): Use new.
2796         (delete_thread_object): Use delete.
2797         (infpy_threads): Update.
2798         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2799         GIL.
2800
2801 2019-07-10  Tom Tromey  <tromey@adacore.com>
2802
2803         * valops.c (value_cast): Specialize error message for Ada.
2804
2805 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2806
2807         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2808
2809 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2810
2811         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2812         bpstat_should_step): Return bool, adjust comments.
2813         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2814         bpstat_should_step): Likewise.
2815
2816 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2817
2818         * features/Makefile: Use feature target descriptions for Arm.
2819         * features/arm/arm-core.c: Generate new file.
2820         * features/arm/arm-fpa.c: Likewise.
2821         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2822         * features/arm/arm-m-profile.c: Likewise.
2823         * features/arm/arm-vfpv2.c: Likewise.
2824         * features/arm/arm-vfpv3.c: Likewise.
2825         * features/arm/xscale-iwmmxt.c: Likewise.
2826         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2827
2828 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2829
2830         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2831         ptrace earlier.
2832
2833 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2834
2835         * features/aarch64-pauth.c: Regenerate.
2836
2837 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2838
2839         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2840         bool.
2841         (bpstat_what): Use false instead of 0.
2842
2843 2019-07-09  Pedro Alves  <palves@redhat.com>
2844
2845         * break-catch-throw.c (is_exception_catchpoint): New.
2846         * breakpoint.c (print_one_breakpoint_location): New parameter
2847         'raw_loc'.  Handle it.  Use
2848         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2849         looking at the breakpoint's type.
2850         (print_one_breakpoint): If handling "maint info breakpoints", also
2851         print locations of exception catchpoints.
2852         * breakpoint.h (is_exception_catchpoint): Declare.
2853
2854 2019-07-09  Pedro Alves  <palves@redhat.com>
2855
2856         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2857         "addr" field.
2858         (allocate_location_exception_catchpoint): New.
2859         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2860         (initialize_throw_catchpoint_ops): Install
2861         allocate_location_exception_catchpoint as allocate_location
2862         method.
2863         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2864         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2865         bp_loc_other.
2866         (breakpoint_address_is_meaningful): Delete.
2867         (bl_address_is_meaningful): New.
2868         (breakpoint_locations_match): Adjust comment.
2869         (bp_location_from_bp_type): New, factored out of...
2870         (bp_location::bp_location(breakpoint *)): ... this.
2871         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2872         factored out of...
2873         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2874         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2875         breakpoint_address_is_meaningful.
2876         (bp_locations_compare): Adjust comment.
2877         (update_global_location_list): Use bl_address_is_meaningful
2878         instead of breakpoint_address_is_meaningful.
2879         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2880         explicit.
2881         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2882         * python/py-breakpoint.c (bppy_get_location): No longer check
2883         whether location is null.
2884
2885 2019-07-09  Pedro Alves  <palves@redhat.com>
2886
2887         PR c++/15468
2888         * breakpoint.c (print_one_breakpoint_location): Remove
2889         single-location assert.
2890
2891 2019-07-09  Tom Tromey  <tom@tromey.com>
2892
2893         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2894         * configure: Rebuild.
2895         * configure.ac: Change common to gdbsupport.
2896         * gdbsupport: Rename from common.
2897         * acinclude.m4: Change common to gdbsupport.
2898         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2899         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2900         gdbsupport.
2901         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2902         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2903         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2904         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2905         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2906         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2907         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2908         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2909         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2910         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2911         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2912         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2913         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2914         coff-pe-read.c, command.h, compile/compile-c-support.c,
2915         compile/compile-c.h, compile/compile-cplus-symbols.c,
2916         compile/compile-cplus-types.c, compile/compile-cplus.h,
2917         compile/compile-loc2c.c, compile/compile.c, completer.c,
2918         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2919         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2920         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2921         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2922         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2923         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2924         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2925         features/aarch64-core.c, features/aarch64-fpu.c,
2926         features/aarch64-pauth.c, features/aarch64-sve.c,
2927         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2928         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2929         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2930         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2931         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2932         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2933         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2934         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2935         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2936         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2937         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2938         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2939         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2940         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2941         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2942         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2943         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2944         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2945         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2946         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2947         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2948         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2949         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2950         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2951         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2952         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2953         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2954         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2955         minsyms.c, mips-linux-tdep.c, namespace.h,
2956         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2957         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2958         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2959         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2960         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2961         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2962         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2963         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2964         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2965         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2966         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2967         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2968         procfs.c, producer.c, progspace.h, psymtab.h,
2969         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2970         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2971         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2972         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2973         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2974         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2975         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2976         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2977         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2978         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2979         target-memory.c, target.c, target.h, target/waitstatus.c,
2980         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2981         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2982         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2983         unittests/array-view-selftests.c,
2984         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2985         unittests/common-utils-selftests.c,
2986         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2987         unittests/format_pieces-selftests.c,
2988         unittests/function-view-selftests.c,
2989         unittests/lookup_name_info-selftests.c,
2990         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2991         unittests/mkdir-recursive-selftests.c,
2992         unittests/observable-selftests.c,
2993         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2994         unittests/parse-connection-spec-selftests.c,
2995         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2996         unittests/scoped_fd-selftests.c,
2997         unittests/scoped_mmap-selftests.c,
2998         unittests/scoped_restore-selftests.c,
2999         unittests/string_view-selftests.c, unittests/style-selftests.c,
3000         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3001         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3002         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3003         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3004         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3005         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3006
3007 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3008
3009         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3010         bool value.
3011         (decode_digits_ordinary): Set explicit_line field in sal.
3012         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3013         symtab_and_line that was set on an explicit line number in
3014         assembler code.  Do always update the recorded symtab and line if
3015         we do skip the prologue.
3016
3017 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3018
3019         * breakpoint.c (set_breakpoint_location_function): Remove
3020         explicit_loc parameter.
3021         (momentary_breakpoint_from_master): Update call to
3022         set_breakpoint_location_function.
3023         (add_location_to_breakpoint): Likewise.
3024
3025 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3026
3027         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3028         required features based on default bfd type when no specific bfd
3029         is present.
3030
3031 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3032
3033         * NEWS: Mention that GDB printf and eval commands can now print
3034         C-style and Ada-style convenience var strings without
3035         calling the inferior.
3036         * printcmd.c (printf_c_string): Locally print GDB internal var
3037         instead of transiting via the inferior.
3038         (printf_wide_c_string): Likewise.
3039
3040 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3041
3042         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3043
3044 2019-07-04  Tom Tromey  <tom@tromey.com>
3045
3046         PR tui/24724:
3047         * tui/tui-winsource.c (tui_clear_source_content): Update.
3048         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3049         (tui_update_breakpoint_info): Update.
3050         (tui_set_exec_info_content): Update.
3051         * tui/tui-source.c (tui_set_source_content_nil): Update.
3052         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3053         has_break.
3054         * tui/tui-data.h (enum tui_bp_flag): New.
3055         (tui_bp_flags): New enum flags type.
3056         (struct tui_source_element) <break_mode>: Change type.  Rename
3057         from has_break.
3058         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3059         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3060         constants.
3061         * tui/tui-winsource.h: Fix comment.
3062
3063 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3064
3065         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3066         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3067         (store_fpregs_to_thread)
3068         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3069         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3070         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3071         (IWMMXT_REGS_SIZE): Add define.
3072         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3073         (fetch_vfp_regs, store_vfp_regs)
3074         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3075         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3076
3077 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3078
3079         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3080         defines.
3081         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3082         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3083         (ARM_INT_REGISTER_SIZE): ...to this.
3084         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3085         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3086         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3087         (arm_linux_collect_gregset, supply_nwfpe_register)
3088         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3089         defines.
3090         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3091         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3092         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3093         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3094         (arm_return_in_memory, arm_store_return_value)
3095         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3096         (arm_record_ld_st_multiple): Likewise.
3097         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3098         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3099
3100 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3101
3102         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3103         AARCH64_DISPLACED_MODIFIED_INSNS.
3104         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3105         (aarch64_displaced_step_copy_insn): Likewise.
3106         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3107         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3108         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3109         ARM_DISPLACED_MODIFIED_INSNS.
3110         * arm-tdep.c (arm_gdbarch_init): Likewise.
3111         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3112         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3113         (struct arm_displaced_step_closure): Use
3114         ARM_DISPLACED_MODIFIED_INSNS.
3115
3116 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3117
3118         * features/Makefile: Remove unused xml files.
3119         * features/aarch64.xml: Remove.
3120         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3121         * features/i386/amd64-avx-avx512.xml: Remove.
3122         * features/i386/amd64-avx-linux.xml: Remove.
3123         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3124         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3125         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3126         * features/i386/amd64-avx-mpx.xml: Remove.
3127         * features/i386/amd64-avx.xml: Remove.
3128         * features/i386/amd64-linux.xml: Remove.
3129         * features/i386/amd64-mpx-linux.xml: Remove.
3130         * features/i386/amd64-mpx.xml: Remove.
3131         * features/i386/amd64.xml: Remove.
3132         * features/i386/i386-avx-avx512-linux.xml: Remove.
3133         * features/i386/i386-avx-avx512.xml: Remove.
3134         * features/i386/i386-avx-linux.xml: Remove.
3135         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3136         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3137         * features/i386/i386-avx-mpx-linux.xml: Remove.
3138         * features/i386/i386-avx-mpx.xml: Remove.
3139         * features/i386/i386-avx.xml: Remove.
3140         * features/i386/i386-linux.xml: Remove.
3141         * features/i386/i386-mmx-linux.xml: Remove.
3142         * features/i386/i386-mmx.xml: Remove.
3143         * features/i386/i386-mpx-linux.xml: Remove.
3144         * features/i386/i386-mpx.xml: Remove.
3145         * features/i386/i386.xml: Remove.
3146         * features/i386/x32-avx-avx512-linux.xml: Remove.
3147         * features/i386/x32-avx-linux.xml: Remove.
3148         * features/i386/x32-linux.xml: Remove.
3149
3150 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3151
3152         * regformats/aarch64.dat: Remove.
3153         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3154         * regformats/i386/amd64-avx-linux.dat: Remove.
3155         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3156         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3157         * regformats/i386/amd64-linux.dat: Remove.
3158         * regformats/i386/amd64-mpx-linux.dat: Remove.
3159         * regformats/i386/amd64.dat: Remove.
3160         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3161         * regformats/i386/i386-avx-linux.dat: Remove.
3162         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3163         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3164         * regformats/i386/i386-linux.dat: Remove.
3165         * regformats/i386/i386-mmx-linux.dat: Remove.
3166         * regformats/i386/i386-mpx-linux.dat: Remove.
3167         * regformats/i386/i386.dat: Remove.
3168         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3169         * regformats/i386/x32-avx-linux.dat: Remove.
3170         * regformats/i386/x32-linux.dat: Remove.
3171
3172 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3173
3174         * aarch64-tdep.c: Remove xml self tests.
3175         * amd64-linux-tdep.c: Likewise.
3176         * amd64-tdep.c: Likewise.
3177         * i386-linux-tdep.c: Likewise.
3178         * i386-tdep.c: Likewise.
3179
3180 2019-07-03  Pedro Alves  <palves@redhat.com>
3181
3182         PR cli/24732
3183         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3184         (pipe_cmd_option_defs): New.
3185         (make_pipe_cmd_options_def_group): New.
3186         (pipe_command): Use gdb::option::process_options.
3187         (pipe_command_completer): New function.
3188         (_initialize_cli_cmds): Install completer for "pipe" command.
3189
3190 2019-07-03  Pedro Alves  <palves@redhat.com>
3191
3192         * cli/cli-option.c (union option_value) <string>: New field.
3193         (struct option_def_and_value): Add ctor, move ctor, dtor and
3194         use DISABLE_COPY_AND_ASSIGN.
3195         (option_def_and_value::clear_value): New.
3196         (parse_option, save_option_value_in_ctx, get_val_type_str)
3197         (add_setshow_cmds_for_options): Handle var_string.
3198         * cli-option.h (union option_def::var_address) <string>: New
3199         field.
3200         (struct string_option_def): New.
3201         * maint-test-options.c (struct test_options_opts): Add default
3202         ctor and use DISABLE_COPY_AND_ASSIGN.
3203         <string_opt>: New field.
3204         (test_options_opts::~test_options_opts): New.
3205         (test_options_opts::dump): Also dump "-string".
3206         (test_options_option_defs): Install "string.
3207
3208 2019-07-03  Pedro Alves  <palves@redhat.com>
3209
3210         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3211         option_value with a null enumeration.
3212         (complete_options): Save the option values in the context.
3213         (save_option_value_in_ctx): New, factored out from ...
3214         (process_options): ... here.
3215         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3216         of the function.
3217         * maint-test-options.c (test_options_opts::dump): New, factored
3218         out from ...
3219         (maintenance_test_options_command_mode): ... here.
3220         (maintenance_test_options_command_completion_result): Delete.
3221         (maintenance_test_options_command_completion_text): Update
3222         comment.
3223         (maintenance_show_test_options_completion_result): Change
3224         prototype.  Just print
3225         maintenance_test_options_command_completion_text.
3226         (save_completion_result): New.
3227         (maintenance_test_options_completer_mode): Pass options context to
3228         complete_options, and then save a dump.
3229         (_initialize_maint_test_options): Use add_cmd to install "maint
3230         show test-options-completion-result".
3231
3232 2019-07-03  Pedro Alves  <palves@redhat.com>
3233
3234         * NEWS (New commands): Mention "with" and "maint with".
3235         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3236         (with_command, with_command_completer): New.
3237         (pipe_command): Adjust to new repeat_previous
3238         interface.
3239         (_initialize_cli_cmds): Install the "with" command and its "w"
3240         alias.
3241         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3242         declarations.
3243         * cli/cli-setshow.c (parse_cli_var_uinteger)
3244         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3245         argument strings for all var_types.
3246         (get_setshow_command_value_string): New, factored out from ...
3247         (do_show_command): ... this.
3248         * cli/cli-setshow.h: Include <string>.
3249         (get_setshow_command_value_string): Declare.
3250         * command.h (repeat_previous): Now returns const char *.  Adjust
3251         comment.
3252         * maint.c: Include "cli/cli-cmds.h".
3253         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3254         (_initialize_maint_cmds): Register the "maintenance with" command.
3255         * top.c (repeat_previous): Move bits from pipe_command here:
3256         Return the saved command line, if any; error out if there's no
3257         command to relaunch.
3258
3259 2019-07-03  Pedro Alves  <palves@redhat.com>
3260
3261         * NEWS (New commands): Mention "maint set/show test-settings"
3262         instead of "maint test-settings".
3263         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3264         (maintenance_test_settings_set_list): Rename to ...
3265         (maintenance_set_test_settings_list): ... this.
3266         (maintenance_test_settings_show_list): Rename to  ...
3267         (maintenance_show_test_settings_list): ... this.
3268         (maintenance_test_settings_cmd): Delete.
3269         (maintenance_test_settings_set_cmd): ...
3270         (maintenance_set_test_settings_cmd): ... this.
3271         (maintenance_test_settings_show_cmd): ...
3272         (maintenance_show_test_settings_cmd): ... this.
3273         (maintenance_test_settings_show_value_cmd):
3274         (maintenance_show_test_settings_value_cmd): ... this.
3275         (_initialize_maint_test_settings): No longer install the "maint
3276         test-settings" prefix command.  Rename "maint test-settings set"
3277         to "maint set test-settings", and "maint test-settings show" to
3278         "maint show test-settings".  Adjust all subcommands.
3279
3280 2019-07-03  Pedro Alves  <palves@redhat.com>
3281
3282         * maint-test-settings.c: Fix file's intro comment.  Replace all
3283         references to "test-options" with references to "test-settings",
3284         in comments.
3285
3286 2019-07-03  Pedro Alves  <palves@redhat.com>
3287
3288         * maint-test-settings.c (maintenance_test_settings_xxx)
3289         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3290         New.
3291         (maintenance_test_settings_enums): Use them.
3292         (maintenance_test_settings_enum): Default to
3293         maintenance_test_settings_xxx.
3294         (_initialize_maint_test_settings): Initialize
3295         MAINTENANCE_TEST_SETTINGS_FILENAME.
3296
3297 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3298
3299         * breakpoint.h (remove_breakpoints_inf): Change return type to
3300         void, move function documentation here.
3301         * breakpoint.c (remove_breakpoints_inf): Change return type to
3302         void, move function documentation to header.
3303
3304 2019-07-02  Pedro Alves  <palves@redhat.com>
3305
3306         * NEWS (Completion improvements): Mention "info threads".
3307         * thread.c (struct info_threads_opts, info_threads_option_defs)
3308         (make_info_threads_options_def_group): New.
3309         (info_threads_command): Use gdb::option::process_options.
3310         (info_threads_command_completer): New.
3311         (_initialize_thread): Use gdb::option::build_help to build the
3312         help text for "info threads".
3313
3314 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3315
3316         * defs.h (generic_load): Move from here...
3317         * symfile.h (generic_load): ... to here.  Rename name parameter
3318         to args.
3319         * symfile.c (generic_load): Add comment.
3320
3321 2019-07-01  Tom Tromey  <tromey@adacore.com>
3322
3323         * dwarf2read.c
3324         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3325         declaration of without_params.  Fix formatting.
3326
3327 2019-07-01  Tom Tromey  <tromey@adacore.com>
3328
3329         * ada-exp.y (find_primitive_type): Update.
3330         * ada-lang.h (ada_lookup_symbol): Update.
3331         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3332         parameter.
3333         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3334
3335 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3336
3337         PR breakpoints/24541
3338         * gdbarch.c: Regenerate.
3339         * gdbarch.h: Regenerate.
3340         * gdbarch.sh: Add 'stap_adjust_register'.
3341         * i386-tdep.c: Include '<unordered_set>'.
3342         (i386_stap_adjust_register): New function.
3343         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3344         * stap-probe.c (stap_parse_register_operand): Call
3345         'gdbarch_stap_adjust_register'.
3346
3347 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3348
3349         PR python/24742
3350         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3351         * python/python.c (do_start_initialization): Use 'xmalloc'
3352         instead of 'PyMem_Malloc'.
3353
3354 2019-06-28  Tom Tromey  <tromey@adacore.com>
3355
3356         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3357         for Ada.
3358
3359 2019-06-27  Tom Tromey  <tromey@adacore.com>
3360
3361         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3362         objfile_key.
3363         (arm_find_mapping_symbol, arm_record_special_symbol)
3364         (_initialize_arm_tdep): Update.
3365         (arm_objfile_data_free): Remove.
3366
3367 2019-06-27  Tom Tromey  <tromey@adacore.com>
3368
3369         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3370         to cp_print_static_field.
3371
3372 2019-06-26  Tom Tromey  <tromey@adacore.com>
3373
3374         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3375         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3376         declare.
3377
3378 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3379
3380         * features/aarch64-core.c (create_feature_aarch64_core):
3381         Regenerate.
3382         * features/aarch64-core.xml: Add cpsr flags.
3383
3384 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3385
3386         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3387         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3388
3389 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3390
3391         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3392         field.
3393         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3394         use.
3395         (arm_record_special_symbol): Don't insert new symbol in sorted
3396         position, push it at the end.
3397
3398 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3399
3400         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3401         (arm_mapping_symbol_s): Remove.
3402         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3403         (arm_mapping_symbol_vec): New typedef.
3404         (struct arm_per_objfile): Add constructor.
3405         <section_maps>: Change type to
3406         std::unique_ptr<arm_mapping_symbol_vec[]>.
3407         (arm_compare_mapping_symbols): Remove.
3408         (arm_find_mapping_symbol): Adjust to section_maps type change.
3409         (arm_objfile_data_free): Call delete on arm_per_objfile.
3410         (arm_record_special_symbol): Adjust to section_maps type change.
3411         Allocate arm_per_objfile with new.
3412
3413 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3414
3415         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3416         with the command prefix.
3417
3418 2019-06-25  Tom Tromey  <tom@tromey.com>
3419
3420         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3421         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3422
3423 2019-06-25  Tom Tromey  <tom@tromey.com>
3424
3425         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3426         type.
3427         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3428         protected.
3429
3430 2019-06-25  Tom Tromey  <tom@tromey.com>
3431
3432         * tui/tui-winsource.c
3433         (tui_source_window_base::set_is_exec_point_at): Add check against
3434         LOA_ADDRESS.
3435
3436 2019-06-25  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-source.c (tui_set_source_content): Don't check before
3439         xfree.
3440         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3441
3442 2019-06-25  Tom Tromey  <tom@tromey.com>
3443
3444         * tui/tui-winsource.h (tui_update_source_window_as_is)
3445         (tui_alloc_source_buffer, tui_line_is_displayed)
3446         (tui_addr_is_displayed): Change type of win_info.
3447         * tui/tui-winsource.c (tui_update_source_window_as_is)
3448         (tui_clear_source_content, tui_show_source_line)
3449         (tui_show_source_content, tui_source_window_base::refill)
3450         (tui_source_window_base::set_is_exec_point_at)
3451         (tui_source_window_base::set_is_exec_point_at)
3452         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3453         (tui_alloc_source_buffer, tui_line_is_displayed)
3454         (tui_addr_is_displayed): Change type of win_info.  Update.
3455         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3456         (tui_source_window_base::do_make_visible_with_new_height):
3457         Update.
3458         * tui/tui-source.c (tui_set_source_content)
3459         (tui_set_source_content_nil)
3460         (tui_source_window::do_scroll_vertical): Update.
3461         * tui/tui-layout.c (show_layout): Update.
3462         * tui/tui-disasm.c (tui_set_disassem_content)
3463         (tui_disasm_window::do_scroll_vertical): Update.
3464         * tui/tui-data.h (tui_win_content): Remove.
3465         (struct tui_gen_win_info) <content, content_size>: Remove.
3466         (struct tui_source_element): Add initializers and destructor.
3467         (union tui_which_element, struct tui_win_element): Remove.
3468         (struct tui_source_window_base) <content>: New field.
3469         (struct tui_data_window): Remove destructor.
3470         (tui_alloc_content, tui_free_win_content)
3471         (tui_free_all_source_wins_content): Don't declare.
3472         * tui/tui-data.c (tui_initialize_static_data): Update.
3473         (init_content_element, tui_alloc_content): Remove.
3474         (~tui_gen_win_info): Update.
3475         (~tui_data_window, tui_free_all_source_wins_content)
3476         (tui_free_win_content, free_content, free_content_elements):
3477         Remove.
3478
3479 2019-06-25  Tom Tromey  <tom@tromey.com>
3480
3481         * tui/tui-winsource.h (tui_clear_source_content)
3482         (tui_erase_source_content, tui_show_source_content): Change type
3483         of win_info.
3484         * tui/tui-winsource.c (tui_clear_source_content)
3485         (tui_erase_source_content, tui_show_source_content): Change type
3486         of win_info.
3487         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3488         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3489         win_info.
3490         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3491         win_info.
3492         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3493
3494 2019-06-25  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-winsource.c (tui_clear_source_content)
3497         (tui_source_window_base::set_is_exec_point_at): Update.
3498         * tui/tui-source.c (tui_set_source_content_nil): Update.
3499         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3500         a bool.
3501         * tui/tui-data.c (init_content_element): Update.
3502
3503 2019-06-25  Tom Tromey  <tom@tromey.com>
3504
3505         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3506         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3507         * tui/tui-layout.c (init_and_make_win): Update.
3508         * tui/tui.h (enum tui_win_type): Update.
3509         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3510         tui_win_is_auxillary.
3511         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3512         tui_win_is_auxillary.
3513
3514 2019-06-25  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3517         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3518         (tui_delete_data_content_windows, tui_display_all_data)
3519         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3520         Update.
3521         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3522         * tui/tui-regs.c (tui_last_regs_line_no)
3523         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3524         (tui_show_registers): Update.
3525         (tui_show_register_group): Return void.  Update.
3526         (tui_display_registers_from, tui_display_reg_element_at_line)
3527         (tui_display_registers_from_line, tui_check_register_values):
3528         Update.
3529         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3530         member.
3531         (struct tui_data_window) <regs_content>: Now a std::vector.
3532         <regs_content_count>: Remove.
3533         (tui_add_content_elements, tui_free_data_content): Don't declare.
3534         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3535         (init_content_element): Remove DATA_WIN case.  Add assert.
3536         (tui_add_content_elements): Remove.
3537         (tui_data_window): Update.
3538         (tui_free_data_content): Remove.
3539         (free_content_elements): Remove DATA_WIN case.
3540
3541 2019-06-25  Tom Tromey  <tom@tromey.com>
3542
3543         * tui/tui-data.c (tui_data_item_window): Update.
3544         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3545         * tui/tui-windata.c (tui_display_all_data)
3546         (tui_display_data_from_line): Update.
3547         (tui_check_data_values): Remove.
3548         * tui/tui-regs.c (tui_show_register_group)
3549         (tui_display_reg_element_at_line): Update.
3550         * tui/tui-hooks.c (tui_register_changed)
3551         (tui_refresh_frame_and_register_information): Call
3552         tui_check_register_values.
3553         * tui/tui-data.h (struct tui_data_window) <data_content,
3554         data_content_count, data_type>: Remove.
3555         (enum tui_data_type): Remove.
3556
3557         * tui/tui-data.c (tui_data_window::clear_detail)
3558         (~tui_data_window): Update.
3559
3560 2019-06-25  Tom Tromey  <tom@tromey.com>
3561
3562         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3563         declare.
3564         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3565         Rename from tui_first_data_item_displayed.  Update.
3566         (tui_data_window::refresh_all)
3567         (tui_data_window::do_scroll_vertical): Update.
3568         * tui/tui-data.h (struct tui_data_window)
3569         <first_data_item_displayed>: Declare new method.
3570
3571 2019-06-25  Tom Tromey  <tom@tromey.com>
3572
3573         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3574         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3575         contents...
3576         (tui_initialize_static_data): ...here.
3577
3578 2019-06-25  Tom Tromey  <tom@tromey.com>
3579
3580         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3581         (tui_display_registers_from, tui_check_register_values): Update.
3582         (tui_display_register): Remove win_info parameter; update.
3583         (tui_get_register): Change type of parameters.
3584         * tui/tui-data.h (struct tui_data_element): Remove.
3585         (union tui_which_element) <data>: Remove.
3586         <data_window>: Change type.
3587         (struct tui_data_item_window): New.
3588         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3589         case.  Add assert.
3590         (~tui_data_item_window): New destructor.
3591         (free_content_elements): Remove DATA_ITEM_WIN case.
3592
3593 2019-06-25  Tom Tromey  <tom@tromey.com>
3594
3595         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3596         Remove.
3597
3598 2019-06-25  Tom Tromey  <tom@tromey.com>
3599
3600         * tui/tui-data.h (struct tui_command_element): Remove.
3601         (union tui_which_element) <command>: Remove.
3602         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3603         assert.
3604         (free_content_elements): Remove CMD_WIN case.
3605
3606 2019-06-25  Tom Tromey  <tom@tromey.com>
3607
3608         * tui/tui-layout.c (tui_set_layout): Update.
3609         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3610         * tui/tui-data.c (layout_def): Update.
3611
3612 2019-06-25  Tom Tromey  <tom@tromey.com>
3613
3614         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3615         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3616         (tui_source_window_base::set_new_height): Update.
3617         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3618         Update.
3619         (tui_set_locator_fullname, tui_set_locator_info)
3620         (tui_show_frame_info): Update.
3621         * tui/tui-source.c (tui_set_source_content)
3622         (tui_source_is_displayed): Update.
3623         * tui/tui-layout.c (show_source_disasm_command, show_data)
3624         (show_source_or_disasm_and_command): Update.
3625         * tui/tui-disasm.c (tui_set_disassem_content)
3626         (tui_get_begin_asm_address): Update.
3627         * tui/tui-data.h (struct tui_locator_element): Remove.
3628         (union tui_which_element) <locator>: Remove.
3629         (struct tui_locator_window): New.
3630         (tui_locator_win_info_ptr): Change return type.
3631         * tui/tui-data.c (_locator): Change type.
3632         (tui_locator_win_info_ptr): Change return type.
3633         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3634         (tui_alloc_content): Add assert.
3635
3636 2019-06-25  Tom Tromey  <tom@tromey.com>
3637
3638         * tui/tui-winsource.c
3639         (tui_exec_info_window::maybe_allocate_content): New method.
3640         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3641         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3642         (make_source_or_disasm_window): Add cast.
3643         * tui/tui-data.h (union tui_which_element) <simple_string>:
3644         Remove.
3645         (struct tui_source_info): New.
3646         (struct tui_source_window_base) <execution_info>: Change type.
3647         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3648         case, and add assert.
3649         (tui_alloc_content): Add assert.
3650
3651 2019-06-25  Tom Tromey  <tom@tromey.com>
3652
3653         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3654         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3655         * tui/tui-data.c (tui_alloc_win_info): Remove.
3656
3657 2019-06-25  Tom Tromey  <tom@tromey.com>
3658
3659         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3660         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3661         can_highlight.
3662
3663 2019-06-25  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3666         make_visible_with_new_height method.
3667         (tui_win_info::make_visible_with_new_height): New method.
3668         (tui_source_window_base::do_make_visible_with_new_height)
3669         (tui_data_window::do_make_visible_with_new_height)
3670         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3671         (make_visible_with_new_height): Remove.
3672         (tui_resize_all, tui_adjust_win_heights): Use
3673         make_visible_with_new_height method.
3674         * tui/tui-data.h (struct tui_win_info)
3675         <do_make_visible_with_new_height, make_visible_with_new_height>:
3676         New methods.
3677         (struct tui_source_window_base, struct tui_data_window)
3678         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3679         methods.
3680
3681 2019-06-25  Tom Tromey  <tom@tromey.com>
3682
3683         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3684         method.
3685         (update_tab_width): Call update_tab_width method.
3686         * tui/tui-data.h (struct tui_win_info)
3687         (struct tui_source_window_base) <update_tab_width>: New methods.
3688
3689 2019-06-25  Tom Tromey  <tom@tromey.com>
3690
3691         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3692         parameter.
3693         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3694         parameter.
3695         (tui_gen_win_info::make_visible): Update.
3696         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3697         parameter.
3698         * tui/tui-data.h (enum tui_box): New enum.
3699         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3700
3701 2019-06-25  Tom Tromey  <tom@tromey.com>
3702
3703         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3704         init_and_make_win for EXEC_INFO_WIN.
3705         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3706         longer inline.
3707         (struct tui_win_info) <~tui_win_info>: Inline.
3708         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3709         Don't declare.
3710         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3711         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3712         Remove.
3713         (tui_initialize_static_data): Update.
3714         (~tui_gen_win_info): Handle more cleanup here.
3715         (~tui_source_window_base): Delete "execution_info".
3716         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3717
3718 2019-06-25  Tom Tromey  <tom@tromey.com>
3719
3720         * tui/tui-layout.c (make_command_window): Don't set
3721         can_highlight.
3722         (show_source_disasm_command): Call the reset method.
3723         (show_data): Don't set can_highlight.  Call the reset method.
3724         (tui_gen_win_info::reset): Rename from init_gen_win_info
3725         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3726         (show_source_or_disasm_and_command): Call the reset method.
3727         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3728         (struct tui_cmd_window): Set can_highlight.
3729
3730 2019-06-25  Tom Tromey  <tom@tromey.com>
3731
3732         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3733         from make_visible.
3734         (tui_make_visible, tui_make_invisible): Rewrite.
3735         (tui_win_info::make_visible): Remove.
3736         (tui_source_window_base::make_visible): Update.
3737         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3738         method.  Moved from...
3739         (struct tui_win_info) <make_visible>: ...here.
3740
3741 2019-06-25  Tom Tromey  <tom@tromey.com>
3742
3743         * tui/tui-winsource.c
3744         (tui_source_window_base::do_scroll_horizontal): Remove direction
3745         parameter.
3746         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3747         direction parameter.
3748         * tui/tui-win.c (tui_win_info::forward_scroll)
3749         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3750         (tui_win_info::right_scroll): Update.
3751         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3752         direction parameter.
3753         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3754         direction parameter.
3755         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3756         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3757         Remove direction parameter.
3758         (struct tui_source_window_base, struct tui_source_window)
3759         (struct tui_disasm_window, struct tui_data_window)
3760         (struct tui_cmd_window): Update.
3761
3762 2019-06-25  Tom Tromey  <tom@tromey.com>
3763
3764         * tui/tui-winsource.h (tui_set_exec_info_content)
3765         (tui_show_exec_info_content, tui_erase_exec_info_content)
3766         (tui_clear_exec_info_content, tui_update_exec_info): Change
3767         argument to tui_source_window_base.
3768         * tui/tui-winsource.c (tui_set_exec_info_content)
3769         (tui_show_exec_info_content, tui_erase_exec_info_content)
3770         (tui_clear_exec_info_content, tui_update_exec_info): Change
3771         argument to tui_source_window_base.
3772
3773 2019-06-25  Tom Tromey  <tom@tromey.com>
3774
3775         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3776         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3777
3778 2019-06-25  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3781         check.
3782
3783 2019-06-25  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3786         type to void.
3787         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3788         type to void.
3789         * tui/tui-source.c (tui_set_source_content): Update.
3790         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3791
3792 2019-06-25  Tom Tromey  <tom@tromey.com>
3793
3794         * tui/tui-win.c (window_name_completer, tui_set_focus)
3795         (tui_all_windows_info): Use name method.
3796         * tui/tui-data.h (struct tui_gen_win_info)
3797         (struct tui_source_window, struct tui_disasm_window)
3798         (struct tui_data_window, struct tui_cmd_window) <name>: New
3799         method.
3800         (tui_win_name): Don't declare.
3801         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3802         (tui_win_name): Remove.
3803
3804 2019-06-25  Tom Tromey  <tom@tromey.com>
3805
3806         * tui/tui-winsource.h (tui_update_source_window)
3807         (tui_update_source_window_as_is): Change parameter type.
3808         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3809         to be a tui_source_window_base.
3810         (tui_update_source_window_as_is): Likewise.
3811         * tui/tui-win.c (make_visible_with_new_height): Update.
3812
3813 2019-06-25  Tom Tromey  <tom@tromey.com>
3814
3815         * tui/tui-winsource.c (tui_erase_source_content)
3816         (tui_show_source_content, tui_show_exec_info_content)
3817         (tui_erase_exec_info_content): Use refresh_window method.
3818         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3819         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3820         from tui_refresh_win.
3821         (tui_data_window::refresh_window): New method.
3822         (tui_win_info::refresh, tui_source_window_base::refresh)
3823         (tui_refresh_all): Use refresh_window method.
3824         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3825         method.
3826         * tui/tui-regs.c (tui_display_register): Call refresh_window
3827         method.
3828         * tui/tui-layout.c (show_source_disasm_command)
3829         (show_source_or_disasm_and_command): Call refresh_window method.
3830         * tui/tui-data.h (struct tui_gen_win_info)
3831         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3832         New method.
3833
3834 2019-06-25  Tom Tromey  <tom@tromey.com>
3835
3836         * tui/tui.c (tui_rl_other_window, tui_enable)
3837         (tui_is_window_visible, tui_get_command_dimension): Update.
3838         * tui/tui-winsource.c (tui_update_source_window_as_is)
3839         (tui_clear_source_content, tui_erase_source_content)
3840         (tui_show_source_line, tui_source_window_base::refill)
3841         (tui_source_window_base::do_scroll_horizontal)
3842         (tui_source_window_base::set_is_exec_point_at)
3843         (tui_update_breakpoint_info, tui_set_exec_info_content)
3844         (tui_alloc_source_buffer, tui_line_is_displayed)
3845         (tui_addr_is_displayed): Update.
3846         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3847         (tui_check_and_display_highlight_if_needed)
3848         (tui_win_info::make_visible, tui_win_info::refresh)
3849         (tui_refresh_all): Update.
3850         * tui/tui-windata.c (tui_first_data_item_displayed)
3851         (tui_delete_data_content_windows, tui_erase_data_content)
3852         (tui_display_all_data, tui_data_window::refresh_all)
3853         (tui_check_data_values): Update.
3854         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3855         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3856         (tui_win_info::backward_scroll, tui_refresh_all_win)
3857         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3858         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3859         (tui_source_window_base::set_new_height)
3860         (tui_data_window::set_new_height)
3861         (make_invisible_and_set_new_height)
3862         (make_visible_with_new_height, new_height_ok)
3863         (parse_scrolling_args): Update.
3864         * tui/tui-stack.c (tui_show_frame_info): Update.
3865         * tui/tui-source.c (tui_set_source_content)
3866         (tui_set_source_content_nil, tui_source_is_displayed)
3867         (tui_source_window::do_scroll_vertical): Update.
3868         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3869         (tui_display_registers_from, tui_display_reg_element_at_line)
3870         (tui_check_register_values, tui_reg_command): Update.
3871         * tui/tui-layout.c (tui_default_win_height)
3872         (show_source_disasm_command, show_data, init_and_make_win)
3873         (show_source_or_disasm_and_command): Update.
3874         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3875         (tui_redisplay_readline, tui_mld_flush)
3876         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3877         (tui_getc): Update.
3878         * tui/tui-disasm.c (tui_set_disassem_content)
3879         (tui_disasm_window::do_scroll_vertical): Update.
3880         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3881         Now virtual.
3882         (struct tui_win_info): Derive from tui_gen_win_info.
3883         <~tui_win_info>: Mark as override.
3884         <generic>: Remove member.
3885         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3886         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3887         (~tui_data_window, ~tui_win_info)
3888         (tui_free_all_source_wins_content): Update.
3889         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3890
3891 2019-06-25  Tom Tromey  <tom@tromey.com>
3892
3893         * tui/tui-layout.c (init_and_make_win): Use new.
3894         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3895         destructor, initializers.
3896         (tui_alloc_generic_win_info): Don't declare.
3897         * tui/tui-data.c (_locator): Add argument to constructor.
3898         (source_win, disasm_win): New globals.
3899         (exec_info): Remove.
3900         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3901         Update.
3902         (tui_alloc_generic_win_info): Remove.
3903         (init_content_element): Use new.
3904         (tui_win_info::tui_win_info): Update.
3905         (free_content_elements) <case DATA_WIN>: Use delete.
3906
3907 2019-06-25  Tom Tromey  <tom@tromey.com>
3908
3909         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3910         * tui/tui-windata.c (tui_first_data_item_displayed)
3911         (tui_delete_data_content_windows): Update.
3912         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3913         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3914         (tui_display_registers_from, tui_check_register_values): Update.
3915         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3916         pointer.
3917         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3918         window.
3919         (tui_free_data_content): Update.
3920         (free_content_elements) <case DATA_WIN>: Free the window.
3921
3922 2019-06-25  Tom Tromey  <tom@tromey.com>
3923
3924         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3925         Update.
3926         * tui/tui-layout.c (make_command_window)
3927         (show_source_disasm_command, show_data, init_and_make_win)
3928         (show_source_or_disasm_and_command): Update.
3929         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3930         method.
3931         <can_highight, is_highlighted>: Now bool.
3932         (tui_set_win_highlight): Don't declare.
3933         * tui/tui-data.c (tui_set_win_highlight): Remove.
3934
3935 2019-06-25  Tom Tromey  <tom@tromey.com>
3936
3937         * tui/tui-wingeneral.c (make_visible): Remove check of window
3938         type.
3939
3940 2019-06-25  Tom Tromey  <tom@tromey.com>
3941
3942         * tui/tui-win.c (tui_win_info::max_height)
3943         (tui_cmd_window::max_height): New methods.
3944         (new_height_ok): Call max_height.
3945         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3946         <max_height>: New method.
3947
3948 2019-06-25  Tom Tromey  <tom@tromey.com>
3949
3950         * tui/tui-win.c (tui_source_window_base::set_new_height)
3951         (tui_data_window::set_new_height): New methods.
3952         (make_invisible_and_set_new_height): Call set_new_height method.
3953         * tui/tui-data.h (struct tui_win_info)
3954         (struct tui_source_window_base, struct tui_data_window)
3955         <set_new_height>: New method.
3956
3957 2019-06-25  Tom Tromey  <tom@tromey.com>
3958
3959         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3960         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3961         tui_refresh_data_win.
3962         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3963         method.
3964         (tui_refresh_all_win): Call the refresh_all method.
3965         (tui_set_focus): Likewise.
3966         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3967         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3968         Likewise.
3969
3970 2019-06-25  Tom Tromey  <tom@tromey.com>
3971
3972         * tui/tui-winsource.h (tui_refill_source_window)
3973         (tui_set_is_exec_point_at): Don't declare.
3974         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3975         (tui_source_window_base::refill): Rename from
3976         tui_refill_source_window.
3977         (tui_source_window_base::do_scroll_horizontal): Update.
3978         (tui_source_window_base::set_is_exec_point_at): Rename from
3979         tui_set_is_exec_point_at.
3980         (tui_update_all_breakpoint_info): Update.
3981         * tui/tui-stack.c (tui_show_frame_info): Update.
3982         * tui/tui-layout.c (show_data): Add cast.
3983         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3984         * tui/tui-data.h (struct tui_source_window_base) <refill,
3985         set_is_exec_point_at>: New methods.
3986         (tui_source_windows, tui_add_to_source_windows): Update types.
3987         (tui_add_to_source_windows): Remove redundant declaration.
3988         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3989         (tui_source_windows): Change return type.
3990         (tui_clear_source_windows_detail): Update.
3991         (tui_add_to_source_windows): Change type of parameter.
3992         (tui_free_all_source_wins_content): Update.
3993
3994 2019-06-25  Tom Tromey  <tom@tromey.com>
3995
3996         * tui/tui-wingeneral.c (tui_win_info::refresh)
3997         (tui_source_window_base::refresh): New methods.
3998         (tui_refresh_all): Call the refresh method.
3999         * tui/tui-data.h (struct tui_win_info)
4000         (struct tui_source_window_base) <refresh>: New method.
4001
4002 2019-06-25  Tom Tromey  <tom@tromey.com>
4003
4004         * tui/tui.h (tui_is_window_visible): Return bool.
4005         * tui/tui.c (tui_is_window_visible): Return bool.
4006         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4007         (tui_make_visible, tui_make_invisible)
4008         (tui_win_info::make_visible)
4009         (tui_source_window_base::make_visible, make_all_visible)
4010         (tui_make_all_visible, tui_make_all_invisible): Update.
4011         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4012         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4013         bool.
4014         (struct tui_win_info, struct tui_source_window_base)
4015         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4016         * tui/tui-data.c (tui_init_generic_part): Update.
4017
4018 2019-06-25  Tom Tromey  <tom@tromey.com>
4019
4020         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4021         (tui_source_window_base::make_visible): New methods.
4022         (make_all_visible): Make method call.
4023         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4024         (struct tui_source_window_base, struct tui_cmd_window): Override
4025         make_visible.
4026         (tui_win_is_source_type): Don't declare.
4027         * tui/tui-data.c (tui_win_is_source_type): Remove.
4028
4029 2019-06-25  Tom Tromey  <tom@tromey.com>
4030
4031         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4032         NULL check.
4033
4034 2019-06-25  Tom Tromey  <tom@tromey.com>
4035
4036         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4037         Inline constructor.  Add initializers for members.
4038         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4039         constructors; now inline in class.
4040
4041 2019-06-25  Tom Tromey  <tom@tromey.com>
4042
4043         * tui/tui-regs.c (tui_show_registers): Update.
4044         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4045         bool.
4046         * tui/tui-data.c (tui_data_window::clear_detail)
4047         (tui_data_window): Update.
4048
4049 2019-06-25  Tom Tromey  <tom@tromey.com>
4050
4051         * tui/tui-windata.c (tui_display_all_data)
4052         (tui_display_data_from_line, tui_display_data_from)
4053         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4054         Update.
4055         * tui/tui-regs.c (tui_last_regs_line_no)
4056         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4057         (tui_show_registers, tui_show_register_group)
4058         (tui_display_registers_from, tui_display_reg_element_at_line)
4059         (tui_display_registers_from_line, tui_check_register_values)
4060         (tui_reg_next, tui_reg_prev): Update.
4061         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4062         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4063         tui_data_window.
4064         (struct tui_win_info) <detail>: Remove.  Add new fields from
4065         tui_data_info.
4066         (TUI_DATA_WIN): Add cast.
4067         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4068         (~tui_data_window): Simplify.
4069
4070 2019-06-25  Tom Tromey  <tom@tromey.com>
4071
4072         * tui/tui-layout.c (show_source_disasm_command)
4073         (show_source_or_disasm_and_command): Update.
4074         * tui/tui-io.c (update_cmdwin_start_line)
4075         (tui_redisplay_readline): Update.
4076         * tui/tui-data.h (struct tui_command_info): Remove.
4077         (struct tui_win_info) <detail>: Remove command_info member.
4078         (struct tui_data_window) <start_line>: New member, from
4079         tui_command_info.
4080         (TUI_CMD_WIN): Add casts.
4081
4082 2019-06-25  Tom Tromey  <tom@tromey.com>
4083
4084         * tui/tui-winsource.c (tui_update_source_window)
4085         (tui_refill_source_window)
4086         (tui_source_window_base::do_scroll_horizontal)
4087         (tui_update_breakpoint_info, tui_set_exec_info_content)
4088         (tui_show_exec_info_content, tui_erase_exec_info_content)
4089         (tui_clear_exec_info_content): Update.
4090         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4091         Update.
4092         * tui/tui-win.c (make_invisible_and_set_new_height)
4093         (make_visible_with_new_height): Update.
4094         * tui/tui-source.c (tui_set_source_content)
4095         (tui_show_symtab_source): Update.
4096         * tui/tui-layout.c (extract_display_start_addr)
4097         (show_source_disasm_command, show_data)
4098         (make_source_or_disasm_window)
4099         (show_source_or_disasm_and_command): Update.
4100         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4101         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4102         "gdbarch".
4103         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4104         to tui_source_window_base.
4105         (struct tui_win_info) <detail>: Remove source_info member.
4106         (struct tui_source_window_base) <has_locator>: Inline.
4107         Move contents from tui_source_info; rename has_locator member to
4108         m_has_locator.
4109         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4110         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4111         header file.
4112         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4113         Simplify.
4114         (tui_free_all_source_wins_content): Cast to
4115         tui_source_window_base.
4116
4117 2019-06-25  Tom Tromey  <tom@tromey.com>
4118
4119         * tui/tui-win.c (make_invisible_and_set_new_height)
4120         (make_visible_with_new_height): Call has_locator method.
4121         * tui/tui-layout.c (show_source_disasm_command, show_data)
4122         (show_source_or_disasm_and_command): Update for bool change.
4123         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4124         (tui_win_info) <has_locator>: New method.
4125         (struct tui_source_window_base) <has_locator>: New method.
4126         (tui_win_has_locator): Don't declare.
4127         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4128         from tui_win_has_locator.
4129         (tui_source_window_base): Use false, not FALSE.
4130
4131 2019-06-25  Tom Tromey  <tom@tromey.com>
4132
4133         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4134         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4135         clear_detail method directly.
4136         (tui_clear_win_detail): Remove.
4137
4138 2019-06-25  Tom Tromey  <tom@tromey.com>
4139
4140         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4141         "this", not TUI_DISASM_WIN.
4142
4143 2019-06-25  Tom Tromey  <tom@tromey.com>
4144
4145         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4146         declare.
4147         * tui/tui-winsource.c
4148         (tui_source_window_base::do_scroll_horizontal): Rename from
4149         tui_horizontal_source_scroll.
4150         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4151         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4152         from tui_vertical_data_scroll.
4153         * tui/tui-win.h (tui_scroll): Don't declare.
4154         * tui/tui-win.c (tui_win_info::forward_scroll)
4155         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4156         (tui_win_info::right_scroll): Rename and update.
4157         (tui_scroll_forward_command, tui_scroll_backward_command)
4158         (tui_scroll_left_command, tui_scroll_right_command): Update.
4159         (tui_scroll): Remove.
4160         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4161         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4162         from tui_vertical_source_scroll.
4163         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4164         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4165         from tui_vertical_disassem_scroll.
4166         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4167         do_scroll_horizontal>: New methods.
4168         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4169         Likewise.
4170         (struct tui_source_window_base): Add do_scroll_horizontal.
4171         (struct tui_source_window, struct tui_disasm_window): Add
4172         do_scroll_vertical.
4173         (struct tui_data_window, struct tui_cmd_window): Add
4174         do_scroll_horizontal and do_scroll_vertical.
4175         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4176
4177 2019-06-25  Tom Tromey  <tom@tromey.com>
4178
4179         * tui/tui-data.h (struct tui_source_window_base): New struct.
4180         (struct tui_source_window): Derive from tui_source_window_base.
4181         (struct tui_disasm_window): New struct.
4182         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4183         from tui_source_window::clear_detail.
4184         (tui_source_window_base): Rename from tui_source_window.
4185         (~tui_source_window_base): Rename from ~tui_source_window.
4186         (tui_alloc_win_info): Create a tui_disasm_window.
4187
4188 2019-06-25  Tom Tromey  <tom@tromey.com>
4189
4190         * tui/tui-data.h (struct tui_source_window)
4191         (struct tui_data_window): Declare destructors.
4192         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4193         destructors.
4194         (tui_win_info): Simplify.
4195
4196 2019-06-25  Tom Tromey  <tom@tromey.com>
4197
4198         * tui/tui-winsource.c (tui_display_main)
4199         (tui_update_source_windows_with_addr)
4200         (tui_update_all_breakpoint_info): Update.
4201         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4202         (new_height_ok, parse_scrolling_args): Update.
4203         * tui/tui-stack.c (tui_show_frame_info): Update.
4204         * tui/tui-data.h (struct tui_list): Remove.
4205         (tui_source_windows): Return a reference to a std::vector.
4206         * tui/tui-data.c (source_windows): Now a std::vector.
4207         (tui_source_windows): Change return type.
4208         (tui_clear_source_windows): Rewrite.
4209         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4210         (tui_free_all_source_wins_content): Rewrite.
4211
4212 2019-06-25  Tom Tromey  <tom@tromey.com>
4213
4214         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4215         (struct tui_data_window, struct tui_cmd_window): Declare
4216         clear_detail method.
4217         * tui/tui-data.c (tui_source_window::clear_detail)
4218         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4219         methods.
4220         (tui_clear_win_detail): Simplify.
4221
4222 2019-06-25  Tom Tromey  <tom@tromey.com>
4223
4224         * tui/tui-layout.c (make_source_window, make_disasm_window)
4225         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4226         Return the new window.
4227         (show_source_disasm_command, show_data)
4228         (show_source_or_disasm_and_command): Update.
4229
4230 2019-06-25  Tom Tromey  <tom@tromey.com>
4231
4232         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4233         parameter.  Return the new window.
4234         (show_source_disasm_command): Update and remove NULL check.
4235         (show_source_or_disasm_and_command): Update.
4236
4237 2019-06-25  Tom Tromey  <tom@tromey.com>
4238
4239         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4240
4241 2019-06-25  Tom Tromey  <tom@tromey.com>
4242
4243         * tui/tui-data.h (struct tui_win_info): Make constructor
4244         protected.  Make destructor virtual.  Add initializers.
4245         (tui_source_window, tui_data_window, tui_cmd_window): New
4246         classes.
4247         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4248         constructor.  Add "type" parameter.
4249         (tui_source_window, tui_data_window, tui_cmd_window): New
4250         constructors.
4251         (tui_alloc_win_info): Instantiate the appropriate subclass.
4252
4253 2019-06-25  Tom Tromey  <tom@tromey.com>
4254
4255         * tui/tui-win.c (tui_resize_all): Use delete.
4256         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4257         destructor.
4258         (tui_free_window): Don't declare.
4259         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4260         Update.
4261
4262 2019-06-25  Tom Tromey  <tom@tromey.com>
4263
4264         * tui/tui-data.h (struct tui_win_info): Add constructor.
4265         * tui/tui-data.c (tui_alloc_win_info): Use new.
4266         (tui_free_window): Use delete.
4267
4268 2019-06-22  Tom Tromey  <tom@tromey.com>
4269
4270         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4271         declare.
4272         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4273
4274 2019-06-22  Tom Tromey  <tom@tromey.com>
4275
4276         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4277         declare.
4278         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4279
4280 2019-06-22  Tom de Vries  <tdevries@suse.de>
4281
4282         * dwarf2read.c (create_addrmap_from_aranges)
4283         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4284         instead of '%zu'.
4285
4286 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4287
4288         * dwarf2read.h (dwarf2_section_info_def): Remove.
4289         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4290         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4291         std::vector<dwarf2_section_info>.
4292         (struct dwo_file) <~dwo_file>: Remove.
4293         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4294         types field.
4295         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4296         (dwarf2_read_debug_names): Likewise.
4297         (create_debug_types_hash_table): Change parameter type to
4298         array_view, adjust code accordingly.
4299         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4300         (partial_die_info::fixup): Likewise.
4301         (determine_prefix): Likewise.
4302         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4303
4304 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4305
4306         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4307         gdb_bfd_ref_ptr.
4308         <~dwo_file>: Remove call to gdb_bfd_unref.
4309         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4310         gdb_bfd_ref_ptr::get.
4311
4312 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4313
4314         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4315         type to htab_up.
4316         * dwarf2read.c (struct dwo_file): Initialize fields.
4317         <~dwo_file>: New.
4318         (free_dwo_file): Remove, move content to ~dwo_file.
4319         (struct dwo_file_deleter): Remove.
4320         (dwo_file_up>: Remove custom deleter.
4321         (free_dwo_files): Remove.
4322         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4323         dwo_files.
4324         (process_skeletonless_type_units): Call unique_ptr::get.
4325         (allocate_dwo_file_hash_table): Add deleter to created hash
4326         table.  Change return type to htab_up.
4327         (lookup_dwo_file_slot): Don't memset dwo_file, call
4328         unique_ptr::get.
4329         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4330         (create_dwo_unit_in_dwp_v2): Likewise.
4331         (open_and_init_dwo_file): Likewise.
4332         (free_dwo_file_from_slot): Remove.
4333
4334 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4335
4336         * dwarf2read.h (struct dwarf2_section_info) <readin,
4337         is_virtual>: Change type to bool.
4338         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4339         true instead of 1.
4340
4341 2019-06-19  Tom Tromey  <tom@tromey.com>
4342
4343         * tui/tui-data.h (tui_init_content_element): Don't declare.
4344
4345 2019-06-19  Tom Tromey  <tom@tromey.com>
4346
4347         * tui/tui-data.h (tui_init_win_info): Don't declare.
4348
4349 2019-06-19  Tom de Vries  <tdevries@suse.de>
4350
4351         * dwarf2read.h (abstract_to_concrete): Change type to
4352         std::unordered_map<sect_offset, std::vector<sect_offset>,
4353         gdb::hash_enum<sect_offset>>.
4354
4355 2019-06-19  Tom Tromey  <tromey@adacore.com>
4356
4357         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4358         EVAL_AVOID_SIDE_EFFECTS specially.
4359
4360 2019-06-19  Tom Tromey  <tromey@adacore.com>
4361
4362         * source-cache.c (highlighter): New global.
4363         (source_cache::get_source_lines): Create a highlighter on demand.
4364
4365 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4366
4367         * defs.h (deprecated_interactive_hook): Delete declaration.
4368         * interps.c (clear_interpreter_hooks): Remove use of
4369         deprecated_interactive_hook.
4370         * top.c (deprecated_interactive_hook): Delete definition.
4371         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4372
4373 2019-06-18  Tom de Vries  <tdevries@suse.de>
4374
4375         PR gdb/24515
4376         * dwarf2read.h (abstract_to_concrete): Change type from
4377         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4378         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4379         * dwarf2read.c (read_variable): Update.
4380         (dwarf2_fetch_die_loc_sect_off): Update.
4381
4382 2019-06-17  Tom de Vries  <tdevries@suse.de>
4383
4384         PR gdb/24617
4385         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4386         accessing parent[parent_len - 1].
4387
4388 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4389
4390         PR gdb/24364
4391         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4392         call dtrace_process_dof with NULL dof.
4393
4394 2019-06-16  Tom de Vries  <tdevries@suse.de>
4395
4396         PR gdb/24445
4397         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4398
4399 2019-06-16  Tom Tromey  <tom@tromey.com>
4400
4401         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4402         (make_all_visible): Use address of member.
4403
4404 2019-06-16  Tom Tromey  <tom@tromey.com>
4405
4406         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4407         (tui_free_window, free_content, free_content_elements): Remove
4408         unnecessary cast.
4409         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4410         cast.
4411         * tui/tui-regs.c (tui_show_register_group)
4412         (tui_display_registers_from, tui_display_reg_element_at_line):
4413         Remove unnecessary cast.
4414
4415 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4416
4417         * linux-nat.c (normal_mask): Delete.
4418         (_initialize_linux_nat): Don't initialise normal_mask.
4419
4420 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4421
4422         PR gdb/24445
4423         * dwarf-index-write.h (write_psymtabs_to_index): Add
4424         dwz_basename parameter.
4425         * dwarf-index-write.c (write_gdbindex): Move file writing to
4426         write_gdbindex_1.  Change return type void.
4427         (assert_file_size): Move up, remove filename parameter.
4428         (write_gdbindex_1): New function.
4429         (write_debug_names): Change return type to void, call
4430         assert_file_size.
4431         (struct index_wip_file): New struct.
4432         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4433         file logic to index_wip_file.  Write index for dwz file if
4434         needed.
4435         (save_gdb_index_command): Pass basename of dwz file, if present.
4436         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4437         build-id of dwz file, if present.
4438         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4439         (dwarf2_get_dwz_file): Likewise.
4440         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4441         (dwarf2_get_dwz_file): Likewise.
4442
4443 2019-06-16  Tom Tromey  <tom@tromey.com>
4444
4445         * coffread.c (process_coff_symbol): Use xstrdup.
4446         * value.c (create_internalvar): Use xstrdup.
4447
4448 2019-06-16  Tom Tromey  <tom@tromey.com>
4449
4450         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4451         * breakpoint.c (stopin_command, stopat_command)
4452         (until_break_command, decode_location_default): Remove unnecessary
4453         cast.
4454         * utils.c (subset_compare): Remove unnecessary cast.
4455         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4456         cast.
4457         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4458         cast.
4459         * infcmd.c (path_command): Remove unnecessary cast.
4460         * coffread.c (decode_type): Remove unnecessary cast.
4461         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4462         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4463         * tui/tui-stack.c (tui_show_locator_content)
4464         (tui_show_frame_info): Remove unnecessary cast.
4465         * tui/tui-win.c (tui_scroll_forward_command)
4466         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4467         (parse_scrolling_args): Remove unnecessary cast.
4468         * tui/tui-data.c (init_win_info, tui_del_window)
4469         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4470         (free_content_elements): Remove unnecessary cast.
4471         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4472         unnecessary cast.
4473         * tui/tui-source.c (tui_set_source_content)
4474         (tui_vertical_source_scroll): Remove unnecessary cast.
4475         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4476         cast.
4477         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4478         * tui/tui-regs.c (tui_display_registers_from)
4479         (tui_display_register): Remove unnecessary cast.
4480         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4481         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4482         (make_visible): Remove unnecessary cast.
4483         * tui/tui-winsource.c (tui_erase_source_content)
4484         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4485         unnecessary cast.
4486         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4487         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4488         * stabsread.c (read_type, read_array_type, read_range_type):
4489         Remove unnecessary cast.
4490         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4491         (parse_symbol, parse_type, upgrade_type, parse_external)
4492         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4493         unnecessary cast.
4494         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4495
4496 2019-06-16  Tom Tromey  <tom@tromey.com>
4497
4498         * tui/tui-data.c (tui_alloc_generic_win_info)
4499         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4500         checks.
4501
4502 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4503             Andrew Burgess  <andrew.burgess@embecosm.com>
4504
4505         * f-typeprint.c (f_print_type): Don't return early for not
4506         associated or not allocated types.
4507         (f_type_print_varspec_suffix): Add print_rank parameter and print
4508         ranks of array types in case they dangling.
4509         (f_type_print_base): Add print_rank parameter.
4510
4511 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4512
4513         * NEWS: Mention new MI commands.
4514         * break-catch-throw.c (enum exception_event_kind): Move to
4515         breakpoint.h.
4516         (print_mention_exception_catchpoint): Output text as a single
4517         message.
4518         (catch_exception_command_1): Rename to...
4519         (catch_exception_event): ...this, make non-static, update header
4520         command, and change some parameter types.
4521         (catch_catch_command): Update for changes to
4522         catch_exception_command_1.
4523         (catch_throw_command): Likewise.
4524         (catch_rethrow_command): Likewise.
4525         * breakpoint.c (enum exception_event_kind): Delete.
4526         * breakpoint.h (enum exception_event_kind): Moved here from
4527         break-catch-throw.c.
4528         (catch_exception_event): Declare.
4529         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4530         (mi_cmd_catch_throw): New function.
4531         (mi_cmd_catch_rethrow): New function.
4532         (mi_cmd_catch_catch): New function.
4533         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4534         'catch-catch' entries.
4535         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4536         (mi_cmd_catch_rethrow): Declare.
4537         (mi_cmd_catch_catch): Declare.
4538
4539 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4540
4541         * annotate.c (annotate_source_line): Change return type to void,
4542         update implementation to match.
4543         * annotate.h (annotate_source_line): Change return type to void,
4544         update header comment.
4545         * stack.c (print_frame_info): Don't change what frame information
4546         is printed based on whether annotations are on or not.
4547
4548 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4549
4550         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4551         (annotate_source): Make static.
4552         (annotate_source_line): Moved from source.c and renamed from
4553         identify_source_line.  Update the return type.
4554         * annotate.h (annotate_source): Delete declaration.
4555         (annotate_source_line): Declaration moved from source.h, and
4556         renamed from identify_source_line.  Return type updated.
4557         * source.c (identify_source_line): Moved to annotate.c and renamed
4558         to annotate_source_line.
4559         (info_line_command): Remove check of annotation_level.
4560         * source.h (identify_source_line): Move declaration to annotate.h
4561         and rename to annotate_source_line.
4562         * stack.c: Add 'annotate.h' include.
4563         (print_frame_info): Remove check of annotation_level before
4564         calling annotate_source_line.
4565
4566 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * source-cache.c (source_cache::get_plain_source_lines): Use
4569         open_source_file_with_line_charpos instead of just
4570         open_source_file, remove call to find_source_lines.
4571         (source_cache::get_source_lines): Likewise.
4572         * source.c (find_source_lines): Make static.
4573         (get_filename_and_charpos): Renamed into...
4574         (open_source_file_with_line_charpos): ..this along with changes to
4575         return a scoped_fd, and some other minor clean ups.
4576         (identify_source_line): Use open_source_file_with_line_charpos.
4577         (search_command_helper): Use open_source_file_with_line_charpos
4578         instead of just open_source_file, remove call to
4579         find_source_lines.
4580         * source.h (open_source_file_with_line_charpos): Declare new
4581         function.
4582         (find_source_lines): Delete declaration.
4583
4584 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4585
4586         * source.c (get_filename_and_charpos): Remove fullname
4587         parameter.
4588         (identify_source_line): Update call to get_filename_and_charpos.
4589
4590 2019-06-14  Tom Tromey  <tromey@adacore.com>
4591
4592         PR gdb/24502:
4593         * ui-style.h (skip_ansi_escape): Update comment.
4594         * ui-file.h (class no_terminal_escape_file): New class.
4595         * ui-file.c (no_terminal_escape_file::write)
4596         (no_terminal_escape_file::puts): New methods.
4597         * cli/cli-logging.c (handle_redirections): Use
4598         no_terminal_escape_file.
4599
4600 2019-06-14  Tom Tromey  <tromey@adacore.com>
4601
4602         * NEWS: Move convenience variable news above Python news.
4603
4604 2019-06-14  Tom Tromey  <tom@tromey.com>
4605
4606         * gnulib: Move directory to top-level.
4607         * configure.ac: Don't configure gnulib.
4608         * configure: Rebuild.
4609         * common/common-defs.h: Use new path to gnulib.
4610         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4611         (GNULIB_H): Remove.
4612         (INCGNU): Look in new gnulib location.
4613         (HFILES_NO_SRCDIR): Remove gnulib files.
4614         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4615         (generated_files): Remove GNULIB_H.
4616         ($(LIBGNU), all-lib): Remove targets.
4617         (distclean): Don't mention GNULIB_BUILDDIR.
4618         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4619
4620 2019-06-14  Tom Tromey  <tromey@adacore.com>
4621
4622         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4623         Warn if symbol file does not provide any symbols.
4624
4625 2019-06-14  Tom Tromey  <tromey@adacore.com>
4626
4627         * source.c (find_and_open_source): Respect basenames_may_differ.
4628
4629 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4630
4631         * annotate.c (annotate_breakpoints_invalid): Make use of
4632         scoped_restore_terminal_state.
4633         (annotate_frames_invalid): Likewise.
4634
4635 2019-06-14  Tom Tromey  <tromey@adacore.com>
4636
4637         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4638         allow assignment to an internalvar.
4639
4640 2019-06-14  Tom Tromey  <tromey@adacore.com>
4641
4642         * ada-lex.l: Allow "_" in attribute names.
4643
4644 2019-06-14  Tom Tromey  <tromey@adacore.com>
4645
4646         PR gdb/24653:
4647         * regcache.c (registers_changed): Don't call alloca.
4648         * top.c (execute_command): Don't call alloca.
4649
4650 2019-06-13  Pedro Alves  <palves@redhat.com>
4651
4652         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4653         'expression'.  When parsing an expression, error out if there's
4654         junk after "unlimited".
4655         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4656         (do_set_command): Adjust calls to is_unlimited_literal.
4657
4658 2019-06-13  Pedro Alves  <palves@redhat.com>
4659
4660         * compile/compile.c (make_compile_options_def_group): Add braces
4661         around array_view initializer.
4662         * thread.c (make_thread_apply_all_options_def_group)
4663         (make_thread_apply_all_options_def_group): Likewise.
4664
4665 2019-06-13  Pedro Alves  <palves@redhat.com>
4666
4667         * NEWS (New commands): Mention "maint test-options
4668         require-delimiter", "maint test-options unknown-is-error", "maint
4669         test-options unknown-is-operand" and "maint show
4670         test-options-completion-result".
4671         (New command options, command completion): New section.
4672         (Completion improvements): New section.
4673         Mention that you can abbreviate "unlimited".
4674
4675 2019-06-13  Pedro Alves  <palves@redhat.com>
4676
4677         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4678         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4679         * unittests/cli-utils-selftests.c (test_parse_flags)
4680         (test_parse_flags_qcs): Delete.
4681         (test_cli_utils): Don't call deleted functions.
4682
4683 2019-06-13  Pedro Alves  <palves@redhat.com>
4684
4685         * thread.c: Include "cli/cli-option.h".
4686         (tp_array_compar_ascending): Global.
4687         (tp_array_compar): Delete function.
4688         (tp_array_compar_ascending, tp_array_compar_descending): New
4689         functions.
4690         (ascending_option_def, qcs_flag_option_def)
4691         (thr_qcs_flags_option_defs)
4692         (make_thread_apply_all_options_def_group)
4693         (make_thread_apply_options_def_group): New.
4694         (thread_apply_all_command): Use gdb::option::process_options.
4695         (thread_apply_command_completer)
4696         (thread_apply_all_command_completer): New.
4697         (thread_apply_command): Use gdb::option::process_options.
4698         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4699         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4700         to generate help text of "thread apply".  Adjust "taas"'s help.
4701         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4702         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4703
4704 2019-06-13  Pedro Alves  <palves@redhat.com>
4705
4706         * thread.c (thread_apply_command): Check for invalid TID with
4707         isdigit instead of !isalpha.
4708
4709 2019-06-13  Pedro Alves  <palves@redhat.com>
4710
4711         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4712         (validate_flags_qcs): New.
4713         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4714         (validate_flags_qcs): Declare.
4715         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4716         (make_frame_apply_options_def_group): New.
4717         (frame_apply_command_count): Process options with
4718         gdb::option::process_options.
4719         (frame_apply_completer): New.
4720         (frame_apply_level_completer, frame_apply_all_completer)
4721         (frame_apply_completer): New.
4722         (_initialize_stack): Update help of "frame apply", "frame apply
4723         level", "frame apply all" and "faas" to mention supported options
4724         and install command completers.
4725         * stack.h (frame_apply_all_completer): Declare.
4726         * thread.c: Include "stack.h".
4727         (tfaas_command): Add "--".
4728         (_initialize_thread): Update help "tfaas" to mention supported
4729         options and install command completer.
4730
4731 2019-06-13  Pedro Alves  <palves@redhat.com>
4732
4733         * completer.c (complete_nested_command_line): New.
4734         (gdb_completion_word_break_characters_throw): Add assertion.
4735         * completer.h (complete_nested_command_line): Declare.
4736
4737 2019-06-13  Pedro Alves  <palves@redhat.com>
4738
4739         * stack.c (parse_backtrace_qualifiers): New.
4740         (backtrace_command): Use it.
4741         (backtrace_command_completer): Complete on qualifiers.
4742
4743 2019-06-13  Pedro Alves  <palves@redhat.com>
4744
4745         * frame.c: Include "cli/cli-option.h.
4746         (user_set_backtrace_options): New.
4747         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4748         Delete.
4749         (get_prev_frame): Adjust.
4750         (boolean_option_def, uinteger_option_def)
4751         (set_backtrace_option_defs): New.
4752         (_initialize_frame): Adjust and use
4753         gdb::option::add_setshow_cmds_for_options to install "set
4754         backtrace past-main" and "set backtrace past-entry".
4755         * frame.h: Include "cli/cli-option.h".
4756         (struct frame_print_options): Forward declare.
4757         (print_frame_arguments_all, print_frame_arguments_scalars)
4758         (print_frame_arguments_none): Declare.
4759         (print_entry_values): Delete declaration.
4760         (struct frame_print_options, user_frame_print_options): New.
4761         (struct set_backtrace_options): New.
4762         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4763         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4764         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4765         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4766         (list_args_or_locals): Add frame_print_options parameter.
4767         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4768         * python/py-framefilter.c (enumerate_args): Pass down
4769         USER_FRAME_PRINT_OPTIONS.
4770         * stack.c: Include "cli/cli-option.h".
4771         (print_frame_arguments_all, print_frame_arguments_scalars)
4772         (print_frame_arguments_none): Declare.
4773         (print_raw_frame_arguments, print_entry_values): Delete.
4774         (user_frame_print_options): New.
4775         (boolean_option_def, enum_option_def, frame_print_option_defs):
4776         New.
4777         (struct backtrace_cmd_options): New.
4778         (bt_flag_option_def): New.
4779         (backtrace_command_option_defs): New.
4780         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4781         (print_frame_arg, read_frame_arg, print_frame_args)
4782         (print_frame_info, print_frame): Add frame_print_options parameter
4783         and use it.
4784         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4785         (backtrace_command_1): Add frame_print_options and
4786         backtrace_cmd_options parameters and use them.
4787         (make_backtrace_options_def_group): New.
4788         (backtrace_command): Process command options with
4789         gdb::option::process_options.
4790         (backtrace_command_completer): New.
4791         (_initialize_stack): Extend "backtrace"'s help to mention
4792         supported options.  Install completer for "backtrace".
4793         Install some settings commands with add_setshow_cmds_for_options.
4794
4795 2019-06-13  Pedro Alves  <palves@redhat.com>
4796
4797         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4798         and that "set/show print raw frame-arguments" are now deprecated.
4799
4800         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4801         command.
4802         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4803         * stack.c (_initialize_stack): Install "set/show print
4804         raw-frame-arguments", and deprecate "set/show print raw
4805         frame-arguments".
4806         * valprint.c (_initialize_valprint): Deprecate "set/show print
4807         raw".
4808
4809 2019-06-13  Pedro Alves  <palves@redhat.com>
4810
4811         * compile/compile.c (struct compile_options): New.
4812         (compile_flag_option_def, compile_command_option_defs)
4813         (make_compile_options_def_group): New.
4814         (compile_file_command): Handle options with
4815         gdb::option::process_options.
4816         (compile_file_command_completer): New function.
4817         (compile_code_command): Handle options with
4818         gdb::option::process_options.
4819         (compile_code_command_completer): New function.
4820         (_initialize_compiler): Install completers for "compile code" and
4821         "compile file".  Mention available options in "compile code" and
4822         "compile code"'s help.
4823         * completer.c (advance_to_completion_word): New, factored out from
4824         ...
4825         (advance_to_expression_complete_word_point): ... this.
4826         (advance_to_filename_complete_word_point): New.
4827         * completer.h (advance_to_filename_complete_word_point): New
4828         declaration.
4829
4830 2019-06-13  Pedro Alves  <palves@redhat.com>
4831
4832         * compile/compile.c: Include "cli/cli-option.h".
4833         (compile_print_value): Scope data pointer is now a
4834         value_print_options pointer; adjust.
4835         (compile_print_command): Process options.  Scope data pointer is
4836         now a value_print_options pointer; adjust.
4837         (_initialize_compile): Update "compile print"'s help to include
4838         supported options.  Install a completer for "compile print".
4839         * cp-valprint.c (show_vtblprint, show_objectprint)
4840         (show_static_field_print): Delete.
4841         (_initialize_cp_valprint): Don't install "set print
4842         static-members", "set print vtbl", "set print object" here.
4843         * printcmd.c: Include "cli/cli-option.h" and
4844         "common/gdb_optional.h".
4845         (print_command_parse_format): Rework to fill in a
4846         value_print_options instead of a format_data.
4847         (print_value): Change parameter type from format_data pointer to
4848         value_print_options reference.  Adjust.
4849         (print_command_1): Process options.  Adjust to pass down a
4850         value_print_options.
4851         (print_command_completer): New.
4852         (_initialize_printcmd): Install print_command_completer as
4853         handle_brkchars completer for the "print" command.  Update
4854         "print"'s help to include supported options.
4855         * valprint.c: Include "cli/cli-option.h".
4856         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4857         here from cp-valprint.c.
4858         (boolean_option_def, uinteger_option_def)
4859         (value_print_option_defs, make_value_print_options_def_group):
4860         New.  Use gdb::option::add_setshow_cmds_for_options to install
4861         "set print elements", "set print null-stop", "set print repeats",
4862         "set print pretty", "set print union", "set print array", "set
4863         print address", "set print symbol", "set print array-indexes".
4864         * valprint.h: Include <string> and "cli/cli-option.h".
4865         (make_value_print_options_def_group): Declare.
4866         (print_value): Change parameter type from format_data pointer to
4867         value_print_options reference.
4868         (print_command_completer): Declare.
4869
4870 2019-06-13  Pedro Alves  <palves@redhat.com>
4871
4872         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4873         (COMMON_SFILES): Add maint-test-settings.c.
4874         * cli/cli-decode.c (boolean_enums): New global, factored out from
4875         ...
4876         (add_setshow_boolean_cmd): ... here.
4877         * cli/cli-decode.h (boolean_enums): Declare.
4878         * cli/cli-option.c: New file.
4879         * cli/cli-option.h: New file.
4880         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4881         factored out from ...
4882         (parse_cli_boolean_value(const char *)): ... this.
4883         (is_unlimited_literal): Change parameter type to pointer to
4884         pointer.  Adjust and advance ARG pointer.
4885         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4886         (parse_cli_var_enum): New, factored out from ...
4887         (do_set_command): ... this.  Adjust.
4888         * cli/cli-setshow.h (parse_cli_boolean_value)
4889         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4890         (parse_cli_var_enum): Declare.
4891         * cli/cli-utils.c: Include "cli/cli-option.h".
4892         (get_ulongest): New.
4893         * cli/cli-utils.h (get_ulongest): Declare.
4894         (check_for_argument): New overloads.
4895         * maint-test-options.c: New file.
4896
4897 2019-06-13  Pedro Alves  <palves@redhat.com>
4898
4899         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4900         parse a range if "-" is at the end of the string.
4901
4902 2019-06-13  Pedro Alves  <palves@redhat.com>
4903
4904         * cli/cli-setshow.c (parse_auto_binary_operation)
4905         (parse_cli_boolean_value): Don't allow "o".
4906
4907 2019-06-13  Pedro Alves  <palves@redhat.com>
4908
4909         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4910         * NEWS: Mention maint test-settings KIND.
4911         * maint-test-settings.c: New file.
4912
4913 2019-06-13  Pedro Alves  <palves@redhat.com>
4914
4915         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4916         completer.
4917         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4918         "set" completers.
4919
4920 2019-06-13  Pedro Alves  <palves@redhat.com>
4921
4922         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4923         after item.
4924
4925 2019-06-13  Pedro Alves  <palves@redhat.com>
4926
4927         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4928
4929 2019-06-13  Pedro Alves <palves@redhat.com>
4930
4931         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4932         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4933         call.
4934         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4935         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4936         calls.
4937         (check_for_argument): Skip spaces after argument.
4938
4939 2019-06-13  Pedro Alves  <palves@redhat.com>
4940
4941         * thread.c (thread_apply_command): Adjust TID parsing.
4942         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4943         detected before end of string.
4944         (tid_is_in_list): Error out if LIST is invalid.
4945
4946 2019-06-13  Pedro Alves  <palves@redhat.com>
4947
4948         * completer.c (complete_line_internal_1): Rewind completion word
4949         point.
4950         (completion_tracker::advance_custom_word_point_by): Change
4951         parameter type to int.
4952         * completer.h (completion_tracker::advance_custom_word_point_by):
4953         Likewise.
4954
4955 2019-06-13  Pedro Alves  <palves@redhat.com>
4956
4957         * completer.c (advance_to_completion_word): Handle delimiters.
4958
4959 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4960
4961         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4962
4963 2019-06-11  Tom Tromey  <tom@tromey.com>
4964
4965         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4966         (xmalloc_failed): Move to alloc.c.
4967         * alloc.c: New file.
4968         * Makefile.in (COMMON_SFILES): Add alloc.c.
4969
4970 2019-06-11  Tom Tromey  <tom@tromey.com>
4971
4972         * nat/linux-waitpid.c: Don't include server.h.
4973         (linux_debug): Remove.
4974         (my_waitpid): Update.
4975
4976 2019-06-11  Tom Tromey  <tromey@adacore.com>
4977
4978         * infcall.c (_initialize_infcall): Remove trailing newline from
4979         help.
4980         * user-regs.c (_initialize_user_regs): Remove trailing newline
4981         from help.
4982         * typeprint.c (_initialize_typeprint): Remove trailing newline
4983         from help.
4984         * reverse.c (_initialize_reverse): Remove trailing newlines from
4985         help.
4986         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4987         from help.
4988         * language.c (add_set_language_command): Remove trailing newline
4989         from help.
4990         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4991         help.
4992         * disasm.c (_initialize_disasm): Remove trailing newline from
4993         help.
4994         * top.c (init_main): Remove trailing newline from help.
4995         * interps.c (_initialize_interpreter): Remove trailing newline
4996         from help.
4997         * btrace.c (_initialize_btrace): Remove trailing newlines from
4998         help.
4999         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5000         from help.
5001         * python/python.c (_initialize_python): Remove trailing newline
5002         from help.
5003         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5004         help.
5005         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5006         from help.  Reformat some text.
5007         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5008         from help.
5009         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5010         newline from help.
5011
5012 2019-06-11  Tom Tromey  <tromey@adacore.com>
5013
5014         * darwin-nat.c (darwin_decode_exception_message)
5015         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5016
5017 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5018
5019         * valops.c (value_slice): Check for not allocated or not
5020         associated values.
5021
5022 2019-06-10  Tom de Vries  <tdevries@suse.de>
5023
5024         PR gdb/24618
5025         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5026         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5027         invalid.
5028
5029 2019-06-10  Tom de Vries  <tdevries@suse.de>
5030
5031         PR gdb/24611
5032         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5033         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5034
5035 2019-06-10  Tom de Vries  <tdevries@suse.de>
5036
5037         PR symtab/24545
5038         * symtab.c (struct demangled_name_entry): Add language field.
5039         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5040         static minimal symbol".  Set and use language field.
5041
5042 2019-06-10  Tom Tromey  <tromey@adacore.com>
5043
5044         * ada-lang.c (_initialize_ada_language): Update help text.
5045
5046 2019-06-10  Tom Tromey  <tromey@adacore.com>
5047
5048         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5049         with a newline.
5050         * guile/guile.c (handle_boot_error): Don't end warning with a
5051         newline.
5052         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5053         warning with a newline.
5054         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5055         newline.
5056         (s12z_frame_cache): Likewise.
5057         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5058         a newline.
5059         * solib-svr4.c (disable_probes_interface): Don't end warning with
5060         a newline.
5061         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5062         newline.
5063         * python/python.c (do_finish_initialization): Don't end warning
5064         with a newline.
5065
5066 2019-06-10  Tom Tromey  <tom@tromey.com>
5067
5068         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5069         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5070         gdbpy_enter.
5071
5072 2019-06-10  Tom Tromey  <tromey@adacore.com>
5073
5074         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5075         data.
5076         (elf_new_init): Don't call stabsread_new_init.
5077         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5078         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5079         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5080
5081 2019-06-10  Tom de Vries  <tdevries@suse.de>
5082
5083         PR symtab/16264
5084         PR symtab/24517
5085         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5086
5087 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5088
5089         * source.c (find_and_open_source): Also rewrite relative file
5090         names.
5091
5092 2019-04-26  Amos Bird  <amosbird@gmail.com>
5093
5094         * annotate.c (annotate_thread_exited): Add "thread-exited"
5095         annotation.
5096
5097 2019-06-06  Tom Tromey  <tromey@adacore.com>
5098
5099         * maint.h (class scoped_command_stats): Use
5100         DISABLE_COPY_AND_ASSIGN.
5101         <print_time>: New method.
5102         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5103         print_time.
5104         (scoped_command_stats::print_time): New method.
5105
5106 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5107
5108         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5109         instructions of lengths 6 or 8 bytes.
5110
5111 2019-06-04  Pedro Alves  <palves@redhat.com>
5112
5113         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5114
5115         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5116         * breakpoint.c (condition_completer): Likewise.
5117         * cli/cli-dump.c (scan_expression): Likewise.
5118         * common/filestuff.c (mkdir_recursive): Likewise.
5119         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5120         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5121         (gdb_abspath): Likewise.
5122         * compile/compile-cplus-types.c
5123         (compile_cplus_instance::decl_name): Likewise.
5124         * completer.c (complete_explicit_location):
5125         (signal_completer, reg_or_group_completer_1): Likewise.
5126         * cp-support.c (cp_remove_params_if_any): Likewise.
5127         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5128         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5129         * infcmd.c (strip_bg_char): Likewise.
5130         * linespec.c (copy_token_string): Likewise.
5131         * mi/mi-main.c (output_cores): Likewise.
5132         * psymtab.c (psymtab_search_name):
5133         * symfile.c (test_set_ext_lang_command): Likewise.
5134         * target.c (target_fileio_read_stralloc): Likewise.
5135         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5136         * value.c (complete_internalvar): Likewise.
5137
5138 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5139
5140         Add objfile property to gdb.Type.
5141         * NEWS: Mention Python API addition.
5142         * python/py-type.c (typy_get_objfile): New method.
5143
5144 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5145
5146         * NEWS: Mention the new set|show style [title|highlight].
5147         Mention changes to "show style", "help" and "apropos".
5148
5149 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5150
5151         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5152         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5153         instead of print_help_for_command.
5154         (print_doc_of_command): New function.
5155         (help_list): Add 'apropos -v word' suggestion.
5156         (print_help_for_command): Style the command name using title style.
5157         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5158         (_initialize_cli_cmds): Describe -v in apropos_command help.
5159
5160 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5161
5162         * cli/cli-style.h (cli_style_option): Add name in constructor,
5163         add m_name class member, add constructor with intensity,
5164         add name class function.
5165         (cli_style_option::add_setshow_commands): Remove name argument.
5166         (highlight_style, title_style): New styles.
5167         * cli/cli-style.c (do_show): New function that shows a style
5168         characteristic styling the style name with itself.
5169         (set_style_name): New function.
5170         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5171         Update all callers according to the changes in cli/cli-style.h.
5172         * utils.h (fputs_highlighted): New function.
5173         * utils.c (fputs_highlighted): Likewise.
5174
5175 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5176
5177         * NEWS: Mention new pipe command and new convenience variables.
5178
5179 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5180
5181         * cli/cli-cmds.c (pipe_command): New function.
5182         (_initialize_cli_cmds): Call add_com for pipe_command.
5183         Define | as an alias for pipe.
5184         (exit_status_set_internal_vars): New function.
5185         (shell_escape): Call exit_status_set_internal_vars.
5186         cli/cli-decode.c (find_command_name_length): Recognize | as
5187         a single character command.
5188
5189 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5190
5191         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5192         top.c (execute_command_to_ui_file): New function, mostly a copy
5193         of execute_command_to_string.
5194         (execute_command_to_string): Implement by calling
5195         execute_command_to_ui_file.
5196
5197 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5198
5199         * top.h (saved_command_line): Remove declaration.
5200         * top.c (previous_saved_command_line, previous_repeat_arguments):
5201         New variables.
5202         (saved_command_line): Make static, define together with other
5203         'repeat variables'.
5204         (dont_repeat): Clear repeat_arguments.
5205         (repeat_previous, get_saved_command_line, save_command_line):
5206         New functions.
5207         (gdb_init): Initialize saved_command_line
5208         and previous_saved_command_line.
5209         * main.c (captured_main_1): Remove saved_command_line initialization.
5210         * event-top.c (handle_line_of_input): Update to use
5211         the new 'repeat' related functions instead of direct access to
5212         saved_command_line.
5213         * command.h (repeat_previous, get_saved_command_line,
5214         save_command_line): New declarations.
5215         (dont_repeat): Add comment.
5216
5217 2019-05-30  Tom Tromey  <tromey@adacore.com>
5218
5219         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5220         Fix comment.
5221         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5222
5223 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5224
5225         PR cli/24587
5226         * completer.c (complete): Initialize variable word.
5227
5228 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5229
5230         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5231         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5232         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5233         'body' is NULL to the outter 'if', protecting the '!is_define'
5234         situation as well.
5235
5236 2019-05-29  Tom Tromey  <tromey@adacore.com>
5237
5238         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5239         (dwarf_unknown): New function.
5240         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5241         (dwarf_type_encoding_name): Use dwarf_unknown.
5242
5243 2019-05-29  Tom Tromey  <tromey@adacore.com>
5244
5245         PR c++/20020:
5246         * cp-valprint.c (cp_print_value_fields): Call
5247         cp_print_static_field inside "try".
5248
5249 2019-05-29  Tom Tromey  <tromey@adacore.com>
5250
5251         * inflow.c (struct terminal_info): Add default operator=.
5252         * configure: Rebuild.
5253         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5254         -Wdeprecated-copy-dtor, -Wredundant-move.
5255
5256 2019-05-29  Tom Tromey  <tromey@adacore.com>
5257
5258         * NEWS: Add entry.
5259         * infcmd.c (print_return_value_1): Handle finish_print
5260         option.
5261         (show_print_finish): New function.
5262         (_initialize_infcmd): Add "set/show print finish" commands.
5263         * valprint.c (user_print_options): Initialize new member.
5264         * valprint.h (struct value_print_options) <finish_print>: New
5265         member.
5266
5267 2019-05-28  Tom Tromey  <tromey@adacore.com>
5268
5269         * ada-lang.c (ada_remove_Xbn_suffix)
5270         (find_old_style_renaming_symbol)
5271         (parse_old_style_renaming): Remove.
5272         (ada_find_renaming_symbol): Don't call
5273         find_old_style_renaming_symbol.
5274         (ada_is_renaming_symbol): Rename from
5275         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5276         bool.  Now static.
5277         (ada_read_var_value): Update and simplify.
5278         * ada-exp.y (write_var_or_type): Remove old code.
5279
5280 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5281
5282         * event-top.c: Remove include comment.
5283         * inflow.c (class scoped_ignore_sigttou): Move from here...
5284         * inflow.h (class scoped_ignore_sigttou): ...to here.
5285         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5286         * top.c:  Remove include comment.
5287
5288 2019-05-27  Tom Tromey  <tom@tromey.com>
5289
5290         * NEWS: Fix typo.
5291
5292 2019-05-22  Tom Tromey  <tromey@adacore.com>
5293
5294         * target.c (target_follow_exec): Constify parameter.
5295         * target-delegates.c: Rebuild.
5296         * remote.c (remote_target::follow_exec): Constify parameter.
5297         * infrun.c (follow_exec): Constify parameter.
5298         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5299         (target_follow_exec): Likewise.
5300
5301 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5302
5303         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5304         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5305
5306 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5307
5308         * NEWS: Add debugredirect and testsuite sections.
5309
5310 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5311
5312         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5313         target descriptions using exclusively floating point register name
5314         aliases.
5315
5316 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5317
5318         PR gdb/18644:
5319         * f-lang.c (build_fortran_types): Handle the case where
5320         gdbarch_floatformat_for_type returns a nullptr.
5321
5322 2019-05-21  Tom de Vries  <tdevries@suse.de>
5323
5324         PR cli/24587
5325         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5326
5327 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5328
5329         PR gdb/18644:
5330         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5331         16-byte floats.
5332         * i386-tdep.c (i386_floatformat_for_type): Use
5333         floatformats_ia64_quad for the 16-byte floating point component
5334         within a fortran 32-byte complex number.
5335
5336 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5339         delete default constructor.
5340         (find_partial_die): Update to return const struct.
5341         (partial_die_parent_scope): Move variable declaration into scope
5342         of its use and change its type to auto.
5343         (guess_partial_die_structure_name): Likewise.
5344         (partial_die_info::fixup): Likewise.
5345
5346 2019-05-17  Tom Tromey  <tromey@adacore.com>
5347
5348         * source.c (find_and_open_source): Remove cast.
5349
5350 2019-05-17  Tom Tromey  <tromey@adacore.com>
5351
5352         * annotate.c (annotate_source): Make "filename" const.
5353         * annotate.h (annotate_source): Use const.
5354
5355 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5356
5357         * disasm.c (set_disassembler_options): Send errors to stderr.
5358
5359 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5360
5361         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5362         (cli_interp_base::set_logging): Check debug_redirect.
5363         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5364         * cli/cli-logging.c (debug_redirect): Add static variable.
5365         (pop_output_files): Add default param.
5366         (handle_redirections): Print debug setting.
5367         (show_logging_command): Likewise.
5368         (_initialize_cli_logging): Add debugredirect command.
5369         * interps.c (current_interp_set_logging): Add debug_redirect
5370         parameter.
5371         * interps.h (set_logging): Add debug_redirect parameter.
5372         (current_interp_set_logging): Likewise.
5373         * mi/mi-common.h: Likewise.
5374         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5375
5376 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5377             Tom Tromey  <tromey@adacore.com>
5378
5379         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5380         directly.
5381         * cli/cli-interp.h (make_logging_output): Remove declaration.
5382         * cli/cli-logging.c (make_logging_output): Remove function.
5383         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5384         directly.
5385         * ui-file.c (tee_file::tee_file): Remove bools.
5386         (tee_file::~tee_file): Remove deletes.
5387         * ui-file.h (tee_file): Remove bools.
5388
5389 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5390
5391         * mi/mi-cmds.h (mi_cmd_complete): New function.
5392         * mi/mi-main.c (mi_cmd_complete): Likewise.
5393         * mi/mi-cmds.c: Define new MI command -complete.
5394         * NEWS: Mention new -complete command.
5395
5396 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5397
5398         * completer.h (complete): New function.
5399         * completer.c (complete): Likewise.
5400         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5401         function defined in completer.h.
5402
5403 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5404
5405         * MAINTAINERS (Write After Approval): Add myself.
5406
5407 2019-05-17  Tom de Vries  <tdevries@suse.de>
5408
5409         PR gdb/24094
5410         * dwarf2read.c (struct cu_partial_die_info): New struct.
5411         (find_partial_die): Return cu_partial_die_info.
5412         (partial_die_parent_scope, guess_partial_die_structure_name)
5413         (partial_die_info::fixup): Handle new return type of find_partial_die.
5414
5415 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5416
5417         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5418         "std::string", simplifying the algorithm.
5419
5420 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5421
5422         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5423         (stap_static_probe_ops::get_probes): Likewise.
5424
5425 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5426
5427         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5428         '-')" and "else if".
5429         (stap_parse_single_operand): Join checks for
5430         "gdbarch_stap_parse_special_token_p" and
5431         "gdbarch_stap_parse_special_token" in the same "if" statement.
5432         Invert check when verifying for operation on register
5433         displacement.
5434
5435 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5436
5437         * stap-probe.c (stap_get_opcode): Update comment.
5438         (stap_get_expected_argument_type): Likewise.
5439         (handle_stap_probe): Likewise.
5440
5441 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5442
5443         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5444         return type to 'bool'.  Adjust comment.  Use 'bool' when
5445         appropriate.
5446         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5447         * stap-probe.c (stap_parse_argument_1): Likewise.
5448         (stap_is_operator): Likewise.
5449         (stap_is_generic_prefix): Likewise.
5450         (stap_is_register_prefix): Likewise.
5451         (stap_is_register_indirection_prefix): Likewise.
5452         (stap_is_integer_prefix): Likewise.
5453         (stap_generic_check_suffix): Likewise.
5454         (stap_check_integer_suffix): Likewise.
5455         (stap_check_register_suffix): Likewise.
5456         (stap_check_register_indirection_suffix): Likewise.
5457         (stap_parse_register_operand): Likewise.
5458         (stap_parse_single_operand): Likewise.
5459         (stap_parse_argument_1): Likewise.
5460         (stap_probe::get_argument_count): Likewise.
5461         (stap_is_operator): Likewise.
5462
5463 2019-05-16  Tom Tromey  <tromey@adacore.com>
5464
5465         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5466         keyword to foreach.
5467
5468 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5469
5470         * linux-thread-db.c (try_thread_db_load_1): Change return type
5471         to bool.
5472         (try_thread_db_load): Likewise.
5473         (try_thread_db_load_from_pdir_1): Likewise.
5474         (try_thread_db_load_from_pdir): Likewise.
5475         (try_thread_db_load_from_sdir): Likewise.
5476         (try_thread_db_load_from_dir): Likewise.
5477         (thread_db_load_search): Likewise.
5478         (has_libpthread): Likewise.
5479         (thread_db_load): Likewise.
5480
5481 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5482
5483         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5484         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5485         NULL, and complain/return if that's the case.
5486
5487 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5488
5489         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5490         (advance, posn, abstract_read_memory): New functions.
5491         [struct mem_read_abstraction]: New struct.
5492         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5493
5494 2019-05-14  Tom Tromey  <tromey@adacore.com>
5495
5496         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5497         value is not lval_memory.
5498
5499 2019-05-14  Tom Tromey  <tromey@adacore.com>
5500
5501         * solib.c (info_sharedlibrary_command): Style the file name.
5502
5503 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5504
5505         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5506         (aarch64_vnv_type): Likewise.
5507         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5508         * common/tdesc.c: Likewise.
5509         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5510         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5511         * features/aarch64-fpu.xml: Add ieee half view.
5512         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5513         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5514         * gdbtypes.h (struct builtin_type): Likewise.
5515         (struct objfile_type): Likewise.
5516
5517 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5518
5519         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5520         typo.
5521         * location.h (string_to_event_location): Likewise.
5522
5523 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5524
5525         GDB 8.3 released.
5526
5527 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5528
5529         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5530         New variable declaration.
5531         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5532         New variable.
5533         (print_one_breakpoint): Use ui_out::test_flags and new global
5534         variable to compute use_fixed_output.
5535         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5536         Remove.
5537         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5538         (mi_multi_location_breakpoint_output_fixed): Remove.
5539         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5540         new variable.
5541         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5542         fix_multi_location_breakpoint_output flag if version >= 3.
5543         * ui-out.h (enum ui_out_flag)
5544         <fix_multi_location_breakpoint_output>: New enumerator.
5545
5546 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5547
5548         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5549
5550 2019-05-10  Tom Tromey  <tromey@adacore.com>
5551
5552         * ada-lang.c (catch_ada_completer): New function.
5553         (_initialize_ada_language): Use it.
5554
5555 2019-05-10  Tom Tromey  <tromey@adacore.com>
5556
5557         * thread.c (print_thread_info): Make "requested_threads" const.
5558         * gdbthread.h (print_thread_info): Make "requested_threads"
5559         const.
5560         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5561         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5562
5563 2019-05-08  Tom Tromey  <tom@tromey.com>
5564
5565         * gdbtypes.c (objfile_type_data): Change type.
5566         (objfile_type, _initialize_gdbtypes): Update.
5567
5568 2019-05-08  Tom Tromey  <tom@tromey.com>
5569
5570         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5571         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5572         (_initialize_dwarf2_frame): Update.
5573
5574 2019-05-08  Tom Tromey  <tom@tromey.com>
5575
5576         * objc-lang.c (objc_objfile_data): Change type.
5577         (find_methods): Update.
5578         (_initialize_objc_lang): Remove.
5579
5580 2019-05-08  Tom Tromey  <tom@tromey.com>
5581
5582         * stabsread.c (rs6000_builtin_type_data): Change type.
5583         (rs6000_builtin_type, _initialize_stabsread): Update.
5584
5585 2019-05-08  Tom Tromey  <tom@tromey.com>
5586
5587         * mips-tdep.c (mips_pdr_data): Remove.
5588         (_initialize_mips_tdep): Update.
5589
5590 2019-05-08  Tom Tromey  <tom@tromey.com>
5591
5592         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5593         (hppa_init_objfile_priv_data, read_unwind_info)
5594         (find_unwind_entry, _initialize_hppa_tdep): Update.
5595
5596 2019-05-08  Tom Tromey  <tom@tromey.com>
5597
5598         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5599         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5600         on obstack.
5601         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5602
5603 2019-05-08  Tom Tromey  <tom@tromey.com>
5604
5605         * mdebugread.c (basic_type_data): Change type.
5606         (basic_type, _initialize_mdebugread): Update.
5607
5608 2019-05-08  Tom Tromey  <tom@tromey.com>
5609
5610         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5611
5612 2019-05-08  Tom Tromey  <tom@tromey.com>
5613
5614         * nto-tdep.c (nto_inferior_data_reg): Change type.
5615         (nto_inferior_data): Update.
5616         (nto_inferior_data_cleanup, nto_new_inferior_data)
5617         (_initialize_nto_tdep): Remove.
5618         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5619
5620 2019-05-08  Tom Tromey  <tom@tromey.com>
5621
5622         * ada-lang.c (struct ada_inferior_data): Add initializers.
5623         (ada_inferior_data): Change type.
5624         (ada_inferior_data_cleanup): Remove.
5625         (get_ada_inferior_data, ada_inferior_exit)
5626         (struct ada_pspace_data): Add initializers, destructor.
5627         (ada_pspace_data_handle): Change type.
5628         (get_ada_pspace_data): Update.
5629         (ada_pspace_data_cleanup): Remove.
5630
5631 2019-05-08  Tom Tromey  <tom@tromey.com>
5632
5633         * coffread.c (struct coff_symfile_info): Add initializers.
5634         (coff_objfile_data_key): Move lower.  Change type.
5635         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5636         Update.
5637         (coff_free_info): Remove.
5638
5639 2019-05-08  Tom Tromey  <tom@tromey.com>
5640
5641         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5642         (fbsd_pspace_data_handle): Move lower.  Change type.
5643         (get_fbsd_pspace_data): Update.
5644         (fbsd_pspace_data_cleanup): Remove.
5645         (_initialize_fbsd_tdep): Update.
5646
5647 2019-05-08  Tom Tromey  <tom@tromey.com>
5648
5649         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5650         (get_ada_tasks_pspace_data): Update.
5651         (ada_tasks_pspace_data_cleanup): Remove.
5652         (_initialize_tasks): Update.
5653         (ada_tasks_inferior_data_handle): Change type.
5654         (get_ada_tasks_inferior_data): Update.
5655         (ada_tasks_inferior_data_cleanup): Remove.
5656         (struct ada_tasks_pspace_data): Add initializers.
5657
5658 2019-05-08  Tom Tromey  <tom@tromey.com>
5659
5660         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5661         * symfile-debug.c (debug_sym_get_probes): Change type.
5662         * stap-probe.c (handle_stap_probe):
5663         (stap_static_probe_ops::get_probes): Change type.
5664         * probe.h (class static_probe_ops) <get_probes>: Change type.
5665         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5666         (parse_probes_in_pspace): Update.
5667         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5668         Update.
5669         (any_static_probe_ops::get_probes): Change type.
5670         * elfread.c (elfread_data): New typedef.
5671         (probe_key): Change type.
5672         (elf_get_probes): Likewise.  Update.
5673         (probe_key_free): Remove.
5674         (_initialize_elfread): Update.
5675         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5676         Change type.
5677         (dtrace_process_dof_probe, dtrace_process_dof)
5678         (dtrace_static_probe_ops::get_probe): Change type.
5679
5680 2019-05-08  Tom Tromey  <tom@tromey.com>
5681
5682         * xcoffread.c (struct xcoff_symfile_info): Rename from
5683         coff_symfile_info.  Add initializers.
5684         (xcoff_objfile_data_key): Move lower.  Change type.
5685         (XCOFF_DATA): Rewrite.
5686         (xcoff_free_info): Remove.
5687         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5688         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5689         (xcoff_initial_scan): Update.
5690
5691 2019-05-08  Tom Tromey  <tom@tromey.com>
5692
5693         * solib-svr4.c (struct svr4_info): Add initializers and
5694         destructor.
5695         <probes_table>: Now an htab_up.
5696         (solib_svr4_pspace_data): Change type.
5697         (free_probes_table): Simplify.
5698         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5699         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5700         (probes_table_remove_objfile_probes, register_solib_event_probe)
5701         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5702         (_initialize_svr4_solib): Update.
5703
5704 2019-05-08  Tom Tromey  <tom@tromey.com>
5705
5706         * remote.c (remote_pspace_data): Change type.
5707         (remote_pspace_data_cleanup): Remove.
5708         (get_remote_exec_file, set_pspace_remote_exec_file)
5709         (_initialize_remote): Update.
5710
5711 2019-05-08  Tom Tromey  <tom@tromey.com>
5712
5713         * breakpoint.c (breakpoint_objfile_key): Change type.
5714         (get_breakpoint_objfile_data): Update.
5715         (free_breakpoint_objfile_data): Remove.
5716         (_initialize_breakpoint): Update.
5717
5718 2019-05-08  Tom Tromey  <tom@tromey.com>
5719
5720         * linux-tdep.c (struct linux_info): Add initializers.
5721         (linux_inferior_data): Move.  Change type.
5722         (invalidate_linux_cache_inf): Update.
5723         (linux_inferior_data_cleanup): Remove.
5724         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5725
5726 2019-05-08  Tom Tromey  <tom@tromey.com>
5727
5728         * auxv.c (auxv_inferior_data): Move.  Change type.
5729         (auxv_inferior_data_cleanup): Remove.
5730         (invalidate_auxv_cache_inf): Rewrite.
5731         (get_auxv_inferior_data, _initialize_auxv): Update.
5732
5733 2019-05-08  Tom Tromey  <tom@tromey.com>
5734
5735         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5736         (symfile_debug_objfile_data_key): Change type.
5737         (symfile_debug_installed, debug_qf_has_symbols)
5738         (debug_qf_find_last_source_symtab)
5739         (debug_qf_forget_cached_source_info)
5740         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5741         (debug_qf_print_stats, debug_qf_dump)
5742         (debug_qf_expand_symtabs_for_function)
5743         (debug_qf_expand_all_symtabs)
5744         (debug_qf_expand_symtabs_with_fullname)
5745         (debug_qf_map_matching_symbols)
5746         (debug_qf_expand_symtabs_matching)
5747         (debug_qf_find_pc_sect_compunit_symtab)
5748         (debug_qf_map_symbol_filenames)
5749         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5750         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5751         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5752         (debug_sym_read_linetable, debug_sym_relocate): Update.
5753         (symfile_debug_free_objfile): Remove.
5754         (install_symfile_debug_logging, _initialize_symfile_debug):
5755         Update.
5756
5757 2019-05-08  Tom Tromey  <tom@tromey.com>
5758
5759         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5760         allocate_on_obstack.
5761         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5762         (get_dwarf2_per_objfile): Update.
5763         (set_dwarf2_per_objfile): Remove.
5764         (dwarf2_has_info, dwarf2_get_section_info): Update.
5765         (dwarf2_free_objfile): Remove.
5766         (_initialize_dwarf2_read): Update.
5767
5768 2019-05-08  Tom Tromey  <tom@tromey.com>
5769
5770         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5771         initializers.
5772         <unsupported_script_warning_printed,
5773         script_not_found_warning_printed>: Now bool.
5774         (auto_load_pspace_data): Change type.
5775         (~auto_load_pspace_info): Rename from
5776         auto_load_pspace_data_cleanup.
5777         (get_auto_load_pspace_data, init_loaded_scripts_info)
5778         (clear_section_scripts, maybe_print_unsupported_script_warning)
5779         (maybe_print_script_not_found_warning, _initialize_auto_load):
5780         Update.
5781
5782 2019-05-08  Tom Tromey  <tom@tromey.com>
5783
5784         * objfiles.c (objfile_pspace_info): Add destructor and
5785         initializers.
5786         (objfiles_pspace_data): Change type.
5787         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5788         (get_objfile_pspace_data): Update.
5789         (objfiles_bfd_data): Change type.
5790         (get_objfile_bfd_data): Update.
5791         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5792
5793 2019-05-08  Tom Tromey  <tom@tromey.com>
5794
5795         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5796         Change type.
5797         (get_catch_syscall_inferior_data): Update.
5798         (catch_syscall_inferior_data_cleanup): Remove.
5799         (_initialize_break_catch_syscall): Update.
5800
5801 2019-05-08  Tom Tromey  <tom@tromey.com>
5802
5803         * inflow.c (struct terminal_info): Add destructor and
5804         initializers.
5805         (inflow_inferior_data): Change type.
5806         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5807         (get_inflow_inferior_data, inflow_inferior_exit)
5808         (swap_terminal_info, _initialize_inflow): Update.
5809
5810 2019-05-08  Tom Tromey  <tom@tromey.com>
5811
5812         * target-dcache.c (target_dcache_cleanup): Remove.
5813         (target_dcache_aspace_key): Change type.
5814         (target_dcache_init_p, target_dcache_invalidate)
5815         (target_dcache_get, target_dcache_get_or_init)
5816         (_initialize_target_dcache): Update.
5817         * dcache.h (struct dcache_deleter): New.
5818
5819 2019-05-08  Tom Tromey  <tom@tromey.com>
5820
5821         * symtab.c (struct symbol_cache): Add destructor and
5822         initializers.
5823         (symbol_cache_key): Move.  Change type.
5824         (make_symbol_cache, free_symbol_cache): Remove.
5825         (get_symbol_cache): Update.
5826         (symbol_cache_cleanup): Remove.
5827         (ALL_PSPACES, symbol_cache_flush)
5828         (maintenance_print_symbol_cache)
5829         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5830         Update.
5831
5832 2019-05-08  Tom Tromey  <tom@tromey.com>
5833
5834         * symtab.c (struct main_info): Add destructor and initializers.
5835         (main_progspace_key): Move.  Change type.
5836         (get_main_info): Update.
5837         (main_info_cleanup): Remove.
5838         (_initialize_symtab): Update.
5839
5840 2019-05-08  Tom Tromey  <tom@tromey.com>
5841
5842         * registry.h (DECLARE_REGISTRY): Define the _key class.
5843
5844 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5845
5846         * NEWS: Merge two 'New commands' sections.
5847
5848 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5849
5850         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5851         parameter and use Ada language definition instead.
5852         (ada_val_print_ptr): Remove unused language parameter.
5853         (ada_val_print_num): Remove language parameter and use Ada language
5854         definition instead.
5855         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5856         parameter.
5857         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5858         parameter and use Ada language definition instead.
5859         (ada_val_print_1): Update all ada_val_print_xxx calls.
5860         Remove language parameter.
5861         (ada_val_print): Update ada_val_print_1 call.
5862
5863 2019-05-08  Tom Tromey  <tromey@adacore.com>
5864
5865         * remote.c (remote_hw_watchpoint_limit)
5866         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5867         Now static.
5868
5869 2019-05-08  Tom Tromey  <tromey@adacore.com>
5870
5871         * maint.c (_initialize_maint_cmds): Move initialization code to
5872         remote.c.
5873         (watchdog, show_watchdog): Move to remote.c.
5874         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5875         "watchdog" static.
5876         (_initialize_remote): Move initialization code from maint.c.
5877         * defs.h (watchdog): Don't declare.
5878
5879 2019-05-08  Tom Tromey  <tromey@adacore.com>
5880
5881         * tui/tui-interp.c: Include main.h.
5882         * interps.c: Include main.h.
5883         * main.h (interpreter_p): Declare.
5884         * defs.h (interpreter_p): Don't declare.
5885
5886 2019-05-08  Tom Tromey  <tromey@adacore.com>
5887
5888         * dwarf2loc.c: Include dwarf2read.h.
5889         * defs.h (read_unsigned_leb128): Don't declare.
5890         * dwarf2read.h (read_unsigned_leb128): Declare.
5891
5892 2019-05-08  Tom Tromey  <tromey@adacore.com>
5893
5894         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5895         method.
5896
5897 2019-05-08  Tom Tromey  <tromey@adacore.com>
5898
5899         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5900         when no wrap column is set.
5901
5902 2019-05-08  Tom Tromey  <tromey@adacore.com>
5903
5904         * c-lang.c (c_get_string): Handle non-C-style arrays.
5905
5906 2019-05-08  Tom Tromey  <tromey@adacore.com>
5907
5908         * typeprint.c (print_offset_data::update): Print the bit offset,
5909         not the number of bits remaining.
5910
5911 2019-05-08  Tom Tromey  <tromey@adacore.com>
5912
5913         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5914         padding at end of comment.
5915
5916 2019-05-08  Tom Tromey  <tromey@adacore.com>
5917
5918         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5919         Compare main types.
5920
5921 2019-05-06  Tom Tromey  <tom@tromey.com>
5922
5923         * common/scoped_mmap.c: Include common-defs.h.
5924         * common/scoped_mmap.h: Don't include config.h.
5925
5926 2019-05-04  Tom Tromey  <tom@tromey.com>
5927
5928         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5929         (struct aarch64_call_info): Add initializers.
5930         <si>: Now a std::vector.
5931         (pass_on_stack, aarch64_push_dummy_call): Update.
5932
5933 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5934             Tom Tromey  <tom@tromey.com>
5935
5936         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5937         (ppc_threads): Now a std::vector.  Now static.
5938         (hwdebug_find_thread_points_by_tid)
5939         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5940         Update.
5941
5942 2019-05-04  Tom Tromey  <tom@tromey.com>
5943
5944         * arc-tdep.c (arc_tdesc_init): Return bool.
5945
5946 2019-05-04  Tom Tromey  <tom@tromey.com>
5947
5948         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5949         Use gdb_assert_not_reached.
5950
5951 2019-05-04  Tom Tromey  <tom@tromey.com>
5952
5953         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5954         "false".
5955
5956 2019-05-04  Tom Tromey  <tom@tromey.com>
5957
5958         * arc-tdep.c (arc_tdesc_init): Use bool.
5959
5960 2019-05-04  Tom Tromey  <tom@tromey.com>
5961
5962         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5963
5964 2019-05-04  Tom Tromey  <tom@tromey.com>
5965
5966         * cli/cli-cmds.c (valid_command_p): Return bool.
5967
5968 2019-05-04  Tom Tromey  <tom@tromey.com>
5969
5970         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5971         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5972
5973 2019-05-04  Raul Tambre  <raul@tambre.ee>
5974
5975         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5976         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5977         operator for comparison.
5978
5979 2019-05-04  Tom Tromey  <tom@tromey.com>
5980
5981         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5982         (lookup_partial_symbol, print_partial_symbols)
5983         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5984         (psymbol_compare): Update.
5985         (add_psymbol_to_bcache): Clear the entire psymbol.
5986         (maintenance_check_psymtabs): Update.
5987         * psympriv.h (struct partial_symbol): Don't derive from
5988         general_symbol_info.
5989         <obj_section, unrelocated_address, address,
5990         set_unrelocated_address>: Update.
5991         <ginfo>: New member.
5992         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5993         (debug_names::write_psymbols): Update.
5994
5995 2019-05-04  Tom de Vries  <tdevries@suse.de>
5996
5997         * contrib/cc-with-tweaks.sh: Support -n arg.
5998
5999 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6000
6001         * corelow.c (core_target::detach): Ensure frame cache and
6002         register caches are cleared.
6003         inferior.c (exit_inferior_1): Likewise.
6004
6005 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6006             Tom Tromey  <tom@tromey.com>
6007
6008         * dictionary.c (collate_pending_symbols_by_language): Remove
6009         "struct" from foreach.
6010         * symtab.c (lookup_global_symbol_from_objfile)
6011         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6012         foreach.
6013         * ser-tcp.c (net_open): Remove "struct" from foreach.
6014         * objfiles.c (objfile_relocate, objfile_rebase)
6015         (objfile_has_symbols): Remove "struct" from foreach.
6016         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6017         from foreach.
6018         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6019         foreach.
6020         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6021         "struct" from foreach.
6022         * ada-lang.c (create_excep_cond_exprs)
6023         (ada_exception_catchpoint_cond_string): Remove "struct" from
6024         foreach.
6025
6026 2019-05-03  Tom Tromey  <tromey@adacore.com>
6027
6028         * ada-exp.y (convert_char_literal): Check suffix of each
6029         enumerator.
6030
6031 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6032
6033         PR ada/21406:
6034         * ada-exp.y (yywrap): Don't define.
6035         * ada-lex.l (%option): Add noyywrap
6036         (yywrap): Remove.
6037
6038 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6039
6040         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6041         _WIN32_WINNT to the XP level, unless already defined to a higher
6042         level.
6043
6044         * unittests/parse-connection-spec-selftests.c:
6045         * ser-tcp.c:
6046         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6047         override.
6048
6049         * symfile.c (find_separate_debug_file): Remove colon from the
6050         drive spec of DOS/Windows file names of the target, so that the
6051         file name produced from DEBUGDIR and the target's directory will
6052         be valid on DOS/Windows systems.
6053
6054 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6055
6056         * rust-lang.c (val_print_struct): Handle printing structures
6057         containing strings.
6058
6059 2019-05-02  Tom Tromey  <tromey@adacore.com>
6060
6061         * valarith.c (_initialize_valarith): Remove.
6062
6063 2019-05-01  Tom Tromey  <tromey@adacore.com>
6064
6065         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6066         bitfields.
6067
6068 2019-05-01  Tom Tromey  <tromey@adacore.com>
6069
6070         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6071         for big-endian copies.
6072
6073 2019-04-30  Ali Tamur  <tamur@google.com>
6074         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6075         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6076         (read_3_bytes): New function.
6077
6078 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6079
6080         * windows-nat.c (main_thread_id): Delete.
6081         (handle_output_debug_string): Replace main_thread_id by
6082         current_event.dwThreadId.
6083         (fake_create_process): Likewise.
6084         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6085         Do not set main_thread_id.
6086         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6087         current_event.dwThreadId.
6088         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6089
6090 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6091
6092         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6093         Use current_event.dwThreadId instead of main_thread_id.
6094
6095 2019-04-30  Tom Tromey  <tromey@adacore.com>
6096
6097         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6098         (create_excep_cond_exprs): Iterate over program spaces.
6099         (ada_exception_catchpoint_cond_string): Examine all minimal
6100         symbols for exception types.
6101
6102 2019-04-30  Tom Tromey  <tromey@adacore.com>
6103
6104         PR c++/24470:
6105         * dwarf2read.c (process_structure_scope): Handle case where type
6106         has template parameters but no symbol was created.
6107
6108 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6109             Chris January  <chris.january@arm.com>
6110
6111         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6112         qualifier.
6113         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6114
6115 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6116
6117         * f-typeprint.c (f_print_type): Update rules for printing
6118         whitespace.
6119         (f_type_print_varspec_suffix): Likewise.
6120
6121 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6122             Chris January  <chris.january@arm.com>
6123
6124         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6125         function arguments.
6126
6127 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6128
6129         * f-lang.c (build_fortran_types): Change name of void type to
6130         lower case.
6131         * f-typeprint.c (f_type_print_base): Print the name of the void
6132         type, rather than a fixed string.
6133         * f-valprint.c (f_decorations): Use lower case void string.
6134
6135 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6136             Chris January  <chris.january@arm.com>
6137
6138         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6139         types for Fortran.
6140
6141 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6142             Chris January  <chris.january@arm.com>
6143             David Lecomber  <david.lecomber@arm.com>
6144
6145         * f-exp.y (BINOP_INTRINSIC): New token.
6146         (exp): New parser rule handling BINOP_INTRINSIC.
6147         (f77_keywords): Add new builtin procedures.
6148         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6149         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6150         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6151         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6152         (print_unop_subexp_f): New function.
6153         (print_binop_subexp_f): New function.
6154         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6155         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6156         (dump_subexp_body_f): Likewise.
6157         (operator_check_f): Likewise.
6158         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6159         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6160
6161 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6162
6163         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6164         UNOP_KIND.
6165         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6166         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6167         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6168         (operator_length_f): New fuction.
6169         (print_subexp_f): New function.
6170         (op_name_f): New function.
6171         (dump_subexp_body_f): New function.
6172         (operator_check_f): New function.
6173         (exp_descriptor_f): Replace standard expression handling functions
6174         with new functions.
6175         * gdb/fortran-operator.def: New file.
6176         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6177         * gdb/std-operator.def: Remove UNOP_KIND.
6178
6179 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6180
6181         * std-operator.def: Remove unbalanced, stray double quote
6182         character.
6183
6184 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6185             Chris January  <chris.january@arm.com>
6186             Daniel Everett  <daniel.everett@arm.com>
6187             Nick Forrington  <nick.forrington@arm.com>
6188             Richard Bunt  <richard.bunt@arm.com>
6189
6190         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6191         of depth when printing anonymous structs or unions.
6192         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6193         Don't print either the top-level value, or the children if the
6194         max-depth is exceeded.
6195         (ppscm_print_children): When printing the key of a map, allow one
6196         extra level of depth.
6197         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6198         print either the top-level value, or the children if the max-depth
6199         is exceeded.
6200         (print_children): When printing the key of a map, allow one extra
6201         level of depth.
6202         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6203         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6204         (user_print_options): Initialise max_depth field.
6205         (val_print_scalar_or_string_type_p): New function.
6206         (val_print): Check to see if the max depth has been reached.
6207         (val_print_check_max_depth): Define new function.
6208         (show_print_max_depth): New function.
6209         (_initialize_valprint): Add 'print max-depth' option.
6210         * valprint.h (struct value_print_options) <max_depth>: New field.
6211         (val_print_check_max_depth): Declare new function.
6212         * NEWS: Document new feature.
6213
6214 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6215
6216         * ada-lang.c (ada_language_defn): Initialise new field.
6217         * c-lang.c (c_is_string_type_p): New function.
6218         (c_language_defn): Initialise new field.
6219         (cplus_language_defn): Initialise new field.
6220         (asm_language_defn): Initialise new field.
6221         (minimal_language_defn): Initialise new field.
6222         * c-lang.h (c_is_string_type_p): Declare new function.
6223         * d-lang.c (d_language_defn): Initialise new field.
6224         * f-lang.c (f_is_string_type_p): New function.
6225         (f_language_defn): Initialise new field.
6226         * go-lang.c (go_is_string_type_p): New function.
6227         (go_language_defn): Initialise new field.
6228         * language.c (default_is_string_type_p): New function.
6229         (unknown_language_defn): Initialise new field.
6230         (auto_language_defn): Initialise new field.
6231         * language.h (struct language_defn) <la_is_string_type_p>: New
6232         member variable.
6233         (default_is_string_type_p): Declare new function.
6234         * m2-lang.c (m2_language_defn): Initialise new field.
6235         * objc-lang.c (objc_language_defn): Initialise new field.
6236         * opencl-lang.c (opencl_language_defn): Initialise new field.
6237         * p-lang.c (pascal_is_string_type_p): New function.
6238         (pascal_language_defn): Initialise new field.
6239         * rust-lang.c (rust_is_string_type_p): New function.
6240         (rust_language_defn): Initialise new field.
6241
6242 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6243
6244         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6245         New field.
6246         * ada-lang.c (ada_language_defn): Initialise new field.
6247         * c-lang.c (c_language_defn): Likewise.
6248         (cplus_language_defn): Likewise.
6249         (asm_language_defn): Likewise.
6250         (minimal_language_defn): Likewise.
6251         * d-lang.c (d_language_defn): Likewise.
6252         * f-lang.c (f_language_defn): Likewise.
6253         * go-lang.c (go_language_defn): Likewise.
6254         * language.c (unknown_language_defn): Likewise.
6255         (auto_language_defn): Likewise.
6256         * m2-lang.c (m2_language_defn): Likewise.
6257         * objc-lang.c (objc_language_defn): Likewise.
6258         * opencl-lang.c (opencl_language_defn): Likewise.
6259         * p-lang.c (pascal_language_defn): Likewise.
6260         * rust-lang.c (rust_language_defn): Likewise.
6261
6262 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6263
6264         * ada-lang.c (ada_is_character_type): Change return type to bool.
6265         (ada_is_string_type): Likewise.
6266         * ada-lang.h (ada_is_character_type): Update declaration
6267         (ada_is_string_type): Likewise.
6268
6269 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6270
6271         Support style in 'frame|thread apply'
6272
6273         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6274         * record.c (record_start, record_stop): Update callers of
6275         execute_command_to_string with false.
6276         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6277         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6278         methods.
6279         (class string_file): New constructor with term_out parameter.
6280         Override methods term_out and can_emit_style_escape.  New member
6281         term_out.
6282         (class stdio_file): Override can_emit_style_escape.
6283         (class tee_file): Override term_out and can_emit_style_escape.
6284         * utils.h (can_emit_style_escape): Remove.
6285         * utils.c (can_emit_style_escape): Likewise.
6286         Update all callers of can_emit_style_escape (SOMESTREAM) to
6287         SOMESTREAM->can_emit_style_escape.
6288         * source-cache.c (source_cache::get_source_lines): Likewise.
6289         * stack.c (frame_apply_command_count): Call execute_command_to_string
6290         passing the term_out characteristic of the current gdb_stdout.
6291         * thread.c (thr_try_catch_cmd): Likewise.
6292         * top.c (execute_command_to_string): pass term_out parameter
6293         to construct the string_file for the command output.
6294         * ui-file.c (term_cli_styling): New function (most code moved
6295         from utils.c can_emit_style_escape).
6296         (string_file::string_file, string_file::can_emit_style_escape,
6297         stdio_file::can_emit_style_escape, tee_file::term_out,
6298         tee_file::can_emit_style_escape): New functions.
6299
6300 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6301
6302         * NEWS: Mention the new set|show may-call-functions.
6303         * infcall.c (may_call_functions_p): New variable.
6304         (show_may_call_functions_p): New function.
6305         (call_function_by_hand_dummy): Throws an error if not
6306         may-call-functions.
6307         (_initialize_infcall): Call add_setshow_boolean_cmd for
6308         may-call-functions.
6309
6310 2019-04-25  Keith Seitz  <keiths@redhat.com>
6311
6312         PR c++/24367
6313         * cp-support.c (inspect_type): Don't attempt substitutions
6314         of symbol with the same name.
6315
6316 2019-04-25  Tom Tromey  <tromey@adacore.com>
6317
6318         PR gdb/24475:
6319         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6320         static.
6321
6322 2019-04-25  Tom Tromey  <tromey@adacore.com>
6323
6324         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6325         rvalue reference.
6326         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6327         (gdb_xml_parser::parse): Use std::move.
6328         * python/python-internal.h (gdbpy_convert_exception): Take a const
6329         reference.
6330         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6331         std::move.
6332         * python/py-utils.c (gdbpy_convert_exception): Take a const
6333         reference.
6334         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6335         Use std::move.
6336         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6337         Use std::move.
6338         * mi/mi-main.c (mi_print_exception): Take a const reference.
6339         * main.c (handle_command_errors): Take a const reference.
6340         * linespec.c (parse_linespec): Use std::move.
6341         * infcall.c (run_inferior_call): Use std::move.
6342         (call_function_by_hand_dummy): Use std::move.
6343         * exec.c (try_open_exec_file): Use std::move.
6344         * exceptions.h (exception_print, exception_fprintf)
6345         (exception_print_same): Update.
6346         * exceptions.c (print_exception, exception_print)
6347         (exception_fprintf, exception_print_same): Change parameters to
6348         const reference.
6349         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6350         * common/new-op.c: Use std::move.
6351         * common/common-exceptions.h (struct gdb_exception): Add move
6352         constructor.
6353         (struct gdb_exception_error, struct gdb_exception_quit, struct
6354         gdb_quit_bad_alloc): Change constructor to move constructor.
6355         (throw_exception): Change parameter to rvalue reference.
6356         * common/common-exceptions.c (throw_exception): Take rvalue
6357         reference.
6358         * cli/cli-interp.c (safe_execute_command): Use std::move.
6359         * breakpoint.c (insert_bp_location, location_to_sals): Use
6360         std::move.
6361
6362 2019-04-25  Tom Tromey  <tromey@adacore.com>
6363
6364         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6365         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6366         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6367         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6368         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6369         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6370         guile/scm-value.c: Use unpack.
6371         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6372         gdbscm_gdb_exception.
6373         (gdbscm_throw_gdb_exception): Likewise.
6374         (struct gdbscm_gdb_exception): New.
6375         (unpack): New function.
6376         (gdbscm_wrap): Use unpack.
6377
6378 2019-04-25  Tom Tromey  <tromey@adacore.com>
6379
6380         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6381         (gdb_rl_callback_handler): Use std::move.
6382         * common/common-exceptions.h (struct gdb_exception): Add move
6383         assignment operator.
6384         (throw_exception_sjlj): Change "exception" to const reference.
6385         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6386         (throw_exception_sjlj): Change "exception" to const reference.
6387
6388 2019-04-25  Tom Tromey  <tromey@adacore.com>
6389
6390         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6391         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6392         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6393         Update.
6394         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6395         Update.
6396         * mi/mi-interp.c (mi_interp::exec): Update.
6397         * linespec.c (parse_linespec): Update.
6398         * infcall.c (run_inferior_call): Update.
6399         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6400         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6401         (gdbscm_lookup_global_symbol): Update.
6402         * guile/scm-param.c (gdbscm_parameter_value): Update.
6403         * guile/scm-frame.c (gdbscm_frame_read_register)
6404         (gdbscm_frame_read_var): Update.
6405         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6406         * exec.c (try_open_exec_file): Update.
6407         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6408         (gdb_rl_callback_handler): Update.
6409         * common/common-exceptions.h (exception_none): Don't declare.
6410         * common/common-exceptions.c (exception_none): Don't define.
6411         (struct catcher) <exception>: Update.
6412         * cli/cli-interp.c (safe_execute_command): Update.
6413         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6414
6415 2019-04-25  Ali Tamur  <tamur@google.com>
6416
6417         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6418         (read_attribute_value): Likewise.
6419         (dwarf2_read_addr_index): Update comment.
6420         (read_str_index): Add DW_FORM_strx.
6421         (dwarf2_string_attr): Likewise.
6422         (dwarf2_const_value_attr): Likewise.
6423         (dump_die_shallow): Likewise.
6424         (dwarf2_fetch_constant_bytes): Likewise.
6425         (skip_form_bytes): Likewise.
6426         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6427
6428 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6429
6430         PR corefiles/11608
6431         PR corefiles/18187
6432         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6433         OFFSET.  Verify if current mapping contains an ELF header.
6434         (linux_find_memory_regions_full): Adjust call to
6435         dump_mapping_p.
6436
6437 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6438             Kang Li <kanglictf@gmail.com>
6439
6440         PR gdb/21600
6441
6442         * dwarf2-frame.c (read_initial_length): Be consistent about using
6443         unsigned representation of length.
6444         (decode_frame_entry_1): Likewise.  Check for wraparound of
6445         end pointer as well as buffer overflow.
6446
6447 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6448
6449         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6450         "vq".
6451
6452 2019-04-24  Tom Tromey  <tromey@adacore.com>
6453
6454         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6455
6456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6457
6458         * s12z-tdep.c (s12z_unwind_pc): Delete.
6459         (s12z_unwind_sp): Delete.
6460         (s12z_gdbarch_init): Don't register deleted functions with
6461         gdbarch.
6462
6463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6464
6465         * rl78-tdep.c (rl78_unwind_sp): Delete.
6466         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6467
6468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6469
6470         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6471         (xstormy16_unwind_pc): Delete.
6472         (xstormy16_dummy_id): Delete.
6473         (xstormy16_gdbarch_init): Don't register deleted functions with
6474         gdbarch.
6475
6476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6477
6478         * vax-tdep.c (vax_unwind_pc): Delete.
6479         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6480
6481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6482
6483         * v850-tdep.c (v850_unwind_sp): Delete.
6484         (v850_unwind_pc): Delete.
6485         (v850_dummy_id): Delete.
6486         (v850_gdbarch_init): Don't register deleted functions with
6487         gdbarch.
6488
6489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6490
6491         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6492         (tilegx_unwind_pc): Delete.
6493         (tilegx_unwind_dummy_id): Delete.
6494         (tilegx_gdbarch_init): Don't register deleted functions with
6495         gdbarch.
6496
6497 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6498
6499         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6500         (tic6x_dummy_id): Delete.
6501         (tic6x_gdbarch_init): Don't register deleted functions with
6502         gdbarch.
6503
6504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6505
6506         * sparc-tdep.c (sparc_unwind_pc): Delete.
6507         (sparc32_gdbarch_init): Don't register deleted function with
6508         gdbarch.
6509
6510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6511
6512         * sh-tdep.c (sh_unwind_sp): Delete.
6513         (sh_unwind_pc): Delete.
6514         (sh_dummy_id): Delete.
6515         (sh_gdbarch_init): Don't register deleted functions with
6516         gdbarch.
6517
6518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6519
6520         * score-tdep.c (score_unwind_sp): Delete.
6521         (score_unwind_pc): Delete.
6522         (score_dummy_id): Delete.
6523         (score_gdbarch_init): Don't register deleted functions with
6524         gdbarch.
6525
6526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * rx-tdep.c (rx_unwind_pc): Delete.
6529         (rx_unwind_sp): Delete.
6530         (rx_dummy_id): Delete.
6531         (rx_gdbarch_init): Don't register deleted functions with
6532         gdbarch.  Update comment.
6533
6534 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6535
6536         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6537         (rs6000_dummy_id): Delete.
6538         (rs6000_gdbarch_init): Don't register deleted functions with
6539         gdbarch.
6540
6541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6542
6543         * or1k-tdep.c (or1k_dummy_id): Delete.
6544         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6545
6546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6547
6548         * nios2-tdep.c (nios2_dummy_id): Delete.
6549         (nios2_unwind_sp): Delete.
6550         (nios2_gdbarch_init): Don't register deleted functions with
6551         gdbarch.
6552
6553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6554
6555         * nds32-tdep.c (nds32_dummy_id): Delete.
6556         (nds32_unwind_pc): Delete.
6557         (nds32_unwind_sp): Delete.
6558         (nds32_gdbarch_init): Don't register deleted functions with
6559         gdbarch.
6560
6561 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6562
6563         * msp430-tdep.c (msp430_unwind_pc): Delete.
6564         (msp430_unwind_sp): Delete.
6565         (msp430_dummy_id): Delete.
6566         (msp430_gdbarch_init): Don't register deleted functions with
6567         gdbarch.
6568
6569 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6570
6571         * moxie-tdep.c (moxie_unwind_sp): Delete.
6572         (moxie_unwind_pc): Delete.
6573         (moxie_dummy_id): Delete.
6574         (moxie_gdbarch_init): Don't register deleted functions with
6575         gdbarch.
6576
6577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6578
6579         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6580         (mn10300_unwind_pc): Delete.
6581         (mn10300_unwind_sp): Delete.
6582         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6583         mn10300_unwind_sp.
6584         (mn10300_frame_unwind_init): Don't register deleted functions with
6585         gdbarch.
6586
6587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6588
6589         * mep-tdep.c (mep_unwind_pc): Delete.
6590         (mep_unwind_sp): Delete.
6591         (mep_dummy_id): Delete.
6592         (mep_gdbarch_init): Don't register deleted functions with
6593         gdbarch.
6594
6595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6596
6597         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6598         (m68hc11_unwind_sp): Delete.
6599         (m68hc11_gdbarch_init): Don't register deleted functions with
6600         gdbarch.
6601
6602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6603
6604         * m32r-tdep.c (m32r_unwind_sp): Delete.
6605         (m32r_unwind_pc): Delete.
6606         (m32r_dummy_id): Delete.
6607         (m32r_gdbarch_init): Don't register deleted functions with
6608         gdbarch.
6609
6610 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6611
6612         * m32c-tdep.c (m32c_unwind_pc): Delete.
6613         (m32c_unwind_sp): Delete.
6614         (m32c_dummy_id): Delete.
6615         (m32c_gdbarch_init): Don't register deleted functions with
6616         gdbarch.
6617
6618 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6619
6620         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6621         (lm32_unwind_pc): Delete.
6622         (lm32_dummy_id): Delete.
6623         (lm32_gdbarch_init): Don't register deleted functions with
6624         gdbarch.
6625
6626 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6627
6628         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6629         (iq2000_unwind_pc): Delete.
6630         (iq2000_dummy_id): Delete.
6631         (iq2000_gdbarch_init): Don't register deleted functions with
6632         gdbarch.
6633
6634 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6635
6636         * nds32-tdep.c (nds32_type_align): Delete.
6637         (nds32_push_dummy_call): Use type_align instead.
6638
6639 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6640
6641         * arm-tdep.c (arm_type_align): Only handle vector override case.
6642         (arm_push_dummy_call): Use type_align.
6643         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6644
6645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6646
6647         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6648         case.
6649         (pass_on_stack): Use type_align.
6650         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6651         function.
6652
6653 2019-04-23  Tom Tromey  <tromey@adacore.com>
6654
6655         * dwarf2read.c (line_header::file_name_at): Remove unused
6656         overload.
6657
6658 2019-04-23  Tom de Vries  <tdevries@suse.de>
6659
6660         PR gdb/24438
6661         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6662         invocation.
6663
6664
6665 2019-03-27  Ali Tamur  <tamur@google.com>
6666
6667         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6668         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6669         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6670         (dwarf_expr_context::get_addr_index): Likewise
6671         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6672         (symbol_needs_eval_context::get_addr_index): Likewise
6673         (disassemble_dwarf_expression): Add DW_OP_addrx
6674         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6675         (read_cutu_die_from_dwo): Update comment
6676         (skip_one_die): Add DW_FORM_addrx
6677         (read_attribute_value): Likewise
6678         (var_decode_location): Add DW_OP_addrx
6679         (dwarf2_const_value_attr): Add DW_FORM_addrx
6680         (dump_die_shallow): Likewise
6681         (dwarf2_fetch_constant_bytes): Likewise
6682         (decode_locdesc): Add DW_OP_addrx
6683         (skip_form_bytes): Add DW_FORM_addrx
6684
6685 2019-04-22  Ali Tamur  <tamur@google.com>
6686
6687         * MAINTAINERS (Write After Approval): Add self.
6688
6689 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6690
6691         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6692         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6693         (open_symbol_file_object): Likewise.
6694         (svr4_default_sos): Add info parameter.
6695         (svr4_read_so_list): Likewise.
6696         (svr4_current_sos_direct): Adjust functions calls to pass down
6697         info.
6698         (svr4_current_sos_1): Add info parameter.
6699         (svr4_current_sos): Call get_svr4_info, pass info down to
6700         svr4_current_sos_1.
6701         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6702         get_svr4_info.
6703         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6704         get_svr4_info.
6705         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6706         to get_svr4_info.
6707         (probes_table_remove_objfile_probes): Likewise.
6708         (register_solib_event_probe): Add info parameter.
6709         (solist_update_incremental): Pass info parameter down to
6710         svr4_read_so_list.
6711         (disable_probes_interface): Add info parameter.
6712         (svr4_handle_solib_event): Pass current_program_space to
6713         get_svr4_info.  Adjust disable_probes_interface cleanup.
6714         (svr4_create_probe_breakpoints): Add info parameter, pass it
6715         down to register_solib_event_probe.
6716         (svr4_create_solib_event_breakpoints): Add info parameter,
6717         pass it down to svr4_create_probe_breakpoints.
6718         (enable_break): Pass info down to
6719         svr4_create_solib_event_breakpoints.
6720         (svr4_solib_create_inferior_hook): Pass current_program_space to
6721         get_svr4_info.
6722         (svr4_clear_solib): Likewise.
6723
6724 2019-04-22  Pedro Alves  <palves@redhat.com>
6725
6726         * solib-svr4.c (svr4_free_objfile_observer): New.
6727         (probe_and_action::objfile): New field.
6728         (probes_table_htab_remove_objfile_probes)
6729         (probes_table_remove_objfile_probes): New functions.
6730         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6731         in the new probe_and_action.  Don't store the probe in 'lookup'.
6732         (svr4_create_probe_breakpoints): Pass objfile to
6733         register_solib_event_probe.
6734         (_initialize_svr4_solib): Register a free_objfile observer.
6735
6736 2019-04-19  Tom Tromey  <tom@tromey.com>
6737
6738         * common/queue.h: Remove.
6739
6740 2019-04-19  Tom Tromey  <tom@tromey.com>
6741
6742         * event-loop.c: Don't include "common/queue.h".
6743
6744 2019-04-19  Tom Tromey  <tom@tromey.com>
6745
6746         * remote.c (remote_target): Use delete.
6747         * remote-notif.h: Include <list>, not "common/queue.h".
6748         (notif_client_p): Remove typedef.
6749         (remote_notif_state): Add constructor, destructor, initializer.
6750         <notif_queue>: Now a std::list.
6751         (remote_notif_state_xfree): Don't declare.
6752         * remote-notif.c (remote_notif_process, handle_notification)
6753         (remote_notif_state_allocate): Update.
6754         (~remote_notif_state): Rename from remote_notif_state_xfree.
6755
6756 2019-04-19  Tom Tromey  <tom@tromey.com>
6757
6758         * symfile.c (reread_symbols): Update.
6759         * objfiles.c (objfile_register_static_link)
6760         (objfile_lookup_static_link): Update
6761         (~objfile) Don't delete static_links.
6762         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6763
6764 2019-04-19  Tom Tromey  <tom@tromey.com>
6765
6766         * type-stack.h (struct type_stack) <insert>: Constify string.
6767         * type-stack.c (type_stack::insert): Constify string.
6768         * gdbtypes.h (lookup_template_type): Update.
6769         (address_space_name_to_int): Update.
6770         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6771         const.
6772         (lookup_template_type): Make name const.
6773         * c-exp.y: Update rules.
6774         (lex_one_token, classify_name, classify_inner_name)
6775         (c_print_token): Update.
6776         * p-exp.y: Update rules.
6777         (yylex): Update.
6778         * f-exp.y: Update rules.
6779         (yylex): Update.
6780         * d-exp.y: Update rules.
6781         (lex_one_token, classify_name, classify_inner_name): Update.
6782         * parse.c (write_dollar_variable, copy_name): Return std::string.
6783         * parser-defs.h (copy_name): Change return type.
6784         * m2-exp.y: Update rules.
6785         (yylex): Update.
6786         * go-exp.y (lex_one_token): Update.
6787         Update rules.
6788         (classify_unsafe_function, classify_packaged_name)
6789         (classify_name, yylex): Update.
6790
6791 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6792
6793         * configure.ac: add --enable-source-highlight switch.
6794         * configure: Regenerate.
6795         * top.c (print_gdb_version): plumb --enable-source-highlight
6796         status to "show configuration".
6797
6798 2019-04-19  Tom Tromey  <tromey@adacore.com>
6799
6800         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6801         Check ADA_TYPE_P.
6802         (empty_record, ada_template_to_fixed_record_type_1)
6803         (template_to_static_fixed_type)
6804         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6805         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6806         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6807         macros.
6808
6809 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6810
6811         PR symtab/24423:
6812         * source.c (print_source_lines_base): Advance "iter" when a
6813         control character is seen.
6814
6815 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6816
6817         * inferior.h (struct infcall_suspend_state_deleter):
6818         Catch exception in destructor to avoid crash.
6819
6820 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6821
6822         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6823         close to the add_com "shell".
6824
6825 2019-04-18  Tom Tromey  <tromey@adacore.com>
6826
6827         * process-stratum-target.h (class process_stratum_target)
6828         <stratum>: Add "final".
6829
6830 2019-04-17  Tom Tromey  <tromey@adacore.com>
6831
6832         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6833         against nullptr before use.
6834
6835 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6836
6837         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6838
6839 2019-04-17  Jim Wilson  <jimw@sifive.com>
6840             Andrew Burgess  <andrew.burgess@embecosm.com>
6841
6842         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6843         code read might fail, assume 4-byte breakpoint in that case.
6844
6845 2019-04-15  Leszek Swirski  <leszeks@google.com>
6846
6847         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6848         rather than a hand-rolled POD check when checking for forced MEMORY
6849         classification.
6850
6851 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6852
6853         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6854         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6855         function.
6856         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6857         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6858         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6859         declaration.
6860
6861 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6862
6863         * aarch64-linux-nat.c
6864         (aarch64_linux_nat_target::thread_architecture): Add override.
6865         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6866         each VQ.
6867
6868 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6869
6870         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6871
6872 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6873
6874         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6875         target types of size 96-bits, add some additional comments, and
6876         check that the builtin type we found was the correct size.
6877
6878 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6879
6880         * utils.c (prompt_for_continue): Don't restore the styling at the
6881         end, as applied_style has the wrong value.  This fixes styling in
6882         long lists of file names that are interrupted by the "Continue?"
6883         prompt.
6884
6885 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6886
6887         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6888         * c-lang.c (c_language_defn): Likewise.
6889         (cplus_language_defn): Likewise.
6890         (asm_language_defn): Likewise.
6891         (minimal_language_defn): Likewise.
6892         * d-lang.c (d_language_defn): Likewise.
6893         * f-lang.c (f_language_defn): Likewise.
6894         * go-lang.c (go_language_defn): Likewise.
6895         * language.c (unknown_language_defn): Likewise.
6896         (auto_language_defn): Likewise.
6897         * language.h (struct language_defn): Remove la_magic field.
6898         (LANG_MAGIC): Delete.
6899         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6900         * objc-lang.c (objc_language_defn): Likewise.
6901         * opencl-lang.c (opencl_language_defn): Likewise.
6902         * p-lang.c (pascal_language_defn): Likewise.
6903         * rust-lang.c (rust_language_defn): Likewise.
6904
6905 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6906
6907         * riscv-tdep.c (riscv_type_align): New function.
6908         (riscv_type_alignment): Delete.
6909         (riscv_arg_location): Use 'type_align'.
6910         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6911
6912 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6913
6914         * gdbtypes.c (type_align): A struct with no non-static fields also
6915         has alignment of 1.
6916
6917 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6918
6919         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6920         component to 0.
6921         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6922         member.
6923         (riscv_struct_info::analyse): New implementation using new
6924         analyse_inner member function.
6925         (riscv_struct_info::field_offset): New member function.
6926         (riscv_struct_info::m_offsets): New member variable.
6927         (riscv_struct_info::analyse_inner): New private member function,
6928         takes the old implementation of riscv_struct_info::analyse but
6929         extended to track field offsets.
6930         (riscv_call_arg_struct): Update the struct folding special cases
6931         to handle cases where empty C++ structs, which are non-zero
6932         length, are found.
6933         (riscv_arg_location): Initialise the length of each location, a
6934         non-zero length now indicates the location is in use.
6935         (riscv_push_dummy_call): Allow for the first location having a
6936         non-zero offset when setting up arguments.
6937         (riscv_return_value): Likewise, but for return values.
6938
6939 2019-04-11  Tom Tromey  <tromey@adacore.com>
6940
6941         * utils.c (internal_vproblem): Make "msg" const.
6942
6943 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6944
6945         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6946         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6947         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6948         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6949
6950 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6951
6952         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6953         function.
6954         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6955         of amd64_collect_native_gregset.
6956         (amd64_linux_nat_target::store_registers): Likewise.
6957
6958 2019-04-10  Tom Tromey  <tom@tromey.com>
6959
6960         * symtab.c (lookup_global_symbol_from_objfile)
6961         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6962         * objfiles.h (class separate_debug_iterator): New.
6963         (class separate_debug_range): New.
6964         (struct objfile) <separate_debug_objfiles>: New method.
6965         (objfile_separate_debug_iterate): Don't declare.
6966         * objfiles.c (separate_debug_iterator::operator++): Rename from
6967         objfile_separate_debug_iterate.
6968         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6969         iterator.
6970         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6971         iterator.
6972
6973 2019-04-10  Tom Tromey  <tom@tromey.com>
6974
6975         * symfile.c (reread_symbols): Remove old comment.
6976         * objfiles.c (free_all_objfiles): Fix a typo.
6977
6978 2019-04-10  Tom Tromey  <tom@tromey.com>
6979
6980         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6981         * minsyms.c (lookup_minimal_symbol): Use foreach.
6982         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6983         (lookup_minimal_symbol_solib_trampoline): Likewise.
6984         * symfile.c (reread_symbols): Use foreach.
6985
6986 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6987             Tom Tromey  <tromey@adacore.com>
6988
6989         PR rust/24414:
6990         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6991         (rust_lex_int_test): Change "value" to be LONGEST.
6992         (rust_lex_tests): Add test for long integer literal.
6993
6994 2019-04-09  Tom Tromey  <tromey@adacore.com>
6995
6996         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6997         to bool.
6998         (extended_remote_target::attach): Update.
6999         (remote_target::remote_notice_new_inferior): Update.
7000         (remote_target::add_current_inferior_and_thread): Update.
7001         * inferior.c (exit_inferior_1): Use "false".
7002         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7003
7004 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7005
7006         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7007         the "start" command.
7008
7009 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7010
7011         * python/py-inferior.c (infpy_thread_from_thread_handle):
7012         Adjust comments to reflect renaming of thread_from_thread_handle
7013         to thread_from_handle.  Adjust keywords.  Fix type error message.
7014         (inferior_object_methods): Add thread_from_handle.  Retain
7015         thread_from_thread_handle, but mark it as deprecated.
7016
7017 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7018
7019         * gdbthread.h (find_thread_by_handle): Revise declaration.
7020         * thread.c (find_thread_by_handle): Likewise.  Adjust
7021         implementation too.
7022         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7023         support for buffer objects as handles.
7024
7025 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7026
7027         * python/py-infthread.c (thpy_thread_handle): New function.
7028         (thread_object_methods): Register thpy_thread_handle.
7029
7030 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7031
7032         * gdbthread.h (thread_to_thread_handle): Declare.
7033         * thread.c (gdbtypes.h): Include.
7034         (thread_to_thread_handle): New function.
7035
7036         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7037         (target_thread_info_to_thread_handle): Declare.
7038         * target.c (target_thread_info_to_thread_handle): New function.
7039         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7040         * target-delegates.c: Regenerate.
7041
7042         * linux-thread-db.c (class thread_db_target): Add method
7043         thread_info_to_thread_handle.
7044         (thread_db_target::thread_info_to_thread_handle): Define.
7045         * remote.c (class remote_target): Add new method
7046         thread_info_to_thread_handle.
7047         (remote_target::thread_info_to_thread_handle): Define.
7048
7049 2019-04-08  Pedro Alves  <palves@redhat.com>
7050
7051         * common/common-exceptions.c (throw_exception): Don't create
7052         named object to throw; throw directly.
7053         (throw_it): Likewise.  Don't initialize gdb_exception::message
7054         here, with new; pass FMT and AP to the ctor instead.
7055         * common/common-exceptions.h: Include <string>.
7056         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7057         const char *, va_list)): New ctor.  Use std::make_shared.
7058         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7059         errors)): Delete.
7060         (gdb_exception_error::gdb_exception_error(enum errors, const char
7061         *, va_list)): New.
7062         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7063         Add assertion.
7064         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7065         errors)): Delete.
7066         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7067         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7068         Add assertion.
7069
7070 2019-04-08  Tom Tromey  <tom@tromey.com>
7071
7072         * valops.c (value_rtti_indirect_type): Replace throw_exception
7073         with throw.
7074         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7075         with throw.
7076         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7077         throw.
7078         * target.c (target_translate_tls_address): Replace throw_exception
7079         with throw.
7080         * stack.c (frame_apply_command_count): Replace throw_exception
7081         with throw.
7082         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7083         throw.
7084         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7085         with throw.
7086         * rs6000-tdep.c (rs6000_frame_cache)
7087         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7088         * remote.c: Replace throw_exception with throw.
7089         * record-full.c (record_full_message, record_full_wait_1)
7090         (record_full_restore): Replace throw_exception with throw.
7091         * record-btrace.c:
7092         (get_thread_current_frame_id, record_btrace_start_replaying)
7093         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7094         (cmd_record_btrace_start): Replace throw_exception with throw.
7095         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7096         throw.
7097         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7098         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7099         * linespec.c:
7100         (find_linespec_symbols): Replace throw_exception with throw.
7101         * infrun.c (displaced_step_prepare, resume): Replace
7102         throw_exception with throw.
7103         * infcmd.c (post_create_inferior): Replace throw_exception with
7104         throw.
7105         * inf-loop.c (inferior_event_handler): Replace throw_exception
7106         with throw.
7107         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7108         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7109         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7110         (get_prev_frame_always, get_frame_pc_if_available)
7111         (get_frame_address_in_block_if_available, get_frame_language):
7112         Replace throw_exception with throw.
7113         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7114         throw_exception with throw.
7115         * eval.c (fetch_subexp_value, evaluate_var_value)
7116         (evaluate_funcall, evaluate_subexp_standard): Replace
7117         throw_exception with throw.
7118         * dwarf2loc.c (call_site_find_chain)
7119         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7120         Replace throw_exception with throw.
7121         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7122         with throw.
7123         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7124         throw.
7125         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7126         * completer.c (complete_line_internal): Replace throw_exception
7127         with throw.
7128         * compile/compile-object-run.c (compile_object_run): Replace
7129         throw_exception with throw.
7130         * cli/cli-script.c (process_next_line): Replace throw_exception
7131         with throw.
7132         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7133         (btrace_enable, btrace_maint_update_pt_packets): Replace
7134         throw_exception with throw.
7135         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7136         throw_exception with throw.
7137         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7138         throw_exception with throw.
7139         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7140         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7141         * aarch64-tdep.c (aarch64_make_prologue_cache)
7142         (aarch64_make_stub_cache): Replace throw_exception with throw.
7143
7144 2019-04-08  Tom Tromey  <tom@tromey.com>
7145
7146         * common/common-exceptions.c (throw_exception): Rename from
7147         throw_exception_cxx.  Remove old copy.  Make argument const.
7148         (throw_it): Create and throw exception objects directly.
7149         * common/common-exceptions.h (throw_exception): Make argument
7150         const.
7151         (struct gdb_exception_error): Add constructor.
7152         (struct gdb_exception_quit): Add constructor.
7153
7154 2019-04-08  Tom Tromey  <tom@tromey.com>
7155
7156         * common/common-exceptions.h (exception_rethrow): Don't declare.
7157         (TRY_SJLJ): Update comment.
7158         (TRY, CATCH, END_CATCH): Remove.
7159         * common/common-exceptions.c (exception_rethrow): Remove.
7160
7161 2019-04-08  Tom Tromey  <tom@tromey.com>
7162
7163         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7164         Remove.
7165         (gdb_exception_error): Rename from
7166         gdb_exception_RETURN_MASK_ERROR.
7167         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7168         (gdb_quit_bad_alloc): Update.
7169         * aarch64-tdep.c: Update.
7170         * ada-lang.c: Update.
7171         * ada-typeprint.c: Update.
7172         * ada-valprint.c: Update.
7173         * amd64-tdep.c: Update.
7174         * arch-utils.c: Update.
7175         * break-catch-throw.c: Update.
7176         * breakpoint.c: Update.
7177         * btrace.c: Update.
7178         * c-varobj.c: Update.
7179         * cli/cli-cmds.c: Update.
7180         * cli/cli-interp.c: Update.
7181         * cli/cli-script.c: Update.
7182         * common/common-exceptions.c: Update.
7183         * common/new-op.c: Update.
7184         * common/selftest.c: Update.
7185         * compile/compile-c-symbols.c: Update.
7186         * compile/compile-cplus-symbols.c: Update.
7187         * compile/compile-object-load.c: Update.
7188         * compile/compile-object-run.c: Update.
7189         * completer.c: Update.
7190         * corelow.c: Update.
7191         * cp-abi.c: Update.
7192         * cp-support.c: Update.
7193         * cp-valprint.c: Update.
7194         * darwin-nat.c: Update.
7195         * disasm-selftests.c: Update.
7196         * dtrace-probe.c: Update.
7197         * dwarf-index-cache.c: Update.
7198         * dwarf-index-write.c: Update.
7199         * dwarf2-frame-tailcall.c: Update.
7200         * dwarf2-frame.c: Update.
7201         * dwarf2loc.c: Update.
7202         * dwarf2read.c: Update.
7203         * eval.c: Update.
7204         * event-loop.c: Update.
7205         * event-top.c: Update.
7206         * exec.c: Update.
7207         * f-valprint.c: Update.
7208         * fbsd-tdep.c: Update.
7209         * frame-unwind.c: Update.
7210         * frame.c: Update.
7211         * gdbtypes.c: Update.
7212         * gnu-v3-abi.c: Update.
7213         * guile/guile-internal.h: Update.
7214         * guile/scm-block.c: Update.
7215         * guile/scm-breakpoint.c: Update.
7216         * guile/scm-cmd.c: Update.
7217         * guile/scm-disasm.c: Update.
7218         * guile/scm-frame.c: Update.
7219         * guile/scm-lazy-string.c: Update.
7220         * guile/scm-math.c: Update.
7221         * guile/scm-param.c: Update.
7222         * guile/scm-ports.c: Update.
7223         * guile/scm-pretty-print.c: Update.
7224         * guile/scm-symbol.c: Update.
7225         * guile/scm-symtab.c: Update.
7226         * guile/scm-type.c: Update.
7227         * guile/scm-value.c: Update.
7228         * i386-linux-tdep.c: Update.
7229         * i386-tdep.c: Update.
7230         * inf-loop.c: Update.
7231         * infcall.c: Update.
7232         * infcmd.c: Update.
7233         * infrun.c: Update.
7234         * jit.c: Update.
7235         * language.c: Update.
7236         * linespec.c: Update.
7237         * linux-fork.c: Update.
7238         * linux-nat.c: Update.
7239         * linux-tdep.c: Update.
7240         * linux-thread-db.c: Update.
7241         * main.c: Update.
7242         * mi/mi-cmd-break.c: Update.
7243         * mi/mi-cmd-stack.c: Update.
7244         * mi/mi-interp.c: Update.
7245         * mi/mi-main.c: Update.
7246         * objc-lang.c: Update.
7247         * p-valprint.c: Update.
7248         * parse.c: Update.
7249         * ppc-linux-tdep.c: Update.
7250         * printcmd.c: Update.
7251         * python/py-arch.c: Update.
7252         * python/py-breakpoint.c: Update.
7253         * python/py-cmd.c: Update.
7254         * python/py-finishbreakpoint.c: Update.
7255         * python/py-frame.c: Update.
7256         * python/py-framefilter.c: Update.
7257         * python/py-gdb-readline.c: Update.
7258         * python/py-inferior.c: Update.
7259         * python/py-infthread.c: Update.
7260         * python/py-lazy-string.c: Update.
7261         * python/py-linetable.c: Update.
7262         * python/py-objfile.c: Update.
7263         * python/py-param.c: Update.
7264         * python/py-prettyprint.c: Update.
7265         * python/py-progspace.c: Update.
7266         * python/py-record-btrace.c: Update.
7267         * python/py-record.c: Update.
7268         * python/py-symbol.c: Update.
7269         * python/py-type.c: Update.
7270         * python/py-unwind.c: Update.
7271         * python/py-utils.c: Update.
7272         * python/py-value.c: Update.
7273         * python/python.c: Update.
7274         * record-btrace.c: Update.
7275         * record-full.c: Update.
7276         * remote-fileio.c: Update.
7277         * remote.c: Update.
7278         * riscv-tdep.c: Update.
7279         * rs6000-aix-tdep.c: Update.
7280         * rs6000-tdep.c: Update.
7281         * rust-exp.y: Update.
7282         * rust-lang.c: Update.
7283         * s390-tdep.c: Update.
7284         * selftest-arch.c: Update.
7285         * solib-dsbt.c: Update.
7286         * solib-frv.c: Update.
7287         * solib-spu.c: Update.
7288         * solib-svr4.c: Update.
7289         * solib.c: Update.
7290         * sparc64-linux-tdep.c: Update.
7291         * stack.c: Update.
7292         * symfile-mem.c: Update.
7293         * symmisc.c: Update.
7294         * target.c: Update.
7295         * thread.c: Update.
7296         * top.c: Update.
7297         * tracefile-tfile.c: Update.
7298         * tui/tui.c: Update.
7299         * typeprint.c: Update.
7300         * unittests/cli-utils-selftests.c: Update.
7301         * unittests/parse-connection-spec-selftests.c: Update.
7302         * valops.c: Update.
7303         * valprint.c: Update.
7304         * value.c: Update.
7305         * varobj.c: Update.
7306         * windows-nat.c: Update.
7307         * x86-linux-nat.c: Update.
7308         * xml-support.c: Update.
7309
7310 2019-04-08  Tom Tromey  <tom@tromey.com>
7311
7312         * xml-support.c: Use C++ exception handling.
7313         * x86-linux-nat.c: Use C++ exception handling.
7314         * windows-nat.c: Use C++ exception handling.
7315         * varobj.c: Use C++ exception handling.
7316         * value.c: Use C++ exception handling.
7317         * valprint.c: Use C++ exception handling.
7318         * valops.c: Use C++ exception handling.
7319         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7320         handling.
7321         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7322         * typeprint.c: Use C++ exception handling.
7323         * tui/tui.c: Use C++ exception handling.
7324         * tracefile-tfile.c: Use C++ exception handling.
7325         * top.c: Use C++ exception handling.
7326         * thread.c: Use C++ exception handling.
7327         * target.c: Use C++ exception handling.
7328         * symmisc.c: Use C++ exception handling.
7329         * symfile-mem.c: Use C++ exception handling.
7330         * stack.c: Use C++ exception handling.
7331         * sparc64-linux-tdep.c: Use C++ exception handling.
7332         * solib.c: Use C++ exception handling.
7333         * solib-svr4.c: Use C++ exception handling.
7334         * solib-spu.c: Use C++ exception handling.
7335         * solib-frv.c: Use C++ exception handling.
7336         * solib-dsbt.c: Use C++ exception handling.
7337         * selftest-arch.c: Use C++ exception handling.
7338         * s390-tdep.c: Use C++ exception handling.
7339         * rust-lang.c: Use C++ exception handling.
7340         * rust-exp.y: Use C++ exception handling.
7341         * rs6000-tdep.c: Use C++ exception handling.
7342         * rs6000-aix-tdep.c: Use C++ exception handling.
7343         * riscv-tdep.c: Use C++ exception handling.
7344         * remote.c: Use C++ exception handling.
7345         * remote-fileio.c: Use C++ exception handling.
7346         * record-full.c: Use C++ exception handling.
7347         * record-btrace.c: Use C++ exception handling.
7348         * python/python.c: Use C++ exception handling.
7349         * python/py-value.c: Use C++ exception handling.
7350         * python/py-utils.c: Use C++ exception handling.
7351         * python/py-unwind.c: Use C++ exception handling.
7352         * python/py-type.c: Use C++ exception handling.
7353         * python/py-symbol.c: Use C++ exception handling.
7354         * python/py-record.c: Use C++ exception handling.
7355         * python/py-record-btrace.c: Use C++ exception handling.
7356         * python/py-progspace.c: Use C++ exception handling.
7357         * python/py-prettyprint.c: Use C++ exception handling.
7358         * python/py-param.c: Use C++ exception handling.
7359         * python/py-objfile.c: Use C++ exception handling.
7360         * python/py-linetable.c: Use C++ exception handling.
7361         * python/py-lazy-string.c: Use C++ exception handling.
7362         * python/py-infthread.c: Use C++ exception handling.
7363         * python/py-inferior.c: Use C++ exception handling.
7364         * python/py-gdb-readline.c: Use C++ exception handling.
7365         * python/py-framefilter.c: Use C++ exception handling.
7366         * python/py-frame.c: Use C++ exception handling.
7367         * python/py-finishbreakpoint.c: Use C++ exception handling.
7368         * python/py-cmd.c: Use C++ exception handling.
7369         * python/py-breakpoint.c: Use C++ exception handling.
7370         * python/py-arch.c: Use C++ exception handling.
7371         * printcmd.c: Use C++ exception handling.
7372         * ppc-linux-tdep.c: Use C++ exception handling.
7373         * parse.c: Use C++ exception handling.
7374         * p-valprint.c: Use C++ exception handling.
7375         * objc-lang.c: Use C++ exception handling.
7376         * mi/mi-main.c: Use C++ exception handling.
7377         * mi/mi-interp.c: Use C++ exception handling.
7378         * mi/mi-cmd-stack.c: Use C++ exception handling.
7379         * mi/mi-cmd-break.c: Use C++ exception handling.
7380         * main.c: Use C++ exception handling.
7381         * linux-thread-db.c: Use C++ exception handling.
7382         * linux-tdep.c: Use C++ exception handling.
7383         * linux-nat.c: Use C++ exception handling.
7384         * linux-fork.c: Use C++ exception handling.
7385         * linespec.c: Use C++ exception handling.
7386         * language.c: Use C++ exception handling.
7387         * jit.c: Use C++ exception handling.
7388         * infrun.c: Use C++ exception handling.
7389         * infcmd.c: Use C++ exception handling.
7390         * infcall.c: Use C++ exception handling.
7391         * inf-loop.c: Use C++ exception handling.
7392         * i386-tdep.c: Use C++ exception handling.
7393         * i386-linux-tdep.c: Use C++ exception handling.
7394         * guile/scm-value.c: Use C++ exception handling.
7395         * guile/scm-type.c: Use C++ exception handling.
7396         * guile/scm-symtab.c: Use C++ exception handling.
7397         * guile/scm-symbol.c: Use C++ exception handling.
7398         * guile/scm-pretty-print.c: Use C++ exception handling.
7399         * guile/scm-ports.c: Use C++ exception handling.
7400         * guile/scm-param.c: Use C++ exception handling.
7401         * guile/scm-math.c: Use C++ exception handling.
7402         * guile/scm-lazy-string.c: Use C++ exception handling.
7403         * guile/scm-frame.c: Use C++ exception handling.
7404         * guile/scm-disasm.c: Use C++ exception handling.
7405         * guile/scm-cmd.c: Use C++ exception handling.
7406         * guile/scm-breakpoint.c: Use C++ exception handling.
7407         * guile/scm-block.c: Use C++ exception handling.
7408         * guile/guile-internal.h: Use C++ exception handling.
7409         * gnu-v3-abi.c: Use C++ exception handling.
7410         * gdbtypes.c: Use C++ exception handling.
7411         * frame.c: Use C++ exception handling.
7412         * frame-unwind.c: Use C++ exception handling.
7413         * fbsd-tdep.c: Use C++ exception handling.
7414         * f-valprint.c: Use C++ exception handling.
7415         * exec.c: Use C++ exception handling.
7416         * event-top.c: Use C++ exception handling.
7417         * event-loop.c: Use C++ exception handling.
7418         * eval.c: Use C++ exception handling.
7419         * dwarf2read.c: Use C++ exception handling.
7420         * dwarf2loc.c: Use C++ exception handling.
7421         * dwarf2-frame.c: Use C++ exception handling.
7422         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7423         * dwarf-index-write.c: Use C++ exception handling.
7424         * dwarf-index-cache.c: Use C++ exception handling.
7425         * dtrace-probe.c: Use C++ exception handling.
7426         * disasm-selftests.c: Use C++ exception handling.
7427         * darwin-nat.c: Use C++ exception handling.
7428         * cp-valprint.c: Use C++ exception handling.
7429         * cp-support.c: Use C++ exception handling.
7430         * cp-abi.c: Use C++ exception handling.
7431         * corelow.c: Use C++ exception handling.
7432         * completer.c: Use C++ exception handling.
7433         * compile/compile-object-run.c: Use C++ exception handling.
7434         * compile/compile-object-load.c: Use C++ exception handling.
7435         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7436         * compile/compile-c-symbols.c: Use C++ exception handling.
7437         * common/selftest.c: Use C++ exception handling.
7438         * common/new-op.c: Use C++ exception handling.
7439         * cli/cli-script.c: Use C++ exception handling.
7440         * cli/cli-interp.c: Use C++ exception handling.
7441         * cli/cli-cmds.c: Use C++ exception handling.
7442         * c-varobj.c: Use C++ exception handling.
7443         * btrace.c: Use C++ exception handling.
7444         * breakpoint.c: Use C++ exception handling.
7445         * break-catch-throw.c: Use C++ exception handling.
7446         * arch-utils.c: Use C++ exception handling.
7447         * amd64-tdep.c: Use C++ exception handling.
7448         * ada-valprint.c: Use C++ exception handling.
7449         * ada-typeprint.c: Use C++ exception handling.
7450         * ada-lang.c: Use C++ exception handling.
7451         * aarch64-tdep.c: Use C++ exception handling.
7452
7453 2019-04-08  Tom Tromey  <tom@tromey.com>
7454
7455         * xml-support.c (gdb_xml_parser::parse): Update.
7456         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7457         * value.c (show_convenience): Update.
7458         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7459         (test_parse_flags_qcs): Update.
7460         * thread.c (thr_try_catch_cmd): Update.
7461         * target.c (target_translate_tls_address): Update.
7462         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7463         (info_frame_command_core, frame_apply_command_count): Update.
7464         * rust-exp.y (rust_lex_exception_test): Update.
7465         * riscv-tdep.c (riscv_print_one_register_info): Update.
7466         * remote.c (remote_target::enable_btrace): Update.
7467         * record-btrace.c (record_btrace_enable_warn): Update.
7468         * python/py-utils.c (gdbpy_convert_exception): Update.
7469         * printcmd.c (do_one_display, print_variable_and_value): Update.
7470         * mi/mi-main.c (mi_print_exception): Update.
7471         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7472         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7473         * linux-nat.c (linux_nat_target::attach): Update.
7474         * linux-fork.c (class scoped_switch_fork_info): Update.
7475         * infrun.c (displaced_step_prepare): Update.
7476         * infcall.c (call_function_by_hand_dummy): Update.
7477         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7478         * gnu-v3-abi.c (print_one_vtable): Update.
7479         * frame.c (get_prev_frame_always): Update.
7480         * f-valprint.c (info_common_command_for_block): Update.
7481         * exec.c (try_open_exec_file): Update.
7482         * exceptions.c (print_exception, exception_print)
7483         (exception_fprintf, exception_print_same): Update.
7484         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7485         * dwarf-index-cache.c (index_cache::store)
7486         (index_cache::lookup_gdb_index): Update.
7487         * darwin-nat.c (maybe_cache_shell): Update.
7488         * cp-valprint.c (cp_print_value_fields): Update.
7489         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7490         (gcc_cplus_symbol_address): Update.
7491         * compile/compile-c-symbols.c (gcc_convert_symbol)
7492         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7493         * common/selftest.c: Update.
7494         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7495         a std::string.
7496         (exception_try_scope_entry, exception_try_scope_exit): Don't
7497         declare.
7498         (struct exception_try_scope): Remove.
7499         (TRY): Don't use exception_try_scope.
7500         (struct gdb_exception): Add constructor, operator=.
7501         <what>: New method.
7502         (struct gdb_exception_RETURN_MASK_ALL)
7503         (struct gdb_exception_RETURN_MASK_ERROR)
7504         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7505         (struct gdb_quit_bad_alloc): Update.
7506         * common/common-exceptions.c (exception_none): Change
7507         initializer.
7508         (struct catcher) <state, exception>: Initialize inline.
7509         <prev>: Remove member.
7510         (current_catcher): Remove.
7511         (catchers): New global.
7512         (exceptions_state_mc_init): Simplify.
7513         (catcher_pop): Remove.
7514         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7515         (try_scope_depth, exception_try_scope_entry)
7516         (exception_try_scope_exit): Remove.
7517         (throw_exception_sjlj): Update.
7518         (exception_messages, exception_messages_size): Remove.
7519         (throw_it): Simplify.
7520         (gdb_exception_sliced_copy): Remove.
7521         (throw_exception_cxx): Update.
7522         * cli/cli-script.c (script_from_file): Update.
7523         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7524         Update.
7525         * ada-valprint.c (ada_val_print): Update.
7526         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7527         (create_excep_cond_exprs): Update.
7528
7529 2019-04-08  Tom Tromey  <tom@tromey.com>
7530
7531         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7532         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7533         (TRY, CATCH, END_CATCH): Remove some definitions.
7534         * common/common-exceptions.c: Don't use GDB_XCPT.
7535         (catcher_list_size): Remove.
7536         (throw_exception, throw_it): Simplify.
7537
7538 2019-04-05  Tom Tromey  <tom@tromey.com>
7539
7540         Revert the header-sorting patch.
7541         * ft32-tdep.c: Revert.
7542         * frv-tdep.c: Revert.
7543         * frv-linux-tdep.c: Revert.
7544         * frame.c: Revert.
7545         * frame-unwind.c: Revert.
7546         * frame-base.c: Revert.
7547         * fork-child.c: Revert.
7548         * findvar.c: Revert.
7549         * findcmd.c: Revert.
7550         * filesystem.c: Revert.
7551         * filename-seen-cache.h: Revert.
7552         * filename-seen-cache.c: Revert.
7553         * fbsd-tdep.c: Revert.
7554         * fbsd-nat.h: Revert.
7555         * fbsd-nat.c: Revert.
7556         * f-valprint.c: Revert.
7557         * f-typeprint.c: Revert.
7558         * f-lang.c: Revert.
7559         * extension.h: Revert.
7560         * extension.c: Revert.
7561         * extension-priv.h: Revert.
7562         * expprint.c: Revert.
7563         * exec.h: Revert.
7564         * exec.c: Revert.
7565         * exceptions.c: Revert.
7566         * event-top.c: Revert.
7567         * event-loop.c: Revert.
7568         * eval.c: Revert.
7569         * elfread.c: Revert.
7570         * dwarf2read.h: Revert.
7571         * dwarf2read.c: Revert.
7572         * dwarf2loc.c: Revert.
7573         * dwarf2expr.h: Revert.
7574         * dwarf2expr.c: Revert.
7575         * dwarf2-frame.c: Revert.
7576         * dwarf2-frame-tailcall.c: Revert.
7577         * dwarf-index-write.h: Revert.
7578         * dwarf-index-write.c: Revert.
7579         * dwarf-index-common.c: Revert.
7580         * dwarf-index-cache.h: Revert.
7581         * dwarf-index-cache.c: Revert.
7582         * dummy-frame.c: Revert.
7583         * dtrace-probe.c: Revert.
7584         * disasm.h: Revert.
7585         * disasm.c: Revert.
7586         * disasm-selftests.c: Revert.
7587         * dictionary.c: Revert.
7588         * dicos-tdep.c: Revert.
7589         * demangle.c: Revert.
7590         * dcache.h: Revert.
7591         * dcache.c: Revert.
7592         * darwin-nat.h: Revert.
7593         * darwin-nat.c: Revert.
7594         * darwin-nat-info.c: Revert.
7595         * d-valprint.c: Revert.
7596         * d-namespace.c: Revert.
7597         * d-lang.c: Revert.
7598         * ctf.c: Revert.
7599         * csky-tdep.c: Revert.
7600         * csky-linux-tdep.c: Revert.
7601         * cris-tdep.c: Revert.
7602         * cris-linux-tdep.c: Revert.
7603         * cp-valprint.c: Revert.
7604         * cp-support.c: Revert.
7605         * cp-namespace.c: Revert.
7606         * cp-abi.c: Revert.
7607         * corelow.c: Revert.
7608         * corefile.c: Revert.
7609         * continuations.c: Revert.
7610         * completer.h: Revert.
7611         * completer.c: Revert.
7612         * complaints.c: Revert.
7613         * coffread.c: Revert.
7614         * coff-pe-read.c: Revert.
7615         * cli-out.h: Revert.
7616         * cli-out.c: Revert.
7617         * charset.c: Revert.
7618         * c-varobj.c: Revert.
7619         * c-valprint.c: Revert.
7620         * c-typeprint.c: Revert.
7621         * c-lang.c: Revert.
7622         * buildsym.c: Revert.
7623         * buildsym-legacy.c: Revert.
7624         * build-id.h: Revert.
7625         * build-id.c: Revert.
7626         * btrace.c: Revert.
7627         * bsd-uthread.c: Revert.
7628         * breakpoint.h: Revert.
7629         * breakpoint.c: Revert.
7630         * break-catch-throw.c: Revert.
7631         * break-catch-syscall.c: Revert.
7632         * break-catch-sig.c: Revert.
7633         * blockframe.c: Revert.
7634         * block.c: Revert.
7635         * bfin-tdep.c: Revert.
7636         * bfin-linux-tdep.c: Revert.
7637         * bfd-target.c: Revert.
7638         * bcache.c: Revert.
7639         * ax-general.c: Revert.
7640         * ax-gdb.h: Revert.
7641         * ax-gdb.c: Revert.
7642         * avr-tdep.c: Revert.
7643         * auxv.c: Revert.
7644         * auto-load.c: Revert.
7645         * arm-wince-tdep.c: Revert.
7646         * arm-tdep.c: Revert.
7647         * arm-symbian-tdep.c: Revert.
7648         * arm-pikeos-tdep.c: Revert.
7649         * arm-obsd-tdep.c: Revert.
7650         * arm-nbsd-tdep.c: Revert.
7651         * arm-nbsd-nat.c: Revert.
7652         * arm-linux-tdep.c: Revert.
7653         * arm-linux-nat.c: Revert.
7654         * arm-fbsd-tdep.c: Revert.
7655         * arm-fbsd-nat.c: Revert.
7656         * arm-bsd-tdep.c: Revert.
7657         * arch-utils.c: Revert.
7658         * arc-tdep.c: Revert.
7659         * arc-newlib-tdep.c: Revert.
7660         * annotate.h: Revert.
7661         * annotate.c: Revert.
7662         * amd64-windows-tdep.c: Revert.
7663         * amd64-windows-nat.c: Revert.
7664         * amd64-tdep.c: Revert.
7665         * amd64-sol2-tdep.c: Revert.
7666         * amd64-obsd-tdep.c: Revert.
7667         * amd64-obsd-nat.c: Revert.
7668         * amd64-nbsd-tdep.c: Revert.
7669         * amd64-nbsd-nat.c: Revert.
7670         * amd64-nat.c: Revert.
7671         * amd64-linux-tdep.c: Revert.
7672         * amd64-linux-nat.c: Revert.
7673         * amd64-fbsd-tdep.c: Revert.
7674         * amd64-fbsd-nat.c: Revert.
7675         * amd64-dicos-tdep.c: Revert.
7676         * amd64-darwin-tdep.c: Revert.
7677         * amd64-bsd-nat.c: Revert.
7678         * alpha-tdep.c: Revert.
7679         * alpha-obsd-tdep.c: Revert.
7680         * alpha-nbsd-tdep.c: Revert.
7681         * alpha-mdebug-tdep.c: Revert.
7682         * alpha-linux-tdep.c: Revert.
7683         * alpha-linux-nat.c: Revert.
7684         * alpha-bsd-tdep.c: Revert.
7685         * alpha-bsd-nat.c: Revert.
7686         * aix-thread.c: Revert.
7687         * agent.c: Revert.
7688         * addrmap.c: Revert.
7689         * ada-varobj.c: Revert.
7690         * ada-valprint.c: Revert.
7691         * ada-typeprint.c: Revert.
7692         * ada-tasks.c: Revert.
7693         * ada-lang.c: Revert.
7694         * aarch64-tdep.c: Revert.
7695         * aarch64-ravenscar-thread.c: Revert.
7696         * aarch64-newlib-tdep.c: Revert.
7697         * aarch64-linux-tdep.c: Revert.
7698         * aarch64-linux-nat.c: Revert.
7699         * aarch64-fbsd-tdep.c: Revert.
7700         * aarch64-fbsd-nat.c: Revert.
7701         * aarch32-linux-nat.c: Revert.
7702
7703 2019-04-05  Tom Tromey  <tom@tromey.com>
7704
7705         * ft32-tdep.c: Sort headers.
7706         * frv-tdep.c: Sort headers.
7707         * frv-linux-tdep.c: Sort headers.
7708         * frame.c: Sort headers.
7709         * frame-unwind.c: Sort headers.
7710         * frame-base.c: Sort headers.
7711         * fork-child.c: Sort headers.
7712         * findvar.c: Sort headers.
7713         * findcmd.c: Sort headers.
7714         * filesystem.c: Sort headers.
7715         * filename-seen-cache.h: Sort headers.
7716         * filename-seen-cache.c: Sort headers.
7717         * fbsd-tdep.c: Sort headers.
7718         * fbsd-nat.h: Sort headers.
7719         * fbsd-nat.c: Sort headers.
7720         * f-valprint.c: Sort headers.
7721         * f-typeprint.c: Sort headers.
7722         * f-lang.c: Sort headers.
7723         * extension.h: Sort headers.
7724         * extension.c: Sort headers.
7725         * extension-priv.h: Sort headers.
7726         * expprint.c: Sort headers.
7727         * exec.h: Sort headers.
7728         * exec.c: Sort headers.
7729         * exceptions.c: Sort headers.
7730         * event-top.c: Sort headers.
7731         * event-loop.c: Sort headers.
7732         * eval.c: Sort headers.
7733         * elfread.c: Sort headers.
7734         * dwarf2read.h: Sort headers.
7735         * dwarf2read.c: Sort headers.
7736         * dwarf2loc.c: Sort headers.
7737         * dwarf2expr.h: Sort headers.
7738         * dwarf2expr.c: Sort headers.
7739         * dwarf2-frame.c: Sort headers.
7740         * dwarf2-frame-tailcall.c: Sort headers.
7741         * dwarf-index-write.h: Sort headers.
7742         * dwarf-index-write.c: Sort headers.
7743         * dwarf-index-common.c: Sort headers.
7744         * dwarf-index-cache.h: Sort headers.
7745         * dwarf-index-cache.c: Sort headers.
7746         * dummy-frame.c: Sort headers.
7747         * dtrace-probe.c: Sort headers.
7748         * disasm.h: Sort headers.
7749         * disasm.c: Sort headers.
7750         * disasm-selftests.c: Sort headers.
7751         * dictionary.c: Sort headers.
7752         * dicos-tdep.c: Sort headers.
7753         * demangle.c: Sort headers.
7754         * dcache.h: Sort headers.
7755         * dcache.c: Sort headers.
7756         * darwin-nat.h: Sort headers.
7757         * darwin-nat.c: Sort headers.
7758         * darwin-nat-info.c: Sort headers.
7759         * d-valprint.c: Sort headers.
7760         * d-namespace.c: Sort headers.
7761         * d-lang.c: Sort headers.
7762         * ctf.c: Sort headers.
7763         * csky-tdep.c: Sort headers.
7764         * csky-linux-tdep.c: Sort headers.
7765         * cris-tdep.c: Sort headers.
7766         * cris-linux-tdep.c: Sort headers.
7767         * cp-valprint.c: Sort headers.
7768         * cp-support.c: Sort headers.
7769         * cp-namespace.c: Sort headers.
7770         * cp-abi.c: Sort headers.
7771         * corelow.c: Sort headers.
7772         * corefile.c: Sort headers.
7773         * continuations.c: Sort headers.
7774         * completer.h: Sort headers.
7775         * completer.c: Sort headers.
7776         * complaints.c: Sort headers.
7777         * coffread.c: Sort headers.
7778         * coff-pe-read.c: Sort headers.
7779         * cli-out.h: Sort headers.
7780         * cli-out.c: Sort headers.
7781         * charset.c: Sort headers.
7782         * c-varobj.c: Sort headers.
7783         * c-valprint.c: Sort headers.
7784         * c-typeprint.c: Sort headers.
7785         * c-lang.c: Sort headers.
7786         * buildsym.c: Sort headers.
7787         * buildsym-legacy.c: Sort headers.
7788         * build-id.h: Sort headers.
7789         * build-id.c: Sort headers.
7790         * btrace.c: Sort headers.
7791         * bsd-uthread.c: Sort headers.
7792         * breakpoint.h: Sort headers.
7793         * breakpoint.c: Sort headers.
7794         * break-catch-throw.c: Sort headers.
7795         * break-catch-syscall.c: Sort headers.
7796         * break-catch-sig.c: Sort headers.
7797         * blockframe.c: Sort headers.
7798         * block.c: Sort headers.
7799         * bfin-tdep.c: Sort headers.
7800         * bfin-linux-tdep.c: Sort headers.
7801         * bfd-target.c: Sort headers.
7802         * bcache.c: Sort headers.
7803         * ax-general.c: Sort headers.
7804         * ax-gdb.h: Sort headers.
7805         * ax-gdb.c: Sort headers.
7806         * avr-tdep.c: Sort headers.
7807         * auxv.c: Sort headers.
7808         * auto-load.c: Sort headers.
7809         * arm-wince-tdep.c: Sort headers.
7810         * arm-tdep.c: Sort headers.
7811         * arm-symbian-tdep.c: Sort headers.
7812         * arm-pikeos-tdep.c: Sort headers.
7813         * arm-obsd-tdep.c: Sort headers.
7814         * arm-nbsd-tdep.c: Sort headers.
7815         * arm-nbsd-nat.c: Sort headers.
7816         * arm-linux-tdep.c: Sort headers.
7817         * arm-linux-nat.c: Sort headers.
7818         * arm-fbsd-tdep.c: Sort headers.
7819         * arm-fbsd-nat.c: Sort headers.
7820         * arm-bsd-tdep.c: Sort headers.
7821         * arch-utils.c: Sort headers.
7822         * arc-tdep.c: Sort headers.
7823         * arc-newlib-tdep.c: Sort headers.
7824         * annotate.h: Sort headers.
7825         * annotate.c: Sort headers.
7826         * amd64-windows-tdep.c: Sort headers.
7827         * amd64-windows-nat.c: Sort headers.
7828         * amd64-tdep.c: Sort headers.
7829         * amd64-sol2-tdep.c: Sort headers.
7830         * amd64-obsd-tdep.c: Sort headers.
7831         * amd64-obsd-nat.c: Sort headers.
7832         * amd64-nbsd-tdep.c: Sort headers.
7833         * amd64-nbsd-nat.c: Sort headers.
7834         * amd64-nat.c: Sort headers.
7835         * amd64-linux-tdep.c: Sort headers.
7836         * amd64-linux-nat.c: Sort headers.
7837         * amd64-fbsd-tdep.c: Sort headers.
7838         * amd64-fbsd-nat.c: Sort headers.
7839         * amd64-dicos-tdep.c: Sort headers.
7840         * amd64-darwin-tdep.c: Sort headers.
7841         * amd64-bsd-nat.c: Sort headers.
7842         * alpha-tdep.c: Sort headers.
7843         * alpha-obsd-tdep.c: Sort headers.
7844         * alpha-nbsd-tdep.c: Sort headers.
7845         * alpha-mdebug-tdep.c: Sort headers.
7846         * alpha-linux-tdep.c: Sort headers.
7847         * alpha-linux-nat.c: Sort headers.
7848         * alpha-bsd-tdep.c: Sort headers.
7849         * alpha-bsd-nat.c: Sort headers.
7850         * aix-thread.c: Sort headers.
7851         * agent.c: Sort headers.
7852         * addrmap.c: Sort headers.
7853         * ada-varobj.c: Sort headers.
7854         * ada-valprint.c: Sort headers.
7855         * ada-typeprint.c: Sort headers.
7856         * ada-tasks.c: Sort headers.
7857         * ada-lang.c: Sort headers.
7858         * aarch64-tdep.c: Sort headers.
7859         * aarch64-ravenscar-thread.c: Sort headers.
7860         * aarch64-newlib-tdep.c: Sort headers.
7861         * aarch64-linux-tdep.c: Sort headers.
7862         * aarch64-linux-nat.c: Sort headers.
7863         * aarch64-fbsd-tdep.c: Sort headers.
7864         * aarch64-fbsd-nat.c: Sort headers.
7865         * aarch32-linux-nat.c: Sort headers.
7866
7867 2019-04-04  Tom Tromey  <tom@tromey.com>
7868
7869         * varobj.c (varobj_create): Update.
7870         * rust-exp.y (struct rust_parser) <update_innermost_block,
7871         lookup_symbol>: New methods.
7872         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7873         Rename.
7874         (rust_parser::rust_lookup_type)
7875         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7876         * printcmd.c (display_command, do_one_display): Update.
7877         * parser-defs.h (struct parser_state) <parser_state>: Add
7878         "tracker" parameter.
7879         (block_tracker): New member.
7880         (class innermost_block_tracker) <innermost_block_tracker>: Add
7881         "types" parameter.
7882         <reset>: Remove method.
7883         (innermost_block): Don't declare.
7884         (null_post_parser): Update.
7885         * parse.c (innermost_block): Remove global.
7886         (write_dollar_variable): Update.
7887         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7888         Remove "tracker_types" parameter.
7889         (parse_expression): Add "tracker" parameter.
7890         (parse_expression_for_completion): Update.
7891         (null_post_parser): Add "tracker" parameter.
7892         * p-exp.y: Update rules.
7893         * m2-exp.y: Update rules.
7894         * language.h (struct language_defn) <la_post_parser>: Add
7895         "tracker" parameter.
7896         * go-exp.y: Update rules.
7897         * f-exp.y: Update rules.
7898         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7899         parameter.
7900         * d-exp.y: Update rules.
7901         * c-exp.y: Update rules.
7902         * breakpoint.c (set_breakpoint_condition): Create an
7903         innermost_block_tracker.
7904         (watch_command_1): Likewise.
7905         * ada-lang.c (resolve): Add "tracker" parameter.
7906         (resolve_subexp): Likewise.
7907         * ada-exp.y (write_var_from_sym): Update.
7908
7909 2019-04-04  Tom Tromey  <tom@tromey.com>
7910
7911         * type-stack.h: New file.
7912         * type-stack.c: New file.
7913         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7914         type-stack.h.
7915         (insert_into_type_stack, insert_type, push_type, push_type_int)
7916         (insert_type_address_space, pop_type, pop_type_int)
7917         (pop_typelist, pop_type_stack, append_type_stack)
7918         (push_type_stack, get_type_stack, push_typelist)
7919         (follow_type_instance_flags, follow_types): Don't declare.
7920         * parse.c (type_stack): Remove global.
7921         (parse_exp_in_context): Update.
7922         (insert_into_type_stack, insert_type, push_type, push_type_int)
7923         (insert_type_address_space, pop_type, pop_type_int)
7924         (pop_typelist, pop_type_stack, append_type_stack)
7925         (push_type_stack, get_type_stack, push_typelist)
7926         (follow_type_instance_flags, follow_types): Remove (moved to
7927         type-stack.c).
7928         * f-exp.y (type_stack): New global.
7929         Update rules.
7930         (push_kind_type, f_parse): Update.
7931         * d-exp.y (type_stack): New global.
7932         Update rules.
7933         (d_parse): Update.
7934         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7935         Update rules.
7936         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7937         (HFILES_NO_SRCDIR): Add type-stack.h.
7938
7939 2019-04-04  Tom Tromey  <tom@tromey.com>
7940
7941         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7942         (rust_parser::convert_ast_to_expression, rust_parse)
7943         (rust_lex_test_completion, rust_lex_tests): Update.
7944         * parser-defs.h (struct expr_completion_state): New.
7945         (struct parser_state) <parser_state>: Add completion parameter.
7946         <mark_struct_expression, mark_completion_tag>: New methods.
7947         <parse_completion, m_completion_state>: New members.
7948         (prefixify_expression, null_post_parser): Update.
7949         (mark_struct_expression, mark_completion_tag): Don't declare.
7950         * parse.c (parse_completion, expout_last_struct)
7951         (expout_tag_completion_type, expout_completion_name): Remove
7952         globals.
7953         (parser_state::mark_struct_expression)
7954         (parser_state::mark_completion_tag): Now methods.
7955         (prefixify_expression): Add last_struct parameter.
7956         (prefixify_subexp): Likewise.
7957         (parse_exp_1): Update.
7958         (parse_exp_in_context): Add cstate parameter.  Update.
7959         (parse_expression_for_completion): Create an
7960         expr_completion_state.
7961         (null_post_parser): Add "completion" parameter.
7962         * p-exp.y: Update rules.
7963         (yylex): Update.
7964         * language.h (struct language_defn) <la_post_parser>: Add
7965         "completing" parameter.
7966         * go-exp.y: Update rules.
7967         (lex_one_token): Update.
7968         * expression.h (parse_completion): Don't declare.
7969         * d-exp.y: Update rules.
7970         (lex_one_token): Update rules.
7971         * c-exp.y: Update rules.
7972         (lex_one_token): Update.
7973         * ada-lang.c (resolve): Add "parse_completion" parameter.
7974         (resolve_subexp): Likewise.
7975         (ada_resolve_function): Likewise.
7976
7977 2019-04-04  Tom Tromey  <tom@tromey.com>
7978
7979         * parser-defs.h (struct parser_state) <start_arglist,
7980         end_arglist>: New methods.
7981         <arglist_len, m_funcall_chain>: New members.
7982         (arglist_len, start_arglist, end_arglist): Don't declare.
7983         * parse.c (arglist_len, funcall_chain): Remove global.
7984         (start_arglist, end_arglist): Remove functions.
7985         (parse_exp_in_context): Update.
7986         * p-exp.y: Update rules.
7987         * m2-exp.y: Update rules.
7988         * go-exp.y: Update rules.
7989         * f-exp.y: Update rules.
7990         * d-exp.y: Update rules.
7991         * c-exp.y: Update rules.
7992
7993 2019-04-04  Tom Tromey  <tom@tromey.com>
7994
7995         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7996         lex_operator, push_back>: New methods.
7997         Update all rules.
7998         (rust_parser::lex_hex, lex_escape): Rename and update.
7999         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8000         (rust_parser::lex_operator): Rename and update.
8001         (rust_parser::lex_number, rustyylex, rustyyerror)
8002         (rust_lex_test_init, rust_lex_test_sequence)
8003         (rust_lex_test_push_back, rust_lex_tests): Update.
8004         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8005         parameter.
8006         <lexptr, prev_lexptr>: New members.
8007         (lexptr, prev_lexptr): Don't declare.
8008         * parse.c (lexptr, prev_lexptr): Remove globals.
8009         (parse_exp_in_context): Update.
8010         * p-exp.y (yylex, yyerror): Update.
8011         * m2-exp.y (parse_number, yylex, yyerror): Update.
8012         * go-exp.y (lex_one_token, yyerror): Update.
8013         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8014         * d-exp.y (lex_one_token, yyerror): Update.
8015         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8016         (lex_one_token, yyerror): Update.
8017         * ada-lex.l (YY_INPUT): Update.
8018         (rewind_to_char): Update.
8019         * ada-exp.y (yyerror): Update.
8020
8021 2019-04-04  Tom Tromey  <tom@tromey.com>
8022
8023         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8024         * parser-defs.h (struct parser_state) <parser_state>: Add new
8025         parameter.
8026         <comma_terminates>: New member.
8027         (comma_terminates): Don't declare global.
8028         * parse.c (comma_terminates): Remove global.
8029         (parse_exp_in_context): Update.
8030         * p-exp.y (yylex): Update.
8031         * m2-exp.y (yylex): Update.
8032         * go-exp.y (lex_one_token): Update.
8033         * f-exp.y (yylex): Update.
8034         * d-exp.y (lex_one_token): Update.
8035         * c-exp.y (lex_one_token): Update.
8036         * ada-lex.l: Update.
8037
8038 2019-04-04  Tom Tromey  <tom@tromey.com>
8039
8040         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8041         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8042         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8043         * parser-defs.h (paren_depth): Don't declare.
8044         * parse.c (paren_depth): Remove global.
8045         (parse_exp_in_context): Update.
8046         * p-exp.y (paren_depth): New global.
8047         (pascal_parse): Initialize it.
8048         * m2-exp.y (paren_depth): New global.
8049         (m2_parse): Initialize it.
8050         * go-exp.y (paren_depth): New global.
8051         (go_parse): Initialize it.
8052         * f-exp.y (paren_depth): New global.
8053         (f_parse): Initialize it.
8054         * d-exp.y (paren_depth): New global.
8055         (d_parse): Initialize it.
8056         * c-exp.y (paren_depth): New global.
8057         (c_parse): Initialize it.
8058         * ada-lex.l (paren_depth): New global.
8059         (lexer_init): Initialize it.
8060
8061 2019-04-04  Tom Tromey  <tom@tromey.com>
8062
8063         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8064         (rust_parser::convert_ast_to_type)
8065         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8066         * parser-defs.h (struct parser_state) <parser_state>: Add
8067         parameters.  Initialize new members.
8068         <expression_context_block, expression_context_pc>: New members.
8069         * parse.c (expression_context_block, expression_context_pc):
8070         Remove globals.
8071         (parse_exp_in_context): Update.
8072         * p-exp.y: Update all rules.
8073         (yylex): Update.
8074         * m2-exp.y: Update all rules.
8075         (yylex): Update.
8076         * go-exp.y (yylex): Update.
8077         * f-exp.y (yylex): Update.
8078         * d-exp.y: Update all rules.
8079         (yylex): Update.
8080         * c-exp.y: Update all rules.
8081         (lex_one_token, classify_name, yylex, c_parse): Update.
8082         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8083
8084 2019-04-04  Tom Tromey  <tom@tromey.com>
8085
8086         * gdbarch.h, gdbarch.c: Rebuild.
8087         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8088         * stap-probe.h:
8089         (struct stap_parse_info): Replace "parser_state" with
8090         "expr_builder".
8091         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8092         (parser_state): New class.
8093         * parse.c (expr_builder): Rename.
8094         (expr_builder::release): Rename.
8095         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8096         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8097         (write_exp_elt_longcst, write_exp_elt_floatcst)
8098         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8099         (write_exp_string_vector, write_exp_bitstring)
8100         (write_exp_msymbol, mark_struct_expression)
8101         (write_dollar_variable)
8102         (insert_type_address_space, increase_expout_size): Replace
8103         "parser_state" with "expr_builder".
8104         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8105         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8106         "parser_state" with "expr_builder".
8107
8108 2019-04-04  Tom Tromey  <tom@tromey.com>
8109
8110         * rust-exp.y: Replace "parse_language" with method call.
8111         * p-exp.y:
8112         (yylex): Replace "parse_language" with method call.
8113         * m2-exp.y:
8114         (yylex): Replace "parse_language" with method call.
8115         * go-exp.y (classify_name): Replace "parse_language" with method
8116         call.
8117         * f-exp.y (yylex): Replace "parse_language" with method call.
8118         * d-exp.y (lex_one_token): Replace "parse_language" with method
8119         call.
8120         * c-exp.y:
8121         (lex_one_token, classify_name, yylex): Replace "parse_language"
8122         with method call.
8123         * ada-exp.y (find_primitive_type, type_char)
8124         (type_system_address): Replace "parse_language" with method call.
8125
8126 2019-04-04  Tom Tromey  <tom@tromey.com>
8127
8128         * rust-exp.y: Replace "parse_gdbarch" with method call.
8129         * parse.c (write_dollar_variable, insert_type_address_space):
8130         Replace "parse_gdbarch" with method call.
8131         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8132         call.
8133         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8134         call.
8135         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8136         "parse_gdbarch" with method call.
8137         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8138         with method call.
8139         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8140         "parse_gdbarch" with method call.
8141         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8142         "parse_gdbarch" with method call.
8143         * c-exp.y (parse_type, parse_number, classify_name): Replace
8144         "parse_gdbarch" with method call.
8145         * ada-lex.l: Replace "parse_gdbarch" with method call.
8146         * ada-exp.y (parse_type, find_primitive_type, type_char)
8147         (type_system_address): Replace "parse_gdbarch" with method call.
8148
8149 2019-04-04  Tom Tromey  <tom@tromey.com>
8150
8151         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8152         * stap-probe.c (stap_parse_argument): Update.
8153         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8154         initial_size parameter.
8155         * rust-exp.y (rust_lex_tests): Update.
8156         * parse.c (parser_state): Update.
8157         (parse_exp_in_context): Update.
8158         * parser-defs.h (struct parser_state) <parser_state>: Remove
8159         "initial_size" parameter.
8160
8161 2019-04-04  Tom Tromey  <tom@tromey.com>
8162
8163         * parser-defs.h (increase_expout_size): Don't declare.
8164         * parse.c (increase_expout_size): Now static.
8165
8166 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8167
8168         * gnu-nat.c (gnu_nat_target::wait): Fix
8169         target_waitstatus_to_string call.
8170
8171 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8172
8173         * eval.c (evaluate_subexp_standard): Handle internal functions
8174         during Fortran function call handling.
8175
8176 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8177
8178         * NEWS: Mention new internal functions.
8179         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8180         (read_base_type): Use dwarf2_init_complex_target_type.
8181         * value.c (creal_internal_fn): New function.
8182         (cimag_internal_fn): New function.
8183         (_initialize_values): Register new internal functions.
8184
8185 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8186
8187         * infrun.c (stop_all_threads): If debug_infrun, always
8188         trace the wait status after wait_one, using
8189         target_waitstatus_to_string and target_pid_to_str.
8190         (handle_inferior_event): Replace various trace of
8191         wait status kind by a single trace.
8192         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8193         wait status kind image by target_waitstatus_to_string.
8194         * target/waitstatus.c (target_waitstatus_to_string): Fix
8195         obsolete comment.
8196
8197 2019-04-01  Tom Tromey  <tromey@adacore.com>
8198
8199         PR symtab/23331:
8200         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8201
8202 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8203             Pedro Alves  <palves@redhat.com>
8204
8205         * top.c (quit_force): Call 'finalize_values'.
8206         * value.c (finalize_values): New function.
8207         * value.h (finalize_values): Declare.
8208
8209 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8210
8211         * NEWS: Announce $_gdb_major and $_gdb_minor.
8212
8213         * top.c (init_gdb_version_vars): New function.
8214         (gdb_init): Call init_gdb_version_vars.
8215
8216 2019-03-29  Tom Tromey  <tromey@adacore.com>
8217
8218         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8219         help text.  Remove dead code.
8220
8221 2019-03-29  Keith Seitz  <keiths@redhat.com>
8222
8223         From Siddhesh Poyarekar:
8224         * f-lang.h (f77_get_upperbound): Return LONGEST.
8225         (f77_get_lowerbound): Likewise.
8226         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8227         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8228         print them.
8229         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8230         plongest to format print it.
8231         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8232         (f77_get_upperbound): Likewise.
8233         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8234         LOWER_BOUND to LONGEST.
8235         (f77_create_arrayprint_offset_tbl): Likewise.
8236
8237 2019-03-29  Keith Seitz  <keiths@redhat.com>
8238
8239         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8240         %s/pulongest for TYPE_LENGTH instead of %d in format
8241         strings.
8242         * ada-typerint.c (ada_print_type): Likewise.
8243         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8244         * compile/compile-c-support.c (generate_register_struct): Likewise.
8245         * gdbtypes.c (recursive_dump_type): Likewise.
8246         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8247         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8248         instead of %d in format strings.
8249         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8250         to std::min to ULONGEST.
8251         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8252         instead of %d in format strings.
8253         * tracepoint.c (info_scope_command): Likewise.
8254         * typeprint.c (print_offset_data::update)
8255         (print_offset_data::finish): Likewise.
8256         * xtensa-tdep.c (xtensa_store_return_value)
8257         (xtensa_push_dummy_call): Likewise.
8258
8259 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8260
8261         * windows-nat.c (display_selector): Fixed format specifications
8262         for 64-bit Cygwin.
8263
8264 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8265
8266         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8267
8268 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8269
8270         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8271         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8272         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8273         (nios2_linux_init_abi): Install it.
8274
8275 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8276
8277         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8278
8279 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8280
8281         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8282
8283 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8284             Tom Tromey  <tromey@adacore.com>
8285
8286         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8287
8288 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8289
8290         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8291         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8292         method to compute the bounds of range types. Also print "[evaluated]"
8293         if the bounds' values come from a dynamic evaluation.
8294
8295 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8296
8297         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8298         whitespace when pretty printing is on.
8299
8300 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8301
8302         * ppc-linux-nat.c: Add include.
8303
8304 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8305
8306         * NEWS: Mention AArch64 Pointer Authentication.
8307
8308 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8309
8310         * arm-linux-nat.c: Add include.
8311
8312 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8313
8314         * source-cache.c (source_cache::get_source_lines): Re-read
8315         fullname after calling open_source_file.
8316
8317 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8318
8319         * NEWS: Mention TLS support for FreeBSD.
8320
8321 2019-03-25  Tom Tromey  <tromey@adacore.com>
8322
8323         * minsyms.c (BUNCH_SIZE): Update comment.
8324         (~minimal_symbol_reader): Remove old comment.
8325         (compact_minimal_symbols): Update comment.
8326         (minimal_symbol_reader::install): Remove old comment.  Update
8327         other comments.
8328
8329 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8330
8331         * s390-linux-nat.c: Add include.
8332
8333 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8334
8335         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8336         Call linux_get_hwcap.
8337         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8338         Likewise.
8339         (aarch64_linux_get_hwcap): Remove function.
8340         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8341         declaration.
8342         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8343         linux_get_hwcap.
8344         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8345         * linux-tdep.c (linux_get_hwcap): Add function.
8346         (linux_get_hwcap2): Likewise.
8347         * linux-tdep.h (linux_get_hwcap): Add declaration.
8348         (linux_get_hwcap2): Likewise.
8349         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8350         (ppc_linux_get_hwcap2): Likewise.
8351         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8352         linux_get_hwcap.
8353         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8354         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8355         (ppc_linux_nat_target::read_description): Likewise.
8356         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8357         * s390-linux-nat.c: Likewise.
8358         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8359
8360 2019-03-24  Tom Tromey  <tom@tromey.com>
8361
8362         * ada-lang.c (standard_lookup): Simplify initialization.
8363         (ada_lookup_symbol_nonlocal): Simplify return.
8364         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8365         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8366         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8367         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8368         initialization.
8369         * solib.c (solib_global_lookup): Simplify.
8370         * symtab.c (null_block_symbol): Remove.
8371         (symbol_cache_lookup): Simplify returns.
8372         (lookup_language_this): Simplify returns.
8373         (lookup_symbol_aux): Simplify return.
8374         (lookup_local_symbol): Simplify returns.
8375         (lookup_global_symbol_from_objfile): Simplify return.
8376         (lookup_symbol_in_objfile_symtabs)
8377         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8378         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8379         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8380         * cp-namespace.c (cp_lookup_bare_symbol)
8381         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8382         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8383         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8384         (cp_lookup_symbol_via_imports): Simplify initialization.
8385         (find_symbol_in_baseclass): Likewise.
8386         * symtab.h (null_block_symbol): Remove.
8387         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8388         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8389         (d_lookup_symbol_module): Likewise.
8390         (find_symbol_in_baseclass): Simplify initialization.
8391
8392 2019-03-24  Tom Tromey  <tom@tromey.com>
8393
8394         * expression.h: Don't include symtab.h.
8395         (struct block): Forward declare.
8396
8397 2019-03-24  Tom Tromey  <tom@tromey.com>
8398
8399         * c-exp.y (typebase): Remove casts.
8400         * gdbtypes.c (lookup_unsigned_typename, )
8401         (lookup_signed_typename): Remove cast.
8402         * eval.c (parse_to_comma_and_eval): Remove cast.
8403         * parse.c (write_dollar_variable): Remove cast.
8404         * block.h (struct block) <superblock>: Now const.
8405         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8406         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8407         (map_block): Make "block" const.
8408         * symfile.h (struct quick_symbol_functions)
8409         <map_matching_symbols>: Constify block argument to "callback".
8410         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8411         const.
8412         (find_pc_sect_compunit_symtab): Make "b" const.
8413         (find_symbol_at_address): Likewise.
8414         (search_symbols): Likewise.
8415         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8416         (dw2_debug_names_lookup_symbol): Likewise.
8417         (dw2_map_matching_symbols): Update.
8418         * p-valprint.c (pascal_val_print): Remove "block".
8419         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8420         (aux_add_nonlocal_symbols): Make "block" const.
8421         (resolve_subexp): Remove cast.
8422         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8423         const.
8424         (iterate_over_file_blocks): Likewise.
8425         * f-exp.y (%union) <bval>: Remove.
8426         * coffread.c (patch_opaque_types): Make "b" const.
8427         * spu-tdep.c (spu_catch_start): Make "block" const.
8428         * c-valprint.c (print_unpacked_pointer): Remove "block".
8429         * symmisc.c (dump_symtab_1): Make "b" const.
8430         (block_depth): Make "block" const.
8431         * d-exp.y (%union) <bval>: Remove.
8432         * cp-support.h (cp_lookup_rtti_type): Update.
8433         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8434         * psymtab.c (psym_lookup_symbol): Make "block" const.
8435         (maintenance_check_psymtabs): Make "b" const.
8436         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8437         (enumerate_locals, enumerate_args): Update.
8438         * python/py-symtab.c (stpy_global_block): Make "block" const.
8439         (stpy_static_block): Likewise.
8440         * inline-frame.c (block_starting_point_at): Make "new_block"
8441         const.
8442         * block.c (find_block_in_blockvector): Make return type const.
8443         (blockvector_for_pc_sect): Make "b" const.
8444         (find_block_in_blockvector): Make "b" const.
8445
8446 2019-03-23  Tom Tromey  <tom@tromey.com>
8447
8448         * varobj.c (varobj_create): Update.
8449         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8450         * printcmd.c (display_command, do_one_display): Don't reset
8451         innermost_block.
8452         * parser-defs.h (enum innermost_block_tracker_type): Move to
8453         expression.h.
8454         (innermost_block): Update comment.
8455         * parse.c (parse_exp_1): Add tracker_types parameter.
8456         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8457         tracker_types parameter.  Reset innermost_block.
8458         (parse_exp_in_context): Remove.
8459         (parse_expression_for_completion): Update.
8460         * objfiles.c (~objfile): Don't reset expression_context_block or
8461         innermost_block.
8462         * expression.h (enum innermost_block_tracker_type): Move from
8463         parser-defs.h.
8464         (parse_exp_1): Add tracker_types parameter.
8465         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8466         reset innermost_block.
8467
8468 2019-03-23  Tom Tromey  <tom@tromey.com>
8469
8470         * objfiles.h: Include bcache.h.
8471
8472 2019-03-23  Tom Tromey  <tom@tromey.com>
8473
8474         * linespec.c (get_current_search_block): Use
8475         scoped_restore_current_language.
8476         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8477
8478 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8479             Jiong Wang  <jiong.wang@arm.com>
8480
8481         * aarch64-linux-tdep.c
8482         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8483         section.
8484         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8485
8486 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8487             Jiong Wang  <jiong.wang@arm.com>
8488
8489         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8490         instructions.
8491         (aarch64_analyze_prologue_test): Add PACIASP test.
8492         (aarch64_prologue_prev_register): Unmask PC value.
8493
8494 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8495             Jiong Wang  <jiong.wang@arm.com>
8496
8497         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8498         (aarch64_dwarf2_prev_register): Unmask PC value.
8499         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8500         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8501         DW_CFA_AARCH64_negate_ra_state.
8502         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8503
8504 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8505             Jiong Wang  <jiong.wang@arm.com>
8506
8507         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8508         registers.
8509         (aarch64_pseudo_register_name): Likewise.
8510         (aarch64_pseudo_register_type): Likewise.
8511         (aarch64_pseudo_register_reggroup_p): Likewise.
8512         (aarch64_gdbarch_init): Add pauth registers.
8513         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8514         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8515         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8516         (struct gdbarch_tdep): Add regnum for ra_state.
8517
8518 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8519             Jiong Wang  <jiong.wang@arm.com>
8520
8521         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8522
8523 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8524             Jiong Wang  <jiong.wang@arm.com>
8525
8526         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8527         function.
8528         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8529         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8530         (aarch64_gdbarch_init): Add puth registers.
8531         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8532         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8533         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8534
8535 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8536             Jiong Wang  <jiong.wang@arm.com>
8537
8538         * aarch64-linux-nat.c
8539         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8540         * aarch64-linux-tdep.c
8541         (aarch64_linux_core_read_description): Likewise.
8542         (aarch64_linux_get_hwcap): New function.
8543         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8544         (aarch64_linux_get_hwcap): New declaration.
8545
8546 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8547             Jiong Wang  <jiong.wang@arm.com>
8548
8549         * aarch64-linux-nat.c
8550         (aarch64_linux_nat_target::read_description): Add pauth param.
8551         * aarch64-linux-tdep.c
8552         (aarch64_linux_core_read_description): Likewise.
8553         * aarch64-tdep.c (struct target_desc): Add in pauth.
8554         (aarch64_read_description): Add pauth param.
8555         (aarch64_gdbarch_init): Likewise.
8556         * aarch64-tdep.h (aarch64_read_description): Likewise.
8557         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8558         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8559         * features/Makefile: Add new files.
8560         * features/aarch64-pauth.c: New file.
8561         * features/aarch64-pauth.xml: New file.
8562
8563 2019-03-20  Tom Tromey  <tromey@adacore.com>
8564
8565         * infrun.c (handle_inferior_event): Rename from
8566         handle_inferior_event_1.  Create a scoped_value_mark.
8567         (handle_inferior_event): Remove.
8568
8569 2019-03-19  Tom Tromey  <tromey@adacore.com>
8570
8571         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8572         * infrun.h (print_stop_event): Add "displays" parameter.
8573         * infrun.c (print_stop_event): Add "displays" parameter.
8574
8575 2019-03-19  Pedro Alves  <palves@redhat.com>
8576
8577         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8578         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8579         to -1.  Fix TABs vs spaces.
8580         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8581         * tui/tui-out.h (tui_ui_out) Add intro comments.
8582         <m_line, m_start_of_line>: In-class initialize, and add describing
8583         comment.
8584
8585 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8586
8587         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8588         variable names.
8589         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8590
8591 2019-03-18  Pedro Alves  <palves@redhat.com>
8592             Eli Zaretskii <eliz@gnu.org>
8593
8594         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8595         m_line and m_start_of_line.
8596
8597 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8598
8599         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8600         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8601         it returns a newline.  This fixes a regression in TU mode, whereby
8602         the next line is output on the same screen line as the user input.
8603
8604 2019-03-18  Tom Tromey  <tromey@adacore.com>
8605
8606         * minsyms.c (minimal_symbol_reader::install): Remove call to
8607         obstack_blank.
8608
8609 2019-03-18  Pedro Alves  <palves@redhat.com>
8610
8611         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8612         New globals.
8613         (apply_style): New, factored out from ...
8614         (apply_ansi_escape): ... this.  Handle reverse video mode.
8615         (tui_set_reverse_mode): New function.
8616         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8617         * tui/tui-winsource.c (tui_show_source_line): Use
8618         tui_set_reverse_mode instead of setting A_STANDOUT.
8619         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8620         New setter methods.
8621
8622 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8623
8624         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8625         Handle tabs.
8626
8627 2019-03-18  Tom Tromey  <tromey@adacore.com>
8628
8629         * ada-lang.c (empty_array): Add "high" parameter.
8630         (ada_evaluate_subexp): Update.
8631
8632 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8633
8634         * unittests/string_view-selftests.c: Define
8635         _initialize_string_view_selftests unconditionally.
8636
8637 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8638
8639         PR gdb/24350
8640         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8641
8642 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8643
8644         PR gdb/24351
8645         * windows-nat.c (display_selector): Fix format specifiers.
8646
8647 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8648
8649         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8650         tui_refill_source_window instead of tui_refresh_win, to update the
8651         current execution line.  This fixes redisplay of the current line
8652         when stepping through the code with "next" or "step".
8653
8654 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8655
8656         * source-cache.c (source_cache::get_source_lines): Call
8657         find_source_lines to initialize s->nlines.  This fixes vertical
8658         scrolling of TUI source window when the DOWN arrow is pressed.
8659
8660 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8661
8662         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8663         linux-thread-db.c (_initialize_thread_db): Likewise.
8664
8665 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8666
8667         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8668         wclrtoeol in tui_show_source_line".  This reverts changes made in
8669         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8670
8671 2019-03-15  Tom Tromey  <tom@tromey.com>
8672
8673         * symtab.h (struct minimal_symbol): Derive from
8674         general_symbol_info.
8675         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8676         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8677         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8678         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8679         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8680         (MSYMBOL_SEARCH_NAME): Update.
8681         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8682         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8683         * minsyms.c (minimal_symbol_reader::record_full): Update.
8684
8685 2019-03-15  Tom Tromey  <tom@tromey.com>
8686
8687         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8688
8689 2019-03-15  Tom Tromey  <tom@tromey.com>
8690
8691         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8692         unique_xmalloc_ptr.
8693         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8694         Update.
8695         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8696         (build_minimal_symbol_hash_tables)
8697         (minimal_symbol_reader::install): Update.
8698
8699 2019-03-15  Tom Tromey  <tom@tromey.com>
8700
8701         * symtab.c (create_demangled_names_hash): Update.
8702         (symbol_set_names): Update.
8703         * objfiles.h (struct objfile_per_bfd_storage)
8704         <demangled_names_hash>: Now an htab_up.
8705         * objfiles.c (objfile_per_bfd_storage): Simplify.
8706
8707 2019-03-15  Tom Tromey  <tom@tromey.com>
8708
8709         * objfiles.h (struct objfile_per_bfd_storage): Declare
8710         destructor.
8711         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8712         New.
8713         (get_objfile_bfd_data): Use new.  Don't initialize
8714         language_of_main.
8715         (free_objfile_per_bfd_storage): Remove.
8716         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8717
8718 2019-03-15  Tom Tromey  <tom@tromey.com>
8719
8720         * symfile.c (reread_symbols): Update.
8721         * objfiles.c (objfile::objfile): Update.
8722         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8723         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8724         comment.
8725         (minimal_symbol_reader::install): Update.
8726         (terminate_minimal_symbol_table): Remove.
8727         * jit.c (jit_object_close_impl): Update.
8728
8729 2019-03-15  Tom Tromey  <tom@tromey.com>
8730
8731         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8732         initializations.
8733
8734 2019-03-15  Tom Tromey  <tom@tromey.com>
8735
8736         * objfiles.h (struct objfile_per_bfd_storage)
8737         <demangled_hash_languages>: Now a bitset.
8738         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8739         (lookup_minimal_symbol): Update.
8740
8741 2019-03-15  Tom Tromey  <tom@tromey.com>
8742
8743         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8744         Don't return the symbol.
8745         * coffread.c (record_minimal_symbol): Use record_full.
8746
8747 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8748
8749         The MS-Windows port of ncurses fails to switch to a color pair if
8750         one or both of the colors are the implicit default colors.  This
8751         change records the default colors when TUI is initialized, and
8752         then specifies them explicitly when a color pair uses the default
8753         colors.  This allows color styling in TUI mode on MS-Windows.
8754
8755         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8756         ncurses_norm_attr.
8757         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8758         colors in ncurses_norm_attr.
8759         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8760         "none", replace it with the default color recorded in
8761         ncurses_norm_attr.
8762
8763 2019-03-14  Tom Tromey  <tromey@adacore.com>
8764
8765         * source-cache.h (class source_cache) <get_source_lines>: Return
8766         std::string.
8767         * source-cache.c (source_cache::extract_lines): Handle case where
8768         first_pos==npos.  Return std::string.
8769         (source_cache::get_source_lines): Update.
8770
8771 2019-03-14  Tom Tromey  <tromey@adacore.com>
8772
8773         * NEWS: Add item for "style sources" commands.
8774         * source-cache.c (source_cache::get_source_lines): Check
8775         source_styling.
8776         * cli/cli-style.c (source_styling): New global.
8777         (_initialize_cli_style): Add "style sources" commands.
8778         (show_style_sources): New function.
8779         * cli/cli-style.h (source_styling): Declare.
8780
8781 2019-03-14  Pedro Alves  <palves@redhat.com>
8782             Tom Tromey  <tromey@adacore.com>
8783
8784         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8785         * tui/tui-winsource.c (tui_refill_source_window): New function,
8786         from...
8787         (tui_horizontal_source_scroll): ... here.  Move some logic.
8788         * cli/cli-style.c (set_style_enabled): Notify new observable.
8789         * tui/tui-hooks.c (tui_redisplay_source): New function.
8790         (tui_attach_detach_observers): Attach or detach
8791         tui_redisplay_source.
8792         * observable.h (source_styling_changed): New observable.
8793         * observable.c: Define source_styling_changed observable.
8794
8795 2019-03-13  Tom Tromey  <tromey@adacore.com>
8796
8797         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8798         (i386_gnu_nat_target::store_registers): Update.
8799         * target-debug.h (target_debug_print_std_string): New macro.
8800         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8801         * windows-tdep.c (display_one_tib): Update.
8802         * tui/tui-stack.c (tui_make_status_line): Update.
8803         * top.c (print_inferior_quit_action): Update.
8804         * thread.c (thr_try_catch_cmd): Update.
8805         (add_thread_with_info): Update.
8806         (thread_target_id_str): Update.
8807         (thr_try_catch_cmd): Update.
8808         (thread_command): Update.
8809         (thread_find_command): Update.
8810         * record-btrace.c (record_btrace_target::info_record)
8811         (record_btrace_resume_thread, record_btrace_target::resume)
8812         (record_btrace_cancel_resume, record_btrace_step_thread)
8813         (record_btrace_target::wait, record_btrace_target::wait)
8814         (record_btrace_target::wait, record_btrace_target::stop): Update.
8815         * progspace.c (print_program_space): Update.
8816         * process-stratum-target.c
8817         (process_stratum_target::thread_address_space): Update.
8818         * linux-fork.c (linux_fork_mourn_inferior)
8819         (detach_checkpoint_command, info_checkpoints_command)
8820         (linux_fork_context): Update.
8821         (linux_fork_detach): Update.
8822         (class scoped_switch_fork_info): Update.
8823         (delete_checkpoint_command): Update.
8824         * infrun.c (follow_fork_inferior): Update.
8825         (follow_fork_inferior): Update.
8826         (proceed_after_vfork_done): Update.
8827         (handle_vfork_child_exec_or_exit): Update.
8828         (follow_exec): Update.
8829         (displaced_step_prepare_throw): Update.
8830         (displaced_step_restore): Update.
8831         (start_step_over): Update.
8832         (resume_1): Update.
8833         (clear_proceed_status_thread): Update.
8834         (proceed): Update.
8835         (print_target_wait_results): Update.
8836         (do_target_wait): Update.
8837         (context_switch): Update.
8838         (stop_all_threads): Update.
8839         (restart_threads): Update.
8840         (finish_step_over): Update.
8841         (handle_signal_stop): Update.
8842         (switch_back_to_stepped_thread): Update.
8843         (keep_going_pass_signal): Update.
8844         (print_exited_reason): Update.
8845         (normal_stop): Update.
8846         * inferior.c (inferior_pid_to_str): Change return type.
8847         (print_selected_inferior): Update.
8848         (add_inferior): Update.
8849         (detach_inferior): Update.
8850         * dummy-frame.c (fprint_dummy_frames): Update.
8851         * dcache.c (dcache_info_1): Update.
8852         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8853         (btrace_fetch, btrace_clear): Update.
8854         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8855         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8856         type.
8857         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8858         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8859         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8860         * gdbarch.c, gdbarch.h: Rebuild.
8861         * gdbarch.sh (core_pid_to_str): Change return type.
8862         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8863         return type.
8864         (windows_nat_target::pid_to_str): Change return type.
8865         (windows_delete_thread): Update.
8866         (windows_nat_target::attach): Update.
8867         (windows_nat_target::files_info): Update.
8868         * target-delegates.c: Rebuild.
8869         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8870         return type.
8871         (sol_thread_target::pid_to_str): Change return type.
8872         * remote.c (class remote_target) <pid_to_str>: Change return
8873         type.
8874         (remote_target::pid_to_str): Change return type.
8875         (extended_remote_target::attach, remote_target::remote_stop_ns)
8876         (remote_target::remote_notif_remove_queued_reply)
8877         (remote_target::push_stop_reply, remote_target::disable_btrace):
8878         Update.
8879         (extended_remote_target::attach): Update.
8880         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8881         type.
8882         (gdbsim_target::pid_to_str): Change return type.
8883         * ravenscar-thread.c (struct ravenscar_thread_target)
8884         <pid_to_str>: Change return type.
8885         (ravenscar_thread_target::pid_to_str): Change return type.
8886         * procfs.c (class procfs_target) <pid_to_str>: Change return
8887         type.
8888         (procfs_target::pid_to_str): Change return type.
8889         (procfs_target::attach): Update.
8890         (procfs_target::detach): Update.
8891         (procfs_target::fetch_registers): Update.
8892         (procfs_target::store_registers): Update.
8893         (procfs_target::wait): Update.
8894         (procfs_target::files_info): Update.
8895         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8896         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8897         return type.
8898         (nto_procfs_target::pid_to_str): Change return type.
8899         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8900         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8901         return type.
8902         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8903         (exit_lwp): Update.
8904         (attach_proc_task_lwp_callback, get_detach_signal)
8905         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8906         (linux_nat_target::resume, wait_lwp, stop_callback)
8907         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8908         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8909         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8910         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8911         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8912         type.
8913         (inf_ptrace_target::attach): Update.
8914         (inf_ptrace_target::files_info): Update.
8915         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8916         type.
8917         (go32_nat_target::pid_to_str): Change return type.
8918         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8919         (gnu_nat_target::wait): Update.
8920         (gnu_nat_target::wait): Update.
8921         (gnu_nat_target::resume): Update.
8922         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8923         (fbsd_nat_target::wait): Update.
8924         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8925         type.
8926         (darwin_nat_target::attach): Update.
8927         * corelow.c (class core_target) <pid_to_str>: Change return type.
8928         (core_target::pid_to_str): Change return type.
8929         * target.c (normal_pid_to_str): Change return type.
8930         (default_pid_to_str): Likewise.
8931         (target_pid_to_str): Change return type.
8932         (target_translate_tls_address): Update.
8933         (target_announce_detach): Update.
8934         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8935         return type.
8936         (bsd_uthread_target::pid_to_str): Change return type.
8937         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8938         type.
8939         (bsd_kvm_target::pid_to_str): Change return type.
8940         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8941         return type.
8942         (aix_thread_target::pid_to_str): Change return type.
8943         * target.h (struct target_ops) <pid_to_str>: Change return type.
8944         (target_pid_to_str, normal_pid_to_str): Likewise.
8945         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8946         type.
8947         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8948         type.
8949         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8950         return type.
8951         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8952         type.
8953         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8954         type.
8955         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8956         return type.
8957
8958 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8959
8960         * NEWS: Mention that the new default MI version is 3.  Mention
8961         changes to the output of commands and events that deal with
8962         multi-location breakpoints.
8963         * breakpoint.c: Include "mi/mi-out.h".
8964         (print_one_breakpoint): Change output syntax if using MI version
8965         >= 3.
8966         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8967         New.
8968         (mi_multi_location_breakpoint_output_fixed): New.
8969         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8970         (mi_cmd_fix_multi_location_breakpoint_output): New.
8971         (mi_multi_location_breakpoint_output_fixed): New.
8972         * mi/mi-cmds.c (mi_cmds): Register command
8973         -fix-multi-location-breakpoint-output.
8974         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8975         interpreter "mi".
8976
8977 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8978
8979         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8980         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8981         instantiate mi_ui_out based on interpreter name.
8982         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8983         * mi/mi-main.c (mi_load_progress): Likewise.
8984
8985 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8986
8987         * NEWS: Combine separate "New targets" sections for 8.3.
8988
8989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8990
8991         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8992         (ppcfbsd_init_abi): Install gdbarch
8993         "fetch_tls_load_module_address" and "get_thread_local_address"
8994         methods.
8995
8996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8997
8998         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8999         (riscv_fbsd_init_abi): Install gdbarch
9000         "fetch_tls_load_module_address" and "get_thread_local_address"
9001         methods.
9002
9003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9004
9005         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9006         (i386fbsd_init_abi): Install gdbarch
9007         "fetch_tls_load_module_address" and "get_thread_local_address"
9008         methods.
9009
9010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9011
9012         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9013         (amd64fbsd_init_abi): Install gdbarch
9014         "fetch_tls_load_module_address" and "get_thread_local_address"
9015         methods.
9016
9017 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9018
9019         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9020         (struct fbsd_pspace_data): New type.
9021         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9022         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9023         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9024         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9025         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9026
9027 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9028
9029         * gdbtypes.c (lookup_struct_elt): New function.
9030         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9031         * gdbtypes.h (struct struct_elt): New type.
9032         (lookup_struct_elt): New prototype.
9033
9034 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9035
9036         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9037         remove disabled code block.
9038
9039 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9040
9041         * gdbarch.sh (get_thread_local_address): New method.
9042         * gdbarch.h, gdbarch.c: Regenerate.
9043         * target.c (target_translate_tls_address): Use
9044         gdbarch_get_thread_local_address if present instead of
9045         target::get_thread_local_address.
9046
9047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9048
9049         * target.h (target::get_thread_local_address): Update comment.
9050
9051 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9052
9053         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9054         objfile->separate_debug_objfile_backlink if not NULL.
9055
9056 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9057
9058         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9059         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9060         (amd64bsd_store_inferior_registers): Likewise.
9061         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9062         Enable segment base registers.
9063         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9064         PT_GETFSBASE and PT_GETGSBASE.
9065         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9066         PT_SETGSBASE.
9067         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9068         segment base registers.
9069         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9070
9071 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9072
9073         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9074         Update calls to i386_target_description to add 'segments'
9075         parameter.
9076         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9077         add segment base registers.
9078         * arch/i386.c (i386_create_target_description): Add 'segments'
9079         parameter to enable segment base registers.
9080         * arch/i386.h (i386_create_target_description): Likewise.
9081         * features/i386/32bit-segments.xml: New file.
9082         * features/i386/32bit-segments.c: Generate.
9083         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9084         call to i386_target_description to add 'segments' parameter.
9085         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9086         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9087         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9088         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9089         if feature is present.
9090         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9091         Add 'segments' parameter to call to i386_target_description.
9092         (i386_target_description): Add 'segments' parameter to enable
9093         segment base registers.
9094         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9095         to call to i386_target_description.
9096         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9097         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9098         Define I386_NUM_REGS.
9099         (i386_target_description): Add 'segments' parameter to enable
9100         segment base registers.
9101
9102 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9103
9104         PR/24325
9105         * source-cache.c: #undef open and close, to avoid unresolved
9106         externals during linking.
9107
9108 2019-03-12  Tom Tromey  <tromey@adacore.com>
9109
9110         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9111         const.  Add initializers.
9112         (_initialize_remote): Don't initialize ptid globals.
9113
9114 2019-03-12  Pedro Alves  <palves@redhat.com>
9115
9116         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9117
9118 2019-03-12  Pedro Alves  <palves@redhat.com>
9119
9120         * cp-name-parser.y (main): Remove unused 'len' variable.
9121
9122 2019-03-12  Tom Tromey  <tromey@adacore.com>
9123
9124         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9125         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9126
9127 2019-03-12  Tom Tromey  <tromey@adacore.com>
9128
9129         * linux-nat.c (iterate_over_lwps): Update.
9130         (stop_callback): Remove parameter.
9131         (stop_wait_callback, detach_callback, resume_set_callback)
9132         (select_singlestep_lwp_callback, set_ignore_sigint)
9133         (status_callback, resumed_callback, resume_clear_callback)
9134         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9135         data parameter.
9136         (linux_nat_target::detach, linux_nat_target::resume)
9137         (linux_stop_and_wait_all_lwps, select_event_lwp)
9138         (linux_nat_filter_event, linux_nat_wait_1)
9139         (linux_nat_target::kill, linux_nat_target::stop)
9140         (linux_nat_target::stop): Update.
9141         (linux_nat_resume_callback): Change type.
9142         (resume_stopped_resumed_lwps, count_events_callback)
9143         (select_event_lwp_callback): Likewise.
9144         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9145         * arm-linux-nat.c (struct update_registers_data): Remove.
9146         (update_registers_callback): Change type.
9147         (arm_linux_insert_hw_breakpoint1): Update.
9148         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9149         parameter.
9150         (x86_linux_dr_set_addr): Update.
9151         (x86_linux_dr_set_control): Update.
9152         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9153         (iterate_over_lwps): Use gdb::function_view.
9154         * nat/aarch64-linux-hw-point.c (struct
9155         aarch64_dr_update_callback_param): Remove.
9156         (debug_reg_change_callback): Change type.
9157         (aarch64_notify_debug_reg_change): Update.
9158         * s390-linux-nat.c (s390_refresh_per_info): Update.
9159
9160 2019-03-11  Tom Tromey  <tromey@adacore.com>
9161
9162         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9163         redundant assignment to "this_cu".
9164
9165 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9166
9167         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9168
9169 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9170
9171         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9172         from...
9173         (rank_one_type): ... this.
9174
9175 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9176
9177         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9178         from...
9179         (rank_one_type): ... this.
9180
9181 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9182
9183         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9184         from...
9185         (rank_one_type): ... this.
9186
9187 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9188
9189         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9190         from...
9191         (rank_one_type): ... this.
9192
9193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9194
9195         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9196         from...
9197         (rank_one_type): ... this.
9198
9199 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9200
9201         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9202         from...
9203         (rank_one_type): ... this.
9204
9205 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9206
9207         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9208         from...
9209         (rank_one_type): ... this.
9210
9211 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9212
9213         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9214         from...
9215         (rank_one_type): ... this.
9216
9217 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9218
9219         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9220         from...
9221         (rank_one_type): ... this.
9222
9223 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9224
9225         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9226         from...
9227         (rank_one_type): ... this.
9228
9229 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9230
9231         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9232         from...
9233         (rank_one_type): ... this.
9234
9235 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9236
9237         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9238         from...
9239         (rank_one_type): ... this.
9240
9241 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9242
9243         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9244         inferior-events' shows the example events.
9245
9246 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9247
9248         Support styling on native MS-Windows console
9249
9250         PR/24315
9251         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9252         on MS-Windows if $TERM is not defined.
9253
9254         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9255
9256         * posix-hdep.c (gdb_console_fputs):
9257         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9258         functions.
9259         * ui-file.h (gdb_console_fputs): Add prototype.
9260
9261         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9262         back to fputs only if the former returns zero.
9263
9264 2019-03-07  Tom Tromey  <tom@tromey.com>
9265
9266         * symmisc.c (print_symbol_bcache_statistics): Update.
9267         (print_objfile_statistics): Update.
9268         * symfile.c (allocate_symtab): Update.
9269         * stabsread.c: Don't include bcache.h.
9270         * psymtab.h (struct psymbol_bcache): Don't declare.
9271         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9272         (psymbol_bcache_init, psymbol_bcache_free)
9273         (psymbol_bcache_get_bcache): Don't declare.
9274         * psymtab.c (struct psymbol_bcache): Remove.
9275         (psymtab_storage::psymtab_storage): Update.
9276         (psymtab_storage::~psymtab_storage): Update.
9277         (psymbol_bcache_init, psymbol_bcache_free)
9278         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9279         (add_psymbol_to_bcache): Update.
9280         (allocate_psymtab): Update.
9281         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9282         macro_cache>: No longer pointers.
9283         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9284         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9285         * macrotab.c (macro_bcache): Update.
9286         * macroexp.c: Don't include bcache.h.
9287         * gdbtypes.c (check_types_worklist): Update.
9288         (types_deeply_equal): Remove TRY/CATCH.  Update.
9289         * elfread.c (elf_symtab_read): Update.
9290         * dwarf2read.c: Don't include bcache.h.
9291         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9292         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9293         (print_bcache_statistics, bcache_memory_used): Don't declare.
9294         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9295         methods.  Rename all data members.
9296         * bcache.c (struct bcache): Move to bcache.h.
9297         (bcache::expand_hash_table): Rename from expand_hash_table.
9298         (bcache): Remove.
9299         (bcache::insert): Rename from bcache_full.
9300         (bcache::compare): Rename from bcache_compare.
9301         (bcache_xmalloc): Remove.
9302         (bcache::~bcache): Rename from bcache_xfree.
9303         (bcache::print_statistics): Rename from print_bcache_statistics.
9304         (bcache::memory_used): Rename from bcache_memory_used.
9305
9306 2019-03-07  Pedro Alves  <palves@redhat.com>
9307
9308         * infrun.c (normal_stop): Also check for
9309         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9310
9311 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9312
9313         * f-lang.c (value_from_host_double): Moved to...
9314         * value.c (value_from_host_double): ...here.
9315         * value.h (value_from_host_double): Declare.
9316         * guile/scm-math.c (vlscm_convert_typed_number): Use
9317         value_from_host_double.
9318         (vlscm_convert_number): Likewise.
9319         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9320         * python/py-value.c (convert_value_from_python): Likewise.
9321
9322 2019-03-06  Tom Tromey  <tom@tromey.com>
9323
9324         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9325
9326 2019-03-06  Tom Tromey  <tom@tromey.com>
9327
9328         * utils.h (free_current_contents): Don't declare.
9329         * utils.c (free_current_contents): Remove.
9330
9331 2019-03-06  Tom Tromey  <tom@tromey.com>
9332
9333         * top.c (quit_force): Update.
9334         * main.c (captured_command_loop): Update.
9335         * common/new-op.c (operator new): Update.
9336         * common/common-exceptions.c (struct catcher)
9337         <save_cleanup_chain>: Remove member.
9338         (exceptions_state_mc_init): Update.
9339         (exception_try_scope_entry): Return nullptr.
9340         (exception_try_scope_exit, exception_rethrow)
9341         (throw_exception_sjlj, throw_exception_cxx): Update.
9342         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9343         (all_cleanups, do_cleanups, discard_cleanups)
9344         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9345         (restore_cleanups, restore_final_cleanups): Don't declare.
9346         (do_final_cleanups): Remove parameter.
9347         * common/cleanups.c (cleanup_chain, make_cleanup)
9348         (make_cleanup_dtor, all_cleanups, do_cleanups)
9349         (discard_my_cleanups, discard_cleanups)
9350         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9351         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9352         (null_cleanup): Remove.
9353         (do_final_cleanups): Remove parameter.
9354
9355 2019-03-06  Tom Tromey  <tom@tromey.com>
9356
9357         * remote.c (remote_target::remote_parse_stop_reply): Use
9358         unique_xmalloc_ptr.
9359
9360 2019-03-06  Tom Tromey  <tom@tromey.com>
9361
9362         * stabsread.c (struct stabs_field_info): Rename from field_info.
9363         <list, fnlist>: Add initializers.
9364         <obstack>: New member.
9365         (read_member_functions, read_struct_fields, read_baseclasses):
9366         Allocate on obstack.  Don't use cleanups.
9367         (read_one_struct_field, read_member_functions, read_struct_fields)
9368         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9369         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9370         (read_struct_type): Update.
9371
9372 2019-03-06  Tom Tromey  <tom@tromey.com>
9373
9374         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9375         * common/filestuff.h (make_cleanup_close): Don't declare.
9376         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9377         Remove.
9378
9379 2019-03-06  Tom Tromey  <tom@tromey.com>
9380
9381         * solib-aix.c: Use make_scope_exit.
9382
9383 2019-03-06  Tom Tromey  <tom@tromey.com>
9384
9385         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9386         Use make_scope_exit.
9387
9388 2019-03-06  Tom Tromey  <tom@tromey.com>
9389
9390         * solib-svr4.c (disable_probes_interface): Remove parameter.
9391         (svr4_handle_solib_event): Use make_scope_exit.
9392
9393 2019-03-06  Tom Tromey  <tom@tromey.com>
9394
9395         * remote.c (struct stop_reply_deleter): Remove.
9396         (stop_reply_up): Update.
9397         (struct stop_reply): Derive from notif_event.  Don't typedef.
9398         <regcache>: Now a std::vector.
9399         (stop_reply_xfree): Remove.
9400         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9401         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9402         (remote_target::discard_pending_stop_replies): Use delete.
9403         (remote_target::remote_parse_stop_reply): Update.
9404         (remote_target::process_stop_reply): Update.
9405         * remote-notif.h (struct notif_event): Add virtual destructor.
9406         Remove "dtr" member.
9407         (struct notif_client) <alloc_event>: Return a unique_ptr.
9408         (notif_event_xfree): Don't declare.
9409         (notif_event_up): New typedef.
9410         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9411         (notif_event_xfree, do_notif_event_xfree): Remove.
9412         (remote_notif_state_xfree): Update.
9413
9414 2019-03-06  Tom Tromey  <tom@tromey.com>
9415
9416         * infrun.c (displaced_step_clear_cleanup): Now a
9417         forward_scope_exit type.
9418         (displaced_step_prepare_throw): Update.
9419         (displaced_step_fixup): Update.
9420
9421 2019-03-06  Tom Tromey  <tom@tromey.com>
9422
9423         * inferior.h (class inferior): Update comment.
9424         * gdbthread.h (class thread_info): Update comment.
9425
9426 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9427             Tom Tromey  <tom@tromey.com>
9428
9429         * stabsread.h (struct stab_section_list): Remove.
9430         (coffstab_build_psymtabs): Update.
9431         * dbxread.c (symbuf_sections): Now a std::vector.
9432         (sect_idx): New global.
9433         (fill_symbuf): Update.
9434         (coffstab_build_psymtabs): Change type of stabsects parameter.
9435         Update.
9436         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9437         std::vector.
9438         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9439         (coff_locate_sections): Update.
9440         (coff_symfile_read): Remove cleanups.  Update.
9441         (init_stringtab): Add storage parameter.
9442         (free_stringtab, free_stringtab_cleanup): Remove.
9443         (init_lineno): Add storage parameter.
9444         (free_linetab, free_linetab_cleanup): Remove.
9445
9446 2019-03-06  Pedro Alves  <palves@redhat.com>
9447
9448         * linux-fork.c (fork_info::clobber_regs): Delete.
9449         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9450         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9451         comment.  Adjust.
9452         (scoped_switch_fork_info::scoped_switch_fork_info)
9453         (checkpoint_command, linux_fork_context): Adjust
9454         fork_save_infrun_state calls.
9455
9456 2019-03-06  Pedro Alves  <palves@redhat.com>
9457
9458         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9459         (inf_has_multiple_threads): Return 'bool' and rewrite using
9460         inferior_info::threads().
9461
9462 2019-03-06  Pedro Alves  <palves@redhat.com>
9463
9464         * linux-fork.c: Include <list>.
9465         (fork_list): Now a std::list instance.
9466         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9467         (forks_exist_p, find_last_fork): Adjust.
9468         (new_fork): Delete.
9469         (one_fork_p): New.
9470         (add_fork): Adjust.
9471         (free_fork): Delete, folded into fork_info::~fork_info().
9472         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9473         Adjust.
9474         (init_fork_list): Delete.
9475         (linux_fork_killall, linux_fork_mourn_inferior)
9476         (linux_fork_detach, info_checkpoints_command): Adjust.
9477         (_initialize_linux_fork): No longer call init_fork_list.
9478
9479 2019-03-06  Pedro Alves  <palves@redhat.com>
9480
9481         * linux-fork.c (new_fork): New, split out of ...
9482         (add_fork): ... this.  Return void.  Move "first fork" special
9483         case from here, to ...
9484         (checkpoint_command): ... here.
9485         * linux-linux.h (add_fork): Return void.
9486
9487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9488
9489         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9490
9491 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9492             Chris January  <chris.january@arm.com>
9493             David Lecomber  <david.lecomber@arm.com>
9494
9495         * f-exp.y: New token, UNOP_INTRINSIC.
9496         (exp): New pattern using UNOP_INTRINSIC token.
9497         (f77_keywords): Add 'abs' keyword.
9498         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9499         (value_from_host_double): New function.
9500         (evaluate_subexp_f): Support UNOP_ABS.
9501
9502 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9503
9504         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9505         types.
9506
9507 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9508
9509         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9510         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9511         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9512
9513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9514
9515         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9516
9517 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9518             Chris January  <chris.january@arm.com>
9519
9520         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9521         * f-exp.y: Define 'KIND' token.
9522         (exp): New pattern for KIND expressions.
9523         (ptype): Handle types with a kind extension.
9524         (direct_abs_decl): Extend to spot kind extensions.
9525         (f77_keywords): Add 'kind' to the list.
9526         (push_kind_type): New function.
9527         (convert_to_kind_type): New function.
9528         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9529         * parse.c (operator_length_standard): Likewise.
9530         * parser-defs.h (enum type_pieces): Add tp_kind.
9531         * std-operator.def: Add UNOP_KIND.
9532
9533 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9534
9535         * f-exp.y (f_parse): Set yydebug.
9536
9537 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9538
9539         * f-lang.c (evaluate_subexp_f): New function.
9540         (exp_descriptor_f): New global.
9541         (f_language_defn): Use exp_descriptor_f instead of
9542         exp_descriptor_standard.
9543
9544 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9545
9546         * f-exp.y (struct token): Add comments.
9547         (dot_ops): Remove uppercase versions and the end marker.
9548         (f77_keywords): Likewise.
9549         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9550         entries in the dot_ops array are case insensitive, and use
9551         strncasecmp to compare strings.  Also some whitespace cleanup in
9552         this area.  Similar for the f77_keywords array, except entries in
9553         this list might be case sensitive.
9554
9555 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9556
9557         * f-exp.y (struct f77_boolean_val): Add comments.
9558         (boolean_values): Remove uppercase versions, and end marker.
9559         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9560         and use strncasecmp to achieve case insensitivity.  Additionally,
9561         perform whitespace cleanup around this code.
9562
9563 2019-03-06  Tom Tromey  <tromey@adacore.com>
9564
9565         * remote-sim.c (gdbsim_target_open): Use result of
9566         gdb_argv::release.
9567
9568 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9569         Dirk Schubert  <dirk.schubert@arm.com>
9570         Chris January  <chris.january@arm.com>
9571
9572         * eval.c (evaluate_subexp_standard): Call Fortran argument
9573         wrapping logic.
9574         * f-lang.c (struct value): A value which can be passed into a
9575         Fortran function call.
9576         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9577         where appropriate.
9578         (struct type): Value ready for a Fortran function call.
9579         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9580         is needed.
9581         * f-lang.h (fortran_argument_convert): Declaration.
9582         (fortran_preserve_arg_pointer): Declaration.
9583         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9584
9585 2019-03-05  Tom Tromey  <tromey@adacore.com>
9586
9587         * python/py-prettyprint.c (print_string_repr): Remove #if.
9588         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9589
9590 2019-03-05  Tom Tromey  <tromey@adacore.com>
9591
9592         * target.c (the_dummy_target): Move later.  Change type to
9593         "dummy_target".
9594         (initialize_targets): Don't initialize the_dummy_target.
9595
9596 2019-03-05  Tom Tromey  <tromey@adacore.com>
9597
9598         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9599         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9600
9601 2019-03-05  Tom Tromey  <tromey@adacore.com>
9602
9603         * windows-nat.c (windows_nat_target::attach)
9604         (windows_nat_target::detach): Don't call gdb_flush.
9605         * valprint.c (generic_val_print, val_print, val_print_string):
9606         Don't call gdb_flush.
9607         * utils.c (defaulted_query): Don't call gdb_flush.
9608         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9609         * target.c (target_announce_detach): Don't call gdb_flush.
9610         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9611         * remote.c (extended_remote_target::attach): Don't call
9612         gdb_flush.
9613         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9614         * printcmd.c (do_examine): Don't call gdb_flush.
9615         (info_display_command): Don't call gdb_flush.
9616         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9617         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9618         * memattr.c (info_mem_command): Don't call gdb_flush.
9619         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9620         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9621         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9622         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9623         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9624         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9625         (gnu_nat_target::detach): Don't call gdb_flush.
9626         * f-valprint.c (f_val_print): Don't call gdb_flush.
9627         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9628         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9629         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9630         gdb_flush.
9631         * c-valprint.c (c_val_print): Don't call gdb_flush.
9632         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9633
9634 2019-03-05  Tom Tromey  <tromey@adacore.com>
9635
9636         * varobj.c (update_dynamic_varobj_children): Update.
9637         (install_default_visualizer): Use reset, not release.
9638         * value.c (set_internalvar): Update.
9639         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9640         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9641         ATTRIBUTE_UNUSED_RESULT.
9642
9643 2019-03-05  Tom Tromey  <tromey@adacore.com>
9644
9645         * remote.c (class scoped_remote_fd) <release>: Add
9646         ATTRIBUTE_UNUSED_RESULT.
9647
9648 2019-03-05  Tom Tromey  <tromey@adacore.com>
9649
9650         * macroexp.c (struct macro_buffer) <release>: Add
9651         ATTRIBUTE_UNUSED_RESULT.
9652
9653 2019-03-05  Tom Tromey  <tromey@adacore.com>
9654
9655         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9656         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9657         ATTRIBUTE_UNUSED_RESULT.
9658
9659 2019-03-05  Tom Tromey  <tromey@adacore.com>
9660
9661         * common/scoped_fd.h (class scoped_fd) <release>: Add
9662         ATTRIBUTE_UNUSED_RESULT.
9663
9664 2019-03-05  Tom Tromey  <tromey@adacore.com>
9665
9666         * parser-defs.h (struct parser_state) <release>: Add
9667         ATTRIBUTE_UNUSED_RESULT.
9668
9669 2019-03-05  Tom Tromey  <tromey@adacore.com>
9670
9671         * utils.h (class gdb_argv) <release>: Add
9672         ATTRIBUTE_UNUSED_RESULT.
9673         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9674
9675 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9676
9677         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9678         for-loop range, to avoid compiler warnings.
9679
9680         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9681         avoid compiler warnings about unused variables.
9682
9683         * NEWS: Mention end of support for native debugging on MS-Windows
9684         before XP.
9685
9686         PR gdb/24292
9687         * common/netstuff.c:
9688         * gdbserver/gdbreplay.c
9689         * gdbserver/remote-utils.c:
9690         * ser-tcp.c:
9691         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9692         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9693         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9694         'getaddrinfo' and 'freeaddrinfo' were not available before
9695         Windows XP, and mingw.org's MinGW headers by default define
9696         _WIN32_WINNT to 0x500.
9697
9698 2019-03-01  Gary Benson <gbenson@redhat.com>
9699
9700         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9701
9702 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9703             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9704
9705         PR gdb/8527
9706         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9707         set_sigint_trap, clear_sigint_trap.
9708
9709 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9710
9711         * target.c (target_detach): Clear the regcache and the
9712         frame cache.
9713
9714 2019-02-27  Pedro Alves  <palves@redhat.com>
9715
9716         * utils.c (set_screen_size): When we cap the height/width sizes,
9717         tweak the corresponding command variable to show "unlimited":
9718
9719 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9720             Pedro Alves  <palves@redhat.com>
9721
9722         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9723         before calling rl_set_screen_size.
9724
9725 2019-02-27  Tom Tromey  <tromey@adacore.com>
9726
9727         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9728         define.
9729         * python/py-value.c: Remove Python 2.4 workaround.
9730         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9731         workaround.
9732         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9733         Python 2.4 workaround.
9734         * python/python-internal.h: Remove Python 2.4 comment.
9735         (Py_ssize_t): Don't define.
9736         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9737         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9738         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9739         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9740         * python/python.c (do_start_initialization): Remove Python 2.4
9741         workaround.
9742         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9743         (print_children): Remove Python 2.4 workaround.
9744         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9745         workaround.
9746         (CHARBUFFERPROC_NAME): Remove.
9747         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9748         Python 2.4 workaround.
9749
9750 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9751
9752         * NEWS: Note minimum Python version.
9753
9754 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9755
9756         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9757         code from these functions.  Remove corresponding ifdefs.  Use
9758         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9759         Remove gotos and target of gotos.
9760         (infpy_search_memory): Likewise.
9761
9762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9763
9764         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9765         (hppa_gdbarch_init): Don't register deleted functions with
9766         gdbarch.
9767
9768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9769
9770         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9771         (h8300_unwind_sp): Delete.
9772         (h8300_dummy_id): Delete.
9773         (h8300_gdbarch_init): Don't register deleted functions with
9774         gdbarch.
9775
9776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9777
9778         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9779         (ft32_unwind_pc): Delete.
9780         (ft32_unwind_sp): Delete.
9781         (ft32_gdbarch_init): Don't register deleted functions with
9782         gdbarch.
9783
9784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9785
9786         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9787         (frv_unwind_pc): Delete.
9788         (frv_unwind_sp): Delete.
9789         (frv_gdbarch_init): Don't register deleted functions with
9790         gdbarch.
9791
9792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9793
9794         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9795         (riscv_unwind_pc): Delete.
9796         (riscv_unwind_sp): Delete.
9797         (riscv_gdbarch_init): Don't register deleted functions with
9798         gdbarch.
9799
9800 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9801
9802         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9803         (csky_unwind_pc): Delete.
9804         (csky_unwind_sp): Delete.
9805         (csky_gdbarch_init): Don't register deleted functions with
9806         gdbarch.
9807
9808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9809
9810         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9811         (cris_unwind_pc): Delete.
9812         (cris_unwind_sp): Delete.
9813         (cris_gdbarch_init): Don't register deleted functions with
9814         gdbarch.
9815
9816 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9817
9818         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9819         (bfin_unwind_pc): Delete.
9820         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9821
9822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9823
9824         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9825         (arm_unwind_pc): Delete.
9826         (arm_unwind_sp): Delete.
9827         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9828
9829 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9830
9831         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9832         (arc_unwind_pc): Delete.
9833         (arc_unwind_sp): Delete.
9834         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9835
9836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9837
9838         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9839         (alpha_unwind_pc): Delete.
9840         (alpha_gdbarch_init): Don't register deleted functions with
9841         gdbarch.
9842
9843 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9844
9845         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9846         (aarch64_unwind_pc): Delete.
9847         (aarch64_unwind_sp): Delete.
9848         (aarch64_gdbarch_init): Don't register deleted functions with
9849         gdbarch.
9850
9851 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9852
9853         * gdbtypes.c (type_align): Don't consider static members when
9854         computing structure alignment.
9855
9856 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9857
9858         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9859         return 0 for other types.
9860         * arch-utils.c (default_type_align): Always return 0.
9861         * gdbarch.h: Regenerate.
9862         * gdbarch.sh (type_align): Extend comment.
9863         * gdbtypes.c (type_align): Add additional comments, always call
9864         gdbarch_type_align before applying the default rules.
9865         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9866         generic code will then apply a suitable default.
9867         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9868         types, return 0 for other types.
9869
9870 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9871
9872         * NEWS: Create a new section for the next release branch.
9873         Rename the section of the current branch, now that it has
9874         been cut.
9875
9876 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9877
9878         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9879         * version.in: Bump version to 8.3.50.DATE-git.
9880
9881 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9882
9883         * aix-thread.c (ptid_cmp): Remove unused variable.
9884         (get_signaled_thread): Likewise.
9885         (store_regs_user_thread): Likewise.
9886         (store_regs_kernel_thread): Likewise.
9887         (fetch_regs_kernel_thread): Remove shadowed variable.
9888
9889 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9890
9891         * features/riscv/32bit-cpu.xml: Add register numbers.
9892         * features/riscv/32bit-fpu.c: Regenerate.
9893         * features/riscv/32bit-fpu.xml: Add register numbers.
9894         * features/riscv/64bit-cpu.xml: Add register numbers.
9895         * features/riscv/64bit-fpu.c: Regenerate.
9896         * features/riscv/64bit-fpu.xml: Add register numbers.
9897
9898 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9899
9900         * NEWS: Mention two argument form of gdb.Value constructor.
9901         * python/py-value.c (convert_buffer_and_type_to_value): New
9902         function.
9903         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9904         Add support for handling an optional second argument.  Call
9905         convert_buffer_and_type_to_value as appropriate.
9906         * python/python-internal.h (Py_buffer_deleter): New struct.
9907         (Py_buffer_up): New typedef.
9908
9909 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9910
9911         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9912         instead of releasing ownership.
9913
9914 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9915
9916         * dwarf2read.c (open_and_init_dwp_file): Call
9917         elf_numsections instead of bfd_count_sections to initialize
9918         dwp_file->num_sections.
9919
9920 2019-02-25  Tom Tromey  <tromey@adacore.com>
9921
9922         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9923
9924 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9925
9926         * gcore.in: Add '--readnever' option when invoking GDB.
9927
9928 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9929
9930         * MAINTAINERS: Update my email address.
9931
9932 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9933
9934         * build-id.c (build_id_to_debug_bfd_1): New function.
9935         (build_id_to_debug_bfd): Look for separate debug file in
9936         sysroot.
9937
9938 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9939
9940         * gdbarch.sh: Update the copyright year range that is placed into
9941         generated files.
9942
9943 2019-02-22  Keith Seitz  <keiths@redhat.com>
9944
9945         PR symtab/23853
9946         * linespec.c (create_sals_line_offset): Search for the default
9947         symtab's filename instead of its fullname.
9948
9949 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9950
9951         * NEWS: Update style defaults.
9952
9953 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9954
9955         * main.c (captured_main_1): Disable styling in batch mode.
9956
9957 2019-02-20  Tom Tromey  <tom@tromey.com>
9958
9959         * symtab.c (symtab_symbol_info): Fix typos.
9960
9961 2019-02-20  Tom Tromey  <tromey@adacore.com>
9962
9963         * findcmd.c (_initialize_mem_search): Use upper case for
9964         metasyntactic variables.
9965
9966 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9967
9968         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9969         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9970
9971 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9972
9973         * top.h (source_file_name): Change to std::string.
9974         * top.c (source_file_name): Likewise.
9975         (command_line_input): Adjust.
9976         * cli/cli-script.c (script_from_file): Adjust.
9977
9978 2019-02-19  Tom Tromey  <tromey@adacore.com>
9979
9980         * ravenscar-thread.c
9981         (ravenscar_thread_target::update_thread_list): Don't call
9982         ada_build_task_list.
9983         * ada-lang.h (ada_build_task_list): Don't declare.
9984         * ada-tasks.c (struct ada_tasks_inferior_data)
9985         <task_list_valid_p>: Now bool.
9986         (read_known_tasks, ada_task_list_changed)
9987         (ada_tasks_invalidate_inferior_data): Update.
9988         (read_known_tasks_array): Return bool.
9989         (read_known_tasks_list): Likewise.
9990         (read_known_tasks): Return void.
9991         (ada_build_task_list): Now static.
9992
9993 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9994
9995         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9996         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9997
9998 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9999
10000         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10001         variant for ada_tasks_pspace_data_handle and
10002         ada_tasks_inferior_data_handle.
10003         (ada_tasks_pspace_data_cleanup): New function.
10004         (ada_tasks_inferior_data_cleanup): New function.
10005
10006 2019-02-17  Tom Tromey  <tom@tromey.com>
10007
10008         * macrotab.h (macro_source_fullname): Return a std::string.
10009         * macrotab.c (macro_include, check_for_redefinition)
10010         (macro_undef, macro_lookup_definition, foreach_macro)
10011         (foreach_macro_in_scope): Update.
10012         (macro_source_fullname): Return a std::string.
10013         * macrocmd.c (show_pp_source_pos): Update.
10014
10015 2019-02-17  Tom Tromey  <tom@tromey.com>
10016
10017         * macrocmd.c (show_pp_source_pos): Style the file names.
10018
10019 2019-02-17  Tom Tromey  <tom@tromey.com>
10020
10021         PR tui/24197:
10022         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10023
10024 2019-02-17  Tom Tromey  <tom@tromey.com>
10025
10026         * ada-lang.c (user_select_syms): Use filtered printing.
10027         * utils.c (wrap_style): New global.
10028         (desired_style): Remove.
10029         (emit_style_escape): Add stream parameter.
10030         (set_output_style, reset_terminal_style, prompt_for_continue):
10031         Update.
10032         (flush_wrap_buffer): Only flush gdb_stdout.
10033         (wrap_here): Set wrap_style.
10034         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10035         treat escape sequences as a character.  Change when wrap buffer is
10036         flushed.
10037         (fputs_styled): Do not set the output style when the default is
10038         requested.
10039         * ui-style.h (struct ui_file_style) <is_default>: New method.
10040         * source.c (print_source_lines_base): Emit escape sequences in one
10041         piece.
10042
10043 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10044
10045         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10046         integers and enumeration types.
10047
10048 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10049
10050         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10051         instead of lookup_symbol_in_language
10052         (do_exact_match): New function.
10053         (ada_get_symbol_name_matcher): Return do_exact_match when
10054         doing a verbatim match.
10055
10056 2019-02-15  Tom Tromey  <tromey@adacore.com>
10057
10058         * ravenscar-thread.c (ravenscar_thread_target::resume)
10059         (ravenscar_thread_target::wait): Special case wildcard requests.
10060
10061 2019-02-15  Tom Tromey  <tromey@adacore.com>
10062
10063         * ravenscar-thread.c (base_ptid): Remove.
10064         (struct ravenscar_thread_target) <close>: New method.
10065         <m_base_ptid>: New member.
10066         <update_inferior_ptid, active_task, task_is_currently_active,
10067         runtime_initialized>: Declare methods.
10068         <ravenscar_thread_target>: Add constructor.
10069         (ravenscar_thread_target::task_is_currently_active)
10070         (ravenscar_thread_target::update_inferior_ptid)
10071         (ravenscar_runtime_initialized): Rename.  Now methods.
10072         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10073         (ravenscar_thread_target::update_thread_list): Update.
10074         (ravenscar_thread_target::active_task): Now method.
10075         (ravenscar_thread_target::store_registers)
10076         (ravenscar_thread_target::prepare_to_store)
10077         (ravenscar_thread_target::prepare_to_store)
10078         (ravenscar_thread_target::mourn_inferior): Update.
10079         (ravenscar_inferior_created): Use "new" to create target.
10080         (ravenscar_thread_target::get_ada_task_ptid): Update.
10081         (_initialize_ravenscar): Don't initialize base_ptid.
10082         (ravenscar_ops): Remove global.
10083
10084 2019-02-15  Tom Tromey  <tromey@adacore.com>
10085
10086         * target.h (push_target): Declare new overload.
10087         * target.c (push_target): New overload, taking an rvalue reference.
10088         * remote.c (remote_target::open_1): Use push_target overload.
10089         * corelow.c (core_target_open): Use push_target overload.
10090
10091 2019-02-15  Tom Tromey  <tromey@adacore.com>
10092
10093         * ravenscar-thread.c (is_ravenscar_task)
10094         (ravenscar_task_is_currently_active): Return bool.
10095         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10096         (_initialize_ravenscar): Remove "(void)".
10097         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10098         Return bool.
10099
10100 2019-02-15  Tom Tromey  <tromey@adacore.com>
10101
10102         * ravenscar-thread.c (ravenscar_runtime_initializer)
10103         (has_ravenscar_runtime, get_running_thread_id)
10104         (ravenscar_thread_target::resume): Fix indentation.
10105
10106 2019-02-15  Tom Tromey  <tromey@adacore.com>
10107
10108         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10109         from ravenscar_arch_ops.
10110         (sparc_ravenscar_ops::fetch_registers)
10111         (sparc_ravenscar_ops::store_registers): Now methods.
10112         (sparc_ravenscar_prepare_to_store): Remove.
10113         (sparc_ravenscar_ops): Redefine.
10114         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10115         methods and destructor.  Remove members.
10116         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10117         (ravenscar_thread_target::store_registers)
10118         (ravenscar_thread_target::prepare_to_store): Update.
10119         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10120         Remove.
10121         (struct ppc_ravenscar_powerpc_ops): Derive from
10122         ravenscar_arch_ops.
10123         (ppc_ravenscar_powerpc_ops::fetch_registers)
10124         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10125         (ppc_ravenscar_powerpc_ops): Redefine.
10126         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10127         (ppc_ravenscar_e500_ops::fetch_registers)
10128         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10129         (ppc_ravenscar_e500_ops): Redefine.
10130         * aarch64-ravenscar-thread.c
10131         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10132         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10133         (aarch64_ravenscar_fetch_registers)
10134         (aarch64_ravenscar_store_registers): Now methods.
10135         (aarch64_ravenscar_ops): Redefine.
10136
10137 2019-02-15  Tom Tromey  <tromey@adacore.com>
10138
10139         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10140         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10141         (ravenscar_thread_target::stopped_by_watchpoint)
10142         (ravenscar_thread_target::stopped_data_address)
10143         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10144
10145 2019-02-15  Tom Tromey  <tromey@adacore.com>
10146
10147         * ravenscar-thread.c: Fix some typos.
10148
10149 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10150             Tom Tromey  <tromey@adacore.com>
10151
10152         * ada-lang.c (ada_exception_sal): Change addr_string to a
10153         std::string.
10154         (create_ada_exception_catchpoint): Update.
10155
10156 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10157             Tom Tromey  <tromey@adacore.com>
10158
10159         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10160         (bp_location_ops): Remove.
10161         (base_breakpoint_allocate_location): Update.
10162         (free_bp_location): Update.
10163         * ada-lang.c (class ada_catchpoint_location)
10164         <ada_catchpoint_location>: Remove ops parameter.
10165         (ada_catchpoint_location_dtor): Remove.
10166         (ada_catchpoint_location_ops): Remove.
10167         (allocate_location_exception): Update.
10168         * breakpoint.h (struct bp_location_ops): Remove.
10169         (class bp_location) <bp_location>: Remove bp_location_ops
10170         parameter.
10171         <~bp_location>: Add destructor.
10172         <ops>: Remove.
10173
10174 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10175             Pedro Alves  <palves@redhat.com>
10176
10177         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10178         'PATH_MAX'.
10179
10180 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10181             Samuel Thibault  <samuel.thibault@gnu.org>
10182             Thomas Schwinge  <thomas@codesourcery.com>
10183
10184         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10185         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10186
10187 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10188
10189         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10190         (check_empty): Use "const char *".
10191
10192         * gnu-nat.c (gnu_nat_target::detach): Instead of
10193         'detach_inferior (pid)' call
10194         'detach_inferior (find_inferior_pid (pid))'.
10195
10196         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10197         'nat/fork-inferior.o'.
10198         * gnu-nat.c: #include "nat/fork-inferior.h".
10199
10200         * gnu-nat.c (gnu_nat_target::detach): Instead of
10201         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10202         * gnu-nat.h: #include "inf-child.h".
10203         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10204         'i386_gnu_nat_target::fetch_registers'.
10205         (gnu_store_registers): Rename/move to
10206         'i386_gnu_nat_target::store_registers'.
10207
10208         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10209         * gnu-nat.h (mach_thread_info): New function.
10210         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10211
10212         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10213
10214 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10215
10216         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10217
10218 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10219
10220         * windows-nat.c (windows_add_thread): Add new parameter
10221         "main_thread_p" with default value set to false.  Update
10222         function documentation as well as all callers.
10223         (windows_delete_thread): Likewise.
10224         (fake_create_process): Update call to windows_add_thread.
10225         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10226         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10227         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10228         call to windows_delete_thread.
10229
10230 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10231
10232         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10233
10234 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10235
10236         * symfile.c (find_separate_debug_file): Use canonical path of
10237         sysroot with child_path instead of gdb_sysroot if it is valid.
10238
10239 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10240
10241         * symfile.c (find_separate_debug_file): Use child_path to
10242         determine if an object file is under a sysroot.
10243
10244 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10245
10246         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10247         unittests/child-path-selftests.c.
10248         * common/pathstuff.c (child_path): New function.
10249         * common/pathstuff.h (child_path): New prototype.
10250         * unittests/child-path-selftests.c: New file.
10251
10252 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10253
10254         * symfile.c (find_separate_debug_file): Look for separate debug
10255         files in debug directories under the sysroot.
10256
10257 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10258
10259         * symtab.h (struct minimal_symbol data_p): New const method.
10260         (struct minimal_symbol text_p): Likewise.
10261         * symtab.c (output_source_filename): Use file name style
10262         to print file name.
10263         (print_symbol_info): Likewise.
10264         (print_msymbol_info): Use address style to print addresses.
10265         Use function name style to print executable text symbols.
10266         (expand_symtab_containing_pc): Use data_p.
10267         (find_pc_sect_compunit_symtab): Likewise.
10268
10269 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10270
10271         * breakpoint.c (describe_other_breakpoints): Use address style
10272         to print addresses.
10273         (say_where): Likewise.
10274
10275 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10276
10277         * ada-typeprint.c (print_func_type): Print function name
10278         style to print function name.
10279         * c-typeprint.c (c_print_type_1): Likewise.
10280
10281 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10282
10283         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10284         for execve.
10285
10286 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10287
10288         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10289         type_stack.
10290
10291 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10292
10293         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10294         TYPE_CODE_REF types.
10295
10296 2019-02-08  Jim Wilson  <jimw@sifive.com>
10297
10298         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10299         (riscv_linux_fregset): New.
10300         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10301
10302 2019-02-07  Tom Tromey  <tom@tromey.com>
10303
10304         * thread.c (thread_cancel_execution_command): Update.
10305         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10306         methods.
10307         (struct thread_fsm_ops): Remove.
10308         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10309         (thread_fsm_should_stop, thread_fsm_return_value)
10310         (thread_fsm_set_finished, thread_fsm_finished_p)
10311         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10312         Don't declare.
10313         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10314         * infrun.c (clear_proceed_status_thread)
10315         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10316         (print_stop_event): Update.
10317         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10318         Add constructor.
10319         (step_command_fsm_ops): Remove.
10320         (new_step_command_fsm): Remove.
10321         (step_1): Update.
10322         (step_command_fsm::should_stop): Rename from
10323         step_command_fsm_should_stop.
10324         (step_command_fsm::clean_up): Rename from
10325         step_command_fsm_clean_up.
10326         (step_command_fsm::do_async_reply_reason): Rename from
10327         step_command_fsm_async_reply_reason.
10328         (struct until_next_fsm): Inherit from thread_fsm.  Add
10329         constructor.
10330         (until_next_fsm_ops): Remove.
10331         (new_until_next_fsm): Remove.
10332         (until_next_fsm::should_stop): Rename from
10333         until_next_fsm_should_stop.
10334         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10335         (until_next_fsm::do_async_reply_reason): Rename from
10336         until_next_fsm_async_reply_reason.
10337         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10338         constructor.  Change type of breakpoint.
10339         (finish_command_fsm_ops): Remove.
10340         (new_finish_command_fsm): Remove.
10341         (finish_command_fsm::should_stop): Rename from
10342         finish_command_fsm_should_stop.
10343         (finish_command_fsm::clean_up): Rename from
10344         finish_command_fsm_clean_up.
10345         (finish_command_fsm::return_value): Rename from
10346         finish_command_fsm_return_value.
10347         (finish_command_fsm::do_async_reply_reason): Rename from
10348         finish_command_fsm_async_reply_reason.
10349         (finish_command): Update.
10350         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10351         Add constructor.
10352         (call_thread_fsm_ops): Remove.
10353         (call_thread_fsm::call_thread_fsm): Rename from
10354         new_call_thread_fsm.
10355         (call_thread_fsm::should_stop): Rename from
10356         call_thread_fsm_should_stop.
10357         (call_thread_fsm::should_notify_stop): Rename from
10358         call_thread_fsm_should_notify_stop.
10359         (run_inferior_call, call_function_by_hand_dummy): Update.
10360         * cli/cli-interp.c (should_print_stop_to_console): Update.
10361         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10362         Add constructor.  Change type of location_breakpoint,
10363         caller_breakpoint.
10364         (until_break_fsm_ops): Remove.
10365         (new_until_break_fsm): Remove.
10366         (until_break_fsm::should_stop): Rename from
10367         until_break_fsm_should_stop.
10368         (until_break_fsm::clean_up): Rename from
10369         until_break_fsm_clean_up.
10370         (until_break_fsm::do_async_reply_reason): Rename from
10371         until_break_fsm_async_reply_reason.
10372         (until_break_command): Update.
10373         * thread-fsm.c: Remove.
10374         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10375
10376 2019-02-07  Tom Tromey  <tom@tromey.com>
10377
10378         * yy-remap.h: Add include guard.
10379         * xtensa-tdep.h: Add include guard.
10380         * xcoffread.h: Rename include guard.
10381         * varobj-iter.h: Add include guard.
10382         * tui/tui.h: Rename include guard.
10383         * tui/tui-winsource.h: Rename include guard.
10384         * tui/tui-wingeneral.h: Rename include guard.
10385         * tui/tui-windata.h: Rename include guard.
10386         * tui/tui-win.h: Rename include guard.
10387         * tui/tui-stack.h: Rename include guard.
10388         * tui/tui-source.h: Rename include guard.
10389         * tui/tui-regs.h: Rename include guard.
10390         * tui/tui-out.h: Rename include guard.
10391         * tui/tui-layout.h: Rename include guard.
10392         * tui/tui-io.h: Rename include guard.
10393         * tui/tui-hooks.h: Rename include guard.
10394         * tui/tui-file.h: Rename include guard.
10395         * tui/tui-disasm.h: Rename include guard.
10396         * tui/tui-data.h: Rename include guard.
10397         * tui/tui-command.h: Rename include guard.
10398         * tic6x-tdep.h: Add include guard.
10399         * target/waitstatus.h: Rename include guard.
10400         * target/wait.h: Rename include guard.
10401         * target/target.h: Rename include guard.
10402         * target/resume.h: Rename include guard.
10403         * target-float.h: Rename include guard.
10404         * stabsread.h: Add include guard.
10405         * rs6000-tdep.h: Add include guard.
10406         * riscv-fbsd-tdep.h: Add include guard.
10407         * regformats/regdef.h: Rename include guard.
10408         * record.h: Rename include guard.
10409         * python/python.h: Rename include guard.
10410         * python/python-internal.h: Rename include guard.
10411         * python/py-stopevent.h: Rename include guard.
10412         * python/py-ref.h: Rename include guard.
10413         * python/py-record.h: Rename include guard.
10414         * python/py-record-full.h: Rename include guard.
10415         * python/py-record-btrace.h: Rename include guard.
10416         * python/py-instruction.h: Rename include guard.
10417         * python/py-events.h: Rename include guard.
10418         * python/py-event.h: Rename include guard.
10419         * procfs.h: Add include guard.
10420         * proc-utils.h: Add include guard.
10421         * p-lang.h: Add include guard.
10422         * or1k-tdep.h: Rename include guard.
10423         * observable.h: Rename include guard.
10424         * nto-tdep.h: Rename include guard.
10425         * nat/x86-linux.h: Rename include guard.
10426         * nat/x86-linux-dregs.h: Rename include guard.
10427         * nat/x86-gcc-cpuid.h: Add include guard.
10428         * nat/x86-dregs.h: Rename include guard.
10429         * nat/x86-cpuid.h: Rename include guard.
10430         * nat/ppc-linux.h: Rename include guard.
10431         * nat/mips-linux-watch.h: Rename include guard.
10432         * nat/linux-waitpid.h: Rename include guard.
10433         * nat/linux-ptrace.h: Rename include guard.
10434         * nat/linux-procfs.h: Rename include guard.
10435         * nat/linux-osdata.h: Rename include guard.
10436         * nat/linux-nat.h: Rename include guard.
10437         * nat/linux-namespaces.h: Rename include guard.
10438         * nat/linux-btrace.h: Rename include guard.
10439         * nat/glibc_thread_db.h: Rename include guard.
10440         * nat/gdb_thread_db.h: Rename include guard.
10441         * nat/gdb_ptrace.h: Rename include guard.
10442         * nat/fork-inferior.h: Rename include guard.
10443         * nat/amd64-linux-siginfo.h: Rename include guard.
10444         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10445         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10446         * nat/aarch64-linux.h: Rename include guard.
10447         * nat/aarch64-linux-hw-point.h: Rename include guard.
10448         * mn10300-tdep.h: Add include guard.
10449         * mips-linux-tdep.h: Add include guard.
10450         * mi/mi-parse.h: Rename include guard.
10451         * mi/mi-out.h: Rename include guard.
10452         * mi/mi-main.h: Rename include guard.
10453         * mi/mi-interp.h: Rename include guard.
10454         * mi/mi-getopt.h: Rename include guard.
10455         * mi/mi-console.h: Rename include guard.
10456         * mi/mi-common.h: Rename include guard.
10457         * mi/mi-cmds.h: Rename include guard.
10458         * mi/mi-cmd-break.h: Rename include guard.
10459         * m2-lang.h: Add include guard.
10460         * location.h: Rename include guard.
10461         * linux-record.h: Rename include guard.
10462         * linux-nat.h: Add include guard.
10463         * linux-fork.h: Add include guard.
10464         * i386-darwin-tdep.h: Rename include guard.
10465         * hppa-linux-offsets.h: Add include guard.
10466         * guile/guile.h: Rename include guard.
10467         * guile/guile-internal.h: Rename include guard.
10468         * gnu-nat.h: Rename include guard.
10469         * gdb-stabs.h: Rename include guard.
10470         * frv-tdep.h: Add include guard.
10471         * f-lang.h: Add include guard.
10472         * event-loop.h: Add include guard.
10473         * darwin-nat.h: Rename include guard.
10474         * cp-abi.h: Rename include guard.
10475         * config/sparc/nm-sol2.h: Rename include guard.
10476         * config/nm-nto.h: Rename include guard.
10477         * config/nm-linux.h: Add include guard.
10478         * config/i386/nm-i386gnu.h: Rename include guard.
10479         * config/djgpp/nl_types.h: Rename include guard.
10480         * config/djgpp/langinfo.h: Rename include guard.
10481         * compile/gcc-cp-plugin.h: Add include guard.
10482         * compile/gcc-c-plugin.h: Add include guard.
10483         * compile/compile.h: Rename include guard.
10484         * compile/compile-object-run.h: Rename include guard.
10485         * compile/compile-object-load.h: Rename include guard.
10486         * compile/compile-internal.h: Rename include guard.
10487         * compile/compile-cplus.h: Rename include guard.
10488         * compile/compile-c.h: Rename include guard.
10489         * common/xml-utils.h: Rename include guard.
10490         * common/x86-xstate.h: Rename include guard.
10491         * common/version.h: Rename include guard.
10492         * common/vec.h: Rename include guard.
10493         * common/tdesc.h: Rename include guard.
10494         * common/selftest.h: Rename include guard.
10495         * common/scoped_restore.h: Rename include guard.
10496         * common/scoped_mmap.h: Rename include guard.
10497         * common/scoped_fd.h: Rename include guard.
10498         * common/safe-iterator.h: Rename include guard.
10499         * common/run-time-clock.h: Rename include guard.
10500         * common/refcounted-object.h: Rename include guard.
10501         * common/queue.h: Rename include guard.
10502         * common/ptid.h: Rename include guard.
10503         * common/print-utils.h: Rename include guard.
10504         * common/preprocessor.h: Rename include guard.
10505         * common/pathstuff.h: Rename include guard.
10506         * common/observable.h: Rename include guard.
10507         * common/netstuff.h: Rename include guard.
10508         * common/job-control.h: Rename include guard.
10509         * common/host-defs.h: Rename include guard.
10510         * common/gdb_wait.h: Rename include guard.
10511         * common/gdb_vecs.h: Rename include guard.
10512         * common/gdb_unlinker.h: Rename include guard.
10513         * common/gdb_unique_ptr.h: Rename include guard.
10514         * common/gdb_tilde_expand.h: Rename include guard.
10515         * common/gdb_sys_time.h: Rename include guard.
10516         * common/gdb_string_view.h: Rename include guard.
10517         * common/gdb_splay_tree.h: Rename include guard.
10518         * common/gdb_setjmp.h: Rename include guard.
10519         * common/gdb_ref_ptr.h: Rename include guard.
10520         * common/gdb_optional.h: Rename include guard.
10521         * common/gdb_locale.h: Rename include guard.
10522         * common/gdb_assert.h: Rename include guard.
10523         * common/filtered-iterator.h: Rename include guard.
10524         * common/filestuff.h: Rename include guard.
10525         * common/fileio.h: Rename include guard.
10526         * common/environ.h: Rename include guard.
10527         * common/common-utils.h: Rename include guard.
10528         * common/common-types.h: Rename include guard.
10529         * common/common-regcache.h: Rename include guard.
10530         * common/common-inferior.h: Rename include guard.
10531         * common/common-gdbthread.h: Rename include guard.
10532         * common/common-exceptions.h: Rename include guard.
10533         * common/common-defs.h: Rename include guard.
10534         * common/common-debug.h: Rename include guard.
10535         * common/cleanups.h: Rename include guard.
10536         * common/buffer.h: Rename include guard.
10537         * common/btrace-common.h: Rename include guard.
10538         * common/break-common.h: Rename include guard.
10539         * cli/cli-utils.h: Rename include guard.
10540         * cli/cli-style.h: Rename include guard.
10541         * cli/cli-setshow.h: Rename include guard.
10542         * cli/cli-script.h: Rename include guard.
10543         * cli/cli-interp.h: Rename include guard.
10544         * cli/cli-decode.h: Rename include guard.
10545         * cli/cli-cmds.h: Rename include guard.
10546         * charset-list.h: Add include guard.
10547         * buildsym-legacy.h: Rename include guard.
10548         * bfin-tdep.h: Add include guard.
10549         * ax.h: Rename include guard.
10550         * arm-linux-tdep.h: Add include guard.
10551         * arm-fbsd-tdep.h: Add include guard.
10552         * arch/xtensa.h: Rename include guard.
10553         * arch/tic6x.h: Add include guard.
10554         * arch/i386.h: Add include guard.
10555         * arch/arm.h: Rename include guard.
10556         * arch/arm-linux.h: Rename include guard.
10557         * arch/arm-get-next-pcs.h: Rename include guard.
10558         * arch/amd64.h: Add include guard.
10559         * arch/aarch64-insn.h: Rename include guard.
10560         * arch-utils.h: Rename include guard.
10561         * annotate.h: Add include guard.
10562         * amd64-darwin-tdep.h: Rename include guard.
10563         * aarch64-linux-tdep.h: Add include guard.
10564         * aarch64-fbsd-tdep.h: Add include guard.
10565         * aarch32-linux-nat.h: Add include guard.
10566
10567 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10568
10569         * macrotab.c (macro_define_internal): New function that
10570         factorizes macro_define_object_internal and macro_define_function
10571         code.
10572         (macro_define_object_internal): Use macro_define_internal.
10573         (macro_define_function): Likewise.
10574
10575 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10576
10577         * macrocmd.c (extract_identifier): Return
10578         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10579         callers.
10580
10581 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10582
10583         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10584
10585 2019-02-05  Tom Tromey  <tom@tromey.com>
10586
10587         * target.c (target_stack::unpush): Move assertion earlier.
10588
10589 2019-01-30  Tom Tromey  <tom@tromey.com>
10590
10591         PR python/23615:
10592         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10593         (gdbpy_parse_and_eval): Likewise.
10594         * python/python-internal.h (gdbpy_allow_threads): New class.
10595
10596 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10597
10598         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10599         (aarch64_fbsd_fpregmap): Move earlier.
10600         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10601         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10602         instead of individual calls to trad_frame_set_reg_addr.
10603         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10604         earlier.
10605         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10606         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10607         instead of individual calls to trad_frame_set_reg_addr.
10608
10609 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10610
10611         * CONTRIBUTE: Replace contribution list with wiki link.
10612
10613 2019-01-25  Tom Tromey  <tom@tromey.com>
10614
10615         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10616
10617 2019-01-25  Tom Tromey  <tom@tromey.com>
10618
10619         * xtensa-linux-nat.c: Fix common/ includes.
10620         * xml-support.h: Fix common/ includes.
10621         * xml-support.c: Fix common/ includes.
10622         * x86-linux-nat.c: Fix common/ includes.
10623         * windows-nat.c: Fix common/ includes.
10624         * varobj.h: Fix common/ includes.
10625         * varobj.c: Fix common/ includes.
10626         * value.c: Fix common/ includes.
10627         * valops.c: Fix common/ includes.
10628         * utils.c: Fix common/ includes.
10629         * unittests/xml-utils-selftests.c: Fix common/ includes.
10630         * unittests/utils-selftests.c: Fix common/ includes.
10631         * unittests/unpack-selftests.c: Fix common/ includes.
10632         * unittests/tracepoint-selftests.c: Fix common/ includes.
10633         * unittests/style-selftests.c: Fix common/ includes.
10634         * unittests/string_view-selftests.c: Fix common/ includes.
10635         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10636         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10637         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10638         * unittests/rsp-low-selftests.c: Fix common/ includes.
10639         * unittests/parse-connection-spec-selftests.c: Fix common/
10640         includes.
10641         * unittests/optional-selftests.c: Fix common/ includes.
10642         * unittests/offset-type-selftests.c: Fix common/ includes.
10643         * unittests/observable-selftests.c: Fix common/ includes.
10644         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10645         * unittests/memrange-selftests.c: Fix common/ includes.
10646         * unittests/memory-map-selftests.c: Fix common/ includes.
10647         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10648         * unittests/function-view-selftests.c: Fix common/ includes.
10649         * unittests/environ-selftests.c: Fix common/ includes.
10650         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10651         * unittests/common-utils-selftests.c: Fix common/ includes.
10652         * unittests/cli-utils-selftests.c: Fix common/ includes.
10653         * unittests/array-view-selftests.c: Fix common/ includes.
10654         * ui-file.c: Fix common/ includes.
10655         * tui/tui-io.c: Fix common/ includes.
10656         * tracepoint.h: Fix common/ includes.
10657         * tracepoint.c: Fix common/ includes.
10658         * tracefile-tfile.c: Fix common/ includes.
10659         * top.h: Fix common/ includes.
10660         * top.c: Fix common/ includes.
10661         * thread.c: Fix common/ includes.
10662         * target/waitstatus.h: Fix common/ includes.
10663         * target/waitstatus.c: Fix common/ includes.
10664         * target.h: Fix common/ includes.
10665         * target.c: Fix common/ includes.
10666         * target-memory.c: Fix common/ includes.
10667         * target-descriptions.c: Fix common/ includes.
10668         * symtab.h: Fix common/ includes.
10669         * symfile.c: Fix common/ includes.
10670         * stap-probe.c: Fix common/ includes.
10671         * spu-linux-nat.c: Fix common/ includes.
10672         * sparc-nat.c: Fix common/ includes.
10673         * source.c: Fix common/ includes.
10674         * solib.c: Fix common/ includes.
10675         * solib-target.c: Fix common/ includes.
10676         * ser-unix.c: Fix common/ includes.
10677         * ser-tcp.c: Fix common/ includes.
10678         * ser-pipe.c: Fix common/ includes.
10679         * ser-base.c: Fix common/ includes.
10680         * selftest-arch.c: Fix common/ includes.
10681         * s12z-tdep.c: Fix common/ includes.
10682         * rust-exp.y: Fix common/ includes.
10683         * rs6000-aix-tdep.c: Fix common/ includes.
10684         * riscv-tdep.c: Fix common/ includes.
10685         * remote.c: Fix common/ includes.
10686         * remote-notif.h: Fix common/ includes.
10687         * remote-fileio.h: Fix common/ includes.
10688         * remote-fileio.c: Fix common/ includes.
10689         * regcache.h: Fix common/ includes.
10690         * regcache.c: Fix common/ includes.
10691         * record-btrace.c: Fix common/ includes.
10692         * python/python.c: Fix common/ includes.
10693         * python/py-type.c: Fix common/ includes.
10694         * python/py-inferior.c: Fix common/ includes.
10695         * progspace.h: Fix common/ includes.
10696         * producer.c: Fix common/ includes.
10697         * procfs.c: Fix common/ includes.
10698         * proc-api.c: Fix common/ includes.
10699         * printcmd.c: Fix common/ includes.
10700         * ppc-linux-nat.c: Fix common/ includes.
10701         * parser-defs.h: Fix common/ includes.
10702         * osdata.c: Fix common/ includes.
10703         * obsd-nat.c: Fix common/ includes.
10704         * nat/x86-linux.c: Fix common/ includes.
10705         * nat/x86-linux-dregs.c: Fix common/ includes.
10706         * nat/x86-dregs.h: Fix common/ includes.
10707         * nat/x86-dregs.c: Fix common/ includes.
10708         * nat/ppc-linux.c: Fix common/ includes.
10709         * nat/mips-linux-watch.h: Fix common/ includes.
10710         * nat/mips-linux-watch.c: Fix common/ includes.
10711         * nat/linux-waitpid.c: Fix common/ includes.
10712         * nat/linux-ptrace.h: Fix common/ includes.
10713         * nat/linux-ptrace.c: Fix common/ includes.
10714         * nat/linux-procfs.c: Fix common/ includes.
10715         * nat/linux-personality.c: Fix common/ includes.
10716         * nat/linux-osdata.c: Fix common/ includes.
10717         * nat/linux-namespaces.c: Fix common/ includes.
10718         * nat/linux-btrace.h: Fix common/ includes.
10719         * nat/linux-btrace.c: Fix common/ includes.
10720         * nat/fork-inferior.c: Fix common/ includes.
10721         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10722         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10723         * nat/aarch64-linux.c: Fix common/ includes.
10724         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10725         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10726         * namespace.h: Fix common/ includes.
10727         * mips-linux-tdep.c: Fix common/ includes.
10728         * minsyms.c: Fix common/ includes.
10729         * mi/mi-parse.h: Fix common/ includes.
10730         * mi/mi-main.c: Fix common/ includes.
10731         * mi/mi-cmd-env.c: Fix common/ includes.
10732         * memrange.h: Fix common/ includes.
10733         * memattr.c: Fix common/ includes.
10734         * maint.h: Fix common/ includes.
10735         * maint.c: Fix common/ includes.
10736         * main.c: Fix common/ includes.
10737         * machoread.c: Fix common/ includes.
10738         * location.c: Fix common/ includes.
10739         * linux-thread-db.c: Fix common/ includes.
10740         * linux-nat.c: Fix common/ includes.
10741         * linux-fork.c: Fix common/ includes.
10742         * inline-frame.c: Fix common/ includes.
10743         * infrun.c: Fix common/ includes.
10744         * inflow.c: Fix common/ includes.
10745         * inferior.h: Fix common/ includes.
10746         * inferior.c: Fix common/ includes.
10747         * infcmd.c: Fix common/ includes.
10748         * inf-ptrace.c: Fix common/ includes.
10749         * inf-child.c: Fix common/ includes.
10750         * ia64-linux-nat.c: Fix common/ includes.
10751         * i387-tdep.c: Fix common/ includes.
10752         * i386-tdep.c: Fix common/ includes.
10753         * i386-linux-tdep.c: Fix common/ includes.
10754         * i386-linux-nat.c: Fix common/ includes.
10755         * i386-go32-tdep.c: Fix common/ includes.
10756         * i386-fbsd-tdep.c: Fix common/ includes.
10757         * i386-fbsd-nat.c: Fix common/ includes.
10758         * guile/scm-type.c: Fix common/ includes.
10759         * guile/guile.c: Fix common/ includes.
10760         * go32-nat.c: Fix common/ includes.
10761         * gnu-nat.c: Fix common/ includes.
10762         * gdbthread.h: Fix common/ includes.
10763         * gdbarch-selftests.c: Fix common/ includes.
10764         * gdb_usleep.c: Fix common/ includes.
10765         * gdb_select.h: Fix common/ includes.
10766         * gdb_bfd.c: Fix common/ includes.
10767         * gcore.c: Fix common/ includes.
10768         * fork-child.c: Fix common/ includes.
10769         * findvar.c: Fix common/ includes.
10770         * fbsd-nat.c: Fix common/ includes.
10771         * event-top.c: Fix common/ includes.
10772         * event-loop.c: Fix common/ includes.
10773         * dwarf2read.c: Fix common/ includes.
10774         * dwarf2loc.c: Fix common/ includes.
10775         * dwarf2-frame.c: Fix common/ includes.
10776         * dwarf-index-cache.c: Fix common/ includes.
10777         * dtrace-probe.c: Fix common/ includes.
10778         * disasm-selftests.c: Fix common/ includes.
10779         * defs.h: Fix common/ includes.
10780         * csky-tdep.c: Fix common/ includes.
10781         * cp-valprint.c: Fix common/ includes.
10782         * cp-support.h: Fix common/ includes.
10783         * cp-support.c: Fix common/ includes.
10784         * corelow.c: Fix common/ includes.
10785         * completer.h: Fix common/ includes.
10786         * completer.c: Fix common/ includes.
10787         * compile/compile.c: Fix common/ includes.
10788         * compile/compile-loc2c.c: Fix common/ includes.
10789         * compile/compile-cplus-types.c: Fix common/ includes.
10790         * compile/compile-cplus-symbols.c: Fix common/ includes.
10791         * command.h: Fix common/ includes.
10792         * cli/cli-dump.c: Fix common/ includes.
10793         * cli/cli-cmds.c: Fix common/ includes.
10794         * charset.c: Fix common/ includes.
10795         * build-id.c: Fix common/ includes.
10796         * btrace.h: Fix common/ includes.
10797         * btrace.c: Fix common/ includes.
10798         * breakpoint.h: Fix common/ includes.
10799         * breakpoint.c: Fix common/ includes.
10800         * ax.h:
10801         (enum agent_op): Fix common/ includes.
10802         * ax-general.c (struct aop_map): Fix common/ includes.
10803         * ax-gdb.c: Fix common/ includes.
10804         * auxv.c: Fix common/ includes.
10805         * auto-load.c: Fix common/ includes.
10806         * arm-tdep.c: Fix common/ includes.
10807         * arch/riscv.c: Fix common/ includes.
10808         * arch/ppc-linux-common.c: Fix common/ includes.
10809         * arch/i386.c: Fix common/ includes.
10810         * arch/arm.c: Fix common/ includes.
10811         * arch/arm-linux.c: Fix common/ includes.
10812         * arch/arm-get-next-pcs.c: Fix common/ includes.
10813         * arch/amd64.c: Fix common/ includes.
10814         * arch/aarch64.c: Fix common/ includes.
10815         * arch/aarch64-insn.c: Fix common/ includes.
10816         * arch-utils.c: Fix common/ includes.
10817         * amd64-windows-tdep.c: Fix common/ includes.
10818         * amd64-tdep.c: Fix common/ includes.
10819         * amd64-sol2-tdep.c: Fix common/ includes.
10820         * amd64-obsd-tdep.c: Fix common/ includes.
10821         * amd64-nbsd-tdep.c: Fix common/ includes.
10822         * amd64-linux-tdep.c: Fix common/ includes.
10823         * amd64-linux-nat.c: Fix common/ includes.
10824         * amd64-fbsd-tdep.c: Fix common/ includes.
10825         * amd64-fbsd-nat.c: Fix common/ includes.
10826         * amd64-dicos-tdep.c: Fix common/ includes.
10827         * amd64-darwin-tdep.c: Fix common/ includes.
10828         * agent.c: Fix common/ includes.
10829         * ada-lang.h: Fix common/ includes.
10830         * ada-lang.c: Fix common/ includes.
10831         * aarch64-tdep.c: Fix common/ includes.
10832
10833 2019-01-25  Tom Tromey  <tom@tromey.com>
10834
10835         * common/create-version.sh: Use common/version.h.
10836
10837 2019-01-24  Pedro Alves  <palves@redhat.com>
10838
10839         * infrun.c (signal_stop, signal_print, signal_program)
10840         (signal_catch, signal_pass): Now arrays instead of pointers.
10841         (update_signals_program_target, do_target_resume)
10842         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10843         * linux-nat.c (linux_nat_target::pass_signals)
10844         (linux_nat_target::create_inferior, linux_nat_target::attach):
10845         Adjust.
10846         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10847         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10848         * procfs.c (procfs_target::pass_signals): Adjust.
10849         * record-full.c (record_full_target::resume): Adjust.
10850         * remote.c (remote_target::pass_signals)
10851         (remote_target::program_signals): Adjust.
10852         * target-debug.h (target_debug_print_signals): Now takes a
10853         gdb::array_view as parameter.  Adjust.
10854         * target.h (target_ops) <pass_signals, program_signals>: Replace
10855         pointer and length parameters with gdb::array_view.
10856         (target_pass_signals, target_program_signals): Likewise.
10857         * target-delegates.c: Regenerate.
10858
10859 2019-01-24  Pedro Alves  <palves@redhat.com>
10860
10861         * common/forward-scope-exit.h
10862         (forward_scope_exit::forward_scope_exit): Pass arguments to
10863         m_bind_function directly, instead of creating a std::bind and
10864         copying that.
10865
10866 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10867
10868         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10869         for static members.
10870         (pass_in_v_vfp_candidate): Likewise.
10871
10872 2019-01-23  Tom Tromey  <tom@tromey.com>
10873             Pedro Alves  <palves@redhat.com>
10874
10875         * regcache.c (class regcache_invalidator): Remove.
10876         (regcache::raw_write): Use make_scope_exit.
10877
10878 2019-01-23  Tom Tromey  <tom@tromey.com>
10879
10880         * ui-out.h (class ui_out_emit_type): Update comment.
10881
10882 2019-01-23  Tom Tromey  <tom@tromey.com>
10883
10884         * infrun.c (fetch_inferior_event): Update comment.
10885
10886 2019-01-23  Tom Tromey  <tom@tromey.com>
10887             Pedro Alves  <palves@redhat.com>
10888
10889         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10890         parameter.
10891         (fetch_inferior_event): Use SCOPE_EXIT.
10892
10893
10894 2019-01-23  Tom Tromey  <tom@tromey.com>
10895             Pedro Alves  <palves@redhat.com>
10896
10897         * infrun.c (disable_thread_events): Delete.
10898         (stop_all_threads): Use SCOPE_EXIT.
10899
10900 2019-01-23  Tom Tromey  <tom@tromey.com>
10901             Pedro Alves  <palves@redhat.com>
10902
10903         * symfile.c: Include forward-scope-exit.h.
10904         (clear_symtab_users_cleanup): Replace forward declaration with
10905         a FORWARD_SCOPE_EXIT.
10906         (syms_from_objfile_1): Use the forward_scope_exit and
10907         gdb::optional instead of cleanup_function.
10908         (reread_symbols): Use the forward_scope_exit instead of
10909         cleanup_function.
10910         (clear_symtab_users_cleanup): Remove function.
10911
10912 2019-01-23  Tom Tromey  <tom@tromey.com>
10913             Pedro Alves  <palves@redhat.com>
10914
10915         * linux-nat.c: Include scope-exit.h.
10916         (cleanup_target_stop): Remove.
10917         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10918         SCOPE_EXIT.
10919
10920 2019-01-23  Tom Tromey  <tom@tromey.com>
10921             Pedro Alves  <palves@redhat.com>
10922
10923         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10924         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10925
10926 2019-01-23  Tom Tromey  <tom@tromey.com>
10927             Andrew Burgess  <andrew.burgess@embecosm.com>
10928             Pedro Alves  <palves@redhat.com>
10929
10930         * infrun.c (fetch_inferior_event): Use scope_exit.
10931         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10932         * top.c (execute_command): Use scope_exit.
10933         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10934         * utils.c (do_bpstat_clear_actions_cleanup)
10935         (make_bpstat_clear_actions_cleanup): Remove.
10936
10937 2019-01-23  Tom Tromey  <tom@tromey.com>
10938             Pedro Alves  <palves@redhat.com>
10939
10940         * infrun.c: Include "common/scope-exit.h"
10941         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10942         (wait_for_inferior): Use SCOPE_EXIT.
10943         (fetch_inferior_event): Use scope_exit.
10944
10945 2019-01-23  Tom Tromey  <tom@tromey.com>
10946             Pedro Alves  <palves@redhat.com>
10947
10948         * breakpoint.c (create_breakpoint): Remove cleanup.
10949
10950 2019-01-23  Tom Tromey  <tom@tromey.com>
10951             Andrew Burgess  <andrew.burgess@embecosm.com>
10952             Pedro Alves  <palves@redhat.com>
10953
10954 2019-01-23  Pedro Alves  <palves@redhat.com>
10955
10956         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10957
10958 2019-01-23  Pedro Alves  <palves@redhat.com>
10959             Andrew Burgess  <andrew.burgess@embecosm.com>
10960
10961         * gdbthread.h: Include "common/forward-scope-exit.h".
10962         (scoped_finish_thread_state): Redefine custom class in terms of
10963         forward_scope_exit.
10964
10965 2019-01-23  Pedro Alves  <palves@redhat.com>
10966             Andrew Burgess  <andrew.burgess@embecosm.com>
10967
10968         * common/forward-scope-exit.h: New file.
10969
10970 2019-01-23  Pedro Alves  <palves@redhat.com>
10971             Andrew Burgess  <andrew.burgess@embecosm.com>
10972             Tom Tromey  <tom@tromey.com>
10973
10974         * common/scope-exit.h: New file.
10975
10976 2019-01-23  Pedro Alves  <palves@redhat.com>
10977
10978         * common/preprocessor.h (ESC): Rename to ...
10979         (ESC_PARENS): ... this.
10980         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10981         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10982
10983 2019-01-23  Tom Tromey  <tom@tromey.com>
10984
10985         * language.h (class scoped_switch_to_sym_language_if_auto):
10986         Initialize m_lang in both cases.
10987
10988 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10989
10990         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10991         with XCNEW.
10992
10993 2019-01-22  Tom Tromey  <tom@tromey.com>
10994
10995         * corelow.c: Do not include sys/file.h.
10996
10997 2019-01-22  Tom Tromey  <tom@tromey.com>
10998
10999         * tui/tui-wingeneral.h: Include gdb_curses.h.
11000
11001 2019-01-22  Tom Tromey  <tom@tromey.com>
11002
11003         * source-cache.h (class source_cache) <get_source_lines,
11004         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11005
11006 2019-01-22  Tom Tromey  <tom@tromey.com>
11007
11008         * remote-fileio.h (struct remote_target): Declare.
11009
11010 2019-01-22  Tom Tromey  <tom@tromey.com>
11011
11012         * python/py-arch.c: Do not include py-ref.h.
11013         * python/py-bpevent.c: Do not include py-ref.h.
11014         * python/py-cmd.c: Do not include py-ref.h.
11015         * python/py-continueevent.c: Do not include py-ref.h.
11016         * python/py-event.h: Do not include py-ref.h.
11017         * python/py-evtregistry.c: Do not include py-ref.h.
11018         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11019         * python/py-frame.c: Do not include py-ref.h.
11020         * python/py-framefilter.c: Do not include py-ref.h.
11021         * python/py-function.c: Do not include py-ref.h.
11022         * python/py-infevents.c: Do not include py-ref.h.
11023         * python/py-linetable.c: Do not include py-ref.h.
11024         * python/py-objfile.c: Do not include py-ref.h.
11025         * python/py-param.c: Do not include py-ref.h.
11026         * python/py-prettyprint.c: Do not include py-ref.h.
11027         * python/py-progspace.c: Do not include py-ref.h.
11028         * python/py-symbol.c: Do not include py-ref.h.
11029         * python/py-symtab.c: Do not include py-ref.h.
11030         * python/py-type.c: Do not include py-ref.h.
11031         * python/py-unwind.c: Do not include py-ref.h.
11032         * python/py-utils.c: Do not include py-ref.h.
11033         * python/py-value.c: Do not include py-ref.h.
11034         * python/py-varobj.c: Do not include py-ref.h.
11035         * python/py-xmethods.c: Do not include py-ref.h.
11036         * python/python.c: Do not include py-ref.h.
11037         * varobj.c: Do not include py-ref.h.
11038
11039 2019-01-22  Tom Tromey  <tom@tromey.com>
11040
11041         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11042         keyword for bcache.
11043
11044 2019-01-22  Tom Tromey  <tom@tromey.com>
11045
11046         * compile/compile-cplus-types.c: Remove a comment by #include.
11047
11048 2019-01-22  Tom Tromey  <tom@tromey.com>
11049
11050         * compile/gcc-c-plugin.h: Include compile-internal.h.
11051
11052 2019-01-22  Tom Tromey  <tom@tromey.com>
11053
11054         * stabsread.c (EXTERN): Do not define.
11055         (symnum, next_symbol_text_func, processing_gcc_compilation)
11056         (within_function, global_sym_chain, global_stabs)
11057         (previous_stab_code, this_object_header_files)
11058         (n_this_object_header_files)
11059         (n_allocated_this_object_header_files): Define.
11060         * stabsread.h (EXTERN): Never define.  Use "extern".
11061
11062 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11063
11064         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11065         history_value.
11066
11067 2019-01-21  Tom Tromey  <tom@tromey.com>
11068
11069         * ui-out.c: Fix includes.
11070         * tui/tui-source.c: Fix includes.
11071         * target.c: Fix includes.
11072         * remote.c: Fix includes.
11073         * regcache.c: Fix includes.
11074         * python/py-block.c: Fix includes.
11075         * printcmd.c: Fix includes.
11076         * or1k-tdep.c: Fix includes.
11077         * mi/mi-main.c: Fix includes.
11078         * m32r-tdep.c: Fix includes.
11079         * csky-tdep.c: Fix includes.
11080         * compile/compile-cplus-types.c: Fix includes.
11081         * cli/cli-interp.c: Fix includes.
11082
11083 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11084
11085         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11086         for padding.
11087
11088 2019-01-16  Tom Tromey  <tom@tromey.com>
11089
11090         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11091         earlier.
11092         (struct objfile) <msymbols_range>: Move from top level.
11093         <msymbols>: New method.
11094         (class objfile_msymbols): Remove.
11095         * symtab.c (default_collect_symbol_completion_matches_break_on):
11096         Update.
11097         * symmisc.c (dump_msymbols): Update.
11098         * stabsread.c (scan_file_globals): Update.
11099         * objc-lang.c (info_selectors_command, info_classes_command)
11100         (find_methods): Update.
11101         * minsyms.c (find_solib_trampoline_target): Update.
11102         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11103         * coffread.c (coff_symfile_read): Update.
11104         * ada-lang.c (ada_lookup_simple_minsym)
11105         (ada_collect_symbol_completion_matches): Update.
11106
11107 2019-01-16  Tom Tromey  <tom@tromey.com>
11108
11109         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11110         type.  Remove no-argument constructor.
11111         <iterator::operator++>: Simplify.
11112         <begin>: Update.
11113         <end>: Use minimal_symbol_count.
11114
11115 2019-01-16  Tom Tromey  <tom@tromey.com>
11116
11117         * objfiles.h (struct objfile) <psymtabs>: New method.
11118         (class objfile_psymtabs): Remove.
11119         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11120         typedef.
11121         <range>: New method.
11122         (require_partial_symbols): Change return type.
11123         * psymtab.c (require_partial_symbols)
11124         (psym_expand_symtabs_matching): Update.
11125         * mdebugread.c (parse_partial_symbols): Update.
11126         * dbxread.c (dbx_end_psymtab): Update.
11127
11128 2019-01-15  Tom Tromey  <tom@tromey.com>
11129
11130         * symtab.c (lookup_objfile_from_block)
11131         (lookup_symbol_in_objfile_symtabs)
11132         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11133         (find_line_symtab, info_sources_command)
11134         (default_collect_symbol_completion_matches_break_on)
11135         (make_source_files_completion_list): Update.
11136         * symmisc.c (print_objfile_statistics, dump_objfile)
11137         (maintenance_print_symbols, maintenance_info_symtabs)
11138         (maintenance_check_symtabs, maintenance_info_line_tables):
11139         Update.
11140         * source.c (select_source_symtab)
11141         (forget_cached_source_info_for_objfile): Update.
11142         * objfiles.h (class objfile_compunits): Remove.
11143         (struct objfile) <compunits_range>: New typedef.
11144         (compunits): New method.
11145         * objfiles.c (objfile_relocate1): Update.
11146         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11147         * maint.c (count_symtabs_and_blocks): Update.
11148         * linespec.c (iterate_over_all_matching_symtabs): Update.
11149         * cp-support.c (add_symbol_overload_list_qualified): Update.
11150         * coffread.c (coff_symtab_read): Update.
11151         * ada-lang.c (add_nonlocal_symbols)
11152         (ada_collect_symbol_completion_matches)
11153         (ada_add_global_exceptions): Update.
11154
11155 2019-01-15  Tom Tromey  <tom@tromey.com>
11156
11157         * progspace.h (program_space) <objfiles_safe_range>: New
11158         typedef.
11159         <objfiles_safe>: New method.
11160         * objfiles.h (class all_objfiles_safe): Remove.
11161         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11162         * jit.c (jit_inferior_exit_hook): Update.
11163
11164 2019-01-17  Tom Tromey  <tom@tromey.com>
11165
11166         * progspace.h (program_space) <objfiles_range>: New typedef.
11167         <objfiles>: New method.
11168         <objfiles_head>: Rename from objfiles.
11169         (object_files): Update.
11170         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11171         * guile/scm-pretty-print.c
11172         (ppscm_find_pretty_printer_from_objfiles): Update.
11173         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11174         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11175         Update.
11176         * python/py-progspace.c (pspy_get_objfiles): Update.
11177         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11178         Update.
11179         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11180         (objfpy_lookup_objfile_by_build_id): Update.
11181         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11182         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11183         Update.
11184         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11185         (expand_symtab_containing_pc, lookup_objfile_from_block)
11186         (lookup_static_symbol, basic_lookup_transparent_type)
11187         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11188         (find_line_symtab, info_sources_command)
11189         (default_collect_symbol_completion_matches_break_on)
11190         (make_source_files_completion_list, find_main_name): Update.
11191         * symmisc.c (print_symbol_bcache_statistics)
11192         (print_objfile_statistics, maintenance_print_symbols)
11193         (maintenance_print_msymbols, maintenance_print_objfiles)
11194         (maintenance_info_symtabs, maintenance_check_symtabs)
11195         (maintenance_expand_symtabs, maintenance_info_line_tables):
11196         Update.
11197         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11198         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11199         (map_overlay_command, unmap_overlay_command)
11200         (simple_overlay_update, expand_symtabs_matching)
11201         (map_symbol_filenames): Update.
11202         * symfile-debug.c (set_debug_symfile): Update.
11203         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11204         Update.
11205         * source.c (select_source_symtab, forget_cached_source_info):
11206         Update.
11207         * solib.c (solib_read_symbols): Update.
11208         * solib-spu.c (append_ocl_sos): Update.
11209         * psymtab.c (maintenance_print_psymbols)
11210         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11211         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11212         * printcmd.c (info_symbol_command): Update.
11213         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11214         Update.
11215         * objfiles.h (class all_objfiles): Remove.
11216         * objfiles.c (have_partial_symbols, have_full_symbols)
11217         (have_minimal_symbols, qsort_cmp, update_section_map)
11218         (shared_objfile_contains_address_p)
11219         (default_iterate_over_objfiles_in_search_order): Update.
11220         * objc-lang.c (info_selectors_command, info_classes_command)
11221         (find_methods): Update.
11222         * minsyms.c (find_solib_trampoline_target): Update.
11223         * maint.c (maintenance_info_sections)
11224         (maintenance_translate_address, count_symtabs_and_blocks):
11225         Update.
11226         * main.c (captured_main_1): Update.
11227         * linux-thread-db.c (try_thread_db_load_from_pdir)
11228         (has_libpthread): Update.
11229         * linespec.c (iterate_over_all_matching_symtabs)
11230         (search_minsyms_for_name): Update.
11231         * jit.c (jit_find_objf_with_entry_addr): Update.
11232         * hppa-tdep.c (find_unwind_entry)
11233         (hppa_lookup_stub_minimal_symbol): Update.
11234         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11235         Update.
11236         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11237         (elf_gnu_ifunc_resolve_by_got): Update.
11238         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11239         * dwarf-index-write.c (save_gdb_index_command): Update.
11240         * cp-support.c (add_symbol_overload_list_qualified): Update.
11241         * breakpoint.c (create_overlay_event_breakpoint)
11242         (create_longjmp_master_breakpoint)
11243         (create_std_terminate_master_breakpoint)
11244         (create_exception_master_breakpoint): Update.
11245         * blockframe.c (find_pc_partial_function): Update.
11246         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11247         (ada_collect_symbol_completion_matches)
11248         (ada_add_global_exceptions): Update.
11249
11250 2019-01-17  Tom Tromey  <tom@tromey.com>
11251
11252         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11253         declare VEC.
11254         (solib_target_parse_libraries): Change return type.
11255         (library_list_start_segment, library_list_start_section)
11256         (library_list_end_library, library_list_start_library); Update.
11257         (solib_target_free_library_list): Remove.
11258         (solib_target_parse_libraries): Remove cleanup.  Change return
11259         type.
11260         (solib_target_current_sos): Update.
11261
11262 2019-01-17  Tom Tromey  <tromey@bapiya>
11263
11264         * valprint.c: Replace "the the" with "the".
11265         * symtab.c: Replace "the the" with "the".
11266         * solib.c: Replace "the the" with "the".
11267         * solib-dsbt.c: Replace "the the" with "the".
11268         * linespec.c: Replace "the the" with "the".
11269         * dwarf2loc.h: Replace "the the" with "the".
11270         * amd64-windows-tdep.c: Replace "the the" with "the".
11271         * aarch64-tdep.c: Replace "the the" with "the".
11272
11273 2019-01-16  Keith Seitz  <keiths@redhat.com>
11274
11275         PR gdb/23773
11276         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11277         <builder>: Rename to ..
11278         <m_builder>: ... this and make private.
11279         (dwarf2_cu::get_builder): New method.  Change all users of
11280         `builder' to use this method.
11281         (dwarf2_start_symtab): Move to ...
11282         (dwarf2_cu::start_symtab): ... here.  Update all callers
11283         (setup_type_unit_groups): Move to ...
11284         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11285         callers.
11286         (dwarf2_cu::reset_builder): New method.
11287         (process_full_compunit, process_full_type_unit): Use
11288         dwarf2_cu::reset_builder.
11289         (follow_die_offset): Record the ancestor CU if it is different
11290         from the followed DIE's CU.
11291         (follow_die_sig_1): Likewise.
11292
11293 2019-01-15  Tom Tromey  <tom@tromey.com>
11294
11295         * remote.c (class remote_state) <buf>: Now a char_vector.
11296         <buf_size>: Remove.
11297         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11298         parameter.
11299         (remote_target::getpkt_or_notif_sane_1)
11300         (remote_target::getpkt_sane)
11301         (remote_target::getpkt_or_notif_sane): Likewise.
11302         (class remote_target) <putpkt>: New overload.
11303         (remote_target::read_frame): Change type of "buf_p".  Remove
11304         sizeof_p parameter.
11305         (packet_ok): New overload.
11306         (packet_check_result): New overload.
11307         Update all uses.
11308
11309 2019-01-14  Tom Tromey  <tom@tromey.com>
11310
11311         * remote-notif.c (handle_notification, remote_notif_ack)
11312         (remote_notif_parse): Make "buf" const.
11313         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11314         const.
11315         (remote_notif_parse, remote_notif_ack, handle_notification):
11316         Likewise.
11317         * remote.c (remote_notif_stop_parse): Make "buf" const.
11318         (remote_target::remote_parse_stop_reply): Make "buf" const.
11319         (remote_notif_stop_ack): Make "buf" const.
11320
11321 2019-01-14  Tom Tromey  <tom@tromey.com>
11322
11323         * remote.c (remote_console_output): Make parameter const.
11324
11325 2019-01-14  Tom Tromey  <tom@tromey.com>
11326
11327         * target-debug.h (target_debug_print_signals): Constify.
11328         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11329         * procfs.c (procfs_target::pass_signals): Update.
11330         * linux-nat.c (linux_nat_target::pass_signals): Update.
11331         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11332         * target-delegates.c: Rebuild.
11333         * remote.c (remote_target::program_signals): Update.
11334         (remote_target::pass_signals): Update.
11335         * target.c (target_pass_signals): Constify argument.
11336         (target_program_signals): Likewise.
11337         * target.h (struct target_ops) <pass_signals, program_signals>:
11338         Constify argument.
11339         (target_pass_signals, target_program_signals): Constify argument.
11340
11341 2019-01-14  Tom Tromey  <tom@tromey.com>
11342
11343         PR tui/28819:
11344         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11345
11346 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11347
11348         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11349         field.
11350         * rs6000-tdep.c: Include reggroups.h.
11351         (IS_V_ALIAS_PSEUDOREG): Define.
11352         (rs6000_register_name): Return names for the "vX" aliases.
11353         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11354         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11355         aliases.  Call default_register_reggroup_p for all other
11356         pseudo-registers.
11357         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11358         New functions.
11359         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11360         Handle "vX" aliases.
11361         (v_alias_pseudo_register_collect): New function.
11362         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11363         (rs6000_gdbarch_init): Initialize "vX" aliases as
11364         pseudo-registers.  Restore registration of
11365         rs6000_pseudo_register_reggroup_p with
11366         set_tdesc_pseudo_register_reggroup_p.
11367
11368 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11369
11370         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11371         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11372         set_gdbarch_num_pseudo_regs.
11373
11374 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11375
11376         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11377         Remove arg prefixname, add do_set and do_show.
11378         Add member functions set_list and show_list.
11379         * cli/cli-style.c (class cli_style_option): Update accordingly.
11380         (style_set_list): Move to file scope.
11381         (style_show_list): Likewise.
11382         (set_style): Call help_list.
11383         (show_style): Call cmd_show_list.
11384         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11385         Update to use the new macro.
11386
11387 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11388
11389         * ada-lang.c (_initialize_ada_language): Expand the help text
11390         for the "catch exception" command.
11391
11392 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11393
11394         * symtab.c (matching_obj_sections): Initialize obj,
11395         declare it closer to its usage.
11396
11397 2019-01-10  Tom Tromey  <tom@tromey.com>
11398
11399         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11400         (basic_inf_threads_range): Remove.
11401         (inf_threads_range, inf_non_exited_threads_range)
11402         (safe_inf_threads_range): Use next_adapter.
11403
11404 2019-01-10  Keith Seitz  <keiths@redhat.com>
11405
11406         PR gdb/23712
11407         PR symtab/23010
11408         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11409         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11410
11411 2019-01-10  Keith Seitz  <keiths@redhat.com>
11412
11413         PR gdb/23712
11414         PR symtab/23010
11415         * dictionary.c (pending_to_vector): Remove.
11416         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11417         Remove _1 suffix, replacing functions of the same name.  Update
11418         all callers.
11419         (dict_create_hashed, dict_create_hashed_expandable)
11420         (dict_create_linear, dict_create_linear_expandable, dict_free)
11421         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11422         Make functions static.
11423
11424 2019-01-10  Keith Seitz  <keiths@redhat.com>
11425
11426         PR gdb/23712
11427         PR symtab/23010
11428         * dictionary.h (struct dictionary): Replace declaration with
11429         multidictionary.
11430         (dict_create_hashed, dict_create_hashed_expandable)
11431         (dict_create_linear, dict_create_linear_expandable)
11432         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11433         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11434         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11435         taking multidictionary argument.
11436         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11437         * block.h (struct block) <dict>: Change to multidictionary
11438         and rename `multidict'.
11439         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11440         symmisc.c: Update all dictionary references to multidictionary.
11441
11442 2019-01-10  Keith Seitz  <keiths@redhat.com>
11443
11444         PR gdb/23712
11445         PR symtab/23010
11446         * dictionary.c: Include unordered_map.
11447         (pending_to_vector): New function.
11448         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11449         Rewrite the non-"_1" functions to take vector instead
11450         of linked list.
11451         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11452         "new" _1 versions of the same name.
11453         (multidictionary): Define.
11454         (std::hash<enum language): New definition.
11455         (collate_pending_symbols_by_language, mdict_create_hashed)
11456         (mdict_create_hashed_expandable, mdict_create_linear)
11457         (mdict_create_linear_expandable, mdict_free)
11458         (find_language_dictionary, create_new_language_dictionary)
11459         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11460         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11461         (mdict_size, mdict_empty): New functions.
11462         * dictionary.h (mdict_iterator): Define.
11463
11464 2019-01-10  Pedro Alves  <palves@redhat.com>
11465
11466         * breakpoint.c (read_uploaded_action)
11467         (create_tracepoint_from_upload): Adjust to use
11468         gdb::unique_xmalloc_ptr.
11469         * ctf.c (ctf_write_uploaded_tp):
11470         (SET_ARRAY_FIELD): Use emplace_back.
11471         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11472         * tracefile-tfile.c (tfile_write_uploaded_tp):
11473         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11474         gdb::unique_xmalloc_ptr.
11475         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11476         at_string, cond_string, cmd_strings>: Replace char pointers
11477         with gdb::unique_xmalloc_ptr.
11478
11479 2019-01-10  Pedro Alves  <palves@redhat.com>
11480
11481         * solib-target.c (library_list_start_library): Don't xstrdup name.
11482
11483 2019-01-10  Pedro Alves  <palves@redhat.com>
11484
11485         * mdebugread.c (parse_partial_symbols): Use
11486         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11487
11488 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11489
11490         * linux-fork.c (scoped_switch_fork_info)
11491         <~scoped_switch_fork_info>: Fix incorrect variable name.
11492
11493 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11494
11495         * linux-fork.c (scoped_switch_fork_info)
11496         <scoped_switch_fork_info>: Make explicit.
11497         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11498
11499 2019-01-10  Tom Tromey  <tom@tromey.com>
11500
11501         * objfiles.h (objfile::reset_psymtabs): Update.
11502         * objfiles.c (objfile::objfile): Update.
11503         * psymtab.h (psymtab_storage::obstack): Update.
11504         (psymtab_storage::m_obstack): Use gdb::optional.
11505         (class psymtab_storage): Update comment.  Remove objfile
11506         parameter.
11507         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11508
11509 2019-01-10  Tom Tromey  <tom@tromey.com>
11510
11511         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11512         <free_psymtabs>: Now private.
11513         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11514         (allocate_psymtab): Use new method.
11515
11516 2019-01-10  Tom Tromey  <tom@tromey.com>
11517
11518         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11519         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11520         * mdebugread.c (parse_partial_symbols): Use
11521         allocate_dependencies.
11522         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11523         allocate_dependencies.
11524         (process_psymtab_comp_unit_reader)
11525         (build_type_psymtab_dependencies): Likewise.
11526         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11527
11528 2019-01-10  Tom Tromey  <tom@tromey.com>
11529
11530         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11531         PSYMBOL_SET_LANGUAGE.
11532         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11533
11534 2019-01-10  Tom Tromey  <tom@tromey.com>
11535
11536         * psymtab.h (psymtab_storage::obstack): New method.
11537         <m_obstack>: Rename from obstack; now private.
11538         * psymtab.c (psymtab_storage): Update.
11539         * dwarf2read.c (create_addrmap_from_index)
11540         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11541         Update.
11542
11543 2019-01-10  Tom Tromey  <tom@tromey.com>
11544
11545         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11546         * objfiles.h (objfile::reset_psymtabs): New method.
11547
11548 2019-01-10  Tom Tromey  <tom@tromey.com>
11549
11550         * symmisc.c (print_symbol_bcache_statistics): Update.
11551         (print_objfile_statistics): Update.
11552         * symfile.c (reread_symbols): Update.
11553         * psymtab.h (class psymtab_storage): New.
11554         * psymtab.c (psymtab_storage): New constructor.
11555         (~psymtab_storage): New destructor.
11556         (require_partial_symbols): Update.
11557         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11558         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11559         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11560         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11561         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11562         (start_psymtab_common, end_psymtab_common)
11563         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11564         (allocate_psymtab): Update.
11565         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11566         Update.
11567         (dump_psymtab_addrmap, maintenance_print_psymbols)
11568         (maintenance_check_psymtabs): Update.
11569         (class objfile_psymtabs): Move to objfiles.h.
11570         * psympriv.h (discard_psymtab): Now inline.
11571         (psymtab_discarder::psymtab_discarder): Update.
11572         (psymtab_discarder::~psymtab_discarder): Update.
11573         (ALL_OBJFILE_PSYMTABS): Rewrite.
11574         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11575         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11576         Remove fields.
11577         <partial_symtabs>: New field.
11578         (class objfile_psymtabs): Move from psymtab.h.  Update.
11579         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11580         psymbol_cache.
11581         (objfile::~objfile): Don't destroy psymbol_cache.
11582         * mdebugread.c (parse_partial_symbols): Update.
11583         * dwarf2read.c (create_addrmap_from_index)
11584         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11585         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11586         (add_partial_subprogram, dwarf2_ranges_read): Update.
11587         * dwarf-index-write.c (write_address_map)
11588         (write_one_signatured_type, recursively_write_psymbols)
11589         (class debug_names, class debug_names, write_psymtabs_to_index):
11590         Update.
11591
11592 2019-01-10  Tom Tromey  <tom@tromey.com>
11593
11594         * symtab.h (SYMBOL_SET_NAMES): Update.
11595         (symbol_set_names): Update.
11596         (MSYMBOL_SET_NAMES): Update.
11597         * symtab.c (symbol_set_names): Change argument to be an
11598         objfile_per_bfd_storage.
11599         * psymtab.c (add_psymbol_to_bcache): Update.
11600         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11601
11602 2019-01-10  Tom Tromey  <tom@tromey.com>
11603
11604         * symtab.c (create_demangled_names_hash): Change argument to be an
11605         objfile_per_bfd_storage.
11606         (symbol_set_names): Update.
11607
11608 2019-01-10  Tom Tromey  <tom@tromey.com>
11609
11610         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11611         init_psymbol_list.
11612         * psymtab.c (init_psymbol_list): Do nothing if already called.
11613         * psympriv.h (init_psymbol_list): Add comment.
11614         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11615         init_psymbol_list.
11616         * dbxread.c (dbx_symfile_read): Unconditionally call
11617         init_psymbol_list.
11618
11619 2019-01-10  Tom Tromey  <tom@tromey.com>
11620
11621         * xcoffread.c (scan_xcoff_symtab): Update.
11622         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11623         "where".
11624         * mdebugread.c (parse_partial_symbols)
11625         (handle_psymbol_enumerators): Update.
11626         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11627         * dbxread.c (read_dbx_symtab): Update.
11628         * psympriv.h (psymbol_placement): New enum.
11629         (add_psymbol_to_list): Update.
11630
11631 2019-01-10  Tom Tromey  <tom@tromey.com>
11632
11633         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11634         static_psymbols parameters.
11635         (scan_xcoff_symtab): Update.
11636         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11637         static_psymbols parameters.
11638         * psympriv.h (start_psymtab_common): Update.
11639         * mdebugread.c (parse_partial_symbols): Update.
11640         * dwarf2read.c (create_partial_symtab): Update.
11641         * dbxread.c (read_dbx_symtab): Update.
11642         (start_psymtab): Remove global_psymbols and static_psymbols
11643         parameters.
11644
11645 2019-01-10  Tom Tromey  <tom@tromey.com>
11646
11647         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11648         * psymtab.c (allocate_psymtab): Add comment.
11649         * psympriv.h (allocate_psymtab): Add comment.
11650         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11651         initializations.
11652         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11653
11654 2019-01-10  Tom Tromey  <tom@tromey.com>
11655
11656         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11657         Don't declare.
11658         * mipsread.c: Include mdebugread.h.
11659         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11660         Declare.
11661         * elfread.c: Include mdebugread.h.
11662
11663 2019-01-09  Tom Tromey  <tom@tromey.com>
11664
11665         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11666         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11667         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11668         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11669         (psym_lookup_symbol, psym_find_last_source_symtab)
11670         (psym_forget_cached_source_info, psym_print_stats)
11671         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11672         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11673         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11674         (psym_find_compunit_symtab_by_address)
11675         (maintenance_print_psymbols, maintenance_info_psymtabs)
11676         (maintenance_check_psymtabs): Use ranged for.
11677         * psymtab.h (class objfile_psymtabs): New.
11678         (require_partial_symbols): Return objfile_psymtabs.
11679         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11680
11681 2019-01-09  Tom Tromey  <tom@tromey.com>
11682
11683         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11684         (find_pc_mapped_section, list_overlays_command)
11685         (map_overlay_command, unmap_overlay_command)
11686         (simple_overlay_update): Use all_objfiles.
11687         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11688         * printcmd.c (info_symbol_command): Use all_objfiles.
11689         * objfiles.h (ALL_OBJSECTIONS): Remove.
11690         * maint.c (maintenance_translate_address): Use all_objfiles.
11691         * gcore.c (gcore_create_callback): Use all_objfiles.
11692         (objfile_find_memory_regions): Likewise.
11693
11694 2019-01-09  Tom Tromey  <tom@tromey.com>
11695
11696         * symtab.c (find_line_symtab, info_sources_command)
11697         (make_source_files_completion_list): Use objfile_compunits.
11698         * source.c (select_source_symtab): Use objfile_compunits.
11699         * objfiles.h (struct objfile): Update comment.
11700         (ALL_OBJFILES): Remove.
11701         (ALL_FILETABS): Remove.
11702         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11703         objfile_compunits.
11704
11705 2019-01-09  Tom Tromey  <tom@tromey.com>
11706
11707         * symmisc.c (print_objfile_statistics, dump_objfile)
11708         (maintenance_print_symbols): Use compunit_filetabs.
11709         * source.c (forget_cached_source_info_for_objfile): Use
11710         compunit_filetabs.
11711         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11712         (ALL_FILETABS): Use compunit_filetabs.
11713         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11714         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11715
11716 2019-01-09  Tom Tromey  <tom@tromey.com>
11717
11718         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11719         (compunit_filetabs): New.
11720         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11721         compunit_filetabs.
11722         (info_sources_command, make_source_files_completion_list): Remove
11723         declaration.
11724         * symmisc.c (print_objfile_statistics, dump_objfile)
11725         (maintenance_print_symbols): Remove declaration.
11726         (maintenance_info_symtabs): Use compunit_filetabs.
11727         (maintenance_info_line_tables): Likewise.
11728         * source.c (select_source_symtab): Change local variable name.
11729         (forget_cached_source_info_for_objfile): Remove declaration.
11730         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11731         * objfiles.c (objfile_relocate1): Remove declaration.
11732         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11733         declaration.
11734         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11735         * coffread.c (coff_symtab_read): Remove declaration.
11736         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11737         compunit_filetabs.
11738
11739 2019-01-09  Tom Tromey  <tom@tromey.com>
11740
11741         * symtab.c (lookup_objfile_from_block)
11742         (find_pc_sect_compunit_symtab, search_symbols)
11743         (default_collect_symbol_completion_matches_break_on): Use
11744         objfile_compunits.
11745         * objfiles.h (ALL_COMPUNITS): Remove.
11746         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11747         * cp-support.c (add_symbol_overload_list_qualified): Use
11748         objfile_compunits.
11749         * ada-lang.c (ada_collect_symbol_completion_matches)
11750         (ada_add_global_exceptions): Use objfile_compunits.
11751
11752 2019-01-09  Tom Tromey  <tom@tromey.com>
11753
11754         * source.c (select_source_symtab)
11755         (forget_cached_source_info_for_objfile): Remove declaration.
11756         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11757         declaration.
11758         * maint.c (count_symtabs_and_blocks): Remove declaration.
11759         * cp-support.c (add_symbol_overload_list_qualified): Remove
11760         declaration.
11761         * coffread.c (coff_symtab_read): Remove declaration.
11762         * symtab.c (lookup_symbol_in_objfile_symtabs)
11763         (basic_lookup_transparent_type_1): Use objfile_compunits.
11764         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11765         (info_sources_command, search_symbols)
11766         (default_collect_symbol_completion_matches_break_on)
11767         (make_source_files_completion_list): Remove declaration.
11768         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11769         (ada_collect_symbol_completion_matches)
11770         (ada_add_global_exceptions): Remove declaration.
11771         * linespec.c (iterate_over_all_matching_symtabs): Use
11772         objfile_compunits.
11773         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11774         (class objfile_compunits): New.
11775         (ALL_COMPUNITS): Use objfile_compunits.
11776         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11777         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11778         objfile_compunits.
11779         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11780
11781 2019-01-09  Tom Tromey  <tom@tromey.com>
11782
11783         * symtab.c (search_symbols)
11784         (default_collect_symbol_completion_matches_break_on): Use
11785         objfile_msymbols.
11786         * ada-lang.c (ada_lookup_simple_minsym)
11787         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11788         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11789         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11790         objfile_msymbols.
11791         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11792         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11793         * objc-lang.c (find_methods): Use objfile_msymbols.
11794         (info_selectors_command, info_classes_command): Likewise.
11795         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11796         * objfiles.h (class objfile_msymbols): New.
11797         (ALL_OBJFILE_MSYMBOLS): Remove.
11798         (ALL_MSYMBOLS): Remove.
11799
11800 2019-01-09  Tom Tromey  <tom@tromey.com>
11801
11802         * common/next-iterator.h (next_adapter): Add Iterator template
11803         parameter.
11804         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11805         (class all_objfiles_safe): New.
11806         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11807         * objfiles.c (put_objfile_before): Update comment.
11808         (add_separate_debug_objfile): Likewise.
11809         (free_all_objfiles): Use all_objfiles_safe.
11810         (objfile_purge_solibs): Likewise.
11811
11812 2019-01-09  Tom Tromey  <tom@tromey.com>
11813
11814         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11815         (expand_symtab_containing_pc, lookup_static_symbol)
11816         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11817         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11818         all_objfiles.
11819         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11820         * breakpoint.c (create_overlay_event_breakpoint)
11821         (create_longjmp_master_breakpoint)
11822         (create_std_terminate_master_breakpoint)
11823         (create_exception_master_breakpoint): Use all_objfiles.
11824         * linux-thread-db.c (try_thread_db_load_from_pdir)
11825         (has_libpthread): Use all_objfiles.
11826         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11827         * linespec.c (iterate_over_all_matching_symtabs)
11828         (search_minsyms_for_name): Use all_objfiles.
11829         * maint.c (maintenance_info_sections): Use all_objfiles.
11830         * main.c (captured_main_1): Use all_objfiles.
11831         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11832         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11833         * guile/scm-pretty-print.c
11834         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11835         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11836         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11837         (maintenance_print_msymbols): Use all_objfiles.
11838         * source.c (select_source_symtab): Use all_objfiles.
11839         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11840         * symfile.c (remove_symbol_file_command)
11841         (expand_symtabs_matching, map_symbol_filenames): Use
11842         all_objfiles.
11843         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11844         all_objfiles.
11845         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11846         * objc-lang.c (find_methods): Use all_objfiles.
11847         * objfiles.c (have_partial_symbols, have_full_symbols)
11848         (have_minimal_symbols, qsort_cmp)
11849         (default_iterate_over_objfiles_in_search_order): Use
11850         all_objfiles.
11851         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11852         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11853         (maintenance_check_psymtabs): Use all_objfiles.
11854         (ALL_PSYMTABS): Remove.
11855         * compile/compile-object-run.c (do_module_cleanup): Use
11856         all_objfiles.
11857         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11858         * cp-support.c (add_symbol_overload_list_qualified): Use
11859         all_objfiles.
11860         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11861         Use all_objfiles.
11862         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11863         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11864         all_objfiles.
11865         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11866         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11867         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11868         Uses all_objfiles.
11869         * solib.c (solib_read_symbols): Use all_objfiles
11870
11871 2019-01-09  Tom Tromey  <tom@tromey.com>
11872
11873         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11874         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11875         all_objfiles.
11876         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11877         * symmisc.c (print_symbol_bcache_statistics)
11878         (print_objfile_statistics, maintenance_print_objfiles)
11879         (maintenance_info_symtabs, maintenance_check_symtabs)
11880         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11881         all_objfiles.
11882         * source.c (forget_cached_source_info): Use all_objfiles.
11883         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11884         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11885         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11886         * objfiles.c (update_section_map): Use all_objfiles.
11887         (shared_objfile_contains_address_p): Likewise.
11888         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11889         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11890
11891 2019-01-09  Tom Tromey  <tom@tromey.com>
11892
11893         * common/next-iterator.h: New file.
11894         * objfiles.h (class all_objfiles): New.
11895         (struct objfile_iterator): New.
11896
11897 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11898
11899         * NEWS: Move the description of the changed "frame", "select-frame",
11900          and "info frame" commands to the Changed commands section.
11901
11902 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11903
11904         * gdbtypes.c (check_stub_method_group): Remove handling of old
11905         mangling schemes.
11906         * linespec.c (find_methods): Likewise.
11907         * stabsread.c (read_member_functions): Likewise.
11908         * valops.c (search_struct_method): Likewise.
11909         (value_struct_elt_for_reference): Likewise.
11910         * NEWS: Mention this change.
11911
11912 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11913
11914         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11915         print_source_lines.
11916         * source.c (print_source_lines_base): Update line number check.
11917         (print_source_lines): New function.
11918         (source_lines_range::source_lines_range): New function.
11919         * source.h (class source_lines_range): New class.
11920         (print_source_lines): New declaration.
11921
11922 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11923
11924         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11925
11926 2019-01-08  Tom Tromey  <tom@tromey.com>
11927             Simon Marchi  <simon.marchi@ericsson.com>
11928
11929         PR gdb/24060
11930         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11931         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11932         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11933         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11934         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11935         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11936
11937 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11938
11939         * source.c (select_source_symtab): Move header comment to
11940         declaration in source.h.
11941         (forget_cached_source_info_for_objfile): Likewise.
11942         (forget_cached_source_info): Likewise.
11943         (identify_source_line): Likewise.
11944         * source.h (identify_source_line): Move declaration from symtab.h
11945         and add comment from source.c
11946         (print_source_lines): Likewise.
11947         (forget_cached_source_info_for_objfile): Likewise.
11948         (forget_cached_source_info): Likewise.
11949         (select_source_symtab): Likewise.
11950         (enum print_source_lines_flag): Move definition from symtab.h.
11951         * symtab.h (identify_source_line): Move declaration to source.h.
11952         (print_source_lines): Likewise.
11953         (forget_cached_source_info_for_objfile): Likewise.
11954         (forget_cached_source_info): Likewise.
11955         (select_source_symtab): Likewise.
11956         (enum print_source_lines_flag): Move definition to source.h.
11957         * tui/tui-hooks.c: Add 'source.h' include.
11958
11959 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11960
11961         * source.c (print_source_lines_base): Handle requests to print
11962         reverse line number sequences, and guard against empty lines
11963         string.
11964
11965 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11966
11967         * source.c (print_source_lines_base): Fix skip of '\r' if next
11968         character is '\n'.
11969
11970 2019-01-06  Tom Tromey  <tom@tromey.com>
11971
11972         * c-exp.y (struct c_parse_state) <macro_original_text,
11973         expansion_obstack>: New member.
11974         (macro_original_text, expansion_obstack): Remove globals.
11975         (scan_macro_expansion, scanning_macro_expansion)
11976         (finished_macro_expansion): Update.
11977         (scan_macro_cleanup): Remove.
11978         (yylex, c_parse): Update.
11979
11980 2019-01-06  Tom Tromey  <tom@tromey.com>
11981
11982         * c-exp.y (struct c_parse_state) <strings>: New member.
11983         (operator_stoken): Update.
11984
11985 2019-01-06  Tom Tromey  <tom@tromey.com>
11986
11987         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11988         (union type_stack_elt) <typelist_val>: Now a pointer to
11989         std::vector.
11990         (type_stack_cleanup): Don't declare.
11991         (push_typelist): Update.
11992         * parse.c (pop_typelist): Return a std::vector.
11993         (push_typelist): Take a std::vector.
11994         (follow_types): Update.  Do not free args.
11995         (type_stack_cleanup): Remove.
11996         * c-exp.y (struct c_parse_state): New.
11997         (cpstate): New global.
11998         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11999         (nonempty_typelist): Update.
12000         (func_mod): Create a new vector.
12001         (c_parse): Create a c_parse_state.
12002         (check_parameter_typelist): Do not delete params.
12003         (function_method): Update.  Do not delete type_list.
12004
12005 2019-01-06  Tom Tromey  <tom@tromey.com>
12006
12007         PR gdb/28155:
12008         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12009         check_typedef.
12010         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12011         (print_return_value): Likewise.
12012
12013 2019-01-05  Tom Tromey  <tom@tromey.com>
12014
12015         * contrib/cleanup_check.py: Remove.
12016         * contrib/gcc-with-excheck: Remove.
12017         * contrib/exsummary.py: Remove.
12018         * contrib/excheck.py: Remove.
12019
12020 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12021
12022         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12023         NULL. Initialize tpprev to NULL instead of assigning it
12024         to NULL on the next statement.
12025         * windows-nat.c (windows_delete_thread): Remove check for
12026         main_thread_id before printing thread exit notifications.
12027         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12028         Remove thread ID check against main_thread_id.
12029         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12030         windows_delete_thread.
12031         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12032
12033 2019-01-04  Tom Tromey  <tom@tromey.com>
12034
12035         * compile/compile.c (_initialize_compile): Use upper case for
12036         metasyntactic variables.
12037         * symmisc.c (_initialize_symmisc): Use upper case for
12038         metasyntactic variables.
12039         * psymtab.c (_initialize_psymtab): Use upper case for
12040         metasyntactic variables.
12041         * demangle.c (demangle_command): Use upper case for metasyntactic
12042         variables.
12043         (_initialize_demangler): Likewise.
12044         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12045         variables.
12046
12047 2019-01-03  Tom Tromey  <tom@tromey.com>
12048
12049         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12050
12051 2019-01-03  Tom Tromey  <tom@tromey.com>
12052
12053         * python/py-symtab.c (salpy_str): Update.
12054         (struct salpy_sal_object) <symtab>: Now a PyObject.
12055         (salpy_dealloc): Update.
12056         (del_objfile_sal): Use gdbpy_ref.
12057
12058 2019-01-03  Tom Tromey  <tom@tromey.com>
12059
12060         * python/py-type.c (convert_field): Use new_reference.  Return
12061         gdbpy_ref.
12062         (make_fielditem): Return gdbpy_ref.
12063         (typy_fields): Update.
12064         (typy_getitem): Update.
12065         (field_name): Return gdbpy_ref.  Use new_reference.
12066         (typy_iterator_iternext): Update.
12067
12068 2019-01-03  Tom Tromey  <tom@tromey.com>
12069
12070         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12071
12072 2019-01-03  Tom Tromey  <tom@tromey.com>
12073
12074         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12075         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12076         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12077         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12078         (pspy_set_type_printers): Likewise.
12079         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12080         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12081         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12082         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12083         (objfpy_set_type_printers): Likewise.
12084
12085 2019-01-03  Tom Tromey  <tom@tromey.com>
12086
12087         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12088         (gdbpy_print_stack): Use gdbpy_err_fetch.
12089         * python/python-internal.h (class gdbpy_err_fetch): New class.
12090         (class gdbpy_enter) <m_error_type, m_error_value,
12091         m_error_traceback>: Remove.
12092         <m_error>: New member.
12093         (gdbpy_exception_to_string): Don't declare.
12094         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12095         * python/py-value.c (convert_value_from_python): Use
12096         gdbpy_err_fetch.
12097         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12098         gdbpy_exception_to_string.
12099         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12100         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12101         gdbpy_err_fetch.
12102
12103 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12104
12105         * linux-nat.c (delete_lwp_cleanup): Delete.
12106         (struct lwp_deleter): New struct.
12107         (lwp_info_up): New typedef.
12108         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12109         lwp_info_up.
12110
12111 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12112
12113         * linux-fork.c (class scoped_switch_fork_info): New class.
12114         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12115
12116 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12117
12118         * valops.c (find_overload_match): Remove use of null_cleanup, and
12119         calls to do_cleanups.
12120
12121 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12122
12123         * compile/compile-cplus-types.c
12124         (compile_cplus_instance::decl_name): Handle changes to
12125         cp_func_name.
12126         * cp-support.c (cp_func_name): Update header comment, update
12127         return type.
12128         * cp-support.h (cp_func_name): Update return type in declaration.
12129         * valops.c (find_overload_match): Move temp_func local to top
12130         level of function and change its type.  Use temp_func to hold and
12131         delete temporary string obtained from cp_func_name.
12132
12133 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12134
12135         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12136         gdb::char_vector, remove cleanup, and update uses of `msg`.
12137
12138 2019-01-03  Jim Wilson  <jimw@sifive.com>
12139
12140         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12141
12142 2019-01-02  Tom Tromey  <tom@tromey.com>
12143
12144         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12145         (tdesc_parse_xml): Remove cleanups.
12146         * target-descriptions.h (make_cleanup_free_target_description):
12147         Don't declare.
12148         (target_desc_deleter): New struct.
12149         (target_desc_up): New typedef.
12150         * target-descriptions.c (target_desc_deleter::operator()): Rename
12151         from free_target_description.
12152         (make_cleanup_free_target_description): Remove.
12153
12154 2019-01-02  Tom Tromey  <tom@tromey.com>
12155
12156         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12157         constructor, destructor.
12158         (linespec_parser): Remove typedef.
12159         (~linespec_parser): Rename from linespec_parser_delete.
12160         (linespec_lex_to_end, linespec_complete_label)
12161         (linespec_complete): Update.
12162         (decode_line_full): Remove cleanups.
12163         (decode_line_1): Update.
12164
12165 2019-01-02  Tom Tromey  <tom@tromey.com>
12166
12167         * python/python-internal.h (inferior_to_inferior_object): Change
12168         return type.
12169         * python/py-exitedevent.c (create_exited_event_object): Update.
12170         * python/py-inferior.c (inferior_to_inferior_object): Return
12171         gdbpy_ref.
12172         (python_new_inferior, python_inferior_deleted)
12173         (thread_to_thread_object, delete_thread_object)
12174         (build_inferior_list, gdbpy_selected_inferior): Update.
12175         * python/py-infthread.c (create_thread_object): Update.  Also fail
12176         if inferior_to_inferior_object fails.
12177
12178 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12179
12180         * inferior.h (class inferior) <displaced_step_state>: New field.
12181         * infrun.h (struct displaced_step_state): Move here from
12182         infrun.c.  Initialize fields, add constructor.
12183         <inf>: Remove field.
12184         <reset>: New method.
12185         * infrun.c (struct displaced_step_inferior_state): Move to
12186         infrun.h.
12187         (displaced_step_inferior_states): Remove.
12188         (get_displaced_stepping_state): Adust.
12189         (displaced_step_in_progress_any_inferior): Adjust.
12190         (displaced_step_in_progress_thread): Adjust.
12191         (displaced_step_in_progress): Adjust.
12192         (add_displaced_stepping_state): Remove.
12193         (get_displaced_step_closure_by_addr): Adjust.
12194         (remove_displaced_stepping_state): Remove.
12195         (infrun_inferior_exit): Call displaced_step_state.reset.
12196         (use_displaced_stepping): Don't check for NULL.
12197         (displaced_step_prepare_throw): Call
12198         get_displaced_stepping_state.
12199         (displaced_step_fixup): Don't check for NULL.
12200         (prepare_for_detach): Don't check for NULL.
12201
12202 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12203
12204         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12205          in case of call that did not complete.
12206
12207 2019-01-02  Andrey Utkin  <autkin@undo.io>
12208
12209         * symfile.c (find_separate_debug_file): Fix search of debug files for
12210         remote debuggee.
12211
12212 2019-01-02  Tom Tromey  <tom@tromey.com>
12213
12214         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12215         indentation.
12216         * python/py-frame.c (frapy_older): Remove cast.
12217         (frapy_newer): Likewise.
12218         * python/py-breakpoint.c (local_setattro): Remove cast.
12219         * python/py-arch.c (archpy_name): Remove local variable.
12220         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12221
12222 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12223
12224         * unittests/basic_string_view/element_access/char/empty.cc:
12225         Fix year range in copyright header.
12226
12227 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12228
12229         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12230         Delete.
12231         <operator==>: Update with for removed field.
12232         <hash>: Likewise.
12233         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12234         <isa_features>: ...this.
12235         <abi_features>: New field.
12236         (riscv_isa_flen): Update comment.
12237         (riscv_abi_xlen): New declaration.
12238         (riscv_abi_flen): New declaration.
12239         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12240         isa_features.
12241         (riscv_abi_xlen): New function.
12242         (riscv_isa_flen): Update to get answer from isa_features.
12243         (riscv_abi_flen): New function.
12244         (riscv_has_fp_abi): Update to get answer from abi_features.
12245         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12246         xlen and flen.
12247         (riscv_call_info) <xlen, flen>: Update comment.
12248         (riscv_call_arg_struct): Remove invalid assertions
12249         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12250         is removed.
12251         (riscv_gdbarch_init): Gather isa features and abi features
12252         separately, ensure both match on the gdbarch when reusing an old
12253         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12254         a target with 64-bit float hardware.
12255
12256 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12257
12258         * source.c (search_command_helper): Stop reverse search
12259         when line 1 has been searched.
12260
12261 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12262
12263         * record-full.c (record_full_base_target::close): Rewrite
12264         record_full_core_buf_list free logic.
12265
12266 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12267
12268         * break-catch-syscall.c (print_one_catch_syscall): xfree
12269         the last text.
12270
12271 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12272
12273         * top.c (print_gdb_version): Update Copyright year in version
12274         message.
12275
12276 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12277
12278         Update copyright year range in all GDB files.
12279
12280 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12281
12282         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12283
12284 For older changes see ChangeLog-2018.
12285 \f
12286 Local Variables:
12287 mode: change-log
12288 left-margin: 8
12289 fill-column: 74
12290 version-control: never
12291 coding: utf-8
12292 End:
12293