gdb/ChangeLog

   1 2019-09-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * ada-lang.c (ada_iterate_over_symbols): Return bool.
   4         * language.h (struct language_defn) <la_iterate_over_symbols>:
   5         Return bool.
   6         * symtab.c (iterate_over_symbols): Return bool.
   7         * symtab.h (iterate_over_symbols): Return bool.
   8
   9 2019-09-10  Tom Tromey  <tromey@adacore.com>
  10
  11         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
  12         (add_nonlocal_symbols): Update.
  13         * dwarf2read.c (dw2_map_matching_symbols): Change type.
  14         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
  15         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
  16         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
  17         Change type of "callback".  Remove "data".
  18
  19
  20 2019-09-09  Ali Tamur  <tamur@google.com>
  21
  22         * dwarf2read.c (comp_unit_head): Update comment.
  23         (dwarf2_dwo_name): New function declaration.
  24         (dwarf_unit_type_name): New function declaration.
  25         (read_comp_unit_head): Add support for new compilation units,
  26         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
  27         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
  28         (currently named as "signature") in their header. Also clarify error
  29         messages.
  30         (lookup_dwo_id): New function. Returns the dwo id of the given
  31         compile unit.
  32         (lookup_dwo_unit): Use the new lookup_dwo_id function.
  33         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
  34         functions.
  35         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
  36         (dwarf2_dwo_name): Get the dwo name if present.
  37         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
  38         purposes.
  39
  40 2019-09-09  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
  43
  44 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  45
  46         * python/python.c (do_start_initialization): Make progname_copy static,
  47         to avoid a leak report.
  48
  49 2019-09-08  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
  52
  53 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
  54
  55         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
  56         Change type to gdb::optional<block_enum>.
  57         (dw2_symtab_iter_init): Change block_index parameter type
  58         to gdb::optional<block_enum>.
  59         (dw2_lookup_symbol): Change block_index parameter
  60         type to block_enum.c
  61         (dw2_debug_names_lookup_symbol): Likewise.
  62         * psymtab.c (psym_lookup_symbol): Likewise.
  63         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
  64         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
  65         Likewise.
  66
  67 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
  68
  69         * defs.h (relocate_gdb_directory): Change int to bool in
  70         signature and rename flag to relocatable.
  71         * main.c (relocate_path): Likewise.
  72         (relocate_gdb_directory): Likewise.
  73
  74 2019-09-06  Alan Modra  <amodra@gmail.com>
  75
  76         * coffread.c (coff_symfile_read): Constify filename variable.
  77         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
  78         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
  79         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
  80         * solib.c (reload_shared_libraries_1): Likewise.
  81         * symfile.c (reread_symbols): Likewise.
  82         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
  83         * solib-darwin.c (darwin_bfd_open): Likewise.
  84         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
  85
  86 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
  87
  88         * psymtab.c (print_partial_symbols): Handle missing domain_enum
  89         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
  90
  91 2019-09-03  Tom Tromey  <tromey@adacore.com>
  92
  93         * ada-valprint.c (ada_val_print_num): Don't recurse for range
  94         types.
  95         (has_negatives): Unbias a range type bound.
  96         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
  97         * gdbtypes.c (operator==): Handle new field.
  98         (create_range_type): Add "bias" parameter.
  99         (create_static_range_type, resolve_dynamic_range): Update.
 100         * gdbtypes.h (struct range_bounds) <bias>: New member.
 101         (create_range_type): Add bias parameter.
 102         * printcmd.c (print_scalar_formatted): Unbias range types.
 103         * value.c (unpack_long): Unbias range types.
 104         (pack_long): Bias range types.
 105
 106 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 107
 108         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 109         probe arguments.
 110
 111 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 112
 113         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 114         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 115         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 116         (compile_probe_arg): Likewise.
 117         * probe.h (get_argument_count): Likewise.
 118         * solib-svr4.c (solib_event_probe_action): Likewise.
 119         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 120
 121 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 122
 123         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 124         code to here...
 125         (svr4_create_solib_event_breakpoints): ...from here.
 126
 127 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 128
 129         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 130         suffix from warning message.
 131
 132 2019-08-30  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui-winsource.h (struct tui_source_window_base)
 135         <refresh_all>: Don't declare.
 136         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 137         Remove.
 138         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 139         tui_show_locator_content.
 140         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 141         declare.
 142         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 143         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 144         declare.
 145
 146 2019-08-30  Tom Tromey  <tom@tromey.com>
 147
 148         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 149
 150 2019-08-30  Tom Tromey  <tom@tromey.com>
 151
 152         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 153         Remove unnecessary forward declarations.
 154
 155 2019-08-30  Tom Tromey  <tom@tromey.com>
 156
 157         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 158         rerender.
 159         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 160         tui_show_locator_content.
 161
 162 2019-08-30  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 165         (tui_locator_window::rerender): Rewrite using body of previous
 166         tui_show_locator_content.
 167
 168 2019-08-30  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 171         set_locator_fullname>: New methods.
 172         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 173         Rename from tui_set_locator_fullname.
 174         (tui_locator_window::set_locator_info): Rename from
 175         tui_set_locator_info.  Return bool.
 176         (tui_update_locator_fullname, tui_show_frame_info): Update.
 177
 178 2019-08-30  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 181
 182 2019-08-30  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 185         call touchwin.
 186
 187 2019-08-30  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-wingeneral.c (box_win): Assume win_info and
 190         win_info->handle cannot be NULL.
 191
 192 2019-08-30  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 195         refresh_window>: Declare.
 196         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 197         resize.
 198         (tui_data_item_window::rerender): Rename from
 199         tui_display_register.
 200         (tui_data_item_window::refresh_window): New method.
 201         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 202         no-op.
 203
 204 2019-08-30  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 207         regs_column_count, current_group>: Move later.  Now private.
 208         <get_current_group>: New method.
 209         * tui/tui-regs.c (tui_reg_command): Update.
 210         * tui/tui-layout.c (tui_set_layout): Update.
 211
 212 2019-08-30  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 215         (tui_data_window::rerender): Don't call
 216         check_and_display_highlight_if_needed.
 217         (tui_data_window::refresh_all): Remove call to
 218         erase_data_content.
 219
 220 2019-08-30  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 223         (tui_data_window::display_registers_from)
 224         (tui_data_window::display_reg_element_at_line)
 225         (tui_data_window::display_registers_from_line): Remove checks of
 226         "empty".
 227
 228 2019-08-30  Tom Tromey  <tom@tromey.com>
 229
 230         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 231         Don't declare.
 232         * tui/tui-regs.c (tui_data_window::show_registers): Call
 233         rerender.
 234         (tui_data_window::rerender): Rename from display_all_data.
 235         (tui_data_window::rerender): Remove old implementation.
 236
 237 2019-08-30  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 240         text.
 241         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 242
 243 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 244             Sergio Durigan Junior  <sergiodj@redhat.com>
 245
 246         PR win32/24284
 247         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 248
 249 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 250
 251         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 252         when searching for types.
 253
 254 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 255
 256         * f-lang.c (f_language_defn): Use f_print_typedef.
 257         * f-lang.h (f_print_typedef): Declare.
 258         * f-typeprint.c (f_print_typedef): Define.
 259
 260 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 261
 262         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 263
 264 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 265
 266         * cli/cli-utils.c (info_print_options_defs): Delete.
 267         (make_info_print_options_def_group): Delete.
 268         (extract_info_print_options): Delete.
 269         (info_print_command_completer): Delete.
 270         (info_print_args_help): Add extra parameter, and optionally
 271         include text about -n flag.
 272         * cli/cli-utils.h (struct info_print_options): Delete.
 273         (extract_info_print_options): Delete declaration.
 274         (info_print_command_completer): Delete declaration.
 275         (info_print_args_help): Add extra parameter, extend header
 276         comment.
 277         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 278         search_symbols.
 279         * stack.c (struct info_print_options): New type.
 280         (info_print_options_defs): New file scoped variable.
 281         (make_info_print_options_def_group): New static function.
 282         (info_print_command_completer): New static function.
 283         (info_locals_command): Update to use new local functions.
 284         (info_args_command): Likewise.
 285         (_initialize_stack): Add extra parameter to calls to
 286         info_print_args_help.
 287         * symtab.c (search_symbols): Add extra parameter, use this to
 288         possibly excluse non-debug symbols.
 289         (symtab_symbol_info): Add extra parameter, which is passed on to
 290         search_symbols.
 291         (struct info_print_options): New type.
 292         (info_print_options_defs): New file scoped variable.
 293         (make_info_print_options_def_group): New static function.
 294         (info_print_command_completer): New static function.
 295         (info_variables_command): Update to use local functions, and pass
 296         extra parameter through to symtab_symbol_info.
 297         (info_functions_command): Likewise.
 298         (info_types_command): Pass additional argument through to
 299         symtab_symbol_info.
 300         (rbreak_command): Pass extra argument to search_symbols.
 301         (_initialize_symtab): Add extra arguments for calls to
 302         info_print_args_help, and update help text for 'info variables',
 303         'whereis', and 'info functions' commands.
 304         * symtab.h (search_symbols): Add extra argument to declaration.
 305         * NEWS: Mention new flags.
 306
 307 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 308
 309         * symtab.c (lookup_static_symbol): Call the new function (and move
 310         it down to be next to lookup_global_symbol).
 311         (struct global_sym_lookup_data): Add block_enum member and rename to...
 312         (struct global_or_static_sym_lookup_data): ...this.
 313         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 314         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 315         (lookup_symbol_global_or_static_iterator_cb): ...this.
 316         (lookup_global_or_static_symbol): New function.
 317         (lookup_global_symbol): Call new function.
 318
 319 2019-08-26  Tom de Vries  <tdevries@suse.de>
 320
 321         PR c++/24852
 322         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 323         when pc_probe.prob == NULL.
 324
 325 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 326
 327         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 328         variable symbol_linkage to symbol_linkage_.
 329
 330 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 331
 332         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 333         represent whether the symbol is static, dynamic, or we don't
 334         know.
 335
 336 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 337
 338         * gdb/rx-tdep.c (rx_register_names): New.
 339         (rx_register_name): Delete.
 340         (rx_psw_type): Delete.
 341         (rx_fpsw_type): Delete.
 342         (rx_register_type): Delete.
 343         (rx_gdbarch_init): Convert target-descriptions.
 344         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 345         * gdb/features/Makefile: Add rx.xml.
 346         * gdb/features/rx.xml: New.
 347         * gdb/features/rx.c: Generated.
 348         * gdb/NEWS: Mention target description support.
 349
 350 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 351
 352         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 353         *slot_ptr.
 354
 355 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 356
 357         * configure.ac: Don't check for 'dlfcn.h' (moved to
 358         gdbsupport/common.m4).
 359         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 360         'gdbsupport/'.
 361         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 362         * compile/compile-c-support.c: Include
 363         'gdbsupport/gdb-dlfcn.h'.
 364         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 365         * gdb-dlfcn.c: Move to...
 366         * gdbsupport/gdb-dlfcn.c: ... here.
 367         * gdb-dlfcn.h: Move to...
 368         * gdbsupport/gdb-dlfcn.h: ... here.
 369
 370 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 371
 372         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 373         the offset field signed.
 374
 375 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 376
 377         * python/lib/gdb/__init__.py (_execute_file): New function.
 378         * python/python.c (python_run_simple_file): Call gdb._execute_file
 379         on Windows.
 380
 381 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 382
 383         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 384         all uses as this was never set to anything but a zero value.
 385
 386 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 387
 388         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 389
 390 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 391
 392         * tui/tui-data.h (tui_gen_win_info): Add an =default
 393         move constructor, required by some GCC versions.
 394
 395 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 396
 397         * go32-nat.c (go32_sysinfo): Add hygon_p.
 398
 399 2019-08-20  Tom Tromey  <tom@tromey.com>
 400
 401         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 402         line_from_reg_element_no, first_reg_element_no_inline,
 403         display_all_data, delete_data_content_windows,
 404         erase_data_content>: Now private.
 405
 406 2019-08-20  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 409         (tui_unhighlight_win, tui_highlight_win)
 410         (tui_win_info::make_window): Update.
 411         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 412
 413 2019-08-20  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 416         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 417         (MAX_PID_WIDTH): Move to tui-stack.c.
 418         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 419         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 420         (MAX_PID_WIDTH): Move from tui-data.h.
 421
 422 2019-08-20  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 425         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 426         (box_win): Update.
 427         (tui_gen_win_info::make_window): Rename from tui_make_window.
 428         (tui_win_info::make_window): New method.
 429         (tui_gen_win_info::make_visible): Update.
 430         * tui/tui-source.c (tui_source_window::set_contents): Update.
 431         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 432         (tui_data_window::display_registers_from): Update.
 433         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 434         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 435         Declare.
 436         <can_box>: Remove.
 437         <title>: Remove.
 438         (struct tui_win_info) <make_window>: Declare.
 439         <can_box>: Now virtual.
 440         <title>: New member.
 441         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 442         * tui/tui-command.c (tui_cmd_window::resize): Update.
 443
 444 2019-08-20  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 447         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 448         (tui_data_window::check_register_values): Update.
 449
 450 2019-08-20  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-regs.h (struct tui_data_window): Use
 453         DISABLE_COPY_AND_ASSIGN.
 454         <regs_content>: Change type, removing unique_ptr.
 455         <tui_data_window>: Add move constructor.
 456         * tui/tui-regs.c (tui_data_window::show_registers)
 457         (tui_data_window::show_register_group)
 458         (tui_data_window::display_registers_from)
 459         (tui_data_window::display_registers_from)
 460         (tui_data_window::first_data_item_displayed)
 461         (tui_data_window::delete_data_content_windows)
 462         (tui_data_window::rerender, tui_data_window::refresh_window)
 463         (tui_data_window::check_register_values): Update.
 464
 465 2019-08-20  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 468         show_register_group>: Declare.
 469         (tui_show_register_group): Don't declare.
 470         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 471         tui_show_registers.
 472         (tui_data_window::show_register_group): Rename from
 473         tui_show_register_group.
 474         (tui_data_window::check_register_values, tui_reg_command):
 475         Update.
 476         * tui/tui-layout.c (tui_set_layout): Update.
 477
 478 2019-08-20  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 481         Declare.
 482         (tui_check_register_values): Don't declare.
 483         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 484         from tui_check_register_values.
 485         * tui/tui-hooks.c (tui_register_changed): Update.
 486
 487 2019-08-20  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-regs.c (tui_reg_layout): Move later.
 490         (tui_show_registers): Don't enable TUI mode or change layout.
 491
 492 2019-08-20  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-regs.h (struct tui_data_item_window)
 495         <~tui_data_item_window>: Remove.
 496         <content>: Now a unique_xmalloc_ptr.
 497         * tui/tui-regs.c (tui_register_format): Return a
 498         unique_xmalloc_ptr.
 499         (tui_get_register): Update.
 500         (~tui_data_item_window): Remove.
 501         (tui_data_window::display_registers_from, tui_display_register):
 502         Update.
 503         * tui/tui-io.h (tui_expand_tabs): Update.
 504         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 505         Remove "col" parameter.
 506
 507 2019-08-20  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 510         field.
 511         * tui/tui-regs.c (~tui_data_item_window): Update.
 512
 513 2019-08-20  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 516         earlier.
 517
 518 2019-08-20  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 521
 522 2019-08-20  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-source.h (struct tui_source_window): Update.
 525         * tui/tui-regs.c (tui_show_registers): Update.
 526         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 527         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 528         (NO_REGS_STRING): Remove defines.
 529
 530 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 531
 532         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 533         unnecessary thread walk if remote doesn't support the packet.
 534
 535 2019-08-19  Tom Tromey  <tromey@adacore.com>
 536
 537         * python/py-value.c (value_has_field): Fix indentation.
 538
 539 2019-08-19  Tom Tromey  <tromey@adacore.com>
 540
 541         * printcmd.c (do_one_display, info_display_command): Update.
 542         * block.h (contained_in): Return bool.  Add allow_nested
 543         parameter.
 544         * block.c (contained_in): Return bool.  Add allow_nested
 545         parameter.
 546
 547 2019-08-19  Tom Tromey  <tom@tromey.com>
 548
 549         * configure: Rebuild.
 550         * configure.ac: Disallow the combination of -static-libstdc++ and
 551         source highlight.
 552         * source-cache.c (get_language_name): Handle rust.
 553         (source_cache::get_source_lines): Ignore highlighting exceptions.
 554
 555 2019-08-16  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 558         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 559         (struct tui_source_window_base) <make_visible, refresh_window,
 560         resize>: Remove methods.
 561         <execution_info>: Remove field.
 562         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 563         (tui_show_source_line, tui_source_window_base)
 564         (~tui_source_window_base): Update.
 565         (tui_source_window_base::resize)
 566         (tui_source_window_base::make_visible)
 567         (tui_source_window_base::refresh_window): Remove.
 568         (tui_source_window_base::update_exec_info): Update.
 569         * tui/tui-source.c (tui_source_window::set_contents): Update.
 570         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 571
 572 2019-08-16  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 575         deprecated_query_hook.
 576
 577 2019-08-16  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 580         (tui_update_source_windows_with_line): Update.
 581         * tui/tui-source.h (struct tui_source_window)
 582         <show_symtab_source>: Declare.
 583         (tui_show_symtab_source): Don't declare.
 584         * tui/tui-source.c (tui_show_symtab_source): Rename from
 585         tui_show_symtab_source.
 586
 587 2019-08-16  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-winsource.h (struct tui_source_window_base)
 590         <set_contents>: Declare.
 591         * tui/tui-winsource.c
 592         (tui_source_window_base::update_source_window_as_is): Update.
 593         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 594         Declare.
 595         (tui_set_source_content): Don't declare.
 596         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 597         tui_set_source_content.
 598         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 599         Declare.
 600         (tui_set_disassem_content): Don't declare.
 601         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 602         tui_set_disassem_content.
 603
 604 2019-08-16  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-winsource.h (struct tui_source_window_base)
 607         <update_breakpoint_info>: Declare.
 608         (tui_update_breakpoint_info): Don't declare.
 609         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 610         (tui_update_all_breakpoint_info): Update.
 611         (tui_source_window_base::update_breakpoint_info): Rename from
 612         tui_update_breakpoint_info.
 613         (tui_source_window_base::update_exec_info): Update.
 614
 615 2019-08-16  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-winsource.h (struct tui_source_window_base)
 618         <update_source_window>: Declare.
 619         (tui_update_source_window): Don't declare.
 620         * tui/tui-winsource.c
 621         (tui_source_window_base::update_source_window): Rename from
 622         tui_update_source_window.
 623         (tui_source_window_base::rerender): Update.
 624         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 625         * tui/tui-disasm.c (tui_show_disassem)
 626         (tui_show_disassem_and_update_source)
 627         (tui_disasm_window::maybe_update): Update.
 628
 629 2019-08-16  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-winsource.h (struct tui_source_window_base)
 632         <update_source_window_as_is>: Declare.
 633         (tui_update_source_window_as_is): Don't declare.
 634         * tui/tui-winsource.c (tui_update_source_window): Update
 635         (tui_source_window_base::update_source_window_as_is): Rename from
 636         tui_update_source_window_as_is.
 637         (tui_source_window_base::refill): Update.
 638         * tui/tui-source.c (tui_show_symtab_source): Update.
 639         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 640         Update.
 641
 642 2019-08-16  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-winsource.h (tui_update_source_window)
 645         (tui_update_source_window_as_is): Remove "noerror" parameter.
 646         * tui/tui-winsource.c (tui_update_source_window)
 647         (tui_update_source_window_as_is): Remove "noerror" parameter.
 648         (tui_update_source_windows_with_addr)
 649         (tui_update_source_windows_with_line)
 650         (tui_source_window_base::rerender)
 651         (tui_source_window_base::refill): Update.
 652         * tui/tui-source.h (tui_set_source_content)
 653         (tui_show_symtab_source): Remove "noerror" parameter.
 654         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 655         parameter.
 656         (tui_show_symtab_source): Likewise.
 657         (tui_source_window::maybe_update): Update.
 658         * tui/tui-disasm.c (tui_show_disassem)
 659         (tui_show_disassem_and_update_source)
 660         (tui_disasm_window::do_scroll_vertical)
 661         (tui_disasm_window::maybe_update): Update.
 662
 663 2019-08-16  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui.c (tui_is_window_visible): Update.
 666         * tui/tui-wingeneral.c (tui_make_window)
 667         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 668         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 669         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 670         (tui_set_win_height_command, parse_scrolling_args): Update.
 671         * tui/tui-source.c (tui_source_window::style_changed): Update.
 672         * tui/tui-regs.c (tui_show_registers)
 673         (tui_data_window::first_data_item_displayed)
 674         (tui_data_window::delete_data_content_windows)
 675         (tui_check_register_values, tui_reg_command): Update.
 676         * tui/tui-disasm.c (tui_show_disassem): Update.
 677         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 678         method.
 679         <is_visible>: Remove field.
 680         * tui/tui-data.c (tui_next_win, tui_prev_win)
 681         (tui_delete_invisible_windows): Update.
 682
 683 2019-08-16  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-winsource.h (struct tui_source_window_base)
 686         <m_has_locator>: Remove.
 687         * tui/tui-layout.c (show_source_disasm_command, show_data)
 688         (show_source_or_disasm_and_command): Update.
 689
 690 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 691
 692         * NEWS (Other MI changes): New subsection.
 693         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 694         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 695         * arch-utils.c (default_get_pc_address_flags): New function.
 696         * arch-utils.h (default_get_pc_address_flags): New declaration.
 697         * gdbarch.sh: Add get_pc_address_flags.
 698         * gdbarch.c: Regenerate.
 699         * gdbarch.h: Likewise.
 700         * stack.c (print_pc): New function.
 701         (print_frame_info) (print_frame): Call print_pc.
 702
 703 2019-08-16  Tom de Vries  <tdevries@suse.de>
 704
 705         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 706         print_objfile_section_info.
 707
 708 2019-08-15  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 711         calling update_cmdwin_start_line.
 712         * tui/tui-winsource.h (struct tui_source_window_base)
 713         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 714         <rerender>: Declare.
 715         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 716         Call rerender.
 717         (tui_source_window_base::set_new_height): Remove.
 718         (tui_source_window_base::rerender): Rename from
 719         do_make_visible_with_new_height.
 720         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 721         resize method.
 722         (tui_win_info::make_invisible_and_set_new_height)
 723         (tui_win_info::make_visible_with_new_height): Remove.
 724         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 725         Declare.
 726         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 727         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 728         do_make_visible_with_new_height>: Don't declare.
 729         <rerender>: Declare.
 730         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 731         set_new_height.
 732         (tui_data_window::do_make_visible_with_new_height): Remove.
 733         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 734         call tui_show_locator_content.
 735         (tui_gen_win_info::resize): Call rerender.
 736         (show_source_or_disasm_and_command): Don't call
 737         tui_show_locator_content.
 738         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 739         method.
 740         (struct tui_win_info) <rerender>: Declare.
 741         <set_new_height, make_invisible_and_set_new_height,
 742         make_visible_with_new_height>: Don't declare.
 743         * tui/tui-data.c (tui_win_list::rerender): New method.
 744         * tui/tui-command.h (struct tui_cmd_window)
 745         <do_make_visible_with_new_height>: Don't declare.
 746         * tui/tui-command.c
 747         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 748
 749 2019-08-15  Tom Tromey  <tromey@adacore.com>
 750
 751         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 752         * ada-lang.c (ada_enum_name): Likewise.
 753
 754 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 755
 756         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 757         leading underscore.
 758         (GdbOutputErrorFile): Likewise.
 759         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 760         accordingly.
 761         (execute_unwinders): Rename to have a leading underscore.
 762         (auto_load_packages): Likewise.
 763         (global scope): Adjust call to auto_load_packages accordingly.
 764         (GdbSetPythonDirectory): Likewise.
 765         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 766         instead of execute_unwinders.
 767
 768 2019-08-15  Tom Tromey  <tom@tromey.com>
 769
 770         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 771         (show_data): Don't change window visibility.
 772         (tui_gen_win_info::resize): Remove special case for command
 773         window.  Use wresize, when available.
 774         (show_source_or_disasm_and_command): Don't change window
 775         visibility.
 776         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 777         <make_visible>: New method.
 778         * tui/tui-command.c (tui_cmd_window::resize): New method.
 779
 780 2019-08-15  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 783         (struct tui_source_windows): New.
 784         * tui/tui-winsource.c (tui_display_main): Update.
 785         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 786         (new_height_ok, parse_scrolling_args): Update.
 787         * tui/tui-layout.c (show_layout, show_data): Update.
 788         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 789         (tui_add_to_source_windows): Don't declare.
 790         * tui/tui-data.c (source_windows, tui_source_windows)
 791         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 792
 793 2019-08-15  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 796         Rename from reset.
 797         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 798         * tui/tui-layout.c (show_source_disasm_command, show_data):
 799         Update.
 800         (tui_gen_win_info::resize): Rename.
 801         (show_source_or_disasm_and_command): Update.
 802         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 803         reset.
 804
 805 2019-08-15  Tom Tromey  <tom@tromey.com>
 806
 807         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 808         * tui/tui-interp.c (tui_interp::init): Don't call
 809         tui_initialize_static_data.
 810         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 811
 812 2019-08-15  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 815         examine tui_win_list.
 816
 817 2019-08-15  Tom Tromey  <tom@tromey.com>
 818
 819         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 820         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 821         tui_clear_source_content.
 822         (tui_clear_source_content): Remove.
 823         (tui_source_window_base::do_erase_source_content): Hoist call to
 824         content.clear().
 825         * tui/tui-stack.c (tui_show_frame_info): Don't call
 826         tui_clear_source_content.
 827
 828 2019-08-15  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-winsource.h (struct tui_source_window_base)
 831         <do_erase_source_content>: New method.
 832         <erase_source_content>: New method.
 833         (tui_erase_source_content): Don't declare.
 834         * tui/tui-winsource.c (tui_clear_source_content): Update.
 835         (tui_source_window_base::do_erase_source_content): Rename from
 836         tui_erase_source_content.
 837         (tui_source_window_base::show_source_content): Update.
 838         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 839         * tui/tui-source.h (struct tui_source_window)
 840         <erase_source_content>: New method.
 841         * tui/tui-disasm.h (struct tui_disasm_window)
 842         <erase_source_content>: New method.
 843
 844 2019-08-15  Tom Tromey  <tom@tromey.com>
 845
 846         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 847         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 848         constructor.
 849         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 850         * tui/tui-source.c (tui_set_source_content): Update.
 851         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 852
 853 2019-08-15  Tom Tromey  <tom@tromey.com>
 854
 855         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 856         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 857         tui-source.c.
 858         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 859         Declare.
 860         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 861         method.
 862         (tui_source_window::maybe_update): Update.
 863
 864 2019-08-15  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 867         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 868         tui-disasm.c.
 869         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 870         Declare.
 871         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 872         method.
 873         (tui_disasm_window::maybe_update): Update.
 874
 875 2019-08-15  Tom Tromey  <tom@tromey.com>
 876
 877         * tui/tui-winsource.h (struct tui_source_window_base)
 878         <maybe_update>: Declare.
 879         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 880         method.
 881         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 882         Declare.
 883         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 884         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 885         Declare.
 886         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 887
 888 2019-08-15  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 891
 892 2019-08-15  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-wingeneral.c: Include tui-stack.h.
 895         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 896         (struct tui_locator_window): Move from tui-data.h.
 897         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 898         (tui_initialize_static_data): Move from tui-data.c.
 899         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 900         (struct tui_locator_window): Move to tui-stack.c.
 901         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 902         (tui_initialize_static_data): Move to tui-stack.c.
 903
 904 2019-08-15  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-layout.c (show_source_disasm_command)
 907         (show_source_or_disasm_and_command): Use make_visible method, not
 908         tui_make_window.
 909         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 910         Remove.
 911
 912 2019-08-15  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-wingeneral.h (tui_make_window): Update.
 915         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 916         parameter.
 917         (tui_gen_win_info::make_visible): Update.
 918         * tui/tui-regs.c (tui_data_window::display_registers_from):
 919         Update.
 920         * tui/tui-layout.c (show_source_disasm_command)
 921         (show_source_or_disasm_and_command): Update.
 922         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 923         (enum tui_box): Remove.
 924         (struct tui_win_info) <can_box>: New method.
 925         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 926         method.
 927
 928 2019-08-15  Tom de Vries  <tdevries@suse.de>
 929
 930         * linux-nat-trad.c: Include gdbarch.h.
 931
 932 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 933
 934         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 935         register sizes.
 936
 937 2019-08-14  Tom Tromey  <tromey@adacore.com>
 938
 939         * darwin-nat.c: Include gdbarch.h.
 940         * darwin-nat-info.c: Include gdbarch.h.
 941
 942 2019-08-13  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 945         Remove.
 946         * tui/tui-data.c (tui_initialize_static_data): Update.
 947
 948 2019-08-13  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-winsource.h (struct tui_exec_info_window)
 951         <~tui_exec_info_window, maybe_allocate_content, get_content,
 952         m_content>: Remove.
 953         (struct tui_source_window_base) <set_exec_info_content,
 954         show_exec_info_content>: Don't declare.
 955         * tui/tui-winsource.c
 956         (tui_exec_info_window::maybe_allocate_content): Remove.
 957         (tui_source_window_base::update_exec_info): Rename from
 958         set_exec_info_content.
 959         (tui_source_window_base::show_exec_info_content)
 960         (tui_source_window_base::update_exec_info): Remove.
 961
 962 2019-08-13  Tom Tromey  <tom@tromey.com>
 963
 964         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 965         declare.
 966         * tui/tui-winsource.c (tui_update_source_window_as_is)
 967         (tui_update_source_windows_with_addr, tui_erase_source_content):
 968         Update.
 969         (tui_clear_exec_info_content): Remove.
 970
 971 2019-08-13  Tom Tromey  <tom@tromey.com>
 972
 973         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 974         declare.
 975         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 976         call tui_erase_exec_info_content.
 977         (tui_clear_exec_info_content): Rename from
 978         tui_erase_exec_info_content.
 979         (tui_clear_exec_info_content): Delete.
 980
 981 2019-08-13  Tom Tromey  <tom@tromey.com>
 982
 983         * tui/tui-winsource.h (struct tui_source_window_base)
 984         <show_exec_info_content>: Declare.
 985         (tui_show_exec_info_content): Don't declare.
 986         * tui/tui-winsource.c
 987         (tui_source_window_base::show_exec_info_content): Rename from
 988         tui_show_exec_info_content.
 989         (tui_source_window_base::update_exec_info): Update.
 990
 991 2019-08-13  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 994         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 995         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 996         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 997         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 998         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 999         ... here.
1000
1001 2019-08-13  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui-winsource.h (struct tui_source_window_base)
1004         <update_exec_info>: Declare.
1005         (tui_update_exec_info): Don't declare.
1006         * tui/tui-winsource.c (tui_update_source_window_as_is)
1007         (tui_source_window_base::refresh_all)
1008         (tui_update_all_breakpoint_info): Update.
1009         (tui_source_window_base::update_exec_info): Rename from
1010         tui_update_exec_info.
1011         * tui/tui-stack.c (tui_show_frame_info): Update.
1012
1013 2019-08-13  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-winsource.h (struct tui_source_window_base)
1016         <set_exec_info_content>: Declare.
1017         (tui_set_exec_info_content): Don't declare.
1018         * tui/tui-winsource.c
1019         (tui_source_window_base::set_exec_info_content): Rename from
1020         tui_set_exec_info_content.
1021         (tui_update_exec_info): Update.
1022
1023 2019-08-13  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-winsource.h (struct tui_source_window_base)
1026         <show_source_content>: Declare.
1027         (tui_show_source_content): Don't declare.
1028         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1029         (tui_source_window_base::show_source_content): Rename from
1030         tui_show_source_content.
1031         (tui_source_window_base::refresh_all): Update.
1032         * tui/tui-layout.c (show_source_disasm_command)
1033         (show_source_or_disasm_and_command): Update.
1034
1035 2019-08-13  Tom Tromey  <tom@tromey.com>
1036
1037         * tui/tui-winsource.c (tui_erase_source_content)
1038         (tui_show_source_content, tui_source_window_base::refresh_all):
1039         Update.
1040         * tui/tui-wingeneral.h
1041         (tui_check_and_display_highlight_if_needed): Don't declare.
1042         * tui/tui-wingeneral.c
1043         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1044         check_and_display_highlight_if_needed.
1045         * tui/tui-win.c (tui_rehighlight_all)
1046         (tui_win_info::make_visible_with_new_height): Update.
1047         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1048         (tui_data_window::erase_data_content)
1049         (tui_data_window::display_all_data): Update.
1050         * tui/tui-data.h (struct tui_win_info)
1051         <check_and_display_highlight_if_needed>: Declare.
1052
1053 2019-08-13  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-win.c (tui_resize_all): Call
1056         tui_delete_invisible_windows.
1057         * tui/tui-layout.c (show_layout): Call
1058         tui_delete_invisible_windows.
1059         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1060         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1061
1062 2019-08-13  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1065         tui_add_win_to_layout.
1066
1067 2019-08-13  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1070         * tui/tui-layout.c (tui_default_win_height): Now static.
1071
1072 2019-08-13  Tom Tromey  <tom@tromey.com>
1073
1074         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1075         single switch.
1076         (show_source_disasm_command, show_source_or_disasm_and_command):
1077         Don't check current layout.
1078
1079 2019-08-13  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-wingeneral.c (make_all_visible): Remove.
1082         (tui_make_all_invisible): Simplify.
1083         * tui/tui-layout.c (tui_make_all_invisible): Move from
1084         tui-wingeneral.c; simplify.
1085         (show_layout): Hoist call to tui_make_all_invisible.
1086         (show_data): Don't call tui_make_all_invisible.
1087
1088 2019-08-13  Tom Tromey  <tom@tromey.com>
1089
1090         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1091         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1092
1093 2019-08-13  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1096         tui-data.c.
1097         (show_source_disasm_command, show_data)
1098         (show_source_or_disasm_and_command): Don't use
1099         tui_set_current_layout_to.
1100         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1101         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1102         tui-layout.c.
1103         (tui_set_current_layout_to): Remove.
1104
1105 2019-08-13  Tom Tromey  <tom@tromey.com>
1106
1107         * tui/tui-layout.c (tui_set_layout): Update.
1108         * tui/tui-data.h (struct tui_layout_def): Remove.
1109         (tui_layout_def): Don't declare.
1110         * tui/tui-data.c (layout_def): Remove.
1111         (tui_layout_def): Remove.
1112
1113 2019-08-13  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-winsource.h (struct tui_source_window_base)
1116         <clear_detail>: No longer "override".
1117         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1118         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1119         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1120         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1121         Remove.
1122         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1123
1124 2019-08-13  Tom Tromey  <tromey@adacore.com>
1125
1126         * tracepoint.c: Don't include readline.h or history.h.
1127
1128 2019-08-12  Tom Tromey  <tom@tromey.com>
1129
1130         * configure: Rebuild.
1131         * configure.ac: Check for readline 7.
1132         * NEWS: Mention readline 7 requirement.
1133         * README: Update.
1134
1135 2019-08-12  Tom Tromey  <tom@tromey.com>
1136
1137         * mingw-hdep.c (gdb_select): Remove readline hack.
1138
1139 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1140
1141         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1142         when the function fails.
1143
1144 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1145
1146         * s390-tdep.c (s390_type_align): New function.
1147         (s390_gdbarch_init): Set it as type_align gdbarch method.
1148
1149 2019-08-09  Tom de Vries  <tdevries@suse.de>
1150
1151         PR gdb/24591
1152         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1153         pc_low with relocation offset.
1154
1155 2019-08-07  Tom Tromey  <tromey@adacore.com>
1156
1157         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1158         (print_frame_args): Update.
1159         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1160         Update.
1161         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1162         * frame.h (struct frame_arg): Add initializers.
1163         <error>: Now a unique_xmalloc_ptr.
1164
1165 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1166
1167         * NEWS: Expand the Pointer Authentication entry.
1168         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1169         (aarch64_frame_unmask_lr): ... to this.
1170         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1171         Call aarch64_frame_unmask_lr.
1172         * frame.c (struct frame_info): Add "masked" variable.
1173         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1174         (fprint_frame): Check for masked pc.
1175         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1176         declarations.
1177         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1178         * stack.c (print_frame): Check for masked pc.
1179
1180 2019-08-06  Tom Tromey  <tom@tromey.com>
1181
1182         * stabsread.c (patch_block_stabs, read_one_struct_field)
1183         (read_enum_type): Use obstack_strndup.
1184         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1185         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1186         * dwarf2read.c (guess_full_die_structure_name)
1187         (anonymous_struct_prefix): Use obstack_strndup.
1188         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1189         * c-exp.y (yylex): Use obstack_strndup.
1190         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1191         (write_var_or_type): Use obstack_strndup.
1192
1193 2019-08-06  Tom Tromey  <tom@tromey.com>
1194
1195         * symfile.c (reread_symbols): Use obstack_strdup.
1196         * stabsread.c (read_type): Use obstack_strdup.
1197         * gdb_obstack.h (obstack_strdup): New overload.
1198         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1199         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1200         (dwarf2_canonicalize_name): Use obstack_strdup.
1201         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1202         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1203         Use obstack_strdup.
1204
1205 2019-08-06  Tom Tromey  <tom@tromey.com>
1206
1207         * gdb_obstack.h (obstack_strdup): Define.
1208         * gdb_obstack.c (obstack_strdup): Don't define.
1209
1210 2019-08-06  Tom Tromey  <tom@tromey.com>
1211
1212         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1213         obstack_strdup.
1214         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1215         obstack_strdup.
1216         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1217         * stabsread.c (common_block_start): Use obstack_strdup.
1218         * objfiles.c (set_objfile_main_name, objfile): Use
1219         obstack_strdup.
1220         * namespace.c (add_using_directive): Use obstack_strdup.
1221         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1222         * jit.c (finalize_symtab): Use obstack_strdup.
1223         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1224         (guess_partial_die_structure_name, partial_die_info::fixup)
1225         (dwarf2_name): Use obstack_strdup.
1226         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1227         obstack_strdup.
1228         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1229         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1230         obstack_strdup.
1231         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1232
1233 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1234
1235         * unittests/help-doc-selftests.c: New file.
1236         * Makefile.in: Add the new file.
1237
1238 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1239
1240         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1241         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1242         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1243         the trailing '.' is not output, and the first character is uppercased.
1244         (print_help_for_command): Update call to print_doc_line.
1245         (print_doc_of_command): Likewise.
1246         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1247         * cli/cli-option.c (append_indented_doc): Do not append newline.
1248         (build_help_option): Append newline after first appended_indented_doc
1249         only if a second call is done.
1250         (build_help): Append 2 new lines before each option, except the first
1251         one.
1252         * compile/compile.c (_initialize_compile): Add new lines after
1253         %OPTIONS%, when not at the end of the help.
1254         Change help doc or code
1255         producing the help doc to respect the invariants.
1256         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1257         Also removed the new line after 'Options:', as all other commands
1258         do not put an empty line between 'Options:' and the first option.
1259         * printcmd.c (_initialize_printcmd): Likewise.
1260         * stack.c (_initialize_stack): Likewise.
1261         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1262         incorrectly telling COMMAND is optional.
1263         * ada-lang.c (_initialize_ada_language): Change help doc or code
1264         producing the help doc to respect the invariants.
1265         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1266         * breakpoint.c (_initialize_breakpoint): Likewise.
1267         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1268         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1269         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1270         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1271         _initialize_cli_style): Likewise.
1272         * corelow.c (core_target_info): Likewise.
1273         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1274         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1275         * filesystem.c (_initialize_filesystem): Likewise.
1276         * frame.c (_initialize_frame): Likewise.
1277         * gnu-nat.c (add_task_commands): Likewise.
1278         * infcall.c (_initialize_infcall): Likewise.
1279         * infcmd.c (_initialize_infcmd): Likewise.
1280         * interps.c (_initialize_interpreter): Likewise.
1281         * language.c (_initialize_language): Likewise.
1282         * linux-fork.c (_initialize_linux_fork): Likewise.
1283         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1284         * maint.c (_initialize_maint_cmds): Likewise.
1285         * memattr.c (_initialize_mem): Likewise.
1286         * printcmd.c (_initialize_printcmd): Likewise.
1287         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1288         _RegEx): Likewise.
1289         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1290         * record-btrace.c (_initialize_record_btrace): Likewise.
1291         * record-full.c (_initialize_record_full): Likewise.
1292         * record.c (_initialize_record): Likewise.
1293         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1294         * regcache.c (_initialize_regcache): Likewise.
1295         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1296         _initialize_remote): Likewise.
1297         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1298         * serial.c (_initialize_serial): Likewise.
1299         * skip.c (_initialize_step_skip): Likewise.
1300         * source.c (_initialize_source): Likewise.
1301         * stack.c (_initialize_stack): Likewise.
1302         * symfile.c (_initialize_symfile): Likewise.
1303         * symtab.c (_initialize_symtab): Likewise.
1304         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1305         * top.c (init_main): Likewise.
1306         * tracefile-tfile.c (tfile_target_info): Likewise.
1307         * tracepoint.c (_initialize_tracepoint): Likewise.
1308         * tui/tui-win.c (_initialize_tui_win): Likewise.
1309         * utils.c (add_internal_problem_command): Likewise.
1310         * valprint.c (value_print_option_defs): Likewise.
1311
1312 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1313
1314         PR build/24886
1315         * configure.ac: Drop enable-libmcheck support.
1316         * configure, config.in: Rebuild.
1317         * libmcheck.m4: Remove.
1318         * acinclude.m4: Don't include it.
1319         * Makefile.in: Don't distribute it.
1320         * top.c (print_gdb_configuration): Don't mention it.
1321
1322 2019-08-06  Tom Tromey  <tom@tromey.com>
1323
1324         * utils.c (set_output_style): Sometimes pass stream to
1325         emit_style_escape.
1326         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1327         * record-btrace.c (btrace_insn_history): Update.
1328         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1329         method.
1330         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1331         Update initializers.
1332         <m_uiout>: New field.
1333         <m_di>: Move lower.
1334         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1335         Remove "uiout" parameter.
1336         (dump_insns): Update.
1337         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1338         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1339
1340 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1341
1342         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1343         (error_in_psymtab_expansion): Likewise.
1344         (lookup_symbol_via_quick_fns): Likewise.
1345         (basic_lookup_transparent_type_quick): Likewise.
1346         (basic_lookup_transparent_type_1): Likewise.
1347
1348 2019-08-06  Tom Tromey  <tromey@adacore.com>
1349
1350         * source.c (last_source_error): Now bool.
1351         (print_source_lines_base): Make "noprint" bool.  Only open
1352         source file when last_source_visited changes.
1353
1354 2019-08-06  Tom Tromey  <tromey@adacore.com>
1355
1356         * annotate.c (annotate_source_line): Use g_source_cache.
1357         * source-cache.c (source_cache::get_plain_source_lines): Change
1358         parameters.  Populate m_offset_cache.
1359         (source_cache::ensure): New method.
1360         (source_cache::get_line_charpos): New method.
1361         (extract_lines): Move lower.  Change parameters.
1362         (source_cache::get_source_lines): Move lower.
1363         * source-cache.h (class source_cache): Update comment.
1364         <get_line_charpos>: New method.
1365         <get_source_lines>: Update comment.
1366         <clear>: Clear m_offset_cache.
1367         <get_plain_source_lines>: Change parameters.
1368         <ensure>: New method
1369         <m_offset_cache>: New member.
1370         * source.c (forget_cached_source_info_for_objfile): Update.
1371         (info_source_command): Use g_source_cache.
1372         (find_source_lines, open_source_file_with_line_charpos): Remove.
1373         (print_source_lines_base, search_command_helper): Use g_source_cache.
1374         * source.h (open_source_file_with_line_charpos): Don't declare.
1375         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1376         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1377         Use g_source_cache.
1378
1379 2019-08-06  Tom Tromey  <tromey@adacore.com>
1380
1381         * source-cache.c (source_cache::get_plain_source_lines):
1382         Remove "first_line" and "last_line" parameters.
1383         (source_cache::get_source_lines): Cache plain text.
1384         * source-cache.h (class source_cache)
1385         <get_plain_source_lines>: Update.
1386
1387 2019-08-06  Tom Tromey  <tromey@adacore.com>
1388
1389         * source-cache.c (extract_lines): No longer a method.
1390         Changed type of parameter.  Include final newline.
1391         (selftests::extract_lines_test): New function.
1392         (_initialize_source_cache): Likewise.
1393         * source-cache.h (class source_cache)
1394         <extract_lines>: Don't declare.
1395
1396 2019-08-06  Tom Tromey  <tromey@adacore.com>
1397
1398         * breakpoint.c (init_breakpoint_sal): Update.
1399         (breakpoint): Update.
1400         * breakpoint.h (struct breakpoint) <filter>: Now a
1401         unique_xmalloc_ptr.
1402
1403 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1404
1405         * NEWS: Mention dictionary access on blocks.
1406         * python/py-block.c (blpy_getitem): New function.
1407         (block_object_as_mapping): New struct.
1408         (block_object_type): Use new struct for tp_as_mapping field.
1409
1410 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1411
1412         * objfiles.h (objfile): Add a comment describing partial symbols.
1413
1414 2019-08-05  Tom Tromey  <tromey@adacore.com>
1415
1416         * compile/compile.c (_initialize_compile): Use _(), not N_().
1417         * thread.c (_initialize_thread): Use _(), not N_().
1418         * stack.c (_initialize_stack): Use _(), not N_().
1419         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1420
1421 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1422
1423         * dwarf2read.c (struct dw2_symtab_iterator):
1424         <want_specific_block>: Remove.
1425         <block_index>: Change type to gdb::optional.
1426         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1427         change type of BLOCK_INDEX parameter to gdb::optional.
1428         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1429         (dw2_lookup_symbol): Don't pass argument for
1430         WANT_SPECIFIC_BLOCK.
1431         (dw2_expand_symtabs_for_function): Don't pass argument for
1432         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1433         (class dw2_debug_names_iterator)
1434         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1435         parameter, change BLOCK_INDEX type to gdb::optional.
1436         <m_want_specific_block>: Remove.
1437         <m_block_index>: Change type to gdb::optional.
1438         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1439         gdb::optional.  Re-write in function of gdb::optional.
1440         (dw2_debug_names_lookup_symbol): Don't pass argument for
1441         WANT_SPECIFIC_BLOCK.
1442         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1443         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1444         BLOCK_INDEX.
1445
1446 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1447
1448         * NEWS: Mention changes to "info sources" command.
1449
1450 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1451
1452         * symtab.c (filename_partial_match_opts): New struct type.
1453         (struct output_source_filename_data): New members
1454         regexp, c_regexp, partial_match.
1455         (output_source_filename): Use new members to decide to print file.
1456         (info_sources_option_defs): New variable.
1457         (make_info_sources_options_def_group, print_info_sources_header,
1458         info_sources_command_completer):
1459         New functions.
1460         (info_sources_command): Read new optional arguments.
1461         (_initialize_symtab): Update info sources help.
1462
1463 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1464
1465         * ada-lang.c (exception_support_info_v0): Renamed from...
1466         (default_exception_support_info): ... this.  Create new
1467         definition for v1.
1468         (ada_has_this_exception_support): Look up catch_handlers_sym.
1469         (ada_exception_support_info_sniffer): Try v0 after default.
1470
1471 2019-08-01  Tom Tromey  <tromey@adacore.com>
1472
1473         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1474         gdbarch.h.
1475
1476 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1477
1478         * s12z-tdep.c: Fix include path for s12z-opc.h.
1479
1480 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1481
1482         * NEWS: Require GNU make 3.82.
1483
1484 2019-07-16  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1487         declare.
1488
1489 2019-07-30  Tom Tromey  <tromey@adacore.com>
1490
1491         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1492
1493 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1494
1495         * printcmd.c (print_address_symbolic): Print negative offsets.
1496         (build_address_symbolic): Force signed arithmetic when computing
1497         offset.
1498
1499 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1500
1501         PR/24474: Add a function to lookup static variables.
1502         * NEWS: Mention this new function.
1503         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1504         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1505         * python/python.c (python_GdbMethods): Add new function.
1506
1507 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1508
1509         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1510         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1511         (objfpy_lookup_static_symbol): New function.
1512         (objfile_object_methods): Add new functions.
1513
1514 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1515
1516         * NEWS: Mention 'set|show print frame-info'.  Mention new
1517         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1518         backtrace argument.  Mention that python frame filtering code
1519         is now consistent with what 'backtrace' command prints.
1520
1521 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1522
1523         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1524         comments.
1525         (print_frame_info_auto, print_frame_info_source_line,
1526         print_frame_info_location, print_frame_info_source_and_location,
1527         print_frame_info_location_and_address, print_frame_info_short_location):
1528         New declarations.
1529         (struct frame_print_options): New member print_frame_info.
1530         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1531         * stack.h (get_user_print_what_frame_info): New declaration.
1532         (frame_show_address): New declaration.
1533         * stack.c (print_frame_arguments_choices): New value 'presence'.
1534         (print_frame_info_auto, print_frame_info_source_line,
1535         print_frame_info_location, print_frame_info_source_and_location,
1536         print_frame_info_location_and_address, print_frame_info_short_location,
1537         print_frame_info_choices, print_frame_info_print_what): New definitions.
1538         (print_frame_args): Only print dots for args if print frame-arguments
1539         is 'presence'.
1540         (frame_print_option_defs): New element for "frame-info".
1541         (get_user_print_what_frame_info): New function.
1542         (frame_show_address): Make non static.  Move comment to stack.h.
1543         (print_frame_info_to_print_what): New function.
1544         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1545         to decide what to print.
1546         (backtrace_command_1): Handle the new print_frame_arguments_presence
1547         value.
1548         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1549         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1550         (py_print_frame): In non-mi mode, use LOCATION as default for
1551         print_what, similarly to frame information printed directly by
1552         backtrace command. Handle frame-info user option in non MI mode.
1553
1554 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1555
1556         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1557         Add case for debugging 32-bit target on 64-bit host.  Revise
1558         comment.
1559
1560 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1561
1562         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1563         instead of find_function_entry_range_from_pc.
1564
1565 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1566
1567         * stack.c (find_frame_funname): Remove code which preferred
1568         minsym over symtab sym in "certain pathological cases".
1569
1570         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1571         parameter.  Change type of "do_demangle" to bool.
1572         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1573         Pass suitable "prefer_sym_over_minsym" flag to
1574         build_address_symbolic().  Don't output "+" for negative offsets.
1575         * printcmd.c (print_address_symbolic): Update invocation of
1576         build_address_symbolic to include a "prefer_sym_over_minsym"
1577         flag.
1578         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1579         Restrict cases in which use of minimal symbol is preferred to that
1580         of a found symbol.  Update comments.
1581
1582         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1583         for entry pc when entry pc is out of range for that FDE.
1584
1585 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1586
1587         PR gdb/24839:
1588         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1589         type.
1590
1591 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1592
1593         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1594         this function's Python signature.
1595
1596
1597 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1598
1599         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1600         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1601         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1602         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1603         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1604
1605
1606 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1607
1608         * h8300-tdep.c (h8300_register_name_common): New.
1609         h8300_register_name): Use h8300_register_name_common.
1610         (h8300s_register_name): Likewise.
1611         (h8300sx_register_name): Likewise.
1612         (h8300h_register_nam): New.
1613         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1614
1615
1616 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1617
1618         * arm-tdep.c (arm_skip_cmse_entry): New function.
1619         (arm_is_sgstubs_section): New function.
1620         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1621
1622 2019-07-22  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1625         Don't self-assign.
1626
1627 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1628
1629         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1630         type_print.
1631
1632 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1633
1634         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1635         so that GDB doesn't match any msymbols when searching in the
1636         TYPES_DOMAIN.
1637         (print_symbol_info): Print using typedef_print or type_print based
1638         on the type of the symbol.  Add updated FIXME comment moved from...
1639         (_initialize_symtab): ... move and update FIXME comment to above.
1640
1641 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1642
1643         * NEWS: Mention adding -q option to "info types".
1644         * symtab.c (struct info_types_options): New struct.
1645         (info_types_options_defs): New variable.
1646         (make_info_types_options_def_group): New function.
1647         (info_types_command): Use gdb::option framework to parse options.
1648         (info_types_command_completer): New function.
1649         (_initialize_symtab): Extend the help text on "info types" and
1650         register command completer.
1651
1652 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1653
1654         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1655         (lookup_symbol_in_objfile): Change int to block_enum and add a
1656         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1657
1658 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1659
1660         * MAINTAINERS (Write After Approval): Add self.
1661
1662 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1663
1664         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1665         instruction to the dummy code region.
1666
1667 2019-07-19  Tom Tromey  <tromey@adacore.com>
1668
1669         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1670         (ARGSUSED, PARAMS, __func__): Remove rules.
1671
1672 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1673
1674         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1675         * features/arm/arm-with-iwmmxt.c: Remove.
1676         * features/arm/arm-with-iwmmxt.xml: Remove.
1677         * features/arm/arm-with-m-fpa-layout.c: Remove.
1678         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1679         * features/arm/arm-with-m-vfp-d16.c: Remove.
1680         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1681         * features/arm/arm-with-m.c: Remove.
1682         * features/arm/arm-with-m.xml: Remove.
1683         * features/arm/arm-with-neon.c: Remove.
1684         * features/arm/arm-with-neon.xml: Remove.
1685         * features/arm/arm-with-vfpv2.c: Remove.
1686         * features/arm/arm-with-vfpv2.xml: Remove.
1687         * features/arm/arm-with-vfpv3.c: Remove.
1688         * features/arm/arm-with-vfpv3.xml: Remove.
1689
1690 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1691
1692         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1693
1694 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1695
1696         * arch/aarch32.c (aarch32_create_target_description): Create
1697         target descriptions using features.
1698         * arch/arm.c (arm_create_target_description)
1699         (arm_create_mprofile_target_description): Likewise.
1700         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1701
1702 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1703
1704         * Makefile.in: Add new files.
1705         * aarch32-tdep.c: New file.
1706         * aarch32-tdep.h: New file.
1707         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1708         Call aarch32_read_description.
1709         * arch/aarch32.c: New file.
1710         * arch/aarch32.h: New file.
1711         * arch/arm.c (arm_create_target_description)
1712         (arm_create_mprofile_target_description): New function.
1713         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1714         (arm_create_target_description)
1715         (arm_create_mprofile_target_description): New declaration.
1716         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1717         read_description functions.
1718         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1719         Likewise.
1720         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1721         * arm-tdep.c (tdesc_arm_list): New variable.
1722         (arm_register_g_packet_guesses): Call create description functions.
1723         (arm_read_description) (arm_read_mprofile_description): New
1724         function.
1725         * arm-tdep.h (arm_read_description)
1726         (arm_read_mprofile_description): Add declaration.
1727         * configure.tgt: Add new files.
1728
1729 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1730
1731         * top.c (new_ui_command): Open specified terminal just once.
1732
1733 2019-07-18  Tom Tromey  <tromey@adacore.com>
1734
1735         * symtab.c (main_name): Constify return type.
1736         * symfile.c (set_initial_language): Update.
1737         * symtab.h (main_name): Constify return type.
1738
1739 2019-07-17  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-winsource.c (tui_update_source_window)
1742         (tui_update_source_window_as_is)
1743         (tui_update_source_windows_with_line): Remove return.
1744         * tui/tui-disasm.c (tui_show_disassem)
1745         (tui_show_disassem_and_update_source): Remove return.
1746         * tui/tui.c (tui_reset): Remove return.
1747         * tui/tui-wingeneral.c
1748         (tui_check_and_display_highlight_if_needed): Remove return.
1749
1750 2019-07-17  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1753
1754 2019-07-17  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-winsource.h (struct tui_exec_info_window)
1757         (struct tui_source_window_base): Move from tui-data.h.
1758         * tui/tui-winsource.c: Move many method definitions from
1759         elsewhere.  Remove "structuring" comments.
1760         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1761         (tui_source_window_base::refresh_window): Move to
1762         tui-winsource.c.
1763         * tui/tui-win.c (tui_source_window_base::refresh_all)
1764         (tui_source_window_base::update_tab_width)
1765         (tui_source_window_base::set_new_height)
1766         (tui_source_window_base::do_make_visible_with_new_height): Move to
1767         tui-winsource.c.
1768         * tui/tui-source.h: Update.
1769         * tui/tui-source.c (tui_source_window_base::reset): Move to
1770         tui-winsource.c.
1771         * tui/tui-disasm.h: Update.
1772         * tui/tui-data.h (struct tui_exec_info_window): Move to
1773         tui-winsource.h.
1774         (struct tui_source_window_base): Likewise.
1775         * tui/tui-data.c (tui_source_window_base::clear_detail)
1776         (tui_source_window_base, ~tui_source_window_base): Move to
1777         tui-winsource.c.
1778
1779 2019-07-17  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-win.c (tui_resize_all)
1782         (tui_source_window_base::update_tab_width)
1783         (tui_adjust_win_heights): Update.
1784         (tui_win_info::make_invisible_and_set_new_height): Rename from
1785         make_invisible_and_set_new_height.
1786         * tui/tui-data.h (struct tui_win_info)
1787         <make_invisible_and_set_new_height>: New method.
1788
1789 2019-07-17  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui.c: Update.
1792         * tui/tui-source.h (struct tui_source_window): Move from
1793         tui-data.h.
1794         * tui/tui-layout.c: Update.
1795         * tui/tui-disasm.c: Update.
1796         * tui/tui-data.h (struct tui_source_window): Move to
1797         tui-source.h.
1798
1799 2019-07-17  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1802         tui-data.h.
1803         * tui/tui-data.h (struct tui_disasm_window): Move to
1804         tui-disasm.h.
1805
1806 2019-07-17  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-regs.h (struct tui_data_item_window): Move from
1809         tui-data.h.
1810         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1811         * tui/tui-data.h (struct tui_data_item_window): Move to
1812         tui-regs.h.
1813         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1814
1815 2019-07-17  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui.c: Update.
1818         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1819         (tui_cmd_window::max_height): Move to tui-command.c.
1820         * tui/tui-layout.c: Update.
1821         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1822         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1823         tui-command.c.
1824         * tui/tui-command.h (struct tui_cmd_window): Move from
1825         tui-data.h.
1826         * tui/tui-command.c: Remove "structuring" comments.
1827         (tui_cmd_window::clear_detail)
1828         (tui_cmd_window::do_make_visible_with_new_height)
1829         (tui_cmd_window::max_height): Move from elsewhere.
1830
1831 2019-07-17  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1834         Now static.
1835         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1836         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1837
1838 2019-07-17  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui.c: Update.
1841         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1842         tui-regs.c.
1843         * tui/tui-windata.h: Remove file.
1844         * tui/tui-windata.c: Remove file.
1845         * tui/tui-win.c (tui_data_window::set_new_height)
1846         (tui_data_window::do_make_visible_with_new_height): Move to
1847         tui-regs.c.
1848         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1849         * tui/tui-regs.c: Remove "structuring" comments.
1850         (tui_data_window::first_data_item_displayed)
1851         (tui_data_window::delete_data_content_windows)
1852         (tui_data_window::erase_data_content)
1853         (tui_data_window::display_all_data)
1854         (tui_data_window::refresh_all)
1855         (tui_data_window::do_scroll_vertical)
1856         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1857         (tui_data_window::do_make_visible_with_new_height)
1858         (tui_data_window::refresh_window): Move from elsewhere.
1859         (_initialize_tui_regs): Move to end of file.
1860         * tui/tui-layout.c: Update.
1861         * tui/tui-hooks.c: Update.
1862         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1863         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1864         tui-regs.c.
1865         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1866
1867 2019-07-17  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1870         seen.
1871
1872 2019-07-17  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-win.c (tui_source_window_base::set_new_height)
1875         (tui_source_window_base::do_make_visible_with_new_height): Use
1876         m_has_locator field directly.
1877         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1878         method.
1879         (struct tui_source_window_base) <has_locator>: Likewise.
1880
1881 2019-07-17  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1884         Don't declare.
1885         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1886         Remove.
1887         * tui/tui-win.c (tui_source_window_base::set_new_height)
1888         (tui_source_window_base::set_new_height)
1889         (make_invisible_and_set_new_height)
1890         (tui_source_window_base::do_make_visible_with_new_height)
1891         (tui_source_window_base::do_make_visible_with_new_height):
1892         Update.
1893         * tui/tui-layout.c (show_source_disasm_command, show_data)
1894         (show_source_or_disasm_and_command): Update.
1895         * tui/tui-layout.c (show_layout): Update.
1896
1897 2019-07-17  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-layout.c (make_data_window): Remove.
1900         (show_data): Unify creation and re-initialization cases.
1901
1902 2019-07-17  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-layout.c (make_source_window, make_disasm_window):
1905         Remove.
1906         (show_data): Unify creation and re-initialization cases.
1907
1908 2019-07-17  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-layout.c (make_command_window): Remove.
1911         (show_source_disasm_command, show_source_or_disasm_and_command):
1912         Unify creation and re-initialization cases.
1913
1914 2019-07-17  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1917         creation and re-initialization cases.
1918
1919 2019-07-17  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-regs.c (tui_get_register): Return void.
1922
1923 2019-07-17  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1926         Simplify.
1927
1928 2019-07-17  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1931         resetting.
1932
1933 2019-07-17  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1936         * tui/tui-regs.c (tui_reg_layout): New function.
1937         (tui_show_registers, tui_reg_command): Use it.
1938         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1939         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1940         parameters.
1941         (tui_layout_command): Remove.
1942
1943 2019-07-17  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-layout.h (tui/tui-layout): Return void.
1946         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1947
1948 2019-07-17  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-layout.c (show_source_disasm_command, show_data):
1951         Update.
1952         (reset_locator): Remove.
1953         (show_source_or_disasm_and_command): Update.
1954
1955 2019-07-17  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-source.c (tui_source_window_base::reset): Remove
1958         win_type parameter.
1959         * tui/tui-layout.c (make_command_window, make_source_window)
1960         (make_disasm_window, make_data_window)
1961         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1962         (reset_locator, show_source_or_disasm_and_command): Update.
1963         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1964         win_type parameter.
1965         (struct tui_source_window_base) <reset>: Likewise.
1966
1967 2019-07-17  Tom Tromey  <tom@tromey.com>
1968
1969         * tui/tui-layout.c (show_source_disasm_command): Use
1970         reset_locator.
1971         (reset_locator): New function.
1972         (init_and_make_win): Remove.
1973         (show_source_or_disasm_and_command): Use reset_locator.
1974
1975 2019-07-17  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1978         condition.
1979         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1980         Remove condition.
1981         * tui/tui-source.c (tui_source_window_base::reset): New method.
1982         * tui/tui-layout.c (make_command_window): Don't call
1983         init_and_make_win.
1984         (make_source_window, make_disasm_window): Don't call
1985         make_source_or_disasm_window.
1986         (make_data_window): Don't call init_and_make_win.  Change calling
1987         convention.
1988         (show_source_disasm_command, show_data): Simplify.
1989         (make_source_or_disasm_window): Remove.
1990         (show_source_or_disasm_and_command): Simplify.
1991         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1992         (struct tui_source_window_base) <reset>: Likewise.
1993         <execution_info>: Remove initializer.
1994         * tui/tui-data.c (tui_source_window_base): Initialize
1995         execution_info.
1996
1997 2019-07-17  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2000         variable.
2001
2002 2019-07-17  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui.c (tui_rl_other_window): Update.
2005         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2006         superclass method first.  Always iterate over regs_content.
2007         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2008         method.
2009         * tui/tui-win.c (tui_set_focus_command): Update.
2010
2011 2019-07-17  Tom Tromey  <tom@tromey.com>
2012
2013         * tui/tui-win.c (tui_set_focus_command): Rename from
2014         tui_set_focus.  Call tui_enable.
2015         (tui_set_focus_command): Remove.
2016
2017 2019-07-17  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2020         refresh_window.
2021         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2022         touchwin.
2023         (tui_data_window::refresh_window): Call refresh_window on data
2024         items.  Always call superclass refresh_window.
2025         (tui_win_info::refresh): Remove.
2026         (tui_source_window_base::refresh_window): Update.
2027         (tui_refresh_all): Update.
2028         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2029         refresh_window.
2030         (show_source_or_disasm_and_command): Likewise.
2031         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2032         (struct tui_source_window_base) <refresh>: Likewise.
2033
2034 2019-07-17  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-winsource.c (tui_clear_source_content)
2037         (tui_show_source_content): Update.
2038         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2039         whether content is empty.
2040         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2041         Remove.
2042
2043 2019-07-17  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2046         window's contents.
2047         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2048         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2049
2050 2019-07-17  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2053         (struct tui_data_item_window): Update.
2054
2055 2019-07-17  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2058         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2059         defines.
2060
2061 2019-07-17  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-winsource.h (tui_erase_source_content)
2064         (tui_clear_source_content): Remove "display_prompt" parameter.
2065         * tui/tui-winsource.c (tui_update_source_window_as_is)
2066         (tui_update_source_windows_with_addr): Update.
2067         (tui_clear_source_content): Remove "display_prompt" parameter.
2068         (tui_erase_source_content): Likewise.  Simplify.
2069         (tui_show_source_content): Update.
2070         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2071         * tui/tui-stack.c (tui_show_frame_info): Update.
2072         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2073         Remove defines.
2074
2075 2019-07-17  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2078         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2079         parameter.
2080         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2081         parameter.
2082
2083 2019-07-17  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-winsource.c (tui_clear_source_content)
2086         (tui_show_source_content, tui_show_exec_info_content)
2087         (tui_clear_exec_info_content): Update.
2088         * tui/tui-stack.c (tui_show_locator_content): Update.
2089         (tui_show_frame_info): Update.
2090         * tui/tui-source.h (tui_source_window): Don't declare.
2091         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2092         from tui_source_is_displayed.
2093         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2094         Remove field.
2095         (struct tui_source_window_base) <content_in_use>: New field.  Now
2096         bool.
2097         (struct tui_source_window) <showing_source_p>: New method.
2098         (TUI_SRC_WIN): Change cast.
2099         * tui/tui-data.c (tui_initialize_static_data): Update.
2100
2101 2019-07-17  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2104         location_matches_p.
2105         * tui/tui-source.c (tui_source_window::location_matches_p): New
2106         method.
2107         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2108         method.
2109         * tui/tui-data.h (struct tui_source_window_base)
2110         <location_matches_p>: New method.
2111         (struct tui_source_window, struct tui_disasm_window)
2112         <location_matches_p>: Likewise.
2113
2114 2019-07-17  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-win.c (tui_set_win_height_command): Rename from
2117         tui_set_win_height.
2118         (tui_set_win_height_command): Remove.
2119
2120 2019-07-17  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-source.c (tui_source_window): New constructor.  Add
2123         observer.
2124         (~tui_source_window): New destructor.
2125         (tui_source_window::style_changed): New method.
2126         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2127         (tui_attach_detach_observers): Update.
2128         * tui/tui-data.h (struct tui_source_window): Make constructor not
2129         inline.  Add destructor.
2130         (struct tui_source_window) <style_changed>: New method.
2131         <m_observable>: New member.
2132
2133 2019-07-17  Tom Tromey  <tom@tromey.com>
2134
2135         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2136         * tui/tui-win.c (tui_resize_all): Fix typo.
2137
2138 2019-07-17  Tom Tromey  <tom@tromey.com>
2139
2140         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2141         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2142         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2143         * tui/tui-win.c (window_name_completer): Use foreach.
2144         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2145         (update_tab_width): Likewise.
2146         * tui/tui-layout.c (show_layout): Update.
2147         * tui/tui-data.h (class tui_window_iterator): New.
2148         (struct all_tui_windows): New.
2149         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2150
2151 2019-07-17  Tom Tromey  <tom@tromey.com>
2152
2153         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2154         parameter.  Don't reference globals.
2155         (tui_reg_command): Update.
2156
2157 2019-07-17  Tom Tromey  <tom@tromey.com>
2158
2159         * tui/tui-regs.c (tui_show_registers): Simplify.
2160
2161 2019-07-17  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-regs.c (tui_show_registers): Update.
2164         (tui_show_register_group): Add win_info parameter.
2165
2166 2019-07-17  Tom Tromey  <tom@tromey.com>
2167
2168         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2169         Rename from tui_display_reg_element_at_line.
2170         (tui_data_window::display_registers_from_line): Update.
2171         * tui/tui-data.h (struct tui_data_window)
2172         <display_reg_element_at_line>: New method.
2173
2174 2019-07-17  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-regs.h (tui_display_registers_from)
2177         (tui_display_registers_from_line): Don't declare.
2178         * tui/tui-windata.c (tui_data_window::display_all_data)
2179         (tui_data_window::refresh_all)
2180         (tui_data_window::do_scroll_vertical): Update.
2181         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2182         from tui_display_registers_from.
2183         (tui_display_reg_element_at_line): Update.
2184         (tui_data_window::display_registers_from_line): Rename from
2185         tui_display_registers_from_line.
2186         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2187         display_registers_from_line>: New methods.
2188
2189 2019-07-17  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2192         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2193         from tui_erase_data_content.
2194         (tui_data_window::display_all_data)
2195         (tui_data_window::refresh_all)
2196         (tui_data_window::do_scroll_vertical): Update.
2197         * tui/tui-regs.c (tui_show_registers): Update.
2198         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2199         New method.
2200
2201 2019-07-17  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2204         declare.
2205         * tui/tui-windata.c
2206         (tui_data_window::delete_data_content_windows): Rename from
2207         tui_delete_data_content_windows.
2208         (tui_data_window::display_all_data)
2209         (tui_data_window::do_scroll_vertical): Update.
2210         * tui/tui-data.h (struct tui_data_window)
2211         <delete_data_content_windows>: New method.
2212
2213 2019-07-17  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2216         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2217
2218 2019-07-17  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2221         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2222         from tui_display_all_data.
2223         * tui/tui-win.c
2224         (tui_data_window::do_make_visible_with_new_height): Update.
2225         * tui/tui-regs.c (tui_show_registers): Update.
2226         * tui/tui-layout.c (tui_set_layout): Update.
2227         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2228         method.
2229
2230 2019-07-17  Tom Tromey  <tom@tromey.com>
2231
2232         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2233         * tui/tui-windata.c (tui_display_data_from): Remove.
2234         (tui_data_window::refresh_all): Update.
2235
2236 2019-07-17  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2239         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2240         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2241         tui_display_registers_from_line.
2242         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2243         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2244         "force_display" parameter.
2245
2246 2019-07-17  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2249         declare.
2250         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2251         Rename from tui_first_reg_element_no_inline.
2252         (tui_display_reg_element_at_line)
2253         (tui_display_registers_from_line): Update.
2254         * tui/tui-data.h (struct tui_data_window)
2255         <first_reg_element_no_inline>: New method.
2256
2257 2019-07-17  Tom Tromey  <tom@tromey.com>
2258
2259         * tui/tui-windata.c (tui_display_data_from)
2260         (tui_data_window::do_scroll_vertical): Update.
2261         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2262         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2263         Rename from tui_line_from_reg_element_no.
2264         (tui_display_registers_from_line): Update.
2265         * tui/tui-data.h (struct tui_data_window)
2266         <line_from_reg_element_no>: New method.
2267
2268 2019-07-17  Tom Tromey  <tom@tromey.com>
2269
2270         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2271         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2272         tui_last_regs_line_no.
2273         (tui_display_reg_element_at_line)
2274         (tui_display_registers_from_line): Update.
2275         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2276         method.
2277
2278 2019-07-17  Tom Tromey  <tom@tromey.com>
2279
2280         PR tui/24722:
2281         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2282         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2283         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2284         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2285         (tui_update_breakpoint_info): Likewise.
2286         * tui/tui-hooks.c (tui_event_create_breakpoint)
2287         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2288         Update.
2289
2290 2019-07-17  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2293
2294 2019-07-17  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui-winsource.c (tui_update_source_window_as_is)
2297         (tui_update_source_windows_with_addr): Update.
2298         * tui/tui-source.h (tui_set_source_content)
2299         (tui_show_symtab_source): Add "win_info" parameter.
2300         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2301         parameter.
2302         (tui_show_symtab_source): Likewise.
2303
2304 2019-07-17  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui-wingeneral.c
2307         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2308
2309 2019-07-17  Tom Tromey  <tom@tromey.com>
2310
2311         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2312         (struct tui_cmd_window) <can_scroll>: New method.
2313         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2314         method.
2315
2316 2019-07-17  Tom Tromey  <tromey@adacore.com>
2317
2318         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2319         do_field_signed>: Rename.  Change type of "value".
2320         * ui-out.c (ui_out::field_signed): Rename from field_int.
2321         Change type of "value".
2322         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2323         type of "value".
2324         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2325         do_field_int.  Change type of "value".
2326         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2327         do_field_int.  Change type of "value".
2328         * tracepoint.c (trace_status_mi, tfind_1)
2329         (print_one_static_tracepoint_marker): Update.
2330         * thread.c (print_thread_info_1, print_selected_thread_frame):
2331         Update.
2332         * stack.c (print_frame, print_frame_info): Update.
2333         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2334         Update.
2335         * source.c (print_source_lines_base): Update.
2336         * skip.c (info_skip_command): Update.
2337         * record-btrace.c (btrace_ui_out_decode_error)
2338         (btrace_call_history_src_line): Update.
2339         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2340         Update.
2341         * progspace.c (print_program_space): Update.
2342         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2343         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2344         do_field_int.  Change type of "value".
2345         * mi/mi-out.c (mi_ui_out::do_table_begin)
2346         (mi_ui_out::do_table_header): Update.
2347         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2348         type of "value".
2349         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2350         (mi_cmd_data_list_changed_registers, output_register)
2351         (mi_cmd_data_read_memory, mi_load_progress)
2352         (mi_cmd_trace_frame_collected): Update.
2353         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2354         Update.
2355         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2356         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2357         (mi_cmd_var_list_children, varobj_update_one): Update.
2358         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2359         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2360         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2361         * inferior.c (print_inferior): Update.
2362         * gdb_bfd.c (print_one_bfd): Update.
2363         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2364         Update.
2365         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2366         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2367         do_field_int.  Change type of "value".
2368         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2369         do_field_int.  Change type of "value".
2370         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2371         (print_one_breakpoint_location, print_it_catch_fork)
2372         (print_one_catch_fork, print_it_catch_vfork)
2373         (print_one_catch_vfork, print_it_catch_solib)
2374         (print_it_catch_exec, print_it_ranged_breakpoint)
2375         (print_mention_watchpoint, print_mention_masked_watchpoint)
2376         (bkpt_print_it, update_static_tracepoint): Update.
2377         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2378         * break-catch-syscall.c (print_it_catch_syscall): Update.
2379         * ada-tasks.c (print_ada_task_info): Update.
2380         * ada-lang.c (print_it_exception, print_mention_exception):
2381         Update.
2382
2383 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2384
2385         PR breakpoints/24541
2386         * gdbarch.c: Regenerate.
2387         * gdbarch.h: Regenerate.
2388         * gdbarch.sh: Adjust return type and parameter types for
2389         'stap_adjust_register'.
2390         (i386_stap_adjust_register): Adjust signature and return new
2391         register name.
2392         * stap-probe.c (stap_parse_register_operand): Adjust use of
2393         'gdbarch_stap_adjust_register'.
2394
2395 2019-07-17  Tom Tromey  <tromey@adacore.com>
2396
2397         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2398         declare VEC.
2399         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2400         std::vector.
2401         (struct s390_process_info): Add initializers.
2402         (s390_add_process): Use new.
2403         (s390_linux_nat_target::low_forget_process): Use delete.
2404         (s390_linux_nat_target::low_new_fork)
2405         (s390_linux_nat_target::stopped_by_watchpoint)
2406         (s390_linux_nat_target::low_prepare_to_resume)
2407         (s390_linux_nat_target::insert_watchpoint)
2408         (s390_linux_nat_target::insert_hw_breakpoint)
2409         (s390_linux_nat_target::remove_watchpoint)
2410         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2411
2412 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2413
2414         * aarch64-fbsd-nat.c: Include regcache.h.
2415         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2416         argument.
2417         (aarch64_fbsd_nat_target::fetch_registers)
2418         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2419         variable.
2420         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2421
2422 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2423
2424         * fbsd-nat.c: Include gdbarch.h.
2425
2426 2019-07-15  Tom Tromey  <tromey@adacore.com>
2427
2428         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2429
2430 2019-07-15  Tom Tromey  <tromey@adacore.com>
2431
2432         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2433         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2434         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2435         * cli-out.c (cli_ui_out::do_field_int): New method.
2436         * ui-out.c (ui_out::field_unsigned): New method.
2437         * symfile.c (generic_load): Use field_unsigned.
2438         (print_transfer_performance): Likewise.
2439         * record-btrace.c (ui_out_field_uint): Remove.
2440         (btrace_call_history_insn_range, btrace_call_history): Use
2441         field_unsigned.
2442         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2443         field_unsigned.
2444         * ui-out.h (class ui_out) <field_unsigned>: New method.
2445         <do_field_unsigned>: Likewise.
2446
2447 2019-07-15  Tom Tromey  <tromey@adacore.com>
2448
2449         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2450         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2451         * target.c (flash_erase_command): Use field_string.
2452         * infrun.c (print_signal_received_reason): Use field_string.
2453         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2454         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2455         field_string.
2456         * ada-tasks.c (print_ada_task_info): Use field_string.
2457
2458 2019-07-15  Tom Tromey  <tromey@adacore.com>
2459
2460         * target.c (flash_erase_command): Use field_core_addr.
2461         * symfile.c (generic_load): Use field_core_addr.
2462         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2463         Use field_core_addr.
2464         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2465         field_core_addr.
2466
2467 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2468
2469         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2470         value if its desired type is smaller than a CORE_ADDR and signed.
2471
2472 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2473
2474         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2475         of changes to field names, and use new is_reference field to
2476         decide if a property is a reference or not.
2477         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2478         field.
2479         (struct dwarf2_property_baton): Update header comment, rename
2480         'referenced_type' to 'property_type' and update comments.
2481         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2482         default property type, store in property baton, update to take
2483         accound of renamed field.
2484         (read_func_scope): Update call to attr_to_dynamic_prop.
2485         (read_array_type): Likewise.
2486         (dwarf2_per_cu_addr_sized_int_type): New function.
2487         (read_subrange_index_type): Move type finding code to
2488         dwarf2_per_cu_addr_sized_int_type.
2489         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2490         (dwarf2_per_cu_addr_type): New function.
2491         (set_die_type): Update calls to attr_to_dynamic_prop.
2492
2493 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2494
2495         * dwarf2read.c (read_subrange_index_type): New function.
2496         (read_subrange_type): Move code into new function and call it.
2497         * gdbtypes.c (create_range_type): Add some asserts.
2498
2499 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2500
2501         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2502         update return statements.
2503         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2504         declaration, and update comment to match.
2505         * gdbtypes.c (resolve_dynamic_array): Update call to
2506         dwarf2_evaluate_property to match new return type.
2507
2508 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2509
2510         * valarith.c (value_subscripted_rvalue): Change lowerbound
2511         parameter type from int to LONGEST.
2512         * value.h (value_subscripted_rvalue): Likewise in declaration.
2513
2514 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * cli/cli-utils.c (info_print_command_completer): New function.
2517         * cli/cli-utils.h: Add 'completer.h' include, and forward
2518         declaration for 'struct cmd_list_element'.
2519         (info_print_command_completer): Declare.
2520         * stack.c (_initialize_stack): Add completer for 'info locals' and
2521         'info args'.
2522         * symtab.c (_initialize_symtab): Add completer for 'info
2523         variables' and 'info functions'.
2524         * NEWS: Mention completion for additional info commands.
2525
2526 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2527
2528         * cli/cli-utils.c (extract_info_print_args): Delete.
2529         (extract_arg_maybe_quoted): Delete.
2530         (info_print_options_defs): New variable.
2531         (make_info_print_options_def_group): New function.
2532         (extract_info_print_options): Define new function.
2533         * cli/cli-utils.h (extract_info_print_args): Delete.
2534         (struct info_print_options): New structure.
2535         (extract_info_print_options): Declare new function.
2536         * stack.c (info_locals_command): Update to use new
2537         extract_info_print_options, also add a header comment.
2538         (info_args_command): Likewise.
2539         * symtab.c (info_variables_command): Likewise.
2540         (info_functions_command): Likewise.
2541
2542 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2543
2544         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2545         to extract string arguments.
2546         * common/common-utils.c (extract_string_maybe_quoted): New function.
2547         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2548
2549 2019-07-11  Tom Tromey  <tromey@adacore.com>
2550
2551         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2552         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2553         * top.h (gdbinit): Don't declare.
2554         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2555         into...
2556         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2557         * top.c (gdb_init): Don't call init_cli_cmds.
2558         (gdbinit): Remove.
2559         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2560
2561 2019-07-11  Tom Tromey  <tromey@adacore.com>
2562
2563         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2564         after it has been moved.
2565
2566 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2567
2568         * valops.c (value_must_coerce_to_target): Change return type to
2569         bool.
2570         * value.h (value_must_coerce_to_target): Likewise.
2571
2572 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2573
2574         * breakpoint.c (is_hardware_watchpoint): Remove
2575         forward-declaration.
2576         (is_masked_watchpoint): Change return type to bool.
2577         (is_tracepoint): Likewise.
2578         (is_breakpoint): Likewise.
2579         (is_hardware_watchpoint): Likewise.
2580         (is_watchpoint): Likewise.
2581         (is_no_memory_software_watchpoint): Likewise.
2582         (is_catchpoint): Likewise.
2583         (breakpoint_1): Make FILTER parameter's return type bool.
2584         is_masked_watchpoint): Change return type to bool.
2585         (save_breakpoints): Make FILTER parameter's return type bool.
2586         * breakpoint.h (is_breakpoint): Change return type to bool.
2587         (is_watchpoint): Likewise.
2588         (is_catchpoint): Likewise.
2589         (is_tracepoint): Likewise.
2590
2591 2019-07-10  Tom Tromey  <tom@tromey.com>
2592
2593         * defs.h: Don't include gdbarch.h.
2594         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2595         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2596         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2597         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2598         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2599         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2600         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2601         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2602         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2603         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2604         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2605         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2606         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2607         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2608         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2609         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2610         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2611         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2612         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2613         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2614         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2615         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2616         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2617         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2618         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2619         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2620         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2621
2622 2019-07-10  Tom Tromey  <tromey@adacore.com>
2623
2624         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2625         * breakpoint.c (init_ada_exception_breakpoint): Register as
2626         bp_catchpoint.
2627         (print_one_breakpoint_location, print_one_breakpoint): Use
2628         is_ada_exception_catchpoint.
2629         * ada-lang.c (class ada_catchpoint_location): Pass
2630         bp_loc_software_breakpoint to bp_location constructor.
2631         (is_ada_exception_catchpoint): New function.
2632
2633 2019-07-10  Tom Tromey  <tromey@adacore.com>
2634
2635         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2636         VEC.
2637         (struct arm_exidx_entry): New method operator<.
2638         (struct arm_exidx_data) <section_maps>: Change type.
2639         (arm_exidx_data_free): Remove.
2640         (arm_exidx_data_key): Change type.  Move lower.
2641         (arm_exidx_new_objfile): Update.
2642         (arm_compare_exidx_entries): Remove.
2643         (arm_find_exidx_entry, _initialize_arm_tdep)
2644
2645 2019-07-10  Tom Tromey  <tromey@adacore.com>
2646
2647         * solib-spu.c (ocl_program_data_key): Change type.
2648         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2649         Update.
2650
2651 2019-07-10  Tom Tromey  <tromey@adacore.com>
2652
2653         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2654         (struct solib_aix_inferior_data) <library_list>: Change type.
2655         (solib_aix_inferior_data_handle): Change type.
2656         (get_solib_aix_inferior_data): Update.
2657         (solib_aix_free_library_list): Remove.
2658         (library_list_start_library): Update.
2659         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2660         return type.
2661         (solib_aix_get_library_list)
2662         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2663         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2664
2665 2019-07-10  Tom Tromey  <tromey@adacore.com>
2666
2667         * solib-dsbt.c (struct dsbt_info): Add initializers.
2668         (solib_dsbt_pspace_data): Change type.
2669         (dsbt_pspace_data_cleanup): Remove.
2670         (get_dsbt_info, _initialize_dsbt_solib): Update.
2671
2672 2019-07-10  Tom Tromey  <tromey@adacore.com>
2673
2674         * spu-tdep.c (spu_overlay_data): Change type.
2675         (spu_get_overlay_table, spu_overlay_new_objfile)
2676         (_initialize_spu_tdep): Update.
2677
2678 2019-07-10  Tom Tromey  <tromey@adacore.com>
2679
2680         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2681         destructor.
2682         (dbx_objfile_data_key): Change type and declare later.
2683         (DBX_SYMFILE_INFO): Rewrite.
2684         * dbxread.c (dbx_objfile_data_key): Change type.
2685         (dbx_symfile_init): Update.
2686         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2687         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2688         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2689
2690 2019-07-10  Tom Tromey  <tromey@adacore.com>
2691
2692         * jit.c (jit_program_space_key): Change type.  Move lower.
2693         (get_jit_program_space_data): Update.
2694         (jit_program_space_data_cleanup): Remove.
2695         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2696         Update.
2697         (struct jit_program_space_data): Add initializers.
2698
2699 2019-07-10  Tom Tromey  <tromey@adacore.com>
2700
2701         * solib-darwin.c (struct darwin_info): Add initializers.
2702         (solib_darwin_pspace_data): Change type.
2703         (darwin_pspace_data_cleanup): Remove.
2704         (get_darwin_info, _initialize_darwin_solib): Update.
2705
2706 2019-07-10  Tom Tromey  <tromey@adacore.com>
2707
2708         * remote-sim.c (struct sim_inferior_data): Add initializers,
2709         constructor, and destructor.
2710         (sim_inferior_data_key): Change type.  Move lower.
2711         (check_for_duplicate_sim_descriptor): Update.
2712         (get_sim_inferior_data): Use new.  Update.
2713         (~sim_inferior_data_cleanup): Rename from
2714         sim_inferior_data_cleanup.  Simplify.
2715         (gdbsim_close_inferior, simulator_command)
2716         (sim_command_completer, _initialize_remote_sim): Update.
2717         (next_pid, INITIAL_PID): Move earlier.
2718
2719 2019-07-10  Tom Tromey  <tromey@adacore.com>
2720
2721         * python/python-internal.h (create_thread_object): Return
2722         gdbpy_ref.
2723         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2724         * python/py-inferior.c (struct threadlist_entry): Add
2725         constructor.
2726         <thread_obj>: Now a gdbpy_ref.
2727         (thread_to_thread_object): Update.
2728         (add_thread_object): Use new.
2729         (delete_thread_object): Use delete.
2730         (infpy_threads): Update.
2731         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2732         GIL.
2733
2734 2019-07-10  Tom Tromey  <tromey@adacore.com>
2735
2736         * valops.c (value_cast): Specialize error message for Ada.
2737
2738 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2739
2740         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2741
2742 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2743
2744         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2745         bpstat_should_step): Return bool, adjust comments.
2746         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2747         bpstat_should_step): Likewise.
2748
2749 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2750
2751         * features/Makefile: Use feature target descriptions for Arm.
2752         * features/arm/arm-core.c: Generate new file.
2753         * features/arm/arm-fpa.c: Likewise.
2754         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2755         * features/arm/arm-m-profile.c: Likewise.
2756         * features/arm/arm-vfpv2.c: Likewise.
2757         * features/arm/arm-vfpv3.c: Likewise.
2758         * features/arm/xscale-iwmmxt.c: Likewise.
2759         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2760
2761 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2762
2763         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2764         ptrace earlier.
2765
2766 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2767
2768         * features/aarch64-pauth.c: Regenerate.
2769
2770 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2771
2772         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2773         bool.
2774         (bpstat_what): Use false instead of 0.
2775
2776 2019-07-09  Pedro Alves  <palves@redhat.com>
2777
2778         * break-catch-throw.c (is_exception_catchpoint): New.
2779         * breakpoint.c (print_one_breakpoint_location): New parameter
2780         'raw_loc'.  Handle it.  Use
2781         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2782         looking at the breakpoint's type.
2783         (print_one_breakpoint): If handling "maint info breakpoints", also
2784         print locations of exception catchpoints.
2785         * breakpoint.h (is_exception_catchpoint): Declare.
2786
2787 2019-07-09  Pedro Alves  <palves@redhat.com>
2788
2789         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2790         "addr" field.
2791         (allocate_location_exception_catchpoint): New.
2792         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2793         (initialize_throw_catchpoint_ops): Install
2794         allocate_location_exception_catchpoint as allocate_location
2795         method.
2796         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2797         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2798         bp_loc_other.
2799         (breakpoint_address_is_meaningful): Delete.
2800         (bl_address_is_meaningful): New.
2801         (breakpoint_locations_match): Adjust comment.
2802         (bp_location_from_bp_type): New, factored out of...
2803         (bp_location::bp_location(breakpoint *)): ... this.
2804         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2805         factored out of...
2806         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2807         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2808         breakpoint_address_is_meaningful.
2809         (bp_locations_compare): Adjust comment.
2810         (update_global_location_list): Use bl_address_is_meaningful
2811         instead of breakpoint_address_is_meaningful.
2812         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2813         explicit.
2814         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2815         * python/py-breakpoint.c (bppy_get_location): No longer check
2816         whether location is null.
2817
2818 2019-07-09  Pedro Alves  <palves@redhat.com>
2819
2820         PR c++/15468
2821         * breakpoint.c (print_one_breakpoint_location): Remove
2822         single-location assert.
2823
2824 2019-07-09  Tom Tromey  <tom@tromey.com>
2825
2826         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2827         * configure: Rebuild.
2828         * configure.ac: Change common to gdbsupport.
2829         * gdbsupport: Rename from common.
2830         * acinclude.m4: Change common to gdbsupport.
2831         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2832         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2833         gdbsupport.
2834         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2835         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2836         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2837         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2838         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2839         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2840         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2841         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2842         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2843         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2844         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2845         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2846         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2847         coff-pe-read.c, command.h, compile/compile-c-support.c,
2848         compile/compile-c.h, compile/compile-cplus-symbols.c,
2849         compile/compile-cplus-types.c, compile/compile-cplus.h,
2850         compile/compile-loc2c.c, compile/compile.c, completer.c,
2851         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2852         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2853         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2854         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2855         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2856         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2857         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2858         features/aarch64-core.c, features/aarch64-fpu.c,
2859         features/aarch64-pauth.c, features/aarch64-sve.c,
2860         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2861         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2862         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2863         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2864         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2865         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2866         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2867         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2868         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2869         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2870         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2871         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2872         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2873         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2874         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2875         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2876         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2877         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2878         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2879         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2880         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2881         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2882         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2883         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2884         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2885         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2886         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2887         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2888         minsyms.c, mips-linux-tdep.c, namespace.h,
2889         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2890         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2891         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2892         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2893         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2894         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2895         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2896         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2897         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2898         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2899         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2900         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2901         procfs.c, producer.c, progspace.h, psymtab.h,
2902         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2903         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2904         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2905         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2906         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2907         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2908         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2909         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2910         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2911         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2912         target-memory.c, target.c, target.h, target/waitstatus.c,
2913         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2914         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2915         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2916         unittests/array-view-selftests.c,
2917         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2918         unittests/common-utils-selftests.c,
2919         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2920         unittests/format_pieces-selftests.c,
2921         unittests/function-view-selftests.c,
2922         unittests/lookup_name_info-selftests.c,
2923         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2924         unittests/mkdir-recursive-selftests.c,
2925         unittests/observable-selftests.c,
2926         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2927         unittests/parse-connection-spec-selftests.c,
2928         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2929         unittests/scoped_fd-selftests.c,
2930         unittests/scoped_mmap-selftests.c,
2931         unittests/scoped_restore-selftests.c,
2932         unittests/string_view-selftests.c, unittests/style-selftests.c,
2933         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2934         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2935         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2936         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2937         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2938         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2939
2940 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2941
2942         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2943         bool value.
2944         (decode_digits_ordinary): Set explicit_line field in sal.
2945         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2946         symtab_and_line that was set on an explicit line number in
2947         assembler code.  Do always update the recorded symtab and line if
2948         we do skip the prologue.
2949
2950 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2951
2952         * breakpoint.c (set_breakpoint_location_function): Remove
2953         explicit_loc parameter.
2954         (momentary_breakpoint_from_master): Update call to
2955         set_breakpoint_location_function.
2956         (add_location_to_breakpoint): Likewise.
2957
2958 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2959
2960         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2961         required features based on default bfd type when no specific bfd
2962         is present.
2963
2964 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2965
2966         * NEWS: Mention that GDB printf and eval commands can now print
2967         C-style and Ada-style convenience var strings without
2968         calling the inferior.
2969         * printcmd.c (printf_c_string): Locally print GDB internal var
2970         instead of transiting via the inferior.
2971         (printf_wide_c_string): Likewise.
2972
2973 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2974
2975         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2976
2977 2019-07-04  Tom Tromey  <tom@tromey.com>
2978
2979         PR tui/24724:
2980         * tui/tui-winsource.c (tui_clear_source_content): Update.
2981         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2982         (tui_update_breakpoint_info): Update.
2983         (tui_set_exec_info_content): Update.
2984         * tui/tui-source.c (tui_set_source_content_nil): Update.
2985         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2986         has_break.
2987         * tui/tui-data.h (enum tui_bp_flag): New.
2988         (tui_bp_flags): New enum flags type.
2989         (struct tui_source_element) <break_mode>: Change type.  Rename
2990         from has_break.
2991         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2992         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2993         constants.
2994         * tui/tui-winsource.h: Fix comment.
2995
2996 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2997
2998         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2999         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3000         (store_fpregs_to_thread)
3001         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3002         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3003         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3004         (IWMMXT_REGS_SIZE): Add define.
3005         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3006         (fetch_vfp_regs, store_vfp_regs)
3007         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3008         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3009
3010 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3011
3012         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3013         defines.
3014         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3015         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3016         (ARM_INT_REGISTER_SIZE): ...to this.
3017         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3018         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3019         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3020         (arm_linux_collect_gregset, supply_nwfpe_register)
3021         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3022         defines.
3023         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3024         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3025         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3026         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3027         (arm_return_in_memory, arm_store_return_value)
3028         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3029         (arm_record_ld_st_multiple): Likewise.
3030         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3031         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3032
3033 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3034
3035         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3036         AARCH64_DISPLACED_MODIFIED_INSNS.
3037         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3038         (aarch64_displaced_step_copy_insn): Likewise.
3039         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3040         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3041         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3042         ARM_DISPLACED_MODIFIED_INSNS.
3043         * arm-tdep.c (arm_gdbarch_init): Likewise.
3044         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3045         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3046         (struct arm_displaced_step_closure): Use
3047         ARM_DISPLACED_MODIFIED_INSNS.
3048
3049 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3050
3051         * features/Makefile: Remove unused xml files.
3052         * features/aarch64.xml: Remove.
3053         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3054         * features/i386/amd64-avx-avx512.xml: Remove.
3055         * features/i386/amd64-avx-linux.xml: Remove.
3056         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3057         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3058         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3059         * features/i386/amd64-avx-mpx.xml: Remove.
3060         * features/i386/amd64-avx.xml: Remove.
3061         * features/i386/amd64-linux.xml: Remove.
3062         * features/i386/amd64-mpx-linux.xml: Remove.
3063         * features/i386/amd64-mpx.xml: Remove.
3064         * features/i386/amd64.xml: Remove.
3065         * features/i386/i386-avx-avx512-linux.xml: Remove.
3066         * features/i386/i386-avx-avx512.xml: Remove.
3067         * features/i386/i386-avx-linux.xml: Remove.
3068         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3069         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3070         * features/i386/i386-avx-mpx-linux.xml: Remove.
3071         * features/i386/i386-avx-mpx.xml: Remove.
3072         * features/i386/i386-avx.xml: Remove.
3073         * features/i386/i386-linux.xml: Remove.
3074         * features/i386/i386-mmx-linux.xml: Remove.
3075         * features/i386/i386-mmx.xml: Remove.
3076         * features/i386/i386-mpx-linux.xml: Remove.
3077         * features/i386/i386-mpx.xml: Remove.
3078         * features/i386/i386.xml: Remove.
3079         * features/i386/x32-avx-avx512-linux.xml: Remove.
3080         * features/i386/x32-avx-linux.xml: Remove.
3081         * features/i386/x32-linux.xml: Remove.
3082
3083 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3084
3085         * regformats/aarch64.dat: Remove.
3086         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3087         * regformats/i386/amd64-avx-linux.dat: Remove.
3088         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3089         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3090         * regformats/i386/amd64-linux.dat: Remove.
3091         * regformats/i386/amd64-mpx-linux.dat: Remove.
3092         * regformats/i386/amd64.dat: Remove.
3093         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3094         * regformats/i386/i386-avx-linux.dat: Remove.
3095         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3096         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3097         * regformats/i386/i386-linux.dat: Remove.
3098         * regformats/i386/i386-mmx-linux.dat: Remove.
3099         * regformats/i386/i386-mpx-linux.dat: Remove.
3100         * regformats/i386/i386.dat: Remove.
3101         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3102         * regformats/i386/x32-avx-linux.dat: Remove.
3103         * regformats/i386/x32-linux.dat: Remove.
3104
3105 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3106
3107         * aarch64-tdep.c: Remove xml self tests.
3108         * amd64-linux-tdep.c: Likewise.
3109         * amd64-tdep.c: Likewise.
3110         * i386-linux-tdep.c: Likewise.
3111         * i386-tdep.c: Likewise.
3112
3113 2019-07-03  Pedro Alves  <palves@redhat.com>
3114
3115         PR cli/24732
3116         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3117         (pipe_cmd_option_defs): New.
3118         (make_pipe_cmd_options_def_group): New.
3119         (pipe_command): Use gdb::option::process_options.
3120         (pipe_command_completer): New function.
3121         (_initialize_cli_cmds): Install completer for "pipe" command.
3122
3123 2019-07-03  Pedro Alves  <palves@redhat.com>
3124
3125         * cli/cli-option.c (union option_value) <string>: New field.
3126         (struct option_def_and_value): Add ctor, move ctor, dtor and
3127         use DISABLE_COPY_AND_ASSIGN.
3128         (option_def_and_value::clear_value): New.
3129         (parse_option, save_option_value_in_ctx, get_val_type_str)
3130         (add_setshow_cmds_for_options): Handle var_string.
3131         * cli-option.h (union option_def::var_address) <string>: New
3132         field.
3133         (struct string_option_def): New.
3134         * maint-test-options.c (struct test_options_opts): Add default
3135         ctor and use DISABLE_COPY_AND_ASSIGN.
3136         <string_opt>: New field.
3137         (test_options_opts::~test_options_opts): New.
3138         (test_options_opts::dump): Also dump "-string".
3139         (test_options_option_defs): Install "string.
3140
3141 2019-07-03  Pedro Alves  <palves@redhat.com>
3142
3143         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3144         option_value with a null enumeration.
3145         (complete_options): Save the option values in the context.
3146         (save_option_value_in_ctx): New, factored out from ...
3147         (process_options): ... here.
3148         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3149         of the function.
3150         * maint-test-options.c (test_options_opts::dump): New, factored
3151         out from ...
3152         (maintenance_test_options_command_mode): ... here.
3153         (maintenance_test_options_command_completion_result): Delete.
3154         (maintenance_test_options_command_completion_text): Update
3155         comment.
3156         (maintenance_show_test_options_completion_result): Change
3157         prototype.  Just print
3158         maintenance_test_options_command_completion_text.
3159         (save_completion_result): New.
3160         (maintenance_test_options_completer_mode): Pass options context to
3161         complete_options, and then save a dump.
3162         (_initialize_maint_test_options): Use add_cmd to install "maint
3163         show test-options-completion-result".
3164
3165 2019-07-03  Pedro Alves  <palves@redhat.com>
3166
3167         * NEWS (New commands): Mention "with" and "maint with".
3168         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3169         (with_command, with_command_completer): New.
3170         (pipe_command): Adjust to new repeat_previous
3171         interface.
3172         (_initialize_cli_cmds): Install the "with" command and its "w"
3173         alias.
3174         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3175         declarations.
3176         * cli/cli-setshow.c (parse_cli_var_uinteger)
3177         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3178         argument strings for all var_types.
3179         (get_setshow_command_value_string): New, factored out from ...
3180         (do_show_command): ... this.
3181         * cli/cli-setshow.h: Include <string>.
3182         (get_setshow_command_value_string): Declare.
3183         * command.h (repeat_previous): Now returns const char *.  Adjust
3184         comment.
3185         * maint.c: Include "cli/cli-cmds.h".
3186         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3187         (_initialize_maint_cmds): Register the "maintenance with" command.
3188         * top.c (repeat_previous): Move bits from pipe_command here:
3189         Return the saved command line, if any; error out if there's no
3190         command to relaunch.
3191
3192 2019-07-03  Pedro Alves  <palves@redhat.com>
3193
3194         * NEWS (New commands): Mention "maint set/show test-settings"
3195         instead of "maint test-settings".
3196         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3197         (maintenance_test_settings_set_list): Rename to ...
3198         (maintenance_set_test_settings_list): ... this.
3199         (maintenance_test_settings_show_list): Rename to  ...
3200         (maintenance_show_test_settings_list): ... this.
3201         (maintenance_test_settings_cmd): Delete.
3202         (maintenance_test_settings_set_cmd): ...
3203         (maintenance_set_test_settings_cmd): ... this.
3204         (maintenance_test_settings_show_cmd): ...
3205         (maintenance_show_test_settings_cmd): ... this.
3206         (maintenance_test_settings_show_value_cmd):
3207         (maintenance_show_test_settings_value_cmd): ... this.
3208         (_initialize_maint_test_settings): No longer install the "maint
3209         test-settings" prefix command.  Rename "maint test-settings set"
3210         to "maint set test-settings", and "maint test-settings show" to
3211         "maint show test-settings".  Adjust all subcommands.
3212
3213 2019-07-03  Pedro Alves  <palves@redhat.com>
3214
3215         * maint-test-settings.c: Fix file's intro comment.  Replace all
3216         references to "test-options" with references to "test-settings",
3217         in comments.
3218
3219 2019-07-03  Pedro Alves  <palves@redhat.com>
3220
3221         * maint-test-settings.c (maintenance_test_settings_xxx)
3222         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3223         New.
3224         (maintenance_test_settings_enums): Use them.
3225         (maintenance_test_settings_enum): Default to
3226         maintenance_test_settings_xxx.
3227         (_initialize_maint_test_settings): Initialize
3228         MAINTENANCE_TEST_SETTINGS_FILENAME.
3229
3230 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3231
3232         * breakpoint.h (remove_breakpoints_inf): Change return type to
3233         void, move function documentation here.
3234         * breakpoint.c (remove_breakpoints_inf): Change return type to
3235         void, move function documentation to header.
3236
3237 2019-07-02  Pedro Alves  <palves@redhat.com>
3238
3239         * NEWS (Completion improvements): Mention "info threads".
3240         * thread.c (struct info_threads_opts, info_threads_option_defs)
3241         (make_info_threads_options_def_group): New.
3242         (info_threads_command): Use gdb::option::process_options.
3243         (info_threads_command_completer): New.
3244         (_initialize_thread): Use gdb::option::build_help to build the
3245         help text for "info threads".
3246
3247 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3248
3249         * defs.h (generic_load): Move from here...
3250         * symfile.h (generic_load): ... to here.  Rename name parameter
3251         to args.
3252         * symfile.c (generic_load): Add comment.
3253
3254 2019-07-01  Tom Tromey  <tromey@adacore.com>
3255
3256         * dwarf2read.c
3257         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3258         declaration of without_params.  Fix formatting.
3259
3260 2019-07-01  Tom Tromey  <tromey@adacore.com>
3261
3262         * ada-exp.y (find_primitive_type): Update.
3263         * ada-lang.h (ada_lookup_symbol): Update.
3264         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3265         parameter.
3266         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3267
3268 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3269
3270         PR breakpoints/24541
3271         * gdbarch.c: Regenerate.
3272         * gdbarch.h: Regenerate.
3273         * gdbarch.sh: Add 'stap_adjust_register'.
3274         * i386-tdep.c: Include '<unordered_set>'.
3275         (i386_stap_adjust_register): New function.
3276         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3277         * stap-probe.c (stap_parse_register_operand): Call
3278         'gdbarch_stap_adjust_register'.
3279
3280 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3281
3282         PR python/24742
3283         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3284         * python/python.c (do_start_initialization): Use 'xmalloc'
3285         instead of 'PyMem_Malloc'.
3286
3287 2019-06-28  Tom Tromey  <tromey@adacore.com>
3288
3289         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3290         for Ada.
3291
3292 2019-06-27  Tom Tromey  <tromey@adacore.com>
3293
3294         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3295         objfile_key.
3296         (arm_find_mapping_symbol, arm_record_special_symbol)
3297         (_initialize_arm_tdep): Update.
3298         (arm_objfile_data_free): Remove.
3299
3300 2019-06-27  Tom Tromey  <tromey@adacore.com>
3301
3302         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3303         to cp_print_static_field.
3304
3305 2019-06-26  Tom Tromey  <tromey@adacore.com>
3306
3307         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3308         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3309         declare.
3310
3311 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3312
3313         * features/aarch64-core.c (create_feature_aarch64_core):
3314         Regenerate.
3315         * features/aarch64-core.xml: Add cpsr flags.
3316
3317 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3318
3319         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3320         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3321
3322 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3323
3324         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3325         field.
3326         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3327         use.
3328         (arm_record_special_symbol): Don't insert new symbol in sorted
3329         position, push it at the end.
3330
3331 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3332
3333         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3334         (arm_mapping_symbol_s): Remove.
3335         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3336         (arm_mapping_symbol_vec): New typedef.
3337         (struct arm_per_objfile): Add constructor.
3338         <section_maps>: Change type to
3339         std::unique_ptr<arm_mapping_symbol_vec[]>.
3340         (arm_compare_mapping_symbols): Remove.
3341         (arm_find_mapping_symbol): Adjust to section_maps type change.
3342         (arm_objfile_data_free): Call delete on arm_per_objfile.
3343         (arm_record_special_symbol): Adjust to section_maps type change.
3344         Allocate arm_per_objfile with new.
3345
3346 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3347
3348         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3349         with the command prefix.
3350
3351 2019-06-25  Tom Tromey  <tom@tromey.com>
3352
3353         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3354         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3355
3356 2019-06-25  Tom Tromey  <tom@tromey.com>
3357
3358         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3359         type.
3360         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3361         protected.
3362
3363 2019-06-25  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-winsource.c
3366         (tui_source_window_base::set_is_exec_point_at): Add check against
3367         LOA_ADDRESS.
3368
3369 2019-06-25  Tom Tromey  <tom@tromey.com>
3370
3371         * tui/tui-source.c (tui_set_source_content): Don't check before
3372         xfree.
3373         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3374
3375 2019-06-25  Tom Tromey  <tom@tromey.com>
3376
3377         * tui/tui-winsource.h (tui_update_source_window_as_is)
3378         (tui_alloc_source_buffer, tui_line_is_displayed)
3379         (tui_addr_is_displayed): Change type of win_info.
3380         * tui/tui-winsource.c (tui_update_source_window_as_is)
3381         (tui_clear_source_content, tui_show_source_line)
3382         (tui_show_source_content, tui_source_window_base::refill)
3383         (tui_source_window_base::set_is_exec_point_at)
3384         (tui_source_window_base::set_is_exec_point_at)
3385         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3386         (tui_alloc_source_buffer, tui_line_is_displayed)
3387         (tui_addr_is_displayed): Change type of win_info.  Update.
3388         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3389         (tui_source_window_base::do_make_visible_with_new_height):
3390         Update.
3391         * tui/tui-source.c (tui_set_source_content)
3392         (tui_set_source_content_nil)
3393         (tui_source_window::do_scroll_vertical): Update.
3394         * tui/tui-layout.c (show_layout): Update.
3395         * tui/tui-disasm.c (tui_set_disassem_content)
3396         (tui_disasm_window::do_scroll_vertical): Update.
3397         * tui/tui-data.h (tui_win_content): Remove.
3398         (struct tui_gen_win_info) <content, content_size>: Remove.
3399         (struct tui_source_element): Add initializers and destructor.
3400         (union tui_which_element, struct tui_win_element): Remove.
3401         (struct tui_source_window_base) <content>: New field.
3402         (struct tui_data_window): Remove destructor.
3403         (tui_alloc_content, tui_free_win_content)
3404         (tui_free_all_source_wins_content): Don't declare.
3405         * tui/tui-data.c (tui_initialize_static_data): Update.
3406         (init_content_element, tui_alloc_content): Remove.
3407         (~tui_gen_win_info): Update.
3408         (~tui_data_window, tui_free_all_source_wins_content)
3409         (tui_free_win_content, free_content, free_content_elements):
3410         Remove.
3411
3412 2019-06-25  Tom Tromey  <tom@tromey.com>
3413
3414         * tui/tui-winsource.h (tui_clear_source_content)
3415         (tui_erase_source_content, tui_show_source_content): Change type
3416         of win_info.
3417         * tui/tui-winsource.c (tui_clear_source_content)
3418         (tui_erase_source_content, tui_show_source_content): Change type
3419         of win_info.
3420         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3421         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3422         win_info.
3423         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3424         win_info.
3425         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3426
3427 2019-06-25  Tom Tromey  <tom@tromey.com>
3428
3429         * tui/tui-winsource.c (tui_clear_source_content)
3430         (tui_source_window_base::set_is_exec_point_at): Update.
3431         * tui/tui-source.c (tui_set_source_content_nil): Update.
3432         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3433         a bool.
3434         * tui/tui-data.c (init_content_element): Update.
3435
3436 2019-06-25  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3439         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3440         * tui/tui-layout.c (init_and_make_win): Update.
3441         * tui/tui.h (enum tui_win_type): Update.
3442         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3443         tui_win_is_auxillary.
3444         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3445         tui_win_is_auxillary.
3446
3447 2019-06-25  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3450         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3451         (tui_delete_data_content_windows, tui_display_all_data)
3452         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3453         Update.
3454         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3455         * tui/tui-regs.c (tui_last_regs_line_no)
3456         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3457         (tui_show_registers): Update.
3458         (tui_show_register_group): Return void.  Update.
3459         (tui_display_registers_from, tui_display_reg_element_at_line)
3460         (tui_display_registers_from_line, tui_check_register_values):
3461         Update.
3462         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3463         member.
3464         (struct tui_data_window) <regs_content>: Now a std::vector.
3465         <regs_content_count>: Remove.
3466         (tui_add_content_elements, tui_free_data_content): Don't declare.
3467         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3468         (init_content_element): Remove DATA_WIN case.  Add assert.
3469         (tui_add_content_elements): Remove.
3470         (tui_data_window): Update.
3471         (tui_free_data_content): Remove.
3472         (free_content_elements): Remove DATA_WIN case.
3473
3474 2019-06-25  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-data.c (tui_data_item_window): Update.
3477         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3478         * tui/tui-windata.c (tui_display_all_data)
3479         (tui_display_data_from_line): Update.
3480         (tui_check_data_values): Remove.
3481         * tui/tui-regs.c (tui_show_register_group)
3482         (tui_display_reg_element_at_line): Update.
3483         * tui/tui-hooks.c (tui_register_changed)
3484         (tui_refresh_frame_and_register_information): Call
3485         tui_check_register_values.
3486         * tui/tui-data.h (struct tui_data_window) <data_content,
3487         data_content_count, data_type>: Remove.
3488         (enum tui_data_type): Remove.
3489
3490         * tui/tui-data.c (tui_data_window::clear_detail)
3491         (~tui_data_window): Update.
3492
3493 2019-06-25  Tom Tromey  <tom@tromey.com>
3494
3495         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3496         declare.
3497         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3498         Rename from tui_first_data_item_displayed.  Update.
3499         (tui_data_window::refresh_all)
3500         (tui_data_window::do_scroll_vertical): Update.
3501         * tui/tui-data.h (struct tui_data_window)
3502         <first_data_item_displayed>: Declare new method.
3503
3504 2019-06-25  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3507         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3508         contents...
3509         (tui_initialize_static_data): ...here.
3510
3511 2019-06-25  Tom Tromey  <tom@tromey.com>
3512
3513         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3514         (tui_display_registers_from, tui_check_register_values): Update.
3515         (tui_display_register): Remove win_info parameter; update.
3516         (tui_get_register): Change type of parameters.
3517         * tui/tui-data.h (struct tui_data_element): Remove.
3518         (union tui_which_element) <data>: Remove.
3519         <data_window>: Change type.
3520         (struct tui_data_item_window): New.
3521         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3522         case.  Add assert.
3523         (~tui_data_item_window): New destructor.
3524         (free_content_elements): Remove DATA_ITEM_WIN case.
3525
3526 2019-06-25  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3529         Remove.
3530
3531 2019-06-25  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui-data.h (struct tui_command_element): Remove.
3534         (union tui_which_element) <command>: Remove.
3535         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3536         assert.
3537         (free_content_elements): Remove CMD_WIN case.
3538
3539 2019-06-25  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-layout.c (tui_set_layout): Update.
3542         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3543         * tui/tui-data.c (layout_def): Update.
3544
3545 2019-06-25  Tom Tromey  <tom@tromey.com>
3546
3547         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3548         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3549         (tui_source_window_base::set_new_height): Update.
3550         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3551         Update.
3552         (tui_set_locator_fullname, tui_set_locator_info)
3553         (tui_show_frame_info): Update.
3554         * tui/tui-source.c (tui_set_source_content)
3555         (tui_source_is_displayed): Update.
3556         * tui/tui-layout.c (show_source_disasm_command, show_data)
3557         (show_source_or_disasm_and_command): Update.
3558         * tui/tui-disasm.c (tui_set_disassem_content)
3559         (tui_get_begin_asm_address): Update.
3560         * tui/tui-data.h (struct tui_locator_element): Remove.
3561         (union tui_which_element) <locator>: Remove.
3562         (struct tui_locator_window): New.
3563         (tui_locator_win_info_ptr): Change return type.
3564         * tui/tui-data.c (_locator): Change type.
3565         (tui_locator_win_info_ptr): Change return type.
3566         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3567         (tui_alloc_content): Add assert.
3568
3569 2019-06-25  Tom Tromey  <tom@tromey.com>
3570
3571         * tui/tui-winsource.c
3572         (tui_exec_info_window::maybe_allocate_content): New method.
3573         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3574         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3575         (make_source_or_disasm_window): Add cast.
3576         * tui/tui-data.h (union tui_which_element) <simple_string>:
3577         Remove.
3578         (struct tui_source_info): New.
3579         (struct tui_source_window_base) <execution_info>: Change type.
3580         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3581         case, and add assert.
3582         (tui_alloc_content): Add assert.
3583
3584 2019-06-25  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3587         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3588         * tui/tui-data.c (tui_alloc_win_info): Remove.
3589
3590 2019-06-25  Tom Tromey  <tom@tromey.com>
3591
3592         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3593         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3594         can_highlight.
3595
3596 2019-06-25  Tom Tromey  <tom@tromey.com>
3597
3598         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3599         make_visible_with_new_height method.
3600         (tui_win_info::make_visible_with_new_height): New method.
3601         (tui_source_window_base::do_make_visible_with_new_height)
3602         (tui_data_window::do_make_visible_with_new_height)
3603         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3604         (make_visible_with_new_height): Remove.
3605         (tui_resize_all, tui_adjust_win_heights): Use
3606         make_visible_with_new_height method.
3607         * tui/tui-data.h (struct tui_win_info)
3608         <do_make_visible_with_new_height, make_visible_with_new_height>:
3609         New methods.
3610         (struct tui_source_window_base, struct tui_data_window)
3611         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3612         methods.
3613
3614 2019-06-25  Tom Tromey  <tom@tromey.com>
3615
3616         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3617         method.
3618         (update_tab_width): Call update_tab_width method.
3619         * tui/tui-data.h (struct tui_win_info)
3620         (struct tui_source_window_base) <update_tab_width>: New methods.
3621
3622 2019-06-25  Tom Tromey  <tom@tromey.com>
3623
3624         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3625         parameter.
3626         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3627         parameter.
3628         (tui_gen_win_info::make_visible): Update.
3629         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3630         parameter.
3631         * tui/tui-data.h (enum tui_box): New enum.
3632         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3633
3634 2019-06-25  Tom Tromey  <tom@tromey.com>
3635
3636         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3637         init_and_make_win for EXEC_INFO_WIN.
3638         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3639         longer inline.
3640         (struct tui_win_info) <~tui_win_info>: Inline.
3641         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3642         Don't declare.
3643         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3644         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3645         Remove.
3646         (tui_initialize_static_data): Update.
3647         (~tui_gen_win_info): Handle more cleanup here.
3648         (~tui_source_window_base): Delete "execution_info".
3649         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3650
3651 2019-06-25  Tom Tromey  <tom@tromey.com>
3652
3653         * tui/tui-layout.c (make_command_window): Don't set
3654         can_highlight.
3655         (show_source_disasm_command): Call the reset method.
3656         (show_data): Don't set can_highlight.  Call the reset method.
3657         (tui_gen_win_info::reset): Rename from init_gen_win_info
3658         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3659         (show_source_or_disasm_and_command): Call the reset method.
3660         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3661         (struct tui_cmd_window): Set can_highlight.
3662
3663 2019-06-25  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3666         from make_visible.
3667         (tui_make_visible, tui_make_invisible): Rewrite.
3668         (tui_win_info::make_visible): Remove.
3669         (tui_source_window_base::make_visible): Update.
3670         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3671         method.  Moved from...
3672         (struct tui_win_info) <make_visible>: ...here.
3673
3674 2019-06-25  Tom Tromey  <tom@tromey.com>
3675
3676         * tui/tui-winsource.c
3677         (tui_source_window_base::do_scroll_horizontal): Remove direction
3678         parameter.
3679         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3680         direction parameter.
3681         * tui/tui-win.c (tui_win_info::forward_scroll)
3682         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3683         (tui_win_info::right_scroll): Update.
3684         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3685         direction parameter.
3686         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3687         direction parameter.
3688         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3689         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3690         Remove direction parameter.
3691         (struct tui_source_window_base, struct tui_source_window)
3692         (struct tui_disasm_window, struct tui_data_window)
3693         (struct tui_cmd_window): Update.
3694
3695 2019-06-25  Tom Tromey  <tom@tromey.com>
3696
3697         * tui/tui-winsource.h (tui_set_exec_info_content)
3698         (tui_show_exec_info_content, tui_erase_exec_info_content)
3699         (tui_clear_exec_info_content, tui_update_exec_info): Change
3700         argument to tui_source_window_base.
3701         * tui/tui-winsource.c (tui_set_exec_info_content)
3702         (tui_show_exec_info_content, tui_erase_exec_info_content)
3703         (tui_clear_exec_info_content, tui_update_exec_info): Change
3704         argument to tui_source_window_base.
3705
3706 2019-06-25  Tom Tromey  <tom@tromey.com>
3707
3708         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3709         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3710
3711 2019-06-25  Tom Tromey  <tom@tromey.com>
3712
3713         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3714         check.
3715
3716 2019-06-25  Tom Tromey  <tom@tromey.com>
3717
3718         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3719         type to void.
3720         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3721         type to void.
3722         * tui/tui-source.c (tui_set_source_content): Update.
3723         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3724
3725 2019-06-25  Tom Tromey  <tom@tromey.com>
3726
3727         * tui/tui-win.c (window_name_completer, tui_set_focus)
3728         (tui_all_windows_info): Use name method.
3729         * tui/tui-data.h (struct tui_gen_win_info)
3730         (struct tui_source_window, struct tui_disasm_window)
3731         (struct tui_data_window, struct tui_cmd_window) <name>: New
3732         method.
3733         (tui_win_name): Don't declare.
3734         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3735         (tui_win_name): Remove.
3736
3737 2019-06-25  Tom Tromey  <tom@tromey.com>
3738
3739         * tui/tui-winsource.h (tui_update_source_window)
3740         (tui_update_source_window_as_is): Change parameter type.
3741         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3742         to be a tui_source_window_base.
3743         (tui_update_source_window_as_is): Likewise.
3744         * tui/tui-win.c (make_visible_with_new_height): Update.
3745
3746 2019-06-25  Tom Tromey  <tom@tromey.com>
3747
3748         * tui/tui-winsource.c (tui_erase_source_content)
3749         (tui_show_source_content, tui_show_exec_info_content)
3750         (tui_erase_exec_info_content): Use refresh_window method.
3751         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3752         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3753         from tui_refresh_win.
3754         (tui_data_window::refresh_window): New method.
3755         (tui_win_info::refresh, tui_source_window_base::refresh)
3756         (tui_refresh_all): Use refresh_window method.
3757         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3758         method.
3759         * tui/tui-regs.c (tui_display_register): Call refresh_window
3760         method.
3761         * tui/tui-layout.c (show_source_disasm_command)
3762         (show_source_or_disasm_and_command): Call refresh_window method.
3763         * tui/tui-data.h (struct tui_gen_win_info)
3764         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3765         New method.
3766
3767 2019-06-25  Tom Tromey  <tom@tromey.com>
3768
3769         * tui/tui.c (tui_rl_other_window, tui_enable)
3770         (tui_is_window_visible, tui_get_command_dimension): Update.
3771         * tui/tui-winsource.c (tui_update_source_window_as_is)
3772         (tui_clear_source_content, tui_erase_source_content)
3773         (tui_show_source_line, tui_source_window_base::refill)
3774         (tui_source_window_base::do_scroll_horizontal)
3775         (tui_source_window_base::set_is_exec_point_at)
3776         (tui_update_breakpoint_info, tui_set_exec_info_content)
3777         (tui_alloc_source_buffer, tui_line_is_displayed)
3778         (tui_addr_is_displayed): Update.
3779         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3780         (tui_check_and_display_highlight_if_needed)
3781         (tui_win_info::make_visible, tui_win_info::refresh)
3782         (tui_refresh_all): Update.
3783         * tui/tui-windata.c (tui_first_data_item_displayed)
3784         (tui_delete_data_content_windows, tui_erase_data_content)
3785         (tui_display_all_data, tui_data_window::refresh_all)
3786         (tui_check_data_values): Update.
3787         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3788         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3789         (tui_win_info::backward_scroll, tui_refresh_all_win)
3790         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3791         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3792         (tui_source_window_base::set_new_height)
3793         (tui_data_window::set_new_height)
3794         (make_invisible_and_set_new_height)
3795         (make_visible_with_new_height, new_height_ok)
3796         (parse_scrolling_args): Update.
3797         * tui/tui-stack.c (tui_show_frame_info): Update.
3798         * tui/tui-source.c (tui_set_source_content)
3799         (tui_set_source_content_nil, tui_source_is_displayed)
3800         (tui_source_window::do_scroll_vertical): Update.
3801         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3802         (tui_display_registers_from, tui_display_reg_element_at_line)
3803         (tui_check_register_values, tui_reg_command): Update.
3804         * tui/tui-layout.c (tui_default_win_height)
3805         (show_source_disasm_command, show_data, init_and_make_win)
3806         (show_source_or_disasm_and_command): Update.
3807         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3808         (tui_redisplay_readline, tui_mld_flush)
3809         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3810         (tui_getc): Update.
3811         * tui/tui-disasm.c (tui_set_disassem_content)
3812         (tui_disasm_window::do_scroll_vertical): Update.
3813         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3814         Now virtual.
3815         (struct tui_win_info): Derive from tui_gen_win_info.
3816         <~tui_win_info>: Mark as override.
3817         <generic>: Remove member.
3818         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3819         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3820         (~tui_data_window, ~tui_win_info)
3821         (tui_free_all_source_wins_content): Update.
3822         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3823
3824 2019-06-25  Tom Tromey  <tom@tromey.com>
3825
3826         * tui/tui-layout.c (init_and_make_win): Use new.
3827         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3828         destructor, initializers.
3829         (tui_alloc_generic_win_info): Don't declare.
3830         * tui/tui-data.c (_locator): Add argument to constructor.
3831         (source_win, disasm_win): New globals.
3832         (exec_info): Remove.
3833         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3834         Update.
3835         (tui_alloc_generic_win_info): Remove.
3836         (init_content_element): Use new.
3837         (tui_win_info::tui_win_info): Update.
3838         (free_content_elements) <case DATA_WIN>: Use delete.
3839
3840 2019-06-25  Tom Tromey  <tom@tromey.com>
3841
3842         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3843         * tui/tui-windata.c (tui_first_data_item_displayed)
3844         (tui_delete_data_content_windows): Update.
3845         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3846         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3847         (tui_display_registers_from, tui_check_register_values): Update.
3848         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3849         pointer.
3850         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3851         window.
3852         (tui_free_data_content): Update.
3853         (free_content_elements) <case DATA_WIN>: Free the window.
3854
3855 2019-06-25  Tom Tromey  <tom@tromey.com>
3856
3857         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3858         Update.
3859         * tui/tui-layout.c (make_command_window)
3860         (show_source_disasm_command, show_data, init_and_make_win)
3861         (show_source_or_disasm_and_command): Update.
3862         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3863         method.
3864         <can_highight, is_highlighted>: Now bool.
3865         (tui_set_win_highlight): Don't declare.
3866         * tui/tui-data.c (tui_set_win_highlight): Remove.
3867
3868 2019-06-25  Tom Tromey  <tom@tromey.com>
3869
3870         * tui/tui-wingeneral.c (make_visible): Remove check of window
3871         type.
3872
3873 2019-06-25  Tom Tromey  <tom@tromey.com>
3874
3875         * tui/tui-win.c (tui_win_info::max_height)
3876         (tui_cmd_window::max_height): New methods.
3877         (new_height_ok): Call max_height.
3878         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3879         <max_height>: New method.
3880
3881 2019-06-25  Tom Tromey  <tom@tromey.com>
3882
3883         * tui/tui-win.c (tui_source_window_base::set_new_height)
3884         (tui_data_window::set_new_height): New methods.
3885         (make_invisible_and_set_new_height): Call set_new_height method.
3886         * tui/tui-data.h (struct tui_win_info)
3887         (struct tui_source_window_base, struct tui_data_window)
3888         <set_new_height>: New method.
3889
3890 2019-06-25  Tom Tromey  <tom@tromey.com>
3891
3892         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3893         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3894         tui_refresh_data_win.
3895         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3896         method.
3897         (tui_refresh_all_win): Call the refresh_all method.
3898         (tui_set_focus): Likewise.
3899         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3900         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3901         Likewise.
3902
3903 2019-06-25  Tom Tromey  <tom@tromey.com>
3904
3905         * tui/tui-winsource.h (tui_refill_source_window)
3906         (tui_set_is_exec_point_at): Don't declare.
3907         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3908         (tui_source_window_base::refill): Rename from
3909         tui_refill_source_window.
3910         (tui_source_window_base::do_scroll_horizontal): Update.
3911         (tui_source_window_base::set_is_exec_point_at): Rename from
3912         tui_set_is_exec_point_at.
3913         (tui_update_all_breakpoint_info): Update.
3914         * tui/tui-stack.c (tui_show_frame_info): Update.
3915         * tui/tui-layout.c (show_data): Add cast.
3916         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3917         * tui/tui-data.h (struct tui_source_window_base) <refill,
3918         set_is_exec_point_at>: New methods.
3919         (tui_source_windows, tui_add_to_source_windows): Update types.
3920         (tui_add_to_source_windows): Remove redundant declaration.
3921         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3922         (tui_source_windows): Change return type.
3923         (tui_clear_source_windows_detail): Update.
3924         (tui_add_to_source_windows): Change type of parameter.
3925         (tui_free_all_source_wins_content): Update.
3926
3927 2019-06-25  Tom Tromey  <tom@tromey.com>
3928
3929         * tui/tui-wingeneral.c (tui_win_info::refresh)
3930         (tui_source_window_base::refresh): New methods.
3931         (tui_refresh_all): Call the refresh method.
3932         * tui/tui-data.h (struct tui_win_info)
3933         (struct tui_source_window_base) <refresh>: New method.
3934
3935 2019-06-25  Tom Tromey  <tom@tromey.com>
3936
3937         * tui/tui.h (tui_is_window_visible): Return bool.
3938         * tui/tui.c (tui_is_window_visible): Return bool.
3939         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3940         (tui_make_visible, tui_make_invisible)
3941         (tui_win_info::make_visible)
3942         (tui_source_window_base::make_visible, make_all_visible)
3943         (tui_make_all_visible, tui_make_all_invisible): Update.
3944         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3945         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3946         bool.
3947         (struct tui_win_info, struct tui_source_window_base)
3948         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3949         * tui/tui-data.c (tui_init_generic_part): Update.
3950
3951 2019-06-25  Tom Tromey  <tom@tromey.com>
3952
3953         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3954         (tui_source_window_base::make_visible): New methods.
3955         (make_all_visible): Make method call.
3956         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3957         (struct tui_source_window_base, struct tui_cmd_window): Override
3958         make_visible.
3959         (tui_win_is_source_type): Don't declare.
3960         * tui/tui-data.c (tui_win_is_source_type): Remove.
3961
3962 2019-06-25  Tom Tromey  <tom@tromey.com>
3963
3964         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3965         NULL check.
3966
3967 2019-06-25  Tom Tromey  <tom@tromey.com>
3968
3969         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3970         Inline constructor.  Add initializers for members.
3971         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3972         constructors; now inline in class.
3973
3974 2019-06-25  Tom Tromey  <tom@tromey.com>
3975
3976         * tui/tui-regs.c (tui_show_registers): Update.
3977         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3978         bool.
3979         * tui/tui-data.c (tui_data_window::clear_detail)
3980         (tui_data_window): Update.
3981
3982 2019-06-25  Tom Tromey  <tom@tromey.com>
3983
3984         * tui/tui-windata.c (tui_display_all_data)
3985         (tui_display_data_from_line, tui_display_data_from)
3986         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3987         Update.
3988         * tui/tui-regs.c (tui_last_regs_line_no)
3989         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3990         (tui_show_registers, tui_show_register_group)
3991         (tui_display_registers_from, tui_display_reg_element_at_line)
3992         (tui_display_registers_from_line, tui_check_register_values)
3993         (tui_reg_next, tui_reg_prev): Update.
3994         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3995         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3996         tui_data_window.
3997         (struct tui_win_info) <detail>: Remove.  Add new fields from
3998         tui_data_info.
3999         (TUI_DATA_WIN): Add cast.
4000         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4001         (~tui_data_window): Simplify.
4002
4003 2019-06-25  Tom Tromey  <tom@tromey.com>
4004
4005         * tui/tui-layout.c (show_source_disasm_command)
4006         (show_source_or_disasm_and_command): Update.
4007         * tui/tui-io.c (update_cmdwin_start_line)
4008         (tui_redisplay_readline): Update.
4009         * tui/tui-data.h (struct tui_command_info): Remove.
4010         (struct tui_win_info) <detail>: Remove command_info member.
4011         (struct tui_data_window) <start_line>: New member, from
4012         tui_command_info.
4013         (TUI_CMD_WIN): Add casts.
4014
4015 2019-06-25  Tom Tromey  <tom@tromey.com>
4016
4017         * tui/tui-winsource.c (tui_update_source_window)
4018         (tui_refill_source_window)
4019         (tui_source_window_base::do_scroll_horizontal)
4020         (tui_update_breakpoint_info, tui_set_exec_info_content)
4021         (tui_show_exec_info_content, tui_erase_exec_info_content)
4022         (tui_clear_exec_info_content): Update.
4023         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4024         Update.
4025         * tui/tui-win.c (make_invisible_and_set_new_height)
4026         (make_visible_with_new_height): Update.
4027         * tui/tui-source.c (tui_set_source_content)
4028         (tui_show_symtab_source): Update.
4029         * tui/tui-layout.c (extract_display_start_addr)
4030         (show_source_disasm_command, show_data)
4031         (make_source_or_disasm_window)
4032         (show_source_or_disasm_and_command): Update.
4033         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4034         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4035         "gdbarch".
4036         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4037         to tui_source_window_base.
4038         (struct tui_win_info) <detail>: Remove source_info member.
4039         (struct tui_source_window_base) <has_locator>: Inline.
4040         Move contents from tui_source_info; rename has_locator member to
4041         m_has_locator.
4042         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4043         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4044         header file.
4045         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4046         Simplify.
4047         (tui_free_all_source_wins_content): Cast to
4048         tui_source_window_base.
4049
4050 2019-06-25  Tom Tromey  <tom@tromey.com>
4051
4052         * tui/tui-win.c (make_invisible_and_set_new_height)
4053         (make_visible_with_new_height): Call has_locator method.
4054         * tui/tui-layout.c (show_source_disasm_command, show_data)
4055         (show_source_or_disasm_and_command): Update for bool change.
4056         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4057         (tui_win_info) <has_locator>: New method.
4058         (struct tui_source_window_base) <has_locator>: New method.
4059         (tui_win_has_locator): Don't declare.
4060         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4061         from tui_win_has_locator.
4062         (tui_source_window_base): Use false, not FALSE.
4063
4064 2019-06-25  Tom Tromey  <tom@tromey.com>
4065
4066         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4067         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4068         clear_detail method directly.
4069         (tui_clear_win_detail): Remove.
4070
4071 2019-06-25  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4074         "this", not TUI_DISASM_WIN.
4075
4076 2019-06-25  Tom Tromey  <tom@tromey.com>
4077
4078         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4079         declare.
4080         * tui/tui-winsource.c
4081         (tui_source_window_base::do_scroll_horizontal): Rename from
4082         tui_horizontal_source_scroll.
4083         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4084         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4085         from tui_vertical_data_scroll.
4086         * tui/tui-win.h (tui_scroll): Don't declare.
4087         * tui/tui-win.c (tui_win_info::forward_scroll)
4088         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4089         (tui_win_info::right_scroll): Rename and update.
4090         (tui_scroll_forward_command, tui_scroll_backward_command)
4091         (tui_scroll_left_command, tui_scroll_right_command): Update.
4092         (tui_scroll): Remove.
4093         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4094         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4095         from tui_vertical_source_scroll.
4096         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4097         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4098         from tui_vertical_disassem_scroll.
4099         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4100         do_scroll_horizontal>: New methods.
4101         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4102         Likewise.
4103         (struct tui_source_window_base): Add do_scroll_horizontal.
4104         (struct tui_source_window, struct tui_disasm_window): Add
4105         do_scroll_vertical.
4106         (struct tui_data_window, struct tui_cmd_window): Add
4107         do_scroll_horizontal and do_scroll_vertical.
4108         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4109
4110 2019-06-25  Tom Tromey  <tom@tromey.com>
4111
4112         * tui/tui-data.h (struct tui_source_window_base): New struct.
4113         (struct tui_source_window): Derive from tui_source_window_base.
4114         (struct tui_disasm_window): New struct.
4115         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4116         from tui_source_window::clear_detail.
4117         (tui_source_window_base): Rename from tui_source_window.
4118         (~tui_source_window_base): Rename from ~tui_source_window.
4119         (tui_alloc_win_info): Create a tui_disasm_window.
4120
4121 2019-06-25  Tom Tromey  <tom@tromey.com>
4122
4123         * tui/tui-data.h (struct tui_source_window)
4124         (struct tui_data_window): Declare destructors.
4125         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4126         destructors.
4127         (tui_win_info): Simplify.
4128
4129 2019-06-25  Tom Tromey  <tom@tromey.com>
4130
4131         * tui/tui-winsource.c (tui_display_main)
4132         (tui_update_source_windows_with_addr)
4133         (tui_update_all_breakpoint_info): Update.
4134         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4135         (new_height_ok, parse_scrolling_args): Update.
4136         * tui/tui-stack.c (tui_show_frame_info): Update.
4137         * tui/tui-data.h (struct tui_list): Remove.
4138         (tui_source_windows): Return a reference to a std::vector.
4139         * tui/tui-data.c (source_windows): Now a std::vector.
4140         (tui_source_windows): Change return type.
4141         (tui_clear_source_windows): Rewrite.
4142         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4143         (tui_free_all_source_wins_content): Rewrite.
4144
4145 2019-06-25  Tom Tromey  <tom@tromey.com>
4146
4147         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4148         (struct tui_data_window, struct tui_cmd_window): Declare
4149         clear_detail method.
4150         * tui/tui-data.c (tui_source_window::clear_detail)
4151         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4152         methods.
4153         (tui_clear_win_detail): Simplify.
4154
4155 2019-06-25  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-layout.c (make_source_window, make_disasm_window)
4158         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4159         Return the new window.
4160         (show_source_disasm_command, show_data)
4161         (show_source_or_disasm_and_command): Update.
4162
4163 2019-06-25  Tom Tromey  <tom@tromey.com>
4164
4165         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4166         parameter.  Return the new window.
4167         (show_source_disasm_command): Update and remove NULL check.
4168         (show_source_or_disasm_and_command): Update.
4169
4170 2019-06-25  Tom Tromey  <tom@tromey.com>
4171
4172         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4173
4174 2019-06-25  Tom Tromey  <tom@tromey.com>
4175
4176         * tui/tui-data.h (struct tui_win_info): Make constructor
4177         protected.  Make destructor virtual.  Add initializers.
4178         (tui_source_window, tui_data_window, tui_cmd_window): New
4179         classes.
4180         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4181         constructor.  Add "type" parameter.
4182         (tui_source_window, tui_data_window, tui_cmd_window): New
4183         constructors.
4184         (tui_alloc_win_info): Instantiate the appropriate subclass.
4185
4186 2019-06-25  Tom Tromey  <tom@tromey.com>
4187
4188         * tui/tui-win.c (tui_resize_all): Use delete.
4189         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4190         destructor.
4191         (tui_free_window): Don't declare.
4192         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4193         Update.
4194
4195 2019-06-25  Tom Tromey  <tom@tromey.com>
4196
4197         * tui/tui-data.h (struct tui_win_info): Add constructor.
4198         * tui/tui-data.c (tui_alloc_win_info): Use new.
4199         (tui_free_window): Use delete.
4200
4201 2019-06-22  Tom Tromey  <tom@tromey.com>
4202
4203         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4204         declare.
4205         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4206
4207 2019-06-22  Tom Tromey  <tom@tromey.com>
4208
4209         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4210         declare.
4211         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4212
4213 2019-06-22  Tom de Vries  <tdevries@suse.de>
4214
4215         * dwarf2read.c (create_addrmap_from_aranges)
4216         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4217         instead of '%zu'.
4218
4219 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4220
4221         * dwarf2read.h (dwarf2_section_info_def): Remove.
4222         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4223         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4224         std::vector<dwarf2_section_info>.
4225         (struct dwo_file) <~dwo_file>: Remove.
4226         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4227         types field.
4228         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4229         (dwarf2_read_debug_names): Likewise.
4230         (create_debug_types_hash_table): Change parameter type to
4231         array_view, adjust code accordingly.
4232         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4233         (partial_die_info::fixup): Likewise.
4234         (determine_prefix): Likewise.
4235         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4236
4237 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4238
4239         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4240         gdb_bfd_ref_ptr.
4241         <~dwo_file>: Remove call to gdb_bfd_unref.
4242         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4243         gdb_bfd_ref_ptr::get.
4244
4245 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4246
4247         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4248         type to htab_up.
4249         * dwarf2read.c (struct dwo_file): Initialize fields.
4250         <~dwo_file>: New.
4251         (free_dwo_file): Remove, move content to ~dwo_file.
4252         (struct dwo_file_deleter): Remove.
4253         (dwo_file_up>: Remove custom deleter.
4254         (free_dwo_files): Remove.
4255         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4256         dwo_files.
4257         (process_skeletonless_type_units): Call unique_ptr::get.
4258         (allocate_dwo_file_hash_table): Add deleter to created hash
4259         table.  Change return type to htab_up.
4260         (lookup_dwo_file_slot): Don't memset dwo_file, call
4261         unique_ptr::get.
4262         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4263         (create_dwo_unit_in_dwp_v2): Likewise.
4264         (open_and_init_dwo_file): Likewise.
4265         (free_dwo_file_from_slot): Remove.
4266
4267 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4268
4269         * dwarf2read.h (struct dwarf2_section_info) <readin,
4270         is_virtual>: Change type to bool.
4271         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4272         true instead of 1.
4273
4274 2019-06-19  Tom Tromey  <tom@tromey.com>
4275
4276         * tui/tui-data.h (tui_init_content_element): Don't declare.
4277
4278 2019-06-19  Tom Tromey  <tom@tromey.com>
4279
4280         * tui/tui-data.h (tui_init_win_info): Don't declare.
4281
4282 2019-06-19  Tom de Vries  <tdevries@suse.de>
4283
4284         * dwarf2read.h (abstract_to_concrete): Change type to
4285         std::unordered_map<sect_offset, std::vector<sect_offset>,
4286         gdb::hash_enum<sect_offset>>.
4287
4288 2019-06-19  Tom Tromey  <tromey@adacore.com>
4289
4290         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4291         EVAL_AVOID_SIDE_EFFECTS specially.
4292
4293 2019-06-19  Tom Tromey  <tromey@adacore.com>
4294
4295         * source-cache.c (highlighter): New global.
4296         (source_cache::get_source_lines): Create a highlighter on demand.
4297
4298 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4299
4300         * defs.h (deprecated_interactive_hook): Delete declaration.
4301         * interps.c (clear_interpreter_hooks): Remove use of
4302         deprecated_interactive_hook.
4303         * top.c (deprecated_interactive_hook): Delete definition.
4304         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4305
4306 2019-06-18  Tom de Vries  <tdevries@suse.de>
4307
4308         PR gdb/24515
4309         * dwarf2read.h (abstract_to_concrete): Change type from
4310         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4311         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4312         * dwarf2read.c (read_variable): Update.
4313         (dwarf2_fetch_die_loc_sect_off): Update.
4314
4315 2019-06-17  Tom de Vries  <tdevries@suse.de>
4316
4317         PR gdb/24617
4318         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4319         accessing parent[parent_len - 1].
4320
4321 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4322
4323         PR gdb/24364
4324         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4325         call dtrace_process_dof with NULL dof.
4326
4327 2019-06-16  Tom de Vries  <tdevries@suse.de>
4328
4329         PR gdb/24445
4330         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4331
4332 2019-06-16  Tom Tromey  <tom@tromey.com>
4333
4334         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4335         (make_all_visible): Use address of member.
4336
4337 2019-06-16  Tom Tromey  <tom@tromey.com>
4338
4339         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4340         (tui_free_window, free_content, free_content_elements): Remove
4341         unnecessary cast.
4342         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4343         cast.
4344         * tui/tui-regs.c (tui_show_register_group)
4345         (tui_display_registers_from, tui_display_reg_element_at_line):
4346         Remove unnecessary cast.
4347
4348 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4349
4350         * linux-nat.c (normal_mask): Delete.
4351         (_initialize_linux_nat): Don't initialise normal_mask.
4352
4353 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4354
4355         PR gdb/24445
4356         * dwarf-index-write.h (write_psymtabs_to_index): Add
4357         dwz_basename parameter.
4358         * dwarf-index-write.c (write_gdbindex): Move file writing to
4359         write_gdbindex_1.  Change return type void.
4360         (assert_file_size): Move up, remove filename parameter.
4361         (write_gdbindex_1): New function.
4362         (write_debug_names): Change return type to void, call
4363         assert_file_size.
4364         (struct index_wip_file): New struct.
4365         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4366         file logic to index_wip_file.  Write index for dwz file if
4367         needed.
4368         (save_gdb_index_command): Pass basename of dwz file, if present.
4369         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4370         build-id of dwz file, if present.
4371         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4372         (dwarf2_get_dwz_file): Likewise.
4373         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4374         (dwarf2_get_dwz_file): Likewise.
4375
4376 2019-06-16  Tom Tromey  <tom@tromey.com>
4377
4378         * coffread.c (process_coff_symbol): Use xstrdup.
4379         * value.c (create_internalvar): Use xstrdup.
4380
4381 2019-06-16  Tom Tromey  <tom@tromey.com>
4382
4383         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4384         * breakpoint.c (stopin_command, stopat_command)
4385         (until_break_command, decode_location_default): Remove unnecessary
4386         cast.
4387         * utils.c (subset_compare): Remove unnecessary cast.
4388         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4389         cast.
4390         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4391         cast.
4392         * infcmd.c (path_command): Remove unnecessary cast.
4393         * coffread.c (decode_type): Remove unnecessary cast.
4394         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4395         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4396         * tui/tui-stack.c (tui_show_locator_content)
4397         (tui_show_frame_info): Remove unnecessary cast.
4398         * tui/tui-win.c (tui_scroll_forward_command)
4399         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4400         (parse_scrolling_args): Remove unnecessary cast.
4401         * tui/tui-data.c (init_win_info, tui_del_window)
4402         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4403         (free_content_elements): Remove unnecessary cast.
4404         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4405         unnecessary cast.
4406         * tui/tui-source.c (tui_set_source_content)
4407         (tui_vertical_source_scroll): Remove unnecessary cast.
4408         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4409         cast.
4410         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4411         * tui/tui-regs.c (tui_display_registers_from)
4412         (tui_display_register): Remove unnecessary cast.
4413         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4414         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4415         (make_visible): Remove unnecessary cast.
4416         * tui/tui-winsource.c (tui_erase_source_content)
4417         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4418         unnecessary cast.
4419         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4420         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4421         * stabsread.c (read_type, read_array_type, read_range_type):
4422         Remove unnecessary cast.
4423         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4424         (parse_symbol, parse_type, upgrade_type, parse_external)
4425         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4426         unnecessary cast.
4427         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4428
4429 2019-06-16  Tom Tromey  <tom@tromey.com>
4430
4431         * tui/tui-data.c (tui_alloc_generic_win_info)
4432         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4433         checks.
4434
4435 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4436             Andrew Burgess  <andrew.burgess@embecosm.com>
4437
4438         * f-typeprint.c (f_print_type): Don't return early for not
4439         associated or not allocated types.
4440         (f_type_print_varspec_suffix): Add print_rank parameter and print
4441         ranks of array types in case they dangling.
4442         (f_type_print_base): Add print_rank parameter.
4443
4444 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4445
4446         * NEWS: Mention new MI commands.
4447         * break-catch-throw.c (enum exception_event_kind): Move to
4448         breakpoint.h.
4449         (print_mention_exception_catchpoint): Output text as a single
4450         message.
4451         (catch_exception_command_1): Rename to...
4452         (catch_exception_event): ...this, make non-static, update header
4453         command, and change some parameter types.
4454         (catch_catch_command): Update for changes to
4455         catch_exception_command_1.
4456         (catch_throw_command): Likewise.
4457         (catch_rethrow_command): Likewise.
4458         * breakpoint.c (enum exception_event_kind): Delete.
4459         * breakpoint.h (enum exception_event_kind): Moved here from
4460         break-catch-throw.c.
4461         (catch_exception_event): Declare.
4462         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4463         (mi_cmd_catch_throw): New function.
4464         (mi_cmd_catch_rethrow): New function.
4465         (mi_cmd_catch_catch): New function.
4466         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4467         'catch-catch' entries.
4468         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4469         (mi_cmd_catch_rethrow): Declare.
4470         (mi_cmd_catch_catch): Declare.
4471
4472 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4473
4474         * annotate.c (annotate_source_line): Change return type to void,
4475         update implementation to match.
4476         * annotate.h (annotate_source_line): Change return type to void,
4477         update header comment.
4478         * stack.c (print_frame_info): Don't change what frame information
4479         is printed based on whether annotations are on or not.
4480
4481 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4482
4483         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4484         (annotate_source): Make static.
4485         (annotate_source_line): Moved from source.c and renamed from
4486         identify_source_line.  Update the return type.
4487         * annotate.h (annotate_source): Delete declaration.
4488         (annotate_source_line): Declaration moved from source.h, and
4489         renamed from identify_source_line.  Return type updated.
4490         * source.c (identify_source_line): Moved to annotate.c and renamed
4491         to annotate_source_line.
4492         (info_line_command): Remove check of annotation_level.
4493         * source.h (identify_source_line): Move declaration to annotate.h
4494         and rename to annotate_source_line.
4495         * stack.c: Add 'annotate.h' include.
4496         (print_frame_info): Remove check of annotation_level before
4497         calling annotate_source_line.
4498
4499 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4500
4501         * source-cache.c (source_cache::get_plain_source_lines): Use
4502         open_source_file_with_line_charpos instead of just
4503         open_source_file, remove call to find_source_lines.
4504         (source_cache::get_source_lines): Likewise.
4505         * source.c (find_source_lines): Make static.
4506         (get_filename_and_charpos): Renamed into...
4507         (open_source_file_with_line_charpos): ..this along with changes to
4508         return a scoped_fd, and some other minor clean ups.
4509         (identify_source_line): Use open_source_file_with_line_charpos.
4510         (search_command_helper): Use open_source_file_with_line_charpos
4511         instead of just open_source_file, remove call to
4512         find_source_lines.
4513         * source.h (open_source_file_with_line_charpos): Declare new
4514         function.
4515         (find_source_lines): Delete declaration.
4516
4517 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4518
4519         * source.c (get_filename_and_charpos): Remove fullname
4520         parameter.
4521         (identify_source_line): Update call to get_filename_and_charpos.
4522
4523 2019-06-14  Tom Tromey  <tromey@adacore.com>
4524
4525         PR gdb/24502:
4526         * ui-style.h (skip_ansi_escape): Update comment.
4527         * ui-file.h (class no_terminal_escape_file): New class.
4528         * ui-file.c (no_terminal_escape_file::write)
4529         (no_terminal_escape_file::puts): New methods.
4530         * cli/cli-logging.c (handle_redirections): Use
4531         no_terminal_escape_file.
4532
4533 2019-06-14  Tom Tromey  <tromey@adacore.com>
4534
4535         * NEWS: Move convenience variable news above Python news.
4536
4537 2019-06-14  Tom Tromey  <tom@tromey.com>
4538
4539         * gnulib: Move directory to top-level.
4540         * configure.ac: Don't configure gnulib.
4541         * configure: Rebuild.
4542         * common/common-defs.h: Use new path to gnulib.
4543         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4544         (GNULIB_H): Remove.
4545         (INCGNU): Look in new gnulib location.
4546         (HFILES_NO_SRCDIR): Remove gnulib files.
4547         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4548         (generated_files): Remove GNULIB_H.
4549         ($(LIBGNU), all-lib): Remove targets.
4550         (distclean): Don't mention GNULIB_BUILDDIR.
4551         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4552
4553 2019-06-14  Tom Tromey  <tromey@adacore.com>
4554
4555         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4556         Warn if symbol file does not provide any symbols.
4557
4558 2019-06-14  Tom Tromey  <tromey@adacore.com>
4559
4560         * source.c (find_and_open_source): Respect basenames_may_differ.
4561
4562 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4563
4564         * annotate.c (annotate_breakpoints_invalid): Make use of
4565         scoped_restore_terminal_state.
4566         (annotate_frames_invalid): Likewise.
4567
4568 2019-06-14  Tom Tromey  <tromey@adacore.com>
4569
4570         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4571         allow assignment to an internalvar.
4572
4573 2019-06-14  Tom Tromey  <tromey@adacore.com>
4574
4575         * ada-lex.l: Allow "_" in attribute names.
4576
4577 2019-06-14  Tom Tromey  <tromey@adacore.com>
4578
4579         PR gdb/24653:
4580         * regcache.c (registers_changed): Don't call alloca.
4581         * top.c (execute_command): Don't call alloca.
4582
4583 2019-06-13  Pedro Alves  <palves@redhat.com>
4584
4585         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4586         'expression'.  When parsing an expression, error out if there's
4587         junk after "unlimited".
4588         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4589         (do_set_command): Adjust calls to is_unlimited_literal.
4590
4591 2019-06-13  Pedro Alves  <palves@redhat.com>
4592
4593         * compile/compile.c (make_compile_options_def_group): Add braces
4594         around array_view initializer.
4595         * thread.c (make_thread_apply_all_options_def_group)
4596         (make_thread_apply_all_options_def_group): Likewise.
4597
4598 2019-06-13  Pedro Alves  <palves@redhat.com>
4599
4600         * NEWS (New commands): Mention "maint test-options
4601         require-delimiter", "maint test-options unknown-is-error", "maint
4602         test-options unknown-is-operand" and "maint show
4603         test-options-completion-result".
4604         (New command options, command completion): New section.
4605         (Completion improvements): New section.
4606         Mention that you can abbreviate "unlimited".
4607
4608 2019-06-13  Pedro Alves  <palves@redhat.com>
4609
4610         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4611         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4612         * unittests/cli-utils-selftests.c (test_parse_flags)
4613         (test_parse_flags_qcs): Delete.
4614         (test_cli_utils): Don't call deleted functions.
4615
4616 2019-06-13  Pedro Alves  <palves@redhat.com>
4617
4618         * thread.c: Include "cli/cli-option.h".
4619         (tp_array_compar_ascending): Global.
4620         (tp_array_compar): Delete function.
4621         (tp_array_compar_ascending, tp_array_compar_descending): New
4622         functions.
4623         (ascending_option_def, qcs_flag_option_def)
4624         (thr_qcs_flags_option_defs)
4625         (make_thread_apply_all_options_def_group)
4626         (make_thread_apply_options_def_group): New.
4627         (thread_apply_all_command): Use gdb::option::process_options.
4628         (thread_apply_command_completer)
4629         (thread_apply_all_command_completer): New.
4630         (thread_apply_command): Use gdb::option::process_options.
4631         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4632         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4633         to generate help text of "thread apply".  Adjust "taas"'s help.
4634         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4635         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4636
4637 2019-06-13  Pedro Alves  <palves@redhat.com>
4638
4639         * thread.c (thread_apply_command): Check for invalid TID with
4640         isdigit instead of !isalpha.
4641
4642 2019-06-13  Pedro Alves  <palves@redhat.com>
4643
4644         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4645         (validate_flags_qcs): New.
4646         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4647         (validate_flags_qcs): Declare.
4648         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4649         (make_frame_apply_options_def_group): New.
4650         (frame_apply_command_count): Process options with
4651         gdb::option::process_options.
4652         (frame_apply_completer): New.
4653         (frame_apply_level_completer, frame_apply_all_completer)
4654         (frame_apply_completer): New.
4655         (_initialize_stack): Update help of "frame apply", "frame apply
4656         level", "frame apply all" and "faas" to mention supported options
4657         and install command completers.
4658         * stack.h (frame_apply_all_completer): Declare.
4659         * thread.c: Include "stack.h".
4660         (tfaas_command): Add "--".
4661         (_initialize_thread): Update help "tfaas" to mention supported
4662         options and install command completer.
4663
4664 2019-06-13  Pedro Alves  <palves@redhat.com>
4665
4666         * completer.c (complete_nested_command_line): New.
4667         (gdb_completion_word_break_characters_throw): Add assertion.
4668         * completer.h (complete_nested_command_line): Declare.
4669
4670 2019-06-13  Pedro Alves  <palves@redhat.com>
4671
4672         * stack.c (parse_backtrace_qualifiers): New.
4673         (backtrace_command): Use it.
4674         (backtrace_command_completer): Complete on qualifiers.
4675
4676 2019-06-13  Pedro Alves  <palves@redhat.com>
4677
4678         * frame.c: Include "cli/cli-option.h.
4679         (user_set_backtrace_options): New.
4680         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4681         Delete.
4682         (get_prev_frame): Adjust.
4683         (boolean_option_def, uinteger_option_def)
4684         (set_backtrace_option_defs): New.
4685         (_initialize_frame): Adjust and use
4686         gdb::option::add_setshow_cmds_for_options to install "set
4687         backtrace past-main" and "set backtrace past-entry".
4688         * frame.h: Include "cli/cli-option.h".
4689         (struct frame_print_options): Forward declare.
4690         (print_frame_arguments_all, print_frame_arguments_scalars)
4691         (print_frame_arguments_none): Declare.
4692         (print_entry_values): Delete declaration.
4693         (struct frame_print_options, user_frame_print_options): New.
4694         (struct set_backtrace_options): New.
4695         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4696         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4697         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4698         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4699         (list_args_or_locals): Add frame_print_options parameter.
4700         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4701         * python/py-framefilter.c (enumerate_args): Pass down
4702         USER_FRAME_PRINT_OPTIONS.
4703         * stack.c: Include "cli/cli-option.h".
4704         (print_frame_arguments_all, print_frame_arguments_scalars)
4705         (print_frame_arguments_none): Declare.
4706         (print_raw_frame_arguments, print_entry_values): Delete.
4707         (user_frame_print_options): New.
4708         (boolean_option_def, enum_option_def, frame_print_option_defs):
4709         New.
4710         (struct backtrace_cmd_options): New.
4711         (bt_flag_option_def): New.
4712         (backtrace_command_option_defs): New.
4713         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4714         (print_frame_arg, read_frame_arg, print_frame_args)
4715         (print_frame_info, print_frame): Add frame_print_options parameter
4716         and use it.
4717         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4718         (backtrace_command_1): Add frame_print_options and
4719         backtrace_cmd_options parameters and use them.
4720         (make_backtrace_options_def_group): New.
4721         (backtrace_command): Process command options with
4722         gdb::option::process_options.
4723         (backtrace_command_completer): New.
4724         (_initialize_stack): Extend "backtrace"'s help to mention
4725         supported options.  Install completer for "backtrace".
4726         Install some settings commands with add_setshow_cmds_for_options.
4727
4728 2019-06-13  Pedro Alves  <palves@redhat.com>
4729
4730         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4731         and that "set/show print raw frame-arguments" are now deprecated.
4732
4733         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4734         command.
4735         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4736         * stack.c (_initialize_stack): Install "set/show print
4737         raw-frame-arguments", and deprecate "set/show print raw
4738         frame-arguments".
4739         * valprint.c (_initialize_valprint): Deprecate "set/show print
4740         raw".
4741
4742 2019-06-13  Pedro Alves  <palves@redhat.com>
4743
4744         * compile/compile.c (struct compile_options): New.
4745         (compile_flag_option_def, compile_command_option_defs)
4746         (make_compile_options_def_group): New.
4747         (compile_file_command): Handle options with
4748         gdb::option::process_options.
4749         (compile_file_command_completer): New function.
4750         (compile_code_command): Handle options with
4751         gdb::option::process_options.
4752         (compile_code_command_completer): New function.
4753         (_initialize_compiler): Install completers for "compile code" and
4754         "compile file".  Mention available options in "compile code" and
4755         "compile code"'s help.
4756         * completer.c (advance_to_completion_word): New, factored out from
4757         ...
4758         (advance_to_expression_complete_word_point): ... this.
4759         (advance_to_filename_complete_word_point): New.
4760         * completer.h (advance_to_filename_complete_word_point): New
4761         declaration.
4762
4763 2019-06-13  Pedro Alves  <palves@redhat.com>
4764
4765         * compile/compile.c: Include "cli/cli-option.h".
4766         (compile_print_value): Scope data pointer is now a
4767         value_print_options pointer; adjust.
4768         (compile_print_command): Process options.  Scope data pointer is
4769         now a value_print_options pointer; adjust.
4770         (_initialize_compile): Update "compile print"'s help to include
4771         supported options.  Install a completer for "compile print".
4772         * cp-valprint.c (show_vtblprint, show_objectprint)
4773         (show_static_field_print): Delete.
4774         (_initialize_cp_valprint): Don't install "set print
4775         static-members", "set print vtbl", "set print object" here.
4776         * printcmd.c: Include "cli/cli-option.h" and
4777         "common/gdb_optional.h".
4778         (print_command_parse_format): Rework to fill in a
4779         value_print_options instead of a format_data.
4780         (print_value): Change parameter type from format_data pointer to
4781         value_print_options reference.  Adjust.
4782         (print_command_1): Process options.  Adjust to pass down a
4783         value_print_options.
4784         (print_command_completer): New.
4785         (_initialize_printcmd): Install print_command_completer as
4786         handle_brkchars completer for the "print" command.  Update
4787         "print"'s help to include supported options.
4788         * valprint.c: Include "cli/cli-option.h".
4789         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4790         here from cp-valprint.c.
4791         (boolean_option_def, uinteger_option_def)
4792         (value_print_option_defs, make_value_print_options_def_group):
4793         New.  Use gdb::option::add_setshow_cmds_for_options to install
4794         "set print elements", "set print null-stop", "set print repeats",
4795         "set print pretty", "set print union", "set print array", "set
4796         print address", "set print symbol", "set print array-indexes".
4797         * valprint.h: Include <string> and "cli/cli-option.h".
4798         (make_value_print_options_def_group): Declare.
4799         (print_value): Change parameter type from format_data pointer to
4800         value_print_options reference.
4801         (print_command_completer): Declare.
4802
4803 2019-06-13  Pedro Alves  <palves@redhat.com>
4804
4805         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4806         (COMMON_SFILES): Add maint-test-settings.c.
4807         * cli/cli-decode.c (boolean_enums): New global, factored out from
4808         ...
4809         (add_setshow_boolean_cmd): ... here.
4810         * cli/cli-decode.h (boolean_enums): Declare.
4811         * cli/cli-option.c: New file.
4812         * cli/cli-option.h: New file.
4813         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4814         factored out from ...
4815         (parse_cli_boolean_value(const char *)): ... this.
4816         (is_unlimited_literal): Change parameter type to pointer to
4817         pointer.  Adjust and advance ARG pointer.
4818         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4819         (parse_cli_var_enum): New, factored out from ...
4820         (do_set_command): ... this.  Adjust.
4821         * cli/cli-setshow.h (parse_cli_boolean_value)
4822         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4823         (parse_cli_var_enum): Declare.
4824         * cli/cli-utils.c: Include "cli/cli-option.h".
4825         (get_ulongest): New.
4826         * cli/cli-utils.h (get_ulongest): Declare.
4827         (check_for_argument): New overloads.
4828         * maint-test-options.c: New file.
4829
4830 2019-06-13  Pedro Alves  <palves@redhat.com>
4831
4832         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4833         parse a range if "-" is at the end of the string.
4834
4835 2019-06-13  Pedro Alves  <palves@redhat.com>
4836
4837         * cli/cli-setshow.c (parse_auto_binary_operation)
4838         (parse_cli_boolean_value): Don't allow "o".
4839
4840 2019-06-13  Pedro Alves  <palves@redhat.com>
4841
4842         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4843         * NEWS: Mention maint test-settings KIND.
4844         * maint-test-settings.c: New file.
4845
4846 2019-06-13  Pedro Alves  <palves@redhat.com>
4847
4848         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4849         completer.
4850         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4851         "set" completers.
4852
4853 2019-06-13  Pedro Alves  <palves@redhat.com>
4854
4855         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4856         after item.
4857
4858 2019-06-13  Pedro Alves  <palves@redhat.com>
4859
4860         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4861
4862 2019-06-13  Pedro Alves <palves@redhat.com>
4863
4864         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4865         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4866         call.
4867         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4868         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4869         calls.
4870         (check_for_argument): Skip spaces after argument.
4871
4872 2019-06-13  Pedro Alves  <palves@redhat.com>
4873
4874         * thread.c (thread_apply_command): Adjust TID parsing.
4875         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4876         detected before end of string.
4877         (tid_is_in_list): Error out if LIST is invalid.
4878
4879 2019-06-13  Pedro Alves  <palves@redhat.com>
4880
4881         * completer.c (complete_line_internal_1): Rewind completion word
4882         point.
4883         (completion_tracker::advance_custom_word_point_by): Change
4884         parameter type to int.
4885         * completer.h (completion_tracker::advance_custom_word_point_by):
4886         Likewise.
4887
4888 2019-06-13  Pedro Alves  <palves@redhat.com>
4889
4890         * completer.c (advance_to_completion_word): Handle delimiters.
4891
4892 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4893
4894         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4895
4896 2019-06-11  Tom Tromey  <tom@tromey.com>
4897
4898         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4899         (xmalloc_failed): Move to alloc.c.
4900         * alloc.c: New file.
4901         * Makefile.in (COMMON_SFILES): Add alloc.c.
4902
4903 2019-06-11  Tom Tromey  <tom@tromey.com>
4904
4905         * nat/linux-waitpid.c: Don't include server.h.
4906         (linux_debug): Remove.
4907         (my_waitpid): Update.
4908
4909 2019-06-11  Tom Tromey  <tromey@adacore.com>
4910
4911         * infcall.c (_initialize_infcall): Remove trailing newline from
4912         help.
4913         * user-regs.c (_initialize_user_regs): Remove trailing newline
4914         from help.
4915         * typeprint.c (_initialize_typeprint): Remove trailing newline
4916         from help.
4917         * reverse.c (_initialize_reverse): Remove trailing newlines from
4918         help.
4919         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4920         from help.
4921         * language.c (add_set_language_command): Remove trailing newline
4922         from help.
4923         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4924         help.
4925         * disasm.c (_initialize_disasm): Remove trailing newline from
4926         help.
4927         * top.c (init_main): Remove trailing newline from help.
4928         * interps.c (_initialize_interpreter): Remove trailing newline
4929         from help.
4930         * btrace.c (_initialize_btrace): Remove trailing newlines from
4931         help.
4932         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4933         from help.
4934         * python/python.c (_initialize_python): Remove trailing newline
4935         from help.
4936         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4937         help.
4938         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4939         from help.  Reformat some text.
4940         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4941         from help.
4942         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4943         newline from help.
4944
4945 2019-06-11  Tom Tromey  <tromey@adacore.com>
4946
4947         * darwin-nat.c (darwin_decode_exception_message)
4948         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4949
4950 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4951
4952         * valops.c (value_slice): Check for not allocated or not
4953         associated values.
4954
4955 2019-06-10  Tom de Vries  <tdevries@suse.de>
4956
4957         PR gdb/24618
4958         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4959         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4960         invalid.
4961
4962 2019-06-10  Tom de Vries  <tdevries@suse.de>
4963
4964         PR gdb/24611
4965         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4966         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4967
4968 2019-06-10  Tom de Vries  <tdevries@suse.de>
4969
4970         PR symtab/24545
4971         * symtab.c (struct demangled_name_entry): Add language field.
4972         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4973         static minimal symbol".  Set and use language field.
4974
4975 2019-06-10  Tom Tromey  <tromey@adacore.com>
4976
4977         * ada-lang.c (_initialize_ada_language): Update help text.
4978
4979 2019-06-10  Tom Tromey  <tromey@adacore.com>
4980
4981         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4982         with a newline.
4983         * guile/guile.c (handle_boot_error): Don't end warning with a
4984         newline.
4985         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4986         warning with a newline.
4987         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4988         newline.
4989         (s12z_frame_cache): Likewise.
4990         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4991         a newline.
4992         * solib-svr4.c (disable_probes_interface): Don't end warning with
4993         a newline.
4994         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4995         newline.
4996         * python/python.c (do_finish_initialization): Don't end warning
4997         with a newline.
4998
4999 2019-06-10  Tom Tromey  <tom@tromey.com>
5000
5001         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5002         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5003         gdbpy_enter.
5004
5005 2019-06-10  Tom Tromey  <tromey@adacore.com>
5006
5007         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5008         data.
5009         (elf_new_init): Don't call stabsread_new_init.
5010         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5011         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5012         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5013
5014 2019-06-10  Tom de Vries  <tdevries@suse.de>
5015
5016         PR symtab/16264
5017         PR symtab/24517
5018         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5019
5020 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5021
5022         * source.c (find_and_open_source): Also rewrite relative file
5023         names.
5024
5025 2019-04-26  Amos Bird  <amosbird@gmail.com>
5026
5027         * annotate.c (annotate_thread_exited): Add "thread-exited"
5028         annotation.
5029
5030 2019-06-06  Tom Tromey  <tromey@adacore.com>
5031
5032         * maint.h (class scoped_command_stats): Use
5033         DISABLE_COPY_AND_ASSIGN.
5034         <print_time>: New method.
5035         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5036         print_time.
5037         (scoped_command_stats::print_time): New method.
5038
5039 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5040
5041         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5042         instructions of lengths 6 or 8 bytes.
5043
5044 2019-06-04  Pedro Alves  <palves@redhat.com>
5045
5046         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5047
5048         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5049         * breakpoint.c (condition_completer): Likewise.
5050         * cli/cli-dump.c (scan_expression): Likewise.
5051         * common/filestuff.c (mkdir_recursive): Likewise.
5052         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5053         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5054         (gdb_abspath): Likewise.
5055         * compile/compile-cplus-types.c
5056         (compile_cplus_instance::decl_name): Likewise.
5057         * completer.c (complete_explicit_location):
5058         (signal_completer, reg_or_group_completer_1): Likewise.
5059         * cp-support.c (cp_remove_params_if_any): Likewise.
5060         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5061         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5062         * infcmd.c (strip_bg_char): Likewise.
5063         * linespec.c (copy_token_string): Likewise.
5064         * mi/mi-main.c (output_cores): Likewise.
5065         * psymtab.c (psymtab_search_name):
5066         * symfile.c (test_set_ext_lang_command): Likewise.
5067         * target.c (target_fileio_read_stralloc): Likewise.
5068         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5069         * value.c (complete_internalvar): Likewise.
5070
5071 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5072
5073         Add objfile property to gdb.Type.
5074         * NEWS: Mention Python API addition.
5075         * python/py-type.c (typy_get_objfile): New method.
5076
5077 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5078
5079         * NEWS: Mention the new set|show style [title|highlight].
5080         Mention changes to "show style", "help" and "apropos".
5081
5082 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5083
5084         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5085         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5086         instead of print_help_for_command.
5087         (print_doc_of_command): New function.
5088         (help_list): Add 'apropos -v word' suggestion.
5089         (print_help_for_command): Style the command name using title style.
5090         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5091         (_initialize_cli_cmds): Describe -v in apropos_command help.
5092
5093 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5094
5095         * cli/cli-style.h (cli_style_option): Add name in constructor,
5096         add m_name class member, add constructor with intensity,
5097         add name class function.
5098         (cli_style_option::add_setshow_commands): Remove name argument.
5099         (highlight_style, title_style): New styles.
5100         * cli/cli-style.c (do_show): New function that shows a style
5101         characteristic styling the style name with itself.
5102         (set_style_name): New function.
5103         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5104         Update all callers according to the changes in cli/cli-style.h.
5105         * utils.h (fputs_highlighted): New function.
5106         * utils.c (fputs_highlighted): Likewise.
5107
5108 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5109
5110         * NEWS: Mention new pipe command and new convenience variables.
5111
5112 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5113
5114         * cli/cli-cmds.c (pipe_command): New function.
5115         (_initialize_cli_cmds): Call add_com for pipe_command.
5116         Define | as an alias for pipe.
5117         (exit_status_set_internal_vars): New function.
5118         (shell_escape): Call exit_status_set_internal_vars.
5119         cli/cli-decode.c (find_command_name_length): Recognize | as
5120         a single character command.
5121
5122 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5123
5124         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5125         top.c (execute_command_to_ui_file): New function, mostly a copy
5126         of execute_command_to_string.
5127         (execute_command_to_string): Implement by calling
5128         execute_command_to_ui_file.
5129
5130 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5131
5132         * top.h (saved_command_line): Remove declaration.
5133         * top.c (previous_saved_command_line, previous_repeat_arguments):
5134         New variables.
5135         (saved_command_line): Make static, define together with other
5136         'repeat variables'.
5137         (dont_repeat): Clear repeat_arguments.
5138         (repeat_previous, get_saved_command_line, save_command_line):
5139         New functions.
5140         (gdb_init): Initialize saved_command_line
5141         and previous_saved_command_line.
5142         * main.c (captured_main_1): Remove saved_command_line initialization.
5143         * event-top.c (handle_line_of_input): Update to use
5144         the new 'repeat' related functions instead of direct access to
5145         saved_command_line.
5146         * command.h (repeat_previous, get_saved_command_line,
5147         save_command_line): New declarations.
5148         (dont_repeat): Add comment.
5149
5150 2019-05-30  Tom Tromey  <tromey@adacore.com>
5151
5152         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5153         Fix comment.
5154         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5155
5156 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5157
5158         PR cli/24587
5159         * completer.c (complete): Initialize variable word.
5160
5161 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5162
5163         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5164         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5165         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5166         'body' is NULL to the outter 'if', protecting the '!is_define'
5167         situation as well.
5168
5169 2019-05-29  Tom Tromey  <tromey@adacore.com>
5170
5171         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5172         (dwarf_unknown): New function.
5173         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5174         (dwarf_type_encoding_name): Use dwarf_unknown.
5175
5176 2019-05-29  Tom Tromey  <tromey@adacore.com>
5177
5178         PR c++/20020:
5179         * cp-valprint.c (cp_print_value_fields): Call
5180         cp_print_static_field inside "try".
5181
5182 2019-05-29  Tom Tromey  <tromey@adacore.com>
5183
5184         * inflow.c (struct terminal_info): Add default operator=.
5185         * configure: Rebuild.
5186         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5187         -Wdeprecated-copy-dtor, -Wredundant-move.
5188
5189 2019-05-29  Tom Tromey  <tromey@adacore.com>
5190
5191         * NEWS: Add entry.
5192         * infcmd.c (print_return_value_1): Handle finish_print
5193         option.
5194         (show_print_finish): New function.
5195         (_initialize_infcmd): Add "set/show print finish" commands.
5196         * valprint.c (user_print_options): Initialize new member.
5197         * valprint.h (struct value_print_options) <finish_print>: New
5198         member.
5199
5200 2019-05-28  Tom Tromey  <tromey@adacore.com>
5201
5202         * ada-lang.c (ada_remove_Xbn_suffix)
5203         (find_old_style_renaming_symbol)
5204         (parse_old_style_renaming): Remove.
5205         (ada_find_renaming_symbol): Don't call
5206         find_old_style_renaming_symbol.
5207         (ada_is_renaming_symbol): Rename from
5208         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5209         bool.  Now static.
5210         (ada_read_var_value): Update and simplify.
5211         * ada-exp.y (write_var_or_type): Remove old code.
5212
5213 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5214
5215         * event-top.c: Remove include comment.
5216         * inflow.c (class scoped_ignore_sigttou): Move from here...
5217         * inflow.h (class scoped_ignore_sigttou): ...to here.
5218         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5219         * top.c:  Remove include comment.
5220
5221 2019-05-27  Tom Tromey  <tom@tromey.com>
5222
5223         * NEWS: Fix typo.
5224
5225 2019-05-22  Tom Tromey  <tromey@adacore.com>
5226
5227         * target.c (target_follow_exec): Constify parameter.
5228         * target-delegates.c: Rebuild.
5229         * remote.c (remote_target::follow_exec): Constify parameter.
5230         * infrun.c (follow_exec): Constify parameter.
5231         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5232         (target_follow_exec): Likewise.
5233
5234 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5235
5236         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5237         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5238
5239 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5240
5241         * NEWS: Add debugredirect and testsuite sections.
5242
5243 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5244
5245         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5246         target descriptions using exclusively floating point register name
5247         aliases.
5248
5249 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5250
5251         PR gdb/18644:
5252         * f-lang.c (build_fortran_types): Handle the case where
5253         gdbarch_floatformat_for_type returns a nullptr.
5254
5255 2019-05-21  Tom de Vries  <tdevries@suse.de>
5256
5257         PR cli/24587
5258         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5259
5260 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5261
5262         PR gdb/18644:
5263         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5264         16-byte floats.
5265         * i386-tdep.c (i386_floatformat_for_type): Use
5266         floatformats_ia64_quad for the 16-byte floating point component
5267         within a fortran 32-byte complex number.
5268
5269 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5270
5271         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5272         delete default constructor.
5273         (find_partial_die): Update to return const struct.
5274         (partial_die_parent_scope): Move variable declaration into scope
5275         of its use and change its type to auto.
5276         (guess_partial_die_structure_name): Likewise.
5277         (partial_die_info::fixup): Likewise.
5278
5279 2019-05-17  Tom Tromey  <tromey@adacore.com>
5280
5281         * source.c (find_and_open_source): Remove cast.
5282
5283 2019-05-17  Tom Tromey  <tromey@adacore.com>
5284
5285         * annotate.c (annotate_source): Make "filename" const.
5286         * annotate.h (annotate_source): Use const.
5287
5288 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5289
5290         * disasm.c (set_disassembler_options): Send errors to stderr.
5291
5292 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5293
5294         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5295         (cli_interp_base::set_logging): Check debug_redirect.
5296         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5297         * cli/cli-logging.c (debug_redirect): Add static variable.
5298         (pop_output_files): Add default param.
5299         (handle_redirections): Print debug setting.
5300         (show_logging_command): Likewise.
5301         (_initialize_cli_logging): Add debugredirect command.
5302         * interps.c (current_interp_set_logging): Add debug_redirect
5303         parameter.
5304         * interps.h (set_logging): Add debug_redirect parameter.
5305         (current_interp_set_logging): Likewise.
5306         * mi/mi-common.h: Likewise.
5307         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5308
5309 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5310             Tom Tromey  <tromey@adacore.com>
5311
5312         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5313         directly.
5314         * cli/cli-interp.h (make_logging_output): Remove declaration.
5315         * cli/cli-logging.c (make_logging_output): Remove function.
5316         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5317         directly.
5318         * ui-file.c (tee_file::tee_file): Remove bools.
5319         (tee_file::~tee_file): Remove deletes.
5320         * ui-file.h (tee_file): Remove bools.
5321
5322 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5323
5324         * mi/mi-cmds.h (mi_cmd_complete): New function.
5325         * mi/mi-main.c (mi_cmd_complete): Likewise.
5326         * mi/mi-cmds.c: Define new MI command -complete.
5327         * NEWS: Mention new -complete command.
5328
5329 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5330
5331         * completer.h (complete): New function.
5332         * completer.c (complete): Likewise.
5333         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5334         function defined in completer.h.
5335
5336 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5337
5338         * MAINTAINERS (Write After Approval): Add myself.
5339
5340 2019-05-17  Tom de Vries  <tdevries@suse.de>
5341
5342         PR gdb/24094
5343         * dwarf2read.c (struct cu_partial_die_info): New struct.
5344         (find_partial_die): Return cu_partial_die_info.
5345         (partial_die_parent_scope, guess_partial_die_structure_name)
5346         (partial_die_info::fixup): Handle new return type of find_partial_die.
5347
5348 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5349
5350         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5351         "std::string", simplifying the algorithm.
5352
5353 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5354
5355         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5356         (stap_static_probe_ops::get_probes): Likewise.
5357
5358 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5359
5360         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5361         '-')" and "else if".
5362         (stap_parse_single_operand): Join checks for
5363         "gdbarch_stap_parse_special_token_p" and
5364         "gdbarch_stap_parse_special_token" in the same "if" statement.
5365         Invert check when verifying for operation on register
5366         displacement.
5367
5368 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5369
5370         * stap-probe.c (stap_get_opcode): Update comment.
5371         (stap_get_expected_argument_type): Likewise.
5372         (handle_stap_probe): Likewise.
5373
5374 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5375
5376         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5377         return type to 'bool'.  Adjust comment.  Use 'bool' when
5378         appropriate.
5379         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5380         * stap-probe.c (stap_parse_argument_1): Likewise.
5381         (stap_is_operator): Likewise.
5382         (stap_is_generic_prefix): Likewise.
5383         (stap_is_register_prefix): Likewise.
5384         (stap_is_register_indirection_prefix): Likewise.
5385         (stap_is_integer_prefix): Likewise.
5386         (stap_generic_check_suffix): Likewise.
5387         (stap_check_integer_suffix): Likewise.
5388         (stap_check_register_suffix): Likewise.
5389         (stap_check_register_indirection_suffix): Likewise.
5390         (stap_parse_register_operand): Likewise.
5391         (stap_parse_single_operand): Likewise.
5392         (stap_parse_argument_1): Likewise.
5393         (stap_probe::get_argument_count): Likewise.
5394         (stap_is_operator): Likewise.
5395
5396 2019-05-16  Tom Tromey  <tromey@adacore.com>
5397
5398         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5399         keyword to foreach.
5400
5401 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5402
5403         * linux-thread-db.c (try_thread_db_load_1): Change return type
5404         to bool.
5405         (try_thread_db_load): Likewise.
5406         (try_thread_db_load_from_pdir_1): Likewise.
5407         (try_thread_db_load_from_pdir): Likewise.
5408         (try_thread_db_load_from_sdir): Likewise.
5409         (try_thread_db_load_from_dir): Likewise.
5410         (thread_db_load_search): Likewise.
5411         (has_libpthread): Likewise.
5412         (thread_db_load): Likewise.
5413
5414 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5415
5416         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5417         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5418         NULL, and complain/return if that's the case.
5419
5420 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5421
5422         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5423         (advance, posn, abstract_read_memory): New functions.
5424         [struct mem_read_abstraction]: New struct.
5425         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5426
5427 2019-05-14  Tom Tromey  <tromey@adacore.com>
5428
5429         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5430         value is not lval_memory.
5431
5432 2019-05-14  Tom Tromey  <tromey@adacore.com>
5433
5434         * solib.c (info_sharedlibrary_command): Style the file name.
5435
5436 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5437
5438         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5439         (aarch64_vnv_type): Likewise.
5440         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5441         * common/tdesc.c: Likewise.
5442         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5443         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5444         * features/aarch64-fpu.xml: Add ieee half view.
5445         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5446         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5447         * gdbtypes.h (struct builtin_type): Likewise.
5448         (struct objfile_type): Likewise.
5449
5450 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5451
5452         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5453         typo.
5454         * location.h (string_to_event_location): Likewise.
5455
5456 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5457
5458         GDB 8.3 released.
5459
5460 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5461
5462         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5463         New variable declaration.
5464         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5465         New variable.
5466         (print_one_breakpoint): Use ui_out::test_flags and new global
5467         variable to compute use_fixed_output.
5468         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5469         Remove.
5470         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5471         (mi_multi_location_breakpoint_output_fixed): Remove.
5472         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5473         new variable.
5474         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5475         fix_multi_location_breakpoint_output flag if version >= 3.
5476         * ui-out.h (enum ui_out_flag)
5477         <fix_multi_location_breakpoint_output>: New enumerator.
5478
5479 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5480
5481         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5482
5483 2019-05-10  Tom Tromey  <tromey@adacore.com>
5484
5485         * ada-lang.c (catch_ada_completer): New function.
5486         (_initialize_ada_language): Use it.
5487
5488 2019-05-10  Tom Tromey  <tromey@adacore.com>
5489
5490         * thread.c (print_thread_info): Make "requested_threads" const.
5491         * gdbthread.h (print_thread_info): Make "requested_threads"
5492         const.
5493         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5494         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5495
5496 2019-05-08  Tom Tromey  <tom@tromey.com>
5497
5498         * gdbtypes.c (objfile_type_data): Change type.
5499         (objfile_type, _initialize_gdbtypes): Update.
5500
5501 2019-05-08  Tom Tromey  <tom@tromey.com>
5502
5503         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5504         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5505         (_initialize_dwarf2_frame): Update.
5506
5507 2019-05-08  Tom Tromey  <tom@tromey.com>
5508
5509         * objc-lang.c (objc_objfile_data): Change type.
5510         (find_methods): Update.
5511         (_initialize_objc_lang): Remove.
5512
5513 2019-05-08  Tom Tromey  <tom@tromey.com>
5514
5515         * stabsread.c (rs6000_builtin_type_data): Change type.
5516         (rs6000_builtin_type, _initialize_stabsread): Update.
5517
5518 2019-05-08  Tom Tromey  <tom@tromey.com>
5519
5520         * mips-tdep.c (mips_pdr_data): Remove.
5521         (_initialize_mips_tdep): Update.
5522
5523 2019-05-08  Tom Tromey  <tom@tromey.com>
5524
5525         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5526         (hppa_init_objfile_priv_data, read_unwind_info)
5527         (find_unwind_entry, _initialize_hppa_tdep): Update.
5528
5529 2019-05-08  Tom Tromey  <tom@tromey.com>
5530
5531         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5532         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5533         on obstack.
5534         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5535
5536 2019-05-08  Tom Tromey  <tom@tromey.com>
5537
5538         * mdebugread.c (basic_type_data): Change type.
5539         (basic_type, _initialize_mdebugread): Update.
5540
5541 2019-05-08  Tom Tromey  <tom@tromey.com>
5542
5543         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5544
5545 2019-05-08  Tom Tromey  <tom@tromey.com>
5546
5547         * nto-tdep.c (nto_inferior_data_reg): Change type.
5548         (nto_inferior_data): Update.
5549         (nto_inferior_data_cleanup, nto_new_inferior_data)
5550         (_initialize_nto_tdep): Remove.
5551         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5552
5553 2019-05-08  Tom Tromey  <tom@tromey.com>
5554
5555         * ada-lang.c (struct ada_inferior_data): Add initializers.
5556         (ada_inferior_data): Change type.
5557         (ada_inferior_data_cleanup): Remove.
5558         (get_ada_inferior_data, ada_inferior_exit)
5559         (struct ada_pspace_data): Add initializers, destructor.
5560         (ada_pspace_data_handle): Change type.
5561         (get_ada_pspace_data): Update.
5562         (ada_pspace_data_cleanup): Remove.
5563
5564 2019-05-08  Tom Tromey  <tom@tromey.com>
5565
5566         * coffread.c (struct coff_symfile_info): Add initializers.
5567         (coff_objfile_data_key): Move lower.  Change type.
5568         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5569         Update.
5570         (coff_free_info): Remove.
5571
5572 2019-05-08  Tom Tromey  <tom@tromey.com>
5573
5574         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5575         (fbsd_pspace_data_handle): Move lower.  Change type.
5576         (get_fbsd_pspace_data): Update.
5577         (fbsd_pspace_data_cleanup): Remove.
5578         (_initialize_fbsd_tdep): Update.
5579
5580 2019-05-08  Tom Tromey  <tom@tromey.com>
5581
5582         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5583         (get_ada_tasks_pspace_data): Update.
5584         (ada_tasks_pspace_data_cleanup): Remove.
5585         (_initialize_tasks): Update.
5586         (ada_tasks_inferior_data_handle): Change type.
5587         (get_ada_tasks_inferior_data): Update.
5588         (ada_tasks_inferior_data_cleanup): Remove.
5589         (struct ada_tasks_pspace_data): Add initializers.
5590
5591 2019-05-08  Tom Tromey  <tom@tromey.com>
5592
5593         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5594         * symfile-debug.c (debug_sym_get_probes): Change type.
5595         * stap-probe.c (handle_stap_probe):
5596         (stap_static_probe_ops::get_probes): Change type.
5597         * probe.h (class static_probe_ops) <get_probes>: Change type.
5598         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5599         (parse_probes_in_pspace): Update.
5600         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5601         Update.
5602         (any_static_probe_ops::get_probes): Change type.
5603         * elfread.c (elfread_data): New typedef.
5604         (probe_key): Change type.
5605         (elf_get_probes): Likewise.  Update.
5606         (probe_key_free): Remove.
5607         (_initialize_elfread): Update.
5608         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5609         Change type.
5610         (dtrace_process_dof_probe, dtrace_process_dof)
5611         (dtrace_static_probe_ops::get_probe): Change type.
5612
5613 2019-05-08  Tom Tromey  <tom@tromey.com>
5614
5615         * xcoffread.c (struct xcoff_symfile_info): Rename from
5616         coff_symfile_info.  Add initializers.
5617         (xcoff_objfile_data_key): Move lower.  Change type.
5618         (XCOFF_DATA): Rewrite.
5619         (xcoff_free_info): Remove.
5620         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5621         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5622         (xcoff_initial_scan): Update.
5623
5624 2019-05-08  Tom Tromey  <tom@tromey.com>
5625
5626         * solib-svr4.c (struct svr4_info): Add initializers and
5627         destructor.
5628         <probes_table>: Now an htab_up.
5629         (solib_svr4_pspace_data): Change type.
5630         (free_probes_table): Simplify.
5631         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5632         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5633         (probes_table_remove_objfile_probes, register_solib_event_probe)
5634         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5635         (_initialize_svr4_solib): Update.
5636
5637 2019-05-08  Tom Tromey  <tom@tromey.com>
5638
5639         * remote.c (remote_pspace_data): Change type.
5640         (remote_pspace_data_cleanup): Remove.
5641         (get_remote_exec_file, set_pspace_remote_exec_file)
5642         (_initialize_remote): Update.
5643
5644 2019-05-08  Tom Tromey  <tom@tromey.com>
5645
5646         * breakpoint.c (breakpoint_objfile_key): Change type.
5647         (get_breakpoint_objfile_data): Update.
5648         (free_breakpoint_objfile_data): Remove.
5649         (_initialize_breakpoint): Update.
5650
5651 2019-05-08  Tom Tromey  <tom@tromey.com>
5652
5653         * linux-tdep.c (struct linux_info): Add initializers.
5654         (linux_inferior_data): Move.  Change type.
5655         (invalidate_linux_cache_inf): Update.
5656         (linux_inferior_data_cleanup): Remove.
5657         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5658
5659 2019-05-08  Tom Tromey  <tom@tromey.com>
5660
5661         * auxv.c (auxv_inferior_data): Move.  Change type.
5662         (auxv_inferior_data_cleanup): Remove.
5663         (invalidate_auxv_cache_inf): Rewrite.
5664         (get_auxv_inferior_data, _initialize_auxv): Update.
5665
5666 2019-05-08  Tom Tromey  <tom@tromey.com>
5667
5668         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5669         (symfile_debug_objfile_data_key): Change type.
5670         (symfile_debug_installed, debug_qf_has_symbols)
5671         (debug_qf_find_last_source_symtab)
5672         (debug_qf_forget_cached_source_info)
5673         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5674         (debug_qf_print_stats, debug_qf_dump)
5675         (debug_qf_expand_symtabs_for_function)
5676         (debug_qf_expand_all_symtabs)
5677         (debug_qf_expand_symtabs_with_fullname)
5678         (debug_qf_map_matching_symbols)
5679         (debug_qf_expand_symtabs_matching)
5680         (debug_qf_find_pc_sect_compunit_symtab)
5681         (debug_qf_map_symbol_filenames)
5682         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5683         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5684         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5685         (debug_sym_read_linetable, debug_sym_relocate): Update.
5686         (symfile_debug_free_objfile): Remove.
5687         (install_symfile_debug_logging, _initialize_symfile_debug):
5688         Update.
5689
5690 2019-05-08  Tom Tromey  <tom@tromey.com>
5691
5692         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5693         allocate_on_obstack.
5694         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5695         (get_dwarf2_per_objfile): Update.
5696         (set_dwarf2_per_objfile): Remove.
5697         (dwarf2_has_info, dwarf2_get_section_info): Update.
5698         (dwarf2_free_objfile): Remove.
5699         (_initialize_dwarf2_read): Update.
5700
5701 2019-05-08  Tom Tromey  <tom@tromey.com>
5702
5703         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5704         initializers.
5705         <unsupported_script_warning_printed,
5706         script_not_found_warning_printed>: Now bool.
5707         (auto_load_pspace_data): Change type.
5708         (~auto_load_pspace_info): Rename from
5709         auto_load_pspace_data_cleanup.
5710         (get_auto_load_pspace_data, init_loaded_scripts_info)
5711         (clear_section_scripts, maybe_print_unsupported_script_warning)
5712         (maybe_print_script_not_found_warning, _initialize_auto_load):
5713         Update.
5714
5715 2019-05-08  Tom Tromey  <tom@tromey.com>
5716
5717         * objfiles.c (objfile_pspace_info): Add destructor and
5718         initializers.
5719         (objfiles_pspace_data): Change type.
5720         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5721         (get_objfile_pspace_data): Update.
5722         (objfiles_bfd_data): Change type.
5723         (get_objfile_bfd_data): Update.
5724         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5725
5726 2019-05-08  Tom Tromey  <tom@tromey.com>
5727
5728         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5729         Change type.
5730         (get_catch_syscall_inferior_data): Update.
5731         (catch_syscall_inferior_data_cleanup): Remove.
5732         (_initialize_break_catch_syscall): Update.
5733
5734 2019-05-08  Tom Tromey  <tom@tromey.com>
5735
5736         * inflow.c (struct terminal_info): Add destructor and
5737         initializers.
5738         (inflow_inferior_data): Change type.
5739         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5740         (get_inflow_inferior_data, inflow_inferior_exit)
5741         (swap_terminal_info, _initialize_inflow): Update.
5742
5743 2019-05-08  Tom Tromey  <tom@tromey.com>
5744
5745         * target-dcache.c (target_dcache_cleanup): Remove.
5746         (target_dcache_aspace_key): Change type.
5747         (target_dcache_init_p, target_dcache_invalidate)
5748         (target_dcache_get, target_dcache_get_or_init)
5749         (_initialize_target_dcache): Update.
5750         * dcache.h (struct dcache_deleter): New.
5751
5752 2019-05-08  Tom Tromey  <tom@tromey.com>
5753
5754         * symtab.c (struct symbol_cache): Add destructor and
5755         initializers.
5756         (symbol_cache_key): Move.  Change type.
5757         (make_symbol_cache, free_symbol_cache): Remove.
5758         (get_symbol_cache): Update.
5759         (symbol_cache_cleanup): Remove.
5760         (ALL_PSPACES, symbol_cache_flush)
5761         (maintenance_print_symbol_cache)
5762         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5763         Update.
5764
5765 2019-05-08  Tom Tromey  <tom@tromey.com>
5766
5767         * symtab.c (struct main_info): Add destructor and initializers.
5768         (main_progspace_key): Move.  Change type.
5769         (get_main_info): Update.
5770         (main_info_cleanup): Remove.
5771         (_initialize_symtab): Update.
5772
5773 2019-05-08  Tom Tromey  <tom@tromey.com>
5774
5775         * registry.h (DECLARE_REGISTRY): Define the _key class.
5776
5777 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5778
5779         * NEWS: Merge two 'New commands' sections.
5780
5781 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5782
5783         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5784         parameter and use Ada language definition instead.
5785         (ada_val_print_ptr): Remove unused language parameter.
5786         (ada_val_print_num): Remove language parameter and use Ada language
5787         definition instead.
5788         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5789         parameter.
5790         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5791         parameter and use Ada language definition instead.
5792         (ada_val_print_1): Update all ada_val_print_xxx calls.
5793         Remove language parameter.
5794         (ada_val_print): Update ada_val_print_1 call.
5795
5796 2019-05-08  Tom Tromey  <tromey@adacore.com>
5797
5798         * remote.c (remote_hw_watchpoint_limit)
5799         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5800         Now static.
5801
5802 2019-05-08  Tom Tromey  <tromey@adacore.com>
5803
5804         * maint.c (_initialize_maint_cmds): Move initialization code to
5805         remote.c.
5806         (watchdog, show_watchdog): Move to remote.c.
5807         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5808         "watchdog" static.
5809         (_initialize_remote): Move initialization code from maint.c.
5810         * defs.h (watchdog): Don't declare.
5811
5812 2019-05-08  Tom Tromey  <tromey@adacore.com>
5813
5814         * tui/tui-interp.c: Include main.h.
5815         * interps.c: Include main.h.
5816         * main.h (interpreter_p): Declare.
5817         * defs.h (interpreter_p): Don't declare.
5818
5819 2019-05-08  Tom Tromey  <tromey@adacore.com>
5820
5821         * dwarf2loc.c: Include dwarf2read.h.
5822         * defs.h (read_unsigned_leb128): Don't declare.
5823         * dwarf2read.h (read_unsigned_leb128): Declare.
5824
5825 2019-05-08  Tom Tromey  <tromey@adacore.com>
5826
5827         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5828         method.
5829
5830 2019-05-08  Tom Tromey  <tromey@adacore.com>
5831
5832         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5833         when no wrap column is set.
5834
5835 2019-05-08  Tom Tromey  <tromey@adacore.com>
5836
5837         * c-lang.c (c_get_string): Handle non-C-style arrays.
5838
5839 2019-05-08  Tom Tromey  <tromey@adacore.com>
5840
5841         * typeprint.c (print_offset_data::update): Print the bit offset,
5842         not the number of bits remaining.
5843
5844 2019-05-08  Tom Tromey  <tromey@adacore.com>
5845
5846         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5847         padding at end of comment.
5848
5849 2019-05-08  Tom Tromey  <tromey@adacore.com>
5850
5851         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5852         Compare main types.
5853
5854 2019-05-06  Tom Tromey  <tom@tromey.com>
5855
5856         * common/scoped_mmap.c: Include common-defs.h.
5857         * common/scoped_mmap.h: Don't include config.h.
5858
5859 2019-05-04  Tom Tromey  <tom@tromey.com>
5860
5861         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5862         (struct aarch64_call_info): Add initializers.
5863         <si>: Now a std::vector.
5864         (pass_on_stack, aarch64_push_dummy_call): Update.
5865
5866 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5867             Tom Tromey  <tom@tromey.com>
5868
5869         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5870         (ppc_threads): Now a std::vector.  Now static.
5871         (hwdebug_find_thread_points_by_tid)
5872         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5873         Update.
5874
5875 2019-05-04  Tom Tromey  <tom@tromey.com>
5876
5877         * arc-tdep.c (arc_tdesc_init): Return bool.
5878
5879 2019-05-04  Tom Tromey  <tom@tromey.com>
5880
5881         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5882         Use gdb_assert_not_reached.
5883
5884 2019-05-04  Tom Tromey  <tom@tromey.com>
5885
5886         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5887         "false".
5888
5889 2019-05-04  Tom Tromey  <tom@tromey.com>
5890
5891         * arc-tdep.c (arc_tdesc_init): Use bool.
5892
5893 2019-05-04  Tom Tromey  <tom@tromey.com>
5894
5895         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5896
5897 2019-05-04  Tom Tromey  <tom@tromey.com>
5898
5899         * cli/cli-cmds.c (valid_command_p): Return bool.
5900
5901 2019-05-04  Tom Tromey  <tom@tromey.com>
5902
5903         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5904         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5905
5906 2019-05-04  Raul Tambre  <raul@tambre.ee>
5907
5908         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5909         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5910         operator for comparison.
5911
5912 2019-05-04  Tom Tromey  <tom@tromey.com>
5913
5914         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5915         (lookup_partial_symbol, print_partial_symbols)
5916         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5917         (psymbol_compare): Update.
5918         (add_psymbol_to_bcache): Clear the entire psymbol.
5919         (maintenance_check_psymtabs): Update.
5920         * psympriv.h (struct partial_symbol): Don't derive from
5921         general_symbol_info.
5922         <obj_section, unrelocated_address, address,
5923         set_unrelocated_address>: Update.
5924         <ginfo>: New member.
5925         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5926         (debug_names::write_psymbols): Update.
5927
5928 2019-05-04  Tom de Vries  <tdevries@suse.de>
5929
5930         * contrib/cc-with-tweaks.sh: Support -n arg.
5931
5932 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5933
5934         * corelow.c (core_target::detach): Ensure frame cache and
5935         register caches are cleared.
5936         inferior.c (exit_inferior_1): Likewise.
5937
5938 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5939             Tom Tromey  <tom@tromey.com>
5940
5941         * dictionary.c (collate_pending_symbols_by_language): Remove
5942         "struct" from foreach.
5943         * symtab.c (lookup_global_symbol_from_objfile)
5944         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5945         foreach.
5946         * ser-tcp.c (net_open): Remove "struct" from foreach.
5947         * objfiles.c (objfile_relocate, objfile_rebase)
5948         (objfile_has_symbols): Remove "struct" from foreach.
5949         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5950         from foreach.
5951         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5952         foreach.
5953         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5954         "struct" from foreach.
5955         * ada-lang.c (create_excep_cond_exprs)
5956         (ada_exception_catchpoint_cond_string): Remove "struct" from
5957         foreach.
5958
5959 2019-05-03  Tom Tromey  <tromey@adacore.com>
5960
5961         * ada-exp.y (convert_char_literal): Check suffix of each
5962         enumerator.
5963
5964 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5965
5966         PR ada/21406:
5967         * ada-exp.y (yywrap): Don't define.
5968         * ada-lex.l (%option): Add noyywrap
5969         (yywrap): Remove.
5970
5971 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5972
5973         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5974         _WIN32_WINNT to the XP level, unless already defined to a higher
5975         level.
5976
5977         * unittests/parse-connection-spec-selftests.c:
5978         * ser-tcp.c:
5979         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5980         override.
5981
5982         * symfile.c (find_separate_debug_file): Remove colon from the
5983         drive spec of DOS/Windows file names of the target, so that the
5984         file name produced from DEBUGDIR and the target's directory will
5985         be valid on DOS/Windows systems.
5986
5987 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5988
5989         * rust-lang.c (val_print_struct): Handle printing structures
5990         containing strings.
5991
5992 2019-05-02  Tom Tromey  <tromey@adacore.com>
5993
5994         * valarith.c (_initialize_valarith): Remove.
5995
5996 2019-05-01  Tom Tromey  <tromey@adacore.com>
5997
5998         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5999         bitfields.
6000
6001 2019-05-01  Tom Tromey  <tromey@adacore.com>
6002
6003         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6004         for big-endian copies.
6005
6006 2019-04-30  Ali Tamur  <tamur@google.com>
6007         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6008         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6009         (read_3_bytes): New function.
6010
6011 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6012
6013         * windows-nat.c (main_thread_id): Delete.
6014         (handle_output_debug_string): Replace main_thread_id by
6015         current_event.dwThreadId.
6016         (fake_create_process): Likewise.
6017         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6018         Do not set main_thread_id.
6019         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6020         current_event.dwThreadId.
6021         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6022
6023 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6024
6025         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6026         Use current_event.dwThreadId instead of main_thread_id.
6027
6028 2019-04-30  Tom Tromey  <tromey@adacore.com>
6029
6030         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6031         (create_excep_cond_exprs): Iterate over program spaces.
6032         (ada_exception_catchpoint_cond_string): Examine all minimal
6033         symbols for exception types.
6034
6035 2019-04-30  Tom Tromey  <tromey@adacore.com>
6036
6037         PR c++/24470:
6038         * dwarf2read.c (process_structure_scope): Handle case where type
6039         has template parameters but no symbol was created.
6040
6041 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6042             Chris January  <chris.january@arm.com>
6043
6044         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6045         qualifier.
6046         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6047
6048 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6049
6050         * f-typeprint.c (f_print_type): Update rules for printing
6051         whitespace.
6052         (f_type_print_varspec_suffix): Likewise.
6053
6054 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6055             Chris January  <chris.january@arm.com>
6056
6057         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6058         function arguments.
6059
6060 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6061
6062         * f-lang.c (build_fortran_types): Change name of void type to
6063         lower case.
6064         * f-typeprint.c (f_type_print_base): Print the name of the void
6065         type, rather than a fixed string.
6066         * f-valprint.c (f_decorations): Use lower case void string.
6067
6068 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6069             Chris January  <chris.january@arm.com>
6070
6071         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6072         types for Fortran.
6073
6074 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6075             Chris January  <chris.january@arm.com>
6076             David Lecomber  <david.lecomber@arm.com>
6077
6078         * f-exp.y (BINOP_INTRINSIC): New token.
6079         (exp): New parser rule handling BINOP_INTRINSIC.
6080         (f77_keywords): Add new builtin procedures.
6081         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6082         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6083         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6084         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6085         (print_unop_subexp_f): New function.
6086         (print_binop_subexp_f): New function.
6087         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6088         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6089         (dump_subexp_body_f): Likewise.
6090         (operator_check_f): Likewise.
6091         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6092         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6093
6094 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6095
6096         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6097         UNOP_KIND.
6098         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6099         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6100         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6101         (operator_length_f): New fuction.
6102         (print_subexp_f): New function.
6103         (op_name_f): New function.
6104         (dump_subexp_body_f): New function.
6105         (operator_check_f): New function.
6106         (exp_descriptor_f): Replace standard expression handling functions
6107         with new functions.
6108         * gdb/fortran-operator.def: New file.
6109         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6110         * gdb/std-operator.def: Remove UNOP_KIND.
6111
6112 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6113
6114         * std-operator.def: Remove unbalanced, stray double quote
6115         character.
6116
6117 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6118             Chris January  <chris.january@arm.com>
6119             Daniel Everett  <daniel.everett@arm.com>
6120             Nick Forrington  <nick.forrington@arm.com>
6121             Richard Bunt  <richard.bunt@arm.com>
6122
6123         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6124         of depth when printing anonymous structs or unions.
6125         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6126         Don't print either the top-level value, or the children if the
6127         max-depth is exceeded.
6128         (ppscm_print_children): When printing the key of a map, allow one
6129         extra level of depth.
6130         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6131         print either the top-level value, or the children if the max-depth
6132         is exceeded.
6133         (print_children): When printing the key of a map, allow one extra
6134         level of depth.
6135         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6136         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6137         (user_print_options): Initialise max_depth field.
6138         (val_print_scalar_or_string_type_p): New function.
6139         (val_print): Check to see if the max depth has been reached.
6140         (val_print_check_max_depth): Define new function.
6141         (show_print_max_depth): New function.
6142         (_initialize_valprint): Add 'print max-depth' option.
6143         * valprint.h (struct value_print_options) <max_depth>: New field.
6144         (val_print_check_max_depth): Declare new function.
6145         * NEWS: Document new feature.
6146
6147 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6148
6149         * ada-lang.c (ada_language_defn): Initialise new field.
6150         * c-lang.c (c_is_string_type_p): New function.
6151         (c_language_defn): Initialise new field.
6152         (cplus_language_defn): Initialise new field.
6153         (asm_language_defn): Initialise new field.
6154         (minimal_language_defn): Initialise new field.
6155         * c-lang.h (c_is_string_type_p): Declare new function.
6156         * d-lang.c (d_language_defn): Initialise new field.
6157         * f-lang.c (f_is_string_type_p): New function.
6158         (f_language_defn): Initialise new field.
6159         * go-lang.c (go_is_string_type_p): New function.
6160         (go_language_defn): Initialise new field.
6161         * language.c (default_is_string_type_p): New function.
6162         (unknown_language_defn): Initialise new field.
6163         (auto_language_defn): Initialise new field.
6164         * language.h (struct language_defn) <la_is_string_type_p>: New
6165         member variable.
6166         (default_is_string_type_p): Declare new function.
6167         * m2-lang.c (m2_language_defn): Initialise new field.
6168         * objc-lang.c (objc_language_defn): Initialise new field.
6169         * opencl-lang.c (opencl_language_defn): Initialise new field.
6170         * p-lang.c (pascal_is_string_type_p): New function.
6171         (pascal_language_defn): Initialise new field.
6172         * rust-lang.c (rust_is_string_type_p): New function.
6173         (rust_language_defn): Initialise new field.
6174
6175 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6176
6177         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6178         New field.
6179         * ada-lang.c (ada_language_defn): Initialise new field.
6180         * c-lang.c (c_language_defn): Likewise.
6181         (cplus_language_defn): Likewise.
6182         (asm_language_defn): Likewise.
6183         (minimal_language_defn): Likewise.
6184         * d-lang.c (d_language_defn): Likewise.
6185         * f-lang.c (f_language_defn): Likewise.
6186         * go-lang.c (go_language_defn): Likewise.
6187         * language.c (unknown_language_defn): Likewise.
6188         (auto_language_defn): Likewise.
6189         * m2-lang.c (m2_language_defn): Likewise.
6190         * objc-lang.c (objc_language_defn): Likewise.
6191         * opencl-lang.c (opencl_language_defn): Likewise.
6192         * p-lang.c (pascal_language_defn): Likewise.
6193         * rust-lang.c (rust_language_defn): Likewise.
6194
6195 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6196
6197         * ada-lang.c (ada_is_character_type): Change return type to bool.
6198         (ada_is_string_type): Likewise.
6199         * ada-lang.h (ada_is_character_type): Update declaration
6200         (ada_is_string_type): Likewise.
6201
6202 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6203
6204         Support style in 'frame|thread apply'
6205
6206         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6207         * record.c (record_start, record_stop): Update callers of
6208         execute_command_to_string with false.
6209         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6210         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6211         methods.
6212         (class string_file): New constructor with term_out parameter.
6213         Override methods term_out and can_emit_style_escape.  New member
6214         term_out.
6215         (class stdio_file): Override can_emit_style_escape.
6216         (class tee_file): Override term_out and can_emit_style_escape.
6217         * utils.h (can_emit_style_escape): Remove.
6218         * utils.c (can_emit_style_escape): Likewise.
6219         Update all callers of can_emit_style_escape (SOMESTREAM) to
6220         SOMESTREAM->can_emit_style_escape.
6221         * source-cache.c (source_cache::get_source_lines): Likewise.
6222         * stack.c (frame_apply_command_count): Call execute_command_to_string
6223         passing the term_out characteristic of the current gdb_stdout.
6224         * thread.c (thr_try_catch_cmd): Likewise.
6225         * top.c (execute_command_to_string): pass term_out parameter
6226         to construct the string_file for the command output.
6227         * ui-file.c (term_cli_styling): New function (most code moved
6228         from utils.c can_emit_style_escape).
6229         (string_file::string_file, string_file::can_emit_style_escape,
6230         stdio_file::can_emit_style_escape, tee_file::term_out,
6231         tee_file::can_emit_style_escape): New functions.
6232
6233 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6234
6235         * NEWS: Mention the new set|show may-call-functions.
6236         * infcall.c (may_call_functions_p): New variable.
6237         (show_may_call_functions_p): New function.
6238         (call_function_by_hand_dummy): Throws an error if not
6239         may-call-functions.
6240         (_initialize_infcall): Call add_setshow_boolean_cmd for
6241         may-call-functions.
6242
6243 2019-04-25  Keith Seitz  <keiths@redhat.com>
6244
6245         PR c++/24367
6246         * cp-support.c (inspect_type): Don't attempt substitutions
6247         of symbol with the same name.
6248
6249 2019-04-25  Tom Tromey  <tromey@adacore.com>
6250
6251         PR gdb/24475:
6252         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6253         static.
6254
6255 2019-04-25  Tom Tromey  <tromey@adacore.com>
6256
6257         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6258         rvalue reference.
6259         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6260         (gdb_xml_parser::parse): Use std::move.
6261         * python/python-internal.h (gdbpy_convert_exception): Take a const
6262         reference.
6263         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6264         std::move.
6265         * python/py-utils.c (gdbpy_convert_exception): Take a const
6266         reference.
6267         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6268         Use std::move.
6269         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6270         Use std::move.
6271         * mi/mi-main.c (mi_print_exception): Take a const reference.
6272         * main.c (handle_command_errors): Take a const reference.
6273         * linespec.c (parse_linespec): Use std::move.
6274         * infcall.c (run_inferior_call): Use std::move.
6275         (call_function_by_hand_dummy): Use std::move.
6276         * exec.c (try_open_exec_file): Use std::move.
6277         * exceptions.h (exception_print, exception_fprintf)
6278         (exception_print_same): Update.
6279         * exceptions.c (print_exception, exception_print)
6280         (exception_fprintf, exception_print_same): Change parameters to
6281         const reference.
6282         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6283         * common/new-op.c: Use std::move.
6284         * common/common-exceptions.h (struct gdb_exception): Add move
6285         constructor.
6286         (struct gdb_exception_error, struct gdb_exception_quit, struct
6287         gdb_quit_bad_alloc): Change constructor to move constructor.
6288         (throw_exception): Change parameter to rvalue reference.
6289         * common/common-exceptions.c (throw_exception): Take rvalue
6290         reference.
6291         * cli/cli-interp.c (safe_execute_command): Use std::move.
6292         * breakpoint.c (insert_bp_location, location_to_sals): Use
6293         std::move.
6294
6295 2019-04-25  Tom Tromey  <tromey@adacore.com>
6296
6297         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6298         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6299         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6300         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6301         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6302         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6303         guile/scm-value.c: Use unpack.
6304         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6305         gdbscm_gdb_exception.
6306         (gdbscm_throw_gdb_exception): Likewise.
6307         (struct gdbscm_gdb_exception): New.
6308         (unpack): New function.
6309         (gdbscm_wrap): Use unpack.
6310
6311 2019-04-25  Tom Tromey  <tromey@adacore.com>
6312
6313         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6314         (gdb_rl_callback_handler): Use std::move.
6315         * common/common-exceptions.h (struct gdb_exception): Add move
6316         assignment operator.
6317         (throw_exception_sjlj): Change "exception" to const reference.
6318         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6319         (throw_exception_sjlj): Change "exception" to const reference.
6320
6321 2019-04-25  Tom Tromey  <tromey@adacore.com>
6322
6323         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6324         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6325         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6326         Update.
6327         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6328         Update.
6329         * mi/mi-interp.c (mi_interp::exec): Update.
6330         * linespec.c (parse_linespec): Update.
6331         * infcall.c (run_inferior_call): Update.
6332         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6333         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6334         (gdbscm_lookup_global_symbol): Update.
6335         * guile/scm-param.c (gdbscm_parameter_value): Update.
6336         * guile/scm-frame.c (gdbscm_frame_read_register)
6337         (gdbscm_frame_read_var): Update.
6338         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6339         * exec.c (try_open_exec_file): Update.
6340         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6341         (gdb_rl_callback_handler): Update.
6342         * common/common-exceptions.h (exception_none): Don't declare.
6343         * common/common-exceptions.c (exception_none): Don't define.
6344         (struct catcher) <exception>: Update.
6345         * cli/cli-interp.c (safe_execute_command): Update.
6346         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6347
6348 2019-04-25  Ali Tamur  <tamur@google.com>
6349
6350         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6351         (read_attribute_value): Likewise.
6352         (dwarf2_read_addr_index): Update comment.
6353         (read_str_index): Add DW_FORM_strx.
6354         (dwarf2_string_attr): Likewise.
6355         (dwarf2_const_value_attr): Likewise.
6356         (dump_die_shallow): Likewise.
6357         (dwarf2_fetch_constant_bytes): Likewise.
6358         (skip_form_bytes): Likewise.
6359         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6360
6361 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6362
6363         PR corefiles/11608
6364         PR corefiles/18187
6365         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6366         OFFSET.  Verify if current mapping contains an ELF header.
6367         (linux_find_memory_regions_full): Adjust call to
6368         dump_mapping_p.
6369
6370 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6371             Kang Li <kanglictf@gmail.com>
6372
6373         PR gdb/21600
6374
6375         * dwarf2-frame.c (read_initial_length): Be consistent about using
6376         unsigned representation of length.
6377         (decode_frame_entry_1): Likewise.  Check for wraparound of
6378         end pointer as well as buffer overflow.
6379
6380 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6381
6382         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6383         "vq".
6384
6385 2019-04-24  Tom Tromey  <tromey@adacore.com>
6386
6387         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6388
6389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6390
6391         * s12z-tdep.c (s12z_unwind_pc): Delete.
6392         (s12z_unwind_sp): Delete.
6393         (s12z_gdbarch_init): Don't register deleted functions with
6394         gdbarch.
6395
6396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6397
6398         * rl78-tdep.c (rl78_unwind_sp): Delete.
6399         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6400
6401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6402
6403         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6404         (xstormy16_unwind_pc): Delete.
6405         (xstormy16_dummy_id): Delete.
6406         (xstormy16_gdbarch_init): Don't register deleted functions with
6407         gdbarch.
6408
6409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6410
6411         * vax-tdep.c (vax_unwind_pc): Delete.
6412         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6413
6414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6415
6416         * v850-tdep.c (v850_unwind_sp): Delete.
6417         (v850_unwind_pc): Delete.
6418         (v850_dummy_id): Delete.
6419         (v850_gdbarch_init): Don't register deleted functions with
6420         gdbarch.
6421
6422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6423
6424         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6425         (tilegx_unwind_pc): Delete.
6426         (tilegx_unwind_dummy_id): Delete.
6427         (tilegx_gdbarch_init): Don't register deleted functions with
6428         gdbarch.
6429
6430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6431
6432         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6433         (tic6x_dummy_id): Delete.
6434         (tic6x_gdbarch_init): Don't register deleted functions with
6435         gdbarch.
6436
6437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6438
6439         * sparc-tdep.c (sparc_unwind_pc): Delete.
6440         (sparc32_gdbarch_init): Don't register deleted function with
6441         gdbarch.
6442
6443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6444
6445         * sh-tdep.c (sh_unwind_sp): Delete.
6446         (sh_unwind_pc): Delete.
6447         (sh_dummy_id): Delete.
6448         (sh_gdbarch_init): Don't register deleted functions with
6449         gdbarch.
6450
6451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6452
6453         * score-tdep.c (score_unwind_sp): Delete.
6454         (score_unwind_pc): Delete.
6455         (score_dummy_id): Delete.
6456         (score_gdbarch_init): Don't register deleted functions with
6457         gdbarch.
6458
6459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6460
6461         * rx-tdep.c (rx_unwind_pc): Delete.
6462         (rx_unwind_sp): Delete.
6463         (rx_dummy_id): Delete.
6464         (rx_gdbarch_init): Don't register deleted functions with
6465         gdbarch.  Update comment.
6466
6467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6468
6469         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6470         (rs6000_dummy_id): Delete.
6471         (rs6000_gdbarch_init): Don't register deleted functions with
6472         gdbarch.
6473
6474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6475
6476         * or1k-tdep.c (or1k_dummy_id): Delete.
6477         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6478
6479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6480
6481         * nios2-tdep.c (nios2_dummy_id): Delete.
6482         (nios2_unwind_sp): Delete.
6483         (nios2_gdbarch_init): Don't register deleted functions with
6484         gdbarch.
6485
6486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6487
6488         * nds32-tdep.c (nds32_dummy_id): Delete.
6489         (nds32_unwind_pc): Delete.
6490         (nds32_unwind_sp): Delete.
6491         (nds32_gdbarch_init): Don't register deleted functions with
6492         gdbarch.
6493
6494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6495
6496         * msp430-tdep.c (msp430_unwind_pc): Delete.
6497         (msp430_unwind_sp): Delete.
6498         (msp430_dummy_id): Delete.
6499         (msp430_gdbarch_init): Don't register deleted functions with
6500         gdbarch.
6501
6502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6503
6504         * moxie-tdep.c (moxie_unwind_sp): Delete.
6505         (moxie_unwind_pc): Delete.
6506         (moxie_dummy_id): Delete.
6507         (moxie_gdbarch_init): Don't register deleted functions with
6508         gdbarch.
6509
6510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6511
6512         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6513         (mn10300_unwind_pc): Delete.
6514         (mn10300_unwind_sp): Delete.
6515         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6516         mn10300_unwind_sp.
6517         (mn10300_frame_unwind_init): Don't register deleted functions with
6518         gdbarch.
6519
6520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6521
6522         * mep-tdep.c (mep_unwind_pc): Delete.
6523         (mep_unwind_sp): Delete.
6524         (mep_dummy_id): Delete.
6525         (mep_gdbarch_init): Don't register deleted functions with
6526         gdbarch.
6527
6528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6529
6530         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6531         (m68hc11_unwind_sp): Delete.
6532         (m68hc11_gdbarch_init): Don't register deleted functions with
6533         gdbarch.
6534
6535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6536
6537         * m32r-tdep.c (m32r_unwind_sp): Delete.
6538         (m32r_unwind_pc): Delete.
6539         (m32r_dummy_id): Delete.
6540         (m32r_gdbarch_init): Don't register deleted functions with
6541         gdbarch.
6542
6543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6544
6545         * m32c-tdep.c (m32c_unwind_pc): Delete.
6546         (m32c_unwind_sp): Delete.
6547         (m32c_dummy_id): Delete.
6548         (m32c_gdbarch_init): Don't register deleted functions with
6549         gdbarch.
6550
6551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6552
6553         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6554         (lm32_unwind_pc): Delete.
6555         (lm32_dummy_id): Delete.
6556         (lm32_gdbarch_init): Don't register deleted functions with
6557         gdbarch.
6558
6559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6560
6561         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6562         (iq2000_unwind_pc): Delete.
6563         (iq2000_dummy_id): Delete.
6564         (iq2000_gdbarch_init): Don't register deleted functions with
6565         gdbarch.
6566
6567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6568
6569         * nds32-tdep.c (nds32_type_align): Delete.
6570         (nds32_push_dummy_call): Use type_align instead.
6571
6572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6573
6574         * arm-tdep.c (arm_type_align): Only handle vector override case.
6575         (arm_push_dummy_call): Use type_align.
6576         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6577
6578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6579
6580         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6581         case.
6582         (pass_on_stack): Use type_align.
6583         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6584         function.
6585
6586 2019-04-23  Tom Tromey  <tromey@adacore.com>
6587
6588         * dwarf2read.c (line_header::file_name_at): Remove unused
6589         overload.
6590
6591 2019-04-23  Tom de Vries  <tdevries@suse.de>
6592
6593         PR gdb/24438
6594         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6595         invocation.
6596
6597
6598 2019-03-27  Ali Tamur  <tamur@google.com>
6599
6600         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6601         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6602         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6603         (dwarf_expr_context::get_addr_index): Likewise
6604         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6605         (symbol_needs_eval_context::get_addr_index): Likewise
6606         (disassemble_dwarf_expression): Add DW_OP_addrx
6607         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6608         (read_cutu_die_from_dwo): Update comment
6609         (skip_one_die): Add DW_FORM_addrx
6610         (read_attribute_value): Likewise
6611         (var_decode_location): Add DW_OP_addrx
6612         (dwarf2_const_value_attr): Add DW_FORM_addrx
6613         (dump_die_shallow): Likewise
6614         (dwarf2_fetch_constant_bytes): Likewise
6615         (decode_locdesc): Add DW_OP_addrx
6616         (skip_form_bytes): Add DW_FORM_addrx
6617
6618 2019-04-22  Ali Tamur  <tamur@google.com>
6619
6620         * MAINTAINERS (Write After Approval): Add self.
6621
6622 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6623
6624         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6625         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6626         (open_symbol_file_object): Likewise.
6627         (svr4_default_sos): Add info parameter.
6628         (svr4_read_so_list): Likewise.
6629         (svr4_current_sos_direct): Adjust functions calls to pass down
6630         info.
6631         (svr4_current_sos_1): Add info parameter.
6632         (svr4_current_sos): Call get_svr4_info, pass info down to
6633         svr4_current_sos_1.
6634         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6635         get_svr4_info.
6636         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6637         get_svr4_info.
6638         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6639         to get_svr4_info.
6640         (probes_table_remove_objfile_probes): Likewise.
6641         (register_solib_event_probe): Add info parameter.
6642         (solist_update_incremental): Pass info parameter down to
6643         svr4_read_so_list.
6644         (disable_probes_interface): Add info parameter.
6645         (svr4_handle_solib_event): Pass current_program_space to
6646         get_svr4_info.  Adjust disable_probes_interface cleanup.
6647         (svr4_create_probe_breakpoints): Add info parameter, pass it
6648         down to register_solib_event_probe.
6649         (svr4_create_solib_event_breakpoints): Add info parameter,
6650         pass it down to svr4_create_probe_breakpoints.
6651         (enable_break): Pass info down to
6652         svr4_create_solib_event_breakpoints.
6653         (svr4_solib_create_inferior_hook): Pass current_program_space to
6654         get_svr4_info.
6655         (svr4_clear_solib): Likewise.
6656
6657 2019-04-22  Pedro Alves  <palves@redhat.com>
6658
6659         * solib-svr4.c (svr4_free_objfile_observer): New.
6660         (probe_and_action::objfile): New field.
6661         (probes_table_htab_remove_objfile_probes)
6662         (probes_table_remove_objfile_probes): New functions.
6663         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6664         in the new probe_and_action.  Don't store the probe in 'lookup'.
6665         (svr4_create_probe_breakpoints): Pass objfile to
6666         register_solib_event_probe.
6667         (_initialize_svr4_solib): Register a free_objfile observer.
6668
6669 2019-04-19  Tom Tromey  <tom@tromey.com>
6670
6671         * common/queue.h: Remove.
6672
6673 2019-04-19  Tom Tromey  <tom@tromey.com>
6674
6675         * event-loop.c: Don't include "common/queue.h".
6676
6677 2019-04-19  Tom Tromey  <tom@tromey.com>
6678
6679         * remote.c (remote_target): Use delete.
6680         * remote-notif.h: Include <list>, not "common/queue.h".
6681         (notif_client_p): Remove typedef.
6682         (remote_notif_state): Add constructor, destructor, initializer.
6683         <notif_queue>: Now a std::list.
6684         (remote_notif_state_xfree): Don't declare.
6685         * remote-notif.c (remote_notif_process, handle_notification)
6686         (remote_notif_state_allocate): Update.
6687         (~remote_notif_state): Rename from remote_notif_state_xfree.
6688
6689 2019-04-19  Tom Tromey  <tom@tromey.com>
6690
6691         * symfile.c (reread_symbols): Update.
6692         * objfiles.c (objfile_register_static_link)
6693         (objfile_lookup_static_link): Update
6694         (~objfile) Don't delete static_links.
6695         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6696
6697 2019-04-19  Tom Tromey  <tom@tromey.com>
6698
6699         * type-stack.h (struct type_stack) <insert>: Constify string.
6700         * type-stack.c (type_stack::insert): Constify string.
6701         * gdbtypes.h (lookup_template_type): Update.
6702         (address_space_name_to_int): Update.
6703         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6704         const.
6705         (lookup_template_type): Make name const.
6706         * c-exp.y: Update rules.
6707         (lex_one_token, classify_name, classify_inner_name)
6708         (c_print_token): Update.
6709         * p-exp.y: Update rules.
6710         (yylex): Update.
6711         * f-exp.y: Update rules.
6712         (yylex): Update.
6713         * d-exp.y: Update rules.
6714         (lex_one_token, classify_name, classify_inner_name): Update.
6715         * parse.c (write_dollar_variable, copy_name): Return std::string.
6716         * parser-defs.h (copy_name): Change return type.
6717         * m2-exp.y: Update rules.
6718         (yylex): Update.
6719         * go-exp.y (lex_one_token): Update.
6720         Update rules.
6721         (classify_unsafe_function, classify_packaged_name)
6722         (classify_name, yylex): Update.
6723
6724 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6725
6726         * configure.ac: add --enable-source-highlight switch.
6727         * configure: Regenerate.
6728         * top.c (print_gdb_version): plumb --enable-source-highlight
6729         status to "show configuration".
6730
6731 2019-04-19  Tom Tromey  <tromey@adacore.com>
6732
6733         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6734         Check ADA_TYPE_P.
6735         (empty_record, ada_template_to_fixed_record_type_1)
6736         (template_to_static_fixed_type)
6737         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6738         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6739         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6740         macros.
6741
6742 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6743
6744         PR symtab/24423:
6745         * source.c (print_source_lines_base): Advance "iter" when a
6746         control character is seen.
6747
6748 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6749
6750         * inferior.h (struct infcall_suspend_state_deleter):
6751         Catch exception in destructor to avoid crash.
6752
6753 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6754
6755         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6756         close to the add_com "shell".
6757
6758 2019-04-18  Tom Tromey  <tromey@adacore.com>
6759
6760         * process-stratum-target.h (class process_stratum_target)
6761         <stratum>: Add "final".
6762
6763 2019-04-17  Tom Tromey  <tromey@adacore.com>
6764
6765         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6766         against nullptr before use.
6767
6768 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6769
6770         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6771
6772 2019-04-17  Jim Wilson  <jimw@sifive.com>
6773             Andrew Burgess  <andrew.burgess@embecosm.com>
6774
6775         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6776         code read might fail, assume 4-byte breakpoint in that case.
6777
6778 2019-04-15  Leszek Swirski  <leszeks@google.com>
6779
6780         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6781         rather than a hand-rolled POD check when checking for forced MEMORY
6782         classification.
6783
6784 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6785
6786         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6787         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6788         function.
6789         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6790         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6791         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6792         declaration.
6793
6794 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6795
6796         * aarch64-linux-nat.c
6797         (aarch64_linux_nat_target::thread_architecture): Add override.
6798         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6799         each VQ.
6800
6801 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6802
6803         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6804
6805 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6806
6807         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6808         target types of size 96-bits, add some additional comments, and
6809         check that the builtin type we found was the correct size.
6810
6811 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6812
6813         * utils.c (prompt_for_continue): Don't restore the styling at the
6814         end, as applied_style has the wrong value.  This fixes styling in
6815         long lists of file names that are interrupted by the "Continue?"
6816         prompt.
6817
6818 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6819
6820         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6821         * c-lang.c (c_language_defn): Likewise.
6822         (cplus_language_defn): Likewise.
6823         (asm_language_defn): Likewise.
6824         (minimal_language_defn): Likewise.
6825         * d-lang.c (d_language_defn): Likewise.
6826         * f-lang.c (f_language_defn): Likewise.
6827         * go-lang.c (go_language_defn): Likewise.
6828         * language.c (unknown_language_defn): Likewise.
6829         (auto_language_defn): Likewise.
6830         * language.h (struct language_defn): Remove la_magic field.
6831         (LANG_MAGIC): Delete.
6832         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6833         * objc-lang.c (objc_language_defn): Likewise.
6834         * opencl-lang.c (opencl_language_defn): Likewise.
6835         * p-lang.c (pascal_language_defn): Likewise.
6836         * rust-lang.c (rust_language_defn): Likewise.
6837
6838 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6839
6840         * riscv-tdep.c (riscv_type_align): New function.
6841         (riscv_type_alignment): Delete.
6842         (riscv_arg_location): Use 'type_align'.
6843         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6844
6845 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6846
6847         * gdbtypes.c (type_align): A struct with no non-static fields also
6848         has alignment of 1.
6849
6850 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6851
6852         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6853         component to 0.
6854         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6855         member.
6856         (riscv_struct_info::analyse): New implementation using new
6857         analyse_inner member function.
6858         (riscv_struct_info::field_offset): New member function.
6859         (riscv_struct_info::m_offsets): New member variable.
6860         (riscv_struct_info::analyse_inner): New private member function,
6861         takes the old implementation of riscv_struct_info::analyse but
6862         extended to track field offsets.
6863         (riscv_call_arg_struct): Update the struct folding special cases
6864         to handle cases where empty C++ structs, which are non-zero
6865         length, are found.
6866         (riscv_arg_location): Initialise the length of each location, a
6867         non-zero length now indicates the location is in use.
6868         (riscv_push_dummy_call): Allow for the first location having a
6869         non-zero offset when setting up arguments.
6870         (riscv_return_value): Likewise, but for return values.
6871
6872 2019-04-11  Tom Tromey  <tromey@adacore.com>
6873
6874         * utils.c (internal_vproblem): Make "msg" const.
6875
6876 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6877
6878         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6879         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6880         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6881         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6882
6883 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6884
6885         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6886         function.
6887         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6888         of amd64_collect_native_gregset.
6889         (amd64_linux_nat_target::store_registers): Likewise.
6890
6891 2019-04-10  Tom Tromey  <tom@tromey.com>
6892
6893         * symtab.c (lookup_global_symbol_from_objfile)
6894         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6895         * objfiles.h (class separate_debug_iterator): New.
6896         (class separate_debug_range): New.
6897         (struct objfile) <separate_debug_objfiles>: New method.
6898         (objfile_separate_debug_iterate): Don't declare.
6899         * objfiles.c (separate_debug_iterator::operator++): Rename from
6900         objfile_separate_debug_iterate.
6901         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6902         iterator.
6903         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6904         iterator.
6905
6906 2019-04-10  Tom Tromey  <tom@tromey.com>
6907
6908         * symfile.c (reread_symbols): Remove old comment.
6909         * objfiles.c (free_all_objfiles): Fix a typo.
6910
6911 2019-04-10  Tom Tromey  <tom@tromey.com>
6912
6913         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6914         * minsyms.c (lookup_minimal_symbol): Use foreach.
6915         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6916         (lookup_minimal_symbol_solib_trampoline): Likewise.
6917         * symfile.c (reread_symbols): Use foreach.
6918
6919 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6920             Tom Tromey  <tromey@adacore.com>
6921
6922         PR rust/24414:
6923         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6924         (rust_lex_int_test): Change "value" to be LONGEST.
6925         (rust_lex_tests): Add test for long integer literal.
6926
6927 2019-04-09  Tom Tromey  <tromey@adacore.com>
6928
6929         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6930         to bool.
6931         (extended_remote_target::attach): Update.
6932         (remote_target::remote_notice_new_inferior): Update.
6933         (remote_target::add_current_inferior_and_thread): Update.
6934         * inferior.c (exit_inferior_1): Use "false".
6935         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6936
6937 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6938
6939         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6940         the "start" command.
6941
6942 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6943
6944         * python/py-inferior.c (infpy_thread_from_thread_handle):
6945         Adjust comments to reflect renaming of thread_from_thread_handle
6946         to thread_from_handle.  Adjust keywords.  Fix type error message.
6947         (inferior_object_methods): Add thread_from_handle.  Retain
6948         thread_from_thread_handle, but mark it as deprecated.
6949
6950 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6951
6952         * gdbthread.h (find_thread_by_handle): Revise declaration.
6953         * thread.c (find_thread_by_handle): Likewise.  Adjust
6954         implementation too.
6955         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6956         support for buffer objects as handles.
6957
6958 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6959
6960         * python/py-infthread.c (thpy_thread_handle): New function.
6961         (thread_object_methods): Register thpy_thread_handle.
6962
6963 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6964
6965         * gdbthread.h (thread_to_thread_handle): Declare.
6966         * thread.c (gdbtypes.h): Include.
6967         (thread_to_thread_handle): New function.
6968
6969         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6970         (target_thread_info_to_thread_handle): Declare.
6971         * target.c (target_thread_info_to_thread_handle): New function.
6972         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6973         * target-delegates.c: Regenerate.
6974
6975         * linux-thread-db.c (class thread_db_target): Add method
6976         thread_info_to_thread_handle.
6977         (thread_db_target::thread_info_to_thread_handle): Define.
6978         * remote.c (class remote_target): Add new method
6979         thread_info_to_thread_handle.
6980         (remote_target::thread_info_to_thread_handle): Define.
6981
6982 2019-04-08  Pedro Alves  <palves@redhat.com>
6983
6984         * common/common-exceptions.c (throw_exception): Don't create
6985         named object to throw; throw directly.
6986         (throw_it): Likewise.  Don't initialize gdb_exception::message
6987         here, with new; pass FMT and AP to the ctor instead.
6988         * common/common-exceptions.h: Include <string>.
6989         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6990         const char *, va_list)): New ctor.  Use std::make_shared.
6991         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6992         errors)): Delete.
6993         (gdb_exception_error::gdb_exception_error(enum errors, const char
6994         *, va_list)): New.
6995         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6996         Add assertion.
6997         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6998         errors)): Delete.
6999         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7000         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7001         Add assertion.
7002
7003 2019-04-08  Tom Tromey  <tom@tromey.com>
7004
7005         * valops.c (value_rtti_indirect_type): Replace throw_exception
7006         with throw.
7007         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7008         with throw.
7009         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7010         throw.
7011         * target.c (target_translate_tls_address): Replace throw_exception
7012         with throw.
7013         * stack.c (frame_apply_command_count): Replace throw_exception
7014         with throw.
7015         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7016         throw.
7017         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7018         with throw.
7019         * rs6000-tdep.c (rs6000_frame_cache)
7020         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7021         * remote.c: Replace throw_exception with throw.
7022         * record-full.c (record_full_message, record_full_wait_1)
7023         (record_full_restore): Replace throw_exception with throw.
7024         * record-btrace.c:
7025         (get_thread_current_frame_id, record_btrace_start_replaying)
7026         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7027         (cmd_record_btrace_start): Replace throw_exception with throw.
7028         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7029         throw.
7030         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7031         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7032         * linespec.c:
7033         (find_linespec_symbols): Replace throw_exception with throw.
7034         * infrun.c (displaced_step_prepare, resume): Replace
7035         throw_exception with throw.
7036         * infcmd.c (post_create_inferior): Replace throw_exception with
7037         throw.
7038         * inf-loop.c (inferior_event_handler): Replace throw_exception
7039         with throw.
7040         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7041         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7042         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7043         (get_prev_frame_always, get_frame_pc_if_available)
7044         (get_frame_address_in_block_if_available, get_frame_language):
7045         Replace throw_exception with throw.
7046         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7047         throw_exception with throw.
7048         * eval.c (fetch_subexp_value, evaluate_var_value)
7049         (evaluate_funcall, evaluate_subexp_standard): Replace
7050         throw_exception with throw.
7051         * dwarf2loc.c (call_site_find_chain)
7052         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7053         Replace throw_exception with throw.
7054         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7055         with throw.
7056         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7057         throw.
7058         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7059         * completer.c (complete_line_internal): Replace throw_exception
7060         with throw.
7061         * compile/compile-object-run.c (compile_object_run): Replace
7062         throw_exception with throw.
7063         * cli/cli-script.c (process_next_line): Replace throw_exception
7064         with throw.
7065         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7066         (btrace_enable, btrace_maint_update_pt_packets): Replace
7067         throw_exception with throw.
7068         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7069         throw_exception with throw.
7070         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7071         throw_exception with throw.
7072         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7073         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7074         * aarch64-tdep.c (aarch64_make_prologue_cache)
7075         (aarch64_make_stub_cache): Replace throw_exception with throw.
7076
7077 2019-04-08  Tom Tromey  <tom@tromey.com>
7078
7079         * common/common-exceptions.c (throw_exception): Rename from
7080         throw_exception_cxx.  Remove old copy.  Make argument const.
7081         (throw_it): Create and throw exception objects directly.
7082         * common/common-exceptions.h (throw_exception): Make argument
7083         const.
7084         (struct gdb_exception_error): Add constructor.
7085         (struct gdb_exception_quit): Add constructor.
7086
7087 2019-04-08  Tom Tromey  <tom@tromey.com>
7088
7089         * common/common-exceptions.h (exception_rethrow): Don't declare.
7090         (TRY_SJLJ): Update comment.
7091         (TRY, CATCH, END_CATCH): Remove.
7092         * common/common-exceptions.c (exception_rethrow): Remove.
7093
7094 2019-04-08  Tom Tromey  <tom@tromey.com>
7095
7096         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7097         Remove.
7098         (gdb_exception_error): Rename from
7099         gdb_exception_RETURN_MASK_ERROR.
7100         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7101         (gdb_quit_bad_alloc): Update.
7102         * aarch64-tdep.c: Update.
7103         * ada-lang.c: Update.
7104         * ada-typeprint.c: Update.
7105         * ada-valprint.c: Update.
7106         * amd64-tdep.c: Update.
7107         * arch-utils.c: Update.
7108         * break-catch-throw.c: Update.
7109         * breakpoint.c: Update.
7110         * btrace.c: Update.
7111         * c-varobj.c: Update.
7112         * cli/cli-cmds.c: Update.
7113         * cli/cli-interp.c: Update.
7114         * cli/cli-script.c: Update.
7115         * common/common-exceptions.c: Update.
7116         * common/new-op.c: Update.
7117         * common/selftest.c: Update.
7118         * compile/compile-c-symbols.c: Update.
7119         * compile/compile-cplus-symbols.c: Update.
7120         * compile/compile-object-load.c: Update.
7121         * compile/compile-object-run.c: Update.
7122         * completer.c: Update.
7123         * corelow.c: Update.
7124         * cp-abi.c: Update.
7125         * cp-support.c: Update.
7126         * cp-valprint.c: Update.
7127         * darwin-nat.c: Update.
7128         * disasm-selftests.c: Update.
7129         * dtrace-probe.c: Update.
7130         * dwarf-index-cache.c: Update.
7131         * dwarf-index-write.c: Update.
7132         * dwarf2-frame-tailcall.c: Update.
7133         * dwarf2-frame.c: Update.
7134         * dwarf2loc.c: Update.
7135         * dwarf2read.c: Update.
7136         * eval.c: Update.
7137         * event-loop.c: Update.
7138         * event-top.c: Update.
7139         * exec.c: Update.
7140         * f-valprint.c: Update.
7141         * fbsd-tdep.c: Update.
7142         * frame-unwind.c: Update.
7143         * frame.c: Update.
7144         * gdbtypes.c: Update.
7145         * gnu-v3-abi.c: Update.
7146         * guile/guile-internal.h: Update.
7147         * guile/scm-block.c: Update.
7148         * guile/scm-breakpoint.c: Update.
7149         * guile/scm-cmd.c: Update.
7150         * guile/scm-disasm.c: Update.
7151         * guile/scm-frame.c: Update.
7152         * guile/scm-lazy-string.c: Update.
7153         * guile/scm-math.c: Update.
7154         * guile/scm-param.c: Update.
7155         * guile/scm-ports.c: Update.
7156         * guile/scm-pretty-print.c: Update.
7157         * guile/scm-symbol.c: Update.
7158         * guile/scm-symtab.c: Update.
7159         * guile/scm-type.c: Update.
7160         * guile/scm-value.c: Update.
7161         * i386-linux-tdep.c: Update.
7162         * i386-tdep.c: Update.
7163         * inf-loop.c: Update.
7164         * infcall.c: Update.
7165         * infcmd.c: Update.
7166         * infrun.c: Update.
7167         * jit.c: Update.
7168         * language.c: Update.
7169         * linespec.c: Update.
7170         * linux-fork.c: Update.
7171         * linux-nat.c: Update.
7172         * linux-tdep.c: Update.
7173         * linux-thread-db.c: Update.
7174         * main.c: Update.
7175         * mi/mi-cmd-break.c: Update.
7176         * mi/mi-cmd-stack.c: Update.
7177         * mi/mi-interp.c: Update.
7178         * mi/mi-main.c: Update.
7179         * objc-lang.c: Update.
7180         * p-valprint.c: Update.
7181         * parse.c: Update.
7182         * ppc-linux-tdep.c: Update.
7183         * printcmd.c: Update.
7184         * python/py-arch.c: Update.
7185         * python/py-breakpoint.c: Update.
7186         * python/py-cmd.c: Update.
7187         * python/py-finishbreakpoint.c: Update.
7188         * python/py-frame.c: Update.
7189         * python/py-framefilter.c: Update.
7190         * python/py-gdb-readline.c: Update.
7191         * python/py-inferior.c: Update.
7192         * python/py-infthread.c: Update.
7193         * python/py-lazy-string.c: Update.
7194         * python/py-linetable.c: Update.
7195         * python/py-objfile.c: Update.
7196         * python/py-param.c: Update.
7197         * python/py-prettyprint.c: Update.
7198         * python/py-progspace.c: Update.
7199         * python/py-record-btrace.c: Update.
7200         * python/py-record.c: Update.
7201         * python/py-symbol.c: Update.
7202         * python/py-type.c: Update.
7203         * python/py-unwind.c: Update.
7204         * python/py-utils.c: Update.
7205         * python/py-value.c: Update.
7206         * python/python.c: Update.
7207         * record-btrace.c: Update.
7208         * record-full.c: Update.
7209         * remote-fileio.c: Update.
7210         * remote.c: Update.
7211         * riscv-tdep.c: Update.
7212         * rs6000-aix-tdep.c: Update.
7213         * rs6000-tdep.c: Update.
7214         * rust-exp.y: Update.
7215         * rust-lang.c: Update.
7216         * s390-tdep.c: Update.
7217         * selftest-arch.c: Update.
7218         * solib-dsbt.c: Update.
7219         * solib-frv.c: Update.
7220         * solib-spu.c: Update.
7221         * solib-svr4.c: Update.
7222         * solib.c: Update.
7223         * sparc64-linux-tdep.c: Update.
7224         * stack.c: Update.
7225         * symfile-mem.c: Update.
7226         * symmisc.c: Update.
7227         * target.c: Update.
7228         * thread.c: Update.
7229         * top.c: Update.
7230         * tracefile-tfile.c: Update.
7231         * tui/tui.c: Update.
7232         * typeprint.c: Update.
7233         * unittests/cli-utils-selftests.c: Update.
7234         * unittests/parse-connection-spec-selftests.c: Update.
7235         * valops.c: Update.
7236         * valprint.c: Update.
7237         * value.c: Update.
7238         * varobj.c: Update.
7239         * windows-nat.c: Update.
7240         * x86-linux-nat.c: Update.
7241         * xml-support.c: Update.
7242
7243 2019-04-08  Tom Tromey  <tom@tromey.com>
7244
7245         * xml-support.c: Use C++ exception handling.
7246         * x86-linux-nat.c: Use C++ exception handling.
7247         * windows-nat.c: Use C++ exception handling.
7248         * varobj.c: Use C++ exception handling.
7249         * value.c: Use C++ exception handling.
7250         * valprint.c: Use C++ exception handling.
7251         * valops.c: Use C++ exception handling.
7252         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7253         handling.
7254         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7255         * typeprint.c: Use C++ exception handling.
7256         * tui/tui.c: Use C++ exception handling.
7257         * tracefile-tfile.c: Use C++ exception handling.
7258         * top.c: Use C++ exception handling.
7259         * thread.c: Use C++ exception handling.
7260         * target.c: Use C++ exception handling.
7261         * symmisc.c: Use C++ exception handling.
7262         * symfile-mem.c: Use C++ exception handling.
7263         * stack.c: Use C++ exception handling.
7264         * sparc64-linux-tdep.c: Use C++ exception handling.
7265         * solib.c: Use C++ exception handling.
7266         * solib-svr4.c: Use C++ exception handling.
7267         * solib-spu.c: Use C++ exception handling.
7268         * solib-frv.c: Use C++ exception handling.
7269         * solib-dsbt.c: Use C++ exception handling.
7270         * selftest-arch.c: Use C++ exception handling.
7271         * s390-tdep.c: Use C++ exception handling.
7272         * rust-lang.c: Use C++ exception handling.
7273         * rust-exp.y: Use C++ exception handling.
7274         * rs6000-tdep.c: Use C++ exception handling.
7275         * rs6000-aix-tdep.c: Use C++ exception handling.
7276         * riscv-tdep.c: Use C++ exception handling.
7277         * remote.c: Use C++ exception handling.
7278         * remote-fileio.c: Use C++ exception handling.
7279         * record-full.c: Use C++ exception handling.
7280         * record-btrace.c: Use C++ exception handling.
7281         * python/python.c: Use C++ exception handling.
7282         * python/py-value.c: Use C++ exception handling.
7283         * python/py-utils.c: Use C++ exception handling.
7284         * python/py-unwind.c: Use C++ exception handling.
7285         * python/py-type.c: Use C++ exception handling.
7286         * python/py-symbol.c: Use C++ exception handling.
7287         * python/py-record.c: Use C++ exception handling.
7288         * python/py-record-btrace.c: Use C++ exception handling.
7289         * python/py-progspace.c: Use C++ exception handling.
7290         * python/py-prettyprint.c: Use C++ exception handling.
7291         * python/py-param.c: Use C++ exception handling.
7292         * python/py-objfile.c: Use C++ exception handling.
7293         * python/py-linetable.c: Use C++ exception handling.
7294         * python/py-lazy-string.c: Use C++ exception handling.
7295         * python/py-infthread.c: Use C++ exception handling.
7296         * python/py-inferior.c: Use C++ exception handling.
7297         * python/py-gdb-readline.c: Use C++ exception handling.
7298         * python/py-framefilter.c: Use C++ exception handling.
7299         * python/py-frame.c: Use C++ exception handling.
7300         * python/py-finishbreakpoint.c: Use C++ exception handling.
7301         * python/py-cmd.c: Use C++ exception handling.
7302         * python/py-breakpoint.c: Use C++ exception handling.
7303         * python/py-arch.c: Use C++ exception handling.
7304         * printcmd.c: Use C++ exception handling.
7305         * ppc-linux-tdep.c: Use C++ exception handling.
7306         * parse.c: Use C++ exception handling.
7307         * p-valprint.c: Use C++ exception handling.
7308         * objc-lang.c: Use C++ exception handling.
7309         * mi/mi-main.c: Use C++ exception handling.
7310         * mi/mi-interp.c: Use C++ exception handling.
7311         * mi/mi-cmd-stack.c: Use C++ exception handling.
7312         * mi/mi-cmd-break.c: Use C++ exception handling.
7313         * main.c: Use C++ exception handling.
7314         * linux-thread-db.c: Use C++ exception handling.
7315         * linux-tdep.c: Use C++ exception handling.
7316         * linux-nat.c: Use C++ exception handling.
7317         * linux-fork.c: Use C++ exception handling.
7318         * linespec.c: Use C++ exception handling.
7319         * language.c: Use C++ exception handling.
7320         * jit.c: Use C++ exception handling.
7321         * infrun.c: Use C++ exception handling.
7322         * infcmd.c: Use C++ exception handling.
7323         * infcall.c: Use C++ exception handling.
7324         * inf-loop.c: Use C++ exception handling.
7325         * i386-tdep.c: Use C++ exception handling.
7326         * i386-linux-tdep.c: Use C++ exception handling.
7327         * guile/scm-value.c: Use C++ exception handling.
7328         * guile/scm-type.c: Use C++ exception handling.
7329         * guile/scm-symtab.c: Use C++ exception handling.
7330         * guile/scm-symbol.c: Use C++ exception handling.
7331         * guile/scm-pretty-print.c: Use C++ exception handling.
7332         * guile/scm-ports.c: Use C++ exception handling.
7333         * guile/scm-param.c: Use C++ exception handling.
7334         * guile/scm-math.c: Use C++ exception handling.
7335         * guile/scm-lazy-string.c: Use C++ exception handling.
7336         * guile/scm-frame.c: Use C++ exception handling.
7337         * guile/scm-disasm.c: Use C++ exception handling.
7338         * guile/scm-cmd.c: Use C++ exception handling.
7339         * guile/scm-breakpoint.c: Use C++ exception handling.
7340         * guile/scm-block.c: Use C++ exception handling.
7341         * guile/guile-internal.h: Use C++ exception handling.
7342         * gnu-v3-abi.c: Use C++ exception handling.
7343         * gdbtypes.c: Use C++ exception handling.
7344         * frame.c: Use C++ exception handling.
7345         * frame-unwind.c: Use C++ exception handling.
7346         * fbsd-tdep.c: Use C++ exception handling.
7347         * f-valprint.c: Use C++ exception handling.
7348         * exec.c: Use C++ exception handling.
7349         * event-top.c: Use C++ exception handling.
7350         * event-loop.c: Use C++ exception handling.
7351         * eval.c: Use C++ exception handling.
7352         * dwarf2read.c: Use C++ exception handling.
7353         * dwarf2loc.c: Use C++ exception handling.
7354         * dwarf2-frame.c: Use C++ exception handling.
7355         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7356         * dwarf-index-write.c: Use C++ exception handling.
7357         * dwarf-index-cache.c: Use C++ exception handling.
7358         * dtrace-probe.c: Use C++ exception handling.
7359         * disasm-selftests.c: Use C++ exception handling.
7360         * darwin-nat.c: Use C++ exception handling.
7361         * cp-valprint.c: Use C++ exception handling.
7362         * cp-support.c: Use C++ exception handling.
7363         * cp-abi.c: Use C++ exception handling.
7364         * corelow.c: Use C++ exception handling.
7365         * completer.c: Use C++ exception handling.
7366         * compile/compile-object-run.c: Use C++ exception handling.
7367         * compile/compile-object-load.c: Use C++ exception handling.
7368         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7369         * compile/compile-c-symbols.c: Use C++ exception handling.
7370         * common/selftest.c: Use C++ exception handling.
7371         * common/new-op.c: Use C++ exception handling.
7372         * cli/cli-script.c: Use C++ exception handling.
7373         * cli/cli-interp.c: Use C++ exception handling.
7374         * cli/cli-cmds.c: Use C++ exception handling.
7375         * c-varobj.c: Use C++ exception handling.
7376         * btrace.c: Use C++ exception handling.
7377         * breakpoint.c: Use C++ exception handling.
7378         * break-catch-throw.c: Use C++ exception handling.
7379         * arch-utils.c: Use C++ exception handling.
7380         * amd64-tdep.c: Use C++ exception handling.
7381         * ada-valprint.c: Use C++ exception handling.
7382         * ada-typeprint.c: Use C++ exception handling.
7383         * ada-lang.c: Use C++ exception handling.
7384         * aarch64-tdep.c: Use C++ exception handling.
7385
7386 2019-04-08  Tom Tromey  <tom@tromey.com>
7387
7388         * xml-support.c (gdb_xml_parser::parse): Update.
7389         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7390         * value.c (show_convenience): Update.
7391         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7392         (test_parse_flags_qcs): Update.
7393         * thread.c (thr_try_catch_cmd): Update.
7394         * target.c (target_translate_tls_address): Update.
7395         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7396         (info_frame_command_core, frame_apply_command_count): Update.
7397         * rust-exp.y (rust_lex_exception_test): Update.
7398         * riscv-tdep.c (riscv_print_one_register_info): Update.
7399         * remote.c (remote_target::enable_btrace): Update.
7400         * record-btrace.c (record_btrace_enable_warn): Update.
7401         * python/py-utils.c (gdbpy_convert_exception): Update.
7402         * printcmd.c (do_one_display, print_variable_and_value): Update.
7403         * mi/mi-main.c (mi_print_exception): Update.
7404         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7405         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7406         * linux-nat.c (linux_nat_target::attach): Update.
7407         * linux-fork.c (class scoped_switch_fork_info): Update.
7408         * infrun.c (displaced_step_prepare): Update.
7409         * infcall.c (call_function_by_hand_dummy): Update.
7410         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7411         * gnu-v3-abi.c (print_one_vtable): Update.
7412         * frame.c (get_prev_frame_always): Update.
7413         * f-valprint.c (info_common_command_for_block): Update.
7414         * exec.c (try_open_exec_file): Update.
7415         * exceptions.c (print_exception, exception_print)
7416         (exception_fprintf, exception_print_same): Update.
7417         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7418         * dwarf-index-cache.c (index_cache::store)
7419         (index_cache::lookup_gdb_index): Update.
7420         * darwin-nat.c (maybe_cache_shell): Update.
7421         * cp-valprint.c (cp_print_value_fields): Update.
7422         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7423         (gcc_cplus_symbol_address): Update.
7424         * compile/compile-c-symbols.c (gcc_convert_symbol)
7425         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7426         * common/selftest.c: Update.
7427         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7428         a std::string.
7429         (exception_try_scope_entry, exception_try_scope_exit): Don't
7430         declare.
7431         (struct exception_try_scope): Remove.
7432         (TRY): Don't use exception_try_scope.
7433         (struct gdb_exception): Add constructor, operator=.
7434         <what>: New method.
7435         (struct gdb_exception_RETURN_MASK_ALL)
7436         (struct gdb_exception_RETURN_MASK_ERROR)
7437         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7438         (struct gdb_quit_bad_alloc): Update.
7439         * common/common-exceptions.c (exception_none): Change
7440         initializer.
7441         (struct catcher) <state, exception>: Initialize inline.
7442         <prev>: Remove member.
7443         (current_catcher): Remove.
7444         (catchers): New global.
7445         (exceptions_state_mc_init): Simplify.
7446         (catcher_pop): Remove.
7447         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7448         (try_scope_depth, exception_try_scope_entry)
7449         (exception_try_scope_exit): Remove.
7450         (throw_exception_sjlj): Update.
7451         (exception_messages, exception_messages_size): Remove.
7452         (throw_it): Simplify.
7453         (gdb_exception_sliced_copy): Remove.
7454         (throw_exception_cxx): Update.
7455         * cli/cli-script.c (script_from_file): Update.
7456         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7457         Update.
7458         * ada-valprint.c (ada_val_print): Update.
7459         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7460         (create_excep_cond_exprs): Update.
7461
7462 2019-04-08  Tom Tromey  <tom@tromey.com>
7463
7464         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7465         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7466         (TRY, CATCH, END_CATCH): Remove some definitions.
7467         * common/common-exceptions.c: Don't use GDB_XCPT.
7468         (catcher_list_size): Remove.
7469         (throw_exception, throw_it): Simplify.
7470
7471 2019-04-05  Tom Tromey  <tom@tromey.com>
7472
7473         Revert the header-sorting patch.
7474         * ft32-tdep.c: Revert.
7475         * frv-tdep.c: Revert.
7476         * frv-linux-tdep.c: Revert.
7477         * frame.c: Revert.
7478         * frame-unwind.c: Revert.
7479         * frame-base.c: Revert.
7480         * fork-child.c: Revert.
7481         * findvar.c: Revert.
7482         * findcmd.c: Revert.
7483         * filesystem.c: Revert.
7484         * filename-seen-cache.h: Revert.
7485         * filename-seen-cache.c: Revert.
7486         * fbsd-tdep.c: Revert.
7487         * fbsd-nat.h: Revert.
7488         * fbsd-nat.c: Revert.
7489         * f-valprint.c: Revert.
7490         * f-typeprint.c: Revert.
7491         * f-lang.c: Revert.
7492         * extension.h: Revert.
7493         * extension.c: Revert.
7494         * extension-priv.h: Revert.
7495         * expprint.c: Revert.
7496         * exec.h: Revert.
7497         * exec.c: Revert.
7498         * exceptions.c: Revert.
7499         * event-top.c: Revert.
7500         * event-loop.c: Revert.
7501         * eval.c: Revert.
7502         * elfread.c: Revert.
7503         * dwarf2read.h: Revert.
7504         * dwarf2read.c: Revert.
7505         * dwarf2loc.c: Revert.
7506         * dwarf2expr.h: Revert.
7507         * dwarf2expr.c: Revert.
7508         * dwarf2-frame.c: Revert.
7509         * dwarf2-frame-tailcall.c: Revert.
7510         * dwarf-index-write.h: Revert.
7511         * dwarf-index-write.c: Revert.
7512         * dwarf-index-common.c: Revert.
7513         * dwarf-index-cache.h: Revert.
7514         * dwarf-index-cache.c: Revert.
7515         * dummy-frame.c: Revert.
7516         * dtrace-probe.c: Revert.
7517         * disasm.h: Revert.
7518         * disasm.c: Revert.
7519         * disasm-selftests.c: Revert.
7520         * dictionary.c: Revert.
7521         * dicos-tdep.c: Revert.
7522         * demangle.c: Revert.
7523         * dcache.h: Revert.
7524         * dcache.c: Revert.
7525         * darwin-nat.h: Revert.
7526         * darwin-nat.c: Revert.
7527         * darwin-nat-info.c: Revert.
7528         * d-valprint.c: Revert.
7529         * d-namespace.c: Revert.
7530         * d-lang.c: Revert.
7531         * ctf.c: Revert.
7532         * csky-tdep.c: Revert.
7533         * csky-linux-tdep.c: Revert.
7534         * cris-tdep.c: Revert.
7535         * cris-linux-tdep.c: Revert.
7536         * cp-valprint.c: Revert.
7537         * cp-support.c: Revert.
7538         * cp-namespace.c: Revert.
7539         * cp-abi.c: Revert.
7540         * corelow.c: Revert.
7541         * corefile.c: Revert.
7542         * continuations.c: Revert.
7543         * completer.h: Revert.
7544         * completer.c: Revert.
7545         * complaints.c: Revert.
7546         * coffread.c: Revert.
7547         * coff-pe-read.c: Revert.
7548         * cli-out.h: Revert.
7549         * cli-out.c: Revert.
7550         * charset.c: Revert.
7551         * c-varobj.c: Revert.
7552         * c-valprint.c: Revert.
7553         * c-typeprint.c: Revert.
7554         * c-lang.c: Revert.
7555         * buildsym.c: Revert.
7556         * buildsym-legacy.c: Revert.
7557         * build-id.h: Revert.
7558         * build-id.c: Revert.
7559         * btrace.c: Revert.
7560         * bsd-uthread.c: Revert.
7561         * breakpoint.h: Revert.
7562         * breakpoint.c: Revert.
7563         * break-catch-throw.c: Revert.
7564         * break-catch-syscall.c: Revert.
7565         * break-catch-sig.c: Revert.
7566         * blockframe.c: Revert.
7567         * block.c: Revert.
7568         * bfin-tdep.c: Revert.
7569         * bfin-linux-tdep.c: Revert.
7570         * bfd-target.c: Revert.
7571         * bcache.c: Revert.
7572         * ax-general.c: Revert.
7573         * ax-gdb.h: Revert.
7574         * ax-gdb.c: Revert.
7575         * avr-tdep.c: Revert.
7576         * auxv.c: Revert.
7577         * auto-load.c: Revert.
7578         * arm-wince-tdep.c: Revert.
7579         * arm-tdep.c: Revert.
7580         * arm-symbian-tdep.c: Revert.
7581         * arm-pikeos-tdep.c: Revert.
7582         * arm-obsd-tdep.c: Revert.
7583         * arm-nbsd-tdep.c: Revert.
7584         * arm-nbsd-nat.c: Revert.
7585         * arm-linux-tdep.c: Revert.
7586         * arm-linux-nat.c: Revert.
7587         * arm-fbsd-tdep.c: Revert.
7588         * arm-fbsd-nat.c: Revert.
7589         * arm-bsd-tdep.c: Revert.
7590         * arch-utils.c: Revert.
7591         * arc-tdep.c: Revert.
7592         * arc-newlib-tdep.c: Revert.
7593         * annotate.h: Revert.
7594         * annotate.c: Revert.
7595         * amd64-windows-tdep.c: Revert.
7596         * amd64-windows-nat.c: Revert.
7597         * amd64-tdep.c: Revert.
7598         * amd64-sol2-tdep.c: Revert.
7599         * amd64-obsd-tdep.c: Revert.
7600         * amd64-obsd-nat.c: Revert.
7601         * amd64-nbsd-tdep.c: Revert.
7602         * amd64-nbsd-nat.c: Revert.
7603         * amd64-nat.c: Revert.
7604         * amd64-linux-tdep.c: Revert.
7605         * amd64-linux-nat.c: Revert.
7606         * amd64-fbsd-tdep.c: Revert.
7607         * amd64-fbsd-nat.c: Revert.
7608         * amd64-dicos-tdep.c: Revert.
7609         * amd64-darwin-tdep.c: Revert.
7610         * amd64-bsd-nat.c: Revert.
7611         * alpha-tdep.c: Revert.
7612         * alpha-obsd-tdep.c: Revert.
7613         * alpha-nbsd-tdep.c: Revert.
7614         * alpha-mdebug-tdep.c: Revert.
7615         * alpha-linux-tdep.c: Revert.
7616         * alpha-linux-nat.c: Revert.
7617         * alpha-bsd-tdep.c: Revert.
7618         * alpha-bsd-nat.c: Revert.
7619         * aix-thread.c: Revert.
7620         * agent.c: Revert.
7621         * addrmap.c: Revert.
7622         * ada-varobj.c: Revert.
7623         * ada-valprint.c: Revert.
7624         * ada-typeprint.c: Revert.
7625         * ada-tasks.c: Revert.
7626         * ada-lang.c: Revert.
7627         * aarch64-tdep.c: Revert.
7628         * aarch64-ravenscar-thread.c: Revert.
7629         * aarch64-newlib-tdep.c: Revert.
7630         * aarch64-linux-tdep.c: Revert.
7631         * aarch64-linux-nat.c: Revert.
7632         * aarch64-fbsd-tdep.c: Revert.
7633         * aarch64-fbsd-nat.c: Revert.
7634         * aarch32-linux-nat.c: Revert.
7635
7636 2019-04-05  Tom Tromey  <tom@tromey.com>
7637
7638         * ft32-tdep.c: Sort headers.
7639         * frv-tdep.c: Sort headers.
7640         * frv-linux-tdep.c: Sort headers.
7641         * frame.c: Sort headers.
7642         * frame-unwind.c: Sort headers.
7643         * frame-base.c: Sort headers.
7644         * fork-child.c: Sort headers.
7645         * findvar.c: Sort headers.
7646         * findcmd.c: Sort headers.
7647         * filesystem.c: Sort headers.
7648         * filename-seen-cache.h: Sort headers.
7649         * filename-seen-cache.c: Sort headers.
7650         * fbsd-tdep.c: Sort headers.
7651         * fbsd-nat.h: Sort headers.
7652         * fbsd-nat.c: Sort headers.
7653         * f-valprint.c: Sort headers.
7654         * f-typeprint.c: Sort headers.
7655         * f-lang.c: Sort headers.
7656         * extension.h: Sort headers.
7657         * extension.c: Sort headers.
7658         * extension-priv.h: Sort headers.
7659         * expprint.c: Sort headers.
7660         * exec.h: Sort headers.
7661         * exec.c: Sort headers.
7662         * exceptions.c: Sort headers.
7663         * event-top.c: Sort headers.
7664         * event-loop.c: Sort headers.
7665         * eval.c: Sort headers.
7666         * elfread.c: Sort headers.
7667         * dwarf2read.h: Sort headers.
7668         * dwarf2read.c: Sort headers.
7669         * dwarf2loc.c: Sort headers.
7670         * dwarf2expr.h: Sort headers.
7671         * dwarf2expr.c: Sort headers.
7672         * dwarf2-frame.c: Sort headers.
7673         * dwarf2-frame-tailcall.c: Sort headers.
7674         * dwarf-index-write.h: Sort headers.
7675         * dwarf-index-write.c: Sort headers.
7676         * dwarf-index-common.c: Sort headers.
7677         * dwarf-index-cache.h: Sort headers.
7678         * dwarf-index-cache.c: Sort headers.
7679         * dummy-frame.c: Sort headers.
7680         * dtrace-probe.c: Sort headers.
7681         * disasm.h: Sort headers.
7682         * disasm.c: Sort headers.
7683         * disasm-selftests.c: Sort headers.
7684         * dictionary.c: Sort headers.
7685         * dicos-tdep.c: Sort headers.
7686         * demangle.c: Sort headers.
7687         * dcache.h: Sort headers.
7688         * dcache.c: Sort headers.
7689         * darwin-nat.h: Sort headers.
7690         * darwin-nat.c: Sort headers.
7691         * darwin-nat-info.c: Sort headers.
7692         * d-valprint.c: Sort headers.
7693         * d-namespace.c: Sort headers.
7694         * d-lang.c: Sort headers.
7695         * ctf.c: Sort headers.
7696         * csky-tdep.c: Sort headers.
7697         * csky-linux-tdep.c: Sort headers.
7698         * cris-tdep.c: Sort headers.
7699         * cris-linux-tdep.c: Sort headers.
7700         * cp-valprint.c: Sort headers.
7701         * cp-support.c: Sort headers.
7702         * cp-namespace.c: Sort headers.
7703         * cp-abi.c: Sort headers.
7704         * corelow.c: Sort headers.
7705         * corefile.c: Sort headers.
7706         * continuations.c: Sort headers.
7707         * completer.h: Sort headers.
7708         * completer.c: Sort headers.
7709         * complaints.c: Sort headers.
7710         * coffread.c: Sort headers.
7711         * coff-pe-read.c: Sort headers.
7712         * cli-out.h: Sort headers.
7713         * cli-out.c: Sort headers.
7714         * charset.c: Sort headers.
7715         * c-varobj.c: Sort headers.
7716         * c-valprint.c: Sort headers.
7717         * c-typeprint.c: Sort headers.
7718         * c-lang.c: Sort headers.
7719         * buildsym.c: Sort headers.
7720         * buildsym-legacy.c: Sort headers.
7721         * build-id.h: Sort headers.
7722         * build-id.c: Sort headers.
7723         * btrace.c: Sort headers.
7724         * bsd-uthread.c: Sort headers.
7725         * breakpoint.h: Sort headers.
7726         * breakpoint.c: Sort headers.
7727         * break-catch-throw.c: Sort headers.
7728         * break-catch-syscall.c: Sort headers.
7729         * break-catch-sig.c: Sort headers.
7730         * blockframe.c: Sort headers.
7731         * block.c: Sort headers.
7732         * bfin-tdep.c: Sort headers.
7733         * bfin-linux-tdep.c: Sort headers.
7734         * bfd-target.c: Sort headers.
7735         * bcache.c: Sort headers.
7736         * ax-general.c: Sort headers.
7737         * ax-gdb.h: Sort headers.
7738         * ax-gdb.c: Sort headers.
7739         * avr-tdep.c: Sort headers.
7740         * auxv.c: Sort headers.
7741         * auto-load.c: Sort headers.
7742         * arm-wince-tdep.c: Sort headers.
7743         * arm-tdep.c: Sort headers.
7744         * arm-symbian-tdep.c: Sort headers.
7745         * arm-pikeos-tdep.c: Sort headers.
7746         * arm-obsd-tdep.c: Sort headers.
7747         * arm-nbsd-tdep.c: Sort headers.
7748         * arm-nbsd-nat.c: Sort headers.
7749         * arm-linux-tdep.c: Sort headers.
7750         * arm-linux-nat.c: Sort headers.
7751         * arm-fbsd-tdep.c: Sort headers.
7752         * arm-fbsd-nat.c: Sort headers.
7753         * arm-bsd-tdep.c: Sort headers.
7754         * arch-utils.c: Sort headers.
7755         * arc-tdep.c: Sort headers.
7756         * arc-newlib-tdep.c: Sort headers.
7757         * annotate.h: Sort headers.
7758         * annotate.c: Sort headers.
7759         * amd64-windows-tdep.c: Sort headers.
7760         * amd64-windows-nat.c: Sort headers.
7761         * amd64-tdep.c: Sort headers.
7762         * amd64-sol2-tdep.c: Sort headers.
7763         * amd64-obsd-tdep.c: Sort headers.
7764         * amd64-obsd-nat.c: Sort headers.
7765         * amd64-nbsd-tdep.c: Sort headers.
7766         * amd64-nbsd-nat.c: Sort headers.
7767         * amd64-nat.c: Sort headers.
7768         * amd64-linux-tdep.c: Sort headers.
7769         * amd64-linux-nat.c: Sort headers.
7770         * amd64-fbsd-tdep.c: Sort headers.
7771         * amd64-fbsd-nat.c: Sort headers.
7772         * amd64-dicos-tdep.c: Sort headers.
7773         * amd64-darwin-tdep.c: Sort headers.
7774         * amd64-bsd-nat.c: Sort headers.
7775         * alpha-tdep.c: Sort headers.
7776         * alpha-obsd-tdep.c: Sort headers.
7777         * alpha-nbsd-tdep.c: Sort headers.
7778         * alpha-mdebug-tdep.c: Sort headers.
7779         * alpha-linux-tdep.c: Sort headers.
7780         * alpha-linux-nat.c: Sort headers.
7781         * alpha-bsd-tdep.c: Sort headers.
7782         * alpha-bsd-nat.c: Sort headers.
7783         * aix-thread.c: Sort headers.
7784         * agent.c: Sort headers.
7785         * addrmap.c: Sort headers.
7786         * ada-varobj.c: Sort headers.
7787         * ada-valprint.c: Sort headers.
7788         * ada-typeprint.c: Sort headers.
7789         * ada-tasks.c: Sort headers.
7790         * ada-lang.c: Sort headers.
7791         * aarch64-tdep.c: Sort headers.
7792         * aarch64-ravenscar-thread.c: Sort headers.
7793         * aarch64-newlib-tdep.c: Sort headers.
7794         * aarch64-linux-tdep.c: Sort headers.
7795         * aarch64-linux-nat.c: Sort headers.
7796         * aarch64-fbsd-tdep.c: Sort headers.
7797         * aarch64-fbsd-nat.c: Sort headers.
7798         * aarch32-linux-nat.c: Sort headers.
7799
7800 2019-04-04  Tom Tromey  <tom@tromey.com>
7801
7802         * varobj.c (varobj_create): Update.
7803         * rust-exp.y (struct rust_parser) <update_innermost_block,
7804         lookup_symbol>: New methods.
7805         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7806         Rename.
7807         (rust_parser::rust_lookup_type)
7808         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7809         * printcmd.c (display_command, do_one_display): Update.
7810         * parser-defs.h (struct parser_state) <parser_state>: Add
7811         "tracker" parameter.
7812         (block_tracker): New member.
7813         (class innermost_block_tracker) <innermost_block_tracker>: Add
7814         "types" parameter.
7815         <reset>: Remove method.
7816         (innermost_block): Don't declare.
7817         (null_post_parser): Update.
7818         * parse.c (innermost_block): Remove global.
7819         (write_dollar_variable): Update.
7820         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7821         Remove "tracker_types" parameter.
7822         (parse_expression): Add "tracker" parameter.
7823         (parse_expression_for_completion): Update.
7824         (null_post_parser): Add "tracker" parameter.
7825         * p-exp.y: Update rules.
7826         * m2-exp.y: Update rules.
7827         * language.h (struct language_defn) <la_post_parser>: Add
7828         "tracker" parameter.
7829         * go-exp.y: Update rules.
7830         * f-exp.y: Update rules.
7831         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7832         parameter.
7833         * d-exp.y: Update rules.
7834         * c-exp.y: Update rules.
7835         * breakpoint.c (set_breakpoint_condition): Create an
7836         innermost_block_tracker.
7837         (watch_command_1): Likewise.
7838         * ada-lang.c (resolve): Add "tracker" parameter.
7839         (resolve_subexp): Likewise.
7840         * ada-exp.y (write_var_from_sym): Update.
7841
7842 2019-04-04  Tom Tromey  <tom@tromey.com>
7843
7844         * type-stack.h: New file.
7845         * type-stack.c: New file.
7846         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7847         type-stack.h.
7848         (insert_into_type_stack, insert_type, push_type, push_type_int)
7849         (insert_type_address_space, pop_type, pop_type_int)
7850         (pop_typelist, pop_type_stack, append_type_stack)
7851         (push_type_stack, get_type_stack, push_typelist)
7852         (follow_type_instance_flags, follow_types): Don't declare.
7853         * parse.c (type_stack): Remove global.
7854         (parse_exp_in_context): Update.
7855         (insert_into_type_stack, insert_type, push_type, push_type_int)
7856         (insert_type_address_space, pop_type, pop_type_int)
7857         (pop_typelist, pop_type_stack, append_type_stack)
7858         (push_type_stack, get_type_stack, push_typelist)
7859         (follow_type_instance_flags, follow_types): Remove (moved to
7860         type-stack.c).
7861         * f-exp.y (type_stack): New global.
7862         Update rules.
7863         (push_kind_type, f_parse): Update.
7864         * d-exp.y (type_stack): New global.
7865         Update rules.
7866         (d_parse): Update.
7867         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7868         Update rules.
7869         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7870         (HFILES_NO_SRCDIR): Add type-stack.h.
7871
7872 2019-04-04  Tom Tromey  <tom@tromey.com>
7873
7874         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7875         (rust_parser::convert_ast_to_expression, rust_parse)
7876         (rust_lex_test_completion, rust_lex_tests): Update.
7877         * parser-defs.h (struct expr_completion_state): New.
7878         (struct parser_state) <parser_state>: Add completion parameter.
7879         <mark_struct_expression, mark_completion_tag>: New methods.
7880         <parse_completion, m_completion_state>: New members.
7881         (prefixify_expression, null_post_parser): Update.
7882         (mark_struct_expression, mark_completion_tag): Don't declare.
7883         * parse.c (parse_completion, expout_last_struct)
7884         (expout_tag_completion_type, expout_completion_name): Remove
7885         globals.
7886         (parser_state::mark_struct_expression)
7887         (parser_state::mark_completion_tag): Now methods.
7888         (prefixify_expression): Add last_struct parameter.
7889         (prefixify_subexp): Likewise.
7890         (parse_exp_1): Update.
7891         (parse_exp_in_context): Add cstate parameter.  Update.
7892         (parse_expression_for_completion): Create an
7893         expr_completion_state.
7894         (null_post_parser): Add "completion" parameter.
7895         * p-exp.y: Update rules.
7896         (yylex): Update.
7897         * language.h (struct language_defn) <la_post_parser>: Add
7898         "completing" parameter.
7899         * go-exp.y: Update rules.
7900         (lex_one_token): Update.
7901         * expression.h (parse_completion): Don't declare.
7902         * d-exp.y: Update rules.
7903         (lex_one_token): Update rules.
7904         * c-exp.y: Update rules.
7905         (lex_one_token): Update.
7906         * ada-lang.c (resolve): Add "parse_completion" parameter.
7907         (resolve_subexp): Likewise.
7908         (ada_resolve_function): Likewise.
7909
7910 2019-04-04  Tom Tromey  <tom@tromey.com>
7911
7912         * parser-defs.h (struct parser_state) <start_arglist,
7913         end_arglist>: New methods.
7914         <arglist_len, m_funcall_chain>: New members.
7915         (arglist_len, start_arglist, end_arglist): Don't declare.
7916         * parse.c (arglist_len, funcall_chain): Remove global.
7917         (start_arglist, end_arglist): Remove functions.
7918         (parse_exp_in_context): Update.
7919         * p-exp.y: Update rules.
7920         * m2-exp.y: Update rules.
7921         * go-exp.y: Update rules.
7922         * f-exp.y: Update rules.
7923         * d-exp.y: Update rules.
7924         * c-exp.y: Update rules.
7925
7926 2019-04-04  Tom Tromey  <tom@tromey.com>
7927
7928         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7929         lex_operator, push_back>: New methods.
7930         Update all rules.
7931         (rust_parser::lex_hex, lex_escape): Rename and update.
7932         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7933         (rust_parser::lex_operator): Rename and update.
7934         (rust_parser::lex_number, rustyylex, rustyyerror)
7935         (rust_lex_test_init, rust_lex_test_sequence)
7936         (rust_lex_test_push_back, rust_lex_tests): Update.
7937         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7938         parameter.
7939         <lexptr, prev_lexptr>: New members.
7940         (lexptr, prev_lexptr): Don't declare.
7941         * parse.c (lexptr, prev_lexptr): Remove globals.
7942         (parse_exp_in_context): Update.
7943         * p-exp.y (yylex, yyerror): Update.
7944         * m2-exp.y (parse_number, yylex, yyerror): Update.
7945         * go-exp.y (lex_one_token, yyerror): Update.
7946         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7947         * d-exp.y (lex_one_token, yyerror): Update.
7948         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7949         (lex_one_token, yyerror): Update.
7950         * ada-lex.l (YY_INPUT): Update.
7951         (rewind_to_char): Update.
7952         * ada-exp.y (yyerror): Update.
7953
7954 2019-04-04  Tom Tromey  <tom@tromey.com>
7955
7956         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7957         * parser-defs.h (struct parser_state) <parser_state>: Add new
7958         parameter.
7959         <comma_terminates>: New member.
7960         (comma_terminates): Don't declare global.
7961         * parse.c (comma_terminates): Remove global.
7962         (parse_exp_in_context): Update.
7963         * p-exp.y (yylex): Update.
7964         * m2-exp.y (yylex): Update.
7965         * go-exp.y (lex_one_token): Update.
7966         * f-exp.y (yylex): Update.
7967         * d-exp.y (lex_one_token): Update.
7968         * c-exp.y (lex_one_token): Update.
7969         * ada-lex.l: Update.
7970
7971 2019-04-04  Tom Tromey  <tom@tromey.com>
7972
7973         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7974         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7975         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7976         * parser-defs.h (paren_depth): Don't declare.
7977         * parse.c (paren_depth): Remove global.
7978         (parse_exp_in_context): Update.
7979         * p-exp.y (paren_depth): New global.
7980         (pascal_parse): Initialize it.
7981         * m2-exp.y (paren_depth): New global.
7982         (m2_parse): Initialize it.
7983         * go-exp.y (paren_depth): New global.
7984         (go_parse): Initialize it.
7985         * f-exp.y (paren_depth): New global.
7986         (f_parse): Initialize it.
7987         * d-exp.y (paren_depth): New global.
7988         (d_parse): Initialize it.
7989         * c-exp.y (paren_depth): New global.
7990         (c_parse): Initialize it.
7991         * ada-lex.l (paren_depth): New global.
7992         (lexer_init): Initialize it.
7993
7994 2019-04-04  Tom Tromey  <tom@tromey.com>
7995
7996         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7997         (rust_parser::convert_ast_to_type)
7998         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7999         * parser-defs.h (struct parser_state) <parser_state>: Add
8000         parameters.  Initialize new members.
8001         <expression_context_block, expression_context_pc>: New members.
8002         * parse.c (expression_context_block, expression_context_pc):
8003         Remove globals.
8004         (parse_exp_in_context): Update.
8005         * p-exp.y: Update all rules.
8006         (yylex): Update.
8007         * m2-exp.y: Update all rules.
8008         (yylex): Update.
8009         * go-exp.y (yylex): Update.
8010         * f-exp.y (yylex): Update.
8011         * d-exp.y: Update all rules.
8012         (yylex): Update.
8013         * c-exp.y: Update all rules.
8014         (lex_one_token, classify_name, yylex, c_parse): Update.
8015         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8016
8017 2019-04-04  Tom Tromey  <tom@tromey.com>
8018
8019         * gdbarch.h, gdbarch.c: Rebuild.
8020         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8021         * stap-probe.h:
8022         (struct stap_parse_info): Replace "parser_state" with
8023         "expr_builder".
8024         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8025         (parser_state): New class.
8026         * parse.c (expr_builder): Rename.
8027         (expr_builder::release): Rename.
8028         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8029         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8030         (write_exp_elt_longcst, write_exp_elt_floatcst)
8031         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8032         (write_exp_string_vector, write_exp_bitstring)
8033         (write_exp_msymbol, mark_struct_expression)
8034         (write_dollar_variable)
8035         (insert_type_address_space, increase_expout_size): Replace
8036         "parser_state" with "expr_builder".
8037         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8038         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8039         "parser_state" with "expr_builder".
8040
8041 2019-04-04  Tom Tromey  <tom@tromey.com>
8042
8043         * rust-exp.y: Replace "parse_language" with method call.
8044         * p-exp.y:
8045         (yylex): Replace "parse_language" with method call.
8046         * m2-exp.y:
8047         (yylex): Replace "parse_language" with method call.
8048         * go-exp.y (classify_name): Replace "parse_language" with method
8049         call.
8050         * f-exp.y (yylex): Replace "parse_language" with method call.
8051         * d-exp.y (lex_one_token): Replace "parse_language" with method
8052         call.
8053         * c-exp.y:
8054         (lex_one_token, classify_name, yylex): Replace "parse_language"
8055         with method call.
8056         * ada-exp.y (find_primitive_type, type_char)
8057         (type_system_address): Replace "parse_language" with method call.
8058
8059 2019-04-04  Tom Tromey  <tom@tromey.com>
8060
8061         * rust-exp.y: Replace "parse_gdbarch" with method call.
8062         * parse.c (write_dollar_variable, insert_type_address_space):
8063         Replace "parse_gdbarch" with method call.
8064         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8065         call.
8066         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8067         call.
8068         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8069         "parse_gdbarch" with method call.
8070         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8071         with method call.
8072         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8073         "parse_gdbarch" with method call.
8074         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8075         "parse_gdbarch" with method call.
8076         * c-exp.y (parse_type, parse_number, classify_name): Replace
8077         "parse_gdbarch" with method call.
8078         * ada-lex.l: Replace "parse_gdbarch" with method call.
8079         * ada-exp.y (parse_type, find_primitive_type, type_char)
8080         (type_system_address): Replace "parse_gdbarch" with method call.
8081
8082 2019-04-04  Tom Tromey  <tom@tromey.com>
8083
8084         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8085         * stap-probe.c (stap_parse_argument): Update.
8086         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8087         initial_size parameter.
8088         * rust-exp.y (rust_lex_tests): Update.
8089         * parse.c (parser_state): Update.
8090         (parse_exp_in_context): Update.
8091         * parser-defs.h (struct parser_state) <parser_state>: Remove
8092         "initial_size" parameter.
8093
8094 2019-04-04  Tom Tromey  <tom@tromey.com>
8095
8096         * parser-defs.h (increase_expout_size): Don't declare.
8097         * parse.c (increase_expout_size): Now static.
8098
8099 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8100
8101         * gnu-nat.c (gnu_nat_target::wait): Fix
8102         target_waitstatus_to_string call.
8103
8104 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8105
8106         * eval.c (evaluate_subexp_standard): Handle internal functions
8107         during Fortran function call handling.
8108
8109 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8110
8111         * NEWS: Mention new internal functions.
8112         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8113         (read_base_type): Use dwarf2_init_complex_target_type.
8114         * value.c (creal_internal_fn): New function.
8115         (cimag_internal_fn): New function.
8116         (_initialize_values): Register new internal functions.
8117
8118 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8119
8120         * infrun.c (stop_all_threads): If debug_infrun, always
8121         trace the wait status after wait_one, using
8122         target_waitstatus_to_string and target_pid_to_str.
8123         (handle_inferior_event): Replace various trace of
8124         wait status kind by a single trace.
8125         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8126         wait status kind image by target_waitstatus_to_string.
8127         * target/waitstatus.c (target_waitstatus_to_string): Fix
8128         obsolete comment.
8129
8130 2019-04-01  Tom Tromey  <tromey@adacore.com>
8131
8132         PR symtab/23331:
8133         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8134
8135 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8136             Pedro Alves  <palves@redhat.com>
8137
8138         * top.c (quit_force): Call 'finalize_values'.
8139         * value.c (finalize_values): New function.
8140         * value.h (finalize_values): Declare.
8141
8142 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8143
8144         * NEWS: Announce $_gdb_major and $_gdb_minor.
8145
8146         * top.c (init_gdb_version_vars): New function.
8147         (gdb_init): Call init_gdb_version_vars.
8148
8149 2019-03-29  Tom Tromey  <tromey@adacore.com>
8150
8151         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8152         help text.  Remove dead code.
8153
8154 2019-03-29  Keith Seitz  <keiths@redhat.com>
8155
8156         From Siddhesh Poyarekar:
8157         * f-lang.h (f77_get_upperbound): Return LONGEST.
8158         (f77_get_lowerbound): Likewise.
8159         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8160         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8161         print them.
8162         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8163         plongest to format print it.
8164         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8165         (f77_get_upperbound): Likewise.
8166         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8167         LOWER_BOUND to LONGEST.
8168         (f77_create_arrayprint_offset_tbl): Likewise.
8169
8170 2019-03-29  Keith Seitz  <keiths@redhat.com>
8171
8172         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8173         %s/pulongest for TYPE_LENGTH instead of %d in format
8174         strings.
8175         * ada-typerint.c (ada_print_type): Likewise.
8176         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8177         * compile/compile-c-support.c (generate_register_struct): Likewise.
8178         * gdbtypes.c (recursive_dump_type): Likewise.
8179         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8180         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8181         instead of %d in format strings.
8182         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8183         to std::min to ULONGEST.
8184         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8185         instead of %d in format strings.
8186         * tracepoint.c (info_scope_command): Likewise.
8187         * typeprint.c (print_offset_data::update)
8188         (print_offset_data::finish): Likewise.
8189         * xtensa-tdep.c (xtensa_store_return_value)
8190         (xtensa_push_dummy_call): Likewise.
8191
8192 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8193
8194         * windows-nat.c (display_selector): Fixed format specifications
8195         for 64-bit Cygwin.
8196
8197 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8198
8199         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8200
8201 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8202
8203         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8204         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8205         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8206         (nios2_linux_init_abi): Install it.
8207
8208 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8209
8210         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8211
8212 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8213
8214         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8215
8216 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8217             Tom Tromey  <tromey@adacore.com>
8218
8219         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8220
8221 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8222
8223         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8224         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8225         method to compute the bounds of range types. Also print "[evaluated]"
8226         if the bounds' values come from a dynamic evaluation.
8227
8228 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8229
8230         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8231         whitespace when pretty printing is on.
8232
8233 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8234
8235         * ppc-linux-nat.c: Add include.
8236
8237 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8238
8239         * NEWS: Mention AArch64 Pointer Authentication.
8240
8241 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8242
8243         * arm-linux-nat.c: Add include.
8244
8245 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8246
8247         * source-cache.c (source_cache::get_source_lines): Re-read
8248         fullname after calling open_source_file.
8249
8250 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8251
8252         * NEWS: Mention TLS support for FreeBSD.
8253
8254 2019-03-25  Tom Tromey  <tromey@adacore.com>
8255
8256         * minsyms.c (BUNCH_SIZE): Update comment.
8257         (~minimal_symbol_reader): Remove old comment.
8258         (compact_minimal_symbols): Update comment.
8259         (minimal_symbol_reader::install): Remove old comment.  Update
8260         other comments.
8261
8262 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8263
8264         * s390-linux-nat.c: Add include.
8265
8266 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8267
8268         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8269         Call linux_get_hwcap.
8270         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8271         Likewise.
8272         (aarch64_linux_get_hwcap): Remove function.
8273         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8274         declaration.
8275         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8276         linux_get_hwcap.
8277         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8278         * linux-tdep.c (linux_get_hwcap): Add function.
8279         (linux_get_hwcap2): Likewise.
8280         * linux-tdep.h (linux_get_hwcap): Add declaration.
8281         (linux_get_hwcap2): Likewise.
8282         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8283         (ppc_linux_get_hwcap2): Likewise.
8284         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8285         linux_get_hwcap.
8286         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8287         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8288         (ppc_linux_nat_target::read_description): Likewise.
8289         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8290         * s390-linux-nat.c: Likewise.
8291         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8292
8293 2019-03-24  Tom Tromey  <tom@tromey.com>
8294
8295         * ada-lang.c (standard_lookup): Simplify initialization.
8296         (ada_lookup_symbol_nonlocal): Simplify return.
8297         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8298         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8299         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8300         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8301         initialization.
8302         * solib.c (solib_global_lookup): Simplify.
8303         * symtab.c (null_block_symbol): Remove.
8304         (symbol_cache_lookup): Simplify returns.
8305         (lookup_language_this): Simplify returns.
8306         (lookup_symbol_aux): Simplify return.
8307         (lookup_local_symbol): Simplify returns.
8308         (lookup_global_symbol_from_objfile): Simplify return.
8309         (lookup_symbol_in_objfile_symtabs)
8310         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8311         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8312         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8313         * cp-namespace.c (cp_lookup_bare_symbol)
8314         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8315         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8316         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8317         (cp_lookup_symbol_via_imports): Simplify initialization.
8318         (find_symbol_in_baseclass): Likewise.
8319         * symtab.h (null_block_symbol): Remove.
8320         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8321         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8322         (d_lookup_symbol_module): Likewise.
8323         (find_symbol_in_baseclass): Simplify initialization.
8324
8325 2019-03-24  Tom Tromey  <tom@tromey.com>
8326
8327         * expression.h: Don't include symtab.h.
8328         (struct block): Forward declare.
8329
8330 2019-03-24  Tom Tromey  <tom@tromey.com>
8331
8332         * c-exp.y (typebase): Remove casts.
8333         * gdbtypes.c (lookup_unsigned_typename, )
8334         (lookup_signed_typename): Remove cast.
8335         * eval.c (parse_to_comma_and_eval): Remove cast.
8336         * parse.c (write_dollar_variable): Remove cast.
8337         * block.h (struct block) <superblock>: Now const.
8338         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8339         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8340         (map_block): Make "block" const.
8341         * symfile.h (struct quick_symbol_functions)
8342         <map_matching_symbols>: Constify block argument to "callback".
8343         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8344         const.
8345         (find_pc_sect_compunit_symtab): Make "b" const.
8346         (find_symbol_at_address): Likewise.
8347         (search_symbols): Likewise.
8348         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8349         (dw2_debug_names_lookup_symbol): Likewise.
8350         (dw2_map_matching_symbols): Update.
8351         * p-valprint.c (pascal_val_print): Remove "block".
8352         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8353         (aux_add_nonlocal_symbols): Make "block" const.
8354         (resolve_subexp): Remove cast.
8355         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8356         const.
8357         (iterate_over_file_blocks): Likewise.
8358         * f-exp.y (%union) <bval>: Remove.
8359         * coffread.c (patch_opaque_types): Make "b" const.
8360         * spu-tdep.c (spu_catch_start): Make "block" const.
8361         * c-valprint.c (print_unpacked_pointer): Remove "block".
8362         * symmisc.c (dump_symtab_1): Make "b" const.
8363         (block_depth): Make "block" const.
8364         * d-exp.y (%union) <bval>: Remove.
8365         * cp-support.h (cp_lookup_rtti_type): Update.
8366         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8367         * psymtab.c (psym_lookup_symbol): Make "block" const.
8368         (maintenance_check_psymtabs): Make "b" const.
8369         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8370         (enumerate_locals, enumerate_args): Update.
8371         * python/py-symtab.c (stpy_global_block): Make "block" const.
8372         (stpy_static_block): Likewise.
8373         * inline-frame.c (block_starting_point_at): Make "new_block"
8374         const.
8375         * block.c (find_block_in_blockvector): Make return type const.
8376         (blockvector_for_pc_sect): Make "b" const.
8377         (find_block_in_blockvector): Make "b" const.
8378
8379 2019-03-23  Tom Tromey  <tom@tromey.com>
8380
8381         * varobj.c (varobj_create): Update.
8382         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8383         * printcmd.c (display_command, do_one_display): Don't reset
8384         innermost_block.
8385         * parser-defs.h (enum innermost_block_tracker_type): Move to
8386         expression.h.
8387         (innermost_block): Update comment.
8388         * parse.c (parse_exp_1): Add tracker_types parameter.
8389         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8390         tracker_types parameter.  Reset innermost_block.
8391         (parse_exp_in_context): Remove.
8392         (parse_expression_for_completion): Update.
8393         * objfiles.c (~objfile): Don't reset expression_context_block or
8394         innermost_block.
8395         * expression.h (enum innermost_block_tracker_type): Move from
8396         parser-defs.h.
8397         (parse_exp_1): Add tracker_types parameter.
8398         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8399         reset innermost_block.
8400
8401 2019-03-23  Tom Tromey  <tom@tromey.com>
8402
8403         * objfiles.h: Include bcache.h.
8404
8405 2019-03-23  Tom Tromey  <tom@tromey.com>
8406
8407         * linespec.c (get_current_search_block): Use
8408         scoped_restore_current_language.
8409         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8410
8411 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8412             Jiong Wang  <jiong.wang@arm.com>
8413
8414         * aarch64-linux-tdep.c
8415         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8416         section.
8417         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8418
8419 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8420             Jiong Wang  <jiong.wang@arm.com>
8421
8422         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8423         instructions.
8424         (aarch64_analyze_prologue_test): Add PACIASP test.
8425         (aarch64_prologue_prev_register): Unmask PC value.
8426
8427 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8428             Jiong Wang  <jiong.wang@arm.com>
8429
8430         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8431         (aarch64_dwarf2_prev_register): Unmask PC value.
8432         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8433         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8434         DW_CFA_AARCH64_negate_ra_state.
8435         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8436
8437 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8438             Jiong Wang  <jiong.wang@arm.com>
8439
8440         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8441         registers.
8442         (aarch64_pseudo_register_name): Likewise.
8443         (aarch64_pseudo_register_type): Likewise.
8444         (aarch64_pseudo_register_reggroup_p): Likewise.
8445         (aarch64_gdbarch_init): Add pauth registers.
8446         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8447         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8448         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8449         (struct gdbarch_tdep): Add regnum for ra_state.
8450
8451 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8452             Jiong Wang  <jiong.wang@arm.com>
8453
8454         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8455
8456 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8457             Jiong Wang  <jiong.wang@arm.com>
8458
8459         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8460         function.
8461         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8462         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8463         (aarch64_gdbarch_init): Add puth registers.
8464         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8465         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8466         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8467
8468 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8469             Jiong Wang  <jiong.wang@arm.com>
8470
8471         * aarch64-linux-nat.c
8472         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8473         * aarch64-linux-tdep.c
8474         (aarch64_linux_core_read_description): Likewise.
8475         (aarch64_linux_get_hwcap): New function.
8476         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8477         (aarch64_linux_get_hwcap): New declaration.
8478
8479 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8480             Jiong Wang  <jiong.wang@arm.com>
8481
8482         * aarch64-linux-nat.c
8483         (aarch64_linux_nat_target::read_description): Add pauth param.
8484         * aarch64-linux-tdep.c
8485         (aarch64_linux_core_read_description): Likewise.
8486         * aarch64-tdep.c (struct target_desc): Add in pauth.
8487         (aarch64_read_description): Add pauth param.
8488         (aarch64_gdbarch_init): Likewise.
8489         * aarch64-tdep.h (aarch64_read_description): Likewise.
8490         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8491         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8492         * features/Makefile: Add new files.
8493         * features/aarch64-pauth.c: New file.
8494         * features/aarch64-pauth.xml: New file.
8495
8496 2019-03-20  Tom Tromey  <tromey@adacore.com>
8497
8498         * infrun.c (handle_inferior_event): Rename from
8499         handle_inferior_event_1.  Create a scoped_value_mark.
8500         (handle_inferior_event): Remove.
8501
8502 2019-03-19  Tom Tromey  <tromey@adacore.com>
8503
8504         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8505         * infrun.h (print_stop_event): Add "displays" parameter.
8506         * infrun.c (print_stop_event): Add "displays" parameter.
8507
8508 2019-03-19  Pedro Alves  <palves@redhat.com>
8509
8510         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8511         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8512         to -1.  Fix TABs vs spaces.
8513         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8514         * tui/tui-out.h (tui_ui_out) Add intro comments.
8515         <m_line, m_start_of_line>: In-class initialize, and add describing
8516         comment.
8517
8518 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8519
8520         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8521         variable names.
8522         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8523
8524 2019-03-18  Pedro Alves  <palves@redhat.com>
8525             Eli Zaretskii <eliz@gnu.org>
8526
8527         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8528         m_line and m_start_of_line.
8529
8530 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8531
8532         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8533         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8534         it returns a newline.  This fixes a regression in TU mode, whereby
8535         the next line is output on the same screen line as the user input.
8536
8537 2019-03-18  Tom Tromey  <tromey@adacore.com>
8538
8539         * minsyms.c (minimal_symbol_reader::install): Remove call to
8540         obstack_blank.
8541
8542 2019-03-18  Pedro Alves  <palves@redhat.com>
8543
8544         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8545         New globals.
8546         (apply_style): New, factored out from ...
8547         (apply_ansi_escape): ... this.  Handle reverse video mode.
8548         (tui_set_reverse_mode): New function.
8549         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8550         * tui/tui-winsource.c (tui_show_source_line): Use
8551         tui_set_reverse_mode instead of setting A_STANDOUT.
8552         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8553         New setter methods.
8554
8555 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8556
8557         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8558         Handle tabs.
8559
8560 2019-03-18  Tom Tromey  <tromey@adacore.com>
8561
8562         * ada-lang.c (empty_array): Add "high" parameter.
8563         (ada_evaluate_subexp): Update.
8564
8565 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8566
8567         * unittests/string_view-selftests.c: Define
8568         _initialize_string_view_selftests unconditionally.
8569
8570 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8571
8572         PR gdb/24350
8573         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8574
8575 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8576
8577         PR gdb/24351
8578         * windows-nat.c (display_selector): Fix format specifiers.
8579
8580 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8581
8582         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8583         tui_refill_source_window instead of tui_refresh_win, to update the
8584         current execution line.  This fixes redisplay of the current line
8585         when stepping through the code with "next" or "step".
8586
8587 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8588
8589         * source-cache.c (source_cache::get_source_lines): Call
8590         find_source_lines to initialize s->nlines.  This fixes vertical
8591         scrolling of TUI source window when the DOWN arrow is pressed.
8592
8593 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8594
8595         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8596         linux-thread-db.c (_initialize_thread_db): Likewise.
8597
8598 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8599
8600         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8601         wclrtoeol in tui_show_source_line".  This reverts changes made in
8602         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8603
8604 2019-03-15  Tom Tromey  <tom@tromey.com>
8605
8606         * symtab.h (struct minimal_symbol): Derive from
8607         general_symbol_info.
8608         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8609         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8610         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8611         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8612         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8613         (MSYMBOL_SEARCH_NAME): Update.
8614         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8615         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8616         * minsyms.c (minimal_symbol_reader::record_full): Update.
8617
8618 2019-03-15  Tom Tromey  <tom@tromey.com>
8619
8620         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8621
8622 2019-03-15  Tom Tromey  <tom@tromey.com>
8623
8624         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8625         unique_xmalloc_ptr.
8626         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8627         Update.
8628         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8629         (build_minimal_symbol_hash_tables)
8630         (minimal_symbol_reader::install): Update.
8631
8632 2019-03-15  Tom Tromey  <tom@tromey.com>
8633
8634         * symtab.c (create_demangled_names_hash): Update.
8635         (symbol_set_names): Update.
8636         * objfiles.h (struct objfile_per_bfd_storage)
8637         <demangled_names_hash>: Now an htab_up.
8638         * objfiles.c (objfile_per_bfd_storage): Simplify.
8639
8640 2019-03-15  Tom Tromey  <tom@tromey.com>
8641
8642         * objfiles.h (struct objfile_per_bfd_storage): Declare
8643         destructor.
8644         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8645         New.
8646         (get_objfile_bfd_data): Use new.  Don't initialize
8647         language_of_main.
8648         (free_objfile_per_bfd_storage): Remove.
8649         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8650
8651 2019-03-15  Tom Tromey  <tom@tromey.com>
8652
8653         * symfile.c (reread_symbols): Update.
8654         * objfiles.c (objfile::objfile): Update.
8655         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8656         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8657         comment.
8658         (minimal_symbol_reader::install): Update.
8659         (terminate_minimal_symbol_table): Remove.
8660         * jit.c (jit_object_close_impl): Update.
8661
8662 2019-03-15  Tom Tromey  <tom@tromey.com>
8663
8664         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8665         initializations.
8666
8667 2019-03-15  Tom Tromey  <tom@tromey.com>
8668
8669         * objfiles.h (struct objfile_per_bfd_storage)
8670         <demangled_hash_languages>: Now a bitset.
8671         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8672         (lookup_minimal_symbol): Update.
8673
8674 2019-03-15  Tom Tromey  <tom@tromey.com>
8675
8676         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8677         Don't return the symbol.
8678         * coffread.c (record_minimal_symbol): Use record_full.
8679
8680 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8681
8682         The MS-Windows port of ncurses fails to switch to a color pair if
8683         one or both of the colors are the implicit default colors.  This
8684         change records the default colors when TUI is initialized, and
8685         then specifies them explicitly when a color pair uses the default
8686         colors.  This allows color styling in TUI mode on MS-Windows.
8687
8688         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8689         ncurses_norm_attr.
8690         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8691         colors in ncurses_norm_attr.
8692         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8693         "none", replace it with the default color recorded in
8694         ncurses_norm_attr.
8695
8696 2019-03-14  Tom Tromey  <tromey@adacore.com>
8697
8698         * source-cache.h (class source_cache) <get_source_lines>: Return
8699         std::string.
8700         * source-cache.c (source_cache::extract_lines): Handle case where
8701         first_pos==npos.  Return std::string.
8702         (source_cache::get_source_lines): Update.
8703
8704 2019-03-14  Tom Tromey  <tromey@adacore.com>
8705
8706         * NEWS: Add item for "style sources" commands.
8707         * source-cache.c (source_cache::get_source_lines): Check
8708         source_styling.
8709         * cli/cli-style.c (source_styling): New global.
8710         (_initialize_cli_style): Add "style sources" commands.
8711         (show_style_sources): New function.
8712         * cli/cli-style.h (source_styling): Declare.
8713
8714 2019-03-14  Pedro Alves  <palves@redhat.com>
8715             Tom Tromey  <tromey@adacore.com>
8716
8717         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8718         * tui/tui-winsource.c (tui_refill_source_window): New function,
8719         from...
8720         (tui_horizontal_source_scroll): ... here.  Move some logic.
8721         * cli/cli-style.c (set_style_enabled): Notify new observable.
8722         * tui/tui-hooks.c (tui_redisplay_source): New function.
8723         (tui_attach_detach_observers): Attach or detach
8724         tui_redisplay_source.
8725         * observable.h (source_styling_changed): New observable.
8726         * observable.c: Define source_styling_changed observable.
8727
8728 2019-03-13  Tom Tromey  <tromey@adacore.com>
8729
8730         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8731         (i386_gnu_nat_target::store_registers): Update.
8732         * target-debug.h (target_debug_print_std_string): New macro.
8733         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8734         * windows-tdep.c (display_one_tib): Update.
8735         * tui/tui-stack.c (tui_make_status_line): Update.
8736         * top.c (print_inferior_quit_action): Update.
8737         * thread.c (thr_try_catch_cmd): Update.
8738         (add_thread_with_info): Update.
8739         (thread_target_id_str): Update.
8740         (thr_try_catch_cmd): Update.
8741         (thread_command): Update.
8742         (thread_find_command): Update.
8743         * record-btrace.c (record_btrace_target::info_record)
8744         (record_btrace_resume_thread, record_btrace_target::resume)
8745         (record_btrace_cancel_resume, record_btrace_step_thread)
8746         (record_btrace_target::wait, record_btrace_target::wait)
8747         (record_btrace_target::wait, record_btrace_target::stop): Update.
8748         * progspace.c (print_program_space): Update.
8749         * process-stratum-target.c
8750         (process_stratum_target::thread_address_space): Update.
8751         * linux-fork.c (linux_fork_mourn_inferior)
8752         (detach_checkpoint_command, info_checkpoints_command)
8753         (linux_fork_context): Update.
8754         (linux_fork_detach): Update.
8755         (class scoped_switch_fork_info): Update.
8756         (delete_checkpoint_command): Update.
8757         * infrun.c (follow_fork_inferior): Update.
8758         (follow_fork_inferior): Update.
8759         (proceed_after_vfork_done): Update.
8760         (handle_vfork_child_exec_or_exit): Update.
8761         (follow_exec): Update.
8762         (displaced_step_prepare_throw): Update.
8763         (displaced_step_restore): Update.
8764         (start_step_over): Update.
8765         (resume_1): Update.
8766         (clear_proceed_status_thread): Update.
8767         (proceed): Update.
8768         (print_target_wait_results): Update.
8769         (do_target_wait): Update.
8770         (context_switch): Update.
8771         (stop_all_threads): Update.
8772         (restart_threads): Update.
8773         (finish_step_over): Update.
8774         (handle_signal_stop): Update.
8775         (switch_back_to_stepped_thread): Update.
8776         (keep_going_pass_signal): Update.
8777         (print_exited_reason): Update.
8778         (normal_stop): Update.
8779         * inferior.c (inferior_pid_to_str): Change return type.
8780         (print_selected_inferior): Update.
8781         (add_inferior): Update.
8782         (detach_inferior): Update.
8783         * dummy-frame.c (fprint_dummy_frames): Update.
8784         * dcache.c (dcache_info_1): Update.
8785         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8786         (btrace_fetch, btrace_clear): Update.
8787         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8788         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8789         type.
8790         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8791         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8792         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8793         * gdbarch.c, gdbarch.h: Rebuild.
8794         * gdbarch.sh (core_pid_to_str): Change return type.
8795         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8796         return type.
8797         (windows_nat_target::pid_to_str): Change return type.
8798         (windows_delete_thread): Update.
8799         (windows_nat_target::attach): Update.
8800         (windows_nat_target::files_info): Update.
8801         * target-delegates.c: Rebuild.
8802         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8803         return type.
8804         (sol_thread_target::pid_to_str): Change return type.
8805         * remote.c (class remote_target) <pid_to_str>: Change return
8806         type.
8807         (remote_target::pid_to_str): Change return type.
8808         (extended_remote_target::attach, remote_target::remote_stop_ns)
8809         (remote_target::remote_notif_remove_queued_reply)
8810         (remote_target::push_stop_reply, remote_target::disable_btrace):
8811         Update.
8812         (extended_remote_target::attach): Update.
8813         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8814         type.
8815         (gdbsim_target::pid_to_str): Change return type.
8816         * ravenscar-thread.c (struct ravenscar_thread_target)
8817         <pid_to_str>: Change return type.
8818         (ravenscar_thread_target::pid_to_str): Change return type.
8819         * procfs.c (class procfs_target) <pid_to_str>: Change return
8820         type.
8821         (procfs_target::pid_to_str): Change return type.
8822         (procfs_target::attach): Update.
8823         (procfs_target::detach): Update.
8824         (procfs_target::fetch_registers): Update.
8825         (procfs_target::store_registers): Update.
8826         (procfs_target::wait): Update.
8827         (procfs_target::files_info): Update.
8828         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8829         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8830         return type.
8831         (nto_procfs_target::pid_to_str): Change return type.
8832         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8833         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8834         return type.
8835         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8836         (exit_lwp): Update.
8837         (attach_proc_task_lwp_callback, get_detach_signal)
8838         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8839         (linux_nat_target::resume, wait_lwp, stop_callback)
8840         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8841         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8842         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8843         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8844         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8845         type.
8846         (inf_ptrace_target::attach): Update.
8847         (inf_ptrace_target::files_info): Update.
8848         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8849         type.
8850         (go32_nat_target::pid_to_str): Change return type.
8851         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8852         (gnu_nat_target::wait): Update.
8853         (gnu_nat_target::wait): Update.
8854         (gnu_nat_target::resume): Update.
8855         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8856         (fbsd_nat_target::wait): Update.
8857         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8858         type.
8859         (darwin_nat_target::attach): Update.
8860         * corelow.c (class core_target) <pid_to_str>: Change return type.
8861         (core_target::pid_to_str): Change return type.
8862         * target.c (normal_pid_to_str): Change return type.
8863         (default_pid_to_str): Likewise.
8864         (target_pid_to_str): Change return type.
8865         (target_translate_tls_address): Update.
8866         (target_announce_detach): Update.
8867         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8868         return type.
8869         (bsd_uthread_target::pid_to_str): Change return type.
8870         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8871         type.
8872         (bsd_kvm_target::pid_to_str): Change return type.
8873         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8874         return type.
8875         (aix_thread_target::pid_to_str): Change return type.
8876         * target.h (struct target_ops) <pid_to_str>: Change return type.
8877         (target_pid_to_str, normal_pid_to_str): Likewise.
8878         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8879         type.
8880         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8881         type.
8882         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8883         return type.
8884         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8885         type.
8886         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8887         type.
8888         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8889         return type.
8890
8891 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8892
8893         * NEWS: Mention that the new default MI version is 3.  Mention
8894         changes to the output of commands and events that deal with
8895         multi-location breakpoints.
8896         * breakpoint.c: Include "mi/mi-out.h".
8897         (print_one_breakpoint): Change output syntax if using MI version
8898         >= 3.
8899         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8900         New.
8901         (mi_multi_location_breakpoint_output_fixed): New.
8902         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8903         (mi_cmd_fix_multi_location_breakpoint_output): New.
8904         (mi_multi_location_breakpoint_output_fixed): New.
8905         * mi/mi-cmds.c (mi_cmds): Register command
8906         -fix-multi-location-breakpoint-output.
8907         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8908         interpreter "mi".
8909
8910 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8911
8912         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8913         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8914         instantiate mi_ui_out based on interpreter name.
8915         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8916         * mi/mi-main.c (mi_load_progress): Likewise.
8917
8918 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8919
8920         * NEWS: Combine separate "New targets" sections for 8.3.
8921
8922 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8923
8924         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8925         (ppcfbsd_init_abi): Install gdbarch
8926         "fetch_tls_load_module_address" and "get_thread_local_address"
8927         methods.
8928
8929 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8930
8931         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8932         (riscv_fbsd_init_abi): Install gdbarch
8933         "fetch_tls_load_module_address" and "get_thread_local_address"
8934         methods.
8935
8936 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8937
8938         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8939         (i386fbsd_init_abi): Install gdbarch
8940         "fetch_tls_load_module_address" and "get_thread_local_address"
8941         methods.
8942
8943 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8944
8945         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8946         (amd64fbsd_init_abi): Install gdbarch
8947         "fetch_tls_load_module_address" and "get_thread_local_address"
8948         methods.
8949
8950 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8951
8952         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8953         (struct fbsd_pspace_data): New type.
8954         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8955         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8956         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8957         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8958         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8959
8960 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8961
8962         * gdbtypes.c (lookup_struct_elt): New function.
8963         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8964         * gdbtypes.h (struct struct_elt): New type.
8965         (lookup_struct_elt): New prototype.
8966
8967 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8968
8969         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8970         remove disabled code block.
8971
8972 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8973
8974         * gdbarch.sh (get_thread_local_address): New method.
8975         * gdbarch.h, gdbarch.c: Regenerate.
8976         * target.c (target_translate_tls_address): Use
8977         gdbarch_get_thread_local_address if present instead of
8978         target::get_thread_local_address.
8979
8980 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8981
8982         * target.h (target::get_thread_local_address): Update comment.
8983
8984 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8985
8986         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8987         objfile->separate_debug_objfile_backlink if not NULL.
8988
8989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8990
8991         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8992         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8993         (amd64bsd_store_inferior_registers): Likewise.
8994         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8995         Enable segment base registers.
8996         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8997         PT_GETFSBASE and PT_GETGSBASE.
8998         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8999         PT_SETGSBASE.
9000         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9001         segment base registers.
9002         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9003
9004 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9005
9006         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9007         Update calls to i386_target_description to add 'segments'
9008         parameter.
9009         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9010         add segment base registers.
9011         * arch/i386.c (i386_create_target_description): Add 'segments'
9012         parameter to enable segment base registers.
9013         * arch/i386.h (i386_create_target_description): Likewise.
9014         * features/i386/32bit-segments.xml: New file.
9015         * features/i386/32bit-segments.c: Generate.
9016         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9017         call to i386_target_description to add 'segments' parameter.
9018         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9019         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9020         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9021         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9022         if feature is present.
9023         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9024         Add 'segments' parameter to call to i386_target_description.
9025         (i386_target_description): Add 'segments' parameter to enable
9026         segment base registers.
9027         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9028         to call to i386_target_description.
9029         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9030         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9031         Define I386_NUM_REGS.
9032         (i386_target_description): Add 'segments' parameter to enable
9033         segment base registers.
9034
9035 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9036
9037         PR/24325
9038         * source-cache.c: #undef open and close, to avoid unresolved
9039         externals during linking.
9040
9041 2019-03-12  Tom Tromey  <tromey@adacore.com>
9042
9043         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9044         const.  Add initializers.
9045         (_initialize_remote): Don't initialize ptid globals.
9046
9047 2019-03-12  Pedro Alves  <palves@redhat.com>
9048
9049         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9050
9051 2019-03-12  Pedro Alves  <palves@redhat.com>
9052
9053         * cp-name-parser.y (main): Remove unused 'len' variable.
9054
9055 2019-03-12  Tom Tromey  <tromey@adacore.com>
9056
9057         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9058         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9059
9060 2019-03-12  Tom Tromey  <tromey@adacore.com>
9061
9062         * linux-nat.c (iterate_over_lwps): Update.
9063         (stop_callback): Remove parameter.
9064         (stop_wait_callback, detach_callback, resume_set_callback)
9065         (select_singlestep_lwp_callback, set_ignore_sigint)
9066         (status_callback, resumed_callback, resume_clear_callback)
9067         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9068         data parameter.
9069         (linux_nat_target::detach, linux_nat_target::resume)
9070         (linux_stop_and_wait_all_lwps, select_event_lwp)
9071         (linux_nat_filter_event, linux_nat_wait_1)
9072         (linux_nat_target::kill, linux_nat_target::stop)
9073         (linux_nat_target::stop): Update.
9074         (linux_nat_resume_callback): Change type.
9075         (resume_stopped_resumed_lwps, count_events_callback)
9076         (select_event_lwp_callback): Likewise.
9077         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9078         * arm-linux-nat.c (struct update_registers_data): Remove.
9079         (update_registers_callback): Change type.
9080         (arm_linux_insert_hw_breakpoint1): Update.
9081         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9082         parameter.
9083         (x86_linux_dr_set_addr): Update.
9084         (x86_linux_dr_set_control): Update.
9085         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9086         (iterate_over_lwps): Use gdb::function_view.
9087         * nat/aarch64-linux-hw-point.c (struct
9088         aarch64_dr_update_callback_param): Remove.
9089         (debug_reg_change_callback): Change type.
9090         (aarch64_notify_debug_reg_change): Update.
9091         * s390-linux-nat.c (s390_refresh_per_info): Update.
9092
9093 2019-03-11  Tom Tromey  <tromey@adacore.com>
9094
9095         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9096         redundant assignment to "this_cu".
9097
9098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9099
9100         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9101
9102 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9103
9104         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9105         from...
9106         (rank_one_type): ... this.
9107
9108 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9109
9110         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9111         from...
9112         (rank_one_type): ... this.
9113
9114 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9115
9116         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9117         from...
9118         (rank_one_type): ... this.
9119
9120 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9121
9122         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9123         from...
9124         (rank_one_type): ... this.
9125
9126 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9127
9128         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9129         from...
9130         (rank_one_type): ... this.
9131
9132 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9133
9134         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9135         from...
9136         (rank_one_type): ... this.
9137
9138 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9139
9140         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9141         from...
9142         (rank_one_type): ... this.
9143
9144 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9145
9146         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9147         from...
9148         (rank_one_type): ... this.
9149
9150 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9151
9152         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9153         from...
9154         (rank_one_type): ... this.
9155
9156 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9157
9158         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9159         from...
9160         (rank_one_type): ... this.
9161
9162 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9163
9164         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9165         from...
9166         (rank_one_type): ... this.
9167
9168 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9169
9170         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9171         from...
9172         (rank_one_type): ... this.
9173
9174 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9175
9176         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9177         inferior-events' shows the example events.
9178
9179 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9180
9181         Support styling on native MS-Windows console
9182
9183         PR/24315
9184         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9185         on MS-Windows if $TERM is not defined.
9186
9187         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9188
9189         * posix-hdep.c (gdb_console_fputs):
9190         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9191         functions.
9192         * ui-file.h (gdb_console_fputs): Add prototype.
9193
9194         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9195         back to fputs only if the former returns zero.
9196
9197 2019-03-07  Tom Tromey  <tom@tromey.com>
9198
9199         * symmisc.c (print_symbol_bcache_statistics): Update.
9200         (print_objfile_statistics): Update.
9201         * symfile.c (allocate_symtab): Update.
9202         * stabsread.c: Don't include bcache.h.
9203         * psymtab.h (struct psymbol_bcache): Don't declare.
9204         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9205         (psymbol_bcache_init, psymbol_bcache_free)
9206         (psymbol_bcache_get_bcache): Don't declare.
9207         * psymtab.c (struct psymbol_bcache): Remove.
9208         (psymtab_storage::psymtab_storage): Update.
9209         (psymtab_storage::~psymtab_storage): Update.
9210         (psymbol_bcache_init, psymbol_bcache_free)
9211         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9212         (add_psymbol_to_bcache): Update.
9213         (allocate_psymtab): Update.
9214         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9215         macro_cache>: No longer pointers.
9216         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9217         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9218         * macrotab.c (macro_bcache): Update.
9219         * macroexp.c: Don't include bcache.h.
9220         * gdbtypes.c (check_types_worklist): Update.
9221         (types_deeply_equal): Remove TRY/CATCH.  Update.
9222         * elfread.c (elf_symtab_read): Update.
9223         * dwarf2read.c: Don't include bcache.h.
9224         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9225         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9226         (print_bcache_statistics, bcache_memory_used): Don't declare.
9227         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9228         methods.  Rename all data members.
9229         * bcache.c (struct bcache): Move to bcache.h.
9230         (bcache::expand_hash_table): Rename from expand_hash_table.
9231         (bcache): Remove.
9232         (bcache::insert): Rename from bcache_full.
9233         (bcache::compare): Rename from bcache_compare.
9234         (bcache_xmalloc): Remove.
9235         (bcache::~bcache): Rename from bcache_xfree.
9236         (bcache::print_statistics): Rename from print_bcache_statistics.
9237         (bcache::memory_used): Rename from bcache_memory_used.
9238
9239 2019-03-07  Pedro Alves  <palves@redhat.com>
9240
9241         * infrun.c (normal_stop): Also check for
9242         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9243
9244 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9245
9246         * f-lang.c (value_from_host_double): Moved to...
9247         * value.c (value_from_host_double): ...here.
9248         * value.h (value_from_host_double): Declare.
9249         * guile/scm-math.c (vlscm_convert_typed_number): Use
9250         value_from_host_double.
9251         (vlscm_convert_number): Likewise.
9252         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9253         * python/py-value.c (convert_value_from_python): Likewise.
9254
9255 2019-03-06  Tom Tromey  <tom@tromey.com>
9256
9257         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9258
9259 2019-03-06  Tom Tromey  <tom@tromey.com>
9260
9261         * utils.h (free_current_contents): Don't declare.
9262         * utils.c (free_current_contents): Remove.
9263
9264 2019-03-06  Tom Tromey  <tom@tromey.com>
9265
9266         * top.c (quit_force): Update.
9267         * main.c (captured_command_loop): Update.
9268         * common/new-op.c (operator new): Update.
9269         * common/common-exceptions.c (struct catcher)
9270         <save_cleanup_chain>: Remove member.
9271         (exceptions_state_mc_init): Update.
9272         (exception_try_scope_entry): Return nullptr.
9273         (exception_try_scope_exit, exception_rethrow)
9274         (throw_exception_sjlj, throw_exception_cxx): Update.
9275         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9276         (all_cleanups, do_cleanups, discard_cleanups)
9277         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9278         (restore_cleanups, restore_final_cleanups): Don't declare.
9279         (do_final_cleanups): Remove parameter.
9280         * common/cleanups.c (cleanup_chain, make_cleanup)
9281         (make_cleanup_dtor, all_cleanups, do_cleanups)
9282         (discard_my_cleanups, discard_cleanups)
9283         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9284         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9285         (null_cleanup): Remove.
9286         (do_final_cleanups): Remove parameter.
9287
9288 2019-03-06  Tom Tromey  <tom@tromey.com>
9289
9290         * remote.c (remote_target::remote_parse_stop_reply): Use
9291         unique_xmalloc_ptr.
9292
9293 2019-03-06  Tom Tromey  <tom@tromey.com>
9294
9295         * stabsread.c (struct stabs_field_info): Rename from field_info.
9296         <list, fnlist>: Add initializers.
9297         <obstack>: New member.
9298         (read_member_functions, read_struct_fields, read_baseclasses):
9299         Allocate on obstack.  Don't use cleanups.
9300         (read_one_struct_field, read_member_functions, read_struct_fields)
9301         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9302         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9303         (read_struct_type): Update.
9304
9305 2019-03-06  Tom Tromey  <tom@tromey.com>
9306
9307         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9308         * common/filestuff.h (make_cleanup_close): Don't declare.
9309         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9310         Remove.
9311
9312 2019-03-06  Tom Tromey  <tom@tromey.com>
9313
9314         * solib-aix.c: Use make_scope_exit.
9315
9316 2019-03-06  Tom Tromey  <tom@tromey.com>
9317
9318         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9319         Use make_scope_exit.
9320
9321 2019-03-06  Tom Tromey  <tom@tromey.com>
9322
9323         * solib-svr4.c (disable_probes_interface): Remove parameter.
9324         (svr4_handle_solib_event): Use make_scope_exit.
9325
9326 2019-03-06  Tom Tromey  <tom@tromey.com>
9327
9328         * remote.c (struct stop_reply_deleter): Remove.
9329         (stop_reply_up): Update.
9330         (struct stop_reply): Derive from notif_event.  Don't typedef.
9331         <regcache>: Now a std::vector.
9332         (stop_reply_xfree): Remove.
9333         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9334         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9335         (remote_target::discard_pending_stop_replies): Use delete.
9336         (remote_target::remote_parse_stop_reply): Update.
9337         (remote_target::process_stop_reply): Update.
9338         * remote-notif.h (struct notif_event): Add virtual destructor.
9339         Remove "dtr" member.
9340         (struct notif_client) <alloc_event>: Return a unique_ptr.
9341         (notif_event_xfree): Don't declare.
9342         (notif_event_up): New typedef.
9343         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9344         (notif_event_xfree, do_notif_event_xfree): Remove.
9345         (remote_notif_state_xfree): Update.
9346
9347 2019-03-06  Tom Tromey  <tom@tromey.com>
9348
9349         * infrun.c (displaced_step_clear_cleanup): Now a
9350         forward_scope_exit type.
9351         (displaced_step_prepare_throw): Update.
9352         (displaced_step_fixup): Update.
9353
9354 2019-03-06  Tom Tromey  <tom@tromey.com>
9355
9356         * inferior.h (class inferior): Update comment.
9357         * gdbthread.h (class thread_info): Update comment.
9358
9359 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9360             Tom Tromey  <tom@tromey.com>
9361
9362         * stabsread.h (struct stab_section_list): Remove.
9363         (coffstab_build_psymtabs): Update.
9364         * dbxread.c (symbuf_sections): Now a std::vector.
9365         (sect_idx): New global.
9366         (fill_symbuf): Update.
9367         (coffstab_build_psymtabs): Change type of stabsects parameter.
9368         Update.
9369         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9370         std::vector.
9371         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9372         (coff_locate_sections): Update.
9373         (coff_symfile_read): Remove cleanups.  Update.
9374         (init_stringtab): Add storage parameter.
9375         (free_stringtab, free_stringtab_cleanup): Remove.
9376         (init_lineno): Add storage parameter.
9377         (free_linetab, free_linetab_cleanup): Remove.
9378
9379 2019-03-06  Pedro Alves  <palves@redhat.com>
9380
9381         * linux-fork.c (fork_info::clobber_regs): Delete.
9382         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9383         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9384         comment.  Adjust.
9385         (scoped_switch_fork_info::scoped_switch_fork_info)
9386         (checkpoint_command, linux_fork_context): Adjust
9387         fork_save_infrun_state calls.
9388
9389 2019-03-06  Pedro Alves  <palves@redhat.com>
9390
9391         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9392         (inf_has_multiple_threads): Return 'bool' and rewrite using
9393         inferior_info::threads().
9394
9395 2019-03-06  Pedro Alves  <palves@redhat.com>
9396
9397         * linux-fork.c: Include <list>.
9398         (fork_list): Now a std::list instance.
9399         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9400         (forks_exist_p, find_last_fork): Adjust.
9401         (new_fork): Delete.
9402         (one_fork_p): New.
9403         (add_fork): Adjust.
9404         (free_fork): Delete, folded into fork_info::~fork_info().
9405         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9406         Adjust.
9407         (init_fork_list): Delete.
9408         (linux_fork_killall, linux_fork_mourn_inferior)
9409         (linux_fork_detach, info_checkpoints_command): Adjust.
9410         (_initialize_linux_fork): No longer call init_fork_list.
9411
9412 2019-03-06  Pedro Alves  <palves@redhat.com>
9413
9414         * linux-fork.c (new_fork): New, split out of ...
9415         (add_fork): ... this.  Return void.  Move "first fork" special
9416         case from here, to ...
9417         (checkpoint_command): ... here.
9418         * linux-linux.h (add_fork): Return void.
9419
9420 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9421
9422         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9423
9424 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9425             Chris January  <chris.january@arm.com>
9426             David Lecomber  <david.lecomber@arm.com>
9427
9428         * f-exp.y: New token, UNOP_INTRINSIC.
9429         (exp): New pattern using UNOP_INTRINSIC token.
9430         (f77_keywords): Add 'abs' keyword.
9431         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9432         (value_from_host_double): New function.
9433         (evaluate_subexp_f): Support UNOP_ABS.
9434
9435 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9436
9437         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9438         types.
9439
9440 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9441
9442         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9443         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9444         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9445
9446 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9447
9448         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9449
9450 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9451             Chris January  <chris.january@arm.com>
9452
9453         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9454         * f-exp.y: Define 'KIND' token.
9455         (exp): New pattern for KIND expressions.
9456         (ptype): Handle types with a kind extension.
9457         (direct_abs_decl): Extend to spot kind extensions.
9458         (f77_keywords): Add 'kind' to the list.
9459         (push_kind_type): New function.
9460         (convert_to_kind_type): New function.
9461         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9462         * parse.c (operator_length_standard): Likewise.
9463         * parser-defs.h (enum type_pieces): Add tp_kind.
9464         * std-operator.def: Add UNOP_KIND.
9465
9466 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9467
9468         * f-exp.y (f_parse): Set yydebug.
9469
9470 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9471
9472         * f-lang.c (evaluate_subexp_f): New function.
9473         (exp_descriptor_f): New global.
9474         (f_language_defn): Use exp_descriptor_f instead of
9475         exp_descriptor_standard.
9476
9477 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9478
9479         * f-exp.y (struct token): Add comments.
9480         (dot_ops): Remove uppercase versions and the end marker.
9481         (f77_keywords): Likewise.
9482         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9483         entries in the dot_ops array are case insensitive, and use
9484         strncasecmp to compare strings.  Also some whitespace cleanup in
9485         this area.  Similar for the f77_keywords array, except entries in
9486         this list might be case sensitive.
9487
9488 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9489
9490         * f-exp.y (struct f77_boolean_val): Add comments.
9491         (boolean_values): Remove uppercase versions, and end marker.
9492         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9493         and use strncasecmp to achieve case insensitivity.  Additionally,
9494         perform whitespace cleanup around this code.
9495
9496 2019-03-06  Tom Tromey  <tromey@adacore.com>
9497
9498         * remote-sim.c (gdbsim_target_open): Use result of
9499         gdb_argv::release.
9500
9501 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9502         Dirk Schubert  <dirk.schubert@arm.com>
9503         Chris January  <chris.january@arm.com>
9504
9505         * eval.c (evaluate_subexp_standard): Call Fortran argument
9506         wrapping logic.
9507         * f-lang.c (struct value): A value which can be passed into a
9508         Fortran function call.
9509         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9510         where appropriate.
9511         (struct type): Value ready for a Fortran function call.
9512         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9513         is needed.
9514         * f-lang.h (fortran_argument_convert): Declaration.
9515         (fortran_preserve_arg_pointer): Declaration.
9516         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9517
9518 2019-03-05  Tom Tromey  <tromey@adacore.com>
9519
9520         * python/py-prettyprint.c (print_string_repr): Remove #if.
9521         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9522
9523 2019-03-05  Tom Tromey  <tromey@adacore.com>
9524
9525         * target.c (the_dummy_target): Move later.  Change type to
9526         "dummy_target".
9527         (initialize_targets): Don't initialize the_dummy_target.
9528
9529 2019-03-05  Tom Tromey  <tromey@adacore.com>
9530
9531         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9532         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9533
9534 2019-03-05  Tom Tromey  <tromey@adacore.com>
9535
9536         * windows-nat.c (windows_nat_target::attach)
9537         (windows_nat_target::detach): Don't call gdb_flush.
9538         * valprint.c (generic_val_print, val_print, val_print_string):
9539         Don't call gdb_flush.
9540         * utils.c (defaulted_query): Don't call gdb_flush.
9541         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9542         * target.c (target_announce_detach): Don't call gdb_flush.
9543         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9544         * remote.c (extended_remote_target::attach): Don't call
9545         gdb_flush.
9546         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9547         * printcmd.c (do_examine): Don't call gdb_flush.
9548         (info_display_command): Don't call gdb_flush.
9549         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9550         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9551         * memattr.c (info_mem_command): Don't call gdb_flush.
9552         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9553         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9554         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9555         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9556         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9557         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9558         (gnu_nat_target::detach): Don't call gdb_flush.
9559         * f-valprint.c (f_val_print): Don't call gdb_flush.
9560         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9561         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9562         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9563         gdb_flush.
9564         * c-valprint.c (c_val_print): Don't call gdb_flush.
9565         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9566
9567 2019-03-05  Tom Tromey  <tromey@adacore.com>
9568
9569         * varobj.c (update_dynamic_varobj_children): Update.
9570         (install_default_visualizer): Use reset, not release.
9571         * value.c (set_internalvar): Update.
9572         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9573         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9574         ATTRIBUTE_UNUSED_RESULT.
9575
9576 2019-03-05  Tom Tromey  <tromey@adacore.com>
9577
9578         * remote.c (class scoped_remote_fd) <release>: Add
9579         ATTRIBUTE_UNUSED_RESULT.
9580
9581 2019-03-05  Tom Tromey  <tromey@adacore.com>
9582
9583         * macroexp.c (struct macro_buffer) <release>: Add
9584         ATTRIBUTE_UNUSED_RESULT.
9585
9586 2019-03-05  Tom Tromey  <tromey@adacore.com>
9587
9588         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9589         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9590         ATTRIBUTE_UNUSED_RESULT.
9591
9592 2019-03-05  Tom Tromey  <tromey@adacore.com>
9593
9594         * common/scoped_fd.h (class scoped_fd) <release>: Add
9595         ATTRIBUTE_UNUSED_RESULT.
9596
9597 2019-03-05  Tom Tromey  <tromey@adacore.com>
9598
9599         * parser-defs.h (struct parser_state) <release>: Add
9600         ATTRIBUTE_UNUSED_RESULT.
9601
9602 2019-03-05  Tom Tromey  <tromey@adacore.com>
9603
9604         * utils.h (class gdb_argv) <release>: Add
9605         ATTRIBUTE_UNUSED_RESULT.
9606         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9607
9608 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9609
9610         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9611         for-loop range, to avoid compiler warnings.
9612
9613         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9614         avoid compiler warnings about unused variables.
9615
9616         * NEWS: Mention end of support for native debugging on MS-Windows
9617         before XP.
9618
9619         PR gdb/24292
9620         * common/netstuff.c:
9621         * gdbserver/gdbreplay.c
9622         * gdbserver/remote-utils.c:
9623         * ser-tcp.c:
9624         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9625         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9626         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9627         'getaddrinfo' and 'freeaddrinfo' were not available before
9628         Windows XP, and mingw.org's MinGW headers by default define
9629         _WIN32_WINNT to 0x500.
9630
9631 2019-03-01  Gary Benson <gbenson@redhat.com>
9632
9633         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9634
9635 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9636             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9637
9638         PR gdb/8527
9639         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9640         set_sigint_trap, clear_sigint_trap.
9641
9642 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9643
9644         * target.c (target_detach): Clear the regcache and the
9645         frame cache.
9646
9647 2019-02-27  Pedro Alves  <palves@redhat.com>
9648
9649         * utils.c (set_screen_size): When we cap the height/width sizes,
9650         tweak the corresponding command variable to show "unlimited":
9651
9652 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9653             Pedro Alves  <palves@redhat.com>
9654
9655         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9656         before calling rl_set_screen_size.
9657
9658 2019-02-27  Tom Tromey  <tromey@adacore.com>
9659
9660         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9661         define.
9662         * python/py-value.c: Remove Python 2.4 workaround.
9663         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9664         workaround.
9665         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9666         Python 2.4 workaround.
9667         * python/python-internal.h: Remove Python 2.4 comment.
9668         (Py_ssize_t): Don't define.
9669         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9670         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9671         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9672         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9673         * python/python.c (do_start_initialization): Remove Python 2.4
9674         workaround.
9675         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9676         (print_children): Remove Python 2.4 workaround.
9677         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9678         workaround.
9679         (CHARBUFFERPROC_NAME): Remove.
9680         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9681         Python 2.4 workaround.
9682
9683 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9684
9685         * NEWS: Note minimum Python version.
9686
9687 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9688
9689         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9690         code from these functions.  Remove corresponding ifdefs.  Use
9691         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9692         Remove gotos and target of gotos.
9693         (infpy_search_memory): Likewise.
9694
9695 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9696
9697         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9698         (hppa_gdbarch_init): Don't register deleted functions with
9699         gdbarch.
9700
9701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9702
9703         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9704         (h8300_unwind_sp): Delete.
9705         (h8300_dummy_id): Delete.
9706         (h8300_gdbarch_init): Don't register deleted functions with
9707         gdbarch.
9708
9709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9710
9711         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9712         (ft32_unwind_pc): Delete.
9713         (ft32_unwind_sp): Delete.
9714         (ft32_gdbarch_init): Don't register deleted functions with
9715         gdbarch.
9716
9717 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9718
9719         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9720         (frv_unwind_pc): Delete.
9721         (frv_unwind_sp): Delete.
9722         (frv_gdbarch_init): Don't register deleted functions with
9723         gdbarch.
9724
9725 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9726
9727         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9728         (riscv_unwind_pc): Delete.
9729         (riscv_unwind_sp): Delete.
9730         (riscv_gdbarch_init): Don't register deleted functions with
9731         gdbarch.
9732
9733 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9734
9735         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9736         (csky_unwind_pc): Delete.
9737         (csky_unwind_sp): Delete.
9738         (csky_gdbarch_init): Don't register deleted functions with
9739         gdbarch.
9740
9741 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9742
9743         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9744         (cris_unwind_pc): Delete.
9745         (cris_unwind_sp): Delete.
9746         (cris_gdbarch_init): Don't register deleted functions with
9747         gdbarch.
9748
9749 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9750
9751         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9752         (bfin_unwind_pc): Delete.
9753         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9754
9755 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9756
9757         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9758         (arm_unwind_pc): Delete.
9759         (arm_unwind_sp): Delete.
9760         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9761
9762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9763
9764         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9765         (arc_unwind_pc): Delete.
9766         (arc_unwind_sp): Delete.
9767         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9768
9769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9770
9771         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9772         (alpha_unwind_pc): Delete.
9773         (alpha_gdbarch_init): Don't register deleted functions with
9774         gdbarch.
9775
9776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9777
9778         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9779         (aarch64_unwind_pc): Delete.
9780         (aarch64_unwind_sp): Delete.
9781         (aarch64_gdbarch_init): Don't register deleted functions with
9782         gdbarch.
9783
9784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9785
9786         * gdbtypes.c (type_align): Don't consider static members when
9787         computing structure alignment.
9788
9789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9790
9791         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9792         return 0 for other types.
9793         * arch-utils.c (default_type_align): Always return 0.
9794         * gdbarch.h: Regenerate.
9795         * gdbarch.sh (type_align): Extend comment.
9796         * gdbtypes.c (type_align): Add additional comments, always call
9797         gdbarch_type_align before applying the default rules.
9798         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9799         generic code will then apply a suitable default.
9800         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9801         types, return 0 for other types.
9802
9803 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9804
9805         * NEWS: Create a new section for the next release branch.
9806         Rename the section of the current branch, now that it has
9807         been cut.
9808
9809 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9810
9811         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9812         * version.in: Bump version to 8.3.50.DATE-git.
9813
9814 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9815
9816         * aix-thread.c (ptid_cmp): Remove unused variable.
9817         (get_signaled_thread): Likewise.
9818         (store_regs_user_thread): Likewise.
9819         (store_regs_kernel_thread): Likewise.
9820         (fetch_regs_kernel_thread): Remove shadowed variable.
9821
9822 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9823
9824         * features/riscv/32bit-cpu.xml: Add register numbers.
9825         * features/riscv/32bit-fpu.c: Regenerate.
9826         * features/riscv/32bit-fpu.xml: Add register numbers.
9827         * features/riscv/64bit-cpu.xml: Add register numbers.
9828         * features/riscv/64bit-fpu.c: Regenerate.
9829         * features/riscv/64bit-fpu.xml: Add register numbers.
9830
9831 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9832
9833         * NEWS: Mention two argument form of gdb.Value constructor.
9834         * python/py-value.c (convert_buffer_and_type_to_value): New
9835         function.
9836         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9837         Add support for handling an optional second argument.  Call
9838         convert_buffer_and_type_to_value as appropriate.
9839         * python/python-internal.h (Py_buffer_deleter): New struct.
9840         (Py_buffer_up): New typedef.
9841
9842 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9843
9844         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9845         instead of releasing ownership.
9846
9847 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9848
9849         * dwarf2read.c (open_and_init_dwp_file): Call
9850         elf_numsections instead of bfd_count_sections to initialize
9851         dwp_file->num_sections.
9852
9853 2019-02-25  Tom Tromey  <tromey@adacore.com>
9854
9855         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9856
9857 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9858
9859         * gcore.in: Add '--readnever' option when invoking GDB.
9860
9861 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9862
9863         * MAINTAINERS: Update my email address.
9864
9865 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9866
9867         * build-id.c (build_id_to_debug_bfd_1): New function.
9868         (build_id_to_debug_bfd): Look for separate debug file in
9869         sysroot.
9870
9871 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9872
9873         * gdbarch.sh: Update the copyright year range that is placed into
9874         generated files.
9875
9876 2019-02-22  Keith Seitz  <keiths@redhat.com>
9877
9878         PR symtab/23853
9879         * linespec.c (create_sals_line_offset): Search for the default
9880         symtab's filename instead of its fullname.
9881
9882 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9883
9884         * NEWS: Update style defaults.
9885
9886 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9887
9888         * main.c (captured_main_1): Disable styling in batch mode.
9889
9890 2019-02-20  Tom Tromey  <tom@tromey.com>
9891
9892         * symtab.c (symtab_symbol_info): Fix typos.
9893
9894 2019-02-20  Tom Tromey  <tromey@adacore.com>
9895
9896         * findcmd.c (_initialize_mem_search): Use upper case for
9897         metasyntactic variables.
9898
9899 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9900
9901         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9902         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9903
9904 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9905
9906         * top.h (source_file_name): Change to std::string.
9907         * top.c (source_file_name): Likewise.
9908         (command_line_input): Adjust.
9909         * cli/cli-script.c (script_from_file): Adjust.
9910
9911 2019-02-19  Tom Tromey  <tromey@adacore.com>
9912
9913         * ravenscar-thread.c
9914         (ravenscar_thread_target::update_thread_list): Don't call
9915         ada_build_task_list.
9916         * ada-lang.h (ada_build_task_list): Don't declare.
9917         * ada-tasks.c (struct ada_tasks_inferior_data)
9918         <task_list_valid_p>: Now bool.
9919         (read_known_tasks, ada_task_list_changed)
9920         (ada_tasks_invalidate_inferior_data): Update.
9921         (read_known_tasks_array): Return bool.
9922         (read_known_tasks_list): Likewise.
9923         (read_known_tasks): Return void.
9924         (ada_build_task_list): Now static.
9925
9926 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9927
9928         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9929         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9930
9931 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9932
9933         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9934         variant for ada_tasks_pspace_data_handle and
9935         ada_tasks_inferior_data_handle.
9936         (ada_tasks_pspace_data_cleanup): New function.
9937         (ada_tasks_inferior_data_cleanup): New function.
9938
9939 2019-02-17  Tom Tromey  <tom@tromey.com>
9940
9941         * macrotab.h (macro_source_fullname): Return a std::string.
9942         * macrotab.c (macro_include, check_for_redefinition)
9943         (macro_undef, macro_lookup_definition, foreach_macro)
9944         (foreach_macro_in_scope): Update.
9945         (macro_source_fullname): Return a std::string.
9946         * macrocmd.c (show_pp_source_pos): Update.
9947
9948 2019-02-17  Tom Tromey  <tom@tromey.com>
9949
9950         * macrocmd.c (show_pp_source_pos): Style the file names.
9951
9952 2019-02-17  Tom Tromey  <tom@tromey.com>
9953
9954         PR tui/24197:
9955         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9956
9957 2019-02-17  Tom Tromey  <tom@tromey.com>
9958
9959         * ada-lang.c (user_select_syms): Use filtered printing.
9960         * utils.c (wrap_style): New global.
9961         (desired_style): Remove.
9962         (emit_style_escape): Add stream parameter.
9963         (set_output_style, reset_terminal_style, prompt_for_continue):
9964         Update.
9965         (flush_wrap_buffer): Only flush gdb_stdout.
9966         (wrap_here): Set wrap_style.
9967         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9968         treat escape sequences as a character.  Change when wrap buffer is
9969         flushed.
9970         (fputs_styled): Do not set the output style when the default is
9971         requested.
9972         * ui-style.h (struct ui_file_style) <is_default>: New method.
9973         * source.c (print_source_lines_base): Emit escape sequences in one
9974         piece.
9975
9976 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9977
9978         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9979         integers and enumeration types.
9980
9981 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9982
9983         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9984         instead of lookup_symbol_in_language
9985         (do_exact_match): New function.
9986         (ada_get_symbol_name_matcher): Return do_exact_match when
9987         doing a verbatim match.
9988
9989 2019-02-15  Tom Tromey  <tromey@adacore.com>
9990
9991         * ravenscar-thread.c (ravenscar_thread_target::resume)
9992         (ravenscar_thread_target::wait): Special case wildcard requests.
9993
9994 2019-02-15  Tom Tromey  <tromey@adacore.com>
9995
9996         * ravenscar-thread.c (base_ptid): Remove.
9997         (struct ravenscar_thread_target) <close>: New method.
9998         <m_base_ptid>: New member.
9999         <update_inferior_ptid, active_task, task_is_currently_active,
10000         runtime_initialized>: Declare methods.
10001         <ravenscar_thread_target>: Add constructor.
10002         (ravenscar_thread_target::task_is_currently_active)
10003         (ravenscar_thread_target::update_inferior_ptid)
10004         (ravenscar_runtime_initialized): Rename.  Now methods.
10005         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10006         (ravenscar_thread_target::update_thread_list): Update.
10007         (ravenscar_thread_target::active_task): Now method.
10008         (ravenscar_thread_target::store_registers)
10009         (ravenscar_thread_target::prepare_to_store)
10010         (ravenscar_thread_target::prepare_to_store)
10011         (ravenscar_thread_target::mourn_inferior): Update.
10012         (ravenscar_inferior_created): Use "new" to create target.
10013         (ravenscar_thread_target::get_ada_task_ptid): Update.
10014         (_initialize_ravenscar): Don't initialize base_ptid.
10015         (ravenscar_ops): Remove global.
10016
10017 2019-02-15  Tom Tromey  <tromey@adacore.com>
10018
10019         * target.h (push_target): Declare new overload.
10020         * target.c (push_target): New overload, taking an rvalue reference.
10021         * remote.c (remote_target::open_1): Use push_target overload.
10022         * corelow.c (core_target_open): Use push_target overload.
10023
10024 2019-02-15  Tom Tromey  <tromey@adacore.com>
10025
10026         * ravenscar-thread.c (is_ravenscar_task)
10027         (ravenscar_task_is_currently_active): Return bool.
10028         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10029         (_initialize_ravenscar): Remove "(void)".
10030         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10031         Return bool.
10032
10033 2019-02-15  Tom Tromey  <tromey@adacore.com>
10034
10035         * ravenscar-thread.c (ravenscar_runtime_initializer)
10036         (has_ravenscar_runtime, get_running_thread_id)
10037         (ravenscar_thread_target::resume): Fix indentation.
10038
10039 2019-02-15  Tom Tromey  <tromey@adacore.com>
10040
10041         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10042         from ravenscar_arch_ops.
10043         (sparc_ravenscar_ops::fetch_registers)
10044         (sparc_ravenscar_ops::store_registers): Now methods.
10045         (sparc_ravenscar_prepare_to_store): Remove.
10046         (sparc_ravenscar_ops): Redefine.
10047         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10048         methods and destructor.  Remove members.
10049         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10050         (ravenscar_thread_target::store_registers)
10051         (ravenscar_thread_target::prepare_to_store): Update.
10052         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10053         Remove.
10054         (struct ppc_ravenscar_powerpc_ops): Derive from
10055         ravenscar_arch_ops.
10056         (ppc_ravenscar_powerpc_ops::fetch_registers)
10057         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10058         (ppc_ravenscar_powerpc_ops): Redefine.
10059         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10060         (ppc_ravenscar_e500_ops::fetch_registers)
10061         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10062         (ppc_ravenscar_e500_ops): Redefine.
10063         * aarch64-ravenscar-thread.c
10064         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10065         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10066         (aarch64_ravenscar_fetch_registers)
10067         (aarch64_ravenscar_store_registers): Now methods.
10068         (aarch64_ravenscar_ops): Redefine.
10069
10070 2019-02-15  Tom Tromey  <tromey@adacore.com>
10071
10072         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10073         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10074         (ravenscar_thread_target::stopped_by_watchpoint)
10075         (ravenscar_thread_target::stopped_data_address)
10076         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10077
10078 2019-02-15  Tom Tromey  <tromey@adacore.com>
10079
10080         * ravenscar-thread.c: Fix some typos.
10081
10082 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10083             Tom Tromey  <tromey@adacore.com>
10084
10085         * ada-lang.c (ada_exception_sal): Change addr_string to a
10086         std::string.
10087         (create_ada_exception_catchpoint): Update.
10088
10089 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10090             Tom Tromey  <tromey@adacore.com>
10091
10092         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10093         (bp_location_ops): Remove.
10094         (base_breakpoint_allocate_location): Update.
10095         (free_bp_location): Update.
10096         * ada-lang.c (class ada_catchpoint_location)
10097         <ada_catchpoint_location>: Remove ops parameter.
10098         (ada_catchpoint_location_dtor): Remove.
10099         (ada_catchpoint_location_ops): Remove.
10100         (allocate_location_exception): Update.
10101         * breakpoint.h (struct bp_location_ops): Remove.
10102         (class bp_location) <bp_location>: Remove bp_location_ops
10103         parameter.
10104         <~bp_location>: Add destructor.
10105         <ops>: Remove.
10106
10107 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10108             Pedro Alves  <palves@redhat.com>
10109
10110         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10111         'PATH_MAX'.
10112
10113 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10114             Samuel Thibault  <samuel.thibault@gnu.org>
10115             Thomas Schwinge  <thomas@codesourcery.com>
10116
10117         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10118         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10119
10120 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10121
10122         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10123         (check_empty): Use "const char *".
10124
10125         * gnu-nat.c (gnu_nat_target::detach): Instead of
10126         'detach_inferior (pid)' call
10127         'detach_inferior (find_inferior_pid (pid))'.
10128
10129         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10130         'nat/fork-inferior.o'.
10131         * gnu-nat.c: #include "nat/fork-inferior.h".
10132
10133         * gnu-nat.c (gnu_nat_target::detach): Instead of
10134         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10135         * gnu-nat.h: #include "inf-child.h".
10136         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10137         'i386_gnu_nat_target::fetch_registers'.
10138         (gnu_store_registers): Rename/move to
10139         'i386_gnu_nat_target::store_registers'.
10140
10141         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10142         * gnu-nat.h (mach_thread_info): New function.
10143         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10144
10145         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10146
10147 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10148
10149         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10150
10151 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10152
10153         * windows-nat.c (windows_add_thread): Add new parameter
10154         "main_thread_p" with default value set to false.  Update
10155         function documentation as well as all callers.
10156         (windows_delete_thread): Likewise.
10157         (fake_create_process): Update call to windows_add_thread.
10158         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10159         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10160         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10161         call to windows_delete_thread.
10162
10163 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10164
10165         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10166
10167 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10168
10169         * symfile.c (find_separate_debug_file): Use canonical path of
10170         sysroot with child_path instead of gdb_sysroot if it is valid.
10171
10172 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10173
10174         * symfile.c (find_separate_debug_file): Use child_path to
10175         determine if an object file is under a sysroot.
10176
10177 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10178
10179         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10180         unittests/child-path-selftests.c.
10181         * common/pathstuff.c (child_path): New function.
10182         * common/pathstuff.h (child_path): New prototype.
10183         * unittests/child-path-selftests.c: New file.
10184
10185 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10186
10187         * symfile.c (find_separate_debug_file): Look for separate debug
10188         files in debug directories under the sysroot.
10189
10190 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10191
10192         * symtab.h (struct minimal_symbol data_p): New const method.
10193         (struct minimal_symbol text_p): Likewise.
10194         * symtab.c (output_source_filename): Use file name style
10195         to print file name.
10196         (print_symbol_info): Likewise.
10197         (print_msymbol_info): Use address style to print addresses.
10198         Use function name style to print executable text symbols.
10199         (expand_symtab_containing_pc): Use data_p.
10200         (find_pc_sect_compunit_symtab): Likewise.
10201
10202 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10203
10204         * breakpoint.c (describe_other_breakpoints): Use address style
10205         to print addresses.
10206         (say_where): Likewise.
10207
10208 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10209
10210         * ada-typeprint.c (print_func_type): Print function name
10211         style to print function name.
10212         * c-typeprint.c (c_print_type_1): Likewise.
10213
10214 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10215
10216         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10217         for execve.
10218
10219 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10220
10221         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10222         type_stack.
10223
10224 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10225
10226         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10227         TYPE_CODE_REF types.
10228
10229 2019-02-08  Jim Wilson  <jimw@sifive.com>
10230
10231         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10232         (riscv_linux_fregset): New.
10233         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10234
10235 2019-02-07  Tom Tromey  <tom@tromey.com>
10236
10237         * thread.c (thread_cancel_execution_command): Update.
10238         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10239         methods.
10240         (struct thread_fsm_ops): Remove.
10241         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10242         (thread_fsm_should_stop, thread_fsm_return_value)
10243         (thread_fsm_set_finished, thread_fsm_finished_p)
10244         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10245         Don't declare.
10246         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10247         * infrun.c (clear_proceed_status_thread)
10248         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10249         (print_stop_event): Update.
10250         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10251         Add constructor.
10252         (step_command_fsm_ops): Remove.
10253         (new_step_command_fsm): Remove.
10254         (step_1): Update.
10255         (step_command_fsm::should_stop): Rename from
10256         step_command_fsm_should_stop.
10257         (step_command_fsm::clean_up): Rename from
10258         step_command_fsm_clean_up.
10259         (step_command_fsm::do_async_reply_reason): Rename from
10260         step_command_fsm_async_reply_reason.
10261         (struct until_next_fsm): Inherit from thread_fsm.  Add
10262         constructor.
10263         (until_next_fsm_ops): Remove.
10264         (new_until_next_fsm): Remove.
10265         (until_next_fsm::should_stop): Rename from
10266         until_next_fsm_should_stop.
10267         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10268         (until_next_fsm::do_async_reply_reason): Rename from
10269         until_next_fsm_async_reply_reason.
10270         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10271         constructor.  Change type of breakpoint.
10272         (finish_command_fsm_ops): Remove.
10273         (new_finish_command_fsm): Remove.
10274         (finish_command_fsm::should_stop): Rename from
10275         finish_command_fsm_should_stop.
10276         (finish_command_fsm::clean_up): Rename from
10277         finish_command_fsm_clean_up.
10278         (finish_command_fsm::return_value): Rename from
10279         finish_command_fsm_return_value.
10280         (finish_command_fsm::do_async_reply_reason): Rename from
10281         finish_command_fsm_async_reply_reason.
10282         (finish_command): Update.
10283         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10284         Add constructor.
10285         (call_thread_fsm_ops): Remove.
10286         (call_thread_fsm::call_thread_fsm): Rename from
10287         new_call_thread_fsm.
10288         (call_thread_fsm::should_stop): Rename from
10289         call_thread_fsm_should_stop.
10290         (call_thread_fsm::should_notify_stop): Rename from
10291         call_thread_fsm_should_notify_stop.
10292         (run_inferior_call, call_function_by_hand_dummy): Update.
10293         * cli/cli-interp.c (should_print_stop_to_console): Update.
10294         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10295         Add constructor.  Change type of location_breakpoint,
10296         caller_breakpoint.
10297         (until_break_fsm_ops): Remove.
10298         (new_until_break_fsm): Remove.
10299         (until_break_fsm::should_stop): Rename from
10300         until_break_fsm_should_stop.
10301         (until_break_fsm::clean_up): Rename from
10302         until_break_fsm_clean_up.
10303         (until_break_fsm::do_async_reply_reason): Rename from
10304         until_break_fsm_async_reply_reason.
10305         (until_break_command): Update.
10306         * thread-fsm.c: Remove.
10307         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10308
10309 2019-02-07  Tom Tromey  <tom@tromey.com>
10310
10311         * yy-remap.h: Add include guard.
10312         * xtensa-tdep.h: Add include guard.
10313         * xcoffread.h: Rename include guard.
10314         * varobj-iter.h: Add include guard.
10315         * tui/tui.h: Rename include guard.
10316         * tui/tui-winsource.h: Rename include guard.
10317         * tui/tui-wingeneral.h: Rename include guard.
10318         * tui/tui-windata.h: Rename include guard.
10319         * tui/tui-win.h: Rename include guard.
10320         * tui/tui-stack.h: Rename include guard.
10321         * tui/tui-source.h: Rename include guard.
10322         * tui/tui-regs.h: Rename include guard.
10323         * tui/tui-out.h: Rename include guard.
10324         * tui/tui-layout.h: Rename include guard.
10325         * tui/tui-io.h: Rename include guard.
10326         * tui/tui-hooks.h: Rename include guard.
10327         * tui/tui-file.h: Rename include guard.
10328         * tui/tui-disasm.h: Rename include guard.
10329         * tui/tui-data.h: Rename include guard.
10330         * tui/tui-command.h: Rename include guard.
10331         * tic6x-tdep.h: Add include guard.
10332         * target/waitstatus.h: Rename include guard.
10333         * target/wait.h: Rename include guard.
10334         * target/target.h: Rename include guard.
10335         * target/resume.h: Rename include guard.
10336         * target-float.h: Rename include guard.
10337         * stabsread.h: Add include guard.
10338         * rs6000-tdep.h: Add include guard.
10339         * riscv-fbsd-tdep.h: Add include guard.
10340         * regformats/regdef.h: Rename include guard.
10341         * record.h: Rename include guard.
10342         * python/python.h: Rename include guard.
10343         * python/python-internal.h: Rename include guard.
10344         * python/py-stopevent.h: Rename include guard.
10345         * python/py-ref.h: Rename include guard.
10346         * python/py-record.h: Rename include guard.
10347         * python/py-record-full.h: Rename include guard.
10348         * python/py-record-btrace.h: Rename include guard.
10349         * python/py-instruction.h: Rename include guard.
10350         * python/py-events.h: Rename include guard.
10351         * python/py-event.h: Rename include guard.
10352         * procfs.h: Add include guard.
10353         * proc-utils.h: Add include guard.
10354         * p-lang.h: Add include guard.
10355         * or1k-tdep.h: Rename include guard.
10356         * observable.h: Rename include guard.
10357         * nto-tdep.h: Rename include guard.
10358         * nat/x86-linux.h: Rename include guard.
10359         * nat/x86-linux-dregs.h: Rename include guard.
10360         * nat/x86-gcc-cpuid.h: Add include guard.
10361         * nat/x86-dregs.h: Rename include guard.
10362         * nat/x86-cpuid.h: Rename include guard.
10363         * nat/ppc-linux.h: Rename include guard.
10364         * nat/mips-linux-watch.h: Rename include guard.
10365         * nat/linux-waitpid.h: Rename include guard.
10366         * nat/linux-ptrace.h: Rename include guard.
10367         * nat/linux-procfs.h: Rename include guard.
10368         * nat/linux-osdata.h: Rename include guard.
10369         * nat/linux-nat.h: Rename include guard.
10370         * nat/linux-namespaces.h: Rename include guard.
10371         * nat/linux-btrace.h: Rename include guard.
10372         * nat/glibc_thread_db.h: Rename include guard.
10373         * nat/gdb_thread_db.h: Rename include guard.
10374         * nat/gdb_ptrace.h: Rename include guard.
10375         * nat/fork-inferior.h: Rename include guard.
10376         * nat/amd64-linux-siginfo.h: Rename include guard.
10377         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10378         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10379         * nat/aarch64-linux.h: Rename include guard.
10380         * nat/aarch64-linux-hw-point.h: Rename include guard.
10381         * mn10300-tdep.h: Add include guard.
10382         * mips-linux-tdep.h: Add include guard.
10383         * mi/mi-parse.h: Rename include guard.
10384         * mi/mi-out.h: Rename include guard.
10385         * mi/mi-main.h: Rename include guard.
10386         * mi/mi-interp.h: Rename include guard.
10387         * mi/mi-getopt.h: Rename include guard.
10388         * mi/mi-console.h: Rename include guard.
10389         * mi/mi-common.h: Rename include guard.
10390         * mi/mi-cmds.h: Rename include guard.
10391         * mi/mi-cmd-break.h: Rename include guard.
10392         * m2-lang.h: Add include guard.
10393         * location.h: Rename include guard.
10394         * linux-record.h: Rename include guard.
10395         * linux-nat.h: Add include guard.
10396         * linux-fork.h: Add include guard.
10397         * i386-darwin-tdep.h: Rename include guard.
10398         * hppa-linux-offsets.h: Add include guard.
10399         * guile/guile.h: Rename include guard.
10400         * guile/guile-internal.h: Rename include guard.
10401         * gnu-nat.h: Rename include guard.
10402         * gdb-stabs.h: Rename include guard.
10403         * frv-tdep.h: Add include guard.
10404         * f-lang.h: Add include guard.
10405         * event-loop.h: Add include guard.
10406         * darwin-nat.h: Rename include guard.
10407         * cp-abi.h: Rename include guard.
10408         * config/sparc/nm-sol2.h: Rename include guard.
10409         * config/nm-nto.h: Rename include guard.
10410         * config/nm-linux.h: Add include guard.
10411         * config/i386/nm-i386gnu.h: Rename include guard.
10412         * config/djgpp/nl_types.h: Rename include guard.
10413         * config/djgpp/langinfo.h: Rename include guard.
10414         * compile/gcc-cp-plugin.h: Add include guard.
10415         * compile/gcc-c-plugin.h: Add include guard.
10416         * compile/compile.h: Rename include guard.
10417         * compile/compile-object-run.h: Rename include guard.
10418         * compile/compile-object-load.h: Rename include guard.
10419         * compile/compile-internal.h: Rename include guard.
10420         * compile/compile-cplus.h: Rename include guard.
10421         * compile/compile-c.h: Rename include guard.
10422         * common/xml-utils.h: Rename include guard.
10423         * common/x86-xstate.h: Rename include guard.
10424         * common/version.h: Rename include guard.
10425         * common/vec.h: Rename include guard.
10426         * common/tdesc.h: Rename include guard.
10427         * common/selftest.h: Rename include guard.
10428         * common/scoped_restore.h: Rename include guard.
10429         * common/scoped_mmap.h: Rename include guard.
10430         * common/scoped_fd.h: Rename include guard.
10431         * common/safe-iterator.h: Rename include guard.
10432         * common/run-time-clock.h: Rename include guard.
10433         * common/refcounted-object.h: Rename include guard.
10434         * common/queue.h: Rename include guard.
10435         * common/ptid.h: Rename include guard.
10436         * common/print-utils.h: Rename include guard.
10437         * common/preprocessor.h: Rename include guard.
10438         * common/pathstuff.h: Rename include guard.
10439         * common/observable.h: Rename include guard.
10440         * common/netstuff.h: Rename include guard.
10441         * common/job-control.h: Rename include guard.
10442         * common/host-defs.h: Rename include guard.
10443         * common/gdb_wait.h: Rename include guard.
10444         * common/gdb_vecs.h: Rename include guard.
10445         * common/gdb_unlinker.h: Rename include guard.
10446         * common/gdb_unique_ptr.h: Rename include guard.
10447         * common/gdb_tilde_expand.h: Rename include guard.
10448         * common/gdb_sys_time.h: Rename include guard.
10449         * common/gdb_string_view.h: Rename include guard.
10450         * common/gdb_splay_tree.h: Rename include guard.
10451         * common/gdb_setjmp.h: Rename include guard.
10452         * common/gdb_ref_ptr.h: Rename include guard.
10453         * common/gdb_optional.h: Rename include guard.
10454         * common/gdb_locale.h: Rename include guard.
10455         * common/gdb_assert.h: Rename include guard.
10456         * common/filtered-iterator.h: Rename include guard.
10457         * common/filestuff.h: Rename include guard.
10458         * common/fileio.h: Rename include guard.
10459         * common/environ.h: Rename include guard.
10460         * common/common-utils.h: Rename include guard.
10461         * common/common-types.h: Rename include guard.
10462         * common/common-regcache.h: Rename include guard.
10463         * common/common-inferior.h: Rename include guard.
10464         * common/common-gdbthread.h: Rename include guard.
10465         * common/common-exceptions.h: Rename include guard.
10466         * common/common-defs.h: Rename include guard.
10467         * common/common-debug.h: Rename include guard.
10468         * common/cleanups.h: Rename include guard.
10469         * common/buffer.h: Rename include guard.
10470         * common/btrace-common.h: Rename include guard.
10471         * common/break-common.h: Rename include guard.
10472         * cli/cli-utils.h: Rename include guard.
10473         * cli/cli-style.h: Rename include guard.
10474         * cli/cli-setshow.h: Rename include guard.
10475         * cli/cli-script.h: Rename include guard.
10476         * cli/cli-interp.h: Rename include guard.
10477         * cli/cli-decode.h: Rename include guard.
10478         * cli/cli-cmds.h: Rename include guard.
10479         * charset-list.h: Add include guard.
10480         * buildsym-legacy.h: Rename include guard.
10481         * bfin-tdep.h: Add include guard.
10482         * ax.h: Rename include guard.
10483         * arm-linux-tdep.h: Add include guard.
10484         * arm-fbsd-tdep.h: Add include guard.
10485         * arch/xtensa.h: Rename include guard.
10486         * arch/tic6x.h: Add include guard.
10487         * arch/i386.h: Add include guard.
10488         * arch/arm.h: Rename include guard.
10489         * arch/arm-linux.h: Rename include guard.
10490         * arch/arm-get-next-pcs.h: Rename include guard.
10491         * arch/amd64.h: Add include guard.
10492         * arch/aarch64-insn.h: Rename include guard.
10493         * arch-utils.h: Rename include guard.
10494         * annotate.h: Add include guard.
10495         * amd64-darwin-tdep.h: Rename include guard.
10496         * aarch64-linux-tdep.h: Add include guard.
10497         * aarch64-fbsd-tdep.h: Add include guard.
10498         * aarch32-linux-nat.h: Add include guard.
10499
10500 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10501
10502         * macrotab.c (macro_define_internal): New function that
10503         factorizes macro_define_object_internal and macro_define_function
10504         code.
10505         (macro_define_object_internal): Use macro_define_internal.
10506         (macro_define_function): Likewise.
10507
10508 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10509
10510         * macrocmd.c (extract_identifier): Return
10511         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10512         callers.
10513
10514 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10515
10516         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10517
10518 2019-02-05  Tom Tromey  <tom@tromey.com>
10519
10520         * target.c (target_stack::unpush): Move assertion earlier.
10521
10522 2019-01-30  Tom Tromey  <tom@tromey.com>
10523
10524         PR python/23615:
10525         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10526         (gdbpy_parse_and_eval): Likewise.
10527         * python/python-internal.h (gdbpy_allow_threads): New class.
10528
10529 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10530
10531         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10532         (aarch64_fbsd_fpregmap): Move earlier.
10533         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10534         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10535         instead of individual calls to trad_frame_set_reg_addr.
10536         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10537         earlier.
10538         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10539         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10540         instead of individual calls to trad_frame_set_reg_addr.
10541
10542 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10543
10544         * CONTRIBUTE: Replace contribution list with wiki link.
10545
10546 2019-01-25  Tom Tromey  <tom@tromey.com>
10547
10548         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10549
10550 2019-01-25  Tom Tromey  <tom@tromey.com>
10551
10552         * xtensa-linux-nat.c: Fix common/ includes.
10553         * xml-support.h: Fix common/ includes.
10554         * xml-support.c: Fix common/ includes.
10555         * x86-linux-nat.c: Fix common/ includes.
10556         * windows-nat.c: Fix common/ includes.
10557         * varobj.h: Fix common/ includes.
10558         * varobj.c: Fix common/ includes.
10559         * value.c: Fix common/ includes.
10560         * valops.c: Fix common/ includes.
10561         * utils.c: Fix common/ includes.
10562         * unittests/xml-utils-selftests.c: Fix common/ includes.
10563         * unittests/utils-selftests.c: Fix common/ includes.
10564         * unittests/unpack-selftests.c: Fix common/ includes.
10565         * unittests/tracepoint-selftests.c: Fix common/ includes.
10566         * unittests/style-selftests.c: Fix common/ includes.
10567         * unittests/string_view-selftests.c: Fix common/ includes.
10568         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10569         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10570         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10571         * unittests/rsp-low-selftests.c: Fix common/ includes.
10572         * unittests/parse-connection-spec-selftests.c: Fix common/
10573         includes.
10574         * unittests/optional-selftests.c: Fix common/ includes.
10575         * unittests/offset-type-selftests.c: Fix common/ includes.
10576         * unittests/observable-selftests.c: Fix common/ includes.
10577         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10578         * unittests/memrange-selftests.c: Fix common/ includes.
10579         * unittests/memory-map-selftests.c: Fix common/ includes.
10580         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10581         * unittests/function-view-selftests.c: Fix common/ includes.
10582         * unittests/environ-selftests.c: Fix common/ includes.
10583         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10584         * unittests/common-utils-selftests.c: Fix common/ includes.
10585         * unittests/cli-utils-selftests.c: Fix common/ includes.
10586         * unittests/array-view-selftests.c: Fix common/ includes.
10587         * ui-file.c: Fix common/ includes.
10588         * tui/tui-io.c: Fix common/ includes.
10589         * tracepoint.h: Fix common/ includes.
10590         * tracepoint.c: Fix common/ includes.
10591         * tracefile-tfile.c: Fix common/ includes.
10592         * top.h: Fix common/ includes.
10593         * top.c: Fix common/ includes.
10594         * thread.c: Fix common/ includes.
10595         * target/waitstatus.h: Fix common/ includes.
10596         * target/waitstatus.c: Fix common/ includes.
10597         * target.h: Fix common/ includes.
10598         * target.c: Fix common/ includes.
10599         * target-memory.c: Fix common/ includes.
10600         * target-descriptions.c: Fix common/ includes.
10601         * symtab.h: Fix common/ includes.
10602         * symfile.c: Fix common/ includes.
10603         * stap-probe.c: Fix common/ includes.
10604         * spu-linux-nat.c: Fix common/ includes.
10605         * sparc-nat.c: Fix common/ includes.
10606         * source.c: Fix common/ includes.
10607         * solib.c: Fix common/ includes.
10608         * solib-target.c: Fix common/ includes.
10609         * ser-unix.c: Fix common/ includes.
10610         * ser-tcp.c: Fix common/ includes.
10611         * ser-pipe.c: Fix common/ includes.
10612         * ser-base.c: Fix common/ includes.
10613         * selftest-arch.c: Fix common/ includes.
10614         * s12z-tdep.c: Fix common/ includes.
10615         * rust-exp.y: Fix common/ includes.
10616         * rs6000-aix-tdep.c: Fix common/ includes.
10617         * riscv-tdep.c: Fix common/ includes.
10618         * remote.c: Fix common/ includes.
10619         * remote-notif.h: Fix common/ includes.
10620         * remote-fileio.h: Fix common/ includes.
10621         * remote-fileio.c: Fix common/ includes.
10622         * regcache.h: Fix common/ includes.
10623         * regcache.c: Fix common/ includes.
10624         * record-btrace.c: Fix common/ includes.
10625         * python/python.c: Fix common/ includes.
10626         * python/py-type.c: Fix common/ includes.
10627         * python/py-inferior.c: Fix common/ includes.
10628         * progspace.h: Fix common/ includes.
10629         * producer.c: Fix common/ includes.
10630         * procfs.c: Fix common/ includes.
10631         * proc-api.c: Fix common/ includes.
10632         * printcmd.c: Fix common/ includes.
10633         * ppc-linux-nat.c: Fix common/ includes.
10634         * parser-defs.h: Fix common/ includes.
10635         * osdata.c: Fix common/ includes.
10636         * obsd-nat.c: Fix common/ includes.
10637         * nat/x86-linux.c: Fix common/ includes.
10638         * nat/x86-linux-dregs.c: Fix common/ includes.
10639         * nat/x86-dregs.h: Fix common/ includes.
10640         * nat/x86-dregs.c: Fix common/ includes.
10641         * nat/ppc-linux.c: Fix common/ includes.
10642         * nat/mips-linux-watch.h: Fix common/ includes.
10643         * nat/mips-linux-watch.c: Fix common/ includes.
10644         * nat/linux-waitpid.c: Fix common/ includes.
10645         * nat/linux-ptrace.h: Fix common/ includes.
10646         * nat/linux-ptrace.c: Fix common/ includes.
10647         * nat/linux-procfs.c: Fix common/ includes.
10648         * nat/linux-personality.c: Fix common/ includes.
10649         * nat/linux-osdata.c: Fix common/ includes.
10650         * nat/linux-namespaces.c: Fix common/ includes.
10651         * nat/linux-btrace.h: Fix common/ includes.
10652         * nat/linux-btrace.c: Fix common/ includes.
10653         * nat/fork-inferior.c: Fix common/ includes.
10654         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10655         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10656         * nat/aarch64-linux.c: Fix common/ includes.
10657         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10658         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10659         * namespace.h: Fix common/ includes.
10660         * mips-linux-tdep.c: Fix common/ includes.
10661         * minsyms.c: Fix common/ includes.
10662         * mi/mi-parse.h: Fix common/ includes.
10663         * mi/mi-main.c: Fix common/ includes.
10664         * mi/mi-cmd-env.c: Fix common/ includes.
10665         * memrange.h: Fix common/ includes.
10666         * memattr.c: Fix common/ includes.
10667         * maint.h: Fix common/ includes.
10668         * maint.c: Fix common/ includes.
10669         * main.c: Fix common/ includes.
10670         * machoread.c: Fix common/ includes.
10671         * location.c: Fix common/ includes.
10672         * linux-thread-db.c: Fix common/ includes.
10673         * linux-nat.c: Fix common/ includes.
10674         * linux-fork.c: Fix common/ includes.
10675         * inline-frame.c: Fix common/ includes.
10676         * infrun.c: Fix common/ includes.
10677         * inflow.c: Fix common/ includes.
10678         * inferior.h: Fix common/ includes.
10679         * inferior.c: Fix common/ includes.
10680         * infcmd.c: Fix common/ includes.
10681         * inf-ptrace.c: Fix common/ includes.
10682         * inf-child.c: Fix common/ includes.
10683         * ia64-linux-nat.c: Fix common/ includes.
10684         * i387-tdep.c: Fix common/ includes.
10685         * i386-tdep.c: Fix common/ includes.
10686         * i386-linux-tdep.c: Fix common/ includes.
10687         * i386-linux-nat.c: Fix common/ includes.
10688         * i386-go32-tdep.c: Fix common/ includes.
10689         * i386-fbsd-tdep.c: Fix common/ includes.
10690         * i386-fbsd-nat.c: Fix common/ includes.
10691         * guile/scm-type.c: Fix common/ includes.
10692         * guile/guile.c: Fix common/ includes.
10693         * go32-nat.c: Fix common/ includes.
10694         * gnu-nat.c: Fix common/ includes.
10695         * gdbthread.h: Fix common/ includes.
10696         * gdbarch-selftests.c: Fix common/ includes.
10697         * gdb_usleep.c: Fix common/ includes.
10698         * gdb_select.h: Fix common/ includes.
10699         * gdb_bfd.c: Fix common/ includes.
10700         * gcore.c: Fix common/ includes.
10701         * fork-child.c: Fix common/ includes.
10702         * findvar.c: Fix common/ includes.
10703         * fbsd-nat.c: Fix common/ includes.
10704         * event-top.c: Fix common/ includes.
10705         * event-loop.c: Fix common/ includes.
10706         * dwarf2read.c: Fix common/ includes.
10707         * dwarf2loc.c: Fix common/ includes.
10708         * dwarf2-frame.c: Fix common/ includes.
10709         * dwarf-index-cache.c: Fix common/ includes.
10710         * dtrace-probe.c: Fix common/ includes.
10711         * disasm-selftests.c: Fix common/ includes.
10712         * defs.h: Fix common/ includes.
10713         * csky-tdep.c: Fix common/ includes.
10714         * cp-valprint.c: Fix common/ includes.
10715         * cp-support.h: Fix common/ includes.
10716         * cp-support.c: Fix common/ includes.
10717         * corelow.c: Fix common/ includes.
10718         * completer.h: Fix common/ includes.
10719         * completer.c: Fix common/ includes.
10720         * compile/compile.c: Fix common/ includes.
10721         * compile/compile-loc2c.c: Fix common/ includes.
10722         * compile/compile-cplus-types.c: Fix common/ includes.
10723         * compile/compile-cplus-symbols.c: Fix common/ includes.
10724         * command.h: Fix common/ includes.
10725         * cli/cli-dump.c: Fix common/ includes.
10726         * cli/cli-cmds.c: Fix common/ includes.
10727         * charset.c: Fix common/ includes.
10728         * build-id.c: Fix common/ includes.
10729         * btrace.h: Fix common/ includes.
10730         * btrace.c: Fix common/ includes.
10731         * breakpoint.h: Fix common/ includes.
10732         * breakpoint.c: Fix common/ includes.
10733         * ax.h:
10734         (enum agent_op): Fix common/ includes.
10735         * ax-general.c (struct aop_map): Fix common/ includes.
10736         * ax-gdb.c: Fix common/ includes.
10737         * auxv.c: Fix common/ includes.
10738         * auto-load.c: Fix common/ includes.
10739         * arm-tdep.c: Fix common/ includes.
10740         * arch/riscv.c: Fix common/ includes.
10741         * arch/ppc-linux-common.c: Fix common/ includes.
10742         * arch/i386.c: Fix common/ includes.
10743         * arch/arm.c: Fix common/ includes.
10744         * arch/arm-linux.c: Fix common/ includes.
10745         * arch/arm-get-next-pcs.c: Fix common/ includes.
10746         * arch/amd64.c: Fix common/ includes.
10747         * arch/aarch64.c: Fix common/ includes.
10748         * arch/aarch64-insn.c: Fix common/ includes.
10749         * arch-utils.c: Fix common/ includes.
10750         * amd64-windows-tdep.c: Fix common/ includes.
10751         * amd64-tdep.c: Fix common/ includes.
10752         * amd64-sol2-tdep.c: Fix common/ includes.
10753         * amd64-obsd-tdep.c: Fix common/ includes.
10754         * amd64-nbsd-tdep.c: Fix common/ includes.
10755         * amd64-linux-tdep.c: Fix common/ includes.
10756         * amd64-linux-nat.c: Fix common/ includes.
10757         * amd64-fbsd-tdep.c: Fix common/ includes.
10758         * amd64-fbsd-nat.c: Fix common/ includes.
10759         * amd64-dicos-tdep.c: Fix common/ includes.
10760         * amd64-darwin-tdep.c: Fix common/ includes.
10761         * agent.c: Fix common/ includes.
10762         * ada-lang.h: Fix common/ includes.
10763         * ada-lang.c: Fix common/ includes.
10764         * aarch64-tdep.c: Fix common/ includes.
10765
10766 2019-01-25  Tom Tromey  <tom@tromey.com>
10767
10768         * common/create-version.sh: Use common/version.h.
10769
10770 2019-01-24  Pedro Alves  <palves@redhat.com>
10771
10772         * infrun.c (signal_stop, signal_print, signal_program)
10773         (signal_catch, signal_pass): Now arrays instead of pointers.
10774         (update_signals_program_target, do_target_resume)
10775         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10776         * linux-nat.c (linux_nat_target::pass_signals)
10777         (linux_nat_target::create_inferior, linux_nat_target::attach):
10778         Adjust.
10779         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10780         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10781         * procfs.c (procfs_target::pass_signals): Adjust.
10782         * record-full.c (record_full_target::resume): Adjust.
10783         * remote.c (remote_target::pass_signals)
10784         (remote_target::program_signals): Adjust.
10785         * target-debug.h (target_debug_print_signals): Now takes a
10786         gdb::array_view as parameter.  Adjust.
10787         * target.h (target_ops) <pass_signals, program_signals>: Replace
10788         pointer and length parameters with gdb::array_view.
10789         (target_pass_signals, target_program_signals): Likewise.
10790         * target-delegates.c: Regenerate.
10791
10792 2019-01-24  Pedro Alves  <palves@redhat.com>
10793
10794         * common/forward-scope-exit.h
10795         (forward_scope_exit::forward_scope_exit): Pass arguments to
10796         m_bind_function directly, instead of creating a std::bind and
10797         copying that.
10798
10799 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10800
10801         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10802         for static members.
10803         (pass_in_v_vfp_candidate): Likewise.
10804
10805 2019-01-23  Tom Tromey  <tom@tromey.com>
10806             Pedro Alves  <palves@redhat.com>
10807
10808         * regcache.c (class regcache_invalidator): Remove.
10809         (regcache::raw_write): Use make_scope_exit.
10810
10811 2019-01-23  Tom Tromey  <tom@tromey.com>
10812
10813         * ui-out.h (class ui_out_emit_type): Update comment.
10814
10815 2019-01-23  Tom Tromey  <tom@tromey.com>
10816
10817         * infrun.c (fetch_inferior_event): Update comment.
10818
10819 2019-01-23  Tom Tromey  <tom@tromey.com>
10820             Pedro Alves  <palves@redhat.com>
10821
10822         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10823         parameter.
10824         (fetch_inferior_event): Use SCOPE_EXIT.
10825
10826
10827 2019-01-23  Tom Tromey  <tom@tromey.com>
10828             Pedro Alves  <palves@redhat.com>
10829
10830         * infrun.c (disable_thread_events): Delete.
10831         (stop_all_threads): Use SCOPE_EXIT.
10832
10833 2019-01-23  Tom Tromey  <tom@tromey.com>
10834             Pedro Alves  <palves@redhat.com>
10835
10836         * symfile.c: Include forward-scope-exit.h.
10837         (clear_symtab_users_cleanup): Replace forward declaration with
10838         a FORWARD_SCOPE_EXIT.
10839         (syms_from_objfile_1): Use the forward_scope_exit and
10840         gdb::optional instead of cleanup_function.
10841         (reread_symbols): Use the forward_scope_exit instead of
10842         cleanup_function.
10843         (clear_symtab_users_cleanup): Remove function.
10844
10845 2019-01-23  Tom Tromey  <tom@tromey.com>
10846             Pedro Alves  <palves@redhat.com>
10847
10848         * linux-nat.c: Include scope-exit.h.
10849         (cleanup_target_stop): Remove.
10850         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10851         SCOPE_EXIT.
10852
10853 2019-01-23  Tom Tromey  <tom@tromey.com>
10854             Pedro Alves  <palves@redhat.com>
10855
10856         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10857         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10858
10859 2019-01-23  Tom Tromey  <tom@tromey.com>
10860             Andrew Burgess  <andrew.burgess@embecosm.com>
10861             Pedro Alves  <palves@redhat.com>
10862
10863         * infrun.c (fetch_inferior_event): Use scope_exit.
10864         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10865         * top.c (execute_command): Use scope_exit.
10866         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10867         * utils.c (do_bpstat_clear_actions_cleanup)
10868         (make_bpstat_clear_actions_cleanup): Remove.
10869
10870 2019-01-23  Tom Tromey  <tom@tromey.com>
10871             Pedro Alves  <palves@redhat.com>
10872
10873         * infrun.c: Include "common/scope-exit.h"
10874         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10875         (wait_for_inferior): Use SCOPE_EXIT.
10876         (fetch_inferior_event): Use scope_exit.
10877
10878 2019-01-23  Tom Tromey  <tom@tromey.com>
10879             Pedro Alves  <palves@redhat.com>
10880
10881         * breakpoint.c (create_breakpoint): Remove cleanup.
10882
10883 2019-01-23  Tom Tromey  <tom@tromey.com>
10884             Andrew Burgess  <andrew.burgess@embecosm.com>
10885             Pedro Alves  <palves@redhat.com>
10886
10887 2019-01-23  Pedro Alves  <palves@redhat.com>
10888
10889         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10890
10891 2019-01-23  Pedro Alves  <palves@redhat.com>
10892             Andrew Burgess  <andrew.burgess@embecosm.com>
10893
10894         * gdbthread.h: Include "common/forward-scope-exit.h".
10895         (scoped_finish_thread_state): Redefine custom class in terms of
10896         forward_scope_exit.
10897
10898 2019-01-23  Pedro Alves  <palves@redhat.com>
10899             Andrew Burgess  <andrew.burgess@embecosm.com>
10900
10901         * common/forward-scope-exit.h: New file.
10902
10903 2019-01-23  Pedro Alves  <palves@redhat.com>
10904             Andrew Burgess  <andrew.burgess@embecosm.com>
10905             Tom Tromey  <tom@tromey.com>
10906
10907         * common/scope-exit.h: New file.
10908
10909 2019-01-23  Pedro Alves  <palves@redhat.com>
10910
10911         * common/preprocessor.h (ESC): Rename to ...
10912         (ESC_PARENS): ... this.
10913         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10914         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10915
10916 2019-01-23  Tom Tromey  <tom@tromey.com>
10917
10918         * language.h (class scoped_switch_to_sym_language_if_auto):
10919         Initialize m_lang in both cases.
10920
10921 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10922
10923         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10924         with XCNEW.
10925
10926 2019-01-22  Tom Tromey  <tom@tromey.com>
10927
10928         * corelow.c: Do not include sys/file.h.
10929
10930 2019-01-22  Tom Tromey  <tom@tromey.com>
10931
10932         * tui/tui-wingeneral.h: Include gdb_curses.h.
10933
10934 2019-01-22  Tom Tromey  <tom@tromey.com>
10935
10936         * source-cache.h (class source_cache) <get_source_lines,
10937         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10938
10939 2019-01-22  Tom Tromey  <tom@tromey.com>
10940
10941         * remote-fileio.h (struct remote_target): Declare.
10942
10943 2019-01-22  Tom Tromey  <tom@tromey.com>
10944
10945         * python/py-arch.c: Do not include py-ref.h.
10946         * python/py-bpevent.c: Do not include py-ref.h.
10947         * python/py-cmd.c: Do not include py-ref.h.
10948         * python/py-continueevent.c: Do not include py-ref.h.
10949         * python/py-event.h: Do not include py-ref.h.
10950         * python/py-evtregistry.c: Do not include py-ref.h.
10951         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10952         * python/py-frame.c: Do not include py-ref.h.
10953         * python/py-framefilter.c: Do not include py-ref.h.
10954         * python/py-function.c: Do not include py-ref.h.
10955         * python/py-infevents.c: Do not include py-ref.h.
10956         * python/py-linetable.c: Do not include py-ref.h.
10957         * python/py-objfile.c: Do not include py-ref.h.
10958         * python/py-param.c: Do not include py-ref.h.
10959         * python/py-prettyprint.c: Do not include py-ref.h.
10960         * python/py-progspace.c: Do not include py-ref.h.
10961         * python/py-symbol.c: Do not include py-ref.h.
10962         * python/py-symtab.c: Do not include py-ref.h.
10963         * python/py-type.c: Do not include py-ref.h.
10964         * python/py-unwind.c: Do not include py-ref.h.
10965         * python/py-utils.c: Do not include py-ref.h.
10966         * python/py-value.c: Do not include py-ref.h.
10967         * python/py-varobj.c: Do not include py-ref.h.
10968         * python/py-xmethods.c: Do not include py-ref.h.
10969         * python/python.c: Do not include py-ref.h.
10970         * varobj.c: Do not include py-ref.h.
10971
10972 2019-01-22  Tom Tromey  <tom@tromey.com>
10973
10974         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10975         keyword for bcache.
10976
10977 2019-01-22  Tom Tromey  <tom@tromey.com>
10978
10979         * compile/compile-cplus-types.c: Remove a comment by #include.
10980
10981 2019-01-22  Tom Tromey  <tom@tromey.com>
10982
10983         * compile/gcc-c-plugin.h: Include compile-internal.h.
10984
10985 2019-01-22  Tom Tromey  <tom@tromey.com>
10986
10987         * stabsread.c (EXTERN): Do not define.
10988         (symnum, next_symbol_text_func, processing_gcc_compilation)
10989         (within_function, global_sym_chain, global_stabs)
10990         (previous_stab_code, this_object_header_files)
10991         (n_this_object_header_files)
10992         (n_allocated_this_object_header_files): Define.
10993         * stabsread.h (EXTERN): Never define.  Use "extern".
10994
10995 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10996
10997         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10998         history_value.
10999
11000 2019-01-21  Tom Tromey  <tom@tromey.com>
11001
11002         * ui-out.c: Fix includes.
11003         * tui/tui-source.c: Fix includes.
11004         * target.c: Fix includes.
11005         * remote.c: Fix includes.
11006         * regcache.c: Fix includes.
11007         * python/py-block.c: Fix includes.
11008         * printcmd.c: Fix includes.
11009         * or1k-tdep.c: Fix includes.
11010         * mi/mi-main.c: Fix includes.
11011         * m32r-tdep.c: Fix includes.
11012         * csky-tdep.c: Fix includes.
11013         * compile/compile-cplus-types.c: Fix includes.
11014         * cli/cli-interp.c: Fix includes.
11015
11016 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11017
11018         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11019         for padding.
11020
11021 2019-01-16  Tom Tromey  <tom@tromey.com>
11022
11023         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11024         earlier.
11025         (struct objfile) <msymbols_range>: Move from top level.
11026         <msymbols>: New method.
11027         (class objfile_msymbols): Remove.
11028         * symtab.c (default_collect_symbol_completion_matches_break_on):
11029         Update.
11030         * symmisc.c (dump_msymbols): Update.
11031         * stabsread.c (scan_file_globals): Update.
11032         * objc-lang.c (info_selectors_command, info_classes_command)
11033         (find_methods): Update.
11034         * minsyms.c (find_solib_trampoline_target): Update.
11035         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11036         * coffread.c (coff_symfile_read): Update.
11037         * ada-lang.c (ada_lookup_simple_minsym)
11038         (ada_collect_symbol_completion_matches): Update.
11039
11040 2019-01-16  Tom Tromey  <tom@tromey.com>
11041
11042         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11043         type.  Remove no-argument constructor.
11044         <iterator::operator++>: Simplify.
11045         <begin>: Update.
11046         <end>: Use minimal_symbol_count.
11047
11048 2019-01-16  Tom Tromey  <tom@tromey.com>
11049
11050         * objfiles.h (struct objfile) <psymtabs>: New method.
11051         (class objfile_psymtabs): Remove.
11052         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11053         typedef.
11054         <range>: New method.
11055         (require_partial_symbols): Change return type.
11056         * psymtab.c (require_partial_symbols)
11057         (psym_expand_symtabs_matching): Update.
11058         * mdebugread.c (parse_partial_symbols): Update.
11059         * dbxread.c (dbx_end_psymtab): Update.
11060
11061 2019-01-15  Tom Tromey  <tom@tromey.com>
11062
11063         * symtab.c (lookup_objfile_from_block)
11064         (lookup_symbol_in_objfile_symtabs)
11065         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11066         (find_line_symtab, info_sources_command)
11067         (default_collect_symbol_completion_matches_break_on)
11068         (make_source_files_completion_list): Update.
11069         * symmisc.c (print_objfile_statistics, dump_objfile)
11070         (maintenance_print_symbols, maintenance_info_symtabs)
11071         (maintenance_check_symtabs, maintenance_info_line_tables):
11072         Update.
11073         * source.c (select_source_symtab)
11074         (forget_cached_source_info_for_objfile): Update.
11075         * objfiles.h (class objfile_compunits): Remove.
11076         (struct objfile) <compunits_range>: New typedef.
11077         (compunits): New method.
11078         * objfiles.c (objfile_relocate1): Update.
11079         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11080         * maint.c (count_symtabs_and_blocks): Update.
11081         * linespec.c (iterate_over_all_matching_symtabs): Update.
11082         * cp-support.c (add_symbol_overload_list_qualified): Update.
11083         * coffread.c (coff_symtab_read): Update.
11084         * ada-lang.c (add_nonlocal_symbols)
11085         (ada_collect_symbol_completion_matches)
11086         (ada_add_global_exceptions): Update.
11087
11088 2019-01-15  Tom Tromey  <tom@tromey.com>
11089
11090         * progspace.h (program_space) <objfiles_safe_range>: New
11091         typedef.
11092         <objfiles_safe>: New method.
11093         * objfiles.h (class all_objfiles_safe): Remove.
11094         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11095         * jit.c (jit_inferior_exit_hook): Update.
11096
11097 2019-01-17  Tom Tromey  <tom@tromey.com>
11098
11099         * progspace.h (program_space) <objfiles_range>: New typedef.
11100         <objfiles>: New method.
11101         <objfiles_head>: Rename from objfiles.
11102         (object_files): Update.
11103         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11104         * guile/scm-pretty-print.c
11105         (ppscm_find_pretty_printer_from_objfiles): Update.
11106         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11107         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11108         Update.
11109         * python/py-progspace.c (pspy_get_objfiles): Update.
11110         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11111         Update.
11112         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11113         (objfpy_lookup_objfile_by_build_id): Update.
11114         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11115         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11116         Update.
11117         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11118         (expand_symtab_containing_pc, lookup_objfile_from_block)
11119         (lookup_static_symbol, basic_lookup_transparent_type)
11120         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11121         (find_line_symtab, info_sources_command)
11122         (default_collect_symbol_completion_matches_break_on)
11123         (make_source_files_completion_list, find_main_name): Update.
11124         * symmisc.c (print_symbol_bcache_statistics)
11125         (print_objfile_statistics, maintenance_print_symbols)
11126         (maintenance_print_msymbols, maintenance_print_objfiles)
11127         (maintenance_info_symtabs, maintenance_check_symtabs)
11128         (maintenance_expand_symtabs, maintenance_info_line_tables):
11129         Update.
11130         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11131         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11132         (map_overlay_command, unmap_overlay_command)
11133         (simple_overlay_update, expand_symtabs_matching)
11134         (map_symbol_filenames): Update.
11135         * symfile-debug.c (set_debug_symfile): Update.
11136         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11137         Update.
11138         * source.c (select_source_symtab, forget_cached_source_info):
11139         Update.
11140         * solib.c (solib_read_symbols): Update.
11141         * solib-spu.c (append_ocl_sos): Update.
11142         * psymtab.c (maintenance_print_psymbols)
11143         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11144         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11145         * printcmd.c (info_symbol_command): Update.
11146         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11147         Update.
11148         * objfiles.h (class all_objfiles): Remove.
11149         * objfiles.c (have_partial_symbols, have_full_symbols)
11150         (have_minimal_symbols, qsort_cmp, update_section_map)
11151         (shared_objfile_contains_address_p)
11152         (default_iterate_over_objfiles_in_search_order): Update.
11153         * objc-lang.c (info_selectors_command, info_classes_command)
11154         (find_methods): Update.
11155         * minsyms.c (find_solib_trampoline_target): Update.
11156         * maint.c (maintenance_info_sections)
11157         (maintenance_translate_address, count_symtabs_and_blocks):
11158         Update.
11159         * main.c (captured_main_1): Update.
11160         * linux-thread-db.c (try_thread_db_load_from_pdir)
11161         (has_libpthread): Update.
11162         * linespec.c (iterate_over_all_matching_symtabs)
11163         (search_minsyms_for_name): Update.
11164         * jit.c (jit_find_objf_with_entry_addr): Update.
11165         * hppa-tdep.c (find_unwind_entry)
11166         (hppa_lookup_stub_minimal_symbol): Update.
11167         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11168         Update.
11169         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11170         (elf_gnu_ifunc_resolve_by_got): Update.
11171         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11172         * dwarf-index-write.c (save_gdb_index_command): Update.
11173         * cp-support.c (add_symbol_overload_list_qualified): Update.
11174         * breakpoint.c (create_overlay_event_breakpoint)
11175         (create_longjmp_master_breakpoint)
11176         (create_std_terminate_master_breakpoint)
11177         (create_exception_master_breakpoint): Update.
11178         * blockframe.c (find_pc_partial_function): Update.
11179         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11180         (ada_collect_symbol_completion_matches)
11181         (ada_add_global_exceptions): Update.
11182
11183 2019-01-17  Tom Tromey  <tom@tromey.com>
11184
11185         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11186         declare VEC.
11187         (solib_target_parse_libraries): Change return type.
11188         (library_list_start_segment, library_list_start_section)
11189         (library_list_end_library, library_list_start_library); Update.
11190         (solib_target_free_library_list): Remove.
11191         (solib_target_parse_libraries): Remove cleanup.  Change return
11192         type.
11193         (solib_target_current_sos): Update.
11194
11195 2019-01-17  Tom Tromey  <tromey@bapiya>
11196
11197         * valprint.c: Replace "the the" with "the".
11198         * symtab.c: Replace "the the" with "the".
11199         * solib.c: Replace "the the" with "the".
11200         * solib-dsbt.c: Replace "the the" with "the".
11201         * linespec.c: Replace "the the" with "the".
11202         * dwarf2loc.h: Replace "the the" with "the".
11203         * amd64-windows-tdep.c: Replace "the the" with "the".
11204         * aarch64-tdep.c: Replace "the the" with "the".
11205
11206 2019-01-16  Keith Seitz  <keiths@redhat.com>
11207
11208         PR gdb/23773
11209         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11210         <builder>: Rename to ..
11211         <m_builder>: ... this and make private.
11212         (dwarf2_cu::get_builder): New method.  Change all users of
11213         `builder' to use this method.
11214         (dwarf2_start_symtab): Move to ...
11215         (dwarf2_cu::start_symtab): ... here.  Update all callers
11216         (setup_type_unit_groups): Move to ...
11217         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11218         callers.
11219         (dwarf2_cu::reset_builder): New method.
11220         (process_full_compunit, process_full_type_unit): Use
11221         dwarf2_cu::reset_builder.
11222         (follow_die_offset): Record the ancestor CU if it is different
11223         from the followed DIE's CU.
11224         (follow_die_sig_1): Likewise.
11225
11226 2019-01-15  Tom Tromey  <tom@tromey.com>
11227
11228         * remote.c (class remote_state) <buf>: Now a char_vector.
11229         <buf_size>: Remove.
11230         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11231         parameter.
11232         (remote_target::getpkt_or_notif_sane_1)
11233         (remote_target::getpkt_sane)
11234         (remote_target::getpkt_or_notif_sane): Likewise.
11235         (class remote_target) <putpkt>: New overload.
11236         (remote_target::read_frame): Change type of "buf_p".  Remove
11237         sizeof_p parameter.
11238         (packet_ok): New overload.
11239         (packet_check_result): New overload.
11240         Update all uses.
11241
11242 2019-01-14  Tom Tromey  <tom@tromey.com>
11243
11244         * remote-notif.c (handle_notification, remote_notif_ack)
11245         (remote_notif_parse): Make "buf" const.
11246         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11247         const.
11248         (remote_notif_parse, remote_notif_ack, handle_notification):
11249         Likewise.
11250         * remote.c (remote_notif_stop_parse): Make "buf" const.
11251         (remote_target::remote_parse_stop_reply): Make "buf" const.
11252         (remote_notif_stop_ack): Make "buf" const.
11253
11254 2019-01-14  Tom Tromey  <tom@tromey.com>
11255
11256         * remote.c (remote_console_output): Make parameter const.
11257
11258 2019-01-14  Tom Tromey  <tom@tromey.com>
11259
11260         * target-debug.h (target_debug_print_signals): Constify.
11261         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11262         * procfs.c (procfs_target::pass_signals): Update.
11263         * linux-nat.c (linux_nat_target::pass_signals): Update.
11264         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11265         * target-delegates.c: Rebuild.
11266         * remote.c (remote_target::program_signals): Update.
11267         (remote_target::pass_signals): Update.
11268         * target.c (target_pass_signals): Constify argument.
11269         (target_program_signals): Likewise.
11270         * target.h (struct target_ops) <pass_signals, program_signals>:
11271         Constify argument.
11272         (target_pass_signals, target_program_signals): Constify argument.
11273
11274 2019-01-14  Tom Tromey  <tom@tromey.com>
11275
11276         PR tui/28819:
11277         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11278
11279 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11280
11281         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11282         field.
11283         * rs6000-tdep.c: Include reggroups.h.
11284         (IS_V_ALIAS_PSEUDOREG): Define.
11285         (rs6000_register_name): Return names for the "vX" aliases.
11286         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11287         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11288         aliases.  Call default_register_reggroup_p for all other
11289         pseudo-registers.
11290         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11291         New functions.
11292         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11293         Handle "vX" aliases.
11294         (v_alias_pseudo_register_collect): New function.
11295         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11296         (rs6000_gdbarch_init): Initialize "vX" aliases as
11297         pseudo-registers.  Restore registration of
11298         rs6000_pseudo_register_reggroup_p with
11299         set_tdesc_pseudo_register_reggroup_p.
11300
11301 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11302
11303         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11304         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11305         set_gdbarch_num_pseudo_regs.
11306
11307 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11308
11309         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11310         Remove arg prefixname, add do_set and do_show.
11311         Add member functions set_list and show_list.
11312         * cli/cli-style.c (class cli_style_option): Update accordingly.
11313         (style_set_list): Move to file scope.
11314         (style_show_list): Likewise.
11315         (set_style): Call help_list.
11316         (show_style): Call cmd_show_list.
11317         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11318         Update to use the new macro.
11319
11320 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11321
11322         * ada-lang.c (_initialize_ada_language): Expand the help text
11323         for the "catch exception" command.
11324
11325 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11326
11327         * symtab.c (matching_obj_sections): Initialize obj,
11328         declare it closer to its usage.
11329
11330 2019-01-10  Tom Tromey  <tom@tromey.com>
11331
11332         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11333         (basic_inf_threads_range): Remove.
11334         (inf_threads_range, inf_non_exited_threads_range)
11335         (safe_inf_threads_range): Use next_adapter.
11336
11337 2019-01-10  Keith Seitz  <keiths@redhat.com>
11338
11339         PR gdb/23712
11340         PR symtab/23010
11341         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11342         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11343
11344 2019-01-10  Keith Seitz  <keiths@redhat.com>
11345
11346         PR gdb/23712
11347         PR symtab/23010
11348         * dictionary.c (pending_to_vector): Remove.
11349         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11350         Remove _1 suffix, replacing functions of the same name.  Update
11351         all callers.
11352         (dict_create_hashed, dict_create_hashed_expandable)
11353         (dict_create_linear, dict_create_linear_expandable, dict_free)
11354         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11355         Make functions static.
11356
11357 2019-01-10  Keith Seitz  <keiths@redhat.com>
11358
11359         PR gdb/23712
11360         PR symtab/23010
11361         * dictionary.h (struct dictionary): Replace declaration with
11362         multidictionary.
11363         (dict_create_hashed, dict_create_hashed_expandable)
11364         (dict_create_linear, dict_create_linear_expandable)
11365         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11366         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11367         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11368         taking multidictionary argument.
11369         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11370         * block.h (struct block) <dict>: Change to multidictionary
11371         and rename `multidict'.
11372         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11373         symmisc.c: Update all dictionary references to multidictionary.
11374
11375 2019-01-10  Keith Seitz  <keiths@redhat.com>
11376
11377         PR gdb/23712
11378         PR symtab/23010
11379         * dictionary.c: Include unordered_map.
11380         (pending_to_vector): New function.
11381         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11382         Rewrite the non-"_1" functions to take vector instead
11383         of linked list.
11384         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11385         "new" _1 versions of the same name.
11386         (multidictionary): Define.
11387         (std::hash<enum language): New definition.
11388         (collate_pending_symbols_by_language, mdict_create_hashed)
11389         (mdict_create_hashed_expandable, mdict_create_linear)
11390         (mdict_create_linear_expandable, mdict_free)
11391         (find_language_dictionary, create_new_language_dictionary)
11392         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11393         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11394         (mdict_size, mdict_empty): New functions.
11395         * dictionary.h (mdict_iterator): Define.
11396
11397 2019-01-10  Pedro Alves  <palves@redhat.com>
11398
11399         * breakpoint.c (read_uploaded_action)
11400         (create_tracepoint_from_upload): Adjust to use
11401         gdb::unique_xmalloc_ptr.
11402         * ctf.c (ctf_write_uploaded_tp):
11403         (SET_ARRAY_FIELD): Use emplace_back.
11404         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11405         * tracefile-tfile.c (tfile_write_uploaded_tp):
11406         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11407         gdb::unique_xmalloc_ptr.
11408         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11409         at_string, cond_string, cmd_strings>: Replace char pointers
11410         with gdb::unique_xmalloc_ptr.
11411
11412 2019-01-10  Pedro Alves  <palves@redhat.com>
11413
11414         * solib-target.c (library_list_start_library): Don't xstrdup name.
11415
11416 2019-01-10  Pedro Alves  <palves@redhat.com>
11417
11418         * mdebugread.c (parse_partial_symbols): Use
11419         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11420
11421 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11422
11423         * linux-fork.c (scoped_switch_fork_info)
11424         <~scoped_switch_fork_info>: Fix incorrect variable name.
11425
11426 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11427
11428         * linux-fork.c (scoped_switch_fork_info)
11429         <scoped_switch_fork_info>: Make explicit.
11430         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11431
11432 2019-01-10  Tom Tromey  <tom@tromey.com>
11433
11434         * objfiles.h (objfile::reset_psymtabs): Update.
11435         * objfiles.c (objfile::objfile): Update.
11436         * psymtab.h (psymtab_storage::obstack): Update.
11437         (psymtab_storage::m_obstack): Use gdb::optional.
11438         (class psymtab_storage): Update comment.  Remove objfile
11439         parameter.
11440         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11441
11442 2019-01-10  Tom Tromey  <tom@tromey.com>
11443
11444         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11445         <free_psymtabs>: Now private.
11446         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11447         (allocate_psymtab): Use new method.
11448
11449 2019-01-10  Tom Tromey  <tom@tromey.com>
11450
11451         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11452         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11453         * mdebugread.c (parse_partial_symbols): Use
11454         allocate_dependencies.
11455         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11456         allocate_dependencies.
11457         (process_psymtab_comp_unit_reader)
11458         (build_type_psymtab_dependencies): Likewise.
11459         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11460
11461 2019-01-10  Tom Tromey  <tom@tromey.com>
11462
11463         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11464         PSYMBOL_SET_LANGUAGE.
11465         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11466
11467 2019-01-10  Tom Tromey  <tom@tromey.com>
11468
11469         * psymtab.h (psymtab_storage::obstack): New method.
11470         <m_obstack>: Rename from obstack; now private.
11471         * psymtab.c (psymtab_storage): Update.
11472         * dwarf2read.c (create_addrmap_from_index)
11473         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11474         Update.
11475
11476 2019-01-10  Tom Tromey  <tom@tromey.com>
11477
11478         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11479         * objfiles.h (objfile::reset_psymtabs): New method.
11480
11481 2019-01-10  Tom Tromey  <tom@tromey.com>
11482
11483         * symmisc.c (print_symbol_bcache_statistics): Update.
11484         (print_objfile_statistics): Update.
11485         * symfile.c (reread_symbols): Update.
11486         * psymtab.h (class psymtab_storage): New.
11487         * psymtab.c (psymtab_storage): New constructor.
11488         (~psymtab_storage): New destructor.
11489         (require_partial_symbols): Update.
11490         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11491         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11492         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11493         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11494         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11495         (start_psymtab_common, end_psymtab_common)
11496         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11497         (allocate_psymtab): Update.
11498         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11499         Update.
11500         (dump_psymtab_addrmap, maintenance_print_psymbols)
11501         (maintenance_check_psymtabs): Update.
11502         (class objfile_psymtabs): Move to objfiles.h.
11503         * psympriv.h (discard_psymtab): Now inline.
11504         (psymtab_discarder::psymtab_discarder): Update.
11505         (psymtab_discarder::~psymtab_discarder): Update.
11506         (ALL_OBJFILE_PSYMTABS): Rewrite.
11507         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11508         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11509         Remove fields.
11510         <partial_symtabs>: New field.
11511         (class objfile_psymtabs): Move from psymtab.h.  Update.
11512         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11513         psymbol_cache.
11514         (objfile::~objfile): Don't destroy psymbol_cache.
11515         * mdebugread.c (parse_partial_symbols): Update.
11516         * dwarf2read.c (create_addrmap_from_index)
11517         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11518         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11519         (add_partial_subprogram, dwarf2_ranges_read): Update.
11520         * dwarf-index-write.c (write_address_map)
11521         (write_one_signatured_type, recursively_write_psymbols)
11522         (class debug_names, class debug_names, write_psymtabs_to_index):
11523         Update.
11524
11525 2019-01-10  Tom Tromey  <tom@tromey.com>
11526
11527         * symtab.h (SYMBOL_SET_NAMES): Update.
11528         (symbol_set_names): Update.
11529         (MSYMBOL_SET_NAMES): Update.
11530         * symtab.c (symbol_set_names): Change argument to be an
11531         objfile_per_bfd_storage.
11532         * psymtab.c (add_psymbol_to_bcache): Update.
11533         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11534
11535 2019-01-10  Tom Tromey  <tom@tromey.com>
11536
11537         * symtab.c (create_demangled_names_hash): Change argument to be an
11538         objfile_per_bfd_storage.
11539         (symbol_set_names): Update.
11540
11541 2019-01-10  Tom Tromey  <tom@tromey.com>
11542
11543         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11544         init_psymbol_list.
11545         * psymtab.c (init_psymbol_list): Do nothing if already called.
11546         * psympriv.h (init_psymbol_list): Add comment.
11547         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11548         init_psymbol_list.
11549         * dbxread.c (dbx_symfile_read): Unconditionally call
11550         init_psymbol_list.
11551
11552 2019-01-10  Tom Tromey  <tom@tromey.com>
11553
11554         * xcoffread.c (scan_xcoff_symtab): Update.
11555         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11556         "where".
11557         * mdebugread.c (parse_partial_symbols)
11558         (handle_psymbol_enumerators): Update.
11559         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11560         * dbxread.c (read_dbx_symtab): Update.
11561         * psympriv.h (psymbol_placement): New enum.
11562         (add_psymbol_to_list): Update.
11563
11564 2019-01-10  Tom Tromey  <tom@tromey.com>
11565
11566         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11567         static_psymbols parameters.
11568         (scan_xcoff_symtab): Update.
11569         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11570         static_psymbols parameters.
11571         * psympriv.h (start_psymtab_common): Update.
11572         * mdebugread.c (parse_partial_symbols): Update.
11573         * dwarf2read.c (create_partial_symtab): Update.
11574         * dbxread.c (read_dbx_symtab): Update.
11575         (start_psymtab): Remove global_psymbols and static_psymbols
11576         parameters.
11577
11578 2019-01-10  Tom Tromey  <tom@tromey.com>
11579
11580         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11581         * psymtab.c (allocate_psymtab): Add comment.
11582         * psympriv.h (allocate_psymtab): Add comment.
11583         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11584         initializations.
11585         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11586
11587 2019-01-10  Tom Tromey  <tom@tromey.com>
11588
11589         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11590         Don't declare.
11591         * mipsread.c: Include mdebugread.h.
11592         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11593         Declare.
11594         * elfread.c: Include mdebugread.h.
11595
11596 2019-01-09  Tom Tromey  <tom@tromey.com>
11597
11598         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11599         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11600         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11601         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11602         (psym_lookup_symbol, psym_find_last_source_symtab)
11603         (psym_forget_cached_source_info, psym_print_stats)
11604         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11605         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11606         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11607         (psym_find_compunit_symtab_by_address)
11608         (maintenance_print_psymbols, maintenance_info_psymtabs)
11609         (maintenance_check_psymtabs): Use ranged for.
11610         * psymtab.h (class objfile_psymtabs): New.
11611         (require_partial_symbols): Return objfile_psymtabs.
11612         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11613
11614 2019-01-09  Tom Tromey  <tom@tromey.com>
11615
11616         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11617         (find_pc_mapped_section, list_overlays_command)
11618         (map_overlay_command, unmap_overlay_command)
11619         (simple_overlay_update): Use all_objfiles.
11620         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11621         * printcmd.c (info_symbol_command): Use all_objfiles.
11622         * objfiles.h (ALL_OBJSECTIONS): Remove.
11623         * maint.c (maintenance_translate_address): Use all_objfiles.
11624         * gcore.c (gcore_create_callback): Use all_objfiles.
11625         (objfile_find_memory_regions): Likewise.
11626
11627 2019-01-09  Tom Tromey  <tom@tromey.com>
11628
11629         * symtab.c (find_line_symtab, info_sources_command)
11630         (make_source_files_completion_list): Use objfile_compunits.
11631         * source.c (select_source_symtab): Use objfile_compunits.
11632         * objfiles.h (struct objfile): Update comment.
11633         (ALL_OBJFILES): Remove.
11634         (ALL_FILETABS): Remove.
11635         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11636         objfile_compunits.
11637
11638 2019-01-09  Tom Tromey  <tom@tromey.com>
11639
11640         * symmisc.c (print_objfile_statistics, dump_objfile)
11641         (maintenance_print_symbols): Use compunit_filetabs.
11642         * source.c (forget_cached_source_info_for_objfile): Use
11643         compunit_filetabs.
11644         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11645         (ALL_FILETABS): Use compunit_filetabs.
11646         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11647         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11648
11649 2019-01-09  Tom Tromey  <tom@tromey.com>
11650
11651         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11652         (compunit_filetabs): New.
11653         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11654         compunit_filetabs.
11655         (info_sources_command, make_source_files_completion_list): Remove
11656         declaration.
11657         * symmisc.c (print_objfile_statistics, dump_objfile)
11658         (maintenance_print_symbols): Remove declaration.
11659         (maintenance_info_symtabs): Use compunit_filetabs.
11660         (maintenance_info_line_tables): Likewise.
11661         * source.c (select_source_symtab): Change local variable name.
11662         (forget_cached_source_info_for_objfile): Remove declaration.
11663         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11664         * objfiles.c (objfile_relocate1): Remove declaration.
11665         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11666         declaration.
11667         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11668         * coffread.c (coff_symtab_read): Remove declaration.
11669         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11670         compunit_filetabs.
11671
11672 2019-01-09  Tom Tromey  <tom@tromey.com>
11673
11674         * symtab.c (lookup_objfile_from_block)
11675         (find_pc_sect_compunit_symtab, search_symbols)
11676         (default_collect_symbol_completion_matches_break_on): Use
11677         objfile_compunits.
11678         * objfiles.h (ALL_COMPUNITS): Remove.
11679         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11680         * cp-support.c (add_symbol_overload_list_qualified): Use
11681         objfile_compunits.
11682         * ada-lang.c (ada_collect_symbol_completion_matches)
11683         (ada_add_global_exceptions): Use objfile_compunits.
11684
11685 2019-01-09  Tom Tromey  <tom@tromey.com>
11686
11687         * source.c (select_source_symtab)
11688         (forget_cached_source_info_for_objfile): Remove declaration.
11689         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11690         declaration.
11691         * maint.c (count_symtabs_and_blocks): Remove declaration.
11692         * cp-support.c (add_symbol_overload_list_qualified): Remove
11693         declaration.
11694         * coffread.c (coff_symtab_read): Remove declaration.
11695         * symtab.c (lookup_symbol_in_objfile_symtabs)
11696         (basic_lookup_transparent_type_1): Use objfile_compunits.
11697         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11698         (info_sources_command, search_symbols)
11699         (default_collect_symbol_completion_matches_break_on)
11700         (make_source_files_completion_list): Remove declaration.
11701         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11702         (ada_collect_symbol_completion_matches)
11703         (ada_add_global_exceptions): Remove declaration.
11704         * linespec.c (iterate_over_all_matching_symtabs): Use
11705         objfile_compunits.
11706         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11707         (class objfile_compunits): New.
11708         (ALL_COMPUNITS): Use objfile_compunits.
11709         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11710         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11711         objfile_compunits.
11712         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11713
11714 2019-01-09  Tom Tromey  <tom@tromey.com>
11715
11716         * symtab.c (search_symbols)
11717         (default_collect_symbol_completion_matches_break_on): Use
11718         objfile_msymbols.
11719         * ada-lang.c (ada_lookup_simple_minsym)
11720         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11721         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11722         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11723         objfile_msymbols.
11724         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11725         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11726         * objc-lang.c (find_methods): Use objfile_msymbols.
11727         (info_selectors_command, info_classes_command): Likewise.
11728         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11729         * objfiles.h (class objfile_msymbols): New.
11730         (ALL_OBJFILE_MSYMBOLS): Remove.
11731         (ALL_MSYMBOLS): Remove.
11732
11733 2019-01-09  Tom Tromey  <tom@tromey.com>
11734
11735         * common/next-iterator.h (next_adapter): Add Iterator template
11736         parameter.
11737         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11738         (class all_objfiles_safe): New.
11739         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11740         * objfiles.c (put_objfile_before): Update comment.
11741         (add_separate_debug_objfile): Likewise.
11742         (free_all_objfiles): Use all_objfiles_safe.
11743         (objfile_purge_solibs): Likewise.
11744
11745 2019-01-09  Tom Tromey  <tom@tromey.com>
11746
11747         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11748         (expand_symtab_containing_pc, lookup_static_symbol)
11749         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11750         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11751         all_objfiles.
11752         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11753         * breakpoint.c (create_overlay_event_breakpoint)
11754         (create_longjmp_master_breakpoint)
11755         (create_std_terminate_master_breakpoint)
11756         (create_exception_master_breakpoint): Use all_objfiles.
11757         * linux-thread-db.c (try_thread_db_load_from_pdir)
11758         (has_libpthread): Use all_objfiles.
11759         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11760         * linespec.c (iterate_over_all_matching_symtabs)
11761         (search_minsyms_for_name): Use all_objfiles.
11762         * maint.c (maintenance_info_sections): Use all_objfiles.
11763         * main.c (captured_main_1): Use all_objfiles.
11764         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11765         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11766         * guile/scm-pretty-print.c
11767         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11768         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11769         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11770         (maintenance_print_msymbols): Use all_objfiles.
11771         * source.c (select_source_symtab): Use all_objfiles.
11772         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11773         * symfile.c (remove_symbol_file_command)
11774         (expand_symtabs_matching, map_symbol_filenames): Use
11775         all_objfiles.
11776         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11777         all_objfiles.
11778         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11779         * objc-lang.c (find_methods): Use all_objfiles.
11780         * objfiles.c (have_partial_symbols, have_full_symbols)
11781         (have_minimal_symbols, qsort_cmp)
11782         (default_iterate_over_objfiles_in_search_order): Use
11783         all_objfiles.
11784         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11785         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11786         (maintenance_check_psymtabs): Use all_objfiles.
11787         (ALL_PSYMTABS): Remove.
11788         * compile/compile-object-run.c (do_module_cleanup): Use
11789         all_objfiles.
11790         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11791         * cp-support.c (add_symbol_overload_list_qualified): Use
11792         all_objfiles.
11793         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11794         Use all_objfiles.
11795         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11796         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11797         all_objfiles.
11798         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11799         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11800         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11801         Uses all_objfiles.
11802         * solib.c (solib_read_symbols): Use all_objfiles
11803
11804 2019-01-09  Tom Tromey  <tom@tromey.com>
11805
11806         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11807         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11808         all_objfiles.
11809         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11810         * symmisc.c (print_symbol_bcache_statistics)
11811         (print_objfile_statistics, maintenance_print_objfiles)
11812         (maintenance_info_symtabs, maintenance_check_symtabs)
11813         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11814         all_objfiles.
11815         * source.c (forget_cached_source_info): Use all_objfiles.
11816         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11817         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11818         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11819         * objfiles.c (update_section_map): Use all_objfiles.
11820         (shared_objfile_contains_address_p): Likewise.
11821         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11822         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11823
11824 2019-01-09  Tom Tromey  <tom@tromey.com>
11825
11826         * common/next-iterator.h: New file.
11827         * objfiles.h (class all_objfiles): New.
11828         (struct objfile_iterator): New.
11829
11830 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11831
11832         * NEWS: Move the description of the changed "frame", "select-frame",
11833          and "info frame" commands to the Changed commands section.
11834
11835 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11836
11837         * gdbtypes.c (check_stub_method_group): Remove handling of old
11838         mangling schemes.
11839         * linespec.c (find_methods): Likewise.
11840         * stabsread.c (read_member_functions): Likewise.
11841         * valops.c (search_struct_method): Likewise.
11842         (value_struct_elt_for_reference): Likewise.
11843         * NEWS: Mention this change.
11844
11845 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11846
11847         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11848         print_source_lines.
11849         * source.c (print_source_lines_base): Update line number check.
11850         (print_source_lines): New function.
11851         (source_lines_range::source_lines_range): New function.
11852         * source.h (class source_lines_range): New class.
11853         (print_source_lines): New declaration.
11854
11855 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11856
11857         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11858
11859 2019-01-08  Tom Tromey  <tom@tromey.com>
11860             Simon Marchi  <simon.marchi@ericsson.com>
11861
11862         PR gdb/24060
11863         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11864         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11865         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11866         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11867         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11868         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11869
11870 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11871
11872         * source.c (select_source_symtab): Move header comment to
11873         declaration in source.h.
11874         (forget_cached_source_info_for_objfile): Likewise.
11875         (forget_cached_source_info): Likewise.
11876         (identify_source_line): Likewise.
11877         * source.h (identify_source_line): Move declaration from symtab.h
11878         and add comment from source.c
11879         (print_source_lines): Likewise.
11880         (forget_cached_source_info_for_objfile): Likewise.
11881         (forget_cached_source_info): Likewise.
11882         (select_source_symtab): Likewise.
11883         (enum print_source_lines_flag): Move definition from symtab.h.
11884         * symtab.h (identify_source_line): Move declaration to source.h.
11885         (print_source_lines): Likewise.
11886         (forget_cached_source_info_for_objfile): Likewise.
11887         (forget_cached_source_info): Likewise.
11888         (select_source_symtab): Likewise.
11889         (enum print_source_lines_flag): Move definition to source.h.
11890         * tui/tui-hooks.c: Add 'source.h' include.
11891
11892 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11893
11894         * source.c (print_source_lines_base): Handle requests to print
11895         reverse line number sequences, and guard against empty lines
11896         string.
11897
11898 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11899
11900         * source.c (print_source_lines_base): Fix skip of '\r' if next
11901         character is '\n'.
11902
11903 2019-01-06  Tom Tromey  <tom@tromey.com>
11904
11905         * c-exp.y (struct c_parse_state) <macro_original_text,
11906         expansion_obstack>: New member.
11907         (macro_original_text, expansion_obstack): Remove globals.
11908         (scan_macro_expansion, scanning_macro_expansion)
11909         (finished_macro_expansion): Update.
11910         (scan_macro_cleanup): Remove.
11911         (yylex, c_parse): Update.
11912
11913 2019-01-06  Tom Tromey  <tom@tromey.com>
11914
11915         * c-exp.y (struct c_parse_state) <strings>: New member.
11916         (operator_stoken): Update.
11917
11918 2019-01-06  Tom Tromey  <tom@tromey.com>
11919
11920         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11921         (union type_stack_elt) <typelist_val>: Now a pointer to
11922         std::vector.
11923         (type_stack_cleanup): Don't declare.
11924         (push_typelist): Update.
11925         * parse.c (pop_typelist): Return a std::vector.
11926         (push_typelist): Take a std::vector.
11927         (follow_types): Update.  Do not free args.
11928         (type_stack_cleanup): Remove.
11929         * c-exp.y (struct c_parse_state): New.
11930         (cpstate): New global.
11931         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11932         (nonempty_typelist): Update.
11933         (func_mod): Create a new vector.
11934         (c_parse): Create a c_parse_state.
11935         (check_parameter_typelist): Do not delete params.
11936         (function_method): Update.  Do not delete type_list.
11937
11938 2019-01-06  Tom Tromey  <tom@tromey.com>
11939
11940         PR gdb/28155:
11941         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11942         check_typedef.
11943         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11944         (print_return_value): Likewise.
11945
11946 2019-01-05  Tom Tromey  <tom@tromey.com>
11947
11948         * contrib/cleanup_check.py: Remove.
11949         * contrib/gcc-with-excheck: Remove.
11950         * contrib/exsummary.py: Remove.
11951         * contrib/excheck.py: Remove.
11952
11953 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11954
11955         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11956         NULL. Initialize tpprev to NULL instead of assigning it
11957         to NULL on the next statement.
11958         * windows-nat.c (windows_delete_thread): Remove check for
11959         main_thread_id before printing thread exit notifications.
11960         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11961         Remove thread ID check against main_thread_id.
11962         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11963         windows_delete_thread.
11964         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11965
11966 2019-01-04  Tom Tromey  <tom@tromey.com>
11967
11968         * compile/compile.c (_initialize_compile): Use upper case for
11969         metasyntactic variables.
11970         * symmisc.c (_initialize_symmisc): Use upper case for
11971         metasyntactic variables.
11972         * psymtab.c (_initialize_psymtab): Use upper case for
11973         metasyntactic variables.
11974         * demangle.c (demangle_command): Use upper case for metasyntactic
11975         variables.
11976         (_initialize_demangler): Likewise.
11977         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11978         variables.
11979
11980 2019-01-03  Tom Tromey  <tom@tromey.com>
11981
11982         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11983
11984 2019-01-03  Tom Tromey  <tom@tromey.com>
11985
11986         * python/py-symtab.c (salpy_str): Update.
11987         (struct salpy_sal_object) <symtab>: Now a PyObject.
11988         (salpy_dealloc): Update.
11989         (del_objfile_sal): Use gdbpy_ref.
11990
11991 2019-01-03  Tom Tromey  <tom@tromey.com>
11992
11993         * python/py-type.c (convert_field): Use new_reference.  Return
11994         gdbpy_ref.
11995         (make_fielditem): Return gdbpy_ref.
11996         (typy_fields): Update.
11997         (typy_getitem): Update.
11998         (field_name): Return gdbpy_ref.  Use new_reference.
11999         (typy_iterator_iternext): Update.
12000
12001 2019-01-03  Tom Tromey  <tom@tromey.com>
12002
12003         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12004
12005 2019-01-03  Tom Tromey  <tom@tromey.com>
12006
12007         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12008         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12009         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12010         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12011         (pspy_set_type_printers): Likewise.
12012         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12013         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12014         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12015         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12016         (objfpy_set_type_printers): Likewise.
12017
12018 2019-01-03  Tom Tromey  <tom@tromey.com>
12019
12020         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12021         (gdbpy_print_stack): Use gdbpy_err_fetch.
12022         * python/python-internal.h (class gdbpy_err_fetch): New class.
12023         (class gdbpy_enter) <m_error_type, m_error_value,
12024         m_error_traceback>: Remove.
12025         <m_error>: New member.
12026         (gdbpy_exception_to_string): Don't declare.
12027         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12028         * python/py-value.c (convert_value_from_python): Use
12029         gdbpy_err_fetch.
12030         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12031         gdbpy_exception_to_string.
12032         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12033         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12034         gdbpy_err_fetch.
12035
12036 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12037
12038         * linux-nat.c (delete_lwp_cleanup): Delete.
12039         (struct lwp_deleter): New struct.
12040         (lwp_info_up): New typedef.
12041         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12042         lwp_info_up.
12043
12044 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12045
12046         * linux-fork.c (class scoped_switch_fork_info): New class.
12047         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12048
12049 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12050
12051         * valops.c (find_overload_match): Remove use of null_cleanup, and
12052         calls to do_cleanups.
12053
12054 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12055
12056         * compile/compile-cplus-types.c
12057         (compile_cplus_instance::decl_name): Handle changes to
12058         cp_func_name.
12059         * cp-support.c (cp_func_name): Update header comment, update
12060         return type.
12061         * cp-support.h (cp_func_name): Update return type in declaration.
12062         * valops.c (find_overload_match): Move temp_func local to top
12063         level of function and change its type.  Use temp_func to hold and
12064         delete temporary string obtained from cp_func_name.
12065
12066 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12067
12068         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12069         gdb::char_vector, remove cleanup, and update uses of `msg`.
12070
12071 2019-01-03  Jim Wilson  <jimw@sifive.com>
12072
12073         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12074
12075 2019-01-02  Tom Tromey  <tom@tromey.com>
12076
12077         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12078         (tdesc_parse_xml): Remove cleanups.
12079         * target-descriptions.h (make_cleanup_free_target_description):
12080         Don't declare.
12081         (target_desc_deleter): New struct.
12082         (target_desc_up): New typedef.
12083         * target-descriptions.c (target_desc_deleter::operator()): Rename
12084         from free_target_description.
12085         (make_cleanup_free_target_description): Remove.
12086
12087 2019-01-02  Tom Tromey  <tom@tromey.com>
12088
12089         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12090         constructor, destructor.
12091         (linespec_parser): Remove typedef.
12092         (~linespec_parser): Rename from linespec_parser_delete.
12093         (linespec_lex_to_end, linespec_complete_label)
12094         (linespec_complete): Update.
12095         (decode_line_full): Remove cleanups.
12096         (decode_line_1): Update.
12097
12098 2019-01-02  Tom Tromey  <tom@tromey.com>
12099
12100         * python/python-internal.h (inferior_to_inferior_object): Change
12101         return type.
12102         * python/py-exitedevent.c (create_exited_event_object): Update.
12103         * python/py-inferior.c (inferior_to_inferior_object): Return
12104         gdbpy_ref.
12105         (python_new_inferior, python_inferior_deleted)
12106         (thread_to_thread_object, delete_thread_object)
12107         (build_inferior_list, gdbpy_selected_inferior): Update.
12108         * python/py-infthread.c (create_thread_object): Update.  Also fail
12109         if inferior_to_inferior_object fails.
12110
12111 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12112
12113         * inferior.h (class inferior) <displaced_step_state>: New field.
12114         * infrun.h (struct displaced_step_state): Move here from
12115         infrun.c.  Initialize fields, add constructor.
12116         <inf>: Remove field.
12117         <reset>: New method.
12118         * infrun.c (struct displaced_step_inferior_state): Move to
12119         infrun.h.
12120         (displaced_step_inferior_states): Remove.
12121         (get_displaced_stepping_state): Adust.
12122         (displaced_step_in_progress_any_inferior): Adjust.
12123         (displaced_step_in_progress_thread): Adjust.
12124         (displaced_step_in_progress): Adjust.
12125         (add_displaced_stepping_state): Remove.
12126         (get_displaced_step_closure_by_addr): Adjust.
12127         (remove_displaced_stepping_state): Remove.
12128         (infrun_inferior_exit): Call displaced_step_state.reset.
12129         (use_displaced_stepping): Don't check for NULL.
12130         (displaced_step_prepare_throw): Call
12131         get_displaced_stepping_state.
12132         (displaced_step_fixup): Don't check for NULL.
12133         (prepare_for_detach): Don't check for NULL.
12134
12135 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12136
12137         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12138          in case of call that did not complete.
12139
12140 2019-01-02  Andrey Utkin  <autkin@undo.io>
12141
12142         * symfile.c (find_separate_debug_file): Fix search of debug files for
12143         remote debuggee.
12144
12145 2019-01-02  Tom Tromey  <tom@tromey.com>
12146
12147         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12148         indentation.
12149         * python/py-frame.c (frapy_older): Remove cast.
12150         (frapy_newer): Likewise.
12151         * python/py-breakpoint.c (local_setattro): Remove cast.
12152         * python/py-arch.c (archpy_name): Remove local variable.
12153         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12154
12155 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12156
12157         * unittests/basic_string_view/element_access/char/empty.cc:
12158         Fix year range in copyright header.
12159
12160 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12161
12162         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12163         Delete.
12164         <operator==>: Update with for removed field.
12165         <hash>: Likewise.
12166         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12167         <isa_features>: ...this.
12168         <abi_features>: New field.
12169         (riscv_isa_flen): Update comment.
12170         (riscv_abi_xlen): New declaration.
12171         (riscv_abi_flen): New declaration.
12172         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12173         isa_features.
12174         (riscv_abi_xlen): New function.
12175         (riscv_isa_flen): Update to get answer from isa_features.
12176         (riscv_abi_flen): New function.
12177         (riscv_has_fp_abi): Update to get answer from abi_features.
12178         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12179         xlen and flen.
12180         (riscv_call_info) <xlen, flen>: Update comment.
12181         (riscv_call_arg_struct): Remove invalid assertions
12182         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12183         is removed.
12184         (riscv_gdbarch_init): Gather isa features and abi features
12185         separately, ensure both match on the gdbarch when reusing an old
12186         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12187         a target with 64-bit float hardware.
12188
12189 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12190
12191         * source.c (search_command_helper): Stop reverse search
12192         when line 1 has been searched.
12193
12194 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12195
12196         * record-full.c (record_full_base_target::close): Rewrite
12197         record_full_core_buf_list free logic.
12198
12199 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12200
12201         * break-catch-syscall.c (print_one_catch_syscall): xfree
12202         the last text.
12203
12204 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12205
12206         * top.c (print_gdb_version): Update Copyright year in version
12207         message.
12208
12209 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12210
12211         Update copyright year range in all GDB files.
12212
12213 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12214
12215         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12216
12217 For older changes see ChangeLog-2018.
12218 \f
12219 Local Variables:
12220 mode: change-log
12221 left-margin: 8
12222 fill-column: 74
12223 version-control: never
12224 coding: utf-8
12225 End:
12226