gdb/ChangeLog

   1 2019-10-23  Tom Tromey  <tom@tromey.com>
   2
   3         * Makefile.in (READLINE_DIR): Update.
   4
   5 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
   6
   7         * infcall.c (call_function_by_hand_dummy): Fix the function
   8         comment.  And extract out a code section into...
   9         (reserve_stack_space): ...this new function.
  10
  11 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  12
  13         * infcall.c (value_arg_coerce): Remove an unused parameter.
  14         (call_function_by_hand_dummy): Update the call to
  15         'value_arg_coerce'.
  16
  17 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  18
  19         * infcall.c (call_function_by_hand_dummy): Refactor.
  20
  21 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  22
  23         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
  24
  25 2019-10-23  Tom Tromey  <tom@tromey.com>
  26
  27         * configure: Rebuild.
  28         * configure.ac: Don't check for sigprocmask.
  29         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
  30
  31 2019-10-23  Tom Tromey  <tom@tromey.com>
  32
  33         * configure: Rebuild.
  34         * acinclude.m4: Use m4_include, not sinclude.
  35
  36 2019-10-23  Tom de Vries  <tdevries@suse.de>
  37
  38         PR breakpoints/24687
  39         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
  40
  41 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  42
  43         * symtab.c (struct demangled_name_entry) <language>: Change from
  44         bitfield to regular variable.
  45
  46 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  47
  48         * symtab.c (struct demangled_name_entry): Add a constructor.
  49         (free_demangled_name_entry): New function to call the destructor
  50         for demangled_name_entry.
  51         (create_demangled_names_hash): Pass free_demangled_name_entry to
  52         htab_create_alloc.
  53         (symbol_set_names): Call placement new for demangled_name_entry.
  54         * utils.c: No longer include xxhash.h here, now that fast_hash
  55         is inlined in the header.
  56         * utils.h: Instead, include it here.
  57
  58 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  59
  60         * Makefile.in: Link with libxxhash.
  61         * config.in: Regenerate.
  62         * configure: Regenerate.
  63         * configure.ac: Search for libxxhash.
  64         * utils.c (fast_hash): Use xxhash if present.
  65
  66 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  67
  68         * utils.h (fast_hash): New function.
  69         * symtab.c (hash_demangled_name_entry): Call new function
  70         fast_hash.
  71
  72 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  73
  74         * symtab.c (struct demangled_name_entry): Change type of mangled
  75         to gdb::string_view. Also adds a constructor that takes the
  76         mangled name.
  77         (hash_demangled_name_entry): Update.
  78         (eq_demangled_name_entry): Update.
  79         (free_demangled_name_entry): New function to call the destructor
  80         now that this is not a POD anymore.
  81         (create_demangled_names_hash): Pass free_demangled_name_entry to
  82         htab_create_alloc.
  83         (symbol_set_names): Update.
  84
  85 2019-10-21  Ali Tamur  <tamu@google.com>
  86
  87         * dwarf2read.c (dir_index): Change type.
  88         (file_name_index): Likewise.
  89         (line_header::include_dir_at): Change comment and implementation on
  90         whether it is DWARF 5.
  91         (line_header::is_valid_file_index): New function.
  92         (line_header::file_name_at): Change comment and implementation on
  93         whether it is DWARF 5.
  94         (line_header::file_names): Change to private field renamed as
  95         m_file_names and introduce a new accessor method.
  96         (line_header::file_names_size): New method.
  97         (line_header::include_dirs): Change to private field and rename as
  98         m_include_dirs.
  99         (dw2_get_file_names_reader): Define local var at a smaller scope and
 100         reflect API change.
 101         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 102         (process_structure_scope): Likewise.
 103         (line_header::add_include_dir): Change message and reflect renaming.
 104         (line_header::add_file_name): Likewise.
 105         (read_formatted_entries): Handle DW_FORM_data16.
 106         (dwarf_decode_line_header): Fix line header length calculation.
 107         (psymtab_include_file_name): Change comment and API.
 108         (lnp_state_machine::m_file): Update comment and reflect type change.
 109         (lnp_state_machine::record_line): Reflect type change.
 110         (dwarf_decode_lines): Reflect API change.
 111         (file_file_name): Likewise.
 112         (file_full_name): Likewise.
 113
 114 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 115
 116         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 117
 118 2019-10-21  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 121
 122 2019-10-21  Tom Tromey  <tom@tromey.com>
 123
 124         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 125         NM_H.   Use AC_CONFIG_LINKS.
 126         * configure: Rebuild.
 127         * Makefile.in (NM_H): New variable.
 128         (generated_files): Add NM_H.  Remove gcore.
 129         (nm.h, stamp-nmh): New targets.
 130
 131 2019-10-20  Tom Tromey  <tom@tromey.com>
 132
 133         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 134         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 135         obsolete comment.
 136         (put_objfile_before): Now static.
 137
 138 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 139
 140         * gdbsupport/common-utils.h (startswith): Change return type to
 141         bool.
 142
 143 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 144
 145         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 146         * breakpoint.c (bp_locations_compare): Rename to...
 147         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 148         (update_global_location_list): Use std::sort instead of qsort.
 149         * buildsym.c (compare_line_numbers): Rename to...
 150         (lte_is_less_than): ...this, and change to std::sort semantics.
 151         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 152         instead of qsort.
 153         * disasm.c (compare_lines): Rename to...
 154         (line_is_less_than): ...this, and change to std::sort semantics.
 155         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 156         of qsort.
 157         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 158         (fde_is_less_than): ...this, and change to std::sort semantics.
 159         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 160         * mdebugread.c (compare_blocks):
 161         (block_is_less_than): ...this, and change to std::sort semantics.
 162         (sort_blocks): Call std::sort instead of qsort.
 163         * objfiles.c (qsort_cmp): Rename to...
 164         (sort_cmp): ...this, and change to std::sort semantics.
 165         (update_section_map): Call std::sort instead of qsort.
 166         * remote.c (compare_pnums): Remove.
 167         (map_regcache_remote_table): Call std::sort instead of qsort.
 168         * utils.c (compare_positive_ints): Remove.
 169         * utils.h (compare_positive_ints): Remove.
 170         * xcoffread.c (compare_lte): Remove.
 171         (arrange_linetable): Call std::sort instead of qsort.
 172
 173 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 174
 175         * symfile.c (init_entry_point_info): Fix typo.
 176         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 177
 178 2019-10-18  Tom de Vries  <tdevries@suse.de>
 179
 180         * aarch64-tdep.c: Fix typos in comments.
 181         * ada-lang.c: Same.
 182         * ada-tasks.c: Same.
 183         * alpha-tdep.c: Same.
 184         * alpha-tdep.h: Same.
 185         * amd64-nat.c: Same.
 186         * amd64-windows-tdep.c: Same.
 187         * arc-tdep.c: Same.
 188         * arc-tdep.h: Same.
 189         * arch-utils.c: Same.
 190         * arm-nbsd-tdep.c: Same.
 191         * arm-tdep.c: Same.
 192         * ax-gdb.c: Same.
 193         * blockframe.c: Same.
 194         * btrace.c: Same.
 195         * c-varobj.c: Same.
 196         * coff-pe-read.c: Same.
 197         * coffread.c: Same.
 198         * cris-tdep.c: Same.
 199         * darwin-nat.c: Same.
 200         * dbxread.c: Same.
 201         * dcache.c: Same.
 202         * disasm.c: Same.
 203         * dtrace-probe.c: Same.
 204         * dwarf-index-write.c: Same.
 205         * dwarf2-frame-tailcall.c: Same.
 206         * dwarf2-frame.c: Same.
 207         * dwarf2read.c: Same.
 208         * eval.c: Same.
 209         * exceptions.c: Same.
 210         * fbsd-tdep.c: Same.
 211         * findvar.c: Same.
 212         * frame.c: Same.
 213         * frv-tdep.c: Same.
 214         * gnu-v3-abi.c: Same.
 215         * go32-nat.c: Same.
 216         * h8300-tdep.c: Same.
 217         * hppa-tdep.c: Same.
 218         * i386-linux-tdep.c: Same.
 219         * i386-tdep.c: Same.
 220         * ia64-libunwind-tdep.c: Same.
 221         * ia64-tdep.c: Same.
 222         * infcmd.c: Same.
 223         * infrun.c: Same.
 224         * linespec.c: Same.
 225         * linux-nat.c: Same.
 226         * linux-thread-db.c: Same.
 227         * machoread.c: Same.
 228         * mdebugread.c: Same.
 229         * mep-tdep.c: Same.
 230         * mn10300-tdep.c: Same.
 231         * namespace.c: Same.
 232         * objfiles.c: Same.
 233         * opencl-lang.c: Same.
 234         * or1k-tdep.c: Same.
 235         * osabi.c: Same.
 236         * ppc-linux-nat.c: Same.
 237         * ppc-linux-tdep.c: Same.
 238         * ppc-sysv-tdep.c: Same.
 239         * printcmd.c: Same.
 240         * procfs.c: Same.
 241         * record-btrace.c: Same.
 242         * record-full.c: Same.
 243         * remote-fileio.c: Same.
 244         * remote.c: Same.
 245         * rs6000-tdep.c: Same.
 246         * s12z-tdep.c: Same.
 247         * score-tdep.c: Same.
 248         * ser-base.c: Same.
 249         * ser-go32.c: Same.
 250         * skip.c: Same.
 251         * sol-thread.c: Same.
 252         * solib-svr4.c: Same.
 253         * solib.c: Same.
 254         * source.c: Same.
 255         * sparc-nat.c: Same.
 256         * sparc-sol2-tdep.c: Same.
 257         * sparc-tdep.c: Same.
 258         * sparc64-tdep.c: Same.
 259         * stabsread.c: Same.
 260         * stack.c: Same.
 261         * symfile.c: Same.
 262         * symtab.c: Same.
 263         * target-descriptions.c: Same.
 264         * target-float.c: Same.
 265         * thread.c: Same.
 266         * utils.c: Same.
 267         * valops.c: Same.
 268         * valprint.c: Same.
 269         * value.c: Same.
 270         * varobj.c: Same.
 271         * windows-nat.c: Same.
 272         * xcoffread.c: Same.
 273         * xstormy16-tdep.c: Same.
 274         * xtensa-tdep.c: Same.
 275
 276 2019-10-17  Tom Tromey  <tromey@adacore.com>
 277
 278         * configure: Rebuild.
 279         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 280         in AC_CONFIG_FILES invocation.
 281         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 282         new-style config.status invocation.
 283
 284 2019-10-17  Tom de Vries  <tdevries@suse.de>
 285
 286         * arm-nbsd-nat.c: Fix typos in comments.
 287         * arm-tdep.c: Same.
 288         * darwin-nat-info.c: Same.
 289         * dwarf2read.c: Same.
 290         * elfread.c: Same.
 291         * event-top.c: Same.
 292         * findvar.c: Same.
 293         * gdbtypes.c: Same.
 294         * hppa-tdep.c: Same.
 295         * i386-tdep.c: Same.
 296         * jit.c: Same.
 297         * main.c: Same.
 298         * mdebugread.c: Same.
 299         * moxie-tdep.c: Same.
 300         * nto-procfs.c: Same.
 301         * osabi.c: Same.
 302         * ppc-linux-tdep.c: Same.
 303         * remote.c: Same.
 304         * riscv-tdep.c: Same.
 305         * s390-tdep.c: Same.
 306         * sh-tdep.c: Same.
 307         * sparc-linux-tdep.c: Same.
 308         * sparc-nat.c: Same.
 309         * stack.c: Same.
 310         * target-descriptions.c: Same.
 311         * top.c: Same.
 312         * varobj.c: Same.
 313
 314 2019-10-16  Tom Tromey  <tom@tromey.com>
 315
 316         * objfiles.h (struct objfile) <original_name>: Now const.
 317
 318 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 319
 320         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 321         pass on to sigsetjmp's second argument.
 322         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 323
 324 2019-10-16  Keith Seitz  <keiths@redhat.com>
 325
 326         PR gdb/23567
 327         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 328         sections whose size is greater than the file size.
 329
 330 2019-10-16  Jim Wilson  <jimw@sifive.com>
 331
 332         * riscv-tdep.c (riscv_gcc_target_options): New.
 333         (riscv_gnu_triplet_regexp): New.
 334         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 335         set_gdbarch_gnu_triplet_regexp.
 336
 337 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 338
 339         * Makefile.in: Add xml-builtin.h.
 340         * features/feature_to_c.sh: Add an include for xml-builtin.h
 341         to ensure that the compiler checks that the types match.
 342         * xml-builtin.h: New file.
 343         * xml-support.c (fetch_xml_builtin): Add missing const.
 344         * xml-support.h: Remove declaration of xml_builtins.
 345
 346 2019-10-16  Tom de Vries  <tdevries@suse.de>
 347
 348         PR tdep/25096
 349         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 350         (amd64_classify_aggregate): ... here.
 351         (amd64_classify_aggregate_field): Handled fiels of nested structs
 352         recursively.
 353
 354 2019-10-16  Tom de Vries  <tdevries@suse.de>
 355
 356         PR tdep/24104
 357         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 358         that handles 'theclass'.
 359
 360 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 361
 362         * linespec.c (decode_digits_ordinary): Update comment.
 363         * make-target-delegates: No longer need to handle VEC case.
 364         * memrange.c (normalize_mem_ranges): Update comment.
 365         * namespace.c (add_using_directive): Update comment.
 366         * objc-lang.c (uniquify_strings): Update comment.
 367         * ppc-linux-nat.c (struct thread_points): Update comment.
 368         * probe.h (find_probes_in_objfile): Update comment.
 369         * target.h (enum flash_preserve_mode): Update comment.
 370         * varobj.c (varobj_restrict_range): Update comment.
 371         * varobj.h (varobj_list_children): Update comment.
 372
 373 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 374
 375         * Makefile.in: Remove references to vec.h and vec.c.
 376         * aarch64-tdep.c: No longer include vec.h.
 377         * ada-lang.c: Likewise.
 378         * ada-lang.h: Likewise.
 379         * arm-tdep.c: Likewise.
 380         * ax.h: Likewise.
 381         * breakpoint.h: Likewise.
 382         * charset.c: Likewise.
 383         * cp-support.h: Likewise.
 384         * dtrace-probe.c: Likewise.
 385         * dwarf2read.c: Likewise.
 386         * extension.h: Likewise.
 387         * gdb_bfd.c: Likewise.
 388         * gdbsupport/gdb_vecs.h: Likewise.
 389         * gdbsupport/vec.c: Remove.
 390         * gdbsupport/vec.h: Remove.
 391         * gdbthread.h: Likewise.
 392         * guile/scm-type.c: Likewise.
 393         * inline-frame.c: Likewise.
 394         * machoread.c: Likewise.
 395         * memattr.c: Likewise.
 396         * memrange.h: Likewise.
 397         * namespace.h: Likewise.
 398         * nat/linux-btrace.h: Likewise.
 399         * osdata.c: Likewise.
 400         * parser-defs.h: Likewise.
 401         * progspace.h: Likewise.
 402         * python/py-type.c: Likewise.
 403         * record-btrace.c: Likewise.
 404         * rust-exp.y: Likewise.
 405         * solib-target.c: Likewise.
 406         * stap-probe.c: Likewise.
 407         * target-descriptions.c: Likewise.
 408         * target-memory.c: Likewise.
 409         * target.h: Likewise.
 410         * varobj.c: Likewise.
 411         * varobj.h: Likewise.
 412         * xml-support.h: Likewise.
 413
 414 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 415
 416         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 417         Update for new std::vector based implementation.
 418         (process_psymtab_comp_unit_reader): Likewise.
 419         (scan_partial_symbols): Likewise.
 420         (recursively_compute_inclusions): Likewise.
 421         (compute_compunit_symtab_includes): Likewise.
 422         (process_imported_unit_die): Likewise.
 423         (queue_and_load_dwo_tu): Likewise.
 424         (follow_die_sig_1): Likewise.
 425         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 426         (typedef dwarf2_per_cu_ptr): Remove.
 427         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 428         function.
 429         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 430         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 431         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 432         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 433         std::vector.
 434
 435 2019-10-15  Tom Tromey  <tromey@adacore.com>
 436
 437         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 438         TID.
 439
 440 2019-10-15  Tom Tromey  <tromey@adacore.com>
 441
 442         * windows-nat.c (windows_nat_target::fetch_registers)
 443         (windows_nat_target::store_registers): Rename "pid" to "tid".
 444
 445 2019-10-15  Tom Tromey  <tromey@adacore.com>
 446
 447         * gdbarch.h, gdbarch.c: Rebuild.
 448         * gdbarch.sh (gcc_target_options): Change return type to
 449         std::string.
 450         * compile/compile.c (get_args): Update.
 451         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 452         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 453         std::string.
 454         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 455         std::string.
 456         * arch-utils.c (default_gcc_target_options): Return std::string.
 457         * arch-utils.h (default_gcc_target_options): Return std::string.
 458         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 459
 460 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 461
 462         * breakpoint.c (breakpoint_chain): Make static.
 463         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 464         of accessing breakpoint_chain.
 465
 466 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 467
 468         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 469         to a gdb::function_view and return value to bool.
 470         * breakpoint.h (iterate_over_breakpoints): Likewise.
 471         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 472         (pop_dummy_frame): Update.
 473         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 474         (gdbscm_breakpoints): Update.
 475         * python/py-breakpoint.c (build_bp_list): Update.
 476         (gdbpy_breakpoints): Update.
 477         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 478         Update.
 479         (bpfinishpy_handle_stop): Update.
 480         (bpfinishpy_handle_exit): Update.
 481         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 482         (svr4_update_solib_event_breakpoints): Update.
 483
 484 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 485
 486         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 487         when unwrapping single-field structs.
 488
 489 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 490
 491         * dwarf2read.c: Remove includes.
 492
 493 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 494
 495         * ui-out.c (ui_out::call_do_message): Silence
 496         -Wformat-nonliteral warning.
 497
 498 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 499
 500         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 501         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 502         include: readline/tilde.h.
 503
 504 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 505
 506         * remote.c (remote_target::get_trace_status): Remove declaration of
 507         trace_regblock_size.
 508
 509 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 510
 511         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 512         (show_user): Remove declaration of cmdlist.
 513         * cli/cli-cmds.h (max_user_call_depth): Declare.
 514         * cli/cli-script.c (execute_user_command): Remove declaration
 515         of max_user_call_depth.
 516
 517 2019-10-11  Jim Wilson  <jimw@sifive.com>
 518
 519         * gdbsupport/print-utils.h (pulongest): Fix comment.
 520         (plongest): Likewise.
 521         (phex): Add missing comment, mention leading zeros.
 522         (phex_nz): Add mention of no leading zeros to comment.
 523
 524         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 525         plongest instead of unsigned long long cast.
 526
 527 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 528
 529         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 530         for external_editor_command and gdbtk_test.
 531
 532 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 533
 534         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 535         * varobj.c (varobjdebug): Move comment to...
 536         * varobj.h (varobjdebug): ...here, and declare.
 537
 538 2019-10-09  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 541         erase_data_content.
 542
 543 2019-10-09  Tom Tromey  <tom@tromey.com>
 544
 545         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 546         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 547         * tui/tui-command.c (tui_cmd_window::resize)
 548         (tui_refresh_cmd_win): Update.
 549         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 550         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 551         * tui/tui-data.c (~tui_gen_win_info): Remove.
 552         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 553         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 554         (tui_redisplay_readline, tui_mld_flush)
 555         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 556         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 557         (tui_data_window::erase_data_content)
 558         (tui_data_item_window::rerender)
 559         (tui_data_item_window::refresh_window): Update.
 560         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 561         (box_win, tui_gen_win_info::make_window)
 562         (tui_gen_win_info::make_visible): Update.
 563         (tui_delete_win): Remove.
 564         * tui/tui-winsource.c
 565         (tui_source_window_base::do_erase_source_content): Update.
 566         (tui_show_source_line, tui_source_window_base::update_tab_width)
 567         (tui_source_window_base::update_exec_info): Update.
 568         * tui/tui-data.h (struct curses_deleter): New.
 569         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 570         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 571
 572 2019-10-09  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 575
 576 2019-10-09  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 579         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 580
 581 2019-10-09  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 584         window height directly.
 585         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 586         declare.
 587         * tui/tui-layout.c (tui_default_win_height): Remove.
 588         (tui_default_win_viewport_height): Remove.
 589
 590 2019-10-09  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui.h: Remove comments.
 593
 594 2019-10-09  Tom de Vries  <tdevries@suse.de>
 595
 596         * python/lib/gdb/printer/bound_registers.py: Use
 597         '^builtin_type_bound128' as regexp argument for
 598         add_builtin_pretty_printer.
 599
 600 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 601
 602         * guile/guile.c (guile_extension_script_ops): Remove forward
 603         declaration and mark as static.
 604         (guile_script_ops): Likewise.
 605         (extension_language_guile): Move further down in the file so
 606         it can reference the definitions for guile_{extension_,}script_ops.
 607
 608 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 609
 610         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 611         except SORTL, DFLTCC, and KDSA.
 612
 613 2019-10-08  Tom Tromey  <tromey@adacore.com>
 614
 615         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 616         (struct safe_symbol_file_add_args): Remove.
 617
 618 2019-10-08  Tom Tromey  <tromey@adacore.com>
 619
 620         * windows-nat.c: Don't include buildsym-legacy.h.
 621
 622 2019-10-08  Tom Tromey  <tromey@adacore.com>
 623
 624         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 625
 626 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 627
 628         * gdbtypes.c (overload_debug): Move comment to header.
 629         * gdbtypes.h (overload_debug): Declare.
 630         * valops.c: Remove declaration of overload_debug, instead
 631         include gdbtypes.h.
 632
 633 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 634
 635         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 636         through _().
 637         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 638         move comment...
 639         * language.h (lang_frame_mismatch_warn): ... here. Also add
 640         declaration.
 641         * top.c (lang_frame_mismatch_warn): Remove declaration.
 642         (check_frame_language_change): Pass lang_frame_mismatch_warn
 643         through _().
 644
 645 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 646
 647         * c-lang.h (vtbl_ptr_name): Declare.
 648         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 649         it from the header.
 650         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 651
 652 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 653
 654         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 655         gdb_static_assert.
 656
 657 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 658
 659         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 660         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 661         * ctfread.c: New file.
 662         * ctfread.h: New file.
 663         * elfread.c: Include ctfread.h.
 664         (struct elfinfo text_p): New member ctfsect.
 665         (elf_locate_sections): Mark CTF section.
 666         (elf_symfile_read): Call elfctf_build_psymtabs.
 667         * Makefile.in (LIBCTF): Add.
 668         (CLIBS): Use it.
 669         (CDEPS): Likewise.
 670         (DIST): Add ctfread.c.
 671
 672 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 673
 674         * ctfread.c (struct nextfield): Renamed to ...
 675         (struct ctf_nextfield): ... this.
 676         (struct field_info): Renamed to ...
 677         (strut ctf_field_info): ... this.
 678         (attach_fields_to_type): Update for renamed structures.
 679         (ctf_add_member_cb): Likewise.
 680         (ctf_add_enum_member_cb): Likewise.
 681         (process_struct_members): Likewise.
 682         (process_enum_type): Likewise.
 683
 684 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 685
 686         * tracectf.h: Rename, was ctf.h.
 687         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 688         * tracefile.c: Likewise.
 689         * tracepoint.c: Remove unused include ctf.h.
 690         * mi/mi-main.c: Likewise.
 691         * Makefile.in Replace ctf.c with tracectf.c.
 692
 693 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 694
 695         * version.in: Change version number to "9.0.50.DATE-git".
 696
 697 2019-10-03  Tom Tromey  <tom@tromey.com>
 698
 699         PR rust/24976:
 700         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 701
 702 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 703
 704         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 705         cp_search_name_hash.
 706         * NEWS: Add entry about nested function support.
 707
 708 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 709             Andrew Burgess  <andrew.burgess@embecosm.com>
 710
 711         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 712         for nested static variables when searchin VAR_DOMAIN.
 713         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 714         global scope, update comment.
 715         (add_partial_subprogram): Call add_partial_subprogram recursively
 716         for nested subroutines when processinng Fortran.
 717         (load_partial_dies): Process the child entities of a subprogram
 718         when processing Fortran.
 719         (partial_die_parent_scope): Handle building scope
 720         for Fortran nested functions.
 721         (process_die): Record that nested functions have a scope.
 722         (new_symbol): Always record Fortran subprograms on the global
 723         symbol list.
 724         (determine_prefix): How to build the prefix for Fortran
 725         subprograms.
 726
 727 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 728
 729         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 730         have just sent the thread a SIGSTOP and are waiting for it to
 731         arrive.
 732
 733 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * btrace.c (btrace_add_pc): Remove whitespace before the template
 736         parameter in 'std::vector <...>'.
 737         (parse_xml_btrace_block): Likewise.
 738         (btrace_maint_decode_pt): Likewise.
 739         (btrace_maint_update_packets): Likewise.
 740         (btrace_maint_print_packets): Likewise.
 741         * btrace.h (struct btrace_maint_info): Likewise.
 742         * dwarf2read.c (struct type_unit_group): Likewise.
 743         (build_type_psymtabs_reader): Likewise.
 744         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 745         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 746         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 747
 748 2019-10-03  Tom de Vries  <tdevries@suse.de>
 749
 750         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 751         the first line of the help text for set/show style metadata.
 752
 753 2019-10-02  Tom Tromey  <tromey@adacore.com>
 754
 755         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 756         * gdbsupport/common-inferior.c: New file.
 757         * infcmd.c (startup_with_shell): Don't define.
 758         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 759         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 760         * inferior.h (startup_with_shell): Don't declare.
 761
 762 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 763
 764         * gdbsupport/gdb_assert.h: Include errors.h.
 765         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 766
 767 2019-10-02  Tom Tromey  <tromey@adacore.com>
 768
 769         * NEWS: Add $_ada_exception entry.
 770         * ada-lang.c (struct ada_catchpoint): Add constructor.
 771         <m_kind>: New member.
 772         (allocate_location_exception, re_set_exception): Remove
 773         "ex" parameter.
 774         (should_stop_exception): Compute $_ada_exception.
 775         (check_status_exception, print_it_exception)
 776         (print_one_exception, print_mention_exception): Remove
 777         "ex" parameter.
 778         (allocate_location_catch_exception, re_set_catch_exception)
 779         (check_status_exception, print_it_catch_exception)
 780         (print_one_catch_exception, print_mention_catch_exception)
 781         (print_recreate_catch_exception)
 782         (allocate_location_catch_exception_unhandled)
 783         (re_set_catch_exception_unhandled)
 784         (check_status_exception, print_it_catch_exception_unhandled)
 785         (print_one_catch_exception_unhandled)
 786         (print_mention_catch_exception_unhandled)
 787         (print_recreate_catch_exception_unhandled)
 788         (allocate_location_catch_assert, re_set_catch_assert)
 789         (check_status_assert, print_it_catch_assert)
 790         (print_one_catch_assert, print_mention_catch_assert)
 791         (print_recreate_catch_assert)
 792         (allocate_location_catch_handlers, re_set_catch_handlers)
 793         (check_status_handlers, print_it_catch_handlers)
 794         (print_one_catch_handlers, print_mention_catch_handlers)
 795         (print_recreate_catch_handlers): Remove.
 796         (create_ada_exception_catchpoint): Update.
 797         (initialize_ada_catchpoint_ops): Update.
 798
 799 2019-10-02  Tom Tromey  <tromey@adacore.com>
 800
 801         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 802         (create_excep_cond_exprs): Simplify exception string computation.
 803         (ada_exception_catchpoint_cond_string): Likewise.
 804
 805 2019-10-02  Tom Tromey  <tromey@adacore.com>
 806
 807         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 808         * ada-lang.c (lesseq_defined_than): Handle
 809         LOC_STATIC.
 810         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 811         parameter.
 812         (dwarf2_has_info): Likewise.
 813         (new_symbol): Set maybe_copied on symbol when
 814         appropriate.
 815         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 816         parameter.
 817         <can_copy>: New member.
 818         * elfread.c (record_minimal_symbol): Set maybe_copied
 819         on symbol when appropriate.
 820         (elf_symfile_read): Update call to dwarf2_has_info.
 821         * minsyms.c (lookup_minimal_symbol_linkage): New
 822         function.
 823         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 824         * symtab.c (get_symbol_address, get_msymbol_address):
 825         New functions.
 826         * symtab.h (get_symbol_address, get_msymbol_address):
 827         Declare.
 828         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 829         maybe_copied.
 830         (struct symbol, struct minimal_symbol) <maybe_copied>:
 831         New member.
 832
 833 2019-10-02  Tom Tromey  <tromey@adacore.com>
 834
 835         * source.c (struct current_source_location): New.
 836         (current_source_key): New global.
 837         (current_source_symtab, current_source_line)
 838         (current_source_pspace): Remove.
 839         (get_source_location): New function.
 840         (get_current_source_symtab_and_line)
 841         (set_default_source_symtab_and_line)
 842         (set_current_source_symtab_and_line)
 843         (clear_current_source_symtab_and_line, select_source_symtab)
 844         (info_source_command, print_source_lines_base)
 845         (info_line_command, search_command_helper, _initialize_source):
 846         Update.
 847
 848 2019-10-02  Tom Tromey  <tromey@adacore.com>
 849
 850         * source.c (select_source_symtab): Don't call
 851         decode_line_with_current_source.
 852
 853 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 854
 855         * symtab.c (lookup_global_symbol): Search global block.
 856
 857 2019-10-02  Tom Tromey  <tromey@adacore.com>
 858
 859         * coffread.c (process_coff_symbol): Update.
 860         * dwarf2read.c (var_decode_location, new_symbol): Update.
 861         * mdebugread.c (parse_symbol): Update.
 862         * objfiles.c (relocate_one_symbol): Update.
 863         * stabsread.c (define_symbol, fix_common_block)
 864         (scan_file_globals): Update.
 865         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 866         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 867         * xcoffread.c (process_xcoff_symbol): Update.
 868
 869 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 870
 871         * MAINTAINERS: Update my email address.
 872
 873 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 874
 875         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 876         std::vector.
 877         (build_type_psymtabs_reader): Update for std::vector.
 878         (build_type_psymtab_dependencies): Likewise.
 879         * dwarf2read.h: Remove use of DEF_VEC_P.
 880         (typedef sig_type_ptr): Delete.
 881
 882 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 883
 884         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 885         to std::vector.
 886         (btrace_maint_decode_pt): Likewise, and move allocation of the
 887         vector outside of the loop.
 888         (btrace_maint_update_packets): Update to handle change from VEC to
 889         std::vector.
 890         (btrace_maint_print_packets): Likewise.
 891         (maint_info_btrace_cmd): Likewise.
 892         * btrace.h: Remove use of DEF_VEC_O.
 893         (typedef btrace_pt_packet_s): Delete.
 894         (struct btrace_maint_info) <packets>: Change fromm VEC to
 895         std::vector.
 896         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 897
 898 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 899
 900         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 901         make accesses into the vector constant references.
 902         (btrace_add_pc): Update for std::vector.
 903         (btrace_stitch_bts): Likewise.
 904         (parse_xml_btrace_block): Likewise.
 905         (btrace_maint_update_packets): Likewise.
 906         (btrace_maint_print_packets): Likewise.
 907         (maint_info_btrace_cmd): Likewise.
 908         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 909         std::vector.
 910         (btrace_data::empty): Likewise.
 911         (btrace_data_append): Likewise.
 912         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 913         (typedef btrace_block_s): Delete.
 914         (struct btrace_block): Add constructor.
 915         (struct btrace_data_bts) <blocks>: Change to std::vector.
 916         * nat/linux-btrace.c (perf_event_read_bts): Update for
 917         std::vector.
 918         (linux_read_bts): Likewise.
 919
 920 2019-10-01  Tom Tromey  <tom@tromey.com>
 921
 922         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 923
 924 2019-10-01  Tom Tromey  <tom@tromey.com>
 925
 926         * stack.c (print_frame, info_frame_command_core): Use
 927         styled_string.
 928         * linux-thread-db.c (try_thread_db_load_1)
 929         (try_thread_db_load_from_pdir_1): Use styled_string.
 930         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 931         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 932         (maybe_print_unsupported_script_warning)
 933         (maybe_print_script_not_found_warning): Use styled_string.
 934         * ada-lang.c (user_select_syms): Use styled_string.
 935
 936 2019-10-01  Tom Tromey  <tom@tromey.com>
 937
 938         * p-lang.c (pascal_printstr): Use metadata style.
 939         * value.c (show_convenience): Use metadata style.
 940         * valprint.c (valprint_check_validity, val_print_optimized_out)
 941         (val_print_not_saved, val_print_unavailable)
 942         (val_print_invalid_address, generic_val_print, val_print)
 943         (value_check_printable, val_print_array_elements): Use metadata
 944         style.
 945         * ui-out.h (class ui_out) <field_fmt>: New overload.
 946         <do_field_fmt>: Add style parameter.
 947         * ui-out.c (ui_out::field_fmt): New overload.
 948         * typeprint.c (type_print_unknown_return_type)
 949         (val_print_not_allocated, val_print_not_associated): Use metadata
 950         style.
 951         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 952         parameter.
 953         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 954         * tracepoint.c (tvariables_info_1): Use metadata style.
 955         * stack.c (print_frame_arg, print_frame_info, print_frame)
 956         (info_frame_command_core): Use metadata style.
 957         * skip.c (info_skip_command): Use metadata style.
 958         * rust-lang.c (rust_print_enum): Use metadata style.
 959         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 960         metadata style.
 961         * python/py-framefilter.c (py_print_single_arg): Use metadata
 962         style.
 963         * printcmd.c (do_one_display, print_variable_and_value): Use
 964         metadata style.
 965         * p-valprint.c (pascal_val_print)
 966         (pascal_object_print_value_fields): Use metadata style.
 967         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 968         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 969         parameter.
 970         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 971         * m2-valprint.c (m2_print_long_set): Use metadata style.
 972         * m2-typeprint.c (m2_print_type): Use metadata style.
 973         * infcmd.c (print_return_value_1): Use metadata style.
 974         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 975         * f-valprint.c (info_common_command_for_block): Use metadata
 976         style.
 977         * f-typeprint.c (f_type_print_base): Use metadata style.
 978         * expprint.c (print_subexp_standard): Use metadata style.
 979         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 980         * cli/cli-style.h (class cli_style_option): Add constructor.
 981         (metadata_style): Declare.
 982         * cli/cli-style.c (metadata_style): New global.
 983         (_initialize_cli_style): Register metadata style.
 984         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 985         parameter.
 986         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 987         * c-typeprint.c (c_type_print_base_struct_union)
 988         (c_type_print_base_1): Use metadata style.
 989         * breakpoint.c (watchpoint_value_print)
 990         (print_one_breakpoint_location): Use metadata style.
 991         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 992         style.
 993         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 994         style.
 995         * ada-valprint.c (val_print_packed_array_elements, printstr)
 996         (print_field_values, ada_val_print_ref, ada_val_print): Use
 997         metadata style.
 998         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 999         style.
1000         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1001         style.
1002         * ada-lang.c (user_select_syms): Use metadata style.
1003
1004 2019-10-01  Tom Tromey  <tom@tromey.com>
1005
1006         * cli/cli-cmds.c (pwd_command): Style output.
1007
1008 2019-10-01  Pedro Alves  <palves@redhat.com>
1009             Tom Tromey  <tom@tromey.com>
1010
1011         * symtab.c (print_symbol_info): Use %ps.
1012         (print_msymbol_info): Use %ps.
1013         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1014         * printcmd.c (print_variable_and_value): Use %ps.
1015         * macrocmd.c (show_pp_source_pos): Use %ps.
1016         * infrun.c (print_exited_reason): Use ui_out::message.
1017         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1018         (describe_other_breakpoints): Use ui_out::message and new
1019         formats.
1020         (say_where): Use new formats.
1021         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1022         and new formats.
1023
1024 2019-10-01  Pedro Alves  <palves@redhat.com>
1025             Tom Tromey  <tom@tromey.com>
1026
1027         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1028         (test_gdb_formats): New function.
1029         (run_tests): Call it.
1030         (test_format_specifier): Update.
1031         * utils.h (fputs_filtered): Update comment.
1032         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1033         (fputs_styled_unfiltered): Declare.
1034         * utils.c (fputs_styled_unfiltered): New function.
1035         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1036         (vfprintf_filtered): Update.
1037         (vfprintf_unfiltered, vprintf_filtered): Update.
1038         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1039         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1040         disallow_ui_out_field>: New constants.
1041         (enum class field_kind): New.
1042         (struct base_field_s, struct signed_field_s): New.
1043         (signed_field): New function.
1044         (struct string_field_s): New.
1045         (string_field): New function.
1046         (struct styled_string_s): New.
1047         (styled_string): New function.
1048         (class ui_out) <message>: Add comment.
1049         <vmessage, call_do_message>: New methods.
1050         <do_message>: Add style parameter.
1051         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1052         methods.
1053         (ui_out::message): Rewrite.
1054         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1055         parameter.
1056         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1057         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1058         gdb_extensions parameter.
1059         (class format_piece): Add parameter to constructor.
1060         (n_int_args): New field.
1061         * gdbsupport/format.c (format_pieces::format_pieces): Add
1062         gdb_extensions parameter.  Handle '*'.
1063         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1064         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1065         vfprintf_styled_no_gdbfmt.
1066         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1067         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1068         unfiltered output.
1069         * ui-style.h (struct ui_file_style) <ptr>: New method.
1070
1071 2019-10-01  Tom Tromey  <tom@tromey.com>
1072
1073         * unittests/format_pieces-selftests.c: Update.  Add final format.
1074         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1075         empty literal pieces.
1076
1077 2019-10-01  Tom Tromey  <tom@tromey.com>
1078
1079         * ui-out.h (enum class ui_out_style_kind): Remove.
1080         (class ui_out) <field_string, field_stsream, do_field_string>:
1081         Change type of "style".
1082         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1083         (ui_out::field_string): Update.
1084         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1085         of "style".
1086         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1087         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1088         * stack.c (print_frame_arg, print_frame_info, print_frame):
1089         Update.
1090         * source.c (print_source_lines_base): Update.
1091         * solib.c (info_sharedlibrary_command): Update.
1092         * skip.c (info_skip_command): Update.
1093         * record-btrace.c (btrace_call_history_src_line)
1094         (btrace_call_history): Update.
1095         * python/py-framefilter.c (py_print_frame): Update.
1096         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1097         "style".
1098         * mi/mi-out.c (mi_ui_out::do_table_header)
1099         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1100         (mi_ui_out::do_field_string): Update.
1101         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1102         Update.
1103         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1104         "style".
1105         * cli-out.c (cli_ui_out::do_table_header)
1106         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1107         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1108         (cli_ui_out::do_field_fmt): Update.
1109         * breakpoint.c (print_breakpoint_location): Update.
1110         (update_static_tracepoint): Update.
1111
1112 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1113
1114         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1115         conversion of gdb_datadir.
1116         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1117         remove not needed c_str ().
1118
1119 2019-09-30  Ali Tamur <tamur@google.com>
1120
1121         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1122         (dwarf2_string_attr): Likewise.
1123
1124 2019-09-30  Ali Tamur <tamur@google.com>
1125
1126         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1127         (process_full_type_unit): Likewise.
1128         (dump_die_shallow): Likewise.
1129         (cu_debug_loc_section): Likewise.
1130
1131 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1132
1133         * minsyms.c (compare_minimal_symbols): Rename to...
1134         (minimal_symbol_is_less_than): ...this, and adjust to STL
1135         conventions (return bool, take arguments as references)
1136         (minimal_symbol_reader::install): Call std::sort instead
1137         of qsort.
1138
1139 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1140
1141         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1142         hash and why.
1143         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1144         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1145
1146 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1147
1148         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1149         * psympriv.h (add_psymbol_to_list): Move comment here and update
1150         it.
1151
1152 2019-09-29  Tom de Vries  <tdevries@suse.de>
1153
1154         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1155         Use $tmpdir/$(basename "$output_file").dwz instead of
1156         "${output_file}.dwz".
1157
1158 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1159
1160         PR gdb/25045
1161         * hppa-linux-nat.c: Include gdbarch.h.
1162
1163 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1164
1165         * blockframe.c (find_pc_partial_function): Change return type to bool.
1166         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1167         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1168         (stub_gnu_ifunc_resolve_name): Likewise.
1169         * symtab.c (compare_filenames_for_search): Likewise.
1170         (compare_glob_filenames_for_search): Likewise.
1171         (matching_obj_sections): Likewise.
1172         (symbol_matches_domain): Likewise.
1173         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1174         (find_line_pc): Change return type to bool.
1175         (find_line_pc_range): Likewise.
1176         (producer_is_realview): Likewise.
1177         * symtab.h (symbol_matches_domain): Likewise.
1178         (find_pc_partial_function): Likewise.
1179         (find_pc_line_pc_range): Likewise.
1180         (in_gnu_ifunc_stub): Likewise.
1181         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1182         (find_line_pc): Likewise.
1183         (find_line_pc_range): Likewise.
1184         (matching_obj_sections): Likewise.
1185         (find_line_symtab): Change out parameter to bool.
1186         (producer_is_realview): Change return type to bool.
1187         (compare_filenames_for_search): Likewise.
1188         (compare_glob_filenames_for_search): Likewise.
1189
1190 2019-09-26  Tom Tromey  <tom@tromey.com>
1191
1192         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1193         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1194         * gdb_usleep.h: Remove.
1195         * gdb_usleep.c: Remove.
1196         * utils.c: Don't include gdb_usleep.h.
1197
1198 2019-09-26  Tom Tromey  <tromey@adacore.com>
1199
1200         * python/py-type.c (type_to_type_object): Call check_typedef
1201         for stub types.
1202
1203 2019-09-26  Tom Tromey  <tom@tromey.com>
1204
1205         * utils.h (initialize_utils): Don't declare.
1206         * top.c (gdb_init): Don't call initialize_utils.
1207         * utils.c (initialize_utils): Remove.  Move contents...
1208         (_initialize_utils): ... here.
1209
1210 2019-09-25  Tom Tromey  <tom@tromey.com>
1211
1212         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1213         * utils.h (make_hex_string): Don't declare.
1214         * utils.c (make_hex_string): Remove.
1215
1216 2019-09-24  Tom de Vries  <tdevries@suse.de>
1217
1218         PR gdb/23815
1219         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1220         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1221
1222 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1223
1224         * NEWS: Mention new simulator port for PRU.
1225
1226 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1227
1228         * ada-exp.y (write_object_remaining): Update.
1229         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1230         and eliminate the static buffer.
1231         (ada_decode_symbol): Update.
1232         (ada_la_decode): Update.
1233         (ada_sniff_from_mangled_name): Update.
1234         (is_valid_name_for_wild_match): Update.
1235         (ada_lookup_name_info::matches): Update and simplify.
1236         (name_matches_regex): Update.
1237         (ada_add_global_exceptions): Update.
1238         * ada-lang.h (ada_decode): Update signature.
1239         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1240         * dwarf-index-write.c (debug_names::insert): Update.
1241
1242 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1243
1244         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1245         formatting.
1246
1247 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1248
1249         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1250         Change "nonzero" to "true" in documentation.
1251
1252 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1253
1254         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1255         (_initialize_darwin_solib): Don't set
1256         darwin_so_ops.lookup_lib_global_symbol.
1257         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1258         set_gdbarch_iterate_over_objfiles_in_search_order.
1259         (elf_lookup_lib_symbol): Rename to...
1260         (svr4_iterate_over_objfiles_in_search_order): this, and update
1261         to iterate semantics.
1262         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1263         * solib.c (solib_global_lookup): Remove.
1264         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1265         (solib_global_lookup): Remove.
1266         * symtab.c (lookup_global_or_static_symbol): Remove call to
1267         solib_global_lookup.
1268
1269 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1270
1271         * NEWS: Move entries about default MI version now being
1272         version 3, and about the GDB/MI fix for multi-location
1273         breakpoints to the "since GDB 8.3" section.
1274
1275 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1276
1277         GDB 8.3.1 released.
1278
1279 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1280
1281         * NEWS: Mention that Cell/B.E. debugging support was removed.
1282         * MAINTAINERS: Remove spu target.
1283
1284         * config/djgpp/fnchange.lst: Remove entries for removed files.
1285
1286         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1287         spu-multiarch.o, and spu-tdep.o.
1288         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1289         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1290         spu-multiarch.c, and spu-tdep.c.
1291         * spu-linux-nat.c: Remove file.
1292         * spu-multiarch.c: Remove file.
1293         * spu-tdep.c: Remove file.
1294         * spu-tdep.h: Remove file.
1295         * solib-spu.c: Remove file.
1296         * solib-spu.h: Remove file.
1297
1298         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1299         * configure.nat (spu-linux): Remove.
1300         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1301         solib-multiarch.o from gdb_target_obs.
1302         (spu*-*-*): Remove.
1303
1304         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1305         feature flag.
1306         (ppc_linux_no_features): Update.
1307         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1308         Cell/B.E. support.
1309         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1310         (tdesc_powerpc_cell64l): Likewise.
1311         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1312         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1313         Cell/B.E. support.
1314         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1315         Do not include "features/rs6000/powerpc-cell32l.c" or
1316         "features/rs6000/powerpc-cell64l.c".
1317         (ppc_linux_spu_section): Remove.
1318         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1319         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1320         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1321         (ppc_linux_spe_context_lookup): Remove.
1322         (ppc_linux_spe_context_inferior_created): Remove.
1323         (ppc_linux_spe_context_solib_loaded): Remove.
1324         (ppc_linux_spe_context_solib_unloaded): Remove.
1325         (ppc_linux_spe_context): Remove.
1326         (struct ppu2spu_cache): Remove.
1327         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1328         (struct ppu2spu_data): Remove.
1329         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1330         ppu2spu_unwind): Remove.
1331         (ppc_linux_init_abi): Remove Cell/B.E. support.
1332         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1333
1334         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1335         (rs6000/powerpc-cell64l-expedite): Likewise
1336         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1337         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1338         rs6000/powerpc-cell64l.xml.
1339         * features/rs6000/powerpc-cell32l.xml: Remove.
1340         * features/rs6000/powerpc-cell64l.xml: Likewise.
1341         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1342         * features/rs6000/powerpc-cell64l.c: Likewise.
1343         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1344         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1345         * regformats/reg-spu.dat: Remove.
1346
1347         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1348         * corelow.c (struct spuid_list): Remove.
1349         (add_to_spuid_list): Remove.
1350         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1351         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1352         (remote_protocol_features): Remove associated entries.
1353         (_initialize_remote): No longer initialize them.
1354         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1355         * linux-nat.c (SPUFS_MAGIC): Remove.
1356         (linux_proc_xfer_spu): Remove.
1357         (spu_enumerate_spu_ids): Remove.
1358         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1359         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1360         (linux_make_corefile_notes): No longer call it.
1361
1362         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1363         (cooked_write_test): Likewise.
1364
1365 2019-09-20  Tom Tromey  <tom@tromey.com>
1366
1367         * NEWS: Mention case-sensitivity of TUI commands.
1368         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1369         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1370         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1371
1372 2019-09-20  Tom Tromey  <tom@tromey.com>
1373
1374         * tui/tui-source.c (tui_source_window::set_contents): Use
1375         make_unique_xstrdup.
1376         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1377         make_unique_xstrdup.
1378
1379 2019-09-20  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-data.c: Remove separator comments.
1382         * tui/tui-layout.c: Remove separator comments.
1383         * tui/tui-win.c: Remove separator comments.
1384         * tui/tui-wingeneral.c: Remove separator comments.
1385
1386 2019-09-20  Tom Tromey  <tom@tromey.com>
1387
1388         * tui/tui.h (strcat_to_buf): Don't declare.
1389         * tui/tui.c (strcat_to_buf): Remove.
1390
1391 2019-09-20  Tom Tromey  <tom@tromey.com>
1392
1393         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1394         from "fullname".
1395         * tui/tui-source.c (tui_source_window::set_contents)
1396         (tui_source_window::location_matches_p)
1397         (tui_source_window::maybe_update): Update.
1398
1399 2019-09-20  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1402         Update.
1403         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1404         prefix.
1405         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1406         (tui_data_window::line_from_reg_element_no)
1407         (tui_data_window::first_reg_element_no_inline)
1408         (tui_data_window::show_registers)
1409         (tui_data_window::show_register_group)
1410         (tui_data_window::display_registers_from)
1411         (tui_data_window::display_registers_from_line)
1412         (tui_data_window::first_data_item_displayed)
1413         (tui_data_window::delete_data_content_windows)
1414         (tui_data_window::erase_data_content)
1415         (tui_data_window::do_scroll_vertical)
1416         (tui_data_window::refresh_window)
1417         (tui_data_window::check_register_values): Update.
1418
1419 2019-09-20  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1422         (struct tui_locator_window) <full_name, proc_name>: Now
1423         std::string.
1424         * tui/tui-stack.c (tui_locator_window::make_status_line)
1425         (tui_locator_window::set_locator_fullname)
1426         (tui_locator_window::set_locator_info): Update.
1427         * tui/tui-source.c (tui_source_window::set_contents)
1428         (tui_source_window::showing_source_p): Update.
1429
1430 2019-09-20  Tom Tromey  <tom@tromey.com>
1431
1432         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1433         Don't call tui_locator_win_info_ptr.
1434
1435 2019-09-20  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1438
1439 2019-09-20  Tom Tromey  <tom@tromey.com>
1440
1441         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1442         height for locator.
1443         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1444         * tui/tui-layout.c (show_source_disasm_command, show_data)
1445         (show_source_or_disasm_and_command): Use 1 as height for locator.
1446
1447 2019-09-20  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui.c (tui_enable): Update.
1450         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1451         Update.
1452         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1453         Update.
1454         * tui/tui-data.c (win_resized): Now bool.
1455         (tui_win_resized): Return bool.
1456         (tui_set_win_resized_to): Accept a bool.
1457
1458 2019-09-20  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1461         Change type of "refresh_values_only".
1462         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1463         type of "refresh_values_only".
1464
1465 2019-09-20  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1468         std::string.
1469         (tui_disassemble): Add "pos" parameter.
1470         (tui_disasm_window::set_contents): Simplify.
1471
1472 2019-09-20  Tom Tromey  <tom@tromey.com>
1473
1474         * tui/tui-winsource.h (struct tui_source_window_base)
1475         <show_source_content>: Now private.
1476         * tui/tui-winsource.c
1477         (tui_source_window_base::show_source_content): Don't handle empty
1478         content case.
1479
1480 2019-09-20  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-layout.c (show_source_disasm_command)
1483         (show_source_or_disasm_and_command): Don't call
1484         show_source_content.
1485
1486 2019-09-20  Tom Tromey  <tom@tromey.com>
1487
1488         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1489         Declare.
1490         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1491         from tui_make_status_line.
1492         (tui_locator_window::rerender): Update.
1493
1494 2019-09-20  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1497         (tui_locator_window::rerender): Update.
1498
1499 2019-09-20  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-winsource.h (struct tui_source_window_base)
1502         <~tui_source_window_base>: Don't declare.
1503         <fullname>: Remove.
1504         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1505         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1506         member.
1507         * tui/tui-source.c (tui_source_window::set_contents): Update.
1508         (tui_source_window::location_matches_p)
1509         (tui_source_window::maybe_update): Update.
1510
1511 2019-09-20  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-winsource.h (~tui_source_element): Remove.
1514         (tui_source_element): Update.
1515         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1516         * tui/tui-winsource.c (tui_show_source_line): Update.
1517         * tui/tui-source.c (tui_source_window::set_contents): Update.
1518         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1519
1520 2019-09-20  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1523         declare.
1524         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1525         tui_clear_source_windows_detail.
1526         * tui/tui-winsource.h (struct tui_source_window_base)
1527         <clear_detail>: Don't declare.
1528         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1529         Remove.
1530         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1531
1532 2019-09-20  Tom Tromey  <tromey@adacore.com>
1533
1534         PR ada/24919:
1535         * block.c (contained_in): Fix final return value.
1536
1537 2019-09-20  Alan Modra  <amodra@gmail.com>
1538
1539         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1540         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1541         (read_indirect_string_from_dwz): Use bfd accessor.
1542         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1543         * machoread.c (macho_symfile_read_all_oso): Likewise.
1544         * solib.c (solib_bfd_open): Likewise.
1545
1546 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1547
1548         * eval.c: Move declaration of overload_resolution to...
1549         * value.h: ...here.
1550
1551 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1552
1553         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1554         * arm-linux-tdep.c: Likewise.
1555         * arm-nbsd-nat.c: Likewise.
1556         * arm-tdep.h: Declare arm_apcs_32.
1557         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1558
1559 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1560
1561         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1562         * dwarf2read.h: Declare dwarf_always_disassemble.
1563
1564 2019-09-19  Tom de Vries  <tdevries@suse.de>
1565
1566         PR gdb/25009
1567         * source-cache.c (source_cache::ensure): Catch exception thrown during
1568         construction of the highlighter.
1569
1570 2019-09-18  Alan Modra  <amodra@gmail.com>
1571
1572         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1573         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1574         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1575         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1576         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1577         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1578         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1579         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1580         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1581         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1582         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1583         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1584         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1585         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1586         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1587         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1588         * mi/mi-interp.c: Update throughout for bfd section macro and
1589         function changes.
1590         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1591         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1592
1593 2019-09-18  Tom Tromey  <tom@tromey.com>
1594
1595         * NEWS: Add entry.
1596         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1597         call rl_initialize.
1598         (tui_enable): Do not call rl_initialize.
1599
1600 2019-09-18  Christian Groessler  <chris@groessler.org>
1601
1602         * alpha-linux-nat.c: Include gdbarch.h.
1603
1604 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1605
1606         * ui-file.c: Include cli/cli-style.h.
1607         (term_cli_styling): Remove cli_styling declaration.
1608
1609 2019-09-18  Alan Modra  <amodra@gmail.com>
1610
1611         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1612         to bfd_asymbol_section.
1613
1614 2019-09-18  Alan Modra  <amodra@gmail.com>
1615
1616         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1617         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1618         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1619
1620 2019-09-18  Alan Modra  <amodra@gmail.com>
1621
1622         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1623         * spu-linux-nat.c (spu_bfd_open): Likewise.
1624
1625 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1626
1627         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1628         to bool to match definition in dwarf2read.c.
1629
1630 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1631
1632         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1633         (print_signatures): Likewise.
1634         (trust_pad_over_xvs): Likewise.
1635         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1636         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1637         * arm-linux-nat.c (arm_apcs_32): Likewise.
1638         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1639         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1640         * arm-tdep.c (arm_debug): Likewise.
1641         (arm_apcs_32): Likewise.
1642         * auto-load.c (debug_auto_load): Likewise.
1643         (auto_load_gdb_scripts): Likewise.
1644         (global_auto_load): Likewise.
1645         (auto_load_local_gdbinit): Likewise.
1646         (auto_load_local_gdbinit_loaded): Likewise.
1647         * auto-load.h (global_auto_load): Likewise.
1648         (auto_load_local_gdbinit): Likewise.
1649         (auto_load_local_gdbinit_loaded): Likewise.
1650         * breakpoint.c (disconnected_dprintf): Likewise.
1651         (breakpoint_proceeded): Likewise.
1652         (automatic_hardware_breakpoints): Likewise.
1653         (always_inserted_mode): Likewise.
1654         (target_exact_watchpoints): Likewise.
1655         (_initialize_breakpoint): Update.
1656         * breakpoint.h (target_exact_watchpoints): Change to bool.
1657         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1658         * cli/cli-cmds.c (trace_commands): Likewise.
1659         * cli/cli-cmds.h (trace_commands): Likewise.
1660         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1661         to bool*.
1662         * cli/cli-logging.c (logging_overwrite): Change to bool.
1663         (logging_redirect): Likewise.
1664         (debug_redirect): Likewise.
1665         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1666         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1667         to bool.
1668         <boolean_option_def>: Update.
1669         (struct flag_option_def): Change default type of Context to bool
1670         from int.
1671         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1672         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1673         (get_setshow_command_value_string): Likewise.
1674         * cli/cli-style.c (cli_styling): Change to bool.
1675         (source_styling): Likewise.
1676         * cli/cli-style.h (source_styling): Likewise.
1677         (cli_styling): Likewise.
1678         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1679         to bool.
1680         * command.h (var_types): Update comment.
1681         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1682         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1683         bool.
1684         (debug_compile_cplus_scopes): Likewise.
1685         * compile/compile-internal.h (compile_debug): Likewise.
1686         * compile/compile.c (compile_debug): Likewise.
1687         (struct compile_options) <raw>: Likewise.
1688         * cp-support.c (catch_demangler_crashes): Likewise.
1689         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1690         (usr_cmd_cris_dwarf2_cfi): Likewise.
1691         * csky-tdep.c (csky_debug): Likewise.
1692         * darwin-nat.c (enable_mach_exceptions): Likewise.
1693         * dcache.c (dcache_enabled_p): Likewise.
1694         * defs.h (info_verbose): Likewise.
1695         * demangle.c (demangle): Likewise.
1696         (asm_demangle): Likewise.
1697         * dwarf-index-cache.c (debug_index_cache): Likewise.
1698         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1699         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1700         * dwarf2read.c (check_physname): Likewise.
1701         (use_deprecated_index_sections): Likewise.
1702         (dwarf_always_disassemble): Likewise.
1703         * eval.c (overload_resolution): Likewise.
1704         * event-top.c (set_editing_cmd_var): Likewise.
1705         (exec_done_display_p): Likewise.
1706         * event-top.h (set_editing_cmd_var): Likewise.
1707         (exec_done_display_p): Likewise.
1708         * exec.c (write_files): Likewise.
1709         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1710         (debug_fbsd_nat): Likewise.
1711         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1712         Likewise.
1713         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1714         <backtrace_past_entry> Likewise.
1715         * gdb-demangle.h (demangle): Likewise.
1716         (asm_demangle): Likewise.
1717         * gdb_bfd.c (bfd_sharing): Likewise.
1718         * gdbcore.h (write_files): Likewise.
1719         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1720         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1721         * gdbthread.h (print_thread_events): Likewise.
1722         * gdbtypes.c (opaque_type_resolution): Likewise.
1723         (strict_type_checking): Likewise.
1724         * gnu-nat.c (gnu_debug_flag): Likewise.
1725         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1726         * guile/scm-param.c (pascm_variable): Add boolval.
1727         (add_setshow_generic): Update.
1728         (pascm_param_value): Update.
1729         (pascm_set_param_value_x): Update.
1730         * hppa-tdep.c (hppa_debug): Change to bool..
1731         * infcall.c (may_call_functions_p): Likewise.
1732         (coerce_float_to_double_p): Likewise.
1733         (unwind_on_signal_p): Likewise.
1734         (unwind_on_terminating_exception_p): Likewise.
1735         * infcmd.c (startup_with_shell): Likewise.
1736         * inferior.c (print_inferior_events): Likewise.
1737         * inferior.h (startup_with_shell): Likewise.
1738         (print_inferior_events): Likewise.
1739         * infrun.c (step_stop_if_no_debug): Likewise.
1740         (detach_fork): Likewise.
1741         (debug_displaced): Likewise.
1742         (disable_randomization): Likewise.
1743         (non_stop): Likewise.
1744         (non_stop_1): Likewise.
1745         (observer_mode): Likewise.
1746         (observer_mode_1): Likewise.
1747         (set_observer_mode): Update.
1748         (sched_multi): Change to bool.
1749         * infrun.h (debug_displaced): Likewise.
1750         (sched_multi): Likewise.
1751         (step_stop_if_no_debug): Likewise.
1752         (non_stop): Likewise.
1753         (disable_randomization): Likewise.
1754         * linux-tdep.c (use_coredump_filter): Likewise.
1755         (dump_excluded_mappings): Likewise.
1756         * linux-thread-db.c (auto_load_thread_db): Likewise.
1757         (check_thread_db_on_load): Likewise.
1758         * main.c (captured_main_1): Update.
1759         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1760         xx2_opt, boolean_opt>: Change to bool.
1761         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1762         * maint.c (maintenance_profile_p): Likewise.
1763         (per_command_time): Likewise.
1764         (per_command_space): Likewise.
1765         (per_command_symtab): Likewise.
1766         * memattr.c (inaccessible_by_default): Likewise.
1767         * mi/mi-main.c (mi_async): Likewise.
1768         (mi_async_1): Likewise.
1769         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1770         * nat/fork-inferior.h (startup_with_shell): Likewise.
1771         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1772         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1773         * nios2-tdep.c (nios2_debug): Likewise.
1774         * or1k-tdep.c (or1k_debug): Likewise.
1775         * parse.c (parser_debug): Likewise.
1776         * parser-defs.h (parser_debug): Likewise.
1777         * printcmd.c (print_symbol_filename): Likewise.
1778         * proc-api.c (procfs_trace): Likewise.
1779         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1780         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1781         (set_parameter_value): Update.
1782         (add_setshow_generic): Update.
1783         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1784         to bool*.
1785         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1786         int*.
1787         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1788         * record-btrace.c (record_btrace_target::store_registers): Update.
1789         * record-full.c (record_full_memory_query): Change to bool.
1790         (record_full_stop_at_limit): Likewise.
1791         * record-full.h (record_full_memory_query): Likewise.
1792         * remote-notif.c (notif_debug): Likewise.
1793         * remote-notif.h (notif_debug): Likewise.
1794         * remote.c (use_range_stepping): Likewise.
1795         (interrupt_on_connect): Likewise.
1796         (remote_break): Likewise.
1797         * ser-tcp.c (tcp_auto_retry): Likewise.
1798         * ser-unix.c (serial_hwflow): Likewise.
1799         * skip.c (debug_skip): Likewise.
1800         * solib-aix.c (solib_aix_debug): Likewise.
1801         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1802         (spu_auto_flush_cache_p): Likewise.
1803         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1804         Likewise.
1805         (struct info_print_options) <quiet>: Likewise.
1806         * symfile-debug.c (debug_symfile): Likewise.
1807         * symfile.c (auto_solib_add): Likewise.
1808         (separate_debug_file_debug): Likewise.
1809         * symfile.h (auto_solib_add): Likewise.
1810         (separate_debug_file_debug): Likewise.
1811         * symtab.c (basenames_may_differ): Likewise.
1812         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1813         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1814         (struct info_types_options) <quiet>: Likewise.
1815         * symtab.h (demangle): Likewise.
1816         (basenames_may_differ): Likewise.
1817         * target-dcache.c (stack_cache_enabled_1): Likewise.
1818         (code_cache_enabled_1): Likewise.
1819         * target.c (trust_readonly): Likewise.
1820         (may_write_registers): Likewise.
1821         (may_write_memory): Likewise.
1822         (may_insert_breakpoints): Likewise.
1823         (may_insert_tracepoints): Likewise.
1824         (may_insert_fast_tracepoints): Likewise.
1825         (may_stop): Likewise.
1826         (auto_connect_native_target): Likewise.
1827         (target_stop_and_wait): Update.
1828         (target_async_permitted): Change to bool.
1829         (target_async_permitted_1): Likewise.
1830         (may_write_registers_1): Likewise.
1831         (may_write_memory_1): Likewise.
1832         (may_insert_breakpoints_1): Likewise.
1833         (may_insert_tracepoints_1): Likewise.
1834         (may_insert_fast_tracepoints_1): Likewise.
1835         (may_stop_1): Likewise.
1836         * target.h (target_async_permitted): Likewise.
1837         (may_write_registers): Likewise.
1838         (may_write_memory): Likewise.
1839         (may_insert_breakpoints): Likewise.
1840         (may_insert_tracepoints): Likewise.
1841         (may_insert_fast_tracepoints): Likewise.
1842         (may_stop): Likewise.
1843         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1844         (make_thread_apply_all_options_def_group): Change argument from int*
1845         to bool*.
1846         (thread_apply_all_command): Update.
1847         (print_thread_events): Change to bool.
1848         * top.c (confirm): Likewise.
1849         (command_editing_p): Likewise.
1850         (history_expansion_p): Likewise.
1851         (write_history_p): Likewise.
1852         (info_verbose): Likewise.
1853         * top.h (confirm): Likewise.
1854         (history_expansion_p): Likewise.
1855         * tracepoint.c (disconnected_tracing): Likewise.
1856         (circular_trace_buffer): Likewise.
1857         * typeprint.c (print_methods): Likewise.
1858         (print_typedefs): Likewise.
1859         * utils.c (debug_timestamp): Likewise.
1860         (sevenbit_strings): Likewise.
1861         (pagination_enabled): Likewise.
1862         * utils.h (sevenbit_strings): Likewise.
1863         (pagination_enabled): Likewise.
1864         * valops.c (overload_resolution): Likewise.
1865         * valprint.h (struct value_print_options) <prettyformat_arrays,
1866         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1867         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1868         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1869         Likewise.
1870         * windows-nat.c (new_console): Likewise.
1871         (cygwin_exceptions): Likewise.
1872         (new_group): Likewise.
1873         (debug_exec): Likewise.
1874         (debug_events): Likewise.
1875         (debug_memory): Likewise.
1876         (debug_exceptions): Likewise.
1877         (useshell): Likewise.
1878         * windows-tdep.c (maint_display_all_tib): Likewise.
1879         * xml-support.c (debug_xml): Likewise.
1880
1881 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1882
1883         * source.c (prepare_path_for_appending): New function.
1884         (openp): Make use of new function.
1885         (find_and_open_source): Search for the compilation directory and
1886         source file as a relative path beneath the directory search path.
1887
1888 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1889
1890         * source-cache.c (source_cache::get_line_charpos): Catch
1891         exceptions and return false, this matches the behaviour documented
1892         in the header file.
1893
1894 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1895
1896         * ada-tasks.c (info_task): Remove quoting of the task's name.
1897
1898 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1899
1900         * symfile.c (auto_solib_add): Replace comment with a reference
1901         to the header file.
1902
1903 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1904
1905         * NEWS: Mention that gdb can now be compiled with Python 3
1906         on Windows.
1907
1908 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1909
1910         * maint.c (maint_print_section_data::maint_print_section_data):
1911         Force use of 'float log10 (float)' by casting the argument to
1912         float.
1913
1914 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1915
1916         * maint.c: Add 'cmath' include.
1917         (struct maint_print_section_data): New structure.
1918         (print_section_index): New function.
1919         (print_bfd_section_info): Add header comment, small whitespace
1920         cleanup, and update to call new print_section_index function.
1921         (print_objfile_section_info): Likewise.
1922         (maint_obj_section_from_bfd_section): New function.
1923         (print_bfd_section_info_maybe_relocated): New function.
1924         (maintenance_info_sections): Add header comment, always use
1925         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1926
1927 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1928
1929         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1930         inner scope, add check that the objfile has psymtabs before
1931         checking psymtabs_addrmap.
1932         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1933
1934 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1935
1936         * NEWS: Announce that Ada task names are now shown at more places,
1937         and between quotes (except in info task output).
1938         * gdb/ada-tasks.c (task_to_str): New function.
1939         (display_current_task_id): Call task_to_str.
1940         (task_command_1): Likewise.
1941         (print_ada_task_info): In non-mi mode, Properly align headers and data
1942         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1943
1944 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1945
1946         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1947         prstatus.pr_lwp.pr_info instead of making it up.
1948
1949 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1950
1951         * auto-load.c (auto_load_expand_dir_vars): Update.
1952         * defs.h (gdb_datadir): Change to std::string.
1953         (python_libdir): Likewise.
1954         (relocate_gdb_directory): Change return type to std::string.
1955         * guile/guile.c (gdbscm_data_directory): Update.
1956         (initialize_scheme_side): Update.
1957         * jit.c (jit_reader_dir): Change to std::string.
1958         (jit_reader_load_command): Update.
1959         * main.c (gdb_datadir): Change to std::string.
1960         (python_libdir): Likewise.
1961         (set_gdb_data_directory): Update.
1962         (relocate_path): Change to return std::string.
1963         (relocate_gdb_directory): Change to return std::string.
1964         (relocate_gdbinit_path_maybe_in_datadir): Update.
1965         (captured_main_1): Update.
1966         * python/python.c (do_start_initialization): Update.
1967         * top.c (show_gdb_datadir): Update.
1968         * xml-syscall.c (xml_init_syscalls_info): Update.
1969         (init_syscalls_info): Update.
1970
1971 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1972
1973         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1974         out of get_init_files.
1975         (get_init_files): Update.
1976
1977 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1978
1979         * main.c (get_init_files): Change to use std::string.
1980         (captured_main_1): Update.
1981         (print_gdb_help): Update.
1982
1983 2019-09-11  Ali Tamur  <tamur@google.com>
1984
1985         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1986         implementation.
1987
1988 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1989
1990         * dbxread.c (read_dbx_symtab): Update.
1991         * dwarf2read.c (load_partial_dies): Update.
1992         * mdebugread.c (parse_partial_symbols): Update.
1993         (handle_psymbol_enumerators): Update.
1994         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1995         * psymtab.c (add_psymbol_to_bcache): Likewise.
1996         (add_psymbol_to_list): Likewise.
1997         * symtab.c (symbol_set_names): Likewise.
1998         * symtab.h (symbol_set_names): Likewise.
1999         * xcoffread.c (scan_xcoff_symtab): Update.
2000
2001 2019-09-11  Tom Tromey  <tom@tromey.com>
2002
2003         * symfile-mem.c (symbol_file_add_from_memory): Use
2004         bfd_set_filename.
2005         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2006         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2007
2008 2019-09-10  Tom Tromey  <tromey@adacore.com>
2009
2010         * dwarf-index-write.c (write_psymbols): Extend error message.
2011         (debug_names::insert): Add Ada code.
2012         (debug_names::write_psymbols): Remove Ada check.
2013         (debug_names) <m_string_obstack>: New member.
2014         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2015         (gdb_index_symbol_name_matcher::matches): Remove.
2016         (mapped_index_base::find_name_components_bounds): Add "lang"
2017         parameter.
2018         (mapped_index_base::build_name_components): Also split names
2019         according to Ada syntax.
2020         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2021         type of "match_callback".
2022         (check_match, check_find_bounds_finds)
2023         (dw2_expand_symtabs_matching): Update.
2024         (dw2_debug_names_iterator): Add new constructor.
2025         (dw2_debug_names_map_matching_symbols): New function.
2026         (dw2_debug_names_expand_symtabs_matching): Update.
2027         (dwarf2_debug_names_functions): Use
2028         dw2_debug_names_map_matching_symbols.
2029
2030 2019-09-10  Tom Tromey  <tromey@adacore.com>
2031
2032         * dwarf2read.c (dw2_get_file_names_reader): Add the
2033         CU's file name to the results.
2034
2035 2019-09-10  Tom Tromey  <tromey@adacore.com>
2036
2037         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2038         map_matching_symbols.  Update.
2039         * dwarf2read.c (dw2_map_matching_symbols): Update.
2040         * psymtab.c (match_partial_symbol): Change type; update.
2041         (psym_map_matching_symbols): Likewise.
2042         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2043         type; update.
2044         * symfile.h (struct quick_symbol_functions)
2045         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2046         Remove "match".
2047
2048 2019-09-10  Tom Tromey  <tromey@adacore.com>
2049
2050         * psymtab.c (map_block): Remove.
2051         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2052         * symtab.c (iterate_over_symbols_terminated): New function.
2053         * symtab.c (iterate_over_symbols_terminated): Declare.
2054
2055 2019-09-10  Tom Tromey  <tromey@adacore.com>
2056
2057         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2058         * language.h (struct language_defn) <la_iterate_over_symbols>:
2059         Return bool.
2060         * symtab.c (iterate_over_symbols): Return bool.
2061         * symtab.h (iterate_over_symbols): Return bool.
2062
2063 2019-09-10  Tom Tromey  <tromey@adacore.com>
2064
2065         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2066         (add_nonlocal_symbols): Update.
2067         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2068         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2069         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2070         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2071         Change type of "callback".  Remove "data".
2072
2073
2074 2019-09-09  Ali Tamur  <tamur@google.com>
2075
2076         * dwarf2read.c (comp_unit_head): Update comment.
2077         (dwarf2_dwo_name): New function declaration.
2078         (dwarf_unit_type_name): New function declaration.
2079         (read_comp_unit_head): Add support for new compilation units,
2080         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2081         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2082         (currently named as "signature") in their header. Also clarify error
2083         messages.
2084         (lookup_dwo_id): New function. Returns the dwo id of the given
2085         compile unit.
2086         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2087         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2088         functions.
2089         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2090         (dwarf2_dwo_name): Get the dwo name if present.
2091         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2092         purposes.
2093
2094 2019-09-09  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2097
2098 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2099
2100         * python/python.c (do_start_initialization): Make progname_copy static,
2101         to avoid a leak report.
2102
2103 2019-09-08  Tom Tromey  <tom@tromey.com>
2104
2105         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2106
2107 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2108
2109         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2110         Change type to gdb::optional<block_enum>.
2111         (dw2_symtab_iter_init): Change block_index parameter type
2112         to gdb::optional<block_enum>.
2113         (dw2_lookup_symbol): Change block_index parameter
2114         type to block_enum.c
2115         (dw2_debug_names_lookup_symbol): Likewise.
2116         * psymtab.c (psym_lookup_symbol): Likewise.
2117         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2118         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2119         Likewise.
2120
2121 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2122
2123         * defs.h (relocate_gdb_directory): Change int to bool in
2124         signature and rename flag to relocatable.
2125         * main.c (relocate_path): Likewise.
2126         (relocate_gdb_directory): Likewise.
2127
2128 2019-09-06  Alan Modra  <amodra@gmail.com>
2129
2130         * coffread.c (coff_symfile_read): Constify filename variable.
2131         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2132         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2133         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2134         * solib.c (reload_shared_libraries_1): Likewise.
2135         * symfile.c (reread_symbols): Likewise.
2136         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2137         * solib-darwin.c (darwin_bfd_open): Likewise.
2138         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2139
2140 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2141
2142         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2143         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2144
2145 2019-09-03  Tom Tromey  <tromey@adacore.com>
2146
2147         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2148         types.
2149         (has_negatives): Unbias a range type bound.
2150         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2151         * gdbtypes.c (operator==): Handle new field.
2152         (create_range_type): Add "bias" parameter.
2153         (create_static_range_type, resolve_dynamic_range): Update.
2154         * gdbtypes.h (struct range_bounds) <bias>: New member.
2155         (create_range_type): Add bias parameter.
2156         * printcmd.c (print_scalar_formatted): Unbias range types.
2157         * value.c (unpack_long): Unbias range types.
2158         (pack_long): Bias range types.
2159
2160 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2161
2162         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2163         probe arguments.
2164
2165 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2166
2167         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2168         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2169         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2170         (compile_probe_arg): Likewise.
2171         * probe.h (get_argument_count): Likewise.
2172         * solib-svr4.c (solib_event_probe_action): Likewise.
2173         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2174
2175 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2176
2177         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2178         code to here...
2179         (svr4_create_solib_event_breakpoints): ...from here.
2180
2181 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2182
2183         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2184         suffix from warning message.
2185
2186 2019-08-30  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-winsource.h (struct tui_source_window_base)
2189         <refresh_all>: Don't declare.
2190         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2191         Remove.
2192         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2193         tui_show_locator_content.
2194         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2195         declare.
2196         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2197         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2198         declare.
2199
2200 2019-08-30  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2203
2204 2019-08-30  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2207         Remove unnecessary forward declarations.
2208
2209 2019-08-30  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2212         rerender.
2213         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2214         tui_show_locator_content.
2215
2216 2019-08-30  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2219         (tui_locator_window::rerender): Rewrite using body of previous
2220         tui_show_locator_content.
2221
2222 2019-08-30  Tom Tromey  <tom@tromey.com>
2223
2224         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2225         set_locator_fullname>: New methods.
2226         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2227         Rename from tui_set_locator_fullname.
2228         (tui_locator_window::set_locator_info): Rename from
2229         tui_set_locator_info.  Return bool.
2230         (tui_update_locator_fullname, tui_show_frame_info): Update.
2231
2232 2019-08-30  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2235
2236 2019-08-30  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2239         call touchwin.
2240
2241 2019-08-30  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-wingeneral.c (box_win): Assume win_info and
2244         win_info->handle cannot be NULL.
2245
2246 2019-08-30  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2249         refresh_window>: Declare.
2250         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2251         resize.
2252         (tui_data_item_window::rerender): Rename from
2253         tui_display_register.
2254         (tui_data_item_window::refresh_window): New method.
2255         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2256         no-op.
2257
2258 2019-08-30  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2261         regs_column_count, current_group>: Move later.  Now private.
2262         <get_current_group>: New method.
2263         * tui/tui-regs.c (tui_reg_command): Update.
2264         * tui/tui-layout.c (tui_set_layout): Update.
2265
2266 2019-08-30  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2269         (tui_data_window::rerender): Don't call
2270         check_and_display_highlight_if_needed.
2271         (tui_data_window::refresh_all): Remove call to
2272         erase_data_content.
2273
2274 2019-08-30  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2277         (tui_data_window::display_registers_from)
2278         (tui_data_window::display_reg_element_at_line)
2279         (tui_data_window::display_registers_from_line): Remove checks of
2280         "empty".
2281
2282 2019-08-30  Tom Tromey  <tom@tromey.com>
2283
2284         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2285         Don't declare.
2286         * tui/tui-regs.c (tui_data_window::show_registers): Call
2287         rerender.
2288         (tui_data_window::rerender): Rename from display_all_data.
2289         (tui_data_window::rerender): Remove old implementation.
2290
2291 2019-08-30  Tom Tromey  <tom@tromey.com>
2292
2293         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2294         text.
2295         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2296
2297 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2298             Sergio Durigan Junior  <sergiodj@redhat.com>
2299
2300         PR win32/24284
2301         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2302
2303 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2304
2305         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2306         when searching for types.
2307
2308 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2309
2310         * f-lang.c (f_language_defn): Use f_print_typedef.
2311         * f-lang.h (f_print_typedef): Declare.
2312         * f-typeprint.c (f_print_typedef): Define.
2313
2314 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2315
2316         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2317
2318 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2319
2320         * cli/cli-utils.c (info_print_options_defs): Delete.
2321         (make_info_print_options_def_group): Delete.
2322         (extract_info_print_options): Delete.
2323         (info_print_command_completer): Delete.
2324         (info_print_args_help): Add extra parameter, and optionally
2325         include text about -n flag.
2326         * cli/cli-utils.h (struct info_print_options): Delete.
2327         (extract_info_print_options): Delete declaration.
2328         (info_print_command_completer): Delete declaration.
2329         (info_print_args_help): Add extra parameter, extend header
2330         comment.
2331         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2332         search_symbols.
2333         * stack.c (struct info_print_options): New type.
2334         (info_print_options_defs): New file scoped variable.
2335         (make_info_print_options_def_group): New static function.
2336         (info_print_command_completer): New static function.
2337         (info_locals_command): Update to use new local functions.
2338         (info_args_command): Likewise.
2339         (_initialize_stack): Add extra parameter to calls to
2340         info_print_args_help.
2341         * symtab.c (search_symbols): Add extra parameter, use this to
2342         possibly excluse non-debug symbols.
2343         (symtab_symbol_info): Add extra parameter, which is passed on to
2344         search_symbols.
2345         (struct info_print_options): New type.
2346         (info_print_options_defs): New file scoped variable.
2347         (make_info_print_options_def_group): New static function.
2348         (info_print_command_completer): New static function.
2349         (info_variables_command): Update to use local functions, and pass
2350         extra parameter through to symtab_symbol_info.
2351         (info_functions_command): Likewise.
2352         (info_types_command): Pass additional argument through to
2353         symtab_symbol_info.
2354         (rbreak_command): Pass extra argument to search_symbols.
2355         (_initialize_symtab): Add extra arguments for calls to
2356         info_print_args_help, and update help text for 'info variables',
2357         'whereis', and 'info functions' commands.
2358         * symtab.h (search_symbols): Add extra argument to declaration.
2359         * NEWS: Mention new flags.
2360
2361 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2362
2363         * symtab.c (lookup_static_symbol): Call the new function (and move
2364         it down to be next to lookup_global_symbol).
2365         (struct global_sym_lookup_data): Add block_enum member and rename to...
2366         (struct global_or_static_sym_lookup_data): ...this.
2367         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2368         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2369         (lookup_symbol_global_or_static_iterator_cb): ...this.
2370         (lookup_global_or_static_symbol): New function.
2371         (lookup_global_symbol): Call new function.
2372
2373 2019-08-26  Tom de Vries  <tdevries@suse.de>
2374
2375         PR c++/24852
2376         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2377         when pc_probe.prob == NULL.
2378
2379 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2380
2381         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2382         variable symbol_linkage to symbol_linkage_.
2383
2384 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2385
2386         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2387         represent whether the symbol is static, dynamic, or we don't
2388         know.
2389
2390 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2391
2392         * gdb/rx-tdep.c (rx_register_names): New.
2393         (rx_register_name): Delete.
2394         (rx_psw_type): Delete.
2395         (rx_fpsw_type): Delete.
2396         (rx_register_type): Delete.
2397         (rx_gdbarch_init): Convert target-descriptions.
2398         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2399         * gdb/features/Makefile: Add rx.xml.
2400         * gdb/features/rx.xml: New.
2401         * gdb/features/rx.c: Generated.
2402         * gdb/NEWS: Mention target description support.
2403
2404 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2405
2406         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2407         *slot_ptr.
2408
2409 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2410
2411         * configure.ac: Don't check for 'dlfcn.h' (moved to
2412         gdbsupport/common.m4).
2413         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2414         'gdbsupport/'.
2415         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2416         * compile/compile-c-support.c: Include
2417         'gdbsupport/gdb-dlfcn.h'.
2418         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2419         * gdb-dlfcn.c: Move to...
2420         * gdbsupport/gdb-dlfcn.c: ... here.
2421         * gdb-dlfcn.h: Move to...
2422         * gdbsupport/gdb-dlfcn.h: ... here.
2423
2424 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2425
2426         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2427         the offset field signed.
2428
2429 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2430
2431         * python/lib/gdb/__init__.py (_execute_file): New function.
2432         * python/python.c (python_run_simple_file): Call gdb._execute_file
2433         on Windows.
2434
2435 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2436
2437         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2438         all uses as this was never set to anything but a zero value.
2439
2440 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2441
2442         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2443
2444 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2445
2446         * tui/tui-data.h (tui_gen_win_info): Add an =default
2447         move constructor, required by some GCC versions.
2448
2449 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2450
2451         * go32-nat.c (go32_sysinfo): Add hygon_p.
2452
2453 2019-08-20  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2456         line_from_reg_element_no, first_reg_element_no_inline,
2457         display_all_data, delete_data_content_windows,
2458         erase_data_content>: Now private.
2459
2460 2019-08-20  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2463         (tui_unhighlight_win, tui_highlight_win)
2464         (tui_win_info::make_window): Update.
2465         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2466
2467 2019-08-20  Tom Tromey  <tom@tromey.com>
2468
2469         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2470         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2471         (MAX_PID_WIDTH): Move to tui-stack.c.
2472         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2473         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2474         (MAX_PID_WIDTH): Move from tui-data.h.
2475
2476 2019-08-20  Tom Tromey  <tom@tromey.com>
2477
2478         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2479         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2480         (box_win): Update.
2481         (tui_gen_win_info::make_window): Rename from tui_make_window.
2482         (tui_win_info::make_window): New method.
2483         (tui_gen_win_info::make_visible): Update.
2484         * tui/tui-source.c (tui_source_window::set_contents): Update.
2485         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2486         (tui_data_window::display_registers_from): Update.
2487         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2488         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2489         Declare.
2490         <can_box>: Remove.
2491         <title>: Remove.
2492         (struct tui_win_info) <make_window>: Declare.
2493         <can_box>: Now virtual.
2494         <title>: New member.
2495         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2496         * tui/tui-command.c (tui_cmd_window::resize): Update.
2497
2498 2019-08-20  Tom Tromey  <tom@tromey.com>
2499
2500         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2501         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2502         (tui_data_window::check_register_values): Update.
2503
2504 2019-08-20  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-regs.h (struct tui_data_window): Use
2507         DISABLE_COPY_AND_ASSIGN.
2508         <regs_content>: Change type, removing unique_ptr.
2509         <tui_data_window>: Add move constructor.
2510         * tui/tui-regs.c (tui_data_window::show_registers)
2511         (tui_data_window::show_register_group)
2512         (tui_data_window::display_registers_from)
2513         (tui_data_window::display_registers_from)
2514         (tui_data_window::first_data_item_displayed)
2515         (tui_data_window::delete_data_content_windows)
2516         (tui_data_window::rerender, tui_data_window::refresh_window)
2517         (tui_data_window::check_register_values): Update.
2518
2519 2019-08-20  Tom Tromey  <tom@tromey.com>
2520
2521         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2522         show_register_group>: Declare.
2523         (tui_show_register_group): Don't declare.
2524         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2525         tui_show_registers.
2526         (tui_data_window::show_register_group): Rename from
2527         tui_show_register_group.
2528         (tui_data_window::check_register_values, tui_reg_command):
2529         Update.
2530         * tui/tui-layout.c (tui_set_layout): Update.
2531
2532 2019-08-20  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2535         Declare.
2536         (tui_check_register_values): Don't declare.
2537         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2538         from tui_check_register_values.
2539         * tui/tui-hooks.c (tui_register_changed): Update.
2540
2541 2019-08-20  Tom Tromey  <tom@tromey.com>
2542
2543         * tui/tui-regs.c (tui_reg_layout): Move later.
2544         (tui_show_registers): Don't enable TUI mode or change layout.
2545
2546 2019-08-20  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-regs.h (struct tui_data_item_window)
2549         <~tui_data_item_window>: Remove.
2550         <content>: Now a unique_xmalloc_ptr.
2551         * tui/tui-regs.c (tui_register_format): Return a
2552         unique_xmalloc_ptr.
2553         (tui_get_register): Update.
2554         (~tui_data_item_window): Remove.
2555         (tui_data_window::display_registers_from, tui_display_register):
2556         Update.
2557         * tui/tui-io.h (tui_expand_tabs): Update.
2558         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2559         Remove "col" parameter.
2560
2561 2019-08-20  Tom Tromey  <tom@tromey.com>
2562
2563         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2564         field.
2565         * tui/tui-regs.c (~tui_data_item_window): Update.
2566
2567 2019-08-20  Tom Tromey  <tom@tromey.com>
2568
2569         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2570         earlier.
2571
2572 2019-08-20  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2575
2576 2019-08-20  Tom Tromey  <tom@tromey.com>
2577
2578         * tui/tui-source.h (struct tui_source_window): Update.
2579         * tui/tui-regs.c (tui_show_registers): Update.
2580         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2581         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2582         (NO_REGS_STRING): Remove defines.
2583
2584 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2585
2586         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2587         unnecessary thread walk if remote doesn't support the packet.
2588
2589 2019-08-19  Tom Tromey  <tromey@adacore.com>
2590
2591         * python/py-value.c (value_has_field): Fix indentation.
2592
2593 2019-08-19  Tom Tromey  <tromey@adacore.com>
2594
2595         * printcmd.c (do_one_display, info_display_command): Update.
2596         * block.h (contained_in): Return bool.  Add allow_nested
2597         parameter.
2598         * block.c (contained_in): Return bool.  Add allow_nested
2599         parameter.
2600
2601 2019-08-19  Tom Tromey  <tom@tromey.com>
2602
2603         * configure: Rebuild.
2604         * configure.ac: Disallow the combination of -static-libstdc++ and
2605         source highlight.
2606         * source-cache.c (get_language_name): Handle rust.
2607         (source_cache::get_source_lines): Ignore highlighting exceptions.
2608
2609 2019-08-16  Tom Tromey  <tom@tromey.com>
2610
2611         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2612         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2613         (struct tui_source_window_base) <make_visible, refresh_window,
2614         resize>: Remove methods.
2615         <execution_info>: Remove field.
2616         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2617         (tui_show_source_line, tui_source_window_base)
2618         (~tui_source_window_base): Update.
2619         (tui_source_window_base::resize)
2620         (tui_source_window_base::make_visible)
2621         (tui_source_window_base::refresh_window): Remove.
2622         (tui_source_window_base::update_exec_info): Update.
2623         * tui/tui-source.c (tui_source_window::set_contents): Update.
2624         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2625
2626 2019-08-16  Tom Tromey  <tom@tromey.com>
2627
2628         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2629         deprecated_query_hook.
2630
2631 2019-08-16  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2634         (tui_update_source_windows_with_line): Update.
2635         * tui/tui-source.h (struct tui_source_window)
2636         <show_symtab_source>: Declare.
2637         (tui_show_symtab_source): Don't declare.
2638         * tui/tui-source.c (tui_show_symtab_source): Rename from
2639         tui_show_symtab_source.
2640
2641 2019-08-16  Tom Tromey  <tom@tromey.com>
2642
2643         * tui/tui-winsource.h (struct tui_source_window_base)
2644         <set_contents>: Declare.
2645         * tui/tui-winsource.c
2646         (tui_source_window_base::update_source_window_as_is): Update.
2647         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2648         Declare.
2649         (tui_set_source_content): Don't declare.
2650         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2651         tui_set_source_content.
2652         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2653         Declare.
2654         (tui_set_disassem_content): Don't declare.
2655         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2656         tui_set_disassem_content.
2657
2658 2019-08-16  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui-winsource.h (struct tui_source_window_base)
2661         <update_breakpoint_info>: Declare.
2662         (tui_update_breakpoint_info): Don't declare.
2663         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2664         (tui_update_all_breakpoint_info): Update.
2665         (tui_source_window_base::update_breakpoint_info): Rename from
2666         tui_update_breakpoint_info.
2667         (tui_source_window_base::update_exec_info): Update.
2668
2669 2019-08-16  Tom Tromey  <tom@tromey.com>
2670
2671         * tui/tui-winsource.h (struct tui_source_window_base)
2672         <update_source_window>: Declare.
2673         (tui_update_source_window): Don't declare.
2674         * tui/tui-winsource.c
2675         (tui_source_window_base::update_source_window): Rename from
2676         tui_update_source_window.
2677         (tui_source_window_base::rerender): Update.
2678         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2679         * tui/tui-disasm.c (tui_show_disassem)
2680         (tui_show_disassem_and_update_source)
2681         (tui_disasm_window::maybe_update): Update.
2682
2683 2019-08-16  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-winsource.h (struct tui_source_window_base)
2686         <update_source_window_as_is>: Declare.
2687         (tui_update_source_window_as_is): Don't declare.
2688         * tui/tui-winsource.c (tui_update_source_window): Update
2689         (tui_source_window_base::update_source_window_as_is): Rename from
2690         tui_update_source_window_as_is.
2691         (tui_source_window_base::refill): Update.
2692         * tui/tui-source.c (tui_show_symtab_source): Update.
2693         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2694         Update.
2695
2696 2019-08-16  Tom Tromey  <tom@tromey.com>
2697
2698         * tui/tui-winsource.h (tui_update_source_window)
2699         (tui_update_source_window_as_is): Remove "noerror" parameter.
2700         * tui/tui-winsource.c (tui_update_source_window)
2701         (tui_update_source_window_as_is): Remove "noerror" parameter.
2702         (tui_update_source_windows_with_addr)
2703         (tui_update_source_windows_with_line)
2704         (tui_source_window_base::rerender)
2705         (tui_source_window_base::refill): Update.
2706         * tui/tui-source.h (tui_set_source_content)
2707         (tui_show_symtab_source): Remove "noerror" parameter.
2708         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2709         parameter.
2710         (tui_show_symtab_source): Likewise.
2711         (tui_source_window::maybe_update): Update.
2712         * tui/tui-disasm.c (tui_show_disassem)
2713         (tui_show_disassem_and_update_source)
2714         (tui_disasm_window::do_scroll_vertical)
2715         (tui_disasm_window::maybe_update): Update.
2716
2717 2019-08-16  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui.c (tui_is_window_visible): Update.
2720         * tui/tui-wingeneral.c (tui_make_window)
2721         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2722         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2723         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2724         (tui_set_win_height_command, parse_scrolling_args): Update.
2725         * tui/tui-source.c (tui_source_window::style_changed): Update.
2726         * tui/tui-regs.c (tui_show_registers)
2727         (tui_data_window::first_data_item_displayed)
2728         (tui_data_window::delete_data_content_windows)
2729         (tui_check_register_values, tui_reg_command): Update.
2730         * tui/tui-disasm.c (tui_show_disassem): Update.
2731         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2732         method.
2733         <is_visible>: Remove field.
2734         * tui/tui-data.c (tui_next_win, tui_prev_win)
2735         (tui_delete_invisible_windows): Update.
2736
2737 2019-08-16  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-winsource.h (struct tui_source_window_base)
2740         <m_has_locator>: Remove.
2741         * tui/tui-layout.c (show_source_disasm_command, show_data)
2742         (show_source_or_disasm_and_command): Update.
2743
2744 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2745
2746         * NEWS (Other MI changes): New subsection.
2747         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2748         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2749         * arch-utils.c (default_get_pc_address_flags): New function.
2750         * arch-utils.h (default_get_pc_address_flags): New declaration.
2751         * gdbarch.sh: Add get_pc_address_flags.
2752         * gdbarch.c: Regenerate.
2753         * gdbarch.h: Likewise.
2754         * stack.c (print_pc): New function.
2755         (print_frame_info) (print_frame): Call print_pc.
2756
2757 2019-08-16  Tom de Vries  <tdevries@suse.de>
2758
2759         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2760         print_objfile_section_info.
2761
2762 2019-08-15  Tom Tromey  <tom@tromey.com>
2763
2764         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2765         calling update_cmdwin_start_line.
2766         * tui/tui-winsource.h (struct tui_source_window_base)
2767         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2768         <rerender>: Declare.
2769         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2770         Call rerender.
2771         (tui_source_window_base::set_new_height): Remove.
2772         (tui_source_window_base::rerender): Rename from
2773         do_make_visible_with_new_height.
2774         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2775         resize method.
2776         (tui_win_info::make_invisible_and_set_new_height)
2777         (tui_win_info::make_visible_with_new_height): Remove.
2778         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2779         Declare.
2780         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2781         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2782         do_make_visible_with_new_height>: Don't declare.
2783         <rerender>: Declare.
2784         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2785         set_new_height.
2786         (tui_data_window::do_make_visible_with_new_height): Remove.
2787         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2788         call tui_show_locator_content.
2789         (tui_gen_win_info::resize): Call rerender.
2790         (show_source_or_disasm_and_command): Don't call
2791         tui_show_locator_content.
2792         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2793         method.
2794         (struct tui_win_info) <rerender>: Declare.
2795         <set_new_height, make_invisible_and_set_new_height,
2796         make_visible_with_new_height>: Don't declare.
2797         * tui/tui-data.c (tui_win_list::rerender): New method.
2798         * tui/tui-command.h (struct tui_cmd_window)
2799         <do_make_visible_with_new_height>: Don't declare.
2800         * tui/tui-command.c
2801         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2802
2803 2019-08-15  Tom Tromey  <tromey@adacore.com>
2804
2805         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2806         * ada-lang.c (ada_enum_name): Likewise.
2807
2808 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2809
2810         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2811         leading underscore.
2812         (GdbOutputErrorFile): Likewise.
2813         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2814         accordingly.
2815         (execute_unwinders): Rename to have a leading underscore.
2816         (auto_load_packages): Likewise.
2817         (global scope): Adjust call to auto_load_packages accordingly.
2818         (GdbSetPythonDirectory): Likewise.
2819         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2820         instead of execute_unwinders.
2821
2822 2019-08-15  Tom Tromey  <tom@tromey.com>
2823
2824         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2825         (show_data): Don't change window visibility.
2826         (tui_gen_win_info::resize): Remove special case for command
2827         window.  Use wresize, when available.
2828         (show_source_or_disasm_and_command): Don't change window
2829         visibility.
2830         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2831         <make_visible>: New method.
2832         * tui/tui-command.c (tui_cmd_window::resize): New method.
2833
2834 2019-08-15  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2837         (struct tui_source_windows): New.
2838         * tui/tui-winsource.c (tui_display_main): Update.
2839         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2840         (new_height_ok, parse_scrolling_args): Update.
2841         * tui/tui-layout.c (show_layout, show_data): Update.
2842         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2843         (tui_add_to_source_windows): Don't declare.
2844         * tui/tui-data.c (source_windows, tui_source_windows)
2845         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2846
2847 2019-08-15  Tom Tromey  <tom@tromey.com>
2848
2849         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2850         Rename from reset.
2851         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2852         * tui/tui-layout.c (show_source_disasm_command, show_data):
2853         Update.
2854         (tui_gen_win_info::resize): Rename.
2855         (show_source_or_disasm_and_command): Update.
2856         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2857         reset.
2858
2859 2019-08-15  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2862         * tui/tui-interp.c (tui_interp::init): Don't call
2863         tui_initialize_static_data.
2864         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2865
2866 2019-08-15  Tom Tromey  <tom@tromey.com>
2867
2868         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2869         examine tui_win_list.
2870
2871 2019-08-15  Tom Tromey  <tom@tromey.com>
2872
2873         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2874         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2875         tui_clear_source_content.
2876         (tui_clear_source_content): Remove.
2877         (tui_source_window_base::do_erase_source_content): Hoist call to
2878         content.clear().
2879         * tui/tui-stack.c (tui_show_frame_info): Don't call
2880         tui_clear_source_content.
2881
2882 2019-08-15  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui-winsource.h (struct tui_source_window_base)
2885         <do_erase_source_content>: New method.
2886         <erase_source_content>: New method.
2887         (tui_erase_source_content): Don't declare.
2888         * tui/tui-winsource.c (tui_clear_source_content): Update.
2889         (tui_source_window_base::do_erase_source_content): Rename from
2890         tui_erase_source_content.
2891         (tui_source_window_base::show_source_content): Update.
2892         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2893         * tui/tui-source.h (struct tui_source_window)
2894         <erase_source_content>: New method.
2895         * tui/tui-disasm.h (struct tui_disasm_window)
2896         <erase_source_content>: New method.
2897
2898 2019-08-15  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2901         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2902         constructor.
2903         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2904         * tui/tui-source.c (tui_set_source_content): Update.
2905         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2906
2907 2019-08-15  Tom Tromey  <tom@tromey.com>
2908
2909         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2910         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2911         tui-source.c.
2912         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2913         Declare.
2914         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2915         method.
2916         (tui_source_window::maybe_update): Update.
2917
2918 2019-08-15  Tom Tromey  <tom@tromey.com>
2919
2920         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2921         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2922         tui-disasm.c.
2923         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2924         Declare.
2925         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2926         method.
2927         (tui_disasm_window::maybe_update): Update.
2928
2929 2019-08-15  Tom Tromey  <tom@tromey.com>
2930
2931         * tui/tui-winsource.h (struct tui_source_window_base)
2932         <maybe_update>: Declare.
2933         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2934         method.
2935         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2936         Declare.
2937         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2938         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2939         Declare.
2940         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2941
2942 2019-08-15  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2945
2946 2019-08-15  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-wingeneral.c: Include tui-stack.h.
2949         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2950         (struct tui_locator_window): Move from tui-data.h.
2951         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2952         (tui_initialize_static_data): Move from tui-data.c.
2953         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2954         (struct tui_locator_window): Move to tui-stack.c.
2955         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2956         (tui_initialize_static_data): Move to tui-stack.c.
2957
2958 2019-08-15  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-layout.c (show_source_disasm_command)
2961         (show_source_or_disasm_and_command): Use make_visible method, not
2962         tui_make_window.
2963         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2964         Remove.
2965
2966 2019-08-15  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-wingeneral.h (tui_make_window): Update.
2969         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2970         parameter.
2971         (tui_gen_win_info::make_visible): Update.
2972         * tui/tui-regs.c (tui_data_window::display_registers_from):
2973         Update.
2974         * tui/tui-layout.c (show_source_disasm_command)
2975         (show_source_or_disasm_and_command): Update.
2976         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2977         (enum tui_box): Remove.
2978         (struct tui_win_info) <can_box>: New method.
2979         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2980         method.
2981
2982 2019-08-15  Tom de Vries  <tdevries@suse.de>
2983
2984         * linux-nat-trad.c: Include gdbarch.h.
2985
2986 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2987
2988         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2989         register sizes.
2990
2991 2019-08-14  Tom Tromey  <tromey@adacore.com>
2992
2993         * darwin-nat.c: Include gdbarch.h.
2994         * darwin-nat-info.c: Include gdbarch.h.
2995
2996 2019-08-13  Tom Tromey  <tom@tromey.com>
2997
2998         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2999         Remove.
3000         * tui/tui-data.c (tui_initialize_static_data): Update.
3001
3002 2019-08-13  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-winsource.h (struct tui_exec_info_window)
3005         <~tui_exec_info_window, maybe_allocate_content, get_content,
3006         m_content>: Remove.
3007         (struct tui_source_window_base) <set_exec_info_content,
3008         show_exec_info_content>: Don't declare.
3009         * tui/tui-winsource.c
3010         (tui_exec_info_window::maybe_allocate_content): Remove.
3011         (tui_source_window_base::update_exec_info): Rename from
3012         set_exec_info_content.
3013         (tui_source_window_base::show_exec_info_content)
3014         (tui_source_window_base::update_exec_info): Remove.
3015
3016 2019-08-13  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3019         declare.
3020         * tui/tui-winsource.c (tui_update_source_window_as_is)
3021         (tui_update_source_windows_with_addr, tui_erase_source_content):
3022         Update.
3023         (tui_clear_exec_info_content): Remove.
3024
3025 2019-08-13  Tom Tromey  <tom@tromey.com>
3026
3027         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3028         declare.
3029         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3030         call tui_erase_exec_info_content.
3031         (tui_clear_exec_info_content): Rename from
3032         tui_erase_exec_info_content.
3033         (tui_clear_exec_info_content): Delete.
3034
3035 2019-08-13  Tom Tromey  <tom@tromey.com>
3036
3037         * tui/tui-winsource.h (struct tui_source_window_base)
3038         <show_exec_info_content>: Declare.
3039         (tui_show_exec_info_content): Don't declare.
3040         * tui/tui-winsource.c
3041         (tui_source_window_base::show_exec_info_content): Rename from
3042         tui_show_exec_info_content.
3043         (tui_source_window_base::update_exec_info): Update.
3044
3045 2019-08-13  Tom Tromey  <tom@tromey.com>
3046
3047         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3048         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3049         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3050         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3051         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3052         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3053         ... here.
3054
3055 2019-08-13  Tom Tromey  <tom@tromey.com>
3056
3057         * tui/tui-winsource.h (struct tui_source_window_base)
3058         <update_exec_info>: Declare.
3059         (tui_update_exec_info): Don't declare.
3060         * tui/tui-winsource.c (tui_update_source_window_as_is)
3061         (tui_source_window_base::refresh_all)
3062         (tui_update_all_breakpoint_info): Update.
3063         (tui_source_window_base::update_exec_info): Rename from
3064         tui_update_exec_info.
3065         * tui/tui-stack.c (tui_show_frame_info): Update.
3066
3067 2019-08-13  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-winsource.h (struct tui_source_window_base)
3070         <set_exec_info_content>: Declare.
3071         (tui_set_exec_info_content): Don't declare.
3072         * tui/tui-winsource.c
3073         (tui_source_window_base::set_exec_info_content): Rename from
3074         tui_set_exec_info_content.
3075         (tui_update_exec_info): Update.
3076
3077 2019-08-13  Tom Tromey  <tom@tromey.com>
3078
3079         * tui/tui-winsource.h (struct tui_source_window_base)
3080         <show_source_content>: Declare.
3081         (tui_show_source_content): Don't declare.
3082         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3083         (tui_source_window_base::show_source_content): Rename from
3084         tui_show_source_content.
3085         (tui_source_window_base::refresh_all): Update.
3086         * tui/tui-layout.c (show_source_disasm_command)
3087         (show_source_or_disasm_and_command): Update.
3088
3089 2019-08-13  Tom Tromey  <tom@tromey.com>
3090
3091         * tui/tui-winsource.c (tui_erase_source_content)
3092         (tui_show_source_content, tui_source_window_base::refresh_all):
3093         Update.
3094         * tui/tui-wingeneral.h
3095         (tui_check_and_display_highlight_if_needed): Don't declare.
3096         * tui/tui-wingeneral.c
3097         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3098         check_and_display_highlight_if_needed.
3099         * tui/tui-win.c (tui_rehighlight_all)
3100         (tui_win_info::make_visible_with_new_height): Update.
3101         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3102         (tui_data_window::erase_data_content)
3103         (tui_data_window::display_all_data): Update.
3104         * tui/tui-data.h (struct tui_win_info)
3105         <check_and_display_highlight_if_needed>: Declare.
3106
3107 2019-08-13  Tom Tromey  <tom@tromey.com>
3108
3109         * tui/tui-win.c (tui_resize_all): Call
3110         tui_delete_invisible_windows.
3111         * tui/tui-layout.c (show_layout): Call
3112         tui_delete_invisible_windows.
3113         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3114         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3115
3116 2019-08-13  Tom Tromey  <tom@tromey.com>
3117
3118         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3119         tui_add_win_to_layout.
3120
3121 2019-08-13  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3124         * tui/tui-layout.c (tui_default_win_height): Now static.
3125
3126 2019-08-13  Tom Tromey  <tom@tromey.com>
3127
3128         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3129         single switch.
3130         (show_source_disasm_command, show_source_or_disasm_and_command):
3131         Don't check current layout.
3132
3133 2019-08-13  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-wingeneral.c (make_all_visible): Remove.
3136         (tui_make_all_invisible): Simplify.
3137         * tui/tui-layout.c (tui_make_all_invisible): Move from
3138         tui-wingeneral.c; simplify.
3139         (show_layout): Hoist call to tui_make_all_invisible.
3140         (show_data): Don't call tui_make_all_invisible.
3141
3142 2019-08-13  Tom Tromey  <tom@tromey.com>
3143
3144         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3145         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3146
3147 2019-08-13  Tom Tromey  <tom@tromey.com>
3148
3149         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3150         tui-data.c.
3151         (show_source_disasm_command, show_data)
3152         (show_source_or_disasm_and_command): Don't use
3153         tui_set_current_layout_to.
3154         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3155         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3156         tui-layout.c.
3157         (tui_set_current_layout_to): Remove.
3158
3159 2019-08-13  Tom Tromey  <tom@tromey.com>
3160
3161         * tui/tui-layout.c (tui_set_layout): Update.
3162         * tui/tui-data.h (struct tui_layout_def): Remove.
3163         (tui_layout_def): Don't declare.
3164         * tui/tui-data.c (layout_def): Remove.
3165         (tui_layout_def): Remove.
3166
3167 2019-08-13  Tom Tromey  <tom@tromey.com>
3168
3169         * tui/tui-winsource.h (struct tui_source_window_base)
3170         <clear_detail>: No longer "override".
3171         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3172         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3173         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3174         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3175         Remove.
3176         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3177
3178 2019-08-13  Tom Tromey  <tromey@adacore.com>
3179
3180         * tracepoint.c: Don't include readline.h or history.h.
3181
3182 2019-08-12  Tom Tromey  <tom@tromey.com>
3183
3184         * configure: Rebuild.
3185         * configure.ac: Check for readline 7.
3186         * NEWS: Mention readline 7 requirement.
3187         * README: Update.
3188
3189 2019-08-12  Tom Tromey  <tom@tromey.com>
3190
3191         * mingw-hdep.c (gdb_select): Remove readline hack.
3192
3193 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3194
3195         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3196         when the function fails.
3197
3198 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3199
3200         * s390-tdep.c (s390_type_align): New function.
3201         (s390_gdbarch_init): Set it as type_align gdbarch method.
3202
3203 2019-08-09  Tom de Vries  <tdevries@suse.de>
3204
3205         PR gdb/24591
3206         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3207         pc_low with relocation offset.
3208
3209 2019-08-07  Tom Tromey  <tromey@adacore.com>
3210
3211         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3212         (print_frame_args): Update.
3213         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3214         Update.
3215         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3216         * frame.h (struct frame_arg): Add initializers.
3217         <error>: Now a unique_xmalloc_ptr.
3218
3219 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3220
3221         * NEWS: Expand the Pointer Authentication entry.
3222         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3223         (aarch64_frame_unmask_lr): ... to this.
3224         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3225         Call aarch64_frame_unmask_lr.
3226         * frame.c (struct frame_info): Add "masked" variable.
3227         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3228         (fprint_frame): Check for masked pc.
3229         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3230         declarations.
3231         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3232         * stack.c (print_frame): Check for masked pc.
3233
3234 2019-08-06  Tom Tromey  <tom@tromey.com>
3235
3236         * stabsread.c (patch_block_stabs, read_one_struct_field)
3237         (read_enum_type): Use obstack_strndup.
3238         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3239         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3240         * dwarf2read.c (guess_full_die_structure_name)
3241         (anonymous_struct_prefix): Use obstack_strndup.
3242         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3243         * c-exp.y (yylex): Use obstack_strndup.
3244         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3245         (write_var_or_type): Use obstack_strndup.
3246
3247 2019-08-06  Tom Tromey  <tom@tromey.com>
3248
3249         * symfile.c (reread_symbols): Use obstack_strdup.
3250         * stabsread.c (read_type): Use obstack_strdup.
3251         * gdb_obstack.h (obstack_strdup): New overload.
3252         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3253         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3254         (dwarf2_canonicalize_name): Use obstack_strdup.
3255         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3256         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3257         Use obstack_strdup.
3258
3259 2019-08-06  Tom Tromey  <tom@tromey.com>
3260
3261         * gdb_obstack.h (obstack_strdup): Define.
3262         * gdb_obstack.c (obstack_strdup): Don't define.
3263
3264 2019-08-06  Tom Tromey  <tom@tromey.com>
3265
3266         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3267         obstack_strdup.
3268         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3269         obstack_strdup.
3270         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3271         * stabsread.c (common_block_start): Use obstack_strdup.
3272         * objfiles.c (set_objfile_main_name, objfile): Use
3273         obstack_strdup.
3274         * namespace.c (add_using_directive): Use obstack_strdup.
3275         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3276         * jit.c (finalize_symtab): Use obstack_strdup.
3277         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3278         (guess_partial_die_structure_name, partial_die_info::fixup)
3279         (dwarf2_name): Use obstack_strdup.
3280         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3281         obstack_strdup.
3282         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3283         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3284         obstack_strdup.
3285         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3286
3287 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3288
3289         * unittests/help-doc-selftests.c: New file.
3290         * Makefile.in: Add the new file.
3291
3292 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3293
3294         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3295         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3296         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3297         the trailing '.' is not output, and the first character is uppercased.
3298         (print_help_for_command): Update call to print_doc_line.
3299         (print_doc_of_command): Likewise.
3300         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3301         * cli/cli-option.c (append_indented_doc): Do not append newline.
3302         (build_help_option): Append newline after first appended_indented_doc
3303         only if a second call is done.
3304         (build_help): Append 2 new lines before each option, except the first
3305         one.
3306         * compile/compile.c (_initialize_compile): Add new lines after
3307         %OPTIONS%, when not at the end of the help.
3308         Change help doc or code
3309         producing the help doc to respect the invariants.
3310         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3311         Also removed the new line after 'Options:', as all other commands
3312         do not put an empty line between 'Options:' and the first option.
3313         * printcmd.c (_initialize_printcmd): Likewise.
3314         * stack.c (_initialize_stack): Likewise.
3315         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3316         incorrectly telling COMMAND is optional.
3317         * ada-lang.c (_initialize_ada_language): Change help doc or code
3318         producing the help doc to respect the invariants.
3319         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3320         * breakpoint.c (_initialize_breakpoint): Likewise.
3321         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3322         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3323         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3324         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3325         _initialize_cli_style): Likewise.
3326         * corelow.c (core_target_info): Likewise.
3327         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3328         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3329         * filesystem.c (_initialize_filesystem): Likewise.
3330         * frame.c (_initialize_frame): Likewise.
3331         * gnu-nat.c (add_task_commands): Likewise.
3332         * infcall.c (_initialize_infcall): Likewise.
3333         * infcmd.c (_initialize_infcmd): Likewise.
3334         * interps.c (_initialize_interpreter): Likewise.
3335         * language.c (_initialize_language): Likewise.
3336         * linux-fork.c (_initialize_linux_fork): Likewise.
3337         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3338         * maint.c (_initialize_maint_cmds): Likewise.
3339         * memattr.c (_initialize_mem): Likewise.
3340         * printcmd.c (_initialize_printcmd): Likewise.
3341         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3342         _RegEx): Likewise.
3343         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3344         * record-btrace.c (_initialize_record_btrace): Likewise.
3345         * record-full.c (_initialize_record_full): Likewise.
3346         * record.c (_initialize_record): Likewise.
3347         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3348         * regcache.c (_initialize_regcache): Likewise.
3349         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3350         _initialize_remote): Likewise.
3351         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3352         * serial.c (_initialize_serial): Likewise.
3353         * skip.c (_initialize_step_skip): Likewise.
3354         * source.c (_initialize_source): Likewise.
3355         * stack.c (_initialize_stack): Likewise.
3356         * symfile.c (_initialize_symfile): Likewise.
3357         * symtab.c (_initialize_symtab): Likewise.
3358         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3359         * top.c (init_main): Likewise.
3360         * tracefile-tfile.c (tfile_target_info): Likewise.
3361         * tracepoint.c (_initialize_tracepoint): Likewise.
3362         * tui/tui-win.c (_initialize_tui_win): Likewise.
3363         * utils.c (add_internal_problem_command): Likewise.
3364         * valprint.c (value_print_option_defs): Likewise.
3365
3366 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3367
3368         PR build/24886
3369         * configure.ac: Drop enable-libmcheck support.
3370         * configure, config.in: Rebuild.
3371         * libmcheck.m4: Remove.
3372         * acinclude.m4: Don't include it.
3373         * Makefile.in: Don't distribute it.
3374         * top.c (print_gdb_configuration): Don't mention it.
3375
3376 2019-08-06  Tom Tromey  <tom@tromey.com>
3377
3378         * utils.c (set_output_style): Sometimes pass stream to
3379         emit_style_escape.
3380         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3381         * record-btrace.c (btrace_insn_history): Update.
3382         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3383         method.
3384         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3385         Update initializers.
3386         <m_uiout>: New field.
3387         <m_di>: Move lower.
3388         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3389         Remove "uiout" parameter.
3390         (dump_insns): Update.
3391         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3392         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3393
3394 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3395
3396         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3397         (error_in_psymtab_expansion): Likewise.
3398         (lookup_symbol_via_quick_fns): Likewise.
3399         (basic_lookup_transparent_type_quick): Likewise.
3400         (basic_lookup_transparent_type_1): Likewise.
3401
3402 2019-08-06  Tom Tromey  <tromey@adacore.com>
3403
3404         * source.c (last_source_error): Now bool.
3405         (print_source_lines_base): Make "noprint" bool.  Only open
3406         source file when last_source_visited changes.
3407
3408 2019-08-06  Tom Tromey  <tromey@adacore.com>
3409
3410         * annotate.c (annotate_source_line): Use g_source_cache.
3411         * source-cache.c (source_cache::get_plain_source_lines): Change
3412         parameters.  Populate m_offset_cache.
3413         (source_cache::ensure): New method.
3414         (source_cache::get_line_charpos): New method.
3415         (extract_lines): Move lower.  Change parameters.
3416         (source_cache::get_source_lines): Move lower.
3417         * source-cache.h (class source_cache): Update comment.
3418         <get_line_charpos>: New method.
3419         <get_source_lines>: Update comment.
3420         <clear>: Clear m_offset_cache.
3421         <get_plain_source_lines>: Change parameters.
3422         <ensure>: New method
3423         <m_offset_cache>: New member.
3424         * source.c (forget_cached_source_info_for_objfile): Update.
3425         (info_source_command): Use g_source_cache.
3426         (find_source_lines, open_source_file_with_line_charpos): Remove.
3427         (print_source_lines_base, search_command_helper): Use g_source_cache.
3428         * source.h (open_source_file_with_line_charpos): Don't declare.
3429         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3430         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3431         Use g_source_cache.
3432
3433 2019-08-06  Tom Tromey  <tromey@adacore.com>
3434
3435         * source-cache.c (source_cache::get_plain_source_lines):
3436         Remove "first_line" and "last_line" parameters.
3437         (source_cache::get_source_lines): Cache plain text.
3438         * source-cache.h (class source_cache)
3439         <get_plain_source_lines>: Update.
3440
3441 2019-08-06  Tom Tromey  <tromey@adacore.com>
3442
3443         * source-cache.c (extract_lines): No longer a method.
3444         Changed type of parameter.  Include final newline.
3445         (selftests::extract_lines_test): New function.
3446         (_initialize_source_cache): Likewise.
3447         * source-cache.h (class source_cache)
3448         <extract_lines>: Don't declare.
3449
3450 2019-08-06  Tom Tromey  <tromey@adacore.com>
3451
3452         * breakpoint.c (init_breakpoint_sal): Update.
3453         (breakpoint): Update.
3454         * breakpoint.h (struct breakpoint) <filter>: Now a
3455         unique_xmalloc_ptr.
3456
3457 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3458
3459         * NEWS: Mention dictionary access on blocks.
3460         * python/py-block.c (blpy_getitem): New function.
3461         (block_object_as_mapping): New struct.
3462         (block_object_type): Use new struct for tp_as_mapping field.
3463
3464 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3465
3466         * objfiles.h (objfile): Add a comment describing partial symbols.
3467
3468 2019-08-05  Tom Tromey  <tromey@adacore.com>
3469
3470         * compile/compile.c (_initialize_compile): Use _(), not N_().
3471         * thread.c (_initialize_thread): Use _(), not N_().
3472         * stack.c (_initialize_stack): Use _(), not N_().
3473         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3474
3475 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3476
3477         * dwarf2read.c (struct dw2_symtab_iterator):
3478         <want_specific_block>: Remove.
3479         <block_index>: Change type to gdb::optional.
3480         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3481         change type of BLOCK_INDEX parameter to gdb::optional.
3482         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3483         (dw2_lookup_symbol): Don't pass argument for
3484         WANT_SPECIFIC_BLOCK.
3485         (dw2_expand_symtabs_for_function): Don't pass argument for
3486         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3487         (class dw2_debug_names_iterator)
3488         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3489         parameter, change BLOCK_INDEX type to gdb::optional.
3490         <m_want_specific_block>: Remove.
3491         <m_block_index>: Change type to gdb::optional.
3492         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3493         gdb::optional.  Re-write in function of gdb::optional.
3494         (dw2_debug_names_lookup_symbol): Don't pass argument for
3495         WANT_SPECIFIC_BLOCK.
3496         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3497         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3498         BLOCK_INDEX.
3499
3500 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3501
3502         * NEWS: Mention changes to "info sources" command.
3503
3504 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3505
3506         * symtab.c (filename_partial_match_opts): New struct type.
3507         (struct output_source_filename_data): New members
3508         regexp, c_regexp, partial_match.
3509         (output_source_filename): Use new members to decide to print file.
3510         (info_sources_option_defs): New variable.
3511         (make_info_sources_options_def_group, print_info_sources_header,
3512         info_sources_command_completer):
3513         New functions.
3514         (info_sources_command): Read new optional arguments.
3515         (_initialize_symtab): Update info sources help.
3516
3517 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3518
3519         * ada-lang.c (exception_support_info_v0): Renamed from...
3520         (default_exception_support_info): ... this.  Create new
3521         definition for v1.
3522         (ada_has_this_exception_support): Look up catch_handlers_sym.
3523         (ada_exception_support_info_sniffer): Try v0 after default.
3524
3525 2019-08-01  Tom Tromey  <tromey@adacore.com>
3526
3527         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3528         gdbarch.h.
3529
3530 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3531
3532         * s12z-tdep.c: Fix include path for s12z-opc.h.
3533
3534 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3535
3536         * NEWS: Require GNU make 3.82.
3537
3538 2019-07-16  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3541         declare.
3542
3543 2019-07-30  Tom Tromey  <tromey@adacore.com>
3544
3545         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3546
3547 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3548
3549         * printcmd.c (print_address_symbolic): Print negative offsets.
3550         (build_address_symbolic): Force signed arithmetic when computing
3551         offset.
3552
3553 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3554
3555         PR/24474: Add a function to lookup static variables.
3556         * NEWS: Mention this new function.
3557         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3558         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3559         * python/python.c (python_GdbMethods): Add new function.
3560
3561 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3562
3563         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3564         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3565         (objfpy_lookup_static_symbol): New function.
3566         (objfile_object_methods): Add new functions.
3567
3568 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3569
3570         * NEWS: Mention 'set|show print frame-info'.  Mention new
3571         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3572         backtrace argument.  Mention that python frame filtering code
3573         is now consistent with what 'backtrace' command prints.
3574
3575 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3576
3577         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3578         comments.
3579         (print_frame_info_auto, print_frame_info_source_line,
3580         print_frame_info_location, print_frame_info_source_and_location,
3581         print_frame_info_location_and_address, print_frame_info_short_location):
3582         New declarations.
3583         (struct frame_print_options): New member print_frame_info.
3584         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3585         * stack.h (get_user_print_what_frame_info): New declaration.
3586         (frame_show_address): New declaration.
3587         * stack.c (print_frame_arguments_choices): New value 'presence'.
3588         (print_frame_info_auto, print_frame_info_source_line,
3589         print_frame_info_location, print_frame_info_source_and_location,
3590         print_frame_info_location_and_address, print_frame_info_short_location,
3591         print_frame_info_choices, print_frame_info_print_what): New definitions.
3592         (print_frame_args): Only print dots for args if print frame-arguments
3593         is 'presence'.
3594         (frame_print_option_defs): New element for "frame-info".
3595         (get_user_print_what_frame_info): New function.
3596         (frame_show_address): Make non static.  Move comment to stack.h.
3597         (print_frame_info_to_print_what): New function.
3598         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3599         to decide what to print.
3600         (backtrace_command_1): Handle the new print_frame_arguments_presence
3601         value.
3602         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3603         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3604         (py_print_frame): In non-mi mode, use LOCATION as default for
3605         print_what, similarly to frame information printed directly by
3606         backtrace command. Handle frame-info user option in non MI mode.
3607
3608 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3609
3610         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3611         Add case for debugging 32-bit target on 64-bit host.  Revise
3612         comment.
3613
3614 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3615
3616         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3617         instead of find_function_entry_range_from_pc.
3618
3619 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3620
3621         * stack.c (find_frame_funname): Remove code which preferred
3622         minsym over symtab sym in "certain pathological cases".
3623
3624         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3625         parameter.  Change type of "do_demangle" to bool.
3626         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3627         Pass suitable "prefer_sym_over_minsym" flag to
3628         build_address_symbolic().  Don't output "+" for negative offsets.
3629         * printcmd.c (print_address_symbolic): Update invocation of
3630         build_address_symbolic to include a "prefer_sym_over_minsym"
3631         flag.
3632         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3633         Restrict cases in which use of minimal symbol is preferred to that
3634         of a found symbol.  Update comments.
3635
3636         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3637         for entry pc when entry pc is out of range for that FDE.
3638
3639 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3640
3641         PR gdb/24839:
3642         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3643         type.
3644
3645 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3646
3647         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3648         this function's Python signature.
3649
3650
3651 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3652
3653         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3654         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3655         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3656         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3657         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3658
3659
3660 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3661
3662         * h8300-tdep.c (h8300_register_name_common): New.
3663         h8300_register_name): Use h8300_register_name_common.
3664         (h8300s_register_name): Likewise.
3665         (h8300sx_register_name): Likewise.
3666         (h8300h_register_nam): New.
3667         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3668
3669
3670 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3671
3672         * arm-tdep.c (arm_skip_cmse_entry): New function.
3673         (arm_is_sgstubs_section): New function.
3674         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3675
3676 2019-07-22  Tom Tromey  <tom@tromey.com>
3677
3678         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3679         Don't self-assign.
3680
3681 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3682
3683         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3684         type_print.
3685
3686 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3687
3688         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3689         so that GDB doesn't match any msymbols when searching in the
3690         TYPES_DOMAIN.
3691         (print_symbol_info): Print using typedef_print or type_print based
3692         on the type of the symbol.  Add updated FIXME comment moved from...
3693         (_initialize_symtab): ... move and update FIXME comment to above.
3694
3695 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3696
3697         * NEWS: Mention adding -q option to "info types".
3698         * symtab.c (struct info_types_options): New struct.
3699         (info_types_options_defs): New variable.
3700         (make_info_types_options_def_group): New function.
3701         (info_types_command): Use gdb::option framework to parse options.
3702         (info_types_command_completer): New function.
3703         (_initialize_symtab): Extend the help text on "info types" and
3704         register command completer.
3705
3706 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3707
3708         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3709         (lookup_symbol_in_objfile): Change int to block_enum and add a
3710         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3711
3712 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3713
3714         * MAINTAINERS (Write After Approval): Add self.
3715
3716 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3717
3718         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3719         instruction to the dummy code region.
3720
3721 2019-07-19  Tom Tromey  <tromey@adacore.com>
3722
3723         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3724         (ARGSUSED, PARAMS, __func__): Remove rules.
3725
3726 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3727
3728         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3729         * features/arm/arm-with-iwmmxt.c: Remove.
3730         * features/arm/arm-with-iwmmxt.xml: Remove.
3731         * features/arm/arm-with-m-fpa-layout.c: Remove.
3732         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3733         * features/arm/arm-with-m-vfp-d16.c: Remove.
3734         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3735         * features/arm/arm-with-m.c: Remove.
3736         * features/arm/arm-with-m.xml: Remove.
3737         * features/arm/arm-with-neon.c: Remove.
3738         * features/arm/arm-with-neon.xml: Remove.
3739         * features/arm/arm-with-vfpv2.c: Remove.
3740         * features/arm/arm-with-vfpv2.xml: Remove.
3741         * features/arm/arm-with-vfpv3.c: Remove.
3742         * features/arm/arm-with-vfpv3.xml: Remove.
3743
3744 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3745
3746         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3747
3748 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3749
3750         * arch/aarch32.c (aarch32_create_target_description): Create
3751         target descriptions using features.
3752         * arch/arm.c (arm_create_target_description)
3753         (arm_create_mprofile_target_description): Likewise.
3754         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3755
3756 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3757
3758         * Makefile.in: Add new files.
3759         * aarch32-tdep.c: New file.
3760         * aarch32-tdep.h: New file.
3761         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3762         Call aarch32_read_description.
3763         * arch/aarch32.c: New file.
3764         * arch/aarch32.h: New file.
3765         * arch/arm.c (arm_create_target_description)
3766         (arm_create_mprofile_target_description): New function.
3767         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3768         (arm_create_target_description)
3769         (arm_create_mprofile_target_description): New declaration.
3770         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3771         read_description functions.
3772         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3773         Likewise.
3774         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3775         * arm-tdep.c (tdesc_arm_list): New variable.
3776         (arm_register_g_packet_guesses): Call create description functions.
3777         (arm_read_description) (arm_read_mprofile_description): New
3778         function.
3779         * arm-tdep.h (arm_read_description)
3780         (arm_read_mprofile_description): Add declaration.
3781         * configure.tgt: Add new files.
3782
3783 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3784
3785         * top.c (new_ui_command): Open specified terminal just once.
3786
3787 2019-07-18  Tom Tromey  <tromey@adacore.com>
3788
3789         * symtab.c (main_name): Constify return type.
3790         * symfile.c (set_initial_language): Update.
3791         * symtab.h (main_name): Constify return type.
3792
3793 2019-07-17  Tom Tromey  <tom@tromey.com>
3794
3795         * tui/tui-winsource.c (tui_update_source_window)
3796         (tui_update_source_window_as_is)
3797         (tui_update_source_windows_with_line): Remove return.
3798         * tui/tui-disasm.c (tui_show_disassem)
3799         (tui_show_disassem_and_update_source): Remove return.
3800         * tui/tui.c (tui_reset): Remove return.
3801         * tui/tui-wingeneral.c
3802         (tui_check_and_display_highlight_if_needed): Remove return.
3803
3804 2019-07-17  Tom Tromey  <tom@tromey.com>
3805
3806         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3807
3808 2019-07-17  Tom Tromey  <tom@tromey.com>
3809
3810         * tui/tui-winsource.h (struct tui_exec_info_window)
3811         (struct tui_source_window_base): Move from tui-data.h.
3812         * tui/tui-winsource.c: Move many method definitions from
3813         elsewhere.  Remove "structuring" comments.
3814         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3815         (tui_source_window_base::refresh_window): Move to
3816         tui-winsource.c.
3817         * tui/tui-win.c (tui_source_window_base::refresh_all)
3818         (tui_source_window_base::update_tab_width)
3819         (tui_source_window_base::set_new_height)
3820         (tui_source_window_base::do_make_visible_with_new_height): Move to
3821         tui-winsource.c.
3822         * tui/tui-source.h: Update.
3823         * tui/tui-source.c (tui_source_window_base::reset): Move to
3824         tui-winsource.c.
3825         * tui/tui-disasm.h: Update.
3826         * tui/tui-data.h (struct tui_exec_info_window): Move to
3827         tui-winsource.h.
3828         (struct tui_source_window_base): Likewise.
3829         * tui/tui-data.c (tui_source_window_base::clear_detail)
3830         (tui_source_window_base, ~tui_source_window_base): Move to
3831         tui-winsource.c.
3832
3833 2019-07-17  Tom Tromey  <tom@tromey.com>
3834
3835         * tui/tui-win.c (tui_resize_all)
3836         (tui_source_window_base::update_tab_width)
3837         (tui_adjust_win_heights): Update.
3838         (tui_win_info::make_invisible_and_set_new_height): Rename from
3839         make_invisible_and_set_new_height.
3840         * tui/tui-data.h (struct tui_win_info)
3841         <make_invisible_and_set_new_height>: New method.
3842
3843 2019-07-17  Tom Tromey  <tom@tromey.com>
3844
3845         * tui/tui.c: Update.
3846         * tui/tui-source.h (struct tui_source_window): Move from
3847         tui-data.h.
3848         * tui/tui-layout.c: Update.
3849         * tui/tui-disasm.c: Update.
3850         * tui/tui-data.h (struct tui_source_window): Move to
3851         tui-source.h.
3852
3853 2019-07-17  Tom Tromey  <tom@tromey.com>
3854
3855         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3856         tui-data.h.
3857         * tui/tui-data.h (struct tui_disasm_window): Move to
3858         tui-disasm.h.
3859
3860 2019-07-17  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-regs.h (struct tui_data_item_window): Move from
3863         tui-data.h.
3864         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3865         * tui/tui-data.h (struct tui_data_item_window): Move to
3866         tui-regs.h.
3867         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3868
3869 2019-07-17  Tom Tromey  <tom@tromey.com>
3870
3871         * tui/tui.c: Update.
3872         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3873         (tui_cmd_window::max_height): Move to tui-command.c.
3874         * tui/tui-layout.c: Update.
3875         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3876         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3877         tui-command.c.
3878         * tui/tui-command.h (struct tui_cmd_window): Move from
3879         tui-data.h.
3880         * tui/tui-command.c: Remove "structuring" comments.
3881         (tui_cmd_window::clear_detail)
3882         (tui_cmd_window::do_make_visible_with_new_height)
3883         (tui_cmd_window::max_height): Move from elsewhere.
3884
3885 2019-07-17  Tom Tromey  <tom@tromey.com>
3886
3887         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3888         Now static.
3889         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3890         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3891
3892 2019-07-17  Tom Tromey  <tom@tromey.com>
3893
3894         * tui/tui.c: Update.
3895         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3896         tui-regs.c.
3897         * tui/tui-windata.h: Remove file.
3898         * tui/tui-windata.c: Remove file.
3899         * tui/tui-win.c (tui_data_window::set_new_height)
3900         (tui_data_window::do_make_visible_with_new_height): Move to
3901         tui-regs.c.
3902         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3903         * tui/tui-regs.c: Remove "structuring" comments.
3904         (tui_data_window::first_data_item_displayed)
3905         (tui_data_window::delete_data_content_windows)
3906         (tui_data_window::erase_data_content)
3907         (tui_data_window::display_all_data)
3908         (tui_data_window::refresh_all)
3909         (tui_data_window::do_scroll_vertical)
3910         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3911         (tui_data_window::do_make_visible_with_new_height)
3912         (tui_data_window::refresh_window): Move from elsewhere.
3913         (_initialize_tui_regs): Move to end of file.
3914         * tui/tui-layout.c: Update.
3915         * tui/tui-hooks.c: Update.
3916         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3917         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3918         tui-regs.c.
3919         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3920
3921 2019-07-17  Tom Tromey  <tom@tromey.com>
3922
3923         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3924         seen.
3925
3926 2019-07-17  Tom Tromey  <tom@tromey.com>
3927
3928         * tui/tui-win.c (tui_source_window_base::set_new_height)
3929         (tui_source_window_base::do_make_visible_with_new_height): Use
3930         m_has_locator field directly.
3931         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3932         method.
3933         (struct tui_source_window_base) <has_locator>: Likewise.
3934
3935 2019-07-17  Tom Tromey  <tom@tromey.com>
3936
3937         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3938         Don't declare.
3939         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3940         Remove.
3941         * tui/tui-win.c (tui_source_window_base::set_new_height)
3942         (tui_source_window_base::set_new_height)
3943         (make_invisible_and_set_new_height)
3944         (tui_source_window_base::do_make_visible_with_new_height)
3945         (tui_source_window_base::do_make_visible_with_new_height):
3946         Update.
3947         * tui/tui-layout.c (show_source_disasm_command, show_data)
3948         (show_source_or_disasm_and_command): Update.
3949         * tui/tui-layout.c (show_layout): Update.
3950
3951 2019-07-17  Tom Tromey  <tom@tromey.com>
3952
3953         * tui/tui-layout.c (make_data_window): Remove.
3954         (show_data): Unify creation and re-initialization cases.
3955
3956 2019-07-17  Tom Tromey  <tom@tromey.com>
3957
3958         * tui/tui-layout.c (make_source_window, make_disasm_window):
3959         Remove.
3960         (show_data): Unify creation and re-initialization cases.
3961
3962 2019-07-17  Tom Tromey  <tom@tromey.com>
3963
3964         * tui/tui-layout.c (make_command_window): Remove.
3965         (show_source_disasm_command, show_source_or_disasm_and_command):
3966         Unify creation and re-initialization cases.
3967
3968 2019-07-17  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3971         creation and re-initialization cases.
3972
3973 2019-07-17  Tom Tromey  <tom@tromey.com>
3974
3975         * tui/tui-regs.c (tui_get_register): Return void.
3976
3977 2019-07-17  Tom Tromey  <tom@tromey.com>
3978
3979         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3980         Simplify.
3981
3982 2019-07-17  Tom Tromey  <tom@tromey.com>
3983
3984         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3985         resetting.
3986
3987 2019-07-17  Tom Tromey  <tom@tromey.com>
3988
3989         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3990         * tui/tui-regs.c (tui_reg_layout): New function.
3991         (tui_show_registers, tui_reg_command): Use it.
3992         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3993         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3994         parameters.
3995         (tui_layout_command): Remove.
3996
3997 2019-07-17  Tom Tromey  <tom@tromey.com>
3998
3999         * tui/tui-layout.h (tui/tui-layout): Return void.
4000         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4001
4002 2019-07-17  Tom Tromey  <tom@tromey.com>
4003
4004         * tui/tui-layout.c (show_source_disasm_command, show_data):
4005         Update.
4006         (reset_locator): Remove.
4007         (show_source_or_disasm_and_command): Update.
4008
4009 2019-07-17  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui-source.c (tui_source_window_base::reset): Remove
4012         win_type parameter.
4013         * tui/tui-layout.c (make_command_window, make_source_window)
4014         (make_disasm_window, make_data_window)
4015         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4016         (reset_locator, show_source_or_disasm_and_command): Update.
4017         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4018         win_type parameter.
4019         (struct tui_source_window_base) <reset>: Likewise.
4020
4021 2019-07-17  Tom Tromey  <tom@tromey.com>
4022
4023         * tui/tui-layout.c (show_source_disasm_command): Use
4024         reset_locator.
4025         (reset_locator): New function.
4026         (init_and_make_win): Remove.
4027         (show_source_or_disasm_and_command): Use reset_locator.
4028
4029 2019-07-17  Tom Tromey  <tom@tromey.com>
4030
4031         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4032         condition.
4033         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4034         Remove condition.
4035         * tui/tui-source.c (tui_source_window_base::reset): New method.
4036         * tui/tui-layout.c (make_command_window): Don't call
4037         init_and_make_win.
4038         (make_source_window, make_disasm_window): Don't call
4039         make_source_or_disasm_window.
4040         (make_data_window): Don't call init_and_make_win.  Change calling
4041         convention.
4042         (show_source_disasm_command, show_data): Simplify.
4043         (make_source_or_disasm_window): Remove.
4044         (show_source_or_disasm_and_command): Simplify.
4045         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4046         (struct tui_source_window_base) <reset>: Likewise.
4047         <execution_info>: Remove initializer.
4048         * tui/tui-data.c (tui_source_window_base): Initialize
4049         execution_info.
4050
4051 2019-07-17  Tom Tromey  <tom@tromey.com>
4052
4053         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4054         variable.
4055
4056 2019-07-17  Tom Tromey  <tom@tromey.com>
4057
4058         * tui/tui.c (tui_rl_other_window): Update.
4059         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4060         superclass method first.  Always iterate over regs_content.
4061         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4062         method.
4063         * tui/tui-win.c (tui_set_focus_command): Update.
4064
4065 2019-07-17  Tom Tromey  <tom@tromey.com>
4066
4067         * tui/tui-win.c (tui_set_focus_command): Rename from
4068         tui_set_focus.  Call tui_enable.
4069         (tui_set_focus_command): Remove.
4070
4071 2019-07-17  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4074         refresh_window.
4075         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4076         touchwin.
4077         (tui_data_window::refresh_window): Call refresh_window on data
4078         items.  Always call superclass refresh_window.
4079         (tui_win_info::refresh): Remove.
4080         (tui_source_window_base::refresh_window): Update.
4081         (tui_refresh_all): Update.
4082         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4083         refresh_window.
4084         (show_source_or_disasm_and_command): Likewise.
4085         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4086         (struct tui_source_window_base) <refresh>: Likewise.
4087
4088 2019-07-17  Tom Tromey  <tom@tromey.com>
4089
4090         * tui/tui-winsource.c (tui_clear_source_content)
4091         (tui_show_source_content): Update.
4092         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4093         whether content is empty.
4094         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4095         Remove.
4096
4097 2019-07-17  Tom Tromey  <tom@tromey.com>
4098
4099         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4100         window's contents.
4101         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4102         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4103
4104 2019-07-17  Tom Tromey  <tom@tromey.com>
4105
4106         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4107         (struct tui_data_item_window): Update.
4108
4109 2019-07-17  Tom Tromey  <tom@tromey.com>
4110
4111         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4112         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4113         defines.
4114
4115 2019-07-17  Tom Tromey  <tom@tromey.com>
4116
4117         * tui/tui-winsource.h (tui_erase_source_content)
4118         (tui_clear_source_content): Remove "display_prompt" parameter.
4119         * tui/tui-winsource.c (tui_update_source_window_as_is)
4120         (tui_update_source_windows_with_addr): Update.
4121         (tui_clear_source_content): Remove "display_prompt" parameter.
4122         (tui_erase_source_content): Likewise.  Simplify.
4123         (tui_show_source_content): Update.
4124         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4125         * tui/tui-stack.c (tui_show_frame_info): Update.
4126         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4127         Remove defines.
4128
4129 2019-07-17  Tom Tromey  <tom@tromey.com>
4130
4131         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4132         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4133         parameter.
4134         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4135         parameter.
4136
4137 2019-07-17  Tom Tromey  <tom@tromey.com>
4138
4139         * tui/tui-winsource.c (tui_clear_source_content)
4140         (tui_show_source_content, tui_show_exec_info_content)
4141         (tui_clear_exec_info_content): Update.
4142         * tui/tui-stack.c (tui_show_locator_content): Update.
4143         (tui_show_frame_info): Update.
4144         * tui/tui-source.h (tui_source_window): Don't declare.
4145         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4146         from tui_source_is_displayed.
4147         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4148         Remove field.
4149         (struct tui_source_window_base) <content_in_use>: New field.  Now
4150         bool.
4151         (struct tui_source_window) <showing_source_p>: New method.
4152         (TUI_SRC_WIN): Change cast.
4153         * tui/tui-data.c (tui_initialize_static_data): Update.
4154
4155 2019-07-17  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4158         location_matches_p.
4159         * tui/tui-source.c (tui_source_window::location_matches_p): New
4160         method.
4161         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4162         method.
4163         * tui/tui-data.h (struct tui_source_window_base)
4164         <location_matches_p>: New method.
4165         (struct tui_source_window, struct tui_disasm_window)
4166         <location_matches_p>: Likewise.
4167
4168 2019-07-17  Tom Tromey  <tom@tromey.com>
4169
4170         * tui/tui-win.c (tui_set_win_height_command): Rename from
4171         tui_set_win_height.
4172         (tui_set_win_height_command): Remove.
4173
4174 2019-07-17  Tom Tromey  <tom@tromey.com>
4175
4176         * tui/tui-source.c (tui_source_window): New constructor.  Add
4177         observer.
4178         (~tui_source_window): New destructor.
4179         (tui_source_window::style_changed): New method.
4180         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4181         (tui_attach_detach_observers): Update.
4182         * tui/tui-data.h (struct tui_source_window): Make constructor not
4183         inline.  Add destructor.
4184         (struct tui_source_window) <style_changed>: New method.
4185         <m_observable>: New member.
4186
4187 2019-07-17  Tom Tromey  <tom@tromey.com>
4188
4189         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4190         * tui/tui-win.c (tui_resize_all): Fix typo.
4191
4192 2019-07-17  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4195         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4196         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4197         * tui/tui-win.c (window_name_completer): Use foreach.
4198         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4199         (update_tab_width): Likewise.
4200         * tui/tui-layout.c (show_layout): Update.
4201         * tui/tui-data.h (class tui_window_iterator): New.
4202         (struct all_tui_windows): New.
4203         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4204
4205 2019-07-17  Tom Tromey  <tom@tromey.com>
4206
4207         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4208         parameter.  Don't reference globals.
4209         (tui_reg_command): Update.
4210
4211 2019-07-17  Tom Tromey  <tom@tromey.com>
4212
4213         * tui/tui-regs.c (tui_show_registers): Simplify.
4214
4215 2019-07-17  Tom Tromey  <tom@tromey.com>
4216
4217         * tui/tui-regs.c (tui_show_registers): Update.
4218         (tui_show_register_group): Add win_info parameter.
4219
4220 2019-07-17  Tom Tromey  <tom@tromey.com>
4221
4222         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4223         Rename from tui_display_reg_element_at_line.
4224         (tui_data_window::display_registers_from_line): Update.
4225         * tui/tui-data.h (struct tui_data_window)
4226         <display_reg_element_at_line>: New method.
4227
4228 2019-07-17  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-regs.h (tui_display_registers_from)
4231         (tui_display_registers_from_line): Don't declare.
4232         * tui/tui-windata.c (tui_data_window::display_all_data)
4233         (tui_data_window::refresh_all)
4234         (tui_data_window::do_scroll_vertical): Update.
4235         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4236         from tui_display_registers_from.
4237         (tui_display_reg_element_at_line): Update.
4238         (tui_data_window::display_registers_from_line): Rename from
4239         tui_display_registers_from_line.
4240         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4241         display_registers_from_line>: New methods.
4242
4243 2019-07-17  Tom Tromey  <tom@tromey.com>
4244
4245         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4246         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4247         from tui_erase_data_content.
4248         (tui_data_window::display_all_data)
4249         (tui_data_window::refresh_all)
4250         (tui_data_window::do_scroll_vertical): Update.
4251         * tui/tui-regs.c (tui_show_registers): Update.
4252         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4253         New method.
4254
4255 2019-07-17  Tom Tromey  <tom@tromey.com>
4256
4257         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4258         declare.
4259         * tui/tui-windata.c
4260         (tui_data_window::delete_data_content_windows): Rename from
4261         tui_delete_data_content_windows.
4262         (tui_data_window::display_all_data)
4263         (tui_data_window::do_scroll_vertical): Update.
4264         * tui/tui-data.h (struct tui_data_window)
4265         <delete_data_content_windows>: New method.
4266
4267 2019-07-17  Tom Tromey  <tom@tromey.com>
4268
4269         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4270         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4271
4272 2019-07-17  Tom Tromey  <tom@tromey.com>
4273
4274         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4275         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4276         from tui_display_all_data.
4277         * tui/tui-win.c
4278         (tui_data_window::do_make_visible_with_new_height): Update.
4279         * tui/tui-regs.c (tui_show_registers): Update.
4280         * tui/tui-layout.c (tui_set_layout): Update.
4281         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4282         method.
4283
4284 2019-07-17  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4287         * tui/tui-windata.c (tui_display_data_from): Remove.
4288         (tui_data_window::refresh_all): Update.
4289
4290 2019-07-17  Tom Tromey  <tom@tromey.com>
4291
4292         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4293         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4294         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4295         tui_display_registers_from_line.
4296         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4297         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4298         "force_display" parameter.
4299
4300 2019-07-17  Tom Tromey  <tom@tromey.com>
4301
4302         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4303         declare.
4304         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4305         Rename from tui_first_reg_element_no_inline.
4306         (tui_display_reg_element_at_line)
4307         (tui_display_registers_from_line): Update.
4308         * tui/tui-data.h (struct tui_data_window)
4309         <first_reg_element_no_inline>: New method.
4310
4311 2019-07-17  Tom Tromey  <tom@tromey.com>
4312
4313         * tui/tui-windata.c (tui_display_data_from)
4314         (tui_data_window::do_scroll_vertical): Update.
4315         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4316         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4317         Rename from tui_line_from_reg_element_no.
4318         (tui_display_registers_from_line): Update.
4319         * tui/tui-data.h (struct tui_data_window)
4320         <line_from_reg_element_no>: New method.
4321
4322 2019-07-17  Tom Tromey  <tom@tromey.com>
4323
4324         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4325         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4326         tui_last_regs_line_no.
4327         (tui_display_reg_element_at_line)
4328         (tui_display_registers_from_line): Update.
4329         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4330         method.
4331
4332 2019-07-17  Tom Tromey  <tom@tromey.com>
4333
4334         PR tui/24722:
4335         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4336         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4337         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4338         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4339         (tui_update_breakpoint_info): Likewise.
4340         * tui/tui-hooks.c (tui_event_create_breakpoint)
4341         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4342         Update.
4343
4344 2019-07-17  Tom Tromey  <tom@tromey.com>
4345
4346         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4347
4348 2019-07-17  Tom Tromey  <tom@tromey.com>
4349
4350         * tui/tui-winsource.c (tui_update_source_window_as_is)
4351         (tui_update_source_windows_with_addr): Update.
4352         * tui/tui-source.h (tui_set_source_content)
4353         (tui_show_symtab_source): Add "win_info" parameter.
4354         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4355         parameter.
4356         (tui_show_symtab_source): Likewise.
4357
4358 2019-07-17  Tom Tromey  <tom@tromey.com>
4359
4360         * tui/tui-wingeneral.c
4361         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4362
4363 2019-07-17  Tom Tromey  <tom@tromey.com>
4364
4365         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4366         (struct tui_cmd_window) <can_scroll>: New method.
4367         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4368         method.
4369
4370 2019-07-17  Tom Tromey  <tromey@adacore.com>
4371
4372         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4373         do_field_signed>: Rename.  Change type of "value".
4374         * ui-out.c (ui_out::field_signed): Rename from field_int.
4375         Change type of "value".
4376         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4377         type of "value".
4378         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4379         do_field_int.  Change type of "value".
4380         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4381         do_field_int.  Change type of "value".
4382         * tracepoint.c (trace_status_mi, tfind_1)
4383         (print_one_static_tracepoint_marker): Update.
4384         * thread.c (print_thread_info_1, print_selected_thread_frame):
4385         Update.
4386         * stack.c (print_frame, print_frame_info): Update.
4387         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4388         Update.
4389         * source.c (print_source_lines_base): Update.
4390         * skip.c (info_skip_command): Update.
4391         * record-btrace.c (btrace_ui_out_decode_error)
4392         (btrace_call_history_src_line): Update.
4393         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4394         Update.
4395         * progspace.c (print_program_space): Update.
4396         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4397         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4398         do_field_int.  Change type of "value".
4399         * mi/mi-out.c (mi_ui_out::do_table_begin)
4400         (mi_ui_out::do_table_header): Update.
4401         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4402         type of "value".
4403         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4404         (mi_cmd_data_list_changed_registers, output_register)
4405         (mi_cmd_data_read_memory, mi_load_progress)
4406         (mi_cmd_trace_frame_collected): Update.
4407         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4408         Update.
4409         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4410         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4411         (mi_cmd_var_list_children, varobj_update_one): Update.
4412         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4413         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4414         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4415         * inferior.c (print_inferior): Update.
4416         * gdb_bfd.c (print_one_bfd): Update.
4417         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4418         Update.
4419         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4420         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4421         do_field_int.  Change type of "value".
4422         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4423         do_field_int.  Change type of "value".
4424         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4425         (print_one_breakpoint_location, print_it_catch_fork)
4426         (print_one_catch_fork, print_it_catch_vfork)
4427         (print_one_catch_vfork, print_it_catch_solib)
4428         (print_it_catch_exec, print_it_ranged_breakpoint)
4429         (print_mention_watchpoint, print_mention_masked_watchpoint)
4430         (bkpt_print_it, update_static_tracepoint): Update.
4431         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4432         * break-catch-syscall.c (print_it_catch_syscall): Update.
4433         * ada-tasks.c (print_ada_task_info): Update.
4434         * ada-lang.c (print_it_exception, print_mention_exception):
4435         Update.
4436
4437 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4438
4439         PR breakpoints/24541
4440         * gdbarch.c: Regenerate.
4441         * gdbarch.h: Regenerate.
4442         * gdbarch.sh: Adjust return type and parameter types for
4443         'stap_adjust_register'.
4444         (i386_stap_adjust_register): Adjust signature and return new
4445         register name.
4446         * stap-probe.c (stap_parse_register_operand): Adjust use of
4447         'gdbarch_stap_adjust_register'.
4448
4449 2019-07-17  Tom Tromey  <tromey@adacore.com>
4450
4451         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4452         declare VEC.
4453         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4454         std::vector.
4455         (struct s390_process_info): Add initializers.
4456         (s390_add_process): Use new.
4457         (s390_linux_nat_target::low_forget_process): Use delete.
4458         (s390_linux_nat_target::low_new_fork)
4459         (s390_linux_nat_target::stopped_by_watchpoint)
4460         (s390_linux_nat_target::low_prepare_to_resume)
4461         (s390_linux_nat_target::insert_watchpoint)
4462         (s390_linux_nat_target::insert_hw_breakpoint)
4463         (s390_linux_nat_target::remove_watchpoint)
4464         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4465
4466 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4467
4468         * aarch64-fbsd-nat.c: Include regcache.h.
4469         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4470         argument.
4471         (aarch64_fbsd_nat_target::fetch_registers)
4472         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4473         variable.
4474         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4475
4476 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4477
4478         * fbsd-nat.c: Include gdbarch.h.
4479
4480 2019-07-15  Tom Tromey  <tromey@adacore.com>
4481
4482         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4483
4484 2019-07-15  Tom Tromey  <tromey@adacore.com>
4485
4486         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4487         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4488         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4489         * cli-out.c (cli_ui_out::do_field_int): New method.
4490         * ui-out.c (ui_out::field_unsigned): New method.
4491         * symfile.c (generic_load): Use field_unsigned.
4492         (print_transfer_performance): Likewise.
4493         * record-btrace.c (ui_out_field_uint): Remove.
4494         (btrace_call_history_insn_range, btrace_call_history): Use
4495         field_unsigned.
4496         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4497         field_unsigned.
4498         * ui-out.h (class ui_out) <field_unsigned>: New method.
4499         <do_field_unsigned>: Likewise.
4500
4501 2019-07-15  Tom Tromey  <tromey@adacore.com>
4502
4503         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4504         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4505         * target.c (flash_erase_command): Use field_string.
4506         * infrun.c (print_signal_received_reason): Use field_string.
4507         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4508         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4509         field_string.
4510         * ada-tasks.c (print_ada_task_info): Use field_string.
4511
4512 2019-07-15  Tom Tromey  <tromey@adacore.com>
4513
4514         * target.c (flash_erase_command): Use field_core_addr.
4515         * symfile.c (generic_load): Use field_core_addr.
4516         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4517         Use field_core_addr.
4518         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4519         field_core_addr.
4520
4521 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4524         value if its desired type is smaller than a CORE_ADDR and signed.
4525
4526 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4527
4528         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4529         of changes to field names, and use new is_reference field to
4530         decide if a property is a reference or not.
4531         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4532         field.
4533         (struct dwarf2_property_baton): Update header comment, rename
4534         'referenced_type' to 'property_type' and update comments.
4535         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4536         default property type, store in property baton, update to take
4537         accound of renamed field.
4538         (read_func_scope): Update call to attr_to_dynamic_prop.
4539         (read_array_type): Likewise.
4540         (dwarf2_per_cu_addr_sized_int_type): New function.
4541         (read_subrange_index_type): Move type finding code to
4542         dwarf2_per_cu_addr_sized_int_type.
4543         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4544         (dwarf2_per_cu_addr_type): New function.
4545         (set_die_type): Update calls to attr_to_dynamic_prop.
4546
4547 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4548
4549         * dwarf2read.c (read_subrange_index_type): New function.
4550         (read_subrange_type): Move code into new function and call it.
4551         * gdbtypes.c (create_range_type): Add some asserts.
4552
4553 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4554
4555         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4556         update return statements.
4557         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4558         declaration, and update comment to match.
4559         * gdbtypes.c (resolve_dynamic_array): Update call to
4560         dwarf2_evaluate_property to match new return type.
4561
4562 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4563
4564         * valarith.c (value_subscripted_rvalue): Change lowerbound
4565         parameter type from int to LONGEST.
4566         * value.h (value_subscripted_rvalue): Likewise in declaration.
4567
4568 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4569
4570         * cli/cli-utils.c (info_print_command_completer): New function.
4571         * cli/cli-utils.h: Add 'completer.h' include, and forward
4572         declaration for 'struct cmd_list_element'.
4573         (info_print_command_completer): Declare.
4574         * stack.c (_initialize_stack): Add completer for 'info locals' and
4575         'info args'.
4576         * symtab.c (_initialize_symtab): Add completer for 'info
4577         variables' and 'info functions'.
4578         * NEWS: Mention completion for additional info commands.
4579
4580 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4581
4582         * cli/cli-utils.c (extract_info_print_args): Delete.
4583         (extract_arg_maybe_quoted): Delete.
4584         (info_print_options_defs): New variable.
4585         (make_info_print_options_def_group): New function.
4586         (extract_info_print_options): Define new function.
4587         * cli/cli-utils.h (extract_info_print_args): Delete.
4588         (struct info_print_options): New structure.
4589         (extract_info_print_options): Declare new function.
4590         * stack.c (info_locals_command): Update to use new
4591         extract_info_print_options, also add a header comment.
4592         (info_args_command): Likewise.
4593         * symtab.c (info_variables_command): Likewise.
4594         (info_functions_command): Likewise.
4595
4596 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4599         to extract string arguments.
4600         * common/common-utils.c (extract_string_maybe_quoted): New function.
4601         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4602
4603 2019-07-11  Tom Tromey  <tromey@adacore.com>
4604
4605         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4606         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4607         * top.h (gdbinit): Don't declare.
4608         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4609         into...
4610         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4611         * top.c (gdb_init): Don't call init_cli_cmds.
4612         (gdbinit): Remove.
4613         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4614
4615 2019-07-11  Tom Tromey  <tromey@adacore.com>
4616
4617         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4618         after it has been moved.
4619
4620 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4621
4622         * valops.c (value_must_coerce_to_target): Change return type to
4623         bool.
4624         * value.h (value_must_coerce_to_target): Likewise.
4625
4626 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4627
4628         * breakpoint.c (is_hardware_watchpoint): Remove
4629         forward-declaration.
4630         (is_masked_watchpoint): Change return type to bool.
4631         (is_tracepoint): Likewise.
4632         (is_breakpoint): Likewise.
4633         (is_hardware_watchpoint): Likewise.
4634         (is_watchpoint): Likewise.
4635         (is_no_memory_software_watchpoint): Likewise.
4636         (is_catchpoint): Likewise.
4637         (breakpoint_1): Make FILTER parameter's return type bool.
4638         is_masked_watchpoint): Change return type to bool.
4639         (save_breakpoints): Make FILTER parameter's return type bool.
4640         * breakpoint.h (is_breakpoint): Change return type to bool.
4641         (is_watchpoint): Likewise.
4642         (is_catchpoint): Likewise.
4643         (is_tracepoint): Likewise.
4644
4645 2019-07-10  Tom Tromey  <tom@tromey.com>
4646
4647         * defs.h: Don't include gdbarch.h.
4648         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4649         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4650         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4651         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4652         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4653         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4654         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4655         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4656         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4657         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4658         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4659         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4660         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4661         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4662         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4663         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4664         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4665         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4666         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4667         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4668         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4669         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4670         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4671         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4672         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4673         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4674         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4675
4676 2019-07-10  Tom Tromey  <tromey@adacore.com>
4677
4678         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4679         * breakpoint.c (init_ada_exception_breakpoint): Register as
4680         bp_catchpoint.
4681         (print_one_breakpoint_location, print_one_breakpoint): Use
4682         is_ada_exception_catchpoint.
4683         * ada-lang.c (class ada_catchpoint_location): Pass
4684         bp_loc_software_breakpoint to bp_location constructor.
4685         (is_ada_exception_catchpoint): New function.
4686
4687 2019-07-10  Tom Tromey  <tromey@adacore.com>
4688
4689         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4690         VEC.
4691         (struct arm_exidx_entry): New method operator<.
4692         (struct arm_exidx_data) <section_maps>: Change type.
4693         (arm_exidx_data_free): Remove.
4694         (arm_exidx_data_key): Change type.  Move lower.
4695         (arm_exidx_new_objfile): Update.
4696         (arm_compare_exidx_entries): Remove.
4697         (arm_find_exidx_entry, _initialize_arm_tdep)
4698
4699 2019-07-10  Tom Tromey  <tromey@adacore.com>
4700
4701         * solib-spu.c (ocl_program_data_key): Change type.
4702         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4703         Update.
4704
4705 2019-07-10  Tom Tromey  <tromey@adacore.com>
4706
4707         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4708         (struct solib_aix_inferior_data) <library_list>: Change type.
4709         (solib_aix_inferior_data_handle): Change type.
4710         (get_solib_aix_inferior_data): Update.
4711         (solib_aix_free_library_list): Remove.
4712         (library_list_start_library): Update.
4713         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4714         return type.
4715         (solib_aix_get_library_list)
4716         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4717         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4718
4719 2019-07-10  Tom Tromey  <tromey@adacore.com>
4720
4721         * solib-dsbt.c (struct dsbt_info): Add initializers.
4722         (solib_dsbt_pspace_data): Change type.
4723         (dsbt_pspace_data_cleanup): Remove.
4724         (get_dsbt_info, _initialize_dsbt_solib): Update.
4725
4726 2019-07-10  Tom Tromey  <tromey@adacore.com>
4727
4728         * spu-tdep.c (spu_overlay_data): Change type.
4729         (spu_get_overlay_table, spu_overlay_new_objfile)
4730         (_initialize_spu_tdep): Update.
4731
4732 2019-07-10  Tom Tromey  <tromey@adacore.com>
4733
4734         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4735         destructor.
4736         (dbx_objfile_data_key): Change type and declare later.
4737         (DBX_SYMFILE_INFO): Rewrite.
4738         * dbxread.c (dbx_objfile_data_key): Change type.
4739         (dbx_symfile_init): Update.
4740         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4741         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4742         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4743
4744 2019-07-10  Tom Tromey  <tromey@adacore.com>
4745
4746         * jit.c (jit_program_space_key): Change type.  Move lower.
4747         (get_jit_program_space_data): Update.
4748         (jit_program_space_data_cleanup): Remove.
4749         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4750         Update.
4751         (struct jit_program_space_data): Add initializers.
4752
4753 2019-07-10  Tom Tromey  <tromey@adacore.com>
4754
4755         * solib-darwin.c (struct darwin_info): Add initializers.
4756         (solib_darwin_pspace_data): Change type.
4757         (darwin_pspace_data_cleanup): Remove.
4758         (get_darwin_info, _initialize_darwin_solib): Update.
4759
4760 2019-07-10  Tom Tromey  <tromey@adacore.com>
4761
4762         * remote-sim.c (struct sim_inferior_data): Add initializers,
4763         constructor, and destructor.
4764         (sim_inferior_data_key): Change type.  Move lower.
4765         (check_for_duplicate_sim_descriptor): Update.
4766         (get_sim_inferior_data): Use new.  Update.
4767         (~sim_inferior_data_cleanup): Rename from
4768         sim_inferior_data_cleanup.  Simplify.
4769         (gdbsim_close_inferior, simulator_command)
4770         (sim_command_completer, _initialize_remote_sim): Update.
4771         (next_pid, INITIAL_PID): Move earlier.
4772
4773 2019-07-10  Tom Tromey  <tromey@adacore.com>
4774
4775         * python/python-internal.h (create_thread_object): Return
4776         gdbpy_ref.
4777         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4778         * python/py-inferior.c (struct threadlist_entry): Add
4779         constructor.
4780         <thread_obj>: Now a gdbpy_ref.
4781         (thread_to_thread_object): Update.
4782         (add_thread_object): Use new.
4783         (delete_thread_object): Use delete.
4784         (infpy_threads): Update.
4785         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4786         GIL.
4787
4788 2019-07-10  Tom Tromey  <tromey@adacore.com>
4789
4790         * valops.c (value_cast): Specialize error message for Ada.
4791
4792 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4793
4794         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4795
4796 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4797
4798         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4799         bpstat_should_step): Return bool, adjust comments.
4800         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4801         bpstat_should_step): Likewise.
4802
4803 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4804
4805         * features/Makefile: Use feature target descriptions for Arm.
4806         * features/arm/arm-core.c: Generate new file.
4807         * features/arm/arm-fpa.c: Likewise.
4808         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4809         * features/arm/arm-m-profile.c: Likewise.
4810         * features/arm/arm-vfpv2.c: Likewise.
4811         * features/arm/arm-vfpv3.c: Likewise.
4812         * features/arm/xscale-iwmmxt.c: Likewise.
4813         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4814
4815 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4816
4817         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4818         ptrace earlier.
4819
4820 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4821
4822         * features/aarch64-pauth.c: Regenerate.
4823
4824 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4825
4826         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4827         bool.
4828         (bpstat_what): Use false instead of 0.
4829
4830 2019-07-09  Pedro Alves  <palves@redhat.com>
4831
4832         * break-catch-throw.c (is_exception_catchpoint): New.
4833         * breakpoint.c (print_one_breakpoint_location): New parameter
4834         'raw_loc'.  Handle it.  Use
4835         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4836         looking at the breakpoint's type.
4837         (print_one_breakpoint): If handling "maint info breakpoints", also
4838         print locations of exception catchpoints.
4839         * breakpoint.h (is_exception_catchpoint): Declare.
4840
4841 2019-07-09  Pedro Alves  <palves@redhat.com>
4842
4843         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4844         "addr" field.
4845         (allocate_location_exception_catchpoint): New.
4846         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4847         (initialize_throw_catchpoint_ops): Install
4848         allocate_location_exception_catchpoint as allocate_location
4849         method.
4850         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4851         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4852         bp_loc_other.
4853         (breakpoint_address_is_meaningful): Delete.
4854         (bl_address_is_meaningful): New.
4855         (breakpoint_locations_match): Adjust comment.
4856         (bp_location_from_bp_type): New, factored out of...
4857         (bp_location::bp_location(breakpoint *)): ... this.
4858         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4859         factored out of...
4860         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4861         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4862         breakpoint_address_is_meaningful.
4863         (bp_locations_compare): Adjust comment.
4864         (update_global_location_list): Use bl_address_is_meaningful
4865         instead of breakpoint_address_is_meaningful.
4866         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4867         explicit.
4868         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4869         * python/py-breakpoint.c (bppy_get_location): No longer check
4870         whether location is null.
4871
4872 2019-07-09  Pedro Alves  <palves@redhat.com>
4873
4874         PR c++/15468
4875         * breakpoint.c (print_one_breakpoint_location): Remove
4876         single-location assert.
4877
4878 2019-07-09  Tom Tromey  <tom@tromey.com>
4879
4880         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4881         * configure: Rebuild.
4882         * configure.ac: Change common to gdbsupport.
4883         * gdbsupport: Rename from common.
4884         * acinclude.m4: Change common to gdbsupport.
4885         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4886         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4887         gdbsupport.
4888         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4889         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4890         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4891         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4892         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4893         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4894         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4895         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4896         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4897         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4898         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4899         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4900         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4901         coff-pe-read.c, command.h, compile/compile-c-support.c,
4902         compile/compile-c.h, compile/compile-cplus-symbols.c,
4903         compile/compile-cplus-types.c, compile/compile-cplus.h,
4904         compile/compile-loc2c.c, compile/compile.c, completer.c,
4905         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4906         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4907         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4908         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4909         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4910         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4911         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4912         features/aarch64-core.c, features/aarch64-fpu.c,
4913         features/aarch64-pauth.c, features/aarch64-sve.c,
4914         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4915         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4916         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4917         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4918         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4919         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4920         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4921         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4922         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4923         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4924         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4925         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4926         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4927         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4928         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4929         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4930         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4931         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4932         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4933         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4934         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4935         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4936         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4937         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4938         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4939         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4940         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4941         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4942         minsyms.c, mips-linux-tdep.c, namespace.h,
4943         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4944         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4945         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4946         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4947         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4948         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4949         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4950         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4951         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4952         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4953         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4954         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4955         procfs.c, producer.c, progspace.h, psymtab.h,
4956         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4957         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4958         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4959         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4960         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4961         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4962         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4963         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4964         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4965         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4966         target-memory.c, target.c, target.h, target/waitstatus.c,
4967         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4968         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4969         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4970         unittests/array-view-selftests.c,
4971         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4972         unittests/common-utils-selftests.c,
4973         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4974         unittests/format_pieces-selftests.c,
4975         unittests/function-view-selftests.c,
4976         unittests/lookup_name_info-selftests.c,
4977         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4978         unittests/mkdir-recursive-selftests.c,
4979         unittests/observable-selftests.c,
4980         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4981         unittests/parse-connection-spec-selftests.c,
4982         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4983         unittests/scoped_fd-selftests.c,
4984         unittests/scoped_mmap-selftests.c,
4985         unittests/scoped_restore-selftests.c,
4986         unittests/string_view-selftests.c, unittests/style-selftests.c,
4987         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4988         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4989         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4990         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4991         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4992         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4993
4994 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4997         bool value.
4998         (decode_digits_ordinary): Set explicit_line field in sal.
4999         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5000         symtab_and_line that was set on an explicit line number in
5001         assembler code.  Do always update the recorded symtab and line if
5002         we do skip the prologue.
5003
5004 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5005
5006         * breakpoint.c (set_breakpoint_location_function): Remove
5007         explicit_loc parameter.
5008         (momentary_breakpoint_from_master): Update call to
5009         set_breakpoint_location_function.
5010         (add_location_to_breakpoint): Likewise.
5011
5012 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5013
5014         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5015         required features based on default bfd type when no specific bfd
5016         is present.
5017
5018 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5019
5020         * NEWS: Mention that GDB printf and eval commands can now print
5021         C-style and Ada-style convenience var strings without
5022         calling the inferior.
5023         * printcmd.c (printf_c_string): Locally print GDB internal var
5024         instead of transiting via the inferior.
5025         (printf_wide_c_string): Likewise.
5026
5027 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5028
5029         PR breakpoints/25011
5030         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5031
5032 2019-07-04  Tom Tromey  <tom@tromey.com>
5033
5034         PR tui/24724:
5035         * tui/tui-winsource.c (tui_clear_source_content): Update.
5036         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5037         (tui_update_breakpoint_info): Update.
5038         (tui_set_exec_info_content): Update.
5039         * tui/tui-source.c (tui_set_source_content_nil): Update.
5040         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5041         has_break.
5042         * tui/tui-data.h (enum tui_bp_flag): New.
5043         (tui_bp_flags): New enum flags type.
5044         (struct tui_source_element) <break_mode>: Change type.  Rename
5045         from has_break.
5046         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5047         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5048         constants.
5049         * tui/tui-winsource.h: Fix comment.
5050
5051 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5052
5053         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5054         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5055         (store_fpregs_to_thread)
5056         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5057         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5058         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5059         (IWMMXT_REGS_SIZE): Add define.
5060         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5061         (fetch_vfp_regs, store_vfp_regs)
5062         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5063         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5064
5065 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5066
5067         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5068         defines.
5069         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5070         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5071         (ARM_INT_REGISTER_SIZE): ...to this.
5072         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5073         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5074         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5075         (arm_linux_collect_gregset, supply_nwfpe_register)
5076         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5077         defines.
5078         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5079         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5080         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5081         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5082         (arm_return_in_memory, arm_store_return_value)
5083         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5084         (arm_record_ld_st_multiple): Likewise.
5085         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5086         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5087
5088 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5089
5090         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5091         AARCH64_DISPLACED_MODIFIED_INSNS.
5092         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5093         (aarch64_displaced_step_copy_insn): Likewise.
5094         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5095         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5096         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5097         ARM_DISPLACED_MODIFIED_INSNS.
5098         * arm-tdep.c (arm_gdbarch_init): Likewise.
5099         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5100         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5101         (struct arm_displaced_step_closure): Use
5102         ARM_DISPLACED_MODIFIED_INSNS.
5103
5104 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5105
5106         * features/Makefile: Remove unused xml files.
5107         * features/aarch64.xml: Remove.
5108         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5109         * features/i386/amd64-avx-avx512.xml: Remove.
5110         * features/i386/amd64-avx-linux.xml: Remove.
5111         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5112         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5113         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5114         * features/i386/amd64-avx-mpx.xml: Remove.
5115         * features/i386/amd64-avx.xml: Remove.
5116         * features/i386/amd64-linux.xml: Remove.
5117         * features/i386/amd64-mpx-linux.xml: Remove.
5118         * features/i386/amd64-mpx.xml: Remove.
5119         * features/i386/amd64.xml: Remove.
5120         * features/i386/i386-avx-avx512-linux.xml: Remove.
5121         * features/i386/i386-avx-avx512.xml: Remove.
5122         * features/i386/i386-avx-linux.xml: Remove.
5123         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5124         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5125         * features/i386/i386-avx-mpx-linux.xml: Remove.
5126         * features/i386/i386-avx-mpx.xml: Remove.
5127         * features/i386/i386-avx.xml: Remove.
5128         * features/i386/i386-linux.xml: Remove.
5129         * features/i386/i386-mmx-linux.xml: Remove.
5130         * features/i386/i386-mmx.xml: Remove.
5131         * features/i386/i386-mpx-linux.xml: Remove.
5132         * features/i386/i386-mpx.xml: Remove.
5133         * features/i386/i386.xml: Remove.
5134         * features/i386/x32-avx-avx512-linux.xml: Remove.
5135         * features/i386/x32-avx-linux.xml: Remove.
5136         * features/i386/x32-linux.xml: Remove.
5137
5138 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5139
5140         * regformats/aarch64.dat: Remove.
5141         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5142         * regformats/i386/amd64-avx-linux.dat: Remove.
5143         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5144         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5145         * regformats/i386/amd64-linux.dat: Remove.
5146         * regformats/i386/amd64-mpx-linux.dat: Remove.
5147         * regformats/i386/amd64.dat: Remove.
5148         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5149         * regformats/i386/i386-avx-linux.dat: Remove.
5150         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5151         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5152         * regformats/i386/i386-linux.dat: Remove.
5153         * regformats/i386/i386-mmx-linux.dat: Remove.
5154         * regformats/i386/i386-mpx-linux.dat: Remove.
5155         * regformats/i386/i386.dat: Remove.
5156         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5157         * regformats/i386/x32-avx-linux.dat: Remove.
5158         * regformats/i386/x32-linux.dat: Remove.
5159
5160 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5161
5162         * aarch64-tdep.c: Remove xml self tests.
5163         * amd64-linux-tdep.c: Likewise.
5164         * amd64-tdep.c: Likewise.
5165         * i386-linux-tdep.c: Likewise.
5166         * i386-tdep.c: Likewise.
5167
5168 2019-07-03  Pedro Alves  <palves@redhat.com>
5169
5170         PR cli/24732
5171         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5172         (pipe_cmd_option_defs): New.
5173         (make_pipe_cmd_options_def_group): New.
5174         (pipe_command): Use gdb::option::process_options.
5175         (pipe_command_completer): New function.
5176         (_initialize_cli_cmds): Install completer for "pipe" command.
5177
5178 2019-07-03  Pedro Alves  <palves@redhat.com>
5179
5180         * cli/cli-option.c (union option_value) <string>: New field.
5181         (struct option_def_and_value): Add ctor, move ctor, dtor and
5182         use DISABLE_COPY_AND_ASSIGN.
5183         (option_def_and_value::clear_value): New.
5184         (parse_option, save_option_value_in_ctx, get_val_type_str)
5185         (add_setshow_cmds_for_options): Handle var_string.
5186         * cli-option.h (union option_def::var_address) <string>: New
5187         field.
5188         (struct string_option_def): New.
5189         * maint-test-options.c (struct test_options_opts): Add default
5190         ctor and use DISABLE_COPY_AND_ASSIGN.
5191         <string_opt>: New field.
5192         (test_options_opts::~test_options_opts): New.
5193         (test_options_opts::dump): Also dump "-string".
5194         (test_options_option_defs): Install "string.
5195
5196 2019-07-03  Pedro Alves  <palves@redhat.com>
5197
5198         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5199         option_value with a null enumeration.
5200         (complete_options): Save the option values in the context.
5201         (save_option_value_in_ctx): New, factored out from ...
5202         (process_options): ... here.
5203         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5204         of the function.
5205         * maint-test-options.c (test_options_opts::dump): New, factored
5206         out from ...
5207         (maintenance_test_options_command_mode): ... here.
5208         (maintenance_test_options_command_completion_result): Delete.
5209         (maintenance_test_options_command_completion_text): Update
5210         comment.
5211         (maintenance_show_test_options_completion_result): Change
5212         prototype.  Just print
5213         maintenance_test_options_command_completion_text.
5214         (save_completion_result): New.
5215         (maintenance_test_options_completer_mode): Pass options context to
5216         complete_options, and then save a dump.
5217         (_initialize_maint_test_options): Use add_cmd to install "maint
5218         show test-options-completion-result".
5219
5220 2019-07-03  Pedro Alves  <palves@redhat.com>
5221
5222         * NEWS (New commands): Mention "with" and "maint with".
5223         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5224         (with_command, with_command_completer): New.
5225         (pipe_command): Adjust to new repeat_previous
5226         interface.
5227         (_initialize_cli_cmds): Install the "with" command and its "w"
5228         alias.
5229         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5230         declarations.
5231         * cli/cli-setshow.c (parse_cli_var_uinteger)
5232         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5233         argument strings for all var_types.
5234         (get_setshow_command_value_string): New, factored out from ...
5235         (do_show_command): ... this.
5236         * cli/cli-setshow.h: Include <string>.
5237         (get_setshow_command_value_string): Declare.
5238         * command.h (repeat_previous): Now returns const char *.  Adjust
5239         comment.
5240         * maint.c: Include "cli/cli-cmds.h".
5241         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5242         (_initialize_maint_cmds): Register the "maintenance with" command.
5243         * top.c (repeat_previous): Move bits from pipe_command here:
5244         Return the saved command line, if any; error out if there's no
5245         command to relaunch.
5246
5247 2019-07-03  Pedro Alves  <palves@redhat.com>
5248
5249         * NEWS (New commands): Mention "maint set/show test-settings"
5250         instead of "maint test-settings".
5251         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5252         (maintenance_test_settings_set_list): Rename to ...
5253         (maintenance_set_test_settings_list): ... this.
5254         (maintenance_test_settings_show_list): Rename to  ...
5255         (maintenance_show_test_settings_list): ... this.
5256         (maintenance_test_settings_cmd): Delete.
5257         (maintenance_test_settings_set_cmd): ...
5258         (maintenance_set_test_settings_cmd): ... this.
5259         (maintenance_test_settings_show_cmd): ...
5260         (maintenance_show_test_settings_cmd): ... this.
5261         (maintenance_test_settings_show_value_cmd):
5262         (maintenance_show_test_settings_value_cmd): ... this.
5263         (_initialize_maint_test_settings): No longer install the "maint
5264         test-settings" prefix command.  Rename "maint test-settings set"
5265         to "maint set test-settings", and "maint test-settings show" to
5266         "maint show test-settings".  Adjust all subcommands.
5267
5268 2019-07-03  Pedro Alves  <palves@redhat.com>
5269
5270         * maint-test-settings.c: Fix file's intro comment.  Replace all
5271         references to "test-options" with references to "test-settings",
5272         in comments.
5273
5274 2019-07-03  Pedro Alves  <palves@redhat.com>
5275
5276         * maint-test-settings.c (maintenance_test_settings_xxx)
5277         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5278         New.
5279         (maintenance_test_settings_enums): Use them.
5280         (maintenance_test_settings_enum): Default to
5281         maintenance_test_settings_xxx.
5282         (_initialize_maint_test_settings): Initialize
5283         MAINTENANCE_TEST_SETTINGS_FILENAME.
5284
5285 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5286
5287         * breakpoint.h (remove_breakpoints_inf): Change return type to
5288         void, move function documentation here.
5289         * breakpoint.c (remove_breakpoints_inf): Change return type to
5290         void, move function documentation to header.
5291
5292 2019-07-02  Pedro Alves  <palves@redhat.com>
5293
5294         * NEWS (Completion improvements): Mention "info threads".
5295         * thread.c (struct info_threads_opts, info_threads_option_defs)
5296         (make_info_threads_options_def_group): New.
5297         (info_threads_command): Use gdb::option::process_options.
5298         (info_threads_command_completer): New.
5299         (_initialize_thread): Use gdb::option::build_help to build the
5300         help text for "info threads".
5301
5302 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5303
5304         * defs.h (generic_load): Move from here...
5305         * symfile.h (generic_load): ... to here.  Rename name parameter
5306         to args.
5307         * symfile.c (generic_load): Add comment.
5308
5309 2019-07-01  Tom Tromey  <tromey@adacore.com>
5310
5311         * dwarf2read.c
5312         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5313         declaration of without_params.  Fix formatting.
5314
5315 2019-07-01  Tom Tromey  <tromey@adacore.com>
5316
5317         * ada-exp.y (find_primitive_type): Update.
5318         * ada-lang.h (ada_lookup_symbol): Update.
5319         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5320         parameter.
5321         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5322
5323 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5324
5325         PR breakpoints/24541
5326         * gdbarch.c: Regenerate.
5327         * gdbarch.h: Regenerate.
5328         * gdbarch.sh: Add 'stap_adjust_register'.
5329         * i386-tdep.c: Include '<unordered_set>'.
5330         (i386_stap_adjust_register): New function.
5331         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5332         * stap-probe.c (stap_parse_register_operand): Call
5333         'gdbarch_stap_adjust_register'.
5334
5335 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5336
5337         PR python/24742
5338         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5339         * python/python.c (do_start_initialization): Use 'xmalloc'
5340         instead of 'PyMem_Malloc'.
5341
5342 2019-06-28  Tom Tromey  <tromey@adacore.com>
5343
5344         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5345         for Ada.
5346
5347 2019-06-27  Tom Tromey  <tromey@adacore.com>
5348
5349         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5350         objfile_key.
5351         (arm_find_mapping_symbol, arm_record_special_symbol)
5352         (_initialize_arm_tdep): Update.
5353         (arm_objfile_data_free): Remove.
5354
5355 2019-06-27  Tom Tromey  <tromey@adacore.com>
5356
5357         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5358         to cp_print_static_field.
5359
5360 2019-06-26  Tom Tromey  <tromey@adacore.com>
5361
5362         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5363         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5364         declare.
5365
5366 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5367
5368         * features/aarch64-core.c (create_feature_aarch64_core):
5369         Regenerate.
5370         * features/aarch64-core.xml: Add cpsr flags.
5371
5372 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5373
5374         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5375         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5376
5377 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5378
5379         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5380         field.
5381         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5382         use.
5383         (arm_record_special_symbol): Don't insert new symbol in sorted
5384         position, push it at the end.
5385
5386 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5387
5388         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5389         (arm_mapping_symbol_s): Remove.
5390         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5391         (arm_mapping_symbol_vec): New typedef.
5392         (struct arm_per_objfile): Add constructor.
5393         <section_maps>: Change type to
5394         std::unique_ptr<arm_mapping_symbol_vec[]>.
5395         (arm_compare_mapping_symbols): Remove.
5396         (arm_find_mapping_symbol): Adjust to section_maps type change.
5397         (arm_objfile_data_free): Call delete on arm_per_objfile.
5398         (arm_record_special_symbol): Adjust to section_maps type change.
5399         Allocate arm_per_objfile with new.
5400
5401 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5402
5403         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5404         with the command prefix.
5405
5406 2019-06-25  Tom Tromey  <tom@tromey.com>
5407
5408         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5409         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5410
5411 2019-06-25  Tom Tromey  <tom@tromey.com>
5412
5413         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5414         type.
5415         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5416         protected.
5417
5418 2019-06-25  Tom Tromey  <tom@tromey.com>
5419
5420         * tui/tui-winsource.c
5421         (tui_source_window_base::set_is_exec_point_at): Add check against
5422         LOA_ADDRESS.
5423
5424 2019-06-25  Tom Tromey  <tom@tromey.com>
5425
5426         * tui/tui-source.c (tui_set_source_content): Don't check before
5427         xfree.
5428         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5429
5430 2019-06-25  Tom Tromey  <tom@tromey.com>
5431
5432         * tui/tui-winsource.h (tui_update_source_window_as_is)
5433         (tui_alloc_source_buffer, tui_line_is_displayed)
5434         (tui_addr_is_displayed): Change type of win_info.
5435         * tui/tui-winsource.c (tui_update_source_window_as_is)
5436         (tui_clear_source_content, tui_show_source_line)
5437         (tui_show_source_content, tui_source_window_base::refill)
5438         (tui_source_window_base::set_is_exec_point_at)
5439         (tui_source_window_base::set_is_exec_point_at)
5440         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5441         (tui_alloc_source_buffer, tui_line_is_displayed)
5442         (tui_addr_is_displayed): Change type of win_info.  Update.
5443         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5444         (tui_source_window_base::do_make_visible_with_new_height):
5445         Update.
5446         * tui/tui-source.c (tui_set_source_content)
5447         (tui_set_source_content_nil)
5448         (tui_source_window::do_scroll_vertical): Update.
5449         * tui/tui-layout.c (show_layout): Update.
5450         * tui/tui-disasm.c (tui_set_disassem_content)
5451         (tui_disasm_window::do_scroll_vertical): Update.
5452         * tui/tui-data.h (tui_win_content): Remove.
5453         (struct tui_gen_win_info) <content, content_size>: Remove.
5454         (struct tui_source_element): Add initializers and destructor.
5455         (union tui_which_element, struct tui_win_element): Remove.
5456         (struct tui_source_window_base) <content>: New field.
5457         (struct tui_data_window): Remove destructor.
5458         (tui_alloc_content, tui_free_win_content)
5459         (tui_free_all_source_wins_content): Don't declare.
5460         * tui/tui-data.c (tui_initialize_static_data): Update.
5461         (init_content_element, tui_alloc_content): Remove.
5462         (~tui_gen_win_info): Update.
5463         (~tui_data_window, tui_free_all_source_wins_content)
5464         (tui_free_win_content, free_content, free_content_elements):
5465         Remove.
5466
5467 2019-06-25  Tom Tromey  <tom@tromey.com>
5468
5469         * tui/tui-winsource.h (tui_clear_source_content)
5470         (tui_erase_source_content, tui_show_source_content): Change type
5471         of win_info.
5472         * tui/tui-winsource.c (tui_clear_source_content)
5473         (tui_erase_source_content, tui_show_source_content): Change type
5474         of win_info.
5475         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5476         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5477         win_info.
5478         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5479         win_info.
5480         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5481
5482 2019-06-25  Tom Tromey  <tom@tromey.com>
5483
5484         * tui/tui-winsource.c (tui_clear_source_content)
5485         (tui_source_window_base::set_is_exec_point_at): Update.
5486         * tui/tui-source.c (tui_set_source_content_nil): Update.
5487         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5488         a bool.
5489         * tui/tui-data.c (init_content_element): Update.
5490
5491 2019-06-25  Tom Tromey  <tom@tromey.com>
5492
5493         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5494         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5495         * tui/tui-layout.c (init_and_make_win): Update.
5496         * tui/tui.h (enum tui_win_type): Update.
5497         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5498         tui_win_is_auxillary.
5499         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5500         tui_win_is_auxillary.
5501
5502 2019-06-25  Tom Tromey  <tom@tromey.com>
5503
5504         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5505         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5506         (tui_delete_data_content_windows, tui_display_all_data)
5507         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5508         Update.
5509         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5510         * tui/tui-regs.c (tui_last_regs_line_no)
5511         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5512         (tui_show_registers): Update.
5513         (tui_show_register_group): Return void.  Update.
5514         (tui_display_registers_from, tui_display_reg_element_at_line)
5515         (tui_display_registers_from_line, tui_check_register_values):
5516         Update.
5517         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5518         member.
5519         (struct tui_data_window) <regs_content>: Now a std::vector.
5520         <regs_content_count>: Remove.
5521         (tui_add_content_elements, tui_free_data_content): Don't declare.
5522         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5523         (init_content_element): Remove DATA_WIN case.  Add assert.
5524         (tui_add_content_elements): Remove.
5525         (tui_data_window): Update.
5526         (tui_free_data_content): Remove.
5527         (free_content_elements): Remove DATA_WIN case.
5528
5529 2019-06-25  Tom Tromey  <tom@tromey.com>
5530
5531         * tui/tui-data.c (tui_data_item_window): Update.
5532         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5533         * tui/tui-windata.c (tui_display_all_data)
5534         (tui_display_data_from_line): Update.
5535         (tui_check_data_values): Remove.
5536         * tui/tui-regs.c (tui_show_register_group)
5537         (tui_display_reg_element_at_line): Update.
5538         * tui/tui-hooks.c (tui_register_changed)
5539         (tui_refresh_frame_and_register_information): Call
5540         tui_check_register_values.
5541         * tui/tui-data.h (struct tui_data_window) <data_content,
5542         data_content_count, data_type>: Remove.
5543         (enum tui_data_type): Remove.
5544
5545         * tui/tui-data.c (tui_data_window::clear_detail)
5546         (~tui_data_window): Update.
5547
5548 2019-06-25  Tom Tromey  <tom@tromey.com>
5549
5550         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5551         declare.
5552         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5553         Rename from tui_first_data_item_displayed.  Update.
5554         (tui_data_window::refresh_all)
5555         (tui_data_window::do_scroll_vertical): Update.
5556         * tui/tui-data.h (struct tui_data_window)
5557         <first_data_item_displayed>: Declare new method.
5558
5559 2019-06-25  Tom Tromey  <tom@tromey.com>
5560
5561         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5562         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5563         contents...
5564         (tui_initialize_static_data): ...here.
5565
5566 2019-06-25  Tom Tromey  <tom@tromey.com>
5567
5568         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5569         (tui_display_registers_from, tui_check_register_values): Update.
5570         (tui_display_register): Remove win_info parameter; update.
5571         (tui_get_register): Change type of parameters.
5572         * tui/tui-data.h (struct tui_data_element): Remove.
5573         (union tui_which_element) <data>: Remove.
5574         <data_window>: Change type.
5575         (struct tui_data_item_window): New.
5576         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5577         case.  Add assert.
5578         (~tui_data_item_window): New destructor.
5579         (free_content_elements): Remove DATA_ITEM_WIN case.
5580
5581 2019-06-25  Tom Tromey  <tom@tromey.com>
5582
5583         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5584         Remove.
5585
5586 2019-06-25  Tom Tromey  <tom@tromey.com>
5587
5588         * tui/tui-data.h (struct tui_command_element): Remove.
5589         (union tui_which_element) <command>: Remove.
5590         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5591         assert.
5592         (free_content_elements): Remove CMD_WIN case.
5593
5594 2019-06-25  Tom Tromey  <tom@tromey.com>
5595
5596         * tui/tui-layout.c (tui_set_layout): Update.
5597         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5598         * tui/tui-data.c (layout_def): Update.
5599
5600 2019-06-25  Tom Tromey  <tom@tromey.com>
5601
5602         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5603         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5604         (tui_source_window_base::set_new_height): Update.
5605         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5606         Update.
5607         (tui_set_locator_fullname, tui_set_locator_info)
5608         (tui_show_frame_info): Update.
5609         * tui/tui-source.c (tui_set_source_content)
5610         (tui_source_is_displayed): Update.
5611         * tui/tui-layout.c (show_source_disasm_command, show_data)
5612         (show_source_or_disasm_and_command): Update.
5613         * tui/tui-disasm.c (tui_set_disassem_content)
5614         (tui_get_begin_asm_address): Update.
5615         * tui/tui-data.h (struct tui_locator_element): Remove.
5616         (union tui_which_element) <locator>: Remove.
5617         (struct tui_locator_window): New.
5618         (tui_locator_win_info_ptr): Change return type.
5619         * tui/tui-data.c (_locator): Change type.
5620         (tui_locator_win_info_ptr): Change return type.
5621         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5622         (tui_alloc_content): Add assert.
5623
5624 2019-06-25  Tom Tromey  <tom@tromey.com>
5625
5626         * tui/tui-winsource.c
5627         (tui_exec_info_window::maybe_allocate_content): New method.
5628         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5629         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5630         (make_source_or_disasm_window): Add cast.
5631         * tui/tui-data.h (union tui_which_element) <simple_string>:
5632         Remove.
5633         (struct tui_source_info): New.
5634         (struct tui_source_window_base) <execution_info>: Change type.
5635         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5636         case, and add assert.
5637         (tui_alloc_content): Add assert.
5638
5639 2019-06-25  Tom Tromey  <tom@tromey.com>
5640
5641         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5642         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5643         * tui/tui-data.c (tui_alloc_win_info): Remove.
5644
5645 2019-06-25  Tom Tromey  <tom@tromey.com>
5646
5647         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5648         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5649         can_highlight.
5650
5651 2019-06-25  Tom Tromey  <tom@tromey.com>
5652
5653         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5654         make_visible_with_new_height method.
5655         (tui_win_info::make_visible_with_new_height): New method.
5656         (tui_source_window_base::do_make_visible_with_new_height)
5657         (tui_data_window::do_make_visible_with_new_height)
5658         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5659         (make_visible_with_new_height): Remove.
5660         (tui_resize_all, tui_adjust_win_heights): Use
5661         make_visible_with_new_height method.
5662         * tui/tui-data.h (struct tui_win_info)
5663         <do_make_visible_with_new_height, make_visible_with_new_height>:
5664         New methods.
5665         (struct tui_source_window_base, struct tui_data_window)
5666         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5667         methods.
5668
5669 2019-06-25  Tom Tromey  <tom@tromey.com>
5670
5671         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5672         method.
5673         (update_tab_width): Call update_tab_width method.
5674         * tui/tui-data.h (struct tui_win_info)
5675         (struct tui_source_window_base) <update_tab_width>: New methods.
5676
5677 2019-06-25  Tom Tromey  <tom@tromey.com>
5678
5679         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5680         parameter.
5681         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5682         parameter.
5683         (tui_gen_win_info::make_visible): Update.
5684         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5685         parameter.
5686         * tui/tui-data.h (enum tui_box): New enum.
5687         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5688
5689 2019-06-25  Tom Tromey  <tom@tromey.com>
5690
5691         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5692         init_and_make_win for EXEC_INFO_WIN.
5693         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5694         longer inline.
5695         (struct tui_win_info) <~tui_win_info>: Inline.
5696         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5697         Don't declare.
5698         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5699         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5700         Remove.
5701         (tui_initialize_static_data): Update.
5702         (~tui_gen_win_info): Handle more cleanup here.
5703         (~tui_source_window_base): Delete "execution_info".
5704         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5705
5706 2019-06-25  Tom Tromey  <tom@tromey.com>
5707
5708         * tui/tui-layout.c (make_command_window): Don't set
5709         can_highlight.
5710         (show_source_disasm_command): Call the reset method.
5711         (show_data): Don't set can_highlight.  Call the reset method.
5712         (tui_gen_win_info::reset): Rename from init_gen_win_info
5713         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5714         (show_source_or_disasm_and_command): Call the reset method.
5715         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5716         (struct tui_cmd_window): Set can_highlight.
5717
5718 2019-06-25  Tom Tromey  <tom@tromey.com>
5719
5720         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5721         from make_visible.
5722         (tui_make_visible, tui_make_invisible): Rewrite.
5723         (tui_win_info::make_visible): Remove.
5724         (tui_source_window_base::make_visible): Update.
5725         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5726         method.  Moved from...
5727         (struct tui_win_info) <make_visible>: ...here.
5728
5729 2019-06-25  Tom Tromey  <tom@tromey.com>
5730
5731         * tui/tui-winsource.c
5732         (tui_source_window_base::do_scroll_horizontal): Remove direction
5733         parameter.
5734         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5735         direction parameter.
5736         * tui/tui-win.c (tui_win_info::forward_scroll)
5737         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5738         (tui_win_info::right_scroll): Update.
5739         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5740         direction parameter.
5741         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5742         direction parameter.
5743         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5744         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5745         Remove direction parameter.
5746         (struct tui_source_window_base, struct tui_source_window)
5747         (struct tui_disasm_window, struct tui_data_window)
5748         (struct tui_cmd_window): Update.
5749
5750 2019-06-25  Tom Tromey  <tom@tromey.com>
5751
5752         * tui/tui-winsource.h (tui_set_exec_info_content)
5753         (tui_show_exec_info_content, tui_erase_exec_info_content)
5754         (tui_clear_exec_info_content, tui_update_exec_info): Change
5755         argument to tui_source_window_base.
5756         * tui/tui-winsource.c (tui_set_exec_info_content)
5757         (tui_show_exec_info_content, tui_erase_exec_info_content)
5758         (tui_clear_exec_info_content, tui_update_exec_info): Change
5759         argument to tui_source_window_base.
5760
5761 2019-06-25  Tom Tromey  <tom@tromey.com>
5762
5763         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5764         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5765
5766 2019-06-25  Tom Tromey  <tom@tromey.com>
5767
5768         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5769         check.
5770
5771 2019-06-25  Tom Tromey  <tom@tromey.com>
5772
5773         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5774         type to void.
5775         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5776         type to void.
5777         * tui/tui-source.c (tui_set_source_content): Update.
5778         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5779
5780 2019-06-25  Tom Tromey  <tom@tromey.com>
5781
5782         * tui/tui-win.c (window_name_completer, tui_set_focus)
5783         (tui_all_windows_info): Use name method.
5784         * tui/tui-data.h (struct tui_gen_win_info)
5785         (struct tui_source_window, struct tui_disasm_window)
5786         (struct tui_data_window, struct tui_cmd_window) <name>: New
5787         method.
5788         (tui_win_name): Don't declare.
5789         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5790         (tui_win_name): Remove.
5791
5792 2019-06-25  Tom Tromey  <tom@tromey.com>
5793
5794         * tui/tui-winsource.h (tui_update_source_window)
5795         (tui_update_source_window_as_is): Change parameter type.
5796         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5797         to be a tui_source_window_base.
5798         (tui_update_source_window_as_is): Likewise.
5799         * tui/tui-win.c (make_visible_with_new_height): Update.
5800
5801 2019-06-25  Tom Tromey  <tom@tromey.com>
5802
5803         * tui/tui-winsource.c (tui_erase_source_content)
5804         (tui_show_source_content, tui_show_exec_info_content)
5805         (tui_erase_exec_info_content): Use refresh_window method.
5806         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5807         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5808         from tui_refresh_win.
5809         (tui_data_window::refresh_window): New method.
5810         (tui_win_info::refresh, tui_source_window_base::refresh)
5811         (tui_refresh_all): Use refresh_window method.
5812         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5813         method.
5814         * tui/tui-regs.c (tui_display_register): Call refresh_window
5815         method.
5816         * tui/tui-layout.c (show_source_disasm_command)
5817         (show_source_or_disasm_and_command): Call refresh_window method.
5818         * tui/tui-data.h (struct tui_gen_win_info)
5819         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5820         New method.
5821
5822 2019-06-25  Tom Tromey  <tom@tromey.com>
5823
5824         * tui/tui.c (tui_rl_other_window, tui_enable)
5825         (tui_is_window_visible, tui_get_command_dimension): Update.
5826         * tui/tui-winsource.c (tui_update_source_window_as_is)
5827         (tui_clear_source_content, tui_erase_source_content)
5828         (tui_show_source_line, tui_source_window_base::refill)
5829         (tui_source_window_base::do_scroll_horizontal)
5830         (tui_source_window_base::set_is_exec_point_at)
5831         (tui_update_breakpoint_info, tui_set_exec_info_content)
5832         (tui_alloc_source_buffer, tui_line_is_displayed)
5833         (tui_addr_is_displayed): Update.
5834         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5835         (tui_check_and_display_highlight_if_needed)
5836         (tui_win_info::make_visible, tui_win_info::refresh)
5837         (tui_refresh_all): Update.
5838         * tui/tui-windata.c (tui_first_data_item_displayed)
5839         (tui_delete_data_content_windows, tui_erase_data_content)
5840         (tui_display_all_data, tui_data_window::refresh_all)
5841         (tui_check_data_values): Update.
5842         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5843         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5844         (tui_win_info::backward_scroll, tui_refresh_all_win)
5845         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5846         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5847         (tui_source_window_base::set_new_height)
5848         (tui_data_window::set_new_height)
5849         (make_invisible_and_set_new_height)
5850         (make_visible_with_new_height, new_height_ok)
5851         (parse_scrolling_args): Update.
5852         * tui/tui-stack.c (tui_show_frame_info): Update.
5853         * tui/tui-source.c (tui_set_source_content)
5854         (tui_set_source_content_nil, tui_source_is_displayed)
5855         (tui_source_window::do_scroll_vertical): Update.
5856         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5857         (tui_display_registers_from, tui_display_reg_element_at_line)
5858         (tui_check_register_values, tui_reg_command): Update.
5859         * tui/tui-layout.c (tui_default_win_height)
5860         (show_source_disasm_command, show_data, init_and_make_win)
5861         (show_source_or_disasm_and_command): Update.
5862         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5863         (tui_redisplay_readline, tui_mld_flush)
5864         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5865         (tui_getc): Update.
5866         * tui/tui-disasm.c (tui_set_disassem_content)
5867         (tui_disasm_window::do_scroll_vertical): Update.
5868         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5869         Now virtual.
5870         (struct tui_win_info): Derive from tui_gen_win_info.
5871         <~tui_win_info>: Mark as override.
5872         <generic>: Remove member.
5873         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5874         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5875         (~tui_data_window, ~tui_win_info)
5876         (tui_free_all_source_wins_content): Update.
5877         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5878
5879 2019-06-25  Tom Tromey  <tom@tromey.com>
5880
5881         * tui/tui-layout.c (init_and_make_win): Use new.
5882         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5883         destructor, initializers.
5884         (tui_alloc_generic_win_info): Don't declare.
5885         * tui/tui-data.c (_locator): Add argument to constructor.
5886         (source_win, disasm_win): New globals.
5887         (exec_info): Remove.
5888         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5889         Update.
5890         (tui_alloc_generic_win_info): Remove.
5891         (init_content_element): Use new.
5892         (tui_win_info::tui_win_info): Update.
5893         (free_content_elements) <case DATA_WIN>: Use delete.
5894
5895 2019-06-25  Tom Tromey  <tom@tromey.com>
5896
5897         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5898         * tui/tui-windata.c (tui_first_data_item_displayed)
5899         (tui_delete_data_content_windows): Update.
5900         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5901         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5902         (tui_display_registers_from, tui_check_register_values): Update.
5903         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5904         pointer.
5905         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5906         window.
5907         (tui_free_data_content): Update.
5908         (free_content_elements) <case DATA_WIN>: Free the window.
5909
5910 2019-06-25  Tom Tromey  <tom@tromey.com>
5911
5912         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5913         Update.
5914         * tui/tui-layout.c (make_command_window)
5915         (show_source_disasm_command, show_data, init_and_make_win)
5916         (show_source_or_disasm_and_command): Update.
5917         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5918         method.
5919         <can_highight, is_highlighted>: Now bool.
5920         (tui_set_win_highlight): Don't declare.
5921         * tui/tui-data.c (tui_set_win_highlight): Remove.
5922
5923 2019-06-25  Tom Tromey  <tom@tromey.com>
5924
5925         * tui/tui-wingeneral.c (make_visible): Remove check of window
5926         type.
5927
5928 2019-06-25  Tom Tromey  <tom@tromey.com>
5929
5930         * tui/tui-win.c (tui_win_info::max_height)
5931         (tui_cmd_window::max_height): New methods.
5932         (new_height_ok): Call max_height.
5933         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5934         <max_height>: New method.
5935
5936 2019-06-25  Tom Tromey  <tom@tromey.com>
5937
5938         * tui/tui-win.c (tui_source_window_base::set_new_height)
5939         (tui_data_window::set_new_height): New methods.
5940         (make_invisible_and_set_new_height): Call set_new_height method.
5941         * tui/tui-data.h (struct tui_win_info)
5942         (struct tui_source_window_base, struct tui_data_window)
5943         <set_new_height>: New method.
5944
5945 2019-06-25  Tom Tromey  <tom@tromey.com>
5946
5947         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5948         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5949         tui_refresh_data_win.
5950         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5951         method.
5952         (tui_refresh_all_win): Call the refresh_all method.
5953         (tui_set_focus): Likewise.
5954         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5955         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5956         Likewise.
5957
5958 2019-06-25  Tom Tromey  <tom@tromey.com>
5959
5960         * tui/tui-winsource.h (tui_refill_source_window)
5961         (tui_set_is_exec_point_at): Don't declare.
5962         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5963         (tui_source_window_base::refill): Rename from
5964         tui_refill_source_window.
5965         (tui_source_window_base::do_scroll_horizontal): Update.
5966         (tui_source_window_base::set_is_exec_point_at): Rename from
5967         tui_set_is_exec_point_at.
5968         (tui_update_all_breakpoint_info): Update.
5969         * tui/tui-stack.c (tui_show_frame_info): Update.
5970         * tui/tui-layout.c (show_data): Add cast.
5971         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5972         * tui/tui-data.h (struct tui_source_window_base) <refill,
5973         set_is_exec_point_at>: New methods.
5974         (tui_source_windows, tui_add_to_source_windows): Update types.
5975         (tui_add_to_source_windows): Remove redundant declaration.
5976         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5977         (tui_source_windows): Change return type.
5978         (tui_clear_source_windows_detail): Update.
5979         (tui_add_to_source_windows): Change type of parameter.
5980         (tui_free_all_source_wins_content): Update.
5981
5982 2019-06-25  Tom Tromey  <tom@tromey.com>
5983
5984         * tui/tui-wingeneral.c (tui_win_info::refresh)
5985         (tui_source_window_base::refresh): New methods.
5986         (tui_refresh_all): Call the refresh method.
5987         * tui/tui-data.h (struct tui_win_info)
5988         (struct tui_source_window_base) <refresh>: New method.
5989
5990 2019-06-25  Tom Tromey  <tom@tromey.com>
5991
5992         * tui/tui.h (tui_is_window_visible): Return bool.
5993         * tui/tui.c (tui_is_window_visible): Return bool.
5994         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5995         (tui_make_visible, tui_make_invisible)
5996         (tui_win_info::make_visible)
5997         (tui_source_window_base::make_visible, make_all_visible)
5998         (tui_make_all_visible, tui_make_all_invisible): Update.
5999         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6000         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6001         bool.
6002         (struct tui_win_info, struct tui_source_window_base)
6003         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6004         * tui/tui-data.c (tui_init_generic_part): Update.
6005
6006 2019-06-25  Tom Tromey  <tom@tromey.com>
6007
6008         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6009         (tui_source_window_base::make_visible): New methods.
6010         (make_all_visible): Make method call.
6011         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6012         (struct tui_source_window_base, struct tui_cmd_window): Override
6013         make_visible.
6014         (tui_win_is_source_type): Don't declare.
6015         * tui/tui-data.c (tui_win_is_source_type): Remove.
6016
6017 2019-06-25  Tom Tromey  <tom@tromey.com>
6018
6019         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6020         NULL check.
6021
6022 2019-06-25  Tom Tromey  <tom@tromey.com>
6023
6024         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6025         Inline constructor.  Add initializers for members.
6026         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6027         constructors; now inline in class.
6028
6029 2019-06-25  Tom Tromey  <tom@tromey.com>
6030
6031         * tui/tui-regs.c (tui_show_registers): Update.
6032         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6033         bool.
6034         * tui/tui-data.c (tui_data_window::clear_detail)
6035         (tui_data_window): Update.
6036
6037 2019-06-25  Tom Tromey  <tom@tromey.com>
6038
6039         * tui/tui-windata.c (tui_display_all_data)
6040         (tui_display_data_from_line, tui_display_data_from)
6041         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6042         Update.
6043         * tui/tui-regs.c (tui_last_regs_line_no)
6044         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6045         (tui_show_registers, tui_show_register_group)
6046         (tui_display_registers_from, tui_display_reg_element_at_line)
6047         (tui_display_registers_from_line, tui_check_register_values)
6048         (tui_reg_next, tui_reg_prev): Update.
6049         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6050         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6051         tui_data_window.
6052         (struct tui_win_info) <detail>: Remove.  Add new fields from
6053         tui_data_info.
6054         (TUI_DATA_WIN): Add cast.
6055         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6056         (~tui_data_window): Simplify.
6057
6058 2019-06-25  Tom Tromey  <tom@tromey.com>
6059
6060         * tui/tui-layout.c (show_source_disasm_command)
6061         (show_source_or_disasm_and_command): Update.
6062         * tui/tui-io.c (update_cmdwin_start_line)
6063         (tui_redisplay_readline): Update.
6064         * tui/tui-data.h (struct tui_command_info): Remove.
6065         (struct tui_win_info) <detail>: Remove command_info member.
6066         (struct tui_data_window) <start_line>: New member, from
6067         tui_command_info.
6068         (TUI_CMD_WIN): Add casts.
6069
6070 2019-06-25  Tom Tromey  <tom@tromey.com>
6071
6072         * tui/tui-winsource.c (tui_update_source_window)
6073         (tui_refill_source_window)
6074         (tui_source_window_base::do_scroll_horizontal)
6075         (tui_update_breakpoint_info, tui_set_exec_info_content)
6076         (tui_show_exec_info_content, tui_erase_exec_info_content)
6077         (tui_clear_exec_info_content): Update.
6078         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6079         Update.
6080         * tui/tui-win.c (make_invisible_and_set_new_height)
6081         (make_visible_with_new_height): Update.
6082         * tui/tui-source.c (tui_set_source_content)
6083         (tui_show_symtab_source): Update.
6084         * tui/tui-layout.c (extract_display_start_addr)
6085         (show_source_disasm_command, show_data)
6086         (make_source_or_disasm_window)
6087         (show_source_or_disasm_and_command): Update.
6088         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6089         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6090         "gdbarch".
6091         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6092         to tui_source_window_base.
6093         (struct tui_win_info) <detail>: Remove source_info member.
6094         (struct tui_source_window_base) <has_locator>: Inline.
6095         Move contents from tui_source_info; rename has_locator member to
6096         m_has_locator.
6097         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6098         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6099         header file.
6100         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6101         Simplify.
6102         (tui_free_all_source_wins_content): Cast to
6103         tui_source_window_base.
6104
6105 2019-06-25  Tom Tromey  <tom@tromey.com>
6106
6107         * tui/tui-win.c (make_invisible_and_set_new_height)
6108         (make_visible_with_new_height): Call has_locator method.
6109         * tui/tui-layout.c (show_source_disasm_command, show_data)
6110         (show_source_or_disasm_and_command): Update for bool change.
6111         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6112         (tui_win_info) <has_locator>: New method.
6113         (struct tui_source_window_base) <has_locator>: New method.
6114         (tui_win_has_locator): Don't declare.
6115         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6116         from tui_win_has_locator.
6117         (tui_source_window_base): Use false, not FALSE.
6118
6119 2019-06-25  Tom Tromey  <tom@tromey.com>
6120
6121         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6122         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6123         clear_detail method directly.
6124         (tui_clear_win_detail): Remove.
6125
6126 2019-06-25  Tom Tromey  <tom@tromey.com>
6127
6128         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6129         "this", not TUI_DISASM_WIN.
6130
6131 2019-06-25  Tom Tromey  <tom@tromey.com>
6132
6133         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6134         declare.
6135         * tui/tui-winsource.c
6136         (tui_source_window_base::do_scroll_horizontal): Rename from
6137         tui_horizontal_source_scroll.
6138         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6139         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6140         from tui_vertical_data_scroll.
6141         * tui/tui-win.h (tui_scroll): Don't declare.
6142         * tui/tui-win.c (tui_win_info::forward_scroll)
6143         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6144         (tui_win_info::right_scroll): Rename and update.
6145         (tui_scroll_forward_command, tui_scroll_backward_command)
6146         (tui_scroll_left_command, tui_scroll_right_command): Update.
6147         (tui_scroll): Remove.
6148         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6149         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6150         from tui_vertical_source_scroll.
6151         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6152         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6153         from tui_vertical_disassem_scroll.
6154         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6155         do_scroll_horizontal>: New methods.
6156         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6157         Likewise.
6158         (struct tui_source_window_base): Add do_scroll_horizontal.
6159         (struct tui_source_window, struct tui_disasm_window): Add
6160         do_scroll_vertical.
6161         (struct tui_data_window, struct tui_cmd_window): Add
6162         do_scroll_horizontal and do_scroll_vertical.
6163         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6164
6165 2019-06-25  Tom Tromey  <tom@tromey.com>
6166
6167         * tui/tui-data.h (struct tui_source_window_base): New struct.
6168         (struct tui_source_window): Derive from tui_source_window_base.
6169         (struct tui_disasm_window): New struct.
6170         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6171         from tui_source_window::clear_detail.
6172         (tui_source_window_base): Rename from tui_source_window.
6173         (~tui_source_window_base): Rename from ~tui_source_window.
6174         (tui_alloc_win_info): Create a tui_disasm_window.
6175
6176 2019-06-25  Tom Tromey  <tom@tromey.com>
6177
6178         * tui/tui-data.h (struct tui_source_window)
6179         (struct tui_data_window): Declare destructors.
6180         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6181         destructors.
6182         (tui_win_info): Simplify.
6183
6184 2019-06-25  Tom Tromey  <tom@tromey.com>
6185
6186         * tui/tui-winsource.c (tui_display_main)
6187         (tui_update_source_windows_with_addr)
6188         (tui_update_all_breakpoint_info): Update.
6189         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6190         (new_height_ok, parse_scrolling_args): Update.
6191         * tui/tui-stack.c (tui_show_frame_info): Update.
6192         * tui/tui-data.h (struct tui_list): Remove.
6193         (tui_source_windows): Return a reference to a std::vector.
6194         * tui/tui-data.c (source_windows): Now a std::vector.
6195         (tui_source_windows): Change return type.
6196         (tui_clear_source_windows): Rewrite.
6197         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6198         (tui_free_all_source_wins_content): Rewrite.
6199
6200 2019-06-25  Tom Tromey  <tom@tromey.com>
6201
6202         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6203         (struct tui_data_window, struct tui_cmd_window): Declare
6204         clear_detail method.
6205         * tui/tui-data.c (tui_source_window::clear_detail)
6206         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6207         methods.
6208         (tui_clear_win_detail): Simplify.
6209
6210 2019-06-25  Tom Tromey  <tom@tromey.com>
6211
6212         * tui/tui-layout.c (make_source_window, make_disasm_window)
6213         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6214         Return the new window.
6215         (show_source_disasm_command, show_data)
6216         (show_source_or_disasm_and_command): Update.
6217
6218 2019-06-25  Tom Tromey  <tom@tromey.com>
6219
6220         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6221         parameter.  Return the new window.
6222         (show_source_disasm_command): Update and remove NULL check.
6223         (show_source_or_disasm_and_command): Update.
6224
6225 2019-06-25  Tom Tromey  <tom@tromey.com>
6226
6227         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6228
6229 2019-06-25  Tom Tromey  <tom@tromey.com>
6230
6231         * tui/tui-data.h (struct tui_win_info): Make constructor
6232         protected.  Make destructor virtual.  Add initializers.
6233         (tui_source_window, tui_data_window, tui_cmd_window): New
6234         classes.
6235         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6236         constructor.  Add "type" parameter.
6237         (tui_source_window, tui_data_window, tui_cmd_window): New
6238         constructors.
6239         (tui_alloc_win_info): Instantiate the appropriate subclass.
6240
6241 2019-06-25  Tom Tromey  <tom@tromey.com>
6242
6243         * tui/tui-win.c (tui_resize_all): Use delete.
6244         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6245         destructor.
6246         (tui_free_window): Don't declare.
6247         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6248         Update.
6249
6250 2019-06-25  Tom Tromey  <tom@tromey.com>
6251
6252         * tui/tui-data.h (struct tui_win_info): Add constructor.
6253         * tui/tui-data.c (tui_alloc_win_info): Use new.
6254         (tui_free_window): Use delete.
6255
6256 2019-06-22  Tom Tromey  <tom@tromey.com>
6257
6258         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6259         declare.
6260         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6261
6262 2019-06-22  Tom Tromey  <tom@tromey.com>
6263
6264         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6265         declare.
6266         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6267
6268 2019-06-22  Tom de Vries  <tdevries@suse.de>
6269
6270         * dwarf2read.c (create_addrmap_from_aranges)
6271         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6272         instead of '%zu'.
6273
6274 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6275
6276         * dwarf2read.h (dwarf2_section_info_def): Remove.
6277         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6278         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6279         std::vector<dwarf2_section_info>.
6280         (struct dwo_file) <~dwo_file>: Remove.
6281         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6282         types field.
6283         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6284         (dwarf2_read_debug_names): Likewise.
6285         (create_debug_types_hash_table): Change parameter type to
6286         array_view, adjust code accordingly.
6287         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6288         (partial_die_info::fixup): Likewise.
6289         (determine_prefix): Likewise.
6290         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6291
6292 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6293
6294         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6295         gdb_bfd_ref_ptr.
6296         <~dwo_file>: Remove call to gdb_bfd_unref.
6297         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6298         gdb_bfd_ref_ptr::get.
6299
6300 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6301
6302         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6303         type to htab_up.
6304         * dwarf2read.c (struct dwo_file): Initialize fields.
6305         <~dwo_file>: New.
6306         (free_dwo_file): Remove, move content to ~dwo_file.
6307         (struct dwo_file_deleter): Remove.
6308         (dwo_file_up>: Remove custom deleter.
6309         (free_dwo_files): Remove.
6310         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6311         dwo_files.
6312         (process_skeletonless_type_units): Call unique_ptr::get.
6313         (allocate_dwo_file_hash_table): Add deleter to created hash
6314         table.  Change return type to htab_up.
6315         (lookup_dwo_file_slot): Don't memset dwo_file, call
6316         unique_ptr::get.
6317         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6318         (create_dwo_unit_in_dwp_v2): Likewise.
6319         (open_and_init_dwo_file): Likewise.
6320         (free_dwo_file_from_slot): Remove.
6321
6322 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6323
6324         * dwarf2read.h (struct dwarf2_section_info) <readin,
6325         is_virtual>: Change type to bool.
6326         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6327         true instead of 1.
6328
6329 2019-06-19  Tom Tromey  <tom@tromey.com>
6330
6331         * tui/tui-data.h (tui_init_content_element): Don't declare.
6332
6333 2019-06-19  Tom Tromey  <tom@tromey.com>
6334
6335         * tui/tui-data.h (tui_init_win_info): Don't declare.
6336
6337 2019-06-19  Tom de Vries  <tdevries@suse.de>
6338
6339         * dwarf2read.h (abstract_to_concrete): Change type to
6340         std::unordered_map<sect_offset, std::vector<sect_offset>,
6341         gdb::hash_enum<sect_offset>>.
6342
6343 2019-06-19  Tom Tromey  <tromey@adacore.com>
6344
6345         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6346         EVAL_AVOID_SIDE_EFFECTS specially.
6347
6348 2019-06-19  Tom Tromey  <tromey@adacore.com>
6349
6350         * source-cache.c (highlighter): New global.
6351         (source_cache::get_source_lines): Create a highlighter on demand.
6352
6353 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6354
6355         * defs.h (deprecated_interactive_hook): Delete declaration.
6356         * interps.c (clear_interpreter_hooks): Remove use of
6357         deprecated_interactive_hook.
6358         * top.c (deprecated_interactive_hook): Delete definition.
6359         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6360
6361 2019-06-18  Tom de Vries  <tdevries@suse.de>
6362
6363         PR gdb/24515
6364         * dwarf2read.h (abstract_to_concrete): Change type from
6365         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6366         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6367         * dwarf2read.c (read_variable): Update.
6368         (dwarf2_fetch_die_loc_sect_off): Update.
6369
6370 2019-06-17  Tom de Vries  <tdevries@suse.de>
6371
6372         PR gdb/24617
6373         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6374         accessing parent[parent_len - 1].
6375
6376 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6377
6378         PR gdb/24364
6379         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6380         call dtrace_process_dof with NULL dof.
6381
6382 2019-06-16  Tom de Vries  <tdevries@suse.de>
6383
6384         PR gdb/24445
6385         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6386
6387 2019-06-16  Tom Tromey  <tom@tromey.com>
6388
6389         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6390         (make_all_visible): Use address of member.
6391
6392 2019-06-16  Tom Tromey  <tom@tromey.com>
6393
6394         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6395         (tui_free_window, free_content, free_content_elements): Remove
6396         unnecessary cast.
6397         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6398         cast.
6399         * tui/tui-regs.c (tui_show_register_group)
6400         (tui_display_registers_from, tui_display_reg_element_at_line):
6401         Remove unnecessary cast.
6402
6403 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6404
6405         * linux-nat.c (normal_mask): Delete.
6406         (_initialize_linux_nat): Don't initialise normal_mask.
6407
6408 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6409
6410         PR gdb/24445
6411         * dwarf-index-write.h (write_psymtabs_to_index): Add
6412         dwz_basename parameter.
6413         * dwarf-index-write.c (write_gdbindex): Move file writing to
6414         write_gdbindex_1.  Change return type void.
6415         (assert_file_size): Move up, remove filename parameter.
6416         (write_gdbindex_1): New function.
6417         (write_debug_names): Change return type to void, call
6418         assert_file_size.
6419         (struct index_wip_file): New struct.
6420         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6421         file logic to index_wip_file.  Write index for dwz file if
6422         needed.
6423         (save_gdb_index_command): Pass basename of dwz file, if present.
6424         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6425         build-id of dwz file, if present.
6426         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6427         (dwarf2_get_dwz_file): Likewise.
6428         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6429         (dwarf2_get_dwz_file): Likewise.
6430
6431 2019-06-16  Tom Tromey  <tom@tromey.com>
6432
6433         * coffread.c (process_coff_symbol): Use xstrdup.
6434         * value.c (create_internalvar): Use xstrdup.
6435
6436 2019-06-16  Tom Tromey  <tom@tromey.com>
6437
6438         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6439         * breakpoint.c (stopin_command, stopat_command)
6440         (until_break_command, decode_location_default): Remove unnecessary
6441         cast.
6442         * utils.c (subset_compare): Remove unnecessary cast.
6443         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6444         cast.
6445         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6446         cast.
6447         * infcmd.c (path_command): Remove unnecessary cast.
6448         * coffread.c (decode_type): Remove unnecessary cast.
6449         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6450         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6451         * tui/tui-stack.c (tui_show_locator_content)
6452         (tui_show_frame_info): Remove unnecessary cast.
6453         * tui/tui-win.c (tui_scroll_forward_command)
6454         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6455         (parse_scrolling_args): Remove unnecessary cast.
6456         * tui/tui-data.c (init_win_info, tui_del_window)
6457         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6458         (free_content_elements): Remove unnecessary cast.
6459         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6460         unnecessary cast.
6461         * tui/tui-source.c (tui_set_source_content)
6462         (tui_vertical_source_scroll): Remove unnecessary cast.
6463         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6464         cast.
6465         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6466         * tui/tui-regs.c (tui_display_registers_from)
6467         (tui_display_register): Remove unnecessary cast.
6468         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6469         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6470         (make_visible): Remove unnecessary cast.
6471         * tui/tui-winsource.c (tui_erase_source_content)
6472         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6473         unnecessary cast.
6474         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6475         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6476         * stabsread.c (read_type, read_array_type, read_range_type):
6477         Remove unnecessary cast.
6478         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6479         (parse_symbol, parse_type, upgrade_type, parse_external)
6480         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6481         unnecessary cast.
6482         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6483
6484 2019-06-16  Tom Tromey  <tom@tromey.com>
6485
6486         * tui/tui-data.c (tui_alloc_generic_win_info)
6487         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6488         checks.
6489
6490 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6491             Andrew Burgess  <andrew.burgess@embecosm.com>
6492
6493         * f-typeprint.c (f_print_type): Don't return early for not
6494         associated or not allocated types.
6495         (f_type_print_varspec_suffix): Add print_rank parameter and print
6496         ranks of array types in case they dangling.
6497         (f_type_print_base): Add print_rank parameter.
6498
6499 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6500
6501         * NEWS: Mention new MI commands.
6502         * break-catch-throw.c (enum exception_event_kind): Move to
6503         breakpoint.h.
6504         (print_mention_exception_catchpoint): Output text as a single
6505         message.
6506         (catch_exception_command_1): Rename to...
6507         (catch_exception_event): ...this, make non-static, update header
6508         command, and change some parameter types.
6509         (catch_catch_command): Update for changes to
6510         catch_exception_command_1.
6511         (catch_throw_command): Likewise.
6512         (catch_rethrow_command): Likewise.
6513         * breakpoint.c (enum exception_event_kind): Delete.
6514         * breakpoint.h (enum exception_event_kind): Moved here from
6515         break-catch-throw.c.
6516         (catch_exception_event): Declare.
6517         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6518         (mi_cmd_catch_throw): New function.
6519         (mi_cmd_catch_rethrow): New function.
6520         (mi_cmd_catch_catch): New function.
6521         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6522         'catch-catch' entries.
6523         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6524         (mi_cmd_catch_rethrow): Declare.
6525         (mi_cmd_catch_catch): Declare.
6526
6527 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6528
6529         * annotate.c (annotate_source_line): Change return type to void,
6530         update implementation to match.
6531         * annotate.h (annotate_source_line): Change return type to void,
6532         update header comment.
6533         * stack.c (print_frame_info): Don't change what frame information
6534         is printed based on whether annotations are on or not.
6535
6536 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6537
6538         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6539         (annotate_source): Make static.
6540         (annotate_source_line): Moved from source.c and renamed from
6541         identify_source_line.  Update the return type.
6542         * annotate.h (annotate_source): Delete declaration.
6543         (annotate_source_line): Declaration moved from source.h, and
6544         renamed from identify_source_line.  Return type updated.
6545         * source.c (identify_source_line): Moved to annotate.c and renamed
6546         to annotate_source_line.
6547         (info_line_command): Remove check of annotation_level.
6548         * source.h (identify_source_line): Move declaration to annotate.h
6549         and rename to annotate_source_line.
6550         * stack.c: Add 'annotate.h' include.
6551         (print_frame_info): Remove check of annotation_level before
6552         calling annotate_source_line.
6553
6554 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6555
6556         * source-cache.c (source_cache::get_plain_source_lines): Use
6557         open_source_file_with_line_charpos instead of just
6558         open_source_file, remove call to find_source_lines.
6559         (source_cache::get_source_lines): Likewise.
6560         * source.c (find_source_lines): Make static.
6561         (get_filename_and_charpos): Renamed into...
6562         (open_source_file_with_line_charpos): ..this along with changes to
6563         return a scoped_fd, and some other minor clean ups.
6564         (identify_source_line): Use open_source_file_with_line_charpos.
6565         (search_command_helper): Use open_source_file_with_line_charpos
6566         instead of just open_source_file, remove call to
6567         find_source_lines.
6568         * source.h (open_source_file_with_line_charpos): Declare new
6569         function.
6570         (find_source_lines): Delete declaration.
6571
6572 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6573
6574         * source.c (get_filename_and_charpos): Remove fullname
6575         parameter.
6576         (identify_source_line): Update call to get_filename_and_charpos.
6577
6578 2019-06-14  Tom Tromey  <tromey@adacore.com>
6579
6580         PR gdb/24502:
6581         * ui-style.h (skip_ansi_escape): Update comment.
6582         * ui-file.h (class no_terminal_escape_file): New class.
6583         * ui-file.c (no_terminal_escape_file::write)
6584         (no_terminal_escape_file::puts): New methods.
6585         * cli/cli-logging.c (handle_redirections): Use
6586         no_terminal_escape_file.
6587
6588 2019-06-14  Tom Tromey  <tromey@adacore.com>
6589
6590         * NEWS: Move convenience variable news above Python news.
6591
6592 2019-06-14  Tom Tromey  <tom@tromey.com>
6593
6594         * gnulib: Move directory to top-level.
6595         * configure.ac: Don't configure gnulib.
6596         * configure: Rebuild.
6597         * common/common-defs.h: Use new path to gnulib.
6598         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6599         (GNULIB_H): Remove.
6600         (INCGNU): Look in new gnulib location.
6601         (HFILES_NO_SRCDIR): Remove gnulib files.
6602         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6603         (generated_files): Remove GNULIB_H.
6604         ($(LIBGNU), all-lib): Remove targets.
6605         (distclean): Don't mention GNULIB_BUILDDIR.
6606         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6607
6608 2019-06-14  Tom Tromey  <tromey@adacore.com>
6609
6610         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6611         Warn if symbol file does not provide any symbols.
6612
6613 2019-06-14  Tom Tromey  <tromey@adacore.com>
6614
6615         * source.c (find_and_open_source): Respect basenames_may_differ.
6616
6617 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6618
6619         * annotate.c (annotate_breakpoints_invalid): Make use of
6620         scoped_restore_terminal_state.
6621         (annotate_frames_invalid): Likewise.
6622
6623 2019-06-14  Tom Tromey  <tromey@adacore.com>
6624
6625         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6626         allow assignment to an internalvar.
6627
6628 2019-06-14  Tom Tromey  <tromey@adacore.com>
6629
6630         * ada-lex.l: Allow "_" in attribute names.
6631
6632 2019-06-14  Tom Tromey  <tromey@adacore.com>
6633
6634         PR gdb/24653:
6635         * regcache.c (registers_changed): Don't call alloca.
6636         * top.c (execute_command): Don't call alloca.
6637
6638 2019-06-13  Pedro Alves  <palves@redhat.com>
6639
6640         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6641         'expression'.  When parsing an expression, error out if there's
6642         junk after "unlimited".
6643         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6644         (do_set_command): Adjust calls to is_unlimited_literal.
6645
6646 2019-06-13  Pedro Alves  <palves@redhat.com>
6647
6648         * compile/compile.c (make_compile_options_def_group): Add braces
6649         around array_view initializer.
6650         * thread.c (make_thread_apply_all_options_def_group)
6651         (make_thread_apply_all_options_def_group): Likewise.
6652
6653 2019-06-13  Pedro Alves  <palves@redhat.com>
6654
6655         * NEWS (New commands): Mention "maint test-options
6656         require-delimiter", "maint test-options unknown-is-error", "maint
6657         test-options unknown-is-operand" and "maint show
6658         test-options-completion-result".
6659         (New command options, command completion): New section.
6660         (Completion improvements): New section.
6661         Mention that you can abbreviate "unlimited".
6662
6663 2019-06-13  Pedro Alves  <palves@redhat.com>
6664
6665         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6666         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6667         * unittests/cli-utils-selftests.c (test_parse_flags)
6668         (test_parse_flags_qcs): Delete.
6669         (test_cli_utils): Don't call deleted functions.
6670
6671 2019-06-13  Pedro Alves  <palves@redhat.com>
6672
6673         * thread.c: Include "cli/cli-option.h".
6674         (tp_array_compar_ascending): Global.
6675         (tp_array_compar): Delete function.
6676         (tp_array_compar_ascending, tp_array_compar_descending): New
6677         functions.
6678         (ascending_option_def, qcs_flag_option_def)
6679         (thr_qcs_flags_option_defs)
6680         (make_thread_apply_all_options_def_group)
6681         (make_thread_apply_options_def_group): New.
6682         (thread_apply_all_command): Use gdb::option::process_options.
6683         (thread_apply_command_completer)
6684         (thread_apply_all_command_completer): New.
6685         (thread_apply_command): Use gdb::option::process_options.
6686         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6687         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6688         to generate help text of "thread apply".  Adjust "taas"'s help.
6689         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6690         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6691
6692 2019-06-13  Pedro Alves  <palves@redhat.com>
6693
6694         * thread.c (thread_apply_command): Check for invalid TID with
6695         isdigit instead of !isalpha.
6696
6697 2019-06-13  Pedro Alves  <palves@redhat.com>
6698
6699         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6700         (validate_flags_qcs): New.
6701         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6702         (validate_flags_qcs): Declare.
6703         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6704         (make_frame_apply_options_def_group): New.
6705         (frame_apply_command_count): Process options with
6706         gdb::option::process_options.
6707         (frame_apply_completer): New.
6708         (frame_apply_level_completer, frame_apply_all_completer)
6709         (frame_apply_completer): New.
6710         (_initialize_stack): Update help of "frame apply", "frame apply
6711         level", "frame apply all" and "faas" to mention supported options
6712         and install command completers.
6713         * stack.h (frame_apply_all_completer): Declare.
6714         * thread.c: Include "stack.h".
6715         (tfaas_command): Add "--".
6716         (_initialize_thread): Update help "tfaas" to mention supported
6717         options and install command completer.
6718
6719 2019-06-13  Pedro Alves  <palves@redhat.com>
6720
6721         * completer.c (complete_nested_command_line): New.
6722         (gdb_completion_word_break_characters_throw): Add assertion.
6723         * completer.h (complete_nested_command_line): Declare.
6724
6725 2019-06-13  Pedro Alves  <palves@redhat.com>
6726
6727         * stack.c (parse_backtrace_qualifiers): New.
6728         (backtrace_command): Use it.
6729         (backtrace_command_completer): Complete on qualifiers.
6730
6731 2019-06-13  Pedro Alves  <palves@redhat.com>
6732
6733         * frame.c: Include "cli/cli-option.h.
6734         (user_set_backtrace_options): New.
6735         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6736         Delete.
6737         (get_prev_frame): Adjust.
6738         (boolean_option_def, uinteger_option_def)
6739         (set_backtrace_option_defs): New.
6740         (_initialize_frame): Adjust and use
6741         gdb::option::add_setshow_cmds_for_options to install "set
6742         backtrace past-main" and "set backtrace past-entry".
6743         * frame.h: Include "cli/cli-option.h".
6744         (struct frame_print_options): Forward declare.
6745         (print_frame_arguments_all, print_frame_arguments_scalars)
6746         (print_frame_arguments_none): Declare.
6747         (print_entry_values): Delete declaration.
6748         (struct frame_print_options, user_frame_print_options): New.
6749         (struct set_backtrace_options): New.
6750         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6751         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6752         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6753         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6754         (list_args_or_locals): Add frame_print_options parameter.
6755         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6756         * python/py-framefilter.c (enumerate_args): Pass down
6757         USER_FRAME_PRINT_OPTIONS.
6758         * stack.c: Include "cli/cli-option.h".
6759         (print_frame_arguments_all, print_frame_arguments_scalars)
6760         (print_frame_arguments_none): Declare.
6761         (print_raw_frame_arguments, print_entry_values): Delete.
6762         (user_frame_print_options): New.
6763         (boolean_option_def, enum_option_def, frame_print_option_defs):
6764         New.
6765         (struct backtrace_cmd_options): New.
6766         (bt_flag_option_def): New.
6767         (backtrace_command_option_defs): New.
6768         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6769         (print_frame_arg, read_frame_arg, print_frame_args)
6770         (print_frame_info, print_frame): Add frame_print_options parameter
6771         and use it.
6772         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6773         (backtrace_command_1): Add frame_print_options and
6774         backtrace_cmd_options parameters and use them.
6775         (make_backtrace_options_def_group): New.
6776         (backtrace_command): Process command options with
6777         gdb::option::process_options.
6778         (backtrace_command_completer): New.
6779         (_initialize_stack): Extend "backtrace"'s help to mention
6780         supported options.  Install completer for "backtrace".
6781         Install some settings commands with add_setshow_cmds_for_options.
6782
6783 2019-06-13  Pedro Alves  <palves@redhat.com>
6784
6785         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6786         and that "set/show print raw frame-arguments" are now deprecated.
6787
6788         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6789         command.
6790         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6791         * stack.c (_initialize_stack): Install "set/show print
6792         raw-frame-arguments", and deprecate "set/show print raw
6793         frame-arguments".
6794         * valprint.c (_initialize_valprint): Deprecate "set/show print
6795         raw".
6796
6797 2019-06-13  Pedro Alves  <palves@redhat.com>
6798
6799         * compile/compile.c (struct compile_options): New.
6800         (compile_flag_option_def, compile_command_option_defs)
6801         (make_compile_options_def_group): New.
6802         (compile_file_command): Handle options with
6803         gdb::option::process_options.
6804         (compile_file_command_completer): New function.
6805         (compile_code_command): Handle options with
6806         gdb::option::process_options.
6807         (compile_code_command_completer): New function.
6808         (_initialize_compiler): Install completers for "compile code" and
6809         "compile file".  Mention available options in "compile code" and
6810         "compile code"'s help.
6811         * completer.c (advance_to_completion_word): New, factored out from
6812         ...
6813         (advance_to_expression_complete_word_point): ... this.
6814         (advance_to_filename_complete_word_point): New.
6815         * completer.h (advance_to_filename_complete_word_point): New
6816         declaration.
6817
6818 2019-06-13  Pedro Alves  <palves@redhat.com>
6819
6820         * compile/compile.c: Include "cli/cli-option.h".
6821         (compile_print_value): Scope data pointer is now a
6822         value_print_options pointer; adjust.
6823         (compile_print_command): Process options.  Scope data pointer is
6824         now a value_print_options pointer; adjust.
6825         (_initialize_compile): Update "compile print"'s help to include
6826         supported options.  Install a completer for "compile print".
6827         * cp-valprint.c (show_vtblprint, show_objectprint)
6828         (show_static_field_print): Delete.
6829         (_initialize_cp_valprint): Don't install "set print
6830         static-members", "set print vtbl", "set print object" here.
6831         * printcmd.c: Include "cli/cli-option.h" and
6832         "common/gdb_optional.h".
6833         (print_command_parse_format): Rework to fill in a
6834         value_print_options instead of a format_data.
6835         (print_value): Change parameter type from format_data pointer to
6836         value_print_options reference.  Adjust.
6837         (print_command_1): Process options.  Adjust to pass down a
6838         value_print_options.
6839         (print_command_completer): New.
6840         (_initialize_printcmd): Install print_command_completer as
6841         handle_brkchars completer for the "print" command.  Update
6842         "print"'s help to include supported options.
6843         * valprint.c: Include "cli/cli-option.h".
6844         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6845         here from cp-valprint.c.
6846         (boolean_option_def, uinteger_option_def)
6847         (value_print_option_defs, make_value_print_options_def_group):
6848         New.  Use gdb::option::add_setshow_cmds_for_options to install
6849         "set print elements", "set print null-stop", "set print repeats",
6850         "set print pretty", "set print union", "set print array", "set
6851         print address", "set print symbol", "set print array-indexes".
6852         * valprint.h: Include <string> and "cli/cli-option.h".
6853         (make_value_print_options_def_group): Declare.
6854         (print_value): Change parameter type from format_data pointer to
6855         value_print_options reference.
6856         (print_command_completer): Declare.
6857
6858 2019-06-13  Pedro Alves  <palves@redhat.com>
6859
6860         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6861         (COMMON_SFILES): Add maint-test-settings.c.
6862         * cli/cli-decode.c (boolean_enums): New global, factored out from
6863         ...
6864         (add_setshow_boolean_cmd): ... here.
6865         * cli/cli-decode.h (boolean_enums): Declare.
6866         * cli/cli-option.c: New file.
6867         * cli/cli-option.h: New file.
6868         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6869         factored out from ...
6870         (parse_cli_boolean_value(const char *)): ... this.
6871         (is_unlimited_literal): Change parameter type to pointer to
6872         pointer.  Adjust and advance ARG pointer.
6873         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6874         (parse_cli_var_enum): New, factored out from ...
6875         (do_set_command): ... this.  Adjust.
6876         * cli/cli-setshow.h (parse_cli_boolean_value)
6877         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6878         (parse_cli_var_enum): Declare.
6879         * cli/cli-utils.c: Include "cli/cli-option.h".
6880         (get_ulongest): New.
6881         * cli/cli-utils.h (get_ulongest): Declare.
6882         (check_for_argument): New overloads.
6883         * maint-test-options.c: New file.
6884
6885 2019-06-13  Pedro Alves  <palves@redhat.com>
6886
6887         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6888         parse a range if "-" is at the end of the string.
6889
6890 2019-06-13  Pedro Alves  <palves@redhat.com>
6891
6892         * cli/cli-setshow.c (parse_auto_binary_operation)
6893         (parse_cli_boolean_value): Don't allow "o".
6894
6895 2019-06-13  Pedro Alves  <palves@redhat.com>
6896
6897         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6898         * NEWS: Mention maint test-settings KIND.
6899         * maint-test-settings.c: New file.
6900
6901 2019-06-13  Pedro Alves  <palves@redhat.com>
6902
6903         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6904         completer.
6905         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6906         "set" completers.
6907
6908 2019-06-13  Pedro Alves  <palves@redhat.com>
6909
6910         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6911         after item.
6912
6913 2019-06-13  Pedro Alves  <palves@redhat.com>
6914
6915         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6916
6917 2019-06-13  Pedro Alves <palves@redhat.com>
6918
6919         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6920         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6921         call.
6922         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6923         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6924         calls.
6925         (check_for_argument): Skip spaces after argument.
6926
6927 2019-06-13  Pedro Alves  <palves@redhat.com>
6928
6929         * thread.c (thread_apply_command): Adjust TID parsing.
6930         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6931         detected before end of string.
6932         (tid_is_in_list): Error out if LIST is invalid.
6933
6934 2019-06-13  Pedro Alves  <palves@redhat.com>
6935
6936         * completer.c (complete_line_internal_1): Rewind completion word
6937         point.
6938         (completion_tracker::advance_custom_word_point_by): Change
6939         parameter type to int.
6940         * completer.h (completion_tracker::advance_custom_word_point_by):
6941         Likewise.
6942
6943 2019-06-13  Pedro Alves  <palves@redhat.com>
6944
6945         * completer.c (advance_to_completion_word): Handle delimiters.
6946
6947 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6948
6949         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6950
6951 2019-06-11  Tom Tromey  <tom@tromey.com>
6952
6953         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6954         (xmalloc_failed): Move to alloc.c.
6955         * alloc.c: New file.
6956         * Makefile.in (COMMON_SFILES): Add alloc.c.
6957
6958 2019-06-11  Tom Tromey  <tom@tromey.com>
6959
6960         * nat/linux-waitpid.c: Don't include server.h.
6961         (linux_debug): Remove.
6962         (my_waitpid): Update.
6963
6964 2019-06-11  Tom Tromey  <tromey@adacore.com>
6965
6966         * infcall.c (_initialize_infcall): Remove trailing newline from
6967         help.
6968         * user-regs.c (_initialize_user_regs): Remove trailing newline
6969         from help.
6970         * typeprint.c (_initialize_typeprint): Remove trailing newline
6971         from help.
6972         * reverse.c (_initialize_reverse): Remove trailing newlines from
6973         help.
6974         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6975         from help.
6976         * language.c (add_set_language_command): Remove trailing newline
6977         from help.
6978         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6979         help.
6980         * disasm.c (_initialize_disasm): Remove trailing newline from
6981         help.
6982         * top.c (init_main): Remove trailing newline from help.
6983         * interps.c (_initialize_interpreter): Remove trailing newline
6984         from help.
6985         * btrace.c (_initialize_btrace): Remove trailing newlines from
6986         help.
6987         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6988         from help.
6989         * python/python.c (_initialize_python): Remove trailing newline
6990         from help.
6991         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6992         help.
6993         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6994         from help.  Reformat some text.
6995         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6996         from help.
6997         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6998         newline from help.
6999
7000 2019-06-11  Tom Tromey  <tromey@adacore.com>
7001
7002         * darwin-nat.c (darwin_decode_exception_message)
7003         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7004
7005 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7006
7007         * valops.c (value_slice): Check for not allocated or not
7008         associated values.
7009
7010 2019-06-10  Tom de Vries  <tdevries@suse.de>
7011
7012         PR gdb/24618
7013         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7014         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7015         invalid.
7016
7017 2019-06-10  Tom de Vries  <tdevries@suse.de>
7018
7019         PR gdb/24611
7020         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7021         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7022
7023 2019-06-10  Tom de Vries  <tdevries@suse.de>
7024
7025         PR symtab/24545
7026         * symtab.c (struct demangled_name_entry): Add language field.
7027         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7028         static minimal symbol".  Set and use language field.
7029
7030 2019-06-10  Tom Tromey  <tromey@adacore.com>
7031
7032         * ada-lang.c (_initialize_ada_language): Update help text.
7033
7034 2019-06-10  Tom Tromey  <tromey@adacore.com>
7035
7036         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7037         with a newline.
7038         * guile/guile.c (handle_boot_error): Don't end warning with a
7039         newline.
7040         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7041         warning with a newline.
7042         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7043         newline.
7044         (s12z_frame_cache): Likewise.
7045         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7046         a newline.
7047         * solib-svr4.c (disable_probes_interface): Don't end warning with
7048         a newline.
7049         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7050         newline.
7051         * python/python.c (do_finish_initialization): Don't end warning
7052         with a newline.
7053
7054 2019-06-10  Tom Tromey  <tom@tromey.com>
7055
7056         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7057         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7058         gdbpy_enter.
7059
7060 2019-06-10  Tom Tromey  <tromey@adacore.com>
7061
7062         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7063         data.
7064         (elf_new_init): Don't call stabsread_new_init.
7065         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7066         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7067         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7068
7069 2019-06-10  Tom de Vries  <tdevries@suse.de>
7070
7071         PR symtab/16264
7072         PR symtab/24517
7073         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7074
7075 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7076
7077         * source.c (find_and_open_source): Also rewrite relative file
7078         names.
7079
7080 2019-04-26  Amos Bird  <amosbird@gmail.com>
7081
7082         * annotate.c (annotate_thread_exited): Add "thread-exited"
7083         annotation.
7084
7085 2019-06-06  Tom Tromey  <tromey@adacore.com>
7086
7087         * maint.h (class scoped_command_stats): Use
7088         DISABLE_COPY_AND_ASSIGN.
7089         <print_time>: New method.
7090         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7091         print_time.
7092         (scoped_command_stats::print_time): New method.
7093
7094 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7095
7096         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7097         instructions of lengths 6 or 8 bytes.
7098
7099 2019-06-04  Pedro Alves  <palves@redhat.com>
7100
7101         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7102
7103         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7104         * breakpoint.c (condition_completer): Likewise.
7105         * cli/cli-dump.c (scan_expression): Likewise.
7106         * common/filestuff.c (mkdir_recursive): Likewise.
7107         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7108         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7109         (gdb_abspath): Likewise.
7110         * compile/compile-cplus-types.c
7111         (compile_cplus_instance::decl_name): Likewise.
7112         * completer.c (complete_explicit_location):
7113         (signal_completer, reg_or_group_completer_1): Likewise.
7114         * cp-support.c (cp_remove_params_if_any): Likewise.
7115         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7116         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7117         * infcmd.c (strip_bg_char): Likewise.
7118         * linespec.c (copy_token_string): Likewise.
7119         * mi/mi-main.c (output_cores): Likewise.
7120         * psymtab.c (psymtab_search_name):
7121         * symfile.c (test_set_ext_lang_command): Likewise.
7122         * target.c (target_fileio_read_stralloc): Likewise.
7123         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7124         * value.c (complete_internalvar): Likewise.
7125
7126 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7127
7128         Add objfile property to gdb.Type.
7129         * NEWS: Mention Python API addition.
7130         * python/py-type.c (typy_get_objfile): New method.
7131
7132 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7133
7134         * NEWS: Mention the new set|show style [title|highlight].
7135         Mention changes to "show style", "help" and "apropos".
7136
7137 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7138
7139         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7140         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7141         instead of print_help_for_command.
7142         (print_doc_of_command): New function.
7143         (help_list): Add 'apropos -v word' suggestion.
7144         (print_help_for_command): Style the command name using title style.
7145         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7146         (_initialize_cli_cmds): Describe -v in apropos_command help.
7147
7148 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7149
7150         * cli/cli-style.h (cli_style_option): Add name in constructor,
7151         add m_name class member, add constructor with intensity,
7152         add name class function.
7153         (cli_style_option::add_setshow_commands): Remove name argument.
7154         (highlight_style, title_style): New styles.
7155         * cli/cli-style.c (do_show): New function that shows a style
7156         characteristic styling the style name with itself.
7157         (set_style_name): New function.
7158         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7159         Update all callers according to the changes in cli/cli-style.h.
7160         * utils.h (fputs_highlighted): New function.
7161         * utils.c (fputs_highlighted): Likewise.
7162
7163 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7164
7165         * NEWS: Mention new pipe command and new convenience variables.
7166
7167 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7168
7169         * cli/cli-cmds.c (pipe_command): New function.
7170         (_initialize_cli_cmds): Call add_com for pipe_command.
7171         Define | as an alias for pipe.
7172         (exit_status_set_internal_vars): New function.
7173         (shell_escape): Call exit_status_set_internal_vars.
7174         cli/cli-decode.c (find_command_name_length): Recognize | as
7175         a single character command.
7176
7177 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7178
7179         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7180         top.c (execute_command_to_ui_file): New function, mostly a copy
7181         of execute_command_to_string.
7182         (execute_command_to_string): Implement by calling
7183         execute_command_to_ui_file.
7184
7185 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7186
7187         * top.h (saved_command_line): Remove declaration.
7188         * top.c (previous_saved_command_line, previous_repeat_arguments):
7189         New variables.
7190         (saved_command_line): Make static, define together with other
7191         'repeat variables'.
7192         (dont_repeat): Clear repeat_arguments.
7193         (repeat_previous, get_saved_command_line, save_command_line):
7194         New functions.
7195         (gdb_init): Initialize saved_command_line
7196         and previous_saved_command_line.
7197         * main.c (captured_main_1): Remove saved_command_line initialization.
7198         * event-top.c (handle_line_of_input): Update to use
7199         the new 'repeat' related functions instead of direct access to
7200         saved_command_line.
7201         * command.h (repeat_previous, get_saved_command_line,
7202         save_command_line): New declarations.
7203         (dont_repeat): Add comment.
7204
7205 2019-05-30  Tom Tromey  <tromey@adacore.com>
7206
7207         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7208         Fix comment.
7209         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7210
7211 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7212
7213         PR cli/24587
7214         * completer.c (complete): Initialize variable word.
7215
7216 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7217
7218         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7219         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7220         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7221         'body' is NULL to the outter 'if', protecting the '!is_define'
7222         situation as well.
7223
7224 2019-05-29  Tom Tromey  <tromey@adacore.com>
7225
7226         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7227         (dwarf_unknown): New function.
7228         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7229         (dwarf_type_encoding_name): Use dwarf_unknown.
7230
7231 2019-05-29  Tom Tromey  <tromey@adacore.com>
7232
7233         PR c++/20020:
7234         * cp-valprint.c (cp_print_value_fields): Call
7235         cp_print_static_field inside "try".
7236
7237 2019-05-29  Tom Tromey  <tromey@adacore.com>
7238
7239         * inflow.c (struct terminal_info): Add default operator=.
7240         * configure: Rebuild.
7241         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7242         -Wdeprecated-copy-dtor, -Wredundant-move.
7243
7244 2019-05-29  Tom Tromey  <tromey@adacore.com>
7245
7246         * NEWS: Add entry.
7247         * infcmd.c (print_return_value_1): Handle finish_print
7248         option.
7249         (show_print_finish): New function.
7250         (_initialize_infcmd): Add "set/show print finish" commands.
7251         * valprint.c (user_print_options): Initialize new member.
7252         * valprint.h (struct value_print_options) <finish_print>: New
7253         member.
7254
7255 2019-05-28  Tom Tromey  <tromey@adacore.com>
7256
7257         * ada-lang.c (ada_remove_Xbn_suffix)
7258         (find_old_style_renaming_symbol)
7259         (parse_old_style_renaming): Remove.
7260         (ada_find_renaming_symbol): Don't call
7261         find_old_style_renaming_symbol.
7262         (ada_is_renaming_symbol): Rename from
7263         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7264         bool.  Now static.
7265         (ada_read_var_value): Update and simplify.
7266         * ada-exp.y (write_var_or_type): Remove old code.
7267
7268 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7269
7270         PR gdb/25010
7271         * event-top.c: Remove include comment.
7272         * inflow.c (class scoped_ignore_sigttou): Move from here...
7273         * inflow.h (class scoped_ignore_sigttou): ...to here.
7274         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7275         * top.c:  Remove include comment.
7276
7277 2019-05-27  Tom Tromey  <tom@tromey.com>
7278
7279         * NEWS: Fix typo.
7280
7281 2019-05-22  Tom Tromey  <tromey@adacore.com>
7282
7283         * target.c (target_follow_exec): Constify parameter.
7284         * target-delegates.c: Rebuild.
7285         * remote.c (remote_target::follow_exec): Constify parameter.
7286         * infrun.c (follow_exec): Constify parameter.
7287         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7288         (target_follow_exec): Likewise.
7289
7290 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7291
7292         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7293         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7294
7295 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7296
7297         * NEWS: Add debugredirect and testsuite sections.
7298
7299 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7300
7301         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7302         target descriptions using exclusively floating point register name
7303         aliases.
7304
7305 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         PR gdb/18644:
7308         * f-lang.c (build_fortran_types): Handle the case where
7309         gdbarch_floatformat_for_type returns a nullptr.
7310
7311 2019-05-21  Tom de Vries  <tdevries@suse.de>
7312
7313         PR cli/24587
7314         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7315
7316 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7317
7318         PR gdb/18644:
7319         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7320         16-byte floats.
7321         * i386-tdep.c (i386_floatformat_for_type): Use
7322         floatformats_ia64_quad for the 16-byte floating point component
7323         within a fortran 32-byte complex number.
7324
7325 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7326
7327         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7328         delete default constructor.
7329         (find_partial_die): Update to return const struct.
7330         (partial_die_parent_scope): Move variable declaration into scope
7331         of its use and change its type to auto.
7332         (guess_partial_die_structure_name): Likewise.
7333         (partial_die_info::fixup): Likewise.
7334
7335 2019-05-17  Tom Tromey  <tromey@adacore.com>
7336
7337         * source.c (find_and_open_source): Remove cast.
7338
7339 2019-05-17  Tom Tromey  <tromey@adacore.com>
7340
7341         * annotate.c (annotate_source): Make "filename" const.
7342         * annotate.h (annotate_source): Use const.
7343
7344 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7345
7346         * disasm.c (set_disassembler_options): Send errors to stderr.
7347
7348 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7349
7350         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7351         (cli_interp_base::set_logging): Check debug_redirect.
7352         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7353         * cli/cli-logging.c (debug_redirect): Add static variable.
7354         (pop_output_files): Add default param.
7355         (handle_redirections): Print debug setting.
7356         (show_logging_command): Likewise.
7357         (_initialize_cli_logging): Add debugredirect command.
7358         * interps.c (current_interp_set_logging): Add debug_redirect
7359         parameter.
7360         * interps.h (set_logging): Add debug_redirect parameter.
7361         (current_interp_set_logging): Likewise.
7362         * mi/mi-common.h: Likewise.
7363         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7364
7365 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7366             Tom Tromey  <tromey@adacore.com>
7367
7368         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7369         directly.
7370         * cli/cli-interp.h (make_logging_output): Remove declaration.
7371         * cli/cli-logging.c (make_logging_output): Remove function.
7372         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7373         directly.
7374         * ui-file.c (tee_file::tee_file): Remove bools.
7375         (tee_file::~tee_file): Remove deletes.
7376         * ui-file.h (tee_file): Remove bools.
7377
7378 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7379
7380         * mi/mi-cmds.h (mi_cmd_complete): New function.
7381         * mi/mi-main.c (mi_cmd_complete): Likewise.
7382         * mi/mi-cmds.c: Define new MI command -complete.
7383         * NEWS: Mention new -complete command.
7384
7385 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7386
7387         * completer.h (complete): New function.
7388         * completer.c (complete): Likewise.
7389         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7390         function defined in completer.h.
7391
7392 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7393
7394         * MAINTAINERS (Write After Approval): Add myself.
7395
7396 2019-05-17  Tom de Vries  <tdevries@suse.de>
7397
7398         PR gdb/24094
7399         * dwarf2read.c (struct cu_partial_die_info): New struct.
7400         (find_partial_die): Return cu_partial_die_info.
7401         (partial_die_parent_scope, guess_partial_die_structure_name)
7402         (partial_die_info::fixup): Handle new return type of find_partial_die.
7403
7404 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7405
7406         PR breakpoints/24541
7407         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7408         "std::string", simplifying the algorithm.
7409
7410 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7411
7412         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7413         (stap_static_probe_ops::get_probes): Likewise.
7414
7415 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7416
7417         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7418         '-')" and "else if".
7419         (stap_parse_single_operand): Join checks for
7420         "gdbarch_stap_parse_special_token_p" and
7421         "gdbarch_stap_parse_special_token" in the same "if" statement.
7422         Invert check when verifying for operation on register
7423         displacement.
7424
7425 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7426
7427         * stap-probe.c (stap_get_opcode): Update comment.
7428         (stap_get_expected_argument_type): Likewise.
7429         (handle_stap_probe): Likewise.
7430
7431 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7432
7433         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7434         return type to 'bool'.  Adjust comment.  Use 'bool' when
7435         appropriate.
7436         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7437         * stap-probe.c (stap_parse_argument_1): Likewise.
7438         (stap_is_operator): Likewise.
7439         (stap_is_generic_prefix): Likewise.
7440         (stap_is_register_prefix): Likewise.
7441         (stap_is_register_indirection_prefix): Likewise.
7442         (stap_is_integer_prefix): Likewise.
7443         (stap_generic_check_suffix): Likewise.
7444         (stap_check_integer_suffix): Likewise.
7445         (stap_check_register_suffix): Likewise.
7446         (stap_check_register_indirection_suffix): Likewise.
7447         (stap_parse_register_operand): Likewise.
7448         (stap_parse_single_operand): Likewise.
7449         (stap_parse_argument_1): Likewise.
7450         (stap_probe::get_argument_count): Likewise.
7451         (stap_is_operator): Likewise.
7452
7453 2019-05-16  Tom Tromey  <tromey@adacore.com>
7454
7455         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7456         keyword to foreach.
7457
7458 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7459
7460         * linux-thread-db.c (try_thread_db_load_1): Change return type
7461         to bool.
7462         (try_thread_db_load): Likewise.
7463         (try_thread_db_load_from_pdir_1): Likewise.
7464         (try_thread_db_load_from_pdir): Likewise.
7465         (try_thread_db_load_from_sdir): Likewise.
7466         (try_thread_db_load_from_dir): Likewise.
7467         (thread_db_load_search): Likewise.
7468         (has_libpthread): Likewise.
7469         (thread_db_load): Likewise.
7470
7471 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7472
7473         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7474         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7475         NULL, and complain/return if that's the case.
7476
7477 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7478
7479         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7480         (advance, posn, abstract_read_memory): New functions.
7481         [struct mem_read_abstraction]: New struct.
7482         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7483
7484 2019-05-14  Tom Tromey  <tromey@adacore.com>
7485
7486         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7487         value is not lval_memory.
7488
7489 2019-05-14  Tom Tromey  <tromey@adacore.com>
7490
7491         * solib.c (info_sharedlibrary_command): Style the file name.
7492
7493 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7494
7495         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7496         (aarch64_vnv_type): Likewise.
7497         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7498         * common/tdesc.c: Likewise.
7499         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7500         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7501         * features/aarch64-fpu.xml: Add ieee half view.
7502         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7503         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7504         * gdbtypes.h (struct builtin_type): Likewise.
7505         (struct objfile_type): Likewise.
7506
7507 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7508
7509         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7510         typo.
7511         * location.h (string_to_event_location): Likewise.
7512
7513 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7514
7515         GDB 8.3 released.
7516
7517 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7518
7519         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7520         New variable declaration.
7521         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7522         New variable.
7523         (print_one_breakpoint): Use ui_out::test_flags and new global
7524         variable to compute use_fixed_output.
7525         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7526         Remove.
7527         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7528         (mi_multi_location_breakpoint_output_fixed): Remove.
7529         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7530         new variable.
7531         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7532         fix_multi_location_breakpoint_output flag if version >= 3.
7533         * ui-out.h (enum ui_out_flag)
7534         <fix_multi_location_breakpoint_output>: New enumerator.
7535
7536 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7537
7538         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7539
7540 2019-05-10  Tom Tromey  <tromey@adacore.com>
7541
7542         * ada-lang.c (catch_ada_completer): New function.
7543         (_initialize_ada_language): Use it.
7544
7545 2019-05-10  Tom Tromey  <tromey@adacore.com>
7546
7547         * thread.c (print_thread_info): Make "requested_threads" const.
7548         * gdbthread.h (print_thread_info): Make "requested_threads"
7549         const.
7550         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7551         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7552
7553 2019-05-08  Tom Tromey  <tom@tromey.com>
7554
7555         * gdbtypes.c (objfile_type_data): Change type.
7556         (objfile_type, _initialize_gdbtypes): Update.
7557
7558 2019-05-08  Tom Tromey  <tom@tromey.com>
7559
7560         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7561         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7562         (_initialize_dwarf2_frame): Update.
7563
7564 2019-05-08  Tom Tromey  <tom@tromey.com>
7565
7566         * objc-lang.c (objc_objfile_data): Change type.
7567         (find_methods): Update.
7568         (_initialize_objc_lang): Remove.
7569
7570 2019-05-08  Tom Tromey  <tom@tromey.com>
7571
7572         * stabsread.c (rs6000_builtin_type_data): Change type.
7573         (rs6000_builtin_type, _initialize_stabsread): Update.
7574
7575 2019-05-08  Tom Tromey  <tom@tromey.com>
7576
7577         * mips-tdep.c (mips_pdr_data): Remove.
7578         (_initialize_mips_tdep): Update.
7579
7580 2019-05-08  Tom Tromey  <tom@tromey.com>
7581
7582         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7583         (hppa_init_objfile_priv_data, read_unwind_info)
7584         (find_unwind_entry, _initialize_hppa_tdep): Update.
7585
7586 2019-05-08  Tom Tromey  <tom@tromey.com>
7587
7588         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7589         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7590         on obstack.
7591         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7592
7593 2019-05-08  Tom Tromey  <tom@tromey.com>
7594
7595         * mdebugread.c (basic_type_data): Change type.
7596         (basic_type, _initialize_mdebugread): Update.
7597
7598 2019-05-08  Tom Tromey  <tom@tromey.com>
7599
7600         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7601
7602 2019-05-08  Tom Tromey  <tom@tromey.com>
7603
7604         * nto-tdep.c (nto_inferior_data_reg): Change type.
7605         (nto_inferior_data): Update.
7606         (nto_inferior_data_cleanup, nto_new_inferior_data)
7607         (_initialize_nto_tdep): Remove.
7608         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7609
7610 2019-05-08  Tom Tromey  <tom@tromey.com>
7611
7612         * ada-lang.c (struct ada_inferior_data): Add initializers.
7613         (ada_inferior_data): Change type.
7614         (ada_inferior_data_cleanup): Remove.
7615         (get_ada_inferior_data, ada_inferior_exit)
7616         (struct ada_pspace_data): Add initializers, destructor.
7617         (ada_pspace_data_handle): Change type.
7618         (get_ada_pspace_data): Update.
7619         (ada_pspace_data_cleanup): Remove.
7620
7621 2019-05-08  Tom Tromey  <tom@tromey.com>
7622
7623         * coffread.c (struct coff_symfile_info): Add initializers.
7624         (coff_objfile_data_key): Move lower.  Change type.
7625         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7626         Update.
7627         (coff_free_info): Remove.
7628
7629 2019-05-08  Tom Tromey  <tom@tromey.com>
7630
7631         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7632         (fbsd_pspace_data_handle): Move lower.  Change type.
7633         (get_fbsd_pspace_data): Update.
7634         (fbsd_pspace_data_cleanup): Remove.
7635         (_initialize_fbsd_tdep): Update.
7636
7637 2019-05-08  Tom Tromey  <tom@tromey.com>
7638
7639         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7640         (get_ada_tasks_pspace_data): Update.
7641         (ada_tasks_pspace_data_cleanup): Remove.
7642         (_initialize_tasks): Update.
7643         (ada_tasks_inferior_data_handle): Change type.
7644         (get_ada_tasks_inferior_data): Update.
7645         (ada_tasks_inferior_data_cleanup): Remove.
7646         (struct ada_tasks_pspace_data): Add initializers.
7647
7648 2019-05-08  Tom Tromey  <tom@tromey.com>
7649
7650         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7651         * symfile-debug.c (debug_sym_get_probes): Change type.
7652         * stap-probe.c (handle_stap_probe):
7653         (stap_static_probe_ops::get_probes): Change type.
7654         * probe.h (class static_probe_ops) <get_probes>: Change type.
7655         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7656         (parse_probes_in_pspace): Update.
7657         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7658         Update.
7659         (any_static_probe_ops::get_probes): Change type.
7660         * elfread.c (elfread_data): New typedef.
7661         (probe_key): Change type.
7662         (elf_get_probes): Likewise.  Update.
7663         (probe_key_free): Remove.
7664         (_initialize_elfread): Update.
7665         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7666         Change type.
7667         (dtrace_process_dof_probe, dtrace_process_dof)
7668         (dtrace_static_probe_ops::get_probe): Change type.
7669
7670 2019-05-08  Tom Tromey  <tom@tromey.com>
7671
7672         * xcoffread.c (struct xcoff_symfile_info): Rename from
7673         coff_symfile_info.  Add initializers.
7674         (xcoff_objfile_data_key): Move lower.  Change type.
7675         (XCOFF_DATA): Rewrite.
7676         (xcoff_free_info): Remove.
7677         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7678         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7679         (xcoff_initial_scan): Update.
7680
7681 2019-05-08  Tom Tromey  <tom@tromey.com>
7682
7683         * solib-svr4.c (struct svr4_info): Add initializers and
7684         destructor.
7685         <probes_table>: Now an htab_up.
7686         (solib_svr4_pspace_data): Change type.
7687         (free_probes_table): Simplify.
7688         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7689         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7690         (probes_table_remove_objfile_probes, register_solib_event_probe)
7691         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7692         (_initialize_svr4_solib): Update.
7693
7694 2019-05-08  Tom Tromey  <tom@tromey.com>
7695
7696         * remote.c (remote_pspace_data): Change type.
7697         (remote_pspace_data_cleanup): Remove.
7698         (get_remote_exec_file, set_pspace_remote_exec_file)
7699         (_initialize_remote): Update.
7700
7701 2019-05-08  Tom Tromey  <tom@tromey.com>
7702
7703         * breakpoint.c (breakpoint_objfile_key): Change type.
7704         (get_breakpoint_objfile_data): Update.
7705         (free_breakpoint_objfile_data): Remove.
7706         (_initialize_breakpoint): Update.
7707
7708 2019-05-08  Tom Tromey  <tom@tromey.com>
7709
7710         * linux-tdep.c (struct linux_info): Add initializers.
7711         (linux_inferior_data): Move.  Change type.
7712         (invalidate_linux_cache_inf): Update.
7713         (linux_inferior_data_cleanup): Remove.
7714         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7715
7716 2019-05-08  Tom Tromey  <tom@tromey.com>
7717
7718         * auxv.c (auxv_inferior_data): Move.  Change type.
7719         (auxv_inferior_data_cleanup): Remove.
7720         (invalidate_auxv_cache_inf): Rewrite.
7721         (get_auxv_inferior_data, _initialize_auxv): Update.
7722
7723 2019-05-08  Tom Tromey  <tom@tromey.com>
7724
7725         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7726         (symfile_debug_objfile_data_key): Change type.
7727         (symfile_debug_installed, debug_qf_has_symbols)
7728         (debug_qf_find_last_source_symtab)
7729         (debug_qf_forget_cached_source_info)
7730         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7731         (debug_qf_print_stats, debug_qf_dump)
7732         (debug_qf_expand_symtabs_for_function)
7733         (debug_qf_expand_all_symtabs)
7734         (debug_qf_expand_symtabs_with_fullname)
7735         (debug_qf_map_matching_symbols)
7736         (debug_qf_expand_symtabs_matching)
7737         (debug_qf_find_pc_sect_compunit_symtab)
7738         (debug_qf_map_symbol_filenames)
7739         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7740         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7741         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7742         (debug_sym_read_linetable, debug_sym_relocate): Update.
7743         (symfile_debug_free_objfile): Remove.
7744         (install_symfile_debug_logging, _initialize_symfile_debug):
7745         Update.
7746
7747 2019-05-08  Tom Tromey  <tom@tromey.com>
7748
7749         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7750         allocate_on_obstack.
7751         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7752         (get_dwarf2_per_objfile): Update.
7753         (set_dwarf2_per_objfile): Remove.
7754         (dwarf2_has_info, dwarf2_get_section_info): Update.
7755         (dwarf2_free_objfile): Remove.
7756         (_initialize_dwarf2_read): Update.
7757
7758 2019-05-08  Tom Tromey  <tom@tromey.com>
7759
7760         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7761         initializers.
7762         <unsupported_script_warning_printed,
7763         script_not_found_warning_printed>: Now bool.
7764         (auto_load_pspace_data): Change type.
7765         (~auto_load_pspace_info): Rename from
7766         auto_load_pspace_data_cleanup.
7767         (get_auto_load_pspace_data, init_loaded_scripts_info)
7768         (clear_section_scripts, maybe_print_unsupported_script_warning)
7769         (maybe_print_script_not_found_warning, _initialize_auto_load):
7770         Update.
7771
7772 2019-05-08  Tom Tromey  <tom@tromey.com>
7773
7774         * objfiles.c (objfile_pspace_info): Add destructor and
7775         initializers.
7776         (objfiles_pspace_data): Change type.
7777         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7778         (get_objfile_pspace_data): Update.
7779         (objfiles_bfd_data): Change type.
7780         (get_objfile_bfd_data): Update.
7781         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7782
7783 2019-05-08  Tom Tromey  <tom@tromey.com>
7784
7785         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7786         Change type.
7787         (get_catch_syscall_inferior_data): Update.
7788         (catch_syscall_inferior_data_cleanup): Remove.
7789         (_initialize_break_catch_syscall): Update.
7790
7791 2019-05-08  Tom Tromey  <tom@tromey.com>
7792
7793         * inflow.c (struct terminal_info): Add destructor and
7794         initializers.
7795         (inflow_inferior_data): Change type.
7796         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7797         (get_inflow_inferior_data, inflow_inferior_exit)
7798         (swap_terminal_info, _initialize_inflow): Update.
7799
7800 2019-05-08  Tom Tromey  <tom@tromey.com>
7801
7802         * target-dcache.c (target_dcache_cleanup): Remove.
7803         (target_dcache_aspace_key): Change type.
7804         (target_dcache_init_p, target_dcache_invalidate)
7805         (target_dcache_get, target_dcache_get_or_init)
7806         (_initialize_target_dcache): Update.
7807         * dcache.h (struct dcache_deleter): New.
7808
7809 2019-05-08  Tom Tromey  <tom@tromey.com>
7810
7811         * symtab.c (struct symbol_cache): Add destructor and
7812         initializers.
7813         (symbol_cache_key): Move.  Change type.
7814         (make_symbol_cache, free_symbol_cache): Remove.
7815         (get_symbol_cache): Update.
7816         (symbol_cache_cleanup): Remove.
7817         (ALL_PSPACES, symbol_cache_flush)
7818         (maintenance_print_symbol_cache)
7819         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7820         Update.
7821
7822 2019-05-08  Tom Tromey  <tom@tromey.com>
7823
7824         * symtab.c (struct main_info): Add destructor and initializers.
7825         (main_progspace_key): Move.  Change type.
7826         (get_main_info): Update.
7827         (main_info_cleanup): Remove.
7828         (_initialize_symtab): Update.
7829
7830 2019-05-08  Tom Tromey  <tom@tromey.com>
7831
7832         * registry.h (DECLARE_REGISTRY): Define the _key class.
7833
7834 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7835
7836         * NEWS: Merge two 'New commands' sections.
7837
7838 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7839
7840         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7841         parameter and use Ada language definition instead.
7842         (ada_val_print_ptr): Remove unused language parameter.
7843         (ada_val_print_num): Remove language parameter and use Ada language
7844         definition instead.
7845         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7846         parameter.
7847         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7848         parameter and use Ada language definition instead.
7849         (ada_val_print_1): Update all ada_val_print_xxx calls.
7850         Remove language parameter.
7851         (ada_val_print): Update ada_val_print_1 call.
7852
7853 2019-05-08  Tom Tromey  <tromey@adacore.com>
7854
7855         * remote.c (remote_hw_watchpoint_limit)
7856         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7857         Now static.
7858
7859 2019-05-08  Tom Tromey  <tromey@adacore.com>
7860
7861         * maint.c (_initialize_maint_cmds): Move initialization code to
7862         remote.c.
7863         (watchdog, show_watchdog): Move to remote.c.
7864         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7865         "watchdog" static.
7866         (_initialize_remote): Move initialization code from maint.c.
7867         * defs.h (watchdog): Don't declare.
7868
7869 2019-05-08  Tom Tromey  <tromey@adacore.com>
7870
7871         * tui/tui-interp.c: Include main.h.
7872         * interps.c: Include main.h.
7873         * main.h (interpreter_p): Declare.
7874         * defs.h (interpreter_p): Don't declare.
7875
7876 2019-05-08  Tom Tromey  <tromey@adacore.com>
7877
7878         * dwarf2loc.c: Include dwarf2read.h.
7879         * defs.h (read_unsigned_leb128): Don't declare.
7880         * dwarf2read.h (read_unsigned_leb128): Declare.
7881
7882 2019-05-08  Tom Tromey  <tromey@adacore.com>
7883
7884         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7885         method.
7886
7887 2019-05-08  Tom Tromey  <tromey@adacore.com>
7888
7889         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7890         when no wrap column is set.
7891
7892 2019-05-08  Tom Tromey  <tromey@adacore.com>
7893
7894         * c-lang.c (c_get_string): Handle non-C-style arrays.
7895
7896 2019-05-08  Tom Tromey  <tromey@adacore.com>
7897
7898         * typeprint.c (print_offset_data::update): Print the bit offset,
7899         not the number of bits remaining.
7900
7901 2019-05-08  Tom Tromey  <tromey@adacore.com>
7902
7903         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7904         padding at end of comment.
7905
7906 2019-05-08  Tom Tromey  <tromey@adacore.com>
7907
7908         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7909         Compare main types.
7910
7911 2019-05-06  Tom Tromey  <tom@tromey.com>
7912
7913         * common/scoped_mmap.c: Include common-defs.h.
7914         * common/scoped_mmap.h: Don't include config.h.
7915
7916 2019-05-04  Tom Tromey  <tom@tromey.com>
7917
7918         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7919         (struct aarch64_call_info): Add initializers.
7920         <si>: Now a std::vector.
7921         (pass_on_stack, aarch64_push_dummy_call): Update.
7922
7923 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7924             Tom Tromey  <tom@tromey.com>
7925
7926         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7927         (ppc_threads): Now a std::vector.  Now static.
7928         (hwdebug_find_thread_points_by_tid)
7929         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7930         Update.
7931
7932 2019-05-04  Tom Tromey  <tom@tromey.com>
7933
7934         * arc-tdep.c (arc_tdesc_init): Return bool.
7935
7936 2019-05-04  Tom Tromey  <tom@tromey.com>
7937
7938         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7939         Use gdb_assert_not_reached.
7940
7941 2019-05-04  Tom Tromey  <tom@tromey.com>
7942
7943         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7944         "false".
7945
7946 2019-05-04  Tom Tromey  <tom@tromey.com>
7947
7948         * arc-tdep.c (arc_tdesc_init): Use bool.
7949
7950 2019-05-04  Tom Tromey  <tom@tromey.com>
7951
7952         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7953
7954 2019-05-04  Tom Tromey  <tom@tromey.com>
7955
7956         * cli/cli-cmds.c (valid_command_p): Return bool.
7957
7958 2019-05-04  Tom Tromey  <tom@tromey.com>
7959
7960         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7961         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7962
7963 2019-05-04  Raul Tambre  <raul@tambre.ee>
7964
7965         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7966         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7967         operator for comparison.
7968
7969 2019-05-04  Tom Tromey  <tom@tromey.com>
7970
7971         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7972         (lookup_partial_symbol, print_partial_symbols)
7973         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7974         (psymbol_compare): Update.
7975         (add_psymbol_to_bcache): Clear the entire psymbol.
7976         (maintenance_check_psymtabs): Update.
7977         * psympriv.h (struct partial_symbol): Don't derive from
7978         general_symbol_info.
7979         <obj_section, unrelocated_address, address,
7980         set_unrelocated_address>: Update.
7981         <ginfo>: New member.
7982         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7983         (debug_names::write_psymbols): Update.
7984
7985 2019-05-04  Tom de Vries  <tdevries@suse.de>
7986
7987         * contrib/cc-with-tweaks.sh: Support -n arg.
7988
7989 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7990
7991         * corelow.c (core_target::detach): Ensure frame cache and
7992         register caches are cleared.
7993         inferior.c (exit_inferior_1): Likewise.
7994
7995 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7996             Tom Tromey  <tom@tromey.com>
7997
7998         * dictionary.c (collate_pending_symbols_by_language): Remove
7999         "struct" from foreach.
8000         * symtab.c (lookup_global_symbol_from_objfile)
8001         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8002         foreach.
8003         * ser-tcp.c (net_open): Remove "struct" from foreach.
8004         * objfiles.c (objfile_relocate, objfile_rebase)
8005         (objfile_has_symbols): Remove "struct" from foreach.
8006         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8007         from foreach.
8008         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8009         foreach.
8010         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8011         "struct" from foreach.
8012         * ada-lang.c (create_excep_cond_exprs)
8013         (ada_exception_catchpoint_cond_string): Remove "struct" from
8014         foreach.
8015
8016 2019-05-03  Tom Tromey  <tromey@adacore.com>
8017
8018         * ada-exp.y (convert_char_literal): Check suffix of each
8019         enumerator.
8020
8021 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8022
8023         PR ada/21406:
8024         * ada-exp.y (yywrap): Don't define.
8025         * ada-lex.l (%option): Add noyywrap
8026         (yywrap): Remove.
8027
8028 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8029
8030         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8031         _WIN32_WINNT to the XP level, unless already defined to a higher
8032         level.
8033
8034         * unittests/parse-connection-spec-selftests.c:
8035         * ser-tcp.c:
8036         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8037         override.
8038
8039         * symfile.c (find_separate_debug_file): Remove colon from the
8040         drive spec of DOS/Windows file names of the target, so that the
8041         file name produced from DEBUGDIR and the target's directory will
8042         be valid on DOS/Windows systems.
8043
8044 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8045
8046         * rust-lang.c (val_print_struct): Handle printing structures
8047         containing strings.
8048
8049 2019-05-02  Tom Tromey  <tromey@adacore.com>
8050
8051         * valarith.c (_initialize_valarith): Remove.
8052
8053 2019-05-01  Tom Tromey  <tromey@adacore.com>
8054
8055         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8056         bitfields.
8057
8058 2019-05-01  Tom Tromey  <tromey@adacore.com>
8059
8060         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8061         for big-endian copies.
8062
8063 2019-04-30  Ali Tamur  <tamur@google.com>
8064         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8065         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8066         (read_3_bytes): New function.
8067
8068 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8069
8070         * windows-nat.c (main_thread_id): Delete.
8071         (handle_output_debug_string): Replace main_thread_id by
8072         current_event.dwThreadId.
8073         (fake_create_process): Likewise.
8074         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8075         Do not set main_thread_id.
8076         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8077         current_event.dwThreadId.
8078         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8079
8080 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8081
8082         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8083         Use current_event.dwThreadId instead of main_thread_id.
8084
8085 2019-04-30  Tom Tromey  <tromey@adacore.com>
8086
8087         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8088         (create_excep_cond_exprs): Iterate over program spaces.
8089         (ada_exception_catchpoint_cond_string): Examine all minimal
8090         symbols for exception types.
8091
8092 2019-04-30  Tom Tromey  <tromey@adacore.com>
8093
8094         PR c++/24470:
8095         * dwarf2read.c (process_structure_scope): Handle case where type
8096         has template parameters but no symbol was created.
8097
8098 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8099             Chris January  <chris.january@arm.com>
8100
8101         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8102         qualifier.
8103         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8104
8105 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8106
8107         * f-typeprint.c (f_print_type): Update rules for printing
8108         whitespace.
8109         (f_type_print_varspec_suffix): Likewise.
8110
8111 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8112             Chris January  <chris.january@arm.com>
8113
8114         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8115         function arguments.
8116
8117 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8118
8119         * f-lang.c (build_fortran_types): Change name of void type to
8120         lower case.
8121         * f-typeprint.c (f_type_print_base): Print the name of the void
8122         type, rather than a fixed string.
8123         * f-valprint.c (f_decorations): Use lower case void string.
8124
8125 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8126             Chris January  <chris.january@arm.com>
8127
8128         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8129         types for Fortran.
8130
8131 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8132             Chris January  <chris.january@arm.com>
8133             David Lecomber  <david.lecomber@arm.com>
8134
8135         * f-exp.y (BINOP_INTRINSIC): New token.
8136         (exp): New parser rule handling BINOP_INTRINSIC.
8137         (f77_keywords): Add new builtin procedures.
8138         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8139         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8140         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8141         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8142         (print_unop_subexp_f): New function.
8143         (print_binop_subexp_f): New function.
8144         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8145         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8146         (dump_subexp_body_f): Likewise.
8147         (operator_check_f): Likewise.
8148         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8149         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8150
8151 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8152
8153         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8154         UNOP_KIND.
8155         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8156         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8157         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8158         (operator_length_f): New fuction.
8159         (print_subexp_f): New function.
8160         (op_name_f): New function.
8161         (dump_subexp_body_f): New function.
8162         (operator_check_f): New function.
8163         (exp_descriptor_f): Replace standard expression handling functions
8164         with new functions.
8165         * gdb/fortran-operator.def: New file.
8166         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8167         * gdb/std-operator.def: Remove UNOP_KIND.
8168
8169 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8170
8171         * std-operator.def: Remove unbalanced, stray double quote
8172         character.
8173
8174 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8175             Chris January  <chris.january@arm.com>
8176             Daniel Everett  <daniel.everett@arm.com>
8177             Nick Forrington  <nick.forrington@arm.com>
8178             Richard Bunt  <richard.bunt@arm.com>
8179
8180         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8181         of depth when printing anonymous structs or unions.
8182         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8183         Don't print either the top-level value, or the children if the
8184         max-depth is exceeded.
8185         (ppscm_print_children): When printing the key of a map, allow one
8186         extra level of depth.
8187         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8188         print either the top-level value, or the children if the max-depth
8189         is exceeded.
8190         (print_children): When printing the key of a map, allow one extra
8191         level of depth.
8192         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8193         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8194         (user_print_options): Initialise max_depth field.
8195         (val_print_scalar_or_string_type_p): New function.
8196         (val_print): Check to see if the max depth has been reached.
8197         (val_print_check_max_depth): Define new function.
8198         (show_print_max_depth): New function.
8199         (_initialize_valprint): Add 'print max-depth' option.
8200         * valprint.h (struct value_print_options) <max_depth>: New field.
8201         (val_print_check_max_depth): Declare new function.
8202         * NEWS: Document new feature.
8203
8204 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8205
8206         * ada-lang.c (ada_language_defn): Initialise new field.
8207         * c-lang.c (c_is_string_type_p): New function.
8208         (c_language_defn): Initialise new field.
8209         (cplus_language_defn): Initialise new field.
8210         (asm_language_defn): Initialise new field.
8211         (minimal_language_defn): Initialise new field.
8212         * c-lang.h (c_is_string_type_p): Declare new function.
8213         * d-lang.c (d_language_defn): Initialise new field.
8214         * f-lang.c (f_is_string_type_p): New function.
8215         (f_language_defn): Initialise new field.
8216         * go-lang.c (go_is_string_type_p): New function.
8217         (go_language_defn): Initialise new field.
8218         * language.c (default_is_string_type_p): New function.
8219         (unknown_language_defn): Initialise new field.
8220         (auto_language_defn): Initialise new field.
8221         * language.h (struct language_defn) <la_is_string_type_p>: New
8222         member variable.
8223         (default_is_string_type_p): Declare new function.
8224         * m2-lang.c (m2_language_defn): Initialise new field.
8225         * objc-lang.c (objc_language_defn): Initialise new field.
8226         * opencl-lang.c (opencl_language_defn): Initialise new field.
8227         * p-lang.c (pascal_is_string_type_p): New function.
8228         (pascal_language_defn): Initialise new field.
8229         * rust-lang.c (rust_is_string_type_p): New function.
8230         (rust_language_defn): Initialise new field.
8231
8232 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8233
8234         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8235         New field.
8236         * ada-lang.c (ada_language_defn): Initialise new field.
8237         * c-lang.c (c_language_defn): Likewise.
8238         (cplus_language_defn): Likewise.
8239         (asm_language_defn): Likewise.
8240         (minimal_language_defn): Likewise.
8241         * d-lang.c (d_language_defn): Likewise.
8242         * f-lang.c (f_language_defn): Likewise.
8243         * go-lang.c (go_language_defn): Likewise.
8244         * language.c (unknown_language_defn): Likewise.
8245         (auto_language_defn): Likewise.
8246         * m2-lang.c (m2_language_defn): Likewise.
8247         * objc-lang.c (objc_language_defn): Likewise.
8248         * opencl-lang.c (opencl_language_defn): Likewise.
8249         * p-lang.c (pascal_language_defn): Likewise.
8250         * rust-lang.c (rust_language_defn): Likewise.
8251
8252 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8253
8254         * ada-lang.c (ada_is_character_type): Change return type to bool.
8255         (ada_is_string_type): Likewise.
8256         * ada-lang.h (ada_is_character_type): Update declaration
8257         (ada_is_string_type): Likewise.
8258
8259 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8260
8261         Support style in 'frame|thread apply'
8262
8263         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8264         * record.c (record_start, record_stop): Update callers of
8265         execute_command_to_string with false.
8266         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8267         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8268         methods.
8269         (class string_file): New constructor with term_out parameter.
8270         Override methods term_out and can_emit_style_escape.  New member
8271         term_out.
8272         (class stdio_file): Override can_emit_style_escape.
8273         (class tee_file): Override term_out and can_emit_style_escape.
8274         * utils.h (can_emit_style_escape): Remove.
8275         * utils.c (can_emit_style_escape): Likewise.
8276         Update all callers of can_emit_style_escape (SOMESTREAM) to
8277         SOMESTREAM->can_emit_style_escape.
8278         * source-cache.c (source_cache::get_source_lines): Likewise.
8279         * stack.c (frame_apply_command_count): Call execute_command_to_string
8280         passing the term_out characteristic of the current gdb_stdout.
8281         * thread.c (thr_try_catch_cmd): Likewise.
8282         * top.c (execute_command_to_string): pass term_out parameter
8283         to construct the string_file for the command output.
8284         * ui-file.c (term_cli_styling): New function (most code moved
8285         from utils.c can_emit_style_escape).
8286         (string_file::string_file, string_file::can_emit_style_escape,
8287         stdio_file::can_emit_style_escape, tee_file::term_out,
8288         tee_file::can_emit_style_escape): New functions.
8289
8290 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8291
8292         * NEWS: Mention the new set|show may-call-functions.
8293         * infcall.c (may_call_functions_p): New variable.
8294         (show_may_call_functions_p): New function.
8295         (call_function_by_hand_dummy): Throws an error if not
8296         may-call-functions.
8297         (_initialize_infcall): Call add_setshow_boolean_cmd for
8298         may-call-functions.
8299
8300 2019-04-25  Keith Seitz  <keiths@redhat.com>
8301
8302         PR c++/24367
8303         * cp-support.c (inspect_type): Don't attempt substitutions
8304         of symbol with the same name.
8305
8306 2019-04-25  Tom Tromey  <tromey@adacore.com>
8307
8308         PR gdb/24475:
8309         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8310         static.
8311
8312 2019-04-25  Tom Tromey  <tromey@adacore.com>
8313
8314         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8315         rvalue reference.
8316         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8317         (gdb_xml_parser::parse): Use std::move.
8318         * python/python-internal.h (gdbpy_convert_exception): Take a const
8319         reference.
8320         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8321         std::move.
8322         * python/py-utils.c (gdbpy_convert_exception): Take a const
8323         reference.
8324         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8325         Use std::move.
8326         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8327         Use std::move.
8328         * mi/mi-main.c (mi_print_exception): Take a const reference.
8329         * main.c (handle_command_errors): Take a const reference.
8330         * linespec.c (parse_linespec): Use std::move.
8331         * infcall.c (run_inferior_call): Use std::move.
8332         (call_function_by_hand_dummy): Use std::move.
8333         * exec.c (try_open_exec_file): Use std::move.
8334         * exceptions.h (exception_print, exception_fprintf)
8335         (exception_print_same): Update.
8336         * exceptions.c (print_exception, exception_print)
8337         (exception_fprintf, exception_print_same): Change parameters to
8338         const reference.
8339         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8340         * common/new-op.c: Use std::move.
8341         * common/common-exceptions.h (struct gdb_exception): Add move
8342         constructor.
8343         (struct gdb_exception_error, struct gdb_exception_quit, struct
8344         gdb_quit_bad_alloc): Change constructor to move constructor.
8345         (throw_exception): Change parameter to rvalue reference.
8346         * common/common-exceptions.c (throw_exception): Take rvalue
8347         reference.
8348         * cli/cli-interp.c (safe_execute_command): Use std::move.
8349         * breakpoint.c (insert_bp_location, location_to_sals): Use
8350         std::move.
8351
8352 2019-04-25  Tom Tromey  <tromey@adacore.com>
8353
8354         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8355         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8356         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8357         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8358         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8359         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8360         guile/scm-value.c: Use unpack.
8361         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8362         gdbscm_gdb_exception.
8363         (gdbscm_throw_gdb_exception): Likewise.
8364         (struct gdbscm_gdb_exception): New.
8365         (unpack): New function.
8366         (gdbscm_wrap): Use unpack.
8367
8368 2019-04-25  Tom Tromey  <tromey@adacore.com>
8369
8370         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8371         (gdb_rl_callback_handler): Use std::move.
8372         * common/common-exceptions.h (struct gdb_exception): Add move
8373         assignment operator.
8374         (throw_exception_sjlj): Change "exception" to const reference.
8375         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8376         (throw_exception_sjlj): Change "exception" to const reference.
8377
8378 2019-04-25  Tom Tromey  <tromey@adacore.com>
8379
8380         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8381         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8382         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8383         Update.
8384         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8385         Update.
8386         * mi/mi-interp.c (mi_interp::exec): Update.
8387         * linespec.c (parse_linespec): Update.
8388         * infcall.c (run_inferior_call): Update.
8389         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8390         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8391         (gdbscm_lookup_global_symbol): Update.
8392         * guile/scm-param.c (gdbscm_parameter_value): Update.
8393         * guile/scm-frame.c (gdbscm_frame_read_register)
8394         (gdbscm_frame_read_var): Update.
8395         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8396         * exec.c (try_open_exec_file): Update.
8397         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8398         (gdb_rl_callback_handler): Update.
8399         * common/common-exceptions.h (exception_none): Don't declare.
8400         * common/common-exceptions.c (exception_none): Don't define.
8401         (struct catcher) <exception>: Update.
8402         * cli/cli-interp.c (safe_execute_command): Update.
8403         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8404
8405 2019-04-25  Ali Tamur  <tamur@google.com>
8406
8407         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8408         (read_attribute_value): Likewise.
8409         (dwarf2_read_addr_index): Update comment.
8410         (read_str_index): Add DW_FORM_strx.
8411         (dwarf2_string_attr): Likewise.
8412         (dwarf2_const_value_attr): Likewise.
8413         (dump_die_shallow): Likewise.
8414         (dwarf2_fetch_constant_bytes): Likewise.
8415         (skip_form_bytes): Likewise.
8416         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8417
8418 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8419
8420         PR corefiles/11608
8421         PR corefiles/18187
8422         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8423         OFFSET.  Verify if current mapping contains an ELF header.
8424         (linux_find_memory_regions_full): Adjust call to
8425         dump_mapping_p.
8426
8427 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8428             Kang Li <kanglictf@gmail.com>
8429
8430         PR gdb/21600
8431
8432         * dwarf2-frame.c (read_initial_length): Be consistent about using
8433         unsigned representation of length.
8434         (decode_frame_entry_1): Likewise.  Check for wraparound of
8435         end pointer as well as buffer overflow.
8436
8437 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8438
8439         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8440         "vq".
8441
8442 2019-04-24  Tom Tromey  <tromey@adacore.com>
8443
8444         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8445
8446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8447
8448         * s12z-tdep.c (s12z_unwind_pc): Delete.
8449         (s12z_unwind_sp): Delete.
8450         (s12z_gdbarch_init): Don't register deleted functions with
8451         gdbarch.
8452
8453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8454
8455         * rl78-tdep.c (rl78_unwind_sp): Delete.
8456         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8457
8458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8459
8460         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8461         (xstormy16_unwind_pc): Delete.
8462         (xstormy16_dummy_id): Delete.
8463         (xstormy16_gdbarch_init): Don't register deleted functions with
8464         gdbarch.
8465
8466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8467
8468         * vax-tdep.c (vax_unwind_pc): Delete.
8469         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8470
8471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8472
8473         * v850-tdep.c (v850_unwind_sp): Delete.
8474         (v850_unwind_pc): Delete.
8475         (v850_dummy_id): Delete.
8476         (v850_gdbarch_init): Don't register deleted functions with
8477         gdbarch.
8478
8479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8480
8481         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8482         (tilegx_unwind_pc): Delete.
8483         (tilegx_unwind_dummy_id): Delete.
8484         (tilegx_gdbarch_init): Don't register deleted functions with
8485         gdbarch.
8486
8487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8488
8489         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8490         (tic6x_dummy_id): Delete.
8491         (tic6x_gdbarch_init): Don't register deleted functions with
8492         gdbarch.
8493
8494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8495
8496         * sparc-tdep.c (sparc_unwind_pc): Delete.
8497         (sparc32_gdbarch_init): Don't register deleted function with
8498         gdbarch.
8499
8500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8501
8502         * sh-tdep.c (sh_unwind_sp): Delete.
8503         (sh_unwind_pc): Delete.
8504         (sh_dummy_id): Delete.
8505         (sh_gdbarch_init): Don't register deleted functions with
8506         gdbarch.
8507
8508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8509
8510         * score-tdep.c (score_unwind_sp): Delete.
8511         (score_unwind_pc): Delete.
8512         (score_dummy_id): Delete.
8513         (score_gdbarch_init): Don't register deleted functions with
8514         gdbarch.
8515
8516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8517
8518         * rx-tdep.c (rx_unwind_pc): Delete.
8519         (rx_unwind_sp): Delete.
8520         (rx_dummy_id): Delete.
8521         (rx_gdbarch_init): Don't register deleted functions with
8522         gdbarch.  Update comment.
8523
8524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8525
8526         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8527         (rs6000_dummy_id): Delete.
8528         (rs6000_gdbarch_init): Don't register deleted functions with
8529         gdbarch.
8530
8531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8532
8533         * or1k-tdep.c (or1k_dummy_id): Delete.
8534         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8535
8536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8537
8538         * nios2-tdep.c (nios2_dummy_id): Delete.
8539         (nios2_unwind_sp): Delete.
8540         (nios2_gdbarch_init): Don't register deleted functions with
8541         gdbarch.
8542
8543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8544
8545         * nds32-tdep.c (nds32_dummy_id): Delete.
8546         (nds32_unwind_pc): Delete.
8547         (nds32_unwind_sp): Delete.
8548         (nds32_gdbarch_init): Don't register deleted functions with
8549         gdbarch.
8550
8551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8552
8553         * msp430-tdep.c (msp430_unwind_pc): Delete.
8554         (msp430_unwind_sp): Delete.
8555         (msp430_dummy_id): Delete.
8556         (msp430_gdbarch_init): Don't register deleted functions with
8557         gdbarch.
8558
8559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8560
8561         * moxie-tdep.c (moxie_unwind_sp): Delete.
8562         (moxie_unwind_pc): Delete.
8563         (moxie_dummy_id): Delete.
8564         (moxie_gdbarch_init): Don't register deleted functions with
8565         gdbarch.
8566
8567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8568
8569         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8570         (mn10300_unwind_pc): Delete.
8571         (mn10300_unwind_sp): Delete.
8572         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8573         mn10300_unwind_sp.
8574         (mn10300_frame_unwind_init): Don't register deleted functions with
8575         gdbarch.
8576
8577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8578
8579         * mep-tdep.c (mep_unwind_pc): Delete.
8580         (mep_unwind_sp): Delete.
8581         (mep_dummy_id): Delete.
8582         (mep_gdbarch_init): Don't register deleted functions with
8583         gdbarch.
8584
8585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8586
8587         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8588         (m68hc11_unwind_sp): Delete.
8589         (m68hc11_gdbarch_init): Don't register deleted functions with
8590         gdbarch.
8591
8592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8593
8594         * m32r-tdep.c (m32r_unwind_sp): Delete.
8595         (m32r_unwind_pc): Delete.
8596         (m32r_dummy_id): Delete.
8597         (m32r_gdbarch_init): Don't register deleted functions with
8598         gdbarch.
8599
8600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8601
8602         * m32c-tdep.c (m32c_unwind_pc): Delete.
8603         (m32c_unwind_sp): Delete.
8604         (m32c_dummy_id): Delete.
8605         (m32c_gdbarch_init): Don't register deleted functions with
8606         gdbarch.
8607
8608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8609
8610         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8611         (lm32_unwind_pc): Delete.
8612         (lm32_dummy_id): Delete.
8613         (lm32_gdbarch_init): Don't register deleted functions with
8614         gdbarch.
8615
8616 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8617
8618         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8619         (iq2000_unwind_pc): Delete.
8620         (iq2000_dummy_id): Delete.
8621         (iq2000_gdbarch_init): Don't register deleted functions with
8622         gdbarch.
8623
8624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8625
8626         * nds32-tdep.c (nds32_type_align): Delete.
8627         (nds32_push_dummy_call): Use type_align instead.
8628
8629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8630
8631         * arm-tdep.c (arm_type_align): Only handle vector override case.
8632         (arm_push_dummy_call): Use type_align.
8633         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8634
8635 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8636
8637         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8638         case.
8639         (pass_on_stack): Use type_align.
8640         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8641         function.
8642
8643 2019-04-23  Tom Tromey  <tromey@adacore.com>
8644
8645         * dwarf2read.c (line_header::file_name_at): Remove unused
8646         overload.
8647
8648 2019-04-23  Tom de Vries  <tdevries@suse.de>
8649
8650         PR gdb/24438
8651         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8652         invocation.
8653
8654
8655 2019-03-27  Ali Tamur  <tamur@google.com>
8656
8657         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8658         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8659         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8660         (dwarf_expr_context::get_addr_index): Likewise
8661         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8662         (symbol_needs_eval_context::get_addr_index): Likewise
8663         (disassemble_dwarf_expression): Add DW_OP_addrx
8664         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8665         (read_cutu_die_from_dwo): Update comment
8666         (skip_one_die): Add DW_FORM_addrx
8667         (read_attribute_value): Likewise
8668         (var_decode_location): Add DW_OP_addrx
8669         (dwarf2_const_value_attr): Add DW_FORM_addrx
8670         (dump_die_shallow): Likewise
8671         (dwarf2_fetch_constant_bytes): Likewise
8672         (decode_locdesc): Add DW_OP_addrx
8673         (skip_form_bytes): Add DW_FORM_addrx
8674
8675 2019-04-22  Ali Tamur  <tamur@google.com>
8676
8677         * MAINTAINERS (Write After Approval): Add self.
8678
8679 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8680
8681         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8682         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8683         (open_symbol_file_object): Likewise.
8684         (svr4_default_sos): Add info parameter.
8685         (svr4_read_so_list): Likewise.
8686         (svr4_current_sos_direct): Adjust functions calls to pass down
8687         info.
8688         (svr4_current_sos_1): Add info parameter.
8689         (svr4_current_sos): Call get_svr4_info, pass info down to
8690         svr4_current_sos_1.
8691         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8692         get_svr4_info.
8693         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8694         get_svr4_info.
8695         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8696         to get_svr4_info.
8697         (probes_table_remove_objfile_probes): Likewise.
8698         (register_solib_event_probe): Add info parameter.
8699         (solist_update_incremental): Pass info parameter down to
8700         svr4_read_so_list.
8701         (disable_probes_interface): Add info parameter.
8702         (svr4_handle_solib_event): Pass current_program_space to
8703         get_svr4_info.  Adjust disable_probes_interface cleanup.
8704         (svr4_create_probe_breakpoints): Add info parameter, pass it
8705         down to register_solib_event_probe.
8706         (svr4_create_solib_event_breakpoints): Add info parameter,
8707         pass it down to svr4_create_probe_breakpoints.
8708         (enable_break): Pass info down to
8709         svr4_create_solib_event_breakpoints.
8710         (svr4_solib_create_inferior_hook): Pass current_program_space to
8711         get_svr4_info.
8712         (svr4_clear_solib): Likewise.
8713
8714 2019-04-22  Pedro Alves  <palves@redhat.com>
8715
8716         * solib-svr4.c (svr4_free_objfile_observer): New.
8717         (probe_and_action::objfile): New field.
8718         (probes_table_htab_remove_objfile_probes)
8719         (probes_table_remove_objfile_probes): New functions.
8720         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8721         in the new probe_and_action.  Don't store the probe in 'lookup'.
8722         (svr4_create_probe_breakpoints): Pass objfile to
8723         register_solib_event_probe.
8724         (_initialize_svr4_solib): Register a free_objfile observer.
8725
8726 2019-04-19  Tom Tromey  <tom@tromey.com>
8727
8728         * common/queue.h: Remove.
8729
8730 2019-04-19  Tom Tromey  <tom@tromey.com>
8731
8732         * event-loop.c: Don't include "common/queue.h".
8733
8734 2019-04-19  Tom Tromey  <tom@tromey.com>
8735
8736         * remote.c (remote_target): Use delete.
8737         * remote-notif.h: Include <list>, not "common/queue.h".
8738         (notif_client_p): Remove typedef.
8739         (remote_notif_state): Add constructor, destructor, initializer.
8740         <notif_queue>: Now a std::list.
8741         (remote_notif_state_xfree): Don't declare.
8742         * remote-notif.c (remote_notif_process, handle_notification)
8743         (remote_notif_state_allocate): Update.
8744         (~remote_notif_state): Rename from remote_notif_state_xfree.
8745
8746 2019-04-19  Tom Tromey  <tom@tromey.com>
8747
8748         * symfile.c (reread_symbols): Update.
8749         * objfiles.c (objfile_register_static_link)
8750         (objfile_lookup_static_link): Update
8751         (~objfile) Don't delete static_links.
8752         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8753
8754 2019-04-19  Tom Tromey  <tom@tromey.com>
8755
8756         * type-stack.h (struct type_stack) <insert>: Constify string.
8757         * type-stack.c (type_stack::insert): Constify string.
8758         * gdbtypes.h (lookup_template_type): Update.
8759         (address_space_name_to_int): Update.
8760         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8761         const.
8762         (lookup_template_type): Make name const.
8763         * c-exp.y: Update rules.
8764         (lex_one_token, classify_name, classify_inner_name)
8765         (c_print_token): Update.
8766         * p-exp.y: Update rules.
8767         (yylex): Update.
8768         * f-exp.y: Update rules.
8769         (yylex): Update.
8770         * d-exp.y: Update rules.
8771         (lex_one_token, classify_name, classify_inner_name): Update.
8772         * parse.c (write_dollar_variable, copy_name): Return std::string.
8773         * parser-defs.h (copy_name): Change return type.
8774         * m2-exp.y: Update rules.
8775         (yylex): Update.
8776         * go-exp.y (lex_one_token): Update.
8777         Update rules.
8778         (classify_unsafe_function, classify_packaged_name)
8779         (classify_name, yylex): Update.
8780
8781 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8782
8783         * configure.ac: add --enable-source-highlight switch.
8784         * configure: Regenerate.
8785         * top.c (print_gdb_version): plumb --enable-source-highlight
8786         status to "show configuration".
8787
8788 2019-04-19  Tom Tromey  <tromey@adacore.com>
8789
8790         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8791         Check ADA_TYPE_P.
8792         (empty_record, ada_template_to_fixed_record_type_1)
8793         (template_to_static_fixed_type)
8794         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8795         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8796         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8797         macros.
8798
8799 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8800
8801         PR symtab/24423:
8802         * source.c (print_source_lines_base): Advance "iter" when a
8803         control character is seen.
8804
8805 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8806
8807         * inferior.h (struct infcall_suspend_state_deleter):
8808         Catch exception in destructor to avoid crash.
8809
8810 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8811
8812         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8813         close to the add_com "shell".
8814
8815 2019-04-18  Tom Tromey  <tromey@adacore.com>
8816
8817         * process-stratum-target.h (class process_stratum_target)
8818         <stratum>: Add "final".
8819
8820 2019-04-17  Tom Tromey  <tromey@adacore.com>
8821
8822         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8823         against nullptr before use.
8824
8825 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8826
8827         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8828
8829 2019-04-17  Jim Wilson  <jimw@sifive.com>
8830             Andrew Burgess  <andrew.burgess@embecosm.com>
8831
8832         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8833         code read might fail, assume 4-byte breakpoint in that case.
8834
8835 2019-04-15  Leszek Swirski  <leszeks@google.com>
8836
8837         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8838         rather than a hand-rolled POD check when checking for forced MEMORY
8839         classification.
8840
8841 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8842
8843         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8844         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8845         function.
8846         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8847         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8848         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8849         declaration.
8850
8851 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8852
8853         * aarch64-linux-nat.c
8854         (aarch64_linux_nat_target::thread_architecture): Add override.
8855         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8856         each VQ.
8857
8858 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8859
8860         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8861
8862 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8863
8864         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8865         target types of size 96-bits, add some additional comments, and
8866         check that the builtin type we found was the correct size.
8867
8868 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8869
8870         * utils.c (prompt_for_continue): Don't restore the styling at the
8871         end, as applied_style has the wrong value.  This fixes styling in
8872         long lists of file names that are interrupted by the "Continue?"
8873         prompt.
8874
8875 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8876
8877         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8878         * c-lang.c (c_language_defn): Likewise.
8879         (cplus_language_defn): Likewise.
8880         (asm_language_defn): Likewise.
8881         (minimal_language_defn): Likewise.
8882         * d-lang.c (d_language_defn): Likewise.
8883         * f-lang.c (f_language_defn): Likewise.
8884         * go-lang.c (go_language_defn): Likewise.
8885         * language.c (unknown_language_defn): Likewise.
8886         (auto_language_defn): Likewise.
8887         * language.h (struct language_defn): Remove la_magic field.
8888         (LANG_MAGIC): Delete.
8889         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8890         * objc-lang.c (objc_language_defn): Likewise.
8891         * opencl-lang.c (opencl_language_defn): Likewise.
8892         * p-lang.c (pascal_language_defn): Likewise.
8893         * rust-lang.c (rust_language_defn): Likewise.
8894
8895 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8896
8897         * riscv-tdep.c (riscv_type_align): New function.
8898         (riscv_type_alignment): Delete.
8899         (riscv_arg_location): Use 'type_align'.
8900         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8901
8902 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8903
8904         * gdbtypes.c (type_align): A struct with no non-static fields also
8905         has alignment of 1.
8906
8907 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8908
8909         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8910         component to 0.
8911         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8912         member.
8913         (riscv_struct_info::analyse): New implementation using new
8914         analyse_inner member function.
8915         (riscv_struct_info::field_offset): New member function.
8916         (riscv_struct_info::m_offsets): New member variable.
8917         (riscv_struct_info::analyse_inner): New private member function,
8918         takes the old implementation of riscv_struct_info::analyse but
8919         extended to track field offsets.
8920         (riscv_call_arg_struct): Update the struct folding special cases
8921         to handle cases where empty C++ structs, which are non-zero
8922         length, are found.
8923         (riscv_arg_location): Initialise the length of each location, a
8924         non-zero length now indicates the location is in use.
8925         (riscv_push_dummy_call): Allow for the first location having a
8926         non-zero offset when setting up arguments.
8927         (riscv_return_value): Likewise, but for return values.
8928
8929 2019-04-11  Tom Tromey  <tromey@adacore.com>
8930
8931         * utils.c (internal_vproblem): Make "msg" const.
8932
8933 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8934
8935         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8936         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8937         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8938         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8939
8940 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8941
8942         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8943         function.
8944         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8945         of amd64_collect_native_gregset.
8946         (amd64_linux_nat_target::store_registers): Likewise.
8947
8948 2019-04-10  Tom Tromey  <tom@tromey.com>
8949
8950         * symtab.c (lookup_global_symbol_from_objfile)
8951         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8952         * objfiles.h (class separate_debug_iterator): New.
8953         (class separate_debug_range): New.
8954         (struct objfile) <separate_debug_objfiles>: New method.
8955         (objfile_separate_debug_iterate): Don't declare.
8956         * objfiles.c (separate_debug_iterator::operator++): Rename from
8957         objfile_separate_debug_iterate.
8958         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8959         iterator.
8960         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8961         iterator.
8962
8963 2019-04-10  Tom Tromey  <tom@tromey.com>
8964
8965         * symfile.c (reread_symbols): Remove old comment.
8966         * objfiles.c (free_all_objfiles): Fix a typo.
8967
8968 2019-04-10  Tom Tromey  <tom@tromey.com>
8969
8970         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8971         * minsyms.c (lookup_minimal_symbol): Use foreach.
8972         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8973         (lookup_minimal_symbol_solib_trampoline): Likewise.
8974         * symfile.c (reread_symbols): Use foreach.
8975
8976 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8977             Tom Tromey  <tromey@adacore.com>
8978
8979         PR rust/24414:
8980         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8981         (rust_lex_int_test): Change "value" to be LONGEST.
8982         (rust_lex_tests): Add test for long integer literal.
8983
8984 2019-04-09  Tom Tromey  <tromey@adacore.com>
8985
8986         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8987         to bool.
8988         (extended_remote_target::attach): Update.
8989         (remote_target::remote_notice_new_inferior): Update.
8990         (remote_target::add_current_inferior_and_thread): Update.
8991         * inferior.c (exit_inferior_1): Use "false".
8992         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8993
8994 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8995
8996         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8997         the "start" command.
8998
8999 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9000
9001         * python/py-inferior.c (infpy_thread_from_thread_handle):
9002         Adjust comments to reflect renaming of thread_from_thread_handle
9003         to thread_from_handle.  Adjust keywords.  Fix type error message.
9004         (inferior_object_methods): Add thread_from_handle.  Retain
9005         thread_from_thread_handle, but mark it as deprecated.
9006
9007 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9008
9009         * gdbthread.h (find_thread_by_handle): Revise declaration.
9010         * thread.c (find_thread_by_handle): Likewise.  Adjust
9011         implementation too.
9012         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9013         support for buffer objects as handles.
9014
9015 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9016
9017         * python/py-infthread.c (thpy_thread_handle): New function.
9018         (thread_object_methods): Register thpy_thread_handle.
9019
9020 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9021
9022         * gdbthread.h (thread_to_thread_handle): Declare.
9023         * thread.c (gdbtypes.h): Include.
9024         (thread_to_thread_handle): New function.
9025
9026         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9027         (target_thread_info_to_thread_handle): Declare.
9028         * target.c (target_thread_info_to_thread_handle): New function.
9029         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9030         * target-delegates.c: Regenerate.
9031
9032         * linux-thread-db.c (class thread_db_target): Add method
9033         thread_info_to_thread_handle.
9034         (thread_db_target::thread_info_to_thread_handle): Define.
9035         * remote.c (class remote_target): Add new method
9036         thread_info_to_thread_handle.
9037         (remote_target::thread_info_to_thread_handle): Define.
9038
9039 2019-04-08  Pedro Alves  <palves@redhat.com>
9040
9041         * common/common-exceptions.c (throw_exception): Don't create
9042         named object to throw; throw directly.
9043         (throw_it): Likewise.  Don't initialize gdb_exception::message
9044         here, with new; pass FMT and AP to the ctor instead.
9045         * common/common-exceptions.h: Include <string>.
9046         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9047         const char *, va_list)): New ctor.  Use std::make_shared.
9048         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9049         errors)): Delete.
9050         (gdb_exception_error::gdb_exception_error(enum errors, const char
9051         *, va_list)): New.
9052         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9053         Add assertion.
9054         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9055         errors)): Delete.
9056         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9057         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9058         Add assertion.
9059
9060 2019-04-08  Tom Tromey  <tom@tromey.com>
9061
9062         * valops.c (value_rtti_indirect_type): Replace throw_exception
9063         with throw.
9064         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9065         with throw.
9066         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9067         throw.
9068         * target.c (target_translate_tls_address): Replace throw_exception
9069         with throw.
9070         * stack.c (frame_apply_command_count): Replace throw_exception
9071         with throw.
9072         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9073         throw.
9074         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9075         with throw.
9076         * rs6000-tdep.c (rs6000_frame_cache)
9077         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9078         * remote.c: Replace throw_exception with throw.
9079         * record-full.c (record_full_message, record_full_wait_1)
9080         (record_full_restore): Replace throw_exception with throw.
9081         * record-btrace.c:
9082         (get_thread_current_frame_id, record_btrace_start_replaying)
9083         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9084         (cmd_record_btrace_start): Replace throw_exception with throw.
9085         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9086         throw.
9087         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9088         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9089         * linespec.c:
9090         (find_linespec_symbols): Replace throw_exception with throw.
9091         * infrun.c (displaced_step_prepare, resume): Replace
9092         throw_exception with throw.
9093         * infcmd.c (post_create_inferior): Replace throw_exception with
9094         throw.
9095         * inf-loop.c (inferior_event_handler): Replace throw_exception
9096         with throw.
9097         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9098         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9099         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9100         (get_prev_frame_always, get_frame_pc_if_available)
9101         (get_frame_address_in_block_if_available, get_frame_language):
9102         Replace throw_exception with throw.
9103         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9104         throw_exception with throw.
9105         * eval.c (fetch_subexp_value, evaluate_var_value)
9106         (evaluate_funcall, evaluate_subexp_standard): Replace
9107         throw_exception with throw.
9108         * dwarf2loc.c (call_site_find_chain)
9109         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9110         Replace throw_exception with throw.
9111         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9112         with throw.
9113         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9114         throw.
9115         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9116         * completer.c (complete_line_internal): Replace throw_exception
9117         with throw.
9118         * compile/compile-object-run.c (compile_object_run): Replace
9119         throw_exception with throw.
9120         * cli/cli-script.c (process_next_line): Replace throw_exception
9121         with throw.
9122         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9123         (btrace_enable, btrace_maint_update_pt_packets): Replace
9124         throw_exception with throw.
9125         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9126         throw_exception with throw.
9127         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9128         throw_exception with throw.
9129         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9130         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9131         * aarch64-tdep.c (aarch64_make_prologue_cache)
9132         (aarch64_make_stub_cache): Replace throw_exception with throw.
9133
9134 2019-04-08  Tom Tromey  <tom@tromey.com>
9135
9136         * common/common-exceptions.c (throw_exception): Rename from
9137         throw_exception_cxx.  Remove old copy.  Make argument const.
9138         (throw_it): Create and throw exception objects directly.
9139         * common/common-exceptions.h (throw_exception): Make argument
9140         const.
9141         (struct gdb_exception_error): Add constructor.
9142         (struct gdb_exception_quit): Add constructor.
9143
9144 2019-04-08  Tom Tromey  <tom@tromey.com>
9145
9146         * common/common-exceptions.h (exception_rethrow): Don't declare.
9147         (TRY_SJLJ): Update comment.
9148         (TRY, CATCH, END_CATCH): Remove.
9149         * common/common-exceptions.c (exception_rethrow): Remove.
9150
9151 2019-04-08  Tom Tromey  <tom@tromey.com>
9152
9153         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9154         Remove.
9155         (gdb_exception_error): Rename from
9156         gdb_exception_RETURN_MASK_ERROR.
9157         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9158         (gdb_quit_bad_alloc): Update.
9159         * aarch64-tdep.c: Update.
9160         * ada-lang.c: Update.
9161         * ada-typeprint.c: Update.
9162         * ada-valprint.c: Update.
9163         * amd64-tdep.c: Update.
9164         * arch-utils.c: Update.
9165         * break-catch-throw.c: Update.
9166         * breakpoint.c: Update.
9167         * btrace.c: Update.
9168         * c-varobj.c: Update.
9169         * cli/cli-cmds.c: Update.
9170         * cli/cli-interp.c: Update.
9171         * cli/cli-script.c: Update.
9172         * common/common-exceptions.c: Update.
9173         * common/new-op.c: Update.
9174         * common/selftest.c: Update.
9175         * compile/compile-c-symbols.c: Update.
9176         * compile/compile-cplus-symbols.c: Update.
9177         * compile/compile-object-load.c: Update.
9178         * compile/compile-object-run.c: Update.
9179         * completer.c: Update.
9180         * corelow.c: Update.
9181         * cp-abi.c: Update.
9182         * cp-support.c: Update.
9183         * cp-valprint.c: Update.
9184         * darwin-nat.c: Update.
9185         * disasm-selftests.c: Update.
9186         * dtrace-probe.c: Update.
9187         * dwarf-index-cache.c: Update.
9188         * dwarf-index-write.c: Update.
9189         * dwarf2-frame-tailcall.c: Update.
9190         * dwarf2-frame.c: Update.
9191         * dwarf2loc.c: Update.
9192         * dwarf2read.c: Update.
9193         * eval.c: Update.
9194         * event-loop.c: Update.
9195         * event-top.c: Update.
9196         * exec.c: Update.
9197         * f-valprint.c: Update.
9198         * fbsd-tdep.c: Update.
9199         * frame-unwind.c: Update.
9200         * frame.c: Update.
9201         * gdbtypes.c: Update.
9202         * gnu-v3-abi.c: Update.
9203         * guile/guile-internal.h: Update.
9204         * guile/scm-block.c: Update.
9205         * guile/scm-breakpoint.c: Update.
9206         * guile/scm-cmd.c: Update.
9207         * guile/scm-disasm.c: Update.
9208         * guile/scm-frame.c: Update.
9209         * guile/scm-lazy-string.c: Update.
9210         * guile/scm-math.c: Update.
9211         * guile/scm-param.c: Update.
9212         * guile/scm-ports.c: Update.
9213         * guile/scm-pretty-print.c: Update.
9214         * guile/scm-symbol.c: Update.
9215         * guile/scm-symtab.c: Update.
9216         * guile/scm-type.c: Update.
9217         * guile/scm-value.c: Update.
9218         * i386-linux-tdep.c: Update.
9219         * i386-tdep.c: Update.
9220         * inf-loop.c: Update.
9221         * infcall.c: Update.
9222         * infcmd.c: Update.
9223         * infrun.c: Update.
9224         * jit.c: Update.
9225         * language.c: Update.
9226         * linespec.c: Update.
9227         * linux-fork.c: Update.
9228         * linux-nat.c: Update.
9229         * linux-tdep.c: Update.
9230         * linux-thread-db.c: Update.
9231         * main.c: Update.
9232         * mi/mi-cmd-break.c: Update.
9233         * mi/mi-cmd-stack.c: Update.
9234         * mi/mi-interp.c: Update.
9235         * mi/mi-main.c: Update.
9236         * objc-lang.c: Update.
9237         * p-valprint.c: Update.
9238         * parse.c: Update.
9239         * ppc-linux-tdep.c: Update.
9240         * printcmd.c: Update.
9241         * python/py-arch.c: Update.
9242         * python/py-breakpoint.c: Update.
9243         * python/py-cmd.c: Update.
9244         * python/py-finishbreakpoint.c: Update.
9245         * python/py-frame.c: Update.
9246         * python/py-framefilter.c: Update.
9247         * python/py-gdb-readline.c: Update.
9248         * python/py-inferior.c: Update.
9249         * python/py-infthread.c: Update.
9250         * python/py-lazy-string.c: Update.
9251         * python/py-linetable.c: Update.
9252         * python/py-objfile.c: Update.
9253         * python/py-param.c: Update.
9254         * python/py-prettyprint.c: Update.
9255         * python/py-progspace.c: Update.
9256         * python/py-record-btrace.c: Update.
9257         * python/py-record.c: Update.
9258         * python/py-symbol.c: Update.
9259         * python/py-type.c: Update.
9260         * python/py-unwind.c: Update.
9261         * python/py-utils.c: Update.
9262         * python/py-value.c: Update.
9263         * python/python.c: Update.
9264         * record-btrace.c: Update.
9265         * record-full.c: Update.
9266         * remote-fileio.c: Update.
9267         * remote.c: Update.
9268         * riscv-tdep.c: Update.
9269         * rs6000-aix-tdep.c: Update.
9270         * rs6000-tdep.c: Update.
9271         * rust-exp.y: Update.
9272         * rust-lang.c: Update.
9273         * s390-tdep.c: Update.
9274         * selftest-arch.c: Update.
9275         * solib-dsbt.c: Update.
9276         * solib-frv.c: Update.
9277         * solib-spu.c: Update.
9278         * solib-svr4.c: Update.
9279         * solib.c: Update.
9280         * sparc64-linux-tdep.c: Update.
9281         * stack.c: Update.
9282         * symfile-mem.c: Update.
9283         * symmisc.c: Update.
9284         * target.c: Update.
9285         * thread.c: Update.
9286         * top.c: Update.
9287         * tracefile-tfile.c: Update.
9288         * tui/tui.c: Update.
9289         * typeprint.c: Update.
9290         * unittests/cli-utils-selftests.c: Update.
9291         * unittests/parse-connection-spec-selftests.c: Update.
9292         * valops.c: Update.
9293         * valprint.c: Update.
9294         * value.c: Update.
9295         * varobj.c: Update.
9296         * windows-nat.c: Update.
9297         * x86-linux-nat.c: Update.
9298         * xml-support.c: Update.
9299
9300 2019-04-08  Tom Tromey  <tom@tromey.com>
9301
9302         * xml-support.c: Use C++ exception handling.
9303         * x86-linux-nat.c: Use C++ exception handling.
9304         * windows-nat.c: Use C++ exception handling.
9305         * varobj.c: Use C++ exception handling.
9306         * value.c: Use C++ exception handling.
9307         * valprint.c: Use C++ exception handling.
9308         * valops.c: Use C++ exception handling.
9309         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9310         handling.
9311         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9312         * typeprint.c: Use C++ exception handling.
9313         * tui/tui.c: Use C++ exception handling.
9314         * tracefile-tfile.c: Use C++ exception handling.
9315         * top.c: Use C++ exception handling.
9316         * thread.c: Use C++ exception handling.
9317         * target.c: Use C++ exception handling.
9318         * symmisc.c: Use C++ exception handling.
9319         * symfile-mem.c: Use C++ exception handling.
9320         * stack.c: Use C++ exception handling.
9321         * sparc64-linux-tdep.c: Use C++ exception handling.
9322         * solib.c: Use C++ exception handling.
9323         * solib-svr4.c: Use C++ exception handling.
9324         * solib-spu.c: Use C++ exception handling.
9325         * solib-frv.c: Use C++ exception handling.
9326         * solib-dsbt.c: Use C++ exception handling.
9327         * selftest-arch.c: Use C++ exception handling.
9328         * s390-tdep.c: Use C++ exception handling.
9329         * rust-lang.c: Use C++ exception handling.
9330         * rust-exp.y: Use C++ exception handling.
9331         * rs6000-tdep.c: Use C++ exception handling.
9332         * rs6000-aix-tdep.c: Use C++ exception handling.
9333         * riscv-tdep.c: Use C++ exception handling.
9334         * remote.c: Use C++ exception handling.
9335         * remote-fileio.c: Use C++ exception handling.
9336         * record-full.c: Use C++ exception handling.
9337         * record-btrace.c: Use C++ exception handling.
9338         * python/python.c: Use C++ exception handling.
9339         * python/py-value.c: Use C++ exception handling.
9340         * python/py-utils.c: Use C++ exception handling.
9341         * python/py-unwind.c: Use C++ exception handling.
9342         * python/py-type.c: Use C++ exception handling.
9343         * python/py-symbol.c: Use C++ exception handling.
9344         * python/py-record.c: Use C++ exception handling.
9345         * python/py-record-btrace.c: Use C++ exception handling.
9346         * python/py-progspace.c: Use C++ exception handling.
9347         * python/py-prettyprint.c: Use C++ exception handling.
9348         * python/py-param.c: Use C++ exception handling.
9349         * python/py-objfile.c: Use C++ exception handling.
9350         * python/py-linetable.c: Use C++ exception handling.
9351         * python/py-lazy-string.c: Use C++ exception handling.
9352         * python/py-infthread.c: Use C++ exception handling.
9353         * python/py-inferior.c: Use C++ exception handling.
9354         * python/py-gdb-readline.c: Use C++ exception handling.
9355         * python/py-framefilter.c: Use C++ exception handling.
9356         * python/py-frame.c: Use C++ exception handling.
9357         * python/py-finishbreakpoint.c: Use C++ exception handling.
9358         * python/py-cmd.c: Use C++ exception handling.
9359         * python/py-breakpoint.c: Use C++ exception handling.
9360         * python/py-arch.c: Use C++ exception handling.
9361         * printcmd.c: Use C++ exception handling.
9362         * ppc-linux-tdep.c: Use C++ exception handling.
9363         * parse.c: Use C++ exception handling.
9364         * p-valprint.c: Use C++ exception handling.
9365         * objc-lang.c: Use C++ exception handling.
9366         * mi/mi-main.c: Use C++ exception handling.
9367         * mi/mi-interp.c: Use C++ exception handling.
9368         * mi/mi-cmd-stack.c: Use C++ exception handling.
9369         * mi/mi-cmd-break.c: Use C++ exception handling.
9370         * main.c: Use C++ exception handling.
9371         * linux-thread-db.c: Use C++ exception handling.
9372         * linux-tdep.c: Use C++ exception handling.
9373         * linux-nat.c: Use C++ exception handling.
9374         * linux-fork.c: Use C++ exception handling.
9375         * linespec.c: Use C++ exception handling.
9376         * language.c: Use C++ exception handling.
9377         * jit.c: Use C++ exception handling.
9378         * infrun.c: Use C++ exception handling.
9379         * infcmd.c: Use C++ exception handling.
9380         * infcall.c: Use C++ exception handling.
9381         * inf-loop.c: Use C++ exception handling.
9382         * i386-tdep.c: Use C++ exception handling.
9383         * i386-linux-tdep.c: Use C++ exception handling.
9384         * guile/scm-value.c: Use C++ exception handling.
9385         * guile/scm-type.c: Use C++ exception handling.
9386         * guile/scm-symtab.c: Use C++ exception handling.
9387         * guile/scm-symbol.c: Use C++ exception handling.
9388         * guile/scm-pretty-print.c: Use C++ exception handling.
9389         * guile/scm-ports.c: Use C++ exception handling.
9390         * guile/scm-param.c: Use C++ exception handling.
9391         * guile/scm-math.c: Use C++ exception handling.
9392         * guile/scm-lazy-string.c: Use C++ exception handling.
9393         * guile/scm-frame.c: Use C++ exception handling.
9394         * guile/scm-disasm.c: Use C++ exception handling.
9395         * guile/scm-cmd.c: Use C++ exception handling.
9396         * guile/scm-breakpoint.c: Use C++ exception handling.
9397         * guile/scm-block.c: Use C++ exception handling.
9398         * guile/guile-internal.h: Use C++ exception handling.
9399         * gnu-v3-abi.c: Use C++ exception handling.
9400         * gdbtypes.c: Use C++ exception handling.
9401         * frame.c: Use C++ exception handling.
9402         * frame-unwind.c: Use C++ exception handling.
9403         * fbsd-tdep.c: Use C++ exception handling.
9404         * f-valprint.c: Use C++ exception handling.
9405         * exec.c: Use C++ exception handling.
9406         * event-top.c: Use C++ exception handling.
9407         * event-loop.c: Use C++ exception handling.
9408         * eval.c: Use C++ exception handling.
9409         * dwarf2read.c: Use C++ exception handling.
9410         * dwarf2loc.c: Use C++ exception handling.
9411         * dwarf2-frame.c: Use C++ exception handling.
9412         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9413         * dwarf-index-write.c: Use C++ exception handling.
9414         * dwarf-index-cache.c: Use C++ exception handling.
9415         * dtrace-probe.c: Use C++ exception handling.
9416         * disasm-selftests.c: Use C++ exception handling.
9417         * darwin-nat.c: Use C++ exception handling.
9418         * cp-valprint.c: Use C++ exception handling.
9419         * cp-support.c: Use C++ exception handling.
9420         * cp-abi.c: Use C++ exception handling.
9421         * corelow.c: Use C++ exception handling.
9422         * completer.c: Use C++ exception handling.
9423         * compile/compile-object-run.c: Use C++ exception handling.
9424         * compile/compile-object-load.c: Use C++ exception handling.
9425         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9426         * compile/compile-c-symbols.c: Use C++ exception handling.
9427         * common/selftest.c: Use C++ exception handling.
9428         * common/new-op.c: Use C++ exception handling.
9429         * cli/cli-script.c: Use C++ exception handling.
9430         * cli/cli-interp.c: Use C++ exception handling.
9431         * cli/cli-cmds.c: Use C++ exception handling.
9432         * c-varobj.c: Use C++ exception handling.
9433         * btrace.c: Use C++ exception handling.
9434         * breakpoint.c: Use C++ exception handling.
9435         * break-catch-throw.c: Use C++ exception handling.
9436         * arch-utils.c: Use C++ exception handling.
9437         * amd64-tdep.c: Use C++ exception handling.
9438         * ada-valprint.c: Use C++ exception handling.
9439         * ada-typeprint.c: Use C++ exception handling.
9440         * ada-lang.c: Use C++ exception handling.
9441         * aarch64-tdep.c: Use C++ exception handling.
9442
9443 2019-04-08  Tom Tromey  <tom@tromey.com>
9444
9445         * xml-support.c (gdb_xml_parser::parse): Update.
9446         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9447         * value.c (show_convenience): Update.
9448         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9449         (test_parse_flags_qcs): Update.
9450         * thread.c (thr_try_catch_cmd): Update.
9451         * target.c (target_translate_tls_address): Update.
9452         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9453         (info_frame_command_core, frame_apply_command_count): Update.
9454         * rust-exp.y (rust_lex_exception_test): Update.
9455         * riscv-tdep.c (riscv_print_one_register_info): Update.
9456         * remote.c (remote_target::enable_btrace): Update.
9457         * record-btrace.c (record_btrace_enable_warn): Update.
9458         * python/py-utils.c (gdbpy_convert_exception): Update.
9459         * printcmd.c (do_one_display, print_variable_and_value): Update.
9460         * mi/mi-main.c (mi_print_exception): Update.
9461         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9462         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9463         * linux-nat.c (linux_nat_target::attach): Update.
9464         * linux-fork.c (class scoped_switch_fork_info): Update.
9465         * infrun.c (displaced_step_prepare): Update.
9466         * infcall.c (call_function_by_hand_dummy): Update.
9467         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9468         * gnu-v3-abi.c (print_one_vtable): Update.
9469         * frame.c (get_prev_frame_always): Update.
9470         * f-valprint.c (info_common_command_for_block): Update.
9471         * exec.c (try_open_exec_file): Update.
9472         * exceptions.c (print_exception, exception_print)
9473         (exception_fprintf, exception_print_same): Update.
9474         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9475         * dwarf-index-cache.c (index_cache::store)
9476         (index_cache::lookup_gdb_index): Update.
9477         * darwin-nat.c (maybe_cache_shell): Update.
9478         * cp-valprint.c (cp_print_value_fields): Update.
9479         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9480         (gcc_cplus_symbol_address): Update.
9481         * compile/compile-c-symbols.c (gcc_convert_symbol)
9482         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9483         * common/selftest.c: Update.
9484         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9485         a std::string.
9486         (exception_try_scope_entry, exception_try_scope_exit): Don't
9487         declare.
9488         (struct exception_try_scope): Remove.
9489         (TRY): Don't use exception_try_scope.
9490         (struct gdb_exception): Add constructor, operator=.
9491         <what>: New method.
9492         (struct gdb_exception_RETURN_MASK_ALL)
9493         (struct gdb_exception_RETURN_MASK_ERROR)
9494         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9495         (struct gdb_quit_bad_alloc): Update.
9496         * common/common-exceptions.c (exception_none): Change
9497         initializer.
9498         (struct catcher) <state, exception>: Initialize inline.
9499         <prev>: Remove member.
9500         (current_catcher): Remove.
9501         (catchers): New global.
9502         (exceptions_state_mc_init): Simplify.
9503         (catcher_pop): Remove.
9504         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9505         (try_scope_depth, exception_try_scope_entry)
9506         (exception_try_scope_exit): Remove.
9507         (throw_exception_sjlj): Update.
9508         (exception_messages, exception_messages_size): Remove.
9509         (throw_it): Simplify.
9510         (gdb_exception_sliced_copy): Remove.
9511         (throw_exception_cxx): Update.
9512         * cli/cli-script.c (script_from_file): Update.
9513         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9514         Update.
9515         * ada-valprint.c (ada_val_print): Update.
9516         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9517         (create_excep_cond_exprs): Update.
9518
9519 2019-04-08  Tom Tromey  <tom@tromey.com>
9520
9521         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9522         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9523         (TRY, CATCH, END_CATCH): Remove some definitions.
9524         * common/common-exceptions.c: Don't use GDB_XCPT.
9525         (catcher_list_size): Remove.
9526         (throw_exception, throw_it): Simplify.
9527
9528 2019-04-05  Tom Tromey  <tom@tromey.com>
9529
9530         Revert the header-sorting patch.
9531         * ft32-tdep.c: Revert.
9532         * frv-tdep.c: Revert.
9533         * frv-linux-tdep.c: Revert.
9534         * frame.c: Revert.
9535         * frame-unwind.c: Revert.
9536         * frame-base.c: Revert.
9537         * fork-child.c: Revert.
9538         * findvar.c: Revert.
9539         * findcmd.c: Revert.
9540         * filesystem.c: Revert.
9541         * filename-seen-cache.h: Revert.
9542         * filename-seen-cache.c: Revert.
9543         * fbsd-tdep.c: Revert.
9544         * fbsd-nat.h: Revert.
9545         * fbsd-nat.c: Revert.
9546         * f-valprint.c: Revert.
9547         * f-typeprint.c: Revert.
9548         * f-lang.c: Revert.
9549         * extension.h: Revert.
9550         * extension.c: Revert.
9551         * extension-priv.h: Revert.
9552         * expprint.c: Revert.
9553         * exec.h: Revert.
9554         * exec.c: Revert.
9555         * exceptions.c: Revert.
9556         * event-top.c: Revert.
9557         * event-loop.c: Revert.
9558         * eval.c: Revert.
9559         * elfread.c: Revert.
9560         * dwarf2read.h: Revert.
9561         * dwarf2read.c: Revert.
9562         * dwarf2loc.c: Revert.
9563         * dwarf2expr.h: Revert.
9564         * dwarf2expr.c: Revert.
9565         * dwarf2-frame.c: Revert.
9566         * dwarf2-frame-tailcall.c: Revert.
9567         * dwarf-index-write.h: Revert.
9568         * dwarf-index-write.c: Revert.
9569         * dwarf-index-common.c: Revert.
9570         * dwarf-index-cache.h: Revert.
9571         * dwarf-index-cache.c: Revert.
9572         * dummy-frame.c: Revert.
9573         * dtrace-probe.c: Revert.
9574         * disasm.h: Revert.
9575         * disasm.c: Revert.
9576         * disasm-selftests.c: Revert.
9577         * dictionary.c: Revert.
9578         * dicos-tdep.c: Revert.
9579         * demangle.c: Revert.
9580         * dcache.h: Revert.
9581         * dcache.c: Revert.
9582         * darwin-nat.h: Revert.
9583         * darwin-nat.c: Revert.
9584         * darwin-nat-info.c: Revert.
9585         * d-valprint.c: Revert.
9586         * d-namespace.c: Revert.
9587         * d-lang.c: Revert.
9588         * ctf.c: Revert.
9589         * csky-tdep.c: Revert.
9590         * csky-linux-tdep.c: Revert.
9591         * cris-tdep.c: Revert.
9592         * cris-linux-tdep.c: Revert.
9593         * cp-valprint.c: Revert.
9594         * cp-support.c: Revert.
9595         * cp-namespace.c: Revert.
9596         * cp-abi.c: Revert.
9597         * corelow.c: Revert.
9598         * corefile.c: Revert.
9599         * continuations.c: Revert.
9600         * completer.h: Revert.
9601         * completer.c: Revert.
9602         * complaints.c: Revert.
9603         * coffread.c: Revert.
9604         * coff-pe-read.c: Revert.
9605         * cli-out.h: Revert.
9606         * cli-out.c: Revert.
9607         * charset.c: Revert.
9608         * c-varobj.c: Revert.
9609         * c-valprint.c: Revert.
9610         * c-typeprint.c: Revert.
9611         * c-lang.c: Revert.
9612         * buildsym.c: Revert.
9613         * buildsym-legacy.c: Revert.
9614         * build-id.h: Revert.
9615         * build-id.c: Revert.
9616         * btrace.c: Revert.
9617         * bsd-uthread.c: Revert.
9618         * breakpoint.h: Revert.
9619         * breakpoint.c: Revert.
9620         * break-catch-throw.c: Revert.
9621         * break-catch-syscall.c: Revert.
9622         * break-catch-sig.c: Revert.
9623         * blockframe.c: Revert.
9624         * block.c: Revert.
9625         * bfin-tdep.c: Revert.
9626         * bfin-linux-tdep.c: Revert.
9627         * bfd-target.c: Revert.
9628         * bcache.c: Revert.
9629         * ax-general.c: Revert.
9630         * ax-gdb.h: Revert.
9631         * ax-gdb.c: Revert.
9632         * avr-tdep.c: Revert.
9633         * auxv.c: Revert.
9634         * auto-load.c: Revert.
9635         * arm-wince-tdep.c: Revert.
9636         * arm-tdep.c: Revert.
9637         * arm-symbian-tdep.c: Revert.
9638         * arm-pikeos-tdep.c: Revert.
9639         * arm-obsd-tdep.c: Revert.
9640         * arm-nbsd-tdep.c: Revert.
9641         * arm-nbsd-nat.c: Revert.
9642         * arm-linux-tdep.c: Revert.
9643         * arm-linux-nat.c: Revert.
9644         * arm-fbsd-tdep.c: Revert.
9645         * arm-fbsd-nat.c: Revert.
9646         * arm-bsd-tdep.c: Revert.
9647         * arch-utils.c: Revert.
9648         * arc-tdep.c: Revert.
9649         * arc-newlib-tdep.c: Revert.
9650         * annotate.h: Revert.
9651         * annotate.c: Revert.
9652         * amd64-windows-tdep.c: Revert.
9653         * amd64-windows-nat.c: Revert.
9654         * amd64-tdep.c: Revert.
9655         * amd64-sol2-tdep.c: Revert.
9656         * amd64-obsd-tdep.c: Revert.
9657         * amd64-obsd-nat.c: Revert.
9658         * amd64-nbsd-tdep.c: Revert.
9659         * amd64-nbsd-nat.c: Revert.
9660         * amd64-nat.c: Revert.
9661         * amd64-linux-tdep.c: Revert.
9662         * amd64-linux-nat.c: Revert.
9663         * amd64-fbsd-tdep.c: Revert.
9664         * amd64-fbsd-nat.c: Revert.
9665         * amd64-dicos-tdep.c: Revert.
9666         * amd64-darwin-tdep.c: Revert.
9667         * amd64-bsd-nat.c: Revert.
9668         * alpha-tdep.c: Revert.
9669         * alpha-obsd-tdep.c: Revert.
9670         * alpha-nbsd-tdep.c: Revert.
9671         * alpha-mdebug-tdep.c: Revert.
9672         * alpha-linux-tdep.c: Revert.
9673         * alpha-linux-nat.c: Revert.
9674         * alpha-bsd-tdep.c: Revert.
9675         * alpha-bsd-nat.c: Revert.
9676         * aix-thread.c: Revert.
9677         * agent.c: Revert.
9678         * addrmap.c: Revert.
9679         * ada-varobj.c: Revert.
9680         * ada-valprint.c: Revert.
9681         * ada-typeprint.c: Revert.
9682         * ada-tasks.c: Revert.
9683         * ada-lang.c: Revert.
9684         * aarch64-tdep.c: Revert.
9685         * aarch64-ravenscar-thread.c: Revert.
9686         * aarch64-newlib-tdep.c: Revert.
9687         * aarch64-linux-tdep.c: Revert.
9688         * aarch64-linux-nat.c: Revert.
9689         * aarch64-fbsd-tdep.c: Revert.
9690         * aarch64-fbsd-nat.c: Revert.
9691         * aarch32-linux-nat.c: Revert.
9692
9693 2019-04-05  Tom Tromey  <tom@tromey.com>
9694
9695         * ft32-tdep.c: Sort headers.
9696         * frv-tdep.c: Sort headers.
9697         * frv-linux-tdep.c: Sort headers.
9698         * frame.c: Sort headers.
9699         * frame-unwind.c: Sort headers.
9700         * frame-base.c: Sort headers.
9701         * fork-child.c: Sort headers.
9702         * findvar.c: Sort headers.
9703         * findcmd.c: Sort headers.
9704         * filesystem.c: Sort headers.
9705         * filename-seen-cache.h: Sort headers.
9706         * filename-seen-cache.c: Sort headers.
9707         * fbsd-tdep.c: Sort headers.
9708         * fbsd-nat.h: Sort headers.
9709         * fbsd-nat.c: Sort headers.
9710         * f-valprint.c: Sort headers.
9711         * f-typeprint.c: Sort headers.
9712         * f-lang.c: Sort headers.
9713         * extension.h: Sort headers.
9714         * extension.c: Sort headers.
9715         * extension-priv.h: Sort headers.
9716         * expprint.c: Sort headers.
9717         * exec.h: Sort headers.
9718         * exec.c: Sort headers.
9719         * exceptions.c: Sort headers.
9720         * event-top.c: Sort headers.
9721         * event-loop.c: Sort headers.
9722         * eval.c: Sort headers.
9723         * elfread.c: Sort headers.
9724         * dwarf2read.h: Sort headers.
9725         * dwarf2read.c: Sort headers.
9726         * dwarf2loc.c: Sort headers.
9727         * dwarf2expr.h: Sort headers.
9728         * dwarf2expr.c: Sort headers.
9729         * dwarf2-frame.c: Sort headers.
9730         * dwarf2-frame-tailcall.c: Sort headers.
9731         * dwarf-index-write.h: Sort headers.
9732         * dwarf-index-write.c: Sort headers.
9733         * dwarf-index-common.c: Sort headers.
9734         * dwarf-index-cache.h: Sort headers.
9735         * dwarf-index-cache.c: Sort headers.
9736         * dummy-frame.c: Sort headers.
9737         * dtrace-probe.c: Sort headers.
9738         * disasm.h: Sort headers.
9739         * disasm.c: Sort headers.
9740         * disasm-selftests.c: Sort headers.
9741         * dictionary.c: Sort headers.
9742         * dicos-tdep.c: Sort headers.
9743         * demangle.c: Sort headers.
9744         * dcache.h: Sort headers.
9745         * dcache.c: Sort headers.
9746         * darwin-nat.h: Sort headers.
9747         * darwin-nat.c: Sort headers.
9748         * darwin-nat-info.c: Sort headers.
9749         * d-valprint.c: Sort headers.
9750         * d-namespace.c: Sort headers.
9751         * d-lang.c: Sort headers.
9752         * ctf.c: Sort headers.
9753         * csky-tdep.c: Sort headers.
9754         * csky-linux-tdep.c: Sort headers.
9755         * cris-tdep.c: Sort headers.
9756         * cris-linux-tdep.c: Sort headers.
9757         * cp-valprint.c: Sort headers.
9758         * cp-support.c: Sort headers.
9759         * cp-namespace.c: Sort headers.
9760         * cp-abi.c: Sort headers.
9761         * corelow.c: Sort headers.
9762         * corefile.c: Sort headers.
9763         * continuations.c: Sort headers.
9764         * completer.h: Sort headers.
9765         * completer.c: Sort headers.
9766         * complaints.c: Sort headers.
9767         * coffread.c: Sort headers.
9768         * coff-pe-read.c: Sort headers.
9769         * cli-out.h: Sort headers.
9770         * cli-out.c: Sort headers.
9771         * charset.c: Sort headers.
9772         * c-varobj.c: Sort headers.
9773         * c-valprint.c: Sort headers.
9774         * c-typeprint.c: Sort headers.
9775         * c-lang.c: Sort headers.
9776         * buildsym.c: Sort headers.
9777         * buildsym-legacy.c: Sort headers.
9778         * build-id.h: Sort headers.
9779         * build-id.c: Sort headers.
9780         * btrace.c: Sort headers.
9781         * bsd-uthread.c: Sort headers.
9782         * breakpoint.h: Sort headers.
9783         * breakpoint.c: Sort headers.
9784         * break-catch-throw.c: Sort headers.
9785         * break-catch-syscall.c: Sort headers.
9786         * break-catch-sig.c: Sort headers.
9787         * blockframe.c: Sort headers.
9788         * block.c: Sort headers.
9789         * bfin-tdep.c: Sort headers.
9790         * bfin-linux-tdep.c: Sort headers.
9791         * bfd-target.c: Sort headers.
9792         * bcache.c: Sort headers.
9793         * ax-general.c: Sort headers.
9794         * ax-gdb.h: Sort headers.
9795         * ax-gdb.c: Sort headers.
9796         * avr-tdep.c: Sort headers.
9797         * auxv.c: Sort headers.
9798         * auto-load.c: Sort headers.
9799         * arm-wince-tdep.c: Sort headers.
9800         * arm-tdep.c: Sort headers.
9801         * arm-symbian-tdep.c: Sort headers.
9802         * arm-pikeos-tdep.c: Sort headers.
9803         * arm-obsd-tdep.c: Sort headers.
9804         * arm-nbsd-tdep.c: Sort headers.
9805         * arm-nbsd-nat.c: Sort headers.
9806         * arm-linux-tdep.c: Sort headers.
9807         * arm-linux-nat.c: Sort headers.
9808         * arm-fbsd-tdep.c: Sort headers.
9809         * arm-fbsd-nat.c: Sort headers.
9810         * arm-bsd-tdep.c: Sort headers.
9811         * arch-utils.c: Sort headers.
9812         * arc-tdep.c: Sort headers.
9813         * arc-newlib-tdep.c: Sort headers.
9814         * annotate.h: Sort headers.
9815         * annotate.c: Sort headers.
9816         * amd64-windows-tdep.c: Sort headers.
9817         * amd64-windows-nat.c: Sort headers.
9818         * amd64-tdep.c: Sort headers.
9819         * amd64-sol2-tdep.c: Sort headers.
9820         * amd64-obsd-tdep.c: Sort headers.
9821         * amd64-obsd-nat.c: Sort headers.
9822         * amd64-nbsd-tdep.c: Sort headers.
9823         * amd64-nbsd-nat.c: Sort headers.
9824         * amd64-nat.c: Sort headers.
9825         * amd64-linux-tdep.c: Sort headers.
9826         * amd64-linux-nat.c: Sort headers.
9827         * amd64-fbsd-tdep.c: Sort headers.
9828         * amd64-fbsd-nat.c: Sort headers.
9829         * amd64-dicos-tdep.c: Sort headers.
9830         * amd64-darwin-tdep.c: Sort headers.
9831         * amd64-bsd-nat.c: Sort headers.
9832         * alpha-tdep.c: Sort headers.
9833         * alpha-obsd-tdep.c: Sort headers.
9834         * alpha-nbsd-tdep.c: Sort headers.
9835         * alpha-mdebug-tdep.c: Sort headers.
9836         * alpha-linux-tdep.c: Sort headers.
9837         * alpha-linux-nat.c: Sort headers.
9838         * alpha-bsd-tdep.c: Sort headers.
9839         * alpha-bsd-nat.c: Sort headers.
9840         * aix-thread.c: Sort headers.
9841         * agent.c: Sort headers.
9842         * addrmap.c: Sort headers.
9843         * ada-varobj.c: Sort headers.
9844         * ada-valprint.c: Sort headers.
9845         * ada-typeprint.c: Sort headers.
9846         * ada-tasks.c: Sort headers.
9847         * ada-lang.c: Sort headers.
9848         * aarch64-tdep.c: Sort headers.
9849         * aarch64-ravenscar-thread.c: Sort headers.
9850         * aarch64-newlib-tdep.c: Sort headers.
9851         * aarch64-linux-tdep.c: Sort headers.
9852         * aarch64-linux-nat.c: Sort headers.
9853         * aarch64-fbsd-tdep.c: Sort headers.
9854         * aarch64-fbsd-nat.c: Sort headers.
9855         * aarch32-linux-nat.c: Sort headers.
9856
9857 2019-04-04  Tom Tromey  <tom@tromey.com>
9858
9859         * varobj.c (varobj_create): Update.
9860         * rust-exp.y (struct rust_parser) <update_innermost_block,
9861         lookup_symbol>: New methods.
9862         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9863         Rename.
9864         (rust_parser::rust_lookup_type)
9865         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9866         * printcmd.c (display_command, do_one_display): Update.
9867         * parser-defs.h (struct parser_state) <parser_state>: Add
9868         "tracker" parameter.
9869         (block_tracker): New member.
9870         (class innermost_block_tracker) <innermost_block_tracker>: Add
9871         "types" parameter.
9872         <reset>: Remove method.
9873         (innermost_block): Don't declare.
9874         (null_post_parser): Update.
9875         * parse.c (innermost_block): Remove global.
9876         (write_dollar_variable): Update.
9877         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9878         Remove "tracker_types" parameter.
9879         (parse_expression): Add "tracker" parameter.
9880         (parse_expression_for_completion): Update.
9881         (null_post_parser): Add "tracker" parameter.
9882         * p-exp.y: Update rules.
9883         * m2-exp.y: Update rules.
9884         * language.h (struct language_defn) <la_post_parser>: Add
9885         "tracker" parameter.
9886         * go-exp.y: Update rules.
9887         * f-exp.y: Update rules.
9888         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9889         parameter.
9890         * d-exp.y: Update rules.
9891         * c-exp.y: Update rules.
9892         * breakpoint.c (set_breakpoint_condition): Create an
9893         innermost_block_tracker.
9894         (watch_command_1): Likewise.
9895         * ada-lang.c (resolve): Add "tracker" parameter.
9896         (resolve_subexp): Likewise.
9897         * ada-exp.y (write_var_from_sym): Update.
9898
9899 2019-04-04  Tom Tromey  <tom@tromey.com>
9900
9901         * type-stack.h: New file.
9902         * type-stack.c: New file.
9903         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9904         type-stack.h.
9905         (insert_into_type_stack, insert_type, push_type, push_type_int)
9906         (insert_type_address_space, pop_type, pop_type_int)
9907         (pop_typelist, pop_type_stack, append_type_stack)
9908         (push_type_stack, get_type_stack, push_typelist)
9909         (follow_type_instance_flags, follow_types): Don't declare.
9910         * parse.c (type_stack): Remove global.
9911         (parse_exp_in_context): Update.
9912         (insert_into_type_stack, insert_type, push_type, push_type_int)
9913         (insert_type_address_space, pop_type, pop_type_int)
9914         (pop_typelist, pop_type_stack, append_type_stack)
9915         (push_type_stack, get_type_stack, push_typelist)
9916         (follow_type_instance_flags, follow_types): Remove (moved to
9917         type-stack.c).
9918         * f-exp.y (type_stack): New global.
9919         Update rules.
9920         (push_kind_type, f_parse): Update.
9921         * d-exp.y (type_stack): New global.
9922         Update rules.
9923         (d_parse): Update.
9924         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9925         Update rules.
9926         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9927         (HFILES_NO_SRCDIR): Add type-stack.h.
9928
9929 2019-04-04  Tom Tromey  <tom@tromey.com>
9930
9931         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9932         (rust_parser::convert_ast_to_expression, rust_parse)
9933         (rust_lex_test_completion, rust_lex_tests): Update.
9934         * parser-defs.h (struct expr_completion_state): New.
9935         (struct parser_state) <parser_state>: Add completion parameter.
9936         <mark_struct_expression, mark_completion_tag>: New methods.
9937         <parse_completion, m_completion_state>: New members.
9938         (prefixify_expression, null_post_parser): Update.
9939         (mark_struct_expression, mark_completion_tag): Don't declare.
9940         * parse.c (parse_completion, expout_last_struct)
9941         (expout_tag_completion_type, expout_completion_name): Remove
9942         globals.
9943         (parser_state::mark_struct_expression)
9944         (parser_state::mark_completion_tag): Now methods.
9945         (prefixify_expression): Add last_struct parameter.
9946         (prefixify_subexp): Likewise.
9947         (parse_exp_1): Update.
9948         (parse_exp_in_context): Add cstate parameter.  Update.
9949         (parse_expression_for_completion): Create an
9950         expr_completion_state.
9951         (null_post_parser): Add "completion" parameter.
9952         * p-exp.y: Update rules.
9953         (yylex): Update.
9954         * language.h (struct language_defn) <la_post_parser>: Add
9955         "completing" parameter.
9956         * go-exp.y: Update rules.
9957         (lex_one_token): Update.
9958         * expression.h (parse_completion): Don't declare.
9959         * d-exp.y: Update rules.
9960         (lex_one_token): Update rules.
9961         * c-exp.y: Update rules.
9962         (lex_one_token): Update.
9963         * ada-lang.c (resolve): Add "parse_completion" parameter.
9964         (resolve_subexp): Likewise.
9965         (ada_resolve_function): Likewise.
9966
9967 2019-04-04  Tom Tromey  <tom@tromey.com>
9968
9969         * parser-defs.h (struct parser_state) <start_arglist,
9970         end_arglist>: New methods.
9971         <arglist_len, m_funcall_chain>: New members.
9972         (arglist_len, start_arglist, end_arglist): Don't declare.
9973         * parse.c (arglist_len, funcall_chain): Remove global.
9974         (start_arglist, end_arglist): Remove functions.
9975         (parse_exp_in_context): Update.
9976         * p-exp.y: Update rules.
9977         * m2-exp.y: Update rules.
9978         * go-exp.y: Update rules.
9979         * f-exp.y: Update rules.
9980         * d-exp.y: Update rules.
9981         * c-exp.y: Update rules.
9982
9983 2019-04-04  Tom Tromey  <tom@tromey.com>
9984
9985         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9986         lex_operator, push_back>: New methods.
9987         Update all rules.
9988         (rust_parser::lex_hex, lex_escape): Rename and update.
9989         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9990         (rust_parser::lex_operator): Rename and update.
9991         (rust_parser::lex_number, rustyylex, rustyyerror)
9992         (rust_lex_test_init, rust_lex_test_sequence)
9993         (rust_lex_test_push_back, rust_lex_tests): Update.
9994         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9995         parameter.
9996         <lexptr, prev_lexptr>: New members.
9997         (lexptr, prev_lexptr): Don't declare.
9998         * parse.c (lexptr, prev_lexptr): Remove globals.
9999         (parse_exp_in_context): Update.
10000         * p-exp.y (yylex, yyerror): Update.
10001         * m2-exp.y (parse_number, yylex, yyerror): Update.
10002         * go-exp.y (lex_one_token, yyerror): Update.
10003         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10004         * d-exp.y (lex_one_token, yyerror): Update.
10005         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10006         (lex_one_token, yyerror): Update.
10007         * ada-lex.l (YY_INPUT): Update.
10008         (rewind_to_char): Update.
10009         * ada-exp.y (yyerror): Update.
10010
10011 2019-04-04  Tom Tromey  <tom@tromey.com>
10012
10013         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10014         * parser-defs.h (struct parser_state) <parser_state>: Add new
10015         parameter.
10016         <comma_terminates>: New member.
10017         (comma_terminates): Don't declare global.
10018         * parse.c (comma_terminates): Remove global.
10019         (parse_exp_in_context): Update.
10020         * p-exp.y (yylex): Update.
10021         * m2-exp.y (yylex): Update.
10022         * go-exp.y (lex_one_token): Update.
10023         * f-exp.y (yylex): Update.
10024         * d-exp.y (lex_one_token): Update.
10025         * c-exp.y (lex_one_token): Update.
10026         * ada-lex.l: Update.
10027
10028 2019-04-04  Tom Tromey  <tom@tromey.com>
10029
10030         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10031         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10032         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10033         * parser-defs.h (paren_depth): Don't declare.
10034         * parse.c (paren_depth): Remove global.
10035         (parse_exp_in_context): Update.
10036         * p-exp.y (paren_depth): New global.
10037         (pascal_parse): Initialize it.
10038         * m2-exp.y (paren_depth): New global.
10039         (m2_parse): Initialize it.
10040         * go-exp.y (paren_depth): New global.
10041         (go_parse): Initialize it.
10042         * f-exp.y (paren_depth): New global.
10043         (f_parse): Initialize it.
10044         * d-exp.y (paren_depth): New global.
10045         (d_parse): Initialize it.
10046         * c-exp.y (paren_depth): New global.
10047         (c_parse): Initialize it.
10048         * ada-lex.l (paren_depth): New global.
10049         (lexer_init): Initialize it.
10050
10051 2019-04-04  Tom Tromey  <tom@tromey.com>
10052
10053         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10054         (rust_parser::convert_ast_to_type)
10055         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10056         * parser-defs.h (struct parser_state) <parser_state>: Add
10057         parameters.  Initialize new members.
10058         <expression_context_block, expression_context_pc>: New members.
10059         * parse.c (expression_context_block, expression_context_pc):
10060         Remove globals.
10061         (parse_exp_in_context): Update.
10062         * p-exp.y: Update all rules.
10063         (yylex): Update.
10064         * m2-exp.y: Update all rules.
10065         (yylex): Update.
10066         * go-exp.y (yylex): Update.
10067         * f-exp.y (yylex): Update.
10068         * d-exp.y: Update all rules.
10069         (yylex): Update.
10070         * c-exp.y: Update all rules.
10071         (lex_one_token, classify_name, yylex, c_parse): Update.
10072         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10073
10074 2019-04-04  Tom Tromey  <tom@tromey.com>
10075
10076         * gdbarch.h, gdbarch.c: Rebuild.
10077         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10078         * stap-probe.h:
10079         (struct stap_parse_info): Replace "parser_state" with
10080         "expr_builder".
10081         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10082         (parser_state): New class.
10083         * parse.c (expr_builder): Rename.
10084         (expr_builder::release): Rename.
10085         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10086         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10087         (write_exp_elt_longcst, write_exp_elt_floatcst)
10088         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10089         (write_exp_string_vector, write_exp_bitstring)
10090         (write_exp_msymbol, mark_struct_expression)
10091         (write_dollar_variable)
10092         (insert_type_address_space, increase_expout_size): Replace
10093         "parser_state" with "expr_builder".
10094         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10095         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10096         "parser_state" with "expr_builder".
10097
10098 2019-04-04  Tom Tromey  <tom@tromey.com>
10099
10100         * rust-exp.y: Replace "parse_language" with method call.
10101         * p-exp.y:
10102         (yylex): Replace "parse_language" with method call.
10103         * m2-exp.y:
10104         (yylex): Replace "parse_language" with method call.
10105         * go-exp.y (classify_name): Replace "parse_language" with method
10106         call.
10107         * f-exp.y (yylex): Replace "parse_language" with method call.
10108         * d-exp.y (lex_one_token): Replace "parse_language" with method
10109         call.
10110         * c-exp.y:
10111         (lex_one_token, classify_name, yylex): Replace "parse_language"
10112         with method call.
10113         * ada-exp.y (find_primitive_type, type_char)
10114         (type_system_address): Replace "parse_language" with method call.
10115
10116 2019-04-04  Tom Tromey  <tom@tromey.com>
10117
10118         * rust-exp.y: Replace "parse_gdbarch" with method call.
10119         * parse.c (write_dollar_variable, insert_type_address_space):
10120         Replace "parse_gdbarch" with method call.
10121         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10122         call.
10123         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10124         call.
10125         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10126         "parse_gdbarch" with method call.
10127         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10128         with method call.
10129         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10130         "parse_gdbarch" with method call.
10131         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10132         "parse_gdbarch" with method call.
10133         * c-exp.y (parse_type, parse_number, classify_name): Replace
10134         "parse_gdbarch" with method call.
10135         * ada-lex.l: Replace "parse_gdbarch" with method call.
10136         * ada-exp.y (parse_type, find_primitive_type, type_char)
10137         (type_system_address): Replace "parse_gdbarch" with method call.
10138
10139 2019-04-04  Tom Tromey  <tom@tromey.com>
10140
10141         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10142         * stap-probe.c (stap_parse_argument): Update.
10143         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10144         initial_size parameter.
10145         * rust-exp.y (rust_lex_tests): Update.
10146         * parse.c (parser_state): Update.
10147         (parse_exp_in_context): Update.
10148         * parser-defs.h (struct parser_state) <parser_state>: Remove
10149         "initial_size" parameter.
10150
10151 2019-04-04  Tom Tromey  <tom@tromey.com>
10152
10153         * parser-defs.h (increase_expout_size): Don't declare.
10154         * parse.c (increase_expout_size): Now static.
10155
10156 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10157
10158         * gnu-nat.c (gnu_nat_target::wait): Fix
10159         target_waitstatus_to_string call.
10160
10161 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10162
10163         * eval.c (evaluate_subexp_standard): Handle internal functions
10164         during Fortran function call handling.
10165
10166 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10167
10168         * NEWS: Mention new internal functions.
10169         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10170         (read_base_type): Use dwarf2_init_complex_target_type.
10171         * value.c (creal_internal_fn): New function.
10172         (cimag_internal_fn): New function.
10173         (_initialize_values): Register new internal functions.
10174
10175 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10176
10177         * infrun.c (stop_all_threads): If debug_infrun, always
10178         trace the wait status after wait_one, using
10179         target_waitstatus_to_string and target_pid_to_str.
10180         (handle_inferior_event): Replace various trace of
10181         wait status kind by a single trace.
10182         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10183         wait status kind image by target_waitstatus_to_string.
10184         * target/waitstatus.c (target_waitstatus_to_string): Fix
10185         obsolete comment.
10186
10187 2019-04-01  Tom Tromey  <tromey@adacore.com>
10188
10189         PR symtab/23331:
10190         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10191
10192 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10193             Pedro Alves  <palves@redhat.com>
10194
10195         * top.c (quit_force): Call 'finalize_values'.
10196         * value.c (finalize_values): New function.
10197         * value.h (finalize_values): Declare.
10198
10199 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10200
10201         * NEWS: Announce $_gdb_major and $_gdb_minor.
10202
10203         * top.c (init_gdb_version_vars): New function.
10204         (gdb_init): Call init_gdb_version_vars.
10205
10206 2019-03-29  Tom Tromey  <tromey@adacore.com>
10207
10208         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10209         help text.  Remove dead code.
10210
10211 2019-03-29  Keith Seitz  <keiths@redhat.com>
10212
10213         From Siddhesh Poyarekar:
10214         * f-lang.h (f77_get_upperbound): Return LONGEST.
10215         (f77_get_lowerbound): Likewise.
10216         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10217         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10218         print them.
10219         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10220         plongest to format print it.
10221         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10222         (f77_get_upperbound): Likewise.
10223         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10224         LOWER_BOUND to LONGEST.
10225         (f77_create_arrayprint_offset_tbl): Likewise.
10226
10227 2019-03-29  Keith Seitz  <keiths@redhat.com>
10228
10229         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10230         %s/pulongest for TYPE_LENGTH instead of %d in format
10231         strings.
10232         * ada-typerint.c (ada_print_type): Likewise.
10233         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10234         * compile/compile-c-support.c (generate_register_struct): Likewise.
10235         * gdbtypes.c (recursive_dump_type): Likewise.
10236         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10237         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10238         instead of %d in format strings.
10239         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10240         to std::min to ULONGEST.
10241         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10242         instead of %d in format strings.
10243         * tracepoint.c (info_scope_command): Likewise.
10244         * typeprint.c (print_offset_data::update)
10245         (print_offset_data::finish): Likewise.
10246         * xtensa-tdep.c (xtensa_store_return_value)
10247         (xtensa_push_dummy_call): Likewise.
10248
10249 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10250
10251         * windows-nat.c (display_selector): Fixed format specifications
10252         for 64-bit Cygwin.
10253
10254 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10255
10256         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10257
10258 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10259
10260         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10261         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10262         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10263         (nios2_linux_init_abi): Install it.
10264
10265 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10266
10267         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10268
10269 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10270
10271         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10272
10273 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10274             Tom Tromey  <tromey@adacore.com>
10275
10276         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10277
10278 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10279
10280         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10281         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10282         method to compute the bounds of range types. Also print "[evaluated]"
10283         if the bounds' values come from a dynamic evaluation.
10284
10285 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10286
10287         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10288         whitespace when pretty printing is on.
10289
10290 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10291
10292         * ppc-linux-nat.c: Add include.
10293
10294 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10295
10296         * NEWS: Mention AArch64 Pointer Authentication.
10297
10298 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10299
10300         * arm-linux-nat.c: Add include.
10301
10302 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10303
10304         * source-cache.c (source_cache::get_source_lines): Re-read
10305         fullname after calling open_source_file.
10306
10307 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10308
10309         * NEWS: Mention TLS support for FreeBSD.
10310
10311 2019-03-25  Tom Tromey  <tromey@adacore.com>
10312
10313         * minsyms.c (BUNCH_SIZE): Update comment.
10314         (~minimal_symbol_reader): Remove old comment.
10315         (compact_minimal_symbols): Update comment.
10316         (minimal_symbol_reader::install): Remove old comment.  Update
10317         other comments.
10318
10319 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10320
10321         * s390-linux-nat.c: Add include.
10322
10323 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10324
10325         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10326         Call linux_get_hwcap.
10327         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10328         Likewise.
10329         (aarch64_linux_get_hwcap): Remove function.
10330         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10331         declaration.
10332         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10333         linux_get_hwcap.
10334         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10335         * linux-tdep.c (linux_get_hwcap): Add function.
10336         (linux_get_hwcap2): Likewise.
10337         * linux-tdep.h (linux_get_hwcap): Add declaration.
10338         (linux_get_hwcap2): Likewise.
10339         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10340         (ppc_linux_get_hwcap2): Likewise.
10341         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10342         linux_get_hwcap.
10343         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10344         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10345         (ppc_linux_nat_target::read_description): Likewise.
10346         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10347         * s390-linux-nat.c: Likewise.
10348         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10349
10350 2019-03-24  Tom Tromey  <tom@tromey.com>
10351
10352         * ada-lang.c (standard_lookup): Simplify initialization.
10353         (ada_lookup_symbol_nonlocal): Simplify return.
10354         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10355         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10356         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10357         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10358         initialization.
10359         * solib.c (solib_global_lookup): Simplify.
10360         * symtab.c (null_block_symbol): Remove.
10361         (symbol_cache_lookup): Simplify returns.
10362         (lookup_language_this): Simplify returns.
10363         (lookup_symbol_aux): Simplify return.
10364         (lookup_local_symbol): Simplify returns.
10365         (lookup_global_symbol_from_objfile): Simplify return.
10366         (lookup_symbol_in_objfile_symtabs)
10367         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10368         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10369         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10370         * cp-namespace.c (cp_lookup_bare_symbol)
10371         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10372         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10373         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10374         (cp_lookup_symbol_via_imports): Simplify initialization.
10375         (find_symbol_in_baseclass): Likewise.
10376         * symtab.h (null_block_symbol): Remove.
10377         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10378         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10379         (d_lookup_symbol_module): Likewise.
10380         (find_symbol_in_baseclass): Simplify initialization.
10381
10382 2019-03-24  Tom Tromey  <tom@tromey.com>
10383
10384         * expression.h: Don't include symtab.h.
10385         (struct block): Forward declare.
10386
10387 2019-03-24  Tom Tromey  <tom@tromey.com>
10388
10389         * c-exp.y (typebase): Remove casts.
10390         * gdbtypes.c (lookup_unsigned_typename, )
10391         (lookup_signed_typename): Remove cast.
10392         * eval.c (parse_to_comma_and_eval): Remove cast.
10393         * parse.c (write_dollar_variable): Remove cast.
10394         * block.h (struct block) <superblock>: Now const.
10395         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10396         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10397         (map_block): Make "block" const.
10398         * symfile.h (struct quick_symbol_functions)
10399         <map_matching_symbols>: Constify block argument to "callback".
10400         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10401         const.
10402         (find_pc_sect_compunit_symtab): Make "b" const.
10403         (find_symbol_at_address): Likewise.
10404         (search_symbols): Likewise.
10405         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10406         (dw2_debug_names_lookup_symbol): Likewise.
10407         (dw2_map_matching_symbols): Update.
10408         * p-valprint.c (pascal_val_print): Remove "block".
10409         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10410         (aux_add_nonlocal_symbols): Make "block" const.
10411         (resolve_subexp): Remove cast.
10412         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10413         const.
10414         (iterate_over_file_blocks): Likewise.
10415         * f-exp.y (%union) <bval>: Remove.
10416         * coffread.c (patch_opaque_types): Make "b" const.
10417         * spu-tdep.c (spu_catch_start): Make "block" const.
10418         * c-valprint.c (print_unpacked_pointer): Remove "block".
10419         * symmisc.c (dump_symtab_1): Make "b" const.
10420         (block_depth): Make "block" const.
10421         * d-exp.y (%union) <bval>: Remove.
10422         * cp-support.h (cp_lookup_rtti_type): Update.
10423         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10424         * psymtab.c (psym_lookup_symbol): Make "block" const.
10425         (maintenance_check_psymtabs): Make "b" const.
10426         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10427         (enumerate_locals, enumerate_args): Update.
10428         * python/py-symtab.c (stpy_global_block): Make "block" const.
10429         (stpy_static_block): Likewise.
10430         * inline-frame.c (block_starting_point_at): Make "new_block"
10431         const.
10432         * block.c (find_block_in_blockvector): Make return type const.
10433         (blockvector_for_pc_sect): Make "b" const.
10434         (find_block_in_blockvector): Make "b" const.
10435
10436 2019-03-23  Tom Tromey  <tom@tromey.com>
10437
10438         * varobj.c (varobj_create): Update.
10439         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10440         * printcmd.c (display_command, do_one_display): Don't reset
10441         innermost_block.
10442         * parser-defs.h (enum innermost_block_tracker_type): Move to
10443         expression.h.
10444         (innermost_block): Update comment.
10445         * parse.c (parse_exp_1): Add tracker_types parameter.
10446         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10447         tracker_types parameter.  Reset innermost_block.
10448         (parse_exp_in_context): Remove.
10449         (parse_expression_for_completion): Update.
10450         * objfiles.c (~objfile): Don't reset expression_context_block or
10451         innermost_block.
10452         * expression.h (enum innermost_block_tracker_type): Move from
10453         parser-defs.h.
10454         (parse_exp_1): Add tracker_types parameter.
10455         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10456         reset innermost_block.
10457
10458 2019-03-23  Tom Tromey  <tom@tromey.com>
10459
10460         * objfiles.h: Include bcache.h.
10461
10462 2019-03-23  Tom Tromey  <tom@tromey.com>
10463
10464         * linespec.c (get_current_search_block): Use
10465         scoped_restore_current_language.
10466         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10467
10468 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10469             Jiong Wang  <jiong.wang@arm.com>
10470
10471         * aarch64-linux-tdep.c
10472         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10473         section.
10474         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10475
10476 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10477             Jiong Wang  <jiong.wang@arm.com>
10478
10479         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10480         instructions.
10481         (aarch64_analyze_prologue_test): Add PACIASP test.
10482         (aarch64_prologue_prev_register): Unmask PC value.
10483
10484 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10485             Jiong Wang  <jiong.wang@arm.com>
10486
10487         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10488         (aarch64_dwarf2_prev_register): Unmask PC value.
10489         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10490         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10491         DW_CFA_AARCH64_negate_ra_state.
10492         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10493
10494 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10495             Jiong Wang  <jiong.wang@arm.com>
10496
10497         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10498         registers.
10499         (aarch64_pseudo_register_name): Likewise.
10500         (aarch64_pseudo_register_type): Likewise.
10501         (aarch64_pseudo_register_reggroup_p): Likewise.
10502         (aarch64_gdbarch_init): Add pauth registers.
10503         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10504         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10505         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10506         (struct gdbarch_tdep): Add regnum for ra_state.
10507
10508 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10509             Jiong Wang  <jiong.wang@arm.com>
10510
10511         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10512
10513 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10514             Jiong Wang  <jiong.wang@arm.com>
10515
10516         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10517         function.
10518         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10519         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10520         (aarch64_gdbarch_init): Add puth registers.
10521         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10522         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10523         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10524
10525 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10526             Jiong Wang  <jiong.wang@arm.com>
10527
10528         * aarch64-linux-nat.c
10529         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10530         * aarch64-linux-tdep.c
10531         (aarch64_linux_core_read_description): Likewise.
10532         (aarch64_linux_get_hwcap): New function.
10533         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10534         (aarch64_linux_get_hwcap): New declaration.
10535
10536 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10537             Jiong Wang  <jiong.wang@arm.com>
10538
10539         * aarch64-linux-nat.c
10540         (aarch64_linux_nat_target::read_description): Add pauth param.
10541         * aarch64-linux-tdep.c
10542         (aarch64_linux_core_read_description): Likewise.
10543         * aarch64-tdep.c (struct target_desc): Add in pauth.
10544         (aarch64_read_description): Add pauth param.
10545         (aarch64_gdbarch_init): Likewise.
10546         * aarch64-tdep.h (aarch64_read_description): Likewise.
10547         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10548         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10549         * features/Makefile: Add new files.
10550         * features/aarch64-pauth.c: New file.
10551         * features/aarch64-pauth.xml: New file.
10552
10553 2019-03-20  Tom Tromey  <tromey@adacore.com>
10554
10555         * infrun.c (handle_inferior_event): Rename from
10556         handle_inferior_event_1.  Create a scoped_value_mark.
10557         (handle_inferior_event): Remove.
10558
10559 2019-03-19  Tom Tromey  <tromey@adacore.com>
10560
10561         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10562         * infrun.h (print_stop_event): Add "displays" parameter.
10563         * infrun.c (print_stop_event): Add "displays" parameter.
10564
10565 2019-03-19  Pedro Alves  <palves@redhat.com>
10566
10567         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10568         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10569         to -1.  Fix TABs vs spaces.
10570         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10571         * tui/tui-out.h (tui_ui_out) Add intro comments.
10572         <m_line, m_start_of_line>: In-class initialize, and add describing
10573         comment.
10574
10575 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10576
10577         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10578         variable names.
10579         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10580
10581 2019-03-18  Pedro Alves  <palves@redhat.com>
10582             Eli Zaretskii <eliz@gnu.org>
10583
10584         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10585         m_line and m_start_of_line.
10586
10587 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10588
10589         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10590         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10591         it returns a newline.  This fixes a regression in TU mode, whereby
10592         the next line is output on the same screen line as the user input.
10593
10594 2019-03-18  Tom Tromey  <tromey@adacore.com>
10595
10596         * minsyms.c (minimal_symbol_reader::install): Remove call to
10597         obstack_blank.
10598
10599 2019-03-18  Pedro Alves  <palves@redhat.com>
10600
10601         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10602         New globals.
10603         (apply_style): New, factored out from ...
10604         (apply_ansi_escape): ... this.  Handle reverse video mode.
10605         (tui_set_reverse_mode): New function.
10606         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10607         * tui/tui-winsource.c (tui_show_source_line): Use
10608         tui_set_reverse_mode instead of setting A_STANDOUT.
10609         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10610         New setter methods.
10611
10612 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10613
10614         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10615         Handle tabs.
10616
10617 2019-03-18  Tom Tromey  <tromey@adacore.com>
10618
10619         * ada-lang.c (empty_array): Add "high" parameter.
10620         (ada_evaluate_subexp): Update.
10621
10622 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10623
10624         * unittests/string_view-selftests.c: Define
10625         _initialize_string_view_selftests unconditionally.
10626
10627 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10628
10629         PR gdb/24350
10630         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10631
10632 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10633
10634         PR gdb/24351
10635         * windows-nat.c (display_selector): Fix format specifiers.
10636
10637 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10638
10639         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10640         tui_refill_source_window instead of tui_refresh_win, to update the
10641         current execution line.  This fixes redisplay of the current line
10642         when stepping through the code with "next" or "step".
10643
10644 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10645
10646         * source-cache.c (source_cache::get_source_lines): Call
10647         find_source_lines to initialize s->nlines.  This fixes vertical
10648         scrolling of TUI source window when the DOWN arrow is pressed.
10649
10650 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10651
10652         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10653         linux-thread-db.c (_initialize_thread_db): Likewise.
10654
10655 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10656
10657         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10658         wclrtoeol in tui_show_source_line".  This reverts changes made in
10659         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10660
10661 2019-03-15  Tom Tromey  <tom@tromey.com>
10662
10663         * symtab.h (struct minimal_symbol): Derive from
10664         general_symbol_info.
10665         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10666         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10667         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10668         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10669         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10670         (MSYMBOL_SEARCH_NAME): Update.
10671         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10672         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10673         * minsyms.c (minimal_symbol_reader::record_full): Update.
10674
10675 2019-03-15  Tom Tromey  <tom@tromey.com>
10676
10677         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10678
10679 2019-03-15  Tom Tromey  <tom@tromey.com>
10680
10681         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10682         unique_xmalloc_ptr.
10683         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10684         Update.
10685         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10686         (build_minimal_symbol_hash_tables)
10687         (minimal_symbol_reader::install): Update.
10688
10689 2019-03-15  Tom Tromey  <tom@tromey.com>
10690
10691         * symtab.c (create_demangled_names_hash): Update.
10692         (symbol_set_names): Update.
10693         * objfiles.h (struct objfile_per_bfd_storage)
10694         <demangled_names_hash>: Now an htab_up.
10695         * objfiles.c (objfile_per_bfd_storage): Simplify.
10696
10697 2019-03-15  Tom Tromey  <tom@tromey.com>
10698
10699         * objfiles.h (struct objfile_per_bfd_storage): Declare
10700         destructor.
10701         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10702         New.
10703         (get_objfile_bfd_data): Use new.  Don't initialize
10704         language_of_main.
10705         (free_objfile_per_bfd_storage): Remove.
10706         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10707
10708 2019-03-15  Tom Tromey  <tom@tromey.com>
10709
10710         * symfile.c (reread_symbols): Update.
10711         * objfiles.c (objfile::objfile): Update.
10712         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10713         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10714         comment.
10715         (minimal_symbol_reader::install): Update.
10716         (terminate_minimal_symbol_table): Remove.
10717         * jit.c (jit_object_close_impl): Update.
10718
10719 2019-03-15  Tom Tromey  <tom@tromey.com>
10720
10721         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10722         initializations.
10723
10724 2019-03-15  Tom Tromey  <tom@tromey.com>
10725
10726         * objfiles.h (struct objfile_per_bfd_storage)
10727         <demangled_hash_languages>: Now a bitset.
10728         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10729         (lookup_minimal_symbol): Update.
10730
10731 2019-03-15  Tom Tromey  <tom@tromey.com>
10732
10733         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10734         Don't return the symbol.
10735         * coffread.c (record_minimal_symbol): Use record_full.
10736
10737 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10738
10739         The MS-Windows port of ncurses fails to switch to a color pair if
10740         one or both of the colors are the implicit default colors.  This
10741         change records the default colors when TUI is initialized, and
10742         then specifies them explicitly when a color pair uses the default
10743         colors.  This allows color styling in TUI mode on MS-Windows.
10744
10745         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10746         ncurses_norm_attr.
10747         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10748         colors in ncurses_norm_attr.
10749         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10750         "none", replace it with the default color recorded in
10751         ncurses_norm_attr.
10752
10753 2019-03-14  Tom Tromey  <tromey@adacore.com>
10754
10755         * source-cache.h (class source_cache) <get_source_lines>: Return
10756         std::string.
10757         * source-cache.c (source_cache::extract_lines): Handle case where
10758         first_pos==npos.  Return std::string.
10759         (source_cache::get_source_lines): Update.
10760
10761 2019-03-14  Tom Tromey  <tromey@adacore.com>
10762
10763         * NEWS: Add item for "style sources" commands.
10764         * source-cache.c (source_cache::get_source_lines): Check
10765         source_styling.
10766         * cli/cli-style.c (source_styling): New global.
10767         (_initialize_cli_style): Add "style sources" commands.
10768         (show_style_sources): New function.
10769         * cli/cli-style.h (source_styling): Declare.
10770
10771 2019-03-14  Pedro Alves  <palves@redhat.com>
10772             Tom Tromey  <tromey@adacore.com>
10773
10774         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10775         * tui/tui-winsource.c (tui_refill_source_window): New function,
10776         from...
10777         (tui_horizontal_source_scroll): ... here.  Move some logic.
10778         * cli/cli-style.c (set_style_enabled): Notify new observable.
10779         * tui/tui-hooks.c (tui_redisplay_source): New function.
10780         (tui_attach_detach_observers): Attach or detach
10781         tui_redisplay_source.
10782         * observable.h (source_styling_changed): New observable.
10783         * observable.c: Define source_styling_changed observable.
10784
10785 2019-03-13  Tom Tromey  <tromey@adacore.com>
10786
10787         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10788         (i386_gnu_nat_target::store_registers): Update.
10789         * target-debug.h (target_debug_print_std_string): New macro.
10790         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10791         * windows-tdep.c (display_one_tib): Update.
10792         * tui/tui-stack.c (tui_make_status_line): Update.
10793         * top.c (print_inferior_quit_action): Update.
10794         * thread.c (thr_try_catch_cmd): Update.
10795         (add_thread_with_info): Update.
10796         (thread_target_id_str): Update.
10797         (thr_try_catch_cmd): Update.
10798         (thread_command): Update.
10799         (thread_find_command): Update.
10800         * record-btrace.c (record_btrace_target::info_record)
10801         (record_btrace_resume_thread, record_btrace_target::resume)
10802         (record_btrace_cancel_resume, record_btrace_step_thread)
10803         (record_btrace_target::wait, record_btrace_target::wait)
10804         (record_btrace_target::wait, record_btrace_target::stop): Update.
10805         * progspace.c (print_program_space): Update.
10806         * process-stratum-target.c
10807         (process_stratum_target::thread_address_space): Update.
10808         * linux-fork.c (linux_fork_mourn_inferior)
10809         (detach_checkpoint_command, info_checkpoints_command)
10810         (linux_fork_context): Update.
10811         (linux_fork_detach): Update.
10812         (class scoped_switch_fork_info): Update.
10813         (delete_checkpoint_command): Update.
10814         * infrun.c (follow_fork_inferior): Update.
10815         (follow_fork_inferior): Update.
10816         (proceed_after_vfork_done): Update.
10817         (handle_vfork_child_exec_or_exit): Update.
10818         (follow_exec): Update.
10819         (displaced_step_prepare_throw): Update.
10820         (displaced_step_restore): Update.
10821         (start_step_over): Update.
10822         (resume_1): Update.
10823         (clear_proceed_status_thread): Update.
10824         (proceed): Update.
10825         (print_target_wait_results): Update.
10826         (do_target_wait): Update.
10827         (context_switch): Update.
10828         (stop_all_threads): Update.
10829         (restart_threads): Update.
10830         (finish_step_over): Update.
10831         (handle_signal_stop): Update.
10832         (switch_back_to_stepped_thread): Update.
10833         (keep_going_pass_signal): Update.
10834         (print_exited_reason): Update.
10835         (normal_stop): Update.
10836         * inferior.c (inferior_pid_to_str): Change return type.
10837         (print_selected_inferior): Update.
10838         (add_inferior): Update.
10839         (detach_inferior): Update.
10840         * dummy-frame.c (fprint_dummy_frames): Update.
10841         * dcache.c (dcache_info_1): Update.
10842         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10843         (btrace_fetch, btrace_clear): Update.
10844         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10845         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10846         type.
10847         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10848         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10849         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10850         * gdbarch.c, gdbarch.h: Rebuild.
10851         * gdbarch.sh (core_pid_to_str): Change return type.
10852         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10853         return type.
10854         (windows_nat_target::pid_to_str): Change return type.
10855         (windows_delete_thread): Update.
10856         (windows_nat_target::attach): Update.
10857         (windows_nat_target::files_info): Update.
10858         * target-delegates.c: Rebuild.
10859         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10860         return type.
10861         (sol_thread_target::pid_to_str): Change return type.
10862         * remote.c (class remote_target) <pid_to_str>: Change return
10863         type.
10864         (remote_target::pid_to_str): Change return type.
10865         (extended_remote_target::attach, remote_target::remote_stop_ns)
10866         (remote_target::remote_notif_remove_queued_reply)
10867         (remote_target::push_stop_reply, remote_target::disable_btrace):
10868         Update.
10869         (extended_remote_target::attach): Update.
10870         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10871         type.
10872         (gdbsim_target::pid_to_str): Change return type.
10873         * ravenscar-thread.c (struct ravenscar_thread_target)
10874         <pid_to_str>: Change return type.
10875         (ravenscar_thread_target::pid_to_str): Change return type.
10876         * procfs.c (class procfs_target) <pid_to_str>: Change return
10877         type.
10878         (procfs_target::pid_to_str): Change return type.
10879         (procfs_target::attach): Update.
10880         (procfs_target::detach): Update.
10881         (procfs_target::fetch_registers): Update.
10882         (procfs_target::store_registers): Update.
10883         (procfs_target::wait): Update.
10884         (procfs_target::files_info): Update.
10885         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10886         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10887         return type.
10888         (nto_procfs_target::pid_to_str): Change return type.
10889         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10890         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10891         return type.
10892         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10893         (exit_lwp): Update.
10894         (attach_proc_task_lwp_callback, get_detach_signal)
10895         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10896         (linux_nat_target::resume, wait_lwp, stop_callback)
10897         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10898         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10899         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10900         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10901         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10902         type.
10903         (inf_ptrace_target::attach): Update.
10904         (inf_ptrace_target::files_info): Update.
10905         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10906         type.
10907         (go32_nat_target::pid_to_str): Change return type.
10908         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10909         (gnu_nat_target::wait): Update.
10910         (gnu_nat_target::wait): Update.
10911         (gnu_nat_target::resume): Update.
10912         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10913         (fbsd_nat_target::wait): Update.
10914         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10915         type.
10916         (darwin_nat_target::attach): Update.
10917         * corelow.c (class core_target) <pid_to_str>: Change return type.
10918         (core_target::pid_to_str): Change return type.
10919         * target.c (normal_pid_to_str): Change return type.
10920         (default_pid_to_str): Likewise.
10921         (target_pid_to_str): Change return type.
10922         (target_translate_tls_address): Update.
10923         (target_announce_detach): Update.
10924         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10925         return type.
10926         (bsd_uthread_target::pid_to_str): Change return type.
10927         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10928         type.
10929         (bsd_kvm_target::pid_to_str): Change return type.
10930         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10931         return type.
10932         (aix_thread_target::pid_to_str): Change return type.
10933         * target.h (struct target_ops) <pid_to_str>: Change return type.
10934         (target_pid_to_str, normal_pid_to_str): Likewise.
10935         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10936         type.
10937         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10938         type.
10939         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10940         return type.
10941         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10942         type.
10943         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10944         type.
10945         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10946         return type.
10947
10948 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10949
10950         * NEWS: Mention that the new default MI version is 3.  Mention
10951         changes to the output of commands and events that deal with
10952         multi-location breakpoints.
10953         * breakpoint.c: Include "mi/mi-out.h".
10954         (print_one_breakpoint): Change output syntax if using MI version
10955         >= 3.
10956         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10957         New.
10958         (mi_multi_location_breakpoint_output_fixed): New.
10959         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10960         (mi_cmd_fix_multi_location_breakpoint_output): New.
10961         (mi_multi_location_breakpoint_output_fixed): New.
10962         * mi/mi-cmds.c (mi_cmds): Register command
10963         -fix-multi-location-breakpoint-output.
10964         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10965         interpreter "mi".
10966
10967 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10968
10969         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10970         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10971         instantiate mi_ui_out based on interpreter name.
10972         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10973         * mi/mi-main.c (mi_load_progress): Likewise.
10974
10975 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10976
10977         * NEWS: Combine separate "New targets" sections for 8.3.
10978
10979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10980
10981         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10982         (ppcfbsd_init_abi): Install gdbarch
10983         "fetch_tls_load_module_address" and "get_thread_local_address"
10984         methods.
10985
10986 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10987
10988         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10989         (riscv_fbsd_init_abi): Install gdbarch
10990         "fetch_tls_load_module_address" and "get_thread_local_address"
10991         methods.
10992
10993 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10994
10995         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10996         (i386fbsd_init_abi): Install gdbarch
10997         "fetch_tls_load_module_address" and "get_thread_local_address"
10998         methods.
10999
11000 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11001
11002         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11003         (amd64fbsd_init_abi): Install gdbarch
11004         "fetch_tls_load_module_address" and "get_thread_local_address"
11005         methods.
11006
11007 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11008
11009         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11010         (struct fbsd_pspace_data): New type.
11011         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11012         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11013         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11014         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11015         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11016
11017 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11018
11019         * gdbtypes.c (lookup_struct_elt): New function.
11020         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11021         * gdbtypes.h (struct struct_elt): New type.
11022         (lookup_struct_elt): New prototype.
11023
11024 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11025
11026         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11027         remove disabled code block.
11028
11029 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11030
11031         * gdbarch.sh (get_thread_local_address): New method.
11032         * gdbarch.h, gdbarch.c: Regenerate.
11033         * target.c (target_translate_tls_address): Use
11034         gdbarch_get_thread_local_address if present instead of
11035         target::get_thread_local_address.
11036
11037 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11038
11039         * target.h (target::get_thread_local_address): Update comment.
11040
11041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11042
11043         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11044         objfile->separate_debug_objfile_backlink if not NULL.
11045
11046 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11047
11048         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11049         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11050         (amd64bsd_store_inferior_registers): Likewise.
11051         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11052         Enable segment base registers.
11053         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11054         PT_GETFSBASE and PT_GETGSBASE.
11055         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11056         PT_SETGSBASE.
11057         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11058         segment base registers.
11059         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11060
11061 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11062
11063         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11064         Update calls to i386_target_description to add 'segments'
11065         parameter.
11066         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11067         add segment base registers.
11068         * arch/i386.c (i386_create_target_description): Add 'segments'
11069         parameter to enable segment base registers.
11070         * arch/i386.h (i386_create_target_description): Likewise.
11071         * features/i386/32bit-segments.xml: New file.
11072         * features/i386/32bit-segments.c: Generate.
11073         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11074         call to i386_target_description to add 'segments' parameter.
11075         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11076         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11077         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11078         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11079         if feature is present.
11080         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11081         Add 'segments' parameter to call to i386_target_description.
11082         (i386_target_description): Add 'segments' parameter to enable
11083         segment base registers.
11084         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11085         to call to i386_target_description.
11086         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11087         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11088         Define I386_NUM_REGS.
11089         (i386_target_description): Add 'segments' parameter to enable
11090         segment base registers.
11091
11092 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11093
11094         PR/24325
11095         * source-cache.c: #undef open and close, to avoid unresolved
11096         externals during linking.
11097
11098 2019-03-12  Tom Tromey  <tromey@adacore.com>
11099
11100         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11101         const.  Add initializers.
11102         (_initialize_remote): Don't initialize ptid globals.
11103
11104 2019-03-12  Pedro Alves  <palves@redhat.com>
11105
11106         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11107
11108 2019-03-12  Pedro Alves  <palves@redhat.com>
11109
11110         * cp-name-parser.y (main): Remove unused 'len' variable.
11111
11112 2019-03-12  Tom Tromey  <tromey@adacore.com>
11113
11114         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11115         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11116
11117 2019-03-12  Tom Tromey  <tromey@adacore.com>
11118
11119         * linux-nat.c (iterate_over_lwps): Update.
11120         (stop_callback): Remove parameter.
11121         (stop_wait_callback, detach_callback, resume_set_callback)
11122         (select_singlestep_lwp_callback, set_ignore_sigint)
11123         (status_callback, resumed_callback, resume_clear_callback)
11124         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11125         data parameter.
11126         (linux_nat_target::detach, linux_nat_target::resume)
11127         (linux_stop_and_wait_all_lwps, select_event_lwp)
11128         (linux_nat_filter_event, linux_nat_wait_1)
11129         (linux_nat_target::kill, linux_nat_target::stop)
11130         (linux_nat_target::stop): Update.
11131         (linux_nat_resume_callback): Change type.
11132         (resume_stopped_resumed_lwps, count_events_callback)
11133         (select_event_lwp_callback): Likewise.
11134         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11135         * arm-linux-nat.c (struct update_registers_data): Remove.
11136         (update_registers_callback): Change type.
11137         (arm_linux_insert_hw_breakpoint1): Update.
11138         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11139         parameter.
11140         (x86_linux_dr_set_addr): Update.
11141         (x86_linux_dr_set_control): Update.
11142         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11143         (iterate_over_lwps): Use gdb::function_view.
11144         * nat/aarch64-linux-hw-point.c (struct
11145         aarch64_dr_update_callback_param): Remove.
11146         (debug_reg_change_callback): Change type.
11147         (aarch64_notify_debug_reg_change): Update.
11148         * s390-linux-nat.c (s390_refresh_per_info): Update.
11149
11150 2019-03-11  Tom Tromey  <tromey@adacore.com>
11151
11152         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11153         redundant assignment to "this_cu".
11154
11155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11156
11157         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11158
11159 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11160
11161         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11162         from...
11163         (rank_one_type): ... this.
11164
11165 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11166
11167         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11168         from...
11169         (rank_one_type): ... this.
11170
11171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11172
11173         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11174         from...
11175         (rank_one_type): ... this.
11176
11177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11178
11179         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11180         from...
11181         (rank_one_type): ... this.
11182
11183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11184
11185         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11186         from...
11187         (rank_one_type): ... this.
11188
11189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11190
11191         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11192         from...
11193         (rank_one_type): ... this.
11194
11195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11196
11197         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11198         from...
11199         (rank_one_type): ... this.
11200
11201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11202
11203         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11204         from...
11205         (rank_one_type): ... this.
11206
11207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11208
11209         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11210         from...
11211         (rank_one_type): ... this.
11212
11213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11214
11215         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11216         from...
11217         (rank_one_type): ... this.
11218
11219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11220
11221         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11222         from...
11223         (rank_one_type): ... this.
11224
11225 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11226
11227         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11228         from...
11229         (rank_one_type): ... this.
11230
11231 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11232
11233         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11234         inferior-events' shows the example events.
11235
11236 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11237
11238         Support styling on native MS-Windows console
11239
11240         PR/24315
11241         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11242         on MS-Windows if $TERM is not defined.
11243
11244         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11245
11246         * posix-hdep.c (gdb_console_fputs):
11247         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11248         functions.
11249         * ui-file.h (gdb_console_fputs): Add prototype.
11250
11251         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11252         back to fputs only if the former returns zero.
11253
11254 2019-03-07  Tom Tromey  <tom@tromey.com>
11255
11256         * symmisc.c (print_symbol_bcache_statistics): Update.
11257         (print_objfile_statistics): Update.
11258         * symfile.c (allocate_symtab): Update.
11259         * stabsread.c: Don't include bcache.h.
11260         * psymtab.h (struct psymbol_bcache): Don't declare.
11261         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11262         (psymbol_bcache_init, psymbol_bcache_free)
11263         (psymbol_bcache_get_bcache): Don't declare.
11264         * psymtab.c (struct psymbol_bcache): Remove.
11265         (psymtab_storage::psymtab_storage): Update.
11266         (psymtab_storage::~psymtab_storage): Update.
11267         (psymbol_bcache_init, psymbol_bcache_free)
11268         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11269         (add_psymbol_to_bcache): Update.
11270         (allocate_psymtab): Update.
11271         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11272         macro_cache>: No longer pointers.
11273         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11274         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11275         * macrotab.c (macro_bcache): Update.
11276         * macroexp.c: Don't include bcache.h.
11277         * gdbtypes.c (check_types_worklist): Update.
11278         (types_deeply_equal): Remove TRY/CATCH.  Update.
11279         * elfread.c (elf_symtab_read): Update.
11280         * dwarf2read.c: Don't include bcache.h.
11281         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11282         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11283         (print_bcache_statistics, bcache_memory_used): Don't declare.
11284         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11285         methods.  Rename all data members.
11286         * bcache.c (struct bcache): Move to bcache.h.
11287         (bcache::expand_hash_table): Rename from expand_hash_table.
11288         (bcache): Remove.
11289         (bcache::insert): Rename from bcache_full.
11290         (bcache::compare): Rename from bcache_compare.
11291         (bcache_xmalloc): Remove.
11292         (bcache::~bcache): Rename from bcache_xfree.
11293         (bcache::print_statistics): Rename from print_bcache_statistics.
11294         (bcache::memory_used): Rename from bcache_memory_used.
11295
11296 2019-03-07  Pedro Alves  <palves@redhat.com>
11297
11298         * infrun.c (normal_stop): Also check for
11299         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11300
11301 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11302
11303         * f-lang.c (value_from_host_double): Moved to...
11304         * value.c (value_from_host_double): ...here.
11305         * value.h (value_from_host_double): Declare.
11306         * guile/scm-math.c (vlscm_convert_typed_number): Use
11307         value_from_host_double.
11308         (vlscm_convert_number): Likewise.
11309         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11310         * python/py-value.c (convert_value_from_python): Likewise.
11311
11312 2019-03-06  Tom Tromey  <tom@tromey.com>
11313
11314         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11315
11316 2019-03-06  Tom Tromey  <tom@tromey.com>
11317
11318         * utils.h (free_current_contents): Don't declare.
11319         * utils.c (free_current_contents): Remove.
11320
11321 2019-03-06  Tom Tromey  <tom@tromey.com>
11322
11323         * top.c (quit_force): Update.
11324         * main.c (captured_command_loop): Update.
11325         * common/new-op.c (operator new): Update.
11326         * common/common-exceptions.c (struct catcher)
11327         <save_cleanup_chain>: Remove member.
11328         (exceptions_state_mc_init): Update.
11329         (exception_try_scope_entry): Return nullptr.
11330         (exception_try_scope_exit, exception_rethrow)
11331         (throw_exception_sjlj, throw_exception_cxx): Update.
11332         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11333         (all_cleanups, do_cleanups, discard_cleanups)
11334         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11335         (restore_cleanups, restore_final_cleanups): Don't declare.
11336         (do_final_cleanups): Remove parameter.
11337         * common/cleanups.c (cleanup_chain, make_cleanup)
11338         (make_cleanup_dtor, all_cleanups, do_cleanups)
11339         (discard_my_cleanups, discard_cleanups)
11340         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11341         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11342         (null_cleanup): Remove.
11343         (do_final_cleanups): Remove parameter.
11344
11345 2019-03-06  Tom Tromey  <tom@tromey.com>
11346
11347         * remote.c (remote_target::remote_parse_stop_reply): Use
11348         unique_xmalloc_ptr.
11349
11350 2019-03-06  Tom Tromey  <tom@tromey.com>
11351
11352         * stabsread.c (struct stabs_field_info): Rename from field_info.
11353         <list, fnlist>: Add initializers.
11354         <obstack>: New member.
11355         (read_member_functions, read_struct_fields, read_baseclasses):
11356         Allocate on obstack.  Don't use cleanups.
11357         (read_one_struct_field, read_member_functions, read_struct_fields)
11358         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11359         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11360         (read_struct_type): Update.
11361
11362 2019-03-06  Tom Tromey  <tom@tromey.com>
11363
11364         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11365         * common/filestuff.h (make_cleanup_close): Don't declare.
11366         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11367         Remove.
11368
11369 2019-03-06  Tom Tromey  <tom@tromey.com>
11370
11371         * solib-aix.c: Use make_scope_exit.
11372
11373 2019-03-06  Tom Tromey  <tom@tromey.com>
11374
11375         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11376         Use make_scope_exit.
11377
11378 2019-03-06  Tom Tromey  <tom@tromey.com>
11379
11380         * solib-svr4.c (disable_probes_interface): Remove parameter.
11381         (svr4_handle_solib_event): Use make_scope_exit.
11382
11383 2019-03-06  Tom Tromey  <tom@tromey.com>
11384
11385         * remote.c (struct stop_reply_deleter): Remove.
11386         (stop_reply_up): Update.
11387         (struct stop_reply): Derive from notif_event.  Don't typedef.
11388         <regcache>: Now a std::vector.
11389         (stop_reply_xfree): Remove.
11390         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11391         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11392         (remote_target::discard_pending_stop_replies): Use delete.
11393         (remote_target::remote_parse_stop_reply): Update.
11394         (remote_target::process_stop_reply): Update.
11395         * remote-notif.h (struct notif_event): Add virtual destructor.
11396         Remove "dtr" member.
11397         (struct notif_client) <alloc_event>: Return a unique_ptr.
11398         (notif_event_xfree): Don't declare.
11399         (notif_event_up): New typedef.
11400         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11401         (notif_event_xfree, do_notif_event_xfree): Remove.
11402         (remote_notif_state_xfree): Update.
11403
11404 2019-03-06  Tom Tromey  <tom@tromey.com>
11405
11406         * infrun.c (displaced_step_clear_cleanup): Now a
11407         forward_scope_exit type.
11408         (displaced_step_prepare_throw): Update.
11409         (displaced_step_fixup): Update.
11410
11411 2019-03-06  Tom Tromey  <tom@tromey.com>
11412
11413         * inferior.h (class inferior): Update comment.
11414         * gdbthread.h (class thread_info): Update comment.
11415
11416 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11417             Tom Tromey  <tom@tromey.com>
11418
11419         * stabsread.h (struct stab_section_list): Remove.
11420         (coffstab_build_psymtabs): Update.
11421         * dbxread.c (symbuf_sections): Now a std::vector.
11422         (sect_idx): New global.
11423         (fill_symbuf): Update.
11424         (coffstab_build_psymtabs): Change type of stabsects parameter.
11425         Update.
11426         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11427         std::vector.
11428         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11429         (coff_locate_sections): Update.
11430         (coff_symfile_read): Remove cleanups.  Update.
11431         (init_stringtab): Add storage parameter.
11432         (free_stringtab, free_stringtab_cleanup): Remove.
11433         (init_lineno): Add storage parameter.
11434         (free_linetab, free_linetab_cleanup): Remove.
11435
11436 2019-03-06  Pedro Alves  <palves@redhat.com>
11437
11438         * linux-fork.c (fork_info::clobber_regs): Delete.
11439         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11440         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11441         comment.  Adjust.
11442         (scoped_switch_fork_info::scoped_switch_fork_info)
11443         (checkpoint_command, linux_fork_context): Adjust
11444         fork_save_infrun_state calls.
11445
11446 2019-03-06  Pedro Alves  <palves@redhat.com>
11447
11448         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11449         (inf_has_multiple_threads): Return 'bool' and rewrite using
11450         inferior_info::threads().
11451
11452 2019-03-06  Pedro Alves  <palves@redhat.com>
11453
11454         * linux-fork.c: Include <list>.
11455         (fork_list): Now a std::list instance.
11456         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11457         (forks_exist_p, find_last_fork): Adjust.
11458         (new_fork): Delete.
11459         (one_fork_p): New.
11460         (add_fork): Adjust.
11461         (free_fork): Delete, folded into fork_info::~fork_info().
11462         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11463         Adjust.
11464         (init_fork_list): Delete.
11465         (linux_fork_killall, linux_fork_mourn_inferior)
11466         (linux_fork_detach, info_checkpoints_command): Adjust.
11467         (_initialize_linux_fork): No longer call init_fork_list.
11468
11469 2019-03-06  Pedro Alves  <palves@redhat.com>
11470
11471         * linux-fork.c (new_fork): New, split out of ...
11472         (add_fork): ... this.  Return void.  Move "first fork" special
11473         case from here, to ...
11474         (checkpoint_command): ... here.
11475         * linux-linux.h (add_fork): Return void.
11476
11477 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11478
11479         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11480
11481 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11482             Chris January  <chris.january@arm.com>
11483             David Lecomber  <david.lecomber@arm.com>
11484
11485         * f-exp.y: New token, UNOP_INTRINSIC.
11486         (exp): New pattern using UNOP_INTRINSIC token.
11487         (f77_keywords): Add 'abs' keyword.
11488         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11489         (value_from_host_double): New function.
11490         (evaluate_subexp_f): Support UNOP_ABS.
11491
11492 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11493
11494         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11495         types.
11496
11497 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11498
11499         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11500         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11501         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11502
11503 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11504
11505         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11506
11507 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11508             Chris January  <chris.january@arm.com>
11509
11510         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11511         * f-exp.y: Define 'KIND' token.
11512         (exp): New pattern for KIND expressions.
11513         (ptype): Handle types with a kind extension.
11514         (direct_abs_decl): Extend to spot kind extensions.
11515         (f77_keywords): Add 'kind' to the list.
11516         (push_kind_type): New function.
11517         (convert_to_kind_type): New function.
11518         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11519         * parse.c (operator_length_standard): Likewise.
11520         * parser-defs.h (enum type_pieces): Add tp_kind.
11521         * std-operator.def: Add UNOP_KIND.
11522
11523 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11524
11525         * f-exp.y (f_parse): Set yydebug.
11526
11527 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11528
11529         * f-lang.c (evaluate_subexp_f): New function.
11530         (exp_descriptor_f): New global.
11531         (f_language_defn): Use exp_descriptor_f instead of
11532         exp_descriptor_standard.
11533
11534 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11535
11536         * f-exp.y (struct token): Add comments.
11537         (dot_ops): Remove uppercase versions and the end marker.
11538         (f77_keywords): Likewise.
11539         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11540         entries in the dot_ops array are case insensitive, and use
11541         strncasecmp to compare strings.  Also some whitespace cleanup in
11542         this area.  Similar for the f77_keywords array, except entries in
11543         this list might be case sensitive.
11544
11545 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11546
11547         * f-exp.y (struct f77_boolean_val): Add comments.
11548         (boolean_values): Remove uppercase versions, and end marker.
11549         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11550         and use strncasecmp to achieve case insensitivity.  Additionally,
11551         perform whitespace cleanup around this code.
11552
11553 2019-03-06  Tom Tromey  <tromey@adacore.com>
11554
11555         * remote-sim.c (gdbsim_target_open): Use result of
11556         gdb_argv::release.
11557
11558 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11559         Dirk Schubert  <dirk.schubert@arm.com>
11560         Chris January  <chris.january@arm.com>
11561
11562         * eval.c (evaluate_subexp_standard): Call Fortran argument
11563         wrapping logic.
11564         * f-lang.c (struct value): A value which can be passed into a
11565         Fortran function call.
11566         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11567         where appropriate.
11568         (struct type): Value ready for a Fortran function call.
11569         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11570         is needed.
11571         * f-lang.h (fortran_argument_convert): Declaration.
11572         (fortran_preserve_arg_pointer): Declaration.
11573         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11574
11575 2019-03-05  Tom Tromey  <tromey@adacore.com>
11576
11577         * python/py-prettyprint.c (print_string_repr): Remove #if.
11578         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11579
11580 2019-03-05  Tom Tromey  <tromey@adacore.com>
11581
11582         * target.c (the_dummy_target): Move later.  Change type to
11583         "dummy_target".
11584         (initialize_targets): Don't initialize the_dummy_target.
11585
11586 2019-03-05  Tom Tromey  <tromey@adacore.com>
11587
11588         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11589         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11590
11591 2019-03-05  Tom Tromey  <tromey@adacore.com>
11592
11593         * windows-nat.c (windows_nat_target::attach)
11594         (windows_nat_target::detach): Don't call gdb_flush.
11595         * valprint.c (generic_val_print, val_print, val_print_string):
11596         Don't call gdb_flush.
11597         * utils.c (defaulted_query): Don't call gdb_flush.
11598         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11599         * target.c (target_announce_detach): Don't call gdb_flush.
11600         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11601         * remote.c (extended_remote_target::attach): Don't call
11602         gdb_flush.
11603         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11604         * printcmd.c (do_examine): Don't call gdb_flush.
11605         (info_display_command): Don't call gdb_flush.
11606         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11607         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11608         * memattr.c (info_mem_command): Don't call gdb_flush.
11609         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11610         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11611         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11612         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11613         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11614         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11615         (gnu_nat_target::detach): Don't call gdb_flush.
11616         * f-valprint.c (f_val_print): Don't call gdb_flush.
11617         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11618         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11619         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11620         gdb_flush.
11621         * c-valprint.c (c_val_print): Don't call gdb_flush.
11622         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11623
11624 2019-03-05  Tom Tromey  <tromey@adacore.com>
11625
11626         * varobj.c (update_dynamic_varobj_children): Update.
11627         (install_default_visualizer): Use reset, not release.
11628         * value.c (set_internalvar): Update.
11629         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11630         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11631         ATTRIBUTE_UNUSED_RESULT.
11632
11633 2019-03-05  Tom Tromey  <tromey@adacore.com>
11634
11635         * remote.c (class scoped_remote_fd) <release>: Add
11636         ATTRIBUTE_UNUSED_RESULT.
11637
11638 2019-03-05  Tom Tromey  <tromey@adacore.com>
11639
11640         * macroexp.c (struct macro_buffer) <release>: Add
11641         ATTRIBUTE_UNUSED_RESULT.
11642
11643 2019-03-05  Tom Tromey  <tromey@adacore.com>
11644
11645         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11646         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11647         ATTRIBUTE_UNUSED_RESULT.
11648
11649 2019-03-05  Tom Tromey  <tromey@adacore.com>
11650
11651         * common/scoped_fd.h (class scoped_fd) <release>: Add
11652         ATTRIBUTE_UNUSED_RESULT.
11653
11654 2019-03-05  Tom Tromey  <tromey@adacore.com>
11655
11656         * parser-defs.h (struct parser_state) <release>: Add
11657         ATTRIBUTE_UNUSED_RESULT.
11658
11659 2019-03-05  Tom Tromey  <tromey@adacore.com>
11660
11661         * utils.h (class gdb_argv) <release>: Add
11662         ATTRIBUTE_UNUSED_RESULT.
11663         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11664
11665 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11666
11667         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11668         for-loop range, to avoid compiler warnings.
11669
11670         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11671         avoid compiler warnings about unused variables.
11672
11673         * NEWS: Mention end of support for native debugging on MS-Windows
11674         before XP.
11675
11676         PR gdb/24292
11677         * common/netstuff.c:
11678         * gdbserver/gdbreplay.c
11679         * gdbserver/remote-utils.c:
11680         * ser-tcp.c:
11681         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11682         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11683         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11684         'getaddrinfo' and 'freeaddrinfo' were not available before
11685         Windows XP, and mingw.org's MinGW headers by default define
11686         _WIN32_WINNT to 0x500.
11687
11688 2019-03-01  Gary Benson <gbenson@redhat.com>
11689
11690         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11691
11692 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11693             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11694
11695         PR gdb/8527
11696         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11697         set_sigint_trap, clear_sigint_trap.
11698
11699 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11700
11701         * target.c (target_detach): Clear the regcache and the
11702         frame cache.
11703
11704 2019-02-27  Pedro Alves  <palves@redhat.com>
11705
11706         * utils.c (set_screen_size): When we cap the height/width sizes,
11707         tweak the corresponding command variable to show "unlimited":
11708
11709 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11710             Pedro Alves  <palves@redhat.com>
11711
11712         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11713         before calling rl_set_screen_size.
11714
11715 2019-02-27  Tom Tromey  <tromey@adacore.com>
11716
11717         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11718         define.
11719         * python/py-value.c: Remove Python 2.4 workaround.
11720         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11721         workaround.
11722         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11723         Python 2.4 workaround.
11724         * python/python-internal.h: Remove Python 2.4 comment.
11725         (Py_ssize_t): Don't define.
11726         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11727         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11728         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11729         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11730         * python/python.c (do_start_initialization): Remove Python 2.4
11731         workaround.
11732         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11733         (print_children): Remove Python 2.4 workaround.
11734         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11735         workaround.
11736         (CHARBUFFERPROC_NAME): Remove.
11737         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11738         Python 2.4 workaround.
11739
11740 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11741
11742         * NEWS: Note minimum Python version.
11743
11744 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11745
11746         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11747         code from these functions.  Remove corresponding ifdefs.  Use
11748         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11749         Remove gotos and target of gotos.
11750         (infpy_search_memory): Likewise.
11751
11752 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11753
11754         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11755         (hppa_gdbarch_init): Don't register deleted functions with
11756         gdbarch.
11757
11758 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11759
11760         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11761         (h8300_unwind_sp): Delete.
11762         (h8300_dummy_id): Delete.
11763         (h8300_gdbarch_init): Don't register deleted functions with
11764         gdbarch.
11765
11766 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11767
11768         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11769         (ft32_unwind_pc): Delete.
11770         (ft32_unwind_sp): Delete.
11771         (ft32_gdbarch_init): Don't register deleted functions with
11772         gdbarch.
11773
11774 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11775
11776         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11777         (frv_unwind_pc): Delete.
11778         (frv_unwind_sp): Delete.
11779         (frv_gdbarch_init): Don't register deleted functions with
11780         gdbarch.
11781
11782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11783
11784         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11785         (riscv_unwind_pc): Delete.
11786         (riscv_unwind_sp): Delete.
11787         (riscv_gdbarch_init): Don't register deleted functions with
11788         gdbarch.
11789
11790 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11791
11792         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11793         (csky_unwind_pc): Delete.
11794         (csky_unwind_sp): Delete.
11795         (csky_gdbarch_init): Don't register deleted functions with
11796         gdbarch.
11797
11798 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11799
11800         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11801         (cris_unwind_pc): Delete.
11802         (cris_unwind_sp): Delete.
11803         (cris_gdbarch_init): Don't register deleted functions with
11804         gdbarch.
11805
11806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11807
11808         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11809         (bfin_unwind_pc): Delete.
11810         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11811
11812 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11813
11814         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11815         (arm_unwind_pc): Delete.
11816         (arm_unwind_sp): Delete.
11817         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11818
11819 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11820
11821         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11822         (arc_unwind_pc): Delete.
11823         (arc_unwind_sp): Delete.
11824         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11825
11826 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11827
11828         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11829         (alpha_unwind_pc): Delete.
11830         (alpha_gdbarch_init): Don't register deleted functions with
11831         gdbarch.
11832
11833 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11834
11835         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11836         (aarch64_unwind_pc): Delete.
11837         (aarch64_unwind_sp): Delete.
11838         (aarch64_gdbarch_init): Don't register deleted functions with
11839         gdbarch.
11840
11841 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11842
11843         * gdbtypes.c (type_align): Don't consider static members when
11844         computing structure alignment.
11845
11846 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11847
11848         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11849         return 0 for other types.
11850         * arch-utils.c (default_type_align): Always return 0.
11851         * gdbarch.h: Regenerate.
11852         * gdbarch.sh (type_align): Extend comment.
11853         * gdbtypes.c (type_align): Add additional comments, always call
11854         gdbarch_type_align before applying the default rules.
11855         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11856         generic code will then apply a suitable default.
11857         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11858         types, return 0 for other types.
11859
11860 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11861
11862         * NEWS: Create a new section for the next release branch.
11863         Rename the section of the current branch, now that it has
11864         been cut.
11865
11866 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11867
11868         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11869         * version.in: Bump version to 8.3.50.DATE-git.
11870
11871 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11872
11873         * aix-thread.c (ptid_cmp): Remove unused variable.
11874         (get_signaled_thread): Likewise.
11875         (store_regs_user_thread): Likewise.
11876         (store_regs_kernel_thread): Likewise.
11877         (fetch_regs_kernel_thread): Remove shadowed variable.
11878
11879 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11880
11881         * features/riscv/32bit-cpu.xml: Add register numbers.
11882         * features/riscv/32bit-fpu.c: Regenerate.
11883         * features/riscv/32bit-fpu.xml: Add register numbers.
11884         * features/riscv/64bit-cpu.xml: Add register numbers.
11885         * features/riscv/64bit-fpu.c: Regenerate.
11886         * features/riscv/64bit-fpu.xml: Add register numbers.
11887
11888 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11889
11890         * NEWS: Mention two argument form of gdb.Value constructor.
11891         * python/py-value.c (convert_buffer_and_type_to_value): New
11892         function.
11893         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11894         Add support for handling an optional second argument.  Call
11895         convert_buffer_and_type_to_value as appropriate.
11896         * python/python-internal.h (Py_buffer_deleter): New struct.
11897         (Py_buffer_up): New typedef.
11898
11899 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11900
11901         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11902         instead of releasing ownership.
11903
11904 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11905
11906         * dwarf2read.c (open_and_init_dwp_file): Call
11907         elf_numsections instead of bfd_count_sections to initialize
11908         dwp_file->num_sections.
11909
11910 2019-02-25  Tom Tromey  <tromey@adacore.com>
11911
11912         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11913
11914 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11915
11916         * gcore.in: Add '--readnever' option when invoking GDB.
11917
11918 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11919
11920         * MAINTAINERS: Update my email address.
11921
11922 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11923
11924         * build-id.c (build_id_to_debug_bfd_1): New function.
11925         (build_id_to_debug_bfd): Look for separate debug file in
11926         sysroot.
11927
11928 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11929
11930         * gdbarch.sh: Update the copyright year range that is placed into
11931         generated files.
11932
11933 2019-02-22  Keith Seitz  <keiths@redhat.com>
11934
11935         PR symtab/23853
11936         * linespec.c (create_sals_line_offset): Search for the default
11937         symtab's filename instead of its fullname.
11938
11939 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11940
11941         * NEWS: Update style defaults.
11942
11943 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11944
11945         * main.c (captured_main_1): Disable styling in batch mode.
11946
11947 2019-02-20  Tom Tromey  <tom@tromey.com>
11948
11949         * symtab.c (symtab_symbol_info): Fix typos.
11950
11951 2019-02-20  Tom Tromey  <tromey@adacore.com>
11952
11953         * findcmd.c (_initialize_mem_search): Use upper case for
11954         metasyntactic variables.
11955
11956 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11957
11958         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11959         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11960
11961 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11962
11963         * top.h (source_file_name): Change to std::string.
11964         * top.c (source_file_name): Likewise.
11965         (command_line_input): Adjust.
11966         * cli/cli-script.c (script_from_file): Adjust.
11967
11968 2019-02-19  Tom Tromey  <tromey@adacore.com>
11969
11970         * ravenscar-thread.c
11971         (ravenscar_thread_target::update_thread_list): Don't call
11972         ada_build_task_list.
11973         * ada-lang.h (ada_build_task_list): Don't declare.
11974         * ada-tasks.c (struct ada_tasks_inferior_data)
11975         <task_list_valid_p>: Now bool.
11976         (read_known_tasks, ada_task_list_changed)
11977         (ada_tasks_invalidate_inferior_data): Update.
11978         (read_known_tasks_array): Return bool.
11979         (read_known_tasks_list): Likewise.
11980         (read_known_tasks): Return void.
11981         (ada_build_task_list): Now static.
11982
11983 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11984
11985         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11986         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11987
11988 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11989
11990         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11991         variant for ada_tasks_pspace_data_handle and
11992         ada_tasks_inferior_data_handle.
11993         (ada_tasks_pspace_data_cleanup): New function.
11994         (ada_tasks_inferior_data_cleanup): New function.
11995
11996 2019-02-17  Tom Tromey  <tom@tromey.com>
11997
11998         * macrotab.h (macro_source_fullname): Return a std::string.
11999         * macrotab.c (macro_include, check_for_redefinition)
12000         (macro_undef, macro_lookup_definition, foreach_macro)
12001         (foreach_macro_in_scope): Update.
12002         (macro_source_fullname): Return a std::string.
12003         * macrocmd.c (show_pp_source_pos): Update.
12004
12005 2019-02-17  Tom Tromey  <tom@tromey.com>
12006
12007         * macrocmd.c (show_pp_source_pos): Style the file names.
12008
12009 2019-02-17  Tom Tromey  <tom@tromey.com>
12010
12011         PR tui/24197:
12012         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12013
12014 2019-02-17  Tom Tromey  <tom@tromey.com>
12015
12016         * ada-lang.c (user_select_syms): Use filtered printing.
12017         * utils.c (wrap_style): New global.
12018         (desired_style): Remove.
12019         (emit_style_escape): Add stream parameter.
12020         (set_output_style, reset_terminal_style, prompt_for_continue):
12021         Update.
12022         (flush_wrap_buffer): Only flush gdb_stdout.
12023         (wrap_here): Set wrap_style.
12024         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12025         treat escape sequences as a character.  Change when wrap buffer is
12026         flushed.
12027         (fputs_styled): Do not set the output style when the default is
12028         requested.
12029         * ui-style.h (struct ui_file_style) <is_default>: New method.
12030         * source.c (print_source_lines_base): Emit escape sequences in one
12031         piece.
12032
12033 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12034
12035         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12036         integers and enumeration types.
12037
12038 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12039
12040         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12041         instead of lookup_symbol_in_language
12042         (do_exact_match): New function.
12043         (ada_get_symbol_name_matcher): Return do_exact_match when
12044         doing a verbatim match.
12045
12046 2019-02-15  Tom Tromey  <tromey@adacore.com>
12047
12048         * ravenscar-thread.c (ravenscar_thread_target::resume)
12049         (ravenscar_thread_target::wait): Special case wildcard requests.
12050
12051 2019-02-15  Tom Tromey  <tromey@adacore.com>
12052
12053         * ravenscar-thread.c (base_ptid): Remove.
12054         (struct ravenscar_thread_target) <close>: New method.
12055         <m_base_ptid>: New member.
12056         <update_inferior_ptid, active_task, task_is_currently_active,
12057         runtime_initialized>: Declare methods.
12058         <ravenscar_thread_target>: Add constructor.
12059         (ravenscar_thread_target::task_is_currently_active)
12060         (ravenscar_thread_target::update_inferior_ptid)
12061         (ravenscar_runtime_initialized): Rename.  Now methods.
12062         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12063         (ravenscar_thread_target::update_thread_list): Update.
12064         (ravenscar_thread_target::active_task): Now method.
12065         (ravenscar_thread_target::store_registers)
12066         (ravenscar_thread_target::prepare_to_store)
12067         (ravenscar_thread_target::prepare_to_store)
12068         (ravenscar_thread_target::mourn_inferior): Update.
12069         (ravenscar_inferior_created): Use "new" to create target.
12070         (ravenscar_thread_target::get_ada_task_ptid): Update.
12071         (_initialize_ravenscar): Don't initialize base_ptid.
12072         (ravenscar_ops): Remove global.
12073
12074 2019-02-15  Tom Tromey  <tromey@adacore.com>
12075
12076         * target.h (push_target): Declare new overload.
12077         * target.c (push_target): New overload, taking an rvalue reference.
12078         * remote.c (remote_target::open_1): Use push_target overload.
12079         * corelow.c (core_target_open): Use push_target overload.
12080
12081 2019-02-15  Tom Tromey  <tromey@adacore.com>
12082
12083         * ravenscar-thread.c (is_ravenscar_task)
12084         (ravenscar_task_is_currently_active): Return bool.
12085         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12086         (_initialize_ravenscar): Remove "(void)".
12087         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12088         Return bool.
12089
12090 2019-02-15  Tom Tromey  <tromey@adacore.com>
12091
12092         * ravenscar-thread.c (ravenscar_runtime_initializer)
12093         (has_ravenscar_runtime, get_running_thread_id)
12094         (ravenscar_thread_target::resume): Fix indentation.
12095
12096 2019-02-15  Tom Tromey  <tromey@adacore.com>
12097
12098         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12099         from ravenscar_arch_ops.
12100         (sparc_ravenscar_ops::fetch_registers)
12101         (sparc_ravenscar_ops::store_registers): Now methods.
12102         (sparc_ravenscar_prepare_to_store): Remove.
12103         (sparc_ravenscar_ops): Redefine.
12104         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12105         methods and destructor.  Remove members.
12106         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12107         (ravenscar_thread_target::store_registers)
12108         (ravenscar_thread_target::prepare_to_store): Update.
12109         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12110         Remove.
12111         (struct ppc_ravenscar_powerpc_ops): Derive from
12112         ravenscar_arch_ops.
12113         (ppc_ravenscar_powerpc_ops::fetch_registers)
12114         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12115         (ppc_ravenscar_powerpc_ops): Redefine.
12116         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12117         (ppc_ravenscar_e500_ops::fetch_registers)
12118         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12119         (ppc_ravenscar_e500_ops): Redefine.
12120         * aarch64-ravenscar-thread.c
12121         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12122         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12123         (aarch64_ravenscar_fetch_registers)
12124         (aarch64_ravenscar_store_registers): Now methods.
12125         (aarch64_ravenscar_ops): Redefine.
12126
12127 2019-02-15  Tom Tromey  <tromey@adacore.com>
12128
12129         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12130         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12131         (ravenscar_thread_target::stopped_by_watchpoint)
12132         (ravenscar_thread_target::stopped_data_address)
12133         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12134
12135 2019-02-15  Tom Tromey  <tromey@adacore.com>
12136
12137         * ravenscar-thread.c: Fix some typos.
12138
12139 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12140             Tom Tromey  <tromey@adacore.com>
12141
12142         * ada-lang.c (ada_exception_sal): Change addr_string to a
12143         std::string.
12144         (create_ada_exception_catchpoint): Update.
12145
12146 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12147             Tom Tromey  <tromey@adacore.com>
12148
12149         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12150         (bp_location_ops): Remove.
12151         (base_breakpoint_allocate_location): Update.
12152         (free_bp_location): Update.
12153         * ada-lang.c (class ada_catchpoint_location)
12154         <ada_catchpoint_location>: Remove ops parameter.
12155         (ada_catchpoint_location_dtor): Remove.
12156         (ada_catchpoint_location_ops): Remove.
12157         (allocate_location_exception): Update.
12158         * breakpoint.h (struct bp_location_ops): Remove.
12159         (class bp_location) <bp_location>: Remove bp_location_ops
12160         parameter.
12161         <~bp_location>: Add destructor.
12162         <ops>: Remove.
12163
12164 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12165             Pedro Alves  <palves@redhat.com>
12166
12167         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12168         'PATH_MAX'.
12169
12170 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12171             Samuel Thibault  <samuel.thibault@gnu.org>
12172             Thomas Schwinge  <thomas@codesourcery.com>
12173
12174         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12175         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12176
12177 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12178
12179         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12180         (check_empty): Use "const char *".
12181
12182         * gnu-nat.c (gnu_nat_target::detach): Instead of
12183         'detach_inferior (pid)' call
12184         'detach_inferior (find_inferior_pid (pid))'.
12185
12186         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12187         'nat/fork-inferior.o'.
12188         * gnu-nat.c: #include "nat/fork-inferior.h".
12189
12190         * gnu-nat.c (gnu_nat_target::detach): Instead of
12191         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12192         * gnu-nat.h: #include "inf-child.h".
12193         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12194         'i386_gnu_nat_target::fetch_registers'.
12195         (gnu_store_registers): Rename/move to
12196         'i386_gnu_nat_target::store_registers'.
12197
12198         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12199         * gnu-nat.h (mach_thread_info): New function.
12200         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12201
12202         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12203
12204 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12205
12206         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12207
12208 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12209
12210         * windows-nat.c (windows_add_thread): Add new parameter
12211         "main_thread_p" with default value set to false.  Update
12212         function documentation as well as all callers.
12213         (windows_delete_thread): Likewise.
12214         (fake_create_process): Update call to windows_add_thread.
12215         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12216         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12217         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12218         call to windows_delete_thread.
12219
12220 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12221
12222         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12223
12224 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12225
12226         * symfile.c (find_separate_debug_file): Use canonical path of
12227         sysroot with child_path instead of gdb_sysroot if it is valid.
12228
12229 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12230
12231         * symfile.c (find_separate_debug_file): Use child_path to
12232         determine if an object file is under a sysroot.
12233
12234 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12235
12236         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12237         unittests/child-path-selftests.c.
12238         * common/pathstuff.c (child_path): New function.
12239         * common/pathstuff.h (child_path): New prototype.
12240         * unittests/child-path-selftests.c: New file.
12241
12242 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12243
12244         * symfile.c (find_separate_debug_file): Look for separate debug
12245         files in debug directories under the sysroot.
12246
12247 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12248
12249         * symtab.h (struct minimal_symbol data_p): New const method.
12250         (struct minimal_symbol text_p): Likewise.
12251         * symtab.c (output_source_filename): Use file name style
12252         to print file name.
12253         (print_symbol_info): Likewise.
12254         (print_msymbol_info): Use address style to print addresses.
12255         Use function name style to print executable text symbols.
12256         (expand_symtab_containing_pc): Use data_p.
12257         (find_pc_sect_compunit_symtab): Likewise.
12258
12259 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12260
12261         * breakpoint.c (describe_other_breakpoints): Use address style
12262         to print addresses.
12263         (say_where): Likewise.
12264
12265 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12266
12267         * ada-typeprint.c (print_func_type): Print function name
12268         style to print function name.
12269         * c-typeprint.c (c_print_type_1): Likewise.
12270
12271 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12272
12273         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12274         for execve.
12275
12276 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12277
12278         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12279         type_stack.
12280
12281 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12282
12283         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12284         TYPE_CODE_REF types.
12285
12286 2019-02-08  Jim Wilson  <jimw@sifive.com>
12287
12288         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12289         (riscv_linux_fregset): New.
12290         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12291
12292 2019-02-07  Tom Tromey  <tom@tromey.com>
12293
12294         * thread.c (thread_cancel_execution_command): Update.
12295         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12296         methods.
12297         (struct thread_fsm_ops): Remove.
12298         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12299         (thread_fsm_should_stop, thread_fsm_return_value)
12300         (thread_fsm_set_finished, thread_fsm_finished_p)
12301         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12302         Don't declare.
12303         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12304         * infrun.c (clear_proceed_status_thread)
12305         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12306         (print_stop_event): Update.
12307         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12308         Add constructor.
12309         (step_command_fsm_ops): Remove.
12310         (new_step_command_fsm): Remove.
12311         (step_1): Update.
12312         (step_command_fsm::should_stop): Rename from
12313         step_command_fsm_should_stop.
12314         (step_command_fsm::clean_up): Rename from
12315         step_command_fsm_clean_up.
12316         (step_command_fsm::do_async_reply_reason): Rename from
12317         step_command_fsm_async_reply_reason.
12318         (struct until_next_fsm): Inherit from thread_fsm.  Add
12319         constructor.
12320         (until_next_fsm_ops): Remove.
12321         (new_until_next_fsm): Remove.
12322         (until_next_fsm::should_stop): Rename from
12323         until_next_fsm_should_stop.
12324         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12325         (until_next_fsm::do_async_reply_reason): Rename from
12326         until_next_fsm_async_reply_reason.
12327         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12328         constructor.  Change type of breakpoint.
12329         (finish_command_fsm_ops): Remove.
12330         (new_finish_command_fsm): Remove.
12331         (finish_command_fsm::should_stop): Rename from
12332         finish_command_fsm_should_stop.
12333         (finish_command_fsm::clean_up): Rename from
12334         finish_command_fsm_clean_up.
12335         (finish_command_fsm::return_value): Rename from
12336         finish_command_fsm_return_value.
12337         (finish_command_fsm::do_async_reply_reason): Rename from
12338         finish_command_fsm_async_reply_reason.
12339         (finish_command): Update.
12340         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12341         Add constructor.
12342         (call_thread_fsm_ops): Remove.
12343         (call_thread_fsm::call_thread_fsm): Rename from
12344         new_call_thread_fsm.
12345         (call_thread_fsm::should_stop): Rename from
12346         call_thread_fsm_should_stop.
12347         (call_thread_fsm::should_notify_stop): Rename from
12348         call_thread_fsm_should_notify_stop.
12349         (run_inferior_call, call_function_by_hand_dummy): Update.
12350         * cli/cli-interp.c (should_print_stop_to_console): Update.
12351         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12352         Add constructor.  Change type of location_breakpoint,
12353         caller_breakpoint.
12354         (until_break_fsm_ops): Remove.
12355         (new_until_break_fsm): Remove.
12356         (until_break_fsm::should_stop): Rename from
12357         until_break_fsm_should_stop.
12358         (until_break_fsm::clean_up): Rename from
12359         until_break_fsm_clean_up.
12360         (until_break_fsm::do_async_reply_reason): Rename from
12361         until_break_fsm_async_reply_reason.
12362         (until_break_command): Update.
12363         * thread-fsm.c: Remove.
12364         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12365
12366 2019-02-07  Tom Tromey  <tom@tromey.com>
12367
12368         * yy-remap.h: Add include guard.
12369         * xtensa-tdep.h: Add include guard.
12370         * xcoffread.h: Rename include guard.
12371         * varobj-iter.h: Add include guard.
12372         * tui/tui.h: Rename include guard.
12373         * tui/tui-winsource.h: Rename include guard.
12374         * tui/tui-wingeneral.h: Rename include guard.
12375         * tui/tui-windata.h: Rename include guard.
12376         * tui/tui-win.h: Rename include guard.
12377         * tui/tui-stack.h: Rename include guard.
12378         * tui/tui-source.h: Rename include guard.
12379         * tui/tui-regs.h: Rename include guard.
12380         * tui/tui-out.h: Rename include guard.
12381         * tui/tui-layout.h: Rename include guard.
12382         * tui/tui-io.h: Rename include guard.
12383         * tui/tui-hooks.h: Rename include guard.
12384         * tui/tui-file.h: Rename include guard.
12385         * tui/tui-disasm.h: Rename include guard.
12386         * tui/tui-data.h: Rename include guard.
12387         * tui/tui-command.h: Rename include guard.
12388         * tic6x-tdep.h: Add include guard.
12389         * target/waitstatus.h: Rename include guard.
12390         * target/wait.h: Rename include guard.
12391         * target/target.h: Rename include guard.
12392         * target/resume.h: Rename include guard.
12393         * target-float.h: Rename include guard.
12394         * stabsread.h: Add include guard.
12395         * rs6000-tdep.h: Add include guard.
12396         * riscv-fbsd-tdep.h: Add include guard.
12397         * regformats/regdef.h: Rename include guard.
12398         * record.h: Rename include guard.
12399         * python/python.h: Rename include guard.
12400         * python/python-internal.h: Rename include guard.
12401         * python/py-stopevent.h: Rename include guard.
12402         * python/py-ref.h: Rename include guard.
12403         * python/py-record.h: Rename include guard.
12404         * python/py-record-full.h: Rename include guard.
12405         * python/py-record-btrace.h: Rename include guard.
12406         * python/py-instruction.h: Rename include guard.
12407         * python/py-events.h: Rename include guard.
12408         * python/py-event.h: Rename include guard.
12409         * procfs.h: Add include guard.
12410         * proc-utils.h: Add include guard.
12411         * p-lang.h: Add include guard.
12412         * or1k-tdep.h: Rename include guard.
12413         * observable.h: Rename include guard.
12414         * nto-tdep.h: Rename include guard.
12415         * nat/x86-linux.h: Rename include guard.
12416         * nat/x86-linux-dregs.h: Rename include guard.
12417         * nat/x86-gcc-cpuid.h: Add include guard.
12418         * nat/x86-dregs.h: Rename include guard.
12419         * nat/x86-cpuid.h: Rename include guard.
12420         * nat/ppc-linux.h: Rename include guard.
12421         * nat/mips-linux-watch.h: Rename include guard.
12422         * nat/linux-waitpid.h: Rename include guard.
12423         * nat/linux-ptrace.h: Rename include guard.
12424         * nat/linux-procfs.h: Rename include guard.
12425         * nat/linux-osdata.h: Rename include guard.
12426         * nat/linux-nat.h: Rename include guard.
12427         * nat/linux-namespaces.h: Rename include guard.
12428         * nat/linux-btrace.h: Rename include guard.
12429         * nat/glibc_thread_db.h: Rename include guard.
12430         * nat/gdb_thread_db.h: Rename include guard.
12431         * nat/gdb_ptrace.h: Rename include guard.
12432         * nat/fork-inferior.h: Rename include guard.
12433         * nat/amd64-linux-siginfo.h: Rename include guard.
12434         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12435         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12436         * nat/aarch64-linux.h: Rename include guard.
12437         * nat/aarch64-linux-hw-point.h: Rename include guard.
12438         * mn10300-tdep.h: Add include guard.
12439         * mips-linux-tdep.h: Add include guard.
12440         * mi/mi-parse.h: Rename include guard.
12441         * mi/mi-out.h: Rename include guard.
12442         * mi/mi-main.h: Rename include guard.
12443         * mi/mi-interp.h: Rename include guard.
12444         * mi/mi-getopt.h: Rename include guard.
12445         * mi/mi-console.h: Rename include guard.
12446         * mi/mi-common.h: Rename include guard.
12447         * mi/mi-cmds.h: Rename include guard.
12448         * mi/mi-cmd-break.h: Rename include guard.
12449         * m2-lang.h: Add include guard.
12450         * location.h: Rename include guard.
12451         * linux-record.h: Rename include guard.
12452         * linux-nat.h: Add include guard.
12453         * linux-fork.h: Add include guard.
12454         * i386-darwin-tdep.h: Rename include guard.
12455         * hppa-linux-offsets.h: Add include guard.
12456         * guile/guile.h: Rename include guard.
12457         * guile/guile-internal.h: Rename include guard.
12458         * gnu-nat.h: Rename include guard.
12459         * gdb-stabs.h: Rename include guard.
12460         * frv-tdep.h: Add include guard.
12461         * f-lang.h: Add include guard.
12462         * event-loop.h: Add include guard.
12463         * darwin-nat.h: Rename include guard.
12464         * cp-abi.h: Rename include guard.
12465         * config/sparc/nm-sol2.h: Rename include guard.
12466         * config/nm-nto.h: Rename include guard.
12467         * config/nm-linux.h: Add include guard.
12468         * config/i386/nm-i386gnu.h: Rename include guard.
12469         * config/djgpp/nl_types.h: Rename include guard.
12470         * config/djgpp/langinfo.h: Rename include guard.
12471         * compile/gcc-cp-plugin.h: Add include guard.
12472         * compile/gcc-c-plugin.h: Add include guard.
12473         * compile/compile.h: Rename include guard.
12474         * compile/compile-object-run.h: Rename include guard.
12475         * compile/compile-object-load.h: Rename include guard.
12476         * compile/compile-internal.h: Rename include guard.
12477         * compile/compile-cplus.h: Rename include guard.
12478         * compile/compile-c.h: Rename include guard.
12479         * common/xml-utils.h: Rename include guard.
12480         * common/x86-xstate.h: Rename include guard.
12481         * common/version.h: Rename include guard.
12482         * common/vec.h: Rename include guard.
12483         * common/tdesc.h: Rename include guard.
12484         * common/selftest.h: Rename include guard.
12485         * common/scoped_restore.h: Rename include guard.
12486         * common/scoped_mmap.h: Rename include guard.
12487         * common/scoped_fd.h: Rename include guard.
12488         * common/safe-iterator.h: Rename include guard.
12489         * common/run-time-clock.h: Rename include guard.
12490         * common/refcounted-object.h: Rename include guard.
12491         * common/queue.h: Rename include guard.
12492         * common/ptid.h: Rename include guard.
12493         * common/print-utils.h: Rename include guard.
12494         * common/preprocessor.h: Rename include guard.
12495         * common/pathstuff.h: Rename include guard.
12496         * common/observable.h: Rename include guard.
12497         * common/netstuff.h: Rename include guard.
12498         * common/job-control.h: Rename include guard.
12499         * common/host-defs.h: Rename include guard.
12500         * common/gdb_wait.h: Rename include guard.
12501         * common/gdb_vecs.h: Rename include guard.
12502         * common/gdb_unlinker.h: Rename include guard.
12503         * common/gdb_unique_ptr.h: Rename include guard.
12504         * common/gdb_tilde_expand.h: Rename include guard.
12505         * common/gdb_sys_time.h: Rename include guard.
12506         * common/gdb_string_view.h: Rename include guard.
12507         * common/gdb_splay_tree.h: Rename include guard.
12508         * common/gdb_setjmp.h: Rename include guard.
12509         * common/gdb_ref_ptr.h: Rename include guard.
12510         * common/gdb_optional.h: Rename include guard.
12511         * common/gdb_locale.h: Rename include guard.
12512         * common/gdb_assert.h: Rename include guard.
12513         * common/filtered-iterator.h: Rename include guard.
12514         * common/filestuff.h: Rename include guard.
12515         * common/fileio.h: Rename include guard.
12516         * common/environ.h: Rename include guard.
12517         * common/common-utils.h: Rename include guard.
12518         * common/common-types.h: Rename include guard.
12519         * common/common-regcache.h: Rename include guard.
12520         * common/common-inferior.h: Rename include guard.
12521         * common/common-gdbthread.h: Rename include guard.
12522         * common/common-exceptions.h: Rename include guard.
12523         * common/common-defs.h: Rename include guard.
12524         * common/common-debug.h: Rename include guard.
12525         * common/cleanups.h: Rename include guard.
12526         * common/buffer.h: Rename include guard.
12527         * common/btrace-common.h: Rename include guard.
12528         * common/break-common.h: Rename include guard.
12529         * cli/cli-utils.h: Rename include guard.
12530         * cli/cli-style.h: Rename include guard.
12531         * cli/cli-setshow.h: Rename include guard.
12532         * cli/cli-script.h: Rename include guard.
12533         * cli/cli-interp.h: Rename include guard.
12534         * cli/cli-decode.h: Rename include guard.
12535         * cli/cli-cmds.h: Rename include guard.
12536         * charset-list.h: Add include guard.
12537         * buildsym-legacy.h: Rename include guard.
12538         * bfin-tdep.h: Add include guard.
12539         * ax.h: Rename include guard.
12540         * arm-linux-tdep.h: Add include guard.
12541         * arm-fbsd-tdep.h: Add include guard.
12542         * arch/xtensa.h: Rename include guard.
12543         * arch/tic6x.h: Add include guard.
12544         * arch/i386.h: Add include guard.
12545         * arch/arm.h: Rename include guard.
12546         * arch/arm-linux.h: Rename include guard.
12547         * arch/arm-get-next-pcs.h: Rename include guard.
12548         * arch/amd64.h: Add include guard.
12549         * arch/aarch64-insn.h: Rename include guard.
12550         * arch-utils.h: Rename include guard.
12551         * annotate.h: Add include guard.
12552         * amd64-darwin-tdep.h: Rename include guard.
12553         * aarch64-linux-tdep.h: Add include guard.
12554         * aarch64-fbsd-tdep.h: Add include guard.
12555         * aarch32-linux-nat.h: Add include guard.
12556
12557 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12558
12559         * macrotab.c (macro_define_internal): New function that
12560         factorizes macro_define_object_internal and macro_define_function
12561         code.
12562         (macro_define_object_internal): Use macro_define_internal.
12563         (macro_define_function): Likewise.
12564
12565 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12566
12567         * macrocmd.c (extract_identifier): Return
12568         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12569         callers.
12570
12571 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12572
12573         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12574
12575 2019-02-05  Tom Tromey  <tom@tromey.com>
12576
12577         * target.c (target_stack::unpush): Move assertion earlier.
12578
12579 2019-01-30  Tom Tromey  <tom@tromey.com>
12580
12581         PR python/23615:
12582         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12583         (gdbpy_parse_and_eval): Likewise.
12584         * python/python-internal.h (gdbpy_allow_threads): New class.
12585
12586 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12587
12588         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12589         (aarch64_fbsd_fpregmap): Move earlier.
12590         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12591         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12592         instead of individual calls to trad_frame_set_reg_addr.
12593         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12594         earlier.
12595         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12596         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12597         instead of individual calls to trad_frame_set_reg_addr.
12598
12599 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12600
12601         * CONTRIBUTE: Replace contribution list with wiki link.
12602
12603 2019-01-25  Tom Tromey  <tom@tromey.com>
12604
12605         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12606
12607 2019-01-25  Tom Tromey  <tom@tromey.com>
12608
12609         * xtensa-linux-nat.c: Fix common/ includes.
12610         * xml-support.h: Fix common/ includes.
12611         * xml-support.c: Fix common/ includes.
12612         * x86-linux-nat.c: Fix common/ includes.
12613         * windows-nat.c: Fix common/ includes.
12614         * varobj.h: Fix common/ includes.
12615         * varobj.c: Fix common/ includes.
12616         * value.c: Fix common/ includes.
12617         * valops.c: Fix common/ includes.
12618         * utils.c: Fix common/ includes.
12619         * unittests/xml-utils-selftests.c: Fix common/ includes.
12620         * unittests/utils-selftests.c: Fix common/ includes.
12621         * unittests/unpack-selftests.c: Fix common/ includes.
12622         * unittests/tracepoint-selftests.c: Fix common/ includes.
12623         * unittests/style-selftests.c: Fix common/ includes.
12624         * unittests/string_view-selftests.c: Fix common/ includes.
12625         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12626         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12627         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12628         * unittests/rsp-low-selftests.c: Fix common/ includes.
12629         * unittests/parse-connection-spec-selftests.c: Fix common/
12630         includes.
12631         * unittests/optional-selftests.c: Fix common/ includes.
12632         * unittests/offset-type-selftests.c: Fix common/ includes.
12633         * unittests/observable-selftests.c: Fix common/ includes.
12634         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12635         * unittests/memrange-selftests.c: Fix common/ includes.
12636         * unittests/memory-map-selftests.c: Fix common/ includes.
12637         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12638         * unittests/function-view-selftests.c: Fix common/ includes.
12639         * unittests/environ-selftests.c: Fix common/ includes.
12640         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12641         * unittests/common-utils-selftests.c: Fix common/ includes.
12642         * unittests/cli-utils-selftests.c: Fix common/ includes.
12643         * unittests/array-view-selftests.c: Fix common/ includes.
12644         * ui-file.c: Fix common/ includes.
12645         * tui/tui-io.c: Fix common/ includes.
12646         * tracepoint.h: Fix common/ includes.
12647         * tracepoint.c: Fix common/ includes.
12648         * tracefile-tfile.c: Fix common/ includes.
12649         * top.h: Fix common/ includes.
12650         * top.c: Fix common/ includes.
12651         * thread.c: Fix common/ includes.
12652         * target/waitstatus.h: Fix common/ includes.
12653         * target/waitstatus.c: Fix common/ includes.
12654         * target.h: Fix common/ includes.
12655         * target.c: Fix common/ includes.
12656         * target-memory.c: Fix common/ includes.
12657         * target-descriptions.c: Fix common/ includes.
12658         * symtab.h: Fix common/ includes.
12659         * symfile.c: Fix common/ includes.
12660         * stap-probe.c: Fix common/ includes.
12661         * spu-linux-nat.c: Fix common/ includes.
12662         * sparc-nat.c: Fix common/ includes.
12663         * source.c: Fix common/ includes.
12664         * solib.c: Fix common/ includes.
12665         * solib-target.c: Fix common/ includes.
12666         * ser-unix.c: Fix common/ includes.
12667         * ser-tcp.c: Fix common/ includes.
12668         * ser-pipe.c: Fix common/ includes.
12669         * ser-base.c: Fix common/ includes.
12670         * selftest-arch.c: Fix common/ includes.
12671         * s12z-tdep.c: Fix common/ includes.
12672         * rust-exp.y: Fix common/ includes.
12673         * rs6000-aix-tdep.c: Fix common/ includes.
12674         * riscv-tdep.c: Fix common/ includes.
12675         * remote.c: Fix common/ includes.
12676         * remote-notif.h: Fix common/ includes.
12677         * remote-fileio.h: Fix common/ includes.
12678         * remote-fileio.c: Fix common/ includes.
12679         * regcache.h: Fix common/ includes.
12680         * regcache.c: Fix common/ includes.
12681         * record-btrace.c: Fix common/ includes.
12682         * python/python.c: Fix common/ includes.
12683         * python/py-type.c: Fix common/ includes.
12684         * python/py-inferior.c: Fix common/ includes.
12685         * progspace.h: Fix common/ includes.
12686         * producer.c: Fix common/ includes.
12687         * procfs.c: Fix common/ includes.
12688         * proc-api.c: Fix common/ includes.
12689         * printcmd.c: Fix common/ includes.
12690         * ppc-linux-nat.c: Fix common/ includes.
12691         * parser-defs.h: Fix common/ includes.
12692         * osdata.c: Fix common/ includes.
12693         * obsd-nat.c: Fix common/ includes.
12694         * nat/x86-linux.c: Fix common/ includes.
12695         * nat/x86-linux-dregs.c: Fix common/ includes.
12696         * nat/x86-dregs.h: Fix common/ includes.
12697         * nat/x86-dregs.c: Fix common/ includes.
12698         * nat/ppc-linux.c: Fix common/ includes.
12699         * nat/mips-linux-watch.h: Fix common/ includes.
12700         * nat/mips-linux-watch.c: Fix common/ includes.
12701         * nat/linux-waitpid.c: Fix common/ includes.
12702         * nat/linux-ptrace.h: Fix common/ includes.
12703         * nat/linux-ptrace.c: Fix common/ includes.
12704         * nat/linux-procfs.c: Fix common/ includes.
12705         * nat/linux-personality.c: Fix common/ includes.
12706         * nat/linux-osdata.c: Fix common/ includes.
12707         * nat/linux-namespaces.c: Fix common/ includes.
12708         * nat/linux-btrace.h: Fix common/ includes.
12709         * nat/linux-btrace.c: Fix common/ includes.
12710         * nat/fork-inferior.c: Fix common/ includes.
12711         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12712         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12713         * nat/aarch64-linux.c: Fix common/ includes.
12714         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12715         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12716         * namespace.h: Fix common/ includes.
12717         * mips-linux-tdep.c: Fix common/ includes.
12718         * minsyms.c: Fix common/ includes.
12719         * mi/mi-parse.h: Fix common/ includes.
12720         * mi/mi-main.c: Fix common/ includes.
12721         * mi/mi-cmd-env.c: Fix common/ includes.
12722         * memrange.h: Fix common/ includes.
12723         * memattr.c: Fix common/ includes.
12724         * maint.h: Fix common/ includes.
12725         * maint.c: Fix common/ includes.
12726         * main.c: Fix common/ includes.
12727         * machoread.c: Fix common/ includes.
12728         * location.c: Fix common/ includes.
12729         * linux-thread-db.c: Fix common/ includes.
12730         * linux-nat.c: Fix common/ includes.
12731         * linux-fork.c: Fix common/ includes.
12732         * inline-frame.c: Fix common/ includes.
12733         * infrun.c: Fix common/ includes.
12734         * inflow.c: Fix common/ includes.
12735         * inferior.h: Fix common/ includes.
12736         * inferior.c: Fix common/ includes.
12737         * infcmd.c: Fix common/ includes.
12738         * inf-ptrace.c: Fix common/ includes.
12739         * inf-child.c: Fix common/ includes.
12740         * ia64-linux-nat.c: Fix common/ includes.
12741         * i387-tdep.c: Fix common/ includes.
12742         * i386-tdep.c: Fix common/ includes.
12743         * i386-linux-tdep.c: Fix common/ includes.
12744         * i386-linux-nat.c: Fix common/ includes.
12745         * i386-go32-tdep.c: Fix common/ includes.
12746         * i386-fbsd-tdep.c: Fix common/ includes.
12747         * i386-fbsd-nat.c: Fix common/ includes.
12748         * guile/scm-type.c: Fix common/ includes.
12749         * guile/guile.c: Fix common/ includes.
12750         * go32-nat.c: Fix common/ includes.
12751         * gnu-nat.c: Fix common/ includes.
12752         * gdbthread.h: Fix common/ includes.
12753         * gdbarch-selftests.c: Fix common/ includes.
12754         * gdb_usleep.c: Fix common/ includes.
12755         * gdb_select.h: Fix common/ includes.
12756         * gdb_bfd.c: Fix common/ includes.
12757         * gcore.c: Fix common/ includes.
12758         * fork-child.c: Fix common/ includes.
12759         * findvar.c: Fix common/ includes.
12760         * fbsd-nat.c: Fix common/ includes.
12761         * event-top.c: Fix common/ includes.
12762         * event-loop.c: Fix common/ includes.
12763         * dwarf2read.c: Fix common/ includes.
12764         * dwarf2loc.c: Fix common/ includes.
12765         * dwarf2-frame.c: Fix common/ includes.
12766         * dwarf-index-cache.c: Fix common/ includes.
12767         * dtrace-probe.c: Fix common/ includes.
12768         * disasm-selftests.c: Fix common/ includes.
12769         * defs.h: Fix common/ includes.
12770         * csky-tdep.c: Fix common/ includes.
12771         * cp-valprint.c: Fix common/ includes.
12772         * cp-support.h: Fix common/ includes.
12773         * cp-support.c: Fix common/ includes.
12774         * corelow.c: Fix common/ includes.
12775         * completer.h: Fix common/ includes.
12776         * completer.c: Fix common/ includes.
12777         * compile/compile.c: Fix common/ includes.
12778         * compile/compile-loc2c.c: Fix common/ includes.
12779         * compile/compile-cplus-types.c: Fix common/ includes.
12780         * compile/compile-cplus-symbols.c: Fix common/ includes.
12781         * command.h: Fix common/ includes.
12782         * cli/cli-dump.c: Fix common/ includes.
12783         * cli/cli-cmds.c: Fix common/ includes.
12784         * charset.c: Fix common/ includes.
12785         * build-id.c: Fix common/ includes.
12786         * btrace.h: Fix common/ includes.
12787         * btrace.c: Fix common/ includes.
12788         * breakpoint.h: Fix common/ includes.
12789         * breakpoint.c: Fix common/ includes.
12790         * ax.h:
12791         (enum agent_op): Fix common/ includes.
12792         * ax-general.c (struct aop_map): Fix common/ includes.
12793         * ax-gdb.c: Fix common/ includes.
12794         * auxv.c: Fix common/ includes.
12795         * auto-load.c: Fix common/ includes.
12796         * arm-tdep.c: Fix common/ includes.
12797         * arch/riscv.c: Fix common/ includes.
12798         * arch/ppc-linux-common.c: Fix common/ includes.
12799         * arch/i386.c: Fix common/ includes.
12800         * arch/arm.c: Fix common/ includes.
12801         * arch/arm-linux.c: Fix common/ includes.
12802         * arch/arm-get-next-pcs.c: Fix common/ includes.
12803         * arch/amd64.c: Fix common/ includes.
12804         * arch/aarch64.c: Fix common/ includes.
12805         * arch/aarch64-insn.c: Fix common/ includes.
12806         * arch-utils.c: Fix common/ includes.
12807         * amd64-windows-tdep.c: Fix common/ includes.
12808         * amd64-tdep.c: Fix common/ includes.
12809         * amd64-sol2-tdep.c: Fix common/ includes.
12810         * amd64-obsd-tdep.c: Fix common/ includes.
12811         * amd64-nbsd-tdep.c: Fix common/ includes.
12812         * amd64-linux-tdep.c: Fix common/ includes.
12813         * amd64-linux-nat.c: Fix common/ includes.
12814         * amd64-fbsd-tdep.c: Fix common/ includes.
12815         * amd64-fbsd-nat.c: Fix common/ includes.
12816         * amd64-dicos-tdep.c: Fix common/ includes.
12817         * amd64-darwin-tdep.c: Fix common/ includes.
12818         * agent.c: Fix common/ includes.
12819         * ada-lang.h: Fix common/ includes.
12820         * ada-lang.c: Fix common/ includes.
12821         * aarch64-tdep.c: Fix common/ includes.
12822
12823 2019-01-25  Tom Tromey  <tom@tromey.com>
12824
12825         * common/create-version.sh: Use common/version.h.
12826
12827 2019-01-24  Pedro Alves  <palves@redhat.com>
12828
12829         * infrun.c (signal_stop, signal_print, signal_program)
12830         (signal_catch, signal_pass): Now arrays instead of pointers.
12831         (update_signals_program_target, do_target_resume)
12832         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12833         * linux-nat.c (linux_nat_target::pass_signals)
12834         (linux_nat_target::create_inferior, linux_nat_target::attach):
12835         Adjust.
12836         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12837         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12838         * procfs.c (procfs_target::pass_signals): Adjust.
12839         * record-full.c (record_full_target::resume): Adjust.
12840         * remote.c (remote_target::pass_signals)
12841         (remote_target::program_signals): Adjust.
12842         * target-debug.h (target_debug_print_signals): Now takes a
12843         gdb::array_view as parameter.  Adjust.
12844         * target.h (target_ops) <pass_signals, program_signals>: Replace
12845         pointer and length parameters with gdb::array_view.
12846         (target_pass_signals, target_program_signals): Likewise.
12847         * target-delegates.c: Regenerate.
12848
12849 2019-01-24  Pedro Alves  <palves@redhat.com>
12850
12851         * common/forward-scope-exit.h
12852         (forward_scope_exit::forward_scope_exit): Pass arguments to
12853         m_bind_function directly, instead of creating a std::bind and
12854         copying that.
12855
12856 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12857
12858         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12859         for static members.
12860         (pass_in_v_vfp_candidate): Likewise.
12861
12862 2019-01-23  Tom Tromey  <tom@tromey.com>
12863             Pedro Alves  <palves@redhat.com>
12864
12865         * regcache.c (class regcache_invalidator): Remove.
12866         (regcache::raw_write): Use make_scope_exit.
12867
12868 2019-01-23  Tom Tromey  <tom@tromey.com>
12869
12870         * ui-out.h (class ui_out_emit_type): Update comment.
12871
12872 2019-01-23  Tom Tromey  <tom@tromey.com>
12873
12874         * infrun.c (fetch_inferior_event): Update comment.
12875
12876 2019-01-23  Tom Tromey  <tom@tromey.com>
12877             Pedro Alves  <palves@redhat.com>
12878
12879         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12880         parameter.
12881         (fetch_inferior_event): Use SCOPE_EXIT.
12882
12883
12884 2019-01-23  Tom Tromey  <tom@tromey.com>
12885             Pedro Alves  <palves@redhat.com>
12886
12887         * infrun.c (disable_thread_events): Delete.
12888         (stop_all_threads): Use SCOPE_EXIT.
12889
12890 2019-01-23  Tom Tromey  <tom@tromey.com>
12891             Pedro Alves  <palves@redhat.com>
12892
12893         * symfile.c: Include forward-scope-exit.h.
12894         (clear_symtab_users_cleanup): Replace forward declaration with
12895         a FORWARD_SCOPE_EXIT.
12896         (syms_from_objfile_1): Use the forward_scope_exit and
12897         gdb::optional instead of cleanup_function.
12898         (reread_symbols): Use the forward_scope_exit instead of
12899         cleanup_function.
12900         (clear_symtab_users_cleanup): Remove function.
12901
12902 2019-01-23  Tom Tromey  <tom@tromey.com>
12903             Pedro Alves  <palves@redhat.com>
12904
12905         * linux-nat.c: Include scope-exit.h.
12906         (cleanup_target_stop): Remove.
12907         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12908         SCOPE_EXIT.
12909
12910 2019-01-23  Tom Tromey  <tom@tromey.com>
12911             Pedro Alves  <palves@redhat.com>
12912
12913         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12914         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12915
12916 2019-01-23  Tom Tromey  <tom@tromey.com>
12917             Andrew Burgess  <andrew.burgess@embecosm.com>
12918             Pedro Alves  <palves@redhat.com>
12919
12920         * infrun.c (fetch_inferior_event): Use scope_exit.
12921         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12922         * top.c (execute_command): Use scope_exit.
12923         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12924         * utils.c (do_bpstat_clear_actions_cleanup)
12925         (make_bpstat_clear_actions_cleanup): Remove.
12926
12927 2019-01-23  Tom Tromey  <tom@tromey.com>
12928             Pedro Alves  <palves@redhat.com>
12929
12930         * infrun.c: Include "common/scope-exit.h"
12931         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12932         (wait_for_inferior): Use SCOPE_EXIT.
12933         (fetch_inferior_event): Use scope_exit.
12934
12935 2019-01-23  Tom Tromey  <tom@tromey.com>
12936             Pedro Alves  <palves@redhat.com>
12937
12938         * breakpoint.c (create_breakpoint): Remove cleanup.
12939
12940 2019-01-23  Tom Tromey  <tom@tromey.com>
12941             Andrew Burgess  <andrew.burgess@embecosm.com>
12942             Pedro Alves  <palves@redhat.com>
12943
12944 2019-01-23  Pedro Alves  <palves@redhat.com>
12945
12946         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12947
12948 2019-01-23  Pedro Alves  <palves@redhat.com>
12949             Andrew Burgess  <andrew.burgess@embecosm.com>
12950
12951         * gdbthread.h: Include "common/forward-scope-exit.h".
12952         (scoped_finish_thread_state): Redefine custom class in terms of
12953         forward_scope_exit.
12954
12955 2019-01-23  Pedro Alves  <palves@redhat.com>
12956             Andrew Burgess  <andrew.burgess@embecosm.com>
12957
12958         * common/forward-scope-exit.h: New file.
12959
12960 2019-01-23  Pedro Alves  <palves@redhat.com>
12961             Andrew Burgess  <andrew.burgess@embecosm.com>
12962             Tom Tromey  <tom@tromey.com>
12963
12964         * common/scope-exit.h: New file.
12965
12966 2019-01-23  Pedro Alves  <palves@redhat.com>
12967
12968         * common/preprocessor.h (ESC): Rename to ...
12969         (ESC_PARENS): ... this.
12970         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12971         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12972
12973 2019-01-23  Tom Tromey  <tom@tromey.com>
12974
12975         * language.h (class scoped_switch_to_sym_language_if_auto):
12976         Initialize m_lang in both cases.
12977
12978 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12979
12980         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12981         with XCNEW.
12982
12983 2019-01-22  Tom Tromey  <tom@tromey.com>
12984
12985         * corelow.c: Do not include sys/file.h.
12986
12987 2019-01-22  Tom Tromey  <tom@tromey.com>
12988
12989         * tui/tui-wingeneral.h: Include gdb_curses.h.
12990
12991 2019-01-22  Tom Tromey  <tom@tromey.com>
12992
12993         * source-cache.h (class source_cache) <get_source_lines,
12994         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12995
12996 2019-01-22  Tom Tromey  <tom@tromey.com>
12997
12998         * remote-fileio.h (struct remote_target): Declare.
12999
13000 2019-01-22  Tom Tromey  <tom@tromey.com>
13001
13002         * python/py-arch.c: Do not include py-ref.h.
13003         * python/py-bpevent.c: Do not include py-ref.h.
13004         * python/py-cmd.c: Do not include py-ref.h.
13005         * python/py-continueevent.c: Do not include py-ref.h.
13006         * python/py-event.h: Do not include py-ref.h.
13007         * python/py-evtregistry.c: Do not include py-ref.h.
13008         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13009         * python/py-frame.c: Do not include py-ref.h.
13010         * python/py-framefilter.c: Do not include py-ref.h.
13011         * python/py-function.c: Do not include py-ref.h.
13012         * python/py-infevents.c: Do not include py-ref.h.
13013         * python/py-linetable.c: Do not include py-ref.h.
13014         * python/py-objfile.c: Do not include py-ref.h.
13015         * python/py-param.c: Do not include py-ref.h.
13016         * python/py-prettyprint.c: Do not include py-ref.h.
13017         * python/py-progspace.c: Do not include py-ref.h.
13018         * python/py-symbol.c: Do not include py-ref.h.
13019         * python/py-symtab.c: Do not include py-ref.h.
13020         * python/py-type.c: Do not include py-ref.h.
13021         * python/py-unwind.c: Do not include py-ref.h.
13022         * python/py-utils.c: Do not include py-ref.h.
13023         * python/py-value.c: Do not include py-ref.h.
13024         * python/py-varobj.c: Do not include py-ref.h.
13025         * python/py-xmethods.c: Do not include py-ref.h.
13026         * python/python.c: Do not include py-ref.h.
13027         * varobj.c: Do not include py-ref.h.
13028
13029 2019-01-22  Tom Tromey  <tom@tromey.com>
13030
13031         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13032         keyword for bcache.
13033
13034 2019-01-22  Tom Tromey  <tom@tromey.com>
13035
13036         * compile/compile-cplus-types.c: Remove a comment by #include.
13037
13038 2019-01-22  Tom Tromey  <tom@tromey.com>
13039
13040         * compile/gcc-c-plugin.h: Include compile-internal.h.
13041
13042 2019-01-22  Tom Tromey  <tom@tromey.com>
13043
13044         * stabsread.c (EXTERN): Do not define.
13045         (symnum, next_symbol_text_func, processing_gcc_compilation)
13046         (within_function, global_sym_chain, global_stabs)
13047         (previous_stab_code, this_object_header_files)
13048         (n_this_object_header_files)
13049         (n_allocated_this_object_header_files): Define.
13050         * stabsread.h (EXTERN): Never define.  Use "extern".
13051
13052 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13053
13054         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13055         history_value.
13056
13057 2019-01-21  Tom Tromey  <tom@tromey.com>
13058
13059         * ui-out.c: Fix includes.
13060         * tui/tui-source.c: Fix includes.
13061         * target.c: Fix includes.
13062         * remote.c: Fix includes.
13063         * regcache.c: Fix includes.
13064         * python/py-block.c: Fix includes.
13065         * printcmd.c: Fix includes.
13066         * or1k-tdep.c: Fix includes.
13067         * mi/mi-main.c: Fix includes.
13068         * m32r-tdep.c: Fix includes.
13069         * csky-tdep.c: Fix includes.
13070         * compile/compile-cplus-types.c: Fix includes.
13071         * cli/cli-interp.c: Fix includes.
13072
13073 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13074
13075         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13076         for padding.
13077
13078 2019-01-16  Tom Tromey  <tom@tromey.com>
13079
13080         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13081         earlier.
13082         (struct objfile) <msymbols_range>: Move from top level.
13083         <msymbols>: New method.
13084         (class objfile_msymbols): Remove.
13085         * symtab.c (default_collect_symbol_completion_matches_break_on):
13086         Update.
13087         * symmisc.c (dump_msymbols): Update.
13088         * stabsread.c (scan_file_globals): Update.
13089         * objc-lang.c (info_selectors_command, info_classes_command)
13090         (find_methods): Update.
13091         * minsyms.c (find_solib_trampoline_target): Update.
13092         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13093         * coffread.c (coff_symfile_read): Update.
13094         * ada-lang.c (ada_lookup_simple_minsym)
13095         (ada_collect_symbol_completion_matches): Update.
13096
13097 2019-01-16  Tom Tromey  <tom@tromey.com>
13098
13099         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13100         type.  Remove no-argument constructor.
13101         <iterator::operator++>: Simplify.
13102         <begin>: Update.
13103         <end>: Use minimal_symbol_count.
13104
13105 2019-01-16  Tom Tromey  <tom@tromey.com>
13106
13107         * objfiles.h (struct objfile) <psymtabs>: New method.
13108         (class objfile_psymtabs): Remove.
13109         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13110         typedef.
13111         <range>: New method.
13112         (require_partial_symbols): Change return type.
13113         * psymtab.c (require_partial_symbols)
13114         (psym_expand_symtabs_matching): Update.
13115         * mdebugread.c (parse_partial_symbols): Update.
13116         * dbxread.c (dbx_end_psymtab): Update.
13117
13118 2019-01-15  Tom Tromey  <tom@tromey.com>
13119
13120         * symtab.c (lookup_objfile_from_block)
13121         (lookup_symbol_in_objfile_symtabs)
13122         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13123         (find_line_symtab, info_sources_command)
13124         (default_collect_symbol_completion_matches_break_on)
13125         (make_source_files_completion_list): Update.
13126         * symmisc.c (print_objfile_statistics, dump_objfile)
13127         (maintenance_print_symbols, maintenance_info_symtabs)
13128         (maintenance_check_symtabs, maintenance_info_line_tables):
13129         Update.
13130         * source.c (select_source_symtab)
13131         (forget_cached_source_info_for_objfile): Update.
13132         * objfiles.h (class objfile_compunits): Remove.
13133         (struct objfile) <compunits_range>: New typedef.
13134         (compunits): New method.
13135         * objfiles.c (objfile_relocate1): Update.
13136         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13137         * maint.c (count_symtabs_and_blocks): Update.
13138         * linespec.c (iterate_over_all_matching_symtabs): Update.
13139         * cp-support.c (add_symbol_overload_list_qualified): Update.
13140         * coffread.c (coff_symtab_read): Update.
13141         * ada-lang.c (add_nonlocal_symbols)
13142         (ada_collect_symbol_completion_matches)
13143         (ada_add_global_exceptions): Update.
13144
13145 2019-01-15  Tom Tromey  <tom@tromey.com>
13146
13147         * progspace.h (program_space) <objfiles_safe_range>: New
13148         typedef.
13149         <objfiles_safe>: New method.
13150         * objfiles.h (class all_objfiles_safe): Remove.
13151         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13152         * jit.c (jit_inferior_exit_hook): Update.
13153
13154 2019-01-17  Tom Tromey  <tom@tromey.com>
13155
13156         * progspace.h (program_space) <objfiles_range>: New typedef.
13157         <objfiles>: New method.
13158         <objfiles_head>: Rename from objfiles.
13159         (object_files): Update.
13160         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13161         * guile/scm-pretty-print.c
13162         (ppscm_find_pretty_printer_from_objfiles): Update.
13163         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13164         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13165         Update.
13166         * python/py-progspace.c (pspy_get_objfiles): Update.
13167         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13168         Update.
13169         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13170         (objfpy_lookup_objfile_by_build_id): Update.
13171         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13172         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13173         Update.
13174         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13175         (expand_symtab_containing_pc, lookup_objfile_from_block)
13176         (lookup_static_symbol, basic_lookup_transparent_type)
13177         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13178         (find_line_symtab, info_sources_command)
13179         (default_collect_symbol_completion_matches_break_on)
13180         (make_source_files_completion_list, find_main_name): Update.
13181         * symmisc.c (print_symbol_bcache_statistics)
13182         (print_objfile_statistics, maintenance_print_symbols)
13183         (maintenance_print_msymbols, maintenance_print_objfiles)
13184         (maintenance_info_symtabs, maintenance_check_symtabs)
13185         (maintenance_expand_symtabs, maintenance_info_line_tables):
13186         Update.
13187         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13188         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13189         (map_overlay_command, unmap_overlay_command)
13190         (simple_overlay_update, expand_symtabs_matching)
13191         (map_symbol_filenames): Update.
13192         * symfile-debug.c (set_debug_symfile): Update.
13193         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13194         Update.
13195         * source.c (select_source_symtab, forget_cached_source_info):
13196         Update.
13197         * solib.c (solib_read_symbols): Update.
13198         * solib-spu.c (append_ocl_sos): Update.
13199         * psymtab.c (maintenance_print_psymbols)
13200         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13201         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13202         * printcmd.c (info_symbol_command): Update.
13203         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13204         Update.
13205         * objfiles.h (class all_objfiles): Remove.
13206         * objfiles.c (have_partial_symbols, have_full_symbols)
13207         (have_minimal_symbols, qsort_cmp, update_section_map)
13208         (shared_objfile_contains_address_p)
13209         (default_iterate_over_objfiles_in_search_order): Update.
13210         * objc-lang.c (info_selectors_command, info_classes_command)
13211         (find_methods): Update.
13212         * minsyms.c (find_solib_trampoline_target): Update.
13213         * maint.c (maintenance_info_sections)
13214         (maintenance_translate_address, count_symtabs_and_blocks):
13215         Update.
13216         * main.c (captured_main_1): Update.
13217         * linux-thread-db.c (try_thread_db_load_from_pdir)
13218         (has_libpthread): Update.
13219         * linespec.c (iterate_over_all_matching_symtabs)
13220         (search_minsyms_for_name): Update.
13221         * jit.c (jit_find_objf_with_entry_addr): Update.
13222         * hppa-tdep.c (find_unwind_entry)
13223         (hppa_lookup_stub_minimal_symbol): Update.
13224         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13225         Update.
13226         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13227         (elf_gnu_ifunc_resolve_by_got): Update.
13228         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13229         * dwarf-index-write.c (save_gdb_index_command): Update.
13230         * cp-support.c (add_symbol_overload_list_qualified): Update.
13231         * breakpoint.c (create_overlay_event_breakpoint)
13232         (create_longjmp_master_breakpoint)
13233         (create_std_terminate_master_breakpoint)
13234         (create_exception_master_breakpoint): Update.
13235         * blockframe.c (find_pc_partial_function): Update.
13236         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13237         (ada_collect_symbol_completion_matches)
13238         (ada_add_global_exceptions): Update.
13239
13240 2019-01-17  Tom Tromey  <tom@tromey.com>
13241
13242         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13243         declare VEC.
13244         (solib_target_parse_libraries): Change return type.
13245         (library_list_start_segment, library_list_start_section)
13246         (library_list_end_library, library_list_start_library); Update.
13247         (solib_target_free_library_list): Remove.
13248         (solib_target_parse_libraries): Remove cleanup.  Change return
13249         type.
13250         (solib_target_current_sos): Update.
13251
13252 2019-01-17  Tom Tromey  <tromey@bapiya>
13253
13254         * valprint.c: Replace "the the" with "the".
13255         * symtab.c: Replace "the the" with "the".
13256         * solib.c: Replace "the the" with "the".
13257         * solib-dsbt.c: Replace "the the" with "the".
13258         * linespec.c: Replace "the the" with "the".
13259         * dwarf2loc.h: Replace "the the" with "the".
13260         * amd64-windows-tdep.c: Replace "the the" with "the".
13261         * aarch64-tdep.c: Replace "the the" with "the".
13262
13263 2019-01-16  Keith Seitz  <keiths@redhat.com>
13264
13265         PR gdb/23773
13266         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13267         <builder>: Rename to ..
13268         <m_builder>: ... this and make private.
13269         (dwarf2_cu::get_builder): New method.  Change all users of
13270         `builder' to use this method.
13271         (dwarf2_start_symtab): Move to ...
13272         (dwarf2_cu::start_symtab): ... here.  Update all callers
13273         (setup_type_unit_groups): Move to ...
13274         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13275         callers.
13276         (dwarf2_cu::reset_builder): New method.
13277         (process_full_compunit, process_full_type_unit): Use
13278         dwarf2_cu::reset_builder.
13279         (follow_die_offset): Record the ancestor CU if it is different
13280         from the followed DIE's CU.
13281         (follow_die_sig_1): Likewise.
13282
13283 2019-01-15  Tom Tromey  <tom@tromey.com>
13284
13285         * remote.c (class remote_state) <buf>: Now a char_vector.
13286         <buf_size>: Remove.
13287         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13288         parameter.
13289         (remote_target::getpkt_or_notif_sane_1)
13290         (remote_target::getpkt_sane)
13291         (remote_target::getpkt_or_notif_sane): Likewise.
13292         (class remote_target) <putpkt>: New overload.
13293         (remote_target::read_frame): Change type of "buf_p".  Remove
13294         sizeof_p parameter.
13295         (packet_ok): New overload.
13296         (packet_check_result): New overload.
13297         Update all uses.
13298
13299 2019-01-14  Tom Tromey  <tom@tromey.com>
13300
13301         * remote-notif.c (handle_notification, remote_notif_ack)
13302         (remote_notif_parse): Make "buf" const.
13303         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13304         const.
13305         (remote_notif_parse, remote_notif_ack, handle_notification):
13306         Likewise.
13307         * remote.c (remote_notif_stop_parse): Make "buf" const.
13308         (remote_target::remote_parse_stop_reply): Make "buf" const.
13309         (remote_notif_stop_ack): Make "buf" const.
13310
13311 2019-01-14  Tom Tromey  <tom@tromey.com>
13312
13313         * remote.c (remote_console_output): Make parameter const.
13314
13315 2019-01-14  Tom Tromey  <tom@tromey.com>
13316
13317         * target-debug.h (target_debug_print_signals): Constify.
13318         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13319         * procfs.c (procfs_target::pass_signals): Update.
13320         * linux-nat.c (linux_nat_target::pass_signals): Update.
13321         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13322         * target-delegates.c: Rebuild.
13323         * remote.c (remote_target::program_signals): Update.
13324         (remote_target::pass_signals): Update.
13325         * target.c (target_pass_signals): Constify argument.
13326         (target_program_signals): Likewise.
13327         * target.h (struct target_ops) <pass_signals, program_signals>:
13328         Constify argument.
13329         (target_pass_signals, target_program_signals): Constify argument.
13330
13331 2019-01-14  Tom Tromey  <tom@tromey.com>
13332
13333         PR tui/28819:
13334         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13335
13336 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13337
13338         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13339         field.
13340         * rs6000-tdep.c: Include reggroups.h.
13341         (IS_V_ALIAS_PSEUDOREG): Define.
13342         (rs6000_register_name): Return names for the "vX" aliases.
13343         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13344         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13345         aliases.  Call default_register_reggroup_p for all other
13346         pseudo-registers.
13347         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13348         New functions.
13349         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13350         Handle "vX" aliases.
13351         (v_alias_pseudo_register_collect): New function.
13352         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13353         (rs6000_gdbarch_init): Initialize "vX" aliases as
13354         pseudo-registers.  Restore registration of
13355         rs6000_pseudo_register_reggroup_p with
13356         set_tdesc_pseudo_register_reggroup_p.
13357
13358 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13359
13360         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13361         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13362         set_gdbarch_num_pseudo_regs.
13363
13364 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13365
13366         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13367         Remove arg prefixname, add do_set and do_show.
13368         Add member functions set_list and show_list.
13369         * cli/cli-style.c (class cli_style_option): Update accordingly.
13370         (style_set_list): Move to file scope.
13371         (style_show_list): Likewise.
13372         (set_style): Call help_list.
13373         (show_style): Call cmd_show_list.
13374         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13375         Update to use the new macro.
13376
13377 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13378
13379         * ada-lang.c (_initialize_ada_language): Expand the help text
13380         for the "catch exception" command.
13381
13382 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13383
13384         * symtab.c (matching_obj_sections): Initialize obj,
13385         declare it closer to its usage.
13386
13387 2019-01-10  Tom Tromey  <tom@tromey.com>
13388
13389         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13390         (basic_inf_threads_range): Remove.
13391         (inf_threads_range, inf_non_exited_threads_range)
13392         (safe_inf_threads_range): Use next_adapter.
13393
13394 2019-01-10  Keith Seitz  <keiths@redhat.com>
13395
13396         PR gdb/23712
13397         PR symtab/23010
13398         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13399         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13400
13401 2019-01-10  Keith Seitz  <keiths@redhat.com>
13402
13403         PR gdb/23712
13404         PR symtab/23010
13405         * dictionary.c (pending_to_vector): Remove.
13406         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13407         Remove _1 suffix, replacing functions of the same name.  Update
13408         all callers.
13409         (dict_create_hashed, dict_create_hashed_expandable)
13410         (dict_create_linear, dict_create_linear_expandable, dict_free)
13411         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13412         Make functions static.
13413
13414 2019-01-10  Keith Seitz  <keiths@redhat.com>
13415
13416         PR gdb/23712
13417         PR symtab/23010
13418         * dictionary.h (struct dictionary): Replace declaration with
13419         multidictionary.
13420         (dict_create_hashed, dict_create_hashed_expandable)
13421         (dict_create_linear, dict_create_linear_expandable)
13422         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13423         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13424         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13425         taking multidictionary argument.
13426         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13427         * block.h (struct block) <dict>: Change to multidictionary
13428         and rename `multidict'.
13429         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13430         symmisc.c: Update all dictionary references to multidictionary.
13431
13432 2019-01-10  Keith Seitz  <keiths@redhat.com>
13433
13434         PR gdb/23712
13435         PR symtab/23010
13436         * dictionary.c: Include unordered_map.
13437         (pending_to_vector): New function.
13438         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13439         Rewrite the non-"_1" functions to take vector instead
13440         of linked list.
13441         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13442         "new" _1 versions of the same name.
13443         (multidictionary): Define.
13444         (std::hash<enum language): New definition.
13445         (collate_pending_symbols_by_language, mdict_create_hashed)
13446         (mdict_create_hashed_expandable, mdict_create_linear)
13447         (mdict_create_linear_expandable, mdict_free)
13448         (find_language_dictionary, create_new_language_dictionary)
13449         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13450         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13451         (mdict_size, mdict_empty): New functions.
13452         * dictionary.h (mdict_iterator): Define.
13453
13454 2019-01-10  Pedro Alves  <palves@redhat.com>
13455
13456         * breakpoint.c (read_uploaded_action)
13457         (create_tracepoint_from_upload): Adjust to use
13458         gdb::unique_xmalloc_ptr.
13459         * ctf.c (ctf_write_uploaded_tp):
13460         (SET_ARRAY_FIELD): Use emplace_back.
13461         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13462         * tracefile-tfile.c (tfile_write_uploaded_tp):
13463         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13464         gdb::unique_xmalloc_ptr.
13465         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13466         at_string, cond_string, cmd_strings>: Replace char pointers
13467         with gdb::unique_xmalloc_ptr.
13468
13469 2019-01-10  Pedro Alves  <palves@redhat.com>
13470
13471         * solib-target.c (library_list_start_library): Don't xstrdup name.
13472
13473 2019-01-10  Pedro Alves  <palves@redhat.com>
13474
13475         * mdebugread.c (parse_partial_symbols): Use
13476         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13477
13478 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13479
13480         * linux-fork.c (scoped_switch_fork_info)
13481         <~scoped_switch_fork_info>: Fix incorrect variable name.
13482
13483 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13484
13485         * linux-fork.c (scoped_switch_fork_info)
13486         <scoped_switch_fork_info>: Make explicit.
13487         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13488
13489 2019-01-10  Tom Tromey  <tom@tromey.com>
13490
13491         * objfiles.h (objfile::reset_psymtabs): Update.
13492         * objfiles.c (objfile::objfile): Update.
13493         * psymtab.h (psymtab_storage::obstack): Update.
13494         (psymtab_storage::m_obstack): Use gdb::optional.
13495         (class psymtab_storage): Update comment.  Remove objfile
13496         parameter.
13497         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13498
13499 2019-01-10  Tom Tromey  <tom@tromey.com>
13500
13501         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13502         <free_psymtabs>: Now private.
13503         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13504         (allocate_psymtab): Use new method.
13505
13506 2019-01-10  Tom Tromey  <tom@tromey.com>
13507
13508         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13509         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13510         * mdebugread.c (parse_partial_symbols): Use
13511         allocate_dependencies.
13512         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13513         allocate_dependencies.
13514         (process_psymtab_comp_unit_reader)
13515         (build_type_psymtab_dependencies): Likewise.
13516         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13517
13518 2019-01-10  Tom Tromey  <tom@tromey.com>
13519
13520         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13521         PSYMBOL_SET_LANGUAGE.
13522         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13523
13524 2019-01-10  Tom Tromey  <tom@tromey.com>
13525
13526         * psymtab.h (psymtab_storage::obstack): New method.
13527         <m_obstack>: Rename from obstack; now private.
13528         * psymtab.c (psymtab_storage): Update.
13529         * dwarf2read.c (create_addrmap_from_index)
13530         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13531         Update.
13532
13533 2019-01-10  Tom Tromey  <tom@tromey.com>
13534
13535         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13536         * objfiles.h (objfile::reset_psymtabs): New method.
13537
13538 2019-01-10  Tom Tromey  <tom@tromey.com>
13539
13540         * symmisc.c (print_symbol_bcache_statistics): Update.
13541         (print_objfile_statistics): Update.
13542         * symfile.c (reread_symbols): Update.
13543         * psymtab.h (class psymtab_storage): New.
13544         * psymtab.c (psymtab_storage): New constructor.
13545         (~psymtab_storage): New destructor.
13546         (require_partial_symbols): Update.
13547         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13548         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13549         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13550         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13551         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13552         (start_psymtab_common, end_psymtab_common)
13553         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13554         (allocate_psymtab): Update.
13555         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13556         Update.
13557         (dump_psymtab_addrmap, maintenance_print_psymbols)
13558         (maintenance_check_psymtabs): Update.
13559         (class objfile_psymtabs): Move to objfiles.h.
13560         * psympriv.h (discard_psymtab): Now inline.
13561         (psymtab_discarder::psymtab_discarder): Update.
13562         (psymtab_discarder::~psymtab_discarder): Update.
13563         (ALL_OBJFILE_PSYMTABS): Rewrite.
13564         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13565         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13566         Remove fields.
13567         <partial_symtabs>: New field.
13568         (class objfile_psymtabs): Move from psymtab.h.  Update.
13569         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13570         psymbol_cache.
13571         (objfile::~objfile): Don't destroy psymbol_cache.
13572         * mdebugread.c (parse_partial_symbols): Update.
13573         * dwarf2read.c (create_addrmap_from_index)
13574         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13575         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13576         (add_partial_subprogram, dwarf2_ranges_read): Update.
13577         * dwarf-index-write.c (write_address_map)
13578         (write_one_signatured_type, recursively_write_psymbols)
13579         (class debug_names, class debug_names, write_psymtabs_to_index):
13580         Update.
13581
13582 2019-01-10  Tom Tromey  <tom@tromey.com>
13583
13584         * symtab.h (SYMBOL_SET_NAMES): Update.
13585         (symbol_set_names): Update.
13586         (MSYMBOL_SET_NAMES): Update.
13587         * symtab.c (symbol_set_names): Change argument to be an
13588         objfile_per_bfd_storage.
13589         * psymtab.c (add_psymbol_to_bcache): Update.
13590         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13591
13592 2019-01-10  Tom Tromey  <tom@tromey.com>
13593
13594         * symtab.c (create_demangled_names_hash): Change argument to be an
13595         objfile_per_bfd_storage.
13596         (symbol_set_names): Update.
13597
13598 2019-01-10  Tom Tromey  <tom@tromey.com>
13599
13600         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13601         init_psymbol_list.
13602         * psymtab.c (init_psymbol_list): Do nothing if already called.
13603         * psympriv.h (init_psymbol_list): Add comment.
13604         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13605         init_psymbol_list.
13606         * dbxread.c (dbx_symfile_read): Unconditionally call
13607         init_psymbol_list.
13608
13609 2019-01-10  Tom Tromey  <tom@tromey.com>
13610
13611         * xcoffread.c (scan_xcoff_symtab): Update.
13612         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13613         "where".
13614         * mdebugread.c (parse_partial_symbols)
13615         (handle_psymbol_enumerators): Update.
13616         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13617         * dbxread.c (read_dbx_symtab): Update.
13618         * psympriv.h (psymbol_placement): New enum.
13619         (add_psymbol_to_list): Update.
13620
13621 2019-01-10  Tom Tromey  <tom@tromey.com>
13622
13623         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13624         static_psymbols parameters.
13625         (scan_xcoff_symtab): Update.
13626         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13627         static_psymbols parameters.
13628         * psympriv.h (start_psymtab_common): Update.
13629         * mdebugread.c (parse_partial_symbols): Update.
13630         * dwarf2read.c (create_partial_symtab): Update.
13631         * dbxread.c (read_dbx_symtab): Update.
13632         (start_psymtab): Remove global_psymbols and static_psymbols
13633         parameters.
13634
13635 2019-01-10  Tom Tromey  <tom@tromey.com>
13636
13637         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13638         * psymtab.c (allocate_psymtab): Add comment.
13639         * psympriv.h (allocate_psymtab): Add comment.
13640         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13641         initializations.
13642         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13643
13644 2019-01-10  Tom Tromey  <tom@tromey.com>
13645
13646         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13647         Don't declare.
13648         * mipsread.c: Include mdebugread.h.
13649         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13650         Declare.
13651         * elfread.c: Include mdebugread.h.
13652
13653 2019-01-09  Tom Tromey  <tom@tromey.com>
13654
13655         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13656         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13657         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13658         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13659         (psym_lookup_symbol, psym_find_last_source_symtab)
13660         (psym_forget_cached_source_info, psym_print_stats)
13661         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13662         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13663         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13664         (psym_find_compunit_symtab_by_address)
13665         (maintenance_print_psymbols, maintenance_info_psymtabs)
13666         (maintenance_check_psymtabs): Use ranged for.
13667         * psymtab.h (class objfile_psymtabs): New.
13668         (require_partial_symbols): Return objfile_psymtabs.
13669         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13670
13671 2019-01-09  Tom Tromey  <tom@tromey.com>
13672
13673         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13674         (find_pc_mapped_section, list_overlays_command)
13675         (map_overlay_command, unmap_overlay_command)
13676         (simple_overlay_update): Use all_objfiles.
13677         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13678         * printcmd.c (info_symbol_command): Use all_objfiles.
13679         * objfiles.h (ALL_OBJSECTIONS): Remove.
13680         * maint.c (maintenance_translate_address): Use all_objfiles.
13681         * gcore.c (gcore_create_callback): Use all_objfiles.
13682         (objfile_find_memory_regions): Likewise.
13683
13684 2019-01-09  Tom Tromey  <tom@tromey.com>
13685
13686         * symtab.c (find_line_symtab, info_sources_command)
13687         (make_source_files_completion_list): Use objfile_compunits.
13688         * source.c (select_source_symtab): Use objfile_compunits.
13689         * objfiles.h (struct objfile): Update comment.
13690         (ALL_OBJFILES): Remove.
13691         (ALL_FILETABS): Remove.
13692         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13693         objfile_compunits.
13694
13695 2019-01-09  Tom Tromey  <tom@tromey.com>
13696
13697         * symmisc.c (print_objfile_statistics, dump_objfile)
13698         (maintenance_print_symbols): Use compunit_filetabs.
13699         * source.c (forget_cached_source_info_for_objfile): Use
13700         compunit_filetabs.
13701         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13702         (ALL_FILETABS): Use compunit_filetabs.
13703         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13704         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13705
13706 2019-01-09  Tom Tromey  <tom@tromey.com>
13707
13708         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13709         (compunit_filetabs): New.
13710         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13711         compunit_filetabs.
13712         (info_sources_command, make_source_files_completion_list): Remove
13713         declaration.
13714         * symmisc.c (print_objfile_statistics, dump_objfile)
13715         (maintenance_print_symbols): Remove declaration.
13716         (maintenance_info_symtabs): Use compunit_filetabs.
13717         (maintenance_info_line_tables): Likewise.
13718         * source.c (select_source_symtab): Change local variable name.
13719         (forget_cached_source_info_for_objfile): Remove declaration.
13720         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13721         * objfiles.c (objfile_relocate1): Remove declaration.
13722         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13723         declaration.
13724         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13725         * coffread.c (coff_symtab_read): Remove declaration.
13726         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13727         compunit_filetabs.
13728
13729 2019-01-09  Tom Tromey  <tom@tromey.com>
13730
13731         * symtab.c (lookup_objfile_from_block)
13732         (find_pc_sect_compunit_symtab, search_symbols)
13733         (default_collect_symbol_completion_matches_break_on): Use
13734         objfile_compunits.
13735         * objfiles.h (ALL_COMPUNITS): Remove.
13736         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13737         * cp-support.c (add_symbol_overload_list_qualified): Use
13738         objfile_compunits.
13739         * ada-lang.c (ada_collect_symbol_completion_matches)
13740         (ada_add_global_exceptions): Use objfile_compunits.
13741
13742 2019-01-09  Tom Tromey  <tom@tromey.com>
13743
13744         * source.c (select_source_symtab)
13745         (forget_cached_source_info_for_objfile): Remove declaration.
13746         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13747         declaration.
13748         * maint.c (count_symtabs_and_blocks): Remove declaration.
13749         * cp-support.c (add_symbol_overload_list_qualified): Remove
13750         declaration.
13751         * coffread.c (coff_symtab_read): Remove declaration.
13752         * symtab.c (lookup_symbol_in_objfile_symtabs)
13753         (basic_lookup_transparent_type_1): Use objfile_compunits.
13754         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13755         (info_sources_command, search_symbols)
13756         (default_collect_symbol_completion_matches_break_on)
13757         (make_source_files_completion_list): Remove declaration.
13758         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13759         (ada_collect_symbol_completion_matches)
13760         (ada_add_global_exceptions): Remove declaration.
13761         * linespec.c (iterate_over_all_matching_symtabs): Use
13762         objfile_compunits.
13763         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13764         (class objfile_compunits): New.
13765         (ALL_COMPUNITS): Use objfile_compunits.
13766         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13767         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13768         objfile_compunits.
13769         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13770
13771 2019-01-09  Tom Tromey  <tom@tromey.com>
13772
13773         * symtab.c (search_symbols)
13774         (default_collect_symbol_completion_matches_break_on): Use
13775         objfile_msymbols.
13776         * ada-lang.c (ada_lookup_simple_minsym)
13777         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13778         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13779         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13780         objfile_msymbols.
13781         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13782         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13783         * objc-lang.c (find_methods): Use objfile_msymbols.
13784         (info_selectors_command, info_classes_command): Likewise.
13785         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13786         * objfiles.h (class objfile_msymbols): New.
13787         (ALL_OBJFILE_MSYMBOLS): Remove.
13788         (ALL_MSYMBOLS): Remove.
13789
13790 2019-01-09  Tom Tromey  <tom@tromey.com>
13791
13792         * common/next-iterator.h (next_adapter): Add Iterator template
13793         parameter.
13794         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13795         (class all_objfiles_safe): New.
13796         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13797         * objfiles.c (put_objfile_before): Update comment.
13798         (add_separate_debug_objfile): Likewise.
13799         (free_all_objfiles): Use all_objfiles_safe.
13800         (objfile_purge_solibs): Likewise.
13801
13802 2019-01-09  Tom Tromey  <tom@tromey.com>
13803
13804         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13805         (expand_symtab_containing_pc, lookup_static_symbol)
13806         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13807         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13808         all_objfiles.
13809         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13810         * breakpoint.c (create_overlay_event_breakpoint)
13811         (create_longjmp_master_breakpoint)
13812         (create_std_terminate_master_breakpoint)
13813         (create_exception_master_breakpoint): Use all_objfiles.
13814         * linux-thread-db.c (try_thread_db_load_from_pdir)
13815         (has_libpthread): Use all_objfiles.
13816         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13817         * linespec.c (iterate_over_all_matching_symtabs)
13818         (search_minsyms_for_name): Use all_objfiles.
13819         * maint.c (maintenance_info_sections): Use all_objfiles.
13820         * main.c (captured_main_1): Use all_objfiles.
13821         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13822         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13823         * guile/scm-pretty-print.c
13824         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13825         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13826         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13827         (maintenance_print_msymbols): Use all_objfiles.
13828         * source.c (select_source_symtab): Use all_objfiles.
13829         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13830         * symfile.c (remove_symbol_file_command)
13831         (expand_symtabs_matching, map_symbol_filenames): Use
13832         all_objfiles.
13833         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13834         all_objfiles.
13835         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13836         * objc-lang.c (find_methods): Use all_objfiles.
13837         * objfiles.c (have_partial_symbols, have_full_symbols)
13838         (have_minimal_symbols, qsort_cmp)
13839         (default_iterate_over_objfiles_in_search_order): Use
13840         all_objfiles.
13841         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13842         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13843         (maintenance_check_psymtabs): Use all_objfiles.
13844         (ALL_PSYMTABS): Remove.
13845         * compile/compile-object-run.c (do_module_cleanup): Use
13846         all_objfiles.
13847         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13848         * cp-support.c (add_symbol_overload_list_qualified): Use
13849         all_objfiles.
13850         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13851         Use all_objfiles.
13852         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13853         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13854         all_objfiles.
13855         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13856         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13857         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13858         Uses all_objfiles.
13859         * solib.c (solib_read_symbols): Use all_objfiles
13860
13861 2019-01-09  Tom Tromey  <tom@tromey.com>
13862
13863         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13864         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13865         all_objfiles.
13866         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13867         * symmisc.c (print_symbol_bcache_statistics)
13868         (print_objfile_statistics, maintenance_print_objfiles)
13869         (maintenance_info_symtabs, maintenance_check_symtabs)
13870         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13871         all_objfiles.
13872         * source.c (forget_cached_source_info): Use all_objfiles.
13873         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13874         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13875         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13876         * objfiles.c (update_section_map): Use all_objfiles.
13877         (shared_objfile_contains_address_p): Likewise.
13878         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13879         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13880
13881 2019-01-09  Tom Tromey  <tom@tromey.com>
13882
13883         * common/next-iterator.h: New file.
13884         * objfiles.h (class all_objfiles): New.
13885         (struct objfile_iterator): New.
13886
13887 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13888
13889         * NEWS: Move the description of the changed "frame", "select-frame",
13890          and "info frame" commands to the Changed commands section.
13891
13892 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13893
13894         * gdbtypes.c (check_stub_method_group): Remove handling of old
13895         mangling schemes.
13896         * linespec.c (find_methods): Likewise.
13897         * stabsread.c (read_member_functions): Likewise.
13898         * valops.c (search_struct_method): Likewise.
13899         (value_struct_elt_for_reference): Likewise.
13900         * NEWS: Mention this change.
13901
13902 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13903
13904         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13905         print_source_lines.
13906         * source.c (print_source_lines_base): Update line number check.
13907         (print_source_lines): New function.
13908         (source_lines_range::source_lines_range): New function.
13909         * source.h (class source_lines_range): New class.
13910         (print_source_lines): New declaration.
13911
13912 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13913
13914         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13915
13916 2019-01-08  Tom Tromey  <tom@tromey.com>
13917             Simon Marchi  <simon.marchi@ericsson.com>
13918
13919         PR gdb/24060
13920         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13921         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13922         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13923         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13924         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13925         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13926
13927 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13928
13929         * source.c (select_source_symtab): Move header comment to
13930         declaration in source.h.
13931         (forget_cached_source_info_for_objfile): Likewise.
13932         (forget_cached_source_info): Likewise.
13933         (identify_source_line): Likewise.
13934         * source.h (identify_source_line): Move declaration from symtab.h
13935         and add comment from source.c
13936         (print_source_lines): Likewise.
13937         (forget_cached_source_info_for_objfile): Likewise.
13938         (forget_cached_source_info): Likewise.
13939         (select_source_symtab): Likewise.
13940         (enum print_source_lines_flag): Move definition from symtab.h.
13941         * symtab.h (identify_source_line): Move declaration to source.h.
13942         (print_source_lines): Likewise.
13943         (forget_cached_source_info_for_objfile): Likewise.
13944         (forget_cached_source_info): Likewise.
13945         (select_source_symtab): Likewise.
13946         (enum print_source_lines_flag): Move definition to source.h.
13947         * tui/tui-hooks.c: Add 'source.h' include.
13948
13949 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13950
13951         * source.c (print_source_lines_base): Handle requests to print
13952         reverse line number sequences, and guard against empty lines
13953         string.
13954
13955 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13956
13957         * source.c (print_source_lines_base): Fix skip of '\r' if next
13958         character is '\n'.
13959
13960 2019-01-06  Tom Tromey  <tom@tromey.com>
13961
13962         * c-exp.y (struct c_parse_state) <macro_original_text,
13963         expansion_obstack>: New member.
13964         (macro_original_text, expansion_obstack): Remove globals.
13965         (scan_macro_expansion, scanning_macro_expansion)
13966         (finished_macro_expansion): Update.
13967         (scan_macro_cleanup): Remove.
13968         (yylex, c_parse): Update.
13969
13970 2019-01-06  Tom Tromey  <tom@tromey.com>
13971
13972         * c-exp.y (struct c_parse_state) <strings>: New member.
13973         (operator_stoken): Update.
13974
13975 2019-01-06  Tom Tromey  <tom@tromey.com>
13976
13977         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13978         (union type_stack_elt) <typelist_val>: Now a pointer to
13979         std::vector.
13980         (type_stack_cleanup): Don't declare.
13981         (push_typelist): Update.
13982         * parse.c (pop_typelist): Return a std::vector.
13983         (push_typelist): Take a std::vector.
13984         (follow_types): Update.  Do not free args.
13985         (type_stack_cleanup): Remove.
13986         * c-exp.y (struct c_parse_state): New.
13987         (cpstate): New global.
13988         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13989         (nonempty_typelist): Update.
13990         (func_mod): Create a new vector.
13991         (c_parse): Create a c_parse_state.
13992         (check_parameter_typelist): Do not delete params.
13993         (function_method): Update.  Do not delete type_list.
13994
13995 2019-01-06  Tom Tromey  <tom@tromey.com>
13996
13997         PR gdb/28155:
13998         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13999         check_typedef.
14000         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14001         (print_return_value): Likewise.
14002
14003 2019-01-05  Tom Tromey  <tom@tromey.com>
14004
14005         * contrib/cleanup_check.py: Remove.
14006         * contrib/gcc-with-excheck: Remove.
14007         * contrib/exsummary.py: Remove.
14008         * contrib/excheck.py: Remove.
14009
14010 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14011
14012         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14013         NULL. Initialize tpprev to NULL instead of assigning it
14014         to NULL on the next statement.
14015         * windows-nat.c (windows_delete_thread): Remove check for
14016         main_thread_id before printing thread exit notifications.
14017         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14018         Remove thread ID check against main_thread_id.
14019         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14020         windows_delete_thread.
14021         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14022
14023 2019-01-04  Tom Tromey  <tom@tromey.com>
14024
14025         * compile/compile.c (_initialize_compile): Use upper case for
14026         metasyntactic variables.
14027         * symmisc.c (_initialize_symmisc): Use upper case for
14028         metasyntactic variables.
14029         * psymtab.c (_initialize_psymtab): Use upper case for
14030         metasyntactic variables.
14031         * demangle.c (demangle_command): Use upper case for metasyntactic
14032         variables.
14033         (_initialize_demangler): Likewise.
14034         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14035         variables.
14036
14037 2019-01-03  Tom Tromey  <tom@tromey.com>
14038
14039         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14040
14041 2019-01-03  Tom Tromey  <tom@tromey.com>
14042
14043         * python/py-symtab.c (salpy_str): Update.
14044         (struct salpy_sal_object) <symtab>: Now a PyObject.
14045         (salpy_dealloc): Update.
14046         (del_objfile_sal): Use gdbpy_ref.
14047
14048 2019-01-03  Tom Tromey  <tom@tromey.com>
14049
14050         * python/py-type.c (convert_field): Use new_reference.  Return
14051         gdbpy_ref.
14052         (make_fielditem): Return gdbpy_ref.
14053         (typy_fields): Update.
14054         (typy_getitem): Update.
14055         (field_name): Return gdbpy_ref.  Use new_reference.
14056         (typy_iterator_iternext): Update.
14057
14058 2019-01-03  Tom Tromey  <tom@tromey.com>
14059
14060         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14061
14062 2019-01-03  Tom Tromey  <tom@tromey.com>
14063
14064         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14065         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14066         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14067         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14068         (pspy_set_type_printers): Likewise.
14069         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14070         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14071         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14072         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14073         (objfpy_set_type_printers): Likewise.
14074
14075 2019-01-03  Tom Tromey  <tom@tromey.com>
14076
14077         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14078         (gdbpy_print_stack): Use gdbpy_err_fetch.
14079         * python/python-internal.h (class gdbpy_err_fetch): New class.
14080         (class gdbpy_enter) <m_error_type, m_error_value,
14081         m_error_traceback>: Remove.
14082         <m_error>: New member.
14083         (gdbpy_exception_to_string): Don't declare.
14084         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14085         * python/py-value.c (convert_value_from_python): Use
14086         gdbpy_err_fetch.
14087         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14088         gdbpy_exception_to_string.
14089         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14090         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14091         gdbpy_err_fetch.
14092
14093 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14094
14095         * linux-nat.c (delete_lwp_cleanup): Delete.
14096         (struct lwp_deleter): New struct.
14097         (lwp_info_up): New typedef.
14098         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14099         lwp_info_up.
14100
14101 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14102
14103         * linux-fork.c (class scoped_switch_fork_info): New class.
14104         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14105
14106 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14107
14108         * valops.c (find_overload_match): Remove use of null_cleanup, and
14109         calls to do_cleanups.
14110
14111 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14112
14113         * compile/compile-cplus-types.c
14114         (compile_cplus_instance::decl_name): Handle changes to
14115         cp_func_name.
14116         * cp-support.c (cp_func_name): Update header comment, update
14117         return type.
14118         * cp-support.h (cp_func_name): Update return type in declaration.
14119         * valops.c (find_overload_match): Move temp_func local to top
14120         level of function and change its type.  Use temp_func to hold and
14121         delete temporary string obtained from cp_func_name.
14122
14123 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14124
14125         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14126         gdb::char_vector, remove cleanup, and update uses of `msg`.
14127
14128 2019-01-03  Jim Wilson  <jimw@sifive.com>
14129
14130         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14131
14132 2019-01-02  Tom Tromey  <tom@tromey.com>
14133
14134         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14135         (tdesc_parse_xml): Remove cleanups.
14136         * target-descriptions.h (make_cleanup_free_target_description):
14137         Don't declare.
14138         (target_desc_deleter): New struct.
14139         (target_desc_up): New typedef.
14140         * target-descriptions.c (target_desc_deleter::operator()): Rename
14141         from free_target_description.
14142         (make_cleanup_free_target_description): Remove.
14143
14144 2019-01-02  Tom Tromey  <tom@tromey.com>
14145
14146         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14147         constructor, destructor.
14148         (linespec_parser): Remove typedef.
14149         (~linespec_parser): Rename from linespec_parser_delete.
14150         (linespec_lex_to_end, linespec_complete_label)
14151         (linespec_complete): Update.
14152         (decode_line_full): Remove cleanups.
14153         (decode_line_1): Update.
14154
14155 2019-01-02  Tom Tromey  <tom@tromey.com>
14156
14157         * python/python-internal.h (inferior_to_inferior_object): Change
14158         return type.
14159         * python/py-exitedevent.c (create_exited_event_object): Update.
14160         * python/py-inferior.c (inferior_to_inferior_object): Return
14161         gdbpy_ref.
14162         (python_new_inferior, python_inferior_deleted)
14163         (thread_to_thread_object, delete_thread_object)
14164         (build_inferior_list, gdbpy_selected_inferior): Update.
14165         * python/py-infthread.c (create_thread_object): Update.  Also fail
14166         if inferior_to_inferior_object fails.
14167
14168 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14169
14170         * inferior.h (class inferior) <displaced_step_state>: New field.
14171         * infrun.h (struct displaced_step_state): Move here from
14172         infrun.c.  Initialize fields, add constructor.
14173         <inf>: Remove field.
14174         <reset>: New method.
14175         * infrun.c (struct displaced_step_inferior_state): Move to
14176         infrun.h.
14177         (displaced_step_inferior_states): Remove.
14178         (get_displaced_stepping_state): Adust.
14179         (displaced_step_in_progress_any_inferior): Adjust.
14180         (displaced_step_in_progress_thread): Adjust.
14181         (displaced_step_in_progress): Adjust.
14182         (add_displaced_stepping_state): Remove.
14183         (get_displaced_step_closure_by_addr): Adjust.
14184         (remove_displaced_stepping_state): Remove.
14185         (infrun_inferior_exit): Call displaced_step_state.reset.
14186         (use_displaced_stepping): Don't check for NULL.
14187         (displaced_step_prepare_throw): Call
14188         get_displaced_stepping_state.
14189         (displaced_step_fixup): Don't check for NULL.
14190         (prepare_for_detach): Don't check for NULL.
14191
14192 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14193
14194         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14195          in case of call that did not complete.
14196
14197 2019-01-02  Andrey Utkin  <autkin@undo.io>
14198
14199         * symfile.c (find_separate_debug_file): Fix search of debug files for
14200         remote debuggee.
14201
14202 2019-01-02  Tom Tromey  <tom@tromey.com>
14203
14204         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14205         indentation.
14206         * python/py-frame.c (frapy_older): Remove cast.
14207         (frapy_newer): Likewise.
14208         * python/py-breakpoint.c (local_setattro): Remove cast.
14209         * python/py-arch.c (archpy_name): Remove local variable.
14210         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14211
14212 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14213
14214         * unittests/basic_string_view/element_access/char/empty.cc:
14215         Fix year range in copyright header.
14216
14217 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14218
14219         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14220         Delete.
14221         <operator==>: Update with for removed field.
14222         <hash>: Likewise.
14223         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14224         <isa_features>: ...this.
14225         <abi_features>: New field.
14226         (riscv_isa_flen): Update comment.
14227         (riscv_abi_xlen): New declaration.
14228         (riscv_abi_flen): New declaration.
14229         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14230         isa_features.
14231         (riscv_abi_xlen): New function.
14232         (riscv_isa_flen): Update to get answer from isa_features.
14233         (riscv_abi_flen): New function.
14234         (riscv_has_fp_abi): Update to get answer from abi_features.
14235         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14236         xlen and flen.
14237         (riscv_call_info) <xlen, flen>: Update comment.
14238         (riscv_call_arg_struct): Remove invalid assertions
14239         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14240         is removed.
14241         (riscv_gdbarch_init): Gather isa features and abi features
14242         separately, ensure both match on the gdbarch when reusing an old
14243         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14244         a target with 64-bit float hardware.
14245
14246 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14247
14248         * source.c (search_command_helper): Stop reverse search
14249         when line 1 has been searched.
14250
14251 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14252
14253         * record-full.c (record_full_base_target::close): Rewrite
14254         record_full_core_buf_list free logic.
14255
14256 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14257
14258         * break-catch-syscall.c (print_one_catch_syscall): xfree
14259         the last text.
14260
14261 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14262
14263         * top.c (print_gdb_version): Update Copyright year in version
14264         message.
14265
14266 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14267
14268         Update copyright year range in all GDB files.
14269
14270 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14271
14272         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14273
14274 For older changes see ChangeLog-2018.
14275 \f
14276 Local Variables:
14277 mode: change-log
14278 left-margin: 8
14279 fill-column: 74
14280 version-control: never
14281 coding: utf-8
14282 End:
14283