gdb/ChangeLog

   1 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * minsyms.c (compare_minimal_symbols): Rename to...
   4         (minimal_symbol_is_less_than): ...this, and adjust to STL
   5         conventions (return bool, take arguments as references)
   6         (minimal_symbol_reader::install): Call std::sort instead
   7         of qsort.
   8
   9 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
  10
  11         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
  12         hash and why.
  13         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
  14         msymbol_hash, msymbol_demangled_hash>: Improve comments.
  15
  16 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
  17
  18         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
  19         * psympriv.h (add_psymbol_to_list): Move comment here and update
  20         it.
  21
  22 2019-09-29  Tom de Vries  <tdevries@suse.de>
  23
  24         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
  25         Use $tmpdir/$(basename "$output_file").dwz instead of
  26         "${output_file}.dwz".
  27
  28 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
  29
  30         PR gdb/25045
  31         * hppa-linux-nat.c: Include gdbarch.h.
  32
  33 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
  34
  35         * blockframe.c (find_pc_partial_function): Change return type to bool.
  36         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
  37         * minsyms.c (in_gnu_ifunc_stub): Likewise.
  38         (stub_gnu_ifunc_resolve_name): Likewise.
  39         * symtab.c (compare_filenames_for_search): Likewise.
  40         (compare_glob_filenames_for_search): Likewise.
  41         (matching_obj_sections): Likewise.
  42         (symbol_matches_domain): Likewise.
  43         (find_line_symtab): Change out param EXACT_MATCH to bool *.
  44         (find_line_pc): Change return type to bool.
  45         (find_line_pc_range): Likewise.
  46         (producer_is_realview): Likewise.
  47         * symtab.h (symbol_matches_domain): Likewise.
  48         (find_pc_partial_function): Likewise.
  49         (find_pc_line_pc_range): Likewise.
  50         (in_gnu_ifunc_stub): Likewise.
  51         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
  52         (find_line_pc): Likewise.
  53         (find_line_pc_range): Likewise.
  54         (matching_obj_sections): Likewise.
  55         (find_line_symtab): Change out parameter to bool.
  56         (producer_is_realview): Change return type to bool.
  57         (compare_filenames_for_search): Likewise.
  58         (compare_glob_filenames_for_search): Likewise.
  59
  60 2019-09-26  Tom Tromey  <tom@tromey.com>
  61
  62         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
  63         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
  64         * gdb_usleep.h: Remove.
  65         * gdb_usleep.c: Remove.
  66         * utils.c: Don't include gdb_usleep.h.
  67
  68 2019-09-26  Tom Tromey  <tromey@adacore.com>
  69
  70         * python/py-type.c (type_to_type_object): Call check_typedef
  71         for stub types.
  72
  73 2019-09-26  Tom Tromey  <tom@tromey.com>
  74
  75         * utils.h (initialize_utils): Don't declare.
  76         * top.c (gdb_init): Don't call initialize_utils.
  77         * utils.c (initialize_utils): Remove.  Move contents...
  78         (_initialize_utils): ... here.
  79
  80 2019-09-25  Tom Tromey  <tom@tromey.com>
  81
  82         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
  83         * utils.h (make_hex_string): Don't declare.
  84         * utils.c (make_hex_string): Remove.
  85
  86 2019-09-24  Tom de Vries  <tdevries@suse.de>
  87
  88         PR gdb/23815
  89         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
  90         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
  91
  92 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
  93
  94         * NEWS: Mention new simulator port for PRU.
  95
  96 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
  97
  98         * ada-exp.y (write_object_remaining): Update.
  99         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 100         and eliminate the static buffer.
 101         (ada_decode_symbol): Update.
 102         (ada_la_decode): Update.
 103         (ada_sniff_from_mangled_name): Update.
 104         (is_valid_name_for_wild_match): Update.
 105         (ada_lookup_name_info::matches): Update and simplify.
 106         (name_matches_regex): Update.
 107         (ada_add_global_exceptions): Update.
 108         * ada-lang.h (ada_decode): Update signature.
 109         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 110         * dwarf-index-write.c (debug_names::insert): Update.
 111
 112 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 113
 114         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 115         formatting.
 116
 117 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 118
 119         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 120         Change "nonzero" to "true" in documentation.
 121
 122 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 123
 124         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 125         (_initialize_darwin_solib): Don't set
 126         darwin_so_ops.lookup_lib_global_symbol.
 127         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 128         set_gdbarch_iterate_over_objfiles_in_search_order.
 129         (elf_lookup_lib_symbol): Rename to...
 130         (svr4_iterate_over_objfiles_in_search_order): this, and update
 131         to iterate semantics.
 132         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 133         * solib.c (solib_global_lookup): Remove.
 134         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 135         (solib_global_lookup): Remove.
 136         * symtab.c (lookup_global_or_static_symbol): Remove call to
 137         solib_global_lookup.
 138
 139 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 140
 141         * NEWS: Move entries about default MI version now being
 142         version 3, and about the GDB/MI fix for multi-location
 143         breakpoints to the "since GDB 8.3" section.
 144
 145 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 146
 147         GDB 8.3.1 released.
 148
 149 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 150
 151         * NEWS: Mention that Cell/B.E. debugging support was removed.
 152         * MAINTAINERS: Remove spu target.
 153
 154         * config/djgpp/fnchange.lst: Remove entries for removed files.
 155
 156         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 157         spu-multiarch.o, and spu-tdep.o.
 158         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 159         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 160         spu-multiarch.c, and spu-tdep.c.
 161         * spu-linux-nat.c: Remove file.
 162         * spu-multiarch.c: Remove file.
 163         * spu-tdep.c: Remove file.
 164         * spu-tdep.h: Remove file.
 165         * solib-spu.c: Remove file.
 166         * solib-spu.h: Remove file.
 167
 168         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 169         * configure.nat (spu-linux): Remove.
 170         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 171         solib-multiarch.o from gdb_target_obs.
 172         (spu*-*-*): Remove.
 173
 174         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 175         feature flag.
 176         (ppc_linux_no_features): Update.
 177         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 178         Cell/B.E. support.
 179         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 180         (tdesc_powerpc_cell64l): Likewise.
 181         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 182         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 183         Cell/B.E. support.
 184         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 185         Do not include "features/rs6000/powerpc-cell32l.c" or
 186         "features/rs6000/powerpc-cell64l.c".
 187         (ppc_linux_spu_section): Remove.
 188         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 189         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 190         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 191         (ppc_linux_spe_context_lookup): Remove.
 192         (ppc_linux_spe_context_inferior_created): Remove.
 193         (ppc_linux_spe_context_solib_loaded): Remove.
 194         (ppc_linux_spe_context_solib_unloaded): Remove.
 195         (ppc_linux_spe_context): Remove.
 196         (struct ppu2spu_cache): Remove.
 197         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 198         (struct ppu2spu_data): Remove.
 199         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 200         ppu2spu_unwind): Remove.
 201         (ppc_linux_init_abi): Remove Cell/B.E. support.
 202         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 203
 204         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 205         (rs6000/powerpc-cell64l-expedite): Likewise
 206         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 207         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 208         rs6000/powerpc-cell64l.xml.
 209         * features/rs6000/powerpc-cell32l.xml: Remove.
 210         * features/rs6000/powerpc-cell64l.xml: Likewise.
 211         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 212         * features/rs6000/powerpc-cell64l.c: Likewise.
 213         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 214         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 215         * regformats/reg-spu.dat: Remove.
 216
 217         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 218         * corelow.c (struct spuid_list): Remove.
 219         (add_to_spuid_list): Remove.
 220         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 221         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 222         (remote_protocol_features): Remove associated entries.
 223         (_initialize_remote): No longer initialize them.
 224         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 225         * linux-nat.c (SPUFS_MAGIC): Remove.
 226         (linux_proc_xfer_spu): Remove.
 227         (spu_enumerate_spu_ids): Remove.
 228         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 229         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 230         (linux_make_corefile_notes): No longer call it.
 231
 232         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 233         (cooked_write_test): Likewise.
 234
 235 2019-09-20  Tom Tromey  <tom@tromey.com>
 236
 237         * NEWS: Mention case-sensitivity of TUI commands.
 238         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 239         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 240         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 241
 242 2019-09-20  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-source.c (tui_source_window::set_contents): Use
 245         make_unique_xstrdup.
 246         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 247         make_unique_xstrdup.
 248
 249 2019-09-20  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui-data.c: Remove separator comments.
 252         * tui/tui-layout.c: Remove separator comments.
 253         * tui/tui-win.c: Remove separator comments.
 254         * tui/tui-wingeneral.c: Remove separator comments.
 255
 256 2019-09-20  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui.h (strcat_to_buf): Don't declare.
 259         * tui/tui.c (strcat_to_buf): Remove.
 260
 261 2019-09-20  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 264         from "fullname".
 265         * tui/tui-source.c (tui_source_window::set_contents)
 266         (tui_source_window::location_matches_p)
 267         (tui_source_window::maybe_update): Update.
 268
 269 2019-09-20  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 272         Update.
 273         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 274         prefix.
 275         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 276         (tui_data_window::line_from_reg_element_no)
 277         (tui_data_window::first_reg_element_no_inline)
 278         (tui_data_window::show_registers)
 279         (tui_data_window::show_register_group)
 280         (tui_data_window::display_registers_from)
 281         (tui_data_window::display_registers_from_line)
 282         (tui_data_window::first_data_item_displayed)
 283         (tui_data_window::delete_data_content_windows)
 284         (tui_data_window::erase_data_content)
 285         (tui_data_window::do_scroll_vertical)
 286         (tui_data_window::refresh_window)
 287         (tui_data_window::check_register_values): Update.
 288
 289 2019-09-20  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 292         (struct tui_locator_window) <full_name, proc_name>: Now
 293         std::string.
 294         * tui/tui-stack.c (tui_locator_window::make_status_line)
 295         (tui_locator_window::set_locator_fullname)
 296         (tui_locator_window::set_locator_info): Update.
 297         * tui/tui-source.c (tui_source_window::set_contents)
 298         (tui_source_window::showing_source_p): Update.
 299
 300 2019-09-20  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 303         Don't call tui_locator_win_info_ptr.
 304
 305 2019-09-20  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 308
 309 2019-09-20  Tom Tromey  <tom@tromey.com>
 310
 311         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 312         height for locator.
 313         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 314         * tui/tui-layout.c (show_source_disasm_command, show_data)
 315         (show_source_or_disasm_and_command): Use 1 as height for locator.
 316
 317 2019-09-20  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui.c (tui_enable): Update.
 320         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 321         Update.
 322         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 323         Update.
 324         * tui/tui-data.c (win_resized): Now bool.
 325         (tui_win_resized): Return bool.
 326         (tui_set_win_resized_to): Accept a bool.
 327
 328 2019-09-20  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 331         Change type of "refresh_values_only".
 332         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 333         type of "refresh_values_only".
 334
 335 2019-09-20  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 338         std::string.
 339         (tui_disassemble): Add "pos" parameter.
 340         (tui_disasm_window::set_contents): Simplify.
 341
 342 2019-09-20  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-winsource.h (struct tui_source_window_base)
 345         <show_source_content>: Now private.
 346         * tui/tui-winsource.c
 347         (tui_source_window_base::show_source_content): Don't handle empty
 348         content case.
 349
 350 2019-09-20  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-layout.c (show_source_disasm_command)
 353         (show_source_or_disasm_and_command): Don't call
 354         show_source_content.
 355
 356 2019-09-20  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 359         Declare.
 360         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 361         from tui_make_status_line.
 362         (tui_locator_window::rerender): Update.
 363
 364 2019-09-20  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 367         (tui_locator_window::rerender): Update.
 368
 369 2019-09-20  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-winsource.h (struct tui_source_window_base)
 372         <~tui_source_window_base>: Don't declare.
 373         <fullname>: Remove.
 374         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 375         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 376         member.
 377         * tui/tui-source.c (tui_source_window::set_contents): Update.
 378         (tui_source_window::location_matches_p)
 379         (tui_source_window::maybe_update): Update.
 380
 381 2019-09-20  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-winsource.h (~tui_source_element): Remove.
 384         (tui_source_element): Update.
 385         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 386         * tui/tui-winsource.c (tui_show_source_line): Update.
 387         * tui/tui-source.c (tui_source_window::set_contents): Update.
 388         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 389
 390 2019-09-20  Tom Tromey  <tom@tromey.com>
 391
 392         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 393         declare.
 394         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 395         tui_clear_source_windows_detail.
 396         * tui/tui-winsource.h (struct tui_source_window_base)
 397         <clear_detail>: Don't declare.
 398         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 399         Remove.
 400         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 401
 402 2019-09-20  Tom Tromey  <tromey@adacore.com>
 403
 404         PR ada/24919:
 405         * block.c (contained_in): Fix final return value.
 406
 407 2019-09-20  Alan Modra  <amodra@gmail.com>
 408
 409         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 410         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 411         (read_indirect_string_from_dwz): Use bfd accessor.
 412         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 413         * machoread.c (macho_symfile_read_all_oso): Likewise.
 414         * solib.c (solib_bfd_open): Likewise.
 415
 416 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 417
 418         * eval.c: Move declaration of overload_resolution to...
 419         * value.h: ...here.
 420
 421 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 422
 423         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 424         * arm-linux-tdep.c: Likewise.
 425         * arm-nbsd-nat.c: Likewise.
 426         * arm-tdep.h: Declare arm_apcs_32.
 427         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 428
 429 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 430
 431         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 432         * dwarf2read.h: Declare dwarf_always_disassemble.
 433
 434 2019-09-19  Tom de Vries  <tdevries@suse.de>
 435
 436         PR gdb/25009
 437         * source-cache.c (source_cache::ensure): Catch exception thrown during
 438         construction of the highlighter.
 439
 440 2019-09-18  Alan Modra  <amodra@gmail.com>
 441
 442         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 443         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 444         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 445         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 446         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 447         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 448         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 449         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 450         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 451         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 452         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 453         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 454         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 455         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 456         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 457         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 458         * mi/mi-interp.c: Update throughout for bfd section macro and
 459         function changes.
 460         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 461         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 462
 463 2019-09-18  Tom Tromey  <tom@tromey.com>
 464
 465         * NEWS: Add entry.
 466         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 467         call rl_initialize.
 468         (tui_enable): Do not call rl_initialize.
 469
 470 2019-09-18  Christian Groessler  <chris@groessler.org>
 471
 472         * alpha-linux-nat.c: Include gdbarch.h.
 473
 474 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 475
 476         * ui-file.c: Include cli/cli-style.h.
 477         (term_cli_styling): Remove cli_styling declaration.
 478
 479 2019-09-18  Alan Modra  <amodra@gmail.com>
 480
 481         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 482         to bfd_asymbol_section.
 483
 484 2019-09-18  Alan Modra  <amodra@gmail.com>
 485
 486         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 487         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 488         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 489
 490 2019-09-18  Alan Modra  <amodra@gmail.com>
 491
 492         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 493         * spu-linux-nat.c (spu_bfd_open): Likewise.
 494
 495 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 496
 497         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 498         to bool to match definition in dwarf2read.c.
 499
 500 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 501
 502         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 503         (print_signatures): Likewise.
 504         (trust_pad_over_xvs): Likewise.
 505         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 506         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 507         * arm-linux-nat.c (arm_apcs_32): Likewise.
 508         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 509         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 510         * arm-tdep.c (arm_debug): Likewise.
 511         (arm_apcs_32): Likewise.
 512         * auto-load.c (debug_auto_load): Likewise.
 513         (auto_load_gdb_scripts): Likewise.
 514         (global_auto_load): Likewise.
 515         (auto_load_local_gdbinit): Likewise.
 516         (auto_load_local_gdbinit_loaded): Likewise.
 517         * auto-load.h (global_auto_load): Likewise.
 518         (auto_load_local_gdbinit): Likewise.
 519         (auto_load_local_gdbinit_loaded): Likewise.
 520         * breakpoint.c (disconnected_dprintf): Likewise.
 521         (breakpoint_proceeded): Likewise.
 522         (automatic_hardware_breakpoints): Likewise.
 523         (always_inserted_mode): Likewise.
 524         (target_exact_watchpoints): Likewise.
 525         (_initialize_breakpoint): Update.
 526         * breakpoint.h (target_exact_watchpoints): Change to bool.
 527         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 528         * cli/cli-cmds.c (trace_commands): Likewise.
 529         * cli/cli-cmds.h (trace_commands): Likewise.
 530         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 531         to bool*.
 532         * cli/cli-logging.c (logging_overwrite): Change to bool.
 533         (logging_redirect): Likewise.
 534         (debug_redirect): Likewise.
 535         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 536         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 537         to bool.
 538         <boolean_option_def>: Update.
 539         (struct flag_option_def): Change default type of Context to bool
 540         from int.
 541         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 542         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 543         (get_setshow_command_value_string): Likewise.
 544         * cli/cli-style.c (cli_styling): Change to bool.
 545         (source_styling): Likewise.
 546         * cli/cli-style.h (source_styling): Likewise.
 547         (cli_styling): Likewise.
 548         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 549         to bool.
 550         * command.h (var_types): Update comment.
 551         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 552         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 553         bool.
 554         (debug_compile_cplus_scopes): Likewise.
 555         * compile/compile-internal.h (compile_debug): Likewise.
 556         * compile/compile.c (compile_debug): Likewise.
 557         (struct compile_options) <raw>: Likewise.
 558         * cp-support.c (catch_demangler_crashes): Likewise.
 559         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 560         (usr_cmd_cris_dwarf2_cfi): Likewise.
 561         * csky-tdep.c (csky_debug): Likewise.
 562         * darwin-nat.c (enable_mach_exceptions): Likewise.
 563         * dcache.c (dcache_enabled_p): Likewise.
 564         * defs.h (info_verbose): Likewise.
 565         * demangle.c (demangle): Likewise.
 566         (asm_demangle): Likewise.
 567         * dwarf-index-cache.c (debug_index_cache): Likewise.
 568         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 569         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 570         * dwarf2read.c (check_physname): Likewise.
 571         (use_deprecated_index_sections): Likewise.
 572         (dwarf_always_disassemble): Likewise.
 573         * eval.c (overload_resolution): Likewise.
 574         * event-top.c (set_editing_cmd_var): Likewise.
 575         (exec_done_display_p): Likewise.
 576         * event-top.h (set_editing_cmd_var): Likewise.
 577         (exec_done_display_p): Likewise.
 578         * exec.c (write_files): Likewise.
 579         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 580         (debug_fbsd_nat): Likewise.
 581         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 582         Likewise.
 583         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 584         <backtrace_past_entry> Likewise.
 585         * gdb-demangle.h (demangle): Likewise.
 586         (asm_demangle): Likewise.
 587         * gdb_bfd.c (bfd_sharing): Likewise.
 588         * gdbcore.h (write_files): Likewise.
 589         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 590         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 591         * gdbthread.h (print_thread_events): Likewise.
 592         * gdbtypes.c (opaque_type_resolution): Likewise.
 593         (strict_type_checking): Likewise.
 594         * gnu-nat.c (gnu_debug_flag): Likewise.
 595         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 596         * guile/scm-param.c (pascm_variable): Add boolval.
 597         (add_setshow_generic): Update.
 598         (pascm_param_value): Update.
 599         (pascm_set_param_value_x): Update.
 600         * hppa-tdep.c (hppa_debug): Change to bool..
 601         * infcall.c (may_call_functions_p): Likewise.
 602         (coerce_float_to_double_p): Likewise.
 603         (unwind_on_signal_p): Likewise.
 604         (unwind_on_terminating_exception_p): Likewise.
 605         * infcmd.c (startup_with_shell): Likewise.
 606         * inferior.c (print_inferior_events): Likewise.
 607         * inferior.h (startup_with_shell): Likewise.
 608         (print_inferior_events): Likewise.
 609         * infrun.c (step_stop_if_no_debug): Likewise.
 610         (detach_fork): Likewise.
 611         (debug_displaced): Likewise.
 612         (disable_randomization): Likewise.
 613         (non_stop): Likewise.
 614         (non_stop_1): Likewise.
 615         (observer_mode): Likewise.
 616         (observer_mode_1): Likewise.
 617         (set_observer_mode): Update.
 618         (sched_multi): Change to bool.
 619         * infrun.h (debug_displaced): Likewise.
 620         (sched_multi): Likewise.
 621         (step_stop_if_no_debug): Likewise.
 622         (non_stop): Likewise.
 623         (disable_randomization): Likewise.
 624         * linux-tdep.c (use_coredump_filter): Likewise.
 625         (dump_excluded_mappings): Likewise.
 626         * linux-thread-db.c (auto_load_thread_db): Likewise.
 627         (check_thread_db_on_load): Likewise.
 628         * main.c (captured_main_1): Update.
 629         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 630         xx2_opt, boolean_opt>: Change to bool.
 631         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 632         * maint.c (maintenance_profile_p): Likewise.
 633         (per_command_time): Likewise.
 634         (per_command_space): Likewise.
 635         (per_command_symtab): Likewise.
 636         * memattr.c (inaccessible_by_default): Likewise.
 637         * mi/mi-main.c (mi_async): Likewise.
 638         (mi_async_1): Likewise.
 639         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 640         * nat/fork-inferior.h (startup_with_shell): Likewise.
 641         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 642         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 643         * nios2-tdep.c (nios2_debug): Likewise.
 644         * or1k-tdep.c (or1k_debug): Likewise.
 645         * parse.c (parser_debug): Likewise.
 646         * parser-defs.h (parser_debug): Likewise.
 647         * printcmd.c (print_symbol_filename): Likewise.
 648         * proc-api.c (procfs_trace): Likewise.
 649         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 650         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 651         (set_parameter_value): Update.
 652         (add_setshow_generic): Update.
 653         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 654         to bool*.
 655         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 656         int*.
 657         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 658         * record-btrace.c (record_btrace_target::store_registers): Update.
 659         * record-full.c (record_full_memory_query): Change to bool.
 660         (record_full_stop_at_limit): Likewise.
 661         * record-full.h (record_full_memory_query): Likewise.
 662         * remote-notif.c (notif_debug): Likewise.
 663         * remote-notif.h (notif_debug): Likewise.
 664         * remote.c (use_range_stepping): Likewise.
 665         (interrupt_on_connect): Likewise.
 666         (remote_break): Likewise.
 667         * ser-tcp.c (tcp_auto_retry): Likewise.
 668         * ser-unix.c (serial_hwflow): Likewise.
 669         * skip.c (debug_skip): Likewise.
 670         * solib-aix.c (solib_aix_debug): Likewise.
 671         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 672         (spu_auto_flush_cache_p): Likewise.
 673         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 674         Likewise.
 675         (struct info_print_options) <quiet>: Likewise.
 676         * symfile-debug.c (debug_symfile): Likewise.
 677         * symfile.c (auto_solib_add): Likewise.
 678         (separate_debug_file_debug): Likewise.
 679         * symfile.h (auto_solib_add): Likewise.
 680         (separate_debug_file_debug): Likewise.
 681         * symtab.c (basenames_may_differ): Likewise.
 682         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 683         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 684         (struct info_types_options) <quiet>: Likewise.
 685         * symtab.h (demangle): Likewise.
 686         (basenames_may_differ): Likewise.
 687         * target-dcache.c (stack_cache_enabled_1): Likewise.
 688         (code_cache_enabled_1): Likewise.
 689         * target.c (trust_readonly): Likewise.
 690         (may_write_registers): Likewise.
 691         (may_write_memory): Likewise.
 692         (may_insert_breakpoints): Likewise.
 693         (may_insert_tracepoints): Likewise.
 694         (may_insert_fast_tracepoints): Likewise.
 695         (may_stop): Likewise.
 696         (auto_connect_native_target): Likewise.
 697         (target_stop_and_wait): Update.
 698         (target_async_permitted): Change to bool.
 699         (target_async_permitted_1): Likewise.
 700         (may_write_registers_1): Likewise.
 701         (may_write_memory_1): Likewise.
 702         (may_insert_breakpoints_1): Likewise.
 703         (may_insert_tracepoints_1): Likewise.
 704         (may_insert_fast_tracepoints_1): Likewise.
 705         (may_stop_1): Likewise.
 706         * target.h (target_async_permitted): Likewise.
 707         (may_write_registers): Likewise.
 708         (may_write_memory): Likewise.
 709         (may_insert_breakpoints): Likewise.
 710         (may_insert_tracepoints): Likewise.
 711         (may_insert_fast_tracepoints): Likewise.
 712         (may_stop): Likewise.
 713         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 714         (make_thread_apply_all_options_def_group): Change argument from int*
 715         to bool*.
 716         (thread_apply_all_command): Update.
 717         (print_thread_events): Change to bool.
 718         * top.c (confirm): Likewise.
 719         (command_editing_p): Likewise.
 720         (history_expansion_p): Likewise.
 721         (write_history_p): Likewise.
 722         (info_verbose): Likewise.
 723         * top.h (confirm): Likewise.
 724         (history_expansion_p): Likewise.
 725         * tracepoint.c (disconnected_tracing): Likewise.
 726         (circular_trace_buffer): Likewise.
 727         * typeprint.c (print_methods): Likewise.
 728         (print_typedefs): Likewise.
 729         * utils.c (debug_timestamp): Likewise.
 730         (sevenbit_strings): Likewise.
 731         (pagination_enabled): Likewise.
 732         * utils.h (sevenbit_strings): Likewise.
 733         (pagination_enabled): Likewise.
 734         * valops.c (overload_resolution): Likewise.
 735         * valprint.h (struct value_print_options) <prettyformat_arrays,
 736         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 737         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 738         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 739         Likewise.
 740         * windows-nat.c (new_console): Likewise.
 741         (cygwin_exceptions): Likewise.
 742         (new_group): Likewise.
 743         (debug_exec): Likewise.
 744         (debug_events): Likewise.
 745         (debug_memory): Likewise.
 746         (debug_exceptions): Likewise.
 747         (useshell): Likewise.
 748         * windows-tdep.c (maint_display_all_tib): Likewise.
 749         * xml-support.c (debug_xml): Likewise.
 750
 751 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 752
 753         * source.c (prepare_path_for_appending): New function.
 754         (openp): Make use of new function.
 755         (find_and_open_source): Search for the compilation directory and
 756         source file as a relative path beneath the directory search path.
 757
 758 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 759
 760         * source-cache.c (source_cache::get_line_charpos): Catch
 761         exceptions and return false, this matches the behaviour documented
 762         in the header file.
 763
 764 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 765
 766         * ada-tasks.c (info_task): Remove quoting of the task's name.
 767
 768 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 769
 770         * symfile.c (auto_solib_add): Replace comment with a reference
 771         to the header file.
 772
 773 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 774
 775         * NEWS: Mention that gdb can now be compiled with Python 3
 776         on Windows.
 777
 778 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * maint.c (maint_print_section_data::maint_print_section_data):
 781         Force use of 'float log10 (float)' by casting the argument to
 782         float.
 783
 784 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 785
 786         * maint.c: Add 'cmath' include.
 787         (struct maint_print_section_data): New structure.
 788         (print_section_index): New function.
 789         (print_bfd_section_info): Add header comment, small whitespace
 790         cleanup, and update to call new print_section_index function.
 791         (print_objfile_section_info): Likewise.
 792         (maint_obj_section_from_bfd_section): New function.
 793         (print_bfd_section_info_maybe_relocated): New function.
 794         (maintenance_info_sections): Add header comment, always use
 795         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 796
 797 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 798
 799         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 800         inner scope, add check that the objfile has psymtabs before
 801         checking psymtabs_addrmap.
 802         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 803
 804 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 805
 806         * NEWS: Announce that Ada task names are now shown at more places,
 807         and between quotes (except in info task output).
 808         * gdb/ada-tasks.c (task_to_str): New function.
 809         (display_current_task_id): Call task_to_str.
 810         (task_command_1): Likewise.
 811         (print_ada_task_info): In non-mi mode, Properly align headers and data
 812         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 813
 814 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 815
 816         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 817         prstatus.pr_lwp.pr_info instead of making it up.
 818
 819 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 820
 821         * auto-load.c (auto_load_expand_dir_vars): Update.
 822         * defs.h (gdb_datadir): Change to std::string.
 823         (python_libdir): Likewise.
 824         (relocate_gdb_directory): Change return type to std::string.
 825         * guile/guile.c (gdbscm_data_directory): Update.
 826         (initialize_scheme_side): Update.
 827         * jit.c (jit_reader_dir): Change to std::string.
 828         (jit_reader_load_command): Update.
 829         * main.c (gdb_datadir): Change to std::string.
 830         (python_libdir): Likewise.
 831         (set_gdb_data_directory): Update.
 832         (relocate_path): Change to return std::string.
 833         (relocate_gdb_directory): Change to return std::string.
 834         (relocate_gdbinit_path_maybe_in_datadir): Update.
 835         (captured_main_1): Update.
 836         * python/python.c (do_start_initialization): Update.
 837         * top.c (show_gdb_datadir): Update.
 838         * xml-syscall.c (xml_init_syscalls_info): Update.
 839         (init_syscalls_info): Update.
 840
 841 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 842
 843         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 844         out of get_init_files.
 845         (get_init_files): Update.
 846
 847 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 848
 849         * main.c (get_init_files): Change to use std::string.
 850         (captured_main_1): Update.
 851         (print_gdb_help): Update.
 852
 853 2019-09-11  Ali Tamur  <tamur@google.com>
 854
 855         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 856         implementation.
 857
 858 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 859
 860         * dbxread.c (read_dbx_symtab): Update.
 861         * dwarf2read.c (load_partial_dies): Update.
 862         * mdebugread.c (parse_partial_symbols): Update.
 863         (handle_psymbol_enumerators): Update.
 864         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 865         * psymtab.c (add_psymbol_to_bcache): Likewise.
 866         (add_psymbol_to_list): Likewise.
 867         * symtab.c (symbol_set_names): Likewise.
 868         * symtab.h (symbol_set_names): Likewise.
 869         * xcoffread.c (scan_xcoff_symtab): Update.
 870
 871 2019-09-11  Tom Tromey  <tom@tromey.com>
 872
 873         * symfile-mem.c (symbol_file_add_from_memory): Use
 874         bfd_set_filename.
 875         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 876         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 877
 878 2019-09-10  Tom Tromey  <tromey@adacore.com>
 879
 880         * dwarf-index-write.c (write_psymbols): Extend error message.
 881         (debug_names::insert): Add Ada code.
 882         (debug_names::write_psymbols): Remove Ada check.
 883         (debug_names) <m_string_obstack>: New member.
 884         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 885         (gdb_index_symbol_name_matcher::matches): Remove.
 886         (mapped_index_base::find_name_components_bounds): Add "lang"
 887         parameter.
 888         (mapped_index_base::build_name_components): Also split names
 889         according to Ada syntax.
 890         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 891         type of "match_callback".
 892         (check_match, check_find_bounds_finds)
 893         (dw2_expand_symtabs_matching): Update.
 894         (dw2_debug_names_iterator): Add new constructor.
 895         (dw2_debug_names_map_matching_symbols): New function.
 896         (dw2_debug_names_expand_symtabs_matching): Update.
 897         (dwarf2_debug_names_functions): Use
 898         dw2_debug_names_map_matching_symbols.
 899
 900 2019-09-10  Tom Tromey  <tromey@adacore.com>
 901
 902         * dwarf2read.c (dw2_get_file_names_reader): Add the
 903         CU's file name to the results.
 904
 905 2019-09-10  Tom Tromey  <tromey@adacore.com>
 906
 907         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 908         map_matching_symbols.  Update.
 909         * dwarf2read.c (dw2_map_matching_symbols): Update.
 910         * psymtab.c (match_partial_symbol): Change type; update.
 911         (psym_map_matching_symbols): Likewise.
 912         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 913         type; update.
 914         * symfile.h (struct quick_symbol_functions)
 915         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 916         Remove "match".
 917
 918 2019-09-10  Tom Tromey  <tromey@adacore.com>
 919
 920         * psymtab.c (map_block): Remove.
 921         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 922         * symtab.c (iterate_over_symbols_terminated): New function.
 923         * symtab.c (iterate_over_symbols_terminated): Declare.
 924
 925 2019-09-10  Tom Tromey  <tromey@adacore.com>
 926
 927         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 928         * language.h (struct language_defn) <la_iterate_over_symbols>:
 929         Return bool.
 930         * symtab.c (iterate_over_symbols): Return bool.
 931         * symtab.h (iterate_over_symbols): Return bool.
 932
 933 2019-09-10  Tom Tromey  <tromey@adacore.com>
 934
 935         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 936         (add_nonlocal_symbols): Update.
 937         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 938         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 939         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 940         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 941         Change type of "callback".  Remove "data".
 942
 943
 944 2019-09-09  Ali Tamur  <tamur@google.com>
 945
 946         * dwarf2read.c (comp_unit_head): Update comment.
 947         (dwarf2_dwo_name): New function declaration.
 948         (dwarf_unit_type_name): New function declaration.
 949         (read_comp_unit_head): Add support for new compilation units,
 950         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 951         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 952         (currently named as "signature") in their header. Also clarify error
 953         messages.
 954         (lookup_dwo_id): New function. Returns the dwo id of the given
 955         compile unit.
 956         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 957         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 958         functions.
 959         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 960         (dwarf2_dwo_name): Get the dwo name if present.
 961         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 962         purposes.
 963
 964 2019-09-09  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 967
 968 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 969
 970         * python/python.c (do_start_initialization): Make progname_copy static,
 971         to avoid a leak report.
 972
 973 2019-09-08  Tom Tromey  <tom@tromey.com>
 974
 975         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 976
 977 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 978
 979         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 980         Change type to gdb::optional<block_enum>.
 981         (dw2_symtab_iter_init): Change block_index parameter type
 982         to gdb::optional<block_enum>.
 983         (dw2_lookup_symbol): Change block_index parameter
 984         type to block_enum.c
 985         (dw2_debug_names_lookup_symbol): Likewise.
 986         * psymtab.c (psym_lookup_symbol): Likewise.
 987         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 988         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 989         Likewise.
 990
 991 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 992
 993         * defs.h (relocate_gdb_directory): Change int to bool in
 994         signature and rename flag to relocatable.
 995         * main.c (relocate_path): Likewise.
 996         (relocate_gdb_directory): Likewise.
 997
 998 2019-09-06  Alan Modra  <amodra@gmail.com>
 999
1000         * coffread.c (coff_symfile_read): Constify filename variable.
1001         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1002         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1003         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1004         * solib.c (reload_shared_libraries_1): Likewise.
1005         * symfile.c (reread_symbols): Likewise.
1006         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1007         * solib-darwin.c (darwin_bfd_open): Likewise.
1008         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1009
1010 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1011
1012         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1013         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1014
1015 2019-09-03  Tom Tromey  <tromey@adacore.com>
1016
1017         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1018         types.
1019         (has_negatives): Unbias a range type bound.
1020         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1021         * gdbtypes.c (operator==): Handle new field.
1022         (create_range_type): Add "bias" parameter.
1023         (create_static_range_type, resolve_dynamic_range): Update.
1024         * gdbtypes.h (struct range_bounds) <bias>: New member.
1025         (create_range_type): Add bias parameter.
1026         * printcmd.c (print_scalar_formatted): Unbias range types.
1027         * value.c (unpack_long): Unbias range types.
1028         (pack_long): Bias range types.
1029
1030 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1031
1032         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1033         probe arguments.
1034
1035 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1036
1037         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1038         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1039         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1040         (compile_probe_arg): Likewise.
1041         * probe.h (get_argument_count): Likewise.
1042         * solib-svr4.c (solib_event_probe_action): Likewise.
1043         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1044
1045 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1046
1047         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1048         code to here...
1049         (svr4_create_solib_event_breakpoints): ...from here.
1050
1051 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1052
1053         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1054         suffix from warning message.
1055
1056 2019-08-30  Tom Tromey  <tom@tromey.com>
1057
1058         * tui/tui-winsource.h (struct tui_source_window_base)
1059         <refresh_all>: Don't declare.
1060         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1061         Remove.
1062         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1063         tui_show_locator_content.
1064         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1065         declare.
1066         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1067         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1068         declare.
1069
1070 2019-08-30  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1073
1074 2019-08-30  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1077         Remove unnecessary forward declarations.
1078
1079 2019-08-30  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1082         rerender.
1083         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1084         tui_show_locator_content.
1085
1086 2019-08-30  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1089         (tui_locator_window::rerender): Rewrite using body of previous
1090         tui_show_locator_content.
1091
1092 2019-08-30  Tom Tromey  <tom@tromey.com>
1093
1094         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1095         set_locator_fullname>: New methods.
1096         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1097         Rename from tui_set_locator_fullname.
1098         (tui_locator_window::set_locator_info): Rename from
1099         tui_set_locator_info.  Return bool.
1100         (tui_update_locator_fullname, tui_show_frame_info): Update.
1101
1102 2019-08-30  Tom Tromey  <tom@tromey.com>
1103
1104         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1105
1106 2019-08-30  Tom Tromey  <tom@tromey.com>
1107
1108         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1109         call touchwin.
1110
1111 2019-08-30  Tom Tromey  <tom@tromey.com>
1112
1113         * tui/tui-wingeneral.c (box_win): Assume win_info and
1114         win_info->handle cannot be NULL.
1115
1116 2019-08-30  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1119         refresh_window>: Declare.
1120         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1121         resize.
1122         (tui_data_item_window::rerender): Rename from
1123         tui_display_register.
1124         (tui_data_item_window::refresh_window): New method.
1125         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1126         no-op.
1127
1128 2019-08-30  Tom Tromey  <tom@tromey.com>
1129
1130         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1131         regs_column_count, current_group>: Move later.  Now private.
1132         <get_current_group>: New method.
1133         * tui/tui-regs.c (tui_reg_command): Update.
1134         * tui/tui-layout.c (tui_set_layout): Update.
1135
1136 2019-08-30  Tom Tromey  <tom@tromey.com>
1137
1138         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1139         (tui_data_window::rerender): Don't call
1140         check_and_display_highlight_if_needed.
1141         (tui_data_window::refresh_all): Remove call to
1142         erase_data_content.
1143
1144 2019-08-30  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1147         (tui_data_window::display_registers_from)
1148         (tui_data_window::display_reg_element_at_line)
1149         (tui_data_window::display_registers_from_line): Remove checks of
1150         "empty".
1151
1152 2019-08-30  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1155         Don't declare.
1156         * tui/tui-regs.c (tui_data_window::show_registers): Call
1157         rerender.
1158         (tui_data_window::rerender): Rename from display_all_data.
1159         (tui_data_window::rerender): Remove old implementation.
1160
1161 2019-08-30  Tom Tromey  <tom@tromey.com>
1162
1163         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1164         text.
1165         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1166
1167 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1168             Sergio Durigan Junior  <sergiodj@redhat.com>
1169
1170         PR win32/24284
1171         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1172
1173 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1174
1175         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1176         when searching for types.
1177
1178 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1179
1180         * f-lang.c (f_language_defn): Use f_print_typedef.
1181         * f-lang.h (f_print_typedef): Declare.
1182         * f-typeprint.c (f_print_typedef): Define.
1183
1184 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1185
1186         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1187
1188 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1189
1190         * cli/cli-utils.c (info_print_options_defs): Delete.
1191         (make_info_print_options_def_group): Delete.
1192         (extract_info_print_options): Delete.
1193         (info_print_command_completer): Delete.
1194         (info_print_args_help): Add extra parameter, and optionally
1195         include text about -n flag.
1196         * cli/cli-utils.h (struct info_print_options): Delete.
1197         (extract_info_print_options): Delete declaration.
1198         (info_print_command_completer): Delete declaration.
1199         (info_print_args_help): Add extra parameter, extend header
1200         comment.
1201         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1202         search_symbols.
1203         * stack.c (struct info_print_options): New type.
1204         (info_print_options_defs): New file scoped variable.
1205         (make_info_print_options_def_group): New static function.
1206         (info_print_command_completer): New static function.
1207         (info_locals_command): Update to use new local functions.
1208         (info_args_command): Likewise.
1209         (_initialize_stack): Add extra parameter to calls to
1210         info_print_args_help.
1211         * symtab.c (search_symbols): Add extra parameter, use this to
1212         possibly excluse non-debug symbols.
1213         (symtab_symbol_info): Add extra parameter, which is passed on to
1214         search_symbols.
1215         (struct info_print_options): New type.
1216         (info_print_options_defs): New file scoped variable.
1217         (make_info_print_options_def_group): New static function.
1218         (info_print_command_completer): New static function.
1219         (info_variables_command): Update to use local functions, and pass
1220         extra parameter through to symtab_symbol_info.
1221         (info_functions_command): Likewise.
1222         (info_types_command): Pass additional argument through to
1223         symtab_symbol_info.
1224         (rbreak_command): Pass extra argument to search_symbols.
1225         (_initialize_symtab): Add extra arguments for calls to
1226         info_print_args_help, and update help text for 'info variables',
1227         'whereis', and 'info functions' commands.
1228         * symtab.h (search_symbols): Add extra argument to declaration.
1229         * NEWS: Mention new flags.
1230
1231 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1232
1233         * symtab.c (lookup_static_symbol): Call the new function (and move
1234         it down to be next to lookup_global_symbol).
1235         (struct global_sym_lookup_data): Add block_enum member and rename to...
1236         (struct global_or_static_sym_lookup_data): ...this.
1237         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1238         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1239         (lookup_symbol_global_or_static_iterator_cb): ...this.
1240         (lookup_global_or_static_symbol): New function.
1241         (lookup_global_symbol): Call new function.
1242
1243 2019-08-26  Tom de Vries  <tdevries@suse.de>
1244
1245         PR c++/24852
1246         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1247         when pc_probe.prob == NULL.
1248
1249 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1250
1251         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1252         variable symbol_linkage to symbol_linkage_.
1253
1254 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1255
1256         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1257         represent whether the symbol is static, dynamic, or we don't
1258         know.
1259
1260 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1261
1262         * gdb/rx-tdep.c (rx_register_names): New.
1263         (rx_register_name): Delete.
1264         (rx_psw_type): Delete.
1265         (rx_fpsw_type): Delete.
1266         (rx_register_type): Delete.
1267         (rx_gdbarch_init): Convert target-descriptions.
1268         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1269         * gdb/features/Makefile: Add rx.xml.
1270         * gdb/features/rx.xml: New.
1271         * gdb/features/rx.c: Generated.
1272         * gdb/NEWS: Mention target description support.
1273
1274 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1275
1276         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1277         *slot_ptr.
1278
1279 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1280
1281         * configure.ac: Don't check for 'dlfcn.h' (moved to
1282         gdbsupport/common.m4).
1283         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1284         'gdbsupport/'.
1285         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1286         * compile/compile-c-support.c: Include
1287         'gdbsupport/gdb-dlfcn.h'.
1288         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1289         * gdb-dlfcn.c: Move to...
1290         * gdbsupport/gdb-dlfcn.c: ... here.
1291         * gdb-dlfcn.h: Move to...
1292         * gdbsupport/gdb-dlfcn.h: ... here.
1293
1294 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1295
1296         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1297         the offset field signed.
1298
1299 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1300
1301         * python/lib/gdb/__init__.py (_execute_file): New function.
1302         * python/python.c (python_run_simple_file): Call gdb._execute_file
1303         on Windows.
1304
1305 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1308         all uses as this was never set to anything but a zero value.
1309
1310 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1311
1312         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1313
1314 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1315
1316         * tui/tui-data.h (tui_gen_win_info): Add an =default
1317         move constructor, required by some GCC versions.
1318
1319 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1320
1321         * go32-nat.c (go32_sysinfo): Add hygon_p.
1322
1323 2019-08-20  Tom Tromey  <tom@tromey.com>
1324
1325         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1326         line_from_reg_element_no, first_reg_element_no_inline,
1327         display_all_data, delete_data_content_windows,
1328         erase_data_content>: Now private.
1329
1330 2019-08-20  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1333         (tui_unhighlight_win, tui_highlight_win)
1334         (tui_win_info::make_window): Update.
1335         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1336
1337 2019-08-20  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1340         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1341         (MAX_PID_WIDTH): Move to tui-stack.c.
1342         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1343         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1344         (MAX_PID_WIDTH): Move from tui-data.h.
1345
1346 2019-08-20  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1349         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1350         (box_win): Update.
1351         (tui_gen_win_info::make_window): Rename from tui_make_window.
1352         (tui_win_info::make_window): New method.
1353         (tui_gen_win_info::make_visible): Update.
1354         * tui/tui-source.c (tui_source_window::set_contents): Update.
1355         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1356         (tui_data_window::display_registers_from): Update.
1357         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1358         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1359         Declare.
1360         <can_box>: Remove.
1361         <title>: Remove.
1362         (struct tui_win_info) <make_window>: Declare.
1363         <can_box>: Now virtual.
1364         <title>: New member.
1365         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1366         * tui/tui-command.c (tui_cmd_window::resize): Update.
1367
1368 2019-08-20  Tom Tromey  <tom@tromey.com>
1369
1370         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1371         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1372         (tui_data_window::check_register_values): Update.
1373
1374 2019-08-20  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-regs.h (struct tui_data_window): Use
1377         DISABLE_COPY_AND_ASSIGN.
1378         <regs_content>: Change type, removing unique_ptr.
1379         <tui_data_window>: Add move constructor.
1380         * tui/tui-regs.c (tui_data_window::show_registers)
1381         (tui_data_window::show_register_group)
1382         (tui_data_window::display_registers_from)
1383         (tui_data_window::display_registers_from)
1384         (tui_data_window::first_data_item_displayed)
1385         (tui_data_window::delete_data_content_windows)
1386         (tui_data_window::rerender, tui_data_window::refresh_window)
1387         (tui_data_window::check_register_values): Update.
1388
1389 2019-08-20  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1392         show_register_group>: Declare.
1393         (tui_show_register_group): Don't declare.
1394         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1395         tui_show_registers.
1396         (tui_data_window::show_register_group): Rename from
1397         tui_show_register_group.
1398         (tui_data_window::check_register_values, tui_reg_command):
1399         Update.
1400         * tui/tui-layout.c (tui_set_layout): Update.
1401
1402 2019-08-20  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1405         Declare.
1406         (tui_check_register_values): Don't declare.
1407         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1408         from tui_check_register_values.
1409         * tui/tui-hooks.c (tui_register_changed): Update.
1410
1411 2019-08-20  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-regs.c (tui_reg_layout): Move later.
1414         (tui_show_registers): Don't enable TUI mode or change layout.
1415
1416 2019-08-20  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-regs.h (struct tui_data_item_window)
1419         <~tui_data_item_window>: Remove.
1420         <content>: Now a unique_xmalloc_ptr.
1421         * tui/tui-regs.c (tui_register_format): Return a
1422         unique_xmalloc_ptr.
1423         (tui_get_register): Update.
1424         (~tui_data_item_window): Remove.
1425         (tui_data_window::display_registers_from, tui_display_register):
1426         Update.
1427         * tui/tui-io.h (tui_expand_tabs): Update.
1428         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1429         Remove "col" parameter.
1430
1431 2019-08-20  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1434         field.
1435         * tui/tui-regs.c (~tui_data_item_window): Update.
1436
1437 2019-08-20  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1440         earlier.
1441
1442 2019-08-20  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1445
1446 2019-08-20  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-source.h (struct tui_source_window): Update.
1449         * tui/tui-regs.c (tui_show_registers): Update.
1450         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1451         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1452         (NO_REGS_STRING): Remove defines.
1453
1454 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1455
1456         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1457         unnecessary thread walk if remote doesn't support the packet.
1458
1459 2019-08-19  Tom Tromey  <tromey@adacore.com>
1460
1461         * python/py-value.c (value_has_field): Fix indentation.
1462
1463 2019-08-19  Tom Tromey  <tromey@adacore.com>
1464
1465         * printcmd.c (do_one_display, info_display_command): Update.
1466         * block.h (contained_in): Return bool.  Add allow_nested
1467         parameter.
1468         * block.c (contained_in): Return bool.  Add allow_nested
1469         parameter.
1470
1471 2019-08-19  Tom Tromey  <tom@tromey.com>
1472
1473         * configure: Rebuild.
1474         * configure.ac: Disallow the combination of -static-libstdc++ and
1475         source highlight.
1476         * source-cache.c (get_language_name): Handle rust.
1477         (source_cache::get_source_lines): Ignore highlighting exceptions.
1478
1479 2019-08-16  Tom Tromey  <tom@tromey.com>
1480
1481         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1482         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1483         (struct tui_source_window_base) <make_visible, refresh_window,
1484         resize>: Remove methods.
1485         <execution_info>: Remove field.
1486         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1487         (tui_show_source_line, tui_source_window_base)
1488         (~tui_source_window_base): Update.
1489         (tui_source_window_base::resize)
1490         (tui_source_window_base::make_visible)
1491         (tui_source_window_base::refresh_window): Remove.
1492         (tui_source_window_base::update_exec_info): Update.
1493         * tui/tui-source.c (tui_source_window::set_contents): Update.
1494         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1495
1496 2019-08-16  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1499         deprecated_query_hook.
1500
1501 2019-08-16  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1504         (tui_update_source_windows_with_line): Update.
1505         * tui/tui-source.h (struct tui_source_window)
1506         <show_symtab_source>: Declare.
1507         (tui_show_symtab_source): Don't declare.
1508         * tui/tui-source.c (tui_show_symtab_source): Rename from
1509         tui_show_symtab_source.
1510
1511 2019-08-16  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-winsource.h (struct tui_source_window_base)
1514         <set_contents>: Declare.
1515         * tui/tui-winsource.c
1516         (tui_source_window_base::update_source_window_as_is): Update.
1517         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1518         Declare.
1519         (tui_set_source_content): Don't declare.
1520         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1521         tui_set_source_content.
1522         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1523         Declare.
1524         (tui_set_disassem_content): Don't declare.
1525         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1526         tui_set_disassem_content.
1527
1528 2019-08-16  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui-winsource.h (struct tui_source_window_base)
1531         <update_breakpoint_info>: Declare.
1532         (tui_update_breakpoint_info): Don't declare.
1533         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1534         (tui_update_all_breakpoint_info): Update.
1535         (tui_source_window_base::update_breakpoint_info): Rename from
1536         tui_update_breakpoint_info.
1537         (tui_source_window_base::update_exec_info): Update.
1538
1539 2019-08-16  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-winsource.h (struct tui_source_window_base)
1542         <update_source_window>: Declare.
1543         (tui_update_source_window): Don't declare.
1544         * tui/tui-winsource.c
1545         (tui_source_window_base::update_source_window): Rename from
1546         tui_update_source_window.
1547         (tui_source_window_base::rerender): Update.
1548         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1549         * tui/tui-disasm.c (tui_show_disassem)
1550         (tui_show_disassem_and_update_source)
1551         (tui_disasm_window::maybe_update): Update.
1552
1553 2019-08-16  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-winsource.h (struct tui_source_window_base)
1556         <update_source_window_as_is>: Declare.
1557         (tui_update_source_window_as_is): Don't declare.
1558         * tui/tui-winsource.c (tui_update_source_window): Update
1559         (tui_source_window_base::update_source_window_as_is): Rename from
1560         tui_update_source_window_as_is.
1561         (tui_source_window_base::refill): Update.
1562         * tui/tui-source.c (tui_show_symtab_source): Update.
1563         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1564         Update.
1565
1566 2019-08-16  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-winsource.h (tui_update_source_window)
1569         (tui_update_source_window_as_is): Remove "noerror" parameter.
1570         * tui/tui-winsource.c (tui_update_source_window)
1571         (tui_update_source_window_as_is): Remove "noerror" parameter.
1572         (tui_update_source_windows_with_addr)
1573         (tui_update_source_windows_with_line)
1574         (tui_source_window_base::rerender)
1575         (tui_source_window_base::refill): Update.
1576         * tui/tui-source.h (tui_set_source_content)
1577         (tui_show_symtab_source): Remove "noerror" parameter.
1578         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1579         parameter.
1580         (tui_show_symtab_source): Likewise.
1581         (tui_source_window::maybe_update): Update.
1582         * tui/tui-disasm.c (tui_show_disassem)
1583         (tui_show_disassem_and_update_source)
1584         (tui_disasm_window::do_scroll_vertical)
1585         (tui_disasm_window::maybe_update): Update.
1586
1587 2019-08-16  Tom Tromey  <tom@tromey.com>
1588
1589         * tui/tui.c (tui_is_window_visible): Update.
1590         * tui/tui-wingeneral.c (tui_make_window)
1591         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1592         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1593         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1594         (tui_set_win_height_command, parse_scrolling_args): Update.
1595         * tui/tui-source.c (tui_source_window::style_changed): Update.
1596         * tui/tui-regs.c (tui_show_registers)
1597         (tui_data_window::first_data_item_displayed)
1598         (tui_data_window::delete_data_content_windows)
1599         (tui_check_register_values, tui_reg_command): Update.
1600         * tui/tui-disasm.c (tui_show_disassem): Update.
1601         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1602         method.
1603         <is_visible>: Remove field.
1604         * tui/tui-data.c (tui_next_win, tui_prev_win)
1605         (tui_delete_invisible_windows): Update.
1606
1607 2019-08-16  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-winsource.h (struct tui_source_window_base)
1610         <m_has_locator>: Remove.
1611         * tui/tui-layout.c (show_source_disasm_command, show_data)
1612         (show_source_or_disasm_and_command): Update.
1613
1614 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1615
1616         * NEWS (Other MI changes): New subsection.
1617         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1618         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1619         * arch-utils.c (default_get_pc_address_flags): New function.
1620         * arch-utils.h (default_get_pc_address_flags): New declaration.
1621         * gdbarch.sh: Add get_pc_address_flags.
1622         * gdbarch.c: Regenerate.
1623         * gdbarch.h: Likewise.
1624         * stack.c (print_pc): New function.
1625         (print_frame_info) (print_frame): Call print_pc.
1626
1627 2019-08-16  Tom de Vries  <tdevries@suse.de>
1628
1629         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1630         print_objfile_section_info.
1631
1632 2019-08-15  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1635         calling update_cmdwin_start_line.
1636         * tui/tui-winsource.h (struct tui_source_window_base)
1637         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1638         <rerender>: Declare.
1639         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1640         Call rerender.
1641         (tui_source_window_base::set_new_height): Remove.
1642         (tui_source_window_base::rerender): Rename from
1643         do_make_visible_with_new_height.
1644         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1645         resize method.
1646         (tui_win_info::make_invisible_and_set_new_height)
1647         (tui_win_info::make_visible_with_new_height): Remove.
1648         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1649         Declare.
1650         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1651         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1652         do_make_visible_with_new_height>: Don't declare.
1653         <rerender>: Declare.
1654         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1655         set_new_height.
1656         (tui_data_window::do_make_visible_with_new_height): Remove.
1657         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1658         call tui_show_locator_content.
1659         (tui_gen_win_info::resize): Call rerender.
1660         (show_source_or_disasm_and_command): Don't call
1661         tui_show_locator_content.
1662         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1663         method.
1664         (struct tui_win_info) <rerender>: Declare.
1665         <set_new_height, make_invisible_and_set_new_height,
1666         make_visible_with_new_height>: Don't declare.
1667         * tui/tui-data.c (tui_win_list::rerender): New method.
1668         * tui/tui-command.h (struct tui_cmd_window)
1669         <do_make_visible_with_new_height>: Don't declare.
1670         * tui/tui-command.c
1671         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1672
1673 2019-08-15  Tom Tromey  <tromey@adacore.com>
1674
1675         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1676         * ada-lang.c (ada_enum_name): Likewise.
1677
1678 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1679
1680         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1681         leading underscore.
1682         (GdbOutputErrorFile): Likewise.
1683         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1684         accordingly.
1685         (execute_unwinders): Rename to have a leading underscore.
1686         (auto_load_packages): Likewise.
1687         (global scope): Adjust call to auto_load_packages accordingly.
1688         (GdbSetPythonDirectory): Likewise.
1689         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1690         instead of execute_unwinders.
1691
1692 2019-08-15  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1695         (show_data): Don't change window visibility.
1696         (tui_gen_win_info::resize): Remove special case for command
1697         window.  Use wresize, when available.
1698         (show_source_or_disasm_and_command): Don't change window
1699         visibility.
1700         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1701         <make_visible>: New method.
1702         * tui/tui-command.c (tui_cmd_window::resize): New method.
1703
1704 2019-08-15  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1707         (struct tui_source_windows): New.
1708         * tui/tui-winsource.c (tui_display_main): Update.
1709         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1710         (new_height_ok, parse_scrolling_args): Update.
1711         * tui/tui-layout.c (show_layout, show_data): Update.
1712         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1713         (tui_add_to_source_windows): Don't declare.
1714         * tui/tui-data.c (source_windows, tui_source_windows)
1715         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1716
1717 2019-08-15  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1720         Rename from reset.
1721         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1722         * tui/tui-layout.c (show_source_disasm_command, show_data):
1723         Update.
1724         (tui_gen_win_info::resize): Rename.
1725         (show_source_or_disasm_and_command): Update.
1726         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1727         reset.
1728
1729 2019-08-15  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1732         * tui/tui-interp.c (tui_interp::init): Don't call
1733         tui_initialize_static_data.
1734         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1735
1736 2019-08-15  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1739         examine tui_win_list.
1740
1741 2019-08-15  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1744         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1745         tui_clear_source_content.
1746         (tui_clear_source_content): Remove.
1747         (tui_source_window_base::do_erase_source_content): Hoist call to
1748         content.clear().
1749         * tui/tui-stack.c (tui_show_frame_info): Don't call
1750         tui_clear_source_content.
1751
1752 2019-08-15  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-winsource.h (struct tui_source_window_base)
1755         <do_erase_source_content>: New method.
1756         <erase_source_content>: New method.
1757         (tui_erase_source_content): Don't declare.
1758         * tui/tui-winsource.c (tui_clear_source_content): Update.
1759         (tui_source_window_base::do_erase_source_content): Rename from
1760         tui_erase_source_content.
1761         (tui_source_window_base::show_source_content): Update.
1762         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1763         * tui/tui-source.h (struct tui_source_window)
1764         <erase_source_content>: New method.
1765         * tui/tui-disasm.h (struct tui_disasm_window)
1766         <erase_source_content>: New method.
1767
1768 2019-08-15  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1771         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1772         constructor.
1773         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1774         * tui/tui-source.c (tui_set_source_content): Update.
1775         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1776
1777 2019-08-15  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1780         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1781         tui-source.c.
1782         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1783         Declare.
1784         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1785         method.
1786         (tui_source_window::maybe_update): Update.
1787
1788 2019-08-15  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1791         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1792         tui-disasm.c.
1793         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1794         Declare.
1795         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1796         method.
1797         (tui_disasm_window::maybe_update): Update.
1798
1799 2019-08-15  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-winsource.h (struct tui_source_window_base)
1802         <maybe_update>: Declare.
1803         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1804         method.
1805         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1806         Declare.
1807         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1808         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1809         Declare.
1810         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1811
1812 2019-08-15  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1815
1816 2019-08-15  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-wingeneral.c: Include tui-stack.h.
1819         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1820         (struct tui_locator_window): Move from tui-data.h.
1821         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1822         (tui_initialize_static_data): Move from tui-data.c.
1823         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1824         (struct tui_locator_window): Move to tui-stack.c.
1825         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1826         (tui_initialize_static_data): Move to tui-stack.c.
1827
1828 2019-08-15  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-layout.c (show_source_disasm_command)
1831         (show_source_or_disasm_and_command): Use make_visible method, not
1832         tui_make_window.
1833         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1834         Remove.
1835
1836 2019-08-15  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-wingeneral.h (tui_make_window): Update.
1839         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1840         parameter.
1841         (tui_gen_win_info::make_visible): Update.
1842         * tui/tui-regs.c (tui_data_window::display_registers_from):
1843         Update.
1844         * tui/tui-layout.c (show_source_disasm_command)
1845         (show_source_or_disasm_and_command): Update.
1846         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1847         (enum tui_box): Remove.
1848         (struct tui_win_info) <can_box>: New method.
1849         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1850         method.
1851
1852 2019-08-15  Tom de Vries  <tdevries@suse.de>
1853
1854         * linux-nat-trad.c: Include gdbarch.h.
1855
1856 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1857
1858         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1859         register sizes.
1860
1861 2019-08-14  Tom Tromey  <tromey@adacore.com>
1862
1863         * darwin-nat.c: Include gdbarch.h.
1864         * darwin-nat-info.c: Include gdbarch.h.
1865
1866 2019-08-13  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1869         Remove.
1870         * tui/tui-data.c (tui_initialize_static_data): Update.
1871
1872 2019-08-13  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-winsource.h (struct tui_exec_info_window)
1875         <~tui_exec_info_window, maybe_allocate_content, get_content,
1876         m_content>: Remove.
1877         (struct tui_source_window_base) <set_exec_info_content,
1878         show_exec_info_content>: Don't declare.
1879         * tui/tui-winsource.c
1880         (tui_exec_info_window::maybe_allocate_content): Remove.
1881         (tui_source_window_base::update_exec_info): Rename from
1882         set_exec_info_content.
1883         (tui_source_window_base::show_exec_info_content)
1884         (tui_source_window_base::update_exec_info): Remove.
1885
1886 2019-08-13  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1889         declare.
1890         * tui/tui-winsource.c (tui_update_source_window_as_is)
1891         (tui_update_source_windows_with_addr, tui_erase_source_content):
1892         Update.
1893         (tui_clear_exec_info_content): Remove.
1894
1895 2019-08-13  Tom Tromey  <tom@tromey.com>
1896
1897         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1898         declare.
1899         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1900         call tui_erase_exec_info_content.
1901         (tui_clear_exec_info_content): Rename from
1902         tui_erase_exec_info_content.
1903         (tui_clear_exec_info_content): Delete.
1904
1905 2019-08-13  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui-winsource.h (struct tui_source_window_base)
1908         <show_exec_info_content>: Declare.
1909         (tui_show_exec_info_content): Don't declare.
1910         * tui/tui-winsource.c
1911         (tui_source_window_base::show_exec_info_content): Rename from
1912         tui_show_exec_info_content.
1913         (tui_source_window_base::update_exec_info): Update.
1914
1915 2019-08-13  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1918         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1919         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1920         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1921         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1922         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1923         ... here.
1924
1925 2019-08-13  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-winsource.h (struct tui_source_window_base)
1928         <update_exec_info>: Declare.
1929         (tui_update_exec_info): Don't declare.
1930         * tui/tui-winsource.c (tui_update_source_window_as_is)
1931         (tui_source_window_base::refresh_all)
1932         (tui_update_all_breakpoint_info): Update.
1933         (tui_source_window_base::update_exec_info): Rename from
1934         tui_update_exec_info.
1935         * tui/tui-stack.c (tui_show_frame_info): Update.
1936
1937 2019-08-13  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-winsource.h (struct tui_source_window_base)
1940         <set_exec_info_content>: Declare.
1941         (tui_set_exec_info_content): Don't declare.
1942         * tui/tui-winsource.c
1943         (tui_source_window_base::set_exec_info_content): Rename from
1944         tui_set_exec_info_content.
1945         (tui_update_exec_info): Update.
1946
1947 2019-08-13  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-winsource.h (struct tui_source_window_base)
1950         <show_source_content>: Declare.
1951         (tui_show_source_content): Don't declare.
1952         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1953         (tui_source_window_base::show_source_content): Rename from
1954         tui_show_source_content.
1955         (tui_source_window_base::refresh_all): Update.
1956         * tui/tui-layout.c (show_source_disasm_command)
1957         (show_source_or_disasm_and_command): Update.
1958
1959 2019-08-13  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-winsource.c (tui_erase_source_content)
1962         (tui_show_source_content, tui_source_window_base::refresh_all):
1963         Update.
1964         * tui/tui-wingeneral.h
1965         (tui_check_and_display_highlight_if_needed): Don't declare.
1966         * tui/tui-wingeneral.c
1967         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1968         check_and_display_highlight_if_needed.
1969         * tui/tui-win.c (tui_rehighlight_all)
1970         (tui_win_info::make_visible_with_new_height): Update.
1971         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1972         (tui_data_window::erase_data_content)
1973         (tui_data_window::display_all_data): Update.
1974         * tui/tui-data.h (struct tui_win_info)
1975         <check_and_display_highlight_if_needed>: Declare.
1976
1977 2019-08-13  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-win.c (tui_resize_all): Call
1980         tui_delete_invisible_windows.
1981         * tui/tui-layout.c (show_layout): Call
1982         tui_delete_invisible_windows.
1983         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1984         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1985
1986 2019-08-13  Tom Tromey  <tom@tromey.com>
1987
1988         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1989         tui_add_win_to_layout.
1990
1991 2019-08-13  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1994         * tui/tui-layout.c (tui_default_win_height): Now static.
1995
1996 2019-08-13  Tom Tromey  <tom@tromey.com>
1997
1998         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1999         single switch.
2000         (show_source_disasm_command, show_source_or_disasm_and_command):
2001         Don't check current layout.
2002
2003 2019-08-13  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-wingeneral.c (make_all_visible): Remove.
2006         (tui_make_all_invisible): Simplify.
2007         * tui/tui-layout.c (tui_make_all_invisible): Move from
2008         tui-wingeneral.c; simplify.
2009         (show_layout): Hoist call to tui_make_all_invisible.
2010         (show_data): Don't call tui_make_all_invisible.
2011
2012 2019-08-13  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2015         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2016
2017 2019-08-13  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2020         tui-data.c.
2021         (show_source_disasm_command, show_data)
2022         (show_source_or_disasm_and_command): Don't use
2023         tui_set_current_layout_to.
2024         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2025         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2026         tui-layout.c.
2027         (tui_set_current_layout_to): Remove.
2028
2029 2019-08-13  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-layout.c (tui_set_layout): Update.
2032         * tui/tui-data.h (struct tui_layout_def): Remove.
2033         (tui_layout_def): Don't declare.
2034         * tui/tui-data.c (layout_def): Remove.
2035         (tui_layout_def): Remove.
2036
2037 2019-08-13  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-winsource.h (struct tui_source_window_base)
2040         <clear_detail>: No longer "override".
2041         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2042         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2043         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2044         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2045         Remove.
2046         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2047
2048 2019-08-13  Tom Tromey  <tromey@adacore.com>
2049
2050         * tracepoint.c: Don't include readline.h or history.h.
2051
2052 2019-08-12  Tom Tromey  <tom@tromey.com>
2053
2054         * configure: Rebuild.
2055         * configure.ac: Check for readline 7.
2056         * NEWS: Mention readline 7 requirement.
2057         * README: Update.
2058
2059 2019-08-12  Tom Tromey  <tom@tromey.com>
2060
2061         * mingw-hdep.c (gdb_select): Remove readline hack.
2062
2063 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2064
2065         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2066         when the function fails.
2067
2068 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2069
2070         * s390-tdep.c (s390_type_align): New function.
2071         (s390_gdbarch_init): Set it as type_align gdbarch method.
2072
2073 2019-08-09  Tom de Vries  <tdevries@suse.de>
2074
2075         PR gdb/24591
2076         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2077         pc_low with relocation offset.
2078
2079 2019-08-07  Tom Tromey  <tromey@adacore.com>
2080
2081         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2082         (print_frame_args): Update.
2083         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2084         Update.
2085         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2086         * frame.h (struct frame_arg): Add initializers.
2087         <error>: Now a unique_xmalloc_ptr.
2088
2089 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2090
2091         * NEWS: Expand the Pointer Authentication entry.
2092         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2093         (aarch64_frame_unmask_lr): ... to this.
2094         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2095         Call aarch64_frame_unmask_lr.
2096         * frame.c (struct frame_info): Add "masked" variable.
2097         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2098         (fprint_frame): Check for masked pc.
2099         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2100         declarations.
2101         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2102         * stack.c (print_frame): Check for masked pc.
2103
2104 2019-08-06  Tom Tromey  <tom@tromey.com>
2105
2106         * stabsread.c (patch_block_stabs, read_one_struct_field)
2107         (read_enum_type): Use obstack_strndup.
2108         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2109         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2110         * dwarf2read.c (guess_full_die_structure_name)
2111         (anonymous_struct_prefix): Use obstack_strndup.
2112         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2113         * c-exp.y (yylex): Use obstack_strndup.
2114         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2115         (write_var_or_type): Use obstack_strndup.
2116
2117 2019-08-06  Tom Tromey  <tom@tromey.com>
2118
2119         * symfile.c (reread_symbols): Use obstack_strdup.
2120         * stabsread.c (read_type): Use obstack_strdup.
2121         * gdb_obstack.h (obstack_strdup): New overload.
2122         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2123         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2124         (dwarf2_canonicalize_name): Use obstack_strdup.
2125         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2126         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2127         Use obstack_strdup.
2128
2129 2019-08-06  Tom Tromey  <tom@tromey.com>
2130
2131         * gdb_obstack.h (obstack_strdup): Define.
2132         * gdb_obstack.c (obstack_strdup): Don't define.
2133
2134 2019-08-06  Tom Tromey  <tom@tromey.com>
2135
2136         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2137         obstack_strdup.
2138         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2139         obstack_strdup.
2140         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2141         * stabsread.c (common_block_start): Use obstack_strdup.
2142         * objfiles.c (set_objfile_main_name, objfile): Use
2143         obstack_strdup.
2144         * namespace.c (add_using_directive): Use obstack_strdup.
2145         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2146         * jit.c (finalize_symtab): Use obstack_strdup.
2147         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2148         (guess_partial_die_structure_name, partial_die_info::fixup)
2149         (dwarf2_name): Use obstack_strdup.
2150         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2151         obstack_strdup.
2152         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2153         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2154         obstack_strdup.
2155         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2156
2157 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2158
2159         * unittests/help-doc-selftests.c: New file.
2160         * Makefile.in: Add the new file.
2161
2162 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2163
2164         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2165         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2166         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2167         the trailing '.' is not output, and the first character is uppercased.
2168         (print_help_for_command): Update call to print_doc_line.
2169         (print_doc_of_command): Likewise.
2170         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2171         * cli/cli-option.c (append_indented_doc): Do not append newline.
2172         (build_help_option): Append newline after first appended_indented_doc
2173         only if a second call is done.
2174         (build_help): Append 2 new lines before each option, except the first
2175         one.
2176         * compile/compile.c (_initialize_compile): Add new lines after
2177         %OPTIONS%, when not at the end of the help.
2178         Change help doc or code
2179         producing the help doc to respect the invariants.
2180         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2181         Also removed the new line after 'Options:', as all other commands
2182         do not put an empty line between 'Options:' and the first option.
2183         * printcmd.c (_initialize_printcmd): Likewise.
2184         * stack.c (_initialize_stack): Likewise.
2185         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2186         incorrectly telling COMMAND is optional.
2187         * ada-lang.c (_initialize_ada_language): Change help doc or code
2188         producing the help doc to respect the invariants.
2189         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2190         * breakpoint.c (_initialize_breakpoint): Likewise.
2191         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2192         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2193         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2194         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2195         _initialize_cli_style): Likewise.
2196         * corelow.c (core_target_info): Likewise.
2197         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2198         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2199         * filesystem.c (_initialize_filesystem): Likewise.
2200         * frame.c (_initialize_frame): Likewise.
2201         * gnu-nat.c (add_task_commands): Likewise.
2202         * infcall.c (_initialize_infcall): Likewise.
2203         * infcmd.c (_initialize_infcmd): Likewise.
2204         * interps.c (_initialize_interpreter): Likewise.
2205         * language.c (_initialize_language): Likewise.
2206         * linux-fork.c (_initialize_linux_fork): Likewise.
2207         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2208         * maint.c (_initialize_maint_cmds): Likewise.
2209         * memattr.c (_initialize_mem): Likewise.
2210         * printcmd.c (_initialize_printcmd): Likewise.
2211         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2212         _RegEx): Likewise.
2213         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2214         * record-btrace.c (_initialize_record_btrace): Likewise.
2215         * record-full.c (_initialize_record_full): Likewise.
2216         * record.c (_initialize_record): Likewise.
2217         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2218         * regcache.c (_initialize_regcache): Likewise.
2219         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2220         _initialize_remote): Likewise.
2221         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2222         * serial.c (_initialize_serial): Likewise.
2223         * skip.c (_initialize_step_skip): Likewise.
2224         * source.c (_initialize_source): Likewise.
2225         * stack.c (_initialize_stack): Likewise.
2226         * symfile.c (_initialize_symfile): Likewise.
2227         * symtab.c (_initialize_symtab): Likewise.
2228         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2229         * top.c (init_main): Likewise.
2230         * tracefile-tfile.c (tfile_target_info): Likewise.
2231         * tracepoint.c (_initialize_tracepoint): Likewise.
2232         * tui/tui-win.c (_initialize_tui_win): Likewise.
2233         * utils.c (add_internal_problem_command): Likewise.
2234         * valprint.c (value_print_option_defs): Likewise.
2235
2236 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2237
2238         PR build/24886
2239         * configure.ac: Drop enable-libmcheck support.
2240         * configure, config.in: Rebuild.
2241         * libmcheck.m4: Remove.
2242         * acinclude.m4: Don't include it.
2243         * Makefile.in: Don't distribute it.
2244         * top.c (print_gdb_configuration): Don't mention it.
2245
2246 2019-08-06  Tom Tromey  <tom@tromey.com>
2247
2248         * utils.c (set_output_style): Sometimes pass stream to
2249         emit_style_escape.
2250         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2251         * record-btrace.c (btrace_insn_history): Update.
2252         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2253         method.
2254         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2255         Update initializers.
2256         <m_uiout>: New field.
2257         <m_di>: Move lower.
2258         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2259         Remove "uiout" parameter.
2260         (dump_insns): Update.
2261         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2262         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2263
2264 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2265
2266         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2267         (error_in_psymtab_expansion): Likewise.
2268         (lookup_symbol_via_quick_fns): Likewise.
2269         (basic_lookup_transparent_type_quick): Likewise.
2270         (basic_lookup_transparent_type_1): Likewise.
2271
2272 2019-08-06  Tom Tromey  <tromey@adacore.com>
2273
2274         * source.c (last_source_error): Now bool.
2275         (print_source_lines_base): Make "noprint" bool.  Only open
2276         source file when last_source_visited changes.
2277
2278 2019-08-06  Tom Tromey  <tromey@adacore.com>
2279
2280         * annotate.c (annotate_source_line): Use g_source_cache.
2281         * source-cache.c (source_cache::get_plain_source_lines): Change
2282         parameters.  Populate m_offset_cache.
2283         (source_cache::ensure): New method.
2284         (source_cache::get_line_charpos): New method.
2285         (extract_lines): Move lower.  Change parameters.
2286         (source_cache::get_source_lines): Move lower.
2287         * source-cache.h (class source_cache): Update comment.
2288         <get_line_charpos>: New method.
2289         <get_source_lines>: Update comment.
2290         <clear>: Clear m_offset_cache.
2291         <get_plain_source_lines>: Change parameters.
2292         <ensure>: New method
2293         <m_offset_cache>: New member.
2294         * source.c (forget_cached_source_info_for_objfile): Update.
2295         (info_source_command): Use g_source_cache.
2296         (find_source_lines, open_source_file_with_line_charpos): Remove.
2297         (print_source_lines_base, search_command_helper): Use g_source_cache.
2298         * source.h (open_source_file_with_line_charpos): Don't declare.
2299         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2300         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2301         Use g_source_cache.
2302
2303 2019-08-06  Tom Tromey  <tromey@adacore.com>
2304
2305         * source-cache.c (source_cache::get_plain_source_lines):
2306         Remove "first_line" and "last_line" parameters.
2307         (source_cache::get_source_lines): Cache plain text.
2308         * source-cache.h (class source_cache)
2309         <get_plain_source_lines>: Update.
2310
2311 2019-08-06  Tom Tromey  <tromey@adacore.com>
2312
2313         * source-cache.c (extract_lines): No longer a method.
2314         Changed type of parameter.  Include final newline.
2315         (selftests::extract_lines_test): New function.
2316         (_initialize_source_cache): Likewise.
2317         * source-cache.h (class source_cache)
2318         <extract_lines>: Don't declare.
2319
2320 2019-08-06  Tom Tromey  <tromey@adacore.com>
2321
2322         * breakpoint.c (init_breakpoint_sal): Update.
2323         (breakpoint): Update.
2324         * breakpoint.h (struct breakpoint) <filter>: Now a
2325         unique_xmalloc_ptr.
2326
2327 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2328
2329         * NEWS: Mention dictionary access on blocks.
2330         * python/py-block.c (blpy_getitem): New function.
2331         (block_object_as_mapping): New struct.
2332         (block_object_type): Use new struct for tp_as_mapping field.
2333
2334 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2335
2336         * objfiles.h (objfile): Add a comment describing partial symbols.
2337
2338 2019-08-05  Tom Tromey  <tromey@adacore.com>
2339
2340         * compile/compile.c (_initialize_compile): Use _(), not N_().
2341         * thread.c (_initialize_thread): Use _(), not N_().
2342         * stack.c (_initialize_stack): Use _(), not N_().
2343         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2344
2345 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2346
2347         * dwarf2read.c (struct dw2_symtab_iterator):
2348         <want_specific_block>: Remove.
2349         <block_index>: Change type to gdb::optional.
2350         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2351         change type of BLOCK_INDEX parameter to gdb::optional.
2352         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2353         (dw2_lookup_symbol): Don't pass argument for
2354         WANT_SPECIFIC_BLOCK.
2355         (dw2_expand_symtabs_for_function): Don't pass argument for
2356         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2357         (class dw2_debug_names_iterator)
2358         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2359         parameter, change BLOCK_INDEX type to gdb::optional.
2360         <m_want_specific_block>: Remove.
2361         <m_block_index>: Change type to gdb::optional.
2362         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2363         gdb::optional.  Re-write in function of gdb::optional.
2364         (dw2_debug_names_lookup_symbol): Don't pass argument for
2365         WANT_SPECIFIC_BLOCK.
2366         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2367         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2368         BLOCK_INDEX.
2369
2370 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2371
2372         * NEWS: Mention changes to "info sources" command.
2373
2374 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2375
2376         * symtab.c (filename_partial_match_opts): New struct type.
2377         (struct output_source_filename_data): New members
2378         regexp, c_regexp, partial_match.
2379         (output_source_filename): Use new members to decide to print file.
2380         (info_sources_option_defs): New variable.
2381         (make_info_sources_options_def_group, print_info_sources_header,
2382         info_sources_command_completer):
2383         New functions.
2384         (info_sources_command): Read new optional arguments.
2385         (_initialize_symtab): Update info sources help.
2386
2387 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2388
2389         * ada-lang.c (exception_support_info_v0): Renamed from...
2390         (default_exception_support_info): ... this.  Create new
2391         definition for v1.
2392         (ada_has_this_exception_support): Look up catch_handlers_sym.
2393         (ada_exception_support_info_sniffer): Try v0 after default.
2394
2395 2019-08-01  Tom Tromey  <tromey@adacore.com>
2396
2397         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2398         gdbarch.h.
2399
2400 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2401
2402         * s12z-tdep.c: Fix include path for s12z-opc.h.
2403
2404 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2405
2406         * NEWS: Require GNU make 3.82.
2407
2408 2019-07-16  Tom Tromey  <tom@tromey.com>
2409
2410         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2411         declare.
2412
2413 2019-07-30  Tom Tromey  <tromey@adacore.com>
2414
2415         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2416
2417 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2418
2419         * printcmd.c (print_address_symbolic): Print negative offsets.
2420         (build_address_symbolic): Force signed arithmetic when computing
2421         offset.
2422
2423 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2424
2425         PR/24474: Add a function to lookup static variables.
2426         * NEWS: Mention this new function.
2427         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2428         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2429         * python/python.c (python_GdbMethods): Add new function.
2430
2431 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2432
2433         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2434         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2435         (objfpy_lookup_static_symbol): New function.
2436         (objfile_object_methods): Add new functions.
2437
2438 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2439
2440         * NEWS: Mention 'set|show print frame-info'.  Mention new
2441         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2442         backtrace argument.  Mention that python frame filtering code
2443         is now consistent with what 'backtrace' command prints.
2444
2445 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2446
2447         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2448         comments.
2449         (print_frame_info_auto, print_frame_info_source_line,
2450         print_frame_info_location, print_frame_info_source_and_location,
2451         print_frame_info_location_and_address, print_frame_info_short_location):
2452         New declarations.
2453         (struct frame_print_options): New member print_frame_info.
2454         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2455         * stack.h (get_user_print_what_frame_info): New declaration.
2456         (frame_show_address): New declaration.
2457         * stack.c (print_frame_arguments_choices): New value 'presence'.
2458         (print_frame_info_auto, print_frame_info_source_line,
2459         print_frame_info_location, print_frame_info_source_and_location,
2460         print_frame_info_location_and_address, print_frame_info_short_location,
2461         print_frame_info_choices, print_frame_info_print_what): New definitions.
2462         (print_frame_args): Only print dots for args if print frame-arguments
2463         is 'presence'.
2464         (frame_print_option_defs): New element for "frame-info".
2465         (get_user_print_what_frame_info): New function.
2466         (frame_show_address): Make non static.  Move comment to stack.h.
2467         (print_frame_info_to_print_what): New function.
2468         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2469         to decide what to print.
2470         (backtrace_command_1): Handle the new print_frame_arguments_presence
2471         value.
2472         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2473         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2474         (py_print_frame): In non-mi mode, use LOCATION as default for
2475         print_what, similarly to frame information printed directly by
2476         backtrace command. Handle frame-info user option in non MI mode.
2477
2478 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2479
2480         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2481         Add case for debugging 32-bit target on 64-bit host.  Revise
2482         comment.
2483
2484 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2485
2486         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2487         instead of find_function_entry_range_from_pc.
2488
2489 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2490
2491         * stack.c (find_frame_funname): Remove code which preferred
2492         minsym over symtab sym in "certain pathological cases".
2493
2494         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2495         parameter.  Change type of "do_demangle" to bool.
2496         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2497         Pass suitable "prefer_sym_over_minsym" flag to
2498         build_address_symbolic().  Don't output "+" for negative offsets.
2499         * printcmd.c (print_address_symbolic): Update invocation of
2500         build_address_symbolic to include a "prefer_sym_over_minsym"
2501         flag.
2502         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2503         Restrict cases in which use of minimal symbol is preferred to that
2504         of a found symbol.  Update comments.
2505
2506         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2507         for entry pc when entry pc is out of range for that FDE.
2508
2509 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2510
2511         PR gdb/24839:
2512         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2513         type.
2514
2515 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2516
2517         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2518         this function's Python signature.
2519
2520
2521 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2522
2523         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2524         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2525         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2526         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2527         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2528
2529
2530 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2531
2532         * h8300-tdep.c (h8300_register_name_common): New.
2533         h8300_register_name): Use h8300_register_name_common.
2534         (h8300s_register_name): Likewise.
2535         (h8300sx_register_name): Likewise.
2536         (h8300h_register_nam): New.
2537         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2538
2539
2540 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2541
2542         * arm-tdep.c (arm_skip_cmse_entry): New function.
2543         (arm_is_sgstubs_section): New function.
2544         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2545
2546 2019-07-22  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2549         Don't self-assign.
2550
2551 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2552
2553         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2554         type_print.
2555
2556 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2557
2558         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2559         so that GDB doesn't match any msymbols when searching in the
2560         TYPES_DOMAIN.
2561         (print_symbol_info): Print using typedef_print or type_print based
2562         on the type of the symbol.  Add updated FIXME comment moved from...
2563         (_initialize_symtab): ... move and update FIXME comment to above.
2564
2565 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * NEWS: Mention adding -q option to "info types".
2568         * symtab.c (struct info_types_options): New struct.
2569         (info_types_options_defs): New variable.
2570         (make_info_types_options_def_group): New function.
2571         (info_types_command): Use gdb::option framework to parse options.
2572         (info_types_command_completer): New function.
2573         (_initialize_symtab): Extend the help text on "info types" and
2574         register command completer.
2575
2576 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2577
2578         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2579         (lookup_symbol_in_objfile): Change int to block_enum and add a
2580         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2581
2582 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2583
2584         * MAINTAINERS (Write After Approval): Add self.
2585
2586 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2587
2588         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2589         instruction to the dummy code region.
2590
2591 2019-07-19  Tom Tromey  <tromey@adacore.com>
2592
2593         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2594         (ARGSUSED, PARAMS, __func__): Remove rules.
2595
2596 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2597
2598         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2599         * features/arm/arm-with-iwmmxt.c: Remove.
2600         * features/arm/arm-with-iwmmxt.xml: Remove.
2601         * features/arm/arm-with-m-fpa-layout.c: Remove.
2602         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2603         * features/arm/arm-with-m-vfp-d16.c: Remove.
2604         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2605         * features/arm/arm-with-m.c: Remove.
2606         * features/arm/arm-with-m.xml: Remove.
2607         * features/arm/arm-with-neon.c: Remove.
2608         * features/arm/arm-with-neon.xml: Remove.
2609         * features/arm/arm-with-vfpv2.c: Remove.
2610         * features/arm/arm-with-vfpv2.xml: Remove.
2611         * features/arm/arm-with-vfpv3.c: Remove.
2612         * features/arm/arm-with-vfpv3.xml: Remove.
2613
2614 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2615
2616         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2617
2618 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2619
2620         * arch/aarch32.c (aarch32_create_target_description): Create
2621         target descriptions using features.
2622         * arch/arm.c (arm_create_target_description)
2623         (arm_create_mprofile_target_description): Likewise.
2624         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2625
2626 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2627
2628         * Makefile.in: Add new files.
2629         * aarch32-tdep.c: New file.
2630         * aarch32-tdep.h: New file.
2631         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2632         Call aarch32_read_description.
2633         * arch/aarch32.c: New file.
2634         * arch/aarch32.h: New file.
2635         * arch/arm.c (arm_create_target_description)
2636         (arm_create_mprofile_target_description): New function.
2637         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2638         (arm_create_target_description)
2639         (arm_create_mprofile_target_description): New declaration.
2640         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2641         read_description functions.
2642         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2643         Likewise.
2644         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2645         * arm-tdep.c (tdesc_arm_list): New variable.
2646         (arm_register_g_packet_guesses): Call create description functions.
2647         (arm_read_description) (arm_read_mprofile_description): New
2648         function.
2649         * arm-tdep.h (arm_read_description)
2650         (arm_read_mprofile_description): Add declaration.
2651         * configure.tgt: Add new files.
2652
2653 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2654
2655         * top.c (new_ui_command): Open specified terminal just once.
2656
2657 2019-07-18  Tom Tromey  <tromey@adacore.com>
2658
2659         * symtab.c (main_name): Constify return type.
2660         * symfile.c (set_initial_language): Update.
2661         * symtab.h (main_name): Constify return type.
2662
2663 2019-07-17  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-winsource.c (tui_update_source_window)
2666         (tui_update_source_window_as_is)
2667         (tui_update_source_windows_with_line): Remove return.
2668         * tui/tui-disasm.c (tui_show_disassem)
2669         (tui_show_disassem_and_update_source): Remove return.
2670         * tui/tui.c (tui_reset): Remove return.
2671         * tui/tui-wingeneral.c
2672         (tui_check_and_display_highlight_if_needed): Remove return.
2673
2674 2019-07-17  Tom Tromey  <tom@tromey.com>
2675
2676         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2677
2678 2019-07-17  Tom Tromey  <tom@tromey.com>
2679
2680         * tui/tui-winsource.h (struct tui_exec_info_window)
2681         (struct tui_source_window_base): Move from tui-data.h.
2682         * tui/tui-winsource.c: Move many method definitions from
2683         elsewhere.  Remove "structuring" comments.
2684         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2685         (tui_source_window_base::refresh_window): Move to
2686         tui-winsource.c.
2687         * tui/tui-win.c (tui_source_window_base::refresh_all)
2688         (tui_source_window_base::update_tab_width)
2689         (tui_source_window_base::set_new_height)
2690         (tui_source_window_base::do_make_visible_with_new_height): Move to
2691         tui-winsource.c.
2692         * tui/tui-source.h: Update.
2693         * tui/tui-source.c (tui_source_window_base::reset): Move to
2694         tui-winsource.c.
2695         * tui/tui-disasm.h: Update.
2696         * tui/tui-data.h (struct tui_exec_info_window): Move to
2697         tui-winsource.h.
2698         (struct tui_source_window_base): Likewise.
2699         * tui/tui-data.c (tui_source_window_base::clear_detail)
2700         (tui_source_window_base, ~tui_source_window_base): Move to
2701         tui-winsource.c.
2702
2703 2019-07-17  Tom Tromey  <tom@tromey.com>
2704
2705         * tui/tui-win.c (tui_resize_all)
2706         (tui_source_window_base::update_tab_width)
2707         (tui_adjust_win_heights): Update.
2708         (tui_win_info::make_invisible_and_set_new_height): Rename from
2709         make_invisible_and_set_new_height.
2710         * tui/tui-data.h (struct tui_win_info)
2711         <make_invisible_and_set_new_height>: New method.
2712
2713 2019-07-17  Tom Tromey  <tom@tromey.com>
2714
2715         * tui/tui.c: Update.
2716         * tui/tui-source.h (struct tui_source_window): Move from
2717         tui-data.h.
2718         * tui/tui-layout.c: Update.
2719         * tui/tui-disasm.c: Update.
2720         * tui/tui-data.h (struct tui_source_window): Move to
2721         tui-source.h.
2722
2723 2019-07-17  Tom Tromey  <tom@tromey.com>
2724
2725         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2726         tui-data.h.
2727         * tui/tui-data.h (struct tui_disasm_window): Move to
2728         tui-disasm.h.
2729
2730 2019-07-17  Tom Tromey  <tom@tromey.com>
2731
2732         * tui/tui-regs.h (struct tui_data_item_window): Move from
2733         tui-data.h.
2734         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2735         * tui/tui-data.h (struct tui_data_item_window): Move to
2736         tui-regs.h.
2737         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2738
2739 2019-07-17  Tom Tromey  <tom@tromey.com>
2740
2741         * tui/tui.c: Update.
2742         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2743         (tui_cmd_window::max_height): Move to tui-command.c.
2744         * tui/tui-layout.c: Update.
2745         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2746         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2747         tui-command.c.
2748         * tui/tui-command.h (struct tui_cmd_window): Move from
2749         tui-data.h.
2750         * tui/tui-command.c: Remove "structuring" comments.
2751         (tui_cmd_window::clear_detail)
2752         (tui_cmd_window::do_make_visible_with_new_height)
2753         (tui_cmd_window::max_height): Move from elsewhere.
2754
2755 2019-07-17  Tom Tromey  <tom@tromey.com>
2756
2757         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2758         Now static.
2759         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2760         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2761
2762 2019-07-17  Tom Tromey  <tom@tromey.com>
2763
2764         * tui/tui.c: Update.
2765         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2766         tui-regs.c.
2767         * tui/tui-windata.h: Remove file.
2768         * tui/tui-windata.c: Remove file.
2769         * tui/tui-win.c (tui_data_window::set_new_height)
2770         (tui_data_window::do_make_visible_with_new_height): Move to
2771         tui-regs.c.
2772         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2773         * tui/tui-regs.c: Remove "structuring" comments.
2774         (tui_data_window::first_data_item_displayed)
2775         (tui_data_window::delete_data_content_windows)
2776         (tui_data_window::erase_data_content)
2777         (tui_data_window::display_all_data)
2778         (tui_data_window::refresh_all)
2779         (tui_data_window::do_scroll_vertical)
2780         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2781         (tui_data_window::do_make_visible_with_new_height)
2782         (tui_data_window::refresh_window): Move from elsewhere.
2783         (_initialize_tui_regs): Move to end of file.
2784         * tui/tui-layout.c: Update.
2785         * tui/tui-hooks.c: Update.
2786         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2787         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2788         tui-regs.c.
2789         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2790
2791 2019-07-17  Tom Tromey  <tom@tromey.com>
2792
2793         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2794         seen.
2795
2796 2019-07-17  Tom Tromey  <tom@tromey.com>
2797
2798         * tui/tui-win.c (tui_source_window_base::set_new_height)
2799         (tui_source_window_base::do_make_visible_with_new_height): Use
2800         m_has_locator field directly.
2801         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2802         method.
2803         (struct tui_source_window_base) <has_locator>: Likewise.
2804
2805 2019-07-17  Tom Tromey  <tom@tromey.com>
2806
2807         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2808         Don't declare.
2809         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2810         Remove.
2811         * tui/tui-win.c (tui_source_window_base::set_new_height)
2812         (tui_source_window_base::set_new_height)
2813         (make_invisible_and_set_new_height)
2814         (tui_source_window_base::do_make_visible_with_new_height)
2815         (tui_source_window_base::do_make_visible_with_new_height):
2816         Update.
2817         * tui/tui-layout.c (show_source_disasm_command, show_data)
2818         (show_source_or_disasm_and_command): Update.
2819         * tui/tui-layout.c (show_layout): Update.
2820
2821 2019-07-17  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-layout.c (make_data_window): Remove.
2824         (show_data): Unify creation and re-initialization cases.
2825
2826 2019-07-17  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-layout.c (make_source_window, make_disasm_window):
2829         Remove.
2830         (show_data): Unify creation and re-initialization cases.
2831
2832 2019-07-17  Tom Tromey  <tom@tromey.com>
2833
2834         * tui/tui-layout.c (make_command_window): Remove.
2835         (show_source_disasm_command, show_source_or_disasm_and_command):
2836         Unify creation and re-initialization cases.
2837
2838 2019-07-17  Tom Tromey  <tom@tromey.com>
2839
2840         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2841         creation and re-initialization cases.
2842
2843 2019-07-17  Tom Tromey  <tom@tromey.com>
2844
2845         * tui/tui-regs.c (tui_get_register): Return void.
2846
2847 2019-07-17  Tom Tromey  <tom@tromey.com>
2848
2849         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2850         Simplify.
2851
2852 2019-07-17  Tom Tromey  <tom@tromey.com>
2853
2854         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2855         resetting.
2856
2857 2019-07-17  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2860         * tui/tui-regs.c (tui_reg_layout): New function.
2861         (tui_show_registers, tui_reg_command): Use it.
2862         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2863         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2864         parameters.
2865         (tui_layout_command): Remove.
2866
2867 2019-07-17  Tom Tromey  <tom@tromey.com>
2868
2869         * tui/tui-layout.h (tui/tui-layout): Return void.
2870         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2871
2872 2019-07-17  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-layout.c (show_source_disasm_command, show_data):
2875         Update.
2876         (reset_locator): Remove.
2877         (show_source_or_disasm_and_command): Update.
2878
2879 2019-07-17  Tom Tromey  <tom@tromey.com>
2880
2881         * tui/tui-source.c (tui_source_window_base::reset): Remove
2882         win_type parameter.
2883         * tui/tui-layout.c (make_command_window, make_source_window)
2884         (make_disasm_window, make_data_window)
2885         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2886         (reset_locator, show_source_or_disasm_and_command): Update.
2887         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2888         win_type parameter.
2889         (struct tui_source_window_base) <reset>: Likewise.
2890
2891 2019-07-17  Tom Tromey  <tom@tromey.com>
2892
2893         * tui/tui-layout.c (show_source_disasm_command): Use
2894         reset_locator.
2895         (reset_locator): New function.
2896         (init_and_make_win): Remove.
2897         (show_source_or_disasm_and_command): Use reset_locator.
2898
2899 2019-07-17  Tom Tromey  <tom@tromey.com>
2900
2901         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2902         condition.
2903         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2904         Remove condition.
2905         * tui/tui-source.c (tui_source_window_base::reset): New method.
2906         * tui/tui-layout.c (make_command_window): Don't call
2907         init_and_make_win.
2908         (make_source_window, make_disasm_window): Don't call
2909         make_source_or_disasm_window.
2910         (make_data_window): Don't call init_and_make_win.  Change calling
2911         convention.
2912         (show_source_disasm_command, show_data): Simplify.
2913         (make_source_or_disasm_window): Remove.
2914         (show_source_or_disasm_and_command): Simplify.
2915         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2916         (struct tui_source_window_base) <reset>: Likewise.
2917         <execution_info>: Remove initializer.
2918         * tui/tui-data.c (tui_source_window_base): Initialize
2919         execution_info.
2920
2921 2019-07-17  Tom Tromey  <tom@tromey.com>
2922
2923         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2924         variable.
2925
2926 2019-07-17  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui.c (tui_rl_other_window): Update.
2929         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2930         superclass method first.  Always iterate over regs_content.
2931         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2932         method.
2933         * tui/tui-win.c (tui_set_focus_command): Update.
2934
2935 2019-07-17  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-win.c (tui_set_focus_command): Rename from
2938         tui_set_focus.  Call tui_enable.
2939         (tui_set_focus_command): Remove.
2940
2941 2019-07-17  Tom Tromey  <tom@tromey.com>
2942
2943         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2944         refresh_window.
2945         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2946         touchwin.
2947         (tui_data_window::refresh_window): Call refresh_window on data
2948         items.  Always call superclass refresh_window.
2949         (tui_win_info::refresh): Remove.
2950         (tui_source_window_base::refresh_window): Update.
2951         (tui_refresh_all): Update.
2952         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2953         refresh_window.
2954         (show_source_or_disasm_and_command): Likewise.
2955         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2956         (struct tui_source_window_base) <refresh>: Likewise.
2957
2958 2019-07-17  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-winsource.c (tui_clear_source_content)
2961         (tui_show_source_content): Update.
2962         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2963         whether content is empty.
2964         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2965         Remove.
2966
2967 2019-07-17  Tom Tromey  <tom@tromey.com>
2968
2969         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2970         window's contents.
2971         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2972         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2973
2974 2019-07-17  Tom Tromey  <tom@tromey.com>
2975
2976         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2977         (struct tui_data_item_window): Update.
2978
2979 2019-07-17  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2982         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2983         defines.
2984
2985 2019-07-17  Tom Tromey  <tom@tromey.com>
2986
2987         * tui/tui-winsource.h (tui_erase_source_content)
2988         (tui_clear_source_content): Remove "display_prompt" parameter.
2989         * tui/tui-winsource.c (tui_update_source_window_as_is)
2990         (tui_update_source_windows_with_addr): Update.
2991         (tui_clear_source_content): Remove "display_prompt" parameter.
2992         (tui_erase_source_content): Likewise.  Simplify.
2993         (tui_show_source_content): Update.
2994         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2995         * tui/tui-stack.c (tui_show_frame_info): Update.
2996         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2997         Remove defines.
2998
2999 2019-07-17  Tom Tromey  <tom@tromey.com>
3000
3001         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3002         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3003         parameter.
3004         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3005         parameter.
3006
3007 2019-07-17  Tom Tromey  <tom@tromey.com>
3008
3009         * tui/tui-winsource.c (tui_clear_source_content)
3010         (tui_show_source_content, tui_show_exec_info_content)
3011         (tui_clear_exec_info_content): Update.
3012         * tui/tui-stack.c (tui_show_locator_content): Update.
3013         (tui_show_frame_info): Update.
3014         * tui/tui-source.h (tui_source_window): Don't declare.
3015         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3016         from tui_source_is_displayed.
3017         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3018         Remove field.
3019         (struct tui_source_window_base) <content_in_use>: New field.  Now
3020         bool.
3021         (struct tui_source_window) <showing_source_p>: New method.
3022         (TUI_SRC_WIN): Change cast.
3023         * tui/tui-data.c (tui_initialize_static_data): Update.
3024
3025 2019-07-17  Tom Tromey  <tom@tromey.com>
3026
3027         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3028         location_matches_p.
3029         * tui/tui-source.c (tui_source_window::location_matches_p): New
3030         method.
3031         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3032         method.
3033         * tui/tui-data.h (struct tui_source_window_base)
3034         <location_matches_p>: New method.
3035         (struct tui_source_window, struct tui_disasm_window)
3036         <location_matches_p>: Likewise.
3037
3038 2019-07-17  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-win.c (tui_set_win_height_command): Rename from
3041         tui_set_win_height.
3042         (tui_set_win_height_command): Remove.
3043
3044 2019-07-17  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-source.c (tui_source_window): New constructor.  Add
3047         observer.
3048         (~tui_source_window): New destructor.
3049         (tui_source_window::style_changed): New method.
3050         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3051         (tui_attach_detach_observers): Update.
3052         * tui/tui-data.h (struct tui_source_window): Make constructor not
3053         inline.  Add destructor.
3054         (struct tui_source_window) <style_changed>: New method.
3055         <m_observable>: New member.
3056
3057 2019-07-17  Tom Tromey  <tom@tromey.com>
3058
3059         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3060         * tui/tui-win.c (tui_resize_all): Fix typo.
3061
3062 2019-07-17  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3065         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3066         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3067         * tui/tui-win.c (window_name_completer): Use foreach.
3068         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3069         (update_tab_width): Likewise.
3070         * tui/tui-layout.c (show_layout): Update.
3071         * tui/tui-data.h (class tui_window_iterator): New.
3072         (struct all_tui_windows): New.
3073         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3074
3075 2019-07-17  Tom Tromey  <tom@tromey.com>
3076
3077         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3078         parameter.  Don't reference globals.
3079         (tui_reg_command): Update.
3080
3081 2019-07-17  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-regs.c (tui_show_registers): Simplify.
3084
3085 2019-07-17  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-regs.c (tui_show_registers): Update.
3088         (tui_show_register_group): Add win_info parameter.
3089
3090 2019-07-17  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3093         Rename from tui_display_reg_element_at_line.
3094         (tui_data_window::display_registers_from_line): Update.
3095         * tui/tui-data.h (struct tui_data_window)
3096         <display_reg_element_at_line>: New method.
3097
3098 2019-07-17  Tom Tromey  <tom@tromey.com>
3099
3100         * tui/tui-regs.h (tui_display_registers_from)
3101         (tui_display_registers_from_line): Don't declare.
3102         * tui/tui-windata.c (tui_data_window::display_all_data)
3103         (tui_data_window::refresh_all)
3104         (tui_data_window::do_scroll_vertical): Update.
3105         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3106         from tui_display_registers_from.
3107         (tui_display_reg_element_at_line): Update.
3108         (tui_data_window::display_registers_from_line): Rename from
3109         tui_display_registers_from_line.
3110         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3111         display_registers_from_line>: New methods.
3112
3113 2019-07-17  Tom Tromey  <tom@tromey.com>
3114
3115         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3116         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3117         from tui_erase_data_content.
3118         (tui_data_window::display_all_data)
3119         (tui_data_window::refresh_all)
3120         (tui_data_window::do_scroll_vertical): Update.
3121         * tui/tui-regs.c (tui_show_registers): Update.
3122         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3123         New method.
3124
3125 2019-07-17  Tom Tromey  <tom@tromey.com>
3126
3127         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3128         declare.
3129         * tui/tui-windata.c
3130         (tui_data_window::delete_data_content_windows): Rename from
3131         tui_delete_data_content_windows.
3132         (tui_data_window::display_all_data)
3133         (tui_data_window::do_scroll_vertical): Update.
3134         * tui/tui-data.h (struct tui_data_window)
3135         <delete_data_content_windows>: New method.
3136
3137 2019-07-17  Tom Tromey  <tom@tromey.com>
3138
3139         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3140         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3141
3142 2019-07-17  Tom Tromey  <tom@tromey.com>
3143
3144         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3145         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3146         from tui_display_all_data.
3147         * tui/tui-win.c
3148         (tui_data_window::do_make_visible_with_new_height): Update.
3149         * tui/tui-regs.c (tui_show_registers): Update.
3150         * tui/tui-layout.c (tui_set_layout): Update.
3151         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3152         method.
3153
3154 2019-07-17  Tom Tromey  <tom@tromey.com>
3155
3156         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3157         * tui/tui-windata.c (tui_display_data_from): Remove.
3158         (tui_data_window::refresh_all): Update.
3159
3160 2019-07-17  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3163         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3164         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3165         tui_display_registers_from_line.
3166         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3167         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3168         "force_display" parameter.
3169
3170 2019-07-17  Tom Tromey  <tom@tromey.com>
3171
3172         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3173         declare.
3174         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3175         Rename from tui_first_reg_element_no_inline.
3176         (tui_display_reg_element_at_line)
3177         (tui_display_registers_from_line): Update.
3178         * tui/tui-data.h (struct tui_data_window)
3179         <first_reg_element_no_inline>: New method.
3180
3181 2019-07-17  Tom Tromey  <tom@tromey.com>
3182
3183         * tui/tui-windata.c (tui_display_data_from)
3184         (tui_data_window::do_scroll_vertical): Update.
3185         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3186         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3187         Rename from tui_line_from_reg_element_no.
3188         (tui_display_registers_from_line): Update.
3189         * tui/tui-data.h (struct tui_data_window)
3190         <line_from_reg_element_no>: New method.
3191
3192 2019-07-17  Tom Tromey  <tom@tromey.com>
3193
3194         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3195         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3196         tui_last_regs_line_no.
3197         (tui_display_reg_element_at_line)
3198         (tui_display_registers_from_line): Update.
3199         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3200         method.
3201
3202 2019-07-17  Tom Tromey  <tom@tromey.com>
3203
3204         PR tui/24722:
3205         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3206         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3207         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3208         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3209         (tui_update_breakpoint_info): Likewise.
3210         * tui/tui-hooks.c (tui_event_create_breakpoint)
3211         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3212         Update.
3213
3214 2019-07-17  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3217
3218 2019-07-17  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-winsource.c (tui_update_source_window_as_is)
3221         (tui_update_source_windows_with_addr): Update.
3222         * tui/tui-source.h (tui_set_source_content)
3223         (tui_show_symtab_source): Add "win_info" parameter.
3224         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3225         parameter.
3226         (tui_show_symtab_source): Likewise.
3227
3228 2019-07-17  Tom Tromey  <tom@tromey.com>
3229
3230         * tui/tui-wingeneral.c
3231         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3232
3233 2019-07-17  Tom Tromey  <tom@tromey.com>
3234
3235         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3236         (struct tui_cmd_window) <can_scroll>: New method.
3237         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3238         method.
3239
3240 2019-07-17  Tom Tromey  <tromey@adacore.com>
3241
3242         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3243         do_field_signed>: Rename.  Change type of "value".
3244         * ui-out.c (ui_out::field_signed): Rename from field_int.
3245         Change type of "value".
3246         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3247         type of "value".
3248         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3249         do_field_int.  Change type of "value".
3250         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3251         do_field_int.  Change type of "value".
3252         * tracepoint.c (trace_status_mi, tfind_1)
3253         (print_one_static_tracepoint_marker): Update.
3254         * thread.c (print_thread_info_1, print_selected_thread_frame):
3255         Update.
3256         * stack.c (print_frame, print_frame_info): Update.
3257         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3258         Update.
3259         * source.c (print_source_lines_base): Update.
3260         * skip.c (info_skip_command): Update.
3261         * record-btrace.c (btrace_ui_out_decode_error)
3262         (btrace_call_history_src_line): Update.
3263         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3264         Update.
3265         * progspace.c (print_program_space): Update.
3266         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3267         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3268         do_field_int.  Change type of "value".
3269         * mi/mi-out.c (mi_ui_out::do_table_begin)
3270         (mi_ui_out::do_table_header): Update.
3271         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3272         type of "value".
3273         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3274         (mi_cmd_data_list_changed_registers, output_register)
3275         (mi_cmd_data_read_memory, mi_load_progress)
3276         (mi_cmd_trace_frame_collected): Update.
3277         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3278         Update.
3279         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3280         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3281         (mi_cmd_var_list_children, varobj_update_one): Update.
3282         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3283         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3284         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3285         * inferior.c (print_inferior): Update.
3286         * gdb_bfd.c (print_one_bfd): Update.
3287         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3288         Update.
3289         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3290         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3291         do_field_int.  Change type of "value".
3292         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3293         do_field_int.  Change type of "value".
3294         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3295         (print_one_breakpoint_location, print_it_catch_fork)
3296         (print_one_catch_fork, print_it_catch_vfork)
3297         (print_one_catch_vfork, print_it_catch_solib)
3298         (print_it_catch_exec, print_it_ranged_breakpoint)
3299         (print_mention_watchpoint, print_mention_masked_watchpoint)
3300         (bkpt_print_it, update_static_tracepoint): Update.
3301         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3302         * break-catch-syscall.c (print_it_catch_syscall): Update.
3303         * ada-tasks.c (print_ada_task_info): Update.
3304         * ada-lang.c (print_it_exception, print_mention_exception):
3305         Update.
3306
3307 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3308
3309         PR breakpoints/24541
3310         * gdbarch.c: Regenerate.
3311         * gdbarch.h: Regenerate.
3312         * gdbarch.sh: Adjust return type and parameter types for
3313         'stap_adjust_register'.
3314         (i386_stap_adjust_register): Adjust signature and return new
3315         register name.
3316         * stap-probe.c (stap_parse_register_operand): Adjust use of
3317         'gdbarch_stap_adjust_register'.
3318
3319 2019-07-17  Tom Tromey  <tromey@adacore.com>
3320
3321         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3322         declare VEC.
3323         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3324         std::vector.
3325         (struct s390_process_info): Add initializers.
3326         (s390_add_process): Use new.
3327         (s390_linux_nat_target::low_forget_process): Use delete.
3328         (s390_linux_nat_target::low_new_fork)
3329         (s390_linux_nat_target::stopped_by_watchpoint)
3330         (s390_linux_nat_target::low_prepare_to_resume)
3331         (s390_linux_nat_target::insert_watchpoint)
3332         (s390_linux_nat_target::insert_hw_breakpoint)
3333         (s390_linux_nat_target::remove_watchpoint)
3334         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3335
3336 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3337
3338         * aarch64-fbsd-nat.c: Include regcache.h.
3339         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3340         argument.
3341         (aarch64_fbsd_nat_target::fetch_registers)
3342         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3343         variable.
3344         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3345
3346 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3347
3348         * fbsd-nat.c: Include gdbarch.h.
3349
3350 2019-07-15  Tom Tromey  <tromey@adacore.com>
3351
3352         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3353
3354 2019-07-15  Tom Tromey  <tromey@adacore.com>
3355
3356         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3357         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3358         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3359         * cli-out.c (cli_ui_out::do_field_int): New method.
3360         * ui-out.c (ui_out::field_unsigned): New method.
3361         * symfile.c (generic_load): Use field_unsigned.
3362         (print_transfer_performance): Likewise.
3363         * record-btrace.c (ui_out_field_uint): Remove.
3364         (btrace_call_history_insn_range, btrace_call_history): Use
3365         field_unsigned.
3366         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3367         field_unsigned.
3368         * ui-out.h (class ui_out) <field_unsigned>: New method.
3369         <do_field_unsigned>: Likewise.
3370
3371 2019-07-15  Tom Tromey  <tromey@adacore.com>
3372
3373         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3374         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3375         * target.c (flash_erase_command): Use field_string.
3376         * infrun.c (print_signal_received_reason): Use field_string.
3377         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3378         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3379         field_string.
3380         * ada-tasks.c (print_ada_task_info): Use field_string.
3381
3382 2019-07-15  Tom Tromey  <tromey@adacore.com>
3383
3384         * target.c (flash_erase_command): Use field_core_addr.
3385         * symfile.c (generic_load): Use field_core_addr.
3386         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3387         Use field_core_addr.
3388         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3389         field_core_addr.
3390
3391 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3392
3393         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3394         value if its desired type is smaller than a CORE_ADDR and signed.
3395
3396 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3397
3398         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3399         of changes to field names, and use new is_reference field to
3400         decide if a property is a reference or not.
3401         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3402         field.
3403         (struct dwarf2_property_baton): Update header comment, rename
3404         'referenced_type' to 'property_type' and update comments.
3405         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3406         default property type, store in property baton, update to take
3407         accound of renamed field.
3408         (read_func_scope): Update call to attr_to_dynamic_prop.
3409         (read_array_type): Likewise.
3410         (dwarf2_per_cu_addr_sized_int_type): New function.
3411         (read_subrange_index_type): Move type finding code to
3412         dwarf2_per_cu_addr_sized_int_type.
3413         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3414         (dwarf2_per_cu_addr_type): New function.
3415         (set_die_type): Update calls to attr_to_dynamic_prop.
3416
3417 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3418
3419         * dwarf2read.c (read_subrange_index_type): New function.
3420         (read_subrange_type): Move code into new function and call it.
3421         * gdbtypes.c (create_range_type): Add some asserts.
3422
3423 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3424
3425         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3426         update return statements.
3427         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3428         declaration, and update comment to match.
3429         * gdbtypes.c (resolve_dynamic_array): Update call to
3430         dwarf2_evaluate_property to match new return type.
3431
3432 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3433
3434         * valarith.c (value_subscripted_rvalue): Change lowerbound
3435         parameter type from int to LONGEST.
3436         * value.h (value_subscripted_rvalue): Likewise in declaration.
3437
3438 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3439
3440         * cli/cli-utils.c (info_print_command_completer): New function.
3441         * cli/cli-utils.h: Add 'completer.h' include, and forward
3442         declaration for 'struct cmd_list_element'.
3443         (info_print_command_completer): Declare.
3444         * stack.c (_initialize_stack): Add completer for 'info locals' and
3445         'info args'.
3446         * symtab.c (_initialize_symtab): Add completer for 'info
3447         variables' and 'info functions'.
3448         * NEWS: Mention completion for additional info commands.
3449
3450 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3451
3452         * cli/cli-utils.c (extract_info_print_args): Delete.
3453         (extract_arg_maybe_quoted): Delete.
3454         (info_print_options_defs): New variable.
3455         (make_info_print_options_def_group): New function.
3456         (extract_info_print_options): Define new function.
3457         * cli/cli-utils.h (extract_info_print_args): Delete.
3458         (struct info_print_options): New structure.
3459         (extract_info_print_options): Declare new function.
3460         * stack.c (info_locals_command): Update to use new
3461         extract_info_print_options, also add a header comment.
3462         (info_args_command): Likewise.
3463         * symtab.c (info_variables_command): Likewise.
3464         (info_functions_command): Likewise.
3465
3466 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3467
3468         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3469         to extract string arguments.
3470         * common/common-utils.c (extract_string_maybe_quoted): New function.
3471         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3472
3473 2019-07-11  Tom Tromey  <tromey@adacore.com>
3474
3475         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3476         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3477         * top.h (gdbinit): Don't declare.
3478         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3479         into...
3480         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3481         * top.c (gdb_init): Don't call init_cli_cmds.
3482         (gdbinit): Remove.
3483         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3484
3485 2019-07-11  Tom Tromey  <tromey@adacore.com>
3486
3487         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3488         after it has been moved.
3489
3490 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3491
3492         * valops.c (value_must_coerce_to_target): Change return type to
3493         bool.
3494         * value.h (value_must_coerce_to_target): Likewise.
3495
3496 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3497
3498         * breakpoint.c (is_hardware_watchpoint): Remove
3499         forward-declaration.
3500         (is_masked_watchpoint): Change return type to bool.
3501         (is_tracepoint): Likewise.
3502         (is_breakpoint): Likewise.
3503         (is_hardware_watchpoint): Likewise.
3504         (is_watchpoint): Likewise.
3505         (is_no_memory_software_watchpoint): Likewise.
3506         (is_catchpoint): Likewise.
3507         (breakpoint_1): Make FILTER parameter's return type bool.
3508         is_masked_watchpoint): Change return type to bool.
3509         (save_breakpoints): Make FILTER parameter's return type bool.
3510         * breakpoint.h (is_breakpoint): Change return type to bool.
3511         (is_watchpoint): Likewise.
3512         (is_catchpoint): Likewise.
3513         (is_tracepoint): Likewise.
3514
3515 2019-07-10  Tom Tromey  <tom@tromey.com>
3516
3517         * defs.h: Don't include gdbarch.h.
3518         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3519         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3520         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3521         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3522         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3523         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3524         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3525         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3526         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3527         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3528         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3529         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3530         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3531         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3532         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3533         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3534         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3535         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3536         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3537         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3538         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3539         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3540         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3541         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3542         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3543         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3544         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3545
3546 2019-07-10  Tom Tromey  <tromey@adacore.com>
3547
3548         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3549         * breakpoint.c (init_ada_exception_breakpoint): Register as
3550         bp_catchpoint.
3551         (print_one_breakpoint_location, print_one_breakpoint): Use
3552         is_ada_exception_catchpoint.
3553         * ada-lang.c (class ada_catchpoint_location): Pass
3554         bp_loc_software_breakpoint to bp_location constructor.
3555         (is_ada_exception_catchpoint): New function.
3556
3557 2019-07-10  Tom Tromey  <tromey@adacore.com>
3558
3559         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3560         VEC.
3561         (struct arm_exidx_entry): New method operator<.
3562         (struct arm_exidx_data) <section_maps>: Change type.
3563         (arm_exidx_data_free): Remove.
3564         (arm_exidx_data_key): Change type.  Move lower.
3565         (arm_exidx_new_objfile): Update.
3566         (arm_compare_exidx_entries): Remove.
3567         (arm_find_exidx_entry, _initialize_arm_tdep)
3568
3569 2019-07-10  Tom Tromey  <tromey@adacore.com>
3570
3571         * solib-spu.c (ocl_program_data_key): Change type.
3572         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3573         Update.
3574
3575 2019-07-10  Tom Tromey  <tromey@adacore.com>
3576
3577         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3578         (struct solib_aix_inferior_data) <library_list>: Change type.
3579         (solib_aix_inferior_data_handle): Change type.
3580         (get_solib_aix_inferior_data): Update.
3581         (solib_aix_free_library_list): Remove.
3582         (library_list_start_library): Update.
3583         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3584         return type.
3585         (solib_aix_get_library_list)
3586         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3587         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3588
3589 2019-07-10  Tom Tromey  <tromey@adacore.com>
3590
3591         * solib-dsbt.c (struct dsbt_info): Add initializers.
3592         (solib_dsbt_pspace_data): Change type.
3593         (dsbt_pspace_data_cleanup): Remove.
3594         (get_dsbt_info, _initialize_dsbt_solib): Update.
3595
3596 2019-07-10  Tom Tromey  <tromey@adacore.com>
3597
3598         * spu-tdep.c (spu_overlay_data): Change type.
3599         (spu_get_overlay_table, spu_overlay_new_objfile)
3600         (_initialize_spu_tdep): Update.
3601
3602 2019-07-10  Tom Tromey  <tromey@adacore.com>
3603
3604         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3605         destructor.
3606         (dbx_objfile_data_key): Change type and declare later.
3607         (DBX_SYMFILE_INFO): Rewrite.
3608         * dbxread.c (dbx_objfile_data_key): Change type.
3609         (dbx_symfile_init): Update.
3610         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3611         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3612         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3613
3614 2019-07-10  Tom Tromey  <tromey@adacore.com>
3615
3616         * jit.c (jit_program_space_key): Change type.  Move lower.
3617         (get_jit_program_space_data): Update.
3618         (jit_program_space_data_cleanup): Remove.
3619         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3620         Update.
3621         (struct jit_program_space_data): Add initializers.
3622
3623 2019-07-10  Tom Tromey  <tromey@adacore.com>
3624
3625         * solib-darwin.c (struct darwin_info): Add initializers.
3626         (solib_darwin_pspace_data): Change type.
3627         (darwin_pspace_data_cleanup): Remove.
3628         (get_darwin_info, _initialize_darwin_solib): Update.
3629
3630 2019-07-10  Tom Tromey  <tromey@adacore.com>
3631
3632         * remote-sim.c (struct sim_inferior_data): Add initializers,
3633         constructor, and destructor.
3634         (sim_inferior_data_key): Change type.  Move lower.
3635         (check_for_duplicate_sim_descriptor): Update.
3636         (get_sim_inferior_data): Use new.  Update.
3637         (~sim_inferior_data_cleanup): Rename from
3638         sim_inferior_data_cleanup.  Simplify.
3639         (gdbsim_close_inferior, simulator_command)
3640         (sim_command_completer, _initialize_remote_sim): Update.
3641         (next_pid, INITIAL_PID): Move earlier.
3642
3643 2019-07-10  Tom Tromey  <tromey@adacore.com>
3644
3645         * python/python-internal.h (create_thread_object): Return
3646         gdbpy_ref.
3647         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3648         * python/py-inferior.c (struct threadlist_entry): Add
3649         constructor.
3650         <thread_obj>: Now a gdbpy_ref.
3651         (thread_to_thread_object): Update.
3652         (add_thread_object): Use new.
3653         (delete_thread_object): Use delete.
3654         (infpy_threads): Update.
3655         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3656         GIL.
3657
3658 2019-07-10  Tom Tromey  <tromey@adacore.com>
3659
3660         * valops.c (value_cast): Specialize error message for Ada.
3661
3662 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3663
3664         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3665
3666 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3667
3668         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3669         bpstat_should_step): Return bool, adjust comments.
3670         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3671         bpstat_should_step): Likewise.
3672
3673 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3674
3675         * features/Makefile: Use feature target descriptions for Arm.
3676         * features/arm/arm-core.c: Generate new file.
3677         * features/arm/arm-fpa.c: Likewise.
3678         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3679         * features/arm/arm-m-profile.c: Likewise.
3680         * features/arm/arm-vfpv2.c: Likewise.
3681         * features/arm/arm-vfpv3.c: Likewise.
3682         * features/arm/xscale-iwmmxt.c: Likewise.
3683         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3684
3685 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3686
3687         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3688         ptrace earlier.
3689
3690 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3691
3692         * features/aarch64-pauth.c: Regenerate.
3693
3694 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3695
3696         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3697         bool.
3698         (bpstat_what): Use false instead of 0.
3699
3700 2019-07-09  Pedro Alves  <palves@redhat.com>
3701
3702         * break-catch-throw.c (is_exception_catchpoint): New.
3703         * breakpoint.c (print_one_breakpoint_location): New parameter
3704         'raw_loc'.  Handle it.  Use
3705         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3706         looking at the breakpoint's type.
3707         (print_one_breakpoint): If handling "maint info breakpoints", also
3708         print locations of exception catchpoints.
3709         * breakpoint.h (is_exception_catchpoint): Declare.
3710
3711 2019-07-09  Pedro Alves  <palves@redhat.com>
3712
3713         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3714         "addr" field.
3715         (allocate_location_exception_catchpoint): New.
3716         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3717         (initialize_throw_catchpoint_ops): Install
3718         allocate_location_exception_catchpoint as allocate_location
3719         method.
3720         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3721         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3722         bp_loc_other.
3723         (breakpoint_address_is_meaningful): Delete.
3724         (bl_address_is_meaningful): New.
3725         (breakpoint_locations_match): Adjust comment.
3726         (bp_location_from_bp_type): New, factored out of...
3727         (bp_location::bp_location(breakpoint *)): ... this.
3728         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3729         factored out of...
3730         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3731         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3732         breakpoint_address_is_meaningful.
3733         (bp_locations_compare): Adjust comment.
3734         (update_global_location_list): Use bl_address_is_meaningful
3735         instead of breakpoint_address_is_meaningful.
3736         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3737         explicit.
3738         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3739         * python/py-breakpoint.c (bppy_get_location): No longer check
3740         whether location is null.
3741
3742 2019-07-09  Pedro Alves  <palves@redhat.com>
3743
3744         PR c++/15468
3745         * breakpoint.c (print_one_breakpoint_location): Remove
3746         single-location assert.
3747
3748 2019-07-09  Tom Tromey  <tom@tromey.com>
3749
3750         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3751         * configure: Rebuild.
3752         * configure.ac: Change common to gdbsupport.
3753         * gdbsupport: Rename from common.
3754         * acinclude.m4: Change common to gdbsupport.
3755         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3756         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3757         gdbsupport.
3758         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3759         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3760         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3761         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3762         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3763         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3764         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3765         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3766         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3767         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3768         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3769         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3770         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3771         coff-pe-read.c, command.h, compile/compile-c-support.c,
3772         compile/compile-c.h, compile/compile-cplus-symbols.c,
3773         compile/compile-cplus-types.c, compile/compile-cplus.h,
3774         compile/compile-loc2c.c, compile/compile.c, completer.c,
3775         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3776         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3777         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3778         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3779         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3780         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3781         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3782         features/aarch64-core.c, features/aarch64-fpu.c,
3783         features/aarch64-pauth.c, features/aarch64-sve.c,
3784         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3785         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3786         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3787         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3788         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3789         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3790         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3791         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3792         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3793         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3794         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3795         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3796         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3797         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3798         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3799         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3800         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3801         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3802         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3803         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3804         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3805         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3806         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3807         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3808         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3809         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3810         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3811         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3812         minsyms.c, mips-linux-tdep.c, namespace.h,
3813         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3814         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3815         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3816         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3817         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3818         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3819         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3820         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3821         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3822         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3823         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3824         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3825         procfs.c, producer.c, progspace.h, psymtab.h,
3826         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3827         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3828         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3829         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3830         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3831         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3832         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3833         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3834         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3835         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3836         target-memory.c, target.c, target.h, target/waitstatus.c,
3837         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3838         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3839         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3840         unittests/array-view-selftests.c,
3841         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3842         unittests/common-utils-selftests.c,
3843         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3844         unittests/format_pieces-selftests.c,
3845         unittests/function-view-selftests.c,
3846         unittests/lookup_name_info-selftests.c,
3847         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3848         unittests/mkdir-recursive-selftests.c,
3849         unittests/observable-selftests.c,
3850         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3851         unittests/parse-connection-spec-selftests.c,
3852         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3853         unittests/scoped_fd-selftests.c,
3854         unittests/scoped_mmap-selftests.c,
3855         unittests/scoped_restore-selftests.c,
3856         unittests/string_view-selftests.c, unittests/style-selftests.c,
3857         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3858         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3859         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3860         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3861         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3862         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3863
3864 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3867         bool value.
3868         (decode_digits_ordinary): Set explicit_line field in sal.
3869         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3870         symtab_and_line that was set on an explicit line number in
3871         assembler code.  Do always update the recorded symtab and line if
3872         we do skip the prologue.
3873
3874 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         * breakpoint.c (set_breakpoint_location_function): Remove
3877         explicit_loc parameter.
3878         (momentary_breakpoint_from_master): Update call to
3879         set_breakpoint_location_function.
3880         (add_location_to_breakpoint): Likewise.
3881
3882 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3883
3884         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3885         required features based on default bfd type when no specific bfd
3886         is present.
3887
3888 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3889
3890         * NEWS: Mention that GDB printf and eval commands can now print
3891         C-style and Ada-style convenience var strings without
3892         calling the inferior.
3893         * printcmd.c (printf_c_string): Locally print GDB internal var
3894         instead of transiting via the inferior.
3895         (printf_wide_c_string): Likewise.
3896
3897 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3898
3899         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3900
3901 2019-07-04  Tom Tromey  <tom@tromey.com>
3902
3903         PR tui/24724:
3904         * tui/tui-winsource.c (tui_clear_source_content): Update.
3905         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3906         (tui_update_breakpoint_info): Update.
3907         (tui_set_exec_info_content): Update.
3908         * tui/tui-source.c (tui_set_source_content_nil): Update.
3909         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3910         has_break.
3911         * tui/tui-data.h (enum tui_bp_flag): New.
3912         (tui_bp_flags): New enum flags type.
3913         (struct tui_source_element) <break_mode>: Change type.  Rename
3914         from has_break.
3915         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3916         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3917         constants.
3918         * tui/tui-winsource.h: Fix comment.
3919
3920 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3921
3922         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3923         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3924         (store_fpregs_to_thread)
3925         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3926         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3927         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3928         (IWMMXT_REGS_SIZE): Add define.
3929         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3930         (fetch_vfp_regs, store_vfp_regs)
3931         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3932         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3933
3934 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3935
3936         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3937         defines.
3938         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3939         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3940         (ARM_INT_REGISTER_SIZE): ...to this.
3941         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3942         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3943         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3944         (arm_linux_collect_gregset, supply_nwfpe_register)
3945         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3946         defines.
3947         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3948         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3949         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3950         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3951         (arm_return_in_memory, arm_store_return_value)
3952         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3953         (arm_record_ld_st_multiple): Likewise.
3954         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3955         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3956
3957 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3958
3959         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3960         AARCH64_DISPLACED_MODIFIED_INSNS.
3961         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3962         (aarch64_displaced_step_copy_insn): Likewise.
3963         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3964         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3965         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3966         ARM_DISPLACED_MODIFIED_INSNS.
3967         * arm-tdep.c (arm_gdbarch_init): Likewise.
3968         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3969         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3970         (struct arm_displaced_step_closure): Use
3971         ARM_DISPLACED_MODIFIED_INSNS.
3972
3973 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3974
3975         * features/Makefile: Remove unused xml files.
3976         * features/aarch64.xml: Remove.
3977         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3978         * features/i386/amd64-avx-avx512.xml: Remove.
3979         * features/i386/amd64-avx-linux.xml: Remove.
3980         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3981         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3982         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3983         * features/i386/amd64-avx-mpx.xml: Remove.
3984         * features/i386/amd64-avx.xml: Remove.
3985         * features/i386/amd64-linux.xml: Remove.
3986         * features/i386/amd64-mpx-linux.xml: Remove.
3987         * features/i386/amd64-mpx.xml: Remove.
3988         * features/i386/amd64.xml: Remove.
3989         * features/i386/i386-avx-avx512-linux.xml: Remove.
3990         * features/i386/i386-avx-avx512.xml: Remove.
3991         * features/i386/i386-avx-linux.xml: Remove.
3992         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3993         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3994         * features/i386/i386-avx-mpx-linux.xml: Remove.
3995         * features/i386/i386-avx-mpx.xml: Remove.
3996         * features/i386/i386-avx.xml: Remove.
3997         * features/i386/i386-linux.xml: Remove.
3998         * features/i386/i386-mmx-linux.xml: Remove.
3999         * features/i386/i386-mmx.xml: Remove.
4000         * features/i386/i386-mpx-linux.xml: Remove.
4001         * features/i386/i386-mpx.xml: Remove.
4002         * features/i386/i386.xml: Remove.
4003         * features/i386/x32-avx-avx512-linux.xml: Remove.
4004         * features/i386/x32-avx-linux.xml: Remove.
4005         * features/i386/x32-linux.xml: Remove.
4006
4007 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4008
4009         * regformats/aarch64.dat: Remove.
4010         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4011         * regformats/i386/amd64-avx-linux.dat: Remove.
4012         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4013         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4014         * regformats/i386/amd64-linux.dat: Remove.
4015         * regformats/i386/amd64-mpx-linux.dat: Remove.
4016         * regformats/i386/amd64.dat: Remove.
4017         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4018         * regformats/i386/i386-avx-linux.dat: Remove.
4019         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4020         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4021         * regformats/i386/i386-linux.dat: Remove.
4022         * regformats/i386/i386-mmx-linux.dat: Remove.
4023         * regformats/i386/i386-mpx-linux.dat: Remove.
4024         * regformats/i386/i386.dat: Remove.
4025         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4026         * regformats/i386/x32-avx-linux.dat: Remove.
4027         * regformats/i386/x32-linux.dat: Remove.
4028
4029 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4030
4031         * aarch64-tdep.c: Remove xml self tests.
4032         * amd64-linux-tdep.c: Likewise.
4033         * amd64-tdep.c: Likewise.
4034         * i386-linux-tdep.c: Likewise.
4035         * i386-tdep.c: Likewise.
4036
4037 2019-07-03  Pedro Alves  <palves@redhat.com>
4038
4039         PR cli/24732
4040         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4041         (pipe_cmd_option_defs): New.
4042         (make_pipe_cmd_options_def_group): New.
4043         (pipe_command): Use gdb::option::process_options.
4044         (pipe_command_completer): New function.
4045         (_initialize_cli_cmds): Install completer for "pipe" command.
4046
4047 2019-07-03  Pedro Alves  <palves@redhat.com>
4048
4049         * cli/cli-option.c (union option_value) <string>: New field.
4050         (struct option_def_and_value): Add ctor, move ctor, dtor and
4051         use DISABLE_COPY_AND_ASSIGN.
4052         (option_def_and_value::clear_value): New.
4053         (parse_option, save_option_value_in_ctx, get_val_type_str)
4054         (add_setshow_cmds_for_options): Handle var_string.
4055         * cli-option.h (union option_def::var_address) <string>: New
4056         field.
4057         (struct string_option_def): New.
4058         * maint-test-options.c (struct test_options_opts): Add default
4059         ctor and use DISABLE_COPY_AND_ASSIGN.
4060         <string_opt>: New field.
4061         (test_options_opts::~test_options_opts): New.
4062         (test_options_opts::dump): Also dump "-string".
4063         (test_options_option_defs): Install "string.
4064
4065 2019-07-03  Pedro Alves  <palves@redhat.com>
4066
4067         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4068         option_value with a null enumeration.
4069         (complete_options): Save the option values in the context.
4070         (save_option_value_in_ctx): New, factored out from ...
4071         (process_options): ... here.
4072         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4073         of the function.
4074         * maint-test-options.c (test_options_opts::dump): New, factored
4075         out from ...
4076         (maintenance_test_options_command_mode): ... here.
4077         (maintenance_test_options_command_completion_result): Delete.
4078         (maintenance_test_options_command_completion_text): Update
4079         comment.
4080         (maintenance_show_test_options_completion_result): Change
4081         prototype.  Just print
4082         maintenance_test_options_command_completion_text.
4083         (save_completion_result): New.
4084         (maintenance_test_options_completer_mode): Pass options context to
4085         complete_options, and then save a dump.
4086         (_initialize_maint_test_options): Use add_cmd to install "maint
4087         show test-options-completion-result".
4088
4089 2019-07-03  Pedro Alves  <palves@redhat.com>
4090
4091         * NEWS (New commands): Mention "with" and "maint with".
4092         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4093         (with_command, with_command_completer): New.
4094         (pipe_command): Adjust to new repeat_previous
4095         interface.
4096         (_initialize_cli_cmds): Install the "with" command and its "w"
4097         alias.
4098         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4099         declarations.
4100         * cli/cli-setshow.c (parse_cli_var_uinteger)
4101         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4102         argument strings for all var_types.
4103         (get_setshow_command_value_string): New, factored out from ...
4104         (do_show_command): ... this.
4105         * cli/cli-setshow.h: Include <string>.
4106         (get_setshow_command_value_string): Declare.
4107         * command.h (repeat_previous): Now returns const char *.  Adjust
4108         comment.
4109         * maint.c: Include "cli/cli-cmds.h".
4110         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4111         (_initialize_maint_cmds): Register the "maintenance with" command.
4112         * top.c (repeat_previous): Move bits from pipe_command here:
4113         Return the saved command line, if any; error out if there's no
4114         command to relaunch.
4115
4116 2019-07-03  Pedro Alves  <palves@redhat.com>
4117
4118         * NEWS (New commands): Mention "maint set/show test-settings"
4119         instead of "maint test-settings".
4120         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4121         (maintenance_test_settings_set_list): Rename to ...
4122         (maintenance_set_test_settings_list): ... this.
4123         (maintenance_test_settings_show_list): Rename to  ...
4124         (maintenance_show_test_settings_list): ... this.
4125         (maintenance_test_settings_cmd): Delete.
4126         (maintenance_test_settings_set_cmd): ...
4127         (maintenance_set_test_settings_cmd): ... this.
4128         (maintenance_test_settings_show_cmd): ...
4129         (maintenance_show_test_settings_cmd): ... this.
4130         (maintenance_test_settings_show_value_cmd):
4131         (maintenance_show_test_settings_value_cmd): ... this.
4132         (_initialize_maint_test_settings): No longer install the "maint
4133         test-settings" prefix command.  Rename "maint test-settings set"
4134         to "maint set test-settings", and "maint test-settings show" to
4135         "maint show test-settings".  Adjust all subcommands.
4136
4137 2019-07-03  Pedro Alves  <palves@redhat.com>
4138
4139         * maint-test-settings.c: Fix file's intro comment.  Replace all
4140         references to "test-options" with references to "test-settings",
4141         in comments.
4142
4143 2019-07-03  Pedro Alves  <palves@redhat.com>
4144
4145         * maint-test-settings.c (maintenance_test_settings_xxx)
4146         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4147         New.
4148         (maintenance_test_settings_enums): Use them.
4149         (maintenance_test_settings_enum): Default to
4150         maintenance_test_settings_xxx.
4151         (_initialize_maint_test_settings): Initialize
4152         MAINTENANCE_TEST_SETTINGS_FILENAME.
4153
4154 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4155
4156         * breakpoint.h (remove_breakpoints_inf): Change return type to
4157         void, move function documentation here.
4158         * breakpoint.c (remove_breakpoints_inf): Change return type to
4159         void, move function documentation to header.
4160
4161 2019-07-02  Pedro Alves  <palves@redhat.com>
4162
4163         * NEWS (Completion improvements): Mention "info threads".
4164         * thread.c (struct info_threads_opts, info_threads_option_defs)
4165         (make_info_threads_options_def_group): New.
4166         (info_threads_command): Use gdb::option::process_options.
4167         (info_threads_command_completer): New.
4168         (_initialize_thread): Use gdb::option::build_help to build the
4169         help text for "info threads".
4170
4171 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4172
4173         * defs.h (generic_load): Move from here...
4174         * symfile.h (generic_load): ... to here.  Rename name parameter
4175         to args.
4176         * symfile.c (generic_load): Add comment.
4177
4178 2019-07-01  Tom Tromey  <tromey@adacore.com>
4179
4180         * dwarf2read.c
4181         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4182         declaration of without_params.  Fix formatting.
4183
4184 2019-07-01  Tom Tromey  <tromey@adacore.com>
4185
4186         * ada-exp.y (find_primitive_type): Update.
4187         * ada-lang.h (ada_lookup_symbol): Update.
4188         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4189         parameter.
4190         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4191
4192 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4193
4194         PR breakpoints/24541
4195         * gdbarch.c: Regenerate.
4196         * gdbarch.h: Regenerate.
4197         * gdbarch.sh: Add 'stap_adjust_register'.
4198         * i386-tdep.c: Include '<unordered_set>'.
4199         (i386_stap_adjust_register): New function.
4200         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4201         * stap-probe.c (stap_parse_register_operand): Call
4202         'gdbarch_stap_adjust_register'.
4203
4204 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4205
4206         PR python/24742
4207         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4208         * python/python.c (do_start_initialization): Use 'xmalloc'
4209         instead of 'PyMem_Malloc'.
4210
4211 2019-06-28  Tom Tromey  <tromey@adacore.com>
4212
4213         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4214         for Ada.
4215
4216 2019-06-27  Tom Tromey  <tromey@adacore.com>
4217
4218         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4219         objfile_key.
4220         (arm_find_mapping_symbol, arm_record_special_symbol)
4221         (_initialize_arm_tdep): Update.
4222         (arm_objfile_data_free): Remove.
4223
4224 2019-06-27  Tom Tromey  <tromey@adacore.com>
4225
4226         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4227         to cp_print_static_field.
4228
4229 2019-06-26  Tom Tromey  <tromey@adacore.com>
4230
4231         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4232         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4233         declare.
4234
4235 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4236
4237         * features/aarch64-core.c (create_feature_aarch64_core):
4238         Regenerate.
4239         * features/aarch64-core.xml: Add cpsr flags.
4240
4241 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4242
4243         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4244         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4245
4246 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4247
4248         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4249         field.
4250         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4251         use.
4252         (arm_record_special_symbol): Don't insert new symbol in sorted
4253         position, push it at the end.
4254
4255 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4256
4257         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4258         (arm_mapping_symbol_s): Remove.
4259         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4260         (arm_mapping_symbol_vec): New typedef.
4261         (struct arm_per_objfile): Add constructor.
4262         <section_maps>: Change type to
4263         std::unique_ptr<arm_mapping_symbol_vec[]>.
4264         (arm_compare_mapping_symbols): Remove.
4265         (arm_find_mapping_symbol): Adjust to section_maps type change.
4266         (arm_objfile_data_free): Call delete on arm_per_objfile.
4267         (arm_record_special_symbol): Adjust to section_maps type change.
4268         Allocate arm_per_objfile with new.
4269
4270 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4271
4272         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4273         with the command prefix.
4274
4275 2019-06-25  Tom Tromey  <tom@tromey.com>
4276
4277         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4278         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4279
4280 2019-06-25  Tom Tromey  <tom@tromey.com>
4281
4282         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4283         type.
4284         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4285         protected.
4286
4287 2019-06-25  Tom Tromey  <tom@tromey.com>
4288
4289         * tui/tui-winsource.c
4290         (tui_source_window_base::set_is_exec_point_at): Add check against
4291         LOA_ADDRESS.
4292
4293 2019-06-25  Tom Tromey  <tom@tromey.com>
4294
4295         * tui/tui-source.c (tui_set_source_content): Don't check before
4296         xfree.
4297         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4298
4299 2019-06-25  Tom Tromey  <tom@tromey.com>
4300
4301         * tui/tui-winsource.h (tui_update_source_window_as_is)
4302         (tui_alloc_source_buffer, tui_line_is_displayed)
4303         (tui_addr_is_displayed): Change type of win_info.
4304         * tui/tui-winsource.c (tui_update_source_window_as_is)
4305         (tui_clear_source_content, tui_show_source_line)
4306         (tui_show_source_content, tui_source_window_base::refill)
4307         (tui_source_window_base::set_is_exec_point_at)
4308         (tui_source_window_base::set_is_exec_point_at)
4309         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4310         (tui_alloc_source_buffer, tui_line_is_displayed)
4311         (tui_addr_is_displayed): Change type of win_info.  Update.
4312         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4313         (tui_source_window_base::do_make_visible_with_new_height):
4314         Update.
4315         * tui/tui-source.c (tui_set_source_content)
4316         (tui_set_source_content_nil)
4317         (tui_source_window::do_scroll_vertical): Update.
4318         * tui/tui-layout.c (show_layout): Update.
4319         * tui/tui-disasm.c (tui_set_disassem_content)
4320         (tui_disasm_window::do_scroll_vertical): Update.
4321         * tui/tui-data.h (tui_win_content): Remove.
4322         (struct tui_gen_win_info) <content, content_size>: Remove.
4323         (struct tui_source_element): Add initializers and destructor.
4324         (union tui_which_element, struct tui_win_element): Remove.
4325         (struct tui_source_window_base) <content>: New field.
4326         (struct tui_data_window): Remove destructor.
4327         (tui_alloc_content, tui_free_win_content)
4328         (tui_free_all_source_wins_content): Don't declare.
4329         * tui/tui-data.c (tui_initialize_static_data): Update.
4330         (init_content_element, tui_alloc_content): Remove.
4331         (~tui_gen_win_info): Update.
4332         (~tui_data_window, tui_free_all_source_wins_content)
4333         (tui_free_win_content, free_content, free_content_elements):
4334         Remove.
4335
4336 2019-06-25  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui-winsource.h (tui_clear_source_content)
4339         (tui_erase_source_content, tui_show_source_content): Change type
4340         of win_info.
4341         * tui/tui-winsource.c (tui_clear_source_content)
4342         (tui_erase_source_content, tui_show_source_content): Change type
4343         of win_info.
4344         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4345         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4346         win_info.
4347         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4348         win_info.
4349         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4350
4351 2019-06-25  Tom Tromey  <tom@tromey.com>
4352
4353         * tui/tui-winsource.c (tui_clear_source_content)
4354         (tui_source_window_base::set_is_exec_point_at): Update.
4355         * tui/tui-source.c (tui_set_source_content_nil): Update.
4356         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4357         a bool.
4358         * tui/tui-data.c (init_content_element): Update.
4359
4360 2019-06-25  Tom Tromey  <tom@tromey.com>
4361
4362         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4363         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4364         * tui/tui-layout.c (init_and_make_win): Update.
4365         * tui/tui.h (enum tui_win_type): Update.
4366         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4367         tui_win_is_auxillary.
4368         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4369         tui_win_is_auxillary.
4370
4371 2019-06-25  Tom Tromey  <tom@tromey.com>
4372
4373         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4374         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4375         (tui_delete_data_content_windows, tui_display_all_data)
4376         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4377         Update.
4378         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4379         * tui/tui-regs.c (tui_last_regs_line_no)
4380         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4381         (tui_show_registers): Update.
4382         (tui_show_register_group): Return void.  Update.
4383         (tui_display_registers_from, tui_display_reg_element_at_line)
4384         (tui_display_registers_from_line, tui_check_register_values):
4385         Update.
4386         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4387         member.
4388         (struct tui_data_window) <regs_content>: Now a std::vector.
4389         <regs_content_count>: Remove.
4390         (tui_add_content_elements, tui_free_data_content): Don't declare.
4391         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4392         (init_content_element): Remove DATA_WIN case.  Add assert.
4393         (tui_add_content_elements): Remove.
4394         (tui_data_window): Update.
4395         (tui_free_data_content): Remove.
4396         (free_content_elements): Remove DATA_WIN case.
4397
4398 2019-06-25  Tom Tromey  <tom@tromey.com>
4399
4400         * tui/tui-data.c (tui_data_item_window): Update.
4401         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4402         * tui/tui-windata.c (tui_display_all_data)
4403         (tui_display_data_from_line): Update.
4404         (tui_check_data_values): Remove.
4405         * tui/tui-regs.c (tui_show_register_group)
4406         (tui_display_reg_element_at_line): Update.
4407         * tui/tui-hooks.c (tui_register_changed)
4408         (tui_refresh_frame_and_register_information): Call
4409         tui_check_register_values.
4410         * tui/tui-data.h (struct tui_data_window) <data_content,
4411         data_content_count, data_type>: Remove.
4412         (enum tui_data_type): Remove.
4413
4414         * tui/tui-data.c (tui_data_window::clear_detail)
4415         (~tui_data_window): Update.
4416
4417 2019-06-25  Tom Tromey  <tom@tromey.com>
4418
4419         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4420         declare.
4421         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4422         Rename from tui_first_data_item_displayed.  Update.
4423         (tui_data_window::refresh_all)
4424         (tui_data_window::do_scroll_vertical): Update.
4425         * tui/tui-data.h (struct tui_data_window)
4426         <first_data_item_displayed>: Declare new method.
4427
4428 2019-06-25  Tom Tromey  <tom@tromey.com>
4429
4430         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4431         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4432         contents...
4433         (tui_initialize_static_data): ...here.
4434
4435 2019-06-25  Tom Tromey  <tom@tromey.com>
4436
4437         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4438         (tui_display_registers_from, tui_check_register_values): Update.
4439         (tui_display_register): Remove win_info parameter; update.
4440         (tui_get_register): Change type of parameters.
4441         * tui/tui-data.h (struct tui_data_element): Remove.
4442         (union tui_which_element) <data>: Remove.
4443         <data_window>: Change type.
4444         (struct tui_data_item_window): New.
4445         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4446         case.  Add assert.
4447         (~tui_data_item_window): New destructor.
4448         (free_content_elements): Remove DATA_ITEM_WIN case.
4449
4450 2019-06-25  Tom Tromey  <tom@tromey.com>
4451
4452         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4453         Remove.
4454
4455 2019-06-25  Tom Tromey  <tom@tromey.com>
4456
4457         * tui/tui-data.h (struct tui_command_element): Remove.
4458         (union tui_which_element) <command>: Remove.
4459         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4460         assert.
4461         (free_content_elements): Remove CMD_WIN case.
4462
4463 2019-06-25  Tom Tromey  <tom@tromey.com>
4464
4465         * tui/tui-layout.c (tui_set_layout): Update.
4466         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4467         * tui/tui-data.c (layout_def): Update.
4468
4469 2019-06-25  Tom Tromey  <tom@tromey.com>
4470
4471         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4472         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4473         (tui_source_window_base::set_new_height): Update.
4474         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4475         Update.
4476         (tui_set_locator_fullname, tui_set_locator_info)
4477         (tui_show_frame_info): Update.
4478         * tui/tui-source.c (tui_set_source_content)
4479         (tui_source_is_displayed): Update.
4480         * tui/tui-layout.c (show_source_disasm_command, show_data)
4481         (show_source_or_disasm_and_command): Update.
4482         * tui/tui-disasm.c (tui_set_disassem_content)
4483         (tui_get_begin_asm_address): Update.
4484         * tui/tui-data.h (struct tui_locator_element): Remove.
4485         (union tui_which_element) <locator>: Remove.
4486         (struct tui_locator_window): New.
4487         (tui_locator_win_info_ptr): Change return type.
4488         * tui/tui-data.c (_locator): Change type.
4489         (tui_locator_win_info_ptr): Change return type.
4490         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4491         (tui_alloc_content): Add assert.
4492
4493 2019-06-25  Tom Tromey  <tom@tromey.com>
4494
4495         * tui/tui-winsource.c
4496         (tui_exec_info_window::maybe_allocate_content): New method.
4497         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4498         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4499         (make_source_or_disasm_window): Add cast.
4500         * tui/tui-data.h (union tui_which_element) <simple_string>:
4501         Remove.
4502         (struct tui_source_info): New.
4503         (struct tui_source_window_base) <execution_info>: Change type.
4504         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4505         case, and add assert.
4506         (tui_alloc_content): Add assert.
4507
4508 2019-06-25  Tom Tromey  <tom@tromey.com>
4509
4510         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4511         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4512         * tui/tui-data.c (tui_alloc_win_info): Remove.
4513
4514 2019-06-25  Tom Tromey  <tom@tromey.com>
4515
4516         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4517         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4518         can_highlight.
4519
4520 2019-06-25  Tom Tromey  <tom@tromey.com>
4521
4522         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4523         make_visible_with_new_height method.
4524         (tui_win_info::make_visible_with_new_height): New method.
4525         (tui_source_window_base::do_make_visible_with_new_height)
4526         (tui_data_window::do_make_visible_with_new_height)
4527         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4528         (make_visible_with_new_height): Remove.
4529         (tui_resize_all, tui_adjust_win_heights): Use
4530         make_visible_with_new_height method.
4531         * tui/tui-data.h (struct tui_win_info)
4532         <do_make_visible_with_new_height, make_visible_with_new_height>:
4533         New methods.
4534         (struct tui_source_window_base, struct tui_data_window)
4535         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4536         methods.
4537
4538 2019-06-25  Tom Tromey  <tom@tromey.com>
4539
4540         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4541         method.
4542         (update_tab_width): Call update_tab_width method.
4543         * tui/tui-data.h (struct tui_win_info)
4544         (struct tui_source_window_base) <update_tab_width>: New methods.
4545
4546 2019-06-25  Tom Tromey  <tom@tromey.com>
4547
4548         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4549         parameter.
4550         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4551         parameter.
4552         (tui_gen_win_info::make_visible): Update.
4553         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4554         parameter.
4555         * tui/tui-data.h (enum tui_box): New enum.
4556         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4557
4558 2019-06-25  Tom Tromey  <tom@tromey.com>
4559
4560         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4561         init_and_make_win for EXEC_INFO_WIN.
4562         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4563         longer inline.
4564         (struct tui_win_info) <~tui_win_info>: Inline.
4565         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4566         Don't declare.
4567         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4568         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4569         Remove.
4570         (tui_initialize_static_data): Update.
4571         (~tui_gen_win_info): Handle more cleanup here.
4572         (~tui_source_window_base): Delete "execution_info".
4573         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4574
4575 2019-06-25  Tom Tromey  <tom@tromey.com>
4576
4577         * tui/tui-layout.c (make_command_window): Don't set
4578         can_highlight.
4579         (show_source_disasm_command): Call the reset method.
4580         (show_data): Don't set can_highlight.  Call the reset method.
4581         (tui_gen_win_info::reset): Rename from init_gen_win_info
4582         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4583         (show_source_or_disasm_and_command): Call the reset method.
4584         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4585         (struct tui_cmd_window): Set can_highlight.
4586
4587 2019-06-25  Tom Tromey  <tom@tromey.com>
4588
4589         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4590         from make_visible.
4591         (tui_make_visible, tui_make_invisible): Rewrite.
4592         (tui_win_info::make_visible): Remove.
4593         (tui_source_window_base::make_visible): Update.
4594         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4595         method.  Moved from...
4596         (struct tui_win_info) <make_visible>: ...here.
4597
4598 2019-06-25  Tom Tromey  <tom@tromey.com>
4599
4600         * tui/tui-winsource.c
4601         (tui_source_window_base::do_scroll_horizontal): Remove direction
4602         parameter.
4603         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4604         direction parameter.
4605         * tui/tui-win.c (tui_win_info::forward_scroll)
4606         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4607         (tui_win_info::right_scroll): Update.
4608         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4609         direction parameter.
4610         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4611         direction parameter.
4612         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4613         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4614         Remove direction parameter.
4615         (struct tui_source_window_base, struct tui_source_window)
4616         (struct tui_disasm_window, struct tui_data_window)
4617         (struct tui_cmd_window): Update.
4618
4619 2019-06-25  Tom Tromey  <tom@tromey.com>
4620
4621         * tui/tui-winsource.h (tui_set_exec_info_content)
4622         (tui_show_exec_info_content, tui_erase_exec_info_content)
4623         (tui_clear_exec_info_content, tui_update_exec_info): Change
4624         argument to tui_source_window_base.
4625         * tui/tui-winsource.c (tui_set_exec_info_content)
4626         (tui_show_exec_info_content, tui_erase_exec_info_content)
4627         (tui_clear_exec_info_content, tui_update_exec_info): Change
4628         argument to tui_source_window_base.
4629
4630 2019-06-25  Tom Tromey  <tom@tromey.com>
4631
4632         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4633         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4634
4635 2019-06-25  Tom Tromey  <tom@tromey.com>
4636
4637         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4638         check.
4639
4640 2019-06-25  Tom Tromey  <tom@tromey.com>
4641
4642         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4643         type to void.
4644         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4645         type to void.
4646         * tui/tui-source.c (tui_set_source_content): Update.
4647         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4648
4649 2019-06-25  Tom Tromey  <tom@tromey.com>
4650
4651         * tui/tui-win.c (window_name_completer, tui_set_focus)
4652         (tui_all_windows_info): Use name method.
4653         * tui/tui-data.h (struct tui_gen_win_info)
4654         (struct tui_source_window, struct tui_disasm_window)
4655         (struct tui_data_window, struct tui_cmd_window) <name>: New
4656         method.
4657         (tui_win_name): Don't declare.
4658         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4659         (tui_win_name): Remove.
4660
4661 2019-06-25  Tom Tromey  <tom@tromey.com>
4662
4663         * tui/tui-winsource.h (tui_update_source_window)
4664         (tui_update_source_window_as_is): Change parameter type.
4665         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4666         to be a tui_source_window_base.
4667         (tui_update_source_window_as_is): Likewise.
4668         * tui/tui-win.c (make_visible_with_new_height): Update.
4669
4670 2019-06-25  Tom Tromey  <tom@tromey.com>
4671
4672         * tui/tui-winsource.c (tui_erase_source_content)
4673         (tui_show_source_content, tui_show_exec_info_content)
4674         (tui_erase_exec_info_content): Use refresh_window method.
4675         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4676         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4677         from tui_refresh_win.
4678         (tui_data_window::refresh_window): New method.
4679         (tui_win_info::refresh, tui_source_window_base::refresh)
4680         (tui_refresh_all): Use refresh_window method.
4681         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4682         method.
4683         * tui/tui-regs.c (tui_display_register): Call refresh_window
4684         method.
4685         * tui/tui-layout.c (show_source_disasm_command)
4686         (show_source_or_disasm_and_command): Call refresh_window method.
4687         * tui/tui-data.h (struct tui_gen_win_info)
4688         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4689         New method.
4690
4691 2019-06-25  Tom Tromey  <tom@tromey.com>
4692
4693         * tui/tui.c (tui_rl_other_window, tui_enable)
4694         (tui_is_window_visible, tui_get_command_dimension): Update.
4695         * tui/tui-winsource.c (tui_update_source_window_as_is)
4696         (tui_clear_source_content, tui_erase_source_content)
4697         (tui_show_source_line, tui_source_window_base::refill)
4698         (tui_source_window_base::do_scroll_horizontal)
4699         (tui_source_window_base::set_is_exec_point_at)
4700         (tui_update_breakpoint_info, tui_set_exec_info_content)
4701         (tui_alloc_source_buffer, tui_line_is_displayed)
4702         (tui_addr_is_displayed): Update.
4703         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4704         (tui_check_and_display_highlight_if_needed)
4705         (tui_win_info::make_visible, tui_win_info::refresh)
4706         (tui_refresh_all): Update.
4707         * tui/tui-windata.c (tui_first_data_item_displayed)
4708         (tui_delete_data_content_windows, tui_erase_data_content)
4709         (tui_display_all_data, tui_data_window::refresh_all)
4710         (tui_check_data_values): Update.
4711         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4712         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4713         (tui_win_info::backward_scroll, tui_refresh_all_win)
4714         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4715         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4716         (tui_source_window_base::set_new_height)
4717         (tui_data_window::set_new_height)
4718         (make_invisible_and_set_new_height)
4719         (make_visible_with_new_height, new_height_ok)
4720         (parse_scrolling_args): Update.
4721         * tui/tui-stack.c (tui_show_frame_info): Update.
4722         * tui/tui-source.c (tui_set_source_content)
4723         (tui_set_source_content_nil, tui_source_is_displayed)
4724         (tui_source_window::do_scroll_vertical): Update.
4725         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4726         (tui_display_registers_from, tui_display_reg_element_at_line)
4727         (tui_check_register_values, tui_reg_command): Update.
4728         * tui/tui-layout.c (tui_default_win_height)
4729         (show_source_disasm_command, show_data, init_and_make_win)
4730         (show_source_or_disasm_and_command): Update.
4731         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4732         (tui_redisplay_readline, tui_mld_flush)
4733         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4734         (tui_getc): Update.
4735         * tui/tui-disasm.c (tui_set_disassem_content)
4736         (tui_disasm_window::do_scroll_vertical): Update.
4737         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4738         Now virtual.
4739         (struct tui_win_info): Derive from tui_gen_win_info.
4740         <~tui_win_info>: Mark as override.
4741         <generic>: Remove member.
4742         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4743         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4744         (~tui_data_window, ~tui_win_info)
4745         (tui_free_all_source_wins_content): Update.
4746         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4747
4748 2019-06-25  Tom Tromey  <tom@tromey.com>
4749
4750         * tui/tui-layout.c (init_and_make_win): Use new.
4751         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4752         destructor, initializers.
4753         (tui_alloc_generic_win_info): Don't declare.
4754         * tui/tui-data.c (_locator): Add argument to constructor.
4755         (source_win, disasm_win): New globals.
4756         (exec_info): Remove.
4757         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4758         Update.
4759         (tui_alloc_generic_win_info): Remove.
4760         (init_content_element): Use new.
4761         (tui_win_info::tui_win_info): Update.
4762         (free_content_elements) <case DATA_WIN>: Use delete.
4763
4764 2019-06-25  Tom Tromey  <tom@tromey.com>
4765
4766         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4767         * tui/tui-windata.c (tui_first_data_item_displayed)
4768         (tui_delete_data_content_windows): Update.
4769         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4770         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4771         (tui_display_registers_from, tui_check_register_values): Update.
4772         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4773         pointer.
4774         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4775         window.
4776         (tui_free_data_content): Update.
4777         (free_content_elements) <case DATA_WIN>: Free the window.
4778
4779 2019-06-25  Tom Tromey  <tom@tromey.com>
4780
4781         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4782         Update.
4783         * tui/tui-layout.c (make_command_window)
4784         (show_source_disasm_command, show_data, init_and_make_win)
4785         (show_source_or_disasm_and_command): Update.
4786         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4787         method.
4788         <can_highight, is_highlighted>: Now bool.
4789         (tui_set_win_highlight): Don't declare.
4790         * tui/tui-data.c (tui_set_win_highlight): Remove.
4791
4792 2019-06-25  Tom Tromey  <tom@tromey.com>
4793
4794         * tui/tui-wingeneral.c (make_visible): Remove check of window
4795         type.
4796
4797 2019-06-25  Tom Tromey  <tom@tromey.com>
4798
4799         * tui/tui-win.c (tui_win_info::max_height)
4800         (tui_cmd_window::max_height): New methods.
4801         (new_height_ok): Call max_height.
4802         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4803         <max_height>: New method.
4804
4805 2019-06-25  Tom Tromey  <tom@tromey.com>
4806
4807         * tui/tui-win.c (tui_source_window_base::set_new_height)
4808         (tui_data_window::set_new_height): New methods.
4809         (make_invisible_and_set_new_height): Call set_new_height method.
4810         * tui/tui-data.h (struct tui_win_info)
4811         (struct tui_source_window_base, struct tui_data_window)
4812         <set_new_height>: New method.
4813
4814 2019-06-25  Tom Tromey  <tom@tromey.com>
4815
4816         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4817         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4818         tui_refresh_data_win.
4819         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4820         method.
4821         (tui_refresh_all_win): Call the refresh_all method.
4822         (tui_set_focus): Likewise.
4823         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4824         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4825         Likewise.
4826
4827 2019-06-25  Tom Tromey  <tom@tromey.com>
4828
4829         * tui/tui-winsource.h (tui_refill_source_window)
4830         (tui_set_is_exec_point_at): Don't declare.
4831         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4832         (tui_source_window_base::refill): Rename from
4833         tui_refill_source_window.
4834         (tui_source_window_base::do_scroll_horizontal): Update.
4835         (tui_source_window_base::set_is_exec_point_at): Rename from
4836         tui_set_is_exec_point_at.
4837         (tui_update_all_breakpoint_info): Update.
4838         * tui/tui-stack.c (tui_show_frame_info): Update.
4839         * tui/tui-layout.c (show_data): Add cast.
4840         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4841         * tui/tui-data.h (struct tui_source_window_base) <refill,
4842         set_is_exec_point_at>: New methods.
4843         (tui_source_windows, tui_add_to_source_windows): Update types.
4844         (tui_add_to_source_windows): Remove redundant declaration.
4845         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4846         (tui_source_windows): Change return type.
4847         (tui_clear_source_windows_detail): Update.
4848         (tui_add_to_source_windows): Change type of parameter.
4849         (tui_free_all_source_wins_content): Update.
4850
4851 2019-06-25  Tom Tromey  <tom@tromey.com>
4852
4853         * tui/tui-wingeneral.c (tui_win_info::refresh)
4854         (tui_source_window_base::refresh): New methods.
4855         (tui_refresh_all): Call the refresh method.
4856         * tui/tui-data.h (struct tui_win_info)
4857         (struct tui_source_window_base) <refresh>: New method.
4858
4859 2019-06-25  Tom Tromey  <tom@tromey.com>
4860
4861         * tui/tui.h (tui_is_window_visible): Return bool.
4862         * tui/tui.c (tui_is_window_visible): Return bool.
4863         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4864         (tui_make_visible, tui_make_invisible)
4865         (tui_win_info::make_visible)
4866         (tui_source_window_base::make_visible, make_all_visible)
4867         (tui_make_all_visible, tui_make_all_invisible): Update.
4868         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4869         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4870         bool.
4871         (struct tui_win_info, struct tui_source_window_base)
4872         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4873         * tui/tui-data.c (tui_init_generic_part): Update.
4874
4875 2019-06-25  Tom Tromey  <tom@tromey.com>
4876
4877         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4878         (tui_source_window_base::make_visible): New methods.
4879         (make_all_visible): Make method call.
4880         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4881         (struct tui_source_window_base, struct tui_cmd_window): Override
4882         make_visible.
4883         (tui_win_is_source_type): Don't declare.
4884         * tui/tui-data.c (tui_win_is_source_type): Remove.
4885
4886 2019-06-25  Tom Tromey  <tom@tromey.com>
4887
4888         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4889         NULL check.
4890
4891 2019-06-25  Tom Tromey  <tom@tromey.com>
4892
4893         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4894         Inline constructor.  Add initializers for members.
4895         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4896         constructors; now inline in class.
4897
4898 2019-06-25  Tom Tromey  <tom@tromey.com>
4899
4900         * tui/tui-regs.c (tui_show_registers): Update.
4901         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4902         bool.
4903         * tui/tui-data.c (tui_data_window::clear_detail)
4904         (tui_data_window): Update.
4905
4906 2019-06-25  Tom Tromey  <tom@tromey.com>
4907
4908         * tui/tui-windata.c (tui_display_all_data)
4909         (tui_display_data_from_line, tui_display_data_from)
4910         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4911         Update.
4912         * tui/tui-regs.c (tui_last_regs_line_no)
4913         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4914         (tui_show_registers, tui_show_register_group)
4915         (tui_display_registers_from, tui_display_reg_element_at_line)
4916         (tui_display_registers_from_line, tui_check_register_values)
4917         (tui_reg_next, tui_reg_prev): Update.
4918         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4919         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4920         tui_data_window.
4921         (struct tui_win_info) <detail>: Remove.  Add new fields from
4922         tui_data_info.
4923         (TUI_DATA_WIN): Add cast.
4924         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4925         (~tui_data_window): Simplify.
4926
4927 2019-06-25  Tom Tromey  <tom@tromey.com>
4928
4929         * tui/tui-layout.c (show_source_disasm_command)
4930         (show_source_or_disasm_and_command): Update.
4931         * tui/tui-io.c (update_cmdwin_start_line)
4932         (tui_redisplay_readline): Update.
4933         * tui/tui-data.h (struct tui_command_info): Remove.
4934         (struct tui_win_info) <detail>: Remove command_info member.
4935         (struct tui_data_window) <start_line>: New member, from
4936         tui_command_info.
4937         (TUI_CMD_WIN): Add casts.
4938
4939 2019-06-25  Tom Tromey  <tom@tromey.com>
4940
4941         * tui/tui-winsource.c (tui_update_source_window)
4942         (tui_refill_source_window)
4943         (tui_source_window_base::do_scroll_horizontal)
4944         (tui_update_breakpoint_info, tui_set_exec_info_content)
4945         (tui_show_exec_info_content, tui_erase_exec_info_content)
4946         (tui_clear_exec_info_content): Update.
4947         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4948         Update.
4949         * tui/tui-win.c (make_invisible_and_set_new_height)
4950         (make_visible_with_new_height): Update.
4951         * tui/tui-source.c (tui_set_source_content)
4952         (tui_show_symtab_source): Update.
4953         * tui/tui-layout.c (extract_display_start_addr)
4954         (show_source_disasm_command, show_data)
4955         (make_source_or_disasm_window)
4956         (show_source_or_disasm_and_command): Update.
4957         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4958         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4959         "gdbarch".
4960         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4961         to tui_source_window_base.
4962         (struct tui_win_info) <detail>: Remove source_info member.
4963         (struct tui_source_window_base) <has_locator>: Inline.
4964         Move contents from tui_source_info; rename has_locator member to
4965         m_has_locator.
4966         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4967         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4968         header file.
4969         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4970         Simplify.
4971         (tui_free_all_source_wins_content): Cast to
4972         tui_source_window_base.
4973
4974 2019-06-25  Tom Tromey  <tom@tromey.com>
4975
4976         * tui/tui-win.c (make_invisible_and_set_new_height)
4977         (make_visible_with_new_height): Call has_locator method.
4978         * tui/tui-layout.c (show_source_disasm_command, show_data)
4979         (show_source_or_disasm_and_command): Update for bool change.
4980         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4981         (tui_win_info) <has_locator>: New method.
4982         (struct tui_source_window_base) <has_locator>: New method.
4983         (tui_win_has_locator): Don't declare.
4984         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4985         from tui_win_has_locator.
4986         (tui_source_window_base): Use false, not FALSE.
4987
4988 2019-06-25  Tom Tromey  <tom@tromey.com>
4989
4990         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4991         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4992         clear_detail method directly.
4993         (tui_clear_win_detail): Remove.
4994
4995 2019-06-25  Tom Tromey  <tom@tromey.com>
4996
4997         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4998         "this", not TUI_DISASM_WIN.
4999
5000 2019-06-25  Tom Tromey  <tom@tromey.com>
5001
5002         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5003         declare.
5004         * tui/tui-winsource.c
5005         (tui_source_window_base::do_scroll_horizontal): Rename from
5006         tui_horizontal_source_scroll.
5007         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5008         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5009         from tui_vertical_data_scroll.
5010         * tui/tui-win.h (tui_scroll): Don't declare.
5011         * tui/tui-win.c (tui_win_info::forward_scroll)
5012         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5013         (tui_win_info::right_scroll): Rename and update.
5014         (tui_scroll_forward_command, tui_scroll_backward_command)
5015         (tui_scroll_left_command, tui_scroll_right_command): Update.
5016         (tui_scroll): Remove.
5017         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5018         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5019         from tui_vertical_source_scroll.
5020         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5021         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5022         from tui_vertical_disassem_scroll.
5023         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5024         do_scroll_horizontal>: New methods.
5025         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5026         Likewise.
5027         (struct tui_source_window_base): Add do_scroll_horizontal.
5028         (struct tui_source_window, struct tui_disasm_window): Add
5029         do_scroll_vertical.
5030         (struct tui_data_window, struct tui_cmd_window): Add
5031         do_scroll_horizontal and do_scroll_vertical.
5032         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5033
5034 2019-06-25  Tom Tromey  <tom@tromey.com>
5035
5036         * tui/tui-data.h (struct tui_source_window_base): New struct.
5037         (struct tui_source_window): Derive from tui_source_window_base.
5038         (struct tui_disasm_window): New struct.
5039         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5040         from tui_source_window::clear_detail.
5041         (tui_source_window_base): Rename from tui_source_window.
5042         (~tui_source_window_base): Rename from ~tui_source_window.
5043         (tui_alloc_win_info): Create a tui_disasm_window.
5044
5045 2019-06-25  Tom Tromey  <tom@tromey.com>
5046
5047         * tui/tui-data.h (struct tui_source_window)
5048         (struct tui_data_window): Declare destructors.
5049         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5050         destructors.
5051         (tui_win_info): Simplify.
5052
5053 2019-06-25  Tom Tromey  <tom@tromey.com>
5054
5055         * tui/tui-winsource.c (tui_display_main)
5056         (tui_update_source_windows_with_addr)
5057         (tui_update_all_breakpoint_info): Update.
5058         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5059         (new_height_ok, parse_scrolling_args): Update.
5060         * tui/tui-stack.c (tui_show_frame_info): Update.
5061         * tui/tui-data.h (struct tui_list): Remove.
5062         (tui_source_windows): Return a reference to a std::vector.
5063         * tui/tui-data.c (source_windows): Now a std::vector.
5064         (tui_source_windows): Change return type.
5065         (tui_clear_source_windows): Rewrite.
5066         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5067         (tui_free_all_source_wins_content): Rewrite.
5068
5069 2019-06-25  Tom Tromey  <tom@tromey.com>
5070
5071         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5072         (struct tui_data_window, struct tui_cmd_window): Declare
5073         clear_detail method.
5074         * tui/tui-data.c (tui_source_window::clear_detail)
5075         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5076         methods.
5077         (tui_clear_win_detail): Simplify.
5078
5079 2019-06-25  Tom Tromey  <tom@tromey.com>
5080
5081         * tui/tui-layout.c (make_source_window, make_disasm_window)
5082         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5083         Return the new window.
5084         (show_source_disasm_command, show_data)
5085         (show_source_or_disasm_and_command): Update.
5086
5087 2019-06-25  Tom Tromey  <tom@tromey.com>
5088
5089         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5090         parameter.  Return the new window.
5091         (show_source_disasm_command): Update and remove NULL check.
5092         (show_source_or_disasm_and_command): Update.
5093
5094 2019-06-25  Tom Tromey  <tom@tromey.com>
5095
5096         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5097
5098 2019-06-25  Tom Tromey  <tom@tromey.com>
5099
5100         * tui/tui-data.h (struct tui_win_info): Make constructor
5101         protected.  Make destructor virtual.  Add initializers.
5102         (tui_source_window, tui_data_window, tui_cmd_window): New
5103         classes.
5104         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5105         constructor.  Add "type" parameter.
5106         (tui_source_window, tui_data_window, tui_cmd_window): New
5107         constructors.
5108         (tui_alloc_win_info): Instantiate the appropriate subclass.
5109
5110 2019-06-25  Tom Tromey  <tom@tromey.com>
5111
5112         * tui/tui-win.c (tui_resize_all): Use delete.
5113         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5114         destructor.
5115         (tui_free_window): Don't declare.
5116         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5117         Update.
5118
5119 2019-06-25  Tom Tromey  <tom@tromey.com>
5120
5121         * tui/tui-data.h (struct tui_win_info): Add constructor.
5122         * tui/tui-data.c (tui_alloc_win_info): Use new.
5123         (tui_free_window): Use delete.
5124
5125 2019-06-22  Tom Tromey  <tom@tromey.com>
5126
5127         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5128         declare.
5129         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5130
5131 2019-06-22  Tom Tromey  <tom@tromey.com>
5132
5133         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5134         declare.
5135         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5136
5137 2019-06-22  Tom de Vries  <tdevries@suse.de>
5138
5139         * dwarf2read.c (create_addrmap_from_aranges)
5140         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5141         instead of '%zu'.
5142
5143 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5144
5145         * dwarf2read.h (dwarf2_section_info_def): Remove.
5146         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5147         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5148         std::vector<dwarf2_section_info>.
5149         (struct dwo_file) <~dwo_file>: Remove.
5150         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5151         types field.
5152         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5153         (dwarf2_read_debug_names): Likewise.
5154         (create_debug_types_hash_table): Change parameter type to
5155         array_view, adjust code accordingly.
5156         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5157         (partial_die_info::fixup): Likewise.
5158         (determine_prefix): Likewise.
5159         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5160
5161 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5162
5163         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5164         gdb_bfd_ref_ptr.
5165         <~dwo_file>: Remove call to gdb_bfd_unref.
5166         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5167         gdb_bfd_ref_ptr::get.
5168
5169 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5170
5171         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5172         type to htab_up.
5173         * dwarf2read.c (struct dwo_file): Initialize fields.
5174         <~dwo_file>: New.
5175         (free_dwo_file): Remove, move content to ~dwo_file.
5176         (struct dwo_file_deleter): Remove.
5177         (dwo_file_up>: Remove custom deleter.
5178         (free_dwo_files): Remove.
5179         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5180         dwo_files.
5181         (process_skeletonless_type_units): Call unique_ptr::get.
5182         (allocate_dwo_file_hash_table): Add deleter to created hash
5183         table.  Change return type to htab_up.
5184         (lookup_dwo_file_slot): Don't memset dwo_file, call
5185         unique_ptr::get.
5186         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5187         (create_dwo_unit_in_dwp_v2): Likewise.
5188         (open_and_init_dwo_file): Likewise.
5189         (free_dwo_file_from_slot): Remove.
5190
5191 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5192
5193         * dwarf2read.h (struct dwarf2_section_info) <readin,
5194         is_virtual>: Change type to bool.
5195         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5196         true instead of 1.
5197
5198 2019-06-19  Tom Tromey  <tom@tromey.com>
5199
5200         * tui/tui-data.h (tui_init_content_element): Don't declare.
5201
5202 2019-06-19  Tom Tromey  <tom@tromey.com>
5203
5204         * tui/tui-data.h (tui_init_win_info): Don't declare.
5205
5206 2019-06-19  Tom de Vries  <tdevries@suse.de>
5207
5208         * dwarf2read.h (abstract_to_concrete): Change type to
5209         std::unordered_map<sect_offset, std::vector<sect_offset>,
5210         gdb::hash_enum<sect_offset>>.
5211
5212 2019-06-19  Tom Tromey  <tromey@adacore.com>
5213
5214         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5215         EVAL_AVOID_SIDE_EFFECTS specially.
5216
5217 2019-06-19  Tom Tromey  <tromey@adacore.com>
5218
5219         * source-cache.c (highlighter): New global.
5220         (source_cache::get_source_lines): Create a highlighter on demand.
5221
5222 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5223
5224         * defs.h (deprecated_interactive_hook): Delete declaration.
5225         * interps.c (clear_interpreter_hooks): Remove use of
5226         deprecated_interactive_hook.
5227         * top.c (deprecated_interactive_hook): Delete definition.
5228         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5229
5230 2019-06-18  Tom de Vries  <tdevries@suse.de>
5231
5232         PR gdb/24515
5233         * dwarf2read.h (abstract_to_concrete): Change type from
5234         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5235         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5236         * dwarf2read.c (read_variable): Update.
5237         (dwarf2_fetch_die_loc_sect_off): Update.
5238
5239 2019-06-17  Tom de Vries  <tdevries@suse.de>
5240
5241         PR gdb/24617
5242         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5243         accessing parent[parent_len - 1].
5244
5245 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5246
5247         PR gdb/24364
5248         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5249         call dtrace_process_dof with NULL dof.
5250
5251 2019-06-16  Tom de Vries  <tdevries@suse.de>
5252
5253         PR gdb/24445
5254         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5255
5256 2019-06-16  Tom Tromey  <tom@tromey.com>
5257
5258         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5259         (make_all_visible): Use address of member.
5260
5261 2019-06-16  Tom Tromey  <tom@tromey.com>
5262
5263         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5264         (tui_free_window, free_content, free_content_elements): Remove
5265         unnecessary cast.
5266         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5267         cast.
5268         * tui/tui-regs.c (tui_show_register_group)
5269         (tui_display_registers_from, tui_display_reg_element_at_line):
5270         Remove unnecessary cast.
5271
5272 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5273
5274         * linux-nat.c (normal_mask): Delete.
5275         (_initialize_linux_nat): Don't initialise normal_mask.
5276
5277 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5278
5279         PR gdb/24445
5280         * dwarf-index-write.h (write_psymtabs_to_index): Add
5281         dwz_basename parameter.
5282         * dwarf-index-write.c (write_gdbindex): Move file writing to
5283         write_gdbindex_1.  Change return type void.
5284         (assert_file_size): Move up, remove filename parameter.
5285         (write_gdbindex_1): New function.
5286         (write_debug_names): Change return type to void, call
5287         assert_file_size.
5288         (struct index_wip_file): New struct.
5289         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5290         file logic to index_wip_file.  Write index for dwz file if
5291         needed.
5292         (save_gdb_index_command): Pass basename of dwz file, if present.
5293         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5294         build-id of dwz file, if present.
5295         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5296         (dwarf2_get_dwz_file): Likewise.
5297         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5298         (dwarf2_get_dwz_file): Likewise.
5299
5300 2019-06-16  Tom Tromey  <tom@tromey.com>
5301
5302         * coffread.c (process_coff_symbol): Use xstrdup.
5303         * value.c (create_internalvar): Use xstrdup.
5304
5305 2019-06-16  Tom Tromey  <tom@tromey.com>
5306
5307         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5308         * breakpoint.c (stopin_command, stopat_command)
5309         (until_break_command, decode_location_default): Remove unnecessary
5310         cast.
5311         * utils.c (subset_compare): Remove unnecessary cast.
5312         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5313         cast.
5314         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5315         cast.
5316         * infcmd.c (path_command): Remove unnecessary cast.
5317         * coffread.c (decode_type): Remove unnecessary cast.
5318         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5319         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5320         * tui/tui-stack.c (tui_show_locator_content)
5321         (tui_show_frame_info): Remove unnecessary cast.
5322         * tui/tui-win.c (tui_scroll_forward_command)
5323         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5324         (parse_scrolling_args): Remove unnecessary cast.
5325         * tui/tui-data.c (init_win_info, tui_del_window)
5326         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5327         (free_content_elements): Remove unnecessary cast.
5328         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5329         unnecessary cast.
5330         * tui/tui-source.c (tui_set_source_content)
5331         (tui_vertical_source_scroll): Remove unnecessary cast.
5332         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5333         cast.
5334         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5335         * tui/tui-regs.c (tui_display_registers_from)
5336         (tui_display_register): Remove unnecessary cast.
5337         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5338         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5339         (make_visible): Remove unnecessary cast.
5340         * tui/tui-winsource.c (tui_erase_source_content)
5341         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5342         unnecessary cast.
5343         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5344         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5345         * stabsread.c (read_type, read_array_type, read_range_type):
5346         Remove unnecessary cast.
5347         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5348         (parse_symbol, parse_type, upgrade_type, parse_external)
5349         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5350         unnecessary cast.
5351         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5352
5353 2019-06-16  Tom Tromey  <tom@tromey.com>
5354
5355         * tui/tui-data.c (tui_alloc_generic_win_info)
5356         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5357         checks.
5358
5359 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5360             Andrew Burgess  <andrew.burgess@embecosm.com>
5361
5362         * f-typeprint.c (f_print_type): Don't return early for not
5363         associated or not allocated types.
5364         (f_type_print_varspec_suffix): Add print_rank parameter and print
5365         ranks of array types in case they dangling.
5366         (f_type_print_base): Add print_rank parameter.
5367
5368 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5369
5370         * NEWS: Mention new MI commands.
5371         * break-catch-throw.c (enum exception_event_kind): Move to
5372         breakpoint.h.
5373         (print_mention_exception_catchpoint): Output text as a single
5374         message.
5375         (catch_exception_command_1): Rename to...
5376         (catch_exception_event): ...this, make non-static, update header
5377         command, and change some parameter types.
5378         (catch_catch_command): Update for changes to
5379         catch_exception_command_1.
5380         (catch_throw_command): Likewise.
5381         (catch_rethrow_command): Likewise.
5382         * breakpoint.c (enum exception_event_kind): Delete.
5383         * breakpoint.h (enum exception_event_kind): Moved here from
5384         break-catch-throw.c.
5385         (catch_exception_event): Declare.
5386         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5387         (mi_cmd_catch_throw): New function.
5388         (mi_cmd_catch_rethrow): New function.
5389         (mi_cmd_catch_catch): New function.
5390         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5391         'catch-catch' entries.
5392         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5393         (mi_cmd_catch_rethrow): Declare.
5394         (mi_cmd_catch_catch): Declare.
5395
5396 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5397
5398         * annotate.c (annotate_source_line): Change return type to void,
5399         update implementation to match.
5400         * annotate.h (annotate_source_line): Change return type to void,
5401         update header comment.
5402         * stack.c (print_frame_info): Don't change what frame information
5403         is printed based on whether annotations are on or not.
5404
5405 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5406
5407         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5408         (annotate_source): Make static.
5409         (annotate_source_line): Moved from source.c and renamed from
5410         identify_source_line.  Update the return type.
5411         * annotate.h (annotate_source): Delete declaration.
5412         (annotate_source_line): Declaration moved from source.h, and
5413         renamed from identify_source_line.  Return type updated.
5414         * source.c (identify_source_line): Moved to annotate.c and renamed
5415         to annotate_source_line.
5416         (info_line_command): Remove check of annotation_level.
5417         * source.h (identify_source_line): Move declaration to annotate.h
5418         and rename to annotate_source_line.
5419         * stack.c: Add 'annotate.h' include.
5420         (print_frame_info): Remove check of annotation_level before
5421         calling annotate_source_line.
5422
5423 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5424
5425         * source-cache.c (source_cache::get_plain_source_lines): Use
5426         open_source_file_with_line_charpos instead of just
5427         open_source_file, remove call to find_source_lines.
5428         (source_cache::get_source_lines): Likewise.
5429         * source.c (find_source_lines): Make static.
5430         (get_filename_and_charpos): Renamed into...
5431         (open_source_file_with_line_charpos): ..this along with changes to
5432         return a scoped_fd, and some other minor clean ups.
5433         (identify_source_line): Use open_source_file_with_line_charpos.
5434         (search_command_helper): Use open_source_file_with_line_charpos
5435         instead of just open_source_file, remove call to
5436         find_source_lines.
5437         * source.h (open_source_file_with_line_charpos): Declare new
5438         function.
5439         (find_source_lines): Delete declaration.
5440
5441 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5442
5443         * source.c (get_filename_and_charpos): Remove fullname
5444         parameter.
5445         (identify_source_line): Update call to get_filename_and_charpos.
5446
5447 2019-06-14  Tom Tromey  <tromey@adacore.com>
5448
5449         PR gdb/24502:
5450         * ui-style.h (skip_ansi_escape): Update comment.
5451         * ui-file.h (class no_terminal_escape_file): New class.
5452         * ui-file.c (no_terminal_escape_file::write)
5453         (no_terminal_escape_file::puts): New methods.
5454         * cli/cli-logging.c (handle_redirections): Use
5455         no_terminal_escape_file.
5456
5457 2019-06-14  Tom Tromey  <tromey@adacore.com>
5458
5459         * NEWS: Move convenience variable news above Python news.
5460
5461 2019-06-14  Tom Tromey  <tom@tromey.com>
5462
5463         * gnulib: Move directory to top-level.
5464         * configure.ac: Don't configure gnulib.
5465         * configure: Rebuild.
5466         * common/common-defs.h: Use new path to gnulib.
5467         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5468         (GNULIB_H): Remove.
5469         (INCGNU): Look in new gnulib location.
5470         (HFILES_NO_SRCDIR): Remove gnulib files.
5471         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5472         (generated_files): Remove GNULIB_H.
5473         ($(LIBGNU), all-lib): Remove targets.
5474         (distclean): Don't mention GNULIB_BUILDDIR.
5475         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5476
5477 2019-06-14  Tom Tromey  <tromey@adacore.com>
5478
5479         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5480         Warn if symbol file does not provide any symbols.
5481
5482 2019-06-14  Tom Tromey  <tromey@adacore.com>
5483
5484         * source.c (find_and_open_source): Respect basenames_may_differ.
5485
5486 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5487
5488         * annotate.c (annotate_breakpoints_invalid): Make use of
5489         scoped_restore_terminal_state.
5490         (annotate_frames_invalid): Likewise.
5491
5492 2019-06-14  Tom Tromey  <tromey@adacore.com>
5493
5494         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5495         allow assignment to an internalvar.
5496
5497 2019-06-14  Tom Tromey  <tromey@adacore.com>
5498
5499         * ada-lex.l: Allow "_" in attribute names.
5500
5501 2019-06-14  Tom Tromey  <tromey@adacore.com>
5502
5503         PR gdb/24653:
5504         * regcache.c (registers_changed): Don't call alloca.
5505         * top.c (execute_command): Don't call alloca.
5506
5507 2019-06-13  Pedro Alves  <palves@redhat.com>
5508
5509         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5510         'expression'.  When parsing an expression, error out if there's
5511         junk after "unlimited".
5512         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5513         (do_set_command): Adjust calls to is_unlimited_literal.
5514
5515 2019-06-13  Pedro Alves  <palves@redhat.com>
5516
5517         * compile/compile.c (make_compile_options_def_group): Add braces
5518         around array_view initializer.
5519         * thread.c (make_thread_apply_all_options_def_group)
5520         (make_thread_apply_all_options_def_group): Likewise.
5521
5522 2019-06-13  Pedro Alves  <palves@redhat.com>
5523
5524         * NEWS (New commands): Mention "maint test-options
5525         require-delimiter", "maint test-options unknown-is-error", "maint
5526         test-options unknown-is-operand" and "maint show
5527         test-options-completion-result".
5528         (New command options, command completion): New section.
5529         (Completion improvements): New section.
5530         Mention that you can abbreviate "unlimited".
5531
5532 2019-06-13  Pedro Alves  <palves@redhat.com>
5533
5534         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5535         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5536         * unittests/cli-utils-selftests.c (test_parse_flags)
5537         (test_parse_flags_qcs): Delete.
5538         (test_cli_utils): Don't call deleted functions.
5539
5540 2019-06-13  Pedro Alves  <palves@redhat.com>
5541
5542         * thread.c: Include "cli/cli-option.h".
5543         (tp_array_compar_ascending): Global.
5544         (tp_array_compar): Delete function.
5545         (tp_array_compar_ascending, tp_array_compar_descending): New
5546         functions.
5547         (ascending_option_def, qcs_flag_option_def)
5548         (thr_qcs_flags_option_defs)
5549         (make_thread_apply_all_options_def_group)
5550         (make_thread_apply_options_def_group): New.
5551         (thread_apply_all_command): Use gdb::option::process_options.
5552         (thread_apply_command_completer)
5553         (thread_apply_all_command_completer): New.
5554         (thread_apply_command): Use gdb::option::process_options.
5555         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5556         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5557         to generate help text of "thread apply".  Adjust "taas"'s help.
5558         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5559         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5560
5561 2019-06-13  Pedro Alves  <palves@redhat.com>
5562
5563         * thread.c (thread_apply_command): Check for invalid TID with
5564         isdigit instead of !isalpha.
5565
5566 2019-06-13  Pedro Alves  <palves@redhat.com>
5567
5568         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5569         (validate_flags_qcs): New.
5570         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5571         (validate_flags_qcs): Declare.
5572         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5573         (make_frame_apply_options_def_group): New.
5574         (frame_apply_command_count): Process options with
5575         gdb::option::process_options.
5576         (frame_apply_completer): New.
5577         (frame_apply_level_completer, frame_apply_all_completer)
5578         (frame_apply_completer): New.
5579         (_initialize_stack): Update help of "frame apply", "frame apply
5580         level", "frame apply all" and "faas" to mention supported options
5581         and install command completers.
5582         * stack.h (frame_apply_all_completer): Declare.
5583         * thread.c: Include "stack.h".
5584         (tfaas_command): Add "--".
5585         (_initialize_thread): Update help "tfaas" to mention supported
5586         options and install command completer.
5587
5588 2019-06-13  Pedro Alves  <palves@redhat.com>
5589
5590         * completer.c (complete_nested_command_line): New.
5591         (gdb_completion_word_break_characters_throw): Add assertion.
5592         * completer.h (complete_nested_command_line): Declare.
5593
5594 2019-06-13  Pedro Alves  <palves@redhat.com>
5595
5596         * stack.c (parse_backtrace_qualifiers): New.
5597         (backtrace_command): Use it.
5598         (backtrace_command_completer): Complete on qualifiers.
5599
5600 2019-06-13  Pedro Alves  <palves@redhat.com>
5601
5602         * frame.c: Include "cli/cli-option.h.
5603         (user_set_backtrace_options): New.
5604         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5605         Delete.
5606         (get_prev_frame): Adjust.
5607         (boolean_option_def, uinteger_option_def)
5608         (set_backtrace_option_defs): New.
5609         (_initialize_frame): Adjust and use
5610         gdb::option::add_setshow_cmds_for_options to install "set
5611         backtrace past-main" and "set backtrace past-entry".
5612         * frame.h: Include "cli/cli-option.h".
5613         (struct frame_print_options): Forward declare.
5614         (print_frame_arguments_all, print_frame_arguments_scalars)
5615         (print_frame_arguments_none): Declare.
5616         (print_entry_values): Delete declaration.
5617         (struct frame_print_options, user_frame_print_options): New.
5618         (struct set_backtrace_options): New.
5619         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5620         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5621         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5622         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5623         (list_args_or_locals): Add frame_print_options parameter.
5624         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5625         * python/py-framefilter.c (enumerate_args): Pass down
5626         USER_FRAME_PRINT_OPTIONS.
5627         * stack.c: Include "cli/cli-option.h".
5628         (print_frame_arguments_all, print_frame_arguments_scalars)
5629         (print_frame_arguments_none): Declare.
5630         (print_raw_frame_arguments, print_entry_values): Delete.
5631         (user_frame_print_options): New.
5632         (boolean_option_def, enum_option_def, frame_print_option_defs):
5633         New.
5634         (struct backtrace_cmd_options): New.
5635         (bt_flag_option_def): New.
5636         (backtrace_command_option_defs): New.
5637         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5638         (print_frame_arg, read_frame_arg, print_frame_args)
5639         (print_frame_info, print_frame): Add frame_print_options parameter
5640         and use it.
5641         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5642         (backtrace_command_1): Add frame_print_options and
5643         backtrace_cmd_options parameters and use them.
5644         (make_backtrace_options_def_group): New.
5645         (backtrace_command): Process command options with
5646         gdb::option::process_options.
5647         (backtrace_command_completer): New.
5648         (_initialize_stack): Extend "backtrace"'s help to mention
5649         supported options.  Install completer for "backtrace".
5650         Install some settings commands with add_setshow_cmds_for_options.
5651
5652 2019-06-13  Pedro Alves  <palves@redhat.com>
5653
5654         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5655         and that "set/show print raw frame-arguments" are now deprecated.
5656
5657         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5658         command.
5659         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5660         * stack.c (_initialize_stack): Install "set/show print
5661         raw-frame-arguments", and deprecate "set/show print raw
5662         frame-arguments".
5663         * valprint.c (_initialize_valprint): Deprecate "set/show print
5664         raw".
5665
5666 2019-06-13  Pedro Alves  <palves@redhat.com>
5667
5668         * compile/compile.c (struct compile_options): New.
5669         (compile_flag_option_def, compile_command_option_defs)
5670         (make_compile_options_def_group): New.
5671         (compile_file_command): Handle options with
5672         gdb::option::process_options.
5673         (compile_file_command_completer): New function.
5674         (compile_code_command): Handle options with
5675         gdb::option::process_options.
5676         (compile_code_command_completer): New function.
5677         (_initialize_compiler): Install completers for "compile code" and
5678         "compile file".  Mention available options in "compile code" and
5679         "compile code"'s help.
5680         * completer.c (advance_to_completion_word): New, factored out from
5681         ...
5682         (advance_to_expression_complete_word_point): ... this.
5683         (advance_to_filename_complete_word_point): New.
5684         * completer.h (advance_to_filename_complete_word_point): New
5685         declaration.
5686
5687 2019-06-13  Pedro Alves  <palves@redhat.com>
5688
5689         * compile/compile.c: Include "cli/cli-option.h".
5690         (compile_print_value): Scope data pointer is now a
5691         value_print_options pointer; adjust.
5692         (compile_print_command): Process options.  Scope data pointer is
5693         now a value_print_options pointer; adjust.
5694         (_initialize_compile): Update "compile print"'s help to include
5695         supported options.  Install a completer for "compile print".
5696         * cp-valprint.c (show_vtblprint, show_objectprint)
5697         (show_static_field_print): Delete.
5698         (_initialize_cp_valprint): Don't install "set print
5699         static-members", "set print vtbl", "set print object" here.
5700         * printcmd.c: Include "cli/cli-option.h" and
5701         "common/gdb_optional.h".
5702         (print_command_parse_format): Rework to fill in a
5703         value_print_options instead of a format_data.
5704         (print_value): Change parameter type from format_data pointer to
5705         value_print_options reference.  Adjust.
5706         (print_command_1): Process options.  Adjust to pass down a
5707         value_print_options.
5708         (print_command_completer): New.
5709         (_initialize_printcmd): Install print_command_completer as
5710         handle_brkchars completer for the "print" command.  Update
5711         "print"'s help to include supported options.
5712         * valprint.c: Include "cli/cli-option.h".
5713         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5714         here from cp-valprint.c.
5715         (boolean_option_def, uinteger_option_def)
5716         (value_print_option_defs, make_value_print_options_def_group):
5717         New.  Use gdb::option::add_setshow_cmds_for_options to install
5718         "set print elements", "set print null-stop", "set print repeats",
5719         "set print pretty", "set print union", "set print array", "set
5720         print address", "set print symbol", "set print array-indexes".
5721         * valprint.h: Include <string> and "cli/cli-option.h".
5722         (make_value_print_options_def_group): Declare.
5723         (print_value): Change parameter type from format_data pointer to
5724         value_print_options reference.
5725         (print_command_completer): Declare.
5726
5727 2019-06-13  Pedro Alves  <palves@redhat.com>
5728
5729         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5730         (COMMON_SFILES): Add maint-test-settings.c.
5731         * cli/cli-decode.c (boolean_enums): New global, factored out from
5732         ...
5733         (add_setshow_boolean_cmd): ... here.
5734         * cli/cli-decode.h (boolean_enums): Declare.
5735         * cli/cli-option.c: New file.
5736         * cli/cli-option.h: New file.
5737         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5738         factored out from ...
5739         (parse_cli_boolean_value(const char *)): ... this.
5740         (is_unlimited_literal): Change parameter type to pointer to
5741         pointer.  Adjust and advance ARG pointer.
5742         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5743         (parse_cli_var_enum): New, factored out from ...
5744         (do_set_command): ... this.  Adjust.
5745         * cli/cli-setshow.h (parse_cli_boolean_value)
5746         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5747         (parse_cli_var_enum): Declare.
5748         * cli/cli-utils.c: Include "cli/cli-option.h".
5749         (get_ulongest): New.
5750         * cli/cli-utils.h (get_ulongest): Declare.
5751         (check_for_argument): New overloads.
5752         * maint-test-options.c: New file.
5753
5754 2019-06-13  Pedro Alves  <palves@redhat.com>
5755
5756         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5757         parse a range if "-" is at the end of the string.
5758
5759 2019-06-13  Pedro Alves  <palves@redhat.com>
5760
5761         * cli/cli-setshow.c (parse_auto_binary_operation)
5762         (parse_cli_boolean_value): Don't allow "o".
5763
5764 2019-06-13  Pedro Alves  <palves@redhat.com>
5765
5766         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5767         * NEWS: Mention maint test-settings KIND.
5768         * maint-test-settings.c: New file.
5769
5770 2019-06-13  Pedro Alves  <palves@redhat.com>
5771
5772         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5773         completer.
5774         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5775         "set" completers.
5776
5777 2019-06-13  Pedro Alves  <palves@redhat.com>
5778
5779         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5780         after item.
5781
5782 2019-06-13  Pedro Alves  <palves@redhat.com>
5783
5784         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5785
5786 2019-06-13  Pedro Alves <palves@redhat.com>
5787
5788         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5789         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5790         call.
5791         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5792         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5793         calls.
5794         (check_for_argument): Skip spaces after argument.
5795
5796 2019-06-13  Pedro Alves  <palves@redhat.com>
5797
5798         * thread.c (thread_apply_command): Adjust TID parsing.
5799         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5800         detected before end of string.
5801         (tid_is_in_list): Error out if LIST is invalid.
5802
5803 2019-06-13  Pedro Alves  <palves@redhat.com>
5804
5805         * completer.c (complete_line_internal_1): Rewind completion word
5806         point.
5807         (completion_tracker::advance_custom_word_point_by): Change
5808         parameter type to int.
5809         * completer.h (completion_tracker::advance_custom_word_point_by):
5810         Likewise.
5811
5812 2019-06-13  Pedro Alves  <palves@redhat.com>
5813
5814         * completer.c (advance_to_completion_word): Handle delimiters.
5815
5816 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5817
5818         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5819
5820 2019-06-11  Tom Tromey  <tom@tromey.com>
5821
5822         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5823         (xmalloc_failed): Move to alloc.c.
5824         * alloc.c: New file.
5825         * Makefile.in (COMMON_SFILES): Add alloc.c.
5826
5827 2019-06-11  Tom Tromey  <tom@tromey.com>
5828
5829         * nat/linux-waitpid.c: Don't include server.h.
5830         (linux_debug): Remove.
5831         (my_waitpid): Update.
5832
5833 2019-06-11  Tom Tromey  <tromey@adacore.com>
5834
5835         * infcall.c (_initialize_infcall): Remove trailing newline from
5836         help.
5837         * user-regs.c (_initialize_user_regs): Remove trailing newline
5838         from help.
5839         * typeprint.c (_initialize_typeprint): Remove trailing newline
5840         from help.
5841         * reverse.c (_initialize_reverse): Remove trailing newlines from
5842         help.
5843         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5844         from help.
5845         * language.c (add_set_language_command): Remove trailing newline
5846         from help.
5847         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5848         help.
5849         * disasm.c (_initialize_disasm): Remove trailing newline from
5850         help.
5851         * top.c (init_main): Remove trailing newline from help.
5852         * interps.c (_initialize_interpreter): Remove trailing newline
5853         from help.
5854         * btrace.c (_initialize_btrace): Remove trailing newlines from
5855         help.
5856         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5857         from help.
5858         * python/python.c (_initialize_python): Remove trailing newline
5859         from help.
5860         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5861         help.
5862         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5863         from help.  Reformat some text.
5864         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5865         from help.
5866         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5867         newline from help.
5868
5869 2019-06-11  Tom Tromey  <tromey@adacore.com>
5870
5871         * darwin-nat.c (darwin_decode_exception_message)
5872         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5873
5874 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5875
5876         * valops.c (value_slice): Check for not allocated or not
5877         associated values.
5878
5879 2019-06-10  Tom de Vries  <tdevries@suse.de>
5880
5881         PR gdb/24618
5882         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5883         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5884         invalid.
5885
5886 2019-06-10  Tom de Vries  <tdevries@suse.de>
5887
5888         PR gdb/24611
5889         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5890         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5891
5892 2019-06-10  Tom de Vries  <tdevries@suse.de>
5893
5894         PR symtab/24545
5895         * symtab.c (struct demangled_name_entry): Add language field.
5896         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5897         static minimal symbol".  Set and use language field.
5898
5899 2019-06-10  Tom Tromey  <tromey@adacore.com>
5900
5901         * ada-lang.c (_initialize_ada_language): Update help text.
5902
5903 2019-06-10  Tom Tromey  <tromey@adacore.com>
5904
5905         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5906         with a newline.
5907         * guile/guile.c (handle_boot_error): Don't end warning with a
5908         newline.
5909         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5910         warning with a newline.
5911         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5912         newline.
5913         (s12z_frame_cache): Likewise.
5914         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5915         a newline.
5916         * solib-svr4.c (disable_probes_interface): Don't end warning with
5917         a newline.
5918         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5919         newline.
5920         * python/python.c (do_finish_initialization): Don't end warning
5921         with a newline.
5922
5923 2019-06-10  Tom Tromey  <tom@tromey.com>
5924
5925         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5926         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5927         gdbpy_enter.
5928
5929 2019-06-10  Tom Tromey  <tromey@adacore.com>
5930
5931         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5932         data.
5933         (elf_new_init): Don't call stabsread_new_init.
5934         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5935         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5936         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5937
5938 2019-06-10  Tom de Vries  <tdevries@suse.de>
5939
5940         PR symtab/16264
5941         PR symtab/24517
5942         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5943
5944 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5945
5946         * source.c (find_and_open_source): Also rewrite relative file
5947         names.
5948
5949 2019-04-26  Amos Bird  <amosbird@gmail.com>
5950
5951         * annotate.c (annotate_thread_exited): Add "thread-exited"
5952         annotation.
5953
5954 2019-06-06  Tom Tromey  <tromey@adacore.com>
5955
5956         * maint.h (class scoped_command_stats): Use
5957         DISABLE_COPY_AND_ASSIGN.
5958         <print_time>: New method.
5959         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5960         print_time.
5961         (scoped_command_stats::print_time): New method.
5962
5963 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5964
5965         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5966         instructions of lengths 6 or 8 bytes.
5967
5968 2019-06-04  Pedro Alves  <palves@redhat.com>
5969
5970         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5971
5972         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5973         * breakpoint.c (condition_completer): Likewise.
5974         * cli/cli-dump.c (scan_expression): Likewise.
5975         * common/filestuff.c (mkdir_recursive): Likewise.
5976         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5977         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5978         (gdb_abspath): Likewise.
5979         * compile/compile-cplus-types.c
5980         (compile_cplus_instance::decl_name): Likewise.
5981         * completer.c (complete_explicit_location):
5982         (signal_completer, reg_or_group_completer_1): Likewise.
5983         * cp-support.c (cp_remove_params_if_any): Likewise.
5984         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5985         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5986         * infcmd.c (strip_bg_char): Likewise.
5987         * linespec.c (copy_token_string): Likewise.
5988         * mi/mi-main.c (output_cores): Likewise.
5989         * psymtab.c (psymtab_search_name):
5990         * symfile.c (test_set_ext_lang_command): Likewise.
5991         * target.c (target_fileio_read_stralloc): Likewise.
5992         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5993         * value.c (complete_internalvar): Likewise.
5994
5995 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5996
5997         Add objfile property to gdb.Type.
5998         * NEWS: Mention Python API addition.
5999         * python/py-type.c (typy_get_objfile): New method.
6000
6001 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6002
6003         * NEWS: Mention the new set|show style [title|highlight].
6004         Mention changes to "show style", "help" and "apropos".
6005
6006 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6007
6008         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6009         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6010         instead of print_help_for_command.
6011         (print_doc_of_command): New function.
6012         (help_list): Add 'apropos -v word' suggestion.
6013         (print_help_for_command): Style the command name using title style.
6014         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6015         (_initialize_cli_cmds): Describe -v in apropos_command help.
6016
6017 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6018
6019         * cli/cli-style.h (cli_style_option): Add name in constructor,
6020         add m_name class member, add constructor with intensity,
6021         add name class function.
6022         (cli_style_option::add_setshow_commands): Remove name argument.
6023         (highlight_style, title_style): New styles.
6024         * cli/cli-style.c (do_show): New function that shows a style
6025         characteristic styling the style name with itself.
6026         (set_style_name): New function.
6027         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6028         Update all callers according to the changes in cli/cli-style.h.
6029         * utils.h (fputs_highlighted): New function.
6030         * utils.c (fputs_highlighted): Likewise.
6031
6032 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6033
6034         * NEWS: Mention new pipe command and new convenience variables.
6035
6036 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6037
6038         * cli/cli-cmds.c (pipe_command): New function.
6039         (_initialize_cli_cmds): Call add_com for pipe_command.
6040         Define | as an alias for pipe.
6041         (exit_status_set_internal_vars): New function.
6042         (shell_escape): Call exit_status_set_internal_vars.
6043         cli/cli-decode.c (find_command_name_length): Recognize | as
6044         a single character command.
6045
6046 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6047
6048         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6049         top.c (execute_command_to_ui_file): New function, mostly a copy
6050         of execute_command_to_string.
6051         (execute_command_to_string): Implement by calling
6052         execute_command_to_ui_file.
6053
6054 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6055
6056         * top.h (saved_command_line): Remove declaration.
6057         * top.c (previous_saved_command_line, previous_repeat_arguments):
6058         New variables.
6059         (saved_command_line): Make static, define together with other
6060         'repeat variables'.
6061         (dont_repeat): Clear repeat_arguments.
6062         (repeat_previous, get_saved_command_line, save_command_line):
6063         New functions.
6064         (gdb_init): Initialize saved_command_line
6065         and previous_saved_command_line.
6066         * main.c (captured_main_1): Remove saved_command_line initialization.
6067         * event-top.c (handle_line_of_input): Update to use
6068         the new 'repeat' related functions instead of direct access to
6069         saved_command_line.
6070         * command.h (repeat_previous, get_saved_command_line,
6071         save_command_line): New declarations.
6072         (dont_repeat): Add comment.
6073
6074 2019-05-30  Tom Tromey  <tromey@adacore.com>
6075
6076         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6077         Fix comment.
6078         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6079
6080 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6081
6082         PR cli/24587
6083         * completer.c (complete): Initialize variable word.
6084
6085 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6086
6087         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6088         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6089         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6090         'body' is NULL to the outter 'if', protecting the '!is_define'
6091         situation as well.
6092
6093 2019-05-29  Tom Tromey  <tromey@adacore.com>
6094
6095         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6096         (dwarf_unknown): New function.
6097         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6098         (dwarf_type_encoding_name): Use dwarf_unknown.
6099
6100 2019-05-29  Tom Tromey  <tromey@adacore.com>
6101
6102         PR c++/20020:
6103         * cp-valprint.c (cp_print_value_fields): Call
6104         cp_print_static_field inside "try".
6105
6106 2019-05-29  Tom Tromey  <tromey@adacore.com>
6107
6108         * inflow.c (struct terminal_info): Add default operator=.
6109         * configure: Rebuild.
6110         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6111         -Wdeprecated-copy-dtor, -Wredundant-move.
6112
6113 2019-05-29  Tom Tromey  <tromey@adacore.com>
6114
6115         * NEWS: Add entry.
6116         * infcmd.c (print_return_value_1): Handle finish_print
6117         option.
6118         (show_print_finish): New function.
6119         (_initialize_infcmd): Add "set/show print finish" commands.
6120         * valprint.c (user_print_options): Initialize new member.
6121         * valprint.h (struct value_print_options) <finish_print>: New
6122         member.
6123
6124 2019-05-28  Tom Tromey  <tromey@adacore.com>
6125
6126         * ada-lang.c (ada_remove_Xbn_suffix)
6127         (find_old_style_renaming_symbol)
6128         (parse_old_style_renaming): Remove.
6129         (ada_find_renaming_symbol): Don't call
6130         find_old_style_renaming_symbol.
6131         (ada_is_renaming_symbol): Rename from
6132         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6133         bool.  Now static.
6134         (ada_read_var_value): Update and simplify.
6135         * ada-exp.y (write_var_or_type): Remove old code.
6136
6137 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6138
6139         * event-top.c: Remove include comment.
6140         * inflow.c (class scoped_ignore_sigttou): Move from here...
6141         * inflow.h (class scoped_ignore_sigttou): ...to here.
6142         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6143         * top.c:  Remove include comment.
6144
6145 2019-05-27  Tom Tromey  <tom@tromey.com>
6146
6147         * NEWS: Fix typo.
6148
6149 2019-05-22  Tom Tromey  <tromey@adacore.com>
6150
6151         * target.c (target_follow_exec): Constify parameter.
6152         * target-delegates.c: Rebuild.
6153         * remote.c (remote_target::follow_exec): Constify parameter.
6154         * infrun.c (follow_exec): Constify parameter.
6155         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6156         (target_follow_exec): Likewise.
6157
6158 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6159
6160         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6161         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6162
6163 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6164
6165         * NEWS: Add debugredirect and testsuite sections.
6166
6167 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6168
6169         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6170         target descriptions using exclusively floating point register name
6171         aliases.
6172
6173 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6174
6175         PR gdb/18644:
6176         * f-lang.c (build_fortran_types): Handle the case where
6177         gdbarch_floatformat_for_type returns a nullptr.
6178
6179 2019-05-21  Tom de Vries  <tdevries@suse.de>
6180
6181         PR cli/24587
6182         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6183
6184 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6185
6186         PR gdb/18644:
6187         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6188         16-byte floats.
6189         * i386-tdep.c (i386_floatformat_for_type): Use
6190         floatformats_ia64_quad for the 16-byte floating point component
6191         within a fortran 32-byte complex number.
6192
6193 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6194
6195         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6196         delete default constructor.
6197         (find_partial_die): Update to return const struct.
6198         (partial_die_parent_scope): Move variable declaration into scope
6199         of its use and change its type to auto.
6200         (guess_partial_die_structure_name): Likewise.
6201         (partial_die_info::fixup): Likewise.
6202
6203 2019-05-17  Tom Tromey  <tromey@adacore.com>
6204
6205         * source.c (find_and_open_source): Remove cast.
6206
6207 2019-05-17  Tom Tromey  <tromey@adacore.com>
6208
6209         * annotate.c (annotate_source): Make "filename" const.
6210         * annotate.h (annotate_source): Use const.
6211
6212 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6213
6214         * disasm.c (set_disassembler_options): Send errors to stderr.
6215
6216 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6217
6218         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6219         (cli_interp_base::set_logging): Check debug_redirect.
6220         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6221         * cli/cli-logging.c (debug_redirect): Add static variable.
6222         (pop_output_files): Add default param.
6223         (handle_redirections): Print debug setting.
6224         (show_logging_command): Likewise.
6225         (_initialize_cli_logging): Add debugredirect command.
6226         * interps.c (current_interp_set_logging): Add debug_redirect
6227         parameter.
6228         * interps.h (set_logging): Add debug_redirect parameter.
6229         (current_interp_set_logging): Likewise.
6230         * mi/mi-common.h: Likewise.
6231         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6232
6233 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6234             Tom Tromey  <tromey@adacore.com>
6235
6236         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6237         directly.
6238         * cli/cli-interp.h (make_logging_output): Remove declaration.
6239         * cli/cli-logging.c (make_logging_output): Remove function.
6240         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6241         directly.
6242         * ui-file.c (tee_file::tee_file): Remove bools.
6243         (tee_file::~tee_file): Remove deletes.
6244         * ui-file.h (tee_file): Remove bools.
6245
6246 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6247
6248         * mi/mi-cmds.h (mi_cmd_complete): New function.
6249         * mi/mi-main.c (mi_cmd_complete): Likewise.
6250         * mi/mi-cmds.c: Define new MI command -complete.
6251         * NEWS: Mention new -complete command.
6252
6253 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6254
6255         * completer.h (complete): New function.
6256         * completer.c (complete): Likewise.
6257         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6258         function defined in completer.h.
6259
6260 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6261
6262         * MAINTAINERS (Write After Approval): Add myself.
6263
6264 2019-05-17  Tom de Vries  <tdevries@suse.de>
6265
6266         PR gdb/24094
6267         * dwarf2read.c (struct cu_partial_die_info): New struct.
6268         (find_partial_die): Return cu_partial_die_info.
6269         (partial_die_parent_scope, guess_partial_die_structure_name)
6270         (partial_die_info::fixup): Handle new return type of find_partial_die.
6271
6272 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6273
6274         PR breakpoints/24541
6275         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6276         "std::string", simplifying the algorithm.
6277
6278 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6279
6280         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6281         (stap_static_probe_ops::get_probes): Likewise.
6282
6283 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6284
6285         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6286         '-')" and "else if".
6287         (stap_parse_single_operand): Join checks for
6288         "gdbarch_stap_parse_special_token_p" and
6289         "gdbarch_stap_parse_special_token" in the same "if" statement.
6290         Invert check when verifying for operation on register
6291         displacement.
6292
6293 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6294
6295         * stap-probe.c (stap_get_opcode): Update comment.
6296         (stap_get_expected_argument_type): Likewise.
6297         (handle_stap_probe): Likewise.
6298
6299 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6300
6301         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6302         return type to 'bool'.  Adjust comment.  Use 'bool' when
6303         appropriate.
6304         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6305         * stap-probe.c (stap_parse_argument_1): Likewise.
6306         (stap_is_operator): Likewise.
6307         (stap_is_generic_prefix): Likewise.
6308         (stap_is_register_prefix): Likewise.
6309         (stap_is_register_indirection_prefix): Likewise.
6310         (stap_is_integer_prefix): Likewise.
6311         (stap_generic_check_suffix): Likewise.
6312         (stap_check_integer_suffix): Likewise.
6313         (stap_check_register_suffix): Likewise.
6314         (stap_check_register_indirection_suffix): Likewise.
6315         (stap_parse_register_operand): Likewise.
6316         (stap_parse_single_operand): Likewise.
6317         (stap_parse_argument_1): Likewise.
6318         (stap_probe::get_argument_count): Likewise.
6319         (stap_is_operator): Likewise.
6320
6321 2019-05-16  Tom Tromey  <tromey@adacore.com>
6322
6323         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6324         keyword to foreach.
6325
6326 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6327
6328         * linux-thread-db.c (try_thread_db_load_1): Change return type
6329         to bool.
6330         (try_thread_db_load): Likewise.
6331         (try_thread_db_load_from_pdir_1): Likewise.
6332         (try_thread_db_load_from_pdir): Likewise.
6333         (try_thread_db_load_from_sdir): Likewise.
6334         (try_thread_db_load_from_dir): Likewise.
6335         (thread_db_load_search): Likewise.
6336         (has_libpthread): Likewise.
6337         (thread_db_load): Likewise.
6338
6339 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6340
6341         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6342         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6343         NULL, and complain/return if that's the case.
6344
6345 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6346
6347         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6348         (advance, posn, abstract_read_memory): New functions.
6349         [struct mem_read_abstraction]: New struct.
6350         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6351
6352 2019-05-14  Tom Tromey  <tromey@adacore.com>
6353
6354         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6355         value is not lval_memory.
6356
6357 2019-05-14  Tom Tromey  <tromey@adacore.com>
6358
6359         * solib.c (info_sharedlibrary_command): Style the file name.
6360
6361 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6362
6363         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6364         (aarch64_vnv_type): Likewise.
6365         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6366         * common/tdesc.c: Likewise.
6367         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6368         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6369         * features/aarch64-fpu.xml: Add ieee half view.
6370         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6371         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6372         * gdbtypes.h (struct builtin_type): Likewise.
6373         (struct objfile_type): Likewise.
6374
6375 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6376
6377         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6378         typo.
6379         * location.h (string_to_event_location): Likewise.
6380
6381 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6382
6383         GDB 8.3 released.
6384
6385 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6386
6387         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6388         New variable declaration.
6389         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6390         New variable.
6391         (print_one_breakpoint): Use ui_out::test_flags and new global
6392         variable to compute use_fixed_output.
6393         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6394         Remove.
6395         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6396         (mi_multi_location_breakpoint_output_fixed): Remove.
6397         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6398         new variable.
6399         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6400         fix_multi_location_breakpoint_output flag if version >= 3.
6401         * ui-out.h (enum ui_out_flag)
6402         <fix_multi_location_breakpoint_output>: New enumerator.
6403
6404 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6405
6406         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6407
6408 2019-05-10  Tom Tromey  <tromey@adacore.com>
6409
6410         * ada-lang.c (catch_ada_completer): New function.
6411         (_initialize_ada_language): Use it.
6412
6413 2019-05-10  Tom Tromey  <tromey@adacore.com>
6414
6415         * thread.c (print_thread_info): Make "requested_threads" const.
6416         * gdbthread.h (print_thread_info): Make "requested_threads"
6417         const.
6418         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6419         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6420
6421 2019-05-08  Tom Tromey  <tom@tromey.com>
6422
6423         * gdbtypes.c (objfile_type_data): Change type.
6424         (objfile_type, _initialize_gdbtypes): Update.
6425
6426 2019-05-08  Tom Tromey  <tom@tromey.com>
6427
6428         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6429         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6430         (_initialize_dwarf2_frame): Update.
6431
6432 2019-05-08  Tom Tromey  <tom@tromey.com>
6433
6434         * objc-lang.c (objc_objfile_data): Change type.
6435         (find_methods): Update.
6436         (_initialize_objc_lang): Remove.
6437
6438 2019-05-08  Tom Tromey  <tom@tromey.com>
6439
6440         * stabsread.c (rs6000_builtin_type_data): Change type.
6441         (rs6000_builtin_type, _initialize_stabsread): Update.
6442
6443 2019-05-08  Tom Tromey  <tom@tromey.com>
6444
6445         * mips-tdep.c (mips_pdr_data): Remove.
6446         (_initialize_mips_tdep): Update.
6447
6448 2019-05-08  Tom Tromey  <tom@tromey.com>
6449
6450         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6451         (hppa_init_objfile_priv_data, read_unwind_info)
6452         (find_unwind_entry, _initialize_hppa_tdep): Update.
6453
6454 2019-05-08  Tom Tromey  <tom@tromey.com>
6455
6456         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6457         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6458         on obstack.
6459         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6460
6461 2019-05-08  Tom Tromey  <tom@tromey.com>
6462
6463         * mdebugread.c (basic_type_data): Change type.
6464         (basic_type, _initialize_mdebugread): Update.
6465
6466 2019-05-08  Tom Tromey  <tom@tromey.com>
6467
6468         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6469
6470 2019-05-08  Tom Tromey  <tom@tromey.com>
6471
6472         * nto-tdep.c (nto_inferior_data_reg): Change type.
6473         (nto_inferior_data): Update.
6474         (nto_inferior_data_cleanup, nto_new_inferior_data)
6475         (_initialize_nto_tdep): Remove.
6476         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6477
6478 2019-05-08  Tom Tromey  <tom@tromey.com>
6479
6480         * ada-lang.c (struct ada_inferior_data): Add initializers.
6481         (ada_inferior_data): Change type.
6482         (ada_inferior_data_cleanup): Remove.
6483         (get_ada_inferior_data, ada_inferior_exit)
6484         (struct ada_pspace_data): Add initializers, destructor.
6485         (ada_pspace_data_handle): Change type.
6486         (get_ada_pspace_data): Update.
6487         (ada_pspace_data_cleanup): Remove.
6488
6489 2019-05-08  Tom Tromey  <tom@tromey.com>
6490
6491         * coffread.c (struct coff_symfile_info): Add initializers.
6492         (coff_objfile_data_key): Move lower.  Change type.
6493         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6494         Update.
6495         (coff_free_info): Remove.
6496
6497 2019-05-08  Tom Tromey  <tom@tromey.com>
6498
6499         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6500         (fbsd_pspace_data_handle): Move lower.  Change type.
6501         (get_fbsd_pspace_data): Update.
6502         (fbsd_pspace_data_cleanup): Remove.
6503         (_initialize_fbsd_tdep): Update.
6504
6505 2019-05-08  Tom Tromey  <tom@tromey.com>
6506
6507         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6508         (get_ada_tasks_pspace_data): Update.
6509         (ada_tasks_pspace_data_cleanup): Remove.
6510         (_initialize_tasks): Update.
6511         (ada_tasks_inferior_data_handle): Change type.
6512         (get_ada_tasks_inferior_data): Update.
6513         (ada_tasks_inferior_data_cleanup): Remove.
6514         (struct ada_tasks_pspace_data): Add initializers.
6515
6516 2019-05-08  Tom Tromey  <tom@tromey.com>
6517
6518         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6519         * symfile-debug.c (debug_sym_get_probes): Change type.
6520         * stap-probe.c (handle_stap_probe):
6521         (stap_static_probe_ops::get_probes): Change type.
6522         * probe.h (class static_probe_ops) <get_probes>: Change type.
6523         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6524         (parse_probes_in_pspace): Update.
6525         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6526         Update.
6527         (any_static_probe_ops::get_probes): Change type.
6528         * elfread.c (elfread_data): New typedef.
6529         (probe_key): Change type.
6530         (elf_get_probes): Likewise.  Update.
6531         (probe_key_free): Remove.
6532         (_initialize_elfread): Update.
6533         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6534         Change type.
6535         (dtrace_process_dof_probe, dtrace_process_dof)
6536         (dtrace_static_probe_ops::get_probe): Change type.
6537
6538 2019-05-08  Tom Tromey  <tom@tromey.com>
6539
6540         * xcoffread.c (struct xcoff_symfile_info): Rename from
6541         coff_symfile_info.  Add initializers.
6542         (xcoff_objfile_data_key): Move lower.  Change type.
6543         (XCOFF_DATA): Rewrite.
6544         (xcoff_free_info): Remove.
6545         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6546         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6547         (xcoff_initial_scan): Update.
6548
6549 2019-05-08  Tom Tromey  <tom@tromey.com>
6550
6551         * solib-svr4.c (struct svr4_info): Add initializers and
6552         destructor.
6553         <probes_table>: Now an htab_up.
6554         (solib_svr4_pspace_data): Change type.
6555         (free_probes_table): Simplify.
6556         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6557         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6558         (probes_table_remove_objfile_probes, register_solib_event_probe)
6559         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6560         (_initialize_svr4_solib): Update.
6561
6562 2019-05-08  Tom Tromey  <tom@tromey.com>
6563
6564         * remote.c (remote_pspace_data): Change type.
6565         (remote_pspace_data_cleanup): Remove.
6566         (get_remote_exec_file, set_pspace_remote_exec_file)
6567         (_initialize_remote): Update.
6568
6569 2019-05-08  Tom Tromey  <tom@tromey.com>
6570
6571         * breakpoint.c (breakpoint_objfile_key): Change type.
6572         (get_breakpoint_objfile_data): Update.
6573         (free_breakpoint_objfile_data): Remove.
6574         (_initialize_breakpoint): Update.
6575
6576 2019-05-08  Tom Tromey  <tom@tromey.com>
6577
6578         * linux-tdep.c (struct linux_info): Add initializers.
6579         (linux_inferior_data): Move.  Change type.
6580         (invalidate_linux_cache_inf): Update.
6581         (linux_inferior_data_cleanup): Remove.
6582         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6583
6584 2019-05-08  Tom Tromey  <tom@tromey.com>
6585
6586         * auxv.c (auxv_inferior_data): Move.  Change type.
6587         (auxv_inferior_data_cleanup): Remove.
6588         (invalidate_auxv_cache_inf): Rewrite.
6589         (get_auxv_inferior_data, _initialize_auxv): Update.
6590
6591 2019-05-08  Tom Tromey  <tom@tromey.com>
6592
6593         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6594         (symfile_debug_objfile_data_key): Change type.
6595         (symfile_debug_installed, debug_qf_has_symbols)
6596         (debug_qf_find_last_source_symtab)
6597         (debug_qf_forget_cached_source_info)
6598         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6599         (debug_qf_print_stats, debug_qf_dump)
6600         (debug_qf_expand_symtabs_for_function)
6601         (debug_qf_expand_all_symtabs)
6602         (debug_qf_expand_symtabs_with_fullname)
6603         (debug_qf_map_matching_symbols)
6604         (debug_qf_expand_symtabs_matching)
6605         (debug_qf_find_pc_sect_compunit_symtab)
6606         (debug_qf_map_symbol_filenames)
6607         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6608         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6609         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6610         (debug_sym_read_linetable, debug_sym_relocate): Update.
6611         (symfile_debug_free_objfile): Remove.
6612         (install_symfile_debug_logging, _initialize_symfile_debug):
6613         Update.
6614
6615 2019-05-08  Tom Tromey  <tom@tromey.com>
6616
6617         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6618         allocate_on_obstack.
6619         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6620         (get_dwarf2_per_objfile): Update.
6621         (set_dwarf2_per_objfile): Remove.
6622         (dwarf2_has_info, dwarf2_get_section_info): Update.
6623         (dwarf2_free_objfile): Remove.
6624         (_initialize_dwarf2_read): Update.
6625
6626 2019-05-08  Tom Tromey  <tom@tromey.com>
6627
6628         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6629         initializers.
6630         <unsupported_script_warning_printed,
6631         script_not_found_warning_printed>: Now bool.
6632         (auto_load_pspace_data): Change type.
6633         (~auto_load_pspace_info): Rename from
6634         auto_load_pspace_data_cleanup.
6635         (get_auto_load_pspace_data, init_loaded_scripts_info)
6636         (clear_section_scripts, maybe_print_unsupported_script_warning)
6637         (maybe_print_script_not_found_warning, _initialize_auto_load):
6638         Update.
6639
6640 2019-05-08  Tom Tromey  <tom@tromey.com>
6641
6642         * objfiles.c (objfile_pspace_info): Add destructor and
6643         initializers.
6644         (objfiles_pspace_data): Change type.
6645         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6646         (get_objfile_pspace_data): Update.
6647         (objfiles_bfd_data): Change type.
6648         (get_objfile_bfd_data): Update.
6649         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6650
6651 2019-05-08  Tom Tromey  <tom@tromey.com>
6652
6653         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6654         Change type.
6655         (get_catch_syscall_inferior_data): Update.
6656         (catch_syscall_inferior_data_cleanup): Remove.
6657         (_initialize_break_catch_syscall): Update.
6658
6659 2019-05-08  Tom Tromey  <tom@tromey.com>
6660
6661         * inflow.c (struct terminal_info): Add destructor and
6662         initializers.
6663         (inflow_inferior_data): Change type.
6664         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6665         (get_inflow_inferior_data, inflow_inferior_exit)
6666         (swap_terminal_info, _initialize_inflow): Update.
6667
6668 2019-05-08  Tom Tromey  <tom@tromey.com>
6669
6670         * target-dcache.c (target_dcache_cleanup): Remove.
6671         (target_dcache_aspace_key): Change type.
6672         (target_dcache_init_p, target_dcache_invalidate)
6673         (target_dcache_get, target_dcache_get_or_init)
6674         (_initialize_target_dcache): Update.
6675         * dcache.h (struct dcache_deleter): New.
6676
6677 2019-05-08  Tom Tromey  <tom@tromey.com>
6678
6679         * symtab.c (struct symbol_cache): Add destructor and
6680         initializers.
6681         (symbol_cache_key): Move.  Change type.
6682         (make_symbol_cache, free_symbol_cache): Remove.
6683         (get_symbol_cache): Update.
6684         (symbol_cache_cleanup): Remove.
6685         (ALL_PSPACES, symbol_cache_flush)
6686         (maintenance_print_symbol_cache)
6687         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6688         Update.
6689
6690 2019-05-08  Tom Tromey  <tom@tromey.com>
6691
6692         * symtab.c (struct main_info): Add destructor and initializers.
6693         (main_progspace_key): Move.  Change type.
6694         (get_main_info): Update.
6695         (main_info_cleanup): Remove.
6696         (_initialize_symtab): Update.
6697
6698 2019-05-08  Tom Tromey  <tom@tromey.com>
6699
6700         * registry.h (DECLARE_REGISTRY): Define the _key class.
6701
6702 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6703
6704         * NEWS: Merge two 'New commands' sections.
6705
6706 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6707
6708         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6709         parameter and use Ada language definition instead.
6710         (ada_val_print_ptr): Remove unused language parameter.
6711         (ada_val_print_num): Remove language parameter and use Ada language
6712         definition instead.
6713         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6714         parameter.
6715         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6716         parameter and use Ada language definition instead.
6717         (ada_val_print_1): Update all ada_val_print_xxx calls.
6718         Remove language parameter.
6719         (ada_val_print): Update ada_val_print_1 call.
6720
6721 2019-05-08  Tom Tromey  <tromey@adacore.com>
6722
6723         * remote.c (remote_hw_watchpoint_limit)
6724         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6725         Now static.
6726
6727 2019-05-08  Tom Tromey  <tromey@adacore.com>
6728
6729         * maint.c (_initialize_maint_cmds): Move initialization code to
6730         remote.c.
6731         (watchdog, show_watchdog): Move to remote.c.
6732         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6733         "watchdog" static.
6734         (_initialize_remote): Move initialization code from maint.c.
6735         * defs.h (watchdog): Don't declare.
6736
6737 2019-05-08  Tom Tromey  <tromey@adacore.com>
6738
6739         * tui/tui-interp.c: Include main.h.
6740         * interps.c: Include main.h.
6741         * main.h (interpreter_p): Declare.
6742         * defs.h (interpreter_p): Don't declare.
6743
6744 2019-05-08  Tom Tromey  <tromey@adacore.com>
6745
6746         * dwarf2loc.c: Include dwarf2read.h.
6747         * defs.h (read_unsigned_leb128): Don't declare.
6748         * dwarf2read.h (read_unsigned_leb128): Declare.
6749
6750 2019-05-08  Tom Tromey  <tromey@adacore.com>
6751
6752         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6753         method.
6754
6755 2019-05-08  Tom Tromey  <tromey@adacore.com>
6756
6757         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6758         when no wrap column is set.
6759
6760 2019-05-08  Tom Tromey  <tromey@adacore.com>
6761
6762         * c-lang.c (c_get_string): Handle non-C-style arrays.
6763
6764 2019-05-08  Tom Tromey  <tromey@adacore.com>
6765
6766         * typeprint.c (print_offset_data::update): Print the bit offset,
6767         not the number of bits remaining.
6768
6769 2019-05-08  Tom Tromey  <tromey@adacore.com>
6770
6771         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6772         padding at end of comment.
6773
6774 2019-05-08  Tom Tromey  <tromey@adacore.com>
6775
6776         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6777         Compare main types.
6778
6779 2019-05-06  Tom Tromey  <tom@tromey.com>
6780
6781         * common/scoped_mmap.c: Include common-defs.h.
6782         * common/scoped_mmap.h: Don't include config.h.
6783
6784 2019-05-04  Tom Tromey  <tom@tromey.com>
6785
6786         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6787         (struct aarch64_call_info): Add initializers.
6788         <si>: Now a std::vector.
6789         (pass_on_stack, aarch64_push_dummy_call): Update.
6790
6791 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6792             Tom Tromey  <tom@tromey.com>
6793
6794         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6795         (ppc_threads): Now a std::vector.  Now static.
6796         (hwdebug_find_thread_points_by_tid)
6797         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6798         Update.
6799
6800 2019-05-04  Tom Tromey  <tom@tromey.com>
6801
6802         * arc-tdep.c (arc_tdesc_init): Return bool.
6803
6804 2019-05-04  Tom Tromey  <tom@tromey.com>
6805
6806         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6807         Use gdb_assert_not_reached.
6808
6809 2019-05-04  Tom Tromey  <tom@tromey.com>
6810
6811         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6812         "false".
6813
6814 2019-05-04  Tom Tromey  <tom@tromey.com>
6815
6816         * arc-tdep.c (arc_tdesc_init): Use bool.
6817
6818 2019-05-04  Tom Tromey  <tom@tromey.com>
6819
6820         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6821
6822 2019-05-04  Tom Tromey  <tom@tromey.com>
6823
6824         * cli/cli-cmds.c (valid_command_p): Return bool.
6825
6826 2019-05-04  Tom Tromey  <tom@tromey.com>
6827
6828         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6829         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6830
6831 2019-05-04  Raul Tambre  <raul@tambre.ee>
6832
6833         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6834         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6835         operator for comparison.
6836
6837 2019-05-04  Tom Tromey  <tom@tromey.com>
6838
6839         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6840         (lookup_partial_symbol, print_partial_symbols)
6841         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6842         (psymbol_compare): Update.
6843         (add_psymbol_to_bcache): Clear the entire psymbol.
6844         (maintenance_check_psymtabs): Update.
6845         * psympriv.h (struct partial_symbol): Don't derive from
6846         general_symbol_info.
6847         <obj_section, unrelocated_address, address,
6848         set_unrelocated_address>: Update.
6849         <ginfo>: New member.
6850         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6851         (debug_names::write_psymbols): Update.
6852
6853 2019-05-04  Tom de Vries  <tdevries@suse.de>
6854
6855         * contrib/cc-with-tweaks.sh: Support -n arg.
6856
6857 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6858
6859         * corelow.c (core_target::detach): Ensure frame cache and
6860         register caches are cleared.
6861         inferior.c (exit_inferior_1): Likewise.
6862
6863 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6864             Tom Tromey  <tom@tromey.com>
6865
6866         * dictionary.c (collate_pending_symbols_by_language): Remove
6867         "struct" from foreach.
6868         * symtab.c (lookup_global_symbol_from_objfile)
6869         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6870         foreach.
6871         * ser-tcp.c (net_open): Remove "struct" from foreach.
6872         * objfiles.c (objfile_relocate, objfile_rebase)
6873         (objfile_has_symbols): Remove "struct" from foreach.
6874         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6875         from foreach.
6876         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6877         foreach.
6878         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6879         "struct" from foreach.
6880         * ada-lang.c (create_excep_cond_exprs)
6881         (ada_exception_catchpoint_cond_string): Remove "struct" from
6882         foreach.
6883
6884 2019-05-03  Tom Tromey  <tromey@adacore.com>
6885
6886         * ada-exp.y (convert_char_literal): Check suffix of each
6887         enumerator.
6888
6889 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6890
6891         PR ada/21406:
6892         * ada-exp.y (yywrap): Don't define.
6893         * ada-lex.l (%option): Add noyywrap
6894         (yywrap): Remove.
6895
6896 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6897
6898         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6899         _WIN32_WINNT to the XP level, unless already defined to a higher
6900         level.
6901
6902         * unittests/parse-connection-spec-selftests.c:
6903         * ser-tcp.c:
6904         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6905         override.
6906
6907         * symfile.c (find_separate_debug_file): Remove colon from the
6908         drive spec of DOS/Windows file names of the target, so that the
6909         file name produced from DEBUGDIR and the target's directory will
6910         be valid on DOS/Windows systems.
6911
6912 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6913
6914         * rust-lang.c (val_print_struct): Handle printing structures
6915         containing strings.
6916
6917 2019-05-02  Tom Tromey  <tromey@adacore.com>
6918
6919         * valarith.c (_initialize_valarith): Remove.
6920
6921 2019-05-01  Tom Tromey  <tromey@adacore.com>
6922
6923         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6924         bitfields.
6925
6926 2019-05-01  Tom Tromey  <tromey@adacore.com>
6927
6928         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6929         for big-endian copies.
6930
6931 2019-04-30  Ali Tamur  <tamur@google.com>
6932         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6933         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6934         (read_3_bytes): New function.
6935
6936 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6937
6938         * windows-nat.c (main_thread_id): Delete.
6939         (handle_output_debug_string): Replace main_thread_id by
6940         current_event.dwThreadId.
6941         (fake_create_process): Likewise.
6942         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6943         Do not set main_thread_id.
6944         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6945         current_event.dwThreadId.
6946         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6947
6948 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6949
6950         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6951         Use current_event.dwThreadId instead of main_thread_id.
6952
6953 2019-04-30  Tom Tromey  <tromey@adacore.com>
6954
6955         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6956         (create_excep_cond_exprs): Iterate over program spaces.
6957         (ada_exception_catchpoint_cond_string): Examine all minimal
6958         symbols for exception types.
6959
6960 2019-04-30  Tom Tromey  <tromey@adacore.com>
6961
6962         PR c++/24470:
6963         * dwarf2read.c (process_structure_scope): Handle case where type
6964         has template parameters but no symbol was created.
6965
6966 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6967             Chris January  <chris.january@arm.com>
6968
6969         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6970         qualifier.
6971         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6972
6973 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6974
6975         * f-typeprint.c (f_print_type): Update rules for printing
6976         whitespace.
6977         (f_type_print_varspec_suffix): Likewise.
6978
6979 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6980             Chris January  <chris.january@arm.com>
6981
6982         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6983         function arguments.
6984
6985 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6986
6987         * f-lang.c (build_fortran_types): Change name of void type to
6988         lower case.
6989         * f-typeprint.c (f_type_print_base): Print the name of the void
6990         type, rather than a fixed string.
6991         * f-valprint.c (f_decorations): Use lower case void string.
6992
6993 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6994             Chris January  <chris.january@arm.com>
6995
6996         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6997         types for Fortran.
6998
6999 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7000             Chris January  <chris.january@arm.com>
7001             David Lecomber  <david.lecomber@arm.com>
7002
7003         * f-exp.y (BINOP_INTRINSIC): New token.
7004         (exp): New parser rule handling BINOP_INTRINSIC.
7005         (f77_keywords): Add new builtin procedures.
7006         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7007         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7008         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7009         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7010         (print_unop_subexp_f): New function.
7011         (print_binop_subexp_f): New function.
7012         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7013         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7014         (dump_subexp_body_f): Likewise.
7015         (operator_check_f): Likewise.
7016         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7017         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7018
7019 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7020
7021         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7022         UNOP_KIND.
7023         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7024         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7025         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7026         (operator_length_f): New fuction.
7027         (print_subexp_f): New function.
7028         (op_name_f): New function.
7029         (dump_subexp_body_f): New function.
7030         (operator_check_f): New function.
7031         (exp_descriptor_f): Replace standard expression handling functions
7032         with new functions.
7033         * gdb/fortran-operator.def: New file.
7034         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7035         * gdb/std-operator.def: Remove UNOP_KIND.
7036
7037 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7038
7039         * std-operator.def: Remove unbalanced, stray double quote
7040         character.
7041
7042 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7043             Chris January  <chris.january@arm.com>
7044             Daniel Everett  <daniel.everett@arm.com>
7045             Nick Forrington  <nick.forrington@arm.com>
7046             Richard Bunt  <richard.bunt@arm.com>
7047
7048         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7049         of depth when printing anonymous structs or unions.
7050         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7051         Don't print either the top-level value, or the children if the
7052         max-depth is exceeded.
7053         (ppscm_print_children): When printing the key of a map, allow one
7054         extra level of depth.
7055         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7056         print either the top-level value, or the children if the max-depth
7057         is exceeded.
7058         (print_children): When printing the key of a map, allow one extra
7059         level of depth.
7060         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7061         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7062         (user_print_options): Initialise max_depth field.
7063         (val_print_scalar_or_string_type_p): New function.
7064         (val_print): Check to see if the max depth has been reached.
7065         (val_print_check_max_depth): Define new function.
7066         (show_print_max_depth): New function.
7067         (_initialize_valprint): Add 'print max-depth' option.
7068         * valprint.h (struct value_print_options) <max_depth>: New field.
7069         (val_print_check_max_depth): Declare new function.
7070         * NEWS: Document new feature.
7071
7072 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7073
7074         * ada-lang.c (ada_language_defn): Initialise new field.
7075         * c-lang.c (c_is_string_type_p): New function.
7076         (c_language_defn): Initialise new field.
7077         (cplus_language_defn): Initialise new field.
7078         (asm_language_defn): Initialise new field.
7079         (minimal_language_defn): Initialise new field.
7080         * c-lang.h (c_is_string_type_p): Declare new function.
7081         * d-lang.c (d_language_defn): Initialise new field.
7082         * f-lang.c (f_is_string_type_p): New function.
7083         (f_language_defn): Initialise new field.
7084         * go-lang.c (go_is_string_type_p): New function.
7085         (go_language_defn): Initialise new field.
7086         * language.c (default_is_string_type_p): New function.
7087         (unknown_language_defn): Initialise new field.
7088         (auto_language_defn): Initialise new field.
7089         * language.h (struct language_defn) <la_is_string_type_p>: New
7090         member variable.
7091         (default_is_string_type_p): Declare new function.
7092         * m2-lang.c (m2_language_defn): Initialise new field.
7093         * objc-lang.c (objc_language_defn): Initialise new field.
7094         * opencl-lang.c (opencl_language_defn): Initialise new field.
7095         * p-lang.c (pascal_is_string_type_p): New function.
7096         (pascal_language_defn): Initialise new field.
7097         * rust-lang.c (rust_is_string_type_p): New function.
7098         (rust_language_defn): Initialise new field.
7099
7100 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7103         New field.
7104         * ada-lang.c (ada_language_defn): Initialise new field.
7105         * c-lang.c (c_language_defn): Likewise.
7106         (cplus_language_defn): Likewise.
7107         (asm_language_defn): Likewise.
7108         (minimal_language_defn): Likewise.
7109         * d-lang.c (d_language_defn): Likewise.
7110         * f-lang.c (f_language_defn): Likewise.
7111         * go-lang.c (go_language_defn): Likewise.
7112         * language.c (unknown_language_defn): Likewise.
7113         (auto_language_defn): Likewise.
7114         * m2-lang.c (m2_language_defn): Likewise.
7115         * objc-lang.c (objc_language_defn): Likewise.
7116         * opencl-lang.c (opencl_language_defn): Likewise.
7117         * p-lang.c (pascal_language_defn): Likewise.
7118         * rust-lang.c (rust_language_defn): Likewise.
7119
7120 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7121
7122         * ada-lang.c (ada_is_character_type): Change return type to bool.
7123         (ada_is_string_type): Likewise.
7124         * ada-lang.h (ada_is_character_type): Update declaration
7125         (ada_is_string_type): Likewise.
7126
7127 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7128
7129         Support style in 'frame|thread apply'
7130
7131         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7132         * record.c (record_start, record_stop): Update callers of
7133         execute_command_to_string with false.
7134         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7135         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7136         methods.
7137         (class string_file): New constructor with term_out parameter.
7138         Override methods term_out and can_emit_style_escape.  New member
7139         term_out.
7140         (class stdio_file): Override can_emit_style_escape.
7141         (class tee_file): Override term_out and can_emit_style_escape.
7142         * utils.h (can_emit_style_escape): Remove.
7143         * utils.c (can_emit_style_escape): Likewise.
7144         Update all callers of can_emit_style_escape (SOMESTREAM) to
7145         SOMESTREAM->can_emit_style_escape.
7146         * source-cache.c (source_cache::get_source_lines): Likewise.
7147         * stack.c (frame_apply_command_count): Call execute_command_to_string
7148         passing the term_out characteristic of the current gdb_stdout.
7149         * thread.c (thr_try_catch_cmd): Likewise.
7150         * top.c (execute_command_to_string): pass term_out parameter
7151         to construct the string_file for the command output.
7152         * ui-file.c (term_cli_styling): New function (most code moved
7153         from utils.c can_emit_style_escape).
7154         (string_file::string_file, string_file::can_emit_style_escape,
7155         stdio_file::can_emit_style_escape, tee_file::term_out,
7156         tee_file::can_emit_style_escape): New functions.
7157
7158 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7159
7160         * NEWS: Mention the new set|show may-call-functions.
7161         * infcall.c (may_call_functions_p): New variable.
7162         (show_may_call_functions_p): New function.
7163         (call_function_by_hand_dummy): Throws an error if not
7164         may-call-functions.
7165         (_initialize_infcall): Call add_setshow_boolean_cmd for
7166         may-call-functions.
7167
7168 2019-04-25  Keith Seitz  <keiths@redhat.com>
7169
7170         PR c++/24367
7171         * cp-support.c (inspect_type): Don't attempt substitutions
7172         of symbol with the same name.
7173
7174 2019-04-25  Tom Tromey  <tromey@adacore.com>
7175
7176         PR gdb/24475:
7177         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7178         static.
7179
7180 2019-04-25  Tom Tromey  <tromey@adacore.com>
7181
7182         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7183         rvalue reference.
7184         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7185         (gdb_xml_parser::parse): Use std::move.
7186         * python/python-internal.h (gdbpy_convert_exception): Take a const
7187         reference.
7188         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7189         std::move.
7190         * python/py-utils.c (gdbpy_convert_exception): Take a const
7191         reference.
7192         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7193         Use std::move.
7194         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7195         Use std::move.
7196         * mi/mi-main.c (mi_print_exception): Take a const reference.
7197         * main.c (handle_command_errors): Take a const reference.
7198         * linespec.c (parse_linespec): Use std::move.
7199         * infcall.c (run_inferior_call): Use std::move.
7200         (call_function_by_hand_dummy): Use std::move.
7201         * exec.c (try_open_exec_file): Use std::move.
7202         * exceptions.h (exception_print, exception_fprintf)
7203         (exception_print_same): Update.
7204         * exceptions.c (print_exception, exception_print)
7205         (exception_fprintf, exception_print_same): Change parameters to
7206         const reference.
7207         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7208         * common/new-op.c: Use std::move.
7209         * common/common-exceptions.h (struct gdb_exception): Add move
7210         constructor.
7211         (struct gdb_exception_error, struct gdb_exception_quit, struct
7212         gdb_quit_bad_alloc): Change constructor to move constructor.
7213         (throw_exception): Change parameter to rvalue reference.
7214         * common/common-exceptions.c (throw_exception): Take rvalue
7215         reference.
7216         * cli/cli-interp.c (safe_execute_command): Use std::move.
7217         * breakpoint.c (insert_bp_location, location_to_sals): Use
7218         std::move.
7219
7220 2019-04-25  Tom Tromey  <tromey@adacore.com>
7221
7222         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7223         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7224         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7225         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7226         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7227         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7228         guile/scm-value.c: Use unpack.
7229         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7230         gdbscm_gdb_exception.
7231         (gdbscm_throw_gdb_exception): Likewise.
7232         (struct gdbscm_gdb_exception): New.
7233         (unpack): New function.
7234         (gdbscm_wrap): Use unpack.
7235
7236 2019-04-25  Tom Tromey  <tromey@adacore.com>
7237
7238         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7239         (gdb_rl_callback_handler): Use std::move.
7240         * common/common-exceptions.h (struct gdb_exception): Add move
7241         assignment operator.
7242         (throw_exception_sjlj): Change "exception" to const reference.
7243         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7244         (throw_exception_sjlj): Change "exception" to const reference.
7245
7246 2019-04-25  Tom Tromey  <tromey@adacore.com>
7247
7248         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7249         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7250         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7251         Update.
7252         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7253         Update.
7254         * mi/mi-interp.c (mi_interp::exec): Update.
7255         * linespec.c (parse_linespec): Update.
7256         * infcall.c (run_inferior_call): Update.
7257         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7258         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7259         (gdbscm_lookup_global_symbol): Update.
7260         * guile/scm-param.c (gdbscm_parameter_value): Update.
7261         * guile/scm-frame.c (gdbscm_frame_read_register)
7262         (gdbscm_frame_read_var): Update.
7263         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7264         * exec.c (try_open_exec_file): Update.
7265         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7266         (gdb_rl_callback_handler): Update.
7267         * common/common-exceptions.h (exception_none): Don't declare.
7268         * common/common-exceptions.c (exception_none): Don't define.
7269         (struct catcher) <exception>: Update.
7270         * cli/cli-interp.c (safe_execute_command): Update.
7271         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7272
7273 2019-04-25  Ali Tamur  <tamur@google.com>
7274
7275         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7276         (read_attribute_value): Likewise.
7277         (dwarf2_read_addr_index): Update comment.
7278         (read_str_index): Add DW_FORM_strx.
7279         (dwarf2_string_attr): Likewise.
7280         (dwarf2_const_value_attr): Likewise.
7281         (dump_die_shallow): Likewise.
7282         (dwarf2_fetch_constant_bytes): Likewise.
7283         (skip_form_bytes): Likewise.
7284         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7285
7286 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7287
7288         PR corefiles/11608
7289         PR corefiles/18187
7290         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7291         OFFSET.  Verify if current mapping contains an ELF header.
7292         (linux_find_memory_regions_full): Adjust call to
7293         dump_mapping_p.
7294
7295 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7296             Kang Li <kanglictf@gmail.com>
7297
7298         PR gdb/21600
7299
7300         * dwarf2-frame.c (read_initial_length): Be consistent about using
7301         unsigned representation of length.
7302         (decode_frame_entry_1): Likewise.  Check for wraparound of
7303         end pointer as well as buffer overflow.
7304
7305 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7306
7307         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7308         "vq".
7309
7310 2019-04-24  Tom Tromey  <tromey@adacore.com>
7311
7312         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7313
7314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7315
7316         * s12z-tdep.c (s12z_unwind_pc): Delete.
7317         (s12z_unwind_sp): Delete.
7318         (s12z_gdbarch_init): Don't register deleted functions with
7319         gdbarch.
7320
7321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7322
7323         * rl78-tdep.c (rl78_unwind_sp): Delete.
7324         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7325
7326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7327
7328         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7329         (xstormy16_unwind_pc): Delete.
7330         (xstormy16_dummy_id): Delete.
7331         (xstormy16_gdbarch_init): Don't register deleted functions with
7332         gdbarch.
7333
7334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7335
7336         * vax-tdep.c (vax_unwind_pc): Delete.
7337         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7338
7339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7340
7341         * v850-tdep.c (v850_unwind_sp): Delete.
7342         (v850_unwind_pc): Delete.
7343         (v850_dummy_id): Delete.
7344         (v850_gdbarch_init): Don't register deleted functions with
7345         gdbarch.
7346
7347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7348
7349         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7350         (tilegx_unwind_pc): Delete.
7351         (tilegx_unwind_dummy_id): Delete.
7352         (tilegx_gdbarch_init): Don't register deleted functions with
7353         gdbarch.
7354
7355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7356
7357         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7358         (tic6x_dummy_id): Delete.
7359         (tic6x_gdbarch_init): Don't register deleted functions with
7360         gdbarch.
7361
7362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7363
7364         * sparc-tdep.c (sparc_unwind_pc): Delete.
7365         (sparc32_gdbarch_init): Don't register deleted function with
7366         gdbarch.
7367
7368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7369
7370         * sh-tdep.c (sh_unwind_sp): Delete.
7371         (sh_unwind_pc): Delete.
7372         (sh_dummy_id): Delete.
7373         (sh_gdbarch_init): Don't register deleted functions with
7374         gdbarch.
7375
7376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7377
7378         * score-tdep.c (score_unwind_sp): Delete.
7379         (score_unwind_pc): Delete.
7380         (score_dummy_id): Delete.
7381         (score_gdbarch_init): Don't register deleted functions with
7382         gdbarch.
7383
7384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7385
7386         * rx-tdep.c (rx_unwind_pc): Delete.
7387         (rx_unwind_sp): Delete.
7388         (rx_dummy_id): Delete.
7389         (rx_gdbarch_init): Don't register deleted functions with
7390         gdbarch.  Update comment.
7391
7392 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7393
7394         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7395         (rs6000_dummy_id): Delete.
7396         (rs6000_gdbarch_init): Don't register deleted functions with
7397         gdbarch.
7398
7399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7400
7401         * or1k-tdep.c (or1k_dummy_id): Delete.
7402         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7403
7404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7405
7406         * nios2-tdep.c (nios2_dummy_id): Delete.
7407         (nios2_unwind_sp): Delete.
7408         (nios2_gdbarch_init): Don't register deleted functions with
7409         gdbarch.
7410
7411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7412
7413         * nds32-tdep.c (nds32_dummy_id): Delete.
7414         (nds32_unwind_pc): Delete.
7415         (nds32_unwind_sp): Delete.
7416         (nds32_gdbarch_init): Don't register deleted functions with
7417         gdbarch.
7418
7419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7420
7421         * msp430-tdep.c (msp430_unwind_pc): Delete.
7422         (msp430_unwind_sp): Delete.
7423         (msp430_dummy_id): Delete.
7424         (msp430_gdbarch_init): Don't register deleted functions with
7425         gdbarch.
7426
7427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7428
7429         * moxie-tdep.c (moxie_unwind_sp): Delete.
7430         (moxie_unwind_pc): Delete.
7431         (moxie_dummy_id): Delete.
7432         (moxie_gdbarch_init): Don't register deleted functions with
7433         gdbarch.
7434
7435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7436
7437         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7438         (mn10300_unwind_pc): Delete.
7439         (mn10300_unwind_sp): Delete.
7440         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7441         mn10300_unwind_sp.
7442         (mn10300_frame_unwind_init): Don't register deleted functions with
7443         gdbarch.
7444
7445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7446
7447         * mep-tdep.c (mep_unwind_pc): Delete.
7448         (mep_unwind_sp): Delete.
7449         (mep_dummy_id): Delete.
7450         (mep_gdbarch_init): Don't register deleted functions with
7451         gdbarch.
7452
7453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7454
7455         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7456         (m68hc11_unwind_sp): Delete.
7457         (m68hc11_gdbarch_init): Don't register deleted functions with
7458         gdbarch.
7459
7460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7461
7462         * m32r-tdep.c (m32r_unwind_sp): Delete.
7463         (m32r_unwind_pc): Delete.
7464         (m32r_dummy_id): Delete.
7465         (m32r_gdbarch_init): Don't register deleted functions with
7466         gdbarch.
7467
7468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7469
7470         * m32c-tdep.c (m32c_unwind_pc): Delete.
7471         (m32c_unwind_sp): Delete.
7472         (m32c_dummy_id): Delete.
7473         (m32c_gdbarch_init): Don't register deleted functions with
7474         gdbarch.
7475
7476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7477
7478         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7479         (lm32_unwind_pc): Delete.
7480         (lm32_dummy_id): Delete.
7481         (lm32_gdbarch_init): Don't register deleted functions with
7482         gdbarch.
7483
7484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7485
7486         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7487         (iq2000_unwind_pc): Delete.
7488         (iq2000_dummy_id): Delete.
7489         (iq2000_gdbarch_init): Don't register deleted functions with
7490         gdbarch.
7491
7492 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7493
7494         * nds32-tdep.c (nds32_type_align): Delete.
7495         (nds32_push_dummy_call): Use type_align instead.
7496
7497 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7498
7499         * arm-tdep.c (arm_type_align): Only handle vector override case.
7500         (arm_push_dummy_call): Use type_align.
7501         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7502
7503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7504
7505         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7506         case.
7507         (pass_on_stack): Use type_align.
7508         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7509         function.
7510
7511 2019-04-23  Tom Tromey  <tromey@adacore.com>
7512
7513         * dwarf2read.c (line_header::file_name_at): Remove unused
7514         overload.
7515
7516 2019-04-23  Tom de Vries  <tdevries@suse.de>
7517
7518         PR gdb/24438
7519         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7520         invocation.
7521
7522
7523 2019-03-27  Ali Tamur  <tamur@google.com>
7524
7525         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7526         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7527         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7528         (dwarf_expr_context::get_addr_index): Likewise
7529         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7530         (symbol_needs_eval_context::get_addr_index): Likewise
7531         (disassemble_dwarf_expression): Add DW_OP_addrx
7532         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7533         (read_cutu_die_from_dwo): Update comment
7534         (skip_one_die): Add DW_FORM_addrx
7535         (read_attribute_value): Likewise
7536         (var_decode_location): Add DW_OP_addrx
7537         (dwarf2_const_value_attr): Add DW_FORM_addrx
7538         (dump_die_shallow): Likewise
7539         (dwarf2_fetch_constant_bytes): Likewise
7540         (decode_locdesc): Add DW_OP_addrx
7541         (skip_form_bytes): Add DW_FORM_addrx
7542
7543 2019-04-22  Ali Tamur  <tamur@google.com>
7544
7545         * MAINTAINERS (Write After Approval): Add self.
7546
7547 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7548
7549         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7550         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7551         (open_symbol_file_object): Likewise.
7552         (svr4_default_sos): Add info parameter.
7553         (svr4_read_so_list): Likewise.
7554         (svr4_current_sos_direct): Adjust functions calls to pass down
7555         info.
7556         (svr4_current_sos_1): Add info parameter.
7557         (svr4_current_sos): Call get_svr4_info, pass info down to
7558         svr4_current_sos_1.
7559         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7560         get_svr4_info.
7561         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7562         get_svr4_info.
7563         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7564         to get_svr4_info.
7565         (probes_table_remove_objfile_probes): Likewise.
7566         (register_solib_event_probe): Add info parameter.
7567         (solist_update_incremental): Pass info parameter down to
7568         svr4_read_so_list.
7569         (disable_probes_interface): Add info parameter.
7570         (svr4_handle_solib_event): Pass current_program_space to
7571         get_svr4_info.  Adjust disable_probes_interface cleanup.
7572         (svr4_create_probe_breakpoints): Add info parameter, pass it
7573         down to register_solib_event_probe.
7574         (svr4_create_solib_event_breakpoints): Add info parameter,
7575         pass it down to svr4_create_probe_breakpoints.
7576         (enable_break): Pass info down to
7577         svr4_create_solib_event_breakpoints.
7578         (svr4_solib_create_inferior_hook): Pass current_program_space to
7579         get_svr4_info.
7580         (svr4_clear_solib): Likewise.
7581
7582 2019-04-22  Pedro Alves  <palves@redhat.com>
7583
7584         * solib-svr4.c (svr4_free_objfile_observer): New.
7585         (probe_and_action::objfile): New field.
7586         (probes_table_htab_remove_objfile_probes)
7587         (probes_table_remove_objfile_probes): New functions.
7588         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7589         in the new probe_and_action.  Don't store the probe in 'lookup'.
7590         (svr4_create_probe_breakpoints): Pass objfile to
7591         register_solib_event_probe.
7592         (_initialize_svr4_solib): Register a free_objfile observer.
7593
7594 2019-04-19  Tom Tromey  <tom@tromey.com>
7595
7596         * common/queue.h: Remove.
7597
7598 2019-04-19  Tom Tromey  <tom@tromey.com>
7599
7600         * event-loop.c: Don't include "common/queue.h".
7601
7602 2019-04-19  Tom Tromey  <tom@tromey.com>
7603
7604         * remote.c (remote_target): Use delete.
7605         * remote-notif.h: Include <list>, not "common/queue.h".
7606         (notif_client_p): Remove typedef.
7607         (remote_notif_state): Add constructor, destructor, initializer.
7608         <notif_queue>: Now a std::list.
7609         (remote_notif_state_xfree): Don't declare.
7610         * remote-notif.c (remote_notif_process, handle_notification)
7611         (remote_notif_state_allocate): Update.
7612         (~remote_notif_state): Rename from remote_notif_state_xfree.
7613
7614 2019-04-19  Tom Tromey  <tom@tromey.com>
7615
7616         * symfile.c (reread_symbols): Update.
7617         * objfiles.c (objfile_register_static_link)
7618         (objfile_lookup_static_link): Update
7619         (~objfile) Don't delete static_links.
7620         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7621
7622 2019-04-19  Tom Tromey  <tom@tromey.com>
7623
7624         * type-stack.h (struct type_stack) <insert>: Constify string.
7625         * type-stack.c (type_stack::insert): Constify string.
7626         * gdbtypes.h (lookup_template_type): Update.
7627         (address_space_name_to_int): Update.
7628         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7629         const.
7630         (lookup_template_type): Make name const.
7631         * c-exp.y: Update rules.
7632         (lex_one_token, classify_name, classify_inner_name)
7633         (c_print_token): Update.
7634         * p-exp.y: Update rules.
7635         (yylex): Update.
7636         * f-exp.y: Update rules.
7637         (yylex): Update.
7638         * d-exp.y: Update rules.
7639         (lex_one_token, classify_name, classify_inner_name): Update.
7640         * parse.c (write_dollar_variable, copy_name): Return std::string.
7641         * parser-defs.h (copy_name): Change return type.
7642         * m2-exp.y: Update rules.
7643         (yylex): Update.
7644         * go-exp.y (lex_one_token): Update.
7645         Update rules.
7646         (classify_unsafe_function, classify_packaged_name)
7647         (classify_name, yylex): Update.
7648
7649 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7650
7651         * configure.ac: add --enable-source-highlight switch.
7652         * configure: Regenerate.
7653         * top.c (print_gdb_version): plumb --enable-source-highlight
7654         status to "show configuration".
7655
7656 2019-04-19  Tom Tromey  <tromey@adacore.com>
7657
7658         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7659         Check ADA_TYPE_P.
7660         (empty_record, ada_template_to_fixed_record_type_1)
7661         (template_to_static_fixed_type)
7662         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7663         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7664         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7665         macros.
7666
7667 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7668
7669         PR symtab/24423:
7670         * source.c (print_source_lines_base): Advance "iter" when a
7671         control character is seen.
7672
7673 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7674
7675         * inferior.h (struct infcall_suspend_state_deleter):
7676         Catch exception in destructor to avoid crash.
7677
7678 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7679
7680         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7681         close to the add_com "shell".
7682
7683 2019-04-18  Tom Tromey  <tromey@adacore.com>
7684
7685         * process-stratum-target.h (class process_stratum_target)
7686         <stratum>: Add "final".
7687
7688 2019-04-17  Tom Tromey  <tromey@adacore.com>
7689
7690         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7691         against nullptr before use.
7692
7693 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7694
7695         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7696
7697 2019-04-17  Jim Wilson  <jimw@sifive.com>
7698             Andrew Burgess  <andrew.burgess@embecosm.com>
7699
7700         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7701         code read might fail, assume 4-byte breakpoint in that case.
7702
7703 2019-04-15  Leszek Swirski  <leszeks@google.com>
7704
7705         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7706         rather than a hand-rolled POD check when checking for forced MEMORY
7707         classification.
7708
7709 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7710
7711         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7712         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7713         function.
7714         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7715         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7716         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7717         declaration.
7718
7719 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7720
7721         * aarch64-linux-nat.c
7722         (aarch64_linux_nat_target::thread_architecture): Add override.
7723         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7724         each VQ.
7725
7726 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7727
7728         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7729
7730 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7731
7732         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7733         target types of size 96-bits, add some additional comments, and
7734         check that the builtin type we found was the correct size.
7735
7736 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7737
7738         * utils.c (prompt_for_continue): Don't restore the styling at the
7739         end, as applied_style has the wrong value.  This fixes styling in
7740         long lists of file names that are interrupted by the "Continue?"
7741         prompt.
7742
7743 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7744
7745         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7746         * c-lang.c (c_language_defn): Likewise.
7747         (cplus_language_defn): Likewise.
7748         (asm_language_defn): Likewise.
7749         (minimal_language_defn): Likewise.
7750         * d-lang.c (d_language_defn): Likewise.
7751         * f-lang.c (f_language_defn): Likewise.
7752         * go-lang.c (go_language_defn): Likewise.
7753         * language.c (unknown_language_defn): Likewise.
7754         (auto_language_defn): Likewise.
7755         * language.h (struct language_defn): Remove la_magic field.
7756         (LANG_MAGIC): Delete.
7757         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7758         * objc-lang.c (objc_language_defn): Likewise.
7759         * opencl-lang.c (opencl_language_defn): Likewise.
7760         * p-lang.c (pascal_language_defn): Likewise.
7761         * rust-lang.c (rust_language_defn): Likewise.
7762
7763 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7764
7765         * riscv-tdep.c (riscv_type_align): New function.
7766         (riscv_type_alignment): Delete.
7767         (riscv_arg_location): Use 'type_align'.
7768         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7769
7770 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7771
7772         * gdbtypes.c (type_align): A struct with no non-static fields also
7773         has alignment of 1.
7774
7775 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7776
7777         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7778         component to 0.
7779         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7780         member.
7781         (riscv_struct_info::analyse): New implementation using new
7782         analyse_inner member function.
7783         (riscv_struct_info::field_offset): New member function.
7784         (riscv_struct_info::m_offsets): New member variable.
7785         (riscv_struct_info::analyse_inner): New private member function,
7786         takes the old implementation of riscv_struct_info::analyse but
7787         extended to track field offsets.
7788         (riscv_call_arg_struct): Update the struct folding special cases
7789         to handle cases where empty C++ structs, which are non-zero
7790         length, are found.
7791         (riscv_arg_location): Initialise the length of each location, a
7792         non-zero length now indicates the location is in use.
7793         (riscv_push_dummy_call): Allow for the first location having a
7794         non-zero offset when setting up arguments.
7795         (riscv_return_value): Likewise, but for return values.
7796
7797 2019-04-11  Tom Tromey  <tromey@adacore.com>
7798
7799         * utils.c (internal_vproblem): Make "msg" const.
7800
7801 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7802
7803         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7804         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7805         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7806         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7807
7808 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7809
7810         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7811         function.
7812         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7813         of amd64_collect_native_gregset.
7814         (amd64_linux_nat_target::store_registers): Likewise.
7815
7816 2019-04-10  Tom Tromey  <tom@tromey.com>
7817
7818         * symtab.c (lookup_global_symbol_from_objfile)
7819         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7820         * objfiles.h (class separate_debug_iterator): New.
7821         (class separate_debug_range): New.
7822         (struct objfile) <separate_debug_objfiles>: New method.
7823         (objfile_separate_debug_iterate): Don't declare.
7824         * objfiles.c (separate_debug_iterator::operator++): Rename from
7825         objfile_separate_debug_iterate.
7826         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7827         iterator.
7828         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7829         iterator.
7830
7831 2019-04-10  Tom Tromey  <tom@tromey.com>
7832
7833         * symfile.c (reread_symbols): Remove old comment.
7834         * objfiles.c (free_all_objfiles): Fix a typo.
7835
7836 2019-04-10  Tom Tromey  <tom@tromey.com>
7837
7838         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7839         * minsyms.c (lookup_minimal_symbol): Use foreach.
7840         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7841         (lookup_minimal_symbol_solib_trampoline): Likewise.
7842         * symfile.c (reread_symbols): Use foreach.
7843
7844 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7845             Tom Tromey  <tromey@adacore.com>
7846
7847         PR rust/24414:
7848         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7849         (rust_lex_int_test): Change "value" to be LONGEST.
7850         (rust_lex_tests): Add test for long integer literal.
7851
7852 2019-04-09  Tom Tromey  <tromey@adacore.com>
7853
7854         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7855         to bool.
7856         (extended_remote_target::attach): Update.
7857         (remote_target::remote_notice_new_inferior): Update.
7858         (remote_target::add_current_inferior_and_thread): Update.
7859         * inferior.c (exit_inferior_1): Use "false".
7860         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7861
7862 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7863
7864         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7865         the "start" command.
7866
7867 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7868
7869         * python/py-inferior.c (infpy_thread_from_thread_handle):
7870         Adjust comments to reflect renaming of thread_from_thread_handle
7871         to thread_from_handle.  Adjust keywords.  Fix type error message.
7872         (inferior_object_methods): Add thread_from_handle.  Retain
7873         thread_from_thread_handle, but mark it as deprecated.
7874
7875 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7876
7877         * gdbthread.h (find_thread_by_handle): Revise declaration.
7878         * thread.c (find_thread_by_handle): Likewise.  Adjust
7879         implementation too.
7880         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7881         support for buffer objects as handles.
7882
7883 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7884
7885         * python/py-infthread.c (thpy_thread_handle): New function.
7886         (thread_object_methods): Register thpy_thread_handle.
7887
7888 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7889
7890         * gdbthread.h (thread_to_thread_handle): Declare.
7891         * thread.c (gdbtypes.h): Include.
7892         (thread_to_thread_handle): New function.
7893
7894         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7895         (target_thread_info_to_thread_handle): Declare.
7896         * target.c (target_thread_info_to_thread_handle): New function.
7897         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7898         * target-delegates.c: Regenerate.
7899
7900         * linux-thread-db.c (class thread_db_target): Add method
7901         thread_info_to_thread_handle.
7902         (thread_db_target::thread_info_to_thread_handle): Define.
7903         * remote.c (class remote_target): Add new method
7904         thread_info_to_thread_handle.
7905         (remote_target::thread_info_to_thread_handle): Define.
7906
7907 2019-04-08  Pedro Alves  <palves@redhat.com>
7908
7909         * common/common-exceptions.c (throw_exception): Don't create
7910         named object to throw; throw directly.
7911         (throw_it): Likewise.  Don't initialize gdb_exception::message
7912         here, with new; pass FMT and AP to the ctor instead.
7913         * common/common-exceptions.h: Include <string>.
7914         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7915         const char *, va_list)): New ctor.  Use std::make_shared.
7916         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7917         errors)): Delete.
7918         (gdb_exception_error::gdb_exception_error(enum errors, const char
7919         *, va_list)): New.
7920         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7921         Add assertion.
7922         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7923         errors)): Delete.
7924         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7925         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7926         Add assertion.
7927
7928 2019-04-08  Tom Tromey  <tom@tromey.com>
7929
7930         * valops.c (value_rtti_indirect_type): Replace throw_exception
7931         with throw.
7932         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7933         with throw.
7934         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7935         throw.
7936         * target.c (target_translate_tls_address): Replace throw_exception
7937         with throw.
7938         * stack.c (frame_apply_command_count): Replace throw_exception
7939         with throw.
7940         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7941         throw.
7942         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7943         with throw.
7944         * rs6000-tdep.c (rs6000_frame_cache)
7945         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7946         * remote.c: Replace throw_exception with throw.
7947         * record-full.c (record_full_message, record_full_wait_1)
7948         (record_full_restore): Replace throw_exception with throw.
7949         * record-btrace.c:
7950         (get_thread_current_frame_id, record_btrace_start_replaying)
7951         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7952         (cmd_record_btrace_start): Replace throw_exception with throw.
7953         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7954         throw.
7955         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7956         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7957         * linespec.c:
7958         (find_linespec_symbols): Replace throw_exception with throw.
7959         * infrun.c (displaced_step_prepare, resume): Replace
7960         throw_exception with throw.
7961         * infcmd.c (post_create_inferior): Replace throw_exception with
7962         throw.
7963         * inf-loop.c (inferior_event_handler): Replace throw_exception
7964         with throw.
7965         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7966         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7967         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7968         (get_prev_frame_always, get_frame_pc_if_available)
7969         (get_frame_address_in_block_if_available, get_frame_language):
7970         Replace throw_exception with throw.
7971         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7972         throw_exception with throw.
7973         * eval.c (fetch_subexp_value, evaluate_var_value)
7974         (evaluate_funcall, evaluate_subexp_standard): Replace
7975         throw_exception with throw.
7976         * dwarf2loc.c (call_site_find_chain)
7977         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7978         Replace throw_exception with throw.
7979         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7980         with throw.
7981         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7982         throw.
7983         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7984         * completer.c (complete_line_internal): Replace throw_exception
7985         with throw.
7986         * compile/compile-object-run.c (compile_object_run): Replace
7987         throw_exception with throw.
7988         * cli/cli-script.c (process_next_line): Replace throw_exception
7989         with throw.
7990         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7991         (btrace_enable, btrace_maint_update_pt_packets): Replace
7992         throw_exception with throw.
7993         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7994         throw_exception with throw.
7995         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7996         throw_exception with throw.
7997         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7998         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7999         * aarch64-tdep.c (aarch64_make_prologue_cache)
8000         (aarch64_make_stub_cache): Replace throw_exception with throw.
8001
8002 2019-04-08  Tom Tromey  <tom@tromey.com>
8003
8004         * common/common-exceptions.c (throw_exception): Rename from
8005         throw_exception_cxx.  Remove old copy.  Make argument const.
8006         (throw_it): Create and throw exception objects directly.
8007         * common/common-exceptions.h (throw_exception): Make argument
8008         const.
8009         (struct gdb_exception_error): Add constructor.
8010         (struct gdb_exception_quit): Add constructor.
8011
8012 2019-04-08  Tom Tromey  <tom@tromey.com>
8013
8014         * common/common-exceptions.h (exception_rethrow): Don't declare.
8015         (TRY_SJLJ): Update comment.
8016         (TRY, CATCH, END_CATCH): Remove.
8017         * common/common-exceptions.c (exception_rethrow): Remove.
8018
8019 2019-04-08  Tom Tromey  <tom@tromey.com>
8020
8021         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8022         Remove.
8023         (gdb_exception_error): Rename from
8024         gdb_exception_RETURN_MASK_ERROR.
8025         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8026         (gdb_quit_bad_alloc): Update.
8027         * aarch64-tdep.c: Update.
8028         * ada-lang.c: Update.
8029         * ada-typeprint.c: Update.
8030         * ada-valprint.c: Update.
8031         * amd64-tdep.c: Update.
8032         * arch-utils.c: Update.
8033         * break-catch-throw.c: Update.
8034         * breakpoint.c: Update.
8035         * btrace.c: Update.
8036         * c-varobj.c: Update.
8037         * cli/cli-cmds.c: Update.
8038         * cli/cli-interp.c: Update.
8039         * cli/cli-script.c: Update.
8040         * common/common-exceptions.c: Update.
8041         * common/new-op.c: Update.
8042         * common/selftest.c: Update.
8043         * compile/compile-c-symbols.c: Update.
8044         * compile/compile-cplus-symbols.c: Update.
8045         * compile/compile-object-load.c: Update.
8046         * compile/compile-object-run.c: Update.
8047         * completer.c: Update.
8048         * corelow.c: Update.
8049         * cp-abi.c: Update.
8050         * cp-support.c: Update.
8051         * cp-valprint.c: Update.
8052         * darwin-nat.c: Update.
8053         * disasm-selftests.c: Update.
8054         * dtrace-probe.c: Update.
8055         * dwarf-index-cache.c: Update.
8056         * dwarf-index-write.c: Update.
8057         * dwarf2-frame-tailcall.c: Update.
8058         * dwarf2-frame.c: Update.
8059         * dwarf2loc.c: Update.
8060         * dwarf2read.c: Update.
8061         * eval.c: Update.
8062         * event-loop.c: Update.
8063         * event-top.c: Update.
8064         * exec.c: Update.
8065         * f-valprint.c: Update.
8066         * fbsd-tdep.c: Update.
8067         * frame-unwind.c: Update.
8068         * frame.c: Update.
8069         * gdbtypes.c: Update.
8070         * gnu-v3-abi.c: Update.
8071         * guile/guile-internal.h: Update.
8072         * guile/scm-block.c: Update.
8073         * guile/scm-breakpoint.c: Update.
8074         * guile/scm-cmd.c: Update.
8075         * guile/scm-disasm.c: Update.
8076         * guile/scm-frame.c: Update.
8077         * guile/scm-lazy-string.c: Update.
8078         * guile/scm-math.c: Update.
8079         * guile/scm-param.c: Update.
8080         * guile/scm-ports.c: Update.
8081         * guile/scm-pretty-print.c: Update.
8082         * guile/scm-symbol.c: Update.
8083         * guile/scm-symtab.c: Update.
8084         * guile/scm-type.c: Update.
8085         * guile/scm-value.c: Update.
8086         * i386-linux-tdep.c: Update.
8087         * i386-tdep.c: Update.
8088         * inf-loop.c: Update.
8089         * infcall.c: Update.
8090         * infcmd.c: Update.
8091         * infrun.c: Update.
8092         * jit.c: Update.
8093         * language.c: Update.
8094         * linespec.c: Update.
8095         * linux-fork.c: Update.
8096         * linux-nat.c: Update.
8097         * linux-tdep.c: Update.
8098         * linux-thread-db.c: Update.
8099         * main.c: Update.
8100         * mi/mi-cmd-break.c: Update.
8101         * mi/mi-cmd-stack.c: Update.
8102         * mi/mi-interp.c: Update.
8103         * mi/mi-main.c: Update.
8104         * objc-lang.c: Update.
8105         * p-valprint.c: Update.
8106         * parse.c: Update.
8107         * ppc-linux-tdep.c: Update.
8108         * printcmd.c: Update.
8109         * python/py-arch.c: Update.
8110         * python/py-breakpoint.c: Update.
8111         * python/py-cmd.c: Update.
8112         * python/py-finishbreakpoint.c: Update.
8113         * python/py-frame.c: Update.
8114         * python/py-framefilter.c: Update.
8115         * python/py-gdb-readline.c: Update.
8116         * python/py-inferior.c: Update.
8117         * python/py-infthread.c: Update.
8118         * python/py-lazy-string.c: Update.
8119         * python/py-linetable.c: Update.
8120         * python/py-objfile.c: Update.
8121         * python/py-param.c: Update.
8122         * python/py-prettyprint.c: Update.
8123         * python/py-progspace.c: Update.
8124         * python/py-record-btrace.c: Update.
8125         * python/py-record.c: Update.
8126         * python/py-symbol.c: Update.
8127         * python/py-type.c: Update.
8128         * python/py-unwind.c: Update.
8129         * python/py-utils.c: Update.
8130         * python/py-value.c: Update.
8131         * python/python.c: Update.
8132         * record-btrace.c: Update.
8133         * record-full.c: Update.
8134         * remote-fileio.c: Update.
8135         * remote.c: Update.
8136         * riscv-tdep.c: Update.
8137         * rs6000-aix-tdep.c: Update.
8138         * rs6000-tdep.c: Update.
8139         * rust-exp.y: Update.
8140         * rust-lang.c: Update.
8141         * s390-tdep.c: Update.
8142         * selftest-arch.c: Update.
8143         * solib-dsbt.c: Update.
8144         * solib-frv.c: Update.
8145         * solib-spu.c: Update.
8146         * solib-svr4.c: Update.
8147         * solib.c: Update.
8148         * sparc64-linux-tdep.c: Update.
8149         * stack.c: Update.
8150         * symfile-mem.c: Update.
8151         * symmisc.c: Update.
8152         * target.c: Update.
8153         * thread.c: Update.
8154         * top.c: Update.
8155         * tracefile-tfile.c: Update.
8156         * tui/tui.c: Update.
8157         * typeprint.c: Update.
8158         * unittests/cli-utils-selftests.c: Update.
8159         * unittests/parse-connection-spec-selftests.c: Update.
8160         * valops.c: Update.
8161         * valprint.c: Update.
8162         * value.c: Update.
8163         * varobj.c: Update.
8164         * windows-nat.c: Update.
8165         * x86-linux-nat.c: Update.
8166         * xml-support.c: Update.
8167
8168 2019-04-08  Tom Tromey  <tom@tromey.com>
8169
8170         * xml-support.c: Use C++ exception handling.
8171         * x86-linux-nat.c: Use C++ exception handling.
8172         * windows-nat.c: Use C++ exception handling.
8173         * varobj.c: Use C++ exception handling.
8174         * value.c: Use C++ exception handling.
8175         * valprint.c: Use C++ exception handling.
8176         * valops.c: Use C++ exception handling.
8177         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8178         handling.
8179         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8180         * typeprint.c: Use C++ exception handling.
8181         * tui/tui.c: Use C++ exception handling.
8182         * tracefile-tfile.c: Use C++ exception handling.
8183         * top.c: Use C++ exception handling.
8184         * thread.c: Use C++ exception handling.
8185         * target.c: Use C++ exception handling.
8186         * symmisc.c: Use C++ exception handling.
8187         * symfile-mem.c: Use C++ exception handling.
8188         * stack.c: Use C++ exception handling.
8189         * sparc64-linux-tdep.c: Use C++ exception handling.
8190         * solib.c: Use C++ exception handling.
8191         * solib-svr4.c: Use C++ exception handling.
8192         * solib-spu.c: Use C++ exception handling.
8193         * solib-frv.c: Use C++ exception handling.
8194         * solib-dsbt.c: Use C++ exception handling.
8195         * selftest-arch.c: Use C++ exception handling.
8196         * s390-tdep.c: Use C++ exception handling.
8197         * rust-lang.c: Use C++ exception handling.
8198         * rust-exp.y: Use C++ exception handling.
8199         * rs6000-tdep.c: Use C++ exception handling.
8200         * rs6000-aix-tdep.c: Use C++ exception handling.
8201         * riscv-tdep.c: Use C++ exception handling.
8202         * remote.c: Use C++ exception handling.
8203         * remote-fileio.c: Use C++ exception handling.
8204         * record-full.c: Use C++ exception handling.
8205         * record-btrace.c: Use C++ exception handling.
8206         * python/python.c: Use C++ exception handling.
8207         * python/py-value.c: Use C++ exception handling.
8208         * python/py-utils.c: Use C++ exception handling.
8209         * python/py-unwind.c: Use C++ exception handling.
8210         * python/py-type.c: Use C++ exception handling.
8211         * python/py-symbol.c: Use C++ exception handling.
8212         * python/py-record.c: Use C++ exception handling.
8213         * python/py-record-btrace.c: Use C++ exception handling.
8214         * python/py-progspace.c: Use C++ exception handling.
8215         * python/py-prettyprint.c: Use C++ exception handling.
8216         * python/py-param.c: Use C++ exception handling.
8217         * python/py-objfile.c: Use C++ exception handling.
8218         * python/py-linetable.c: Use C++ exception handling.
8219         * python/py-lazy-string.c: Use C++ exception handling.
8220         * python/py-infthread.c: Use C++ exception handling.
8221         * python/py-inferior.c: Use C++ exception handling.
8222         * python/py-gdb-readline.c: Use C++ exception handling.
8223         * python/py-framefilter.c: Use C++ exception handling.
8224         * python/py-frame.c: Use C++ exception handling.
8225         * python/py-finishbreakpoint.c: Use C++ exception handling.
8226         * python/py-cmd.c: Use C++ exception handling.
8227         * python/py-breakpoint.c: Use C++ exception handling.
8228         * python/py-arch.c: Use C++ exception handling.
8229         * printcmd.c: Use C++ exception handling.
8230         * ppc-linux-tdep.c: Use C++ exception handling.
8231         * parse.c: Use C++ exception handling.
8232         * p-valprint.c: Use C++ exception handling.
8233         * objc-lang.c: Use C++ exception handling.
8234         * mi/mi-main.c: Use C++ exception handling.
8235         * mi/mi-interp.c: Use C++ exception handling.
8236         * mi/mi-cmd-stack.c: Use C++ exception handling.
8237         * mi/mi-cmd-break.c: Use C++ exception handling.
8238         * main.c: Use C++ exception handling.
8239         * linux-thread-db.c: Use C++ exception handling.
8240         * linux-tdep.c: Use C++ exception handling.
8241         * linux-nat.c: Use C++ exception handling.
8242         * linux-fork.c: Use C++ exception handling.
8243         * linespec.c: Use C++ exception handling.
8244         * language.c: Use C++ exception handling.
8245         * jit.c: Use C++ exception handling.
8246         * infrun.c: Use C++ exception handling.
8247         * infcmd.c: Use C++ exception handling.
8248         * infcall.c: Use C++ exception handling.
8249         * inf-loop.c: Use C++ exception handling.
8250         * i386-tdep.c: Use C++ exception handling.
8251         * i386-linux-tdep.c: Use C++ exception handling.
8252         * guile/scm-value.c: Use C++ exception handling.
8253         * guile/scm-type.c: Use C++ exception handling.
8254         * guile/scm-symtab.c: Use C++ exception handling.
8255         * guile/scm-symbol.c: Use C++ exception handling.
8256         * guile/scm-pretty-print.c: Use C++ exception handling.
8257         * guile/scm-ports.c: Use C++ exception handling.
8258         * guile/scm-param.c: Use C++ exception handling.
8259         * guile/scm-math.c: Use C++ exception handling.
8260         * guile/scm-lazy-string.c: Use C++ exception handling.
8261         * guile/scm-frame.c: Use C++ exception handling.
8262         * guile/scm-disasm.c: Use C++ exception handling.
8263         * guile/scm-cmd.c: Use C++ exception handling.
8264         * guile/scm-breakpoint.c: Use C++ exception handling.
8265         * guile/scm-block.c: Use C++ exception handling.
8266         * guile/guile-internal.h: Use C++ exception handling.
8267         * gnu-v3-abi.c: Use C++ exception handling.
8268         * gdbtypes.c: Use C++ exception handling.
8269         * frame.c: Use C++ exception handling.
8270         * frame-unwind.c: Use C++ exception handling.
8271         * fbsd-tdep.c: Use C++ exception handling.
8272         * f-valprint.c: Use C++ exception handling.
8273         * exec.c: Use C++ exception handling.
8274         * event-top.c: Use C++ exception handling.
8275         * event-loop.c: Use C++ exception handling.
8276         * eval.c: Use C++ exception handling.
8277         * dwarf2read.c: Use C++ exception handling.
8278         * dwarf2loc.c: Use C++ exception handling.
8279         * dwarf2-frame.c: Use C++ exception handling.
8280         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8281         * dwarf-index-write.c: Use C++ exception handling.
8282         * dwarf-index-cache.c: Use C++ exception handling.
8283         * dtrace-probe.c: Use C++ exception handling.
8284         * disasm-selftests.c: Use C++ exception handling.
8285         * darwin-nat.c: Use C++ exception handling.
8286         * cp-valprint.c: Use C++ exception handling.
8287         * cp-support.c: Use C++ exception handling.
8288         * cp-abi.c: Use C++ exception handling.
8289         * corelow.c: Use C++ exception handling.
8290         * completer.c: Use C++ exception handling.
8291         * compile/compile-object-run.c: Use C++ exception handling.
8292         * compile/compile-object-load.c: Use C++ exception handling.
8293         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8294         * compile/compile-c-symbols.c: Use C++ exception handling.
8295         * common/selftest.c: Use C++ exception handling.
8296         * common/new-op.c: Use C++ exception handling.
8297         * cli/cli-script.c: Use C++ exception handling.
8298         * cli/cli-interp.c: Use C++ exception handling.
8299         * cli/cli-cmds.c: Use C++ exception handling.
8300         * c-varobj.c: Use C++ exception handling.
8301         * btrace.c: Use C++ exception handling.
8302         * breakpoint.c: Use C++ exception handling.
8303         * break-catch-throw.c: Use C++ exception handling.
8304         * arch-utils.c: Use C++ exception handling.
8305         * amd64-tdep.c: Use C++ exception handling.
8306         * ada-valprint.c: Use C++ exception handling.
8307         * ada-typeprint.c: Use C++ exception handling.
8308         * ada-lang.c: Use C++ exception handling.
8309         * aarch64-tdep.c: Use C++ exception handling.
8310
8311 2019-04-08  Tom Tromey  <tom@tromey.com>
8312
8313         * xml-support.c (gdb_xml_parser::parse): Update.
8314         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8315         * value.c (show_convenience): Update.
8316         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8317         (test_parse_flags_qcs): Update.
8318         * thread.c (thr_try_catch_cmd): Update.
8319         * target.c (target_translate_tls_address): Update.
8320         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8321         (info_frame_command_core, frame_apply_command_count): Update.
8322         * rust-exp.y (rust_lex_exception_test): Update.
8323         * riscv-tdep.c (riscv_print_one_register_info): Update.
8324         * remote.c (remote_target::enable_btrace): Update.
8325         * record-btrace.c (record_btrace_enable_warn): Update.
8326         * python/py-utils.c (gdbpy_convert_exception): Update.
8327         * printcmd.c (do_one_display, print_variable_and_value): Update.
8328         * mi/mi-main.c (mi_print_exception): Update.
8329         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8330         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8331         * linux-nat.c (linux_nat_target::attach): Update.
8332         * linux-fork.c (class scoped_switch_fork_info): Update.
8333         * infrun.c (displaced_step_prepare): Update.
8334         * infcall.c (call_function_by_hand_dummy): Update.
8335         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8336         * gnu-v3-abi.c (print_one_vtable): Update.
8337         * frame.c (get_prev_frame_always): Update.
8338         * f-valprint.c (info_common_command_for_block): Update.
8339         * exec.c (try_open_exec_file): Update.
8340         * exceptions.c (print_exception, exception_print)
8341         (exception_fprintf, exception_print_same): Update.
8342         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8343         * dwarf-index-cache.c (index_cache::store)
8344         (index_cache::lookup_gdb_index): Update.
8345         * darwin-nat.c (maybe_cache_shell): Update.
8346         * cp-valprint.c (cp_print_value_fields): Update.
8347         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8348         (gcc_cplus_symbol_address): Update.
8349         * compile/compile-c-symbols.c (gcc_convert_symbol)
8350         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8351         * common/selftest.c: Update.
8352         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8353         a std::string.
8354         (exception_try_scope_entry, exception_try_scope_exit): Don't
8355         declare.
8356         (struct exception_try_scope): Remove.
8357         (TRY): Don't use exception_try_scope.
8358         (struct gdb_exception): Add constructor, operator=.
8359         <what>: New method.
8360         (struct gdb_exception_RETURN_MASK_ALL)
8361         (struct gdb_exception_RETURN_MASK_ERROR)
8362         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8363         (struct gdb_quit_bad_alloc): Update.
8364         * common/common-exceptions.c (exception_none): Change
8365         initializer.
8366         (struct catcher) <state, exception>: Initialize inline.
8367         <prev>: Remove member.
8368         (current_catcher): Remove.
8369         (catchers): New global.
8370         (exceptions_state_mc_init): Simplify.
8371         (catcher_pop): Remove.
8372         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8373         (try_scope_depth, exception_try_scope_entry)
8374         (exception_try_scope_exit): Remove.
8375         (throw_exception_sjlj): Update.
8376         (exception_messages, exception_messages_size): Remove.
8377         (throw_it): Simplify.
8378         (gdb_exception_sliced_copy): Remove.
8379         (throw_exception_cxx): Update.
8380         * cli/cli-script.c (script_from_file): Update.
8381         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8382         Update.
8383         * ada-valprint.c (ada_val_print): Update.
8384         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8385         (create_excep_cond_exprs): Update.
8386
8387 2019-04-08  Tom Tromey  <tom@tromey.com>
8388
8389         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8390         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8391         (TRY, CATCH, END_CATCH): Remove some definitions.
8392         * common/common-exceptions.c: Don't use GDB_XCPT.
8393         (catcher_list_size): Remove.
8394         (throw_exception, throw_it): Simplify.
8395
8396 2019-04-05  Tom Tromey  <tom@tromey.com>
8397
8398         Revert the header-sorting patch.
8399         * ft32-tdep.c: Revert.
8400         * frv-tdep.c: Revert.
8401         * frv-linux-tdep.c: Revert.
8402         * frame.c: Revert.
8403         * frame-unwind.c: Revert.
8404         * frame-base.c: Revert.
8405         * fork-child.c: Revert.
8406         * findvar.c: Revert.
8407         * findcmd.c: Revert.
8408         * filesystem.c: Revert.
8409         * filename-seen-cache.h: Revert.
8410         * filename-seen-cache.c: Revert.
8411         * fbsd-tdep.c: Revert.
8412         * fbsd-nat.h: Revert.
8413         * fbsd-nat.c: Revert.
8414         * f-valprint.c: Revert.
8415         * f-typeprint.c: Revert.
8416         * f-lang.c: Revert.
8417         * extension.h: Revert.
8418         * extension.c: Revert.
8419         * extension-priv.h: Revert.
8420         * expprint.c: Revert.
8421         * exec.h: Revert.
8422         * exec.c: Revert.
8423         * exceptions.c: Revert.
8424         * event-top.c: Revert.
8425         * event-loop.c: Revert.
8426         * eval.c: Revert.
8427         * elfread.c: Revert.
8428         * dwarf2read.h: Revert.
8429         * dwarf2read.c: Revert.
8430         * dwarf2loc.c: Revert.
8431         * dwarf2expr.h: Revert.
8432         * dwarf2expr.c: Revert.
8433         * dwarf2-frame.c: Revert.
8434         * dwarf2-frame-tailcall.c: Revert.
8435         * dwarf-index-write.h: Revert.
8436         * dwarf-index-write.c: Revert.
8437         * dwarf-index-common.c: Revert.
8438         * dwarf-index-cache.h: Revert.
8439         * dwarf-index-cache.c: Revert.
8440         * dummy-frame.c: Revert.
8441         * dtrace-probe.c: Revert.
8442         * disasm.h: Revert.
8443         * disasm.c: Revert.
8444         * disasm-selftests.c: Revert.
8445         * dictionary.c: Revert.
8446         * dicos-tdep.c: Revert.
8447         * demangle.c: Revert.
8448         * dcache.h: Revert.
8449         * dcache.c: Revert.
8450         * darwin-nat.h: Revert.
8451         * darwin-nat.c: Revert.
8452         * darwin-nat-info.c: Revert.
8453         * d-valprint.c: Revert.
8454         * d-namespace.c: Revert.
8455         * d-lang.c: Revert.
8456         * ctf.c: Revert.
8457         * csky-tdep.c: Revert.
8458         * csky-linux-tdep.c: Revert.
8459         * cris-tdep.c: Revert.
8460         * cris-linux-tdep.c: Revert.
8461         * cp-valprint.c: Revert.
8462         * cp-support.c: Revert.
8463         * cp-namespace.c: Revert.
8464         * cp-abi.c: Revert.
8465         * corelow.c: Revert.
8466         * corefile.c: Revert.
8467         * continuations.c: Revert.
8468         * completer.h: Revert.
8469         * completer.c: Revert.
8470         * complaints.c: Revert.
8471         * coffread.c: Revert.
8472         * coff-pe-read.c: Revert.
8473         * cli-out.h: Revert.
8474         * cli-out.c: Revert.
8475         * charset.c: Revert.
8476         * c-varobj.c: Revert.
8477         * c-valprint.c: Revert.
8478         * c-typeprint.c: Revert.
8479         * c-lang.c: Revert.
8480         * buildsym.c: Revert.
8481         * buildsym-legacy.c: Revert.
8482         * build-id.h: Revert.
8483         * build-id.c: Revert.
8484         * btrace.c: Revert.
8485         * bsd-uthread.c: Revert.
8486         * breakpoint.h: Revert.
8487         * breakpoint.c: Revert.
8488         * break-catch-throw.c: Revert.
8489         * break-catch-syscall.c: Revert.
8490         * break-catch-sig.c: Revert.
8491         * blockframe.c: Revert.
8492         * block.c: Revert.
8493         * bfin-tdep.c: Revert.
8494         * bfin-linux-tdep.c: Revert.
8495         * bfd-target.c: Revert.
8496         * bcache.c: Revert.
8497         * ax-general.c: Revert.
8498         * ax-gdb.h: Revert.
8499         * ax-gdb.c: Revert.
8500         * avr-tdep.c: Revert.
8501         * auxv.c: Revert.
8502         * auto-load.c: Revert.
8503         * arm-wince-tdep.c: Revert.
8504         * arm-tdep.c: Revert.
8505         * arm-symbian-tdep.c: Revert.
8506         * arm-pikeos-tdep.c: Revert.
8507         * arm-obsd-tdep.c: Revert.
8508         * arm-nbsd-tdep.c: Revert.
8509         * arm-nbsd-nat.c: Revert.
8510         * arm-linux-tdep.c: Revert.
8511         * arm-linux-nat.c: Revert.
8512         * arm-fbsd-tdep.c: Revert.
8513         * arm-fbsd-nat.c: Revert.
8514         * arm-bsd-tdep.c: Revert.
8515         * arch-utils.c: Revert.
8516         * arc-tdep.c: Revert.
8517         * arc-newlib-tdep.c: Revert.
8518         * annotate.h: Revert.
8519         * annotate.c: Revert.
8520         * amd64-windows-tdep.c: Revert.
8521         * amd64-windows-nat.c: Revert.
8522         * amd64-tdep.c: Revert.
8523         * amd64-sol2-tdep.c: Revert.
8524         * amd64-obsd-tdep.c: Revert.
8525         * amd64-obsd-nat.c: Revert.
8526         * amd64-nbsd-tdep.c: Revert.
8527         * amd64-nbsd-nat.c: Revert.
8528         * amd64-nat.c: Revert.
8529         * amd64-linux-tdep.c: Revert.
8530         * amd64-linux-nat.c: Revert.
8531         * amd64-fbsd-tdep.c: Revert.
8532         * amd64-fbsd-nat.c: Revert.
8533         * amd64-dicos-tdep.c: Revert.
8534         * amd64-darwin-tdep.c: Revert.
8535         * amd64-bsd-nat.c: Revert.
8536         * alpha-tdep.c: Revert.
8537         * alpha-obsd-tdep.c: Revert.
8538         * alpha-nbsd-tdep.c: Revert.
8539         * alpha-mdebug-tdep.c: Revert.
8540         * alpha-linux-tdep.c: Revert.
8541         * alpha-linux-nat.c: Revert.
8542         * alpha-bsd-tdep.c: Revert.
8543         * alpha-bsd-nat.c: Revert.
8544         * aix-thread.c: Revert.
8545         * agent.c: Revert.
8546         * addrmap.c: Revert.
8547         * ada-varobj.c: Revert.
8548         * ada-valprint.c: Revert.
8549         * ada-typeprint.c: Revert.
8550         * ada-tasks.c: Revert.
8551         * ada-lang.c: Revert.
8552         * aarch64-tdep.c: Revert.
8553         * aarch64-ravenscar-thread.c: Revert.
8554         * aarch64-newlib-tdep.c: Revert.
8555         * aarch64-linux-tdep.c: Revert.
8556         * aarch64-linux-nat.c: Revert.
8557         * aarch64-fbsd-tdep.c: Revert.
8558         * aarch64-fbsd-nat.c: Revert.
8559         * aarch32-linux-nat.c: Revert.
8560
8561 2019-04-05  Tom Tromey  <tom@tromey.com>
8562
8563         * ft32-tdep.c: Sort headers.
8564         * frv-tdep.c: Sort headers.
8565         * frv-linux-tdep.c: Sort headers.
8566         * frame.c: Sort headers.
8567         * frame-unwind.c: Sort headers.
8568         * frame-base.c: Sort headers.
8569         * fork-child.c: Sort headers.
8570         * findvar.c: Sort headers.
8571         * findcmd.c: Sort headers.
8572         * filesystem.c: Sort headers.
8573         * filename-seen-cache.h: Sort headers.
8574         * filename-seen-cache.c: Sort headers.
8575         * fbsd-tdep.c: Sort headers.
8576         * fbsd-nat.h: Sort headers.
8577         * fbsd-nat.c: Sort headers.
8578         * f-valprint.c: Sort headers.
8579         * f-typeprint.c: Sort headers.
8580         * f-lang.c: Sort headers.
8581         * extension.h: Sort headers.
8582         * extension.c: Sort headers.
8583         * extension-priv.h: Sort headers.
8584         * expprint.c: Sort headers.
8585         * exec.h: Sort headers.
8586         * exec.c: Sort headers.
8587         * exceptions.c: Sort headers.
8588         * event-top.c: Sort headers.
8589         * event-loop.c: Sort headers.
8590         * eval.c: Sort headers.
8591         * elfread.c: Sort headers.
8592         * dwarf2read.h: Sort headers.
8593         * dwarf2read.c: Sort headers.
8594         * dwarf2loc.c: Sort headers.
8595         * dwarf2expr.h: Sort headers.
8596         * dwarf2expr.c: Sort headers.
8597         * dwarf2-frame.c: Sort headers.
8598         * dwarf2-frame-tailcall.c: Sort headers.
8599         * dwarf-index-write.h: Sort headers.
8600         * dwarf-index-write.c: Sort headers.
8601         * dwarf-index-common.c: Sort headers.
8602         * dwarf-index-cache.h: Sort headers.
8603         * dwarf-index-cache.c: Sort headers.
8604         * dummy-frame.c: Sort headers.
8605         * dtrace-probe.c: Sort headers.
8606         * disasm.h: Sort headers.
8607         * disasm.c: Sort headers.
8608         * disasm-selftests.c: Sort headers.
8609         * dictionary.c: Sort headers.
8610         * dicos-tdep.c: Sort headers.
8611         * demangle.c: Sort headers.
8612         * dcache.h: Sort headers.
8613         * dcache.c: Sort headers.
8614         * darwin-nat.h: Sort headers.
8615         * darwin-nat.c: Sort headers.
8616         * darwin-nat-info.c: Sort headers.
8617         * d-valprint.c: Sort headers.
8618         * d-namespace.c: Sort headers.
8619         * d-lang.c: Sort headers.
8620         * ctf.c: Sort headers.
8621         * csky-tdep.c: Sort headers.
8622         * csky-linux-tdep.c: Sort headers.
8623         * cris-tdep.c: Sort headers.
8624         * cris-linux-tdep.c: Sort headers.
8625         * cp-valprint.c: Sort headers.
8626         * cp-support.c: Sort headers.
8627         * cp-namespace.c: Sort headers.
8628         * cp-abi.c: Sort headers.
8629         * corelow.c: Sort headers.
8630         * corefile.c: Sort headers.
8631         * continuations.c: Sort headers.
8632         * completer.h: Sort headers.
8633         * completer.c: Sort headers.
8634         * complaints.c: Sort headers.
8635         * coffread.c: Sort headers.
8636         * coff-pe-read.c: Sort headers.
8637         * cli-out.h: Sort headers.
8638         * cli-out.c: Sort headers.
8639         * charset.c: Sort headers.
8640         * c-varobj.c: Sort headers.
8641         * c-valprint.c: Sort headers.
8642         * c-typeprint.c: Sort headers.
8643         * c-lang.c: Sort headers.
8644         * buildsym.c: Sort headers.
8645         * buildsym-legacy.c: Sort headers.
8646         * build-id.h: Sort headers.
8647         * build-id.c: Sort headers.
8648         * btrace.c: Sort headers.
8649         * bsd-uthread.c: Sort headers.
8650         * breakpoint.h: Sort headers.
8651         * breakpoint.c: Sort headers.
8652         * break-catch-throw.c: Sort headers.
8653         * break-catch-syscall.c: Sort headers.
8654         * break-catch-sig.c: Sort headers.
8655         * blockframe.c: Sort headers.
8656         * block.c: Sort headers.
8657         * bfin-tdep.c: Sort headers.
8658         * bfin-linux-tdep.c: Sort headers.
8659         * bfd-target.c: Sort headers.
8660         * bcache.c: Sort headers.
8661         * ax-general.c: Sort headers.
8662         * ax-gdb.h: Sort headers.
8663         * ax-gdb.c: Sort headers.
8664         * avr-tdep.c: Sort headers.
8665         * auxv.c: Sort headers.
8666         * auto-load.c: Sort headers.
8667         * arm-wince-tdep.c: Sort headers.
8668         * arm-tdep.c: Sort headers.
8669         * arm-symbian-tdep.c: Sort headers.
8670         * arm-pikeos-tdep.c: Sort headers.
8671         * arm-obsd-tdep.c: Sort headers.
8672         * arm-nbsd-tdep.c: Sort headers.
8673         * arm-nbsd-nat.c: Sort headers.
8674         * arm-linux-tdep.c: Sort headers.
8675         * arm-linux-nat.c: Sort headers.
8676         * arm-fbsd-tdep.c: Sort headers.
8677         * arm-fbsd-nat.c: Sort headers.
8678         * arm-bsd-tdep.c: Sort headers.
8679         * arch-utils.c: Sort headers.
8680         * arc-tdep.c: Sort headers.
8681         * arc-newlib-tdep.c: Sort headers.
8682         * annotate.h: Sort headers.
8683         * annotate.c: Sort headers.
8684         * amd64-windows-tdep.c: Sort headers.
8685         * amd64-windows-nat.c: Sort headers.
8686         * amd64-tdep.c: Sort headers.
8687         * amd64-sol2-tdep.c: Sort headers.
8688         * amd64-obsd-tdep.c: Sort headers.
8689         * amd64-obsd-nat.c: Sort headers.
8690         * amd64-nbsd-tdep.c: Sort headers.
8691         * amd64-nbsd-nat.c: Sort headers.
8692         * amd64-nat.c: Sort headers.
8693         * amd64-linux-tdep.c: Sort headers.
8694         * amd64-linux-nat.c: Sort headers.
8695         * amd64-fbsd-tdep.c: Sort headers.
8696         * amd64-fbsd-nat.c: Sort headers.
8697         * amd64-dicos-tdep.c: Sort headers.
8698         * amd64-darwin-tdep.c: Sort headers.
8699         * amd64-bsd-nat.c: Sort headers.
8700         * alpha-tdep.c: Sort headers.
8701         * alpha-obsd-tdep.c: Sort headers.
8702         * alpha-nbsd-tdep.c: Sort headers.
8703         * alpha-mdebug-tdep.c: Sort headers.
8704         * alpha-linux-tdep.c: Sort headers.
8705         * alpha-linux-nat.c: Sort headers.
8706         * alpha-bsd-tdep.c: Sort headers.
8707         * alpha-bsd-nat.c: Sort headers.
8708         * aix-thread.c: Sort headers.
8709         * agent.c: Sort headers.
8710         * addrmap.c: Sort headers.
8711         * ada-varobj.c: Sort headers.
8712         * ada-valprint.c: Sort headers.
8713         * ada-typeprint.c: Sort headers.
8714         * ada-tasks.c: Sort headers.
8715         * ada-lang.c: Sort headers.
8716         * aarch64-tdep.c: Sort headers.
8717         * aarch64-ravenscar-thread.c: Sort headers.
8718         * aarch64-newlib-tdep.c: Sort headers.
8719         * aarch64-linux-tdep.c: Sort headers.
8720         * aarch64-linux-nat.c: Sort headers.
8721         * aarch64-fbsd-tdep.c: Sort headers.
8722         * aarch64-fbsd-nat.c: Sort headers.
8723         * aarch32-linux-nat.c: Sort headers.
8724
8725 2019-04-04  Tom Tromey  <tom@tromey.com>
8726
8727         * varobj.c (varobj_create): Update.
8728         * rust-exp.y (struct rust_parser) <update_innermost_block,
8729         lookup_symbol>: New methods.
8730         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8731         Rename.
8732         (rust_parser::rust_lookup_type)
8733         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8734         * printcmd.c (display_command, do_one_display): Update.
8735         * parser-defs.h (struct parser_state) <parser_state>: Add
8736         "tracker" parameter.
8737         (block_tracker): New member.
8738         (class innermost_block_tracker) <innermost_block_tracker>: Add
8739         "types" parameter.
8740         <reset>: Remove method.
8741         (innermost_block): Don't declare.
8742         (null_post_parser): Update.
8743         * parse.c (innermost_block): Remove global.
8744         (write_dollar_variable): Update.
8745         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8746         Remove "tracker_types" parameter.
8747         (parse_expression): Add "tracker" parameter.
8748         (parse_expression_for_completion): Update.
8749         (null_post_parser): Add "tracker" parameter.
8750         * p-exp.y: Update rules.
8751         * m2-exp.y: Update rules.
8752         * language.h (struct language_defn) <la_post_parser>: Add
8753         "tracker" parameter.
8754         * go-exp.y: Update rules.
8755         * f-exp.y: Update rules.
8756         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8757         parameter.
8758         * d-exp.y: Update rules.
8759         * c-exp.y: Update rules.
8760         * breakpoint.c (set_breakpoint_condition): Create an
8761         innermost_block_tracker.
8762         (watch_command_1): Likewise.
8763         * ada-lang.c (resolve): Add "tracker" parameter.
8764         (resolve_subexp): Likewise.
8765         * ada-exp.y (write_var_from_sym): Update.
8766
8767 2019-04-04  Tom Tromey  <tom@tromey.com>
8768
8769         * type-stack.h: New file.
8770         * type-stack.c: New file.
8771         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8772         type-stack.h.
8773         (insert_into_type_stack, insert_type, push_type, push_type_int)
8774         (insert_type_address_space, pop_type, pop_type_int)
8775         (pop_typelist, pop_type_stack, append_type_stack)
8776         (push_type_stack, get_type_stack, push_typelist)
8777         (follow_type_instance_flags, follow_types): Don't declare.
8778         * parse.c (type_stack): Remove global.
8779         (parse_exp_in_context): Update.
8780         (insert_into_type_stack, insert_type, push_type, push_type_int)
8781         (insert_type_address_space, pop_type, pop_type_int)
8782         (pop_typelist, pop_type_stack, append_type_stack)
8783         (push_type_stack, get_type_stack, push_typelist)
8784         (follow_type_instance_flags, follow_types): Remove (moved to
8785         type-stack.c).
8786         * f-exp.y (type_stack): New global.
8787         Update rules.
8788         (push_kind_type, f_parse): Update.
8789         * d-exp.y (type_stack): New global.
8790         Update rules.
8791         (d_parse): Update.
8792         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8793         Update rules.
8794         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8795         (HFILES_NO_SRCDIR): Add type-stack.h.
8796
8797 2019-04-04  Tom Tromey  <tom@tromey.com>
8798
8799         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8800         (rust_parser::convert_ast_to_expression, rust_parse)
8801         (rust_lex_test_completion, rust_lex_tests): Update.
8802         * parser-defs.h (struct expr_completion_state): New.
8803         (struct parser_state) <parser_state>: Add completion parameter.
8804         <mark_struct_expression, mark_completion_tag>: New methods.
8805         <parse_completion, m_completion_state>: New members.
8806         (prefixify_expression, null_post_parser): Update.
8807         (mark_struct_expression, mark_completion_tag): Don't declare.
8808         * parse.c (parse_completion, expout_last_struct)
8809         (expout_tag_completion_type, expout_completion_name): Remove
8810         globals.
8811         (parser_state::mark_struct_expression)
8812         (parser_state::mark_completion_tag): Now methods.
8813         (prefixify_expression): Add last_struct parameter.
8814         (prefixify_subexp): Likewise.
8815         (parse_exp_1): Update.
8816         (parse_exp_in_context): Add cstate parameter.  Update.
8817         (parse_expression_for_completion): Create an
8818         expr_completion_state.
8819         (null_post_parser): Add "completion" parameter.
8820         * p-exp.y: Update rules.
8821         (yylex): Update.
8822         * language.h (struct language_defn) <la_post_parser>: Add
8823         "completing" parameter.
8824         * go-exp.y: Update rules.
8825         (lex_one_token): Update.
8826         * expression.h (parse_completion): Don't declare.
8827         * d-exp.y: Update rules.
8828         (lex_one_token): Update rules.
8829         * c-exp.y: Update rules.
8830         (lex_one_token): Update.
8831         * ada-lang.c (resolve): Add "parse_completion" parameter.
8832         (resolve_subexp): Likewise.
8833         (ada_resolve_function): Likewise.
8834
8835 2019-04-04  Tom Tromey  <tom@tromey.com>
8836
8837         * parser-defs.h (struct parser_state) <start_arglist,
8838         end_arglist>: New methods.
8839         <arglist_len, m_funcall_chain>: New members.
8840         (arglist_len, start_arglist, end_arglist): Don't declare.
8841         * parse.c (arglist_len, funcall_chain): Remove global.
8842         (start_arglist, end_arglist): Remove functions.
8843         (parse_exp_in_context): Update.
8844         * p-exp.y: Update rules.
8845         * m2-exp.y: Update rules.
8846         * go-exp.y: Update rules.
8847         * f-exp.y: Update rules.
8848         * d-exp.y: Update rules.
8849         * c-exp.y: Update rules.
8850
8851 2019-04-04  Tom Tromey  <tom@tromey.com>
8852
8853         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8854         lex_operator, push_back>: New methods.
8855         Update all rules.
8856         (rust_parser::lex_hex, lex_escape): Rename and update.
8857         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8858         (rust_parser::lex_operator): Rename and update.
8859         (rust_parser::lex_number, rustyylex, rustyyerror)
8860         (rust_lex_test_init, rust_lex_test_sequence)
8861         (rust_lex_test_push_back, rust_lex_tests): Update.
8862         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8863         parameter.
8864         <lexptr, prev_lexptr>: New members.
8865         (lexptr, prev_lexptr): Don't declare.
8866         * parse.c (lexptr, prev_lexptr): Remove globals.
8867         (parse_exp_in_context): Update.
8868         * p-exp.y (yylex, yyerror): Update.
8869         * m2-exp.y (parse_number, yylex, yyerror): Update.
8870         * go-exp.y (lex_one_token, yyerror): Update.
8871         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8872         * d-exp.y (lex_one_token, yyerror): Update.
8873         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8874         (lex_one_token, yyerror): Update.
8875         * ada-lex.l (YY_INPUT): Update.
8876         (rewind_to_char): Update.
8877         * ada-exp.y (yyerror): Update.
8878
8879 2019-04-04  Tom Tromey  <tom@tromey.com>
8880
8881         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8882         * parser-defs.h (struct parser_state) <parser_state>: Add new
8883         parameter.
8884         <comma_terminates>: New member.
8885         (comma_terminates): Don't declare global.
8886         * parse.c (comma_terminates): Remove global.
8887         (parse_exp_in_context): Update.
8888         * p-exp.y (yylex): Update.
8889         * m2-exp.y (yylex): Update.
8890         * go-exp.y (lex_one_token): Update.
8891         * f-exp.y (yylex): Update.
8892         * d-exp.y (lex_one_token): Update.
8893         * c-exp.y (lex_one_token): Update.
8894         * ada-lex.l: Update.
8895
8896 2019-04-04  Tom Tromey  <tom@tromey.com>
8897
8898         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8899         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8900         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8901         * parser-defs.h (paren_depth): Don't declare.
8902         * parse.c (paren_depth): Remove global.
8903         (parse_exp_in_context): Update.
8904         * p-exp.y (paren_depth): New global.
8905         (pascal_parse): Initialize it.
8906         * m2-exp.y (paren_depth): New global.
8907         (m2_parse): Initialize it.
8908         * go-exp.y (paren_depth): New global.
8909         (go_parse): Initialize it.
8910         * f-exp.y (paren_depth): New global.
8911         (f_parse): Initialize it.
8912         * d-exp.y (paren_depth): New global.
8913         (d_parse): Initialize it.
8914         * c-exp.y (paren_depth): New global.
8915         (c_parse): Initialize it.
8916         * ada-lex.l (paren_depth): New global.
8917         (lexer_init): Initialize it.
8918
8919 2019-04-04  Tom Tromey  <tom@tromey.com>
8920
8921         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8922         (rust_parser::convert_ast_to_type)
8923         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8924         * parser-defs.h (struct parser_state) <parser_state>: Add
8925         parameters.  Initialize new members.
8926         <expression_context_block, expression_context_pc>: New members.
8927         * parse.c (expression_context_block, expression_context_pc):
8928         Remove globals.
8929         (parse_exp_in_context): Update.
8930         * p-exp.y: Update all rules.
8931         (yylex): Update.
8932         * m2-exp.y: Update all rules.
8933         (yylex): Update.
8934         * go-exp.y (yylex): Update.
8935         * f-exp.y (yylex): Update.
8936         * d-exp.y: Update all rules.
8937         (yylex): Update.
8938         * c-exp.y: Update all rules.
8939         (lex_one_token, classify_name, yylex, c_parse): Update.
8940         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8941
8942 2019-04-04  Tom Tromey  <tom@tromey.com>
8943
8944         * gdbarch.h, gdbarch.c: Rebuild.
8945         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8946         * stap-probe.h:
8947         (struct stap_parse_info): Replace "parser_state" with
8948         "expr_builder".
8949         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8950         (parser_state): New class.
8951         * parse.c (expr_builder): Rename.
8952         (expr_builder::release): Rename.
8953         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8954         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8955         (write_exp_elt_longcst, write_exp_elt_floatcst)
8956         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8957         (write_exp_string_vector, write_exp_bitstring)
8958         (write_exp_msymbol, mark_struct_expression)
8959         (write_dollar_variable)
8960         (insert_type_address_space, increase_expout_size): Replace
8961         "parser_state" with "expr_builder".
8962         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8963         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8964         "parser_state" with "expr_builder".
8965
8966 2019-04-04  Tom Tromey  <tom@tromey.com>
8967
8968         * rust-exp.y: Replace "parse_language" with method call.
8969         * p-exp.y:
8970         (yylex): Replace "parse_language" with method call.
8971         * m2-exp.y:
8972         (yylex): Replace "parse_language" with method call.
8973         * go-exp.y (classify_name): Replace "parse_language" with method
8974         call.
8975         * f-exp.y (yylex): Replace "parse_language" with method call.
8976         * d-exp.y (lex_one_token): Replace "parse_language" with method
8977         call.
8978         * c-exp.y:
8979         (lex_one_token, classify_name, yylex): Replace "parse_language"
8980         with method call.
8981         * ada-exp.y (find_primitive_type, type_char)
8982         (type_system_address): Replace "parse_language" with method call.
8983
8984 2019-04-04  Tom Tromey  <tom@tromey.com>
8985
8986         * rust-exp.y: Replace "parse_gdbarch" with method call.
8987         * parse.c (write_dollar_variable, insert_type_address_space):
8988         Replace "parse_gdbarch" with method call.
8989         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8990         call.
8991         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8992         call.
8993         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8994         "parse_gdbarch" with method call.
8995         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8996         with method call.
8997         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8998         "parse_gdbarch" with method call.
8999         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9000         "parse_gdbarch" with method call.
9001         * c-exp.y (parse_type, parse_number, classify_name): Replace
9002         "parse_gdbarch" with method call.
9003         * ada-lex.l: Replace "parse_gdbarch" with method call.
9004         * ada-exp.y (parse_type, find_primitive_type, type_char)
9005         (type_system_address): Replace "parse_gdbarch" with method call.
9006
9007 2019-04-04  Tom Tromey  <tom@tromey.com>
9008
9009         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9010         * stap-probe.c (stap_parse_argument): Update.
9011         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9012         initial_size parameter.
9013         * rust-exp.y (rust_lex_tests): Update.
9014         * parse.c (parser_state): Update.
9015         (parse_exp_in_context): Update.
9016         * parser-defs.h (struct parser_state) <parser_state>: Remove
9017         "initial_size" parameter.
9018
9019 2019-04-04  Tom Tromey  <tom@tromey.com>
9020
9021         * parser-defs.h (increase_expout_size): Don't declare.
9022         * parse.c (increase_expout_size): Now static.
9023
9024 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9025
9026         * gnu-nat.c (gnu_nat_target::wait): Fix
9027         target_waitstatus_to_string call.
9028
9029 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9030
9031         * eval.c (evaluate_subexp_standard): Handle internal functions
9032         during Fortran function call handling.
9033
9034 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9035
9036         * NEWS: Mention new internal functions.
9037         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9038         (read_base_type): Use dwarf2_init_complex_target_type.
9039         * value.c (creal_internal_fn): New function.
9040         (cimag_internal_fn): New function.
9041         (_initialize_values): Register new internal functions.
9042
9043 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9044
9045         * infrun.c (stop_all_threads): If debug_infrun, always
9046         trace the wait status after wait_one, using
9047         target_waitstatus_to_string and target_pid_to_str.
9048         (handle_inferior_event): Replace various trace of
9049         wait status kind by a single trace.
9050         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9051         wait status kind image by target_waitstatus_to_string.
9052         * target/waitstatus.c (target_waitstatus_to_string): Fix
9053         obsolete comment.
9054
9055 2019-04-01  Tom Tromey  <tromey@adacore.com>
9056
9057         PR symtab/23331:
9058         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9059
9060 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9061             Pedro Alves  <palves@redhat.com>
9062
9063         * top.c (quit_force): Call 'finalize_values'.
9064         * value.c (finalize_values): New function.
9065         * value.h (finalize_values): Declare.
9066
9067 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9068
9069         * NEWS: Announce $_gdb_major and $_gdb_minor.
9070
9071         * top.c (init_gdb_version_vars): New function.
9072         (gdb_init): Call init_gdb_version_vars.
9073
9074 2019-03-29  Tom Tromey  <tromey@adacore.com>
9075
9076         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9077         help text.  Remove dead code.
9078
9079 2019-03-29  Keith Seitz  <keiths@redhat.com>
9080
9081         From Siddhesh Poyarekar:
9082         * f-lang.h (f77_get_upperbound): Return LONGEST.
9083         (f77_get_lowerbound): Likewise.
9084         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9085         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9086         print them.
9087         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9088         plongest to format print it.
9089         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9090         (f77_get_upperbound): Likewise.
9091         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9092         LOWER_BOUND to LONGEST.
9093         (f77_create_arrayprint_offset_tbl): Likewise.
9094
9095 2019-03-29  Keith Seitz  <keiths@redhat.com>
9096
9097         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9098         %s/pulongest for TYPE_LENGTH instead of %d in format
9099         strings.
9100         * ada-typerint.c (ada_print_type): Likewise.
9101         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9102         * compile/compile-c-support.c (generate_register_struct): Likewise.
9103         * gdbtypes.c (recursive_dump_type): Likewise.
9104         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9105         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9106         instead of %d in format strings.
9107         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9108         to std::min to ULONGEST.
9109         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9110         instead of %d in format strings.
9111         * tracepoint.c (info_scope_command): Likewise.
9112         * typeprint.c (print_offset_data::update)
9113         (print_offset_data::finish): Likewise.
9114         * xtensa-tdep.c (xtensa_store_return_value)
9115         (xtensa_push_dummy_call): Likewise.
9116
9117 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9118
9119         * windows-nat.c (display_selector): Fixed format specifications
9120         for 64-bit Cygwin.
9121
9122 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9123
9124         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9125
9126 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9127
9128         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9129         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9130         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9131         (nios2_linux_init_abi): Install it.
9132
9133 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9134
9135         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9136
9137 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9138
9139         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9140
9141 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9142             Tom Tromey  <tromey@adacore.com>
9143
9144         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9145
9146 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9147
9148         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9149         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9150         method to compute the bounds of range types. Also print "[evaluated]"
9151         if the bounds' values come from a dynamic evaluation.
9152
9153 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9154
9155         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9156         whitespace when pretty printing is on.
9157
9158 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9159
9160         * ppc-linux-nat.c: Add include.
9161
9162 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9163
9164         * NEWS: Mention AArch64 Pointer Authentication.
9165
9166 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9167
9168         * arm-linux-nat.c: Add include.
9169
9170 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9171
9172         * source-cache.c (source_cache::get_source_lines): Re-read
9173         fullname after calling open_source_file.
9174
9175 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9176
9177         * NEWS: Mention TLS support for FreeBSD.
9178
9179 2019-03-25  Tom Tromey  <tromey@adacore.com>
9180
9181         * minsyms.c (BUNCH_SIZE): Update comment.
9182         (~minimal_symbol_reader): Remove old comment.
9183         (compact_minimal_symbols): Update comment.
9184         (minimal_symbol_reader::install): Remove old comment.  Update
9185         other comments.
9186
9187 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9188
9189         * s390-linux-nat.c: Add include.
9190
9191 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9192
9193         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9194         Call linux_get_hwcap.
9195         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9196         Likewise.
9197         (aarch64_linux_get_hwcap): Remove function.
9198         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9199         declaration.
9200         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9201         linux_get_hwcap.
9202         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9203         * linux-tdep.c (linux_get_hwcap): Add function.
9204         (linux_get_hwcap2): Likewise.
9205         * linux-tdep.h (linux_get_hwcap): Add declaration.
9206         (linux_get_hwcap2): Likewise.
9207         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9208         (ppc_linux_get_hwcap2): Likewise.
9209         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9210         linux_get_hwcap.
9211         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9212         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9213         (ppc_linux_nat_target::read_description): Likewise.
9214         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9215         * s390-linux-nat.c: Likewise.
9216         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9217
9218 2019-03-24  Tom Tromey  <tom@tromey.com>
9219
9220         * ada-lang.c (standard_lookup): Simplify initialization.
9221         (ada_lookup_symbol_nonlocal): Simplify return.
9222         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9223         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9224         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9225         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9226         initialization.
9227         * solib.c (solib_global_lookup): Simplify.
9228         * symtab.c (null_block_symbol): Remove.
9229         (symbol_cache_lookup): Simplify returns.
9230         (lookup_language_this): Simplify returns.
9231         (lookup_symbol_aux): Simplify return.
9232         (lookup_local_symbol): Simplify returns.
9233         (lookup_global_symbol_from_objfile): Simplify return.
9234         (lookup_symbol_in_objfile_symtabs)
9235         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9236         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9237         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9238         * cp-namespace.c (cp_lookup_bare_symbol)
9239         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9240         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9241         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9242         (cp_lookup_symbol_via_imports): Simplify initialization.
9243         (find_symbol_in_baseclass): Likewise.
9244         * symtab.h (null_block_symbol): Remove.
9245         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9246         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9247         (d_lookup_symbol_module): Likewise.
9248         (find_symbol_in_baseclass): Simplify initialization.
9249
9250 2019-03-24  Tom Tromey  <tom@tromey.com>
9251
9252         * expression.h: Don't include symtab.h.
9253         (struct block): Forward declare.
9254
9255 2019-03-24  Tom Tromey  <tom@tromey.com>
9256
9257         * c-exp.y (typebase): Remove casts.
9258         * gdbtypes.c (lookup_unsigned_typename, )
9259         (lookup_signed_typename): Remove cast.
9260         * eval.c (parse_to_comma_and_eval): Remove cast.
9261         * parse.c (write_dollar_variable): Remove cast.
9262         * block.h (struct block) <superblock>: Now const.
9263         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9264         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9265         (map_block): Make "block" const.
9266         * symfile.h (struct quick_symbol_functions)
9267         <map_matching_symbols>: Constify block argument to "callback".
9268         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9269         const.
9270         (find_pc_sect_compunit_symtab): Make "b" const.
9271         (find_symbol_at_address): Likewise.
9272         (search_symbols): Likewise.
9273         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9274         (dw2_debug_names_lookup_symbol): Likewise.
9275         (dw2_map_matching_symbols): Update.
9276         * p-valprint.c (pascal_val_print): Remove "block".
9277         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9278         (aux_add_nonlocal_symbols): Make "block" const.
9279         (resolve_subexp): Remove cast.
9280         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9281         const.
9282         (iterate_over_file_blocks): Likewise.
9283         * f-exp.y (%union) <bval>: Remove.
9284         * coffread.c (patch_opaque_types): Make "b" const.
9285         * spu-tdep.c (spu_catch_start): Make "block" const.
9286         * c-valprint.c (print_unpacked_pointer): Remove "block".
9287         * symmisc.c (dump_symtab_1): Make "b" const.
9288         (block_depth): Make "block" const.
9289         * d-exp.y (%union) <bval>: Remove.
9290         * cp-support.h (cp_lookup_rtti_type): Update.
9291         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9292         * psymtab.c (psym_lookup_symbol): Make "block" const.
9293         (maintenance_check_psymtabs): Make "b" const.
9294         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9295         (enumerate_locals, enumerate_args): Update.
9296         * python/py-symtab.c (stpy_global_block): Make "block" const.
9297         (stpy_static_block): Likewise.
9298         * inline-frame.c (block_starting_point_at): Make "new_block"
9299         const.
9300         * block.c (find_block_in_blockvector): Make return type const.
9301         (blockvector_for_pc_sect): Make "b" const.
9302         (find_block_in_blockvector): Make "b" const.
9303
9304 2019-03-23  Tom Tromey  <tom@tromey.com>
9305
9306         * varobj.c (varobj_create): Update.
9307         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9308         * printcmd.c (display_command, do_one_display): Don't reset
9309         innermost_block.
9310         * parser-defs.h (enum innermost_block_tracker_type): Move to
9311         expression.h.
9312         (innermost_block): Update comment.
9313         * parse.c (parse_exp_1): Add tracker_types parameter.
9314         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9315         tracker_types parameter.  Reset innermost_block.
9316         (parse_exp_in_context): Remove.
9317         (parse_expression_for_completion): Update.
9318         * objfiles.c (~objfile): Don't reset expression_context_block or
9319         innermost_block.
9320         * expression.h (enum innermost_block_tracker_type): Move from
9321         parser-defs.h.
9322         (parse_exp_1): Add tracker_types parameter.
9323         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9324         reset innermost_block.
9325
9326 2019-03-23  Tom Tromey  <tom@tromey.com>
9327
9328         * objfiles.h: Include bcache.h.
9329
9330 2019-03-23  Tom Tromey  <tom@tromey.com>
9331
9332         * linespec.c (get_current_search_block): Use
9333         scoped_restore_current_language.
9334         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9335
9336 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9337             Jiong Wang  <jiong.wang@arm.com>
9338
9339         * aarch64-linux-tdep.c
9340         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9341         section.
9342         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9343
9344 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9345             Jiong Wang  <jiong.wang@arm.com>
9346
9347         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9348         instructions.
9349         (aarch64_analyze_prologue_test): Add PACIASP test.
9350         (aarch64_prologue_prev_register): Unmask PC value.
9351
9352 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9353             Jiong Wang  <jiong.wang@arm.com>
9354
9355         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9356         (aarch64_dwarf2_prev_register): Unmask PC value.
9357         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9358         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9359         DW_CFA_AARCH64_negate_ra_state.
9360         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9361
9362 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9363             Jiong Wang  <jiong.wang@arm.com>
9364
9365         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9366         registers.
9367         (aarch64_pseudo_register_name): Likewise.
9368         (aarch64_pseudo_register_type): Likewise.
9369         (aarch64_pseudo_register_reggroup_p): Likewise.
9370         (aarch64_gdbarch_init): Add pauth registers.
9371         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9372         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9373         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9374         (struct gdbarch_tdep): Add regnum for ra_state.
9375
9376 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9377             Jiong Wang  <jiong.wang@arm.com>
9378
9379         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9380
9381 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9382             Jiong Wang  <jiong.wang@arm.com>
9383
9384         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9385         function.
9386         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9387         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9388         (aarch64_gdbarch_init): Add puth registers.
9389         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9390         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9391         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9392
9393 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9394             Jiong Wang  <jiong.wang@arm.com>
9395
9396         * aarch64-linux-nat.c
9397         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9398         * aarch64-linux-tdep.c
9399         (aarch64_linux_core_read_description): Likewise.
9400         (aarch64_linux_get_hwcap): New function.
9401         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9402         (aarch64_linux_get_hwcap): New declaration.
9403
9404 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9405             Jiong Wang  <jiong.wang@arm.com>
9406
9407         * aarch64-linux-nat.c
9408         (aarch64_linux_nat_target::read_description): Add pauth param.
9409         * aarch64-linux-tdep.c
9410         (aarch64_linux_core_read_description): Likewise.
9411         * aarch64-tdep.c (struct target_desc): Add in pauth.
9412         (aarch64_read_description): Add pauth param.
9413         (aarch64_gdbarch_init): Likewise.
9414         * aarch64-tdep.h (aarch64_read_description): Likewise.
9415         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9416         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9417         * features/Makefile: Add new files.
9418         * features/aarch64-pauth.c: New file.
9419         * features/aarch64-pauth.xml: New file.
9420
9421 2019-03-20  Tom Tromey  <tromey@adacore.com>
9422
9423         * infrun.c (handle_inferior_event): Rename from
9424         handle_inferior_event_1.  Create a scoped_value_mark.
9425         (handle_inferior_event): Remove.
9426
9427 2019-03-19  Tom Tromey  <tromey@adacore.com>
9428
9429         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9430         * infrun.h (print_stop_event): Add "displays" parameter.
9431         * infrun.c (print_stop_event): Add "displays" parameter.
9432
9433 2019-03-19  Pedro Alves  <palves@redhat.com>
9434
9435         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9436         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9437         to -1.  Fix TABs vs spaces.
9438         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9439         * tui/tui-out.h (tui_ui_out) Add intro comments.
9440         <m_line, m_start_of_line>: In-class initialize, and add describing
9441         comment.
9442
9443 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9444
9445         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9446         variable names.
9447         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9448
9449 2019-03-18  Pedro Alves  <palves@redhat.com>
9450             Eli Zaretskii <eliz@gnu.org>
9451
9452         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9453         m_line and m_start_of_line.
9454
9455 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9456
9457         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9458         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9459         it returns a newline.  This fixes a regression in TU mode, whereby
9460         the next line is output on the same screen line as the user input.
9461
9462 2019-03-18  Tom Tromey  <tromey@adacore.com>
9463
9464         * minsyms.c (minimal_symbol_reader::install): Remove call to
9465         obstack_blank.
9466
9467 2019-03-18  Pedro Alves  <palves@redhat.com>
9468
9469         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9470         New globals.
9471         (apply_style): New, factored out from ...
9472         (apply_ansi_escape): ... this.  Handle reverse video mode.
9473         (tui_set_reverse_mode): New function.
9474         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9475         * tui/tui-winsource.c (tui_show_source_line): Use
9476         tui_set_reverse_mode instead of setting A_STANDOUT.
9477         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9478         New setter methods.
9479
9480 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9481
9482         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9483         Handle tabs.
9484
9485 2019-03-18  Tom Tromey  <tromey@adacore.com>
9486
9487         * ada-lang.c (empty_array): Add "high" parameter.
9488         (ada_evaluate_subexp): Update.
9489
9490 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9491
9492         * unittests/string_view-selftests.c: Define
9493         _initialize_string_view_selftests unconditionally.
9494
9495 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9496
9497         PR gdb/24350
9498         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9499
9500 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9501
9502         PR gdb/24351
9503         * windows-nat.c (display_selector): Fix format specifiers.
9504
9505 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9506
9507         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9508         tui_refill_source_window instead of tui_refresh_win, to update the
9509         current execution line.  This fixes redisplay of the current line
9510         when stepping through the code with "next" or "step".
9511
9512 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9513
9514         * source-cache.c (source_cache::get_source_lines): Call
9515         find_source_lines to initialize s->nlines.  This fixes vertical
9516         scrolling of TUI source window when the DOWN arrow is pressed.
9517
9518 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9519
9520         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9521         linux-thread-db.c (_initialize_thread_db): Likewise.
9522
9523 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9524
9525         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9526         wclrtoeol in tui_show_source_line".  This reverts changes made in
9527         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9528
9529 2019-03-15  Tom Tromey  <tom@tromey.com>
9530
9531         * symtab.h (struct minimal_symbol): Derive from
9532         general_symbol_info.
9533         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9534         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9535         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9536         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9537         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9538         (MSYMBOL_SEARCH_NAME): Update.
9539         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9540         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9541         * minsyms.c (minimal_symbol_reader::record_full): Update.
9542
9543 2019-03-15  Tom Tromey  <tom@tromey.com>
9544
9545         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9546
9547 2019-03-15  Tom Tromey  <tom@tromey.com>
9548
9549         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9550         unique_xmalloc_ptr.
9551         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9552         Update.
9553         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9554         (build_minimal_symbol_hash_tables)
9555         (minimal_symbol_reader::install): Update.
9556
9557 2019-03-15  Tom Tromey  <tom@tromey.com>
9558
9559         * symtab.c (create_demangled_names_hash): Update.
9560         (symbol_set_names): Update.
9561         * objfiles.h (struct objfile_per_bfd_storage)
9562         <demangled_names_hash>: Now an htab_up.
9563         * objfiles.c (objfile_per_bfd_storage): Simplify.
9564
9565 2019-03-15  Tom Tromey  <tom@tromey.com>
9566
9567         * objfiles.h (struct objfile_per_bfd_storage): Declare
9568         destructor.
9569         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9570         New.
9571         (get_objfile_bfd_data): Use new.  Don't initialize
9572         language_of_main.
9573         (free_objfile_per_bfd_storage): Remove.
9574         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9575
9576 2019-03-15  Tom Tromey  <tom@tromey.com>
9577
9578         * symfile.c (reread_symbols): Update.
9579         * objfiles.c (objfile::objfile): Update.
9580         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9581         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9582         comment.
9583         (minimal_symbol_reader::install): Update.
9584         (terminate_minimal_symbol_table): Remove.
9585         * jit.c (jit_object_close_impl): Update.
9586
9587 2019-03-15  Tom Tromey  <tom@tromey.com>
9588
9589         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9590         initializations.
9591
9592 2019-03-15  Tom Tromey  <tom@tromey.com>
9593
9594         * objfiles.h (struct objfile_per_bfd_storage)
9595         <demangled_hash_languages>: Now a bitset.
9596         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9597         (lookup_minimal_symbol): Update.
9598
9599 2019-03-15  Tom Tromey  <tom@tromey.com>
9600
9601         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9602         Don't return the symbol.
9603         * coffread.c (record_minimal_symbol): Use record_full.
9604
9605 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9606
9607         The MS-Windows port of ncurses fails to switch to a color pair if
9608         one or both of the colors are the implicit default colors.  This
9609         change records the default colors when TUI is initialized, and
9610         then specifies them explicitly when a color pair uses the default
9611         colors.  This allows color styling in TUI mode on MS-Windows.
9612
9613         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9614         ncurses_norm_attr.
9615         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9616         colors in ncurses_norm_attr.
9617         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9618         "none", replace it with the default color recorded in
9619         ncurses_norm_attr.
9620
9621 2019-03-14  Tom Tromey  <tromey@adacore.com>
9622
9623         * source-cache.h (class source_cache) <get_source_lines>: Return
9624         std::string.
9625         * source-cache.c (source_cache::extract_lines): Handle case where
9626         first_pos==npos.  Return std::string.
9627         (source_cache::get_source_lines): Update.
9628
9629 2019-03-14  Tom Tromey  <tromey@adacore.com>
9630
9631         * NEWS: Add item for "style sources" commands.
9632         * source-cache.c (source_cache::get_source_lines): Check
9633         source_styling.
9634         * cli/cli-style.c (source_styling): New global.
9635         (_initialize_cli_style): Add "style sources" commands.
9636         (show_style_sources): New function.
9637         * cli/cli-style.h (source_styling): Declare.
9638
9639 2019-03-14  Pedro Alves  <palves@redhat.com>
9640             Tom Tromey  <tromey@adacore.com>
9641
9642         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9643         * tui/tui-winsource.c (tui_refill_source_window): New function,
9644         from...
9645         (tui_horizontal_source_scroll): ... here.  Move some logic.
9646         * cli/cli-style.c (set_style_enabled): Notify new observable.
9647         * tui/tui-hooks.c (tui_redisplay_source): New function.
9648         (tui_attach_detach_observers): Attach or detach
9649         tui_redisplay_source.
9650         * observable.h (source_styling_changed): New observable.
9651         * observable.c: Define source_styling_changed observable.
9652
9653 2019-03-13  Tom Tromey  <tromey@adacore.com>
9654
9655         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9656         (i386_gnu_nat_target::store_registers): Update.
9657         * target-debug.h (target_debug_print_std_string): New macro.
9658         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9659         * windows-tdep.c (display_one_tib): Update.
9660         * tui/tui-stack.c (tui_make_status_line): Update.
9661         * top.c (print_inferior_quit_action): Update.
9662         * thread.c (thr_try_catch_cmd): Update.
9663         (add_thread_with_info): Update.
9664         (thread_target_id_str): Update.
9665         (thr_try_catch_cmd): Update.
9666         (thread_command): Update.
9667         (thread_find_command): Update.
9668         * record-btrace.c (record_btrace_target::info_record)
9669         (record_btrace_resume_thread, record_btrace_target::resume)
9670         (record_btrace_cancel_resume, record_btrace_step_thread)
9671         (record_btrace_target::wait, record_btrace_target::wait)
9672         (record_btrace_target::wait, record_btrace_target::stop): Update.
9673         * progspace.c (print_program_space): Update.
9674         * process-stratum-target.c
9675         (process_stratum_target::thread_address_space): Update.
9676         * linux-fork.c (linux_fork_mourn_inferior)
9677         (detach_checkpoint_command, info_checkpoints_command)
9678         (linux_fork_context): Update.
9679         (linux_fork_detach): Update.
9680         (class scoped_switch_fork_info): Update.
9681         (delete_checkpoint_command): Update.
9682         * infrun.c (follow_fork_inferior): Update.
9683         (follow_fork_inferior): Update.
9684         (proceed_after_vfork_done): Update.
9685         (handle_vfork_child_exec_or_exit): Update.
9686         (follow_exec): Update.
9687         (displaced_step_prepare_throw): Update.
9688         (displaced_step_restore): Update.
9689         (start_step_over): Update.
9690         (resume_1): Update.
9691         (clear_proceed_status_thread): Update.
9692         (proceed): Update.
9693         (print_target_wait_results): Update.
9694         (do_target_wait): Update.
9695         (context_switch): Update.
9696         (stop_all_threads): Update.
9697         (restart_threads): Update.
9698         (finish_step_over): Update.
9699         (handle_signal_stop): Update.
9700         (switch_back_to_stepped_thread): Update.
9701         (keep_going_pass_signal): Update.
9702         (print_exited_reason): Update.
9703         (normal_stop): Update.
9704         * inferior.c (inferior_pid_to_str): Change return type.
9705         (print_selected_inferior): Update.
9706         (add_inferior): Update.
9707         (detach_inferior): Update.
9708         * dummy-frame.c (fprint_dummy_frames): Update.
9709         * dcache.c (dcache_info_1): Update.
9710         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9711         (btrace_fetch, btrace_clear): Update.
9712         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9713         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9714         type.
9715         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9716         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9717         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9718         * gdbarch.c, gdbarch.h: Rebuild.
9719         * gdbarch.sh (core_pid_to_str): Change return type.
9720         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9721         return type.
9722         (windows_nat_target::pid_to_str): Change return type.
9723         (windows_delete_thread): Update.
9724         (windows_nat_target::attach): Update.
9725         (windows_nat_target::files_info): Update.
9726         * target-delegates.c: Rebuild.
9727         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9728         return type.
9729         (sol_thread_target::pid_to_str): Change return type.
9730         * remote.c (class remote_target) <pid_to_str>: Change return
9731         type.
9732         (remote_target::pid_to_str): Change return type.
9733         (extended_remote_target::attach, remote_target::remote_stop_ns)
9734         (remote_target::remote_notif_remove_queued_reply)
9735         (remote_target::push_stop_reply, remote_target::disable_btrace):
9736         Update.
9737         (extended_remote_target::attach): Update.
9738         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9739         type.
9740         (gdbsim_target::pid_to_str): Change return type.
9741         * ravenscar-thread.c (struct ravenscar_thread_target)
9742         <pid_to_str>: Change return type.
9743         (ravenscar_thread_target::pid_to_str): Change return type.
9744         * procfs.c (class procfs_target) <pid_to_str>: Change return
9745         type.
9746         (procfs_target::pid_to_str): Change return type.
9747         (procfs_target::attach): Update.
9748         (procfs_target::detach): Update.
9749         (procfs_target::fetch_registers): Update.
9750         (procfs_target::store_registers): Update.
9751         (procfs_target::wait): Update.
9752         (procfs_target::files_info): Update.
9753         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9754         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9755         return type.
9756         (nto_procfs_target::pid_to_str): Change return type.
9757         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9758         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9759         return type.
9760         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9761         (exit_lwp): Update.
9762         (attach_proc_task_lwp_callback, get_detach_signal)
9763         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9764         (linux_nat_target::resume, wait_lwp, stop_callback)
9765         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9766         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9767         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9768         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9769         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9770         type.
9771         (inf_ptrace_target::attach): Update.
9772         (inf_ptrace_target::files_info): Update.
9773         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9774         type.
9775         (go32_nat_target::pid_to_str): Change return type.
9776         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9777         (gnu_nat_target::wait): Update.
9778         (gnu_nat_target::wait): Update.
9779         (gnu_nat_target::resume): Update.
9780         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9781         (fbsd_nat_target::wait): Update.
9782         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9783         type.
9784         (darwin_nat_target::attach): Update.
9785         * corelow.c (class core_target) <pid_to_str>: Change return type.
9786         (core_target::pid_to_str): Change return type.
9787         * target.c (normal_pid_to_str): Change return type.
9788         (default_pid_to_str): Likewise.
9789         (target_pid_to_str): Change return type.
9790         (target_translate_tls_address): Update.
9791         (target_announce_detach): Update.
9792         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9793         return type.
9794         (bsd_uthread_target::pid_to_str): Change return type.
9795         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9796         type.
9797         (bsd_kvm_target::pid_to_str): Change return type.
9798         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9799         return type.
9800         (aix_thread_target::pid_to_str): Change return type.
9801         * target.h (struct target_ops) <pid_to_str>: Change return type.
9802         (target_pid_to_str, normal_pid_to_str): Likewise.
9803         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9804         type.
9805         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9806         type.
9807         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9808         return type.
9809         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9810         type.
9811         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9812         type.
9813         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9814         return type.
9815
9816 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9817
9818         * NEWS: Mention that the new default MI version is 3.  Mention
9819         changes to the output of commands and events that deal with
9820         multi-location breakpoints.
9821         * breakpoint.c: Include "mi/mi-out.h".
9822         (print_one_breakpoint): Change output syntax if using MI version
9823         >= 3.
9824         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9825         New.
9826         (mi_multi_location_breakpoint_output_fixed): New.
9827         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9828         (mi_cmd_fix_multi_location_breakpoint_output): New.
9829         (mi_multi_location_breakpoint_output_fixed): New.
9830         * mi/mi-cmds.c (mi_cmds): Register command
9831         -fix-multi-location-breakpoint-output.
9832         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9833         interpreter "mi".
9834
9835 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9836
9837         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9838         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9839         instantiate mi_ui_out based on interpreter name.
9840         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9841         * mi/mi-main.c (mi_load_progress): Likewise.
9842
9843 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9844
9845         * NEWS: Combine separate "New targets" sections for 8.3.
9846
9847 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9848
9849         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9850         (ppcfbsd_init_abi): Install gdbarch
9851         "fetch_tls_load_module_address" and "get_thread_local_address"
9852         methods.
9853
9854 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9855
9856         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9857         (riscv_fbsd_init_abi): Install gdbarch
9858         "fetch_tls_load_module_address" and "get_thread_local_address"
9859         methods.
9860
9861 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9862
9863         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9864         (i386fbsd_init_abi): Install gdbarch
9865         "fetch_tls_load_module_address" and "get_thread_local_address"
9866         methods.
9867
9868 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9869
9870         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9871         (amd64fbsd_init_abi): Install gdbarch
9872         "fetch_tls_load_module_address" and "get_thread_local_address"
9873         methods.
9874
9875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9876
9877         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9878         (struct fbsd_pspace_data): New type.
9879         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9880         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9881         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9882         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9883         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9884
9885 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9886
9887         * gdbtypes.c (lookup_struct_elt): New function.
9888         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9889         * gdbtypes.h (struct struct_elt): New type.
9890         (lookup_struct_elt): New prototype.
9891
9892 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9893
9894         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9895         remove disabled code block.
9896
9897 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9898
9899         * gdbarch.sh (get_thread_local_address): New method.
9900         * gdbarch.h, gdbarch.c: Regenerate.
9901         * target.c (target_translate_tls_address): Use
9902         gdbarch_get_thread_local_address if present instead of
9903         target::get_thread_local_address.
9904
9905 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9906
9907         * target.h (target::get_thread_local_address): Update comment.
9908
9909 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9910
9911         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9912         objfile->separate_debug_objfile_backlink if not NULL.
9913
9914 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9915
9916         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9917         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9918         (amd64bsd_store_inferior_registers): Likewise.
9919         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9920         Enable segment base registers.
9921         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9922         PT_GETFSBASE and PT_GETGSBASE.
9923         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9924         PT_SETGSBASE.
9925         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9926         segment base registers.
9927         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9928
9929 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9930
9931         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9932         Update calls to i386_target_description to add 'segments'
9933         parameter.
9934         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9935         add segment base registers.
9936         * arch/i386.c (i386_create_target_description): Add 'segments'
9937         parameter to enable segment base registers.
9938         * arch/i386.h (i386_create_target_description): Likewise.
9939         * features/i386/32bit-segments.xml: New file.
9940         * features/i386/32bit-segments.c: Generate.
9941         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9942         call to i386_target_description to add 'segments' parameter.
9943         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9944         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9945         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9946         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9947         if feature is present.
9948         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9949         Add 'segments' parameter to call to i386_target_description.
9950         (i386_target_description): Add 'segments' parameter to enable
9951         segment base registers.
9952         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9953         to call to i386_target_description.
9954         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9955         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9956         Define I386_NUM_REGS.
9957         (i386_target_description): Add 'segments' parameter to enable
9958         segment base registers.
9959
9960 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9961
9962         PR/24325
9963         * source-cache.c: #undef open and close, to avoid unresolved
9964         externals during linking.
9965
9966 2019-03-12  Tom Tromey  <tromey@adacore.com>
9967
9968         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9969         const.  Add initializers.
9970         (_initialize_remote): Don't initialize ptid globals.
9971
9972 2019-03-12  Pedro Alves  <palves@redhat.com>
9973
9974         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9975
9976 2019-03-12  Pedro Alves  <palves@redhat.com>
9977
9978         * cp-name-parser.y (main): Remove unused 'len' variable.
9979
9980 2019-03-12  Tom Tromey  <tromey@adacore.com>
9981
9982         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9983         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9984
9985 2019-03-12  Tom Tromey  <tromey@adacore.com>
9986
9987         * linux-nat.c (iterate_over_lwps): Update.
9988         (stop_callback): Remove parameter.
9989         (stop_wait_callback, detach_callback, resume_set_callback)
9990         (select_singlestep_lwp_callback, set_ignore_sigint)
9991         (status_callback, resumed_callback, resume_clear_callback)
9992         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9993         data parameter.
9994         (linux_nat_target::detach, linux_nat_target::resume)
9995         (linux_stop_and_wait_all_lwps, select_event_lwp)
9996         (linux_nat_filter_event, linux_nat_wait_1)
9997         (linux_nat_target::kill, linux_nat_target::stop)
9998         (linux_nat_target::stop): Update.
9999         (linux_nat_resume_callback): Change type.
10000         (resume_stopped_resumed_lwps, count_events_callback)
10001         (select_event_lwp_callback): Likewise.
10002         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10003         * arm-linux-nat.c (struct update_registers_data): Remove.
10004         (update_registers_callback): Change type.
10005         (arm_linux_insert_hw_breakpoint1): Update.
10006         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10007         parameter.
10008         (x86_linux_dr_set_addr): Update.
10009         (x86_linux_dr_set_control): Update.
10010         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10011         (iterate_over_lwps): Use gdb::function_view.
10012         * nat/aarch64-linux-hw-point.c (struct
10013         aarch64_dr_update_callback_param): Remove.
10014         (debug_reg_change_callback): Change type.
10015         (aarch64_notify_debug_reg_change): Update.
10016         * s390-linux-nat.c (s390_refresh_per_info): Update.
10017
10018 2019-03-11  Tom Tromey  <tromey@adacore.com>
10019
10020         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10021         redundant assignment to "this_cu".
10022
10023 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10024
10025         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10026
10027 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10028
10029         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10030         from...
10031         (rank_one_type): ... this.
10032
10033 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10034
10035         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10036         from...
10037         (rank_one_type): ... this.
10038
10039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10040
10041         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10042         from...
10043         (rank_one_type): ... this.
10044
10045 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10046
10047         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10048         from...
10049         (rank_one_type): ... this.
10050
10051 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10052
10053         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10054         from...
10055         (rank_one_type): ... this.
10056
10057 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10058
10059         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10060         from...
10061         (rank_one_type): ... this.
10062
10063 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10064
10065         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10066         from...
10067         (rank_one_type): ... this.
10068
10069 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10070
10071         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10072         from...
10073         (rank_one_type): ... this.
10074
10075 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10076
10077         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10078         from...
10079         (rank_one_type): ... this.
10080
10081 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10082
10083         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10084         from...
10085         (rank_one_type): ... this.
10086
10087 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10088
10089         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10090         from...
10091         (rank_one_type): ... this.
10092
10093 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10094
10095         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10096         from...
10097         (rank_one_type): ... this.
10098
10099 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10100
10101         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10102         inferior-events' shows the example events.
10103
10104 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10105
10106         Support styling on native MS-Windows console
10107
10108         PR/24315
10109         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10110         on MS-Windows if $TERM is not defined.
10111
10112         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10113
10114         * posix-hdep.c (gdb_console_fputs):
10115         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10116         functions.
10117         * ui-file.h (gdb_console_fputs): Add prototype.
10118
10119         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10120         back to fputs only if the former returns zero.
10121
10122 2019-03-07  Tom Tromey  <tom@tromey.com>
10123
10124         * symmisc.c (print_symbol_bcache_statistics): Update.
10125         (print_objfile_statistics): Update.
10126         * symfile.c (allocate_symtab): Update.
10127         * stabsread.c: Don't include bcache.h.
10128         * psymtab.h (struct psymbol_bcache): Don't declare.
10129         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10130         (psymbol_bcache_init, psymbol_bcache_free)
10131         (psymbol_bcache_get_bcache): Don't declare.
10132         * psymtab.c (struct psymbol_bcache): Remove.
10133         (psymtab_storage::psymtab_storage): Update.
10134         (psymtab_storage::~psymtab_storage): Update.
10135         (psymbol_bcache_init, psymbol_bcache_free)
10136         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10137         (add_psymbol_to_bcache): Update.
10138         (allocate_psymtab): Update.
10139         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10140         macro_cache>: No longer pointers.
10141         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10142         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10143         * macrotab.c (macro_bcache): Update.
10144         * macroexp.c: Don't include bcache.h.
10145         * gdbtypes.c (check_types_worklist): Update.
10146         (types_deeply_equal): Remove TRY/CATCH.  Update.
10147         * elfread.c (elf_symtab_read): Update.
10148         * dwarf2read.c: Don't include bcache.h.
10149         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10150         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10151         (print_bcache_statistics, bcache_memory_used): Don't declare.
10152         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10153         methods.  Rename all data members.
10154         * bcache.c (struct bcache): Move to bcache.h.
10155         (bcache::expand_hash_table): Rename from expand_hash_table.
10156         (bcache): Remove.
10157         (bcache::insert): Rename from bcache_full.
10158         (bcache::compare): Rename from bcache_compare.
10159         (bcache_xmalloc): Remove.
10160         (bcache::~bcache): Rename from bcache_xfree.
10161         (bcache::print_statistics): Rename from print_bcache_statistics.
10162         (bcache::memory_used): Rename from bcache_memory_used.
10163
10164 2019-03-07  Pedro Alves  <palves@redhat.com>
10165
10166         * infrun.c (normal_stop): Also check for
10167         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10168
10169 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10170
10171         * f-lang.c (value_from_host_double): Moved to...
10172         * value.c (value_from_host_double): ...here.
10173         * value.h (value_from_host_double): Declare.
10174         * guile/scm-math.c (vlscm_convert_typed_number): Use
10175         value_from_host_double.
10176         (vlscm_convert_number): Likewise.
10177         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10178         * python/py-value.c (convert_value_from_python): Likewise.
10179
10180 2019-03-06  Tom Tromey  <tom@tromey.com>
10181
10182         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10183
10184 2019-03-06  Tom Tromey  <tom@tromey.com>
10185
10186         * utils.h (free_current_contents): Don't declare.
10187         * utils.c (free_current_contents): Remove.
10188
10189 2019-03-06  Tom Tromey  <tom@tromey.com>
10190
10191         * top.c (quit_force): Update.
10192         * main.c (captured_command_loop): Update.
10193         * common/new-op.c (operator new): Update.
10194         * common/common-exceptions.c (struct catcher)
10195         <save_cleanup_chain>: Remove member.
10196         (exceptions_state_mc_init): Update.
10197         (exception_try_scope_entry): Return nullptr.
10198         (exception_try_scope_exit, exception_rethrow)
10199         (throw_exception_sjlj, throw_exception_cxx): Update.
10200         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10201         (all_cleanups, do_cleanups, discard_cleanups)
10202         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10203         (restore_cleanups, restore_final_cleanups): Don't declare.
10204         (do_final_cleanups): Remove parameter.
10205         * common/cleanups.c (cleanup_chain, make_cleanup)
10206         (make_cleanup_dtor, all_cleanups, do_cleanups)
10207         (discard_my_cleanups, discard_cleanups)
10208         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10209         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10210         (null_cleanup): Remove.
10211         (do_final_cleanups): Remove parameter.
10212
10213 2019-03-06  Tom Tromey  <tom@tromey.com>
10214
10215         * remote.c (remote_target::remote_parse_stop_reply): Use
10216         unique_xmalloc_ptr.
10217
10218 2019-03-06  Tom Tromey  <tom@tromey.com>
10219
10220         * stabsread.c (struct stabs_field_info): Rename from field_info.
10221         <list, fnlist>: Add initializers.
10222         <obstack>: New member.
10223         (read_member_functions, read_struct_fields, read_baseclasses):
10224         Allocate on obstack.  Don't use cleanups.
10225         (read_one_struct_field, read_member_functions, read_struct_fields)
10226         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10227         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10228         (read_struct_type): Update.
10229
10230 2019-03-06  Tom Tromey  <tom@tromey.com>
10231
10232         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10233         * common/filestuff.h (make_cleanup_close): Don't declare.
10234         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10235         Remove.
10236
10237 2019-03-06  Tom Tromey  <tom@tromey.com>
10238
10239         * solib-aix.c: Use make_scope_exit.
10240
10241 2019-03-06  Tom Tromey  <tom@tromey.com>
10242
10243         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10244         Use make_scope_exit.
10245
10246 2019-03-06  Tom Tromey  <tom@tromey.com>
10247
10248         * solib-svr4.c (disable_probes_interface): Remove parameter.
10249         (svr4_handle_solib_event): Use make_scope_exit.
10250
10251 2019-03-06  Tom Tromey  <tom@tromey.com>
10252
10253         * remote.c (struct stop_reply_deleter): Remove.
10254         (stop_reply_up): Update.
10255         (struct stop_reply): Derive from notif_event.  Don't typedef.
10256         <regcache>: Now a std::vector.
10257         (stop_reply_xfree): Remove.
10258         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10259         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10260         (remote_target::discard_pending_stop_replies): Use delete.
10261         (remote_target::remote_parse_stop_reply): Update.
10262         (remote_target::process_stop_reply): Update.
10263         * remote-notif.h (struct notif_event): Add virtual destructor.
10264         Remove "dtr" member.
10265         (struct notif_client) <alloc_event>: Return a unique_ptr.
10266         (notif_event_xfree): Don't declare.
10267         (notif_event_up): New typedef.
10268         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10269         (notif_event_xfree, do_notif_event_xfree): Remove.
10270         (remote_notif_state_xfree): Update.
10271
10272 2019-03-06  Tom Tromey  <tom@tromey.com>
10273
10274         * infrun.c (displaced_step_clear_cleanup): Now a
10275         forward_scope_exit type.
10276         (displaced_step_prepare_throw): Update.
10277         (displaced_step_fixup): Update.
10278
10279 2019-03-06  Tom Tromey  <tom@tromey.com>
10280
10281         * inferior.h (class inferior): Update comment.
10282         * gdbthread.h (class thread_info): Update comment.
10283
10284 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10285             Tom Tromey  <tom@tromey.com>
10286
10287         * stabsread.h (struct stab_section_list): Remove.
10288         (coffstab_build_psymtabs): Update.
10289         * dbxread.c (symbuf_sections): Now a std::vector.
10290         (sect_idx): New global.
10291         (fill_symbuf): Update.
10292         (coffstab_build_psymtabs): Change type of stabsects parameter.
10293         Update.
10294         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10295         std::vector.
10296         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10297         (coff_locate_sections): Update.
10298         (coff_symfile_read): Remove cleanups.  Update.
10299         (init_stringtab): Add storage parameter.
10300         (free_stringtab, free_stringtab_cleanup): Remove.
10301         (init_lineno): Add storage parameter.
10302         (free_linetab, free_linetab_cleanup): Remove.
10303
10304 2019-03-06  Pedro Alves  <palves@redhat.com>
10305
10306         * linux-fork.c (fork_info::clobber_regs): Delete.
10307         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10308         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10309         comment.  Adjust.
10310         (scoped_switch_fork_info::scoped_switch_fork_info)
10311         (checkpoint_command, linux_fork_context): Adjust
10312         fork_save_infrun_state calls.
10313
10314 2019-03-06  Pedro Alves  <palves@redhat.com>
10315
10316         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10317         (inf_has_multiple_threads): Return 'bool' and rewrite using
10318         inferior_info::threads().
10319
10320 2019-03-06  Pedro Alves  <palves@redhat.com>
10321
10322         * linux-fork.c: Include <list>.
10323         (fork_list): Now a std::list instance.
10324         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10325         (forks_exist_p, find_last_fork): Adjust.
10326         (new_fork): Delete.
10327         (one_fork_p): New.
10328         (add_fork): Adjust.
10329         (free_fork): Delete, folded into fork_info::~fork_info().
10330         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10331         Adjust.
10332         (init_fork_list): Delete.
10333         (linux_fork_killall, linux_fork_mourn_inferior)
10334         (linux_fork_detach, info_checkpoints_command): Adjust.
10335         (_initialize_linux_fork): No longer call init_fork_list.
10336
10337 2019-03-06  Pedro Alves  <palves@redhat.com>
10338
10339         * linux-fork.c (new_fork): New, split out of ...
10340         (add_fork): ... this.  Return void.  Move "first fork" special
10341         case from here, to ...
10342         (checkpoint_command): ... here.
10343         * linux-linux.h (add_fork): Return void.
10344
10345 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10346
10347         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10348
10349 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10350             Chris January  <chris.january@arm.com>
10351             David Lecomber  <david.lecomber@arm.com>
10352
10353         * f-exp.y: New token, UNOP_INTRINSIC.
10354         (exp): New pattern using UNOP_INTRINSIC token.
10355         (f77_keywords): Add 'abs' keyword.
10356         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10357         (value_from_host_double): New function.
10358         (evaluate_subexp_f): Support UNOP_ABS.
10359
10360 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10361
10362         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10363         types.
10364
10365 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10366
10367         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10368         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10369         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10370
10371 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10372
10373         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10374
10375 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10376             Chris January  <chris.january@arm.com>
10377
10378         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10379         * f-exp.y: Define 'KIND' token.
10380         (exp): New pattern for KIND expressions.
10381         (ptype): Handle types with a kind extension.
10382         (direct_abs_decl): Extend to spot kind extensions.
10383         (f77_keywords): Add 'kind' to the list.
10384         (push_kind_type): New function.
10385         (convert_to_kind_type): New function.
10386         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10387         * parse.c (operator_length_standard): Likewise.
10388         * parser-defs.h (enum type_pieces): Add tp_kind.
10389         * std-operator.def: Add UNOP_KIND.
10390
10391 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10392
10393         * f-exp.y (f_parse): Set yydebug.
10394
10395 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10396
10397         * f-lang.c (evaluate_subexp_f): New function.
10398         (exp_descriptor_f): New global.
10399         (f_language_defn): Use exp_descriptor_f instead of
10400         exp_descriptor_standard.
10401
10402 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10403
10404         * f-exp.y (struct token): Add comments.
10405         (dot_ops): Remove uppercase versions and the end marker.
10406         (f77_keywords): Likewise.
10407         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10408         entries in the dot_ops array are case insensitive, and use
10409         strncasecmp to compare strings.  Also some whitespace cleanup in
10410         this area.  Similar for the f77_keywords array, except entries in
10411         this list might be case sensitive.
10412
10413 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10414
10415         * f-exp.y (struct f77_boolean_val): Add comments.
10416         (boolean_values): Remove uppercase versions, and end marker.
10417         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10418         and use strncasecmp to achieve case insensitivity.  Additionally,
10419         perform whitespace cleanup around this code.
10420
10421 2019-03-06  Tom Tromey  <tromey@adacore.com>
10422
10423         * remote-sim.c (gdbsim_target_open): Use result of
10424         gdb_argv::release.
10425
10426 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10427         Dirk Schubert  <dirk.schubert@arm.com>
10428         Chris January  <chris.january@arm.com>
10429
10430         * eval.c (evaluate_subexp_standard): Call Fortran argument
10431         wrapping logic.
10432         * f-lang.c (struct value): A value which can be passed into a
10433         Fortran function call.
10434         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10435         where appropriate.
10436         (struct type): Value ready for a Fortran function call.
10437         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10438         is needed.
10439         * f-lang.h (fortran_argument_convert): Declaration.
10440         (fortran_preserve_arg_pointer): Declaration.
10441         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10442
10443 2019-03-05  Tom Tromey  <tromey@adacore.com>
10444
10445         * python/py-prettyprint.c (print_string_repr): Remove #if.
10446         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10447
10448 2019-03-05  Tom Tromey  <tromey@adacore.com>
10449
10450         * target.c (the_dummy_target): Move later.  Change type to
10451         "dummy_target".
10452         (initialize_targets): Don't initialize the_dummy_target.
10453
10454 2019-03-05  Tom Tromey  <tromey@adacore.com>
10455
10456         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10457         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10458
10459 2019-03-05  Tom Tromey  <tromey@adacore.com>
10460
10461         * windows-nat.c (windows_nat_target::attach)
10462         (windows_nat_target::detach): Don't call gdb_flush.
10463         * valprint.c (generic_val_print, val_print, val_print_string):
10464         Don't call gdb_flush.
10465         * utils.c (defaulted_query): Don't call gdb_flush.
10466         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10467         * target.c (target_announce_detach): Don't call gdb_flush.
10468         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10469         * remote.c (extended_remote_target::attach): Don't call
10470         gdb_flush.
10471         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10472         * printcmd.c (do_examine): Don't call gdb_flush.
10473         (info_display_command): Don't call gdb_flush.
10474         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10475         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10476         * memattr.c (info_mem_command): Don't call gdb_flush.
10477         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10478         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10479         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10480         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10481         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10482         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10483         (gnu_nat_target::detach): Don't call gdb_flush.
10484         * f-valprint.c (f_val_print): Don't call gdb_flush.
10485         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10486         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10487         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10488         gdb_flush.
10489         * c-valprint.c (c_val_print): Don't call gdb_flush.
10490         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10491
10492 2019-03-05  Tom Tromey  <tromey@adacore.com>
10493
10494         * varobj.c (update_dynamic_varobj_children): Update.
10495         (install_default_visualizer): Use reset, not release.
10496         * value.c (set_internalvar): Update.
10497         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10498         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10499         ATTRIBUTE_UNUSED_RESULT.
10500
10501 2019-03-05  Tom Tromey  <tromey@adacore.com>
10502
10503         * remote.c (class scoped_remote_fd) <release>: Add
10504         ATTRIBUTE_UNUSED_RESULT.
10505
10506 2019-03-05  Tom Tromey  <tromey@adacore.com>
10507
10508         * macroexp.c (struct macro_buffer) <release>: Add
10509         ATTRIBUTE_UNUSED_RESULT.
10510
10511 2019-03-05  Tom Tromey  <tromey@adacore.com>
10512
10513         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10514         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10515         ATTRIBUTE_UNUSED_RESULT.
10516
10517 2019-03-05  Tom Tromey  <tromey@adacore.com>
10518
10519         * common/scoped_fd.h (class scoped_fd) <release>: Add
10520         ATTRIBUTE_UNUSED_RESULT.
10521
10522 2019-03-05  Tom Tromey  <tromey@adacore.com>
10523
10524         * parser-defs.h (struct parser_state) <release>: Add
10525         ATTRIBUTE_UNUSED_RESULT.
10526
10527 2019-03-05  Tom Tromey  <tromey@adacore.com>
10528
10529         * utils.h (class gdb_argv) <release>: Add
10530         ATTRIBUTE_UNUSED_RESULT.
10531         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10532
10533 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10534
10535         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10536         for-loop range, to avoid compiler warnings.
10537
10538         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10539         avoid compiler warnings about unused variables.
10540
10541         * NEWS: Mention end of support for native debugging on MS-Windows
10542         before XP.
10543
10544         PR gdb/24292
10545         * common/netstuff.c:
10546         * gdbserver/gdbreplay.c
10547         * gdbserver/remote-utils.c:
10548         * ser-tcp.c:
10549         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10550         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10551         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10552         'getaddrinfo' and 'freeaddrinfo' were not available before
10553         Windows XP, and mingw.org's MinGW headers by default define
10554         _WIN32_WINNT to 0x500.
10555
10556 2019-03-01  Gary Benson <gbenson@redhat.com>
10557
10558         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10559
10560 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10561             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10562
10563         PR gdb/8527
10564         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10565         set_sigint_trap, clear_sigint_trap.
10566
10567 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10568
10569         * target.c (target_detach): Clear the regcache and the
10570         frame cache.
10571
10572 2019-02-27  Pedro Alves  <palves@redhat.com>
10573
10574         * utils.c (set_screen_size): When we cap the height/width sizes,
10575         tweak the corresponding command variable to show "unlimited":
10576
10577 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10578             Pedro Alves  <palves@redhat.com>
10579
10580         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10581         before calling rl_set_screen_size.
10582
10583 2019-02-27  Tom Tromey  <tromey@adacore.com>
10584
10585         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10586         define.
10587         * python/py-value.c: Remove Python 2.4 workaround.
10588         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10589         workaround.
10590         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10591         Python 2.4 workaround.
10592         * python/python-internal.h: Remove Python 2.4 comment.
10593         (Py_ssize_t): Don't define.
10594         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10595         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10596         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10597         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10598         * python/python.c (do_start_initialization): Remove Python 2.4
10599         workaround.
10600         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10601         (print_children): Remove Python 2.4 workaround.
10602         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10603         workaround.
10604         (CHARBUFFERPROC_NAME): Remove.
10605         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10606         Python 2.4 workaround.
10607
10608 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10609
10610         * NEWS: Note minimum Python version.
10611
10612 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10613
10614         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10615         code from these functions.  Remove corresponding ifdefs.  Use
10616         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10617         Remove gotos and target of gotos.
10618         (infpy_search_memory): Likewise.
10619
10620 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10621
10622         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10623         (hppa_gdbarch_init): Don't register deleted functions with
10624         gdbarch.
10625
10626 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10627
10628         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10629         (h8300_unwind_sp): Delete.
10630         (h8300_dummy_id): Delete.
10631         (h8300_gdbarch_init): Don't register deleted functions with
10632         gdbarch.
10633
10634 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10635
10636         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10637         (ft32_unwind_pc): Delete.
10638         (ft32_unwind_sp): Delete.
10639         (ft32_gdbarch_init): Don't register deleted functions with
10640         gdbarch.
10641
10642 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10643
10644         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10645         (frv_unwind_pc): Delete.
10646         (frv_unwind_sp): Delete.
10647         (frv_gdbarch_init): Don't register deleted functions with
10648         gdbarch.
10649
10650 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10651
10652         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10653         (riscv_unwind_pc): Delete.
10654         (riscv_unwind_sp): Delete.
10655         (riscv_gdbarch_init): Don't register deleted functions with
10656         gdbarch.
10657
10658 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10659
10660         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10661         (csky_unwind_pc): Delete.
10662         (csky_unwind_sp): Delete.
10663         (csky_gdbarch_init): Don't register deleted functions with
10664         gdbarch.
10665
10666 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10667
10668         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10669         (cris_unwind_pc): Delete.
10670         (cris_unwind_sp): Delete.
10671         (cris_gdbarch_init): Don't register deleted functions with
10672         gdbarch.
10673
10674 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10675
10676         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10677         (bfin_unwind_pc): Delete.
10678         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10679
10680 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10681
10682         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10683         (arm_unwind_pc): Delete.
10684         (arm_unwind_sp): Delete.
10685         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10686
10687 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10688
10689         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10690         (arc_unwind_pc): Delete.
10691         (arc_unwind_sp): Delete.
10692         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10693
10694 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10695
10696         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10697         (alpha_unwind_pc): Delete.
10698         (alpha_gdbarch_init): Don't register deleted functions with
10699         gdbarch.
10700
10701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10702
10703         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10704         (aarch64_unwind_pc): Delete.
10705         (aarch64_unwind_sp): Delete.
10706         (aarch64_gdbarch_init): Don't register deleted functions with
10707         gdbarch.
10708
10709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10710
10711         * gdbtypes.c (type_align): Don't consider static members when
10712         computing structure alignment.
10713
10714 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10715
10716         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10717         return 0 for other types.
10718         * arch-utils.c (default_type_align): Always return 0.
10719         * gdbarch.h: Regenerate.
10720         * gdbarch.sh (type_align): Extend comment.
10721         * gdbtypes.c (type_align): Add additional comments, always call
10722         gdbarch_type_align before applying the default rules.
10723         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10724         generic code will then apply a suitable default.
10725         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10726         types, return 0 for other types.
10727
10728 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10729
10730         * NEWS: Create a new section for the next release branch.
10731         Rename the section of the current branch, now that it has
10732         been cut.
10733
10734 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10735
10736         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10737         * version.in: Bump version to 8.3.50.DATE-git.
10738
10739 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10740
10741         * aix-thread.c (ptid_cmp): Remove unused variable.
10742         (get_signaled_thread): Likewise.
10743         (store_regs_user_thread): Likewise.
10744         (store_regs_kernel_thread): Likewise.
10745         (fetch_regs_kernel_thread): Remove shadowed variable.
10746
10747 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10748
10749         * features/riscv/32bit-cpu.xml: Add register numbers.
10750         * features/riscv/32bit-fpu.c: Regenerate.
10751         * features/riscv/32bit-fpu.xml: Add register numbers.
10752         * features/riscv/64bit-cpu.xml: Add register numbers.
10753         * features/riscv/64bit-fpu.c: Regenerate.
10754         * features/riscv/64bit-fpu.xml: Add register numbers.
10755
10756 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10757
10758         * NEWS: Mention two argument form of gdb.Value constructor.
10759         * python/py-value.c (convert_buffer_and_type_to_value): New
10760         function.
10761         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10762         Add support for handling an optional second argument.  Call
10763         convert_buffer_and_type_to_value as appropriate.
10764         * python/python-internal.h (Py_buffer_deleter): New struct.
10765         (Py_buffer_up): New typedef.
10766
10767 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10768
10769         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10770         instead of releasing ownership.
10771
10772 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10773
10774         * dwarf2read.c (open_and_init_dwp_file): Call
10775         elf_numsections instead of bfd_count_sections to initialize
10776         dwp_file->num_sections.
10777
10778 2019-02-25  Tom Tromey  <tromey@adacore.com>
10779
10780         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10781
10782 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10783
10784         * gcore.in: Add '--readnever' option when invoking GDB.
10785
10786 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10787
10788         * MAINTAINERS: Update my email address.
10789
10790 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10791
10792         * build-id.c (build_id_to_debug_bfd_1): New function.
10793         (build_id_to_debug_bfd): Look for separate debug file in
10794         sysroot.
10795
10796 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10797
10798         * gdbarch.sh: Update the copyright year range that is placed into
10799         generated files.
10800
10801 2019-02-22  Keith Seitz  <keiths@redhat.com>
10802
10803         PR symtab/23853
10804         * linespec.c (create_sals_line_offset): Search for the default
10805         symtab's filename instead of its fullname.
10806
10807 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10808
10809         * NEWS: Update style defaults.
10810
10811 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10812
10813         * main.c (captured_main_1): Disable styling in batch mode.
10814
10815 2019-02-20  Tom Tromey  <tom@tromey.com>
10816
10817         * symtab.c (symtab_symbol_info): Fix typos.
10818
10819 2019-02-20  Tom Tromey  <tromey@adacore.com>
10820
10821         * findcmd.c (_initialize_mem_search): Use upper case for
10822         metasyntactic variables.
10823
10824 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10825
10826         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10827         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10828
10829 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10830
10831         * top.h (source_file_name): Change to std::string.
10832         * top.c (source_file_name): Likewise.
10833         (command_line_input): Adjust.
10834         * cli/cli-script.c (script_from_file): Adjust.
10835
10836 2019-02-19  Tom Tromey  <tromey@adacore.com>
10837
10838         * ravenscar-thread.c
10839         (ravenscar_thread_target::update_thread_list): Don't call
10840         ada_build_task_list.
10841         * ada-lang.h (ada_build_task_list): Don't declare.
10842         * ada-tasks.c (struct ada_tasks_inferior_data)
10843         <task_list_valid_p>: Now bool.
10844         (read_known_tasks, ada_task_list_changed)
10845         (ada_tasks_invalidate_inferior_data): Update.
10846         (read_known_tasks_array): Return bool.
10847         (read_known_tasks_list): Likewise.
10848         (read_known_tasks): Return void.
10849         (ada_build_task_list): Now static.
10850
10851 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10852
10853         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10854         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10855
10856 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10857
10858         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10859         variant for ada_tasks_pspace_data_handle and
10860         ada_tasks_inferior_data_handle.
10861         (ada_tasks_pspace_data_cleanup): New function.
10862         (ada_tasks_inferior_data_cleanup): New function.
10863
10864 2019-02-17  Tom Tromey  <tom@tromey.com>
10865
10866         * macrotab.h (macro_source_fullname): Return a std::string.
10867         * macrotab.c (macro_include, check_for_redefinition)
10868         (macro_undef, macro_lookup_definition, foreach_macro)
10869         (foreach_macro_in_scope): Update.
10870         (macro_source_fullname): Return a std::string.
10871         * macrocmd.c (show_pp_source_pos): Update.
10872
10873 2019-02-17  Tom Tromey  <tom@tromey.com>
10874
10875         * macrocmd.c (show_pp_source_pos): Style the file names.
10876
10877 2019-02-17  Tom Tromey  <tom@tromey.com>
10878
10879         PR tui/24197:
10880         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10881
10882 2019-02-17  Tom Tromey  <tom@tromey.com>
10883
10884         * ada-lang.c (user_select_syms): Use filtered printing.
10885         * utils.c (wrap_style): New global.
10886         (desired_style): Remove.
10887         (emit_style_escape): Add stream parameter.
10888         (set_output_style, reset_terminal_style, prompt_for_continue):
10889         Update.
10890         (flush_wrap_buffer): Only flush gdb_stdout.
10891         (wrap_here): Set wrap_style.
10892         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10893         treat escape sequences as a character.  Change when wrap buffer is
10894         flushed.
10895         (fputs_styled): Do not set the output style when the default is
10896         requested.
10897         * ui-style.h (struct ui_file_style) <is_default>: New method.
10898         * source.c (print_source_lines_base): Emit escape sequences in one
10899         piece.
10900
10901 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10902
10903         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10904         integers and enumeration types.
10905
10906 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10907
10908         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10909         instead of lookup_symbol_in_language
10910         (do_exact_match): New function.
10911         (ada_get_symbol_name_matcher): Return do_exact_match when
10912         doing a verbatim match.
10913
10914 2019-02-15  Tom Tromey  <tromey@adacore.com>
10915
10916         * ravenscar-thread.c (ravenscar_thread_target::resume)
10917         (ravenscar_thread_target::wait): Special case wildcard requests.
10918
10919 2019-02-15  Tom Tromey  <tromey@adacore.com>
10920
10921         * ravenscar-thread.c (base_ptid): Remove.
10922         (struct ravenscar_thread_target) <close>: New method.
10923         <m_base_ptid>: New member.
10924         <update_inferior_ptid, active_task, task_is_currently_active,
10925         runtime_initialized>: Declare methods.
10926         <ravenscar_thread_target>: Add constructor.
10927         (ravenscar_thread_target::task_is_currently_active)
10928         (ravenscar_thread_target::update_inferior_ptid)
10929         (ravenscar_runtime_initialized): Rename.  Now methods.
10930         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10931         (ravenscar_thread_target::update_thread_list): Update.
10932         (ravenscar_thread_target::active_task): Now method.
10933         (ravenscar_thread_target::store_registers)
10934         (ravenscar_thread_target::prepare_to_store)
10935         (ravenscar_thread_target::prepare_to_store)
10936         (ravenscar_thread_target::mourn_inferior): Update.
10937         (ravenscar_inferior_created): Use "new" to create target.
10938         (ravenscar_thread_target::get_ada_task_ptid): Update.
10939         (_initialize_ravenscar): Don't initialize base_ptid.
10940         (ravenscar_ops): Remove global.
10941
10942 2019-02-15  Tom Tromey  <tromey@adacore.com>
10943
10944         * target.h (push_target): Declare new overload.
10945         * target.c (push_target): New overload, taking an rvalue reference.
10946         * remote.c (remote_target::open_1): Use push_target overload.
10947         * corelow.c (core_target_open): Use push_target overload.
10948
10949 2019-02-15  Tom Tromey  <tromey@adacore.com>
10950
10951         * ravenscar-thread.c (is_ravenscar_task)
10952         (ravenscar_task_is_currently_active): Return bool.
10953         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10954         (_initialize_ravenscar): Remove "(void)".
10955         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10956         Return bool.
10957
10958 2019-02-15  Tom Tromey  <tromey@adacore.com>
10959
10960         * ravenscar-thread.c (ravenscar_runtime_initializer)
10961         (has_ravenscar_runtime, get_running_thread_id)
10962         (ravenscar_thread_target::resume): Fix indentation.
10963
10964 2019-02-15  Tom Tromey  <tromey@adacore.com>
10965
10966         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10967         from ravenscar_arch_ops.
10968         (sparc_ravenscar_ops::fetch_registers)
10969         (sparc_ravenscar_ops::store_registers): Now methods.
10970         (sparc_ravenscar_prepare_to_store): Remove.
10971         (sparc_ravenscar_ops): Redefine.
10972         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10973         methods and destructor.  Remove members.
10974         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10975         (ravenscar_thread_target::store_registers)
10976         (ravenscar_thread_target::prepare_to_store): Update.
10977         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10978         Remove.
10979         (struct ppc_ravenscar_powerpc_ops): Derive from
10980         ravenscar_arch_ops.
10981         (ppc_ravenscar_powerpc_ops::fetch_registers)
10982         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10983         (ppc_ravenscar_powerpc_ops): Redefine.
10984         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10985         (ppc_ravenscar_e500_ops::fetch_registers)
10986         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10987         (ppc_ravenscar_e500_ops): Redefine.
10988         * aarch64-ravenscar-thread.c
10989         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10990         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10991         (aarch64_ravenscar_fetch_registers)
10992         (aarch64_ravenscar_store_registers): Now methods.
10993         (aarch64_ravenscar_ops): Redefine.
10994
10995 2019-02-15  Tom Tromey  <tromey@adacore.com>
10996
10997         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10998         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10999         (ravenscar_thread_target::stopped_by_watchpoint)
11000         (ravenscar_thread_target::stopped_data_address)
11001         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11002
11003 2019-02-15  Tom Tromey  <tromey@adacore.com>
11004
11005         * ravenscar-thread.c: Fix some typos.
11006
11007 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11008             Tom Tromey  <tromey@adacore.com>
11009
11010         * ada-lang.c (ada_exception_sal): Change addr_string to a
11011         std::string.
11012         (create_ada_exception_catchpoint): Update.
11013
11014 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11015             Tom Tromey  <tromey@adacore.com>
11016
11017         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11018         (bp_location_ops): Remove.
11019         (base_breakpoint_allocate_location): Update.
11020         (free_bp_location): Update.
11021         * ada-lang.c (class ada_catchpoint_location)
11022         <ada_catchpoint_location>: Remove ops parameter.
11023         (ada_catchpoint_location_dtor): Remove.
11024         (ada_catchpoint_location_ops): Remove.
11025         (allocate_location_exception): Update.
11026         * breakpoint.h (struct bp_location_ops): Remove.
11027         (class bp_location) <bp_location>: Remove bp_location_ops
11028         parameter.
11029         <~bp_location>: Add destructor.
11030         <ops>: Remove.
11031
11032 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11033             Pedro Alves  <palves@redhat.com>
11034
11035         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11036         'PATH_MAX'.
11037
11038 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11039             Samuel Thibault  <samuel.thibault@gnu.org>
11040             Thomas Schwinge  <thomas@codesourcery.com>
11041
11042         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11043         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11044
11045 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11046
11047         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11048         (check_empty): Use "const char *".
11049
11050         * gnu-nat.c (gnu_nat_target::detach): Instead of
11051         'detach_inferior (pid)' call
11052         'detach_inferior (find_inferior_pid (pid))'.
11053
11054         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11055         'nat/fork-inferior.o'.
11056         * gnu-nat.c: #include "nat/fork-inferior.h".
11057
11058         * gnu-nat.c (gnu_nat_target::detach): Instead of
11059         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11060         * gnu-nat.h: #include "inf-child.h".
11061         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11062         'i386_gnu_nat_target::fetch_registers'.
11063         (gnu_store_registers): Rename/move to
11064         'i386_gnu_nat_target::store_registers'.
11065
11066         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11067         * gnu-nat.h (mach_thread_info): New function.
11068         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11069
11070         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11071
11072 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11073
11074         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11075
11076 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11077
11078         * windows-nat.c (windows_add_thread): Add new parameter
11079         "main_thread_p" with default value set to false.  Update
11080         function documentation as well as all callers.
11081         (windows_delete_thread): Likewise.
11082         (fake_create_process): Update call to windows_add_thread.
11083         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11084         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11085         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11086         call to windows_delete_thread.
11087
11088 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11089
11090         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11091
11092 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11093
11094         * symfile.c (find_separate_debug_file): Use canonical path of
11095         sysroot with child_path instead of gdb_sysroot if it is valid.
11096
11097 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11098
11099         * symfile.c (find_separate_debug_file): Use child_path to
11100         determine if an object file is under a sysroot.
11101
11102 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11103
11104         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11105         unittests/child-path-selftests.c.
11106         * common/pathstuff.c (child_path): New function.
11107         * common/pathstuff.h (child_path): New prototype.
11108         * unittests/child-path-selftests.c: New file.
11109
11110 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11111
11112         * symfile.c (find_separate_debug_file): Look for separate debug
11113         files in debug directories under the sysroot.
11114
11115 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11116
11117         * symtab.h (struct minimal_symbol data_p): New const method.
11118         (struct minimal_symbol text_p): Likewise.
11119         * symtab.c (output_source_filename): Use file name style
11120         to print file name.
11121         (print_symbol_info): Likewise.
11122         (print_msymbol_info): Use address style to print addresses.
11123         Use function name style to print executable text symbols.
11124         (expand_symtab_containing_pc): Use data_p.
11125         (find_pc_sect_compunit_symtab): Likewise.
11126
11127 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11128
11129         * breakpoint.c (describe_other_breakpoints): Use address style
11130         to print addresses.
11131         (say_where): Likewise.
11132
11133 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11134
11135         * ada-typeprint.c (print_func_type): Print function name
11136         style to print function name.
11137         * c-typeprint.c (c_print_type_1): Likewise.
11138
11139 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11140
11141         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11142         for execve.
11143
11144 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11145
11146         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11147         type_stack.
11148
11149 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11150
11151         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11152         TYPE_CODE_REF types.
11153
11154 2019-02-08  Jim Wilson  <jimw@sifive.com>
11155
11156         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11157         (riscv_linux_fregset): New.
11158         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11159
11160 2019-02-07  Tom Tromey  <tom@tromey.com>
11161
11162         * thread.c (thread_cancel_execution_command): Update.
11163         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11164         methods.
11165         (struct thread_fsm_ops): Remove.
11166         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11167         (thread_fsm_should_stop, thread_fsm_return_value)
11168         (thread_fsm_set_finished, thread_fsm_finished_p)
11169         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11170         Don't declare.
11171         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11172         * infrun.c (clear_proceed_status_thread)
11173         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11174         (print_stop_event): Update.
11175         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11176         Add constructor.
11177         (step_command_fsm_ops): Remove.
11178         (new_step_command_fsm): Remove.
11179         (step_1): Update.
11180         (step_command_fsm::should_stop): Rename from
11181         step_command_fsm_should_stop.
11182         (step_command_fsm::clean_up): Rename from
11183         step_command_fsm_clean_up.
11184         (step_command_fsm::do_async_reply_reason): Rename from
11185         step_command_fsm_async_reply_reason.
11186         (struct until_next_fsm): Inherit from thread_fsm.  Add
11187         constructor.
11188         (until_next_fsm_ops): Remove.
11189         (new_until_next_fsm): Remove.
11190         (until_next_fsm::should_stop): Rename from
11191         until_next_fsm_should_stop.
11192         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11193         (until_next_fsm::do_async_reply_reason): Rename from
11194         until_next_fsm_async_reply_reason.
11195         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11196         constructor.  Change type of breakpoint.
11197         (finish_command_fsm_ops): Remove.
11198         (new_finish_command_fsm): Remove.
11199         (finish_command_fsm::should_stop): Rename from
11200         finish_command_fsm_should_stop.
11201         (finish_command_fsm::clean_up): Rename from
11202         finish_command_fsm_clean_up.
11203         (finish_command_fsm::return_value): Rename from
11204         finish_command_fsm_return_value.
11205         (finish_command_fsm::do_async_reply_reason): Rename from
11206         finish_command_fsm_async_reply_reason.
11207         (finish_command): Update.
11208         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11209         Add constructor.
11210         (call_thread_fsm_ops): Remove.
11211         (call_thread_fsm::call_thread_fsm): Rename from
11212         new_call_thread_fsm.
11213         (call_thread_fsm::should_stop): Rename from
11214         call_thread_fsm_should_stop.
11215         (call_thread_fsm::should_notify_stop): Rename from
11216         call_thread_fsm_should_notify_stop.
11217         (run_inferior_call, call_function_by_hand_dummy): Update.
11218         * cli/cli-interp.c (should_print_stop_to_console): Update.
11219         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11220         Add constructor.  Change type of location_breakpoint,
11221         caller_breakpoint.
11222         (until_break_fsm_ops): Remove.
11223         (new_until_break_fsm): Remove.
11224         (until_break_fsm::should_stop): Rename from
11225         until_break_fsm_should_stop.
11226         (until_break_fsm::clean_up): Rename from
11227         until_break_fsm_clean_up.
11228         (until_break_fsm::do_async_reply_reason): Rename from
11229         until_break_fsm_async_reply_reason.
11230         (until_break_command): Update.
11231         * thread-fsm.c: Remove.
11232         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11233
11234 2019-02-07  Tom Tromey  <tom@tromey.com>
11235
11236         * yy-remap.h: Add include guard.
11237         * xtensa-tdep.h: Add include guard.
11238         * xcoffread.h: Rename include guard.
11239         * varobj-iter.h: Add include guard.
11240         * tui/tui.h: Rename include guard.
11241         * tui/tui-winsource.h: Rename include guard.
11242         * tui/tui-wingeneral.h: Rename include guard.
11243         * tui/tui-windata.h: Rename include guard.
11244         * tui/tui-win.h: Rename include guard.
11245         * tui/tui-stack.h: Rename include guard.
11246         * tui/tui-source.h: Rename include guard.
11247         * tui/tui-regs.h: Rename include guard.
11248         * tui/tui-out.h: Rename include guard.
11249         * tui/tui-layout.h: Rename include guard.
11250         * tui/tui-io.h: Rename include guard.
11251         * tui/tui-hooks.h: Rename include guard.
11252         * tui/tui-file.h: Rename include guard.
11253         * tui/tui-disasm.h: Rename include guard.
11254         * tui/tui-data.h: Rename include guard.
11255         * tui/tui-command.h: Rename include guard.
11256         * tic6x-tdep.h: Add include guard.
11257         * target/waitstatus.h: Rename include guard.
11258         * target/wait.h: Rename include guard.
11259         * target/target.h: Rename include guard.
11260         * target/resume.h: Rename include guard.
11261         * target-float.h: Rename include guard.
11262         * stabsread.h: Add include guard.
11263         * rs6000-tdep.h: Add include guard.
11264         * riscv-fbsd-tdep.h: Add include guard.
11265         * regformats/regdef.h: Rename include guard.
11266         * record.h: Rename include guard.
11267         * python/python.h: Rename include guard.
11268         * python/python-internal.h: Rename include guard.
11269         * python/py-stopevent.h: Rename include guard.
11270         * python/py-ref.h: Rename include guard.
11271         * python/py-record.h: Rename include guard.
11272         * python/py-record-full.h: Rename include guard.
11273         * python/py-record-btrace.h: Rename include guard.
11274         * python/py-instruction.h: Rename include guard.
11275         * python/py-events.h: Rename include guard.
11276         * python/py-event.h: Rename include guard.
11277         * procfs.h: Add include guard.
11278         * proc-utils.h: Add include guard.
11279         * p-lang.h: Add include guard.
11280         * or1k-tdep.h: Rename include guard.
11281         * observable.h: Rename include guard.
11282         * nto-tdep.h: Rename include guard.
11283         * nat/x86-linux.h: Rename include guard.
11284         * nat/x86-linux-dregs.h: Rename include guard.
11285         * nat/x86-gcc-cpuid.h: Add include guard.
11286         * nat/x86-dregs.h: Rename include guard.
11287         * nat/x86-cpuid.h: Rename include guard.
11288         * nat/ppc-linux.h: Rename include guard.
11289         * nat/mips-linux-watch.h: Rename include guard.
11290         * nat/linux-waitpid.h: Rename include guard.
11291         * nat/linux-ptrace.h: Rename include guard.
11292         * nat/linux-procfs.h: Rename include guard.
11293         * nat/linux-osdata.h: Rename include guard.
11294         * nat/linux-nat.h: Rename include guard.
11295         * nat/linux-namespaces.h: Rename include guard.
11296         * nat/linux-btrace.h: Rename include guard.
11297         * nat/glibc_thread_db.h: Rename include guard.
11298         * nat/gdb_thread_db.h: Rename include guard.
11299         * nat/gdb_ptrace.h: Rename include guard.
11300         * nat/fork-inferior.h: Rename include guard.
11301         * nat/amd64-linux-siginfo.h: Rename include guard.
11302         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11303         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11304         * nat/aarch64-linux.h: Rename include guard.
11305         * nat/aarch64-linux-hw-point.h: Rename include guard.
11306         * mn10300-tdep.h: Add include guard.
11307         * mips-linux-tdep.h: Add include guard.
11308         * mi/mi-parse.h: Rename include guard.
11309         * mi/mi-out.h: Rename include guard.
11310         * mi/mi-main.h: Rename include guard.
11311         * mi/mi-interp.h: Rename include guard.
11312         * mi/mi-getopt.h: Rename include guard.
11313         * mi/mi-console.h: Rename include guard.
11314         * mi/mi-common.h: Rename include guard.
11315         * mi/mi-cmds.h: Rename include guard.
11316         * mi/mi-cmd-break.h: Rename include guard.
11317         * m2-lang.h: Add include guard.
11318         * location.h: Rename include guard.
11319         * linux-record.h: Rename include guard.
11320         * linux-nat.h: Add include guard.
11321         * linux-fork.h: Add include guard.
11322         * i386-darwin-tdep.h: Rename include guard.
11323         * hppa-linux-offsets.h: Add include guard.
11324         * guile/guile.h: Rename include guard.
11325         * guile/guile-internal.h: Rename include guard.
11326         * gnu-nat.h: Rename include guard.
11327         * gdb-stabs.h: Rename include guard.
11328         * frv-tdep.h: Add include guard.
11329         * f-lang.h: Add include guard.
11330         * event-loop.h: Add include guard.
11331         * darwin-nat.h: Rename include guard.
11332         * cp-abi.h: Rename include guard.
11333         * config/sparc/nm-sol2.h: Rename include guard.
11334         * config/nm-nto.h: Rename include guard.
11335         * config/nm-linux.h: Add include guard.
11336         * config/i386/nm-i386gnu.h: Rename include guard.
11337         * config/djgpp/nl_types.h: Rename include guard.
11338         * config/djgpp/langinfo.h: Rename include guard.
11339         * compile/gcc-cp-plugin.h: Add include guard.
11340         * compile/gcc-c-plugin.h: Add include guard.
11341         * compile/compile.h: Rename include guard.
11342         * compile/compile-object-run.h: Rename include guard.
11343         * compile/compile-object-load.h: Rename include guard.
11344         * compile/compile-internal.h: Rename include guard.
11345         * compile/compile-cplus.h: Rename include guard.
11346         * compile/compile-c.h: Rename include guard.
11347         * common/xml-utils.h: Rename include guard.
11348         * common/x86-xstate.h: Rename include guard.
11349         * common/version.h: Rename include guard.
11350         * common/vec.h: Rename include guard.
11351         * common/tdesc.h: Rename include guard.
11352         * common/selftest.h: Rename include guard.
11353         * common/scoped_restore.h: Rename include guard.
11354         * common/scoped_mmap.h: Rename include guard.
11355         * common/scoped_fd.h: Rename include guard.
11356         * common/safe-iterator.h: Rename include guard.
11357         * common/run-time-clock.h: Rename include guard.
11358         * common/refcounted-object.h: Rename include guard.
11359         * common/queue.h: Rename include guard.
11360         * common/ptid.h: Rename include guard.
11361         * common/print-utils.h: Rename include guard.
11362         * common/preprocessor.h: Rename include guard.
11363         * common/pathstuff.h: Rename include guard.
11364         * common/observable.h: Rename include guard.
11365         * common/netstuff.h: Rename include guard.
11366         * common/job-control.h: Rename include guard.
11367         * common/host-defs.h: Rename include guard.
11368         * common/gdb_wait.h: Rename include guard.
11369         * common/gdb_vecs.h: Rename include guard.
11370         * common/gdb_unlinker.h: Rename include guard.
11371         * common/gdb_unique_ptr.h: Rename include guard.
11372         * common/gdb_tilde_expand.h: Rename include guard.
11373         * common/gdb_sys_time.h: Rename include guard.
11374         * common/gdb_string_view.h: Rename include guard.
11375         * common/gdb_splay_tree.h: Rename include guard.
11376         * common/gdb_setjmp.h: Rename include guard.
11377         * common/gdb_ref_ptr.h: Rename include guard.
11378         * common/gdb_optional.h: Rename include guard.
11379         * common/gdb_locale.h: Rename include guard.
11380         * common/gdb_assert.h: Rename include guard.
11381         * common/filtered-iterator.h: Rename include guard.
11382         * common/filestuff.h: Rename include guard.
11383         * common/fileio.h: Rename include guard.
11384         * common/environ.h: Rename include guard.
11385         * common/common-utils.h: Rename include guard.
11386         * common/common-types.h: Rename include guard.
11387         * common/common-regcache.h: Rename include guard.
11388         * common/common-inferior.h: Rename include guard.
11389         * common/common-gdbthread.h: Rename include guard.
11390         * common/common-exceptions.h: Rename include guard.
11391         * common/common-defs.h: Rename include guard.
11392         * common/common-debug.h: Rename include guard.
11393         * common/cleanups.h: Rename include guard.
11394         * common/buffer.h: Rename include guard.
11395         * common/btrace-common.h: Rename include guard.
11396         * common/break-common.h: Rename include guard.
11397         * cli/cli-utils.h: Rename include guard.
11398         * cli/cli-style.h: Rename include guard.
11399         * cli/cli-setshow.h: Rename include guard.
11400         * cli/cli-script.h: Rename include guard.
11401         * cli/cli-interp.h: Rename include guard.
11402         * cli/cli-decode.h: Rename include guard.
11403         * cli/cli-cmds.h: Rename include guard.
11404         * charset-list.h: Add include guard.
11405         * buildsym-legacy.h: Rename include guard.
11406         * bfin-tdep.h: Add include guard.
11407         * ax.h: Rename include guard.
11408         * arm-linux-tdep.h: Add include guard.
11409         * arm-fbsd-tdep.h: Add include guard.
11410         * arch/xtensa.h: Rename include guard.
11411         * arch/tic6x.h: Add include guard.
11412         * arch/i386.h: Add include guard.
11413         * arch/arm.h: Rename include guard.
11414         * arch/arm-linux.h: Rename include guard.
11415         * arch/arm-get-next-pcs.h: Rename include guard.
11416         * arch/amd64.h: Add include guard.
11417         * arch/aarch64-insn.h: Rename include guard.
11418         * arch-utils.h: Rename include guard.
11419         * annotate.h: Add include guard.
11420         * amd64-darwin-tdep.h: Rename include guard.
11421         * aarch64-linux-tdep.h: Add include guard.
11422         * aarch64-fbsd-tdep.h: Add include guard.
11423         * aarch32-linux-nat.h: Add include guard.
11424
11425 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11426
11427         * macrotab.c (macro_define_internal): New function that
11428         factorizes macro_define_object_internal and macro_define_function
11429         code.
11430         (macro_define_object_internal): Use macro_define_internal.
11431         (macro_define_function): Likewise.
11432
11433 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11434
11435         * macrocmd.c (extract_identifier): Return
11436         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11437         callers.
11438
11439 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11440
11441         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11442
11443 2019-02-05  Tom Tromey  <tom@tromey.com>
11444
11445         * target.c (target_stack::unpush): Move assertion earlier.
11446
11447 2019-01-30  Tom Tromey  <tom@tromey.com>
11448
11449         PR python/23615:
11450         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11451         (gdbpy_parse_and_eval): Likewise.
11452         * python/python-internal.h (gdbpy_allow_threads): New class.
11453
11454 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11455
11456         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11457         (aarch64_fbsd_fpregmap): Move earlier.
11458         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11459         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11460         instead of individual calls to trad_frame_set_reg_addr.
11461         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11462         earlier.
11463         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11464         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11465         instead of individual calls to trad_frame_set_reg_addr.
11466
11467 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11468
11469         * CONTRIBUTE: Replace contribution list with wiki link.
11470
11471 2019-01-25  Tom Tromey  <tom@tromey.com>
11472
11473         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11474
11475 2019-01-25  Tom Tromey  <tom@tromey.com>
11476
11477         * xtensa-linux-nat.c: Fix common/ includes.
11478         * xml-support.h: Fix common/ includes.
11479         * xml-support.c: Fix common/ includes.
11480         * x86-linux-nat.c: Fix common/ includes.
11481         * windows-nat.c: Fix common/ includes.
11482         * varobj.h: Fix common/ includes.
11483         * varobj.c: Fix common/ includes.
11484         * value.c: Fix common/ includes.
11485         * valops.c: Fix common/ includes.
11486         * utils.c: Fix common/ includes.
11487         * unittests/xml-utils-selftests.c: Fix common/ includes.
11488         * unittests/utils-selftests.c: Fix common/ includes.
11489         * unittests/unpack-selftests.c: Fix common/ includes.
11490         * unittests/tracepoint-selftests.c: Fix common/ includes.
11491         * unittests/style-selftests.c: Fix common/ includes.
11492         * unittests/string_view-selftests.c: Fix common/ includes.
11493         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11494         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11495         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11496         * unittests/rsp-low-selftests.c: Fix common/ includes.
11497         * unittests/parse-connection-spec-selftests.c: Fix common/
11498         includes.
11499         * unittests/optional-selftests.c: Fix common/ includes.
11500         * unittests/offset-type-selftests.c: Fix common/ includes.
11501         * unittests/observable-selftests.c: Fix common/ includes.
11502         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11503         * unittests/memrange-selftests.c: Fix common/ includes.
11504         * unittests/memory-map-selftests.c: Fix common/ includes.
11505         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11506         * unittests/function-view-selftests.c: Fix common/ includes.
11507         * unittests/environ-selftests.c: Fix common/ includes.
11508         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11509         * unittests/common-utils-selftests.c: Fix common/ includes.
11510         * unittests/cli-utils-selftests.c: Fix common/ includes.
11511         * unittests/array-view-selftests.c: Fix common/ includes.
11512         * ui-file.c: Fix common/ includes.
11513         * tui/tui-io.c: Fix common/ includes.
11514         * tracepoint.h: Fix common/ includes.
11515         * tracepoint.c: Fix common/ includes.
11516         * tracefile-tfile.c: Fix common/ includes.
11517         * top.h: Fix common/ includes.
11518         * top.c: Fix common/ includes.
11519         * thread.c: Fix common/ includes.
11520         * target/waitstatus.h: Fix common/ includes.
11521         * target/waitstatus.c: Fix common/ includes.
11522         * target.h: Fix common/ includes.
11523         * target.c: Fix common/ includes.
11524         * target-memory.c: Fix common/ includes.
11525         * target-descriptions.c: Fix common/ includes.
11526         * symtab.h: Fix common/ includes.
11527         * symfile.c: Fix common/ includes.
11528         * stap-probe.c: Fix common/ includes.
11529         * spu-linux-nat.c: Fix common/ includes.
11530         * sparc-nat.c: Fix common/ includes.
11531         * source.c: Fix common/ includes.
11532         * solib.c: Fix common/ includes.
11533         * solib-target.c: Fix common/ includes.
11534         * ser-unix.c: Fix common/ includes.
11535         * ser-tcp.c: Fix common/ includes.
11536         * ser-pipe.c: Fix common/ includes.
11537         * ser-base.c: Fix common/ includes.
11538         * selftest-arch.c: Fix common/ includes.
11539         * s12z-tdep.c: Fix common/ includes.
11540         * rust-exp.y: Fix common/ includes.
11541         * rs6000-aix-tdep.c: Fix common/ includes.
11542         * riscv-tdep.c: Fix common/ includes.
11543         * remote.c: Fix common/ includes.
11544         * remote-notif.h: Fix common/ includes.
11545         * remote-fileio.h: Fix common/ includes.
11546         * remote-fileio.c: Fix common/ includes.
11547         * regcache.h: Fix common/ includes.
11548         * regcache.c: Fix common/ includes.
11549         * record-btrace.c: Fix common/ includes.
11550         * python/python.c: Fix common/ includes.
11551         * python/py-type.c: Fix common/ includes.
11552         * python/py-inferior.c: Fix common/ includes.
11553         * progspace.h: Fix common/ includes.
11554         * producer.c: Fix common/ includes.
11555         * procfs.c: Fix common/ includes.
11556         * proc-api.c: Fix common/ includes.
11557         * printcmd.c: Fix common/ includes.
11558         * ppc-linux-nat.c: Fix common/ includes.
11559         * parser-defs.h: Fix common/ includes.
11560         * osdata.c: Fix common/ includes.
11561         * obsd-nat.c: Fix common/ includes.
11562         * nat/x86-linux.c: Fix common/ includes.
11563         * nat/x86-linux-dregs.c: Fix common/ includes.
11564         * nat/x86-dregs.h: Fix common/ includes.
11565         * nat/x86-dregs.c: Fix common/ includes.
11566         * nat/ppc-linux.c: Fix common/ includes.
11567         * nat/mips-linux-watch.h: Fix common/ includes.
11568         * nat/mips-linux-watch.c: Fix common/ includes.
11569         * nat/linux-waitpid.c: Fix common/ includes.
11570         * nat/linux-ptrace.h: Fix common/ includes.
11571         * nat/linux-ptrace.c: Fix common/ includes.
11572         * nat/linux-procfs.c: Fix common/ includes.
11573         * nat/linux-personality.c: Fix common/ includes.
11574         * nat/linux-osdata.c: Fix common/ includes.
11575         * nat/linux-namespaces.c: Fix common/ includes.
11576         * nat/linux-btrace.h: Fix common/ includes.
11577         * nat/linux-btrace.c: Fix common/ includes.
11578         * nat/fork-inferior.c: Fix common/ includes.
11579         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11580         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11581         * nat/aarch64-linux.c: Fix common/ includes.
11582         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11583         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11584         * namespace.h: Fix common/ includes.
11585         * mips-linux-tdep.c: Fix common/ includes.
11586         * minsyms.c: Fix common/ includes.
11587         * mi/mi-parse.h: Fix common/ includes.
11588         * mi/mi-main.c: Fix common/ includes.
11589         * mi/mi-cmd-env.c: Fix common/ includes.
11590         * memrange.h: Fix common/ includes.
11591         * memattr.c: Fix common/ includes.
11592         * maint.h: Fix common/ includes.
11593         * maint.c: Fix common/ includes.
11594         * main.c: Fix common/ includes.
11595         * machoread.c: Fix common/ includes.
11596         * location.c: Fix common/ includes.
11597         * linux-thread-db.c: Fix common/ includes.
11598         * linux-nat.c: Fix common/ includes.
11599         * linux-fork.c: Fix common/ includes.
11600         * inline-frame.c: Fix common/ includes.
11601         * infrun.c: Fix common/ includes.
11602         * inflow.c: Fix common/ includes.
11603         * inferior.h: Fix common/ includes.
11604         * inferior.c: Fix common/ includes.
11605         * infcmd.c: Fix common/ includes.
11606         * inf-ptrace.c: Fix common/ includes.
11607         * inf-child.c: Fix common/ includes.
11608         * ia64-linux-nat.c: Fix common/ includes.
11609         * i387-tdep.c: Fix common/ includes.
11610         * i386-tdep.c: Fix common/ includes.
11611         * i386-linux-tdep.c: Fix common/ includes.
11612         * i386-linux-nat.c: Fix common/ includes.
11613         * i386-go32-tdep.c: Fix common/ includes.
11614         * i386-fbsd-tdep.c: Fix common/ includes.
11615         * i386-fbsd-nat.c: Fix common/ includes.
11616         * guile/scm-type.c: Fix common/ includes.
11617         * guile/guile.c: Fix common/ includes.
11618         * go32-nat.c: Fix common/ includes.
11619         * gnu-nat.c: Fix common/ includes.
11620         * gdbthread.h: Fix common/ includes.
11621         * gdbarch-selftests.c: Fix common/ includes.
11622         * gdb_usleep.c: Fix common/ includes.
11623         * gdb_select.h: Fix common/ includes.
11624         * gdb_bfd.c: Fix common/ includes.
11625         * gcore.c: Fix common/ includes.
11626         * fork-child.c: Fix common/ includes.
11627         * findvar.c: Fix common/ includes.
11628         * fbsd-nat.c: Fix common/ includes.
11629         * event-top.c: Fix common/ includes.
11630         * event-loop.c: Fix common/ includes.
11631         * dwarf2read.c: Fix common/ includes.
11632         * dwarf2loc.c: Fix common/ includes.
11633         * dwarf2-frame.c: Fix common/ includes.
11634         * dwarf-index-cache.c: Fix common/ includes.
11635         * dtrace-probe.c: Fix common/ includes.
11636         * disasm-selftests.c: Fix common/ includes.
11637         * defs.h: Fix common/ includes.
11638         * csky-tdep.c: Fix common/ includes.
11639         * cp-valprint.c: Fix common/ includes.
11640         * cp-support.h: Fix common/ includes.
11641         * cp-support.c: Fix common/ includes.
11642         * corelow.c: Fix common/ includes.
11643         * completer.h: Fix common/ includes.
11644         * completer.c: Fix common/ includes.
11645         * compile/compile.c: Fix common/ includes.
11646         * compile/compile-loc2c.c: Fix common/ includes.
11647         * compile/compile-cplus-types.c: Fix common/ includes.
11648         * compile/compile-cplus-symbols.c: Fix common/ includes.
11649         * command.h: Fix common/ includes.
11650         * cli/cli-dump.c: Fix common/ includes.
11651         * cli/cli-cmds.c: Fix common/ includes.
11652         * charset.c: Fix common/ includes.
11653         * build-id.c: Fix common/ includes.
11654         * btrace.h: Fix common/ includes.
11655         * btrace.c: Fix common/ includes.
11656         * breakpoint.h: Fix common/ includes.
11657         * breakpoint.c: Fix common/ includes.
11658         * ax.h:
11659         (enum agent_op): Fix common/ includes.
11660         * ax-general.c (struct aop_map): Fix common/ includes.
11661         * ax-gdb.c: Fix common/ includes.
11662         * auxv.c: Fix common/ includes.
11663         * auto-load.c: Fix common/ includes.
11664         * arm-tdep.c: Fix common/ includes.
11665         * arch/riscv.c: Fix common/ includes.
11666         * arch/ppc-linux-common.c: Fix common/ includes.
11667         * arch/i386.c: Fix common/ includes.
11668         * arch/arm.c: Fix common/ includes.
11669         * arch/arm-linux.c: Fix common/ includes.
11670         * arch/arm-get-next-pcs.c: Fix common/ includes.
11671         * arch/amd64.c: Fix common/ includes.
11672         * arch/aarch64.c: Fix common/ includes.
11673         * arch/aarch64-insn.c: Fix common/ includes.
11674         * arch-utils.c: Fix common/ includes.
11675         * amd64-windows-tdep.c: Fix common/ includes.
11676         * amd64-tdep.c: Fix common/ includes.
11677         * amd64-sol2-tdep.c: Fix common/ includes.
11678         * amd64-obsd-tdep.c: Fix common/ includes.
11679         * amd64-nbsd-tdep.c: Fix common/ includes.
11680         * amd64-linux-tdep.c: Fix common/ includes.
11681         * amd64-linux-nat.c: Fix common/ includes.
11682         * amd64-fbsd-tdep.c: Fix common/ includes.
11683         * amd64-fbsd-nat.c: Fix common/ includes.
11684         * amd64-dicos-tdep.c: Fix common/ includes.
11685         * amd64-darwin-tdep.c: Fix common/ includes.
11686         * agent.c: Fix common/ includes.
11687         * ada-lang.h: Fix common/ includes.
11688         * ada-lang.c: Fix common/ includes.
11689         * aarch64-tdep.c: Fix common/ includes.
11690
11691 2019-01-25  Tom Tromey  <tom@tromey.com>
11692
11693         * common/create-version.sh: Use common/version.h.
11694
11695 2019-01-24  Pedro Alves  <palves@redhat.com>
11696
11697         * infrun.c (signal_stop, signal_print, signal_program)
11698         (signal_catch, signal_pass): Now arrays instead of pointers.
11699         (update_signals_program_target, do_target_resume)
11700         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11701         * linux-nat.c (linux_nat_target::pass_signals)
11702         (linux_nat_target::create_inferior, linux_nat_target::attach):
11703         Adjust.
11704         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11705         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11706         * procfs.c (procfs_target::pass_signals): Adjust.
11707         * record-full.c (record_full_target::resume): Adjust.
11708         * remote.c (remote_target::pass_signals)
11709         (remote_target::program_signals): Adjust.
11710         * target-debug.h (target_debug_print_signals): Now takes a
11711         gdb::array_view as parameter.  Adjust.
11712         * target.h (target_ops) <pass_signals, program_signals>: Replace
11713         pointer and length parameters with gdb::array_view.
11714         (target_pass_signals, target_program_signals): Likewise.
11715         * target-delegates.c: Regenerate.
11716
11717 2019-01-24  Pedro Alves  <palves@redhat.com>
11718
11719         * common/forward-scope-exit.h
11720         (forward_scope_exit::forward_scope_exit): Pass arguments to
11721         m_bind_function directly, instead of creating a std::bind and
11722         copying that.
11723
11724 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11725
11726         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11727         for static members.
11728         (pass_in_v_vfp_candidate): Likewise.
11729
11730 2019-01-23  Tom Tromey  <tom@tromey.com>
11731             Pedro Alves  <palves@redhat.com>
11732
11733         * regcache.c (class regcache_invalidator): Remove.
11734         (regcache::raw_write): Use make_scope_exit.
11735
11736 2019-01-23  Tom Tromey  <tom@tromey.com>
11737
11738         * ui-out.h (class ui_out_emit_type): Update comment.
11739
11740 2019-01-23  Tom Tromey  <tom@tromey.com>
11741
11742         * infrun.c (fetch_inferior_event): Update comment.
11743
11744 2019-01-23  Tom Tromey  <tom@tromey.com>
11745             Pedro Alves  <palves@redhat.com>
11746
11747         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11748         parameter.
11749         (fetch_inferior_event): Use SCOPE_EXIT.
11750
11751
11752 2019-01-23  Tom Tromey  <tom@tromey.com>
11753             Pedro Alves  <palves@redhat.com>
11754
11755         * infrun.c (disable_thread_events): Delete.
11756         (stop_all_threads): Use SCOPE_EXIT.
11757
11758 2019-01-23  Tom Tromey  <tom@tromey.com>
11759             Pedro Alves  <palves@redhat.com>
11760
11761         * symfile.c: Include forward-scope-exit.h.
11762         (clear_symtab_users_cleanup): Replace forward declaration with
11763         a FORWARD_SCOPE_EXIT.
11764         (syms_from_objfile_1): Use the forward_scope_exit and
11765         gdb::optional instead of cleanup_function.
11766         (reread_symbols): Use the forward_scope_exit instead of
11767         cleanup_function.
11768         (clear_symtab_users_cleanup): Remove function.
11769
11770 2019-01-23  Tom Tromey  <tom@tromey.com>
11771             Pedro Alves  <palves@redhat.com>
11772
11773         * linux-nat.c: Include scope-exit.h.
11774         (cleanup_target_stop): Remove.
11775         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11776         SCOPE_EXIT.
11777
11778 2019-01-23  Tom Tromey  <tom@tromey.com>
11779             Pedro Alves  <palves@redhat.com>
11780
11781         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11782         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11783
11784 2019-01-23  Tom Tromey  <tom@tromey.com>
11785             Andrew Burgess  <andrew.burgess@embecosm.com>
11786             Pedro Alves  <palves@redhat.com>
11787
11788         * infrun.c (fetch_inferior_event): Use scope_exit.
11789         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11790         * top.c (execute_command): Use scope_exit.
11791         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11792         * utils.c (do_bpstat_clear_actions_cleanup)
11793         (make_bpstat_clear_actions_cleanup): Remove.
11794
11795 2019-01-23  Tom Tromey  <tom@tromey.com>
11796             Pedro Alves  <palves@redhat.com>
11797
11798         * infrun.c: Include "common/scope-exit.h"
11799         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11800         (wait_for_inferior): Use SCOPE_EXIT.
11801         (fetch_inferior_event): Use scope_exit.
11802
11803 2019-01-23  Tom Tromey  <tom@tromey.com>
11804             Pedro Alves  <palves@redhat.com>
11805
11806         * breakpoint.c (create_breakpoint): Remove cleanup.
11807
11808 2019-01-23  Tom Tromey  <tom@tromey.com>
11809             Andrew Burgess  <andrew.burgess@embecosm.com>
11810             Pedro Alves  <palves@redhat.com>
11811
11812 2019-01-23  Pedro Alves  <palves@redhat.com>
11813
11814         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11815
11816 2019-01-23  Pedro Alves  <palves@redhat.com>
11817             Andrew Burgess  <andrew.burgess@embecosm.com>
11818
11819         * gdbthread.h: Include "common/forward-scope-exit.h".
11820         (scoped_finish_thread_state): Redefine custom class in terms of
11821         forward_scope_exit.
11822
11823 2019-01-23  Pedro Alves  <palves@redhat.com>
11824             Andrew Burgess  <andrew.burgess@embecosm.com>
11825
11826         * common/forward-scope-exit.h: New file.
11827
11828 2019-01-23  Pedro Alves  <palves@redhat.com>
11829             Andrew Burgess  <andrew.burgess@embecosm.com>
11830             Tom Tromey  <tom@tromey.com>
11831
11832         * common/scope-exit.h: New file.
11833
11834 2019-01-23  Pedro Alves  <palves@redhat.com>
11835
11836         * common/preprocessor.h (ESC): Rename to ...
11837         (ESC_PARENS): ... this.
11838         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11839         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11840
11841 2019-01-23  Tom Tromey  <tom@tromey.com>
11842
11843         * language.h (class scoped_switch_to_sym_language_if_auto):
11844         Initialize m_lang in both cases.
11845
11846 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11847
11848         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11849         with XCNEW.
11850
11851 2019-01-22  Tom Tromey  <tom@tromey.com>
11852
11853         * corelow.c: Do not include sys/file.h.
11854
11855 2019-01-22  Tom Tromey  <tom@tromey.com>
11856
11857         * tui/tui-wingeneral.h: Include gdb_curses.h.
11858
11859 2019-01-22  Tom Tromey  <tom@tromey.com>
11860
11861         * source-cache.h (class source_cache) <get_source_lines,
11862         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11863
11864 2019-01-22  Tom Tromey  <tom@tromey.com>
11865
11866         * remote-fileio.h (struct remote_target): Declare.
11867
11868 2019-01-22  Tom Tromey  <tom@tromey.com>
11869
11870         * python/py-arch.c: Do not include py-ref.h.
11871         * python/py-bpevent.c: Do not include py-ref.h.
11872         * python/py-cmd.c: Do not include py-ref.h.
11873         * python/py-continueevent.c: Do not include py-ref.h.
11874         * python/py-event.h: Do not include py-ref.h.
11875         * python/py-evtregistry.c: Do not include py-ref.h.
11876         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11877         * python/py-frame.c: Do not include py-ref.h.
11878         * python/py-framefilter.c: Do not include py-ref.h.
11879         * python/py-function.c: Do not include py-ref.h.
11880         * python/py-infevents.c: Do not include py-ref.h.
11881         * python/py-linetable.c: Do not include py-ref.h.
11882         * python/py-objfile.c: Do not include py-ref.h.
11883         * python/py-param.c: Do not include py-ref.h.
11884         * python/py-prettyprint.c: Do not include py-ref.h.
11885         * python/py-progspace.c: Do not include py-ref.h.
11886         * python/py-symbol.c: Do not include py-ref.h.
11887         * python/py-symtab.c: Do not include py-ref.h.
11888         * python/py-type.c: Do not include py-ref.h.
11889         * python/py-unwind.c: Do not include py-ref.h.
11890         * python/py-utils.c: Do not include py-ref.h.
11891         * python/py-value.c: Do not include py-ref.h.
11892         * python/py-varobj.c: Do not include py-ref.h.
11893         * python/py-xmethods.c: Do not include py-ref.h.
11894         * python/python.c: Do not include py-ref.h.
11895         * varobj.c: Do not include py-ref.h.
11896
11897 2019-01-22  Tom Tromey  <tom@tromey.com>
11898
11899         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11900         keyword for bcache.
11901
11902 2019-01-22  Tom Tromey  <tom@tromey.com>
11903
11904         * compile/compile-cplus-types.c: Remove a comment by #include.
11905
11906 2019-01-22  Tom Tromey  <tom@tromey.com>
11907
11908         * compile/gcc-c-plugin.h: Include compile-internal.h.
11909
11910 2019-01-22  Tom Tromey  <tom@tromey.com>
11911
11912         * stabsread.c (EXTERN): Do not define.
11913         (symnum, next_symbol_text_func, processing_gcc_compilation)
11914         (within_function, global_sym_chain, global_stabs)
11915         (previous_stab_code, this_object_header_files)
11916         (n_this_object_header_files)
11917         (n_allocated_this_object_header_files): Define.
11918         * stabsread.h (EXTERN): Never define.  Use "extern".
11919
11920 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11921
11922         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11923         history_value.
11924
11925 2019-01-21  Tom Tromey  <tom@tromey.com>
11926
11927         * ui-out.c: Fix includes.
11928         * tui/tui-source.c: Fix includes.
11929         * target.c: Fix includes.
11930         * remote.c: Fix includes.
11931         * regcache.c: Fix includes.
11932         * python/py-block.c: Fix includes.
11933         * printcmd.c: Fix includes.
11934         * or1k-tdep.c: Fix includes.
11935         * mi/mi-main.c: Fix includes.
11936         * m32r-tdep.c: Fix includes.
11937         * csky-tdep.c: Fix includes.
11938         * compile/compile-cplus-types.c: Fix includes.
11939         * cli/cli-interp.c: Fix includes.
11940
11941 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11942
11943         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11944         for padding.
11945
11946 2019-01-16  Tom Tromey  <tom@tromey.com>
11947
11948         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11949         earlier.
11950         (struct objfile) <msymbols_range>: Move from top level.
11951         <msymbols>: New method.
11952         (class objfile_msymbols): Remove.
11953         * symtab.c (default_collect_symbol_completion_matches_break_on):
11954         Update.
11955         * symmisc.c (dump_msymbols): Update.
11956         * stabsread.c (scan_file_globals): Update.
11957         * objc-lang.c (info_selectors_command, info_classes_command)
11958         (find_methods): Update.
11959         * minsyms.c (find_solib_trampoline_target): Update.
11960         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11961         * coffread.c (coff_symfile_read): Update.
11962         * ada-lang.c (ada_lookup_simple_minsym)
11963         (ada_collect_symbol_completion_matches): Update.
11964
11965 2019-01-16  Tom Tromey  <tom@tromey.com>
11966
11967         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11968         type.  Remove no-argument constructor.
11969         <iterator::operator++>: Simplify.
11970         <begin>: Update.
11971         <end>: Use minimal_symbol_count.
11972
11973 2019-01-16  Tom Tromey  <tom@tromey.com>
11974
11975         * objfiles.h (struct objfile) <psymtabs>: New method.
11976         (class objfile_psymtabs): Remove.
11977         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11978         typedef.
11979         <range>: New method.
11980         (require_partial_symbols): Change return type.
11981         * psymtab.c (require_partial_symbols)
11982         (psym_expand_symtabs_matching): Update.
11983         * mdebugread.c (parse_partial_symbols): Update.
11984         * dbxread.c (dbx_end_psymtab): Update.
11985
11986 2019-01-15  Tom Tromey  <tom@tromey.com>
11987
11988         * symtab.c (lookup_objfile_from_block)
11989         (lookup_symbol_in_objfile_symtabs)
11990         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11991         (find_line_symtab, info_sources_command)
11992         (default_collect_symbol_completion_matches_break_on)
11993         (make_source_files_completion_list): Update.
11994         * symmisc.c (print_objfile_statistics, dump_objfile)
11995         (maintenance_print_symbols, maintenance_info_symtabs)
11996         (maintenance_check_symtabs, maintenance_info_line_tables):
11997         Update.
11998         * source.c (select_source_symtab)
11999         (forget_cached_source_info_for_objfile): Update.
12000         * objfiles.h (class objfile_compunits): Remove.
12001         (struct objfile) <compunits_range>: New typedef.
12002         (compunits): New method.
12003         * objfiles.c (objfile_relocate1): Update.
12004         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12005         * maint.c (count_symtabs_and_blocks): Update.
12006         * linespec.c (iterate_over_all_matching_symtabs): Update.
12007         * cp-support.c (add_symbol_overload_list_qualified): Update.
12008         * coffread.c (coff_symtab_read): Update.
12009         * ada-lang.c (add_nonlocal_symbols)
12010         (ada_collect_symbol_completion_matches)
12011         (ada_add_global_exceptions): Update.
12012
12013 2019-01-15  Tom Tromey  <tom@tromey.com>
12014
12015         * progspace.h (program_space) <objfiles_safe_range>: New
12016         typedef.
12017         <objfiles_safe>: New method.
12018         * objfiles.h (class all_objfiles_safe): Remove.
12019         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12020         * jit.c (jit_inferior_exit_hook): Update.
12021
12022 2019-01-17  Tom Tromey  <tom@tromey.com>
12023
12024         * progspace.h (program_space) <objfiles_range>: New typedef.
12025         <objfiles>: New method.
12026         <objfiles_head>: Rename from objfiles.
12027         (object_files): Update.
12028         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12029         * guile/scm-pretty-print.c
12030         (ppscm_find_pretty_printer_from_objfiles): Update.
12031         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12032         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12033         Update.
12034         * python/py-progspace.c (pspy_get_objfiles): Update.
12035         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12036         Update.
12037         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12038         (objfpy_lookup_objfile_by_build_id): Update.
12039         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12040         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12041         Update.
12042         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12043         (expand_symtab_containing_pc, lookup_objfile_from_block)
12044         (lookup_static_symbol, basic_lookup_transparent_type)
12045         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12046         (find_line_symtab, info_sources_command)
12047         (default_collect_symbol_completion_matches_break_on)
12048         (make_source_files_completion_list, find_main_name): Update.
12049         * symmisc.c (print_symbol_bcache_statistics)
12050         (print_objfile_statistics, maintenance_print_symbols)
12051         (maintenance_print_msymbols, maintenance_print_objfiles)
12052         (maintenance_info_symtabs, maintenance_check_symtabs)
12053         (maintenance_expand_symtabs, maintenance_info_line_tables):
12054         Update.
12055         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12056         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12057         (map_overlay_command, unmap_overlay_command)
12058         (simple_overlay_update, expand_symtabs_matching)
12059         (map_symbol_filenames): Update.
12060         * symfile-debug.c (set_debug_symfile): Update.
12061         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12062         Update.
12063         * source.c (select_source_symtab, forget_cached_source_info):
12064         Update.
12065         * solib.c (solib_read_symbols): Update.
12066         * solib-spu.c (append_ocl_sos): Update.
12067         * psymtab.c (maintenance_print_psymbols)
12068         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12069         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12070         * printcmd.c (info_symbol_command): Update.
12071         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12072         Update.
12073         * objfiles.h (class all_objfiles): Remove.
12074         * objfiles.c (have_partial_symbols, have_full_symbols)
12075         (have_minimal_symbols, qsort_cmp, update_section_map)
12076         (shared_objfile_contains_address_p)
12077         (default_iterate_over_objfiles_in_search_order): Update.
12078         * objc-lang.c (info_selectors_command, info_classes_command)
12079         (find_methods): Update.
12080         * minsyms.c (find_solib_trampoline_target): Update.
12081         * maint.c (maintenance_info_sections)
12082         (maintenance_translate_address, count_symtabs_and_blocks):
12083         Update.
12084         * main.c (captured_main_1): Update.
12085         * linux-thread-db.c (try_thread_db_load_from_pdir)
12086         (has_libpthread): Update.
12087         * linespec.c (iterate_over_all_matching_symtabs)
12088         (search_minsyms_for_name): Update.
12089         * jit.c (jit_find_objf_with_entry_addr): Update.
12090         * hppa-tdep.c (find_unwind_entry)
12091         (hppa_lookup_stub_minimal_symbol): Update.
12092         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12093         Update.
12094         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12095         (elf_gnu_ifunc_resolve_by_got): Update.
12096         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12097         * dwarf-index-write.c (save_gdb_index_command): Update.
12098         * cp-support.c (add_symbol_overload_list_qualified): Update.
12099         * breakpoint.c (create_overlay_event_breakpoint)
12100         (create_longjmp_master_breakpoint)
12101         (create_std_terminate_master_breakpoint)
12102         (create_exception_master_breakpoint): Update.
12103         * blockframe.c (find_pc_partial_function): Update.
12104         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12105         (ada_collect_symbol_completion_matches)
12106         (ada_add_global_exceptions): Update.
12107
12108 2019-01-17  Tom Tromey  <tom@tromey.com>
12109
12110         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12111         declare VEC.
12112         (solib_target_parse_libraries): Change return type.
12113         (library_list_start_segment, library_list_start_section)
12114         (library_list_end_library, library_list_start_library); Update.
12115         (solib_target_free_library_list): Remove.
12116         (solib_target_parse_libraries): Remove cleanup.  Change return
12117         type.
12118         (solib_target_current_sos): Update.
12119
12120 2019-01-17  Tom Tromey  <tromey@bapiya>
12121
12122         * valprint.c: Replace "the the" with "the".
12123         * symtab.c: Replace "the the" with "the".
12124         * solib.c: Replace "the the" with "the".
12125         * solib-dsbt.c: Replace "the the" with "the".
12126         * linespec.c: Replace "the the" with "the".
12127         * dwarf2loc.h: Replace "the the" with "the".
12128         * amd64-windows-tdep.c: Replace "the the" with "the".
12129         * aarch64-tdep.c: Replace "the the" with "the".
12130
12131 2019-01-16  Keith Seitz  <keiths@redhat.com>
12132
12133         PR gdb/23773
12134         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12135         <builder>: Rename to ..
12136         <m_builder>: ... this and make private.
12137         (dwarf2_cu::get_builder): New method.  Change all users of
12138         `builder' to use this method.
12139         (dwarf2_start_symtab): Move to ...
12140         (dwarf2_cu::start_symtab): ... here.  Update all callers
12141         (setup_type_unit_groups): Move to ...
12142         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12143         callers.
12144         (dwarf2_cu::reset_builder): New method.
12145         (process_full_compunit, process_full_type_unit): Use
12146         dwarf2_cu::reset_builder.
12147         (follow_die_offset): Record the ancestor CU if it is different
12148         from the followed DIE's CU.
12149         (follow_die_sig_1): Likewise.
12150
12151 2019-01-15  Tom Tromey  <tom@tromey.com>
12152
12153         * remote.c (class remote_state) <buf>: Now a char_vector.
12154         <buf_size>: Remove.
12155         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12156         parameter.
12157         (remote_target::getpkt_or_notif_sane_1)
12158         (remote_target::getpkt_sane)
12159         (remote_target::getpkt_or_notif_sane): Likewise.
12160         (class remote_target) <putpkt>: New overload.
12161         (remote_target::read_frame): Change type of "buf_p".  Remove
12162         sizeof_p parameter.
12163         (packet_ok): New overload.
12164         (packet_check_result): New overload.
12165         Update all uses.
12166
12167 2019-01-14  Tom Tromey  <tom@tromey.com>
12168
12169         * remote-notif.c (handle_notification, remote_notif_ack)
12170         (remote_notif_parse): Make "buf" const.
12171         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12172         const.
12173         (remote_notif_parse, remote_notif_ack, handle_notification):
12174         Likewise.
12175         * remote.c (remote_notif_stop_parse): Make "buf" const.
12176         (remote_target::remote_parse_stop_reply): Make "buf" const.
12177         (remote_notif_stop_ack): Make "buf" const.
12178
12179 2019-01-14  Tom Tromey  <tom@tromey.com>
12180
12181         * remote.c (remote_console_output): Make parameter const.
12182
12183 2019-01-14  Tom Tromey  <tom@tromey.com>
12184
12185         * target-debug.h (target_debug_print_signals): Constify.
12186         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12187         * procfs.c (procfs_target::pass_signals): Update.
12188         * linux-nat.c (linux_nat_target::pass_signals): Update.
12189         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12190         * target-delegates.c: Rebuild.
12191         * remote.c (remote_target::program_signals): Update.
12192         (remote_target::pass_signals): Update.
12193         * target.c (target_pass_signals): Constify argument.
12194         (target_program_signals): Likewise.
12195         * target.h (struct target_ops) <pass_signals, program_signals>:
12196         Constify argument.
12197         (target_pass_signals, target_program_signals): Constify argument.
12198
12199 2019-01-14  Tom Tromey  <tom@tromey.com>
12200
12201         PR tui/28819:
12202         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12203
12204 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12205
12206         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12207         field.
12208         * rs6000-tdep.c: Include reggroups.h.
12209         (IS_V_ALIAS_PSEUDOREG): Define.
12210         (rs6000_register_name): Return names for the "vX" aliases.
12211         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12212         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12213         aliases.  Call default_register_reggroup_p for all other
12214         pseudo-registers.
12215         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12216         New functions.
12217         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12218         Handle "vX" aliases.
12219         (v_alias_pseudo_register_collect): New function.
12220         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12221         (rs6000_gdbarch_init): Initialize "vX" aliases as
12222         pseudo-registers.  Restore registration of
12223         rs6000_pseudo_register_reggroup_p with
12224         set_tdesc_pseudo_register_reggroup_p.
12225
12226 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12227
12228         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12229         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12230         set_gdbarch_num_pseudo_regs.
12231
12232 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12233
12234         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12235         Remove arg prefixname, add do_set and do_show.
12236         Add member functions set_list and show_list.
12237         * cli/cli-style.c (class cli_style_option): Update accordingly.
12238         (style_set_list): Move to file scope.
12239         (style_show_list): Likewise.
12240         (set_style): Call help_list.
12241         (show_style): Call cmd_show_list.
12242         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12243         Update to use the new macro.
12244
12245 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12246
12247         * ada-lang.c (_initialize_ada_language): Expand the help text
12248         for the "catch exception" command.
12249
12250 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12251
12252         * symtab.c (matching_obj_sections): Initialize obj,
12253         declare it closer to its usage.
12254
12255 2019-01-10  Tom Tromey  <tom@tromey.com>
12256
12257         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12258         (basic_inf_threads_range): Remove.
12259         (inf_threads_range, inf_non_exited_threads_range)
12260         (safe_inf_threads_range): Use next_adapter.
12261
12262 2019-01-10  Keith Seitz  <keiths@redhat.com>
12263
12264         PR gdb/23712
12265         PR symtab/23010
12266         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12267         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12268
12269 2019-01-10  Keith Seitz  <keiths@redhat.com>
12270
12271         PR gdb/23712
12272         PR symtab/23010
12273         * dictionary.c (pending_to_vector): Remove.
12274         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12275         Remove _1 suffix, replacing functions of the same name.  Update
12276         all callers.
12277         (dict_create_hashed, dict_create_hashed_expandable)
12278         (dict_create_linear, dict_create_linear_expandable, dict_free)
12279         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12280         Make functions static.
12281
12282 2019-01-10  Keith Seitz  <keiths@redhat.com>
12283
12284         PR gdb/23712
12285         PR symtab/23010
12286         * dictionary.h (struct dictionary): Replace declaration with
12287         multidictionary.
12288         (dict_create_hashed, dict_create_hashed_expandable)
12289         (dict_create_linear, dict_create_linear_expandable)
12290         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12291         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12292         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12293         taking multidictionary argument.
12294         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12295         * block.h (struct block) <dict>: Change to multidictionary
12296         and rename `multidict'.
12297         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12298         symmisc.c: Update all dictionary references to multidictionary.
12299
12300 2019-01-10  Keith Seitz  <keiths@redhat.com>
12301
12302         PR gdb/23712
12303         PR symtab/23010
12304         * dictionary.c: Include unordered_map.
12305         (pending_to_vector): New function.
12306         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12307         Rewrite the non-"_1" functions to take vector instead
12308         of linked list.
12309         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12310         "new" _1 versions of the same name.
12311         (multidictionary): Define.
12312         (std::hash<enum language): New definition.
12313         (collate_pending_symbols_by_language, mdict_create_hashed)
12314         (mdict_create_hashed_expandable, mdict_create_linear)
12315         (mdict_create_linear_expandable, mdict_free)
12316         (find_language_dictionary, create_new_language_dictionary)
12317         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12318         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12319         (mdict_size, mdict_empty): New functions.
12320         * dictionary.h (mdict_iterator): Define.
12321
12322 2019-01-10  Pedro Alves  <palves@redhat.com>
12323
12324         * breakpoint.c (read_uploaded_action)
12325         (create_tracepoint_from_upload): Adjust to use
12326         gdb::unique_xmalloc_ptr.
12327         * ctf.c (ctf_write_uploaded_tp):
12328         (SET_ARRAY_FIELD): Use emplace_back.
12329         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12330         * tracefile-tfile.c (tfile_write_uploaded_tp):
12331         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12332         gdb::unique_xmalloc_ptr.
12333         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12334         at_string, cond_string, cmd_strings>: Replace char pointers
12335         with gdb::unique_xmalloc_ptr.
12336
12337 2019-01-10  Pedro Alves  <palves@redhat.com>
12338
12339         * solib-target.c (library_list_start_library): Don't xstrdup name.
12340
12341 2019-01-10  Pedro Alves  <palves@redhat.com>
12342
12343         * mdebugread.c (parse_partial_symbols): Use
12344         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12345
12346 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12347
12348         * linux-fork.c (scoped_switch_fork_info)
12349         <~scoped_switch_fork_info>: Fix incorrect variable name.
12350
12351 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12352
12353         * linux-fork.c (scoped_switch_fork_info)
12354         <scoped_switch_fork_info>: Make explicit.
12355         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12356
12357 2019-01-10  Tom Tromey  <tom@tromey.com>
12358
12359         * objfiles.h (objfile::reset_psymtabs): Update.
12360         * objfiles.c (objfile::objfile): Update.
12361         * psymtab.h (psymtab_storage::obstack): Update.
12362         (psymtab_storage::m_obstack): Use gdb::optional.
12363         (class psymtab_storage): Update comment.  Remove objfile
12364         parameter.
12365         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12366
12367 2019-01-10  Tom Tromey  <tom@tromey.com>
12368
12369         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12370         <free_psymtabs>: Now private.
12371         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12372         (allocate_psymtab): Use new method.
12373
12374 2019-01-10  Tom Tromey  <tom@tromey.com>
12375
12376         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12377         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12378         * mdebugread.c (parse_partial_symbols): Use
12379         allocate_dependencies.
12380         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12381         allocate_dependencies.
12382         (process_psymtab_comp_unit_reader)
12383         (build_type_psymtab_dependencies): Likewise.
12384         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12385
12386 2019-01-10  Tom Tromey  <tom@tromey.com>
12387
12388         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12389         PSYMBOL_SET_LANGUAGE.
12390         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12391
12392 2019-01-10  Tom Tromey  <tom@tromey.com>
12393
12394         * psymtab.h (psymtab_storage::obstack): New method.
12395         <m_obstack>: Rename from obstack; now private.
12396         * psymtab.c (psymtab_storage): Update.
12397         * dwarf2read.c (create_addrmap_from_index)
12398         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12399         Update.
12400
12401 2019-01-10  Tom Tromey  <tom@tromey.com>
12402
12403         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12404         * objfiles.h (objfile::reset_psymtabs): New method.
12405
12406 2019-01-10  Tom Tromey  <tom@tromey.com>
12407
12408         * symmisc.c (print_symbol_bcache_statistics): Update.
12409         (print_objfile_statistics): Update.
12410         * symfile.c (reread_symbols): Update.
12411         * psymtab.h (class psymtab_storage): New.
12412         * psymtab.c (psymtab_storage): New constructor.
12413         (~psymtab_storage): New destructor.
12414         (require_partial_symbols): Update.
12415         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12416         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12417         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12418         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12419         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12420         (start_psymtab_common, end_psymtab_common)
12421         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12422         (allocate_psymtab): Update.
12423         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12424         Update.
12425         (dump_psymtab_addrmap, maintenance_print_psymbols)
12426         (maintenance_check_psymtabs): Update.
12427         (class objfile_psymtabs): Move to objfiles.h.
12428         * psympriv.h (discard_psymtab): Now inline.
12429         (psymtab_discarder::psymtab_discarder): Update.
12430         (psymtab_discarder::~psymtab_discarder): Update.
12431         (ALL_OBJFILE_PSYMTABS): Rewrite.
12432         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12433         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12434         Remove fields.
12435         <partial_symtabs>: New field.
12436         (class objfile_psymtabs): Move from psymtab.h.  Update.
12437         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12438         psymbol_cache.
12439         (objfile::~objfile): Don't destroy psymbol_cache.
12440         * mdebugread.c (parse_partial_symbols): Update.
12441         * dwarf2read.c (create_addrmap_from_index)
12442         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12443         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12444         (add_partial_subprogram, dwarf2_ranges_read): Update.
12445         * dwarf-index-write.c (write_address_map)
12446         (write_one_signatured_type, recursively_write_psymbols)
12447         (class debug_names, class debug_names, write_psymtabs_to_index):
12448         Update.
12449
12450 2019-01-10  Tom Tromey  <tom@tromey.com>
12451
12452         * symtab.h (SYMBOL_SET_NAMES): Update.
12453         (symbol_set_names): Update.
12454         (MSYMBOL_SET_NAMES): Update.
12455         * symtab.c (symbol_set_names): Change argument to be an
12456         objfile_per_bfd_storage.
12457         * psymtab.c (add_psymbol_to_bcache): Update.
12458         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12459
12460 2019-01-10  Tom Tromey  <tom@tromey.com>
12461
12462         * symtab.c (create_demangled_names_hash): Change argument to be an
12463         objfile_per_bfd_storage.
12464         (symbol_set_names): Update.
12465
12466 2019-01-10  Tom Tromey  <tom@tromey.com>
12467
12468         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12469         init_psymbol_list.
12470         * psymtab.c (init_psymbol_list): Do nothing if already called.
12471         * psympriv.h (init_psymbol_list): Add comment.
12472         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12473         init_psymbol_list.
12474         * dbxread.c (dbx_symfile_read): Unconditionally call
12475         init_psymbol_list.
12476
12477 2019-01-10  Tom Tromey  <tom@tromey.com>
12478
12479         * xcoffread.c (scan_xcoff_symtab): Update.
12480         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12481         "where".
12482         * mdebugread.c (parse_partial_symbols)
12483         (handle_psymbol_enumerators): Update.
12484         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12485         * dbxread.c (read_dbx_symtab): Update.
12486         * psympriv.h (psymbol_placement): New enum.
12487         (add_psymbol_to_list): Update.
12488
12489 2019-01-10  Tom Tromey  <tom@tromey.com>
12490
12491         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12492         static_psymbols parameters.
12493         (scan_xcoff_symtab): Update.
12494         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12495         static_psymbols parameters.
12496         * psympriv.h (start_psymtab_common): Update.
12497         * mdebugread.c (parse_partial_symbols): Update.
12498         * dwarf2read.c (create_partial_symtab): Update.
12499         * dbxread.c (read_dbx_symtab): Update.
12500         (start_psymtab): Remove global_psymbols and static_psymbols
12501         parameters.
12502
12503 2019-01-10  Tom Tromey  <tom@tromey.com>
12504
12505         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12506         * psymtab.c (allocate_psymtab): Add comment.
12507         * psympriv.h (allocate_psymtab): Add comment.
12508         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12509         initializations.
12510         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12511
12512 2019-01-10  Tom Tromey  <tom@tromey.com>
12513
12514         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12515         Don't declare.
12516         * mipsread.c: Include mdebugread.h.
12517         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12518         Declare.
12519         * elfread.c: Include mdebugread.h.
12520
12521 2019-01-09  Tom Tromey  <tom@tromey.com>
12522
12523         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12524         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12525         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12526         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12527         (psym_lookup_symbol, psym_find_last_source_symtab)
12528         (psym_forget_cached_source_info, psym_print_stats)
12529         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12530         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12531         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12532         (psym_find_compunit_symtab_by_address)
12533         (maintenance_print_psymbols, maintenance_info_psymtabs)
12534         (maintenance_check_psymtabs): Use ranged for.
12535         * psymtab.h (class objfile_psymtabs): New.
12536         (require_partial_symbols): Return objfile_psymtabs.
12537         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12538
12539 2019-01-09  Tom Tromey  <tom@tromey.com>
12540
12541         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12542         (find_pc_mapped_section, list_overlays_command)
12543         (map_overlay_command, unmap_overlay_command)
12544         (simple_overlay_update): Use all_objfiles.
12545         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12546         * printcmd.c (info_symbol_command): Use all_objfiles.
12547         * objfiles.h (ALL_OBJSECTIONS): Remove.
12548         * maint.c (maintenance_translate_address): Use all_objfiles.
12549         * gcore.c (gcore_create_callback): Use all_objfiles.
12550         (objfile_find_memory_regions): Likewise.
12551
12552 2019-01-09  Tom Tromey  <tom@tromey.com>
12553
12554         * symtab.c (find_line_symtab, info_sources_command)
12555         (make_source_files_completion_list): Use objfile_compunits.
12556         * source.c (select_source_symtab): Use objfile_compunits.
12557         * objfiles.h (struct objfile): Update comment.
12558         (ALL_OBJFILES): Remove.
12559         (ALL_FILETABS): Remove.
12560         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12561         objfile_compunits.
12562
12563 2019-01-09  Tom Tromey  <tom@tromey.com>
12564
12565         * symmisc.c (print_objfile_statistics, dump_objfile)
12566         (maintenance_print_symbols): Use compunit_filetabs.
12567         * source.c (forget_cached_source_info_for_objfile): Use
12568         compunit_filetabs.
12569         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12570         (ALL_FILETABS): Use compunit_filetabs.
12571         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12572         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12573
12574 2019-01-09  Tom Tromey  <tom@tromey.com>
12575
12576         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12577         (compunit_filetabs): New.
12578         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12579         compunit_filetabs.
12580         (info_sources_command, make_source_files_completion_list): Remove
12581         declaration.
12582         * symmisc.c (print_objfile_statistics, dump_objfile)
12583         (maintenance_print_symbols): Remove declaration.
12584         (maintenance_info_symtabs): Use compunit_filetabs.
12585         (maintenance_info_line_tables): Likewise.
12586         * source.c (select_source_symtab): Change local variable name.
12587         (forget_cached_source_info_for_objfile): Remove declaration.
12588         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12589         * objfiles.c (objfile_relocate1): Remove declaration.
12590         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12591         declaration.
12592         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12593         * coffread.c (coff_symtab_read): Remove declaration.
12594         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12595         compunit_filetabs.
12596
12597 2019-01-09  Tom Tromey  <tom@tromey.com>
12598
12599         * symtab.c (lookup_objfile_from_block)
12600         (find_pc_sect_compunit_symtab, search_symbols)
12601         (default_collect_symbol_completion_matches_break_on): Use
12602         objfile_compunits.
12603         * objfiles.h (ALL_COMPUNITS): Remove.
12604         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12605         * cp-support.c (add_symbol_overload_list_qualified): Use
12606         objfile_compunits.
12607         * ada-lang.c (ada_collect_symbol_completion_matches)
12608         (ada_add_global_exceptions): Use objfile_compunits.
12609
12610 2019-01-09  Tom Tromey  <tom@tromey.com>
12611
12612         * source.c (select_source_symtab)
12613         (forget_cached_source_info_for_objfile): Remove declaration.
12614         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12615         declaration.
12616         * maint.c (count_symtabs_and_blocks): Remove declaration.
12617         * cp-support.c (add_symbol_overload_list_qualified): Remove
12618         declaration.
12619         * coffread.c (coff_symtab_read): Remove declaration.
12620         * symtab.c (lookup_symbol_in_objfile_symtabs)
12621         (basic_lookup_transparent_type_1): Use objfile_compunits.
12622         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12623         (info_sources_command, search_symbols)
12624         (default_collect_symbol_completion_matches_break_on)
12625         (make_source_files_completion_list): Remove declaration.
12626         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12627         (ada_collect_symbol_completion_matches)
12628         (ada_add_global_exceptions): Remove declaration.
12629         * linespec.c (iterate_over_all_matching_symtabs): Use
12630         objfile_compunits.
12631         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12632         (class objfile_compunits): New.
12633         (ALL_COMPUNITS): Use objfile_compunits.
12634         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12635         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12636         objfile_compunits.
12637         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12638
12639 2019-01-09  Tom Tromey  <tom@tromey.com>
12640
12641         * symtab.c (search_symbols)
12642         (default_collect_symbol_completion_matches_break_on): Use
12643         objfile_msymbols.
12644         * ada-lang.c (ada_lookup_simple_minsym)
12645         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12646         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12647         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12648         objfile_msymbols.
12649         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12650         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12651         * objc-lang.c (find_methods): Use objfile_msymbols.
12652         (info_selectors_command, info_classes_command): Likewise.
12653         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12654         * objfiles.h (class objfile_msymbols): New.
12655         (ALL_OBJFILE_MSYMBOLS): Remove.
12656         (ALL_MSYMBOLS): Remove.
12657
12658 2019-01-09  Tom Tromey  <tom@tromey.com>
12659
12660         * common/next-iterator.h (next_adapter): Add Iterator template
12661         parameter.
12662         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12663         (class all_objfiles_safe): New.
12664         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12665         * objfiles.c (put_objfile_before): Update comment.
12666         (add_separate_debug_objfile): Likewise.
12667         (free_all_objfiles): Use all_objfiles_safe.
12668         (objfile_purge_solibs): Likewise.
12669
12670 2019-01-09  Tom Tromey  <tom@tromey.com>
12671
12672         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12673         (expand_symtab_containing_pc, lookup_static_symbol)
12674         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12675         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12676         all_objfiles.
12677         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12678         * breakpoint.c (create_overlay_event_breakpoint)
12679         (create_longjmp_master_breakpoint)
12680         (create_std_terminate_master_breakpoint)
12681         (create_exception_master_breakpoint): Use all_objfiles.
12682         * linux-thread-db.c (try_thread_db_load_from_pdir)
12683         (has_libpthread): Use all_objfiles.
12684         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12685         * linespec.c (iterate_over_all_matching_symtabs)
12686         (search_minsyms_for_name): Use all_objfiles.
12687         * maint.c (maintenance_info_sections): Use all_objfiles.
12688         * main.c (captured_main_1): Use all_objfiles.
12689         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12690         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12691         * guile/scm-pretty-print.c
12692         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12693         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12694         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12695         (maintenance_print_msymbols): Use all_objfiles.
12696         * source.c (select_source_symtab): Use all_objfiles.
12697         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12698         * symfile.c (remove_symbol_file_command)
12699         (expand_symtabs_matching, map_symbol_filenames): Use
12700         all_objfiles.
12701         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12702         all_objfiles.
12703         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12704         * objc-lang.c (find_methods): Use all_objfiles.
12705         * objfiles.c (have_partial_symbols, have_full_symbols)
12706         (have_minimal_symbols, qsort_cmp)
12707         (default_iterate_over_objfiles_in_search_order): Use
12708         all_objfiles.
12709         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12710         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12711         (maintenance_check_psymtabs): Use all_objfiles.
12712         (ALL_PSYMTABS): Remove.
12713         * compile/compile-object-run.c (do_module_cleanup): Use
12714         all_objfiles.
12715         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12716         * cp-support.c (add_symbol_overload_list_qualified): Use
12717         all_objfiles.
12718         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12719         Use all_objfiles.
12720         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12721         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12722         all_objfiles.
12723         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12724         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12725         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12726         Uses all_objfiles.
12727         * solib.c (solib_read_symbols): Use all_objfiles
12728
12729 2019-01-09  Tom Tromey  <tom@tromey.com>
12730
12731         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12732         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12733         all_objfiles.
12734         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12735         * symmisc.c (print_symbol_bcache_statistics)
12736         (print_objfile_statistics, maintenance_print_objfiles)
12737         (maintenance_info_symtabs, maintenance_check_symtabs)
12738         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12739         all_objfiles.
12740         * source.c (forget_cached_source_info): Use all_objfiles.
12741         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12742         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12743         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12744         * objfiles.c (update_section_map): Use all_objfiles.
12745         (shared_objfile_contains_address_p): Likewise.
12746         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12747         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12748
12749 2019-01-09  Tom Tromey  <tom@tromey.com>
12750
12751         * common/next-iterator.h: New file.
12752         * objfiles.h (class all_objfiles): New.
12753         (struct objfile_iterator): New.
12754
12755 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12756
12757         * NEWS: Move the description of the changed "frame", "select-frame",
12758          and "info frame" commands to the Changed commands section.
12759
12760 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12761
12762         * gdbtypes.c (check_stub_method_group): Remove handling of old
12763         mangling schemes.
12764         * linespec.c (find_methods): Likewise.
12765         * stabsread.c (read_member_functions): Likewise.
12766         * valops.c (search_struct_method): Likewise.
12767         (value_struct_elt_for_reference): Likewise.
12768         * NEWS: Mention this change.
12769
12770 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12771
12772         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12773         print_source_lines.
12774         * source.c (print_source_lines_base): Update line number check.
12775         (print_source_lines): New function.
12776         (source_lines_range::source_lines_range): New function.
12777         * source.h (class source_lines_range): New class.
12778         (print_source_lines): New declaration.
12779
12780 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12781
12782         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12783
12784 2019-01-08  Tom Tromey  <tom@tromey.com>
12785             Simon Marchi  <simon.marchi@ericsson.com>
12786
12787         PR gdb/24060
12788         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12789         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12790         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12791         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12792         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12793         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12794
12795 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12796
12797         * source.c (select_source_symtab): Move header comment to
12798         declaration in source.h.
12799         (forget_cached_source_info_for_objfile): Likewise.
12800         (forget_cached_source_info): Likewise.
12801         (identify_source_line): Likewise.
12802         * source.h (identify_source_line): Move declaration from symtab.h
12803         and add comment from source.c
12804         (print_source_lines): Likewise.
12805         (forget_cached_source_info_for_objfile): Likewise.
12806         (forget_cached_source_info): Likewise.
12807         (select_source_symtab): Likewise.
12808         (enum print_source_lines_flag): Move definition from symtab.h.
12809         * symtab.h (identify_source_line): Move declaration to source.h.
12810         (print_source_lines): Likewise.
12811         (forget_cached_source_info_for_objfile): Likewise.
12812         (forget_cached_source_info): Likewise.
12813         (select_source_symtab): Likewise.
12814         (enum print_source_lines_flag): Move definition to source.h.
12815         * tui/tui-hooks.c: Add 'source.h' include.
12816
12817 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12818
12819         * source.c (print_source_lines_base): Handle requests to print
12820         reverse line number sequences, and guard against empty lines
12821         string.
12822
12823 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12824
12825         * source.c (print_source_lines_base): Fix skip of '\r' if next
12826         character is '\n'.
12827
12828 2019-01-06  Tom Tromey  <tom@tromey.com>
12829
12830         * c-exp.y (struct c_parse_state) <macro_original_text,
12831         expansion_obstack>: New member.
12832         (macro_original_text, expansion_obstack): Remove globals.
12833         (scan_macro_expansion, scanning_macro_expansion)
12834         (finished_macro_expansion): Update.
12835         (scan_macro_cleanup): Remove.
12836         (yylex, c_parse): Update.
12837
12838 2019-01-06  Tom Tromey  <tom@tromey.com>
12839
12840         * c-exp.y (struct c_parse_state) <strings>: New member.
12841         (operator_stoken): Update.
12842
12843 2019-01-06  Tom Tromey  <tom@tromey.com>
12844
12845         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12846         (union type_stack_elt) <typelist_val>: Now a pointer to
12847         std::vector.
12848         (type_stack_cleanup): Don't declare.
12849         (push_typelist): Update.
12850         * parse.c (pop_typelist): Return a std::vector.
12851         (push_typelist): Take a std::vector.
12852         (follow_types): Update.  Do not free args.
12853         (type_stack_cleanup): Remove.
12854         * c-exp.y (struct c_parse_state): New.
12855         (cpstate): New global.
12856         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12857         (nonempty_typelist): Update.
12858         (func_mod): Create a new vector.
12859         (c_parse): Create a c_parse_state.
12860         (check_parameter_typelist): Do not delete params.
12861         (function_method): Update.  Do not delete type_list.
12862
12863 2019-01-06  Tom Tromey  <tom@tromey.com>
12864
12865         PR gdb/28155:
12866         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12867         check_typedef.
12868         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12869         (print_return_value): Likewise.
12870
12871 2019-01-05  Tom Tromey  <tom@tromey.com>
12872
12873         * contrib/cleanup_check.py: Remove.
12874         * contrib/gcc-with-excheck: Remove.
12875         * contrib/exsummary.py: Remove.
12876         * contrib/excheck.py: Remove.
12877
12878 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12879
12880         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12881         NULL. Initialize tpprev to NULL instead of assigning it
12882         to NULL on the next statement.
12883         * windows-nat.c (windows_delete_thread): Remove check for
12884         main_thread_id before printing thread exit notifications.
12885         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12886         Remove thread ID check against main_thread_id.
12887         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12888         windows_delete_thread.
12889         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12890
12891 2019-01-04  Tom Tromey  <tom@tromey.com>
12892
12893         * compile/compile.c (_initialize_compile): Use upper case for
12894         metasyntactic variables.
12895         * symmisc.c (_initialize_symmisc): Use upper case for
12896         metasyntactic variables.
12897         * psymtab.c (_initialize_psymtab): Use upper case for
12898         metasyntactic variables.
12899         * demangle.c (demangle_command): Use upper case for metasyntactic
12900         variables.
12901         (_initialize_demangler): Likewise.
12902         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12903         variables.
12904
12905 2019-01-03  Tom Tromey  <tom@tromey.com>
12906
12907         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12908
12909 2019-01-03  Tom Tromey  <tom@tromey.com>
12910
12911         * python/py-symtab.c (salpy_str): Update.
12912         (struct salpy_sal_object) <symtab>: Now a PyObject.
12913         (salpy_dealloc): Update.
12914         (del_objfile_sal): Use gdbpy_ref.
12915
12916 2019-01-03  Tom Tromey  <tom@tromey.com>
12917
12918         * python/py-type.c (convert_field): Use new_reference.  Return
12919         gdbpy_ref.
12920         (make_fielditem): Return gdbpy_ref.
12921         (typy_fields): Update.
12922         (typy_getitem): Update.
12923         (field_name): Return gdbpy_ref.  Use new_reference.
12924         (typy_iterator_iternext): Update.
12925
12926 2019-01-03  Tom Tromey  <tom@tromey.com>
12927
12928         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12929
12930 2019-01-03  Tom Tromey  <tom@tromey.com>
12931
12932         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12933         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12934         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12935         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12936         (pspy_set_type_printers): Likewise.
12937         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12938         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12939         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12940         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12941         (objfpy_set_type_printers): Likewise.
12942
12943 2019-01-03  Tom Tromey  <tom@tromey.com>
12944
12945         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12946         (gdbpy_print_stack): Use gdbpy_err_fetch.
12947         * python/python-internal.h (class gdbpy_err_fetch): New class.
12948         (class gdbpy_enter) <m_error_type, m_error_value,
12949         m_error_traceback>: Remove.
12950         <m_error>: New member.
12951         (gdbpy_exception_to_string): Don't declare.
12952         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12953         * python/py-value.c (convert_value_from_python): Use
12954         gdbpy_err_fetch.
12955         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12956         gdbpy_exception_to_string.
12957         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12958         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12959         gdbpy_err_fetch.
12960
12961 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12962
12963         * linux-nat.c (delete_lwp_cleanup): Delete.
12964         (struct lwp_deleter): New struct.
12965         (lwp_info_up): New typedef.
12966         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12967         lwp_info_up.
12968
12969 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12970
12971         * linux-fork.c (class scoped_switch_fork_info): New class.
12972         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12973
12974 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12975
12976         * valops.c (find_overload_match): Remove use of null_cleanup, and
12977         calls to do_cleanups.
12978
12979 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12980
12981         * compile/compile-cplus-types.c
12982         (compile_cplus_instance::decl_name): Handle changes to
12983         cp_func_name.
12984         * cp-support.c (cp_func_name): Update header comment, update
12985         return type.
12986         * cp-support.h (cp_func_name): Update return type in declaration.
12987         * valops.c (find_overload_match): Move temp_func local to top
12988         level of function and change its type.  Use temp_func to hold and
12989         delete temporary string obtained from cp_func_name.
12990
12991 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12992
12993         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12994         gdb::char_vector, remove cleanup, and update uses of `msg`.
12995
12996 2019-01-03  Jim Wilson  <jimw@sifive.com>
12997
12998         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12999
13000 2019-01-02  Tom Tromey  <tom@tromey.com>
13001
13002         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13003         (tdesc_parse_xml): Remove cleanups.
13004         * target-descriptions.h (make_cleanup_free_target_description):
13005         Don't declare.
13006         (target_desc_deleter): New struct.
13007         (target_desc_up): New typedef.
13008         * target-descriptions.c (target_desc_deleter::operator()): Rename
13009         from free_target_description.
13010         (make_cleanup_free_target_description): Remove.
13011
13012 2019-01-02  Tom Tromey  <tom@tromey.com>
13013
13014         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13015         constructor, destructor.
13016         (linespec_parser): Remove typedef.
13017         (~linespec_parser): Rename from linespec_parser_delete.
13018         (linespec_lex_to_end, linespec_complete_label)
13019         (linespec_complete): Update.
13020         (decode_line_full): Remove cleanups.
13021         (decode_line_1): Update.
13022
13023 2019-01-02  Tom Tromey  <tom@tromey.com>
13024
13025         * python/python-internal.h (inferior_to_inferior_object): Change
13026         return type.
13027         * python/py-exitedevent.c (create_exited_event_object): Update.
13028         * python/py-inferior.c (inferior_to_inferior_object): Return
13029         gdbpy_ref.
13030         (python_new_inferior, python_inferior_deleted)
13031         (thread_to_thread_object, delete_thread_object)
13032         (build_inferior_list, gdbpy_selected_inferior): Update.
13033         * python/py-infthread.c (create_thread_object): Update.  Also fail
13034         if inferior_to_inferior_object fails.
13035
13036 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13037
13038         * inferior.h (class inferior) <displaced_step_state>: New field.
13039         * infrun.h (struct displaced_step_state): Move here from
13040         infrun.c.  Initialize fields, add constructor.
13041         <inf>: Remove field.
13042         <reset>: New method.
13043         * infrun.c (struct displaced_step_inferior_state): Move to
13044         infrun.h.
13045         (displaced_step_inferior_states): Remove.
13046         (get_displaced_stepping_state): Adust.
13047         (displaced_step_in_progress_any_inferior): Adjust.
13048         (displaced_step_in_progress_thread): Adjust.
13049         (displaced_step_in_progress): Adjust.
13050         (add_displaced_stepping_state): Remove.
13051         (get_displaced_step_closure_by_addr): Adjust.
13052         (remove_displaced_stepping_state): Remove.
13053         (infrun_inferior_exit): Call displaced_step_state.reset.
13054         (use_displaced_stepping): Don't check for NULL.
13055         (displaced_step_prepare_throw): Call
13056         get_displaced_stepping_state.
13057         (displaced_step_fixup): Don't check for NULL.
13058         (prepare_for_detach): Don't check for NULL.
13059
13060 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13061
13062         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13063          in case of call that did not complete.
13064
13065 2019-01-02  Andrey Utkin  <autkin@undo.io>
13066
13067         * symfile.c (find_separate_debug_file): Fix search of debug files for
13068         remote debuggee.
13069
13070 2019-01-02  Tom Tromey  <tom@tromey.com>
13071
13072         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13073         indentation.
13074         * python/py-frame.c (frapy_older): Remove cast.
13075         (frapy_newer): Likewise.
13076         * python/py-breakpoint.c (local_setattro): Remove cast.
13077         * python/py-arch.c (archpy_name): Remove local variable.
13078         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13079
13080 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13081
13082         * unittests/basic_string_view/element_access/char/empty.cc:
13083         Fix year range in copyright header.
13084
13085 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13086
13087         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13088         Delete.
13089         <operator==>: Update with for removed field.
13090         <hash>: Likewise.
13091         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13092         <isa_features>: ...this.
13093         <abi_features>: New field.
13094         (riscv_isa_flen): Update comment.
13095         (riscv_abi_xlen): New declaration.
13096         (riscv_abi_flen): New declaration.
13097         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13098         isa_features.
13099         (riscv_abi_xlen): New function.
13100         (riscv_isa_flen): Update to get answer from isa_features.
13101         (riscv_abi_flen): New function.
13102         (riscv_has_fp_abi): Update to get answer from abi_features.
13103         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13104         xlen and flen.
13105         (riscv_call_info) <xlen, flen>: Update comment.
13106         (riscv_call_arg_struct): Remove invalid assertions
13107         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13108         is removed.
13109         (riscv_gdbarch_init): Gather isa features and abi features
13110         separately, ensure both match on the gdbarch when reusing an old
13111         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13112         a target with 64-bit float hardware.
13113
13114 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13115
13116         * source.c (search_command_helper): Stop reverse search
13117         when line 1 has been searched.
13118
13119 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13120
13121         * record-full.c (record_full_base_target::close): Rewrite
13122         record_full_core_buf_list free logic.
13123
13124 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13125
13126         * break-catch-syscall.c (print_one_catch_syscall): xfree
13127         the last text.
13128
13129 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13130
13131         * top.c (print_gdb_version): Update Copyright year in version
13132         message.
13133
13134 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13135
13136         Update copyright year range in all GDB files.
13137
13138 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13139
13140         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13141
13142 For older changes see ChangeLog-2018.
13143 \f
13144 Local Variables:
13145 mode: change-log
13146 left-margin: 8
13147 fill-column: 74
13148 version-control: never
13149 coding: utf-8
13150 End:
13151