gdb/ChangeLog

   1 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
   4         register sizes.
   5
   6 2019-08-14  Tom Tromey  <tromey@adacore.com>
   7
   8         * darwin-nat.c: Include gdbarch.h.
   9         * darwin-nat-info.c: Include gdbarch.h.
  10
  11 2019-08-13  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
  14         Remove.
  15         * tui/tui-data.c (tui_initialize_static_data): Update.
  16
  17 2019-08-13  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-winsource.h (struct tui_exec_info_window)
  20         <~tui_exec_info_window, maybe_allocate_content, get_content,
  21         m_content>: Remove.
  22         (struct tui_source_window_base) <set_exec_info_content,
  23         show_exec_info_content>: Don't declare.
  24         * tui/tui-winsource.c
  25         (tui_exec_info_window::maybe_allocate_content): Remove.
  26         (tui_source_window_base::update_exec_info): Rename from
  27         set_exec_info_content.
  28         (tui_source_window_base::show_exec_info_content)
  29         (tui_source_window_base::update_exec_info): Remove.
  30
  31 2019-08-13  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
  34         declare.
  35         * tui/tui-winsource.c (tui_update_source_window_as_is)
  36         (tui_update_source_windows_with_addr, tui_erase_source_content):
  37         Update.
  38         (tui_clear_exec_info_content): Remove.
  39
  40 2019-08-13  Tom Tromey  <tom@tromey.com>
  41
  42         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
  43         declare.
  44         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
  45         call tui_erase_exec_info_content.
  46         (tui_clear_exec_info_content): Rename from
  47         tui_erase_exec_info_content.
  48         (tui_clear_exec_info_content): Delete.
  49
  50 2019-08-13  Tom Tromey  <tom@tromey.com>
  51
  52         * tui/tui-winsource.h (struct tui_source_window_base)
  53         <show_exec_info_content>: Declare.
  54         (tui_show_exec_info_content): Don't declare.
  55         * tui/tui-winsource.c
  56         (tui_source_window_base::show_exec_info_content): Rename from
  57         tui_show_exec_info_content.
  58         (tui_source_window_base::update_exec_info): Update.
  59
  60 2019-08-13  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
  63         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
  64         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
  65         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
  66         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
  67         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
  68         ... here.
  69
  70 2019-08-13  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-winsource.h (struct tui_source_window_base)
  73         <update_exec_info>: Declare.
  74         (tui_update_exec_info): Don't declare.
  75         * tui/tui-winsource.c (tui_update_source_window_as_is)
  76         (tui_source_window_base::refresh_all)
  77         (tui_update_all_breakpoint_info): Update.
  78         (tui_source_window_base::update_exec_info): Rename from
  79         tui_update_exec_info.
  80         * tui/tui-stack.c (tui_show_frame_info): Update.
  81
  82 2019-08-13  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-winsource.h (struct tui_source_window_base)
  85         <set_exec_info_content>: Declare.
  86         (tui_set_exec_info_content): Don't declare.
  87         * tui/tui-winsource.c
  88         (tui_source_window_base::set_exec_info_content): Rename from
  89         tui_set_exec_info_content.
  90         (tui_update_exec_info): Update.
  91
  92 2019-08-13  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-winsource.h (struct tui_source_window_base)
  95         <show_source_content>: Declare.
  96         (tui_show_source_content): Don't declare.
  97         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  98         (tui_source_window_base::show_source_content): Rename from
  99         tui_show_source_content.
 100         (tui_source_window_base::refresh_all): Update.
 101         * tui/tui-layout.c (show_source_disasm_command)
 102         (show_source_or_disasm_and_command): Update.
 103
 104 2019-08-13  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-winsource.c (tui_erase_source_content)
 107         (tui_show_source_content, tui_source_window_base::refresh_all):
 108         Update.
 109         * tui/tui-wingeneral.h
 110         (tui_check_and_display_highlight_if_needed): Don't declare.
 111         * tui/tui-wingeneral.c
 112         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 113         check_and_display_highlight_if_needed.
 114         * tui/tui-win.c (tui_rehighlight_all)
 115         (tui_win_info::make_visible_with_new_height): Update.
 116         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 117         (tui_data_window::erase_data_content)
 118         (tui_data_window::display_all_data): Update.
 119         * tui/tui-data.h (struct tui_win_info)
 120         <check_and_display_highlight_if_needed>: Declare.
 121
 122 2019-08-13  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui-win.c (tui_resize_all): Call
 125         tui_delete_invisible_windows.
 126         * tui/tui-layout.c (show_layout): Call
 127         tui_delete_invisible_windows.
 128         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 129         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 130
 131 2019-08-13  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 134         tui_add_win_to_layout.
 135
 136 2019-08-13  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 139         * tui/tui-layout.c (tui_default_win_height): Now static.
 140
 141 2019-08-13  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 144         single switch.
 145         (show_source_disasm_command, show_source_or_disasm_and_command):
 146         Don't check current layout.
 147
 148 2019-08-13  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-wingeneral.c (make_all_visible): Remove.
 151         (tui_make_all_invisible): Simplify.
 152         * tui/tui-layout.c (tui_make_all_invisible): Move from
 153         tui-wingeneral.c; simplify.
 154         (show_layout): Hoist call to tui_make_all_invisible.
 155         (show_data): Don't call tui_make_all_invisible.
 156
 157 2019-08-13  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 160         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 161
 162 2019-08-13  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 165         tui-data.c.
 166         (show_source_disasm_command, show_data)
 167         (show_source_or_disasm_and_command): Don't use
 168         tui_set_current_layout_to.
 169         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 170         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 171         tui-layout.c.
 172         (tui_set_current_layout_to): Remove.
 173
 174 2019-08-13  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-layout.c (tui_set_layout): Update.
 177         * tui/tui-data.h (struct tui_layout_def): Remove.
 178         (tui_layout_def): Don't declare.
 179         * tui/tui-data.c (layout_def): Remove.
 180         (tui_layout_def): Remove.
 181
 182 2019-08-13  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-winsource.h (struct tui_source_window_base)
 185         <clear_detail>: No longer "override".
 186         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 187         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 188         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 189         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 190         Remove.
 191         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 192
 193 2019-08-13  Tom Tromey  <tromey@adacore.com>
 194
 195         * tracepoint.c: Don't include readline.h or history.h.
 196
 197 2019-08-12  Tom Tromey  <tom@tromey.com>
 198
 199         * configure: Rebuild.
 200         * configure.ac: Check for readline 7.
 201         * NEWS: Mention readline 7 requirement.
 202         * README: Update.
 203
 204 2019-08-12  Tom Tromey  <tom@tromey.com>
 205
 206         * mingw-hdep.c (gdb_select): Remove readline hack.
 207
 208 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 209
 210         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 211         when the function fails.
 212
 213 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 214
 215         * s390-tdep.c (s390_type_align): New function.
 216         (s390_gdbarch_init): Set it as type_align gdbarch method.
 217
 218 2019-08-09  Tom de Vries  <tdevries@suse.de>
 219
 220         PR gdb/24591
 221         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 222         pc_low with relocation offset.
 223
 224 2019-08-07  Tom Tromey  <tromey@adacore.com>
 225
 226         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 227         (print_frame_args): Update.
 228         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 229         Update.
 230         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 231         * frame.h (struct frame_arg): Add initializers.
 232         <error>: Now a unique_xmalloc_ptr.
 233
 234 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 235
 236         * NEWS: Expand the Pointer Authentication entry.
 237         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 238         (aarch64_frame_unmask_lr): ... to this.
 239         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 240         Call aarch64_frame_unmask_lr.
 241         * frame.c (struct frame_info): Add "masked" variable.
 242         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 243         (fprint_frame): Check for masked pc.
 244         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 245         declarations.
 246         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 247         * stack.c (print_frame): Check for masked pc.
 248
 249 2019-08-06  Tom Tromey  <tom@tromey.com>
 250
 251         * stabsread.c (patch_block_stabs, read_one_struct_field)
 252         (read_enum_type): Use obstack_strndup.
 253         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 254         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 255         * dwarf2read.c (guess_full_die_structure_name)
 256         (anonymous_struct_prefix): Use obstack_strndup.
 257         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 258         * c-exp.y (yylex): Use obstack_strndup.
 259         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 260         (write_var_or_type): Use obstack_strndup.
 261
 262 2019-08-06  Tom Tromey  <tom@tromey.com>
 263
 264         * symfile.c (reread_symbols): Use obstack_strdup.
 265         * stabsread.c (read_type): Use obstack_strdup.
 266         * gdb_obstack.h (obstack_strdup): New overload.
 267         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 268         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 269         (dwarf2_canonicalize_name): Use obstack_strdup.
 270         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 271         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 272         Use obstack_strdup.
 273
 274 2019-08-06  Tom Tromey  <tom@tromey.com>
 275
 276         * gdb_obstack.h (obstack_strdup): Define.
 277         * gdb_obstack.c (obstack_strdup): Don't define.
 278
 279 2019-08-06  Tom Tromey  <tom@tromey.com>
 280
 281         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 282         obstack_strdup.
 283         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 284         obstack_strdup.
 285         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 286         * stabsread.c (common_block_start): Use obstack_strdup.
 287         * objfiles.c (set_objfile_main_name, objfile): Use
 288         obstack_strdup.
 289         * namespace.c (add_using_directive): Use obstack_strdup.
 290         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 291         * jit.c (finalize_symtab): Use obstack_strdup.
 292         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 293         (guess_partial_die_structure_name, partial_die_info::fixup)
 294         (dwarf2_name): Use obstack_strdup.
 295         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 296         obstack_strdup.
 297         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 298         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 299         obstack_strdup.
 300         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 301
 302 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 303
 304         * unittests/help-doc-selftests.c: New file.
 305         * Makefile.in: Add the new file.
 306
 307 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 308
 309         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 310         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 311         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 312         the trailing '.' is not output, and the first character is uppercased.
 313         (print_help_for_command): Update call to print_doc_line.
 314         (print_doc_of_command): Likewise.
 315         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 316         * cli/cli-option.c (append_indented_doc): Do not append newline.
 317         (build_help_option): Append newline after first appended_indented_doc
 318         only if a second call is done.
 319         (build_help): Append 2 new lines before each option, except the first
 320         one.
 321         * compile/compile.c (_initialize_compile): Add new lines after
 322         %OPTIONS%, when not at the end of the help.
 323         Change help doc or code
 324         producing the help doc to respect the invariants.
 325         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 326         Also removed the new line after 'Options:', as all other commands
 327         do not put an empty line between 'Options:' and the first option.
 328         * printcmd.c (_initialize_printcmd): Likewise.
 329         * stack.c (_initialize_stack): Likewise.
 330         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 331         incorrectly telling COMMAND is optional.
 332         * ada-lang.c (_initialize_ada_language): Change help doc or code
 333         producing the help doc to respect the invariants.
 334         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 335         * breakpoint.c (_initialize_breakpoint): Likewise.
 336         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 337         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 338         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 339         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 340         _initialize_cli_style): Likewise.
 341         * corelow.c (core_target_info): Likewise.
 342         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 343         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 344         * filesystem.c (_initialize_filesystem): Likewise.
 345         * frame.c (_initialize_frame): Likewise.
 346         * gnu-nat.c (add_task_commands): Likewise.
 347         * infcall.c (_initialize_infcall): Likewise.
 348         * infcmd.c (_initialize_infcmd): Likewise.
 349         * interps.c (_initialize_interpreter): Likewise.
 350         * language.c (_initialize_language): Likewise.
 351         * linux-fork.c (_initialize_linux_fork): Likewise.
 352         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 353         * maint.c (_initialize_maint_cmds): Likewise.
 354         * memattr.c (_initialize_mem): Likewise.
 355         * printcmd.c (_initialize_printcmd): Likewise.
 356         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 357         _RegEx): Likewise.
 358         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 359         * record-btrace.c (_initialize_record_btrace): Likewise.
 360         * record-full.c (_initialize_record_full): Likewise.
 361         * record.c (_initialize_record): Likewise.
 362         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 363         * regcache.c (_initialize_regcache): Likewise.
 364         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 365         _initialize_remote): Likewise.
 366         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 367         * serial.c (_initialize_serial): Likewise.
 368         * skip.c (_initialize_step_skip): Likewise.
 369         * source.c (_initialize_source): Likewise.
 370         * stack.c (_initialize_stack): Likewise.
 371         * symfile.c (_initialize_symfile): Likewise.
 372         * symtab.c (_initialize_symtab): Likewise.
 373         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 374         * top.c (init_main): Likewise.
 375         * tracefile-tfile.c (tfile_target_info): Likewise.
 376         * tracepoint.c (_initialize_tracepoint): Likewise.
 377         * tui/tui-win.c (_initialize_tui_win): Likewise.
 378         * utils.c (add_internal_problem_command): Likewise.
 379         * valprint.c (value_print_option_defs): Likewise.
 380
 381 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 382
 383         PR build/24886
 384         * configure.ac: Drop enable-libmcheck support.
 385         * configure, config.in: Rebuild.
 386         * libmcheck.m4: Remove.
 387         * acinclude.m4: Don't include it.
 388         * Makefile.in: Don't distribute it.
 389         * top.c (print_gdb_configuration): Don't mention it.
 390
 391 2019-08-06  Tom Tromey  <tom@tromey.com>
 392
 393         * utils.c (set_output_style): Sometimes pass stream to
 394         emit_style_escape.
 395         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 396         * record-btrace.c (btrace_insn_history): Update.
 397         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 398         method.
 399         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 400         Update initializers.
 401         <m_uiout>: New field.
 402         <m_di>: Move lower.
 403         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 404         Remove "uiout" parameter.
 405         (dump_insns): Update.
 406         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 407         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 408
 409 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 410
 411         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 412         (error_in_psymtab_expansion): Likewise.
 413         (lookup_symbol_via_quick_fns): Likewise.
 414         (basic_lookup_transparent_type_quick): Likewise.
 415         (basic_lookup_transparent_type_1): Likewise.
 416
 417 2019-08-06  Tom Tromey  <tromey@adacore.com>
 418
 419         * source.c (last_source_error): Now bool.
 420         (print_source_lines_base): Make "noprint" bool.  Only open
 421         source file when last_source_visited changes.
 422
 423 2019-08-06  Tom Tromey  <tromey@adacore.com>
 424
 425         * annotate.c (annotate_source_line): Use g_source_cache.
 426         * source-cache.c (source_cache::get_plain_source_lines): Change
 427         parameters.  Populate m_offset_cache.
 428         (source_cache::ensure): New method.
 429         (source_cache::get_line_charpos): New method.
 430         (extract_lines): Move lower.  Change parameters.
 431         (source_cache::get_source_lines): Move lower.
 432         * source-cache.h (class source_cache): Update comment.
 433         <get_line_charpos>: New method.
 434         <get_source_lines>: Update comment.
 435         <clear>: Clear m_offset_cache.
 436         <get_plain_source_lines>: Change parameters.
 437         <ensure>: New method
 438         <m_offset_cache>: New member.
 439         * source.c (forget_cached_source_info_for_objfile): Update.
 440         (info_source_command): Use g_source_cache.
 441         (find_source_lines, open_source_file_with_line_charpos): Remove.
 442         (print_source_lines_base, search_command_helper): Use g_source_cache.
 443         * source.h (open_source_file_with_line_charpos): Don't declare.
 444         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 445         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 446         Use g_source_cache.
 447
 448 2019-08-06  Tom Tromey  <tromey@adacore.com>
 449
 450         * source-cache.c (source_cache::get_plain_source_lines):
 451         Remove "first_line" and "last_line" parameters.
 452         (source_cache::get_source_lines): Cache plain text.
 453         * source-cache.h (class source_cache)
 454         <get_plain_source_lines>: Update.
 455
 456 2019-08-06  Tom Tromey  <tromey@adacore.com>
 457
 458         * source-cache.c (extract_lines): No longer a method.
 459         Changed type of parameter.  Include final newline.
 460         (selftests::extract_lines_test): New function.
 461         (_initialize_source_cache): Likewise.
 462         * source-cache.h (class source_cache)
 463         <extract_lines>: Don't declare.
 464
 465 2019-08-06  Tom Tromey  <tromey@adacore.com>
 466
 467         * breakpoint.c (init_breakpoint_sal): Update.
 468         (breakpoint): Update.
 469         * breakpoint.h (struct breakpoint) <filter>: Now a
 470         unique_xmalloc_ptr.
 471
 472 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 473
 474         * NEWS: Mention dictionary access on blocks.
 475         * python/py-block.c (blpy_getitem): New function.
 476         (block_object_as_mapping): New struct.
 477         (block_object_type): Use new struct for tp_as_mapping field.
 478
 479 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 480
 481         * objfiles.h (objfile): Add a comment describing partial symbols.
 482
 483 2019-08-05  Tom Tromey  <tromey@adacore.com>
 484
 485         * compile/compile.c (_initialize_compile): Use _(), not N_().
 486         * thread.c (_initialize_thread): Use _(), not N_().
 487         * stack.c (_initialize_stack): Use _(), not N_().
 488         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 489
 490 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 491
 492         * dwarf2read.c (struct dw2_symtab_iterator):
 493         <want_specific_block>: Remove.
 494         <block_index>: Change type to gdb::optional.
 495         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 496         change type of BLOCK_INDEX parameter to gdb::optional.
 497         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 498         (dw2_lookup_symbol): Don't pass argument for
 499         WANT_SPECIFIC_BLOCK.
 500         (dw2_expand_symtabs_for_function): Don't pass argument for
 501         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 502         (class dw2_debug_names_iterator)
 503         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 504         parameter, change BLOCK_INDEX type to gdb::optional.
 505         <m_want_specific_block>: Remove.
 506         <m_block_index>: Change type to gdb::optional.
 507         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 508         gdb::optional.  Re-write in function of gdb::optional.
 509         (dw2_debug_names_lookup_symbol): Don't pass argument for
 510         WANT_SPECIFIC_BLOCK.
 511         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 512         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 513         BLOCK_INDEX.
 514
 515 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 516
 517         * NEWS: Mention changes to "info sources" command.
 518
 519 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 520
 521         * symtab.c (filename_partial_match_opts): New struct type.
 522         (struct output_source_filename_data): New members
 523         regexp, c_regexp, partial_match.
 524         (output_source_filename): Use new members to decide to print file.
 525         (info_sources_option_defs): New variable.
 526         (make_info_sources_options_def_group, print_info_sources_header,
 527         info_sources_command_completer):
 528         New functions.
 529         (info_sources_command): Read new optional arguments.
 530         (_initialize_symtab): Update info sources help.
 531
 532 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 533
 534         * ada-lang.c (exception_support_info_v0): Renamed from...
 535         (default_exception_support_info): ... this.  Create new
 536         definition for v1.
 537         (ada_has_this_exception_support): Look up catch_handlers_sym.
 538         (ada_exception_support_info_sniffer): Try v0 after default.
 539
 540 2019-08-01  Tom Tromey  <tromey@adacore.com>
 541
 542         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 543         gdbarch.h.
 544
 545 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 546
 547         * s12z-tdep.c: Fix include path for s12z-opc.h.
 548
 549 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 550
 551         * NEWS: Require GNU make 3.82.
 552
 553 2019-07-16  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 556         declare.
 557
 558 2019-07-30  Tom Tromey  <tromey@adacore.com>
 559
 560         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 561
 562 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 563
 564         * printcmd.c (print_address_symbolic): Print negative offsets.
 565         (build_address_symbolic): Force signed arithmetic when computing
 566         offset.
 567
 568 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 569
 570         PR/24474: Add a function to lookup static variables.
 571         * NEWS: Mention this new function.
 572         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 573         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 574         * python/python.c (python_GdbMethods): Add new function.
 575
 576 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 577
 578         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 579         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 580         (objfpy_lookup_static_symbol): New function.
 581         (objfile_object_methods): Add new functions.
 582
 583 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 584
 585         * NEWS: Mention 'set|show print frame-info'.  Mention new
 586         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 587         backtrace argument.  Mention that python frame filtering code
 588         is now consistent with what 'backtrace' command prints.
 589
 590 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 591
 592         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 593         comments.
 594         (print_frame_info_auto, print_frame_info_source_line,
 595         print_frame_info_location, print_frame_info_source_and_location,
 596         print_frame_info_location_and_address, print_frame_info_short_location):
 597         New declarations.
 598         (struct frame_print_options): New member print_frame_info.
 599         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 600         * stack.h (get_user_print_what_frame_info): New declaration.
 601         (frame_show_address): New declaration.
 602         * stack.c (print_frame_arguments_choices): New value 'presence'.
 603         (print_frame_info_auto, print_frame_info_source_line,
 604         print_frame_info_location, print_frame_info_source_and_location,
 605         print_frame_info_location_and_address, print_frame_info_short_location,
 606         print_frame_info_choices, print_frame_info_print_what): New definitions.
 607         (print_frame_args): Only print dots for args if print frame-arguments
 608         is 'presence'.
 609         (frame_print_option_defs): New element for "frame-info".
 610         (get_user_print_what_frame_info): New function.
 611         (frame_show_address): Make non static.  Move comment to stack.h.
 612         (print_frame_info_to_print_what): New function.
 613         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 614         to decide what to print.
 615         (backtrace_command_1): Handle the new print_frame_arguments_presence
 616         value.
 617         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 618         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 619         (py_print_frame): In non-mi mode, use LOCATION as default for
 620         print_what, similarly to frame information printed directly by
 621         backtrace command. Handle frame-info user option in non MI mode.
 622
 623 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 624
 625         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 626         Add case for debugging 32-bit target on 64-bit host.  Revise
 627         comment.
 628
 629 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 630
 631         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 632         instead of find_function_entry_range_from_pc.
 633
 634 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 635
 636         * stack.c (find_frame_funname): Remove code which preferred
 637         minsym over symtab sym in "certain pathological cases".
 638
 639         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 640         parameter.  Change type of "do_demangle" to bool.
 641         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 642         Pass suitable "prefer_sym_over_minsym" flag to
 643         build_address_symbolic().  Don't output "+" for negative offsets.
 644         * printcmd.c (print_address_symbolic): Update invocation of
 645         build_address_symbolic to include a "prefer_sym_over_minsym"
 646         flag.
 647         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 648         Restrict cases in which use of minimal symbol is preferred to that
 649         of a found symbol.  Update comments.
 650
 651         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 652         for entry pc when entry pc is out of range for that FDE.
 653
 654 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 655
 656         PR gdb/24839:
 657         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 658         type.
 659
 660 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 661
 662         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 663         this function's Python signature.
 664
 665
 666 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 667
 668         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 669         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 670         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 671         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 672         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 673
 674
 675 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 676
 677         * h8300-tdep.c (h8300_register_name_common): New.
 678         h8300_register_name): Use h8300_register_name_common.
 679         (h8300s_register_name): Likewise.
 680         (h8300sx_register_name): Likewise.
 681         (h8300h_register_nam): New.
 682         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 683
 684
 685 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 686
 687         * arm-tdep.c (arm_skip_cmse_entry): New function.
 688         (arm_is_sgstubs_section): New function.
 689         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 690
 691 2019-07-22  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 694         Don't self-assign.
 695
 696 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 697
 698         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 699         type_print.
 700
 701 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 702
 703         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 704         so that GDB doesn't match any msymbols when searching in the
 705         TYPES_DOMAIN.
 706         (print_symbol_info): Print using typedef_print or type_print based
 707         on the type of the symbol.  Add updated FIXME comment moved from...
 708         (_initialize_symtab): ... move and update FIXME comment to above.
 709
 710 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 711
 712         * NEWS: Mention adding -q option to "info types".
 713         * symtab.c (struct info_types_options): New struct.
 714         (info_types_options_defs): New variable.
 715         (make_info_types_options_def_group): New function.
 716         (info_types_command): Use gdb::option framework to parse options.
 717         (info_types_command_completer): New function.
 718         (_initialize_symtab): Extend the help text on "info types" and
 719         register command completer.
 720
 721 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 722
 723         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 724         (lookup_symbol_in_objfile): Change int to block_enum and add a
 725         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 726
 727 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 728
 729         * MAINTAINERS (Write After Approval): Add self.
 730
 731 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 732
 733         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 734         instruction to the dummy code region.
 735
 736 2019-07-19  Tom Tromey  <tromey@adacore.com>
 737
 738         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 739         (ARGSUSED, PARAMS, __func__): Remove rules.
 740
 741 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 742
 743         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 744         * features/arm/arm-with-iwmmxt.c: Remove.
 745         * features/arm/arm-with-iwmmxt.xml: Remove.
 746         * features/arm/arm-with-m-fpa-layout.c: Remove.
 747         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 748         * features/arm/arm-with-m-vfp-d16.c: Remove.
 749         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 750         * features/arm/arm-with-m.c: Remove.
 751         * features/arm/arm-with-m.xml: Remove.
 752         * features/arm/arm-with-neon.c: Remove.
 753         * features/arm/arm-with-neon.xml: Remove.
 754         * features/arm/arm-with-vfpv2.c: Remove.
 755         * features/arm/arm-with-vfpv2.xml: Remove.
 756         * features/arm/arm-with-vfpv3.c: Remove.
 757         * features/arm/arm-with-vfpv3.xml: Remove.
 758
 759 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 760
 761         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 762
 763 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 764
 765         * arch/aarch32.c (aarch32_create_target_description): Create
 766         target descriptions using features.
 767         * arch/arm.c (arm_create_target_description)
 768         (arm_create_mprofile_target_description): Likewise.
 769         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 770
 771 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 772
 773         * Makefile.in: Add new files.
 774         * aarch32-tdep.c: New file.
 775         * aarch32-tdep.h: New file.
 776         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 777         Call aarch32_read_description.
 778         * arch/aarch32.c: New file.
 779         * arch/aarch32.h: New file.
 780         * arch/arm.c (arm_create_target_description)
 781         (arm_create_mprofile_target_description): New function.
 782         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 783         (arm_create_target_description)
 784         (arm_create_mprofile_target_description): New declaration.
 785         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 786         read_description functions.
 787         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 788         Likewise.
 789         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 790         * arm-tdep.c (tdesc_arm_list): New variable.
 791         (arm_register_g_packet_guesses): Call create description functions.
 792         (arm_read_description) (arm_read_mprofile_description): New
 793         function.
 794         * arm-tdep.h (arm_read_description)
 795         (arm_read_mprofile_description): Add declaration.
 796         * configure.tgt: Add new files.
 797
 798 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 799
 800         * top.c (new_ui_command): Open specified terminal just once.
 801
 802 2019-07-18  Tom Tromey  <tromey@adacore.com>
 803
 804         * symtab.c (main_name): Constify return type.
 805         * symfile.c (set_initial_language): Update.
 806         * symtab.h (main_name): Constify return type.
 807
 808 2019-07-17  Tom Tromey  <tom@tromey.com>
 809
 810         * tui/tui-winsource.c (tui_update_source_window)
 811         (tui_update_source_window_as_is)
 812         (tui_update_source_windows_with_line): Remove return.
 813         * tui/tui-disasm.c (tui_show_disassem)
 814         (tui_show_disassem_and_update_source): Remove return.
 815         * tui/tui.c (tui_reset): Remove return.
 816         * tui/tui-wingeneral.c
 817         (tui_check_and_display_highlight_if_needed): Remove return.
 818
 819 2019-07-17  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 822
 823 2019-07-17  Tom Tromey  <tom@tromey.com>
 824
 825         * tui/tui-winsource.h (struct tui_exec_info_window)
 826         (struct tui_source_window_base): Move from tui-data.h.
 827         * tui/tui-winsource.c: Move many method definitions from
 828         elsewhere.  Remove "structuring" comments.
 829         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 830         (tui_source_window_base::refresh_window): Move to
 831         tui-winsource.c.
 832         * tui/tui-win.c (tui_source_window_base::refresh_all)
 833         (tui_source_window_base::update_tab_width)
 834         (tui_source_window_base::set_new_height)
 835         (tui_source_window_base::do_make_visible_with_new_height): Move to
 836         tui-winsource.c.
 837         * tui/tui-source.h: Update.
 838         * tui/tui-source.c (tui_source_window_base::reset): Move to
 839         tui-winsource.c.
 840         * tui/tui-disasm.h: Update.
 841         * tui/tui-data.h (struct tui_exec_info_window): Move to
 842         tui-winsource.h.
 843         (struct tui_source_window_base): Likewise.
 844         * tui/tui-data.c (tui_source_window_base::clear_detail)
 845         (tui_source_window_base, ~tui_source_window_base): Move to
 846         tui-winsource.c.
 847
 848 2019-07-17  Tom Tromey  <tom@tromey.com>
 849
 850         * tui/tui-win.c (tui_resize_all)
 851         (tui_source_window_base::update_tab_width)
 852         (tui_adjust_win_heights): Update.
 853         (tui_win_info::make_invisible_and_set_new_height): Rename from
 854         make_invisible_and_set_new_height.
 855         * tui/tui-data.h (struct tui_win_info)
 856         <make_invisible_and_set_new_height>: New method.
 857
 858 2019-07-17  Tom Tromey  <tom@tromey.com>
 859
 860         * tui/tui.c: Update.
 861         * tui/tui-source.h (struct tui_source_window): Move from
 862         tui-data.h.
 863         * tui/tui-layout.c: Update.
 864         * tui/tui-disasm.c: Update.
 865         * tui/tui-data.h (struct tui_source_window): Move to
 866         tui-source.h.
 867
 868 2019-07-17  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 871         tui-data.h.
 872         * tui/tui-data.h (struct tui_disasm_window): Move to
 873         tui-disasm.h.
 874
 875 2019-07-17  Tom Tromey  <tom@tromey.com>
 876
 877         * tui/tui-regs.h (struct tui_data_item_window): Move from
 878         tui-data.h.
 879         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 880         * tui/tui-data.h (struct tui_data_item_window): Move to
 881         tui-regs.h.
 882         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 883
 884 2019-07-17  Tom Tromey  <tom@tromey.com>
 885
 886         * tui/tui.c: Update.
 887         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 888         (tui_cmd_window::max_height): Move to tui-command.c.
 889         * tui/tui-layout.c: Update.
 890         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 891         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 892         tui-command.c.
 893         * tui/tui-command.h (struct tui_cmd_window): Move from
 894         tui-data.h.
 895         * tui/tui-command.c: Remove "structuring" comments.
 896         (tui_cmd_window::clear_detail)
 897         (tui_cmd_window::do_make_visible_with_new_height)
 898         (tui_cmd_window::max_height): Move from elsewhere.
 899
 900 2019-07-17  Tom Tromey  <tom@tromey.com>
 901
 902         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 903         Now static.
 904         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 905         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 906
 907 2019-07-17  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui.c: Update.
 910         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 911         tui-regs.c.
 912         * tui/tui-windata.h: Remove file.
 913         * tui/tui-windata.c: Remove file.
 914         * tui/tui-win.c (tui_data_window::set_new_height)
 915         (tui_data_window::do_make_visible_with_new_height): Move to
 916         tui-regs.c.
 917         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 918         * tui/tui-regs.c: Remove "structuring" comments.
 919         (tui_data_window::first_data_item_displayed)
 920         (tui_data_window::delete_data_content_windows)
 921         (tui_data_window::erase_data_content)
 922         (tui_data_window::display_all_data)
 923         (tui_data_window::refresh_all)
 924         (tui_data_window::do_scroll_vertical)
 925         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 926         (tui_data_window::do_make_visible_with_new_height)
 927         (tui_data_window::refresh_window): Move from elsewhere.
 928         (_initialize_tui_regs): Move to end of file.
 929         * tui/tui-layout.c: Update.
 930         * tui/tui-hooks.c: Update.
 931         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 932         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 933         tui-regs.c.
 934         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 935
 936 2019-07-17  Tom Tromey  <tom@tromey.com>
 937
 938         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 939         seen.
 940
 941 2019-07-17  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-win.c (tui_source_window_base::set_new_height)
 944         (tui_source_window_base::do_make_visible_with_new_height): Use
 945         m_has_locator field directly.
 946         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 947         method.
 948         (struct tui_source_window_base) <has_locator>: Likewise.
 949
 950 2019-07-17  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 953         Don't declare.
 954         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 955         Remove.
 956         * tui/tui-win.c (tui_source_window_base::set_new_height)
 957         (tui_source_window_base::set_new_height)
 958         (make_invisible_and_set_new_height)
 959         (tui_source_window_base::do_make_visible_with_new_height)
 960         (tui_source_window_base::do_make_visible_with_new_height):
 961         Update.
 962         * tui/tui-layout.c (show_source_disasm_command, show_data)
 963         (show_source_or_disasm_and_command): Update.
 964         * tui/tui-layout.c (show_layout): Update.
 965
 966 2019-07-17  Tom Tromey  <tom@tromey.com>
 967
 968         * tui/tui-layout.c (make_data_window): Remove.
 969         (show_data): Unify creation and re-initialization cases.
 970
 971 2019-07-17  Tom Tromey  <tom@tromey.com>
 972
 973         * tui/tui-layout.c (make_source_window, make_disasm_window):
 974         Remove.
 975         (show_data): Unify creation and re-initialization cases.
 976
 977 2019-07-17  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-layout.c (make_command_window): Remove.
 980         (show_source_disasm_command, show_source_or_disasm_and_command):
 981         Unify creation and re-initialization cases.
 982
 983 2019-07-17  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 986         creation and re-initialization cases.
 987
 988 2019-07-17  Tom Tromey  <tom@tromey.com>
 989
 990         * tui/tui-regs.c (tui_get_register): Return void.
 991
 992 2019-07-17  Tom Tromey  <tom@tromey.com>
 993
 994         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 995         Simplify.
 996
 997 2019-07-17  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1000         resetting.
1001
1002 2019-07-17  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1005         * tui/tui-regs.c (tui_reg_layout): New function.
1006         (tui_show_registers, tui_reg_command): Use it.
1007         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1008         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1009         parameters.
1010         (tui_layout_command): Remove.
1011
1012 2019-07-17  Tom Tromey  <tom@tromey.com>
1013
1014         * tui/tui-layout.h (tui/tui-layout): Return void.
1015         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1016
1017 2019-07-17  Tom Tromey  <tom@tromey.com>
1018
1019         * tui/tui-layout.c (show_source_disasm_command, show_data):
1020         Update.
1021         (reset_locator): Remove.
1022         (show_source_or_disasm_and_command): Update.
1023
1024 2019-07-17  Tom Tromey  <tom@tromey.com>
1025
1026         * tui/tui-source.c (tui_source_window_base::reset): Remove
1027         win_type parameter.
1028         * tui/tui-layout.c (make_command_window, make_source_window)
1029         (make_disasm_window, make_data_window)
1030         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1031         (reset_locator, show_source_or_disasm_and_command): Update.
1032         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1033         win_type parameter.
1034         (struct tui_source_window_base) <reset>: Likewise.
1035
1036 2019-07-17  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-layout.c (show_source_disasm_command): Use
1039         reset_locator.
1040         (reset_locator): New function.
1041         (init_and_make_win): Remove.
1042         (show_source_or_disasm_and_command): Use reset_locator.
1043
1044 2019-07-17  Tom Tromey  <tom@tromey.com>
1045
1046         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1047         condition.
1048         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1049         Remove condition.
1050         * tui/tui-source.c (tui_source_window_base::reset): New method.
1051         * tui/tui-layout.c (make_command_window): Don't call
1052         init_and_make_win.
1053         (make_source_window, make_disasm_window): Don't call
1054         make_source_or_disasm_window.
1055         (make_data_window): Don't call init_and_make_win.  Change calling
1056         convention.
1057         (show_source_disasm_command, show_data): Simplify.
1058         (make_source_or_disasm_window): Remove.
1059         (show_source_or_disasm_and_command): Simplify.
1060         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1061         (struct tui_source_window_base) <reset>: Likewise.
1062         <execution_info>: Remove initializer.
1063         * tui/tui-data.c (tui_source_window_base): Initialize
1064         execution_info.
1065
1066 2019-07-17  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1069         variable.
1070
1071 2019-07-17  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui.c (tui_rl_other_window): Update.
1074         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1075         superclass method first.  Always iterate over regs_content.
1076         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1077         method.
1078         * tui/tui-win.c (tui_set_focus_command): Update.
1079
1080 2019-07-17  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui-win.c (tui_set_focus_command): Rename from
1083         tui_set_focus.  Call tui_enable.
1084         (tui_set_focus_command): Remove.
1085
1086 2019-07-17  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1089         refresh_window.
1090         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1091         touchwin.
1092         (tui_data_window::refresh_window): Call refresh_window on data
1093         items.  Always call superclass refresh_window.
1094         (tui_win_info::refresh): Remove.
1095         (tui_source_window_base::refresh_window): Update.
1096         (tui_refresh_all): Update.
1097         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1098         refresh_window.
1099         (show_source_or_disasm_and_command): Likewise.
1100         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1101         (struct tui_source_window_base) <refresh>: Likewise.
1102
1103 2019-07-17  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-winsource.c (tui_clear_source_content)
1106         (tui_show_source_content): Update.
1107         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1108         whether content is empty.
1109         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1110         Remove.
1111
1112 2019-07-17  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1115         window's contents.
1116         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1117         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1118
1119 2019-07-17  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1122         (struct tui_data_item_window): Update.
1123
1124 2019-07-17  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1127         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1128         defines.
1129
1130 2019-07-17  Tom Tromey  <tom@tromey.com>
1131
1132         * tui/tui-winsource.h (tui_erase_source_content)
1133         (tui_clear_source_content): Remove "display_prompt" parameter.
1134         * tui/tui-winsource.c (tui_update_source_window_as_is)
1135         (tui_update_source_windows_with_addr): Update.
1136         (tui_clear_source_content): Remove "display_prompt" parameter.
1137         (tui_erase_source_content): Likewise.  Simplify.
1138         (tui_show_source_content): Update.
1139         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1140         * tui/tui-stack.c (tui_show_frame_info): Update.
1141         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1142         Remove defines.
1143
1144 2019-07-17  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1147         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1148         parameter.
1149         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1150         parameter.
1151
1152 2019-07-17  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui-winsource.c (tui_clear_source_content)
1155         (tui_show_source_content, tui_show_exec_info_content)
1156         (tui_clear_exec_info_content): Update.
1157         * tui/tui-stack.c (tui_show_locator_content): Update.
1158         (tui_show_frame_info): Update.
1159         * tui/tui-source.h (tui_source_window): Don't declare.
1160         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1161         from tui_source_is_displayed.
1162         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1163         Remove field.
1164         (struct tui_source_window_base) <content_in_use>: New field.  Now
1165         bool.
1166         (struct tui_source_window) <showing_source_p>: New method.
1167         (TUI_SRC_WIN): Change cast.
1168         * tui/tui-data.c (tui_initialize_static_data): Update.
1169
1170 2019-07-17  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1173         location_matches_p.
1174         * tui/tui-source.c (tui_source_window::location_matches_p): New
1175         method.
1176         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1177         method.
1178         * tui/tui-data.h (struct tui_source_window_base)
1179         <location_matches_p>: New method.
1180         (struct tui_source_window, struct tui_disasm_window)
1181         <location_matches_p>: Likewise.
1182
1183 2019-07-17  Tom Tromey  <tom@tromey.com>
1184
1185         * tui/tui-win.c (tui_set_win_height_command): Rename from
1186         tui_set_win_height.
1187         (tui_set_win_height_command): Remove.
1188
1189 2019-07-17  Tom Tromey  <tom@tromey.com>
1190
1191         * tui/tui-source.c (tui_source_window): New constructor.  Add
1192         observer.
1193         (~tui_source_window): New destructor.
1194         (tui_source_window::style_changed): New method.
1195         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1196         (tui_attach_detach_observers): Update.
1197         * tui/tui-data.h (struct tui_source_window): Make constructor not
1198         inline.  Add destructor.
1199         (struct tui_source_window) <style_changed>: New method.
1200         <m_observable>: New member.
1201
1202 2019-07-17  Tom Tromey  <tom@tromey.com>
1203
1204         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1205         * tui/tui-win.c (tui_resize_all): Fix typo.
1206
1207 2019-07-17  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1210         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1211         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1212         * tui/tui-win.c (window_name_completer): Use foreach.
1213         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1214         (update_tab_width): Likewise.
1215         * tui/tui-layout.c (show_layout): Update.
1216         * tui/tui-data.h (class tui_window_iterator): New.
1217         (struct all_tui_windows): New.
1218         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1219
1220 2019-07-17  Tom Tromey  <tom@tromey.com>
1221
1222         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1223         parameter.  Don't reference globals.
1224         (tui_reg_command): Update.
1225
1226 2019-07-17  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-regs.c (tui_show_registers): Simplify.
1229
1230 2019-07-17  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-regs.c (tui_show_registers): Update.
1233         (tui_show_register_group): Add win_info parameter.
1234
1235 2019-07-17  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1238         Rename from tui_display_reg_element_at_line.
1239         (tui_data_window::display_registers_from_line): Update.
1240         * tui/tui-data.h (struct tui_data_window)
1241         <display_reg_element_at_line>: New method.
1242
1243 2019-07-17  Tom Tromey  <tom@tromey.com>
1244
1245         * tui/tui-regs.h (tui_display_registers_from)
1246         (tui_display_registers_from_line): Don't declare.
1247         * tui/tui-windata.c (tui_data_window::display_all_data)
1248         (tui_data_window::refresh_all)
1249         (tui_data_window::do_scroll_vertical): Update.
1250         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1251         from tui_display_registers_from.
1252         (tui_display_reg_element_at_line): Update.
1253         (tui_data_window::display_registers_from_line): Rename from
1254         tui_display_registers_from_line.
1255         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1256         display_registers_from_line>: New methods.
1257
1258 2019-07-17  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1261         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1262         from tui_erase_data_content.
1263         (tui_data_window::display_all_data)
1264         (tui_data_window::refresh_all)
1265         (tui_data_window::do_scroll_vertical): Update.
1266         * tui/tui-regs.c (tui_show_registers): Update.
1267         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1268         New method.
1269
1270 2019-07-17  Tom Tromey  <tom@tromey.com>
1271
1272         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1273         declare.
1274         * tui/tui-windata.c
1275         (tui_data_window::delete_data_content_windows): Rename from
1276         tui_delete_data_content_windows.
1277         (tui_data_window::display_all_data)
1278         (tui_data_window::do_scroll_vertical): Update.
1279         * tui/tui-data.h (struct tui_data_window)
1280         <delete_data_content_windows>: New method.
1281
1282 2019-07-17  Tom Tromey  <tom@tromey.com>
1283
1284         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1285         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1286
1287 2019-07-17  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1290         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1291         from tui_display_all_data.
1292         * tui/tui-win.c
1293         (tui_data_window::do_make_visible_with_new_height): Update.
1294         * tui/tui-regs.c (tui_show_registers): Update.
1295         * tui/tui-layout.c (tui_set_layout): Update.
1296         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1297         method.
1298
1299 2019-07-17  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1302         * tui/tui-windata.c (tui_display_data_from): Remove.
1303         (tui_data_window::refresh_all): Update.
1304
1305 2019-07-17  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1308         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1309         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1310         tui_display_registers_from_line.
1311         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1312         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1313         "force_display" parameter.
1314
1315 2019-07-17  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1318         declare.
1319         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1320         Rename from tui_first_reg_element_no_inline.
1321         (tui_display_reg_element_at_line)
1322         (tui_display_registers_from_line): Update.
1323         * tui/tui-data.h (struct tui_data_window)
1324         <first_reg_element_no_inline>: New method.
1325
1326 2019-07-17  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-windata.c (tui_display_data_from)
1329         (tui_data_window::do_scroll_vertical): Update.
1330         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1331         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1332         Rename from tui_line_from_reg_element_no.
1333         (tui_display_registers_from_line): Update.
1334         * tui/tui-data.h (struct tui_data_window)
1335         <line_from_reg_element_no>: New method.
1336
1337 2019-07-17  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1340         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1341         tui_last_regs_line_no.
1342         (tui_display_reg_element_at_line)
1343         (tui_display_registers_from_line): Update.
1344         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1345         method.
1346
1347 2019-07-17  Tom Tromey  <tom@tromey.com>
1348
1349         PR tui/24722:
1350         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1351         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1352         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1353         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1354         (tui_update_breakpoint_info): Likewise.
1355         * tui/tui-hooks.c (tui_event_create_breakpoint)
1356         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1357         Update.
1358
1359 2019-07-17  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1362
1363 2019-07-17  Tom Tromey  <tom@tromey.com>
1364
1365         * tui/tui-winsource.c (tui_update_source_window_as_is)
1366         (tui_update_source_windows_with_addr): Update.
1367         * tui/tui-source.h (tui_set_source_content)
1368         (tui_show_symtab_source): Add "win_info" parameter.
1369         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1370         parameter.
1371         (tui_show_symtab_source): Likewise.
1372
1373 2019-07-17  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-wingeneral.c
1376         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1377
1378 2019-07-17  Tom Tromey  <tom@tromey.com>
1379
1380         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1381         (struct tui_cmd_window) <can_scroll>: New method.
1382         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1383         method.
1384
1385 2019-07-17  Tom Tromey  <tromey@adacore.com>
1386
1387         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1388         do_field_signed>: Rename.  Change type of "value".
1389         * ui-out.c (ui_out::field_signed): Rename from field_int.
1390         Change type of "value".
1391         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1392         type of "value".
1393         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1394         do_field_int.  Change type of "value".
1395         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1396         do_field_int.  Change type of "value".
1397         * tracepoint.c (trace_status_mi, tfind_1)
1398         (print_one_static_tracepoint_marker): Update.
1399         * thread.c (print_thread_info_1, print_selected_thread_frame):
1400         Update.
1401         * stack.c (print_frame, print_frame_info): Update.
1402         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1403         Update.
1404         * source.c (print_source_lines_base): Update.
1405         * skip.c (info_skip_command): Update.
1406         * record-btrace.c (btrace_ui_out_decode_error)
1407         (btrace_call_history_src_line): Update.
1408         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1409         Update.
1410         * progspace.c (print_program_space): Update.
1411         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1412         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1413         do_field_int.  Change type of "value".
1414         * mi/mi-out.c (mi_ui_out::do_table_begin)
1415         (mi_ui_out::do_table_header): Update.
1416         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1417         type of "value".
1418         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1419         (mi_cmd_data_list_changed_registers, output_register)
1420         (mi_cmd_data_read_memory, mi_load_progress)
1421         (mi_cmd_trace_frame_collected): Update.
1422         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1423         Update.
1424         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1425         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1426         (mi_cmd_var_list_children, varobj_update_one): Update.
1427         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1428         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1429         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1430         * inferior.c (print_inferior): Update.
1431         * gdb_bfd.c (print_one_bfd): Update.
1432         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1433         Update.
1434         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1435         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1436         do_field_int.  Change type of "value".
1437         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1438         do_field_int.  Change type of "value".
1439         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1440         (print_one_breakpoint_location, print_it_catch_fork)
1441         (print_one_catch_fork, print_it_catch_vfork)
1442         (print_one_catch_vfork, print_it_catch_solib)
1443         (print_it_catch_exec, print_it_ranged_breakpoint)
1444         (print_mention_watchpoint, print_mention_masked_watchpoint)
1445         (bkpt_print_it, update_static_tracepoint): Update.
1446         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1447         * break-catch-syscall.c (print_it_catch_syscall): Update.
1448         * ada-tasks.c (print_ada_task_info): Update.
1449         * ada-lang.c (print_it_exception, print_mention_exception):
1450         Update.
1451
1452 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1453
1454         PR breakpoints/24541
1455         * gdbarch.c: Regenerate.
1456         * gdbarch.h: Regenerate.
1457         * gdbarch.sh: Adjust return type and parameter types for
1458         'stap_adjust_register'.
1459         (i386_stap_adjust_register): Adjust signature and return new
1460         register name.
1461         * stap-probe.c (stap_parse_register_operand): Adjust use of
1462         'gdbarch_stap_adjust_register'.
1463
1464 2019-07-17  Tom Tromey  <tromey@adacore.com>
1465
1466         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1467         declare VEC.
1468         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1469         std::vector.
1470         (struct s390_process_info): Add initializers.
1471         (s390_add_process): Use new.
1472         (s390_linux_nat_target::low_forget_process): Use delete.
1473         (s390_linux_nat_target::low_new_fork)
1474         (s390_linux_nat_target::stopped_by_watchpoint)
1475         (s390_linux_nat_target::low_prepare_to_resume)
1476         (s390_linux_nat_target::insert_watchpoint)
1477         (s390_linux_nat_target::insert_hw_breakpoint)
1478         (s390_linux_nat_target::remove_watchpoint)
1479         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1480
1481 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1482
1483         * aarch64-fbsd-nat.c: Include regcache.h.
1484         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1485         argument.
1486         (aarch64_fbsd_nat_target::fetch_registers)
1487         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1488         variable.
1489         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1490
1491 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1492
1493         * fbsd-nat.c: Include gdbarch.h.
1494
1495 2019-07-15  Tom Tromey  <tromey@adacore.com>
1496
1497         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1498
1499 2019-07-15  Tom Tromey  <tromey@adacore.com>
1500
1501         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1502         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1503         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1504         * cli-out.c (cli_ui_out::do_field_int): New method.
1505         * ui-out.c (ui_out::field_unsigned): New method.
1506         * symfile.c (generic_load): Use field_unsigned.
1507         (print_transfer_performance): Likewise.
1508         * record-btrace.c (ui_out_field_uint): Remove.
1509         (btrace_call_history_insn_range, btrace_call_history): Use
1510         field_unsigned.
1511         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1512         field_unsigned.
1513         * ui-out.h (class ui_out) <field_unsigned>: New method.
1514         <do_field_unsigned>: Likewise.
1515
1516 2019-07-15  Tom Tromey  <tromey@adacore.com>
1517
1518         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1519         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1520         * target.c (flash_erase_command): Use field_string.
1521         * infrun.c (print_signal_received_reason): Use field_string.
1522         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1523         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1524         field_string.
1525         * ada-tasks.c (print_ada_task_info): Use field_string.
1526
1527 2019-07-15  Tom Tromey  <tromey@adacore.com>
1528
1529         * target.c (flash_erase_command): Use field_core_addr.
1530         * symfile.c (generic_load): Use field_core_addr.
1531         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1532         Use field_core_addr.
1533         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1534         field_core_addr.
1535
1536 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1537
1538         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1539         value if its desired type is smaller than a CORE_ADDR and signed.
1540
1541 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1542
1543         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1544         of changes to field names, and use new is_reference field to
1545         decide if a property is a reference or not.
1546         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1547         field.
1548         (struct dwarf2_property_baton): Update header comment, rename
1549         'referenced_type' to 'property_type' and update comments.
1550         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1551         default property type, store in property baton, update to take
1552         accound of renamed field.
1553         (read_func_scope): Update call to attr_to_dynamic_prop.
1554         (read_array_type): Likewise.
1555         (dwarf2_per_cu_addr_sized_int_type): New function.
1556         (read_subrange_index_type): Move type finding code to
1557         dwarf2_per_cu_addr_sized_int_type.
1558         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1559         (dwarf2_per_cu_addr_type): New function.
1560         (set_die_type): Update calls to attr_to_dynamic_prop.
1561
1562 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1563
1564         * dwarf2read.c (read_subrange_index_type): New function.
1565         (read_subrange_type): Move code into new function and call it.
1566         * gdbtypes.c (create_range_type): Add some asserts.
1567
1568 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1569
1570         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1571         update return statements.
1572         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1573         declaration, and update comment to match.
1574         * gdbtypes.c (resolve_dynamic_array): Update call to
1575         dwarf2_evaluate_property to match new return type.
1576
1577 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1578
1579         * valarith.c (value_subscripted_rvalue): Change lowerbound
1580         parameter type from int to LONGEST.
1581         * value.h (value_subscripted_rvalue): Likewise in declaration.
1582
1583 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1584
1585         * cli/cli-utils.c (info_print_command_completer): New function.
1586         * cli/cli-utils.h: Add 'completer.h' include, and forward
1587         declaration for 'struct cmd_list_element'.
1588         (info_print_command_completer): Declare.
1589         * stack.c (_initialize_stack): Add completer for 'info locals' and
1590         'info args'.
1591         * symtab.c (_initialize_symtab): Add completer for 'info
1592         variables' and 'info functions'.
1593         * NEWS: Mention completion for additional info commands.
1594
1595 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1596
1597         * cli/cli-utils.c (extract_info_print_args): Delete.
1598         (extract_arg_maybe_quoted): Delete.
1599         (info_print_options_defs): New variable.
1600         (make_info_print_options_def_group): New function.
1601         (extract_info_print_options): Define new function.
1602         * cli/cli-utils.h (extract_info_print_args): Delete.
1603         (struct info_print_options): New structure.
1604         (extract_info_print_options): Declare new function.
1605         * stack.c (info_locals_command): Update to use new
1606         extract_info_print_options, also add a header comment.
1607         (info_args_command): Likewise.
1608         * symtab.c (info_variables_command): Likewise.
1609         (info_functions_command): Likewise.
1610
1611 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1612
1613         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1614         to extract string arguments.
1615         * common/common-utils.c (extract_string_maybe_quoted): New function.
1616         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1617
1618 2019-07-11  Tom Tromey  <tromey@adacore.com>
1619
1620         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1621         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1622         * top.h (gdbinit): Don't declare.
1623         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1624         into...
1625         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1626         * top.c (gdb_init): Don't call init_cli_cmds.
1627         (gdbinit): Remove.
1628         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1629
1630 2019-07-11  Tom Tromey  <tromey@adacore.com>
1631
1632         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1633         after it has been moved.
1634
1635 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1636
1637         * valops.c (value_must_coerce_to_target): Change return type to
1638         bool.
1639         * value.h (value_must_coerce_to_target): Likewise.
1640
1641 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1642
1643         * breakpoint.c (is_hardware_watchpoint): Remove
1644         forward-declaration.
1645         (is_masked_watchpoint): Change return type to bool.
1646         (is_tracepoint): Likewise.
1647         (is_breakpoint): Likewise.
1648         (is_hardware_watchpoint): Likewise.
1649         (is_watchpoint): Likewise.
1650         (is_no_memory_software_watchpoint): Likewise.
1651         (is_catchpoint): Likewise.
1652         (breakpoint_1): Make FILTER parameter's return type bool.
1653         is_masked_watchpoint): Change return type to bool.
1654         (save_breakpoints): Make FILTER parameter's return type bool.
1655         * breakpoint.h (is_breakpoint): Change return type to bool.
1656         (is_watchpoint): Likewise.
1657         (is_catchpoint): Likewise.
1658         (is_tracepoint): Likewise.
1659
1660 2019-07-10  Tom Tromey  <tom@tromey.com>
1661
1662         * defs.h: Don't include gdbarch.h.
1663         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1664         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1665         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1666         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1667         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1668         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1669         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1670         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1671         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1672         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1673         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1674         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1675         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1676         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1677         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1678         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1679         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1680         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1681         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1682         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1683         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1684         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1685         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1686         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1687         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1688         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1689         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1690
1691 2019-07-10  Tom Tromey  <tromey@adacore.com>
1692
1693         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1694         * breakpoint.c (init_ada_exception_breakpoint): Register as
1695         bp_catchpoint.
1696         (print_one_breakpoint_location, print_one_breakpoint): Use
1697         is_ada_exception_catchpoint.
1698         * ada-lang.c (class ada_catchpoint_location): Pass
1699         bp_loc_software_breakpoint to bp_location constructor.
1700         (is_ada_exception_catchpoint): New function.
1701
1702 2019-07-10  Tom Tromey  <tromey@adacore.com>
1703
1704         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1705         VEC.
1706         (struct arm_exidx_entry): New method operator<.
1707         (struct arm_exidx_data) <section_maps>: Change type.
1708         (arm_exidx_data_free): Remove.
1709         (arm_exidx_data_key): Change type.  Move lower.
1710         (arm_exidx_new_objfile): Update.
1711         (arm_compare_exidx_entries): Remove.
1712         (arm_find_exidx_entry, _initialize_arm_tdep)
1713
1714 2019-07-10  Tom Tromey  <tromey@adacore.com>
1715
1716         * solib-spu.c (ocl_program_data_key): Change type.
1717         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1718         Update.
1719
1720 2019-07-10  Tom Tromey  <tromey@adacore.com>
1721
1722         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1723         (struct solib_aix_inferior_data) <library_list>: Change type.
1724         (solib_aix_inferior_data_handle): Change type.
1725         (get_solib_aix_inferior_data): Update.
1726         (solib_aix_free_library_list): Remove.
1727         (library_list_start_library): Update.
1728         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1729         return type.
1730         (solib_aix_get_library_list)
1731         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1732         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1733
1734 2019-07-10  Tom Tromey  <tromey@adacore.com>
1735
1736         * solib-dsbt.c (struct dsbt_info): Add initializers.
1737         (solib_dsbt_pspace_data): Change type.
1738         (dsbt_pspace_data_cleanup): Remove.
1739         (get_dsbt_info, _initialize_dsbt_solib): Update.
1740
1741 2019-07-10  Tom Tromey  <tromey@adacore.com>
1742
1743         * spu-tdep.c (spu_overlay_data): Change type.
1744         (spu_get_overlay_table, spu_overlay_new_objfile)
1745         (_initialize_spu_tdep): Update.
1746
1747 2019-07-10  Tom Tromey  <tromey@adacore.com>
1748
1749         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1750         destructor.
1751         (dbx_objfile_data_key): Change type and declare later.
1752         (DBX_SYMFILE_INFO): Rewrite.
1753         * dbxread.c (dbx_objfile_data_key): Change type.
1754         (dbx_symfile_init): Update.
1755         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1756         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1757         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1758
1759 2019-07-10  Tom Tromey  <tromey@adacore.com>
1760
1761         * jit.c (jit_program_space_key): Change type.  Move lower.
1762         (get_jit_program_space_data): Update.
1763         (jit_program_space_data_cleanup): Remove.
1764         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1765         Update.
1766         (struct jit_program_space_data): Add initializers.
1767
1768 2019-07-10  Tom Tromey  <tromey@adacore.com>
1769
1770         * solib-darwin.c (struct darwin_info): Add initializers.
1771         (solib_darwin_pspace_data): Change type.
1772         (darwin_pspace_data_cleanup): Remove.
1773         (get_darwin_info, _initialize_darwin_solib): Update.
1774
1775 2019-07-10  Tom Tromey  <tromey@adacore.com>
1776
1777         * remote-sim.c (struct sim_inferior_data): Add initializers,
1778         constructor, and destructor.
1779         (sim_inferior_data_key): Change type.  Move lower.
1780         (check_for_duplicate_sim_descriptor): Update.
1781         (get_sim_inferior_data): Use new.  Update.
1782         (~sim_inferior_data_cleanup): Rename from
1783         sim_inferior_data_cleanup.  Simplify.
1784         (gdbsim_close_inferior, simulator_command)
1785         (sim_command_completer, _initialize_remote_sim): Update.
1786         (next_pid, INITIAL_PID): Move earlier.
1787
1788 2019-07-10  Tom Tromey  <tromey@adacore.com>
1789
1790         * python/python-internal.h (create_thread_object): Return
1791         gdbpy_ref.
1792         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1793         * python/py-inferior.c (struct threadlist_entry): Add
1794         constructor.
1795         <thread_obj>: Now a gdbpy_ref.
1796         (thread_to_thread_object): Update.
1797         (add_thread_object): Use new.
1798         (delete_thread_object): Use delete.
1799         (infpy_threads): Update.
1800         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1801         GIL.
1802
1803 2019-07-10  Tom Tromey  <tromey@adacore.com>
1804
1805         * valops.c (value_cast): Specialize error message for Ada.
1806
1807 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1808
1809         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1810
1811 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1812
1813         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1814         bpstat_should_step): Return bool, adjust comments.
1815         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1816         bpstat_should_step): Likewise.
1817
1818 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1819
1820         * features/Makefile: Use feature target descriptions for Arm.
1821         * features/arm/arm-core.c: Generate new file.
1822         * features/arm/arm-fpa.c: Likewise.
1823         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1824         * features/arm/arm-m-profile.c: Likewise.
1825         * features/arm/arm-vfpv2.c: Likewise.
1826         * features/arm/arm-vfpv3.c: Likewise.
1827         * features/arm/xscale-iwmmxt.c: Likewise.
1828         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1829
1830 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1831
1832         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1833         ptrace earlier.
1834
1835 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1836
1837         * features/aarch64-pauth.c: Regenerate.
1838
1839 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1840
1841         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1842         bool.
1843         (bpstat_what): Use false instead of 0.
1844
1845 2019-07-09  Pedro Alves  <palves@redhat.com>
1846
1847         * break-catch-throw.c (is_exception_catchpoint): New.
1848         * breakpoint.c (print_one_breakpoint_location): New parameter
1849         'raw_loc'.  Handle it.  Use
1850         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1851         looking at the breakpoint's type.
1852         (print_one_breakpoint): If handling "maint info breakpoints", also
1853         print locations of exception catchpoints.
1854         * breakpoint.h (is_exception_catchpoint): Declare.
1855
1856 2019-07-09  Pedro Alves  <palves@redhat.com>
1857
1858         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1859         "addr" field.
1860         (allocate_location_exception_catchpoint): New.
1861         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1862         (initialize_throw_catchpoint_ops): Install
1863         allocate_location_exception_catchpoint as allocate_location
1864         method.
1865         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1866         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1867         bp_loc_other.
1868         (breakpoint_address_is_meaningful): Delete.
1869         (bl_address_is_meaningful): New.
1870         (breakpoint_locations_match): Adjust comment.
1871         (bp_location_from_bp_type): New, factored out of...
1872         (bp_location::bp_location(breakpoint *)): ... this.
1873         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1874         factored out of...
1875         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1876         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1877         breakpoint_address_is_meaningful.
1878         (bp_locations_compare): Adjust comment.
1879         (update_global_location_list): Use bl_address_is_meaningful
1880         instead of breakpoint_address_is_meaningful.
1881         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1882         explicit.
1883         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1884         * python/py-breakpoint.c (bppy_get_location): No longer check
1885         whether location is null.
1886
1887 2019-07-09  Pedro Alves  <palves@redhat.com>
1888
1889         PR c++/15468
1890         * breakpoint.c (print_one_breakpoint_location): Remove
1891         single-location assert.
1892
1893 2019-07-09  Tom Tromey  <tom@tromey.com>
1894
1895         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1896         * configure: Rebuild.
1897         * configure.ac: Change common to gdbsupport.
1898         * gdbsupport: Rename from common.
1899         * acinclude.m4: Change common to gdbsupport.
1900         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1901         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1902         gdbsupport.
1903         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1904         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1905         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1906         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1907         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1908         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1909         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1910         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1911         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1912         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1913         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1914         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1915         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1916         coff-pe-read.c, command.h, compile/compile-c-support.c,
1917         compile/compile-c.h, compile/compile-cplus-symbols.c,
1918         compile/compile-cplus-types.c, compile/compile-cplus.h,
1919         compile/compile-loc2c.c, compile/compile.c, completer.c,
1920         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1921         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1922         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1923         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1924         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1925         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1926         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1927         features/aarch64-core.c, features/aarch64-fpu.c,
1928         features/aarch64-pauth.c, features/aarch64-sve.c,
1929         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1930         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1931         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1932         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1933         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1934         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1935         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1936         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1937         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1938         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1939         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1940         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1941         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1942         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1943         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1944         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1945         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1946         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1947         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1948         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1949         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1950         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1951         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1952         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1953         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1954         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1955         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1956         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1957         minsyms.c, mips-linux-tdep.c, namespace.h,
1958         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1959         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1960         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1961         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1962         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1963         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1964         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1965         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1966         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1967         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1968         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1969         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1970         procfs.c, producer.c, progspace.h, psymtab.h,
1971         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1972         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1973         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1974         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1975         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1976         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1977         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1978         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1979         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1980         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1981         target-memory.c, target.c, target.h, target/waitstatus.c,
1982         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1983         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1984         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1985         unittests/array-view-selftests.c,
1986         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1987         unittests/common-utils-selftests.c,
1988         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1989         unittests/format_pieces-selftests.c,
1990         unittests/function-view-selftests.c,
1991         unittests/lookup_name_info-selftests.c,
1992         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1993         unittests/mkdir-recursive-selftests.c,
1994         unittests/observable-selftests.c,
1995         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1996         unittests/parse-connection-spec-selftests.c,
1997         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1998         unittests/scoped_fd-selftests.c,
1999         unittests/scoped_mmap-selftests.c,
2000         unittests/scoped_restore-selftests.c,
2001         unittests/string_view-selftests.c, unittests/style-selftests.c,
2002         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2003         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2004         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2005         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2006         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2007         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2008
2009 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2010
2011         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2012         bool value.
2013         (decode_digits_ordinary): Set explicit_line field in sal.
2014         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2015         symtab_and_line that was set on an explicit line number in
2016         assembler code.  Do always update the recorded symtab and line if
2017         we do skip the prologue.
2018
2019 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2020
2021         * breakpoint.c (set_breakpoint_location_function): Remove
2022         explicit_loc parameter.
2023         (momentary_breakpoint_from_master): Update call to
2024         set_breakpoint_location_function.
2025         (add_location_to_breakpoint): Likewise.
2026
2027 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2028
2029         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2030         required features based on default bfd type when no specific bfd
2031         is present.
2032
2033 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2034
2035         * NEWS: Mention that GDB printf and eval commands can now print
2036         C-style and Ada-style convenience var strings without
2037         calling the inferior.
2038         * printcmd.c (printf_c_string): Locally print GDB internal var
2039         instead of transiting via the inferior.
2040         (printf_wide_c_string): Likewise.
2041
2042 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2043
2044         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2045
2046 2019-07-04  Tom Tromey  <tom@tromey.com>
2047
2048         PR tui/24724:
2049         * tui/tui-winsource.c (tui_clear_source_content): Update.
2050         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2051         (tui_update_breakpoint_info): Update.
2052         (tui_set_exec_info_content): Update.
2053         * tui/tui-source.c (tui_set_source_content_nil): Update.
2054         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2055         has_break.
2056         * tui/tui-data.h (enum tui_bp_flag): New.
2057         (tui_bp_flags): New enum flags type.
2058         (struct tui_source_element) <break_mode>: Change type.  Rename
2059         from has_break.
2060         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2061         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2062         constants.
2063         * tui/tui-winsource.h: Fix comment.
2064
2065 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2066
2067         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2068         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2069         (store_fpregs_to_thread)
2070         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2071         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2072         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2073         (IWMMXT_REGS_SIZE): Add define.
2074         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2075         (fetch_vfp_regs, store_vfp_regs)
2076         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2077         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2078
2079 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2080
2081         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2082         defines.
2083         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2084         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2085         (ARM_INT_REGISTER_SIZE): ...to this.
2086         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2087         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2088         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2089         (arm_linux_collect_gregset, supply_nwfpe_register)
2090         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2091         defines.
2092         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2093         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2094         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2095         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2096         (arm_return_in_memory, arm_store_return_value)
2097         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2098         (arm_record_ld_st_multiple): Likewise.
2099         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2100         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2101
2102 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2103
2104         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2105         AARCH64_DISPLACED_MODIFIED_INSNS.
2106         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2107         (aarch64_displaced_step_copy_insn): Likewise.
2108         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2109         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2110         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2111         ARM_DISPLACED_MODIFIED_INSNS.
2112         * arm-tdep.c (arm_gdbarch_init): Likewise.
2113         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2114         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2115         (struct arm_displaced_step_closure): Use
2116         ARM_DISPLACED_MODIFIED_INSNS.
2117
2118 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2119
2120         * features/Makefile: Remove unused xml files.
2121         * features/aarch64.xml: Remove.
2122         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2123         * features/i386/amd64-avx-avx512.xml: Remove.
2124         * features/i386/amd64-avx-linux.xml: Remove.
2125         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2126         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2127         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2128         * features/i386/amd64-avx-mpx.xml: Remove.
2129         * features/i386/amd64-avx.xml: Remove.
2130         * features/i386/amd64-linux.xml: Remove.
2131         * features/i386/amd64-mpx-linux.xml: Remove.
2132         * features/i386/amd64-mpx.xml: Remove.
2133         * features/i386/amd64.xml: Remove.
2134         * features/i386/i386-avx-avx512-linux.xml: Remove.
2135         * features/i386/i386-avx-avx512.xml: Remove.
2136         * features/i386/i386-avx-linux.xml: Remove.
2137         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2138         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2139         * features/i386/i386-avx-mpx-linux.xml: Remove.
2140         * features/i386/i386-avx-mpx.xml: Remove.
2141         * features/i386/i386-avx.xml: Remove.
2142         * features/i386/i386-linux.xml: Remove.
2143         * features/i386/i386-mmx-linux.xml: Remove.
2144         * features/i386/i386-mmx.xml: Remove.
2145         * features/i386/i386-mpx-linux.xml: Remove.
2146         * features/i386/i386-mpx.xml: Remove.
2147         * features/i386/i386.xml: Remove.
2148         * features/i386/x32-avx-avx512-linux.xml: Remove.
2149         * features/i386/x32-avx-linux.xml: Remove.
2150         * features/i386/x32-linux.xml: Remove.
2151
2152 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2153
2154         * regformats/aarch64.dat: Remove.
2155         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2156         * regformats/i386/amd64-avx-linux.dat: Remove.
2157         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2158         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2159         * regformats/i386/amd64-linux.dat: Remove.
2160         * regformats/i386/amd64-mpx-linux.dat: Remove.
2161         * regformats/i386/amd64.dat: Remove.
2162         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2163         * regformats/i386/i386-avx-linux.dat: Remove.
2164         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2165         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2166         * regformats/i386/i386-linux.dat: Remove.
2167         * regformats/i386/i386-mmx-linux.dat: Remove.
2168         * regformats/i386/i386-mpx-linux.dat: Remove.
2169         * regformats/i386/i386.dat: Remove.
2170         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2171         * regformats/i386/x32-avx-linux.dat: Remove.
2172         * regformats/i386/x32-linux.dat: Remove.
2173
2174 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2175
2176         * aarch64-tdep.c: Remove xml self tests.
2177         * amd64-linux-tdep.c: Likewise.
2178         * amd64-tdep.c: Likewise.
2179         * i386-linux-tdep.c: Likewise.
2180         * i386-tdep.c: Likewise.
2181
2182 2019-07-03  Pedro Alves  <palves@redhat.com>
2183
2184         PR cli/24732
2185         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2186         (pipe_cmd_option_defs): New.
2187         (make_pipe_cmd_options_def_group): New.
2188         (pipe_command): Use gdb::option::process_options.
2189         (pipe_command_completer): New function.
2190         (_initialize_cli_cmds): Install completer for "pipe" command.
2191
2192 2019-07-03  Pedro Alves  <palves@redhat.com>
2193
2194         * cli/cli-option.c (union option_value) <string>: New field.
2195         (struct option_def_and_value): Add ctor, move ctor, dtor and
2196         use DISABLE_COPY_AND_ASSIGN.
2197         (option_def_and_value::clear_value): New.
2198         (parse_option, save_option_value_in_ctx, get_val_type_str)
2199         (add_setshow_cmds_for_options): Handle var_string.
2200         * cli-option.h (union option_def::var_address) <string>: New
2201         field.
2202         (struct string_option_def): New.
2203         * maint-test-options.c (struct test_options_opts): Add default
2204         ctor and use DISABLE_COPY_AND_ASSIGN.
2205         <string_opt>: New field.
2206         (test_options_opts::~test_options_opts): New.
2207         (test_options_opts::dump): Also dump "-string".
2208         (test_options_option_defs): Install "string.
2209
2210 2019-07-03  Pedro Alves  <palves@redhat.com>
2211
2212         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2213         option_value with a null enumeration.
2214         (complete_options): Save the option values in the context.
2215         (save_option_value_in_ctx): New, factored out from ...
2216         (process_options): ... here.
2217         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2218         of the function.
2219         * maint-test-options.c (test_options_opts::dump): New, factored
2220         out from ...
2221         (maintenance_test_options_command_mode): ... here.
2222         (maintenance_test_options_command_completion_result): Delete.
2223         (maintenance_test_options_command_completion_text): Update
2224         comment.
2225         (maintenance_show_test_options_completion_result): Change
2226         prototype.  Just print
2227         maintenance_test_options_command_completion_text.
2228         (save_completion_result): New.
2229         (maintenance_test_options_completer_mode): Pass options context to
2230         complete_options, and then save a dump.
2231         (_initialize_maint_test_options): Use add_cmd to install "maint
2232         show test-options-completion-result".
2233
2234 2019-07-03  Pedro Alves  <palves@redhat.com>
2235
2236         * NEWS (New commands): Mention "with" and "maint with".
2237         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2238         (with_command, with_command_completer): New.
2239         (pipe_command): Adjust to new repeat_previous
2240         interface.
2241         (_initialize_cli_cmds): Install the "with" command and its "w"
2242         alias.
2243         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2244         declarations.
2245         * cli/cli-setshow.c (parse_cli_var_uinteger)
2246         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2247         argument strings for all var_types.
2248         (get_setshow_command_value_string): New, factored out from ...
2249         (do_show_command): ... this.
2250         * cli/cli-setshow.h: Include <string>.
2251         (get_setshow_command_value_string): Declare.
2252         * command.h (repeat_previous): Now returns const char *.  Adjust
2253         comment.
2254         * maint.c: Include "cli/cli-cmds.h".
2255         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2256         (_initialize_maint_cmds): Register the "maintenance with" command.
2257         * top.c (repeat_previous): Move bits from pipe_command here:
2258         Return the saved command line, if any; error out if there's no
2259         command to relaunch.
2260
2261 2019-07-03  Pedro Alves  <palves@redhat.com>
2262
2263         * NEWS (New commands): Mention "maint set/show test-settings"
2264         instead of "maint test-settings".
2265         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2266         (maintenance_test_settings_set_list): Rename to ...
2267         (maintenance_set_test_settings_list): ... this.
2268         (maintenance_test_settings_show_list): Rename to  ...
2269         (maintenance_show_test_settings_list): ... this.
2270         (maintenance_test_settings_cmd): Delete.
2271         (maintenance_test_settings_set_cmd): ...
2272         (maintenance_set_test_settings_cmd): ... this.
2273         (maintenance_test_settings_show_cmd): ...
2274         (maintenance_show_test_settings_cmd): ... this.
2275         (maintenance_test_settings_show_value_cmd):
2276         (maintenance_show_test_settings_value_cmd): ... this.
2277         (_initialize_maint_test_settings): No longer install the "maint
2278         test-settings" prefix command.  Rename "maint test-settings set"
2279         to "maint set test-settings", and "maint test-settings show" to
2280         "maint show test-settings".  Adjust all subcommands.
2281
2282 2019-07-03  Pedro Alves  <palves@redhat.com>
2283
2284         * maint-test-settings.c: Fix file's intro comment.  Replace all
2285         references to "test-options" with references to "test-settings",
2286         in comments.
2287
2288 2019-07-03  Pedro Alves  <palves@redhat.com>
2289
2290         * maint-test-settings.c (maintenance_test_settings_xxx)
2291         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2292         New.
2293         (maintenance_test_settings_enums): Use them.
2294         (maintenance_test_settings_enum): Default to
2295         maintenance_test_settings_xxx.
2296         (_initialize_maint_test_settings): Initialize
2297         MAINTENANCE_TEST_SETTINGS_FILENAME.
2298
2299 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2300
2301         * breakpoint.h (remove_breakpoints_inf): Change return type to
2302         void, move function documentation here.
2303         * breakpoint.c (remove_breakpoints_inf): Change return type to
2304         void, move function documentation to header.
2305
2306 2019-07-02  Pedro Alves  <palves@redhat.com>
2307
2308         * NEWS (Completion improvements): Mention "info threads".
2309         * thread.c (struct info_threads_opts, info_threads_option_defs)
2310         (make_info_threads_options_def_group): New.
2311         (info_threads_command): Use gdb::option::process_options.
2312         (info_threads_command_completer): New.
2313         (_initialize_thread): Use gdb::option::build_help to build the
2314         help text for "info threads".
2315
2316 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2317
2318         * defs.h (generic_load): Move from here...
2319         * symfile.h (generic_load): ... to here.  Rename name parameter
2320         to args.
2321         * symfile.c (generic_load): Add comment.
2322
2323 2019-07-01  Tom Tromey  <tromey@adacore.com>
2324
2325         * dwarf2read.c
2326         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2327         declaration of without_params.  Fix formatting.
2328
2329 2019-07-01  Tom Tromey  <tromey@adacore.com>
2330
2331         * ada-exp.y (find_primitive_type): Update.
2332         * ada-lang.h (ada_lookup_symbol): Update.
2333         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2334         parameter.
2335         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2336
2337 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2338
2339         PR breakpoints/24541
2340         * gdbarch.c: Regenerate.
2341         * gdbarch.h: Regenerate.
2342         * gdbarch.sh: Add 'stap_adjust_register'.
2343         * i386-tdep.c: Include '<unordered_set>'.
2344         (i386_stap_adjust_register): New function.
2345         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2346         * stap-probe.c (stap_parse_register_operand): Call
2347         'gdbarch_stap_adjust_register'.
2348
2349 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2350
2351         PR python/24742
2352         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2353         * python/python.c (do_start_initialization): Use 'xmalloc'
2354         instead of 'PyMem_Malloc'.
2355
2356 2019-06-28  Tom Tromey  <tromey@adacore.com>
2357
2358         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2359         for Ada.
2360
2361 2019-06-27  Tom Tromey  <tromey@adacore.com>
2362
2363         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2364         objfile_key.
2365         (arm_find_mapping_symbol, arm_record_special_symbol)
2366         (_initialize_arm_tdep): Update.
2367         (arm_objfile_data_free): Remove.
2368
2369 2019-06-27  Tom Tromey  <tromey@adacore.com>
2370
2371         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2372         to cp_print_static_field.
2373
2374 2019-06-26  Tom Tromey  <tromey@adacore.com>
2375
2376         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2377         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2378         declare.
2379
2380 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2381
2382         * features/aarch64-core.c (create_feature_aarch64_core):
2383         Regenerate.
2384         * features/aarch64-core.xml: Add cpsr flags.
2385
2386 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2387
2388         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2389         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2390
2391 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2392
2393         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2394         field.
2395         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2396         use.
2397         (arm_record_special_symbol): Don't insert new symbol in sorted
2398         position, push it at the end.
2399
2400 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2401
2402         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2403         (arm_mapping_symbol_s): Remove.
2404         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2405         (arm_mapping_symbol_vec): New typedef.
2406         (struct arm_per_objfile): Add constructor.
2407         <section_maps>: Change type to
2408         std::unique_ptr<arm_mapping_symbol_vec[]>.
2409         (arm_compare_mapping_symbols): Remove.
2410         (arm_find_mapping_symbol): Adjust to section_maps type change.
2411         (arm_objfile_data_free): Call delete on arm_per_objfile.
2412         (arm_record_special_symbol): Adjust to section_maps type change.
2413         Allocate arm_per_objfile with new.
2414
2415 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2416
2417         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2418         with the command prefix.
2419
2420 2019-06-25  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2423         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2424
2425 2019-06-25  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2428         type.
2429         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2430         protected.
2431
2432 2019-06-25  Tom Tromey  <tom@tromey.com>
2433
2434         * tui/tui-winsource.c
2435         (tui_source_window_base::set_is_exec_point_at): Add check against
2436         LOA_ADDRESS.
2437
2438 2019-06-25  Tom Tromey  <tom@tromey.com>
2439
2440         * tui/tui-source.c (tui_set_source_content): Don't check before
2441         xfree.
2442         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2443
2444 2019-06-25  Tom Tromey  <tom@tromey.com>
2445
2446         * tui/tui-winsource.h (tui_update_source_window_as_is)
2447         (tui_alloc_source_buffer, tui_line_is_displayed)
2448         (tui_addr_is_displayed): Change type of win_info.
2449         * tui/tui-winsource.c (tui_update_source_window_as_is)
2450         (tui_clear_source_content, tui_show_source_line)
2451         (tui_show_source_content, tui_source_window_base::refill)
2452         (tui_source_window_base::set_is_exec_point_at)
2453         (tui_source_window_base::set_is_exec_point_at)
2454         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2455         (tui_alloc_source_buffer, tui_line_is_displayed)
2456         (tui_addr_is_displayed): Change type of win_info.  Update.
2457         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2458         (tui_source_window_base::do_make_visible_with_new_height):
2459         Update.
2460         * tui/tui-source.c (tui_set_source_content)
2461         (tui_set_source_content_nil)
2462         (tui_source_window::do_scroll_vertical): Update.
2463         * tui/tui-layout.c (show_layout): Update.
2464         * tui/tui-disasm.c (tui_set_disassem_content)
2465         (tui_disasm_window::do_scroll_vertical): Update.
2466         * tui/tui-data.h (tui_win_content): Remove.
2467         (struct tui_gen_win_info) <content, content_size>: Remove.
2468         (struct tui_source_element): Add initializers and destructor.
2469         (union tui_which_element, struct tui_win_element): Remove.
2470         (struct tui_source_window_base) <content>: New field.
2471         (struct tui_data_window): Remove destructor.
2472         (tui_alloc_content, tui_free_win_content)
2473         (tui_free_all_source_wins_content): Don't declare.
2474         * tui/tui-data.c (tui_initialize_static_data): Update.
2475         (init_content_element, tui_alloc_content): Remove.
2476         (~tui_gen_win_info): Update.
2477         (~tui_data_window, tui_free_all_source_wins_content)
2478         (tui_free_win_content, free_content, free_content_elements):
2479         Remove.
2480
2481 2019-06-25  Tom Tromey  <tom@tromey.com>
2482
2483         * tui/tui-winsource.h (tui_clear_source_content)
2484         (tui_erase_source_content, tui_show_source_content): Change type
2485         of win_info.
2486         * tui/tui-winsource.c (tui_clear_source_content)
2487         (tui_erase_source_content, tui_show_source_content): Change type
2488         of win_info.
2489         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2490         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2491         win_info.
2492         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2493         win_info.
2494         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2495
2496 2019-06-25  Tom Tromey  <tom@tromey.com>
2497
2498         * tui/tui-winsource.c (tui_clear_source_content)
2499         (tui_source_window_base::set_is_exec_point_at): Update.
2500         * tui/tui-source.c (tui_set_source_content_nil): Update.
2501         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2502         a bool.
2503         * tui/tui-data.c (init_content_element): Update.
2504
2505 2019-06-25  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2508         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2509         * tui/tui-layout.c (init_and_make_win): Update.
2510         * tui/tui.h (enum tui_win_type): Update.
2511         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2512         tui_win_is_auxillary.
2513         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2514         tui_win_is_auxillary.
2515
2516 2019-06-25  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2519         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2520         (tui_delete_data_content_windows, tui_display_all_data)
2521         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2522         Update.
2523         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2524         * tui/tui-regs.c (tui_last_regs_line_no)
2525         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2526         (tui_show_registers): Update.
2527         (tui_show_register_group): Return void.  Update.
2528         (tui_display_registers_from, tui_display_reg_element_at_line)
2529         (tui_display_registers_from_line, tui_check_register_values):
2530         Update.
2531         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2532         member.
2533         (struct tui_data_window) <regs_content>: Now a std::vector.
2534         <regs_content_count>: Remove.
2535         (tui_add_content_elements, tui_free_data_content): Don't declare.
2536         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2537         (init_content_element): Remove DATA_WIN case.  Add assert.
2538         (tui_add_content_elements): Remove.
2539         (tui_data_window): Update.
2540         (tui_free_data_content): Remove.
2541         (free_content_elements): Remove DATA_WIN case.
2542
2543 2019-06-25  Tom Tromey  <tom@tromey.com>
2544
2545         * tui/tui-data.c (tui_data_item_window): Update.
2546         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2547         * tui/tui-windata.c (tui_display_all_data)
2548         (tui_display_data_from_line): Update.
2549         (tui_check_data_values): Remove.
2550         * tui/tui-regs.c (tui_show_register_group)
2551         (tui_display_reg_element_at_line): Update.
2552         * tui/tui-hooks.c (tui_register_changed)
2553         (tui_refresh_frame_and_register_information): Call
2554         tui_check_register_values.
2555         * tui/tui-data.h (struct tui_data_window) <data_content,
2556         data_content_count, data_type>: Remove.
2557         (enum tui_data_type): Remove.
2558
2559         * tui/tui-data.c (tui_data_window::clear_detail)
2560         (~tui_data_window): Update.
2561
2562 2019-06-25  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2565         declare.
2566         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2567         Rename from tui_first_data_item_displayed.  Update.
2568         (tui_data_window::refresh_all)
2569         (tui_data_window::do_scroll_vertical): Update.
2570         * tui/tui-data.h (struct tui_data_window)
2571         <first_data_item_displayed>: Declare new method.
2572
2573 2019-06-25  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2576         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2577         contents...
2578         (tui_initialize_static_data): ...here.
2579
2580 2019-06-25  Tom Tromey  <tom@tromey.com>
2581
2582         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2583         (tui_display_registers_from, tui_check_register_values): Update.
2584         (tui_display_register): Remove win_info parameter; update.
2585         (tui_get_register): Change type of parameters.
2586         * tui/tui-data.h (struct tui_data_element): Remove.
2587         (union tui_which_element) <data>: Remove.
2588         <data_window>: Change type.
2589         (struct tui_data_item_window): New.
2590         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2591         case.  Add assert.
2592         (~tui_data_item_window): New destructor.
2593         (free_content_elements): Remove DATA_ITEM_WIN case.
2594
2595 2019-06-25  Tom Tromey  <tom@tromey.com>
2596
2597         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2598         Remove.
2599
2600 2019-06-25  Tom Tromey  <tom@tromey.com>
2601
2602         * tui/tui-data.h (struct tui_command_element): Remove.
2603         (union tui_which_element) <command>: Remove.
2604         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2605         assert.
2606         (free_content_elements): Remove CMD_WIN case.
2607
2608 2019-06-25  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-layout.c (tui_set_layout): Update.
2611         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2612         * tui/tui-data.c (layout_def): Update.
2613
2614 2019-06-25  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2617         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2618         (tui_source_window_base::set_new_height): Update.
2619         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2620         Update.
2621         (tui_set_locator_fullname, tui_set_locator_info)
2622         (tui_show_frame_info): Update.
2623         * tui/tui-source.c (tui_set_source_content)
2624         (tui_source_is_displayed): Update.
2625         * tui/tui-layout.c (show_source_disasm_command, show_data)
2626         (show_source_or_disasm_and_command): Update.
2627         * tui/tui-disasm.c (tui_set_disassem_content)
2628         (tui_get_begin_asm_address): Update.
2629         * tui/tui-data.h (struct tui_locator_element): Remove.
2630         (union tui_which_element) <locator>: Remove.
2631         (struct tui_locator_window): New.
2632         (tui_locator_win_info_ptr): Change return type.
2633         * tui/tui-data.c (_locator): Change type.
2634         (tui_locator_win_info_ptr): Change return type.
2635         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2636         (tui_alloc_content): Add assert.
2637
2638 2019-06-25  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui-winsource.c
2641         (tui_exec_info_window::maybe_allocate_content): New method.
2642         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2643         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2644         (make_source_or_disasm_window): Add cast.
2645         * tui/tui-data.h (union tui_which_element) <simple_string>:
2646         Remove.
2647         (struct tui_source_info): New.
2648         (struct tui_source_window_base) <execution_info>: Change type.
2649         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2650         case, and add assert.
2651         (tui_alloc_content): Add assert.
2652
2653 2019-06-25  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2656         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2657         * tui/tui-data.c (tui_alloc_win_info): Remove.
2658
2659 2019-06-25  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2662         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2663         can_highlight.
2664
2665 2019-06-25  Tom Tromey  <tom@tromey.com>
2666
2667         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2668         make_visible_with_new_height method.
2669         (tui_win_info::make_visible_with_new_height): New method.
2670         (tui_source_window_base::do_make_visible_with_new_height)
2671         (tui_data_window::do_make_visible_with_new_height)
2672         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2673         (make_visible_with_new_height): Remove.
2674         (tui_resize_all, tui_adjust_win_heights): Use
2675         make_visible_with_new_height method.
2676         * tui/tui-data.h (struct tui_win_info)
2677         <do_make_visible_with_new_height, make_visible_with_new_height>:
2678         New methods.
2679         (struct tui_source_window_base, struct tui_data_window)
2680         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2681         methods.
2682
2683 2019-06-25  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2686         method.
2687         (update_tab_width): Call update_tab_width method.
2688         * tui/tui-data.h (struct tui_win_info)
2689         (struct tui_source_window_base) <update_tab_width>: New methods.
2690
2691 2019-06-25  Tom Tromey  <tom@tromey.com>
2692
2693         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2694         parameter.
2695         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2696         parameter.
2697         (tui_gen_win_info::make_visible): Update.
2698         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2699         parameter.
2700         * tui/tui-data.h (enum tui_box): New enum.
2701         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2702
2703 2019-06-25  Tom Tromey  <tom@tromey.com>
2704
2705         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2706         init_and_make_win for EXEC_INFO_WIN.
2707         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2708         longer inline.
2709         (struct tui_win_info) <~tui_win_info>: Inline.
2710         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2711         Don't declare.
2712         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2713         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2714         Remove.
2715         (tui_initialize_static_data): Update.
2716         (~tui_gen_win_info): Handle more cleanup here.
2717         (~tui_source_window_base): Delete "execution_info".
2718         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2719
2720 2019-06-25  Tom Tromey  <tom@tromey.com>
2721
2722         * tui/tui-layout.c (make_command_window): Don't set
2723         can_highlight.
2724         (show_source_disasm_command): Call the reset method.
2725         (show_data): Don't set can_highlight.  Call the reset method.
2726         (tui_gen_win_info::reset): Rename from init_gen_win_info
2727         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2728         (show_source_or_disasm_and_command): Call the reset method.
2729         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2730         (struct tui_cmd_window): Set can_highlight.
2731
2732 2019-06-25  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2735         from make_visible.
2736         (tui_make_visible, tui_make_invisible): Rewrite.
2737         (tui_win_info::make_visible): Remove.
2738         (tui_source_window_base::make_visible): Update.
2739         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2740         method.  Moved from...
2741         (struct tui_win_info) <make_visible>: ...here.
2742
2743 2019-06-25  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui-winsource.c
2746         (tui_source_window_base::do_scroll_horizontal): Remove direction
2747         parameter.
2748         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2749         direction parameter.
2750         * tui/tui-win.c (tui_win_info::forward_scroll)
2751         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2752         (tui_win_info::right_scroll): Update.
2753         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2754         direction parameter.
2755         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2756         direction parameter.
2757         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2758         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2759         Remove direction parameter.
2760         (struct tui_source_window_base, struct tui_source_window)
2761         (struct tui_disasm_window, struct tui_data_window)
2762         (struct tui_cmd_window): Update.
2763
2764 2019-06-25  Tom Tromey  <tom@tromey.com>
2765
2766         * tui/tui-winsource.h (tui_set_exec_info_content)
2767         (tui_show_exec_info_content, tui_erase_exec_info_content)
2768         (tui_clear_exec_info_content, tui_update_exec_info): Change
2769         argument to tui_source_window_base.
2770         * tui/tui-winsource.c (tui_set_exec_info_content)
2771         (tui_show_exec_info_content, tui_erase_exec_info_content)
2772         (tui_clear_exec_info_content, tui_update_exec_info): Change
2773         argument to tui_source_window_base.
2774
2775 2019-06-25  Tom Tromey  <tom@tromey.com>
2776
2777         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2778         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2779
2780 2019-06-25  Tom Tromey  <tom@tromey.com>
2781
2782         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2783         check.
2784
2785 2019-06-25  Tom Tromey  <tom@tromey.com>
2786
2787         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2788         type to void.
2789         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2790         type to void.
2791         * tui/tui-source.c (tui_set_source_content): Update.
2792         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2793
2794 2019-06-25  Tom Tromey  <tom@tromey.com>
2795
2796         * tui/tui-win.c (window_name_completer, tui_set_focus)
2797         (tui_all_windows_info): Use name method.
2798         * tui/tui-data.h (struct tui_gen_win_info)
2799         (struct tui_source_window, struct tui_disasm_window)
2800         (struct tui_data_window, struct tui_cmd_window) <name>: New
2801         method.
2802         (tui_win_name): Don't declare.
2803         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2804         (tui_win_name): Remove.
2805
2806 2019-06-25  Tom Tromey  <tom@tromey.com>
2807
2808         * tui/tui-winsource.h (tui_update_source_window)
2809         (tui_update_source_window_as_is): Change parameter type.
2810         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2811         to be a tui_source_window_base.
2812         (tui_update_source_window_as_is): Likewise.
2813         * tui/tui-win.c (make_visible_with_new_height): Update.
2814
2815 2019-06-25  Tom Tromey  <tom@tromey.com>
2816
2817         * tui/tui-winsource.c (tui_erase_source_content)
2818         (tui_show_source_content, tui_show_exec_info_content)
2819         (tui_erase_exec_info_content): Use refresh_window method.
2820         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2821         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2822         from tui_refresh_win.
2823         (tui_data_window::refresh_window): New method.
2824         (tui_win_info::refresh, tui_source_window_base::refresh)
2825         (tui_refresh_all): Use refresh_window method.
2826         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2827         method.
2828         * tui/tui-regs.c (tui_display_register): Call refresh_window
2829         method.
2830         * tui/tui-layout.c (show_source_disasm_command)
2831         (show_source_or_disasm_and_command): Call refresh_window method.
2832         * tui/tui-data.h (struct tui_gen_win_info)
2833         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2834         New method.
2835
2836 2019-06-25  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui.c (tui_rl_other_window, tui_enable)
2839         (tui_is_window_visible, tui_get_command_dimension): Update.
2840         * tui/tui-winsource.c (tui_update_source_window_as_is)
2841         (tui_clear_source_content, tui_erase_source_content)
2842         (tui_show_source_line, tui_source_window_base::refill)
2843         (tui_source_window_base::do_scroll_horizontal)
2844         (tui_source_window_base::set_is_exec_point_at)
2845         (tui_update_breakpoint_info, tui_set_exec_info_content)
2846         (tui_alloc_source_buffer, tui_line_is_displayed)
2847         (tui_addr_is_displayed): Update.
2848         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2849         (tui_check_and_display_highlight_if_needed)
2850         (tui_win_info::make_visible, tui_win_info::refresh)
2851         (tui_refresh_all): Update.
2852         * tui/tui-windata.c (tui_first_data_item_displayed)
2853         (tui_delete_data_content_windows, tui_erase_data_content)
2854         (tui_display_all_data, tui_data_window::refresh_all)
2855         (tui_check_data_values): Update.
2856         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2857         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2858         (tui_win_info::backward_scroll, tui_refresh_all_win)
2859         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2860         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2861         (tui_source_window_base::set_new_height)
2862         (tui_data_window::set_new_height)
2863         (make_invisible_and_set_new_height)
2864         (make_visible_with_new_height, new_height_ok)
2865         (parse_scrolling_args): Update.
2866         * tui/tui-stack.c (tui_show_frame_info): Update.
2867         * tui/tui-source.c (tui_set_source_content)
2868         (tui_set_source_content_nil, tui_source_is_displayed)
2869         (tui_source_window::do_scroll_vertical): Update.
2870         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2871         (tui_display_registers_from, tui_display_reg_element_at_line)
2872         (tui_check_register_values, tui_reg_command): Update.
2873         * tui/tui-layout.c (tui_default_win_height)
2874         (show_source_disasm_command, show_data, init_and_make_win)
2875         (show_source_or_disasm_and_command): Update.
2876         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2877         (tui_redisplay_readline, tui_mld_flush)
2878         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2879         (tui_getc): Update.
2880         * tui/tui-disasm.c (tui_set_disassem_content)
2881         (tui_disasm_window::do_scroll_vertical): Update.
2882         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2883         Now virtual.
2884         (struct tui_win_info): Derive from tui_gen_win_info.
2885         <~tui_win_info>: Mark as override.
2886         <generic>: Remove member.
2887         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2888         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2889         (~tui_data_window, ~tui_win_info)
2890         (tui_free_all_source_wins_content): Update.
2891         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2892
2893 2019-06-25  Tom Tromey  <tom@tromey.com>
2894
2895         * tui/tui-layout.c (init_and_make_win): Use new.
2896         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2897         destructor, initializers.
2898         (tui_alloc_generic_win_info): Don't declare.
2899         * tui/tui-data.c (_locator): Add argument to constructor.
2900         (source_win, disasm_win): New globals.
2901         (exec_info): Remove.
2902         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2903         Update.
2904         (tui_alloc_generic_win_info): Remove.
2905         (init_content_element): Use new.
2906         (tui_win_info::tui_win_info): Update.
2907         (free_content_elements) <case DATA_WIN>: Use delete.
2908
2909 2019-06-25  Tom Tromey  <tom@tromey.com>
2910
2911         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2912         * tui/tui-windata.c (tui_first_data_item_displayed)
2913         (tui_delete_data_content_windows): Update.
2914         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2915         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2916         (tui_display_registers_from, tui_check_register_values): Update.
2917         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2918         pointer.
2919         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2920         window.
2921         (tui_free_data_content): Update.
2922         (free_content_elements) <case DATA_WIN>: Free the window.
2923
2924 2019-06-25  Tom Tromey  <tom@tromey.com>
2925
2926         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2927         Update.
2928         * tui/tui-layout.c (make_command_window)
2929         (show_source_disasm_command, show_data, init_and_make_win)
2930         (show_source_or_disasm_and_command): Update.
2931         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2932         method.
2933         <can_highight, is_highlighted>: Now bool.
2934         (tui_set_win_highlight): Don't declare.
2935         * tui/tui-data.c (tui_set_win_highlight): Remove.
2936
2937 2019-06-25  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-wingeneral.c (make_visible): Remove check of window
2940         type.
2941
2942 2019-06-25  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-win.c (tui_win_info::max_height)
2945         (tui_cmd_window::max_height): New methods.
2946         (new_height_ok): Call max_height.
2947         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2948         <max_height>: New method.
2949
2950 2019-06-25  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-win.c (tui_source_window_base::set_new_height)
2953         (tui_data_window::set_new_height): New methods.
2954         (make_invisible_and_set_new_height): Call set_new_height method.
2955         * tui/tui-data.h (struct tui_win_info)
2956         (struct tui_source_window_base, struct tui_data_window)
2957         <set_new_height>: New method.
2958
2959 2019-06-25  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2962         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2963         tui_refresh_data_win.
2964         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2965         method.
2966         (tui_refresh_all_win): Call the refresh_all method.
2967         (tui_set_focus): Likewise.
2968         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2969         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2970         Likewise.
2971
2972 2019-06-25  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-winsource.h (tui_refill_source_window)
2975         (tui_set_is_exec_point_at): Don't declare.
2976         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2977         (tui_source_window_base::refill): Rename from
2978         tui_refill_source_window.
2979         (tui_source_window_base::do_scroll_horizontal): Update.
2980         (tui_source_window_base::set_is_exec_point_at): Rename from
2981         tui_set_is_exec_point_at.
2982         (tui_update_all_breakpoint_info): Update.
2983         * tui/tui-stack.c (tui_show_frame_info): Update.
2984         * tui/tui-layout.c (show_data): Add cast.
2985         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2986         * tui/tui-data.h (struct tui_source_window_base) <refill,
2987         set_is_exec_point_at>: New methods.
2988         (tui_source_windows, tui_add_to_source_windows): Update types.
2989         (tui_add_to_source_windows): Remove redundant declaration.
2990         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2991         (tui_source_windows): Change return type.
2992         (tui_clear_source_windows_detail): Update.
2993         (tui_add_to_source_windows): Change type of parameter.
2994         (tui_free_all_source_wins_content): Update.
2995
2996 2019-06-25  Tom Tromey  <tom@tromey.com>
2997
2998         * tui/tui-wingeneral.c (tui_win_info::refresh)
2999         (tui_source_window_base::refresh): New methods.
3000         (tui_refresh_all): Call the refresh method.
3001         * tui/tui-data.h (struct tui_win_info)
3002         (struct tui_source_window_base) <refresh>: New method.
3003
3004 2019-06-25  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui.h (tui_is_window_visible): Return bool.
3007         * tui/tui.c (tui_is_window_visible): Return bool.
3008         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3009         (tui_make_visible, tui_make_invisible)
3010         (tui_win_info::make_visible)
3011         (tui_source_window_base::make_visible, make_all_visible)
3012         (tui_make_all_visible, tui_make_all_invisible): Update.
3013         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3014         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3015         bool.
3016         (struct tui_win_info, struct tui_source_window_base)
3017         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3018         * tui/tui-data.c (tui_init_generic_part): Update.
3019
3020 2019-06-25  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3023         (tui_source_window_base::make_visible): New methods.
3024         (make_all_visible): Make method call.
3025         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3026         (struct tui_source_window_base, struct tui_cmd_window): Override
3027         make_visible.
3028         (tui_win_is_source_type): Don't declare.
3029         * tui/tui-data.c (tui_win_is_source_type): Remove.
3030
3031 2019-06-25  Tom Tromey  <tom@tromey.com>
3032
3033         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3034         NULL check.
3035
3036 2019-06-25  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3039         Inline constructor.  Add initializers for members.
3040         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3041         constructors; now inline in class.
3042
3043 2019-06-25  Tom Tromey  <tom@tromey.com>
3044
3045         * tui/tui-regs.c (tui_show_registers): Update.
3046         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3047         bool.
3048         * tui/tui-data.c (tui_data_window::clear_detail)
3049         (tui_data_window): Update.
3050
3051 2019-06-25  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-windata.c (tui_display_all_data)
3054         (tui_display_data_from_line, tui_display_data_from)
3055         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3056         Update.
3057         * tui/tui-regs.c (tui_last_regs_line_no)
3058         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3059         (tui_show_registers, tui_show_register_group)
3060         (tui_display_registers_from, tui_display_reg_element_at_line)
3061         (tui_display_registers_from_line, tui_check_register_values)
3062         (tui_reg_next, tui_reg_prev): Update.
3063         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3064         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3065         tui_data_window.
3066         (struct tui_win_info) <detail>: Remove.  Add new fields from
3067         tui_data_info.
3068         (TUI_DATA_WIN): Add cast.
3069         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3070         (~tui_data_window): Simplify.
3071
3072 2019-06-25  Tom Tromey  <tom@tromey.com>
3073
3074         * tui/tui-layout.c (show_source_disasm_command)
3075         (show_source_or_disasm_and_command): Update.
3076         * tui/tui-io.c (update_cmdwin_start_line)
3077         (tui_redisplay_readline): Update.
3078         * tui/tui-data.h (struct tui_command_info): Remove.
3079         (struct tui_win_info) <detail>: Remove command_info member.
3080         (struct tui_data_window) <start_line>: New member, from
3081         tui_command_info.
3082         (TUI_CMD_WIN): Add casts.
3083
3084 2019-06-25  Tom Tromey  <tom@tromey.com>
3085
3086         * tui/tui-winsource.c (tui_update_source_window)
3087         (tui_refill_source_window)
3088         (tui_source_window_base::do_scroll_horizontal)
3089         (tui_update_breakpoint_info, tui_set_exec_info_content)
3090         (tui_show_exec_info_content, tui_erase_exec_info_content)
3091         (tui_clear_exec_info_content): Update.
3092         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3093         Update.
3094         * tui/tui-win.c (make_invisible_and_set_new_height)
3095         (make_visible_with_new_height): Update.
3096         * tui/tui-source.c (tui_set_source_content)
3097         (tui_show_symtab_source): Update.
3098         * tui/tui-layout.c (extract_display_start_addr)
3099         (show_source_disasm_command, show_data)
3100         (make_source_or_disasm_window)
3101         (show_source_or_disasm_and_command): Update.
3102         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3103         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3104         "gdbarch".
3105         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3106         to tui_source_window_base.
3107         (struct tui_win_info) <detail>: Remove source_info member.
3108         (struct tui_source_window_base) <has_locator>: Inline.
3109         Move contents from tui_source_info; rename has_locator member to
3110         m_has_locator.
3111         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3112         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3113         header file.
3114         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3115         Simplify.
3116         (tui_free_all_source_wins_content): Cast to
3117         tui_source_window_base.
3118
3119 2019-06-25  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-win.c (make_invisible_and_set_new_height)
3122         (make_visible_with_new_height): Call has_locator method.
3123         * tui/tui-layout.c (show_source_disasm_command, show_data)
3124         (show_source_or_disasm_and_command): Update for bool change.
3125         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3126         (tui_win_info) <has_locator>: New method.
3127         (struct tui_source_window_base) <has_locator>: New method.
3128         (tui_win_has_locator): Don't declare.
3129         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3130         from tui_win_has_locator.
3131         (tui_source_window_base): Use false, not FALSE.
3132
3133 2019-06-25  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3136         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3137         clear_detail method directly.
3138         (tui_clear_win_detail): Remove.
3139
3140 2019-06-25  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3143         "this", not TUI_DISASM_WIN.
3144
3145 2019-06-25  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3148         declare.
3149         * tui/tui-winsource.c
3150         (tui_source_window_base::do_scroll_horizontal): Rename from
3151         tui_horizontal_source_scroll.
3152         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3153         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3154         from tui_vertical_data_scroll.
3155         * tui/tui-win.h (tui_scroll): Don't declare.
3156         * tui/tui-win.c (tui_win_info::forward_scroll)
3157         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3158         (tui_win_info::right_scroll): Rename and update.
3159         (tui_scroll_forward_command, tui_scroll_backward_command)
3160         (tui_scroll_left_command, tui_scroll_right_command): Update.
3161         (tui_scroll): Remove.
3162         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3163         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3164         from tui_vertical_source_scroll.
3165         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3166         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3167         from tui_vertical_disassem_scroll.
3168         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3169         do_scroll_horizontal>: New methods.
3170         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3171         Likewise.
3172         (struct tui_source_window_base): Add do_scroll_horizontal.
3173         (struct tui_source_window, struct tui_disasm_window): Add
3174         do_scroll_vertical.
3175         (struct tui_data_window, struct tui_cmd_window): Add
3176         do_scroll_horizontal and do_scroll_vertical.
3177         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3178
3179 2019-06-25  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui-data.h (struct tui_source_window_base): New struct.
3182         (struct tui_source_window): Derive from tui_source_window_base.
3183         (struct tui_disasm_window): New struct.
3184         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3185         from tui_source_window::clear_detail.
3186         (tui_source_window_base): Rename from tui_source_window.
3187         (~tui_source_window_base): Rename from ~tui_source_window.
3188         (tui_alloc_win_info): Create a tui_disasm_window.
3189
3190 2019-06-25  Tom Tromey  <tom@tromey.com>
3191
3192         * tui/tui-data.h (struct tui_source_window)
3193         (struct tui_data_window): Declare destructors.
3194         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3195         destructors.
3196         (tui_win_info): Simplify.
3197
3198 2019-06-25  Tom Tromey  <tom@tromey.com>
3199
3200         * tui/tui-winsource.c (tui_display_main)
3201         (tui_update_source_windows_with_addr)
3202         (tui_update_all_breakpoint_info): Update.
3203         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3204         (new_height_ok, parse_scrolling_args): Update.
3205         * tui/tui-stack.c (tui_show_frame_info): Update.
3206         * tui/tui-data.h (struct tui_list): Remove.
3207         (tui_source_windows): Return a reference to a std::vector.
3208         * tui/tui-data.c (source_windows): Now a std::vector.
3209         (tui_source_windows): Change return type.
3210         (tui_clear_source_windows): Rewrite.
3211         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3212         (tui_free_all_source_wins_content): Rewrite.
3213
3214 2019-06-25  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3217         (struct tui_data_window, struct tui_cmd_window): Declare
3218         clear_detail method.
3219         * tui/tui-data.c (tui_source_window::clear_detail)
3220         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3221         methods.
3222         (tui_clear_win_detail): Simplify.
3223
3224 2019-06-25  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui-layout.c (make_source_window, make_disasm_window)
3227         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3228         Return the new window.
3229         (show_source_disasm_command, show_data)
3230         (show_source_or_disasm_and_command): Update.
3231
3232 2019-06-25  Tom Tromey  <tom@tromey.com>
3233
3234         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3235         parameter.  Return the new window.
3236         (show_source_disasm_command): Update and remove NULL check.
3237         (show_source_or_disasm_and_command): Update.
3238
3239 2019-06-25  Tom Tromey  <tom@tromey.com>
3240
3241         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3242
3243 2019-06-25  Tom Tromey  <tom@tromey.com>
3244
3245         * tui/tui-data.h (struct tui_win_info): Make constructor
3246         protected.  Make destructor virtual.  Add initializers.
3247         (tui_source_window, tui_data_window, tui_cmd_window): New
3248         classes.
3249         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3250         constructor.  Add "type" parameter.
3251         (tui_source_window, tui_data_window, tui_cmd_window): New
3252         constructors.
3253         (tui_alloc_win_info): Instantiate the appropriate subclass.
3254
3255 2019-06-25  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui-win.c (tui_resize_all): Use delete.
3258         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3259         destructor.
3260         (tui_free_window): Don't declare.
3261         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3262         Update.
3263
3264 2019-06-25  Tom Tromey  <tom@tromey.com>
3265
3266         * tui/tui-data.h (struct tui_win_info): Add constructor.
3267         * tui/tui-data.c (tui_alloc_win_info): Use new.
3268         (tui_free_window): Use delete.
3269
3270 2019-06-22  Tom Tromey  <tom@tromey.com>
3271
3272         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3273         declare.
3274         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3275
3276 2019-06-22  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3279         declare.
3280         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3281
3282 2019-06-22  Tom de Vries  <tdevries@suse.de>
3283
3284         * dwarf2read.c (create_addrmap_from_aranges)
3285         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3286         instead of '%zu'.
3287
3288 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3289
3290         * dwarf2read.h (dwarf2_section_info_def): Remove.
3291         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3292         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3293         std::vector<dwarf2_section_info>.
3294         (struct dwo_file) <~dwo_file>: Remove.
3295         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3296         types field.
3297         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3298         (dwarf2_read_debug_names): Likewise.
3299         (create_debug_types_hash_table): Change parameter type to
3300         array_view, adjust code accordingly.
3301         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3302         (partial_die_info::fixup): Likewise.
3303         (determine_prefix): Likewise.
3304         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3305
3306 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3307
3308         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3309         gdb_bfd_ref_ptr.
3310         <~dwo_file>: Remove call to gdb_bfd_unref.
3311         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3312         gdb_bfd_ref_ptr::get.
3313
3314 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3315
3316         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3317         type to htab_up.
3318         * dwarf2read.c (struct dwo_file): Initialize fields.
3319         <~dwo_file>: New.
3320         (free_dwo_file): Remove, move content to ~dwo_file.
3321         (struct dwo_file_deleter): Remove.
3322         (dwo_file_up>: Remove custom deleter.
3323         (free_dwo_files): Remove.
3324         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3325         dwo_files.
3326         (process_skeletonless_type_units): Call unique_ptr::get.
3327         (allocate_dwo_file_hash_table): Add deleter to created hash
3328         table.  Change return type to htab_up.
3329         (lookup_dwo_file_slot): Don't memset dwo_file, call
3330         unique_ptr::get.
3331         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3332         (create_dwo_unit_in_dwp_v2): Likewise.
3333         (open_and_init_dwo_file): Likewise.
3334         (free_dwo_file_from_slot): Remove.
3335
3336 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3337
3338         * dwarf2read.h (struct dwarf2_section_info) <readin,
3339         is_virtual>: Change type to bool.
3340         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3341         true instead of 1.
3342
3343 2019-06-19  Tom Tromey  <tom@tromey.com>
3344
3345         * tui/tui-data.h (tui_init_content_element): Don't declare.
3346
3347 2019-06-19  Tom Tromey  <tom@tromey.com>
3348
3349         * tui/tui-data.h (tui_init_win_info): Don't declare.
3350
3351 2019-06-19  Tom de Vries  <tdevries@suse.de>
3352
3353         * dwarf2read.h (abstract_to_concrete): Change type to
3354         std::unordered_map<sect_offset, std::vector<sect_offset>,
3355         gdb::hash_enum<sect_offset>>.
3356
3357 2019-06-19  Tom Tromey  <tromey@adacore.com>
3358
3359         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3360         EVAL_AVOID_SIDE_EFFECTS specially.
3361
3362 2019-06-19  Tom Tromey  <tromey@adacore.com>
3363
3364         * source-cache.c (highlighter): New global.
3365         (source_cache::get_source_lines): Create a highlighter on demand.
3366
3367 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3368
3369         * defs.h (deprecated_interactive_hook): Delete declaration.
3370         * interps.c (clear_interpreter_hooks): Remove use of
3371         deprecated_interactive_hook.
3372         * top.c (deprecated_interactive_hook): Delete definition.
3373         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3374
3375 2019-06-18  Tom de Vries  <tdevries@suse.de>
3376
3377         PR gdb/24515
3378         * dwarf2read.h (abstract_to_concrete): Change type from
3379         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3380         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3381         * dwarf2read.c (read_variable): Update.
3382         (dwarf2_fetch_die_loc_sect_off): Update.
3383
3384 2019-06-17  Tom de Vries  <tdevries@suse.de>
3385
3386         PR gdb/24617
3387         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3388         accessing parent[parent_len - 1].
3389
3390 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3391
3392         PR gdb/24364
3393         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3394         call dtrace_process_dof with NULL dof.
3395
3396 2019-06-16  Tom de Vries  <tdevries@suse.de>
3397
3398         PR gdb/24445
3399         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3400
3401 2019-06-16  Tom Tromey  <tom@tromey.com>
3402
3403         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3404         (make_all_visible): Use address of member.
3405
3406 2019-06-16  Tom Tromey  <tom@tromey.com>
3407
3408         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3409         (tui_free_window, free_content, free_content_elements): Remove
3410         unnecessary cast.
3411         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3412         cast.
3413         * tui/tui-regs.c (tui_show_register_group)
3414         (tui_display_registers_from, tui_display_reg_element_at_line):
3415         Remove unnecessary cast.
3416
3417 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3418
3419         * linux-nat.c (normal_mask): Delete.
3420         (_initialize_linux_nat): Don't initialise normal_mask.
3421
3422 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3423
3424         PR gdb/24445
3425         * dwarf-index-write.h (write_psymtabs_to_index): Add
3426         dwz_basename parameter.
3427         * dwarf-index-write.c (write_gdbindex): Move file writing to
3428         write_gdbindex_1.  Change return type void.
3429         (assert_file_size): Move up, remove filename parameter.
3430         (write_gdbindex_1): New function.
3431         (write_debug_names): Change return type to void, call
3432         assert_file_size.
3433         (struct index_wip_file): New struct.
3434         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3435         file logic to index_wip_file.  Write index for dwz file if
3436         needed.
3437         (save_gdb_index_command): Pass basename of dwz file, if present.
3438         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3439         build-id of dwz file, if present.
3440         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3441         (dwarf2_get_dwz_file): Likewise.
3442         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3443         (dwarf2_get_dwz_file): Likewise.
3444
3445 2019-06-16  Tom Tromey  <tom@tromey.com>
3446
3447         * coffread.c (process_coff_symbol): Use xstrdup.
3448         * value.c (create_internalvar): Use xstrdup.
3449
3450 2019-06-16  Tom Tromey  <tom@tromey.com>
3451
3452         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3453         * breakpoint.c (stopin_command, stopat_command)
3454         (until_break_command, decode_location_default): Remove unnecessary
3455         cast.
3456         * utils.c (subset_compare): Remove unnecessary cast.
3457         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3458         cast.
3459         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3460         cast.
3461         * infcmd.c (path_command): Remove unnecessary cast.
3462         * coffread.c (decode_type): Remove unnecessary cast.
3463         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3464         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3465         * tui/tui-stack.c (tui_show_locator_content)
3466         (tui_show_frame_info): Remove unnecessary cast.
3467         * tui/tui-win.c (tui_scroll_forward_command)
3468         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3469         (parse_scrolling_args): Remove unnecessary cast.
3470         * tui/tui-data.c (init_win_info, tui_del_window)
3471         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3472         (free_content_elements): Remove unnecessary cast.
3473         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3474         unnecessary cast.
3475         * tui/tui-source.c (tui_set_source_content)
3476         (tui_vertical_source_scroll): Remove unnecessary cast.
3477         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3478         cast.
3479         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3480         * tui/tui-regs.c (tui_display_registers_from)
3481         (tui_display_register): Remove unnecessary cast.
3482         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3483         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3484         (make_visible): Remove unnecessary cast.
3485         * tui/tui-winsource.c (tui_erase_source_content)
3486         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3487         unnecessary cast.
3488         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3489         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3490         * stabsread.c (read_type, read_array_type, read_range_type):
3491         Remove unnecessary cast.
3492         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3493         (parse_symbol, parse_type, upgrade_type, parse_external)
3494         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3495         unnecessary cast.
3496         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3497
3498 2019-06-16  Tom Tromey  <tom@tromey.com>
3499
3500         * tui/tui-data.c (tui_alloc_generic_win_info)
3501         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3502         checks.
3503
3504 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3505             Andrew Burgess  <andrew.burgess@embecosm.com>
3506
3507         * f-typeprint.c (f_print_type): Don't return early for not
3508         associated or not allocated types.
3509         (f_type_print_varspec_suffix): Add print_rank parameter and print
3510         ranks of array types in case they dangling.
3511         (f_type_print_base): Add print_rank parameter.
3512
3513 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3514
3515         * NEWS: Mention new MI commands.
3516         * break-catch-throw.c (enum exception_event_kind): Move to
3517         breakpoint.h.
3518         (print_mention_exception_catchpoint): Output text as a single
3519         message.
3520         (catch_exception_command_1): Rename to...
3521         (catch_exception_event): ...this, make non-static, update header
3522         command, and change some parameter types.
3523         (catch_catch_command): Update for changes to
3524         catch_exception_command_1.
3525         (catch_throw_command): Likewise.
3526         (catch_rethrow_command): Likewise.
3527         * breakpoint.c (enum exception_event_kind): Delete.
3528         * breakpoint.h (enum exception_event_kind): Moved here from
3529         break-catch-throw.c.
3530         (catch_exception_event): Declare.
3531         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3532         (mi_cmd_catch_throw): New function.
3533         (mi_cmd_catch_rethrow): New function.
3534         (mi_cmd_catch_catch): New function.
3535         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3536         'catch-catch' entries.
3537         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3538         (mi_cmd_catch_rethrow): Declare.
3539         (mi_cmd_catch_catch): Declare.
3540
3541 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3542
3543         * annotate.c (annotate_source_line): Change return type to void,
3544         update implementation to match.
3545         * annotate.h (annotate_source_line): Change return type to void,
3546         update header comment.
3547         * stack.c (print_frame_info): Don't change what frame information
3548         is printed based on whether annotations are on or not.
3549
3550 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3551
3552         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3553         (annotate_source): Make static.
3554         (annotate_source_line): Moved from source.c and renamed from
3555         identify_source_line.  Update the return type.
3556         * annotate.h (annotate_source): Delete declaration.
3557         (annotate_source_line): Declaration moved from source.h, and
3558         renamed from identify_source_line.  Return type updated.
3559         * source.c (identify_source_line): Moved to annotate.c and renamed
3560         to annotate_source_line.
3561         (info_line_command): Remove check of annotation_level.
3562         * source.h (identify_source_line): Move declaration to annotate.h
3563         and rename to annotate_source_line.
3564         * stack.c: Add 'annotate.h' include.
3565         (print_frame_info): Remove check of annotation_level before
3566         calling annotate_source_line.
3567
3568 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3569
3570         * source-cache.c (source_cache::get_plain_source_lines): Use
3571         open_source_file_with_line_charpos instead of just
3572         open_source_file, remove call to find_source_lines.
3573         (source_cache::get_source_lines): Likewise.
3574         * source.c (find_source_lines): Make static.
3575         (get_filename_and_charpos): Renamed into...
3576         (open_source_file_with_line_charpos): ..this along with changes to
3577         return a scoped_fd, and some other minor clean ups.
3578         (identify_source_line): Use open_source_file_with_line_charpos.
3579         (search_command_helper): Use open_source_file_with_line_charpos
3580         instead of just open_source_file, remove call to
3581         find_source_lines.
3582         * source.h (open_source_file_with_line_charpos): Declare new
3583         function.
3584         (find_source_lines): Delete declaration.
3585
3586 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3587
3588         * source.c (get_filename_and_charpos): Remove fullname
3589         parameter.
3590         (identify_source_line): Update call to get_filename_and_charpos.
3591
3592 2019-06-14  Tom Tromey  <tromey@adacore.com>
3593
3594         PR gdb/24502:
3595         * ui-style.h (skip_ansi_escape): Update comment.
3596         * ui-file.h (class no_terminal_escape_file): New class.
3597         * ui-file.c (no_terminal_escape_file::write)
3598         (no_terminal_escape_file::puts): New methods.
3599         * cli/cli-logging.c (handle_redirections): Use
3600         no_terminal_escape_file.
3601
3602 2019-06-14  Tom Tromey  <tromey@adacore.com>
3603
3604         * NEWS: Move convenience variable news above Python news.
3605
3606 2019-06-14  Tom Tromey  <tom@tromey.com>
3607
3608         * gnulib: Move directory to top-level.
3609         * configure.ac: Don't configure gnulib.
3610         * configure: Rebuild.
3611         * common/common-defs.h: Use new path to gnulib.
3612         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3613         (GNULIB_H): Remove.
3614         (INCGNU): Look in new gnulib location.
3615         (HFILES_NO_SRCDIR): Remove gnulib files.
3616         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3617         (generated_files): Remove GNULIB_H.
3618         ($(LIBGNU), all-lib): Remove targets.
3619         (distclean): Don't mention GNULIB_BUILDDIR.
3620         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3621
3622 2019-06-14  Tom Tromey  <tromey@adacore.com>
3623
3624         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3625         Warn if symbol file does not provide any symbols.
3626
3627 2019-06-14  Tom Tromey  <tromey@adacore.com>
3628
3629         * source.c (find_and_open_source): Respect basenames_may_differ.
3630
3631 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3632
3633         * annotate.c (annotate_breakpoints_invalid): Make use of
3634         scoped_restore_terminal_state.
3635         (annotate_frames_invalid): Likewise.
3636
3637 2019-06-14  Tom Tromey  <tromey@adacore.com>
3638
3639         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3640         allow assignment to an internalvar.
3641
3642 2019-06-14  Tom Tromey  <tromey@adacore.com>
3643
3644         * ada-lex.l: Allow "_" in attribute names.
3645
3646 2019-06-14  Tom Tromey  <tromey@adacore.com>
3647
3648         PR gdb/24653:
3649         * regcache.c (registers_changed): Don't call alloca.
3650         * top.c (execute_command): Don't call alloca.
3651
3652 2019-06-13  Pedro Alves  <palves@redhat.com>
3653
3654         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3655         'expression'.  When parsing an expression, error out if there's
3656         junk after "unlimited".
3657         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3658         (do_set_command): Adjust calls to is_unlimited_literal.
3659
3660 2019-06-13  Pedro Alves  <palves@redhat.com>
3661
3662         * compile/compile.c (make_compile_options_def_group): Add braces
3663         around array_view initializer.
3664         * thread.c (make_thread_apply_all_options_def_group)
3665         (make_thread_apply_all_options_def_group): Likewise.
3666
3667 2019-06-13  Pedro Alves  <palves@redhat.com>
3668
3669         * NEWS (New commands): Mention "maint test-options
3670         require-delimiter", "maint test-options unknown-is-error", "maint
3671         test-options unknown-is-operand" and "maint show
3672         test-options-completion-result".
3673         (New command options, command completion): New section.
3674         (Completion improvements): New section.
3675         Mention that you can abbreviate "unlimited".
3676
3677 2019-06-13  Pedro Alves  <palves@redhat.com>
3678
3679         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3680         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3681         * unittests/cli-utils-selftests.c (test_parse_flags)
3682         (test_parse_flags_qcs): Delete.
3683         (test_cli_utils): Don't call deleted functions.
3684
3685 2019-06-13  Pedro Alves  <palves@redhat.com>
3686
3687         * thread.c: Include "cli/cli-option.h".
3688         (tp_array_compar_ascending): Global.
3689         (tp_array_compar): Delete function.
3690         (tp_array_compar_ascending, tp_array_compar_descending): New
3691         functions.
3692         (ascending_option_def, qcs_flag_option_def)
3693         (thr_qcs_flags_option_defs)
3694         (make_thread_apply_all_options_def_group)
3695         (make_thread_apply_options_def_group): New.
3696         (thread_apply_all_command): Use gdb::option::process_options.
3697         (thread_apply_command_completer)
3698         (thread_apply_all_command_completer): New.
3699         (thread_apply_command): Use gdb::option::process_options.
3700         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3701         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3702         to generate help text of "thread apply".  Adjust "taas"'s help.
3703         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3704         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3705
3706 2019-06-13  Pedro Alves  <palves@redhat.com>
3707
3708         * thread.c (thread_apply_command): Check for invalid TID with
3709         isdigit instead of !isalpha.
3710
3711 2019-06-13  Pedro Alves  <palves@redhat.com>
3712
3713         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3714         (validate_flags_qcs): New.
3715         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3716         (validate_flags_qcs): Declare.
3717         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3718         (make_frame_apply_options_def_group): New.
3719         (frame_apply_command_count): Process options with
3720         gdb::option::process_options.
3721         (frame_apply_completer): New.
3722         (frame_apply_level_completer, frame_apply_all_completer)
3723         (frame_apply_completer): New.
3724         (_initialize_stack): Update help of "frame apply", "frame apply
3725         level", "frame apply all" and "faas" to mention supported options
3726         and install command completers.
3727         * stack.h (frame_apply_all_completer): Declare.
3728         * thread.c: Include "stack.h".
3729         (tfaas_command): Add "--".
3730         (_initialize_thread): Update help "tfaas" to mention supported
3731         options and install command completer.
3732
3733 2019-06-13  Pedro Alves  <palves@redhat.com>
3734
3735         * completer.c (complete_nested_command_line): New.
3736         (gdb_completion_word_break_characters_throw): Add assertion.
3737         * completer.h (complete_nested_command_line): Declare.
3738
3739 2019-06-13  Pedro Alves  <palves@redhat.com>
3740
3741         * stack.c (parse_backtrace_qualifiers): New.
3742         (backtrace_command): Use it.
3743         (backtrace_command_completer): Complete on qualifiers.
3744
3745 2019-06-13  Pedro Alves  <palves@redhat.com>
3746
3747         * frame.c: Include "cli/cli-option.h.
3748         (user_set_backtrace_options): New.
3749         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3750         Delete.
3751         (get_prev_frame): Adjust.
3752         (boolean_option_def, uinteger_option_def)
3753         (set_backtrace_option_defs): New.
3754         (_initialize_frame): Adjust and use
3755         gdb::option::add_setshow_cmds_for_options to install "set
3756         backtrace past-main" and "set backtrace past-entry".
3757         * frame.h: Include "cli/cli-option.h".
3758         (struct frame_print_options): Forward declare.
3759         (print_frame_arguments_all, print_frame_arguments_scalars)
3760         (print_frame_arguments_none): Declare.
3761         (print_entry_values): Delete declaration.
3762         (struct frame_print_options, user_frame_print_options): New.
3763         (struct set_backtrace_options): New.
3764         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3765         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3766         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3767         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3768         (list_args_or_locals): Add frame_print_options parameter.
3769         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3770         * python/py-framefilter.c (enumerate_args): Pass down
3771         USER_FRAME_PRINT_OPTIONS.
3772         * stack.c: Include "cli/cli-option.h".
3773         (print_frame_arguments_all, print_frame_arguments_scalars)
3774         (print_frame_arguments_none): Declare.
3775         (print_raw_frame_arguments, print_entry_values): Delete.
3776         (user_frame_print_options): New.
3777         (boolean_option_def, enum_option_def, frame_print_option_defs):
3778         New.
3779         (struct backtrace_cmd_options): New.
3780         (bt_flag_option_def): New.
3781         (backtrace_command_option_defs): New.
3782         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3783         (print_frame_arg, read_frame_arg, print_frame_args)
3784         (print_frame_info, print_frame): Add frame_print_options parameter
3785         and use it.
3786         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3787         (backtrace_command_1): Add frame_print_options and
3788         backtrace_cmd_options parameters and use them.
3789         (make_backtrace_options_def_group): New.
3790         (backtrace_command): Process command options with
3791         gdb::option::process_options.
3792         (backtrace_command_completer): New.
3793         (_initialize_stack): Extend "backtrace"'s help to mention
3794         supported options.  Install completer for "backtrace".
3795         Install some settings commands with add_setshow_cmds_for_options.
3796
3797 2019-06-13  Pedro Alves  <palves@redhat.com>
3798
3799         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3800         and that "set/show print raw frame-arguments" are now deprecated.
3801
3802         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3803         command.
3804         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3805         * stack.c (_initialize_stack): Install "set/show print
3806         raw-frame-arguments", and deprecate "set/show print raw
3807         frame-arguments".
3808         * valprint.c (_initialize_valprint): Deprecate "set/show print
3809         raw".
3810
3811 2019-06-13  Pedro Alves  <palves@redhat.com>
3812
3813         * compile/compile.c (struct compile_options): New.
3814         (compile_flag_option_def, compile_command_option_defs)
3815         (make_compile_options_def_group): New.
3816         (compile_file_command): Handle options with
3817         gdb::option::process_options.
3818         (compile_file_command_completer): New function.
3819         (compile_code_command): Handle options with
3820         gdb::option::process_options.
3821         (compile_code_command_completer): New function.
3822         (_initialize_compiler): Install completers for "compile code" and
3823         "compile file".  Mention available options in "compile code" and
3824         "compile code"'s help.
3825         * completer.c (advance_to_completion_word): New, factored out from
3826         ...
3827         (advance_to_expression_complete_word_point): ... this.
3828         (advance_to_filename_complete_word_point): New.
3829         * completer.h (advance_to_filename_complete_word_point): New
3830         declaration.
3831
3832 2019-06-13  Pedro Alves  <palves@redhat.com>
3833
3834         * compile/compile.c: Include "cli/cli-option.h".
3835         (compile_print_value): Scope data pointer is now a
3836         value_print_options pointer; adjust.
3837         (compile_print_command): Process options.  Scope data pointer is
3838         now a value_print_options pointer; adjust.
3839         (_initialize_compile): Update "compile print"'s help to include
3840         supported options.  Install a completer for "compile print".
3841         * cp-valprint.c (show_vtblprint, show_objectprint)
3842         (show_static_field_print): Delete.
3843         (_initialize_cp_valprint): Don't install "set print
3844         static-members", "set print vtbl", "set print object" here.
3845         * printcmd.c: Include "cli/cli-option.h" and
3846         "common/gdb_optional.h".
3847         (print_command_parse_format): Rework to fill in a
3848         value_print_options instead of a format_data.
3849         (print_value): Change parameter type from format_data pointer to
3850         value_print_options reference.  Adjust.
3851         (print_command_1): Process options.  Adjust to pass down a
3852         value_print_options.
3853         (print_command_completer): New.
3854         (_initialize_printcmd): Install print_command_completer as
3855         handle_brkchars completer for the "print" command.  Update
3856         "print"'s help to include supported options.
3857         * valprint.c: Include "cli/cli-option.h".
3858         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3859         here from cp-valprint.c.
3860         (boolean_option_def, uinteger_option_def)
3861         (value_print_option_defs, make_value_print_options_def_group):
3862         New.  Use gdb::option::add_setshow_cmds_for_options to install
3863         "set print elements", "set print null-stop", "set print repeats",
3864         "set print pretty", "set print union", "set print array", "set
3865         print address", "set print symbol", "set print array-indexes".
3866         * valprint.h: Include <string> and "cli/cli-option.h".
3867         (make_value_print_options_def_group): Declare.
3868         (print_value): Change parameter type from format_data pointer to
3869         value_print_options reference.
3870         (print_command_completer): Declare.
3871
3872 2019-06-13  Pedro Alves  <palves@redhat.com>
3873
3874         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3875         (COMMON_SFILES): Add maint-test-settings.c.
3876         * cli/cli-decode.c (boolean_enums): New global, factored out from
3877         ...
3878         (add_setshow_boolean_cmd): ... here.
3879         * cli/cli-decode.h (boolean_enums): Declare.
3880         * cli/cli-option.c: New file.
3881         * cli/cli-option.h: New file.
3882         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3883         factored out from ...
3884         (parse_cli_boolean_value(const char *)): ... this.
3885         (is_unlimited_literal): Change parameter type to pointer to
3886         pointer.  Adjust and advance ARG pointer.
3887         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3888         (parse_cli_var_enum): New, factored out from ...
3889         (do_set_command): ... this.  Adjust.
3890         * cli/cli-setshow.h (parse_cli_boolean_value)
3891         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3892         (parse_cli_var_enum): Declare.
3893         * cli/cli-utils.c: Include "cli/cli-option.h".
3894         (get_ulongest): New.
3895         * cli/cli-utils.h (get_ulongest): Declare.
3896         (check_for_argument): New overloads.
3897         * maint-test-options.c: New file.
3898
3899 2019-06-13  Pedro Alves  <palves@redhat.com>
3900
3901         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3902         parse a range if "-" is at the end of the string.
3903
3904 2019-06-13  Pedro Alves  <palves@redhat.com>
3905
3906         * cli/cli-setshow.c (parse_auto_binary_operation)
3907         (parse_cli_boolean_value): Don't allow "o".
3908
3909 2019-06-13  Pedro Alves  <palves@redhat.com>
3910
3911         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3912         * NEWS: Mention maint test-settings KIND.
3913         * maint-test-settings.c: New file.
3914
3915 2019-06-13  Pedro Alves  <palves@redhat.com>
3916
3917         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3918         completer.
3919         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3920         "set" completers.
3921
3922 2019-06-13  Pedro Alves  <palves@redhat.com>
3923
3924         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3925         after item.
3926
3927 2019-06-13  Pedro Alves  <palves@redhat.com>
3928
3929         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3930
3931 2019-06-13  Pedro Alves <palves@redhat.com>
3932
3933         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3934         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3935         call.
3936         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3937         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3938         calls.
3939         (check_for_argument): Skip spaces after argument.
3940
3941 2019-06-13  Pedro Alves  <palves@redhat.com>
3942
3943         * thread.c (thread_apply_command): Adjust TID parsing.
3944         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3945         detected before end of string.
3946         (tid_is_in_list): Error out if LIST is invalid.
3947
3948 2019-06-13  Pedro Alves  <palves@redhat.com>
3949
3950         * completer.c (complete_line_internal_1): Rewind completion word
3951         point.
3952         (completion_tracker::advance_custom_word_point_by): Change
3953         parameter type to int.
3954         * completer.h (completion_tracker::advance_custom_word_point_by):
3955         Likewise.
3956
3957 2019-06-13  Pedro Alves  <palves@redhat.com>
3958
3959         * completer.c (advance_to_completion_word): Handle delimiters.
3960
3961 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3962
3963         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3964
3965 2019-06-11  Tom Tromey  <tom@tromey.com>
3966
3967         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3968         (xmalloc_failed): Move to alloc.c.
3969         * alloc.c: New file.
3970         * Makefile.in (COMMON_SFILES): Add alloc.c.
3971
3972 2019-06-11  Tom Tromey  <tom@tromey.com>
3973
3974         * nat/linux-waitpid.c: Don't include server.h.
3975         (linux_debug): Remove.
3976         (my_waitpid): Update.
3977
3978 2019-06-11  Tom Tromey  <tromey@adacore.com>
3979
3980         * infcall.c (_initialize_infcall): Remove trailing newline from
3981         help.
3982         * user-regs.c (_initialize_user_regs): Remove trailing newline
3983         from help.
3984         * typeprint.c (_initialize_typeprint): Remove trailing newline
3985         from help.
3986         * reverse.c (_initialize_reverse): Remove trailing newlines from
3987         help.
3988         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3989         from help.
3990         * language.c (add_set_language_command): Remove trailing newline
3991         from help.
3992         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3993         help.
3994         * disasm.c (_initialize_disasm): Remove trailing newline from
3995         help.
3996         * top.c (init_main): Remove trailing newline from help.
3997         * interps.c (_initialize_interpreter): Remove trailing newline
3998         from help.
3999         * btrace.c (_initialize_btrace): Remove trailing newlines from
4000         help.
4001         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4002         from help.
4003         * python/python.c (_initialize_python): Remove trailing newline
4004         from help.
4005         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4006         help.
4007         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4008         from help.  Reformat some text.
4009         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4010         from help.
4011         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4012         newline from help.
4013
4014 2019-06-11  Tom Tromey  <tromey@adacore.com>
4015
4016         * darwin-nat.c (darwin_decode_exception_message)
4017         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4018
4019 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4020
4021         * valops.c (value_slice): Check for not allocated or not
4022         associated values.
4023
4024 2019-06-10  Tom de Vries  <tdevries@suse.de>
4025
4026         PR gdb/24618
4027         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4028         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4029         invalid.
4030
4031 2019-06-10  Tom de Vries  <tdevries@suse.de>
4032
4033         PR gdb/24611
4034         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4035         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4036
4037 2019-06-10  Tom de Vries  <tdevries@suse.de>
4038
4039         PR symtab/24545
4040         * symtab.c (struct demangled_name_entry): Add language field.
4041         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4042         static minimal symbol".  Set and use language field.
4043
4044 2019-06-10  Tom Tromey  <tromey@adacore.com>
4045
4046         * ada-lang.c (_initialize_ada_language): Update help text.
4047
4048 2019-06-10  Tom Tromey  <tromey@adacore.com>
4049
4050         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4051         with a newline.
4052         * guile/guile.c (handle_boot_error): Don't end warning with a
4053         newline.
4054         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4055         warning with a newline.
4056         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4057         newline.
4058         (s12z_frame_cache): Likewise.
4059         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4060         a newline.
4061         * solib-svr4.c (disable_probes_interface): Don't end warning with
4062         a newline.
4063         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4064         newline.
4065         * python/python.c (do_finish_initialization): Don't end warning
4066         with a newline.
4067
4068 2019-06-10  Tom Tromey  <tom@tromey.com>
4069
4070         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4071         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4072         gdbpy_enter.
4073
4074 2019-06-10  Tom Tromey  <tromey@adacore.com>
4075
4076         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4077         data.
4078         (elf_new_init): Don't call stabsread_new_init.
4079         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4080         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4081         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4082
4083 2019-06-10  Tom de Vries  <tdevries@suse.de>
4084
4085         PR symtab/16264
4086         PR symtab/24517
4087         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4088
4089 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4090
4091         * source.c (find_and_open_source): Also rewrite relative file
4092         names.
4093
4094 2019-04-26  Amos Bird  <amosbird@gmail.com>
4095
4096         * annotate.c (annotate_thread_exited): Add "thread-exited"
4097         annotation.
4098
4099 2019-06-06  Tom Tromey  <tromey@adacore.com>
4100
4101         * maint.h (class scoped_command_stats): Use
4102         DISABLE_COPY_AND_ASSIGN.
4103         <print_time>: New method.
4104         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4105         print_time.
4106         (scoped_command_stats::print_time): New method.
4107
4108 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4109
4110         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4111         instructions of lengths 6 or 8 bytes.
4112
4113 2019-06-04  Pedro Alves  <palves@redhat.com>
4114
4115         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4116
4117         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4118         * breakpoint.c (condition_completer): Likewise.
4119         * cli/cli-dump.c (scan_expression): Likewise.
4120         * common/filestuff.c (mkdir_recursive): Likewise.
4121         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4122         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4123         (gdb_abspath): Likewise.
4124         * compile/compile-cplus-types.c
4125         (compile_cplus_instance::decl_name): Likewise.
4126         * completer.c (complete_explicit_location):
4127         (signal_completer, reg_or_group_completer_1): Likewise.
4128         * cp-support.c (cp_remove_params_if_any): Likewise.
4129         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4130         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4131         * infcmd.c (strip_bg_char): Likewise.
4132         * linespec.c (copy_token_string): Likewise.
4133         * mi/mi-main.c (output_cores): Likewise.
4134         * psymtab.c (psymtab_search_name):
4135         * symfile.c (test_set_ext_lang_command): Likewise.
4136         * target.c (target_fileio_read_stralloc): Likewise.
4137         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4138         * value.c (complete_internalvar): Likewise.
4139
4140 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4141
4142         Add objfile property to gdb.Type.
4143         * NEWS: Mention Python API addition.
4144         * python/py-type.c (typy_get_objfile): New method.
4145
4146 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4147
4148         * NEWS: Mention the new set|show style [title|highlight].
4149         Mention changes to "show style", "help" and "apropos".
4150
4151 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4152
4153         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4154         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4155         instead of print_help_for_command.
4156         (print_doc_of_command): New function.
4157         (help_list): Add 'apropos -v word' suggestion.
4158         (print_help_for_command): Style the command name using title style.
4159         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4160         (_initialize_cli_cmds): Describe -v in apropos_command help.
4161
4162 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4163
4164         * cli/cli-style.h (cli_style_option): Add name in constructor,
4165         add m_name class member, add constructor with intensity,
4166         add name class function.
4167         (cli_style_option::add_setshow_commands): Remove name argument.
4168         (highlight_style, title_style): New styles.
4169         * cli/cli-style.c (do_show): New function that shows a style
4170         characteristic styling the style name with itself.
4171         (set_style_name): New function.
4172         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4173         Update all callers according to the changes in cli/cli-style.h.
4174         * utils.h (fputs_highlighted): New function.
4175         * utils.c (fputs_highlighted): Likewise.
4176
4177 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4178
4179         * NEWS: Mention new pipe command and new convenience variables.
4180
4181 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4182
4183         * cli/cli-cmds.c (pipe_command): New function.
4184         (_initialize_cli_cmds): Call add_com for pipe_command.
4185         Define | as an alias for pipe.
4186         (exit_status_set_internal_vars): New function.
4187         (shell_escape): Call exit_status_set_internal_vars.
4188         cli/cli-decode.c (find_command_name_length): Recognize | as
4189         a single character command.
4190
4191 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4192
4193         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4194         top.c (execute_command_to_ui_file): New function, mostly a copy
4195         of execute_command_to_string.
4196         (execute_command_to_string): Implement by calling
4197         execute_command_to_ui_file.
4198
4199 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4200
4201         * top.h (saved_command_line): Remove declaration.
4202         * top.c (previous_saved_command_line, previous_repeat_arguments):
4203         New variables.
4204         (saved_command_line): Make static, define together with other
4205         'repeat variables'.
4206         (dont_repeat): Clear repeat_arguments.
4207         (repeat_previous, get_saved_command_line, save_command_line):
4208         New functions.
4209         (gdb_init): Initialize saved_command_line
4210         and previous_saved_command_line.
4211         * main.c (captured_main_1): Remove saved_command_line initialization.
4212         * event-top.c (handle_line_of_input): Update to use
4213         the new 'repeat' related functions instead of direct access to
4214         saved_command_line.
4215         * command.h (repeat_previous, get_saved_command_line,
4216         save_command_line): New declarations.
4217         (dont_repeat): Add comment.
4218
4219 2019-05-30  Tom Tromey  <tromey@adacore.com>
4220
4221         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4222         Fix comment.
4223         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4224
4225 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4226
4227         PR cli/24587
4228         * completer.c (complete): Initialize variable word.
4229
4230 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4231
4232         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4233         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4234         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4235         'body' is NULL to the outter 'if', protecting the '!is_define'
4236         situation as well.
4237
4238 2019-05-29  Tom Tromey  <tromey@adacore.com>
4239
4240         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4241         (dwarf_unknown): New function.
4242         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4243         (dwarf_type_encoding_name): Use dwarf_unknown.
4244
4245 2019-05-29  Tom Tromey  <tromey@adacore.com>
4246
4247         PR c++/20020:
4248         * cp-valprint.c (cp_print_value_fields): Call
4249         cp_print_static_field inside "try".
4250
4251 2019-05-29  Tom Tromey  <tromey@adacore.com>
4252
4253         * inflow.c (struct terminal_info): Add default operator=.
4254         * configure: Rebuild.
4255         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4256         -Wdeprecated-copy-dtor, -Wredundant-move.
4257
4258 2019-05-29  Tom Tromey  <tromey@adacore.com>
4259
4260         * NEWS: Add entry.
4261         * infcmd.c (print_return_value_1): Handle finish_print
4262         option.
4263         (show_print_finish): New function.
4264         (_initialize_infcmd): Add "set/show print finish" commands.
4265         * valprint.c (user_print_options): Initialize new member.
4266         * valprint.h (struct value_print_options) <finish_print>: New
4267         member.
4268
4269 2019-05-28  Tom Tromey  <tromey@adacore.com>
4270
4271         * ada-lang.c (ada_remove_Xbn_suffix)
4272         (find_old_style_renaming_symbol)
4273         (parse_old_style_renaming): Remove.
4274         (ada_find_renaming_symbol): Don't call
4275         find_old_style_renaming_symbol.
4276         (ada_is_renaming_symbol): Rename from
4277         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4278         bool.  Now static.
4279         (ada_read_var_value): Update and simplify.
4280         * ada-exp.y (write_var_or_type): Remove old code.
4281
4282 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4283
4284         * event-top.c: Remove include comment.
4285         * inflow.c (class scoped_ignore_sigttou): Move from here...
4286         * inflow.h (class scoped_ignore_sigttou): ...to here.
4287         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4288         * top.c:  Remove include comment.
4289
4290 2019-05-27  Tom Tromey  <tom@tromey.com>
4291
4292         * NEWS: Fix typo.
4293
4294 2019-05-22  Tom Tromey  <tromey@adacore.com>
4295
4296         * target.c (target_follow_exec): Constify parameter.
4297         * target-delegates.c: Rebuild.
4298         * remote.c (remote_target::follow_exec): Constify parameter.
4299         * infrun.c (follow_exec): Constify parameter.
4300         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4301         (target_follow_exec): Likewise.
4302
4303 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4304
4305         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4306         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4307
4308 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4309
4310         * NEWS: Add debugredirect and testsuite sections.
4311
4312 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4313
4314         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4315         target descriptions using exclusively floating point register name
4316         aliases.
4317
4318 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4319
4320         PR gdb/18644:
4321         * f-lang.c (build_fortran_types): Handle the case where
4322         gdbarch_floatformat_for_type returns a nullptr.
4323
4324 2019-05-21  Tom de Vries  <tdevries@suse.de>
4325
4326         PR cli/24587
4327         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4328
4329 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4330
4331         PR gdb/18644:
4332         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4333         16-byte floats.
4334         * i386-tdep.c (i386_floatformat_for_type): Use
4335         floatformats_ia64_quad for the 16-byte floating point component
4336         within a fortran 32-byte complex number.
4337
4338 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4339
4340         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4341         delete default constructor.
4342         (find_partial_die): Update to return const struct.
4343         (partial_die_parent_scope): Move variable declaration into scope
4344         of its use and change its type to auto.
4345         (guess_partial_die_structure_name): Likewise.
4346         (partial_die_info::fixup): Likewise.
4347
4348 2019-05-17  Tom Tromey  <tromey@adacore.com>
4349
4350         * source.c (find_and_open_source): Remove cast.
4351
4352 2019-05-17  Tom Tromey  <tromey@adacore.com>
4353
4354         * annotate.c (annotate_source): Make "filename" const.
4355         * annotate.h (annotate_source): Use const.
4356
4357 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4358
4359         * disasm.c (set_disassembler_options): Send errors to stderr.
4360
4361 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4362
4363         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4364         (cli_interp_base::set_logging): Check debug_redirect.
4365         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4366         * cli/cli-logging.c (debug_redirect): Add static variable.
4367         (pop_output_files): Add default param.
4368         (handle_redirections): Print debug setting.
4369         (show_logging_command): Likewise.
4370         (_initialize_cli_logging): Add debugredirect command.
4371         * interps.c (current_interp_set_logging): Add debug_redirect
4372         parameter.
4373         * interps.h (set_logging): Add debug_redirect parameter.
4374         (current_interp_set_logging): Likewise.
4375         * mi/mi-common.h: Likewise.
4376         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4377
4378 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4379             Tom Tromey  <tromey@adacore.com>
4380
4381         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4382         directly.
4383         * cli/cli-interp.h (make_logging_output): Remove declaration.
4384         * cli/cli-logging.c (make_logging_output): Remove function.
4385         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4386         directly.
4387         * ui-file.c (tee_file::tee_file): Remove bools.
4388         (tee_file::~tee_file): Remove deletes.
4389         * ui-file.h (tee_file): Remove bools.
4390
4391 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4392
4393         * mi/mi-cmds.h (mi_cmd_complete): New function.
4394         * mi/mi-main.c (mi_cmd_complete): Likewise.
4395         * mi/mi-cmds.c: Define new MI command -complete.
4396         * NEWS: Mention new -complete command.
4397
4398 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4399
4400         * completer.h (complete): New function.
4401         * completer.c (complete): Likewise.
4402         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4403         function defined in completer.h.
4404
4405 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4406
4407         * MAINTAINERS (Write After Approval): Add myself.
4408
4409 2019-05-17  Tom de Vries  <tdevries@suse.de>
4410
4411         PR gdb/24094
4412         * dwarf2read.c (struct cu_partial_die_info): New struct.
4413         (find_partial_die): Return cu_partial_die_info.
4414         (partial_die_parent_scope, guess_partial_die_structure_name)
4415         (partial_die_info::fixup): Handle new return type of find_partial_die.
4416
4417 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4418
4419         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4420         "std::string", simplifying the algorithm.
4421
4422 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4423
4424         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4425         (stap_static_probe_ops::get_probes): Likewise.
4426
4427 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4428
4429         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4430         '-')" and "else if".
4431         (stap_parse_single_operand): Join checks for
4432         "gdbarch_stap_parse_special_token_p" and
4433         "gdbarch_stap_parse_special_token" in the same "if" statement.
4434         Invert check when verifying for operation on register
4435         displacement.
4436
4437 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4438
4439         * stap-probe.c (stap_get_opcode): Update comment.
4440         (stap_get_expected_argument_type): Likewise.
4441         (handle_stap_probe): Likewise.
4442
4443 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4444
4445         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4446         return type to 'bool'.  Adjust comment.  Use 'bool' when
4447         appropriate.
4448         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4449         * stap-probe.c (stap_parse_argument_1): Likewise.
4450         (stap_is_operator): Likewise.
4451         (stap_is_generic_prefix): Likewise.
4452         (stap_is_register_prefix): Likewise.
4453         (stap_is_register_indirection_prefix): Likewise.
4454         (stap_is_integer_prefix): Likewise.
4455         (stap_generic_check_suffix): Likewise.
4456         (stap_check_integer_suffix): Likewise.
4457         (stap_check_register_suffix): Likewise.
4458         (stap_check_register_indirection_suffix): Likewise.
4459         (stap_parse_register_operand): Likewise.
4460         (stap_parse_single_operand): Likewise.
4461         (stap_parse_argument_1): Likewise.
4462         (stap_probe::get_argument_count): Likewise.
4463         (stap_is_operator): Likewise.
4464
4465 2019-05-16  Tom Tromey  <tromey@adacore.com>
4466
4467         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4468         keyword to foreach.
4469
4470 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4471
4472         * linux-thread-db.c (try_thread_db_load_1): Change return type
4473         to bool.
4474         (try_thread_db_load): Likewise.
4475         (try_thread_db_load_from_pdir_1): Likewise.
4476         (try_thread_db_load_from_pdir): Likewise.
4477         (try_thread_db_load_from_sdir): Likewise.
4478         (try_thread_db_load_from_dir): Likewise.
4479         (thread_db_load_search): Likewise.
4480         (has_libpthread): Likewise.
4481         (thread_db_load): Likewise.
4482
4483 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4484
4485         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4486         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4487         NULL, and complain/return if that's the case.
4488
4489 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4490
4491         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4492         (advance, posn, abstract_read_memory): New functions.
4493         [struct mem_read_abstraction]: New struct.
4494         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4495
4496 2019-05-14  Tom Tromey  <tromey@adacore.com>
4497
4498         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4499         value is not lval_memory.
4500
4501 2019-05-14  Tom Tromey  <tromey@adacore.com>
4502
4503         * solib.c (info_sharedlibrary_command): Style the file name.
4504
4505 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4506
4507         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4508         (aarch64_vnv_type): Likewise.
4509         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4510         * common/tdesc.c: Likewise.
4511         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4512         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4513         * features/aarch64-fpu.xml: Add ieee half view.
4514         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4515         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4516         * gdbtypes.h (struct builtin_type): Likewise.
4517         (struct objfile_type): Likewise.
4518
4519 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4520
4521         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4522         typo.
4523         * location.h (string_to_event_location): Likewise.
4524
4525 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4526
4527         GDB 8.3 released.
4528
4529 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4530
4531         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4532         New variable declaration.
4533         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4534         New variable.
4535         (print_one_breakpoint): Use ui_out::test_flags and new global
4536         variable to compute use_fixed_output.
4537         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4538         Remove.
4539         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4540         (mi_multi_location_breakpoint_output_fixed): Remove.
4541         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4542         new variable.
4543         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4544         fix_multi_location_breakpoint_output flag if version >= 3.
4545         * ui-out.h (enum ui_out_flag)
4546         <fix_multi_location_breakpoint_output>: New enumerator.
4547
4548 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4549
4550         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4551
4552 2019-05-10  Tom Tromey  <tromey@adacore.com>
4553
4554         * ada-lang.c (catch_ada_completer): New function.
4555         (_initialize_ada_language): Use it.
4556
4557 2019-05-10  Tom Tromey  <tromey@adacore.com>
4558
4559         * thread.c (print_thread_info): Make "requested_threads" const.
4560         * gdbthread.h (print_thread_info): Make "requested_threads"
4561         const.
4562         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4563         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4564
4565 2019-05-08  Tom Tromey  <tom@tromey.com>
4566
4567         * gdbtypes.c (objfile_type_data): Change type.
4568         (objfile_type, _initialize_gdbtypes): Update.
4569
4570 2019-05-08  Tom Tromey  <tom@tromey.com>
4571
4572         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4573         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4574         (_initialize_dwarf2_frame): Update.
4575
4576 2019-05-08  Tom Tromey  <tom@tromey.com>
4577
4578         * objc-lang.c (objc_objfile_data): Change type.
4579         (find_methods): Update.
4580         (_initialize_objc_lang): Remove.
4581
4582 2019-05-08  Tom Tromey  <tom@tromey.com>
4583
4584         * stabsread.c (rs6000_builtin_type_data): Change type.
4585         (rs6000_builtin_type, _initialize_stabsread): Update.
4586
4587 2019-05-08  Tom Tromey  <tom@tromey.com>
4588
4589         * mips-tdep.c (mips_pdr_data): Remove.
4590         (_initialize_mips_tdep): Update.
4591
4592 2019-05-08  Tom Tromey  <tom@tromey.com>
4593
4594         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4595         (hppa_init_objfile_priv_data, read_unwind_info)
4596         (find_unwind_entry, _initialize_hppa_tdep): Update.
4597
4598 2019-05-08  Tom Tromey  <tom@tromey.com>
4599
4600         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4601         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4602         on obstack.
4603         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4604
4605 2019-05-08  Tom Tromey  <tom@tromey.com>
4606
4607         * mdebugread.c (basic_type_data): Change type.
4608         (basic_type, _initialize_mdebugread): Update.
4609
4610 2019-05-08  Tom Tromey  <tom@tromey.com>
4611
4612         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4613
4614 2019-05-08  Tom Tromey  <tom@tromey.com>
4615
4616         * nto-tdep.c (nto_inferior_data_reg): Change type.
4617         (nto_inferior_data): Update.
4618         (nto_inferior_data_cleanup, nto_new_inferior_data)
4619         (_initialize_nto_tdep): Remove.
4620         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4621
4622 2019-05-08  Tom Tromey  <tom@tromey.com>
4623
4624         * ada-lang.c (struct ada_inferior_data): Add initializers.
4625         (ada_inferior_data): Change type.
4626         (ada_inferior_data_cleanup): Remove.
4627         (get_ada_inferior_data, ada_inferior_exit)
4628         (struct ada_pspace_data): Add initializers, destructor.
4629         (ada_pspace_data_handle): Change type.
4630         (get_ada_pspace_data): Update.
4631         (ada_pspace_data_cleanup): Remove.
4632
4633 2019-05-08  Tom Tromey  <tom@tromey.com>
4634
4635         * coffread.c (struct coff_symfile_info): Add initializers.
4636         (coff_objfile_data_key): Move lower.  Change type.
4637         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4638         Update.
4639         (coff_free_info): Remove.
4640
4641 2019-05-08  Tom Tromey  <tom@tromey.com>
4642
4643         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4644         (fbsd_pspace_data_handle): Move lower.  Change type.
4645         (get_fbsd_pspace_data): Update.
4646         (fbsd_pspace_data_cleanup): Remove.
4647         (_initialize_fbsd_tdep): Update.
4648
4649 2019-05-08  Tom Tromey  <tom@tromey.com>
4650
4651         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4652         (get_ada_tasks_pspace_data): Update.
4653         (ada_tasks_pspace_data_cleanup): Remove.
4654         (_initialize_tasks): Update.
4655         (ada_tasks_inferior_data_handle): Change type.
4656         (get_ada_tasks_inferior_data): Update.
4657         (ada_tasks_inferior_data_cleanup): Remove.
4658         (struct ada_tasks_pspace_data): Add initializers.
4659
4660 2019-05-08  Tom Tromey  <tom@tromey.com>
4661
4662         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4663         * symfile-debug.c (debug_sym_get_probes): Change type.
4664         * stap-probe.c (handle_stap_probe):
4665         (stap_static_probe_ops::get_probes): Change type.
4666         * probe.h (class static_probe_ops) <get_probes>: Change type.
4667         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4668         (parse_probes_in_pspace): Update.
4669         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4670         Update.
4671         (any_static_probe_ops::get_probes): Change type.
4672         * elfread.c (elfread_data): New typedef.
4673         (probe_key): Change type.
4674         (elf_get_probes): Likewise.  Update.
4675         (probe_key_free): Remove.
4676         (_initialize_elfread): Update.
4677         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4678         Change type.
4679         (dtrace_process_dof_probe, dtrace_process_dof)
4680         (dtrace_static_probe_ops::get_probe): Change type.
4681
4682 2019-05-08  Tom Tromey  <tom@tromey.com>
4683
4684         * xcoffread.c (struct xcoff_symfile_info): Rename from
4685         coff_symfile_info.  Add initializers.
4686         (xcoff_objfile_data_key): Move lower.  Change type.
4687         (XCOFF_DATA): Rewrite.
4688         (xcoff_free_info): Remove.
4689         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4690         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4691         (xcoff_initial_scan): Update.
4692
4693 2019-05-08  Tom Tromey  <tom@tromey.com>
4694
4695         * solib-svr4.c (struct svr4_info): Add initializers and
4696         destructor.
4697         <probes_table>: Now an htab_up.
4698         (solib_svr4_pspace_data): Change type.
4699         (free_probes_table): Simplify.
4700         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4701         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4702         (probes_table_remove_objfile_probes, register_solib_event_probe)
4703         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4704         (_initialize_svr4_solib): Update.
4705
4706 2019-05-08  Tom Tromey  <tom@tromey.com>
4707
4708         * remote.c (remote_pspace_data): Change type.
4709         (remote_pspace_data_cleanup): Remove.
4710         (get_remote_exec_file, set_pspace_remote_exec_file)
4711         (_initialize_remote): Update.
4712
4713 2019-05-08  Tom Tromey  <tom@tromey.com>
4714
4715         * breakpoint.c (breakpoint_objfile_key): Change type.
4716         (get_breakpoint_objfile_data): Update.
4717         (free_breakpoint_objfile_data): Remove.
4718         (_initialize_breakpoint): Update.
4719
4720 2019-05-08  Tom Tromey  <tom@tromey.com>
4721
4722         * linux-tdep.c (struct linux_info): Add initializers.
4723         (linux_inferior_data): Move.  Change type.
4724         (invalidate_linux_cache_inf): Update.
4725         (linux_inferior_data_cleanup): Remove.
4726         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4727
4728 2019-05-08  Tom Tromey  <tom@tromey.com>
4729
4730         * auxv.c (auxv_inferior_data): Move.  Change type.
4731         (auxv_inferior_data_cleanup): Remove.
4732         (invalidate_auxv_cache_inf): Rewrite.
4733         (get_auxv_inferior_data, _initialize_auxv): Update.
4734
4735 2019-05-08  Tom Tromey  <tom@tromey.com>
4736
4737         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4738         (symfile_debug_objfile_data_key): Change type.
4739         (symfile_debug_installed, debug_qf_has_symbols)
4740         (debug_qf_find_last_source_symtab)
4741         (debug_qf_forget_cached_source_info)
4742         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4743         (debug_qf_print_stats, debug_qf_dump)
4744         (debug_qf_expand_symtabs_for_function)
4745         (debug_qf_expand_all_symtabs)
4746         (debug_qf_expand_symtabs_with_fullname)
4747         (debug_qf_map_matching_symbols)
4748         (debug_qf_expand_symtabs_matching)
4749         (debug_qf_find_pc_sect_compunit_symtab)
4750         (debug_qf_map_symbol_filenames)
4751         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4752         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4753         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4754         (debug_sym_read_linetable, debug_sym_relocate): Update.
4755         (symfile_debug_free_objfile): Remove.
4756         (install_symfile_debug_logging, _initialize_symfile_debug):
4757         Update.
4758
4759 2019-05-08  Tom Tromey  <tom@tromey.com>
4760
4761         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4762         allocate_on_obstack.
4763         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4764         (get_dwarf2_per_objfile): Update.
4765         (set_dwarf2_per_objfile): Remove.
4766         (dwarf2_has_info, dwarf2_get_section_info): Update.
4767         (dwarf2_free_objfile): Remove.
4768         (_initialize_dwarf2_read): Update.
4769
4770 2019-05-08  Tom Tromey  <tom@tromey.com>
4771
4772         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4773         initializers.
4774         <unsupported_script_warning_printed,
4775         script_not_found_warning_printed>: Now bool.
4776         (auto_load_pspace_data): Change type.
4777         (~auto_load_pspace_info): Rename from
4778         auto_load_pspace_data_cleanup.
4779         (get_auto_load_pspace_data, init_loaded_scripts_info)
4780         (clear_section_scripts, maybe_print_unsupported_script_warning)
4781         (maybe_print_script_not_found_warning, _initialize_auto_load):
4782         Update.
4783
4784 2019-05-08  Tom Tromey  <tom@tromey.com>
4785
4786         * objfiles.c (objfile_pspace_info): Add destructor and
4787         initializers.
4788         (objfiles_pspace_data): Change type.
4789         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4790         (get_objfile_pspace_data): Update.
4791         (objfiles_bfd_data): Change type.
4792         (get_objfile_bfd_data): Update.
4793         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4794
4795 2019-05-08  Tom Tromey  <tom@tromey.com>
4796
4797         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4798         Change type.
4799         (get_catch_syscall_inferior_data): Update.
4800         (catch_syscall_inferior_data_cleanup): Remove.
4801         (_initialize_break_catch_syscall): Update.
4802
4803 2019-05-08  Tom Tromey  <tom@tromey.com>
4804
4805         * inflow.c (struct terminal_info): Add destructor and
4806         initializers.
4807         (inflow_inferior_data): Change type.
4808         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4809         (get_inflow_inferior_data, inflow_inferior_exit)
4810         (swap_terminal_info, _initialize_inflow): Update.
4811
4812 2019-05-08  Tom Tromey  <tom@tromey.com>
4813
4814         * target-dcache.c (target_dcache_cleanup): Remove.
4815         (target_dcache_aspace_key): Change type.
4816         (target_dcache_init_p, target_dcache_invalidate)
4817         (target_dcache_get, target_dcache_get_or_init)
4818         (_initialize_target_dcache): Update.
4819         * dcache.h (struct dcache_deleter): New.
4820
4821 2019-05-08  Tom Tromey  <tom@tromey.com>
4822
4823         * symtab.c (struct symbol_cache): Add destructor and
4824         initializers.
4825         (symbol_cache_key): Move.  Change type.
4826         (make_symbol_cache, free_symbol_cache): Remove.
4827         (get_symbol_cache): Update.
4828         (symbol_cache_cleanup): Remove.
4829         (ALL_PSPACES, symbol_cache_flush)
4830         (maintenance_print_symbol_cache)
4831         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4832         Update.
4833
4834 2019-05-08  Tom Tromey  <tom@tromey.com>
4835
4836         * symtab.c (struct main_info): Add destructor and initializers.
4837         (main_progspace_key): Move.  Change type.
4838         (get_main_info): Update.
4839         (main_info_cleanup): Remove.
4840         (_initialize_symtab): Update.
4841
4842 2019-05-08  Tom Tromey  <tom@tromey.com>
4843
4844         * registry.h (DECLARE_REGISTRY): Define the _key class.
4845
4846 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4847
4848         * NEWS: Merge two 'New commands' sections.
4849
4850 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4851
4852         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4853         parameter and use Ada language definition instead.
4854         (ada_val_print_ptr): Remove unused language parameter.
4855         (ada_val_print_num): Remove language parameter and use Ada language
4856         definition instead.
4857         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4858         parameter.
4859         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4860         parameter and use Ada language definition instead.
4861         (ada_val_print_1): Update all ada_val_print_xxx calls.
4862         Remove language parameter.
4863         (ada_val_print): Update ada_val_print_1 call.
4864
4865 2019-05-08  Tom Tromey  <tromey@adacore.com>
4866
4867         * remote.c (remote_hw_watchpoint_limit)
4868         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4869         Now static.
4870
4871 2019-05-08  Tom Tromey  <tromey@adacore.com>
4872
4873         * maint.c (_initialize_maint_cmds): Move initialization code to
4874         remote.c.
4875         (watchdog, show_watchdog): Move to remote.c.
4876         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4877         "watchdog" static.
4878         (_initialize_remote): Move initialization code from maint.c.
4879         * defs.h (watchdog): Don't declare.
4880
4881 2019-05-08  Tom Tromey  <tromey@adacore.com>
4882
4883         * tui/tui-interp.c: Include main.h.
4884         * interps.c: Include main.h.
4885         * main.h (interpreter_p): Declare.
4886         * defs.h (interpreter_p): Don't declare.
4887
4888 2019-05-08  Tom Tromey  <tromey@adacore.com>
4889
4890         * dwarf2loc.c: Include dwarf2read.h.
4891         * defs.h (read_unsigned_leb128): Don't declare.
4892         * dwarf2read.h (read_unsigned_leb128): Declare.
4893
4894 2019-05-08  Tom Tromey  <tromey@adacore.com>
4895
4896         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4897         method.
4898
4899 2019-05-08  Tom Tromey  <tromey@adacore.com>
4900
4901         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4902         when no wrap column is set.
4903
4904 2019-05-08  Tom Tromey  <tromey@adacore.com>
4905
4906         * c-lang.c (c_get_string): Handle non-C-style arrays.
4907
4908 2019-05-08  Tom Tromey  <tromey@adacore.com>
4909
4910         * typeprint.c (print_offset_data::update): Print the bit offset,
4911         not the number of bits remaining.
4912
4913 2019-05-08  Tom Tromey  <tromey@adacore.com>
4914
4915         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4916         padding at end of comment.
4917
4918 2019-05-08  Tom Tromey  <tromey@adacore.com>
4919
4920         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4921         Compare main types.
4922
4923 2019-05-06  Tom Tromey  <tom@tromey.com>
4924
4925         * common/scoped_mmap.c: Include common-defs.h.
4926         * common/scoped_mmap.h: Don't include config.h.
4927
4928 2019-05-04  Tom Tromey  <tom@tromey.com>
4929
4930         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4931         (struct aarch64_call_info): Add initializers.
4932         <si>: Now a std::vector.
4933         (pass_on_stack, aarch64_push_dummy_call): Update.
4934
4935 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4936             Tom Tromey  <tom@tromey.com>
4937
4938         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4939         (ppc_threads): Now a std::vector.  Now static.
4940         (hwdebug_find_thread_points_by_tid)
4941         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4942         Update.
4943
4944 2019-05-04  Tom Tromey  <tom@tromey.com>
4945
4946         * arc-tdep.c (arc_tdesc_init): Return bool.
4947
4948 2019-05-04  Tom Tromey  <tom@tromey.com>
4949
4950         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4951         Use gdb_assert_not_reached.
4952
4953 2019-05-04  Tom Tromey  <tom@tromey.com>
4954
4955         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4956         "false".
4957
4958 2019-05-04  Tom Tromey  <tom@tromey.com>
4959
4960         * arc-tdep.c (arc_tdesc_init): Use bool.
4961
4962 2019-05-04  Tom Tromey  <tom@tromey.com>
4963
4964         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4965
4966 2019-05-04  Tom Tromey  <tom@tromey.com>
4967
4968         * cli/cli-cmds.c (valid_command_p): Return bool.
4969
4970 2019-05-04  Tom Tromey  <tom@tromey.com>
4971
4972         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4973         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4974
4975 2019-05-04  Raul Tambre  <raul@tambre.ee>
4976
4977         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4978         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4979         operator for comparison.
4980
4981 2019-05-04  Tom Tromey  <tom@tromey.com>
4982
4983         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4984         (lookup_partial_symbol, print_partial_symbols)
4985         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4986         (psymbol_compare): Update.
4987         (add_psymbol_to_bcache): Clear the entire psymbol.
4988         (maintenance_check_psymtabs): Update.
4989         * psympriv.h (struct partial_symbol): Don't derive from
4990         general_symbol_info.
4991         <obj_section, unrelocated_address, address,
4992         set_unrelocated_address>: Update.
4993         <ginfo>: New member.
4994         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4995         (debug_names::write_psymbols): Update.
4996
4997 2019-05-04  Tom de Vries  <tdevries@suse.de>
4998
4999         * contrib/cc-with-tweaks.sh: Support -n arg.
5000
5001 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5002
5003         * corelow.c (core_target::detach): Ensure frame cache and
5004         register caches are cleared.
5005         inferior.c (exit_inferior_1): Likewise.
5006
5007 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5008             Tom Tromey  <tom@tromey.com>
5009
5010         * dictionary.c (collate_pending_symbols_by_language): Remove
5011         "struct" from foreach.
5012         * symtab.c (lookup_global_symbol_from_objfile)
5013         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5014         foreach.
5015         * ser-tcp.c (net_open): Remove "struct" from foreach.
5016         * objfiles.c (objfile_relocate, objfile_rebase)
5017         (objfile_has_symbols): Remove "struct" from foreach.
5018         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5019         from foreach.
5020         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5021         foreach.
5022         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5023         "struct" from foreach.
5024         * ada-lang.c (create_excep_cond_exprs)
5025         (ada_exception_catchpoint_cond_string): Remove "struct" from
5026         foreach.
5027
5028 2019-05-03  Tom Tromey  <tromey@adacore.com>
5029
5030         * ada-exp.y (convert_char_literal): Check suffix of each
5031         enumerator.
5032
5033 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5034
5035         PR ada/21406:
5036         * ada-exp.y (yywrap): Don't define.
5037         * ada-lex.l (%option): Add noyywrap
5038         (yywrap): Remove.
5039
5040 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5041
5042         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5043         _WIN32_WINNT to the XP level, unless already defined to a higher
5044         level.
5045
5046         * unittests/parse-connection-spec-selftests.c:
5047         * ser-tcp.c:
5048         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5049         override.
5050
5051         * symfile.c (find_separate_debug_file): Remove colon from the
5052         drive spec of DOS/Windows file names of the target, so that the
5053         file name produced from DEBUGDIR and the target's directory will
5054         be valid on DOS/Windows systems.
5055
5056 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5057
5058         * rust-lang.c (val_print_struct): Handle printing structures
5059         containing strings.
5060
5061 2019-05-02  Tom Tromey  <tromey@adacore.com>
5062
5063         * valarith.c (_initialize_valarith): Remove.
5064
5065 2019-05-01  Tom Tromey  <tromey@adacore.com>
5066
5067         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5068         bitfields.
5069
5070 2019-05-01  Tom Tromey  <tromey@adacore.com>
5071
5072         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5073         for big-endian copies.
5074
5075 2019-04-30  Ali Tamur  <tamur@google.com>
5076         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5077         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5078         (read_3_bytes): New function.
5079
5080 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5081
5082         * windows-nat.c (main_thread_id): Delete.
5083         (handle_output_debug_string): Replace main_thread_id by
5084         current_event.dwThreadId.
5085         (fake_create_process): Likewise.
5086         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5087         Do not set main_thread_id.
5088         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5089         current_event.dwThreadId.
5090         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5091
5092 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5093
5094         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5095         Use current_event.dwThreadId instead of main_thread_id.
5096
5097 2019-04-30  Tom Tromey  <tromey@adacore.com>
5098
5099         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5100         (create_excep_cond_exprs): Iterate over program spaces.
5101         (ada_exception_catchpoint_cond_string): Examine all minimal
5102         symbols for exception types.
5103
5104 2019-04-30  Tom Tromey  <tromey@adacore.com>
5105
5106         PR c++/24470:
5107         * dwarf2read.c (process_structure_scope): Handle case where type
5108         has template parameters but no symbol was created.
5109
5110 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5111             Chris January  <chris.january@arm.com>
5112
5113         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5114         qualifier.
5115         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5116
5117 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5118
5119         * f-typeprint.c (f_print_type): Update rules for printing
5120         whitespace.
5121         (f_type_print_varspec_suffix): Likewise.
5122
5123 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5124             Chris January  <chris.january@arm.com>
5125
5126         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5127         function arguments.
5128
5129 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5130
5131         * f-lang.c (build_fortran_types): Change name of void type to
5132         lower case.
5133         * f-typeprint.c (f_type_print_base): Print the name of the void
5134         type, rather than a fixed string.
5135         * f-valprint.c (f_decorations): Use lower case void string.
5136
5137 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5138             Chris January  <chris.january@arm.com>
5139
5140         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5141         types for Fortran.
5142
5143 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5144             Chris January  <chris.january@arm.com>
5145             David Lecomber  <david.lecomber@arm.com>
5146
5147         * f-exp.y (BINOP_INTRINSIC): New token.
5148         (exp): New parser rule handling BINOP_INTRINSIC.
5149         (f77_keywords): Add new builtin procedures.
5150         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5151         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5152         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5153         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5154         (print_unop_subexp_f): New function.
5155         (print_binop_subexp_f): New function.
5156         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5157         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5158         (dump_subexp_body_f): Likewise.
5159         (operator_check_f): Likewise.
5160         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5161         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5162
5163 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5164
5165         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5166         UNOP_KIND.
5167         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5168         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5169         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5170         (operator_length_f): New fuction.
5171         (print_subexp_f): New function.
5172         (op_name_f): New function.
5173         (dump_subexp_body_f): New function.
5174         (operator_check_f): New function.
5175         (exp_descriptor_f): Replace standard expression handling functions
5176         with new functions.
5177         * gdb/fortran-operator.def: New file.
5178         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5179         * gdb/std-operator.def: Remove UNOP_KIND.
5180
5181 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5182
5183         * std-operator.def: Remove unbalanced, stray double quote
5184         character.
5185
5186 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5187             Chris January  <chris.january@arm.com>
5188             Daniel Everett  <daniel.everett@arm.com>
5189             Nick Forrington  <nick.forrington@arm.com>
5190             Richard Bunt  <richard.bunt@arm.com>
5191
5192         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5193         of depth when printing anonymous structs or unions.
5194         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5195         Don't print either the top-level value, or the children if the
5196         max-depth is exceeded.
5197         (ppscm_print_children): When printing the key of a map, allow one
5198         extra level of depth.
5199         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5200         print either the top-level value, or the children if the max-depth
5201         is exceeded.
5202         (print_children): When printing the key of a map, allow one extra
5203         level of depth.
5204         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5205         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5206         (user_print_options): Initialise max_depth field.
5207         (val_print_scalar_or_string_type_p): New function.
5208         (val_print): Check to see if the max depth has been reached.
5209         (val_print_check_max_depth): Define new function.
5210         (show_print_max_depth): New function.
5211         (_initialize_valprint): Add 'print max-depth' option.
5212         * valprint.h (struct value_print_options) <max_depth>: New field.
5213         (val_print_check_max_depth): Declare new function.
5214         * NEWS: Document new feature.
5215
5216 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5217
5218         * ada-lang.c (ada_language_defn): Initialise new field.
5219         * c-lang.c (c_is_string_type_p): New function.
5220         (c_language_defn): Initialise new field.
5221         (cplus_language_defn): Initialise new field.
5222         (asm_language_defn): Initialise new field.
5223         (minimal_language_defn): Initialise new field.
5224         * c-lang.h (c_is_string_type_p): Declare new function.
5225         * d-lang.c (d_language_defn): Initialise new field.
5226         * f-lang.c (f_is_string_type_p): New function.
5227         (f_language_defn): Initialise new field.
5228         * go-lang.c (go_is_string_type_p): New function.
5229         (go_language_defn): Initialise new field.
5230         * language.c (default_is_string_type_p): New function.
5231         (unknown_language_defn): Initialise new field.
5232         (auto_language_defn): Initialise new field.
5233         * language.h (struct language_defn) <la_is_string_type_p>: New
5234         member variable.
5235         (default_is_string_type_p): Declare new function.
5236         * m2-lang.c (m2_language_defn): Initialise new field.
5237         * objc-lang.c (objc_language_defn): Initialise new field.
5238         * opencl-lang.c (opencl_language_defn): Initialise new field.
5239         * p-lang.c (pascal_is_string_type_p): New function.
5240         (pascal_language_defn): Initialise new field.
5241         * rust-lang.c (rust_is_string_type_p): New function.
5242         (rust_language_defn): Initialise new field.
5243
5244 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5245
5246         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5247         New field.
5248         * ada-lang.c (ada_language_defn): Initialise new field.
5249         * c-lang.c (c_language_defn): Likewise.
5250         (cplus_language_defn): Likewise.
5251         (asm_language_defn): Likewise.
5252         (minimal_language_defn): Likewise.
5253         * d-lang.c (d_language_defn): Likewise.
5254         * f-lang.c (f_language_defn): Likewise.
5255         * go-lang.c (go_language_defn): Likewise.
5256         * language.c (unknown_language_defn): Likewise.
5257         (auto_language_defn): Likewise.
5258         * m2-lang.c (m2_language_defn): Likewise.
5259         * objc-lang.c (objc_language_defn): Likewise.
5260         * opencl-lang.c (opencl_language_defn): Likewise.
5261         * p-lang.c (pascal_language_defn): Likewise.
5262         * rust-lang.c (rust_language_defn): Likewise.
5263
5264 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5265
5266         * ada-lang.c (ada_is_character_type): Change return type to bool.
5267         (ada_is_string_type): Likewise.
5268         * ada-lang.h (ada_is_character_type): Update declaration
5269         (ada_is_string_type): Likewise.
5270
5271 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5272
5273         Support style in 'frame|thread apply'
5274
5275         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5276         * record.c (record_start, record_stop): Update callers of
5277         execute_command_to_string with false.
5278         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5279         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5280         methods.
5281         (class string_file): New constructor with term_out parameter.
5282         Override methods term_out and can_emit_style_escape.  New member
5283         term_out.
5284         (class stdio_file): Override can_emit_style_escape.
5285         (class tee_file): Override term_out and can_emit_style_escape.
5286         * utils.h (can_emit_style_escape): Remove.
5287         * utils.c (can_emit_style_escape): Likewise.
5288         Update all callers of can_emit_style_escape (SOMESTREAM) to
5289         SOMESTREAM->can_emit_style_escape.
5290         * source-cache.c (source_cache::get_source_lines): Likewise.
5291         * stack.c (frame_apply_command_count): Call execute_command_to_string
5292         passing the term_out characteristic of the current gdb_stdout.
5293         * thread.c (thr_try_catch_cmd): Likewise.
5294         * top.c (execute_command_to_string): pass term_out parameter
5295         to construct the string_file for the command output.
5296         * ui-file.c (term_cli_styling): New function (most code moved
5297         from utils.c can_emit_style_escape).
5298         (string_file::string_file, string_file::can_emit_style_escape,
5299         stdio_file::can_emit_style_escape, tee_file::term_out,
5300         tee_file::can_emit_style_escape): New functions.
5301
5302 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5303
5304         * NEWS: Mention the new set|show may-call-functions.
5305         * infcall.c (may_call_functions_p): New variable.
5306         (show_may_call_functions_p): New function.
5307         (call_function_by_hand_dummy): Throws an error if not
5308         may-call-functions.
5309         (_initialize_infcall): Call add_setshow_boolean_cmd for
5310         may-call-functions.
5311
5312 2019-04-25  Keith Seitz  <keiths@redhat.com>
5313
5314         PR c++/24367
5315         * cp-support.c (inspect_type): Don't attempt substitutions
5316         of symbol with the same name.
5317
5318 2019-04-25  Tom Tromey  <tromey@adacore.com>
5319
5320         PR gdb/24475:
5321         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5322         static.
5323
5324 2019-04-25  Tom Tromey  <tromey@adacore.com>
5325
5326         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5327         rvalue reference.
5328         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5329         (gdb_xml_parser::parse): Use std::move.
5330         * python/python-internal.h (gdbpy_convert_exception): Take a const
5331         reference.
5332         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5333         std::move.
5334         * python/py-utils.c (gdbpy_convert_exception): Take a const
5335         reference.
5336         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5337         Use std::move.
5338         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5339         Use std::move.
5340         * mi/mi-main.c (mi_print_exception): Take a const reference.
5341         * main.c (handle_command_errors): Take a const reference.
5342         * linespec.c (parse_linespec): Use std::move.
5343         * infcall.c (run_inferior_call): Use std::move.
5344         (call_function_by_hand_dummy): Use std::move.
5345         * exec.c (try_open_exec_file): Use std::move.
5346         * exceptions.h (exception_print, exception_fprintf)
5347         (exception_print_same): Update.
5348         * exceptions.c (print_exception, exception_print)
5349         (exception_fprintf, exception_print_same): Change parameters to
5350         const reference.
5351         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5352         * common/new-op.c: Use std::move.
5353         * common/common-exceptions.h (struct gdb_exception): Add move
5354         constructor.
5355         (struct gdb_exception_error, struct gdb_exception_quit, struct
5356         gdb_quit_bad_alloc): Change constructor to move constructor.
5357         (throw_exception): Change parameter to rvalue reference.
5358         * common/common-exceptions.c (throw_exception): Take rvalue
5359         reference.
5360         * cli/cli-interp.c (safe_execute_command): Use std::move.
5361         * breakpoint.c (insert_bp_location, location_to_sals): Use
5362         std::move.
5363
5364 2019-04-25  Tom Tromey  <tromey@adacore.com>
5365
5366         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5367         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5368         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5369         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5370         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5371         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5372         guile/scm-value.c: Use unpack.
5373         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5374         gdbscm_gdb_exception.
5375         (gdbscm_throw_gdb_exception): Likewise.
5376         (struct gdbscm_gdb_exception): New.
5377         (unpack): New function.
5378         (gdbscm_wrap): Use unpack.
5379
5380 2019-04-25  Tom Tromey  <tromey@adacore.com>
5381
5382         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5383         (gdb_rl_callback_handler): Use std::move.
5384         * common/common-exceptions.h (struct gdb_exception): Add move
5385         assignment operator.
5386         (throw_exception_sjlj): Change "exception" to const reference.
5387         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5388         (throw_exception_sjlj): Change "exception" to const reference.
5389
5390 2019-04-25  Tom Tromey  <tromey@adacore.com>
5391
5392         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5393         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5394         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5395         Update.
5396         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5397         Update.
5398         * mi/mi-interp.c (mi_interp::exec): Update.
5399         * linespec.c (parse_linespec): Update.
5400         * infcall.c (run_inferior_call): Update.
5401         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5402         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5403         (gdbscm_lookup_global_symbol): Update.
5404         * guile/scm-param.c (gdbscm_parameter_value): Update.
5405         * guile/scm-frame.c (gdbscm_frame_read_register)
5406         (gdbscm_frame_read_var): Update.
5407         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5408         * exec.c (try_open_exec_file): Update.
5409         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5410         (gdb_rl_callback_handler): Update.
5411         * common/common-exceptions.h (exception_none): Don't declare.
5412         * common/common-exceptions.c (exception_none): Don't define.
5413         (struct catcher) <exception>: Update.
5414         * cli/cli-interp.c (safe_execute_command): Update.
5415         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5416
5417 2019-04-25  Ali Tamur  <tamur@google.com>
5418
5419         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5420         (read_attribute_value): Likewise.
5421         (dwarf2_read_addr_index): Update comment.
5422         (read_str_index): Add DW_FORM_strx.
5423         (dwarf2_string_attr): Likewise.
5424         (dwarf2_const_value_attr): Likewise.
5425         (dump_die_shallow): Likewise.
5426         (dwarf2_fetch_constant_bytes): Likewise.
5427         (skip_form_bytes): Likewise.
5428         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5429
5430 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5431
5432         PR corefiles/11608
5433         PR corefiles/18187
5434         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5435         OFFSET.  Verify if current mapping contains an ELF header.
5436         (linux_find_memory_regions_full): Adjust call to
5437         dump_mapping_p.
5438
5439 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5440             Kang Li <kanglictf@gmail.com>
5441
5442         PR gdb/21600
5443
5444         * dwarf2-frame.c (read_initial_length): Be consistent about using
5445         unsigned representation of length.
5446         (decode_frame_entry_1): Likewise.  Check for wraparound of
5447         end pointer as well as buffer overflow.
5448
5449 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5450
5451         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5452         "vq".
5453
5454 2019-04-24  Tom Tromey  <tromey@adacore.com>
5455
5456         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5457
5458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5459
5460         * s12z-tdep.c (s12z_unwind_pc): Delete.
5461         (s12z_unwind_sp): Delete.
5462         (s12z_gdbarch_init): Don't register deleted functions with
5463         gdbarch.
5464
5465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5466
5467         * rl78-tdep.c (rl78_unwind_sp): Delete.
5468         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5469
5470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5471
5472         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5473         (xstormy16_unwind_pc): Delete.
5474         (xstormy16_dummy_id): Delete.
5475         (xstormy16_gdbarch_init): Don't register deleted functions with
5476         gdbarch.
5477
5478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5479
5480         * vax-tdep.c (vax_unwind_pc): Delete.
5481         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5482
5483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5484
5485         * v850-tdep.c (v850_unwind_sp): Delete.
5486         (v850_unwind_pc): Delete.
5487         (v850_dummy_id): Delete.
5488         (v850_gdbarch_init): Don't register deleted functions with
5489         gdbarch.
5490
5491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5492
5493         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5494         (tilegx_unwind_pc): Delete.
5495         (tilegx_unwind_dummy_id): Delete.
5496         (tilegx_gdbarch_init): Don't register deleted functions with
5497         gdbarch.
5498
5499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5500
5501         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5502         (tic6x_dummy_id): Delete.
5503         (tic6x_gdbarch_init): Don't register deleted functions with
5504         gdbarch.
5505
5506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5507
5508         * sparc-tdep.c (sparc_unwind_pc): Delete.
5509         (sparc32_gdbarch_init): Don't register deleted function with
5510         gdbarch.
5511
5512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5513
5514         * sh-tdep.c (sh_unwind_sp): Delete.
5515         (sh_unwind_pc): Delete.
5516         (sh_dummy_id): Delete.
5517         (sh_gdbarch_init): Don't register deleted functions with
5518         gdbarch.
5519
5520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5521
5522         * score-tdep.c (score_unwind_sp): Delete.
5523         (score_unwind_pc): Delete.
5524         (score_dummy_id): Delete.
5525         (score_gdbarch_init): Don't register deleted functions with
5526         gdbarch.
5527
5528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5529
5530         * rx-tdep.c (rx_unwind_pc): Delete.
5531         (rx_unwind_sp): Delete.
5532         (rx_dummy_id): Delete.
5533         (rx_gdbarch_init): Don't register deleted functions with
5534         gdbarch.  Update comment.
5535
5536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5537
5538         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5539         (rs6000_dummy_id): Delete.
5540         (rs6000_gdbarch_init): Don't register deleted functions with
5541         gdbarch.
5542
5543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5544
5545         * or1k-tdep.c (or1k_dummy_id): Delete.
5546         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5547
5548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5549
5550         * nios2-tdep.c (nios2_dummy_id): Delete.
5551         (nios2_unwind_sp): Delete.
5552         (nios2_gdbarch_init): Don't register deleted functions with
5553         gdbarch.
5554
5555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5556
5557         * nds32-tdep.c (nds32_dummy_id): Delete.
5558         (nds32_unwind_pc): Delete.
5559         (nds32_unwind_sp): Delete.
5560         (nds32_gdbarch_init): Don't register deleted functions with
5561         gdbarch.
5562
5563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5564
5565         * msp430-tdep.c (msp430_unwind_pc): Delete.
5566         (msp430_unwind_sp): Delete.
5567         (msp430_dummy_id): Delete.
5568         (msp430_gdbarch_init): Don't register deleted functions with
5569         gdbarch.
5570
5571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5572
5573         * moxie-tdep.c (moxie_unwind_sp): Delete.
5574         (moxie_unwind_pc): Delete.
5575         (moxie_dummy_id): Delete.
5576         (moxie_gdbarch_init): Don't register deleted functions with
5577         gdbarch.
5578
5579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5580
5581         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5582         (mn10300_unwind_pc): Delete.
5583         (mn10300_unwind_sp): Delete.
5584         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5585         mn10300_unwind_sp.
5586         (mn10300_frame_unwind_init): Don't register deleted functions with
5587         gdbarch.
5588
5589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5590
5591         * mep-tdep.c (mep_unwind_pc): Delete.
5592         (mep_unwind_sp): Delete.
5593         (mep_dummy_id): Delete.
5594         (mep_gdbarch_init): Don't register deleted functions with
5595         gdbarch.
5596
5597 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5598
5599         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5600         (m68hc11_unwind_sp): Delete.
5601         (m68hc11_gdbarch_init): Don't register deleted functions with
5602         gdbarch.
5603
5604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5605
5606         * m32r-tdep.c (m32r_unwind_sp): Delete.
5607         (m32r_unwind_pc): Delete.
5608         (m32r_dummy_id): Delete.
5609         (m32r_gdbarch_init): Don't register deleted functions with
5610         gdbarch.
5611
5612 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5613
5614         * m32c-tdep.c (m32c_unwind_pc): Delete.
5615         (m32c_unwind_sp): Delete.
5616         (m32c_dummy_id): Delete.
5617         (m32c_gdbarch_init): Don't register deleted functions with
5618         gdbarch.
5619
5620 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5621
5622         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5623         (lm32_unwind_pc): Delete.
5624         (lm32_dummy_id): Delete.
5625         (lm32_gdbarch_init): Don't register deleted functions with
5626         gdbarch.
5627
5628 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5629
5630         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5631         (iq2000_unwind_pc): Delete.
5632         (iq2000_dummy_id): Delete.
5633         (iq2000_gdbarch_init): Don't register deleted functions with
5634         gdbarch.
5635
5636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5637
5638         * nds32-tdep.c (nds32_type_align): Delete.
5639         (nds32_push_dummy_call): Use type_align instead.
5640
5641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5642
5643         * arm-tdep.c (arm_type_align): Only handle vector override case.
5644         (arm_push_dummy_call): Use type_align.
5645         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5646
5647 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5648
5649         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5650         case.
5651         (pass_on_stack): Use type_align.
5652         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5653         function.
5654
5655 2019-04-23  Tom Tromey  <tromey@adacore.com>
5656
5657         * dwarf2read.c (line_header::file_name_at): Remove unused
5658         overload.
5659
5660 2019-04-23  Tom de Vries  <tdevries@suse.de>
5661
5662         PR gdb/24438
5663         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5664         invocation.
5665
5666
5667 2019-03-27  Ali Tamur  <tamur@google.com>
5668
5669         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5670         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5671         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5672         (dwarf_expr_context::get_addr_index): Likewise
5673         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5674         (symbol_needs_eval_context::get_addr_index): Likewise
5675         (disassemble_dwarf_expression): Add DW_OP_addrx
5676         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5677         (read_cutu_die_from_dwo): Update comment
5678         (skip_one_die): Add DW_FORM_addrx
5679         (read_attribute_value): Likewise
5680         (var_decode_location): Add DW_OP_addrx
5681         (dwarf2_const_value_attr): Add DW_FORM_addrx
5682         (dump_die_shallow): Likewise
5683         (dwarf2_fetch_constant_bytes): Likewise
5684         (decode_locdesc): Add DW_OP_addrx
5685         (skip_form_bytes): Add DW_FORM_addrx
5686
5687 2019-04-22  Ali Tamur  <tamur@google.com>
5688
5689         * MAINTAINERS (Write After Approval): Add self.
5690
5691 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5692
5693         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5694         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5695         (open_symbol_file_object): Likewise.
5696         (svr4_default_sos): Add info parameter.
5697         (svr4_read_so_list): Likewise.
5698         (svr4_current_sos_direct): Adjust functions calls to pass down
5699         info.
5700         (svr4_current_sos_1): Add info parameter.
5701         (svr4_current_sos): Call get_svr4_info, pass info down to
5702         svr4_current_sos_1.
5703         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5704         get_svr4_info.
5705         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5706         get_svr4_info.
5707         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5708         to get_svr4_info.
5709         (probes_table_remove_objfile_probes): Likewise.
5710         (register_solib_event_probe): Add info parameter.
5711         (solist_update_incremental): Pass info parameter down to
5712         svr4_read_so_list.
5713         (disable_probes_interface): Add info parameter.
5714         (svr4_handle_solib_event): Pass current_program_space to
5715         get_svr4_info.  Adjust disable_probes_interface cleanup.
5716         (svr4_create_probe_breakpoints): Add info parameter, pass it
5717         down to register_solib_event_probe.
5718         (svr4_create_solib_event_breakpoints): Add info parameter,
5719         pass it down to svr4_create_probe_breakpoints.
5720         (enable_break): Pass info down to
5721         svr4_create_solib_event_breakpoints.
5722         (svr4_solib_create_inferior_hook): Pass current_program_space to
5723         get_svr4_info.
5724         (svr4_clear_solib): Likewise.
5725
5726 2019-04-22  Pedro Alves  <palves@redhat.com>
5727
5728         * solib-svr4.c (svr4_free_objfile_observer): New.
5729         (probe_and_action::objfile): New field.
5730         (probes_table_htab_remove_objfile_probes)
5731         (probes_table_remove_objfile_probes): New functions.
5732         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5733         in the new probe_and_action.  Don't store the probe in 'lookup'.
5734         (svr4_create_probe_breakpoints): Pass objfile to
5735         register_solib_event_probe.
5736         (_initialize_svr4_solib): Register a free_objfile observer.
5737
5738 2019-04-19  Tom Tromey  <tom@tromey.com>
5739
5740         * common/queue.h: Remove.
5741
5742 2019-04-19  Tom Tromey  <tom@tromey.com>
5743
5744         * event-loop.c: Don't include "common/queue.h".
5745
5746 2019-04-19  Tom Tromey  <tom@tromey.com>
5747
5748         * remote.c (remote_target): Use delete.
5749         * remote-notif.h: Include <list>, not "common/queue.h".
5750         (notif_client_p): Remove typedef.
5751         (remote_notif_state): Add constructor, destructor, initializer.
5752         <notif_queue>: Now a std::list.
5753         (remote_notif_state_xfree): Don't declare.
5754         * remote-notif.c (remote_notif_process, handle_notification)
5755         (remote_notif_state_allocate): Update.
5756         (~remote_notif_state): Rename from remote_notif_state_xfree.
5757
5758 2019-04-19  Tom Tromey  <tom@tromey.com>
5759
5760         * symfile.c (reread_symbols): Update.
5761         * objfiles.c (objfile_register_static_link)
5762         (objfile_lookup_static_link): Update
5763         (~objfile) Don't delete static_links.
5764         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5765
5766 2019-04-19  Tom Tromey  <tom@tromey.com>
5767
5768         * type-stack.h (struct type_stack) <insert>: Constify string.
5769         * type-stack.c (type_stack::insert): Constify string.
5770         * gdbtypes.h (lookup_template_type): Update.
5771         (address_space_name_to_int): Update.
5772         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5773         const.
5774         (lookup_template_type): Make name const.
5775         * c-exp.y: Update rules.
5776         (lex_one_token, classify_name, classify_inner_name)
5777         (c_print_token): Update.
5778         * p-exp.y: Update rules.
5779         (yylex): Update.
5780         * f-exp.y: Update rules.
5781         (yylex): Update.
5782         * d-exp.y: Update rules.
5783         (lex_one_token, classify_name, classify_inner_name): Update.
5784         * parse.c (write_dollar_variable, copy_name): Return std::string.
5785         * parser-defs.h (copy_name): Change return type.
5786         * m2-exp.y: Update rules.
5787         (yylex): Update.
5788         * go-exp.y (lex_one_token): Update.
5789         Update rules.
5790         (classify_unsafe_function, classify_packaged_name)
5791         (classify_name, yylex): Update.
5792
5793 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5794
5795         * configure.ac: add --enable-source-highlight switch.
5796         * configure: Regenerate.
5797         * top.c (print_gdb_version): plumb --enable-source-highlight
5798         status to "show configuration".
5799
5800 2019-04-19  Tom Tromey  <tromey@adacore.com>
5801
5802         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5803         Check ADA_TYPE_P.
5804         (empty_record, ada_template_to_fixed_record_type_1)
5805         (template_to_static_fixed_type)
5806         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5807         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5808         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5809         macros.
5810
5811 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5812
5813         PR symtab/24423:
5814         * source.c (print_source_lines_base): Advance "iter" when a
5815         control character is seen.
5816
5817 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5818
5819         * inferior.h (struct infcall_suspend_state_deleter):
5820         Catch exception in destructor to avoid crash.
5821
5822 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5823
5824         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5825         close to the add_com "shell".
5826
5827 2019-04-18  Tom Tromey  <tromey@adacore.com>
5828
5829         * process-stratum-target.h (class process_stratum_target)
5830         <stratum>: Add "final".
5831
5832 2019-04-17  Tom Tromey  <tromey@adacore.com>
5833
5834         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5835         against nullptr before use.
5836
5837 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5838
5839         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5840
5841 2019-04-17  Jim Wilson  <jimw@sifive.com>
5842             Andrew Burgess  <andrew.burgess@embecosm.com>
5843
5844         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5845         code read might fail, assume 4-byte breakpoint in that case.
5846
5847 2019-04-15  Leszek Swirski  <leszeks@google.com>
5848
5849         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5850         rather than a hand-rolled POD check when checking for forced MEMORY
5851         classification.
5852
5853 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5854
5855         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5856         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5857         function.
5858         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5859         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5860         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5861         declaration.
5862
5863 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5864
5865         * aarch64-linux-nat.c
5866         (aarch64_linux_nat_target::thread_architecture): Add override.
5867         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5868         each VQ.
5869
5870 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5871
5872         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5873
5874 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5875
5876         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5877         target types of size 96-bits, add some additional comments, and
5878         check that the builtin type we found was the correct size.
5879
5880 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5881
5882         * utils.c (prompt_for_continue): Don't restore the styling at the
5883         end, as applied_style has the wrong value.  This fixes styling in
5884         long lists of file names that are interrupted by the "Continue?"
5885         prompt.
5886
5887 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5888
5889         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5890         * c-lang.c (c_language_defn): Likewise.
5891         (cplus_language_defn): Likewise.
5892         (asm_language_defn): Likewise.
5893         (minimal_language_defn): Likewise.
5894         * d-lang.c (d_language_defn): Likewise.
5895         * f-lang.c (f_language_defn): Likewise.
5896         * go-lang.c (go_language_defn): Likewise.
5897         * language.c (unknown_language_defn): Likewise.
5898         (auto_language_defn): Likewise.
5899         * language.h (struct language_defn): Remove la_magic field.
5900         (LANG_MAGIC): Delete.
5901         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5902         * objc-lang.c (objc_language_defn): Likewise.
5903         * opencl-lang.c (opencl_language_defn): Likewise.
5904         * p-lang.c (pascal_language_defn): Likewise.
5905         * rust-lang.c (rust_language_defn): Likewise.
5906
5907 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5908
5909         * riscv-tdep.c (riscv_type_align): New function.
5910         (riscv_type_alignment): Delete.
5911         (riscv_arg_location): Use 'type_align'.
5912         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5913
5914 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5915
5916         * gdbtypes.c (type_align): A struct with no non-static fields also
5917         has alignment of 1.
5918
5919 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5920
5921         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5922         component to 0.
5923         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5924         member.
5925         (riscv_struct_info::analyse): New implementation using new
5926         analyse_inner member function.
5927         (riscv_struct_info::field_offset): New member function.
5928         (riscv_struct_info::m_offsets): New member variable.
5929         (riscv_struct_info::analyse_inner): New private member function,
5930         takes the old implementation of riscv_struct_info::analyse but
5931         extended to track field offsets.
5932         (riscv_call_arg_struct): Update the struct folding special cases
5933         to handle cases where empty C++ structs, which are non-zero
5934         length, are found.
5935         (riscv_arg_location): Initialise the length of each location, a
5936         non-zero length now indicates the location is in use.
5937         (riscv_push_dummy_call): Allow for the first location having a
5938         non-zero offset when setting up arguments.
5939         (riscv_return_value): Likewise, but for return values.
5940
5941 2019-04-11  Tom Tromey  <tromey@adacore.com>
5942
5943         * utils.c (internal_vproblem): Make "msg" const.
5944
5945 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5946
5947         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5948         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5949         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5950         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5951
5952 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5953
5954         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5955         function.
5956         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5957         of amd64_collect_native_gregset.
5958         (amd64_linux_nat_target::store_registers): Likewise.
5959
5960 2019-04-10  Tom Tromey  <tom@tromey.com>
5961
5962         * symtab.c (lookup_global_symbol_from_objfile)
5963         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5964         * objfiles.h (class separate_debug_iterator): New.
5965         (class separate_debug_range): New.
5966         (struct objfile) <separate_debug_objfiles>: New method.
5967         (objfile_separate_debug_iterate): Don't declare.
5968         * objfiles.c (separate_debug_iterator::operator++): Rename from
5969         objfile_separate_debug_iterate.
5970         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5971         iterator.
5972         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5973         iterator.
5974
5975 2019-04-10  Tom Tromey  <tom@tromey.com>
5976
5977         * symfile.c (reread_symbols): Remove old comment.
5978         * objfiles.c (free_all_objfiles): Fix a typo.
5979
5980 2019-04-10  Tom Tromey  <tom@tromey.com>
5981
5982         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5983         * minsyms.c (lookup_minimal_symbol): Use foreach.
5984         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5985         (lookup_minimal_symbol_solib_trampoline): Likewise.
5986         * symfile.c (reread_symbols): Use foreach.
5987
5988 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5989             Tom Tromey  <tromey@adacore.com>
5990
5991         PR rust/24414:
5992         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5993         (rust_lex_int_test): Change "value" to be LONGEST.
5994         (rust_lex_tests): Add test for long integer literal.
5995
5996 2019-04-09  Tom Tromey  <tromey@adacore.com>
5997
5998         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5999         to bool.
6000         (extended_remote_target::attach): Update.
6001         (remote_target::remote_notice_new_inferior): Update.
6002         (remote_target::add_current_inferior_and_thread): Update.
6003         * inferior.c (exit_inferior_1): Use "false".
6004         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6005
6006 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6007
6008         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6009         the "start" command.
6010
6011 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6012
6013         * python/py-inferior.c (infpy_thread_from_thread_handle):
6014         Adjust comments to reflect renaming of thread_from_thread_handle
6015         to thread_from_handle.  Adjust keywords.  Fix type error message.
6016         (inferior_object_methods): Add thread_from_handle.  Retain
6017         thread_from_thread_handle, but mark it as deprecated.
6018
6019 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6020
6021         * gdbthread.h (find_thread_by_handle): Revise declaration.
6022         * thread.c (find_thread_by_handle): Likewise.  Adjust
6023         implementation too.
6024         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6025         support for buffer objects as handles.
6026
6027 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6028
6029         * python/py-infthread.c (thpy_thread_handle): New function.
6030         (thread_object_methods): Register thpy_thread_handle.
6031
6032 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6033
6034         * gdbthread.h (thread_to_thread_handle): Declare.
6035         * thread.c (gdbtypes.h): Include.
6036         (thread_to_thread_handle): New function.
6037
6038         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6039         (target_thread_info_to_thread_handle): Declare.
6040         * target.c (target_thread_info_to_thread_handle): New function.
6041         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6042         * target-delegates.c: Regenerate.
6043
6044         * linux-thread-db.c (class thread_db_target): Add method
6045         thread_info_to_thread_handle.
6046         (thread_db_target::thread_info_to_thread_handle): Define.
6047         * remote.c (class remote_target): Add new method
6048         thread_info_to_thread_handle.
6049         (remote_target::thread_info_to_thread_handle): Define.
6050
6051 2019-04-08  Pedro Alves  <palves@redhat.com>
6052
6053         * common/common-exceptions.c (throw_exception): Don't create
6054         named object to throw; throw directly.
6055         (throw_it): Likewise.  Don't initialize gdb_exception::message
6056         here, with new; pass FMT and AP to the ctor instead.
6057         * common/common-exceptions.h: Include <string>.
6058         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6059         const char *, va_list)): New ctor.  Use std::make_shared.
6060         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6061         errors)): Delete.
6062         (gdb_exception_error::gdb_exception_error(enum errors, const char
6063         *, va_list)): New.
6064         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6065         Add assertion.
6066         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6067         errors)): Delete.
6068         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6069         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6070         Add assertion.
6071
6072 2019-04-08  Tom Tromey  <tom@tromey.com>
6073
6074         * valops.c (value_rtti_indirect_type): Replace throw_exception
6075         with throw.
6076         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6077         with throw.
6078         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6079         throw.
6080         * target.c (target_translate_tls_address): Replace throw_exception
6081         with throw.
6082         * stack.c (frame_apply_command_count): Replace throw_exception
6083         with throw.
6084         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6085         throw.
6086         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6087         with throw.
6088         * rs6000-tdep.c (rs6000_frame_cache)
6089         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6090         * remote.c: Replace throw_exception with throw.
6091         * record-full.c (record_full_message, record_full_wait_1)
6092         (record_full_restore): Replace throw_exception with throw.
6093         * record-btrace.c:
6094         (get_thread_current_frame_id, record_btrace_start_replaying)
6095         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6096         (cmd_record_btrace_start): Replace throw_exception with throw.
6097         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6098         throw.
6099         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6100         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6101         * linespec.c:
6102         (find_linespec_symbols): Replace throw_exception with throw.
6103         * infrun.c (displaced_step_prepare, resume): Replace
6104         throw_exception with throw.
6105         * infcmd.c (post_create_inferior): Replace throw_exception with
6106         throw.
6107         * inf-loop.c (inferior_event_handler): Replace throw_exception
6108         with throw.
6109         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6110         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6111         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6112         (get_prev_frame_always, get_frame_pc_if_available)
6113         (get_frame_address_in_block_if_available, get_frame_language):
6114         Replace throw_exception with throw.
6115         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6116         throw_exception with throw.
6117         * eval.c (fetch_subexp_value, evaluate_var_value)
6118         (evaluate_funcall, evaluate_subexp_standard): Replace
6119         throw_exception with throw.
6120         * dwarf2loc.c (call_site_find_chain)
6121         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6122         Replace throw_exception with throw.
6123         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6124         with throw.
6125         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6126         throw.
6127         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6128         * completer.c (complete_line_internal): Replace throw_exception
6129         with throw.
6130         * compile/compile-object-run.c (compile_object_run): Replace
6131         throw_exception with throw.
6132         * cli/cli-script.c (process_next_line): Replace throw_exception
6133         with throw.
6134         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6135         (btrace_enable, btrace_maint_update_pt_packets): Replace
6136         throw_exception with throw.
6137         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6138         throw_exception with throw.
6139         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6140         throw_exception with throw.
6141         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6142         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6143         * aarch64-tdep.c (aarch64_make_prologue_cache)
6144         (aarch64_make_stub_cache): Replace throw_exception with throw.
6145
6146 2019-04-08  Tom Tromey  <tom@tromey.com>
6147
6148         * common/common-exceptions.c (throw_exception): Rename from
6149         throw_exception_cxx.  Remove old copy.  Make argument const.
6150         (throw_it): Create and throw exception objects directly.
6151         * common/common-exceptions.h (throw_exception): Make argument
6152         const.
6153         (struct gdb_exception_error): Add constructor.
6154         (struct gdb_exception_quit): Add constructor.
6155
6156 2019-04-08  Tom Tromey  <tom@tromey.com>
6157
6158         * common/common-exceptions.h (exception_rethrow): Don't declare.
6159         (TRY_SJLJ): Update comment.
6160         (TRY, CATCH, END_CATCH): Remove.
6161         * common/common-exceptions.c (exception_rethrow): Remove.
6162
6163 2019-04-08  Tom Tromey  <tom@tromey.com>
6164
6165         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6166         Remove.
6167         (gdb_exception_error): Rename from
6168         gdb_exception_RETURN_MASK_ERROR.
6169         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6170         (gdb_quit_bad_alloc): Update.
6171         * aarch64-tdep.c: Update.
6172         * ada-lang.c: Update.
6173         * ada-typeprint.c: Update.
6174         * ada-valprint.c: Update.
6175         * amd64-tdep.c: Update.
6176         * arch-utils.c: Update.
6177         * break-catch-throw.c: Update.
6178         * breakpoint.c: Update.
6179         * btrace.c: Update.
6180         * c-varobj.c: Update.
6181         * cli/cli-cmds.c: Update.
6182         * cli/cli-interp.c: Update.
6183         * cli/cli-script.c: Update.
6184         * common/common-exceptions.c: Update.
6185         * common/new-op.c: Update.
6186         * common/selftest.c: Update.
6187         * compile/compile-c-symbols.c: Update.
6188         * compile/compile-cplus-symbols.c: Update.
6189         * compile/compile-object-load.c: Update.
6190         * compile/compile-object-run.c: Update.
6191         * completer.c: Update.
6192         * corelow.c: Update.
6193         * cp-abi.c: Update.
6194         * cp-support.c: Update.
6195         * cp-valprint.c: Update.
6196         * darwin-nat.c: Update.
6197         * disasm-selftests.c: Update.
6198         * dtrace-probe.c: Update.
6199         * dwarf-index-cache.c: Update.
6200         * dwarf-index-write.c: Update.
6201         * dwarf2-frame-tailcall.c: Update.
6202         * dwarf2-frame.c: Update.
6203         * dwarf2loc.c: Update.
6204         * dwarf2read.c: Update.
6205         * eval.c: Update.
6206         * event-loop.c: Update.
6207         * event-top.c: Update.
6208         * exec.c: Update.
6209         * f-valprint.c: Update.
6210         * fbsd-tdep.c: Update.
6211         * frame-unwind.c: Update.
6212         * frame.c: Update.
6213         * gdbtypes.c: Update.
6214         * gnu-v3-abi.c: Update.
6215         * guile/guile-internal.h: Update.
6216         * guile/scm-block.c: Update.
6217         * guile/scm-breakpoint.c: Update.
6218         * guile/scm-cmd.c: Update.
6219         * guile/scm-disasm.c: Update.
6220         * guile/scm-frame.c: Update.
6221         * guile/scm-lazy-string.c: Update.
6222         * guile/scm-math.c: Update.
6223         * guile/scm-param.c: Update.
6224         * guile/scm-ports.c: Update.
6225         * guile/scm-pretty-print.c: Update.
6226         * guile/scm-symbol.c: Update.
6227         * guile/scm-symtab.c: Update.
6228         * guile/scm-type.c: Update.
6229         * guile/scm-value.c: Update.
6230         * i386-linux-tdep.c: Update.
6231         * i386-tdep.c: Update.
6232         * inf-loop.c: Update.
6233         * infcall.c: Update.
6234         * infcmd.c: Update.
6235         * infrun.c: Update.
6236         * jit.c: Update.
6237         * language.c: Update.
6238         * linespec.c: Update.
6239         * linux-fork.c: Update.
6240         * linux-nat.c: Update.
6241         * linux-tdep.c: Update.
6242         * linux-thread-db.c: Update.
6243         * main.c: Update.
6244         * mi/mi-cmd-break.c: Update.
6245         * mi/mi-cmd-stack.c: Update.
6246         * mi/mi-interp.c: Update.
6247         * mi/mi-main.c: Update.
6248         * objc-lang.c: Update.
6249         * p-valprint.c: Update.
6250         * parse.c: Update.
6251         * ppc-linux-tdep.c: Update.
6252         * printcmd.c: Update.
6253         * python/py-arch.c: Update.
6254         * python/py-breakpoint.c: Update.
6255         * python/py-cmd.c: Update.
6256         * python/py-finishbreakpoint.c: Update.
6257         * python/py-frame.c: Update.
6258         * python/py-framefilter.c: Update.
6259         * python/py-gdb-readline.c: Update.
6260         * python/py-inferior.c: Update.
6261         * python/py-infthread.c: Update.
6262         * python/py-lazy-string.c: Update.
6263         * python/py-linetable.c: Update.
6264         * python/py-objfile.c: Update.
6265         * python/py-param.c: Update.
6266         * python/py-prettyprint.c: Update.
6267         * python/py-progspace.c: Update.
6268         * python/py-record-btrace.c: Update.
6269         * python/py-record.c: Update.
6270         * python/py-symbol.c: Update.
6271         * python/py-type.c: Update.
6272         * python/py-unwind.c: Update.
6273         * python/py-utils.c: Update.
6274         * python/py-value.c: Update.
6275         * python/python.c: Update.
6276         * record-btrace.c: Update.
6277         * record-full.c: Update.
6278         * remote-fileio.c: Update.
6279         * remote.c: Update.
6280         * riscv-tdep.c: Update.
6281         * rs6000-aix-tdep.c: Update.
6282         * rs6000-tdep.c: Update.
6283         * rust-exp.y: Update.
6284         * rust-lang.c: Update.
6285         * s390-tdep.c: Update.
6286         * selftest-arch.c: Update.
6287         * solib-dsbt.c: Update.
6288         * solib-frv.c: Update.
6289         * solib-spu.c: Update.
6290         * solib-svr4.c: Update.
6291         * solib.c: Update.
6292         * sparc64-linux-tdep.c: Update.
6293         * stack.c: Update.
6294         * symfile-mem.c: Update.
6295         * symmisc.c: Update.
6296         * target.c: Update.
6297         * thread.c: Update.
6298         * top.c: Update.
6299         * tracefile-tfile.c: Update.
6300         * tui/tui.c: Update.
6301         * typeprint.c: Update.
6302         * unittests/cli-utils-selftests.c: Update.
6303         * unittests/parse-connection-spec-selftests.c: Update.
6304         * valops.c: Update.
6305         * valprint.c: Update.
6306         * value.c: Update.
6307         * varobj.c: Update.
6308         * windows-nat.c: Update.
6309         * x86-linux-nat.c: Update.
6310         * xml-support.c: Update.
6311
6312 2019-04-08  Tom Tromey  <tom@tromey.com>
6313
6314         * xml-support.c: Use C++ exception handling.
6315         * x86-linux-nat.c: Use C++ exception handling.
6316         * windows-nat.c: Use C++ exception handling.
6317         * varobj.c: Use C++ exception handling.
6318         * value.c: Use C++ exception handling.
6319         * valprint.c: Use C++ exception handling.
6320         * valops.c: Use C++ exception handling.
6321         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6322         handling.
6323         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6324         * typeprint.c: Use C++ exception handling.
6325         * tui/tui.c: Use C++ exception handling.
6326         * tracefile-tfile.c: Use C++ exception handling.
6327         * top.c: Use C++ exception handling.
6328         * thread.c: Use C++ exception handling.
6329         * target.c: Use C++ exception handling.
6330         * symmisc.c: Use C++ exception handling.
6331         * symfile-mem.c: Use C++ exception handling.
6332         * stack.c: Use C++ exception handling.
6333         * sparc64-linux-tdep.c: Use C++ exception handling.
6334         * solib.c: Use C++ exception handling.
6335         * solib-svr4.c: Use C++ exception handling.
6336         * solib-spu.c: Use C++ exception handling.
6337         * solib-frv.c: Use C++ exception handling.
6338         * solib-dsbt.c: Use C++ exception handling.
6339         * selftest-arch.c: Use C++ exception handling.
6340         * s390-tdep.c: Use C++ exception handling.
6341         * rust-lang.c: Use C++ exception handling.
6342         * rust-exp.y: Use C++ exception handling.
6343         * rs6000-tdep.c: Use C++ exception handling.
6344         * rs6000-aix-tdep.c: Use C++ exception handling.
6345         * riscv-tdep.c: Use C++ exception handling.
6346         * remote.c: Use C++ exception handling.
6347         * remote-fileio.c: Use C++ exception handling.
6348         * record-full.c: Use C++ exception handling.
6349         * record-btrace.c: Use C++ exception handling.
6350         * python/python.c: Use C++ exception handling.
6351         * python/py-value.c: Use C++ exception handling.
6352         * python/py-utils.c: Use C++ exception handling.
6353         * python/py-unwind.c: Use C++ exception handling.
6354         * python/py-type.c: Use C++ exception handling.
6355         * python/py-symbol.c: Use C++ exception handling.
6356         * python/py-record.c: Use C++ exception handling.
6357         * python/py-record-btrace.c: Use C++ exception handling.
6358         * python/py-progspace.c: Use C++ exception handling.
6359         * python/py-prettyprint.c: Use C++ exception handling.
6360         * python/py-param.c: Use C++ exception handling.
6361         * python/py-objfile.c: Use C++ exception handling.
6362         * python/py-linetable.c: Use C++ exception handling.
6363         * python/py-lazy-string.c: Use C++ exception handling.
6364         * python/py-infthread.c: Use C++ exception handling.
6365         * python/py-inferior.c: Use C++ exception handling.
6366         * python/py-gdb-readline.c: Use C++ exception handling.
6367         * python/py-framefilter.c: Use C++ exception handling.
6368         * python/py-frame.c: Use C++ exception handling.
6369         * python/py-finishbreakpoint.c: Use C++ exception handling.
6370         * python/py-cmd.c: Use C++ exception handling.
6371         * python/py-breakpoint.c: Use C++ exception handling.
6372         * python/py-arch.c: Use C++ exception handling.
6373         * printcmd.c: Use C++ exception handling.
6374         * ppc-linux-tdep.c: Use C++ exception handling.
6375         * parse.c: Use C++ exception handling.
6376         * p-valprint.c: Use C++ exception handling.
6377         * objc-lang.c: Use C++ exception handling.
6378         * mi/mi-main.c: Use C++ exception handling.
6379         * mi/mi-interp.c: Use C++ exception handling.
6380         * mi/mi-cmd-stack.c: Use C++ exception handling.
6381         * mi/mi-cmd-break.c: Use C++ exception handling.
6382         * main.c: Use C++ exception handling.
6383         * linux-thread-db.c: Use C++ exception handling.
6384         * linux-tdep.c: Use C++ exception handling.
6385         * linux-nat.c: Use C++ exception handling.
6386         * linux-fork.c: Use C++ exception handling.
6387         * linespec.c: Use C++ exception handling.
6388         * language.c: Use C++ exception handling.
6389         * jit.c: Use C++ exception handling.
6390         * infrun.c: Use C++ exception handling.
6391         * infcmd.c: Use C++ exception handling.
6392         * infcall.c: Use C++ exception handling.
6393         * inf-loop.c: Use C++ exception handling.
6394         * i386-tdep.c: Use C++ exception handling.
6395         * i386-linux-tdep.c: Use C++ exception handling.
6396         * guile/scm-value.c: Use C++ exception handling.
6397         * guile/scm-type.c: Use C++ exception handling.
6398         * guile/scm-symtab.c: Use C++ exception handling.
6399         * guile/scm-symbol.c: Use C++ exception handling.
6400         * guile/scm-pretty-print.c: Use C++ exception handling.
6401         * guile/scm-ports.c: Use C++ exception handling.
6402         * guile/scm-param.c: Use C++ exception handling.
6403         * guile/scm-math.c: Use C++ exception handling.
6404         * guile/scm-lazy-string.c: Use C++ exception handling.
6405         * guile/scm-frame.c: Use C++ exception handling.
6406         * guile/scm-disasm.c: Use C++ exception handling.
6407         * guile/scm-cmd.c: Use C++ exception handling.
6408         * guile/scm-breakpoint.c: Use C++ exception handling.
6409         * guile/scm-block.c: Use C++ exception handling.
6410         * guile/guile-internal.h: Use C++ exception handling.
6411         * gnu-v3-abi.c: Use C++ exception handling.
6412         * gdbtypes.c: Use C++ exception handling.
6413         * frame.c: Use C++ exception handling.
6414         * frame-unwind.c: Use C++ exception handling.
6415         * fbsd-tdep.c: Use C++ exception handling.
6416         * f-valprint.c: Use C++ exception handling.
6417         * exec.c: Use C++ exception handling.
6418         * event-top.c: Use C++ exception handling.
6419         * event-loop.c: Use C++ exception handling.
6420         * eval.c: Use C++ exception handling.
6421         * dwarf2read.c: Use C++ exception handling.
6422         * dwarf2loc.c: Use C++ exception handling.
6423         * dwarf2-frame.c: Use C++ exception handling.
6424         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6425         * dwarf-index-write.c: Use C++ exception handling.
6426         * dwarf-index-cache.c: Use C++ exception handling.
6427         * dtrace-probe.c: Use C++ exception handling.
6428         * disasm-selftests.c: Use C++ exception handling.
6429         * darwin-nat.c: Use C++ exception handling.
6430         * cp-valprint.c: Use C++ exception handling.
6431         * cp-support.c: Use C++ exception handling.
6432         * cp-abi.c: Use C++ exception handling.
6433         * corelow.c: Use C++ exception handling.
6434         * completer.c: Use C++ exception handling.
6435         * compile/compile-object-run.c: Use C++ exception handling.
6436         * compile/compile-object-load.c: Use C++ exception handling.
6437         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6438         * compile/compile-c-symbols.c: Use C++ exception handling.
6439         * common/selftest.c: Use C++ exception handling.
6440         * common/new-op.c: Use C++ exception handling.
6441         * cli/cli-script.c: Use C++ exception handling.
6442         * cli/cli-interp.c: Use C++ exception handling.
6443         * cli/cli-cmds.c: Use C++ exception handling.
6444         * c-varobj.c: Use C++ exception handling.
6445         * btrace.c: Use C++ exception handling.
6446         * breakpoint.c: Use C++ exception handling.
6447         * break-catch-throw.c: Use C++ exception handling.
6448         * arch-utils.c: Use C++ exception handling.
6449         * amd64-tdep.c: Use C++ exception handling.
6450         * ada-valprint.c: Use C++ exception handling.
6451         * ada-typeprint.c: Use C++ exception handling.
6452         * ada-lang.c: Use C++ exception handling.
6453         * aarch64-tdep.c: Use C++ exception handling.
6454
6455 2019-04-08  Tom Tromey  <tom@tromey.com>
6456
6457         * xml-support.c (gdb_xml_parser::parse): Update.
6458         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6459         * value.c (show_convenience): Update.
6460         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6461         (test_parse_flags_qcs): Update.
6462         * thread.c (thr_try_catch_cmd): Update.
6463         * target.c (target_translate_tls_address): Update.
6464         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6465         (info_frame_command_core, frame_apply_command_count): Update.
6466         * rust-exp.y (rust_lex_exception_test): Update.
6467         * riscv-tdep.c (riscv_print_one_register_info): Update.
6468         * remote.c (remote_target::enable_btrace): Update.
6469         * record-btrace.c (record_btrace_enable_warn): Update.
6470         * python/py-utils.c (gdbpy_convert_exception): Update.
6471         * printcmd.c (do_one_display, print_variable_and_value): Update.
6472         * mi/mi-main.c (mi_print_exception): Update.
6473         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6474         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6475         * linux-nat.c (linux_nat_target::attach): Update.
6476         * linux-fork.c (class scoped_switch_fork_info): Update.
6477         * infrun.c (displaced_step_prepare): Update.
6478         * infcall.c (call_function_by_hand_dummy): Update.
6479         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6480         * gnu-v3-abi.c (print_one_vtable): Update.
6481         * frame.c (get_prev_frame_always): Update.
6482         * f-valprint.c (info_common_command_for_block): Update.
6483         * exec.c (try_open_exec_file): Update.
6484         * exceptions.c (print_exception, exception_print)
6485         (exception_fprintf, exception_print_same): Update.
6486         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6487         * dwarf-index-cache.c (index_cache::store)
6488         (index_cache::lookup_gdb_index): Update.
6489         * darwin-nat.c (maybe_cache_shell): Update.
6490         * cp-valprint.c (cp_print_value_fields): Update.
6491         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6492         (gcc_cplus_symbol_address): Update.
6493         * compile/compile-c-symbols.c (gcc_convert_symbol)
6494         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6495         * common/selftest.c: Update.
6496         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6497         a std::string.
6498         (exception_try_scope_entry, exception_try_scope_exit): Don't
6499         declare.
6500         (struct exception_try_scope): Remove.
6501         (TRY): Don't use exception_try_scope.
6502         (struct gdb_exception): Add constructor, operator=.
6503         <what>: New method.
6504         (struct gdb_exception_RETURN_MASK_ALL)
6505         (struct gdb_exception_RETURN_MASK_ERROR)
6506         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6507         (struct gdb_quit_bad_alloc): Update.
6508         * common/common-exceptions.c (exception_none): Change
6509         initializer.
6510         (struct catcher) <state, exception>: Initialize inline.
6511         <prev>: Remove member.
6512         (current_catcher): Remove.
6513         (catchers): New global.
6514         (exceptions_state_mc_init): Simplify.
6515         (catcher_pop): Remove.
6516         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6517         (try_scope_depth, exception_try_scope_entry)
6518         (exception_try_scope_exit): Remove.
6519         (throw_exception_sjlj): Update.
6520         (exception_messages, exception_messages_size): Remove.
6521         (throw_it): Simplify.
6522         (gdb_exception_sliced_copy): Remove.
6523         (throw_exception_cxx): Update.
6524         * cli/cli-script.c (script_from_file): Update.
6525         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6526         Update.
6527         * ada-valprint.c (ada_val_print): Update.
6528         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6529         (create_excep_cond_exprs): Update.
6530
6531 2019-04-08  Tom Tromey  <tom@tromey.com>
6532
6533         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6534         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6535         (TRY, CATCH, END_CATCH): Remove some definitions.
6536         * common/common-exceptions.c: Don't use GDB_XCPT.
6537         (catcher_list_size): Remove.
6538         (throw_exception, throw_it): Simplify.
6539
6540 2019-04-05  Tom Tromey  <tom@tromey.com>
6541
6542         Revert the header-sorting patch.
6543         * ft32-tdep.c: Revert.
6544         * frv-tdep.c: Revert.
6545         * frv-linux-tdep.c: Revert.
6546         * frame.c: Revert.
6547         * frame-unwind.c: Revert.
6548         * frame-base.c: Revert.
6549         * fork-child.c: Revert.
6550         * findvar.c: Revert.
6551         * findcmd.c: Revert.
6552         * filesystem.c: Revert.
6553         * filename-seen-cache.h: Revert.
6554         * filename-seen-cache.c: Revert.
6555         * fbsd-tdep.c: Revert.
6556         * fbsd-nat.h: Revert.
6557         * fbsd-nat.c: Revert.
6558         * f-valprint.c: Revert.
6559         * f-typeprint.c: Revert.
6560         * f-lang.c: Revert.
6561         * extension.h: Revert.
6562         * extension.c: Revert.
6563         * extension-priv.h: Revert.
6564         * expprint.c: Revert.
6565         * exec.h: Revert.
6566         * exec.c: Revert.
6567         * exceptions.c: Revert.
6568         * event-top.c: Revert.
6569         * event-loop.c: Revert.
6570         * eval.c: Revert.
6571         * elfread.c: Revert.
6572         * dwarf2read.h: Revert.
6573         * dwarf2read.c: Revert.
6574         * dwarf2loc.c: Revert.
6575         * dwarf2expr.h: Revert.
6576         * dwarf2expr.c: Revert.
6577         * dwarf2-frame.c: Revert.
6578         * dwarf2-frame-tailcall.c: Revert.
6579         * dwarf-index-write.h: Revert.
6580         * dwarf-index-write.c: Revert.
6581         * dwarf-index-common.c: Revert.
6582         * dwarf-index-cache.h: Revert.
6583         * dwarf-index-cache.c: Revert.
6584         * dummy-frame.c: Revert.
6585         * dtrace-probe.c: Revert.
6586         * disasm.h: Revert.
6587         * disasm.c: Revert.
6588         * disasm-selftests.c: Revert.
6589         * dictionary.c: Revert.
6590         * dicos-tdep.c: Revert.
6591         * demangle.c: Revert.
6592         * dcache.h: Revert.
6593         * dcache.c: Revert.
6594         * darwin-nat.h: Revert.
6595         * darwin-nat.c: Revert.
6596         * darwin-nat-info.c: Revert.
6597         * d-valprint.c: Revert.
6598         * d-namespace.c: Revert.
6599         * d-lang.c: Revert.
6600         * ctf.c: Revert.
6601         * csky-tdep.c: Revert.
6602         * csky-linux-tdep.c: Revert.
6603         * cris-tdep.c: Revert.
6604         * cris-linux-tdep.c: Revert.
6605         * cp-valprint.c: Revert.
6606         * cp-support.c: Revert.
6607         * cp-namespace.c: Revert.
6608         * cp-abi.c: Revert.
6609         * corelow.c: Revert.
6610         * corefile.c: Revert.
6611         * continuations.c: Revert.
6612         * completer.h: Revert.
6613         * completer.c: Revert.
6614         * complaints.c: Revert.
6615         * coffread.c: Revert.
6616         * coff-pe-read.c: Revert.
6617         * cli-out.h: Revert.
6618         * cli-out.c: Revert.
6619         * charset.c: Revert.
6620         * c-varobj.c: Revert.
6621         * c-valprint.c: Revert.
6622         * c-typeprint.c: Revert.
6623         * c-lang.c: Revert.
6624         * buildsym.c: Revert.
6625         * buildsym-legacy.c: Revert.
6626         * build-id.h: Revert.
6627         * build-id.c: Revert.
6628         * btrace.c: Revert.
6629         * bsd-uthread.c: Revert.
6630         * breakpoint.h: Revert.
6631         * breakpoint.c: Revert.
6632         * break-catch-throw.c: Revert.
6633         * break-catch-syscall.c: Revert.
6634         * break-catch-sig.c: Revert.
6635         * blockframe.c: Revert.
6636         * block.c: Revert.
6637         * bfin-tdep.c: Revert.
6638         * bfin-linux-tdep.c: Revert.
6639         * bfd-target.c: Revert.
6640         * bcache.c: Revert.
6641         * ax-general.c: Revert.
6642         * ax-gdb.h: Revert.
6643         * ax-gdb.c: Revert.
6644         * avr-tdep.c: Revert.
6645         * auxv.c: Revert.
6646         * auto-load.c: Revert.
6647         * arm-wince-tdep.c: Revert.
6648         * arm-tdep.c: Revert.
6649         * arm-symbian-tdep.c: Revert.
6650         * arm-pikeos-tdep.c: Revert.
6651         * arm-obsd-tdep.c: Revert.
6652         * arm-nbsd-tdep.c: Revert.
6653         * arm-nbsd-nat.c: Revert.
6654         * arm-linux-tdep.c: Revert.
6655         * arm-linux-nat.c: Revert.
6656         * arm-fbsd-tdep.c: Revert.
6657         * arm-fbsd-nat.c: Revert.
6658         * arm-bsd-tdep.c: Revert.
6659         * arch-utils.c: Revert.
6660         * arc-tdep.c: Revert.
6661         * arc-newlib-tdep.c: Revert.
6662         * annotate.h: Revert.
6663         * annotate.c: Revert.
6664         * amd64-windows-tdep.c: Revert.
6665         * amd64-windows-nat.c: Revert.
6666         * amd64-tdep.c: Revert.
6667         * amd64-sol2-tdep.c: Revert.
6668         * amd64-obsd-tdep.c: Revert.
6669         * amd64-obsd-nat.c: Revert.
6670         * amd64-nbsd-tdep.c: Revert.
6671         * amd64-nbsd-nat.c: Revert.
6672         * amd64-nat.c: Revert.
6673         * amd64-linux-tdep.c: Revert.
6674         * amd64-linux-nat.c: Revert.
6675         * amd64-fbsd-tdep.c: Revert.
6676         * amd64-fbsd-nat.c: Revert.
6677         * amd64-dicos-tdep.c: Revert.
6678         * amd64-darwin-tdep.c: Revert.
6679         * amd64-bsd-nat.c: Revert.
6680         * alpha-tdep.c: Revert.
6681         * alpha-obsd-tdep.c: Revert.
6682         * alpha-nbsd-tdep.c: Revert.
6683         * alpha-mdebug-tdep.c: Revert.
6684         * alpha-linux-tdep.c: Revert.
6685         * alpha-linux-nat.c: Revert.
6686         * alpha-bsd-tdep.c: Revert.
6687         * alpha-bsd-nat.c: Revert.
6688         * aix-thread.c: Revert.
6689         * agent.c: Revert.
6690         * addrmap.c: Revert.
6691         * ada-varobj.c: Revert.
6692         * ada-valprint.c: Revert.
6693         * ada-typeprint.c: Revert.
6694         * ada-tasks.c: Revert.
6695         * ada-lang.c: Revert.
6696         * aarch64-tdep.c: Revert.
6697         * aarch64-ravenscar-thread.c: Revert.
6698         * aarch64-newlib-tdep.c: Revert.
6699         * aarch64-linux-tdep.c: Revert.
6700         * aarch64-linux-nat.c: Revert.
6701         * aarch64-fbsd-tdep.c: Revert.
6702         * aarch64-fbsd-nat.c: Revert.
6703         * aarch32-linux-nat.c: Revert.
6704
6705 2019-04-05  Tom Tromey  <tom@tromey.com>
6706
6707         * ft32-tdep.c: Sort headers.
6708         * frv-tdep.c: Sort headers.
6709         * frv-linux-tdep.c: Sort headers.
6710         * frame.c: Sort headers.
6711         * frame-unwind.c: Sort headers.
6712         * frame-base.c: Sort headers.
6713         * fork-child.c: Sort headers.
6714         * findvar.c: Sort headers.
6715         * findcmd.c: Sort headers.
6716         * filesystem.c: Sort headers.
6717         * filename-seen-cache.h: Sort headers.
6718         * filename-seen-cache.c: Sort headers.
6719         * fbsd-tdep.c: Sort headers.
6720         * fbsd-nat.h: Sort headers.
6721         * fbsd-nat.c: Sort headers.
6722         * f-valprint.c: Sort headers.
6723         * f-typeprint.c: Sort headers.
6724         * f-lang.c: Sort headers.
6725         * extension.h: Sort headers.
6726         * extension.c: Sort headers.
6727         * extension-priv.h: Sort headers.
6728         * expprint.c: Sort headers.
6729         * exec.h: Sort headers.
6730         * exec.c: Sort headers.
6731         * exceptions.c: Sort headers.
6732         * event-top.c: Sort headers.
6733         * event-loop.c: Sort headers.
6734         * eval.c: Sort headers.
6735         * elfread.c: Sort headers.
6736         * dwarf2read.h: Sort headers.
6737         * dwarf2read.c: Sort headers.
6738         * dwarf2loc.c: Sort headers.
6739         * dwarf2expr.h: Sort headers.
6740         * dwarf2expr.c: Sort headers.
6741         * dwarf2-frame.c: Sort headers.
6742         * dwarf2-frame-tailcall.c: Sort headers.
6743         * dwarf-index-write.h: Sort headers.
6744         * dwarf-index-write.c: Sort headers.
6745         * dwarf-index-common.c: Sort headers.
6746         * dwarf-index-cache.h: Sort headers.
6747         * dwarf-index-cache.c: Sort headers.
6748         * dummy-frame.c: Sort headers.
6749         * dtrace-probe.c: Sort headers.
6750         * disasm.h: Sort headers.
6751         * disasm.c: Sort headers.
6752         * disasm-selftests.c: Sort headers.
6753         * dictionary.c: Sort headers.
6754         * dicos-tdep.c: Sort headers.
6755         * demangle.c: Sort headers.
6756         * dcache.h: Sort headers.
6757         * dcache.c: Sort headers.
6758         * darwin-nat.h: Sort headers.
6759         * darwin-nat.c: Sort headers.
6760         * darwin-nat-info.c: Sort headers.
6761         * d-valprint.c: Sort headers.
6762         * d-namespace.c: Sort headers.
6763         * d-lang.c: Sort headers.
6764         * ctf.c: Sort headers.
6765         * csky-tdep.c: Sort headers.
6766         * csky-linux-tdep.c: Sort headers.
6767         * cris-tdep.c: Sort headers.
6768         * cris-linux-tdep.c: Sort headers.
6769         * cp-valprint.c: Sort headers.
6770         * cp-support.c: Sort headers.
6771         * cp-namespace.c: Sort headers.
6772         * cp-abi.c: Sort headers.
6773         * corelow.c: Sort headers.
6774         * corefile.c: Sort headers.
6775         * continuations.c: Sort headers.
6776         * completer.h: Sort headers.
6777         * completer.c: Sort headers.
6778         * complaints.c: Sort headers.
6779         * coffread.c: Sort headers.
6780         * coff-pe-read.c: Sort headers.
6781         * cli-out.h: Sort headers.
6782         * cli-out.c: Sort headers.
6783         * charset.c: Sort headers.
6784         * c-varobj.c: Sort headers.
6785         * c-valprint.c: Sort headers.
6786         * c-typeprint.c: Sort headers.
6787         * c-lang.c: Sort headers.
6788         * buildsym.c: Sort headers.
6789         * buildsym-legacy.c: Sort headers.
6790         * build-id.h: Sort headers.
6791         * build-id.c: Sort headers.
6792         * btrace.c: Sort headers.
6793         * bsd-uthread.c: Sort headers.
6794         * breakpoint.h: Sort headers.
6795         * breakpoint.c: Sort headers.
6796         * break-catch-throw.c: Sort headers.
6797         * break-catch-syscall.c: Sort headers.
6798         * break-catch-sig.c: Sort headers.
6799         * blockframe.c: Sort headers.
6800         * block.c: Sort headers.
6801         * bfin-tdep.c: Sort headers.
6802         * bfin-linux-tdep.c: Sort headers.
6803         * bfd-target.c: Sort headers.
6804         * bcache.c: Sort headers.
6805         * ax-general.c: Sort headers.
6806         * ax-gdb.h: Sort headers.
6807         * ax-gdb.c: Sort headers.
6808         * avr-tdep.c: Sort headers.
6809         * auxv.c: Sort headers.
6810         * auto-load.c: Sort headers.
6811         * arm-wince-tdep.c: Sort headers.
6812         * arm-tdep.c: Sort headers.
6813         * arm-symbian-tdep.c: Sort headers.
6814         * arm-pikeos-tdep.c: Sort headers.
6815         * arm-obsd-tdep.c: Sort headers.
6816         * arm-nbsd-tdep.c: Sort headers.
6817         * arm-nbsd-nat.c: Sort headers.
6818         * arm-linux-tdep.c: Sort headers.
6819         * arm-linux-nat.c: Sort headers.
6820         * arm-fbsd-tdep.c: Sort headers.
6821         * arm-fbsd-nat.c: Sort headers.
6822         * arm-bsd-tdep.c: Sort headers.
6823         * arch-utils.c: Sort headers.
6824         * arc-tdep.c: Sort headers.
6825         * arc-newlib-tdep.c: Sort headers.
6826         * annotate.h: Sort headers.
6827         * annotate.c: Sort headers.
6828         * amd64-windows-tdep.c: Sort headers.
6829         * amd64-windows-nat.c: Sort headers.
6830         * amd64-tdep.c: Sort headers.
6831         * amd64-sol2-tdep.c: Sort headers.
6832         * amd64-obsd-tdep.c: Sort headers.
6833         * amd64-obsd-nat.c: Sort headers.
6834         * amd64-nbsd-tdep.c: Sort headers.
6835         * amd64-nbsd-nat.c: Sort headers.
6836         * amd64-nat.c: Sort headers.
6837         * amd64-linux-tdep.c: Sort headers.
6838         * amd64-linux-nat.c: Sort headers.
6839         * amd64-fbsd-tdep.c: Sort headers.
6840         * amd64-fbsd-nat.c: Sort headers.
6841         * amd64-dicos-tdep.c: Sort headers.
6842         * amd64-darwin-tdep.c: Sort headers.
6843         * amd64-bsd-nat.c: Sort headers.
6844         * alpha-tdep.c: Sort headers.
6845         * alpha-obsd-tdep.c: Sort headers.
6846         * alpha-nbsd-tdep.c: Sort headers.
6847         * alpha-mdebug-tdep.c: Sort headers.
6848         * alpha-linux-tdep.c: Sort headers.
6849         * alpha-linux-nat.c: Sort headers.
6850         * alpha-bsd-tdep.c: Sort headers.
6851         * alpha-bsd-nat.c: Sort headers.
6852         * aix-thread.c: Sort headers.
6853         * agent.c: Sort headers.
6854         * addrmap.c: Sort headers.
6855         * ada-varobj.c: Sort headers.
6856         * ada-valprint.c: Sort headers.
6857         * ada-typeprint.c: Sort headers.
6858         * ada-tasks.c: Sort headers.
6859         * ada-lang.c: Sort headers.
6860         * aarch64-tdep.c: Sort headers.
6861         * aarch64-ravenscar-thread.c: Sort headers.
6862         * aarch64-newlib-tdep.c: Sort headers.
6863         * aarch64-linux-tdep.c: Sort headers.
6864         * aarch64-linux-nat.c: Sort headers.
6865         * aarch64-fbsd-tdep.c: Sort headers.
6866         * aarch64-fbsd-nat.c: Sort headers.
6867         * aarch32-linux-nat.c: Sort headers.
6868
6869 2019-04-04  Tom Tromey  <tom@tromey.com>
6870
6871         * varobj.c (varobj_create): Update.
6872         * rust-exp.y (struct rust_parser) <update_innermost_block,
6873         lookup_symbol>: New methods.
6874         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6875         Rename.
6876         (rust_parser::rust_lookup_type)
6877         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6878         * printcmd.c (display_command, do_one_display): Update.
6879         * parser-defs.h (struct parser_state) <parser_state>: Add
6880         "tracker" parameter.
6881         (block_tracker): New member.
6882         (class innermost_block_tracker) <innermost_block_tracker>: Add
6883         "types" parameter.
6884         <reset>: Remove method.
6885         (innermost_block): Don't declare.
6886         (null_post_parser): Update.
6887         * parse.c (innermost_block): Remove global.
6888         (write_dollar_variable): Update.
6889         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6890         Remove "tracker_types" parameter.
6891         (parse_expression): Add "tracker" parameter.
6892         (parse_expression_for_completion): Update.
6893         (null_post_parser): Add "tracker" parameter.
6894         * p-exp.y: Update rules.
6895         * m2-exp.y: Update rules.
6896         * language.h (struct language_defn) <la_post_parser>: Add
6897         "tracker" parameter.
6898         * go-exp.y: Update rules.
6899         * f-exp.y: Update rules.
6900         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6901         parameter.
6902         * d-exp.y: Update rules.
6903         * c-exp.y: Update rules.
6904         * breakpoint.c (set_breakpoint_condition): Create an
6905         innermost_block_tracker.
6906         (watch_command_1): Likewise.
6907         * ada-lang.c (resolve): Add "tracker" parameter.
6908         (resolve_subexp): Likewise.
6909         * ada-exp.y (write_var_from_sym): Update.
6910
6911 2019-04-04  Tom Tromey  <tom@tromey.com>
6912
6913         * type-stack.h: New file.
6914         * type-stack.c: New file.
6915         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6916         type-stack.h.
6917         (insert_into_type_stack, insert_type, push_type, push_type_int)
6918         (insert_type_address_space, pop_type, pop_type_int)
6919         (pop_typelist, pop_type_stack, append_type_stack)
6920         (push_type_stack, get_type_stack, push_typelist)
6921         (follow_type_instance_flags, follow_types): Don't declare.
6922         * parse.c (type_stack): Remove global.
6923         (parse_exp_in_context): Update.
6924         (insert_into_type_stack, insert_type, push_type, push_type_int)
6925         (insert_type_address_space, pop_type, pop_type_int)
6926         (pop_typelist, pop_type_stack, append_type_stack)
6927         (push_type_stack, get_type_stack, push_typelist)
6928         (follow_type_instance_flags, follow_types): Remove (moved to
6929         type-stack.c).
6930         * f-exp.y (type_stack): New global.
6931         Update rules.
6932         (push_kind_type, f_parse): Update.
6933         * d-exp.y (type_stack): New global.
6934         Update rules.
6935         (d_parse): Update.
6936         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6937         Update rules.
6938         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6939         (HFILES_NO_SRCDIR): Add type-stack.h.
6940
6941 2019-04-04  Tom Tromey  <tom@tromey.com>
6942
6943         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6944         (rust_parser::convert_ast_to_expression, rust_parse)
6945         (rust_lex_test_completion, rust_lex_tests): Update.
6946         * parser-defs.h (struct expr_completion_state): New.
6947         (struct parser_state) <parser_state>: Add completion parameter.
6948         <mark_struct_expression, mark_completion_tag>: New methods.
6949         <parse_completion, m_completion_state>: New members.
6950         (prefixify_expression, null_post_parser): Update.
6951         (mark_struct_expression, mark_completion_tag): Don't declare.
6952         * parse.c (parse_completion, expout_last_struct)
6953         (expout_tag_completion_type, expout_completion_name): Remove
6954         globals.
6955         (parser_state::mark_struct_expression)
6956         (parser_state::mark_completion_tag): Now methods.
6957         (prefixify_expression): Add last_struct parameter.
6958         (prefixify_subexp): Likewise.
6959         (parse_exp_1): Update.
6960         (parse_exp_in_context): Add cstate parameter.  Update.
6961         (parse_expression_for_completion): Create an
6962         expr_completion_state.
6963         (null_post_parser): Add "completion" parameter.
6964         * p-exp.y: Update rules.
6965         (yylex): Update.
6966         * language.h (struct language_defn) <la_post_parser>: Add
6967         "completing" parameter.
6968         * go-exp.y: Update rules.
6969         (lex_one_token): Update.
6970         * expression.h (parse_completion): Don't declare.
6971         * d-exp.y: Update rules.
6972         (lex_one_token): Update rules.
6973         * c-exp.y: Update rules.
6974         (lex_one_token): Update.
6975         * ada-lang.c (resolve): Add "parse_completion" parameter.
6976         (resolve_subexp): Likewise.
6977         (ada_resolve_function): Likewise.
6978
6979 2019-04-04  Tom Tromey  <tom@tromey.com>
6980
6981         * parser-defs.h (struct parser_state) <start_arglist,
6982         end_arglist>: New methods.
6983         <arglist_len, m_funcall_chain>: New members.
6984         (arglist_len, start_arglist, end_arglist): Don't declare.
6985         * parse.c (arglist_len, funcall_chain): Remove global.
6986         (start_arglist, end_arglist): Remove functions.
6987         (parse_exp_in_context): Update.
6988         * p-exp.y: Update rules.
6989         * m2-exp.y: Update rules.
6990         * go-exp.y: Update rules.
6991         * f-exp.y: Update rules.
6992         * d-exp.y: Update rules.
6993         * c-exp.y: Update rules.
6994
6995 2019-04-04  Tom Tromey  <tom@tromey.com>
6996
6997         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6998         lex_operator, push_back>: New methods.
6999         Update all rules.
7000         (rust_parser::lex_hex, lex_escape): Rename and update.
7001         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7002         (rust_parser::lex_operator): Rename and update.
7003         (rust_parser::lex_number, rustyylex, rustyyerror)
7004         (rust_lex_test_init, rust_lex_test_sequence)
7005         (rust_lex_test_push_back, rust_lex_tests): Update.
7006         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7007         parameter.
7008         <lexptr, prev_lexptr>: New members.
7009         (lexptr, prev_lexptr): Don't declare.
7010         * parse.c (lexptr, prev_lexptr): Remove globals.
7011         (parse_exp_in_context): Update.
7012         * p-exp.y (yylex, yyerror): Update.
7013         * m2-exp.y (parse_number, yylex, yyerror): Update.
7014         * go-exp.y (lex_one_token, yyerror): Update.
7015         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7016         * d-exp.y (lex_one_token, yyerror): Update.
7017         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7018         (lex_one_token, yyerror): Update.
7019         * ada-lex.l (YY_INPUT): Update.
7020         (rewind_to_char): Update.
7021         * ada-exp.y (yyerror): Update.
7022
7023 2019-04-04  Tom Tromey  <tom@tromey.com>
7024
7025         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7026         * parser-defs.h (struct parser_state) <parser_state>: Add new
7027         parameter.
7028         <comma_terminates>: New member.
7029         (comma_terminates): Don't declare global.
7030         * parse.c (comma_terminates): Remove global.
7031         (parse_exp_in_context): Update.
7032         * p-exp.y (yylex): Update.
7033         * m2-exp.y (yylex): Update.
7034         * go-exp.y (lex_one_token): Update.
7035         * f-exp.y (yylex): Update.
7036         * d-exp.y (lex_one_token): Update.
7037         * c-exp.y (lex_one_token): Update.
7038         * ada-lex.l: Update.
7039
7040 2019-04-04  Tom Tromey  <tom@tromey.com>
7041
7042         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7043         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7044         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7045         * parser-defs.h (paren_depth): Don't declare.
7046         * parse.c (paren_depth): Remove global.
7047         (parse_exp_in_context): Update.
7048         * p-exp.y (paren_depth): New global.
7049         (pascal_parse): Initialize it.
7050         * m2-exp.y (paren_depth): New global.
7051         (m2_parse): Initialize it.
7052         * go-exp.y (paren_depth): New global.
7053         (go_parse): Initialize it.
7054         * f-exp.y (paren_depth): New global.
7055         (f_parse): Initialize it.
7056         * d-exp.y (paren_depth): New global.
7057         (d_parse): Initialize it.
7058         * c-exp.y (paren_depth): New global.
7059         (c_parse): Initialize it.
7060         * ada-lex.l (paren_depth): New global.
7061         (lexer_init): Initialize it.
7062
7063 2019-04-04  Tom Tromey  <tom@tromey.com>
7064
7065         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7066         (rust_parser::convert_ast_to_type)
7067         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7068         * parser-defs.h (struct parser_state) <parser_state>: Add
7069         parameters.  Initialize new members.
7070         <expression_context_block, expression_context_pc>: New members.
7071         * parse.c (expression_context_block, expression_context_pc):
7072         Remove globals.
7073         (parse_exp_in_context): Update.
7074         * p-exp.y: Update all rules.
7075         (yylex): Update.
7076         * m2-exp.y: Update all rules.
7077         (yylex): Update.
7078         * go-exp.y (yylex): Update.
7079         * f-exp.y (yylex): Update.
7080         * d-exp.y: Update all rules.
7081         (yylex): Update.
7082         * c-exp.y: Update all rules.
7083         (lex_one_token, classify_name, yylex, c_parse): Update.
7084         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7085
7086 2019-04-04  Tom Tromey  <tom@tromey.com>
7087
7088         * gdbarch.h, gdbarch.c: Rebuild.
7089         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7090         * stap-probe.h:
7091         (struct stap_parse_info): Replace "parser_state" with
7092         "expr_builder".
7093         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7094         (parser_state): New class.
7095         * parse.c (expr_builder): Rename.
7096         (expr_builder::release): Rename.
7097         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7098         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7099         (write_exp_elt_longcst, write_exp_elt_floatcst)
7100         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7101         (write_exp_string_vector, write_exp_bitstring)
7102         (write_exp_msymbol, mark_struct_expression)
7103         (write_dollar_variable)
7104         (insert_type_address_space, increase_expout_size): Replace
7105         "parser_state" with "expr_builder".
7106         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7107         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7108         "parser_state" with "expr_builder".
7109
7110 2019-04-04  Tom Tromey  <tom@tromey.com>
7111
7112         * rust-exp.y: Replace "parse_language" with method call.
7113         * p-exp.y:
7114         (yylex): Replace "parse_language" with method call.
7115         * m2-exp.y:
7116         (yylex): Replace "parse_language" with method call.
7117         * go-exp.y (classify_name): Replace "parse_language" with method
7118         call.
7119         * f-exp.y (yylex): Replace "parse_language" with method call.
7120         * d-exp.y (lex_one_token): Replace "parse_language" with method
7121         call.
7122         * c-exp.y:
7123         (lex_one_token, classify_name, yylex): Replace "parse_language"
7124         with method call.
7125         * ada-exp.y (find_primitive_type, type_char)
7126         (type_system_address): Replace "parse_language" with method call.
7127
7128 2019-04-04  Tom Tromey  <tom@tromey.com>
7129
7130         * rust-exp.y: Replace "parse_gdbarch" with method call.
7131         * parse.c (write_dollar_variable, insert_type_address_space):
7132         Replace "parse_gdbarch" with method call.
7133         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7134         call.
7135         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7136         call.
7137         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7138         "parse_gdbarch" with method call.
7139         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7140         with method call.
7141         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7142         "parse_gdbarch" with method call.
7143         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7144         "parse_gdbarch" with method call.
7145         * c-exp.y (parse_type, parse_number, classify_name): Replace
7146         "parse_gdbarch" with method call.
7147         * ada-lex.l: Replace "parse_gdbarch" with method call.
7148         * ada-exp.y (parse_type, find_primitive_type, type_char)
7149         (type_system_address): Replace "parse_gdbarch" with method call.
7150
7151 2019-04-04  Tom Tromey  <tom@tromey.com>
7152
7153         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7154         * stap-probe.c (stap_parse_argument): Update.
7155         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7156         initial_size parameter.
7157         * rust-exp.y (rust_lex_tests): Update.
7158         * parse.c (parser_state): Update.
7159         (parse_exp_in_context): Update.
7160         * parser-defs.h (struct parser_state) <parser_state>: Remove
7161         "initial_size" parameter.
7162
7163 2019-04-04  Tom Tromey  <tom@tromey.com>
7164
7165         * parser-defs.h (increase_expout_size): Don't declare.
7166         * parse.c (increase_expout_size): Now static.
7167
7168 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7169
7170         * gnu-nat.c (gnu_nat_target::wait): Fix
7171         target_waitstatus_to_string call.
7172
7173 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7174
7175         * eval.c (evaluate_subexp_standard): Handle internal functions
7176         during Fortran function call handling.
7177
7178 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7179
7180         * NEWS: Mention new internal functions.
7181         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7182         (read_base_type): Use dwarf2_init_complex_target_type.
7183         * value.c (creal_internal_fn): New function.
7184         (cimag_internal_fn): New function.
7185         (_initialize_values): Register new internal functions.
7186
7187 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7188
7189         * infrun.c (stop_all_threads): If debug_infrun, always
7190         trace the wait status after wait_one, using
7191         target_waitstatus_to_string and target_pid_to_str.
7192         (handle_inferior_event): Replace various trace of
7193         wait status kind by a single trace.
7194         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7195         wait status kind image by target_waitstatus_to_string.
7196         * target/waitstatus.c (target_waitstatus_to_string): Fix
7197         obsolete comment.
7198
7199 2019-04-01  Tom Tromey  <tromey@adacore.com>
7200
7201         PR symtab/23331:
7202         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7203
7204 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7205             Pedro Alves  <palves@redhat.com>
7206
7207         * top.c (quit_force): Call 'finalize_values'.
7208         * value.c (finalize_values): New function.
7209         * value.h (finalize_values): Declare.
7210
7211 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7212
7213         * NEWS: Announce $_gdb_major and $_gdb_minor.
7214
7215         * top.c (init_gdb_version_vars): New function.
7216         (gdb_init): Call init_gdb_version_vars.
7217
7218 2019-03-29  Tom Tromey  <tromey@adacore.com>
7219
7220         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7221         help text.  Remove dead code.
7222
7223 2019-03-29  Keith Seitz  <keiths@redhat.com>
7224
7225         From Siddhesh Poyarekar:
7226         * f-lang.h (f77_get_upperbound): Return LONGEST.
7227         (f77_get_lowerbound): Likewise.
7228         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7229         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7230         print them.
7231         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7232         plongest to format print it.
7233         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7234         (f77_get_upperbound): Likewise.
7235         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7236         LOWER_BOUND to LONGEST.
7237         (f77_create_arrayprint_offset_tbl): Likewise.
7238
7239 2019-03-29  Keith Seitz  <keiths@redhat.com>
7240
7241         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7242         %s/pulongest for TYPE_LENGTH instead of %d in format
7243         strings.
7244         * ada-typerint.c (ada_print_type): Likewise.
7245         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7246         * compile/compile-c-support.c (generate_register_struct): Likewise.
7247         * gdbtypes.c (recursive_dump_type): Likewise.
7248         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7249         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7250         instead of %d in format strings.
7251         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7252         to std::min to ULONGEST.
7253         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7254         instead of %d in format strings.
7255         * tracepoint.c (info_scope_command): Likewise.
7256         * typeprint.c (print_offset_data::update)
7257         (print_offset_data::finish): Likewise.
7258         * xtensa-tdep.c (xtensa_store_return_value)
7259         (xtensa_push_dummy_call): Likewise.
7260
7261 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7262
7263         * windows-nat.c (display_selector): Fixed format specifications
7264         for 64-bit Cygwin.
7265
7266 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7267
7268         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7269
7270 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7271
7272         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7273         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7274         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7275         (nios2_linux_init_abi): Install it.
7276
7277 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7278
7279         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7280
7281 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7282
7283         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7284
7285 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7286             Tom Tromey  <tromey@adacore.com>
7287
7288         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7289
7290 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7291
7292         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7293         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7294         method to compute the bounds of range types. Also print "[evaluated]"
7295         if the bounds' values come from a dynamic evaluation.
7296
7297 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7298
7299         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7300         whitespace when pretty printing is on.
7301
7302 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7303
7304         * ppc-linux-nat.c: Add include.
7305
7306 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7307
7308         * NEWS: Mention AArch64 Pointer Authentication.
7309
7310 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7311
7312         * arm-linux-nat.c: Add include.
7313
7314 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7315
7316         * source-cache.c (source_cache::get_source_lines): Re-read
7317         fullname after calling open_source_file.
7318
7319 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7320
7321         * NEWS: Mention TLS support for FreeBSD.
7322
7323 2019-03-25  Tom Tromey  <tromey@adacore.com>
7324
7325         * minsyms.c (BUNCH_SIZE): Update comment.
7326         (~minimal_symbol_reader): Remove old comment.
7327         (compact_minimal_symbols): Update comment.
7328         (minimal_symbol_reader::install): Remove old comment.  Update
7329         other comments.
7330
7331 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7332
7333         * s390-linux-nat.c: Add include.
7334
7335 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7336
7337         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7338         Call linux_get_hwcap.
7339         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7340         Likewise.
7341         (aarch64_linux_get_hwcap): Remove function.
7342         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7343         declaration.
7344         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7345         linux_get_hwcap.
7346         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7347         * linux-tdep.c (linux_get_hwcap): Add function.
7348         (linux_get_hwcap2): Likewise.
7349         * linux-tdep.h (linux_get_hwcap): Add declaration.
7350         (linux_get_hwcap2): Likewise.
7351         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7352         (ppc_linux_get_hwcap2): Likewise.
7353         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7354         linux_get_hwcap.
7355         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7356         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7357         (ppc_linux_nat_target::read_description): Likewise.
7358         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7359         * s390-linux-nat.c: Likewise.
7360         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7361
7362 2019-03-24  Tom Tromey  <tom@tromey.com>
7363
7364         * ada-lang.c (standard_lookup): Simplify initialization.
7365         (ada_lookup_symbol_nonlocal): Simplify return.
7366         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7367         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7368         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7369         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7370         initialization.
7371         * solib.c (solib_global_lookup): Simplify.
7372         * symtab.c (null_block_symbol): Remove.
7373         (symbol_cache_lookup): Simplify returns.
7374         (lookup_language_this): Simplify returns.
7375         (lookup_symbol_aux): Simplify return.
7376         (lookup_local_symbol): Simplify returns.
7377         (lookup_global_symbol_from_objfile): Simplify return.
7378         (lookup_symbol_in_objfile_symtabs)
7379         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7380         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7381         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7382         * cp-namespace.c (cp_lookup_bare_symbol)
7383         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7384         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7385         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7386         (cp_lookup_symbol_via_imports): Simplify initialization.
7387         (find_symbol_in_baseclass): Likewise.
7388         * symtab.h (null_block_symbol): Remove.
7389         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7390         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7391         (d_lookup_symbol_module): Likewise.
7392         (find_symbol_in_baseclass): Simplify initialization.
7393
7394 2019-03-24  Tom Tromey  <tom@tromey.com>
7395
7396         * expression.h: Don't include symtab.h.
7397         (struct block): Forward declare.
7398
7399 2019-03-24  Tom Tromey  <tom@tromey.com>
7400
7401         * c-exp.y (typebase): Remove casts.
7402         * gdbtypes.c (lookup_unsigned_typename, )
7403         (lookup_signed_typename): Remove cast.
7404         * eval.c (parse_to_comma_and_eval): Remove cast.
7405         * parse.c (write_dollar_variable): Remove cast.
7406         * block.h (struct block) <superblock>: Now const.
7407         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7408         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7409         (map_block): Make "block" const.
7410         * symfile.h (struct quick_symbol_functions)
7411         <map_matching_symbols>: Constify block argument to "callback".
7412         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7413         const.
7414         (find_pc_sect_compunit_symtab): Make "b" const.
7415         (find_symbol_at_address): Likewise.
7416         (search_symbols): Likewise.
7417         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7418         (dw2_debug_names_lookup_symbol): Likewise.
7419         (dw2_map_matching_symbols): Update.
7420         * p-valprint.c (pascal_val_print): Remove "block".
7421         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7422         (aux_add_nonlocal_symbols): Make "block" const.
7423         (resolve_subexp): Remove cast.
7424         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7425         const.
7426         (iterate_over_file_blocks): Likewise.
7427         * f-exp.y (%union) <bval>: Remove.
7428         * coffread.c (patch_opaque_types): Make "b" const.
7429         * spu-tdep.c (spu_catch_start): Make "block" const.
7430         * c-valprint.c (print_unpacked_pointer): Remove "block".
7431         * symmisc.c (dump_symtab_1): Make "b" const.
7432         (block_depth): Make "block" const.
7433         * d-exp.y (%union) <bval>: Remove.
7434         * cp-support.h (cp_lookup_rtti_type): Update.
7435         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7436         * psymtab.c (psym_lookup_symbol): Make "block" const.
7437         (maintenance_check_psymtabs): Make "b" const.
7438         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7439         (enumerate_locals, enumerate_args): Update.
7440         * python/py-symtab.c (stpy_global_block): Make "block" const.
7441         (stpy_static_block): Likewise.
7442         * inline-frame.c (block_starting_point_at): Make "new_block"
7443         const.
7444         * block.c (find_block_in_blockvector): Make return type const.
7445         (blockvector_for_pc_sect): Make "b" const.
7446         (find_block_in_blockvector): Make "b" const.
7447
7448 2019-03-23  Tom Tromey  <tom@tromey.com>
7449
7450         * varobj.c (varobj_create): Update.
7451         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7452         * printcmd.c (display_command, do_one_display): Don't reset
7453         innermost_block.
7454         * parser-defs.h (enum innermost_block_tracker_type): Move to
7455         expression.h.
7456         (innermost_block): Update comment.
7457         * parse.c (parse_exp_1): Add tracker_types parameter.
7458         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7459         tracker_types parameter.  Reset innermost_block.
7460         (parse_exp_in_context): Remove.
7461         (parse_expression_for_completion): Update.
7462         * objfiles.c (~objfile): Don't reset expression_context_block or
7463         innermost_block.
7464         * expression.h (enum innermost_block_tracker_type): Move from
7465         parser-defs.h.
7466         (parse_exp_1): Add tracker_types parameter.
7467         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7468         reset innermost_block.
7469
7470 2019-03-23  Tom Tromey  <tom@tromey.com>
7471
7472         * objfiles.h: Include bcache.h.
7473
7474 2019-03-23  Tom Tromey  <tom@tromey.com>
7475
7476         * linespec.c (get_current_search_block): Use
7477         scoped_restore_current_language.
7478         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7479
7480 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7481             Jiong Wang  <jiong.wang@arm.com>
7482
7483         * aarch64-linux-tdep.c
7484         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7485         section.
7486         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7487
7488 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7489             Jiong Wang  <jiong.wang@arm.com>
7490
7491         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7492         instructions.
7493         (aarch64_analyze_prologue_test): Add PACIASP test.
7494         (aarch64_prologue_prev_register): Unmask PC value.
7495
7496 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7497             Jiong Wang  <jiong.wang@arm.com>
7498
7499         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7500         (aarch64_dwarf2_prev_register): Unmask PC value.
7501         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7502         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7503         DW_CFA_AARCH64_negate_ra_state.
7504         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7505
7506 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7507             Jiong Wang  <jiong.wang@arm.com>
7508
7509         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7510         registers.
7511         (aarch64_pseudo_register_name): Likewise.
7512         (aarch64_pseudo_register_type): Likewise.
7513         (aarch64_pseudo_register_reggroup_p): Likewise.
7514         (aarch64_gdbarch_init): Add pauth registers.
7515         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7516         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7517         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7518         (struct gdbarch_tdep): Add regnum for ra_state.
7519
7520 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7521             Jiong Wang  <jiong.wang@arm.com>
7522
7523         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7524
7525 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7526             Jiong Wang  <jiong.wang@arm.com>
7527
7528         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7529         function.
7530         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7531         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7532         (aarch64_gdbarch_init): Add puth registers.
7533         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7534         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7535         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7536
7537 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7538             Jiong Wang  <jiong.wang@arm.com>
7539
7540         * aarch64-linux-nat.c
7541         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7542         * aarch64-linux-tdep.c
7543         (aarch64_linux_core_read_description): Likewise.
7544         (aarch64_linux_get_hwcap): New function.
7545         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7546         (aarch64_linux_get_hwcap): New declaration.
7547
7548 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7549             Jiong Wang  <jiong.wang@arm.com>
7550
7551         * aarch64-linux-nat.c
7552         (aarch64_linux_nat_target::read_description): Add pauth param.
7553         * aarch64-linux-tdep.c
7554         (aarch64_linux_core_read_description): Likewise.
7555         * aarch64-tdep.c (struct target_desc): Add in pauth.
7556         (aarch64_read_description): Add pauth param.
7557         (aarch64_gdbarch_init): Likewise.
7558         * aarch64-tdep.h (aarch64_read_description): Likewise.
7559         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7560         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7561         * features/Makefile: Add new files.
7562         * features/aarch64-pauth.c: New file.
7563         * features/aarch64-pauth.xml: New file.
7564
7565 2019-03-20  Tom Tromey  <tromey@adacore.com>
7566
7567         * infrun.c (handle_inferior_event): Rename from
7568         handle_inferior_event_1.  Create a scoped_value_mark.
7569         (handle_inferior_event): Remove.
7570
7571 2019-03-19  Tom Tromey  <tromey@adacore.com>
7572
7573         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7574         * infrun.h (print_stop_event): Add "displays" parameter.
7575         * infrun.c (print_stop_event): Add "displays" parameter.
7576
7577 2019-03-19  Pedro Alves  <palves@redhat.com>
7578
7579         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7580         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7581         to -1.  Fix TABs vs spaces.
7582         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7583         * tui/tui-out.h (tui_ui_out) Add intro comments.
7584         <m_line, m_start_of_line>: In-class initialize, and add describing
7585         comment.
7586
7587 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7588
7589         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7590         variable names.
7591         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7592
7593 2019-03-18  Pedro Alves  <palves@redhat.com>
7594             Eli Zaretskii <eliz@gnu.org>
7595
7596         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7597         m_line and m_start_of_line.
7598
7599 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7600
7601         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7602         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7603         it returns a newline.  This fixes a regression in TU mode, whereby
7604         the next line is output on the same screen line as the user input.
7605
7606 2019-03-18  Tom Tromey  <tromey@adacore.com>
7607
7608         * minsyms.c (minimal_symbol_reader::install): Remove call to
7609         obstack_blank.
7610
7611 2019-03-18  Pedro Alves  <palves@redhat.com>
7612
7613         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7614         New globals.
7615         (apply_style): New, factored out from ...
7616         (apply_ansi_escape): ... this.  Handle reverse video mode.
7617         (tui_set_reverse_mode): New function.
7618         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7619         * tui/tui-winsource.c (tui_show_source_line): Use
7620         tui_set_reverse_mode instead of setting A_STANDOUT.
7621         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7622         New setter methods.
7623
7624 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7625
7626         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7627         Handle tabs.
7628
7629 2019-03-18  Tom Tromey  <tromey@adacore.com>
7630
7631         * ada-lang.c (empty_array): Add "high" parameter.
7632         (ada_evaluate_subexp): Update.
7633
7634 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7635
7636         * unittests/string_view-selftests.c: Define
7637         _initialize_string_view_selftests unconditionally.
7638
7639 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7640
7641         PR gdb/24350
7642         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7643
7644 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7645
7646         PR gdb/24351
7647         * windows-nat.c (display_selector): Fix format specifiers.
7648
7649 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7650
7651         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7652         tui_refill_source_window instead of tui_refresh_win, to update the
7653         current execution line.  This fixes redisplay of the current line
7654         when stepping through the code with "next" or "step".
7655
7656 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7657
7658         * source-cache.c (source_cache::get_source_lines): Call
7659         find_source_lines to initialize s->nlines.  This fixes vertical
7660         scrolling of TUI source window when the DOWN arrow is pressed.
7661
7662 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7663
7664         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7665         linux-thread-db.c (_initialize_thread_db): Likewise.
7666
7667 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7668
7669         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7670         wclrtoeol in tui_show_source_line".  This reverts changes made in
7671         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7672
7673 2019-03-15  Tom Tromey  <tom@tromey.com>
7674
7675         * symtab.h (struct minimal_symbol): Derive from
7676         general_symbol_info.
7677         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7678         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7679         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7680         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7681         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7682         (MSYMBOL_SEARCH_NAME): Update.
7683         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7684         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7685         * minsyms.c (minimal_symbol_reader::record_full): Update.
7686
7687 2019-03-15  Tom Tromey  <tom@tromey.com>
7688
7689         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7690
7691 2019-03-15  Tom Tromey  <tom@tromey.com>
7692
7693         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7694         unique_xmalloc_ptr.
7695         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7696         Update.
7697         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7698         (build_minimal_symbol_hash_tables)
7699         (minimal_symbol_reader::install): Update.
7700
7701 2019-03-15  Tom Tromey  <tom@tromey.com>
7702
7703         * symtab.c (create_demangled_names_hash): Update.
7704         (symbol_set_names): Update.
7705         * objfiles.h (struct objfile_per_bfd_storage)
7706         <demangled_names_hash>: Now an htab_up.
7707         * objfiles.c (objfile_per_bfd_storage): Simplify.
7708
7709 2019-03-15  Tom Tromey  <tom@tromey.com>
7710
7711         * objfiles.h (struct objfile_per_bfd_storage): Declare
7712         destructor.
7713         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7714         New.
7715         (get_objfile_bfd_data): Use new.  Don't initialize
7716         language_of_main.
7717         (free_objfile_per_bfd_storage): Remove.
7718         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7719
7720 2019-03-15  Tom Tromey  <tom@tromey.com>
7721
7722         * symfile.c (reread_symbols): Update.
7723         * objfiles.c (objfile::objfile): Update.
7724         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7725         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7726         comment.
7727         (minimal_symbol_reader::install): Update.
7728         (terminate_minimal_symbol_table): Remove.
7729         * jit.c (jit_object_close_impl): Update.
7730
7731 2019-03-15  Tom Tromey  <tom@tromey.com>
7732
7733         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7734         initializations.
7735
7736 2019-03-15  Tom Tromey  <tom@tromey.com>
7737
7738         * objfiles.h (struct objfile_per_bfd_storage)
7739         <demangled_hash_languages>: Now a bitset.
7740         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7741         (lookup_minimal_symbol): Update.
7742
7743 2019-03-15  Tom Tromey  <tom@tromey.com>
7744
7745         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7746         Don't return the symbol.
7747         * coffread.c (record_minimal_symbol): Use record_full.
7748
7749 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7750
7751         The MS-Windows port of ncurses fails to switch to a color pair if
7752         one or both of the colors are the implicit default colors.  This
7753         change records the default colors when TUI is initialized, and
7754         then specifies them explicitly when a color pair uses the default
7755         colors.  This allows color styling in TUI mode on MS-Windows.
7756
7757         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7758         ncurses_norm_attr.
7759         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7760         colors in ncurses_norm_attr.
7761         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7762         "none", replace it with the default color recorded in
7763         ncurses_norm_attr.
7764
7765 2019-03-14  Tom Tromey  <tromey@adacore.com>
7766
7767         * source-cache.h (class source_cache) <get_source_lines>: Return
7768         std::string.
7769         * source-cache.c (source_cache::extract_lines): Handle case where
7770         first_pos==npos.  Return std::string.
7771         (source_cache::get_source_lines): Update.
7772
7773 2019-03-14  Tom Tromey  <tromey@adacore.com>
7774
7775         * NEWS: Add item for "style sources" commands.
7776         * source-cache.c (source_cache::get_source_lines): Check
7777         source_styling.
7778         * cli/cli-style.c (source_styling): New global.
7779         (_initialize_cli_style): Add "style sources" commands.
7780         (show_style_sources): New function.
7781         * cli/cli-style.h (source_styling): Declare.
7782
7783 2019-03-14  Pedro Alves  <palves@redhat.com>
7784             Tom Tromey  <tromey@adacore.com>
7785
7786         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7787         * tui/tui-winsource.c (tui_refill_source_window): New function,
7788         from...
7789         (tui_horizontal_source_scroll): ... here.  Move some logic.
7790         * cli/cli-style.c (set_style_enabled): Notify new observable.
7791         * tui/tui-hooks.c (tui_redisplay_source): New function.
7792         (tui_attach_detach_observers): Attach or detach
7793         tui_redisplay_source.
7794         * observable.h (source_styling_changed): New observable.
7795         * observable.c: Define source_styling_changed observable.
7796
7797 2019-03-13  Tom Tromey  <tromey@adacore.com>
7798
7799         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7800         (i386_gnu_nat_target::store_registers): Update.
7801         * target-debug.h (target_debug_print_std_string): New macro.
7802         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7803         * windows-tdep.c (display_one_tib): Update.
7804         * tui/tui-stack.c (tui_make_status_line): Update.
7805         * top.c (print_inferior_quit_action): Update.
7806         * thread.c (thr_try_catch_cmd): Update.
7807         (add_thread_with_info): Update.
7808         (thread_target_id_str): Update.
7809         (thr_try_catch_cmd): Update.
7810         (thread_command): Update.
7811         (thread_find_command): Update.
7812         * record-btrace.c (record_btrace_target::info_record)
7813         (record_btrace_resume_thread, record_btrace_target::resume)
7814         (record_btrace_cancel_resume, record_btrace_step_thread)
7815         (record_btrace_target::wait, record_btrace_target::wait)
7816         (record_btrace_target::wait, record_btrace_target::stop): Update.
7817         * progspace.c (print_program_space): Update.
7818         * process-stratum-target.c
7819         (process_stratum_target::thread_address_space): Update.
7820         * linux-fork.c (linux_fork_mourn_inferior)
7821         (detach_checkpoint_command, info_checkpoints_command)
7822         (linux_fork_context): Update.
7823         (linux_fork_detach): Update.
7824         (class scoped_switch_fork_info): Update.
7825         (delete_checkpoint_command): Update.
7826         * infrun.c (follow_fork_inferior): Update.
7827         (follow_fork_inferior): Update.
7828         (proceed_after_vfork_done): Update.
7829         (handle_vfork_child_exec_or_exit): Update.
7830         (follow_exec): Update.
7831         (displaced_step_prepare_throw): Update.
7832         (displaced_step_restore): Update.
7833         (start_step_over): Update.
7834         (resume_1): Update.
7835         (clear_proceed_status_thread): Update.
7836         (proceed): Update.
7837         (print_target_wait_results): Update.
7838         (do_target_wait): Update.
7839         (context_switch): Update.
7840         (stop_all_threads): Update.
7841         (restart_threads): Update.
7842         (finish_step_over): Update.
7843         (handle_signal_stop): Update.
7844         (switch_back_to_stepped_thread): Update.
7845         (keep_going_pass_signal): Update.
7846         (print_exited_reason): Update.
7847         (normal_stop): Update.
7848         * inferior.c (inferior_pid_to_str): Change return type.
7849         (print_selected_inferior): Update.
7850         (add_inferior): Update.
7851         (detach_inferior): Update.
7852         * dummy-frame.c (fprint_dummy_frames): Update.
7853         * dcache.c (dcache_info_1): Update.
7854         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7855         (btrace_fetch, btrace_clear): Update.
7856         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7857         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7858         type.
7859         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7860         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7861         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7862         * gdbarch.c, gdbarch.h: Rebuild.
7863         * gdbarch.sh (core_pid_to_str): Change return type.
7864         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7865         return type.
7866         (windows_nat_target::pid_to_str): Change return type.
7867         (windows_delete_thread): Update.
7868         (windows_nat_target::attach): Update.
7869         (windows_nat_target::files_info): Update.
7870         * target-delegates.c: Rebuild.
7871         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7872         return type.
7873         (sol_thread_target::pid_to_str): Change return type.
7874         * remote.c (class remote_target) <pid_to_str>: Change return
7875         type.
7876         (remote_target::pid_to_str): Change return type.
7877         (extended_remote_target::attach, remote_target::remote_stop_ns)
7878         (remote_target::remote_notif_remove_queued_reply)
7879         (remote_target::push_stop_reply, remote_target::disable_btrace):
7880         Update.
7881         (extended_remote_target::attach): Update.
7882         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7883         type.
7884         (gdbsim_target::pid_to_str): Change return type.
7885         * ravenscar-thread.c (struct ravenscar_thread_target)
7886         <pid_to_str>: Change return type.
7887         (ravenscar_thread_target::pid_to_str): Change return type.
7888         * procfs.c (class procfs_target) <pid_to_str>: Change return
7889         type.
7890         (procfs_target::pid_to_str): Change return type.
7891         (procfs_target::attach): Update.
7892         (procfs_target::detach): Update.
7893         (procfs_target::fetch_registers): Update.
7894         (procfs_target::store_registers): Update.
7895         (procfs_target::wait): Update.
7896         (procfs_target::files_info): Update.
7897         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7898         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7899         return type.
7900         (nto_procfs_target::pid_to_str): Change return type.
7901         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7902         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7903         return type.
7904         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7905         (exit_lwp): Update.
7906         (attach_proc_task_lwp_callback, get_detach_signal)
7907         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7908         (linux_nat_target::resume, wait_lwp, stop_callback)
7909         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7910         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7911         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7912         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7913         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7914         type.
7915         (inf_ptrace_target::attach): Update.
7916         (inf_ptrace_target::files_info): Update.
7917         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7918         type.
7919         (go32_nat_target::pid_to_str): Change return type.
7920         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7921         (gnu_nat_target::wait): Update.
7922         (gnu_nat_target::wait): Update.
7923         (gnu_nat_target::resume): Update.
7924         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7925         (fbsd_nat_target::wait): Update.
7926         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7927         type.
7928         (darwin_nat_target::attach): Update.
7929         * corelow.c (class core_target) <pid_to_str>: Change return type.
7930         (core_target::pid_to_str): Change return type.
7931         * target.c (normal_pid_to_str): Change return type.
7932         (default_pid_to_str): Likewise.
7933         (target_pid_to_str): Change return type.
7934         (target_translate_tls_address): Update.
7935         (target_announce_detach): Update.
7936         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7937         return type.
7938         (bsd_uthread_target::pid_to_str): Change return type.
7939         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7940         type.
7941         (bsd_kvm_target::pid_to_str): Change return type.
7942         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7943         return type.
7944         (aix_thread_target::pid_to_str): Change return type.
7945         * target.h (struct target_ops) <pid_to_str>: Change return type.
7946         (target_pid_to_str, normal_pid_to_str): Likewise.
7947         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7948         type.
7949         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7950         type.
7951         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7952         return type.
7953         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7954         type.
7955         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7956         type.
7957         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7958         return type.
7959
7960 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7961
7962         * NEWS: Mention that the new default MI version is 3.  Mention
7963         changes to the output of commands and events that deal with
7964         multi-location breakpoints.
7965         * breakpoint.c: Include "mi/mi-out.h".
7966         (print_one_breakpoint): Change output syntax if using MI version
7967         >= 3.
7968         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7969         New.
7970         (mi_multi_location_breakpoint_output_fixed): New.
7971         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7972         (mi_cmd_fix_multi_location_breakpoint_output): New.
7973         (mi_multi_location_breakpoint_output_fixed): New.
7974         * mi/mi-cmds.c (mi_cmds): Register command
7975         -fix-multi-location-breakpoint-output.
7976         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7977         interpreter "mi".
7978
7979 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7980
7981         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7982         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7983         instantiate mi_ui_out based on interpreter name.
7984         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7985         * mi/mi-main.c (mi_load_progress): Likewise.
7986
7987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7988
7989         * NEWS: Combine separate "New targets" sections for 8.3.
7990
7991 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7992
7993         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7994         (ppcfbsd_init_abi): Install gdbarch
7995         "fetch_tls_load_module_address" and "get_thread_local_address"
7996         methods.
7997
7998 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7999
8000         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8001         (riscv_fbsd_init_abi): Install gdbarch
8002         "fetch_tls_load_module_address" and "get_thread_local_address"
8003         methods.
8004
8005 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8006
8007         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8008         (i386fbsd_init_abi): Install gdbarch
8009         "fetch_tls_load_module_address" and "get_thread_local_address"
8010         methods.
8011
8012 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8013
8014         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8015         (amd64fbsd_init_abi): Install gdbarch
8016         "fetch_tls_load_module_address" and "get_thread_local_address"
8017         methods.
8018
8019 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8020
8021         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8022         (struct fbsd_pspace_data): New type.
8023         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8024         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8025         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8026         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8027         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8028
8029 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8030
8031         * gdbtypes.c (lookup_struct_elt): New function.
8032         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8033         * gdbtypes.h (struct struct_elt): New type.
8034         (lookup_struct_elt): New prototype.
8035
8036 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8037
8038         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8039         remove disabled code block.
8040
8041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8042
8043         * gdbarch.sh (get_thread_local_address): New method.
8044         * gdbarch.h, gdbarch.c: Regenerate.
8045         * target.c (target_translate_tls_address): Use
8046         gdbarch_get_thread_local_address if present instead of
8047         target::get_thread_local_address.
8048
8049 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8050
8051         * target.h (target::get_thread_local_address): Update comment.
8052
8053 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8054
8055         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8056         objfile->separate_debug_objfile_backlink if not NULL.
8057
8058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8059
8060         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8061         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8062         (amd64bsd_store_inferior_registers): Likewise.
8063         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8064         Enable segment base registers.
8065         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8066         PT_GETFSBASE and PT_GETGSBASE.
8067         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8068         PT_SETGSBASE.
8069         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8070         segment base registers.
8071         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8072
8073 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8074
8075         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8076         Update calls to i386_target_description to add 'segments'
8077         parameter.
8078         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8079         add segment base registers.
8080         * arch/i386.c (i386_create_target_description): Add 'segments'
8081         parameter to enable segment base registers.
8082         * arch/i386.h (i386_create_target_description): Likewise.
8083         * features/i386/32bit-segments.xml: New file.
8084         * features/i386/32bit-segments.c: Generate.
8085         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8086         call to i386_target_description to add 'segments' parameter.
8087         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8088         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8089         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8090         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8091         if feature is present.
8092         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8093         Add 'segments' parameter to call to i386_target_description.
8094         (i386_target_description): Add 'segments' parameter to enable
8095         segment base registers.
8096         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8097         to call to i386_target_description.
8098         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8099         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8100         Define I386_NUM_REGS.
8101         (i386_target_description): Add 'segments' parameter to enable
8102         segment base registers.
8103
8104 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8105
8106         PR/24325
8107         * source-cache.c: #undef open and close, to avoid unresolved
8108         externals during linking.
8109
8110 2019-03-12  Tom Tromey  <tromey@adacore.com>
8111
8112         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8113         const.  Add initializers.
8114         (_initialize_remote): Don't initialize ptid globals.
8115
8116 2019-03-12  Pedro Alves  <palves@redhat.com>
8117
8118         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8119
8120 2019-03-12  Pedro Alves  <palves@redhat.com>
8121
8122         * cp-name-parser.y (main): Remove unused 'len' variable.
8123
8124 2019-03-12  Tom Tromey  <tromey@adacore.com>
8125
8126         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8127         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8128
8129 2019-03-12  Tom Tromey  <tromey@adacore.com>
8130
8131         * linux-nat.c (iterate_over_lwps): Update.
8132         (stop_callback): Remove parameter.
8133         (stop_wait_callback, detach_callback, resume_set_callback)
8134         (select_singlestep_lwp_callback, set_ignore_sigint)
8135         (status_callback, resumed_callback, resume_clear_callback)
8136         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8137         data parameter.
8138         (linux_nat_target::detach, linux_nat_target::resume)
8139         (linux_stop_and_wait_all_lwps, select_event_lwp)
8140         (linux_nat_filter_event, linux_nat_wait_1)
8141         (linux_nat_target::kill, linux_nat_target::stop)
8142         (linux_nat_target::stop): Update.
8143         (linux_nat_resume_callback): Change type.
8144         (resume_stopped_resumed_lwps, count_events_callback)
8145         (select_event_lwp_callback): Likewise.
8146         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8147         * arm-linux-nat.c (struct update_registers_data): Remove.
8148         (update_registers_callback): Change type.
8149         (arm_linux_insert_hw_breakpoint1): Update.
8150         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8151         parameter.
8152         (x86_linux_dr_set_addr): Update.
8153         (x86_linux_dr_set_control): Update.
8154         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8155         (iterate_over_lwps): Use gdb::function_view.
8156         * nat/aarch64-linux-hw-point.c (struct
8157         aarch64_dr_update_callback_param): Remove.
8158         (debug_reg_change_callback): Change type.
8159         (aarch64_notify_debug_reg_change): Update.
8160         * s390-linux-nat.c (s390_refresh_per_info): Update.
8161
8162 2019-03-11  Tom Tromey  <tromey@adacore.com>
8163
8164         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8165         redundant assignment to "this_cu".
8166
8167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8168
8169         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8170
8171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8172
8173         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8174         from...
8175         (rank_one_type): ... this.
8176
8177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8178
8179         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8180         from...
8181         (rank_one_type): ... this.
8182
8183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8184
8185         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8186         from...
8187         (rank_one_type): ... this.
8188
8189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8190
8191         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8192         from...
8193         (rank_one_type): ... this.
8194
8195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8196
8197         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8198         from...
8199         (rank_one_type): ... this.
8200
8201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8202
8203         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8204         from...
8205         (rank_one_type): ... this.
8206
8207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8208
8209         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8210         from...
8211         (rank_one_type): ... this.
8212
8213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8214
8215         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8216         from...
8217         (rank_one_type): ... this.
8218
8219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8220
8221         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8222         from...
8223         (rank_one_type): ... this.
8224
8225 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8226
8227         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8228         from...
8229         (rank_one_type): ... this.
8230
8231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8232
8233         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8234         from...
8235         (rank_one_type): ... this.
8236
8237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8238
8239         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8240         from...
8241         (rank_one_type): ... this.
8242
8243 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8244
8245         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8246         inferior-events' shows the example events.
8247
8248 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8249
8250         Support styling on native MS-Windows console
8251
8252         PR/24315
8253         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8254         on MS-Windows if $TERM is not defined.
8255
8256         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8257
8258         * posix-hdep.c (gdb_console_fputs):
8259         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8260         functions.
8261         * ui-file.h (gdb_console_fputs): Add prototype.
8262
8263         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8264         back to fputs only if the former returns zero.
8265
8266 2019-03-07  Tom Tromey  <tom@tromey.com>
8267
8268         * symmisc.c (print_symbol_bcache_statistics): Update.
8269         (print_objfile_statistics): Update.
8270         * symfile.c (allocate_symtab): Update.
8271         * stabsread.c: Don't include bcache.h.
8272         * psymtab.h (struct psymbol_bcache): Don't declare.
8273         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8274         (psymbol_bcache_init, psymbol_bcache_free)
8275         (psymbol_bcache_get_bcache): Don't declare.
8276         * psymtab.c (struct psymbol_bcache): Remove.
8277         (psymtab_storage::psymtab_storage): Update.
8278         (psymtab_storage::~psymtab_storage): Update.
8279         (psymbol_bcache_init, psymbol_bcache_free)
8280         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8281         (add_psymbol_to_bcache): Update.
8282         (allocate_psymtab): Update.
8283         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8284         macro_cache>: No longer pointers.
8285         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8286         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8287         * macrotab.c (macro_bcache): Update.
8288         * macroexp.c: Don't include bcache.h.
8289         * gdbtypes.c (check_types_worklist): Update.
8290         (types_deeply_equal): Remove TRY/CATCH.  Update.
8291         * elfread.c (elf_symtab_read): Update.
8292         * dwarf2read.c: Don't include bcache.h.
8293         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8294         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8295         (print_bcache_statistics, bcache_memory_used): Don't declare.
8296         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8297         methods.  Rename all data members.
8298         * bcache.c (struct bcache): Move to bcache.h.
8299         (bcache::expand_hash_table): Rename from expand_hash_table.
8300         (bcache): Remove.
8301         (bcache::insert): Rename from bcache_full.
8302         (bcache::compare): Rename from bcache_compare.
8303         (bcache_xmalloc): Remove.
8304         (bcache::~bcache): Rename from bcache_xfree.
8305         (bcache::print_statistics): Rename from print_bcache_statistics.
8306         (bcache::memory_used): Rename from bcache_memory_used.
8307
8308 2019-03-07  Pedro Alves  <palves@redhat.com>
8309
8310         * infrun.c (normal_stop): Also check for
8311         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8312
8313 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8314
8315         * f-lang.c (value_from_host_double): Moved to...
8316         * value.c (value_from_host_double): ...here.
8317         * value.h (value_from_host_double): Declare.
8318         * guile/scm-math.c (vlscm_convert_typed_number): Use
8319         value_from_host_double.
8320         (vlscm_convert_number): Likewise.
8321         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8322         * python/py-value.c (convert_value_from_python): Likewise.
8323
8324 2019-03-06  Tom Tromey  <tom@tromey.com>
8325
8326         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8327
8328 2019-03-06  Tom Tromey  <tom@tromey.com>
8329
8330         * utils.h (free_current_contents): Don't declare.
8331         * utils.c (free_current_contents): Remove.
8332
8333 2019-03-06  Tom Tromey  <tom@tromey.com>
8334
8335         * top.c (quit_force): Update.
8336         * main.c (captured_command_loop): Update.
8337         * common/new-op.c (operator new): Update.
8338         * common/common-exceptions.c (struct catcher)
8339         <save_cleanup_chain>: Remove member.
8340         (exceptions_state_mc_init): Update.
8341         (exception_try_scope_entry): Return nullptr.
8342         (exception_try_scope_exit, exception_rethrow)
8343         (throw_exception_sjlj, throw_exception_cxx): Update.
8344         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8345         (all_cleanups, do_cleanups, discard_cleanups)
8346         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8347         (restore_cleanups, restore_final_cleanups): Don't declare.
8348         (do_final_cleanups): Remove parameter.
8349         * common/cleanups.c (cleanup_chain, make_cleanup)
8350         (make_cleanup_dtor, all_cleanups, do_cleanups)
8351         (discard_my_cleanups, discard_cleanups)
8352         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8353         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8354         (null_cleanup): Remove.
8355         (do_final_cleanups): Remove parameter.
8356
8357 2019-03-06  Tom Tromey  <tom@tromey.com>
8358
8359         * remote.c (remote_target::remote_parse_stop_reply): Use
8360         unique_xmalloc_ptr.
8361
8362 2019-03-06  Tom Tromey  <tom@tromey.com>
8363
8364         * stabsread.c (struct stabs_field_info): Rename from field_info.
8365         <list, fnlist>: Add initializers.
8366         <obstack>: New member.
8367         (read_member_functions, read_struct_fields, read_baseclasses):
8368         Allocate on obstack.  Don't use cleanups.
8369         (read_one_struct_field, read_member_functions, read_struct_fields)
8370         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8371         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8372         (read_struct_type): Update.
8373
8374 2019-03-06  Tom Tromey  <tom@tromey.com>
8375
8376         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8377         * common/filestuff.h (make_cleanup_close): Don't declare.
8378         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8379         Remove.
8380
8381 2019-03-06  Tom Tromey  <tom@tromey.com>
8382
8383         * solib-aix.c: Use make_scope_exit.
8384
8385 2019-03-06  Tom Tromey  <tom@tromey.com>
8386
8387         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8388         Use make_scope_exit.
8389
8390 2019-03-06  Tom Tromey  <tom@tromey.com>
8391
8392         * solib-svr4.c (disable_probes_interface): Remove parameter.
8393         (svr4_handle_solib_event): Use make_scope_exit.
8394
8395 2019-03-06  Tom Tromey  <tom@tromey.com>
8396
8397         * remote.c (struct stop_reply_deleter): Remove.
8398         (stop_reply_up): Update.
8399         (struct stop_reply): Derive from notif_event.  Don't typedef.
8400         <regcache>: Now a std::vector.
8401         (stop_reply_xfree): Remove.
8402         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8403         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8404         (remote_target::discard_pending_stop_replies): Use delete.
8405         (remote_target::remote_parse_stop_reply): Update.
8406         (remote_target::process_stop_reply): Update.
8407         * remote-notif.h (struct notif_event): Add virtual destructor.
8408         Remove "dtr" member.
8409         (struct notif_client) <alloc_event>: Return a unique_ptr.
8410         (notif_event_xfree): Don't declare.
8411         (notif_event_up): New typedef.
8412         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8413         (notif_event_xfree, do_notif_event_xfree): Remove.
8414         (remote_notif_state_xfree): Update.
8415
8416 2019-03-06  Tom Tromey  <tom@tromey.com>
8417
8418         * infrun.c (displaced_step_clear_cleanup): Now a
8419         forward_scope_exit type.
8420         (displaced_step_prepare_throw): Update.
8421         (displaced_step_fixup): Update.
8422
8423 2019-03-06  Tom Tromey  <tom@tromey.com>
8424
8425         * inferior.h (class inferior): Update comment.
8426         * gdbthread.h (class thread_info): Update comment.
8427
8428 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8429             Tom Tromey  <tom@tromey.com>
8430
8431         * stabsread.h (struct stab_section_list): Remove.
8432         (coffstab_build_psymtabs): Update.
8433         * dbxread.c (symbuf_sections): Now a std::vector.
8434         (sect_idx): New global.
8435         (fill_symbuf): Update.
8436         (coffstab_build_psymtabs): Change type of stabsects parameter.
8437         Update.
8438         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8439         std::vector.
8440         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8441         (coff_locate_sections): Update.
8442         (coff_symfile_read): Remove cleanups.  Update.
8443         (init_stringtab): Add storage parameter.
8444         (free_stringtab, free_stringtab_cleanup): Remove.
8445         (init_lineno): Add storage parameter.
8446         (free_linetab, free_linetab_cleanup): Remove.
8447
8448 2019-03-06  Pedro Alves  <palves@redhat.com>
8449
8450         * linux-fork.c (fork_info::clobber_regs): Delete.
8451         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8452         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8453         comment.  Adjust.
8454         (scoped_switch_fork_info::scoped_switch_fork_info)
8455         (checkpoint_command, linux_fork_context): Adjust
8456         fork_save_infrun_state calls.
8457
8458 2019-03-06  Pedro Alves  <palves@redhat.com>
8459
8460         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8461         (inf_has_multiple_threads): Return 'bool' and rewrite using
8462         inferior_info::threads().
8463
8464 2019-03-06  Pedro Alves  <palves@redhat.com>
8465
8466         * linux-fork.c: Include <list>.
8467         (fork_list): Now a std::list instance.
8468         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8469         (forks_exist_p, find_last_fork): Adjust.
8470         (new_fork): Delete.
8471         (one_fork_p): New.
8472         (add_fork): Adjust.
8473         (free_fork): Delete, folded into fork_info::~fork_info().
8474         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8475         Adjust.
8476         (init_fork_list): Delete.
8477         (linux_fork_killall, linux_fork_mourn_inferior)
8478         (linux_fork_detach, info_checkpoints_command): Adjust.
8479         (_initialize_linux_fork): No longer call init_fork_list.
8480
8481 2019-03-06  Pedro Alves  <palves@redhat.com>
8482
8483         * linux-fork.c (new_fork): New, split out of ...
8484         (add_fork): ... this.  Return void.  Move "first fork" special
8485         case from here, to ...
8486         (checkpoint_command): ... here.
8487         * linux-linux.h (add_fork): Return void.
8488
8489 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8490
8491         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8492
8493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8494             Chris January  <chris.january@arm.com>
8495             David Lecomber  <david.lecomber@arm.com>
8496
8497         * f-exp.y: New token, UNOP_INTRINSIC.
8498         (exp): New pattern using UNOP_INTRINSIC token.
8499         (f77_keywords): Add 'abs' keyword.
8500         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8501         (value_from_host_double): New function.
8502         (evaluate_subexp_f): Support UNOP_ABS.
8503
8504 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8505
8506         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8507         types.
8508
8509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8510
8511         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8512         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8513         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8514
8515 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8516
8517         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8518
8519 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8520             Chris January  <chris.january@arm.com>
8521
8522         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8523         * f-exp.y: Define 'KIND' token.
8524         (exp): New pattern for KIND expressions.
8525         (ptype): Handle types with a kind extension.
8526         (direct_abs_decl): Extend to spot kind extensions.
8527         (f77_keywords): Add 'kind' to the list.
8528         (push_kind_type): New function.
8529         (convert_to_kind_type): New function.
8530         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8531         * parse.c (operator_length_standard): Likewise.
8532         * parser-defs.h (enum type_pieces): Add tp_kind.
8533         * std-operator.def: Add UNOP_KIND.
8534
8535 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8536
8537         * f-exp.y (f_parse): Set yydebug.
8538
8539 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8540
8541         * f-lang.c (evaluate_subexp_f): New function.
8542         (exp_descriptor_f): New global.
8543         (f_language_defn): Use exp_descriptor_f instead of
8544         exp_descriptor_standard.
8545
8546 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8547
8548         * f-exp.y (struct token): Add comments.
8549         (dot_ops): Remove uppercase versions and the end marker.
8550         (f77_keywords): Likewise.
8551         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8552         entries in the dot_ops array are case insensitive, and use
8553         strncasecmp to compare strings.  Also some whitespace cleanup in
8554         this area.  Similar for the f77_keywords array, except entries in
8555         this list might be case sensitive.
8556
8557 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8558
8559         * f-exp.y (struct f77_boolean_val): Add comments.
8560         (boolean_values): Remove uppercase versions, and end marker.
8561         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8562         and use strncasecmp to achieve case insensitivity.  Additionally,
8563         perform whitespace cleanup around this code.
8564
8565 2019-03-06  Tom Tromey  <tromey@adacore.com>
8566
8567         * remote-sim.c (gdbsim_target_open): Use result of
8568         gdb_argv::release.
8569
8570 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8571         Dirk Schubert  <dirk.schubert@arm.com>
8572         Chris January  <chris.january@arm.com>
8573
8574         * eval.c (evaluate_subexp_standard): Call Fortran argument
8575         wrapping logic.
8576         * f-lang.c (struct value): A value which can be passed into a
8577         Fortran function call.
8578         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8579         where appropriate.
8580         (struct type): Value ready for a Fortran function call.
8581         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8582         is needed.
8583         * f-lang.h (fortran_argument_convert): Declaration.
8584         (fortran_preserve_arg_pointer): Declaration.
8585         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8586
8587 2019-03-05  Tom Tromey  <tromey@adacore.com>
8588
8589         * python/py-prettyprint.c (print_string_repr): Remove #if.
8590         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8591
8592 2019-03-05  Tom Tromey  <tromey@adacore.com>
8593
8594         * target.c (the_dummy_target): Move later.  Change type to
8595         "dummy_target".
8596         (initialize_targets): Don't initialize the_dummy_target.
8597
8598 2019-03-05  Tom Tromey  <tromey@adacore.com>
8599
8600         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8601         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8602
8603 2019-03-05  Tom Tromey  <tromey@adacore.com>
8604
8605         * windows-nat.c (windows_nat_target::attach)
8606         (windows_nat_target::detach): Don't call gdb_flush.
8607         * valprint.c (generic_val_print, val_print, val_print_string):
8608         Don't call gdb_flush.
8609         * utils.c (defaulted_query): Don't call gdb_flush.
8610         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8611         * target.c (target_announce_detach): Don't call gdb_flush.
8612         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8613         * remote.c (extended_remote_target::attach): Don't call
8614         gdb_flush.
8615         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8616         * printcmd.c (do_examine): Don't call gdb_flush.
8617         (info_display_command): Don't call gdb_flush.
8618         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8619         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8620         * memattr.c (info_mem_command): Don't call gdb_flush.
8621         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8622         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8623         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8624         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8625         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8626         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8627         (gnu_nat_target::detach): Don't call gdb_flush.
8628         * f-valprint.c (f_val_print): Don't call gdb_flush.
8629         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8630         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8631         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8632         gdb_flush.
8633         * c-valprint.c (c_val_print): Don't call gdb_flush.
8634         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8635
8636 2019-03-05  Tom Tromey  <tromey@adacore.com>
8637
8638         * varobj.c (update_dynamic_varobj_children): Update.
8639         (install_default_visualizer): Use reset, not release.
8640         * value.c (set_internalvar): Update.
8641         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8642         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8643         ATTRIBUTE_UNUSED_RESULT.
8644
8645 2019-03-05  Tom Tromey  <tromey@adacore.com>
8646
8647         * remote.c (class scoped_remote_fd) <release>: Add
8648         ATTRIBUTE_UNUSED_RESULT.
8649
8650 2019-03-05  Tom Tromey  <tromey@adacore.com>
8651
8652         * macroexp.c (struct macro_buffer) <release>: Add
8653         ATTRIBUTE_UNUSED_RESULT.
8654
8655 2019-03-05  Tom Tromey  <tromey@adacore.com>
8656
8657         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8658         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8659         ATTRIBUTE_UNUSED_RESULT.
8660
8661 2019-03-05  Tom Tromey  <tromey@adacore.com>
8662
8663         * common/scoped_fd.h (class scoped_fd) <release>: Add
8664         ATTRIBUTE_UNUSED_RESULT.
8665
8666 2019-03-05  Tom Tromey  <tromey@adacore.com>
8667
8668         * parser-defs.h (struct parser_state) <release>: Add
8669         ATTRIBUTE_UNUSED_RESULT.
8670
8671 2019-03-05  Tom Tromey  <tromey@adacore.com>
8672
8673         * utils.h (class gdb_argv) <release>: Add
8674         ATTRIBUTE_UNUSED_RESULT.
8675         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8676
8677 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8678
8679         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8680         for-loop range, to avoid compiler warnings.
8681
8682         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8683         avoid compiler warnings about unused variables.
8684
8685         * NEWS: Mention end of support for native debugging on MS-Windows
8686         before XP.
8687
8688         PR gdb/24292
8689         * common/netstuff.c:
8690         * gdbserver/gdbreplay.c
8691         * gdbserver/remote-utils.c:
8692         * ser-tcp.c:
8693         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8694         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8695         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8696         'getaddrinfo' and 'freeaddrinfo' were not available before
8697         Windows XP, and mingw.org's MinGW headers by default define
8698         _WIN32_WINNT to 0x500.
8699
8700 2019-03-01  Gary Benson <gbenson@redhat.com>
8701
8702         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8703
8704 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8705             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8706
8707         PR gdb/8527
8708         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8709         set_sigint_trap, clear_sigint_trap.
8710
8711 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8712
8713         * target.c (target_detach): Clear the regcache and the
8714         frame cache.
8715
8716 2019-02-27  Pedro Alves  <palves@redhat.com>
8717
8718         * utils.c (set_screen_size): When we cap the height/width sizes,
8719         tweak the corresponding command variable to show "unlimited":
8720
8721 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8722             Pedro Alves  <palves@redhat.com>
8723
8724         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8725         before calling rl_set_screen_size.
8726
8727 2019-02-27  Tom Tromey  <tromey@adacore.com>
8728
8729         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8730         define.
8731         * python/py-value.c: Remove Python 2.4 workaround.
8732         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8733         workaround.
8734         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8735         Python 2.4 workaround.
8736         * python/python-internal.h: Remove Python 2.4 comment.
8737         (Py_ssize_t): Don't define.
8738         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8739         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8740         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8741         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8742         * python/python.c (do_start_initialization): Remove Python 2.4
8743         workaround.
8744         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8745         (print_children): Remove Python 2.4 workaround.
8746         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8747         workaround.
8748         (CHARBUFFERPROC_NAME): Remove.
8749         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8750         Python 2.4 workaround.
8751
8752 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8753
8754         * NEWS: Note minimum Python version.
8755
8756 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8757
8758         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8759         code from these functions.  Remove corresponding ifdefs.  Use
8760         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8761         Remove gotos and target of gotos.
8762         (infpy_search_memory): Likewise.
8763
8764 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8765
8766         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8767         (hppa_gdbarch_init): Don't register deleted functions with
8768         gdbarch.
8769
8770 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8771
8772         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8773         (h8300_unwind_sp): Delete.
8774         (h8300_dummy_id): Delete.
8775         (h8300_gdbarch_init): Don't register deleted functions with
8776         gdbarch.
8777
8778 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8779
8780         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8781         (ft32_unwind_pc): Delete.
8782         (ft32_unwind_sp): Delete.
8783         (ft32_gdbarch_init): Don't register deleted functions with
8784         gdbarch.
8785
8786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8787
8788         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8789         (frv_unwind_pc): Delete.
8790         (frv_unwind_sp): Delete.
8791         (frv_gdbarch_init): Don't register deleted functions with
8792         gdbarch.
8793
8794 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8795
8796         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8797         (riscv_unwind_pc): Delete.
8798         (riscv_unwind_sp): Delete.
8799         (riscv_gdbarch_init): Don't register deleted functions with
8800         gdbarch.
8801
8802 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8803
8804         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8805         (csky_unwind_pc): Delete.
8806         (csky_unwind_sp): Delete.
8807         (csky_gdbarch_init): Don't register deleted functions with
8808         gdbarch.
8809
8810 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8811
8812         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8813         (cris_unwind_pc): Delete.
8814         (cris_unwind_sp): Delete.
8815         (cris_gdbarch_init): Don't register deleted functions with
8816         gdbarch.
8817
8818 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8819
8820         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8821         (bfin_unwind_pc): Delete.
8822         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8823
8824 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8825
8826         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8827         (arm_unwind_pc): Delete.
8828         (arm_unwind_sp): Delete.
8829         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8830
8831 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8832
8833         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8834         (arc_unwind_pc): Delete.
8835         (arc_unwind_sp): Delete.
8836         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8837
8838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8839
8840         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8841         (alpha_unwind_pc): Delete.
8842         (alpha_gdbarch_init): Don't register deleted functions with
8843         gdbarch.
8844
8845 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8846
8847         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8848         (aarch64_unwind_pc): Delete.
8849         (aarch64_unwind_sp): Delete.
8850         (aarch64_gdbarch_init): Don't register deleted functions with
8851         gdbarch.
8852
8853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8854
8855         * gdbtypes.c (type_align): Don't consider static members when
8856         computing structure alignment.
8857
8858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8859
8860         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8861         return 0 for other types.
8862         * arch-utils.c (default_type_align): Always return 0.
8863         * gdbarch.h: Regenerate.
8864         * gdbarch.sh (type_align): Extend comment.
8865         * gdbtypes.c (type_align): Add additional comments, always call
8866         gdbarch_type_align before applying the default rules.
8867         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8868         generic code will then apply a suitable default.
8869         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8870         types, return 0 for other types.
8871
8872 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8873
8874         * NEWS: Create a new section for the next release branch.
8875         Rename the section of the current branch, now that it has
8876         been cut.
8877
8878 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8879
8880         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8881         * version.in: Bump version to 8.3.50.DATE-git.
8882
8883 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8884
8885         * aix-thread.c (ptid_cmp): Remove unused variable.
8886         (get_signaled_thread): Likewise.
8887         (store_regs_user_thread): Likewise.
8888         (store_regs_kernel_thread): Likewise.
8889         (fetch_regs_kernel_thread): Remove shadowed variable.
8890
8891 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8892
8893         * features/riscv/32bit-cpu.xml: Add register numbers.
8894         * features/riscv/32bit-fpu.c: Regenerate.
8895         * features/riscv/32bit-fpu.xml: Add register numbers.
8896         * features/riscv/64bit-cpu.xml: Add register numbers.
8897         * features/riscv/64bit-fpu.c: Regenerate.
8898         * features/riscv/64bit-fpu.xml: Add register numbers.
8899
8900 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8901
8902         * NEWS: Mention two argument form of gdb.Value constructor.
8903         * python/py-value.c (convert_buffer_and_type_to_value): New
8904         function.
8905         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8906         Add support for handling an optional second argument.  Call
8907         convert_buffer_and_type_to_value as appropriate.
8908         * python/python-internal.h (Py_buffer_deleter): New struct.
8909         (Py_buffer_up): New typedef.
8910
8911 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8912
8913         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8914         instead of releasing ownership.
8915
8916 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8917
8918         * dwarf2read.c (open_and_init_dwp_file): Call
8919         elf_numsections instead of bfd_count_sections to initialize
8920         dwp_file->num_sections.
8921
8922 2019-02-25  Tom Tromey  <tromey@adacore.com>
8923
8924         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8925
8926 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8927
8928         * gcore.in: Add '--readnever' option when invoking GDB.
8929
8930 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8931
8932         * MAINTAINERS: Update my email address.
8933
8934 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8935
8936         * build-id.c (build_id_to_debug_bfd_1): New function.
8937         (build_id_to_debug_bfd): Look for separate debug file in
8938         sysroot.
8939
8940 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8941
8942         * gdbarch.sh: Update the copyright year range that is placed into
8943         generated files.
8944
8945 2019-02-22  Keith Seitz  <keiths@redhat.com>
8946
8947         PR symtab/23853
8948         * linespec.c (create_sals_line_offset): Search for the default
8949         symtab's filename instead of its fullname.
8950
8951 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8952
8953         * NEWS: Update style defaults.
8954
8955 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8956
8957         * main.c (captured_main_1): Disable styling in batch mode.
8958
8959 2019-02-20  Tom Tromey  <tom@tromey.com>
8960
8961         * symtab.c (symtab_symbol_info): Fix typos.
8962
8963 2019-02-20  Tom Tromey  <tromey@adacore.com>
8964
8965         * findcmd.c (_initialize_mem_search): Use upper case for
8966         metasyntactic variables.
8967
8968 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8969
8970         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8971         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8972
8973 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8974
8975         * top.h (source_file_name): Change to std::string.
8976         * top.c (source_file_name): Likewise.
8977         (command_line_input): Adjust.
8978         * cli/cli-script.c (script_from_file): Adjust.
8979
8980 2019-02-19  Tom Tromey  <tromey@adacore.com>
8981
8982         * ravenscar-thread.c
8983         (ravenscar_thread_target::update_thread_list): Don't call
8984         ada_build_task_list.
8985         * ada-lang.h (ada_build_task_list): Don't declare.
8986         * ada-tasks.c (struct ada_tasks_inferior_data)
8987         <task_list_valid_p>: Now bool.
8988         (read_known_tasks, ada_task_list_changed)
8989         (ada_tasks_invalidate_inferior_data): Update.
8990         (read_known_tasks_array): Return bool.
8991         (read_known_tasks_list): Likewise.
8992         (read_known_tasks): Return void.
8993         (ada_build_task_list): Now static.
8994
8995 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8996
8997         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8998         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8999
9000 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9001
9002         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9003         variant for ada_tasks_pspace_data_handle and
9004         ada_tasks_inferior_data_handle.
9005         (ada_tasks_pspace_data_cleanup): New function.
9006         (ada_tasks_inferior_data_cleanup): New function.
9007
9008 2019-02-17  Tom Tromey  <tom@tromey.com>
9009
9010         * macrotab.h (macro_source_fullname): Return a std::string.
9011         * macrotab.c (macro_include, check_for_redefinition)
9012         (macro_undef, macro_lookup_definition, foreach_macro)
9013         (foreach_macro_in_scope): Update.
9014         (macro_source_fullname): Return a std::string.
9015         * macrocmd.c (show_pp_source_pos): Update.
9016
9017 2019-02-17  Tom Tromey  <tom@tromey.com>
9018
9019         * macrocmd.c (show_pp_source_pos): Style the file names.
9020
9021 2019-02-17  Tom Tromey  <tom@tromey.com>
9022
9023         PR tui/24197:
9024         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9025
9026 2019-02-17  Tom Tromey  <tom@tromey.com>
9027
9028         * ada-lang.c (user_select_syms): Use filtered printing.
9029         * utils.c (wrap_style): New global.
9030         (desired_style): Remove.
9031         (emit_style_escape): Add stream parameter.
9032         (set_output_style, reset_terminal_style, prompt_for_continue):
9033         Update.
9034         (flush_wrap_buffer): Only flush gdb_stdout.
9035         (wrap_here): Set wrap_style.
9036         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9037         treat escape sequences as a character.  Change when wrap buffer is
9038         flushed.
9039         (fputs_styled): Do not set the output style when the default is
9040         requested.
9041         * ui-style.h (struct ui_file_style) <is_default>: New method.
9042         * source.c (print_source_lines_base): Emit escape sequences in one
9043         piece.
9044
9045 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9046
9047         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9048         integers and enumeration types.
9049
9050 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9051
9052         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9053         instead of lookup_symbol_in_language
9054         (do_exact_match): New function.
9055         (ada_get_symbol_name_matcher): Return do_exact_match when
9056         doing a verbatim match.
9057
9058 2019-02-15  Tom Tromey  <tromey@adacore.com>
9059
9060         * ravenscar-thread.c (ravenscar_thread_target::resume)
9061         (ravenscar_thread_target::wait): Special case wildcard requests.
9062
9063 2019-02-15  Tom Tromey  <tromey@adacore.com>
9064
9065         * ravenscar-thread.c (base_ptid): Remove.
9066         (struct ravenscar_thread_target) <close>: New method.
9067         <m_base_ptid>: New member.
9068         <update_inferior_ptid, active_task, task_is_currently_active,
9069         runtime_initialized>: Declare methods.
9070         <ravenscar_thread_target>: Add constructor.
9071         (ravenscar_thread_target::task_is_currently_active)
9072         (ravenscar_thread_target::update_inferior_ptid)
9073         (ravenscar_runtime_initialized): Rename.  Now methods.
9074         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9075         (ravenscar_thread_target::update_thread_list): Update.
9076         (ravenscar_thread_target::active_task): Now method.
9077         (ravenscar_thread_target::store_registers)
9078         (ravenscar_thread_target::prepare_to_store)
9079         (ravenscar_thread_target::prepare_to_store)
9080         (ravenscar_thread_target::mourn_inferior): Update.
9081         (ravenscar_inferior_created): Use "new" to create target.
9082         (ravenscar_thread_target::get_ada_task_ptid): Update.
9083         (_initialize_ravenscar): Don't initialize base_ptid.
9084         (ravenscar_ops): Remove global.
9085
9086 2019-02-15  Tom Tromey  <tromey@adacore.com>
9087
9088         * target.h (push_target): Declare new overload.
9089         * target.c (push_target): New overload, taking an rvalue reference.
9090         * remote.c (remote_target::open_1): Use push_target overload.
9091         * corelow.c (core_target_open): Use push_target overload.
9092
9093 2019-02-15  Tom Tromey  <tromey@adacore.com>
9094
9095         * ravenscar-thread.c (is_ravenscar_task)
9096         (ravenscar_task_is_currently_active): Return bool.
9097         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9098         (_initialize_ravenscar): Remove "(void)".
9099         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9100         Return bool.
9101
9102 2019-02-15  Tom Tromey  <tromey@adacore.com>
9103
9104         * ravenscar-thread.c (ravenscar_runtime_initializer)
9105         (has_ravenscar_runtime, get_running_thread_id)
9106         (ravenscar_thread_target::resume): Fix indentation.
9107
9108 2019-02-15  Tom Tromey  <tromey@adacore.com>
9109
9110         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9111         from ravenscar_arch_ops.
9112         (sparc_ravenscar_ops::fetch_registers)
9113         (sparc_ravenscar_ops::store_registers): Now methods.
9114         (sparc_ravenscar_prepare_to_store): Remove.
9115         (sparc_ravenscar_ops): Redefine.
9116         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9117         methods and destructor.  Remove members.
9118         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9119         (ravenscar_thread_target::store_registers)
9120         (ravenscar_thread_target::prepare_to_store): Update.
9121         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9122         Remove.
9123         (struct ppc_ravenscar_powerpc_ops): Derive from
9124         ravenscar_arch_ops.
9125         (ppc_ravenscar_powerpc_ops::fetch_registers)
9126         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9127         (ppc_ravenscar_powerpc_ops): Redefine.
9128         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9129         (ppc_ravenscar_e500_ops::fetch_registers)
9130         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9131         (ppc_ravenscar_e500_ops): Redefine.
9132         * aarch64-ravenscar-thread.c
9133         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9134         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9135         (aarch64_ravenscar_fetch_registers)
9136         (aarch64_ravenscar_store_registers): Now methods.
9137         (aarch64_ravenscar_ops): Redefine.
9138
9139 2019-02-15  Tom Tromey  <tromey@adacore.com>
9140
9141         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9142         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9143         (ravenscar_thread_target::stopped_by_watchpoint)
9144         (ravenscar_thread_target::stopped_data_address)
9145         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9146
9147 2019-02-15  Tom Tromey  <tromey@adacore.com>
9148
9149         * ravenscar-thread.c: Fix some typos.
9150
9151 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9152             Tom Tromey  <tromey@adacore.com>
9153
9154         * ada-lang.c (ada_exception_sal): Change addr_string to a
9155         std::string.
9156         (create_ada_exception_catchpoint): Update.
9157
9158 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9159             Tom Tromey  <tromey@adacore.com>
9160
9161         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9162         (bp_location_ops): Remove.
9163         (base_breakpoint_allocate_location): Update.
9164         (free_bp_location): Update.
9165         * ada-lang.c (class ada_catchpoint_location)
9166         <ada_catchpoint_location>: Remove ops parameter.
9167         (ada_catchpoint_location_dtor): Remove.
9168         (ada_catchpoint_location_ops): Remove.
9169         (allocate_location_exception): Update.
9170         * breakpoint.h (struct bp_location_ops): Remove.
9171         (class bp_location) <bp_location>: Remove bp_location_ops
9172         parameter.
9173         <~bp_location>: Add destructor.
9174         <ops>: Remove.
9175
9176 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9177             Pedro Alves  <palves@redhat.com>
9178
9179         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9180         'PATH_MAX'.
9181
9182 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9183             Samuel Thibault  <samuel.thibault@gnu.org>
9184             Thomas Schwinge  <thomas@codesourcery.com>
9185
9186         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9187         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9188
9189 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9190
9191         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9192         (check_empty): Use "const char *".
9193
9194         * gnu-nat.c (gnu_nat_target::detach): Instead of
9195         'detach_inferior (pid)' call
9196         'detach_inferior (find_inferior_pid (pid))'.
9197
9198         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9199         'nat/fork-inferior.o'.
9200         * gnu-nat.c: #include "nat/fork-inferior.h".
9201
9202         * gnu-nat.c (gnu_nat_target::detach): Instead of
9203         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9204         * gnu-nat.h: #include "inf-child.h".
9205         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9206         'i386_gnu_nat_target::fetch_registers'.
9207         (gnu_store_registers): Rename/move to
9208         'i386_gnu_nat_target::store_registers'.
9209
9210         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9211         * gnu-nat.h (mach_thread_info): New function.
9212         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9213
9214         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9215
9216 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9217
9218         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9219
9220 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9221
9222         * windows-nat.c (windows_add_thread): Add new parameter
9223         "main_thread_p" with default value set to false.  Update
9224         function documentation as well as all callers.
9225         (windows_delete_thread): Likewise.
9226         (fake_create_process): Update call to windows_add_thread.
9227         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9228         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9229         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9230         call to windows_delete_thread.
9231
9232 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9233
9234         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9235
9236 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9237
9238         * symfile.c (find_separate_debug_file): Use canonical path of
9239         sysroot with child_path instead of gdb_sysroot if it is valid.
9240
9241 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9242
9243         * symfile.c (find_separate_debug_file): Use child_path to
9244         determine if an object file is under a sysroot.
9245
9246 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9247
9248         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9249         unittests/child-path-selftests.c.
9250         * common/pathstuff.c (child_path): New function.
9251         * common/pathstuff.h (child_path): New prototype.
9252         * unittests/child-path-selftests.c: New file.
9253
9254 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9255
9256         * symfile.c (find_separate_debug_file): Look for separate debug
9257         files in debug directories under the sysroot.
9258
9259 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9260
9261         * symtab.h (struct minimal_symbol data_p): New const method.
9262         (struct minimal_symbol text_p): Likewise.
9263         * symtab.c (output_source_filename): Use file name style
9264         to print file name.
9265         (print_symbol_info): Likewise.
9266         (print_msymbol_info): Use address style to print addresses.
9267         Use function name style to print executable text symbols.
9268         (expand_symtab_containing_pc): Use data_p.
9269         (find_pc_sect_compunit_symtab): Likewise.
9270
9271 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9272
9273         * breakpoint.c (describe_other_breakpoints): Use address style
9274         to print addresses.
9275         (say_where): Likewise.
9276
9277 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9278
9279         * ada-typeprint.c (print_func_type): Print function name
9280         style to print function name.
9281         * c-typeprint.c (c_print_type_1): Likewise.
9282
9283 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9284
9285         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9286         for execve.
9287
9288 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9289
9290         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9291         type_stack.
9292
9293 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9294
9295         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9296         TYPE_CODE_REF types.
9297
9298 2019-02-08  Jim Wilson  <jimw@sifive.com>
9299
9300         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9301         (riscv_linux_fregset): New.
9302         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9303
9304 2019-02-07  Tom Tromey  <tom@tromey.com>
9305
9306         * thread.c (thread_cancel_execution_command): Update.
9307         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9308         methods.
9309         (struct thread_fsm_ops): Remove.
9310         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9311         (thread_fsm_should_stop, thread_fsm_return_value)
9312         (thread_fsm_set_finished, thread_fsm_finished_p)
9313         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9314         Don't declare.
9315         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9316         * infrun.c (clear_proceed_status_thread)
9317         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9318         (print_stop_event): Update.
9319         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9320         Add constructor.
9321         (step_command_fsm_ops): Remove.
9322         (new_step_command_fsm): Remove.
9323         (step_1): Update.
9324         (step_command_fsm::should_stop): Rename from
9325         step_command_fsm_should_stop.
9326         (step_command_fsm::clean_up): Rename from
9327         step_command_fsm_clean_up.
9328         (step_command_fsm::do_async_reply_reason): Rename from
9329         step_command_fsm_async_reply_reason.
9330         (struct until_next_fsm): Inherit from thread_fsm.  Add
9331         constructor.
9332         (until_next_fsm_ops): Remove.
9333         (new_until_next_fsm): Remove.
9334         (until_next_fsm::should_stop): Rename from
9335         until_next_fsm_should_stop.
9336         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9337         (until_next_fsm::do_async_reply_reason): Rename from
9338         until_next_fsm_async_reply_reason.
9339         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9340         constructor.  Change type of breakpoint.
9341         (finish_command_fsm_ops): Remove.
9342         (new_finish_command_fsm): Remove.
9343         (finish_command_fsm::should_stop): Rename from
9344         finish_command_fsm_should_stop.
9345         (finish_command_fsm::clean_up): Rename from
9346         finish_command_fsm_clean_up.
9347         (finish_command_fsm::return_value): Rename from
9348         finish_command_fsm_return_value.
9349         (finish_command_fsm::do_async_reply_reason): Rename from
9350         finish_command_fsm_async_reply_reason.
9351         (finish_command): Update.
9352         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9353         Add constructor.
9354         (call_thread_fsm_ops): Remove.
9355         (call_thread_fsm::call_thread_fsm): Rename from
9356         new_call_thread_fsm.
9357         (call_thread_fsm::should_stop): Rename from
9358         call_thread_fsm_should_stop.
9359         (call_thread_fsm::should_notify_stop): Rename from
9360         call_thread_fsm_should_notify_stop.
9361         (run_inferior_call, call_function_by_hand_dummy): Update.
9362         * cli/cli-interp.c (should_print_stop_to_console): Update.
9363         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9364         Add constructor.  Change type of location_breakpoint,
9365         caller_breakpoint.
9366         (until_break_fsm_ops): Remove.
9367         (new_until_break_fsm): Remove.
9368         (until_break_fsm::should_stop): Rename from
9369         until_break_fsm_should_stop.
9370         (until_break_fsm::clean_up): Rename from
9371         until_break_fsm_clean_up.
9372         (until_break_fsm::do_async_reply_reason): Rename from
9373         until_break_fsm_async_reply_reason.
9374         (until_break_command): Update.
9375         * thread-fsm.c: Remove.
9376         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9377
9378 2019-02-07  Tom Tromey  <tom@tromey.com>
9379
9380         * yy-remap.h: Add include guard.
9381         * xtensa-tdep.h: Add include guard.
9382         * xcoffread.h: Rename include guard.
9383         * varobj-iter.h: Add include guard.
9384         * tui/tui.h: Rename include guard.
9385         * tui/tui-winsource.h: Rename include guard.
9386         * tui/tui-wingeneral.h: Rename include guard.
9387         * tui/tui-windata.h: Rename include guard.
9388         * tui/tui-win.h: Rename include guard.
9389         * tui/tui-stack.h: Rename include guard.
9390         * tui/tui-source.h: Rename include guard.
9391         * tui/tui-regs.h: Rename include guard.
9392         * tui/tui-out.h: Rename include guard.
9393         * tui/tui-layout.h: Rename include guard.
9394         * tui/tui-io.h: Rename include guard.
9395         * tui/tui-hooks.h: Rename include guard.
9396         * tui/tui-file.h: Rename include guard.
9397         * tui/tui-disasm.h: Rename include guard.
9398         * tui/tui-data.h: Rename include guard.
9399         * tui/tui-command.h: Rename include guard.
9400         * tic6x-tdep.h: Add include guard.
9401         * target/waitstatus.h: Rename include guard.
9402         * target/wait.h: Rename include guard.
9403         * target/target.h: Rename include guard.
9404         * target/resume.h: Rename include guard.
9405         * target-float.h: Rename include guard.
9406         * stabsread.h: Add include guard.
9407         * rs6000-tdep.h: Add include guard.
9408         * riscv-fbsd-tdep.h: Add include guard.
9409         * regformats/regdef.h: Rename include guard.
9410         * record.h: Rename include guard.
9411         * python/python.h: Rename include guard.
9412         * python/python-internal.h: Rename include guard.
9413         * python/py-stopevent.h: Rename include guard.
9414         * python/py-ref.h: Rename include guard.
9415         * python/py-record.h: Rename include guard.
9416         * python/py-record-full.h: Rename include guard.
9417         * python/py-record-btrace.h: Rename include guard.
9418         * python/py-instruction.h: Rename include guard.
9419         * python/py-events.h: Rename include guard.
9420         * python/py-event.h: Rename include guard.
9421         * procfs.h: Add include guard.
9422         * proc-utils.h: Add include guard.
9423         * p-lang.h: Add include guard.
9424         * or1k-tdep.h: Rename include guard.
9425         * observable.h: Rename include guard.
9426         * nto-tdep.h: Rename include guard.
9427         * nat/x86-linux.h: Rename include guard.
9428         * nat/x86-linux-dregs.h: Rename include guard.
9429         * nat/x86-gcc-cpuid.h: Add include guard.
9430         * nat/x86-dregs.h: Rename include guard.
9431         * nat/x86-cpuid.h: Rename include guard.
9432         * nat/ppc-linux.h: Rename include guard.
9433         * nat/mips-linux-watch.h: Rename include guard.
9434         * nat/linux-waitpid.h: Rename include guard.
9435         * nat/linux-ptrace.h: Rename include guard.
9436         * nat/linux-procfs.h: Rename include guard.
9437         * nat/linux-osdata.h: Rename include guard.
9438         * nat/linux-nat.h: Rename include guard.
9439         * nat/linux-namespaces.h: Rename include guard.
9440         * nat/linux-btrace.h: Rename include guard.
9441         * nat/glibc_thread_db.h: Rename include guard.
9442         * nat/gdb_thread_db.h: Rename include guard.
9443         * nat/gdb_ptrace.h: Rename include guard.
9444         * nat/fork-inferior.h: Rename include guard.
9445         * nat/amd64-linux-siginfo.h: Rename include guard.
9446         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9447         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9448         * nat/aarch64-linux.h: Rename include guard.
9449         * nat/aarch64-linux-hw-point.h: Rename include guard.
9450         * mn10300-tdep.h: Add include guard.
9451         * mips-linux-tdep.h: Add include guard.
9452         * mi/mi-parse.h: Rename include guard.
9453         * mi/mi-out.h: Rename include guard.
9454         * mi/mi-main.h: Rename include guard.
9455         * mi/mi-interp.h: Rename include guard.
9456         * mi/mi-getopt.h: Rename include guard.
9457         * mi/mi-console.h: Rename include guard.
9458         * mi/mi-common.h: Rename include guard.
9459         * mi/mi-cmds.h: Rename include guard.
9460         * mi/mi-cmd-break.h: Rename include guard.
9461         * m2-lang.h: Add include guard.
9462         * location.h: Rename include guard.
9463         * linux-record.h: Rename include guard.
9464         * linux-nat.h: Add include guard.
9465         * linux-fork.h: Add include guard.
9466         * i386-darwin-tdep.h: Rename include guard.
9467         * hppa-linux-offsets.h: Add include guard.
9468         * guile/guile.h: Rename include guard.
9469         * guile/guile-internal.h: Rename include guard.
9470         * gnu-nat.h: Rename include guard.
9471         * gdb-stabs.h: Rename include guard.
9472         * frv-tdep.h: Add include guard.
9473         * f-lang.h: Add include guard.
9474         * event-loop.h: Add include guard.
9475         * darwin-nat.h: Rename include guard.
9476         * cp-abi.h: Rename include guard.
9477         * config/sparc/nm-sol2.h: Rename include guard.
9478         * config/nm-nto.h: Rename include guard.
9479         * config/nm-linux.h: Add include guard.
9480         * config/i386/nm-i386gnu.h: Rename include guard.
9481         * config/djgpp/nl_types.h: Rename include guard.
9482         * config/djgpp/langinfo.h: Rename include guard.
9483         * compile/gcc-cp-plugin.h: Add include guard.
9484         * compile/gcc-c-plugin.h: Add include guard.
9485         * compile/compile.h: Rename include guard.
9486         * compile/compile-object-run.h: Rename include guard.
9487         * compile/compile-object-load.h: Rename include guard.
9488         * compile/compile-internal.h: Rename include guard.
9489         * compile/compile-cplus.h: Rename include guard.
9490         * compile/compile-c.h: Rename include guard.
9491         * common/xml-utils.h: Rename include guard.
9492         * common/x86-xstate.h: Rename include guard.
9493         * common/version.h: Rename include guard.
9494         * common/vec.h: Rename include guard.
9495         * common/tdesc.h: Rename include guard.
9496         * common/selftest.h: Rename include guard.
9497         * common/scoped_restore.h: Rename include guard.
9498         * common/scoped_mmap.h: Rename include guard.
9499         * common/scoped_fd.h: Rename include guard.
9500         * common/safe-iterator.h: Rename include guard.
9501         * common/run-time-clock.h: Rename include guard.
9502         * common/refcounted-object.h: Rename include guard.
9503         * common/queue.h: Rename include guard.
9504         * common/ptid.h: Rename include guard.
9505         * common/print-utils.h: Rename include guard.
9506         * common/preprocessor.h: Rename include guard.
9507         * common/pathstuff.h: Rename include guard.
9508         * common/observable.h: Rename include guard.
9509         * common/netstuff.h: Rename include guard.
9510         * common/job-control.h: Rename include guard.
9511         * common/host-defs.h: Rename include guard.
9512         * common/gdb_wait.h: Rename include guard.
9513         * common/gdb_vecs.h: Rename include guard.
9514         * common/gdb_unlinker.h: Rename include guard.
9515         * common/gdb_unique_ptr.h: Rename include guard.
9516         * common/gdb_tilde_expand.h: Rename include guard.
9517         * common/gdb_sys_time.h: Rename include guard.
9518         * common/gdb_string_view.h: Rename include guard.
9519         * common/gdb_splay_tree.h: Rename include guard.
9520         * common/gdb_setjmp.h: Rename include guard.
9521         * common/gdb_ref_ptr.h: Rename include guard.
9522         * common/gdb_optional.h: Rename include guard.
9523         * common/gdb_locale.h: Rename include guard.
9524         * common/gdb_assert.h: Rename include guard.
9525         * common/filtered-iterator.h: Rename include guard.
9526         * common/filestuff.h: Rename include guard.
9527         * common/fileio.h: Rename include guard.
9528         * common/environ.h: Rename include guard.
9529         * common/common-utils.h: Rename include guard.
9530         * common/common-types.h: Rename include guard.
9531         * common/common-regcache.h: Rename include guard.
9532         * common/common-inferior.h: Rename include guard.
9533         * common/common-gdbthread.h: Rename include guard.
9534         * common/common-exceptions.h: Rename include guard.
9535         * common/common-defs.h: Rename include guard.
9536         * common/common-debug.h: Rename include guard.
9537         * common/cleanups.h: Rename include guard.
9538         * common/buffer.h: Rename include guard.
9539         * common/btrace-common.h: Rename include guard.
9540         * common/break-common.h: Rename include guard.
9541         * cli/cli-utils.h: Rename include guard.
9542         * cli/cli-style.h: Rename include guard.
9543         * cli/cli-setshow.h: Rename include guard.
9544         * cli/cli-script.h: Rename include guard.
9545         * cli/cli-interp.h: Rename include guard.
9546         * cli/cli-decode.h: Rename include guard.
9547         * cli/cli-cmds.h: Rename include guard.
9548         * charset-list.h: Add include guard.
9549         * buildsym-legacy.h: Rename include guard.
9550         * bfin-tdep.h: Add include guard.
9551         * ax.h: Rename include guard.
9552         * arm-linux-tdep.h: Add include guard.
9553         * arm-fbsd-tdep.h: Add include guard.
9554         * arch/xtensa.h: Rename include guard.
9555         * arch/tic6x.h: Add include guard.
9556         * arch/i386.h: Add include guard.
9557         * arch/arm.h: Rename include guard.
9558         * arch/arm-linux.h: Rename include guard.
9559         * arch/arm-get-next-pcs.h: Rename include guard.
9560         * arch/amd64.h: Add include guard.
9561         * arch/aarch64-insn.h: Rename include guard.
9562         * arch-utils.h: Rename include guard.
9563         * annotate.h: Add include guard.
9564         * amd64-darwin-tdep.h: Rename include guard.
9565         * aarch64-linux-tdep.h: Add include guard.
9566         * aarch64-fbsd-tdep.h: Add include guard.
9567         * aarch32-linux-nat.h: Add include guard.
9568
9569 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9570
9571         * macrotab.c (macro_define_internal): New function that
9572         factorizes macro_define_object_internal and macro_define_function
9573         code.
9574         (macro_define_object_internal): Use macro_define_internal.
9575         (macro_define_function): Likewise.
9576
9577 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9578
9579         * macrocmd.c (extract_identifier): Return
9580         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9581         callers.
9582
9583 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9584
9585         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9586
9587 2019-02-05  Tom Tromey  <tom@tromey.com>
9588
9589         * target.c (target_stack::unpush): Move assertion earlier.
9590
9591 2019-01-30  Tom Tromey  <tom@tromey.com>
9592
9593         PR python/23615:
9594         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9595         (gdbpy_parse_and_eval): Likewise.
9596         * python/python-internal.h (gdbpy_allow_threads): New class.
9597
9598 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9599
9600         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9601         (aarch64_fbsd_fpregmap): Move earlier.
9602         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9603         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9604         instead of individual calls to trad_frame_set_reg_addr.
9605         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9606         earlier.
9607         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9608         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9609         instead of individual calls to trad_frame_set_reg_addr.
9610
9611 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9612
9613         * CONTRIBUTE: Replace contribution list with wiki link.
9614
9615 2019-01-25  Tom Tromey  <tom@tromey.com>
9616
9617         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9618
9619 2019-01-25  Tom Tromey  <tom@tromey.com>
9620
9621         * xtensa-linux-nat.c: Fix common/ includes.
9622         * xml-support.h: Fix common/ includes.
9623         * xml-support.c: Fix common/ includes.
9624         * x86-linux-nat.c: Fix common/ includes.
9625         * windows-nat.c: Fix common/ includes.
9626         * varobj.h: Fix common/ includes.
9627         * varobj.c: Fix common/ includes.
9628         * value.c: Fix common/ includes.
9629         * valops.c: Fix common/ includes.
9630         * utils.c: Fix common/ includes.
9631         * unittests/xml-utils-selftests.c: Fix common/ includes.
9632         * unittests/utils-selftests.c: Fix common/ includes.
9633         * unittests/unpack-selftests.c: Fix common/ includes.
9634         * unittests/tracepoint-selftests.c: Fix common/ includes.
9635         * unittests/style-selftests.c: Fix common/ includes.
9636         * unittests/string_view-selftests.c: Fix common/ includes.
9637         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9638         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9639         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9640         * unittests/rsp-low-selftests.c: Fix common/ includes.
9641         * unittests/parse-connection-spec-selftests.c: Fix common/
9642         includes.
9643         * unittests/optional-selftests.c: Fix common/ includes.
9644         * unittests/offset-type-selftests.c: Fix common/ includes.
9645         * unittests/observable-selftests.c: Fix common/ includes.
9646         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9647         * unittests/memrange-selftests.c: Fix common/ includes.
9648         * unittests/memory-map-selftests.c: Fix common/ includes.
9649         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9650         * unittests/function-view-selftests.c: Fix common/ includes.
9651         * unittests/environ-selftests.c: Fix common/ includes.
9652         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9653         * unittests/common-utils-selftests.c: Fix common/ includes.
9654         * unittests/cli-utils-selftests.c: Fix common/ includes.
9655         * unittests/array-view-selftests.c: Fix common/ includes.
9656         * ui-file.c: Fix common/ includes.
9657         * tui/tui-io.c: Fix common/ includes.
9658         * tracepoint.h: Fix common/ includes.
9659         * tracepoint.c: Fix common/ includes.
9660         * tracefile-tfile.c: Fix common/ includes.
9661         * top.h: Fix common/ includes.
9662         * top.c: Fix common/ includes.
9663         * thread.c: Fix common/ includes.
9664         * target/waitstatus.h: Fix common/ includes.
9665         * target/waitstatus.c: Fix common/ includes.
9666         * target.h: Fix common/ includes.
9667         * target.c: Fix common/ includes.
9668         * target-memory.c: Fix common/ includes.
9669         * target-descriptions.c: Fix common/ includes.
9670         * symtab.h: Fix common/ includes.
9671         * symfile.c: Fix common/ includes.
9672         * stap-probe.c: Fix common/ includes.
9673         * spu-linux-nat.c: Fix common/ includes.
9674         * sparc-nat.c: Fix common/ includes.
9675         * source.c: Fix common/ includes.
9676         * solib.c: Fix common/ includes.
9677         * solib-target.c: Fix common/ includes.
9678         * ser-unix.c: Fix common/ includes.
9679         * ser-tcp.c: Fix common/ includes.
9680         * ser-pipe.c: Fix common/ includes.
9681         * ser-base.c: Fix common/ includes.
9682         * selftest-arch.c: Fix common/ includes.
9683         * s12z-tdep.c: Fix common/ includes.
9684         * rust-exp.y: Fix common/ includes.
9685         * rs6000-aix-tdep.c: Fix common/ includes.
9686         * riscv-tdep.c: Fix common/ includes.
9687         * remote.c: Fix common/ includes.
9688         * remote-notif.h: Fix common/ includes.
9689         * remote-fileio.h: Fix common/ includes.
9690         * remote-fileio.c: Fix common/ includes.
9691         * regcache.h: Fix common/ includes.
9692         * regcache.c: Fix common/ includes.
9693         * record-btrace.c: Fix common/ includes.
9694         * python/python.c: Fix common/ includes.
9695         * python/py-type.c: Fix common/ includes.
9696         * python/py-inferior.c: Fix common/ includes.
9697         * progspace.h: Fix common/ includes.
9698         * producer.c: Fix common/ includes.
9699         * procfs.c: Fix common/ includes.
9700         * proc-api.c: Fix common/ includes.
9701         * printcmd.c: Fix common/ includes.
9702         * ppc-linux-nat.c: Fix common/ includes.
9703         * parser-defs.h: Fix common/ includes.
9704         * osdata.c: Fix common/ includes.
9705         * obsd-nat.c: Fix common/ includes.
9706         * nat/x86-linux.c: Fix common/ includes.
9707         * nat/x86-linux-dregs.c: Fix common/ includes.
9708         * nat/x86-dregs.h: Fix common/ includes.
9709         * nat/x86-dregs.c: Fix common/ includes.
9710         * nat/ppc-linux.c: Fix common/ includes.
9711         * nat/mips-linux-watch.h: Fix common/ includes.
9712         * nat/mips-linux-watch.c: Fix common/ includes.
9713         * nat/linux-waitpid.c: Fix common/ includes.
9714         * nat/linux-ptrace.h: Fix common/ includes.
9715         * nat/linux-ptrace.c: Fix common/ includes.
9716         * nat/linux-procfs.c: Fix common/ includes.
9717         * nat/linux-personality.c: Fix common/ includes.
9718         * nat/linux-osdata.c: Fix common/ includes.
9719         * nat/linux-namespaces.c: Fix common/ includes.
9720         * nat/linux-btrace.h: Fix common/ includes.
9721         * nat/linux-btrace.c: Fix common/ includes.
9722         * nat/fork-inferior.c: Fix common/ includes.
9723         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9724         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9725         * nat/aarch64-linux.c: Fix common/ includes.
9726         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9727         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9728         * namespace.h: Fix common/ includes.
9729         * mips-linux-tdep.c: Fix common/ includes.
9730         * minsyms.c: Fix common/ includes.
9731         * mi/mi-parse.h: Fix common/ includes.
9732         * mi/mi-main.c: Fix common/ includes.
9733         * mi/mi-cmd-env.c: Fix common/ includes.
9734         * memrange.h: Fix common/ includes.
9735         * memattr.c: Fix common/ includes.
9736         * maint.h: Fix common/ includes.
9737         * maint.c: Fix common/ includes.
9738         * main.c: Fix common/ includes.
9739         * machoread.c: Fix common/ includes.
9740         * location.c: Fix common/ includes.
9741         * linux-thread-db.c: Fix common/ includes.
9742         * linux-nat.c: Fix common/ includes.
9743         * linux-fork.c: Fix common/ includes.
9744         * inline-frame.c: Fix common/ includes.
9745         * infrun.c: Fix common/ includes.
9746         * inflow.c: Fix common/ includes.
9747         * inferior.h: Fix common/ includes.
9748         * inferior.c: Fix common/ includes.
9749         * infcmd.c: Fix common/ includes.
9750         * inf-ptrace.c: Fix common/ includes.
9751         * inf-child.c: Fix common/ includes.
9752         * ia64-linux-nat.c: Fix common/ includes.
9753         * i387-tdep.c: Fix common/ includes.
9754         * i386-tdep.c: Fix common/ includes.
9755         * i386-linux-tdep.c: Fix common/ includes.
9756         * i386-linux-nat.c: Fix common/ includes.
9757         * i386-go32-tdep.c: Fix common/ includes.
9758         * i386-fbsd-tdep.c: Fix common/ includes.
9759         * i386-fbsd-nat.c: Fix common/ includes.
9760         * guile/scm-type.c: Fix common/ includes.
9761         * guile/guile.c: Fix common/ includes.
9762         * go32-nat.c: Fix common/ includes.
9763         * gnu-nat.c: Fix common/ includes.
9764         * gdbthread.h: Fix common/ includes.
9765         * gdbarch-selftests.c: Fix common/ includes.
9766         * gdb_usleep.c: Fix common/ includes.
9767         * gdb_select.h: Fix common/ includes.
9768         * gdb_bfd.c: Fix common/ includes.
9769         * gcore.c: Fix common/ includes.
9770         * fork-child.c: Fix common/ includes.
9771         * findvar.c: Fix common/ includes.
9772         * fbsd-nat.c: Fix common/ includes.
9773         * event-top.c: Fix common/ includes.
9774         * event-loop.c: Fix common/ includes.
9775         * dwarf2read.c: Fix common/ includes.
9776         * dwarf2loc.c: Fix common/ includes.
9777         * dwarf2-frame.c: Fix common/ includes.
9778         * dwarf-index-cache.c: Fix common/ includes.
9779         * dtrace-probe.c: Fix common/ includes.
9780         * disasm-selftests.c: Fix common/ includes.
9781         * defs.h: Fix common/ includes.
9782         * csky-tdep.c: Fix common/ includes.
9783         * cp-valprint.c: Fix common/ includes.
9784         * cp-support.h: Fix common/ includes.
9785         * cp-support.c: Fix common/ includes.
9786         * corelow.c: Fix common/ includes.
9787         * completer.h: Fix common/ includes.
9788         * completer.c: Fix common/ includes.
9789         * compile/compile.c: Fix common/ includes.
9790         * compile/compile-loc2c.c: Fix common/ includes.
9791         * compile/compile-cplus-types.c: Fix common/ includes.
9792         * compile/compile-cplus-symbols.c: Fix common/ includes.
9793         * command.h: Fix common/ includes.
9794         * cli/cli-dump.c: Fix common/ includes.
9795         * cli/cli-cmds.c: Fix common/ includes.
9796         * charset.c: Fix common/ includes.
9797         * build-id.c: Fix common/ includes.
9798         * btrace.h: Fix common/ includes.
9799         * btrace.c: Fix common/ includes.
9800         * breakpoint.h: Fix common/ includes.
9801         * breakpoint.c: Fix common/ includes.
9802         * ax.h:
9803         (enum agent_op): Fix common/ includes.
9804         * ax-general.c (struct aop_map): Fix common/ includes.
9805         * ax-gdb.c: Fix common/ includes.
9806         * auxv.c: Fix common/ includes.
9807         * auto-load.c: Fix common/ includes.
9808         * arm-tdep.c: Fix common/ includes.
9809         * arch/riscv.c: Fix common/ includes.
9810         * arch/ppc-linux-common.c: Fix common/ includes.
9811         * arch/i386.c: Fix common/ includes.
9812         * arch/arm.c: Fix common/ includes.
9813         * arch/arm-linux.c: Fix common/ includes.
9814         * arch/arm-get-next-pcs.c: Fix common/ includes.
9815         * arch/amd64.c: Fix common/ includes.
9816         * arch/aarch64.c: Fix common/ includes.
9817         * arch/aarch64-insn.c: Fix common/ includes.
9818         * arch-utils.c: Fix common/ includes.
9819         * amd64-windows-tdep.c: Fix common/ includes.
9820         * amd64-tdep.c: Fix common/ includes.
9821         * amd64-sol2-tdep.c: Fix common/ includes.
9822         * amd64-obsd-tdep.c: Fix common/ includes.
9823         * amd64-nbsd-tdep.c: Fix common/ includes.
9824         * amd64-linux-tdep.c: Fix common/ includes.
9825         * amd64-linux-nat.c: Fix common/ includes.
9826         * amd64-fbsd-tdep.c: Fix common/ includes.
9827         * amd64-fbsd-nat.c: Fix common/ includes.
9828         * amd64-dicos-tdep.c: Fix common/ includes.
9829         * amd64-darwin-tdep.c: Fix common/ includes.
9830         * agent.c: Fix common/ includes.
9831         * ada-lang.h: Fix common/ includes.
9832         * ada-lang.c: Fix common/ includes.
9833         * aarch64-tdep.c: Fix common/ includes.
9834
9835 2019-01-25  Tom Tromey  <tom@tromey.com>
9836
9837         * common/create-version.sh: Use common/version.h.
9838
9839 2019-01-24  Pedro Alves  <palves@redhat.com>
9840
9841         * infrun.c (signal_stop, signal_print, signal_program)
9842         (signal_catch, signal_pass): Now arrays instead of pointers.
9843         (update_signals_program_target, do_target_resume)
9844         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9845         * linux-nat.c (linux_nat_target::pass_signals)
9846         (linux_nat_target::create_inferior, linux_nat_target::attach):
9847         Adjust.
9848         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9849         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9850         * procfs.c (procfs_target::pass_signals): Adjust.
9851         * record-full.c (record_full_target::resume): Adjust.
9852         * remote.c (remote_target::pass_signals)
9853         (remote_target::program_signals): Adjust.
9854         * target-debug.h (target_debug_print_signals): Now takes a
9855         gdb::array_view as parameter.  Adjust.
9856         * target.h (target_ops) <pass_signals, program_signals>: Replace
9857         pointer and length parameters with gdb::array_view.
9858         (target_pass_signals, target_program_signals): Likewise.
9859         * target-delegates.c: Regenerate.
9860
9861 2019-01-24  Pedro Alves  <palves@redhat.com>
9862
9863         * common/forward-scope-exit.h
9864         (forward_scope_exit::forward_scope_exit): Pass arguments to
9865         m_bind_function directly, instead of creating a std::bind and
9866         copying that.
9867
9868 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9869
9870         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9871         for static members.
9872         (pass_in_v_vfp_candidate): Likewise.
9873
9874 2019-01-23  Tom Tromey  <tom@tromey.com>
9875             Pedro Alves  <palves@redhat.com>
9876
9877         * regcache.c (class regcache_invalidator): Remove.
9878         (regcache::raw_write): Use make_scope_exit.
9879
9880 2019-01-23  Tom Tromey  <tom@tromey.com>
9881
9882         * ui-out.h (class ui_out_emit_type): Update comment.
9883
9884 2019-01-23  Tom Tromey  <tom@tromey.com>
9885
9886         * infrun.c (fetch_inferior_event): Update comment.
9887
9888 2019-01-23  Tom Tromey  <tom@tromey.com>
9889             Pedro Alves  <palves@redhat.com>
9890
9891         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9892         parameter.
9893         (fetch_inferior_event): Use SCOPE_EXIT.
9894
9895
9896 2019-01-23  Tom Tromey  <tom@tromey.com>
9897             Pedro Alves  <palves@redhat.com>
9898
9899         * infrun.c (disable_thread_events): Delete.
9900         (stop_all_threads): Use SCOPE_EXIT.
9901
9902 2019-01-23  Tom Tromey  <tom@tromey.com>
9903             Pedro Alves  <palves@redhat.com>
9904
9905         * symfile.c: Include forward-scope-exit.h.
9906         (clear_symtab_users_cleanup): Replace forward declaration with
9907         a FORWARD_SCOPE_EXIT.
9908         (syms_from_objfile_1): Use the forward_scope_exit and
9909         gdb::optional instead of cleanup_function.
9910         (reread_symbols): Use the forward_scope_exit instead of
9911         cleanup_function.
9912         (clear_symtab_users_cleanup): Remove function.
9913
9914 2019-01-23  Tom Tromey  <tom@tromey.com>
9915             Pedro Alves  <palves@redhat.com>
9916
9917         * linux-nat.c: Include scope-exit.h.
9918         (cleanup_target_stop): Remove.
9919         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9920         SCOPE_EXIT.
9921
9922 2019-01-23  Tom Tromey  <tom@tromey.com>
9923             Pedro Alves  <palves@redhat.com>
9924
9925         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9926         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9927
9928 2019-01-23  Tom Tromey  <tom@tromey.com>
9929             Andrew Burgess  <andrew.burgess@embecosm.com>
9930             Pedro Alves  <palves@redhat.com>
9931
9932         * infrun.c (fetch_inferior_event): Use scope_exit.
9933         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9934         * top.c (execute_command): Use scope_exit.
9935         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9936         * utils.c (do_bpstat_clear_actions_cleanup)
9937         (make_bpstat_clear_actions_cleanup): Remove.
9938
9939 2019-01-23  Tom Tromey  <tom@tromey.com>
9940             Pedro Alves  <palves@redhat.com>
9941
9942         * infrun.c: Include "common/scope-exit.h"
9943         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9944         (wait_for_inferior): Use SCOPE_EXIT.
9945         (fetch_inferior_event): Use scope_exit.
9946
9947 2019-01-23  Tom Tromey  <tom@tromey.com>
9948             Pedro Alves  <palves@redhat.com>
9949
9950         * breakpoint.c (create_breakpoint): Remove cleanup.
9951
9952 2019-01-23  Tom Tromey  <tom@tromey.com>
9953             Andrew Burgess  <andrew.burgess@embecosm.com>
9954             Pedro Alves  <palves@redhat.com>
9955
9956 2019-01-23  Pedro Alves  <palves@redhat.com>
9957
9958         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9959
9960 2019-01-23  Pedro Alves  <palves@redhat.com>
9961             Andrew Burgess  <andrew.burgess@embecosm.com>
9962
9963         * gdbthread.h: Include "common/forward-scope-exit.h".
9964         (scoped_finish_thread_state): Redefine custom class in terms of
9965         forward_scope_exit.
9966
9967 2019-01-23  Pedro Alves  <palves@redhat.com>
9968             Andrew Burgess  <andrew.burgess@embecosm.com>
9969
9970         * common/forward-scope-exit.h: New file.
9971
9972 2019-01-23  Pedro Alves  <palves@redhat.com>
9973             Andrew Burgess  <andrew.burgess@embecosm.com>
9974             Tom Tromey  <tom@tromey.com>
9975
9976         * common/scope-exit.h: New file.
9977
9978 2019-01-23  Pedro Alves  <palves@redhat.com>
9979
9980         * common/preprocessor.h (ESC): Rename to ...
9981         (ESC_PARENS): ... this.
9982         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9983         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9984
9985 2019-01-23  Tom Tromey  <tom@tromey.com>
9986
9987         * language.h (class scoped_switch_to_sym_language_if_auto):
9988         Initialize m_lang in both cases.
9989
9990 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9991
9992         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9993         with XCNEW.
9994
9995 2019-01-22  Tom Tromey  <tom@tromey.com>
9996
9997         * corelow.c: Do not include sys/file.h.
9998
9999 2019-01-22  Tom Tromey  <tom@tromey.com>
10000
10001         * tui/tui-wingeneral.h: Include gdb_curses.h.
10002
10003 2019-01-22  Tom Tromey  <tom@tromey.com>
10004
10005         * source-cache.h (class source_cache) <get_source_lines,
10006         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10007
10008 2019-01-22  Tom Tromey  <tom@tromey.com>
10009
10010         * remote-fileio.h (struct remote_target): Declare.
10011
10012 2019-01-22  Tom Tromey  <tom@tromey.com>
10013
10014         * python/py-arch.c: Do not include py-ref.h.
10015         * python/py-bpevent.c: Do not include py-ref.h.
10016         * python/py-cmd.c: Do not include py-ref.h.
10017         * python/py-continueevent.c: Do not include py-ref.h.
10018         * python/py-event.h: Do not include py-ref.h.
10019         * python/py-evtregistry.c: Do not include py-ref.h.
10020         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10021         * python/py-frame.c: Do not include py-ref.h.
10022         * python/py-framefilter.c: Do not include py-ref.h.
10023         * python/py-function.c: Do not include py-ref.h.
10024         * python/py-infevents.c: Do not include py-ref.h.
10025         * python/py-linetable.c: Do not include py-ref.h.
10026         * python/py-objfile.c: Do not include py-ref.h.
10027         * python/py-param.c: Do not include py-ref.h.
10028         * python/py-prettyprint.c: Do not include py-ref.h.
10029         * python/py-progspace.c: Do not include py-ref.h.
10030         * python/py-symbol.c: Do not include py-ref.h.
10031         * python/py-symtab.c: Do not include py-ref.h.
10032         * python/py-type.c: Do not include py-ref.h.
10033         * python/py-unwind.c: Do not include py-ref.h.
10034         * python/py-utils.c: Do not include py-ref.h.
10035         * python/py-value.c: Do not include py-ref.h.
10036         * python/py-varobj.c: Do not include py-ref.h.
10037         * python/py-xmethods.c: Do not include py-ref.h.
10038         * python/python.c: Do not include py-ref.h.
10039         * varobj.c: Do not include py-ref.h.
10040
10041 2019-01-22  Tom Tromey  <tom@tromey.com>
10042
10043         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10044         keyword for bcache.
10045
10046 2019-01-22  Tom Tromey  <tom@tromey.com>
10047
10048         * compile/compile-cplus-types.c: Remove a comment by #include.
10049
10050 2019-01-22  Tom Tromey  <tom@tromey.com>
10051
10052         * compile/gcc-c-plugin.h: Include compile-internal.h.
10053
10054 2019-01-22  Tom Tromey  <tom@tromey.com>
10055
10056         * stabsread.c (EXTERN): Do not define.
10057         (symnum, next_symbol_text_func, processing_gcc_compilation)
10058         (within_function, global_sym_chain, global_stabs)
10059         (previous_stab_code, this_object_header_files)
10060         (n_this_object_header_files)
10061         (n_allocated_this_object_header_files): Define.
10062         * stabsread.h (EXTERN): Never define.  Use "extern".
10063
10064 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10065
10066         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10067         history_value.
10068
10069 2019-01-21  Tom Tromey  <tom@tromey.com>
10070
10071         * ui-out.c: Fix includes.
10072         * tui/tui-source.c: Fix includes.
10073         * target.c: Fix includes.
10074         * remote.c: Fix includes.
10075         * regcache.c: Fix includes.
10076         * python/py-block.c: Fix includes.
10077         * printcmd.c: Fix includes.
10078         * or1k-tdep.c: Fix includes.
10079         * mi/mi-main.c: Fix includes.
10080         * m32r-tdep.c: Fix includes.
10081         * csky-tdep.c: Fix includes.
10082         * compile/compile-cplus-types.c: Fix includes.
10083         * cli/cli-interp.c: Fix includes.
10084
10085 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10086
10087         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10088         for padding.
10089
10090 2019-01-16  Tom Tromey  <tom@tromey.com>
10091
10092         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10093         earlier.
10094         (struct objfile) <msymbols_range>: Move from top level.
10095         <msymbols>: New method.
10096         (class objfile_msymbols): Remove.
10097         * symtab.c (default_collect_symbol_completion_matches_break_on):
10098         Update.
10099         * symmisc.c (dump_msymbols): Update.
10100         * stabsread.c (scan_file_globals): Update.
10101         * objc-lang.c (info_selectors_command, info_classes_command)
10102         (find_methods): Update.
10103         * minsyms.c (find_solib_trampoline_target): Update.
10104         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10105         * coffread.c (coff_symfile_read): Update.
10106         * ada-lang.c (ada_lookup_simple_minsym)
10107         (ada_collect_symbol_completion_matches): Update.
10108
10109 2019-01-16  Tom Tromey  <tom@tromey.com>
10110
10111         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10112         type.  Remove no-argument constructor.
10113         <iterator::operator++>: Simplify.
10114         <begin>: Update.
10115         <end>: Use minimal_symbol_count.
10116
10117 2019-01-16  Tom Tromey  <tom@tromey.com>
10118
10119         * objfiles.h (struct objfile) <psymtabs>: New method.
10120         (class objfile_psymtabs): Remove.
10121         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10122         typedef.
10123         <range>: New method.
10124         (require_partial_symbols): Change return type.
10125         * psymtab.c (require_partial_symbols)
10126         (psym_expand_symtabs_matching): Update.
10127         * mdebugread.c (parse_partial_symbols): Update.
10128         * dbxread.c (dbx_end_psymtab): Update.
10129
10130 2019-01-15  Tom Tromey  <tom@tromey.com>
10131
10132         * symtab.c (lookup_objfile_from_block)
10133         (lookup_symbol_in_objfile_symtabs)
10134         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10135         (find_line_symtab, info_sources_command)
10136         (default_collect_symbol_completion_matches_break_on)
10137         (make_source_files_completion_list): Update.
10138         * symmisc.c (print_objfile_statistics, dump_objfile)
10139         (maintenance_print_symbols, maintenance_info_symtabs)
10140         (maintenance_check_symtabs, maintenance_info_line_tables):
10141         Update.
10142         * source.c (select_source_symtab)
10143         (forget_cached_source_info_for_objfile): Update.
10144         * objfiles.h (class objfile_compunits): Remove.
10145         (struct objfile) <compunits_range>: New typedef.
10146         (compunits): New method.
10147         * objfiles.c (objfile_relocate1): Update.
10148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10149         * maint.c (count_symtabs_and_blocks): Update.
10150         * linespec.c (iterate_over_all_matching_symtabs): Update.
10151         * cp-support.c (add_symbol_overload_list_qualified): Update.
10152         * coffread.c (coff_symtab_read): Update.
10153         * ada-lang.c (add_nonlocal_symbols)
10154         (ada_collect_symbol_completion_matches)
10155         (ada_add_global_exceptions): Update.
10156
10157 2019-01-15  Tom Tromey  <tom@tromey.com>
10158
10159         * progspace.h (program_space) <objfiles_safe_range>: New
10160         typedef.
10161         <objfiles_safe>: New method.
10162         * objfiles.h (class all_objfiles_safe): Remove.
10163         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10164         * jit.c (jit_inferior_exit_hook): Update.
10165
10166 2019-01-17  Tom Tromey  <tom@tromey.com>
10167
10168         * progspace.h (program_space) <objfiles_range>: New typedef.
10169         <objfiles>: New method.
10170         <objfiles_head>: Rename from objfiles.
10171         (object_files): Update.
10172         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10173         * guile/scm-pretty-print.c
10174         (ppscm_find_pretty_printer_from_objfiles): Update.
10175         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10176         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10177         Update.
10178         * python/py-progspace.c (pspy_get_objfiles): Update.
10179         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10180         Update.
10181         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10182         (objfpy_lookup_objfile_by_build_id): Update.
10183         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10184         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10185         Update.
10186         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10187         (expand_symtab_containing_pc, lookup_objfile_from_block)
10188         (lookup_static_symbol, basic_lookup_transparent_type)
10189         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10190         (find_line_symtab, info_sources_command)
10191         (default_collect_symbol_completion_matches_break_on)
10192         (make_source_files_completion_list, find_main_name): Update.
10193         * symmisc.c (print_symbol_bcache_statistics)
10194         (print_objfile_statistics, maintenance_print_symbols)
10195         (maintenance_print_msymbols, maintenance_print_objfiles)
10196         (maintenance_info_symtabs, maintenance_check_symtabs)
10197         (maintenance_expand_symtabs, maintenance_info_line_tables):
10198         Update.
10199         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10200         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10201         (map_overlay_command, unmap_overlay_command)
10202         (simple_overlay_update, expand_symtabs_matching)
10203         (map_symbol_filenames): Update.
10204         * symfile-debug.c (set_debug_symfile): Update.
10205         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10206         Update.
10207         * source.c (select_source_symtab, forget_cached_source_info):
10208         Update.
10209         * solib.c (solib_read_symbols): Update.
10210         * solib-spu.c (append_ocl_sos): Update.
10211         * psymtab.c (maintenance_print_psymbols)
10212         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10213         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10214         * printcmd.c (info_symbol_command): Update.
10215         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10216         Update.
10217         * objfiles.h (class all_objfiles): Remove.
10218         * objfiles.c (have_partial_symbols, have_full_symbols)
10219         (have_minimal_symbols, qsort_cmp, update_section_map)
10220         (shared_objfile_contains_address_p)
10221         (default_iterate_over_objfiles_in_search_order): Update.
10222         * objc-lang.c (info_selectors_command, info_classes_command)
10223         (find_methods): Update.
10224         * minsyms.c (find_solib_trampoline_target): Update.
10225         * maint.c (maintenance_info_sections)
10226         (maintenance_translate_address, count_symtabs_and_blocks):
10227         Update.
10228         * main.c (captured_main_1): Update.
10229         * linux-thread-db.c (try_thread_db_load_from_pdir)
10230         (has_libpthread): Update.
10231         * linespec.c (iterate_over_all_matching_symtabs)
10232         (search_minsyms_for_name): Update.
10233         * jit.c (jit_find_objf_with_entry_addr): Update.
10234         * hppa-tdep.c (find_unwind_entry)
10235         (hppa_lookup_stub_minimal_symbol): Update.
10236         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10237         Update.
10238         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10239         (elf_gnu_ifunc_resolve_by_got): Update.
10240         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10241         * dwarf-index-write.c (save_gdb_index_command): Update.
10242         * cp-support.c (add_symbol_overload_list_qualified): Update.
10243         * breakpoint.c (create_overlay_event_breakpoint)
10244         (create_longjmp_master_breakpoint)
10245         (create_std_terminate_master_breakpoint)
10246         (create_exception_master_breakpoint): Update.
10247         * blockframe.c (find_pc_partial_function): Update.
10248         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10249         (ada_collect_symbol_completion_matches)
10250         (ada_add_global_exceptions): Update.
10251
10252 2019-01-17  Tom Tromey  <tom@tromey.com>
10253
10254         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10255         declare VEC.
10256         (solib_target_parse_libraries): Change return type.
10257         (library_list_start_segment, library_list_start_section)
10258         (library_list_end_library, library_list_start_library); Update.
10259         (solib_target_free_library_list): Remove.
10260         (solib_target_parse_libraries): Remove cleanup.  Change return
10261         type.
10262         (solib_target_current_sos): Update.
10263
10264 2019-01-17  Tom Tromey  <tromey@bapiya>
10265
10266         * valprint.c: Replace "the the" with "the".
10267         * symtab.c: Replace "the the" with "the".
10268         * solib.c: Replace "the the" with "the".
10269         * solib-dsbt.c: Replace "the the" with "the".
10270         * linespec.c: Replace "the the" with "the".
10271         * dwarf2loc.h: Replace "the the" with "the".
10272         * amd64-windows-tdep.c: Replace "the the" with "the".
10273         * aarch64-tdep.c: Replace "the the" with "the".
10274
10275 2019-01-16  Keith Seitz  <keiths@redhat.com>
10276
10277         PR gdb/23773
10278         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10279         <builder>: Rename to ..
10280         <m_builder>: ... this and make private.
10281         (dwarf2_cu::get_builder): New method.  Change all users of
10282         `builder' to use this method.
10283         (dwarf2_start_symtab): Move to ...
10284         (dwarf2_cu::start_symtab): ... here.  Update all callers
10285         (setup_type_unit_groups): Move to ...
10286         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10287         callers.
10288         (dwarf2_cu::reset_builder): New method.
10289         (process_full_compunit, process_full_type_unit): Use
10290         dwarf2_cu::reset_builder.
10291         (follow_die_offset): Record the ancestor CU if it is different
10292         from the followed DIE's CU.
10293         (follow_die_sig_1): Likewise.
10294
10295 2019-01-15  Tom Tromey  <tom@tromey.com>
10296
10297         * remote.c (class remote_state) <buf>: Now a char_vector.
10298         <buf_size>: Remove.
10299         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10300         parameter.
10301         (remote_target::getpkt_or_notif_sane_1)
10302         (remote_target::getpkt_sane)
10303         (remote_target::getpkt_or_notif_sane): Likewise.
10304         (class remote_target) <putpkt>: New overload.
10305         (remote_target::read_frame): Change type of "buf_p".  Remove
10306         sizeof_p parameter.
10307         (packet_ok): New overload.
10308         (packet_check_result): New overload.
10309         Update all uses.
10310
10311 2019-01-14  Tom Tromey  <tom@tromey.com>
10312
10313         * remote-notif.c (handle_notification, remote_notif_ack)
10314         (remote_notif_parse): Make "buf" const.
10315         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10316         const.
10317         (remote_notif_parse, remote_notif_ack, handle_notification):
10318         Likewise.
10319         * remote.c (remote_notif_stop_parse): Make "buf" const.
10320         (remote_target::remote_parse_stop_reply): Make "buf" const.
10321         (remote_notif_stop_ack): Make "buf" const.
10322
10323 2019-01-14  Tom Tromey  <tom@tromey.com>
10324
10325         * remote.c (remote_console_output): Make parameter const.
10326
10327 2019-01-14  Tom Tromey  <tom@tromey.com>
10328
10329         * target-debug.h (target_debug_print_signals): Constify.
10330         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10331         * procfs.c (procfs_target::pass_signals): Update.
10332         * linux-nat.c (linux_nat_target::pass_signals): Update.
10333         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10334         * target-delegates.c: Rebuild.
10335         * remote.c (remote_target::program_signals): Update.
10336         (remote_target::pass_signals): Update.
10337         * target.c (target_pass_signals): Constify argument.
10338         (target_program_signals): Likewise.
10339         * target.h (struct target_ops) <pass_signals, program_signals>:
10340         Constify argument.
10341         (target_pass_signals, target_program_signals): Constify argument.
10342
10343 2019-01-14  Tom Tromey  <tom@tromey.com>
10344
10345         PR tui/28819:
10346         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10347
10348 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10349
10350         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10351         field.
10352         * rs6000-tdep.c: Include reggroups.h.
10353         (IS_V_ALIAS_PSEUDOREG): Define.
10354         (rs6000_register_name): Return names for the "vX" aliases.
10355         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10356         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10357         aliases.  Call default_register_reggroup_p for all other
10358         pseudo-registers.
10359         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10360         New functions.
10361         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10362         Handle "vX" aliases.
10363         (v_alias_pseudo_register_collect): New function.
10364         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10365         (rs6000_gdbarch_init): Initialize "vX" aliases as
10366         pseudo-registers.  Restore registration of
10367         rs6000_pseudo_register_reggroup_p with
10368         set_tdesc_pseudo_register_reggroup_p.
10369
10370 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10371
10372         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10373         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10374         set_gdbarch_num_pseudo_regs.
10375
10376 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10377
10378         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10379         Remove arg prefixname, add do_set and do_show.
10380         Add member functions set_list and show_list.
10381         * cli/cli-style.c (class cli_style_option): Update accordingly.
10382         (style_set_list): Move to file scope.
10383         (style_show_list): Likewise.
10384         (set_style): Call help_list.
10385         (show_style): Call cmd_show_list.
10386         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10387         Update to use the new macro.
10388
10389 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10390
10391         * ada-lang.c (_initialize_ada_language): Expand the help text
10392         for the "catch exception" command.
10393
10394 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10395
10396         * symtab.c (matching_obj_sections): Initialize obj,
10397         declare it closer to its usage.
10398
10399 2019-01-10  Tom Tromey  <tom@tromey.com>
10400
10401         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10402         (basic_inf_threads_range): Remove.
10403         (inf_threads_range, inf_non_exited_threads_range)
10404         (safe_inf_threads_range): Use next_adapter.
10405
10406 2019-01-10  Keith Seitz  <keiths@redhat.com>
10407
10408         PR gdb/23712
10409         PR symtab/23010
10410         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10411         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10412
10413 2019-01-10  Keith Seitz  <keiths@redhat.com>
10414
10415         PR gdb/23712
10416         PR symtab/23010
10417         * dictionary.c (pending_to_vector): Remove.
10418         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10419         Remove _1 suffix, replacing functions of the same name.  Update
10420         all callers.
10421         (dict_create_hashed, dict_create_hashed_expandable)
10422         (dict_create_linear, dict_create_linear_expandable, dict_free)
10423         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10424         Make functions static.
10425
10426 2019-01-10  Keith Seitz  <keiths@redhat.com>
10427
10428         PR gdb/23712
10429         PR symtab/23010
10430         * dictionary.h (struct dictionary): Replace declaration with
10431         multidictionary.
10432         (dict_create_hashed, dict_create_hashed_expandable)
10433         (dict_create_linear, dict_create_linear_expandable)
10434         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10435         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10436         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10437         taking multidictionary argument.
10438         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10439         * block.h (struct block) <dict>: Change to multidictionary
10440         and rename `multidict'.
10441         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10442         symmisc.c: Update all dictionary references to multidictionary.
10443
10444 2019-01-10  Keith Seitz  <keiths@redhat.com>
10445
10446         PR gdb/23712
10447         PR symtab/23010
10448         * dictionary.c: Include unordered_map.
10449         (pending_to_vector): New function.
10450         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10451         Rewrite the non-"_1" functions to take vector instead
10452         of linked list.
10453         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10454         "new" _1 versions of the same name.
10455         (multidictionary): Define.
10456         (std::hash<enum language): New definition.
10457         (collate_pending_symbols_by_language, mdict_create_hashed)
10458         (mdict_create_hashed_expandable, mdict_create_linear)
10459         (mdict_create_linear_expandable, mdict_free)
10460         (find_language_dictionary, create_new_language_dictionary)
10461         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10462         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10463         (mdict_size, mdict_empty): New functions.
10464         * dictionary.h (mdict_iterator): Define.
10465
10466 2019-01-10  Pedro Alves  <palves@redhat.com>
10467
10468         * breakpoint.c (read_uploaded_action)
10469         (create_tracepoint_from_upload): Adjust to use
10470         gdb::unique_xmalloc_ptr.
10471         * ctf.c (ctf_write_uploaded_tp):
10472         (SET_ARRAY_FIELD): Use emplace_back.
10473         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10474         * tracefile-tfile.c (tfile_write_uploaded_tp):
10475         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10476         gdb::unique_xmalloc_ptr.
10477         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10478         at_string, cond_string, cmd_strings>: Replace char pointers
10479         with gdb::unique_xmalloc_ptr.
10480
10481 2019-01-10  Pedro Alves  <palves@redhat.com>
10482
10483         * solib-target.c (library_list_start_library): Don't xstrdup name.
10484
10485 2019-01-10  Pedro Alves  <palves@redhat.com>
10486
10487         * mdebugread.c (parse_partial_symbols): Use
10488         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10489
10490 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10491
10492         * linux-fork.c (scoped_switch_fork_info)
10493         <~scoped_switch_fork_info>: Fix incorrect variable name.
10494
10495 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10496
10497         * linux-fork.c (scoped_switch_fork_info)
10498         <scoped_switch_fork_info>: Make explicit.
10499         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10500
10501 2019-01-10  Tom Tromey  <tom@tromey.com>
10502
10503         * objfiles.h (objfile::reset_psymtabs): Update.
10504         * objfiles.c (objfile::objfile): Update.
10505         * psymtab.h (psymtab_storage::obstack): Update.
10506         (psymtab_storage::m_obstack): Use gdb::optional.
10507         (class psymtab_storage): Update comment.  Remove objfile
10508         parameter.
10509         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10510
10511 2019-01-10  Tom Tromey  <tom@tromey.com>
10512
10513         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10514         <free_psymtabs>: Now private.
10515         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10516         (allocate_psymtab): Use new method.
10517
10518 2019-01-10  Tom Tromey  <tom@tromey.com>
10519
10520         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10521         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10522         * mdebugread.c (parse_partial_symbols): Use
10523         allocate_dependencies.
10524         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10525         allocate_dependencies.
10526         (process_psymtab_comp_unit_reader)
10527         (build_type_psymtab_dependencies): Likewise.
10528         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10529
10530 2019-01-10  Tom Tromey  <tom@tromey.com>
10531
10532         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10533         PSYMBOL_SET_LANGUAGE.
10534         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10535
10536 2019-01-10  Tom Tromey  <tom@tromey.com>
10537
10538         * psymtab.h (psymtab_storage::obstack): New method.
10539         <m_obstack>: Rename from obstack; now private.
10540         * psymtab.c (psymtab_storage): Update.
10541         * dwarf2read.c (create_addrmap_from_index)
10542         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10543         Update.
10544
10545 2019-01-10  Tom Tromey  <tom@tromey.com>
10546
10547         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10548         * objfiles.h (objfile::reset_psymtabs): New method.
10549
10550 2019-01-10  Tom Tromey  <tom@tromey.com>
10551
10552         * symmisc.c (print_symbol_bcache_statistics): Update.
10553         (print_objfile_statistics): Update.
10554         * symfile.c (reread_symbols): Update.
10555         * psymtab.h (class psymtab_storage): New.
10556         * psymtab.c (psymtab_storage): New constructor.
10557         (~psymtab_storage): New destructor.
10558         (require_partial_symbols): Update.
10559         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10560         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10561         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10562         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10563         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10564         (start_psymtab_common, end_psymtab_common)
10565         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10566         (allocate_psymtab): Update.
10567         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10568         Update.
10569         (dump_psymtab_addrmap, maintenance_print_psymbols)
10570         (maintenance_check_psymtabs): Update.
10571         (class objfile_psymtabs): Move to objfiles.h.
10572         * psympriv.h (discard_psymtab): Now inline.
10573         (psymtab_discarder::psymtab_discarder): Update.
10574         (psymtab_discarder::~psymtab_discarder): Update.
10575         (ALL_OBJFILE_PSYMTABS): Rewrite.
10576         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10577         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10578         Remove fields.
10579         <partial_symtabs>: New field.
10580         (class objfile_psymtabs): Move from psymtab.h.  Update.
10581         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10582         psymbol_cache.
10583         (objfile::~objfile): Don't destroy psymbol_cache.
10584         * mdebugread.c (parse_partial_symbols): Update.
10585         * dwarf2read.c (create_addrmap_from_index)
10586         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10587         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10588         (add_partial_subprogram, dwarf2_ranges_read): Update.
10589         * dwarf-index-write.c (write_address_map)
10590         (write_one_signatured_type, recursively_write_psymbols)
10591         (class debug_names, class debug_names, write_psymtabs_to_index):
10592         Update.
10593
10594 2019-01-10  Tom Tromey  <tom@tromey.com>
10595
10596         * symtab.h (SYMBOL_SET_NAMES): Update.
10597         (symbol_set_names): Update.
10598         (MSYMBOL_SET_NAMES): Update.
10599         * symtab.c (symbol_set_names): Change argument to be an
10600         objfile_per_bfd_storage.
10601         * psymtab.c (add_psymbol_to_bcache): Update.
10602         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10603
10604 2019-01-10  Tom Tromey  <tom@tromey.com>
10605
10606         * symtab.c (create_demangled_names_hash): Change argument to be an
10607         objfile_per_bfd_storage.
10608         (symbol_set_names): Update.
10609
10610 2019-01-10  Tom Tromey  <tom@tromey.com>
10611
10612         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10613         init_psymbol_list.
10614         * psymtab.c (init_psymbol_list): Do nothing if already called.
10615         * psympriv.h (init_psymbol_list): Add comment.
10616         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10617         init_psymbol_list.
10618         * dbxread.c (dbx_symfile_read): Unconditionally call
10619         init_psymbol_list.
10620
10621 2019-01-10  Tom Tromey  <tom@tromey.com>
10622
10623         * xcoffread.c (scan_xcoff_symtab): Update.
10624         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10625         "where".
10626         * mdebugread.c (parse_partial_symbols)
10627         (handle_psymbol_enumerators): Update.
10628         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10629         * dbxread.c (read_dbx_symtab): Update.
10630         * psympriv.h (psymbol_placement): New enum.
10631         (add_psymbol_to_list): Update.
10632
10633 2019-01-10  Tom Tromey  <tom@tromey.com>
10634
10635         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10636         static_psymbols parameters.
10637         (scan_xcoff_symtab): Update.
10638         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10639         static_psymbols parameters.
10640         * psympriv.h (start_psymtab_common): Update.
10641         * mdebugread.c (parse_partial_symbols): Update.
10642         * dwarf2read.c (create_partial_symtab): Update.
10643         * dbxread.c (read_dbx_symtab): Update.
10644         (start_psymtab): Remove global_psymbols and static_psymbols
10645         parameters.
10646
10647 2019-01-10  Tom Tromey  <tom@tromey.com>
10648
10649         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10650         * psymtab.c (allocate_psymtab): Add comment.
10651         * psympriv.h (allocate_psymtab): Add comment.
10652         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10653         initializations.
10654         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10655
10656 2019-01-10  Tom Tromey  <tom@tromey.com>
10657
10658         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10659         Don't declare.
10660         * mipsread.c: Include mdebugread.h.
10661         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10662         Declare.
10663         * elfread.c: Include mdebugread.h.
10664
10665 2019-01-09  Tom Tromey  <tom@tromey.com>
10666
10667         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10668         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10669         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10670         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10671         (psym_lookup_symbol, psym_find_last_source_symtab)
10672         (psym_forget_cached_source_info, psym_print_stats)
10673         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10674         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10675         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10676         (psym_find_compunit_symtab_by_address)
10677         (maintenance_print_psymbols, maintenance_info_psymtabs)
10678         (maintenance_check_psymtabs): Use ranged for.
10679         * psymtab.h (class objfile_psymtabs): New.
10680         (require_partial_symbols): Return objfile_psymtabs.
10681         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10682
10683 2019-01-09  Tom Tromey  <tom@tromey.com>
10684
10685         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10686         (find_pc_mapped_section, list_overlays_command)
10687         (map_overlay_command, unmap_overlay_command)
10688         (simple_overlay_update): Use all_objfiles.
10689         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10690         * printcmd.c (info_symbol_command): Use all_objfiles.
10691         * objfiles.h (ALL_OBJSECTIONS): Remove.
10692         * maint.c (maintenance_translate_address): Use all_objfiles.
10693         * gcore.c (gcore_create_callback): Use all_objfiles.
10694         (objfile_find_memory_regions): Likewise.
10695
10696 2019-01-09  Tom Tromey  <tom@tromey.com>
10697
10698         * symtab.c (find_line_symtab, info_sources_command)
10699         (make_source_files_completion_list): Use objfile_compunits.
10700         * source.c (select_source_symtab): Use objfile_compunits.
10701         * objfiles.h (struct objfile): Update comment.
10702         (ALL_OBJFILES): Remove.
10703         (ALL_FILETABS): Remove.
10704         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10705         objfile_compunits.
10706
10707 2019-01-09  Tom Tromey  <tom@tromey.com>
10708
10709         * symmisc.c (print_objfile_statistics, dump_objfile)
10710         (maintenance_print_symbols): Use compunit_filetabs.
10711         * source.c (forget_cached_source_info_for_objfile): Use
10712         compunit_filetabs.
10713         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10714         (ALL_FILETABS): Use compunit_filetabs.
10715         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10716         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10717
10718 2019-01-09  Tom Tromey  <tom@tromey.com>
10719
10720         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10721         (compunit_filetabs): New.
10722         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10723         compunit_filetabs.
10724         (info_sources_command, make_source_files_completion_list): Remove
10725         declaration.
10726         * symmisc.c (print_objfile_statistics, dump_objfile)
10727         (maintenance_print_symbols): Remove declaration.
10728         (maintenance_info_symtabs): Use compunit_filetabs.
10729         (maintenance_info_line_tables): Likewise.
10730         * source.c (select_source_symtab): Change local variable name.
10731         (forget_cached_source_info_for_objfile): Remove declaration.
10732         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10733         * objfiles.c (objfile_relocate1): Remove declaration.
10734         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10735         declaration.
10736         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10737         * coffread.c (coff_symtab_read): Remove declaration.
10738         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10739         compunit_filetabs.
10740
10741 2019-01-09  Tom Tromey  <tom@tromey.com>
10742
10743         * symtab.c (lookup_objfile_from_block)
10744         (find_pc_sect_compunit_symtab, search_symbols)
10745         (default_collect_symbol_completion_matches_break_on): Use
10746         objfile_compunits.
10747         * objfiles.h (ALL_COMPUNITS): Remove.
10748         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10749         * cp-support.c (add_symbol_overload_list_qualified): Use
10750         objfile_compunits.
10751         * ada-lang.c (ada_collect_symbol_completion_matches)
10752         (ada_add_global_exceptions): Use objfile_compunits.
10753
10754 2019-01-09  Tom Tromey  <tom@tromey.com>
10755
10756         * source.c (select_source_symtab)
10757         (forget_cached_source_info_for_objfile): Remove declaration.
10758         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10759         declaration.
10760         * maint.c (count_symtabs_and_blocks): Remove declaration.
10761         * cp-support.c (add_symbol_overload_list_qualified): Remove
10762         declaration.
10763         * coffread.c (coff_symtab_read): Remove declaration.
10764         * symtab.c (lookup_symbol_in_objfile_symtabs)
10765         (basic_lookup_transparent_type_1): Use objfile_compunits.
10766         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10767         (info_sources_command, search_symbols)
10768         (default_collect_symbol_completion_matches_break_on)
10769         (make_source_files_completion_list): Remove declaration.
10770         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10771         (ada_collect_symbol_completion_matches)
10772         (ada_add_global_exceptions): Remove declaration.
10773         * linespec.c (iterate_over_all_matching_symtabs): Use
10774         objfile_compunits.
10775         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10776         (class objfile_compunits): New.
10777         (ALL_COMPUNITS): Use objfile_compunits.
10778         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10779         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10780         objfile_compunits.
10781         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10782
10783 2019-01-09  Tom Tromey  <tom@tromey.com>
10784
10785         * symtab.c (search_symbols)
10786         (default_collect_symbol_completion_matches_break_on): Use
10787         objfile_msymbols.
10788         * ada-lang.c (ada_lookup_simple_minsym)
10789         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10790         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10791         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10792         objfile_msymbols.
10793         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10794         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10795         * objc-lang.c (find_methods): Use objfile_msymbols.
10796         (info_selectors_command, info_classes_command): Likewise.
10797         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10798         * objfiles.h (class objfile_msymbols): New.
10799         (ALL_OBJFILE_MSYMBOLS): Remove.
10800         (ALL_MSYMBOLS): Remove.
10801
10802 2019-01-09  Tom Tromey  <tom@tromey.com>
10803
10804         * common/next-iterator.h (next_adapter): Add Iterator template
10805         parameter.
10806         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10807         (class all_objfiles_safe): New.
10808         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10809         * objfiles.c (put_objfile_before): Update comment.
10810         (add_separate_debug_objfile): Likewise.
10811         (free_all_objfiles): Use all_objfiles_safe.
10812         (objfile_purge_solibs): Likewise.
10813
10814 2019-01-09  Tom Tromey  <tom@tromey.com>
10815
10816         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10817         (expand_symtab_containing_pc, lookup_static_symbol)
10818         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10819         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10820         all_objfiles.
10821         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10822         * breakpoint.c (create_overlay_event_breakpoint)
10823         (create_longjmp_master_breakpoint)
10824         (create_std_terminate_master_breakpoint)
10825         (create_exception_master_breakpoint): Use all_objfiles.
10826         * linux-thread-db.c (try_thread_db_load_from_pdir)
10827         (has_libpthread): Use all_objfiles.
10828         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10829         * linespec.c (iterate_over_all_matching_symtabs)
10830         (search_minsyms_for_name): Use all_objfiles.
10831         * maint.c (maintenance_info_sections): Use all_objfiles.
10832         * main.c (captured_main_1): Use all_objfiles.
10833         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10834         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10835         * guile/scm-pretty-print.c
10836         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10837         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10838         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10839         (maintenance_print_msymbols): Use all_objfiles.
10840         * source.c (select_source_symtab): Use all_objfiles.
10841         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10842         * symfile.c (remove_symbol_file_command)
10843         (expand_symtabs_matching, map_symbol_filenames): Use
10844         all_objfiles.
10845         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10846         all_objfiles.
10847         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10848         * objc-lang.c (find_methods): Use all_objfiles.
10849         * objfiles.c (have_partial_symbols, have_full_symbols)
10850         (have_minimal_symbols, qsort_cmp)
10851         (default_iterate_over_objfiles_in_search_order): Use
10852         all_objfiles.
10853         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10854         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10855         (maintenance_check_psymtabs): Use all_objfiles.
10856         (ALL_PSYMTABS): Remove.
10857         * compile/compile-object-run.c (do_module_cleanup): Use
10858         all_objfiles.
10859         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10860         * cp-support.c (add_symbol_overload_list_qualified): Use
10861         all_objfiles.
10862         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10863         Use all_objfiles.
10864         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10865         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10866         all_objfiles.
10867         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10868         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10869         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10870         Uses all_objfiles.
10871         * solib.c (solib_read_symbols): Use all_objfiles
10872
10873 2019-01-09  Tom Tromey  <tom@tromey.com>
10874
10875         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10876         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10877         all_objfiles.
10878         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10879         * symmisc.c (print_symbol_bcache_statistics)
10880         (print_objfile_statistics, maintenance_print_objfiles)
10881         (maintenance_info_symtabs, maintenance_check_symtabs)
10882         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10883         all_objfiles.
10884         * source.c (forget_cached_source_info): Use all_objfiles.
10885         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10886         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10887         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10888         * objfiles.c (update_section_map): Use all_objfiles.
10889         (shared_objfile_contains_address_p): Likewise.
10890         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10891         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10892
10893 2019-01-09  Tom Tromey  <tom@tromey.com>
10894
10895         * common/next-iterator.h: New file.
10896         * objfiles.h (class all_objfiles): New.
10897         (struct objfile_iterator): New.
10898
10899 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10900
10901         * NEWS: Move the description of the changed "frame", "select-frame",
10902          and "info frame" commands to the Changed commands section.
10903
10904 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10905
10906         * gdbtypes.c (check_stub_method_group): Remove handling of old
10907         mangling schemes.
10908         * linespec.c (find_methods): Likewise.
10909         * stabsread.c (read_member_functions): Likewise.
10910         * valops.c (search_struct_method): Likewise.
10911         (value_struct_elt_for_reference): Likewise.
10912         * NEWS: Mention this change.
10913
10914 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10915
10916         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10917         print_source_lines.
10918         * source.c (print_source_lines_base): Update line number check.
10919         (print_source_lines): New function.
10920         (source_lines_range::source_lines_range): New function.
10921         * source.h (class source_lines_range): New class.
10922         (print_source_lines): New declaration.
10923
10924 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10925
10926         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10927
10928 2019-01-08  Tom Tromey  <tom@tromey.com>
10929             Simon Marchi  <simon.marchi@ericsson.com>
10930
10931         PR gdb/24060
10932         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10933         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10934         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10935         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10936         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10937         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10938
10939 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10940
10941         * source.c (select_source_symtab): Move header comment to
10942         declaration in source.h.
10943         (forget_cached_source_info_for_objfile): Likewise.
10944         (forget_cached_source_info): Likewise.
10945         (identify_source_line): Likewise.
10946         * source.h (identify_source_line): Move declaration from symtab.h
10947         and add comment from source.c
10948         (print_source_lines): Likewise.
10949         (forget_cached_source_info_for_objfile): Likewise.
10950         (forget_cached_source_info): Likewise.
10951         (select_source_symtab): Likewise.
10952         (enum print_source_lines_flag): Move definition from symtab.h.
10953         * symtab.h (identify_source_line): Move declaration to source.h.
10954         (print_source_lines): Likewise.
10955         (forget_cached_source_info_for_objfile): Likewise.
10956         (forget_cached_source_info): Likewise.
10957         (select_source_symtab): Likewise.
10958         (enum print_source_lines_flag): Move definition to source.h.
10959         * tui/tui-hooks.c: Add 'source.h' include.
10960
10961 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10962
10963         * source.c (print_source_lines_base): Handle requests to print
10964         reverse line number sequences, and guard against empty lines
10965         string.
10966
10967 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10968
10969         * source.c (print_source_lines_base): Fix skip of '\r' if next
10970         character is '\n'.
10971
10972 2019-01-06  Tom Tromey  <tom@tromey.com>
10973
10974         * c-exp.y (struct c_parse_state) <macro_original_text,
10975         expansion_obstack>: New member.
10976         (macro_original_text, expansion_obstack): Remove globals.
10977         (scan_macro_expansion, scanning_macro_expansion)
10978         (finished_macro_expansion): Update.
10979         (scan_macro_cleanup): Remove.
10980         (yylex, c_parse): Update.
10981
10982 2019-01-06  Tom Tromey  <tom@tromey.com>
10983
10984         * c-exp.y (struct c_parse_state) <strings>: New member.
10985         (operator_stoken): Update.
10986
10987 2019-01-06  Tom Tromey  <tom@tromey.com>
10988
10989         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10990         (union type_stack_elt) <typelist_val>: Now a pointer to
10991         std::vector.
10992         (type_stack_cleanup): Don't declare.
10993         (push_typelist): Update.
10994         * parse.c (pop_typelist): Return a std::vector.
10995         (push_typelist): Take a std::vector.
10996         (follow_types): Update.  Do not free args.
10997         (type_stack_cleanup): Remove.
10998         * c-exp.y (struct c_parse_state): New.
10999         (cpstate): New global.
11000         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11001         (nonempty_typelist): Update.
11002         (func_mod): Create a new vector.
11003         (c_parse): Create a c_parse_state.
11004         (check_parameter_typelist): Do not delete params.
11005         (function_method): Update.  Do not delete type_list.
11006
11007 2019-01-06  Tom Tromey  <tom@tromey.com>
11008
11009         PR gdb/28155:
11010         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11011         check_typedef.
11012         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11013         (print_return_value): Likewise.
11014
11015 2019-01-05  Tom Tromey  <tom@tromey.com>
11016
11017         * contrib/cleanup_check.py: Remove.
11018         * contrib/gcc-with-excheck: Remove.
11019         * contrib/exsummary.py: Remove.
11020         * contrib/excheck.py: Remove.
11021
11022 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11023
11024         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11025         NULL. Initialize tpprev to NULL instead of assigning it
11026         to NULL on the next statement.
11027         * windows-nat.c (windows_delete_thread): Remove check for
11028         main_thread_id before printing thread exit notifications.
11029         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11030         Remove thread ID check against main_thread_id.
11031         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11032         windows_delete_thread.
11033         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11034
11035 2019-01-04  Tom Tromey  <tom@tromey.com>
11036
11037         * compile/compile.c (_initialize_compile): Use upper case for
11038         metasyntactic variables.
11039         * symmisc.c (_initialize_symmisc): Use upper case for
11040         metasyntactic variables.
11041         * psymtab.c (_initialize_psymtab): Use upper case for
11042         metasyntactic variables.
11043         * demangle.c (demangle_command): Use upper case for metasyntactic
11044         variables.
11045         (_initialize_demangler): Likewise.
11046         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11047         variables.
11048
11049 2019-01-03  Tom Tromey  <tom@tromey.com>
11050
11051         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11052
11053 2019-01-03  Tom Tromey  <tom@tromey.com>
11054
11055         * python/py-symtab.c (salpy_str): Update.
11056         (struct salpy_sal_object) <symtab>: Now a PyObject.
11057         (salpy_dealloc): Update.
11058         (del_objfile_sal): Use gdbpy_ref.
11059
11060 2019-01-03  Tom Tromey  <tom@tromey.com>
11061
11062         * python/py-type.c (convert_field): Use new_reference.  Return
11063         gdbpy_ref.
11064         (make_fielditem): Return gdbpy_ref.
11065         (typy_fields): Update.
11066         (typy_getitem): Update.
11067         (field_name): Return gdbpy_ref.  Use new_reference.
11068         (typy_iterator_iternext): Update.
11069
11070 2019-01-03  Tom Tromey  <tom@tromey.com>
11071
11072         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11073
11074 2019-01-03  Tom Tromey  <tom@tromey.com>
11075
11076         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11077         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11078         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11079         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11080         (pspy_set_type_printers): Likewise.
11081         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11082         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11083         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11084         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11085         (objfpy_set_type_printers): Likewise.
11086
11087 2019-01-03  Tom Tromey  <tom@tromey.com>
11088
11089         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11090         (gdbpy_print_stack): Use gdbpy_err_fetch.
11091         * python/python-internal.h (class gdbpy_err_fetch): New class.
11092         (class gdbpy_enter) <m_error_type, m_error_value,
11093         m_error_traceback>: Remove.
11094         <m_error>: New member.
11095         (gdbpy_exception_to_string): Don't declare.
11096         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11097         * python/py-value.c (convert_value_from_python): Use
11098         gdbpy_err_fetch.
11099         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11100         gdbpy_exception_to_string.
11101         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11102         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11103         gdbpy_err_fetch.
11104
11105 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11106
11107         * linux-nat.c (delete_lwp_cleanup): Delete.
11108         (struct lwp_deleter): New struct.
11109         (lwp_info_up): New typedef.
11110         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11111         lwp_info_up.
11112
11113 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11114
11115         * linux-fork.c (class scoped_switch_fork_info): New class.
11116         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11117
11118 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11119
11120         * valops.c (find_overload_match): Remove use of null_cleanup, and
11121         calls to do_cleanups.
11122
11123 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11124
11125         * compile/compile-cplus-types.c
11126         (compile_cplus_instance::decl_name): Handle changes to
11127         cp_func_name.
11128         * cp-support.c (cp_func_name): Update header comment, update
11129         return type.
11130         * cp-support.h (cp_func_name): Update return type in declaration.
11131         * valops.c (find_overload_match): Move temp_func local to top
11132         level of function and change its type.  Use temp_func to hold and
11133         delete temporary string obtained from cp_func_name.
11134
11135 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11136
11137         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11138         gdb::char_vector, remove cleanup, and update uses of `msg`.
11139
11140 2019-01-03  Jim Wilson  <jimw@sifive.com>
11141
11142         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11143
11144 2019-01-02  Tom Tromey  <tom@tromey.com>
11145
11146         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11147         (tdesc_parse_xml): Remove cleanups.
11148         * target-descriptions.h (make_cleanup_free_target_description):
11149         Don't declare.
11150         (target_desc_deleter): New struct.
11151         (target_desc_up): New typedef.
11152         * target-descriptions.c (target_desc_deleter::operator()): Rename
11153         from free_target_description.
11154         (make_cleanup_free_target_description): Remove.
11155
11156 2019-01-02  Tom Tromey  <tom@tromey.com>
11157
11158         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11159         constructor, destructor.
11160         (linespec_parser): Remove typedef.
11161         (~linespec_parser): Rename from linespec_parser_delete.
11162         (linespec_lex_to_end, linespec_complete_label)
11163         (linespec_complete): Update.
11164         (decode_line_full): Remove cleanups.
11165         (decode_line_1): Update.
11166
11167 2019-01-02  Tom Tromey  <tom@tromey.com>
11168
11169         * python/python-internal.h (inferior_to_inferior_object): Change
11170         return type.
11171         * python/py-exitedevent.c (create_exited_event_object): Update.
11172         * python/py-inferior.c (inferior_to_inferior_object): Return
11173         gdbpy_ref.
11174         (python_new_inferior, python_inferior_deleted)
11175         (thread_to_thread_object, delete_thread_object)
11176         (build_inferior_list, gdbpy_selected_inferior): Update.
11177         * python/py-infthread.c (create_thread_object): Update.  Also fail
11178         if inferior_to_inferior_object fails.
11179
11180 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11181
11182         * inferior.h (class inferior) <displaced_step_state>: New field.
11183         * infrun.h (struct displaced_step_state): Move here from
11184         infrun.c.  Initialize fields, add constructor.
11185         <inf>: Remove field.
11186         <reset>: New method.
11187         * infrun.c (struct displaced_step_inferior_state): Move to
11188         infrun.h.
11189         (displaced_step_inferior_states): Remove.
11190         (get_displaced_stepping_state): Adust.
11191         (displaced_step_in_progress_any_inferior): Adjust.
11192         (displaced_step_in_progress_thread): Adjust.
11193         (displaced_step_in_progress): Adjust.
11194         (add_displaced_stepping_state): Remove.
11195         (get_displaced_step_closure_by_addr): Adjust.
11196         (remove_displaced_stepping_state): Remove.
11197         (infrun_inferior_exit): Call displaced_step_state.reset.
11198         (use_displaced_stepping): Don't check for NULL.
11199         (displaced_step_prepare_throw): Call
11200         get_displaced_stepping_state.
11201         (displaced_step_fixup): Don't check for NULL.
11202         (prepare_for_detach): Don't check for NULL.
11203
11204 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11205
11206         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11207          in case of call that did not complete.
11208
11209 2019-01-02  Andrey Utkin  <autkin@undo.io>
11210
11211         * symfile.c (find_separate_debug_file): Fix search of debug files for
11212         remote debuggee.
11213
11214 2019-01-02  Tom Tromey  <tom@tromey.com>
11215
11216         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11217         indentation.
11218         * python/py-frame.c (frapy_older): Remove cast.
11219         (frapy_newer): Likewise.
11220         * python/py-breakpoint.c (local_setattro): Remove cast.
11221         * python/py-arch.c (archpy_name): Remove local variable.
11222         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11223
11224 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11225
11226         * unittests/basic_string_view/element_access/char/empty.cc:
11227         Fix year range in copyright header.
11228
11229 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11230
11231         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11232         Delete.
11233         <operator==>: Update with for removed field.
11234         <hash>: Likewise.
11235         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11236         <isa_features>: ...this.
11237         <abi_features>: New field.
11238         (riscv_isa_flen): Update comment.
11239         (riscv_abi_xlen): New declaration.
11240         (riscv_abi_flen): New declaration.
11241         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11242         isa_features.
11243         (riscv_abi_xlen): New function.
11244         (riscv_isa_flen): Update to get answer from isa_features.
11245         (riscv_abi_flen): New function.
11246         (riscv_has_fp_abi): Update to get answer from abi_features.
11247         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11248         xlen and flen.
11249         (riscv_call_info) <xlen, flen>: Update comment.
11250         (riscv_call_arg_struct): Remove invalid assertions
11251         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11252         is removed.
11253         (riscv_gdbarch_init): Gather isa features and abi features
11254         separately, ensure both match on the gdbarch when reusing an old
11255         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11256         a target with 64-bit float hardware.
11257
11258 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11259
11260         * source.c (search_command_helper): Stop reverse search
11261         when line 1 has been searched.
11262
11263 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11264
11265         * record-full.c (record_full_base_target::close): Rewrite
11266         record_full_core_buf_list free logic.
11267
11268 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11269
11270         * break-catch-syscall.c (print_one_catch_syscall): xfree
11271         the last text.
11272
11273 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11274
11275         * top.c (print_gdb_version): Update Copyright year in version
11276         message.
11277
11278 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11279
11280         Update copyright year range in all GDB files.
11281
11282 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11283
11284         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11285
11286 For older changes see ChangeLog-2018.
11287 \f
11288 Local Variables:
11289 mode: change-log
11290 left-margin: 8
11291 fill-column: 74
11292 version-control: never
11293 coding: utf-8
11294 End:
11295