gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
   4         call touchwin.
   5
   6 2019-08-30  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-wingeneral.c (box_win): Assume win_info and
   9         win_info->handle cannot be NULL.
  10
  11 2019-08-30  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
  14         refresh_window>: Declare.
  15         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
  16         resize.
  17         (tui_data_item_window::rerender): Rename from
  18         tui_display_register.
  19         (tui_data_item_window::refresh_window): New method.
  20         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
  21         no-op.
  22
  23 2019-08-30  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-regs.h (struct tui_data_window) <regs_content,
  26         regs_column_count, current_group>: Move later.  Now private.
  27         <get_current_group>: New method.
  28         * tui/tui-regs.c (tui_reg_command): Update.
  29         * tui/tui-layout.c (tui_set_layout): Update.
  30
  31 2019-08-30  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  34         (tui_data_window::rerender): Don't call
  35         check_and_display_highlight_if_needed.
  36         (tui_data_window::refresh_all): Remove call to
  37         erase_data_content.
  38
  39 2019-08-30  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  42         (tui_data_window::display_registers_from)
  43         (tui_data_window::display_reg_element_at_line)
  44         (tui_data_window::display_registers_from_line): Remove checks of
  45         "empty".
  46
  47 2019-08-30  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
  50         Don't declare.
  51         * tui/tui-regs.c (tui_data_window::show_registers): Call
  52         rerender.
  53         (tui_data_window::rerender): Rename from display_all_data.
  54         (tui_data_window::rerender): Remove old implementation.
  55
  56 2019-08-30  Tom Tromey  <tom@tromey.com>
  57
  58         * tui/tui-regs.c (tui_data_window::display_all_data): Change
  59         text.
  60         * tui/tui-data.h (NO_DATA_STRING): Remove define.
  61
  62 2019-08-29  Bernhard Wodok  <barto@gmx.net>
  63             Sergio Durigan Junior  <sergiodj@redhat.com>
  64
  65         PR win32/24284
  66         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
  67
  68 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  69
  70         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
  71         when searching for types.
  72
  73 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  74
  75         * f-lang.c (f_language_defn): Use f_print_typedef.
  76         * f-lang.h (f_print_typedef): Declare.
  77         * f-typeprint.c (f_print_typedef): Define.
  78
  79 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
  80
  81         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
  82
  83 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  84
  85         * cli/cli-utils.c (info_print_options_defs): Delete.
  86         (make_info_print_options_def_group): Delete.
  87         (extract_info_print_options): Delete.
  88         (info_print_command_completer): Delete.
  89         (info_print_args_help): Add extra parameter, and optionally
  90         include text about -n flag.
  91         * cli/cli-utils.h (struct info_print_options): Delete.
  92         (extract_info_print_options): Delete declaration.
  93         (info_print_command_completer): Delete declaration.
  94         (info_print_args_help): Add extra parameter, extend header
  95         comment.
  96         * python/python.c (gdbpy_rbreak): Pass additional parameter to
  97         search_symbols.
  98         * stack.c (struct info_print_options): New type.
  99         (info_print_options_defs): New file scoped variable.
 100         (make_info_print_options_def_group): New static function.
 101         (info_print_command_completer): New static function.
 102         (info_locals_command): Update to use new local functions.
 103         (info_args_command): Likewise.
 104         (_initialize_stack): Add extra parameter to calls to
 105         info_print_args_help.
 106         * symtab.c (search_symbols): Add extra parameter, use this to
 107         possibly excluse non-debug symbols.
 108         (symtab_symbol_info): Add extra parameter, which is passed on to
 109         search_symbols.
 110         (struct info_print_options): New type.
 111         (info_print_options_defs): New file scoped variable.
 112         (make_info_print_options_def_group): New static function.
 113         (info_print_command_completer): New static function.
 114         (info_variables_command): Update to use local functions, and pass
 115         extra parameter through to symtab_symbol_info.
 116         (info_functions_command): Likewise.
 117         (info_types_command): Pass additional argument through to
 118         symtab_symbol_info.
 119         (rbreak_command): Pass extra argument to search_symbols.
 120         (_initialize_symtab): Add extra arguments for calls to
 121         info_print_args_help, and update help text for 'info variables',
 122         'whereis', and 'info functions' commands.
 123         * symtab.h (search_symbols): Add extra argument to declaration.
 124         * NEWS: Mention new flags.
 125
 126 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 127
 128         * symtab.c (lookup_static_symbol): Call the new function (and move
 129         it down to be next to lookup_global_symbol).
 130         (struct global_sym_lookup_data): Add block_enum member and rename to...
 131         (struct global_or_static_sym_lookup_data): ...this.
 132         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 133         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 134         (lookup_symbol_global_or_static_iterator_cb): ...this.
 135         (lookup_global_or_static_symbol): New function.
 136         (lookup_global_symbol): Call new function.
 137
 138 2019-08-26  Tom de Vries  <tdevries@suse.de>
 139
 140         PR c++/24852
 141         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 142         when pc_probe.prob == NULL.
 143
 144 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 145
 146         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 147         variable symbol_linkage to symbol_linkage_.
 148
 149 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 150
 151         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 152         represent whether the symbol is static, dynamic, or we don't
 153         know.
 154
 155 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 156
 157         * gdb/rx-tdep.c (rx_register_names): New.
 158         (rx_register_name): Delete.
 159         (rx_psw_type): Delete.
 160         (rx_fpsw_type): Delete.
 161         (rx_register_type): Delete.
 162         (rx_gdbarch_init): Convert target-descriptions.
 163         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 164         * gdb/features/Makefile: Add rx.xml.
 165         * gdb/features/rx.xml: New.
 166         * gdb/features/rx.c: Generated.
 167         * gdb/NEWS: Mention target description support.
 168
 169 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 170
 171         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 172         *slot_ptr.
 173
 174 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 175
 176         * configure.ac: Don't check for 'dlfcn.h' (moved to
 177         gdbsupport/common.m4).
 178         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 179         'gdbsupport/'.
 180         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 181         * compile/compile-c-support.c: Include
 182         'gdbsupport/gdb-dlfcn.h'.
 183         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 184         * gdb-dlfcn.c: Move to...
 185         * gdbsupport/gdb-dlfcn.c: ... here.
 186         * gdb-dlfcn.h: Move to...
 187         * gdbsupport/gdb-dlfcn.h: ... here.
 188
 189 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 190
 191         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 192         the offset field signed.
 193
 194 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 195
 196         * python/lib/gdb/__init__.py (_execute_file): New function.
 197         * python/python.c (python_run_simple_file): Call gdb._execute_file
 198         on Windows.
 199
 200 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 201
 202         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 203         all uses as this was never set to anything but a zero value.
 204
 205 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 206
 207         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 208
 209 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 210
 211         * tui/tui-data.h (tui_gen_win_info): Add an =default
 212         move constructor, required by some GCC versions.
 213
 214 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 215
 216         * go32-nat.c (go32_sysinfo): Add hygon_p.
 217
 218 2019-08-20  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 221         line_from_reg_element_no, first_reg_element_no_inline,
 222         display_all_data, delete_data_content_windows,
 223         erase_data_content>: Now private.
 224
 225 2019-08-20  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 228         (tui_unhighlight_win, tui_highlight_win)
 229         (tui_win_info::make_window): Update.
 230         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 231
 232 2019-08-20  Tom Tromey  <tom@tromey.com>
 233
 234         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 235         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 236         (MAX_PID_WIDTH): Move to tui-stack.c.
 237         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 238         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 239         (MAX_PID_WIDTH): Move from tui-data.h.
 240
 241 2019-08-20  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 244         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 245         (box_win): Update.
 246         (tui_gen_win_info::make_window): Rename from tui_make_window.
 247         (tui_win_info::make_window): New method.
 248         (tui_gen_win_info::make_visible): Update.
 249         * tui/tui-source.c (tui_source_window::set_contents): Update.
 250         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 251         (tui_data_window::display_registers_from): Update.
 252         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 253         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 254         Declare.
 255         <can_box>: Remove.
 256         <title>: Remove.
 257         (struct tui_win_info) <make_window>: Declare.
 258         <can_box>: Now virtual.
 259         <title>: New member.
 260         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 261         * tui/tui-command.c (tui_cmd_window::resize): Update.
 262
 263 2019-08-20  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 266         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 267         (tui_data_window::check_register_values): Update.
 268
 269 2019-08-20  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-regs.h (struct tui_data_window): Use
 272         DISABLE_COPY_AND_ASSIGN.
 273         <regs_content>: Change type, removing unique_ptr.
 274         <tui_data_window>: Add move constructor.
 275         * tui/tui-regs.c (tui_data_window::show_registers)
 276         (tui_data_window::show_register_group)
 277         (tui_data_window::display_registers_from)
 278         (tui_data_window::display_registers_from)
 279         (tui_data_window::first_data_item_displayed)
 280         (tui_data_window::delete_data_content_windows)
 281         (tui_data_window::rerender, tui_data_window::refresh_window)
 282         (tui_data_window::check_register_values): Update.
 283
 284 2019-08-20  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 287         show_register_group>: Declare.
 288         (tui_show_register_group): Don't declare.
 289         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 290         tui_show_registers.
 291         (tui_data_window::show_register_group): Rename from
 292         tui_show_register_group.
 293         (tui_data_window::check_register_values, tui_reg_command):
 294         Update.
 295         * tui/tui-layout.c (tui_set_layout): Update.
 296
 297 2019-08-20  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 300         Declare.
 301         (tui_check_register_values): Don't declare.
 302         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 303         from tui_check_register_values.
 304         * tui/tui-hooks.c (tui_register_changed): Update.
 305
 306 2019-08-20  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-regs.c (tui_reg_layout): Move later.
 309         (tui_show_registers): Don't enable TUI mode or change layout.
 310
 311 2019-08-20  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-regs.h (struct tui_data_item_window)
 314         <~tui_data_item_window>: Remove.
 315         <content>: Now a unique_xmalloc_ptr.
 316         * tui/tui-regs.c (tui_register_format): Return a
 317         unique_xmalloc_ptr.
 318         (tui_get_register): Update.
 319         (~tui_data_item_window): Remove.
 320         (tui_data_window::display_registers_from, tui_display_register):
 321         Update.
 322         * tui/tui-io.h (tui_expand_tabs): Update.
 323         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 324         Remove "col" parameter.
 325
 326 2019-08-20  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 329         field.
 330         * tui/tui-regs.c (~tui_data_item_window): Update.
 331
 332 2019-08-20  Tom Tromey  <tom@tromey.com>
 333
 334         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 335         earlier.
 336
 337 2019-08-20  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 340
 341 2019-08-20  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-source.h (struct tui_source_window): Update.
 344         * tui/tui-regs.c (tui_show_registers): Update.
 345         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 346         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 347         (NO_REGS_STRING): Remove defines.
 348
 349 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 350
 351         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 352         unnecessary thread walk if remote doesn't support the packet.
 353
 354 2019-08-19  Tom Tromey  <tromey@adacore.com>
 355
 356         * python/py-value.c (value_has_field): Fix indentation.
 357
 358 2019-08-19  Tom Tromey  <tromey@adacore.com>
 359
 360         * printcmd.c (do_one_display, info_display_command): Update.
 361         * block.h (contained_in): Return bool.  Add allow_nested
 362         parameter.
 363         * block.c (contained_in): Return bool.  Add allow_nested
 364         parameter.
 365
 366 2019-08-19  Tom Tromey  <tom@tromey.com>
 367
 368         * configure: Rebuild.
 369         * configure.ac: Disallow the combination of -static-libstdc++ and
 370         source highlight.
 371         * source-cache.c (get_language_name): Handle rust.
 372         (source_cache::get_source_lines): Ignore highlighting exceptions.
 373
 374 2019-08-16  Tom Tromey  <tom@tromey.com>
 375
 376         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 377         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 378         (struct tui_source_window_base) <make_visible, refresh_window,
 379         resize>: Remove methods.
 380         <execution_info>: Remove field.
 381         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 382         (tui_show_source_line, tui_source_window_base)
 383         (~tui_source_window_base): Update.
 384         (tui_source_window_base::resize)
 385         (tui_source_window_base::make_visible)
 386         (tui_source_window_base::refresh_window): Remove.
 387         (tui_source_window_base::update_exec_info): Update.
 388         * tui/tui-source.c (tui_source_window::set_contents): Update.
 389         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 390
 391 2019-08-16  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 394         deprecated_query_hook.
 395
 396 2019-08-16  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 399         (tui_update_source_windows_with_line): Update.
 400         * tui/tui-source.h (struct tui_source_window)
 401         <show_symtab_source>: Declare.
 402         (tui_show_symtab_source): Don't declare.
 403         * tui/tui-source.c (tui_show_symtab_source): Rename from
 404         tui_show_symtab_source.
 405
 406 2019-08-16  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-winsource.h (struct tui_source_window_base)
 409         <set_contents>: Declare.
 410         * tui/tui-winsource.c
 411         (tui_source_window_base::update_source_window_as_is): Update.
 412         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 413         Declare.
 414         (tui_set_source_content): Don't declare.
 415         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 416         tui_set_source_content.
 417         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 418         Declare.
 419         (tui_set_disassem_content): Don't declare.
 420         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 421         tui_set_disassem_content.
 422
 423 2019-08-16  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-winsource.h (struct tui_source_window_base)
 426         <update_breakpoint_info>: Declare.
 427         (tui_update_breakpoint_info): Don't declare.
 428         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 429         (tui_update_all_breakpoint_info): Update.
 430         (tui_source_window_base::update_breakpoint_info): Rename from
 431         tui_update_breakpoint_info.
 432         (tui_source_window_base::update_exec_info): Update.
 433
 434 2019-08-16  Tom Tromey  <tom@tromey.com>
 435
 436         * tui/tui-winsource.h (struct tui_source_window_base)
 437         <update_source_window>: Declare.
 438         (tui_update_source_window): Don't declare.
 439         * tui/tui-winsource.c
 440         (tui_source_window_base::update_source_window): Rename from
 441         tui_update_source_window.
 442         (tui_source_window_base::rerender): Update.
 443         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 444         * tui/tui-disasm.c (tui_show_disassem)
 445         (tui_show_disassem_and_update_source)
 446         (tui_disasm_window::maybe_update): Update.
 447
 448 2019-08-16  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-winsource.h (struct tui_source_window_base)
 451         <update_source_window_as_is>: Declare.
 452         (tui_update_source_window_as_is): Don't declare.
 453         * tui/tui-winsource.c (tui_update_source_window): Update
 454         (tui_source_window_base::update_source_window_as_is): Rename from
 455         tui_update_source_window_as_is.
 456         (tui_source_window_base::refill): Update.
 457         * tui/tui-source.c (tui_show_symtab_source): Update.
 458         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 459         Update.
 460
 461 2019-08-16  Tom Tromey  <tom@tromey.com>
 462
 463         * tui/tui-winsource.h (tui_update_source_window)
 464         (tui_update_source_window_as_is): Remove "noerror" parameter.
 465         * tui/tui-winsource.c (tui_update_source_window)
 466         (tui_update_source_window_as_is): Remove "noerror" parameter.
 467         (tui_update_source_windows_with_addr)
 468         (tui_update_source_windows_with_line)
 469         (tui_source_window_base::rerender)
 470         (tui_source_window_base::refill): Update.
 471         * tui/tui-source.h (tui_set_source_content)
 472         (tui_show_symtab_source): Remove "noerror" parameter.
 473         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 474         parameter.
 475         (tui_show_symtab_source): Likewise.
 476         (tui_source_window::maybe_update): Update.
 477         * tui/tui-disasm.c (tui_show_disassem)
 478         (tui_show_disassem_and_update_source)
 479         (tui_disasm_window::do_scroll_vertical)
 480         (tui_disasm_window::maybe_update): Update.
 481
 482 2019-08-16  Tom Tromey  <tom@tromey.com>
 483
 484         * tui/tui.c (tui_is_window_visible): Update.
 485         * tui/tui-wingeneral.c (tui_make_window)
 486         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 487         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 488         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 489         (tui_set_win_height_command, parse_scrolling_args): Update.
 490         * tui/tui-source.c (tui_source_window::style_changed): Update.
 491         * tui/tui-regs.c (tui_show_registers)
 492         (tui_data_window::first_data_item_displayed)
 493         (tui_data_window::delete_data_content_windows)
 494         (tui_check_register_values, tui_reg_command): Update.
 495         * tui/tui-disasm.c (tui_show_disassem): Update.
 496         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 497         method.
 498         <is_visible>: Remove field.
 499         * tui/tui-data.c (tui_next_win, tui_prev_win)
 500         (tui_delete_invisible_windows): Update.
 501
 502 2019-08-16  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-winsource.h (struct tui_source_window_base)
 505         <m_has_locator>: Remove.
 506         * tui/tui-layout.c (show_source_disasm_command, show_data)
 507         (show_source_or_disasm_and_command): Update.
 508
 509 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 510
 511         * NEWS (Other MI changes): New subsection.
 512         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 513         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 514         * arch-utils.c (default_get_pc_address_flags): New function.
 515         * arch-utils.h (default_get_pc_address_flags): New declaration.
 516         * gdbarch.sh: Add get_pc_address_flags.
 517         * gdbarch.c: Regenerate.
 518         * gdbarch.h: Likewise.
 519         * stack.c (print_pc): New function.
 520         (print_frame_info) (print_frame): Call print_pc.
 521
 522 2019-08-16  Tom de Vries  <tdevries@suse.de>
 523
 524         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 525         print_objfile_section_info.
 526
 527 2019-08-15  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 530         calling update_cmdwin_start_line.
 531         * tui/tui-winsource.h (struct tui_source_window_base)
 532         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 533         <rerender>: Declare.
 534         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 535         Call rerender.
 536         (tui_source_window_base::set_new_height): Remove.
 537         (tui_source_window_base::rerender): Rename from
 538         do_make_visible_with_new_height.
 539         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 540         resize method.
 541         (tui_win_info::make_invisible_and_set_new_height)
 542         (tui_win_info::make_visible_with_new_height): Remove.
 543         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 544         Declare.
 545         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 546         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 547         do_make_visible_with_new_height>: Don't declare.
 548         <rerender>: Declare.
 549         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 550         set_new_height.
 551         (tui_data_window::do_make_visible_with_new_height): Remove.
 552         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 553         call tui_show_locator_content.
 554         (tui_gen_win_info::resize): Call rerender.
 555         (show_source_or_disasm_and_command): Don't call
 556         tui_show_locator_content.
 557         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 558         method.
 559         (struct tui_win_info) <rerender>: Declare.
 560         <set_new_height, make_invisible_and_set_new_height,
 561         make_visible_with_new_height>: Don't declare.
 562         * tui/tui-data.c (tui_win_list::rerender): New method.
 563         * tui/tui-command.h (struct tui_cmd_window)
 564         <do_make_visible_with_new_height>: Don't declare.
 565         * tui/tui-command.c
 566         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 567
 568 2019-08-15  Tom Tromey  <tromey@adacore.com>
 569
 570         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 571         * ada-lang.c (ada_enum_name): Likewise.
 572
 573 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 574
 575         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 576         leading underscore.
 577         (GdbOutputErrorFile): Likewise.
 578         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 579         accordingly.
 580         (execute_unwinders): Rename to have a leading underscore.
 581         (auto_load_packages): Likewise.
 582         (global scope): Adjust call to auto_load_packages accordingly.
 583         (GdbSetPythonDirectory): Likewise.
 584         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 585         instead of execute_unwinders.
 586
 587 2019-08-15  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 590         (show_data): Don't change window visibility.
 591         (tui_gen_win_info::resize): Remove special case for command
 592         window.  Use wresize, when available.
 593         (show_source_or_disasm_and_command): Don't change window
 594         visibility.
 595         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 596         <make_visible>: New method.
 597         * tui/tui-command.c (tui_cmd_window::resize): New method.
 598
 599 2019-08-15  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 602         (struct tui_source_windows): New.
 603         * tui/tui-winsource.c (tui_display_main): Update.
 604         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 605         (new_height_ok, parse_scrolling_args): Update.
 606         * tui/tui-layout.c (show_layout, show_data): Update.
 607         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 608         (tui_add_to_source_windows): Don't declare.
 609         * tui/tui-data.c (source_windows, tui_source_windows)
 610         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 611
 612 2019-08-15  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 615         Rename from reset.
 616         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 617         * tui/tui-layout.c (show_source_disasm_command, show_data):
 618         Update.
 619         (tui_gen_win_info::resize): Rename.
 620         (show_source_or_disasm_and_command): Update.
 621         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 622         reset.
 623
 624 2019-08-15  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 627         * tui/tui-interp.c (tui_interp::init): Don't call
 628         tui_initialize_static_data.
 629         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 630
 631 2019-08-15  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 634         examine tui_win_list.
 635
 636 2019-08-15  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 639         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 640         tui_clear_source_content.
 641         (tui_clear_source_content): Remove.
 642         (tui_source_window_base::do_erase_source_content): Hoist call to
 643         content.clear().
 644         * tui/tui-stack.c (tui_show_frame_info): Don't call
 645         tui_clear_source_content.
 646
 647 2019-08-15  Tom Tromey  <tom@tromey.com>
 648
 649         * tui/tui-winsource.h (struct tui_source_window_base)
 650         <do_erase_source_content>: New method.
 651         <erase_source_content>: New method.
 652         (tui_erase_source_content): Don't declare.
 653         * tui/tui-winsource.c (tui_clear_source_content): Update.
 654         (tui_source_window_base::do_erase_source_content): Rename from
 655         tui_erase_source_content.
 656         (tui_source_window_base::show_source_content): Update.
 657         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 658         * tui/tui-source.h (struct tui_source_window)
 659         <erase_source_content>: New method.
 660         * tui/tui-disasm.h (struct tui_disasm_window)
 661         <erase_source_content>: New method.
 662
 663 2019-08-15  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 666         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 667         constructor.
 668         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 669         * tui/tui-source.c (tui_set_source_content): Update.
 670         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 671
 672 2019-08-15  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 675         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 676         tui-source.c.
 677         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 678         Declare.
 679         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 680         method.
 681         (tui_source_window::maybe_update): Update.
 682
 683 2019-08-15  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 686         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 687         tui-disasm.c.
 688         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 689         Declare.
 690         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 691         method.
 692         (tui_disasm_window::maybe_update): Update.
 693
 694 2019-08-15  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui-winsource.h (struct tui_source_window_base)
 697         <maybe_update>: Declare.
 698         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 699         method.
 700         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 701         Declare.
 702         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 703         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 704         Declare.
 705         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 706
 707 2019-08-15  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 710
 711 2019-08-15  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-wingeneral.c: Include tui-stack.h.
 714         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 715         (struct tui_locator_window): Move from tui-data.h.
 716         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 717         (tui_initialize_static_data): Move from tui-data.c.
 718         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 719         (struct tui_locator_window): Move to tui-stack.c.
 720         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 721         (tui_initialize_static_data): Move to tui-stack.c.
 722
 723 2019-08-15  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-layout.c (show_source_disasm_command)
 726         (show_source_or_disasm_and_command): Use make_visible method, not
 727         tui_make_window.
 728         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 729         Remove.
 730
 731 2019-08-15  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-wingeneral.h (tui_make_window): Update.
 734         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 735         parameter.
 736         (tui_gen_win_info::make_visible): Update.
 737         * tui/tui-regs.c (tui_data_window::display_registers_from):
 738         Update.
 739         * tui/tui-layout.c (show_source_disasm_command)
 740         (show_source_or_disasm_and_command): Update.
 741         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 742         (enum tui_box): Remove.
 743         (struct tui_win_info) <can_box>: New method.
 744         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 745         method.
 746
 747 2019-08-15  Tom de Vries  <tdevries@suse.de>
 748
 749         * linux-nat-trad.c: Include gdbarch.h.
 750
 751 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 752
 753         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 754         register sizes.
 755
 756 2019-08-14  Tom Tromey  <tromey@adacore.com>
 757
 758         * darwin-nat.c: Include gdbarch.h.
 759         * darwin-nat-info.c: Include gdbarch.h.
 760
 761 2019-08-13  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 764         Remove.
 765         * tui/tui-data.c (tui_initialize_static_data): Update.
 766
 767 2019-08-13  Tom Tromey  <tom@tromey.com>
 768
 769         * tui/tui-winsource.h (struct tui_exec_info_window)
 770         <~tui_exec_info_window, maybe_allocate_content, get_content,
 771         m_content>: Remove.
 772         (struct tui_source_window_base) <set_exec_info_content,
 773         show_exec_info_content>: Don't declare.
 774         * tui/tui-winsource.c
 775         (tui_exec_info_window::maybe_allocate_content): Remove.
 776         (tui_source_window_base::update_exec_info): Rename from
 777         set_exec_info_content.
 778         (tui_source_window_base::show_exec_info_content)
 779         (tui_source_window_base::update_exec_info): Remove.
 780
 781 2019-08-13  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 784         declare.
 785         * tui/tui-winsource.c (tui_update_source_window_as_is)
 786         (tui_update_source_windows_with_addr, tui_erase_source_content):
 787         Update.
 788         (tui_clear_exec_info_content): Remove.
 789
 790 2019-08-13  Tom Tromey  <tom@tromey.com>
 791
 792         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 793         declare.
 794         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 795         call tui_erase_exec_info_content.
 796         (tui_clear_exec_info_content): Rename from
 797         tui_erase_exec_info_content.
 798         (tui_clear_exec_info_content): Delete.
 799
 800 2019-08-13  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-winsource.h (struct tui_source_window_base)
 803         <show_exec_info_content>: Declare.
 804         (tui_show_exec_info_content): Don't declare.
 805         * tui/tui-winsource.c
 806         (tui_source_window_base::show_exec_info_content): Rename from
 807         tui_show_exec_info_content.
 808         (tui_source_window_base::update_exec_info): Update.
 809
 810 2019-08-13  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 813         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 814         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 815         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 816         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 817         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 818         ... here.
 819
 820 2019-08-13  Tom Tromey  <tom@tromey.com>
 821
 822         * tui/tui-winsource.h (struct tui_source_window_base)
 823         <update_exec_info>: Declare.
 824         (tui_update_exec_info): Don't declare.
 825         * tui/tui-winsource.c (tui_update_source_window_as_is)
 826         (tui_source_window_base::refresh_all)
 827         (tui_update_all_breakpoint_info): Update.
 828         (tui_source_window_base::update_exec_info): Rename from
 829         tui_update_exec_info.
 830         * tui/tui-stack.c (tui_show_frame_info): Update.
 831
 832 2019-08-13  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-winsource.h (struct tui_source_window_base)
 835         <set_exec_info_content>: Declare.
 836         (tui_set_exec_info_content): Don't declare.
 837         * tui/tui-winsource.c
 838         (tui_source_window_base::set_exec_info_content): Rename from
 839         tui_set_exec_info_content.
 840         (tui_update_exec_info): Update.
 841
 842 2019-08-13  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-winsource.h (struct tui_source_window_base)
 845         <show_source_content>: Declare.
 846         (tui_show_source_content): Don't declare.
 847         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 848         (tui_source_window_base::show_source_content): Rename from
 849         tui_show_source_content.
 850         (tui_source_window_base::refresh_all): Update.
 851         * tui/tui-layout.c (show_source_disasm_command)
 852         (show_source_or_disasm_and_command): Update.
 853
 854 2019-08-13  Tom Tromey  <tom@tromey.com>
 855
 856         * tui/tui-winsource.c (tui_erase_source_content)
 857         (tui_show_source_content, tui_source_window_base::refresh_all):
 858         Update.
 859         * tui/tui-wingeneral.h
 860         (tui_check_and_display_highlight_if_needed): Don't declare.
 861         * tui/tui-wingeneral.c
 862         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 863         check_and_display_highlight_if_needed.
 864         * tui/tui-win.c (tui_rehighlight_all)
 865         (tui_win_info::make_visible_with_new_height): Update.
 866         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 867         (tui_data_window::erase_data_content)
 868         (tui_data_window::display_all_data): Update.
 869         * tui/tui-data.h (struct tui_win_info)
 870         <check_and_display_highlight_if_needed>: Declare.
 871
 872 2019-08-13  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui-win.c (tui_resize_all): Call
 875         tui_delete_invisible_windows.
 876         * tui/tui-layout.c (show_layout): Call
 877         tui_delete_invisible_windows.
 878         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 879         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 880
 881 2019-08-13  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 884         tui_add_win_to_layout.
 885
 886 2019-08-13  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 889         * tui/tui-layout.c (tui_default_win_height): Now static.
 890
 891 2019-08-13  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 894         single switch.
 895         (show_source_disasm_command, show_source_or_disasm_and_command):
 896         Don't check current layout.
 897
 898 2019-08-13  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui-wingeneral.c (make_all_visible): Remove.
 901         (tui_make_all_invisible): Simplify.
 902         * tui/tui-layout.c (tui_make_all_invisible): Move from
 903         tui-wingeneral.c; simplify.
 904         (show_layout): Hoist call to tui_make_all_invisible.
 905         (show_data): Don't call tui_make_all_invisible.
 906
 907 2019-08-13  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 910         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 911
 912 2019-08-13  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 915         tui-data.c.
 916         (show_source_disasm_command, show_data)
 917         (show_source_or_disasm_and_command): Don't use
 918         tui_set_current_layout_to.
 919         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 920         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 921         tui-layout.c.
 922         (tui_set_current_layout_to): Remove.
 923
 924 2019-08-13  Tom Tromey  <tom@tromey.com>
 925
 926         * tui/tui-layout.c (tui_set_layout): Update.
 927         * tui/tui-data.h (struct tui_layout_def): Remove.
 928         (tui_layout_def): Don't declare.
 929         * tui/tui-data.c (layout_def): Remove.
 930         (tui_layout_def): Remove.
 931
 932 2019-08-13  Tom Tromey  <tom@tromey.com>
 933
 934         * tui/tui-winsource.h (struct tui_source_window_base)
 935         <clear_detail>: No longer "override".
 936         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 937         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 938         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 939         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 940         Remove.
 941         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 942
 943 2019-08-13  Tom Tromey  <tromey@adacore.com>
 944
 945         * tracepoint.c: Don't include readline.h or history.h.
 946
 947 2019-08-12  Tom Tromey  <tom@tromey.com>
 948
 949         * configure: Rebuild.
 950         * configure.ac: Check for readline 7.
 951         * NEWS: Mention readline 7 requirement.
 952         * README: Update.
 953
 954 2019-08-12  Tom Tromey  <tom@tromey.com>
 955
 956         * mingw-hdep.c (gdb_select): Remove readline hack.
 957
 958 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 959
 960         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 961         when the function fails.
 962
 963 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 964
 965         * s390-tdep.c (s390_type_align): New function.
 966         (s390_gdbarch_init): Set it as type_align gdbarch method.
 967
 968 2019-08-09  Tom de Vries  <tdevries@suse.de>
 969
 970         PR gdb/24591
 971         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 972         pc_low with relocation offset.
 973
 974 2019-08-07  Tom Tromey  <tromey@adacore.com>
 975
 976         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 977         (print_frame_args): Update.
 978         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 979         Update.
 980         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 981         * frame.h (struct frame_arg): Add initializers.
 982         <error>: Now a unique_xmalloc_ptr.
 983
 984 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 985
 986         * NEWS: Expand the Pointer Authentication entry.
 987         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 988         (aarch64_frame_unmask_lr): ... to this.
 989         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 990         Call aarch64_frame_unmask_lr.
 991         * frame.c (struct frame_info): Add "masked" variable.
 992         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 993         (fprint_frame): Check for masked pc.
 994         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 995         declarations.
 996         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 997         * stack.c (print_frame): Check for masked pc.
 998
 999 2019-08-06  Tom Tromey  <tom@tromey.com>
1000
1001         * stabsread.c (patch_block_stabs, read_one_struct_field)
1002         (read_enum_type): Use obstack_strndup.
1003         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1004         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1005         * dwarf2read.c (guess_full_die_structure_name)
1006         (anonymous_struct_prefix): Use obstack_strndup.
1007         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1008         * c-exp.y (yylex): Use obstack_strndup.
1009         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1010         (write_var_or_type): Use obstack_strndup.
1011
1012 2019-08-06  Tom Tromey  <tom@tromey.com>
1013
1014         * symfile.c (reread_symbols): Use obstack_strdup.
1015         * stabsread.c (read_type): Use obstack_strdup.
1016         * gdb_obstack.h (obstack_strdup): New overload.
1017         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1018         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1019         (dwarf2_canonicalize_name): Use obstack_strdup.
1020         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1021         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1022         Use obstack_strdup.
1023
1024 2019-08-06  Tom Tromey  <tom@tromey.com>
1025
1026         * gdb_obstack.h (obstack_strdup): Define.
1027         * gdb_obstack.c (obstack_strdup): Don't define.
1028
1029 2019-08-06  Tom Tromey  <tom@tromey.com>
1030
1031         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1032         obstack_strdup.
1033         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1034         obstack_strdup.
1035         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1036         * stabsread.c (common_block_start): Use obstack_strdup.
1037         * objfiles.c (set_objfile_main_name, objfile): Use
1038         obstack_strdup.
1039         * namespace.c (add_using_directive): Use obstack_strdup.
1040         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1041         * jit.c (finalize_symtab): Use obstack_strdup.
1042         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1043         (guess_partial_die_structure_name, partial_die_info::fixup)
1044         (dwarf2_name): Use obstack_strdup.
1045         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1046         obstack_strdup.
1047         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1048         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1049         obstack_strdup.
1050         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1051
1052 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1053
1054         * unittests/help-doc-selftests.c: New file.
1055         * Makefile.in: Add the new file.
1056
1057 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1058
1059         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1060         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1061         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1062         the trailing '.' is not output, and the first character is uppercased.
1063         (print_help_for_command): Update call to print_doc_line.
1064         (print_doc_of_command): Likewise.
1065         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1066         * cli/cli-option.c (append_indented_doc): Do not append newline.
1067         (build_help_option): Append newline after first appended_indented_doc
1068         only if a second call is done.
1069         (build_help): Append 2 new lines before each option, except the first
1070         one.
1071         * compile/compile.c (_initialize_compile): Add new lines after
1072         %OPTIONS%, when not at the end of the help.
1073         Change help doc or code
1074         producing the help doc to respect the invariants.
1075         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1076         Also removed the new line after 'Options:', as all other commands
1077         do not put an empty line between 'Options:' and the first option.
1078         * printcmd.c (_initialize_printcmd): Likewise.
1079         * stack.c (_initialize_stack): Likewise.
1080         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1081         incorrectly telling COMMAND is optional.
1082         * ada-lang.c (_initialize_ada_language): Change help doc or code
1083         producing the help doc to respect the invariants.
1084         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1085         * breakpoint.c (_initialize_breakpoint): Likewise.
1086         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1087         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1088         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1089         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1090         _initialize_cli_style): Likewise.
1091         * corelow.c (core_target_info): Likewise.
1092         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1093         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1094         * filesystem.c (_initialize_filesystem): Likewise.
1095         * frame.c (_initialize_frame): Likewise.
1096         * gnu-nat.c (add_task_commands): Likewise.
1097         * infcall.c (_initialize_infcall): Likewise.
1098         * infcmd.c (_initialize_infcmd): Likewise.
1099         * interps.c (_initialize_interpreter): Likewise.
1100         * language.c (_initialize_language): Likewise.
1101         * linux-fork.c (_initialize_linux_fork): Likewise.
1102         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1103         * maint.c (_initialize_maint_cmds): Likewise.
1104         * memattr.c (_initialize_mem): Likewise.
1105         * printcmd.c (_initialize_printcmd): Likewise.
1106         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1107         _RegEx): Likewise.
1108         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1109         * record-btrace.c (_initialize_record_btrace): Likewise.
1110         * record-full.c (_initialize_record_full): Likewise.
1111         * record.c (_initialize_record): Likewise.
1112         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1113         * regcache.c (_initialize_regcache): Likewise.
1114         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1115         _initialize_remote): Likewise.
1116         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1117         * serial.c (_initialize_serial): Likewise.
1118         * skip.c (_initialize_step_skip): Likewise.
1119         * source.c (_initialize_source): Likewise.
1120         * stack.c (_initialize_stack): Likewise.
1121         * symfile.c (_initialize_symfile): Likewise.
1122         * symtab.c (_initialize_symtab): Likewise.
1123         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1124         * top.c (init_main): Likewise.
1125         * tracefile-tfile.c (tfile_target_info): Likewise.
1126         * tracepoint.c (_initialize_tracepoint): Likewise.
1127         * tui/tui-win.c (_initialize_tui_win): Likewise.
1128         * utils.c (add_internal_problem_command): Likewise.
1129         * valprint.c (value_print_option_defs): Likewise.
1130
1131 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1132
1133         PR build/24886
1134         * configure.ac: Drop enable-libmcheck support.
1135         * configure, config.in: Rebuild.
1136         * libmcheck.m4: Remove.
1137         * acinclude.m4: Don't include it.
1138         * Makefile.in: Don't distribute it.
1139         * top.c (print_gdb_configuration): Don't mention it.
1140
1141 2019-08-06  Tom Tromey  <tom@tromey.com>
1142
1143         * utils.c (set_output_style): Sometimes pass stream to
1144         emit_style_escape.
1145         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1146         * record-btrace.c (btrace_insn_history): Update.
1147         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1148         method.
1149         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1150         Update initializers.
1151         <m_uiout>: New field.
1152         <m_di>: Move lower.
1153         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1154         Remove "uiout" parameter.
1155         (dump_insns): Update.
1156         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1157         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1158
1159 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1160
1161         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1162         (error_in_psymtab_expansion): Likewise.
1163         (lookup_symbol_via_quick_fns): Likewise.
1164         (basic_lookup_transparent_type_quick): Likewise.
1165         (basic_lookup_transparent_type_1): Likewise.
1166
1167 2019-08-06  Tom Tromey  <tromey@adacore.com>
1168
1169         * source.c (last_source_error): Now bool.
1170         (print_source_lines_base): Make "noprint" bool.  Only open
1171         source file when last_source_visited changes.
1172
1173 2019-08-06  Tom Tromey  <tromey@adacore.com>
1174
1175         * annotate.c (annotate_source_line): Use g_source_cache.
1176         * source-cache.c (source_cache::get_plain_source_lines): Change
1177         parameters.  Populate m_offset_cache.
1178         (source_cache::ensure): New method.
1179         (source_cache::get_line_charpos): New method.
1180         (extract_lines): Move lower.  Change parameters.
1181         (source_cache::get_source_lines): Move lower.
1182         * source-cache.h (class source_cache): Update comment.
1183         <get_line_charpos>: New method.
1184         <get_source_lines>: Update comment.
1185         <clear>: Clear m_offset_cache.
1186         <get_plain_source_lines>: Change parameters.
1187         <ensure>: New method
1188         <m_offset_cache>: New member.
1189         * source.c (forget_cached_source_info_for_objfile): Update.
1190         (info_source_command): Use g_source_cache.
1191         (find_source_lines, open_source_file_with_line_charpos): Remove.
1192         (print_source_lines_base, search_command_helper): Use g_source_cache.
1193         * source.h (open_source_file_with_line_charpos): Don't declare.
1194         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1195         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1196         Use g_source_cache.
1197
1198 2019-08-06  Tom Tromey  <tromey@adacore.com>
1199
1200         * source-cache.c (source_cache::get_plain_source_lines):
1201         Remove "first_line" and "last_line" parameters.
1202         (source_cache::get_source_lines): Cache plain text.
1203         * source-cache.h (class source_cache)
1204         <get_plain_source_lines>: Update.
1205
1206 2019-08-06  Tom Tromey  <tromey@adacore.com>
1207
1208         * source-cache.c (extract_lines): No longer a method.
1209         Changed type of parameter.  Include final newline.
1210         (selftests::extract_lines_test): New function.
1211         (_initialize_source_cache): Likewise.
1212         * source-cache.h (class source_cache)
1213         <extract_lines>: Don't declare.
1214
1215 2019-08-06  Tom Tromey  <tromey@adacore.com>
1216
1217         * breakpoint.c (init_breakpoint_sal): Update.
1218         (breakpoint): Update.
1219         * breakpoint.h (struct breakpoint) <filter>: Now a
1220         unique_xmalloc_ptr.
1221
1222 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1223
1224         * NEWS: Mention dictionary access on blocks.
1225         * python/py-block.c (blpy_getitem): New function.
1226         (block_object_as_mapping): New struct.
1227         (block_object_type): Use new struct for tp_as_mapping field.
1228
1229 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1230
1231         * objfiles.h (objfile): Add a comment describing partial symbols.
1232
1233 2019-08-05  Tom Tromey  <tromey@adacore.com>
1234
1235         * compile/compile.c (_initialize_compile): Use _(), not N_().
1236         * thread.c (_initialize_thread): Use _(), not N_().
1237         * stack.c (_initialize_stack): Use _(), not N_().
1238         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1239
1240 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1241
1242         * dwarf2read.c (struct dw2_symtab_iterator):
1243         <want_specific_block>: Remove.
1244         <block_index>: Change type to gdb::optional.
1245         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1246         change type of BLOCK_INDEX parameter to gdb::optional.
1247         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1248         (dw2_lookup_symbol): Don't pass argument for
1249         WANT_SPECIFIC_BLOCK.
1250         (dw2_expand_symtabs_for_function): Don't pass argument for
1251         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1252         (class dw2_debug_names_iterator)
1253         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1254         parameter, change BLOCK_INDEX type to gdb::optional.
1255         <m_want_specific_block>: Remove.
1256         <m_block_index>: Change type to gdb::optional.
1257         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1258         gdb::optional.  Re-write in function of gdb::optional.
1259         (dw2_debug_names_lookup_symbol): Don't pass argument for
1260         WANT_SPECIFIC_BLOCK.
1261         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1262         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1263         BLOCK_INDEX.
1264
1265 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1266
1267         * NEWS: Mention changes to "info sources" command.
1268
1269 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1270
1271         * symtab.c (filename_partial_match_opts): New struct type.
1272         (struct output_source_filename_data): New members
1273         regexp, c_regexp, partial_match.
1274         (output_source_filename): Use new members to decide to print file.
1275         (info_sources_option_defs): New variable.
1276         (make_info_sources_options_def_group, print_info_sources_header,
1277         info_sources_command_completer):
1278         New functions.
1279         (info_sources_command): Read new optional arguments.
1280         (_initialize_symtab): Update info sources help.
1281
1282 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1283
1284         * ada-lang.c (exception_support_info_v0): Renamed from...
1285         (default_exception_support_info): ... this.  Create new
1286         definition for v1.
1287         (ada_has_this_exception_support): Look up catch_handlers_sym.
1288         (ada_exception_support_info_sniffer): Try v0 after default.
1289
1290 2019-08-01  Tom Tromey  <tromey@adacore.com>
1291
1292         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1293         gdbarch.h.
1294
1295 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1296
1297         * s12z-tdep.c: Fix include path for s12z-opc.h.
1298
1299 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1300
1301         * NEWS: Require GNU make 3.82.
1302
1303 2019-07-16  Tom Tromey  <tom@tromey.com>
1304
1305         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1306         declare.
1307
1308 2019-07-30  Tom Tromey  <tromey@adacore.com>
1309
1310         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1311
1312 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1313
1314         * printcmd.c (print_address_symbolic): Print negative offsets.
1315         (build_address_symbolic): Force signed arithmetic when computing
1316         offset.
1317
1318 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1319
1320         PR/24474: Add a function to lookup static variables.
1321         * NEWS: Mention this new function.
1322         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1323         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1324         * python/python.c (python_GdbMethods): Add new function.
1325
1326 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1327
1328         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1329         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1330         (objfpy_lookup_static_symbol): New function.
1331         (objfile_object_methods): Add new functions.
1332
1333 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1334
1335         * NEWS: Mention 'set|show print frame-info'.  Mention new
1336         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1337         backtrace argument.  Mention that python frame filtering code
1338         is now consistent with what 'backtrace' command prints.
1339
1340 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1341
1342         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1343         comments.
1344         (print_frame_info_auto, print_frame_info_source_line,
1345         print_frame_info_location, print_frame_info_source_and_location,
1346         print_frame_info_location_and_address, print_frame_info_short_location):
1347         New declarations.
1348         (struct frame_print_options): New member print_frame_info.
1349         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1350         * stack.h (get_user_print_what_frame_info): New declaration.
1351         (frame_show_address): New declaration.
1352         * stack.c (print_frame_arguments_choices): New value 'presence'.
1353         (print_frame_info_auto, print_frame_info_source_line,
1354         print_frame_info_location, print_frame_info_source_and_location,
1355         print_frame_info_location_and_address, print_frame_info_short_location,
1356         print_frame_info_choices, print_frame_info_print_what): New definitions.
1357         (print_frame_args): Only print dots for args if print frame-arguments
1358         is 'presence'.
1359         (frame_print_option_defs): New element for "frame-info".
1360         (get_user_print_what_frame_info): New function.
1361         (frame_show_address): Make non static.  Move comment to stack.h.
1362         (print_frame_info_to_print_what): New function.
1363         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1364         to decide what to print.
1365         (backtrace_command_1): Handle the new print_frame_arguments_presence
1366         value.
1367         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1368         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1369         (py_print_frame): In non-mi mode, use LOCATION as default for
1370         print_what, similarly to frame information printed directly by
1371         backtrace command. Handle frame-info user option in non MI mode.
1372
1373 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1374
1375         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1376         Add case for debugging 32-bit target on 64-bit host.  Revise
1377         comment.
1378
1379 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1380
1381         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1382         instead of find_function_entry_range_from_pc.
1383
1384 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1385
1386         * stack.c (find_frame_funname): Remove code which preferred
1387         minsym over symtab sym in "certain pathological cases".
1388
1389         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1390         parameter.  Change type of "do_demangle" to bool.
1391         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1392         Pass suitable "prefer_sym_over_minsym" flag to
1393         build_address_symbolic().  Don't output "+" for negative offsets.
1394         * printcmd.c (print_address_symbolic): Update invocation of
1395         build_address_symbolic to include a "prefer_sym_over_minsym"
1396         flag.
1397         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1398         Restrict cases in which use of minimal symbol is preferred to that
1399         of a found symbol.  Update comments.
1400
1401         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1402         for entry pc when entry pc is out of range for that FDE.
1403
1404 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1405
1406         PR gdb/24839:
1407         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1408         type.
1409
1410 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1411
1412         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1413         this function's Python signature.
1414
1415
1416 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1417
1418         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1419         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1420         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1421         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1422         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1423
1424
1425 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1426
1427         * h8300-tdep.c (h8300_register_name_common): New.
1428         h8300_register_name): Use h8300_register_name_common.
1429         (h8300s_register_name): Likewise.
1430         (h8300sx_register_name): Likewise.
1431         (h8300h_register_nam): New.
1432         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1433
1434
1435 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1436
1437         * arm-tdep.c (arm_skip_cmse_entry): New function.
1438         (arm_is_sgstubs_section): New function.
1439         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1440
1441 2019-07-22  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1444         Don't self-assign.
1445
1446 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1447
1448         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1449         type_print.
1450
1451 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1452
1453         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1454         so that GDB doesn't match any msymbols when searching in the
1455         TYPES_DOMAIN.
1456         (print_symbol_info): Print using typedef_print or type_print based
1457         on the type of the symbol.  Add updated FIXME comment moved from...
1458         (_initialize_symtab): ... move and update FIXME comment to above.
1459
1460 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1461
1462         * NEWS: Mention adding -q option to "info types".
1463         * symtab.c (struct info_types_options): New struct.
1464         (info_types_options_defs): New variable.
1465         (make_info_types_options_def_group): New function.
1466         (info_types_command): Use gdb::option framework to parse options.
1467         (info_types_command_completer): New function.
1468         (_initialize_symtab): Extend the help text on "info types" and
1469         register command completer.
1470
1471 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1472
1473         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1474         (lookup_symbol_in_objfile): Change int to block_enum and add a
1475         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1476
1477 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1478
1479         * MAINTAINERS (Write After Approval): Add self.
1480
1481 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1482
1483         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1484         instruction to the dummy code region.
1485
1486 2019-07-19  Tom Tromey  <tromey@adacore.com>
1487
1488         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1489         (ARGSUSED, PARAMS, __func__): Remove rules.
1490
1491 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1492
1493         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1494         * features/arm/arm-with-iwmmxt.c: Remove.
1495         * features/arm/arm-with-iwmmxt.xml: Remove.
1496         * features/arm/arm-with-m-fpa-layout.c: Remove.
1497         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1498         * features/arm/arm-with-m-vfp-d16.c: Remove.
1499         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1500         * features/arm/arm-with-m.c: Remove.
1501         * features/arm/arm-with-m.xml: Remove.
1502         * features/arm/arm-with-neon.c: Remove.
1503         * features/arm/arm-with-neon.xml: Remove.
1504         * features/arm/arm-with-vfpv2.c: Remove.
1505         * features/arm/arm-with-vfpv2.xml: Remove.
1506         * features/arm/arm-with-vfpv3.c: Remove.
1507         * features/arm/arm-with-vfpv3.xml: Remove.
1508
1509 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1510
1511         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1512
1513 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1514
1515         * arch/aarch32.c (aarch32_create_target_description): Create
1516         target descriptions using features.
1517         * arch/arm.c (arm_create_target_description)
1518         (arm_create_mprofile_target_description): Likewise.
1519         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1520
1521 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1522
1523         * Makefile.in: Add new files.
1524         * aarch32-tdep.c: New file.
1525         * aarch32-tdep.h: New file.
1526         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1527         Call aarch32_read_description.
1528         * arch/aarch32.c: New file.
1529         * arch/aarch32.h: New file.
1530         * arch/arm.c (arm_create_target_description)
1531         (arm_create_mprofile_target_description): New function.
1532         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1533         (arm_create_target_description)
1534         (arm_create_mprofile_target_description): New declaration.
1535         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1536         read_description functions.
1537         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1538         Likewise.
1539         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1540         * arm-tdep.c (tdesc_arm_list): New variable.
1541         (arm_register_g_packet_guesses): Call create description functions.
1542         (arm_read_description) (arm_read_mprofile_description): New
1543         function.
1544         * arm-tdep.h (arm_read_description)
1545         (arm_read_mprofile_description): Add declaration.
1546         * configure.tgt: Add new files.
1547
1548 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1549
1550         * top.c (new_ui_command): Open specified terminal just once.
1551
1552 2019-07-18  Tom Tromey  <tromey@adacore.com>
1553
1554         * symtab.c (main_name): Constify return type.
1555         * symfile.c (set_initial_language): Update.
1556         * symtab.h (main_name): Constify return type.
1557
1558 2019-07-17  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-winsource.c (tui_update_source_window)
1561         (tui_update_source_window_as_is)
1562         (tui_update_source_windows_with_line): Remove return.
1563         * tui/tui-disasm.c (tui_show_disassem)
1564         (tui_show_disassem_and_update_source): Remove return.
1565         * tui/tui.c (tui_reset): Remove return.
1566         * tui/tui-wingeneral.c
1567         (tui_check_and_display_highlight_if_needed): Remove return.
1568
1569 2019-07-17  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1572
1573 2019-07-17  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-winsource.h (struct tui_exec_info_window)
1576         (struct tui_source_window_base): Move from tui-data.h.
1577         * tui/tui-winsource.c: Move many method definitions from
1578         elsewhere.  Remove "structuring" comments.
1579         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1580         (tui_source_window_base::refresh_window): Move to
1581         tui-winsource.c.
1582         * tui/tui-win.c (tui_source_window_base::refresh_all)
1583         (tui_source_window_base::update_tab_width)
1584         (tui_source_window_base::set_new_height)
1585         (tui_source_window_base::do_make_visible_with_new_height): Move to
1586         tui-winsource.c.
1587         * tui/tui-source.h: Update.
1588         * tui/tui-source.c (tui_source_window_base::reset): Move to
1589         tui-winsource.c.
1590         * tui/tui-disasm.h: Update.
1591         * tui/tui-data.h (struct tui_exec_info_window): Move to
1592         tui-winsource.h.
1593         (struct tui_source_window_base): Likewise.
1594         * tui/tui-data.c (tui_source_window_base::clear_detail)
1595         (tui_source_window_base, ~tui_source_window_base): Move to
1596         tui-winsource.c.
1597
1598 2019-07-17  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-win.c (tui_resize_all)
1601         (tui_source_window_base::update_tab_width)
1602         (tui_adjust_win_heights): Update.
1603         (tui_win_info::make_invisible_and_set_new_height): Rename from
1604         make_invisible_and_set_new_height.
1605         * tui/tui-data.h (struct tui_win_info)
1606         <make_invisible_and_set_new_height>: New method.
1607
1608 2019-07-17  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui.c: Update.
1611         * tui/tui-source.h (struct tui_source_window): Move from
1612         tui-data.h.
1613         * tui/tui-layout.c: Update.
1614         * tui/tui-disasm.c: Update.
1615         * tui/tui-data.h (struct tui_source_window): Move to
1616         tui-source.h.
1617
1618 2019-07-17  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1621         tui-data.h.
1622         * tui/tui-data.h (struct tui_disasm_window): Move to
1623         tui-disasm.h.
1624
1625 2019-07-17  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-regs.h (struct tui_data_item_window): Move from
1628         tui-data.h.
1629         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1630         * tui/tui-data.h (struct tui_data_item_window): Move to
1631         tui-regs.h.
1632         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1633
1634 2019-07-17  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui.c: Update.
1637         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1638         (tui_cmd_window::max_height): Move to tui-command.c.
1639         * tui/tui-layout.c: Update.
1640         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1641         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1642         tui-command.c.
1643         * tui/tui-command.h (struct tui_cmd_window): Move from
1644         tui-data.h.
1645         * tui/tui-command.c: Remove "structuring" comments.
1646         (tui_cmd_window::clear_detail)
1647         (tui_cmd_window::do_make_visible_with_new_height)
1648         (tui_cmd_window::max_height): Move from elsewhere.
1649
1650 2019-07-17  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1653         Now static.
1654         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1655         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1656
1657 2019-07-17  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui.c: Update.
1660         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1661         tui-regs.c.
1662         * tui/tui-windata.h: Remove file.
1663         * tui/tui-windata.c: Remove file.
1664         * tui/tui-win.c (tui_data_window::set_new_height)
1665         (tui_data_window::do_make_visible_with_new_height): Move to
1666         tui-regs.c.
1667         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1668         * tui/tui-regs.c: Remove "structuring" comments.
1669         (tui_data_window::first_data_item_displayed)
1670         (tui_data_window::delete_data_content_windows)
1671         (tui_data_window::erase_data_content)
1672         (tui_data_window::display_all_data)
1673         (tui_data_window::refresh_all)
1674         (tui_data_window::do_scroll_vertical)
1675         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1676         (tui_data_window::do_make_visible_with_new_height)
1677         (tui_data_window::refresh_window): Move from elsewhere.
1678         (_initialize_tui_regs): Move to end of file.
1679         * tui/tui-layout.c: Update.
1680         * tui/tui-hooks.c: Update.
1681         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1682         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1683         tui-regs.c.
1684         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1685
1686 2019-07-17  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1689         seen.
1690
1691 2019-07-17  Tom Tromey  <tom@tromey.com>
1692
1693         * tui/tui-win.c (tui_source_window_base::set_new_height)
1694         (tui_source_window_base::do_make_visible_with_new_height): Use
1695         m_has_locator field directly.
1696         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1697         method.
1698         (struct tui_source_window_base) <has_locator>: Likewise.
1699
1700 2019-07-17  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1703         Don't declare.
1704         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1705         Remove.
1706         * tui/tui-win.c (tui_source_window_base::set_new_height)
1707         (tui_source_window_base::set_new_height)
1708         (make_invisible_and_set_new_height)
1709         (tui_source_window_base::do_make_visible_with_new_height)
1710         (tui_source_window_base::do_make_visible_with_new_height):
1711         Update.
1712         * tui/tui-layout.c (show_source_disasm_command, show_data)
1713         (show_source_or_disasm_and_command): Update.
1714         * tui/tui-layout.c (show_layout): Update.
1715
1716 2019-07-17  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-layout.c (make_data_window): Remove.
1719         (show_data): Unify creation and re-initialization cases.
1720
1721 2019-07-17  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-layout.c (make_source_window, make_disasm_window):
1724         Remove.
1725         (show_data): Unify creation and re-initialization cases.
1726
1727 2019-07-17  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui-layout.c (make_command_window): Remove.
1730         (show_source_disasm_command, show_source_or_disasm_and_command):
1731         Unify creation and re-initialization cases.
1732
1733 2019-07-17  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1736         creation and re-initialization cases.
1737
1738 2019-07-17  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-regs.c (tui_get_register): Return void.
1741
1742 2019-07-17  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1745         Simplify.
1746
1747 2019-07-17  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1750         resetting.
1751
1752 2019-07-17  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1755         * tui/tui-regs.c (tui_reg_layout): New function.
1756         (tui_show_registers, tui_reg_command): Use it.
1757         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1758         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1759         parameters.
1760         (tui_layout_command): Remove.
1761
1762 2019-07-17  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-layout.h (tui/tui-layout): Return void.
1765         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1766
1767 2019-07-17  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-layout.c (show_source_disasm_command, show_data):
1770         Update.
1771         (reset_locator): Remove.
1772         (show_source_or_disasm_and_command): Update.
1773
1774 2019-07-17  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-source.c (tui_source_window_base::reset): Remove
1777         win_type parameter.
1778         * tui/tui-layout.c (make_command_window, make_source_window)
1779         (make_disasm_window, make_data_window)
1780         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1781         (reset_locator, show_source_or_disasm_and_command): Update.
1782         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1783         win_type parameter.
1784         (struct tui_source_window_base) <reset>: Likewise.
1785
1786 2019-07-17  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-layout.c (show_source_disasm_command): Use
1789         reset_locator.
1790         (reset_locator): New function.
1791         (init_and_make_win): Remove.
1792         (show_source_or_disasm_and_command): Use reset_locator.
1793
1794 2019-07-17  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1797         condition.
1798         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1799         Remove condition.
1800         * tui/tui-source.c (tui_source_window_base::reset): New method.
1801         * tui/tui-layout.c (make_command_window): Don't call
1802         init_and_make_win.
1803         (make_source_window, make_disasm_window): Don't call
1804         make_source_or_disasm_window.
1805         (make_data_window): Don't call init_and_make_win.  Change calling
1806         convention.
1807         (show_source_disasm_command, show_data): Simplify.
1808         (make_source_or_disasm_window): Remove.
1809         (show_source_or_disasm_and_command): Simplify.
1810         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1811         (struct tui_source_window_base) <reset>: Likewise.
1812         <execution_info>: Remove initializer.
1813         * tui/tui-data.c (tui_source_window_base): Initialize
1814         execution_info.
1815
1816 2019-07-17  Tom Tromey  <tom@tromey.com>
1817
1818         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1819         variable.
1820
1821 2019-07-17  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui.c (tui_rl_other_window): Update.
1824         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1825         superclass method first.  Always iterate over regs_content.
1826         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1827         method.
1828         * tui/tui-win.c (tui_set_focus_command): Update.
1829
1830 2019-07-17  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-win.c (tui_set_focus_command): Rename from
1833         tui_set_focus.  Call tui_enable.
1834         (tui_set_focus_command): Remove.
1835
1836 2019-07-17  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1839         refresh_window.
1840         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1841         touchwin.
1842         (tui_data_window::refresh_window): Call refresh_window on data
1843         items.  Always call superclass refresh_window.
1844         (tui_win_info::refresh): Remove.
1845         (tui_source_window_base::refresh_window): Update.
1846         (tui_refresh_all): Update.
1847         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1848         refresh_window.
1849         (show_source_or_disasm_and_command): Likewise.
1850         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1851         (struct tui_source_window_base) <refresh>: Likewise.
1852
1853 2019-07-17  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-winsource.c (tui_clear_source_content)
1856         (tui_show_source_content): Update.
1857         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1858         whether content is empty.
1859         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1860         Remove.
1861
1862 2019-07-17  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1865         window's contents.
1866         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1867         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1868
1869 2019-07-17  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1872         (struct tui_data_item_window): Update.
1873
1874 2019-07-17  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1877         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1878         defines.
1879
1880 2019-07-17  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-winsource.h (tui_erase_source_content)
1883         (tui_clear_source_content): Remove "display_prompt" parameter.
1884         * tui/tui-winsource.c (tui_update_source_window_as_is)
1885         (tui_update_source_windows_with_addr): Update.
1886         (tui_clear_source_content): Remove "display_prompt" parameter.
1887         (tui_erase_source_content): Likewise.  Simplify.
1888         (tui_show_source_content): Update.
1889         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1890         * tui/tui-stack.c (tui_show_frame_info): Update.
1891         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1892         Remove defines.
1893
1894 2019-07-17  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1897         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1898         parameter.
1899         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1900         parameter.
1901
1902 2019-07-17  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-winsource.c (tui_clear_source_content)
1905         (tui_show_source_content, tui_show_exec_info_content)
1906         (tui_clear_exec_info_content): Update.
1907         * tui/tui-stack.c (tui_show_locator_content): Update.
1908         (tui_show_frame_info): Update.
1909         * tui/tui-source.h (tui_source_window): Don't declare.
1910         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1911         from tui_source_is_displayed.
1912         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1913         Remove field.
1914         (struct tui_source_window_base) <content_in_use>: New field.  Now
1915         bool.
1916         (struct tui_source_window) <showing_source_p>: New method.
1917         (TUI_SRC_WIN): Change cast.
1918         * tui/tui-data.c (tui_initialize_static_data): Update.
1919
1920 2019-07-17  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1923         location_matches_p.
1924         * tui/tui-source.c (tui_source_window::location_matches_p): New
1925         method.
1926         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1927         method.
1928         * tui/tui-data.h (struct tui_source_window_base)
1929         <location_matches_p>: New method.
1930         (struct tui_source_window, struct tui_disasm_window)
1931         <location_matches_p>: Likewise.
1932
1933 2019-07-17  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-win.c (tui_set_win_height_command): Rename from
1936         tui_set_win_height.
1937         (tui_set_win_height_command): Remove.
1938
1939 2019-07-17  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-source.c (tui_source_window): New constructor.  Add
1942         observer.
1943         (~tui_source_window): New destructor.
1944         (tui_source_window::style_changed): New method.
1945         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1946         (tui_attach_detach_observers): Update.
1947         * tui/tui-data.h (struct tui_source_window): Make constructor not
1948         inline.  Add destructor.
1949         (struct tui_source_window) <style_changed>: New method.
1950         <m_observable>: New member.
1951
1952 2019-07-17  Tom Tromey  <tom@tromey.com>
1953
1954         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1955         * tui/tui-win.c (tui_resize_all): Fix typo.
1956
1957 2019-07-17  Tom Tromey  <tom@tromey.com>
1958
1959         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1960         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1961         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1962         * tui/tui-win.c (window_name_completer): Use foreach.
1963         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1964         (update_tab_width): Likewise.
1965         * tui/tui-layout.c (show_layout): Update.
1966         * tui/tui-data.h (class tui_window_iterator): New.
1967         (struct all_tui_windows): New.
1968         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1969
1970 2019-07-17  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1973         parameter.  Don't reference globals.
1974         (tui_reg_command): Update.
1975
1976 2019-07-17  Tom Tromey  <tom@tromey.com>
1977
1978         * tui/tui-regs.c (tui_show_registers): Simplify.
1979
1980 2019-07-17  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui-regs.c (tui_show_registers): Update.
1983         (tui_show_register_group): Add win_info parameter.
1984
1985 2019-07-17  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1988         Rename from tui_display_reg_element_at_line.
1989         (tui_data_window::display_registers_from_line): Update.
1990         * tui/tui-data.h (struct tui_data_window)
1991         <display_reg_element_at_line>: New method.
1992
1993 2019-07-17  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-regs.h (tui_display_registers_from)
1996         (tui_display_registers_from_line): Don't declare.
1997         * tui/tui-windata.c (tui_data_window::display_all_data)
1998         (tui_data_window::refresh_all)
1999         (tui_data_window::do_scroll_vertical): Update.
2000         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2001         from tui_display_registers_from.
2002         (tui_display_reg_element_at_line): Update.
2003         (tui_data_window::display_registers_from_line): Rename from
2004         tui_display_registers_from_line.
2005         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2006         display_registers_from_line>: New methods.
2007
2008 2019-07-17  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2011         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2012         from tui_erase_data_content.
2013         (tui_data_window::display_all_data)
2014         (tui_data_window::refresh_all)
2015         (tui_data_window::do_scroll_vertical): Update.
2016         * tui/tui-regs.c (tui_show_registers): Update.
2017         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2018         New method.
2019
2020 2019-07-17  Tom Tromey  <tom@tromey.com>
2021
2022         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2023         declare.
2024         * tui/tui-windata.c
2025         (tui_data_window::delete_data_content_windows): Rename from
2026         tui_delete_data_content_windows.
2027         (tui_data_window::display_all_data)
2028         (tui_data_window::do_scroll_vertical): Update.
2029         * tui/tui-data.h (struct tui_data_window)
2030         <delete_data_content_windows>: New method.
2031
2032 2019-07-17  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2035         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2036
2037 2019-07-17  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2040         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2041         from tui_display_all_data.
2042         * tui/tui-win.c
2043         (tui_data_window::do_make_visible_with_new_height): Update.
2044         * tui/tui-regs.c (tui_show_registers): Update.
2045         * tui/tui-layout.c (tui_set_layout): Update.
2046         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2047         method.
2048
2049 2019-07-17  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2052         * tui/tui-windata.c (tui_display_data_from): Remove.
2053         (tui_data_window::refresh_all): Update.
2054
2055 2019-07-17  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2058         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2059         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2060         tui_display_registers_from_line.
2061         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2062         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2063         "force_display" parameter.
2064
2065 2019-07-17  Tom Tromey  <tom@tromey.com>
2066
2067         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2068         declare.
2069         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2070         Rename from tui_first_reg_element_no_inline.
2071         (tui_display_reg_element_at_line)
2072         (tui_display_registers_from_line): Update.
2073         * tui/tui-data.h (struct tui_data_window)
2074         <first_reg_element_no_inline>: New method.
2075
2076 2019-07-17  Tom Tromey  <tom@tromey.com>
2077
2078         * tui/tui-windata.c (tui_display_data_from)
2079         (tui_data_window::do_scroll_vertical): Update.
2080         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2081         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2082         Rename from tui_line_from_reg_element_no.
2083         (tui_display_registers_from_line): Update.
2084         * tui/tui-data.h (struct tui_data_window)
2085         <line_from_reg_element_no>: New method.
2086
2087 2019-07-17  Tom Tromey  <tom@tromey.com>
2088
2089         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2090         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2091         tui_last_regs_line_no.
2092         (tui_display_reg_element_at_line)
2093         (tui_display_registers_from_line): Update.
2094         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2095         method.
2096
2097 2019-07-17  Tom Tromey  <tom@tromey.com>
2098
2099         PR tui/24722:
2100         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2101         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2102         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2103         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2104         (tui_update_breakpoint_info): Likewise.
2105         * tui/tui-hooks.c (tui_event_create_breakpoint)
2106         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2107         Update.
2108
2109 2019-07-17  Tom Tromey  <tom@tromey.com>
2110
2111         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2112
2113 2019-07-17  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-winsource.c (tui_update_source_window_as_is)
2116         (tui_update_source_windows_with_addr): Update.
2117         * tui/tui-source.h (tui_set_source_content)
2118         (tui_show_symtab_source): Add "win_info" parameter.
2119         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2120         parameter.
2121         (tui_show_symtab_source): Likewise.
2122
2123 2019-07-17  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-wingeneral.c
2126         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2127
2128 2019-07-17  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2131         (struct tui_cmd_window) <can_scroll>: New method.
2132         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2133         method.
2134
2135 2019-07-17  Tom Tromey  <tromey@adacore.com>
2136
2137         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2138         do_field_signed>: Rename.  Change type of "value".
2139         * ui-out.c (ui_out::field_signed): Rename from field_int.
2140         Change type of "value".
2141         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2142         type of "value".
2143         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2144         do_field_int.  Change type of "value".
2145         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2146         do_field_int.  Change type of "value".
2147         * tracepoint.c (trace_status_mi, tfind_1)
2148         (print_one_static_tracepoint_marker): Update.
2149         * thread.c (print_thread_info_1, print_selected_thread_frame):
2150         Update.
2151         * stack.c (print_frame, print_frame_info): Update.
2152         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2153         Update.
2154         * source.c (print_source_lines_base): Update.
2155         * skip.c (info_skip_command): Update.
2156         * record-btrace.c (btrace_ui_out_decode_error)
2157         (btrace_call_history_src_line): Update.
2158         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2159         Update.
2160         * progspace.c (print_program_space): Update.
2161         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2162         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2163         do_field_int.  Change type of "value".
2164         * mi/mi-out.c (mi_ui_out::do_table_begin)
2165         (mi_ui_out::do_table_header): Update.
2166         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2167         type of "value".
2168         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2169         (mi_cmd_data_list_changed_registers, output_register)
2170         (mi_cmd_data_read_memory, mi_load_progress)
2171         (mi_cmd_trace_frame_collected): Update.
2172         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2173         Update.
2174         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2175         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2176         (mi_cmd_var_list_children, varobj_update_one): Update.
2177         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2178         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2179         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2180         * inferior.c (print_inferior): Update.
2181         * gdb_bfd.c (print_one_bfd): Update.
2182         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2183         Update.
2184         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2185         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2186         do_field_int.  Change type of "value".
2187         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2188         do_field_int.  Change type of "value".
2189         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2190         (print_one_breakpoint_location, print_it_catch_fork)
2191         (print_one_catch_fork, print_it_catch_vfork)
2192         (print_one_catch_vfork, print_it_catch_solib)
2193         (print_it_catch_exec, print_it_ranged_breakpoint)
2194         (print_mention_watchpoint, print_mention_masked_watchpoint)
2195         (bkpt_print_it, update_static_tracepoint): Update.
2196         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2197         * break-catch-syscall.c (print_it_catch_syscall): Update.
2198         * ada-tasks.c (print_ada_task_info): Update.
2199         * ada-lang.c (print_it_exception, print_mention_exception):
2200         Update.
2201
2202 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         PR breakpoints/24541
2205         * gdbarch.c: Regenerate.
2206         * gdbarch.h: Regenerate.
2207         * gdbarch.sh: Adjust return type and parameter types for
2208         'stap_adjust_register'.
2209         (i386_stap_adjust_register): Adjust signature and return new
2210         register name.
2211         * stap-probe.c (stap_parse_register_operand): Adjust use of
2212         'gdbarch_stap_adjust_register'.
2213
2214 2019-07-17  Tom Tromey  <tromey@adacore.com>
2215
2216         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2217         declare VEC.
2218         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2219         std::vector.
2220         (struct s390_process_info): Add initializers.
2221         (s390_add_process): Use new.
2222         (s390_linux_nat_target::low_forget_process): Use delete.
2223         (s390_linux_nat_target::low_new_fork)
2224         (s390_linux_nat_target::stopped_by_watchpoint)
2225         (s390_linux_nat_target::low_prepare_to_resume)
2226         (s390_linux_nat_target::insert_watchpoint)
2227         (s390_linux_nat_target::insert_hw_breakpoint)
2228         (s390_linux_nat_target::remove_watchpoint)
2229         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2230
2231 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2232
2233         * aarch64-fbsd-nat.c: Include regcache.h.
2234         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2235         argument.
2236         (aarch64_fbsd_nat_target::fetch_registers)
2237         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2238         variable.
2239         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2240
2241 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2242
2243         * fbsd-nat.c: Include gdbarch.h.
2244
2245 2019-07-15  Tom Tromey  <tromey@adacore.com>
2246
2247         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2248
2249 2019-07-15  Tom Tromey  <tromey@adacore.com>
2250
2251         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2252         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2253         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2254         * cli-out.c (cli_ui_out::do_field_int): New method.
2255         * ui-out.c (ui_out::field_unsigned): New method.
2256         * symfile.c (generic_load): Use field_unsigned.
2257         (print_transfer_performance): Likewise.
2258         * record-btrace.c (ui_out_field_uint): Remove.
2259         (btrace_call_history_insn_range, btrace_call_history): Use
2260         field_unsigned.
2261         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2262         field_unsigned.
2263         * ui-out.h (class ui_out) <field_unsigned>: New method.
2264         <do_field_unsigned>: Likewise.
2265
2266 2019-07-15  Tom Tromey  <tromey@adacore.com>
2267
2268         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2269         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2270         * target.c (flash_erase_command): Use field_string.
2271         * infrun.c (print_signal_received_reason): Use field_string.
2272         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2273         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2274         field_string.
2275         * ada-tasks.c (print_ada_task_info): Use field_string.
2276
2277 2019-07-15  Tom Tromey  <tromey@adacore.com>
2278
2279         * target.c (flash_erase_command): Use field_core_addr.
2280         * symfile.c (generic_load): Use field_core_addr.
2281         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2282         Use field_core_addr.
2283         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2284         field_core_addr.
2285
2286 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2289         value if its desired type is smaller than a CORE_ADDR and signed.
2290
2291 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2292
2293         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2294         of changes to field names, and use new is_reference field to
2295         decide if a property is a reference or not.
2296         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2297         field.
2298         (struct dwarf2_property_baton): Update header comment, rename
2299         'referenced_type' to 'property_type' and update comments.
2300         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2301         default property type, store in property baton, update to take
2302         accound of renamed field.
2303         (read_func_scope): Update call to attr_to_dynamic_prop.
2304         (read_array_type): Likewise.
2305         (dwarf2_per_cu_addr_sized_int_type): New function.
2306         (read_subrange_index_type): Move type finding code to
2307         dwarf2_per_cu_addr_sized_int_type.
2308         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2309         (dwarf2_per_cu_addr_type): New function.
2310         (set_die_type): Update calls to attr_to_dynamic_prop.
2311
2312 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2313
2314         * dwarf2read.c (read_subrange_index_type): New function.
2315         (read_subrange_type): Move code into new function and call it.
2316         * gdbtypes.c (create_range_type): Add some asserts.
2317
2318 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2319
2320         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2321         update return statements.
2322         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2323         declaration, and update comment to match.
2324         * gdbtypes.c (resolve_dynamic_array): Update call to
2325         dwarf2_evaluate_property to match new return type.
2326
2327 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2328
2329         * valarith.c (value_subscripted_rvalue): Change lowerbound
2330         parameter type from int to LONGEST.
2331         * value.h (value_subscripted_rvalue): Likewise in declaration.
2332
2333 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2334
2335         * cli/cli-utils.c (info_print_command_completer): New function.
2336         * cli/cli-utils.h: Add 'completer.h' include, and forward
2337         declaration for 'struct cmd_list_element'.
2338         (info_print_command_completer): Declare.
2339         * stack.c (_initialize_stack): Add completer for 'info locals' and
2340         'info args'.
2341         * symtab.c (_initialize_symtab): Add completer for 'info
2342         variables' and 'info functions'.
2343         * NEWS: Mention completion for additional info commands.
2344
2345 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2346
2347         * cli/cli-utils.c (extract_info_print_args): Delete.
2348         (extract_arg_maybe_quoted): Delete.
2349         (info_print_options_defs): New variable.
2350         (make_info_print_options_def_group): New function.
2351         (extract_info_print_options): Define new function.
2352         * cli/cli-utils.h (extract_info_print_args): Delete.
2353         (struct info_print_options): New structure.
2354         (extract_info_print_options): Declare new function.
2355         * stack.c (info_locals_command): Update to use new
2356         extract_info_print_options, also add a header comment.
2357         (info_args_command): Likewise.
2358         * symtab.c (info_variables_command): Likewise.
2359         (info_functions_command): Likewise.
2360
2361 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2362
2363         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2364         to extract string arguments.
2365         * common/common-utils.c (extract_string_maybe_quoted): New function.
2366         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2367
2368 2019-07-11  Tom Tromey  <tromey@adacore.com>
2369
2370         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2371         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2372         * top.h (gdbinit): Don't declare.
2373         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2374         into...
2375         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2376         * top.c (gdb_init): Don't call init_cli_cmds.
2377         (gdbinit): Remove.
2378         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2379
2380 2019-07-11  Tom Tromey  <tromey@adacore.com>
2381
2382         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2383         after it has been moved.
2384
2385 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2386
2387         * valops.c (value_must_coerce_to_target): Change return type to
2388         bool.
2389         * value.h (value_must_coerce_to_target): Likewise.
2390
2391 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2392
2393         * breakpoint.c (is_hardware_watchpoint): Remove
2394         forward-declaration.
2395         (is_masked_watchpoint): Change return type to bool.
2396         (is_tracepoint): Likewise.
2397         (is_breakpoint): Likewise.
2398         (is_hardware_watchpoint): Likewise.
2399         (is_watchpoint): Likewise.
2400         (is_no_memory_software_watchpoint): Likewise.
2401         (is_catchpoint): Likewise.
2402         (breakpoint_1): Make FILTER parameter's return type bool.
2403         is_masked_watchpoint): Change return type to bool.
2404         (save_breakpoints): Make FILTER parameter's return type bool.
2405         * breakpoint.h (is_breakpoint): Change return type to bool.
2406         (is_watchpoint): Likewise.
2407         (is_catchpoint): Likewise.
2408         (is_tracepoint): Likewise.
2409
2410 2019-07-10  Tom Tromey  <tom@tromey.com>
2411
2412         * defs.h: Don't include gdbarch.h.
2413         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2414         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2415         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2416         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2417         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2418         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2419         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2420         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2421         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2422         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2423         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2424         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2425         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2426         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2427         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2428         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2429         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2430         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2431         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2432         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2433         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2434         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2435         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2436         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2437         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2438         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2439         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2440
2441 2019-07-10  Tom Tromey  <tromey@adacore.com>
2442
2443         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2444         * breakpoint.c (init_ada_exception_breakpoint): Register as
2445         bp_catchpoint.
2446         (print_one_breakpoint_location, print_one_breakpoint): Use
2447         is_ada_exception_catchpoint.
2448         * ada-lang.c (class ada_catchpoint_location): Pass
2449         bp_loc_software_breakpoint to bp_location constructor.
2450         (is_ada_exception_catchpoint): New function.
2451
2452 2019-07-10  Tom Tromey  <tromey@adacore.com>
2453
2454         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2455         VEC.
2456         (struct arm_exidx_entry): New method operator<.
2457         (struct arm_exidx_data) <section_maps>: Change type.
2458         (arm_exidx_data_free): Remove.
2459         (arm_exidx_data_key): Change type.  Move lower.
2460         (arm_exidx_new_objfile): Update.
2461         (arm_compare_exidx_entries): Remove.
2462         (arm_find_exidx_entry, _initialize_arm_tdep)
2463
2464 2019-07-10  Tom Tromey  <tromey@adacore.com>
2465
2466         * solib-spu.c (ocl_program_data_key): Change type.
2467         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2468         Update.
2469
2470 2019-07-10  Tom Tromey  <tromey@adacore.com>
2471
2472         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2473         (struct solib_aix_inferior_data) <library_list>: Change type.
2474         (solib_aix_inferior_data_handle): Change type.
2475         (get_solib_aix_inferior_data): Update.
2476         (solib_aix_free_library_list): Remove.
2477         (library_list_start_library): Update.
2478         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2479         return type.
2480         (solib_aix_get_library_list)
2481         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2482         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2483
2484 2019-07-10  Tom Tromey  <tromey@adacore.com>
2485
2486         * solib-dsbt.c (struct dsbt_info): Add initializers.
2487         (solib_dsbt_pspace_data): Change type.
2488         (dsbt_pspace_data_cleanup): Remove.
2489         (get_dsbt_info, _initialize_dsbt_solib): Update.
2490
2491 2019-07-10  Tom Tromey  <tromey@adacore.com>
2492
2493         * spu-tdep.c (spu_overlay_data): Change type.
2494         (spu_get_overlay_table, spu_overlay_new_objfile)
2495         (_initialize_spu_tdep): Update.
2496
2497 2019-07-10  Tom Tromey  <tromey@adacore.com>
2498
2499         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2500         destructor.
2501         (dbx_objfile_data_key): Change type and declare later.
2502         (DBX_SYMFILE_INFO): Rewrite.
2503         * dbxread.c (dbx_objfile_data_key): Change type.
2504         (dbx_symfile_init): Update.
2505         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2506         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2507         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2508
2509 2019-07-10  Tom Tromey  <tromey@adacore.com>
2510
2511         * jit.c (jit_program_space_key): Change type.  Move lower.
2512         (get_jit_program_space_data): Update.
2513         (jit_program_space_data_cleanup): Remove.
2514         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2515         Update.
2516         (struct jit_program_space_data): Add initializers.
2517
2518 2019-07-10  Tom Tromey  <tromey@adacore.com>
2519
2520         * solib-darwin.c (struct darwin_info): Add initializers.
2521         (solib_darwin_pspace_data): Change type.
2522         (darwin_pspace_data_cleanup): Remove.
2523         (get_darwin_info, _initialize_darwin_solib): Update.
2524
2525 2019-07-10  Tom Tromey  <tromey@adacore.com>
2526
2527         * remote-sim.c (struct sim_inferior_data): Add initializers,
2528         constructor, and destructor.
2529         (sim_inferior_data_key): Change type.  Move lower.
2530         (check_for_duplicate_sim_descriptor): Update.
2531         (get_sim_inferior_data): Use new.  Update.
2532         (~sim_inferior_data_cleanup): Rename from
2533         sim_inferior_data_cleanup.  Simplify.
2534         (gdbsim_close_inferior, simulator_command)
2535         (sim_command_completer, _initialize_remote_sim): Update.
2536         (next_pid, INITIAL_PID): Move earlier.
2537
2538 2019-07-10  Tom Tromey  <tromey@adacore.com>
2539
2540         * python/python-internal.h (create_thread_object): Return
2541         gdbpy_ref.
2542         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2543         * python/py-inferior.c (struct threadlist_entry): Add
2544         constructor.
2545         <thread_obj>: Now a gdbpy_ref.
2546         (thread_to_thread_object): Update.
2547         (add_thread_object): Use new.
2548         (delete_thread_object): Use delete.
2549         (infpy_threads): Update.
2550         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2551         GIL.
2552
2553 2019-07-10  Tom Tromey  <tromey@adacore.com>
2554
2555         * valops.c (value_cast): Specialize error message for Ada.
2556
2557 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2558
2559         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2560
2561 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2562
2563         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2564         bpstat_should_step): Return bool, adjust comments.
2565         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2566         bpstat_should_step): Likewise.
2567
2568 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2569
2570         * features/Makefile: Use feature target descriptions for Arm.
2571         * features/arm/arm-core.c: Generate new file.
2572         * features/arm/arm-fpa.c: Likewise.
2573         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2574         * features/arm/arm-m-profile.c: Likewise.
2575         * features/arm/arm-vfpv2.c: Likewise.
2576         * features/arm/arm-vfpv3.c: Likewise.
2577         * features/arm/xscale-iwmmxt.c: Likewise.
2578         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2579
2580 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2581
2582         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2583         ptrace earlier.
2584
2585 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2586
2587         * features/aarch64-pauth.c: Regenerate.
2588
2589 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2590
2591         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2592         bool.
2593         (bpstat_what): Use false instead of 0.
2594
2595 2019-07-09  Pedro Alves  <palves@redhat.com>
2596
2597         * break-catch-throw.c (is_exception_catchpoint): New.
2598         * breakpoint.c (print_one_breakpoint_location): New parameter
2599         'raw_loc'.  Handle it.  Use
2600         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2601         looking at the breakpoint's type.
2602         (print_one_breakpoint): If handling "maint info breakpoints", also
2603         print locations of exception catchpoints.
2604         * breakpoint.h (is_exception_catchpoint): Declare.
2605
2606 2019-07-09  Pedro Alves  <palves@redhat.com>
2607
2608         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2609         "addr" field.
2610         (allocate_location_exception_catchpoint): New.
2611         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2612         (initialize_throw_catchpoint_ops): Install
2613         allocate_location_exception_catchpoint as allocate_location
2614         method.
2615         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2616         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2617         bp_loc_other.
2618         (breakpoint_address_is_meaningful): Delete.
2619         (bl_address_is_meaningful): New.
2620         (breakpoint_locations_match): Adjust comment.
2621         (bp_location_from_bp_type): New, factored out of...
2622         (bp_location::bp_location(breakpoint *)): ... this.
2623         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2624         factored out of...
2625         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2626         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2627         breakpoint_address_is_meaningful.
2628         (bp_locations_compare): Adjust comment.
2629         (update_global_location_list): Use bl_address_is_meaningful
2630         instead of breakpoint_address_is_meaningful.
2631         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2632         explicit.
2633         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2634         * python/py-breakpoint.c (bppy_get_location): No longer check
2635         whether location is null.
2636
2637 2019-07-09  Pedro Alves  <palves@redhat.com>
2638
2639         PR c++/15468
2640         * breakpoint.c (print_one_breakpoint_location): Remove
2641         single-location assert.
2642
2643 2019-07-09  Tom Tromey  <tom@tromey.com>
2644
2645         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2646         * configure: Rebuild.
2647         * configure.ac: Change common to gdbsupport.
2648         * gdbsupport: Rename from common.
2649         * acinclude.m4: Change common to gdbsupport.
2650         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2651         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2652         gdbsupport.
2653         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2654         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2655         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2656         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2657         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2658         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2659         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2660         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2661         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2662         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2663         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2664         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2665         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2666         coff-pe-read.c, command.h, compile/compile-c-support.c,
2667         compile/compile-c.h, compile/compile-cplus-symbols.c,
2668         compile/compile-cplus-types.c, compile/compile-cplus.h,
2669         compile/compile-loc2c.c, compile/compile.c, completer.c,
2670         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2671         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2672         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2673         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2674         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2675         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2676         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2677         features/aarch64-core.c, features/aarch64-fpu.c,
2678         features/aarch64-pauth.c, features/aarch64-sve.c,
2679         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2680         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2681         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2682         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2683         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2684         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2685         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2686         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2687         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2688         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2689         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2690         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2691         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2692         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2693         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2694         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2695         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2696         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2697         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2698         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2699         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2700         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2701         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2702         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2703         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2704         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2705         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2706         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2707         minsyms.c, mips-linux-tdep.c, namespace.h,
2708         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2709         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2710         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2711         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2712         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2713         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2714         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2715         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2716         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2717         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2718         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2719         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2720         procfs.c, producer.c, progspace.h, psymtab.h,
2721         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2722         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2723         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2724         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2725         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2726         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2727         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2728         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2729         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2730         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2731         target-memory.c, target.c, target.h, target/waitstatus.c,
2732         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2733         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2734         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2735         unittests/array-view-selftests.c,
2736         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2737         unittests/common-utils-selftests.c,
2738         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2739         unittests/format_pieces-selftests.c,
2740         unittests/function-view-selftests.c,
2741         unittests/lookup_name_info-selftests.c,
2742         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2743         unittests/mkdir-recursive-selftests.c,
2744         unittests/observable-selftests.c,
2745         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2746         unittests/parse-connection-spec-selftests.c,
2747         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2748         unittests/scoped_fd-selftests.c,
2749         unittests/scoped_mmap-selftests.c,
2750         unittests/scoped_restore-selftests.c,
2751         unittests/string_view-selftests.c, unittests/style-selftests.c,
2752         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2753         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2754         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2755         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2756         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2757         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2758
2759 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2760
2761         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2762         bool value.
2763         (decode_digits_ordinary): Set explicit_line field in sal.
2764         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2765         symtab_and_line that was set on an explicit line number in
2766         assembler code.  Do always update the recorded symtab and line if
2767         we do skip the prologue.
2768
2769 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * breakpoint.c (set_breakpoint_location_function): Remove
2772         explicit_loc parameter.
2773         (momentary_breakpoint_from_master): Update call to
2774         set_breakpoint_location_function.
2775         (add_location_to_breakpoint): Likewise.
2776
2777 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2778
2779         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2780         required features based on default bfd type when no specific bfd
2781         is present.
2782
2783 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2784
2785         * NEWS: Mention that GDB printf and eval commands can now print
2786         C-style and Ada-style convenience var strings without
2787         calling the inferior.
2788         * printcmd.c (printf_c_string): Locally print GDB internal var
2789         instead of transiting via the inferior.
2790         (printf_wide_c_string): Likewise.
2791
2792 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2793
2794         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2795
2796 2019-07-04  Tom Tromey  <tom@tromey.com>
2797
2798         PR tui/24724:
2799         * tui/tui-winsource.c (tui_clear_source_content): Update.
2800         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2801         (tui_update_breakpoint_info): Update.
2802         (tui_set_exec_info_content): Update.
2803         * tui/tui-source.c (tui_set_source_content_nil): Update.
2804         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2805         has_break.
2806         * tui/tui-data.h (enum tui_bp_flag): New.
2807         (tui_bp_flags): New enum flags type.
2808         (struct tui_source_element) <break_mode>: Change type.  Rename
2809         from has_break.
2810         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2811         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2812         constants.
2813         * tui/tui-winsource.h: Fix comment.
2814
2815 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2816
2817         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2818         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2819         (store_fpregs_to_thread)
2820         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2821         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2822         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2823         (IWMMXT_REGS_SIZE): Add define.
2824         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2825         (fetch_vfp_regs, store_vfp_regs)
2826         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2827         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2828
2829 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2830
2831         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2832         defines.
2833         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2834         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2835         (ARM_INT_REGISTER_SIZE): ...to this.
2836         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2837         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2838         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2839         (arm_linux_collect_gregset, supply_nwfpe_register)
2840         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2841         defines.
2842         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2843         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2844         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2845         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2846         (arm_return_in_memory, arm_store_return_value)
2847         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2848         (arm_record_ld_st_multiple): Likewise.
2849         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2850         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2851
2852 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2853
2854         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2855         AARCH64_DISPLACED_MODIFIED_INSNS.
2856         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2857         (aarch64_displaced_step_copy_insn): Likewise.
2858         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2859         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2860         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2861         ARM_DISPLACED_MODIFIED_INSNS.
2862         * arm-tdep.c (arm_gdbarch_init): Likewise.
2863         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2864         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2865         (struct arm_displaced_step_closure): Use
2866         ARM_DISPLACED_MODIFIED_INSNS.
2867
2868 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2869
2870         * features/Makefile: Remove unused xml files.
2871         * features/aarch64.xml: Remove.
2872         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2873         * features/i386/amd64-avx-avx512.xml: Remove.
2874         * features/i386/amd64-avx-linux.xml: Remove.
2875         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2876         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2877         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2878         * features/i386/amd64-avx-mpx.xml: Remove.
2879         * features/i386/amd64-avx.xml: Remove.
2880         * features/i386/amd64-linux.xml: Remove.
2881         * features/i386/amd64-mpx-linux.xml: Remove.
2882         * features/i386/amd64-mpx.xml: Remove.
2883         * features/i386/amd64.xml: Remove.
2884         * features/i386/i386-avx-avx512-linux.xml: Remove.
2885         * features/i386/i386-avx-avx512.xml: Remove.
2886         * features/i386/i386-avx-linux.xml: Remove.
2887         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2888         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2889         * features/i386/i386-avx-mpx-linux.xml: Remove.
2890         * features/i386/i386-avx-mpx.xml: Remove.
2891         * features/i386/i386-avx.xml: Remove.
2892         * features/i386/i386-linux.xml: Remove.
2893         * features/i386/i386-mmx-linux.xml: Remove.
2894         * features/i386/i386-mmx.xml: Remove.
2895         * features/i386/i386-mpx-linux.xml: Remove.
2896         * features/i386/i386-mpx.xml: Remove.
2897         * features/i386/i386.xml: Remove.
2898         * features/i386/x32-avx-avx512-linux.xml: Remove.
2899         * features/i386/x32-avx-linux.xml: Remove.
2900         * features/i386/x32-linux.xml: Remove.
2901
2902 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2903
2904         * regformats/aarch64.dat: Remove.
2905         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2906         * regformats/i386/amd64-avx-linux.dat: Remove.
2907         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2908         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2909         * regformats/i386/amd64-linux.dat: Remove.
2910         * regformats/i386/amd64-mpx-linux.dat: Remove.
2911         * regformats/i386/amd64.dat: Remove.
2912         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2913         * regformats/i386/i386-avx-linux.dat: Remove.
2914         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2915         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2916         * regformats/i386/i386-linux.dat: Remove.
2917         * regformats/i386/i386-mmx-linux.dat: Remove.
2918         * regformats/i386/i386-mpx-linux.dat: Remove.
2919         * regformats/i386/i386.dat: Remove.
2920         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2921         * regformats/i386/x32-avx-linux.dat: Remove.
2922         * regformats/i386/x32-linux.dat: Remove.
2923
2924 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2925
2926         * aarch64-tdep.c: Remove xml self tests.
2927         * amd64-linux-tdep.c: Likewise.
2928         * amd64-tdep.c: Likewise.
2929         * i386-linux-tdep.c: Likewise.
2930         * i386-tdep.c: Likewise.
2931
2932 2019-07-03  Pedro Alves  <palves@redhat.com>
2933
2934         PR cli/24732
2935         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2936         (pipe_cmd_option_defs): New.
2937         (make_pipe_cmd_options_def_group): New.
2938         (pipe_command): Use gdb::option::process_options.
2939         (pipe_command_completer): New function.
2940         (_initialize_cli_cmds): Install completer for "pipe" command.
2941
2942 2019-07-03  Pedro Alves  <palves@redhat.com>
2943
2944         * cli/cli-option.c (union option_value) <string>: New field.
2945         (struct option_def_and_value): Add ctor, move ctor, dtor and
2946         use DISABLE_COPY_AND_ASSIGN.
2947         (option_def_and_value::clear_value): New.
2948         (parse_option, save_option_value_in_ctx, get_val_type_str)
2949         (add_setshow_cmds_for_options): Handle var_string.
2950         * cli-option.h (union option_def::var_address) <string>: New
2951         field.
2952         (struct string_option_def): New.
2953         * maint-test-options.c (struct test_options_opts): Add default
2954         ctor and use DISABLE_COPY_AND_ASSIGN.
2955         <string_opt>: New field.
2956         (test_options_opts::~test_options_opts): New.
2957         (test_options_opts::dump): Also dump "-string".
2958         (test_options_option_defs): Install "string.
2959
2960 2019-07-03  Pedro Alves  <palves@redhat.com>
2961
2962         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2963         option_value with a null enumeration.
2964         (complete_options): Save the option values in the context.
2965         (save_option_value_in_ctx): New, factored out from ...
2966         (process_options): ... here.
2967         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2968         of the function.
2969         * maint-test-options.c (test_options_opts::dump): New, factored
2970         out from ...
2971         (maintenance_test_options_command_mode): ... here.
2972         (maintenance_test_options_command_completion_result): Delete.
2973         (maintenance_test_options_command_completion_text): Update
2974         comment.
2975         (maintenance_show_test_options_completion_result): Change
2976         prototype.  Just print
2977         maintenance_test_options_command_completion_text.
2978         (save_completion_result): New.
2979         (maintenance_test_options_completer_mode): Pass options context to
2980         complete_options, and then save a dump.
2981         (_initialize_maint_test_options): Use add_cmd to install "maint
2982         show test-options-completion-result".
2983
2984 2019-07-03  Pedro Alves  <palves@redhat.com>
2985
2986         * NEWS (New commands): Mention "with" and "maint with".
2987         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2988         (with_command, with_command_completer): New.
2989         (pipe_command): Adjust to new repeat_previous
2990         interface.
2991         (_initialize_cli_cmds): Install the "with" command and its "w"
2992         alias.
2993         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2994         declarations.
2995         * cli/cli-setshow.c (parse_cli_var_uinteger)
2996         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2997         argument strings for all var_types.
2998         (get_setshow_command_value_string): New, factored out from ...
2999         (do_show_command): ... this.
3000         * cli/cli-setshow.h: Include <string>.
3001         (get_setshow_command_value_string): Declare.
3002         * command.h (repeat_previous): Now returns const char *.  Adjust
3003         comment.
3004         * maint.c: Include "cli/cli-cmds.h".
3005         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3006         (_initialize_maint_cmds): Register the "maintenance with" command.
3007         * top.c (repeat_previous): Move bits from pipe_command here:
3008         Return the saved command line, if any; error out if there's no
3009         command to relaunch.
3010
3011 2019-07-03  Pedro Alves  <palves@redhat.com>
3012
3013         * NEWS (New commands): Mention "maint set/show test-settings"
3014         instead of "maint test-settings".
3015         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3016         (maintenance_test_settings_set_list): Rename to ...
3017         (maintenance_set_test_settings_list): ... this.
3018         (maintenance_test_settings_show_list): Rename to  ...
3019         (maintenance_show_test_settings_list): ... this.
3020         (maintenance_test_settings_cmd): Delete.
3021         (maintenance_test_settings_set_cmd): ...
3022         (maintenance_set_test_settings_cmd): ... this.
3023         (maintenance_test_settings_show_cmd): ...
3024         (maintenance_show_test_settings_cmd): ... this.
3025         (maintenance_test_settings_show_value_cmd):
3026         (maintenance_show_test_settings_value_cmd): ... this.
3027         (_initialize_maint_test_settings): No longer install the "maint
3028         test-settings" prefix command.  Rename "maint test-settings set"
3029         to "maint set test-settings", and "maint test-settings show" to
3030         "maint show test-settings".  Adjust all subcommands.
3031
3032 2019-07-03  Pedro Alves  <palves@redhat.com>
3033
3034         * maint-test-settings.c: Fix file's intro comment.  Replace all
3035         references to "test-options" with references to "test-settings",
3036         in comments.
3037
3038 2019-07-03  Pedro Alves  <palves@redhat.com>
3039
3040         * maint-test-settings.c (maintenance_test_settings_xxx)
3041         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3042         New.
3043         (maintenance_test_settings_enums): Use them.
3044         (maintenance_test_settings_enum): Default to
3045         maintenance_test_settings_xxx.
3046         (_initialize_maint_test_settings): Initialize
3047         MAINTENANCE_TEST_SETTINGS_FILENAME.
3048
3049 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3050
3051         * breakpoint.h (remove_breakpoints_inf): Change return type to
3052         void, move function documentation here.
3053         * breakpoint.c (remove_breakpoints_inf): Change return type to
3054         void, move function documentation to header.
3055
3056 2019-07-02  Pedro Alves  <palves@redhat.com>
3057
3058         * NEWS (Completion improvements): Mention "info threads".
3059         * thread.c (struct info_threads_opts, info_threads_option_defs)
3060         (make_info_threads_options_def_group): New.
3061         (info_threads_command): Use gdb::option::process_options.
3062         (info_threads_command_completer): New.
3063         (_initialize_thread): Use gdb::option::build_help to build the
3064         help text for "info threads".
3065
3066 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3067
3068         * defs.h (generic_load): Move from here...
3069         * symfile.h (generic_load): ... to here.  Rename name parameter
3070         to args.
3071         * symfile.c (generic_load): Add comment.
3072
3073 2019-07-01  Tom Tromey  <tromey@adacore.com>
3074
3075         * dwarf2read.c
3076         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3077         declaration of without_params.  Fix formatting.
3078
3079 2019-07-01  Tom Tromey  <tromey@adacore.com>
3080
3081         * ada-exp.y (find_primitive_type): Update.
3082         * ada-lang.h (ada_lookup_symbol): Update.
3083         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3084         parameter.
3085         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3086
3087 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3088
3089         PR breakpoints/24541
3090         * gdbarch.c: Regenerate.
3091         * gdbarch.h: Regenerate.
3092         * gdbarch.sh: Add 'stap_adjust_register'.
3093         * i386-tdep.c: Include '<unordered_set>'.
3094         (i386_stap_adjust_register): New function.
3095         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3096         * stap-probe.c (stap_parse_register_operand): Call
3097         'gdbarch_stap_adjust_register'.
3098
3099 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3100
3101         PR python/24742
3102         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3103         * python/python.c (do_start_initialization): Use 'xmalloc'
3104         instead of 'PyMem_Malloc'.
3105
3106 2019-06-28  Tom Tromey  <tromey@adacore.com>
3107
3108         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3109         for Ada.
3110
3111 2019-06-27  Tom Tromey  <tromey@adacore.com>
3112
3113         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3114         objfile_key.
3115         (arm_find_mapping_symbol, arm_record_special_symbol)
3116         (_initialize_arm_tdep): Update.
3117         (arm_objfile_data_free): Remove.
3118
3119 2019-06-27  Tom Tromey  <tromey@adacore.com>
3120
3121         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3122         to cp_print_static_field.
3123
3124 2019-06-26  Tom Tromey  <tromey@adacore.com>
3125
3126         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3127         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3128         declare.
3129
3130 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3131
3132         * features/aarch64-core.c (create_feature_aarch64_core):
3133         Regenerate.
3134         * features/aarch64-core.xml: Add cpsr flags.
3135
3136 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3137
3138         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3139         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3140
3141 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3142
3143         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3144         field.
3145         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3146         use.
3147         (arm_record_special_symbol): Don't insert new symbol in sorted
3148         position, push it at the end.
3149
3150 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3151
3152         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3153         (arm_mapping_symbol_s): Remove.
3154         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3155         (arm_mapping_symbol_vec): New typedef.
3156         (struct arm_per_objfile): Add constructor.
3157         <section_maps>: Change type to
3158         std::unique_ptr<arm_mapping_symbol_vec[]>.
3159         (arm_compare_mapping_symbols): Remove.
3160         (arm_find_mapping_symbol): Adjust to section_maps type change.
3161         (arm_objfile_data_free): Call delete on arm_per_objfile.
3162         (arm_record_special_symbol): Adjust to section_maps type change.
3163         Allocate arm_per_objfile with new.
3164
3165 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3166
3167         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3168         with the command prefix.
3169
3170 2019-06-25  Tom Tromey  <tom@tromey.com>
3171
3172         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3173         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3174
3175 2019-06-25  Tom Tromey  <tom@tromey.com>
3176
3177         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3178         type.
3179         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3180         protected.
3181
3182 2019-06-25  Tom Tromey  <tom@tromey.com>
3183
3184         * tui/tui-winsource.c
3185         (tui_source_window_base::set_is_exec_point_at): Add check against
3186         LOA_ADDRESS.
3187
3188 2019-06-25  Tom Tromey  <tom@tromey.com>
3189
3190         * tui/tui-source.c (tui_set_source_content): Don't check before
3191         xfree.
3192         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3193
3194 2019-06-25  Tom Tromey  <tom@tromey.com>
3195
3196         * tui/tui-winsource.h (tui_update_source_window_as_is)
3197         (tui_alloc_source_buffer, tui_line_is_displayed)
3198         (tui_addr_is_displayed): Change type of win_info.
3199         * tui/tui-winsource.c (tui_update_source_window_as_is)
3200         (tui_clear_source_content, tui_show_source_line)
3201         (tui_show_source_content, tui_source_window_base::refill)
3202         (tui_source_window_base::set_is_exec_point_at)
3203         (tui_source_window_base::set_is_exec_point_at)
3204         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3205         (tui_alloc_source_buffer, tui_line_is_displayed)
3206         (tui_addr_is_displayed): Change type of win_info.  Update.
3207         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3208         (tui_source_window_base::do_make_visible_with_new_height):
3209         Update.
3210         * tui/tui-source.c (tui_set_source_content)
3211         (tui_set_source_content_nil)
3212         (tui_source_window::do_scroll_vertical): Update.
3213         * tui/tui-layout.c (show_layout): Update.
3214         * tui/tui-disasm.c (tui_set_disassem_content)
3215         (tui_disasm_window::do_scroll_vertical): Update.
3216         * tui/tui-data.h (tui_win_content): Remove.
3217         (struct tui_gen_win_info) <content, content_size>: Remove.
3218         (struct tui_source_element): Add initializers and destructor.
3219         (union tui_which_element, struct tui_win_element): Remove.
3220         (struct tui_source_window_base) <content>: New field.
3221         (struct tui_data_window): Remove destructor.
3222         (tui_alloc_content, tui_free_win_content)
3223         (tui_free_all_source_wins_content): Don't declare.
3224         * tui/tui-data.c (tui_initialize_static_data): Update.
3225         (init_content_element, tui_alloc_content): Remove.
3226         (~tui_gen_win_info): Update.
3227         (~tui_data_window, tui_free_all_source_wins_content)
3228         (tui_free_win_content, free_content, free_content_elements):
3229         Remove.
3230
3231 2019-06-25  Tom Tromey  <tom@tromey.com>
3232
3233         * tui/tui-winsource.h (tui_clear_source_content)
3234         (tui_erase_source_content, tui_show_source_content): Change type
3235         of win_info.
3236         * tui/tui-winsource.c (tui_clear_source_content)
3237         (tui_erase_source_content, tui_show_source_content): Change type
3238         of win_info.
3239         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3240         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3241         win_info.
3242         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3243         win_info.
3244         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3245
3246 2019-06-25  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-winsource.c (tui_clear_source_content)
3249         (tui_source_window_base::set_is_exec_point_at): Update.
3250         * tui/tui-source.c (tui_set_source_content_nil): Update.
3251         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3252         a bool.
3253         * tui/tui-data.c (init_content_element): Update.
3254
3255 2019-06-25  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3258         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3259         * tui/tui-layout.c (init_and_make_win): Update.
3260         * tui/tui.h (enum tui_win_type): Update.
3261         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3262         tui_win_is_auxillary.
3263         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3264         tui_win_is_auxillary.
3265
3266 2019-06-25  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3269         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3270         (tui_delete_data_content_windows, tui_display_all_data)
3271         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3272         Update.
3273         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3274         * tui/tui-regs.c (tui_last_regs_line_no)
3275         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3276         (tui_show_registers): Update.
3277         (tui_show_register_group): Return void.  Update.
3278         (tui_display_registers_from, tui_display_reg_element_at_line)
3279         (tui_display_registers_from_line, tui_check_register_values):
3280         Update.
3281         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3282         member.
3283         (struct tui_data_window) <regs_content>: Now a std::vector.
3284         <regs_content_count>: Remove.
3285         (tui_add_content_elements, tui_free_data_content): Don't declare.
3286         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3287         (init_content_element): Remove DATA_WIN case.  Add assert.
3288         (tui_add_content_elements): Remove.
3289         (tui_data_window): Update.
3290         (tui_free_data_content): Remove.
3291         (free_content_elements): Remove DATA_WIN case.
3292
3293 2019-06-25  Tom Tromey  <tom@tromey.com>
3294
3295         * tui/tui-data.c (tui_data_item_window): Update.
3296         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3297         * tui/tui-windata.c (tui_display_all_data)
3298         (tui_display_data_from_line): Update.
3299         (tui_check_data_values): Remove.
3300         * tui/tui-regs.c (tui_show_register_group)
3301         (tui_display_reg_element_at_line): Update.
3302         * tui/tui-hooks.c (tui_register_changed)
3303         (tui_refresh_frame_and_register_information): Call
3304         tui_check_register_values.
3305         * tui/tui-data.h (struct tui_data_window) <data_content,
3306         data_content_count, data_type>: Remove.
3307         (enum tui_data_type): Remove.
3308
3309         * tui/tui-data.c (tui_data_window::clear_detail)
3310         (~tui_data_window): Update.
3311
3312 2019-06-25  Tom Tromey  <tom@tromey.com>
3313
3314         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3315         declare.
3316         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3317         Rename from tui_first_data_item_displayed.  Update.
3318         (tui_data_window::refresh_all)
3319         (tui_data_window::do_scroll_vertical): Update.
3320         * tui/tui-data.h (struct tui_data_window)
3321         <first_data_item_displayed>: Declare new method.
3322
3323 2019-06-25  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3326         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3327         contents...
3328         (tui_initialize_static_data): ...here.
3329
3330 2019-06-25  Tom Tromey  <tom@tromey.com>
3331
3332         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3333         (tui_display_registers_from, tui_check_register_values): Update.
3334         (tui_display_register): Remove win_info parameter; update.
3335         (tui_get_register): Change type of parameters.
3336         * tui/tui-data.h (struct tui_data_element): Remove.
3337         (union tui_which_element) <data>: Remove.
3338         <data_window>: Change type.
3339         (struct tui_data_item_window): New.
3340         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3341         case.  Add assert.
3342         (~tui_data_item_window): New destructor.
3343         (free_content_elements): Remove DATA_ITEM_WIN case.
3344
3345 2019-06-25  Tom Tromey  <tom@tromey.com>
3346
3347         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3348         Remove.
3349
3350 2019-06-25  Tom Tromey  <tom@tromey.com>
3351
3352         * tui/tui-data.h (struct tui_command_element): Remove.
3353         (union tui_which_element) <command>: Remove.
3354         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3355         assert.
3356         (free_content_elements): Remove CMD_WIN case.
3357
3358 2019-06-25  Tom Tromey  <tom@tromey.com>
3359
3360         * tui/tui-layout.c (tui_set_layout): Update.
3361         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3362         * tui/tui-data.c (layout_def): Update.
3363
3364 2019-06-25  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3367         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3368         (tui_source_window_base::set_new_height): Update.
3369         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3370         Update.
3371         (tui_set_locator_fullname, tui_set_locator_info)
3372         (tui_show_frame_info): Update.
3373         * tui/tui-source.c (tui_set_source_content)
3374         (tui_source_is_displayed): Update.
3375         * tui/tui-layout.c (show_source_disasm_command, show_data)
3376         (show_source_or_disasm_and_command): Update.
3377         * tui/tui-disasm.c (tui_set_disassem_content)
3378         (tui_get_begin_asm_address): Update.
3379         * tui/tui-data.h (struct tui_locator_element): Remove.
3380         (union tui_which_element) <locator>: Remove.
3381         (struct tui_locator_window): New.
3382         (tui_locator_win_info_ptr): Change return type.
3383         * tui/tui-data.c (_locator): Change type.
3384         (tui_locator_win_info_ptr): Change return type.
3385         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3386         (tui_alloc_content): Add assert.
3387
3388 2019-06-25  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-winsource.c
3391         (tui_exec_info_window::maybe_allocate_content): New method.
3392         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3393         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3394         (make_source_or_disasm_window): Add cast.
3395         * tui/tui-data.h (union tui_which_element) <simple_string>:
3396         Remove.
3397         (struct tui_source_info): New.
3398         (struct tui_source_window_base) <execution_info>: Change type.
3399         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3400         case, and add assert.
3401         (tui_alloc_content): Add assert.
3402
3403 2019-06-25  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3406         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3407         * tui/tui-data.c (tui_alloc_win_info): Remove.
3408
3409 2019-06-25  Tom Tromey  <tom@tromey.com>
3410
3411         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3412         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3413         can_highlight.
3414
3415 2019-06-25  Tom Tromey  <tom@tromey.com>
3416
3417         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3418         make_visible_with_new_height method.
3419         (tui_win_info::make_visible_with_new_height): New method.
3420         (tui_source_window_base::do_make_visible_with_new_height)
3421         (tui_data_window::do_make_visible_with_new_height)
3422         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3423         (make_visible_with_new_height): Remove.
3424         (tui_resize_all, tui_adjust_win_heights): Use
3425         make_visible_with_new_height method.
3426         * tui/tui-data.h (struct tui_win_info)
3427         <do_make_visible_with_new_height, make_visible_with_new_height>:
3428         New methods.
3429         (struct tui_source_window_base, struct tui_data_window)
3430         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3431         methods.
3432
3433 2019-06-25  Tom Tromey  <tom@tromey.com>
3434
3435         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3436         method.
3437         (update_tab_width): Call update_tab_width method.
3438         * tui/tui-data.h (struct tui_win_info)
3439         (struct tui_source_window_base) <update_tab_width>: New methods.
3440
3441 2019-06-25  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3444         parameter.
3445         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3446         parameter.
3447         (tui_gen_win_info::make_visible): Update.
3448         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3449         parameter.
3450         * tui/tui-data.h (enum tui_box): New enum.
3451         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3452
3453 2019-06-25  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3456         init_and_make_win for EXEC_INFO_WIN.
3457         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3458         longer inline.
3459         (struct tui_win_info) <~tui_win_info>: Inline.
3460         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3461         Don't declare.
3462         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3463         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3464         Remove.
3465         (tui_initialize_static_data): Update.
3466         (~tui_gen_win_info): Handle more cleanup here.
3467         (~tui_source_window_base): Delete "execution_info".
3468         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3469
3470 2019-06-25  Tom Tromey  <tom@tromey.com>
3471
3472         * tui/tui-layout.c (make_command_window): Don't set
3473         can_highlight.
3474         (show_source_disasm_command): Call the reset method.
3475         (show_data): Don't set can_highlight.  Call the reset method.
3476         (tui_gen_win_info::reset): Rename from init_gen_win_info
3477         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3478         (show_source_or_disasm_and_command): Call the reset method.
3479         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3480         (struct tui_cmd_window): Set can_highlight.
3481
3482 2019-06-25  Tom Tromey  <tom@tromey.com>
3483
3484         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3485         from make_visible.
3486         (tui_make_visible, tui_make_invisible): Rewrite.
3487         (tui_win_info::make_visible): Remove.
3488         (tui_source_window_base::make_visible): Update.
3489         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3490         method.  Moved from...
3491         (struct tui_win_info) <make_visible>: ...here.
3492
3493 2019-06-25  Tom Tromey  <tom@tromey.com>
3494
3495         * tui/tui-winsource.c
3496         (tui_source_window_base::do_scroll_horizontal): Remove direction
3497         parameter.
3498         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3499         direction parameter.
3500         * tui/tui-win.c (tui_win_info::forward_scroll)
3501         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3502         (tui_win_info::right_scroll): Update.
3503         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3504         direction parameter.
3505         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3506         direction parameter.
3507         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3508         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3509         Remove direction parameter.
3510         (struct tui_source_window_base, struct tui_source_window)
3511         (struct tui_disasm_window, struct tui_data_window)
3512         (struct tui_cmd_window): Update.
3513
3514 2019-06-25  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui-winsource.h (tui_set_exec_info_content)
3517         (tui_show_exec_info_content, tui_erase_exec_info_content)
3518         (tui_clear_exec_info_content, tui_update_exec_info): Change
3519         argument to tui_source_window_base.
3520         * tui/tui-winsource.c (tui_set_exec_info_content)
3521         (tui_show_exec_info_content, tui_erase_exec_info_content)
3522         (tui_clear_exec_info_content, tui_update_exec_info): Change
3523         argument to tui_source_window_base.
3524
3525 2019-06-25  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3528         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3529
3530 2019-06-25  Tom Tromey  <tom@tromey.com>
3531
3532         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3533         check.
3534
3535 2019-06-25  Tom Tromey  <tom@tromey.com>
3536
3537         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3538         type to void.
3539         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3540         type to void.
3541         * tui/tui-source.c (tui_set_source_content): Update.
3542         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3543
3544 2019-06-25  Tom Tromey  <tom@tromey.com>
3545
3546         * tui/tui-win.c (window_name_completer, tui_set_focus)
3547         (tui_all_windows_info): Use name method.
3548         * tui/tui-data.h (struct tui_gen_win_info)
3549         (struct tui_source_window, struct tui_disasm_window)
3550         (struct tui_data_window, struct tui_cmd_window) <name>: New
3551         method.
3552         (tui_win_name): Don't declare.
3553         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3554         (tui_win_name): Remove.
3555
3556 2019-06-25  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui-winsource.h (tui_update_source_window)
3559         (tui_update_source_window_as_is): Change parameter type.
3560         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3561         to be a tui_source_window_base.
3562         (tui_update_source_window_as_is): Likewise.
3563         * tui/tui-win.c (make_visible_with_new_height): Update.
3564
3565 2019-06-25  Tom Tromey  <tom@tromey.com>
3566
3567         * tui/tui-winsource.c (tui_erase_source_content)
3568         (tui_show_source_content, tui_show_exec_info_content)
3569         (tui_erase_exec_info_content): Use refresh_window method.
3570         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3571         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3572         from tui_refresh_win.
3573         (tui_data_window::refresh_window): New method.
3574         (tui_win_info::refresh, tui_source_window_base::refresh)
3575         (tui_refresh_all): Use refresh_window method.
3576         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3577         method.
3578         * tui/tui-regs.c (tui_display_register): Call refresh_window
3579         method.
3580         * tui/tui-layout.c (show_source_disasm_command)
3581         (show_source_or_disasm_and_command): Call refresh_window method.
3582         * tui/tui-data.h (struct tui_gen_win_info)
3583         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3584         New method.
3585
3586 2019-06-25  Tom Tromey  <tom@tromey.com>
3587
3588         * tui/tui.c (tui_rl_other_window, tui_enable)
3589         (tui_is_window_visible, tui_get_command_dimension): Update.
3590         * tui/tui-winsource.c (tui_update_source_window_as_is)
3591         (tui_clear_source_content, tui_erase_source_content)
3592         (tui_show_source_line, tui_source_window_base::refill)
3593         (tui_source_window_base::do_scroll_horizontal)
3594         (tui_source_window_base::set_is_exec_point_at)
3595         (tui_update_breakpoint_info, tui_set_exec_info_content)
3596         (tui_alloc_source_buffer, tui_line_is_displayed)
3597         (tui_addr_is_displayed): Update.
3598         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3599         (tui_check_and_display_highlight_if_needed)
3600         (tui_win_info::make_visible, tui_win_info::refresh)
3601         (tui_refresh_all): Update.
3602         * tui/tui-windata.c (tui_first_data_item_displayed)
3603         (tui_delete_data_content_windows, tui_erase_data_content)
3604         (tui_display_all_data, tui_data_window::refresh_all)
3605         (tui_check_data_values): Update.
3606         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3607         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3608         (tui_win_info::backward_scroll, tui_refresh_all_win)
3609         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3610         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3611         (tui_source_window_base::set_new_height)
3612         (tui_data_window::set_new_height)
3613         (make_invisible_and_set_new_height)
3614         (make_visible_with_new_height, new_height_ok)
3615         (parse_scrolling_args): Update.
3616         * tui/tui-stack.c (tui_show_frame_info): Update.
3617         * tui/tui-source.c (tui_set_source_content)
3618         (tui_set_source_content_nil, tui_source_is_displayed)
3619         (tui_source_window::do_scroll_vertical): Update.
3620         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3621         (tui_display_registers_from, tui_display_reg_element_at_line)
3622         (tui_check_register_values, tui_reg_command): Update.
3623         * tui/tui-layout.c (tui_default_win_height)
3624         (show_source_disasm_command, show_data, init_and_make_win)
3625         (show_source_or_disasm_and_command): Update.
3626         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3627         (tui_redisplay_readline, tui_mld_flush)
3628         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3629         (tui_getc): Update.
3630         * tui/tui-disasm.c (tui_set_disassem_content)
3631         (tui_disasm_window::do_scroll_vertical): Update.
3632         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3633         Now virtual.
3634         (struct tui_win_info): Derive from tui_gen_win_info.
3635         <~tui_win_info>: Mark as override.
3636         <generic>: Remove member.
3637         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3638         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3639         (~tui_data_window, ~tui_win_info)
3640         (tui_free_all_source_wins_content): Update.
3641         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3642
3643 2019-06-25  Tom Tromey  <tom@tromey.com>
3644
3645         * tui/tui-layout.c (init_and_make_win): Use new.
3646         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3647         destructor, initializers.
3648         (tui_alloc_generic_win_info): Don't declare.
3649         * tui/tui-data.c (_locator): Add argument to constructor.
3650         (source_win, disasm_win): New globals.
3651         (exec_info): Remove.
3652         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3653         Update.
3654         (tui_alloc_generic_win_info): Remove.
3655         (init_content_element): Use new.
3656         (tui_win_info::tui_win_info): Update.
3657         (free_content_elements) <case DATA_WIN>: Use delete.
3658
3659 2019-06-25  Tom Tromey  <tom@tromey.com>
3660
3661         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3662         * tui/tui-windata.c (tui_first_data_item_displayed)
3663         (tui_delete_data_content_windows): Update.
3664         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3665         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3666         (tui_display_registers_from, tui_check_register_values): Update.
3667         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3668         pointer.
3669         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3670         window.
3671         (tui_free_data_content): Update.
3672         (free_content_elements) <case DATA_WIN>: Free the window.
3673
3674 2019-06-25  Tom Tromey  <tom@tromey.com>
3675
3676         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3677         Update.
3678         * tui/tui-layout.c (make_command_window)
3679         (show_source_disasm_command, show_data, init_and_make_win)
3680         (show_source_or_disasm_and_command): Update.
3681         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3682         method.
3683         <can_highight, is_highlighted>: Now bool.
3684         (tui_set_win_highlight): Don't declare.
3685         * tui/tui-data.c (tui_set_win_highlight): Remove.
3686
3687 2019-06-25  Tom Tromey  <tom@tromey.com>
3688
3689         * tui/tui-wingeneral.c (make_visible): Remove check of window
3690         type.
3691
3692 2019-06-25  Tom Tromey  <tom@tromey.com>
3693
3694         * tui/tui-win.c (tui_win_info::max_height)
3695         (tui_cmd_window::max_height): New methods.
3696         (new_height_ok): Call max_height.
3697         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3698         <max_height>: New method.
3699
3700 2019-06-25  Tom Tromey  <tom@tromey.com>
3701
3702         * tui/tui-win.c (tui_source_window_base::set_new_height)
3703         (tui_data_window::set_new_height): New methods.
3704         (make_invisible_and_set_new_height): Call set_new_height method.
3705         * tui/tui-data.h (struct tui_win_info)
3706         (struct tui_source_window_base, struct tui_data_window)
3707         <set_new_height>: New method.
3708
3709 2019-06-25  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3712         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3713         tui_refresh_data_win.
3714         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3715         method.
3716         (tui_refresh_all_win): Call the refresh_all method.
3717         (tui_set_focus): Likewise.
3718         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3719         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3720         Likewise.
3721
3722 2019-06-25  Tom Tromey  <tom@tromey.com>
3723
3724         * tui/tui-winsource.h (tui_refill_source_window)
3725         (tui_set_is_exec_point_at): Don't declare.
3726         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3727         (tui_source_window_base::refill): Rename from
3728         tui_refill_source_window.
3729         (tui_source_window_base::do_scroll_horizontal): Update.
3730         (tui_source_window_base::set_is_exec_point_at): Rename from
3731         tui_set_is_exec_point_at.
3732         (tui_update_all_breakpoint_info): Update.
3733         * tui/tui-stack.c (tui_show_frame_info): Update.
3734         * tui/tui-layout.c (show_data): Add cast.
3735         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3736         * tui/tui-data.h (struct tui_source_window_base) <refill,
3737         set_is_exec_point_at>: New methods.
3738         (tui_source_windows, tui_add_to_source_windows): Update types.
3739         (tui_add_to_source_windows): Remove redundant declaration.
3740         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3741         (tui_source_windows): Change return type.
3742         (tui_clear_source_windows_detail): Update.
3743         (tui_add_to_source_windows): Change type of parameter.
3744         (tui_free_all_source_wins_content): Update.
3745
3746 2019-06-25  Tom Tromey  <tom@tromey.com>
3747
3748         * tui/tui-wingeneral.c (tui_win_info::refresh)
3749         (tui_source_window_base::refresh): New methods.
3750         (tui_refresh_all): Call the refresh method.
3751         * tui/tui-data.h (struct tui_win_info)
3752         (struct tui_source_window_base) <refresh>: New method.
3753
3754 2019-06-25  Tom Tromey  <tom@tromey.com>
3755
3756         * tui/tui.h (tui_is_window_visible): Return bool.
3757         * tui/tui.c (tui_is_window_visible): Return bool.
3758         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3759         (tui_make_visible, tui_make_invisible)
3760         (tui_win_info::make_visible)
3761         (tui_source_window_base::make_visible, make_all_visible)
3762         (tui_make_all_visible, tui_make_all_invisible): Update.
3763         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3764         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3765         bool.
3766         (struct tui_win_info, struct tui_source_window_base)
3767         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3768         * tui/tui-data.c (tui_init_generic_part): Update.
3769
3770 2019-06-25  Tom Tromey  <tom@tromey.com>
3771
3772         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3773         (tui_source_window_base::make_visible): New methods.
3774         (make_all_visible): Make method call.
3775         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3776         (struct tui_source_window_base, struct tui_cmd_window): Override
3777         make_visible.
3778         (tui_win_is_source_type): Don't declare.
3779         * tui/tui-data.c (tui_win_is_source_type): Remove.
3780
3781 2019-06-25  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3784         NULL check.
3785
3786 2019-06-25  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3789         Inline constructor.  Add initializers for members.
3790         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3791         constructors; now inline in class.
3792
3793 2019-06-25  Tom Tromey  <tom@tromey.com>
3794
3795         * tui/tui-regs.c (tui_show_registers): Update.
3796         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3797         bool.
3798         * tui/tui-data.c (tui_data_window::clear_detail)
3799         (tui_data_window): Update.
3800
3801 2019-06-25  Tom Tromey  <tom@tromey.com>
3802
3803         * tui/tui-windata.c (tui_display_all_data)
3804         (tui_display_data_from_line, tui_display_data_from)
3805         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3806         Update.
3807         * tui/tui-regs.c (tui_last_regs_line_no)
3808         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3809         (tui_show_registers, tui_show_register_group)
3810         (tui_display_registers_from, tui_display_reg_element_at_line)
3811         (tui_display_registers_from_line, tui_check_register_values)
3812         (tui_reg_next, tui_reg_prev): Update.
3813         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3814         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3815         tui_data_window.
3816         (struct tui_win_info) <detail>: Remove.  Add new fields from
3817         tui_data_info.
3818         (TUI_DATA_WIN): Add cast.
3819         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3820         (~tui_data_window): Simplify.
3821
3822 2019-06-25  Tom Tromey  <tom@tromey.com>
3823
3824         * tui/tui-layout.c (show_source_disasm_command)
3825         (show_source_or_disasm_and_command): Update.
3826         * tui/tui-io.c (update_cmdwin_start_line)
3827         (tui_redisplay_readline): Update.
3828         * tui/tui-data.h (struct tui_command_info): Remove.
3829         (struct tui_win_info) <detail>: Remove command_info member.
3830         (struct tui_data_window) <start_line>: New member, from
3831         tui_command_info.
3832         (TUI_CMD_WIN): Add casts.
3833
3834 2019-06-25  Tom Tromey  <tom@tromey.com>
3835
3836         * tui/tui-winsource.c (tui_update_source_window)
3837         (tui_refill_source_window)
3838         (tui_source_window_base::do_scroll_horizontal)
3839         (tui_update_breakpoint_info, tui_set_exec_info_content)
3840         (tui_show_exec_info_content, tui_erase_exec_info_content)
3841         (tui_clear_exec_info_content): Update.
3842         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3843         Update.
3844         * tui/tui-win.c (make_invisible_and_set_new_height)
3845         (make_visible_with_new_height): Update.
3846         * tui/tui-source.c (tui_set_source_content)
3847         (tui_show_symtab_source): Update.
3848         * tui/tui-layout.c (extract_display_start_addr)
3849         (show_source_disasm_command, show_data)
3850         (make_source_or_disasm_window)
3851         (show_source_or_disasm_and_command): Update.
3852         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3853         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3854         "gdbarch".
3855         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3856         to tui_source_window_base.
3857         (struct tui_win_info) <detail>: Remove source_info member.
3858         (struct tui_source_window_base) <has_locator>: Inline.
3859         Move contents from tui_source_info; rename has_locator member to
3860         m_has_locator.
3861         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3862         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3863         header file.
3864         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3865         Simplify.
3866         (tui_free_all_source_wins_content): Cast to
3867         tui_source_window_base.
3868
3869 2019-06-25  Tom Tromey  <tom@tromey.com>
3870
3871         * tui/tui-win.c (make_invisible_and_set_new_height)
3872         (make_visible_with_new_height): Call has_locator method.
3873         * tui/tui-layout.c (show_source_disasm_command, show_data)
3874         (show_source_or_disasm_and_command): Update for bool change.
3875         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3876         (tui_win_info) <has_locator>: New method.
3877         (struct tui_source_window_base) <has_locator>: New method.
3878         (tui_win_has_locator): Don't declare.
3879         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3880         from tui_win_has_locator.
3881         (tui_source_window_base): Use false, not FALSE.
3882
3883 2019-06-25  Tom Tromey  <tom@tromey.com>
3884
3885         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3886         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3887         clear_detail method directly.
3888         (tui_clear_win_detail): Remove.
3889
3890 2019-06-25  Tom Tromey  <tom@tromey.com>
3891
3892         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3893         "this", not TUI_DISASM_WIN.
3894
3895 2019-06-25  Tom Tromey  <tom@tromey.com>
3896
3897         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3898         declare.
3899         * tui/tui-winsource.c
3900         (tui_source_window_base::do_scroll_horizontal): Rename from
3901         tui_horizontal_source_scroll.
3902         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3903         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3904         from tui_vertical_data_scroll.
3905         * tui/tui-win.h (tui_scroll): Don't declare.
3906         * tui/tui-win.c (tui_win_info::forward_scroll)
3907         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3908         (tui_win_info::right_scroll): Rename and update.
3909         (tui_scroll_forward_command, tui_scroll_backward_command)
3910         (tui_scroll_left_command, tui_scroll_right_command): Update.
3911         (tui_scroll): Remove.
3912         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3913         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3914         from tui_vertical_source_scroll.
3915         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3916         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3917         from tui_vertical_disassem_scroll.
3918         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3919         do_scroll_horizontal>: New methods.
3920         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3921         Likewise.
3922         (struct tui_source_window_base): Add do_scroll_horizontal.
3923         (struct tui_source_window, struct tui_disasm_window): Add
3924         do_scroll_vertical.
3925         (struct tui_data_window, struct tui_cmd_window): Add
3926         do_scroll_horizontal and do_scroll_vertical.
3927         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3928
3929 2019-06-25  Tom Tromey  <tom@tromey.com>
3930
3931         * tui/tui-data.h (struct tui_source_window_base): New struct.
3932         (struct tui_source_window): Derive from tui_source_window_base.
3933         (struct tui_disasm_window): New struct.
3934         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3935         from tui_source_window::clear_detail.
3936         (tui_source_window_base): Rename from tui_source_window.
3937         (~tui_source_window_base): Rename from ~tui_source_window.
3938         (tui_alloc_win_info): Create a tui_disasm_window.
3939
3940 2019-06-25  Tom Tromey  <tom@tromey.com>
3941
3942         * tui/tui-data.h (struct tui_source_window)
3943         (struct tui_data_window): Declare destructors.
3944         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3945         destructors.
3946         (tui_win_info): Simplify.
3947
3948 2019-06-25  Tom Tromey  <tom@tromey.com>
3949
3950         * tui/tui-winsource.c (tui_display_main)
3951         (tui_update_source_windows_with_addr)
3952         (tui_update_all_breakpoint_info): Update.
3953         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3954         (new_height_ok, parse_scrolling_args): Update.
3955         * tui/tui-stack.c (tui_show_frame_info): Update.
3956         * tui/tui-data.h (struct tui_list): Remove.
3957         (tui_source_windows): Return a reference to a std::vector.
3958         * tui/tui-data.c (source_windows): Now a std::vector.
3959         (tui_source_windows): Change return type.
3960         (tui_clear_source_windows): Rewrite.
3961         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3962         (tui_free_all_source_wins_content): Rewrite.
3963
3964 2019-06-25  Tom Tromey  <tom@tromey.com>
3965
3966         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3967         (struct tui_data_window, struct tui_cmd_window): Declare
3968         clear_detail method.
3969         * tui/tui-data.c (tui_source_window::clear_detail)
3970         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3971         methods.
3972         (tui_clear_win_detail): Simplify.
3973
3974 2019-06-25  Tom Tromey  <tom@tromey.com>
3975
3976         * tui/tui-layout.c (make_source_window, make_disasm_window)
3977         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3978         Return the new window.
3979         (show_source_disasm_command, show_data)
3980         (show_source_or_disasm_and_command): Update.
3981
3982 2019-06-25  Tom Tromey  <tom@tromey.com>
3983
3984         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3985         parameter.  Return the new window.
3986         (show_source_disasm_command): Update and remove NULL check.
3987         (show_source_or_disasm_and_command): Update.
3988
3989 2019-06-25  Tom Tromey  <tom@tromey.com>
3990
3991         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3992
3993 2019-06-25  Tom Tromey  <tom@tromey.com>
3994
3995         * tui/tui-data.h (struct tui_win_info): Make constructor
3996         protected.  Make destructor virtual.  Add initializers.
3997         (tui_source_window, tui_data_window, tui_cmd_window): New
3998         classes.
3999         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4000         constructor.  Add "type" parameter.
4001         (tui_source_window, tui_data_window, tui_cmd_window): New
4002         constructors.
4003         (tui_alloc_win_info): Instantiate the appropriate subclass.
4004
4005 2019-06-25  Tom Tromey  <tom@tromey.com>
4006
4007         * tui/tui-win.c (tui_resize_all): Use delete.
4008         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4009         destructor.
4010         (tui_free_window): Don't declare.
4011         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4012         Update.
4013
4014 2019-06-25  Tom Tromey  <tom@tromey.com>
4015
4016         * tui/tui-data.h (struct tui_win_info): Add constructor.
4017         * tui/tui-data.c (tui_alloc_win_info): Use new.
4018         (tui_free_window): Use delete.
4019
4020 2019-06-22  Tom Tromey  <tom@tromey.com>
4021
4022         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4023         declare.
4024         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4025
4026 2019-06-22  Tom Tromey  <tom@tromey.com>
4027
4028         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4029         declare.
4030         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4031
4032 2019-06-22  Tom de Vries  <tdevries@suse.de>
4033
4034         * dwarf2read.c (create_addrmap_from_aranges)
4035         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4036         instead of '%zu'.
4037
4038 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4039
4040         * dwarf2read.h (dwarf2_section_info_def): Remove.
4041         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4042         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4043         std::vector<dwarf2_section_info>.
4044         (struct dwo_file) <~dwo_file>: Remove.
4045         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4046         types field.
4047         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4048         (dwarf2_read_debug_names): Likewise.
4049         (create_debug_types_hash_table): Change parameter type to
4050         array_view, adjust code accordingly.
4051         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4052         (partial_die_info::fixup): Likewise.
4053         (determine_prefix): Likewise.
4054         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4055
4056 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4057
4058         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4059         gdb_bfd_ref_ptr.
4060         <~dwo_file>: Remove call to gdb_bfd_unref.
4061         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4062         gdb_bfd_ref_ptr::get.
4063
4064 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4065
4066         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4067         type to htab_up.
4068         * dwarf2read.c (struct dwo_file): Initialize fields.
4069         <~dwo_file>: New.
4070         (free_dwo_file): Remove, move content to ~dwo_file.
4071         (struct dwo_file_deleter): Remove.
4072         (dwo_file_up>: Remove custom deleter.
4073         (free_dwo_files): Remove.
4074         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4075         dwo_files.
4076         (process_skeletonless_type_units): Call unique_ptr::get.
4077         (allocate_dwo_file_hash_table): Add deleter to created hash
4078         table.  Change return type to htab_up.
4079         (lookup_dwo_file_slot): Don't memset dwo_file, call
4080         unique_ptr::get.
4081         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4082         (create_dwo_unit_in_dwp_v2): Likewise.
4083         (open_and_init_dwo_file): Likewise.
4084         (free_dwo_file_from_slot): Remove.
4085
4086 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4087
4088         * dwarf2read.h (struct dwarf2_section_info) <readin,
4089         is_virtual>: Change type to bool.
4090         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4091         true instead of 1.
4092
4093 2019-06-19  Tom Tromey  <tom@tromey.com>
4094
4095         * tui/tui-data.h (tui_init_content_element): Don't declare.
4096
4097 2019-06-19  Tom Tromey  <tom@tromey.com>
4098
4099         * tui/tui-data.h (tui_init_win_info): Don't declare.
4100
4101 2019-06-19  Tom de Vries  <tdevries@suse.de>
4102
4103         * dwarf2read.h (abstract_to_concrete): Change type to
4104         std::unordered_map<sect_offset, std::vector<sect_offset>,
4105         gdb::hash_enum<sect_offset>>.
4106
4107 2019-06-19  Tom Tromey  <tromey@adacore.com>
4108
4109         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4110         EVAL_AVOID_SIDE_EFFECTS specially.
4111
4112 2019-06-19  Tom Tromey  <tromey@adacore.com>
4113
4114         * source-cache.c (highlighter): New global.
4115         (source_cache::get_source_lines): Create a highlighter on demand.
4116
4117 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4118
4119         * defs.h (deprecated_interactive_hook): Delete declaration.
4120         * interps.c (clear_interpreter_hooks): Remove use of
4121         deprecated_interactive_hook.
4122         * top.c (deprecated_interactive_hook): Delete definition.
4123         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4124
4125 2019-06-18  Tom de Vries  <tdevries@suse.de>
4126
4127         PR gdb/24515
4128         * dwarf2read.h (abstract_to_concrete): Change type from
4129         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4130         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4131         * dwarf2read.c (read_variable): Update.
4132         (dwarf2_fetch_die_loc_sect_off): Update.
4133
4134 2019-06-17  Tom de Vries  <tdevries@suse.de>
4135
4136         PR gdb/24617
4137         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4138         accessing parent[parent_len - 1].
4139
4140 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4141
4142         PR gdb/24364
4143         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4144         call dtrace_process_dof with NULL dof.
4145
4146 2019-06-16  Tom de Vries  <tdevries@suse.de>
4147
4148         PR gdb/24445
4149         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4150
4151 2019-06-16  Tom Tromey  <tom@tromey.com>
4152
4153         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4154         (make_all_visible): Use address of member.
4155
4156 2019-06-16  Tom Tromey  <tom@tromey.com>
4157
4158         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4159         (tui_free_window, free_content, free_content_elements): Remove
4160         unnecessary cast.
4161         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4162         cast.
4163         * tui/tui-regs.c (tui_show_register_group)
4164         (tui_display_registers_from, tui_display_reg_element_at_line):
4165         Remove unnecessary cast.
4166
4167 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4168
4169         * linux-nat.c (normal_mask): Delete.
4170         (_initialize_linux_nat): Don't initialise normal_mask.
4171
4172 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4173
4174         PR gdb/24445
4175         * dwarf-index-write.h (write_psymtabs_to_index): Add
4176         dwz_basename parameter.
4177         * dwarf-index-write.c (write_gdbindex): Move file writing to
4178         write_gdbindex_1.  Change return type void.
4179         (assert_file_size): Move up, remove filename parameter.
4180         (write_gdbindex_1): New function.
4181         (write_debug_names): Change return type to void, call
4182         assert_file_size.
4183         (struct index_wip_file): New struct.
4184         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4185         file logic to index_wip_file.  Write index for dwz file if
4186         needed.
4187         (save_gdb_index_command): Pass basename of dwz file, if present.
4188         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4189         build-id of dwz file, if present.
4190         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4191         (dwarf2_get_dwz_file): Likewise.
4192         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4193         (dwarf2_get_dwz_file): Likewise.
4194
4195 2019-06-16  Tom Tromey  <tom@tromey.com>
4196
4197         * coffread.c (process_coff_symbol): Use xstrdup.
4198         * value.c (create_internalvar): Use xstrdup.
4199
4200 2019-06-16  Tom Tromey  <tom@tromey.com>
4201
4202         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4203         * breakpoint.c (stopin_command, stopat_command)
4204         (until_break_command, decode_location_default): Remove unnecessary
4205         cast.
4206         * utils.c (subset_compare): Remove unnecessary cast.
4207         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4208         cast.
4209         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4210         cast.
4211         * infcmd.c (path_command): Remove unnecessary cast.
4212         * coffread.c (decode_type): Remove unnecessary cast.
4213         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4214         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4215         * tui/tui-stack.c (tui_show_locator_content)
4216         (tui_show_frame_info): Remove unnecessary cast.
4217         * tui/tui-win.c (tui_scroll_forward_command)
4218         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4219         (parse_scrolling_args): Remove unnecessary cast.
4220         * tui/tui-data.c (init_win_info, tui_del_window)
4221         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4222         (free_content_elements): Remove unnecessary cast.
4223         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4224         unnecessary cast.
4225         * tui/tui-source.c (tui_set_source_content)
4226         (tui_vertical_source_scroll): Remove unnecessary cast.
4227         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4228         cast.
4229         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4230         * tui/tui-regs.c (tui_display_registers_from)
4231         (tui_display_register): Remove unnecessary cast.
4232         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4233         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4234         (make_visible): Remove unnecessary cast.
4235         * tui/tui-winsource.c (tui_erase_source_content)
4236         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4237         unnecessary cast.
4238         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4239         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4240         * stabsread.c (read_type, read_array_type, read_range_type):
4241         Remove unnecessary cast.
4242         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4243         (parse_symbol, parse_type, upgrade_type, parse_external)
4244         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4245         unnecessary cast.
4246         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4247
4248 2019-06-16  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui-data.c (tui_alloc_generic_win_info)
4251         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4252         checks.
4253
4254 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4255             Andrew Burgess  <andrew.burgess@embecosm.com>
4256
4257         * f-typeprint.c (f_print_type): Don't return early for not
4258         associated or not allocated types.
4259         (f_type_print_varspec_suffix): Add print_rank parameter and print
4260         ranks of array types in case they dangling.
4261         (f_type_print_base): Add print_rank parameter.
4262
4263 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4264
4265         * NEWS: Mention new MI commands.
4266         * break-catch-throw.c (enum exception_event_kind): Move to
4267         breakpoint.h.
4268         (print_mention_exception_catchpoint): Output text as a single
4269         message.
4270         (catch_exception_command_1): Rename to...
4271         (catch_exception_event): ...this, make non-static, update header
4272         command, and change some parameter types.
4273         (catch_catch_command): Update for changes to
4274         catch_exception_command_1.
4275         (catch_throw_command): Likewise.
4276         (catch_rethrow_command): Likewise.
4277         * breakpoint.c (enum exception_event_kind): Delete.
4278         * breakpoint.h (enum exception_event_kind): Moved here from
4279         break-catch-throw.c.
4280         (catch_exception_event): Declare.
4281         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4282         (mi_cmd_catch_throw): New function.
4283         (mi_cmd_catch_rethrow): New function.
4284         (mi_cmd_catch_catch): New function.
4285         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4286         'catch-catch' entries.
4287         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4288         (mi_cmd_catch_rethrow): Declare.
4289         (mi_cmd_catch_catch): Declare.
4290
4291 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4292
4293         * annotate.c (annotate_source_line): Change return type to void,
4294         update implementation to match.
4295         * annotate.h (annotate_source_line): Change return type to void,
4296         update header comment.
4297         * stack.c (print_frame_info): Don't change what frame information
4298         is printed based on whether annotations are on or not.
4299
4300 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4301
4302         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4303         (annotate_source): Make static.
4304         (annotate_source_line): Moved from source.c and renamed from
4305         identify_source_line.  Update the return type.
4306         * annotate.h (annotate_source): Delete declaration.
4307         (annotate_source_line): Declaration moved from source.h, and
4308         renamed from identify_source_line.  Return type updated.
4309         * source.c (identify_source_line): Moved to annotate.c and renamed
4310         to annotate_source_line.
4311         (info_line_command): Remove check of annotation_level.
4312         * source.h (identify_source_line): Move declaration to annotate.h
4313         and rename to annotate_source_line.
4314         * stack.c: Add 'annotate.h' include.
4315         (print_frame_info): Remove check of annotation_level before
4316         calling annotate_source_line.
4317
4318 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4319
4320         * source-cache.c (source_cache::get_plain_source_lines): Use
4321         open_source_file_with_line_charpos instead of just
4322         open_source_file, remove call to find_source_lines.
4323         (source_cache::get_source_lines): Likewise.
4324         * source.c (find_source_lines): Make static.
4325         (get_filename_and_charpos): Renamed into...
4326         (open_source_file_with_line_charpos): ..this along with changes to
4327         return a scoped_fd, and some other minor clean ups.
4328         (identify_source_line): Use open_source_file_with_line_charpos.
4329         (search_command_helper): Use open_source_file_with_line_charpos
4330         instead of just open_source_file, remove call to
4331         find_source_lines.
4332         * source.h (open_source_file_with_line_charpos): Declare new
4333         function.
4334         (find_source_lines): Delete declaration.
4335
4336 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4337
4338         * source.c (get_filename_and_charpos): Remove fullname
4339         parameter.
4340         (identify_source_line): Update call to get_filename_and_charpos.
4341
4342 2019-06-14  Tom Tromey  <tromey@adacore.com>
4343
4344         PR gdb/24502:
4345         * ui-style.h (skip_ansi_escape): Update comment.
4346         * ui-file.h (class no_terminal_escape_file): New class.
4347         * ui-file.c (no_terminal_escape_file::write)
4348         (no_terminal_escape_file::puts): New methods.
4349         * cli/cli-logging.c (handle_redirections): Use
4350         no_terminal_escape_file.
4351
4352 2019-06-14  Tom Tromey  <tromey@adacore.com>
4353
4354         * NEWS: Move convenience variable news above Python news.
4355
4356 2019-06-14  Tom Tromey  <tom@tromey.com>
4357
4358         * gnulib: Move directory to top-level.
4359         * configure.ac: Don't configure gnulib.
4360         * configure: Rebuild.
4361         * common/common-defs.h: Use new path to gnulib.
4362         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4363         (GNULIB_H): Remove.
4364         (INCGNU): Look in new gnulib location.
4365         (HFILES_NO_SRCDIR): Remove gnulib files.
4366         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4367         (generated_files): Remove GNULIB_H.
4368         ($(LIBGNU), all-lib): Remove targets.
4369         (distclean): Don't mention GNULIB_BUILDDIR.
4370         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4371
4372 2019-06-14  Tom Tromey  <tromey@adacore.com>
4373
4374         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4375         Warn if symbol file does not provide any symbols.
4376
4377 2019-06-14  Tom Tromey  <tromey@adacore.com>
4378
4379         * source.c (find_and_open_source): Respect basenames_may_differ.
4380
4381 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4382
4383         * annotate.c (annotate_breakpoints_invalid): Make use of
4384         scoped_restore_terminal_state.
4385         (annotate_frames_invalid): Likewise.
4386
4387 2019-06-14  Tom Tromey  <tromey@adacore.com>
4388
4389         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4390         allow assignment to an internalvar.
4391
4392 2019-06-14  Tom Tromey  <tromey@adacore.com>
4393
4394         * ada-lex.l: Allow "_" in attribute names.
4395
4396 2019-06-14  Tom Tromey  <tromey@adacore.com>
4397
4398         PR gdb/24653:
4399         * regcache.c (registers_changed): Don't call alloca.
4400         * top.c (execute_command): Don't call alloca.
4401
4402 2019-06-13  Pedro Alves  <palves@redhat.com>
4403
4404         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4405         'expression'.  When parsing an expression, error out if there's
4406         junk after "unlimited".
4407         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4408         (do_set_command): Adjust calls to is_unlimited_literal.
4409
4410 2019-06-13  Pedro Alves  <palves@redhat.com>
4411
4412         * compile/compile.c (make_compile_options_def_group): Add braces
4413         around array_view initializer.
4414         * thread.c (make_thread_apply_all_options_def_group)
4415         (make_thread_apply_all_options_def_group): Likewise.
4416
4417 2019-06-13  Pedro Alves  <palves@redhat.com>
4418
4419         * NEWS (New commands): Mention "maint test-options
4420         require-delimiter", "maint test-options unknown-is-error", "maint
4421         test-options unknown-is-operand" and "maint show
4422         test-options-completion-result".
4423         (New command options, command completion): New section.
4424         (Completion improvements): New section.
4425         Mention that you can abbreviate "unlimited".
4426
4427 2019-06-13  Pedro Alves  <palves@redhat.com>
4428
4429         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4430         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4431         * unittests/cli-utils-selftests.c (test_parse_flags)
4432         (test_parse_flags_qcs): Delete.
4433         (test_cli_utils): Don't call deleted functions.
4434
4435 2019-06-13  Pedro Alves  <palves@redhat.com>
4436
4437         * thread.c: Include "cli/cli-option.h".
4438         (tp_array_compar_ascending): Global.
4439         (tp_array_compar): Delete function.
4440         (tp_array_compar_ascending, tp_array_compar_descending): New
4441         functions.
4442         (ascending_option_def, qcs_flag_option_def)
4443         (thr_qcs_flags_option_defs)
4444         (make_thread_apply_all_options_def_group)
4445         (make_thread_apply_options_def_group): New.
4446         (thread_apply_all_command): Use gdb::option::process_options.
4447         (thread_apply_command_completer)
4448         (thread_apply_all_command_completer): New.
4449         (thread_apply_command): Use gdb::option::process_options.
4450         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4451         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4452         to generate help text of "thread apply".  Adjust "taas"'s help.
4453         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4454         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4455
4456 2019-06-13  Pedro Alves  <palves@redhat.com>
4457
4458         * thread.c (thread_apply_command): Check for invalid TID with
4459         isdigit instead of !isalpha.
4460
4461 2019-06-13  Pedro Alves  <palves@redhat.com>
4462
4463         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4464         (validate_flags_qcs): New.
4465         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4466         (validate_flags_qcs): Declare.
4467         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4468         (make_frame_apply_options_def_group): New.
4469         (frame_apply_command_count): Process options with
4470         gdb::option::process_options.
4471         (frame_apply_completer): New.
4472         (frame_apply_level_completer, frame_apply_all_completer)
4473         (frame_apply_completer): New.
4474         (_initialize_stack): Update help of "frame apply", "frame apply
4475         level", "frame apply all" and "faas" to mention supported options
4476         and install command completers.
4477         * stack.h (frame_apply_all_completer): Declare.
4478         * thread.c: Include "stack.h".
4479         (tfaas_command): Add "--".
4480         (_initialize_thread): Update help "tfaas" to mention supported
4481         options and install command completer.
4482
4483 2019-06-13  Pedro Alves  <palves@redhat.com>
4484
4485         * completer.c (complete_nested_command_line): New.
4486         (gdb_completion_word_break_characters_throw): Add assertion.
4487         * completer.h (complete_nested_command_line): Declare.
4488
4489 2019-06-13  Pedro Alves  <palves@redhat.com>
4490
4491         * stack.c (parse_backtrace_qualifiers): New.
4492         (backtrace_command): Use it.
4493         (backtrace_command_completer): Complete on qualifiers.
4494
4495 2019-06-13  Pedro Alves  <palves@redhat.com>
4496
4497         * frame.c: Include "cli/cli-option.h.
4498         (user_set_backtrace_options): New.
4499         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4500         Delete.
4501         (get_prev_frame): Adjust.
4502         (boolean_option_def, uinteger_option_def)
4503         (set_backtrace_option_defs): New.
4504         (_initialize_frame): Adjust and use
4505         gdb::option::add_setshow_cmds_for_options to install "set
4506         backtrace past-main" and "set backtrace past-entry".
4507         * frame.h: Include "cli/cli-option.h".
4508         (struct frame_print_options): Forward declare.
4509         (print_frame_arguments_all, print_frame_arguments_scalars)
4510         (print_frame_arguments_none): Declare.
4511         (print_entry_values): Delete declaration.
4512         (struct frame_print_options, user_frame_print_options): New.
4513         (struct set_backtrace_options): New.
4514         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4515         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4516         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4517         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4518         (list_args_or_locals): Add frame_print_options parameter.
4519         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4520         * python/py-framefilter.c (enumerate_args): Pass down
4521         USER_FRAME_PRINT_OPTIONS.
4522         * stack.c: Include "cli/cli-option.h".
4523         (print_frame_arguments_all, print_frame_arguments_scalars)
4524         (print_frame_arguments_none): Declare.
4525         (print_raw_frame_arguments, print_entry_values): Delete.
4526         (user_frame_print_options): New.
4527         (boolean_option_def, enum_option_def, frame_print_option_defs):
4528         New.
4529         (struct backtrace_cmd_options): New.
4530         (bt_flag_option_def): New.
4531         (backtrace_command_option_defs): New.
4532         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4533         (print_frame_arg, read_frame_arg, print_frame_args)
4534         (print_frame_info, print_frame): Add frame_print_options parameter
4535         and use it.
4536         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4537         (backtrace_command_1): Add frame_print_options and
4538         backtrace_cmd_options parameters and use them.
4539         (make_backtrace_options_def_group): New.
4540         (backtrace_command): Process command options with
4541         gdb::option::process_options.
4542         (backtrace_command_completer): New.
4543         (_initialize_stack): Extend "backtrace"'s help to mention
4544         supported options.  Install completer for "backtrace".
4545         Install some settings commands with add_setshow_cmds_for_options.
4546
4547 2019-06-13  Pedro Alves  <palves@redhat.com>
4548
4549         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4550         and that "set/show print raw frame-arguments" are now deprecated.
4551
4552         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4553         command.
4554         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4555         * stack.c (_initialize_stack): Install "set/show print
4556         raw-frame-arguments", and deprecate "set/show print raw
4557         frame-arguments".
4558         * valprint.c (_initialize_valprint): Deprecate "set/show print
4559         raw".
4560
4561 2019-06-13  Pedro Alves  <palves@redhat.com>
4562
4563         * compile/compile.c (struct compile_options): New.
4564         (compile_flag_option_def, compile_command_option_defs)
4565         (make_compile_options_def_group): New.
4566         (compile_file_command): Handle options with
4567         gdb::option::process_options.
4568         (compile_file_command_completer): New function.
4569         (compile_code_command): Handle options with
4570         gdb::option::process_options.
4571         (compile_code_command_completer): New function.
4572         (_initialize_compiler): Install completers for "compile code" and
4573         "compile file".  Mention available options in "compile code" and
4574         "compile code"'s help.
4575         * completer.c (advance_to_completion_word): New, factored out from
4576         ...
4577         (advance_to_expression_complete_word_point): ... this.
4578         (advance_to_filename_complete_word_point): New.
4579         * completer.h (advance_to_filename_complete_word_point): New
4580         declaration.
4581
4582 2019-06-13  Pedro Alves  <palves@redhat.com>
4583
4584         * compile/compile.c: Include "cli/cli-option.h".
4585         (compile_print_value): Scope data pointer is now a
4586         value_print_options pointer; adjust.
4587         (compile_print_command): Process options.  Scope data pointer is
4588         now a value_print_options pointer; adjust.
4589         (_initialize_compile): Update "compile print"'s help to include
4590         supported options.  Install a completer for "compile print".
4591         * cp-valprint.c (show_vtblprint, show_objectprint)
4592         (show_static_field_print): Delete.
4593         (_initialize_cp_valprint): Don't install "set print
4594         static-members", "set print vtbl", "set print object" here.
4595         * printcmd.c: Include "cli/cli-option.h" and
4596         "common/gdb_optional.h".
4597         (print_command_parse_format): Rework to fill in a
4598         value_print_options instead of a format_data.
4599         (print_value): Change parameter type from format_data pointer to
4600         value_print_options reference.  Adjust.
4601         (print_command_1): Process options.  Adjust to pass down a
4602         value_print_options.
4603         (print_command_completer): New.
4604         (_initialize_printcmd): Install print_command_completer as
4605         handle_brkchars completer for the "print" command.  Update
4606         "print"'s help to include supported options.
4607         * valprint.c: Include "cli/cli-option.h".
4608         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4609         here from cp-valprint.c.
4610         (boolean_option_def, uinteger_option_def)
4611         (value_print_option_defs, make_value_print_options_def_group):
4612         New.  Use gdb::option::add_setshow_cmds_for_options to install
4613         "set print elements", "set print null-stop", "set print repeats",
4614         "set print pretty", "set print union", "set print array", "set
4615         print address", "set print symbol", "set print array-indexes".
4616         * valprint.h: Include <string> and "cli/cli-option.h".
4617         (make_value_print_options_def_group): Declare.
4618         (print_value): Change parameter type from format_data pointer to
4619         value_print_options reference.
4620         (print_command_completer): Declare.
4621
4622 2019-06-13  Pedro Alves  <palves@redhat.com>
4623
4624         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4625         (COMMON_SFILES): Add maint-test-settings.c.
4626         * cli/cli-decode.c (boolean_enums): New global, factored out from
4627         ...
4628         (add_setshow_boolean_cmd): ... here.
4629         * cli/cli-decode.h (boolean_enums): Declare.
4630         * cli/cli-option.c: New file.
4631         * cli/cli-option.h: New file.
4632         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4633         factored out from ...
4634         (parse_cli_boolean_value(const char *)): ... this.
4635         (is_unlimited_literal): Change parameter type to pointer to
4636         pointer.  Adjust and advance ARG pointer.
4637         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4638         (parse_cli_var_enum): New, factored out from ...
4639         (do_set_command): ... this.  Adjust.
4640         * cli/cli-setshow.h (parse_cli_boolean_value)
4641         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4642         (parse_cli_var_enum): Declare.
4643         * cli/cli-utils.c: Include "cli/cli-option.h".
4644         (get_ulongest): New.
4645         * cli/cli-utils.h (get_ulongest): Declare.
4646         (check_for_argument): New overloads.
4647         * maint-test-options.c: New file.
4648
4649 2019-06-13  Pedro Alves  <palves@redhat.com>
4650
4651         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4652         parse a range if "-" is at the end of the string.
4653
4654 2019-06-13  Pedro Alves  <palves@redhat.com>
4655
4656         * cli/cli-setshow.c (parse_auto_binary_operation)
4657         (parse_cli_boolean_value): Don't allow "o".
4658
4659 2019-06-13  Pedro Alves  <palves@redhat.com>
4660
4661         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4662         * NEWS: Mention maint test-settings KIND.
4663         * maint-test-settings.c: New file.
4664
4665 2019-06-13  Pedro Alves  <palves@redhat.com>
4666
4667         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4668         completer.
4669         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4670         "set" completers.
4671
4672 2019-06-13  Pedro Alves  <palves@redhat.com>
4673
4674         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4675         after item.
4676
4677 2019-06-13  Pedro Alves  <palves@redhat.com>
4678
4679         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4680
4681 2019-06-13  Pedro Alves <palves@redhat.com>
4682
4683         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4684         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4685         call.
4686         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4687         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4688         calls.
4689         (check_for_argument): Skip spaces after argument.
4690
4691 2019-06-13  Pedro Alves  <palves@redhat.com>
4692
4693         * thread.c (thread_apply_command): Adjust TID parsing.
4694         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4695         detected before end of string.
4696         (tid_is_in_list): Error out if LIST is invalid.
4697
4698 2019-06-13  Pedro Alves  <palves@redhat.com>
4699
4700         * completer.c (complete_line_internal_1): Rewind completion word
4701         point.
4702         (completion_tracker::advance_custom_word_point_by): Change
4703         parameter type to int.
4704         * completer.h (completion_tracker::advance_custom_word_point_by):
4705         Likewise.
4706
4707 2019-06-13  Pedro Alves  <palves@redhat.com>
4708
4709         * completer.c (advance_to_completion_word): Handle delimiters.
4710
4711 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4712
4713         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4714
4715 2019-06-11  Tom Tromey  <tom@tromey.com>
4716
4717         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4718         (xmalloc_failed): Move to alloc.c.
4719         * alloc.c: New file.
4720         * Makefile.in (COMMON_SFILES): Add alloc.c.
4721
4722 2019-06-11  Tom Tromey  <tom@tromey.com>
4723
4724         * nat/linux-waitpid.c: Don't include server.h.
4725         (linux_debug): Remove.
4726         (my_waitpid): Update.
4727
4728 2019-06-11  Tom Tromey  <tromey@adacore.com>
4729
4730         * infcall.c (_initialize_infcall): Remove trailing newline from
4731         help.
4732         * user-regs.c (_initialize_user_regs): Remove trailing newline
4733         from help.
4734         * typeprint.c (_initialize_typeprint): Remove trailing newline
4735         from help.
4736         * reverse.c (_initialize_reverse): Remove trailing newlines from
4737         help.
4738         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4739         from help.
4740         * language.c (add_set_language_command): Remove trailing newline
4741         from help.
4742         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4743         help.
4744         * disasm.c (_initialize_disasm): Remove trailing newline from
4745         help.
4746         * top.c (init_main): Remove trailing newline from help.
4747         * interps.c (_initialize_interpreter): Remove trailing newline
4748         from help.
4749         * btrace.c (_initialize_btrace): Remove trailing newlines from
4750         help.
4751         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4752         from help.
4753         * python/python.c (_initialize_python): Remove trailing newline
4754         from help.
4755         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4756         help.
4757         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4758         from help.  Reformat some text.
4759         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4760         from help.
4761         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4762         newline from help.
4763
4764 2019-06-11  Tom Tromey  <tromey@adacore.com>
4765
4766         * darwin-nat.c (darwin_decode_exception_message)
4767         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4768
4769 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4770
4771         * valops.c (value_slice): Check for not allocated or not
4772         associated values.
4773
4774 2019-06-10  Tom de Vries  <tdevries@suse.de>
4775
4776         PR gdb/24618
4777         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4778         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4779         invalid.
4780
4781 2019-06-10  Tom de Vries  <tdevries@suse.de>
4782
4783         PR gdb/24611
4784         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4785         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4786
4787 2019-06-10  Tom de Vries  <tdevries@suse.de>
4788
4789         PR symtab/24545
4790         * symtab.c (struct demangled_name_entry): Add language field.
4791         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4792         static minimal symbol".  Set and use language field.
4793
4794 2019-06-10  Tom Tromey  <tromey@adacore.com>
4795
4796         * ada-lang.c (_initialize_ada_language): Update help text.
4797
4798 2019-06-10  Tom Tromey  <tromey@adacore.com>
4799
4800         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4801         with a newline.
4802         * guile/guile.c (handle_boot_error): Don't end warning with a
4803         newline.
4804         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4805         warning with a newline.
4806         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4807         newline.
4808         (s12z_frame_cache): Likewise.
4809         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4810         a newline.
4811         * solib-svr4.c (disable_probes_interface): Don't end warning with
4812         a newline.
4813         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4814         newline.
4815         * python/python.c (do_finish_initialization): Don't end warning
4816         with a newline.
4817
4818 2019-06-10  Tom Tromey  <tom@tromey.com>
4819
4820         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4821         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4822         gdbpy_enter.
4823
4824 2019-06-10  Tom Tromey  <tromey@adacore.com>
4825
4826         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4827         data.
4828         (elf_new_init): Don't call stabsread_new_init.
4829         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4830         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4831         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4832
4833 2019-06-10  Tom de Vries  <tdevries@suse.de>
4834
4835         PR symtab/16264
4836         PR symtab/24517
4837         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4838
4839 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4840
4841         * source.c (find_and_open_source): Also rewrite relative file
4842         names.
4843
4844 2019-04-26  Amos Bird  <amosbird@gmail.com>
4845
4846         * annotate.c (annotate_thread_exited): Add "thread-exited"
4847         annotation.
4848
4849 2019-06-06  Tom Tromey  <tromey@adacore.com>
4850
4851         * maint.h (class scoped_command_stats): Use
4852         DISABLE_COPY_AND_ASSIGN.
4853         <print_time>: New method.
4854         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4855         print_time.
4856         (scoped_command_stats::print_time): New method.
4857
4858 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4859
4860         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4861         instructions of lengths 6 or 8 bytes.
4862
4863 2019-06-04  Pedro Alves  <palves@redhat.com>
4864
4865         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4866
4867         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4868         * breakpoint.c (condition_completer): Likewise.
4869         * cli/cli-dump.c (scan_expression): Likewise.
4870         * common/filestuff.c (mkdir_recursive): Likewise.
4871         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4872         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4873         (gdb_abspath): Likewise.
4874         * compile/compile-cplus-types.c
4875         (compile_cplus_instance::decl_name): Likewise.
4876         * completer.c (complete_explicit_location):
4877         (signal_completer, reg_or_group_completer_1): Likewise.
4878         * cp-support.c (cp_remove_params_if_any): Likewise.
4879         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4880         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4881         * infcmd.c (strip_bg_char): Likewise.
4882         * linespec.c (copy_token_string): Likewise.
4883         * mi/mi-main.c (output_cores): Likewise.
4884         * psymtab.c (psymtab_search_name):
4885         * symfile.c (test_set_ext_lang_command): Likewise.
4886         * target.c (target_fileio_read_stralloc): Likewise.
4887         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4888         * value.c (complete_internalvar): Likewise.
4889
4890 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4891
4892         Add objfile property to gdb.Type.
4893         * NEWS: Mention Python API addition.
4894         * python/py-type.c (typy_get_objfile): New method.
4895
4896 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4897
4898         * NEWS: Mention the new set|show style [title|highlight].
4899         Mention changes to "show style", "help" and "apropos".
4900
4901 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4902
4903         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4904         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4905         instead of print_help_for_command.
4906         (print_doc_of_command): New function.
4907         (help_list): Add 'apropos -v word' suggestion.
4908         (print_help_for_command): Style the command name using title style.
4909         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4910         (_initialize_cli_cmds): Describe -v in apropos_command help.
4911
4912 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4913
4914         * cli/cli-style.h (cli_style_option): Add name in constructor,
4915         add m_name class member, add constructor with intensity,
4916         add name class function.
4917         (cli_style_option::add_setshow_commands): Remove name argument.
4918         (highlight_style, title_style): New styles.
4919         * cli/cli-style.c (do_show): New function that shows a style
4920         characteristic styling the style name with itself.
4921         (set_style_name): New function.
4922         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4923         Update all callers according to the changes in cli/cli-style.h.
4924         * utils.h (fputs_highlighted): New function.
4925         * utils.c (fputs_highlighted): Likewise.
4926
4927 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4928
4929         * NEWS: Mention new pipe command and new convenience variables.
4930
4931 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4932
4933         * cli/cli-cmds.c (pipe_command): New function.
4934         (_initialize_cli_cmds): Call add_com for pipe_command.
4935         Define | as an alias for pipe.
4936         (exit_status_set_internal_vars): New function.
4937         (shell_escape): Call exit_status_set_internal_vars.
4938         cli/cli-decode.c (find_command_name_length): Recognize | as
4939         a single character command.
4940
4941 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4942
4943         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4944         top.c (execute_command_to_ui_file): New function, mostly a copy
4945         of execute_command_to_string.
4946         (execute_command_to_string): Implement by calling
4947         execute_command_to_ui_file.
4948
4949 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4950
4951         * top.h (saved_command_line): Remove declaration.
4952         * top.c (previous_saved_command_line, previous_repeat_arguments):
4953         New variables.
4954         (saved_command_line): Make static, define together with other
4955         'repeat variables'.
4956         (dont_repeat): Clear repeat_arguments.
4957         (repeat_previous, get_saved_command_line, save_command_line):
4958         New functions.
4959         (gdb_init): Initialize saved_command_line
4960         and previous_saved_command_line.
4961         * main.c (captured_main_1): Remove saved_command_line initialization.
4962         * event-top.c (handle_line_of_input): Update to use
4963         the new 'repeat' related functions instead of direct access to
4964         saved_command_line.
4965         * command.h (repeat_previous, get_saved_command_line,
4966         save_command_line): New declarations.
4967         (dont_repeat): Add comment.
4968
4969 2019-05-30  Tom Tromey  <tromey@adacore.com>
4970
4971         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4972         Fix comment.
4973         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4974
4975 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4976
4977         PR cli/24587
4978         * completer.c (complete): Initialize variable word.
4979
4980 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4981
4982         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4983         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4984         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4985         'body' is NULL to the outter 'if', protecting the '!is_define'
4986         situation as well.
4987
4988 2019-05-29  Tom Tromey  <tromey@adacore.com>
4989
4990         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4991         (dwarf_unknown): New function.
4992         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4993         (dwarf_type_encoding_name): Use dwarf_unknown.
4994
4995 2019-05-29  Tom Tromey  <tromey@adacore.com>
4996
4997         PR c++/20020:
4998         * cp-valprint.c (cp_print_value_fields): Call
4999         cp_print_static_field inside "try".
5000
5001 2019-05-29  Tom Tromey  <tromey@adacore.com>
5002
5003         * inflow.c (struct terminal_info): Add default operator=.
5004         * configure: Rebuild.
5005         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5006         -Wdeprecated-copy-dtor, -Wredundant-move.
5007
5008 2019-05-29  Tom Tromey  <tromey@adacore.com>
5009
5010         * NEWS: Add entry.
5011         * infcmd.c (print_return_value_1): Handle finish_print
5012         option.
5013         (show_print_finish): New function.
5014         (_initialize_infcmd): Add "set/show print finish" commands.
5015         * valprint.c (user_print_options): Initialize new member.
5016         * valprint.h (struct value_print_options) <finish_print>: New
5017         member.
5018
5019 2019-05-28  Tom Tromey  <tromey@adacore.com>
5020
5021         * ada-lang.c (ada_remove_Xbn_suffix)
5022         (find_old_style_renaming_symbol)
5023         (parse_old_style_renaming): Remove.
5024         (ada_find_renaming_symbol): Don't call
5025         find_old_style_renaming_symbol.
5026         (ada_is_renaming_symbol): Rename from
5027         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5028         bool.  Now static.
5029         (ada_read_var_value): Update and simplify.
5030         * ada-exp.y (write_var_or_type): Remove old code.
5031
5032 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5033
5034         * event-top.c: Remove include comment.
5035         * inflow.c (class scoped_ignore_sigttou): Move from here...
5036         * inflow.h (class scoped_ignore_sigttou): ...to here.
5037         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5038         * top.c:  Remove include comment.
5039
5040 2019-05-27  Tom Tromey  <tom@tromey.com>
5041
5042         * NEWS: Fix typo.
5043
5044 2019-05-22  Tom Tromey  <tromey@adacore.com>
5045
5046         * target.c (target_follow_exec): Constify parameter.
5047         * target-delegates.c: Rebuild.
5048         * remote.c (remote_target::follow_exec): Constify parameter.
5049         * infrun.c (follow_exec): Constify parameter.
5050         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5051         (target_follow_exec): Likewise.
5052
5053 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5054
5055         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5056         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5057
5058 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5059
5060         * NEWS: Add debugredirect and testsuite sections.
5061
5062 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5063
5064         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5065         target descriptions using exclusively floating point register name
5066         aliases.
5067
5068 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5069
5070         PR gdb/18644:
5071         * f-lang.c (build_fortran_types): Handle the case where
5072         gdbarch_floatformat_for_type returns a nullptr.
5073
5074 2019-05-21  Tom de Vries  <tdevries@suse.de>
5075
5076         PR cli/24587
5077         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5078
5079 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5080
5081         PR gdb/18644:
5082         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5083         16-byte floats.
5084         * i386-tdep.c (i386_floatformat_for_type): Use
5085         floatformats_ia64_quad for the 16-byte floating point component
5086         within a fortran 32-byte complex number.
5087
5088 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5089
5090         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5091         delete default constructor.
5092         (find_partial_die): Update to return const struct.
5093         (partial_die_parent_scope): Move variable declaration into scope
5094         of its use and change its type to auto.
5095         (guess_partial_die_structure_name): Likewise.
5096         (partial_die_info::fixup): Likewise.
5097
5098 2019-05-17  Tom Tromey  <tromey@adacore.com>
5099
5100         * source.c (find_and_open_source): Remove cast.
5101
5102 2019-05-17  Tom Tromey  <tromey@adacore.com>
5103
5104         * annotate.c (annotate_source): Make "filename" const.
5105         * annotate.h (annotate_source): Use const.
5106
5107 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5108
5109         * disasm.c (set_disassembler_options): Send errors to stderr.
5110
5111 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5112
5113         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5114         (cli_interp_base::set_logging): Check debug_redirect.
5115         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5116         * cli/cli-logging.c (debug_redirect): Add static variable.
5117         (pop_output_files): Add default param.
5118         (handle_redirections): Print debug setting.
5119         (show_logging_command): Likewise.
5120         (_initialize_cli_logging): Add debugredirect command.
5121         * interps.c (current_interp_set_logging): Add debug_redirect
5122         parameter.
5123         * interps.h (set_logging): Add debug_redirect parameter.
5124         (current_interp_set_logging): Likewise.
5125         * mi/mi-common.h: Likewise.
5126         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5127
5128 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5129             Tom Tromey  <tromey@adacore.com>
5130
5131         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5132         directly.
5133         * cli/cli-interp.h (make_logging_output): Remove declaration.
5134         * cli/cli-logging.c (make_logging_output): Remove function.
5135         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5136         directly.
5137         * ui-file.c (tee_file::tee_file): Remove bools.
5138         (tee_file::~tee_file): Remove deletes.
5139         * ui-file.h (tee_file): Remove bools.
5140
5141 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5142
5143         * mi/mi-cmds.h (mi_cmd_complete): New function.
5144         * mi/mi-main.c (mi_cmd_complete): Likewise.
5145         * mi/mi-cmds.c: Define new MI command -complete.
5146         * NEWS: Mention new -complete command.
5147
5148 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5149
5150         * completer.h (complete): New function.
5151         * completer.c (complete): Likewise.
5152         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5153         function defined in completer.h.
5154
5155 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5156
5157         * MAINTAINERS (Write After Approval): Add myself.
5158
5159 2019-05-17  Tom de Vries  <tdevries@suse.de>
5160
5161         PR gdb/24094
5162         * dwarf2read.c (struct cu_partial_die_info): New struct.
5163         (find_partial_die): Return cu_partial_die_info.
5164         (partial_die_parent_scope, guess_partial_die_structure_name)
5165         (partial_die_info::fixup): Handle new return type of find_partial_die.
5166
5167 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5168
5169         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5170         "std::string", simplifying the algorithm.
5171
5172 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5173
5174         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5175         (stap_static_probe_ops::get_probes): Likewise.
5176
5177 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5178
5179         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5180         '-')" and "else if".
5181         (stap_parse_single_operand): Join checks for
5182         "gdbarch_stap_parse_special_token_p" and
5183         "gdbarch_stap_parse_special_token" in the same "if" statement.
5184         Invert check when verifying for operation on register
5185         displacement.
5186
5187 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5188
5189         * stap-probe.c (stap_get_opcode): Update comment.
5190         (stap_get_expected_argument_type): Likewise.
5191         (handle_stap_probe): Likewise.
5192
5193 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5194
5195         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5196         return type to 'bool'.  Adjust comment.  Use 'bool' when
5197         appropriate.
5198         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5199         * stap-probe.c (stap_parse_argument_1): Likewise.
5200         (stap_is_operator): Likewise.
5201         (stap_is_generic_prefix): Likewise.
5202         (stap_is_register_prefix): Likewise.
5203         (stap_is_register_indirection_prefix): Likewise.
5204         (stap_is_integer_prefix): Likewise.
5205         (stap_generic_check_suffix): Likewise.
5206         (stap_check_integer_suffix): Likewise.
5207         (stap_check_register_suffix): Likewise.
5208         (stap_check_register_indirection_suffix): Likewise.
5209         (stap_parse_register_operand): Likewise.
5210         (stap_parse_single_operand): Likewise.
5211         (stap_parse_argument_1): Likewise.
5212         (stap_probe::get_argument_count): Likewise.
5213         (stap_is_operator): Likewise.
5214
5215 2019-05-16  Tom Tromey  <tromey@adacore.com>
5216
5217         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5218         keyword to foreach.
5219
5220 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5221
5222         * linux-thread-db.c (try_thread_db_load_1): Change return type
5223         to bool.
5224         (try_thread_db_load): Likewise.
5225         (try_thread_db_load_from_pdir_1): Likewise.
5226         (try_thread_db_load_from_pdir): Likewise.
5227         (try_thread_db_load_from_sdir): Likewise.
5228         (try_thread_db_load_from_dir): Likewise.
5229         (thread_db_load_search): Likewise.
5230         (has_libpthread): Likewise.
5231         (thread_db_load): Likewise.
5232
5233 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5234
5235         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5236         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5237         NULL, and complain/return if that's the case.
5238
5239 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5240
5241         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5242         (advance, posn, abstract_read_memory): New functions.
5243         [struct mem_read_abstraction]: New struct.
5244         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5245
5246 2019-05-14  Tom Tromey  <tromey@adacore.com>
5247
5248         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5249         value is not lval_memory.
5250
5251 2019-05-14  Tom Tromey  <tromey@adacore.com>
5252
5253         * solib.c (info_sharedlibrary_command): Style the file name.
5254
5255 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5256
5257         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5258         (aarch64_vnv_type): Likewise.
5259         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5260         * common/tdesc.c: Likewise.
5261         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5262         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5263         * features/aarch64-fpu.xml: Add ieee half view.
5264         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5265         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5266         * gdbtypes.h (struct builtin_type): Likewise.
5267         (struct objfile_type): Likewise.
5268
5269 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5270
5271         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5272         typo.
5273         * location.h (string_to_event_location): Likewise.
5274
5275 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5276
5277         GDB 8.3 released.
5278
5279 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5280
5281         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5282         New variable declaration.
5283         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5284         New variable.
5285         (print_one_breakpoint): Use ui_out::test_flags and new global
5286         variable to compute use_fixed_output.
5287         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5288         Remove.
5289         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5290         (mi_multi_location_breakpoint_output_fixed): Remove.
5291         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5292         new variable.
5293         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5294         fix_multi_location_breakpoint_output flag if version >= 3.
5295         * ui-out.h (enum ui_out_flag)
5296         <fix_multi_location_breakpoint_output>: New enumerator.
5297
5298 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5299
5300         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5301
5302 2019-05-10  Tom Tromey  <tromey@adacore.com>
5303
5304         * ada-lang.c (catch_ada_completer): New function.
5305         (_initialize_ada_language): Use it.
5306
5307 2019-05-10  Tom Tromey  <tromey@adacore.com>
5308
5309         * thread.c (print_thread_info): Make "requested_threads" const.
5310         * gdbthread.h (print_thread_info): Make "requested_threads"
5311         const.
5312         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5313         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5314
5315 2019-05-08  Tom Tromey  <tom@tromey.com>
5316
5317         * gdbtypes.c (objfile_type_data): Change type.
5318         (objfile_type, _initialize_gdbtypes): Update.
5319
5320 2019-05-08  Tom Tromey  <tom@tromey.com>
5321
5322         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5323         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5324         (_initialize_dwarf2_frame): Update.
5325
5326 2019-05-08  Tom Tromey  <tom@tromey.com>
5327
5328         * objc-lang.c (objc_objfile_data): Change type.
5329         (find_methods): Update.
5330         (_initialize_objc_lang): Remove.
5331
5332 2019-05-08  Tom Tromey  <tom@tromey.com>
5333
5334         * stabsread.c (rs6000_builtin_type_data): Change type.
5335         (rs6000_builtin_type, _initialize_stabsread): Update.
5336
5337 2019-05-08  Tom Tromey  <tom@tromey.com>
5338
5339         * mips-tdep.c (mips_pdr_data): Remove.
5340         (_initialize_mips_tdep): Update.
5341
5342 2019-05-08  Tom Tromey  <tom@tromey.com>
5343
5344         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5345         (hppa_init_objfile_priv_data, read_unwind_info)
5346         (find_unwind_entry, _initialize_hppa_tdep): Update.
5347
5348 2019-05-08  Tom Tromey  <tom@tromey.com>
5349
5350         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5351         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5352         on obstack.
5353         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5354
5355 2019-05-08  Tom Tromey  <tom@tromey.com>
5356
5357         * mdebugread.c (basic_type_data): Change type.
5358         (basic_type, _initialize_mdebugread): Update.
5359
5360 2019-05-08  Tom Tromey  <tom@tromey.com>
5361
5362         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5363
5364 2019-05-08  Tom Tromey  <tom@tromey.com>
5365
5366         * nto-tdep.c (nto_inferior_data_reg): Change type.
5367         (nto_inferior_data): Update.
5368         (nto_inferior_data_cleanup, nto_new_inferior_data)
5369         (_initialize_nto_tdep): Remove.
5370         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5371
5372 2019-05-08  Tom Tromey  <tom@tromey.com>
5373
5374         * ada-lang.c (struct ada_inferior_data): Add initializers.
5375         (ada_inferior_data): Change type.
5376         (ada_inferior_data_cleanup): Remove.
5377         (get_ada_inferior_data, ada_inferior_exit)
5378         (struct ada_pspace_data): Add initializers, destructor.
5379         (ada_pspace_data_handle): Change type.
5380         (get_ada_pspace_data): Update.
5381         (ada_pspace_data_cleanup): Remove.
5382
5383 2019-05-08  Tom Tromey  <tom@tromey.com>
5384
5385         * coffread.c (struct coff_symfile_info): Add initializers.
5386         (coff_objfile_data_key): Move lower.  Change type.
5387         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5388         Update.
5389         (coff_free_info): Remove.
5390
5391 2019-05-08  Tom Tromey  <tom@tromey.com>
5392
5393         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5394         (fbsd_pspace_data_handle): Move lower.  Change type.
5395         (get_fbsd_pspace_data): Update.
5396         (fbsd_pspace_data_cleanup): Remove.
5397         (_initialize_fbsd_tdep): Update.
5398
5399 2019-05-08  Tom Tromey  <tom@tromey.com>
5400
5401         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5402         (get_ada_tasks_pspace_data): Update.
5403         (ada_tasks_pspace_data_cleanup): Remove.
5404         (_initialize_tasks): Update.
5405         (ada_tasks_inferior_data_handle): Change type.
5406         (get_ada_tasks_inferior_data): Update.
5407         (ada_tasks_inferior_data_cleanup): Remove.
5408         (struct ada_tasks_pspace_data): Add initializers.
5409
5410 2019-05-08  Tom Tromey  <tom@tromey.com>
5411
5412         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5413         * symfile-debug.c (debug_sym_get_probes): Change type.
5414         * stap-probe.c (handle_stap_probe):
5415         (stap_static_probe_ops::get_probes): Change type.
5416         * probe.h (class static_probe_ops) <get_probes>: Change type.
5417         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5418         (parse_probes_in_pspace): Update.
5419         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5420         Update.
5421         (any_static_probe_ops::get_probes): Change type.
5422         * elfread.c (elfread_data): New typedef.
5423         (probe_key): Change type.
5424         (elf_get_probes): Likewise.  Update.
5425         (probe_key_free): Remove.
5426         (_initialize_elfread): Update.
5427         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5428         Change type.
5429         (dtrace_process_dof_probe, dtrace_process_dof)
5430         (dtrace_static_probe_ops::get_probe): Change type.
5431
5432 2019-05-08  Tom Tromey  <tom@tromey.com>
5433
5434         * xcoffread.c (struct xcoff_symfile_info): Rename from
5435         coff_symfile_info.  Add initializers.
5436         (xcoff_objfile_data_key): Move lower.  Change type.
5437         (XCOFF_DATA): Rewrite.
5438         (xcoff_free_info): Remove.
5439         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5440         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5441         (xcoff_initial_scan): Update.
5442
5443 2019-05-08  Tom Tromey  <tom@tromey.com>
5444
5445         * solib-svr4.c (struct svr4_info): Add initializers and
5446         destructor.
5447         <probes_table>: Now an htab_up.
5448         (solib_svr4_pspace_data): Change type.
5449         (free_probes_table): Simplify.
5450         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5451         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5452         (probes_table_remove_objfile_probes, register_solib_event_probe)
5453         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5454         (_initialize_svr4_solib): Update.
5455
5456 2019-05-08  Tom Tromey  <tom@tromey.com>
5457
5458         * remote.c (remote_pspace_data): Change type.
5459         (remote_pspace_data_cleanup): Remove.
5460         (get_remote_exec_file, set_pspace_remote_exec_file)
5461         (_initialize_remote): Update.
5462
5463 2019-05-08  Tom Tromey  <tom@tromey.com>
5464
5465         * breakpoint.c (breakpoint_objfile_key): Change type.
5466         (get_breakpoint_objfile_data): Update.
5467         (free_breakpoint_objfile_data): Remove.
5468         (_initialize_breakpoint): Update.
5469
5470 2019-05-08  Tom Tromey  <tom@tromey.com>
5471
5472         * linux-tdep.c (struct linux_info): Add initializers.
5473         (linux_inferior_data): Move.  Change type.
5474         (invalidate_linux_cache_inf): Update.
5475         (linux_inferior_data_cleanup): Remove.
5476         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5477
5478 2019-05-08  Tom Tromey  <tom@tromey.com>
5479
5480         * auxv.c (auxv_inferior_data): Move.  Change type.
5481         (auxv_inferior_data_cleanup): Remove.
5482         (invalidate_auxv_cache_inf): Rewrite.
5483         (get_auxv_inferior_data, _initialize_auxv): Update.
5484
5485 2019-05-08  Tom Tromey  <tom@tromey.com>
5486
5487         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5488         (symfile_debug_objfile_data_key): Change type.
5489         (symfile_debug_installed, debug_qf_has_symbols)
5490         (debug_qf_find_last_source_symtab)
5491         (debug_qf_forget_cached_source_info)
5492         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5493         (debug_qf_print_stats, debug_qf_dump)
5494         (debug_qf_expand_symtabs_for_function)
5495         (debug_qf_expand_all_symtabs)
5496         (debug_qf_expand_symtabs_with_fullname)
5497         (debug_qf_map_matching_symbols)
5498         (debug_qf_expand_symtabs_matching)
5499         (debug_qf_find_pc_sect_compunit_symtab)
5500         (debug_qf_map_symbol_filenames)
5501         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5502         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5503         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5504         (debug_sym_read_linetable, debug_sym_relocate): Update.
5505         (symfile_debug_free_objfile): Remove.
5506         (install_symfile_debug_logging, _initialize_symfile_debug):
5507         Update.
5508
5509 2019-05-08  Tom Tromey  <tom@tromey.com>
5510
5511         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5512         allocate_on_obstack.
5513         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5514         (get_dwarf2_per_objfile): Update.
5515         (set_dwarf2_per_objfile): Remove.
5516         (dwarf2_has_info, dwarf2_get_section_info): Update.
5517         (dwarf2_free_objfile): Remove.
5518         (_initialize_dwarf2_read): Update.
5519
5520 2019-05-08  Tom Tromey  <tom@tromey.com>
5521
5522         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5523         initializers.
5524         <unsupported_script_warning_printed,
5525         script_not_found_warning_printed>: Now bool.
5526         (auto_load_pspace_data): Change type.
5527         (~auto_load_pspace_info): Rename from
5528         auto_load_pspace_data_cleanup.
5529         (get_auto_load_pspace_data, init_loaded_scripts_info)
5530         (clear_section_scripts, maybe_print_unsupported_script_warning)
5531         (maybe_print_script_not_found_warning, _initialize_auto_load):
5532         Update.
5533
5534 2019-05-08  Tom Tromey  <tom@tromey.com>
5535
5536         * objfiles.c (objfile_pspace_info): Add destructor and
5537         initializers.
5538         (objfiles_pspace_data): Change type.
5539         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5540         (get_objfile_pspace_data): Update.
5541         (objfiles_bfd_data): Change type.
5542         (get_objfile_bfd_data): Update.
5543         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5544
5545 2019-05-08  Tom Tromey  <tom@tromey.com>
5546
5547         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5548         Change type.
5549         (get_catch_syscall_inferior_data): Update.
5550         (catch_syscall_inferior_data_cleanup): Remove.
5551         (_initialize_break_catch_syscall): Update.
5552
5553 2019-05-08  Tom Tromey  <tom@tromey.com>
5554
5555         * inflow.c (struct terminal_info): Add destructor and
5556         initializers.
5557         (inflow_inferior_data): Change type.
5558         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5559         (get_inflow_inferior_data, inflow_inferior_exit)
5560         (swap_terminal_info, _initialize_inflow): Update.
5561
5562 2019-05-08  Tom Tromey  <tom@tromey.com>
5563
5564         * target-dcache.c (target_dcache_cleanup): Remove.
5565         (target_dcache_aspace_key): Change type.
5566         (target_dcache_init_p, target_dcache_invalidate)
5567         (target_dcache_get, target_dcache_get_or_init)
5568         (_initialize_target_dcache): Update.
5569         * dcache.h (struct dcache_deleter): New.
5570
5571 2019-05-08  Tom Tromey  <tom@tromey.com>
5572
5573         * symtab.c (struct symbol_cache): Add destructor and
5574         initializers.
5575         (symbol_cache_key): Move.  Change type.
5576         (make_symbol_cache, free_symbol_cache): Remove.
5577         (get_symbol_cache): Update.
5578         (symbol_cache_cleanup): Remove.
5579         (ALL_PSPACES, symbol_cache_flush)
5580         (maintenance_print_symbol_cache)
5581         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5582         Update.
5583
5584 2019-05-08  Tom Tromey  <tom@tromey.com>
5585
5586         * symtab.c (struct main_info): Add destructor and initializers.
5587         (main_progspace_key): Move.  Change type.
5588         (get_main_info): Update.
5589         (main_info_cleanup): Remove.
5590         (_initialize_symtab): Update.
5591
5592 2019-05-08  Tom Tromey  <tom@tromey.com>
5593
5594         * registry.h (DECLARE_REGISTRY): Define the _key class.
5595
5596 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5597
5598         * NEWS: Merge two 'New commands' sections.
5599
5600 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5601
5602         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5603         parameter and use Ada language definition instead.
5604         (ada_val_print_ptr): Remove unused language parameter.
5605         (ada_val_print_num): Remove language parameter and use Ada language
5606         definition instead.
5607         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5608         parameter.
5609         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5610         parameter and use Ada language definition instead.
5611         (ada_val_print_1): Update all ada_val_print_xxx calls.
5612         Remove language parameter.
5613         (ada_val_print): Update ada_val_print_1 call.
5614
5615 2019-05-08  Tom Tromey  <tromey@adacore.com>
5616
5617         * remote.c (remote_hw_watchpoint_limit)
5618         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5619         Now static.
5620
5621 2019-05-08  Tom Tromey  <tromey@adacore.com>
5622
5623         * maint.c (_initialize_maint_cmds): Move initialization code to
5624         remote.c.
5625         (watchdog, show_watchdog): Move to remote.c.
5626         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5627         "watchdog" static.
5628         (_initialize_remote): Move initialization code from maint.c.
5629         * defs.h (watchdog): Don't declare.
5630
5631 2019-05-08  Tom Tromey  <tromey@adacore.com>
5632
5633         * tui/tui-interp.c: Include main.h.
5634         * interps.c: Include main.h.
5635         * main.h (interpreter_p): Declare.
5636         * defs.h (interpreter_p): Don't declare.
5637
5638 2019-05-08  Tom Tromey  <tromey@adacore.com>
5639
5640         * dwarf2loc.c: Include dwarf2read.h.
5641         * defs.h (read_unsigned_leb128): Don't declare.
5642         * dwarf2read.h (read_unsigned_leb128): Declare.
5643
5644 2019-05-08  Tom Tromey  <tromey@adacore.com>
5645
5646         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5647         method.
5648
5649 2019-05-08  Tom Tromey  <tromey@adacore.com>
5650
5651         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5652         when no wrap column is set.
5653
5654 2019-05-08  Tom Tromey  <tromey@adacore.com>
5655
5656         * c-lang.c (c_get_string): Handle non-C-style arrays.
5657
5658 2019-05-08  Tom Tromey  <tromey@adacore.com>
5659
5660         * typeprint.c (print_offset_data::update): Print the bit offset,
5661         not the number of bits remaining.
5662
5663 2019-05-08  Tom Tromey  <tromey@adacore.com>
5664
5665         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5666         padding at end of comment.
5667
5668 2019-05-08  Tom Tromey  <tromey@adacore.com>
5669
5670         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5671         Compare main types.
5672
5673 2019-05-06  Tom Tromey  <tom@tromey.com>
5674
5675         * common/scoped_mmap.c: Include common-defs.h.
5676         * common/scoped_mmap.h: Don't include config.h.
5677
5678 2019-05-04  Tom Tromey  <tom@tromey.com>
5679
5680         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5681         (struct aarch64_call_info): Add initializers.
5682         <si>: Now a std::vector.
5683         (pass_on_stack, aarch64_push_dummy_call): Update.
5684
5685 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5686             Tom Tromey  <tom@tromey.com>
5687
5688         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5689         (ppc_threads): Now a std::vector.  Now static.
5690         (hwdebug_find_thread_points_by_tid)
5691         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5692         Update.
5693
5694 2019-05-04  Tom Tromey  <tom@tromey.com>
5695
5696         * arc-tdep.c (arc_tdesc_init): Return bool.
5697
5698 2019-05-04  Tom Tromey  <tom@tromey.com>
5699
5700         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5701         Use gdb_assert_not_reached.
5702
5703 2019-05-04  Tom Tromey  <tom@tromey.com>
5704
5705         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5706         "false".
5707
5708 2019-05-04  Tom Tromey  <tom@tromey.com>
5709
5710         * arc-tdep.c (arc_tdesc_init): Use bool.
5711
5712 2019-05-04  Tom Tromey  <tom@tromey.com>
5713
5714         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5715
5716 2019-05-04  Tom Tromey  <tom@tromey.com>
5717
5718         * cli/cli-cmds.c (valid_command_p): Return bool.
5719
5720 2019-05-04  Tom Tromey  <tom@tromey.com>
5721
5722         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5723         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5724
5725 2019-05-04  Raul Tambre  <raul@tambre.ee>
5726
5727         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5728         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5729         operator for comparison.
5730
5731 2019-05-04  Tom Tromey  <tom@tromey.com>
5732
5733         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5734         (lookup_partial_symbol, print_partial_symbols)
5735         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5736         (psymbol_compare): Update.
5737         (add_psymbol_to_bcache): Clear the entire psymbol.
5738         (maintenance_check_psymtabs): Update.
5739         * psympriv.h (struct partial_symbol): Don't derive from
5740         general_symbol_info.
5741         <obj_section, unrelocated_address, address,
5742         set_unrelocated_address>: Update.
5743         <ginfo>: New member.
5744         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5745         (debug_names::write_psymbols): Update.
5746
5747 2019-05-04  Tom de Vries  <tdevries@suse.de>
5748
5749         * contrib/cc-with-tweaks.sh: Support -n arg.
5750
5751 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5752
5753         * corelow.c (core_target::detach): Ensure frame cache and
5754         register caches are cleared.
5755         inferior.c (exit_inferior_1): Likewise.
5756
5757 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5758             Tom Tromey  <tom@tromey.com>
5759
5760         * dictionary.c (collate_pending_symbols_by_language): Remove
5761         "struct" from foreach.
5762         * symtab.c (lookup_global_symbol_from_objfile)
5763         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5764         foreach.
5765         * ser-tcp.c (net_open): Remove "struct" from foreach.
5766         * objfiles.c (objfile_relocate, objfile_rebase)
5767         (objfile_has_symbols): Remove "struct" from foreach.
5768         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5769         from foreach.
5770         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5771         foreach.
5772         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5773         "struct" from foreach.
5774         * ada-lang.c (create_excep_cond_exprs)
5775         (ada_exception_catchpoint_cond_string): Remove "struct" from
5776         foreach.
5777
5778 2019-05-03  Tom Tromey  <tromey@adacore.com>
5779
5780         * ada-exp.y (convert_char_literal): Check suffix of each
5781         enumerator.
5782
5783 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5784
5785         PR ada/21406:
5786         * ada-exp.y (yywrap): Don't define.
5787         * ada-lex.l (%option): Add noyywrap
5788         (yywrap): Remove.
5789
5790 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5791
5792         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5793         _WIN32_WINNT to the XP level, unless already defined to a higher
5794         level.
5795
5796         * unittests/parse-connection-spec-selftests.c:
5797         * ser-tcp.c:
5798         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5799         override.
5800
5801         * symfile.c (find_separate_debug_file): Remove colon from the
5802         drive spec of DOS/Windows file names of the target, so that the
5803         file name produced from DEBUGDIR and the target's directory will
5804         be valid on DOS/Windows systems.
5805
5806 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5807
5808         * rust-lang.c (val_print_struct): Handle printing structures
5809         containing strings.
5810
5811 2019-05-02  Tom Tromey  <tromey@adacore.com>
5812
5813         * valarith.c (_initialize_valarith): Remove.
5814
5815 2019-05-01  Tom Tromey  <tromey@adacore.com>
5816
5817         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5818         bitfields.
5819
5820 2019-05-01  Tom Tromey  <tromey@adacore.com>
5821
5822         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5823         for big-endian copies.
5824
5825 2019-04-30  Ali Tamur  <tamur@google.com>
5826         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5827         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5828         (read_3_bytes): New function.
5829
5830 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5831
5832         * windows-nat.c (main_thread_id): Delete.
5833         (handle_output_debug_string): Replace main_thread_id by
5834         current_event.dwThreadId.
5835         (fake_create_process): Likewise.
5836         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5837         Do not set main_thread_id.
5838         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5839         current_event.dwThreadId.
5840         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5841
5842 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5843
5844         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5845         Use current_event.dwThreadId instead of main_thread_id.
5846
5847 2019-04-30  Tom Tromey  <tromey@adacore.com>
5848
5849         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5850         (create_excep_cond_exprs): Iterate over program spaces.
5851         (ada_exception_catchpoint_cond_string): Examine all minimal
5852         symbols for exception types.
5853
5854 2019-04-30  Tom Tromey  <tromey@adacore.com>
5855
5856         PR c++/24470:
5857         * dwarf2read.c (process_structure_scope): Handle case where type
5858         has template parameters but no symbol was created.
5859
5860 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5861             Chris January  <chris.january@arm.com>
5862
5863         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5864         qualifier.
5865         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5866
5867 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5868
5869         * f-typeprint.c (f_print_type): Update rules for printing
5870         whitespace.
5871         (f_type_print_varspec_suffix): Likewise.
5872
5873 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5874             Chris January  <chris.january@arm.com>
5875
5876         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5877         function arguments.
5878
5879 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5880
5881         * f-lang.c (build_fortran_types): Change name of void type to
5882         lower case.
5883         * f-typeprint.c (f_type_print_base): Print the name of the void
5884         type, rather than a fixed string.
5885         * f-valprint.c (f_decorations): Use lower case void string.
5886
5887 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5888             Chris January  <chris.january@arm.com>
5889
5890         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5891         types for Fortran.
5892
5893 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5894             Chris January  <chris.january@arm.com>
5895             David Lecomber  <david.lecomber@arm.com>
5896
5897         * f-exp.y (BINOP_INTRINSIC): New token.
5898         (exp): New parser rule handling BINOP_INTRINSIC.
5899         (f77_keywords): Add new builtin procedures.
5900         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5901         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5902         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5903         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5904         (print_unop_subexp_f): New function.
5905         (print_binop_subexp_f): New function.
5906         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5907         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5908         (dump_subexp_body_f): Likewise.
5909         (operator_check_f): Likewise.
5910         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5911         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5912
5913 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5914
5915         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5916         UNOP_KIND.
5917         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5918         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5919         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5920         (operator_length_f): New fuction.
5921         (print_subexp_f): New function.
5922         (op_name_f): New function.
5923         (dump_subexp_body_f): New function.
5924         (operator_check_f): New function.
5925         (exp_descriptor_f): Replace standard expression handling functions
5926         with new functions.
5927         * gdb/fortran-operator.def: New file.
5928         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5929         * gdb/std-operator.def: Remove UNOP_KIND.
5930
5931 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5932
5933         * std-operator.def: Remove unbalanced, stray double quote
5934         character.
5935
5936 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5937             Chris January  <chris.january@arm.com>
5938             Daniel Everett  <daniel.everett@arm.com>
5939             Nick Forrington  <nick.forrington@arm.com>
5940             Richard Bunt  <richard.bunt@arm.com>
5941
5942         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5943         of depth when printing anonymous structs or unions.
5944         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5945         Don't print either the top-level value, or the children if the
5946         max-depth is exceeded.
5947         (ppscm_print_children): When printing the key of a map, allow one
5948         extra level of depth.
5949         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5950         print either the top-level value, or the children if the max-depth
5951         is exceeded.
5952         (print_children): When printing the key of a map, allow one extra
5953         level of depth.
5954         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5955         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5956         (user_print_options): Initialise max_depth field.
5957         (val_print_scalar_or_string_type_p): New function.
5958         (val_print): Check to see if the max depth has been reached.
5959         (val_print_check_max_depth): Define new function.
5960         (show_print_max_depth): New function.
5961         (_initialize_valprint): Add 'print max-depth' option.
5962         * valprint.h (struct value_print_options) <max_depth>: New field.
5963         (val_print_check_max_depth): Declare new function.
5964         * NEWS: Document new feature.
5965
5966 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5967
5968         * ada-lang.c (ada_language_defn): Initialise new field.
5969         * c-lang.c (c_is_string_type_p): New function.
5970         (c_language_defn): Initialise new field.
5971         (cplus_language_defn): Initialise new field.
5972         (asm_language_defn): Initialise new field.
5973         (minimal_language_defn): Initialise new field.
5974         * c-lang.h (c_is_string_type_p): Declare new function.
5975         * d-lang.c (d_language_defn): Initialise new field.
5976         * f-lang.c (f_is_string_type_p): New function.
5977         (f_language_defn): Initialise new field.
5978         * go-lang.c (go_is_string_type_p): New function.
5979         (go_language_defn): Initialise new field.
5980         * language.c (default_is_string_type_p): New function.
5981         (unknown_language_defn): Initialise new field.
5982         (auto_language_defn): Initialise new field.
5983         * language.h (struct language_defn) <la_is_string_type_p>: New
5984         member variable.
5985         (default_is_string_type_p): Declare new function.
5986         * m2-lang.c (m2_language_defn): Initialise new field.
5987         * objc-lang.c (objc_language_defn): Initialise new field.
5988         * opencl-lang.c (opencl_language_defn): Initialise new field.
5989         * p-lang.c (pascal_is_string_type_p): New function.
5990         (pascal_language_defn): Initialise new field.
5991         * rust-lang.c (rust_is_string_type_p): New function.
5992         (rust_language_defn): Initialise new field.
5993
5994 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5995
5996         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5997         New field.
5998         * ada-lang.c (ada_language_defn): Initialise new field.
5999         * c-lang.c (c_language_defn): Likewise.
6000         (cplus_language_defn): Likewise.
6001         (asm_language_defn): Likewise.
6002         (minimal_language_defn): Likewise.
6003         * d-lang.c (d_language_defn): Likewise.
6004         * f-lang.c (f_language_defn): Likewise.
6005         * go-lang.c (go_language_defn): Likewise.
6006         * language.c (unknown_language_defn): Likewise.
6007         (auto_language_defn): Likewise.
6008         * m2-lang.c (m2_language_defn): Likewise.
6009         * objc-lang.c (objc_language_defn): Likewise.
6010         * opencl-lang.c (opencl_language_defn): Likewise.
6011         * p-lang.c (pascal_language_defn): Likewise.
6012         * rust-lang.c (rust_language_defn): Likewise.
6013
6014 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6015
6016         * ada-lang.c (ada_is_character_type): Change return type to bool.
6017         (ada_is_string_type): Likewise.
6018         * ada-lang.h (ada_is_character_type): Update declaration
6019         (ada_is_string_type): Likewise.
6020
6021 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6022
6023         Support style in 'frame|thread apply'
6024
6025         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6026         * record.c (record_start, record_stop): Update callers of
6027         execute_command_to_string with false.
6028         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6029         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6030         methods.
6031         (class string_file): New constructor with term_out parameter.
6032         Override methods term_out and can_emit_style_escape.  New member
6033         term_out.
6034         (class stdio_file): Override can_emit_style_escape.
6035         (class tee_file): Override term_out and can_emit_style_escape.
6036         * utils.h (can_emit_style_escape): Remove.
6037         * utils.c (can_emit_style_escape): Likewise.
6038         Update all callers of can_emit_style_escape (SOMESTREAM) to
6039         SOMESTREAM->can_emit_style_escape.
6040         * source-cache.c (source_cache::get_source_lines): Likewise.
6041         * stack.c (frame_apply_command_count): Call execute_command_to_string
6042         passing the term_out characteristic of the current gdb_stdout.
6043         * thread.c (thr_try_catch_cmd): Likewise.
6044         * top.c (execute_command_to_string): pass term_out parameter
6045         to construct the string_file for the command output.
6046         * ui-file.c (term_cli_styling): New function (most code moved
6047         from utils.c can_emit_style_escape).
6048         (string_file::string_file, string_file::can_emit_style_escape,
6049         stdio_file::can_emit_style_escape, tee_file::term_out,
6050         tee_file::can_emit_style_escape): New functions.
6051
6052 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6053
6054         * NEWS: Mention the new set|show may-call-functions.
6055         * infcall.c (may_call_functions_p): New variable.
6056         (show_may_call_functions_p): New function.
6057         (call_function_by_hand_dummy): Throws an error if not
6058         may-call-functions.
6059         (_initialize_infcall): Call add_setshow_boolean_cmd for
6060         may-call-functions.
6061
6062 2019-04-25  Keith Seitz  <keiths@redhat.com>
6063
6064         PR c++/24367
6065         * cp-support.c (inspect_type): Don't attempt substitutions
6066         of symbol with the same name.
6067
6068 2019-04-25  Tom Tromey  <tromey@adacore.com>
6069
6070         PR gdb/24475:
6071         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6072         static.
6073
6074 2019-04-25  Tom Tromey  <tromey@adacore.com>
6075
6076         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6077         rvalue reference.
6078         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6079         (gdb_xml_parser::parse): Use std::move.
6080         * python/python-internal.h (gdbpy_convert_exception): Take a const
6081         reference.
6082         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6083         std::move.
6084         * python/py-utils.c (gdbpy_convert_exception): Take a const
6085         reference.
6086         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6087         Use std::move.
6088         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6089         Use std::move.
6090         * mi/mi-main.c (mi_print_exception): Take a const reference.
6091         * main.c (handle_command_errors): Take a const reference.
6092         * linespec.c (parse_linespec): Use std::move.
6093         * infcall.c (run_inferior_call): Use std::move.
6094         (call_function_by_hand_dummy): Use std::move.
6095         * exec.c (try_open_exec_file): Use std::move.
6096         * exceptions.h (exception_print, exception_fprintf)
6097         (exception_print_same): Update.
6098         * exceptions.c (print_exception, exception_print)
6099         (exception_fprintf, exception_print_same): Change parameters to
6100         const reference.
6101         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6102         * common/new-op.c: Use std::move.
6103         * common/common-exceptions.h (struct gdb_exception): Add move
6104         constructor.
6105         (struct gdb_exception_error, struct gdb_exception_quit, struct
6106         gdb_quit_bad_alloc): Change constructor to move constructor.
6107         (throw_exception): Change parameter to rvalue reference.
6108         * common/common-exceptions.c (throw_exception): Take rvalue
6109         reference.
6110         * cli/cli-interp.c (safe_execute_command): Use std::move.
6111         * breakpoint.c (insert_bp_location, location_to_sals): Use
6112         std::move.
6113
6114 2019-04-25  Tom Tromey  <tromey@adacore.com>
6115
6116         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6117         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6118         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6119         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6120         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6121         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6122         guile/scm-value.c: Use unpack.
6123         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6124         gdbscm_gdb_exception.
6125         (gdbscm_throw_gdb_exception): Likewise.
6126         (struct gdbscm_gdb_exception): New.
6127         (unpack): New function.
6128         (gdbscm_wrap): Use unpack.
6129
6130 2019-04-25  Tom Tromey  <tromey@adacore.com>
6131
6132         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6133         (gdb_rl_callback_handler): Use std::move.
6134         * common/common-exceptions.h (struct gdb_exception): Add move
6135         assignment operator.
6136         (throw_exception_sjlj): Change "exception" to const reference.
6137         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6138         (throw_exception_sjlj): Change "exception" to const reference.
6139
6140 2019-04-25  Tom Tromey  <tromey@adacore.com>
6141
6142         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6143         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6144         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6145         Update.
6146         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6147         Update.
6148         * mi/mi-interp.c (mi_interp::exec): Update.
6149         * linespec.c (parse_linespec): Update.
6150         * infcall.c (run_inferior_call): Update.
6151         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6152         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6153         (gdbscm_lookup_global_symbol): Update.
6154         * guile/scm-param.c (gdbscm_parameter_value): Update.
6155         * guile/scm-frame.c (gdbscm_frame_read_register)
6156         (gdbscm_frame_read_var): Update.
6157         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6158         * exec.c (try_open_exec_file): Update.
6159         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6160         (gdb_rl_callback_handler): Update.
6161         * common/common-exceptions.h (exception_none): Don't declare.
6162         * common/common-exceptions.c (exception_none): Don't define.
6163         (struct catcher) <exception>: Update.
6164         * cli/cli-interp.c (safe_execute_command): Update.
6165         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6166
6167 2019-04-25  Ali Tamur  <tamur@google.com>
6168
6169         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6170         (read_attribute_value): Likewise.
6171         (dwarf2_read_addr_index): Update comment.
6172         (read_str_index): Add DW_FORM_strx.
6173         (dwarf2_string_attr): Likewise.
6174         (dwarf2_const_value_attr): Likewise.
6175         (dump_die_shallow): Likewise.
6176         (dwarf2_fetch_constant_bytes): Likewise.
6177         (skip_form_bytes): Likewise.
6178         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6179
6180 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6181
6182         PR corefiles/11608
6183         PR corefiles/18187
6184         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6185         OFFSET.  Verify if current mapping contains an ELF header.
6186         (linux_find_memory_regions_full): Adjust call to
6187         dump_mapping_p.
6188
6189 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6190             Kang Li <kanglictf@gmail.com>
6191
6192         PR gdb/21600
6193
6194         * dwarf2-frame.c (read_initial_length): Be consistent about using
6195         unsigned representation of length.
6196         (decode_frame_entry_1): Likewise.  Check for wraparound of
6197         end pointer as well as buffer overflow.
6198
6199 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6200
6201         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6202         "vq".
6203
6204 2019-04-24  Tom Tromey  <tromey@adacore.com>
6205
6206         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6207
6208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6209
6210         * s12z-tdep.c (s12z_unwind_pc): Delete.
6211         (s12z_unwind_sp): Delete.
6212         (s12z_gdbarch_init): Don't register deleted functions with
6213         gdbarch.
6214
6215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6216
6217         * rl78-tdep.c (rl78_unwind_sp): Delete.
6218         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6219
6220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6221
6222         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6223         (xstormy16_unwind_pc): Delete.
6224         (xstormy16_dummy_id): Delete.
6225         (xstormy16_gdbarch_init): Don't register deleted functions with
6226         gdbarch.
6227
6228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6229
6230         * vax-tdep.c (vax_unwind_pc): Delete.
6231         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6232
6233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6234
6235         * v850-tdep.c (v850_unwind_sp): Delete.
6236         (v850_unwind_pc): Delete.
6237         (v850_dummy_id): Delete.
6238         (v850_gdbarch_init): Don't register deleted functions with
6239         gdbarch.
6240
6241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6242
6243         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6244         (tilegx_unwind_pc): Delete.
6245         (tilegx_unwind_dummy_id): Delete.
6246         (tilegx_gdbarch_init): Don't register deleted functions with
6247         gdbarch.
6248
6249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6250
6251         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6252         (tic6x_dummy_id): Delete.
6253         (tic6x_gdbarch_init): Don't register deleted functions with
6254         gdbarch.
6255
6256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6257
6258         * sparc-tdep.c (sparc_unwind_pc): Delete.
6259         (sparc32_gdbarch_init): Don't register deleted function with
6260         gdbarch.
6261
6262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6263
6264         * sh-tdep.c (sh_unwind_sp): Delete.
6265         (sh_unwind_pc): Delete.
6266         (sh_dummy_id): Delete.
6267         (sh_gdbarch_init): Don't register deleted functions with
6268         gdbarch.
6269
6270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6271
6272         * score-tdep.c (score_unwind_sp): Delete.
6273         (score_unwind_pc): Delete.
6274         (score_dummy_id): Delete.
6275         (score_gdbarch_init): Don't register deleted functions with
6276         gdbarch.
6277
6278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6279
6280         * rx-tdep.c (rx_unwind_pc): Delete.
6281         (rx_unwind_sp): Delete.
6282         (rx_dummy_id): Delete.
6283         (rx_gdbarch_init): Don't register deleted functions with
6284         gdbarch.  Update comment.
6285
6286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6287
6288         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6289         (rs6000_dummy_id): Delete.
6290         (rs6000_gdbarch_init): Don't register deleted functions with
6291         gdbarch.
6292
6293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6294
6295         * or1k-tdep.c (or1k_dummy_id): Delete.
6296         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6297
6298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6299
6300         * nios2-tdep.c (nios2_dummy_id): Delete.
6301         (nios2_unwind_sp): Delete.
6302         (nios2_gdbarch_init): Don't register deleted functions with
6303         gdbarch.
6304
6305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6306
6307         * nds32-tdep.c (nds32_dummy_id): Delete.
6308         (nds32_unwind_pc): Delete.
6309         (nds32_unwind_sp): Delete.
6310         (nds32_gdbarch_init): Don't register deleted functions with
6311         gdbarch.
6312
6313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6314
6315         * msp430-tdep.c (msp430_unwind_pc): Delete.
6316         (msp430_unwind_sp): Delete.
6317         (msp430_dummy_id): Delete.
6318         (msp430_gdbarch_init): Don't register deleted functions with
6319         gdbarch.
6320
6321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6322
6323         * moxie-tdep.c (moxie_unwind_sp): Delete.
6324         (moxie_unwind_pc): Delete.
6325         (moxie_dummy_id): Delete.
6326         (moxie_gdbarch_init): Don't register deleted functions with
6327         gdbarch.
6328
6329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6330
6331         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6332         (mn10300_unwind_pc): Delete.
6333         (mn10300_unwind_sp): Delete.
6334         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6335         mn10300_unwind_sp.
6336         (mn10300_frame_unwind_init): Don't register deleted functions with
6337         gdbarch.
6338
6339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6340
6341         * mep-tdep.c (mep_unwind_pc): Delete.
6342         (mep_unwind_sp): Delete.
6343         (mep_dummy_id): Delete.
6344         (mep_gdbarch_init): Don't register deleted functions with
6345         gdbarch.
6346
6347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6348
6349         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6350         (m68hc11_unwind_sp): Delete.
6351         (m68hc11_gdbarch_init): Don't register deleted functions with
6352         gdbarch.
6353
6354 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6355
6356         * m32r-tdep.c (m32r_unwind_sp): Delete.
6357         (m32r_unwind_pc): Delete.
6358         (m32r_dummy_id): Delete.
6359         (m32r_gdbarch_init): Don't register deleted functions with
6360         gdbarch.
6361
6362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6363
6364         * m32c-tdep.c (m32c_unwind_pc): Delete.
6365         (m32c_unwind_sp): Delete.
6366         (m32c_dummy_id): Delete.
6367         (m32c_gdbarch_init): Don't register deleted functions with
6368         gdbarch.
6369
6370 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6371
6372         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6373         (lm32_unwind_pc): Delete.
6374         (lm32_dummy_id): Delete.
6375         (lm32_gdbarch_init): Don't register deleted functions with
6376         gdbarch.
6377
6378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6379
6380         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6381         (iq2000_unwind_pc): Delete.
6382         (iq2000_dummy_id): Delete.
6383         (iq2000_gdbarch_init): Don't register deleted functions with
6384         gdbarch.
6385
6386 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6387
6388         * nds32-tdep.c (nds32_type_align): Delete.
6389         (nds32_push_dummy_call): Use type_align instead.
6390
6391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6392
6393         * arm-tdep.c (arm_type_align): Only handle vector override case.
6394         (arm_push_dummy_call): Use type_align.
6395         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6396
6397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6398
6399         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6400         case.
6401         (pass_on_stack): Use type_align.
6402         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6403         function.
6404
6405 2019-04-23  Tom Tromey  <tromey@adacore.com>
6406
6407         * dwarf2read.c (line_header::file_name_at): Remove unused
6408         overload.
6409
6410 2019-04-23  Tom de Vries  <tdevries@suse.de>
6411
6412         PR gdb/24438
6413         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6414         invocation.
6415
6416
6417 2019-03-27  Ali Tamur  <tamur@google.com>
6418
6419         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6420         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6421         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6422         (dwarf_expr_context::get_addr_index): Likewise
6423         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6424         (symbol_needs_eval_context::get_addr_index): Likewise
6425         (disassemble_dwarf_expression): Add DW_OP_addrx
6426         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6427         (read_cutu_die_from_dwo): Update comment
6428         (skip_one_die): Add DW_FORM_addrx
6429         (read_attribute_value): Likewise
6430         (var_decode_location): Add DW_OP_addrx
6431         (dwarf2_const_value_attr): Add DW_FORM_addrx
6432         (dump_die_shallow): Likewise
6433         (dwarf2_fetch_constant_bytes): Likewise
6434         (decode_locdesc): Add DW_OP_addrx
6435         (skip_form_bytes): Add DW_FORM_addrx
6436
6437 2019-04-22  Ali Tamur  <tamur@google.com>
6438
6439         * MAINTAINERS (Write After Approval): Add self.
6440
6441 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6442
6443         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6444         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6445         (open_symbol_file_object): Likewise.
6446         (svr4_default_sos): Add info parameter.
6447         (svr4_read_so_list): Likewise.
6448         (svr4_current_sos_direct): Adjust functions calls to pass down
6449         info.
6450         (svr4_current_sos_1): Add info parameter.
6451         (svr4_current_sos): Call get_svr4_info, pass info down to
6452         svr4_current_sos_1.
6453         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6454         get_svr4_info.
6455         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6456         get_svr4_info.
6457         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6458         to get_svr4_info.
6459         (probes_table_remove_objfile_probes): Likewise.
6460         (register_solib_event_probe): Add info parameter.
6461         (solist_update_incremental): Pass info parameter down to
6462         svr4_read_so_list.
6463         (disable_probes_interface): Add info parameter.
6464         (svr4_handle_solib_event): Pass current_program_space to
6465         get_svr4_info.  Adjust disable_probes_interface cleanup.
6466         (svr4_create_probe_breakpoints): Add info parameter, pass it
6467         down to register_solib_event_probe.
6468         (svr4_create_solib_event_breakpoints): Add info parameter,
6469         pass it down to svr4_create_probe_breakpoints.
6470         (enable_break): Pass info down to
6471         svr4_create_solib_event_breakpoints.
6472         (svr4_solib_create_inferior_hook): Pass current_program_space to
6473         get_svr4_info.
6474         (svr4_clear_solib): Likewise.
6475
6476 2019-04-22  Pedro Alves  <palves@redhat.com>
6477
6478         * solib-svr4.c (svr4_free_objfile_observer): New.
6479         (probe_and_action::objfile): New field.
6480         (probes_table_htab_remove_objfile_probes)
6481         (probes_table_remove_objfile_probes): New functions.
6482         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6483         in the new probe_and_action.  Don't store the probe in 'lookup'.
6484         (svr4_create_probe_breakpoints): Pass objfile to
6485         register_solib_event_probe.
6486         (_initialize_svr4_solib): Register a free_objfile observer.
6487
6488 2019-04-19  Tom Tromey  <tom@tromey.com>
6489
6490         * common/queue.h: Remove.
6491
6492 2019-04-19  Tom Tromey  <tom@tromey.com>
6493
6494         * event-loop.c: Don't include "common/queue.h".
6495
6496 2019-04-19  Tom Tromey  <tom@tromey.com>
6497
6498         * remote.c (remote_target): Use delete.
6499         * remote-notif.h: Include <list>, not "common/queue.h".
6500         (notif_client_p): Remove typedef.
6501         (remote_notif_state): Add constructor, destructor, initializer.
6502         <notif_queue>: Now a std::list.
6503         (remote_notif_state_xfree): Don't declare.
6504         * remote-notif.c (remote_notif_process, handle_notification)
6505         (remote_notif_state_allocate): Update.
6506         (~remote_notif_state): Rename from remote_notif_state_xfree.
6507
6508 2019-04-19  Tom Tromey  <tom@tromey.com>
6509
6510         * symfile.c (reread_symbols): Update.
6511         * objfiles.c (objfile_register_static_link)
6512         (objfile_lookup_static_link): Update
6513         (~objfile) Don't delete static_links.
6514         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6515
6516 2019-04-19  Tom Tromey  <tom@tromey.com>
6517
6518         * type-stack.h (struct type_stack) <insert>: Constify string.
6519         * type-stack.c (type_stack::insert): Constify string.
6520         * gdbtypes.h (lookup_template_type): Update.
6521         (address_space_name_to_int): Update.
6522         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6523         const.
6524         (lookup_template_type): Make name const.
6525         * c-exp.y: Update rules.
6526         (lex_one_token, classify_name, classify_inner_name)
6527         (c_print_token): Update.
6528         * p-exp.y: Update rules.
6529         (yylex): Update.
6530         * f-exp.y: Update rules.
6531         (yylex): Update.
6532         * d-exp.y: Update rules.
6533         (lex_one_token, classify_name, classify_inner_name): Update.
6534         * parse.c (write_dollar_variable, copy_name): Return std::string.
6535         * parser-defs.h (copy_name): Change return type.
6536         * m2-exp.y: Update rules.
6537         (yylex): Update.
6538         * go-exp.y (lex_one_token): Update.
6539         Update rules.
6540         (classify_unsafe_function, classify_packaged_name)
6541         (classify_name, yylex): Update.
6542
6543 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6544
6545         * configure.ac: add --enable-source-highlight switch.
6546         * configure: Regenerate.
6547         * top.c (print_gdb_version): plumb --enable-source-highlight
6548         status to "show configuration".
6549
6550 2019-04-19  Tom Tromey  <tromey@adacore.com>
6551
6552         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6553         Check ADA_TYPE_P.
6554         (empty_record, ada_template_to_fixed_record_type_1)
6555         (template_to_static_fixed_type)
6556         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6557         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6558         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6559         macros.
6560
6561 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6562
6563         PR symtab/24423:
6564         * source.c (print_source_lines_base): Advance "iter" when a
6565         control character is seen.
6566
6567 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6568
6569         * inferior.h (struct infcall_suspend_state_deleter):
6570         Catch exception in destructor to avoid crash.
6571
6572 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6573
6574         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6575         close to the add_com "shell".
6576
6577 2019-04-18  Tom Tromey  <tromey@adacore.com>
6578
6579         * process-stratum-target.h (class process_stratum_target)
6580         <stratum>: Add "final".
6581
6582 2019-04-17  Tom Tromey  <tromey@adacore.com>
6583
6584         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6585         against nullptr before use.
6586
6587 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6588
6589         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6590
6591 2019-04-17  Jim Wilson  <jimw@sifive.com>
6592             Andrew Burgess  <andrew.burgess@embecosm.com>
6593
6594         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6595         code read might fail, assume 4-byte breakpoint in that case.
6596
6597 2019-04-15  Leszek Swirski  <leszeks@google.com>
6598
6599         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6600         rather than a hand-rolled POD check when checking for forced MEMORY
6601         classification.
6602
6603 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6604
6605         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6606         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6607         function.
6608         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6609         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6610         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6611         declaration.
6612
6613 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6614
6615         * aarch64-linux-nat.c
6616         (aarch64_linux_nat_target::thread_architecture): Add override.
6617         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6618         each VQ.
6619
6620 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6621
6622         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6623
6624 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6625
6626         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6627         target types of size 96-bits, add some additional comments, and
6628         check that the builtin type we found was the correct size.
6629
6630 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6631
6632         * utils.c (prompt_for_continue): Don't restore the styling at the
6633         end, as applied_style has the wrong value.  This fixes styling in
6634         long lists of file names that are interrupted by the "Continue?"
6635         prompt.
6636
6637 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6638
6639         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6640         * c-lang.c (c_language_defn): Likewise.
6641         (cplus_language_defn): Likewise.
6642         (asm_language_defn): Likewise.
6643         (minimal_language_defn): Likewise.
6644         * d-lang.c (d_language_defn): Likewise.
6645         * f-lang.c (f_language_defn): Likewise.
6646         * go-lang.c (go_language_defn): Likewise.
6647         * language.c (unknown_language_defn): Likewise.
6648         (auto_language_defn): Likewise.
6649         * language.h (struct language_defn): Remove la_magic field.
6650         (LANG_MAGIC): Delete.
6651         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6652         * objc-lang.c (objc_language_defn): Likewise.
6653         * opencl-lang.c (opencl_language_defn): Likewise.
6654         * p-lang.c (pascal_language_defn): Likewise.
6655         * rust-lang.c (rust_language_defn): Likewise.
6656
6657 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6658
6659         * riscv-tdep.c (riscv_type_align): New function.
6660         (riscv_type_alignment): Delete.
6661         (riscv_arg_location): Use 'type_align'.
6662         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6663
6664 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6665
6666         * gdbtypes.c (type_align): A struct with no non-static fields also
6667         has alignment of 1.
6668
6669 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6670
6671         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6672         component to 0.
6673         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6674         member.
6675         (riscv_struct_info::analyse): New implementation using new
6676         analyse_inner member function.
6677         (riscv_struct_info::field_offset): New member function.
6678         (riscv_struct_info::m_offsets): New member variable.
6679         (riscv_struct_info::analyse_inner): New private member function,
6680         takes the old implementation of riscv_struct_info::analyse but
6681         extended to track field offsets.
6682         (riscv_call_arg_struct): Update the struct folding special cases
6683         to handle cases where empty C++ structs, which are non-zero
6684         length, are found.
6685         (riscv_arg_location): Initialise the length of each location, a
6686         non-zero length now indicates the location is in use.
6687         (riscv_push_dummy_call): Allow for the first location having a
6688         non-zero offset when setting up arguments.
6689         (riscv_return_value): Likewise, but for return values.
6690
6691 2019-04-11  Tom Tromey  <tromey@adacore.com>
6692
6693         * utils.c (internal_vproblem): Make "msg" const.
6694
6695 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6696
6697         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6698         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6699         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6700         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6701
6702 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6703
6704         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6705         function.
6706         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6707         of amd64_collect_native_gregset.
6708         (amd64_linux_nat_target::store_registers): Likewise.
6709
6710 2019-04-10  Tom Tromey  <tom@tromey.com>
6711
6712         * symtab.c (lookup_global_symbol_from_objfile)
6713         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6714         * objfiles.h (class separate_debug_iterator): New.
6715         (class separate_debug_range): New.
6716         (struct objfile) <separate_debug_objfiles>: New method.
6717         (objfile_separate_debug_iterate): Don't declare.
6718         * objfiles.c (separate_debug_iterator::operator++): Rename from
6719         objfile_separate_debug_iterate.
6720         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6721         iterator.
6722         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6723         iterator.
6724
6725 2019-04-10  Tom Tromey  <tom@tromey.com>
6726
6727         * symfile.c (reread_symbols): Remove old comment.
6728         * objfiles.c (free_all_objfiles): Fix a typo.
6729
6730 2019-04-10  Tom Tromey  <tom@tromey.com>
6731
6732         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6733         * minsyms.c (lookup_minimal_symbol): Use foreach.
6734         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6735         (lookup_minimal_symbol_solib_trampoline): Likewise.
6736         * symfile.c (reread_symbols): Use foreach.
6737
6738 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6739             Tom Tromey  <tromey@adacore.com>
6740
6741         PR rust/24414:
6742         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6743         (rust_lex_int_test): Change "value" to be LONGEST.
6744         (rust_lex_tests): Add test for long integer literal.
6745
6746 2019-04-09  Tom Tromey  <tromey@adacore.com>
6747
6748         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6749         to bool.
6750         (extended_remote_target::attach): Update.
6751         (remote_target::remote_notice_new_inferior): Update.
6752         (remote_target::add_current_inferior_and_thread): Update.
6753         * inferior.c (exit_inferior_1): Use "false".
6754         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6755
6756 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6757
6758         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6759         the "start" command.
6760
6761 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6762
6763         * python/py-inferior.c (infpy_thread_from_thread_handle):
6764         Adjust comments to reflect renaming of thread_from_thread_handle
6765         to thread_from_handle.  Adjust keywords.  Fix type error message.
6766         (inferior_object_methods): Add thread_from_handle.  Retain
6767         thread_from_thread_handle, but mark it as deprecated.
6768
6769 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6770
6771         * gdbthread.h (find_thread_by_handle): Revise declaration.
6772         * thread.c (find_thread_by_handle): Likewise.  Adjust
6773         implementation too.
6774         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6775         support for buffer objects as handles.
6776
6777 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6778
6779         * python/py-infthread.c (thpy_thread_handle): New function.
6780         (thread_object_methods): Register thpy_thread_handle.
6781
6782 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6783
6784         * gdbthread.h (thread_to_thread_handle): Declare.
6785         * thread.c (gdbtypes.h): Include.
6786         (thread_to_thread_handle): New function.
6787
6788         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6789         (target_thread_info_to_thread_handle): Declare.
6790         * target.c (target_thread_info_to_thread_handle): New function.
6791         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6792         * target-delegates.c: Regenerate.
6793
6794         * linux-thread-db.c (class thread_db_target): Add method
6795         thread_info_to_thread_handle.
6796         (thread_db_target::thread_info_to_thread_handle): Define.
6797         * remote.c (class remote_target): Add new method
6798         thread_info_to_thread_handle.
6799         (remote_target::thread_info_to_thread_handle): Define.
6800
6801 2019-04-08  Pedro Alves  <palves@redhat.com>
6802
6803         * common/common-exceptions.c (throw_exception): Don't create
6804         named object to throw; throw directly.
6805         (throw_it): Likewise.  Don't initialize gdb_exception::message
6806         here, with new; pass FMT and AP to the ctor instead.
6807         * common/common-exceptions.h: Include <string>.
6808         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6809         const char *, va_list)): New ctor.  Use std::make_shared.
6810         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6811         errors)): Delete.
6812         (gdb_exception_error::gdb_exception_error(enum errors, const char
6813         *, va_list)): New.
6814         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6815         Add assertion.
6816         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6817         errors)): Delete.
6818         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6819         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6820         Add assertion.
6821
6822 2019-04-08  Tom Tromey  <tom@tromey.com>
6823
6824         * valops.c (value_rtti_indirect_type): Replace throw_exception
6825         with throw.
6826         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6827         with throw.
6828         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6829         throw.
6830         * target.c (target_translate_tls_address): Replace throw_exception
6831         with throw.
6832         * stack.c (frame_apply_command_count): Replace throw_exception
6833         with throw.
6834         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6835         throw.
6836         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6837         with throw.
6838         * rs6000-tdep.c (rs6000_frame_cache)
6839         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6840         * remote.c: Replace throw_exception with throw.
6841         * record-full.c (record_full_message, record_full_wait_1)
6842         (record_full_restore): Replace throw_exception with throw.
6843         * record-btrace.c:
6844         (get_thread_current_frame_id, record_btrace_start_replaying)
6845         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6846         (cmd_record_btrace_start): Replace throw_exception with throw.
6847         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6848         throw.
6849         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6850         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6851         * linespec.c:
6852         (find_linespec_symbols): Replace throw_exception with throw.
6853         * infrun.c (displaced_step_prepare, resume): Replace
6854         throw_exception with throw.
6855         * infcmd.c (post_create_inferior): Replace throw_exception with
6856         throw.
6857         * inf-loop.c (inferior_event_handler): Replace throw_exception
6858         with throw.
6859         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6860         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6861         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6862         (get_prev_frame_always, get_frame_pc_if_available)
6863         (get_frame_address_in_block_if_available, get_frame_language):
6864         Replace throw_exception with throw.
6865         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6866         throw_exception with throw.
6867         * eval.c (fetch_subexp_value, evaluate_var_value)
6868         (evaluate_funcall, evaluate_subexp_standard): Replace
6869         throw_exception with throw.
6870         * dwarf2loc.c (call_site_find_chain)
6871         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6872         Replace throw_exception with throw.
6873         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6874         with throw.
6875         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6876         throw.
6877         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6878         * completer.c (complete_line_internal): Replace throw_exception
6879         with throw.
6880         * compile/compile-object-run.c (compile_object_run): Replace
6881         throw_exception with throw.
6882         * cli/cli-script.c (process_next_line): Replace throw_exception
6883         with throw.
6884         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6885         (btrace_enable, btrace_maint_update_pt_packets): Replace
6886         throw_exception with throw.
6887         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6888         throw_exception with throw.
6889         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6890         throw_exception with throw.
6891         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6892         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6893         * aarch64-tdep.c (aarch64_make_prologue_cache)
6894         (aarch64_make_stub_cache): Replace throw_exception with throw.
6895
6896 2019-04-08  Tom Tromey  <tom@tromey.com>
6897
6898         * common/common-exceptions.c (throw_exception): Rename from
6899         throw_exception_cxx.  Remove old copy.  Make argument const.
6900         (throw_it): Create and throw exception objects directly.
6901         * common/common-exceptions.h (throw_exception): Make argument
6902         const.
6903         (struct gdb_exception_error): Add constructor.
6904         (struct gdb_exception_quit): Add constructor.
6905
6906 2019-04-08  Tom Tromey  <tom@tromey.com>
6907
6908         * common/common-exceptions.h (exception_rethrow): Don't declare.
6909         (TRY_SJLJ): Update comment.
6910         (TRY, CATCH, END_CATCH): Remove.
6911         * common/common-exceptions.c (exception_rethrow): Remove.
6912
6913 2019-04-08  Tom Tromey  <tom@tromey.com>
6914
6915         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6916         Remove.
6917         (gdb_exception_error): Rename from
6918         gdb_exception_RETURN_MASK_ERROR.
6919         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6920         (gdb_quit_bad_alloc): Update.
6921         * aarch64-tdep.c: Update.
6922         * ada-lang.c: Update.
6923         * ada-typeprint.c: Update.
6924         * ada-valprint.c: Update.
6925         * amd64-tdep.c: Update.
6926         * arch-utils.c: Update.
6927         * break-catch-throw.c: Update.
6928         * breakpoint.c: Update.
6929         * btrace.c: Update.
6930         * c-varobj.c: Update.
6931         * cli/cli-cmds.c: Update.
6932         * cli/cli-interp.c: Update.
6933         * cli/cli-script.c: Update.
6934         * common/common-exceptions.c: Update.
6935         * common/new-op.c: Update.
6936         * common/selftest.c: Update.
6937         * compile/compile-c-symbols.c: Update.
6938         * compile/compile-cplus-symbols.c: Update.
6939         * compile/compile-object-load.c: Update.
6940         * compile/compile-object-run.c: Update.
6941         * completer.c: Update.
6942         * corelow.c: Update.
6943         * cp-abi.c: Update.
6944         * cp-support.c: Update.
6945         * cp-valprint.c: Update.
6946         * darwin-nat.c: Update.
6947         * disasm-selftests.c: Update.
6948         * dtrace-probe.c: Update.
6949         * dwarf-index-cache.c: Update.
6950         * dwarf-index-write.c: Update.
6951         * dwarf2-frame-tailcall.c: Update.
6952         * dwarf2-frame.c: Update.
6953         * dwarf2loc.c: Update.
6954         * dwarf2read.c: Update.
6955         * eval.c: Update.
6956         * event-loop.c: Update.
6957         * event-top.c: Update.
6958         * exec.c: Update.
6959         * f-valprint.c: Update.
6960         * fbsd-tdep.c: Update.
6961         * frame-unwind.c: Update.
6962         * frame.c: Update.
6963         * gdbtypes.c: Update.
6964         * gnu-v3-abi.c: Update.
6965         * guile/guile-internal.h: Update.
6966         * guile/scm-block.c: Update.
6967         * guile/scm-breakpoint.c: Update.
6968         * guile/scm-cmd.c: Update.
6969         * guile/scm-disasm.c: Update.
6970         * guile/scm-frame.c: Update.
6971         * guile/scm-lazy-string.c: Update.
6972         * guile/scm-math.c: Update.
6973         * guile/scm-param.c: Update.
6974         * guile/scm-ports.c: Update.
6975         * guile/scm-pretty-print.c: Update.
6976         * guile/scm-symbol.c: Update.
6977         * guile/scm-symtab.c: Update.
6978         * guile/scm-type.c: Update.
6979         * guile/scm-value.c: Update.
6980         * i386-linux-tdep.c: Update.
6981         * i386-tdep.c: Update.
6982         * inf-loop.c: Update.
6983         * infcall.c: Update.
6984         * infcmd.c: Update.
6985         * infrun.c: Update.
6986         * jit.c: Update.
6987         * language.c: Update.
6988         * linespec.c: Update.
6989         * linux-fork.c: Update.
6990         * linux-nat.c: Update.
6991         * linux-tdep.c: Update.
6992         * linux-thread-db.c: Update.
6993         * main.c: Update.
6994         * mi/mi-cmd-break.c: Update.
6995         * mi/mi-cmd-stack.c: Update.
6996         * mi/mi-interp.c: Update.
6997         * mi/mi-main.c: Update.
6998         * objc-lang.c: Update.
6999         * p-valprint.c: Update.
7000         * parse.c: Update.
7001         * ppc-linux-tdep.c: Update.
7002         * printcmd.c: Update.
7003         * python/py-arch.c: Update.
7004         * python/py-breakpoint.c: Update.
7005         * python/py-cmd.c: Update.
7006         * python/py-finishbreakpoint.c: Update.
7007         * python/py-frame.c: Update.
7008         * python/py-framefilter.c: Update.
7009         * python/py-gdb-readline.c: Update.
7010         * python/py-inferior.c: Update.
7011         * python/py-infthread.c: Update.
7012         * python/py-lazy-string.c: Update.
7013         * python/py-linetable.c: Update.
7014         * python/py-objfile.c: Update.
7015         * python/py-param.c: Update.
7016         * python/py-prettyprint.c: Update.
7017         * python/py-progspace.c: Update.
7018         * python/py-record-btrace.c: Update.
7019         * python/py-record.c: Update.
7020         * python/py-symbol.c: Update.
7021         * python/py-type.c: Update.
7022         * python/py-unwind.c: Update.
7023         * python/py-utils.c: Update.
7024         * python/py-value.c: Update.
7025         * python/python.c: Update.
7026         * record-btrace.c: Update.
7027         * record-full.c: Update.
7028         * remote-fileio.c: Update.
7029         * remote.c: Update.
7030         * riscv-tdep.c: Update.
7031         * rs6000-aix-tdep.c: Update.
7032         * rs6000-tdep.c: Update.
7033         * rust-exp.y: Update.
7034         * rust-lang.c: Update.
7035         * s390-tdep.c: Update.
7036         * selftest-arch.c: Update.
7037         * solib-dsbt.c: Update.
7038         * solib-frv.c: Update.
7039         * solib-spu.c: Update.
7040         * solib-svr4.c: Update.
7041         * solib.c: Update.
7042         * sparc64-linux-tdep.c: Update.
7043         * stack.c: Update.
7044         * symfile-mem.c: Update.
7045         * symmisc.c: Update.
7046         * target.c: Update.
7047         * thread.c: Update.
7048         * top.c: Update.
7049         * tracefile-tfile.c: Update.
7050         * tui/tui.c: Update.
7051         * typeprint.c: Update.
7052         * unittests/cli-utils-selftests.c: Update.
7053         * unittests/parse-connection-spec-selftests.c: Update.
7054         * valops.c: Update.
7055         * valprint.c: Update.
7056         * value.c: Update.
7057         * varobj.c: Update.
7058         * windows-nat.c: Update.
7059         * x86-linux-nat.c: Update.
7060         * xml-support.c: Update.
7061
7062 2019-04-08  Tom Tromey  <tom@tromey.com>
7063
7064         * xml-support.c: Use C++ exception handling.
7065         * x86-linux-nat.c: Use C++ exception handling.
7066         * windows-nat.c: Use C++ exception handling.
7067         * varobj.c: Use C++ exception handling.
7068         * value.c: Use C++ exception handling.
7069         * valprint.c: Use C++ exception handling.
7070         * valops.c: Use C++ exception handling.
7071         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7072         handling.
7073         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7074         * typeprint.c: Use C++ exception handling.
7075         * tui/tui.c: Use C++ exception handling.
7076         * tracefile-tfile.c: Use C++ exception handling.
7077         * top.c: Use C++ exception handling.
7078         * thread.c: Use C++ exception handling.
7079         * target.c: Use C++ exception handling.
7080         * symmisc.c: Use C++ exception handling.
7081         * symfile-mem.c: Use C++ exception handling.
7082         * stack.c: Use C++ exception handling.
7083         * sparc64-linux-tdep.c: Use C++ exception handling.
7084         * solib.c: Use C++ exception handling.
7085         * solib-svr4.c: Use C++ exception handling.
7086         * solib-spu.c: Use C++ exception handling.
7087         * solib-frv.c: Use C++ exception handling.
7088         * solib-dsbt.c: Use C++ exception handling.
7089         * selftest-arch.c: Use C++ exception handling.
7090         * s390-tdep.c: Use C++ exception handling.
7091         * rust-lang.c: Use C++ exception handling.
7092         * rust-exp.y: Use C++ exception handling.
7093         * rs6000-tdep.c: Use C++ exception handling.
7094         * rs6000-aix-tdep.c: Use C++ exception handling.
7095         * riscv-tdep.c: Use C++ exception handling.
7096         * remote.c: Use C++ exception handling.
7097         * remote-fileio.c: Use C++ exception handling.
7098         * record-full.c: Use C++ exception handling.
7099         * record-btrace.c: Use C++ exception handling.
7100         * python/python.c: Use C++ exception handling.
7101         * python/py-value.c: Use C++ exception handling.
7102         * python/py-utils.c: Use C++ exception handling.
7103         * python/py-unwind.c: Use C++ exception handling.
7104         * python/py-type.c: Use C++ exception handling.
7105         * python/py-symbol.c: Use C++ exception handling.
7106         * python/py-record.c: Use C++ exception handling.
7107         * python/py-record-btrace.c: Use C++ exception handling.
7108         * python/py-progspace.c: Use C++ exception handling.
7109         * python/py-prettyprint.c: Use C++ exception handling.
7110         * python/py-param.c: Use C++ exception handling.
7111         * python/py-objfile.c: Use C++ exception handling.
7112         * python/py-linetable.c: Use C++ exception handling.
7113         * python/py-lazy-string.c: Use C++ exception handling.
7114         * python/py-infthread.c: Use C++ exception handling.
7115         * python/py-inferior.c: Use C++ exception handling.
7116         * python/py-gdb-readline.c: Use C++ exception handling.
7117         * python/py-framefilter.c: Use C++ exception handling.
7118         * python/py-frame.c: Use C++ exception handling.
7119         * python/py-finishbreakpoint.c: Use C++ exception handling.
7120         * python/py-cmd.c: Use C++ exception handling.
7121         * python/py-breakpoint.c: Use C++ exception handling.
7122         * python/py-arch.c: Use C++ exception handling.
7123         * printcmd.c: Use C++ exception handling.
7124         * ppc-linux-tdep.c: Use C++ exception handling.
7125         * parse.c: Use C++ exception handling.
7126         * p-valprint.c: Use C++ exception handling.
7127         * objc-lang.c: Use C++ exception handling.
7128         * mi/mi-main.c: Use C++ exception handling.
7129         * mi/mi-interp.c: Use C++ exception handling.
7130         * mi/mi-cmd-stack.c: Use C++ exception handling.
7131         * mi/mi-cmd-break.c: Use C++ exception handling.
7132         * main.c: Use C++ exception handling.
7133         * linux-thread-db.c: Use C++ exception handling.
7134         * linux-tdep.c: Use C++ exception handling.
7135         * linux-nat.c: Use C++ exception handling.
7136         * linux-fork.c: Use C++ exception handling.
7137         * linespec.c: Use C++ exception handling.
7138         * language.c: Use C++ exception handling.
7139         * jit.c: Use C++ exception handling.
7140         * infrun.c: Use C++ exception handling.
7141         * infcmd.c: Use C++ exception handling.
7142         * infcall.c: Use C++ exception handling.
7143         * inf-loop.c: Use C++ exception handling.
7144         * i386-tdep.c: Use C++ exception handling.
7145         * i386-linux-tdep.c: Use C++ exception handling.
7146         * guile/scm-value.c: Use C++ exception handling.
7147         * guile/scm-type.c: Use C++ exception handling.
7148         * guile/scm-symtab.c: Use C++ exception handling.
7149         * guile/scm-symbol.c: Use C++ exception handling.
7150         * guile/scm-pretty-print.c: Use C++ exception handling.
7151         * guile/scm-ports.c: Use C++ exception handling.
7152         * guile/scm-param.c: Use C++ exception handling.
7153         * guile/scm-math.c: Use C++ exception handling.
7154         * guile/scm-lazy-string.c: Use C++ exception handling.
7155         * guile/scm-frame.c: Use C++ exception handling.
7156         * guile/scm-disasm.c: Use C++ exception handling.
7157         * guile/scm-cmd.c: Use C++ exception handling.
7158         * guile/scm-breakpoint.c: Use C++ exception handling.
7159         * guile/scm-block.c: Use C++ exception handling.
7160         * guile/guile-internal.h: Use C++ exception handling.
7161         * gnu-v3-abi.c: Use C++ exception handling.
7162         * gdbtypes.c: Use C++ exception handling.
7163         * frame.c: Use C++ exception handling.
7164         * frame-unwind.c: Use C++ exception handling.
7165         * fbsd-tdep.c: Use C++ exception handling.
7166         * f-valprint.c: Use C++ exception handling.
7167         * exec.c: Use C++ exception handling.
7168         * event-top.c: Use C++ exception handling.
7169         * event-loop.c: Use C++ exception handling.
7170         * eval.c: Use C++ exception handling.
7171         * dwarf2read.c: Use C++ exception handling.
7172         * dwarf2loc.c: Use C++ exception handling.
7173         * dwarf2-frame.c: Use C++ exception handling.
7174         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7175         * dwarf-index-write.c: Use C++ exception handling.
7176         * dwarf-index-cache.c: Use C++ exception handling.
7177         * dtrace-probe.c: Use C++ exception handling.
7178         * disasm-selftests.c: Use C++ exception handling.
7179         * darwin-nat.c: Use C++ exception handling.
7180         * cp-valprint.c: Use C++ exception handling.
7181         * cp-support.c: Use C++ exception handling.
7182         * cp-abi.c: Use C++ exception handling.
7183         * corelow.c: Use C++ exception handling.
7184         * completer.c: Use C++ exception handling.
7185         * compile/compile-object-run.c: Use C++ exception handling.
7186         * compile/compile-object-load.c: Use C++ exception handling.
7187         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7188         * compile/compile-c-symbols.c: Use C++ exception handling.
7189         * common/selftest.c: Use C++ exception handling.
7190         * common/new-op.c: Use C++ exception handling.
7191         * cli/cli-script.c: Use C++ exception handling.
7192         * cli/cli-interp.c: Use C++ exception handling.
7193         * cli/cli-cmds.c: Use C++ exception handling.
7194         * c-varobj.c: Use C++ exception handling.
7195         * btrace.c: Use C++ exception handling.
7196         * breakpoint.c: Use C++ exception handling.
7197         * break-catch-throw.c: Use C++ exception handling.
7198         * arch-utils.c: Use C++ exception handling.
7199         * amd64-tdep.c: Use C++ exception handling.
7200         * ada-valprint.c: Use C++ exception handling.
7201         * ada-typeprint.c: Use C++ exception handling.
7202         * ada-lang.c: Use C++ exception handling.
7203         * aarch64-tdep.c: Use C++ exception handling.
7204
7205 2019-04-08  Tom Tromey  <tom@tromey.com>
7206
7207         * xml-support.c (gdb_xml_parser::parse): Update.
7208         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7209         * value.c (show_convenience): Update.
7210         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7211         (test_parse_flags_qcs): Update.
7212         * thread.c (thr_try_catch_cmd): Update.
7213         * target.c (target_translate_tls_address): Update.
7214         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7215         (info_frame_command_core, frame_apply_command_count): Update.
7216         * rust-exp.y (rust_lex_exception_test): Update.
7217         * riscv-tdep.c (riscv_print_one_register_info): Update.
7218         * remote.c (remote_target::enable_btrace): Update.
7219         * record-btrace.c (record_btrace_enable_warn): Update.
7220         * python/py-utils.c (gdbpy_convert_exception): Update.
7221         * printcmd.c (do_one_display, print_variable_and_value): Update.
7222         * mi/mi-main.c (mi_print_exception): Update.
7223         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7224         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7225         * linux-nat.c (linux_nat_target::attach): Update.
7226         * linux-fork.c (class scoped_switch_fork_info): Update.
7227         * infrun.c (displaced_step_prepare): Update.
7228         * infcall.c (call_function_by_hand_dummy): Update.
7229         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7230         * gnu-v3-abi.c (print_one_vtable): Update.
7231         * frame.c (get_prev_frame_always): Update.
7232         * f-valprint.c (info_common_command_for_block): Update.
7233         * exec.c (try_open_exec_file): Update.
7234         * exceptions.c (print_exception, exception_print)
7235         (exception_fprintf, exception_print_same): Update.
7236         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7237         * dwarf-index-cache.c (index_cache::store)
7238         (index_cache::lookup_gdb_index): Update.
7239         * darwin-nat.c (maybe_cache_shell): Update.
7240         * cp-valprint.c (cp_print_value_fields): Update.
7241         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7242         (gcc_cplus_symbol_address): Update.
7243         * compile/compile-c-symbols.c (gcc_convert_symbol)
7244         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7245         * common/selftest.c: Update.
7246         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7247         a std::string.
7248         (exception_try_scope_entry, exception_try_scope_exit): Don't
7249         declare.
7250         (struct exception_try_scope): Remove.
7251         (TRY): Don't use exception_try_scope.
7252         (struct gdb_exception): Add constructor, operator=.
7253         <what>: New method.
7254         (struct gdb_exception_RETURN_MASK_ALL)
7255         (struct gdb_exception_RETURN_MASK_ERROR)
7256         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7257         (struct gdb_quit_bad_alloc): Update.
7258         * common/common-exceptions.c (exception_none): Change
7259         initializer.
7260         (struct catcher) <state, exception>: Initialize inline.
7261         <prev>: Remove member.
7262         (current_catcher): Remove.
7263         (catchers): New global.
7264         (exceptions_state_mc_init): Simplify.
7265         (catcher_pop): Remove.
7266         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7267         (try_scope_depth, exception_try_scope_entry)
7268         (exception_try_scope_exit): Remove.
7269         (throw_exception_sjlj): Update.
7270         (exception_messages, exception_messages_size): Remove.
7271         (throw_it): Simplify.
7272         (gdb_exception_sliced_copy): Remove.
7273         (throw_exception_cxx): Update.
7274         * cli/cli-script.c (script_from_file): Update.
7275         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7276         Update.
7277         * ada-valprint.c (ada_val_print): Update.
7278         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7279         (create_excep_cond_exprs): Update.
7280
7281 2019-04-08  Tom Tromey  <tom@tromey.com>
7282
7283         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7284         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7285         (TRY, CATCH, END_CATCH): Remove some definitions.
7286         * common/common-exceptions.c: Don't use GDB_XCPT.
7287         (catcher_list_size): Remove.
7288         (throw_exception, throw_it): Simplify.
7289
7290 2019-04-05  Tom Tromey  <tom@tromey.com>
7291
7292         Revert the header-sorting patch.
7293         * ft32-tdep.c: Revert.
7294         * frv-tdep.c: Revert.
7295         * frv-linux-tdep.c: Revert.
7296         * frame.c: Revert.
7297         * frame-unwind.c: Revert.
7298         * frame-base.c: Revert.
7299         * fork-child.c: Revert.
7300         * findvar.c: Revert.
7301         * findcmd.c: Revert.
7302         * filesystem.c: Revert.
7303         * filename-seen-cache.h: Revert.
7304         * filename-seen-cache.c: Revert.
7305         * fbsd-tdep.c: Revert.
7306         * fbsd-nat.h: Revert.
7307         * fbsd-nat.c: Revert.
7308         * f-valprint.c: Revert.
7309         * f-typeprint.c: Revert.
7310         * f-lang.c: Revert.
7311         * extension.h: Revert.
7312         * extension.c: Revert.
7313         * extension-priv.h: Revert.
7314         * expprint.c: Revert.
7315         * exec.h: Revert.
7316         * exec.c: Revert.
7317         * exceptions.c: Revert.
7318         * event-top.c: Revert.
7319         * event-loop.c: Revert.
7320         * eval.c: Revert.
7321         * elfread.c: Revert.
7322         * dwarf2read.h: Revert.
7323         * dwarf2read.c: Revert.
7324         * dwarf2loc.c: Revert.
7325         * dwarf2expr.h: Revert.
7326         * dwarf2expr.c: Revert.
7327         * dwarf2-frame.c: Revert.
7328         * dwarf2-frame-tailcall.c: Revert.
7329         * dwarf-index-write.h: Revert.
7330         * dwarf-index-write.c: Revert.
7331         * dwarf-index-common.c: Revert.
7332         * dwarf-index-cache.h: Revert.
7333         * dwarf-index-cache.c: Revert.
7334         * dummy-frame.c: Revert.
7335         * dtrace-probe.c: Revert.
7336         * disasm.h: Revert.
7337         * disasm.c: Revert.
7338         * disasm-selftests.c: Revert.
7339         * dictionary.c: Revert.
7340         * dicos-tdep.c: Revert.
7341         * demangle.c: Revert.
7342         * dcache.h: Revert.
7343         * dcache.c: Revert.
7344         * darwin-nat.h: Revert.
7345         * darwin-nat.c: Revert.
7346         * darwin-nat-info.c: Revert.
7347         * d-valprint.c: Revert.
7348         * d-namespace.c: Revert.
7349         * d-lang.c: Revert.
7350         * ctf.c: Revert.
7351         * csky-tdep.c: Revert.
7352         * csky-linux-tdep.c: Revert.
7353         * cris-tdep.c: Revert.
7354         * cris-linux-tdep.c: Revert.
7355         * cp-valprint.c: Revert.
7356         * cp-support.c: Revert.
7357         * cp-namespace.c: Revert.
7358         * cp-abi.c: Revert.
7359         * corelow.c: Revert.
7360         * corefile.c: Revert.
7361         * continuations.c: Revert.
7362         * completer.h: Revert.
7363         * completer.c: Revert.
7364         * complaints.c: Revert.
7365         * coffread.c: Revert.
7366         * coff-pe-read.c: Revert.
7367         * cli-out.h: Revert.
7368         * cli-out.c: Revert.
7369         * charset.c: Revert.
7370         * c-varobj.c: Revert.
7371         * c-valprint.c: Revert.
7372         * c-typeprint.c: Revert.
7373         * c-lang.c: Revert.
7374         * buildsym.c: Revert.
7375         * buildsym-legacy.c: Revert.
7376         * build-id.h: Revert.
7377         * build-id.c: Revert.
7378         * btrace.c: Revert.
7379         * bsd-uthread.c: Revert.
7380         * breakpoint.h: Revert.
7381         * breakpoint.c: Revert.
7382         * break-catch-throw.c: Revert.
7383         * break-catch-syscall.c: Revert.
7384         * break-catch-sig.c: Revert.
7385         * blockframe.c: Revert.
7386         * block.c: Revert.
7387         * bfin-tdep.c: Revert.
7388         * bfin-linux-tdep.c: Revert.
7389         * bfd-target.c: Revert.
7390         * bcache.c: Revert.
7391         * ax-general.c: Revert.
7392         * ax-gdb.h: Revert.
7393         * ax-gdb.c: Revert.
7394         * avr-tdep.c: Revert.
7395         * auxv.c: Revert.
7396         * auto-load.c: Revert.
7397         * arm-wince-tdep.c: Revert.
7398         * arm-tdep.c: Revert.
7399         * arm-symbian-tdep.c: Revert.
7400         * arm-pikeos-tdep.c: Revert.
7401         * arm-obsd-tdep.c: Revert.
7402         * arm-nbsd-tdep.c: Revert.
7403         * arm-nbsd-nat.c: Revert.
7404         * arm-linux-tdep.c: Revert.
7405         * arm-linux-nat.c: Revert.
7406         * arm-fbsd-tdep.c: Revert.
7407         * arm-fbsd-nat.c: Revert.
7408         * arm-bsd-tdep.c: Revert.
7409         * arch-utils.c: Revert.
7410         * arc-tdep.c: Revert.
7411         * arc-newlib-tdep.c: Revert.
7412         * annotate.h: Revert.
7413         * annotate.c: Revert.
7414         * amd64-windows-tdep.c: Revert.
7415         * amd64-windows-nat.c: Revert.
7416         * amd64-tdep.c: Revert.
7417         * amd64-sol2-tdep.c: Revert.
7418         * amd64-obsd-tdep.c: Revert.
7419         * amd64-obsd-nat.c: Revert.
7420         * amd64-nbsd-tdep.c: Revert.
7421         * amd64-nbsd-nat.c: Revert.
7422         * amd64-nat.c: Revert.
7423         * amd64-linux-tdep.c: Revert.
7424         * amd64-linux-nat.c: Revert.
7425         * amd64-fbsd-tdep.c: Revert.
7426         * amd64-fbsd-nat.c: Revert.
7427         * amd64-dicos-tdep.c: Revert.
7428         * amd64-darwin-tdep.c: Revert.
7429         * amd64-bsd-nat.c: Revert.
7430         * alpha-tdep.c: Revert.
7431         * alpha-obsd-tdep.c: Revert.
7432         * alpha-nbsd-tdep.c: Revert.
7433         * alpha-mdebug-tdep.c: Revert.
7434         * alpha-linux-tdep.c: Revert.
7435         * alpha-linux-nat.c: Revert.
7436         * alpha-bsd-tdep.c: Revert.
7437         * alpha-bsd-nat.c: Revert.
7438         * aix-thread.c: Revert.
7439         * agent.c: Revert.
7440         * addrmap.c: Revert.
7441         * ada-varobj.c: Revert.
7442         * ada-valprint.c: Revert.
7443         * ada-typeprint.c: Revert.
7444         * ada-tasks.c: Revert.
7445         * ada-lang.c: Revert.
7446         * aarch64-tdep.c: Revert.
7447         * aarch64-ravenscar-thread.c: Revert.
7448         * aarch64-newlib-tdep.c: Revert.
7449         * aarch64-linux-tdep.c: Revert.
7450         * aarch64-linux-nat.c: Revert.
7451         * aarch64-fbsd-tdep.c: Revert.
7452         * aarch64-fbsd-nat.c: Revert.
7453         * aarch32-linux-nat.c: Revert.
7454
7455 2019-04-05  Tom Tromey  <tom@tromey.com>
7456
7457         * ft32-tdep.c: Sort headers.
7458         * frv-tdep.c: Sort headers.
7459         * frv-linux-tdep.c: Sort headers.
7460         * frame.c: Sort headers.
7461         * frame-unwind.c: Sort headers.
7462         * frame-base.c: Sort headers.
7463         * fork-child.c: Sort headers.
7464         * findvar.c: Sort headers.
7465         * findcmd.c: Sort headers.
7466         * filesystem.c: Sort headers.
7467         * filename-seen-cache.h: Sort headers.
7468         * filename-seen-cache.c: Sort headers.
7469         * fbsd-tdep.c: Sort headers.
7470         * fbsd-nat.h: Sort headers.
7471         * fbsd-nat.c: Sort headers.
7472         * f-valprint.c: Sort headers.
7473         * f-typeprint.c: Sort headers.
7474         * f-lang.c: Sort headers.
7475         * extension.h: Sort headers.
7476         * extension.c: Sort headers.
7477         * extension-priv.h: Sort headers.
7478         * expprint.c: Sort headers.
7479         * exec.h: Sort headers.
7480         * exec.c: Sort headers.
7481         * exceptions.c: Sort headers.
7482         * event-top.c: Sort headers.
7483         * event-loop.c: Sort headers.
7484         * eval.c: Sort headers.
7485         * elfread.c: Sort headers.
7486         * dwarf2read.h: Sort headers.
7487         * dwarf2read.c: Sort headers.
7488         * dwarf2loc.c: Sort headers.
7489         * dwarf2expr.h: Sort headers.
7490         * dwarf2expr.c: Sort headers.
7491         * dwarf2-frame.c: Sort headers.
7492         * dwarf2-frame-tailcall.c: Sort headers.
7493         * dwarf-index-write.h: Sort headers.
7494         * dwarf-index-write.c: Sort headers.
7495         * dwarf-index-common.c: Sort headers.
7496         * dwarf-index-cache.h: Sort headers.
7497         * dwarf-index-cache.c: Sort headers.
7498         * dummy-frame.c: Sort headers.
7499         * dtrace-probe.c: Sort headers.
7500         * disasm.h: Sort headers.
7501         * disasm.c: Sort headers.
7502         * disasm-selftests.c: Sort headers.
7503         * dictionary.c: Sort headers.
7504         * dicos-tdep.c: Sort headers.
7505         * demangle.c: Sort headers.
7506         * dcache.h: Sort headers.
7507         * dcache.c: Sort headers.
7508         * darwin-nat.h: Sort headers.
7509         * darwin-nat.c: Sort headers.
7510         * darwin-nat-info.c: Sort headers.
7511         * d-valprint.c: Sort headers.
7512         * d-namespace.c: Sort headers.
7513         * d-lang.c: Sort headers.
7514         * ctf.c: Sort headers.
7515         * csky-tdep.c: Sort headers.
7516         * csky-linux-tdep.c: Sort headers.
7517         * cris-tdep.c: Sort headers.
7518         * cris-linux-tdep.c: Sort headers.
7519         * cp-valprint.c: Sort headers.
7520         * cp-support.c: Sort headers.
7521         * cp-namespace.c: Sort headers.
7522         * cp-abi.c: Sort headers.
7523         * corelow.c: Sort headers.
7524         * corefile.c: Sort headers.
7525         * continuations.c: Sort headers.
7526         * completer.h: Sort headers.
7527         * completer.c: Sort headers.
7528         * complaints.c: Sort headers.
7529         * coffread.c: Sort headers.
7530         * coff-pe-read.c: Sort headers.
7531         * cli-out.h: Sort headers.
7532         * cli-out.c: Sort headers.
7533         * charset.c: Sort headers.
7534         * c-varobj.c: Sort headers.
7535         * c-valprint.c: Sort headers.
7536         * c-typeprint.c: Sort headers.
7537         * c-lang.c: Sort headers.
7538         * buildsym.c: Sort headers.
7539         * buildsym-legacy.c: Sort headers.
7540         * build-id.h: Sort headers.
7541         * build-id.c: Sort headers.
7542         * btrace.c: Sort headers.
7543         * bsd-uthread.c: Sort headers.
7544         * breakpoint.h: Sort headers.
7545         * breakpoint.c: Sort headers.
7546         * break-catch-throw.c: Sort headers.
7547         * break-catch-syscall.c: Sort headers.
7548         * break-catch-sig.c: Sort headers.
7549         * blockframe.c: Sort headers.
7550         * block.c: Sort headers.
7551         * bfin-tdep.c: Sort headers.
7552         * bfin-linux-tdep.c: Sort headers.
7553         * bfd-target.c: Sort headers.
7554         * bcache.c: Sort headers.
7555         * ax-general.c: Sort headers.
7556         * ax-gdb.h: Sort headers.
7557         * ax-gdb.c: Sort headers.
7558         * avr-tdep.c: Sort headers.
7559         * auxv.c: Sort headers.
7560         * auto-load.c: Sort headers.
7561         * arm-wince-tdep.c: Sort headers.
7562         * arm-tdep.c: Sort headers.
7563         * arm-symbian-tdep.c: Sort headers.
7564         * arm-pikeos-tdep.c: Sort headers.
7565         * arm-obsd-tdep.c: Sort headers.
7566         * arm-nbsd-tdep.c: Sort headers.
7567         * arm-nbsd-nat.c: Sort headers.
7568         * arm-linux-tdep.c: Sort headers.
7569         * arm-linux-nat.c: Sort headers.
7570         * arm-fbsd-tdep.c: Sort headers.
7571         * arm-fbsd-nat.c: Sort headers.
7572         * arm-bsd-tdep.c: Sort headers.
7573         * arch-utils.c: Sort headers.
7574         * arc-tdep.c: Sort headers.
7575         * arc-newlib-tdep.c: Sort headers.
7576         * annotate.h: Sort headers.
7577         * annotate.c: Sort headers.
7578         * amd64-windows-tdep.c: Sort headers.
7579         * amd64-windows-nat.c: Sort headers.
7580         * amd64-tdep.c: Sort headers.
7581         * amd64-sol2-tdep.c: Sort headers.
7582         * amd64-obsd-tdep.c: Sort headers.
7583         * amd64-obsd-nat.c: Sort headers.
7584         * amd64-nbsd-tdep.c: Sort headers.
7585         * amd64-nbsd-nat.c: Sort headers.
7586         * amd64-nat.c: Sort headers.
7587         * amd64-linux-tdep.c: Sort headers.
7588         * amd64-linux-nat.c: Sort headers.
7589         * amd64-fbsd-tdep.c: Sort headers.
7590         * amd64-fbsd-nat.c: Sort headers.
7591         * amd64-dicos-tdep.c: Sort headers.
7592         * amd64-darwin-tdep.c: Sort headers.
7593         * amd64-bsd-nat.c: Sort headers.
7594         * alpha-tdep.c: Sort headers.
7595         * alpha-obsd-tdep.c: Sort headers.
7596         * alpha-nbsd-tdep.c: Sort headers.
7597         * alpha-mdebug-tdep.c: Sort headers.
7598         * alpha-linux-tdep.c: Sort headers.
7599         * alpha-linux-nat.c: Sort headers.
7600         * alpha-bsd-tdep.c: Sort headers.
7601         * alpha-bsd-nat.c: Sort headers.
7602         * aix-thread.c: Sort headers.
7603         * agent.c: Sort headers.
7604         * addrmap.c: Sort headers.
7605         * ada-varobj.c: Sort headers.
7606         * ada-valprint.c: Sort headers.
7607         * ada-typeprint.c: Sort headers.
7608         * ada-tasks.c: Sort headers.
7609         * ada-lang.c: Sort headers.
7610         * aarch64-tdep.c: Sort headers.
7611         * aarch64-ravenscar-thread.c: Sort headers.
7612         * aarch64-newlib-tdep.c: Sort headers.
7613         * aarch64-linux-tdep.c: Sort headers.
7614         * aarch64-linux-nat.c: Sort headers.
7615         * aarch64-fbsd-tdep.c: Sort headers.
7616         * aarch64-fbsd-nat.c: Sort headers.
7617         * aarch32-linux-nat.c: Sort headers.
7618
7619 2019-04-04  Tom Tromey  <tom@tromey.com>
7620
7621         * varobj.c (varobj_create): Update.
7622         * rust-exp.y (struct rust_parser) <update_innermost_block,
7623         lookup_symbol>: New methods.
7624         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7625         Rename.
7626         (rust_parser::rust_lookup_type)
7627         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7628         * printcmd.c (display_command, do_one_display): Update.
7629         * parser-defs.h (struct parser_state) <parser_state>: Add
7630         "tracker" parameter.
7631         (block_tracker): New member.
7632         (class innermost_block_tracker) <innermost_block_tracker>: Add
7633         "types" parameter.
7634         <reset>: Remove method.
7635         (innermost_block): Don't declare.
7636         (null_post_parser): Update.
7637         * parse.c (innermost_block): Remove global.
7638         (write_dollar_variable): Update.
7639         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7640         Remove "tracker_types" parameter.
7641         (parse_expression): Add "tracker" parameter.
7642         (parse_expression_for_completion): Update.
7643         (null_post_parser): Add "tracker" parameter.
7644         * p-exp.y: Update rules.
7645         * m2-exp.y: Update rules.
7646         * language.h (struct language_defn) <la_post_parser>: Add
7647         "tracker" parameter.
7648         * go-exp.y: Update rules.
7649         * f-exp.y: Update rules.
7650         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7651         parameter.
7652         * d-exp.y: Update rules.
7653         * c-exp.y: Update rules.
7654         * breakpoint.c (set_breakpoint_condition): Create an
7655         innermost_block_tracker.
7656         (watch_command_1): Likewise.
7657         * ada-lang.c (resolve): Add "tracker" parameter.
7658         (resolve_subexp): Likewise.
7659         * ada-exp.y (write_var_from_sym): Update.
7660
7661 2019-04-04  Tom Tromey  <tom@tromey.com>
7662
7663         * type-stack.h: New file.
7664         * type-stack.c: New file.
7665         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7666         type-stack.h.
7667         (insert_into_type_stack, insert_type, push_type, push_type_int)
7668         (insert_type_address_space, pop_type, pop_type_int)
7669         (pop_typelist, pop_type_stack, append_type_stack)
7670         (push_type_stack, get_type_stack, push_typelist)
7671         (follow_type_instance_flags, follow_types): Don't declare.
7672         * parse.c (type_stack): Remove global.
7673         (parse_exp_in_context): Update.
7674         (insert_into_type_stack, insert_type, push_type, push_type_int)
7675         (insert_type_address_space, pop_type, pop_type_int)
7676         (pop_typelist, pop_type_stack, append_type_stack)
7677         (push_type_stack, get_type_stack, push_typelist)
7678         (follow_type_instance_flags, follow_types): Remove (moved to
7679         type-stack.c).
7680         * f-exp.y (type_stack): New global.
7681         Update rules.
7682         (push_kind_type, f_parse): Update.
7683         * d-exp.y (type_stack): New global.
7684         Update rules.
7685         (d_parse): Update.
7686         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7687         Update rules.
7688         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7689         (HFILES_NO_SRCDIR): Add type-stack.h.
7690
7691 2019-04-04  Tom Tromey  <tom@tromey.com>
7692
7693         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7694         (rust_parser::convert_ast_to_expression, rust_parse)
7695         (rust_lex_test_completion, rust_lex_tests): Update.
7696         * parser-defs.h (struct expr_completion_state): New.
7697         (struct parser_state) <parser_state>: Add completion parameter.
7698         <mark_struct_expression, mark_completion_tag>: New methods.
7699         <parse_completion, m_completion_state>: New members.
7700         (prefixify_expression, null_post_parser): Update.
7701         (mark_struct_expression, mark_completion_tag): Don't declare.
7702         * parse.c (parse_completion, expout_last_struct)
7703         (expout_tag_completion_type, expout_completion_name): Remove
7704         globals.
7705         (parser_state::mark_struct_expression)
7706         (parser_state::mark_completion_tag): Now methods.
7707         (prefixify_expression): Add last_struct parameter.
7708         (prefixify_subexp): Likewise.
7709         (parse_exp_1): Update.
7710         (parse_exp_in_context): Add cstate parameter.  Update.
7711         (parse_expression_for_completion): Create an
7712         expr_completion_state.
7713         (null_post_parser): Add "completion" parameter.
7714         * p-exp.y: Update rules.
7715         (yylex): Update.
7716         * language.h (struct language_defn) <la_post_parser>: Add
7717         "completing" parameter.
7718         * go-exp.y: Update rules.
7719         (lex_one_token): Update.
7720         * expression.h (parse_completion): Don't declare.
7721         * d-exp.y: Update rules.
7722         (lex_one_token): Update rules.
7723         * c-exp.y: Update rules.
7724         (lex_one_token): Update.
7725         * ada-lang.c (resolve): Add "parse_completion" parameter.
7726         (resolve_subexp): Likewise.
7727         (ada_resolve_function): Likewise.
7728
7729 2019-04-04  Tom Tromey  <tom@tromey.com>
7730
7731         * parser-defs.h (struct parser_state) <start_arglist,
7732         end_arglist>: New methods.
7733         <arglist_len, m_funcall_chain>: New members.
7734         (arglist_len, start_arglist, end_arglist): Don't declare.
7735         * parse.c (arglist_len, funcall_chain): Remove global.
7736         (start_arglist, end_arglist): Remove functions.
7737         (parse_exp_in_context): Update.
7738         * p-exp.y: Update rules.
7739         * m2-exp.y: Update rules.
7740         * go-exp.y: Update rules.
7741         * f-exp.y: Update rules.
7742         * d-exp.y: Update rules.
7743         * c-exp.y: Update rules.
7744
7745 2019-04-04  Tom Tromey  <tom@tromey.com>
7746
7747         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7748         lex_operator, push_back>: New methods.
7749         Update all rules.
7750         (rust_parser::lex_hex, lex_escape): Rename and update.
7751         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7752         (rust_parser::lex_operator): Rename and update.
7753         (rust_parser::lex_number, rustyylex, rustyyerror)
7754         (rust_lex_test_init, rust_lex_test_sequence)
7755         (rust_lex_test_push_back, rust_lex_tests): Update.
7756         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7757         parameter.
7758         <lexptr, prev_lexptr>: New members.
7759         (lexptr, prev_lexptr): Don't declare.
7760         * parse.c (lexptr, prev_lexptr): Remove globals.
7761         (parse_exp_in_context): Update.
7762         * p-exp.y (yylex, yyerror): Update.
7763         * m2-exp.y (parse_number, yylex, yyerror): Update.
7764         * go-exp.y (lex_one_token, yyerror): Update.
7765         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7766         * d-exp.y (lex_one_token, yyerror): Update.
7767         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7768         (lex_one_token, yyerror): Update.
7769         * ada-lex.l (YY_INPUT): Update.
7770         (rewind_to_char): Update.
7771         * ada-exp.y (yyerror): Update.
7772
7773 2019-04-04  Tom Tromey  <tom@tromey.com>
7774
7775         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7776         * parser-defs.h (struct parser_state) <parser_state>: Add new
7777         parameter.
7778         <comma_terminates>: New member.
7779         (comma_terminates): Don't declare global.
7780         * parse.c (comma_terminates): Remove global.
7781         (parse_exp_in_context): Update.
7782         * p-exp.y (yylex): Update.
7783         * m2-exp.y (yylex): Update.
7784         * go-exp.y (lex_one_token): Update.
7785         * f-exp.y (yylex): Update.
7786         * d-exp.y (lex_one_token): Update.
7787         * c-exp.y (lex_one_token): Update.
7788         * ada-lex.l: Update.
7789
7790 2019-04-04  Tom Tromey  <tom@tromey.com>
7791
7792         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7793         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7794         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7795         * parser-defs.h (paren_depth): Don't declare.
7796         * parse.c (paren_depth): Remove global.
7797         (parse_exp_in_context): Update.
7798         * p-exp.y (paren_depth): New global.
7799         (pascal_parse): Initialize it.
7800         * m2-exp.y (paren_depth): New global.
7801         (m2_parse): Initialize it.
7802         * go-exp.y (paren_depth): New global.
7803         (go_parse): Initialize it.
7804         * f-exp.y (paren_depth): New global.
7805         (f_parse): Initialize it.
7806         * d-exp.y (paren_depth): New global.
7807         (d_parse): Initialize it.
7808         * c-exp.y (paren_depth): New global.
7809         (c_parse): Initialize it.
7810         * ada-lex.l (paren_depth): New global.
7811         (lexer_init): Initialize it.
7812
7813 2019-04-04  Tom Tromey  <tom@tromey.com>
7814
7815         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7816         (rust_parser::convert_ast_to_type)
7817         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7818         * parser-defs.h (struct parser_state) <parser_state>: Add
7819         parameters.  Initialize new members.
7820         <expression_context_block, expression_context_pc>: New members.
7821         * parse.c (expression_context_block, expression_context_pc):
7822         Remove globals.
7823         (parse_exp_in_context): Update.
7824         * p-exp.y: Update all rules.
7825         (yylex): Update.
7826         * m2-exp.y: Update all rules.
7827         (yylex): Update.
7828         * go-exp.y (yylex): Update.
7829         * f-exp.y (yylex): Update.
7830         * d-exp.y: Update all rules.
7831         (yylex): Update.
7832         * c-exp.y: Update all rules.
7833         (lex_one_token, classify_name, yylex, c_parse): Update.
7834         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7835
7836 2019-04-04  Tom Tromey  <tom@tromey.com>
7837
7838         * gdbarch.h, gdbarch.c: Rebuild.
7839         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7840         * stap-probe.h:
7841         (struct stap_parse_info): Replace "parser_state" with
7842         "expr_builder".
7843         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7844         (parser_state): New class.
7845         * parse.c (expr_builder): Rename.
7846         (expr_builder::release): Rename.
7847         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7848         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7849         (write_exp_elt_longcst, write_exp_elt_floatcst)
7850         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7851         (write_exp_string_vector, write_exp_bitstring)
7852         (write_exp_msymbol, mark_struct_expression)
7853         (write_dollar_variable)
7854         (insert_type_address_space, increase_expout_size): Replace
7855         "parser_state" with "expr_builder".
7856         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7857         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7858         "parser_state" with "expr_builder".
7859
7860 2019-04-04  Tom Tromey  <tom@tromey.com>
7861
7862         * rust-exp.y: Replace "parse_language" with method call.
7863         * p-exp.y:
7864         (yylex): Replace "parse_language" with method call.
7865         * m2-exp.y:
7866         (yylex): Replace "parse_language" with method call.
7867         * go-exp.y (classify_name): Replace "parse_language" with method
7868         call.
7869         * f-exp.y (yylex): Replace "parse_language" with method call.
7870         * d-exp.y (lex_one_token): Replace "parse_language" with method
7871         call.
7872         * c-exp.y:
7873         (lex_one_token, classify_name, yylex): Replace "parse_language"
7874         with method call.
7875         * ada-exp.y (find_primitive_type, type_char)
7876         (type_system_address): Replace "parse_language" with method call.
7877
7878 2019-04-04  Tom Tromey  <tom@tromey.com>
7879
7880         * rust-exp.y: Replace "parse_gdbarch" with method call.
7881         * parse.c (write_dollar_variable, insert_type_address_space):
7882         Replace "parse_gdbarch" with method call.
7883         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7884         call.
7885         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7886         call.
7887         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7888         "parse_gdbarch" with method call.
7889         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7890         with method call.
7891         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7892         "parse_gdbarch" with method call.
7893         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7894         "parse_gdbarch" with method call.
7895         * c-exp.y (parse_type, parse_number, classify_name): Replace
7896         "parse_gdbarch" with method call.
7897         * ada-lex.l: Replace "parse_gdbarch" with method call.
7898         * ada-exp.y (parse_type, find_primitive_type, type_char)
7899         (type_system_address): Replace "parse_gdbarch" with method call.
7900
7901 2019-04-04  Tom Tromey  <tom@tromey.com>
7902
7903         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7904         * stap-probe.c (stap_parse_argument): Update.
7905         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7906         initial_size parameter.
7907         * rust-exp.y (rust_lex_tests): Update.
7908         * parse.c (parser_state): Update.
7909         (parse_exp_in_context): Update.
7910         * parser-defs.h (struct parser_state) <parser_state>: Remove
7911         "initial_size" parameter.
7912
7913 2019-04-04  Tom Tromey  <tom@tromey.com>
7914
7915         * parser-defs.h (increase_expout_size): Don't declare.
7916         * parse.c (increase_expout_size): Now static.
7917
7918 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7919
7920         * gnu-nat.c (gnu_nat_target::wait): Fix
7921         target_waitstatus_to_string call.
7922
7923 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7924
7925         * eval.c (evaluate_subexp_standard): Handle internal functions
7926         during Fortran function call handling.
7927
7928 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7929
7930         * NEWS: Mention new internal functions.
7931         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7932         (read_base_type): Use dwarf2_init_complex_target_type.
7933         * value.c (creal_internal_fn): New function.
7934         (cimag_internal_fn): New function.
7935         (_initialize_values): Register new internal functions.
7936
7937 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7938
7939         * infrun.c (stop_all_threads): If debug_infrun, always
7940         trace the wait status after wait_one, using
7941         target_waitstatus_to_string and target_pid_to_str.
7942         (handle_inferior_event): Replace various trace of
7943         wait status kind by a single trace.
7944         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7945         wait status kind image by target_waitstatus_to_string.
7946         * target/waitstatus.c (target_waitstatus_to_string): Fix
7947         obsolete comment.
7948
7949 2019-04-01  Tom Tromey  <tromey@adacore.com>
7950
7951         PR symtab/23331:
7952         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7953
7954 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7955             Pedro Alves  <palves@redhat.com>
7956
7957         * top.c (quit_force): Call 'finalize_values'.
7958         * value.c (finalize_values): New function.
7959         * value.h (finalize_values): Declare.
7960
7961 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7962
7963         * NEWS: Announce $_gdb_major and $_gdb_minor.
7964
7965         * top.c (init_gdb_version_vars): New function.
7966         (gdb_init): Call init_gdb_version_vars.
7967
7968 2019-03-29  Tom Tromey  <tromey@adacore.com>
7969
7970         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7971         help text.  Remove dead code.
7972
7973 2019-03-29  Keith Seitz  <keiths@redhat.com>
7974
7975         From Siddhesh Poyarekar:
7976         * f-lang.h (f77_get_upperbound): Return LONGEST.
7977         (f77_get_lowerbound): Likewise.
7978         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7979         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7980         print them.
7981         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7982         plongest to format print it.
7983         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7984         (f77_get_upperbound): Likewise.
7985         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7986         LOWER_BOUND to LONGEST.
7987         (f77_create_arrayprint_offset_tbl): Likewise.
7988
7989 2019-03-29  Keith Seitz  <keiths@redhat.com>
7990
7991         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7992         %s/pulongest for TYPE_LENGTH instead of %d in format
7993         strings.
7994         * ada-typerint.c (ada_print_type): Likewise.
7995         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7996         * compile/compile-c-support.c (generate_register_struct): Likewise.
7997         * gdbtypes.c (recursive_dump_type): Likewise.
7998         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7999         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8000         instead of %d in format strings.
8001         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8002         to std::min to ULONGEST.
8003         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8004         instead of %d in format strings.
8005         * tracepoint.c (info_scope_command): Likewise.
8006         * typeprint.c (print_offset_data::update)
8007         (print_offset_data::finish): Likewise.
8008         * xtensa-tdep.c (xtensa_store_return_value)
8009         (xtensa_push_dummy_call): Likewise.
8010
8011 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8012
8013         * windows-nat.c (display_selector): Fixed format specifications
8014         for 64-bit Cygwin.
8015
8016 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8017
8018         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8019
8020 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8021
8022         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8023         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8024         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8025         (nios2_linux_init_abi): Install it.
8026
8027 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8028
8029         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8030
8031 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8032
8033         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8034
8035 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8036             Tom Tromey  <tromey@adacore.com>
8037
8038         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8039
8040 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8041
8042         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8043         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8044         method to compute the bounds of range types. Also print "[evaluated]"
8045         if the bounds' values come from a dynamic evaluation.
8046
8047 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8048
8049         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8050         whitespace when pretty printing is on.
8051
8052 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8053
8054         * ppc-linux-nat.c: Add include.
8055
8056 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8057
8058         * NEWS: Mention AArch64 Pointer Authentication.
8059
8060 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8061
8062         * arm-linux-nat.c: Add include.
8063
8064 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8065
8066         * source-cache.c (source_cache::get_source_lines): Re-read
8067         fullname after calling open_source_file.
8068
8069 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8070
8071         * NEWS: Mention TLS support for FreeBSD.
8072
8073 2019-03-25  Tom Tromey  <tromey@adacore.com>
8074
8075         * minsyms.c (BUNCH_SIZE): Update comment.
8076         (~minimal_symbol_reader): Remove old comment.
8077         (compact_minimal_symbols): Update comment.
8078         (minimal_symbol_reader::install): Remove old comment.  Update
8079         other comments.
8080
8081 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8082
8083         * s390-linux-nat.c: Add include.
8084
8085 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8086
8087         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8088         Call linux_get_hwcap.
8089         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8090         Likewise.
8091         (aarch64_linux_get_hwcap): Remove function.
8092         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8093         declaration.
8094         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8095         linux_get_hwcap.
8096         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8097         * linux-tdep.c (linux_get_hwcap): Add function.
8098         (linux_get_hwcap2): Likewise.
8099         * linux-tdep.h (linux_get_hwcap): Add declaration.
8100         (linux_get_hwcap2): Likewise.
8101         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8102         (ppc_linux_get_hwcap2): Likewise.
8103         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8104         linux_get_hwcap.
8105         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8106         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8107         (ppc_linux_nat_target::read_description): Likewise.
8108         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8109         * s390-linux-nat.c: Likewise.
8110         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8111
8112 2019-03-24  Tom Tromey  <tom@tromey.com>
8113
8114         * ada-lang.c (standard_lookup): Simplify initialization.
8115         (ada_lookup_symbol_nonlocal): Simplify return.
8116         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8117         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8118         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8119         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8120         initialization.
8121         * solib.c (solib_global_lookup): Simplify.
8122         * symtab.c (null_block_symbol): Remove.
8123         (symbol_cache_lookup): Simplify returns.
8124         (lookup_language_this): Simplify returns.
8125         (lookup_symbol_aux): Simplify return.
8126         (lookup_local_symbol): Simplify returns.
8127         (lookup_global_symbol_from_objfile): Simplify return.
8128         (lookup_symbol_in_objfile_symtabs)
8129         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8130         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8131         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8132         * cp-namespace.c (cp_lookup_bare_symbol)
8133         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8134         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8135         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8136         (cp_lookup_symbol_via_imports): Simplify initialization.
8137         (find_symbol_in_baseclass): Likewise.
8138         * symtab.h (null_block_symbol): Remove.
8139         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8140         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8141         (d_lookup_symbol_module): Likewise.
8142         (find_symbol_in_baseclass): Simplify initialization.
8143
8144 2019-03-24  Tom Tromey  <tom@tromey.com>
8145
8146         * expression.h: Don't include symtab.h.
8147         (struct block): Forward declare.
8148
8149 2019-03-24  Tom Tromey  <tom@tromey.com>
8150
8151         * c-exp.y (typebase): Remove casts.
8152         * gdbtypes.c (lookup_unsigned_typename, )
8153         (lookup_signed_typename): Remove cast.
8154         * eval.c (parse_to_comma_and_eval): Remove cast.
8155         * parse.c (write_dollar_variable): Remove cast.
8156         * block.h (struct block) <superblock>: Now const.
8157         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8158         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8159         (map_block): Make "block" const.
8160         * symfile.h (struct quick_symbol_functions)
8161         <map_matching_symbols>: Constify block argument to "callback".
8162         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8163         const.
8164         (find_pc_sect_compunit_symtab): Make "b" const.
8165         (find_symbol_at_address): Likewise.
8166         (search_symbols): Likewise.
8167         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8168         (dw2_debug_names_lookup_symbol): Likewise.
8169         (dw2_map_matching_symbols): Update.
8170         * p-valprint.c (pascal_val_print): Remove "block".
8171         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8172         (aux_add_nonlocal_symbols): Make "block" const.
8173         (resolve_subexp): Remove cast.
8174         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8175         const.
8176         (iterate_over_file_blocks): Likewise.
8177         * f-exp.y (%union) <bval>: Remove.
8178         * coffread.c (patch_opaque_types): Make "b" const.
8179         * spu-tdep.c (spu_catch_start): Make "block" const.
8180         * c-valprint.c (print_unpacked_pointer): Remove "block".
8181         * symmisc.c (dump_symtab_1): Make "b" const.
8182         (block_depth): Make "block" const.
8183         * d-exp.y (%union) <bval>: Remove.
8184         * cp-support.h (cp_lookup_rtti_type): Update.
8185         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8186         * psymtab.c (psym_lookup_symbol): Make "block" const.
8187         (maintenance_check_psymtabs): Make "b" const.
8188         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8189         (enumerate_locals, enumerate_args): Update.
8190         * python/py-symtab.c (stpy_global_block): Make "block" const.
8191         (stpy_static_block): Likewise.
8192         * inline-frame.c (block_starting_point_at): Make "new_block"
8193         const.
8194         * block.c (find_block_in_blockvector): Make return type const.
8195         (blockvector_for_pc_sect): Make "b" const.
8196         (find_block_in_blockvector): Make "b" const.
8197
8198 2019-03-23  Tom Tromey  <tom@tromey.com>
8199
8200         * varobj.c (varobj_create): Update.
8201         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8202         * printcmd.c (display_command, do_one_display): Don't reset
8203         innermost_block.
8204         * parser-defs.h (enum innermost_block_tracker_type): Move to
8205         expression.h.
8206         (innermost_block): Update comment.
8207         * parse.c (parse_exp_1): Add tracker_types parameter.
8208         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8209         tracker_types parameter.  Reset innermost_block.
8210         (parse_exp_in_context): Remove.
8211         (parse_expression_for_completion): Update.
8212         * objfiles.c (~objfile): Don't reset expression_context_block or
8213         innermost_block.
8214         * expression.h (enum innermost_block_tracker_type): Move from
8215         parser-defs.h.
8216         (parse_exp_1): Add tracker_types parameter.
8217         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8218         reset innermost_block.
8219
8220 2019-03-23  Tom Tromey  <tom@tromey.com>
8221
8222         * objfiles.h: Include bcache.h.
8223
8224 2019-03-23  Tom Tromey  <tom@tromey.com>
8225
8226         * linespec.c (get_current_search_block): Use
8227         scoped_restore_current_language.
8228         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8229
8230 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8231             Jiong Wang  <jiong.wang@arm.com>
8232
8233         * aarch64-linux-tdep.c
8234         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8235         section.
8236         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8237
8238 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8239             Jiong Wang  <jiong.wang@arm.com>
8240
8241         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8242         instructions.
8243         (aarch64_analyze_prologue_test): Add PACIASP test.
8244         (aarch64_prologue_prev_register): Unmask PC value.
8245
8246 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8247             Jiong Wang  <jiong.wang@arm.com>
8248
8249         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8250         (aarch64_dwarf2_prev_register): Unmask PC value.
8251         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8252         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8253         DW_CFA_AARCH64_negate_ra_state.
8254         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8255
8256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8257             Jiong Wang  <jiong.wang@arm.com>
8258
8259         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8260         registers.
8261         (aarch64_pseudo_register_name): Likewise.
8262         (aarch64_pseudo_register_type): Likewise.
8263         (aarch64_pseudo_register_reggroup_p): Likewise.
8264         (aarch64_gdbarch_init): Add pauth registers.
8265         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8266         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8267         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8268         (struct gdbarch_tdep): Add regnum for ra_state.
8269
8270 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8271             Jiong Wang  <jiong.wang@arm.com>
8272
8273         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8274
8275 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8276             Jiong Wang  <jiong.wang@arm.com>
8277
8278         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8279         function.
8280         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8281         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8282         (aarch64_gdbarch_init): Add puth registers.
8283         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8284         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8285         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8286
8287 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8288             Jiong Wang  <jiong.wang@arm.com>
8289
8290         * aarch64-linux-nat.c
8291         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8292         * aarch64-linux-tdep.c
8293         (aarch64_linux_core_read_description): Likewise.
8294         (aarch64_linux_get_hwcap): New function.
8295         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8296         (aarch64_linux_get_hwcap): New declaration.
8297
8298 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8299             Jiong Wang  <jiong.wang@arm.com>
8300
8301         * aarch64-linux-nat.c
8302         (aarch64_linux_nat_target::read_description): Add pauth param.
8303         * aarch64-linux-tdep.c
8304         (aarch64_linux_core_read_description): Likewise.
8305         * aarch64-tdep.c (struct target_desc): Add in pauth.
8306         (aarch64_read_description): Add pauth param.
8307         (aarch64_gdbarch_init): Likewise.
8308         * aarch64-tdep.h (aarch64_read_description): Likewise.
8309         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8310         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8311         * features/Makefile: Add new files.
8312         * features/aarch64-pauth.c: New file.
8313         * features/aarch64-pauth.xml: New file.
8314
8315 2019-03-20  Tom Tromey  <tromey@adacore.com>
8316
8317         * infrun.c (handle_inferior_event): Rename from
8318         handle_inferior_event_1.  Create a scoped_value_mark.
8319         (handle_inferior_event): Remove.
8320
8321 2019-03-19  Tom Tromey  <tromey@adacore.com>
8322
8323         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8324         * infrun.h (print_stop_event): Add "displays" parameter.
8325         * infrun.c (print_stop_event): Add "displays" parameter.
8326
8327 2019-03-19  Pedro Alves  <palves@redhat.com>
8328
8329         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8330         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8331         to -1.  Fix TABs vs spaces.
8332         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8333         * tui/tui-out.h (tui_ui_out) Add intro comments.
8334         <m_line, m_start_of_line>: In-class initialize, and add describing
8335         comment.
8336
8337 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8338
8339         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8340         variable names.
8341         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8342
8343 2019-03-18  Pedro Alves  <palves@redhat.com>
8344             Eli Zaretskii <eliz@gnu.org>
8345
8346         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8347         m_line and m_start_of_line.
8348
8349 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8350
8351         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8352         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8353         it returns a newline.  This fixes a regression in TU mode, whereby
8354         the next line is output on the same screen line as the user input.
8355
8356 2019-03-18  Tom Tromey  <tromey@adacore.com>
8357
8358         * minsyms.c (minimal_symbol_reader::install): Remove call to
8359         obstack_blank.
8360
8361 2019-03-18  Pedro Alves  <palves@redhat.com>
8362
8363         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8364         New globals.
8365         (apply_style): New, factored out from ...
8366         (apply_ansi_escape): ... this.  Handle reverse video mode.
8367         (tui_set_reverse_mode): New function.
8368         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8369         * tui/tui-winsource.c (tui_show_source_line): Use
8370         tui_set_reverse_mode instead of setting A_STANDOUT.
8371         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8372         New setter methods.
8373
8374 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8375
8376         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8377         Handle tabs.
8378
8379 2019-03-18  Tom Tromey  <tromey@adacore.com>
8380
8381         * ada-lang.c (empty_array): Add "high" parameter.
8382         (ada_evaluate_subexp): Update.
8383
8384 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8385
8386         * unittests/string_view-selftests.c: Define
8387         _initialize_string_view_selftests unconditionally.
8388
8389 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8390
8391         PR gdb/24350
8392         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8393
8394 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8395
8396         PR gdb/24351
8397         * windows-nat.c (display_selector): Fix format specifiers.
8398
8399 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8400
8401         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8402         tui_refill_source_window instead of tui_refresh_win, to update the
8403         current execution line.  This fixes redisplay of the current line
8404         when stepping through the code with "next" or "step".
8405
8406 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8407
8408         * source-cache.c (source_cache::get_source_lines): Call
8409         find_source_lines to initialize s->nlines.  This fixes vertical
8410         scrolling of TUI source window when the DOWN arrow is pressed.
8411
8412 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8413
8414         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8415         linux-thread-db.c (_initialize_thread_db): Likewise.
8416
8417 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8418
8419         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8420         wclrtoeol in tui_show_source_line".  This reverts changes made in
8421         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8422
8423 2019-03-15  Tom Tromey  <tom@tromey.com>
8424
8425         * symtab.h (struct minimal_symbol): Derive from
8426         general_symbol_info.
8427         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8428         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8429         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8430         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8431         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8432         (MSYMBOL_SEARCH_NAME): Update.
8433         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8434         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8435         * minsyms.c (minimal_symbol_reader::record_full): Update.
8436
8437 2019-03-15  Tom Tromey  <tom@tromey.com>
8438
8439         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8440
8441 2019-03-15  Tom Tromey  <tom@tromey.com>
8442
8443         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8444         unique_xmalloc_ptr.
8445         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8446         Update.
8447         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8448         (build_minimal_symbol_hash_tables)
8449         (minimal_symbol_reader::install): Update.
8450
8451 2019-03-15  Tom Tromey  <tom@tromey.com>
8452
8453         * symtab.c (create_demangled_names_hash): Update.
8454         (symbol_set_names): Update.
8455         * objfiles.h (struct objfile_per_bfd_storage)
8456         <demangled_names_hash>: Now an htab_up.
8457         * objfiles.c (objfile_per_bfd_storage): Simplify.
8458
8459 2019-03-15  Tom Tromey  <tom@tromey.com>
8460
8461         * objfiles.h (struct objfile_per_bfd_storage): Declare
8462         destructor.
8463         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8464         New.
8465         (get_objfile_bfd_data): Use new.  Don't initialize
8466         language_of_main.
8467         (free_objfile_per_bfd_storage): Remove.
8468         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8469
8470 2019-03-15  Tom Tromey  <tom@tromey.com>
8471
8472         * symfile.c (reread_symbols): Update.
8473         * objfiles.c (objfile::objfile): Update.
8474         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8475         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8476         comment.
8477         (minimal_symbol_reader::install): Update.
8478         (terminate_minimal_symbol_table): Remove.
8479         * jit.c (jit_object_close_impl): Update.
8480
8481 2019-03-15  Tom Tromey  <tom@tromey.com>
8482
8483         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8484         initializations.
8485
8486 2019-03-15  Tom Tromey  <tom@tromey.com>
8487
8488         * objfiles.h (struct objfile_per_bfd_storage)
8489         <demangled_hash_languages>: Now a bitset.
8490         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8491         (lookup_minimal_symbol): Update.
8492
8493 2019-03-15  Tom Tromey  <tom@tromey.com>
8494
8495         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8496         Don't return the symbol.
8497         * coffread.c (record_minimal_symbol): Use record_full.
8498
8499 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8500
8501         The MS-Windows port of ncurses fails to switch to a color pair if
8502         one or both of the colors are the implicit default colors.  This
8503         change records the default colors when TUI is initialized, and
8504         then specifies them explicitly when a color pair uses the default
8505         colors.  This allows color styling in TUI mode on MS-Windows.
8506
8507         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8508         ncurses_norm_attr.
8509         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8510         colors in ncurses_norm_attr.
8511         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8512         "none", replace it with the default color recorded in
8513         ncurses_norm_attr.
8514
8515 2019-03-14  Tom Tromey  <tromey@adacore.com>
8516
8517         * source-cache.h (class source_cache) <get_source_lines>: Return
8518         std::string.
8519         * source-cache.c (source_cache::extract_lines): Handle case where
8520         first_pos==npos.  Return std::string.
8521         (source_cache::get_source_lines): Update.
8522
8523 2019-03-14  Tom Tromey  <tromey@adacore.com>
8524
8525         * NEWS: Add item for "style sources" commands.
8526         * source-cache.c (source_cache::get_source_lines): Check
8527         source_styling.
8528         * cli/cli-style.c (source_styling): New global.
8529         (_initialize_cli_style): Add "style sources" commands.
8530         (show_style_sources): New function.
8531         * cli/cli-style.h (source_styling): Declare.
8532
8533 2019-03-14  Pedro Alves  <palves@redhat.com>
8534             Tom Tromey  <tromey@adacore.com>
8535
8536         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8537         * tui/tui-winsource.c (tui_refill_source_window): New function,
8538         from...
8539         (tui_horizontal_source_scroll): ... here.  Move some logic.
8540         * cli/cli-style.c (set_style_enabled): Notify new observable.
8541         * tui/tui-hooks.c (tui_redisplay_source): New function.
8542         (tui_attach_detach_observers): Attach or detach
8543         tui_redisplay_source.
8544         * observable.h (source_styling_changed): New observable.
8545         * observable.c: Define source_styling_changed observable.
8546
8547 2019-03-13  Tom Tromey  <tromey@adacore.com>
8548
8549         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8550         (i386_gnu_nat_target::store_registers): Update.
8551         * target-debug.h (target_debug_print_std_string): New macro.
8552         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8553         * windows-tdep.c (display_one_tib): Update.
8554         * tui/tui-stack.c (tui_make_status_line): Update.
8555         * top.c (print_inferior_quit_action): Update.
8556         * thread.c (thr_try_catch_cmd): Update.
8557         (add_thread_with_info): Update.
8558         (thread_target_id_str): Update.
8559         (thr_try_catch_cmd): Update.
8560         (thread_command): Update.
8561         (thread_find_command): Update.
8562         * record-btrace.c (record_btrace_target::info_record)
8563         (record_btrace_resume_thread, record_btrace_target::resume)
8564         (record_btrace_cancel_resume, record_btrace_step_thread)
8565         (record_btrace_target::wait, record_btrace_target::wait)
8566         (record_btrace_target::wait, record_btrace_target::stop): Update.
8567         * progspace.c (print_program_space): Update.
8568         * process-stratum-target.c
8569         (process_stratum_target::thread_address_space): Update.
8570         * linux-fork.c (linux_fork_mourn_inferior)
8571         (detach_checkpoint_command, info_checkpoints_command)
8572         (linux_fork_context): Update.
8573         (linux_fork_detach): Update.
8574         (class scoped_switch_fork_info): Update.
8575         (delete_checkpoint_command): Update.
8576         * infrun.c (follow_fork_inferior): Update.
8577         (follow_fork_inferior): Update.
8578         (proceed_after_vfork_done): Update.
8579         (handle_vfork_child_exec_or_exit): Update.
8580         (follow_exec): Update.
8581         (displaced_step_prepare_throw): Update.
8582         (displaced_step_restore): Update.
8583         (start_step_over): Update.
8584         (resume_1): Update.
8585         (clear_proceed_status_thread): Update.
8586         (proceed): Update.
8587         (print_target_wait_results): Update.
8588         (do_target_wait): Update.
8589         (context_switch): Update.
8590         (stop_all_threads): Update.
8591         (restart_threads): Update.
8592         (finish_step_over): Update.
8593         (handle_signal_stop): Update.
8594         (switch_back_to_stepped_thread): Update.
8595         (keep_going_pass_signal): Update.
8596         (print_exited_reason): Update.
8597         (normal_stop): Update.
8598         * inferior.c (inferior_pid_to_str): Change return type.
8599         (print_selected_inferior): Update.
8600         (add_inferior): Update.
8601         (detach_inferior): Update.
8602         * dummy-frame.c (fprint_dummy_frames): Update.
8603         * dcache.c (dcache_info_1): Update.
8604         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8605         (btrace_fetch, btrace_clear): Update.
8606         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8607         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8608         type.
8609         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8610         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8611         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8612         * gdbarch.c, gdbarch.h: Rebuild.
8613         * gdbarch.sh (core_pid_to_str): Change return type.
8614         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8615         return type.
8616         (windows_nat_target::pid_to_str): Change return type.
8617         (windows_delete_thread): Update.
8618         (windows_nat_target::attach): Update.
8619         (windows_nat_target::files_info): Update.
8620         * target-delegates.c: Rebuild.
8621         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8622         return type.
8623         (sol_thread_target::pid_to_str): Change return type.
8624         * remote.c (class remote_target) <pid_to_str>: Change return
8625         type.
8626         (remote_target::pid_to_str): Change return type.
8627         (extended_remote_target::attach, remote_target::remote_stop_ns)
8628         (remote_target::remote_notif_remove_queued_reply)
8629         (remote_target::push_stop_reply, remote_target::disable_btrace):
8630         Update.
8631         (extended_remote_target::attach): Update.
8632         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8633         type.
8634         (gdbsim_target::pid_to_str): Change return type.
8635         * ravenscar-thread.c (struct ravenscar_thread_target)
8636         <pid_to_str>: Change return type.
8637         (ravenscar_thread_target::pid_to_str): Change return type.
8638         * procfs.c (class procfs_target) <pid_to_str>: Change return
8639         type.
8640         (procfs_target::pid_to_str): Change return type.
8641         (procfs_target::attach): Update.
8642         (procfs_target::detach): Update.
8643         (procfs_target::fetch_registers): Update.
8644         (procfs_target::store_registers): Update.
8645         (procfs_target::wait): Update.
8646         (procfs_target::files_info): Update.
8647         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8648         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8649         return type.
8650         (nto_procfs_target::pid_to_str): Change return type.
8651         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8652         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8653         return type.
8654         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8655         (exit_lwp): Update.
8656         (attach_proc_task_lwp_callback, get_detach_signal)
8657         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8658         (linux_nat_target::resume, wait_lwp, stop_callback)
8659         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8660         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8661         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8662         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8663         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8664         type.
8665         (inf_ptrace_target::attach): Update.
8666         (inf_ptrace_target::files_info): Update.
8667         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8668         type.
8669         (go32_nat_target::pid_to_str): Change return type.
8670         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8671         (gnu_nat_target::wait): Update.
8672         (gnu_nat_target::wait): Update.
8673         (gnu_nat_target::resume): Update.
8674         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8675         (fbsd_nat_target::wait): Update.
8676         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8677         type.
8678         (darwin_nat_target::attach): Update.
8679         * corelow.c (class core_target) <pid_to_str>: Change return type.
8680         (core_target::pid_to_str): Change return type.
8681         * target.c (normal_pid_to_str): Change return type.
8682         (default_pid_to_str): Likewise.
8683         (target_pid_to_str): Change return type.
8684         (target_translate_tls_address): Update.
8685         (target_announce_detach): Update.
8686         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8687         return type.
8688         (bsd_uthread_target::pid_to_str): Change return type.
8689         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8690         type.
8691         (bsd_kvm_target::pid_to_str): Change return type.
8692         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8693         return type.
8694         (aix_thread_target::pid_to_str): Change return type.
8695         * target.h (struct target_ops) <pid_to_str>: Change return type.
8696         (target_pid_to_str, normal_pid_to_str): Likewise.
8697         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8698         type.
8699         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8700         type.
8701         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8702         return type.
8703         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8704         type.
8705         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8706         type.
8707         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8708         return type.
8709
8710 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8711
8712         * NEWS: Mention that the new default MI version is 3.  Mention
8713         changes to the output of commands and events that deal with
8714         multi-location breakpoints.
8715         * breakpoint.c: Include "mi/mi-out.h".
8716         (print_one_breakpoint): Change output syntax if using MI version
8717         >= 3.
8718         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8719         New.
8720         (mi_multi_location_breakpoint_output_fixed): New.
8721         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8722         (mi_cmd_fix_multi_location_breakpoint_output): New.
8723         (mi_multi_location_breakpoint_output_fixed): New.
8724         * mi/mi-cmds.c (mi_cmds): Register command
8725         -fix-multi-location-breakpoint-output.
8726         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8727         interpreter "mi".
8728
8729 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8730
8731         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8732         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8733         instantiate mi_ui_out based on interpreter name.
8734         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8735         * mi/mi-main.c (mi_load_progress): Likewise.
8736
8737 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8738
8739         * NEWS: Combine separate "New targets" sections for 8.3.
8740
8741 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8742
8743         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8744         (ppcfbsd_init_abi): Install gdbarch
8745         "fetch_tls_load_module_address" and "get_thread_local_address"
8746         methods.
8747
8748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8749
8750         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8751         (riscv_fbsd_init_abi): Install gdbarch
8752         "fetch_tls_load_module_address" and "get_thread_local_address"
8753         methods.
8754
8755 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8756
8757         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8758         (i386fbsd_init_abi): Install gdbarch
8759         "fetch_tls_load_module_address" and "get_thread_local_address"
8760         methods.
8761
8762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8763
8764         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8765         (amd64fbsd_init_abi): Install gdbarch
8766         "fetch_tls_load_module_address" and "get_thread_local_address"
8767         methods.
8768
8769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8770
8771         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8772         (struct fbsd_pspace_data): New type.
8773         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8774         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8775         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8776         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8777         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8778
8779 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8780
8781         * gdbtypes.c (lookup_struct_elt): New function.
8782         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8783         * gdbtypes.h (struct struct_elt): New type.
8784         (lookup_struct_elt): New prototype.
8785
8786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8787
8788         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8789         remove disabled code block.
8790
8791 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8792
8793         * gdbarch.sh (get_thread_local_address): New method.
8794         * gdbarch.h, gdbarch.c: Regenerate.
8795         * target.c (target_translate_tls_address): Use
8796         gdbarch_get_thread_local_address if present instead of
8797         target::get_thread_local_address.
8798
8799 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8800
8801         * target.h (target::get_thread_local_address): Update comment.
8802
8803 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8804
8805         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8806         objfile->separate_debug_objfile_backlink if not NULL.
8807
8808 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8809
8810         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8811         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8812         (amd64bsd_store_inferior_registers): Likewise.
8813         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8814         Enable segment base registers.
8815         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8816         PT_GETFSBASE and PT_GETGSBASE.
8817         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8818         PT_SETGSBASE.
8819         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8820         segment base registers.
8821         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8822
8823 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8824
8825         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8826         Update calls to i386_target_description to add 'segments'
8827         parameter.
8828         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8829         add segment base registers.
8830         * arch/i386.c (i386_create_target_description): Add 'segments'
8831         parameter to enable segment base registers.
8832         * arch/i386.h (i386_create_target_description): Likewise.
8833         * features/i386/32bit-segments.xml: New file.
8834         * features/i386/32bit-segments.c: Generate.
8835         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8836         call to i386_target_description to add 'segments' parameter.
8837         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8838         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8839         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8840         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8841         if feature is present.
8842         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8843         Add 'segments' parameter to call to i386_target_description.
8844         (i386_target_description): Add 'segments' parameter to enable
8845         segment base registers.
8846         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8847         to call to i386_target_description.
8848         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8849         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8850         Define I386_NUM_REGS.
8851         (i386_target_description): Add 'segments' parameter to enable
8852         segment base registers.
8853
8854 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8855
8856         PR/24325
8857         * source-cache.c: #undef open and close, to avoid unresolved
8858         externals during linking.
8859
8860 2019-03-12  Tom Tromey  <tromey@adacore.com>
8861
8862         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8863         const.  Add initializers.
8864         (_initialize_remote): Don't initialize ptid globals.
8865
8866 2019-03-12  Pedro Alves  <palves@redhat.com>
8867
8868         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8869
8870 2019-03-12  Pedro Alves  <palves@redhat.com>
8871
8872         * cp-name-parser.y (main): Remove unused 'len' variable.
8873
8874 2019-03-12  Tom Tromey  <tromey@adacore.com>
8875
8876         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8877         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8878
8879 2019-03-12  Tom Tromey  <tromey@adacore.com>
8880
8881         * linux-nat.c (iterate_over_lwps): Update.
8882         (stop_callback): Remove parameter.
8883         (stop_wait_callback, detach_callback, resume_set_callback)
8884         (select_singlestep_lwp_callback, set_ignore_sigint)
8885         (status_callback, resumed_callback, resume_clear_callback)
8886         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8887         data parameter.
8888         (linux_nat_target::detach, linux_nat_target::resume)
8889         (linux_stop_and_wait_all_lwps, select_event_lwp)
8890         (linux_nat_filter_event, linux_nat_wait_1)
8891         (linux_nat_target::kill, linux_nat_target::stop)
8892         (linux_nat_target::stop): Update.
8893         (linux_nat_resume_callback): Change type.
8894         (resume_stopped_resumed_lwps, count_events_callback)
8895         (select_event_lwp_callback): Likewise.
8896         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8897         * arm-linux-nat.c (struct update_registers_data): Remove.
8898         (update_registers_callback): Change type.
8899         (arm_linux_insert_hw_breakpoint1): Update.
8900         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8901         parameter.
8902         (x86_linux_dr_set_addr): Update.
8903         (x86_linux_dr_set_control): Update.
8904         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8905         (iterate_over_lwps): Use gdb::function_view.
8906         * nat/aarch64-linux-hw-point.c (struct
8907         aarch64_dr_update_callback_param): Remove.
8908         (debug_reg_change_callback): Change type.
8909         (aarch64_notify_debug_reg_change): Update.
8910         * s390-linux-nat.c (s390_refresh_per_info): Update.
8911
8912 2019-03-11  Tom Tromey  <tromey@adacore.com>
8913
8914         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8915         redundant assignment to "this_cu".
8916
8917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8918
8919         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8920
8921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8922
8923         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8924         from...
8925         (rank_one_type): ... this.
8926
8927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8928
8929         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8930         from...
8931         (rank_one_type): ... this.
8932
8933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8934
8935         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8936         from...
8937         (rank_one_type): ... this.
8938
8939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8940
8941         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8942         from...
8943         (rank_one_type): ... this.
8944
8945 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8946
8947         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8948         from...
8949         (rank_one_type): ... this.
8950
8951 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8952
8953         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8954         from...
8955         (rank_one_type): ... this.
8956
8957 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8958
8959         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8960         from...
8961         (rank_one_type): ... this.
8962
8963 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8964
8965         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8966         from...
8967         (rank_one_type): ... this.
8968
8969 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8970
8971         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8972         from...
8973         (rank_one_type): ... this.
8974
8975 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8976
8977         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8978         from...
8979         (rank_one_type): ... this.
8980
8981 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8982
8983         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8984         from...
8985         (rank_one_type): ... this.
8986
8987 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8988
8989         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8990         from...
8991         (rank_one_type): ... this.
8992
8993 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8994
8995         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8996         inferior-events' shows the example events.
8997
8998 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8999
9000         Support styling on native MS-Windows console
9001
9002         PR/24315
9003         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9004         on MS-Windows if $TERM is not defined.
9005
9006         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9007
9008         * posix-hdep.c (gdb_console_fputs):
9009         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9010         functions.
9011         * ui-file.h (gdb_console_fputs): Add prototype.
9012
9013         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9014         back to fputs only if the former returns zero.
9015
9016 2019-03-07  Tom Tromey  <tom@tromey.com>
9017
9018         * symmisc.c (print_symbol_bcache_statistics): Update.
9019         (print_objfile_statistics): Update.
9020         * symfile.c (allocate_symtab): Update.
9021         * stabsread.c: Don't include bcache.h.
9022         * psymtab.h (struct psymbol_bcache): Don't declare.
9023         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9024         (psymbol_bcache_init, psymbol_bcache_free)
9025         (psymbol_bcache_get_bcache): Don't declare.
9026         * psymtab.c (struct psymbol_bcache): Remove.
9027         (psymtab_storage::psymtab_storage): Update.
9028         (psymtab_storage::~psymtab_storage): Update.
9029         (psymbol_bcache_init, psymbol_bcache_free)
9030         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9031         (add_psymbol_to_bcache): Update.
9032         (allocate_psymtab): Update.
9033         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9034         macro_cache>: No longer pointers.
9035         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9036         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9037         * macrotab.c (macro_bcache): Update.
9038         * macroexp.c: Don't include bcache.h.
9039         * gdbtypes.c (check_types_worklist): Update.
9040         (types_deeply_equal): Remove TRY/CATCH.  Update.
9041         * elfread.c (elf_symtab_read): Update.
9042         * dwarf2read.c: Don't include bcache.h.
9043         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9044         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9045         (print_bcache_statistics, bcache_memory_used): Don't declare.
9046         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9047         methods.  Rename all data members.
9048         * bcache.c (struct bcache): Move to bcache.h.
9049         (bcache::expand_hash_table): Rename from expand_hash_table.
9050         (bcache): Remove.
9051         (bcache::insert): Rename from bcache_full.
9052         (bcache::compare): Rename from bcache_compare.
9053         (bcache_xmalloc): Remove.
9054         (bcache::~bcache): Rename from bcache_xfree.
9055         (bcache::print_statistics): Rename from print_bcache_statistics.
9056         (bcache::memory_used): Rename from bcache_memory_used.
9057
9058 2019-03-07  Pedro Alves  <palves@redhat.com>
9059
9060         * infrun.c (normal_stop): Also check for
9061         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9062
9063 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9064
9065         * f-lang.c (value_from_host_double): Moved to...
9066         * value.c (value_from_host_double): ...here.
9067         * value.h (value_from_host_double): Declare.
9068         * guile/scm-math.c (vlscm_convert_typed_number): Use
9069         value_from_host_double.
9070         (vlscm_convert_number): Likewise.
9071         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9072         * python/py-value.c (convert_value_from_python): Likewise.
9073
9074 2019-03-06  Tom Tromey  <tom@tromey.com>
9075
9076         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9077
9078 2019-03-06  Tom Tromey  <tom@tromey.com>
9079
9080         * utils.h (free_current_contents): Don't declare.
9081         * utils.c (free_current_contents): Remove.
9082
9083 2019-03-06  Tom Tromey  <tom@tromey.com>
9084
9085         * top.c (quit_force): Update.
9086         * main.c (captured_command_loop): Update.
9087         * common/new-op.c (operator new): Update.
9088         * common/common-exceptions.c (struct catcher)
9089         <save_cleanup_chain>: Remove member.
9090         (exceptions_state_mc_init): Update.
9091         (exception_try_scope_entry): Return nullptr.
9092         (exception_try_scope_exit, exception_rethrow)
9093         (throw_exception_sjlj, throw_exception_cxx): Update.
9094         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9095         (all_cleanups, do_cleanups, discard_cleanups)
9096         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9097         (restore_cleanups, restore_final_cleanups): Don't declare.
9098         (do_final_cleanups): Remove parameter.
9099         * common/cleanups.c (cleanup_chain, make_cleanup)
9100         (make_cleanup_dtor, all_cleanups, do_cleanups)
9101         (discard_my_cleanups, discard_cleanups)
9102         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9103         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9104         (null_cleanup): Remove.
9105         (do_final_cleanups): Remove parameter.
9106
9107 2019-03-06  Tom Tromey  <tom@tromey.com>
9108
9109         * remote.c (remote_target::remote_parse_stop_reply): Use
9110         unique_xmalloc_ptr.
9111
9112 2019-03-06  Tom Tromey  <tom@tromey.com>
9113
9114         * stabsread.c (struct stabs_field_info): Rename from field_info.
9115         <list, fnlist>: Add initializers.
9116         <obstack>: New member.
9117         (read_member_functions, read_struct_fields, read_baseclasses):
9118         Allocate on obstack.  Don't use cleanups.
9119         (read_one_struct_field, read_member_functions, read_struct_fields)
9120         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9121         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9122         (read_struct_type): Update.
9123
9124 2019-03-06  Tom Tromey  <tom@tromey.com>
9125
9126         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9127         * common/filestuff.h (make_cleanup_close): Don't declare.
9128         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9129         Remove.
9130
9131 2019-03-06  Tom Tromey  <tom@tromey.com>
9132
9133         * solib-aix.c: Use make_scope_exit.
9134
9135 2019-03-06  Tom Tromey  <tom@tromey.com>
9136
9137         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9138         Use make_scope_exit.
9139
9140 2019-03-06  Tom Tromey  <tom@tromey.com>
9141
9142         * solib-svr4.c (disable_probes_interface): Remove parameter.
9143         (svr4_handle_solib_event): Use make_scope_exit.
9144
9145 2019-03-06  Tom Tromey  <tom@tromey.com>
9146
9147         * remote.c (struct stop_reply_deleter): Remove.
9148         (stop_reply_up): Update.
9149         (struct stop_reply): Derive from notif_event.  Don't typedef.
9150         <regcache>: Now a std::vector.
9151         (stop_reply_xfree): Remove.
9152         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9153         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9154         (remote_target::discard_pending_stop_replies): Use delete.
9155         (remote_target::remote_parse_stop_reply): Update.
9156         (remote_target::process_stop_reply): Update.
9157         * remote-notif.h (struct notif_event): Add virtual destructor.
9158         Remove "dtr" member.
9159         (struct notif_client) <alloc_event>: Return a unique_ptr.
9160         (notif_event_xfree): Don't declare.
9161         (notif_event_up): New typedef.
9162         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9163         (notif_event_xfree, do_notif_event_xfree): Remove.
9164         (remote_notif_state_xfree): Update.
9165
9166 2019-03-06  Tom Tromey  <tom@tromey.com>
9167
9168         * infrun.c (displaced_step_clear_cleanup): Now a
9169         forward_scope_exit type.
9170         (displaced_step_prepare_throw): Update.
9171         (displaced_step_fixup): Update.
9172
9173 2019-03-06  Tom Tromey  <tom@tromey.com>
9174
9175         * inferior.h (class inferior): Update comment.
9176         * gdbthread.h (class thread_info): Update comment.
9177
9178 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9179             Tom Tromey  <tom@tromey.com>
9180
9181         * stabsread.h (struct stab_section_list): Remove.
9182         (coffstab_build_psymtabs): Update.
9183         * dbxread.c (symbuf_sections): Now a std::vector.
9184         (sect_idx): New global.
9185         (fill_symbuf): Update.
9186         (coffstab_build_psymtabs): Change type of stabsects parameter.
9187         Update.
9188         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9189         std::vector.
9190         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9191         (coff_locate_sections): Update.
9192         (coff_symfile_read): Remove cleanups.  Update.
9193         (init_stringtab): Add storage parameter.
9194         (free_stringtab, free_stringtab_cleanup): Remove.
9195         (init_lineno): Add storage parameter.
9196         (free_linetab, free_linetab_cleanup): Remove.
9197
9198 2019-03-06  Pedro Alves  <palves@redhat.com>
9199
9200         * linux-fork.c (fork_info::clobber_regs): Delete.
9201         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9202         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9203         comment.  Adjust.
9204         (scoped_switch_fork_info::scoped_switch_fork_info)
9205         (checkpoint_command, linux_fork_context): Adjust
9206         fork_save_infrun_state calls.
9207
9208 2019-03-06  Pedro Alves  <palves@redhat.com>
9209
9210         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9211         (inf_has_multiple_threads): Return 'bool' and rewrite using
9212         inferior_info::threads().
9213
9214 2019-03-06  Pedro Alves  <palves@redhat.com>
9215
9216         * linux-fork.c: Include <list>.
9217         (fork_list): Now a std::list instance.
9218         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9219         (forks_exist_p, find_last_fork): Adjust.
9220         (new_fork): Delete.
9221         (one_fork_p): New.
9222         (add_fork): Adjust.
9223         (free_fork): Delete, folded into fork_info::~fork_info().
9224         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9225         Adjust.
9226         (init_fork_list): Delete.
9227         (linux_fork_killall, linux_fork_mourn_inferior)
9228         (linux_fork_detach, info_checkpoints_command): Adjust.
9229         (_initialize_linux_fork): No longer call init_fork_list.
9230
9231 2019-03-06  Pedro Alves  <palves@redhat.com>
9232
9233         * linux-fork.c (new_fork): New, split out of ...
9234         (add_fork): ... this.  Return void.  Move "first fork" special
9235         case from here, to ...
9236         (checkpoint_command): ... here.
9237         * linux-linux.h (add_fork): Return void.
9238
9239 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9240
9241         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9242
9243 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9244             Chris January  <chris.january@arm.com>
9245             David Lecomber  <david.lecomber@arm.com>
9246
9247         * f-exp.y: New token, UNOP_INTRINSIC.
9248         (exp): New pattern using UNOP_INTRINSIC token.
9249         (f77_keywords): Add 'abs' keyword.
9250         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9251         (value_from_host_double): New function.
9252         (evaluate_subexp_f): Support UNOP_ABS.
9253
9254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9255
9256         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9257         types.
9258
9259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9260
9261         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9262         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9263         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9264
9265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9266
9267         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9268
9269 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9270             Chris January  <chris.january@arm.com>
9271
9272         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9273         * f-exp.y: Define 'KIND' token.
9274         (exp): New pattern for KIND expressions.
9275         (ptype): Handle types with a kind extension.
9276         (direct_abs_decl): Extend to spot kind extensions.
9277         (f77_keywords): Add 'kind' to the list.
9278         (push_kind_type): New function.
9279         (convert_to_kind_type): New function.
9280         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9281         * parse.c (operator_length_standard): Likewise.
9282         * parser-defs.h (enum type_pieces): Add tp_kind.
9283         * std-operator.def: Add UNOP_KIND.
9284
9285 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9286
9287         * f-exp.y (f_parse): Set yydebug.
9288
9289 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9290
9291         * f-lang.c (evaluate_subexp_f): New function.
9292         (exp_descriptor_f): New global.
9293         (f_language_defn): Use exp_descriptor_f instead of
9294         exp_descriptor_standard.
9295
9296 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9297
9298         * f-exp.y (struct token): Add comments.
9299         (dot_ops): Remove uppercase versions and the end marker.
9300         (f77_keywords): Likewise.
9301         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9302         entries in the dot_ops array are case insensitive, and use
9303         strncasecmp to compare strings.  Also some whitespace cleanup in
9304         this area.  Similar for the f77_keywords array, except entries in
9305         this list might be case sensitive.
9306
9307 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9308
9309         * f-exp.y (struct f77_boolean_val): Add comments.
9310         (boolean_values): Remove uppercase versions, and end marker.
9311         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9312         and use strncasecmp to achieve case insensitivity.  Additionally,
9313         perform whitespace cleanup around this code.
9314
9315 2019-03-06  Tom Tromey  <tromey@adacore.com>
9316
9317         * remote-sim.c (gdbsim_target_open): Use result of
9318         gdb_argv::release.
9319
9320 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9321         Dirk Schubert  <dirk.schubert@arm.com>
9322         Chris January  <chris.january@arm.com>
9323
9324         * eval.c (evaluate_subexp_standard): Call Fortran argument
9325         wrapping logic.
9326         * f-lang.c (struct value): A value which can be passed into a
9327         Fortran function call.
9328         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9329         where appropriate.
9330         (struct type): Value ready for a Fortran function call.
9331         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9332         is needed.
9333         * f-lang.h (fortran_argument_convert): Declaration.
9334         (fortran_preserve_arg_pointer): Declaration.
9335         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9336
9337 2019-03-05  Tom Tromey  <tromey@adacore.com>
9338
9339         * python/py-prettyprint.c (print_string_repr): Remove #if.
9340         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9341
9342 2019-03-05  Tom Tromey  <tromey@adacore.com>
9343
9344         * target.c (the_dummy_target): Move later.  Change type to
9345         "dummy_target".
9346         (initialize_targets): Don't initialize the_dummy_target.
9347
9348 2019-03-05  Tom Tromey  <tromey@adacore.com>
9349
9350         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9351         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9352
9353 2019-03-05  Tom Tromey  <tromey@adacore.com>
9354
9355         * windows-nat.c (windows_nat_target::attach)
9356         (windows_nat_target::detach): Don't call gdb_flush.
9357         * valprint.c (generic_val_print, val_print, val_print_string):
9358         Don't call gdb_flush.
9359         * utils.c (defaulted_query): Don't call gdb_flush.
9360         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9361         * target.c (target_announce_detach): Don't call gdb_flush.
9362         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9363         * remote.c (extended_remote_target::attach): Don't call
9364         gdb_flush.
9365         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9366         * printcmd.c (do_examine): Don't call gdb_flush.
9367         (info_display_command): Don't call gdb_flush.
9368         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9369         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9370         * memattr.c (info_mem_command): Don't call gdb_flush.
9371         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9372         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9373         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9374         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9375         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9376         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9377         (gnu_nat_target::detach): Don't call gdb_flush.
9378         * f-valprint.c (f_val_print): Don't call gdb_flush.
9379         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9380         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9381         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9382         gdb_flush.
9383         * c-valprint.c (c_val_print): Don't call gdb_flush.
9384         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9385
9386 2019-03-05  Tom Tromey  <tromey@adacore.com>
9387
9388         * varobj.c (update_dynamic_varobj_children): Update.
9389         (install_default_visualizer): Use reset, not release.
9390         * value.c (set_internalvar): Update.
9391         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9392         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9393         ATTRIBUTE_UNUSED_RESULT.
9394
9395 2019-03-05  Tom Tromey  <tromey@adacore.com>
9396
9397         * remote.c (class scoped_remote_fd) <release>: Add
9398         ATTRIBUTE_UNUSED_RESULT.
9399
9400 2019-03-05  Tom Tromey  <tromey@adacore.com>
9401
9402         * macroexp.c (struct macro_buffer) <release>: Add
9403         ATTRIBUTE_UNUSED_RESULT.
9404
9405 2019-03-05  Tom Tromey  <tromey@adacore.com>
9406
9407         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9408         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9409         ATTRIBUTE_UNUSED_RESULT.
9410
9411 2019-03-05  Tom Tromey  <tromey@adacore.com>
9412
9413         * common/scoped_fd.h (class scoped_fd) <release>: Add
9414         ATTRIBUTE_UNUSED_RESULT.
9415
9416 2019-03-05  Tom Tromey  <tromey@adacore.com>
9417
9418         * parser-defs.h (struct parser_state) <release>: Add
9419         ATTRIBUTE_UNUSED_RESULT.
9420
9421 2019-03-05  Tom Tromey  <tromey@adacore.com>
9422
9423         * utils.h (class gdb_argv) <release>: Add
9424         ATTRIBUTE_UNUSED_RESULT.
9425         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9426
9427 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9428
9429         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9430         for-loop range, to avoid compiler warnings.
9431
9432         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9433         avoid compiler warnings about unused variables.
9434
9435         * NEWS: Mention end of support for native debugging on MS-Windows
9436         before XP.
9437
9438         PR gdb/24292
9439         * common/netstuff.c:
9440         * gdbserver/gdbreplay.c
9441         * gdbserver/remote-utils.c:
9442         * ser-tcp.c:
9443         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9444         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9445         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9446         'getaddrinfo' and 'freeaddrinfo' were not available before
9447         Windows XP, and mingw.org's MinGW headers by default define
9448         _WIN32_WINNT to 0x500.
9449
9450 2019-03-01  Gary Benson <gbenson@redhat.com>
9451
9452         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9453
9454 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9455             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9456
9457         PR gdb/8527
9458         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9459         set_sigint_trap, clear_sigint_trap.
9460
9461 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9462
9463         * target.c (target_detach): Clear the regcache and the
9464         frame cache.
9465
9466 2019-02-27  Pedro Alves  <palves@redhat.com>
9467
9468         * utils.c (set_screen_size): When we cap the height/width sizes,
9469         tweak the corresponding command variable to show "unlimited":
9470
9471 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9472             Pedro Alves  <palves@redhat.com>
9473
9474         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9475         before calling rl_set_screen_size.
9476
9477 2019-02-27  Tom Tromey  <tromey@adacore.com>
9478
9479         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9480         define.
9481         * python/py-value.c: Remove Python 2.4 workaround.
9482         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9483         workaround.
9484         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9485         Python 2.4 workaround.
9486         * python/python-internal.h: Remove Python 2.4 comment.
9487         (Py_ssize_t): Don't define.
9488         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9489         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9490         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9491         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9492         * python/python.c (do_start_initialization): Remove Python 2.4
9493         workaround.
9494         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9495         (print_children): Remove Python 2.4 workaround.
9496         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9497         workaround.
9498         (CHARBUFFERPROC_NAME): Remove.
9499         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9500         Python 2.4 workaround.
9501
9502 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9503
9504         * NEWS: Note minimum Python version.
9505
9506 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9507
9508         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9509         code from these functions.  Remove corresponding ifdefs.  Use
9510         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9511         Remove gotos and target of gotos.
9512         (infpy_search_memory): Likewise.
9513
9514 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9515
9516         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9517         (hppa_gdbarch_init): Don't register deleted functions with
9518         gdbarch.
9519
9520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9521
9522         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9523         (h8300_unwind_sp): Delete.
9524         (h8300_dummy_id): Delete.
9525         (h8300_gdbarch_init): Don't register deleted functions with
9526         gdbarch.
9527
9528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9529
9530         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9531         (ft32_unwind_pc): Delete.
9532         (ft32_unwind_sp): Delete.
9533         (ft32_gdbarch_init): Don't register deleted functions with
9534         gdbarch.
9535
9536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9537
9538         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9539         (frv_unwind_pc): Delete.
9540         (frv_unwind_sp): Delete.
9541         (frv_gdbarch_init): Don't register deleted functions with
9542         gdbarch.
9543
9544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9545
9546         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9547         (riscv_unwind_pc): Delete.
9548         (riscv_unwind_sp): Delete.
9549         (riscv_gdbarch_init): Don't register deleted functions with
9550         gdbarch.
9551
9552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9553
9554         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9555         (csky_unwind_pc): Delete.
9556         (csky_unwind_sp): Delete.
9557         (csky_gdbarch_init): Don't register deleted functions with
9558         gdbarch.
9559
9560 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9561
9562         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9563         (cris_unwind_pc): Delete.
9564         (cris_unwind_sp): Delete.
9565         (cris_gdbarch_init): Don't register deleted functions with
9566         gdbarch.
9567
9568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9569
9570         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9571         (bfin_unwind_pc): Delete.
9572         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9573
9574 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9575
9576         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9577         (arm_unwind_pc): Delete.
9578         (arm_unwind_sp): Delete.
9579         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9580
9581 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9582
9583         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9584         (arc_unwind_pc): Delete.
9585         (arc_unwind_sp): Delete.
9586         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9587
9588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9589
9590         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9591         (alpha_unwind_pc): Delete.
9592         (alpha_gdbarch_init): Don't register deleted functions with
9593         gdbarch.
9594
9595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9596
9597         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9598         (aarch64_unwind_pc): Delete.
9599         (aarch64_unwind_sp): Delete.
9600         (aarch64_gdbarch_init): Don't register deleted functions with
9601         gdbarch.
9602
9603 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9604
9605         * gdbtypes.c (type_align): Don't consider static members when
9606         computing structure alignment.
9607
9608 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9609
9610         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9611         return 0 for other types.
9612         * arch-utils.c (default_type_align): Always return 0.
9613         * gdbarch.h: Regenerate.
9614         * gdbarch.sh (type_align): Extend comment.
9615         * gdbtypes.c (type_align): Add additional comments, always call
9616         gdbarch_type_align before applying the default rules.
9617         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9618         generic code will then apply a suitable default.
9619         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9620         types, return 0 for other types.
9621
9622 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9623
9624         * NEWS: Create a new section for the next release branch.
9625         Rename the section of the current branch, now that it has
9626         been cut.
9627
9628 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9629
9630         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9631         * version.in: Bump version to 8.3.50.DATE-git.
9632
9633 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9634
9635         * aix-thread.c (ptid_cmp): Remove unused variable.
9636         (get_signaled_thread): Likewise.
9637         (store_regs_user_thread): Likewise.
9638         (store_regs_kernel_thread): Likewise.
9639         (fetch_regs_kernel_thread): Remove shadowed variable.
9640
9641 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9642
9643         * features/riscv/32bit-cpu.xml: Add register numbers.
9644         * features/riscv/32bit-fpu.c: Regenerate.
9645         * features/riscv/32bit-fpu.xml: Add register numbers.
9646         * features/riscv/64bit-cpu.xml: Add register numbers.
9647         * features/riscv/64bit-fpu.c: Regenerate.
9648         * features/riscv/64bit-fpu.xml: Add register numbers.
9649
9650 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9651
9652         * NEWS: Mention two argument form of gdb.Value constructor.
9653         * python/py-value.c (convert_buffer_and_type_to_value): New
9654         function.
9655         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9656         Add support for handling an optional second argument.  Call
9657         convert_buffer_and_type_to_value as appropriate.
9658         * python/python-internal.h (Py_buffer_deleter): New struct.
9659         (Py_buffer_up): New typedef.
9660
9661 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9662
9663         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9664         instead of releasing ownership.
9665
9666 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9667
9668         * dwarf2read.c (open_and_init_dwp_file): Call
9669         elf_numsections instead of bfd_count_sections to initialize
9670         dwp_file->num_sections.
9671
9672 2019-02-25  Tom Tromey  <tromey@adacore.com>
9673
9674         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9675
9676 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9677
9678         * gcore.in: Add '--readnever' option when invoking GDB.
9679
9680 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9681
9682         * MAINTAINERS: Update my email address.
9683
9684 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9685
9686         * build-id.c (build_id_to_debug_bfd_1): New function.
9687         (build_id_to_debug_bfd): Look for separate debug file in
9688         sysroot.
9689
9690 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9691
9692         * gdbarch.sh: Update the copyright year range that is placed into
9693         generated files.
9694
9695 2019-02-22  Keith Seitz  <keiths@redhat.com>
9696
9697         PR symtab/23853
9698         * linespec.c (create_sals_line_offset): Search for the default
9699         symtab's filename instead of its fullname.
9700
9701 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9702
9703         * NEWS: Update style defaults.
9704
9705 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9706
9707         * main.c (captured_main_1): Disable styling in batch mode.
9708
9709 2019-02-20  Tom Tromey  <tom@tromey.com>
9710
9711         * symtab.c (symtab_symbol_info): Fix typos.
9712
9713 2019-02-20  Tom Tromey  <tromey@adacore.com>
9714
9715         * findcmd.c (_initialize_mem_search): Use upper case for
9716         metasyntactic variables.
9717
9718 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9719
9720         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9721         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9722
9723 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9724
9725         * top.h (source_file_name): Change to std::string.
9726         * top.c (source_file_name): Likewise.
9727         (command_line_input): Adjust.
9728         * cli/cli-script.c (script_from_file): Adjust.
9729
9730 2019-02-19  Tom Tromey  <tromey@adacore.com>
9731
9732         * ravenscar-thread.c
9733         (ravenscar_thread_target::update_thread_list): Don't call
9734         ada_build_task_list.
9735         * ada-lang.h (ada_build_task_list): Don't declare.
9736         * ada-tasks.c (struct ada_tasks_inferior_data)
9737         <task_list_valid_p>: Now bool.
9738         (read_known_tasks, ada_task_list_changed)
9739         (ada_tasks_invalidate_inferior_data): Update.
9740         (read_known_tasks_array): Return bool.
9741         (read_known_tasks_list): Likewise.
9742         (read_known_tasks): Return void.
9743         (ada_build_task_list): Now static.
9744
9745 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9746
9747         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9748         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9749
9750 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9751
9752         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9753         variant for ada_tasks_pspace_data_handle and
9754         ada_tasks_inferior_data_handle.
9755         (ada_tasks_pspace_data_cleanup): New function.
9756         (ada_tasks_inferior_data_cleanup): New function.
9757
9758 2019-02-17  Tom Tromey  <tom@tromey.com>
9759
9760         * macrotab.h (macro_source_fullname): Return a std::string.
9761         * macrotab.c (macro_include, check_for_redefinition)
9762         (macro_undef, macro_lookup_definition, foreach_macro)
9763         (foreach_macro_in_scope): Update.
9764         (macro_source_fullname): Return a std::string.
9765         * macrocmd.c (show_pp_source_pos): Update.
9766
9767 2019-02-17  Tom Tromey  <tom@tromey.com>
9768
9769         * macrocmd.c (show_pp_source_pos): Style the file names.
9770
9771 2019-02-17  Tom Tromey  <tom@tromey.com>
9772
9773         PR tui/24197:
9774         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9775
9776 2019-02-17  Tom Tromey  <tom@tromey.com>
9777
9778         * ada-lang.c (user_select_syms): Use filtered printing.
9779         * utils.c (wrap_style): New global.
9780         (desired_style): Remove.
9781         (emit_style_escape): Add stream parameter.
9782         (set_output_style, reset_terminal_style, prompt_for_continue):
9783         Update.
9784         (flush_wrap_buffer): Only flush gdb_stdout.
9785         (wrap_here): Set wrap_style.
9786         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9787         treat escape sequences as a character.  Change when wrap buffer is
9788         flushed.
9789         (fputs_styled): Do not set the output style when the default is
9790         requested.
9791         * ui-style.h (struct ui_file_style) <is_default>: New method.
9792         * source.c (print_source_lines_base): Emit escape sequences in one
9793         piece.
9794
9795 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9796
9797         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9798         integers and enumeration types.
9799
9800 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9801
9802         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9803         instead of lookup_symbol_in_language
9804         (do_exact_match): New function.
9805         (ada_get_symbol_name_matcher): Return do_exact_match when
9806         doing a verbatim match.
9807
9808 2019-02-15  Tom Tromey  <tromey@adacore.com>
9809
9810         * ravenscar-thread.c (ravenscar_thread_target::resume)
9811         (ravenscar_thread_target::wait): Special case wildcard requests.
9812
9813 2019-02-15  Tom Tromey  <tromey@adacore.com>
9814
9815         * ravenscar-thread.c (base_ptid): Remove.
9816         (struct ravenscar_thread_target) <close>: New method.
9817         <m_base_ptid>: New member.
9818         <update_inferior_ptid, active_task, task_is_currently_active,
9819         runtime_initialized>: Declare methods.
9820         <ravenscar_thread_target>: Add constructor.
9821         (ravenscar_thread_target::task_is_currently_active)
9822         (ravenscar_thread_target::update_inferior_ptid)
9823         (ravenscar_runtime_initialized): Rename.  Now methods.
9824         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9825         (ravenscar_thread_target::update_thread_list): Update.
9826         (ravenscar_thread_target::active_task): Now method.
9827         (ravenscar_thread_target::store_registers)
9828         (ravenscar_thread_target::prepare_to_store)
9829         (ravenscar_thread_target::prepare_to_store)
9830         (ravenscar_thread_target::mourn_inferior): Update.
9831         (ravenscar_inferior_created): Use "new" to create target.
9832         (ravenscar_thread_target::get_ada_task_ptid): Update.
9833         (_initialize_ravenscar): Don't initialize base_ptid.
9834         (ravenscar_ops): Remove global.
9835
9836 2019-02-15  Tom Tromey  <tromey@adacore.com>
9837
9838         * target.h (push_target): Declare new overload.
9839         * target.c (push_target): New overload, taking an rvalue reference.
9840         * remote.c (remote_target::open_1): Use push_target overload.
9841         * corelow.c (core_target_open): Use push_target overload.
9842
9843 2019-02-15  Tom Tromey  <tromey@adacore.com>
9844
9845         * ravenscar-thread.c (is_ravenscar_task)
9846         (ravenscar_task_is_currently_active): Return bool.
9847         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9848         (_initialize_ravenscar): Remove "(void)".
9849         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9850         Return bool.
9851
9852 2019-02-15  Tom Tromey  <tromey@adacore.com>
9853
9854         * ravenscar-thread.c (ravenscar_runtime_initializer)
9855         (has_ravenscar_runtime, get_running_thread_id)
9856         (ravenscar_thread_target::resume): Fix indentation.
9857
9858 2019-02-15  Tom Tromey  <tromey@adacore.com>
9859
9860         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9861         from ravenscar_arch_ops.
9862         (sparc_ravenscar_ops::fetch_registers)
9863         (sparc_ravenscar_ops::store_registers): Now methods.
9864         (sparc_ravenscar_prepare_to_store): Remove.
9865         (sparc_ravenscar_ops): Redefine.
9866         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9867         methods and destructor.  Remove members.
9868         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9869         (ravenscar_thread_target::store_registers)
9870         (ravenscar_thread_target::prepare_to_store): Update.
9871         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9872         Remove.
9873         (struct ppc_ravenscar_powerpc_ops): Derive from
9874         ravenscar_arch_ops.
9875         (ppc_ravenscar_powerpc_ops::fetch_registers)
9876         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9877         (ppc_ravenscar_powerpc_ops): Redefine.
9878         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9879         (ppc_ravenscar_e500_ops::fetch_registers)
9880         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9881         (ppc_ravenscar_e500_ops): Redefine.
9882         * aarch64-ravenscar-thread.c
9883         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9884         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9885         (aarch64_ravenscar_fetch_registers)
9886         (aarch64_ravenscar_store_registers): Now methods.
9887         (aarch64_ravenscar_ops): Redefine.
9888
9889 2019-02-15  Tom Tromey  <tromey@adacore.com>
9890
9891         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9892         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9893         (ravenscar_thread_target::stopped_by_watchpoint)
9894         (ravenscar_thread_target::stopped_data_address)
9895         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9896
9897 2019-02-15  Tom Tromey  <tromey@adacore.com>
9898
9899         * ravenscar-thread.c: Fix some typos.
9900
9901 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9902             Tom Tromey  <tromey@adacore.com>
9903
9904         * ada-lang.c (ada_exception_sal): Change addr_string to a
9905         std::string.
9906         (create_ada_exception_catchpoint): Update.
9907
9908 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9909             Tom Tromey  <tromey@adacore.com>
9910
9911         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9912         (bp_location_ops): Remove.
9913         (base_breakpoint_allocate_location): Update.
9914         (free_bp_location): Update.
9915         * ada-lang.c (class ada_catchpoint_location)
9916         <ada_catchpoint_location>: Remove ops parameter.
9917         (ada_catchpoint_location_dtor): Remove.
9918         (ada_catchpoint_location_ops): Remove.
9919         (allocate_location_exception): Update.
9920         * breakpoint.h (struct bp_location_ops): Remove.
9921         (class bp_location) <bp_location>: Remove bp_location_ops
9922         parameter.
9923         <~bp_location>: Add destructor.
9924         <ops>: Remove.
9925
9926 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9927             Pedro Alves  <palves@redhat.com>
9928
9929         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9930         'PATH_MAX'.
9931
9932 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9933             Samuel Thibault  <samuel.thibault@gnu.org>
9934             Thomas Schwinge  <thomas@codesourcery.com>
9935
9936         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9937         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9938
9939 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9940
9941         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9942         (check_empty): Use "const char *".
9943
9944         * gnu-nat.c (gnu_nat_target::detach): Instead of
9945         'detach_inferior (pid)' call
9946         'detach_inferior (find_inferior_pid (pid))'.
9947
9948         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9949         'nat/fork-inferior.o'.
9950         * gnu-nat.c: #include "nat/fork-inferior.h".
9951
9952         * gnu-nat.c (gnu_nat_target::detach): Instead of
9953         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9954         * gnu-nat.h: #include "inf-child.h".
9955         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9956         'i386_gnu_nat_target::fetch_registers'.
9957         (gnu_store_registers): Rename/move to
9958         'i386_gnu_nat_target::store_registers'.
9959
9960         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9961         * gnu-nat.h (mach_thread_info): New function.
9962         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9963
9964         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9965
9966 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9967
9968         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9969
9970 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9971
9972         * windows-nat.c (windows_add_thread): Add new parameter
9973         "main_thread_p" with default value set to false.  Update
9974         function documentation as well as all callers.
9975         (windows_delete_thread): Likewise.
9976         (fake_create_process): Update call to windows_add_thread.
9977         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9978         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9979         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9980         call to windows_delete_thread.
9981
9982 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9983
9984         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9985
9986 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9987
9988         * symfile.c (find_separate_debug_file): Use canonical path of
9989         sysroot with child_path instead of gdb_sysroot if it is valid.
9990
9991 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9992
9993         * symfile.c (find_separate_debug_file): Use child_path to
9994         determine if an object file is under a sysroot.
9995
9996 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9997
9998         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9999         unittests/child-path-selftests.c.
10000         * common/pathstuff.c (child_path): New function.
10001         * common/pathstuff.h (child_path): New prototype.
10002         * unittests/child-path-selftests.c: New file.
10003
10004 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10005
10006         * symfile.c (find_separate_debug_file): Look for separate debug
10007         files in debug directories under the sysroot.
10008
10009 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10010
10011         * symtab.h (struct minimal_symbol data_p): New const method.
10012         (struct minimal_symbol text_p): Likewise.
10013         * symtab.c (output_source_filename): Use file name style
10014         to print file name.
10015         (print_symbol_info): Likewise.
10016         (print_msymbol_info): Use address style to print addresses.
10017         Use function name style to print executable text symbols.
10018         (expand_symtab_containing_pc): Use data_p.
10019         (find_pc_sect_compunit_symtab): Likewise.
10020
10021 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10022
10023         * breakpoint.c (describe_other_breakpoints): Use address style
10024         to print addresses.
10025         (say_where): Likewise.
10026
10027 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10028
10029         * ada-typeprint.c (print_func_type): Print function name
10030         style to print function name.
10031         * c-typeprint.c (c_print_type_1): Likewise.
10032
10033 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10034
10035         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10036         for execve.
10037
10038 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10039
10040         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10041         type_stack.
10042
10043 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10044
10045         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10046         TYPE_CODE_REF types.
10047
10048 2019-02-08  Jim Wilson  <jimw@sifive.com>
10049
10050         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10051         (riscv_linux_fregset): New.
10052         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10053
10054 2019-02-07  Tom Tromey  <tom@tromey.com>
10055
10056         * thread.c (thread_cancel_execution_command): Update.
10057         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10058         methods.
10059         (struct thread_fsm_ops): Remove.
10060         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10061         (thread_fsm_should_stop, thread_fsm_return_value)
10062         (thread_fsm_set_finished, thread_fsm_finished_p)
10063         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10064         Don't declare.
10065         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10066         * infrun.c (clear_proceed_status_thread)
10067         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10068         (print_stop_event): Update.
10069         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10070         Add constructor.
10071         (step_command_fsm_ops): Remove.
10072         (new_step_command_fsm): Remove.
10073         (step_1): Update.
10074         (step_command_fsm::should_stop): Rename from
10075         step_command_fsm_should_stop.
10076         (step_command_fsm::clean_up): Rename from
10077         step_command_fsm_clean_up.
10078         (step_command_fsm::do_async_reply_reason): Rename from
10079         step_command_fsm_async_reply_reason.
10080         (struct until_next_fsm): Inherit from thread_fsm.  Add
10081         constructor.
10082         (until_next_fsm_ops): Remove.
10083         (new_until_next_fsm): Remove.
10084         (until_next_fsm::should_stop): Rename from
10085         until_next_fsm_should_stop.
10086         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10087         (until_next_fsm::do_async_reply_reason): Rename from
10088         until_next_fsm_async_reply_reason.
10089         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10090         constructor.  Change type of breakpoint.
10091         (finish_command_fsm_ops): Remove.
10092         (new_finish_command_fsm): Remove.
10093         (finish_command_fsm::should_stop): Rename from
10094         finish_command_fsm_should_stop.
10095         (finish_command_fsm::clean_up): Rename from
10096         finish_command_fsm_clean_up.
10097         (finish_command_fsm::return_value): Rename from
10098         finish_command_fsm_return_value.
10099         (finish_command_fsm::do_async_reply_reason): Rename from
10100         finish_command_fsm_async_reply_reason.
10101         (finish_command): Update.
10102         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10103         Add constructor.
10104         (call_thread_fsm_ops): Remove.
10105         (call_thread_fsm::call_thread_fsm): Rename from
10106         new_call_thread_fsm.
10107         (call_thread_fsm::should_stop): Rename from
10108         call_thread_fsm_should_stop.
10109         (call_thread_fsm::should_notify_stop): Rename from
10110         call_thread_fsm_should_notify_stop.
10111         (run_inferior_call, call_function_by_hand_dummy): Update.
10112         * cli/cli-interp.c (should_print_stop_to_console): Update.
10113         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10114         Add constructor.  Change type of location_breakpoint,
10115         caller_breakpoint.
10116         (until_break_fsm_ops): Remove.
10117         (new_until_break_fsm): Remove.
10118         (until_break_fsm::should_stop): Rename from
10119         until_break_fsm_should_stop.
10120         (until_break_fsm::clean_up): Rename from
10121         until_break_fsm_clean_up.
10122         (until_break_fsm::do_async_reply_reason): Rename from
10123         until_break_fsm_async_reply_reason.
10124         (until_break_command): Update.
10125         * thread-fsm.c: Remove.
10126         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10127
10128 2019-02-07  Tom Tromey  <tom@tromey.com>
10129
10130         * yy-remap.h: Add include guard.
10131         * xtensa-tdep.h: Add include guard.
10132         * xcoffread.h: Rename include guard.
10133         * varobj-iter.h: Add include guard.
10134         * tui/tui.h: Rename include guard.
10135         * tui/tui-winsource.h: Rename include guard.
10136         * tui/tui-wingeneral.h: Rename include guard.
10137         * tui/tui-windata.h: Rename include guard.
10138         * tui/tui-win.h: Rename include guard.
10139         * tui/tui-stack.h: Rename include guard.
10140         * tui/tui-source.h: Rename include guard.
10141         * tui/tui-regs.h: Rename include guard.
10142         * tui/tui-out.h: Rename include guard.
10143         * tui/tui-layout.h: Rename include guard.
10144         * tui/tui-io.h: Rename include guard.
10145         * tui/tui-hooks.h: Rename include guard.
10146         * tui/tui-file.h: Rename include guard.
10147         * tui/tui-disasm.h: Rename include guard.
10148         * tui/tui-data.h: Rename include guard.
10149         * tui/tui-command.h: Rename include guard.
10150         * tic6x-tdep.h: Add include guard.
10151         * target/waitstatus.h: Rename include guard.
10152         * target/wait.h: Rename include guard.
10153         * target/target.h: Rename include guard.
10154         * target/resume.h: Rename include guard.
10155         * target-float.h: Rename include guard.
10156         * stabsread.h: Add include guard.
10157         * rs6000-tdep.h: Add include guard.
10158         * riscv-fbsd-tdep.h: Add include guard.
10159         * regformats/regdef.h: Rename include guard.
10160         * record.h: Rename include guard.
10161         * python/python.h: Rename include guard.
10162         * python/python-internal.h: Rename include guard.
10163         * python/py-stopevent.h: Rename include guard.
10164         * python/py-ref.h: Rename include guard.
10165         * python/py-record.h: Rename include guard.
10166         * python/py-record-full.h: Rename include guard.
10167         * python/py-record-btrace.h: Rename include guard.
10168         * python/py-instruction.h: Rename include guard.
10169         * python/py-events.h: Rename include guard.
10170         * python/py-event.h: Rename include guard.
10171         * procfs.h: Add include guard.
10172         * proc-utils.h: Add include guard.
10173         * p-lang.h: Add include guard.
10174         * or1k-tdep.h: Rename include guard.
10175         * observable.h: Rename include guard.
10176         * nto-tdep.h: Rename include guard.
10177         * nat/x86-linux.h: Rename include guard.
10178         * nat/x86-linux-dregs.h: Rename include guard.
10179         * nat/x86-gcc-cpuid.h: Add include guard.
10180         * nat/x86-dregs.h: Rename include guard.
10181         * nat/x86-cpuid.h: Rename include guard.
10182         * nat/ppc-linux.h: Rename include guard.
10183         * nat/mips-linux-watch.h: Rename include guard.
10184         * nat/linux-waitpid.h: Rename include guard.
10185         * nat/linux-ptrace.h: Rename include guard.
10186         * nat/linux-procfs.h: Rename include guard.
10187         * nat/linux-osdata.h: Rename include guard.
10188         * nat/linux-nat.h: Rename include guard.
10189         * nat/linux-namespaces.h: Rename include guard.
10190         * nat/linux-btrace.h: Rename include guard.
10191         * nat/glibc_thread_db.h: Rename include guard.
10192         * nat/gdb_thread_db.h: Rename include guard.
10193         * nat/gdb_ptrace.h: Rename include guard.
10194         * nat/fork-inferior.h: Rename include guard.
10195         * nat/amd64-linux-siginfo.h: Rename include guard.
10196         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10197         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10198         * nat/aarch64-linux.h: Rename include guard.
10199         * nat/aarch64-linux-hw-point.h: Rename include guard.
10200         * mn10300-tdep.h: Add include guard.
10201         * mips-linux-tdep.h: Add include guard.
10202         * mi/mi-parse.h: Rename include guard.
10203         * mi/mi-out.h: Rename include guard.
10204         * mi/mi-main.h: Rename include guard.
10205         * mi/mi-interp.h: Rename include guard.
10206         * mi/mi-getopt.h: Rename include guard.
10207         * mi/mi-console.h: Rename include guard.
10208         * mi/mi-common.h: Rename include guard.
10209         * mi/mi-cmds.h: Rename include guard.
10210         * mi/mi-cmd-break.h: Rename include guard.
10211         * m2-lang.h: Add include guard.
10212         * location.h: Rename include guard.
10213         * linux-record.h: Rename include guard.
10214         * linux-nat.h: Add include guard.
10215         * linux-fork.h: Add include guard.
10216         * i386-darwin-tdep.h: Rename include guard.
10217         * hppa-linux-offsets.h: Add include guard.
10218         * guile/guile.h: Rename include guard.
10219         * guile/guile-internal.h: Rename include guard.
10220         * gnu-nat.h: Rename include guard.
10221         * gdb-stabs.h: Rename include guard.
10222         * frv-tdep.h: Add include guard.
10223         * f-lang.h: Add include guard.
10224         * event-loop.h: Add include guard.
10225         * darwin-nat.h: Rename include guard.
10226         * cp-abi.h: Rename include guard.
10227         * config/sparc/nm-sol2.h: Rename include guard.
10228         * config/nm-nto.h: Rename include guard.
10229         * config/nm-linux.h: Add include guard.
10230         * config/i386/nm-i386gnu.h: Rename include guard.
10231         * config/djgpp/nl_types.h: Rename include guard.
10232         * config/djgpp/langinfo.h: Rename include guard.
10233         * compile/gcc-cp-plugin.h: Add include guard.
10234         * compile/gcc-c-plugin.h: Add include guard.
10235         * compile/compile.h: Rename include guard.
10236         * compile/compile-object-run.h: Rename include guard.
10237         * compile/compile-object-load.h: Rename include guard.
10238         * compile/compile-internal.h: Rename include guard.
10239         * compile/compile-cplus.h: Rename include guard.
10240         * compile/compile-c.h: Rename include guard.
10241         * common/xml-utils.h: Rename include guard.
10242         * common/x86-xstate.h: Rename include guard.
10243         * common/version.h: Rename include guard.
10244         * common/vec.h: Rename include guard.
10245         * common/tdesc.h: Rename include guard.
10246         * common/selftest.h: Rename include guard.
10247         * common/scoped_restore.h: Rename include guard.
10248         * common/scoped_mmap.h: Rename include guard.
10249         * common/scoped_fd.h: Rename include guard.
10250         * common/safe-iterator.h: Rename include guard.
10251         * common/run-time-clock.h: Rename include guard.
10252         * common/refcounted-object.h: Rename include guard.
10253         * common/queue.h: Rename include guard.
10254         * common/ptid.h: Rename include guard.
10255         * common/print-utils.h: Rename include guard.
10256         * common/preprocessor.h: Rename include guard.
10257         * common/pathstuff.h: Rename include guard.
10258         * common/observable.h: Rename include guard.
10259         * common/netstuff.h: Rename include guard.
10260         * common/job-control.h: Rename include guard.
10261         * common/host-defs.h: Rename include guard.
10262         * common/gdb_wait.h: Rename include guard.
10263         * common/gdb_vecs.h: Rename include guard.
10264         * common/gdb_unlinker.h: Rename include guard.
10265         * common/gdb_unique_ptr.h: Rename include guard.
10266         * common/gdb_tilde_expand.h: Rename include guard.
10267         * common/gdb_sys_time.h: Rename include guard.
10268         * common/gdb_string_view.h: Rename include guard.
10269         * common/gdb_splay_tree.h: Rename include guard.
10270         * common/gdb_setjmp.h: Rename include guard.
10271         * common/gdb_ref_ptr.h: Rename include guard.
10272         * common/gdb_optional.h: Rename include guard.
10273         * common/gdb_locale.h: Rename include guard.
10274         * common/gdb_assert.h: Rename include guard.
10275         * common/filtered-iterator.h: Rename include guard.
10276         * common/filestuff.h: Rename include guard.
10277         * common/fileio.h: Rename include guard.
10278         * common/environ.h: Rename include guard.
10279         * common/common-utils.h: Rename include guard.
10280         * common/common-types.h: Rename include guard.
10281         * common/common-regcache.h: Rename include guard.
10282         * common/common-inferior.h: Rename include guard.
10283         * common/common-gdbthread.h: Rename include guard.
10284         * common/common-exceptions.h: Rename include guard.
10285         * common/common-defs.h: Rename include guard.
10286         * common/common-debug.h: Rename include guard.
10287         * common/cleanups.h: Rename include guard.
10288         * common/buffer.h: Rename include guard.
10289         * common/btrace-common.h: Rename include guard.
10290         * common/break-common.h: Rename include guard.
10291         * cli/cli-utils.h: Rename include guard.
10292         * cli/cli-style.h: Rename include guard.
10293         * cli/cli-setshow.h: Rename include guard.
10294         * cli/cli-script.h: Rename include guard.
10295         * cli/cli-interp.h: Rename include guard.
10296         * cli/cli-decode.h: Rename include guard.
10297         * cli/cli-cmds.h: Rename include guard.
10298         * charset-list.h: Add include guard.
10299         * buildsym-legacy.h: Rename include guard.
10300         * bfin-tdep.h: Add include guard.
10301         * ax.h: Rename include guard.
10302         * arm-linux-tdep.h: Add include guard.
10303         * arm-fbsd-tdep.h: Add include guard.
10304         * arch/xtensa.h: Rename include guard.
10305         * arch/tic6x.h: Add include guard.
10306         * arch/i386.h: Add include guard.
10307         * arch/arm.h: Rename include guard.
10308         * arch/arm-linux.h: Rename include guard.
10309         * arch/arm-get-next-pcs.h: Rename include guard.
10310         * arch/amd64.h: Add include guard.
10311         * arch/aarch64-insn.h: Rename include guard.
10312         * arch-utils.h: Rename include guard.
10313         * annotate.h: Add include guard.
10314         * amd64-darwin-tdep.h: Rename include guard.
10315         * aarch64-linux-tdep.h: Add include guard.
10316         * aarch64-fbsd-tdep.h: Add include guard.
10317         * aarch32-linux-nat.h: Add include guard.
10318
10319 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10320
10321         * macrotab.c (macro_define_internal): New function that
10322         factorizes macro_define_object_internal and macro_define_function
10323         code.
10324         (macro_define_object_internal): Use macro_define_internal.
10325         (macro_define_function): Likewise.
10326
10327 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10328
10329         * macrocmd.c (extract_identifier): Return
10330         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10331         callers.
10332
10333 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10334
10335         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10336
10337 2019-02-05  Tom Tromey  <tom@tromey.com>
10338
10339         * target.c (target_stack::unpush): Move assertion earlier.
10340
10341 2019-01-30  Tom Tromey  <tom@tromey.com>
10342
10343         PR python/23615:
10344         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10345         (gdbpy_parse_and_eval): Likewise.
10346         * python/python-internal.h (gdbpy_allow_threads): New class.
10347
10348 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10349
10350         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10351         (aarch64_fbsd_fpregmap): Move earlier.
10352         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10353         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10354         instead of individual calls to trad_frame_set_reg_addr.
10355         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10356         earlier.
10357         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10358         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10359         instead of individual calls to trad_frame_set_reg_addr.
10360
10361 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10362
10363         * CONTRIBUTE: Replace contribution list with wiki link.
10364
10365 2019-01-25  Tom Tromey  <tom@tromey.com>
10366
10367         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10368
10369 2019-01-25  Tom Tromey  <tom@tromey.com>
10370
10371         * xtensa-linux-nat.c: Fix common/ includes.
10372         * xml-support.h: Fix common/ includes.
10373         * xml-support.c: Fix common/ includes.
10374         * x86-linux-nat.c: Fix common/ includes.
10375         * windows-nat.c: Fix common/ includes.
10376         * varobj.h: Fix common/ includes.
10377         * varobj.c: Fix common/ includes.
10378         * value.c: Fix common/ includes.
10379         * valops.c: Fix common/ includes.
10380         * utils.c: Fix common/ includes.
10381         * unittests/xml-utils-selftests.c: Fix common/ includes.
10382         * unittests/utils-selftests.c: Fix common/ includes.
10383         * unittests/unpack-selftests.c: Fix common/ includes.
10384         * unittests/tracepoint-selftests.c: Fix common/ includes.
10385         * unittests/style-selftests.c: Fix common/ includes.
10386         * unittests/string_view-selftests.c: Fix common/ includes.
10387         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10388         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10389         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10390         * unittests/rsp-low-selftests.c: Fix common/ includes.
10391         * unittests/parse-connection-spec-selftests.c: Fix common/
10392         includes.
10393         * unittests/optional-selftests.c: Fix common/ includes.
10394         * unittests/offset-type-selftests.c: Fix common/ includes.
10395         * unittests/observable-selftests.c: Fix common/ includes.
10396         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10397         * unittests/memrange-selftests.c: Fix common/ includes.
10398         * unittests/memory-map-selftests.c: Fix common/ includes.
10399         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10400         * unittests/function-view-selftests.c: Fix common/ includes.
10401         * unittests/environ-selftests.c: Fix common/ includes.
10402         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10403         * unittests/common-utils-selftests.c: Fix common/ includes.
10404         * unittests/cli-utils-selftests.c: Fix common/ includes.
10405         * unittests/array-view-selftests.c: Fix common/ includes.
10406         * ui-file.c: Fix common/ includes.
10407         * tui/tui-io.c: Fix common/ includes.
10408         * tracepoint.h: Fix common/ includes.
10409         * tracepoint.c: Fix common/ includes.
10410         * tracefile-tfile.c: Fix common/ includes.
10411         * top.h: Fix common/ includes.
10412         * top.c: Fix common/ includes.
10413         * thread.c: Fix common/ includes.
10414         * target/waitstatus.h: Fix common/ includes.
10415         * target/waitstatus.c: Fix common/ includes.
10416         * target.h: Fix common/ includes.
10417         * target.c: Fix common/ includes.
10418         * target-memory.c: Fix common/ includes.
10419         * target-descriptions.c: Fix common/ includes.
10420         * symtab.h: Fix common/ includes.
10421         * symfile.c: Fix common/ includes.
10422         * stap-probe.c: Fix common/ includes.
10423         * spu-linux-nat.c: Fix common/ includes.
10424         * sparc-nat.c: Fix common/ includes.
10425         * source.c: Fix common/ includes.
10426         * solib.c: Fix common/ includes.
10427         * solib-target.c: Fix common/ includes.
10428         * ser-unix.c: Fix common/ includes.
10429         * ser-tcp.c: Fix common/ includes.
10430         * ser-pipe.c: Fix common/ includes.
10431         * ser-base.c: Fix common/ includes.
10432         * selftest-arch.c: Fix common/ includes.
10433         * s12z-tdep.c: Fix common/ includes.
10434         * rust-exp.y: Fix common/ includes.
10435         * rs6000-aix-tdep.c: Fix common/ includes.
10436         * riscv-tdep.c: Fix common/ includes.
10437         * remote.c: Fix common/ includes.
10438         * remote-notif.h: Fix common/ includes.
10439         * remote-fileio.h: Fix common/ includes.
10440         * remote-fileio.c: Fix common/ includes.
10441         * regcache.h: Fix common/ includes.
10442         * regcache.c: Fix common/ includes.
10443         * record-btrace.c: Fix common/ includes.
10444         * python/python.c: Fix common/ includes.
10445         * python/py-type.c: Fix common/ includes.
10446         * python/py-inferior.c: Fix common/ includes.
10447         * progspace.h: Fix common/ includes.
10448         * producer.c: Fix common/ includes.
10449         * procfs.c: Fix common/ includes.
10450         * proc-api.c: Fix common/ includes.
10451         * printcmd.c: Fix common/ includes.
10452         * ppc-linux-nat.c: Fix common/ includes.
10453         * parser-defs.h: Fix common/ includes.
10454         * osdata.c: Fix common/ includes.
10455         * obsd-nat.c: Fix common/ includes.
10456         * nat/x86-linux.c: Fix common/ includes.
10457         * nat/x86-linux-dregs.c: Fix common/ includes.
10458         * nat/x86-dregs.h: Fix common/ includes.
10459         * nat/x86-dregs.c: Fix common/ includes.
10460         * nat/ppc-linux.c: Fix common/ includes.
10461         * nat/mips-linux-watch.h: Fix common/ includes.
10462         * nat/mips-linux-watch.c: Fix common/ includes.
10463         * nat/linux-waitpid.c: Fix common/ includes.
10464         * nat/linux-ptrace.h: Fix common/ includes.
10465         * nat/linux-ptrace.c: Fix common/ includes.
10466         * nat/linux-procfs.c: Fix common/ includes.
10467         * nat/linux-personality.c: Fix common/ includes.
10468         * nat/linux-osdata.c: Fix common/ includes.
10469         * nat/linux-namespaces.c: Fix common/ includes.
10470         * nat/linux-btrace.h: Fix common/ includes.
10471         * nat/linux-btrace.c: Fix common/ includes.
10472         * nat/fork-inferior.c: Fix common/ includes.
10473         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10474         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10475         * nat/aarch64-linux.c: Fix common/ includes.
10476         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10477         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10478         * namespace.h: Fix common/ includes.
10479         * mips-linux-tdep.c: Fix common/ includes.
10480         * minsyms.c: Fix common/ includes.
10481         * mi/mi-parse.h: Fix common/ includes.
10482         * mi/mi-main.c: Fix common/ includes.
10483         * mi/mi-cmd-env.c: Fix common/ includes.
10484         * memrange.h: Fix common/ includes.
10485         * memattr.c: Fix common/ includes.
10486         * maint.h: Fix common/ includes.
10487         * maint.c: Fix common/ includes.
10488         * main.c: Fix common/ includes.
10489         * machoread.c: Fix common/ includes.
10490         * location.c: Fix common/ includes.
10491         * linux-thread-db.c: Fix common/ includes.
10492         * linux-nat.c: Fix common/ includes.
10493         * linux-fork.c: Fix common/ includes.
10494         * inline-frame.c: Fix common/ includes.
10495         * infrun.c: Fix common/ includes.
10496         * inflow.c: Fix common/ includes.
10497         * inferior.h: Fix common/ includes.
10498         * inferior.c: Fix common/ includes.
10499         * infcmd.c: Fix common/ includes.
10500         * inf-ptrace.c: Fix common/ includes.
10501         * inf-child.c: Fix common/ includes.
10502         * ia64-linux-nat.c: Fix common/ includes.
10503         * i387-tdep.c: Fix common/ includes.
10504         * i386-tdep.c: Fix common/ includes.
10505         * i386-linux-tdep.c: Fix common/ includes.
10506         * i386-linux-nat.c: Fix common/ includes.
10507         * i386-go32-tdep.c: Fix common/ includes.
10508         * i386-fbsd-tdep.c: Fix common/ includes.
10509         * i386-fbsd-nat.c: Fix common/ includes.
10510         * guile/scm-type.c: Fix common/ includes.
10511         * guile/guile.c: Fix common/ includes.
10512         * go32-nat.c: Fix common/ includes.
10513         * gnu-nat.c: Fix common/ includes.
10514         * gdbthread.h: Fix common/ includes.
10515         * gdbarch-selftests.c: Fix common/ includes.
10516         * gdb_usleep.c: Fix common/ includes.
10517         * gdb_select.h: Fix common/ includes.
10518         * gdb_bfd.c: Fix common/ includes.
10519         * gcore.c: Fix common/ includes.
10520         * fork-child.c: Fix common/ includes.
10521         * findvar.c: Fix common/ includes.
10522         * fbsd-nat.c: Fix common/ includes.
10523         * event-top.c: Fix common/ includes.
10524         * event-loop.c: Fix common/ includes.
10525         * dwarf2read.c: Fix common/ includes.
10526         * dwarf2loc.c: Fix common/ includes.
10527         * dwarf2-frame.c: Fix common/ includes.
10528         * dwarf-index-cache.c: Fix common/ includes.
10529         * dtrace-probe.c: Fix common/ includes.
10530         * disasm-selftests.c: Fix common/ includes.
10531         * defs.h: Fix common/ includes.
10532         * csky-tdep.c: Fix common/ includes.
10533         * cp-valprint.c: Fix common/ includes.
10534         * cp-support.h: Fix common/ includes.
10535         * cp-support.c: Fix common/ includes.
10536         * corelow.c: Fix common/ includes.
10537         * completer.h: Fix common/ includes.
10538         * completer.c: Fix common/ includes.
10539         * compile/compile.c: Fix common/ includes.
10540         * compile/compile-loc2c.c: Fix common/ includes.
10541         * compile/compile-cplus-types.c: Fix common/ includes.
10542         * compile/compile-cplus-symbols.c: Fix common/ includes.
10543         * command.h: Fix common/ includes.
10544         * cli/cli-dump.c: Fix common/ includes.
10545         * cli/cli-cmds.c: Fix common/ includes.
10546         * charset.c: Fix common/ includes.
10547         * build-id.c: Fix common/ includes.
10548         * btrace.h: Fix common/ includes.
10549         * btrace.c: Fix common/ includes.
10550         * breakpoint.h: Fix common/ includes.
10551         * breakpoint.c: Fix common/ includes.
10552         * ax.h:
10553         (enum agent_op): Fix common/ includes.
10554         * ax-general.c (struct aop_map): Fix common/ includes.
10555         * ax-gdb.c: Fix common/ includes.
10556         * auxv.c: Fix common/ includes.
10557         * auto-load.c: Fix common/ includes.
10558         * arm-tdep.c: Fix common/ includes.
10559         * arch/riscv.c: Fix common/ includes.
10560         * arch/ppc-linux-common.c: Fix common/ includes.
10561         * arch/i386.c: Fix common/ includes.
10562         * arch/arm.c: Fix common/ includes.
10563         * arch/arm-linux.c: Fix common/ includes.
10564         * arch/arm-get-next-pcs.c: Fix common/ includes.
10565         * arch/amd64.c: Fix common/ includes.
10566         * arch/aarch64.c: Fix common/ includes.
10567         * arch/aarch64-insn.c: Fix common/ includes.
10568         * arch-utils.c: Fix common/ includes.
10569         * amd64-windows-tdep.c: Fix common/ includes.
10570         * amd64-tdep.c: Fix common/ includes.
10571         * amd64-sol2-tdep.c: Fix common/ includes.
10572         * amd64-obsd-tdep.c: Fix common/ includes.
10573         * amd64-nbsd-tdep.c: Fix common/ includes.
10574         * amd64-linux-tdep.c: Fix common/ includes.
10575         * amd64-linux-nat.c: Fix common/ includes.
10576         * amd64-fbsd-tdep.c: Fix common/ includes.
10577         * amd64-fbsd-nat.c: Fix common/ includes.
10578         * amd64-dicos-tdep.c: Fix common/ includes.
10579         * amd64-darwin-tdep.c: Fix common/ includes.
10580         * agent.c: Fix common/ includes.
10581         * ada-lang.h: Fix common/ includes.
10582         * ada-lang.c: Fix common/ includes.
10583         * aarch64-tdep.c: Fix common/ includes.
10584
10585 2019-01-25  Tom Tromey  <tom@tromey.com>
10586
10587         * common/create-version.sh: Use common/version.h.
10588
10589 2019-01-24  Pedro Alves  <palves@redhat.com>
10590
10591         * infrun.c (signal_stop, signal_print, signal_program)
10592         (signal_catch, signal_pass): Now arrays instead of pointers.
10593         (update_signals_program_target, do_target_resume)
10594         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10595         * linux-nat.c (linux_nat_target::pass_signals)
10596         (linux_nat_target::create_inferior, linux_nat_target::attach):
10597         Adjust.
10598         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10599         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10600         * procfs.c (procfs_target::pass_signals): Adjust.
10601         * record-full.c (record_full_target::resume): Adjust.
10602         * remote.c (remote_target::pass_signals)
10603         (remote_target::program_signals): Adjust.
10604         * target-debug.h (target_debug_print_signals): Now takes a
10605         gdb::array_view as parameter.  Adjust.
10606         * target.h (target_ops) <pass_signals, program_signals>: Replace
10607         pointer and length parameters with gdb::array_view.
10608         (target_pass_signals, target_program_signals): Likewise.
10609         * target-delegates.c: Regenerate.
10610
10611 2019-01-24  Pedro Alves  <palves@redhat.com>
10612
10613         * common/forward-scope-exit.h
10614         (forward_scope_exit::forward_scope_exit): Pass arguments to
10615         m_bind_function directly, instead of creating a std::bind and
10616         copying that.
10617
10618 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10619
10620         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10621         for static members.
10622         (pass_in_v_vfp_candidate): Likewise.
10623
10624 2019-01-23  Tom Tromey  <tom@tromey.com>
10625             Pedro Alves  <palves@redhat.com>
10626
10627         * regcache.c (class regcache_invalidator): Remove.
10628         (regcache::raw_write): Use make_scope_exit.
10629
10630 2019-01-23  Tom Tromey  <tom@tromey.com>
10631
10632         * ui-out.h (class ui_out_emit_type): Update comment.
10633
10634 2019-01-23  Tom Tromey  <tom@tromey.com>
10635
10636         * infrun.c (fetch_inferior_event): Update comment.
10637
10638 2019-01-23  Tom Tromey  <tom@tromey.com>
10639             Pedro Alves  <palves@redhat.com>
10640
10641         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10642         parameter.
10643         (fetch_inferior_event): Use SCOPE_EXIT.
10644
10645
10646 2019-01-23  Tom Tromey  <tom@tromey.com>
10647             Pedro Alves  <palves@redhat.com>
10648
10649         * infrun.c (disable_thread_events): Delete.
10650         (stop_all_threads): Use SCOPE_EXIT.
10651
10652 2019-01-23  Tom Tromey  <tom@tromey.com>
10653             Pedro Alves  <palves@redhat.com>
10654
10655         * symfile.c: Include forward-scope-exit.h.
10656         (clear_symtab_users_cleanup): Replace forward declaration with
10657         a FORWARD_SCOPE_EXIT.
10658         (syms_from_objfile_1): Use the forward_scope_exit and
10659         gdb::optional instead of cleanup_function.
10660         (reread_symbols): Use the forward_scope_exit instead of
10661         cleanup_function.
10662         (clear_symtab_users_cleanup): Remove function.
10663
10664 2019-01-23  Tom Tromey  <tom@tromey.com>
10665             Pedro Alves  <palves@redhat.com>
10666
10667         * linux-nat.c: Include scope-exit.h.
10668         (cleanup_target_stop): Remove.
10669         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10670         SCOPE_EXIT.
10671
10672 2019-01-23  Tom Tromey  <tom@tromey.com>
10673             Pedro Alves  <palves@redhat.com>
10674
10675         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10676         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10677
10678 2019-01-23  Tom Tromey  <tom@tromey.com>
10679             Andrew Burgess  <andrew.burgess@embecosm.com>
10680             Pedro Alves  <palves@redhat.com>
10681
10682         * infrun.c (fetch_inferior_event): Use scope_exit.
10683         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10684         * top.c (execute_command): Use scope_exit.
10685         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10686         * utils.c (do_bpstat_clear_actions_cleanup)
10687         (make_bpstat_clear_actions_cleanup): Remove.
10688
10689 2019-01-23  Tom Tromey  <tom@tromey.com>
10690             Pedro Alves  <palves@redhat.com>
10691
10692         * infrun.c: Include "common/scope-exit.h"
10693         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10694         (wait_for_inferior): Use SCOPE_EXIT.
10695         (fetch_inferior_event): Use scope_exit.
10696
10697 2019-01-23  Tom Tromey  <tom@tromey.com>
10698             Pedro Alves  <palves@redhat.com>
10699
10700         * breakpoint.c (create_breakpoint): Remove cleanup.
10701
10702 2019-01-23  Tom Tromey  <tom@tromey.com>
10703             Andrew Burgess  <andrew.burgess@embecosm.com>
10704             Pedro Alves  <palves@redhat.com>
10705
10706 2019-01-23  Pedro Alves  <palves@redhat.com>
10707
10708         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10709
10710 2019-01-23  Pedro Alves  <palves@redhat.com>
10711             Andrew Burgess  <andrew.burgess@embecosm.com>
10712
10713         * gdbthread.h: Include "common/forward-scope-exit.h".
10714         (scoped_finish_thread_state): Redefine custom class in terms of
10715         forward_scope_exit.
10716
10717 2019-01-23  Pedro Alves  <palves@redhat.com>
10718             Andrew Burgess  <andrew.burgess@embecosm.com>
10719
10720         * common/forward-scope-exit.h: New file.
10721
10722 2019-01-23  Pedro Alves  <palves@redhat.com>
10723             Andrew Burgess  <andrew.burgess@embecosm.com>
10724             Tom Tromey  <tom@tromey.com>
10725
10726         * common/scope-exit.h: New file.
10727
10728 2019-01-23  Pedro Alves  <palves@redhat.com>
10729
10730         * common/preprocessor.h (ESC): Rename to ...
10731         (ESC_PARENS): ... this.
10732         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10733         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10734
10735 2019-01-23  Tom Tromey  <tom@tromey.com>
10736
10737         * language.h (class scoped_switch_to_sym_language_if_auto):
10738         Initialize m_lang in both cases.
10739
10740 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10741
10742         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10743         with XCNEW.
10744
10745 2019-01-22  Tom Tromey  <tom@tromey.com>
10746
10747         * corelow.c: Do not include sys/file.h.
10748
10749 2019-01-22  Tom Tromey  <tom@tromey.com>
10750
10751         * tui/tui-wingeneral.h: Include gdb_curses.h.
10752
10753 2019-01-22  Tom Tromey  <tom@tromey.com>
10754
10755         * source-cache.h (class source_cache) <get_source_lines,
10756         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10757
10758 2019-01-22  Tom Tromey  <tom@tromey.com>
10759
10760         * remote-fileio.h (struct remote_target): Declare.
10761
10762 2019-01-22  Tom Tromey  <tom@tromey.com>
10763
10764         * python/py-arch.c: Do not include py-ref.h.
10765         * python/py-bpevent.c: Do not include py-ref.h.
10766         * python/py-cmd.c: Do not include py-ref.h.
10767         * python/py-continueevent.c: Do not include py-ref.h.
10768         * python/py-event.h: Do not include py-ref.h.
10769         * python/py-evtregistry.c: Do not include py-ref.h.
10770         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10771         * python/py-frame.c: Do not include py-ref.h.
10772         * python/py-framefilter.c: Do not include py-ref.h.
10773         * python/py-function.c: Do not include py-ref.h.
10774         * python/py-infevents.c: Do not include py-ref.h.
10775         * python/py-linetable.c: Do not include py-ref.h.
10776         * python/py-objfile.c: Do not include py-ref.h.
10777         * python/py-param.c: Do not include py-ref.h.
10778         * python/py-prettyprint.c: Do not include py-ref.h.
10779         * python/py-progspace.c: Do not include py-ref.h.
10780         * python/py-symbol.c: Do not include py-ref.h.
10781         * python/py-symtab.c: Do not include py-ref.h.
10782         * python/py-type.c: Do not include py-ref.h.
10783         * python/py-unwind.c: Do not include py-ref.h.
10784         * python/py-utils.c: Do not include py-ref.h.
10785         * python/py-value.c: Do not include py-ref.h.
10786         * python/py-varobj.c: Do not include py-ref.h.
10787         * python/py-xmethods.c: Do not include py-ref.h.
10788         * python/python.c: Do not include py-ref.h.
10789         * varobj.c: Do not include py-ref.h.
10790
10791 2019-01-22  Tom Tromey  <tom@tromey.com>
10792
10793         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10794         keyword for bcache.
10795
10796 2019-01-22  Tom Tromey  <tom@tromey.com>
10797
10798         * compile/compile-cplus-types.c: Remove a comment by #include.
10799
10800 2019-01-22  Tom Tromey  <tom@tromey.com>
10801
10802         * compile/gcc-c-plugin.h: Include compile-internal.h.
10803
10804 2019-01-22  Tom Tromey  <tom@tromey.com>
10805
10806         * stabsread.c (EXTERN): Do not define.
10807         (symnum, next_symbol_text_func, processing_gcc_compilation)
10808         (within_function, global_sym_chain, global_stabs)
10809         (previous_stab_code, this_object_header_files)
10810         (n_this_object_header_files)
10811         (n_allocated_this_object_header_files): Define.
10812         * stabsread.h (EXTERN): Never define.  Use "extern".
10813
10814 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10815
10816         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10817         history_value.
10818
10819 2019-01-21  Tom Tromey  <tom@tromey.com>
10820
10821         * ui-out.c: Fix includes.
10822         * tui/tui-source.c: Fix includes.
10823         * target.c: Fix includes.
10824         * remote.c: Fix includes.
10825         * regcache.c: Fix includes.
10826         * python/py-block.c: Fix includes.
10827         * printcmd.c: Fix includes.
10828         * or1k-tdep.c: Fix includes.
10829         * mi/mi-main.c: Fix includes.
10830         * m32r-tdep.c: Fix includes.
10831         * csky-tdep.c: Fix includes.
10832         * compile/compile-cplus-types.c: Fix includes.
10833         * cli/cli-interp.c: Fix includes.
10834
10835 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10836
10837         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10838         for padding.
10839
10840 2019-01-16  Tom Tromey  <tom@tromey.com>
10841
10842         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10843         earlier.
10844         (struct objfile) <msymbols_range>: Move from top level.
10845         <msymbols>: New method.
10846         (class objfile_msymbols): Remove.
10847         * symtab.c (default_collect_symbol_completion_matches_break_on):
10848         Update.
10849         * symmisc.c (dump_msymbols): Update.
10850         * stabsread.c (scan_file_globals): Update.
10851         * objc-lang.c (info_selectors_command, info_classes_command)
10852         (find_methods): Update.
10853         * minsyms.c (find_solib_trampoline_target): Update.
10854         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10855         * coffread.c (coff_symfile_read): Update.
10856         * ada-lang.c (ada_lookup_simple_minsym)
10857         (ada_collect_symbol_completion_matches): Update.
10858
10859 2019-01-16  Tom Tromey  <tom@tromey.com>
10860
10861         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10862         type.  Remove no-argument constructor.
10863         <iterator::operator++>: Simplify.
10864         <begin>: Update.
10865         <end>: Use minimal_symbol_count.
10866
10867 2019-01-16  Tom Tromey  <tom@tromey.com>
10868
10869         * objfiles.h (struct objfile) <psymtabs>: New method.
10870         (class objfile_psymtabs): Remove.
10871         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10872         typedef.
10873         <range>: New method.
10874         (require_partial_symbols): Change return type.
10875         * psymtab.c (require_partial_symbols)
10876         (psym_expand_symtabs_matching): Update.
10877         * mdebugread.c (parse_partial_symbols): Update.
10878         * dbxread.c (dbx_end_psymtab): Update.
10879
10880 2019-01-15  Tom Tromey  <tom@tromey.com>
10881
10882         * symtab.c (lookup_objfile_from_block)
10883         (lookup_symbol_in_objfile_symtabs)
10884         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10885         (find_line_symtab, info_sources_command)
10886         (default_collect_symbol_completion_matches_break_on)
10887         (make_source_files_completion_list): Update.
10888         * symmisc.c (print_objfile_statistics, dump_objfile)
10889         (maintenance_print_symbols, maintenance_info_symtabs)
10890         (maintenance_check_symtabs, maintenance_info_line_tables):
10891         Update.
10892         * source.c (select_source_symtab)
10893         (forget_cached_source_info_for_objfile): Update.
10894         * objfiles.h (class objfile_compunits): Remove.
10895         (struct objfile) <compunits_range>: New typedef.
10896         (compunits): New method.
10897         * objfiles.c (objfile_relocate1): Update.
10898         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10899         * maint.c (count_symtabs_and_blocks): Update.
10900         * linespec.c (iterate_over_all_matching_symtabs): Update.
10901         * cp-support.c (add_symbol_overload_list_qualified): Update.
10902         * coffread.c (coff_symtab_read): Update.
10903         * ada-lang.c (add_nonlocal_symbols)
10904         (ada_collect_symbol_completion_matches)
10905         (ada_add_global_exceptions): Update.
10906
10907 2019-01-15  Tom Tromey  <tom@tromey.com>
10908
10909         * progspace.h (program_space) <objfiles_safe_range>: New
10910         typedef.
10911         <objfiles_safe>: New method.
10912         * objfiles.h (class all_objfiles_safe): Remove.
10913         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10914         * jit.c (jit_inferior_exit_hook): Update.
10915
10916 2019-01-17  Tom Tromey  <tom@tromey.com>
10917
10918         * progspace.h (program_space) <objfiles_range>: New typedef.
10919         <objfiles>: New method.
10920         <objfiles_head>: Rename from objfiles.
10921         (object_files): Update.
10922         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10923         * guile/scm-pretty-print.c
10924         (ppscm_find_pretty_printer_from_objfiles): Update.
10925         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10926         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10927         Update.
10928         * python/py-progspace.c (pspy_get_objfiles): Update.
10929         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10930         Update.
10931         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10932         (objfpy_lookup_objfile_by_build_id): Update.
10933         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10934         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10935         Update.
10936         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10937         (expand_symtab_containing_pc, lookup_objfile_from_block)
10938         (lookup_static_symbol, basic_lookup_transparent_type)
10939         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10940         (find_line_symtab, info_sources_command)
10941         (default_collect_symbol_completion_matches_break_on)
10942         (make_source_files_completion_list, find_main_name): Update.
10943         * symmisc.c (print_symbol_bcache_statistics)
10944         (print_objfile_statistics, maintenance_print_symbols)
10945         (maintenance_print_msymbols, maintenance_print_objfiles)
10946         (maintenance_info_symtabs, maintenance_check_symtabs)
10947         (maintenance_expand_symtabs, maintenance_info_line_tables):
10948         Update.
10949         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10950         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10951         (map_overlay_command, unmap_overlay_command)
10952         (simple_overlay_update, expand_symtabs_matching)
10953         (map_symbol_filenames): Update.
10954         * symfile-debug.c (set_debug_symfile): Update.
10955         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10956         Update.
10957         * source.c (select_source_symtab, forget_cached_source_info):
10958         Update.
10959         * solib.c (solib_read_symbols): Update.
10960         * solib-spu.c (append_ocl_sos): Update.
10961         * psymtab.c (maintenance_print_psymbols)
10962         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10963         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10964         * printcmd.c (info_symbol_command): Update.
10965         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10966         Update.
10967         * objfiles.h (class all_objfiles): Remove.
10968         * objfiles.c (have_partial_symbols, have_full_symbols)
10969         (have_minimal_symbols, qsort_cmp, update_section_map)
10970         (shared_objfile_contains_address_p)
10971         (default_iterate_over_objfiles_in_search_order): Update.
10972         * objc-lang.c (info_selectors_command, info_classes_command)
10973         (find_methods): Update.
10974         * minsyms.c (find_solib_trampoline_target): Update.
10975         * maint.c (maintenance_info_sections)
10976         (maintenance_translate_address, count_symtabs_and_blocks):
10977         Update.
10978         * main.c (captured_main_1): Update.
10979         * linux-thread-db.c (try_thread_db_load_from_pdir)
10980         (has_libpthread): Update.
10981         * linespec.c (iterate_over_all_matching_symtabs)
10982         (search_minsyms_for_name): Update.
10983         * jit.c (jit_find_objf_with_entry_addr): Update.
10984         * hppa-tdep.c (find_unwind_entry)
10985         (hppa_lookup_stub_minimal_symbol): Update.
10986         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10987         Update.
10988         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10989         (elf_gnu_ifunc_resolve_by_got): Update.
10990         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10991         * dwarf-index-write.c (save_gdb_index_command): Update.
10992         * cp-support.c (add_symbol_overload_list_qualified): Update.
10993         * breakpoint.c (create_overlay_event_breakpoint)
10994         (create_longjmp_master_breakpoint)
10995         (create_std_terminate_master_breakpoint)
10996         (create_exception_master_breakpoint): Update.
10997         * blockframe.c (find_pc_partial_function): Update.
10998         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10999         (ada_collect_symbol_completion_matches)
11000         (ada_add_global_exceptions): Update.
11001
11002 2019-01-17  Tom Tromey  <tom@tromey.com>
11003
11004         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11005         declare VEC.
11006         (solib_target_parse_libraries): Change return type.
11007         (library_list_start_segment, library_list_start_section)
11008         (library_list_end_library, library_list_start_library); Update.
11009         (solib_target_free_library_list): Remove.
11010         (solib_target_parse_libraries): Remove cleanup.  Change return
11011         type.
11012         (solib_target_current_sos): Update.
11013
11014 2019-01-17  Tom Tromey  <tromey@bapiya>
11015
11016         * valprint.c: Replace "the the" with "the".
11017         * symtab.c: Replace "the the" with "the".
11018         * solib.c: Replace "the the" with "the".
11019         * solib-dsbt.c: Replace "the the" with "the".
11020         * linespec.c: Replace "the the" with "the".
11021         * dwarf2loc.h: Replace "the the" with "the".
11022         * amd64-windows-tdep.c: Replace "the the" with "the".
11023         * aarch64-tdep.c: Replace "the the" with "the".
11024
11025 2019-01-16  Keith Seitz  <keiths@redhat.com>
11026
11027         PR gdb/23773
11028         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11029         <builder>: Rename to ..
11030         <m_builder>: ... this and make private.
11031         (dwarf2_cu::get_builder): New method.  Change all users of
11032         `builder' to use this method.
11033         (dwarf2_start_symtab): Move to ...
11034         (dwarf2_cu::start_symtab): ... here.  Update all callers
11035         (setup_type_unit_groups): Move to ...
11036         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11037         callers.
11038         (dwarf2_cu::reset_builder): New method.
11039         (process_full_compunit, process_full_type_unit): Use
11040         dwarf2_cu::reset_builder.
11041         (follow_die_offset): Record the ancestor CU if it is different
11042         from the followed DIE's CU.
11043         (follow_die_sig_1): Likewise.
11044
11045 2019-01-15  Tom Tromey  <tom@tromey.com>
11046
11047         * remote.c (class remote_state) <buf>: Now a char_vector.
11048         <buf_size>: Remove.
11049         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11050         parameter.
11051         (remote_target::getpkt_or_notif_sane_1)
11052         (remote_target::getpkt_sane)
11053         (remote_target::getpkt_or_notif_sane): Likewise.
11054         (class remote_target) <putpkt>: New overload.
11055         (remote_target::read_frame): Change type of "buf_p".  Remove
11056         sizeof_p parameter.
11057         (packet_ok): New overload.
11058         (packet_check_result): New overload.
11059         Update all uses.
11060
11061 2019-01-14  Tom Tromey  <tom@tromey.com>
11062
11063         * remote-notif.c (handle_notification, remote_notif_ack)
11064         (remote_notif_parse): Make "buf" const.
11065         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11066         const.
11067         (remote_notif_parse, remote_notif_ack, handle_notification):
11068         Likewise.
11069         * remote.c (remote_notif_stop_parse): Make "buf" const.
11070         (remote_target::remote_parse_stop_reply): Make "buf" const.
11071         (remote_notif_stop_ack): Make "buf" const.
11072
11073 2019-01-14  Tom Tromey  <tom@tromey.com>
11074
11075         * remote.c (remote_console_output): Make parameter const.
11076
11077 2019-01-14  Tom Tromey  <tom@tromey.com>
11078
11079         * target-debug.h (target_debug_print_signals): Constify.
11080         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11081         * procfs.c (procfs_target::pass_signals): Update.
11082         * linux-nat.c (linux_nat_target::pass_signals): Update.
11083         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11084         * target-delegates.c: Rebuild.
11085         * remote.c (remote_target::program_signals): Update.
11086         (remote_target::pass_signals): Update.
11087         * target.c (target_pass_signals): Constify argument.
11088         (target_program_signals): Likewise.
11089         * target.h (struct target_ops) <pass_signals, program_signals>:
11090         Constify argument.
11091         (target_pass_signals, target_program_signals): Constify argument.
11092
11093 2019-01-14  Tom Tromey  <tom@tromey.com>
11094
11095         PR tui/28819:
11096         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11097
11098 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11099
11100         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11101         field.
11102         * rs6000-tdep.c: Include reggroups.h.
11103         (IS_V_ALIAS_PSEUDOREG): Define.
11104         (rs6000_register_name): Return names for the "vX" aliases.
11105         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11106         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11107         aliases.  Call default_register_reggroup_p for all other
11108         pseudo-registers.
11109         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11110         New functions.
11111         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11112         Handle "vX" aliases.
11113         (v_alias_pseudo_register_collect): New function.
11114         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11115         (rs6000_gdbarch_init): Initialize "vX" aliases as
11116         pseudo-registers.  Restore registration of
11117         rs6000_pseudo_register_reggroup_p with
11118         set_tdesc_pseudo_register_reggroup_p.
11119
11120 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11121
11122         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11123         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11124         set_gdbarch_num_pseudo_regs.
11125
11126 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11127
11128         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11129         Remove arg prefixname, add do_set and do_show.
11130         Add member functions set_list and show_list.
11131         * cli/cli-style.c (class cli_style_option): Update accordingly.
11132         (style_set_list): Move to file scope.
11133         (style_show_list): Likewise.
11134         (set_style): Call help_list.
11135         (show_style): Call cmd_show_list.
11136         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11137         Update to use the new macro.
11138
11139 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11140
11141         * ada-lang.c (_initialize_ada_language): Expand the help text
11142         for the "catch exception" command.
11143
11144 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11145
11146         * symtab.c (matching_obj_sections): Initialize obj,
11147         declare it closer to its usage.
11148
11149 2019-01-10  Tom Tromey  <tom@tromey.com>
11150
11151         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11152         (basic_inf_threads_range): Remove.
11153         (inf_threads_range, inf_non_exited_threads_range)
11154         (safe_inf_threads_range): Use next_adapter.
11155
11156 2019-01-10  Keith Seitz  <keiths@redhat.com>
11157
11158         PR gdb/23712
11159         PR symtab/23010
11160         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11161         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11162
11163 2019-01-10  Keith Seitz  <keiths@redhat.com>
11164
11165         PR gdb/23712
11166         PR symtab/23010
11167         * dictionary.c (pending_to_vector): Remove.
11168         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11169         Remove _1 suffix, replacing functions of the same name.  Update
11170         all callers.
11171         (dict_create_hashed, dict_create_hashed_expandable)
11172         (dict_create_linear, dict_create_linear_expandable, dict_free)
11173         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11174         Make functions static.
11175
11176 2019-01-10  Keith Seitz  <keiths@redhat.com>
11177
11178         PR gdb/23712
11179         PR symtab/23010
11180         * dictionary.h (struct dictionary): Replace declaration with
11181         multidictionary.
11182         (dict_create_hashed, dict_create_hashed_expandable)
11183         (dict_create_linear, dict_create_linear_expandable)
11184         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11185         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11186         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11187         taking multidictionary argument.
11188         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11189         * block.h (struct block) <dict>: Change to multidictionary
11190         and rename `multidict'.
11191         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11192         symmisc.c: Update all dictionary references to multidictionary.
11193
11194 2019-01-10  Keith Seitz  <keiths@redhat.com>
11195
11196         PR gdb/23712
11197         PR symtab/23010
11198         * dictionary.c: Include unordered_map.
11199         (pending_to_vector): New function.
11200         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11201         Rewrite the non-"_1" functions to take vector instead
11202         of linked list.
11203         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11204         "new" _1 versions of the same name.
11205         (multidictionary): Define.
11206         (std::hash<enum language): New definition.
11207         (collate_pending_symbols_by_language, mdict_create_hashed)
11208         (mdict_create_hashed_expandable, mdict_create_linear)
11209         (mdict_create_linear_expandable, mdict_free)
11210         (find_language_dictionary, create_new_language_dictionary)
11211         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11212         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11213         (mdict_size, mdict_empty): New functions.
11214         * dictionary.h (mdict_iterator): Define.
11215
11216 2019-01-10  Pedro Alves  <palves@redhat.com>
11217
11218         * breakpoint.c (read_uploaded_action)
11219         (create_tracepoint_from_upload): Adjust to use
11220         gdb::unique_xmalloc_ptr.
11221         * ctf.c (ctf_write_uploaded_tp):
11222         (SET_ARRAY_FIELD): Use emplace_back.
11223         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11224         * tracefile-tfile.c (tfile_write_uploaded_tp):
11225         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11226         gdb::unique_xmalloc_ptr.
11227         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11228         at_string, cond_string, cmd_strings>: Replace char pointers
11229         with gdb::unique_xmalloc_ptr.
11230
11231 2019-01-10  Pedro Alves  <palves@redhat.com>
11232
11233         * solib-target.c (library_list_start_library): Don't xstrdup name.
11234
11235 2019-01-10  Pedro Alves  <palves@redhat.com>
11236
11237         * mdebugread.c (parse_partial_symbols): Use
11238         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11239
11240 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11241
11242         * linux-fork.c (scoped_switch_fork_info)
11243         <~scoped_switch_fork_info>: Fix incorrect variable name.
11244
11245 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11246
11247         * linux-fork.c (scoped_switch_fork_info)
11248         <scoped_switch_fork_info>: Make explicit.
11249         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11250
11251 2019-01-10  Tom Tromey  <tom@tromey.com>
11252
11253         * objfiles.h (objfile::reset_psymtabs): Update.
11254         * objfiles.c (objfile::objfile): Update.
11255         * psymtab.h (psymtab_storage::obstack): Update.
11256         (psymtab_storage::m_obstack): Use gdb::optional.
11257         (class psymtab_storage): Update comment.  Remove objfile
11258         parameter.
11259         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11260
11261 2019-01-10  Tom Tromey  <tom@tromey.com>
11262
11263         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11264         <free_psymtabs>: Now private.
11265         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11266         (allocate_psymtab): Use new method.
11267
11268 2019-01-10  Tom Tromey  <tom@tromey.com>
11269
11270         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11271         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11272         * mdebugread.c (parse_partial_symbols): Use
11273         allocate_dependencies.
11274         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11275         allocate_dependencies.
11276         (process_psymtab_comp_unit_reader)
11277         (build_type_psymtab_dependencies): Likewise.
11278         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11279
11280 2019-01-10  Tom Tromey  <tom@tromey.com>
11281
11282         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11283         PSYMBOL_SET_LANGUAGE.
11284         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11285
11286 2019-01-10  Tom Tromey  <tom@tromey.com>
11287
11288         * psymtab.h (psymtab_storage::obstack): New method.
11289         <m_obstack>: Rename from obstack; now private.
11290         * psymtab.c (psymtab_storage): Update.
11291         * dwarf2read.c (create_addrmap_from_index)
11292         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11293         Update.
11294
11295 2019-01-10  Tom Tromey  <tom@tromey.com>
11296
11297         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11298         * objfiles.h (objfile::reset_psymtabs): New method.
11299
11300 2019-01-10  Tom Tromey  <tom@tromey.com>
11301
11302         * symmisc.c (print_symbol_bcache_statistics): Update.
11303         (print_objfile_statistics): Update.
11304         * symfile.c (reread_symbols): Update.
11305         * psymtab.h (class psymtab_storage): New.
11306         * psymtab.c (psymtab_storage): New constructor.
11307         (~psymtab_storage): New destructor.
11308         (require_partial_symbols): Update.
11309         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11310         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11311         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11312         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11313         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11314         (start_psymtab_common, end_psymtab_common)
11315         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11316         (allocate_psymtab): Update.
11317         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11318         Update.
11319         (dump_psymtab_addrmap, maintenance_print_psymbols)
11320         (maintenance_check_psymtabs): Update.
11321         (class objfile_psymtabs): Move to objfiles.h.
11322         * psympriv.h (discard_psymtab): Now inline.
11323         (psymtab_discarder::psymtab_discarder): Update.
11324         (psymtab_discarder::~psymtab_discarder): Update.
11325         (ALL_OBJFILE_PSYMTABS): Rewrite.
11326         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11327         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11328         Remove fields.
11329         <partial_symtabs>: New field.
11330         (class objfile_psymtabs): Move from psymtab.h.  Update.
11331         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11332         psymbol_cache.
11333         (objfile::~objfile): Don't destroy psymbol_cache.
11334         * mdebugread.c (parse_partial_symbols): Update.
11335         * dwarf2read.c (create_addrmap_from_index)
11336         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11337         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11338         (add_partial_subprogram, dwarf2_ranges_read): Update.
11339         * dwarf-index-write.c (write_address_map)
11340         (write_one_signatured_type, recursively_write_psymbols)
11341         (class debug_names, class debug_names, write_psymtabs_to_index):
11342         Update.
11343
11344 2019-01-10  Tom Tromey  <tom@tromey.com>
11345
11346         * symtab.h (SYMBOL_SET_NAMES): Update.
11347         (symbol_set_names): Update.
11348         (MSYMBOL_SET_NAMES): Update.
11349         * symtab.c (symbol_set_names): Change argument to be an
11350         objfile_per_bfd_storage.
11351         * psymtab.c (add_psymbol_to_bcache): Update.
11352         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11353
11354 2019-01-10  Tom Tromey  <tom@tromey.com>
11355
11356         * symtab.c (create_demangled_names_hash): Change argument to be an
11357         objfile_per_bfd_storage.
11358         (symbol_set_names): Update.
11359
11360 2019-01-10  Tom Tromey  <tom@tromey.com>
11361
11362         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11363         init_psymbol_list.
11364         * psymtab.c (init_psymbol_list): Do nothing if already called.
11365         * psympriv.h (init_psymbol_list): Add comment.
11366         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11367         init_psymbol_list.
11368         * dbxread.c (dbx_symfile_read): Unconditionally call
11369         init_psymbol_list.
11370
11371 2019-01-10  Tom Tromey  <tom@tromey.com>
11372
11373         * xcoffread.c (scan_xcoff_symtab): Update.
11374         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11375         "where".
11376         * mdebugread.c (parse_partial_symbols)
11377         (handle_psymbol_enumerators): Update.
11378         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11379         * dbxread.c (read_dbx_symtab): Update.
11380         * psympriv.h (psymbol_placement): New enum.
11381         (add_psymbol_to_list): Update.
11382
11383 2019-01-10  Tom Tromey  <tom@tromey.com>
11384
11385         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11386         static_psymbols parameters.
11387         (scan_xcoff_symtab): Update.
11388         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11389         static_psymbols parameters.
11390         * psympriv.h (start_psymtab_common): Update.
11391         * mdebugread.c (parse_partial_symbols): Update.
11392         * dwarf2read.c (create_partial_symtab): Update.
11393         * dbxread.c (read_dbx_symtab): Update.
11394         (start_psymtab): Remove global_psymbols and static_psymbols
11395         parameters.
11396
11397 2019-01-10  Tom Tromey  <tom@tromey.com>
11398
11399         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11400         * psymtab.c (allocate_psymtab): Add comment.
11401         * psympriv.h (allocate_psymtab): Add comment.
11402         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11403         initializations.
11404         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11405
11406 2019-01-10  Tom Tromey  <tom@tromey.com>
11407
11408         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11409         Don't declare.
11410         * mipsread.c: Include mdebugread.h.
11411         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11412         Declare.
11413         * elfread.c: Include mdebugread.h.
11414
11415 2019-01-09  Tom Tromey  <tom@tromey.com>
11416
11417         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11418         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11419         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11420         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11421         (psym_lookup_symbol, psym_find_last_source_symtab)
11422         (psym_forget_cached_source_info, psym_print_stats)
11423         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11424         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11425         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11426         (psym_find_compunit_symtab_by_address)
11427         (maintenance_print_psymbols, maintenance_info_psymtabs)
11428         (maintenance_check_psymtabs): Use ranged for.
11429         * psymtab.h (class objfile_psymtabs): New.
11430         (require_partial_symbols): Return objfile_psymtabs.
11431         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11432
11433 2019-01-09  Tom Tromey  <tom@tromey.com>
11434
11435         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11436         (find_pc_mapped_section, list_overlays_command)
11437         (map_overlay_command, unmap_overlay_command)
11438         (simple_overlay_update): Use all_objfiles.
11439         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11440         * printcmd.c (info_symbol_command): Use all_objfiles.
11441         * objfiles.h (ALL_OBJSECTIONS): Remove.
11442         * maint.c (maintenance_translate_address): Use all_objfiles.
11443         * gcore.c (gcore_create_callback): Use all_objfiles.
11444         (objfile_find_memory_regions): Likewise.
11445
11446 2019-01-09  Tom Tromey  <tom@tromey.com>
11447
11448         * symtab.c (find_line_symtab, info_sources_command)
11449         (make_source_files_completion_list): Use objfile_compunits.
11450         * source.c (select_source_symtab): Use objfile_compunits.
11451         * objfiles.h (struct objfile): Update comment.
11452         (ALL_OBJFILES): Remove.
11453         (ALL_FILETABS): Remove.
11454         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11455         objfile_compunits.
11456
11457 2019-01-09  Tom Tromey  <tom@tromey.com>
11458
11459         * symmisc.c (print_objfile_statistics, dump_objfile)
11460         (maintenance_print_symbols): Use compunit_filetabs.
11461         * source.c (forget_cached_source_info_for_objfile): Use
11462         compunit_filetabs.
11463         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11464         (ALL_FILETABS): Use compunit_filetabs.
11465         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11466         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11467
11468 2019-01-09  Tom Tromey  <tom@tromey.com>
11469
11470         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11471         (compunit_filetabs): New.
11472         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11473         compunit_filetabs.
11474         (info_sources_command, make_source_files_completion_list): Remove
11475         declaration.
11476         * symmisc.c (print_objfile_statistics, dump_objfile)
11477         (maintenance_print_symbols): Remove declaration.
11478         (maintenance_info_symtabs): Use compunit_filetabs.
11479         (maintenance_info_line_tables): Likewise.
11480         * source.c (select_source_symtab): Change local variable name.
11481         (forget_cached_source_info_for_objfile): Remove declaration.
11482         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11483         * objfiles.c (objfile_relocate1): Remove declaration.
11484         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11485         declaration.
11486         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11487         * coffread.c (coff_symtab_read): Remove declaration.
11488         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11489         compunit_filetabs.
11490
11491 2019-01-09  Tom Tromey  <tom@tromey.com>
11492
11493         * symtab.c (lookup_objfile_from_block)
11494         (find_pc_sect_compunit_symtab, search_symbols)
11495         (default_collect_symbol_completion_matches_break_on): Use
11496         objfile_compunits.
11497         * objfiles.h (ALL_COMPUNITS): Remove.
11498         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11499         * cp-support.c (add_symbol_overload_list_qualified): Use
11500         objfile_compunits.
11501         * ada-lang.c (ada_collect_symbol_completion_matches)
11502         (ada_add_global_exceptions): Use objfile_compunits.
11503
11504 2019-01-09  Tom Tromey  <tom@tromey.com>
11505
11506         * source.c (select_source_symtab)
11507         (forget_cached_source_info_for_objfile): Remove declaration.
11508         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11509         declaration.
11510         * maint.c (count_symtabs_and_blocks): Remove declaration.
11511         * cp-support.c (add_symbol_overload_list_qualified): Remove
11512         declaration.
11513         * coffread.c (coff_symtab_read): Remove declaration.
11514         * symtab.c (lookup_symbol_in_objfile_symtabs)
11515         (basic_lookup_transparent_type_1): Use objfile_compunits.
11516         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11517         (info_sources_command, search_symbols)
11518         (default_collect_symbol_completion_matches_break_on)
11519         (make_source_files_completion_list): Remove declaration.
11520         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11521         (ada_collect_symbol_completion_matches)
11522         (ada_add_global_exceptions): Remove declaration.
11523         * linespec.c (iterate_over_all_matching_symtabs): Use
11524         objfile_compunits.
11525         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11526         (class objfile_compunits): New.
11527         (ALL_COMPUNITS): Use objfile_compunits.
11528         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11529         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11530         objfile_compunits.
11531         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11532
11533 2019-01-09  Tom Tromey  <tom@tromey.com>
11534
11535         * symtab.c (search_symbols)
11536         (default_collect_symbol_completion_matches_break_on): Use
11537         objfile_msymbols.
11538         * ada-lang.c (ada_lookup_simple_minsym)
11539         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11540         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11541         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11542         objfile_msymbols.
11543         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11544         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11545         * objc-lang.c (find_methods): Use objfile_msymbols.
11546         (info_selectors_command, info_classes_command): Likewise.
11547         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11548         * objfiles.h (class objfile_msymbols): New.
11549         (ALL_OBJFILE_MSYMBOLS): Remove.
11550         (ALL_MSYMBOLS): Remove.
11551
11552 2019-01-09  Tom Tromey  <tom@tromey.com>
11553
11554         * common/next-iterator.h (next_adapter): Add Iterator template
11555         parameter.
11556         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11557         (class all_objfiles_safe): New.
11558         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11559         * objfiles.c (put_objfile_before): Update comment.
11560         (add_separate_debug_objfile): Likewise.
11561         (free_all_objfiles): Use all_objfiles_safe.
11562         (objfile_purge_solibs): Likewise.
11563
11564 2019-01-09  Tom Tromey  <tom@tromey.com>
11565
11566         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11567         (expand_symtab_containing_pc, lookup_static_symbol)
11568         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11569         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11570         all_objfiles.
11571         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11572         * breakpoint.c (create_overlay_event_breakpoint)
11573         (create_longjmp_master_breakpoint)
11574         (create_std_terminate_master_breakpoint)
11575         (create_exception_master_breakpoint): Use all_objfiles.
11576         * linux-thread-db.c (try_thread_db_load_from_pdir)
11577         (has_libpthread): Use all_objfiles.
11578         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11579         * linespec.c (iterate_over_all_matching_symtabs)
11580         (search_minsyms_for_name): Use all_objfiles.
11581         * maint.c (maintenance_info_sections): Use all_objfiles.
11582         * main.c (captured_main_1): Use all_objfiles.
11583         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11584         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11585         * guile/scm-pretty-print.c
11586         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11587         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11588         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11589         (maintenance_print_msymbols): Use all_objfiles.
11590         * source.c (select_source_symtab): Use all_objfiles.
11591         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11592         * symfile.c (remove_symbol_file_command)
11593         (expand_symtabs_matching, map_symbol_filenames): Use
11594         all_objfiles.
11595         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11596         all_objfiles.
11597         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11598         * objc-lang.c (find_methods): Use all_objfiles.
11599         * objfiles.c (have_partial_symbols, have_full_symbols)
11600         (have_minimal_symbols, qsort_cmp)
11601         (default_iterate_over_objfiles_in_search_order): Use
11602         all_objfiles.
11603         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11604         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11605         (maintenance_check_psymtabs): Use all_objfiles.
11606         (ALL_PSYMTABS): Remove.
11607         * compile/compile-object-run.c (do_module_cleanup): Use
11608         all_objfiles.
11609         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11610         * cp-support.c (add_symbol_overload_list_qualified): Use
11611         all_objfiles.
11612         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11613         Use all_objfiles.
11614         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11615         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11616         all_objfiles.
11617         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11618         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11619         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11620         Uses all_objfiles.
11621         * solib.c (solib_read_symbols): Use all_objfiles
11622
11623 2019-01-09  Tom Tromey  <tom@tromey.com>
11624
11625         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11626         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11627         all_objfiles.
11628         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11629         * symmisc.c (print_symbol_bcache_statistics)
11630         (print_objfile_statistics, maintenance_print_objfiles)
11631         (maintenance_info_symtabs, maintenance_check_symtabs)
11632         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11633         all_objfiles.
11634         * source.c (forget_cached_source_info): Use all_objfiles.
11635         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11636         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11637         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11638         * objfiles.c (update_section_map): Use all_objfiles.
11639         (shared_objfile_contains_address_p): Likewise.
11640         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11641         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11642
11643 2019-01-09  Tom Tromey  <tom@tromey.com>
11644
11645         * common/next-iterator.h: New file.
11646         * objfiles.h (class all_objfiles): New.
11647         (struct objfile_iterator): New.
11648
11649 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11650
11651         * NEWS: Move the description of the changed "frame", "select-frame",
11652          and "info frame" commands to the Changed commands section.
11653
11654 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11655
11656         * gdbtypes.c (check_stub_method_group): Remove handling of old
11657         mangling schemes.
11658         * linespec.c (find_methods): Likewise.
11659         * stabsread.c (read_member_functions): Likewise.
11660         * valops.c (search_struct_method): Likewise.
11661         (value_struct_elt_for_reference): Likewise.
11662         * NEWS: Mention this change.
11663
11664 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11665
11666         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11667         print_source_lines.
11668         * source.c (print_source_lines_base): Update line number check.
11669         (print_source_lines): New function.
11670         (source_lines_range::source_lines_range): New function.
11671         * source.h (class source_lines_range): New class.
11672         (print_source_lines): New declaration.
11673
11674 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11675
11676         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11677
11678 2019-01-08  Tom Tromey  <tom@tromey.com>
11679             Simon Marchi  <simon.marchi@ericsson.com>
11680
11681         PR gdb/24060
11682         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11683         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11684         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11685         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11686         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11687         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11688
11689 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11690
11691         * source.c (select_source_symtab): Move header comment to
11692         declaration in source.h.
11693         (forget_cached_source_info_for_objfile): Likewise.
11694         (forget_cached_source_info): Likewise.
11695         (identify_source_line): Likewise.
11696         * source.h (identify_source_line): Move declaration from symtab.h
11697         and add comment from source.c
11698         (print_source_lines): Likewise.
11699         (forget_cached_source_info_for_objfile): Likewise.
11700         (forget_cached_source_info): Likewise.
11701         (select_source_symtab): Likewise.
11702         (enum print_source_lines_flag): Move definition from symtab.h.
11703         * symtab.h (identify_source_line): Move declaration to source.h.
11704         (print_source_lines): Likewise.
11705         (forget_cached_source_info_for_objfile): Likewise.
11706         (forget_cached_source_info): Likewise.
11707         (select_source_symtab): Likewise.
11708         (enum print_source_lines_flag): Move definition to source.h.
11709         * tui/tui-hooks.c: Add 'source.h' include.
11710
11711 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11712
11713         * source.c (print_source_lines_base): Handle requests to print
11714         reverse line number sequences, and guard against empty lines
11715         string.
11716
11717 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11718
11719         * source.c (print_source_lines_base): Fix skip of '\r' if next
11720         character is '\n'.
11721
11722 2019-01-06  Tom Tromey  <tom@tromey.com>
11723
11724         * c-exp.y (struct c_parse_state) <macro_original_text,
11725         expansion_obstack>: New member.
11726         (macro_original_text, expansion_obstack): Remove globals.
11727         (scan_macro_expansion, scanning_macro_expansion)
11728         (finished_macro_expansion): Update.
11729         (scan_macro_cleanup): Remove.
11730         (yylex, c_parse): Update.
11731
11732 2019-01-06  Tom Tromey  <tom@tromey.com>
11733
11734         * c-exp.y (struct c_parse_state) <strings>: New member.
11735         (operator_stoken): Update.
11736
11737 2019-01-06  Tom Tromey  <tom@tromey.com>
11738
11739         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11740         (union type_stack_elt) <typelist_val>: Now a pointer to
11741         std::vector.
11742         (type_stack_cleanup): Don't declare.
11743         (push_typelist): Update.
11744         * parse.c (pop_typelist): Return a std::vector.
11745         (push_typelist): Take a std::vector.
11746         (follow_types): Update.  Do not free args.
11747         (type_stack_cleanup): Remove.
11748         * c-exp.y (struct c_parse_state): New.
11749         (cpstate): New global.
11750         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11751         (nonempty_typelist): Update.
11752         (func_mod): Create a new vector.
11753         (c_parse): Create a c_parse_state.
11754         (check_parameter_typelist): Do not delete params.
11755         (function_method): Update.  Do not delete type_list.
11756
11757 2019-01-06  Tom Tromey  <tom@tromey.com>
11758
11759         PR gdb/28155:
11760         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11761         check_typedef.
11762         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11763         (print_return_value): Likewise.
11764
11765 2019-01-05  Tom Tromey  <tom@tromey.com>
11766
11767         * contrib/cleanup_check.py: Remove.
11768         * contrib/gcc-with-excheck: Remove.
11769         * contrib/exsummary.py: Remove.
11770         * contrib/excheck.py: Remove.
11771
11772 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11773
11774         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11775         NULL. Initialize tpprev to NULL instead of assigning it
11776         to NULL on the next statement.
11777         * windows-nat.c (windows_delete_thread): Remove check for
11778         main_thread_id before printing thread exit notifications.
11779         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11780         Remove thread ID check against main_thread_id.
11781         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11782         windows_delete_thread.
11783         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11784
11785 2019-01-04  Tom Tromey  <tom@tromey.com>
11786
11787         * compile/compile.c (_initialize_compile): Use upper case for
11788         metasyntactic variables.
11789         * symmisc.c (_initialize_symmisc): Use upper case for
11790         metasyntactic variables.
11791         * psymtab.c (_initialize_psymtab): Use upper case for
11792         metasyntactic variables.
11793         * demangle.c (demangle_command): Use upper case for metasyntactic
11794         variables.
11795         (_initialize_demangler): Likewise.
11796         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11797         variables.
11798
11799 2019-01-03  Tom Tromey  <tom@tromey.com>
11800
11801         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11802
11803 2019-01-03  Tom Tromey  <tom@tromey.com>
11804
11805         * python/py-symtab.c (salpy_str): Update.
11806         (struct salpy_sal_object) <symtab>: Now a PyObject.
11807         (salpy_dealloc): Update.
11808         (del_objfile_sal): Use gdbpy_ref.
11809
11810 2019-01-03  Tom Tromey  <tom@tromey.com>
11811
11812         * python/py-type.c (convert_field): Use new_reference.  Return
11813         gdbpy_ref.
11814         (make_fielditem): Return gdbpy_ref.
11815         (typy_fields): Update.
11816         (typy_getitem): Update.
11817         (field_name): Return gdbpy_ref.  Use new_reference.
11818         (typy_iterator_iternext): Update.
11819
11820 2019-01-03  Tom Tromey  <tom@tromey.com>
11821
11822         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11823
11824 2019-01-03  Tom Tromey  <tom@tromey.com>
11825
11826         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11827         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11828         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11829         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11830         (pspy_set_type_printers): Likewise.
11831         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11832         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11833         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11834         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11835         (objfpy_set_type_printers): Likewise.
11836
11837 2019-01-03  Tom Tromey  <tom@tromey.com>
11838
11839         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11840         (gdbpy_print_stack): Use gdbpy_err_fetch.
11841         * python/python-internal.h (class gdbpy_err_fetch): New class.
11842         (class gdbpy_enter) <m_error_type, m_error_value,
11843         m_error_traceback>: Remove.
11844         <m_error>: New member.
11845         (gdbpy_exception_to_string): Don't declare.
11846         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11847         * python/py-value.c (convert_value_from_python): Use
11848         gdbpy_err_fetch.
11849         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11850         gdbpy_exception_to_string.
11851         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11852         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11853         gdbpy_err_fetch.
11854
11855 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11856
11857         * linux-nat.c (delete_lwp_cleanup): Delete.
11858         (struct lwp_deleter): New struct.
11859         (lwp_info_up): New typedef.
11860         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11861         lwp_info_up.
11862
11863 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11864
11865         * linux-fork.c (class scoped_switch_fork_info): New class.
11866         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11867
11868 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11869
11870         * valops.c (find_overload_match): Remove use of null_cleanup, and
11871         calls to do_cleanups.
11872
11873 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11874
11875         * compile/compile-cplus-types.c
11876         (compile_cplus_instance::decl_name): Handle changes to
11877         cp_func_name.
11878         * cp-support.c (cp_func_name): Update header comment, update
11879         return type.
11880         * cp-support.h (cp_func_name): Update return type in declaration.
11881         * valops.c (find_overload_match): Move temp_func local to top
11882         level of function and change its type.  Use temp_func to hold and
11883         delete temporary string obtained from cp_func_name.
11884
11885 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11886
11887         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11888         gdb::char_vector, remove cleanup, and update uses of `msg`.
11889
11890 2019-01-03  Jim Wilson  <jimw@sifive.com>
11891
11892         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11893
11894 2019-01-02  Tom Tromey  <tom@tromey.com>
11895
11896         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11897         (tdesc_parse_xml): Remove cleanups.
11898         * target-descriptions.h (make_cleanup_free_target_description):
11899         Don't declare.
11900         (target_desc_deleter): New struct.
11901         (target_desc_up): New typedef.
11902         * target-descriptions.c (target_desc_deleter::operator()): Rename
11903         from free_target_description.
11904         (make_cleanup_free_target_description): Remove.
11905
11906 2019-01-02  Tom Tromey  <tom@tromey.com>
11907
11908         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11909         constructor, destructor.
11910         (linespec_parser): Remove typedef.
11911         (~linespec_parser): Rename from linespec_parser_delete.
11912         (linespec_lex_to_end, linespec_complete_label)
11913         (linespec_complete): Update.
11914         (decode_line_full): Remove cleanups.
11915         (decode_line_1): Update.
11916
11917 2019-01-02  Tom Tromey  <tom@tromey.com>
11918
11919         * python/python-internal.h (inferior_to_inferior_object): Change
11920         return type.
11921         * python/py-exitedevent.c (create_exited_event_object): Update.
11922         * python/py-inferior.c (inferior_to_inferior_object): Return
11923         gdbpy_ref.
11924         (python_new_inferior, python_inferior_deleted)
11925         (thread_to_thread_object, delete_thread_object)
11926         (build_inferior_list, gdbpy_selected_inferior): Update.
11927         * python/py-infthread.c (create_thread_object): Update.  Also fail
11928         if inferior_to_inferior_object fails.
11929
11930 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11931
11932         * inferior.h (class inferior) <displaced_step_state>: New field.
11933         * infrun.h (struct displaced_step_state): Move here from
11934         infrun.c.  Initialize fields, add constructor.
11935         <inf>: Remove field.
11936         <reset>: New method.
11937         * infrun.c (struct displaced_step_inferior_state): Move to
11938         infrun.h.
11939         (displaced_step_inferior_states): Remove.
11940         (get_displaced_stepping_state): Adust.
11941         (displaced_step_in_progress_any_inferior): Adjust.
11942         (displaced_step_in_progress_thread): Adjust.
11943         (displaced_step_in_progress): Adjust.
11944         (add_displaced_stepping_state): Remove.
11945         (get_displaced_step_closure_by_addr): Adjust.
11946         (remove_displaced_stepping_state): Remove.
11947         (infrun_inferior_exit): Call displaced_step_state.reset.
11948         (use_displaced_stepping): Don't check for NULL.
11949         (displaced_step_prepare_throw): Call
11950         get_displaced_stepping_state.
11951         (displaced_step_fixup): Don't check for NULL.
11952         (prepare_for_detach): Don't check for NULL.
11953
11954 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11955
11956         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11957          in case of call that did not complete.
11958
11959 2019-01-02  Andrey Utkin  <autkin@undo.io>
11960
11961         * symfile.c (find_separate_debug_file): Fix search of debug files for
11962         remote debuggee.
11963
11964 2019-01-02  Tom Tromey  <tom@tromey.com>
11965
11966         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11967         indentation.
11968         * python/py-frame.c (frapy_older): Remove cast.
11969         (frapy_newer): Likewise.
11970         * python/py-breakpoint.c (local_setattro): Remove cast.
11971         * python/py-arch.c (archpy_name): Remove local variable.
11972         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11973
11974 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11975
11976         * unittests/basic_string_view/element_access/char/empty.cc:
11977         Fix year range in copyright header.
11978
11979 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11980
11981         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11982         Delete.
11983         <operator==>: Update with for removed field.
11984         <hash>: Likewise.
11985         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11986         <isa_features>: ...this.
11987         <abi_features>: New field.
11988         (riscv_isa_flen): Update comment.
11989         (riscv_abi_xlen): New declaration.
11990         (riscv_abi_flen): New declaration.
11991         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11992         isa_features.
11993         (riscv_abi_xlen): New function.
11994         (riscv_isa_flen): Update to get answer from isa_features.
11995         (riscv_abi_flen): New function.
11996         (riscv_has_fp_abi): Update to get answer from abi_features.
11997         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11998         xlen and flen.
11999         (riscv_call_info) <xlen, flen>: Update comment.
12000         (riscv_call_arg_struct): Remove invalid assertions
12001         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12002         is removed.
12003         (riscv_gdbarch_init): Gather isa features and abi features
12004         separately, ensure both match on the gdbarch when reusing an old
12005         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12006         a target with 64-bit float hardware.
12007
12008 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12009
12010         * source.c (search_command_helper): Stop reverse search
12011         when line 1 has been searched.
12012
12013 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12014
12015         * record-full.c (record_full_base_target::close): Rewrite
12016         record_full_core_buf_list free logic.
12017
12018 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12019
12020         * break-catch-syscall.c (print_one_catch_syscall): xfree
12021         the last text.
12022
12023 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12024
12025         * top.c (print_gdb_version): Update Copyright year in version
12026         message.
12027
12028 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12029
12030         Update copyright year range in all GDB files.
12031
12032 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12033
12034         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12035
12036 For older changes see ChangeLog-2018.
12037 \f
12038 Local Variables:
12039 mode: change-log
12040 left-margin: 8
12041 fill-column: 74
12042 version-control: never
12043 coding: utf-8
12044 End:
12045