gdb/ChangeLog

   1 2019-08-19  Tom Tromey  <tromey@adacore.com>
   2
   3         * python/py-value.c (value_has_field): Fix indentation.
   4
   5 2019-08-19  Tom Tromey  <tromey@adacore.com>
   6
   7         * printcmd.c (do_one_display, info_display_command): Update.
   8         * block.h (contained_in): Return bool.  Add allow_nested
   9         parameter.
  10         * block.c (contained_in): Return bool.  Add allow_nested
  11         parameter.
  12
  13 2019-08-19  Tom Tromey  <tom@tromey.com>
  14
  15         * configure: Rebuild.
  16         * configure.ac: Disallow the combination of -static-libstdc++ and
  17         source highlight.
  18         * source-cache.c (get_language_name): Handle rust.
  19         (source_cache::get_source_lines): Ignore highlighting exceptions.
  20
  21 2019-08-16  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
  24         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
  25         (struct tui_source_window_base) <make_visible, refresh_window,
  26         resize>: Remove methods.
  27         <execution_info>: Remove field.
  28         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
  29         (tui_show_source_line, tui_source_window_base)
  30         (~tui_source_window_base): Update.
  31         (tui_source_window_base::resize)
  32         (tui_source_window_base::make_visible)
  33         (tui_source_window_base::refresh_window): Remove.
  34         (tui_source_window_base::update_exec_info): Update.
  35         * tui/tui-source.c (tui_source_window::set_contents): Update.
  36         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  37
  38 2019-08-16  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-hooks.c (tui_remove_hooks): Don't set
  41         deprecated_query_hook.
  42
  43 2019-08-16  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  46         (tui_update_source_windows_with_line): Update.
  47         * tui/tui-source.h (struct tui_source_window)
  48         <show_symtab_source>: Declare.
  49         (tui_show_symtab_source): Don't declare.
  50         * tui/tui-source.c (tui_show_symtab_source): Rename from
  51         tui_show_symtab_source.
  52
  53 2019-08-16  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-winsource.h (struct tui_source_window_base)
  56         <set_contents>: Declare.
  57         * tui/tui-winsource.c
  58         (tui_source_window_base::update_source_window_as_is): Update.
  59         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  60         Declare.
  61         (tui_set_source_content): Don't declare.
  62         * tui/tui-source.c (tui_source_window::set_contents): Rename from
  63         tui_set_source_content.
  64         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  65         Declare.
  66         (tui_set_disassem_content): Don't declare.
  67         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
  68         tui_set_disassem_content.
  69
  70 2019-08-16  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-winsource.h (struct tui_source_window_base)
  73         <update_breakpoint_info>: Declare.
  74         (tui_update_breakpoint_info): Don't declare.
  75         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
  76         (tui_update_all_breakpoint_info): Update.
  77         (tui_source_window_base::update_breakpoint_info): Rename from
  78         tui_update_breakpoint_info.
  79         (tui_source_window_base::update_exec_info): Update.
  80
  81 2019-08-16  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-winsource.h (struct tui_source_window_base)
  84         <update_source_window>: Declare.
  85         (tui_update_source_window): Don't declare.
  86         * tui/tui-winsource.c
  87         (tui_source_window_base::update_source_window): Rename from
  88         tui_update_source_window.
  89         (tui_source_window_base::rerender): Update.
  90         * tui/tui-source.c (tui_source_window::maybe_update): Update.
  91         * tui/tui-disasm.c (tui_show_disassem)
  92         (tui_show_disassem_and_update_source)
  93         (tui_disasm_window::maybe_update): Update.
  94
  95 2019-08-16  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-winsource.h (struct tui_source_window_base)
  98         <update_source_window_as_is>: Declare.
  99         (tui_update_source_window_as_is): Don't declare.
 100         * tui/tui-winsource.c (tui_update_source_window): Update
 101         (tui_source_window_base::update_source_window_as_is): Rename from
 102         tui_update_source_window_as_is.
 103         (tui_source_window_base::refill): Update.
 104         * tui/tui-source.c (tui_show_symtab_source): Update.
 105         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 106         Update.
 107
 108 2019-08-16  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-winsource.h (tui_update_source_window)
 111         (tui_update_source_window_as_is): Remove "noerror" parameter.
 112         * tui/tui-winsource.c (tui_update_source_window)
 113         (tui_update_source_window_as_is): Remove "noerror" parameter.
 114         (tui_update_source_windows_with_addr)
 115         (tui_update_source_windows_with_line)
 116         (tui_source_window_base::rerender)
 117         (tui_source_window_base::refill): Update.
 118         * tui/tui-source.h (tui_set_source_content)
 119         (tui_show_symtab_source): Remove "noerror" parameter.
 120         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 121         parameter.
 122         (tui_show_symtab_source): Likewise.
 123         (tui_source_window::maybe_update): Update.
 124         * tui/tui-disasm.c (tui_show_disassem)
 125         (tui_show_disassem_and_update_source)
 126         (tui_disasm_window::do_scroll_vertical)
 127         (tui_disasm_window::maybe_update): Update.
 128
 129 2019-08-16  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui.c (tui_is_window_visible): Update.
 132         * tui/tui-wingeneral.c (tui_make_window)
 133         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 134         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 135         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 136         (tui_set_win_height_command, parse_scrolling_args): Update.
 137         * tui/tui-source.c (tui_source_window::style_changed): Update.
 138         * tui/tui-regs.c (tui_show_registers)
 139         (tui_data_window::first_data_item_displayed)
 140         (tui_data_window::delete_data_content_windows)
 141         (tui_check_register_values, tui_reg_command): Update.
 142         * tui/tui-disasm.c (tui_show_disassem): Update.
 143         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 144         method.
 145         <is_visible>: Remove field.
 146         * tui/tui-data.c (tui_next_win, tui_prev_win)
 147         (tui_delete_invisible_windows): Update.
 148
 149 2019-08-16  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-winsource.h (struct tui_source_window_base)
 152         <m_has_locator>: Remove.
 153         * tui/tui-layout.c (show_source_disasm_command, show_data)
 154         (show_source_or_disasm_and_command): Update.
 155
 156 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 157
 158         * NEWS (Other MI changes): New subsection.
 159         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 160         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 161         * arch-utils.c (default_get_pc_address_flags): New function.
 162         * arch-utils.h (default_get_pc_address_flags): New declaration.
 163         * gdbarch.sh: Add get_pc_address_flags.
 164         * gdbarch.c: Regenerate.
 165         * gdbarch.h: Likewise.
 166         * stack.c (print_pc): New function.
 167         (print_frame_info) (print_frame): Call print_pc.
 168
 169 2019-08-16  Tom de Vries  <tdevries@suse.de>
 170
 171         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 172         print_objfile_section_info.
 173
 174 2019-08-15  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 177         calling update_cmdwin_start_line.
 178         * tui/tui-winsource.h (struct tui_source_window_base)
 179         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 180         <rerender>: Declare.
 181         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 182         Call rerender.
 183         (tui_source_window_base::set_new_height): Remove.
 184         (tui_source_window_base::rerender): Rename from
 185         do_make_visible_with_new_height.
 186         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 187         resize method.
 188         (tui_win_info::make_invisible_and_set_new_height)
 189         (tui_win_info::make_visible_with_new_height): Remove.
 190         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 191         Declare.
 192         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 193         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 194         do_make_visible_with_new_height>: Don't declare.
 195         <rerender>: Declare.
 196         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 197         set_new_height.
 198         (tui_data_window::do_make_visible_with_new_height): Remove.
 199         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 200         call tui_show_locator_content.
 201         (tui_gen_win_info::resize): Call rerender.
 202         (show_source_or_disasm_and_command): Don't call
 203         tui_show_locator_content.
 204         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 205         method.
 206         (struct tui_win_info) <rerender>: Declare.
 207         <set_new_height, make_invisible_and_set_new_height,
 208         make_visible_with_new_height>: Don't declare.
 209         * tui/tui-data.c (tui_win_list::rerender): New method.
 210         * tui/tui-command.h (struct tui_cmd_window)
 211         <do_make_visible_with_new_height>: Don't declare.
 212         * tui/tui-command.c
 213         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 214
 215 2019-08-15  Tom Tromey  <tromey@adacore.com>
 216
 217         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 218         * ada-lang.c (ada_enum_name): Likewise.
 219
 220 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 221
 222         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 223         leading underscore.
 224         (GdbOutputErrorFile): Likewise.
 225         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 226         accordingly.
 227         (execute_unwinders): Rename to have a leading underscore.
 228         (auto_load_packages): Likewise.
 229         (global scope): Adjust call to auto_load_packages accordingly.
 230         (GdbSetPythonDirectory): Likewise.
 231         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 232         instead of execute_unwinders.
 233
 234 2019-08-15  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 237         (show_data): Don't change window visibility.
 238         (tui_gen_win_info::resize): Remove special case for command
 239         window.  Use wresize, when available.
 240         (show_source_or_disasm_and_command): Don't change window
 241         visibility.
 242         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 243         <make_visible>: New method.
 244         * tui/tui-command.c (tui_cmd_window::resize): New method.
 245
 246 2019-08-15  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 249         (struct tui_source_windows): New.
 250         * tui/tui-winsource.c (tui_display_main): Update.
 251         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 252         (new_height_ok, parse_scrolling_args): Update.
 253         * tui/tui-layout.c (show_layout, show_data): Update.
 254         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 255         (tui_add_to_source_windows): Don't declare.
 256         * tui/tui-data.c (source_windows, tui_source_windows)
 257         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 258
 259 2019-08-15  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 262         Rename from reset.
 263         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 264         * tui/tui-layout.c (show_source_disasm_command, show_data):
 265         Update.
 266         (tui_gen_win_info::resize): Rename.
 267         (show_source_or_disasm_and_command): Update.
 268         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 269         reset.
 270
 271 2019-08-15  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 274         * tui/tui-interp.c (tui_interp::init): Don't call
 275         tui_initialize_static_data.
 276         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 277
 278 2019-08-15  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 281         examine tui_win_list.
 282
 283 2019-08-15  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 286         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 287         tui_clear_source_content.
 288         (tui_clear_source_content): Remove.
 289         (tui_source_window_base::do_erase_source_content): Hoist call to
 290         content.clear().
 291         * tui/tui-stack.c (tui_show_frame_info): Don't call
 292         tui_clear_source_content.
 293
 294 2019-08-15  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-winsource.h (struct tui_source_window_base)
 297         <do_erase_source_content>: New method.
 298         <erase_source_content>: New method.
 299         (tui_erase_source_content): Don't declare.
 300         * tui/tui-winsource.c (tui_clear_source_content): Update.
 301         (tui_source_window_base::do_erase_source_content): Rename from
 302         tui_erase_source_content.
 303         (tui_source_window_base::show_source_content): Update.
 304         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 305         * tui/tui-source.h (struct tui_source_window)
 306         <erase_source_content>: New method.
 307         * tui/tui-disasm.h (struct tui_disasm_window)
 308         <erase_source_content>: New method.
 309
 310 2019-08-15  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 313         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 314         constructor.
 315         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 316         * tui/tui-source.c (tui_set_source_content): Update.
 317         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 318
 319 2019-08-15  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 322         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 323         tui-source.c.
 324         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 325         Declare.
 326         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 327         method.
 328         (tui_source_window::maybe_update): Update.
 329
 330 2019-08-15  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 333         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 334         tui-disasm.c.
 335         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 336         Declare.
 337         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 338         method.
 339         (tui_disasm_window::maybe_update): Update.
 340
 341 2019-08-15  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-winsource.h (struct tui_source_window_base)
 344         <maybe_update>: Declare.
 345         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 346         method.
 347         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 348         Declare.
 349         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 350         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 351         Declare.
 352         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 353
 354 2019-08-15  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 357
 358 2019-08-15  Tom Tromey  <tom@tromey.com>
 359
 360         * tui/tui-wingeneral.c: Include tui-stack.h.
 361         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 362         (struct tui_locator_window): Move from tui-data.h.
 363         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 364         (tui_initialize_static_data): Move from tui-data.c.
 365         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 366         (struct tui_locator_window): Move to tui-stack.c.
 367         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 368         (tui_initialize_static_data): Move to tui-stack.c.
 369
 370 2019-08-15  Tom Tromey  <tom@tromey.com>
 371
 372         * tui/tui-layout.c (show_source_disasm_command)
 373         (show_source_or_disasm_and_command): Use make_visible method, not
 374         tui_make_window.
 375         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 376         Remove.
 377
 378 2019-08-15  Tom Tromey  <tom@tromey.com>
 379
 380         * tui/tui-wingeneral.h (tui_make_window): Update.
 381         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 382         parameter.
 383         (tui_gen_win_info::make_visible): Update.
 384         * tui/tui-regs.c (tui_data_window::display_registers_from):
 385         Update.
 386         * tui/tui-layout.c (show_source_disasm_command)
 387         (show_source_or_disasm_and_command): Update.
 388         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 389         (enum tui_box): Remove.
 390         (struct tui_win_info) <can_box>: New method.
 391         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 392         method.
 393
 394 2019-08-15  Tom de Vries  <tdevries@suse.de>
 395
 396         * linux-nat-trad.c: Include gdbarch.h.
 397
 398 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 399
 400         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 401         register sizes.
 402
 403 2019-08-14  Tom Tromey  <tromey@adacore.com>
 404
 405         * darwin-nat.c: Include gdbarch.h.
 406         * darwin-nat-info.c: Include gdbarch.h.
 407
 408 2019-08-13  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 411         Remove.
 412         * tui/tui-data.c (tui_initialize_static_data): Update.
 413
 414 2019-08-13  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-winsource.h (struct tui_exec_info_window)
 417         <~tui_exec_info_window, maybe_allocate_content, get_content,
 418         m_content>: Remove.
 419         (struct tui_source_window_base) <set_exec_info_content,
 420         show_exec_info_content>: Don't declare.
 421         * tui/tui-winsource.c
 422         (tui_exec_info_window::maybe_allocate_content): Remove.
 423         (tui_source_window_base::update_exec_info): Rename from
 424         set_exec_info_content.
 425         (tui_source_window_base::show_exec_info_content)
 426         (tui_source_window_base::update_exec_info): Remove.
 427
 428 2019-08-13  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 431         declare.
 432         * tui/tui-winsource.c (tui_update_source_window_as_is)
 433         (tui_update_source_windows_with_addr, tui_erase_source_content):
 434         Update.
 435         (tui_clear_exec_info_content): Remove.
 436
 437 2019-08-13  Tom Tromey  <tom@tromey.com>
 438
 439         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 440         declare.
 441         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 442         call tui_erase_exec_info_content.
 443         (tui_clear_exec_info_content): Rename from
 444         tui_erase_exec_info_content.
 445         (tui_clear_exec_info_content): Delete.
 446
 447 2019-08-13  Tom Tromey  <tom@tromey.com>
 448
 449         * tui/tui-winsource.h (struct tui_source_window_base)
 450         <show_exec_info_content>: Declare.
 451         (tui_show_exec_info_content): Don't declare.
 452         * tui/tui-winsource.c
 453         (tui_source_window_base::show_exec_info_content): Rename from
 454         tui_show_exec_info_content.
 455         (tui_source_window_base::update_exec_info): Update.
 456
 457 2019-08-13  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 460         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 461         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 462         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 463         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 464         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 465         ... here.
 466
 467 2019-08-13  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-winsource.h (struct tui_source_window_base)
 470         <update_exec_info>: Declare.
 471         (tui_update_exec_info): Don't declare.
 472         * tui/tui-winsource.c (tui_update_source_window_as_is)
 473         (tui_source_window_base::refresh_all)
 474         (tui_update_all_breakpoint_info): Update.
 475         (tui_source_window_base::update_exec_info): Rename from
 476         tui_update_exec_info.
 477         * tui/tui-stack.c (tui_show_frame_info): Update.
 478
 479 2019-08-13  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-winsource.h (struct tui_source_window_base)
 482         <set_exec_info_content>: Declare.
 483         (tui_set_exec_info_content): Don't declare.
 484         * tui/tui-winsource.c
 485         (tui_source_window_base::set_exec_info_content): Rename from
 486         tui_set_exec_info_content.
 487         (tui_update_exec_info): Update.
 488
 489 2019-08-13  Tom Tromey  <tom@tromey.com>
 490
 491         * tui/tui-winsource.h (struct tui_source_window_base)
 492         <show_source_content>: Declare.
 493         (tui_show_source_content): Don't declare.
 494         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 495         (tui_source_window_base::show_source_content): Rename from
 496         tui_show_source_content.
 497         (tui_source_window_base::refresh_all): Update.
 498         * tui/tui-layout.c (show_source_disasm_command)
 499         (show_source_or_disasm_and_command): Update.
 500
 501 2019-08-13  Tom Tromey  <tom@tromey.com>
 502
 503         * tui/tui-winsource.c (tui_erase_source_content)
 504         (tui_show_source_content, tui_source_window_base::refresh_all):
 505         Update.
 506         * tui/tui-wingeneral.h
 507         (tui_check_and_display_highlight_if_needed): Don't declare.
 508         * tui/tui-wingeneral.c
 509         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 510         check_and_display_highlight_if_needed.
 511         * tui/tui-win.c (tui_rehighlight_all)
 512         (tui_win_info::make_visible_with_new_height): Update.
 513         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 514         (tui_data_window::erase_data_content)
 515         (tui_data_window::display_all_data): Update.
 516         * tui/tui-data.h (struct tui_win_info)
 517         <check_and_display_highlight_if_needed>: Declare.
 518
 519 2019-08-13  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-win.c (tui_resize_all): Call
 522         tui_delete_invisible_windows.
 523         * tui/tui-layout.c (show_layout): Call
 524         tui_delete_invisible_windows.
 525         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 526         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 527
 528 2019-08-13  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 531         tui_add_win_to_layout.
 532
 533 2019-08-13  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 536         * tui/tui-layout.c (tui_default_win_height): Now static.
 537
 538 2019-08-13  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 541         single switch.
 542         (show_source_disasm_command, show_source_or_disasm_and_command):
 543         Don't check current layout.
 544
 545 2019-08-13  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui-wingeneral.c (make_all_visible): Remove.
 548         (tui_make_all_invisible): Simplify.
 549         * tui/tui-layout.c (tui_make_all_invisible): Move from
 550         tui-wingeneral.c; simplify.
 551         (show_layout): Hoist call to tui_make_all_invisible.
 552         (show_data): Don't call tui_make_all_invisible.
 553
 554 2019-08-13  Tom Tromey  <tom@tromey.com>
 555
 556         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 557         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 558
 559 2019-08-13  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 562         tui-data.c.
 563         (show_source_disasm_command, show_data)
 564         (show_source_or_disasm_and_command): Don't use
 565         tui_set_current_layout_to.
 566         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 567         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 568         tui-layout.c.
 569         (tui_set_current_layout_to): Remove.
 570
 571 2019-08-13  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-layout.c (tui_set_layout): Update.
 574         * tui/tui-data.h (struct tui_layout_def): Remove.
 575         (tui_layout_def): Don't declare.
 576         * tui/tui-data.c (layout_def): Remove.
 577         (tui_layout_def): Remove.
 578
 579 2019-08-13  Tom Tromey  <tom@tromey.com>
 580
 581         * tui/tui-winsource.h (struct tui_source_window_base)
 582         <clear_detail>: No longer "override".
 583         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 584         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 585         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 586         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 587         Remove.
 588         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 589
 590 2019-08-13  Tom Tromey  <tromey@adacore.com>
 591
 592         * tracepoint.c: Don't include readline.h or history.h.
 593
 594 2019-08-12  Tom Tromey  <tom@tromey.com>
 595
 596         * configure: Rebuild.
 597         * configure.ac: Check for readline 7.
 598         * NEWS: Mention readline 7 requirement.
 599         * README: Update.
 600
 601 2019-08-12  Tom Tromey  <tom@tromey.com>
 602
 603         * mingw-hdep.c (gdb_select): Remove readline hack.
 604
 605 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 606
 607         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 608         when the function fails.
 609
 610 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 611
 612         * s390-tdep.c (s390_type_align): New function.
 613         (s390_gdbarch_init): Set it as type_align gdbarch method.
 614
 615 2019-08-09  Tom de Vries  <tdevries@suse.de>
 616
 617         PR gdb/24591
 618         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 619         pc_low with relocation offset.
 620
 621 2019-08-07  Tom Tromey  <tromey@adacore.com>
 622
 623         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 624         (print_frame_args): Update.
 625         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 626         Update.
 627         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 628         * frame.h (struct frame_arg): Add initializers.
 629         <error>: Now a unique_xmalloc_ptr.
 630
 631 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 632
 633         * NEWS: Expand the Pointer Authentication entry.
 634         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 635         (aarch64_frame_unmask_lr): ... to this.
 636         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 637         Call aarch64_frame_unmask_lr.
 638         * frame.c (struct frame_info): Add "masked" variable.
 639         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 640         (fprint_frame): Check for masked pc.
 641         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 642         declarations.
 643         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 644         * stack.c (print_frame): Check for masked pc.
 645
 646 2019-08-06  Tom Tromey  <tom@tromey.com>
 647
 648         * stabsread.c (patch_block_stabs, read_one_struct_field)
 649         (read_enum_type): Use obstack_strndup.
 650         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 651         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 652         * dwarf2read.c (guess_full_die_structure_name)
 653         (anonymous_struct_prefix): Use obstack_strndup.
 654         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 655         * c-exp.y (yylex): Use obstack_strndup.
 656         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 657         (write_var_or_type): Use obstack_strndup.
 658
 659 2019-08-06  Tom Tromey  <tom@tromey.com>
 660
 661         * symfile.c (reread_symbols): Use obstack_strdup.
 662         * stabsread.c (read_type): Use obstack_strdup.
 663         * gdb_obstack.h (obstack_strdup): New overload.
 664         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 665         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 666         (dwarf2_canonicalize_name): Use obstack_strdup.
 667         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 668         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 669         Use obstack_strdup.
 670
 671 2019-08-06  Tom Tromey  <tom@tromey.com>
 672
 673         * gdb_obstack.h (obstack_strdup): Define.
 674         * gdb_obstack.c (obstack_strdup): Don't define.
 675
 676 2019-08-06  Tom Tromey  <tom@tromey.com>
 677
 678         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 679         obstack_strdup.
 680         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 681         obstack_strdup.
 682         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 683         * stabsread.c (common_block_start): Use obstack_strdup.
 684         * objfiles.c (set_objfile_main_name, objfile): Use
 685         obstack_strdup.
 686         * namespace.c (add_using_directive): Use obstack_strdup.
 687         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 688         * jit.c (finalize_symtab): Use obstack_strdup.
 689         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 690         (guess_partial_die_structure_name, partial_die_info::fixup)
 691         (dwarf2_name): Use obstack_strdup.
 692         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 693         obstack_strdup.
 694         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 695         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 696         obstack_strdup.
 697         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 698
 699 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 700
 701         * unittests/help-doc-selftests.c: New file.
 702         * Makefile.in: Add the new file.
 703
 704 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 705
 706         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 707         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 708         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 709         the trailing '.' is not output, and the first character is uppercased.
 710         (print_help_for_command): Update call to print_doc_line.
 711         (print_doc_of_command): Likewise.
 712         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 713         * cli/cli-option.c (append_indented_doc): Do not append newline.
 714         (build_help_option): Append newline after first appended_indented_doc
 715         only if a second call is done.
 716         (build_help): Append 2 new lines before each option, except the first
 717         one.
 718         * compile/compile.c (_initialize_compile): Add new lines after
 719         %OPTIONS%, when not at the end of the help.
 720         Change help doc or code
 721         producing the help doc to respect the invariants.
 722         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 723         Also removed the new line after 'Options:', as all other commands
 724         do not put an empty line between 'Options:' and the first option.
 725         * printcmd.c (_initialize_printcmd): Likewise.
 726         * stack.c (_initialize_stack): Likewise.
 727         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 728         incorrectly telling COMMAND is optional.
 729         * ada-lang.c (_initialize_ada_language): Change help doc or code
 730         producing the help doc to respect the invariants.
 731         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 732         * breakpoint.c (_initialize_breakpoint): Likewise.
 733         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 734         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 735         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 736         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 737         _initialize_cli_style): Likewise.
 738         * corelow.c (core_target_info): Likewise.
 739         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 740         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 741         * filesystem.c (_initialize_filesystem): Likewise.
 742         * frame.c (_initialize_frame): Likewise.
 743         * gnu-nat.c (add_task_commands): Likewise.
 744         * infcall.c (_initialize_infcall): Likewise.
 745         * infcmd.c (_initialize_infcmd): Likewise.
 746         * interps.c (_initialize_interpreter): Likewise.
 747         * language.c (_initialize_language): Likewise.
 748         * linux-fork.c (_initialize_linux_fork): Likewise.
 749         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 750         * maint.c (_initialize_maint_cmds): Likewise.
 751         * memattr.c (_initialize_mem): Likewise.
 752         * printcmd.c (_initialize_printcmd): Likewise.
 753         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 754         _RegEx): Likewise.
 755         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 756         * record-btrace.c (_initialize_record_btrace): Likewise.
 757         * record-full.c (_initialize_record_full): Likewise.
 758         * record.c (_initialize_record): Likewise.
 759         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 760         * regcache.c (_initialize_regcache): Likewise.
 761         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 762         _initialize_remote): Likewise.
 763         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 764         * serial.c (_initialize_serial): Likewise.
 765         * skip.c (_initialize_step_skip): Likewise.
 766         * source.c (_initialize_source): Likewise.
 767         * stack.c (_initialize_stack): Likewise.
 768         * symfile.c (_initialize_symfile): Likewise.
 769         * symtab.c (_initialize_symtab): Likewise.
 770         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 771         * top.c (init_main): Likewise.
 772         * tracefile-tfile.c (tfile_target_info): Likewise.
 773         * tracepoint.c (_initialize_tracepoint): Likewise.
 774         * tui/tui-win.c (_initialize_tui_win): Likewise.
 775         * utils.c (add_internal_problem_command): Likewise.
 776         * valprint.c (value_print_option_defs): Likewise.
 777
 778 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 779
 780         PR build/24886
 781         * configure.ac: Drop enable-libmcheck support.
 782         * configure, config.in: Rebuild.
 783         * libmcheck.m4: Remove.
 784         * acinclude.m4: Don't include it.
 785         * Makefile.in: Don't distribute it.
 786         * top.c (print_gdb_configuration): Don't mention it.
 787
 788 2019-08-06  Tom Tromey  <tom@tromey.com>
 789
 790         * utils.c (set_output_style): Sometimes pass stream to
 791         emit_style_escape.
 792         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 793         * record-btrace.c (btrace_insn_history): Update.
 794         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 795         method.
 796         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 797         Update initializers.
 798         <m_uiout>: New field.
 799         <m_di>: Move lower.
 800         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 801         Remove "uiout" parameter.
 802         (dump_insns): Update.
 803         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 804         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 805
 806 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 807
 808         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 809         (error_in_psymtab_expansion): Likewise.
 810         (lookup_symbol_via_quick_fns): Likewise.
 811         (basic_lookup_transparent_type_quick): Likewise.
 812         (basic_lookup_transparent_type_1): Likewise.
 813
 814 2019-08-06  Tom Tromey  <tromey@adacore.com>
 815
 816         * source.c (last_source_error): Now bool.
 817         (print_source_lines_base): Make "noprint" bool.  Only open
 818         source file when last_source_visited changes.
 819
 820 2019-08-06  Tom Tromey  <tromey@adacore.com>
 821
 822         * annotate.c (annotate_source_line): Use g_source_cache.
 823         * source-cache.c (source_cache::get_plain_source_lines): Change
 824         parameters.  Populate m_offset_cache.
 825         (source_cache::ensure): New method.
 826         (source_cache::get_line_charpos): New method.
 827         (extract_lines): Move lower.  Change parameters.
 828         (source_cache::get_source_lines): Move lower.
 829         * source-cache.h (class source_cache): Update comment.
 830         <get_line_charpos>: New method.
 831         <get_source_lines>: Update comment.
 832         <clear>: Clear m_offset_cache.
 833         <get_plain_source_lines>: Change parameters.
 834         <ensure>: New method
 835         <m_offset_cache>: New member.
 836         * source.c (forget_cached_source_info_for_objfile): Update.
 837         (info_source_command): Use g_source_cache.
 838         (find_source_lines, open_source_file_with_line_charpos): Remove.
 839         (print_source_lines_base, search_command_helper): Use g_source_cache.
 840         * source.h (open_source_file_with_line_charpos): Don't declare.
 841         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 842         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 843         Use g_source_cache.
 844
 845 2019-08-06  Tom Tromey  <tromey@adacore.com>
 846
 847         * source-cache.c (source_cache::get_plain_source_lines):
 848         Remove "first_line" and "last_line" parameters.
 849         (source_cache::get_source_lines): Cache plain text.
 850         * source-cache.h (class source_cache)
 851         <get_plain_source_lines>: Update.
 852
 853 2019-08-06  Tom Tromey  <tromey@adacore.com>
 854
 855         * source-cache.c (extract_lines): No longer a method.
 856         Changed type of parameter.  Include final newline.
 857         (selftests::extract_lines_test): New function.
 858         (_initialize_source_cache): Likewise.
 859         * source-cache.h (class source_cache)
 860         <extract_lines>: Don't declare.
 861
 862 2019-08-06  Tom Tromey  <tromey@adacore.com>
 863
 864         * breakpoint.c (init_breakpoint_sal): Update.
 865         (breakpoint): Update.
 866         * breakpoint.h (struct breakpoint) <filter>: Now a
 867         unique_xmalloc_ptr.
 868
 869 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 870
 871         * NEWS: Mention dictionary access on blocks.
 872         * python/py-block.c (blpy_getitem): New function.
 873         (block_object_as_mapping): New struct.
 874         (block_object_type): Use new struct for tp_as_mapping field.
 875
 876 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 877
 878         * objfiles.h (objfile): Add a comment describing partial symbols.
 879
 880 2019-08-05  Tom Tromey  <tromey@adacore.com>
 881
 882         * compile/compile.c (_initialize_compile): Use _(), not N_().
 883         * thread.c (_initialize_thread): Use _(), not N_().
 884         * stack.c (_initialize_stack): Use _(), not N_().
 885         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 886
 887 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 888
 889         * dwarf2read.c (struct dw2_symtab_iterator):
 890         <want_specific_block>: Remove.
 891         <block_index>: Change type to gdb::optional.
 892         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 893         change type of BLOCK_INDEX parameter to gdb::optional.
 894         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 895         (dw2_lookup_symbol): Don't pass argument for
 896         WANT_SPECIFIC_BLOCK.
 897         (dw2_expand_symtabs_for_function): Don't pass argument for
 898         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 899         (class dw2_debug_names_iterator)
 900         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 901         parameter, change BLOCK_INDEX type to gdb::optional.
 902         <m_want_specific_block>: Remove.
 903         <m_block_index>: Change type to gdb::optional.
 904         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 905         gdb::optional.  Re-write in function of gdb::optional.
 906         (dw2_debug_names_lookup_symbol): Don't pass argument for
 907         WANT_SPECIFIC_BLOCK.
 908         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 909         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 910         BLOCK_INDEX.
 911
 912 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 913
 914         * NEWS: Mention changes to "info sources" command.
 915
 916 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 917
 918         * symtab.c (filename_partial_match_opts): New struct type.
 919         (struct output_source_filename_data): New members
 920         regexp, c_regexp, partial_match.
 921         (output_source_filename): Use new members to decide to print file.
 922         (info_sources_option_defs): New variable.
 923         (make_info_sources_options_def_group, print_info_sources_header,
 924         info_sources_command_completer):
 925         New functions.
 926         (info_sources_command): Read new optional arguments.
 927         (_initialize_symtab): Update info sources help.
 928
 929 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 930
 931         * ada-lang.c (exception_support_info_v0): Renamed from...
 932         (default_exception_support_info): ... this.  Create new
 933         definition for v1.
 934         (ada_has_this_exception_support): Look up catch_handlers_sym.
 935         (ada_exception_support_info_sniffer): Try v0 after default.
 936
 937 2019-08-01  Tom Tromey  <tromey@adacore.com>
 938
 939         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 940         gdbarch.h.
 941
 942 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 943
 944         * s12z-tdep.c: Fix include path for s12z-opc.h.
 945
 946 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 947
 948         * NEWS: Require GNU make 3.82.
 949
 950 2019-07-16  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 953         declare.
 954
 955 2019-07-30  Tom Tromey  <tromey@adacore.com>
 956
 957         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 958
 959 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 960
 961         * printcmd.c (print_address_symbolic): Print negative offsets.
 962         (build_address_symbolic): Force signed arithmetic when computing
 963         offset.
 964
 965 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 966
 967         PR/24474: Add a function to lookup static variables.
 968         * NEWS: Mention this new function.
 969         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 970         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 971         * python/python.c (python_GdbMethods): Add new function.
 972
 973 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 974
 975         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 976         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 977         (objfpy_lookup_static_symbol): New function.
 978         (objfile_object_methods): Add new functions.
 979
 980 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 981
 982         * NEWS: Mention 'set|show print frame-info'.  Mention new
 983         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 984         backtrace argument.  Mention that python frame filtering code
 985         is now consistent with what 'backtrace' command prints.
 986
 987 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 988
 989         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 990         comments.
 991         (print_frame_info_auto, print_frame_info_source_line,
 992         print_frame_info_location, print_frame_info_source_and_location,
 993         print_frame_info_location_and_address, print_frame_info_short_location):
 994         New declarations.
 995         (struct frame_print_options): New member print_frame_info.
 996         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 997         * stack.h (get_user_print_what_frame_info): New declaration.
 998         (frame_show_address): New declaration.
 999         * stack.c (print_frame_arguments_choices): New value 'presence'.
1000         (print_frame_info_auto, print_frame_info_source_line,
1001         print_frame_info_location, print_frame_info_source_and_location,
1002         print_frame_info_location_and_address, print_frame_info_short_location,
1003         print_frame_info_choices, print_frame_info_print_what): New definitions.
1004         (print_frame_args): Only print dots for args if print frame-arguments
1005         is 'presence'.
1006         (frame_print_option_defs): New element for "frame-info".
1007         (get_user_print_what_frame_info): New function.
1008         (frame_show_address): Make non static.  Move comment to stack.h.
1009         (print_frame_info_to_print_what): New function.
1010         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1011         to decide what to print.
1012         (backtrace_command_1): Handle the new print_frame_arguments_presence
1013         value.
1014         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1015         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1016         (py_print_frame): In non-mi mode, use LOCATION as default for
1017         print_what, similarly to frame information printed directly by
1018         backtrace command. Handle frame-info user option in non MI mode.
1019
1020 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1021
1022         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1023         Add case for debugging 32-bit target on 64-bit host.  Revise
1024         comment.
1025
1026 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1027
1028         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1029         instead of find_function_entry_range_from_pc.
1030
1031 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1032
1033         * stack.c (find_frame_funname): Remove code which preferred
1034         minsym over symtab sym in "certain pathological cases".
1035
1036         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1037         parameter.  Change type of "do_demangle" to bool.
1038         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1039         Pass suitable "prefer_sym_over_minsym" flag to
1040         build_address_symbolic().  Don't output "+" for negative offsets.
1041         * printcmd.c (print_address_symbolic): Update invocation of
1042         build_address_symbolic to include a "prefer_sym_over_minsym"
1043         flag.
1044         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1045         Restrict cases in which use of minimal symbol is preferred to that
1046         of a found symbol.  Update comments.
1047
1048         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1049         for entry pc when entry pc is out of range for that FDE.
1050
1051 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1052
1053         PR gdb/24839:
1054         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1055         type.
1056
1057 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1058
1059         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1060         this function's Python signature.
1061
1062
1063 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1064
1065         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1066         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1067         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1068         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1069         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1070
1071
1072 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1073
1074         * h8300-tdep.c (h8300_register_name_common): New.
1075         h8300_register_name): Use h8300_register_name_common.
1076         (h8300s_register_name): Likewise.
1077         (h8300sx_register_name): Likewise.
1078         (h8300h_register_nam): New.
1079         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1080
1081
1082 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1083
1084         * arm-tdep.c (arm_skip_cmse_entry): New function.
1085         (arm_is_sgstubs_section): New function.
1086         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1087
1088 2019-07-22  Tom Tromey  <tom@tromey.com>
1089
1090         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1091         Don't self-assign.
1092
1093 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1094
1095         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1096         type_print.
1097
1098 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1099
1100         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1101         so that GDB doesn't match any msymbols when searching in the
1102         TYPES_DOMAIN.
1103         (print_symbol_info): Print using typedef_print or type_print based
1104         on the type of the symbol.  Add updated FIXME comment moved from...
1105         (_initialize_symtab): ... move and update FIXME comment to above.
1106
1107 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * NEWS: Mention adding -q option to "info types".
1110         * symtab.c (struct info_types_options): New struct.
1111         (info_types_options_defs): New variable.
1112         (make_info_types_options_def_group): New function.
1113         (info_types_command): Use gdb::option framework to parse options.
1114         (info_types_command_completer): New function.
1115         (_initialize_symtab): Extend the help text on "info types" and
1116         register command completer.
1117
1118 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1119
1120         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1121         (lookup_symbol_in_objfile): Change int to block_enum and add a
1122         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1123
1124 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1125
1126         * MAINTAINERS (Write After Approval): Add self.
1127
1128 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1129
1130         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1131         instruction to the dummy code region.
1132
1133 2019-07-19  Tom Tromey  <tromey@adacore.com>
1134
1135         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1136         (ARGSUSED, PARAMS, __func__): Remove rules.
1137
1138 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1139
1140         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1141         * features/arm/arm-with-iwmmxt.c: Remove.
1142         * features/arm/arm-with-iwmmxt.xml: Remove.
1143         * features/arm/arm-with-m-fpa-layout.c: Remove.
1144         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1145         * features/arm/arm-with-m-vfp-d16.c: Remove.
1146         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1147         * features/arm/arm-with-m.c: Remove.
1148         * features/arm/arm-with-m.xml: Remove.
1149         * features/arm/arm-with-neon.c: Remove.
1150         * features/arm/arm-with-neon.xml: Remove.
1151         * features/arm/arm-with-vfpv2.c: Remove.
1152         * features/arm/arm-with-vfpv2.xml: Remove.
1153         * features/arm/arm-with-vfpv3.c: Remove.
1154         * features/arm/arm-with-vfpv3.xml: Remove.
1155
1156 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1157
1158         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1159
1160 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1161
1162         * arch/aarch32.c (aarch32_create_target_description): Create
1163         target descriptions using features.
1164         * arch/arm.c (arm_create_target_description)
1165         (arm_create_mprofile_target_description): Likewise.
1166         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1167
1168 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1169
1170         * Makefile.in: Add new files.
1171         * aarch32-tdep.c: New file.
1172         * aarch32-tdep.h: New file.
1173         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1174         Call aarch32_read_description.
1175         * arch/aarch32.c: New file.
1176         * arch/aarch32.h: New file.
1177         * arch/arm.c (arm_create_target_description)
1178         (arm_create_mprofile_target_description): New function.
1179         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1180         (arm_create_target_description)
1181         (arm_create_mprofile_target_description): New declaration.
1182         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1183         read_description functions.
1184         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1185         Likewise.
1186         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1187         * arm-tdep.c (tdesc_arm_list): New variable.
1188         (arm_register_g_packet_guesses): Call create description functions.
1189         (arm_read_description) (arm_read_mprofile_description): New
1190         function.
1191         * arm-tdep.h (arm_read_description)
1192         (arm_read_mprofile_description): Add declaration.
1193         * configure.tgt: Add new files.
1194
1195 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1196
1197         * top.c (new_ui_command): Open specified terminal just once.
1198
1199 2019-07-18  Tom Tromey  <tromey@adacore.com>
1200
1201         * symtab.c (main_name): Constify return type.
1202         * symfile.c (set_initial_language): Update.
1203         * symtab.h (main_name): Constify return type.
1204
1205 2019-07-17  Tom Tromey  <tom@tromey.com>
1206
1207         * tui/tui-winsource.c (tui_update_source_window)
1208         (tui_update_source_window_as_is)
1209         (tui_update_source_windows_with_line): Remove return.
1210         * tui/tui-disasm.c (tui_show_disassem)
1211         (tui_show_disassem_and_update_source): Remove return.
1212         * tui/tui.c (tui_reset): Remove return.
1213         * tui/tui-wingeneral.c
1214         (tui_check_and_display_highlight_if_needed): Remove return.
1215
1216 2019-07-17  Tom Tromey  <tom@tromey.com>
1217
1218         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1219
1220 2019-07-17  Tom Tromey  <tom@tromey.com>
1221
1222         * tui/tui-winsource.h (struct tui_exec_info_window)
1223         (struct tui_source_window_base): Move from tui-data.h.
1224         * tui/tui-winsource.c: Move many method definitions from
1225         elsewhere.  Remove "structuring" comments.
1226         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1227         (tui_source_window_base::refresh_window): Move to
1228         tui-winsource.c.
1229         * tui/tui-win.c (tui_source_window_base::refresh_all)
1230         (tui_source_window_base::update_tab_width)
1231         (tui_source_window_base::set_new_height)
1232         (tui_source_window_base::do_make_visible_with_new_height): Move to
1233         tui-winsource.c.
1234         * tui/tui-source.h: Update.
1235         * tui/tui-source.c (tui_source_window_base::reset): Move to
1236         tui-winsource.c.
1237         * tui/tui-disasm.h: Update.
1238         * tui/tui-data.h (struct tui_exec_info_window): Move to
1239         tui-winsource.h.
1240         (struct tui_source_window_base): Likewise.
1241         * tui/tui-data.c (tui_source_window_base::clear_detail)
1242         (tui_source_window_base, ~tui_source_window_base): Move to
1243         tui-winsource.c.
1244
1245 2019-07-17  Tom Tromey  <tom@tromey.com>
1246
1247         * tui/tui-win.c (tui_resize_all)
1248         (tui_source_window_base::update_tab_width)
1249         (tui_adjust_win_heights): Update.
1250         (tui_win_info::make_invisible_and_set_new_height): Rename from
1251         make_invisible_and_set_new_height.
1252         * tui/tui-data.h (struct tui_win_info)
1253         <make_invisible_and_set_new_height>: New method.
1254
1255 2019-07-17  Tom Tromey  <tom@tromey.com>
1256
1257         * tui/tui.c: Update.
1258         * tui/tui-source.h (struct tui_source_window): Move from
1259         tui-data.h.
1260         * tui/tui-layout.c: Update.
1261         * tui/tui-disasm.c: Update.
1262         * tui/tui-data.h (struct tui_source_window): Move to
1263         tui-source.h.
1264
1265 2019-07-17  Tom Tromey  <tom@tromey.com>
1266
1267         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1268         tui-data.h.
1269         * tui/tui-data.h (struct tui_disasm_window): Move to
1270         tui-disasm.h.
1271
1272 2019-07-17  Tom Tromey  <tom@tromey.com>
1273
1274         * tui/tui-regs.h (struct tui_data_item_window): Move from
1275         tui-data.h.
1276         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1277         * tui/tui-data.h (struct tui_data_item_window): Move to
1278         tui-regs.h.
1279         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1280
1281 2019-07-17  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui.c: Update.
1284         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1285         (tui_cmd_window::max_height): Move to tui-command.c.
1286         * tui/tui-layout.c: Update.
1287         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1288         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1289         tui-command.c.
1290         * tui/tui-command.h (struct tui_cmd_window): Move from
1291         tui-data.h.
1292         * tui/tui-command.c: Remove "structuring" comments.
1293         (tui_cmd_window::clear_detail)
1294         (tui_cmd_window::do_make_visible_with_new_height)
1295         (tui_cmd_window::max_height): Move from elsewhere.
1296
1297 2019-07-17  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1300         Now static.
1301         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1302         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1303
1304 2019-07-17  Tom Tromey  <tom@tromey.com>
1305
1306         * tui/tui.c: Update.
1307         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1308         tui-regs.c.
1309         * tui/tui-windata.h: Remove file.
1310         * tui/tui-windata.c: Remove file.
1311         * tui/tui-win.c (tui_data_window::set_new_height)
1312         (tui_data_window::do_make_visible_with_new_height): Move to
1313         tui-regs.c.
1314         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1315         * tui/tui-regs.c: Remove "structuring" comments.
1316         (tui_data_window::first_data_item_displayed)
1317         (tui_data_window::delete_data_content_windows)
1318         (tui_data_window::erase_data_content)
1319         (tui_data_window::display_all_data)
1320         (tui_data_window::refresh_all)
1321         (tui_data_window::do_scroll_vertical)
1322         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1323         (tui_data_window::do_make_visible_with_new_height)
1324         (tui_data_window::refresh_window): Move from elsewhere.
1325         (_initialize_tui_regs): Move to end of file.
1326         * tui/tui-layout.c: Update.
1327         * tui/tui-hooks.c: Update.
1328         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1329         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1330         tui-regs.c.
1331         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1332
1333 2019-07-17  Tom Tromey  <tom@tromey.com>
1334
1335         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1336         seen.
1337
1338 2019-07-17  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-win.c (tui_source_window_base::set_new_height)
1341         (tui_source_window_base::do_make_visible_with_new_height): Use
1342         m_has_locator field directly.
1343         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1344         method.
1345         (struct tui_source_window_base) <has_locator>: Likewise.
1346
1347 2019-07-17  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1350         Don't declare.
1351         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1352         Remove.
1353         * tui/tui-win.c (tui_source_window_base::set_new_height)
1354         (tui_source_window_base::set_new_height)
1355         (make_invisible_and_set_new_height)
1356         (tui_source_window_base::do_make_visible_with_new_height)
1357         (tui_source_window_base::do_make_visible_with_new_height):
1358         Update.
1359         * tui/tui-layout.c (show_source_disasm_command, show_data)
1360         (show_source_or_disasm_and_command): Update.
1361         * tui/tui-layout.c (show_layout): Update.
1362
1363 2019-07-17  Tom Tromey  <tom@tromey.com>
1364
1365         * tui/tui-layout.c (make_data_window): Remove.
1366         (show_data): Unify creation and re-initialization cases.
1367
1368 2019-07-17  Tom Tromey  <tom@tromey.com>
1369
1370         * tui/tui-layout.c (make_source_window, make_disasm_window):
1371         Remove.
1372         (show_data): Unify creation and re-initialization cases.
1373
1374 2019-07-17  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-layout.c (make_command_window): Remove.
1377         (show_source_disasm_command, show_source_or_disasm_and_command):
1378         Unify creation and re-initialization cases.
1379
1380 2019-07-17  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1383         creation and re-initialization cases.
1384
1385 2019-07-17  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-regs.c (tui_get_register): Return void.
1388
1389 2019-07-17  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1392         Simplify.
1393
1394 2019-07-17  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1397         resetting.
1398
1399 2019-07-17  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1402         * tui/tui-regs.c (tui_reg_layout): New function.
1403         (tui_show_registers, tui_reg_command): Use it.
1404         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1405         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1406         parameters.
1407         (tui_layout_command): Remove.
1408
1409 2019-07-17  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-layout.h (tui/tui-layout): Return void.
1412         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1413
1414 2019-07-17  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-layout.c (show_source_disasm_command, show_data):
1417         Update.
1418         (reset_locator): Remove.
1419         (show_source_or_disasm_and_command): Update.
1420
1421 2019-07-17  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-source.c (tui_source_window_base::reset): Remove
1424         win_type parameter.
1425         * tui/tui-layout.c (make_command_window, make_source_window)
1426         (make_disasm_window, make_data_window)
1427         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1428         (reset_locator, show_source_or_disasm_and_command): Update.
1429         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1430         win_type parameter.
1431         (struct tui_source_window_base) <reset>: Likewise.
1432
1433 2019-07-17  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-layout.c (show_source_disasm_command): Use
1436         reset_locator.
1437         (reset_locator): New function.
1438         (init_and_make_win): Remove.
1439         (show_source_or_disasm_and_command): Use reset_locator.
1440
1441 2019-07-17  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1444         condition.
1445         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1446         Remove condition.
1447         * tui/tui-source.c (tui_source_window_base::reset): New method.
1448         * tui/tui-layout.c (make_command_window): Don't call
1449         init_and_make_win.
1450         (make_source_window, make_disasm_window): Don't call
1451         make_source_or_disasm_window.
1452         (make_data_window): Don't call init_and_make_win.  Change calling
1453         convention.
1454         (show_source_disasm_command, show_data): Simplify.
1455         (make_source_or_disasm_window): Remove.
1456         (show_source_or_disasm_and_command): Simplify.
1457         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1458         (struct tui_source_window_base) <reset>: Likewise.
1459         <execution_info>: Remove initializer.
1460         * tui/tui-data.c (tui_source_window_base): Initialize
1461         execution_info.
1462
1463 2019-07-17  Tom Tromey  <tom@tromey.com>
1464
1465         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1466         variable.
1467
1468 2019-07-17  Tom Tromey  <tom@tromey.com>
1469
1470         * tui/tui.c (tui_rl_other_window): Update.
1471         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1472         superclass method first.  Always iterate over regs_content.
1473         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1474         method.
1475         * tui/tui-win.c (tui_set_focus_command): Update.
1476
1477 2019-07-17  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-win.c (tui_set_focus_command): Rename from
1480         tui_set_focus.  Call tui_enable.
1481         (tui_set_focus_command): Remove.
1482
1483 2019-07-17  Tom Tromey  <tom@tromey.com>
1484
1485         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1486         refresh_window.
1487         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1488         touchwin.
1489         (tui_data_window::refresh_window): Call refresh_window on data
1490         items.  Always call superclass refresh_window.
1491         (tui_win_info::refresh): Remove.
1492         (tui_source_window_base::refresh_window): Update.
1493         (tui_refresh_all): Update.
1494         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1495         refresh_window.
1496         (show_source_or_disasm_and_command): Likewise.
1497         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1498         (struct tui_source_window_base) <refresh>: Likewise.
1499
1500 2019-07-17  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-winsource.c (tui_clear_source_content)
1503         (tui_show_source_content): Update.
1504         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1505         whether content is empty.
1506         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1507         Remove.
1508
1509 2019-07-17  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1512         window's contents.
1513         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1514         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1515
1516 2019-07-17  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1519         (struct tui_data_item_window): Update.
1520
1521 2019-07-17  Tom Tromey  <tom@tromey.com>
1522
1523         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1524         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1525         defines.
1526
1527 2019-07-17  Tom Tromey  <tom@tromey.com>
1528
1529         * tui/tui-winsource.h (tui_erase_source_content)
1530         (tui_clear_source_content): Remove "display_prompt" parameter.
1531         * tui/tui-winsource.c (tui_update_source_window_as_is)
1532         (tui_update_source_windows_with_addr): Update.
1533         (tui_clear_source_content): Remove "display_prompt" parameter.
1534         (tui_erase_source_content): Likewise.  Simplify.
1535         (tui_show_source_content): Update.
1536         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1537         * tui/tui-stack.c (tui_show_frame_info): Update.
1538         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1539         Remove defines.
1540
1541 2019-07-17  Tom Tromey  <tom@tromey.com>
1542
1543         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1544         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1545         parameter.
1546         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1547         parameter.
1548
1549 2019-07-17  Tom Tromey  <tom@tromey.com>
1550
1551         * tui/tui-winsource.c (tui_clear_source_content)
1552         (tui_show_source_content, tui_show_exec_info_content)
1553         (tui_clear_exec_info_content): Update.
1554         * tui/tui-stack.c (tui_show_locator_content): Update.
1555         (tui_show_frame_info): Update.
1556         * tui/tui-source.h (tui_source_window): Don't declare.
1557         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1558         from tui_source_is_displayed.
1559         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1560         Remove field.
1561         (struct tui_source_window_base) <content_in_use>: New field.  Now
1562         bool.
1563         (struct tui_source_window) <showing_source_p>: New method.
1564         (TUI_SRC_WIN): Change cast.
1565         * tui/tui-data.c (tui_initialize_static_data): Update.
1566
1567 2019-07-17  Tom Tromey  <tom@tromey.com>
1568
1569         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1570         location_matches_p.
1571         * tui/tui-source.c (tui_source_window::location_matches_p): New
1572         method.
1573         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1574         method.
1575         * tui/tui-data.h (struct tui_source_window_base)
1576         <location_matches_p>: New method.
1577         (struct tui_source_window, struct tui_disasm_window)
1578         <location_matches_p>: Likewise.
1579
1580 2019-07-17  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-win.c (tui_set_win_height_command): Rename from
1583         tui_set_win_height.
1584         (tui_set_win_height_command): Remove.
1585
1586 2019-07-17  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-source.c (tui_source_window): New constructor.  Add
1589         observer.
1590         (~tui_source_window): New destructor.
1591         (tui_source_window::style_changed): New method.
1592         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1593         (tui_attach_detach_observers): Update.
1594         * tui/tui-data.h (struct tui_source_window): Make constructor not
1595         inline.  Add destructor.
1596         (struct tui_source_window) <style_changed>: New method.
1597         <m_observable>: New member.
1598
1599 2019-07-17  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1602         * tui/tui-win.c (tui_resize_all): Fix typo.
1603
1604 2019-07-17  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1607         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1608         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1609         * tui/tui-win.c (window_name_completer): Use foreach.
1610         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1611         (update_tab_width): Likewise.
1612         * tui/tui-layout.c (show_layout): Update.
1613         * tui/tui-data.h (class tui_window_iterator): New.
1614         (struct all_tui_windows): New.
1615         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1616
1617 2019-07-17  Tom Tromey  <tom@tromey.com>
1618
1619         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1620         parameter.  Don't reference globals.
1621         (tui_reg_command): Update.
1622
1623 2019-07-17  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-regs.c (tui_show_registers): Simplify.
1626
1627 2019-07-17  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-regs.c (tui_show_registers): Update.
1630         (tui_show_register_group): Add win_info parameter.
1631
1632 2019-07-17  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1635         Rename from tui_display_reg_element_at_line.
1636         (tui_data_window::display_registers_from_line): Update.
1637         * tui/tui-data.h (struct tui_data_window)
1638         <display_reg_element_at_line>: New method.
1639
1640 2019-07-17  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui-regs.h (tui_display_registers_from)
1643         (tui_display_registers_from_line): Don't declare.
1644         * tui/tui-windata.c (tui_data_window::display_all_data)
1645         (tui_data_window::refresh_all)
1646         (tui_data_window::do_scroll_vertical): Update.
1647         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1648         from tui_display_registers_from.
1649         (tui_display_reg_element_at_line): Update.
1650         (tui_data_window::display_registers_from_line): Rename from
1651         tui_display_registers_from_line.
1652         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1653         display_registers_from_line>: New methods.
1654
1655 2019-07-17  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1658         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1659         from tui_erase_data_content.
1660         (tui_data_window::display_all_data)
1661         (tui_data_window::refresh_all)
1662         (tui_data_window::do_scroll_vertical): Update.
1663         * tui/tui-regs.c (tui_show_registers): Update.
1664         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1665         New method.
1666
1667 2019-07-17  Tom Tromey  <tom@tromey.com>
1668
1669         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1670         declare.
1671         * tui/tui-windata.c
1672         (tui_data_window::delete_data_content_windows): Rename from
1673         tui_delete_data_content_windows.
1674         (tui_data_window::display_all_data)
1675         (tui_data_window::do_scroll_vertical): Update.
1676         * tui/tui-data.h (struct tui_data_window)
1677         <delete_data_content_windows>: New method.
1678
1679 2019-07-17  Tom Tromey  <tom@tromey.com>
1680
1681         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1682         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1683
1684 2019-07-17  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1687         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1688         from tui_display_all_data.
1689         * tui/tui-win.c
1690         (tui_data_window::do_make_visible_with_new_height): Update.
1691         * tui/tui-regs.c (tui_show_registers): Update.
1692         * tui/tui-layout.c (tui_set_layout): Update.
1693         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1694         method.
1695
1696 2019-07-17  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1699         * tui/tui-windata.c (tui_display_data_from): Remove.
1700         (tui_data_window::refresh_all): Update.
1701
1702 2019-07-17  Tom Tromey  <tom@tromey.com>
1703
1704         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1705         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1706         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1707         tui_display_registers_from_line.
1708         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1709         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1710         "force_display" parameter.
1711
1712 2019-07-17  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1715         declare.
1716         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1717         Rename from tui_first_reg_element_no_inline.
1718         (tui_display_reg_element_at_line)
1719         (tui_display_registers_from_line): Update.
1720         * tui/tui-data.h (struct tui_data_window)
1721         <first_reg_element_no_inline>: New method.
1722
1723 2019-07-17  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-windata.c (tui_display_data_from)
1726         (tui_data_window::do_scroll_vertical): Update.
1727         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1728         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1729         Rename from tui_line_from_reg_element_no.
1730         (tui_display_registers_from_line): Update.
1731         * tui/tui-data.h (struct tui_data_window)
1732         <line_from_reg_element_no>: New method.
1733
1734 2019-07-17  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1737         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1738         tui_last_regs_line_no.
1739         (tui_display_reg_element_at_line)
1740         (tui_display_registers_from_line): Update.
1741         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1742         method.
1743
1744 2019-07-17  Tom Tromey  <tom@tromey.com>
1745
1746         PR tui/24722:
1747         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1748         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1749         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1750         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1751         (tui_update_breakpoint_info): Likewise.
1752         * tui/tui-hooks.c (tui_event_create_breakpoint)
1753         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1754         Update.
1755
1756 2019-07-17  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1759
1760 2019-07-17  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui-winsource.c (tui_update_source_window_as_is)
1763         (tui_update_source_windows_with_addr): Update.
1764         * tui/tui-source.h (tui_set_source_content)
1765         (tui_show_symtab_source): Add "win_info" parameter.
1766         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1767         parameter.
1768         (tui_show_symtab_source): Likewise.
1769
1770 2019-07-17  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-wingeneral.c
1773         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1774
1775 2019-07-17  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1778         (struct tui_cmd_window) <can_scroll>: New method.
1779         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1780         method.
1781
1782 2019-07-17  Tom Tromey  <tromey@adacore.com>
1783
1784         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1785         do_field_signed>: Rename.  Change type of "value".
1786         * ui-out.c (ui_out::field_signed): Rename from field_int.
1787         Change type of "value".
1788         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1789         type of "value".
1790         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1791         do_field_int.  Change type of "value".
1792         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1793         do_field_int.  Change type of "value".
1794         * tracepoint.c (trace_status_mi, tfind_1)
1795         (print_one_static_tracepoint_marker): Update.
1796         * thread.c (print_thread_info_1, print_selected_thread_frame):
1797         Update.
1798         * stack.c (print_frame, print_frame_info): Update.
1799         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1800         Update.
1801         * source.c (print_source_lines_base): Update.
1802         * skip.c (info_skip_command): Update.
1803         * record-btrace.c (btrace_ui_out_decode_error)
1804         (btrace_call_history_src_line): Update.
1805         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1806         Update.
1807         * progspace.c (print_program_space): Update.
1808         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1809         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1810         do_field_int.  Change type of "value".
1811         * mi/mi-out.c (mi_ui_out::do_table_begin)
1812         (mi_ui_out::do_table_header): Update.
1813         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1814         type of "value".
1815         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1816         (mi_cmd_data_list_changed_registers, output_register)
1817         (mi_cmd_data_read_memory, mi_load_progress)
1818         (mi_cmd_trace_frame_collected): Update.
1819         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1820         Update.
1821         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1822         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1823         (mi_cmd_var_list_children, varobj_update_one): Update.
1824         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1825         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1826         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1827         * inferior.c (print_inferior): Update.
1828         * gdb_bfd.c (print_one_bfd): Update.
1829         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1830         Update.
1831         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1832         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1833         do_field_int.  Change type of "value".
1834         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1835         do_field_int.  Change type of "value".
1836         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1837         (print_one_breakpoint_location, print_it_catch_fork)
1838         (print_one_catch_fork, print_it_catch_vfork)
1839         (print_one_catch_vfork, print_it_catch_solib)
1840         (print_it_catch_exec, print_it_ranged_breakpoint)
1841         (print_mention_watchpoint, print_mention_masked_watchpoint)
1842         (bkpt_print_it, update_static_tracepoint): Update.
1843         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1844         * break-catch-syscall.c (print_it_catch_syscall): Update.
1845         * ada-tasks.c (print_ada_task_info): Update.
1846         * ada-lang.c (print_it_exception, print_mention_exception):
1847         Update.
1848
1849 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1850
1851         PR breakpoints/24541
1852         * gdbarch.c: Regenerate.
1853         * gdbarch.h: Regenerate.
1854         * gdbarch.sh: Adjust return type and parameter types for
1855         'stap_adjust_register'.
1856         (i386_stap_adjust_register): Adjust signature and return new
1857         register name.
1858         * stap-probe.c (stap_parse_register_operand): Adjust use of
1859         'gdbarch_stap_adjust_register'.
1860
1861 2019-07-17  Tom Tromey  <tromey@adacore.com>
1862
1863         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1864         declare VEC.
1865         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1866         std::vector.
1867         (struct s390_process_info): Add initializers.
1868         (s390_add_process): Use new.
1869         (s390_linux_nat_target::low_forget_process): Use delete.
1870         (s390_linux_nat_target::low_new_fork)
1871         (s390_linux_nat_target::stopped_by_watchpoint)
1872         (s390_linux_nat_target::low_prepare_to_resume)
1873         (s390_linux_nat_target::insert_watchpoint)
1874         (s390_linux_nat_target::insert_hw_breakpoint)
1875         (s390_linux_nat_target::remove_watchpoint)
1876         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1877
1878 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1879
1880         * aarch64-fbsd-nat.c: Include regcache.h.
1881         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1882         argument.
1883         (aarch64_fbsd_nat_target::fetch_registers)
1884         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1885         variable.
1886         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1887
1888 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1889
1890         * fbsd-nat.c: Include gdbarch.h.
1891
1892 2019-07-15  Tom Tromey  <tromey@adacore.com>
1893
1894         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1895
1896 2019-07-15  Tom Tromey  <tromey@adacore.com>
1897
1898         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1899         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1900         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1901         * cli-out.c (cli_ui_out::do_field_int): New method.
1902         * ui-out.c (ui_out::field_unsigned): New method.
1903         * symfile.c (generic_load): Use field_unsigned.
1904         (print_transfer_performance): Likewise.
1905         * record-btrace.c (ui_out_field_uint): Remove.
1906         (btrace_call_history_insn_range, btrace_call_history): Use
1907         field_unsigned.
1908         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1909         field_unsigned.
1910         * ui-out.h (class ui_out) <field_unsigned>: New method.
1911         <do_field_unsigned>: Likewise.
1912
1913 2019-07-15  Tom Tromey  <tromey@adacore.com>
1914
1915         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1916         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1917         * target.c (flash_erase_command): Use field_string.
1918         * infrun.c (print_signal_received_reason): Use field_string.
1919         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1920         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1921         field_string.
1922         * ada-tasks.c (print_ada_task_info): Use field_string.
1923
1924 2019-07-15  Tom Tromey  <tromey@adacore.com>
1925
1926         * target.c (flash_erase_command): Use field_core_addr.
1927         * symfile.c (generic_load): Use field_core_addr.
1928         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1929         Use field_core_addr.
1930         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1931         field_core_addr.
1932
1933 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1934
1935         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1936         value if its desired type is smaller than a CORE_ADDR and signed.
1937
1938 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1939
1940         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1941         of changes to field names, and use new is_reference field to
1942         decide if a property is a reference or not.
1943         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1944         field.
1945         (struct dwarf2_property_baton): Update header comment, rename
1946         'referenced_type' to 'property_type' and update comments.
1947         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1948         default property type, store in property baton, update to take
1949         accound of renamed field.
1950         (read_func_scope): Update call to attr_to_dynamic_prop.
1951         (read_array_type): Likewise.
1952         (dwarf2_per_cu_addr_sized_int_type): New function.
1953         (read_subrange_index_type): Move type finding code to
1954         dwarf2_per_cu_addr_sized_int_type.
1955         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1956         (dwarf2_per_cu_addr_type): New function.
1957         (set_die_type): Update calls to attr_to_dynamic_prop.
1958
1959 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1960
1961         * dwarf2read.c (read_subrange_index_type): New function.
1962         (read_subrange_type): Move code into new function and call it.
1963         * gdbtypes.c (create_range_type): Add some asserts.
1964
1965 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1966
1967         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1968         update return statements.
1969         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1970         declaration, and update comment to match.
1971         * gdbtypes.c (resolve_dynamic_array): Update call to
1972         dwarf2_evaluate_property to match new return type.
1973
1974 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1975
1976         * valarith.c (value_subscripted_rvalue): Change lowerbound
1977         parameter type from int to LONGEST.
1978         * value.h (value_subscripted_rvalue): Likewise in declaration.
1979
1980 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1981
1982         * cli/cli-utils.c (info_print_command_completer): New function.
1983         * cli/cli-utils.h: Add 'completer.h' include, and forward
1984         declaration for 'struct cmd_list_element'.
1985         (info_print_command_completer): Declare.
1986         * stack.c (_initialize_stack): Add completer for 'info locals' and
1987         'info args'.
1988         * symtab.c (_initialize_symtab): Add completer for 'info
1989         variables' and 'info functions'.
1990         * NEWS: Mention completion for additional info commands.
1991
1992 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1993
1994         * cli/cli-utils.c (extract_info_print_args): Delete.
1995         (extract_arg_maybe_quoted): Delete.
1996         (info_print_options_defs): New variable.
1997         (make_info_print_options_def_group): New function.
1998         (extract_info_print_options): Define new function.
1999         * cli/cli-utils.h (extract_info_print_args): Delete.
2000         (struct info_print_options): New structure.
2001         (extract_info_print_options): Declare new function.
2002         * stack.c (info_locals_command): Update to use new
2003         extract_info_print_options, also add a header comment.
2004         (info_args_command): Likewise.
2005         * symtab.c (info_variables_command): Likewise.
2006         (info_functions_command): Likewise.
2007
2008 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2009
2010         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2011         to extract string arguments.
2012         * common/common-utils.c (extract_string_maybe_quoted): New function.
2013         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2014
2015 2019-07-11  Tom Tromey  <tromey@adacore.com>
2016
2017         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2018         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2019         * top.h (gdbinit): Don't declare.
2020         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2021         into...
2022         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2023         * top.c (gdb_init): Don't call init_cli_cmds.
2024         (gdbinit): Remove.
2025         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2026
2027 2019-07-11  Tom Tromey  <tromey@adacore.com>
2028
2029         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2030         after it has been moved.
2031
2032 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2033
2034         * valops.c (value_must_coerce_to_target): Change return type to
2035         bool.
2036         * value.h (value_must_coerce_to_target): Likewise.
2037
2038 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2039
2040         * breakpoint.c (is_hardware_watchpoint): Remove
2041         forward-declaration.
2042         (is_masked_watchpoint): Change return type to bool.
2043         (is_tracepoint): Likewise.
2044         (is_breakpoint): Likewise.
2045         (is_hardware_watchpoint): Likewise.
2046         (is_watchpoint): Likewise.
2047         (is_no_memory_software_watchpoint): Likewise.
2048         (is_catchpoint): Likewise.
2049         (breakpoint_1): Make FILTER parameter's return type bool.
2050         is_masked_watchpoint): Change return type to bool.
2051         (save_breakpoints): Make FILTER parameter's return type bool.
2052         * breakpoint.h (is_breakpoint): Change return type to bool.
2053         (is_watchpoint): Likewise.
2054         (is_catchpoint): Likewise.
2055         (is_tracepoint): Likewise.
2056
2057 2019-07-10  Tom Tromey  <tom@tromey.com>
2058
2059         * defs.h: Don't include gdbarch.h.
2060         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2061         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2062         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2063         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2064         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2065         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2066         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2067         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2068         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2069         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2070         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2071         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2072         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2073         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2074         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2075         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2076         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2077         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2078         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2079         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2080         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2081         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2082         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2083         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2084         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2085         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2086         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2087
2088 2019-07-10  Tom Tromey  <tromey@adacore.com>
2089
2090         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2091         * breakpoint.c (init_ada_exception_breakpoint): Register as
2092         bp_catchpoint.
2093         (print_one_breakpoint_location, print_one_breakpoint): Use
2094         is_ada_exception_catchpoint.
2095         * ada-lang.c (class ada_catchpoint_location): Pass
2096         bp_loc_software_breakpoint to bp_location constructor.
2097         (is_ada_exception_catchpoint): New function.
2098
2099 2019-07-10  Tom Tromey  <tromey@adacore.com>
2100
2101         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2102         VEC.
2103         (struct arm_exidx_entry): New method operator<.
2104         (struct arm_exidx_data) <section_maps>: Change type.
2105         (arm_exidx_data_free): Remove.
2106         (arm_exidx_data_key): Change type.  Move lower.
2107         (arm_exidx_new_objfile): Update.
2108         (arm_compare_exidx_entries): Remove.
2109         (arm_find_exidx_entry, _initialize_arm_tdep)
2110
2111 2019-07-10  Tom Tromey  <tromey@adacore.com>
2112
2113         * solib-spu.c (ocl_program_data_key): Change type.
2114         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2115         Update.
2116
2117 2019-07-10  Tom Tromey  <tromey@adacore.com>
2118
2119         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2120         (struct solib_aix_inferior_data) <library_list>: Change type.
2121         (solib_aix_inferior_data_handle): Change type.
2122         (get_solib_aix_inferior_data): Update.
2123         (solib_aix_free_library_list): Remove.
2124         (library_list_start_library): Update.
2125         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2126         return type.
2127         (solib_aix_get_library_list)
2128         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2129         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2130
2131 2019-07-10  Tom Tromey  <tromey@adacore.com>
2132
2133         * solib-dsbt.c (struct dsbt_info): Add initializers.
2134         (solib_dsbt_pspace_data): Change type.
2135         (dsbt_pspace_data_cleanup): Remove.
2136         (get_dsbt_info, _initialize_dsbt_solib): Update.
2137
2138 2019-07-10  Tom Tromey  <tromey@adacore.com>
2139
2140         * spu-tdep.c (spu_overlay_data): Change type.
2141         (spu_get_overlay_table, spu_overlay_new_objfile)
2142         (_initialize_spu_tdep): Update.
2143
2144 2019-07-10  Tom Tromey  <tromey@adacore.com>
2145
2146         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2147         destructor.
2148         (dbx_objfile_data_key): Change type and declare later.
2149         (DBX_SYMFILE_INFO): Rewrite.
2150         * dbxread.c (dbx_objfile_data_key): Change type.
2151         (dbx_symfile_init): Update.
2152         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2153         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2154         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2155
2156 2019-07-10  Tom Tromey  <tromey@adacore.com>
2157
2158         * jit.c (jit_program_space_key): Change type.  Move lower.
2159         (get_jit_program_space_data): Update.
2160         (jit_program_space_data_cleanup): Remove.
2161         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2162         Update.
2163         (struct jit_program_space_data): Add initializers.
2164
2165 2019-07-10  Tom Tromey  <tromey@adacore.com>
2166
2167         * solib-darwin.c (struct darwin_info): Add initializers.
2168         (solib_darwin_pspace_data): Change type.
2169         (darwin_pspace_data_cleanup): Remove.
2170         (get_darwin_info, _initialize_darwin_solib): Update.
2171
2172 2019-07-10  Tom Tromey  <tromey@adacore.com>
2173
2174         * remote-sim.c (struct sim_inferior_data): Add initializers,
2175         constructor, and destructor.
2176         (sim_inferior_data_key): Change type.  Move lower.
2177         (check_for_duplicate_sim_descriptor): Update.
2178         (get_sim_inferior_data): Use new.  Update.
2179         (~sim_inferior_data_cleanup): Rename from
2180         sim_inferior_data_cleanup.  Simplify.
2181         (gdbsim_close_inferior, simulator_command)
2182         (sim_command_completer, _initialize_remote_sim): Update.
2183         (next_pid, INITIAL_PID): Move earlier.
2184
2185 2019-07-10  Tom Tromey  <tromey@adacore.com>
2186
2187         * python/python-internal.h (create_thread_object): Return
2188         gdbpy_ref.
2189         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2190         * python/py-inferior.c (struct threadlist_entry): Add
2191         constructor.
2192         <thread_obj>: Now a gdbpy_ref.
2193         (thread_to_thread_object): Update.
2194         (add_thread_object): Use new.
2195         (delete_thread_object): Use delete.
2196         (infpy_threads): Update.
2197         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2198         GIL.
2199
2200 2019-07-10  Tom Tromey  <tromey@adacore.com>
2201
2202         * valops.c (value_cast): Specialize error message for Ada.
2203
2204 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2205
2206         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2207
2208 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2209
2210         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2211         bpstat_should_step): Return bool, adjust comments.
2212         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2213         bpstat_should_step): Likewise.
2214
2215 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2216
2217         * features/Makefile: Use feature target descriptions for Arm.
2218         * features/arm/arm-core.c: Generate new file.
2219         * features/arm/arm-fpa.c: Likewise.
2220         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2221         * features/arm/arm-m-profile.c: Likewise.
2222         * features/arm/arm-vfpv2.c: Likewise.
2223         * features/arm/arm-vfpv3.c: Likewise.
2224         * features/arm/xscale-iwmmxt.c: Likewise.
2225         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2226
2227 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2228
2229         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2230         ptrace earlier.
2231
2232 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2233
2234         * features/aarch64-pauth.c: Regenerate.
2235
2236 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2237
2238         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2239         bool.
2240         (bpstat_what): Use false instead of 0.
2241
2242 2019-07-09  Pedro Alves  <palves@redhat.com>
2243
2244         * break-catch-throw.c (is_exception_catchpoint): New.
2245         * breakpoint.c (print_one_breakpoint_location): New parameter
2246         'raw_loc'.  Handle it.  Use
2247         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2248         looking at the breakpoint's type.
2249         (print_one_breakpoint): If handling "maint info breakpoints", also
2250         print locations of exception catchpoints.
2251         * breakpoint.h (is_exception_catchpoint): Declare.
2252
2253 2019-07-09  Pedro Alves  <palves@redhat.com>
2254
2255         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2256         "addr" field.
2257         (allocate_location_exception_catchpoint): New.
2258         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2259         (initialize_throw_catchpoint_ops): Install
2260         allocate_location_exception_catchpoint as allocate_location
2261         method.
2262         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2263         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2264         bp_loc_other.
2265         (breakpoint_address_is_meaningful): Delete.
2266         (bl_address_is_meaningful): New.
2267         (breakpoint_locations_match): Adjust comment.
2268         (bp_location_from_bp_type): New, factored out of...
2269         (bp_location::bp_location(breakpoint *)): ... this.
2270         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2271         factored out of...
2272         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2273         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2274         breakpoint_address_is_meaningful.
2275         (bp_locations_compare): Adjust comment.
2276         (update_global_location_list): Use bl_address_is_meaningful
2277         instead of breakpoint_address_is_meaningful.
2278         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2279         explicit.
2280         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2281         * python/py-breakpoint.c (bppy_get_location): No longer check
2282         whether location is null.
2283
2284 2019-07-09  Pedro Alves  <palves@redhat.com>
2285
2286         PR c++/15468
2287         * breakpoint.c (print_one_breakpoint_location): Remove
2288         single-location assert.
2289
2290 2019-07-09  Tom Tromey  <tom@tromey.com>
2291
2292         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2293         * configure: Rebuild.
2294         * configure.ac: Change common to gdbsupport.
2295         * gdbsupport: Rename from common.
2296         * acinclude.m4: Change common to gdbsupport.
2297         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2298         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2299         gdbsupport.
2300         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2301         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2302         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2303         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2304         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2305         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2306         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2307         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2308         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2309         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2310         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2311         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2312         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2313         coff-pe-read.c, command.h, compile/compile-c-support.c,
2314         compile/compile-c.h, compile/compile-cplus-symbols.c,
2315         compile/compile-cplus-types.c, compile/compile-cplus.h,
2316         compile/compile-loc2c.c, compile/compile.c, completer.c,
2317         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2318         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2319         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2320         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2321         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2322         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2323         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2324         features/aarch64-core.c, features/aarch64-fpu.c,
2325         features/aarch64-pauth.c, features/aarch64-sve.c,
2326         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2327         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2328         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2329         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2330         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2331         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2332         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2333         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2334         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2335         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2336         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2337         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2338         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2339         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2340         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2341         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2342         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2343         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2344         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2345         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2346         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2347         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2348         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2349         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2350         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2351         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2352         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2353         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2354         minsyms.c, mips-linux-tdep.c, namespace.h,
2355         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2356         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2357         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2358         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2359         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2360         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2361         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2362         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2363         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2364         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2365         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2366         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2367         procfs.c, producer.c, progspace.h, psymtab.h,
2368         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2369         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2370         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2371         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2372         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2373         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2374         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2375         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2376         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2377         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2378         target-memory.c, target.c, target.h, target/waitstatus.c,
2379         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2380         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2381         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2382         unittests/array-view-selftests.c,
2383         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2384         unittests/common-utils-selftests.c,
2385         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2386         unittests/format_pieces-selftests.c,
2387         unittests/function-view-selftests.c,
2388         unittests/lookup_name_info-selftests.c,
2389         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2390         unittests/mkdir-recursive-selftests.c,
2391         unittests/observable-selftests.c,
2392         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2393         unittests/parse-connection-spec-selftests.c,
2394         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2395         unittests/scoped_fd-selftests.c,
2396         unittests/scoped_mmap-selftests.c,
2397         unittests/scoped_restore-selftests.c,
2398         unittests/string_view-selftests.c, unittests/style-selftests.c,
2399         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2400         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2401         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2402         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2403         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2404         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2405
2406 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2407
2408         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2409         bool value.
2410         (decode_digits_ordinary): Set explicit_line field in sal.
2411         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2412         symtab_and_line that was set on an explicit line number in
2413         assembler code.  Do always update the recorded symtab and line if
2414         we do skip the prologue.
2415
2416 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2417
2418         * breakpoint.c (set_breakpoint_location_function): Remove
2419         explicit_loc parameter.
2420         (momentary_breakpoint_from_master): Update call to
2421         set_breakpoint_location_function.
2422         (add_location_to_breakpoint): Likewise.
2423
2424 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2425
2426         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2427         required features based on default bfd type when no specific bfd
2428         is present.
2429
2430 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2431
2432         * NEWS: Mention that GDB printf and eval commands can now print
2433         C-style and Ada-style convenience var strings without
2434         calling the inferior.
2435         * printcmd.c (printf_c_string): Locally print GDB internal var
2436         instead of transiting via the inferior.
2437         (printf_wide_c_string): Likewise.
2438
2439 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2440
2441         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2442
2443 2019-07-04  Tom Tromey  <tom@tromey.com>
2444
2445         PR tui/24724:
2446         * tui/tui-winsource.c (tui_clear_source_content): Update.
2447         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2448         (tui_update_breakpoint_info): Update.
2449         (tui_set_exec_info_content): Update.
2450         * tui/tui-source.c (tui_set_source_content_nil): Update.
2451         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2452         has_break.
2453         * tui/tui-data.h (enum tui_bp_flag): New.
2454         (tui_bp_flags): New enum flags type.
2455         (struct tui_source_element) <break_mode>: Change type.  Rename
2456         from has_break.
2457         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2458         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2459         constants.
2460         * tui/tui-winsource.h: Fix comment.
2461
2462 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2463
2464         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2465         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2466         (store_fpregs_to_thread)
2467         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2468         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2469         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2470         (IWMMXT_REGS_SIZE): Add define.
2471         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2472         (fetch_vfp_regs, store_vfp_regs)
2473         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2474         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2475
2476 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2477
2478         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2479         defines.
2480         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2481         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2482         (ARM_INT_REGISTER_SIZE): ...to this.
2483         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2484         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2485         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2486         (arm_linux_collect_gregset, supply_nwfpe_register)
2487         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2488         defines.
2489         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2490         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2491         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2492         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2493         (arm_return_in_memory, arm_store_return_value)
2494         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2495         (arm_record_ld_st_multiple): Likewise.
2496         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2497         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2498
2499 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2500
2501         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2502         AARCH64_DISPLACED_MODIFIED_INSNS.
2503         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2504         (aarch64_displaced_step_copy_insn): Likewise.
2505         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2506         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2507         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2508         ARM_DISPLACED_MODIFIED_INSNS.
2509         * arm-tdep.c (arm_gdbarch_init): Likewise.
2510         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2511         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2512         (struct arm_displaced_step_closure): Use
2513         ARM_DISPLACED_MODIFIED_INSNS.
2514
2515 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2516
2517         * features/Makefile: Remove unused xml files.
2518         * features/aarch64.xml: Remove.
2519         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2520         * features/i386/amd64-avx-avx512.xml: Remove.
2521         * features/i386/amd64-avx-linux.xml: Remove.
2522         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2523         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2524         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2525         * features/i386/amd64-avx-mpx.xml: Remove.
2526         * features/i386/amd64-avx.xml: Remove.
2527         * features/i386/amd64-linux.xml: Remove.
2528         * features/i386/amd64-mpx-linux.xml: Remove.
2529         * features/i386/amd64-mpx.xml: Remove.
2530         * features/i386/amd64.xml: Remove.
2531         * features/i386/i386-avx-avx512-linux.xml: Remove.
2532         * features/i386/i386-avx-avx512.xml: Remove.
2533         * features/i386/i386-avx-linux.xml: Remove.
2534         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2535         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2536         * features/i386/i386-avx-mpx-linux.xml: Remove.
2537         * features/i386/i386-avx-mpx.xml: Remove.
2538         * features/i386/i386-avx.xml: Remove.
2539         * features/i386/i386-linux.xml: Remove.
2540         * features/i386/i386-mmx-linux.xml: Remove.
2541         * features/i386/i386-mmx.xml: Remove.
2542         * features/i386/i386-mpx-linux.xml: Remove.
2543         * features/i386/i386-mpx.xml: Remove.
2544         * features/i386/i386.xml: Remove.
2545         * features/i386/x32-avx-avx512-linux.xml: Remove.
2546         * features/i386/x32-avx-linux.xml: Remove.
2547         * features/i386/x32-linux.xml: Remove.
2548
2549 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2550
2551         * regformats/aarch64.dat: Remove.
2552         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2553         * regformats/i386/amd64-avx-linux.dat: Remove.
2554         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2555         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2556         * regformats/i386/amd64-linux.dat: Remove.
2557         * regformats/i386/amd64-mpx-linux.dat: Remove.
2558         * regformats/i386/amd64.dat: Remove.
2559         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2560         * regformats/i386/i386-avx-linux.dat: Remove.
2561         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2562         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2563         * regformats/i386/i386-linux.dat: Remove.
2564         * regformats/i386/i386-mmx-linux.dat: Remove.
2565         * regformats/i386/i386-mpx-linux.dat: Remove.
2566         * regformats/i386/i386.dat: Remove.
2567         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2568         * regformats/i386/x32-avx-linux.dat: Remove.
2569         * regformats/i386/x32-linux.dat: Remove.
2570
2571 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2572
2573         * aarch64-tdep.c: Remove xml self tests.
2574         * amd64-linux-tdep.c: Likewise.
2575         * amd64-tdep.c: Likewise.
2576         * i386-linux-tdep.c: Likewise.
2577         * i386-tdep.c: Likewise.
2578
2579 2019-07-03  Pedro Alves  <palves@redhat.com>
2580
2581         PR cli/24732
2582         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2583         (pipe_cmd_option_defs): New.
2584         (make_pipe_cmd_options_def_group): New.
2585         (pipe_command): Use gdb::option::process_options.
2586         (pipe_command_completer): New function.
2587         (_initialize_cli_cmds): Install completer for "pipe" command.
2588
2589 2019-07-03  Pedro Alves  <palves@redhat.com>
2590
2591         * cli/cli-option.c (union option_value) <string>: New field.
2592         (struct option_def_and_value): Add ctor, move ctor, dtor and
2593         use DISABLE_COPY_AND_ASSIGN.
2594         (option_def_and_value::clear_value): New.
2595         (parse_option, save_option_value_in_ctx, get_val_type_str)
2596         (add_setshow_cmds_for_options): Handle var_string.
2597         * cli-option.h (union option_def::var_address) <string>: New
2598         field.
2599         (struct string_option_def): New.
2600         * maint-test-options.c (struct test_options_opts): Add default
2601         ctor and use DISABLE_COPY_AND_ASSIGN.
2602         <string_opt>: New field.
2603         (test_options_opts::~test_options_opts): New.
2604         (test_options_opts::dump): Also dump "-string".
2605         (test_options_option_defs): Install "string.
2606
2607 2019-07-03  Pedro Alves  <palves@redhat.com>
2608
2609         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2610         option_value with a null enumeration.
2611         (complete_options): Save the option values in the context.
2612         (save_option_value_in_ctx): New, factored out from ...
2613         (process_options): ... here.
2614         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2615         of the function.
2616         * maint-test-options.c (test_options_opts::dump): New, factored
2617         out from ...
2618         (maintenance_test_options_command_mode): ... here.
2619         (maintenance_test_options_command_completion_result): Delete.
2620         (maintenance_test_options_command_completion_text): Update
2621         comment.
2622         (maintenance_show_test_options_completion_result): Change
2623         prototype.  Just print
2624         maintenance_test_options_command_completion_text.
2625         (save_completion_result): New.
2626         (maintenance_test_options_completer_mode): Pass options context to
2627         complete_options, and then save a dump.
2628         (_initialize_maint_test_options): Use add_cmd to install "maint
2629         show test-options-completion-result".
2630
2631 2019-07-03  Pedro Alves  <palves@redhat.com>
2632
2633         * NEWS (New commands): Mention "with" and "maint with".
2634         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2635         (with_command, with_command_completer): New.
2636         (pipe_command): Adjust to new repeat_previous
2637         interface.
2638         (_initialize_cli_cmds): Install the "with" command and its "w"
2639         alias.
2640         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2641         declarations.
2642         * cli/cli-setshow.c (parse_cli_var_uinteger)
2643         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2644         argument strings for all var_types.
2645         (get_setshow_command_value_string): New, factored out from ...
2646         (do_show_command): ... this.
2647         * cli/cli-setshow.h: Include <string>.
2648         (get_setshow_command_value_string): Declare.
2649         * command.h (repeat_previous): Now returns const char *.  Adjust
2650         comment.
2651         * maint.c: Include "cli/cli-cmds.h".
2652         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2653         (_initialize_maint_cmds): Register the "maintenance with" command.
2654         * top.c (repeat_previous): Move bits from pipe_command here:
2655         Return the saved command line, if any; error out if there's no
2656         command to relaunch.
2657
2658 2019-07-03  Pedro Alves  <palves@redhat.com>
2659
2660         * NEWS (New commands): Mention "maint set/show test-settings"
2661         instead of "maint test-settings".
2662         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2663         (maintenance_test_settings_set_list): Rename to ...
2664         (maintenance_set_test_settings_list): ... this.
2665         (maintenance_test_settings_show_list): Rename to  ...
2666         (maintenance_show_test_settings_list): ... this.
2667         (maintenance_test_settings_cmd): Delete.
2668         (maintenance_test_settings_set_cmd): ...
2669         (maintenance_set_test_settings_cmd): ... this.
2670         (maintenance_test_settings_show_cmd): ...
2671         (maintenance_show_test_settings_cmd): ... this.
2672         (maintenance_test_settings_show_value_cmd):
2673         (maintenance_show_test_settings_value_cmd): ... this.
2674         (_initialize_maint_test_settings): No longer install the "maint
2675         test-settings" prefix command.  Rename "maint test-settings set"
2676         to "maint set test-settings", and "maint test-settings show" to
2677         "maint show test-settings".  Adjust all subcommands.
2678
2679 2019-07-03  Pedro Alves  <palves@redhat.com>
2680
2681         * maint-test-settings.c: Fix file's intro comment.  Replace all
2682         references to "test-options" with references to "test-settings",
2683         in comments.
2684
2685 2019-07-03  Pedro Alves  <palves@redhat.com>
2686
2687         * maint-test-settings.c (maintenance_test_settings_xxx)
2688         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2689         New.
2690         (maintenance_test_settings_enums): Use them.
2691         (maintenance_test_settings_enum): Default to
2692         maintenance_test_settings_xxx.
2693         (_initialize_maint_test_settings): Initialize
2694         MAINTENANCE_TEST_SETTINGS_FILENAME.
2695
2696 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2697
2698         * breakpoint.h (remove_breakpoints_inf): Change return type to
2699         void, move function documentation here.
2700         * breakpoint.c (remove_breakpoints_inf): Change return type to
2701         void, move function documentation to header.
2702
2703 2019-07-02  Pedro Alves  <palves@redhat.com>
2704
2705         * NEWS (Completion improvements): Mention "info threads".
2706         * thread.c (struct info_threads_opts, info_threads_option_defs)
2707         (make_info_threads_options_def_group): New.
2708         (info_threads_command): Use gdb::option::process_options.
2709         (info_threads_command_completer): New.
2710         (_initialize_thread): Use gdb::option::build_help to build the
2711         help text for "info threads".
2712
2713 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2714
2715         * defs.h (generic_load): Move from here...
2716         * symfile.h (generic_load): ... to here.  Rename name parameter
2717         to args.
2718         * symfile.c (generic_load): Add comment.
2719
2720 2019-07-01  Tom Tromey  <tromey@adacore.com>
2721
2722         * dwarf2read.c
2723         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2724         declaration of without_params.  Fix formatting.
2725
2726 2019-07-01  Tom Tromey  <tromey@adacore.com>
2727
2728         * ada-exp.y (find_primitive_type): Update.
2729         * ada-lang.h (ada_lookup_symbol): Update.
2730         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2731         parameter.
2732         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2733
2734 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2735
2736         PR breakpoints/24541
2737         * gdbarch.c: Regenerate.
2738         * gdbarch.h: Regenerate.
2739         * gdbarch.sh: Add 'stap_adjust_register'.
2740         * i386-tdep.c: Include '<unordered_set>'.
2741         (i386_stap_adjust_register): New function.
2742         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2743         * stap-probe.c (stap_parse_register_operand): Call
2744         'gdbarch_stap_adjust_register'.
2745
2746 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2747
2748         PR python/24742
2749         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2750         * python/python.c (do_start_initialization): Use 'xmalloc'
2751         instead of 'PyMem_Malloc'.
2752
2753 2019-06-28  Tom Tromey  <tromey@adacore.com>
2754
2755         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2756         for Ada.
2757
2758 2019-06-27  Tom Tromey  <tromey@adacore.com>
2759
2760         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2761         objfile_key.
2762         (arm_find_mapping_symbol, arm_record_special_symbol)
2763         (_initialize_arm_tdep): Update.
2764         (arm_objfile_data_free): Remove.
2765
2766 2019-06-27  Tom Tromey  <tromey@adacore.com>
2767
2768         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2769         to cp_print_static_field.
2770
2771 2019-06-26  Tom Tromey  <tromey@adacore.com>
2772
2773         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2774         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2775         declare.
2776
2777 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2778
2779         * features/aarch64-core.c (create_feature_aarch64_core):
2780         Regenerate.
2781         * features/aarch64-core.xml: Add cpsr flags.
2782
2783 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2784
2785         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2786         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2787
2788 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2789
2790         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2791         field.
2792         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2793         use.
2794         (arm_record_special_symbol): Don't insert new symbol in sorted
2795         position, push it at the end.
2796
2797 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2798
2799         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2800         (arm_mapping_symbol_s): Remove.
2801         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2802         (arm_mapping_symbol_vec): New typedef.
2803         (struct arm_per_objfile): Add constructor.
2804         <section_maps>: Change type to
2805         std::unique_ptr<arm_mapping_symbol_vec[]>.
2806         (arm_compare_mapping_symbols): Remove.
2807         (arm_find_mapping_symbol): Adjust to section_maps type change.
2808         (arm_objfile_data_free): Call delete on arm_per_objfile.
2809         (arm_record_special_symbol): Adjust to section_maps type change.
2810         Allocate arm_per_objfile with new.
2811
2812 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2813
2814         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2815         with the command prefix.
2816
2817 2019-06-25  Tom Tromey  <tom@tromey.com>
2818
2819         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2820         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2821
2822 2019-06-25  Tom Tromey  <tom@tromey.com>
2823
2824         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2825         type.
2826         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2827         protected.
2828
2829 2019-06-25  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-winsource.c
2832         (tui_source_window_base::set_is_exec_point_at): Add check against
2833         LOA_ADDRESS.
2834
2835 2019-06-25  Tom Tromey  <tom@tromey.com>
2836
2837         * tui/tui-source.c (tui_set_source_content): Don't check before
2838         xfree.
2839         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2840
2841 2019-06-25  Tom Tromey  <tom@tromey.com>
2842
2843         * tui/tui-winsource.h (tui_update_source_window_as_is)
2844         (tui_alloc_source_buffer, tui_line_is_displayed)
2845         (tui_addr_is_displayed): Change type of win_info.
2846         * tui/tui-winsource.c (tui_update_source_window_as_is)
2847         (tui_clear_source_content, tui_show_source_line)
2848         (tui_show_source_content, tui_source_window_base::refill)
2849         (tui_source_window_base::set_is_exec_point_at)
2850         (tui_source_window_base::set_is_exec_point_at)
2851         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2852         (tui_alloc_source_buffer, tui_line_is_displayed)
2853         (tui_addr_is_displayed): Change type of win_info.  Update.
2854         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2855         (tui_source_window_base::do_make_visible_with_new_height):
2856         Update.
2857         * tui/tui-source.c (tui_set_source_content)
2858         (tui_set_source_content_nil)
2859         (tui_source_window::do_scroll_vertical): Update.
2860         * tui/tui-layout.c (show_layout): Update.
2861         * tui/tui-disasm.c (tui_set_disassem_content)
2862         (tui_disasm_window::do_scroll_vertical): Update.
2863         * tui/tui-data.h (tui_win_content): Remove.
2864         (struct tui_gen_win_info) <content, content_size>: Remove.
2865         (struct tui_source_element): Add initializers and destructor.
2866         (union tui_which_element, struct tui_win_element): Remove.
2867         (struct tui_source_window_base) <content>: New field.
2868         (struct tui_data_window): Remove destructor.
2869         (tui_alloc_content, tui_free_win_content)
2870         (tui_free_all_source_wins_content): Don't declare.
2871         * tui/tui-data.c (tui_initialize_static_data): Update.
2872         (init_content_element, tui_alloc_content): Remove.
2873         (~tui_gen_win_info): Update.
2874         (~tui_data_window, tui_free_all_source_wins_content)
2875         (tui_free_win_content, free_content, free_content_elements):
2876         Remove.
2877
2878 2019-06-25  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui-winsource.h (tui_clear_source_content)
2881         (tui_erase_source_content, tui_show_source_content): Change type
2882         of win_info.
2883         * tui/tui-winsource.c (tui_clear_source_content)
2884         (tui_erase_source_content, tui_show_source_content): Change type
2885         of win_info.
2886         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2887         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2888         win_info.
2889         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2890         win_info.
2891         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2892
2893 2019-06-25  Tom Tromey  <tom@tromey.com>
2894
2895         * tui/tui-winsource.c (tui_clear_source_content)
2896         (tui_source_window_base::set_is_exec_point_at): Update.
2897         * tui/tui-source.c (tui_set_source_content_nil): Update.
2898         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2899         a bool.
2900         * tui/tui-data.c (init_content_element): Update.
2901
2902 2019-06-25  Tom Tromey  <tom@tromey.com>
2903
2904         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2905         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2906         * tui/tui-layout.c (init_and_make_win): Update.
2907         * tui/tui.h (enum tui_win_type): Update.
2908         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2909         tui_win_is_auxillary.
2910         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2911         tui_win_is_auxillary.
2912
2913 2019-06-25  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2916         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2917         (tui_delete_data_content_windows, tui_display_all_data)
2918         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2919         Update.
2920         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2921         * tui/tui-regs.c (tui_last_regs_line_no)
2922         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2923         (tui_show_registers): Update.
2924         (tui_show_register_group): Return void.  Update.
2925         (tui_display_registers_from, tui_display_reg_element_at_line)
2926         (tui_display_registers_from_line, tui_check_register_values):
2927         Update.
2928         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2929         member.
2930         (struct tui_data_window) <regs_content>: Now a std::vector.
2931         <regs_content_count>: Remove.
2932         (tui_add_content_elements, tui_free_data_content): Don't declare.
2933         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2934         (init_content_element): Remove DATA_WIN case.  Add assert.
2935         (tui_add_content_elements): Remove.
2936         (tui_data_window): Update.
2937         (tui_free_data_content): Remove.
2938         (free_content_elements): Remove DATA_WIN case.
2939
2940 2019-06-25  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui-data.c (tui_data_item_window): Update.
2943         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2944         * tui/tui-windata.c (tui_display_all_data)
2945         (tui_display_data_from_line): Update.
2946         (tui_check_data_values): Remove.
2947         * tui/tui-regs.c (tui_show_register_group)
2948         (tui_display_reg_element_at_line): Update.
2949         * tui/tui-hooks.c (tui_register_changed)
2950         (tui_refresh_frame_and_register_information): Call
2951         tui_check_register_values.
2952         * tui/tui-data.h (struct tui_data_window) <data_content,
2953         data_content_count, data_type>: Remove.
2954         (enum tui_data_type): Remove.
2955
2956         * tui/tui-data.c (tui_data_window::clear_detail)
2957         (~tui_data_window): Update.
2958
2959 2019-06-25  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2962         declare.
2963         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2964         Rename from tui_first_data_item_displayed.  Update.
2965         (tui_data_window::refresh_all)
2966         (tui_data_window::do_scroll_vertical): Update.
2967         * tui/tui-data.h (struct tui_data_window)
2968         <first_data_item_displayed>: Declare new method.
2969
2970 2019-06-25  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2973         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2974         contents...
2975         (tui_initialize_static_data): ...here.
2976
2977 2019-06-25  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2980         (tui_display_registers_from, tui_check_register_values): Update.
2981         (tui_display_register): Remove win_info parameter; update.
2982         (tui_get_register): Change type of parameters.
2983         * tui/tui-data.h (struct tui_data_element): Remove.
2984         (union tui_which_element) <data>: Remove.
2985         <data_window>: Change type.
2986         (struct tui_data_item_window): New.
2987         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2988         case.  Add assert.
2989         (~tui_data_item_window): New destructor.
2990         (free_content_elements): Remove DATA_ITEM_WIN case.
2991
2992 2019-06-25  Tom Tromey  <tom@tromey.com>
2993
2994         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2995         Remove.
2996
2997 2019-06-25  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui-data.h (struct tui_command_element): Remove.
3000         (union tui_which_element) <command>: Remove.
3001         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3002         assert.
3003         (free_content_elements): Remove CMD_WIN case.
3004
3005 2019-06-25  Tom Tromey  <tom@tromey.com>
3006
3007         * tui/tui-layout.c (tui_set_layout): Update.
3008         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3009         * tui/tui-data.c (layout_def): Update.
3010
3011 2019-06-25  Tom Tromey  <tom@tromey.com>
3012
3013         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3014         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3015         (tui_source_window_base::set_new_height): Update.
3016         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3017         Update.
3018         (tui_set_locator_fullname, tui_set_locator_info)
3019         (tui_show_frame_info): Update.
3020         * tui/tui-source.c (tui_set_source_content)
3021         (tui_source_is_displayed): Update.
3022         * tui/tui-layout.c (show_source_disasm_command, show_data)
3023         (show_source_or_disasm_and_command): Update.
3024         * tui/tui-disasm.c (tui_set_disassem_content)
3025         (tui_get_begin_asm_address): Update.
3026         * tui/tui-data.h (struct tui_locator_element): Remove.
3027         (union tui_which_element) <locator>: Remove.
3028         (struct tui_locator_window): New.
3029         (tui_locator_win_info_ptr): Change return type.
3030         * tui/tui-data.c (_locator): Change type.
3031         (tui_locator_win_info_ptr): Change return type.
3032         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3033         (tui_alloc_content): Add assert.
3034
3035 2019-06-25  Tom Tromey  <tom@tromey.com>
3036
3037         * tui/tui-winsource.c
3038         (tui_exec_info_window::maybe_allocate_content): New method.
3039         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3040         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3041         (make_source_or_disasm_window): Add cast.
3042         * tui/tui-data.h (union tui_which_element) <simple_string>:
3043         Remove.
3044         (struct tui_source_info): New.
3045         (struct tui_source_window_base) <execution_info>: Change type.
3046         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3047         case, and add assert.
3048         (tui_alloc_content): Add assert.
3049
3050 2019-06-25  Tom Tromey  <tom@tromey.com>
3051
3052         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3053         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3054         * tui/tui-data.c (tui_alloc_win_info): Remove.
3055
3056 2019-06-25  Tom Tromey  <tom@tromey.com>
3057
3058         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3059         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3060         can_highlight.
3061
3062 2019-06-25  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3065         make_visible_with_new_height method.
3066         (tui_win_info::make_visible_with_new_height): New method.
3067         (tui_source_window_base::do_make_visible_with_new_height)
3068         (tui_data_window::do_make_visible_with_new_height)
3069         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3070         (make_visible_with_new_height): Remove.
3071         (tui_resize_all, tui_adjust_win_heights): Use
3072         make_visible_with_new_height method.
3073         * tui/tui-data.h (struct tui_win_info)
3074         <do_make_visible_with_new_height, make_visible_with_new_height>:
3075         New methods.
3076         (struct tui_source_window_base, struct tui_data_window)
3077         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3078         methods.
3079
3080 2019-06-25  Tom Tromey  <tom@tromey.com>
3081
3082         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3083         method.
3084         (update_tab_width): Call update_tab_width method.
3085         * tui/tui-data.h (struct tui_win_info)
3086         (struct tui_source_window_base) <update_tab_width>: New methods.
3087
3088 2019-06-25  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3091         parameter.
3092         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3093         parameter.
3094         (tui_gen_win_info::make_visible): Update.
3095         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3096         parameter.
3097         * tui/tui-data.h (enum tui_box): New enum.
3098         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3099
3100 2019-06-25  Tom Tromey  <tom@tromey.com>
3101
3102         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3103         init_and_make_win for EXEC_INFO_WIN.
3104         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3105         longer inline.
3106         (struct tui_win_info) <~tui_win_info>: Inline.
3107         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3108         Don't declare.
3109         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3110         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3111         Remove.
3112         (tui_initialize_static_data): Update.
3113         (~tui_gen_win_info): Handle more cleanup here.
3114         (~tui_source_window_base): Delete "execution_info".
3115         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3116
3117 2019-06-25  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-layout.c (make_command_window): Don't set
3120         can_highlight.
3121         (show_source_disasm_command): Call the reset method.
3122         (show_data): Don't set can_highlight.  Call the reset method.
3123         (tui_gen_win_info::reset): Rename from init_gen_win_info
3124         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3125         (show_source_or_disasm_and_command): Call the reset method.
3126         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3127         (struct tui_cmd_window): Set can_highlight.
3128
3129 2019-06-25  Tom Tromey  <tom@tromey.com>
3130
3131         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3132         from make_visible.
3133         (tui_make_visible, tui_make_invisible): Rewrite.
3134         (tui_win_info::make_visible): Remove.
3135         (tui_source_window_base::make_visible): Update.
3136         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3137         method.  Moved from...
3138         (struct tui_win_info) <make_visible>: ...here.
3139
3140 2019-06-25  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-winsource.c
3143         (tui_source_window_base::do_scroll_horizontal): Remove direction
3144         parameter.
3145         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3146         direction parameter.
3147         * tui/tui-win.c (tui_win_info::forward_scroll)
3148         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3149         (tui_win_info::right_scroll): Update.
3150         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3151         direction parameter.
3152         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3153         direction parameter.
3154         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3155         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3156         Remove direction parameter.
3157         (struct tui_source_window_base, struct tui_source_window)
3158         (struct tui_disasm_window, struct tui_data_window)
3159         (struct tui_cmd_window): Update.
3160
3161 2019-06-25  Tom Tromey  <tom@tromey.com>
3162
3163         * tui/tui-winsource.h (tui_set_exec_info_content)
3164         (tui_show_exec_info_content, tui_erase_exec_info_content)
3165         (tui_clear_exec_info_content, tui_update_exec_info): Change
3166         argument to tui_source_window_base.
3167         * tui/tui-winsource.c (tui_set_exec_info_content)
3168         (tui_show_exec_info_content, tui_erase_exec_info_content)
3169         (tui_clear_exec_info_content, tui_update_exec_info): Change
3170         argument to tui_source_window_base.
3171
3172 2019-06-25  Tom Tromey  <tom@tromey.com>
3173
3174         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3175         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3176
3177 2019-06-25  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3180         check.
3181
3182 2019-06-25  Tom Tromey  <tom@tromey.com>
3183
3184         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3185         type to void.
3186         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3187         type to void.
3188         * tui/tui-source.c (tui_set_source_content): Update.
3189         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3190
3191 2019-06-25  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-win.c (window_name_completer, tui_set_focus)
3194         (tui_all_windows_info): Use name method.
3195         * tui/tui-data.h (struct tui_gen_win_info)
3196         (struct tui_source_window, struct tui_disasm_window)
3197         (struct tui_data_window, struct tui_cmd_window) <name>: New
3198         method.
3199         (tui_win_name): Don't declare.
3200         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3201         (tui_win_name): Remove.
3202
3203 2019-06-25  Tom Tromey  <tom@tromey.com>
3204
3205         * tui/tui-winsource.h (tui_update_source_window)
3206         (tui_update_source_window_as_is): Change parameter type.
3207         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3208         to be a tui_source_window_base.
3209         (tui_update_source_window_as_is): Likewise.
3210         * tui/tui-win.c (make_visible_with_new_height): Update.
3211
3212 2019-06-25  Tom Tromey  <tom@tromey.com>
3213
3214         * tui/tui-winsource.c (tui_erase_source_content)
3215         (tui_show_source_content, tui_show_exec_info_content)
3216         (tui_erase_exec_info_content): Use refresh_window method.
3217         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3218         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3219         from tui_refresh_win.
3220         (tui_data_window::refresh_window): New method.
3221         (tui_win_info::refresh, tui_source_window_base::refresh)
3222         (tui_refresh_all): Use refresh_window method.
3223         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3224         method.
3225         * tui/tui-regs.c (tui_display_register): Call refresh_window
3226         method.
3227         * tui/tui-layout.c (show_source_disasm_command)
3228         (show_source_or_disasm_and_command): Call refresh_window method.
3229         * tui/tui-data.h (struct tui_gen_win_info)
3230         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3231         New method.
3232
3233 2019-06-25  Tom Tromey  <tom@tromey.com>
3234
3235         * tui/tui.c (tui_rl_other_window, tui_enable)
3236         (tui_is_window_visible, tui_get_command_dimension): Update.
3237         * tui/tui-winsource.c (tui_update_source_window_as_is)
3238         (tui_clear_source_content, tui_erase_source_content)
3239         (tui_show_source_line, tui_source_window_base::refill)
3240         (tui_source_window_base::do_scroll_horizontal)
3241         (tui_source_window_base::set_is_exec_point_at)
3242         (tui_update_breakpoint_info, tui_set_exec_info_content)
3243         (tui_alloc_source_buffer, tui_line_is_displayed)
3244         (tui_addr_is_displayed): Update.
3245         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3246         (tui_check_and_display_highlight_if_needed)
3247         (tui_win_info::make_visible, tui_win_info::refresh)
3248         (tui_refresh_all): Update.
3249         * tui/tui-windata.c (tui_first_data_item_displayed)
3250         (tui_delete_data_content_windows, tui_erase_data_content)
3251         (tui_display_all_data, tui_data_window::refresh_all)
3252         (tui_check_data_values): Update.
3253         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3254         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3255         (tui_win_info::backward_scroll, tui_refresh_all_win)
3256         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3257         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3258         (tui_source_window_base::set_new_height)
3259         (tui_data_window::set_new_height)
3260         (make_invisible_and_set_new_height)
3261         (make_visible_with_new_height, new_height_ok)
3262         (parse_scrolling_args): Update.
3263         * tui/tui-stack.c (tui_show_frame_info): Update.
3264         * tui/tui-source.c (tui_set_source_content)
3265         (tui_set_source_content_nil, tui_source_is_displayed)
3266         (tui_source_window::do_scroll_vertical): Update.
3267         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3268         (tui_display_registers_from, tui_display_reg_element_at_line)
3269         (tui_check_register_values, tui_reg_command): Update.
3270         * tui/tui-layout.c (tui_default_win_height)
3271         (show_source_disasm_command, show_data, init_and_make_win)
3272         (show_source_or_disasm_and_command): Update.
3273         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3274         (tui_redisplay_readline, tui_mld_flush)
3275         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3276         (tui_getc): Update.
3277         * tui/tui-disasm.c (tui_set_disassem_content)
3278         (tui_disasm_window::do_scroll_vertical): Update.
3279         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3280         Now virtual.
3281         (struct tui_win_info): Derive from tui_gen_win_info.
3282         <~tui_win_info>: Mark as override.
3283         <generic>: Remove member.
3284         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3285         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3286         (~tui_data_window, ~tui_win_info)
3287         (tui_free_all_source_wins_content): Update.
3288         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3289
3290 2019-06-25  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-layout.c (init_and_make_win): Use new.
3293         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3294         destructor, initializers.
3295         (tui_alloc_generic_win_info): Don't declare.
3296         * tui/tui-data.c (_locator): Add argument to constructor.
3297         (source_win, disasm_win): New globals.
3298         (exec_info): Remove.
3299         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3300         Update.
3301         (tui_alloc_generic_win_info): Remove.
3302         (init_content_element): Use new.
3303         (tui_win_info::tui_win_info): Update.
3304         (free_content_elements) <case DATA_WIN>: Use delete.
3305
3306 2019-06-25  Tom Tromey  <tom@tromey.com>
3307
3308         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3309         * tui/tui-windata.c (tui_first_data_item_displayed)
3310         (tui_delete_data_content_windows): Update.
3311         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3312         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3313         (tui_display_registers_from, tui_check_register_values): Update.
3314         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3315         pointer.
3316         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3317         window.
3318         (tui_free_data_content): Update.
3319         (free_content_elements) <case DATA_WIN>: Free the window.
3320
3321 2019-06-25  Tom Tromey  <tom@tromey.com>
3322
3323         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3324         Update.
3325         * tui/tui-layout.c (make_command_window)
3326         (show_source_disasm_command, show_data, init_and_make_win)
3327         (show_source_or_disasm_and_command): Update.
3328         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3329         method.
3330         <can_highight, is_highlighted>: Now bool.
3331         (tui_set_win_highlight): Don't declare.
3332         * tui/tui-data.c (tui_set_win_highlight): Remove.
3333
3334 2019-06-25  Tom Tromey  <tom@tromey.com>
3335
3336         * tui/tui-wingeneral.c (make_visible): Remove check of window
3337         type.
3338
3339 2019-06-25  Tom Tromey  <tom@tromey.com>
3340
3341         * tui/tui-win.c (tui_win_info::max_height)
3342         (tui_cmd_window::max_height): New methods.
3343         (new_height_ok): Call max_height.
3344         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3345         <max_height>: New method.
3346
3347 2019-06-25  Tom Tromey  <tom@tromey.com>
3348
3349         * tui/tui-win.c (tui_source_window_base::set_new_height)
3350         (tui_data_window::set_new_height): New methods.
3351         (make_invisible_and_set_new_height): Call set_new_height method.
3352         * tui/tui-data.h (struct tui_win_info)
3353         (struct tui_source_window_base, struct tui_data_window)
3354         <set_new_height>: New method.
3355
3356 2019-06-25  Tom Tromey  <tom@tromey.com>
3357
3358         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3359         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3360         tui_refresh_data_win.
3361         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3362         method.
3363         (tui_refresh_all_win): Call the refresh_all method.
3364         (tui_set_focus): Likewise.
3365         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3366         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3367         Likewise.
3368
3369 2019-06-25  Tom Tromey  <tom@tromey.com>
3370
3371         * tui/tui-winsource.h (tui_refill_source_window)
3372         (tui_set_is_exec_point_at): Don't declare.
3373         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3374         (tui_source_window_base::refill): Rename from
3375         tui_refill_source_window.
3376         (tui_source_window_base::do_scroll_horizontal): Update.
3377         (tui_source_window_base::set_is_exec_point_at): Rename from
3378         tui_set_is_exec_point_at.
3379         (tui_update_all_breakpoint_info): Update.
3380         * tui/tui-stack.c (tui_show_frame_info): Update.
3381         * tui/tui-layout.c (show_data): Add cast.
3382         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3383         * tui/tui-data.h (struct tui_source_window_base) <refill,
3384         set_is_exec_point_at>: New methods.
3385         (tui_source_windows, tui_add_to_source_windows): Update types.
3386         (tui_add_to_source_windows): Remove redundant declaration.
3387         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3388         (tui_source_windows): Change return type.
3389         (tui_clear_source_windows_detail): Update.
3390         (tui_add_to_source_windows): Change type of parameter.
3391         (tui_free_all_source_wins_content): Update.
3392
3393 2019-06-25  Tom Tromey  <tom@tromey.com>
3394
3395         * tui/tui-wingeneral.c (tui_win_info::refresh)
3396         (tui_source_window_base::refresh): New methods.
3397         (tui_refresh_all): Call the refresh method.
3398         * tui/tui-data.h (struct tui_win_info)
3399         (struct tui_source_window_base) <refresh>: New method.
3400
3401 2019-06-25  Tom Tromey  <tom@tromey.com>
3402
3403         * tui/tui.h (tui_is_window_visible): Return bool.
3404         * tui/tui.c (tui_is_window_visible): Return bool.
3405         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3406         (tui_make_visible, tui_make_invisible)
3407         (tui_win_info::make_visible)
3408         (tui_source_window_base::make_visible, make_all_visible)
3409         (tui_make_all_visible, tui_make_all_invisible): Update.
3410         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3411         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3412         bool.
3413         (struct tui_win_info, struct tui_source_window_base)
3414         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3415         * tui/tui-data.c (tui_init_generic_part): Update.
3416
3417 2019-06-25  Tom Tromey  <tom@tromey.com>
3418
3419         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3420         (tui_source_window_base::make_visible): New methods.
3421         (make_all_visible): Make method call.
3422         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3423         (struct tui_source_window_base, struct tui_cmd_window): Override
3424         make_visible.
3425         (tui_win_is_source_type): Don't declare.
3426         * tui/tui-data.c (tui_win_is_source_type): Remove.
3427
3428 2019-06-25  Tom Tromey  <tom@tromey.com>
3429
3430         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3431         NULL check.
3432
3433 2019-06-25  Tom Tromey  <tom@tromey.com>
3434
3435         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3436         Inline constructor.  Add initializers for members.
3437         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3438         constructors; now inline in class.
3439
3440 2019-06-25  Tom Tromey  <tom@tromey.com>
3441
3442         * tui/tui-regs.c (tui_show_registers): Update.
3443         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3444         bool.
3445         * tui/tui-data.c (tui_data_window::clear_detail)
3446         (tui_data_window): Update.
3447
3448 2019-06-25  Tom Tromey  <tom@tromey.com>
3449
3450         * tui/tui-windata.c (tui_display_all_data)
3451         (tui_display_data_from_line, tui_display_data_from)
3452         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3453         Update.
3454         * tui/tui-regs.c (tui_last_regs_line_no)
3455         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3456         (tui_show_registers, tui_show_register_group)
3457         (tui_display_registers_from, tui_display_reg_element_at_line)
3458         (tui_display_registers_from_line, tui_check_register_values)
3459         (tui_reg_next, tui_reg_prev): Update.
3460         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3461         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3462         tui_data_window.
3463         (struct tui_win_info) <detail>: Remove.  Add new fields from
3464         tui_data_info.
3465         (TUI_DATA_WIN): Add cast.
3466         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3467         (~tui_data_window): Simplify.
3468
3469 2019-06-25  Tom Tromey  <tom@tromey.com>
3470
3471         * tui/tui-layout.c (show_source_disasm_command)
3472         (show_source_or_disasm_and_command): Update.
3473         * tui/tui-io.c (update_cmdwin_start_line)
3474         (tui_redisplay_readline): Update.
3475         * tui/tui-data.h (struct tui_command_info): Remove.
3476         (struct tui_win_info) <detail>: Remove command_info member.
3477         (struct tui_data_window) <start_line>: New member, from
3478         tui_command_info.
3479         (TUI_CMD_WIN): Add casts.
3480
3481 2019-06-25  Tom Tromey  <tom@tromey.com>
3482
3483         * tui/tui-winsource.c (tui_update_source_window)
3484         (tui_refill_source_window)
3485         (tui_source_window_base::do_scroll_horizontal)
3486         (tui_update_breakpoint_info, tui_set_exec_info_content)
3487         (tui_show_exec_info_content, tui_erase_exec_info_content)
3488         (tui_clear_exec_info_content): Update.
3489         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3490         Update.
3491         * tui/tui-win.c (make_invisible_and_set_new_height)
3492         (make_visible_with_new_height): Update.
3493         * tui/tui-source.c (tui_set_source_content)
3494         (tui_show_symtab_source): Update.
3495         * tui/tui-layout.c (extract_display_start_addr)
3496         (show_source_disasm_command, show_data)
3497         (make_source_or_disasm_window)
3498         (show_source_or_disasm_and_command): Update.
3499         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3500         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3501         "gdbarch".
3502         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3503         to tui_source_window_base.
3504         (struct tui_win_info) <detail>: Remove source_info member.
3505         (struct tui_source_window_base) <has_locator>: Inline.
3506         Move contents from tui_source_info; rename has_locator member to
3507         m_has_locator.
3508         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3509         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3510         header file.
3511         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3512         Simplify.
3513         (tui_free_all_source_wins_content): Cast to
3514         tui_source_window_base.
3515
3516 2019-06-25  Tom Tromey  <tom@tromey.com>
3517
3518         * tui/tui-win.c (make_invisible_and_set_new_height)
3519         (make_visible_with_new_height): Call has_locator method.
3520         * tui/tui-layout.c (show_source_disasm_command, show_data)
3521         (show_source_or_disasm_and_command): Update for bool change.
3522         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3523         (tui_win_info) <has_locator>: New method.
3524         (struct tui_source_window_base) <has_locator>: New method.
3525         (tui_win_has_locator): Don't declare.
3526         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3527         from tui_win_has_locator.
3528         (tui_source_window_base): Use false, not FALSE.
3529
3530 2019-06-25  Tom Tromey  <tom@tromey.com>
3531
3532         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3533         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3534         clear_detail method directly.
3535         (tui_clear_win_detail): Remove.
3536
3537 2019-06-25  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3540         "this", not TUI_DISASM_WIN.
3541
3542 2019-06-25  Tom Tromey  <tom@tromey.com>
3543
3544         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3545         declare.
3546         * tui/tui-winsource.c
3547         (tui_source_window_base::do_scroll_horizontal): Rename from
3548         tui_horizontal_source_scroll.
3549         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3550         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3551         from tui_vertical_data_scroll.
3552         * tui/tui-win.h (tui_scroll): Don't declare.
3553         * tui/tui-win.c (tui_win_info::forward_scroll)
3554         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3555         (tui_win_info::right_scroll): Rename and update.
3556         (tui_scroll_forward_command, tui_scroll_backward_command)
3557         (tui_scroll_left_command, tui_scroll_right_command): Update.
3558         (tui_scroll): Remove.
3559         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3560         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3561         from tui_vertical_source_scroll.
3562         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3563         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3564         from tui_vertical_disassem_scroll.
3565         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3566         do_scroll_horizontal>: New methods.
3567         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3568         Likewise.
3569         (struct tui_source_window_base): Add do_scroll_horizontal.
3570         (struct tui_source_window, struct tui_disasm_window): Add
3571         do_scroll_vertical.
3572         (struct tui_data_window, struct tui_cmd_window): Add
3573         do_scroll_horizontal and do_scroll_vertical.
3574         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3575
3576 2019-06-25  Tom Tromey  <tom@tromey.com>
3577
3578         * tui/tui-data.h (struct tui_source_window_base): New struct.
3579         (struct tui_source_window): Derive from tui_source_window_base.
3580         (struct tui_disasm_window): New struct.
3581         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3582         from tui_source_window::clear_detail.
3583         (tui_source_window_base): Rename from tui_source_window.
3584         (~tui_source_window_base): Rename from ~tui_source_window.
3585         (tui_alloc_win_info): Create a tui_disasm_window.
3586
3587 2019-06-25  Tom Tromey  <tom@tromey.com>
3588
3589         * tui/tui-data.h (struct tui_source_window)
3590         (struct tui_data_window): Declare destructors.
3591         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3592         destructors.
3593         (tui_win_info): Simplify.
3594
3595 2019-06-25  Tom Tromey  <tom@tromey.com>
3596
3597         * tui/tui-winsource.c (tui_display_main)
3598         (tui_update_source_windows_with_addr)
3599         (tui_update_all_breakpoint_info): Update.
3600         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3601         (new_height_ok, parse_scrolling_args): Update.
3602         * tui/tui-stack.c (tui_show_frame_info): Update.
3603         * tui/tui-data.h (struct tui_list): Remove.
3604         (tui_source_windows): Return a reference to a std::vector.
3605         * tui/tui-data.c (source_windows): Now a std::vector.
3606         (tui_source_windows): Change return type.
3607         (tui_clear_source_windows): Rewrite.
3608         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3609         (tui_free_all_source_wins_content): Rewrite.
3610
3611 2019-06-25  Tom Tromey  <tom@tromey.com>
3612
3613         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3614         (struct tui_data_window, struct tui_cmd_window): Declare
3615         clear_detail method.
3616         * tui/tui-data.c (tui_source_window::clear_detail)
3617         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3618         methods.
3619         (tui_clear_win_detail): Simplify.
3620
3621 2019-06-25  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-layout.c (make_source_window, make_disasm_window)
3624         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3625         Return the new window.
3626         (show_source_disasm_command, show_data)
3627         (show_source_or_disasm_and_command): Update.
3628
3629 2019-06-25  Tom Tromey  <tom@tromey.com>
3630
3631         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3632         parameter.  Return the new window.
3633         (show_source_disasm_command): Update and remove NULL check.
3634         (show_source_or_disasm_and_command): Update.
3635
3636 2019-06-25  Tom Tromey  <tom@tromey.com>
3637
3638         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3639
3640 2019-06-25  Tom Tromey  <tom@tromey.com>
3641
3642         * tui/tui-data.h (struct tui_win_info): Make constructor
3643         protected.  Make destructor virtual.  Add initializers.
3644         (tui_source_window, tui_data_window, tui_cmd_window): New
3645         classes.
3646         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3647         constructor.  Add "type" parameter.
3648         (tui_source_window, tui_data_window, tui_cmd_window): New
3649         constructors.
3650         (tui_alloc_win_info): Instantiate the appropriate subclass.
3651
3652 2019-06-25  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-win.c (tui_resize_all): Use delete.
3655         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3656         destructor.
3657         (tui_free_window): Don't declare.
3658         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3659         Update.
3660
3661 2019-06-25  Tom Tromey  <tom@tromey.com>
3662
3663         * tui/tui-data.h (struct tui_win_info): Add constructor.
3664         * tui/tui-data.c (tui_alloc_win_info): Use new.
3665         (tui_free_window): Use delete.
3666
3667 2019-06-22  Tom Tromey  <tom@tromey.com>
3668
3669         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3670         declare.
3671         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3672
3673 2019-06-22  Tom Tromey  <tom@tromey.com>
3674
3675         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3676         declare.
3677         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3678
3679 2019-06-22  Tom de Vries  <tdevries@suse.de>
3680
3681         * dwarf2read.c (create_addrmap_from_aranges)
3682         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3683         instead of '%zu'.
3684
3685 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3686
3687         * dwarf2read.h (dwarf2_section_info_def): Remove.
3688         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3689         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3690         std::vector<dwarf2_section_info>.
3691         (struct dwo_file) <~dwo_file>: Remove.
3692         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3693         types field.
3694         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3695         (dwarf2_read_debug_names): Likewise.
3696         (create_debug_types_hash_table): Change parameter type to
3697         array_view, adjust code accordingly.
3698         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3699         (partial_die_info::fixup): Likewise.
3700         (determine_prefix): Likewise.
3701         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3702
3703 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3704
3705         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3706         gdb_bfd_ref_ptr.
3707         <~dwo_file>: Remove call to gdb_bfd_unref.
3708         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3709         gdb_bfd_ref_ptr::get.
3710
3711 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3712
3713         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3714         type to htab_up.
3715         * dwarf2read.c (struct dwo_file): Initialize fields.
3716         <~dwo_file>: New.
3717         (free_dwo_file): Remove, move content to ~dwo_file.
3718         (struct dwo_file_deleter): Remove.
3719         (dwo_file_up>: Remove custom deleter.
3720         (free_dwo_files): Remove.
3721         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3722         dwo_files.
3723         (process_skeletonless_type_units): Call unique_ptr::get.
3724         (allocate_dwo_file_hash_table): Add deleter to created hash
3725         table.  Change return type to htab_up.
3726         (lookup_dwo_file_slot): Don't memset dwo_file, call
3727         unique_ptr::get.
3728         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3729         (create_dwo_unit_in_dwp_v2): Likewise.
3730         (open_and_init_dwo_file): Likewise.
3731         (free_dwo_file_from_slot): Remove.
3732
3733 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3734
3735         * dwarf2read.h (struct dwarf2_section_info) <readin,
3736         is_virtual>: Change type to bool.
3737         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3738         true instead of 1.
3739
3740 2019-06-19  Tom Tromey  <tom@tromey.com>
3741
3742         * tui/tui-data.h (tui_init_content_element): Don't declare.
3743
3744 2019-06-19  Tom Tromey  <tom@tromey.com>
3745
3746         * tui/tui-data.h (tui_init_win_info): Don't declare.
3747
3748 2019-06-19  Tom de Vries  <tdevries@suse.de>
3749
3750         * dwarf2read.h (abstract_to_concrete): Change type to
3751         std::unordered_map<sect_offset, std::vector<sect_offset>,
3752         gdb::hash_enum<sect_offset>>.
3753
3754 2019-06-19  Tom Tromey  <tromey@adacore.com>
3755
3756         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3757         EVAL_AVOID_SIDE_EFFECTS specially.
3758
3759 2019-06-19  Tom Tromey  <tromey@adacore.com>
3760
3761         * source-cache.c (highlighter): New global.
3762         (source_cache::get_source_lines): Create a highlighter on demand.
3763
3764 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * defs.h (deprecated_interactive_hook): Delete declaration.
3767         * interps.c (clear_interpreter_hooks): Remove use of
3768         deprecated_interactive_hook.
3769         * top.c (deprecated_interactive_hook): Delete definition.
3770         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3771
3772 2019-06-18  Tom de Vries  <tdevries@suse.de>
3773
3774         PR gdb/24515
3775         * dwarf2read.h (abstract_to_concrete): Change type from
3776         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3777         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3778         * dwarf2read.c (read_variable): Update.
3779         (dwarf2_fetch_die_loc_sect_off): Update.
3780
3781 2019-06-17  Tom de Vries  <tdevries@suse.de>
3782
3783         PR gdb/24617
3784         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3785         accessing parent[parent_len - 1].
3786
3787 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3788
3789         PR gdb/24364
3790         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3791         call dtrace_process_dof with NULL dof.
3792
3793 2019-06-16  Tom de Vries  <tdevries@suse.de>
3794
3795         PR gdb/24445
3796         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3797
3798 2019-06-16  Tom Tromey  <tom@tromey.com>
3799
3800         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3801         (make_all_visible): Use address of member.
3802
3803 2019-06-16  Tom Tromey  <tom@tromey.com>
3804
3805         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3806         (tui_free_window, free_content, free_content_elements): Remove
3807         unnecessary cast.
3808         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3809         cast.
3810         * tui/tui-regs.c (tui_show_register_group)
3811         (tui_display_registers_from, tui_display_reg_element_at_line):
3812         Remove unnecessary cast.
3813
3814 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3815
3816         * linux-nat.c (normal_mask): Delete.
3817         (_initialize_linux_nat): Don't initialise normal_mask.
3818
3819 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3820
3821         PR gdb/24445
3822         * dwarf-index-write.h (write_psymtabs_to_index): Add
3823         dwz_basename parameter.
3824         * dwarf-index-write.c (write_gdbindex): Move file writing to
3825         write_gdbindex_1.  Change return type void.
3826         (assert_file_size): Move up, remove filename parameter.
3827         (write_gdbindex_1): New function.
3828         (write_debug_names): Change return type to void, call
3829         assert_file_size.
3830         (struct index_wip_file): New struct.
3831         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3832         file logic to index_wip_file.  Write index for dwz file if
3833         needed.
3834         (save_gdb_index_command): Pass basename of dwz file, if present.
3835         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3836         build-id of dwz file, if present.
3837         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3838         (dwarf2_get_dwz_file): Likewise.
3839         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3840         (dwarf2_get_dwz_file): Likewise.
3841
3842 2019-06-16  Tom Tromey  <tom@tromey.com>
3843
3844         * coffread.c (process_coff_symbol): Use xstrdup.
3845         * value.c (create_internalvar): Use xstrdup.
3846
3847 2019-06-16  Tom Tromey  <tom@tromey.com>
3848
3849         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3850         * breakpoint.c (stopin_command, stopat_command)
3851         (until_break_command, decode_location_default): Remove unnecessary
3852         cast.
3853         * utils.c (subset_compare): Remove unnecessary cast.
3854         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3855         cast.
3856         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3857         cast.
3858         * infcmd.c (path_command): Remove unnecessary cast.
3859         * coffread.c (decode_type): Remove unnecessary cast.
3860         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3861         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3862         * tui/tui-stack.c (tui_show_locator_content)
3863         (tui_show_frame_info): Remove unnecessary cast.
3864         * tui/tui-win.c (tui_scroll_forward_command)
3865         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3866         (parse_scrolling_args): Remove unnecessary cast.
3867         * tui/tui-data.c (init_win_info, tui_del_window)
3868         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3869         (free_content_elements): Remove unnecessary cast.
3870         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3871         unnecessary cast.
3872         * tui/tui-source.c (tui_set_source_content)
3873         (tui_vertical_source_scroll): Remove unnecessary cast.
3874         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3875         cast.
3876         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3877         * tui/tui-regs.c (tui_display_registers_from)
3878         (tui_display_register): Remove unnecessary cast.
3879         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3880         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3881         (make_visible): Remove unnecessary cast.
3882         * tui/tui-winsource.c (tui_erase_source_content)
3883         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3884         unnecessary cast.
3885         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3886         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3887         * stabsread.c (read_type, read_array_type, read_range_type):
3888         Remove unnecessary cast.
3889         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3890         (parse_symbol, parse_type, upgrade_type, parse_external)
3891         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3892         unnecessary cast.
3893         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3894
3895 2019-06-16  Tom Tromey  <tom@tromey.com>
3896
3897         * tui/tui-data.c (tui_alloc_generic_win_info)
3898         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3899         checks.
3900
3901 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3902             Andrew Burgess  <andrew.burgess@embecosm.com>
3903
3904         * f-typeprint.c (f_print_type): Don't return early for not
3905         associated or not allocated types.
3906         (f_type_print_varspec_suffix): Add print_rank parameter and print
3907         ranks of array types in case they dangling.
3908         (f_type_print_base): Add print_rank parameter.
3909
3910 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3911
3912         * NEWS: Mention new MI commands.
3913         * break-catch-throw.c (enum exception_event_kind): Move to
3914         breakpoint.h.
3915         (print_mention_exception_catchpoint): Output text as a single
3916         message.
3917         (catch_exception_command_1): Rename to...
3918         (catch_exception_event): ...this, make non-static, update header
3919         command, and change some parameter types.
3920         (catch_catch_command): Update for changes to
3921         catch_exception_command_1.
3922         (catch_throw_command): Likewise.
3923         (catch_rethrow_command): Likewise.
3924         * breakpoint.c (enum exception_event_kind): Delete.
3925         * breakpoint.h (enum exception_event_kind): Moved here from
3926         break-catch-throw.c.
3927         (catch_exception_event): Declare.
3928         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3929         (mi_cmd_catch_throw): New function.
3930         (mi_cmd_catch_rethrow): New function.
3931         (mi_cmd_catch_catch): New function.
3932         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3933         'catch-catch' entries.
3934         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3935         (mi_cmd_catch_rethrow): Declare.
3936         (mi_cmd_catch_catch): Declare.
3937
3938 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * annotate.c (annotate_source_line): Change return type to void,
3941         update implementation to match.
3942         * annotate.h (annotate_source_line): Change return type to void,
3943         update header comment.
3944         * stack.c (print_frame_info): Don't change what frame information
3945         is printed based on whether annotations are on or not.
3946
3947 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3948
3949         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3950         (annotate_source): Make static.
3951         (annotate_source_line): Moved from source.c and renamed from
3952         identify_source_line.  Update the return type.
3953         * annotate.h (annotate_source): Delete declaration.
3954         (annotate_source_line): Declaration moved from source.h, and
3955         renamed from identify_source_line.  Return type updated.
3956         * source.c (identify_source_line): Moved to annotate.c and renamed
3957         to annotate_source_line.
3958         (info_line_command): Remove check of annotation_level.
3959         * source.h (identify_source_line): Move declaration to annotate.h
3960         and rename to annotate_source_line.
3961         * stack.c: Add 'annotate.h' include.
3962         (print_frame_info): Remove check of annotation_level before
3963         calling annotate_source_line.
3964
3965 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3966
3967         * source-cache.c (source_cache::get_plain_source_lines): Use
3968         open_source_file_with_line_charpos instead of just
3969         open_source_file, remove call to find_source_lines.
3970         (source_cache::get_source_lines): Likewise.
3971         * source.c (find_source_lines): Make static.
3972         (get_filename_and_charpos): Renamed into...
3973         (open_source_file_with_line_charpos): ..this along with changes to
3974         return a scoped_fd, and some other minor clean ups.
3975         (identify_source_line): Use open_source_file_with_line_charpos.
3976         (search_command_helper): Use open_source_file_with_line_charpos
3977         instead of just open_source_file, remove call to
3978         find_source_lines.
3979         * source.h (open_source_file_with_line_charpos): Declare new
3980         function.
3981         (find_source_lines): Delete declaration.
3982
3983 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3984
3985         * source.c (get_filename_and_charpos): Remove fullname
3986         parameter.
3987         (identify_source_line): Update call to get_filename_and_charpos.
3988
3989 2019-06-14  Tom Tromey  <tromey@adacore.com>
3990
3991         PR gdb/24502:
3992         * ui-style.h (skip_ansi_escape): Update comment.
3993         * ui-file.h (class no_terminal_escape_file): New class.
3994         * ui-file.c (no_terminal_escape_file::write)
3995         (no_terminal_escape_file::puts): New methods.
3996         * cli/cli-logging.c (handle_redirections): Use
3997         no_terminal_escape_file.
3998
3999 2019-06-14  Tom Tromey  <tromey@adacore.com>
4000
4001         * NEWS: Move convenience variable news above Python news.
4002
4003 2019-06-14  Tom Tromey  <tom@tromey.com>
4004
4005         * gnulib: Move directory to top-level.
4006         * configure.ac: Don't configure gnulib.
4007         * configure: Rebuild.
4008         * common/common-defs.h: Use new path to gnulib.
4009         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4010         (GNULIB_H): Remove.
4011         (INCGNU): Look in new gnulib location.
4012         (HFILES_NO_SRCDIR): Remove gnulib files.
4013         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4014         (generated_files): Remove GNULIB_H.
4015         ($(LIBGNU), all-lib): Remove targets.
4016         (distclean): Don't mention GNULIB_BUILDDIR.
4017         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4018
4019 2019-06-14  Tom Tromey  <tromey@adacore.com>
4020
4021         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4022         Warn if symbol file does not provide any symbols.
4023
4024 2019-06-14  Tom Tromey  <tromey@adacore.com>
4025
4026         * source.c (find_and_open_source): Respect basenames_may_differ.
4027
4028 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4029
4030         * annotate.c (annotate_breakpoints_invalid): Make use of
4031         scoped_restore_terminal_state.
4032         (annotate_frames_invalid): Likewise.
4033
4034 2019-06-14  Tom Tromey  <tromey@adacore.com>
4035
4036         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4037         allow assignment to an internalvar.
4038
4039 2019-06-14  Tom Tromey  <tromey@adacore.com>
4040
4041         * ada-lex.l: Allow "_" in attribute names.
4042
4043 2019-06-14  Tom Tromey  <tromey@adacore.com>
4044
4045         PR gdb/24653:
4046         * regcache.c (registers_changed): Don't call alloca.
4047         * top.c (execute_command): Don't call alloca.
4048
4049 2019-06-13  Pedro Alves  <palves@redhat.com>
4050
4051         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4052         'expression'.  When parsing an expression, error out if there's
4053         junk after "unlimited".
4054         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4055         (do_set_command): Adjust calls to is_unlimited_literal.
4056
4057 2019-06-13  Pedro Alves  <palves@redhat.com>
4058
4059         * compile/compile.c (make_compile_options_def_group): Add braces
4060         around array_view initializer.
4061         * thread.c (make_thread_apply_all_options_def_group)
4062         (make_thread_apply_all_options_def_group): Likewise.
4063
4064 2019-06-13  Pedro Alves  <palves@redhat.com>
4065
4066         * NEWS (New commands): Mention "maint test-options
4067         require-delimiter", "maint test-options unknown-is-error", "maint
4068         test-options unknown-is-operand" and "maint show
4069         test-options-completion-result".
4070         (New command options, command completion): New section.
4071         (Completion improvements): New section.
4072         Mention that you can abbreviate "unlimited".
4073
4074 2019-06-13  Pedro Alves  <palves@redhat.com>
4075
4076         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4077         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4078         * unittests/cli-utils-selftests.c (test_parse_flags)
4079         (test_parse_flags_qcs): Delete.
4080         (test_cli_utils): Don't call deleted functions.
4081
4082 2019-06-13  Pedro Alves  <palves@redhat.com>
4083
4084         * thread.c: Include "cli/cli-option.h".
4085         (tp_array_compar_ascending): Global.
4086         (tp_array_compar): Delete function.
4087         (tp_array_compar_ascending, tp_array_compar_descending): New
4088         functions.
4089         (ascending_option_def, qcs_flag_option_def)
4090         (thr_qcs_flags_option_defs)
4091         (make_thread_apply_all_options_def_group)
4092         (make_thread_apply_options_def_group): New.
4093         (thread_apply_all_command): Use gdb::option::process_options.
4094         (thread_apply_command_completer)
4095         (thread_apply_all_command_completer): New.
4096         (thread_apply_command): Use gdb::option::process_options.
4097         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4098         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4099         to generate help text of "thread apply".  Adjust "taas"'s help.
4100         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4101         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4102
4103 2019-06-13  Pedro Alves  <palves@redhat.com>
4104
4105         * thread.c (thread_apply_command): Check for invalid TID with
4106         isdigit instead of !isalpha.
4107
4108 2019-06-13  Pedro Alves  <palves@redhat.com>
4109
4110         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4111         (validate_flags_qcs): New.
4112         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4113         (validate_flags_qcs): Declare.
4114         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4115         (make_frame_apply_options_def_group): New.
4116         (frame_apply_command_count): Process options with
4117         gdb::option::process_options.
4118         (frame_apply_completer): New.
4119         (frame_apply_level_completer, frame_apply_all_completer)
4120         (frame_apply_completer): New.
4121         (_initialize_stack): Update help of "frame apply", "frame apply
4122         level", "frame apply all" and "faas" to mention supported options
4123         and install command completers.
4124         * stack.h (frame_apply_all_completer): Declare.
4125         * thread.c: Include "stack.h".
4126         (tfaas_command): Add "--".
4127         (_initialize_thread): Update help "tfaas" to mention supported
4128         options and install command completer.
4129
4130 2019-06-13  Pedro Alves  <palves@redhat.com>
4131
4132         * completer.c (complete_nested_command_line): New.
4133         (gdb_completion_word_break_characters_throw): Add assertion.
4134         * completer.h (complete_nested_command_line): Declare.
4135
4136 2019-06-13  Pedro Alves  <palves@redhat.com>
4137
4138         * stack.c (parse_backtrace_qualifiers): New.
4139         (backtrace_command): Use it.
4140         (backtrace_command_completer): Complete on qualifiers.
4141
4142 2019-06-13  Pedro Alves  <palves@redhat.com>
4143
4144         * frame.c: Include "cli/cli-option.h.
4145         (user_set_backtrace_options): New.
4146         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4147         Delete.
4148         (get_prev_frame): Adjust.
4149         (boolean_option_def, uinteger_option_def)
4150         (set_backtrace_option_defs): New.
4151         (_initialize_frame): Adjust and use
4152         gdb::option::add_setshow_cmds_for_options to install "set
4153         backtrace past-main" and "set backtrace past-entry".
4154         * frame.h: Include "cli/cli-option.h".
4155         (struct frame_print_options): Forward declare.
4156         (print_frame_arguments_all, print_frame_arguments_scalars)
4157         (print_frame_arguments_none): Declare.
4158         (print_entry_values): Delete declaration.
4159         (struct frame_print_options, user_frame_print_options): New.
4160         (struct set_backtrace_options): New.
4161         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4162         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4163         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4164         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4165         (list_args_or_locals): Add frame_print_options parameter.
4166         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4167         * python/py-framefilter.c (enumerate_args): Pass down
4168         USER_FRAME_PRINT_OPTIONS.
4169         * stack.c: Include "cli/cli-option.h".
4170         (print_frame_arguments_all, print_frame_arguments_scalars)
4171         (print_frame_arguments_none): Declare.
4172         (print_raw_frame_arguments, print_entry_values): Delete.
4173         (user_frame_print_options): New.
4174         (boolean_option_def, enum_option_def, frame_print_option_defs):
4175         New.
4176         (struct backtrace_cmd_options): New.
4177         (bt_flag_option_def): New.
4178         (backtrace_command_option_defs): New.
4179         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4180         (print_frame_arg, read_frame_arg, print_frame_args)
4181         (print_frame_info, print_frame): Add frame_print_options parameter
4182         and use it.
4183         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4184         (backtrace_command_1): Add frame_print_options and
4185         backtrace_cmd_options parameters and use them.
4186         (make_backtrace_options_def_group): New.
4187         (backtrace_command): Process command options with
4188         gdb::option::process_options.
4189         (backtrace_command_completer): New.
4190         (_initialize_stack): Extend "backtrace"'s help to mention
4191         supported options.  Install completer for "backtrace".
4192         Install some settings commands with add_setshow_cmds_for_options.
4193
4194 2019-06-13  Pedro Alves  <palves@redhat.com>
4195
4196         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4197         and that "set/show print raw frame-arguments" are now deprecated.
4198
4199         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4200         command.
4201         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4202         * stack.c (_initialize_stack): Install "set/show print
4203         raw-frame-arguments", and deprecate "set/show print raw
4204         frame-arguments".
4205         * valprint.c (_initialize_valprint): Deprecate "set/show print
4206         raw".
4207
4208 2019-06-13  Pedro Alves  <palves@redhat.com>
4209
4210         * compile/compile.c (struct compile_options): New.
4211         (compile_flag_option_def, compile_command_option_defs)
4212         (make_compile_options_def_group): New.
4213         (compile_file_command): Handle options with
4214         gdb::option::process_options.
4215         (compile_file_command_completer): New function.
4216         (compile_code_command): Handle options with
4217         gdb::option::process_options.
4218         (compile_code_command_completer): New function.
4219         (_initialize_compiler): Install completers for "compile code" and
4220         "compile file".  Mention available options in "compile code" and
4221         "compile code"'s help.
4222         * completer.c (advance_to_completion_word): New, factored out from
4223         ...
4224         (advance_to_expression_complete_word_point): ... this.
4225         (advance_to_filename_complete_word_point): New.
4226         * completer.h (advance_to_filename_complete_word_point): New
4227         declaration.
4228
4229 2019-06-13  Pedro Alves  <palves@redhat.com>
4230
4231         * compile/compile.c: Include "cli/cli-option.h".
4232         (compile_print_value): Scope data pointer is now a
4233         value_print_options pointer; adjust.
4234         (compile_print_command): Process options.  Scope data pointer is
4235         now a value_print_options pointer; adjust.
4236         (_initialize_compile): Update "compile print"'s help to include
4237         supported options.  Install a completer for "compile print".
4238         * cp-valprint.c (show_vtblprint, show_objectprint)
4239         (show_static_field_print): Delete.
4240         (_initialize_cp_valprint): Don't install "set print
4241         static-members", "set print vtbl", "set print object" here.
4242         * printcmd.c: Include "cli/cli-option.h" and
4243         "common/gdb_optional.h".
4244         (print_command_parse_format): Rework to fill in a
4245         value_print_options instead of a format_data.
4246         (print_value): Change parameter type from format_data pointer to
4247         value_print_options reference.  Adjust.
4248         (print_command_1): Process options.  Adjust to pass down a
4249         value_print_options.
4250         (print_command_completer): New.
4251         (_initialize_printcmd): Install print_command_completer as
4252         handle_brkchars completer for the "print" command.  Update
4253         "print"'s help to include supported options.
4254         * valprint.c: Include "cli/cli-option.h".
4255         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4256         here from cp-valprint.c.
4257         (boolean_option_def, uinteger_option_def)
4258         (value_print_option_defs, make_value_print_options_def_group):
4259         New.  Use gdb::option::add_setshow_cmds_for_options to install
4260         "set print elements", "set print null-stop", "set print repeats",
4261         "set print pretty", "set print union", "set print array", "set
4262         print address", "set print symbol", "set print array-indexes".
4263         * valprint.h: Include <string> and "cli/cli-option.h".
4264         (make_value_print_options_def_group): Declare.
4265         (print_value): Change parameter type from format_data pointer to
4266         value_print_options reference.
4267         (print_command_completer): Declare.
4268
4269 2019-06-13  Pedro Alves  <palves@redhat.com>
4270
4271         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4272         (COMMON_SFILES): Add maint-test-settings.c.
4273         * cli/cli-decode.c (boolean_enums): New global, factored out from
4274         ...
4275         (add_setshow_boolean_cmd): ... here.
4276         * cli/cli-decode.h (boolean_enums): Declare.
4277         * cli/cli-option.c: New file.
4278         * cli/cli-option.h: New file.
4279         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4280         factored out from ...
4281         (parse_cli_boolean_value(const char *)): ... this.
4282         (is_unlimited_literal): Change parameter type to pointer to
4283         pointer.  Adjust and advance ARG pointer.
4284         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4285         (parse_cli_var_enum): New, factored out from ...
4286         (do_set_command): ... this.  Adjust.
4287         * cli/cli-setshow.h (parse_cli_boolean_value)
4288         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4289         (parse_cli_var_enum): Declare.
4290         * cli/cli-utils.c: Include "cli/cli-option.h".
4291         (get_ulongest): New.
4292         * cli/cli-utils.h (get_ulongest): Declare.
4293         (check_for_argument): New overloads.
4294         * maint-test-options.c: New file.
4295
4296 2019-06-13  Pedro Alves  <palves@redhat.com>
4297
4298         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4299         parse a range if "-" is at the end of the string.
4300
4301 2019-06-13  Pedro Alves  <palves@redhat.com>
4302
4303         * cli/cli-setshow.c (parse_auto_binary_operation)
4304         (parse_cli_boolean_value): Don't allow "o".
4305
4306 2019-06-13  Pedro Alves  <palves@redhat.com>
4307
4308         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4309         * NEWS: Mention maint test-settings KIND.
4310         * maint-test-settings.c: New file.
4311
4312 2019-06-13  Pedro Alves  <palves@redhat.com>
4313
4314         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4315         completer.
4316         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4317         "set" completers.
4318
4319 2019-06-13  Pedro Alves  <palves@redhat.com>
4320
4321         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4322         after item.
4323
4324 2019-06-13  Pedro Alves  <palves@redhat.com>
4325
4326         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4327
4328 2019-06-13  Pedro Alves <palves@redhat.com>
4329
4330         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4331         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4332         call.
4333         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4334         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4335         calls.
4336         (check_for_argument): Skip spaces after argument.
4337
4338 2019-06-13  Pedro Alves  <palves@redhat.com>
4339
4340         * thread.c (thread_apply_command): Adjust TID parsing.
4341         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4342         detected before end of string.
4343         (tid_is_in_list): Error out if LIST is invalid.
4344
4345 2019-06-13  Pedro Alves  <palves@redhat.com>
4346
4347         * completer.c (complete_line_internal_1): Rewind completion word
4348         point.
4349         (completion_tracker::advance_custom_word_point_by): Change
4350         parameter type to int.
4351         * completer.h (completion_tracker::advance_custom_word_point_by):
4352         Likewise.
4353
4354 2019-06-13  Pedro Alves  <palves@redhat.com>
4355
4356         * completer.c (advance_to_completion_word): Handle delimiters.
4357
4358 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4359
4360         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4361
4362 2019-06-11  Tom Tromey  <tom@tromey.com>
4363
4364         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4365         (xmalloc_failed): Move to alloc.c.
4366         * alloc.c: New file.
4367         * Makefile.in (COMMON_SFILES): Add alloc.c.
4368
4369 2019-06-11  Tom Tromey  <tom@tromey.com>
4370
4371         * nat/linux-waitpid.c: Don't include server.h.
4372         (linux_debug): Remove.
4373         (my_waitpid): Update.
4374
4375 2019-06-11  Tom Tromey  <tromey@adacore.com>
4376
4377         * infcall.c (_initialize_infcall): Remove trailing newline from
4378         help.
4379         * user-regs.c (_initialize_user_regs): Remove trailing newline
4380         from help.
4381         * typeprint.c (_initialize_typeprint): Remove trailing newline
4382         from help.
4383         * reverse.c (_initialize_reverse): Remove trailing newlines from
4384         help.
4385         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4386         from help.
4387         * language.c (add_set_language_command): Remove trailing newline
4388         from help.
4389         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4390         help.
4391         * disasm.c (_initialize_disasm): Remove trailing newline from
4392         help.
4393         * top.c (init_main): Remove trailing newline from help.
4394         * interps.c (_initialize_interpreter): Remove trailing newline
4395         from help.
4396         * btrace.c (_initialize_btrace): Remove trailing newlines from
4397         help.
4398         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4399         from help.
4400         * python/python.c (_initialize_python): Remove trailing newline
4401         from help.
4402         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4403         help.
4404         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4405         from help.  Reformat some text.
4406         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4407         from help.
4408         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4409         newline from help.
4410
4411 2019-06-11  Tom Tromey  <tromey@adacore.com>
4412
4413         * darwin-nat.c (darwin_decode_exception_message)
4414         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4415
4416 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4417
4418         * valops.c (value_slice): Check for not allocated or not
4419         associated values.
4420
4421 2019-06-10  Tom de Vries  <tdevries@suse.de>
4422
4423         PR gdb/24618
4424         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4425         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4426         invalid.
4427
4428 2019-06-10  Tom de Vries  <tdevries@suse.de>
4429
4430         PR gdb/24611
4431         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4432         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4433
4434 2019-06-10  Tom de Vries  <tdevries@suse.de>
4435
4436         PR symtab/24545
4437         * symtab.c (struct demangled_name_entry): Add language field.
4438         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4439         static minimal symbol".  Set and use language field.
4440
4441 2019-06-10  Tom Tromey  <tromey@adacore.com>
4442
4443         * ada-lang.c (_initialize_ada_language): Update help text.
4444
4445 2019-06-10  Tom Tromey  <tromey@adacore.com>
4446
4447         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4448         with a newline.
4449         * guile/guile.c (handle_boot_error): Don't end warning with a
4450         newline.
4451         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4452         warning with a newline.
4453         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4454         newline.
4455         (s12z_frame_cache): Likewise.
4456         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4457         a newline.
4458         * solib-svr4.c (disable_probes_interface): Don't end warning with
4459         a newline.
4460         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4461         newline.
4462         * python/python.c (do_finish_initialization): Don't end warning
4463         with a newline.
4464
4465 2019-06-10  Tom Tromey  <tom@tromey.com>
4466
4467         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4468         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4469         gdbpy_enter.
4470
4471 2019-06-10  Tom Tromey  <tromey@adacore.com>
4472
4473         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4474         data.
4475         (elf_new_init): Don't call stabsread_new_init.
4476         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4477         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4478         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4479
4480 2019-06-10  Tom de Vries  <tdevries@suse.de>
4481
4482         PR symtab/16264
4483         PR symtab/24517
4484         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4485
4486 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4487
4488         * source.c (find_and_open_source): Also rewrite relative file
4489         names.
4490
4491 2019-04-26  Amos Bird  <amosbird@gmail.com>
4492
4493         * annotate.c (annotate_thread_exited): Add "thread-exited"
4494         annotation.
4495
4496 2019-06-06  Tom Tromey  <tromey@adacore.com>
4497
4498         * maint.h (class scoped_command_stats): Use
4499         DISABLE_COPY_AND_ASSIGN.
4500         <print_time>: New method.
4501         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4502         print_time.
4503         (scoped_command_stats::print_time): New method.
4504
4505 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4506
4507         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4508         instructions of lengths 6 or 8 bytes.
4509
4510 2019-06-04  Pedro Alves  <palves@redhat.com>
4511
4512         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4513
4514         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4515         * breakpoint.c (condition_completer): Likewise.
4516         * cli/cli-dump.c (scan_expression): Likewise.
4517         * common/filestuff.c (mkdir_recursive): Likewise.
4518         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4519         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4520         (gdb_abspath): Likewise.
4521         * compile/compile-cplus-types.c
4522         (compile_cplus_instance::decl_name): Likewise.
4523         * completer.c (complete_explicit_location):
4524         (signal_completer, reg_or_group_completer_1): Likewise.
4525         * cp-support.c (cp_remove_params_if_any): Likewise.
4526         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4527         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4528         * infcmd.c (strip_bg_char): Likewise.
4529         * linespec.c (copy_token_string): Likewise.
4530         * mi/mi-main.c (output_cores): Likewise.
4531         * psymtab.c (psymtab_search_name):
4532         * symfile.c (test_set_ext_lang_command): Likewise.
4533         * target.c (target_fileio_read_stralloc): Likewise.
4534         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4535         * value.c (complete_internalvar): Likewise.
4536
4537 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4538
4539         Add objfile property to gdb.Type.
4540         * NEWS: Mention Python API addition.
4541         * python/py-type.c (typy_get_objfile): New method.
4542
4543 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4544
4545         * NEWS: Mention the new set|show style [title|highlight].
4546         Mention changes to "show style", "help" and "apropos".
4547
4548 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4549
4550         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4551         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4552         instead of print_help_for_command.
4553         (print_doc_of_command): New function.
4554         (help_list): Add 'apropos -v word' suggestion.
4555         (print_help_for_command): Style the command name using title style.
4556         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4557         (_initialize_cli_cmds): Describe -v in apropos_command help.
4558
4559 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4560
4561         * cli/cli-style.h (cli_style_option): Add name in constructor,
4562         add m_name class member, add constructor with intensity,
4563         add name class function.
4564         (cli_style_option::add_setshow_commands): Remove name argument.
4565         (highlight_style, title_style): New styles.
4566         * cli/cli-style.c (do_show): New function that shows a style
4567         characteristic styling the style name with itself.
4568         (set_style_name): New function.
4569         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4570         Update all callers according to the changes in cli/cli-style.h.
4571         * utils.h (fputs_highlighted): New function.
4572         * utils.c (fputs_highlighted): Likewise.
4573
4574 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4575
4576         * NEWS: Mention new pipe command and new convenience variables.
4577
4578 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4579
4580         * cli/cli-cmds.c (pipe_command): New function.
4581         (_initialize_cli_cmds): Call add_com for pipe_command.
4582         Define | as an alias for pipe.
4583         (exit_status_set_internal_vars): New function.
4584         (shell_escape): Call exit_status_set_internal_vars.
4585         cli/cli-decode.c (find_command_name_length): Recognize | as
4586         a single character command.
4587
4588 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4589
4590         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4591         top.c (execute_command_to_ui_file): New function, mostly a copy
4592         of execute_command_to_string.
4593         (execute_command_to_string): Implement by calling
4594         execute_command_to_ui_file.
4595
4596 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4597
4598         * top.h (saved_command_line): Remove declaration.
4599         * top.c (previous_saved_command_line, previous_repeat_arguments):
4600         New variables.
4601         (saved_command_line): Make static, define together with other
4602         'repeat variables'.
4603         (dont_repeat): Clear repeat_arguments.
4604         (repeat_previous, get_saved_command_line, save_command_line):
4605         New functions.
4606         (gdb_init): Initialize saved_command_line
4607         and previous_saved_command_line.
4608         * main.c (captured_main_1): Remove saved_command_line initialization.
4609         * event-top.c (handle_line_of_input): Update to use
4610         the new 'repeat' related functions instead of direct access to
4611         saved_command_line.
4612         * command.h (repeat_previous, get_saved_command_line,
4613         save_command_line): New declarations.
4614         (dont_repeat): Add comment.
4615
4616 2019-05-30  Tom Tromey  <tromey@adacore.com>
4617
4618         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4619         Fix comment.
4620         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4621
4622 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4623
4624         PR cli/24587
4625         * completer.c (complete): Initialize variable word.
4626
4627 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4628
4629         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4630         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4631         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4632         'body' is NULL to the outter 'if', protecting the '!is_define'
4633         situation as well.
4634
4635 2019-05-29  Tom Tromey  <tromey@adacore.com>
4636
4637         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4638         (dwarf_unknown): New function.
4639         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4640         (dwarf_type_encoding_name): Use dwarf_unknown.
4641
4642 2019-05-29  Tom Tromey  <tromey@adacore.com>
4643
4644         PR c++/20020:
4645         * cp-valprint.c (cp_print_value_fields): Call
4646         cp_print_static_field inside "try".
4647
4648 2019-05-29  Tom Tromey  <tromey@adacore.com>
4649
4650         * inflow.c (struct terminal_info): Add default operator=.
4651         * configure: Rebuild.
4652         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4653         -Wdeprecated-copy-dtor, -Wredundant-move.
4654
4655 2019-05-29  Tom Tromey  <tromey@adacore.com>
4656
4657         * NEWS: Add entry.
4658         * infcmd.c (print_return_value_1): Handle finish_print
4659         option.
4660         (show_print_finish): New function.
4661         (_initialize_infcmd): Add "set/show print finish" commands.
4662         * valprint.c (user_print_options): Initialize new member.
4663         * valprint.h (struct value_print_options) <finish_print>: New
4664         member.
4665
4666 2019-05-28  Tom Tromey  <tromey@adacore.com>
4667
4668         * ada-lang.c (ada_remove_Xbn_suffix)
4669         (find_old_style_renaming_symbol)
4670         (parse_old_style_renaming): Remove.
4671         (ada_find_renaming_symbol): Don't call
4672         find_old_style_renaming_symbol.
4673         (ada_is_renaming_symbol): Rename from
4674         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4675         bool.  Now static.
4676         (ada_read_var_value): Update and simplify.
4677         * ada-exp.y (write_var_or_type): Remove old code.
4678
4679 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4680
4681         * event-top.c: Remove include comment.
4682         * inflow.c (class scoped_ignore_sigttou): Move from here...
4683         * inflow.h (class scoped_ignore_sigttou): ...to here.
4684         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4685         * top.c:  Remove include comment.
4686
4687 2019-05-27  Tom Tromey  <tom@tromey.com>
4688
4689         * NEWS: Fix typo.
4690
4691 2019-05-22  Tom Tromey  <tromey@adacore.com>
4692
4693         * target.c (target_follow_exec): Constify parameter.
4694         * target-delegates.c: Rebuild.
4695         * remote.c (remote_target::follow_exec): Constify parameter.
4696         * infrun.c (follow_exec): Constify parameter.
4697         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4698         (target_follow_exec): Likewise.
4699
4700 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4701
4702         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4703         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4704
4705 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4706
4707         * NEWS: Add debugredirect and testsuite sections.
4708
4709 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4710
4711         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4712         target descriptions using exclusively floating point register name
4713         aliases.
4714
4715 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4716
4717         PR gdb/18644:
4718         * f-lang.c (build_fortran_types): Handle the case where
4719         gdbarch_floatformat_for_type returns a nullptr.
4720
4721 2019-05-21  Tom de Vries  <tdevries@suse.de>
4722
4723         PR cli/24587
4724         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4725
4726 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4727
4728         PR gdb/18644:
4729         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4730         16-byte floats.
4731         * i386-tdep.c (i386_floatformat_for_type): Use
4732         floatformats_ia64_quad for the 16-byte floating point component
4733         within a fortran 32-byte complex number.
4734
4735 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4736
4737         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4738         delete default constructor.
4739         (find_partial_die): Update to return const struct.
4740         (partial_die_parent_scope): Move variable declaration into scope
4741         of its use and change its type to auto.
4742         (guess_partial_die_structure_name): Likewise.
4743         (partial_die_info::fixup): Likewise.
4744
4745 2019-05-17  Tom Tromey  <tromey@adacore.com>
4746
4747         * source.c (find_and_open_source): Remove cast.
4748
4749 2019-05-17  Tom Tromey  <tromey@adacore.com>
4750
4751         * annotate.c (annotate_source): Make "filename" const.
4752         * annotate.h (annotate_source): Use const.
4753
4754 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4755
4756         * disasm.c (set_disassembler_options): Send errors to stderr.
4757
4758 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4759
4760         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4761         (cli_interp_base::set_logging): Check debug_redirect.
4762         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4763         * cli/cli-logging.c (debug_redirect): Add static variable.
4764         (pop_output_files): Add default param.
4765         (handle_redirections): Print debug setting.
4766         (show_logging_command): Likewise.
4767         (_initialize_cli_logging): Add debugredirect command.
4768         * interps.c (current_interp_set_logging): Add debug_redirect
4769         parameter.
4770         * interps.h (set_logging): Add debug_redirect parameter.
4771         (current_interp_set_logging): Likewise.
4772         * mi/mi-common.h: Likewise.
4773         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4774
4775 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4776             Tom Tromey  <tromey@adacore.com>
4777
4778         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4779         directly.
4780         * cli/cli-interp.h (make_logging_output): Remove declaration.
4781         * cli/cli-logging.c (make_logging_output): Remove function.
4782         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4783         directly.
4784         * ui-file.c (tee_file::tee_file): Remove bools.
4785         (tee_file::~tee_file): Remove deletes.
4786         * ui-file.h (tee_file): Remove bools.
4787
4788 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4789
4790         * mi/mi-cmds.h (mi_cmd_complete): New function.
4791         * mi/mi-main.c (mi_cmd_complete): Likewise.
4792         * mi/mi-cmds.c: Define new MI command -complete.
4793         * NEWS: Mention new -complete command.
4794
4795 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4796
4797         * completer.h (complete): New function.
4798         * completer.c (complete): Likewise.
4799         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4800         function defined in completer.h.
4801
4802 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4803
4804         * MAINTAINERS (Write After Approval): Add myself.
4805
4806 2019-05-17  Tom de Vries  <tdevries@suse.de>
4807
4808         PR gdb/24094
4809         * dwarf2read.c (struct cu_partial_die_info): New struct.
4810         (find_partial_die): Return cu_partial_die_info.
4811         (partial_die_parent_scope, guess_partial_die_structure_name)
4812         (partial_die_info::fixup): Handle new return type of find_partial_die.
4813
4814 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4815
4816         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4817         "std::string", simplifying the algorithm.
4818
4819 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4820
4821         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4822         (stap_static_probe_ops::get_probes): Likewise.
4823
4824 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4825
4826         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4827         '-')" and "else if".
4828         (stap_parse_single_operand): Join checks for
4829         "gdbarch_stap_parse_special_token_p" and
4830         "gdbarch_stap_parse_special_token" in the same "if" statement.
4831         Invert check when verifying for operation on register
4832         displacement.
4833
4834 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4835
4836         * stap-probe.c (stap_get_opcode): Update comment.
4837         (stap_get_expected_argument_type): Likewise.
4838         (handle_stap_probe): Likewise.
4839
4840 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4841
4842         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4843         return type to 'bool'.  Adjust comment.  Use 'bool' when
4844         appropriate.
4845         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4846         * stap-probe.c (stap_parse_argument_1): Likewise.
4847         (stap_is_operator): Likewise.
4848         (stap_is_generic_prefix): Likewise.
4849         (stap_is_register_prefix): Likewise.
4850         (stap_is_register_indirection_prefix): Likewise.
4851         (stap_is_integer_prefix): Likewise.
4852         (stap_generic_check_suffix): Likewise.
4853         (stap_check_integer_suffix): Likewise.
4854         (stap_check_register_suffix): Likewise.
4855         (stap_check_register_indirection_suffix): Likewise.
4856         (stap_parse_register_operand): Likewise.
4857         (stap_parse_single_operand): Likewise.
4858         (stap_parse_argument_1): Likewise.
4859         (stap_probe::get_argument_count): Likewise.
4860         (stap_is_operator): Likewise.
4861
4862 2019-05-16  Tom Tromey  <tromey@adacore.com>
4863
4864         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4865         keyword to foreach.
4866
4867 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4868
4869         * linux-thread-db.c (try_thread_db_load_1): Change return type
4870         to bool.
4871         (try_thread_db_load): Likewise.
4872         (try_thread_db_load_from_pdir_1): Likewise.
4873         (try_thread_db_load_from_pdir): Likewise.
4874         (try_thread_db_load_from_sdir): Likewise.
4875         (try_thread_db_load_from_dir): Likewise.
4876         (thread_db_load_search): Likewise.
4877         (has_libpthread): Likewise.
4878         (thread_db_load): Likewise.
4879
4880 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4881
4882         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4883         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4884         NULL, and complain/return if that's the case.
4885
4886 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4887
4888         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4889         (advance, posn, abstract_read_memory): New functions.
4890         [struct mem_read_abstraction]: New struct.
4891         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4892
4893 2019-05-14  Tom Tromey  <tromey@adacore.com>
4894
4895         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4896         value is not lval_memory.
4897
4898 2019-05-14  Tom Tromey  <tromey@adacore.com>
4899
4900         * solib.c (info_sharedlibrary_command): Style the file name.
4901
4902 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4903
4904         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4905         (aarch64_vnv_type): Likewise.
4906         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4907         * common/tdesc.c: Likewise.
4908         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4909         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4910         * features/aarch64-fpu.xml: Add ieee half view.
4911         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4912         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4913         * gdbtypes.h (struct builtin_type): Likewise.
4914         (struct objfile_type): Likewise.
4915
4916 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4917
4918         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4919         typo.
4920         * location.h (string_to_event_location): Likewise.
4921
4922 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4923
4924         GDB 8.3 released.
4925
4926 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4927
4928         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4929         New variable declaration.
4930         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4931         New variable.
4932         (print_one_breakpoint): Use ui_out::test_flags and new global
4933         variable to compute use_fixed_output.
4934         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4935         Remove.
4936         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4937         (mi_multi_location_breakpoint_output_fixed): Remove.
4938         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4939         new variable.
4940         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4941         fix_multi_location_breakpoint_output flag if version >= 3.
4942         * ui-out.h (enum ui_out_flag)
4943         <fix_multi_location_breakpoint_output>: New enumerator.
4944
4945 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4946
4947         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4948
4949 2019-05-10  Tom Tromey  <tromey@adacore.com>
4950
4951         * ada-lang.c (catch_ada_completer): New function.
4952         (_initialize_ada_language): Use it.
4953
4954 2019-05-10  Tom Tromey  <tromey@adacore.com>
4955
4956         * thread.c (print_thread_info): Make "requested_threads" const.
4957         * gdbthread.h (print_thread_info): Make "requested_threads"
4958         const.
4959         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4960         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4961
4962 2019-05-08  Tom Tromey  <tom@tromey.com>
4963
4964         * gdbtypes.c (objfile_type_data): Change type.
4965         (objfile_type, _initialize_gdbtypes): Update.
4966
4967 2019-05-08  Tom Tromey  <tom@tromey.com>
4968
4969         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4970         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4971         (_initialize_dwarf2_frame): Update.
4972
4973 2019-05-08  Tom Tromey  <tom@tromey.com>
4974
4975         * objc-lang.c (objc_objfile_data): Change type.
4976         (find_methods): Update.
4977         (_initialize_objc_lang): Remove.
4978
4979 2019-05-08  Tom Tromey  <tom@tromey.com>
4980
4981         * stabsread.c (rs6000_builtin_type_data): Change type.
4982         (rs6000_builtin_type, _initialize_stabsread): Update.
4983
4984 2019-05-08  Tom Tromey  <tom@tromey.com>
4985
4986         * mips-tdep.c (mips_pdr_data): Remove.
4987         (_initialize_mips_tdep): Update.
4988
4989 2019-05-08  Tom Tromey  <tom@tromey.com>
4990
4991         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4992         (hppa_init_objfile_priv_data, read_unwind_info)
4993         (find_unwind_entry, _initialize_hppa_tdep): Update.
4994
4995 2019-05-08  Tom Tromey  <tom@tromey.com>
4996
4997         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4998         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4999         on obstack.
5000         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5001
5002 2019-05-08  Tom Tromey  <tom@tromey.com>
5003
5004         * mdebugread.c (basic_type_data): Change type.
5005         (basic_type, _initialize_mdebugread): Update.
5006
5007 2019-05-08  Tom Tromey  <tom@tromey.com>
5008
5009         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5010
5011 2019-05-08  Tom Tromey  <tom@tromey.com>
5012
5013         * nto-tdep.c (nto_inferior_data_reg): Change type.
5014         (nto_inferior_data): Update.
5015         (nto_inferior_data_cleanup, nto_new_inferior_data)
5016         (_initialize_nto_tdep): Remove.
5017         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5018
5019 2019-05-08  Tom Tromey  <tom@tromey.com>
5020
5021         * ada-lang.c (struct ada_inferior_data): Add initializers.
5022         (ada_inferior_data): Change type.
5023         (ada_inferior_data_cleanup): Remove.
5024         (get_ada_inferior_data, ada_inferior_exit)
5025         (struct ada_pspace_data): Add initializers, destructor.
5026         (ada_pspace_data_handle): Change type.
5027         (get_ada_pspace_data): Update.
5028         (ada_pspace_data_cleanup): Remove.
5029
5030 2019-05-08  Tom Tromey  <tom@tromey.com>
5031
5032         * coffread.c (struct coff_symfile_info): Add initializers.
5033         (coff_objfile_data_key): Move lower.  Change type.
5034         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5035         Update.
5036         (coff_free_info): Remove.
5037
5038 2019-05-08  Tom Tromey  <tom@tromey.com>
5039
5040         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5041         (fbsd_pspace_data_handle): Move lower.  Change type.
5042         (get_fbsd_pspace_data): Update.
5043         (fbsd_pspace_data_cleanup): Remove.
5044         (_initialize_fbsd_tdep): Update.
5045
5046 2019-05-08  Tom Tromey  <tom@tromey.com>
5047
5048         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5049         (get_ada_tasks_pspace_data): Update.
5050         (ada_tasks_pspace_data_cleanup): Remove.
5051         (_initialize_tasks): Update.
5052         (ada_tasks_inferior_data_handle): Change type.
5053         (get_ada_tasks_inferior_data): Update.
5054         (ada_tasks_inferior_data_cleanup): Remove.
5055         (struct ada_tasks_pspace_data): Add initializers.
5056
5057 2019-05-08  Tom Tromey  <tom@tromey.com>
5058
5059         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5060         * symfile-debug.c (debug_sym_get_probes): Change type.
5061         * stap-probe.c (handle_stap_probe):
5062         (stap_static_probe_ops::get_probes): Change type.
5063         * probe.h (class static_probe_ops) <get_probes>: Change type.
5064         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5065         (parse_probes_in_pspace): Update.
5066         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5067         Update.
5068         (any_static_probe_ops::get_probes): Change type.
5069         * elfread.c (elfread_data): New typedef.
5070         (probe_key): Change type.
5071         (elf_get_probes): Likewise.  Update.
5072         (probe_key_free): Remove.
5073         (_initialize_elfread): Update.
5074         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5075         Change type.
5076         (dtrace_process_dof_probe, dtrace_process_dof)
5077         (dtrace_static_probe_ops::get_probe): Change type.
5078
5079 2019-05-08  Tom Tromey  <tom@tromey.com>
5080
5081         * xcoffread.c (struct xcoff_symfile_info): Rename from
5082         coff_symfile_info.  Add initializers.
5083         (xcoff_objfile_data_key): Move lower.  Change type.
5084         (XCOFF_DATA): Rewrite.
5085         (xcoff_free_info): Remove.
5086         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5087         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5088         (xcoff_initial_scan): Update.
5089
5090 2019-05-08  Tom Tromey  <tom@tromey.com>
5091
5092         * solib-svr4.c (struct svr4_info): Add initializers and
5093         destructor.
5094         <probes_table>: Now an htab_up.
5095         (solib_svr4_pspace_data): Change type.
5096         (free_probes_table): Simplify.
5097         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5098         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5099         (probes_table_remove_objfile_probes, register_solib_event_probe)
5100         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5101         (_initialize_svr4_solib): Update.
5102
5103 2019-05-08  Tom Tromey  <tom@tromey.com>
5104
5105         * remote.c (remote_pspace_data): Change type.
5106         (remote_pspace_data_cleanup): Remove.
5107         (get_remote_exec_file, set_pspace_remote_exec_file)
5108         (_initialize_remote): Update.
5109
5110 2019-05-08  Tom Tromey  <tom@tromey.com>
5111
5112         * breakpoint.c (breakpoint_objfile_key): Change type.
5113         (get_breakpoint_objfile_data): Update.
5114         (free_breakpoint_objfile_data): Remove.
5115         (_initialize_breakpoint): Update.
5116
5117 2019-05-08  Tom Tromey  <tom@tromey.com>
5118
5119         * linux-tdep.c (struct linux_info): Add initializers.
5120         (linux_inferior_data): Move.  Change type.
5121         (invalidate_linux_cache_inf): Update.
5122         (linux_inferior_data_cleanup): Remove.
5123         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5124
5125 2019-05-08  Tom Tromey  <tom@tromey.com>
5126
5127         * auxv.c (auxv_inferior_data): Move.  Change type.
5128         (auxv_inferior_data_cleanup): Remove.
5129         (invalidate_auxv_cache_inf): Rewrite.
5130         (get_auxv_inferior_data, _initialize_auxv): Update.
5131
5132 2019-05-08  Tom Tromey  <tom@tromey.com>
5133
5134         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5135         (symfile_debug_objfile_data_key): Change type.
5136         (symfile_debug_installed, debug_qf_has_symbols)
5137         (debug_qf_find_last_source_symtab)
5138         (debug_qf_forget_cached_source_info)
5139         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5140         (debug_qf_print_stats, debug_qf_dump)
5141         (debug_qf_expand_symtabs_for_function)
5142         (debug_qf_expand_all_symtabs)
5143         (debug_qf_expand_symtabs_with_fullname)
5144         (debug_qf_map_matching_symbols)
5145         (debug_qf_expand_symtabs_matching)
5146         (debug_qf_find_pc_sect_compunit_symtab)
5147         (debug_qf_map_symbol_filenames)
5148         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5149         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5150         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5151         (debug_sym_read_linetable, debug_sym_relocate): Update.
5152         (symfile_debug_free_objfile): Remove.
5153         (install_symfile_debug_logging, _initialize_symfile_debug):
5154         Update.
5155
5156 2019-05-08  Tom Tromey  <tom@tromey.com>
5157
5158         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5159         allocate_on_obstack.
5160         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5161         (get_dwarf2_per_objfile): Update.
5162         (set_dwarf2_per_objfile): Remove.
5163         (dwarf2_has_info, dwarf2_get_section_info): Update.
5164         (dwarf2_free_objfile): Remove.
5165         (_initialize_dwarf2_read): Update.
5166
5167 2019-05-08  Tom Tromey  <tom@tromey.com>
5168
5169         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5170         initializers.
5171         <unsupported_script_warning_printed,
5172         script_not_found_warning_printed>: Now bool.
5173         (auto_load_pspace_data): Change type.
5174         (~auto_load_pspace_info): Rename from
5175         auto_load_pspace_data_cleanup.
5176         (get_auto_load_pspace_data, init_loaded_scripts_info)
5177         (clear_section_scripts, maybe_print_unsupported_script_warning)
5178         (maybe_print_script_not_found_warning, _initialize_auto_load):
5179         Update.
5180
5181 2019-05-08  Tom Tromey  <tom@tromey.com>
5182
5183         * objfiles.c (objfile_pspace_info): Add destructor and
5184         initializers.
5185         (objfiles_pspace_data): Change type.
5186         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5187         (get_objfile_pspace_data): Update.
5188         (objfiles_bfd_data): Change type.
5189         (get_objfile_bfd_data): Update.
5190         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5191
5192 2019-05-08  Tom Tromey  <tom@tromey.com>
5193
5194         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5195         Change type.
5196         (get_catch_syscall_inferior_data): Update.
5197         (catch_syscall_inferior_data_cleanup): Remove.
5198         (_initialize_break_catch_syscall): Update.
5199
5200 2019-05-08  Tom Tromey  <tom@tromey.com>
5201
5202         * inflow.c (struct terminal_info): Add destructor and
5203         initializers.
5204         (inflow_inferior_data): Change type.
5205         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5206         (get_inflow_inferior_data, inflow_inferior_exit)
5207         (swap_terminal_info, _initialize_inflow): Update.
5208
5209 2019-05-08  Tom Tromey  <tom@tromey.com>
5210
5211         * target-dcache.c (target_dcache_cleanup): Remove.
5212         (target_dcache_aspace_key): Change type.
5213         (target_dcache_init_p, target_dcache_invalidate)
5214         (target_dcache_get, target_dcache_get_or_init)
5215         (_initialize_target_dcache): Update.
5216         * dcache.h (struct dcache_deleter): New.
5217
5218 2019-05-08  Tom Tromey  <tom@tromey.com>
5219
5220         * symtab.c (struct symbol_cache): Add destructor and
5221         initializers.
5222         (symbol_cache_key): Move.  Change type.
5223         (make_symbol_cache, free_symbol_cache): Remove.
5224         (get_symbol_cache): Update.
5225         (symbol_cache_cleanup): Remove.
5226         (ALL_PSPACES, symbol_cache_flush)
5227         (maintenance_print_symbol_cache)
5228         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5229         Update.
5230
5231 2019-05-08  Tom Tromey  <tom@tromey.com>
5232
5233         * symtab.c (struct main_info): Add destructor and initializers.
5234         (main_progspace_key): Move.  Change type.
5235         (get_main_info): Update.
5236         (main_info_cleanup): Remove.
5237         (_initialize_symtab): Update.
5238
5239 2019-05-08  Tom Tromey  <tom@tromey.com>
5240
5241         * registry.h (DECLARE_REGISTRY): Define the _key class.
5242
5243 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5244
5245         * NEWS: Merge two 'New commands' sections.
5246
5247 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5248
5249         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5250         parameter and use Ada language definition instead.
5251         (ada_val_print_ptr): Remove unused language parameter.
5252         (ada_val_print_num): Remove language parameter and use Ada language
5253         definition instead.
5254         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5255         parameter.
5256         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5257         parameter and use Ada language definition instead.
5258         (ada_val_print_1): Update all ada_val_print_xxx calls.
5259         Remove language parameter.
5260         (ada_val_print): Update ada_val_print_1 call.
5261
5262 2019-05-08  Tom Tromey  <tromey@adacore.com>
5263
5264         * remote.c (remote_hw_watchpoint_limit)
5265         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5266         Now static.
5267
5268 2019-05-08  Tom Tromey  <tromey@adacore.com>
5269
5270         * maint.c (_initialize_maint_cmds): Move initialization code to
5271         remote.c.
5272         (watchdog, show_watchdog): Move to remote.c.
5273         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5274         "watchdog" static.
5275         (_initialize_remote): Move initialization code from maint.c.
5276         * defs.h (watchdog): Don't declare.
5277
5278 2019-05-08  Tom Tromey  <tromey@adacore.com>
5279
5280         * tui/tui-interp.c: Include main.h.
5281         * interps.c: Include main.h.
5282         * main.h (interpreter_p): Declare.
5283         * defs.h (interpreter_p): Don't declare.
5284
5285 2019-05-08  Tom Tromey  <tromey@adacore.com>
5286
5287         * dwarf2loc.c: Include dwarf2read.h.
5288         * defs.h (read_unsigned_leb128): Don't declare.
5289         * dwarf2read.h (read_unsigned_leb128): Declare.
5290
5291 2019-05-08  Tom Tromey  <tromey@adacore.com>
5292
5293         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5294         method.
5295
5296 2019-05-08  Tom Tromey  <tromey@adacore.com>
5297
5298         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5299         when no wrap column is set.
5300
5301 2019-05-08  Tom Tromey  <tromey@adacore.com>
5302
5303         * c-lang.c (c_get_string): Handle non-C-style arrays.
5304
5305 2019-05-08  Tom Tromey  <tromey@adacore.com>
5306
5307         * typeprint.c (print_offset_data::update): Print the bit offset,
5308         not the number of bits remaining.
5309
5310 2019-05-08  Tom Tromey  <tromey@adacore.com>
5311
5312         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5313         padding at end of comment.
5314
5315 2019-05-08  Tom Tromey  <tromey@adacore.com>
5316
5317         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5318         Compare main types.
5319
5320 2019-05-06  Tom Tromey  <tom@tromey.com>
5321
5322         * common/scoped_mmap.c: Include common-defs.h.
5323         * common/scoped_mmap.h: Don't include config.h.
5324
5325 2019-05-04  Tom Tromey  <tom@tromey.com>
5326
5327         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5328         (struct aarch64_call_info): Add initializers.
5329         <si>: Now a std::vector.
5330         (pass_on_stack, aarch64_push_dummy_call): Update.
5331
5332 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5333             Tom Tromey  <tom@tromey.com>
5334
5335         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5336         (ppc_threads): Now a std::vector.  Now static.
5337         (hwdebug_find_thread_points_by_tid)
5338         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5339         Update.
5340
5341 2019-05-04  Tom Tromey  <tom@tromey.com>
5342
5343         * arc-tdep.c (arc_tdesc_init): Return bool.
5344
5345 2019-05-04  Tom Tromey  <tom@tromey.com>
5346
5347         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5348         Use gdb_assert_not_reached.
5349
5350 2019-05-04  Tom Tromey  <tom@tromey.com>
5351
5352         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5353         "false".
5354
5355 2019-05-04  Tom Tromey  <tom@tromey.com>
5356
5357         * arc-tdep.c (arc_tdesc_init): Use bool.
5358
5359 2019-05-04  Tom Tromey  <tom@tromey.com>
5360
5361         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5362
5363 2019-05-04  Tom Tromey  <tom@tromey.com>
5364
5365         * cli/cli-cmds.c (valid_command_p): Return bool.
5366
5367 2019-05-04  Tom Tromey  <tom@tromey.com>
5368
5369         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5370         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5371
5372 2019-05-04  Raul Tambre  <raul@tambre.ee>
5373
5374         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5375         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5376         operator for comparison.
5377
5378 2019-05-04  Tom Tromey  <tom@tromey.com>
5379
5380         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5381         (lookup_partial_symbol, print_partial_symbols)
5382         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5383         (psymbol_compare): Update.
5384         (add_psymbol_to_bcache): Clear the entire psymbol.
5385         (maintenance_check_psymtabs): Update.
5386         * psympriv.h (struct partial_symbol): Don't derive from
5387         general_symbol_info.
5388         <obj_section, unrelocated_address, address,
5389         set_unrelocated_address>: Update.
5390         <ginfo>: New member.
5391         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5392         (debug_names::write_psymbols): Update.
5393
5394 2019-05-04  Tom de Vries  <tdevries@suse.de>
5395
5396         * contrib/cc-with-tweaks.sh: Support -n arg.
5397
5398 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5399
5400         * corelow.c (core_target::detach): Ensure frame cache and
5401         register caches are cleared.
5402         inferior.c (exit_inferior_1): Likewise.
5403
5404 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5405             Tom Tromey  <tom@tromey.com>
5406
5407         * dictionary.c (collate_pending_symbols_by_language): Remove
5408         "struct" from foreach.
5409         * symtab.c (lookup_global_symbol_from_objfile)
5410         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5411         foreach.
5412         * ser-tcp.c (net_open): Remove "struct" from foreach.
5413         * objfiles.c (objfile_relocate, objfile_rebase)
5414         (objfile_has_symbols): Remove "struct" from foreach.
5415         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5416         from foreach.
5417         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5418         foreach.
5419         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5420         "struct" from foreach.
5421         * ada-lang.c (create_excep_cond_exprs)
5422         (ada_exception_catchpoint_cond_string): Remove "struct" from
5423         foreach.
5424
5425 2019-05-03  Tom Tromey  <tromey@adacore.com>
5426
5427         * ada-exp.y (convert_char_literal): Check suffix of each
5428         enumerator.
5429
5430 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5431
5432         PR ada/21406:
5433         * ada-exp.y (yywrap): Don't define.
5434         * ada-lex.l (%option): Add noyywrap
5435         (yywrap): Remove.
5436
5437 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5438
5439         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5440         _WIN32_WINNT to the XP level, unless already defined to a higher
5441         level.
5442
5443         * unittests/parse-connection-spec-selftests.c:
5444         * ser-tcp.c:
5445         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5446         override.
5447
5448         * symfile.c (find_separate_debug_file): Remove colon from the
5449         drive spec of DOS/Windows file names of the target, so that the
5450         file name produced from DEBUGDIR and the target's directory will
5451         be valid on DOS/Windows systems.
5452
5453 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5454
5455         * rust-lang.c (val_print_struct): Handle printing structures
5456         containing strings.
5457
5458 2019-05-02  Tom Tromey  <tromey@adacore.com>
5459
5460         * valarith.c (_initialize_valarith): Remove.
5461
5462 2019-05-01  Tom Tromey  <tromey@adacore.com>
5463
5464         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5465         bitfields.
5466
5467 2019-05-01  Tom Tromey  <tromey@adacore.com>
5468
5469         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5470         for big-endian copies.
5471
5472 2019-04-30  Ali Tamur  <tamur@google.com>
5473         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5474         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5475         (read_3_bytes): New function.
5476
5477 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5478
5479         * windows-nat.c (main_thread_id): Delete.
5480         (handle_output_debug_string): Replace main_thread_id by
5481         current_event.dwThreadId.
5482         (fake_create_process): Likewise.
5483         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5484         Do not set main_thread_id.
5485         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5486         current_event.dwThreadId.
5487         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5488
5489 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5490
5491         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5492         Use current_event.dwThreadId instead of main_thread_id.
5493
5494 2019-04-30  Tom Tromey  <tromey@adacore.com>
5495
5496         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5497         (create_excep_cond_exprs): Iterate over program spaces.
5498         (ada_exception_catchpoint_cond_string): Examine all minimal
5499         symbols for exception types.
5500
5501 2019-04-30  Tom Tromey  <tromey@adacore.com>
5502
5503         PR c++/24470:
5504         * dwarf2read.c (process_structure_scope): Handle case where type
5505         has template parameters but no symbol was created.
5506
5507 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5508             Chris January  <chris.january@arm.com>
5509
5510         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5511         qualifier.
5512         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5513
5514 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5515
5516         * f-typeprint.c (f_print_type): Update rules for printing
5517         whitespace.
5518         (f_type_print_varspec_suffix): Likewise.
5519
5520 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5521             Chris January  <chris.january@arm.com>
5522
5523         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5524         function arguments.
5525
5526 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5527
5528         * f-lang.c (build_fortran_types): Change name of void type to
5529         lower case.
5530         * f-typeprint.c (f_type_print_base): Print the name of the void
5531         type, rather than a fixed string.
5532         * f-valprint.c (f_decorations): Use lower case void string.
5533
5534 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5535             Chris January  <chris.january@arm.com>
5536
5537         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5538         types for Fortran.
5539
5540 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5541             Chris January  <chris.january@arm.com>
5542             David Lecomber  <david.lecomber@arm.com>
5543
5544         * f-exp.y (BINOP_INTRINSIC): New token.
5545         (exp): New parser rule handling BINOP_INTRINSIC.
5546         (f77_keywords): Add new builtin procedures.
5547         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5548         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5549         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5550         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5551         (print_unop_subexp_f): New function.
5552         (print_binop_subexp_f): New function.
5553         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5554         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5555         (dump_subexp_body_f): Likewise.
5556         (operator_check_f): Likewise.
5557         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5558         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5559
5560 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5561
5562         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5563         UNOP_KIND.
5564         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5565         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5566         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5567         (operator_length_f): New fuction.
5568         (print_subexp_f): New function.
5569         (op_name_f): New function.
5570         (dump_subexp_body_f): New function.
5571         (operator_check_f): New function.
5572         (exp_descriptor_f): Replace standard expression handling functions
5573         with new functions.
5574         * gdb/fortran-operator.def: New file.
5575         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5576         * gdb/std-operator.def: Remove UNOP_KIND.
5577
5578 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5579
5580         * std-operator.def: Remove unbalanced, stray double quote
5581         character.
5582
5583 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5584             Chris January  <chris.january@arm.com>
5585             Daniel Everett  <daniel.everett@arm.com>
5586             Nick Forrington  <nick.forrington@arm.com>
5587             Richard Bunt  <richard.bunt@arm.com>
5588
5589         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5590         of depth when printing anonymous structs or unions.
5591         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5592         Don't print either the top-level value, or the children if the
5593         max-depth is exceeded.
5594         (ppscm_print_children): When printing the key of a map, allow one
5595         extra level of depth.
5596         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5597         print either the top-level value, or the children if the max-depth
5598         is exceeded.
5599         (print_children): When printing the key of a map, allow one extra
5600         level of depth.
5601         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5602         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5603         (user_print_options): Initialise max_depth field.
5604         (val_print_scalar_or_string_type_p): New function.
5605         (val_print): Check to see if the max depth has been reached.
5606         (val_print_check_max_depth): Define new function.
5607         (show_print_max_depth): New function.
5608         (_initialize_valprint): Add 'print max-depth' option.
5609         * valprint.h (struct value_print_options) <max_depth>: New field.
5610         (val_print_check_max_depth): Declare new function.
5611         * NEWS: Document new feature.
5612
5613 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5614
5615         * ada-lang.c (ada_language_defn): Initialise new field.
5616         * c-lang.c (c_is_string_type_p): New function.
5617         (c_language_defn): Initialise new field.
5618         (cplus_language_defn): Initialise new field.
5619         (asm_language_defn): Initialise new field.
5620         (minimal_language_defn): Initialise new field.
5621         * c-lang.h (c_is_string_type_p): Declare new function.
5622         * d-lang.c (d_language_defn): Initialise new field.
5623         * f-lang.c (f_is_string_type_p): New function.
5624         (f_language_defn): Initialise new field.
5625         * go-lang.c (go_is_string_type_p): New function.
5626         (go_language_defn): Initialise new field.
5627         * language.c (default_is_string_type_p): New function.
5628         (unknown_language_defn): Initialise new field.
5629         (auto_language_defn): Initialise new field.
5630         * language.h (struct language_defn) <la_is_string_type_p>: New
5631         member variable.
5632         (default_is_string_type_p): Declare new function.
5633         * m2-lang.c (m2_language_defn): Initialise new field.
5634         * objc-lang.c (objc_language_defn): Initialise new field.
5635         * opencl-lang.c (opencl_language_defn): Initialise new field.
5636         * p-lang.c (pascal_is_string_type_p): New function.
5637         (pascal_language_defn): Initialise new field.
5638         * rust-lang.c (rust_is_string_type_p): New function.
5639         (rust_language_defn): Initialise new field.
5640
5641 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5642
5643         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5644         New field.
5645         * ada-lang.c (ada_language_defn): Initialise new field.
5646         * c-lang.c (c_language_defn): Likewise.
5647         (cplus_language_defn): Likewise.
5648         (asm_language_defn): Likewise.
5649         (minimal_language_defn): Likewise.
5650         * d-lang.c (d_language_defn): Likewise.
5651         * f-lang.c (f_language_defn): Likewise.
5652         * go-lang.c (go_language_defn): Likewise.
5653         * language.c (unknown_language_defn): Likewise.
5654         (auto_language_defn): Likewise.
5655         * m2-lang.c (m2_language_defn): Likewise.
5656         * objc-lang.c (objc_language_defn): Likewise.
5657         * opencl-lang.c (opencl_language_defn): Likewise.
5658         * p-lang.c (pascal_language_defn): Likewise.
5659         * rust-lang.c (rust_language_defn): Likewise.
5660
5661 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5662
5663         * ada-lang.c (ada_is_character_type): Change return type to bool.
5664         (ada_is_string_type): Likewise.
5665         * ada-lang.h (ada_is_character_type): Update declaration
5666         (ada_is_string_type): Likewise.
5667
5668 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5669
5670         Support style in 'frame|thread apply'
5671
5672         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5673         * record.c (record_start, record_stop): Update callers of
5674         execute_command_to_string with false.
5675         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5676         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5677         methods.
5678         (class string_file): New constructor with term_out parameter.
5679         Override methods term_out and can_emit_style_escape.  New member
5680         term_out.
5681         (class stdio_file): Override can_emit_style_escape.
5682         (class tee_file): Override term_out and can_emit_style_escape.
5683         * utils.h (can_emit_style_escape): Remove.
5684         * utils.c (can_emit_style_escape): Likewise.
5685         Update all callers of can_emit_style_escape (SOMESTREAM) to
5686         SOMESTREAM->can_emit_style_escape.
5687         * source-cache.c (source_cache::get_source_lines): Likewise.
5688         * stack.c (frame_apply_command_count): Call execute_command_to_string
5689         passing the term_out characteristic of the current gdb_stdout.
5690         * thread.c (thr_try_catch_cmd): Likewise.
5691         * top.c (execute_command_to_string): pass term_out parameter
5692         to construct the string_file for the command output.
5693         * ui-file.c (term_cli_styling): New function (most code moved
5694         from utils.c can_emit_style_escape).
5695         (string_file::string_file, string_file::can_emit_style_escape,
5696         stdio_file::can_emit_style_escape, tee_file::term_out,
5697         tee_file::can_emit_style_escape): New functions.
5698
5699 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5700
5701         * NEWS: Mention the new set|show may-call-functions.
5702         * infcall.c (may_call_functions_p): New variable.
5703         (show_may_call_functions_p): New function.
5704         (call_function_by_hand_dummy): Throws an error if not
5705         may-call-functions.
5706         (_initialize_infcall): Call add_setshow_boolean_cmd for
5707         may-call-functions.
5708
5709 2019-04-25  Keith Seitz  <keiths@redhat.com>
5710
5711         PR c++/24367
5712         * cp-support.c (inspect_type): Don't attempt substitutions
5713         of symbol with the same name.
5714
5715 2019-04-25  Tom Tromey  <tromey@adacore.com>
5716
5717         PR gdb/24475:
5718         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5719         static.
5720
5721 2019-04-25  Tom Tromey  <tromey@adacore.com>
5722
5723         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5724         rvalue reference.
5725         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5726         (gdb_xml_parser::parse): Use std::move.
5727         * python/python-internal.h (gdbpy_convert_exception): Take a const
5728         reference.
5729         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5730         std::move.
5731         * python/py-utils.c (gdbpy_convert_exception): Take a const
5732         reference.
5733         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5734         Use std::move.
5735         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5736         Use std::move.
5737         * mi/mi-main.c (mi_print_exception): Take a const reference.
5738         * main.c (handle_command_errors): Take a const reference.
5739         * linespec.c (parse_linespec): Use std::move.
5740         * infcall.c (run_inferior_call): Use std::move.
5741         (call_function_by_hand_dummy): Use std::move.
5742         * exec.c (try_open_exec_file): Use std::move.
5743         * exceptions.h (exception_print, exception_fprintf)
5744         (exception_print_same): Update.
5745         * exceptions.c (print_exception, exception_print)
5746         (exception_fprintf, exception_print_same): Change parameters to
5747         const reference.
5748         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5749         * common/new-op.c: Use std::move.
5750         * common/common-exceptions.h (struct gdb_exception): Add move
5751         constructor.
5752         (struct gdb_exception_error, struct gdb_exception_quit, struct
5753         gdb_quit_bad_alloc): Change constructor to move constructor.
5754         (throw_exception): Change parameter to rvalue reference.
5755         * common/common-exceptions.c (throw_exception): Take rvalue
5756         reference.
5757         * cli/cli-interp.c (safe_execute_command): Use std::move.
5758         * breakpoint.c (insert_bp_location, location_to_sals): Use
5759         std::move.
5760
5761 2019-04-25  Tom Tromey  <tromey@adacore.com>
5762
5763         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5764         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5765         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5766         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5767         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5768         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5769         guile/scm-value.c: Use unpack.
5770         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5771         gdbscm_gdb_exception.
5772         (gdbscm_throw_gdb_exception): Likewise.
5773         (struct gdbscm_gdb_exception): New.
5774         (unpack): New function.
5775         (gdbscm_wrap): Use unpack.
5776
5777 2019-04-25  Tom Tromey  <tromey@adacore.com>
5778
5779         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5780         (gdb_rl_callback_handler): Use std::move.
5781         * common/common-exceptions.h (struct gdb_exception): Add move
5782         assignment operator.
5783         (throw_exception_sjlj): Change "exception" to const reference.
5784         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5785         (throw_exception_sjlj): Change "exception" to const reference.
5786
5787 2019-04-25  Tom Tromey  <tromey@adacore.com>
5788
5789         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5790         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5791         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5792         Update.
5793         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5794         Update.
5795         * mi/mi-interp.c (mi_interp::exec): Update.
5796         * linespec.c (parse_linespec): Update.
5797         * infcall.c (run_inferior_call): Update.
5798         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5799         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5800         (gdbscm_lookup_global_symbol): Update.
5801         * guile/scm-param.c (gdbscm_parameter_value): Update.
5802         * guile/scm-frame.c (gdbscm_frame_read_register)
5803         (gdbscm_frame_read_var): Update.
5804         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5805         * exec.c (try_open_exec_file): Update.
5806         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5807         (gdb_rl_callback_handler): Update.
5808         * common/common-exceptions.h (exception_none): Don't declare.
5809         * common/common-exceptions.c (exception_none): Don't define.
5810         (struct catcher) <exception>: Update.
5811         * cli/cli-interp.c (safe_execute_command): Update.
5812         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5813
5814 2019-04-25  Ali Tamur  <tamur@google.com>
5815
5816         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5817         (read_attribute_value): Likewise.
5818         (dwarf2_read_addr_index): Update comment.
5819         (read_str_index): Add DW_FORM_strx.
5820         (dwarf2_string_attr): Likewise.
5821         (dwarf2_const_value_attr): Likewise.
5822         (dump_die_shallow): Likewise.
5823         (dwarf2_fetch_constant_bytes): Likewise.
5824         (skip_form_bytes): Likewise.
5825         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5826
5827 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5828
5829         PR corefiles/11608
5830         PR corefiles/18187
5831         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5832         OFFSET.  Verify if current mapping contains an ELF header.
5833         (linux_find_memory_regions_full): Adjust call to
5834         dump_mapping_p.
5835
5836 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5837             Kang Li <kanglictf@gmail.com>
5838
5839         PR gdb/21600
5840
5841         * dwarf2-frame.c (read_initial_length): Be consistent about using
5842         unsigned representation of length.
5843         (decode_frame_entry_1): Likewise.  Check for wraparound of
5844         end pointer as well as buffer overflow.
5845
5846 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5847
5848         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5849         "vq".
5850
5851 2019-04-24  Tom Tromey  <tromey@adacore.com>
5852
5853         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5854
5855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5856
5857         * s12z-tdep.c (s12z_unwind_pc): Delete.
5858         (s12z_unwind_sp): Delete.
5859         (s12z_gdbarch_init): Don't register deleted functions with
5860         gdbarch.
5861
5862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5863
5864         * rl78-tdep.c (rl78_unwind_sp): Delete.
5865         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5866
5867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5868
5869         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5870         (xstormy16_unwind_pc): Delete.
5871         (xstormy16_dummy_id): Delete.
5872         (xstormy16_gdbarch_init): Don't register deleted functions with
5873         gdbarch.
5874
5875 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5876
5877         * vax-tdep.c (vax_unwind_pc): Delete.
5878         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5879
5880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5881
5882         * v850-tdep.c (v850_unwind_sp): Delete.
5883         (v850_unwind_pc): Delete.
5884         (v850_dummy_id): Delete.
5885         (v850_gdbarch_init): Don't register deleted functions with
5886         gdbarch.
5887
5888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5889
5890         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5891         (tilegx_unwind_pc): Delete.
5892         (tilegx_unwind_dummy_id): Delete.
5893         (tilegx_gdbarch_init): Don't register deleted functions with
5894         gdbarch.
5895
5896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5897
5898         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5899         (tic6x_dummy_id): Delete.
5900         (tic6x_gdbarch_init): Don't register deleted functions with
5901         gdbarch.
5902
5903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5904
5905         * sparc-tdep.c (sparc_unwind_pc): Delete.
5906         (sparc32_gdbarch_init): Don't register deleted function with
5907         gdbarch.
5908
5909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5910
5911         * sh-tdep.c (sh_unwind_sp): Delete.
5912         (sh_unwind_pc): Delete.
5913         (sh_dummy_id): Delete.
5914         (sh_gdbarch_init): Don't register deleted functions with
5915         gdbarch.
5916
5917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5918
5919         * score-tdep.c (score_unwind_sp): Delete.
5920         (score_unwind_pc): Delete.
5921         (score_dummy_id): Delete.
5922         (score_gdbarch_init): Don't register deleted functions with
5923         gdbarch.
5924
5925 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5926
5927         * rx-tdep.c (rx_unwind_pc): Delete.
5928         (rx_unwind_sp): Delete.
5929         (rx_dummy_id): Delete.
5930         (rx_gdbarch_init): Don't register deleted functions with
5931         gdbarch.  Update comment.
5932
5933 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5934
5935         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5936         (rs6000_dummy_id): Delete.
5937         (rs6000_gdbarch_init): Don't register deleted functions with
5938         gdbarch.
5939
5940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5941
5942         * or1k-tdep.c (or1k_dummy_id): Delete.
5943         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5944
5945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5946
5947         * nios2-tdep.c (nios2_dummy_id): Delete.
5948         (nios2_unwind_sp): Delete.
5949         (nios2_gdbarch_init): Don't register deleted functions with
5950         gdbarch.
5951
5952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5953
5954         * nds32-tdep.c (nds32_dummy_id): Delete.
5955         (nds32_unwind_pc): Delete.
5956         (nds32_unwind_sp): Delete.
5957         (nds32_gdbarch_init): Don't register deleted functions with
5958         gdbarch.
5959
5960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5961
5962         * msp430-tdep.c (msp430_unwind_pc): Delete.
5963         (msp430_unwind_sp): Delete.
5964         (msp430_dummy_id): Delete.
5965         (msp430_gdbarch_init): Don't register deleted functions with
5966         gdbarch.
5967
5968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5969
5970         * moxie-tdep.c (moxie_unwind_sp): Delete.
5971         (moxie_unwind_pc): Delete.
5972         (moxie_dummy_id): Delete.
5973         (moxie_gdbarch_init): Don't register deleted functions with
5974         gdbarch.
5975
5976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5977
5978         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5979         (mn10300_unwind_pc): Delete.
5980         (mn10300_unwind_sp): Delete.
5981         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5982         mn10300_unwind_sp.
5983         (mn10300_frame_unwind_init): Don't register deleted functions with
5984         gdbarch.
5985
5986 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5987
5988         * mep-tdep.c (mep_unwind_pc): Delete.
5989         (mep_unwind_sp): Delete.
5990         (mep_dummy_id): Delete.
5991         (mep_gdbarch_init): Don't register deleted functions with
5992         gdbarch.
5993
5994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5995
5996         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5997         (m68hc11_unwind_sp): Delete.
5998         (m68hc11_gdbarch_init): Don't register deleted functions with
5999         gdbarch.
6000
6001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6002
6003         * m32r-tdep.c (m32r_unwind_sp): Delete.
6004         (m32r_unwind_pc): Delete.
6005         (m32r_dummy_id): Delete.
6006         (m32r_gdbarch_init): Don't register deleted functions with
6007         gdbarch.
6008
6009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6010
6011         * m32c-tdep.c (m32c_unwind_pc): Delete.
6012         (m32c_unwind_sp): Delete.
6013         (m32c_dummy_id): Delete.
6014         (m32c_gdbarch_init): Don't register deleted functions with
6015         gdbarch.
6016
6017 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6018
6019         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6020         (lm32_unwind_pc): Delete.
6021         (lm32_dummy_id): Delete.
6022         (lm32_gdbarch_init): Don't register deleted functions with
6023         gdbarch.
6024
6025 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6026
6027         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6028         (iq2000_unwind_pc): Delete.
6029         (iq2000_dummy_id): Delete.
6030         (iq2000_gdbarch_init): Don't register deleted functions with
6031         gdbarch.
6032
6033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6034
6035         * nds32-tdep.c (nds32_type_align): Delete.
6036         (nds32_push_dummy_call): Use type_align instead.
6037
6038 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6039
6040         * arm-tdep.c (arm_type_align): Only handle vector override case.
6041         (arm_push_dummy_call): Use type_align.
6042         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6043
6044 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6047         case.
6048         (pass_on_stack): Use type_align.
6049         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6050         function.
6051
6052 2019-04-23  Tom Tromey  <tromey@adacore.com>
6053
6054         * dwarf2read.c (line_header::file_name_at): Remove unused
6055         overload.
6056
6057 2019-04-23  Tom de Vries  <tdevries@suse.de>
6058
6059         PR gdb/24438
6060         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6061         invocation.
6062
6063
6064 2019-03-27  Ali Tamur  <tamur@google.com>
6065
6066         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6067         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6068         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6069         (dwarf_expr_context::get_addr_index): Likewise
6070         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6071         (symbol_needs_eval_context::get_addr_index): Likewise
6072         (disassemble_dwarf_expression): Add DW_OP_addrx
6073         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6074         (read_cutu_die_from_dwo): Update comment
6075         (skip_one_die): Add DW_FORM_addrx
6076         (read_attribute_value): Likewise
6077         (var_decode_location): Add DW_OP_addrx
6078         (dwarf2_const_value_attr): Add DW_FORM_addrx
6079         (dump_die_shallow): Likewise
6080         (dwarf2_fetch_constant_bytes): Likewise
6081         (decode_locdesc): Add DW_OP_addrx
6082         (skip_form_bytes): Add DW_FORM_addrx
6083
6084 2019-04-22  Ali Tamur  <tamur@google.com>
6085
6086         * MAINTAINERS (Write After Approval): Add self.
6087
6088 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6089
6090         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6091         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6092         (open_symbol_file_object): Likewise.
6093         (svr4_default_sos): Add info parameter.
6094         (svr4_read_so_list): Likewise.
6095         (svr4_current_sos_direct): Adjust functions calls to pass down
6096         info.
6097         (svr4_current_sos_1): Add info parameter.
6098         (svr4_current_sos): Call get_svr4_info, pass info down to
6099         svr4_current_sos_1.
6100         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6101         get_svr4_info.
6102         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6103         get_svr4_info.
6104         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6105         to get_svr4_info.
6106         (probes_table_remove_objfile_probes): Likewise.
6107         (register_solib_event_probe): Add info parameter.
6108         (solist_update_incremental): Pass info parameter down to
6109         svr4_read_so_list.
6110         (disable_probes_interface): Add info parameter.
6111         (svr4_handle_solib_event): Pass current_program_space to
6112         get_svr4_info.  Adjust disable_probes_interface cleanup.
6113         (svr4_create_probe_breakpoints): Add info parameter, pass it
6114         down to register_solib_event_probe.
6115         (svr4_create_solib_event_breakpoints): Add info parameter,
6116         pass it down to svr4_create_probe_breakpoints.
6117         (enable_break): Pass info down to
6118         svr4_create_solib_event_breakpoints.
6119         (svr4_solib_create_inferior_hook): Pass current_program_space to
6120         get_svr4_info.
6121         (svr4_clear_solib): Likewise.
6122
6123 2019-04-22  Pedro Alves  <palves@redhat.com>
6124
6125         * solib-svr4.c (svr4_free_objfile_observer): New.
6126         (probe_and_action::objfile): New field.
6127         (probes_table_htab_remove_objfile_probes)
6128         (probes_table_remove_objfile_probes): New functions.
6129         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6130         in the new probe_and_action.  Don't store the probe in 'lookup'.
6131         (svr4_create_probe_breakpoints): Pass objfile to
6132         register_solib_event_probe.
6133         (_initialize_svr4_solib): Register a free_objfile observer.
6134
6135 2019-04-19  Tom Tromey  <tom@tromey.com>
6136
6137         * common/queue.h: Remove.
6138
6139 2019-04-19  Tom Tromey  <tom@tromey.com>
6140
6141         * event-loop.c: Don't include "common/queue.h".
6142
6143 2019-04-19  Tom Tromey  <tom@tromey.com>
6144
6145         * remote.c (remote_target): Use delete.
6146         * remote-notif.h: Include <list>, not "common/queue.h".
6147         (notif_client_p): Remove typedef.
6148         (remote_notif_state): Add constructor, destructor, initializer.
6149         <notif_queue>: Now a std::list.
6150         (remote_notif_state_xfree): Don't declare.
6151         * remote-notif.c (remote_notif_process, handle_notification)
6152         (remote_notif_state_allocate): Update.
6153         (~remote_notif_state): Rename from remote_notif_state_xfree.
6154
6155 2019-04-19  Tom Tromey  <tom@tromey.com>
6156
6157         * symfile.c (reread_symbols): Update.
6158         * objfiles.c (objfile_register_static_link)
6159         (objfile_lookup_static_link): Update
6160         (~objfile) Don't delete static_links.
6161         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6162
6163 2019-04-19  Tom Tromey  <tom@tromey.com>
6164
6165         * type-stack.h (struct type_stack) <insert>: Constify string.
6166         * type-stack.c (type_stack::insert): Constify string.
6167         * gdbtypes.h (lookup_template_type): Update.
6168         (address_space_name_to_int): Update.
6169         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6170         const.
6171         (lookup_template_type): Make name const.
6172         * c-exp.y: Update rules.
6173         (lex_one_token, classify_name, classify_inner_name)
6174         (c_print_token): Update.
6175         * p-exp.y: Update rules.
6176         (yylex): Update.
6177         * f-exp.y: Update rules.
6178         (yylex): Update.
6179         * d-exp.y: Update rules.
6180         (lex_one_token, classify_name, classify_inner_name): Update.
6181         * parse.c (write_dollar_variable, copy_name): Return std::string.
6182         * parser-defs.h (copy_name): Change return type.
6183         * m2-exp.y: Update rules.
6184         (yylex): Update.
6185         * go-exp.y (lex_one_token): Update.
6186         Update rules.
6187         (classify_unsafe_function, classify_packaged_name)
6188         (classify_name, yylex): Update.
6189
6190 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6191
6192         * configure.ac: add --enable-source-highlight switch.
6193         * configure: Regenerate.
6194         * top.c (print_gdb_version): plumb --enable-source-highlight
6195         status to "show configuration".
6196
6197 2019-04-19  Tom Tromey  <tromey@adacore.com>
6198
6199         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6200         Check ADA_TYPE_P.
6201         (empty_record, ada_template_to_fixed_record_type_1)
6202         (template_to_static_fixed_type)
6203         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6204         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6205         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6206         macros.
6207
6208 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6209
6210         PR symtab/24423:
6211         * source.c (print_source_lines_base): Advance "iter" when a
6212         control character is seen.
6213
6214 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6215
6216         * inferior.h (struct infcall_suspend_state_deleter):
6217         Catch exception in destructor to avoid crash.
6218
6219 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6220
6221         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6222         close to the add_com "shell".
6223
6224 2019-04-18  Tom Tromey  <tromey@adacore.com>
6225
6226         * process-stratum-target.h (class process_stratum_target)
6227         <stratum>: Add "final".
6228
6229 2019-04-17  Tom Tromey  <tromey@adacore.com>
6230
6231         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6232         against nullptr before use.
6233
6234 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6235
6236         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6237
6238 2019-04-17  Jim Wilson  <jimw@sifive.com>
6239             Andrew Burgess  <andrew.burgess@embecosm.com>
6240
6241         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6242         code read might fail, assume 4-byte breakpoint in that case.
6243
6244 2019-04-15  Leszek Swirski  <leszeks@google.com>
6245
6246         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6247         rather than a hand-rolled POD check when checking for forced MEMORY
6248         classification.
6249
6250 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6251
6252         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6253         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6254         function.
6255         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6256         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6257         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6258         declaration.
6259
6260 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6261
6262         * aarch64-linux-nat.c
6263         (aarch64_linux_nat_target::thread_architecture): Add override.
6264         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6265         each VQ.
6266
6267 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6268
6269         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6270
6271 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6272
6273         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6274         target types of size 96-bits, add some additional comments, and
6275         check that the builtin type we found was the correct size.
6276
6277 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6278
6279         * utils.c (prompt_for_continue): Don't restore the styling at the
6280         end, as applied_style has the wrong value.  This fixes styling in
6281         long lists of file names that are interrupted by the "Continue?"
6282         prompt.
6283
6284 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6285
6286         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6287         * c-lang.c (c_language_defn): Likewise.
6288         (cplus_language_defn): Likewise.
6289         (asm_language_defn): Likewise.
6290         (minimal_language_defn): Likewise.
6291         * d-lang.c (d_language_defn): Likewise.
6292         * f-lang.c (f_language_defn): Likewise.
6293         * go-lang.c (go_language_defn): Likewise.
6294         * language.c (unknown_language_defn): Likewise.
6295         (auto_language_defn): Likewise.
6296         * language.h (struct language_defn): Remove la_magic field.
6297         (LANG_MAGIC): Delete.
6298         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6299         * objc-lang.c (objc_language_defn): Likewise.
6300         * opencl-lang.c (opencl_language_defn): Likewise.
6301         * p-lang.c (pascal_language_defn): Likewise.
6302         * rust-lang.c (rust_language_defn): Likewise.
6303
6304 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6305
6306         * riscv-tdep.c (riscv_type_align): New function.
6307         (riscv_type_alignment): Delete.
6308         (riscv_arg_location): Use 'type_align'.
6309         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6310
6311 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6312
6313         * gdbtypes.c (type_align): A struct with no non-static fields also
6314         has alignment of 1.
6315
6316 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6317
6318         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6319         component to 0.
6320         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6321         member.
6322         (riscv_struct_info::analyse): New implementation using new
6323         analyse_inner member function.
6324         (riscv_struct_info::field_offset): New member function.
6325         (riscv_struct_info::m_offsets): New member variable.
6326         (riscv_struct_info::analyse_inner): New private member function,
6327         takes the old implementation of riscv_struct_info::analyse but
6328         extended to track field offsets.
6329         (riscv_call_arg_struct): Update the struct folding special cases
6330         to handle cases where empty C++ structs, which are non-zero
6331         length, are found.
6332         (riscv_arg_location): Initialise the length of each location, a
6333         non-zero length now indicates the location is in use.
6334         (riscv_push_dummy_call): Allow for the first location having a
6335         non-zero offset when setting up arguments.
6336         (riscv_return_value): Likewise, but for return values.
6337
6338 2019-04-11  Tom Tromey  <tromey@adacore.com>
6339
6340         * utils.c (internal_vproblem): Make "msg" const.
6341
6342 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6343
6344         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6345         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6346         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6347         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6348
6349 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6350
6351         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6352         function.
6353         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6354         of amd64_collect_native_gregset.
6355         (amd64_linux_nat_target::store_registers): Likewise.
6356
6357 2019-04-10  Tom Tromey  <tom@tromey.com>
6358
6359         * symtab.c (lookup_global_symbol_from_objfile)
6360         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6361         * objfiles.h (class separate_debug_iterator): New.
6362         (class separate_debug_range): New.
6363         (struct objfile) <separate_debug_objfiles>: New method.
6364         (objfile_separate_debug_iterate): Don't declare.
6365         * objfiles.c (separate_debug_iterator::operator++): Rename from
6366         objfile_separate_debug_iterate.
6367         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6368         iterator.
6369         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6370         iterator.
6371
6372 2019-04-10  Tom Tromey  <tom@tromey.com>
6373
6374         * symfile.c (reread_symbols): Remove old comment.
6375         * objfiles.c (free_all_objfiles): Fix a typo.
6376
6377 2019-04-10  Tom Tromey  <tom@tromey.com>
6378
6379         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6380         * minsyms.c (lookup_minimal_symbol): Use foreach.
6381         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6382         (lookup_minimal_symbol_solib_trampoline): Likewise.
6383         * symfile.c (reread_symbols): Use foreach.
6384
6385 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6386             Tom Tromey  <tromey@adacore.com>
6387
6388         PR rust/24414:
6389         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6390         (rust_lex_int_test): Change "value" to be LONGEST.
6391         (rust_lex_tests): Add test for long integer literal.
6392
6393 2019-04-09  Tom Tromey  <tromey@adacore.com>
6394
6395         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6396         to bool.
6397         (extended_remote_target::attach): Update.
6398         (remote_target::remote_notice_new_inferior): Update.
6399         (remote_target::add_current_inferior_and_thread): Update.
6400         * inferior.c (exit_inferior_1): Use "false".
6401         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6402
6403 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6404
6405         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6406         the "start" command.
6407
6408 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6409
6410         * python/py-inferior.c (infpy_thread_from_thread_handle):
6411         Adjust comments to reflect renaming of thread_from_thread_handle
6412         to thread_from_handle.  Adjust keywords.  Fix type error message.
6413         (inferior_object_methods): Add thread_from_handle.  Retain
6414         thread_from_thread_handle, but mark it as deprecated.
6415
6416 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6417
6418         * gdbthread.h (find_thread_by_handle): Revise declaration.
6419         * thread.c (find_thread_by_handle): Likewise.  Adjust
6420         implementation too.
6421         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6422         support for buffer objects as handles.
6423
6424 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6425
6426         * python/py-infthread.c (thpy_thread_handle): New function.
6427         (thread_object_methods): Register thpy_thread_handle.
6428
6429 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6430
6431         * gdbthread.h (thread_to_thread_handle): Declare.
6432         * thread.c (gdbtypes.h): Include.
6433         (thread_to_thread_handle): New function.
6434
6435         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6436         (target_thread_info_to_thread_handle): Declare.
6437         * target.c (target_thread_info_to_thread_handle): New function.
6438         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6439         * target-delegates.c: Regenerate.
6440
6441         * linux-thread-db.c (class thread_db_target): Add method
6442         thread_info_to_thread_handle.
6443         (thread_db_target::thread_info_to_thread_handle): Define.
6444         * remote.c (class remote_target): Add new method
6445         thread_info_to_thread_handle.
6446         (remote_target::thread_info_to_thread_handle): Define.
6447
6448 2019-04-08  Pedro Alves  <palves@redhat.com>
6449
6450         * common/common-exceptions.c (throw_exception): Don't create
6451         named object to throw; throw directly.
6452         (throw_it): Likewise.  Don't initialize gdb_exception::message
6453         here, with new; pass FMT and AP to the ctor instead.
6454         * common/common-exceptions.h: Include <string>.
6455         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6456         const char *, va_list)): New ctor.  Use std::make_shared.
6457         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6458         errors)): Delete.
6459         (gdb_exception_error::gdb_exception_error(enum errors, const char
6460         *, va_list)): New.
6461         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6462         Add assertion.
6463         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6464         errors)): Delete.
6465         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6466         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6467         Add assertion.
6468
6469 2019-04-08  Tom Tromey  <tom@tromey.com>
6470
6471         * valops.c (value_rtti_indirect_type): Replace throw_exception
6472         with throw.
6473         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6474         with throw.
6475         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6476         throw.
6477         * target.c (target_translate_tls_address): Replace throw_exception
6478         with throw.
6479         * stack.c (frame_apply_command_count): Replace throw_exception
6480         with throw.
6481         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6482         throw.
6483         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6484         with throw.
6485         * rs6000-tdep.c (rs6000_frame_cache)
6486         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6487         * remote.c: Replace throw_exception with throw.
6488         * record-full.c (record_full_message, record_full_wait_1)
6489         (record_full_restore): Replace throw_exception with throw.
6490         * record-btrace.c:
6491         (get_thread_current_frame_id, record_btrace_start_replaying)
6492         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6493         (cmd_record_btrace_start): Replace throw_exception with throw.
6494         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6495         throw.
6496         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6497         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6498         * linespec.c:
6499         (find_linespec_symbols): Replace throw_exception with throw.
6500         * infrun.c (displaced_step_prepare, resume): Replace
6501         throw_exception with throw.
6502         * infcmd.c (post_create_inferior): Replace throw_exception with
6503         throw.
6504         * inf-loop.c (inferior_event_handler): Replace throw_exception
6505         with throw.
6506         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6507         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6508         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6509         (get_prev_frame_always, get_frame_pc_if_available)
6510         (get_frame_address_in_block_if_available, get_frame_language):
6511         Replace throw_exception with throw.
6512         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6513         throw_exception with throw.
6514         * eval.c (fetch_subexp_value, evaluate_var_value)
6515         (evaluate_funcall, evaluate_subexp_standard): Replace
6516         throw_exception with throw.
6517         * dwarf2loc.c (call_site_find_chain)
6518         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6519         Replace throw_exception with throw.
6520         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6521         with throw.
6522         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6523         throw.
6524         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6525         * completer.c (complete_line_internal): Replace throw_exception
6526         with throw.
6527         * compile/compile-object-run.c (compile_object_run): Replace
6528         throw_exception with throw.
6529         * cli/cli-script.c (process_next_line): Replace throw_exception
6530         with throw.
6531         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6532         (btrace_enable, btrace_maint_update_pt_packets): Replace
6533         throw_exception with throw.
6534         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6535         throw_exception with throw.
6536         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6537         throw_exception with throw.
6538         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6539         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6540         * aarch64-tdep.c (aarch64_make_prologue_cache)
6541         (aarch64_make_stub_cache): Replace throw_exception with throw.
6542
6543 2019-04-08  Tom Tromey  <tom@tromey.com>
6544
6545         * common/common-exceptions.c (throw_exception): Rename from
6546         throw_exception_cxx.  Remove old copy.  Make argument const.
6547         (throw_it): Create and throw exception objects directly.
6548         * common/common-exceptions.h (throw_exception): Make argument
6549         const.
6550         (struct gdb_exception_error): Add constructor.
6551         (struct gdb_exception_quit): Add constructor.
6552
6553 2019-04-08  Tom Tromey  <tom@tromey.com>
6554
6555         * common/common-exceptions.h (exception_rethrow): Don't declare.
6556         (TRY_SJLJ): Update comment.
6557         (TRY, CATCH, END_CATCH): Remove.
6558         * common/common-exceptions.c (exception_rethrow): Remove.
6559
6560 2019-04-08  Tom Tromey  <tom@tromey.com>
6561
6562         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6563         Remove.
6564         (gdb_exception_error): Rename from
6565         gdb_exception_RETURN_MASK_ERROR.
6566         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6567         (gdb_quit_bad_alloc): Update.
6568         * aarch64-tdep.c: Update.
6569         * ada-lang.c: Update.
6570         * ada-typeprint.c: Update.
6571         * ada-valprint.c: Update.
6572         * amd64-tdep.c: Update.
6573         * arch-utils.c: Update.
6574         * break-catch-throw.c: Update.
6575         * breakpoint.c: Update.
6576         * btrace.c: Update.
6577         * c-varobj.c: Update.
6578         * cli/cli-cmds.c: Update.
6579         * cli/cli-interp.c: Update.
6580         * cli/cli-script.c: Update.
6581         * common/common-exceptions.c: Update.
6582         * common/new-op.c: Update.
6583         * common/selftest.c: Update.
6584         * compile/compile-c-symbols.c: Update.
6585         * compile/compile-cplus-symbols.c: Update.
6586         * compile/compile-object-load.c: Update.
6587         * compile/compile-object-run.c: Update.
6588         * completer.c: Update.
6589         * corelow.c: Update.
6590         * cp-abi.c: Update.
6591         * cp-support.c: Update.
6592         * cp-valprint.c: Update.
6593         * darwin-nat.c: Update.
6594         * disasm-selftests.c: Update.
6595         * dtrace-probe.c: Update.
6596         * dwarf-index-cache.c: Update.
6597         * dwarf-index-write.c: Update.
6598         * dwarf2-frame-tailcall.c: Update.
6599         * dwarf2-frame.c: Update.
6600         * dwarf2loc.c: Update.
6601         * dwarf2read.c: Update.
6602         * eval.c: Update.
6603         * event-loop.c: Update.
6604         * event-top.c: Update.
6605         * exec.c: Update.
6606         * f-valprint.c: Update.
6607         * fbsd-tdep.c: Update.
6608         * frame-unwind.c: Update.
6609         * frame.c: Update.
6610         * gdbtypes.c: Update.
6611         * gnu-v3-abi.c: Update.
6612         * guile/guile-internal.h: Update.
6613         * guile/scm-block.c: Update.
6614         * guile/scm-breakpoint.c: Update.
6615         * guile/scm-cmd.c: Update.
6616         * guile/scm-disasm.c: Update.
6617         * guile/scm-frame.c: Update.
6618         * guile/scm-lazy-string.c: Update.
6619         * guile/scm-math.c: Update.
6620         * guile/scm-param.c: Update.
6621         * guile/scm-ports.c: Update.
6622         * guile/scm-pretty-print.c: Update.
6623         * guile/scm-symbol.c: Update.
6624         * guile/scm-symtab.c: Update.
6625         * guile/scm-type.c: Update.
6626         * guile/scm-value.c: Update.
6627         * i386-linux-tdep.c: Update.
6628         * i386-tdep.c: Update.
6629         * inf-loop.c: Update.
6630         * infcall.c: Update.
6631         * infcmd.c: Update.
6632         * infrun.c: Update.
6633         * jit.c: Update.
6634         * language.c: Update.
6635         * linespec.c: Update.
6636         * linux-fork.c: Update.
6637         * linux-nat.c: Update.
6638         * linux-tdep.c: Update.
6639         * linux-thread-db.c: Update.
6640         * main.c: Update.
6641         * mi/mi-cmd-break.c: Update.
6642         * mi/mi-cmd-stack.c: Update.
6643         * mi/mi-interp.c: Update.
6644         * mi/mi-main.c: Update.
6645         * objc-lang.c: Update.
6646         * p-valprint.c: Update.
6647         * parse.c: Update.
6648         * ppc-linux-tdep.c: Update.
6649         * printcmd.c: Update.
6650         * python/py-arch.c: Update.
6651         * python/py-breakpoint.c: Update.
6652         * python/py-cmd.c: Update.
6653         * python/py-finishbreakpoint.c: Update.
6654         * python/py-frame.c: Update.
6655         * python/py-framefilter.c: Update.
6656         * python/py-gdb-readline.c: Update.
6657         * python/py-inferior.c: Update.
6658         * python/py-infthread.c: Update.
6659         * python/py-lazy-string.c: Update.
6660         * python/py-linetable.c: Update.
6661         * python/py-objfile.c: Update.
6662         * python/py-param.c: Update.
6663         * python/py-prettyprint.c: Update.
6664         * python/py-progspace.c: Update.
6665         * python/py-record-btrace.c: Update.
6666         * python/py-record.c: Update.
6667         * python/py-symbol.c: Update.
6668         * python/py-type.c: Update.
6669         * python/py-unwind.c: Update.
6670         * python/py-utils.c: Update.
6671         * python/py-value.c: Update.
6672         * python/python.c: Update.
6673         * record-btrace.c: Update.
6674         * record-full.c: Update.
6675         * remote-fileio.c: Update.
6676         * remote.c: Update.
6677         * riscv-tdep.c: Update.
6678         * rs6000-aix-tdep.c: Update.
6679         * rs6000-tdep.c: Update.
6680         * rust-exp.y: Update.
6681         * rust-lang.c: Update.
6682         * s390-tdep.c: Update.
6683         * selftest-arch.c: Update.
6684         * solib-dsbt.c: Update.
6685         * solib-frv.c: Update.
6686         * solib-spu.c: Update.
6687         * solib-svr4.c: Update.
6688         * solib.c: Update.
6689         * sparc64-linux-tdep.c: Update.
6690         * stack.c: Update.
6691         * symfile-mem.c: Update.
6692         * symmisc.c: Update.
6693         * target.c: Update.
6694         * thread.c: Update.
6695         * top.c: Update.
6696         * tracefile-tfile.c: Update.
6697         * tui/tui.c: Update.
6698         * typeprint.c: Update.
6699         * unittests/cli-utils-selftests.c: Update.
6700         * unittests/parse-connection-spec-selftests.c: Update.
6701         * valops.c: Update.
6702         * valprint.c: Update.
6703         * value.c: Update.
6704         * varobj.c: Update.
6705         * windows-nat.c: Update.
6706         * x86-linux-nat.c: Update.
6707         * xml-support.c: Update.
6708
6709 2019-04-08  Tom Tromey  <tom@tromey.com>
6710
6711         * xml-support.c: Use C++ exception handling.
6712         * x86-linux-nat.c: Use C++ exception handling.
6713         * windows-nat.c: Use C++ exception handling.
6714         * varobj.c: Use C++ exception handling.
6715         * value.c: Use C++ exception handling.
6716         * valprint.c: Use C++ exception handling.
6717         * valops.c: Use C++ exception handling.
6718         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6719         handling.
6720         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6721         * typeprint.c: Use C++ exception handling.
6722         * tui/tui.c: Use C++ exception handling.
6723         * tracefile-tfile.c: Use C++ exception handling.
6724         * top.c: Use C++ exception handling.
6725         * thread.c: Use C++ exception handling.
6726         * target.c: Use C++ exception handling.
6727         * symmisc.c: Use C++ exception handling.
6728         * symfile-mem.c: Use C++ exception handling.
6729         * stack.c: Use C++ exception handling.
6730         * sparc64-linux-tdep.c: Use C++ exception handling.
6731         * solib.c: Use C++ exception handling.
6732         * solib-svr4.c: Use C++ exception handling.
6733         * solib-spu.c: Use C++ exception handling.
6734         * solib-frv.c: Use C++ exception handling.
6735         * solib-dsbt.c: Use C++ exception handling.
6736         * selftest-arch.c: Use C++ exception handling.
6737         * s390-tdep.c: Use C++ exception handling.
6738         * rust-lang.c: Use C++ exception handling.
6739         * rust-exp.y: Use C++ exception handling.
6740         * rs6000-tdep.c: Use C++ exception handling.
6741         * rs6000-aix-tdep.c: Use C++ exception handling.
6742         * riscv-tdep.c: Use C++ exception handling.
6743         * remote.c: Use C++ exception handling.
6744         * remote-fileio.c: Use C++ exception handling.
6745         * record-full.c: Use C++ exception handling.
6746         * record-btrace.c: Use C++ exception handling.
6747         * python/python.c: Use C++ exception handling.
6748         * python/py-value.c: Use C++ exception handling.
6749         * python/py-utils.c: Use C++ exception handling.
6750         * python/py-unwind.c: Use C++ exception handling.
6751         * python/py-type.c: Use C++ exception handling.
6752         * python/py-symbol.c: Use C++ exception handling.
6753         * python/py-record.c: Use C++ exception handling.
6754         * python/py-record-btrace.c: Use C++ exception handling.
6755         * python/py-progspace.c: Use C++ exception handling.
6756         * python/py-prettyprint.c: Use C++ exception handling.
6757         * python/py-param.c: Use C++ exception handling.
6758         * python/py-objfile.c: Use C++ exception handling.
6759         * python/py-linetable.c: Use C++ exception handling.
6760         * python/py-lazy-string.c: Use C++ exception handling.
6761         * python/py-infthread.c: Use C++ exception handling.
6762         * python/py-inferior.c: Use C++ exception handling.
6763         * python/py-gdb-readline.c: Use C++ exception handling.
6764         * python/py-framefilter.c: Use C++ exception handling.
6765         * python/py-frame.c: Use C++ exception handling.
6766         * python/py-finishbreakpoint.c: Use C++ exception handling.
6767         * python/py-cmd.c: Use C++ exception handling.
6768         * python/py-breakpoint.c: Use C++ exception handling.
6769         * python/py-arch.c: Use C++ exception handling.
6770         * printcmd.c: Use C++ exception handling.
6771         * ppc-linux-tdep.c: Use C++ exception handling.
6772         * parse.c: Use C++ exception handling.
6773         * p-valprint.c: Use C++ exception handling.
6774         * objc-lang.c: Use C++ exception handling.
6775         * mi/mi-main.c: Use C++ exception handling.
6776         * mi/mi-interp.c: Use C++ exception handling.
6777         * mi/mi-cmd-stack.c: Use C++ exception handling.
6778         * mi/mi-cmd-break.c: Use C++ exception handling.
6779         * main.c: Use C++ exception handling.
6780         * linux-thread-db.c: Use C++ exception handling.
6781         * linux-tdep.c: Use C++ exception handling.
6782         * linux-nat.c: Use C++ exception handling.
6783         * linux-fork.c: Use C++ exception handling.
6784         * linespec.c: Use C++ exception handling.
6785         * language.c: Use C++ exception handling.
6786         * jit.c: Use C++ exception handling.
6787         * infrun.c: Use C++ exception handling.
6788         * infcmd.c: Use C++ exception handling.
6789         * infcall.c: Use C++ exception handling.
6790         * inf-loop.c: Use C++ exception handling.
6791         * i386-tdep.c: Use C++ exception handling.
6792         * i386-linux-tdep.c: Use C++ exception handling.
6793         * guile/scm-value.c: Use C++ exception handling.
6794         * guile/scm-type.c: Use C++ exception handling.
6795         * guile/scm-symtab.c: Use C++ exception handling.
6796         * guile/scm-symbol.c: Use C++ exception handling.
6797         * guile/scm-pretty-print.c: Use C++ exception handling.
6798         * guile/scm-ports.c: Use C++ exception handling.
6799         * guile/scm-param.c: Use C++ exception handling.
6800         * guile/scm-math.c: Use C++ exception handling.
6801         * guile/scm-lazy-string.c: Use C++ exception handling.
6802         * guile/scm-frame.c: Use C++ exception handling.
6803         * guile/scm-disasm.c: Use C++ exception handling.
6804         * guile/scm-cmd.c: Use C++ exception handling.
6805         * guile/scm-breakpoint.c: Use C++ exception handling.
6806         * guile/scm-block.c: Use C++ exception handling.
6807         * guile/guile-internal.h: Use C++ exception handling.
6808         * gnu-v3-abi.c: Use C++ exception handling.
6809         * gdbtypes.c: Use C++ exception handling.
6810         * frame.c: Use C++ exception handling.
6811         * frame-unwind.c: Use C++ exception handling.
6812         * fbsd-tdep.c: Use C++ exception handling.
6813         * f-valprint.c: Use C++ exception handling.
6814         * exec.c: Use C++ exception handling.
6815         * event-top.c: Use C++ exception handling.
6816         * event-loop.c: Use C++ exception handling.
6817         * eval.c: Use C++ exception handling.
6818         * dwarf2read.c: Use C++ exception handling.
6819         * dwarf2loc.c: Use C++ exception handling.
6820         * dwarf2-frame.c: Use C++ exception handling.
6821         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6822         * dwarf-index-write.c: Use C++ exception handling.
6823         * dwarf-index-cache.c: Use C++ exception handling.
6824         * dtrace-probe.c: Use C++ exception handling.
6825         * disasm-selftests.c: Use C++ exception handling.
6826         * darwin-nat.c: Use C++ exception handling.
6827         * cp-valprint.c: Use C++ exception handling.
6828         * cp-support.c: Use C++ exception handling.
6829         * cp-abi.c: Use C++ exception handling.
6830         * corelow.c: Use C++ exception handling.
6831         * completer.c: Use C++ exception handling.
6832         * compile/compile-object-run.c: Use C++ exception handling.
6833         * compile/compile-object-load.c: Use C++ exception handling.
6834         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6835         * compile/compile-c-symbols.c: Use C++ exception handling.
6836         * common/selftest.c: Use C++ exception handling.
6837         * common/new-op.c: Use C++ exception handling.
6838         * cli/cli-script.c: Use C++ exception handling.
6839         * cli/cli-interp.c: Use C++ exception handling.
6840         * cli/cli-cmds.c: Use C++ exception handling.
6841         * c-varobj.c: Use C++ exception handling.
6842         * btrace.c: Use C++ exception handling.
6843         * breakpoint.c: Use C++ exception handling.
6844         * break-catch-throw.c: Use C++ exception handling.
6845         * arch-utils.c: Use C++ exception handling.
6846         * amd64-tdep.c: Use C++ exception handling.
6847         * ada-valprint.c: Use C++ exception handling.
6848         * ada-typeprint.c: Use C++ exception handling.
6849         * ada-lang.c: Use C++ exception handling.
6850         * aarch64-tdep.c: Use C++ exception handling.
6851
6852 2019-04-08  Tom Tromey  <tom@tromey.com>
6853
6854         * xml-support.c (gdb_xml_parser::parse): Update.
6855         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6856         * value.c (show_convenience): Update.
6857         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6858         (test_parse_flags_qcs): Update.
6859         * thread.c (thr_try_catch_cmd): Update.
6860         * target.c (target_translate_tls_address): Update.
6861         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6862         (info_frame_command_core, frame_apply_command_count): Update.
6863         * rust-exp.y (rust_lex_exception_test): Update.
6864         * riscv-tdep.c (riscv_print_one_register_info): Update.
6865         * remote.c (remote_target::enable_btrace): Update.
6866         * record-btrace.c (record_btrace_enable_warn): Update.
6867         * python/py-utils.c (gdbpy_convert_exception): Update.
6868         * printcmd.c (do_one_display, print_variable_and_value): Update.
6869         * mi/mi-main.c (mi_print_exception): Update.
6870         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6871         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6872         * linux-nat.c (linux_nat_target::attach): Update.
6873         * linux-fork.c (class scoped_switch_fork_info): Update.
6874         * infrun.c (displaced_step_prepare): Update.
6875         * infcall.c (call_function_by_hand_dummy): Update.
6876         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6877         * gnu-v3-abi.c (print_one_vtable): Update.
6878         * frame.c (get_prev_frame_always): Update.
6879         * f-valprint.c (info_common_command_for_block): Update.
6880         * exec.c (try_open_exec_file): Update.
6881         * exceptions.c (print_exception, exception_print)
6882         (exception_fprintf, exception_print_same): Update.
6883         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6884         * dwarf-index-cache.c (index_cache::store)
6885         (index_cache::lookup_gdb_index): Update.
6886         * darwin-nat.c (maybe_cache_shell): Update.
6887         * cp-valprint.c (cp_print_value_fields): Update.
6888         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6889         (gcc_cplus_symbol_address): Update.
6890         * compile/compile-c-symbols.c (gcc_convert_symbol)
6891         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6892         * common/selftest.c: Update.
6893         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6894         a std::string.
6895         (exception_try_scope_entry, exception_try_scope_exit): Don't
6896         declare.
6897         (struct exception_try_scope): Remove.
6898         (TRY): Don't use exception_try_scope.
6899         (struct gdb_exception): Add constructor, operator=.
6900         <what>: New method.
6901         (struct gdb_exception_RETURN_MASK_ALL)
6902         (struct gdb_exception_RETURN_MASK_ERROR)
6903         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6904         (struct gdb_quit_bad_alloc): Update.
6905         * common/common-exceptions.c (exception_none): Change
6906         initializer.
6907         (struct catcher) <state, exception>: Initialize inline.
6908         <prev>: Remove member.
6909         (current_catcher): Remove.
6910         (catchers): New global.
6911         (exceptions_state_mc_init): Simplify.
6912         (catcher_pop): Remove.
6913         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6914         (try_scope_depth, exception_try_scope_entry)
6915         (exception_try_scope_exit): Remove.
6916         (throw_exception_sjlj): Update.
6917         (exception_messages, exception_messages_size): Remove.
6918         (throw_it): Simplify.
6919         (gdb_exception_sliced_copy): Remove.
6920         (throw_exception_cxx): Update.
6921         * cli/cli-script.c (script_from_file): Update.
6922         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6923         Update.
6924         * ada-valprint.c (ada_val_print): Update.
6925         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6926         (create_excep_cond_exprs): Update.
6927
6928 2019-04-08  Tom Tromey  <tom@tromey.com>
6929
6930         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6931         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6932         (TRY, CATCH, END_CATCH): Remove some definitions.
6933         * common/common-exceptions.c: Don't use GDB_XCPT.
6934         (catcher_list_size): Remove.
6935         (throw_exception, throw_it): Simplify.
6936
6937 2019-04-05  Tom Tromey  <tom@tromey.com>
6938
6939         Revert the header-sorting patch.
6940         * ft32-tdep.c: Revert.
6941         * frv-tdep.c: Revert.
6942         * frv-linux-tdep.c: Revert.
6943         * frame.c: Revert.
6944         * frame-unwind.c: Revert.
6945         * frame-base.c: Revert.
6946         * fork-child.c: Revert.
6947         * findvar.c: Revert.
6948         * findcmd.c: Revert.
6949         * filesystem.c: Revert.
6950         * filename-seen-cache.h: Revert.
6951         * filename-seen-cache.c: Revert.
6952         * fbsd-tdep.c: Revert.
6953         * fbsd-nat.h: Revert.
6954         * fbsd-nat.c: Revert.
6955         * f-valprint.c: Revert.
6956         * f-typeprint.c: Revert.
6957         * f-lang.c: Revert.
6958         * extension.h: Revert.
6959         * extension.c: Revert.
6960         * extension-priv.h: Revert.
6961         * expprint.c: Revert.
6962         * exec.h: Revert.
6963         * exec.c: Revert.
6964         * exceptions.c: Revert.
6965         * event-top.c: Revert.
6966         * event-loop.c: Revert.
6967         * eval.c: Revert.
6968         * elfread.c: Revert.
6969         * dwarf2read.h: Revert.
6970         * dwarf2read.c: Revert.
6971         * dwarf2loc.c: Revert.
6972         * dwarf2expr.h: Revert.
6973         * dwarf2expr.c: Revert.
6974         * dwarf2-frame.c: Revert.
6975         * dwarf2-frame-tailcall.c: Revert.
6976         * dwarf-index-write.h: Revert.
6977         * dwarf-index-write.c: Revert.
6978         * dwarf-index-common.c: Revert.
6979         * dwarf-index-cache.h: Revert.
6980         * dwarf-index-cache.c: Revert.
6981         * dummy-frame.c: Revert.
6982         * dtrace-probe.c: Revert.
6983         * disasm.h: Revert.
6984         * disasm.c: Revert.
6985         * disasm-selftests.c: Revert.
6986         * dictionary.c: Revert.
6987         * dicos-tdep.c: Revert.
6988         * demangle.c: Revert.
6989         * dcache.h: Revert.
6990         * dcache.c: Revert.
6991         * darwin-nat.h: Revert.
6992         * darwin-nat.c: Revert.
6993         * darwin-nat-info.c: Revert.
6994         * d-valprint.c: Revert.
6995         * d-namespace.c: Revert.
6996         * d-lang.c: Revert.
6997         * ctf.c: Revert.
6998         * csky-tdep.c: Revert.
6999         * csky-linux-tdep.c: Revert.
7000         * cris-tdep.c: Revert.
7001         * cris-linux-tdep.c: Revert.
7002         * cp-valprint.c: Revert.
7003         * cp-support.c: Revert.
7004         * cp-namespace.c: Revert.
7005         * cp-abi.c: Revert.
7006         * corelow.c: Revert.
7007         * corefile.c: Revert.
7008         * continuations.c: Revert.
7009         * completer.h: Revert.
7010         * completer.c: Revert.
7011         * complaints.c: Revert.
7012         * coffread.c: Revert.
7013         * coff-pe-read.c: Revert.
7014         * cli-out.h: Revert.
7015         * cli-out.c: Revert.
7016         * charset.c: Revert.
7017         * c-varobj.c: Revert.
7018         * c-valprint.c: Revert.
7019         * c-typeprint.c: Revert.
7020         * c-lang.c: Revert.
7021         * buildsym.c: Revert.
7022         * buildsym-legacy.c: Revert.
7023         * build-id.h: Revert.
7024         * build-id.c: Revert.
7025         * btrace.c: Revert.
7026         * bsd-uthread.c: Revert.
7027         * breakpoint.h: Revert.
7028         * breakpoint.c: Revert.
7029         * break-catch-throw.c: Revert.
7030         * break-catch-syscall.c: Revert.
7031         * break-catch-sig.c: Revert.
7032         * blockframe.c: Revert.
7033         * block.c: Revert.
7034         * bfin-tdep.c: Revert.
7035         * bfin-linux-tdep.c: Revert.
7036         * bfd-target.c: Revert.
7037         * bcache.c: Revert.
7038         * ax-general.c: Revert.
7039         * ax-gdb.h: Revert.
7040         * ax-gdb.c: Revert.
7041         * avr-tdep.c: Revert.
7042         * auxv.c: Revert.
7043         * auto-load.c: Revert.
7044         * arm-wince-tdep.c: Revert.
7045         * arm-tdep.c: Revert.
7046         * arm-symbian-tdep.c: Revert.
7047         * arm-pikeos-tdep.c: Revert.
7048         * arm-obsd-tdep.c: Revert.
7049         * arm-nbsd-tdep.c: Revert.
7050         * arm-nbsd-nat.c: Revert.
7051         * arm-linux-tdep.c: Revert.
7052         * arm-linux-nat.c: Revert.
7053         * arm-fbsd-tdep.c: Revert.
7054         * arm-fbsd-nat.c: Revert.
7055         * arm-bsd-tdep.c: Revert.
7056         * arch-utils.c: Revert.
7057         * arc-tdep.c: Revert.
7058         * arc-newlib-tdep.c: Revert.
7059         * annotate.h: Revert.
7060         * annotate.c: Revert.
7061         * amd64-windows-tdep.c: Revert.
7062         * amd64-windows-nat.c: Revert.
7063         * amd64-tdep.c: Revert.
7064         * amd64-sol2-tdep.c: Revert.
7065         * amd64-obsd-tdep.c: Revert.
7066         * amd64-obsd-nat.c: Revert.
7067         * amd64-nbsd-tdep.c: Revert.
7068         * amd64-nbsd-nat.c: Revert.
7069         * amd64-nat.c: Revert.
7070         * amd64-linux-tdep.c: Revert.
7071         * amd64-linux-nat.c: Revert.
7072         * amd64-fbsd-tdep.c: Revert.
7073         * amd64-fbsd-nat.c: Revert.
7074         * amd64-dicos-tdep.c: Revert.
7075         * amd64-darwin-tdep.c: Revert.
7076         * amd64-bsd-nat.c: Revert.
7077         * alpha-tdep.c: Revert.
7078         * alpha-obsd-tdep.c: Revert.
7079         * alpha-nbsd-tdep.c: Revert.
7080         * alpha-mdebug-tdep.c: Revert.
7081         * alpha-linux-tdep.c: Revert.
7082         * alpha-linux-nat.c: Revert.
7083         * alpha-bsd-tdep.c: Revert.
7084         * alpha-bsd-nat.c: Revert.
7085         * aix-thread.c: Revert.
7086         * agent.c: Revert.
7087         * addrmap.c: Revert.
7088         * ada-varobj.c: Revert.
7089         * ada-valprint.c: Revert.
7090         * ada-typeprint.c: Revert.
7091         * ada-tasks.c: Revert.
7092         * ada-lang.c: Revert.
7093         * aarch64-tdep.c: Revert.
7094         * aarch64-ravenscar-thread.c: Revert.
7095         * aarch64-newlib-tdep.c: Revert.
7096         * aarch64-linux-tdep.c: Revert.
7097         * aarch64-linux-nat.c: Revert.
7098         * aarch64-fbsd-tdep.c: Revert.
7099         * aarch64-fbsd-nat.c: Revert.
7100         * aarch32-linux-nat.c: Revert.
7101
7102 2019-04-05  Tom Tromey  <tom@tromey.com>
7103
7104         * ft32-tdep.c: Sort headers.
7105         * frv-tdep.c: Sort headers.
7106         * frv-linux-tdep.c: Sort headers.
7107         * frame.c: Sort headers.
7108         * frame-unwind.c: Sort headers.
7109         * frame-base.c: Sort headers.
7110         * fork-child.c: Sort headers.
7111         * findvar.c: Sort headers.
7112         * findcmd.c: Sort headers.
7113         * filesystem.c: Sort headers.
7114         * filename-seen-cache.h: Sort headers.
7115         * filename-seen-cache.c: Sort headers.
7116         * fbsd-tdep.c: Sort headers.
7117         * fbsd-nat.h: Sort headers.
7118         * fbsd-nat.c: Sort headers.
7119         * f-valprint.c: Sort headers.
7120         * f-typeprint.c: Sort headers.
7121         * f-lang.c: Sort headers.
7122         * extension.h: Sort headers.
7123         * extension.c: Sort headers.
7124         * extension-priv.h: Sort headers.
7125         * expprint.c: Sort headers.
7126         * exec.h: Sort headers.
7127         * exec.c: Sort headers.
7128         * exceptions.c: Sort headers.
7129         * event-top.c: Sort headers.
7130         * event-loop.c: Sort headers.
7131         * eval.c: Sort headers.
7132         * elfread.c: Sort headers.
7133         * dwarf2read.h: Sort headers.
7134         * dwarf2read.c: Sort headers.
7135         * dwarf2loc.c: Sort headers.
7136         * dwarf2expr.h: Sort headers.
7137         * dwarf2expr.c: Sort headers.
7138         * dwarf2-frame.c: Sort headers.
7139         * dwarf2-frame-tailcall.c: Sort headers.
7140         * dwarf-index-write.h: Sort headers.
7141         * dwarf-index-write.c: Sort headers.
7142         * dwarf-index-common.c: Sort headers.
7143         * dwarf-index-cache.h: Sort headers.
7144         * dwarf-index-cache.c: Sort headers.
7145         * dummy-frame.c: Sort headers.
7146         * dtrace-probe.c: Sort headers.
7147         * disasm.h: Sort headers.
7148         * disasm.c: Sort headers.
7149         * disasm-selftests.c: Sort headers.
7150         * dictionary.c: Sort headers.
7151         * dicos-tdep.c: Sort headers.
7152         * demangle.c: Sort headers.
7153         * dcache.h: Sort headers.
7154         * dcache.c: Sort headers.
7155         * darwin-nat.h: Sort headers.
7156         * darwin-nat.c: Sort headers.
7157         * darwin-nat-info.c: Sort headers.
7158         * d-valprint.c: Sort headers.
7159         * d-namespace.c: Sort headers.
7160         * d-lang.c: Sort headers.
7161         * ctf.c: Sort headers.
7162         * csky-tdep.c: Sort headers.
7163         * csky-linux-tdep.c: Sort headers.
7164         * cris-tdep.c: Sort headers.
7165         * cris-linux-tdep.c: Sort headers.
7166         * cp-valprint.c: Sort headers.
7167         * cp-support.c: Sort headers.
7168         * cp-namespace.c: Sort headers.
7169         * cp-abi.c: Sort headers.
7170         * corelow.c: Sort headers.
7171         * corefile.c: Sort headers.
7172         * continuations.c: Sort headers.
7173         * completer.h: Sort headers.
7174         * completer.c: Sort headers.
7175         * complaints.c: Sort headers.
7176         * coffread.c: Sort headers.
7177         * coff-pe-read.c: Sort headers.
7178         * cli-out.h: Sort headers.
7179         * cli-out.c: Sort headers.
7180         * charset.c: Sort headers.
7181         * c-varobj.c: Sort headers.
7182         * c-valprint.c: Sort headers.
7183         * c-typeprint.c: Sort headers.
7184         * c-lang.c: Sort headers.
7185         * buildsym.c: Sort headers.
7186         * buildsym-legacy.c: Sort headers.
7187         * build-id.h: Sort headers.
7188         * build-id.c: Sort headers.
7189         * btrace.c: Sort headers.
7190         * bsd-uthread.c: Sort headers.
7191         * breakpoint.h: Sort headers.
7192         * breakpoint.c: Sort headers.
7193         * break-catch-throw.c: Sort headers.
7194         * break-catch-syscall.c: Sort headers.
7195         * break-catch-sig.c: Sort headers.
7196         * blockframe.c: Sort headers.
7197         * block.c: Sort headers.
7198         * bfin-tdep.c: Sort headers.
7199         * bfin-linux-tdep.c: Sort headers.
7200         * bfd-target.c: Sort headers.
7201         * bcache.c: Sort headers.
7202         * ax-general.c: Sort headers.
7203         * ax-gdb.h: Sort headers.
7204         * ax-gdb.c: Sort headers.
7205         * avr-tdep.c: Sort headers.
7206         * auxv.c: Sort headers.
7207         * auto-load.c: Sort headers.
7208         * arm-wince-tdep.c: Sort headers.
7209         * arm-tdep.c: Sort headers.
7210         * arm-symbian-tdep.c: Sort headers.
7211         * arm-pikeos-tdep.c: Sort headers.
7212         * arm-obsd-tdep.c: Sort headers.
7213         * arm-nbsd-tdep.c: Sort headers.
7214         * arm-nbsd-nat.c: Sort headers.
7215         * arm-linux-tdep.c: Sort headers.
7216         * arm-linux-nat.c: Sort headers.
7217         * arm-fbsd-tdep.c: Sort headers.
7218         * arm-fbsd-nat.c: Sort headers.
7219         * arm-bsd-tdep.c: Sort headers.
7220         * arch-utils.c: Sort headers.
7221         * arc-tdep.c: Sort headers.
7222         * arc-newlib-tdep.c: Sort headers.
7223         * annotate.h: Sort headers.
7224         * annotate.c: Sort headers.
7225         * amd64-windows-tdep.c: Sort headers.
7226         * amd64-windows-nat.c: Sort headers.
7227         * amd64-tdep.c: Sort headers.
7228         * amd64-sol2-tdep.c: Sort headers.
7229         * amd64-obsd-tdep.c: Sort headers.
7230         * amd64-obsd-nat.c: Sort headers.
7231         * amd64-nbsd-tdep.c: Sort headers.
7232         * amd64-nbsd-nat.c: Sort headers.
7233         * amd64-nat.c: Sort headers.
7234         * amd64-linux-tdep.c: Sort headers.
7235         * amd64-linux-nat.c: Sort headers.
7236         * amd64-fbsd-tdep.c: Sort headers.
7237         * amd64-fbsd-nat.c: Sort headers.
7238         * amd64-dicos-tdep.c: Sort headers.
7239         * amd64-darwin-tdep.c: Sort headers.
7240         * amd64-bsd-nat.c: Sort headers.
7241         * alpha-tdep.c: Sort headers.
7242         * alpha-obsd-tdep.c: Sort headers.
7243         * alpha-nbsd-tdep.c: Sort headers.
7244         * alpha-mdebug-tdep.c: Sort headers.
7245         * alpha-linux-tdep.c: Sort headers.
7246         * alpha-linux-nat.c: Sort headers.
7247         * alpha-bsd-tdep.c: Sort headers.
7248         * alpha-bsd-nat.c: Sort headers.
7249         * aix-thread.c: Sort headers.
7250         * agent.c: Sort headers.
7251         * addrmap.c: Sort headers.
7252         * ada-varobj.c: Sort headers.
7253         * ada-valprint.c: Sort headers.
7254         * ada-typeprint.c: Sort headers.
7255         * ada-tasks.c: Sort headers.
7256         * ada-lang.c: Sort headers.
7257         * aarch64-tdep.c: Sort headers.
7258         * aarch64-ravenscar-thread.c: Sort headers.
7259         * aarch64-newlib-tdep.c: Sort headers.
7260         * aarch64-linux-tdep.c: Sort headers.
7261         * aarch64-linux-nat.c: Sort headers.
7262         * aarch64-fbsd-tdep.c: Sort headers.
7263         * aarch64-fbsd-nat.c: Sort headers.
7264         * aarch32-linux-nat.c: Sort headers.
7265
7266 2019-04-04  Tom Tromey  <tom@tromey.com>
7267
7268         * varobj.c (varobj_create): Update.
7269         * rust-exp.y (struct rust_parser) <update_innermost_block,
7270         lookup_symbol>: New methods.
7271         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7272         Rename.
7273         (rust_parser::rust_lookup_type)
7274         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7275         * printcmd.c (display_command, do_one_display): Update.
7276         * parser-defs.h (struct parser_state) <parser_state>: Add
7277         "tracker" parameter.
7278         (block_tracker): New member.
7279         (class innermost_block_tracker) <innermost_block_tracker>: Add
7280         "types" parameter.
7281         <reset>: Remove method.
7282         (innermost_block): Don't declare.
7283         (null_post_parser): Update.
7284         * parse.c (innermost_block): Remove global.
7285         (write_dollar_variable): Update.
7286         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7287         Remove "tracker_types" parameter.
7288         (parse_expression): Add "tracker" parameter.
7289         (parse_expression_for_completion): Update.
7290         (null_post_parser): Add "tracker" parameter.
7291         * p-exp.y: Update rules.
7292         * m2-exp.y: Update rules.
7293         * language.h (struct language_defn) <la_post_parser>: Add
7294         "tracker" parameter.
7295         * go-exp.y: Update rules.
7296         * f-exp.y: Update rules.
7297         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7298         parameter.
7299         * d-exp.y: Update rules.
7300         * c-exp.y: Update rules.
7301         * breakpoint.c (set_breakpoint_condition): Create an
7302         innermost_block_tracker.
7303         (watch_command_1): Likewise.
7304         * ada-lang.c (resolve): Add "tracker" parameter.
7305         (resolve_subexp): Likewise.
7306         * ada-exp.y (write_var_from_sym): Update.
7307
7308 2019-04-04  Tom Tromey  <tom@tromey.com>
7309
7310         * type-stack.h: New file.
7311         * type-stack.c: New file.
7312         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7313         type-stack.h.
7314         (insert_into_type_stack, insert_type, push_type, push_type_int)
7315         (insert_type_address_space, pop_type, pop_type_int)
7316         (pop_typelist, pop_type_stack, append_type_stack)
7317         (push_type_stack, get_type_stack, push_typelist)
7318         (follow_type_instance_flags, follow_types): Don't declare.
7319         * parse.c (type_stack): Remove global.
7320         (parse_exp_in_context): Update.
7321         (insert_into_type_stack, insert_type, push_type, push_type_int)
7322         (insert_type_address_space, pop_type, pop_type_int)
7323         (pop_typelist, pop_type_stack, append_type_stack)
7324         (push_type_stack, get_type_stack, push_typelist)
7325         (follow_type_instance_flags, follow_types): Remove (moved to
7326         type-stack.c).
7327         * f-exp.y (type_stack): New global.
7328         Update rules.
7329         (push_kind_type, f_parse): Update.
7330         * d-exp.y (type_stack): New global.
7331         Update rules.
7332         (d_parse): Update.
7333         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7334         Update rules.
7335         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7336         (HFILES_NO_SRCDIR): Add type-stack.h.
7337
7338 2019-04-04  Tom Tromey  <tom@tromey.com>
7339
7340         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7341         (rust_parser::convert_ast_to_expression, rust_parse)
7342         (rust_lex_test_completion, rust_lex_tests): Update.
7343         * parser-defs.h (struct expr_completion_state): New.
7344         (struct parser_state) <parser_state>: Add completion parameter.
7345         <mark_struct_expression, mark_completion_tag>: New methods.
7346         <parse_completion, m_completion_state>: New members.
7347         (prefixify_expression, null_post_parser): Update.
7348         (mark_struct_expression, mark_completion_tag): Don't declare.
7349         * parse.c (parse_completion, expout_last_struct)
7350         (expout_tag_completion_type, expout_completion_name): Remove
7351         globals.
7352         (parser_state::mark_struct_expression)
7353         (parser_state::mark_completion_tag): Now methods.
7354         (prefixify_expression): Add last_struct parameter.
7355         (prefixify_subexp): Likewise.
7356         (parse_exp_1): Update.
7357         (parse_exp_in_context): Add cstate parameter.  Update.
7358         (parse_expression_for_completion): Create an
7359         expr_completion_state.
7360         (null_post_parser): Add "completion" parameter.
7361         * p-exp.y: Update rules.
7362         (yylex): Update.
7363         * language.h (struct language_defn) <la_post_parser>: Add
7364         "completing" parameter.
7365         * go-exp.y: Update rules.
7366         (lex_one_token): Update.
7367         * expression.h (parse_completion): Don't declare.
7368         * d-exp.y: Update rules.
7369         (lex_one_token): Update rules.
7370         * c-exp.y: Update rules.
7371         (lex_one_token): Update.
7372         * ada-lang.c (resolve): Add "parse_completion" parameter.
7373         (resolve_subexp): Likewise.
7374         (ada_resolve_function): Likewise.
7375
7376 2019-04-04  Tom Tromey  <tom@tromey.com>
7377
7378         * parser-defs.h (struct parser_state) <start_arglist,
7379         end_arglist>: New methods.
7380         <arglist_len, m_funcall_chain>: New members.
7381         (arglist_len, start_arglist, end_arglist): Don't declare.
7382         * parse.c (arglist_len, funcall_chain): Remove global.
7383         (start_arglist, end_arglist): Remove functions.
7384         (parse_exp_in_context): Update.
7385         * p-exp.y: Update rules.
7386         * m2-exp.y: Update rules.
7387         * go-exp.y: Update rules.
7388         * f-exp.y: Update rules.
7389         * d-exp.y: Update rules.
7390         * c-exp.y: Update rules.
7391
7392 2019-04-04  Tom Tromey  <tom@tromey.com>
7393
7394         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7395         lex_operator, push_back>: New methods.
7396         Update all rules.
7397         (rust_parser::lex_hex, lex_escape): Rename and update.
7398         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7399         (rust_parser::lex_operator): Rename and update.
7400         (rust_parser::lex_number, rustyylex, rustyyerror)
7401         (rust_lex_test_init, rust_lex_test_sequence)
7402         (rust_lex_test_push_back, rust_lex_tests): Update.
7403         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7404         parameter.
7405         <lexptr, prev_lexptr>: New members.
7406         (lexptr, prev_lexptr): Don't declare.
7407         * parse.c (lexptr, prev_lexptr): Remove globals.
7408         (parse_exp_in_context): Update.
7409         * p-exp.y (yylex, yyerror): Update.
7410         * m2-exp.y (parse_number, yylex, yyerror): Update.
7411         * go-exp.y (lex_one_token, yyerror): Update.
7412         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7413         * d-exp.y (lex_one_token, yyerror): Update.
7414         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7415         (lex_one_token, yyerror): Update.
7416         * ada-lex.l (YY_INPUT): Update.
7417         (rewind_to_char): Update.
7418         * ada-exp.y (yyerror): Update.
7419
7420 2019-04-04  Tom Tromey  <tom@tromey.com>
7421
7422         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7423         * parser-defs.h (struct parser_state) <parser_state>: Add new
7424         parameter.
7425         <comma_terminates>: New member.
7426         (comma_terminates): Don't declare global.
7427         * parse.c (comma_terminates): Remove global.
7428         (parse_exp_in_context): Update.
7429         * p-exp.y (yylex): Update.
7430         * m2-exp.y (yylex): Update.
7431         * go-exp.y (lex_one_token): Update.
7432         * f-exp.y (yylex): Update.
7433         * d-exp.y (lex_one_token): Update.
7434         * c-exp.y (lex_one_token): Update.
7435         * ada-lex.l: Update.
7436
7437 2019-04-04  Tom Tromey  <tom@tromey.com>
7438
7439         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7440         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7441         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7442         * parser-defs.h (paren_depth): Don't declare.
7443         * parse.c (paren_depth): Remove global.
7444         (parse_exp_in_context): Update.
7445         * p-exp.y (paren_depth): New global.
7446         (pascal_parse): Initialize it.
7447         * m2-exp.y (paren_depth): New global.
7448         (m2_parse): Initialize it.
7449         * go-exp.y (paren_depth): New global.
7450         (go_parse): Initialize it.
7451         * f-exp.y (paren_depth): New global.
7452         (f_parse): Initialize it.
7453         * d-exp.y (paren_depth): New global.
7454         (d_parse): Initialize it.
7455         * c-exp.y (paren_depth): New global.
7456         (c_parse): Initialize it.
7457         * ada-lex.l (paren_depth): New global.
7458         (lexer_init): Initialize it.
7459
7460 2019-04-04  Tom Tromey  <tom@tromey.com>
7461
7462         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7463         (rust_parser::convert_ast_to_type)
7464         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7465         * parser-defs.h (struct parser_state) <parser_state>: Add
7466         parameters.  Initialize new members.
7467         <expression_context_block, expression_context_pc>: New members.
7468         * parse.c (expression_context_block, expression_context_pc):
7469         Remove globals.
7470         (parse_exp_in_context): Update.
7471         * p-exp.y: Update all rules.
7472         (yylex): Update.
7473         * m2-exp.y: Update all rules.
7474         (yylex): Update.
7475         * go-exp.y (yylex): Update.
7476         * f-exp.y (yylex): Update.
7477         * d-exp.y: Update all rules.
7478         (yylex): Update.
7479         * c-exp.y: Update all rules.
7480         (lex_one_token, classify_name, yylex, c_parse): Update.
7481         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7482
7483 2019-04-04  Tom Tromey  <tom@tromey.com>
7484
7485         * gdbarch.h, gdbarch.c: Rebuild.
7486         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7487         * stap-probe.h:
7488         (struct stap_parse_info): Replace "parser_state" with
7489         "expr_builder".
7490         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7491         (parser_state): New class.
7492         * parse.c (expr_builder): Rename.
7493         (expr_builder::release): Rename.
7494         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7495         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7496         (write_exp_elt_longcst, write_exp_elt_floatcst)
7497         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7498         (write_exp_string_vector, write_exp_bitstring)
7499         (write_exp_msymbol, mark_struct_expression)
7500         (write_dollar_variable)
7501         (insert_type_address_space, increase_expout_size): Replace
7502         "parser_state" with "expr_builder".
7503         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7504         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7505         "parser_state" with "expr_builder".
7506
7507 2019-04-04  Tom Tromey  <tom@tromey.com>
7508
7509         * rust-exp.y: Replace "parse_language" with method call.
7510         * p-exp.y:
7511         (yylex): Replace "parse_language" with method call.
7512         * m2-exp.y:
7513         (yylex): Replace "parse_language" with method call.
7514         * go-exp.y (classify_name): Replace "parse_language" with method
7515         call.
7516         * f-exp.y (yylex): Replace "parse_language" with method call.
7517         * d-exp.y (lex_one_token): Replace "parse_language" with method
7518         call.
7519         * c-exp.y:
7520         (lex_one_token, classify_name, yylex): Replace "parse_language"
7521         with method call.
7522         * ada-exp.y (find_primitive_type, type_char)
7523         (type_system_address): Replace "parse_language" with method call.
7524
7525 2019-04-04  Tom Tromey  <tom@tromey.com>
7526
7527         * rust-exp.y: Replace "parse_gdbarch" with method call.
7528         * parse.c (write_dollar_variable, insert_type_address_space):
7529         Replace "parse_gdbarch" with method call.
7530         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7531         call.
7532         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7533         call.
7534         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7535         "parse_gdbarch" with method call.
7536         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7537         with method call.
7538         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7539         "parse_gdbarch" with method call.
7540         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7541         "parse_gdbarch" with method call.
7542         * c-exp.y (parse_type, parse_number, classify_name): Replace
7543         "parse_gdbarch" with method call.
7544         * ada-lex.l: Replace "parse_gdbarch" with method call.
7545         * ada-exp.y (parse_type, find_primitive_type, type_char)
7546         (type_system_address): Replace "parse_gdbarch" with method call.
7547
7548 2019-04-04  Tom Tromey  <tom@tromey.com>
7549
7550         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7551         * stap-probe.c (stap_parse_argument): Update.
7552         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7553         initial_size parameter.
7554         * rust-exp.y (rust_lex_tests): Update.
7555         * parse.c (parser_state): Update.
7556         (parse_exp_in_context): Update.
7557         * parser-defs.h (struct parser_state) <parser_state>: Remove
7558         "initial_size" parameter.
7559
7560 2019-04-04  Tom Tromey  <tom@tromey.com>
7561
7562         * parser-defs.h (increase_expout_size): Don't declare.
7563         * parse.c (increase_expout_size): Now static.
7564
7565 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7566
7567         * gnu-nat.c (gnu_nat_target::wait): Fix
7568         target_waitstatus_to_string call.
7569
7570 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7571
7572         * eval.c (evaluate_subexp_standard): Handle internal functions
7573         during Fortran function call handling.
7574
7575 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7576
7577         * NEWS: Mention new internal functions.
7578         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7579         (read_base_type): Use dwarf2_init_complex_target_type.
7580         * value.c (creal_internal_fn): New function.
7581         (cimag_internal_fn): New function.
7582         (_initialize_values): Register new internal functions.
7583
7584 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7585
7586         * infrun.c (stop_all_threads): If debug_infrun, always
7587         trace the wait status after wait_one, using
7588         target_waitstatus_to_string and target_pid_to_str.
7589         (handle_inferior_event): Replace various trace of
7590         wait status kind by a single trace.
7591         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7592         wait status kind image by target_waitstatus_to_string.
7593         * target/waitstatus.c (target_waitstatus_to_string): Fix
7594         obsolete comment.
7595
7596 2019-04-01  Tom Tromey  <tromey@adacore.com>
7597
7598         PR symtab/23331:
7599         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7600
7601 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7602             Pedro Alves  <palves@redhat.com>
7603
7604         * top.c (quit_force): Call 'finalize_values'.
7605         * value.c (finalize_values): New function.
7606         * value.h (finalize_values): Declare.
7607
7608 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7609
7610         * NEWS: Announce $_gdb_major and $_gdb_minor.
7611
7612         * top.c (init_gdb_version_vars): New function.
7613         (gdb_init): Call init_gdb_version_vars.
7614
7615 2019-03-29  Tom Tromey  <tromey@adacore.com>
7616
7617         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7618         help text.  Remove dead code.
7619
7620 2019-03-29  Keith Seitz  <keiths@redhat.com>
7621
7622         From Siddhesh Poyarekar:
7623         * f-lang.h (f77_get_upperbound): Return LONGEST.
7624         (f77_get_lowerbound): Likewise.
7625         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7626         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7627         print them.
7628         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7629         plongest to format print it.
7630         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7631         (f77_get_upperbound): Likewise.
7632         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7633         LOWER_BOUND to LONGEST.
7634         (f77_create_arrayprint_offset_tbl): Likewise.
7635
7636 2019-03-29  Keith Seitz  <keiths@redhat.com>
7637
7638         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7639         %s/pulongest for TYPE_LENGTH instead of %d in format
7640         strings.
7641         * ada-typerint.c (ada_print_type): Likewise.
7642         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7643         * compile/compile-c-support.c (generate_register_struct): Likewise.
7644         * gdbtypes.c (recursive_dump_type): Likewise.
7645         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7646         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7647         instead of %d in format strings.
7648         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7649         to std::min to ULONGEST.
7650         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7651         instead of %d in format strings.
7652         * tracepoint.c (info_scope_command): Likewise.
7653         * typeprint.c (print_offset_data::update)
7654         (print_offset_data::finish): Likewise.
7655         * xtensa-tdep.c (xtensa_store_return_value)
7656         (xtensa_push_dummy_call): Likewise.
7657
7658 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7659
7660         * windows-nat.c (display_selector): Fixed format specifications
7661         for 64-bit Cygwin.
7662
7663 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7664
7665         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7666
7667 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7668
7669         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7670         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7671         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7672         (nios2_linux_init_abi): Install it.
7673
7674 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7675
7676         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7677
7678 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7679
7680         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7681
7682 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7683             Tom Tromey  <tromey@adacore.com>
7684
7685         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7686
7687 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7688
7689         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7690         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7691         method to compute the bounds of range types. Also print "[evaluated]"
7692         if the bounds' values come from a dynamic evaluation.
7693
7694 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7695
7696         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7697         whitespace when pretty printing is on.
7698
7699 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7700
7701         * ppc-linux-nat.c: Add include.
7702
7703 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7704
7705         * NEWS: Mention AArch64 Pointer Authentication.
7706
7707 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7708
7709         * arm-linux-nat.c: Add include.
7710
7711 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7712
7713         * source-cache.c (source_cache::get_source_lines): Re-read
7714         fullname after calling open_source_file.
7715
7716 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7717
7718         * NEWS: Mention TLS support for FreeBSD.
7719
7720 2019-03-25  Tom Tromey  <tromey@adacore.com>
7721
7722         * minsyms.c (BUNCH_SIZE): Update comment.
7723         (~minimal_symbol_reader): Remove old comment.
7724         (compact_minimal_symbols): Update comment.
7725         (minimal_symbol_reader::install): Remove old comment.  Update
7726         other comments.
7727
7728 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7729
7730         * s390-linux-nat.c: Add include.
7731
7732 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7733
7734         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7735         Call linux_get_hwcap.
7736         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7737         Likewise.
7738         (aarch64_linux_get_hwcap): Remove function.
7739         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7740         declaration.
7741         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7742         linux_get_hwcap.
7743         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7744         * linux-tdep.c (linux_get_hwcap): Add function.
7745         (linux_get_hwcap2): Likewise.
7746         * linux-tdep.h (linux_get_hwcap): Add declaration.
7747         (linux_get_hwcap2): Likewise.
7748         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7749         (ppc_linux_get_hwcap2): Likewise.
7750         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7751         linux_get_hwcap.
7752         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7753         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7754         (ppc_linux_nat_target::read_description): Likewise.
7755         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7756         * s390-linux-nat.c: Likewise.
7757         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7758
7759 2019-03-24  Tom Tromey  <tom@tromey.com>
7760
7761         * ada-lang.c (standard_lookup): Simplify initialization.
7762         (ada_lookup_symbol_nonlocal): Simplify return.
7763         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7764         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7765         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7766         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7767         initialization.
7768         * solib.c (solib_global_lookup): Simplify.
7769         * symtab.c (null_block_symbol): Remove.
7770         (symbol_cache_lookup): Simplify returns.
7771         (lookup_language_this): Simplify returns.
7772         (lookup_symbol_aux): Simplify return.
7773         (lookup_local_symbol): Simplify returns.
7774         (lookup_global_symbol_from_objfile): Simplify return.
7775         (lookup_symbol_in_objfile_symtabs)
7776         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7777         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7778         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7779         * cp-namespace.c (cp_lookup_bare_symbol)
7780         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7781         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7782         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7783         (cp_lookup_symbol_via_imports): Simplify initialization.
7784         (find_symbol_in_baseclass): Likewise.
7785         * symtab.h (null_block_symbol): Remove.
7786         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7787         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7788         (d_lookup_symbol_module): Likewise.
7789         (find_symbol_in_baseclass): Simplify initialization.
7790
7791 2019-03-24  Tom Tromey  <tom@tromey.com>
7792
7793         * expression.h: Don't include symtab.h.
7794         (struct block): Forward declare.
7795
7796 2019-03-24  Tom Tromey  <tom@tromey.com>
7797
7798         * c-exp.y (typebase): Remove casts.
7799         * gdbtypes.c (lookup_unsigned_typename, )
7800         (lookup_signed_typename): Remove cast.
7801         * eval.c (parse_to_comma_and_eval): Remove cast.
7802         * parse.c (write_dollar_variable): Remove cast.
7803         * block.h (struct block) <superblock>: Now const.
7804         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7805         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7806         (map_block): Make "block" const.
7807         * symfile.h (struct quick_symbol_functions)
7808         <map_matching_symbols>: Constify block argument to "callback".
7809         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7810         const.
7811         (find_pc_sect_compunit_symtab): Make "b" const.
7812         (find_symbol_at_address): Likewise.
7813         (search_symbols): Likewise.
7814         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7815         (dw2_debug_names_lookup_symbol): Likewise.
7816         (dw2_map_matching_symbols): Update.
7817         * p-valprint.c (pascal_val_print): Remove "block".
7818         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7819         (aux_add_nonlocal_symbols): Make "block" const.
7820         (resolve_subexp): Remove cast.
7821         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7822         const.
7823         (iterate_over_file_blocks): Likewise.
7824         * f-exp.y (%union) <bval>: Remove.
7825         * coffread.c (patch_opaque_types): Make "b" const.
7826         * spu-tdep.c (spu_catch_start): Make "block" const.
7827         * c-valprint.c (print_unpacked_pointer): Remove "block".
7828         * symmisc.c (dump_symtab_1): Make "b" const.
7829         (block_depth): Make "block" const.
7830         * d-exp.y (%union) <bval>: Remove.
7831         * cp-support.h (cp_lookup_rtti_type): Update.
7832         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7833         * psymtab.c (psym_lookup_symbol): Make "block" const.
7834         (maintenance_check_psymtabs): Make "b" const.
7835         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7836         (enumerate_locals, enumerate_args): Update.
7837         * python/py-symtab.c (stpy_global_block): Make "block" const.
7838         (stpy_static_block): Likewise.
7839         * inline-frame.c (block_starting_point_at): Make "new_block"
7840         const.
7841         * block.c (find_block_in_blockvector): Make return type const.
7842         (blockvector_for_pc_sect): Make "b" const.
7843         (find_block_in_blockvector): Make "b" const.
7844
7845 2019-03-23  Tom Tromey  <tom@tromey.com>
7846
7847         * varobj.c (varobj_create): Update.
7848         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7849         * printcmd.c (display_command, do_one_display): Don't reset
7850         innermost_block.
7851         * parser-defs.h (enum innermost_block_tracker_type): Move to
7852         expression.h.
7853         (innermost_block): Update comment.
7854         * parse.c (parse_exp_1): Add tracker_types parameter.
7855         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7856         tracker_types parameter.  Reset innermost_block.
7857         (parse_exp_in_context): Remove.
7858         (parse_expression_for_completion): Update.
7859         * objfiles.c (~objfile): Don't reset expression_context_block or
7860         innermost_block.
7861         * expression.h (enum innermost_block_tracker_type): Move from
7862         parser-defs.h.
7863         (parse_exp_1): Add tracker_types parameter.
7864         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7865         reset innermost_block.
7866
7867 2019-03-23  Tom Tromey  <tom@tromey.com>
7868
7869         * objfiles.h: Include bcache.h.
7870
7871 2019-03-23  Tom Tromey  <tom@tromey.com>
7872
7873         * linespec.c (get_current_search_block): Use
7874         scoped_restore_current_language.
7875         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7876
7877 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7878             Jiong Wang  <jiong.wang@arm.com>
7879
7880         * aarch64-linux-tdep.c
7881         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7882         section.
7883         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7884
7885 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7886             Jiong Wang  <jiong.wang@arm.com>
7887
7888         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7889         instructions.
7890         (aarch64_analyze_prologue_test): Add PACIASP test.
7891         (aarch64_prologue_prev_register): Unmask PC value.
7892
7893 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7894             Jiong Wang  <jiong.wang@arm.com>
7895
7896         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7897         (aarch64_dwarf2_prev_register): Unmask PC value.
7898         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7899         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7900         DW_CFA_AARCH64_negate_ra_state.
7901         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7902
7903 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7904             Jiong Wang  <jiong.wang@arm.com>
7905
7906         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7907         registers.
7908         (aarch64_pseudo_register_name): Likewise.
7909         (aarch64_pseudo_register_type): Likewise.
7910         (aarch64_pseudo_register_reggroup_p): Likewise.
7911         (aarch64_gdbarch_init): Add pauth registers.
7912         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7913         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7914         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7915         (struct gdbarch_tdep): Add regnum for ra_state.
7916
7917 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7918             Jiong Wang  <jiong.wang@arm.com>
7919
7920         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7921
7922 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7923             Jiong Wang  <jiong.wang@arm.com>
7924
7925         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7926         function.
7927         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7928         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7929         (aarch64_gdbarch_init): Add puth registers.
7930         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7931         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7932         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7933
7934 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7935             Jiong Wang  <jiong.wang@arm.com>
7936
7937         * aarch64-linux-nat.c
7938         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7939         * aarch64-linux-tdep.c
7940         (aarch64_linux_core_read_description): Likewise.
7941         (aarch64_linux_get_hwcap): New function.
7942         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7943         (aarch64_linux_get_hwcap): New declaration.
7944
7945 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7946             Jiong Wang  <jiong.wang@arm.com>
7947
7948         * aarch64-linux-nat.c
7949         (aarch64_linux_nat_target::read_description): Add pauth param.
7950         * aarch64-linux-tdep.c
7951         (aarch64_linux_core_read_description): Likewise.
7952         * aarch64-tdep.c (struct target_desc): Add in pauth.
7953         (aarch64_read_description): Add pauth param.
7954         (aarch64_gdbarch_init): Likewise.
7955         * aarch64-tdep.h (aarch64_read_description): Likewise.
7956         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7957         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7958         * features/Makefile: Add new files.
7959         * features/aarch64-pauth.c: New file.
7960         * features/aarch64-pauth.xml: New file.
7961
7962 2019-03-20  Tom Tromey  <tromey@adacore.com>
7963
7964         * infrun.c (handle_inferior_event): Rename from
7965         handle_inferior_event_1.  Create a scoped_value_mark.
7966         (handle_inferior_event): Remove.
7967
7968 2019-03-19  Tom Tromey  <tromey@adacore.com>
7969
7970         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7971         * infrun.h (print_stop_event): Add "displays" parameter.
7972         * infrun.c (print_stop_event): Add "displays" parameter.
7973
7974 2019-03-19  Pedro Alves  <palves@redhat.com>
7975
7976         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7977         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7978         to -1.  Fix TABs vs spaces.
7979         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7980         * tui/tui-out.h (tui_ui_out) Add intro comments.
7981         <m_line, m_start_of_line>: In-class initialize, and add describing
7982         comment.
7983
7984 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7985
7986         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7987         variable names.
7988         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7989
7990 2019-03-18  Pedro Alves  <palves@redhat.com>
7991             Eli Zaretskii <eliz@gnu.org>
7992
7993         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7994         m_line and m_start_of_line.
7995
7996 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7997
7998         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7999         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8000         it returns a newline.  This fixes a regression in TU mode, whereby
8001         the next line is output on the same screen line as the user input.
8002
8003 2019-03-18  Tom Tromey  <tromey@adacore.com>
8004
8005         * minsyms.c (minimal_symbol_reader::install): Remove call to
8006         obstack_blank.
8007
8008 2019-03-18  Pedro Alves  <palves@redhat.com>
8009
8010         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8011         New globals.
8012         (apply_style): New, factored out from ...
8013         (apply_ansi_escape): ... this.  Handle reverse video mode.
8014         (tui_set_reverse_mode): New function.
8015         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8016         * tui/tui-winsource.c (tui_show_source_line): Use
8017         tui_set_reverse_mode instead of setting A_STANDOUT.
8018         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8019         New setter methods.
8020
8021 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8022
8023         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8024         Handle tabs.
8025
8026 2019-03-18  Tom Tromey  <tromey@adacore.com>
8027
8028         * ada-lang.c (empty_array): Add "high" parameter.
8029         (ada_evaluate_subexp): Update.
8030
8031 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8032
8033         * unittests/string_view-selftests.c: Define
8034         _initialize_string_view_selftests unconditionally.
8035
8036 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8037
8038         PR gdb/24350
8039         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8040
8041 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8042
8043         PR gdb/24351
8044         * windows-nat.c (display_selector): Fix format specifiers.
8045
8046 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8047
8048         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8049         tui_refill_source_window instead of tui_refresh_win, to update the
8050         current execution line.  This fixes redisplay of the current line
8051         when stepping through the code with "next" or "step".
8052
8053 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8054
8055         * source-cache.c (source_cache::get_source_lines): Call
8056         find_source_lines to initialize s->nlines.  This fixes vertical
8057         scrolling of TUI source window when the DOWN arrow is pressed.
8058
8059 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8060
8061         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8062         linux-thread-db.c (_initialize_thread_db): Likewise.
8063
8064 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8065
8066         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8067         wclrtoeol in tui_show_source_line".  This reverts changes made in
8068         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8069
8070 2019-03-15  Tom Tromey  <tom@tromey.com>
8071
8072         * symtab.h (struct minimal_symbol): Derive from
8073         general_symbol_info.
8074         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8075         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8076         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8077         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8078         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8079         (MSYMBOL_SEARCH_NAME): Update.
8080         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8081         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8082         * minsyms.c (minimal_symbol_reader::record_full): Update.
8083
8084 2019-03-15  Tom Tromey  <tom@tromey.com>
8085
8086         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8087
8088 2019-03-15  Tom Tromey  <tom@tromey.com>
8089
8090         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8091         unique_xmalloc_ptr.
8092         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8093         Update.
8094         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8095         (build_minimal_symbol_hash_tables)
8096         (minimal_symbol_reader::install): Update.
8097
8098 2019-03-15  Tom Tromey  <tom@tromey.com>
8099
8100         * symtab.c (create_demangled_names_hash): Update.
8101         (symbol_set_names): Update.
8102         * objfiles.h (struct objfile_per_bfd_storage)
8103         <demangled_names_hash>: Now an htab_up.
8104         * objfiles.c (objfile_per_bfd_storage): Simplify.
8105
8106 2019-03-15  Tom Tromey  <tom@tromey.com>
8107
8108         * objfiles.h (struct objfile_per_bfd_storage): Declare
8109         destructor.
8110         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8111         New.
8112         (get_objfile_bfd_data): Use new.  Don't initialize
8113         language_of_main.
8114         (free_objfile_per_bfd_storage): Remove.
8115         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8116
8117 2019-03-15  Tom Tromey  <tom@tromey.com>
8118
8119         * symfile.c (reread_symbols): Update.
8120         * objfiles.c (objfile::objfile): Update.
8121         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8122         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8123         comment.
8124         (minimal_symbol_reader::install): Update.
8125         (terminate_minimal_symbol_table): Remove.
8126         * jit.c (jit_object_close_impl): Update.
8127
8128 2019-03-15  Tom Tromey  <tom@tromey.com>
8129
8130         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8131         initializations.
8132
8133 2019-03-15  Tom Tromey  <tom@tromey.com>
8134
8135         * objfiles.h (struct objfile_per_bfd_storage)
8136         <demangled_hash_languages>: Now a bitset.
8137         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8138         (lookup_minimal_symbol): Update.
8139
8140 2019-03-15  Tom Tromey  <tom@tromey.com>
8141
8142         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8143         Don't return the symbol.
8144         * coffread.c (record_minimal_symbol): Use record_full.
8145
8146 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8147
8148         The MS-Windows port of ncurses fails to switch to a color pair if
8149         one or both of the colors are the implicit default colors.  This
8150         change records the default colors when TUI is initialized, and
8151         then specifies them explicitly when a color pair uses the default
8152         colors.  This allows color styling in TUI mode on MS-Windows.
8153
8154         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8155         ncurses_norm_attr.
8156         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8157         colors in ncurses_norm_attr.
8158         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8159         "none", replace it with the default color recorded in
8160         ncurses_norm_attr.
8161
8162 2019-03-14  Tom Tromey  <tromey@adacore.com>
8163
8164         * source-cache.h (class source_cache) <get_source_lines>: Return
8165         std::string.
8166         * source-cache.c (source_cache::extract_lines): Handle case where
8167         first_pos==npos.  Return std::string.
8168         (source_cache::get_source_lines): Update.
8169
8170 2019-03-14  Tom Tromey  <tromey@adacore.com>
8171
8172         * NEWS: Add item for "style sources" commands.
8173         * source-cache.c (source_cache::get_source_lines): Check
8174         source_styling.
8175         * cli/cli-style.c (source_styling): New global.
8176         (_initialize_cli_style): Add "style sources" commands.
8177         (show_style_sources): New function.
8178         * cli/cli-style.h (source_styling): Declare.
8179
8180 2019-03-14  Pedro Alves  <palves@redhat.com>
8181             Tom Tromey  <tromey@adacore.com>
8182
8183         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8184         * tui/tui-winsource.c (tui_refill_source_window): New function,
8185         from...
8186         (tui_horizontal_source_scroll): ... here.  Move some logic.
8187         * cli/cli-style.c (set_style_enabled): Notify new observable.
8188         * tui/tui-hooks.c (tui_redisplay_source): New function.
8189         (tui_attach_detach_observers): Attach or detach
8190         tui_redisplay_source.
8191         * observable.h (source_styling_changed): New observable.
8192         * observable.c: Define source_styling_changed observable.
8193
8194 2019-03-13  Tom Tromey  <tromey@adacore.com>
8195
8196         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8197         (i386_gnu_nat_target::store_registers): Update.
8198         * target-debug.h (target_debug_print_std_string): New macro.
8199         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8200         * windows-tdep.c (display_one_tib): Update.
8201         * tui/tui-stack.c (tui_make_status_line): Update.
8202         * top.c (print_inferior_quit_action): Update.
8203         * thread.c (thr_try_catch_cmd): Update.
8204         (add_thread_with_info): Update.
8205         (thread_target_id_str): Update.
8206         (thr_try_catch_cmd): Update.
8207         (thread_command): Update.
8208         (thread_find_command): Update.
8209         * record-btrace.c (record_btrace_target::info_record)
8210         (record_btrace_resume_thread, record_btrace_target::resume)
8211         (record_btrace_cancel_resume, record_btrace_step_thread)
8212         (record_btrace_target::wait, record_btrace_target::wait)
8213         (record_btrace_target::wait, record_btrace_target::stop): Update.
8214         * progspace.c (print_program_space): Update.
8215         * process-stratum-target.c
8216         (process_stratum_target::thread_address_space): Update.
8217         * linux-fork.c (linux_fork_mourn_inferior)
8218         (detach_checkpoint_command, info_checkpoints_command)
8219         (linux_fork_context): Update.
8220         (linux_fork_detach): Update.
8221         (class scoped_switch_fork_info): Update.
8222         (delete_checkpoint_command): Update.
8223         * infrun.c (follow_fork_inferior): Update.
8224         (follow_fork_inferior): Update.
8225         (proceed_after_vfork_done): Update.
8226         (handle_vfork_child_exec_or_exit): Update.
8227         (follow_exec): Update.
8228         (displaced_step_prepare_throw): Update.
8229         (displaced_step_restore): Update.
8230         (start_step_over): Update.
8231         (resume_1): Update.
8232         (clear_proceed_status_thread): Update.
8233         (proceed): Update.
8234         (print_target_wait_results): Update.
8235         (do_target_wait): Update.
8236         (context_switch): Update.
8237         (stop_all_threads): Update.
8238         (restart_threads): Update.
8239         (finish_step_over): Update.
8240         (handle_signal_stop): Update.
8241         (switch_back_to_stepped_thread): Update.
8242         (keep_going_pass_signal): Update.
8243         (print_exited_reason): Update.
8244         (normal_stop): Update.
8245         * inferior.c (inferior_pid_to_str): Change return type.
8246         (print_selected_inferior): Update.
8247         (add_inferior): Update.
8248         (detach_inferior): Update.
8249         * dummy-frame.c (fprint_dummy_frames): Update.
8250         * dcache.c (dcache_info_1): Update.
8251         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8252         (btrace_fetch, btrace_clear): Update.
8253         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8254         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8255         type.
8256         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8257         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8258         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8259         * gdbarch.c, gdbarch.h: Rebuild.
8260         * gdbarch.sh (core_pid_to_str): Change return type.
8261         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8262         return type.
8263         (windows_nat_target::pid_to_str): Change return type.
8264         (windows_delete_thread): Update.
8265         (windows_nat_target::attach): Update.
8266         (windows_nat_target::files_info): Update.
8267         * target-delegates.c: Rebuild.
8268         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8269         return type.
8270         (sol_thread_target::pid_to_str): Change return type.
8271         * remote.c (class remote_target) <pid_to_str>: Change return
8272         type.
8273         (remote_target::pid_to_str): Change return type.
8274         (extended_remote_target::attach, remote_target::remote_stop_ns)
8275         (remote_target::remote_notif_remove_queued_reply)
8276         (remote_target::push_stop_reply, remote_target::disable_btrace):
8277         Update.
8278         (extended_remote_target::attach): Update.
8279         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8280         type.
8281         (gdbsim_target::pid_to_str): Change return type.
8282         * ravenscar-thread.c (struct ravenscar_thread_target)
8283         <pid_to_str>: Change return type.
8284         (ravenscar_thread_target::pid_to_str): Change return type.
8285         * procfs.c (class procfs_target) <pid_to_str>: Change return
8286         type.
8287         (procfs_target::pid_to_str): Change return type.
8288         (procfs_target::attach): Update.
8289         (procfs_target::detach): Update.
8290         (procfs_target::fetch_registers): Update.
8291         (procfs_target::store_registers): Update.
8292         (procfs_target::wait): Update.
8293         (procfs_target::files_info): Update.
8294         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8295         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8296         return type.
8297         (nto_procfs_target::pid_to_str): Change return type.
8298         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8299         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8300         return type.
8301         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8302         (exit_lwp): Update.
8303         (attach_proc_task_lwp_callback, get_detach_signal)
8304         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8305         (linux_nat_target::resume, wait_lwp, stop_callback)
8306         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8307         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8308         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8309         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8310         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8311         type.
8312         (inf_ptrace_target::attach): Update.
8313         (inf_ptrace_target::files_info): Update.
8314         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8315         type.
8316         (go32_nat_target::pid_to_str): Change return type.
8317         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8318         (gnu_nat_target::wait): Update.
8319         (gnu_nat_target::wait): Update.
8320         (gnu_nat_target::resume): Update.
8321         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8322         (fbsd_nat_target::wait): Update.
8323         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8324         type.
8325         (darwin_nat_target::attach): Update.
8326         * corelow.c (class core_target) <pid_to_str>: Change return type.
8327         (core_target::pid_to_str): Change return type.
8328         * target.c (normal_pid_to_str): Change return type.
8329         (default_pid_to_str): Likewise.
8330         (target_pid_to_str): Change return type.
8331         (target_translate_tls_address): Update.
8332         (target_announce_detach): Update.
8333         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8334         return type.
8335         (bsd_uthread_target::pid_to_str): Change return type.
8336         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8337         type.
8338         (bsd_kvm_target::pid_to_str): Change return type.
8339         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8340         return type.
8341         (aix_thread_target::pid_to_str): Change return type.
8342         * target.h (struct target_ops) <pid_to_str>: Change return type.
8343         (target_pid_to_str, normal_pid_to_str): Likewise.
8344         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8345         type.
8346         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8347         type.
8348         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8349         return type.
8350         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8351         type.
8352         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8353         type.
8354         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8355         return type.
8356
8357 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8358
8359         * NEWS: Mention that the new default MI version is 3.  Mention
8360         changes to the output of commands and events that deal with
8361         multi-location breakpoints.
8362         * breakpoint.c: Include "mi/mi-out.h".
8363         (print_one_breakpoint): Change output syntax if using MI version
8364         >= 3.
8365         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8366         New.
8367         (mi_multi_location_breakpoint_output_fixed): New.
8368         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8369         (mi_cmd_fix_multi_location_breakpoint_output): New.
8370         (mi_multi_location_breakpoint_output_fixed): New.
8371         * mi/mi-cmds.c (mi_cmds): Register command
8372         -fix-multi-location-breakpoint-output.
8373         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8374         interpreter "mi".
8375
8376 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8377
8378         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8379         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8380         instantiate mi_ui_out based on interpreter name.
8381         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8382         * mi/mi-main.c (mi_load_progress): Likewise.
8383
8384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8385
8386         * NEWS: Combine separate "New targets" sections for 8.3.
8387
8388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8389
8390         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8391         (ppcfbsd_init_abi): Install gdbarch
8392         "fetch_tls_load_module_address" and "get_thread_local_address"
8393         methods.
8394
8395 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8396
8397         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8398         (riscv_fbsd_init_abi): Install gdbarch
8399         "fetch_tls_load_module_address" and "get_thread_local_address"
8400         methods.
8401
8402 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8403
8404         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8405         (i386fbsd_init_abi): Install gdbarch
8406         "fetch_tls_load_module_address" and "get_thread_local_address"
8407         methods.
8408
8409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8410
8411         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8412         (amd64fbsd_init_abi): Install gdbarch
8413         "fetch_tls_load_module_address" and "get_thread_local_address"
8414         methods.
8415
8416 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8417
8418         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8419         (struct fbsd_pspace_data): New type.
8420         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8421         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8422         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8423         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8424         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8425
8426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8427
8428         * gdbtypes.c (lookup_struct_elt): New function.
8429         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8430         * gdbtypes.h (struct struct_elt): New type.
8431         (lookup_struct_elt): New prototype.
8432
8433 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8434
8435         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8436         remove disabled code block.
8437
8438 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8439
8440         * gdbarch.sh (get_thread_local_address): New method.
8441         * gdbarch.h, gdbarch.c: Regenerate.
8442         * target.c (target_translate_tls_address): Use
8443         gdbarch_get_thread_local_address if present instead of
8444         target::get_thread_local_address.
8445
8446 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8447
8448         * target.h (target::get_thread_local_address): Update comment.
8449
8450 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8451
8452         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8453         objfile->separate_debug_objfile_backlink if not NULL.
8454
8455 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8456
8457         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8458         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8459         (amd64bsd_store_inferior_registers): Likewise.
8460         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8461         Enable segment base registers.
8462         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8463         PT_GETFSBASE and PT_GETGSBASE.
8464         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8465         PT_SETGSBASE.
8466         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8467         segment base registers.
8468         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8469
8470 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8471
8472         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8473         Update calls to i386_target_description to add 'segments'
8474         parameter.
8475         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8476         add segment base registers.
8477         * arch/i386.c (i386_create_target_description): Add 'segments'
8478         parameter to enable segment base registers.
8479         * arch/i386.h (i386_create_target_description): Likewise.
8480         * features/i386/32bit-segments.xml: New file.
8481         * features/i386/32bit-segments.c: Generate.
8482         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8483         call to i386_target_description to add 'segments' parameter.
8484         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8485         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8486         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8487         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8488         if feature is present.
8489         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8490         Add 'segments' parameter to call to i386_target_description.
8491         (i386_target_description): Add 'segments' parameter to enable
8492         segment base registers.
8493         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8494         to call to i386_target_description.
8495         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8496         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8497         Define I386_NUM_REGS.
8498         (i386_target_description): Add 'segments' parameter to enable
8499         segment base registers.
8500
8501 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8502
8503         PR/24325
8504         * source-cache.c: #undef open and close, to avoid unresolved
8505         externals during linking.
8506
8507 2019-03-12  Tom Tromey  <tromey@adacore.com>
8508
8509         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8510         const.  Add initializers.
8511         (_initialize_remote): Don't initialize ptid globals.
8512
8513 2019-03-12  Pedro Alves  <palves@redhat.com>
8514
8515         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8516
8517 2019-03-12  Pedro Alves  <palves@redhat.com>
8518
8519         * cp-name-parser.y (main): Remove unused 'len' variable.
8520
8521 2019-03-12  Tom Tromey  <tromey@adacore.com>
8522
8523         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8524         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8525
8526 2019-03-12  Tom Tromey  <tromey@adacore.com>
8527
8528         * linux-nat.c (iterate_over_lwps): Update.
8529         (stop_callback): Remove parameter.
8530         (stop_wait_callback, detach_callback, resume_set_callback)
8531         (select_singlestep_lwp_callback, set_ignore_sigint)
8532         (status_callback, resumed_callback, resume_clear_callback)
8533         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8534         data parameter.
8535         (linux_nat_target::detach, linux_nat_target::resume)
8536         (linux_stop_and_wait_all_lwps, select_event_lwp)
8537         (linux_nat_filter_event, linux_nat_wait_1)
8538         (linux_nat_target::kill, linux_nat_target::stop)
8539         (linux_nat_target::stop): Update.
8540         (linux_nat_resume_callback): Change type.
8541         (resume_stopped_resumed_lwps, count_events_callback)
8542         (select_event_lwp_callback): Likewise.
8543         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8544         * arm-linux-nat.c (struct update_registers_data): Remove.
8545         (update_registers_callback): Change type.
8546         (arm_linux_insert_hw_breakpoint1): Update.
8547         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8548         parameter.
8549         (x86_linux_dr_set_addr): Update.
8550         (x86_linux_dr_set_control): Update.
8551         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8552         (iterate_over_lwps): Use gdb::function_view.
8553         * nat/aarch64-linux-hw-point.c (struct
8554         aarch64_dr_update_callback_param): Remove.
8555         (debug_reg_change_callback): Change type.
8556         (aarch64_notify_debug_reg_change): Update.
8557         * s390-linux-nat.c (s390_refresh_per_info): Update.
8558
8559 2019-03-11  Tom Tromey  <tromey@adacore.com>
8560
8561         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8562         redundant assignment to "this_cu".
8563
8564 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8565
8566         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8567
8568 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8569
8570         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8571         from...
8572         (rank_one_type): ... this.
8573
8574 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8575
8576         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8577         from...
8578         (rank_one_type): ... this.
8579
8580 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8581
8582         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8583         from...
8584         (rank_one_type): ... this.
8585
8586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8587
8588         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8589         from...
8590         (rank_one_type): ... this.
8591
8592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8593
8594         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8595         from...
8596         (rank_one_type): ... this.
8597
8598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8599
8600         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8601         from...
8602         (rank_one_type): ... this.
8603
8604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8605
8606         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8607         from...
8608         (rank_one_type): ... this.
8609
8610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8611
8612         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8613         from...
8614         (rank_one_type): ... this.
8615
8616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8617
8618         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8619         from...
8620         (rank_one_type): ... this.
8621
8622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8623
8624         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8625         from...
8626         (rank_one_type): ... this.
8627
8628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8629
8630         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8631         from...
8632         (rank_one_type): ... this.
8633
8634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8635
8636         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8637         from...
8638         (rank_one_type): ... this.
8639
8640 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8641
8642         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8643         inferior-events' shows the example events.
8644
8645 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8646
8647         Support styling on native MS-Windows console
8648
8649         PR/24315
8650         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8651         on MS-Windows if $TERM is not defined.
8652
8653         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8654
8655         * posix-hdep.c (gdb_console_fputs):
8656         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8657         functions.
8658         * ui-file.h (gdb_console_fputs): Add prototype.
8659
8660         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8661         back to fputs only if the former returns zero.
8662
8663 2019-03-07  Tom Tromey  <tom@tromey.com>
8664
8665         * symmisc.c (print_symbol_bcache_statistics): Update.
8666         (print_objfile_statistics): Update.
8667         * symfile.c (allocate_symtab): Update.
8668         * stabsread.c: Don't include bcache.h.
8669         * psymtab.h (struct psymbol_bcache): Don't declare.
8670         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8671         (psymbol_bcache_init, psymbol_bcache_free)
8672         (psymbol_bcache_get_bcache): Don't declare.
8673         * psymtab.c (struct psymbol_bcache): Remove.
8674         (psymtab_storage::psymtab_storage): Update.
8675         (psymtab_storage::~psymtab_storage): Update.
8676         (psymbol_bcache_init, psymbol_bcache_free)
8677         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8678         (add_psymbol_to_bcache): Update.
8679         (allocate_psymtab): Update.
8680         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8681         macro_cache>: No longer pointers.
8682         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8683         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8684         * macrotab.c (macro_bcache): Update.
8685         * macroexp.c: Don't include bcache.h.
8686         * gdbtypes.c (check_types_worklist): Update.
8687         (types_deeply_equal): Remove TRY/CATCH.  Update.
8688         * elfread.c (elf_symtab_read): Update.
8689         * dwarf2read.c: Don't include bcache.h.
8690         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8691         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8692         (print_bcache_statistics, bcache_memory_used): Don't declare.
8693         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8694         methods.  Rename all data members.
8695         * bcache.c (struct bcache): Move to bcache.h.
8696         (bcache::expand_hash_table): Rename from expand_hash_table.
8697         (bcache): Remove.
8698         (bcache::insert): Rename from bcache_full.
8699         (bcache::compare): Rename from bcache_compare.
8700         (bcache_xmalloc): Remove.
8701         (bcache::~bcache): Rename from bcache_xfree.
8702         (bcache::print_statistics): Rename from print_bcache_statistics.
8703         (bcache::memory_used): Rename from bcache_memory_used.
8704
8705 2019-03-07  Pedro Alves  <palves@redhat.com>
8706
8707         * infrun.c (normal_stop): Also check for
8708         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8709
8710 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8711
8712         * f-lang.c (value_from_host_double): Moved to...
8713         * value.c (value_from_host_double): ...here.
8714         * value.h (value_from_host_double): Declare.
8715         * guile/scm-math.c (vlscm_convert_typed_number): Use
8716         value_from_host_double.
8717         (vlscm_convert_number): Likewise.
8718         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8719         * python/py-value.c (convert_value_from_python): Likewise.
8720
8721 2019-03-06  Tom Tromey  <tom@tromey.com>
8722
8723         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8724
8725 2019-03-06  Tom Tromey  <tom@tromey.com>
8726
8727         * utils.h (free_current_contents): Don't declare.
8728         * utils.c (free_current_contents): Remove.
8729
8730 2019-03-06  Tom Tromey  <tom@tromey.com>
8731
8732         * top.c (quit_force): Update.
8733         * main.c (captured_command_loop): Update.
8734         * common/new-op.c (operator new): Update.
8735         * common/common-exceptions.c (struct catcher)
8736         <save_cleanup_chain>: Remove member.
8737         (exceptions_state_mc_init): Update.
8738         (exception_try_scope_entry): Return nullptr.
8739         (exception_try_scope_exit, exception_rethrow)
8740         (throw_exception_sjlj, throw_exception_cxx): Update.
8741         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8742         (all_cleanups, do_cleanups, discard_cleanups)
8743         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8744         (restore_cleanups, restore_final_cleanups): Don't declare.
8745         (do_final_cleanups): Remove parameter.
8746         * common/cleanups.c (cleanup_chain, make_cleanup)
8747         (make_cleanup_dtor, all_cleanups, do_cleanups)
8748         (discard_my_cleanups, discard_cleanups)
8749         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8750         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8751         (null_cleanup): Remove.
8752         (do_final_cleanups): Remove parameter.
8753
8754 2019-03-06  Tom Tromey  <tom@tromey.com>
8755
8756         * remote.c (remote_target::remote_parse_stop_reply): Use
8757         unique_xmalloc_ptr.
8758
8759 2019-03-06  Tom Tromey  <tom@tromey.com>
8760
8761         * stabsread.c (struct stabs_field_info): Rename from field_info.
8762         <list, fnlist>: Add initializers.
8763         <obstack>: New member.
8764         (read_member_functions, read_struct_fields, read_baseclasses):
8765         Allocate on obstack.  Don't use cleanups.
8766         (read_one_struct_field, read_member_functions, read_struct_fields)
8767         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8768         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8769         (read_struct_type): Update.
8770
8771 2019-03-06  Tom Tromey  <tom@tromey.com>
8772
8773         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8774         * common/filestuff.h (make_cleanup_close): Don't declare.
8775         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8776         Remove.
8777
8778 2019-03-06  Tom Tromey  <tom@tromey.com>
8779
8780         * solib-aix.c: Use make_scope_exit.
8781
8782 2019-03-06  Tom Tromey  <tom@tromey.com>
8783
8784         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8785         Use make_scope_exit.
8786
8787 2019-03-06  Tom Tromey  <tom@tromey.com>
8788
8789         * solib-svr4.c (disable_probes_interface): Remove parameter.
8790         (svr4_handle_solib_event): Use make_scope_exit.
8791
8792 2019-03-06  Tom Tromey  <tom@tromey.com>
8793
8794         * remote.c (struct stop_reply_deleter): Remove.
8795         (stop_reply_up): Update.
8796         (struct stop_reply): Derive from notif_event.  Don't typedef.
8797         <regcache>: Now a std::vector.
8798         (stop_reply_xfree): Remove.
8799         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8800         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8801         (remote_target::discard_pending_stop_replies): Use delete.
8802         (remote_target::remote_parse_stop_reply): Update.
8803         (remote_target::process_stop_reply): Update.
8804         * remote-notif.h (struct notif_event): Add virtual destructor.
8805         Remove "dtr" member.
8806         (struct notif_client) <alloc_event>: Return a unique_ptr.
8807         (notif_event_xfree): Don't declare.
8808         (notif_event_up): New typedef.
8809         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8810         (notif_event_xfree, do_notif_event_xfree): Remove.
8811         (remote_notif_state_xfree): Update.
8812
8813 2019-03-06  Tom Tromey  <tom@tromey.com>
8814
8815         * infrun.c (displaced_step_clear_cleanup): Now a
8816         forward_scope_exit type.
8817         (displaced_step_prepare_throw): Update.
8818         (displaced_step_fixup): Update.
8819
8820 2019-03-06  Tom Tromey  <tom@tromey.com>
8821
8822         * inferior.h (class inferior): Update comment.
8823         * gdbthread.h (class thread_info): Update comment.
8824
8825 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8826             Tom Tromey  <tom@tromey.com>
8827
8828         * stabsread.h (struct stab_section_list): Remove.
8829         (coffstab_build_psymtabs): Update.
8830         * dbxread.c (symbuf_sections): Now a std::vector.
8831         (sect_idx): New global.
8832         (fill_symbuf): Update.
8833         (coffstab_build_psymtabs): Change type of stabsects parameter.
8834         Update.
8835         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8836         std::vector.
8837         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8838         (coff_locate_sections): Update.
8839         (coff_symfile_read): Remove cleanups.  Update.
8840         (init_stringtab): Add storage parameter.
8841         (free_stringtab, free_stringtab_cleanup): Remove.
8842         (init_lineno): Add storage parameter.
8843         (free_linetab, free_linetab_cleanup): Remove.
8844
8845 2019-03-06  Pedro Alves  <palves@redhat.com>
8846
8847         * linux-fork.c (fork_info::clobber_regs): Delete.
8848         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8849         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8850         comment.  Adjust.
8851         (scoped_switch_fork_info::scoped_switch_fork_info)
8852         (checkpoint_command, linux_fork_context): Adjust
8853         fork_save_infrun_state calls.
8854
8855 2019-03-06  Pedro Alves  <palves@redhat.com>
8856
8857         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8858         (inf_has_multiple_threads): Return 'bool' and rewrite using
8859         inferior_info::threads().
8860
8861 2019-03-06  Pedro Alves  <palves@redhat.com>
8862
8863         * linux-fork.c: Include <list>.
8864         (fork_list): Now a std::list instance.
8865         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8866         (forks_exist_p, find_last_fork): Adjust.
8867         (new_fork): Delete.
8868         (one_fork_p): New.
8869         (add_fork): Adjust.
8870         (free_fork): Delete, folded into fork_info::~fork_info().
8871         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8872         Adjust.
8873         (init_fork_list): Delete.
8874         (linux_fork_killall, linux_fork_mourn_inferior)
8875         (linux_fork_detach, info_checkpoints_command): Adjust.
8876         (_initialize_linux_fork): No longer call init_fork_list.
8877
8878 2019-03-06  Pedro Alves  <palves@redhat.com>
8879
8880         * linux-fork.c (new_fork): New, split out of ...
8881         (add_fork): ... this.  Return void.  Move "first fork" special
8882         case from here, to ...
8883         (checkpoint_command): ... here.
8884         * linux-linux.h (add_fork): Return void.
8885
8886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8887
8888         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8889
8890 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8891             Chris January  <chris.january@arm.com>
8892             David Lecomber  <david.lecomber@arm.com>
8893
8894         * f-exp.y: New token, UNOP_INTRINSIC.
8895         (exp): New pattern using UNOP_INTRINSIC token.
8896         (f77_keywords): Add 'abs' keyword.
8897         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8898         (value_from_host_double): New function.
8899         (evaluate_subexp_f): Support UNOP_ABS.
8900
8901 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8902
8903         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8904         types.
8905
8906 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8907
8908         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8909         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8910         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8911
8912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8913
8914         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8915
8916 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8917             Chris January  <chris.january@arm.com>
8918
8919         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8920         * f-exp.y: Define 'KIND' token.
8921         (exp): New pattern for KIND expressions.
8922         (ptype): Handle types with a kind extension.
8923         (direct_abs_decl): Extend to spot kind extensions.
8924         (f77_keywords): Add 'kind' to the list.
8925         (push_kind_type): New function.
8926         (convert_to_kind_type): New function.
8927         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8928         * parse.c (operator_length_standard): Likewise.
8929         * parser-defs.h (enum type_pieces): Add tp_kind.
8930         * std-operator.def: Add UNOP_KIND.
8931
8932 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8933
8934         * f-exp.y (f_parse): Set yydebug.
8935
8936 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8937
8938         * f-lang.c (evaluate_subexp_f): New function.
8939         (exp_descriptor_f): New global.
8940         (f_language_defn): Use exp_descriptor_f instead of
8941         exp_descriptor_standard.
8942
8943 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8944
8945         * f-exp.y (struct token): Add comments.
8946         (dot_ops): Remove uppercase versions and the end marker.
8947         (f77_keywords): Likewise.
8948         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8949         entries in the dot_ops array are case insensitive, and use
8950         strncasecmp to compare strings.  Also some whitespace cleanup in
8951         this area.  Similar for the f77_keywords array, except entries in
8952         this list might be case sensitive.
8953
8954 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8955
8956         * f-exp.y (struct f77_boolean_val): Add comments.
8957         (boolean_values): Remove uppercase versions, and end marker.
8958         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8959         and use strncasecmp to achieve case insensitivity.  Additionally,
8960         perform whitespace cleanup around this code.
8961
8962 2019-03-06  Tom Tromey  <tromey@adacore.com>
8963
8964         * remote-sim.c (gdbsim_target_open): Use result of
8965         gdb_argv::release.
8966
8967 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8968         Dirk Schubert  <dirk.schubert@arm.com>
8969         Chris January  <chris.january@arm.com>
8970
8971         * eval.c (evaluate_subexp_standard): Call Fortran argument
8972         wrapping logic.
8973         * f-lang.c (struct value): A value which can be passed into a
8974         Fortran function call.
8975         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8976         where appropriate.
8977         (struct type): Value ready for a Fortran function call.
8978         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8979         is needed.
8980         * f-lang.h (fortran_argument_convert): Declaration.
8981         (fortran_preserve_arg_pointer): Declaration.
8982         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8983
8984 2019-03-05  Tom Tromey  <tromey@adacore.com>
8985
8986         * python/py-prettyprint.c (print_string_repr): Remove #if.
8987         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8988
8989 2019-03-05  Tom Tromey  <tromey@adacore.com>
8990
8991         * target.c (the_dummy_target): Move later.  Change type to
8992         "dummy_target".
8993         (initialize_targets): Don't initialize the_dummy_target.
8994
8995 2019-03-05  Tom Tromey  <tromey@adacore.com>
8996
8997         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8998         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8999
9000 2019-03-05  Tom Tromey  <tromey@adacore.com>
9001
9002         * windows-nat.c (windows_nat_target::attach)
9003         (windows_nat_target::detach): Don't call gdb_flush.
9004         * valprint.c (generic_val_print, val_print, val_print_string):
9005         Don't call gdb_flush.
9006         * utils.c (defaulted_query): Don't call gdb_flush.
9007         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9008         * target.c (target_announce_detach): Don't call gdb_flush.
9009         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9010         * remote.c (extended_remote_target::attach): Don't call
9011         gdb_flush.
9012         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9013         * printcmd.c (do_examine): Don't call gdb_flush.
9014         (info_display_command): Don't call gdb_flush.
9015         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9016         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9017         * memattr.c (info_mem_command): Don't call gdb_flush.
9018         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9019         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9020         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9021         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9022         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9023         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9024         (gnu_nat_target::detach): Don't call gdb_flush.
9025         * f-valprint.c (f_val_print): Don't call gdb_flush.
9026         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9027         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9028         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9029         gdb_flush.
9030         * c-valprint.c (c_val_print): Don't call gdb_flush.
9031         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9032
9033 2019-03-05  Tom Tromey  <tromey@adacore.com>
9034
9035         * varobj.c (update_dynamic_varobj_children): Update.
9036         (install_default_visualizer): Use reset, not release.
9037         * value.c (set_internalvar): Update.
9038         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9039         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9040         ATTRIBUTE_UNUSED_RESULT.
9041
9042 2019-03-05  Tom Tromey  <tromey@adacore.com>
9043
9044         * remote.c (class scoped_remote_fd) <release>: Add
9045         ATTRIBUTE_UNUSED_RESULT.
9046
9047 2019-03-05  Tom Tromey  <tromey@adacore.com>
9048
9049         * macroexp.c (struct macro_buffer) <release>: Add
9050         ATTRIBUTE_UNUSED_RESULT.
9051
9052 2019-03-05  Tom Tromey  <tromey@adacore.com>
9053
9054         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9055         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9056         ATTRIBUTE_UNUSED_RESULT.
9057
9058 2019-03-05  Tom Tromey  <tromey@adacore.com>
9059
9060         * common/scoped_fd.h (class scoped_fd) <release>: Add
9061         ATTRIBUTE_UNUSED_RESULT.
9062
9063 2019-03-05  Tom Tromey  <tromey@adacore.com>
9064
9065         * parser-defs.h (struct parser_state) <release>: Add
9066         ATTRIBUTE_UNUSED_RESULT.
9067
9068 2019-03-05  Tom Tromey  <tromey@adacore.com>
9069
9070         * utils.h (class gdb_argv) <release>: Add
9071         ATTRIBUTE_UNUSED_RESULT.
9072         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9073
9074 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9075
9076         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9077         for-loop range, to avoid compiler warnings.
9078
9079         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9080         avoid compiler warnings about unused variables.
9081
9082         * NEWS: Mention end of support for native debugging on MS-Windows
9083         before XP.
9084
9085         PR gdb/24292
9086         * common/netstuff.c:
9087         * gdbserver/gdbreplay.c
9088         * gdbserver/remote-utils.c:
9089         * ser-tcp.c:
9090         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9091         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9092         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9093         'getaddrinfo' and 'freeaddrinfo' were not available before
9094         Windows XP, and mingw.org's MinGW headers by default define
9095         _WIN32_WINNT to 0x500.
9096
9097 2019-03-01  Gary Benson <gbenson@redhat.com>
9098
9099         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9100
9101 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9102             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9103
9104         PR gdb/8527
9105         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9106         set_sigint_trap, clear_sigint_trap.
9107
9108 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9109
9110         * target.c (target_detach): Clear the regcache and the
9111         frame cache.
9112
9113 2019-02-27  Pedro Alves  <palves@redhat.com>
9114
9115         * utils.c (set_screen_size): When we cap the height/width sizes,
9116         tweak the corresponding command variable to show "unlimited":
9117
9118 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9119             Pedro Alves  <palves@redhat.com>
9120
9121         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9122         before calling rl_set_screen_size.
9123
9124 2019-02-27  Tom Tromey  <tromey@adacore.com>
9125
9126         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9127         define.
9128         * python/py-value.c: Remove Python 2.4 workaround.
9129         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9130         workaround.
9131         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9132         Python 2.4 workaround.
9133         * python/python-internal.h: Remove Python 2.4 comment.
9134         (Py_ssize_t): Don't define.
9135         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9136         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9137         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9138         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9139         * python/python.c (do_start_initialization): Remove Python 2.4
9140         workaround.
9141         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9142         (print_children): Remove Python 2.4 workaround.
9143         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9144         workaround.
9145         (CHARBUFFERPROC_NAME): Remove.
9146         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9147         Python 2.4 workaround.
9148
9149 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9150
9151         * NEWS: Note minimum Python version.
9152
9153 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9154
9155         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9156         code from these functions.  Remove corresponding ifdefs.  Use
9157         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9158         Remove gotos and target of gotos.
9159         (infpy_search_memory): Likewise.
9160
9161 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9162
9163         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9164         (hppa_gdbarch_init): Don't register deleted functions with
9165         gdbarch.
9166
9167 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9168
9169         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9170         (h8300_unwind_sp): Delete.
9171         (h8300_dummy_id): Delete.
9172         (h8300_gdbarch_init): Don't register deleted functions with
9173         gdbarch.
9174
9175 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9176
9177         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9178         (ft32_unwind_pc): Delete.
9179         (ft32_unwind_sp): Delete.
9180         (ft32_gdbarch_init): Don't register deleted functions with
9181         gdbarch.
9182
9183 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9184
9185         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9186         (frv_unwind_pc): Delete.
9187         (frv_unwind_sp): Delete.
9188         (frv_gdbarch_init): Don't register deleted functions with
9189         gdbarch.
9190
9191 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9192
9193         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9194         (riscv_unwind_pc): Delete.
9195         (riscv_unwind_sp): Delete.
9196         (riscv_gdbarch_init): Don't register deleted functions with
9197         gdbarch.
9198
9199 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9200
9201         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9202         (csky_unwind_pc): Delete.
9203         (csky_unwind_sp): Delete.
9204         (csky_gdbarch_init): Don't register deleted functions with
9205         gdbarch.
9206
9207 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9208
9209         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9210         (cris_unwind_pc): Delete.
9211         (cris_unwind_sp): Delete.
9212         (cris_gdbarch_init): Don't register deleted functions with
9213         gdbarch.
9214
9215 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9216
9217         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9218         (bfin_unwind_pc): Delete.
9219         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9220
9221 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9222
9223         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9224         (arm_unwind_pc): Delete.
9225         (arm_unwind_sp): Delete.
9226         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9227
9228 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9229
9230         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9231         (arc_unwind_pc): Delete.
9232         (arc_unwind_sp): Delete.
9233         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9234
9235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9236
9237         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9238         (alpha_unwind_pc): Delete.
9239         (alpha_gdbarch_init): Don't register deleted functions with
9240         gdbarch.
9241
9242 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9243
9244         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9245         (aarch64_unwind_pc): Delete.
9246         (aarch64_unwind_sp): Delete.
9247         (aarch64_gdbarch_init): Don't register deleted functions with
9248         gdbarch.
9249
9250 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9251
9252         * gdbtypes.c (type_align): Don't consider static members when
9253         computing structure alignment.
9254
9255 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9256
9257         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9258         return 0 for other types.
9259         * arch-utils.c (default_type_align): Always return 0.
9260         * gdbarch.h: Regenerate.
9261         * gdbarch.sh (type_align): Extend comment.
9262         * gdbtypes.c (type_align): Add additional comments, always call
9263         gdbarch_type_align before applying the default rules.
9264         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9265         generic code will then apply a suitable default.
9266         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9267         types, return 0 for other types.
9268
9269 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9270
9271         * NEWS: Create a new section for the next release branch.
9272         Rename the section of the current branch, now that it has
9273         been cut.
9274
9275 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9276
9277         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9278         * version.in: Bump version to 8.3.50.DATE-git.
9279
9280 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9281
9282         * aix-thread.c (ptid_cmp): Remove unused variable.
9283         (get_signaled_thread): Likewise.
9284         (store_regs_user_thread): Likewise.
9285         (store_regs_kernel_thread): Likewise.
9286         (fetch_regs_kernel_thread): Remove shadowed variable.
9287
9288 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9289
9290         * features/riscv/32bit-cpu.xml: Add register numbers.
9291         * features/riscv/32bit-fpu.c: Regenerate.
9292         * features/riscv/32bit-fpu.xml: Add register numbers.
9293         * features/riscv/64bit-cpu.xml: Add register numbers.
9294         * features/riscv/64bit-fpu.c: Regenerate.
9295         * features/riscv/64bit-fpu.xml: Add register numbers.
9296
9297 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9298
9299         * NEWS: Mention two argument form of gdb.Value constructor.
9300         * python/py-value.c (convert_buffer_and_type_to_value): New
9301         function.
9302         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9303         Add support for handling an optional second argument.  Call
9304         convert_buffer_and_type_to_value as appropriate.
9305         * python/python-internal.h (Py_buffer_deleter): New struct.
9306         (Py_buffer_up): New typedef.
9307
9308 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9309
9310         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9311         instead of releasing ownership.
9312
9313 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9314
9315         * dwarf2read.c (open_and_init_dwp_file): Call
9316         elf_numsections instead of bfd_count_sections to initialize
9317         dwp_file->num_sections.
9318
9319 2019-02-25  Tom Tromey  <tromey@adacore.com>
9320
9321         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9322
9323 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9324
9325         * gcore.in: Add '--readnever' option when invoking GDB.
9326
9327 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9328
9329         * MAINTAINERS: Update my email address.
9330
9331 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9332
9333         * build-id.c (build_id_to_debug_bfd_1): New function.
9334         (build_id_to_debug_bfd): Look for separate debug file in
9335         sysroot.
9336
9337 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9338
9339         * gdbarch.sh: Update the copyright year range that is placed into
9340         generated files.
9341
9342 2019-02-22  Keith Seitz  <keiths@redhat.com>
9343
9344         PR symtab/23853
9345         * linespec.c (create_sals_line_offset): Search for the default
9346         symtab's filename instead of its fullname.
9347
9348 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9349
9350         * NEWS: Update style defaults.
9351
9352 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9353
9354         * main.c (captured_main_1): Disable styling in batch mode.
9355
9356 2019-02-20  Tom Tromey  <tom@tromey.com>
9357
9358         * symtab.c (symtab_symbol_info): Fix typos.
9359
9360 2019-02-20  Tom Tromey  <tromey@adacore.com>
9361
9362         * findcmd.c (_initialize_mem_search): Use upper case for
9363         metasyntactic variables.
9364
9365 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9366
9367         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9368         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9369
9370 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9371
9372         * top.h (source_file_name): Change to std::string.
9373         * top.c (source_file_name): Likewise.
9374         (command_line_input): Adjust.
9375         * cli/cli-script.c (script_from_file): Adjust.
9376
9377 2019-02-19  Tom Tromey  <tromey@adacore.com>
9378
9379         * ravenscar-thread.c
9380         (ravenscar_thread_target::update_thread_list): Don't call
9381         ada_build_task_list.
9382         * ada-lang.h (ada_build_task_list): Don't declare.
9383         * ada-tasks.c (struct ada_tasks_inferior_data)
9384         <task_list_valid_p>: Now bool.
9385         (read_known_tasks, ada_task_list_changed)
9386         (ada_tasks_invalidate_inferior_data): Update.
9387         (read_known_tasks_array): Return bool.
9388         (read_known_tasks_list): Likewise.
9389         (read_known_tasks): Return void.
9390         (ada_build_task_list): Now static.
9391
9392 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9393
9394         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9395         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9396
9397 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9398
9399         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9400         variant for ada_tasks_pspace_data_handle and
9401         ada_tasks_inferior_data_handle.
9402         (ada_tasks_pspace_data_cleanup): New function.
9403         (ada_tasks_inferior_data_cleanup): New function.
9404
9405 2019-02-17  Tom Tromey  <tom@tromey.com>
9406
9407         * macrotab.h (macro_source_fullname): Return a std::string.
9408         * macrotab.c (macro_include, check_for_redefinition)
9409         (macro_undef, macro_lookup_definition, foreach_macro)
9410         (foreach_macro_in_scope): Update.
9411         (macro_source_fullname): Return a std::string.
9412         * macrocmd.c (show_pp_source_pos): Update.
9413
9414 2019-02-17  Tom Tromey  <tom@tromey.com>
9415
9416         * macrocmd.c (show_pp_source_pos): Style the file names.
9417
9418 2019-02-17  Tom Tromey  <tom@tromey.com>
9419
9420         PR tui/24197:
9421         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9422
9423 2019-02-17  Tom Tromey  <tom@tromey.com>
9424
9425         * ada-lang.c (user_select_syms): Use filtered printing.
9426         * utils.c (wrap_style): New global.
9427         (desired_style): Remove.
9428         (emit_style_escape): Add stream parameter.
9429         (set_output_style, reset_terminal_style, prompt_for_continue):
9430         Update.
9431         (flush_wrap_buffer): Only flush gdb_stdout.
9432         (wrap_here): Set wrap_style.
9433         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9434         treat escape sequences as a character.  Change when wrap buffer is
9435         flushed.
9436         (fputs_styled): Do not set the output style when the default is
9437         requested.
9438         * ui-style.h (struct ui_file_style) <is_default>: New method.
9439         * source.c (print_source_lines_base): Emit escape sequences in one
9440         piece.
9441
9442 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9443
9444         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9445         integers and enumeration types.
9446
9447 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9448
9449         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9450         instead of lookup_symbol_in_language
9451         (do_exact_match): New function.
9452         (ada_get_symbol_name_matcher): Return do_exact_match when
9453         doing a verbatim match.
9454
9455 2019-02-15  Tom Tromey  <tromey@adacore.com>
9456
9457         * ravenscar-thread.c (ravenscar_thread_target::resume)
9458         (ravenscar_thread_target::wait): Special case wildcard requests.
9459
9460 2019-02-15  Tom Tromey  <tromey@adacore.com>
9461
9462         * ravenscar-thread.c (base_ptid): Remove.
9463         (struct ravenscar_thread_target) <close>: New method.
9464         <m_base_ptid>: New member.
9465         <update_inferior_ptid, active_task, task_is_currently_active,
9466         runtime_initialized>: Declare methods.
9467         <ravenscar_thread_target>: Add constructor.
9468         (ravenscar_thread_target::task_is_currently_active)
9469         (ravenscar_thread_target::update_inferior_ptid)
9470         (ravenscar_runtime_initialized): Rename.  Now methods.
9471         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9472         (ravenscar_thread_target::update_thread_list): Update.
9473         (ravenscar_thread_target::active_task): Now method.
9474         (ravenscar_thread_target::store_registers)
9475         (ravenscar_thread_target::prepare_to_store)
9476         (ravenscar_thread_target::prepare_to_store)
9477         (ravenscar_thread_target::mourn_inferior): Update.
9478         (ravenscar_inferior_created): Use "new" to create target.
9479         (ravenscar_thread_target::get_ada_task_ptid): Update.
9480         (_initialize_ravenscar): Don't initialize base_ptid.
9481         (ravenscar_ops): Remove global.
9482
9483 2019-02-15  Tom Tromey  <tromey@adacore.com>
9484
9485         * target.h (push_target): Declare new overload.
9486         * target.c (push_target): New overload, taking an rvalue reference.
9487         * remote.c (remote_target::open_1): Use push_target overload.
9488         * corelow.c (core_target_open): Use push_target overload.
9489
9490 2019-02-15  Tom Tromey  <tromey@adacore.com>
9491
9492         * ravenscar-thread.c (is_ravenscar_task)
9493         (ravenscar_task_is_currently_active): Return bool.
9494         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9495         (_initialize_ravenscar): Remove "(void)".
9496         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9497         Return bool.
9498
9499 2019-02-15  Tom Tromey  <tromey@adacore.com>
9500
9501         * ravenscar-thread.c (ravenscar_runtime_initializer)
9502         (has_ravenscar_runtime, get_running_thread_id)
9503         (ravenscar_thread_target::resume): Fix indentation.
9504
9505 2019-02-15  Tom Tromey  <tromey@adacore.com>
9506
9507         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9508         from ravenscar_arch_ops.
9509         (sparc_ravenscar_ops::fetch_registers)
9510         (sparc_ravenscar_ops::store_registers): Now methods.
9511         (sparc_ravenscar_prepare_to_store): Remove.
9512         (sparc_ravenscar_ops): Redefine.
9513         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9514         methods and destructor.  Remove members.
9515         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9516         (ravenscar_thread_target::store_registers)
9517         (ravenscar_thread_target::prepare_to_store): Update.
9518         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9519         Remove.
9520         (struct ppc_ravenscar_powerpc_ops): Derive from
9521         ravenscar_arch_ops.
9522         (ppc_ravenscar_powerpc_ops::fetch_registers)
9523         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9524         (ppc_ravenscar_powerpc_ops): Redefine.
9525         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9526         (ppc_ravenscar_e500_ops::fetch_registers)
9527         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9528         (ppc_ravenscar_e500_ops): Redefine.
9529         * aarch64-ravenscar-thread.c
9530         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9531         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9532         (aarch64_ravenscar_fetch_registers)
9533         (aarch64_ravenscar_store_registers): Now methods.
9534         (aarch64_ravenscar_ops): Redefine.
9535
9536 2019-02-15  Tom Tromey  <tromey@adacore.com>
9537
9538         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9539         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9540         (ravenscar_thread_target::stopped_by_watchpoint)
9541         (ravenscar_thread_target::stopped_data_address)
9542         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9543
9544 2019-02-15  Tom Tromey  <tromey@adacore.com>
9545
9546         * ravenscar-thread.c: Fix some typos.
9547
9548 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9549             Tom Tromey  <tromey@adacore.com>
9550
9551         * ada-lang.c (ada_exception_sal): Change addr_string to a
9552         std::string.
9553         (create_ada_exception_catchpoint): Update.
9554
9555 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9556             Tom Tromey  <tromey@adacore.com>
9557
9558         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9559         (bp_location_ops): Remove.
9560         (base_breakpoint_allocate_location): Update.
9561         (free_bp_location): Update.
9562         * ada-lang.c (class ada_catchpoint_location)
9563         <ada_catchpoint_location>: Remove ops parameter.
9564         (ada_catchpoint_location_dtor): Remove.
9565         (ada_catchpoint_location_ops): Remove.
9566         (allocate_location_exception): Update.
9567         * breakpoint.h (struct bp_location_ops): Remove.
9568         (class bp_location) <bp_location>: Remove bp_location_ops
9569         parameter.
9570         <~bp_location>: Add destructor.
9571         <ops>: Remove.
9572
9573 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9574             Pedro Alves  <palves@redhat.com>
9575
9576         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9577         'PATH_MAX'.
9578
9579 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9580             Samuel Thibault  <samuel.thibault@gnu.org>
9581             Thomas Schwinge  <thomas@codesourcery.com>
9582
9583         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9584         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9585
9586 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9587
9588         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9589         (check_empty): Use "const char *".
9590
9591         * gnu-nat.c (gnu_nat_target::detach): Instead of
9592         'detach_inferior (pid)' call
9593         'detach_inferior (find_inferior_pid (pid))'.
9594
9595         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9596         'nat/fork-inferior.o'.
9597         * gnu-nat.c: #include "nat/fork-inferior.h".
9598
9599         * gnu-nat.c (gnu_nat_target::detach): Instead of
9600         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9601         * gnu-nat.h: #include "inf-child.h".
9602         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9603         'i386_gnu_nat_target::fetch_registers'.
9604         (gnu_store_registers): Rename/move to
9605         'i386_gnu_nat_target::store_registers'.
9606
9607         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9608         * gnu-nat.h (mach_thread_info): New function.
9609         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9610
9611         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9612
9613 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9614
9615         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9616
9617 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9618
9619         * windows-nat.c (windows_add_thread): Add new parameter
9620         "main_thread_p" with default value set to false.  Update
9621         function documentation as well as all callers.
9622         (windows_delete_thread): Likewise.
9623         (fake_create_process): Update call to windows_add_thread.
9624         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9625         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9626         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9627         call to windows_delete_thread.
9628
9629 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9630
9631         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9632
9633 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9634
9635         * symfile.c (find_separate_debug_file): Use canonical path of
9636         sysroot with child_path instead of gdb_sysroot if it is valid.
9637
9638 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9639
9640         * symfile.c (find_separate_debug_file): Use child_path to
9641         determine if an object file is under a sysroot.
9642
9643 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9644
9645         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9646         unittests/child-path-selftests.c.
9647         * common/pathstuff.c (child_path): New function.
9648         * common/pathstuff.h (child_path): New prototype.
9649         * unittests/child-path-selftests.c: New file.
9650
9651 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9652
9653         * symfile.c (find_separate_debug_file): Look for separate debug
9654         files in debug directories under the sysroot.
9655
9656 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9657
9658         * symtab.h (struct minimal_symbol data_p): New const method.
9659         (struct minimal_symbol text_p): Likewise.
9660         * symtab.c (output_source_filename): Use file name style
9661         to print file name.
9662         (print_symbol_info): Likewise.
9663         (print_msymbol_info): Use address style to print addresses.
9664         Use function name style to print executable text symbols.
9665         (expand_symtab_containing_pc): Use data_p.
9666         (find_pc_sect_compunit_symtab): Likewise.
9667
9668 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9669
9670         * breakpoint.c (describe_other_breakpoints): Use address style
9671         to print addresses.
9672         (say_where): Likewise.
9673
9674 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9675
9676         * ada-typeprint.c (print_func_type): Print function name
9677         style to print function name.
9678         * c-typeprint.c (c_print_type_1): Likewise.
9679
9680 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9681
9682         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9683         for execve.
9684
9685 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9686
9687         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9688         type_stack.
9689
9690 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9691
9692         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9693         TYPE_CODE_REF types.
9694
9695 2019-02-08  Jim Wilson  <jimw@sifive.com>
9696
9697         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9698         (riscv_linux_fregset): New.
9699         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9700
9701 2019-02-07  Tom Tromey  <tom@tromey.com>
9702
9703         * thread.c (thread_cancel_execution_command): Update.
9704         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9705         methods.
9706         (struct thread_fsm_ops): Remove.
9707         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9708         (thread_fsm_should_stop, thread_fsm_return_value)
9709         (thread_fsm_set_finished, thread_fsm_finished_p)
9710         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9711         Don't declare.
9712         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9713         * infrun.c (clear_proceed_status_thread)
9714         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9715         (print_stop_event): Update.
9716         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9717         Add constructor.
9718         (step_command_fsm_ops): Remove.
9719         (new_step_command_fsm): Remove.
9720         (step_1): Update.
9721         (step_command_fsm::should_stop): Rename from
9722         step_command_fsm_should_stop.
9723         (step_command_fsm::clean_up): Rename from
9724         step_command_fsm_clean_up.
9725         (step_command_fsm::do_async_reply_reason): Rename from
9726         step_command_fsm_async_reply_reason.
9727         (struct until_next_fsm): Inherit from thread_fsm.  Add
9728         constructor.
9729         (until_next_fsm_ops): Remove.
9730         (new_until_next_fsm): Remove.
9731         (until_next_fsm::should_stop): Rename from
9732         until_next_fsm_should_stop.
9733         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9734         (until_next_fsm::do_async_reply_reason): Rename from
9735         until_next_fsm_async_reply_reason.
9736         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9737         constructor.  Change type of breakpoint.
9738         (finish_command_fsm_ops): Remove.
9739         (new_finish_command_fsm): Remove.
9740         (finish_command_fsm::should_stop): Rename from
9741         finish_command_fsm_should_stop.
9742         (finish_command_fsm::clean_up): Rename from
9743         finish_command_fsm_clean_up.
9744         (finish_command_fsm::return_value): Rename from
9745         finish_command_fsm_return_value.
9746         (finish_command_fsm::do_async_reply_reason): Rename from
9747         finish_command_fsm_async_reply_reason.
9748         (finish_command): Update.
9749         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9750         Add constructor.
9751         (call_thread_fsm_ops): Remove.
9752         (call_thread_fsm::call_thread_fsm): Rename from
9753         new_call_thread_fsm.
9754         (call_thread_fsm::should_stop): Rename from
9755         call_thread_fsm_should_stop.
9756         (call_thread_fsm::should_notify_stop): Rename from
9757         call_thread_fsm_should_notify_stop.
9758         (run_inferior_call, call_function_by_hand_dummy): Update.
9759         * cli/cli-interp.c (should_print_stop_to_console): Update.
9760         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9761         Add constructor.  Change type of location_breakpoint,
9762         caller_breakpoint.
9763         (until_break_fsm_ops): Remove.
9764         (new_until_break_fsm): Remove.
9765         (until_break_fsm::should_stop): Rename from
9766         until_break_fsm_should_stop.
9767         (until_break_fsm::clean_up): Rename from
9768         until_break_fsm_clean_up.
9769         (until_break_fsm::do_async_reply_reason): Rename from
9770         until_break_fsm_async_reply_reason.
9771         (until_break_command): Update.
9772         * thread-fsm.c: Remove.
9773         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9774
9775 2019-02-07  Tom Tromey  <tom@tromey.com>
9776
9777         * yy-remap.h: Add include guard.
9778         * xtensa-tdep.h: Add include guard.
9779         * xcoffread.h: Rename include guard.
9780         * varobj-iter.h: Add include guard.
9781         * tui/tui.h: Rename include guard.
9782         * tui/tui-winsource.h: Rename include guard.
9783         * tui/tui-wingeneral.h: Rename include guard.
9784         * tui/tui-windata.h: Rename include guard.
9785         * tui/tui-win.h: Rename include guard.
9786         * tui/tui-stack.h: Rename include guard.
9787         * tui/tui-source.h: Rename include guard.
9788         * tui/tui-regs.h: Rename include guard.
9789         * tui/tui-out.h: Rename include guard.
9790         * tui/tui-layout.h: Rename include guard.
9791         * tui/tui-io.h: Rename include guard.
9792         * tui/tui-hooks.h: Rename include guard.
9793         * tui/tui-file.h: Rename include guard.
9794         * tui/tui-disasm.h: Rename include guard.
9795         * tui/tui-data.h: Rename include guard.
9796         * tui/tui-command.h: Rename include guard.
9797         * tic6x-tdep.h: Add include guard.
9798         * target/waitstatus.h: Rename include guard.
9799         * target/wait.h: Rename include guard.
9800         * target/target.h: Rename include guard.
9801         * target/resume.h: Rename include guard.
9802         * target-float.h: Rename include guard.
9803         * stabsread.h: Add include guard.
9804         * rs6000-tdep.h: Add include guard.
9805         * riscv-fbsd-tdep.h: Add include guard.
9806         * regformats/regdef.h: Rename include guard.
9807         * record.h: Rename include guard.
9808         * python/python.h: Rename include guard.
9809         * python/python-internal.h: Rename include guard.
9810         * python/py-stopevent.h: Rename include guard.
9811         * python/py-ref.h: Rename include guard.
9812         * python/py-record.h: Rename include guard.
9813         * python/py-record-full.h: Rename include guard.
9814         * python/py-record-btrace.h: Rename include guard.
9815         * python/py-instruction.h: Rename include guard.
9816         * python/py-events.h: Rename include guard.
9817         * python/py-event.h: Rename include guard.
9818         * procfs.h: Add include guard.
9819         * proc-utils.h: Add include guard.
9820         * p-lang.h: Add include guard.
9821         * or1k-tdep.h: Rename include guard.
9822         * observable.h: Rename include guard.
9823         * nto-tdep.h: Rename include guard.
9824         * nat/x86-linux.h: Rename include guard.
9825         * nat/x86-linux-dregs.h: Rename include guard.
9826         * nat/x86-gcc-cpuid.h: Add include guard.
9827         * nat/x86-dregs.h: Rename include guard.
9828         * nat/x86-cpuid.h: Rename include guard.
9829         * nat/ppc-linux.h: Rename include guard.
9830         * nat/mips-linux-watch.h: Rename include guard.
9831         * nat/linux-waitpid.h: Rename include guard.
9832         * nat/linux-ptrace.h: Rename include guard.
9833         * nat/linux-procfs.h: Rename include guard.
9834         * nat/linux-osdata.h: Rename include guard.
9835         * nat/linux-nat.h: Rename include guard.
9836         * nat/linux-namespaces.h: Rename include guard.
9837         * nat/linux-btrace.h: Rename include guard.
9838         * nat/glibc_thread_db.h: Rename include guard.
9839         * nat/gdb_thread_db.h: Rename include guard.
9840         * nat/gdb_ptrace.h: Rename include guard.
9841         * nat/fork-inferior.h: Rename include guard.
9842         * nat/amd64-linux-siginfo.h: Rename include guard.
9843         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9844         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9845         * nat/aarch64-linux.h: Rename include guard.
9846         * nat/aarch64-linux-hw-point.h: Rename include guard.
9847         * mn10300-tdep.h: Add include guard.
9848         * mips-linux-tdep.h: Add include guard.
9849         * mi/mi-parse.h: Rename include guard.
9850         * mi/mi-out.h: Rename include guard.
9851         * mi/mi-main.h: Rename include guard.
9852         * mi/mi-interp.h: Rename include guard.
9853         * mi/mi-getopt.h: Rename include guard.
9854         * mi/mi-console.h: Rename include guard.
9855         * mi/mi-common.h: Rename include guard.
9856         * mi/mi-cmds.h: Rename include guard.
9857         * mi/mi-cmd-break.h: Rename include guard.
9858         * m2-lang.h: Add include guard.
9859         * location.h: Rename include guard.
9860         * linux-record.h: Rename include guard.
9861         * linux-nat.h: Add include guard.
9862         * linux-fork.h: Add include guard.
9863         * i386-darwin-tdep.h: Rename include guard.
9864         * hppa-linux-offsets.h: Add include guard.
9865         * guile/guile.h: Rename include guard.
9866         * guile/guile-internal.h: Rename include guard.
9867         * gnu-nat.h: Rename include guard.
9868         * gdb-stabs.h: Rename include guard.
9869         * frv-tdep.h: Add include guard.
9870         * f-lang.h: Add include guard.
9871         * event-loop.h: Add include guard.
9872         * darwin-nat.h: Rename include guard.
9873         * cp-abi.h: Rename include guard.
9874         * config/sparc/nm-sol2.h: Rename include guard.
9875         * config/nm-nto.h: Rename include guard.
9876         * config/nm-linux.h: Add include guard.
9877         * config/i386/nm-i386gnu.h: Rename include guard.
9878         * config/djgpp/nl_types.h: Rename include guard.
9879         * config/djgpp/langinfo.h: Rename include guard.
9880         * compile/gcc-cp-plugin.h: Add include guard.
9881         * compile/gcc-c-plugin.h: Add include guard.
9882         * compile/compile.h: Rename include guard.
9883         * compile/compile-object-run.h: Rename include guard.
9884         * compile/compile-object-load.h: Rename include guard.
9885         * compile/compile-internal.h: Rename include guard.
9886         * compile/compile-cplus.h: Rename include guard.
9887         * compile/compile-c.h: Rename include guard.
9888         * common/xml-utils.h: Rename include guard.
9889         * common/x86-xstate.h: Rename include guard.
9890         * common/version.h: Rename include guard.
9891         * common/vec.h: Rename include guard.
9892         * common/tdesc.h: Rename include guard.
9893         * common/selftest.h: Rename include guard.
9894         * common/scoped_restore.h: Rename include guard.
9895         * common/scoped_mmap.h: Rename include guard.
9896         * common/scoped_fd.h: Rename include guard.
9897         * common/safe-iterator.h: Rename include guard.
9898         * common/run-time-clock.h: Rename include guard.
9899         * common/refcounted-object.h: Rename include guard.
9900         * common/queue.h: Rename include guard.
9901         * common/ptid.h: Rename include guard.
9902         * common/print-utils.h: Rename include guard.
9903         * common/preprocessor.h: Rename include guard.
9904         * common/pathstuff.h: Rename include guard.
9905         * common/observable.h: Rename include guard.
9906         * common/netstuff.h: Rename include guard.
9907         * common/job-control.h: Rename include guard.
9908         * common/host-defs.h: Rename include guard.
9909         * common/gdb_wait.h: Rename include guard.
9910         * common/gdb_vecs.h: Rename include guard.
9911         * common/gdb_unlinker.h: Rename include guard.
9912         * common/gdb_unique_ptr.h: Rename include guard.
9913         * common/gdb_tilde_expand.h: Rename include guard.
9914         * common/gdb_sys_time.h: Rename include guard.
9915         * common/gdb_string_view.h: Rename include guard.
9916         * common/gdb_splay_tree.h: Rename include guard.
9917         * common/gdb_setjmp.h: Rename include guard.
9918         * common/gdb_ref_ptr.h: Rename include guard.
9919         * common/gdb_optional.h: Rename include guard.
9920         * common/gdb_locale.h: Rename include guard.
9921         * common/gdb_assert.h: Rename include guard.
9922         * common/filtered-iterator.h: Rename include guard.
9923         * common/filestuff.h: Rename include guard.
9924         * common/fileio.h: Rename include guard.
9925         * common/environ.h: Rename include guard.
9926         * common/common-utils.h: Rename include guard.
9927         * common/common-types.h: Rename include guard.
9928         * common/common-regcache.h: Rename include guard.
9929         * common/common-inferior.h: Rename include guard.
9930         * common/common-gdbthread.h: Rename include guard.
9931         * common/common-exceptions.h: Rename include guard.
9932         * common/common-defs.h: Rename include guard.
9933         * common/common-debug.h: Rename include guard.
9934         * common/cleanups.h: Rename include guard.
9935         * common/buffer.h: Rename include guard.
9936         * common/btrace-common.h: Rename include guard.
9937         * common/break-common.h: Rename include guard.
9938         * cli/cli-utils.h: Rename include guard.
9939         * cli/cli-style.h: Rename include guard.
9940         * cli/cli-setshow.h: Rename include guard.
9941         * cli/cli-script.h: Rename include guard.
9942         * cli/cli-interp.h: Rename include guard.
9943         * cli/cli-decode.h: Rename include guard.
9944         * cli/cli-cmds.h: Rename include guard.
9945         * charset-list.h: Add include guard.
9946         * buildsym-legacy.h: Rename include guard.
9947         * bfin-tdep.h: Add include guard.
9948         * ax.h: Rename include guard.
9949         * arm-linux-tdep.h: Add include guard.
9950         * arm-fbsd-tdep.h: Add include guard.
9951         * arch/xtensa.h: Rename include guard.
9952         * arch/tic6x.h: Add include guard.
9953         * arch/i386.h: Add include guard.
9954         * arch/arm.h: Rename include guard.
9955         * arch/arm-linux.h: Rename include guard.
9956         * arch/arm-get-next-pcs.h: Rename include guard.
9957         * arch/amd64.h: Add include guard.
9958         * arch/aarch64-insn.h: Rename include guard.
9959         * arch-utils.h: Rename include guard.
9960         * annotate.h: Add include guard.
9961         * amd64-darwin-tdep.h: Rename include guard.
9962         * aarch64-linux-tdep.h: Add include guard.
9963         * aarch64-fbsd-tdep.h: Add include guard.
9964         * aarch32-linux-nat.h: Add include guard.
9965
9966 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9967
9968         * macrotab.c (macro_define_internal): New function that
9969         factorizes macro_define_object_internal and macro_define_function
9970         code.
9971         (macro_define_object_internal): Use macro_define_internal.
9972         (macro_define_function): Likewise.
9973
9974 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9975
9976         * macrocmd.c (extract_identifier): Return
9977         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9978         callers.
9979
9980 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9981
9982         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9983
9984 2019-02-05  Tom Tromey  <tom@tromey.com>
9985
9986         * target.c (target_stack::unpush): Move assertion earlier.
9987
9988 2019-01-30  Tom Tromey  <tom@tromey.com>
9989
9990         PR python/23615:
9991         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9992         (gdbpy_parse_and_eval): Likewise.
9993         * python/python-internal.h (gdbpy_allow_threads): New class.
9994
9995 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9996
9997         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9998         (aarch64_fbsd_fpregmap): Move earlier.
9999         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10000         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10001         instead of individual calls to trad_frame_set_reg_addr.
10002         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10003         earlier.
10004         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10005         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10006         instead of individual calls to trad_frame_set_reg_addr.
10007
10008 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10009
10010         * CONTRIBUTE: Replace contribution list with wiki link.
10011
10012 2019-01-25  Tom Tromey  <tom@tromey.com>
10013
10014         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10015
10016 2019-01-25  Tom Tromey  <tom@tromey.com>
10017
10018         * xtensa-linux-nat.c: Fix common/ includes.
10019         * xml-support.h: Fix common/ includes.
10020         * xml-support.c: Fix common/ includes.
10021         * x86-linux-nat.c: Fix common/ includes.
10022         * windows-nat.c: Fix common/ includes.
10023         * varobj.h: Fix common/ includes.
10024         * varobj.c: Fix common/ includes.
10025         * value.c: Fix common/ includes.
10026         * valops.c: Fix common/ includes.
10027         * utils.c: Fix common/ includes.
10028         * unittests/xml-utils-selftests.c: Fix common/ includes.
10029         * unittests/utils-selftests.c: Fix common/ includes.
10030         * unittests/unpack-selftests.c: Fix common/ includes.
10031         * unittests/tracepoint-selftests.c: Fix common/ includes.
10032         * unittests/style-selftests.c: Fix common/ includes.
10033         * unittests/string_view-selftests.c: Fix common/ includes.
10034         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10035         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10036         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10037         * unittests/rsp-low-selftests.c: Fix common/ includes.
10038         * unittests/parse-connection-spec-selftests.c: Fix common/
10039         includes.
10040         * unittests/optional-selftests.c: Fix common/ includes.
10041         * unittests/offset-type-selftests.c: Fix common/ includes.
10042         * unittests/observable-selftests.c: Fix common/ includes.
10043         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10044         * unittests/memrange-selftests.c: Fix common/ includes.
10045         * unittests/memory-map-selftests.c: Fix common/ includes.
10046         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10047         * unittests/function-view-selftests.c: Fix common/ includes.
10048         * unittests/environ-selftests.c: Fix common/ includes.
10049         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10050         * unittests/common-utils-selftests.c: Fix common/ includes.
10051         * unittests/cli-utils-selftests.c: Fix common/ includes.
10052         * unittests/array-view-selftests.c: Fix common/ includes.
10053         * ui-file.c: Fix common/ includes.
10054         * tui/tui-io.c: Fix common/ includes.
10055         * tracepoint.h: Fix common/ includes.
10056         * tracepoint.c: Fix common/ includes.
10057         * tracefile-tfile.c: Fix common/ includes.
10058         * top.h: Fix common/ includes.
10059         * top.c: Fix common/ includes.
10060         * thread.c: Fix common/ includes.
10061         * target/waitstatus.h: Fix common/ includes.
10062         * target/waitstatus.c: Fix common/ includes.
10063         * target.h: Fix common/ includes.
10064         * target.c: Fix common/ includes.
10065         * target-memory.c: Fix common/ includes.
10066         * target-descriptions.c: Fix common/ includes.
10067         * symtab.h: Fix common/ includes.
10068         * symfile.c: Fix common/ includes.
10069         * stap-probe.c: Fix common/ includes.
10070         * spu-linux-nat.c: Fix common/ includes.
10071         * sparc-nat.c: Fix common/ includes.
10072         * source.c: Fix common/ includes.
10073         * solib.c: Fix common/ includes.
10074         * solib-target.c: Fix common/ includes.
10075         * ser-unix.c: Fix common/ includes.
10076         * ser-tcp.c: Fix common/ includes.
10077         * ser-pipe.c: Fix common/ includes.
10078         * ser-base.c: Fix common/ includes.
10079         * selftest-arch.c: Fix common/ includes.
10080         * s12z-tdep.c: Fix common/ includes.
10081         * rust-exp.y: Fix common/ includes.
10082         * rs6000-aix-tdep.c: Fix common/ includes.
10083         * riscv-tdep.c: Fix common/ includes.
10084         * remote.c: Fix common/ includes.
10085         * remote-notif.h: Fix common/ includes.
10086         * remote-fileio.h: Fix common/ includes.
10087         * remote-fileio.c: Fix common/ includes.
10088         * regcache.h: Fix common/ includes.
10089         * regcache.c: Fix common/ includes.
10090         * record-btrace.c: Fix common/ includes.
10091         * python/python.c: Fix common/ includes.
10092         * python/py-type.c: Fix common/ includes.
10093         * python/py-inferior.c: Fix common/ includes.
10094         * progspace.h: Fix common/ includes.
10095         * producer.c: Fix common/ includes.
10096         * procfs.c: Fix common/ includes.
10097         * proc-api.c: Fix common/ includes.
10098         * printcmd.c: Fix common/ includes.
10099         * ppc-linux-nat.c: Fix common/ includes.
10100         * parser-defs.h: Fix common/ includes.
10101         * osdata.c: Fix common/ includes.
10102         * obsd-nat.c: Fix common/ includes.
10103         * nat/x86-linux.c: Fix common/ includes.
10104         * nat/x86-linux-dregs.c: Fix common/ includes.
10105         * nat/x86-dregs.h: Fix common/ includes.
10106         * nat/x86-dregs.c: Fix common/ includes.
10107         * nat/ppc-linux.c: Fix common/ includes.
10108         * nat/mips-linux-watch.h: Fix common/ includes.
10109         * nat/mips-linux-watch.c: Fix common/ includes.
10110         * nat/linux-waitpid.c: Fix common/ includes.
10111         * nat/linux-ptrace.h: Fix common/ includes.
10112         * nat/linux-ptrace.c: Fix common/ includes.
10113         * nat/linux-procfs.c: Fix common/ includes.
10114         * nat/linux-personality.c: Fix common/ includes.
10115         * nat/linux-osdata.c: Fix common/ includes.
10116         * nat/linux-namespaces.c: Fix common/ includes.
10117         * nat/linux-btrace.h: Fix common/ includes.
10118         * nat/linux-btrace.c: Fix common/ includes.
10119         * nat/fork-inferior.c: Fix common/ includes.
10120         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10121         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10122         * nat/aarch64-linux.c: Fix common/ includes.
10123         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10124         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10125         * namespace.h: Fix common/ includes.
10126         * mips-linux-tdep.c: Fix common/ includes.
10127         * minsyms.c: Fix common/ includes.
10128         * mi/mi-parse.h: Fix common/ includes.
10129         * mi/mi-main.c: Fix common/ includes.
10130         * mi/mi-cmd-env.c: Fix common/ includes.
10131         * memrange.h: Fix common/ includes.
10132         * memattr.c: Fix common/ includes.
10133         * maint.h: Fix common/ includes.
10134         * maint.c: Fix common/ includes.
10135         * main.c: Fix common/ includes.
10136         * machoread.c: Fix common/ includes.
10137         * location.c: Fix common/ includes.
10138         * linux-thread-db.c: Fix common/ includes.
10139         * linux-nat.c: Fix common/ includes.
10140         * linux-fork.c: Fix common/ includes.
10141         * inline-frame.c: Fix common/ includes.
10142         * infrun.c: Fix common/ includes.
10143         * inflow.c: Fix common/ includes.
10144         * inferior.h: Fix common/ includes.
10145         * inferior.c: Fix common/ includes.
10146         * infcmd.c: Fix common/ includes.
10147         * inf-ptrace.c: Fix common/ includes.
10148         * inf-child.c: Fix common/ includes.
10149         * ia64-linux-nat.c: Fix common/ includes.
10150         * i387-tdep.c: Fix common/ includes.
10151         * i386-tdep.c: Fix common/ includes.
10152         * i386-linux-tdep.c: Fix common/ includes.
10153         * i386-linux-nat.c: Fix common/ includes.
10154         * i386-go32-tdep.c: Fix common/ includes.
10155         * i386-fbsd-tdep.c: Fix common/ includes.
10156         * i386-fbsd-nat.c: Fix common/ includes.
10157         * guile/scm-type.c: Fix common/ includes.
10158         * guile/guile.c: Fix common/ includes.
10159         * go32-nat.c: Fix common/ includes.
10160         * gnu-nat.c: Fix common/ includes.
10161         * gdbthread.h: Fix common/ includes.
10162         * gdbarch-selftests.c: Fix common/ includes.
10163         * gdb_usleep.c: Fix common/ includes.
10164         * gdb_select.h: Fix common/ includes.
10165         * gdb_bfd.c: Fix common/ includes.
10166         * gcore.c: Fix common/ includes.
10167         * fork-child.c: Fix common/ includes.
10168         * findvar.c: Fix common/ includes.
10169         * fbsd-nat.c: Fix common/ includes.
10170         * event-top.c: Fix common/ includes.
10171         * event-loop.c: Fix common/ includes.
10172         * dwarf2read.c: Fix common/ includes.
10173         * dwarf2loc.c: Fix common/ includes.
10174         * dwarf2-frame.c: Fix common/ includes.
10175         * dwarf-index-cache.c: Fix common/ includes.
10176         * dtrace-probe.c: Fix common/ includes.
10177         * disasm-selftests.c: Fix common/ includes.
10178         * defs.h: Fix common/ includes.
10179         * csky-tdep.c: Fix common/ includes.
10180         * cp-valprint.c: Fix common/ includes.
10181         * cp-support.h: Fix common/ includes.
10182         * cp-support.c: Fix common/ includes.
10183         * corelow.c: Fix common/ includes.
10184         * completer.h: Fix common/ includes.
10185         * completer.c: Fix common/ includes.
10186         * compile/compile.c: Fix common/ includes.
10187         * compile/compile-loc2c.c: Fix common/ includes.
10188         * compile/compile-cplus-types.c: Fix common/ includes.
10189         * compile/compile-cplus-symbols.c: Fix common/ includes.
10190         * command.h: Fix common/ includes.
10191         * cli/cli-dump.c: Fix common/ includes.
10192         * cli/cli-cmds.c: Fix common/ includes.
10193         * charset.c: Fix common/ includes.
10194         * build-id.c: Fix common/ includes.
10195         * btrace.h: Fix common/ includes.
10196         * btrace.c: Fix common/ includes.
10197         * breakpoint.h: Fix common/ includes.
10198         * breakpoint.c: Fix common/ includes.
10199         * ax.h:
10200         (enum agent_op): Fix common/ includes.
10201         * ax-general.c (struct aop_map): Fix common/ includes.
10202         * ax-gdb.c: Fix common/ includes.
10203         * auxv.c: Fix common/ includes.
10204         * auto-load.c: Fix common/ includes.
10205         * arm-tdep.c: Fix common/ includes.
10206         * arch/riscv.c: Fix common/ includes.
10207         * arch/ppc-linux-common.c: Fix common/ includes.
10208         * arch/i386.c: Fix common/ includes.
10209         * arch/arm.c: Fix common/ includes.
10210         * arch/arm-linux.c: Fix common/ includes.
10211         * arch/arm-get-next-pcs.c: Fix common/ includes.
10212         * arch/amd64.c: Fix common/ includes.
10213         * arch/aarch64.c: Fix common/ includes.
10214         * arch/aarch64-insn.c: Fix common/ includes.
10215         * arch-utils.c: Fix common/ includes.
10216         * amd64-windows-tdep.c: Fix common/ includes.
10217         * amd64-tdep.c: Fix common/ includes.
10218         * amd64-sol2-tdep.c: Fix common/ includes.
10219         * amd64-obsd-tdep.c: Fix common/ includes.
10220         * amd64-nbsd-tdep.c: Fix common/ includes.
10221         * amd64-linux-tdep.c: Fix common/ includes.
10222         * amd64-linux-nat.c: Fix common/ includes.
10223         * amd64-fbsd-tdep.c: Fix common/ includes.
10224         * amd64-fbsd-nat.c: Fix common/ includes.
10225         * amd64-dicos-tdep.c: Fix common/ includes.
10226         * amd64-darwin-tdep.c: Fix common/ includes.
10227         * agent.c: Fix common/ includes.
10228         * ada-lang.h: Fix common/ includes.
10229         * ada-lang.c: Fix common/ includes.
10230         * aarch64-tdep.c: Fix common/ includes.
10231
10232 2019-01-25  Tom Tromey  <tom@tromey.com>
10233
10234         * common/create-version.sh: Use common/version.h.
10235
10236 2019-01-24  Pedro Alves  <palves@redhat.com>
10237
10238         * infrun.c (signal_stop, signal_print, signal_program)
10239         (signal_catch, signal_pass): Now arrays instead of pointers.
10240         (update_signals_program_target, do_target_resume)
10241         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10242         * linux-nat.c (linux_nat_target::pass_signals)
10243         (linux_nat_target::create_inferior, linux_nat_target::attach):
10244         Adjust.
10245         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10246         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10247         * procfs.c (procfs_target::pass_signals): Adjust.
10248         * record-full.c (record_full_target::resume): Adjust.
10249         * remote.c (remote_target::pass_signals)
10250         (remote_target::program_signals): Adjust.
10251         * target-debug.h (target_debug_print_signals): Now takes a
10252         gdb::array_view as parameter.  Adjust.
10253         * target.h (target_ops) <pass_signals, program_signals>: Replace
10254         pointer and length parameters with gdb::array_view.
10255         (target_pass_signals, target_program_signals): Likewise.
10256         * target-delegates.c: Regenerate.
10257
10258 2019-01-24  Pedro Alves  <palves@redhat.com>
10259
10260         * common/forward-scope-exit.h
10261         (forward_scope_exit::forward_scope_exit): Pass arguments to
10262         m_bind_function directly, instead of creating a std::bind and
10263         copying that.
10264
10265 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10266
10267         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10268         for static members.
10269         (pass_in_v_vfp_candidate): Likewise.
10270
10271 2019-01-23  Tom Tromey  <tom@tromey.com>
10272             Pedro Alves  <palves@redhat.com>
10273
10274         * regcache.c (class regcache_invalidator): Remove.
10275         (regcache::raw_write): Use make_scope_exit.
10276
10277 2019-01-23  Tom Tromey  <tom@tromey.com>
10278
10279         * ui-out.h (class ui_out_emit_type): Update comment.
10280
10281 2019-01-23  Tom Tromey  <tom@tromey.com>
10282
10283         * infrun.c (fetch_inferior_event): Update comment.
10284
10285 2019-01-23  Tom Tromey  <tom@tromey.com>
10286             Pedro Alves  <palves@redhat.com>
10287
10288         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10289         parameter.
10290         (fetch_inferior_event): Use SCOPE_EXIT.
10291
10292
10293 2019-01-23  Tom Tromey  <tom@tromey.com>
10294             Pedro Alves  <palves@redhat.com>
10295
10296         * infrun.c (disable_thread_events): Delete.
10297         (stop_all_threads): Use SCOPE_EXIT.
10298
10299 2019-01-23  Tom Tromey  <tom@tromey.com>
10300             Pedro Alves  <palves@redhat.com>
10301
10302         * symfile.c: Include forward-scope-exit.h.
10303         (clear_symtab_users_cleanup): Replace forward declaration with
10304         a FORWARD_SCOPE_EXIT.
10305         (syms_from_objfile_1): Use the forward_scope_exit and
10306         gdb::optional instead of cleanup_function.
10307         (reread_symbols): Use the forward_scope_exit instead of
10308         cleanup_function.
10309         (clear_symtab_users_cleanup): Remove function.
10310
10311 2019-01-23  Tom Tromey  <tom@tromey.com>
10312             Pedro Alves  <palves@redhat.com>
10313
10314         * linux-nat.c: Include scope-exit.h.
10315         (cleanup_target_stop): Remove.
10316         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10317         SCOPE_EXIT.
10318
10319 2019-01-23  Tom Tromey  <tom@tromey.com>
10320             Pedro Alves  <palves@redhat.com>
10321
10322         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10323         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10324
10325 2019-01-23  Tom Tromey  <tom@tromey.com>
10326             Andrew Burgess  <andrew.burgess@embecosm.com>
10327             Pedro Alves  <palves@redhat.com>
10328
10329         * infrun.c (fetch_inferior_event): Use scope_exit.
10330         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10331         * top.c (execute_command): Use scope_exit.
10332         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10333         * utils.c (do_bpstat_clear_actions_cleanup)
10334         (make_bpstat_clear_actions_cleanup): Remove.
10335
10336 2019-01-23  Tom Tromey  <tom@tromey.com>
10337             Pedro Alves  <palves@redhat.com>
10338
10339         * infrun.c: Include "common/scope-exit.h"
10340         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10341         (wait_for_inferior): Use SCOPE_EXIT.
10342         (fetch_inferior_event): Use scope_exit.
10343
10344 2019-01-23  Tom Tromey  <tom@tromey.com>
10345             Pedro Alves  <palves@redhat.com>
10346
10347         * breakpoint.c (create_breakpoint): Remove cleanup.
10348
10349 2019-01-23  Tom Tromey  <tom@tromey.com>
10350             Andrew Burgess  <andrew.burgess@embecosm.com>
10351             Pedro Alves  <palves@redhat.com>
10352
10353 2019-01-23  Pedro Alves  <palves@redhat.com>
10354
10355         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10356
10357 2019-01-23  Pedro Alves  <palves@redhat.com>
10358             Andrew Burgess  <andrew.burgess@embecosm.com>
10359
10360         * gdbthread.h: Include "common/forward-scope-exit.h".
10361         (scoped_finish_thread_state): Redefine custom class in terms of
10362         forward_scope_exit.
10363
10364 2019-01-23  Pedro Alves  <palves@redhat.com>
10365             Andrew Burgess  <andrew.burgess@embecosm.com>
10366
10367         * common/forward-scope-exit.h: New file.
10368
10369 2019-01-23  Pedro Alves  <palves@redhat.com>
10370             Andrew Burgess  <andrew.burgess@embecosm.com>
10371             Tom Tromey  <tom@tromey.com>
10372
10373         * common/scope-exit.h: New file.
10374
10375 2019-01-23  Pedro Alves  <palves@redhat.com>
10376
10377         * common/preprocessor.h (ESC): Rename to ...
10378         (ESC_PARENS): ... this.
10379         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10380         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10381
10382 2019-01-23  Tom Tromey  <tom@tromey.com>
10383
10384         * language.h (class scoped_switch_to_sym_language_if_auto):
10385         Initialize m_lang in both cases.
10386
10387 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10388
10389         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10390         with XCNEW.
10391
10392 2019-01-22  Tom Tromey  <tom@tromey.com>
10393
10394         * corelow.c: Do not include sys/file.h.
10395
10396 2019-01-22  Tom Tromey  <tom@tromey.com>
10397
10398         * tui/tui-wingeneral.h: Include gdb_curses.h.
10399
10400 2019-01-22  Tom Tromey  <tom@tromey.com>
10401
10402         * source-cache.h (class source_cache) <get_source_lines,
10403         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10404
10405 2019-01-22  Tom Tromey  <tom@tromey.com>
10406
10407         * remote-fileio.h (struct remote_target): Declare.
10408
10409 2019-01-22  Tom Tromey  <tom@tromey.com>
10410
10411         * python/py-arch.c: Do not include py-ref.h.
10412         * python/py-bpevent.c: Do not include py-ref.h.
10413         * python/py-cmd.c: Do not include py-ref.h.
10414         * python/py-continueevent.c: Do not include py-ref.h.
10415         * python/py-event.h: Do not include py-ref.h.
10416         * python/py-evtregistry.c: Do not include py-ref.h.
10417         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10418         * python/py-frame.c: Do not include py-ref.h.
10419         * python/py-framefilter.c: Do not include py-ref.h.
10420         * python/py-function.c: Do not include py-ref.h.
10421         * python/py-infevents.c: Do not include py-ref.h.
10422         * python/py-linetable.c: Do not include py-ref.h.
10423         * python/py-objfile.c: Do not include py-ref.h.
10424         * python/py-param.c: Do not include py-ref.h.
10425         * python/py-prettyprint.c: Do not include py-ref.h.
10426         * python/py-progspace.c: Do not include py-ref.h.
10427         * python/py-symbol.c: Do not include py-ref.h.
10428         * python/py-symtab.c: Do not include py-ref.h.
10429         * python/py-type.c: Do not include py-ref.h.
10430         * python/py-unwind.c: Do not include py-ref.h.
10431         * python/py-utils.c: Do not include py-ref.h.
10432         * python/py-value.c: Do not include py-ref.h.
10433         * python/py-varobj.c: Do not include py-ref.h.
10434         * python/py-xmethods.c: Do not include py-ref.h.
10435         * python/python.c: Do not include py-ref.h.
10436         * varobj.c: Do not include py-ref.h.
10437
10438 2019-01-22  Tom Tromey  <tom@tromey.com>
10439
10440         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10441         keyword for bcache.
10442
10443 2019-01-22  Tom Tromey  <tom@tromey.com>
10444
10445         * compile/compile-cplus-types.c: Remove a comment by #include.
10446
10447 2019-01-22  Tom Tromey  <tom@tromey.com>
10448
10449         * compile/gcc-c-plugin.h: Include compile-internal.h.
10450
10451 2019-01-22  Tom Tromey  <tom@tromey.com>
10452
10453         * stabsread.c (EXTERN): Do not define.
10454         (symnum, next_symbol_text_func, processing_gcc_compilation)
10455         (within_function, global_sym_chain, global_stabs)
10456         (previous_stab_code, this_object_header_files)
10457         (n_this_object_header_files)
10458         (n_allocated_this_object_header_files): Define.
10459         * stabsread.h (EXTERN): Never define.  Use "extern".
10460
10461 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10462
10463         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10464         history_value.
10465
10466 2019-01-21  Tom Tromey  <tom@tromey.com>
10467
10468         * ui-out.c: Fix includes.
10469         * tui/tui-source.c: Fix includes.
10470         * target.c: Fix includes.
10471         * remote.c: Fix includes.
10472         * regcache.c: Fix includes.
10473         * python/py-block.c: Fix includes.
10474         * printcmd.c: Fix includes.
10475         * or1k-tdep.c: Fix includes.
10476         * mi/mi-main.c: Fix includes.
10477         * m32r-tdep.c: Fix includes.
10478         * csky-tdep.c: Fix includes.
10479         * compile/compile-cplus-types.c: Fix includes.
10480         * cli/cli-interp.c: Fix includes.
10481
10482 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10483
10484         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10485         for padding.
10486
10487 2019-01-16  Tom Tromey  <tom@tromey.com>
10488
10489         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10490         earlier.
10491         (struct objfile) <msymbols_range>: Move from top level.
10492         <msymbols>: New method.
10493         (class objfile_msymbols): Remove.
10494         * symtab.c (default_collect_symbol_completion_matches_break_on):
10495         Update.
10496         * symmisc.c (dump_msymbols): Update.
10497         * stabsread.c (scan_file_globals): Update.
10498         * objc-lang.c (info_selectors_command, info_classes_command)
10499         (find_methods): Update.
10500         * minsyms.c (find_solib_trampoline_target): Update.
10501         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10502         * coffread.c (coff_symfile_read): Update.
10503         * ada-lang.c (ada_lookup_simple_minsym)
10504         (ada_collect_symbol_completion_matches): Update.
10505
10506 2019-01-16  Tom Tromey  <tom@tromey.com>
10507
10508         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10509         type.  Remove no-argument constructor.
10510         <iterator::operator++>: Simplify.
10511         <begin>: Update.
10512         <end>: Use minimal_symbol_count.
10513
10514 2019-01-16  Tom Tromey  <tom@tromey.com>
10515
10516         * objfiles.h (struct objfile) <psymtabs>: New method.
10517         (class objfile_psymtabs): Remove.
10518         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10519         typedef.
10520         <range>: New method.
10521         (require_partial_symbols): Change return type.
10522         * psymtab.c (require_partial_symbols)
10523         (psym_expand_symtabs_matching): Update.
10524         * mdebugread.c (parse_partial_symbols): Update.
10525         * dbxread.c (dbx_end_psymtab): Update.
10526
10527 2019-01-15  Tom Tromey  <tom@tromey.com>
10528
10529         * symtab.c (lookup_objfile_from_block)
10530         (lookup_symbol_in_objfile_symtabs)
10531         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10532         (find_line_symtab, info_sources_command)
10533         (default_collect_symbol_completion_matches_break_on)
10534         (make_source_files_completion_list): Update.
10535         * symmisc.c (print_objfile_statistics, dump_objfile)
10536         (maintenance_print_symbols, maintenance_info_symtabs)
10537         (maintenance_check_symtabs, maintenance_info_line_tables):
10538         Update.
10539         * source.c (select_source_symtab)
10540         (forget_cached_source_info_for_objfile): Update.
10541         * objfiles.h (class objfile_compunits): Remove.
10542         (struct objfile) <compunits_range>: New typedef.
10543         (compunits): New method.
10544         * objfiles.c (objfile_relocate1): Update.
10545         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10546         * maint.c (count_symtabs_and_blocks): Update.
10547         * linespec.c (iterate_over_all_matching_symtabs): Update.
10548         * cp-support.c (add_symbol_overload_list_qualified): Update.
10549         * coffread.c (coff_symtab_read): Update.
10550         * ada-lang.c (add_nonlocal_symbols)
10551         (ada_collect_symbol_completion_matches)
10552         (ada_add_global_exceptions): Update.
10553
10554 2019-01-15  Tom Tromey  <tom@tromey.com>
10555
10556         * progspace.h (program_space) <objfiles_safe_range>: New
10557         typedef.
10558         <objfiles_safe>: New method.
10559         * objfiles.h (class all_objfiles_safe): Remove.
10560         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10561         * jit.c (jit_inferior_exit_hook): Update.
10562
10563 2019-01-17  Tom Tromey  <tom@tromey.com>
10564
10565         * progspace.h (program_space) <objfiles_range>: New typedef.
10566         <objfiles>: New method.
10567         <objfiles_head>: Rename from objfiles.
10568         (object_files): Update.
10569         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10570         * guile/scm-pretty-print.c
10571         (ppscm_find_pretty_printer_from_objfiles): Update.
10572         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10573         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10574         Update.
10575         * python/py-progspace.c (pspy_get_objfiles): Update.
10576         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10577         Update.
10578         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10579         (objfpy_lookup_objfile_by_build_id): Update.
10580         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10581         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10582         Update.
10583         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10584         (expand_symtab_containing_pc, lookup_objfile_from_block)
10585         (lookup_static_symbol, basic_lookup_transparent_type)
10586         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10587         (find_line_symtab, info_sources_command)
10588         (default_collect_symbol_completion_matches_break_on)
10589         (make_source_files_completion_list, find_main_name): Update.
10590         * symmisc.c (print_symbol_bcache_statistics)
10591         (print_objfile_statistics, maintenance_print_symbols)
10592         (maintenance_print_msymbols, maintenance_print_objfiles)
10593         (maintenance_info_symtabs, maintenance_check_symtabs)
10594         (maintenance_expand_symtabs, maintenance_info_line_tables):
10595         Update.
10596         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10597         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10598         (map_overlay_command, unmap_overlay_command)
10599         (simple_overlay_update, expand_symtabs_matching)
10600         (map_symbol_filenames): Update.
10601         * symfile-debug.c (set_debug_symfile): Update.
10602         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10603         Update.
10604         * source.c (select_source_symtab, forget_cached_source_info):
10605         Update.
10606         * solib.c (solib_read_symbols): Update.
10607         * solib-spu.c (append_ocl_sos): Update.
10608         * psymtab.c (maintenance_print_psymbols)
10609         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10610         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10611         * printcmd.c (info_symbol_command): Update.
10612         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10613         Update.
10614         * objfiles.h (class all_objfiles): Remove.
10615         * objfiles.c (have_partial_symbols, have_full_symbols)
10616         (have_minimal_symbols, qsort_cmp, update_section_map)
10617         (shared_objfile_contains_address_p)
10618         (default_iterate_over_objfiles_in_search_order): Update.
10619         * objc-lang.c (info_selectors_command, info_classes_command)
10620         (find_methods): Update.
10621         * minsyms.c (find_solib_trampoline_target): Update.
10622         * maint.c (maintenance_info_sections)
10623         (maintenance_translate_address, count_symtabs_and_blocks):
10624         Update.
10625         * main.c (captured_main_1): Update.
10626         * linux-thread-db.c (try_thread_db_load_from_pdir)
10627         (has_libpthread): Update.
10628         * linespec.c (iterate_over_all_matching_symtabs)
10629         (search_minsyms_for_name): Update.
10630         * jit.c (jit_find_objf_with_entry_addr): Update.
10631         * hppa-tdep.c (find_unwind_entry)
10632         (hppa_lookup_stub_minimal_symbol): Update.
10633         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10634         Update.
10635         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10636         (elf_gnu_ifunc_resolve_by_got): Update.
10637         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10638         * dwarf-index-write.c (save_gdb_index_command): Update.
10639         * cp-support.c (add_symbol_overload_list_qualified): Update.
10640         * breakpoint.c (create_overlay_event_breakpoint)
10641         (create_longjmp_master_breakpoint)
10642         (create_std_terminate_master_breakpoint)
10643         (create_exception_master_breakpoint): Update.
10644         * blockframe.c (find_pc_partial_function): Update.
10645         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10646         (ada_collect_symbol_completion_matches)
10647         (ada_add_global_exceptions): Update.
10648
10649 2019-01-17  Tom Tromey  <tom@tromey.com>
10650
10651         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10652         declare VEC.
10653         (solib_target_parse_libraries): Change return type.
10654         (library_list_start_segment, library_list_start_section)
10655         (library_list_end_library, library_list_start_library); Update.
10656         (solib_target_free_library_list): Remove.
10657         (solib_target_parse_libraries): Remove cleanup.  Change return
10658         type.
10659         (solib_target_current_sos): Update.
10660
10661 2019-01-17  Tom Tromey  <tromey@bapiya>
10662
10663         * valprint.c: Replace "the the" with "the".
10664         * symtab.c: Replace "the the" with "the".
10665         * solib.c: Replace "the the" with "the".
10666         * solib-dsbt.c: Replace "the the" with "the".
10667         * linespec.c: Replace "the the" with "the".
10668         * dwarf2loc.h: Replace "the the" with "the".
10669         * amd64-windows-tdep.c: Replace "the the" with "the".
10670         * aarch64-tdep.c: Replace "the the" with "the".
10671
10672 2019-01-16  Keith Seitz  <keiths@redhat.com>
10673
10674         PR gdb/23773
10675         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10676         <builder>: Rename to ..
10677         <m_builder>: ... this and make private.
10678         (dwarf2_cu::get_builder): New method.  Change all users of
10679         `builder' to use this method.
10680         (dwarf2_start_symtab): Move to ...
10681         (dwarf2_cu::start_symtab): ... here.  Update all callers
10682         (setup_type_unit_groups): Move to ...
10683         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10684         callers.
10685         (dwarf2_cu::reset_builder): New method.
10686         (process_full_compunit, process_full_type_unit): Use
10687         dwarf2_cu::reset_builder.
10688         (follow_die_offset): Record the ancestor CU if it is different
10689         from the followed DIE's CU.
10690         (follow_die_sig_1): Likewise.
10691
10692 2019-01-15  Tom Tromey  <tom@tromey.com>
10693
10694         * remote.c (class remote_state) <buf>: Now a char_vector.
10695         <buf_size>: Remove.
10696         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10697         parameter.
10698         (remote_target::getpkt_or_notif_sane_1)
10699         (remote_target::getpkt_sane)
10700         (remote_target::getpkt_or_notif_sane): Likewise.
10701         (class remote_target) <putpkt>: New overload.
10702         (remote_target::read_frame): Change type of "buf_p".  Remove
10703         sizeof_p parameter.
10704         (packet_ok): New overload.
10705         (packet_check_result): New overload.
10706         Update all uses.
10707
10708 2019-01-14  Tom Tromey  <tom@tromey.com>
10709
10710         * remote-notif.c (handle_notification, remote_notif_ack)
10711         (remote_notif_parse): Make "buf" const.
10712         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10713         const.
10714         (remote_notif_parse, remote_notif_ack, handle_notification):
10715         Likewise.
10716         * remote.c (remote_notif_stop_parse): Make "buf" const.
10717         (remote_target::remote_parse_stop_reply): Make "buf" const.
10718         (remote_notif_stop_ack): Make "buf" const.
10719
10720 2019-01-14  Tom Tromey  <tom@tromey.com>
10721
10722         * remote.c (remote_console_output): Make parameter const.
10723
10724 2019-01-14  Tom Tromey  <tom@tromey.com>
10725
10726         * target-debug.h (target_debug_print_signals): Constify.
10727         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10728         * procfs.c (procfs_target::pass_signals): Update.
10729         * linux-nat.c (linux_nat_target::pass_signals): Update.
10730         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10731         * target-delegates.c: Rebuild.
10732         * remote.c (remote_target::program_signals): Update.
10733         (remote_target::pass_signals): Update.
10734         * target.c (target_pass_signals): Constify argument.
10735         (target_program_signals): Likewise.
10736         * target.h (struct target_ops) <pass_signals, program_signals>:
10737         Constify argument.
10738         (target_pass_signals, target_program_signals): Constify argument.
10739
10740 2019-01-14  Tom Tromey  <tom@tromey.com>
10741
10742         PR tui/28819:
10743         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10744
10745 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10746
10747         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10748         field.
10749         * rs6000-tdep.c: Include reggroups.h.
10750         (IS_V_ALIAS_PSEUDOREG): Define.
10751         (rs6000_register_name): Return names for the "vX" aliases.
10752         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10753         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10754         aliases.  Call default_register_reggroup_p for all other
10755         pseudo-registers.
10756         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10757         New functions.
10758         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10759         Handle "vX" aliases.
10760         (v_alias_pseudo_register_collect): New function.
10761         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10762         (rs6000_gdbarch_init): Initialize "vX" aliases as
10763         pseudo-registers.  Restore registration of
10764         rs6000_pseudo_register_reggroup_p with
10765         set_tdesc_pseudo_register_reggroup_p.
10766
10767 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10768
10769         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10770         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10771         set_gdbarch_num_pseudo_regs.
10772
10773 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10774
10775         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10776         Remove arg prefixname, add do_set and do_show.
10777         Add member functions set_list and show_list.
10778         * cli/cli-style.c (class cli_style_option): Update accordingly.
10779         (style_set_list): Move to file scope.
10780         (style_show_list): Likewise.
10781         (set_style): Call help_list.
10782         (show_style): Call cmd_show_list.
10783         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10784         Update to use the new macro.
10785
10786 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10787
10788         * ada-lang.c (_initialize_ada_language): Expand the help text
10789         for the "catch exception" command.
10790
10791 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10792
10793         * symtab.c (matching_obj_sections): Initialize obj,
10794         declare it closer to its usage.
10795
10796 2019-01-10  Tom Tromey  <tom@tromey.com>
10797
10798         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10799         (basic_inf_threads_range): Remove.
10800         (inf_threads_range, inf_non_exited_threads_range)
10801         (safe_inf_threads_range): Use next_adapter.
10802
10803 2019-01-10  Keith Seitz  <keiths@redhat.com>
10804
10805         PR gdb/23712
10806         PR symtab/23010
10807         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10808         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10809
10810 2019-01-10  Keith Seitz  <keiths@redhat.com>
10811
10812         PR gdb/23712
10813         PR symtab/23010
10814         * dictionary.c (pending_to_vector): Remove.
10815         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10816         Remove _1 suffix, replacing functions of the same name.  Update
10817         all callers.
10818         (dict_create_hashed, dict_create_hashed_expandable)
10819         (dict_create_linear, dict_create_linear_expandable, dict_free)
10820         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10821         Make functions static.
10822
10823 2019-01-10  Keith Seitz  <keiths@redhat.com>
10824
10825         PR gdb/23712
10826         PR symtab/23010
10827         * dictionary.h (struct dictionary): Replace declaration with
10828         multidictionary.
10829         (dict_create_hashed, dict_create_hashed_expandable)
10830         (dict_create_linear, dict_create_linear_expandable)
10831         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10832         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10833         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10834         taking multidictionary argument.
10835         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10836         * block.h (struct block) <dict>: Change to multidictionary
10837         and rename `multidict'.
10838         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10839         symmisc.c: Update all dictionary references to multidictionary.
10840
10841 2019-01-10  Keith Seitz  <keiths@redhat.com>
10842
10843         PR gdb/23712
10844         PR symtab/23010
10845         * dictionary.c: Include unordered_map.
10846         (pending_to_vector): New function.
10847         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10848         Rewrite the non-"_1" functions to take vector instead
10849         of linked list.
10850         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10851         "new" _1 versions of the same name.
10852         (multidictionary): Define.
10853         (std::hash<enum language): New definition.
10854         (collate_pending_symbols_by_language, mdict_create_hashed)
10855         (mdict_create_hashed_expandable, mdict_create_linear)
10856         (mdict_create_linear_expandable, mdict_free)
10857         (find_language_dictionary, create_new_language_dictionary)
10858         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10859         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10860         (mdict_size, mdict_empty): New functions.
10861         * dictionary.h (mdict_iterator): Define.
10862
10863 2019-01-10  Pedro Alves  <palves@redhat.com>
10864
10865         * breakpoint.c (read_uploaded_action)
10866         (create_tracepoint_from_upload): Adjust to use
10867         gdb::unique_xmalloc_ptr.
10868         * ctf.c (ctf_write_uploaded_tp):
10869         (SET_ARRAY_FIELD): Use emplace_back.
10870         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10871         * tracefile-tfile.c (tfile_write_uploaded_tp):
10872         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10873         gdb::unique_xmalloc_ptr.
10874         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10875         at_string, cond_string, cmd_strings>: Replace char pointers
10876         with gdb::unique_xmalloc_ptr.
10877
10878 2019-01-10  Pedro Alves  <palves@redhat.com>
10879
10880         * solib-target.c (library_list_start_library): Don't xstrdup name.
10881
10882 2019-01-10  Pedro Alves  <palves@redhat.com>
10883
10884         * mdebugread.c (parse_partial_symbols): Use
10885         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10886
10887 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10888
10889         * linux-fork.c (scoped_switch_fork_info)
10890         <~scoped_switch_fork_info>: Fix incorrect variable name.
10891
10892 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10893
10894         * linux-fork.c (scoped_switch_fork_info)
10895         <scoped_switch_fork_info>: Make explicit.
10896         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10897
10898 2019-01-10  Tom Tromey  <tom@tromey.com>
10899
10900         * objfiles.h (objfile::reset_psymtabs): Update.
10901         * objfiles.c (objfile::objfile): Update.
10902         * psymtab.h (psymtab_storage::obstack): Update.
10903         (psymtab_storage::m_obstack): Use gdb::optional.
10904         (class psymtab_storage): Update comment.  Remove objfile
10905         parameter.
10906         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10907
10908 2019-01-10  Tom Tromey  <tom@tromey.com>
10909
10910         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10911         <free_psymtabs>: Now private.
10912         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10913         (allocate_psymtab): Use new method.
10914
10915 2019-01-10  Tom Tromey  <tom@tromey.com>
10916
10917         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10918         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10919         * mdebugread.c (parse_partial_symbols): Use
10920         allocate_dependencies.
10921         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10922         allocate_dependencies.
10923         (process_psymtab_comp_unit_reader)
10924         (build_type_psymtab_dependencies): Likewise.
10925         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10926
10927 2019-01-10  Tom Tromey  <tom@tromey.com>
10928
10929         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10930         PSYMBOL_SET_LANGUAGE.
10931         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10932
10933 2019-01-10  Tom Tromey  <tom@tromey.com>
10934
10935         * psymtab.h (psymtab_storage::obstack): New method.
10936         <m_obstack>: Rename from obstack; now private.
10937         * psymtab.c (psymtab_storage): Update.
10938         * dwarf2read.c (create_addrmap_from_index)
10939         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10940         Update.
10941
10942 2019-01-10  Tom Tromey  <tom@tromey.com>
10943
10944         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10945         * objfiles.h (objfile::reset_psymtabs): New method.
10946
10947 2019-01-10  Tom Tromey  <tom@tromey.com>
10948
10949         * symmisc.c (print_symbol_bcache_statistics): Update.
10950         (print_objfile_statistics): Update.
10951         * symfile.c (reread_symbols): Update.
10952         * psymtab.h (class psymtab_storage): New.
10953         * psymtab.c (psymtab_storage): New constructor.
10954         (~psymtab_storage): New destructor.
10955         (require_partial_symbols): Update.
10956         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10957         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10958         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10959         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10960         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10961         (start_psymtab_common, end_psymtab_common)
10962         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10963         (allocate_psymtab): Update.
10964         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10965         Update.
10966         (dump_psymtab_addrmap, maintenance_print_psymbols)
10967         (maintenance_check_psymtabs): Update.
10968         (class objfile_psymtabs): Move to objfiles.h.
10969         * psympriv.h (discard_psymtab): Now inline.
10970         (psymtab_discarder::psymtab_discarder): Update.
10971         (psymtab_discarder::~psymtab_discarder): Update.
10972         (ALL_OBJFILE_PSYMTABS): Rewrite.
10973         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10974         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10975         Remove fields.
10976         <partial_symtabs>: New field.
10977         (class objfile_psymtabs): Move from psymtab.h.  Update.
10978         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10979         psymbol_cache.
10980         (objfile::~objfile): Don't destroy psymbol_cache.
10981         * mdebugread.c (parse_partial_symbols): Update.
10982         * dwarf2read.c (create_addrmap_from_index)
10983         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10984         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10985         (add_partial_subprogram, dwarf2_ranges_read): Update.
10986         * dwarf-index-write.c (write_address_map)
10987         (write_one_signatured_type, recursively_write_psymbols)
10988         (class debug_names, class debug_names, write_psymtabs_to_index):
10989         Update.
10990
10991 2019-01-10  Tom Tromey  <tom@tromey.com>
10992
10993         * symtab.h (SYMBOL_SET_NAMES): Update.
10994         (symbol_set_names): Update.
10995         (MSYMBOL_SET_NAMES): Update.
10996         * symtab.c (symbol_set_names): Change argument to be an
10997         objfile_per_bfd_storage.
10998         * psymtab.c (add_psymbol_to_bcache): Update.
10999         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11000
11001 2019-01-10  Tom Tromey  <tom@tromey.com>
11002
11003         * symtab.c (create_demangled_names_hash): Change argument to be an
11004         objfile_per_bfd_storage.
11005         (symbol_set_names): Update.
11006
11007 2019-01-10  Tom Tromey  <tom@tromey.com>
11008
11009         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11010         init_psymbol_list.
11011         * psymtab.c (init_psymbol_list): Do nothing if already called.
11012         * psympriv.h (init_psymbol_list): Add comment.
11013         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11014         init_psymbol_list.
11015         * dbxread.c (dbx_symfile_read): Unconditionally call
11016         init_psymbol_list.
11017
11018 2019-01-10  Tom Tromey  <tom@tromey.com>
11019
11020         * xcoffread.c (scan_xcoff_symtab): Update.
11021         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11022         "where".
11023         * mdebugread.c (parse_partial_symbols)
11024         (handle_psymbol_enumerators): Update.
11025         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11026         * dbxread.c (read_dbx_symtab): Update.
11027         * psympriv.h (psymbol_placement): New enum.
11028         (add_psymbol_to_list): Update.
11029
11030 2019-01-10  Tom Tromey  <tom@tromey.com>
11031
11032         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11033         static_psymbols parameters.
11034         (scan_xcoff_symtab): Update.
11035         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11036         static_psymbols parameters.
11037         * psympriv.h (start_psymtab_common): Update.
11038         * mdebugread.c (parse_partial_symbols): Update.
11039         * dwarf2read.c (create_partial_symtab): Update.
11040         * dbxread.c (read_dbx_symtab): Update.
11041         (start_psymtab): Remove global_psymbols and static_psymbols
11042         parameters.
11043
11044 2019-01-10  Tom Tromey  <tom@tromey.com>
11045
11046         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11047         * psymtab.c (allocate_psymtab): Add comment.
11048         * psympriv.h (allocate_psymtab): Add comment.
11049         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11050         initializations.
11051         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11052
11053 2019-01-10  Tom Tromey  <tom@tromey.com>
11054
11055         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11056         Don't declare.
11057         * mipsread.c: Include mdebugread.h.
11058         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11059         Declare.
11060         * elfread.c: Include mdebugread.h.
11061
11062 2019-01-09  Tom Tromey  <tom@tromey.com>
11063
11064         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11065         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11066         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11067         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11068         (psym_lookup_symbol, psym_find_last_source_symtab)
11069         (psym_forget_cached_source_info, psym_print_stats)
11070         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11071         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11072         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11073         (psym_find_compunit_symtab_by_address)
11074         (maintenance_print_psymbols, maintenance_info_psymtabs)
11075         (maintenance_check_psymtabs): Use ranged for.
11076         * psymtab.h (class objfile_psymtabs): New.
11077         (require_partial_symbols): Return objfile_psymtabs.
11078         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11079
11080 2019-01-09  Tom Tromey  <tom@tromey.com>
11081
11082         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11083         (find_pc_mapped_section, list_overlays_command)
11084         (map_overlay_command, unmap_overlay_command)
11085         (simple_overlay_update): Use all_objfiles.
11086         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11087         * printcmd.c (info_symbol_command): Use all_objfiles.
11088         * objfiles.h (ALL_OBJSECTIONS): Remove.
11089         * maint.c (maintenance_translate_address): Use all_objfiles.
11090         * gcore.c (gcore_create_callback): Use all_objfiles.
11091         (objfile_find_memory_regions): Likewise.
11092
11093 2019-01-09  Tom Tromey  <tom@tromey.com>
11094
11095         * symtab.c (find_line_symtab, info_sources_command)
11096         (make_source_files_completion_list): Use objfile_compunits.
11097         * source.c (select_source_symtab): Use objfile_compunits.
11098         * objfiles.h (struct objfile): Update comment.
11099         (ALL_OBJFILES): Remove.
11100         (ALL_FILETABS): Remove.
11101         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11102         objfile_compunits.
11103
11104 2019-01-09  Tom Tromey  <tom@tromey.com>
11105
11106         * symmisc.c (print_objfile_statistics, dump_objfile)
11107         (maintenance_print_symbols): Use compunit_filetabs.
11108         * source.c (forget_cached_source_info_for_objfile): Use
11109         compunit_filetabs.
11110         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11111         (ALL_FILETABS): Use compunit_filetabs.
11112         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11113         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11114
11115 2019-01-09  Tom Tromey  <tom@tromey.com>
11116
11117         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11118         (compunit_filetabs): New.
11119         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11120         compunit_filetabs.
11121         (info_sources_command, make_source_files_completion_list): Remove
11122         declaration.
11123         * symmisc.c (print_objfile_statistics, dump_objfile)
11124         (maintenance_print_symbols): Remove declaration.
11125         (maintenance_info_symtabs): Use compunit_filetabs.
11126         (maintenance_info_line_tables): Likewise.
11127         * source.c (select_source_symtab): Change local variable name.
11128         (forget_cached_source_info_for_objfile): Remove declaration.
11129         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11130         * objfiles.c (objfile_relocate1): Remove declaration.
11131         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11132         declaration.
11133         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11134         * coffread.c (coff_symtab_read): Remove declaration.
11135         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11136         compunit_filetabs.
11137
11138 2019-01-09  Tom Tromey  <tom@tromey.com>
11139
11140         * symtab.c (lookup_objfile_from_block)
11141         (find_pc_sect_compunit_symtab, search_symbols)
11142         (default_collect_symbol_completion_matches_break_on): Use
11143         objfile_compunits.
11144         * objfiles.h (ALL_COMPUNITS): Remove.
11145         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11146         * cp-support.c (add_symbol_overload_list_qualified): Use
11147         objfile_compunits.
11148         * ada-lang.c (ada_collect_symbol_completion_matches)
11149         (ada_add_global_exceptions): Use objfile_compunits.
11150
11151 2019-01-09  Tom Tromey  <tom@tromey.com>
11152
11153         * source.c (select_source_symtab)
11154         (forget_cached_source_info_for_objfile): Remove declaration.
11155         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11156         declaration.
11157         * maint.c (count_symtabs_and_blocks): Remove declaration.
11158         * cp-support.c (add_symbol_overload_list_qualified): Remove
11159         declaration.
11160         * coffread.c (coff_symtab_read): Remove declaration.
11161         * symtab.c (lookup_symbol_in_objfile_symtabs)
11162         (basic_lookup_transparent_type_1): Use objfile_compunits.
11163         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11164         (info_sources_command, search_symbols)
11165         (default_collect_symbol_completion_matches_break_on)
11166         (make_source_files_completion_list): Remove declaration.
11167         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11168         (ada_collect_symbol_completion_matches)
11169         (ada_add_global_exceptions): Remove declaration.
11170         * linespec.c (iterate_over_all_matching_symtabs): Use
11171         objfile_compunits.
11172         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11173         (class objfile_compunits): New.
11174         (ALL_COMPUNITS): Use objfile_compunits.
11175         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11176         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11177         objfile_compunits.
11178         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11179
11180 2019-01-09  Tom Tromey  <tom@tromey.com>
11181
11182         * symtab.c (search_symbols)
11183         (default_collect_symbol_completion_matches_break_on): Use
11184         objfile_msymbols.
11185         * ada-lang.c (ada_lookup_simple_minsym)
11186         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11187         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11188         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11189         objfile_msymbols.
11190         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11191         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11192         * objc-lang.c (find_methods): Use objfile_msymbols.
11193         (info_selectors_command, info_classes_command): Likewise.
11194         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11195         * objfiles.h (class objfile_msymbols): New.
11196         (ALL_OBJFILE_MSYMBOLS): Remove.
11197         (ALL_MSYMBOLS): Remove.
11198
11199 2019-01-09  Tom Tromey  <tom@tromey.com>
11200
11201         * common/next-iterator.h (next_adapter): Add Iterator template
11202         parameter.
11203         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11204         (class all_objfiles_safe): New.
11205         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11206         * objfiles.c (put_objfile_before): Update comment.
11207         (add_separate_debug_objfile): Likewise.
11208         (free_all_objfiles): Use all_objfiles_safe.
11209         (objfile_purge_solibs): Likewise.
11210
11211 2019-01-09  Tom Tromey  <tom@tromey.com>
11212
11213         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11214         (expand_symtab_containing_pc, lookup_static_symbol)
11215         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11216         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11217         all_objfiles.
11218         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11219         * breakpoint.c (create_overlay_event_breakpoint)
11220         (create_longjmp_master_breakpoint)
11221         (create_std_terminate_master_breakpoint)
11222         (create_exception_master_breakpoint): Use all_objfiles.
11223         * linux-thread-db.c (try_thread_db_load_from_pdir)
11224         (has_libpthread): Use all_objfiles.
11225         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11226         * linespec.c (iterate_over_all_matching_symtabs)
11227         (search_minsyms_for_name): Use all_objfiles.
11228         * maint.c (maintenance_info_sections): Use all_objfiles.
11229         * main.c (captured_main_1): Use all_objfiles.
11230         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11231         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11232         * guile/scm-pretty-print.c
11233         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11234         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11235         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11236         (maintenance_print_msymbols): Use all_objfiles.
11237         * source.c (select_source_symtab): Use all_objfiles.
11238         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11239         * symfile.c (remove_symbol_file_command)
11240         (expand_symtabs_matching, map_symbol_filenames): Use
11241         all_objfiles.
11242         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11243         all_objfiles.
11244         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11245         * objc-lang.c (find_methods): Use all_objfiles.
11246         * objfiles.c (have_partial_symbols, have_full_symbols)
11247         (have_minimal_symbols, qsort_cmp)
11248         (default_iterate_over_objfiles_in_search_order): Use
11249         all_objfiles.
11250         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11251         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11252         (maintenance_check_psymtabs): Use all_objfiles.
11253         (ALL_PSYMTABS): Remove.
11254         * compile/compile-object-run.c (do_module_cleanup): Use
11255         all_objfiles.
11256         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11257         * cp-support.c (add_symbol_overload_list_qualified): Use
11258         all_objfiles.
11259         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11260         Use all_objfiles.
11261         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11262         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11263         all_objfiles.
11264         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11265         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11266         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11267         Uses all_objfiles.
11268         * solib.c (solib_read_symbols): Use all_objfiles
11269
11270 2019-01-09  Tom Tromey  <tom@tromey.com>
11271
11272         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11273         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11274         all_objfiles.
11275         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11276         * symmisc.c (print_symbol_bcache_statistics)
11277         (print_objfile_statistics, maintenance_print_objfiles)
11278         (maintenance_info_symtabs, maintenance_check_symtabs)
11279         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11280         all_objfiles.
11281         * source.c (forget_cached_source_info): Use all_objfiles.
11282         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11283         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11284         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11285         * objfiles.c (update_section_map): Use all_objfiles.
11286         (shared_objfile_contains_address_p): Likewise.
11287         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11288         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11289
11290 2019-01-09  Tom Tromey  <tom@tromey.com>
11291
11292         * common/next-iterator.h: New file.
11293         * objfiles.h (class all_objfiles): New.
11294         (struct objfile_iterator): New.
11295
11296 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11297
11298         * NEWS: Move the description of the changed "frame", "select-frame",
11299          and "info frame" commands to the Changed commands section.
11300
11301 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11302
11303         * gdbtypes.c (check_stub_method_group): Remove handling of old
11304         mangling schemes.
11305         * linespec.c (find_methods): Likewise.
11306         * stabsread.c (read_member_functions): Likewise.
11307         * valops.c (search_struct_method): Likewise.
11308         (value_struct_elt_for_reference): Likewise.
11309         * NEWS: Mention this change.
11310
11311 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11312
11313         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11314         print_source_lines.
11315         * source.c (print_source_lines_base): Update line number check.
11316         (print_source_lines): New function.
11317         (source_lines_range::source_lines_range): New function.
11318         * source.h (class source_lines_range): New class.
11319         (print_source_lines): New declaration.
11320
11321 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11322
11323         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11324
11325 2019-01-08  Tom Tromey  <tom@tromey.com>
11326             Simon Marchi  <simon.marchi@ericsson.com>
11327
11328         PR gdb/24060
11329         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11330         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11331         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11332         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11333         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11334         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11335
11336 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11337
11338         * source.c (select_source_symtab): Move header comment to
11339         declaration in source.h.
11340         (forget_cached_source_info_for_objfile): Likewise.
11341         (forget_cached_source_info): Likewise.
11342         (identify_source_line): Likewise.
11343         * source.h (identify_source_line): Move declaration from symtab.h
11344         and add comment from source.c
11345         (print_source_lines): Likewise.
11346         (forget_cached_source_info_for_objfile): Likewise.
11347         (forget_cached_source_info): Likewise.
11348         (select_source_symtab): Likewise.
11349         (enum print_source_lines_flag): Move definition from symtab.h.
11350         * symtab.h (identify_source_line): Move declaration to source.h.
11351         (print_source_lines): Likewise.
11352         (forget_cached_source_info_for_objfile): Likewise.
11353         (forget_cached_source_info): Likewise.
11354         (select_source_symtab): Likewise.
11355         (enum print_source_lines_flag): Move definition to source.h.
11356         * tui/tui-hooks.c: Add 'source.h' include.
11357
11358 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11359
11360         * source.c (print_source_lines_base): Handle requests to print
11361         reverse line number sequences, and guard against empty lines
11362         string.
11363
11364 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11365
11366         * source.c (print_source_lines_base): Fix skip of '\r' if next
11367         character is '\n'.
11368
11369 2019-01-06  Tom Tromey  <tom@tromey.com>
11370
11371         * c-exp.y (struct c_parse_state) <macro_original_text,
11372         expansion_obstack>: New member.
11373         (macro_original_text, expansion_obstack): Remove globals.
11374         (scan_macro_expansion, scanning_macro_expansion)
11375         (finished_macro_expansion): Update.
11376         (scan_macro_cleanup): Remove.
11377         (yylex, c_parse): Update.
11378
11379 2019-01-06  Tom Tromey  <tom@tromey.com>
11380
11381         * c-exp.y (struct c_parse_state) <strings>: New member.
11382         (operator_stoken): Update.
11383
11384 2019-01-06  Tom Tromey  <tom@tromey.com>
11385
11386         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11387         (union type_stack_elt) <typelist_val>: Now a pointer to
11388         std::vector.
11389         (type_stack_cleanup): Don't declare.
11390         (push_typelist): Update.
11391         * parse.c (pop_typelist): Return a std::vector.
11392         (push_typelist): Take a std::vector.
11393         (follow_types): Update.  Do not free args.
11394         (type_stack_cleanup): Remove.
11395         * c-exp.y (struct c_parse_state): New.
11396         (cpstate): New global.
11397         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11398         (nonempty_typelist): Update.
11399         (func_mod): Create a new vector.
11400         (c_parse): Create a c_parse_state.
11401         (check_parameter_typelist): Do not delete params.
11402         (function_method): Update.  Do not delete type_list.
11403
11404 2019-01-06  Tom Tromey  <tom@tromey.com>
11405
11406         PR gdb/28155:
11407         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11408         check_typedef.
11409         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11410         (print_return_value): Likewise.
11411
11412 2019-01-05  Tom Tromey  <tom@tromey.com>
11413
11414         * contrib/cleanup_check.py: Remove.
11415         * contrib/gcc-with-excheck: Remove.
11416         * contrib/exsummary.py: Remove.
11417         * contrib/excheck.py: Remove.
11418
11419 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11420
11421         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11422         NULL. Initialize tpprev to NULL instead of assigning it
11423         to NULL on the next statement.
11424         * windows-nat.c (windows_delete_thread): Remove check for
11425         main_thread_id before printing thread exit notifications.
11426         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11427         Remove thread ID check against main_thread_id.
11428         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11429         windows_delete_thread.
11430         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11431
11432 2019-01-04  Tom Tromey  <tom@tromey.com>
11433
11434         * compile/compile.c (_initialize_compile): Use upper case for
11435         metasyntactic variables.
11436         * symmisc.c (_initialize_symmisc): Use upper case for
11437         metasyntactic variables.
11438         * psymtab.c (_initialize_psymtab): Use upper case for
11439         metasyntactic variables.
11440         * demangle.c (demangle_command): Use upper case for metasyntactic
11441         variables.
11442         (_initialize_demangler): Likewise.
11443         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11444         variables.
11445
11446 2019-01-03  Tom Tromey  <tom@tromey.com>
11447
11448         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11449
11450 2019-01-03  Tom Tromey  <tom@tromey.com>
11451
11452         * python/py-symtab.c (salpy_str): Update.
11453         (struct salpy_sal_object) <symtab>: Now a PyObject.
11454         (salpy_dealloc): Update.
11455         (del_objfile_sal): Use gdbpy_ref.
11456
11457 2019-01-03  Tom Tromey  <tom@tromey.com>
11458
11459         * python/py-type.c (convert_field): Use new_reference.  Return
11460         gdbpy_ref.
11461         (make_fielditem): Return gdbpy_ref.
11462         (typy_fields): Update.
11463         (typy_getitem): Update.
11464         (field_name): Return gdbpy_ref.  Use new_reference.
11465         (typy_iterator_iternext): Update.
11466
11467 2019-01-03  Tom Tromey  <tom@tromey.com>
11468
11469         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11470
11471 2019-01-03  Tom Tromey  <tom@tromey.com>
11472
11473         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11474         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11475         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11476         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11477         (pspy_set_type_printers): Likewise.
11478         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11479         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11480         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11481         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11482         (objfpy_set_type_printers): Likewise.
11483
11484 2019-01-03  Tom Tromey  <tom@tromey.com>
11485
11486         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11487         (gdbpy_print_stack): Use gdbpy_err_fetch.
11488         * python/python-internal.h (class gdbpy_err_fetch): New class.
11489         (class gdbpy_enter) <m_error_type, m_error_value,
11490         m_error_traceback>: Remove.
11491         <m_error>: New member.
11492         (gdbpy_exception_to_string): Don't declare.
11493         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11494         * python/py-value.c (convert_value_from_python): Use
11495         gdbpy_err_fetch.
11496         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11497         gdbpy_exception_to_string.
11498         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11499         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11500         gdbpy_err_fetch.
11501
11502 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11503
11504         * linux-nat.c (delete_lwp_cleanup): Delete.
11505         (struct lwp_deleter): New struct.
11506         (lwp_info_up): New typedef.
11507         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11508         lwp_info_up.
11509
11510 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11511
11512         * linux-fork.c (class scoped_switch_fork_info): New class.
11513         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11514
11515 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11516
11517         * valops.c (find_overload_match): Remove use of null_cleanup, and
11518         calls to do_cleanups.
11519
11520 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11521
11522         * compile/compile-cplus-types.c
11523         (compile_cplus_instance::decl_name): Handle changes to
11524         cp_func_name.
11525         * cp-support.c (cp_func_name): Update header comment, update
11526         return type.
11527         * cp-support.h (cp_func_name): Update return type in declaration.
11528         * valops.c (find_overload_match): Move temp_func local to top
11529         level of function and change its type.  Use temp_func to hold and
11530         delete temporary string obtained from cp_func_name.
11531
11532 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11533
11534         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11535         gdb::char_vector, remove cleanup, and update uses of `msg`.
11536
11537 2019-01-03  Jim Wilson  <jimw@sifive.com>
11538
11539         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11540
11541 2019-01-02  Tom Tromey  <tom@tromey.com>
11542
11543         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11544         (tdesc_parse_xml): Remove cleanups.
11545         * target-descriptions.h (make_cleanup_free_target_description):
11546         Don't declare.
11547         (target_desc_deleter): New struct.
11548         (target_desc_up): New typedef.
11549         * target-descriptions.c (target_desc_deleter::operator()): Rename
11550         from free_target_description.
11551         (make_cleanup_free_target_description): Remove.
11552
11553 2019-01-02  Tom Tromey  <tom@tromey.com>
11554
11555         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11556         constructor, destructor.
11557         (linespec_parser): Remove typedef.
11558         (~linespec_parser): Rename from linespec_parser_delete.
11559         (linespec_lex_to_end, linespec_complete_label)
11560         (linespec_complete): Update.
11561         (decode_line_full): Remove cleanups.
11562         (decode_line_1): Update.
11563
11564 2019-01-02  Tom Tromey  <tom@tromey.com>
11565
11566         * python/python-internal.h (inferior_to_inferior_object): Change
11567         return type.
11568         * python/py-exitedevent.c (create_exited_event_object): Update.
11569         * python/py-inferior.c (inferior_to_inferior_object): Return
11570         gdbpy_ref.
11571         (python_new_inferior, python_inferior_deleted)
11572         (thread_to_thread_object, delete_thread_object)
11573         (build_inferior_list, gdbpy_selected_inferior): Update.
11574         * python/py-infthread.c (create_thread_object): Update.  Also fail
11575         if inferior_to_inferior_object fails.
11576
11577 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11578
11579         * inferior.h (class inferior) <displaced_step_state>: New field.
11580         * infrun.h (struct displaced_step_state): Move here from
11581         infrun.c.  Initialize fields, add constructor.
11582         <inf>: Remove field.
11583         <reset>: New method.
11584         * infrun.c (struct displaced_step_inferior_state): Move to
11585         infrun.h.
11586         (displaced_step_inferior_states): Remove.
11587         (get_displaced_stepping_state): Adust.
11588         (displaced_step_in_progress_any_inferior): Adjust.
11589         (displaced_step_in_progress_thread): Adjust.
11590         (displaced_step_in_progress): Adjust.
11591         (add_displaced_stepping_state): Remove.
11592         (get_displaced_step_closure_by_addr): Adjust.
11593         (remove_displaced_stepping_state): Remove.
11594         (infrun_inferior_exit): Call displaced_step_state.reset.
11595         (use_displaced_stepping): Don't check for NULL.
11596         (displaced_step_prepare_throw): Call
11597         get_displaced_stepping_state.
11598         (displaced_step_fixup): Don't check for NULL.
11599         (prepare_for_detach): Don't check for NULL.
11600
11601 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11602
11603         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11604          in case of call that did not complete.
11605
11606 2019-01-02  Andrey Utkin  <autkin@undo.io>
11607
11608         * symfile.c (find_separate_debug_file): Fix search of debug files for
11609         remote debuggee.
11610
11611 2019-01-02  Tom Tromey  <tom@tromey.com>
11612
11613         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11614         indentation.
11615         * python/py-frame.c (frapy_older): Remove cast.
11616         (frapy_newer): Likewise.
11617         * python/py-breakpoint.c (local_setattro): Remove cast.
11618         * python/py-arch.c (archpy_name): Remove local variable.
11619         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11620
11621 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11622
11623         * unittests/basic_string_view/element_access/char/empty.cc:
11624         Fix year range in copyright header.
11625
11626 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11627
11628         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11629         Delete.
11630         <operator==>: Update with for removed field.
11631         <hash>: Likewise.
11632         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11633         <isa_features>: ...this.
11634         <abi_features>: New field.
11635         (riscv_isa_flen): Update comment.
11636         (riscv_abi_xlen): New declaration.
11637         (riscv_abi_flen): New declaration.
11638         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11639         isa_features.
11640         (riscv_abi_xlen): New function.
11641         (riscv_isa_flen): Update to get answer from isa_features.
11642         (riscv_abi_flen): New function.
11643         (riscv_has_fp_abi): Update to get answer from abi_features.
11644         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11645         xlen and flen.
11646         (riscv_call_info) <xlen, flen>: Update comment.
11647         (riscv_call_arg_struct): Remove invalid assertions
11648         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11649         is removed.
11650         (riscv_gdbarch_init): Gather isa features and abi features
11651         separately, ensure both match on the gdbarch when reusing an old
11652         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11653         a target with 64-bit float hardware.
11654
11655 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11656
11657         * source.c (search_command_helper): Stop reverse search
11658         when line 1 has been searched.
11659
11660 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11661
11662         * record-full.c (record_full_base_target::close): Rewrite
11663         record_full_core_buf_list free logic.
11664
11665 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11666
11667         * break-catch-syscall.c (print_one_catch_syscall): xfree
11668         the last text.
11669
11670 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11671
11672         * top.c (print_gdb_version): Update Copyright year in version
11673         message.
11674
11675 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11676
11677         Update copyright year range in all GDB files.
11678
11679 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11680
11681         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11682
11683 For older changes see ChangeLog-2018.
11684 \f
11685 Local Variables:
11686 mode: change-log
11687 left-margin: 8
11688 fill-column: 74
11689 version-control: never
11690 coding: utf-8
11691 End:
11692